blob: 62bbf245f8f260767125adda6d287255b6378109 [file] [log] [blame]
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001/*
kjellander1afca732016-02-07 20:46:45 -08002 * Copyright (c) 2004 The WebRTC project authors. All Rights Reserved.
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003 *
kjellander1afca732016-02-07 20:46:45 -08004 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00009 */
10
Jonas Olssona4d87372019-07-05 19:08:33 +020011#include "media/engine/webrtc_video_engine.h"
12
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000013#include <map>
kwiberg686a8ef2016-02-26 03:00:35 -080014#include <memory>
Elad Alon040dc432019-05-22 15:40:02 +020015#include <string>
Steve Antone78bcb92017-10-31 09:53:08 -070016#include <utility>
pbos@webrtc.org86f613d2014-06-10 08:53:05 +000017#include <vector>
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000018
Steve Anton2c9ebef2019-01-28 17:27:58 -080019#include "absl/algorithm/container.h"
Niels Möller805a27e2019-01-21 12:21:27 +010020#include "absl/memory/memory.h"
Niels Möller039743e2018-10-23 10:07:25 +020021#include "absl/strings/match.h"
Danil Chapovalov83bbe912019-08-07 12:24:53 +020022#include "api/rtc_event_log/rtc_event_log.h"
Steve Anton10542f22019-01-11 09:11:00 -080023#include "api/rtp_parameters.h"
Danil Chapovalov53d45ba2019-07-03 14:56:33 +020024#include "api/task_queue/default_task_queue_factory.h"
Piotr (Peter) Slatala946b9682019-03-18 10:25:02 -070025#include "api/test/fake_media_transport.h"
Jiawei Ouc2ebe212018-11-08 10:02:56 -080026#include "api/test/mock_video_bitrate_allocator.h"
27#include "api/test/mock_video_bitrate_allocator_factory.h"
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -070028#include "api/test/mock_video_decoder_factory.h"
29#include "api/test/mock_video_encoder_factory.h"
Niels Möller65f17ca2019-09-12 13:59:36 +020030#include "api/transport/media/media_transport_config.h"
Jonas Oreland49ac5952018-09-26 16:04:32 +020031#include "api/units/time_delta.h"
Jiawei Ouc2ebe212018-11-08 10:02:56 -080032#include "api/video/builtin_video_bitrate_allocator_factory.h"
Niels Möller805a27e2019-01-21 12:21:27 +010033#include "api/video/i420_buffer.h"
Åsa Persson23eba222018-10-02 14:47:06 +020034#include "api/video/video_bitrate_allocation.h"
Anders Carlsson5f2bb622018-05-14 09:48:06 +020035#include "api/video_codecs/builtin_video_decoder_factory.h"
36#include "api/video_codecs/builtin_video_encoder_factory.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020037#include "api/video_codecs/sdp_video_format.h"
38#include "api/video_codecs/video_decoder_factory.h"
39#include "api/video_codecs/video_encoder.h"
40#include "api/video_codecs/video_encoder_factory.h"
41#include "call/flexfec_receive_stream.h"
42#include "common_video/h264/profile_level_id.h"
Niels Möller805a27e2019-01-21 12:21:27 +010043#include "media/base/fake_frame_source.h"
Steve Anton10542f22019-01-11 09:11:00 -080044#include "media/base/fake_network_interface.h"
Steve Anton10542f22019-01-11 09:11:00 -080045#include "media/base/fake_video_renderer.h"
46#include "media/base/media_constants.h"
47#include "media/base/rtp_utils.h"
48#include "media/base/test_utils.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020049#include "media/engine/constants.h"
Steve Anton10542f22019-01-11 09:11:00 -080050#include "media/engine/fake_webrtc_call.h"
51#include "media/engine/fake_webrtc_video_engine.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020052#include "media/engine/simulcast.h"
Steve Anton10542f22019-01-11 09:11:00 -080053#include "media/engine/webrtc_voice_engine.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020054#include "rtc_base/arraysize.h"
Elad Alon80f53b72019-10-11 16:19:43 +020055#include "rtc_base/experiments/min_video_bitrate_experiment.h"
Steve Anton10542f22019-01-11 09:11:00 -080056#include "rtc_base/fake_clock.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020057#include "rtc_base/gunit.h"
Yves Gerey665174f2018-06-19 15:03:05 +020058#include "rtc_base/numerics/safe_conversions.h"
Steve Antonf3802842019-01-24 19:07:40 -080059#include "rtc_base/time_utils.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020060#include "test/field_trial.h"
Niels Möllerd0f0f682019-01-14 09:09:53 +010061#include "test/frame_generator.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020062#include "test/gmock.h"
Tommi25eb47c2019-08-29 16:39:05 +020063#include "test/rtp_header_parser.h"
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000064
philipeld9cc8c02019-09-16 14:53:40 +020065using ::testing::Contains;
66using ::testing::Eq;
Mirko Bonadei6a489f22019-04-09 15:11:12 +020067using ::testing::Field;
Chen Xing90f3b892019-06-25 10:16:14 +020068using ::testing::IsEmpty;
philipeld9cc8c02019-09-16 14:53:40 +020069using ::testing::Pair;
Chen Xing90f3b892019-06-25 10:16:14 +020070using ::testing::SizeIs;
Sebastian Jansson8f83b422018-02-21 13:07:13 +010071using webrtc::BitrateConstraints;
isheriff6f8d6862016-05-26 11:24:55 -070072using webrtc::RtpExtension;
73
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000074namespace {
buildbot@webrtc.orga8530772014-12-10 09:01:18 +000075static const int kDefaultQpMax = 56;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +000076
noahricd10a68e2015-07-10 11:27:55 -070077static const uint8_t kRedRtxPayloadType = 125;
78
Niels Möller6557d0c2018-04-11 15:18:34 +020079static const uint32_t kTimeout = 5000U;
80static const uint32_t kDefaultReceiveSsrc = 0;
81static const uint32_t kSsrc = 1234u;
82static const uint32_t kSsrcs4[] = {1, 2, 3, 4};
83static const int kVideoWidth = 640;
84static const int kVideoHeight = 360;
85static const int kFramerate = 30;
86
Peter Boström0c4e06b2015-10-07 12:23:21 +020087static const uint32_t kSsrcs1[] = {1};
88static const uint32_t kSsrcs3[] = {1, 2, 3};
89static const uint32_t kRtxSsrcs1[] = {4};
brandtr468da7c2016-11-22 02:16:47 -080090static const uint32_t kFlexfecSsrc = 5;
Peter Boström0c4e06b2015-10-07 12:23:21 +020091static const uint32_t kIncomingUnsignalledSsrc = 0xC0FFEE;
mzanaty8a855d62017-02-17 15:46:43 -080092static const uint32_t kDefaultRecvSsrc = 0;
93
Bjorn A Mellemda4f0932019-07-30 08:34:03 -070094constexpr uint32_t kRtpHeaderSize = 12;
95
pbos@webrtc.org3c107582014-07-20 15:27:35 +000096static const char kUnsupportedExtensionName[] =
97 "urn:ietf:params:rtp-hdrext:unsupported";
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000098
magjed509e4fe2016-11-18 01:34:11 -080099cricket::VideoCodec RemoveFeedbackParams(cricket::VideoCodec&& codec) {
100 codec.feedback_params = cricket::FeedbackParams();
Mirko Bonadei29a8d102018-04-25 23:58:26 +0200101 return std::move(codec);
magjed509e4fe2016-11-18 01:34:11 -0800102}
103
Elad Alonfadb1812019-05-24 13:40:02 +0200104void VerifyCodecHasDefaultFeedbackParams(const cricket::VideoCodec& codec,
105 bool lntf_expected) {
106 EXPECT_EQ(lntf_expected,
107 codec.HasFeedbackParam(cricket::FeedbackParam(
108 cricket::kRtcpFbParamLntf, cricket::kParamValueEmpty)));
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +0000109 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
110 cricket::kRtcpFbParamNack, cricket::kParamValueEmpty)));
111 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
112 cricket::kRtcpFbParamNack, cricket::kRtcpFbNackParamPli)));
113 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
114 cricket::kRtcpFbParamRemb, cricket::kParamValueEmpty)));
115 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
stefan43edf0f2015-11-20 18:05:48 -0800116 cricket::kRtcpFbParamTransportCc, cricket::kParamValueEmpty)));
117 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +0000118 cricket::kRtcpFbParamCcm, cricket::kRtcpFbCcmParamFir)));
119}
120
magjed725e4842016-11-16 00:48:13 -0800121// Return true if any codec in |codecs| is an RTX codec with associated payload
122// type |payload_type|.
123bool HasRtxCodec(const std::vector<cricket::VideoCodec>& codecs,
124 int payload_type) {
125 for (const cricket::VideoCodec& codec : codecs) {
126 int associated_payload_type;
Niels Möller039743e2018-10-23 10:07:25 +0200127 if (absl::EqualsIgnoreCase(codec.name.c_str(), "rtx") &&
magjed725e4842016-11-16 00:48:13 -0800128 codec.GetParam(cricket::kCodecParamAssociatedPayloadType,
129 &associated_payload_type) &&
130 associated_payload_type == payload_type) {
131 return true;
132 }
133 }
134 return false;
135}
136
nisseca5706d2017-09-11 02:32:16 -0700137// TODO(nisse): Duplicated in call.cc.
138const int* FindKeyByValue(const std::map<int, int>& m, int v) {
139 for (const auto& kv : m) {
140 if (kv.second == v)
141 return &kv.first;
142 }
143 return nullptr;
144}
145
Yves Gerey665174f2018-06-19 15:03:05 +0200146bool HasRtxReceiveAssociation(const webrtc::VideoReceiveStream::Config& config,
147 int payload_type) {
nisseca5706d2017-09-11 02:32:16 -0700148 return FindKeyByValue(config.rtp.rtx_associated_payload_types,
149 payload_type) != nullptr;
150}
151
152// Check that there's an Rtx payload type for each decoder.
153bool VerifyRtxReceiveAssociations(
154 const webrtc::VideoReceiveStream::Config& config) {
155 for (const auto& decoder : config.decoders) {
156 if (!HasRtxReceiveAssociation(config, decoder.payload_type))
157 return false;
158 }
159 return true;
160}
161
brandtrffc61182016-11-28 06:02:22 -0800162rtc::scoped_refptr<webrtc::VideoFrameBuffer> CreateBlackFrameBuffer(
nisse64ec8f82016-09-27 00:17:25 -0700163 int width,
164 int height) {
165 rtc::scoped_refptr<webrtc::I420Buffer> buffer =
166 webrtc::I420Buffer::Create(width, height);
nisseaf916892017-01-10 07:44:26 -0800167 webrtc::I420Buffer::SetBlack(buffer);
nisse64ec8f82016-09-27 00:17:25 -0700168 return buffer;
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +0000169}
170
Shao Changbine62202f2015-04-21 20:24:50 +0800171void VerifySendStreamHasRtxTypes(const webrtc::VideoSendStream::Config& config,
172 const std::map<int, int>& rtx_types) {
173 std::map<int, int>::const_iterator it;
Niels Möller259a4972018-04-05 15:36:51 +0200174 it = rtx_types.find(config.rtp.payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800175 EXPECT_TRUE(it != rtx_types.end() &&
176 it->second == config.rtp.rtx.payload_type);
177
brandtrb5f2c3f2016-10-04 23:28:39 -0700178 if (config.rtp.ulpfec.red_rtx_payload_type != -1) {
179 it = rtx_types.find(config.rtp.ulpfec.red_payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800180 EXPECT_TRUE(it != rtx_types.end() &&
brandtrb5f2c3f2016-10-04 23:28:39 -0700181 it->second == config.rtp.ulpfec.red_rtx_payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800182 }
183}
kthelgason2bc68642017-02-07 07:02:22 -0800184
185cricket::MediaConfig GetMediaConfig() {
186 cricket::MediaConfig media_config;
Niels Möller1d7ecd22018-01-18 15:25:12 +0100187 media_config.video.enable_cpu_adaptation = false;
kthelgason2bc68642017-02-07 07:02:22 -0800188 return media_config;
189}
nisse26e3abb2017-08-25 04:44:25 -0700190
Åsa Perssonbdee46d2018-06-25 11:28:06 +0200191// Values from GetMaxDefaultVideoBitrateKbps in webrtcvideoengine.cc.
192int GetMaxDefaultBitrateBps(size_t width, size_t height) {
193 if (width * height <= 320 * 240) {
194 return 600000;
195 } else if (width * height <= 640 * 480) {
196 return 1700000;
197 } else if (width * height <= 960 * 540) {
198 return 2000000;
199 } else {
200 return 2500000;
201 }
202}
203
Niels Möller731a2c22018-07-30 15:08:07 +0200204class MockVideoSource : public rtc::VideoSourceInterface<webrtc::VideoFrame> {
205 public:
206 MOCK_METHOD2(AddOrUpdateSink,
207 void(rtc::VideoSinkInterface<webrtc::VideoFrame>* sink,
208 const rtc::VideoSinkWants& wants));
209 MOCK_METHOD1(RemoveSink,
210 void(rtc::VideoSinkInterface<webrtc::VideoFrame>* sink));
211};
212
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000213} // namespace
214
Yves Gerey665174f2018-06-19 15:03:05 +0200215#define EXPECT_FRAME_WAIT(c, w, h, t) \
Niels Möller6557d0c2018-04-11 15:18:34 +0200216 EXPECT_EQ_WAIT((c), renderer_.num_rendered_frames(), (t)); \
Yves Gerey665174f2018-06-19 15:03:05 +0200217 EXPECT_EQ((w), renderer_.width()); \
218 EXPECT_EQ((h), renderer_.height()); \
Niels Möller6557d0c2018-04-11 15:18:34 +0200219 EXPECT_EQ(0, renderer_.errors());
220
Yves Gerey665174f2018-06-19 15:03:05 +0200221#define EXPECT_FRAME_ON_RENDERER_WAIT(r, c, w, h, t) \
Niels Möller6557d0c2018-04-11 15:18:34 +0200222 EXPECT_EQ_WAIT((c), (r).num_rendered_frames(), (t)); \
Yves Gerey665174f2018-06-19 15:03:05 +0200223 EXPECT_EQ((w), (r).width()); \
224 EXPECT_EQ((h), (r).height()); \
Niels Möller6557d0c2018-04-11 15:18:34 +0200225 EXPECT_EQ(0, (r).errors());
226
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000227namespace cricket {
eladalonf1841382017-06-12 01:16:46 -0700228class WebRtcVideoEngineTest : public ::testing::Test {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000229 public:
eladalonf1841382017-06-12 01:16:46 -0700230 WebRtcVideoEngineTest() : WebRtcVideoEngineTest("") {}
Elad Alon040dc432019-05-22 15:40:02 +0200231 explicit WebRtcVideoEngineTest(const std::string& field_trials)
232 : override_field_trials_(
233 field_trials.empty()
234 ? nullptr
Mirko Bonadei317a1f02019-09-17 17:06:18 +0200235 : std::make_unique<webrtc::test::ScopedFieldTrials>(
Elad Alon040dc432019-05-22 15:40:02 +0200236 field_trials)),
Danil Chapovalov53d45ba2019-07-03 14:56:33 +0200237 task_queue_factory_(webrtc::CreateDefaultTaskQueueFactory()),
238 call_(webrtc::Call::Create([&] {
239 webrtc::Call::Config call_config(&event_log_);
240 call_config.task_queue_factory = task_queue_factory_.get();
241 return call_config;
242 }())),
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200243 encoder_factory_(new cricket::FakeWebRtcVideoEncoderFactory),
244 decoder_factory_(new cricket::FakeWebRtcVideoDecoderFactory),
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200245 video_bitrate_allocator_factory_(
246 webrtc::CreateBuiltinVideoBitrateAllocatorFactory()),
Anders Carlsson67537952018-05-03 11:28:29 +0200247 engine_(std::unique_ptr<cricket::FakeWebRtcVideoEncoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200248 encoder_factory_),
Anders Carlsson67537952018-05-03 11:28:29 +0200249 std::unique_ptr<cricket::FakeWebRtcVideoDecoderFactory>(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200250 decoder_factory_)) {
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +0200251 // Ensure fake clock doesn't return 0, which will cause some initializations
252 // fail inside RTP senders.
Sebastian Jansson40889f32019-04-17 12:11:20 +0200253 fake_clock_.AdvanceTime(webrtc::TimeDelta::us(1));
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +0200254 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000255
256 protected:
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200257 void AssignDefaultAptRtxTypes();
258 void AssignDefaultCodec();
259
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100260 // Find the index of the codec in the engine with the given name. The codec
261 // must be present.
Oleh Prypina40f8242017-12-21 13:32:23 +0100262 size_t GetEngineCodecIndex(const std::string& name) const;
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100263
magjed509e4fe2016-11-18 01:34:11 -0800264 // Find the codec in the engine with the given name. The codec must be
265 // present.
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100266 cricket::VideoCodec GetEngineCodec(const std::string& name) const;
magjed509e4fe2016-11-18 01:34:11 -0800267
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200268 VideoMediaChannel* SetSendParamsWithAllSupportedCodecs();
pbos@webrtc.orgfa553ef2014-10-20 11:07:07 +0000269
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200270 VideoMediaChannel* SetRecvParamsWithSupportedCodecs(
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000271 const std::vector<VideoCodec>& codecs);
272
Elad Alon157540a2019-02-08 23:37:52 +0100273 void ExpectRtpCapabilitySupport(const char* uri, bool supported) const;
Peter Boströme4499152016-02-05 11:13:28 +0100274
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +0200275 // Has to be the first one, so it is initialized before the call or there is a
276 // race condition in the clock access.
277 rtc::ScopedFakeClock fake_clock_;
Elad Alon040dc432019-05-22 15:40:02 +0200278 std::unique_ptr<webrtc::test::ScopedFieldTrials> override_field_trials_;
Danil Chapovalov83bbe912019-08-07 12:24:53 +0200279 webrtc::RtcEventLogNull event_log_;
Danil Chapovalov53d45ba2019-07-03 14:56:33 +0200280 std::unique_ptr<webrtc::TaskQueueFactory> task_queue_factory_;
eladalonf1841382017-06-12 01:16:46 -0700281 // Used in WebRtcVideoEngineVoiceTest, but defined here so it's properly
pbos@webrtc.orgf1f0d9a2015-03-02 13:30:15 +0000282 // initialized when the constructor is called.
kwiberg686a8ef2016-02-26 03:00:35 -0800283 std::unique_ptr<webrtc::Call> call_;
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200284 cricket::FakeWebRtcVideoEncoderFactory* encoder_factory_;
285 cricket::FakeWebRtcVideoDecoderFactory* decoder_factory_;
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200286 std::unique_ptr<webrtc::VideoBitrateAllocatorFactory>
287 video_bitrate_allocator_factory_;
eladalonf1841382017-06-12 01:16:46 -0700288 WebRtcVideoEngine engine_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000289 VideoCodec default_codec_;
Shao Changbine62202f2015-04-21 20:24:50 +0800290 std::map<int, int> default_apt_rtx_types_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000291};
292
eladalonf1841382017-06-12 01:16:46 -0700293TEST_F(WebRtcVideoEngineTest, DefaultRtxCodecHasAssociatedPayloadTypeSet) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200294 encoder_factory_->AddSupportedVideoCodecType("VP8");
295 AssignDefaultCodec();
296
pbos@webrtc.orge322a172014-06-13 11:47:28 +0000297 std::vector<VideoCodec> engine_codecs = engine_.codecs();
298 for (size_t i = 0; i < engine_codecs.size(); ++i) {
299 if (engine_codecs[i].name != kRtxCodecName)
300 continue;
301 int associated_payload_type;
302 EXPECT_TRUE(engine_codecs[i].GetParam(kCodecParamAssociatedPayloadType,
pbos@webrtc.org42684be2014-10-03 11:25:45 +0000303 &associated_payload_type));
pbos@webrtc.orge322a172014-06-13 11:47:28 +0000304 EXPECT_EQ(default_codec_.id, associated_payload_type);
305 return;
306 }
307 FAIL() << "No RTX codec found among default codecs.";
308}
309
eladalonf1841382017-06-12 01:16:46 -0700310TEST_F(WebRtcVideoEngineTest, SupportsTimestampOffsetHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100311 ExpectRtpCapabilitySupport(RtpExtension::kTimestampOffsetUri, true);
pbos@webrtc.org587ef602014-06-16 17:32:02 +0000312}
313
eladalonf1841382017-06-12 01:16:46 -0700314TEST_F(WebRtcVideoEngineTest, SupportsAbsoluteSenderTimeHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100315 ExpectRtpCapabilitySupport(RtpExtension::kAbsSendTimeUri, true);
pbos@webrtc.org587ef602014-06-16 17:32:02 +0000316}
317
eladalonf1841382017-06-12 01:16:46 -0700318TEST_F(WebRtcVideoEngineTest, SupportsTransportSequenceNumberHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100319 ExpectRtpCapabilitySupport(RtpExtension::kTransportSequenceNumberUri, true);
stefanc1aeaf02015-10-15 07:26:07 -0700320}
321
eladalonf1841382017-06-12 01:16:46 -0700322TEST_F(WebRtcVideoEngineTest, SupportsVideoRotationHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100323 ExpectRtpCapabilitySupport(RtpExtension::kVideoRotationUri, true);
324}
325
326TEST_F(WebRtcVideoEngineTest, SupportsPlayoutDelayHeaderExtension) {
327 ExpectRtpCapabilitySupport(RtpExtension::kPlayoutDelayUri, true);
328}
329
330TEST_F(WebRtcVideoEngineTest, SupportsVideoContentTypeHeaderExtension) {
331 ExpectRtpCapabilitySupport(RtpExtension::kVideoContentTypeUri, true);
332}
333
334TEST_F(WebRtcVideoEngineTest, SupportsVideoTimingHeaderExtension) {
335 ExpectRtpCapabilitySupport(RtpExtension::kVideoTimingUri, true);
336}
337
338TEST_F(WebRtcVideoEngineTest, SupportsFrameMarkingHeaderExtension) {
339 ExpectRtpCapabilitySupport(RtpExtension::kFrameMarkingUri, true);
Johannes Krond0b69a82018-12-03 14:18:53 +0100340}
341
342TEST_F(WebRtcVideoEngineTest, SupportsColorSpaceHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100343 ExpectRtpCapabilitySupport(RtpExtension::kColorSpaceUri, true);
344}
345
Elad Alonccb9b752019-02-19 13:01:31 +0100346TEST_F(WebRtcVideoEngineTest, AdvertiseGenericDescriptor00) {
347 ExpectRtpCapabilitySupport(RtpExtension::kGenericFrameDescriptorUri00, false);
348}
349
350TEST_F(WebRtcVideoEngineTest, AdvertiseGenericDescriptor01) {
351 ExpectRtpCapabilitySupport(RtpExtension::kGenericFrameDescriptorUri01, false);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700352}
353
philipel1e054862018-10-08 16:13:53 +0200354class WebRtcVideoEngineTestWithGenericDescriptor
355 : public WebRtcVideoEngineTest {
356 public:
357 WebRtcVideoEngineTestWithGenericDescriptor()
358 : WebRtcVideoEngineTest("WebRTC-GenericDescriptorAdvertised/Enabled/") {}
359};
360
Elad Alonccb9b752019-02-19 13:01:31 +0100361TEST_F(WebRtcVideoEngineTestWithGenericDescriptor,
362 AdvertiseGenericDescriptor00) {
363 ExpectRtpCapabilitySupport(RtpExtension::kGenericFrameDescriptorUri00, true);
364}
365
366TEST_F(WebRtcVideoEngineTestWithGenericDescriptor,
367 AdvertiseGenericDescriptor01) {
368 ExpectRtpCapabilitySupport(RtpExtension::kGenericFrameDescriptorUri01, true);
philipel1e054862018-10-08 16:13:53 +0200369}
370
eladalonf1841382017-06-12 01:16:46 -0700371TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionBeforeCapturer) {
Niels Möller731a2c22018-07-30 15:08:07 +0200372 // Allocate the source first to prevent early destruction before channel's
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700373 // dtor is called.
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200374 ::testing::NiceMock<MockVideoSource> video_source;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700375
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200376 encoder_factory_->AddSupportedVideoCodecType("VP8");
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700377
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200378 std::unique_ptr<VideoMediaChannel> channel(
379 SetSendParamsWithAllSupportedCodecs());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700380 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
381
382 // Add CVO extension.
383 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800384 cricket::VideoSendParameters parameters;
385 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200386 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700387 RtpExtension(RtpExtension::kVideoRotationUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200388 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700389
Niels Möller731a2c22018-07-30 15:08:07 +0200390 EXPECT_CALL(
391 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200392 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200393 Field(&rtc::VideoSinkWants::rotation_applied, false)));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700394 // Set capturer.
Niels Möller731a2c22018-07-30 15:08:07 +0200395 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700396
397 // Verify capturer has turned off applying rotation.
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200398 ::testing::Mock::VerifyAndClear(&video_source);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700399
400 // Verify removing header extension turns on applying rotation.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200401 parameters.extensions.clear();
Niels Möller731a2c22018-07-30 15:08:07 +0200402 EXPECT_CALL(
403 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200404 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200405 Field(&rtc::VideoSinkWants::rotation_applied, true)));
406
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200407 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700408}
409
eladalonf1841382017-06-12 01:16:46 -0700410TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionBeforeAddSendStream) {
Niels Möller731a2c22018-07-30 15:08:07 +0200411 // Allocate the source first to prevent early destruction before channel's
perkj91e1c152016-03-02 05:34:00 -0800412 // dtor is called.
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200413 ::testing::NiceMock<MockVideoSource> video_source;
perkj91e1c152016-03-02 05:34:00 -0800414
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200415 encoder_factory_->AddSupportedVideoCodecType("VP8");
perkj91e1c152016-03-02 05:34:00 -0800416
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200417 std::unique_ptr<VideoMediaChannel> channel(
418 SetSendParamsWithAllSupportedCodecs());
perkj91e1c152016-03-02 05:34:00 -0800419 // Add CVO extension.
420 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800421 cricket::VideoSendParameters parameters;
422 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkj91e1c152016-03-02 05:34:00 -0800423 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700424 RtpExtension(RtpExtension::kVideoRotationUri, id));
perkj91e1c152016-03-02 05:34:00 -0800425 EXPECT_TRUE(channel->SetSendParameters(parameters));
426 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
427
Niels Möller731a2c22018-07-30 15:08:07 +0200428 // Set source.
429 EXPECT_CALL(
430 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200431 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200432 Field(&rtc::VideoSinkWants::rotation_applied, false)));
433 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
perkj91e1c152016-03-02 05:34:00 -0800434}
435
eladalonf1841382017-06-12 01:16:46 -0700436TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionAfterCapturer) {
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200437 ::testing::NiceMock<MockVideoSource> video_source;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700438
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200439 encoder_factory_->AddSupportedVideoCodecType("VP8");
440 encoder_factory_->AddSupportedVideoCodecType("VP9");
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700441
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200442 std::unique_ptr<VideoMediaChannel> channel(
443 SetSendParamsWithAllSupportedCodecs());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700444 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
445
446 // Set capturer.
Niels Möller731a2c22018-07-30 15:08:07 +0200447 EXPECT_CALL(
448 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200449 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200450 Field(&rtc::VideoSinkWants::rotation_applied, true)));
451 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700452
perkjcaafdba2016-03-20 07:34:29 -0700453 // Verify capturer has turned on applying rotation.
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200454 ::testing::Mock::VerifyAndClear(&video_source);
perkjcaafdba2016-03-20 07:34:29 -0700455
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700456 // Add CVO extension.
457 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800458 cricket::VideoSendParameters parameters;
459 parameters.codecs.push_back(GetEngineCodec("VP8"));
460 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200461 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700462 RtpExtension(RtpExtension::kVideoRotationUri, id));
perkjcaafdba2016-03-20 07:34:29 -0700463 // Also remove the first codec to trigger a codec change as well.
464 parameters.codecs.erase(parameters.codecs.begin());
Niels Möller731a2c22018-07-30 15:08:07 +0200465 EXPECT_CALL(
466 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200467 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200468 Field(&rtc::VideoSinkWants::rotation_applied, false)));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200469 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700470
471 // Verify capturer has turned off applying rotation.
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200472 ::testing::Mock::VerifyAndClear(&video_source);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700473
474 // Verify removing header extension turns on applying rotation.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200475 parameters.extensions.clear();
Niels Möller731a2c22018-07-30 15:08:07 +0200476 EXPECT_CALL(
477 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200478 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200479 Field(&rtc::VideoSinkWants::rotation_applied, true)));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200480 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700481}
482
eladalonf1841382017-06-12 01:16:46 -0700483TEST_F(WebRtcVideoEngineTest, SetSendFailsBeforeSettingCodecs) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200484 encoder_factory_->AddSupportedVideoCodecType("VP8");
485
Sebastian Jansson84848f22018-11-16 10:40:36 +0100486 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200487 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
488 video_bitrate_allocator_factory_.get()));
pbos@webrtc.org5301b0f2014-07-17 08:51:46 +0000489
490 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(123)));
491
492 EXPECT_FALSE(channel->SetSend(true))
493 << "Channel should not start without codecs.";
494 EXPECT_TRUE(channel->SetSend(false))
495 << "Channel should be stoppable even without set codecs.";
496}
497
eladalonf1841382017-06-12 01:16:46 -0700498TEST_F(WebRtcVideoEngineTest, GetStatsWithoutSendCodecsSetDoesNotCrash) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200499 encoder_factory_->AddSupportedVideoCodecType("VP8");
500
Sebastian Jansson84848f22018-11-16 10:40:36 +0100501 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200502 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
503 video_bitrate_allocator_factory_.get()));
pbos@webrtc.orgc3d2bd22014-08-12 20:55:10 +0000504 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(123)));
505 VideoMediaInfo info;
506 channel->GetStats(&info);
507}
508
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200509TEST_F(WebRtcVideoEngineTest, UseFactoryForVp8WhenSupported) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200510 encoder_factory_->AddSupportedVideoCodecType("VP8");
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000511
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200512 std::unique_ptr<VideoMediaChannel> channel(
513 SetSendParamsWithAllSupportedCodecs());
Sergey Ulanove2b15012016-11-22 16:08:30 -0800514 channel->OnReadyToSend(true);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000515
516 EXPECT_TRUE(
517 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200518 EXPECT_EQ(0, encoder_factory_->GetNumCreatedEncoders());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000519 EXPECT_TRUE(channel->SetSend(true));
Niels Möllerd0f0f682019-01-14 09:09:53 +0100520 webrtc::test::FrameForwarder frame_forwarder;
521 cricket::FakeFrameSource frame_source(1280, 720,
522 rtc::kNumMicrosecsPerSec / 30);
523 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
524 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Per21d45d22016-10-30 21:37:57 +0100525 // Sending one frame will have allocate the encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200526 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
527 EXPECT_TRUE_WAIT(encoder_factory_->encoders()[0]->GetNumEncodedFrames() > 0,
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000528 kTimeout);
529
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200530 int num_created_encoders = encoder_factory_->GetNumCreatedEncoders();
Per21d45d22016-10-30 21:37:57 +0100531 EXPECT_EQ(num_created_encoders, 1);
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000532
533 // Setting codecs of the same type should not reallocate any encoders
534 // (expecting a no-op).
magjed509e4fe2016-11-18 01:34:11 -0800535 cricket::VideoSendParameters parameters;
536 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200537 EXPECT_TRUE(channel->SetSendParameters(parameters));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200538 EXPECT_EQ(num_created_encoders, encoder_factory_->GetNumCreatedEncoders());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000539
540 // Remove stream previously added to free the external encoder instance.
541 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200542 EXPECT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000543}
544
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200545// Test that when an encoder factory supports H264, we add an RTX
546// codec for it.
547// TODO(deadbeef): This test should be updated if/when we start
548// adding RTX codecs for unrecognized codec names.
549TEST_F(WebRtcVideoEngineTest, RtxCodecAddedForH264Codec) {
magjed725e4842016-11-16 00:48:13 -0800550 using webrtc::H264::kLevel1;
Jonas Olssona4d87372019-07-05 19:08:33 +0200551 using webrtc::H264::ProfileLevelId;
552 using webrtc::H264::ProfileLevelIdToString;
Anders Carlsson67537952018-05-03 11:28:29 +0200553 webrtc::SdpVideoFormat h264_constrained_baseline("H264");
554 h264_constrained_baseline.parameters[kH264FmtpProfileLevelId] =
magjed725e4842016-11-16 00:48:13 -0800555 *ProfileLevelIdToString(
556 ProfileLevelId(webrtc::H264::kProfileConstrainedBaseline, kLevel1));
Anders Carlsson67537952018-05-03 11:28:29 +0200557 webrtc::SdpVideoFormat h264_constrained_high("H264");
558 h264_constrained_high.parameters[kH264FmtpProfileLevelId] =
magjed725e4842016-11-16 00:48:13 -0800559 *ProfileLevelIdToString(
560 ProfileLevelId(webrtc::H264::kProfileConstrainedHigh, kLevel1));
Anders Carlsson67537952018-05-03 11:28:29 +0200561 webrtc::SdpVideoFormat h264_high("H264");
562 h264_high.parameters[kH264FmtpProfileLevelId] = *ProfileLevelIdToString(
magjed725e4842016-11-16 00:48:13 -0800563 ProfileLevelId(webrtc::H264::kProfileHigh, kLevel1));
564
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200565 encoder_factory_->AddSupportedVideoCodec(h264_constrained_baseline);
566 encoder_factory_->AddSupportedVideoCodec(h264_constrained_high);
567 encoder_factory_->AddSupportedVideoCodec(h264_high);
Taylor Brandstetter6c3e7882016-06-29 11:14:19 -0700568
magjed725e4842016-11-16 00:48:13 -0800569 // First figure out what payload types the test codecs got assigned.
570 const std::vector<cricket::VideoCodec> codecs = engine_.codecs();
magjed509e4fe2016-11-18 01:34:11 -0800571 // Now search for RTX codecs for them. Expect that they all have associated
572 // RTX codecs.
magjed725e4842016-11-16 00:48:13 -0800573 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200574 codecs,
575 FindMatchingCodec(codecs, cricket::VideoCodec(h264_constrained_baseline))
576 ->id));
magjed725e4842016-11-16 00:48:13 -0800577 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200578 codecs,
579 FindMatchingCodec(codecs, cricket::VideoCodec(h264_constrained_high))
580 ->id));
magjed509e4fe2016-11-18 01:34:11 -0800581 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200582 codecs, FindMatchingCodec(codecs, cricket::VideoCodec(h264_high))->id));
Taylor Brandstetter6c3e7882016-06-29 11:14:19 -0700583}
584
Mirko Bonadei8ef57932018-11-16 14:38:03 +0100585#if defined(RTC_ENABLE_VP9)
eladalonf1841382017-06-12 01:16:46 -0700586TEST_F(WebRtcVideoEngineTest, CanConstructDecoderForVp9EncoderFactory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200587 encoder_factory_->AddSupportedVideoCodecType("VP9");
Peter Boström53eda3d2015-03-27 15:53:18 +0100588
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200589 std::unique_ptr<VideoMediaChannel> channel(
590 SetSendParamsWithAllSupportedCodecs());
Peter Boström53eda3d2015-03-27 15:53:18 +0100591
592 EXPECT_TRUE(
593 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
594}
Mirko Bonadei8ef57932018-11-16 14:38:03 +0100595#endif // defined(RTC_ENABLE_VP9)
Peter Boström53eda3d2015-03-27 15:53:18 +0100596
eladalonf1841382017-06-12 01:16:46 -0700597TEST_F(WebRtcVideoEngineTest, PropagatesInputFrameTimestamp) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200598 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson8f83b422018-02-21 13:07:13 +0100599 FakeCall* fake_call = new FakeCall();
Fredrik Solenberg709ed672015-09-15 12:26:33 +0200600 call_.reset(fake_call);
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200601 std::unique_ptr<VideoMediaChannel> channel(
602 SetSendParamsWithAllSupportedCodecs());
qiangchenc27d89f2015-07-16 10:27:16 -0700603
604 EXPECT_TRUE(
605 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
606
Niels Möllerd0f0f682019-01-14 09:09:53 +0100607 webrtc::test::FrameForwarder frame_forwarder;
608 cricket::FakeFrameSource frame_source(1280, 720,
609 rtc::kNumMicrosecsPerSec / 60);
610 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
qiangchenc27d89f2015-07-16 10:27:16 -0700611 channel->SetSend(true);
612
Fredrik Solenberg709ed672015-09-15 12:26:33 +0200613 FakeVideoSendStream* stream = fake_call->GetVideoSendStreams()[0];
qiangchenc27d89f2015-07-16 10:27:16 -0700614
Niels Möllerd0f0f682019-01-14 09:09:53 +0100615 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos1cb121d2015-09-14 11:38:38 -0700616 int64_t last_timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700617 for (int i = 0; i < 10; i++) {
Niels Möllerd0f0f682019-01-14 09:09:53 +0100618 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos1cb121d2015-09-14 11:38:38 -0700619 int64_t timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700620 int64_t interval = timestamp - last_timestamp;
621
622 // Precision changes from nanosecond to millisecond.
623 // Allow error to be no more than 1.
624 EXPECT_NEAR(cricket::VideoFormat::FpsToInterval(60) / 1E6, interval, 1);
625
626 last_timestamp = timestamp;
627 }
628
Niels Möllerd0f0f682019-01-14 09:09:53 +0100629 frame_forwarder.IncomingCapturedFrame(
630 frame_source.GetFrame(1280, 720, webrtc::VideoRotation::kVideoRotation_0,
631 rtc::kNumMicrosecsPerSec / 30));
qiangchenc27d89f2015-07-16 10:27:16 -0700632 last_timestamp = stream->GetLastTimestamp();
633 for (int i = 0; i < 10; i++) {
Niels Möllerd0f0f682019-01-14 09:09:53 +0100634 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame(
635 1280, 720, webrtc::VideoRotation::kVideoRotation_0,
636 rtc::kNumMicrosecsPerSec / 30));
pbos1cb121d2015-09-14 11:38:38 -0700637 int64_t timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700638 int64_t interval = timestamp - last_timestamp;
639
640 // Precision changes from nanosecond to millisecond.
641 // Allow error to be no more than 1.
642 EXPECT_NEAR(cricket::VideoFormat::FpsToInterval(30) / 1E6, interval, 1);
643
644 last_timestamp = timestamp;
645 }
646
647 // Remove stream previously added to free the external encoder instance.
648 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
649}
650
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200651void WebRtcVideoEngineTest::AssignDefaultAptRtxTypes() {
652 std::vector<VideoCodec> engine_codecs = engine_.codecs();
653 RTC_DCHECK(!engine_codecs.empty());
654 for (const cricket::VideoCodec& codec : engine_codecs) {
655 if (codec.name == "rtx") {
656 int associated_payload_type;
657 if (codec.GetParam(kCodecParamAssociatedPayloadType,
658 &associated_payload_type)) {
659 default_apt_rtx_types_[associated_payload_type] = codec.id;
660 }
661 }
662 }
663}
664
665void WebRtcVideoEngineTest::AssignDefaultCodec() {
666 std::vector<VideoCodec> engine_codecs = engine_.codecs();
667 RTC_DCHECK(!engine_codecs.empty());
668 bool codec_set = false;
669 for (const cricket::VideoCodec& codec : engine_codecs) {
670 if (!codec_set && codec.name != "rtx" && codec.name != "red" &&
671 codec.name != "ulpfec") {
672 default_codec_ = codec;
673 codec_set = true;
674 }
675 }
676
677 RTC_DCHECK(codec_set);
678}
679
Oleh Prypina40f8242017-12-21 13:32:23 +0100680size_t WebRtcVideoEngineTest::GetEngineCodecIndex(
681 const std::string& name) const {
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100682 const std::vector<cricket::VideoCodec> codecs = engine_.codecs();
683 for (size_t i = 0; i < codecs.size(); ++i) {
684 const cricket::VideoCodec engine_codec = codecs[i];
Niels Möller039743e2018-10-23 10:07:25 +0200685 if (!absl::EqualsIgnoreCase(name, engine_codec.name))
Magnus Jedvert8deb8182017-10-05 13:13:32 +0200686 continue;
687 // The tests only use H264 Constrained Baseline. Make sure we don't return
688 // an internal H264 codec from the engine with a different H264 profile.
Niels Möller039743e2018-10-23 10:07:25 +0200689 if (absl::EqualsIgnoreCase(name.c_str(), kH264CodecName)) {
Danil Chapovalov00c71832018-06-15 15:58:38 +0200690 const absl::optional<webrtc::H264::ProfileLevelId> profile_level_id =
Magnus Jedvert8deb8182017-10-05 13:13:32 +0200691 webrtc::H264::ParseSdpProfileLevelId(engine_codec.params);
692 if (profile_level_id->profile !=
693 webrtc::H264::kProfileConstrainedBaseline) {
694 continue;
695 }
696 }
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100697 return i;
magjed509e4fe2016-11-18 01:34:11 -0800698 }
699 // This point should never be reached.
700 ADD_FAILURE() << "Unrecognized codec name: " << name;
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100701 return -1;
702}
703
704cricket::VideoCodec WebRtcVideoEngineTest::GetEngineCodec(
705 const std::string& name) const {
706 return engine_.codecs()[GetEngineCodecIndex(name)];
magjed509e4fe2016-11-18 01:34:11 -0800707}
708
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200709VideoMediaChannel*
710WebRtcVideoEngineTest::SetSendParamsWithAllSupportedCodecs() {
Sebastian Jansson84848f22018-11-16 10:40:36 +0100711 VideoMediaChannel* channel = engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200712 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
713 video_bitrate_allocator_factory_.get());
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200714 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -0800715 // We need to look up the codec in the engine to get the correct payload type.
Anders Carlsson67537952018-05-03 11:28:29 +0200716 for (const webrtc::SdpVideoFormat& format :
717 encoder_factory_->GetSupportedFormats()) {
718 cricket::VideoCodec engine_codec = GetEngineCodec(format.name);
Steve Anton2c9ebef2019-01-28 17:27:58 -0800719 if (!absl::c_linear_search(parameters.codecs, engine_codec)) {
Anders Carlsson67537952018-05-03 11:28:29 +0200720 parameters.codecs.push_back(engine_codec);
721 }
722 }
magjed509e4fe2016-11-18 01:34:11 -0800723
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200724 EXPECT_TRUE(channel->SetSendParameters(parameters));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000725
726 return channel;
727}
728
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200729VideoMediaChannel* WebRtcVideoEngineTest::SetRecvParamsWithSupportedCodecs(
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000730 const std::vector<VideoCodec>& codecs) {
Sebastian Jansson84848f22018-11-16 10:40:36 +0100731 VideoMediaChannel* channel = engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200732 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
733 video_bitrate_allocator_factory_.get());
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200734 cricket::VideoRecvParameters parameters;
735 parameters.codecs = codecs;
736 EXPECT_TRUE(channel->SetRecvParameters(parameters));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000737
738 return channel;
739}
740
Elad Alon157540a2019-02-08 23:37:52 +0100741void WebRtcVideoEngineTest::ExpectRtpCapabilitySupport(const char* uri,
742 bool supported) const {
743 const RtpCapabilities capabilities = engine_.GetCapabilities();
744 if (supported) {
745 EXPECT_THAT(capabilities.header_extensions,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200746 ::testing::Contains(::testing::Field(&RtpExtension::uri, uri)));
Elad Alon157540a2019-02-08 23:37:52 +0100747 } else {
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200748 EXPECT_THAT(capabilities.header_extensions,
749 ::testing::Each(::testing::Field(&RtpExtension::uri,
750 ::testing::StrNe(uri))));
Elad Alon157540a2019-02-08 23:37:52 +0100751 }
752}
753
eladalonf1841382017-06-12 01:16:46 -0700754TEST_F(WebRtcVideoEngineTest, UsesSimulcastAdapterForVp8Factories) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200755 encoder_factory_->AddSupportedVideoCodecType("VP8");
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000756
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200757 std::unique_ptr<VideoMediaChannel> channel(
758 SetSendParamsWithAllSupportedCodecs());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000759
Peter Boström0c4e06b2015-10-07 12:23:21 +0200760 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000761
Yves Gerey665174f2018-06-19 15:03:05 +0200762 EXPECT_TRUE(channel->AddSendStream(CreateSimStreamParams("cname", ssrcs)));
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000763 EXPECT_TRUE(channel->SetSend(true));
764
Niels Möller805a27e2019-01-21 12:21:27 +0100765 webrtc::test::FrameForwarder frame_forwarder;
766 cricket::FakeFrameSource frame_source(1280, 720,
767 rtc::kNumMicrosecsPerSec / 60);
768 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, &frame_forwarder));
769 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000770
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200771 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000772
773 // Verify that encoders are configured for simulcast through adapter
774 // (increasing resolution and only configured to send one stream each).
775 int prev_width = -1;
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200776 for (size_t i = 0; i < encoder_factory_->encoders().size(); ++i) {
777 ASSERT_TRUE(encoder_factory_->encoders()[i]->WaitForInitEncode());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000778 webrtc::VideoCodec codec_settings =
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200779 encoder_factory_->encoders()[i]->GetCodecSettings();
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000780 EXPECT_EQ(0, codec_settings.numberOfSimulcastStreams);
781 EXPECT_GT(codec_settings.width, prev_width);
782 prev_width = codec_settings.width;
783 }
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000784
Niels Möllerff40b142018-04-09 08:49:14 +0200785 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, nullptr));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000786
787 channel.reset();
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200788 ASSERT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000789}
790
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200791TEST_F(WebRtcVideoEngineTest, ChannelWithH264CanChangeToVp8) {
792 encoder_factory_->AddSupportedVideoCodecType("VP8");
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200793 encoder_factory_->AddSupportedVideoCodecType("H264");
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000794
Niels Möllerd0f0f682019-01-14 09:09:53 +0100795 // Frame source.
796 webrtc::test::FrameForwarder frame_forwarder;
797 cricket::FakeFrameSource frame_source(1280, 720,
798 rtc::kNumMicrosecsPerSec / 30);
Niels Möller4db138e2018-04-19 09:04:13 +0200799
Sebastian Jansson84848f22018-11-16 10:40:36 +0100800 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200801 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
802 video_bitrate_allocator_factory_.get()));
Anders Carlsson67537952018-05-03 11:28:29 +0200803 cricket::VideoSendParameters parameters;
804 parameters.codecs.push_back(GetEngineCodec("H264"));
805 EXPECT_TRUE(channel->SetSendParameters(parameters));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000806
807 EXPECT_TRUE(
808 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möllerd0f0f682019-01-14 09:09:53 +0100809 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
Niels Möller4db138e2018-04-19 09:04:13 +0200810 // Sending one frame will have allocate the encoder.
Niels Möllerd0f0f682019-01-14 09:09:53 +0100811 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller4db138e2018-04-19 09:04:13 +0200812
813 ASSERT_EQ_WAIT(1u, encoder_factory_->encoders().size(), kTimeout);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000814
Anders Carlsson67537952018-05-03 11:28:29 +0200815 cricket::VideoSendParameters new_parameters;
816 new_parameters.codecs.push_back(GetEngineCodec("VP8"));
817 EXPECT_TRUE(channel->SetSendParameters(new_parameters));
Niels Möller4db138e2018-04-19 09:04:13 +0200818
819 // Sending one frame will switch encoder.
Niels Möllerd0f0f682019-01-14 09:09:53 +0100820 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller4db138e2018-04-19 09:04:13 +0200821
Anders Carlsson8a150d92018-05-14 12:40:04 +0200822 EXPECT_EQ_WAIT(1u, encoder_factory_->encoders().size(), kTimeout);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000823}
824
eladalonf1841382017-06-12 01:16:46 -0700825TEST_F(WebRtcVideoEngineTest,
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000826 UsesSimulcastAdapterForVp8WithCombinedVP8AndH264Factory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200827 encoder_factory_->AddSupportedVideoCodecType("VP8");
828 encoder_factory_->AddSupportedVideoCodecType("H264");
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000829
Sebastian Jansson84848f22018-11-16 10:40:36 +0100830 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200831 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
832 video_bitrate_allocator_factory_.get()));
magjed509e4fe2016-11-18 01:34:11 -0800833 cricket::VideoSendParameters parameters;
834 parameters.codecs.push_back(GetEngineCodec("VP8"));
835 EXPECT_TRUE(channel->SetSendParameters(parameters));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000836
Peter Boström0c4e06b2015-10-07 12:23:21 +0200837 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000838
Yves Gerey665174f2018-06-19 15:03:05 +0200839 EXPECT_TRUE(channel->AddSendStream(CreateSimStreamParams("cname", ssrcs)));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000840 EXPECT_TRUE(channel->SetSend(true));
841
842 // Send a fake frame, or else the media engine will configure the simulcast
843 // encoder adapter at a low-enough size that it'll only create a single
844 // encoder layer.
Niels Möller805a27e2019-01-21 12:21:27 +0100845 webrtc::test::FrameForwarder frame_forwarder;
846 cricket::FakeFrameSource frame_source(1280, 720,
847 rtc::kNumMicrosecsPerSec / 30);
848 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, &frame_forwarder));
849 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000850
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200851 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
852 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000853 EXPECT_EQ(webrtc::kVideoCodecVP8,
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200854 encoder_factory_->encoders()[0]->GetCodecSettings().codecType);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000855
856 channel.reset();
857 // Make sure DestroyVideoEncoder was called on the factory.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200858 EXPECT_EQ(0u, encoder_factory_->encoders().size());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000859}
860
eladalonf1841382017-06-12 01:16:46 -0700861TEST_F(WebRtcVideoEngineTest,
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000862 DestroysNonSimulcastEncoderFromCombinedVP8AndH264Factory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200863 encoder_factory_->AddSupportedVideoCodecType("VP8");
864 encoder_factory_->AddSupportedVideoCodecType("H264");
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000865
Sebastian Jansson84848f22018-11-16 10:40:36 +0100866 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200867 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
868 video_bitrate_allocator_factory_.get()));
magjed509e4fe2016-11-18 01:34:11 -0800869 cricket::VideoSendParameters parameters;
870 parameters.codecs.push_back(GetEngineCodec("H264"));
871 EXPECT_TRUE(channel->SetSendParameters(parameters));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000872
873 EXPECT_TRUE(
874 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Per21d45d22016-10-30 21:37:57 +0100875
876 // Send a frame of 720p. This should trigger a "real" encoder initialization.
Niels Möller805a27e2019-01-21 12:21:27 +0100877 webrtc::test::FrameForwarder frame_forwarder;
878 cricket::FakeFrameSource frame_source(1280, 720,
879 rtc::kNumMicrosecsPerSec / 30);
880 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
881 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller4db138e2018-04-19 09:04:13 +0200882 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
883 ASSERT_EQ(1u, encoder_factory_->encoders().size());
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200884 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000885 EXPECT_EQ(webrtc::kVideoCodecH264,
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200886 encoder_factory_->encoders()[0]->GetCodecSettings().codecType);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000887
888 channel.reset();
889 // Make sure DestroyVideoEncoder was called on the factory.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200890 ASSERT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000891}
892
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200893TEST_F(WebRtcVideoEngineTest, SimulcastEnabledForH264BehindFieldTrial) {
Elad Alon040dc432019-05-22 15:40:02 +0200894 RTC_DCHECK(!override_field_trials_);
Mirko Bonadei317a1f02019-09-17 17:06:18 +0200895 override_field_trials_ = std::make_unique<webrtc::test::ScopedFieldTrials>(
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200896 "WebRTC-H264Simulcast/Enabled/");
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200897 encoder_factory_->AddSupportedVideoCodecType("H264");
noahricfdac5162015-08-27 01:59:29 -0700898
Sebastian Jansson84848f22018-11-16 10:40:36 +0100899 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200900 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
901 video_bitrate_allocator_factory_.get()));
Anders Carlsson67537952018-05-03 11:28:29 +0200902 cricket::VideoSendParameters parameters;
903 parameters.codecs.push_back(GetEngineCodec("H264"));
904 EXPECT_TRUE(channel->SetSendParameters(parameters));
noahricfdac5162015-08-27 01:59:29 -0700905
Peter Boström0c4e06b2015-10-07 12:23:21 +0200906 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
noahricfdac5162015-08-27 01:59:29 -0700907 EXPECT_TRUE(
908 channel->AddSendStream(cricket::CreateSimStreamParams("cname", ssrcs)));
Peter Boströmce23bee2016-02-02 14:14:30 +0100909
910 // Send a frame of 720p. This should trigger a "real" encoder initialization.
Niels Möller805a27e2019-01-21 12:21:27 +0100911 webrtc::test::FrameForwarder frame_forwarder;
912 cricket::FakeFrameSource frame_source(1280, 720,
913 rtc::kNumMicrosecsPerSec / 30);
914 EXPECT_TRUE(channel->SetVideoSend(ssrcs[0], nullptr, &frame_forwarder));
915 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Peter Boströmce23bee2016-02-02 14:14:30 +0100916
Niels Möller4db138e2018-04-19 09:04:13 +0200917 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200918 ASSERT_EQ(1u, encoder_factory_->encoders().size());
919 FakeWebRtcVideoEncoder* encoder = encoder_factory_->encoders()[0];
920 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
noahricfdac5162015-08-27 01:59:29 -0700921 EXPECT_EQ(webrtc::kVideoCodecH264, encoder->GetCodecSettings().codecType);
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200922 EXPECT_LT(1u, encoder->GetCodecSettings().numberOfSimulcastStreams);
Niels Möllerff40b142018-04-09 08:49:14 +0200923 EXPECT_TRUE(channel->SetVideoSend(ssrcs[0], nullptr, nullptr));
noahricfdac5162015-08-27 01:59:29 -0700924}
925
brandtrffc61182016-11-28 06:02:22 -0800926// Test that the FlexFEC field trial properly alters the output of
eladalonf1841382017-06-12 01:16:46 -0700927// WebRtcVideoEngine::codecs(), for an existing |engine_| object.
brandtrffc61182016-11-28 06:02:22 -0800928//
929// TODO(brandtr): Remove this test, when the FlexFEC field trial is gone.
eladalonf1841382017-06-12 01:16:46 -0700930TEST_F(WebRtcVideoEngineTest,
brandtrffc61182016-11-28 06:02:22 -0800931 Flexfec03SupportedAsInternalCodecBehindFieldTrial) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200932 encoder_factory_->AddSupportedVideoCodecType("VP8");
933
Steve Anton2c9ebef2019-01-28 17:27:58 -0800934 auto flexfec = Field("name", &VideoCodec::name, "flexfec-03");
brandtrffc61182016-11-28 06:02:22 -0800935
936 // FlexFEC is not active without field trial.
Steve Anton2c9ebef2019-01-28 17:27:58 -0800937 EXPECT_THAT(engine_.codecs(), Not(Contains(flexfec)));
brandtrffc61182016-11-28 06:02:22 -0800938
939 // FlexFEC is active with field trial.
Elad Alon040dc432019-05-22 15:40:02 +0200940 RTC_DCHECK(!override_field_trials_);
Mirko Bonadei317a1f02019-09-17 17:06:18 +0200941 override_field_trials_ = std::make_unique<webrtc::test::ScopedFieldTrials>(
brandtr340e3fd2017-02-28 15:43:10 -0800942 "WebRTC-FlexFEC-03-Advertised/Enabled/");
Steve Anton2c9ebef2019-01-28 17:27:58 -0800943 EXPECT_THAT(engine_.codecs(), Contains(flexfec));
brandtrffc61182016-11-28 06:02:22 -0800944}
945
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200946// Test that codecs are added in the order they are reported from the factory.
947TEST_F(WebRtcVideoEngineTest, ReportSupportedCodecs) {
948 encoder_factory_->AddSupportedVideoCodecType("VP8");
949 const char* kFakeCodecName = "FakeCodec";
950 encoder_factory_->AddSupportedVideoCodecType(kFakeCodecName);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000951
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200952 // The last reported codec should appear after the first codec in the vector.
Oleh Prypina40f8242017-12-21 13:32:23 +0100953 const size_t vp8_index = GetEngineCodecIndex("VP8");
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200954 const size_t fake_codec_index = GetEngineCodecIndex(kFakeCodecName);
955 EXPECT_LT(vp8_index, fake_codec_index);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000956}
957
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200958// Test that a codec that was added after the engine was initialized
brandtrffc61182016-11-28 06:02:22 -0800959// does show up in the codec list after it was added.
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200960TEST_F(WebRtcVideoEngineTest, ReportSupportedAddedCodec) {
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100961 const char* kFakeExternalCodecName1 = "FakeExternalCodec1";
962 const char* kFakeExternalCodecName2 = "FakeExternalCodec2";
Magnus Jedvert154ee1f2017-11-15 19:27:11 +0100963
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100964 // Set up external encoder factory with first codec, and initialize engine.
965 encoder_factory_->AddSupportedVideoCodecType(kFakeExternalCodecName1);
966
brandtrffc61182016-11-28 06:02:22 -0800967 std::vector<cricket::VideoCodec> codecs_before(engine_.codecs());
brandtrffc61182016-11-28 06:02:22 -0800968
969 // Add second codec.
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100970 encoder_factory_->AddSupportedVideoCodecType(kFakeExternalCodecName2);
brandtrffc61182016-11-28 06:02:22 -0800971 std::vector<cricket::VideoCodec> codecs_after(engine_.codecs());
Sami Kalliomäkie9a18b22018-07-13 10:28:21 +0200972 // The codec itself and RTX should have been added.
973 EXPECT_EQ(codecs_before.size() + 2, codecs_after.size());
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100974
975 // Check that both fake codecs are present and that the second fake codec
976 // appears after the first fake codec.
Oleh Prypina40f8242017-12-21 13:32:23 +0100977 const size_t fake_codec_index1 = GetEngineCodecIndex(kFakeExternalCodecName1);
978 const size_t fake_codec_index2 = GetEngineCodecIndex(kFakeExternalCodecName2);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100979 EXPECT_LT(fake_codec_index1, fake_codec_index2);
brandtrffc61182016-11-28 06:02:22 -0800980}
981
Sami Kalliomäkie9a18b22018-07-13 10:28:21 +0200982TEST_F(WebRtcVideoEngineTest, ReportRtxForExternalCodec) {
983 const char* kFakeCodecName = "FakeCodec";
984 encoder_factory_->AddSupportedVideoCodecType(kFakeCodecName);
985
986 const size_t fake_codec_index = GetEngineCodecIndex(kFakeCodecName);
987 EXPECT_EQ("rtx", engine_.codecs().at(fake_codec_index + 1).name);
988}
989
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200990TEST_F(WebRtcVideoEngineTest, RegisterDecodersIfSupported) {
991 encoder_factory_->AddSupportedVideoCodecType("VP8");
Anders Carlsson67537952018-05-03 11:28:29 +0200992 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200993 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -0800994 parameters.codecs.push_back(GetEngineCodec("VP8"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000995
kwiberg686a8ef2016-02-26 03:00:35 -0800996 std::unique_ptr<VideoMediaChannel> channel(
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200997 SetRecvParamsWithSupportedCodecs(parameters.codecs));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000998
999 EXPECT_TRUE(
1000 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001001 ASSERT_EQ(1u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +00001002
1003 // Setting codecs of the same type should not reallocate the decoder.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02001004 EXPECT_TRUE(channel->SetRecvParameters(parameters));
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001005 EXPECT_EQ(1, decoder_factory_->GetNumCreatedDecoders());
pbos@webrtc.org96a93252014-11-03 14:46:44 +00001006
1007 // Remove stream previously added to free the external decoder instance.
1008 EXPECT_TRUE(channel->RemoveRecvStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001009 EXPECT_EQ(0u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +00001010}
1011
Anders Carlsson5f2bb622018-05-14 09:48:06 +02001012// Verifies that we can set up decoders.
1013TEST_F(WebRtcVideoEngineTest, RegisterH264DecoderIfSupported) {
pbos@webrtc.org96a93252014-11-03 14:46:44 +00001014 // TODO(pbos): Do not assume that encoder/decoder support is symmetric. We
1015 // can't even query the WebRtcVideoDecoderFactory for supported codecs.
1016 // For now we add a FakeWebRtcVideoEncoderFactory to add H264 to supported
1017 // codecs.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001018 encoder_factory_->AddSupportedVideoCodecType("H264");
Steve Anton2dbc6272019-05-31 13:08:58 -07001019 webrtc::SdpVideoFormat supported_h264("H264");
1020 supported_h264.parameters[kH264FmtpPacketizationMode] = "1";
1021 decoder_factory_->AddSupportedVideoCodecType(supported_h264);
pbos@webrtc.org96a93252014-11-03 14:46:44 +00001022 std::vector<cricket::VideoCodec> codecs;
magjed509e4fe2016-11-18 01:34:11 -08001023 codecs.push_back(GetEngineCodec("H264"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +00001024
kwiberg686a8ef2016-02-26 03:00:35 -08001025 std::unique_ptr<VideoMediaChannel> channel(
Anders Carlsson5f2bb622018-05-14 09:48:06 +02001026 SetRecvParamsWithSupportedCodecs(codecs));
pbos@webrtc.org96a93252014-11-03 14:46:44 +00001027
1028 EXPECT_TRUE(
1029 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001030 ASSERT_EQ(1u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +00001031}
1032
Jonas Oreland49ac5952018-09-26 16:04:32 +02001033// Tests when GetSources is called with non-existing ssrc, it will return an
1034// empty list of RtpSource without crashing.
1035TEST_F(WebRtcVideoEngineTest, GetSourcesWithNonExistingSsrc) {
1036 // Setup an recv stream with |kSsrc|.
1037 encoder_factory_->AddSupportedVideoCodecType("VP8");
1038 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("VP8"));
1039 cricket::VideoRecvParameters parameters;
1040 parameters.codecs.push_back(GetEngineCodec("VP8"));
1041 std::unique_ptr<VideoMediaChannel> channel(
1042 SetRecvParamsWithSupportedCodecs(parameters.codecs));
1043
1044 EXPECT_TRUE(
1045 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
1046
1047 // Call GetSources with |kSsrc + 1| which doesn't exist.
1048 std::vector<webrtc::RtpSource> sources = channel->GetSources(kSsrc + 1);
1049 EXPECT_EQ(0u, sources.size());
1050}
1051
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001052TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, NullFactories) {
1053 std::unique_ptr<webrtc::VideoEncoderFactory> encoder_factory;
1054 std::unique_ptr<webrtc::VideoDecoderFactory> decoder_factory;
1055 WebRtcVideoEngine engine(std::move(encoder_factory),
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001056 std::move(decoder_factory));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001057 EXPECT_EQ(0u, engine.codecs().size());
1058}
1059
1060TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, EmptyFactories) {
1061 // |engine| take ownership of the factories.
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -07001062 webrtc::MockVideoEncoderFactory* encoder_factory =
1063 new webrtc::MockVideoEncoderFactory();
1064 webrtc::MockVideoDecoderFactory* decoder_factory =
1065 new webrtc::MockVideoDecoderFactory();
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001066 WebRtcVideoEngine engine(
1067 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001068 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001069 EXPECT_CALL(*encoder_factory, GetSupportedFormats());
1070 EXPECT_EQ(0u, engine.codecs().size());
1071 EXPECT_CALL(*encoder_factory, Die());
1072 EXPECT_CALL(*decoder_factory, Die());
1073}
1074
1075// Test full behavior in the video engine when video codec factories of the new
1076// type are injected supporting the single codec Vp8. Check the returned codecs
1077// from the engine and that we will create a Vp8 encoder and decoder using the
1078// new factories.
1079TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, Vp8) {
1080 // |engine| take ownership of the factories.
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -07001081 webrtc::MockVideoEncoderFactory* encoder_factory =
1082 new webrtc::MockVideoEncoderFactory();
1083 webrtc::MockVideoDecoderFactory* decoder_factory =
1084 new webrtc::MockVideoDecoderFactory();
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001085 std::unique_ptr<webrtc::MockVideoBitrateAllocatorFactory>
1086 rate_allocator_factory =
Mirko Bonadei317a1f02019-09-17 17:06:18 +02001087 std::make_unique<webrtc::MockVideoBitrateAllocatorFactory>();
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001088 EXPECT_CALL(*rate_allocator_factory,
1089 CreateVideoBitrateAllocatorProxy(Field(
1090 &webrtc::VideoCodec::codecType, webrtc::kVideoCodecVP8)))
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001091 .WillOnce(::testing::Return(new webrtc::MockVideoBitrateAllocator()));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001092 WebRtcVideoEngine engine(
1093 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001094 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001095 const webrtc::SdpVideoFormat vp8_format("VP8");
1096 const std::vector<webrtc::SdpVideoFormat> supported_formats = {vp8_format};
1097 EXPECT_CALL(*encoder_factory, GetSupportedFormats())
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001098 .WillRepeatedly(::testing::Return(supported_formats));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001099
1100 // Verify the codecs from the engine.
1101 const std::vector<VideoCodec> engine_codecs = engine.codecs();
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001102 // Verify default codecs has been added correctly.
1103 EXPECT_EQ(5u, engine_codecs.size());
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001104 EXPECT_EQ("VP8", engine_codecs.at(0).name);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001105
1106 // RTX codec for VP8.
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001107 EXPECT_EQ("rtx", engine_codecs.at(1).name);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001108 int vp8_associated_payload;
1109 EXPECT_TRUE(engine_codecs.at(1).GetParam(kCodecParamAssociatedPayloadType,
1110 &vp8_associated_payload));
1111 EXPECT_EQ(vp8_associated_payload, engine_codecs.at(0).id);
1112
1113 EXPECT_EQ(kRedCodecName, engine_codecs.at(2).name);
1114
1115 // RTX codec for RED.
1116 EXPECT_EQ("rtx", engine_codecs.at(3).name);
1117 int red_associated_payload;
1118 EXPECT_TRUE(engine_codecs.at(3).GetParam(kCodecParamAssociatedPayloadType,
1119 &red_associated_payload));
1120 EXPECT_EQ(red_associated_payload, engine_codecs.at(2).id);
1121
1122 EXPECT_EQ(kUlpfecCodecName, engine_codecs.at(4).name);
1123
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001124 int associated_payload_type;
1125 EXPECT_TRUE(engine_codecs.at(1).GetParam(
1126 cricket::kCodecParamAssociatedPayloadType, &associated_payload_type));
1127 EXPECT_EQ(engine_codecs.at(0).id, associated_payload_type);
1128 // Verify default parameters has been added to the VP8 codec.
Elad Alonfadb1812019-05-24 13:40:02 +02001129 VerifyCodecHasDefaultFeedbackParams(engine_codecs.at(0),
1130 /*lntf_expected=*/false);
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001131
1132 // Mock encoder creation. |engine| take ownership of the encoder.
Mirta Dvornicic1ec2a162018-12-10 09:47:34 +00001133 webrtc::VideoEncoderFactory::CodecInfo codec_info;
1134 codec_info.is_hardware_accelerated = false;
1135 codec_info.has_internal_source = false;
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001136 const webrtc::SdpVideoFormat format("VP8");
Mirta Dvornicic1ec2a162018-12-10 09:47:34 +00001137 EXPECT_CALL(*encoder_factory, QueryVideoEncoder(format))
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001138 .WillRepeatedly(::testing::Return(codec_info));
Anders Carlsson67537952018-05-03 11:28:29 +02001139 FakeWebRtcVideoEncoder* const encoder = new FakeWebRtcVideoEncoder(nullptr);
Niels Möllerc572ff32018-11-07 08:43:50 +01001140 rtc::Event encoder_created;
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001141 EXPECT_CALL(*encoder_factory, CreateVideoEncoderProxy(format))
Niels Möller4db138e2018-04-19 09:04:13 +02001142 .WillOnce(
1143 ::testing::DoAll(::testing::InvokeWithoutArgs(
1144 [&encoder_created]() { encoder_created.Set(); }),
1145 ::testing::Return(encoder)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001146
1147 // Mock decoder creation. |engine| take ownership of the decoder.
Anders Carlsson67537952018-05-03 11:28:29 +02001148 FakeWebRtcVideoDecoder* const decoder = new FakeWebRtcVideoDecoder(nullptr);
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001149 EXPECT_CALL(*decoder_factory, CreateVideoDecoderProxy(format))
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001150 .WillOnce(::testing::Return(decoder));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001151
1152 // Create a call.
Danil Chapovalov83bbe912019-08-07 12:24:53 +02001153 webrtc::RtcEventLogNull event_log;
Danil Chapovalov53d45ba2019-07-03 14:56:33 +02001154 auto task_queue_factory = webrtc::CreateDefaultTaskQueueFactory();
1155 webrtc::Call::Config call_config(&event_log);
1156 call_config.task_queue_factory = task_queue_factory.get();
1157 const auto call = absl::WrapUnique(webrtc::Call::Create(call_config));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001158
1159 // Create send channel.
1160 const int send_ssrc = 123;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001161 std::unique_ptr<VideoMediaChannel> send_channel(engine.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001162 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
1163 rate_allocator_factory.get()));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001164 cricket::VideoSendParameters send_parameters;
1165 send_parameters.codecs.push_back(engine_codecs.at(0));
1166 EXPECT_TRUE(send_channel->SetSendParameters(send_parameters));
1167 send_channel->OnReadyToSend(true);
1168 EXPECT_TRUE(
1169 send_channel->AddSendStream(StreamParams::CreateLegacy(send_ssrc)));
1170 EXPECT_TRUE(send_channel->SetSend(true));
1171
Niels Möller4db138e2018-04-19 09:04:13 +02001172 // Set capturer.
Niels Möller805a27e2019-01-21 12:21:27 +01001173 webrtc::test::FrameForwarder frame_forwarder;
1174 cricket::FakeFrameSource frame_source(1280, 720,
1175 rtc::kNumMicrosecsPerSec / 30);
1176 EXPECT_TRUE(send_channel->SetVideoSend(send_ssrc, nullptr, &frame_forwarder));
Niels Möller4db138e2018-04-19 09:04:13 +02001177 // Sending one frame will allocate the encoder.
Niels Möller805a27e2019-01-21 12:21:27 +01001178 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller4db138e2018-04-19 09:04:13 +02001179 encoder_created.Wait(kTimeout);
1180
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001181 // Create recv channel.
1182 const int recv_ssrc = 321;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001183 std::unique_ptr<VideoMediaChannel> recv_channel(engine.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001184 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
1185 rate_allocator_factory.get()));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001186 cricket::VideoRecvParameters recv_parameters;
1187 recv_parameters.codecs.push_back(engine_codecs.at(0));
1188 EXPECT_TRUE(recv_channel->SetRecvParameters(recv_parameters));
1189 EXPECT_TRUE(recv_channel->AddRecvStream(
1190 cricket::StreamParams::CreateLegacy(recv_ssrc)));
1191
1192 // Remove streams previously added to free the encoder and decoder instance.
1193 EXPECT_CALL(*encoder_factory, Die());
1194 EXPECT_CALL(*decoder_factory, Die());
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001195 EXPECT_CALL(*rate_allocator_factory, Die());
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001196 EXPECT_TRUE(send_channel->RemoveSendStream(send_ssrc));
1197 EXPECT_TRUE(recv_channel->RemoveRecvStream(recv_ssrc));
1198}
1199
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001200// Test behavior when decoder factory fails to create a decoder (returns null).
1201TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, NullDecoder) {
1202 // |engine| take ownership of the factories.
1203 webrtc::MockVideoEncoderFactory* encoder_factory =
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001204 new webrtc::MockVideoEncoderFactory();
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001205 webrtc::MockVideoDecoderFactory* decoder_factory =
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001206 new webrtc::MockVideoDecoderFactory();
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001207 std::unique_ptr<webrtc::MockVideoBitrateAllocatorFactory>
1208 rate_allocator_factory =
Mirko Bonadei317a1f02019-09-17 17:06:18 +02001209 std::make_unique<webrtc::MockVideoBitrateAllocatorFactory>();
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001210 WebRtcVideoEngine engine(
1211 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001212 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001213 const webrtc::SdpVideoFormat vp8_format("VP8");
1214 const std::vector<webrtc::SdpVideoFormat> supported_formats = {vp8_format};
1215 EXPECT_CALL(*encoder_factory, GetSupportedFormats())
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001216 .WillRepeatedly(::testing::Return(supported_formats));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001217
1218 // Decoder creation fails.
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001219 EXPECT_CALL(*decoder_factory, CreateVideoDecoderProxy(::testing::_))
1220 .WillOnce(::testing::Return(nullptr));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001221
1222 // Create a call.
Danil Chapovalov83bbe912019-08-07 12:24:53 +02001223 webrtc::RtcEventLogNull event_log;
Danil Chapovalov53d45ba2019-07-03 14:56:33 +02001224 auto task_queue_factory = webrtc::CreateDefaultTaskQueueFactory();
1225 webrtc::Call::Config call_config(&event_log);
1226 call_config.task_queue_factory = task_queue_factory.get();
1227 const auto call = absl::WrapUnique(webrtc::Call::Create(call_config));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001228
1229 // Create recv channel.
1230 const int recv_ssrc = 321;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001231 std::unique_ptr<VideoMediaChannel> recv_channel(engine.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001232 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
1233 rate_allocator_factory.get()));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001234 cricket::VideoRecvParameters recv_parameters;
1235 recv_parameters.codecs.push_back(engine.codecs().front());
1236 EXPECT_TRUE(recv_channel->SetRecvParameters(recv_parameters));
1237 EXPECT_TRUE(recv_channel->AddRecvStream(
1238 cricket::StreamParams::CreateLegacy(recv_ssrc)));
1239
1240 // Remove streams previously added to free the encoder and decoder instance.
1241 EXPECT_TRUE(recv_channel->RemoveRecvStream(recv_ssrc));
1242}
1243
eladalonf1841382017-06-12 01:16:46 -07001244TEST_F(WebRtcVideoEngineTest, DISABLED_RecreatesEncoderOnContentTypeChange) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001245 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson8f83b422018-02-21 13:07:13 +01001246 std::unique_ptr<FakeCall> fake_call(new FakeCall());
Anders Carlsson5f2bb622018-05-14 09:48:06 +02001247 std::unique_ptr<VideoMediaChannel> channel(
1248 SetSendParamsWithAllSupportedCodecs());
sprangf24a0642017-02-28 13:23:26 -08001249 ASSERT_TRUE(
1250 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
1251 cricket::VideoCodec codec = GetEngineCodec("VP8");
1252 cricket::VideoSendParameters parameters;
1253 parameters.codecs.push_back(codec);
1254 channel->OnReadyToSend(true);
1255 channel->SetSend(true);
1256 ASSERT_TRUE(channel->SetSendParameters(parameters));
1257
Niels Möller805a27e2019-01-21 12:21:27 +01001258 webrtc::test::FrameForwarder frame_forwarder;
1259 cricket::FakeFrameSource frame_source(1280, 720,
1260 rtc::kNumMicrosecsPerSec / 30);
sprangf24a0642017-02-28 13:23:26 -08001261 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01001262 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
sprangf24a0642017-02-28 13:23:26 -08001263
Niels Möller805a27e2019-01-21 12:21:27 +01001264 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001265 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001266 EXPECT_EQ(webrtc::VideoCodecMode::kRealtimeVideo,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001267 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001268
Niels Möller805a27e2019-01-21 12:21:27 +01001269 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
1270 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
sprangf24a0642017-02-28 13:23:26 -08001271 // No change in content type, keep current encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001272 EXPECT_EQ(1, encoder_factory_->GetNumCreatedEncoders());
sprangf24a0642017-02-28 13:23:26 -08001273
1274 options.is_screencast.emplace(true);
Niels Möller805a27e2019-01-21 12:21:27 +01001275 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
1276 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
sprangf24a0642017-02-28 13:23:26 -08001277 // Change to screen content, recreate encoder. For the simulcast encoder
1278 // adapter case, this will result in two calls since InitEncode triggers a
1279 // a new instance.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001280 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001281 EXPECT_EQ(webrtc::VideoCodecMode::kScreensharing,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001282 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001283
Niels Möller805a27e2019-01-21 12:21:27 +01001284 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
1285 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
sprangf24a0642017-02-28 13:23:26 -08001286 // Still screen content, no need to update encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001287 EXPECT_EQ(2, encoder_factory_->GetNumCreatedEncoders());
sprangf24a0642017-02-28 13:23:26 -08001288
1289 options.is_screencast.emplace(false);
1290 options.video_noise_reduction.emplace(false);
Niels Möller805a27e2019-01-21 12:21:27 +01001291 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
sprangf24a0642017-02-28 13:23:26 -08001292 // Change back to regular video content, update encoder. Also change
1293 // a non |is_screencast| option just to verify it doesn't affect recreation.
Niels Möller805a27e2019-01-21 12:21:27 +01001294 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001295 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(3));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001296 EXPECT_EQ(webrtc::VideoCodecMode::kRealtimeVideo,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001297 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001298
1299 // Remove stream previously added to free the external encoder instance.
1300 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001301 EXPECT_EQ(0u, encoder_factory_->encoders().size());
sprangf24a0642017-02-28 13:23:26 -08001302}
1303
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001304class WebRtcVideoChannelBaseTest : public ::testing::Test {
Niels Möller6557d0c2018-04-11 15:18:34 +02001305 protected:
1306 WebRtcVideoChannelBaseTest()
Danil Chapovalov53d45ba2019-07-03 14:56:33 +02001307 : task_queue_factory_(webrtc::CreateDefaultTaskQueueFactory()),
1308 video_bitrate_allocator_factory_(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001309 webrtc::CreateBuiltinVideoBitrateAllocatorFactory()),
1310 engine_(webrtc::CreateBuiltinVideoEncoderFactory(),
1311 webrtc::CreateBuiltinVideoDecoderFactory()) {}
Niels Möller6557d0c2018-04-11 15:18:34 +02001312
1313 virtual void SetUp() {
Jonas Oreland49ac5952018-09-26 16:04:32 +02001314 // One testcase calls SetUp in a loop, only create call_ once.
1315 if (!call_) {
Danil Chapovalov53d45ba2019-07-03 14:56:33 +02001316 webrtc::Call::Config call_config(&event_log_);
1317 call_config.task_queue_factory = task_queue_factory_.get();
1318 call_.reset(webrtc::Call::Create(call_config));
Jonas Oreland49ac5952018-09-26 16:04:32 +02001319 }
Niels Möller6557d0c2018-04-11 15:18:34 +02001320 cricket::MediaConfig media_config;
1321 // Disabling cpu overuse detection actually disables quality scaling too; it
1322 // implies DegradationPreference kMaintainResolution. Automatic scaling
1323 // needs to be disabled, otherwise, tests which check the size of received
1324 // frames become flaky.
1325 media_config.video.enable_cpu_adaptation = false;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001326 channel_.reset(
1327 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
1328 call_.get(), media_config, cricket::VideoOptions(),
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001329 webrtc::CryptoOptions(), video_bitrate_allocator_factory_.get())));
Niels Möller6557d0c2018-04-11 15:18:34 +02001330 channel_->OnReadyToSend(true);
1331 EXPECT_TRUE(channel_.get() != NULL);
1332 network_interface_.SetDestination(channel_.get());
Anton Sukhanov4f08faa2019-05-21 11:12:57 -07001333 channel_->SetInterface(&network_interface_, webrtc::MediaTransportConfig());
Niels Möller6557d0c2018-04-11 15:18:34 +02001334 cricket::VideoRecvParameters parameters;
1335 parameters.codecs = engine_.codecs();
1336 channel_->SetRecvParameters(parameters);
1337 EXPECT_TRUE(channel_->AddSendStream(DefaultSendStreamParams()));
Mirko Bonadei317a1f02019-09-17 17:06:18 +02001338 frame_forwarder_ = std::make_unique<webrtc::test::FrameForwarder>();
1339 frame_source_ = std::make_unique<cricket::FakeFrameSource>(
Niels Möller805a27e2019-01-21 12:21:27 +01001340 640, 480, rtc::kNumMicrosecsPerSec / kFramerate);
1341 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, frame_forwarder_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001342 }
1343
1344 // Utility method to setup an additional stream to send and receive video.
1345 // Used to test send and recv between two streams.
1346 void SetUpSecondStream() {
1347 SetUpSecondStreamWithNoRecv();
1348 // Setup recv for second stream.
1349 EXPECT_TRUE(channel_->AddRecvStream(
1350 cricket::StreamParams::CreateLegacy(kSsrc + 2)));
1351 // Make the second renderer available for use by a new stream.
1352 EXPECT_TRUE(channel_->SetSink(kSsrc + 2, &renderer2_));
1353 }
1354 // Setup an additional stream just to send video. Defer add recv stream.
1355 // This is required if you want to test unsignalled recv of video rtp packets.
1356 void SetUpSecondStreamWithNoRecv() {
1357 // SetUp() already added kSsrc make sure duplicate SSRCs cant be added.
Yves Gerey665174f2018-06-19 15:03:05 +02001358 EXPECT_TRUE(
1359 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001360 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
Yves Gerey665174f2018-06-19 15:03:05 +02001361 EXPECT_FALSE(
1362 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001363 EXPECT_TRUE(channel_->AddSendStream(
1364 cricket::StreamParams::CreateLegacy(kSsrc + 2)));
1365 // We dont add recv for the second stream.
1366
1367 // Setup the receive and renderer for second stream after send.
Mirko Bonadei317a1f02019-09-17 17:06:18 +02001368 frame_forwarder_2_ = std::make_unique<webrtc::test::FrameForwarder>();
Yves Gerey665174f2018-06-19 15:03:05 +02001369 EXPECT_TRUE(
Niels Möller805a27e2019-01-21 12:21:27 +01001370 channel_->SetVideoSend(kSsrc + 2, nullptr, frame_forwarder_2_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001371 }
Yves Gerey665174f2018-06-19 15:03:05 +02001372 virtual void TearDown() { channel_.reset(); }
1373 bool SetDefaultCodec() { return SetOneCodec(DefaultCodec()); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001374
1375 bool SetOneCodec(const cricket::VideoCodec& codec) {
Mirko Bonadei317a1f02019-09-17 17:06:18 +02001376 frame_source_ = std::make_unique<cricket::FakeFrameSource>(
Niels Möller805a27e2019-01-21 12:21:27 +01001377 kVideoWidth, kVideoHeight, rtc::kNumMicrosecsPerSec / kFramerate);
Niels Möller6557d0c2018-04-11 15:18:34 +02001378
1379 bool sending = channel_->sending();
1380 bool success = SetSend(false);
1381 if (success) {
1382 cricket::VideoSendParameters parameters;
1383 parameters.codecs.push_back(codec);
1384 success = channel_->SetSendParameters(parameters);
1385 }
1386 if (success) {
1387 success = SetSend(sending);
1388 }
1389 return success;
1390 }
Yves Gerey665174f2018-06-19 15:03:05 +02001391 bool SetSend(bool send) { return channel_->SetSend(send); }
Niels Möller805a27e2019-01-21 12:21:27 +01001392 void SendFrame() {
1393 if (frame_forwarder_2_) {
1394 frame_forwarder_2_->IncomingCapturedFrame(frame_source_->GetFrame());
Niels Möller6557d0c2018-04-11 15:18:34 +02001395 }
Niels Möller805a27e2019-01-21 12:21:27 +01001396 frame_forwarder_->IncomingCapturedFrame(frame_source_->GetFrame());
Niels Möller6557d0c2018-04-11 15:18:34 +02001397 }
1398 bool WaitAndSendFrame(int wait_ms) {
1399 bool ret = rtc::Thread::Current()->ProcessMessages(wait_ms);
Niels Möller805a27e2019-01-21 12:21:27 +01001400 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001401 return ret;
1402 }
Yves Gerey665174f2018-06-19 15:03:05 +02001403 int NumRtpBytes() { return network_interface_.NumRtpBytes(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001404 int NumRtpBytes(uint32_t ssrc) {
1405 return network_interface_.NumRtpBytes(ssrc);
1406 }
Yves Gerey665174f2018-06-19 15:03:05 +02001407 int NumRtpPackets() { return network_interface_.NumRtpPackets(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001408 int NumRtpPackets(uint32_t ssrc) {
1409 return network_interface_.NumRtpPackets(ssrc);
1410 }
Yves Gerey665174f2018-06-19 15:03:05 +02001411 int NumSentSsrcs() { return network_interface_.NumSentSsrcs(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001412 const rtc::CopyOnWriteBuffer* GetRtpPacket(int index) {
1413 return network_interface_.GetRtpPacket(index);
1414 }
1415 static int GetPayloadType(const rtc::CopyOnWriteBuffer* p) {
Åsa Persson23cd45a2018-07-03 10:40:40 +02001416 webrtc::RTPHeader header;
1417 EXPECT_TRUE(ParseRtpPacket(p, &header));
1418 return header.payloadType;
Niels Möller6557d0c2018-04-11 15:18:34 +02001419 }
Åsa Persson23cd45a2018-07-03 10:40:40 +02001420
Niels Möller6557d0c2018-04-11 15:18:34 +02001421 static bool ParseRtpPacket(const rtc::CopyOnWriteBuffer* p,
Åsa Persson23cd45a2018-07-03 10:40:40 +02001422 webrtc::RTPHeader* header) {
1423 std::unique_ptr<webrtc::RtpHeaderParser> parser(
Tommi25eb47c2019-08-29 16:39:05 +02001424 webrtc::RtpHeaderParser::CreateForTest());
Åsa Persson23cd45a2018-07-03 10:40:40 +02001425 return parser->Parse(p->cdata(), p->size(), header);
Niels Möller6557d0c2018-04-11 15:18:34 +02001426 }
1427
1428 // Tests that we can send and receive frames.
1429 void SendAndReceive(const cricket::VideoCodec& codec) {
1430 EXPECT_TRUE(SetOneCodec(codec));
1431 EXPECT_TRUE(SetSend(true));
1432 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1433 EXPECT_EQ(0, renderer_.num_rendered_frames());
Niels Möller805a27e2019-01-21 12:21:27 +01001434 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001435 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1436 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1437 EXPECT_EQ(codec.id, GetPayloadType(p.get()));
1438 }
1439
1440 void SendReceiveManyAndGetStats(const cricket::VideoCodec& codec,
Yves Gerey665174f2018-06-19 15:03:05 +02001441 int duration_sec,
1442 int fps) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001443 EXPECT_TRUE(SetOneCodec(codec));
1444 EXPECT_TRUE(SetSend(true));
1445 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1446 EXPECT_EQ(0, renderer_.num_rendered_frames());
1447 for (int i = 0; i < duration_sec; ++i) {
1448 for (int frame = 1; frame <= fps; ++frame) {
1449 EXPECT_TRUE(WaitAndSendFrame(1000 / fps));
1450 EXPECT_FRAME_WAIT(frame + i * fps, kVideoWidth, kVideoHeight, kTimeout);
1451 }
1452 }
1453 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1454 EXPECT_EQ(codec.id, GetPayloadType(p.get()));
1455 }
1456
Niels Möller6557d0c2018-04-11 15:18:34 +02001457 cricket::VideoSenderInfo GetSenderStats(size_t i) {
1458 cricket::VideoMediaInfo info;
1459 EXPECT_TRUE(channel_->GetStats(&info));
1460 return info.senders[i];
1461 }
1462
1463 cricket::VideoReceiverInfo GetReceiverStats(size_t i) {
1464 cricket::VideoMediaInfo info;
1465 EXPECT_TRUE(channel_->GetStats(&info));
1466 return info.receivers[i];
1467 }
1468
1469 // Two streams one channel tests.
1470
1471 // Tests that we can send and receive frames.
1472 void TwoStreamsSendAndReceive(const cricket::VideoCodec& codec) {
1473 SetUpSecondStream();
1474 // Test sending and receiving on first stream.
1475 SendAndReceive(codec);
1476 // Test sending and receiving on second stream.
1477 EXPECT_EQ_WAIT(1, renderer2_.num_rendered_frames(), kTimeout);
1478 EXPECT_GT(NumRtpPackets(), 0);
1479 EXPECT_EQ(1, renderer2_.num_rendered_frames());
1480 }
1481
1482 cricket::VideoCodec GetEngineCodec(const std::string& name) {
1483 for (const cricket::VideoCodec& engine_codec : engine_.codecs()) {
Niels Möller039743e2018-10-23 10:07:25 +02001484 if (absl::EqualsIgnoreCase(name, engine_codec.name))
Niels Möller6557d0c2018-04-11 15:18:34 +02001485 return engine_codec;
1486 }
1487 // This point should never be reached.
1488 ADD_FAILURE() << "Unrecognized codec name: " << name;
1489 return cricket::VideoCodec();
1490 }
1491
1492 cricket::VideoCodec DefaultCodec() { return GetEngineCodec("VP8"); }
1493
1494 cricket::StreamParams DefaultSendStreamParams() {
1495 return cricket::StreamParams::CreateLegacy(kSsrc);
1496 }
1497
Danil Chapovalov83bbe912019-08-07 12:24:53 +02001498 webrtc::RtcEventLogNull event_log_;
Danil Chapovalov53d45ba2019-07-03 14:56:33 +02001499 std::unique_ptr<webrtc::TaskQueueFactory> task_queue_factory_;
Jonas Oreland49ac5952018-09-26 16:04:32 +02001500 std::unique_ptr<webrtc::Call> call_;
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001501 std::unique_ptr<webrtc::VideoBitrateAllocatorFactory>
1502 video_bitrate_allocator_factory_;
Niels Möller6557d0c2018-04-11 15:18:34 +02001503 WebRtcVideoEngine engine_;
Niels Möller805a27e2019-01-21 12:21:27 +01001504
1505 std::unique_ptr<cricket::FakeFrameSource> frame_source_;
1506 std::unique_ptr<webrtc::test::FrameForwarder> frame_forwarder_;
1507 std::unique_ptr<webrtc::test::FrameForwarder> frame_forwarder_2_;
1508
Niels Möller6557d0c2018-04-11 15:18:34 +02001509 std::unique_ptr<WebRtcVideoChannel> channel_;
1510 cricket::FakeNetworkInterface network_interface_;
1511 cricket::FakeVideoRenderer renderer_;
1512
1513 // Used by test cases where 2 streams are run on the same channel.
1514 cricket::FakeVideoRenderer renderer2_;
1515};
1516
1517// Test that SetSend works.
srtee0c2eea2017-12-15 17:44:33 +01001518TEST_F(WebRtcVideoChannelBaseTest, SetSend) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001519 EXPECT_FALSE(channel_->sending());
Niels Möller805a27e2019-01-21 12:21:27 +01001520 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, frame_forwarder_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001521 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1522 EXPECT_FALSE(channel_->sending());
1523 EXPECT_TRUE(SetSend(true));
1524 EXPECT_TRUE(channel_->sending());
Niels Möller805a27e2019-01-21 12:21:27 +01001525 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001526 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
1527 EXPECT_TRUE(SetSend(false));
1528 EXPECT_FALSE(channel_->sending());
srtee0c2eea2017-12-15 17:44:33 +01001529}
Niels Möller6557d0c2018-04-11 15:18:34 +02001530
1531// Test that SetSend fails without codecs being set.
srtee0c2eea2017-12-15 17:44:33 +01001532TEST_F(WebRtcVideoChannelBaseTest, SetSendWithoutCodecs) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001533 EXPECT_FALSE(channel_->sending());
1534 EXPECT_FALSE(SetSend(true));
1535 EXPECT_FALSE(channel_->sending());
srtee0c2eea2017-12-15 17:44:33 +01001536}
Niels Möller6557d0c2018-04-11 15:18:34 +02001537
1538// Test that we properly set the send and recv buffer sizes by the time
1539// SetSend is called.
srtee0c2eea2017-12-15 17:44:33 +01001540TEST_F(WebRtcVideoChannelBaseTest, SetSendSetsTransportBufferSizes) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001541 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1542 EXPECT_TRUE(SetSend(true));
1543 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
Johannes Krond38a2b82018-10-23 11:31:19 +02001544 EXPECT_EQ(256 * 1024, network_interface_.recvbuf_size());
Erik Språng820ebd02018-08-20 17:14:25 +02001545}
1546
Johannes Kron5a0665b2019-04-08 10:35:50 +02001547// Test that we properly set the send and recv buffer sizes when overriding
1548// via field trials.
1549TEST_F(WebRtcVideoChannelBaseTest, OverridesRecvBufferSize) {
1550 // Set field trial to override the default recv buffer size, and then re-run
1551 // setup where the interface is created and configured.
1552 const int kCustomRecvBufferSize = 123456;
1553 webrtc::test::ScopedFieldTrials field_trial(
1554 "WebRTC-IncreasedReceivebuffers/123456/");
1555 SetUp();
1556
1557 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1558 EXPECT_TRUE(SetSend(true));
1559 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
1560 EXPECT_EQ(kCustomRecvBufferSize, network_interface_.recvbuf_size());
1561}
1562
1563// Test that we properly set the send and recv buffer sizes when overriding
1564// via field trials with suffix.
1565TEST_F(WebRtcVideoChannelBaseTest, OverridesRecvBufferSizeWithSuffix) {
1566 // Set field trial to override the default recv buffer size, and then re-run
1567 // setup where the interface is created and configured.
1568 const int kCustomRecvBufferSize = 123456;
1569 webrtc::test::ScopedFieldTrials field_trial(
1570 "WebRTC-IncreasedReceivebuffers/123456_Dogfood/");
1571 SetUp();
1572
1573 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1574 EXPECT_TRUE(SetSend(true));
1575 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
1576 EXPECT_EQ(kCustomRecvBufferSize, network_interface_.recvbuf_size());
1577}
1578
1579// Test that we properly set the send and recv buffer sizes when overriding
1580// via field trials that don't make any sense.
1581TEST_F(WebRtcVideoChannelBaseTest, InvalidRecvBufferSize) {
1582 // Set bogus field trial values to override the default recv buffer size, and
1583 // then re-run setup where the interface is created and configured. The
1584 // default value should still be used.
1585
1586 for (std::string group : {" ", "NotANumber", "-1", "0"}) {
1587 std::string field_trial_string = "WebRTC-IncreasedReceivebuffers/";
1588 field_trial_string += group;
1589 field_trial_string += "/";
1590 webrtc::test::ScopedFieldTrials field_trial(field_trial_string);
1591 SetUp();
1592
1593 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1594 EXPECT_TRUE(SetSend(true));
1595 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
1596 EXPECT_EQ(256 * 1024, network_interface_.recvbuf_size());
1597 }
1598}
1599
Niels Möller6557d0c2018-04-11 15:18:34 +02001600// Test that stats work properly for a 1-1 call.
srtee0c2eea2017-12-15 17:44:33 +01001601TEST_F(WebRtcVideoChannelBaseTest, GetStats) {
Bjorn A Mellemda4f0932019-07-30 08:34:03 -07001602 SetUp();
1603
Niels Möller6557d0c2018-04-11 15:18:34 +02001604 const int kDurationSec = 3;
1605 const int kFps = 10;
1606 SendReceiveManyAndGetStats(DefaultCodec(), kDurationSec, kFps);
1607
1608 cricket::VideoMediaInfo info;
1609 EXPECT_TRUE(channel_->GetStats(&info));
1610
1611 ASSERT_EQ(1U, info.senders.size());
1612 // TODO(whyuan): bytes_sent and bytes_rcvd are different. Are both payload?
1613 // For webrtc, bytes_sent does not include the RTP header length.
Niels Möllerac0a4cb2019-10-09 15:01:33 +02001614 EXPECT_EQ(info.senders[0].payload_bytes_sent,
Bjorn A Mellemda4f0932019-07-30 08:34:03 -07001615 NumRtpBytes() - kRtpHeaderSize * NumRtpPackets());
Niels Möller6557d0c2018-04-11 15:18:34 +02001616 EXPECT_EQ(NumRtpPackets(), info.senders[0].packets_sent);
1617 EXPECT_EQ(0.0, info.senders[0].fraction_lost);
1618 ASSERT_TRUE(info.senders[0].codec_payload_type);
1619 EXPECT_EQ(DefaultCodec().id, *info.senders[0].codec_payload_type);
1620 EXPECT_EQ(0, info.senders[0].firs_rcvd);
1621 EXPECT_EQ(0, info.senders[0].plis_rcvd);
1622 EXPECT_EQ(0, info.senders[0].nacks_rcvd);
1623 EXPECT_EQ(kVideoWidth, info.senders[0].send_frame_width);
1624 EXPECT_EQ(kVideoHeight, info.senders[0].send_frame_height);
1625 EXPECT_GT(info.senders[0].framerate_input, 0);
1626 EXPECT_GT(info.senders[0].framerate_sent, 0);
1627
1628 EXPECT_EQ(1U, info.send_codecs.count(DefaultCodec().id));
1629 EXPECT_EQ(DefaultCodec().ToCodecParameters(),
1630 info.send_codecs[DefaultCodec().id]);
1631
1632 ASSERT_EQ(1U, info.receivers.size());
1633 EXPECT_EQ(1U, info.senders[0].ssrcs().size());
1634 EXPECT_EQ(1U, info.receivers[0].ssrcs().size());
1635 EXPECT_EQ(info.senders[0].ssrcs()[0], info.receivers[0].ssrcs()[0]);
1636 ASSERT_TRUE(info.receivers[0].codec_payload_type);
1637 EXPECT_EQ(DefaultCodec().id, *info.receivers[0].codec_payload_type);
Bjorn A Mellemda4f0932019-07-30 08:34:03 -07001638 EXPECT_EQ(NumRtpBytes() - kRtpHeaderSize * NumRtpPackets(),
Niels Möllerac0a4cb2019-10-09 15:01:33 +02001639 info.receivers[0].payload_bytes_rcvd);
Niels Möller6557d0c2018-04-11 15:18:34 +02001640 EXPECT_EQ(NumRtpPackets(), info.receivers[0].packets_rcvd);
Niels Möller6557d0c2018-04-11 15:18:34 +02001641 EXPECT_EQ(0, info.receivers[0].packets_lost);
1642 // TODO(asapersson): Not set for webrtc. Handle missing stats.
1643 // EXPECT_EQ(0, info.receivers[0].packets_concealed);
1644 EXPECT_EQ(0, info.receivers[0].firs_sent);
1645 EXPECT_EQ(0, info.receivers[0].plis_sent);
1646 EXPECT_EQ(0, info.receivers[0].nacks_sent);
1647 EXPECT_EQ(kVideoWidth, info.receivers[0].frame_width);
1648 EXPECT_EQ(kVideoHeight, info.receivers[0].frame_height);
1649 EXPECT_GT(info.receivers[0].framerate_rcvd, 0);
1650 EXPECT_GT(info.receivers[0].framerate_decoded, 0);
1651 EXPECT_GT(info.receivers[0].framerate_output, 0);
1652
1653 EXPECT_EQ(1U, info.receive_codecs.count(DefaultCodec().id));
1654 EXPECT_EQ(DefaultCodec().ToCodecParameters(),
1655 info.receive_codecs[DefaultCodec().id]);
srtee0c2eea2017-12-15 17:44:33 +01001656}
Niels Möller6557d0c2018-04-11 15:18:34 +02001657
1658// Test that stats work properly for a conf call with multiple recv streams.
srtee0c2eea2017-12-15 17:44:33 +01001659TEST_F(WebRtcVideoChannelBaseTest, GetStatsMultipleRecvStreams) {
Bjorn A Mellemda4f0932019-07-30 08:34:03 -07001660 SetUp();
1661
Niels Möller6557d0c2018-04-11 15:18:34 +02001662 cricket::FakeVideoRenderer renderer1, renderer2;
1663 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1664 cricket::VideoSendParameters parameters;
1665 parameters.codecs.push_back(DefaultCodec());
1666 parameters.conference_mode = true;
1667 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1668 EXPECT_TRUE(SetSend(true));
Yves Gerey665174f2018-06-19 15:03:05 +02001669 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
1670 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001671 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
1672 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
1673 EXPECT_EQ(0, renderer1.num_rendered_frames());
1674 EXPECT_EQ(0, renderer2.num_rendered_frames());
1675 std::vector<uint32_t> ssrcs;
1676 ssrcs.push_back(1);
1677 ssrcs.push_back(2);
1678 network_interface_.SetConferenceMode(true, ssrcs);
Niels Möller805a27e2019-01-21 12:21:27 +01001679 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001680 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kVideoWidth, kVideoHeight,
1681 kTimeout);
1682 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kVideoWidth, kVideoHeight,
1683 kTimeout);
1684
1685 EXPECT_TRUE(channel_->SetSend(false));
1686
1687 cricket::VideoMediaInfo info;
1688 EXPECT_TRUE(channel_->GetStats(&info));
1689 ASSERT_EQ(1U, info.senders.size());
1690 // TODO(whyuan): bytes_sent and bytes_rcvd are different. Are both payload?
1691 // For webrtc, bytes_sent does not include the RTP header length.
Bjorn A Mellemda4f0932019-07-30 08:34:03 -07001692 EXPECT_EQ_WAIT(NumRtpBytes() - kRtpHeaderSize * NumRtpPackets(),
Niels Möllerac0a4cb2019-10-09 15:01:33 +02001693 GetSenderStats(0).payload_bytes_sent, kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001694 EXPECT_EQ_WAIT(NumRtpPackets(), GetSenderStats(0).packets_sent, kTimeout);
1695 EXPECT_EQ(kVideoWidth, GetSenderStats(0).send_frame_width);
1696 EXPECT_EQ(kVideoHeight, GetSenderStats(0).send_frame_height);
1697
1698 ASSERT_EQ(2U, info.receivers.size());
1699 for (size_t i = 0; i < info.receivers.size(); ++i) {
1700 EXPECT_EQ(1U, GetReceiverStats(i).ssrcs().size());
1701 EXPECT_EQ(i + 1, GetReceiverStats(i).ssrcs()[0]);
Bjorn A Mellemda4f0932019-07-30 08:34:03 -07001702 EXPECT_EQ_WAIT(NumRtpBytes() - kRtpHeaderSize * NumRtpPackets(),
Niels Möllerac0a4cb2019-10-09 15:01:33 +02001703 GetReceiverStats(i).payload_bytes_rcvd, kTimeout);
Yves Gerey665174f2018-06-19 15:03:05 +02001704 EXPECT_EQ_WAIT(NumRtpPackets(), GetReceiverStats(i).packets_rcvd, kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001705 EXPECT_EQ_WAIT(kVideoWidth, GetReceiverStats(i).frame_width, kTimeout);
1706 EXPECT_EQ_WAIT(kVideoHeight, GetReceiverStats(i).frame_height, kTimeout);
1707 }
srtee0c2eea2017-12-15 17:44:33 +01001708}
Niels Möller6557d0c2018-04-11 15:18:34 +02001709
1710// Test that stats work properly for a conf call with multiple send streams.
srtee0c2eea2017-12-15 17:44:33 +01001711TEST_F(WebRtcVideoChannelBaseTest, GetStatsMultipleSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001712 // Normal setup; note that we set the SSRC explicitly to ensure that
1713 // it will come first in the senders map.
1714 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1715 cricket::VideoSendParameters parameters;
1716 parameters.codecs.push_back(DefaultCodec());
1717 parameters.conference_mode = true;
1718 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Yves Gerey665174f2018-06-19 15:03:05 +02001719 EXPECT_TRUE(
1720 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001721 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
1722 EXPECT_TRUE(SetSend(true));
Niels Möller805a27e2019-01-21 12:21:27 +01001723 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001724 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
1725 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1726
1727 // Add an additional capturer, and hook up a renderer to receive it.
1728 cricket::FakeVideoRenderer renderer2;
Niels Möller805a27e2019-01-21 12:21:27 +01001729 webrtc::test::FrameForwarder frame_forwarder;
Niels Möller6557d0c2018-04-11 15:18:34 +02001730 const int kTestWidth = 160;
1731 const int kTestHeight = 120;
Niels Möller805a27e2019-01-21 12:21:27 +01001732 cricket::FakeFrameSource frame_source(kTestWidth, kTestHeight,
1733 rtc::kNumMicrosecsPerSec / 5);
Yves Gerey665174f2018-06-19 15:03:05 +02001734 EXPECT_TRUE(
1735 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(5678)));
Niels Möller805a27e2019-01-21 12:21:27 +01001736 EXPECT_TRUE(channel_->SetVideoSend(5678, nullptr, &frame_forwarder));
Yves Gerey665174f2018-06-19 15:03:05 +02001737 EXPECT_TRUE(
1738 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(5678)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001739 EXPECT_TRUE(channel_->SetSink(5678, &renderer2));
Niels Möller805a27e2019-01-21 12:21:27 +01001740 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Yves Gerey665174f2018-06-19 15:03:05 +02001741 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kTestWidth, kTestHeight,
1742 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001743
1744 // Get stats, and make sure they are correct for two senders. We wait until
1745 // the number of expected packets have been sent to avoid races where we
1746 // check stats before it has been updated.
1747 cricket::VideoMediaInfo info;
1748 for (uint32_t i = 0; i < kTimeout; ++i) {
1749 rtc::Thread::Current()->ProcessMessages(1);
1750 EXPECT_TRUE(channel_->GetStats(&info));
1751 ASSERT_EQ(2U, info.senders.size());
1752 if (info.senders[0].packets_sent + info.senders[1].packets_sent ==
1753 NumRtpPackets()) {
1754 // Stats have been updated for both sent frames, expectations can be
1755 // checked now.
1756 break;
1757 }
1758 }
1759 EXPECT_EQ(NumRtpPackets(),
1760 info.senders[0].packets_sent + info.senders[1].packets_sent)
1761 << "Timed out while waiting for packet counts for all sent packets.";
1762 EXPECT_EQ(1U, info.senders[0].ssrcs().size());
1763 EXPECT_EQ(1234U, info.senders[0].ssrcs()[0]);
1764 EXPECT_EQ(kVideoWidth, info.senders[0].send_frame_width);
1765 EXPECT_EQ(kVideoHeight, info.senders[0].send_frame_height);
1766 EXPECT_EQ(1U, info.senders[1].ssrcs().size());
1767 EXPECT_EQ(5678U, info.senders[1].ssrcs()[0]);
1768 EXPECT_EQ(kTestWidth, info.senders[1].send_frame_width);
1769 EXPECT_EQ(kTestHeight, info.senders[1].send_frame_height);
1770 // The capturer must be unregistered here as it runs out of it's scope next.
1771 channel_->SetVideoSend(5678, nullptr, nullptr);
srtee0c2eea2017-12-15 17:44:33 +01001772}
pbos@webrtc.org8fdeee62014-07-20 14:40:23 +00001773
Niels Möller6557d0c2018-04-11 15:18:34 +02001774// Test that we can set the bandwidth.
srtee0c2eea2017-12-15 17:44:33 +01001775TEST_F(WebRtcVideoChannelBaseTest, SetSendBandwidth) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001776 cricket::VideoSendParameters parameters;
1777 parameters.codecs.push_back(DefaultCodec());
1778 parameters.max_bandwidth_bps = -1; // <= 0 means unlimited.
1779 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1780 parameters.max_bandwidth_bps = 128 * 1024;
1781 EXPECT_TRUE(channel_->SetSendParameters(parameters));
srtee0c2eea2017-12-15 17:44:33 +01001782}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001783
Niels Möller6557d0c2018-04-11 15:18:34 +02001784// Test that we can set the SSRC for the default send source.
srtee0c2eea2017-12-15 17:44:33 +01001785TEST_F(WebRtcVideoChannelBaseTest, SetSendSsrc) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001786 EXPECT_TRUE(SetDefaultCodec());
1787 EXPECT_TRUE(SetSend(true));
Niels Möller805a27e2019-01-21 12:21:27 +01001788 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001789 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001790 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001791 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001792 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1793 EXPECT_EQ(kSsrc, header.ssrc);
1794
Niels Möller6557d0c2018-04-11 15:18:34 +02001795 // Packets are being paced out, so these can mismatch between the first and
1796 // second call to NumRtpPackets until pending packets are paced out.
Åsa Persson23cd45a2018-07-03 10:40:40 +02001797 EXPECT_EQ_WAIT(NumRtpPackets(), NumRtpPackets(header.ssrc), kTimeout);
1798 EXPECT_EQ_WAIT(NumRtpBytes(), NumRtpBytes(header.ssrc), kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001799 EXPECT_EQ(1, NumSentSsrcs());
1800 EXPECT_EQ(0, NumRtpPackets(kSsrc - 1));
1801 EXPECT_EQ(0, NumRtpBytes(kSsrc - 1));
srtee0c2eea2017-12-15 17:44:33 +01001802}
Niels Möller6557d0c2018-04-11 15:18:34 +02001803
1804// Test that we can set the SSRC even after codecs are set.
srtee0c2eea2017-12-15 17:44:33 +01001805TEST_F(WebRtcVideoChannelBaseTest, SetSendSsrcAfterSetCodecs) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001806 // Remove stream added in Setup.
1807 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1808 EXPECT_TRUE(SetDefaultCodec());
Niels Möller6557d0c2018-04-11 15:18:34 +02001809 EXPECT_TRUE(
Yves Gerey665174f2018-06-19 15:03:05 +02001810 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(999)));
Niels Möller805a27e2019-01-21 12:21:27 +01001811 EXPECT_TRUE(channel_->SetVideoSend(999u, nullptr, frame_forwarder_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001812 EXPECT_TRUE(SetSend(true));
1813 EXPECT_TRUE(WaitAndSendFrame(0));
1814 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001815 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001816 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001817 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1818 EXPECT_EQ(999u, header.ssrc);
Niels Möller6557d0c2018-04-11 15:18:34 +02001819 // Packets are being paced out, so these can mismatch between the first and
1820 // second call to NumRtpPackets until pending packets are paced out.
Åsa Persson23cd45a2018-07-03 10:40:40 +02001821 EXPECT_EQ_WAIT(NumRtpPackets(), NumRtpPackets(header.ssrc), kTimeout);
1822 EXPECT_EQ_WAIT(NumRtpBytes(), NumRtpBytes(header.ssrc), kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001823 EXPECT_EQ(1, NumSentSsrcs());
1824 EXPECT_EQ(0, NumRtpPackets(kSsrc));
1825 EXPECT_EQ(0, NumRtpBytes(kSsrc));
srtee0c2eea2017-12-15 17:44:33 +01001826}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001827
Niels Möller6557d0c2018-04-11 15:18:34 +02001828// Test that we can set the default video renderer before and after
1829// media is received.
srtee0c2eea2017-12-15 17:44:33 +01001830TEST_F(WebRtcVideoChannelBaseTest, SetSink) {
Yves Gerey665174f2018-06-19 15:03:05 +02001831 uint8_t data1[] = {0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
1832 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
Niels Möller6557d0c2018-04-11 15:18:34 +02001833
1834 rtc::CopyOnWriteBuffer packet1(data1, sizeof(data1));
1835 rtc::SetBE32(packet1.data() + 8, kSsrc);
1836 channel_->SetSink(kDefaultReceiveSsrc, NULL);
1837 EXPECT_TRUE(SetDefaultCodec());
1838 EXPECT_TRUE(SetSend(true));
1839 EXPECT_EQ(0, renderer_.num_rendered_frames());
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07001840 channel_->OnPacketReceived(packet1, /* packet_time_us */ -1);
Niels Möller6557d0c2018-04-11 15:18:34 +02001841 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
Niels Möller805a27e2019-01-21 12:21:27 +01001842 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001843 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
srtee0c2eea2017-12-15 17:44:33 +01001844}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001845
Niels Möller6557d0c2018-04-11 15:18:34 +02001846// Tests setting up and configuring a send stream.
srtee0c2eea2017-12-15 17:44:33 +01001847TEST_F(WebRtcVideoChannelBaseTest, AddRemoveSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001848 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1849 EXPECT_TRUE(SetSend(true));
1850 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
Niels Möller805a27e2019-01-21 12:21:27 +01001851 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001852 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1853 EXPECT_GT(NumRtpPackets(), 0);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001854 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001855 size_t last_packet = NumRtpPackets() - 1;
Yves Gerey665174f2018-06-19 15:03:05 +02001856 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(
1857 GetRtpPacket(static_cast<int>(last_packet)));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001858 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1859 EXPECT_EQ(kSsrc, header.ssrc);
Niels Möller6557d0c2018-04-11 15:18:34 +02001860
1861 // Remove the send stream that was added during Setup.
1862 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1863 int rtp_packets = NumRtpPackets();
1864
Niels Möller6557d0c2018-04-11 15:18:34 +02001865 EXPECT_TRUE(
Yves Gerey665174f2018-06-19 15:03:05 +02001866 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(789u)));
Niels Möller805a27e2019-01-21 12:21:27 +01001867 EXPECT_TRUE(channel_->SetVideoSend(789u, nullptr, frame_forwarder_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001868 EXPECT_EQ(rtp_packets, NumRtpPackets());
1869 // Wait 30ms to guarantee the engine does not drop the frame.
1870 EXPECT_TRUE(WaitAndSendFrame(30));
1871 EXPECT_TRUE_WAIT(NumRtpPackets() > rtp_packets, kTimeout);
1872
1873 last_packet = NumRtpPackets() - 1;
1874 p.reset(GetRtpPacket(static_cast<int>(last_packet)));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001875 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1876 EXPECT_EQ(789u, header.ssrc);
srtee0c2eea2017-12-15 17:44:33 +01001877}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001878
Niels Möller6557d0c2018-04-11 15:18:34 +02001879// Tests the behavior of incoming streams in a conference scenario.
srtee0c2eea2017-12-15 17:44:33 +01001880TEST_F(WebRtcVideoChannelBaseTest, SimulateConference) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001881 cricket::FakeVideoRenderer renderer1, renderer2;
1882 EXPECT_TRUE(SetDefaultCodec());
1883 cricket::VideoSendParameters parameters;
1884 parameters.codecs.push_back(DefaultCodec());
1885 parameters.conference_mode = true;
1886 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1887 EXPECT_TRUE(SetSend(true));
Yves Gerey665174f2018-06-19 15:03:05 +02001888 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
1889 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001890 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
1891 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
1892 EXPECT_EQ(0, renderer1.num_rendered_frames());
1893 EXPECT_EQ(0, renderer2.num_rendered_frames());
1894 std::vector<uint32_t> ssrcs;
1895 ssrcs.push_back(1);
1896 ssrcs.push_back(2);
1897 network_interface_.SetConferenceMode(true, ssrcs);
Niels Möller805a27e2019-01-21 12:21:27 +01001898 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001899 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kVideoWidth, kVideoHeight,
1900 kTimeout);
1901 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kVideoWidth, kVideoHeight,
1902 kTimeout);
1903
1904 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1905 EXPECT_EQ(DefaultCodec().id, GetPayloadType(p.get()));
1906 EXPECT_EQ(kVideoWidth, renderer1.width());
1907 EXPECT_EQ(kVideoHeight, renderer1.height());
1908 EXPECT_EQ(kVideoWidth, renderer2.width());
1909 EXPECT_EQ(kVideoHeight, renderer2.height());
1910 EXPECT_TRUE(channel_->RemoveRecvStream(2));
1911 EXPECT_TRUE(channel_->RemoveRecvStream(1));
srtee0c2eea2017-12-15 17:44:33 +01001912}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001913
Niels Möller6557d0c2018-04-11 15:18:34 +02001914// Tests that we can add and remove capturers and frames are sent out properly
srtee0c2eea2017-12-15 17:44:33 +01001915TEST_F(WebRtcVideoChannelBaseTest, DISABLED_AddRemoveCapturer) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001916 using cricket::FOURCC_I420;
Jonas Olssona4d87372019-07-05 19:08:33 +02001917 using cricket::VideoCodec;
1918 using cricket::VideoFormat;
1919 using cricket::VideoOptions;
Niels Möller6557d0c2018-04-11 15:18:34 +02001920
1921 VideoCodec codec = DefaultCodec();
1922 const int time_between_send_ms = VideoFormat::FpsToInterval(kFramerate);
1923 EXPECT_TRUE(SetOneCodec(codec));
1924 EXPECT_TRUE(SetSend(true));
1925 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1926 EXPECT_EQ(0, renderer_.num_rendered_frames());
Niels Möller805a27e2019-01-21 12:21:27 +01001927 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001928 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
Niels Möller805a27e2019-01-21 12:21:27 +01001929
1930 webrtc::test::FrameForwarder frame_forwarder;
1931 cricket::FakeFrameSource frame_source(480, 360, rtc::kNumMicrosecsPerSec / 30,
1932 rtc::kNumMicrosecsPerSec / 30);
Niels Möller6557d0c2018-04-11 15:18:34 +02001933
1934 // TODO(nisse): This testcase fails if we don't configure
1935 // screencast. It's unclear why, I see nothing obvious in this
1936 // test which is related to screencast logic.
1937 VideoOptions video_options;
1938 video_options.is_screencast = true;
1939 channel_->SetVideoSend(kSsrc, &video_options, nullptr);
1940
Niels Möller6557d0c2018-04-11 15:18:34 +02001941 int captured_frames = 1;
1942 for (int iterations = 0; iterations < 2; ++iterations) {
Niels Möller805a27e2019-01-21 12:21:27 +01001943 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
Niels Möller6557d0c2018-04-11 15:18:34 +02001944 rtc::Thread::Current()->ProcessMessages(time_between_send_ms);
Niels Möller805a27e2019-01-21 12:21:27 +01001945 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
1946
Niels Möller6557d0c2018-04-11 15:18:34 +02001947 ++captured_frames;
1948 // Wait until frame of right size is captured.
1949 EXPECT_TRUE_WAIT(renderer_.num_rendered_frames() >= captured_frames &&
Niels Möller805a27e2019-01-21 12:21:27 +01001950 480 == renderer_.width() &&
1951 360 == renderer_.height() && !renderer_.black_frame(),
Yves Gerey665174f2018-06-19 15:03:05 +02001952 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001953 EXPECT_GE(renderer_.num_rendered_frames(), captured_frames);
Niels Möller805a27e2019-01-21 12:21:27 +01001954 EXPECT_EQ(480, renderer_.width());
1955 EXPECT_EQ(360, renderer_.height());
Niels Möller6557d0c2018-04-11 15:18:34 +02001956 captured_frames = renderer_.num_rendered_frames() + 1;
1957 EXPECT_FALSE(renderer_.black_frame());
1958 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1959 // Make sure a black frame is generated within the specified timeout.
1960 // The black frame should be the resolution of the previous frame to
1961 // prevent expensive encoder reconfigurations.
1962 EXPECT_TRUE_WAIT(renderer_.num_rendered_frames() >= captured_frames &&
Niels Möller805a27e2019-01-21 12:21:27 +01001963 480 == renderer_.width() &&
1964 360 == renderer_.height() && renderer_.black_frame(),
Yves Gerey665174f2018-06-19 15:03:05 +02001965 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001966 EXPECT_GE(renderer_.num_rendered_frames(), captured_frames);
Niels Möller805a27e2019-01-21 12:21:27 +01001967 EXPECT_EQ(480, renderer_.width());
1968 EXPECT_EQ(360, renderer_.height());
Niels Möller6557d0c2018-04-11 15:18:34 +02001969 EXPECT_TRUE(renderer_.black_frame());
1970
1971 // The black frame has the same timestamp as the next frame since it's
1972 // timestamp is set to the last frame's timestamp + interval. WebRTC will
1973 // not render a frame with the same timestamp so capture another frame
1974 // with the frame capturer to increment the next frame's timestamp.
Niels Möller805a27e2019-01-21 12:21:27 +01001975 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller6557d0c2018-04-11 15:18:34 +02001976 }
srtee0c2eea2017-12-15 17:44:33 +01001977}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001978
Niels Möller6557d0c2018-04-11 15:18:34 +02001979// Tests that if SetVideoSend is called with a NULL capturer after the
1980// capturer was already removed, the application doesn't crash (and no black
1981// frame is sent).
srtee0c2eea2017-12-15 17:44:33 +01001982TEST_F(WebRtcVideoChannelBaseTest, RemoveCapturerWithoutAdd) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001983 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1984 EXPECT_TRUE(SetSend(true));
1985 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1986 EXPECT_EQ(0, renderer_.num_rendered_frames());
Niels Möller805a27e2019-01-21 12:21:27 +01001987 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001988 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1989 // Wait for one frame so they don't get dropped because we send frames too
1990 // tightly.
1991 rtc::Thread::Current()->ProcessMessages(30);
1992 // Remove the capturer.
1993 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1994
1995 // No capturer was added, so this SetVideoSend shouldn't do anything.
1996 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1997 rtc::Thread::Current()->ProcessMessages(300);
1998 // Verify no more frames were sent.
1999 EXPECT_EQ(1, renderer_.num_rendered_frames());
srtee0c2eea2017-12-15 17:44:33 +01002000}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002001
Niels Möller6557d0c2018-04-11 15:18:34 +02002002// Tests that we can add and remove capturer as unique sources.
srtee0c2eea2017-12-15 17:44:33 +01002003TEST_F(WebRtcVideoChannelBaseTest, AddRemoveCapturerMultipleSources) {
Niels Möller6557d0c2018-04-11 15:18:34 +02002004 // WebRTC implementation will drop frames if pushed to quickly. Wait the
2005 // interval time to avoid that.
2006 // WebRTC implementation will drop frames if pushed to quickly. Wait the
2007 // interval time to avoid that.
2008 // Set up the stream associated with the engine.
Yves Gerey665174f2018-06-19 15:03:05 +02002009 EXPECT_TRUE(
2010 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02002011 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
2012 cricket::VideoFormat capture_format(
2013 kVideoWidth, kVideoHeight,
2014 cricket::VideoFormat::FpsToInterval(kFramerate), cricket::FOURCC_I420);
2015 // Set up additional stream 1.
2016 cricket::FakeVideoRenderer renderer1;
2017 EXPECT_FALSE(channel_->SetSink(1, &renderer1));
Yves Gerey665174f2018-06-19 15:03:05 +02002018 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
Niels Möller6557d0c2018-04-11 15:18:34 +02002019 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
Yves Gerey665174f2018-06-19 15:03:05 +02002020 EXPECT_TRUE(channel_->AddSendStream(cricket::StreamParams::CreateLegacy(1)));
Niels Möller805a27e2019-01-21 12:21:27 +01002021
2022 webrtc::test::FrameForwarder frame_forwarder1;
2023 cricket::FakeFrameSource frame_source(kVideoWidth, kVideoHeight,
2024 rtc::kNumMicrosecsPerSec / kFramerate);
2025
Niels Möller6557d0c2018-04-11 15:18:34 +02002026 // Set up additional stream 2.
2027 cricket::FakeVideoRenderer renderer2;
2028 EXPECT_FALSE(channel_->SetSink(2, &renderer2));
Yves Gerey665174f2018-06-19 15:03:05 +02002029 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02002030 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
Yves Gerey665174f2018-06-19 15:03:05 +02002031 EXPECT_TRUE(channel_->AddSendStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller805a27e2019-01-21 12:21:27 +01002032 webrtc::test::FrameForwarder frame_forwarder2;
2033
Niels Möller6557d0c2018-04-11 15:18:34 +02002034 // State for all the streams.
2035 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
2036 // A limitation in the lmi implementation requires that SetVideoSend() is
2037 // called after SetOneCodec().
2038 // TODO(hellner): this seems like an unnecessary constraint, fix it.
Niels Möller805a27e2019-01-21 12:21:27 +01002039 EXPECT_TRUE(channel_->SetVideoSend(1, nullptr, &frame_forwarder1));
2040 EXPECT_TRUE(channel_->SetVideoSend(2, nullptr, &frame_forwarder2));
Niels Möller6557d0c2018-04-11 15:18:34 +02002041 EXPECT_TRUE(SetSend(true));
2042 // Test capturer associated with engine.
2043 const int kTestWidth = 160;
2044 const int kTestHeight = 120;
Niels Möller805a27e2019-01-21 12:21:27 +01002045 frame_forwarder1.IncomingCapturedFrame(frame_source.GetFrame(
2046 kTestWidth, kTestHeight, webrtc::VideoRotation::kVideoRotation_0,
2047 rtc::kNumMicrosecsPerSec / kFramerate));
Yves Gerey665174f2018-06-19 15:03:05 +02002048 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kTestWidth, kTestHeight,
2049 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02002050 // Capture a frame with additional capturer2, frames should be received
Niels Möller805a27e2019-01-21 12:21:27 +01002051 frame_forwarder2.IncomingCapturedFrame(frame_source.GetFrame(
2052 kTestWidth, kTestHeight, webrtc::VideoRotation::kVideoRotation_0,
2053 rtc::kNumMicrosecsPerSec / kFramerate));
Yves Gerey665174f2018-06-19 15:03:05 +02002054 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kTestWidth, kTestHeight,
2055 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02002056 // Successfully remove the capturer.
2057 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
2058 // The capturers must be unregistered here as it runs out of it's scope
2059 // next.
2060 EXPECT_TRUE(channel_->SetVideoSend(1, nullptr, nullptr));
2061 EXPECT_TRUE(channel_->SetVideoSend(2, nullptr, nullptr));
srtee0c2eea2017-12-15 17:44:33 +01002062}
Niels Möller6557d0c2018-04-11 15:18:34 +02002063
2064// Tests empty StreamParams is rejected.
srtee0c2eea2017-12-15 17:44:33 +01002065TEST_F(WebRtcVideoChannelBaseTest, RejectEmptyStreamParams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02002066 // Remove the send stream that was added during Setup.
2067 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
2068
2069 cricket::StreamParams empty;
2070 EXPECT_FALSE(channel_->AddSendStream(empty));
Yves Gerey665174f2018-06-19 15:03:05 +02002071 EXPECT_TRUE(
2072 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(789u)));
srtee0c2eea2017-12-15 17:44:33 +01002073}
Niels Möller6557d0c2018-04-11 15:18:34 +02002074
2075// Test that multiple send streams can be created and deleted properly.
srtee0c2eea2017-12-15 17:44:33 +01002076TEST_F(WebRtcVideoChannelBaseTest, MultipleSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02002077 // Remove stream added in Setup. I.e. remove stream corresponding to default
2078 // channel.
2079 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02002080 const unsigned int kSsrcsSize = sizeof(kSsrcs4) / sizeof(kSsrcs4[0]);
Niels Möller6557d0c2018-04-11 15:18:34 +02002081 for (unsigned int i = 0; i < kSsrcsSize; ++i) {
2082 EXPECT_TRUE(channel_->AddSendStream(
2083 cricket::StreamParams::CreateLegacy(kSsrcs4[i])));
2084 }
2085 // Delete one of the non default channel streams, let the destructor delete
2086 // the remaining ones.
2087 EXPECT_TRUE(channel_->RemoveSendStream(kSsrcs4[kSsrcsSize - 1]));
2088 // Stream should already be deleted.
2089 EXPECT_FALSE(channel_->RemoveSendStream(kSsrcs4[kSsrcsSize - 1]));
srtee0c2eea2017-12-15 17:44:33 +01002090}
pbos@webrtc.orgc4175b92014-09-03 15:25:49 +00002091
eladalonf1841382017-06-12 01:16:46 -07002092TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8Vga) {
magjed509e4fe2016-11-18 01:34:11 -08002093 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00002094}
2095
eladalonf1841382017-06-12 01:16:46 -07002096TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8Qvga) {
magjed509e4fe2016-11-18 01:34:11 -08002097 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00002098}
2099
eladalonf1841382017-06-12 01:16:46 -07002100TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8SvcQqvga) {
magjed509e4fe2016-11-18 01:34:11 -08002101 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00002102}
2103
eladalonf1841382017-06-12 01:16:46 -07002104TEST_F(WebRtcVideoChannelBaseTest, TwoStreamsSendAndReceive) {
Peter Boströmd1f584b2016-04-20 16:31:53 +02002105 // Set a high bitrate to not be downscaled by VP8 due to low initial start
2106 // bitrates. This currently happens at <250k, and two streams sharing 300k
2107 // initially will use QVGA instead of VGA.
2108 // TODO(pbos): Set up the quality scaler so that both senders reliably start
2109 // at QVGA, then verify that instead.
magjed509e4fe2016-11-18 01:34:11 -08002110 cricket::VideoCodec codec = GetEngineCodec("VP8");
Peter Boströmd1f584b2016-04-20 16:31:53 +02002111 codec.params[kCodecParamStartBitrate] = "1000000";
Niels Möller6557d0c2018-04-11 15:18:34 +02002112 TwoStreamsSendAndReceive(codec);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002113}
2114
philipeld9cc8c02019-09-16 14:53:40 +02002115TEST_F(WebRtcVideoChannelBaseTest, RequestEncoderFallback) {
philipele8ed8302019-07-03 11:53:48 +02002116 cricket::VideoSendParameters parameters;
2117 parameters.codecs.push_back(GetEngineCodec("VP9"));
2118 parameters.codecs.push_back(GetEngineCodec("VP8"));
2119 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2120
2121 VideoCodec codec;
2122 ASSERT_TRUE(channel_->GetSendCodec(&codec));
2123 EXPECT_EQ("VP9", codec.name);
2124
philipeld9cc8c02019-09-16 14:53:40 +02002125 // RequestEncoderFallback will post a task to the worker thread (which is also
philipele8ed8302019-07-03 11:53:48 +02002126 // the current thread), hence the ProcessMessages call.
philipeld9cc8c02019-09-16 14:53:40 +02002127 channel_->RequestEncoderFallback();
philipele8ed8302019-07-03 11:53:48 +02002128 rtc::Thread::Current()->ProcessMessages(30);
2129 ASSERT_TRUE(channel_->GetSendCodec(&codec));
2130 EXPECT_EQ("VP8", codec.name);
2131
2132 // No other codec to fall back to, keep using VP8.
philipeld9cc8c02019-09-16 14:53:40 +02002133 channel_->RequestEncoderFallback();
philipele8ed8302019-07-03 11:53:48 +02002134 rtc::Thread::Current()->ProcessMessages(30);
2135 ASSERT_TRUE(channel_->GetSendCodec(&codec));
2136 EXPECT_EQ("VP8", codec.name);
2137}
2138
philipeld9cc8c02019-09-16 14:53:40 +02002139TEST_F(WebRtcVideoChannelBaseTest, RequestEncoderSwitchWithConfig) {
2140 const std::string kParam = "the-param";
2141 const std::string kPing = "ping";
2142 const std::string kPong = "pong";
2143
2144 cricket::VideoSendParameters parameters;
2145 VideoCodec vp9 = GetEngineCodec("VP9");
2146 vp9.params[kParam] = kPong;
2147 parameters.codecs.push_back(vp9);
2148
2149 VideoCodec vp8 = GetEngineCodec("VP8");
2150 vp8.params[kParam] = kPing;
2151 parameters.codecs.push_back(vp8);
2152
2153 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2154
2155 VideoCodec codec;
2156 ASSERT_TRUE(channel_->GetSendCodec(&codec));
2157 EXPECT_THAT(codec.name, Eq("VP9"));
2158
2159 // RequestEncoderSwitch will post a task to the worker thread (which is also
2160 // the current thread), hence the ProcessMessages call.
2161 webrtc::EncoderSwitchRequestCallback::Config conf1{"VP8", kParam, kPing};
2162 channel_->RequestEncoderSwitch(conf1);
2163 rtc::Thread::Current()->ProcessMessages(30);
2164 ASSERT_TRUE(channel_->GetSendCodec(&codec));
2165 EXPECT_THAT(codec.name, Eq("VP8"));
2166 EXPECT_THAT(codec.params, Contains(Pair(kParam, kPing)));
2167
2168 webrtc::EncoderSwitchRequestCallback::Config conf2{"VP9", kParam, kPong};
2169 channel_->RequestEncoderSwitch(conf2);
2170 rtc::Thread::Current()->ProcessMessages(30);
2171 ASSERT_TRUE(channel_->GetSendCodec(&codec));
2172 EXPECT_THAT(codec.name, Eq("VP9"));
2173 EXPECT_THAT(codec.params, Contains(Pair(kParam, kPong)));
2174}
2175
2176TEST_F(WebRtcVideoChannelBaseTest, RequestEncoderSwitchIncorrectParam) {
2177 const std::string kParam = "the-param";
2178 const std::string kPing = "ping";
2179 const std::string kPong = "pong";
2180
2181 cricket::VideoSendParameters parameters;
2182 VideoCodec vp9 = GetEngineCodec("VP9");
2183 vp9.params[kParam] = kPong;
2184 parameters.codecs.push_back(vp9);
2185
2186 VideoCodec vp8 = GetEngineCodec("VP8");
2187 vp8.params[kParam] = kPing;
2188 parameters.codecs.push_back(vp8);
2189
2190 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2191
2192 VideoCodec codec;
2193 ASSERT_TRUE(channel_->GetSendCodec(&codec));
2194 EXPECT_THAT(codec.name, Eq("VP9"));
2195
2196 // RequestEncoderSwitch will post a task to the worker thread (which is also
2197 // the current thread), hence the ProcessMessages call.
2198 webrtc::EncoderSwitchRequestCallback::Config conf1{"VP8", kParam, kPing};
2199 channel_->RequestEncoderSwitch(conf1);
2200 rtc::Thread::Current()->ProcessMessages(30);
2201 ASSERT_TRUE(channel_->GetSendCodec(&codec));
2202 EXPECT_THAT(codec.name, Eq("VP8"));
2203 EXPECT_THAT(codec.params, Contains(Pair(kParam, kPing)));
2204
2205 // Incorrect conf2.value, expect no codec switch.
2206 webrtc::EncoderSwitchRequestCallback::Config conf2{"VP9", kParam, kPing};
2207 channel_->RequestEncoderSwitch(conf2);
2208 rtc::Thread::Current()->ProcessMessages(30);
2209 ASSERT_TRUE(channel_->GetSendCodec(&codec));
2210 EXPECT_THAT(codec.name, Eq("VP8"));
2211 EXPECT_THAT(codec.params, Contains(Pair(kParam, kPing)));
2212}
2213
eladalonf1841382017-06-12 01:16:46 -07002214class WebRtcVideoChannelTest : public WebRtcVideoEngineTest {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002215 public:
eladalonf1841382017-06-12 01:16:46 -07002216 WebRtcVideoChannelTest() : WebRtcVideoChannelTest("") {}
2217 explicit WebRtcVideoChannelTest(const char* field_trials)
Niels Möller805a27e2019-01-21 12:21:27 +01002218 : WebRtcVideoEngineTest(field_trials),
2219 frame_source_(1280, 720, rtc::kNumMicrosecsPerSec / 30),
2220 last_ssrc_(0) {}
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00002221 void SetUp() override {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02002222 encoder_factory_->AddSupportedVideoCodecType("VP8");
2223 encoder_factory_->AddSupportedVideoCodecType("VP9");
2224#if defined(WEBRTC_USE_H264)
2225 encoder_factory_->AddSupportedVideoCodecType("H264");
2226#endif
2227
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002228 fake_call_.reset(new FakeCall());
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02002229 channel_.reset(engine_.CreateMediaChannel(
2230 fake_call_.get(), GetMediaConfig(), VideoOptions(),
2231 webrtc::CryptoOptions(), video_bitrate_allocator_factory_.get()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002232 channel_->OnReadyToSend(true);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002233 last_ssrc_ = 123;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002234 send_parameters_.codecs = engine_.codecs();
2235 recv_parameters_.codecs = engine_.codecs();
2236 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002237 }
2238
2239 protected:
2240 FakeVideoSendStream* AddSendStream() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002241 return AddSendStream(StreamParams::CreateLegacy(++last_ssrc_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002242 }
2243
2244 FakeVideoSendStream* AddSendStream(const StreamParams& sp) {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002245 size_t num_streams = fake_call_->GetVideoSendStreams().size();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002246 EXPECT_TRUE(channel_->AddSendStream(sp));
2247 std::vector<FakeVideoSendStream*> streams =
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002248 fake_call_->GetVideoSendStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002249 EXPECT_EQ(num_streams + 1, streams.size());
2250 return streams[streams.size() - 1];
2251 }
2252
2253 std::vector<FakeVideoSendStream*> GetFakeSendStreams() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002254 return fake_call_->GetVideoSendStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002255 }
2256
2257 FakeVideoReceiveStream* AddRecvStream() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002258 return AddRecvStream(StreamParams::CreateLegacy(++last_ssrc_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002259 }
2260
2261 FakeVideoReceiveStream* AddRecvStream(const StreamParams& sp) {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002262 size_t num_streams = fake_call_->GetVideoReceiveStreams().size();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002263 EXPECT_TRUE(channel_->AddRecvStream(sp));
2264 std::vector<FakeVideoReceiveStream*> streams =
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002265 fake_call_->GetVideoReceiveStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002266 EXPECT_EQ(num_streams + 1, streams.size());
2267 return streams[streams.size() - 1];
2268 }
2269
pbos@webrtc.org00873182014-11-25 14:03:34 +00002270 void SetSendCodecsShouldWorkForBitrates(const char* min_bitrate_kbps,
2271 int expected_min_bitrate_bps,
2272 const char* start_bitrate_kbps,
2273 int expected_start_bitrate_bps,
2274 const char* max_bitrate_kbps,
2275 int expected_max_bitrate_bps) {
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002276 ExpectSetBitrateParameters(expected_min_bitrate_bps,
2277 expected_start_bitrate_bps,
2278 expected_max_bitrate_bps);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002279 auto& codecs = send_parameters_.codecs;
2280 codecs.clear();
magjed509e4fe2016-11-18 01:34:11 -08002281 codecs.push_back(GetEngineCodec("VP8"));
pbos@webrtc.org00873182014-11-25 14:03:34 +00002282 codecs[0].params[kCodecParamMinBitrate] = min_bitrate_kbps;
2283 codecs[0].params[kCodecParamStartBitrate] = start_bitrate_kbps;
2284 codecs[0].params[kCodecParamMaxBitrate] = max_bitrate_kbps;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002285 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002286 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002287
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002288 void ExpectSetBitrateParameters(int min_bitrate_bps,
2289 int start_bitrate_bps,
2290 int max_bitrate_bps) {
2291 EXPECT_CALL(
2292 *fake_call_->GetMockTransportControllerSend(),
2293 SetSdpBitrateParameters(AllOf(
2294 Field(&BitrateConstraints::min_bitrate_bps, min_bitrate_bps),
2295 Field(&BitrateConstraints::start_bitrate_bps, start_bitrate_bps),
2296 Field(&BitrateConstraints::max_bitrate_bps, max_bitrate_bps))));
2297 }
2298
2299 void ExpectSetMaxBitrate(int max_bitrate_bps) {
2300 EXPECT_CALL(*fake_call_->GetMockTransportControllerSend(),
2301 SetSdpBitrateParameters(Field(
2302 &BitrateConstraints::max_bitrate_bps, max_bitrate_bps)));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002303 }
2304
Johannes Kron9190b822018-10-29 11:22:05 +01002305 void TestExtmapAllowMixedCaller(bool extmap_allow_mixed) {
2306 // For a caller, the answer will be applied in set remote description
2307 // where SetSendParameters() is called.
2308 EXPECT_TRUE(
2309 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
2310 send_parameters_.extmap_allow_mixed = extmap_allow_mixed;
2311 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
2312 const webrtc::VideoSendStream::Config& config =
2313 fake_call_->GetVideoSendStreams()[0]->GetConfig();
2314 EXPECT_EQ(extmap_allow_mixed, config.rtp.extmap_allow_mixed);
2315 }
2316
2317 void TestExtmapAllowMixedCallee(bool extmap_allow_mixed) {
2318 // For a callee, the answer will be applied in set local description
2319 // where SetExtmapAllowMixed() and AddSendStream() are called.
2320 channel_->SetExtmapAllowMixed(extmap_allow_mixed);
2321 EXPECT_TRUE(
2322 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
2323 const webrtc::VideoSendStream::Config& config =
2324 fake_call_->GetVideoSendStreams()[0]->GetConfig();
2325 EXPECT_EQ(extmap_allow_mixed, config.rtp.extmap_allow_mixed);
2326 }
2327
isheriff6f8d6862016-05-26 11:24:55 -07002328 void TestSetSendRtpHeaderExtensions(const std::string& ext_uri) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002329 // Enable extension.
2330 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002331 cricket::VideoSendParameters parameters = send_parameters_;
isheriff6f8d6862016-05-26 11:24:55 -07002332 parameters.extensions.push_back(RtpExtension(ext_uri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002333 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002334 FakeVideoSendStream* send_stream =
2335 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2336
2337 // Verify the send extension id.
2338 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2339 EXPECT_EQ(id, send_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002340 EXPECT_EQ(ext_uri, send_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002341 // Verify call with same set of extensions returns true.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002342 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002343 // Verify that SetSendRtpHeaderExtensions doesn't implicitly add them for
2344 // receivers.
2345 EXPECT_TRUE(AddRecvStream(cricket::StreamParams::CreateLegacy(123))
2346 ->GetConfig()
2347 .rtp.extensions.empty());
2348
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002349 // Verify that existing RTP header extensions can be removed.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002350 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002351 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2352 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002353 EXPECT_TRUE(send_stream->GetConfig().rtp.extensions.empty());
2354
2355 // Verify that adding receive RTP header extensions adds them for existing
2356 // streams.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002357 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002358 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002359 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2360 EXPECT_EQ(id, send_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002361 EXPECT_EQ(ext_uri, send_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002362 }
2363
isheriff6f8d6862016-05-26 11:24:55 -07002364 void TestSetRecvRtpHeaderExtensions(const std::string& ext_uri) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002365 // Enable extension.
2366 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002367 cricket::VideoRecvParameters parameters = recv_parameters_;
isheriff6f8d6862016-05-26 11:24:55 -07002368 parameters.extensions.push_back(RtpExtension(ext_uri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002369 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002370
2371 FakeVideoReceiveStream* recv_stream =
2372 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2373
2374 // Verify the recv extension id.
2375 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
2376 EXPECT_EQ(id, recv_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002377 EXPECT_EQ(ext_uri, recv_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002378 // Verify call with same set of extensions returns true.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002379 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002380
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002381 // Verify that SetRecvRtpHeaderExtensions doesn't implicitly add them for
2382 // senders.
2383 EXPECT_TRUE(AddSendStream(cricket::StreamParams::CreateLegacy(123))
2384 ->GetConfig()
2385 .rtp.extensions.empty());
2386
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002387 // Verify that existing RTP header extensions can be removed.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002388 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002389 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
2390 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002391 EXPECT_TRUE(recv_stream->GetConfig().rtp.extensions.empty());
2392
2393 // Verify that adding receive RTP header extensions adds them for existing
2394 // streams.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002395 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002396 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002397 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
2398 EXPECT_EQ(id, recv_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002399 EXPECT_EQ(ext_uri, recv_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002400 }
2401
Elad Alonfadb1812019-05-24 13:40:02 +02002402 void TestLossNotificationState(bool expect_lntf_enabled) {
2403 AssignDefaultCodec();
2404 VerifyCodecHasDefaultFeedbackParams(default_codec_, expect_lntf_enabled);
2405
2406 cricket::VideoSendParameters parameters;
2407 parameters.codecs = engine_.codecs();
2408 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2409 EXPECT_TRUE(channel_->SetSend(true));
2410
2411 // Send side.
2412 FakeVideoSendStream* send_stream =
2413 AddSendStream(cricket::StreamParams::CreateLegacy(1));
2414 EXPECT_EQ(send_stream->GetConfig().rtp.lntf.enabled, expect_lntf_enabled);
2415
2416 // Receiver side.
2417 FakeVideoReceiveStream* recv_stream =
2418 AddRecvStream(cricket::StreamParams::CreateLegacy(1));
2419 EXPECT_EQ(recv_stream->GetConfig().rtp.lntf.enabled, expect_lntf_enabled);
2420 }
2421
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002422 void TestExtensionFilter(const std::vector<std::string>& extensions,
2423 const std::string& expected_extension) {
2424 cricket::VideoSendParameters parameters = send_parameters_;
2425 int expected_id = -1;
2426 int id = 1;
2427 for (const std::string& extension : extensions) {
2428 if (extension == expected_extension)
2429 expected_id = id;
isheriff6f8d6862016-05-26 11:24:55 -07002430 parameters.extensions.push_back(RtpExtension(extension, id++));
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002431 }
2432 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2433 FakeVideoSendStream* send_stream =
2434 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2435
2436 // Verify that only one of them has been set, and that it is the one with
2437 // highest priority (transport sequence number).
2438 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2439 EXPECT_EQ(expected_id, send_stream->GetConfig().rtp.extensions[0].id);
2440 EXPECT_EQ(expected_extension,
isheriff6f8d6862016-05-26 11:24:55 -07002441 send_stream->GetConfig().rtp.extensions[0].uri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002442 }
2443
asapersson3c81a1a2017-06-14 05:52:21 -07002444 void TestDegradationPreference(bool resolution_scaling_enabled,
2445 bool fps_scaling_enabled);
2446
Erik Språngefbde372015-04-29 16:21:28 +02002447 void TestCpuAdaptation(bool enable_overuse, bool is_screenshare);
Peter Boström3548dd22015-05-22 18:48:36 +02002448 void TestReceiverLocalSsrcConfiguration(bool receiver_first);
magjed509e4fe2016-11-18 01:34:11 -08002449 void TestReceiveUnsignaledSsrcPacket(uint8_t payload_type,
2450 bool expect_created_receive_stream);
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002451
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002452 FakeVideoSendStream* SetDenoisingOption(
nisse05103312016-03-16 02:22:50 -07002453 uint32_t ssrc,
Niels Möller805a27e2019-01-21 12:21:27 +01002454 webrtc::test::FrameForwarder* frame_forwarder,
nisse0db023a2016-03-01 04:29:59 -08002455 bool enabled) {
nisse05103312016-03-16 02:22:50 -07002456 cricket::VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002457 options.video_noise_reduction = enabled;
Niels Möller805a27e2019-01-21 12:21:27 +01002458 EXPECT_TRUE(channel_->SetVideoSend(ssrc, &options, frame_forwarder));
nisse0db023a2016-03-01 04:29:59 -08002459 // Options only take effect on the next frame.
Niels Möller805a27e2019-01-21 12:21:27 +01002460 frame_forwarder->IncomingCapturedFrame(frame_source_.GetFrame());
nisse0db023a2016-03-01 04:29:59 -08002461
Erik Språng143cec12015-04-28 10:01:41 +02002462 return fake_call_->GetVideoSendStreams().back();
2463 }
2464
Peter Boström2feafdb2015-09-09 14:32:14 +02002465 FakeVideoSendStream* SetUpSimulcast(bool enabled, bool with_rtx) {
2466 const int kRtxSsrcOffset = 0xDEADBEEF;
Erik Språng143cec12015-04-28 10:01:41 +02002467 last_ssrc_ += 3;
Peter Boström2feafdb2015-09-09 14:32:14 +02002468 std::vector<uint32_t> ssrcs;
2469 std::vector<uint32_t> rtx_ssrcs;
2470 uint32_t num_streams = enabled ? 3 : 1;
2471 for (uint32_t i = 0; i < num_streams; ++i) {
2472 uint32_t ssrc = last_ssrc_ + i;
2473 ssrcs.push_back(ssrc);
2474 if (with_rtx) {
2475 rtx_ssrcs.push_back(ssrc + kRtxSsrcOffset);
2476 }
Erik Språng143cec12015-04-28 10:01:41 +02002477 }
Peter Boström2feafdb2015-09-09 14:32:14 +02002478 if (with_rtx) {
2479 return AddSendStream(
2480 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
2481 }
2482 return AddSendStream(CreateSimStreamParams("cname", ssrcs));
Erik Språng143cec12015-04-28 10:01:41 +02002483 }
2484
perkjfa10b552016-10-02 23:45:26 -07002485 int GetMaxEncoderBitrate() {
skvladdc1c62c2016-03-16 19:07:43 -07002486 std::vector<FakeVideoSendStream*> streams =
2487 fake_call_->GetVideoSendStreams();
perkjfa10b552016-10-02 23:45:26 -07002488 EXPECT_EQ(1u, streams.size());
skvladdc1c62c2016-03-16 19:07:43 -07002489 FakeVideoSendStream* stream = streams[streams.size() - 1];
Mirko Bonadeif859e552018-05-30 15:31:29 +02002490 EXPECT_EQ(1u, stream->GetEncoderConfig().number_of_streams);
perkjfa10b552016-10-02 23:45:26 -07002491 return stream->GetVideoStreams()[0].max_bitrate_bps;
skvladdc1c62c2016-03-16 19:07:43 -07002492 }
2493
perkjfa10b552016-10-02 23:45:26 -07002494 void SetAndExpectMaxBitrate(int global_max,
skvladdc1c62c2016-03-16 19:07:43 -07002495 int stream_max,
2496 int expected_encoder_bitrate) {
2497 VideoSendParameters limited_send_params = send_parameters_;
2498 limited_send_params.max_bandwidth_bps = global_max;
2499 EXPECT_TRUE(channel_->SetSendParameters(limited_send_params));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07002500 webrtc::RtpParameters parameters =
2501 channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07002502 EXPECT_EQ(1UL, parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01002503 parameters.encodings[0].max_bitrate_bps = stream_max;
Zach Steinba37b4b2018-01-23 15:02:36 -08002504 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07002505 // Read back the parameteres and verify they have the correct value
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07002506 parameters = channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07002507 EXPECT_EQ(1UL, parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01002508 EXPECT_EQ(stream_max, parameters.encodings[0].max_bitrate_bps);
skvladdc1c62c2016-03-16 19:07:43 -07002509 // Verify that the new value propagated down to the encoder
perkjfa10b552016-10-02 23:45:26 -07002510 EXPECT_EQ(expected_encoder_bitrate, GetMaxEncoderBitrate());
skvladdc1c62c2016-03-16 19:07:43 -07002511 }
2512
Åsa Persson55659812018-06-18 17:51:32 +02002513 // Values from kSimulcastConfigs in simulcast.cc.
2514 const std::vector<webrtc::VideoStream> GetSimulcastBitrates720p() const {
2515 std::vector<webrtc::VideoStream> layers(3);
2516 layers[0].min_bitrate_bps = 30000;
2517 layers[0].target_bitrate_bps = 150000;
2518 layers[0].max_bitrate_bps = 200000;
2519 layers[1].min_bitrate_bps = 150000;
2520 layers[1].target_bitrate_bps = 500000;
2521 layers[1].max_bitrate_bps = 700000;
2522 layers[2].min_bitrate_bps = 600000;
2523 layers[2].target_bitrate_bps = 2500000;
2524 layers[2].max_bitrate_bps = 2500000;
2525 return layers;
2526 }
2527
Niels Möller805a27e2019-01-21 12:21:27 +01002528 cricket::FakeFrameSource frame_source_;
kwiberg686a8ef2016-02-26 03:00:35 -08002529 std::unique_ptr<FakeCall> fake_call_;
2530 std::unique_ptr<VideoMediaChannel> channel_;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002531 cricket::VideoSendParameters send_parameters_;
2532 cricket::VideoRecvParameters recv_parameters_;
Peter Boström0c4e06b2015-10-07 12:23:21 +02002533 uint32_t last_ssrc_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002534};
2535
eladalonf1841382017-06-12 01:16:46 -07002536TEST_F(WebRtcVideoChannelTest, SetsSyncGroupFromSyncLabel) {
Peter Boström0c4e06b2015-10-07 12:23:21 +02002537 const uint32_t kVideoSsrc = 123;
pbos8fc7fa72015-07-15 08:02:58 -07002538 const std::string kSyncLabel = "AvSyncLabel";
2539
2540 cricket::StreamParams sp = cricket::StreamParams::CreateLegacy(kVideoSsrc);
Seth Hampson845e8782018-03-02 11:34:10 -08002541 sp.set_stream_ids({kSyncLabel});
pbos8fc7fa72015-07-15 08:02:58 -07002542 EXPECT_TRUE(channel_->AddRecvStream(sp));
2543
Mirko Bonadeif859e552018-05-30 15:31:29 +02002544 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
pbos8fc7fa72015-07-15 08:02:58 -07002545 EXPECT_EQ(kSyncLabel,
2546 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group)
2547 << "SyncGroup should be set based on sync_label";
2548}
2549
eladalonf1841382017-06-12 01:16:46 -07002550TEST_F(WebRtcVideoChannelTest, RecvStreamWithSimAndRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002551 cricket::VideoSendParameters parameters;
2552 parameters.codecs = engine_.codecs();
2553 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002554 EXPECT_TRUE(channel_->SetSend(true));
nisse4b4dc862016-02-17 05:25:36 -08002555 parameters.conference_mode = true;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002556 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002557
2558 // Send side.
Peter Boström0c4e06b2015-10-07 12:23:21 +02002559 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
2560 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002561 FakeVideoSendStream* send_stream = AddSendStream(
2562 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
2563
2564 ASSERT_EQ(rtx_ssrcs.size(), send_stream->GetConfig().rtp.rtx.ssrcs.size());
2565 for (size_t i = 0; i < rtx_ssrcs.size(); ++i)
2566 EXPECT_EQ(rtx_ssrcs[i], send_stream->GetConfig().rtp.rtx.ssrcs[i]);
2567
2568 // Receiver side.
2569 FakeVideoReceiveStream* recv_stream = AddRecvStream(
2570 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
nisse26e3abb2017-08-25 04:44:25 -07002571 EXPECT_FALSE(
2572 recv_stream->GetConfig().rtp.rtx_associated_payload_types.empty());
nisseca5706d2017-09-11 02:32:16 -07002573 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
Peter Boströmd8b01092016-05-12 16:44:36 +02002574 << "RTX should be mapped for all decoders/payload types.";
nisseca5706d2017-09-11 02:32:16 -07002575 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02002576 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07002577 << "RTX should be mapped for the RED payload type";
2578
brandtr14742122017-01-27 04:53:07 -08002579 EXPECT_EQ(rtx_ssrcs[0], recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002580}
2581
eladalonf1841382017-06-12 01:16:46 -07002582TEST_F(WebRtcVideoChannelTest, RecvStreamWithRtx) {
pbos@webrtc.orge322a172014-06-13 11:47:28 +00002583 // Setup one channel with an associated RTX stream.
2584 cricket::StreamParams params =
2585 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
2586 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
2587 FakeVideoReceiveStream* recv_stream = AddRecvStream(params);
brandtr14742122017-01-27 04:53:07 -08002588 EXPECT_EQ(kRtxSsrcs1[0], recv_stream->GetConfig().rtp.rtx_ssrc);
nisseca5706d2017-09-11 02:32:16 -07002589
2590 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
2591 << "RTX should be mapped for all decoders/payload types.";
2592 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02002593 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07002594 << "RTX should be mapped for the RED payload type";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002595}
2596
eladalonf1841382017-06-12 01:16:46 -07002597TEST_F(WebRtcVideoChannelTest, RecvStreamNoRtx) {
pbos@webrtc.orge322a172014-06-13 11:47:28 +00002598 // Setup one channel without an associated RTX stream.
2599 cricket::StreamParams params =
2600 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
2601 FakeVideoReceiveStream* recv_stream = AddRecvStream(params);
brandtr14742122017-01-27 04:53:07 -08002602 ASSERT_EQ(0U, recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002603}
2604
Johannes Kron9190b822018-10-29 11:22:05 +01002605// Test propagation of extmap allow mixed setting.
2606TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedAsCaller) {
2607 TestExtmapAllowMixedCaller(/*extmap_allow_mixed=*/true);
2608}
2609TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedDisabledAsCaller) {
2610 TestExtmapAllowMixedCaller(/*extmap_allow_mixed=*/false);
2611}
2612TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedAsCallee) {
2613 TestExtmapAllowMixedCallee(/*extmap_allow_mixed=*/true);
2614}
2615TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedDisabledAsCallee) {
2616 TestExtmapAllowMixedCallee(/*extmap_allow_mixed=*/false);
2617}
2618
eladalonf1841382017-06-12 01:16:46 -07002619TEST_F(WebRtcVideoChannelTest, NoHeaderExtesionsByDefault) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002620 FakeVideoSendStream* send_stream =
2621 AddSendStream(cricket::StreamParams::CreateLegacy(kSsrcs1[0]));
2622 ASSERT_TRUE(send_stream->GetConfig().rtp.extensions.empty());
2623
2624 FakeVideoReceiveStream* recv_stream =
2625 AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrcs1[0]));
2626 ASSERT_TRUE(recv_stream->GetConfig().rtp.extensions.empty());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002627}
2628
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002629// Test support for RTP timestamp offset header extension.
eladalonf1841382017-06-12 01:16:46 -07002630TEST_F(WebRtcVideoChannelTest, SendRtpTimestampOffsetHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002631 TestSetSendRtpHeaderExtensions(RtpExtension::kTimestampOffsetUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002632}
isheriff6f8d6862016-05-26 11:24:55 -07002633
eladalonf1841382017-06-12 01:16:46 -07002634TEST_F(WebRtcVideoChannelTest, RecvRtpTimestampOffsetHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002635 TestSetRecvRtpHeaderExtensions(RtpExtension::kTimestampOffsetUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002636}
2637
2638// Test support for absolute send time header extension.
eladalonf1841382017-06-12 01:16:46 -07002639TEST_F(WebRtcVideoChannelTest, SendAbsoluteSendTimeHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002640 TestSetSendRtpHeaderExtensions(RtpExtension::kAbsSendTimeUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002641}
isheriff6f8d6862016-05-26 11:24:55 -07002642
eladalonf1841382017-06-12 01:16:46 -07002643TEST_F(WebRtcVideoChannelTest, RecvAbsoluteSendTimeHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002644 TestSetRecvRtpHeaderExtensions(RtpExtension::kAbsSendTimeUri);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002645}
2646
eladalonf1841382017-06-12 01:16:46 -07002647TEST_F(WebRtcVideoChannelTest, FiltersExtensionsPicksTransportSeqNum) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002648 // Enable three redundant extensions.
2649 std::vector<std::string> extensions;
isheriff6f8d6862016-05-26 11:24:55 -07002650 extensions.push_back(RtpExtension::kAbsSendTimeUri);
2651 extensions.push_back(RtpExtension::kTimestampOffsetUri);
2652 extensions.push_back(RtpExtension::kTransportSequenceNumberUri);
2653 TestExtensionFilter(extensions, RtpExtension::kTransportSequenceNumberUri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002654}
2655
eladalonf1841382017-06-12 01:16:46 -07002656TEST_F(WebRtcVideoChannelTest, FiltersExtensionsPicksAbsSendTime) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002657 // Enable two redundant extensions.
2658 std::vector<std::string> extensions;
isheriff6f8d6862016-05-26 11:24:55 -07002659 extensions.push_back(RtpExtension::kAbsSendTimeUri);
2660 extensions.push_back(RtpExtension::kTimestampOffsetUri);
2661 TestExtensionFilter(extensions, RtpExtension::kAbsSendTimeUri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002662}
2663
stefanc1aeaf02015-10-15 07:26:07 -07002664// Test support for transport sequence number header extension.
eladalonf1841382017-06-12 01:16:46 -07002665TEST_F(WebRtcVideoChannelTest, SendTransportSequenceNumberHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002666 TestSetSendRtpHeaderExtensions(RtpExtension::kTransportSequenceNumberUri);
stefanc1aeaf02015-10-15 07:26:07 -07002667}
eladalonf1841382017-06-12 01:16:46 -07002668TEST_F(WebRtcVideoChannelTest, RecvTransportSequenceNumberHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002669 TestSetRecvRtpHeaderExtensions(RtpExtension::kTransportSequenceNumberUri);
stefanc1aeaf02015-10-15 07:26:07 -07002670}
2671
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002672// Test support for video rotation header extension.
eladalonf1841382017-06-12 01:16:46 -07002673TEST_F(WebRtcVideoChannelTest, SendVideoRotationHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002674 TestSetSendRtpHeaderExtensions(RtpExtension::kVideoRotationUri);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002675}
eladalonf1841382017-06-12 01:16:46 -07002676TEST_F(WebRtcVideoChannelTest, RecvVideoRotationHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002677 TestSetRecvRtpHeaderExtensions(RtpExtension::kVideoRotationUri);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002678}
2679
eladalonf1841382017-06-12 01:16:46 -07002680TEST_F(WebRtcVideoChannelTest, IdenticalSendExtensionsDoesntRecreateStream) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002681 const int kAbsSendTimeId = 1;
2682 const int kVideoRotationId = 2;
isheriff6f8d6862016-05-26 11:24:55 -07002683 send_parameters_.extensions.push_back(
2684 RtpExtension(RtpExtension::kAbsSendTimeUri, kAbsSendTimeId));
2685 send_parameters_.extensions.push_back(
2686 RtpExtension(RtpExtension::kVideoRotationUri, kVideoRotationId));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002687
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002688 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002689 FakeVideoSendStream* send_stream =
2690 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2691
2692 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002693 ASSERT_EQ(2u, send_stream->GetConfig().rtp.extensions.size());
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002694
2695 // Setting the same extensions (even if in different order) shouldn't
2696 // reallocate the stream.
Steve Anton2c9ebef2019-01-28 17:27:58 -08002697 absl::c_reverse(send_parameters_.extensions);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002698 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002699
2700 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
2701
2702 // Setting different extensions should recreate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002703 send_parameters_.extensions.resize(1);
2704 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002705
2706 EXPECT_EQ(2, fake_call_->GetNumCreatedSendStreams());
2707}
2708
eladalonf1841382017-06-12 01:16:46 -07002709TEST_F(WebRtcVideoChannelTest, IdenticalRecvExtensionsDoesntRecreateStream) {
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002710 const int kTOffsetId = 1;
2711 const int kAbsSendTimeId = 2;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002712 const int kVideoRotationId = 3;
isheriff6f8d6862016-05-26 11:24:55 -07002713 recv_parameters_.extensions.push_back(
2714 RtpExtension(RtpExtension::kAbsSendTimeUri, kAbsSendTimeId));
2715 recv_parameters_.extensions.push_back(
2716 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
2717 recv_parameters_.extensions.push_back(
2718 RtpExtension(RtpExtension::kVideoRotationUri, kVideoRotationId));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002719
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002720 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
Peter Boström54be3e02015-05-25 15:04:24 +02002721 FakeVideoReceiveStream* recv_stream =
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002722 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2723
2724 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
Peter Boström54be3e02015-05-25 15:04:24 +02002725 ASSERT_EQ(3u, recv_stream->GetConfig().rtp.extensions.size());
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002726
2727 // Setting the same extensions (even if in different order) shouldn't
2728 // reallocate the stream.
Steve Anton2c9ebef2019-01-28 17:27:58 -08002729 absl::c_reverse(recv_parameters_.extensions);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002730 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002731
2732 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
2733
2734 // Setting different extensions should recreate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002735 recv_parameters_.extensions.resize(1);
2736 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002737
2738 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams());
2739}
2740
eladalonf1841382017-06-12 01:16:46 -07002741TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002742 SetSendRtpHeaderExtensionsExcludeUnsupportedExtensions) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002743 const int kUnsupportedId = 1;
2744 const int kTOffsetId = 2;
2745
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002746 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002747 RtpExtension(kUnsupportedExtensionName, kUnsupportedId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002748 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002749 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002750 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002751 FakeVideoSendStream* send_stream =
2752 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2753
2754 // Only timestamp offset extension is set to send stream,
2755 // unsupported rtp extension is ignored.
2756 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
isheriff6f8d6862016-05-26 11:24:55 -07002757 EXPECT_STREQ(RtpExtension::kTimestampOffsetUri,
2758 send_stream->GetConfig().rtp.extensions[0].uri.c_str());
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002759}
2760
eladalonf1841382017-06-12 01:16:46 -07002761TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002762 SetRecvRtpHeaderExtensionsExcludeUnsupportedExtensions) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002763 const int kUnsupportedId = 1;
2764 const int kTOffsetId = 2;
2765
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002766 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002767 RtpExtension(kUnsupportedExtensionName, kUnsupportedId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002768 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002769 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002770 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002771 FakeVideoReceiveStream* recv_stream =
2772 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2773
2774 // Only timestamp offset extension is set to receive stream,
2775 // unsupported rtp extension is ignored.
2776 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
isheriff6f8d6862016-05-26 11:24:55 -07002777 EXPECT_STREQ(RtpExtension::kTimestampOffsetUri,
2778 recv_stream->GetConfig().rtp.extensions[0].uri.c_str());
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002779}
2780
eladalonf1841382017-06-12 01:16:46 -07002781TEST_F(WebRtcVideoChannelTest, SetSendRtpHeaderExtensionsRejectsIncorrectIds) {
Peter Boström23914fe2015-03-31 15:08:04 +02002782 const int kIncorrectIds[] = {-2, -1, 0, 15, 16};
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00002783 for (size_t i = 0; i < arraysize(kIncorrectIds); ++i) {
isheriff6f8d6862016-05-26 11:24:55 -07002784 send_parameters_.extensions.push_back(
2785 RtpExtension(RtpExtension::kTimestampOffsetUri, kIncorrectIds[i]));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002786 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_))
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002787 << "Bad extension id '" << kIncorrectIds[i] << "' accepted.";
2788 }
2789}
2790
eladalonf1841382017-06-12 01:16:46 -07002791TEST_F(WebRtcVideoChannelTest, SetRecvRtpHeaderExtensionsRejectsIncorrectIds) {
Peter Boström23914fe2015-03-31 15:08:04 +02002792 const int kIncorrectIds[] = {-2, -1, 0, 15, 16};
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00002793 for (size_t i = 0; i < arraysize(kIncorrectIds); ++i) {
isheriff6f8d6862016-05-26 11:24:55 -07002794 recv_parameters_.extensions.push_back(
2795 RtpExtension(RtpExtension::kTimestampOffsetUri, kIncorrectIds[i]));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002796 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_))
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002797 << "Bad extension id '" << kIncorrectIds[i] << "' accepted.";
2798 }
2799}
2800
eladalonf1841382017-06-12 01:16:46 -07002801TEST_F(WebRtcVideoChannelTest, SetSendRtpHeaderExtensionsRejectsDuplicateIds) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002802 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002803 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002804 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002805 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002806 RtpExtension(RtpExtension::kAbsSendTimeUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002807 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002808
2809 // Duplicate entries are also not supported.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002810 send_parameters_.extensions.clear();
2811 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002812 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002813 send_parameters_.extensions.push_back(send_parameters_.extensions.back());
2814 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002815}
2816
eladalonf1841382017-06-12 01:16:46 -07002817TEST_F(WebRtcVideoChannelTest, SetRecvRtpHeaderExtensionsRejectsDuplicateIds) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002818 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002819 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002820 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002821 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002822 RtpExtension(RtpExtension::kAbsSendTimeUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002823 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002824
2825 // Duplicate entries are also not supported.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002826 recv_parameters_.extensions.clear();
2827 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002828 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002829 recv_parameters_.extensions.push_back(recv_parameters_.extensions.back());
2830 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002831}
2832
eladalonf1841382017-06-12 01:16:46 -07002833TEST_F(WebRtcVideoChannelTest, AddRecvStreamOnlyUsesOneReceiveStream) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002834 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002835 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002836}
2837
eladalonf1841382017-06-12 01:16:46 -07002838TEST_F(WebRtcVideoChannelTest, RtcpIsCompoundByDefault) {
Peter Boströmd7da1202015-06-05 14:09:38 +02002839 FakeVideoReceiveStream* stream = AddRecvStream();
pbosda903ea2015-10-02 02:36:56 -07002840 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream->GetConfig().rtp.rtcp_mode);
Peter Boströmd7da1202015-06-05 14:09:38 +02002841}
2842
eladalonf1841382017-06-12 01:16:46 -07002843TEST_F(WebRtcVideoChannelTest, TransportCcIsEnabledByDefault) {
stefan43edf0f2015-11-20 18:05:48 -08002844 FakeVideoReceiveStream* stream = AddRecvStream();
2845 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2846}
2847
eladalonf1841382017-06-12 01:16:46 -07002848TEST_F(WebRtcVideoChannelTest, TransportCcCanBeEnabledAndDisabled) {
stefan43edf0f2015-11-20 18:05:48 -08002849 FakeVideoReceiveStream* stream = AddRecvStream();
2850 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2851
2852 // Verify that transport cc feedback is turned off when send(!) codecs without
2853 // transport cc feedback are set.
2854 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002855 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
stefan43edf0f2015-11-20 18:05:48 -08002856 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2857 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2858 stream = fake_call_->GetVideoReceiveStreams()[0];
2859 EXPECT_FALSE(stream->GetConfig().rtp.transport_cc);
2860
2861 // Verify that transport cc feedback is turned on when setting default codecs
2862 // since the default codecs have transport cc feedback enabled.
2863 parameters.codecs = engine_.codecs();
2864 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2865 stream = fake_call_->GetVideoReceiveStreams()[0];
2866 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2867}
2868
Elad Alonfadb1812019-05-24 13:40:02 +02002869TEST_F(WebRtcVideoChannelTest, LossNotificationIsDisabledByDefault) {
2870 TestLossNotificationState(false);
2871}
2872
2873TEST_F(WebRtcVideoChannelTest, LossNotificationIsEnabledByFieldTrial) {
2874 RTC_DCHECK(!override_field_trials_);
Mirko Bonadei317a1f02019-09-17 17:06:18 +02002875 override_field_trials_ = std::make_unique<webrtc::test::ScopedFieldTrials>(
Elad Alonfadb1812019-05-24 13:40:02 +02002876 "WebRTC-RtcpLossNotification/Enabled/");
2877 SetUp();
2878 TestLossNotificationState(true);
2879}
2880
2881TEST_F(WebRtcVideoChannelTest, LossNotificationCanBeEnabledAndDisabled) {
2882 RTC_DCHECK(!override_field_trials_);
Mirko Bonadei317a1f02019-09-17 17:06:18 +02002883 override_field_trials_ = std::make_unique<webrtc::test::ScopedFieldTrials>(
Elad Alonfadb1812019-05-24 13:40:02 +02002884 "WebRTC-RtcpLossNotification/Enabled/");
2885 SetUp();
2886
2887 AssignDefaultCodec();
2888 VerifyCodecHasDefaultFeedbackParams(default_codec_, true);
2889
2890 {
2891 cricket::VideoSendParameters parameters;
2892 parameters.codecs = engine_.codecs();
2893 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2894 EXPECT_TRUE(channel_->SetSend(true));
2895 }
2896
2897 // Start with LNTF enabled.
2898 FakeVideoSendStream* send_stream =
2899 AddSendStream(cricket::StreamParams::CreateLegacy(1));
2900 ASSERT_TRUE(send_stream->GetConfig().rtp.lntf.enabled);
2901 FakeVideoReceiveStream* recv_stream =
2902 AddRecvStream(cricket::StreamParams::CreateLegacy(1));
2903 ASSERT_TRUE(recv_stream->GetConfig().rtp.lntf.enabled);
2904
2905 // Verify that LNTF is turned off when send(!) codecs without LNTF are set.
2906 cricket::VideoSendParameters parameters;
2907 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
2908 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2909 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2910 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2911 EXPECT_FALSE(recv_stream->GetConfig().rtp.lntf.enabled);
2912 send_stream = fake_call_->GetVideoSendStreams()[0];
2913 EXPECT_FALSE(send_stream->GetConfig().rtp.lntf.enabled);
2914
2915 // Setting the default codecs again, including VP8, turns LNTF back on.
2916 parameters.codecs = engine_.codecs();
2917 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2918 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2919 EXPECT_TRUE(recv_stream->GetConfig().rtp.lntf.enabled);
2920 send_stream = fake_call_->GetVideoSendStreams()[0];
2921 EXPECT_TRUE(send_stream->GetConfig().rtp.lntf.enabled);
2922}
2923
eladalonf1841382017-06-12 01:16:46 -07002924TEST_F(WebRtcVideoChannelTest, NackIsEnabledByDefault) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02002925 AssignDefaultCodec();
Elad Alonfadb1812019-05-24 13:40:02 +02002926 VerifyCodecHasDefaultFeedbackParams(default_codec_, false);
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002927
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002928 cricket::VideoSendParameters parameters;
2929 parameters.codecs = engine_.codecs();
2930 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org19864742014-05-30 07:35:47 +00002931 EXPECT_TRUE(channel_->SetSend(true));
2932
2933 // Send side.
2934 FakeVideoSendStream* send_stream =
2935 AddSendStream(cricket::StreamParams::CreateLegacy(1));
2936 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2937
2938 // Receiver side.
2939 FakeVideoReceiveStream* recv_stream =
2940 AddRecvStream(cricket::StreamParams::CreateLegacy(1));
2941 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2942
2943 // Nack history size should match between sender and receiver.
2944 EXPECT_EQ(send_stream->GetConfig().rtp.nack.rtp_history_ms,
2945 recv_stream->GetConfig().rtp.nack.rtp_history_ms);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002946}
2947
eladalonf1841382017-06-12 01:16:46 -07002948TEST_F(WebRtcVideoChannelTest, NackCanBeEnabledAndDisabled) {
Peter Boström67c9df72015-05-11 14:34:58 +02002949 FakeVideoSendStream* send_stream = AddSendStream();
Peter Boström3548dd22015-05-22 18:48:36 +02002950 FakeVideoReceiveStream* recv_stream = AddRecvStream();
Peter Boström67c9df72015-05-11 14:34:58 +02002951
2952 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2953 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2954
2955 // Verify that NACK is turned off when send(!) codecs without NACK are set.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002956 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002957 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002958 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2959 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström67c9df72015-05-11 14:34:58 +02002960 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2961 EXPECT_EQ(0, recv_stream->GetConfig().rtp.nack.rtp_history_ms);
2962 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002963 EXPECT_EQ(0, send_stream->GetConfig().rtp.nack.rtp_history_ms);
2964
Peter Boström67c9df72015-05-11 14:34:58 +02002965 // Verify that NACK is turned on when setting default codecs since the
2966 // default codecs have NACK enabled.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002967 parameters.codecs = engine_.codecs();
2968 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström67c9df72015-05-11 14:34:58 +02002969 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2970 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2971 send_stream = fake_call_->GetVideoSendStreams()[0];
2972 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002973}
2974
Peter Boströme7ba0862016-03-12 00:02:28 +01002975// This test verifies that new frame sizes reconfigures encoders even though not
2976// (yet) sending. The purpose of this is to permit encoding as quickly as
2977// possible once we start sending. Likely the frames being input are from the
2978// same source that will be sent later, which just means that we're ready
2979// earlier.
eladalonf1841382017-06-12 01:16:46 -07002980TEST_F(WebRtcVideoChannelTest, ReconfiguresEncodersWhenNotSending) {
Peter Boströme7ba0862016-03-12 00:02:28 +01002981 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002982 parameters.codecs.push_back(GetEngineCodec("VP8"));
Peter Boströme7ba0862016-03-12 00:02:28 +01002983 ASSERT_TRUE(channel_->SetSendParameters(parameters));
2984 channel_->SetSend(false);
2985
2986 FakeVideoSendStream* stream = AddSendStream();
2987
perkjfa10b552016-10-02 23:45:26 -07002988 // No frames entered.
Peter Boströme7ba0862016-03-12 00:02:28 +01002989 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002990 EXPECT_EQ(0u, streams[0].width);
2991 EXPECT_EQ(0u, streams[0].height);
Peter Boströme7ba0862016-03-12 00:02:28 +01002992
Niels Möller805a27e2019-01-21 12:21:27 +01002993 webrtc::test::FrameForwarder frame_forwarder;
2994 cricket::FakeFrameSource frame_source(1280, 720,
2995 rtc::kNumMicrosecsPerSec / 30);
2996
2997 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
2998 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Peter Boströme7ba0862016-03-12 00:02:28 +01002999
3000 // Frame entered, should be reconfigured to new dimensions.
3001 streams = stream->GetVideoStreams();
Niels Möller805a27e2019-01-21 12:21:27 +01003002 EXPECT_EQ(rtc::checked_cast<size_t>(1280), streams[0].width);
3003 EXPECT_EQ(rtc::checked_cast<size_t>(720), streams[0].height);
Peter Boströme7ba0862016-03-12 00:02:28 +01003004
Niels Möllerff40b142018-04-09 08:49:14 +02003005 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boströme7ba0862016-03-12 00:02:28 +01003006}
3007
eladalonf1841382017-06-12 01:16:46 -07003008TEST_F(WebRtcVideoChannelTest, UsesCorrectSettingsForScreencast) {
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00003009 static const int kScreenshareMinBitrateKbps = 800;
magjed509e4fe2016-11-18 01:34:11 -08003010 cricket::VideoCodec codec = GetEngineCodec("VP8");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003011 cricket::VideoSendParameters parameters;
3012 parameters.codecs.push_back(codec);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003013 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00003014 AddSendStream();
3015
Niels Möller805a27e2019-01-21 12:21:27 +01003016 webrtc::test::FrameForwarder frame_forwarder;
3017 cricket::FakeFrameSource frame_source(1280, 720,
3018 rtc::kNumMicrosecsPerSec / 30);
nisse05103312016-03-16 02:22:50 -07003019 VideoOptions min_bitrate_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003020 min_bitrate_options.screencast_min_bitrate_kbps = kScreenshareMinBitrateKbps;
Niels Möller805a27e2019-01-21 12:21:27 +01003021 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &min_bitrate_options,
3022 &frame_forwarder));
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00003023
3024 EXPECT_TRUE(channel_->SetSend(true));
3025
Niels Möller805a27e2019-01-21 12:21:27 +01003026 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00003027 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3028 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
3029
3030 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
3031
3032 // Verify non-screencast settings.
perkj26091b12016-09-01 01:17:40 -07003033 webrtc::VideoEncoderConfig encoder_config =
3034 send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02003035 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kRealtimeVideo,
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00003036 encoder_config.content_type);
perkjfa10b552016-10-02 23:45:26 -07003037 std::vector<webrtc::VideoStream> streams = send_stream->GetVideoStreams();
Niels Möller805a27e2019-01-21 12:21:27 +01003038 EXPECT_EQ(rtc::checked_cast<size_t>(1280), streams.front().width);
3039 EXPECT_EQ(rtc::checked_cast<size_t>(720), streams.front().height);
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00003040 EXPECT_EQ(0, encoder_config.min_transmit_bitrate_bps)
3041 << "Non-screenshare shouldn't use min-transmit bitrate.";
3042
Niels Möllerff40b142018-04-09 08:49:14 +02003043 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
perkjd533aec2017-01-13 05:57:25 -08003044 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
nisse05103312016-03-16 02:22:50 -07003045 VideoOptions screencast_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003046 screencast_options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01003047 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &screencast_options,
3048 &frame_forwarder));
3049 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
sprangf24a0642017-02-28 13:23:26 -08003050 // Send stream recreated after option change.
3051 ASSERT_EQ(2, fake_call_->GetNumCreatedSendStreams());
3052 send_stream = fake_call_->GetVideoSendStreams().front();
3053 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00003054
3055 // Verify screencast settings.
perkj26091b12016-09-01 01:17:40 -07003056 encoder_config = send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02003057 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kScreen,
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00003058 encoder_config.content_type);
3059 EXPECT_EQ(kScreenshareMinBitrateKbps * 1000,
3060 encoder_config.min_transmit_bitrate_bps);
3061
perkjfa10b552016-10-02 23:45:26 -07003062 streams = send_stream->GetVideoStreams();
Niels Möller805a27e2019-01-21 12:21:27 +01003063 EXPECT_EQ(rtc::checked_cast<size_t>(1280), streams.front().width);
3064 EXPECT_EQ(rtc::checked_cast<size_t>(720), streams.front().height);
Sergey Silkina796a7e2018-03-01 15:11:29 +01003065 EXPECT_FALSE(streams[0].num_temporal_layers.has_value());
Niels Möllerff40b142018-04-09 08:49:14 +02003066 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00003067}
3068
eladalonf1841382017-06-12 01:16:46 -07003069TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00003070 ConferenceModeScreencastConfiguresTemporalLayer) {
Rasmus Brandt195d1d72018-05-09 11:28:01 +02003071 static const int kConferenceScreencastTemporalBitrateBps = 200 * 1000;
nisse4b4dc862016-02-17 05:25:36 -08003072 send_parameters_.conference_mode = true;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003073 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00003074
3075 AddSendStream();
nisse05103312016-03-16 02:22:50 -07003076 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003077 options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01003078 webrtc::test::FrameForwarder frame_forwarder;
3079 cricket::FakeFrameSource frame_source(1280, 720,
3080 rtc::kNumMicrosecsPerSec / 30);
3081 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00003082 EXPECT_TRUE(channel_->SetSend(true));
3083
Niels Möller805a27e2019-01-21 12:21:27 +01003084 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00003085 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3086 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
3087
perkj26091b12016-09-01 01:17:40 -07003088 webrtc::VideoEncoderConfig encoder_config =
3089 send_stream->GetEncoderConfig().Copy();
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00003090
3091 // Verify screencast settings.
perkj26091b12016-09-01 01:17:40 -07003092 encoder_config = send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02003093 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kScreen,
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00003094 encoder_config.content_type);
perkjfa10b552016-10-02 23:45:26 -07003095
3096 std::vector<webrtc::VideoStream> streams = send_stream->GetVideoStreams();
3097 ASSERT_EQ(1u, streams.size());
Sergey Silkina796a7e2018-03-01 15:11:29 +01003098 ASSERT_EQ(2u, streams[0].num_temporal_layers);
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00003099 EXPECT_EQ(kConferenceScreencastTemporalBitrateBps,
Sergey Silkina796a7e2018-03-01 15:11:29 +01003100 streams[0].target_bitrate_bps);
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00003101
Niels Möllerff40b142018-04-09 08:49:14 +02003102 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003103}
3104
eladalonf1841382017-06-12 01:16:46 -07003105TEST_F(WebRtcVideoChannelTest, SuspendBelowMinBitrateDisabledByDefault) {
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00003106 FakeVideoSendStream* stream = AddSendStream();
3107 EXPECT_FALSE(stream->GetConfig().suspend_below_min_bitrate);
3108}
3109
eladalonf1841382017-06-12 01:16:46 -07003110TEST_F(WebRtcVideoChannelTest, SetMediaConfigSuspendBelowMinBitrate) {
kthelgason2bc68642017-02-07 07:02:22 -08003111 MediaConfig media_config = GetMediaConfig();
nisse0db023a2016-03-01 04:29:59 -08003112 media_config.video.suspend_below_min_bitrate = true;
3113
Sebastian Jansson84848f22018-11-16 10:40:36 +01003114 channel_.reset(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02003115 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions(),
3116 video_bitrate_allocator_factory_.get()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003117 channel_->OnReadyToSend(true);
nisse0db023a2016-03-01 04:29:59 -08003118
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003119 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00003120
3121 FakeVideoSendStream* stream = AddSendStream();
3122 EXPECT_TRUE(stream->GetConfig().suspend_below_min_bitrate);
3123
nisse0db023a2016-03-01 04:29:59 -08003124 media_config.video.suspend_below_min_bitrate = false;
Sebastian Jansson84848f22018-11-16 10:40:36 +01003125 channel_.reset(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02003126 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions(),
3127 video_bitrate_allocator_factory_.get()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003128 channel_->OnReadyToSend(true);
nisse0db023a2016-03-01 04:29:59 -08003129
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003130 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00003131
nisse0db023a2016-03-01 04:29:59 -08003132 stream = AddSendStream();
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00003133 EXPECT_FALSE(stream->GetConfig().suspend_below_min_bitrate);
3134}
3135
eladalonf1841382017-06-12 01:16:46 -07003136TEST_F(WebRtcVideoChannelTest, Vp8DenoisingEnabledByDefault) {
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00003137 FakeVideoSendStream* stream = AddSendStream();
3138 webrtc::VideoCodecVP8 vp8_settings;
3139 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3140 EXPECT_TRUE(vp8_settings.denoisingOn);
3141}
3142
eladalonf1841382017-06-12 01:16:46 -07003143TEST_F(WebRtcVideoChannelTest, VerifyVp8SpecificSettings) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003144 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003145 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003146 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00003147
Peter Boström2feafdb2015-09-09 14:32:14 +02003148 // Single-stream settings should apply with RTX as well (verifies that we
3149 // check number of regular SSRCs and not StreamParams::ssrcs which contains
3150 // both RTX and regular SSRCs).
3151 FakeVideoSendStream* stream = SetUpSimulcast(false, true);
Erik Språng143cec12015-04-28 10:01:41 +02003152
Niels Möller805a27e2019-01-21 12:21:27 +01003153 webrtc::test::FrameForwarder frame_forwarder;
3154 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Erik Språng143cec12015-04-28 10:01:41 +02003155 channel_->SetSend(true);
3156
Niels Möller805a27e2019-01-21 12:21:27 +01003157 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Erik Språng143cec12015-04-28 10:01:41 +02003158
pbos4cba4eb2015-10-26 11:18:18 -07003159 webrtc::VideoCodecVP8 vp8_settings;
3160 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3161 EXPECT_TRUE(vp8_settings.denoisingOn)
3162 << "VP8 denoising should be on by default.";
3163
Niels Möller805a27e2019-01-21 12:21:27 +01003164 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02003165
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00003166 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3167 EXPECT_FALSE(vp8_settings.denoisingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003168 EXPECT_TRUE(vp8_settings.automaticResizeOn);
3169 EXPECT_TRUE(vp8_settings.frameDroppingOn);
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00003170
Niels Möller805a27e2019-01-21 12:21:27 +01003171 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, true);
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00003172
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00003173 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3174 EXPECT_TRUE(vp8_settings.denoisingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003175 EXPECT_TRUE(vp8_settings.automaticResizeOn);
3176 EXPECT_TRUE(vp8_settings.frameDroppingOn);
3177
Niels Möllerff40b142018-04-09 08:49:14 +02003178 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boström2feafdb2015-09-09 14:32:14 +02003179 stream = SetUpSimulcast(true, false);
Niels Möller805a27e2019-01-21 12:21:27 +01003180 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Erik Språng143cec12015-04-28 10:01:41 +02003181 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01003182 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Erik Språng143cec12015-04-28 10:01:41 +02003183
Mirko Bonadeif859e552018-05-30 15:31:29 +02003184 EXPECT_EQ(3u, stream->GetVideoStreams().size());
Erik Språng143cec12015-04-28 10:01:41 +02003185 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3186 // Autmatic resize off when using simulcast.
3187 EXPECT_FALSE(vp8_settings.automaticResizeOn);
3188 EXPECT_TRUE(vp8_settings.frameDroppingOn);
3189
Florent Castelli66b38602019-07-10 16:57:57 +02003190 // In screen-share mode, denoising is forced off.
nisse05103312016-03-16 02:22:50 -07003191 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003192 options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01003193 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Niels Möller60653ba2016-03-02 11:41:36 +01003194
Niels Möller805a27e2019-01-21 12:21:27 +01003195 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02003196
Florent Castelli66b38602019-07-10 16:57:57 +02003197 EXPECT_EQ(3u, stream->GetVideoStreams().size());
Erik Språng143cec12015-04-28 10:01:41 +02003198 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3199 EXPECT_FALSE(vp8_settings.denoisingOn);
3200 // Resizing and frame dropping always off for screen sharing.
3201 EXPECT_FALSE(vp8_settings.automaticResizeOn);
3202 EXPECT_FALSE(vp8_settings.frameDroppingOn);
3203
Niels Möller805a27e2019-01-21 12:21:27 +01003204 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, true);
Erik Språng143cec12015-04-28 10:01:41 +02003205
3206 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3207 EXPECT_FALSE(vp8_settings.denoisingOn);
3208 EXPECT_FALSE(vp8_settings.automaticResizeOn);
3209 EXPECT_FALSE(vp8_settings.frameDroppingOn);
3210
Niels Möllerff40b142018-04-09 08:49:14 +02003211 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Erik Språng143cec12015-04-28 10:01:41 +02003212}
3213
deadbeef119760a2016-04-04 11:43:27 -07003214// Test that setting the same options doesn't result in the encoder being
3215// reconfigured.
eladalonf1841382017-06-12 01:16:46 -07003216TEST_F(WebRtcVideoChannelTest, SetIdenticalOptionsDoesntReconfigureEncoder) {
deadbeef119760a2016-04-04 11:43:27 -07003217 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01003218 webrtc::test::FrameForwarder frame_forwarder;
deadbeef119760a2016-04-04 11:43:27 -07003219
perkjfa10b552016-10-02 23:45:26 -07003220 AddSendStream();
perkjfa10b552016-10-02 23:45:26 -07003221 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003222 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkjfa10b552016-10-02 23:45:26 -07003223 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3224 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
3225
Niels Möller805a27e2019-01-21 12:21:27 +01003226 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
3227 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
3228 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
perkjfa10b552016-10-02 23:45:26 -07003229 // Expect 1 reconfigurations at this point from the initial configuration.
3230 EXPECT_EQ(1, send_stream->num_encoder_reconfigurations());
deadbeef119760a2016-04-04 11:43:27 -07003231
3232 // Set the options one more time and expect no additional reconfigurations.
Niels Möller805a27e2019-01-21 12:21:27 +01003233 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
perkjfa10b552016-10-02 23:45:26 -07003234 EXPECT_EQ(1, send_stream->num_encoder_reconfigurations());
3235
3236 // Change |options| and expect 2 reconfigurations.
Oskar Sundbom78807582017-11-16 11:09:55 +01003237 options.video_noise_reduction = true;
Niels Möller805a27e2019-01-21 12:21:27 +01003238 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
deadbeef119760a2016-04-04 11:43:27 -07003239 EXPECT_EQ(2, send_stream->num_encoder_reconfigurations());
3240
Niels Möllerff40b142018-04-09 08:49:14 +02003241 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
deadbeef119760a2016-04-04 11:43:27 -07003242}
3243
eladalonf1841382017-06-12 01:16:46 -07003244class Vp9SettingsTest : public WebRtcVideoChannelTest {
Erik Språng143cec12015-04-28 10:01:41 +02003245 public:
asaperssonc5dabdd2016-03-21 04:15:50 -07003246 Vp9SettingsTest() : Vp9SettingsTest("") {}
3247 explicit Vp9SettingsTest(const char* field_trials)
eladalonf1841382017-06-12 01:16:46 -07003248 : WebRtcVideoChannelTest(field_trials) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +02003249 encoder_factory_->AddSupportedVideoCodecType("VP9");
Erik Språng143cec12015-04-28 10:01:41 +02003250 }
3251 virtual ~Vp9SettingsTest() {}
3252
3253 protected:
Erik Språng143cec12015-04-28 10:01:41 +02003254 void TearDown() override {
3255 // Remove references to encoder_factory_ since this will be destroyed
3256 // before channel_ and engine_.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003257 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
Erik Språng143cec12015-04-28 10:01:41 +02003258 }
Erik Språng143cec12015-04-28 10:01:41 +02003259};
3260
3261TEST_F(Vp9SettingsTest, VerifyVp9SpecificSettings) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003262 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003263 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003264 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Erik Språng143cec12015-04-28 10:01:41 +02003265
Peter Boström2feafdb2015-09-09 14:32:14 +02003266 FakeVideoSendStream* stream = SetUpSimulcast(false, false);
Erik Språng143cec12015-04-28 10:01:41 +02003267
Niels Möller805a27e2019-01-21 12:21:27 +01003268 webrtc::test::FrameForwarder frame_forwarder;
3269 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Erik Språng143cec12015-04-28 10:01:41 +02003270 channel_->SetSend(true);
3271
Niels Möller805a27e2019-01-21 12:21:27 +01003272 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Erik Språng143cec12015-04-28 10:01:41 +02003273
pbos4cba4eb2015-10-26 11:18:18 -07003274 webrtc::VideoCodecVP9 vp9_settings;
3275 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
jianja5e8aa62017-03-27 10:09:00 -07003276 EXPECT_TRUE(vp9_settings.denoisingOn)
3277 << "VP9 denoising should be on by default.";
pbos4cba4eb2015-10-26 11:18:18 -07003278
Niels Möller805a27e2019-01-21 12:21:27 +01003279 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02003280
Erik Språng143cec12015-04-28 10:01:41 +02003281 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3282 EXPECT_FALSE(vp9_settings.denoisingOn);
3283 // Frame dropping always on for real time video.
3284 EXPECT_TRUE(vp9_settings.frameDroppingOn);
3285
Niels Möller805a27e2019-01-21 12:21:27 +01003286 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, true);
Erik Språng143cec12015-04-28 10:01:41 +02003287
3288 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3289 EXPECT_TRUE(vp9_settings.denoisingOn);
3290 EXPECT_TRUE(vp9_settings.frameDroppingOn);
3291
3292 // In screen-share mode, denoising is forced off.
nisse05103312016-03-16 02:22:50 -07003293 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003294 options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01003295 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
perkj2d5f0912016-02-29 00:04:41 -08003296
Niels Möller805a27e2019-01-21 12:21:27 +01003297 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02003298
3299 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3300 EXPECT_FALSE(vp9_settings.denoisingOn);
Sergey Silkinbe71a1e2018-05-17 16:46:43 +02003301 // Frame dropping always on for screen sharing.
3302 EXPECT_TRUE(vp9_settings.frameDroppingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003303
Niels Möller805a27e2019-01-21 12:21:27 +01003304 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02003305
3306 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3307 EXPECT_FALSE(vp9_settings.denoisingOn);
Sergey Silkinbe71a1e2018-05-17 16:46:43 +02003308 EXPECT_TRUE(vp9_settings.frameDroppingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003309
Niels Möllerff40b142018-04-09 08:49:14 +02003310 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003311}
3312
Sergey Silkinf18072e2018-03-14 10:35:35 +01003313TEST_F(Vp9SettingsTest, MultipleSsrcsEnablesSvc) {
3314 cricket::VideoSendParameters parameters;
3315 parameters.codecs.push_back(GetEngineCodec("VP9"));
3316 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3317
3318 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
3319
3320 FakeVideoSendStream* stream =
3321 AddSendStream(CreateSimStreamParams("cname", ssrcs));
3322
3323 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
Sergey Silkinf18072e2018-03-14 10:35:35 +01003324
Niels Möller805a27e2019-01-21 12:21:27 +01003325 webrtc::test::FrameForwarder frame_forwarder;
3326 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, &frame_forwarder));
Sergey Silkinf18072e2018-03-14 10:35:35 +01003327 channel_->SetSend(true);
3328
Niels Möller805a27e2019-01-21 12:21:27 +01003329 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Sergey Silkinf18072e2018-03-14 10:35:35 +01003330
3331 webrtc::VideoCodecVP9 vp9_settings;
3332 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3333
3334 const size_t kNumSpatialLayers = ssrcs.size();
3335 const size_t kNumTemporalLayers = 3;
3336 EXPECT_EQ(vp9_settings.numberOfSpatialLayers, kNumSpatialLayers);
3337 EXPECT_EQ(vp9_settings.numberOfTemporalLayers, kNumTemporalLayers);
3338
Niels Möllerff40b142018-04-09 08:49:14 +02003339 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, nullptr));
Sergey Silkinf18072e2018-03-14 10:35:35 +01003340}
3341
Ilya Nikolaevskiy33d2a912019-04-02 11:05:03 +02003342TEST_F(Vp9SettingsTest, SvcModeCreatesSingleRtpStream) {
3343 cricket::VideoSendParameters parameters;
3344 parameters.codecs.push_back(GetEngineCodec("VP9"));
3345 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3346
3347 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
3348
3349 FakeVideoSendStream* stream =
3350 AddSendStream(CreateSimStreamParams("cname", ssrcs));
3351
3352 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3353
3354 // Despite 3 ssrcs provided, single layer is used.
3355 EXPECT_EQ(1u, config.rtp.ssrcs.size());
3356
3357 webrtc::test::FrameForwarder frame_forwarder;
3358 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, &frame_forwarder));
3359 channel_->SetSend(true);
3360
3361 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
3362
3363 webrtc::VideoCodecVP9 vp9_settings;
3364 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3365
3366 const size_t kNumSpatialLayers = ssrcs.size();
3367 EXPECT_EQ(vp9_settings.numberOfSpatialLayers, kNumSpatialLayers);
3368
3369 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, nullptr));
3370}
3371
Sergey Silkin8b9b5f92018-12-10 09:28:53 +01003372TEST_F(Vp9SettingsTest, AllEncodingParametersCopied) {
3373 cricket::VideoSendParameters send_parameters;
3374 send_parameters.codecs.push_back(GetEngineCodec("VP9"));
3375 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
3376
3377 const size_t kNumSpatialLayers = 3;
3378 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
3379
3380 FakeVideoSendStream* stream =
3381 AddSendStream(CreateSimStreamParams("cname", ssrcs));
3382
3383 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(ssrcs[0]);
3384 ASSERT_EQ(kNumSpatialLayers, parameters.encodings.size());
3385 ASSERT_TRUE(parameters.encodings[0].active);
3386 ASSERT_TRUE(parameters.encodings[1].active);
3387 ASSERT_TRUE(parameters.encodings[2].active);
3388 // Invert value to verify copying.
3389 parameters.encodings[1].active = false;
3390 EXPECT_TRUE(channel_->SetRtpSendParameters(ssrcs[0], parameters).ok());
3391
3392 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
3393
3394 // number_of_streams should be 1 since all spatial layers are sent on the
3395 // same SSRC. But encoding parameters of all layers is supposed to be copied
3396 // and stored in simulcast_layers[].
3397 EXPECT_EQ(1u, encoder_config.number_of_streams);
3398 EXPECT_EQ(encoder_config.simulcast_layers.size(), kNumSpatialLayers);
3399 EXPECT_TRUE(encoder_config.simulcast_layers[0].active);
3400 EXPECT_FALSE(encoder_config.simulcast_layers[1].active);
3401 EXPECT_TRUE(encoder_config.simulcast_layers[2].active);
3402}
3403
Sergey Silkincf267052019-04-09 11:40:09 +02003404class Vp9SettingsTestWithFieldTrial
3405 : public Vp9SettingsTest,
3406 public ::testing::WithParamInterface<
3407 ::testing::tuple<const char*, int, int, webrtc::InterLayerPredMode>> {
asaperssonc5dabdd2016-03-21 04:15:50 -07003408 protected:
Sergey Silkincf267052019-04-09 11:40:09 +02003409 Vp9SettingsTestWithFieldTrial()
3410 : Vp9SettingsTest(::testing::get<0>(GetParam())),
3411 num_spatial_layers_(::testing::get<1>(GetParam())),
3412 num_temporal_layers_(::testing::get<2>(GetParam())),
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003413 inter_layer_pred_mode_(::testing::get<3>(GetParam())) {}
Sergey Silkincf267052019-04-09 11:40:09 +02003414
3415 void VerifySettings(int num_spatial_layers,
3416 int num_temporal_layers,
3417 webrtc::InterLayerPredMode interLayerPred) {
asaperssonc5dabdd2016-03-21 04:15:50 -07003418 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003419 parameters.codecs.push_back(GetEngineCodec("VP9"));
asaperssonc5dabdd2016-03-21 04:15:50 -07003420 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3421
3422 FakeVideoSendStream* stream = SetUpSimulcast(false, false);
3423
Niels Möller805a27e2019-01-21 12:21:27 +01003424 webrtc::test::FrameForwarder frame_forwarder;
3425 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
asaperssonc5dabdd2016-03-21 04:15:50 -07003426 channel_->SetSend(true);
3427
Niels Möller805a27e2019-01-21 12:21:27 +01003428 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
asaperssonc5dabdd2016-03-21 04:15:50 -07003429
3430 webrtc::VideoCodecVP9 vp9_settings;
3431 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3432 EXPECT_EQ(num_spatial_layers, vp9_settings.numberOfSpatialLayers);
3433 EXPECT_EQ(num_temporal_layers, vp9_settings.numberOfTemporalLayers);
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003434 EXPECT_EQ(inter_layer_pred_mode_, vp9_settings.interLayerPred);
asaperssonc5dabdd2016-03-21 04:15:50 -07003435
Niels Möllerff40b142018-04-09 08:49:14 +02003436 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
asaperssonc5dabdd2016-03-21 04:15:50 -07003437 }
Sergey Silkincf267052019-04-09 11:40:09 +02003438
3439 const uint8_t num_spatial_layers_;
3440 const uint8_t num_temporal_layers_;
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003441 const webrtc::InterLayerPredMode inter_layer_pred_mode_;
asaperssonc5dabdd2016-03-21 04:15:50 -07003442};
3443
Sergey Silkincf267052019-04-09 11:40:09 +02003444TEST_P(Vp9SettingsTestWithFieldTrial, VerifyCodecSettings) {
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003445 VerifySettings(num_spatial_layers_, num_temporal_layers_,
3446 inter_layer_pred_mode_);
asaperssonc5dabdd2016-03-21 04:15:50 -07003447}
3448
Sergey Silkincf267052019-04-09 11:40:09 +02003449INSTANTIATE_TEST_SUITE_P(
Mirko Bonadei09f11952019-09-29 10:19:42 +02003450 All,
Sergey Silkincf267052019-04-09 11:40:09 +02003451 Vp9SettingsTestWithFieldTrial,
3452 ::testing::Values(
3453 std::make_tuple("", 1, 1, webrtc::InterLayerPredMode::kOnKeyPic),
3454 std::make_tuple("WebRTC-SupportVP9SVC/Default/",
3455 1,
3456 1,
3457 webrtc::InterLayerPredMode::kOnKeyPic),
3458 std::make_tuple("WebRTC-SupportVP9SVC/EnabledByFlag_2SL3TL/",
3459 2,
3460 3,
3461 webrtc::InterLayerPredMode::kOnKeyPic),
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003462 std::make_tuple("WebRTC-Vp9InterLayerPred/Default/",
Sergey Silkincf267052019-04-09 11:40:09 +02003463 1,
3464 1,
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003465 webrtc::InterLayerPredMode::kOnKeyPic),
3466 std::make_tuple("WebRTC-Vp9InterLayerPred/Disabled/",
Sergey Silkincf267052019-04-09 11:40:09 +02003467 1,
3468 1,
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003469 webrtc::InterLayerPredMode::kOnKeyPic),
3470 std::make_tuple(
3471 "WebRTC-Vp9InterLayerPred/Enabled,inter_layer_pred_mode:off/",
3472 1,
3473 1,
3474 webrtc::InterLayerPredMode::kOff),
3475 std::make_tuple(
3476 "WebRTC-Vp9InterLayerPred/Enabled,inter_layer_pred_mode:on/",
3477 1,
3478 1,
3479 webrtc::InterLayerPredMode::kOn),
3480 std::make_tuple(
3481 "WebRTC-Vp9InterLayerPred/Enabled,inter_layer_pred_mode:onkeypic/",
3482 1,
3483 1,
3484 webrtc::InterLayerPredMode::kOnKeyPic)));
asaperssonc5dabdd2016-03-21 04:15:50 -07003485
Åsa Persson45bbc8a2017-11-13 10:16:47 +01003486TEST_F(WebRtcVideoChannelTest, VerifyMinBitrate) {
3487 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3488 ASSERT_EQ(1u, streams.size());
Elad Alon80f53b72019-10-11 16:19:43 +02003489 EXPECT_EQ(webrtc::kDefaultMinVideoBitrateBps, streams[0].min_bitrate_bps);
Åsa Persson45bbc8a2017-11-13 10:16:47 +01003490}
3491
3492TEST_F(WebRtcVideoChannelTest, VerifyMinBitrateWithForcedFallbackFieldTrial) {
Elad Alon040dc432019-05-22 15:40:02 +02003493 RTC_DCHECK(!override_field_trials_);
Mirko Bonadei317a1f02019-09-17 17:06:18 +02003494 override_field_trials_ = std::make_unique<webrtc::test::ScopedFieldTrials>(
Åsa Persson45bbc8a2017-11-13 10:16:47 +01003495 "WebRTC-VP8-Forced-Fallback-Encoder-v2/Enabled-1,2,34567/");
3496 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3497 ASSERT_EQ(1u, streams.size());
3498 EXPECT_EQ(34567, streams[0].min_bitrate_bps);
3499}
3500
asapersson3c81a1a2017-06-14 05:52:21 -07003501TEST_F(WebRtcVideoChannelTest,
3502 BalancedDegradationPreferenceNotSupportedWithoutFieldtrial) {
Elad Alon040dc432019-05-22 15:40:02 +02003503 RTC_DCHECK(!override_field_trials_);
Mirko Bonadei317a1f02019-09-17 17:06:18 +02003504 override_field_trials_ = std::make_unique<webrtc::test::ScopedFieldTrials>(
asapersson3c81a1a2017-06-14 05:52:21 -07003505 "WebRTC-Video-BalancedDegradation/Disabled/");
3506 const bool kResolutionScalingEnabled = true;
3507 const bool kFpsScalingEnabled = false;
3508 TestDegradationPreference(kResolutionScalingEnabled, kFpsScalingEnabled);
3509}
3510
3511TEST_F(WebRtcVideoChannelTest,
3512 BalancedDegradationPreferenceSupportedBehindFieldtrial) {
Elad Alon040dc432019-05-22 15:40:02 +02003513 RTC_DCHECK(!override_field_trials_);
Mirko Bonadei317a1f02019-09-17 17:06:18 +02003514 override_field_trials_ = std::make_unique<webrtc::test::ScopedFieldTrials>(
asapersson3c81a1a2017-06-14 05:52:21 -07003515 "WebRTC-Video-BalancedDegradation/Enabled/");
3516 const bool kResolutionScalingEnabled = true;
3517 const bool kFpsScalingEnabled = true;
3518 TestDegradationPreference(kResolutionScalingEnabled, kFpsScalingEnabled);
3519}
3520
eladalonf1841382017-06-12 01:16:46 -07003521TEST_F(WebRtcVideoChannelTest, AdaptsOnOveruse) {
Erik Språngefbde372015-04-29 16:21:28 +02003522 TestCpuAdaptation(true, false);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003523}
3524
eladalonf1841382017-06-12 01:16:46 -07003525TEST_F(WebRtcVideoChannelTest, DoesNotAdaptOnOveruseWhenDisabled) {
Erik Språngefbde372015-04-29 16:21:28 +02003526 TestCpuAdaptation(false, false);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003527}
3528
Niels Möller3de32e62019-01-18 08:42:18 +01003529TEST_F(WebRtcVideoChannelTest, DoesNotAdaptWhenScreeensharing) {
3530 TestCpuAdaptation(false, true);
3531}
3532
eladalonf1841382017-06-12 01:16:46 -07003533TEST_F(WebRtcVideoChannelTest, DoesNotAdaptOnOveruseWhenScreensharing) {
Erik Språngefbde372015-04-29 16:21:28 +02003534 TestCpuAdaptation(true, true);
3535}
3536
eladalonf1841382017-06-12 01:16:46 -07003537TEST_F(WebRtcVideoChannelTest, PreviousAdaptationDoesNotApplyToScreenshare) {
magjed509e4fe2016-11-18 01:34:11 -08003538 cricket::VideoCodec codec = GetEngineCodec("VP8");
Per766ad3b2016-04-05 15:23:49 +02003539 cricket::VideoSendParameters parameters;
3540 parameters.codecs.push_back(codec);
3541
kthelgason2bc68642017-02-07 07:02:22 -08003542 MediaConfig media_config = GetMediaConfig();
Niels Möller1d7ecd22018-01-18 15:25:12 +01003543 media_config.video.enable_cpu_adaptation = true;
Sebastian Jansson84848f22018-11-16 10:40:36 +01003544 channel_.reset(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02003545 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions(),
3546 video_bitrate_allocator_factory_.get()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003547 channel_->OnReadyToSend(true);
Per766ad3b2016-04-05 15:23:49 +02003548 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3549
3550 AddSendStream();
Niels Möller805a27e2019-01-21 12:21:27 +01003551 webrtc::test::FrameForwarder frame_forwarder;
Per766ad3b2016-04-05 15:23:49 +02003552
Per766ad3b2016-04-05 15:23:49 +02003553 ASSERT_TRUE(channel_->SetSend(true));
3554 cricket::VideoOptions camera_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003555 camera_options.is_screencast = false;
Niels Möller805a27e2019-01-21 12:21:27 +01003556 channel_->SetVideoSend(last_ssrc_, &camera_options, &frame_forwarder);
Per766ad3b2016-04-05 15:23:49 +02003557
3558 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3559 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
Per766ad3b2016-04-05 15:23:49 +02003560
Niels Möllerdcc70292019-01-15 16:32:38 +01003561 EXPECT_TRUE(send_stream->resolution_scaling_enabled());
3562 // Dont' expect anything on framerate_scaling_enabled, since the default is
3563 // transitioning from MAINTAIN_FRAMERATE to BALANCED.
Per766ad3b2016-04-05 15:23:49 +02003564
Niels Möllerdcc70292019-01-15 16:32:38 +01003565 // Switch to screen share. Expect no resolution scaling.
Per766ad3b2016-04-05 15:23:49 +02003566 cricket::VideoOptions screenshare_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003567 screenshare_options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01003568 channel_->SetVideoSend(last_ssrc_, &screenshare_options, &frame_forwarder);
sprangf24a0642017-02-28 13:23:26 -08003569 ASSERT_EQ(2, fake_call_->GetNumCreatedSendStreams());
3570 send_stream = fake_call_->GetVideoSendStreams().front();
Niels Möllerdcc70292019-01-15 16:32:38 +01003571 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
Per766ad3b2016-04-05 15:23:49 +02003572
Niels Möllerdcc70292019-01-15 16:32:38 +01003573 // Switch back to the normal capturer. Expect resolution scaling to be
3574 // reenabled.
Niels Möller805a27e2019-01-21 12:21:27 +01003575 channel_->SetVideoSend(last_ssrc_, &camera_options, &frame_forwarder);
3576 send_stream = fake_call_->GetVideoSendStreams().front();
sprangf24a0642017-02-28 13:23:26 -08003577 ASSERT_EQ(3, fake_call_->GetNumCreatedSendStreams());
3578 send_stream = fake_call_->GetVideoSendStreams().front();
Niels Möllerdcc70292019-01-15 16:32:38 +01003579 EXPECT_TRUE(send_stream->resolution_scaling_enabled());
Per766ad3b2016-04-05 15:23:49 +02003580
Niels Möllerff40b142018-04-09 08:49:14 +02003581 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Per766ad3b2016-04-05 15:23:49 +02003582}
3583
asapersson3c81a1a2017-06-14 05:52:21 -07003584// TODO(asapersson): Remove this test when the balanced field trial is removed.
3585void WebRtcVideoChannelTest::TestDegradationPreference(
3586 bool resolution_scaling_enabled,
3587 bool fps_scaling_enabled) {
3588 cricket::VideoCodec codec = GetEngineCodec("VP8");
3589 cricket::VideoSendParameters parameters;
3590 parameters.codecs.push_back(codec);
3591
3592 MediaConfig media_config = GetMediaConfig();
Niels Möller1d7ecd22018-01-18 15:25:12 +01003593 media_config.video.enable_cpu_adaptation = true;
Sebastian Jansson84848f22018-11-16 10:40:36 +01003594 channel_.reset(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02003595 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions(),
3596 video_bitrate_allocator_factory_.get()));
asapersson3c81a1a2017-06-14 05:52:21 -07003597 channel_->OnReadyToSend(true);
3598
3599 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3600
3601 AddSendStream();
3602
Niels Möller805a27e2019-01-21 12:21:27 +01003603 webrtc::test::FrameForwarder frame_forwarder;
asapersson3c81a1a2017-06-14 05:52:21 -07003604 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01003605 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
asapersson3c81a1a2017-06-14 05:52:21 -07003606
3607 EXPECT_TRUE(channel_->SetSend(true));
3608
3609 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
3610 EXPECT_EQ(resolution_scaling_enabled,
3611 send_stream->resolution_scaling_enabled());
3612 EXPECT_EQ(fps_scaling_enabled, send_stream->framerate_scaling_enabled());
3613
Niels Möllerff40b142018-04-09 08:49:14 +02003614 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
asapersson3c81a1a2017-06-14 05:52:21 -07003615}
3616
eladalonf1841382017-06-12 01:16:46 -07003617void WebRtcVideoChannelTest::TestCpuAdaptation(bool enable_overuse,
3618 bool is_screenshare) {
magjed509e4fe2016-11-18 01:34:11 -08003619 cricket::VideoCodec codec = GetEngineCodec("VP8");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003620 cricket::VideoSendParameters parameters;
3621 parameters.codecs.push_back(codec);
nisse51542be2016-02-12 02:27:06 -08003622
kthelgason2bc68642017-02-07 07:02:22 -08003623 MediaConfig media_config = GetMediaConfig();
3624 if (enable_overuse) {
Niels Möller1d7ecd22018-01-18 15:25:12 +01003625 media_config.video.enable_cpu_adaptation = true;
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003626 }
Sebastian Jansson84848f22018-11-16 10:40:36 +01003627 channel_.reset(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02003628 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions(),
3629 video_bitrate_allocator_factory_.get()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003630 channel_->OnReadyToSend(true);
nisse51542be2016-02-12 02:27:06 -08003631
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003632 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003633
3634 AddSendStream();
3635
Niels Möller805a27e2019-01-21 12:21:27 +01003636 webrtc::test::FrameForwarder frame_forwarder;
nisse05103312016-03-16 02:22:50 -07003637 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003638 options.is_screencast = is_screenshare;
Niels Möller805a27e2019-01-21 12:21:27 +01003639 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003640
3641 EXPECT_TRUE(channel_->SetSend(true));
3642
solenberge5269742015-09-08 05:13:22 -07003643 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
perkj2d5f0912016-02-29 00:04:41 -08003644
sprangc5d62e22017-04-02 23:53:04 -07003645 if (!enable_overuse) {
perkj803d97f2016-11-01 11:45:46 -07003646 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
sprangc5d62e22017-04-02 23:53:04 -07003647 EXPECT_FALSE(send_stream->framerate_scaling_enabled());
Niels Möller805a27e2019-01-21 12:21:27 +01003648 } else if (is_screenshare) {
sprangc5d62e22017-04-02 23:53:04 -07003649 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
3650 EXPECT_TRUE(send_stream->framerate_scaling_enabled());
3651 } else {
3652 EXPECT_TRUE(send_stream->resolution_scaling_enabled());
3653 EXPECT_FALSE(send_stream->framerate_scaling_enabled());
3654 }
Niels Möllerff40b142018-04-09 08:49:14 +02003655 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003656}
3657
eladalonf1841382017-06-12 01:16:46 -07003658TEST_F(WebRtcVideoChannelTest, EstimatesNtpStartTimeCorrectly) {
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003659 // Start at last timestamp to verify that wraparounds are estimated correctly.
3660 static const uint32_t kInitialTimestamp = 0xFFFFFFFFu;
3661 static const int64_t kInitialNtpTimeMs = 1247891230;
3662 static const int kFrameOffsetMs = 20;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003663 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003664
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003665 FakeVideoReceiveStream* stream = AddRecvStream();
3666 cricket::FakeVideoRenderer renderer;
nisse08582ff2016-02-04 01:24:52 -08003667 EXPECT_TRUE(channel_->SetSink(last_ssrc_, &renderer));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003668
Artem Titov1ebfb6a2019-01-03 23:49:37 +01003669 webrtc::VideoFrame video_frame =
3670 webrtc::VideoFrame::Builder()
3671 .set_video_frame_buffer(CreateBlackFrameBuffer(4, 4))
3672 .set_timestamp_rtp(kInitialTimestamp)
3673 .set_timestamp_us(0)
3674 .set_rotation(webrtc::kVideoRotation_0)
3675 .build();
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003676 // Initial NTP time is not available on the first frame, but should still be
3677 // able to be estimated.
nisseeb83a1a2016-03-21 01:27:56 -07003678 stream->InjectFrame(video_frame);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003679
3680 EXPECT_EQ(1, renderer.num_rendered_frames());
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003681
3682 // This timestamp is kInitialTimestamp (-1) + kFrameOffsetMs * 90, which
3683 // triggers a constant-overflow warning, hence we're calculating it explicitly
3684 // here.
Sebastian Jansson40889f32019-04-17 12:11:20 +02003685 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(kFrameOffsetMs));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003686 video_frame.set_timestamp(kFrameOffsetMs * 90 - 1);
3687 video_frame.set_ntp_time_ms(kInitialNtpTimeMs + kFrameOffsetMs);
nisseeb83a1a2016-03-21 01:27:56 -07003688 stream->InjectFrame(video_frame);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003689
3690 EXPECT_EQ(2, renderer.num_rendered_frames());
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003691
3692 // Verify that NTP time has been correctly deduced.
3693 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00003694 ASSERT_TRUE(channel_->GetStats(&info));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003695 ASSERT_EQ(1u, info.receivers.size());
3696 EXPECT_EQ(kInitialNtpTimeMs, info.receivers[0].capture_start_ntp_time_ms);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003697}
3698
eladalonf1841382017-06-12 01:16:46 -07003699TEST_F(WebRtcVideoChannelTest, SetDefaultSendCodecs) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02003700 AssignDefaultAptRtxTypes();
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003701 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003702
3703 VideoCodec codec;
3704 EXPECT_TRUE(channel_->GetSendCodec(&codec));
pbos@webrtc.org9fbb7172014-06-13 09:34:13 +00003705 EXPECT_TRUE(codec.Matches(engine_.codecs()[0]));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003706
3707 // Using a RTX setup to verify that the default RTX payload type is good.
Peter Boström0c4e06b2015-10-07 12:23:21 +02003708 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
3709 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003710 FakeVideoSendStream* stream = AddSendStream(
3711 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
perkj26091b12016-09-01 01:17:40 -07003712 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003713
3714 // Make sure NACK and FEC are enabled on the correct payload types.
3715 EXPECT_EQ(1000, config.rtp.nack.rtp_history_ms);
magjed509e4fe2016-11-18 01:34:11 -08003716 EXPECT_EQ(GetEngineCodec("ulpfec").id, config.rtp.ulpfec.ulpfec_payload_type);
3717 EXPECT_EQ(GetEngineCodec("red").id, config.rtp.ulpfec.red_payload_type);
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003718
3719 EXPECT_EQ(1u, config.rtp.rtx.ssrcs.size());
3720 EXPECT_EQ(kRtxSsrcs1[0], config.rtp.rtx.ssrcs[0]);
Shao Changbine62202f2015-04-21 20:24:50 +08003721 VerifySendStreamHasRtxTypes(config, default_apt_rtx_types_);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003722 // TODO(juberti): Check RTCP, PLI, TMMBR.
3723}
3724
Mirta Dvornicic479a3c02019-06-04 15:38:50 +02003725TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutPacketization) {
3726 cricket::VideoSendParameters parameters;
3727 parameters.codecs.push_back(GetEngineCodec("VP8"));
3728 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3729
3730 FakeVideoSendStream* stream = AddSendStream();
3731 const webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3732 EXPECT_FALSE(config.rtp.raw_payload);
3733}
3734
3735TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithPacketization) {
3736 cricket::VideoSendParameters parameters;
3737 parameters.codecs.push_back(GetEngineCodec("VP8"));
3738 parameters.codecs.back().packetization = kPacketizationParamRaw;
3739 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3740
3741 FakeVideoSendStream* stream = AddSendStream();
3742 const webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3743 EXPECT_TRUE(config.rtp.raw_payload);
3744}
3745
brandtr31bd2242017-05-19 05:47:46 -07003746// The following four tests ensures that FlexFEC is not activated by default
3747// when the field trials are not enabled.
3748// TODO(brandtr): Remove or update these tests when FlexFEC _is_ enabled by
3749// default.
Yves Gerey665174f2018-06-19 15:03:05 +02003750TEST_F(WebRtcVideoChannelTest, FlexfecSendCodecWithoutSsrcNotExposedByDefault) {
brandtr468da7c2016-11-22 02:16:47 -08003751 FakeVideoSendStream* stream = AddSendStream();
3752 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3753
brandtr3d200bd2017-01-16 06:59:19 -08003754 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr31bd2242017-05-19 05:47:46 -07003755 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3756 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
brandtr468da7c2016-11-22 02:16:47 -08003757}
3758
eladalonf1841382017-06-12 01:16:46 -07003759TEST_F(WebRtcVideoChannelTest, FlexfecSendCodecWithSsrcNotExposedByDefault) {
brandtr468da7c2016-11-22 02:16:47 -08003760 FakeVideoSendStream* stream = AddSendStream(
3761 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3762 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3763
brandtr3d200bd2017-01-16 06:59:19 -08003764 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr31bd2242017-05-19 05:47:46 -07003765 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3766 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3767}
3768
Yves Gerey665174f2018-06-19 15:03:05 +02003769TEST_F(WebRtcVideoChannelTest, FlexfecRecvCodecWithoutSsrcNotExposedByDefault) {
brandtr31bd2242017-05-19 05:47:46 -07003770 AddRecvStream();
3771
3772 const std::vector<FakeFlexfecReceiveStream*>& streams =
3773 fake_call_->GetFlexfecReceiveStreams();
3774 EXPECT_TRUE(streams.empty());
3775}
3776
eladalonf1841382017-06-12 01:16:46 -07003777TEST_F(WebRtcVideoChannelTest, FlexfecRecvCodecWithSsrcNotExposedByDefault) {
brandtr31bd2242017-05-19 05:47:46 -07003778 AddRecvStream(
3779 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3780
3781 const std::vector<FakeFlexfecReceiveStream*>& streams =
3782 fake_call_->GetFlexfecReceiveStreams();
3783 EXPECT_TRUE(streams.empty());
brandtr468da7c2016-11-22 02:16:47 -08003784}
3785
3786// TODO(brandtr): When FlexFEC is no longer behind a field trial, merge all
3787// tests that use this test fixture into the corresponding "non-field trial"
3788// tests.
eladalonf1841382017-06-12 01:16:46 -07003789class WebRtcVideoChannelFlexfecRecvTest : public WebRtcVideoChannelTest {
brandtr468da7c2016-11-22 02:16:47 -08003790 public:
eladalonf1841382017-06-12 01:16:46 -07003791 WebRtcVideoChannelFlexfecRecvTest()
3792 : WebRtcVideoChannelTest("WebRTC-FlexFEC-03-Advertised/Enabled/") {}
brandtr468da7c2016-11-22 02:16:47 -08003793};
3794
eladalonf1841382017-06-12 01:16:46 -07003795TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr36e7d702017-01-13 07:15:54 -08003796 DefaultFlexfecCodecHasTransportCcAndRembFeedbackParam) {
3797 EXPECT_TRUE(cricket::HasTransportCc(GetEngineCodec("flexfec-03")));
3798 EXPECT_TRUE(cricket::HasRemb(GetEngineCodec("flexfec-03")));
3799}
3800
eladalonf1841382017-06-12 01:16:46 -07003801TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetDefaultRecvCodecsWithoutSsrc) {
brandtr31bd2242017-05-19 05:47:46 -07003802 AddRecvStream();
3803
3804 const std::vector<FakeFlexfecReceiveStream*>& streams =
3805 fake_call_->GetFlexfecReceiveStreams();
3806 EXPECT_TRUE(streams.empty());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003807
3808 const std::vector<FakeVideoReceiveStream*>& video_streams =
3809 fake_call_->GetVideoReceiveStreams();
3810 ASSERT_EQ(1U, video_streams.size());
3811 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3812 EXPECT_EQ(0, video_stream.GetNumAddedSecondarySinks());
3813 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr31bd2242017-05-19 05:47:46 -07003814}
3815
eladalonf1841382017-06-12 01:16:46 -07003816TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetDefaultRecvCodecsWithSsrc) {
brandtr31bd2242017-05-19 05:47:46 -07003817 AddRecvStream(
3818 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3819
3820 const std::vector<FakeFlexfecReceiveStream*>& streams =
3821 fake_call_->GetFlexfecReceiveStreams();
3822 ASSERT_EQ(1U, streams.size());
3823 const FakeFlexfecReceiveStream* stream = streams.front();
3824 const webrtc::FlexfecReceiveStream::Config& config = stream->GetConfig();
3825 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.payload_type);
3826 EXPECT_EQ(kFlexfecSsrc, config.remote_ssrc);
3827 ASSERT_EQ(1U, config.protected_media_ssrcs.size());
3828 EXPECT_EQ(kSsrcs1[0], config.protected_media_ssrcs[0]);
brandtr7cd28b92017-09-22 00:26:25 -07003829
3830 const std::vector<FakeVideoReceiveStream*>& video_streams =
3831 fake_call_->GetVideoReceiveStreams();
3832 ASSERT_EQ(1U, video_streams.size());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003833 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3834 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
brandtr7cd28b92017-09-22 00:26:25 -07003835 const webrtc::VideoReceiveStream::Config& video_config =
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003836 video_stream.GetConfig();
brandtr7cd28b92017-09-22 00:26:25 -07003837 EXPECT_TRUE(video_config.rtp.protected_by_flexfec);
brandtr31bd2242017-05-19 05:47:46 -07003838}
3839
eladalonf1841382017-06-12 01:16:46 -07003840TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr11fb4722017-05-30 01:31:37 -07003841 EnablingFlexfecDoesNotRecreateVideoReceiveStream) {
3842 cricket::VideoRecvParameters recv_parameters;
3843 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3844 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3845
3846 AddRecvStream(
3847 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3848 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003849 const std::vector<FakeVideoReceiveStream*>& video_streams =
3850 fake_call_->GetVideoReceiveStreams();
3851 ASSERT_EQ(1U, video_streams.size());
3852 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3853 EXPECT_EQ(0, video_stream.GetNumAddedSecondarySinks());
3854 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003855
3856 // Enable FlexFEC.
3857 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3858 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3859 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams())
3860 << "Enabling FlexFEC should create FlexfecReceiveStream.";
3861 EXPECT_EQ(1U, fake_call_->GetVideoReceiveStreams().size())
3862 << "Enabling FlexFEC should not create VideoReceiveStream.";
3863 EXPECT_EQ(1U, fake_call_->GetFlexfecReceiveStreams().size())
3864 << "Enabling FlexFEC should create a single FlexfecReceiveStream.";
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003865 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3866 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003867}
3868
eladalonf1841382017-06-12 01:16:46 -07003869TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr11fb4722017-05-30 01:31:37 -07003870 DisablingFlexfecDoesNotRecreateVideoReceiveStream) {
3871 cricket::VideoRecvParameters recv_parameters;
3872 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3873 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3874 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3875
3876 AddRecvStream(
3877 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3878 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams());
brandtr11fb4722017-05-30 01:31:37 -07003879 EXPECT_EQ(1U, fake_call_->GetFlexfecReceiveStreams().size());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003880 const std::vector<FakeVideoReceiveStream*>& video_streams =
3881 fake_call_->GetVideoReceiveStreams();
3882 ASSERT_EQ(1U, video_streams.size());
3883 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3884 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3885 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003886
3887 // Disable FlexFEC.
3888 recv_parameters.codecs.clear();
3889 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3890 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3891 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams())
3892 << "Disabling FlexFEC should not recreate VideoReceiveStream.";
3893 EXPECT_EQ(1U, fake_call_->GetVideoReceiveStreams().size())
3894 << "Disabling FlexFEC should not destroy VideoReceiveStream.";
3895 EXPECT_TRUE(fake_call_->GetFlexfecReceiveStreams().empty())
3896 << "Disabling FlexFEC should destroy FlexfecReceiveStream.";
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003897 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3898 EXPECT_EQ(1, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003899}
3900
Steve Anton2d2bbb12019-08-07 09:57:59 -07003901TEST_F(WebRtcVideoChannelFlexfecRecvTest, DuplicateFlexfecCodecIsDropped) {
3902 constexpr int kUnusedPayloadType1 = 127;
3903
3904 cricket::VideoRecvParameters recv_parameters;
3905 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3906 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3907 cricket::VideoCodec duplicate = GetEngineCodec("flexfec-03");
3908 duplicate.id = kUnusedPayloadType1;
3909 recv_parameters.codecs.push_back(duplicate);
3910 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3911
3912 AddRecvStream(
3913 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3914
3915 const std::vector<FakeFlexfecReceiveStream*>& streams =
3916 fake_call_->GetFlexfecReceiveStreams();
3917 ASSERT_EQ(1U, streams.size());
3918 const FakeFlexfecReceiveStream* stream = streams.front();
3919 const webrtc::FlexfecReceiveStream::Config& config = stream->GetConfig();
3920 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.payload_type);
3921}
3922
brandtr31bd2242017-05-19 05:47:46 -07003923// TODO(brandtr): When FlexFEC is no longer behind a field trial, merge all
3924// tests that use this test fixture into the corresponding "non-field trial"
3925// tests.
eladalonf1841382017-06-12 01:16:46 -07003926class WebRtcVideoChannelFlexfecSendRecvTest : public WebRtcVideoChannelTest {
brandtr31bd2242017-05-19 05:47:46 -07003927 public:
eladalonf1841382017-06-12 01:16:46 -07003928 WebRtcVideoChannelFlexfecSendRecvTest()
3929 : WebRtcVideoChannelTest(
brandtr31bd2242017-05-19 05:47:46 -07003930 "WebRTC-FlexFEC-03-Advertised/Enabled/WebRTC-FlexFEC-03/Enabled/") {
3931 }
3932};
3933
Yves Gerey665174f2018-06-19 15:03:05 +02003934TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetDefaultSendCodecsWithoutSsrc) {
brandtr468da7c2016-11-22 02:16:47 -08003935 FakeVideoSendStream* stream = AddSendStream();
3936 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3937
brandtr3d200bd2017-01-16 06:59:19 -08003938 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3939 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3940 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
brandtr468da7c2016-11-22 02:16:47 -08003941}
3942
eladalonf1841382017-06-12 01:16:46 -07003943TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetDefaultSendCodecsWithSsrc) {
brandtr468da7c2016-11-22 02:16:47 -08003944 FakeVideoSendStream* stream = AddSendStream(
3945 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3946 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3947
brandtr3d200bd2017-01-16 06:59:19 -08003948 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3949 EXPECT_EQ(kFlexfecSsrc, config.rtp.flexfec.ssrc);
3950 ASSERT_EQ(1U, config.rtp.flexfec.protected_media_ssrcs.size());
3951 EXPECT_EQ(kSsrcs1[0], config.rtp.flexfec.protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08003952}
3953
eladalonf1841382017-06-12 01:16:46 -07003954TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003955 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003956 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003957 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003958
3959 FakeVideoSendStream* stream = AddSendStream();
perkj26091b12016-09-01 01:17:40 -07003960 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003961
brandtrb5f2c3f2016-10-04 23:28:39 -07003962 EXPECT_EQ(-1, config.rtp.ulpfec.ulpfec_payload_type);
3963 EXPECT_EQ(-1, config.rtp.ulpfec.red_payload_type);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003964}
3965
eladalonf1841382017-06-12 01:16:46 -07003966TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetSendCodecsWithoutFec) {
brandtr468da7c2016-11-22 02:16:47 -08003967 cricket::VideoSendParameters parameters;
3968 parameters.codecs.push_back(GetEngineCodec("VP8"));
3969 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3970
3971 FakeVideoSendStream* stream = AddSendStream();
3972 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3973
brandtr3d200bd2017-01-16 06:59:19 -08003974 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr468da7c2016-11-22 02:16:47 -08003975}
3976
eladalonf1841382017-06-12 01:16:46 -07003977TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetRecvCodecsWithFec) {
brandtr9c3d4c42017-01-23 06:59:13 -08003978 AddRecvStream(
3979 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08003980
3981 cricket::VideoRecvParameters recv_parameters;
3982 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3983 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3984 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
brandtr9d58d942017-02-03 04:43:41 -08003985
3986 const std::vector<FakeFlexfecReceiveStream*>& flexfec_streams =
3987 fake_call_->GetFlexfecReceiveStreams();
3988 ASSERT_EQ(1U, flexfec_streams.size());
3989 const FakeFlexfecReceiveStream* flexfec_stream = flexfec_streams.front();
3990 const webrtc::FlexfecReceiveStream::Config& flexfec_stream_config =
3991 flexfec_stream->GetConfig();
brandtr9c3d4c42017-01-23 06:59:13 -08003992 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9d58d942017-02-03 04:43:41 -08003993 flexfec_stream_config.payload_type);
3994 EXPECT_EQ(kFlexfecSsrc, flexfec_stream_config.remote_ssrc);
3995 ASSERT_EQ(1U, flexfec_stream_config.protected_media_ssrcs.size());
3996 EXPECT_EQ(kSsrcs1[0], flexfec_stream_config.protected_media_ssrcs[0]);
3997 const std::vector<FakeVideoReceiveStream*>& video_streams =
3998 fake_call_->GetVideoReceiveStreams();
3999 const FakeVideoReceiveStream* video_stream = video_streams.front();
4000 const webrtc::VideoReceiveStream::Config& video_stream_config =
4001 video_stream->GetConfig();
4002 EXPECT_EQ(video_stream_config.rtp.local_ssrc,
4003 flexfec_stream_config.local_ssrc);
4004 EXPECT_EQ(video_stream_config.rtp.rtcp_mode, flexfec_stream_config.rtcp_mode);
4005 EXPECT_EQ(video_stream_config.rtcp_send_transport,
4006 flexfec_stream_config.rtcp_send_transport);
4007 // TODO(brandtr): Update this EXPECT when we set |transport_cc| in a
4008 // spec-compliant way.
4009 EXPECT_EQ(video_stream_config.rtp.transport_cc,
4010 flexfec_stream_config.transport_cc);
4011 EXPECT_EQ(video_stream_config.rtp.rtcp_mode, flexfec_stream_config.rtcp_mode);
4012 EXPECT_EQ(video_stream_config.rtp.extensions,
4013 flexfec_stream_config.rtp_header_extensions);
brandtr9c3d4c42017-01-23 06:59:13 -08004014}
4015
brandtr31bd2242017-05-19 05:47:46 -07004016// We should not send FlexFEC, even if we advertise it, unless the right
4017// field trial is set.
4018// TODO(brandtr): Remove when FlexFEC is enabled by default.
eladalonf1841382017-06-12 01:16:46 -07004019TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004020 SetSendCodecsWithoutSsrcWithFecDoesNotEnableFec) {
4021 cricket::VideoSendParameters parameters;
4022 parameters.codecs.push_back(GetEngineCodec("VP8"));
4023 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4024 ASSERT_TRUE(channel_->SetSendParameters(parameters));
4025
4026 FakeVideoSendStream* stream = AddSendStream();
4027 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
4028
4029 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
Mirko Bonadeif859e552018-05-30 15:31:29 +02004030 EXPECT_EQ(0u, config.rtp.flexfec.ssrc);
brandtr31bd2242017-05-19 05:47:46 -07004031 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
4032}
4033
eladalonf1841382017-06-12 01:16:46 -07004034TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004035 SetSendCodecsWithSsrcWithFecDoesNotEnableFec) {
4036 cricket::VideoSendParameters parameters;
4037 parameters.codecs.push_back(GetEngineCodec("VP8"));
4038 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4039 ASSERT_TRUE(channel_->SetSendParameters(parameters));
4040
4041 FakeVideoSendStream* stream = AddSendStream(
4042 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
4043 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
4044
4045 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
Mirko Bonadeif859e552018-05-30 15:31:29 +02004046 EXPECT_EQ(0u, config.rtp.flexfec.ssrc);
brandtr31bd2242017-05-19 05:47:46 -07004047 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
4048}
4049
eladalonf1841382017-06-12 01:16:46 -07004050TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004051 SetSendCodecRejectsRtxWithoutAssociatedPayloadType) {
magjed509e4fe2016-11-18 01:34:11 -08004052 const int kUnusedPayloadType = 127;
4053 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType));
4054
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004055 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004056 cricket::VideoCodec rtx_codec(kUnusedPayloadType, "rtx");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004057 parameters.codecs.push_back(rtx_codec);
4058 EXPECT_FALSE(channel_->SetSendParameters(parameters))
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004059 << "RTX codec without associated payload type should be rejected.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004060}
4061
eladalonf1841382017-06-12 01:16:46 -07004062TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004063 SetSendCodecRejectsRtxWithoutMatchingVideoCodec) {
magjed509e4fe2016-11-18 01:34:11 -08004064 const int kUnusedPayloadType1 = 126;
4065 const int kUnusedPayloadType2 = 127;
4066 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4067 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4068 {
4069 cricket::VideoCodec rtx_codec = cricket::VideoCodec::CreateRtxCodec(
4070 kUnusedPayloadType1, GetEngineCodec("VP8").id);
4071 cricket::VideoSendParameters parameters;
4072 parameters.codecs.push_back(GetEngineCodec("VP8"));
4073 parameters.codecs.push_back(rtx_codec);
4074 ASSERT_TRUE(channel_->SetSendParameters(parameters));
4075 }
4076 {
4077 cricket::VideoCodec rtx_codec = cricket::VideoCodec::CreateRtxCodec(
4078 kUnusedPayloadType1, kUnusedPayloadType2);
4079 cricket::VideoSendParameters parameters;
4080 parameters.codecs.push_back(GetEngineCodec("VP8"));
4081 parameters.codecs.push_back(rtx_codec);
4082 EXPECT_FALSE(channel_->SetSendParameters(parameters))
4083 << "RTX without matching video codec should be rejected.";
4084 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004085}
4086
eladalonf1841382017-06-12 01:16:46 -07004087TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithChangedRtxPayloadType) {
brandtr14742122017-01-27 04:53:07 -08004088 const int kUnusedPayloadType1 = 126;
4089 const int kUnusedPayloadType2 = 127;
4090 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4091 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4092
4093 // SSRCs for RTX.
4094 cricket::StreamParams params =
4095 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
4096 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
4097 AddSendStream(params);
4098
4099 // Original payload type for RTX.
4100 cricket::VideoSendParameters parameters;
4101 parameters.codecs.push_back(GetEngineCodec("VP8"));
4102 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
4103 rtx_codec.SetParam("apt", GetEngineCodec("VP8").id);
4104 parameters.codecs.push_back(rtx_codec);
4105 EXPECT_TRUE(channel_->SetSendParameters(parameters));
4106 ASSERT_EQ(1U, fake_call_->GetVideoSendStreams().size());
4107 const webrtc::VideoSendStream::Config& config_before =
4108 fake_call_->GetVideoSendStreams()[0]->GetConfig();
4109 EXPECT_EQ(kUnusedPayloadType1, config_before.rtp.rtx.payload_type);
4110 ASSERT_EQ(1U, config_before.rtp.rtx.ssrcs.size());
4111 EXPECT_EQ(kRtxSsrcs1[0], config_before.rtp.rtx.ssrcs[0]);
4112
4113 // Change payload type for RTX.
4114 parameters.codecs[1].id = kUnusedPayloadType2;
4115 EXPECT_TRUE(channel_->SetSendParameters(parameters));
4116 ASSERT_EQ(1U, fake_call_->GetVideoSendStreams().size());
4117 const webrtc::VideoSendStream::Config& config_after =
4118 fake_call_->GetVideoSendStreams()[0]->GetConfig();
4119 EXPECT_EQ(kUnusedPayloadType2, config_after.rtp.rtx.payload_type);
4120 ASSERT_EQ(1U, config_after.rtp.rtx.ssrcs.size());
4121 EXPECT_EQ(kRtxSsrcs1[0], config_after.rtp.rtx.ssrcs[0]);
4122}
4123
eladalonf1841382017-06-12 01:16:46 -07004124TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutFecDisablesFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004125 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004126 parameters.codecs.push_back(GetEngineCodec("VP8"));
4127 parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004128 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004129
4130 FakeVideoSendStream* stream = AddSendStream();
perkj26091b12016-09-01 01:17:40 -07004131 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004132
magjed509e4fe2016-11-18 01:34:11 -08004133 EXPECT_EQ(GetEngineCodec("ulpfec").id, config.rtp.ulpfec.ulpfec_payload_type);
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004134
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004135 parameters.codecs.pop_back();
4136 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00004137 stream = fake_call_->GetVideoSendStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004138 ASSERT_TRUE(stream != nullptr);
perkj26091b12016-09-01 01:17:40 -07004139 config = stream->GetConfig().Copy();
brandtrb5f2c3f2016-10-04 23:28:39 -07004140 EXPECT_EQ(-1, config.rtp.ulpfec.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004141 << "SetSendCodec without ULPFEC should disable current ULPFEC.";
4142}
4143
eladalonf1841382017-06-12 01:16:46 -07004144TEST_F(WebRtcVideoChannelFlexfecSendRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004145 SetSendCodecsWithoutFecDisablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004146 cricket::VideoSendParameters parameters;
4147 parameters.codecs.push_back(GetEngineCodec("VP8"));
4148 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4149 ASSERT_TRUE(channel_->SetSendParameters(parameters));
4150
4151 FakeVideoSendStream* stream = AddSendStream(
4152 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
4153 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
4154
brandtr3d200bd2017-01-16 06:59:19 -08004155 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
4156 EXPECT_EQ(kFlexfecSsrc, config.rtp.flexfec.ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004157 ASSERT_EQ(1U, config.rtp.flexfec.protected_media_ssrcs.size());
4158 EXPECT_EQ(kSsrcs1[0], config.rtp.flexfec.protected_media_ssrcs[0]);
4159
4160 parameters.codecs.pop_back();
4161 ASSERT_TRUE(channel_->SetSendParameters(parameters));
4162 stream = fake_call_->GetVideoSendStreams()[0];
4163 ASSERT_TRUE(stream != nullptr);
4164 config = stream->GetConfig().Copy();
brandtr3d200bd2017-01-16 06:59:19 -08004165 EXPECT_EQ(-1, config.rtp.flexfec.payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004166 << "SetSendCodec without FlexFEC should disable current FlexFEC.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004167}
4168
eladalonf1841382017-06-12 01:16:46 -07004169TEST_F(WebRtcVideoChannelTest, SetSendCodecsChangesExistingStreams) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004170 cricket::VideoSendParameters parameters;
perkj26752742016-10-24 01:21:16 -07004171 cricket::VideoCodec codec(100, "VP8");
4172 codec.SetParam(kCodecParamMaxQuantization, kDefaultQpMax);
4173 parameters.codecs.push_back(codec);
perkjfa10b552016-10-02 23:45:26 -07004174
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004175 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00004176 channel_->SetSend(true);
pbos@webrtc.org38ce7d02014-07-16 08:01:38 +00004177
pbos@webrtc.org86196c42015-02-16 21:02:00 +00004178 FakeVideoSendStream* stream = AddSendStream();
Niels Möller805a27e2019-01-21 12:21:27 +01004179 webrtc::test::FrameForwarder frame_forwarder;
4180 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00004181
4182 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
perkjfa10b552016-10-02 23:45:26 -07004183 EXPECT_EQ(kDefaultQpMax, streams[0].max_qp);
pbos@webrtc.org38ce7d02014-07-16 08:01:38 +00004184
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004185 parameters.codecs.clear();
perkj26752742016-10-24 01:21:16 -07004186 codec.SetParam(kCodecParamMaxQuantization, kDefaultQpMax + 1);
4187 parameters.codecs.push_back(codec);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004188 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00004189 streams = fake_call_->GetVideoSendStreams()[0]->GetVideoStreams();
perkjfa10b552016-10-02 23:45:26 -07004190 EXPECT_EQ(kDefaultQpMax + 1, streams[0].max_qp);
Niels Möllerff40b142018-04-09 08:49:14 +02004191 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004192}
4193
eladalonf1841382017-06-12 01:16:46 -07004194TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithBitrates) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00004195 SetSendCodecsShouldWorkForBitrates("100", 100000, "150", 150000, "200",
4196 200000);
4197}
4198
eladalonf1841382017-06-12 01:16:46 -07004199TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithHighMaxBitrate) {
pbos@webrtc.orga5f6fb52015-03-23 22:29:39 +00004200 SetSendCodecsShouldWorkForBitrates("", 0, "", -1, "10000", 10000000);
4201 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
4202 ASSERT_EQ(1u, streams.size());
4203 EXPECT_EQ(10000000, streams[0].max_bitrate_bps);
4204}
4205
eladalonf1841382017-06-12 01:16:46 -07004206TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org00873182014-11-25 14:03:34 +00004207 SetSendCodecsWithoutBitratesUsesCorrectDefaults) {
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004208 SetSendCodecsShouldWorkForBitrates("", 0, "", -1, "", -1);
pbos@webrtc.org00873182014-11-25 14:03:34 +00004209}
4210
eladalonf1841382017-06-12 01:16:46 -07004211TEST_F(WebRtcVideoChannelTest, SetSendCodecsCapsMinAndStartBitrate) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00004212 SetSendCodecsShouldWorkForBitrates("-1", 0, "-100", -1, "", -1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004213}
4214
eladalonf1841382017-06-12 01:16:46 -07004215TEST_F(WebRtcVideoChannelTest, SetSendCodecsRejectsMaxLessThanMinBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004216 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "300";
4217 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "200";
4218 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004219}
4220
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004221// Test that when both the codec-specific bitrate params and max_bandwidth_bps
4222// are present in the same send parameters, the settings are combined correctly.
eladalonf1841382017-06-12 01:16:46 -07004223TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithBitratesAndMaxSendBandwidth) {
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004224 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4225 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4226 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4227 send_parameters_.max_bandwidth_bps = 400000;
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004228 // We expect max_bandwidth_bps to take priority, if set.
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004229 ExpectSetBitrateParameters(100000, 200000, 400000);
4230 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
4231 // Since the codec isn't changing, start_bitrate_bps should be -1.
4232 ExpectSetBitrateParameters(100000, -1, 350000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004233
4234 // Decrease max_bandwidth_bps.
4235 send_parameters_.max_bandwidth_bps = 350000;
4236 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004237
4238 // Now try again with the values flipped around.
4239 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "400";
4240 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004241 ExpectSetBitrateParameters(100000, 200000, 300000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004242 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004243
4244 // If we change the codec max, max_bandwidth_bps should still apply.
4245 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "350";
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004246 ExpectSetBitrateParameters(100000, 200000, 300000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004247 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004248}
4249
Piotr (Peter) Slatala946b9682019-03-18 10:25:02 -07004250// Test that when both the codec-specific bitrate params and max_bandwidth_bps
4251// are present in the same send parameters, the settings are combined correctly.
4252TEST_F(WebRtcVideoChannelTest,
4253 SetSendCodecsWithBitratesAndMaxSendBandwidthForMediaTransport) {
4254 // Same as SetSendCodecsWithBitratesAndMaxSendBandwidth but with Media
4255 // Transport.
4256 webrtc::MediaTransportSettings settings;
4257 settings.is_caller = true;
4258 webrtc::FakeMediaTransport fake_media_transport(settings);
4259 std::unique_ptr<cricket::FakeNetworkInterface> network_interface(
4260 new cricket::FakeNetworkInterface);
Anton Sukhanov4f08faa2019-05-21 11:12:57 -07004261 channel_->SetInterface(network_interface.get(),
4262 webrtc::MediaTransportConfig(&fake_media_transport));
Piotr (Peter) Slatala946b9682019-03-18 10:25:02 -07004263
4264 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4265 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4266 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4267 send_parameters_.max_bandwidth_bps = 400000;
4268 {
4269 // We expect max_bandwidth_bps to take priority, if set.
4270 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4271 ASSERT_EQ(1u,
4272 fake_media_transport.target_rate_constraints_in_order().size());
4273 const webrtc::MediaTransportTargetRateConstraints& constraint =
4274 fake_media_transport.target_rate_constraints_in_order()[0];
4275 ASSERT_EQ(webrtc::DataRate::bps(100000), constraint.min_bitrate);
4276 ASSERT_EQ(webrtc::DataRate::bps(200000), constraint.starting_bitrate);
4277 ASSERT_EQ(webrtc::DataRate::bps(400000), constraint.max_bitrate);
4278 }
4279
4280 {
4281 // Decrease max_bandwidth_bps.
4282 send_parameters_.max_bandwidth_bps = 350000;
4283 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4284 ASSERT_EQ(2u,
4285 fake_media_transport.target_rate_constraints_in_order().size());
4286 const webrtc::MediaTransportTargetRateConstraints& constraint =
4287 fake_media_transport.target_rate_constraints_in_order()[1];
4288
4289 // Since the codec isn't changing, start_bitrate_bps should be 0.
4290 ASSERT_EQ(webrtc::DataRate::bps(100000), constraint.min_bitrate);
4291 ASSERT_EQ(absl::nullopt, constraint.starting_bitrate);
4292 ASSERT_EQ(webrtc::DataRate::bps(350000), constraint.max_bitrate);
4293 }
4294
4295 {
4296 // Now try again with the values flipped around.
4297 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "400";
4298 send_parameters_.max_bandwidth_bps = 300000;
4299 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4300 ASSERT_EQ(3u,
4301 fake_media_transport.target_rate_constraints_in_order().size());
4302 const webrtc::MediaTransportTargetRateConstraints& constraint =
4303 fake_media_transport.target_rate_constraints_in_order()[2];
4304
4305 ASSERT_EQ(webrtc::DataRate::bps(100000), constraint.min_bitrate);
4306 ASSERT_EQ(webrtc::DataRate::bps(200000), constraint.starting_bitrate);
4307 ASSERT_EQ(webrtc::DataRate::bps(300000), constraint.max_bitrate);
4308 }
4309
4310 {
4311 // Now try again with the values flipped around.
4312 // If we change the codec max, max_bandwidth_bps should still apply.
4313 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "350";
4314 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4315 ASSERT_EQ(4u,
4316 fake_media_transport.target_rate_constraints_in_order().size());
4317 const webrtc::MediaTransportTargetRateConstraints& constraint =
4318 fake_media_transport.target_rate_constraints_in_order()[3];
4319
4320 ASSERT_EQ(webrtc::DataRate::bps(100000), constraint.min_bitrate);
4321 ASSERT_EQ(webrtc::DataRate::bps(200000), constraint.starting_bitrate);
4322 ASSERT_EQ(webrtc::DataRate::bps(300000), constraint.max_bitrate);
4323 }
4324}
4325
Yves Gerey665174f2018-06-19 15:03:05 +02004326TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthShouldPreserveOtherBitrates) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00004327 SetSendCodecsShouldWorkForBitrates("100", 100000, "150", 150000, "200",
4328 200000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004329 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004330 // Setting max bitrate should keep previous min bitrate.
4331 // Setting max bitrate should not reset start bitrate.
4332 ExpectSetBitrateParameters(100000, -1, 300000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004333 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org00873182014-11-25 14:03:34 +00004334}
4335
eladalonf1841382017-06-12 01:16:46 -07004336TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthShouldBeRemovable) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004337 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004338 ExpectSetMaxBitrate(300000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004339 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos5c7760a2017-03-10 11:23:12 -08004340 // -1 means to disable max bitrate (set infinite).
4341 send_parameters_.max_bandwidth_bps = -1;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004342 ExpectSetMaxBitrate(-1);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004343 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004344}
4345
eladalonf1841382017-06-12 01:16:46 -07004346TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthAndAddSendStream) {
perkjfa10b552016-10-02 23:45:26 -07004347 send_parameters_.max_bandwidth_bps = 99999;
4348 FakeVideoSendStream* stream = AddSendStream();
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004349 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
perkjfa10b552016-10-02 23:45:26 -07004350 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
perkjfa10b552016-10-02 23:45:26 -07004351 ASSERT_EQ(1u, stream->GetVideoStreams().size());
4352 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4353 stream->GetVideoStreams()[0].max_bitrate_bps);
4354
4355 send_parameters_.max_bandwidth_bps = 77777;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004356 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
perkjfa10b552016-10-02 23:45:26 -07004357 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4358 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
perkjfa10b552016-10-02 23:45:26 -07004359 stream->GetVideoStreams()[0].max_bitrate_bps);
4360}
4361
Seth Hampsonfeec91e2018-07-13 10:41:10 -07004362// Tests that when the codec specific max bitrate and VideoSendParameters
4363// max_bandwidth_bps are used, that it sets the VideoStream's max bitrate
4364// appropriately.
4365TEST_F(WebRtcVideoChannelTest,
4366 MaxBitratePrioritizesVideoSendParametersOverCodecMaxBitrate) {
4367 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4368 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4369 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4370 send_parameters_.max_bandwidth_bps = -1;
4371 AddSendStream();
4372 ExpectSetMaxBitrate(300000);
4373 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4374
4375 std::vector<FakeVideoSendStream*> video_send_streams = GetFakeSendStreams();
4376 ASSERT_EQ(1u, video_send_streams.size());
4377 FakeVideoSendStream* video_send_stream = video_send_streams[0];
4378 ASSERT_EQ(1u, video_send_streams[0]->GetVideoStreams().size());
4379 // First the max bitrate is set based upon the codec param.
4380 EXPECT_EQ(300000,
4381 video_send_streams[0]->GetVideoStreams()[0].max_bitrate_bps);
4382
4383 // The VideoSendParameters max bitrate overrides the codec's.
4384 send_parameters_.max_bandwidth_bps = 500000;
4385 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
4386 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4387 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4388 EXPECT_EQ(500000, video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4389}
4390
4391// Tests that when the codec specific max bitrate and RtpParameters
4392// max_bitrate_bps are used, that it sets the VideoStream's max bitrate
4393// appropriately.
4394TEST_F(WebRtcVideoChannelTest,
4395 MaxBitratePrioritizesRtpParametersOverCodecMaxBitrate) {
4396 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4397 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4398 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4399 send_parameters_.max_bandwidth_bps = -1;
4400 AddSendStream();
4401 ExpectSetMaxBitrate(300000);
4402 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4403
4404 std::vector<FakeVideoSendStream*> video_send_streams = GetFakeSendStreams();
4405 ASSERT_EQ(1u, video_send_streams.size());
4406 FakeVideoSendStream* video_send_stream = video_send_streams[0];
4407 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4408 // First the max bitrate is set based upon the codec param.
4409 EXPECT_EQ(300000, video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4410
4411 // The RtpParameter max bitrate overrides the codec's.
4412 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
4413 ASSERT_EQ(1u, parameters.encodings.size());
4414 parameters.encodings[0].max_bitrate_bps = 500000;
4415 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4416 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4417 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps,
4418 video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4419}
4420
Åsa Persson55659812018-06-18 17:51:32 +02004421TEST_F(WebRtcVideoChannelTest,
4422 MaxBitrateIsMinimumOfMaxSendBandwidthAndMaxEncodingBitrate) {
4423 send_parameters_.max_bandwidth_bps = 99999;
4424 FakeVideoSendStream* stream = AddSendStream();
4425 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
4426 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4427 ASSERT_EQ(1u, stream->GetVideoStreams().size());
4428 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4429 stream->GetVideoStreams()[0].max_bitrate_bps);
4430
4431 // Get and set the rtp encoding parameters.
4432 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
4433 EXPECT_EQ(1u, parameters.encodings.size());
4434
4435 parameters.encodings[0].max_bitrate_bps = 99999 - 1;
4436 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4437 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps,
4438 stream->GetVideoStreams()[0].max_bitrate_bps);
4439
4440 parameters.encodings[0].max_bitrate_bps = 99999 + 1;
4441 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4442 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4443 stream->GetVideoStreams()[0].max_bitrate_bps);
4444}
4445
eladalonf1841382017-06-12 01:16:46 -07004446TEST_F(WebRtcVideoChannelTest, SetMaxSendBitrateCanIncreaseSenderBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004447 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004448 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004449 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004450 channel_->SetSend(true);
4451
4452 FakeVideoSendStream* stream = AddSendStream();
4453
Niels Möller805a27e2019-01-21 12:21:27 +01004454 webrtc::test::FrameForwarder frame_forwarder;
4455 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Peter Boström3afc8c42016-01-27 16:45:21 +01004456
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004457 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
4458 int initial_max_bitrate_bps = streams[0].max_bitrate_bps;
4459 EXPECT_GT(initial_max_bitrate_bps, 0);
4460
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004461 parameters.max_bandwidth_bps = initial_max_bitrate_bps * 2;
4462 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström3afc8c42016-01-27 16:45:21 +01004463 // Insert a frame to update the encoder config.
Niels Möller805a27e2019-01-21 12:21:27 +01004464 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004465 streams = stream->GetVideoStreams();
4466 EXPECT_EQ(initial_max_bitrate_bps * 2, streams[0].max_bitrate_bps);
Niels Möllerff40b142018-04-09 08:49:14 +02004467 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004468}
4469
eladalonf1841382017-06-12 01:16:46 -07004470TEST_F(WebRtcVideoChannelTest,
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004471 SetMaxSendBitrateCanIncreaseSimulcastSenderBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004472 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004473 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004474 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004475 channel_->SetSend(true);
4476
4477 FakeVideoSendStream* stream = AddSendStream(
4478 cricket::CreateSimStreamParams("cname", MAKE_VECTOR(kSsrcs3)));
4479
4480 // Send a frame to make sure this scales up to >1 stream (simulcast).
Niels Möller805a27e2019-01-21 12:21:27 +01004481 webrtc::test::FrameForwarder frame_forwarder;
4482 EXPECT_TRUE(channel_->SetVideoSend(kSsrcs3[0], nullptr, &frame_forwarder));
4483 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004484
4485 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
4486 ASSERT_GT(streams.size(), 1u)
4487 << "Without simulcast this test doesn't make sense.";
pbosbe16f792015-10-16 12:49:39 -07004488 int initial_max_bitrate_bps = GetTotalMaxBitrateBps(streams);
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004489 EXPECT_GT(initial_max_bitrate_bps, 0);
4490
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004491 parameters.max_bandwidth_bps = initial_max_bitrate_bps * 2;
4492 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström3afc8c42016-01-27 16:45:21 +01004493 // Insert a frame to update the encoder config.
Niels Möller805a27e2019-01-21 12:21:27 +01004494 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004495 streams = stream->GetVideoStreams();
pbosbe16f792015-10-16 12:49:39 -07004496 int increased_max_bitrate_bps = GetTotalMaxBitrateBps(streams);
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004497 EXPECT_EQ(initial_max_bitrate_bps * 2, increased_max_bitrate_bps);
4498
Niels Möllerff40b142018-04-09 08:49:14 +02004499 EXPECT_TRUE(channel_->SetVideoSend(kSsrcs3[0], nullptr, nullptr));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004500}
4501
eladalonf1841382017-06-12 01:16:46 -07004502TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithMaxQuantization) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004503 static const char* kMaxQuantization = "21";
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004504 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004505 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004506 parameters.codecs[0].params[kCodecParamMaxQuantization] = kMaxQuantization;
4507 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Mirko Bonadeif859e552018-05-30 15:31:29 +02004508 EXPECT_EQ(atoi(kMaxQuantization),
pbos@webrtc.org6ae48c62014-06-06 10:49:19 +00004509 AddSendStream()->GetVideoStreams().back().max_qp);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004510
4511 VideoCodec codec;
4512 EXPECT_TRUE(channel_->GetSendCodec(&codec));
4513 EXPECT_EQ(kMaxQuantization, codec.params[kCodecParamMaxQuantization]);
4514}
4515
eladalonf1841382017-06-12 01:16:46 -07004516TEST_F(WebRtcVideoChannelTest, SetSendCodecsRejectBadPayloadTypes) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004517 // TODO(pbos): Should we only allow the dynamic range?
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00004518 static const int kIncorrectPayloads[] = {-2, -1, 128, 129};
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004519 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004520 parameters.codecs.push_back(GetEngineCodec("VP8"));
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00004521 for (size_t i = 0; i < arraysize(kIncorrectPayloads); ++i) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004522 parameters.codecs[0].id = kIncorrectPayloads[i];
4523 EXPECT_FALSE(channel_->SetSendParameters(parameters))
pkasting@chromium.orgd3245462015-02-23 21:28:22 +00004524 << "Bad payload type '" << kIncorrectPayloads[i] << "' accepted.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004525 }
4526}
4527
eladalonf1841382017-06-12 01:16:46 -07004528TEST_F(WebRtcVideoChannelTest, SetSendCodecsAcceptAllValidPayloadTypes) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004529 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004530 parameters.codecs.push_back(GetEngineCodec("VP8"));
magjedf823ede2016-11-12 09:53:04 -08004531 for (int payload_type = 96; payload_type <= 127; ++payload_type) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004532 parameters.codecs[0].id = payload_type;
4533 EXPECT_TRUE(channel_->SetSendParameters(parameters))
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004534 << "Payload type '" << payload_type << "' rejected.";
4535 }
4536}
4537
deadbeef67cf2c12016-04-13 10:07:16 -07004538// Test that setting the a different set of codecs but with an identical front
4539// codec doesn't result in the stream being recreated.
4540// This may happen when a subsequent negotiation includes fewer codecs, as a
4541// result of one of the codecs being rejected.
eladalonf1841382017-06-12 01:16:46 -07004542TEST_F(WebRtcVideoChannelTest,
deadbeef67cf2c12016-04-13 10:07:16 -07004543 SetSendCodecsIdenticalFirstCodecDoesntRecreateStream) {
4544 cricket::VideoSendParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08004545 parameters1.codecs.push_back(GetEngineCodec("VP8"));
4546 parameters1.codecs.push_back(GetEngineCodec("VP9"));
deadbeef67cf2c12016-04-13 10:07:16 -07004547 EXPECT_TRUE(channel_->SetSendParameters(parameters1));
4548
4549 AddSendStream();
4550 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
4551
4552 cricket::VideoSendParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08004553 parameters2.codecs.push_back(GetEngineCodec("VP8"));
deadbeef67cf2c12016-04-13 10:07:16 -07004554 EXPECT_TRUE(channel_->SetSendParameters(parameters2));
4555 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
4556}
4557
eladalonf1841382017-06-12 01:16:46 -07004558TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithOnlyVp8) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004559 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004560 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004561 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004562}
4563
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004564// Test that we set our inbound RTX codecs properly.
eladalonf1841382017-06-12 01:16:46 -07004565TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithRtx) {
magjed509e4fe2016-11-18 01:34:11 -08004566 const int kUnusedPayloadType1 = 126;
4567 const int kUnusedPayloadType2 = 127;
4568 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4569 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4570
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004571 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004572 parameters.codecs.push_back(GetEngineCodec("VP8"));
4573 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004574 parameters.codecs.push_back(rtx_codec);
4575 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004576 << "RTX codec without associated payload should be rejected.";
4577
magjed509e4fe2016-11-18 01:34:11 -08004578 parameters.codecs[1].SetParam("apt", kUnusedPayloadType2);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004579 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004580 << "RTX codec with invalid associated payload type should be rejected.";
4581
magjed509e4fe2016-11-18 01:34:11 -08004582 parameters.codecs[1].SetParam("apt", GetEngineCodec("VP8").id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004583 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004584
magjed509e4fe2016-11-18 01:34:11 -08004585 cricket::VideoCodec rtx_codec2(kUnusedPayloadType2, "rtx");
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004586 rtx_codec2.SetParam("apt", rtx_codec.id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004587 parameters.codecs.push_back(rtx_codec2);
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004588
Yves Gerey665174f2018-06-19 15:03:05 +02004589 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
4590 << "RTX codec with another RTX as associated payload type should be "
4591 "rejected.";
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004592}
4593
Mirta Dvornicic479a3c02019-06-04 15:38:50 +02004594TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithPacketization) {
4595 cricket::VideoCodec vp8_codec = GetEngineCodec("VP8");
4596 vp8_codec.packetization = kPacketizationParamRaw;
4597
4598 cricket::VideoRecvParameters parameters;
4599 parameters.codecs = {vp8_codec, GetEngineCodec("VP9")};
4600 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4601
4602 const cricket::StreamParams params =
4603 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
4604 AddRecvStream(params);
4605 ASSERT_THAT(fake_call_->GetVideoReceiveStreams(), testing::SizeIs(1));
4606
4607 const webrtc::VideoReceiveStream::Config& config =
4608 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
4609 ASSERT_THAT(config.rtp.raw_payload_types, testing::SizeIs(1));
4610 EXPECT_EQ(config.rtp.raw_payload_types.count(vp8_codec.id), 1U);
4611}
4612
4613TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithPacketizationRecreatesStream) {
4614 cricket::VideoRecvParameters parameters;
4615 parameters.codecs = {GetEngineCodec("VP8"), GetEngineCodec("VP9")};
4616 parameters.codecs.back().packetization = kPacketizationParamRaw;
4617 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4618
4619 const cricket::StreamParams params =
4620 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
4621 AddRecvStream(params);
4622 ASSERT_THAT(fake_call_->GetVideoReceiveStreams(), testing::SizeIs(1));
4623 EXPECT_EQ(fake_call_->GetNumCreatedReceiveStreams(), 1);
4624
4625 parameters.codecs.back().packetization.reset();
4626 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4627 EXPECT_EQ(fake_call_->GetNumCreatedReceiveStreams(), 2);
4628}
4629
Steve Anton2d2bbb12019-08-07 09:57:59 -07004630TEST_F(WebRtcVideoChannelTest, DuplicateUlpfecCodecIsDropped) {
4631 constexpr int kFirstUlpfecPayloadType = 126;
4632 constexpr int kSecondUlpfecPayloadType = 127;
4633
4634 cricket::VideoRecvParameters parameters;
4635 parameters.codecs.push_back(GetEngineCodec("VP8"));
4636 parameters.codecs.push_back(
4637 cricket::VideoCodec(kFirstUlpfecPayloadType, cricket::kUlpfecCodecName));
4638 parameters.codecs.push_back(
4639 cricket::VideoCodec(kSecondUlpfecPayloadType, cricket::kUlpfecCodecName));
4640 ASSERT_TRUE(channel_->SetRecvParameters(parameters));
4641
4642 FakeVideoReceiveStream* recv_stream = AddRecvStream();
4643 EXPECT_EQ(kFirstUlpfecPayloadType,
4644 recv_stream->GetConfig().rtp.ulpfec_payload_type);
4645}
4646
4647TEST_F(WebRtcVideoChannelTest, DuplicateRedCodecIsDropped) {
4648 constexpr int kFirstRedPayloadType = 126;
4649 constexpr int kSecondRedPayloadType = 127;
4650
4651 cricket::VideoRecvParameters parameters;
4652 parameters.codecs.push_back(GetEngineCodec("VP8"));
4653 parameters.codecs.push_back(
4654 cricket::VideoCodec(kFirstRedPayloadType, cricket::kRedCodecName));
4655 parameters.codecs.push_back(
4656 cricket::VideoCodec(kSecondRedPayloadType, cricket::kRedCodecName));
4657 ASSERT_TRUE(channel_->SetRecvParameters(parameters));
4658
4659 FakeVideoReceiveStream* recv_stream = AddRecvStream();
4660 EXPECT_EQ(kFirstRedPayloadType,
4661 recv_stream->GetConfig().rtp.red_payload_type);
4662}
4663
eladalonf1841382017-06-12 01:16:46 -07004664TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithChangedRtxPayloadType) {
brandtr14742122017-01-27 04:53:07 -08004665 const int kUnusedPayloadType1 = 126;
4666 const int kUnusedPayloadType2 = 127;
4667 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4668 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4669
4670 // SSRCs for RTX.
4671 cricket::StreamParams params =
4672 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
4673 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
4674 AddRecvStream(params);
4675
4676 // Original payload type for RTX.
4677 cricket::VideoRecvParameters parameters;
4678 parameters.codecs.push_back(GetEngineCodec("VP8"));
4679 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
4680 rtx_codec.SetParam("apt", GetEngineCodec("VP8").id);
4681 parameters.codecs.push_back(rtx_codec);
4682 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4683 ASSERT_EQ(1U, fake_call_->GetVideoReceiveStreams().size());
4684 const webrtc::VideoReceiveStream::Config& config_before =
4685 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
nisse26e3abb2017-08-25 04:44:25 -07004686 EXPECT_EQ(1U, config_before.rtp.rtx_associated_payload_types.size());
4687 const int* payload_type_before = FindKeyByValue(
4688 config_before.rtp.rtx_associated_payload_types, GetEngineCodec("VP8").id);
4689 ASSERT_NE(payload_type_before, nullptr);
4690 EXPECT_EQ(kUnusedPayloadType1, *payload_type_before);
brandtr14742122017-01-27 04:53:07 -08004691 EXPECT_EQ(kRtxSsrcs1[0], config_before.rtp.rtx_ssrc);
4692
4693 // Change payload type for RTX.
4694 parameters.codecs[1].id = kUnusedPayloadType2;
4695 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4696 ASSERT_EQ(1U, fake_call_->GetVideoReceiveStreams().size());
4697 const webrtc::VideoReceiveStream::Config& config_after =
4698 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
nisse26e3abb2017-08-25 04:44:25 -07004699 EXPECT_EQ(1U, config_after.rtp.rtx_associated_payload_types.size());
4700 const int* payload_type_after = FindKeyByValue(
4701 config_after.rtp.rtx_associated_payload_types, GetEngineCodec("VP8").id);
4702 ASSERT_NE(payload_type_after, nullptr);
4703 EXPECT_EQ(kUnusedPayloadType2, *payload_type_after);
brandtr14742122017-01-27 04:53:07 -08004704 EXPECT_EQ(kRtxSsrcs1[0], config_after.rtp.rtx_ssrc);
4705}
4706
eladalonf1841382017-06-12 01:16:46 -07004707TEST_F(WebRtcVideoChannelTest, SetRecvCodecsDifferentPayloadType) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004708 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004709 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004710 parameters.codecs[0].id = 99;
4711 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004712}
4713
eladalonf1841382017-06-12 01:16:46 -07004714TEST_F(WebRtcVideoChannelTest, SetRecvCodecsAcceptDefaultCodecs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004715 cricket::VideoRecvParameters parameters;
4716 parameters.codecs = engine_.codecs();
4717 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgccbed3b2014-07-11 13:02:54 +00004718
4719 FakeVideoReceiveStream* stream = AddRecvStream();
Tommi733b5472016-06-10 17:58:01 +02004720 const webrtc::VideoReceiveStream::Config& config = stream->GetConfig();
Niels Möllercb7e1d22018-09-11 15:56:04 +02004721 EXPECT_EQ(engine_.codecs()[0].name, config.decoders[0].video_format.name);
pbos@webrtc.org776e6f22014-10-29 15:28:39 +00004722 EXPECT_EQ(engine_.codecs()[0].id, config.decoders[0].payload_type);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004723}
4724
eladalonf1841382017-06-12 01:16:46 -07004725TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectUnsupportedCodec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004726 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004727 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkj26752742016-10-24 01:21:16 -07004728 parameters.codecs.push_back(VideoCodec(101, "WTF3"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004729 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004730}
4731
eladalonf1841382017-06-12 01:16:46 -07004732TEST_F(WebRtcVideoChannelTest, SetRecvCodecsAcceptsMultipleVideoCodecs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004733 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004734 parameters.codecs.push_back(GetEngineCodec("VP8"));
4735 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004736 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004737}
4738
eladalonf1841382017-06-12 01:16:46 -07004739TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithoutFecDisablesFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004740 cricket::VideoSendParameters send_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004741 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4742 send_parameters.codecs.push_back(GetEngineCodec("red"));
4743 send_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004744 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004745
4746 FakeVideoReceiveStream* stream = AddRecvStream();
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004747
magjed509e4fe2016-11-18 01:34:11 -08004748 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004749 stream->GetConfig().rtp.ulpfec_payload_type);
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004750
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004751 cricket::VideoRecvParameters recv_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004752 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004753 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00004754 stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004755 ASSERT_TRUE(stream != nullptr);
nisse3b3622f2017-09-26 02:49:21 -07004756 EXPECT_EQ(-1, stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004757 << "SetSendCodec without ULPFEC should disable current ULPFEC.";
4758}
4759
eladalonf1841382017-06-12 01:16:46 -07004760TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetRecvParamsWithoutFecDisablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004761 AddRecvStream(
4762 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08004763 const std::vector<FakeFlexfecReceiveStream*>& streams =
brandtr468da7c2016-11-22 02:16:47 -08004764 fake_call_->GetFlexfecReceiveStreams();
4765
4766 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004767 const FakeFlexfecReceiveStream* stream = streams.front();
4768 EXPECT_EQ(GetEngineCodec("flexfec-03").id, stream->GetConfig().payload_type);
4769 EXPECT_EQ(kFlexfecSsrc, stream->GetConfig().remote_ssrc);
4770 ASSERT_EQ(1U, stream->GetConfig().protected_media_ssrcs.size());
4771 EXPECT_EQ(kSsrcs1[0], stream->GetConfig().protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08004772
4773 cricket::VideoRecvParameters recv_parameters;
4774 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4775 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4776 EXPECT_TRUE(streams.empty())
4777 << "SetSendCodec without FlexFEC should disable current FlexFEC.";
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004778}
4779
eladalonf1841382017-06-12 01:16:46 -07004780TEST_F(WebRtcVideoChannelTest, SetSendParamsWithFecEnablesFec) {
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004781 FakeVideoReceiveStream* stream = AddRecvStream();
magjed509e4fe2016-11-18 01:34:11 -08004782 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004783 stream->GetConfig().rtp.ulpfec_payload_type);
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004784
4785 cricket::VideoRecvParameters recv_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004786 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4787 recv_parameters.codecs.push_back(GetEngineCodec("red"));
4788 recv_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004789 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4790 stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004791 ASSERT_TRUE(stream != nullptr);
magjed509e4fe2016-11-18 01:34:11 -08004792 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004793 stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004794 << "ULPFEC should be enabled on the receive stream.";
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004795
4796 cricket::VideoSendParameters send_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004797 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4798 send_parameters.codecs.push_back(GetEngineCodec("red"));
4799 send_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004800 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
4801 stream = fake_call_->GetVideoReceiveStreams()[0];
magjed509e4fe2016-11-18 01:34:11 -08004802 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004803 stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004804 << "ULPFEC should be enabled on the receive stream.";
4805}
4806
eladalonf1841382017-06-12 01:16:46 -07004807TEST_F(WebRtcVideoChannelFlexfecSendRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004808 SetSendRecvParamsWithFecEnablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004809 AddRecvStream(
4810 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08004811 const std::vector<FakeFlexfecReceiveStream*>& streams =
brandtr468da7c2016-11-22 02:16:47 -08004812 fake_call_->GetFlexfecReceiveStreams();
4813
4814 cricket::VideoRecvParameters recv_parameters;
4815 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4816 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4817 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4818 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004819 const FakeFlexfecReceiveStream* stream_with_recv_params = streams.front();
brandtr468da7c2016-11-22 02:16:47 -08004820 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9c3d4c42017-01-23 06:59:13 -08004821 stream_with_recv_params->GetConfig().payload_type);
4822 EXPECT_EQ(kFlexfecSsrc, stream_with_recv_params->GetConfig().remote_ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004823 EXPECT_EQ(1U,
brandtr9c3d4c42017-01-23 06:59:13 -08004824 stream_with_recv_params->GetConfig().protected_media_ssrcs.size());
brandtr468da7c2016-11-22 02:16:47 -08004825 EXPECT_EQ(kSsrcs1[0],
brandtr9c3d4c42017-01-23 06:59:13 -08004826 stream_with_recv_params->GetConfig().protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08004827
4828 cricket::VideoSendParameters send_parameters;
4829 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4830 send_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4831 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
4832 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004833 const FakeFlexfecReceiveStream* stream_with_send_params = streams.front();
brandtr468da7c2016-11-22 02:16:47 -08004834 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9c3d4c42017-01-23 06:59:13 -08004835 stream_with_send_params->GetConfig().payload_type);
4836 EXPECT_EQ(kFlexfecSsrc, stream_with_send_params->GetConfig().remote_ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004837 EXPECT_EQ(1U,
brandtr9c3d4c42017-01-23 06:59:13 -08004838 stream_with_send_params->GetConfig().protected_media_ssrcs.size());
brandtr468da7c2016-11-22 02:16:47 -08004839 EXPECT_EQ(kSsrcs1[0],
brandtr9c3d4c42017-01-23 06:59:13 -08004840 stream_with_send_params->GetConfig().protected_media_ssrcs[0]);
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004841}
4842
eladalonf1841382017-06-12 01:16:46 -07004843TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectDuplicateFecPayloads) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004844 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004845 parameters.codecs.push_back(GetEngineCodec("VP8"));
4846 parameters.codecs.push_back(GetEngineCodec("red"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004847 parameters.codecs[1].id = parameters.codecs[0].id;
4848 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004849}
4850
eladalonf1841382017-06-12 01:16:46 -07004851TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004852 SetRecvCodecsRejectDuplicateFecPayloads) {
brandtr468da7c2016-11-22 02:16:47 -08004853 cricket::VideoRecvParameters parameters;
4854 parameters.codecs.push_back(GetEngineCodec("VP8"));
4855 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4856 parameters.codecs[1].id = parameters.codecs[0].id;
4857 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
4858}
4859
eladalonf1841382017-06-12 01:16:46 -07004860TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectDuplicateCodecPayloads) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004861 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004862 parameters.codecs.push_back(GetEngineCodec("VP8"));
4863 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004864 parameters.codecs[1].id = parameters.codecs[0].id;
4865 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004866}
4867
eladalonf1841382017-06-12 01:16:46 -07004868TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004869 SetRecvCodecsAcceptSameCodecOnMultiplePayloadTypes) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004870 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004871 parameters.codecs.push_back(GetEngineCodec("VP8"));
4872 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004873 parameters.codecs[1].id += 1;
4874 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004875}
4876
deadbeef67cf2c12016-04-13 10:07:16 -07004877// Test that setting the same codecs but with a different order
deadbeef874ca3a2015-08-20 17:19:20 -07004878// doesn't result in the stream being recreated.
eladalonf1841382017-06-12 01:16:46 -07004879TEST_F(WebRtcVideoChannelTest,
deadbeef67cf2c12016-04-13 10:07:16 -07004880 SetRecvCodecsDifferentOrderDoesntRecreateStream) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004881 cricket::VideoRecvParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08004882 parameters1.codecs.push_back(GetEngineCodec("VP8"));
4883 parameters1.codecs.push_back(GetEngineCodec("red"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004884 EXPECT_TRUE(channel_->SetRecvParameters(parameters1));
deadbeef874ca3a2015-08-20 17:19:20 -07004885
4886 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
4887 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
4888
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004889 cricket::VideoRecvParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08004890 parameters2.codecs.push_back(GetEngineCodec("red"));
4891 parameters2.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004892 EXPECT_TRUE(channel_->SetRecvParameters(parameters2));
deadbeef874ca3a2015-08-20 17:19:20 -07004893 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
4894}
4895
eladalonf1841382017-06-12 01:16:46 -07004896TEST_F(WebRtcVideoChannelTest, SendStreamNotSendingByDefault) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004897 EXPECT_FALSE(AddSendStream()->IsSending());
4898}
4899
eladalonf1841382017-06-12 01:16:46 -07004900TEST_F(WebRtcVideoChannelTest, ReceiveStreamReceivingByDefault) {
pbos@webrtc.org85f42942014-07-22 09:14:58 +00004901 EXPECT_TRUE(AddRecvStream()->IsReceiving());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004902}
4903
eladalonf1841382017-06-12 01:16:46 -07004904TEST_F(WebRtcVideoChannelTest, SetSend) {
pbos@webrtc.org5301b0f2014-07-17 08:51:46 +00004905 FakeVideoSendStream* stream = AddSendStream();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004906 EXPECT_FALSE(stream->IsSending());
4907
4908 // false->true
4909 EXPECT_TRUE(channel_->SetSend(true));
4910 EXPECT_TRUE(stream->IsSending());
4911 // true->true
4912 EXPECT_TRUE(channel_->SetSend(true));
4913 EXPECT_TRUE(stream->IsSending());
4914 // true->false
4915 EXPECT_TRUE(channel_->SetSend(false));
4916 EXPECT_FALSE(stream->IsSending());
4917 // false->false
4918 EXPECT_TRUE(channel_->SetSend(false));
4919 EXPECT_FALSE(stream->IsSending());
4920
4921 EXPECT_TRUE(channel_->SetSend(true));
4922 FakeVideoSendStream* new_stream = AddSendStream();
4923 EXPECT_TRUE(new_stream->IsSending())
4924 << "Send stream created after SetSend(true) not sending initially.";
4925}
4926
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004927// This test verifies DSCP settings are properly applied on video media channel.
eladalonf1841382017-06-12 01:16:46 -07004928TEST_F(WebRtcVideoChannelTest, TestSetDscpOptions) {
kwiberg686a8ef2016-02-26 03:00:35 -08004929 std::unique_ptr<cricket::FakeNetworkInterface> network_interface(
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004930 new cricket::FakeNetworkInterface);
nisse51542be2016-02-12 02:27:06 -08004931 MediaConfig config;
Tim Haloun6ca98362018-09-17 17:06:08 -07004932 std::unique_ptr<cricket::WebRtcVideoChannel> channel;
Tim Haloun648d28a2018-10-18 16:52:22 -07004933 webrtc::RtpParameters parameters;
nisse51542be2016-02-12 02:27:06 -08004934
Sebastian Jansson84848f22018-11-16 10:40:36 +01004935 channel.reset(
4936 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02004937 call_.get(), config, VideoOptions(), webrtc::CryptoOptions(),
4938 video_bitrate_allocator_factory_.get())));
Anton Sukhanov4f08faa2019-05-21 11:12:57 -07004939 channel->SetInterface(network_interface.get(),
4940 webrtc::MediaTransportConfig());
nisse51542be2016-02-12 02:27:06 -08004941 // Default value when DSCP is disabled should be DSCP_DEFAULT.
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004942 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
nisse51542be2016-02-12 02:27:06 -08004943
Tim Haloun648d28a2018-10-18 16:52:22 -07004944 // Default value when DSCP is enabled is also DSCP_DEFAULT, until it is set
4945 // through rtp parameters.
nisse51542be2016-02-12 02:27:06 -08004946 config.enable_dscp = true;
Sebastian Jansson84848f22018-11-16 10:40:36 +01004947 channel.reset(
4948 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02004949 call_.get(), config, VideoOptions(), webrtc::CryptoOptions(),
4950 video_bitrate_allocator_factory_.get())));
Anton Sukhanov4f08faa2019-05-21 11:12:57 -07004951 channel->SetInterface(network_interface.get(),
4952 webrtc::MediaTransportConfig());
Tim Haloun648d28a2018-10-18 16:52:22 -07004953 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
4954
4955 // Create a send stream to configure
4956 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
4957 parameters = channel->GetRtpSendParameters(kSsrc);
4958 ASSERT_FALSE(parameters.encodings.empty());
4959
4960 // Various priorities map to various dscp values.
4961 parameters.encodings[0].network_priority = 4.0;
4962 ASSERT_TRUE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
nisse51542be2016-02-12 02:27:06 -08004963 EXPECT_EQ(rtc::DSCP_AF41, network_interface->dscp());
Tim Haloun648d28a2018-10-18 16:52:22 -07004964 parameters.encodings[0].network_priority = 0.5;
4965 ASSERT_TRUE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
4966 EXPECT_EQ(rtc::DSCP_CS1, network_interface->dscp());
4967
4968 // A bad priority does not change the dscp value.
4969 parameters.encodings[0].network_priority = 0.0;
4970 ASSERT_FALSE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
4971 EXPECT_EQ(rtc::DSCP_CS1, network_interface->dscp());
nisse51542be2016-02-12 02:27:06 -08004972
Tim Haloun6ca98362018-09-17 17:06:08 -07004973 // Packets should also self-identify their dscp in PacketOptions.
4974 const uint8_t kData[10] = {0};
4975 EXPECT_TRUE(static_cast<webrtc::Transport*>(channel.get())
4976 ->SendRtcp(kData, sizeof(kData)));
Tim Haloun648d28a2018-10-18 16:52:22 -07004977 EXPECT_EQ(rtc::DSCP_CS1, network_interface->options().dscp);
Tim Haloun6ca98362018-09-17 17:06:08 -07004978
nisse51542be2016-02-12 02:27:06 -08004979 // Verify that setting the option to false resets the
4980 // DiffServCodePoint.
4981 config.enable_dscp = false;
Sebastian Jansson84848f22018-11-16 10:40:36 +01004982 channel.reset(
4983 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02004984 call_.get(), config, VideoOptions(), webrtc::CryptoOptions(),
4985 video_bitrate_allocator_factory_.get())));
Anton Sukhanov4f08faa2019-05-21 11:12:57 -07004986 channel->SetInterface(network_interface.get(),
4987 webrtc::MediaTransportConfig());
nisse51542be2016-02-12 02:27:06 -08004988 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004989}
4990
deadbeef13871492015-12-09 12:37:51 -08004991// This test verifies that the RTCP reduced size mode is properly applied to
4992// send video streams.
eladalonf1841382017-06-12 01:16:46 -07004993TEST_F(WebRtcVideoChannelTest, TestSetSendRtcpReducedSize) {
deadbeef13871492015-12-09 12:37:51 -08004994 // Create stream, expecting that default mode is "compound".
4995 FakeVideoSendStream* stream1 = AddSendStream();
4996 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream1->GetConfig().rtp.rtcp_mode);
Florent Castellidacec712018-05-24 16:24:21 +02004997 webrtc::RtpParameters rtp_parameters =
4998 channel_->GetRtpSendParameters(last_ssrc_);
4999 EXPECT_FALSE(rtp_parameters.rtcp.reduced_size);
deadbeef13871492015-12-09 12:37:51 -08005000
5001 // Now enable reduced size mode.
5002 send_parameters_.rtcp.reduced_size = true;
5003 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
5004 stream1 = fake_call_->GetVideoSendStreams()[0];
5005 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream1->GetConfig().rtp.rtcp_mode);
Florent Castellidacec712018-05-24 16:24:21 +02005006 rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
5007 EXPECT_TRUE(rtp_parameters.rtcp.reduced_size);
deadbeef13871492015-12-09 12:37:51 -08005008
5009 // Create a new stream and ensure it picks up the reduced size mode.
5010 FakeVideoSendStream* stream2 = AddSendStream();
5011 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream2->GetConfig().rtp.rtcp_mode);
5012}
5013
5014// This test verifies that the RTCP reduced size mode is properly applied to
5015// receive video streams.
eladalonf1841382017-06-12 01:16:46 -07005016TEST_F(WebRtcVideoChannelTest, TestSetRecvRtcpReducedSize) {
deadbeef13871492015-12-09 12:37:51 -08005017 // Create stream, expecting that default mode is "compound".
5018 FakeVideoReceiveStream* stream1 = AddRecvStream();
5019 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream1->GetConfig().rtp.rtcp_mode);
5020
5021 // Now enable reduced size mode.
Taylor Brandstetter5f0b83b2016-03-18 15:02:07 -07005022 // TODO(deadbeef): Once "recv_parameters" becomes "receiver_parameters",
5023 // the reduced_size flag should come from that.
5024 send_parameters_.rtcp.reduced_size = true;
5025 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
deadbeef13871492015-12-09 12:37:51 -08005026 stream1 = fake_call_->GetVideoReceiveStreams()[0];
5027 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream1->GetConfig().rtp.rtcp_mode);
5028
5029 // Create a new stream and ensure it picks up the reduced size mode.
5030 FakeVideoReceiveStream* stream2 = AddRecvStream();
5031 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream2->GetConfig().rtp.rtcp_mode);
5032}
5033
eladalonf1841382017-06-12 01:16:46 -07005034TEST_F(WebRtcVideoChannelTest, OnReadyToSendSignalsNetworkState) {
skvlad7a43d252016-03-22 15:32:27 -07005035 EXPECT_EQ(webrtc::kNetworkUp,
5036 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
5037 EXPECT_EQ(webrtc::kNetworkUp,
5038 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.org26c0c412014-09-03 16:17:12 +00005039
5040 channel_->OnReadyToSend(false);
skvlad7a43d252016-03-22 15:32:27 -07005041 EXPECT_EQ(webrtc::kNetworkDown,
5042 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
5043 EXPECT_EQ(webrtc::kNetworkUp,
5044 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.org26c0c412014-09-03 16:17:12 +00005045
5046 channel_->OnReadyToSend(true);
skvlad7a43d252016-03-22 15:32:27 -07005047 EXPECT_EQ(webrtc::kNetworkUp,
5048 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
5049 EXPECT_EQ(webrtc::kNetworkUp,
5050 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00005051}
5052
eladalonf1841382017-06-12 01:16:46 -07005053TEST_F(WebRtcVideoChannelTest, GetStatsReportsSentCodecName) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005054 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08005055 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005056 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström74d9ed72015-03-26 16:28:31 +01005057
5058 AddSendStream();
5059
5060 cricket::VideoMediaInfo info;
5061 ASSERT_TRUE(channel_->GetStats(&info));
magjed509e4fe2016-11-18 01:34:11 -08005062 EXPECT_EQ("VP8", info.senders[0].codec_name);
Peter Boström74d9ed72015-03-26 16:28:31 +01005063}
5064
eladalonf1841382017-06-12 01:16:46 -07005065TEST_F(WebRtcVideoChannelTest, GetStatsReportsEncoderImplementationName) {
Peter Boströmb7d9a972015-12-18 16:01:11 +01005066 FakeVideoSendStream* stream = AddSendStream();
5067 webrtc::VideoSendStream::Stats stats;
5068 stats.encoder_implementation_name = "encoder_implementation_name";
5069 stream->SetStats(stats);
5070
5071 cricket::VideoMediaInfo info;
5072 ASSERT_TRUE(channel_->GetStats(&info));
5073 EXPECT_EQ(stats.encoder_implementation_name,
5074 info.senders[0].encoder_implementation_name);
5075}
5076
eladalonf1841382017-06-12 01:16:46 -07005077TEST_F(WebRtcVideoChannelTest, GetStatsReportsCpuOveruseMetrics) {
pbos@webrtc.org3e6e2712015-02-26 12:19:31 +00005078 FakeVideoSendStream* stream = AddSendStream();
5079 webrtc::VideoSendStream::Stats stats;
5080 stats.avg_encode_time_ms = 13;
5081 stats.encode_usage_percent = 42;
5082 stream->SetStats(stats);
5083
5084 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005085 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org3e6e2712015-02-26 12:19:31 +00005086 EXPECT_EQ(stats.avg_encode_time_ms, info.senders[0].avg_encode_ms);
5087 EXPECT_EQ(stats.encode_usage_percent, info.senders[0].encode_usage_percent);
5088}
5089
eladalonf1841382017-06-12 01:16:46 -07005090TEST_F(WebRtcVideoChannelTest, GetStatsReportsFramesEncoded) {
sakal43536c32016-10-24 01:46:43 -07005091 FakeVideoSendStream* stream = AddSendStream();
5092 webrtc::VideoSendStream::Stats stats;
5093 stats.frames_encoded = 13;
5094 stream->SetStats(stats);
5095
5096 cricket::VideoMediaInfo info;
5097 ASSERT_TRUE(channel_->GetStats(&info));
5098 EXPECT_EQ(stats.frames_encoded, info.senders[0].frames_encoded);
5099}
5100
Rasmus Brandt2efae772019-06-27 14:29:34 +02005101TEST_F(WebRtcVideoChannelTest, GetStatsReportsKeyFramesEncoded) {
5102 FakeVideoSendStream* stream = AddSendStream();
5103 webrtc::VideoSendStream::Stats stats;
5104 stats.substreams[123].frame_counts.key_frames = 10;
5105 stats.substreams[456].frame_counts.key_frames = 87;
5106 stream->SetStats(stats);
5107
5108 cricket::VideoMediaInfo info;
5109 ASSERT_TRUE(channel_->GetStats(&info));
5110 // TODO(bugs.webrtc.org/9547): Populate individual outbound-rtp stats objects
5111 // for each simulcast stream, instead of accumulating all keyframes encoded
5112 // over all simulcast streams in the same outbound-rtp stats object.
5113 EXPECT_EQ(97u, info.senders[0].key_frames_encoded);
5114}
5115
eladalonf1841382017-06-12 01:16:46 -07005116TEST_F(WebRtcVideoChannelTest, GetStatsReportsQpSum) {
sakal87da4042016-10-31 06:53:47 -07005117 FakeVideoSendStream* stream = AddSendStream();
5118 webrtc::VideoSendStream::Stats stats;
Oskar Sundbom78807582017-11-16 11:09:55 +01005119 stats.qp_sum = 13;
sakal87da4042016-10-31 06:53:47 -07005120 stream->SetStats(stats);
5121
5122 cricket::VideoMediaInfo info;
5123 ASSERT_TRUE(channel_->GetStats(&info));
5124 EXPECT_EQ(stats.qp_sum, info.senders[0].qp_sum);
5125}
5126
eladalonf1841382017-06-12 01:16:46 -07005127TEST_F(WebRtcVideoChannelTest, GetStatsReportsUpperResolution) {
pbos@webrtc.org273a4142014-12-01 15:23:21 +00005128 FakeVideoSendStream* stream = AddSendStream();
5129 webrtc::VideoSendStream::Stats stats;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005130 stats.substreams[17].width = 123;
5131 stats.substreams[17].height = 40;
5132 stats.substreams[42].width = 80;
5133 stats.substreams[42].height = 31;
5134 stats.substreams[11].width = 20;
5135 stats.substreams[11].height = 90;
pbos@webrtc.org273a4142014-12-01 15:23:21 +00005136 stream->SetStats(stats);
5137
5138 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005139 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org273a4142014-12-01 15:23:21 +00005140 ASSERT_EQ(1u, info.senders.size());
5141 EXPECT_EQ(123, info.senders[0].send_frame_width);
5142 EXPECT_EQ(90, info.senders[0].send_frame_height);
5143}
5144
eladalonf1841382017-06-12 01:16:46 -07005145TEST_F(WebRtcVideoChannelTest, GetStatsReportsCpuAdaptationStats) {
perkj803d97f2016-11-01 11:45:46 -07005146 FakeVideoSendStream* stream = AddSendStream();
5147 webrtc::VideoSendStream::Stats stats;
5148 stats.number_of_cpu_adapt_changes = 2;
5149 stats.cpu_limited_resolution = true;
5150 stream->SetStats(stats);
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00005151
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00005152 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005153 EXPECT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00005154 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07005155 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_CPU, info.senders[0].adapt_reason);
perkj803d97f2016-11-01 11:45:46 -07005156 EXPECT_EQ(stats.number_of_cpu_adapt_changes, info.senders[0].adapt_changes);
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00005157}
5158
eladalonf1841382017-06-12 01:16:46 -07005159TEST_F(WebRtcVideoChannelTest, GetStatsReportsAdaptationAndBandwidthStats) {
perkj803d97f2016-11-01 11:45:46 -07005160 FakeVideoSendStream* stream = AddSendStream();
asapersson17821db2015-12-14 02:08:12 -08005161 webrtc::VideoSendStream::Stats stats;
perkj803d97f2016-11-01 11:45:46 -07005162 stats.number_of_cpu_adapt_changes = 2;
5163 stats.cpu_limited_resolution = true;
asapersson17821db2015-12-14 02:08:12 -08005164 stats.bw_limited_resolution = true;
perkj803d97f2016-11-01 11:45:46 -07005165 stream->SetStats(stats);
5166
5167 cricket::VideoMediaInfo info;
asapersson17821db2015-12-14 02:08:12 -08005168 EXPECT_TRUE(channel_->GetStats(&info));
5169 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07005170 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_CPU |
5171 WebRtcVideoChannel::ADAPTREASON_BANDWIDTH,
asapersson17821db2015-12-14 02:08:12 -08005172 info.senders[0].adapt_reason);
perkj803d97f2016-11-01 11:45:46 -07005173 EXPECT_EQ(stats.number_of_cpu_adapt_changes, info.senders[0].adapt_changes);
asapersson17821db2015-12-14 02:08:12 -08005174}
5175
eladalonf1841382017-06-12 01:16:46 -07005176TEST_F(WebRtcVideoChannelTest,
asapersson17821db2015-12-14 02:08:12 -08005177 GetStatsTranslatesBandwidthLimitedResolutionCorrectly) {
5178 FakeVideoSendStream* stream = AddSendStream();
5179 webrtc::VideoSendStream::Stats stats;
5180 stats.bw_limited_resolution = true;
5181 stream->SetStats(stats);
5182
5183 cricket::VideoMediaInfo info;
5184 EXPECT_TRUE(channel_->GetStats(&info));
5185 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07005186 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_BANDWIDTH,
asapersson17821db2015-12-14 02:08:12 -08005187 info.senders[0].adapt_reason);
5188}
5189
Yves Gerey665174f2018-06-19 15:03:05 +02005190TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesSendRtcpPacketTypesCorrectly) {
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00005191 FakeVideoSendStream* stream = AddSendStream();
5192 webrtc::VideoSendStream::Stats stats;
5193 stats.substreams[17].rtcp_packet_type_counts.fir_packets = 2;
5194 stats.substreams[17].rtcp_packet_type_counts.nack_packets = 3;
5195 stats.substreams[17].rtcp_packet_type_counts.pli_packets = 4;
5196
5197 stats.substreams[42].rtcp_packet_type_counts.fir_packets = 5;
5198 stats.substreams[42].rtcp_packet_type_counts.nack_packets = 7;
5199 stats.substreams[42].rtcp_packet_type_counts.pli_packets = 9;
5200
5201 stream->SetStats(stats);
5202
5203 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005204 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00005205 EXPECT_EQ(7, info.senders[0].firs_rcvd);
5206 EXPECT_EQ(10, info.senders[0].nacks_rcvd);
5207 EXPECT_EQ(13, info.senders[0].plis_rcvd);
5208}
5209
eladalonf1841382017-06-12 01:16:46 -07005210TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00005211 GetStatsTranslatesReceiveRtcpPacketTypesCorrectly) {
5212 FakeVideoReceiveStream* stream = AddRecvStream();
5213 webrtc::VideoReceiveStream::Stats stats;
5214 stats.rtcp_packet_type_counts.fir_packets = 2;
5215 stats.rtcp_packet_type_counts.nack_packets = 3;
5216 stats.rtcp_packet_type_counts.pli_packets = 4;
5217 stream->SetStats(stats);
5218
5219 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005220 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00005221 EXPECT_EQ(stats.rtcp_packet_type_counts.fir_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02005222 rtc::checked_cast<unsigned int>(info.receivers[0].firs_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00005223 EXPECT_EQ(stats.rtcp_packet_type_counts.nack_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02005224 rtc::checked_cast<unsigned int>(info.receivers[0].nacks_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00005225 EXPECT_EQ(stats.rtcp_packet_type_counts.pli_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02005226 rtc::checked_cast<unsigned int>(info.receivers[0].plis_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00005227}
5228
eladalonf1841382017-06-12 01:16:46 -07005229TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesDecodeStatsCorrectly) {
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005230 FakeVideoReceiveStream* stream = AddRecvStream();
5231 webrtc::VideoReceiveStream::Stats stats;
Peter Boströmb7d9a972015-12-18 16:01:11 +01005232 stats.decoder_implementation_name = "decoder_implementation_name";
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005233 stats.decode_ms = 2;
5234 stats.max_decode_ms = 3;
5235 stats.current_delay_ms = 4;
5236 stats.target_delay_ms = 5;
5237 stats.jitter_buffer_ms = 6;
Guido Urdaneta67378412019-05-28 17:38:08 +02005238 stats.jitter_buffer_delay_seconds = 60;
5239 stats.jitter_buffer_emitted_count = 6;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005240 stats.min_playout_delay_ms = 7;
5241 stats.render_delay_ms = 8;
asapersson26dd92b2016-08-30 00:45:45 -07005242 stats.width = 9;
5243 stats.height = 10;
hbos42f6d2f2017-01-20 03:56:50 -08005244 stats.frame_counts.key_frames = 11;
5245 stats.frame_counts.delta_frames = 12;
hbos50cfe1f2017-01-23 07:21:55 -08005246 stats.frames_rendered = 13;
5247 stats.frames_decoded = 14;
Oskar Sundbom78807582017-11-16 11:09:55 +01005248 stats.qp_sum = 15;
Johannes Kronbfd343b2019-07-01 10:07:50 +02005249 stats.total_decode_time_ms = 16;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005250 stream->SetStats(stats);
5251
5252 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005253 ASSERT_TRUE(channel_->GetStats(&info));
Peter Boströmb7d9a972015-12-18 16:01:11 +01005254 EXPECT_EQ(stats.decoder_implementation_name,
5255 info.receivers[0].decoder_implementation_name);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005256 EXPECT_EQ(stats.decode_ms, info.receivers[0].decode_ms);
5257 EXPECT_EQ(stats.max_decode_ms, info.receivers[0].max_decode_ms);
5258 EXPECT_EQ(stats.current_delay_ms, info.receivers[0].current_delay_ms);
5259 EXPECT_EQ(stats.target_delay_ms, info.receivers[0].target_delay_ms);
5260 EXPECT_EQ(stats.jitter_buffer_ms, info.receivers[0].jitter_buffer_ms);
Guido Urdaneta67378412019-05-28 17:38:08 +02005261 EXPECT_EQ(stats.jitter_buffer_delay_seconds,
5262 info.receivers[0].jitter_buffer_delay_seconds);
5263 EXPECT_EQ(stats.jitter_buffer_emitted_count,
5264 info.receivers[0].jitter_buffer_emitted_count);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005265 EXPECT_EQ(stats.min_playout_delay_ms, info.receivers[0].min_playout_delay_ms);
5266 EXPECT_EQ(stats.render_delay_ms, info.receivers[0].render_delay_ms);
asapersson26dd92b2016-08-30 00:45:45 -07005267 EXPECT_EQ(stats.width, info.receivers[0].frame_width);
5268 EXPECT_EQ(stats.height, info.receivers[0].frame_height);
Mirko Bonadeif859e552018-05-30 15:31:29 +02005269 EXPECT_EQ(rtc::checked_cast<unsigned int>(stats.frame_counts.key_frames +
5270 stats.frame_counts.delta_frames),
hbos42f6d2f2017-01-20 03:56:50 -08005271 info.receivers[0].frames_received);
hbos50cfe1f2017-01-23 07:21:55 -08005272 EXPECT_EQ(stats.frames_rendered, info.receivers[0].frames_rendered);
sakale5ba44e2016-10-26 07:09:24 -07005273 EXPECT_EQ(stats.frames_decoded, info.receivers[0].frames_decoded);
Rasmus Brandt2efae772019-06-27 14:29:34 +02005274 EXPECT_EQ(rtc::checked_cast<unsigned int>(stats.frame_counts.key_frames),
5275 info.receivers[0].key_frames_decoded);
sakalcc452e12017-02-09 04:53:45 -08005276 EXPECT_EQ(stats.qp_sum, info.receivers[0].qp_sum);
Johannes Kronbfd343b2019-07-01 10:07:50 +02005277 EXPECT_EQ(stats.total_decode_time_ms, info.receivers[0].total_decode_time_ms);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005278}
5279
eladalonf1841382017-06-12 01:16:46 -07005280TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesReceivePacketStatsCorrectly) {
Peter Boström393347f2015-04-22 14:52:45 +02005281 FakeVideoReceiveStream* stream = AddRecvStream();
5282 webrtc::VideoReceiveStream::Stats stats;
Niels Möllerd77cc242019-08-22 09:40:25 +02005283 stats.rtp_stats.packet_counter.payload_bytes = 2;
5284 stats.rtp_stats.packet_counter.header_bytes = 3;
5285 stats.rtp_stats.packet_counter.padding_bytes = 4;
5286 stats.rtp_stats.packet_counter.packets = 5;
5287 stats.rtp_stats.packets_lost = 6;
Peter Boström393347f2015-04-22 14:52:45 +02005288 stream->SetStats(stats);
5289
5290 cricket::VideoMediaInfo info;
5291 ASSERT_TRUE(channel_->GetStats(&info));
Niels Möllerd77cc242019-08-22 09:40:25 +02005292 EXPECT_EQ(stats.rtp_stats.packet_counter.payload_bytes,
Niels Möllerac0a4cb2019-10-09 15:01:33 +02005293 rtc::checked_cast<size_t>(info.receivers[0].payload_bytes_rcvd));
Niels Möllerd77cc242019-08-22 09:40:25 +02005294 EXPECT_EQ(stats.rtp_stats.packet_counter.packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02005295 rtc::checked_cast<unsigned int>(info.receivers[0].packets_rcvd));
Niels Möllerd77cc242019-08-22 09:40:25 +02005296 EXPECT_EQ(stats.rtp_stats.packets_lost, info.receivers[0].packets_lost);
Peter Boström393347f2015-04-22 14:52:45 +02005297}
5298
eladalonf1841382017-06-12 01:16:46 -07005299TEST_F(WebRtcVideoChannelTest, TranslatesCallStatsCorrectly) {
pbos@webrtc.org2b19f062014-12-11 13:26:09 +00005300 AddSendStream();
5301 AddSendStream();
5302 webrtc::Call::Stats stats;
5303 stats.rtt_ms = 123;
5304 fake_call_->SetStats(stats);
5305
5306 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005307 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org2b19f062014-12-11 13:26:09 +00005308 ASSERT_EQ(2u, info.senders.size());
5309 EXPECT_EQ(stats.rtt_ms, info.senders[0].rtt_ms);
5310 EXPECT_EQ(stats.rtt_ms, info.senders[1].rtt_ms);
5311}
5312
eladalonf1841382017-06-12 01:16:46 -07005313TEST_F(WebRtcVideoChannelTest, TranslatesSenderBitrateStatsCorrectly) {
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005314 FakeVideoSendStream* stream = AddSendStream();
5315 webrtc::VideoSendStream::Stats stats;
pbos@webrtc.org891d4832015-02-26 13:15:22 +00005316 stats.target_media_bitrate_bps = 156;
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005317 stats.media_bitrate_bps = 123;
5318 stats.substreams[17].total_bitrate_bps = 1;
5319 stats.substreams[17].retransmit_bitrate_bps = 2;
5320 stats.substreams[42].total_bitrate_bps = 3;
5321 stats.substreams[42].retransmit_bitrate_bps = 4;
5322 stream->SetStats(stats);
5323
5324 FakeVideoSendStream* stream2 = AddSendStream();
5325 webrtc::VideoSendStream::Stats stats2;
pbos@webrtc.org891d4832015-02-26 13:15:22 +00005326 stats2.target_media_bitrate_bps = 200;
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005327 stats2.media_bitrate_bps = 321;
5328 stats2.substreams[13].total_bitrate_bps = 5;
5329 stats2.substreams[13].retransmit_bitrate_bps = 6;
5330 stats2.substreams[21].total_bitrate_bps = 7;
5331 stats2.substreams[21].retransmit_bitrate_bps = 8;
5332 stream2->SetStats(stats2);
5333
5334 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005335 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005336 ASSERT_EQ(2u, info.senders.size());
stefanf79ade12017-06-02 06:44:03 -07005337 BandwidthEstimationInfo bwe_info;
5338 channel_->FillBitrateInfo(&bwe_info);
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005339 // Assuming stream and stream2 corresponds to senders[0] and [1] respectively
5340 // is OK as std::maps are sorted and AddSendStream() gives increasing SSRCs.
5341 EXPECT_EQ(stats.media_bitrate_bps, info.senders[0].nominal_bitrate);
5342 EXPECT_EQ(stats2.media_bitrate_bps, info.senders[1].nominal_bitrate);
pbos@webrtc.org891d4832015-02-26 13:15:22 +00005343 EXPECT_EQ(stats.target_media_bitrate_bps + stats2.target_media_bitrate_bps,
stefanf79ade12017-06-02 06:44:03 -07005344 bwe_info.target_enc_bitrate);
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005345 EXPECT_EQ(stats.media_bitrate_bps + stats2.media_bitrate_bps,
stefanf79ade12017-06-02 06:44:03 -07005346 bwe_info.actual_enc_bitrate);
5347 EXPECT_EQ(1 + 3 + 5 + 7, bwe_info.transmit_bitrate)
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005348 << "Bandwidth stats should take all streams into account.";
stefanf79ade12017-06-02 06:44:03 -07005349 EXPECT_EQ(2 + 4 + 6 + 8, bwe_info.retransmit_bitrate)
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005350 << "Bandwidth stats should take all streams into account.";
5351}
5352
eladalonf1841382017-06-12 01:16:46 -07005353TEST_F(WebRtcVideoChannelTest, DefaultReceiveStreamReconfiguresToUseRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005354 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005355
Peter Boström0c4e06b2015-10-07 12:23:21 +02005356 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
5357 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005358
5359 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5360 const size_t kDataLength = 12;
5361 uint8_t data[kDataLength];
5362 memset(data, 0, sizeof(data));
5363 rtc::SetBE32(&data[8], ssrcs[0]);
jbaucheec21bd2016-03-20 06:15:43 -07005364 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005365 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005366
5367 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
5368 << "No default receive stream created.";
5369 FakeVideoReceiveStream* recv_stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr14742122017-01-27 04:53:07 -08005370 EXPECT_EQ(0u, recv_stream->GetConfig().rtp.rtx_ssrc)
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005371 << "Default receive stream should not have configured RTX";
5372
5373 EXPECT_TRUE(channel_->AddRecvStream(
5374 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs)));
5375 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
brandtr14742122017-01-27 04:53:07 -08005376 << "AddRecvStream should have reconfigured, not added a new receiver.";
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005377 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
nisse26e3abb2017-08-25 04:44:25 -07005378 EXPECT_FALSE(
5379 recv_stream->GetConfig().rtp.rtx_associated_payload_types.empty());
nisseca5706d2017-09-11 02:32:16 -07005380 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
Peter Boströmd8b01092016-05-12 16:44:36 +02005381 << "RTX should be mapped for all decoders/payload types.";
nisseca5706d2017-09-11 02:32:16 -07005382 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02005383 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07005384 << "RTX should be mapped also for the RED payload type";
brandtr14742122017-01-27 04:53:07 -08005385 EXPECT_EQ(rtx_ssrcs[0], recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005386}
5387
eladalonf1841382017-06-12 01:16:46 -07005388TEST_F(WebRtcVideoChannelTest, RejectsAddingStreamsWithMissingSsrcsForRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005389 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd4362cd2015-03-25 14:17:23 +01005390
Peter Boström0c4e06b2015-10-07 12:23:21 +02005391 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
5392 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
Peter Boströmd4362cd2015-03-25 14:17:23 +01005393
5394 StreamParams sp =
5395 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs);
5396 sp.ssrcs = ssrcs; // Without RTXs, this is the important part.
5397
5398 EXPECT_FALSE(channel_->AddSendStream(sp));
5399 EXPECT_FALSE(channel_->AddRecvStream(sp));
5400}
5401
eladalonf1841382017-06-12 01:16:46 -07005402TEST_F(WebRtcVideoChannelTest, RejectsAddingStreamsWithOverlappingRtxSsrcs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005403 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005404
Peter Boström0c4e06b2015-10-07 12:23:21 +02005405 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
5406 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
Peter Boströmd6f4c252015-03-26 16:23:04 +01005407
5408 StreamParams sp =
5409 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs);
5410
5411 EXPECT_TRUE(channel_->AddSendStream(sp));
5412 EXPECT_TRUE(channel_->AddRecvStream(sp));
5413
5414 // The RTX SSRC is already used in previous streams, using it should fail.
5415 sp = cricket::StreamParams::CreateLegacy(rtx_ssrcs[0]);
5416 EXPECT_FALSE(channel_->AddSendStream(sp));
5417 EXPECT_FALSE(channel_->AddRecvStream(sp));
5418
5419 // After removing the original stream this should be fine to add (makes sure
5420 // that RTX ssrcs are not forever taken).
5421 EXPECT_TRUE(channel_->RemoveSendStream(ssrcs[0]));
5422 EXPECT_TRUE(channel_->RemoveRecvStream(ssrcs[0]));
5423 EXPECT_TRUE(channel_->AddSendStream(sp));
5424 EXPECT_TRUE(channel_->AddRecvStream(sp));
5425}
5426
eladalonf1841382017-06-12 01:16:46 -07005427TEST_F(WebRtcVideoChannelTest,
Peter Boströmd6f4c252015-03-26 16:23:04 +01005428 RejectsAddingStreamsWithOverlappingSimulcastSsrcs) {
Peter Boström0c4e06b2015-10-07 12:23:21 +02005429 static const uint32_t kFirstStreamSsrcs[] = {1, 2, 3};
5430 static const uint32_t kOverlappingStreamSsrcs[] = {4, 3, 5};
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005431 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005432
Peter Boströmd6f4c252015-03-26 16:23:04 +01005433 StreamParams sp =
5434 cricket::CreateSimStreamParams("cname", MAKE_VECTOR(kFirstStreamSsrcs));
5435
5436 EXPECT_TRUE(channel_->AddSendStream(sp));
5437 EXPECT_TRUE(channel_->AddRecvStream(sp));
5438
5439 // One of the SSRCs is already used in previous streams, using it should fail.
5440 sp = cricket::CreateSimStreamParams("cname",
5441 MAKE_VECTOR(kOverlappingStreamSsrcs));
5442 EXPECT_FALSE(channel_->AddSendStream(sp));
5443 EXPECT_FALSE(channel_->AddRecvStream(sp));
5444
5445 // After removing the original stream this should be fine to add (makes sure
5446 // that RTX ssrcs are not forever taken).
Peter Boström3548dd22015-05-22 18:48:36 +02005447 EXPECT_TRUE(channel_->RemoveSendStream(kFirstStreamSsrcs[0]));
5448 EXPECT_TRUE(channel_->RemoveRecvStream(kFirstStreamSsrcs[0]));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005449 EXPECT_TRUE(channel_->AddSendStream(sp));
5450 EXPECT_TRUE(channel_->AddRecvStream(sp));
5451}
5452
eladalonf1841382017-06-12 01:16:46 -07005453TEST_F(WebRtcVideoChannelTest, ReportsSsrcGroupsInStats) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005454 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boström259bd202015-05-28 13:39:50 +02005455
5456 static const uint32_t kSenderSsrcs[] = {4, 7, 10};
5457 static const uint32_t kSenderRtxSsrcs[] = {5, 8, 11};
5458
5459 StreamParams sender_sp = cricket::CreateSimWithRtxStreamParams(
5460 "cname", MAKE_VECTOR(kSenderSsrcs), MAKE_VECTOR(kSenderRtxSsrcs));
5461
5462 EXPECT_TRUE(channel_->AddSendStream(sender_sp));
5463
5464 static const uint32_t kReceiverSsrcs[] = {3};
5465 static const uint32_t kReceiverRtxSsrcs[] = {2};
5466
5467 StreamParams receiver_sp = cricket::CreateSimWithRtxStreamParams(
5468 "cname", MAKE_VECTOR(kReceiverSsrcs), MAKE_VECTOR(kReceiverRtxSsrcs));
5469 EXPECT_TRUE(channel_->AddRecvStream(receiver_sp));
5470
5471 cricket::VideoMediaInfo info;
5472 ASSERT_TRUE(channel_->GetStats(&info));
5473
5474 ASSERT_EQ(1u, info.senders.size());
5475 ASSERT_EQ(1u, info.receivers.size());
5476
5477 EXPECT_NE(sender_sp.ssrc_groups, receiver_sp.ssrc_groups);
5478 EXPECT_EQ(sender_sp.ssrc_groups, info.senders[0].ssrc_groups);
5479 EXPECT_EQ(receiver_sp.ssrc_groups, info.receivers[0].ssrc_groups);
5480}
5481
eladalonf1841382017-06-12 01:16:46 -07005482TEST_F(WebRtcVideoChannelTest, MapsReceivedPayloadTypeToCodecName) {
pbosf42376c2015-08-28 07:35:32 -07005483 FakeVideoReceiveStream* stream = AddRecvStream();
5484 webrtc::VideoReceiveStream::Stats stats;
5485 cricket::VideoMediaInfo info;
5486
5487 // Report no codec name before receiving.
5488 stream->SetStats(stats);
5489 ASSERT_TRUE(channel_->GetStats(&info));
5490 EXPECT_STREQ("", info.receivers[0].codec_name.c_str());
5491
5492 // Report VP8 if we're receiving it.
magjed509e4fe2016-11-18 01:34:11 -08005493 stats.current_payload_type = GetEngineCodec("VP8").id;
pbosf42376c2015-08-28 07:35:32 -07005494 stream->SetStats(stats);
5495 ASSERT_TRUE(channel_->GetStats(&info));
5496 EXPECT_STREQ(kVp8CodecName, info.receivers[0].codec_name.c_str());
5497
5498 // Report no codec name for unknown playload types.
5499 stats.current_payload_type = 3;
5500 stream->SetStats(stats);
5501 ASSERT_TRUE(channel_->GetStats(&info));
5502 EXPECT_STREQ("", info.receivers[0].codec_name.c_str());
5503}
5504
Seth Hampson5897a6e2018-04-03 11:16:33 -07005505// Tests that when we add a stream without SSRCs, but contains a stream_id
5506// that it is stored and its stream id is later used when the first packet
5507// arrives to properly create a receive stream with a sync label.
5508TEST_F(WebRtcVideoChannelTest, RecvUnsignaledSsrcWithSignaledStreamId) {
5509 const char kSyncLabel[] = "sync_label";
5510 cricket::StreamParams unsignaled_stream;
5511 unsignaled_stream.set_stream_ids({kSyncLabel});
5512 ASSERT_TRUE(channel_->AddRecvStream(unsignaled_stream));
5513 // The stream shouldn't have been created at this point because it doesn't
5514 // have any SSRCs.
Mirko Bonadeif859e552018-05-30 15:31:29 +02005515 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
Seth Hampson5897a6e2018-04-03 11:16:33 -07005516
5517 // Create and deliver packet.
5518 const size_t kDataLength = 12;
5519 uint8_t data[kDataLength];
5520 memset(data, 0, sizeof(data));
5521 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
5522 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005523 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
Seth Hampson5897a6e2018-04-03 11:16:33 -07005524
5525 // The stream should now be created with the appropriate sync label.
5526 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5527 EXPECT_EQ(kSyncLabel,
5528 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group);
5529
Saurav Dasff27da52019-09-20 11:05:30 -07005530 // Reset the unsignaled stream to clear the cache. This time when
Seth Hampson5897a6e2018-04-03 11:16:33 -07005531 // a default video receive stream is created it won't have a sync_group.
Saurav Dasff27da52019-09-20 11:05:30 -07005532 channel_->ResetUnsignaledRecvStream();
Seth Hampson5897a6e2018-04-03 11:16:33 -07005533 ASSERT_TRUE(channel_->RemoveRecvStream(kIncomingUnsignalledSsrc));
5534 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5535
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005536 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
Seth Hampson5897a6e2018-04-03 11:16:33 -07005537 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5538 EXPECT_TRUE(
5539 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group.empty());
5540}
5541
Ruslan Burakov493a6502019-02-27 15:32:48 +01005542// Test BaseMinimumPlayoutDelayMs on receive streams.
5543TEST_F(WebRtcVideoChannelTest, BaseMinimumPlayoutDelayMs) {
5544 // Test that set won't work for non-existing receive streams.
5545 EXPECT_FALSE(channel_->SetBaseMinimumPlayoutDelayMs(kSsrc + 2, 200));
5546 // Test that get won't work for non-existing receive streams.
5547 EXPECT_FALSE(channel_->GetBaseMinimumPlayoutDelayMs(kSsrc + 2));
5548
5549 EXPECT_TRUE(AddRecvStream());
5550 // Test that set works for the existing receive stream.
5551 EXPECT_TRUE(channel_->SetBaseMinimumPlayoutDelayMs(last_ssrc_, 200));
5552 auto* recv_stream = fake_call_->GetVideoReceiveStream(last_ssrc_);
5553 EXPECT_TRUE(recv_stream);
5554 EXPECT_EQ(recv_stream->base_mininum_playout_delay_ms(), 200);
5555 EXPECT_EQ(channel_->GetBaseMinimumPlayoutDelayMs(last_ssrc_).value_or(0),
5556 200);
5557}
5558
5559// Test BaseMinimumPlayoutDelayMs on unsignaled receive streams.
5560TEST_F(WebRtcVideoChannelTest, BaseMinimumPlayoutDelayMsUnsignaledRecvStream) {
5561 absl::optional<int> delay_ms;
5562 const FakeVideoReceiveStream* recv_stream;
5563
5564 // Set default stream with SSRC 0
5565 EXPECT_TRUE(channel_->SetBaseMinimumPlayoutDelayMs(0, 200));
5566 EXPECT_EQ(200, channel_->GetBaseMinimumPlayoutDelayMs(0).value_or(0));
5567
5568 // Spawn an unsignaled stream by sending a packet, it should inherit
5569 // default delay 200.
5570 const size_t kDataLength = 12;
5571 uint8_t data[kDataLength];
5572 memset(data, 0, sizeof(data));
5573 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
5574 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005575 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
Ruslan Burakov493a6502019-02-27 15:32:48 +01005576
5577 recv_stream = fake_call_->GetVideoReceiveStream(kIncomingUnsignalledSsrc);
5578 EXPECT_EQ(recv_stream->base_mininum_playout_delay_ms(), 200);
5579 delay_ms = channel_->GetBaseMinimumPlayoutDelayMs(kIncomingUnsignalledSsrc);
5580 EXPECT_EQ(200, delay_ms.value_or(0));
5581
5582 // Check that now if we change delay for SSRC 0 it will change delay for the
5583 // default receiving stream as well.
5584 EXPECT_TRUE(channel_->SetBaseMinimumPlayoutDelayMs(0, 300));
5585 EXPECT_EQ(300, channel_->GetBaseMinimumPlayoutDelayMs(0).value_or(0));
5586 delay_ms = channel_->GetBaseMinimumPlayoutDelayMs(kIncomingUnsignalledSsrc);
5587 EXPECT_EQ(300, delay_ms.value_or(0));
5588 recv_stream = fake_call_->GetVideoReceiveStream(kIncomingUnsignalledSsrc);
5589 EXPECT_EQ(recv_stream->base_mininum_playout_delay_ms(), 300);
5590}
5591
eladalonf1841382017-06-12 01:16:46 -07005592void WebRtcVideoChannelTest::TestReceiveUnsignaledSsrcPacket(
noahricd10a68e2015-07-10 11:27:55 -07005593 uint8_t payload_type,
5594 bool expect_created_receive_stream) {
magjed509e4fe2016-11-18 01:34:11 -08005595 // kRedRtxPayloadType must currently be unused.
5596 EXPECT_FALSE(FindCodecById(engine_.codecs(), kRedRtxPayloadType));
5597
noahricd10a68e2015-07-10 11:27:55 -07005598 // Add a RED RTX codec.
5599 VideoCodec red_rtx_codec =
magjed509e4fe2016-11-18 01:34:11 -08005600 VideoCodec::CreateRtxCodec(kRedRtxPayloadType, GetEngineCodec("red").id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005601 recv_parameters_.codecs.push_back(red_rtx_codec);
5602 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
noahricd10a68e2015-07-10 11:27:55 -07005603
5604 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5605 const size_t kDataLength = 12;
5606 uint8_t data[kDataLength];
5607 memset(data, 0, sizeof(data));
5608
5609 rtc::Set8(data, 1, payload_type);
5610 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
jbaucheec21bd2016-03-20 06:15:43 -07005611 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005612 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
noahricd10a68e2015-07-10 11:27:55 -07005613
5614 if (expect_created_receive_stream) {
5615 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
5616 << "Should have created a receive stream for payload type: "
5617 << payload_type;
5618 } else {
5619 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size())
5620 << "Shouldn't have created a receive stream for payload type: "
5621 << payload_type;
5622 }
5623}
5624
Åsa Persson2c7149b2018-10-15 09:36:10 +02005625class WebRtcVideoChannelDiscardUnknownSsrcTest : public WebRtcVideoChannelTest {
5626 public:
5627 WebRtcVideoChannelDiscardUnknownSsrcTest()
5628 : WebRtcVideoChannelTest(
5629 "WebRTC-Video-DiscardPacketsWithUnknownSsrc/Enabled/") {}
5630};
5631
5632TEST_F(WebRtcVideoChannelDiscardUnknownSsrcTest, NoUnsignalledStreamCreated) {
5633 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP8").id,
5634 false /* expect_created_receive_stream */);
5635}
5636
eladalonf1841382017-06-12 01:16:46 -07005637TEST_F(WebRtcVideoChannelTest, Vp8PacketCreatesUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005638 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP8").id,
5639 true /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005640}
5641
eladalonf1841382017-06-12 01:16:46 -07005642TEST_F(WebRtcVideoChannelTest, Vp9PacketCreatesUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005643 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP9").id,
5644 true /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005645}
5646
eladalonf1841382017-06-12 01:16:46 -07005647TEST_F(WebRtcVideoChannelTest, RtxPacketDoesntCreateUnsignalledStream) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02005648 AssignDefaultAptRtxTypes();
magjed509e4fe2016-11-18 01:34:11 -08005649 const cricket::VideoCodec vp8 = GetEngineCodec("VP8");
5650 const int rtx_vp8_payload_type = default_apt_rtx_types_[vp8.id];
5651 TestReceiveUnsignaledSsrcPacket(rtx_vp8_payload_type,
5652 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005653}
5654
eladalonf1841382017-06-12 01:16:46 -07005655TEST_F(WebRtcVideoChannelTest, UlpfecPacketDoesntCreateUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005656 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("ulpfec").id,
5657 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005658}
5659
eladalonf1841382017-06-12 01:16:46 -07005660TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr468da7c2016-11-22 02:16:47 -08005661 FlexfecPacketDoesntCreateUnsignalledStream) {
5662 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("flexfec-03").id,
5663 false /* expect_created_receive_stream */);
5664}
5665
eladalonf1841382017-06-12 01:16:46 -07005666TEST_F(WebRtcVideoChannelTest, RedRtxPacketDoesntCreateUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005667 TestReceiveUnsignaledSsrcPacket(kRedRtxPayloadType,
5668 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005669}
5670
mzanaty8a855d62017-02-17 15:46:43 -08005671// Test that receiving any unsignalled SSRC works even if it changes.
5672// The first unsignalled SSRC received will create a default receive stream.
5673// Any different unsignalled SSRC received will replace the default.
eladalonf1841382017-06-12 01:16:46 -07005674TEST_F(WebRtcVideoChannelTest, ReceiveDifferentUnsignaledSsrc) {
mzanaty8a855d62017-02-17 15:46:43 -08005675 // Allow receiving VP8, VP9, H264 (if enabled).
5676 cricket::VideoRecvParameters parameters;
5677 parameters.codecs.push_back(GetEngineCodec("VP8"));
5678 parameters.codecs.push_back(GetEngineCodec("VP9"));
5679
5680#if defined(WEBRTC_USE_H264)
5681 cricket::VideoCodec H264codec(126, "H264");
5682 parameters.codecs.push_back(H264codec);
5683#endif
5684
5685 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
5686 // No receive streams yet.
5687 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5688 cricket::FakeVideoRenderer renderer;
5689 EXPECT_TRUE(channel_->SetSink(kDefaultRecvSsrc, &renderer));
5690
5691 // Receive VP8 packet on first SSRC.
5692 uint8_t data[kMinRtpPacketLen];
5693 cricket::RtpHeader rtpHeader;
5694 rtpHeader.payload_type = GetEngineCodec("VP8").id;
5695 rtpHeader.seq_num = rtpHeader.timestamp = 0;
Yves Gerey665174f2018-06-19 15:03:05 +02005696 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 1;
mzanaty8a855d62017-02-17 15:46:43 -08005697 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5698 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005699 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
mzanaty8a855d62017-02-17 15:46:43 -08005700 // VP8 packet should create default receive stream.
5701 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
Yves Gerey665174f2018-06-19 15:03:05 +02005702 FakeVideoReceiveStream* recv_stream = fake_call_->GetVideoReceiveStreams()[0];
mzanaty8a855d62017-02-17 15:46:43 -08005703 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5704 // Verify that the receive stream sinks to a renderer.
Artem Titov1ebfb6a2019-01-03 23:49:37 +01005705 webrtc::VideoFrame video_frame =
5706 webrtc::VideoFrame::Builder()
5707 .set_video_frame_buffer(CreateBlackFrameBuffer(4, 4))
5708 .set_timestamp_rtp(100)
5709 .set_timestamp_us(0)
5710 .set_rotation(webrtc::kVideoRotation_0)
5711 .build();
mzanaty8a855d62017-02-17 15:46:43 -08005712 recv_stream->InjectFrame(video_frame);
5713 EXPECT_EQ(1, renderer.num_rendered_frames());
5714
5715 // Receive VP9 packet on second SSRC.
5716 rtpHeader.payload_type = GetEngineCodec("VP9").id;
Yves Gerey665174f2018-06-19 15:03:05 +02005717 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 2;
mzanaty8a855d62017-02-17 15:46:43 -08005718 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5719 rtc::CopyOnWriteBuffer packet2(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005720 channel_->OnPacketReceived(packet2, /* packet_time_us */ -1);
mzanaty8a855d62017-02-17 15:46:43 -08005721 // VP9 packet should replace the default receive SSRC.
5722 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5723 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
5724 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5725 // Verify that the receive stream sinks to a renderer.
Artem Titov1ebfb6a2019-01-03 23:49:37 +01005726 webrtc::VideoFrame video_frame2 =
5727 webrtc::VideoFrame::Builder()
5728 .set_video_frame_buffer(CreateBlackFrameBuffer(4, 4))
5729 .set_timestamp_rtp(200)
5730 .set_timestamp_us(0)
5731 .set_rotation(webrtc::kVideoRotation_0)
5732 .build();
mzanaty8a855d62017-02-17 15:46:43 -08005733 recv_stream->InjectFrame(video_frame2);
5734 EXPECT_EQ(2, renderer.num_rendered_frames());
5735
5736#if defined(WEBRTC_USE_H264)
5737 // Receive H264 packet on third SSRC.
5738 rtpHeader.payload_type = 126;
Yves Gerey665174f2018-06-19 15:03:05 +02005739 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 3;
mzanaty8a855d62017-02-17 15:46:43 -08005740 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5741 rtc::CopyOnWriteBuffer packet3(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005742 channel_->OnPacketReceived(packet3, /* packet_time_us */ -1);
mzanaty8a855d62017-02-17 15:46:43 -08005743 // H264 packet should replace the default receive SSRC.
5744 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5745 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
5746 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5747 // Verify that the receive stream sinks to a renderer.
Artem Titov1ebfb6a2019-01-03 23:49:37 +01005748 webrtc::VideoFrame video_frame3 =
5749 webrtc::VideoFrame::Builder()
5750 .set_video_frame_buffer(CreateBlackFrameBuffer(4, 4))
5751 .set_timestamp_rtp(300)
5752 .set_timestamp_us(0)
5753 .set_rotation(webrtc::kVideoRotation_0)
5754 .build();
mzanaty8a855d62017-02-17 15:46:43 -08005755 recv_stream->InjectFrame(video_frame3);
5756 EXPECT_EQ(3, renderer.num_rendered_frames());
5757#endif
5758}
5759
brandtr0dc57ea2017-05-29 23:33:31 -07005760// This test verifies that when a new default stream is created for a new
5761// unsignaled SSRC, the new stream does not overwrite any old stream that had
5762// been the default receive stream before being properly signaled.
eladalonf1841382017-06-12 01:16:46 -07005763TEST_F(WebRtcVideoChannelTest,
brandtr0dc57ea2017-05-29 23:33:31 -07005764 NewUnsignaledStreamDoesNotDestroyPreviouslyUnsignaledStream) {
5765 cricket::VideoRecvParameters parameters;
5766 parameters.codecs.push_back(GetEngineCodec("VP8"));
5767 ASSERT_TRUE(channel_->SetRecvParameters(parameters));
5768
5769 // No streams signaled and no packets received, so we should not have any
5770 // stream objects created yet.
5771 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5772
5773 // Receive packet on an unsignaled SSRC.
5774 uint8_t data[kMinRtpPacketLen];
5775 cricket::RtpHeader rtp_header;
5776 rtp_header.payload_type = GetEngineCodec("VP8").id;
5777 rtp_header.seq_num = rtp_header.timestamp = 0;
5778 rtp_header.ssrc = kSsrcs3[0];
5779 cricket::SetRtpHeader(data, sizeof(data), rtp_header);
5780 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005781 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
brandtr0dc57ea2017-05-29 23:33:31 -07005782 // Default receive stream should be created.
5783 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5784 FakeVideoReceiveStream* recv_stream0 =
5785 fake_call_->GetVideoReceiveStreams()[0];
5786 EXPECT_EQ(kSsrcs3[0], recv_stream0->GetConfig().rtp.remote_ssrc);
5787
5788 // Signal the SSRC.
5789 EXPECT_TRUE(
5790 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrcs3[0])));
5791 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5792 recv_stream0 = fake_call_->GetVideoReceiveStreams()[0];
5793 EXPECT_EQ(kSsrcs3[0], recv_stream0->GetConfig().rtp.remote_ssrc);
5794
5795 // Receive packet on a different unsignaled SSRC.
5796 rtp_header.ssrc = kSsrcs3[1];
5797 cricket::SetRtpHeader(data, sizeof(data), rtp_header);
5798 packet.SetData(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005799 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
brandtr0dc57ea2017-05-29 23:33:31 -07005800 // New default receive stream should be created, but old stream should remain.
5801 ASSERT_EQ(2u, fake_call_->GetVideoReceiveStreams().size());
5802 EXPECT_EQ(recv_stream0, fake_call_->GetVideoReceiveStreams()[0]);
5803 FakeVideoReceiveStream* recv_stream1 =
5804 fake_call_->GetVideoReceiveStreams()[1];
5805 EXPECT_EQ(kSsrcs3[1], recv_stream1->GetConfig().rtp.remote_ssrc);
5806}
5807
Seth Hampson7c682e02018-05-04 16:28:15 -07005808TEST_F(WebRtcVideoChannelTest, CanSetMaxBitrateForExistingStream) {
skvladdc1c62c2016-03-16 19:07:43 -07005809 AddSendStream();
5810
Niels Möller805a27e2019-01-21 12:21:27 +01005811 webrtc::test::FrameForwarder frame_forwarder;
5812 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
skvladdc1c62c2016-03-16 19:07:43 -07005813 EXPECT_TRUE(channel_->SetSend(true));
Niels Möller805a27e2019-01-21 12:21:27 +01005814 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
skvladdc1c62c2016-03-16 19:07:43 -07005815
perkjfa10b552016-10-02 23:45:26 -07005816 int default_encoder_bitrate = GetMaxEncoderBitrate();
brandtr468da7c2016-11-22 02:16:47 -08005817 EXPECT_GT(default_encoder_bitrate, 1000);
skvladdc1c62c2016-03-16 19:07:43 -07005818
5819 // TODO(skvlad): Resolve the inconsistency between the interpretation
5820 // of the global bitrate limit for audio and video:
5821 // - Audio: max_bandwidth_bps = 0 - fail the operation,
5822 // max_bandwidth_bps = -1 - remove the bandwidth limit
5823 // - Video: max_bandwidth_bps = 0 - remove the bandwidth limit,
pbos5c7760a2017-03-10 11:23:12 -08005824 // max_bandwidth_bps = -1 - remove the bandwidth limit
skvladdc1c62c2016-03-16 19:07:43 -07005825
perkjfa10b552016-10-02 23:45:26 -07005826 SetAndExpectMaxBitrate(1000, 0, 1000);
5827 SetAndExpectMaxBitrate(1000, 800, 800);
5828 SetAndExpectMaxBitrate(600, 800, 600);
5829 SetAndExpectMaxBitrate(0, 800, 800);
5830 SetAndExpectMaxBitrate(0, 0, default_encoder_bitrate);
skvladdc1c62c2016-03-16 19:07:43 -07005831
Niels Möllerff40b142018-04-09 08:49:14 +02005832 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
skvladdc1c62c2016-03-16 19:07:43 -07005833}
5834
eladalonf1841382017-06-12 01:16:46 -07005835TEST_F(WebRtcVideoChannelTest, CannotSetMaxBitrateForNonexistentStream) {
skvladdc1c62c2016-03-16 19:07:43 -07005836 webrtc::RtpParameters nonexistent_parameters =
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005837 channel_->GetRtpSendParameters(last_ssrc_);
Mirko Bonadeif859e552018-05-30 15:31:29 +02005838 EXPECT_EQ(0u, nonexistent_parameters.encodings.size());
skvladdc1c62c2016-03-16 19:07:43 -07005839
5840 nonexistent_parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005841 EXPECT_FALSE(
Zach Steinba37b4b2018-01-23 15:02:36 -08005842 channel_->SetRtpSendParameters(last_ssrc_, nonexistent_parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07005843}
5844
eladalonf1841382017-06-12 01:16:46 -07005845TEST_F(WebRtcVideoChannelTest,
Seth Hampson7c682e02018-05-04 16:28:15 -07005846 SetLowMaxBitrateOverwritesVideoStreamMinBitrate) {
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005847 FakeVideoSendStream* stream = AddSendStream();
5848
Seth Hampson7c682e02018-05-04 16:28:15 -07005849 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5850 EXPECT_EQ(1UL, parameters.encodings.size());
5851 EXPECT_FALSE(parameters.encodings[0].max_bitrate_bps.has_value());
5852 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5853
5854 // Note that this is testing the behavior of the FakeVideoSendStream, which
5855 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5856 // we are just testing the behavior of
5857 // EncoderStreamFactory::CreateEncoderStreams.
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005858 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
Elad Alon80f53b72019-10-11 16:19:43 +02005859 EXPECT_EQ(webrtc::kDefaultMinVideoBitrateBps,
5860 stream->GetVideoStreams()[0].min_bitrate_bps);
Seth Hampson7c682e02018-05-04 16:28:15 -07005861
5862 // Set a low max bitrate & check that VideoStream.min_bitrate_bps is limited
5863 // by this amount.
5864 parameters = channel_->GetRtpSendParameters(last_ssrc_);
Elad Alon80f53b72019-10-11 16:19:43 +02005865 int low_max_bitrate_bps = webrtc::kDefaultMinVideoBitrateBps - 1000;
Seth Hampson7c682e02018-05-04 16:28:15 -07005866 parameters.encodings[0].max_bitrate_bps = low_max_bitrate_bps;
5867 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5868
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005869 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5870 EXPECT_EQ(low_max_bitrate_bps, stream->GetVideoStreams()[0].min_bitrate_bps);
5871 EXPECT_EQ(low_max_bitrate_bps, stream->GetVideoStreams()[0].max_bitrate_bps);
5872}
5873
5874TEST_F(WebRtcVideoChannelTest,
5875 SetHighMinBitrateOverwritesVideoStreamMaxBitrate) {
5876 FakeVideoSendStream* stream = AddSendStream();
5877
5878 // Note that this is testing the behavior of the FakeVideoSendStream, which
5879 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5880 // we are just testing the behavior of
5881 // EncoderStreamFactory::CreateEncoderStreams.
5882 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5883 int high_min_bitrate_bps = stream->GetVideoStreams()[0].max_bitrate_bps + 1;
5884
5885 // Set a high min bitrate and check that max_bitrate_bps is adjusted up.
5886 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5887 EXPECT_EQ(1UL, parameters.encodings.size());
5888 parameters.encodings[0].min_bitrate_bps = high_min_bitrate_bps;
5889 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5890
5891 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5892 EXPECT_EQ(high_min_bitrate_bps, stream->GetVideoStreams()[0].min_bitrate_bps);
5893 EXPECT_EQ(high_min_bitrate_bps, stream->GetVideoStreams()[0].max_bitrate_bps);
5894}
5895
5896TEST_F(WebRtcVideoChannelTest,
5897 SetMinBitrateAboveMaxBitrateLimitAdjustsMinBitrateDown) {
5898 send_parameters_.max_bandwidth_bps = 99999;
5899 FakeVideoSendStream* stream = AddSendStream();
5900 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
5901 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
5902 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
Elad Alon80f53b72019-10-11 16:19:43 +02005903 EXPECT_EQ(webrtc::kDefaultMinVideoBitrateBps,
5904 stream->GetVideoStreams()[0].min_bitrate_bps);
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005905 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5906 stream->GetVideoStreams()[0].max_bitrate_bps);
5907
5908 // Set min bitrate above global max bitrate and check that min_bitrate_bps is
5909 // adjusted down.
5910 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5911 EXPECT_EQ(1UL, parameters.encodings.size());
5912 parameters.encodings[0].min_bitrate_bps = 99999 + 1;
5913 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5914 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5915 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5916 stream->GetVideoStreams()[0].min_bitrate_bps);
5917 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5918 stream->GetVideoStreams()[0].max_bitrate_bps);
Seth Hampson7c682e02018-05-04 16:28:15 -07005919}
5920
Åsa Persson8c1bf952018-09-13 10:42:19 +02005921TEST_F(WebRtcVideoChannelTest, SetMaxFramerateOneStream) {
5922 FakeVideoSendStream* stream = AddSendStream();
5923
5924 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5925 EXPECT_EQ(1UL, parameters.encodings.size());
5926 EXPECT_FALSE(parameters.encodings[0].max_framerate.has_value());
5927 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5928
5929 // Note that this is testing the behavior of the FakeVideoSendStream, which
5930 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5931 // we are just testing the behavior of
5932 // EncoderStreamFactory::CreateEncoderStreams.
5933 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5934 EXPECT_EQ(kDefaultVideoMaxFramerate,
5935 stream->GetVideoStreams()[0].max_framerate);
5936
5937 // Set max framerate and check that VideoStream.max_framerate is set.
5938 const int kNewMaxFramerate = kDefaultVideoMaxFramerate - 1;
5939 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5940 parameters.encodings[0].max_framerate = kNewMaxFramerate;
5941 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5942
5943 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5944 EXPECT_EQ(kNewMaxFramerate, stream->GetVideoStreams()[0].max_framerate);
5945}
5946
Åsa Persson23eba222018-10-02 14:47:06 +02005947TEST_F(WebRtcVideoChannelTest, SetNumTemporalLayersForSingleStream) {
5948 FakeVideoSendStream* stream = AddSendStream();
5949
5950 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5951 EXPECT_EQ(1UL, parameters.encodings.size());
5952 EXPECT_FALSE(parameters.encodings[0].num_temporal_layers.has_value());
5953 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5954
5955 // Note that this is testing the behavior of the FakeVideoSendStream, which
5956 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5957 // we are just testing the behavior of
5958 // EncoderStreamFactory::CreateEncoderStreams.
5959 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5960 EXPECT_FALSE(stream->GetVideoStreams()[0].num_temporal_layers.has_value());
5961
5962 // Set temporal layers and check that VideoStream.num_temporal_layers is set.
5963 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5964 parameters.encodings[0].num_temporal_layers = 2;
5965 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5966
5967 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5968 EXPECT_EQ(2UL, stream->GetVideoStreams()[0].num_temporal_layers);
5969}
5970
Seth Hampson7c682e02018-05-04 16:28:15 -07005971TEST_F(WebRtcVideoChannelTest,
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005972 CannotSetRtpSendParametersWithIncorrectNumberOfEncodings) {
skvladdc1c62c2016-03-16 19:07:43 -07005973 AddSendStream();
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005974 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07005975 // Two or more encodings should result in failure.
5976 parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Zach Steinba37b4b2018-01-23 15:02:36 -08005977 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeeffb2aced2017-01-06 23:05:37 -08005978 // Zero encodings should also fail.
5979 parameters.encodings.clear();
Zach Steinba37b4b2018-01-23 15:02:36 -08005980 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeeffb2aced2017-01-06 23:05:37 -08005981}
5982
Zach Stein3ca452b2018-01-18 10:01:24 -08005983TEST_F(WebRtcVideoChannelTest,
5984 CannotSetSimulcastRtpSendParametersWithIncorrectNumberOfEncodings) {
5985 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
5986 StreamParams sp = CreateSimStreamParams("cname", ssrcs);
5987 AddSendStream(sp);
5988
5989 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5990
5991 // Additional encodings should result in failure.
5992 parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Zach Steinba37b4b2018-01-23 15:02:36 -08005993 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Zach Stein3ca452b2018-01-18 10:01:24 -08005994 // Zero encodings should also fail.
5995 parameters.encodings.clear();
Zach Steinba37b4b2018-01-23 15:02:36 -08005996 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Zach Stein3ca452b2018-01-18 10:01:24 -08005997}
5998
deadbeeffb2aced2017-01-06 23:05:37 -08005999// Changing the SSRC through RtpParameters is not allowed.
eladalonf1841382017-06-12 01:16:46 -07006000TEST_F(WebRtcVideoChannelTest, CannotSetSsrcInRtpSendParameters) {
deadbeeffb2aced2017-01-06 23:05:37 -08006001 AddSendStream();
6002 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
Oskar Sundbom78807582017-11-16 11:09:55 +01006003 parameters.encodings[0].ssrc = 0xdeadbeef;
Zach Steinba37b4b2018-01-23 15:02:36 -08006004 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07006005}
6006
Seth Hampson24722b32017-12-22 09:36:42 -08006007// Tests that when RTCRtpEncodingParameters.bitrate_priority gets set to
6008// a value <= 0, setting the parameters returns false.
6009TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersInvalidBitratePriority) {
6010 AddSendStream();
6011 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6012 EXPECT_EQ(1UL, parameters.encodings.size());
6013 EXPECT_EQ(webrtc::kDefaultBitratePriority,
6014 parameters.encodings[0].bitrate_priority);
6015
6016 parameters.encodings[0].bitrate_priority = 0;
Zach Steinba37b4b2018-01-23 15:02:36 -08006017 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08006018 parameters.encodings[0].bitrate_priority = -2;
Zach Steinba37b4b2018-01-23 15:02:36 -08006019 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08006020}
6021
6022// Tests when the the RTCRtpEncodingParameters.bitrate_priority gets set
6023// properly on the VideoChannel and propogates down to the video encoder.
6024TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersPriorityOneStream) {
6025 AddSendStream();
6026 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6027 EXPECT_EQ(1UL, parameters.encodings.size());
6028 EXPECT_EQ(webrtc::kDefaultBitratePriority,
6029 parameters.encodings[0].bitrate_priority);
6030
6031 // Change the value and set it on the VideoChannel.
6032 double new_bitrate_priority = 2.0;
6033 parameters.encodings[0].bitrate_priority = new_bitrate_priority;
Zach Steinba37b4b2018-01-23 15:02:36 -08006034 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08006035
6036 // Verify that the encoding parameters bitrate_priority is set for the
6037 // VideoChannel.
6038 parameters = channel_->GetRtpSendParameters(last_ssrc_);
6039 EXPECT_EQ(1UL, parameters.encodings.size());
6040 EXPECT_EQ(new_bitrate_priority, parameters.encodings[0].bitrate_priority);
6041
6042 // Verify that the new value propagated down to the encoder.
6043 std::vector<FakeVideoSendStream*> video_send_streams =
6044 fake_call_->GetVideoSendStreams();
6045 EXPECT_EQ(1UL, video_send_streams.size());
6046 FakeVideoSendStream* video_send_stream = video_send_streams.front();
6047 // Check that the WebRtcVideoSendStream updated the VideoEncoderConfig
6048 // appropriately.
6049 EXPECT_EQ(new_bitrate_priority,
6050 video_send_stream->GetEncoderConfig().bitrate_priority);
6051 // Check that the vector of VideoStreams also was propagated correctly. Note
6052 // that this is testing the behavior of the FakeVideoSendStream, which mimics
6053 // the calls to CreateEncoderStreams to get the VideoStreams.
Danil Chapovalov00c71832018-06-15 15:58:38 +02006054 EXPECT_EQ(absl::optional<double>(new_bitrate_priority),
Seth Hampson24722b32017-12-22 09:36:42 -08006055 video_send_stream->GetVideoStreams()[0].bitrate_priority);
6056}
6057
6058// Tests that the RTCRtpEncodingParameters.bitrate_priority is set for the
6059// VideoChannel and the value propogates to the video encoder with all simulcast
6060// streams.
6061TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersPrioritySimulcastStreams) {
6062 // Create the stream params with multiple ssrcs for simulcast.
Åsa Persson31cb8f92018-06-27 10:44:56 +02006063 const size_t kNumSimulcastStreams = 3;
Seth Hampson24722b32017-12-22 09:36:42 -08006064 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
6065 StreamParams stream_params = CreateSimStreamParams("cname", ssrcs);
6066 AddSendStream(stream_params);
6067 uint32_t primary_ssrc = stream_params.first_ssrc();
6068
Niels Möller805a27e2019-01-21 12:21:27 +01006069 // Using the FrameForwarder, we manually send a full size
Tommi85959932018-02-07 19:26:06 +01006070 // frame. This creates multiple VideoStreams for all simulcast layers when
6071 // reconfiguring, and allows us to test this behavior.
Niels Möller805a27e2019-01-21 12:21:27 +01006072 webrtc::test::FrameForwarder frame_forwarder;
Seth Hampson24722b32017-12-22 09:36:42 -08006073 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006074 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, &options, &frame_forwarder));
Seth Hampson24722b32017-12-22 09:36:42 -08006075 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006076 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame(
6077 1920, 1080, webrtc::VideoRotation::kVideoRotation_0,
6078 rtc::kNumMicrosecsPerSec / 30));
6079
Seth Hampson24722b32017-12-22 09:36:42 -08006080 // Get and set the rtp encoding parameters.
6081 webrtc::RtpParameters parameters =
6082 channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02006083 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson24722b32017-12-22 09:36:42 -08006084 EXPECT_EQ(webrtc::kDefaultBitratePriority,
6085 parameters.encodings[0].bitrate_priority);
6086 // Change the value and set it on the VideoChannel.
6087 double new_bitrate_priority = 2.0;
6088 parameters.encodings[0].bitrate_priority = new_bitrate_priority;
Zach Steinba37b4b2018-01-23 15:02:36 -08006089 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08006090
6091 // Verify that the encoding parameters priority is set on the VideoChannel.
6092 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02006093 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson24722b32017-12-22 09:36:42 -08006094 EXPECT_EQ(new_bitrate_priority, parameters.encodings[0].bitrate_priority);
6095
6096 // Verify that the new value propagated down to the encoder.
6097 std::vector<FakeVideoSendStream*> video_send_streams =
6098 fake_call_->GetVideoSendStreams();
6099 EXPECT_EQ(1UL, video_send_streams.size());
6100 FakeVideoSendStream* video_send_stream = video_send_streams.front();
6101 // Check that the WebRtcVideoSendStream updated the VideoEncoderConfig
6102 // appropriately.
Åsa Persson31cb8f92018-06-27 10:44:56 +02006103 EXPECT_EQ(kNumSimulcastStreams,
Seth Hampson24722b32017-12-22 09:36:42 -08006104 video_send_stream->GetEncoderConfig().number_of_streams);
6105 EXPECT_EQ(new_bitrate_priority,
6106 video_send_stream->GetEncoderConfig().bitrate_priority);
6107 // Check that the vector of VideoStreams also propagated correctly. The
6108 // FakeVideoSendStream calls CreateEncoderStreams, and we are testing that
6109 // these are created appropriately for the simulcast case.
Åsa Persson31cb8f92018-06-27 10:44:56 +02006110 EXPECT_EQ(kNumSimulcastStreams, video_send_stream->GetVideoStreams().size());
Danil Chapovalov00c71832018-06-15 15:58:38 +02006111 EXPECT_EQ(absl::optional<double>(new_bitrate_priority),
Seth Hampson24722b32017-12-22 09:36:42 -08006112 video_send_stream->GetVideoStreams()[0].bitrate_priority);
6113 // Since we are only setting bitrate priority per-sender, the other
6114 // VideoStreams should have a bitrate priority of 0.
Danil Chapovalov00c71832018-06-15 15:58:38 +02006115 EXPECT_EQ(absl::nullopt,
Seth Hampson24722b32017-12-22 09:36:42 -08006116 video_send_stream->GetVideoStreams()[1].bitrate_priority);
Danil Chapovalov00c71832018-06-15 15:58:38 +02006117 EXPECT_EQ(absl::nullopt,
Seth Hampson24722b32017-12-22 09:36:42 -08006118 video_send_stream->GetVideoStreams()[2].bitrate_priority);
Niels Möllerff40b142018-04-09 08:49:14 +02006119 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, nullptr, nullptr));
Seth Hampson24722b32017-12-22 09:36:42 -08006120}
6121
Tim Haloun648d28a2018-10-18 16:52:22 -07006122// RTCRtpEncodingParameters.network_priority must be one of a few values
6123// derived from the default priority, corresponding to very-low, low, medium,
6124// or high.
6125TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersInvalidNetworkPriority) {
6126 AddSendStream();
6127 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6128 EXPECT_EQ(1UL, parameters.encodings.size());
6129 EXPECT_EQ(webrtc::kDefaultBitratePriority,
6130 parameters.encodings[0].network_priority);
6131
6132 double good_values[] = {0.5, 1.0, 2.0, 4.0};
6133 double bad_values[] = {-1.0, 0.0, 0.49, 0.51, 1.1, 3.99, 4.1, 5.0};
6134 for (auto it : good_values) {
6135 parameters.encodings[0].network_priority = it;
6136 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6137 }
6138 for (auto it : bad_values) {
6139 parameters.encodings[0].network_priority = it;
6140 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6141 }
6142}
6143
Florent Castellic1a0bcb2019-01-29 14:26:48 +01006144TEST_F(WebRtcVideoChannelTest,
6145 GetAndSetRtpSendParametersScaleResolutionDownByVP8) {
Rasmus Brandt9387b522019-02-05 14:23:26 +01006146 VideoSendParameters parameters;
6147 parameters.codecs.push_back(VideoCodec(kVp8CodecName));
Florent Castellic1a0bcb2019-01-29 14:26:48 +01006148 ASSERT_TRUE(channel_->SetSendParameters(parameters));
6149 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6150
6151 webrtc::test::FrameForwarder frame_forwarder;
Rasmus Brandt9387b522019-02-05 14:23:26 +01006152 FakeFrameSource frame_source(1280, 720, rtc::kNumMicrosecsPerSec / 30);
Florent Castellic1a0bcb2019-01-29 14:26:48 +01006153
6154 VideoOptions options;
6155 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
6156 channel_->SetSend(true);
6157
6158 // Try layers in natural order (smallest to largest).
6159 {
6160 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6161 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6162 rtp_parameters.encodings[0].scale_resolution_down_by = 4.0;
6163 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6164 rtp_parameters.encodings[2].scale_resolution_down_by = 1.0;
6165 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6166 ASSERT_TRUE(result.ok());
6167
6168 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6169
6170 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6171 ASSERT_EQ(3u, video_streams.size());
6172 EXPECT_EQ(320u, video_streams[0].width);
6173 EXPECT_EQ(180u, video_streams[0].height);
6174 EXPECT_EQ(640u, video_streams[1].width);
6175 EXPECT_EQ(360u, video_streams[1].height);
6176 EXPECT_EQ(1280u, video_streams[2].width);
6177 EXPECT_EQ(720u, video_streams[2].height);
6178 }
6179
6180 // Try layers in reverse natural order (largest to smallest).
6181 {
6182 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6183 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6184 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
6185 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6186 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6187 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6188 ASSERT_TRUE(result.ok());
6189
6190 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6191
6192 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6193 ASSERT_EQ(3u, video_streams.size());
6194 EXPECT_EQ(1280u, video_streams[0].width);
6195 EXPECT_EQ(720u, video_streams[0].height);
6196 EXPECT_EQ(640u, video_streams[1].width);
6197 EXPECT_EQ(360u, video_streams[1].height);
6198 EXPECT_EQ(320u, video_streams[2].width);
6199 EXPECT_EQ(180u, video_streams[2].height);
6200 }
6201
6202 // Try layers in mixed order.
6203 {
6204 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6205 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6206 rtp_parameters.encodings[0].scale_resolution_down_by = 10.0;
6207 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6208 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6209 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6210 ASSERT_TRUE(result.ok());
6211
6212 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6213
6214 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6215 ASSERT_EQ(3u, video_streams.size());
6216 EXPECT_EQ(128u, video_streams[0].width);
6217 EXPECT_EQ(72u, video_streams[0].height);
6218 EXPECT_EQ(640u, video_streams[1].width);
6219 EXPECT_EQ(360u, video_streams[1].height);
6220 EXPECT_EQ(320u, video_streams[2].width);
6221 EXPECT_EQ(180u, video_streams[2].height);
6222 }
6223
6224 // Try with a missing scale setting, defaults to 1.0 if any other is set.
6225 {
6226 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6227 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6228 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
6229 rtp_parameters.encodings[1].scale_resolution_down_by.reset();
6230 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6231 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6232 ASSERT_TRUE(result.ok());
6233
6234 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6235
6236 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6237 ASSERT_EQ(3u, video_streams.size());
6238 EXPECT_EQ(1280u, video_streams[0].width);
6239 EXPECT_EQ(720u, video_streams[0].height);
6240 EXPECT_EQ(1280u, video_streams[1].width);
6241 EXPECT_EQ(720u, video_streams[1].height);
6242 EXPECT_EQ(320u, video_streams[2].width);
6243 EXPECT_EQ(180u, video_streams[2].height);
6244 }
6245
6246 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6247}
6248
6249TEST_F(WebRtcVideoChannelTest,
Rasmus Brandt9387b522019-02-05 14:23:26 +01006250 GetAndSetRtpSendParametersScaleResolutionDownByVP8WithOddResolution) {
6251 // Ensure that the top layer has width and height divisible by 2^3,
6252 // so that the bottom layer has width and height divisible by 2.
6253 // TODO(bugs.webrtc.org/8785): Remove this field trial when we fully trust
6254 // the number of simulcast layers set by the app.
6255 webrtc::test::ScopedFieldTrials field_trial(
6256 "WebRTC-NormalizeSimulcastResolution/Enabled-3/");
6257
6258 // Set up WebRtcVideoChannel for 3-layer VP8 simulcast.
6259 VideoSendParameters parameters;
6260 parameters.codecs.push_back(VideoCodec(kVp8CodecName));
6261 ASSERT_TRUE(channel_->SetSendParameters(parameters));
6262 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6263 webrtc::test::FrameForwarder frame_forwarder;
6264 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, /*options=*/nullptr,
6265 &frame_forwarder));
6266 channel_->SetSend(true);
6267
6268 // Set |scale_resolution_down_by|'s.
6269 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6270 ASSERT_EQ(rtp_parameters.encodings.size(), 3u);
6271 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
6272 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6273 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6274 const auto result =
6275 channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6276 ASSERT_TRUE(result.ok());
6277
6278 // Use a capture resolution whose width and height are not divisible by 2^3.
6279 // (See field trial set at the top of the test.)
6280 FakeFrameSource frame_source(2007, 1207, rtc::kNumMicrosecsPerSec / 30);
6281 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6282
6283 // Ensure the scaling is correct.
6284 const auto video_streams = stream->GetVideoStreams();
6285 ASSERT_EQ(video_streams.size(), 3u);
6286 // Ensure that we round the capture resolution down for the top layer...
6287 EXPECT_EQ(video_streams[0].width, 2000u);
6288 EXPECT_EQ(video_streams[0].height, 1200u);
6289 EXPECT_EQ(video_streams[1].width, 1000u);
6290 EXPECT_EQ(video_streams[1].height, 600u);
6291 // ...and that the bottom layer has a width/height divisible by 2.
6292 EXPECT_EQ(video_streams[2].width, 500u);
6293 EXPECT_EQ(video_streams[2].height, 300u);
6294
6295 // Tear down.
6296 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6297}
6298
6299TEST_F(WebRtcVideoChannelTest,
Florent Castellic1a0bcb2019-01-29 14:26:48 +01006300 GetAndSetRtpSendParametersScaleResolutionDownByH264) {
Rasmus Brandt9387b522019-02-05 14:23:26 +01006301 encoder_factory_->AddSupportedVideoCodecType(kH264CodecName);
6302 VideoSendParameters parameters;
6303 parameters.codecs.push_back(VideoCodec(kH264CodecName));
Florent Castellic1a0bcb2019-01-29 14:26:48 +01006304 ASSERT_TRUE(channel_->SetSendParameters(parameters));
6305 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6306
6307 webrtc::test::FrameForwarder frame_forwarder;
Rasmus Brandt9387b522019-02-05 14:23:26 +01006308 FakeFrameSource frame_source(1280, 720, rtc::kNumMicrosecsPerSec / 30);
Florent Castellic1a0bcb2019-01-29 14:26:48 +01006309
6310 VideoOptions options;
6311 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
6312 channel_->SetSend(true);
6313
6314 // Try layers in natural order (smallest to largest).
6315 {
6316 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6317 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6318 rtp_parameters.encodings[0].scale_resolution_down_by = 4.0;
6319 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6320 rtp_parameters.encodings[2].scale_resolution_down_by = 1.0;
6321 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6322 ASSERT_TRUE(result.ok());
6323
6324 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6325
6326 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6327 ASSERT_EQ(3u, video_streams.size());
6328 EXPECT_EQ(320u, video_streams[0].width);
6329 EXPECT_EQ(180u, video_streams[0].height);
6330 EXPECT_EQ(640u, video_streams[1].width);
6331 EXPECT_EQ(360u, video_streams[1].height);
6332 EXPECT_EQ(1280u, video_streams[2].width);
6333 EXPECT_EQ(720u, video_streams[2].height);
6334 }
6335
6336 // Try layers in reverse natural order (largest to smallest).
6337 {
6338 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6339 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6340 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
6341 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6342 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6343 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6344 ASSERT_TRUE(result.ok());
6345
6346 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6347
6348 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6349 ASSERT_EQ(3u, video_streams.size());
6350 EXPECT_EQ(1280u, video_streams[0].width);
6351 EXPECT_EQ(720u, video_streams[0].height);
6352 EXPECT_EQ(640u, video_streams[1].width);
6353 EXPECT_EQ(360u, video_streams[1].height);
6354 EXPECT_EQ(320u, video_streams[2].width);
6355 EXPECT_EQ(180u, video_streams[2].height);
6356 }
6357
6358 // Try layers in mixed order.
6359 {
6360 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6361 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6362 rtp_parameters.encodings[0].scale_resolution_down_by = 10.0;
6363 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6364 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6365 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6366 ASSERT_TRUE(result.ok());
6367
6368 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6369
6370 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6371 ASSERT_EQ(3u, video_streams.size());
6372 EXPECT_EQ(128u, video_streams[0].width);
6373 EXPECT_EQ(72u, video_streams[0].height);
6374 EXPECT_EQ(640u, video_streams[1].width);
6375 EXPECT_EQ(360u, video_streams[1].height);
6376 EXPECT_EQ(320u, video_streams[2].width);
6377 EXPECT_EQ(180u, video_streams[2].height);
6378 }
6379
6380 // Try with a missing scale setting, defaults to 1.0 if any other is set.
6381 {
6382 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6383 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6384 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
6385 rtp_parameters.encodings[1].scale_resolution_down_by.reset();
6386 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6387 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6388 ASSERT_TRUE(result.ok());
6389
6390 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6391
6392 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6393 ASSERT_EQ(3u, video_streams.size());
6394 EXPECT_EQ(1280u, video_streams[0].width);
6395 EXPECT_EQ(720u, video_streams[0].height);
6396 EXPECT_EQ(1280u, video_streams[1].width);
6397 EXPECT_EQ(720u, video_streams[1].height);
6398 EXPECT_EQ(320u, video_streams[2].width);
6399 EXPECT_EQ(180u, video_streams[2].height);
6400 }
6401 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6402}
6403
Rasmus Brandt9387b522019-02-05 14:23:26 +01006404TEST_F(WebRtcVideoChannelTest,
6405 GetAndSetRtpSendParametersScaleResolutionDownByH264WithOddResolution) {
6406 // Ensure that the top layer has width and height divisible by 2^3,
6407 // so that the bottom layer has width and height divisible by 2.
6408 // TODO(bugs.webrtc.org/8785): Remove this field trial when we fully trust
6409 // the number of simulcast layers set by the app.
6410 webrtc::test::ScopedFieldTrials field_trial(
6411 "WebRTC-NormalizeSimulcastResolution/Enabled-3/");
6412
6413 // Set up WebRtcVideoChannel for 3-layer H264 simulcast.
6414 encoder_factory_->AddSupportedVideoCodecType(kH264CodecName);
6415 VideoSendParameters parameters;
6416 parameters.codecs.push_back(VideoCodec(kH264CodecName));
6417 ASSERT_TRUE(channel_->SetSendParameters(parameters));
6418 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6419 webrtc::test::FrameForwarder frame_forwarder;
6420 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, /*options=*/nullptr,
6421 &frame_forwarder));
6422 channel_->SetSend(true);
6423
6424 // Set |scale_resolution_down_by|'s.
6425 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6426 ASSERT_EQ(rtp_parameters.encodings.size(), 3u);
6427 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
6428 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6429 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6430 const auto result =
6431 channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6432 ASSERT_TRUE(result.ok());
6433
6434 // Use a capture resolution whose width and height are not divisible by 2^3.
6435 // (See field trial set at the top of the test.)
6436 FakeFrameSource frame_source(2007, 1207, rtc::kNumMicrosecsPerSec / 30);
6437 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6438
6439 // Ensure the scaling is correct.
6440 const auto video_streams = stream->GetVideoStreams();
6441 ASSERT_EQ(video_streams.size(), 3u);
6442 // Ensure that we round the capture resolution down for the top layer...
6443 EXPECT_EQ(video_streams[0].width, 2000u);
6444 EXPECT_EQ(video_streams[0].height, 1200u);
6445 EXPECT_EQ(video_streams[1].width, 1000u);
6446 EXPECT_EQ(video_streams[1].height, 600u);
6447 // ...and that the bottom layer has a width/height divisible by 2.
6448 EXPECT_EQ(video_streams[2].width, 500u);
6449 EXPECT_EQ(video_streams[2].height, 300u);
6450
6451 // Tear down.
6452 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6453}
6454
Åsa Persson8c1bf952018-09-13 10:42:19 +02006455TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersMaxFramerate) {
6456 const size_t kNumSimulcastStreams = 3;
6457 SetUpSimulcast(true, false);
6458
6459 // Get and set the rtp encoding parameters.
6460 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6461 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6462 for (const auto& encoding : parameters.encodings) {
6463 EXPECT_FALSE(encoding.max_framerate);
6464 }
6465
6466 // Change the value and set it on the VideoChannel.
6467 parameters.encodings[0].max_framerate = 10;
6468 parameters.encodings[1].max_framerate = 20;
6469 parameters.encodings[2].max_framerate = 25;
6470 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6471
6472 // Verify that the bitrates are set on the VideoChannel.
6473 parameters = channel_->GetRtpSendParameters(last_ssrc_);
6474 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6475 EXPECT_EQ(10, parameters.encodings[0].max_framerate);
6476 EXPECT_EQ(20, parameters.encodings[1].max_framerate);
6477 EXPECT_EQ(25, parameters.encodings[2].max_framerate);
6478}
6479
Åsa Persson23eba222018-10-02 14:47:06 +02006480TEST_F(WebRtcVideoChannelTest,
6481 SetRtpSendParametersNumTemporalLayersFailsForInvalidRange) {
6482 const size_t kNumSimulcastStreams = 3;
6483 SetUpSimulcast(true, false);
6484
6485 // Get and set the rtp encoding parameters.
6486 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6487 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6488
6489 // Num temporal layers should be in the range [1, kMaxTemporalStreams].
6490 parameters.encodings[0].num_temporal_layers = 0;
6491 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
6492 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6493 parameters.encodings[0].num_temporal_layers = webrtc::kMaxTemporalStreams + 1;
6494 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
6495 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6496}
6497
6498TEST_F(WebRtcVideoChannelTest,
6499 SetRtpSendParametersNumTemporalLayersFailsForInvalidModification) {
6500 const size_t kNumSimulcastStreams = 3;
6501 SetUpSimulcast(true, false);
6502
6503 // Get and set the rtp encoding parameters.
6504 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6505 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6506
6507 // No/all layers should be set.
6508 parameters.encodings[0].num_temporal_layers = 1;
6509 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION,
6510 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6511
6512 // Different values not supported.
6513 parameters.encodings[0].num_temporal_layers = 1;
6514 parameters.encodings[1].num_temporal_layers = 2;
6515 parameters.encodings[2].num_temporal_layers = 2;
6516 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION,
6517 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6518}
6519
6520TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersNumTemporalLayers) {
6521 const size_t kNumSimulcastStreams = 3;
6522 SetUpSimulcast(true, false);
6523
6524 // Get and set the rtp encoding parameters.
6525 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6526 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6527 for (const auto& encoding : parameters.encodings)
6528 EXPECT_FALSE(encoding.num_temporal_layers);
6529
6530 // Change the value and set it on the VideoChannel.
6531 parameters.encodings[0].num_temporal_layers = 3;
6532 parameters.encodings[1].num_temporal_layers = 3;
6533 parameters.encodings[2].num_temporal_layers = 3;
6534 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6535
6536 // Verify that the number of temporal layers are set on the VideoChannel.
6537 parameters = channel_->GetRtpSendParameters(last_ssrc_);
6538 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6539 EXPECT_EQ(3, parameters.encodings[0].num_temporal_layers);
6540 EXPECT_EQ(3, parameters.encodings[1].num_temporal_layers);
6541 EXPECT_EQ(3, parameters.encodings[2].num_temporal_layers);
6542}
6543
6544TEST_F(WebRtcVideoChannelTest, NumTemporalLayersPropagatedToEncoder) {
6545 const size_t kNumSimulcastStreams = 3;
6546 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6547
6548 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006549 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson23eba222018-10-02 14:47:06 +02006550 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006551 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson23eba222018-10-02 14:47:06 +02006552 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006553 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson23eba222018-10-02 14:47:06 +02006554
6555 // Get and set the rtp encoding parameters.
6556 // Change the value and set it on the VideoChannel.
6557 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6558 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6559 parameters.encodings[0].num_temporal_layers = 2;
6560 parameters.encodings[1].num_temporal_layers = 2;
6561 parameters.encodings[2].num_temporal_layers = 2;
6562 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6563
6564 // Verify that the new value is propagated down to the encoder.
6565 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6566 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6567 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6568 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6569 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6570 EXPECT_EQ(2UL, encoder_config.simulcast_layers[0].num_temporal_layers);
6571 EXPECT_EQ(2UL, encoder_config.simulcast_layers[1].num_temporal_layers);
6572 EXPECT_EQ(2UL, encoder_config.simulcast_layers[2].num_temporal_layers);
6573
6574 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6575 // VideoStreams are created appropriately for the simulcast case.
6576 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6577 EXPECT_EQ(2UL, stream->GetVideoStreams()[0].num_temporal_layers);
6578 EXPECT_EQ(2UL, stream->GetVideoStreams()[1].num_temporal_layers);
6579 EXPECT_EQ(2UL, stream->GetVideoStreams()[2].num_temporal_layers);
6580
6581 // No parameter changed, encoder should not be reconfigured.
6582 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6583 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6584
6585 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6586}
6587
6588TEST_F(WebRtcVideoChannelTest,
6589 DefaultValuePropagatedToEncoderForUnsetNumTemporalLayers) {
6590 const size_t kDefaultNumTemporalLayers = 3;
6591 const size_t kNumSimulcastStreams = 3;
6592 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6593
6594 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006595 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson23eba222018-10-02 14:47:06 +02006596 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006597 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson23eba222018-10-02 14:47:06 +02006598 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006599 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson23eba222018-10-02 14:47:06 +02006600
6601 // Change rtp encoding parameters, num_temporal_layers not changed.
6602 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6603 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6604 parameters.encodings[0].min_bitrate_bps = 33000;
6605 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6606
6607 // Verify that no value is propagated down to the encoder.
6608 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6609 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6610 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6611 EXPECT_FALSE(encoder_config.simulcast_layers[0].num_temporal_layers);
6612 EXPECT_FALSE(encoder_config.simulcast_layers[1].num_temporal_layers);
6613 EXPECT_FALSE(encoder_config.simulcast_layers[2].num_temporal_layers);
6614
6615 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6616 // VideoStreams are created appropriately for the simulcast case.
6617 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6618 EXPECT_EQ(kDefaultNumTemporalLayers,
6619 stream->GetVideoStreams()[0].num_temporal_layers);
6620 EXPECT_EQ(kDefaultNumTemporalLayers,
6621 stream->GetVideoStreams()[1].num_temporal_layers);
6622 EXPECT_EQ(kDefaultNumTemporalLayers,
6623 stream->GetVideoStreams()[2].num_temporal_layers);
6624
6625 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6626}
6627
Åsa Persson8c1bf952018-09-13 10:42:19 +02006628TEST_F(WebRtcVideoChannelTest, MaxSimulcastFrameratePropagatedToEncoder) {
6629 const size_t kNumSimulcastStreams = 3;
6630 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6631
6632 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006633 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson8c1bf952018-09-13 10:42:19 +02006634 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006635 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson8c1bf952018-09-13 10:42:19 +02006636 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006637 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson8c1bf952018-09-13 10:42:19 +02006638
6639 // Get and set the rtp encoding parameters.
6640 // Change the value and set it on the VideoChannel.
6641 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6642 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6643 parameters.encodings[0].max_framerate = 15;
6644 parameters.encodings[1].max_framerate = 25;
6645 parameters.encodings[2].max_framerate = 20;
6646 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6647
6648 // Verify that the new value propagated down to the encoder.
6649 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6650 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6651 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6652 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6653 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6654 EXPECT_EQ(15, encoder_config.simulcast_layers[0].max_framerate);
6655 EXPECT_EQ(25, encoder_config.simulcast_layers[1].max_framerate);
6656 EXPECT_EQ(20, encoder_config.simulcast_layers[2].max_framerate);
6657
6658 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6659 // VideoStreams are created appropriately for the simulcast case.
6660 // Currently the maximum |max_framerate| is used.
6661 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6662 EXPECT_EQ(25, stream->GetVideoStreams()[0].max_framerate);
6663 EXPECT_EQ(25, stream->GetVideoStreams()[1].max_framerate);
6664 EXPECT_EQ(25, stream->GetVideoStreams()[2].max_framerate);
6665
6666 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6667}
6668
6669TEST_F(WebRtcVideoChannelTest,
6670 DefaultValuePropagatedToEncoderForUnsetFramerate) {
6671 const size_t kNumSimulcastStreams = 3;
6672 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6673 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6674
6675 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006676 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson8c1bf952018-09-13 10:42:19 +02006677 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006678 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson8c1bf952018-09-13 10:42:19 +02006679 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006680 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson8c1bf952018-09-13 10:42:19 +02006681
6682 // Get and set the rtp encoding parameters.
6683 // Change the value and set it on the VideoChannel.
6684 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6685 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6686 parameters.encodings[0].max_framerate = 15;
6687 parameters.encodings[2].max_framerate = 20;
6688 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6689
6690 // Verify that the new value propagated down to the encoder.
6691 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6692 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6693 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6694 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6695 EXPECT_EQ(15, encoder_config.simulcast_layers[0].max_framerate);
6696 EXPECT_EQ(-1, encoder_config.simulcast_layers[1].max_framerate);
6697 EXPECT_EQ(20, encoder_config.simulcast_layers[2].max_framerate);
6698
6699 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6700 // VideoStreams are created appropriately for the simulcast case.
6701 // The maximum |max_framerate| is used, kDefaultVideoMaxFramerate: 60.
6702 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6703 EXPECT_EQ(kDefaultVideoMaxFramerate,
6704 stream->GetVideoStreams()[0].max_framerate);
6705 EXPECT_EQ(kDefaultVideoMaxFramerate,
6706 stream->GetVideoStreams()[1].max_framerate);
6707 EXPECT_EQ(kDefaultVideoMaxFramerate,
6708 stream->GetVideoStreams()[2].max_framerate);
6709
6710 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6711}
6712
Åsa Persson55659812018-06-18 17:51:32 +02006713TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersMinAndMaxBitrate) {
6714 const size_t kNumSimulcastStreams = 3;
6715 SetUpSimulcast(true, false);
6716
6717 // Get and set the rtp encoding parameters.
6718 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6719 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6720 for (const auto& encoding : parameters.encodings) {
6721 EXPECT_FALSE(encoding.min_bitrate_bps);
6722 EXPECT_FALSE(encoding.max_bitrate_bps);
6723 }
6724
6725 // Change the value and set it on the VideoChannel.
6726 parameters.encodings[0].min_bitrate_bps = 100000;
6727 parameters.encodings[0].max_bitrate_bps = 200000;
6728 parameters.encodings[1].min_bitrate_bps = 300000;
6729 parameters.encodings[1].max_bitrate_bps = 400000;
6730 parameters.encodings[2].min_bitrate_bps = 500000;
6731 parameters.encodings[2].max_bitrate_bps = 600000;
6732 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6733
6734 // Verify that the bitrates are set on the VideoChannel.
6735 parameters = channel_->GetRtpSendParameters(last_ssrc_);
6736 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6737 EXPECT_EQ(100000, parameters.encodings[0].min_bitrate_bps);
6738 EXPECT_EQ(200000, parameters.encodings[0].max_bitrate_bps);
6739 EXPECT_EQ(300000, parameters.encodings[1].min_bitrate_bps);
6740 EXPECT_EQ(400000, parameters.encodings[1].max_bitrate_bps);
6741 EXPECT_EQ(500000, parameters.encodings[2].min_bitrate_bps);
6742 EXPECT_EQ(600000, parameters.encodings[2].max_bitrate_bps);
6743}
6744
6745TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersFailsWithIncorrectBitrate) {
6746 const size_t kNumSimulcastStreams = 3;
6747 SetUpSimulcast(true, false);
6748
6749 // Get and set the rtp encoding parameters.
6750 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6751 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6752
6753 // Max bitrate lower than min bitrate should fail.
6754 parameters.encodings[2].min_bitrate_bps = 100000;
6755 parameters.encodings[2].max_bitrate_bps = 100000 - 1;
6756 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
6757 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6758}
6759
6760// Test that min and max bitrate values set via RtpParameters are correctly
6761// propagated to the underlying encoder, and that the target is set to 3/4 of
6762// the maximum (3/4 was chosen because it's similar to the simulcast defaults
6763// that are used if no min/max are specified).
6764TEST_F(WebRtcVideoChannelTest, MinAndMaxSimulcastBitratePropagatedToEncoder) {
6765 const size_t kNumSimulcastStreams = 3;
6766 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6767
6768 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006769 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006770 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006771 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006772 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006773 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006774
6775 // Get and set the rtp encoding parameters.
6776 // Change the value and set it on the VideoChannel.
6777 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6778 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6779 parameters.encodings[0].min_bitrate_bps = 100000;
6780 parameters.encodings[0].max_bitrate_bps = 200000;
6781 parameters.encodings[1].min_bitrate_bps = 300000;
6782 parameters.encodings[1].max_bitrate_bps = 400000;
6783 parameters.encodings[2].min_bitrate_bps = 500000;
6784 parameters.encodings[2].max_bitrate_bps = 600000;
6785 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6786
6787 // Verify that the new value propagated down to the encoder.
6788 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6789 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6790 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6791 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6792 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6793 EXPECT_EQ(100000, encoder_config.simulcast_layers[0].min_bitrate_bps);
6794 EXPECT_EQ(200000, encoder_config.simulcast_layers[0].max_bitrate_bps);
6795 EXPECT_EQ(300000, encoder_config.simulcast_layers[1].min_bitrate_bps);
6796 EXPECT_EQ(400000, encoder_config.simulcast_layers[1].max_bitrate_bps);
6797 EXPECT_EQ(500000, encoder_config.simulcast_layers[2].min_bitrate_bps);
6798 EXPECT_EQ(600000, encoder_config.simulcast_layers[2].max_bitrate_bps);
6799
6800 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6801 // VideoStreams are created appropriately for the simulcast case.
6802 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6803 // Target bitrate: 200000 * 3 / 4 = 150000.
6804 EXPECT_EQ(100000, stream->GetVideoStreams()[0].min_bitrate_bps);
6805 EXPECT_EQ(150000, stream->GetVideoStreams()[0].target_bitrate_bps);
6806 EXPECT_EQ(200000, stream->GetVideoStreams()[0].max_bitrate_bps);
6807 // Target bitrate: 400000 * 3 / 4 = 300000.
6808 EXPECT_EQ(300000, stream->GetVideoStreams()[1].min_bitrate_bps);
6809 EXPECT_EQ(300000, stream->GetVideoStreams()[1].target_bitrate_bps);
6810 EXPECT_EQ(400000, stream->GetVideoStreams()[1].max_bitrate_bps);
6811 // Target bitrate: 600000 * 3 / 4 = 450000, less than min -> max.
6812 EXPECT_EQ(500000, stream->GetVideoStreams()[2].min_bitrate_bps);
6813 EXPECT_EQ(600000, stream->GetVideoStreams()[2].target_bitrate_bps);
6814 EXPECT_EQ(600000, stream->GetVideoStreams()[2].max_bitrate_bps);
6815
6816 // No parameter changed, encoder should not be reconfigured.
6817 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6818 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6819
6820 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6821}
6822
6823// Test to only specify the min or max bitrate value for a layer via
6824// RtpParameters. The unspecified min/max and target value should be set to the
6825// simulcast default that is used if no min/max are specified.
6826TEST_F(WebRtcVideoChannelTest, MinOrMaxSimulcastBitratePropagatedToEncoder) {
6827 const size_t kNumSimulcastStreams = 3;
6828 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6829 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6830
6831 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006832 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006833 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006834 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006835 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006836 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006837
6838 // Get and set the rtp encoding parameters.
6839 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6840 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6841
6842 // Change the value and set it on the VideoChannel.
6843 // Layer 0: only configure min bitrate.
6844 const int kMinBpsLayer0 = kDefault[0].min_bitrate_bps + 1;
6845 parameters.encodings[0].min_bitrate_bps = kMinBpsLayer0;
6846 // Layer 1: only configure max bitrate.
6847 const int kMaxBpsLayer1 = kDefault[1].max_bitrate_bps - 1;
6848 parameters.encodings[1].max_bitrate_bps = kMaxBpsLayer1;
6849 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6850
6851 // Verify that the new value propagated down to the encoder.
6852 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6853 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6854 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6855 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6856 EXPECT_EQ(kMinBpsLayer0, encoder_config.simulcast_layers[0].min_bitrate_bps);
6857 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].max_bitrate_bps);
6858 EXPECT_EQ(-1, encoder_config.simulcast_layers[1].min_bitrate_bps);
6859 EXPECT_EQ(kMaxBpsLayer1, encoder_config.simulcast_layers[1].max_bitrate_bps);
6860 EXPECT_EQ(-1, encoder_config.simulcast_layers[2].min_bitrate_bps);
6861 EXPECT_EQ(-1, encoder_config.simulcast_layers[2].max_bitrate_bps);
6862
6863 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6864 // VideoStreams are created appropriately for the simulcast case.
6865 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6866 // Layer 0: min configured bitrate should overwrite min default.
6867 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].min_bitrate_bps);
6868 EXPECT_EQ(kDefault[0].target_bitrate_bps,
6869 stream->GetVideoStreams()[0].target_bitrate_bps);
6870 EXPECT_EQ(kDefault[0].max_bitrate_bps,
6871 stream->GetVideoStreams()[0].max_bitrate_bps);
6872 // Layer 1: max configured bitrate should overwrite max default.
6873 EXPECT_EQ(kDefault[1].min_bitrate_bps,
6874 stream->GetVideoStreams()[1].min_bitrate_bps);
6875 EXPECT_EQ(kDefault[1].target_bitrate_bps,
6876 stream->GetVideoStreams()[1].target_bitrate_bps);
6877 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].max_bitrate_bps);
6878 // Layer 2: min and max bitrate not configured, default expected.
6879 EXPECT_EQ(kDefault[2].min_bitrate_bps,
6880 stream->GetVideoStreams()[2].min_bitrate_bps);
6881 EXPECT_EQ(kDefault[2].target_bitrate_bps,
6882 stream->GetVideoStreams()[2].target_bitrate_bps);
6883 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6884 stream->GetVideoStreams()[2].max_bitrate_bps);
6885
6886 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6887}
6888
6889// Test that specifying the min (or max) bitrate value for a layer via
6890// RtpParameters above (or below) the simulcast default max (or min) adjusts the
6891// unspecified values accordingly.
6892TEST_F(WebRtcVideoChannelTest, SetMinAndMaxSimulcastBitrateAboveBelowDefault) {
6893 const size_t kNumSimulcastStreams = 3;
6894 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6895 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6896
6897 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006898 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006899 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006900 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006901 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006902 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006903
6904 // Get and set the rtp encoding parameters.
6905 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6906 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6907
6908 // Change the value and set it on the VideoChannel.
6909 // For layer 0, set the min bitrate above the default max.
6910 const int kMinBpsLayer0 = kDefault[0].max_bitrate_bps + 1;
6911 parameters.encodings[0].min_bitrate_bps = kMinBpsLayer0;
6912 // For layer 1, set the max bitrate below the default min.
6913 const int kMaxBpsLayer1 = kDefault[1].min_bitrate_bps - 1;
6914 parameters.encodings[1].max_bitrate_bps = kMaxBpsLayer1;
6915 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6916
6917 // Verify that the new value propagated down to the encoder.
6918 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6919 // VideoStreams are created appropriately for the simulcast case.
6920 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6921 // Layer 0: Min bitrate above default max (target/max should be adjusted).
6922 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].min_bitrate_bps);
6923 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].target_bitrate_bps);
6924 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].max_bitrate_bps);
6925 // Layer 1: Max bitrate below default min (min/target should be adjusted).
6926 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].min_bitrate_bps);
6927 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].target_bitrate_bps);
6928 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].max_bitrate_bps);
6929 // Layer 2: min and max bitrate not configured, default expected.
6930 EXPECT_EQ(kDefault[2].min_bitrate_bps,
6931 stream->GetVideoStreams()[2].min_bitrate_bps);
6932 EXPECT_EQ(kDefault[2].target_bitrate_bps,
6933 stream->GetVideoStreams()[2].target_bitrate_bps);
6934 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6935 stream->GetVideoStreams()[2].max_bitrate_bps);
6936
6937 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6938}
6939
6940TEST_F(WebRtcVideoChannelTest, BandwidthAboveTotalMaxBitrateGivenToMaxLayer) {
6941 const size_t kNumSimulcastStreams = 3;
6942 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6943 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6944
6945 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006946 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006947 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006948 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006949 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006950 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006951
6952 // Set max bitrate for all but the highest layer.
6953 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6954 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6955 parameters.encodings[0].max_bitrate_bps = kDefault[0].max_bitrate_bps;
6956 parameters.encodings[1].max_bitrate_bps = kDefault[1].max_bitrate_bps;
6957 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6958
6959 // Set max bandwidth equal to total max bitrate.
6960 send_parameters_.max_bandwidth_bps =
6961 GetTotalMaxBitrateBps(stream->GetVideoStreams());
6962 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6963 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6964
6965 // No bitrate above the total max to give to the highest layer.
6966 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6967 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6968 stream->GetVideoStreams()[2].max_bitrate_bps);
6969
6970 // Set max bandwidth above the total max bitrate.
6971 send_parameters_.max_bandwidth_bps =
6972 GetTotalMaxBitrateBps(stream->GetVideoStreams()) + 1;
6973 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6974 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6975
6976 // The highest layer has no max bitrate set -> the bitrate above the total
6977 // max should be given to the highest layer.
6978 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6979 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
6980 GetTotalMaxBitrateBps(stream->GetVideoStreams()));
6981 EXPECT_EQ(kDefault[2].max_bitrate_bps + 1,
6982 stream->GetVideoStreams()[2].max_bitrate_bps);
6983
6984 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6985}
6986
6987TEST_F(WebRtcVideoChannelTest,
6988 BandwidthAboveTotalMaxBitrateNotGivenToMaxLayerIfMaxBitrateSet) {
6989 const size_t kNumSimulcastStreams = 3;
6990 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6991 EXPECT_EQ(kNumSimulcastStreams, kDefault.size());
6992 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6993
6994 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006995 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006996 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006997 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006998 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006999 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02007000
7001 // Set max bitrate for the highest layer.
7002 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
7003 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
7004 parameters.encodings[2].max_bitrate_bps = kDefault[2].max_bitrate_bps;
7005 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
7006
7007 // Set max bandwidth above the total max bitrate.
7008 send_parameters_.max_bandwidth_bps =
7009 GetTotalMaxBitrateBps(stream->GetVideoStreams()) + 1;
7010 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
7011 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
7012
7013 // The highest layer has the max bitrate set -> the bitrate above the total
7014 // max should not be given to the highest layer.
7015 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
7016 EXPECT_EQ(*parameters.encodings[2].max_bitrate_bps,
7017 stream->GetVideoStreams()[2].max_bitrate_bps);
7018
7019 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
7020}
7021
Åsa Perssonbdee46d2018-06-25 11:28:06 +02007022// Test that min and max bitrate values set via RtpParameters are correctly
7023// propagated to the underlying encoder for a single stream.
7024TEST_F(WebRtcVideoChannelTest, MinAndMaxBitratePropagatedToEncoder) {
7025 FakeVideoSendStream* stream = AddSendStream();
7026 EXPECT_TRUE(channel_->SetSend(true));
7027 EXPECT_TRUE(stream->IsSending());
7028
7029 // Set min and max bitrate.
7030 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
7031 EXPECT_EQ(1u, parameters.encodings.size());
7032 parameters.encodings[0].min_bitrate_bps = 80000;
7033 parameters.encodings[0].max_bitrate_bps = 150000;
7034 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
7035
7036 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
7037 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
7038 EXPECT_EQ(1u, encoder_config.number_of_streams);
7039 EXPECT_EQ(1u, encoder_config.simulcast_layers.size());
7040 EXPECT_EQ(80000, encoder_config.simulcast_layers[0].min_bitrate_bps);
7041 EXPECT_EQ(150000, encoder_config.simulcast_layers[0].max_bitrate_bps);
7042
7043 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
7044 // VideoStreams are created appropriately.
7045 EXPECT_EQ(1u, stream->GetVideoStreams().size());
7046 EXPECT_EQ(80000, stream->GetVideoStreams()[0].min_bitrate_bps);
7047 EXPECT_EQ(150000, stream->GetVideoStreams()[0].target_bitrate_bps);
7048 EXPECT_EQ(150000, stream->GetVideoStreams()[0].max_bitrate_bps);
7049}
7050
7051// Test the default min and max bitrate value are correctly propagated to the
7052// underlying encoder for a single stream (when the values are not set via
7053// RtpParameters).
7054TEST_F(WebRtcVideoChannelTest, DefaultMinAndMaxBitratePropagatedToEncoder) {
7055 FakeVideoSendStream* stream = AddSendStream();
7056 EXPECT_TRUE(channel_->SetSend(true));
7057 EXPECT_TRUE(stream->IsSending());
7058
7059 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
7060 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
7061 EXPECT_EQ(1u, encoder_config.number_of_streams);
7062 EXPECT_EQ(1u, encoder_config.simulcast_layers.size());
7063 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].min_bitrate_bps);
7064 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].max_bitrate_bps);
7065
7066 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
7067 // VideoStreams are created appropriately.
7068 EXPECT_EQ(1u, stream->GetVideoStreams().size());
Elad Alon80f53b72019-10-11 16:19:43 +02007069 EXPECT_EQ(webrtc::kDefaultMinVideoBitrateBps,
Åsa Perssonbdee46d2018-06-25 11:28:06 +02007070 stream->GetVideoStreams()[0].min_bitrate_bps);
7071 EXPECT_GT(stream->GetVideoStreams()[0].max_bitrate_bps,
7072 stream->GetVideoStreams()[0].min_bitrate_bps);
7073 EXPECT_EQ(stream->GetVideoStreams()[0].max_bitrate_bps,
7074 stream->GetVideoStreams()[0].target_bitrate_bps);
7075}
7076
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07007077// Test that a stream will not be sending if its encoding is made inactive
7078// through SetRtpSendParameters.
Seth Hampson8234ead2018-02-02 15:16:24 -08007079TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersOneEncodingActive) {
deadbeefdbe2b872016-03-22 15:42:00 -07007080 FakeVideoSendStream* stream = AddSendStream();
7081 EXPECT_TRUE(channel_->SetSend(true));
7082 EXPECT_TRUE(stream->IsSending());
7083
7084 // Get current parameters and change "active" to false.
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007085 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
deadbeefdbe2b872016-03-22 15:42:00 -07007086 ASSERT_EQ(1u, parameters.encodings.size());
7087 ASSERT_TRUE(parameters.encodings[0].active);
7088 parameters.encodings[0].active = false;
Zach Steinba37b4b2018-01-23 15:02:36 -08007089 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeefdbe2b872016-03-22 15:42:00 -07007090 EXPECT_FALSE(stream->IsSending());
7091
7092 // Now change it back to active and verify we resume sending.
7093 parameters.encodings[0].active = true;
Zach Steinba37b4b2018-01-23 15:02:36 -08007094 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeefdbe2b872016-03-22 15:42:00 -07007095 EXPECT_TRUE(stream->IsSending());
7096}
7097
Seth Hampson8234ead2018-02-02 15:16:24 -08007098// Tests that when active is updated for any simulcast layer then the send
7099// stream's sending state will be updated and it will be reconfigured with the
7100// new appropriate active simulcast streams.
7101TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersMultipleEncodingsActive) {
7102 // Create the stream params with multiple ssrcs for simulcast.
Åsa Persson31cb8f92018-06-27 10:44:56 +02007103 const size_t kNumSimulcastStreams = 3;
Seth Hampson8234ead2018-02-02 15:16:24 -08007104 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
7105 StreamParams stream_params = CreateSimStreamParams("cname", ssrcs);
7106 FakeVideoSendStream* fake_video_send_stream = AddSendStream(stream_params);
7107 uint32_t primary_ssrc = stream_params.first_ssrc();
7108
Niels Möller805a27e2019-01-21 12:21:27 +01007109 // Using the FrameForwarder, we manually send a full size
Tommi85959932018-02-07 19:26:06 +01007110 // frame. This allows us to test that ReconfigureEncoder is called
7111 // appropriately.
Niels Möller805a27e2019-01-21 12:21:27 +01007112 webrtc::test::FrameForwarder frame_forwarder;
Seth Hampson8234ead2018-02-02 15:16:24 -08007113 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01007114 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, &options, &frame_forwarder));
Seth Hampson8234ead2018-02-02 15:16:24 -08007115 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01007116 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame(
7117 1920, 1080, webrtc::VideoRotation::kVideoRotation_0,
7118 rtc::kNumMicrosecsPerSec / 30));
Seth Hampson8234ead2018-02-02 15:16:24 -08007119
7120 // Check that all encodings are initially active.
7121 webrtc::RtpParameters parameters =
7122 channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02007123 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08007124 EXPECT_TRUE(parameters.encodings[0].active);
7125 EXPECT_TRUE(parameters.encodings[1].active);
7126 EXPECT_TRUE(parameters.encodings[2].active);
7127 EXPECT_TRUE(fake_video_send_stream->IsSending());
7128
7129 // Only turn on only the middle stream.
7130 parameters.encodings[0].active = false;
7131 parameters.encodings[1].active = true;
7132 parameters.encodings[2].active = false;
7133 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
7134 // Verify that the active fields are set on the VideoChannel.
7135 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02007136 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08007137 EXPECT_FALSE(parameters.encodings[0].active);
7138 EXPECT_TRUE(parameters.encodings[1].active);
7139 EXPECT_FALSE(parameters.encodings[2].active);
7140 // Check that the VideoSendStream is updated appropriately. This means its
7141 // send state was updated and it was reconfigured.
7142 EXPECT_TRUE(fake_video_send_stream->IsSending());
7143 std::vector<webrtc::VideoStream> simulcast_streams =
7144 fake_video_send_stream->GetVideoStreams();
Åsa Persson31cb8f92018-06-27 10:44:56 +02007145 EXPECT_EQ(kNumSimulcastStreams, simulcast_streams.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08007146 EXPECT_FALSE(simulcast_streams[0].active);
7147 EXPECT_TRUE(simulcast_streams[1].active);
7148 EXPECT_FALSE(simulcast_streams[2].active);
7149
7150 // Turn off all streams.
7151 parameters.encodings[0].active = false;
7152 parameters.encodings[1].active = false;
7153 parameters.encodings[2].active = false;
7154 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
7155 // Verify that the active fields are set on the VideoChannel.
7156 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02007157 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08007158 EXPECT_FALSE(parameters.encodings[0].active);
7159 EXPECT_FALSE(parameters.encodings[1].active);
7160 EXPECT_FALSE(parameters.encodings[2].active);
7161 // Check that the VideoSendStream is off.
7162 EXPECT_FALSE(fake_video_send_stream->IsSending());
7163 simulcast_streams = fake_video_send_stream->GetVideoStreams();
Åsa Persson31cb8f92018-06-27 10:44:56 +02007164 EXPECT_EQ(kNumSimulcastStreams, simulcast_streams.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08007165 EXPECT_FALSE(simulcast_streams[0].active);
7166 EXPECT_FALSE(simulcast_streams[1].active);
7167 EXPECT_FALSE(simulcast_streams[2].active);
7168
Niels Möllerff40b142018-04-09 08:49:14 +02007169 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, nullptr, nullptr));
Seth Hampson8234ead2018-02-02 15:16:24 -08007170}
7171
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07007172// Test that if a stream is reconfigured (due to a codec change or other
7173// change) while its encoding is still inactive, it doesn't start sending.
eladalonf1841382017-06-12 01:16:46 -07007174TEST_F(WebRtcVideoChannelTest,
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07007175 InactiveStreamDoesntStartSendingWhenReconfigured) {
7176 // Set an initial codec list, which will be modified later.
7177 cricket::VideoSendParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08007178 parameters1.codecs.push_back(GetEngineCodec("VP8"));
7179 parameters1.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07007180 EXPECT_TRUE(channel_->SetSendParameters(parameters1));
7181
7182 FakeVideoSendStream* stream = AddSendStream();
7183 EXPECT_TRUE(channel_->SetSend(true));
7184 EXPECT_TRUE(stream->IsSending());
7185
7186 // Get current parameters and change "active" to false.
7187 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
7188 ASSERT_EQ(1u, parameters.encodings.size());
7189 ASSERT_TRUE(parameters.encodings[0].active);
7190 parameters.encodings[0].active = false;
7191 EXPECT_EQ(1u, GetFakeSendStreams().size());
7192 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
Zach Steinba37b4b2018-01-23 15:02:36 -08007193 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07007194 EXPECT_FALSE(stream->IsSending());
7195
7196 // Reorder the codec list, causing the stream to be reconfigured.
7197 cricket::VideoSendParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08007198 parameters2.codecs.push_back(GetEngineCodec("VP9"));
7199 parameters2.codecs.push_back(GetEngineCodec("VP8"));
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07007200 EXPECT_TRUE(channel_->SetSendParameters(parameters2));
7201 auto new_streams = GetFakeSendStreams();
7202 // Assert that a new underlying stream was created due to the codec change.
7203 // Otherwise, this test isn't testing what it set out to test.
7204 EXPECT_EQ(1u, GetFakeSendStreams().size());
7205 EXPECT_EQ(2, fake_call_->GetNumCreatedSendStreams());
7206
7207 // Verify that we still are not sending anything, due to the inactive
7208 // encoding.
7209 EXPECT_FALSE(new_streams[0]->IsSending());
7210}
7211
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007212// Test that GetRtpSendParameters returns the currently configured codecs.
eladalonf1841382017-06-12 01:16:46 -07007213TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersCodecs) {
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007214 AddSendStream();
7215 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08007216 parameters.codecs.push_back(GetEngineCodec("VP8"));
7217 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007218 EXPECT_TRUE(channel_->SetSendParameters(parameters));
7219
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007220 webrtc::RtpParameters rtp_parameters =
7221 channel_->GetRtpSendParameters(last_ssrc_);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007222 ASSERT_EQ(2u, rtp_parameters.codecs.size());
magjed509e4fe2016-11-18 01:34:11 -08007223 EXPECT_EQ(GetEngineCodec("VP8").ToCodecParameters(),
7224 rtp_parameters.codecs[0]);
7225 EXPECT_EQ(GetEngineCodec("VP9").ToCodecParameters(),
7226 rtp_parameters.codecs[1]);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007227}
7228
Florent Castellidacec712018-05-24 16:24:21 +02007229// Test that GetRtpSendParameters returns the currently configured RTCP CNAME.
7230TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersRtcpCname) {
7231 StreamParams params = StreamParams::CreateLegacy(kSsrc);
7232 params.cname = "rtcpcname";
7233 AddSendStream(params);
7234
7235 webrtc::RtpParameters rtp_parameters = channel_->GetRtpSendParameters(kSsrc);
7236 EXPECT_STREQ("rtcpcname", rtp_parameters.rtcp.cname.c_str());
7237}
7238
deadbeeffb2aced2017-01-06 23:05:37 -08007239// Test that RtpParameters for send stream has one encoding and it has
7240// the correct SSRC.
eladalonf1841382017-06-12 01:16:46 -07007241TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersSsrc) {
deadbeeffb2aced2017-01-06 23:05:37 -08007242 AddSendStream();
7243
7244 webrtc::RtpParameters rtp_parameters =
7245 channel_->GetRtpSendParameters(last_ssrc_);
7246 ASSERT_EQ(1u, rtp_parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01007247 EXPECT_EQ(last_ssrc_, rtp_parameters.encodings[0].ssrc);
deadbeeffb2aced2017-01-06 23:05:37 -08007248}
7249
Florent Castelliabe301f2018-06-12 18:33:49 +02007250TEST_F(WebRtcVideoChannelTest, DetectRtpSendParameterHeaderExtensionsChange) {
7251 AddSendStream();
7252
7253 webrtc::RtpParameters rtp_parameters =
7254 channel_->GetRtpSendParameters(last_ssrc_);
7255 rtp_parameters.header_extensions.emplace_back();
7256
7257 EXPECT_NE(0u, rtp_parameters.header_extensions.size());
7258
7259 webrtc::RTCError result =
7260 channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
7261 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION, result.type());
7262}
7263
Florent Castelli87b3c512018-07-18 16:00:28 +02007264TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersDegradationPreference) {
7265 AddSendStream();
7266
Niels Möller805a27e2019-01-21 12:21:27 +01007267 webrtc::test::FrameForwarder frame_forwarder;
7268 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Florent Castelli87b3c512018-07-18 16:00:28 +02007269
7270 webrtc::RtpParameters rtp_parameters =
7271 channel_->GetRtpSendParameters(last_ssrc_);
7272 EXPECT_EQ(rtp_parameters.degradation_preference,
7273 webrtc::DegradationPreference::BALANCED);
7274 rtp_parameters.degradation_preference =
7275 webrtc::DegradationPreference::MAINTAIN_FRAMERATE;
7276
7277 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters).ok());
7278
7279 webrtc::RtpParameters updated_rtp_parameters =
7280 channel_->GetRtpSendParameters(last_ssrc_);
7281 EXPECT_EQ(updated_rtp_parameters.degradation_preference,
7282 webrtc::DegradationPreference::MAINTAIN_FRAMERATE);
7283
7284 // Remove the source since it will be destroyed before the channel
7285 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
7286}
7287
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007288// Test that if we set/get parameters multiple times, we get the same results.
eladalonf1841382017-06-12 01:16:46 -07007289TEST_F(WebRtcVideoChannelTest, SetAndGetRtpSendParameters) {
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007290 AddSendStream();
7291 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08007292 parameters.codecs.push_back(GetEngineCodec("VP8"));
7293 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007294 EXPECT_TRUE(channel_->SetSendParameters(parameters));
7295
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007296 webrtc::RtpParameters initial_params =
7297 channel_->GetRtpSendParameters(last_ssrc_);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007298
7299 // We should be able to set the params we just got.
Zach Steinba37b4b2018-01-23 15:02:36 -08007300 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, initial_params).ok());
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007301
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007302 // ... And this shouldn't change the params returned by GetRtpSendParameters.
7303 EXPECT_EQ(initial_params, channel_->GetRtpSendParameters(last_ssrc_));
7304}
7305
7306// Test that GetRtpReceiveParameters returns the currently configured codecs.
eladalonf1841382017-06-12 01:16:46 -07007307TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersCodecs) {
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007308 AddRecvStream();
7309 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08007310 parameters.codecs.push_back(GetEngineCodec("VP8"));
7311 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007312 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
7313
7314 webrtc::RtpParameters rtp_parameters =
7315 channel_->GetRtpReceiveParameters(last_ssrc_);
7316 ASSERT_EQ(2u, rtp_parameters.codecs.size());
magjed509e4fe2016-11-18 01:34:11 -08007317 EXPECT_EQ(GetEngineCodec("VP8").ToCodecParameters(),
7318 rtp_parameters.codecs[0]);
7319 EXPECT_EQ(GetEngineCodec("VP9").ToCodecParameters(),
7320 rtp_parameters.codecs[1]);
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007321}
7322
johan073ece42016-08-26 02:59:47 -07007323#if defined(WEBRTC_USE_H264)
eladalonf1841382017-06-12 01:16:46 -07007324TEST_F(WebRtcVideoChannelTest, GetRtpReceiveFmtpSprop) {
johan073ece42016-08-26 02:59:47 -07007325#else
eladalonf1841382017-06-12 01:16:46 -07007326TEST_F(WebRtcVideoChannelTest, DISABLED_GetRtpReceiveFmtpSprop) {
johan073ece42016-08-26 02:59:47 -07007327#endif
johan3859c892016-08-05 09:19:25 -07007328 cricket::VideoRecvParameters parameters;
perkj26752742016-10-24 01:21:16 -07007329 cricket::VideoCodec kH264sprop1(101, "H264");
magjed5dfac562016-11-25 03:56:37 -08007330 kH264sprop1.SetParam(kH264FmtpSpropParameterSets, "uvw");
johan3859c892016-08-05 09:19:25 -07007331 parameters.codecs.push_back(kH264sprop1);
perkj26752742016-10-24 01:21:16 -07007332 cricket::VideoCodec kH264sprop2(102, "H264");
magjed5dfac562016-11-25 03:56:37 -08007333 kH264sprop2.SetParam(kH264FmtpSpropParameterSets, "xyz");
johan3859c892016-08-05 09:19:25 -07007334 parameters.codecs.push_back(kH264sprop2);
7335 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
7336
7337 FakeVideoReceiveStream* recv_stream = AddRecvStream();
7338 const webrtc::VideoReceiveStream::Config& cfg = recv_stream->GetConfig();
7339 webrtc::RtpParameters rtp_parameters =
7340 channel_->GetRtpReceiveParameters(last_ssrc_);
7341 ASSERT_EQ(2u, rtp_parameters.codecs.size());
7342 EXPECT_EQ(kH264sprop1.ToCodecParameters(), rtp_parameters.codecs[0]);
7343 ASSERT_EQ(2u, cfg.decoders.size());
7344 EXPECT_EQ(101, cfg.decoders[0].payload_type);
Niels Möllercb7e1d22018-09-11 15:56:04 +02007345 EXPECT_EQ("H264", cfg.decoders[0].video_format.name);
magjed5dfac562016-11-25 03:56:37 -08007346 const auto it0 =
Niels Möllercb7e1d22018-09-11 15:56:04 +02007347 cfg.decoders[0].video_format.parameters.find(kH264FmtpSpropParameterSets);
7348 ASSERT_TRUE(it0 != cfg.decoders[0].video_format.parameters.end());
magjed5dfac562016-11-25 03:56:37 -08007349 EXPECT_EQ("uvw", it0->second);
johan3859c892016-08-05 09:19:25 -07007350
7351 EXPECT_EQ(102, cfg.decoders[1].payload_type);
Niels Möllercb7e1d22018-09-11 15:56:04 +02007352 EXPECT_EQ("H264", cfg.decoders[1].video_format.name);
magjed5dfac562016-11-25 03:56:37 -08007353 const auto it1 =
Niels Möllercb7e1d22018-09-11 15:56:04 +02007354 cfg.decoders[1].video_format.parameters.find(kH264FmtpSpropParameterSets);
7355 ASSERT_TRUE(it1 != cfg.decoders[1].video_format.parameters.end());
magjed5dfac562016-11-25 03:56:37 -08007356 EXPECT_EQ("xyz", it1->second);
johan3859c892016-08-05 09:19:25 -07007357}
7358
sakal1fd95952016-06-22 00:46:15 -07007359// Test that RtpParameters for receive stream has one encoding and it has
7360// the correct SSRC.
eladalonf1841382017-06-12 01:16:46 -07007361TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersSsrc) {
sakal1fd95952016-06-22 00:46:15 -07007362 AddRecvStream();
7363
7364 webrtc::RtpParameters rtp_parameters =
7365 channel_->GetRtpReceiveParameters(last_ssrc_);
7366 ASSERT_EQ(1u, rtp_parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01007367 EXPECT_EQ(last_ssrc_, rtp_parameters.encodings[0].ssrc);
sakal1fd95952016-06-22 00:46:15 -07007368}
7369
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007370// Test that if we set/get parameters multiple times, we get the same results.
eladalonf1841382017-06-12 01:16:46 -07007371TEST_F(WebRtcVideoChannelTest, SetAndGetRtpReceiveParameters) {
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007372 AddRecvStream();
7373 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08007374 parameters.codecs.push_back(GetEngineCodec("VP8"));
7375 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007376 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
7377
7378 webrtc::RtpParameters initial_params =
7379 channel_->GetRtpReceiveParameters(last_ssrc_);
7380
7381 // We should be able to set the params we just got.
7382 EXPECT_TRUE(channel_->SetRtpReceiveParameters(last_ssrc_, initial_params));
7383
7384 // ... And this shouldn't change the params returned by
7385 // GetRtpReceiveParameters.
7386 EXPECT_EQ(initial_params, channel_->GetRtpReceiveParameters(last_ssrc_));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007387}
7388
deadbeef3bc15102017-04-20 19:25:07 -07007389// Test that GetRtpReceiveParameters returns parameters correctly when SSRCs
7390// aren't signaled. It should always return an empty "RtpEncodingParameters",
7391// even after a packet is received and the unsignaled SSRC is known.
eladalonf1841382017-06-12 01:16:46 -07007392TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersWithUnsignaledSsrc) {
deadbeef3bc15102017-04-20 19:25:07 -07007393 // Call necessary methods to configure receiving a default stream as
7394 // soon as it arrives.
7395 cricket::VideoRecvParameters parameters;
7396 parameters.codecs.push_back(GetEngineCodec("VP8"));
7397 parameters.codecs.push_back(GetEngineCodec("VP9"));
7398 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
7399
7400 // Call GetRtpReceiveParameters before configured to receive an unsignaled
7401 // stream. Should return nothing.
7402 EXPECT_EQ(webrtc::RtpParameters(), channel_->GetRtpReceiveParameters(0));
7403
7404 // Set a sink for an unsignaled stream.
7405 cricket::FakeVideoRenderer renderer;
7406 // Value of "0" means "unsignaled stream".
7407 EXPECT_TRUE(channel_->SetSink(0, &renderer));
7408
7409 // Call GetRtpReceiveParameters before the SSRC is known. Value of "0"
7410 // in this method means "unsignaled stream".
7411 webrtc::RtpParameters rtp_parameters = channel_->GetRtpReceiveParameters(0);
7412 ASSERT_EQ(1u, rtp_parameters.encodings.size());
7413 EXPECT_FALSE(rtp_parameters.encodings[0].ssrc);
7414
7415 // Receive VP8 packet.
7416 uint8_t data[kMinRtpPacketLen];
7417 cricket::RtpHeader rtpHeader;
7418 rtpHeader.payload_type = GetEngineCodec("VP8").id;
7419 rtpHeader.seq_num = rtpHeader.timestamp = 0;
7420 rtpHeader.ssrc = kIncomingUnsignalledSsrc;
7421 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
7422 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07007423 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
deadbeef3bc15102017-04-20 19:25:07 -07007424
7425 // The |ssrc| member should still be unset.
7426 rtp_parameters = channel_->GetRtpReceiveParameters(0);
7427 ASSERT_EQ(1u, rtp_parameters.encodings.size());
7428 EXPECT_FALSE(rtp_parameters.encodings[0].ssrc);
7429}
7430
eladalonf1841382017-06-12 01:16:46 -07007431void WebRtcVideoChannelTest::TestReceiverLocalSsrcConfiguration(
Peter Boström3548dd22015-05-22 18:48:36 +02007432 bool receiver_first) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02007433 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boström3548dd22015-05-22 18:48:36 +02007434
7435 const uint32_t kSenderSsrc = 0xC0FFEE;
Peter Boströmdfa28152015-10-21 17:21:10 +02007436 const uint32_t kSecondSenderSsrc = 0xBADCAFE;
Peter Boström3548dd22015-05-22 18:48:36 +02007437 const uint32_t kReceiverSsrc = 0x4711;
Peter Boströmdfa28152015-10-21 17:21:10 +02007438 const uint32_t kExpectedDefaultReceiverSsrc = 1;
Peter Boström3548dd22015-05-22 18:48:36 +02007439
7440 if (receiver_first) {
7441 AddRecvStream(StreamParams::CreateLegacy(kReceiverSsrc));
7442 std::vector<FakeVideoReceiveStream*> receive_streams =
7443 fake_call_->GetVideoReceiveStreams();
7444 ASSERT_EQ(1u, receive_streams.size());
Peter Boströmdfa28152015-10-21 17:21:10 +02007445 // Default local SSRC when we have no sender.
7446 EXPECT_EQ(kExpectedDefaultReceiverSsrc,
7447 receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boström3548dd22015-05-22 18:48:36 +02007448 }
7449 AddSendStream(StreamParams::CreateLegacy(kSenderSsrc));
7450 if (!receiver_first)
7451 AddRecvStream(StreamParams::CreateLegacy(kReceiverSsrc));
7452 std::vector<FakeVideoReceiveStream*> receive_streams =
7453 fake_call_->GetVideoReceiveStreams();
7454 ASSERT_EQ(1u, receive_streams.size());
7455 EXPECT_EQ(kSenderSsrc, receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boströmdfa28152015-10-21 17:21:10 +02007456
7457 // Removing first sender should fall back to another (in this case the second)
7458 // local send stream's SSRC.
7459 AddSendStream(StreamParams::CreateLegacy(kSecondSenderSsrc));
7460 ASSERT_TRUE(channel_->RemoveSendStream(kSenderSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02007461 receive_streams = fake_call_->GetVideoReceiveStreams();
Peter Boströmdfa28152015-10-21 17:21:10 +02007462 ASSERT_EQ(1u, receive_streams.size());
7463 EXPECT_EQ(kSecondSenderSsrc, receive_streams[0]->GetConfig().rtp.local_ssrc);
7464
7465 // Removing the last sender should fall back to default local SSRC.
7466 ASSERT_TRUE(channel_->RemoveSendStream(kSecondSenderSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02007467 receive_streams = fake_call_->GetVideoReceiveStreams();
Peter Boströmdfa28152015-10-21 17:21:10 +02007468 ASSERT_EQ(1u, receive_streams.size());
7469 EXPECT_EQ(kExpectedDefaultReceiverSsrc,
7470 receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boström3548dd22015-05-22 18:48:36 +02007471}
7472
eladalonf1841382017-06-12 01:16:46 -07007473TEST_F(WebRtcVideoChannelTest, ConfiguresLocalSsrc) {
Peter Boström3548dd22015-05-22 18:48:36 +02007474 TestReceiverLocalSsrcConfiguration(false);
7475}
7476
eladalonf1841382017-06-12 01:16:46 -07007477TEST_F(WebRtcVideoChannelTest, ConfiguresLocalSsrcOnExistingReceivers) {
Peter Boström3548dd22015-05-22 18:48:36 +02007478 TestReceiverLocalSsrcConfiguration(true);
7479}
7480
Mirko Bonadei6a489f22019-04-09 15:11:12 +02007481class WebRtcVideoChannelSimulcastTest : public ::testing::Test {
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007482 public:
eladalonf1841382017-06-12 01:16:46 -07007483 WebRtcVideoChannelSimulcastTest()
Sebastian Jansson8f83b422018-02-21 13:07:13 +01007484 : fake_call_(),
Magnus Jedvert02e7a192017-09-23 17:21:32 +02007485 encoder_factory_(new cricket::FakeWebRtcVideoEncoderFactory),
7486 decoder_factory_(new cricket::FakeWebRtcVideoDecoderFactory),
Jiawei Ouc2ebe212018-11-08 10:02:56 -08007487 mock_rate_allocator_factory_(
Mirko Bonadei317a1f02019-09-17 17:06:18 +02007488 std::make_unique<webrtc::MockVideoBitrateAllocatorFactory>()),
Anders Carlsson67537952018-05-03 11:28:29 +02007489 engine_(std::unique_ptr<cricket::FakeWebRtcVideoEncoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +02007490 encoder_factory_),
Anders Carlsson67537952018-05-03 11:28:29 +02007491 std::unique_ptr<cricket::FakeWebRtcVideoDecoderFactory>(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02007492 decoder_factory_)),
magjed2475ae22017-09-12 04:42:15 -07007493 last_ssrc_(0) {}
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007494
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00007495 void SetUp() override {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02007496 encoder_factory_->AddSupportedVideoCodecType("VP8");
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02007497 channel_.reset(engine_.CreateMediaChannel(
7498 &fake_call_, GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
7499 mock_rate_allocator_factory_.get()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08007500 channel_->OnReadyToSend(true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007501 last_ssrc_ = 123;
7502 }
7503
7504 protected:
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007505 void VerifySimulcastSettings(const VideoCodec& codec,
perkj26752742016-10-24 01:21:16 -07007506 int capture_width,
7507 int capture_height,
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007508 size_t num_configured_streams,
sprang429600d2017-01-26 06:12:26 -08007509 size_t expected_num_streams,
7510 bool screenshare,
7511 bool conference_mode) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02007512 cricket::VideoSendParameters parameters;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02007513 parameters.codecs.push_back(codec);
sprang429600d2017-01-26 06:12:26 -08007514 parameters.conference_mode = conference_mode;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02007515 ASSERT_TRUE(channel_->SetSendParameters(parameters));
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007516
Peter Boström0c4e06b2015-10-07 12:23:21 +02007517 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
henrikg91d6ede2015-09-17 00:24:34 -07007518 RTC_DCHECK(num_configured_streams <= ssrcs.size());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007519 ssrcs.resize(num_configured_streams);
7520
sprangf24a0642017-02-28 13:23:26 -08007521 AddSendStream(CreateSimStreamParams("cname", ssrcs));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00007522 // Send a full-size frame to trigger a stream reconfiguration to use all
7523 // expected simulcast layers.
Niels Möller805a27e2019-01-21 12:21:27 +01007524 webrtc::test::FrameForwarder frame_forwarder;
7525 cricket::FakeFrameSource frame_source(capture_width, capture_height,
7526 rtc::kNumMicrosecsPerSec / 30);
7527
sprangf24a0642017-02-28 13:23:26 -08007528 VideoOptions options;
7529 if (screenshare)
Oskar Sundbom78807582017-11-16 11:09:55 +01007530 options.is_screencast = screenshare;
Niels Möller805a27e2019-01-21 12:21:27 +01007531 EXPECT_TRUE(
7532 channel_->SetVideoSend(ssrcs.front(), &options, &frame_forwarder));
sprangf24a0642017-02-28 13:23:26 -08007533 // Fetch the latest stream since SetVideoSend() may recreate it if the
7534 // screen content setting is changed.
7535 FakeVideoSendStream* stream = fake_call_.GetVideoSendStreams().front();
pbos@webrtc.org86196c42015-02-16 21:02:00 +00007536 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01007537 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007538
Zach Stein3ca452b2018-01-18 10:01:24 -08007539 auto rtp_parameters = channel_->GetRtpSendParameters(kSsrcs3[0]);
7540 EXPECT_EQ(num_configured_streams, rtp_parameters.encodings.size());
7541
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007542 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
7543 ASSERT_EQ(expected_num_streams, video_streams.size());
Ilya Nikolaevskiy33d2a912019-04-02 11:05:03 +02007544 EXPECT_LE(expected_num_streams, stream->GetConfig().rtp.ssrcs.size());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007545
sprang429600d2017-01-26 06:12:26 -08007546 std::vector<webrtc::VideoStream> expected_streams;
Florent Castelli66b38602019-07-10 16:57:57 +02007547 if (num_configured_streams > 1 || conference_mode) {
sprang429600d2017-01-26 06:12:26 -08007548 expected_streams = GetSimulcastConfig(
Florent Castelli668ce0c2019-07-04 17:06:04 +02007549 num_configured_streams, capture_width, capture_height,
Florent Castelli66b38602019-07-10 16:57:57 +02007550 webrtc::kDefaultBitratePriority, kDefaultQpMax,
7551 screenshare && conference_mode, true);
7552 if (screenshare && conference_mode) {
sprang3ebabf12017-02-16 07:35:22 -08007553 for (const webrtc::VideoStream& stream : expected_streams) {
7554 // Never scale screen content.
Danil Chapovalov350531e2018-06-08 11:04:04 +00007555 EXPECT_EQ(stream.width, rtc::checked_cast<size_t>(capture_width));
7556 EXPECT_EQ(stream.height, rtc::checked_cast<size_t>(capture_height));
sprang3ebabf12017-02-16 07:35:22 -08007557 }
7558 }
sprang429600d2017-01-26 06:12:26 -08007559 } else {
7560 webrtc::VideoStream stream;
7561 stream.width = capture_width;
7562 stream.height = capture_height;
7563 stream.max_framerate = kDefaultVideoMaxFramerate;
Elad Alon80f53b72019-10-11 16:19:43 +02007564 stream.min_bitrate_bps = webrtc::kDefaultMinVideoBitrateBps;
sprang429600d2017-01-26 06:12:26 -08007565 stream.target_bitrate_bps = stream.max_bitrate_bps =
Åsa Perssonbdee46d2018-06-25 11:28:06 +02007566 GetMaxDefaultBitrateBps(capture_width, capture_height);
sprang429600d2017-01-26 06:12:26 -08007567 stream.max_qp = kDefaultQpMax;
7568 expected_streams.push_back(stream);
7569 }
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007570
7571 ASSERT_EQ(expected_streams.size(), video_streams.size());
7572
7573 size_t num_streams = video_streams.size();
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00007574 int total_max_bitrate_bps = 0;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007575 for (size_t i = 0; i < num_streams; ++i) {
7576 EXPECT_EQ(expected_streams[i].width, video_streams[i].width);
7577 EXPECT_EQ(expected_streams[i].height, video_streams[i].height);
7578
7579 EXPECT_GT(video_streams[i].max_framerate, 0);
7580 EXPECT_EQ(expected_streams[i].max_framerate,
7581 video_streams[i].max_framerate);
7582
7583 EXPECT_GT(video_streams[i].min_bitrate_bps, 0);
7584 EXPECT_EQ(expected_streams[i].min_bitrate_bps,
7585 video_streams[i].min_bitrate_bps);
7586
7587 EXPECT_GT(video_streams[i].target_bitrate_bps, 0);
7588 EXPECT_EQ(expected_streams[i].target_bitrate_bps,
7589 video_streams[i].target_bitrate_bps);
7590
7591 EXPECT_GT(video_streams[i].max_bitrate_bps, 0);
7592 EXPECT_EQ(expected_streams[i].max_bitrate_bps,
7593 video_streams[i].max_bitrate_bps);
7594
7595 EXPECT_GT(video_streams[i].max_qp, 0);
7596 EXPECT_EQ(expected_streams[i].max_qp, video_streams[i].max_qp);
7597
Florent Castelli66b38602019-07-10 16:57:57 +02007598 EXPECT_EQ(num_configured_streams > 1 || conference_mode,
Sergey Silkina796a7e2018-03-01 15:11:29 +01007599 expected_streams[i].num_temporal_layers.has_value());
7600
7601 if (conference_mode) {
7602 EXPECT_EQ(expected_streams[i].num_temporal_layers,
7603 video_streams[i].num_temporal_layers);
7604 }
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00007605
7606 if (i == num_streams - 1) {
7607 total_max_bitrate_bps += video_streams[i].max_bitrate_bps;
7608 } else {
7609 total_max_bitrate_bps += video_streams[i].target_bitrate_bps;
7610 }
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007611 }
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00007612
Niels Möllerff40b142018-04-09 08:49:14 +02007613 EXPECT_TRUE(channel_->SetVideoSend(ssrcs.front(), nullptr, nullptr));
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007614 }
7615
7616 FakeVideoSendStream* AddSendStream() {
7617 return AddSendStream(StreamParams::CreateLegacy(last_ssrc_++));
7618 }
7619
7620 FakeVideoSendStream* AddSendStream(const StreamParams& sp) {
Yves Gerey665174f2018-06-19 15:03:05 +02007621 size_t num_streams = fake_call_.GetVideoSendStreams().size();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007622 EXPECT_TRUE(channel_->AddSendStream(sp));
7623 std::vector<FakeVideoSendStream*> streams =
Fredrik Solenberg709ed672015-09-15 12:26:33 +02007624 fake_call_.GetVideoSendStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007625 EXPECT_EQ(num_streams + 1, streams.size());
7626 return streams[streams.size() - 1];
7627 }
7628
7629 std::vector<FakeVideoSendStream*> GetFakeSendStreams() {
Fredrik Solenberg709ed672015-09-15 12:26:33 +02007630 return fake_call_.GetVideoSendStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007631 }
7632
7633 FakeVideoReceiveStream* AddRecvStream() {
7634 return AddRecvStream(StreamParams::CreateLegacy(last_ssrc_++));
7635 }
7636
7637 FakeVideoReceiveStream* AddRecvStream(const StreamParams& sp) {
Yves Gerey665174f2018-06-19 15:03:05 +02007638 size_t num_streams = fake_call_.GetVideoReceiveStreams().size();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007639 EXPECT_TRUE(channel_->AddRecvStream(sp));
7640 std::vector<FakeVideoReceiveStream*> streams =
Fredrik Solenberg709ed672015-09-15 12:26:33 +02007641 fake_call_.GetVideoReceiveStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007642 EXPECT_EQ(num_streams + 1, streams.size());
7643 return streams[streams.size() - 1];
7644 }
7645
Danil Chapovalov83bbe912019-08-07 12:24:53 +02007646 webrtc::RtcEventLogNull event_log_;
Fredrik Solenberg709ed672015-09-15 12:26:33 +02007647 FakeCall fake_call_;
Magnus Jedvert02e7a192017-09-23 17:21:32 +02007648 cricket::FakeWebRtcVideoEncoderFactory* encoder_factory_;
7649 cricket::FakeWebRtcVideoDecoderFactory* decoder_factory_;
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02007650 std::unique_ptr<webrtc::MockVideoBitrateAllocatorFactory>
7651 mock_rate_allocator_factory_;
eladalonf1841382017-06-12 01:16:46 -07007652 WebRtcVideoEngine engine_;
kwiberg686a8ef2016-02-26 03:00:35 -08007653 std::unique_ptr<VideoMediaChannel> channel_;
Peter Boström0c4e06b2015-10-07 12:23:21 +02007654 uint32_t last_ssrc_;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007655};
7656
eladalonf1841382017-06-12 01:16:46 -07007657TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWith2SimulcastStreams) {
sprang429600d2017-01-26 06:12:26 -08007658 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 640, 360, 2, 2, false,
7659 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007660}
7661
eladalonf1841382017-06-12 01:16:46 -07007662TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWith3SimulcastStreams) {
sprang429600d2017-01-26 06:12:26 -08007663 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 3, false,
7664 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007665}
7666
7667// Test that we normalize send codec format size in simulcast.
eladalonf1841382017-06-12 01:16:46 -07007668TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWithOddSizeInSimulcast) {
sprang429600d2017-01-26 06:12:26 -08007669 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 541, 271, 2, 2, false,
7670 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007671}
sprang429600d2017-01-26 06:12:26 -08007672
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02007673TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsForScreenshare) {
Florent Castelli66b38602019-07-10 16:57:57 +02007674 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 3, true,
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02007675 false);
7676}
7677
eladalonf1841382017-06-12 01:16:46 -07007678TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsForSimulcastScreenshare) {
sprang429600d2017-01-26 06:12:26 -08007679 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 2, true,
7680 true);
7681}
7682
Florent Castelli66b38602019-07-10 16:57:57 +02007683TEST_F(WebRtcVideoChannelSimulcastTest, SimulcastScreenshareWithoutConference) {
7684 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 3, true,
sprangfe627f32017-03-29 08:24:59 -07007685 false);
7686}
7687
Chen Xing90f3b892019-06-25 10:16:14 +02007688TEST_F(WebRtcVideoChannelBaseTest, GetSources) {
7689 EXPECT_THAT(channel_->GetSources(kSsrc), IsEmpty());
Jonas Oreland49ac5952018-09-26 16:04:32 +02007690
Chen Xing90f3b892019-06-25 10:16:14 +02007691 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
Jonas Oreland49ac5952018-09-26 16:04:32 +02007692 EXPECT_TRUE(SetDefaultCodec());
7693 EXPECT_TRUE(SetSend(true));
Chen Xing90f3b892019-06-25 10:16:14 +02007694 EXPECT_EQ(renderer_.num_rendered_frames(), 0);
Jonas Oreland49ac5952018-09-26 16:04:32 +02007695
Chen Xing90f3b892019-06-25 10:16:14 +02007696 // Send and receive one frame.
7697 SendFrame();
7698 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
Jonas Oreland49ac5952018-09-26 16:04:32 +02007699
Chen Xing90f3b892019-06-25 10:16:14 +02007700 EXPECT_THAT(channel_->GetSources(kSsrc - 1), IsEmpty());
7701 EXPECT_THAT(channel_->GetSources(kSsrc), SizeIs(1));
7702 EXPECT_THAT(channel_->GetSources(kSsrc + 1), IsEmpty());
Jonas Oreland49ac5952018-09-26 16:04:32 +02007703
Chen Xing90f3b892019-06-25 10:16:14 +02007704 webrtc::RtpSource source = channel_->GetSources(kSsrc)[0];
7705 EXPECT_EQ(source.source_id(), kSsrc);
7706 EXPECT_EQ(source.source_type(), webrtc::RtpSourceType::SSRC);
7707 int64_t rtp_timestamp_1 = source.rtp_timestamp();
7708 int64_t timestamp_ms_1 = source.timestamp_ms();
Jonas Oreland49ac5952018-09-26 16:04:32 +02007709
Chen Xing90f3b892019-06-25 10:16:14 +02007710 // Send and receive another frame.
7711 SendFrame();
7712 EXPECT_FRAME_WAIT(2, kVideoWidth, kVideoHeight, kTimeout);
Jonas Oreland49ac5952018-09-26 16:04:32 +02007713
Chen Xing90f3b892019-06-25 10:16:14 +02007714 EXPECT_THAT(channel_->GetSources(kSsrc - 1), IsEmpty());
7715 EXPECT_THAT(channel_->GetSources(kSsrc), SizeIs(1));
7716 EXPECT_THAT(channel_->GetSources(kSsrc + 1), IsEmpty());
Jonas Oreland49ac5952018-09-26 16:04:32 +02007717
Chen Xing90f3b892019-06-25 10:16:14 +02007718 source = channel_->GetSources(kSsrc)[0];
7719 EXPECT_EQ(source.source_id(), kSsrc);
7720 EXPECT_EQ(source.source_type(), webrtc::RtpSourceType::SSRC);
7721 int64_t rtp_timestamp_2 = source.rtp_timestamp();
7722 int64_t timestamp_ms_2 = source.timestamp_ms();
Jonas Oreland49ac5952018-09-26 16:04:32 +02007723
Chen Xing90f3b892019-06-25 10:16:14 +02007724 EXPECT_GT(rtp_timestamp_2, rtp_timestamp_1);
7725 EXPECT_GT(timestamp_ms_2, timestamp_ms_1);
Jonas Oreland49ac5952018-09-26 16:04:32 +02007726}
7727
Amit Hilbuchb000b712019-02-25 10:22:14 -08007728TEST_F(WebRtcVideoChannelTest, SetsRidsOnSendStream) {
7729 StreamParams sp = CreateSimStreamParams("cname", {123, 456, 789});
7730
7731 std::vector<std::string> rids = {"f", "h", "q"};
7732 std::vector<cricket::RidDescription> rid_descriptions;
7733 for (const auto& rid : rids) {
7734 rid_descriptions.emplace_back(rid, cricket::RidDirection::kSend);
7735 }
7736 sp.set_rids(rid_descriptions);
7737
7738 ASSERT_TRUE(channel_->AddSendStream(sp));
7739 const auto& streams = fake_call_->GetVideoSendStreams();
7740 ASSERT_EQ(1u, streams.size());
7741 auto stream = streams[0];
7742 ASSERT_NE(stream, nullptr);
7743 const auto& config = stream->GetConfig();
7744 EXPECT_THAT(config.rtp.rids, ::testing::ElementsAreArray(rids));
7745}
7746
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00007747} // namespace cricket