blob: 7b039627668d6beda975e6a45335ace3b57bbaea [file] [log] [blame]
maruel@chromium.org725f1c32011-04-01 20:24:54 +00001#!/usr/bin/env python
maruel@chromium.org3bbf2942012-01-10 16:52:06 +00002# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
6"""Enables directory-specific presubmit checks to run at upload and/or commit.
7"""
8
Raul Tambre80ee78e2019-05-06 22:41:05 +00009from __future__ import print_function
10
Saagar Sanghavi99816902020-08-11 22:41:25 +000011__version__ = '2.0.0'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000012
13# TODO(joi) Add caching where appropriate/needed. The API is designed to allow
14# caching (between all different invocations of presubmit scripts for a given
15# change). We should add it as our presubmit scripts start feeling slow.
16
Edward Lemura5799e32020-01-17 19:26:51 +000017import argparse
Takeshi Yoshino07a6bea2017-08-02 02:44:06 +090018import ast # Exposed through the API.
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +000019import contextlib
Yoshisato Yanagisawa406de132018-06-29 05:43:25 +000020import cpplint
dcheng091b7db2016-06-16 01:27:51 -070021import fnmatch # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000022import glob
asvitkine@chromium.org15169952011-09-27 14:30:53 +000023import inspect
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +000024import itertools
maruel@chromium.org4f6852c2012-04-20 20:39:20 +000025import json # Exposed through the API.
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +000026import logging
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000027import multiprocessing
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000028import os # Somewhat exposed through the API.
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000029import random
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000030import re # Exposed through the API.
Edward Lesmes8e282792018-04-03 18:50:29 -040031import signal
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000032import sys # Parts exposed through API.
33import tempfile # Exposed through the API.
Edward Lesmes8e282792018-04-03 18:50:29 -040034import threading
jam@chromium.org2a891dc2009-08-20 20:33:37 +000035import time
Edward Lemurde9e3ca2019-10-24 21:13:31 +000036import traceback
maruel@chromium.org1487d532009-06-06 00:22:57 +000037import unittest # Exposed through the API.
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000038from warnings import warn
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000039
40# Local imports.
maruel@chromium.org35625c72011-03-23 17:34:02 +000041import fix_encoding
Yoshisato Yanagisawa04600b42019-03-15 03:03:41 +000042import gclient_paths # Exposed through the API
43import gclient_utils
Aaron Gableb584c4f2017-04-26 16:28:08 -070044import git_footers
tandrii@chromium.org015ebae2016-04-25 19:37:22 +000045import gerrit_util
Edward Lesmes9ce03f82021-01-12 20:13:31 +000046import owners as owners_db
47import owners_client
Jochen Eisinger76f5fc62017-04-07 16:27:46 +020048import owners_finder
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000049import presubmit_canned_checks
Saagar Sanghavi9949ab72020-07-20 20:56:40 +000050import rdb_wrapper
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +000051import scm
maruel@chromium.org84f4fe32011-04-06 13:26:45 +000052import subprocess2 as subprocess # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000053
Edward Lemur16af3562019-10-17 22:11:33 +000054if sys.version_info.major == 2:
55 # TODO(1009814): Expose urllib2 only through urllib_request and urllib_error
56 import urllib2 # Exposed through the API.
57 import urlparse
58 import urllib2 as urllib_request
59 import urllib2 as urllib_error
60else:
61 import urllib.parse as urlparse
62 import urllib.request as urllib_request
63 import urllib.error as urllib_error
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000064
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000065# Ask for feedback only once in program lifetime.
66_ASKED_FOR_FEEDBACK = False
67
Edward Lemurecc27072020-01-06 16:42:34 +000068def time_time():
69 # Use this so that it can be mocked in tests without interfering with python
70 # system machinery.
71 return time.time()
72
73
maruel@chromium.org899e1c12011-04-07 17:03:18 +000074class PresubmitFailure(Exception):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000075 pass
76
77
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000078class CommandData(object):
Edward Lemur940c2822019-08-23 00:34:25 +000079 def __init__(self, name, cmd, kwargs, message, python3=False):
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000080 self.name = name
81 self.cmd = cmd
Edward Lesmes8e282792018-04-03 18:50:29 -040082 self.stdin = kwargs.get('stdin', None)
Edward Lemur2d6b67c2019-08-23 22:25:41 +000083 self.kwargs = kwargs.copy()
Edward Lesmes8e282792018-04-03 18:50:29 -040084 self.kwargs['stdout'] = subprocess.PIPE
85 self.kwargs['stderr'] = subprocess.STDOUT
86 self.kwargs['stdin'] = subprocess.PIPE
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000087 self.message = message
88 self.info = None
Edward Lemur940c2822019-08-23 00:34:25 +000089 self.python3 = python3
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000090
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000091
Edward Lesmes8e282792018-04-03 18:50:29 -040092# Adapted from
93# https://github.com/google/gtest-parallel/blob/master/gtest_parallel.py#L37
94#
95# An object that catches SIGINT sent to the Python process and notices
96# if processes passed to wait() die by SIGINT (we need to look for
97# both of those cases, because pressing Ctrl+C can result in either
98# the main process or one of the subprocesses getting the signal).
99#
100# Before a SIGINT is seen, wait(p) will simply call p.wait() and
101# return the result. Once a SIGINT has been seen (in the main process
102# or a subprocess, including the one the current call is waiting for),
Edward Lemur9a5bb612019-09-26 02:01:52 +0000103# wait(p) will call p.terminate().
Edward Lesmes8e282792018-04-03 18:50:29 -0400104class SigintHandler(object):
Edward Lesmes8e282792018-04-03 18:50:29 -0400105 sigint_returncodes = {-signal.SIGINT, # Unix
106 -1073741510, # Windows
107 }
108 def __init__(self):
109 self.__lock = threading.Lock()
110 self.__processes = set()
111 self.__got_sigint = False
Edward Lemur9a5bb612019-09-26 02:01:52 +0000112 self.__previous_signal = signal.signal(signal.SIGINT, self.interrupt)
Edward Lesmes8e282792018-04-03 18:50:29 -0400113
114 def __on_sigint(self):
115 self.__got_sigint = True
116 while self.__processes:
117 try:
118 self.__processes.pop().terminate()
119 except OSError:
120 pass
121
Edward Lemur9a5bb612019-09-26 02:01:52 +0000122 def interrupt(self, signal_num, frame):
Edward Lesmes8e282792018-04-03 18:50:29 -0400123 with self.__lock:
124 self.__on_sigint()
Edward Lemur9a5bb612019-09-26 02:01:52 +0000125 self.__previous_signal(signal_num, frame)
Edward Lesmes8e282792018-04-03 18:50:29 -0400126
127 def got_sigint(self):
128 with self.__lock:
129 return self.__got_sigint
130
131 def wait(self, p, stdin):
132 with self.__lock:
133 if self.__got_sigint:
134 p.terminate()
135 self.__processes.add(p)
136 stdout, stderr = p.communicate(stdin)
137 code = p.returncode
138 with self.__lock:
139 self.__processes.discard(p)
140 if code in self.sigint_returncodes:
141 self.__on_sigint()
Edward Lesmes8e282792018-04-03 18:50:29 -0400142 return stdout, stderr
143
144sigint_handler = SigintHandler()
145
146
Edward Lemurecc27072020-01-06 16:42:34 +0000147class Timer(object):
148 def __init__(self, timeout, fn):
149 self.completed = False
150 self._fn = fn
151 self._timer = threading.Timer(timeout, self._onTimer) if timeout else None
152
153 def __enter__(self):
154 if self._timer:
155 self._timer.start()
156 return self
157
158 def __exit__(self, _type, _value, _traceback):
159 if self._timer:
160 self._timer.cancel()
161
162 def _onTimer(self):
163 self._fn()
164 self.completed = True
165
166
Edward Lesmes8e282792018-04-03 18:50:29 -0400167class ThreadPool(object):
Edward Lemurecc27072020-01-06 16:42:34 +0000168 def __init__(self, pool_size=None, timeout=None):
169 self.timeout = timeout
Edward Lesmes8e282792018-04-03 18:50:29 -0400170 self._pool_size = pool_size or multiprocessing.cpu_count()
171 self._messages = []
172 self._messages_lock = threading.Lock()
173 self._tests = []
174 self._tests_lock = threading.Lock()
175 self._nonparallel_tests = []
176
Edward Lemurecc27072020-01-06 16:42:34 +0000177 def _GetCommand(self, test):
Edward Lemur940c2822019-08-23 00:34:25 +0000178 vpython = 'vpython'
179 if test.python3:
180 vpython += '3'
181 if sys.platform == 'win32':
182 vpython += '.bat'
Edward Lesmes8e282792018-04-03 18:50:29 -0400183
184 cmd = test.cmd
185 if cmd[0] == 'python':
186 cmd = list(cmd)
187 cmd[0] = vpython
188 elif cmd[0].endswith('.py'):
189 cmd = [vpython] + cmd
190
Edward Lemur336e51f2019-11-14 21:42:04 +0000191 # On Windows, scripts on the current directory take precedence over PATH, so
192 # that when testing depot_tools on Windows, calling `vpython.bat` will
193 # execute the copy of vpython of the depot_tools under test instead of the
194 # one in the bot.
195 # As a workaround, we run the tests from the parent directory instead.
196 if (cmd[0] == vpython and
197 'cwd' in test.kwargs and
198 os.path.basename(test.kwargs['cwd']) == 'depot_tools'):
199 test.kwargs['cwd'] = os.path.dirname(test.kwargs['cwd'])
200 cmd[1] = os.path.join('depot_tools', cmd[1])
201
Edward Lemurecc27072020-01-06 16:42:34 +0000202 return cmd
203
204 def _RunWithTimeout(self, cmd, stdin, kwargs):
205 p = subprocess.Popen(cmd, **kwargs)
206 with Timer(self.timeout, p.terminate) as timer:
207 stdout, _ = sigint_handler.wait(p, stdin)
208 if timer.completed:
209 stdout = 'Process timed out after %ss\n%s' % (self.timeout, stdout)
210 return p.returncode, stdout
211
212 def CallCommand(self, test):
213 """Runs an external program.
214
Edward Lemura5799e32020-01-17 19:26:51 +0000215 This function converts invocation of .py files and invocations of 'python'
Edward Lemurecc27072020-01-06 16:42:34 +0000216 to vpython invocations.
217 """
218 cmd = self._GetCommand(test)
Edward Lesmes8e282792018-04-03 18:50:29 -0400219 try:
Edward Lemurecc27072020-01-06 16:42:34 +0000220 start = time_time()
221 returncode, stdout = self._RunWithTimeout(cmd, test.stdin, test.kwargs)
222 duration = time_time() - start
Edward Lemur7cf94382019-11-15 22:36:41 +0000223 except Exception:
Edward Lemurecc27072020-01-06 16:42:34 +0000224 duration = time_time() - start
Edward Lesmes8e282792018-04-03 18:50:29 -0400225 return test.message(
Edward Lemur7cf94382019-11-15 22:36:41 +0000226 '%s\n%s exec failure (%4.2fs)\n%s' % (
227 test.name, ' '.join(cmd), duration, traceback.format_exc()))
Edward Lemurde9e3ca2019-10-24 21:13:31 +0000228
Edward Lemurecc27072020-01-06 16:42:34 +0000229 if returncode != 0:
Edward Lesmes8e282792018-04-03 18:50:29 -0400230 return test.message(
Edward Lemur7cf94382019-11-15 22:36:41 +0000231 '%s\n%s (%4.2fs) failed\n%s' % (
232 test.name, ' '.join(cmd), duration, stdout))
Edward Lemurecc27072020-01-06 16:42:34 +0000233
Edward Lesmes8e282792018-04-03 18:50:29 -0400234 if test.info:
Edward Lemur7cf94382019-11-15 22:36:41 +0000235 return test.info('%s\n%s (%4.2fs)' % (test.name, ' '.join(cmd), duration))
Edward Lesmes8e282792018-04-03 18:50:29 -0400236
237 def AddTests(self, tests, parallel=True):
238 if parallel:
239 self._tests.extend(tests)
240 else:
241 self._nonparallel_tests.extend(tests)
242
243 def RunAsync(self):
244 self._messages = []
245
246 def _WorkerFn():
247 while True:
248 test = None
249 with self._tests_lock:
250 if not self._tests:
251 break
252 test = self._tests.pop()
253 result = self.CallCommand(test)
254 if result:
255 with self._messages_lock:
256 self._messages.append(result)
257
258 def _StartDaemon():
259 t = threading.Thread(target=_WorkerFn)
260 t.daemon = True
261 t.start()
262 return t
263
264 while self._nonparallel_tests:
265 test = self._nonparallel_tests.pop()
266 result = self.CallCommand(test)
267 if result:
268 self._messages.append(result)
269
270 if self._tests:
271 threads = [_StartDaemon() for _ in range(self._pool_size)]
272 for worker in threads:
273 worker.join()
274
275 return self._messages
276
277
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000278def normpath(path):
279 '''Version of os.path.normpath that also changes backward slashes to
280 forward slashes when not running on Windows.
281 '''
282 # This is safe to always do because the Windows version of os.path.normpath
283 # will replace forward slashes with backward slashes.
284 path = path.replace(os.sep, '/')
285 return os.path.normpath(path)
286
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000287
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000288def _RightHandSideLinesImpl(affected_files):
289 """Implements RightHandSideLines for InputApi and GclChange."""
290 for af in affected_files:
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000291 lines = af.ChangedContents()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000292 for line in lines:
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000293 yield (af, line[0], line[1])
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000294
295
Edward Lemur6eb1d322020-02-27 22:20:15 +0000296def prompt_should_continue(prompt_string):
297 sys.stdout.write(prompt_string)
298 response = sys.stdin.readline().strip().lower()
299 return response in ('y', 'yes')
dpranke@chromium.org5ac21012011-03-16 02:58:25 +0000300
301
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000302# Top level object so multiprocessing can pickle
303# Public access through OutputApi object.
304class _PresubmitResult(object):
305 """Base class for result objects."""
306 fatal = False
307 should_prompt = False
308
309 def __init__(self, message, items=None, long_text=''):
310 """
311 message: A short one-line message to indicate errors.
312 items: A list of short strings to indicate where errors occurred.
313 long_text: multi-line text output, e.g. from another tool
314 """
315 self._message = message
316 self._items = items or []
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000317 self._long_text = long_text.rstrip()
318
Edward Lemur6eb1d322020-02-27 22:20:15 +0000319 def handle(self):
320 sys.stdout.write(self._message)
321 sys.stdout.write('\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000322 for index, item in enumerate(self._items):
Edward Lemur6eb1d322020-02-27 22:20:15 +0000323 sys.stdout.write(' ')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000324 # Write separately in case it's unicode.
Edward Lemur6eb1d322020-02-27 22:20:15 +0000325 sys.stdout.write(str(item))
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000326 if index < len(self._items) - 1:
Edward Lemur6eb1d322020-02-27 22:20:15 +0000327 sys.stdout.write(' \\')
328 sys.stdout.write('\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000329 if self._long_text:
Edward Lemur6eb1d322020-02-27 22:20:15 +0000330 sys.stdout.write('\n***************\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000331 # Write separately in case it's unicode.
Edward Lemur6eb1d322020-02-27 22:20:15 +0000332 sys.stdout.write(self._long_text)
333 sys.stdout.write('\n***************\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000334
Debrian Figueroadd2737e2019-06-21 23:50:13 +0000335 def json_format(self):
336 return {
337 'message': self._message,
Debrian Figueroa6095d402019-06-28 18:47:18 +0000338 'items': [str(item) for item in self._items],
Debrian Figueroadd2737e2019-06-21 23:50:13 +0000339 'long_text': self._long_text,
340 'fatal': self.fatal
341 }
342
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000343
344# Top level object so multiprocessing can pickle
345# Public access through OutputApi object.
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000346class _PresubmitError(_PresubmitResult):
347 """A hard presubmit error."""
348 fatal = True
349
350
351# Top level object so multiprocessing can pickle
352# Public access through OutputApi object.
353class _PresubmitPromptWarning(_PresubmitResult):
354 """An warning that prompts the user if they want to continue."""
355 should_prompt = True
356
357
358# Top level object so multiprocessing can pickle
359# Public access through OutputApi object.
360class _PresubmitNotifyResult(_PresubmitResult):
361 """Just print something to the screen -- but it's not even a warning."""
362 pass
363
364
365# Top level object so multiprocessing can pickle
366# Public access through OutputApi object.
367class _MailTextResult(_PresubmitResult):
368 """A warning that should be included in the review request email."""
369 def __init__(self, *args, **kwargs):
370 super(_MailTextResult, self).__init__()
371 raise NotImplementedError()
372
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000373class GerritAccessor(object):
374 """Limited Gerrit functionality for canned presubmit checks to work.
375
376 To avoid excessive Gerrit calls, caches the results.
377 """
378
379 def __init__(self, host):
380 self.host = host
381 self.cache = {}
382
383 def _FetchChangeDetail(self, issue):
384 # Separate function to be easily mocked in tests.
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +0100385 try:
386 return gerrit_util.GetChangeDetail(
387 self.host, str(issue),
Aaron Gable6f5a8d92017-04-18 14:49:05 -0700388 ['ALL_REVISIONS', 'DETAILED_LABELS', 'ALL_COMMITS'])
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +0100389 except gerrit_util.GerritError as e:
390 if e.http_status == 404:
391 raise Exception('Either Gerrit issue %s doesn\'t exist, or '
392 'no credentials to fetch issue details' % issue)
393 raise
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000394
395 def GetChangeInfo(self, issue):
396 """Returns labels and all revisions (patchsets) for this issue.
397
398 The result is a dictionary according to Gerrit REST Api.
399 https://gerrit-review.googlesource.com/Documentation/rest-api.html
400
401 However, API isn't very clear what's inside, so see tests for example.
402 """
403 assert issue
404 cache_key = int(issue)
405 if cache_key not in self.cache:
406 self.cache[cache_key] = self._FetchChangeDetail(issue)
407 return self.cache[cache_key]
408
409 def GetChangeDescription(self, issue, patchset=None):
410 """If patchset is none, fetches current patchset."""
411 info = self.GetChangeInfo(issue)
412 # info is a reference to cache. We'll modify it here adding description to
413 # it to the right patchset, if it is not yet there.
414
415 # Find revision info for the patchset we want.
416 if patchset is not None:
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +0000417 for rev, rev_info in info['revisions'].items():
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000418 if str(rev_info['_number']) == str(patchset):
419 break
420 else:
421 raise Exception('patchset %s doesn\'t exist in issue %s' % (
422 patchset, issue))
423 else:
424 rev = info['current_revision']
425 rev_info = info['revisions'][rev]
426
Andrii Shyshkalov9c3a4642017-01-24 17:41:22 +0100427 return rev_info['commit']['message']
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000428
Mun Yong Jang603d01e2017-12-19 16:38:30 -0800429 def GetDestRef(self, issue):
430 ref = self.GetChangeInfo(issue)['branch']
431 if not ref.startswith('refs/'):
432 # NOTE: it is possible to create 'refs/x' branch,
433 # aka 'refs/heads/refs/x'. However, this is ill-advised.
434 ref = 'refs/heads/%s' % ref
435 return ref
436
Edward Lesmes02d4b822020-11-11 00:37:35 +0000437 def _GetApproversForLabel(self, issue, label):
438 change_info = self.GetChangeInfo(issue)
439 label_info = change_info.get('labels', {}).get(label, {})
440 values = label_info.get('values', {}).keys()
441 if not values:
442 return []
443 max_value = max(int(v) for v in values)
444 return [v for v in label_info.get('all', [])
445 if v.get('value', 0) == max_value]
446
447 def IsBotCommitApproved(self, issue):
448 return bool(self._GetApproversForLabel(issue, 'Bot-Commit'))
449
Edward Lesmescf49cb82020-11-11 01:08:36 +0000450 def IsOwnersOverrideApproved(self, issue):
451 return bool(self._GetApproversForLabel(issue, 'Owners-Override'))
452
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000453 def GetChangeOwner(self, issue):
454 return self.GetChangeInfo(issue)['owner']['email']
455
456 def GetChangeReviewers(self, issue, approving_only=True):
Aaron Gable8b478f02017-07-31 15:33:19 -0700457 changeinfo = self.GetChangeInfo(issue)
458 if approving_only:
Edward Lesmes02d4b822020-11-11 00:37:35 +0000459 reviewers = self._GetApproversForLabel(issue, 'Code-Review')
Aaron Gable8b478f02017-07-31 15:33:19 -0700460 else:
461 reviewers = changeinfo.get('reviewers', {}).get('REVIEWER', [])
462 return [r.get('email') for r in reviewers]
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000463
Edward Lemure4d329c2020-02-03 20:41:18 +0000464 def UpdateDescription(self, description, issue):
465 gerrit_util.SetCommitMessage(self.host, issue, description, notify='NONE')
466
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000467
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000468class OutputApi(object):
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000469 """An instance of OutputApi gets passed to presubmit scripts so that they
470 can output various types of results.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000471 """
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000472 PresubmitResult = _PresubmitResult
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000473 PresubmitError = _PresubmitError
474 PresubmitPromptWarning = _PresubmitPromptWarning
475 PresubmitNotifyResult = _PresubmitNotifyResult
476 MailTextResult = _MailTextResult
477
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000478 def __init__(self, is_committing):
479 self.is_committing = is_committing
Daniel Cheng7227d212017-11-17 08:12:37 -0800480 self.more_cc = []
481
482 def AppendCC(self, cc):
483 """Appends a user to cc for this change."""
484 self.more_cc.append(cc)
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000485
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000486 def PresubmitPromptOrNotify(self, *args, **kwargs):
487 """Warn the user when uploading, but only notify if committing."""
488 if self.is_committing:
489 return self.PresubmitNotifyResult(*args, **kwargs)
490 return self.PresubmitPromptWarning(*args, **kwargs)
491
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000492
493class InputApi(object):
494 """An instance of this object is passed to presubmit scripts so they can
495 know stuff about the change they're looking at.
496 """
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000497 # Method could be a function
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800498 # pylint: disable=no-self-use
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000499
maruel@chromium.org3410d912009-06-09 20:56:16 +0000500 # File extensions that are considered source files from a style guide
501 # perspective. Don't modify this list from a presubmit script!
maruel@chromium.orgc33455a2011-06-24 19:14:18 +0000502 #
503 # Files without an extension aren't included in the list. If you want to
local_bot30f774e2020-06-25 18:23:34 +0000504 # filter them as source files, add r'(^|.*?[\\\/])[^.]+$' to the allow list.
local_bot64021412020-07-08 21:05:39 +0000505 # Note that ALL CAPS files are skipped in DEFAULT_FILES_TO_SKIP below.
506 DEFAULT_FILES_TO_CHECK = (
maruel@chromium.org3410d912009-06-09 20:56:16 +0000507 # C++ and friends
Edward Lemura5799e32020-01-17 19:26:51 +0000508 r'.+\.c$', r'.+\.cc$', r'.+\.cpp$', r'.+\.h$', r'.+\.m$', r'.+\.mm$',
509 r'.+\.inl$', r'.+\.asm$', r'.+\.hxx$', r'.+\.hpp$', r'.+\.s$', r'.+\.S$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000510 # Scripts
Edward Lemura5799e32020-01-17 19:26:51 +0000511 r'.+\.js$', r'.+\.py$', r'.+\.sh$', r'.+\.rb$', r'.+\.pl$', r'.+\.pm$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000512 # Other
Edward Lemura5799e32020-01-17 19:26:51 +0000513 r'.+\.java$', r'.+\.mk$', r'.+\.am$', r'.+\.css$', r'.+\.mojom$',
514 r'.+\.fidl$'
maruel@chromium.org3410d912009-06-09 20:56:16 +0000515 )
516
517 # Path regexp that should be excluded from being considered containing source
518 # files. Don't modify this list from a presubmit script!
local_bot64021412020-07-08 21:05:39 +0000519 DEFAULT_FILES_TO_SKIP = (
Edward Lemura5799e32020-01-17 19:26:51 +0000520 r'testing_support[\\\/]google_appengine[\\\/].*',
521 r'.*\bexperimental[\\\/].*',
Kent Tamura179dd1e2018-04-26 15:07:41 +0900522 # Exclude third_party/.* but NOT third_party/{WebKit,blink}
523 # (crbug.com/539768 and crbug.com/836555).
Edward Lemura5799e32020-01-17 19:26:51 +0000524 r'.*\bthird_party[\\\/](?!(WebKit|blink)[\\\/]).*',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000525 # Output directories (just in case)
Edward Lemura5799e32020-01-17 19:26:51 +0000526 r'.*\bDebug[\\\/].*',
527 r'.*\bRelease[\\\/].*',
528 r'.*\bxcodebuild[\\\/].*',
529 r'.*\bout[\\\/].*',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000530 # All caps files like README and LICENCE.
Edward Lemura5799e32020-01-17 19:26:51 +0000531 r'.*\b[A-Z0-9_]{2,}$',
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000532 # SCM (can happen in dual SCM configuration). (Slightly over aggressive)
Edward Lemura5799e32020-01-17 19:26:51 +0000533 r'(|.*[\\\/])\.git[\\\/].*',
534 r'(|.*[\\\/])\.svn[\\\/].*',
maruel@chromium.org7ccb4bb2011-11-07 20:26:20 +0000535 # There is no point in processing a patch file.
Edward Lemura5799e32020-01-17 19:26:51 +0000536 r'.+\.diff$',
537 r'.+\.patch$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000538 )
539
local_bot30f774e2020-06-25 18:23:34 +0000540 # TODO(https://crbug.com/1098562): Remove once no longer used
541 @property
542 def DEFAULT_WHITE_LIST(self):
local_bot64021412020-07-08 21:05:39 +0000543 return self.DEFAULT_FILES_TO_CHECK
local_bot30f774e2020-06-25 18:23:34 +0000544
545 # TODO(https://crbug.com/1098562): Remove once no longer used
local_bot37ce2012020-06-26 17:39:24 +0000546 @DEFAULT_WHITE_LIST.setter
547 def DEFAULT_WHITE_LIST(self, value):
local_bot64021412020-07-08 21:05:39 +0000548 self.DEFAULT_FILES_TO_CHECK = value
549
550 # TODO(https://crbug.com/1098562): Remove once no longer used
551 @property
552 def DEFAULT_ALLOW_LIST(self):
553 return self.DEFAULT_FILES_TO_CHECK
554
555 # TODO(https://crbug.com/1098562): Remove once no longer used
556 @DEFAULT_ALLOW_LIST.setter
557 def DEFAULT_ALLOW_LIST(self, value):
558 self.DEFAULT_FILES_TO_CHECK = value
local_bot37ce2012020-06-26 17:39:24 +0000559
560 # TODO(https://crbug.com/1098562): Remove once no longer used
local_bot30f774e2020-06-25 18:23:34 +0000561 @property
562 def DEFAULT_BLACK_LIST(self):
local_bot64021412020-07-08 21:05:39 +0000563 return self.DEFAULT_FILES_TO_SKIP
local_bot30f774e2020-06-25 18:23:34 +0000564
local_bot37ce2012020-06-26 17:39:24 +0000565 # TODO(https://crbug.com/1098562): Remove once no longer used
566 @DEFAULT_BLACK_LIST.setter
567 def DEFAULT_BLACK_LIST(self, value):
local_bot64021412020-07-08 21:05:39 +0000568 self.DEFAULT_FILES_TO_SKIP = value
569
570 # TODO(https://crbug.com/1098562): Remove once no longer used
571 @property
572 def DEFAULT_BLOCK_LIST(self):
573 return self.DEFAULT_FILES_TO_SKIP
574
575 # TODO(https://crbug.com/1098562): Remove once no longer used
576 @DEFAULT_BLOCK_LIST.setter
577 def DEFAULT_BLOCK_LIST(self, value):
578 self.DEFAULT_FILES_TO_SKIP = value
local_bot37ce2012020-06-26 17:39:24 +0000579
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000580 def __init__(self, change, presubmit_path, is_committing,
Edward Lesmes8e282792018-04-03 18:50:29 -0400581 verbose, gerrit_obj, dry_run=None, thread_pool=None, parallel=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000582 """Builds an InputApi object.
583
584 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000585 change: A presubmit.Change object.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000586 presubmit_path: The path to the presubmit script being processed.
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000587 is_committing: True if the change is about to be committed.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000588 gerrit_obj: provides basic Gerrit codereview functionality.
589 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -0400590 parallel: if true, all tests reported via input_api.RunTests for all
591 PRESUBMIT files will be run in parallel.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000592 """
maruel@chromium.org9711bba2009-05-22 23:51:39 +0000593 # Version number of the presubmit_support script.
594 self.version = [int(x) for x in __version__.split('.')]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000595 self.change = change
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000596 self.is_committing = is_committing
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000597 self.gerrit = gerrit_obj
tandrii@chromium.org57bafac2016-04-28 05:09:03 +0000598 self.dry_run = dry_run
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000599
Edward Lesmes8e282792018-04-03 18:50:29 -0400600 self.parallel = parallel
601 self.thread_pool = thread_pool or ThreadPool()
602
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000603 # We expose various modules and functions as attributes of the input_api
604 # so that presubmit scripts don't have to import them.
Takeshi Yoshino07a6bea2017-08-02 02:44:06 +0900605 self.ast = ast
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000606 self.basename = os.path.basename
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000607 self.cpplint = cpplint
dcheng091b7db2016-06-16 01:27:51 -0700608 self.fnmatch = fnmatch
Yoshisato Yanagisawa04600b42019-03-15 03:03:41 +0000609 self.gclient_paths = gclient_paths
Yoshisato Yanagisawa57dd17b2019-03-22 09:10:29 +0000610 # TODO(yyanagisawa): stop exposing this when python3 become default.
611 # Since python3's tempfile has TemporaryDirectory, we do not need this.
612 self.temporary_directory = gclient_utils.temporary_directory
dpranke@chromium.org17cc2442012-10-17 21:12:09 +0000613 self.glob = glob.glob
maruel@chromium.orgfb11c7b2010-03-18 18:22:14 +0000614 self.json = json
maruel@chromium.org6fba34d2011-06-02 13:45:12 +0000615 self.logging = logging.getLogger('PRESUBMIT')
maruel@chromium.org2b5ce562011-03-31 16:15:44 +0000616 self.os_listdir = os.listdir
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000617 self.os_path = os.path
pgervais@chromium.orgbd0cace2014-10-02 23:23:46 +0000618 self.os_stat = os.stat
Yoshisato Yanagisawa406de132018-06-29 05:43:25 +0000619 self.os_walk = os.walk
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000620 self.re = re
621 self.subprocess = subprocess
Edward Lemurb9830242019-10-30 22:19:20 +0000622 self.sys = sys
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000623 self.tempfile = tempfile
dpranke@chromium.org0d1bdea2011-03-24 22:54:38 +0000624 self.time = time
maruel@chromium.org1487d532009-06-06 00:22:57 +0000625 self.unittest = unittest
Edward Lemurb9830242019-10-30 22:19:20 +0000626 if sys.version_info.major == 2:
627 self.urllib2 = urllib2
Edward Lemur16af3562019-10-17 22:11:33 +0000628 self.urllib_request = urllib_request
629 self.urllib_error = urllib_error
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000630
Robert Iannucci50258932018-03-19 10:30:59 -0700631 self.is_windows = sys.platform == 'win32'
632
Edward Lemurb9646622019-10-25 20:57:35 +0000633 # Set python_executable to 'vpython' in order to allow scripts in other
634 # repos (e.g. src.git) to automatically pick up that repo's .vpython file,
635 # instead of inheriting the one in depot_tools.
636 self.python_executable = 'vpython'
maruel@chromium.orgc0b22972009-06-25 16:19:14 +0000637 self.environ = os.environ
638
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000639 # InputApi.platform is the platform you're currently running on.
640 self.platform = sys.platform
641
iannucci@chromium.org0af3bb32015-06-12 20:44:35 +0000642 self.cpu_count = multiprocessing.cpu_count()
643
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000644 # The local path of the currently-being-processed presubmit script.
maruel@chromium.org3d235242009-05-15 12:40:48 +0000645 self._current_presubmit_path = os.path.dirname(presubmit_path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000646
647 # We carry the canned checks so presubmit scripts can easily use them.
648 self.canned_checks = presubmit_canned_checks
649
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +0100650 # Temporary files we must manually remove at the end of a run.
651 self._named_temporary_files = []
Jochen Eisinger72606f82017-04-04 10:44:18 +0200652
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000653 # TODO(dpranke): figure out a list of all approved owners for a repo
654 # in order to be able to handle wildcard OWNERS files?
Edward Lesmes9ce03f82021-01-12 20:13:31 +0000655 self.owners_client = owners_client.DepotToolsClient(
656 change.RepositoryRoot(), change.UpstreamBranch(), os_path=self.os_path)
657 self.owners_db = owners_db.Database(
658 change.RepositoryRoot(), fopen=open, os_path=self.os_path)
Jochen Eisinger76f5fc62017-04-07 16:27:46 +0200659 self.owners_finder = owners_finder.OwnersFinder
maruel@chromium.org899e1c12011-04-07 17:03:18 +0000660 self.verbose = verbose
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000661 self.Command = CommandData
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000662
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000663 # Replace <hash_map> and <hash_set> as headers that need to be included
Edward Lemura5799e32020-01-17 19:26:51 +0000664 # with 'base/containers/hash_tables.h' instead.
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000665 # Access to a protected member _XX of a client class
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800666 # pylint: disable=protected-access
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000667 self.cpplint._re_pattern_templates = [
danakj@chromium.org18278522013-06-11 22:42:32 +0000668 (a, b, 'base/containers/hash_tables.h')
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000669 if header in ('<hash_map>', '<hash_set>') else (a, b, header)
670 for (a, b, header) in cpplint._re_pattern_templates
671 ]
672
Edward Lemurecc27072020-01-06 16:42:34 +0000673 def SetTimeout(self, timeout):
674 self.thread_pool.timeout = timeout
675
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000676 def PresubmitLocalPath(self):
677 """Returns the local path of the presubmit script currently being run.
678
679 This is useful if you don't want to hard-code absolute paths in the
680 presubmit script. For example, It can be used to find another file
681 relative to the PRESUBMIT.py script, so the whole tree can be branched and
682 the presubmit script still works, without editing its content.
683 """
maruel@chromium.org3d235242009-05-15 12:40:48 +0000684 return self._current_presubmit_path
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000685
agable0b65e732016-11-22 09:25:46 -0800686 def AffectedFiles(self, include_deletes=True, file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000687 """Same as input_api.change.AffectedFiles() except only lists files
688 (and optionally directories) in the same directory as the current presubmit
Bruce Dawson7a0b07a2020-04-23 17:14:40 +0000689 script, or subdirectories thereof. Note that files are listed using the OS
690 path separator, so backslashes are used as separators on Windows.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000691 """
Edward Lemura5799e32020-01-17 19:26:51 +0000692 dir_with_slash = normpath('%s/' % self.PresubmitLocalPath())
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000693 if len(dir_with_slash) == 1:
694 dir_with_slash = ''
sail@chromium.org5538e022011-05-12 17:53:16 +0000695
Edward Lemurb9830242019-10-30 22:19:20 +0000696 return list(filter(
maruel@chromium.org4661e0c2009-06-04 00:45:26 +0000697 lambda x: normpath(x.AbsoluteLocalPath()).startswith(dir_with_slash),
Edward Lemurb9830242019-10-30 22:19:20 +0000698 self.change.AffectedFiles(include_deletes, file_filter)))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000699
agable0b65e732016-11-22 09:25:46 -0800700 def LocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000701 """Returns local paths of input_api.AffectedFiles()."""
agable0b65e732016-11-22 09:25:46 -0800702 paths = [af.LocalPath() for af in self.AffectedFiles()]
Edward Lemura5799e32020-01-17 19:26:51 +0000703 logging.debug('LocalPaths: %s', paths)
pgervais@chromium.org2f64f782014-04-25 00:12:33 +0000704 return paths
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000705
agable0b65e732016-11-22 09:25:46 -0800706 def AbsoluteLocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000707 """Returns absolute local paths of input_api.AffectedFiles()."""
agable0b65e732016-11-22 09:25:46 -0800708 return [af.AbsoluteLocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000709
John Budorick16162372018-04-18 10:39:53 -0700710 def AffectedTestableFiles(self, include_deletes=None, **kwargs):
agable0b65e732016-11-22 09:25:46 -0800711 """Same as input_api.change.AffectedTestableFiles() except only lists files
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000712 in the same directory as the current presubmit script, or subdirectories
713 thereof.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000714 """
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000715 if include_deletes is not None:
Edward Lemura5799e32020-01-17 19:26:51 +0000716 warn('AffectedTestableFiles(include_deletes=%s)'
717 ' is deprecated and ignored' % str(include_deletes),
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000718 category=DeprecationWarning,
719 stacklevel=2)
Edward Lemurb9830242019-10-30 22:19:20 +0000720 return list(filter(
721 lambda x: x.IsTestableFile(),
722 self.AffectedFiles(include_deletes=False, **kwargs)))
agable0b65e732016-11-22 09:25:46 -0800723
724 def AffectedTextFiles(self, include_deletes=None):
725 """An alias to AffectedTestableFiles for backwards compatibility."""
726 return self.AffectedTestableFiles(include_deletes=include_deletes)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000727
Josip Sokcevic8c955952021-02-01 21:32:57 +0000728 def FilterSourceFile(self,
729 affected_file,
730 files_to_check=None,
731 files_to_skip=None,
732 allow_list=None,
733 block_list=None):
Edward Lemura5799e32020-01-17 19:26:51 +0000734 """Filters out files that aren't considered 'source file'.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000735
local_bot64021412020-07-08 21:05:39 +0000736 If files_to_check or files_to_skip is None, InputApi.DEFAULT_FILES_TO_CHECK
737 and InputApi.DEFAULT_FILES_TO_SKIP is used respectively.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000738
739 The lists will be compiled as regular expression and
740 AffectedFile.LocalPath() needs to pass both list.
741
742 Note: Copy-paste this function to suit your needs or use a lambda function.
743 """
local_bot64021412020-07-08 21:05:39 +0000744 if files_to_check is None:
745 files_to_check = self.DEFAULT_FILES_TO_CHECK
746 if files_to_skip is None:
747 files_to_skip = self.DEFAULT_FILES_TO_SKIP
local_bot30f774e2020-06-25 18:23:34 +0000748
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000749 def Find(affected_file, items):
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000750 local_path = affected_file.LocalPath()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000751 for item in items:
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000752 if self.re.match(item, local_path):
maruel@chromium.org3410d912009-06-09 20:56:16 +0000753 return True
754 return False
local_bot64021412020-07-08 21:05:39 +0000755 return (Find(affected_file, files_to_check) and
756 not Find(affected_file, files_to_skip))
maruel@chromium.org3410d912009-06-09 20:56:16 +0000757
758 def AffectedSourceFiles(self, source_file):
agable0b65e732016-11-22 09:25:46 -0800759 """Filter the list of AffectedTestableFiles by the function source_file.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000760
761 If source_file is None, InputApi.FilterSourceFile() is used.
762 """
763 if not source_file:
764 source_file = self.FilterSourceFile
Edward Lemurb9830242019-10-30 22:19:20 +0000765 return list(filter(source_file, self.AffectedTestableFiles()))
maruel@chromium.org3410d912009-06-09 20:56:16 +0000766
767 def RightHandSideLines(self, source_file_filter=None):
Edward Lemura5799e32020-01-17 19:26:51 +0000768 """An iterator over all text lines in 'new' version of changed files.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000769
770 Only lists lines from new or modified text files in the change that are
771 contained by the directory of the currently executing presubmit script.
772
773 This is useful for doing line-by-line regex checks, like checking for
774 trailing whitespace.
775
776 Yields:
777 a 3 tuple:
778 the AffectedFile instance of the current file;
779 integer line number (1-based); and
780 the contents of the line as a string.
maruel@chromium.org1487d532009-06-06 00:22:57 +0000781
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000782 Note: The carriage return (LF or CR) is stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000783 """
maruel@chromium.org3410d912009-06-09 20:56:16 +0000784 files = self.AffectedSourceFiles(source_file_filter)
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000785 return _RightHandSideLinesImpl(files)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000786
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000787 def ReadFile(self, file_item, mode='r'):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000788 """Reads an arbitrary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000789
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000790 Deny reading anything outside the repository.
791 """
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000792 if isinstance(file_item, AffectedFile):
793 file_item = file_item.AbsoluteLocalPath()
794 if not file_item.startswith(self.change.RepositoryRoot()):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000795 raise IOError('Access outside the repository root is denied.')
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +0000796 return gclient_utils.FileRead(file_item, mode)
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000797
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +0100798 def CreateTemporaryFile(self, **kwargs):
799 """Returns a named temporary file that must be removed with a call to
800 RemoveTemporaryFiles().
801
802 All keyword arguments are forwarded to tempfile.NamedTemporaryFile(),
803 except for |delete|, which is always set to False.
804
805 Presubmit checks that need to create a temporary file and pass it for
806 reading should use this function instead of NamedTemporaryFile(), as
807 Windows fails to open a file that is already open for writing.
808
809 with input_api.CreateTemporaryFile() as f:
810 f.write('xyz')
811 f.close()
812 input_api.subprocess.check_output(['script-that', '--reads-from',
813 f.name])
814
815
816 Note that callers of CreateTemporaryFile() should not worry about removing
817 any temporary file; this is done transparently by the presubmit handling
818 code.
819 """
820 if 'delete' in kwargs:
821 # Prevent users from passing |delete|; we take care of file deletion
822 # ourselves and this prevents unintuitive error messages when we pass
823 # delete=False and 'delete' is also in kwargs.
824 raise TypeError('CreateTemporaryFile() does not take a "delete" '
825 'argument, file deletion is handled automatically by '
826 'the same presubmit_support code that creates InputApi '
827 'objects.')
828 temp_file = self.tempfile.NamedTemporaryFile(delete=False, **kwargs)
829 self._named_temporary_files.append(temp_file.name)
830 return temp_file
831
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000832 @property
833 def tbr(self):
834 """Returns if a change is TBR'ed."""
Jeremy Romandce22502017-06-20 15:37:29 -0400835 return 'TBR' in self.change.tags or self.change.TBRsFromDescription()
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000836
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000837 def RunTests(self, tests_mix, parallel=True):
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000838 tests = []
839 msgs = []
840 for t in tests_mix:
Edward Lesmes8e282792018-04-03 18:50:29 -0400841 if isinstance(t, OutputApi.PresubmitResult) and t:
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000842 msgs.append(t)
843 else:
844 assert issubclass(t.message, _PresubmitResult)
845 tests.append(t)
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000846 if self.verbose:
847 t.info = _PresubmitNotifyResult
Edward Lemur1037c742018-05-01 18:56:04 -0400848 if not t.kwargs.get('cwd'):
849 t.kwargs['cwd'] = self.PresubmitLocalPath()
Edward Lesmes8e282792018-04-03 18:50:29 -0400850 self.thread_pool.AddTests(tests, parallel)
Edward Lemur21000eb2019-05-24 23:25:58 +0000851 # When self.parallel is True (i.e. --parallel is passed as an option)
852 # RunTests doesn't actually run tests. It adds them to a ThreadPool that
853 # will run all tests once all PRESUBMIT files are processed.
854 # Otherwise, it will run them and return the results.
855 if not self.parallel:
Edward Lesmes8e282792018-04-03 18:50:29 -0400856 msgs.extend(self.thread_pool.RunAsync())
857 return msgs
scottmg86099d72016-09-01 09:16:51 -0700858
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000859
nick@chromium.orgff526192013-06-10 19:30:26 +0000860class _DiffCache(object):
861 """Caches diffs retrieved from a particular SCM."""
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000862 def __init__(self, upstream=None):
863 """Stores the upstream revision against which all diffs will be computed."""
864 self._upstream = upstream
nick@chromium.orgff526192013-06-10 19:30:26 +0000865
866 def GetDiff(self, path, local_root):
867 """Get the diff for a particular path."""
868 raise NotImplementedError()
869
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700870 def GetOldContents(self, path, local_root):
871 """Get the old version for a particular path."""
872 raise NotImplementedError()
873
nick@chromium.orgff526192013-06-10 19:30:26 +0000874
nick@chromium.orgff526192013-06-10 19:30:26 +0000875class _GitDiffCache(_DiffCache):
876 """DiffCache implementation for git; gets all file diffs at once."""
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000877 def __init__(self, upstream):
878 super(_GitDiffCache, self).__init__(upstream=upstream)
nick@chromium.orgff526192013-06-10 19:30:26 +0000879 self._diffs_by_file = None
880
881 def GetDiff(self, path, local_root):
882 if not self._diffs_by_file:
883 # Compute a single diff for all files and parse the output; should
884 # with git this is much faster than computing one diff for each file.
885 diffs = {}
886
887 # Don't specify any filenames below, because there are command line length
888 # limits on some platforms and GenerateDiff would fail.
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000889 unified_diff = scm.GIT.GenerateDiff(local_root, files=[], full_move=True,
890 branch=self._upstream)
nick@chromium.orgff526192013-06-10 19:30:26 +0000891
892 # This regex matches the path twice, separated by a space. Note that
893 # filename itself may contain spaces.
894 file_marker = re.compile('^diff --git (?P<filename>.*) (?P=filename)$')
895 current_diff = []
896 keep_line_endings = True
897 for x in unified_diff.splitlines(keep_line_endings):
898 match = file_marker.match(x)
899 if match:
900 # Marks the start of a new per-file section.
901 diffs[match.group('filename')] = current_diff = [x]
902 elif x.startswith('diff --git'):
903 raise PresubmitFailure('Unexpected diff line: %s' % x)
904 else:
905 current_diff.append(x)
906
907 self._diffs_by_file = dict(
908 (normpath(path), ''.join(diff)) for path, diff in diffs.items())
909
910 if path not in self._diffs_by_file:
911 raise PresubmitFailure(
912 'Unified diff did not contain entry for file %s' % path)
913
914 return self._diffs_by_file[path]
915
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700916 def GetOldContents(self, path, local_root):
917 return scm.GIT.GetOldContents(local_root, path, branch=self._upstream)
918
nick@chromium.orgff526192013-06-10 19:30:26 +0000919
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000920class AffectedFile(object):
921 """Representation of a file in a change."""
nick@chromium.orgff526192013-06-10 19:30:26 +0000922
923 DIFF_CACHE = _DiffCache
924
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000925 # Method could be a function
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800926 # pylint: disable=no-self-use
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000927 def __init__(self, path, action, repository_root, diff_cache):
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000928 self._path = path
929 self._action = action
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000930 self._local_root = repository_root
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000931 self._is_directory = None
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000932 self._cached_changed_contents = None
933 self._cached_new_contents = None
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000934 self._diff_cache = diff_cache
tobiasjs2836bcf2016-08-16 04:08:16 -0700935 logging.debug('%s(%s)', self.__class__.__name__, self._path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000936
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000937 def LocalPath(self):
938 """Returns the path of this file on the local disk relative to client root.
Andrew Grieve92b8b992017-11-02 09:42:24 -0400939
940 This should be used for error messages but not for accessing files,
941 because presubmit checks are run with CWD=PresubmitLocalPath() (which is
942 often != client root).
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000943 """
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000944 return normpath(self._path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000945
946 def AbsoluteLocalPath(self):
947 """Returns the absolute path of this file on the local disk.
948 """
chase@chromium.org8e416c82009-10-06 04:30:44 +0000949 return os.path.abspath(os.path.join(self._local_root, self.LocalPath()))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000950
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000951 def Action(self):
952 """Returns the action on this opened file, e.g. A, M, D, etc."""
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000953 return self._action
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000954
agable0b65e732016-11-22 09:25:46 -0800955 def IsTestableFile(self):
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000956 """Returns True if the file is a text file and not a binary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000957
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000958 Deleted files are not text file."""
maruel@chromium.org1e08c002009-05-28 19:09:33 +0000959 raise NotImplementedError() # Implement when needed
960
agable0b65e732016-11-22 09:25:46 -0800961 def IsTextFile(self):
962 """An alias to IsTestableFile for backwards compatibility."""
963 return self.IsTestableFile()
964
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700965 def OldContents(self):
966 """Returns an iterator over the lines in the old version of file.
967
Daniel Cheng2da34fe2017-03-21 20:42:12 -0700968 The old version is the file before any modifications in the user's
Edward Lemura5799e32020-01-17 19:26:51 +0000969 workspace, i.e. the 'left hand side'.
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700970
971 Contents will be empty if the file is a directory or does not exist.
972 Note: The carriage returns (LF or CR) are stripped off.
973 """
974 return self._diff_cache.GetOldContents(self.LocalPath(),
975 self._local_root).splitlines()
976
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000977 def NewContents(self):
978 """Returns an iterator over the lines in the new version of file.
979
Edward Lemura5799e32020-01-17 19:26:51 +0000980 The new version is the file in the user's workspace, i.e. the 'right hand
981 side'.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000982
983 Contents will be empty if the file is a directory or does not exist.
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000984 Note: The carriage returns (LF or CR) are stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000985 """
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000986 if self._cached_new_contents is None:
987 self._cached_new_contents = []
agable0b65e732016-11-22 09:25:46 -0800988 try:
989 self._cached_new_contents = gclient_utils.FileRead(
990 self.AbsoluteLocalPath(), 'rU').splitlines()
991 except IOError:
992 pass # File not found? That's fine; maybe it was deleted.
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000993 return self._cached_new_contents[:]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000994
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000995 def ChangedContents(self):
996 """Returns a list of tuples (line number, line text) of all new lines.
997
998 This relies on the scm diff output describing each changed code section
999 with a line of the form
1000
1001 ^@@ <old line num>,<old size> <new line num>,<new size> @@$
1002 """
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +00001003 if self._cached_changed_contents is not None:
1004 return self._cached_changed_contents[:]
1005 self._cached_changed_contents = []
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001006 line_num = 0
1007
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001008 for line in self.GenerateScmDiff().splitlines():
Edward Lemurac5c55f2020-02-29 00:17:16 +00001009 m = re.match(r'^@@ [0-9\,\+\-]+ \+([0-9]+)\,[0-9]+ @@', line)
1010 if m:
1011 line_num = int(m.groups(1)[0])
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001012 continue
1013 if line.startswith('+') and not line.startswith('++'):
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +00001014 self._cached_changed_contents.append((line_num, line[1:]))
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001015 if not line.startswith('-'):
1016 line_num += 1
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +00001017 return self._cached_changed_contents[:]
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001018
maruel@chromium.org5de13972009-06-10 18:16:06 +00001019 def __str__(self):
1020 return self.LocalPath()
1021
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001022 def GenerateScmDiff(self):
nick@chromium.orgff526192013-06-10 19:30:26 +00001023 return self._diff_cache.GetDiff(self.LocalPath(), self._local_root)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001024
maruel@chromium.org58407af2011-04-12 23:15:57 +00001025
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001026class GitAffectedFile(AffectedFile):
1027 """Representation of a file in a change out of a git checkout."""
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +00001028 # Method 'NNN' is abstract in class 'NNN' but is not overridden
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08001029 # pylint: disable=abstract-method
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001030
nick@chromium.orgff526192013-06-10 19:30:26 +00001031 DIFF_CACHE = _GitDiffCache
1032
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001033 def __init__(self, *args, **kwargs):
1034 AffectedFile.__init__(self, *args, **kwargs)
1035 self._server_path = None
agable0b65e732016-11-22 09:25:46 -08001036 self._is_testable_file = None
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001037
agable0b65e732016-11-22 09:25:46 -08001038 def IsTestableFile(self):
1039 if self._is_testable_file is None:
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001040 if self.Action() == 'D':
agable0b65e732016-11-22 09:25:46 -08001041 # A deleted file is not testable.
1042 self._is_testable_file = False
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001043 else:
agable0b65e732016-11-22 09:25:46 -08001044 self._is_testable_file = os.path.isfile(self.AbsoluteLocalPath())
1045 return self._is_testable_file
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001046
maruel@chromium.orgc1938752011-04-12 23:11:13 +00001047
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001048class Change(object):
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001049 """Describe a change.
1050
1051 Used directly by the presubmit scripts to query the current change being
1052 tested.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +00001053
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001054 Instance members:
nick@chromium.orgff526192013-06-10 19:30:26 +00001055 tags: Dictionary of KEY=VALUE pairs found in the change description.
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001056 self.KEY: equivalent to tags['KEY']
1057 """
1058
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001059 _AFFECTED_FILES = AffectedFile
1060
Edward Lemura5799e32020-01-17 19:26:51 +00001061 # Matches key/value (or 'tag') lines in changelist descriptions.
maruel@chromium.org428342a2011-11-10 15:46:33 +00001062 TAG_LINE_RE = re.compile(
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001063 '^[ \t]*(?P<key>[A-Z][A-Z_0-9]*)[ \t]*=[ \t]*(?P<value>.*?)[ \t]*$')
maruel@chromium.orgc1938752011-04-12 23:11:13 +00001064 scm = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001065
maruel@chromium.org58407af2011-04-12 23:15:57 +00001066 def __init__(
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001067 self, name, description, local_root, files, issue, patchset, author,
1068 upstream=None):
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001069 if files is None:
1070 files = []
1071 self._name = name
chase@chromium.org8e416c82009-10-06 04:30:44 +00001072 # Convert root into an absolute path.
1073 self._local_root = os.path.abspath(local_root)
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001074 self._upstream = upstream
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001075 self.issue = issue
1076 self.patchset = patchset
maruel@chromium.org58407af2011-04-12 23:15:57 +00001077 self.author_email = author
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001078
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001079 self._full_description = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001080 self.tags = {}
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001081 self._description_without_tags = ''
1082 self.SetDescriptionText(description)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001083
maruel@chromium.orge085d812011-10-10 19:49:15 +00001084 assert all(
1085 (isinstance(f, (list, tuple)) and len(f) == 2) for f in files), files
1086
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001087 diff_cache = self._AFFECTED_FILES.DIFF_CACHE(self._upstream)
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001088 self._affected_files = [
nick@chromium.orgff526192013-06-10 19:30:26 +00001089 self._AFFECTED_FILES(path, action.strip(), self._local_root, diff_cache)
1090 for action, path in files
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +00001091 ]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001092
Edward Lesmes9ce03f82021-01-12 20:13:31 +00001093 def UpstreamBranch(self):
1094 """Returns the upstream branch for the change."""
1095 return self._upstream
1096
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001097 def Name(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001098 """Returns the change name."""
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001099 return self._name
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001100
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001101 def DescriptionText(self):
1102 """Returns the user-entered changelist description, minus tags.
1103
Edward Lemura5799e32020-01-17 19:26:51 +00001104 Any line in the user-provided description starting with e.g. 'FOO='
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001105 (whitespace permitted before and around) is considered a tag line. Such
1106 lines are stripped out of the description this function returns.
1107 """
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001108 return self._description_without_tags
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001109
1110 def FullDescriptionText(self):
1111 """Returns the complete changelist description including tags."""
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001112 return self._full_description
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001113
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001114 def SetDescriptionText(self, description):
1115 """Sets the full description text (including tags) to |description|.
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001116
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001117 Also updates the list of tags."""
1118 self._full_description = description
1119
1120 # From the description text, build up a dictionary of key/value pairs
Edward Lemura5799e32020-01-17 19:26:51 +00001121 # plus the description minus all key/value or 'tag' lines.
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001122 description_without_tags = []
1123 self.tags = {}
1124 for line in self._full_description.splitlines():
1125 m = self.TAG_LINE_RE.match(line)
1126 if m:
1127 self.tags[m.group('key')] = m.group('value')
1128 else:
1129 description_without_tags.append(line)
1130
1131 # Change back to text and remove whitespace at end.
1132 self._description_without_tags = (
1133 '\n'.join(description_without_tags).rstrip())
1134
Edward Lemur69bb8be2020-02-03 20:37:38 +00001135 def AddDescriptionFooter(self, key, value):
1136 """Adds the given footer to the change description.
1137
1138 Args:
1139 key: A string with the key for the git footer. It must conform to
1140 the git footers format (i.e. 'List-Of-Tokens') and will be case
1141 normalized so that each token is title-cased.
1142 value: A string with the value for the git footer.
1143 """
1144 description = git_footers.add_footer(
1145 self.FullDescriptionText(), git_footers.normalize_name(key), value)
1146 self.SetDescriptionText(description)
1147
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001148 def RepositoryRoot(self):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001149 """Returns the repository (checkout) root directory for this change,
1150 as an absolute path.
1151 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001152 return self._local_root
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001153
1154 def __getattr__(self, attr):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001155 """Return tags directly as attributes on the object."""
Edward Lemura5799e32020-01-17 19:26:51 +00001156 if not re.match(r'^[A-Z_]*$', attr):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001157 raise AttributeError(self, attr)
maruel@chromium.orge1a524f2009-05-27 14:43:46 +00001158 return self.tags.get(attr)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001159
Edward Lemur69bb8be2020-02-03 20:37:38 +00001160 def GitFootersFromDescription(self):
1161 """Return the git footers present in the description.
1162
1163 Returns:
1164 footers: A dict of {footer: [values]} containing a multimap of the footers
1165 in the change description.
1166 """
1167 return git_footers.parse_footers(self.FullDescriptionText())
1168
Aaron Gablefc03e672017-05-15 14:09:42 -07001169 def BugsFromDescription(self):
1170 """Returns all bugs referenced in the commit description."""
Aaron Gable12ef5012017-05-15 14:29:00 -07001171 tags = [b.strip() for b in self.tags.get('BUG', '').split(',') if b.strip()]
Caleb Rouleauc0546b92019-02-22 06:12:57 +00001172 footers = []
Edward Lemur69bb8be2020-02-03 20:37:38 +00001173 parsed = self.GitFootersFromDescription()
Dan Beam62954042019-10-03 21:20:33 +00001174 unsplit_footers = parsed.get('Bug', []) + parsed.get('Fixed', [])
Caleb Rouleauc0546b92019-02-22 06:12:57 +00001175 for unsplit_footer in unsplit_footers:
1176 footers += [b.strip() for b in unsplit_footer.split(',')]
Aaron Gable12ef5012017-05-15 14:29:00 -07001177 return sorted(set(tags + footers))
Aaron Gablefc03e672017-05-15 14:09:42 -07001178
1179 def ReviewersFromDescription(self):
1180 """Returns all reviewers listed in the commit description."""
Edward Lemura5799e32020-01-17 19:26:51 +00001181 # We don't support a 'R:' git-footer for reviewers; that is in metadata.
Aaron Gable12ef5012017-05-15 14:29:00 -07001182 tags = [r.strip() for r in self.tags.get('R', '').split(',') if r.strip()]
1183 return sorted(set(tags))
Aaron Gablefc03e672017-05-15 14:09:42 -07001184
1185 def TBRsFromDescription(self):
1186 """Returns all TBR reviewers listed in the commit description."""
Aaron Gable12ef5012017-05-15 14:29:00 -07001187 tags = [r.strip() for r in self.tags.get('TBR', '').split(',') if r.strip()]
Aaron Gable6e7ddb62020-05-27 22:23:29 +00001188 # TODO(crbug.com/839208): Remove support for 'Tbr:' when TBRs are
1189 # programmatically determined by self-CR+1s.
Edward Lemur69bb8be2020-02-03 20:37:38 +00001190 footers = self.GitFootersFromDescription().get('Tbr', [])
Aaron Gable12ef5012017-05-15 14:29:00 -07001191 return sorted(set(tags + footers))
Aaron Gablefc03e672017-05-15 14:09:42 -07001192
Aaron Gable6e7ddb62020-05-27 22:23:29 +00001193 # TODO(crbug.com/753425): Delete these once we're sure they're unused.
Aaron Gablefc03e672017-05-15 14:09:42 -07001194 @property
1195 def BUG(self):
1196 return ','.join(self.BugsFromDescription())
1197 @property
1198 def R(self):
1199 return ','.join(self.ReviewersFromDescription())
1200 @property
1201 def TBR(self):
1202 return ','.join(self.TBRsFromDescription())
1203
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001204 def AllFiles(self, root=None):
1205 """List all files under source control in the repo."""
1206 raise NotImplementedError()
1207
agable0b65e732016-11-22 09:25:46 -08001208 def AffectedFiles(self, include_deletes=True, file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001209 """Returns a list of AffectedFile instances for all files in the change.
1210
1211 Args:
1212 include_deletes: If false, deleted files will be filtered out.
sail@chromium.org5538e022011-05-12 17:53:16 +00001213 file_filter: An additional filter to apply.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001214
1215 Returns:
1216 [AffectedFile(path, action), AffectedFile(path, action)]
1217 """
Edward Lemurb9830242019-10-30 22:19:20 +00001218 affected = list(filter(file_filter, self._affected_files))
sail@chromium.org5538e022011-05-12 17:53:16 +00001219
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001220 if include_deletes:
1221 return affected
Edward Lemurb9830242019-10-30 22:19:20 +00001222 return list(filter(lambda x: x.Action() != 'D', affected))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001223
John Budorick16162372018-04-18 10:39:53 -07001224 def AffectedTestableFiles(self, include_deletes=None, **kwargs):
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +00001225 """Return a list of the existing text files in a change."""
1226 if include_deletes is not None:
Edward Lemura5799e32020-01-17 19:26:51 +00001227 warn('AffectedTeestableFiles(include_deletes=%s)'
1228 ' is deprecated and ignored' % str(include_deletes),
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +00001229 category=DeprecationWarning,
1230 stacklevel=2)
Edward Lemurb9830242019-10-30 22:19:20 +00001231 return list(filter(
1232 lambda x: x.IsTestableFile(),
1233 self.AffectedFiles(include_deletes=False, **kwargs)))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001234
agable0b65e732016-11-22 09:25:46 -08001235 def AffectedTextFiles(self, include_deletes=None):
1236 """An alias to AffectedTestableFiles for backwards compatibility."""
1237 return self.AffectedTestableFiles(include_deletes=include_deletes)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001238
agable0b65e732016-11-22 09:25:46 -08001239 def LocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001240 """Convenience function."""
agable0b65e732016-11-22 09:25:46 -08001241 return [af.LocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001242
agable0b65e732016-11-22 09:25:46 -08001243 def AbsoluteLocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001244 """Convenience function."""
agable0b65e732016-11-22 09:25:46 -08001245 return [af.AbsoluteLocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001246
1247 def RightHandSideLines(self):
Edward Lemura5799e32020-01-17 19:26:51 +00001248 """An iterator over all text lines in 'new' version of changed files.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001249
1250 Lists lines from new or modified text files in the change.
1251
1252 This is useful for doing line-by-line regex checks, like checking for
1253 trailing whitespace.
1254
1255 Yields:
1256 a 3 tuple:
1257 the AffectedFile instance of the current file;
1258 integer line number (1-based); and
1259 the contents of the line as a string.
1260 """
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +00001261 return _RightHandSideLinesImpl(
1262 x for x in self.AffectedFiles(include_deletes=False)
agable0b65e732016-11-22 09:25:46 -08001263 if x.IsTestableFile())
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001264
Jochen Eisingerd0573ec2017-04-13 10:55:06 +02001265 def OriginalOwnersFiles(self):
1266 """A map from path names of affected OWNERS files to their old content."""
1267 def owners_file_filter(f):
1268 return 'OWNERS' in os.path.split(f.LocalPath())[1]
1269 files = self.AffectedFiles(file_filter=owners_file_filter)
1270 return dict([(f.LocalPath(), f.OldContents()) for f in files])
1271
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001272
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001273class GitChange(Change):
1274 _AFFECTED_FILES = GitAffectedFile
maruel@chromium.orgc1938752011-04-12 23:11:13 +00001275 scm = 'git'
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +00001276
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001277 def AllFiles(self, root=None):
1278 """List all files under source control in the repo."""
1279 root = root or self.RepositoryRoot()
1280 return subprocess.check_output(
Aaron Gable7817f022017-12-12 09:43:17 -08001281 ['git', '-c', 'core.quotePath=false', 'ls-files', '--', '.'],
1282 cwd=root).splitlines()
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001283
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001284
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001285def ListRelevantPresubmitFiles(files, root):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001286 """Finds all presubmit files that apply to a given set of source files.
1287
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001288 If inherit-review-settings-ok is present right under root, looks for
1289 PRESUBMIT.py in directories enclosing root.
1290
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001291 Args:
1292 files: An iterable container containing file paths.
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001293 root: Path where to stop searching.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001294
1295 Return:
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001296 List of absolute paths of the existing PRESUBMIT.py scripts.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001297 """
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001298 files = [normpath(os.path.join(root, f)) for f in files]
1299
1300 # List all the individual directories containing files.
1301 directories = set([os.path.dirname(f) for f in files])
1302
1303 # Ignore root if inherit-review-settings-ok is present.
1304 if os.path.isfile(os.path.join(root, 'inherit-review-settings-ok')):
1305 root = None
1306
1307 # Collect all unique directories that may contain PRESUBMIT.py.
1308 candidates = set()
1309 for directory in directories:
1310 while True:
1311 if directory in candidates:
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001312 break
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001313 candidates.add(directory)
1314 if directory == root:
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001315 break
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001316 parent_dir = os.path.dirname(directory)
1317 if parent_dir == directory:
1318 # We hit the system root directory.
1319 break
1320 directory = parent_dir
1321
1322 # Look for PRESUBMIT.py in all candidate directories.
1323 results = []
1324 for directory in sorted(list(candidates)):
tobiasjsff061c02016-08-17 03:23:57 -07001325 try:
1326 for f in os.listdir(directory):
1327 p = os.path.join(directory, f)
1328 if os.path.isfile(p) and re.match(
1329 r'PRESUBMIT.*\.py$', f) and not f.startswith('PRESUBMIT_test'):
1330 results.append(p)
1331 except OSError:
1332 pass
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001333
tobiasjs2836bcf2016-08-16 04:08:16 -07001334 logging.debug('Presubmit files: %s', ','.join(results))
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001335 return results
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001336
1337
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001338class GetTryMastersExecuter(object):
1339 @staticmethod
1340 def ExecPresubmitScript(script_text, presubmit_path, project, change):
1341 """Executes GetPreferredTryMasters() from a single presubmit script.
1342
1343 Args:
1344 script_text: The text of the presubmit script.
1345 presubmit_path: Project script to run.
1346 project: Project name to pass to presubmit script for bot selection.
1347
1348 Return:
1349 A map of try masters to map of builders to set of tests.
1350 """
1351 context = {}
1352 try:
Raul Tambre09e64b42019-05-14 01:57:22 +00001353 exec(compile(script_text, 'PRESUBMIT.py', 'exec', dont_inherit=True),
1354 context)
Raul Tambre7c938462019-05-24 16:35:35 +00001355 except Exception as e:
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001356 raise PresubmitFailure('"%s" had an exception.\n%s'
1357 % (presubmit_path, e))
1358
1359 function_name = 'GetPreferredTryMasters'
1360 if function_name not in context:
1361 return {}
1362 get_preferred_try_masters = context[function_name]
1363 if not len(inspect.getargspec(get_preferred_try_masters)[0]) == 2:
1364 raise PresubmitFailure(
1365 'Expected function "GetPreferredTryMasters" to take two arguments.')
1366 return get_preferred_try_masters(project, change)
1367
1368
rmistry@google.com5626a922015-02-26 14:03:30 +00001369class GetPostUploadExecuter(object):
1370 @staticmethod
Edward Lemur016a0872020-02-04 22:13:28 +00001371 def ExecPresubmitScript(script_text, presubmit_path, gerrit_obj, change):
rmistry@google.com5626a922015-02-26 14:03:30 +00001372 """Executes PostUploadHook() from a single presubmit script.
1373
1374 Args:
1375 script_text: The text of the presubmit script.
1376 presubmit_path: Project script to run.
Edward Lemur016a0872020-02-04 22:13:28 +00001377 gerrit_obj: The GerritAccessor object.
rmistry@google.com5626a922015-02-26 14:03:30 +00001378 change: The Change object.
1379
1380 Return:
1381 A list of results objects.
1382 """
1383 context = {}
1384 try:
Raul Tambre09e64b42019-05-14 01:57:22 +00001385 exec(compile(script_text, 'PRESUBMIT.py', 'exec', dont_inherit=True),
1386 context)
Raul Tambre7c938462019-05-24 16:35:35 +00001387 except Exception as e:
rmistry@google.com5626a922015-02-26 14:03:30 +00001388 raise PresubmitFailure('"%s" had an exception.\n%s'
1389 % (presubmit_path, e))
1390
1391 function_name = 'PostUploadHook'
1392 if function_name not in context:
1393 return {}
1394 post_upload_hook = context[function_name]
1395 if not len(inspect.getargspec(post_upload_hook)[0]) == 3:
1396 raise PresubmitFailure(
1397 'Expected function "PostUploadHook" to take three arguments.')
Edward Lemur016a0872020-02-04 22:13:28 +00001398 return post_upload_hook(gerrit_obj, change, OutputApi(False))
rmistry@google.com5626a922015-02-26 14:03:30 +00001399
1400
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001401def _MergeMasters(masters1, masters2):
1402 """Merges two master maps. Merges also the tests of each builder."""
1403 result = {}
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001404 for (master, builders) in itertools.chain(masters1.items(),
1405 masters2.items()):
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001406 new_builders = result.setdefault(master, {})
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001407 for (builder, tests) in builders.items():
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001408 new_builders.setdefault(builder, set([])).update(tests)
1409 return result
1410
1411
1412def DoGetTryMasters(change,
1413 changed_files,
1414 repository_root,
1415 default_presubmit,
1416 project,
1417 verbose,
1418 output_stream):
1419 """Get the list of try masters from the presubmit scripts.
1420
1421 Args:
1422 changed_files: List of modified files.
1423 repository_root: The repository root.
1424 default_presubmit: A default presubmit script to execute in any case.
1425 project: Optional name of a project used in selecting trybots.
1426 verbose: Prints debug info.
1427 output_stream: A stream to write debug output to.
1428
1429 Return:
1430 Map of try masters to map of builders to set of tests.
1431 """
1432 presubmit_files = ListRelevantPresubmitFiles(changed_files, repository_root)
1433 if not presubmit_files and verbose:
Edward Lemura5799e32020-01-17 19:26:51 +00001434 output_stream.write('Warning, no PRESUBMIT.py found.\n')
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001435 results = {}
1436 executer = GetTryMastersExecuter()
1437
1438 if default_presubmit:
1439 if verbose:
Edward Lemura5799e32020-01-17 19:26:51 +00001440 output_stream.write('Running default presubmit script.\n')
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001441 fake_path = os.path.join(repository_root, 'PRESUBMIT.py')
1442 results = _MergeMasters(results, executer.ExecPresubmitScript(
1443 default_presubmit, fake_path, project, change))
1444 for filename in presubmit_files:
1445 filename = os.path.abspath(filename)
1446 if verbose:
Edward Lemura5799e32020-01-17 19:26:51 +00001447 output_stream.write('Running %s\n' % filename)
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001448 # Accept CRLF presubmit script.
1449 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1450 results = _MergeMasters(results, executer.ExecPresubmitScript(
1451 presubmit_script, filename, project, change))
1452
1453 # Make sets to lists again for later JSON serialization.
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001454 for builders in results.values():
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001455 for builder in builders:
1456 builders[builder] = list(builders[builder])
1457
1458 if results and verbose:
1459 output_stream.write('%s\n' % str(results))
1460 return results
1461
1462
rmistry@google.com5626a922015-02-26 14:03:30 +00001463def DoPostUploadExecuter(change,
Edward Lemur016a0872020-02-04 22:13:28 +00001464 gerrit_obj,
Edward Lemur6eb1d322020-02-27 22:20:15 +00001465 verbose):
rmistry@google.com5626a922015-02-26 14:03:30 +00001466 """Execute the post upload hook.
1467
1468 Args:
1469 change: The Change object.
Edward Lemur016a0872020-02-04 22:13:28 +00001470 gerrit_obj: The GerritAccessor object.
rmistry@google.com5626a922015-02-26 14:03:30 +00001471 verbose: Prints debug info.
rmistry@google.com5626a922015-02-26 14:03:30 +00001472 """
1473 presubmit_files = ListRelevantPresubmitFiles(
Edward Lemur6eb1d322020-02-27 22:20:15 +00001474 change.LocalPaths(), change.RepositoryRoot())
rmistry@google.com5626a922015-02-26 14:03:30 +00001475 if not presubmit_files and verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001476 sys.stdout.write('Warning, no PRESUBMIT.py found.\n')
rmistry@google.com5626a922015-02-26 14:03:30 +00001477 results = []
1478 executer = GetPostUploadExecuter()
1479 # The root presubmit file should be executed after the ones in subdirectories.
1480 # i.e. the specific post upload hooks should run before the general ones.
1481 # Thus, reverse the order provided by ListRelevantPresubmitFiles.
1482 presubmit_files.reverse()
1483
1484 for filename in presubmit_files:
1485 filename = os.path.abspath(filename)
1486 if verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001487 sys.stdout.write('Running %s\n' % filename)
rmistry@google.com5626a922015-02-26 14:03:30 +00001488 # Accept CRLF presubmit script.
1489 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1490 results.extend(executer.ExecPresubmitScript(
Edward Lemur016a0872020-02-04 22:13:28 +00001491 presubmit_script, filename, gerrit_obj, change))
rmistry@google.com5626a922015-02-26 14:03:30 +00001492
Edward Lemur6eb1d322020-02-27 22:20:15 +00001493 if not results:
1494 return 0
1495
1496 sys.stdout.write('\n')
1497 sys.stdout.write('** Post Upload Hook Messages **\n')
1498
1499 exit_code = 0
1500 for result in results:
1501 if result.fatal:
1502 exit_code = 1
1503 result.handle()
1504 sys.stdout.write('\n')
1505
1506 return exit_code
rmistry@google.com5626a922015-02-26 14:03:30 +00001507
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001508class PresubmitExecuter(object):
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001509 def __init__(self, change, committing, verbose, gerrit_obj, dry_run=None,
1510 thread_pool=None, parallel=False, gerrit_project=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001511 """
1512 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001513 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001514 committing: True if 'git cl land' is running, False if 'git cl upload' is.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001515 gerrit_obj: provides basic Gerrit codereview functionality.
1516 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -04001517 parallel: if true, all tests reported via input_api.RunTests for all
1518 PRESUBMIT files will be run in parallel.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001519 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001520 self.change = change
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001521 self.committing = committing
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001522 self.gerrit = gerrit_obj
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001523 self.verbose = verbose
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001524 self.dry_run = dry_run
Daniel Cheng7227d212017-11-17 08:12:37 -08001525 self.more_cc = []
Edward Lesmes8e282792018-04-03 18:50:29 -04001526 self.thread_pool = thread_pool
1527 self.parallel = parallel
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001528 self.gerrit_project = gerrit_project
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001529
1530 def ExecPresubmitScript(self, script_text, presubmit_path):
1531 """Executes a single presubmit script.
1532
1533 Args:
1534 script_text: The text of the presubmit script.
1535 presubmit_path: The path to the presubmit file (this will be reported via
1536 input_api.PresubmitLocalPath()).
1537
1538 Return:
1539 A list of result objects, empty if no problems.
1540 """
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001541
chase@chromium.org8e416c82009-10-06 04:30:44 +00001542 # Change to the presubmit file's directory to support local imports.
1543 main_path = os.getcwd()
Saagar Sanghavi98b332f2020-07-31 17:19:15 +00001544 presubmit_dir = os.path.dirname(presubmit_path)
1545 os.chdir(presubmit_dir)
chase@chromium.org8e416c82009-10-06 04:30:44 +00001546
1547 # Load the presubmit script into context.
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001548 input_api = InputApi(self.change, presubmit_path, self.committing,
Aaron Gable668c1d82018-04-03 10:19:16 -07001549 self.verbose, gerrit_obj=self.gerrit,
Edward Lesmes8e282792018-04-03 18:50:29 -04001550 dry_run=self.dry_run, thread_pool=self.thread_pool,
1551 parallel=self.parallel)
Daniel Cheng7227d212017-11-17 08:12:37 -08001552 output_api = OutputApi(self.committing)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001553 context = {}
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001554
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001555 try:
Raul Tambre09e64b42019-05-14 01:57:22 +00001556 exec(compile(script_text, 'PRESUBMIT.py', 'exec', dont_inherit=True),
1557 context)
Raul Tambre7c938462019-05-24 16:35:35 +00001558 except Exception as e:
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001559 raise PresubmitFailure('"%s" had an exception.\n%s' % (presubmit_path, e))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001560
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001561 context['__args'] = (input_api, output_api)
Ben Pastene8351dc12020-08-06 05:01:35 +00001562
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001563 # Get path of presubmit directory relative to repository root.
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001564 # Always use forward slashes, so that path is same in *nix and Windows
1565 root = input_api.change.RepositoryRoot()
1566 rel_path = os.path.relpath(presubmit_dir, root)
1567 rel_path = rel_path.replace(os.path.sep, '/')
Ben Pastene8351dc12020-08-06 05:01:35 +00001568
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001569 # Get the URL of git remote origin and use it to identify host and project
1570 host = ''
1571 if self.gerrit and self.gerrit.host:
1572 host = self.gerrit.host
1573 project = self.gerrit_project or ''
1574
1575 # Prefix for test names
1576 prefix = 'presubmit:%s/%s:%s/' % (host, project, rel_path)
1577
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001578 # Perform all the desired presubmit checks.
1579 results = []
Ben Pastene8351dc12020-08-06 05:01:35 +00001580
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001581 try:
Scott Leecc2fe9b2020-11-19 19:38:06 +00001582 version = [
1583 int(x) for x in context.get('PRESUBMIT_VERSION', '0.0.0').split('.')
1584 ]
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001585
Scott Leecc2fe9b2020-11-19 19:38:06 +00001586 with rdb_wrapper.client(prefix) as sink:
1587 if version >= [2, 0, 0]:
1588 for function_name in context:
1589 if not function_name.startswith('Check'):
1590 continue
1591 if function_name.endswith('Commit') and not self.committing:
1592 continue
1593 if function_name.endswith('Upload') and self.committing:
1594 continue
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001595 logging.debug('Running %s in %s', function_name, presubmit_path)
1596 results.extend(
Scott Leecc2fe9b2020-11-19 19:38:06 +00001597 self._run_check_function(function_name, context, sink))
1598 logging.debug('Running %s done.', function_name)
1599 self.more_cc.extend(output_api.more_cc)
1600
1601 else: # Old format
1602 if self.committing:
1603 function_name = 'CheckChangeOnCommit'
1604 else:
1605 function_name = 'CheckChangeOnUpload'
1606 if function_name in context:
1607 logging.debug('Running %s in %s', function_name, presubmit_path)
1608 results.extend(
1609 self._run_check_function(function_name, context, sink))
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001610 logging.debug('Running %s done.', function_name)
1611 self.more_cc.extend(output_api.more_cc)
1612
1613 finally:
1614 for f in input_api._named_temporary_files:
1615 os.remove(f)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001616
chase@chromium.org8e416c82009-10-06 04:30:44 +00001617 # Return the process to the original working directory.
1618 os.chdir(main_path)
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001619 return results
1620
Scott Leecc2fe9b2020-11-19 19:38:06 +00001621 def _run_check_function(self, function_name, context, sink=None):
1622 """Evaluates and returns the result of a given presubmit function.
1623
1624 If sink is given, the result of the presubmit function will be reported
1625 to the ResultSink.
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001626
1627 Args:
Scott Leecc2fe9b2020-11-19 19:38:06 +00001628 function_name: the name of the presubmit function to evaluate
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001629 context: a context dictionary in which the function will be evaluated
Scott Leecc2fe9b2020-11-19 19:38:06 +00001630 sink: an instance of ResultSink. None, by default.
1631 Returns:
1632 the result of the presubmit function call.
1633 """
1634 start_time = time_time()
1635 try:
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001636 result = eval(function_name + '(*__args)', context)
1637 self._check_result_type(result)
Scott Leecc2fe9b2020-11-19 19:38:06 +00001638 except:
1639 if sink:
1640 elapsed_time = time_time() - start_time
1641 sink.report(function_name, rdb_wrapper.STATUS_FAIL, elapsed_time)
1642 raise
1643
1644 if sink:
1645 elapsed_time = time_time() - start_time
1646 status = rdb_wrapper.STATUS_PASS
1647 if any(r.fatal for r in result):
1648 status = rdb_wrapper.STATUS_FAIL
1649 sink.report(function_name, status, elapsed_time)
1650
1651 return result
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001652
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00001653 def _check_result_type(self, result):
1654 """Helper function which ensures result is a list, and all elements are
1655 instances of OutputApi.PresubmitResult"""
1656 if not isinstance(result, (tuple, list)):
1657 raise PresubmitFailure('Presubmit functions must return a tuple or list')
1658 if not all(isinstance(res, OutputApi.PresubmitResult) for res in result):
1659 raise PresubmitFailure(
1660 'All presubmit results must be of types derived from '
1661 'output_api.PresubmitResult')
1662
1663
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001664def DoPresubmitChecks(change,
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001665 committing,
1666 verbose,
maruel@chromium.orgb0dfd352009-06-10 14:12:54 +00001667 default_presubmit,
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001668 may_prompt,
Aaron Gable668c1d82018-04-03 10:19:16 -07001669 gerrit_obj,
Edward Lesmes8e282792018-04-03 18:50:29 -04001670 dry_run=None,
Debrian Figueroadd2737e2019-06-21 23:50:13 +00001671 parallel=False,
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001672 json_output=None,
1673 gerrit_project=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001674 """Runs all presubmit checks that apply to the files in the change.
1675
1676 This finds all PRESUBMIT.py files in directories enclosing the files in the
1677 change (up to the repository root) and calls the relevant entrypoint function
1678 depending on whether the change is being committed or uploaded.
1679
1680 Prints errors, warnings and notifications. Prompts the user for warnings
1681 when needed.
1682
1683 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001684 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001685 committing: True if 'git cl land' is running, False if 'git cl upload' is.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001686 verbose: Prints debug info.
maruel@chromium.org0ff1fab2009-05-22 13:08:15 +00001687 default_presubmit: A default presubmit script to execute in any case.
Quinten Yearsley516fe7f2016-12-14 11:50:18 -08001688 may_prompt: Enable (y/n) questions on warning or error. If False,
1689 any questions are answered with yes by default.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001690 gerrit_obj: provides basic Gerrit codereview functionality.
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001691 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -04001692 parallel: if true, all tests specified by input_api.RunTests in all
1693 PRESUBMIT files will be run in parallel.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001694
1695 Return:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001696 1 if presubmit checks failed or 0 otherwise.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001697 """
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001698 old_environ = os.environ
1699 try:
1700 # Make sure python subprocesses won't generate .pyc files.
1701 os.environ = os.environ.copy()
Edward Lemurb9830242019-10-30 22:19:20 +00001702 os.environ['PYTHONDONTWRITEBYTECODE'] = '1'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001703
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001704 if committing:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001705 sys.stdout.write('Running presubmit commit checks ...\n')
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001706 else:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001707 sys.stdout.write('Running presubmit upload checks ...\n')
Edward Lemurecc27072020-01-06 16:42:34 +00001708 start_time = time_time()
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001709 presubmit_files = ListRelevantPresubmitFiles(
agable0b65e732016-11-22 09:25:46 -08001710 change.AbsoluteLocalPaths(), change.RepositoryRoot())
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001711 if not presubmit_files and verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001712 sys.stdout.write('Warning, no PRESUBMIT.py found.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001713 results = []
Edward Lesmes8e282792018-04-03 18:50:29 -04001714 thread_pool = ThreadPool()
Edward Lemur7e3c67f2018-07-20 20:52:49 +00001715 executer = PresubmitExecuter(change, committing, verbose, gerrit_obj,
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001716 dry_run, thread_pool, parallel, gerrit_project)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001717 if default_presubmit:
1718 if verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001719 sys.stdout.write('Running default presubmit script.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001720 fake_path = os.path.join(change.RepositoryRoot(), 'PRESUBMIT.py')
1721 results += executer.ExecPresubmitScript(default_presubmit, fake_path)
1722 for filename in presubmit_files:
1723 filename = os.path.abspath(filename)
1724 if verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001725 sys.stdout.write('Running %s\n' % filename)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001726 # Accept CRLF presubmit script.
1727 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1728 results += executer.ExecPresubmitScript(presubmit_script, filename)
Edward Lesmes8e282792018-04-03 18:50:29 -04001729 results += thread_pool.RunAsync()
1730
Edward Lemur6eb1d322020-02-27 22:20:15 +00001731 messages = {}
1732 should_prompt = False
1733 presubmits_failed = False
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001734 for result in results:
1735 if result.fatal:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001736 presubmits_failed = True
1737 messages.setdefault('ERRORS', []).append(result)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001738 elif result.should_prompt:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001739 should_prompt = True
1740 messages.setdefault('Warnings', []).append(result)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001741 else:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001742 messages.setdefault('Messages', []).append(result)
pam@chromium.orged9a0832009-09-09 22:48:55 +00001743
Edward Lemur6eb1d322020-02-27 22:20:15 +00001744 sys.stdout.write('\n')
1745 for name, items in messages.items():
1746 sys.stdout.write('** Presubmit %s **\n' % name)
1747 for item in items:
1748 item.handle()
1749 sys.stdout.write('\n')
pam@chromium.orged9a0832009-09-09 22:48:55 +00001750
Edward Lemurecc27072020-01-06 16:42:34 +00001751 total_time = time_time() - start_time
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001752 if total_time > 1.0:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001753 sys.stdout.write(
1754 'Presubmit checks took %.1fs to calculate.\n\n' % total_time)
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +00001755
Edward Lemur6eb1d322020-02-27 22:20:15 +00001756 if not should_prompt and not presubmits_failed:
1757 sys.stdout.write('Presubmit checks passed.\n')
1758 elif should_prompt:
1759 sys.stdout.write('There were presubmit warnings. ')
Quinten Yearsley516fe7f2016-12-14 11:50:18 -08001760 if may_prompt:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001761 presubmits_failed = not prompt_should_continue(
1762 'Are you sure you wish to continue? (y/N): ')
Garrett Beatyacb807e2020-08-28 18:17:24 +00001763 else:
1764 sys.stdout.write('\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001765
Edward Lemur1dc66e12020-02-21 21:36:34 +00001766 if json_output:
1767 # Write the presubmit results to json output
1768 presubmit_results = {
1769 'errors': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001770 error.json_format()
1771 for error in messages.get('ERRORS', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001772 ],
1773 'notifications': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001774 notification.json_format()
1775 for notification in messages.get('Messages', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001776 ],
1777 'warnings': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001778 warning.json_format()
1779 for warning in messages.get('Warnings', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001780 ],
Edward Lemur6eb1d322020-02-27 22:20:15 +00001781 'more_cc': executer.more_cc,
Edward Lemur1dc66e12020-02-21 21:36:34 +00001782 }
1783
1784 gclient_utils.FileWrite(
1785 json_output, json.dumps(presubmit_results, sort_keys=True))
1786
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001787 global _ASKED_FOR_FEEDBACK
1788 # Ask for feedback one time out of 5.
1789 if (len(results) and random.randint(0, 4) == 0 and not _ASKED_FOR_FEEDBACK):
Edward Lemur6eb1d322020-02-27 22:20:15 +00001790 sys.stdout.write(
maruel@chromium.org1ce8e662014-01-14 15:23:00 +00001791 'Was the presubmit check useful? If not, run "git cl presubmit -v"\n'
1792 'to figure out which PRESUBMIT.py was run, then run git blame\n'
1793 'on the file to figure out who to ask for help.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001794 _ASKED_FOR_FEEDBACK = True
Edward Lemur6eb1d322020-02-27 22:20:15 +00001795
1796 return 1 if presubmits_failed else 0
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001797 finally:
1798 os.environ = old_environ
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001799
1800
Edward Lemur50984a62020-02-06 18:10:18 +00001801def _scan_sub_dirs(mask, recursive):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001802 if not recursive:
pgervais@chromium.orge57b09d2014-05-07 00:58:13 +00001803 return [x for x in glob.glob(mask) if x not in ('.svn', '.git')]
Lei Zhang9611c4c2017-04-04 01:41:56 -07001804
1805 results = []
1806 for root, dirs, files in os.walk('.'):
1807 if '.svn' in dirs:
1808 dirs.remove('.svn')
1809 if '.git' in dirs:
1810 dirs.remove('.git')
1811 for name in files:
1812 if fnmatch.fnmatch(name, mask):
1813 results.append(os.path.join(root, name))
1814 return results
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001815
1816
Edward Lemur50984a62020-02-06 18:10:18 +00001817def _parse_files(args, recursive):
tobiasjs2836bcf2016-08-16 04:08:16 -07001818 logging.debug('Searching for %s', args)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001819 files = []
1820 for arg in args:
Edward Lemur50984a62020-02-06 18:10:18 +00001821 files.extend([('M', f) for f in _scan_sub_dirs(arg, recursive)])
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001822 return files
1823
1824
Edward Lemur50984a62020-02-06 18:10:18 +00001825def _parse_change(parser, options):
1826 """Process change options.
1827
1828 Args:
1829 parser: The parser used to parse the arguments from command line.
1830 options: The arguments parsed from command line.
1831 Returns:
1832 A GitChange if the change root is a git repository, or a Change otherwise.
1833 """
1834 if options.files and options.all_files:
1835 parser.error('<files> cannot be specified when --all-files is set.')
1836
Edward Lesmes44ea3ff2020-02-05 00:14:30 +00001837 change_scm = scm.determine_scm(options.root)
Edward Lemur50984a62020-02-06 18:10:18 +00001838 if change_scm != 'git' and not options.files:
1839 parser.error('<files> is not optional for unversioned directories.')
1840
1841 if options.files:
1842 change_files = _parse_files(options.files, options.recursive)
1843 elif options.all_files:
1844 change_files = [('M', f) for f in scm.GIT.GetAllFiles(options.root)]
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001845 else:
Edward Lemur50984a62020-02-06 18:10:18 +00001846 change_files = scm.GIT.CaptureStatus(
Edward Lemur7f6dec02020-02-06 20:23:58 +00001847 options.root, options.upstream or None)
Edward Lemur50984a62020-02-06 18:10:18 +00001848
1849 logging.info('Found %d file(s).', len(change_files))
1850
1851 change_class = GitChange if change_scm == 'git' else Change
1852 return change_class(
1853 options.name,
1854 options.description,
1855 options.root,
1856 change_files,
1857 options.issue,
1858 options.patchset,
1859 options.author,
1860 upstream=options.upstream)
1861
1862
1863def _parse_gerrit_options(parser, options):
1864 """Process gerrit options.
1865
1866 SIDE EFFECTS: Modifies options.author and options.description from Gerrit if
1867 options.gerrit_fetch is set.
1868
1869 Args:
1870 parser: The parser used to parse the arguments from command line.
1871 options: The arguments parsed from command line.
1872 Returns:
1873 A GerritAccessor object if options.gerrit_url is set, or None otherwise.
1874 """
1875 gerrit_obj = None
1876 if options.gerrit_url:
1877 gerrit_obj = GerritAccessor(urlparse.urlparse(options.gerrit_url).netloc)
1878
1879 if not options.gerrit_fetch:
1880 return gerrit_obj
1881
1882 if not options.gerrit_url or not options.issue or not options.patchset:
1883 parser.error(
1884 '--gerrit_fetch requires --gerrit_url, --issue and --patchset.')
1885
1886 options.author = gerrit_obj.GetChangeOwner(options.issue)
1887 options.description = gerrit_obj.GetChangeDescription(
1888 options.issue, options.patchset)
1889
1890 logging.info('Got author: "%s"', options.author)
1891 logging.info('Got description: """\n%s\n"""', options.description)
1892
1893 return gerrit_obj
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001894
1895
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001896@contextlib.contextmanager
1897def canned_check_filter(method_names):
1898 filtered = {}
1899 try:
1900 for method_name in method_names:
1901 if not hasattr(presubmit_canned_checks, method_name):
Gavin Make6a62332020-12-04 21:57:10 +00001902 logging.warning('Skipping unknown "canned" check %s' % method_name)
Aaron Gableecee74c2018-04-02 15:13:08 -07001903 continue
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001904 filtered[method_name] = getattr(presubmit_canned_checks, method_name)
1905 setattr(presubmit_canned_checks, method_name, lambda *_a, **_kw: [])
1906 yield
1907 finally:
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001908 for name, method in filtered.items():
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001909 setattr(presubmit_canned_checks, name, method)
1910
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001911
sbc@chromium.org013731e2015-02-26 18:28:43 +00001912def main(argv=None):
Edward Lemura5799e32020-01-17 19:26:51 +00001913 parser = argparse.ArgumentParser(usage='%(prog)s [options] <files...>')
1914 hooks = parser.add_mutually_exclusive_group()
1915 hooks.add_argument('-c', '--commit', action='store_true',
1916 help='Use commit instead of upload checks.')
1917 hooks.add_argument('-u', '--upload', action='store_false', dest='commit',
1918 help='Use upload instead of commit checks.')
Edward Lemur75526302020-02-27 22:31:05 +00001919 hooks.add_argument('--post_upload', action='store_true',
1920 help='Run post-upload commit hooks.')
Edward Lemura5799e32020-01-17 19:26:51 +00001921 parser.add_argument('-r', '--recursive', action='store_true',
1922 help='Act recursively.')
1923 parser.add_argument('-v', '--verbose', action='count', default=0,
1924 help='Use 2 times for more debug info.')
1925 parser.add_argument('--name', default='no name')
1926 parser.add_argument('--author')
Edward Lemur227d5102020-02-25 23:45:35 +00001927 desc = parser.add_mutually_exclusive_group()
1928 desc.add_argument('--description', default='', help='The change description.')
1929 desc.add_argument('--description_file',
1930 help='File to read change description from.')
Edward Lemura5799e32020-01-17 19:26:51 +00001931 parser.add_argument('--issue', type=int, default=0)
1932 parser.add_argument('--patchset', type=int, default=0)
1933 parser.add_argument('--root', default=os.getcwd(),
1934 help='Search for PRESUBMIT.py up to this directory. '
1935 'If inherit-review-settings-ok is present in this '
1936 'directory, parent directories up to the root file '
1937 'system directories will also be searched.')
1938 parser.add_argument('--upstream',
1939 help='Git only: the base ref or upstream branch against '
1940 'which the diff should be computed.')
1941 parser.add_argument('--default_presubmit')
1942 parser.add_argument('--may_prompt', action='store_true', default=False)
1943 parser.add_argument('--skip_canned', action='append', default=[],
1944 help='A list of checks to skip which appear in '
1945 'presubmit_canned_checks. Can be provided multiple times '
1946 'to skip multiple canned checks.')
1947 parser.add_argument('--dry_run', action='store_true', help=argparse.SUPPRESS)
1948 parser.add_argument('--gerrit_url', help=argparse.SUPPRESS)
1949 parser.add_argument('--gerrit_fetch', action='store_true',
1950 help=argparse.SUPPRESS)
1951 parser.add_argument('--parallel', action='store_true',
1952 help='Run all tests specified by input_api.RunTests in '
1953 'all PRESUBMIT files in parallel.')
1954 parser.add_argument('--json_output',
1955 help='Write presubmit errors to json output.')
Edward Lemur1dc66e12020-02-21 21:36:34 +00001956 parser.add_argument('--all_files', action='store_true',
Edward Lemur50984a62020-02-06 18:10:18 +00001957 help='Mark all files under source control as modified.')
Edward Lemura5799e32020-01-17 19:26:51 +00001958 parser.add_argument('files', nargs='*',
1959 help='List of files to be marked as modified when '
1960 'executing presubmit or post-upload hooks. fnmatch '
1961 'wildcards can also be used.')
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001962 parser.add_argument('--gerrit_project', help=argparse.SUPPRESS)
Edward Lemura5799e32020-01-17 19:26:51 +00001963 options = parser.parse_args(argv)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001964
Erik Staabcca5c492020-04-16 17:40:07 +00001965 log_level = logging.ERROR
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001966 if options.verbose >= 2:
Erik Staabcca5c492020-04-16 17:40:07 +00001967 log_level = logging.DEBUG
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001968 elif options.verbose:
Erik Staabcca5c492020-04-16 17:40:07 +00001969 log_level = logging.INFO
1970 log_format = ('[%(levelname).1s%(asctime)s %(process)d %(thread)d '
1971 '%(filename)s] %(message)s')
1972 logging.basicConfig(format=log_format, level=log_level)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001973
Edward Lemur227d5102020-02-25 23:45:35 +00001974 if options.description_file:
1975 options.description = gclient_utils.FileRead(options.description_file)
Edward Lemur50984a62020-02-06 18:10:18 +00001976 gerrit_obj = _parse_gerrit_options(parser, options)
1977 change = _parse_change(parser, options)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001978
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001979 try:
Edward Lemur75526302020-02-27 22:31:05 +00001980 if options.post_upload:
1981 return DoPostUploadExecuter(
1982 change,
1983 gerrit_obj,
1984 options.verbose)
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001985 with canned_check_filter(options.skip_canned):
Edward Lemur6eb1d322020-02-27 22:20:15 +00001986 return DoPresubmitChecks(
Edward Lemur50984a62020-02-06 18:10:18 +00001987 change,
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001988 options.commit,
1989 options.verbose,
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001990 options.default_presubmit,
1991 options.may_prompt,
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001992 gerrit_obj,
Edward Lesmes8e282792018-04-03 18:50:29 -04001993 options.dry_run,
Debrian Figueroadd2737e2019-06-21 23:50:13 +00001994 options.parallel,
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001995 options.json_output,
1996 options.gerrit_project)
Raul Tambre7c938462019-05-24 16:35:35 +00001997 except PresubmitFailure as e:
Raul Tambre80ee78e2019-05-06 22:41:05 +00001998 print(e, file=sys.stderr)
1999 print('Maybe your depot_tools is out of date?', file=sys.stderr)
maruel@chromium.org899e1c12011-04-07 17:03:18 +00002000 return 2
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00002001
2002
2003if __name__ == '__main__':
maruel@chromium.org35625c72011-03-23 17:34:02 +00002004 fix_encoding.fix_encoding()
sbc@chromium.org013731e2015-02-26 18:28:43 +00002005 try:
2006 sys.exit(main())
2007 except KeyboardInterrupt:
2008 sys.stderr.write('interrupted\n')
sergiybf8a3b382016-07-05 11:21:30 -07002009 sys.exit(2)