blob: d69a1cc83e0e81927de09de14fa08a476907c527 [file] [log] [blame]
Josip Sokcevic4de5dea2022-03-23 21:15:14 +00001#!/usr/bin/env vpython3
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +02002# Copyright (c) 2013 The Chromium Authors. All rights reserved.
maruel@chromium.org725f1c32011-04-01 20:24:54 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00006# Copyright (C) 2008 Evan Martin <martine@danga.com>
7
Andrii Shyshkalov03da1502018-10-15 03:42:34 +00008"""A git-command for integrating reviews on Gerrit."""
maruel@chromium.org725f1c32011-04-01 20:24:54 +00009
vapiera7fbd5a2016-06-16 09:17:49 -070010from __future__ import print_function
11
thakis@chromium.org3421c992014-11-02 02:20:32 +000012import base64
rmistry@google.com2dd99862015-06-22 12:22:18 +000013import collections
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +010014import datetime
Brian Sheedyb4307d52019-12-02 19:18:17 +000015import fnmatch
Edward Lemur202c5592019-10-21 22:44:52 +000016import httplib2
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +010017import itertools
maruel@chromium.org4f6852c2012-04-20 20:39:20 +000018import json
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000019import logging
calamity@chromium.orgcf197482016-04-29 20:15:53 +000020import multiprocessing
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000021import optparse
22import os
23import re
Andrii Shyshkalov353637c2017-03-14 16:52:18 +010024import shutil
ukai@chromium.org78c4b982012-02-14 02:20:26 +000025import stat
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000026import sys
Aaron Gable9a03ae02017-11-03 11:31:07 -070027import tempfile
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000028import textwrap
Edward Lemurfec80c42018-11-01 23:14:14 +000029import time
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +000030import uuid
thestig@chromium.org00858c82013-12-02 23:08:03 +000031import webbrowser
thakis@chromium.org3421c992014-11-02 02:20:32 +000032import zlib
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000033
maruel@chromium.org2e23ce32013-05-07 12:42:28 +000034from third_party import colorama
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +000035import auth
nick@chromium.org3ac1c4e2014-01-16 02:44:42 +000036import clang_format
maruel@chromium.org6f09cd92011-04-01 16:38:12 +000037import fix_encoding
maruel@chromium.org0e0436a2011-10-25 13:32:41 +000038import gclient_utils
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +000039import gerrit_util
iannucci@chromium.org9e849272014-04-04 00:31:55 +000040import git_common
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +000041import git_footers
Edward Lemur85153282020-02-14 22:06:29 +000042import git_new_branch
Edward Lemur5ba1e9c2018-07-23 18:19:02 +000043import metrics
Edward Lesmes93277a72018-10-18 22:04:26 +000044import metrics_utils
Edward Lesmeseeca9c62020-11-20 00:00:17 +000045import owners_client
iannucci@chromium.org9e849272014-04-04 00:31:55 +000046import owners_finder
Lei Zhangb8c62cf2020-07-15 20:09:37 +000047import presubmit_canned_checks
maruel@chromium.org2a74d372011-03-29 19:05:50 +000048import presubmit_support
Lukasz Anforowiczb4d39542021-09-30 23:39:25 +000049import rustfmt
maruel@chromium.org2a74d372011-03-29 19:05:50 +000050import scm
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000051import setup_color
Francois Dorayd42c6812017-05-30 15:10:20 -040052import split_cl
maruel@chromium.org0633fb42013-08-16 20:06:14 +000053import subcommand
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +000054import subprocess2
Olivier Robin0a6b5442022-04-07 07:25:04 +000055import swift_format
maruel@chromium.org2a74d372011-03-29 19:05:50 +000056import watchlists
57
Edward Lemur79d4f992019-11-11 23:49:02 +000058from third_party import six
59from six.moves import urllib
60
61
62if sys.version_info.major == 3:
63 basestring = (str,) # pylint: disable=redefined-builtin
64
Edward Lemurb9830242019-10-30 22:19:20 +000065
tandrii7400cf02016-06-21 08:48:07 -070066__version__ = '2.0'
maruel@chromium.org2a74d372011-03-29 19:05:50 +000067
Edward Lemur0f58ae42019-04-30 17:24:12 +000068# Traces for git push will be stored in a traces directory inside the
69# depot_tools checkout.
70DEPOT_TOOLS = os.path.dirname(os.path.abspath(__file__))
71TRACES_DIR = os.path.join(DEPOT_TOOLS, 'traces')
Edward Lemur227d5102020-02-25 23:45:35 +000072PRESUBMIT_SUPPORT = os.path.join(DEPOT_TOOLS, 'presubmit_support.py')
Edward Lemur0f58ae42019-04-30 17:24:12 +000073
74# When collecting traces, Git hashes will be reduced to 6 characters to reduce
75# the size after compression.
76GIT_HASH_RE = re.compile(r'\b([a-f0-9]{6})[a-f0-9]{34}\b', flags=re.I)
77# Used to redact the cookies from the gitcookies file.
78GITCOOKIES_REDACT_RE = re.compile(r'1/.*')
79
Edward Lemurd4d1ba42019-09-20 21:46:37 +000080MAX_ATTEMPTS = 3
81
Edward Lemur1b52d872019-05-09 21:12:12 +000082# The maximum number of traces we will keep. Multiplied by 3 since we store
83# 3 files per trace.
84MAX_TRACES = 3 * 10
Edward Lemur5737f022019-05-17 01:24:00 +000085# Message to be displayed to the user to inform where to find the traces for a
86# git-cl upload execution.
Edward Lemur0f58ae42019-04-30 17:24:12 +000087TRACES_MESSAGE = (
Edward Lemur1b52d872019-05-09 21:12:12 +000088'\n'
Edward Lemur5737f022019-05-17 01:24:00 +000089'The traces of this git-cl execution have been recorded at:\n'
Edward Lemur1b52d872019-05-09 21:12:12 +000090' %(trace_name)s-traces.zip\n'
Edward Lemur5737f022019-05-17 01:24:00 +000091'Copies of your gitcookies file and git config have been recorded at:\n'
92' %(trace_name)s-git-info.zip\n')
Edward Lemur1b52d872019-05-09 21:12:12 +000093# Format of the message to be stored as part of the traces to give developers a
94# better context when they go through traces.
95TRACES_README_FORMAT = (
96'Date: %(now)s\n'
97'\n'
98'Change: https://%(gerrit_host)s/q/%(change_id)s\n'
99'Title: %(title)s\n'
100'\n'
101'%(description)s\n'
102'\n'
103'Execution time: %(execution_time)s\n'
104'Exit code: %(exit_code)s\n') + TRACES_MESSAGE
Edward Lemur0f58ae42019-04-30 17:24:12 +0000105
Aaron Gable1bc7bfe2016-12-19 10:08:14 -0800106POSTUPSTREAM_HOOK = '.git/hooks/post-cl-land'
Henrique Ferreiroff249622019-11-28 23:19:29 +0000107DESCRIPTION_BACKUP_FILE = '.git_cl_description_backup'
rmistry@google.comc68112d2015-03-03 12:48:06 +0000108REFS_THAT_ALIAS_TO_OTHER_REFS = {
Josip Sokcevic7e133ff2021-07-13 17:44:53 +0000109 'refs/remotes/origin/lkgr': 'refs/remotes/origin/main',
110 'refs/remotes/origin/lkcr': 'refs/remotes/origin/main',
rmistry@google.comc68112d2015-03-03 12:48:06 +0000111}
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000112
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000113DEFAULT_OLD_BRANCH = 'refs/remotes/origin/master'
114DEFAULT_NEW_BRANCH = 'refs/remotes/origin/main'
115
thestig@chromium.org44202a22014-03-11 19:22:18 +0000116# Valid extensions for files we want to lint.
117DEFAULT_LINT_REGEX = r"(.*\.cpp|.*\.cc|.*\.h)"
118DEFAULT_LINT_IGNORE_REGEX = r"$^"
119
Aiden Bennerc08566e2018-10-03 17:52:42 +0000120# File name for yapf style config files.
121YAPF_CONFIG_FILENAME = '.style.yapf'
122
Edward Lesmes50da7702020-03-30 19:23:43 +0000123# The issue, patchset and codereview server are stored on git config for each
124# branch under branch.<branch-name>.<config-key>.
125ISSUE_CONFIG_KEY = 'gerritissue'
126PATCHSET_CONFIG_KEY = 'gerritpatchset'
127CODEREVIEW_SERVER_CONFIG_KEY = 'gerritserver'
128
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000129# Shortcut since it quickly becomes repetitive.
maruel@chromium.org2e23ce32013-05-07 12:42:28 +0000130Fore = colorama.Fore
maruel@chromium.org90541732011-04-01 17:54:18 +0000131
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000132# Initialized in main()
133settings = None
134
Andrii Shyshkalov768f1d82016-12-08 15:10:13 +0100135# Used by tests/git_cl_test.py to add extra logging.
136# Inside the weirdly failing test, add this:
137# >>> self.mock(git_cl, '_IS_BEING_TESTED', True)
Quinten Yearsley0c62da92017-05-31 13:39:42 -0700138# And scroll up to see the stack trace printed.
Andrii Shyshkalov768f1d82016-12-08 15:10:13 +0100139_IS_BEING_TESTED = False
140
Garrett Beaty08bb5c42022-09-21 17:34:20 +0000141_GOOGLESOURCE = 'googlesource.com'
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000142
Andrii Shyshkalov1ee78cd2020-03-12 01:31:53 +0000143_KNOWN_GERRIT_TO_SHORT_URLS = {
144 'https://chrome-internal-review.googlesource.com': 'https://crrev.com/i',
145 'https://chromium-review.googlesource.com': 'https://crrev.com/c',
146}
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000147assert len(_KNOWN_GERRIT_TO_SHORT_URLS) == len(
148 set(_KNOWN_GERRIT_TO_SHORT_URLS.values())), 'must have unique values'
Andrii Shyshkalov1ee78cd2020-03-12 01:31:53 +0000149
150
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000151class GitPushError(Exception):
152 pass
153
154
Christopher Lamf732cd52017-01-24 12:40:11 +1100155def DieWithError(message, change_desc=None):
156 if change_desc:
157 SaveDescriptionBackup(change_desc)
Josip Sokcevic953278a2020-02-28 19:46:36 +0000158 print('\n ** Content of CL description **\n' +
159 '='*72 + '\n' +
160 change_desc.description + '\n' +
161 '='*72 + '\n')
Christopher Lamf732cd52017-01-24 12:40:11 +1100162
vapiera7fbd5a2016-06-16 09:17:49 -0700163 print(message, file=sys.stderr)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000164 sys.exit(1)
165
166
Christopher Lamf732cd52017-01-24 12:40:11 +1100167def SaveDescriptionBackup(change_desc):
Henrique Ferreiro5ae48172019-11-29 16:14:42 +0000168 backup_path = os.path.join(DEPOT_TOOLS, DESCRIPTION_BACKUP_FILE)
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000169 print('\nsaving CL description to %s\n' % backup_path)
sokcevic07152802021-08-18 00:06:34 +0000170 with open(backup_path, 'wb') as backup_file:
171 backup_file.write(change_desc.description.encode('utf-8'))
Christopher Lamf732cd52017-01-24 12:40:11 +1100172
173
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000174def GetNoGitPagerEnv():
175 env = os.environ.copy()
176 # 'cat' is a magical git string that disables pagers on all platforms.
177 env['GIT_PAGER'] = 'cat'
178 return env
179
vadimsh@chromium.org566a02a2014-08-22 01:34:13 +0000180
bsep@chromium.org627d9002016-04-29 00:00:52 +0000181def RunCommand(args, error_ok=False, error_message=None, shell=False, **kwargs):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000182 try:
Edward Lemur79d4f992019-11-11 23:49:02 +0000183 stdout = subprocess2.check_output(args, shell=shell, **kwargs)
184 return stdout.decode('utf-8', 'replace')
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000185 except subprocess2.CalledProcessError as e:
186 logging.debug('Failed running %s', args)
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +0000187 if not error_ok:
Alan Cutter594fd332020-07-21 23:55:27 +0000188 message = error_message or e.stdout.decode('utf-8', 'replace') or ''
189 DieWithError('Command "%s" failed.\n%s' % (' '.join(args), message))
Josip Sokcevic673e8ed2021-10-27 23:46:18 +0000190 out = e.stdout.decode('utf-8', 'replace')
191 if e.stderr:
192 out += e.stderr.decode('utf-8', 'replace')
193 return out
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000194
195
196def RunGit(args, **kwargs):
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +0000197 """Returns stdout."""
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000198 return RunCommand(['git'] + args, **kwargs)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000199
200
enne@chromium.org3b7e15c2014-01-21 17:44:47 +0000201def RunGitWithCode(args, suppress_stderr=False):
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +0000202 """Returns return code and stdout."""
tandrii5d48c322016-08-18 16:19:37 -0700203 if suppress_stderr:
Edward Lesmescf06cad2020-12-14 22:03:23 +0000204 stderr = subprocess2.DEVNULL
tandrii5d48c322016-08-18 16:19:37 -0700205 else:
206 stderr = sys.stderr
szager@chromium.org9bb85e22012-06-13 20:28:23 +0000207 try:
tandrii5d48c322016-08-18 16:19:37 -0700208 (out, _), code = subprocess2.communicate(['git'] + args,
209 env=GetNoGitPagerEnv(),
210 stdout=subprocess2.PIPE,
211 stderr=stderr)
Edward Lemur79d4f992019-11-11 23:49:02 +0000212 return code, out.decode('utf-8', 'replace')
tandrii5d48c322016-08-18 16:19:37 -0700213 except subprocess2.CalledProcessError as e:
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +0900214 logging.debug('Failed running %s', ['git'] + args)
Edward Lemur79d4f992019-11-11 23:49:02 +0000215 return e.returncode, e.stdout.decode('utf-8', 'replace')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000216
217
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000218def RunGitSilent(args):
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +0000219 """Returns stdout, suppresses stderr and ignores the return code."""
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000220 return RunGitWithCode(args, suppress_stderr=True)[1]
221
222
tandrii2a16b952016-10-19 07:09:44 -0700223def time_sleep(seconds):
224 # Use this so that it can be mocked in tests without interfering with python
225 # system machinery.
tandrii2a16b952016-10-19 07:09:44 -0700226 return time.sleep(seconds)
227
228
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000229def time_time():
230 # Use this so that it can be mocked in tests without interfering with python
231 # system machinery.
232 return time.time()
233
234
Edward Lemur1b52d872019-05-09 21:12:12 +0000235def datetime_now():
236 # Use this so that it can be mocked in tests without interfering with python
237 # system machinery.
238 return datetime.datetime.now()
239
240
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100241def confirm_or_exit(prefix='', action='confirm'):
242 """Asks user to press enter to continue or press Ctrl+C to abort."""
243 if not prefix or prefix.endswith('\n'):
244 mid = 'Press'
Andrii Shyshkalov353637c2017-03-14 16:52:18 +0100245 elif prefix.endswith('.') or prefix.endswith('?'):
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100246 mid = ' Press'
247 elif prefix.endswith(' '):
248 mid = 'press'
249 else:
250 mid = ' press'
Edward Lesmesae3586b2020-03-23 21:21:14 +0000251 gclient_utils.AskForData(
252 '%s%s Enter to %s, or Ctrl+C to abort' % (prefix, mid, action))
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100253
254
255def ask_for_explicit_yes(prompt):
Quinten Yearsleyd242ed72019-07-25 17:17:55 +0000256 """Returns whether user typed 'y' or 'yes' to confirm the given prompt."""
Edward Lesmesae3586b2020-03-23 21:21:14 +0000257 result = gclient_utils.AskForData(prompt + ' [Yes/No]: ').lower()
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100258 while True:
259 if 'yes'.startswith(result):
260 return True
261 if 'no'.startswith(result):
262 return False
Edward Lesmesae3586b2020-03-23 21:21:14 +0000263 result = gclient_utils.AskForData('Please, type yes or no: ').lower()
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100264
265
machenbach@chromium.org45453142015-09-15 08:45:22 +0000266def _get_properties_from_options(options):
Quinten Yearsleya19d3532019-09-30 21:54:39 +0000267 prop_list = getattr(options, 'properties', [])
268 properties = dict(x.split('=', 1) for x in prop_list)
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +0000269 for key, val in properties.items():
machenbach@chromium.org45453142015-09-15 08:45:22 +0000270 try:
271 properties[key] = json.loads(val)
272 except ValueError:
273 pass # If a value couldn't be evaluated, treat it as a string.
274 return properties
275
276
Edward Lemur4c707a22019-09-24 21:13:43 +0000277def _call_buildbucket(http, buildbucket_host, method, request):
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000278 """Calls a buildbucket v2 method and returns the parsed json response."""
279 headers = {
280 'Accept': 'application/json',
281 'Content-Type': 'application/json',
282 }
283 request = json.dumps(request)
284 url = 'https://%s/prpc/buildbucket.v2.Builds/%s' % (buildbucket_host, method)
285
286 logging.info('POST %s with %s' % (url, request))
287
288 attempts = 1
289 time_to_sleep = 1
290 while True:
291 response, content = http.request(url, 'POST', body=request, headers=headers)
292 if response.status == 200:
293 return json.loads(content[4:])
294 if attempts >= MAX_ATTEMPTS or 400 <= response.status < 500:
295 msg = '%s error when calling POST %s with %s: %s' % (
296 response.status, url, request, content)
297 raise BuildbucketResponseException(msg)
298 logging.debug(
299 '%s error when calling POST %s with %s. '
300 'Sleeping for %d seconds and retrying...' % (
301 response.status, url, request, time_to_sleep))
302 time.sleep(time_to_sleep)
303 time_to_sleep *= 2
304 attempts += 1
305
306 assert False, 'unreachable'
307
308
Edward Lemur6215c792019-10-03 21:59:05 +0000309def _parse_bucket(raw_bucket):
310 legacy = True
311 project = bucket = None
312 if '/' in raw_bucket:
313 legacy = False
314 project, bucket = raw_bucket.split('/', 1)
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000315 # Assume luci.<project>.<bucket>.
Edward Lemur6215c792019-10-03 21:59:05 +0000316 elif raw_bucket.startswith('luci.'):
317 project, bucket = raw_bucket[len('luci.'):].split('.', 1)
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000318 # Otherwise, assume prefix is also the project name.
Edward Lemur6215c792019-10-03 21:59:05 +0000319 elif '.' in raw_bucket:
320 project = raw_bucket.split('.')[0]
321 bucket = raw_bucket
322 # Legacy buckets.
Edward Lemur45768512020-03-02 19:03:14 +0000323 if legacy and project and bucket:
Edward Lemur6215c792019-10-03 21:59:05 +0000324 print('WARNING Please use %s/%s to specify the bucket.' % (project, bucket))
325 return project, bucket
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000326
327
Garrett Beaty08bb5c42022-09-21 17:34:20 +0000328def _canonical_git_googlesource_host(host):
329 """Normalizes Gerrit hosts (with '-review') to Git host."""
330 assert host.endswith(_GOOGLESOURCE)
331 # Prefix doesn't include '.' at the end.
332 prefix = host[:-(1 + len(_GOOGLESOURCE))]
333 if prefix.endswith('-review'):
334 prefix = prefix[:-len('-review')]
335 return prefix + '.' + _GOOGLESOURCE
336
337
338def _canonical_gerrit_googlesource_host(host):
339 git_host = _canonical_git_googlesource_host(host)
340 prefix = git_host.split('.', 1)[0]
341 return prefix + '-review.' + _GOOGLESOURCE
342
343
344def _get_counterpart_host(host):
345 assert host.endswith(_GOOGLESOURCE)
346 git = _canonical_git_googlesource_host(host)
347 gerrit = _canonical_gerrit_googlesource_host(git)
348 return git if gerrit == host else gerrit
349
350
Quinten Yearsley777660f2020-03-04 23:37:06 +0000351def _trigger_tryjobs(changelist, jobs, options, patchset):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000352 """Sends a request to Buildbucket to trigger tryjobs for a changelist.
qyearsley1fdfcb62016-10-24 13:22:03 -0700353
354 Args:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000355 changelist: Changelist that the tryjobs are associated with.
Edward Lemur45768512020-03-02 19:03:14 +0000356 jobs: A list of (project, bucket, builder).
qyearsley1fdfcb62016-10-24 13:22:03 -0700357 options: Command-line options.
358 """
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000359 print('Scheduling jobs on:')
Edward Lemur45768512020-03-02 19:03:14 +0000360 for project, bucket, builder in jobs:
361 print(' %s/%s: %s' % (project, bucket, builder))
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000362 print('To see results here, run: git cl try-results')
363 print('To see results in browser, run: git cl web')
tandriide281ae2016-10-12 06:02:30 -0700364
Quinten Yearsley777660f2020-03-04 23:37:06 +0000365 requests = _make_tryjob_schedule_requests(changelist, jobs, options, patchset)
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +0000366 if not requests:
367 return
368
Edward Lemur5b929a42019-10-21 17:57:39 +0000369 http = auth.Authenticator().authorize(httplib2.Http())
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +0000370 http.force_exception_to_status_code = True
371
372 batch_request = {'requests': requests}
373 batch_response = _call_buildbucket(
374 http, options.buildbucket_host, 'Batch', batch_request)
375
376 errors = [
377 ' ' + response['error']['message']
378 for response in batch_response.get('responses', [])
379 if 'error' in response
380 ]
381 if errors:
382 raise BuildbucketResponseException(
383 'Failed to schedule builds for some bots:\n%s' % '\n'.join(errors))
384
385
Quinten Yearsley777660f2020-03-04 23:37:06 +0000386def _make_tryjob_schedule_requests(changelist, jobs, options, patchset):
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +0000387 """Constructs requests for Buildbucket to trigger tryjobs."""
Edward Lemurf0faf482019-09-25 20:40:17 +0000388 gerrit_changes = [changelist.GetGerritChange(patchset)]
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +0000389 shared_properties = {
390 'category': options.ensure_value('category', 'git_cl_try')
391 }
392 if options.ensure_value('clobber', False):
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000393 shared_properties['clobber'] = True
394 shared_properties.update(_get_properties_from_options(options) or {})
395
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +0000396 shared_tags = [{'key': 'user_agent', 'value': 'git_cl_try'}]
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +0000397 if options.ensure_value('retry_failed', False):
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +0000398 shared_tags.append({'key': 'retry_failed',
399 'value': '1'})
400
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000401 requests = []
Edward Lemur45768512020-03-02 19:03:14 +0000402 for (project, bucket, builder) in jobs:
403 properties = shared_properties.copy()
404 if 'presubmit' in builder.lower():
405 properties['dry_run'] = 'true'
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000406
Edward Lemur45768512020-03-02 19:03:14 +0000407 requests.append({
408 'scheduleBuild': {
409 'requestId': str(uuid.uuid4()),
410 'builder': {
411 'project': getattr(options, 'project', None) or project,
412 'bucket': bucket,
413 'builder': builder,
414 },
415 'gerritChanges': gerrit_changes,
416 'properties': properties,
417 'tags': [
418 {'key': 'builder', 'value': builder},
419 ] + shared_tags,
420 }
421 })
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000422
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +0000423 if options.ensure_value('revision', None):
Josip Sokcevic9011a5b2021-02-12 18:59:44 +0000424 remote, remote_branch = changelist.GetRemoteBranch()
Edward Lemur45768512020-03-02 19:03:14 +0000425 requests[-1]['scheduleBuild']['gitilesCommit'] = {
Garrett Beaty08bb5c42022-09-21 17:34:20 +0000426 'host': _canonical_git_googlesource_host(gerrit_changes[0]['host']),
Edward Lemur45768512020-03-02 19:03:14 +0000427 'project': gerrit_changes[0]['project'],
Josip Sokcevic9011a5b2021-02-12 18:59:44 +0000428 'id': options.revision,
429 'ref': GetTargetRef(remote, remote_branch, None)
Garrett Beaty08bb5c42022-09-21 17:34:20 +0000430 }
Anthony Polito1a5fe232020-01-24 23:17:52 +0000431
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +0000432 return requests
kjellander@chromium.org44424542015-06-02 18:35:29 +0000433
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000434
Quinten Yearsley777660f2020-03-04 23:37:06 +0000435def _fetch_tryjobs(changelist, buildbucket_host, patchset=None):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000436 """Fetches tryjobs from buildbucket.
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000437
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000438 Returns list of buildbucket.v2.Build with the try jobs for the changelist.
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000439 """
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +0000440 fields = ['id', 'builder', 'status', 'createTime', 'tags']
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000441 request = {
442 'predicate': {
443 'gerritChanges': [changelist.GetGerritChange(patchset)],
444 },
445 'fields': ','.join('builds.*.' + field for field in fields),
446 }
tandrii221ab252016-10-06 08:12:04 -0700447
Edward Lemur5b929a42019-10-21 17:57:39 +0000448 authenticator = auth.Authenticator()
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000449 if authenticator.has_cached_credentials():
450 http = authenticator.authorize(httplib2.Http())
451 else:
vapiera7fbd5a2016-06-16 09:17:49 -0700452 print('Warning: Some results might be missing because %s' %
453 # Get the message on how to login.
Andrii Shyshkalov2517afd2021-01-19 17:07:43 +0000454 (str(auth.LoginRequiredError()),))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000455 http = httplib2.Http()
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000456 http.force_exception_to_status_code = True
457
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000458 response = _call_buildbucket(http, buildbucket_host, 'SearchBuilds', request)
459 return response.get('builds', [])
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000460
Edward Lemur45768512020-03-02 19:03:14 +0000461
Edward Lemur5b929a42019-10-21 17:57:39 +0000462def _fetch_latest_builds(changelist, buildbucket_host, latest_patchset=None):
Quinten Yearsley983111f2019-09-26 17:18:48 +0000463 """Fetches builds from the latest patchset that has builds (within
464 the last few patchsets).
465
466 Args:
Quinten Yearsley983111f2019-09-26 17:18:48 +0000467 changelist (Changelist): The CL to fetch builds for
468 buildbucket_host (str): Buildbucket host, e.g. "cr-buildbucket.appspot.com"
Andrii Shyshkalov1ad58112019-10-08 01:46:14 +0000469 lastest_patchset(int|NoneType): the patchset to start fetching builds from.
470 If None (default), starts with the latest available patchset.
Quinten Yearsley983111f2019-09-26 17:18:48 +0000471 Returns:
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000472 A tuple (builds, patchset) where builds is a list of buildbucket.v2.Build,
473 and patchset is the patchset number where those builds came from.
Quinten Yearsley983111f2019-09-26 17:18:48 +0000474 """
475 assert buildbucket_host
476 assert changelist.GetIssue(), 'CL must be uploaded first'
477 assert changelist.GetCodereviewServer(), 'CL must be uploaded first'
Andrii Shyshkalov1ad58112019-10-08 01:46:14 +0000478 if latest_patchset is None:
479 assert changelist.GetMostRecentPatchset()
480 ps = changelist.GetMostRecentPatchset()
481 else:
482 assert latest_patchset > 0, latest_patchset
483 ps = latest_patchset
484
Quinten Yearsley983111f2019-09-26 17:18:48 +0000485 min_ps = max(1, ps - 5)
486 while ps >= min_ps:
Quinten Yearsley777660f2020-03-04 23:37:06 +0000487 builds = _fetch_tryjobs(changelist, buildbucket_host, patchset=ps)
Quinten Yearsley983111f2019-09-26 17:18:48 +0000488 if len(builds):
489 return builds, ps
490 ps -= 1
491 return [], 0
492
493
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +0000494def _filter_failed_for_retry(all_builds):
495 """Returns a list of buckets/builders that are worth retrying.
Quinten Yearsley983111f2019-09-26 17:18:48 +0000496
497 Args:
Quinten Yearsley777660f2020-03-04 23:37:06 +0000498 all_builds (list): Builds, in the format returned by _fetch_tryjobs,
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000499 i.e. a list of buildbucket.v2.Builds which includes status and builder
500 info.
Quinten Yearsley983111f2019-09-26 17:18:48 +0000501
502 Returns:
Edward Lemur45768512020-03-02 19:03:14 +0000503 A dict {(proj, bucket): [builders]}. This is the same format accepted by
Quinten Yearsley777660f2020-03-04 23:37:06 +0000504 _trigger_tryjobs.
Quinten Yearsley983111f2019-09-26 17:18:48 +0000505 """
Edward Lemur45768512020-03-02 19:03:14 +0000506 grouped = {}
507 for build in all_builds:
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +0000508 builder = build['builder']
Edward Lemur45768512020-03-02 19:03:14 +0000509 key = (builder['project'], builder['bucket'], builder['builder'])
510 grouped.setdefault(key, []).append(build)
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +0000511
Edward Lemur45768512020-03-02 19:03:14 +0000512 jobs = []
513 for (project, bucket, builder), builds in grouped.items():
514 if 'triggered' in builder:
515 print('WARNING: Not scheduling %s. Triggered bots require an initial job '
516 'from a parent. Please schedule a manual job for the parent '
517 'instead.')
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +0000518 continue
519 if any(b['status'] in ('STARTED', 'SCHEDULED') for b in builds):
520 # Don't retry if any are running.
521 continue
Edward Lemur45768512020-03-02 19:03:14 +0000522 # If builder had several builds, retry only if the last one failed.
523 # This is a bit different from CQ, which would re-use *any* SUCCESS-full
524 # build, but in case of retrying failed jobs retrying a flaky one makes
525 # sense.
526 builds = sorted(builds, key=lambda b: b['createTime'])
527 if builds[-1]['status'] not in ('FAILURE', 'INFRA_FAILURE'):
528 continue
529 # Don't retry experimental build previously triggered by CQ.
530 if any(t['key'] == 'cq_experimental' and t['value'] == 'true'
531 for t in builds[-1]['tags']):
532 continue
533 jobs.append((project, bucket, builder))
534
535 # Sort the jobs to make testing easier.
536 return sorted(jobs)
Quinten Yearsley983111f2019-09-26 17:18:48 +0000537
538
Quinten Yearsley777660f2020-03-04 23:37:06 +0000539def _print_tryjobs(options, builds):
540 """Prints nicely result of _fetch_tryjobs."""
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000541 if not builds:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000542 print('No tryjobs scheduled.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000543 return
544
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000545 longest_builder = max(len(b['builder']['builder']) for b in builds)
546 name_fmt = '{builder:<%d}' % longest_builder
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000547 if options.print_master:
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000548 longest_bucket = max(len(b['builder']['bucket']) for b in builds)
549 name_fmt = ('{bucket:>%d} ' % longest_bucket) + name_fmt
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000550
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000551 builds_by_status = {}
552 for b in builds:
553 builds_by_status.setdefault(b['status'], []).append({
554 'id': b['id'],
555 'name': name_fmt.format(
556 builder=b['builder']['builder'], bucket=b['builder']['bucket']),
557 })
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000558
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000559 sort_key = lambda b: (b['name'], b['id'])
560
561 def print_builds(title, builds, fmt=None, color=None):
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000562 """Pop matching builds from `builds` dict and print them."""
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000563 if not builds:
564 return
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000565
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000566 fmt = fmt or '{name} https://ci.chromium.org/b/{id}'
tandrii@chromium.org6cf98c82016-03-15 11:56:00 +0000567 if not options.color or color is None:
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000568 colorize = lambda x: x
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000569 else:
570 colorize = lambda x: '%s%s%s' % (color, x, Fore.RESET)
571
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000572 print(colorize(title))
573 for b in sorted(builds, key=sort_key):
574 print(' ', colorize(fmt.format(**b)))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000575
576 total = len(builds)
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000577 print_builds(
578 'Successes:', builds_by_status.pop('SUCCESS', []), color=Fore.GREEN)
579 print_builds(
580 'Infra Failures:', builds_by_status.pop('INFRA_FAILURE', []),
581 color=Fore.MAGENTA)
582 print_builds('Failures:', builds_by_status.pop('FAILURE', []), color=Fore.RED)
583 print_builds('Canceled:', builds_by_status.pop('CANCELED', []), fmt='{name}',
584 color=Fore.MAGENTA)
Andrii Shyshkalov792630c2020-10-19 16:47:44 +0000585 print_builds('Started:', builds_by_status.pop('STARTED', []),
586 color=Fore.YELLOW)
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000587 print_builds(
588 'Scheduled:', builds_by_status.pop('SCHEDULED', []), fmt='{name} id={id}')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000589 # The last section is just in case buildbucket API changes OR there is a bug.
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000590 print_builds(
591 'Other:', sum(builds_by_status.values(), []), fmt='{name} id={id}')
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000592 print('Total: %d tryjobs' % total)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000593
594
Aiden Bennerc08566e2018-10-03 17:52:42 +0000595def _ComputeDiffLineRanges(files, upstream_commit):
596 """Gets the changed line ranges for each file since upstream_commit.
597
598 Parses a git diff on provided files and returns a dict that maps a file name
599 to an ordered list of range tuples in the form (start_line, count).
600 Ranges are in the same format as a git diff.
601 """
602 # If files is empty then diff_output will be a full diff.
603 if len(files) == 0:
604 return {}
605
Aiden Benner6c18a1a2018-11-23 20:18:23 +0000606 # Take the git diff and find the line ranges where there are changes.
Jamie Madill3671a6a2019-10-24 15:13:21 +0000607 diff_cmd = BuildGitDiffCmd('-U0', upstream_commit, files, allow_prefix=True)
Aiden Bennerc08566e2018-10-03 17:52:42 +0000608 diff_output = RunGit(diff_cmd)
609
610 pattern = r'(?:^diff --git a/(?:.*) b/(.*))|(?:^@@.*\+(.*) @@)'
611 # 2 capture groups
612 # 0 == fname of diff file
613 # 1 == 'diff_start,diff_count' or 'diff_start'
614 # will match each of
615 # diff --git a/foo.foo b/foo.py
616 # @@ -12,2 +14,3 @@
617 # @@ -12,2 +17 @@
618 # running re.findall on the above string with pattern will give
619 # [('foo.py', ''), ('', '14,3'), ('', '17')]
620
621 curr_file = None
622 line_diffs = {}
623 for match in re.findall(pattern, diff_output, flags=re.MULTILINE):
624 if match[0] != '':
625 # Will match the second filename in diff --git a/a.py b/b.py.
626 curr_file = match[0]
627 line_diffs[curr_file] = []
628 else:
629 # Matches +14,3
630 if ',' in match[1]:
631 diff_start, diff_count = match[1].split(',')
632 else:
633 # Single line changes are of the form +12 instead of +12,1.
634 diff_start = match[1]
635 diff_count = 1
636
637 diff_start = int(diff_start)
638 diff_count = int(diff_count)
639
640 # If diff_count == 0 this is a removal we can ignore.
641 line_diffs[curr_file].append((diff_start, diff_count))
642
643 return line_diffs
644
645
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000646def _FindYapfConfigFile(fpath, yapf_config_cache, top_dir=None):
Aiden Bennerc08566e2018-10-03 17:52:42 +0000647 """Checks if a yapf file is in any parent directory of fpath until top_dir.
648
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000649 Recursively checks parent directories to find yapf file and if no yapf file
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000650 is found returns None. Uses yapf_config_cache as a cache for previously found
651 configs.
Aiden Bennerc08566e2018-10-03 17:52:42 +0000652 """
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000653 fpath = os.path.abspath(fpath)
Aiden Bennerc08566e2018-10-03 17:52:42 +0000654 # Return result if we've already computed it.
655 if fpath in yapf_config_cache:
656 return yapf_config_cache[fpath]
657
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000658 parent_dir = os.path.dirname(fpath)
659 if os.path.isfile(fpath):
660 ret = _FindYapfConfigFile(parent_dir, yapf_config_cache, top_dir)
Aiden Bennerc08566e2018-10-03 17:52:42 +0000661 else:
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000662 # Otherwise fpath is a directory
663 yapf_file = os.path.join(fpath, YAPF_CONFIG_FILENAME)
664 if os.path.isfile(yapf_file):
665 ret = yapf_file
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +0000666 elif fpath in (top_dir, parent_dir):
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000667 # If we're at the top level directory, or if we're at root
668 # there is no provided style.
669 ret = None
670 else:
671 # Otherwise recurse on the current directory.
672 ret = _FindYapfConfigFile(parent_dir, yapf_config_cache, top_dir)
Aiden Bennerc08566e2018-10-03 17:52:42 +0000673 yapf_config_cache[fpath] = ret
674 return ret
675
676
Brian Sheedyb4307d52019-12-02 19:18:17 +0000677def _GetYapfIgnorePatterns(top_dir):
678 """Returns all patterns in the .yapfignore file.
Brian Sheedy59b06a82019-10-14 17:03:29 +0000679
680 yapf is supposed to handle the ignoring of files listed in .yapfignore itself,
681 but this functionality appears to break when explicitly passing files to
682 yapf for formatting. According to
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000683 https://github.com/google/yapf/blob/HEAD/README.rst#excluding-files-from-formatting-yapfignore,
Brian Sheedy59b06a82019-10-14 17:03:29 +0000684 the .yapfignore file should be in the directory that yapf is invoked from,
685 which we assume to be the top level directory in this case.
686
687 Args:
688 top_dir: The top level directory for the repository being formatted.
689
690 Returns:
Brian Sheedyb4307d52019-12-02 19:18:17 +0000691 A set of all fnmatch patterns to be ignored.
Brian Sheedy59b06a82019-10-14 17:03:29 +0000692 """
693 yapfignore_file = os.path.join(top_dir, '.yapfignore')
Brian Sheedyb4307d52019-12-02 19:18:17 +0000694 ignore_patterns = set()
Brian Sheedy59b06a82019-10-14 17:03:29 +0000695 if not os.path.exists(yapfignore_file):
Brian Sheedyb4307d52019-12-02 19:18:17 +0000696 return ignore_patterns
Brian Sheedy59b06a82019-10-14 17:03:29 +0000697
Anthony Politoc64e3902021-04-30 21:55:25 +0000698 for line in gclient_utils.FileRead(yapfignore_file).split('\n'):
699 stripped_line = line.strip()
700 # Comments and blank lines should be ignored.
701 if stripped_line.startswith('#') or stripped_line == '':
702 continue
703 ignore_patterns.add(stripped_line)
Brian Sheedyb4307d52019-12-02 19:18:17 +0000704 return ignore_patterns
705
706
707def _FilterYapfIgnoredFiles(filepaths, patterns):
708 """Filters out any filepaths that match any of the given patterns.
709
710 Args:
711 filepaths: An iterable of strings containing filepaths to filter.
712 patterns: An iterable of strings containing fnmatch patterns to filter on.
713
714 Returns:
715 A list of strings containing all the elements of |filepaths| that did not
716 match any of the patterns in |patterns|.
717 """
718 # Not inlined so that tests can use the same implementation.
719 return [f for f in filepaths
720 if not any(fnmatch.fnmatch(f, p) for p in patterns)]
Brian Sheedy59b06a82019-10-14 17:03:29 +0000721
722
Aaron Gable13101a62018-02-09 13:20:41 -0800723def print_stats(args):
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000724 """Prints statistics about the change to the user."""
725 # --no-ext-diff is broken in some versions of Git, so try to work around
726 # this by overriding the environment (but there is still a problem if the
727 # git config key "diff.external" is used).
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000728 env = GetNoGitPagerEnv()
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000729 if 'GIT_EXTERNAL_DIFF' in env:
730 del env['GIT_EXTERNAL_DIFF']
iannucci@chromium.org79540052012-10-19 23:15:26 +0000731
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000732 return subprocess2.call(
Aaron Gable13101a62018-02-09 13:20:41 -0800733 ['git', 'diff', '--no-ext-diff', '--stat', '-l100000', '-C50'] + args,
Edward Lemur0db01f02019-11-12 22:01:51 +0000734 env=env)
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000735
736
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000737class BuildbucketResponseException(Exception):
738 pass
739
740
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000741class Settings(object):
742 def __init__(self):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000743 self.cc = None
thestig@chromium.org7a54e812014-02-11 19:57:22 +0000744 self.root = None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000745 self.tree_status_url = None
746 self.viewvc_url = None
747 self.updated = False
ukai@chromium.orge8077812012-02-03 03:41:46 +0000748 self.is_gerrit = None
bauerb@chromium.org54b400c2016-01-14 10:08:25 +0000749 self.squash_gerrit_uploads = None
tandrii@chromium.org28253532016-04-14 13:46:56 +0000750 self.gerrit_skip_ensure_authenticated = None
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000751 self.git_editor = None
Jamie Madilldc4d19e2019-10-24 21:50:02 +0000752 self.format_full_by_default = None
Sigurd Schneider1bfda8e2021-06-30 14:46:25 +0000753 self.is_status_commit_order_by_date = None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000754
Edward Lemur26964072020-02-19 19:18:51 +0000755 def _LazyUpdateIfNeeded(self):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000756 """Updates the settings from a codereview.settings file, if available."""
Edward Lemur26964072020-02-19 19:18:51 +0000757 if self.updated:
758 return
pgervais@chromium.org87884cc2014-01-03 22:23:41 +0000759
Edward Lemur26964072020-02-19 19:18:51 +0000760 # The only value that actually changes the behavior is
761 # autoupdate = "false". Everything else means "true".
762 autoupdate = (
763 scm.GIT.GetConfig(self.GetRoot(), 'rietveld.autoupdate', '').lower())
764
765 cr_settings_file = FindCodereviewSettingsFile()
766 if autoupdate != 'false' and cr_settings_file:
767 LoadCodereviewSettingsFromFile(cr_settings_file)
768 cr_settings_file.close()
769
770 self.updated = True
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000771
thestig@chromium.org7a54e812014-02-11 19:57:22 +0000772 @staticmethod
773 def GetRelativeRoot():
Edward Lesmes50da7702020-03-30 19:23:43 +0000774 return scm.GIT.GetCheckoutRoot('.')
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000775
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000776 def GetRoot(self):
thestig@chromium.org7a54e812014-02-11 19:57:22 +0000777 if self.root is None:
778 self.root = os.path.abspath(self.GetRelativeRoot())
779 return self.root
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000780
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000781 def GetTreeStatusUrl(self, error_ok=False):
782 if not self.tree_status_url:
Edward Lemur26964072020-02-19 19:18:51 +0000783 self.tree_status_url = self._GetConfig('rietveld.tree-status-url')
784 if self.tree_status_url is None and not error_ok:
785 DieWithError(
786 'You must configure your tree status URL by running '
787 '"git cl config".')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000788 return self.tree_status_url
789
790 def GetViewVCUrl(self):
791 if not self.viewvc_url:
Edward Lemur26964072020-02-19 19:18:51 +0000792 self.viewvc_url = self._GetConfig('rietveld.viewvc-url')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000793 return self.viewvc_url
794
rmistry@google.com90752582014-01-14 21:04:50 +0000795 def GetBugPrefix(self):
Edward Lemur26964072020-02-19 19:18:51 +0000796 return self._GetConfig('rietveld.bug-prefix')
rmistry@google.com78948ed2015-07-08 23:09:57 +0000797
rmistry@google.com5626a922015-02-26 14:03:30 +0000798 def GetRunPostUploadHook(self):
Edward Lemur61ea3072018-12-01 00:34:36 +0000799 run_post_upload_hook = self._GetConfig(
Edward Lemur26964072020-02-19 19:18:51 +0000800 'rietveld.run-post-upload-hook')
rmistry@google.com5626a922015-02-26 14:03:30 +0000801 return run_post_upload_hook == "True"
802
bauerb@chromium.orgae6df352011-04-06 17:40:39 +0000803 def GetDefaultCCList(self):
Edward Lemur26964072020-02-19 19:18:51 +0000804 return self._GetConfig('rietveld.cc')
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000805
Dirk Pranke6f0df682021-06-25 00:42:33 +0000806 def GetUsePython3(self):
807 return self._GetConfig('rietveld.use-python3')
808
bauerb@chromium.org54b400c2016-01-14 10:08:25 +0000809 def GetSquashGerritUploads(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000810 """Returns True if uploads to Gerrit should be squashed by default."""
bauerb@chromium.org54b400c2016-01-14 10:08:25 +0000811 if self.squash_gerrit_uploads is None:
Edward Lesmes4de54132020-05-05 19:41:33 +0000812 self.squash_gerrit_uploads = self.GetSquashGerritUploadsOverride()
813 if self.squash_gerrit_uploads is None:
Edward Lemur26964072020-02-19 19:18:51 +0000814 # Default is squash now (http://crbug.com/611892#c23).
815 self.squash_gerrit_uploads = self._GetConfig(
816 'gerrit.squash-uploads').lower() != 'false'
bauerb@chromium.org54b400c2016-01-14 10:08:25 +0000817 return self.squash_gerrit_uploads
818
Edward Lesmes4de54132020-05-05 19:41:33 +0000819 def GetSquashGerritUploadsOverride(self):
820 """Return True or False if codereview.settings should be overridden.
821
822 Returns None if no override has been defined.
823 """
824 # See also http://crbug.com/611892#c23
825 result = self._GetConfig('gerrit.override-squash-uploads').lower()
826 if result == 'true':
827 return True
828 if result == 'false':
829 return False
830 return None
831
Aleksey Khoroshilov35ef5ad2022-06-03 18:29:25 +0000832 def GetIsGerrit(self):
833 """Return True if gerrit.host is set."""
834 if self.is_gerrit is None:
835 self.is_gerrit = bool(self._GetConfig('gerrit.host', False))
836 return self.is_gerrit
837
tandrii@chromium.org28253532016-04-14 13:46:56 +0000838 def GetGerritSkipEnsureAuthenticated(self):
839 """Return True if EnsureAuthenticated should not be done for Gerrit
840 uploads."""
841 if self.gerrit_skip_ensure_authenticated is None:
Edward Lemur26964072020-02-19 19:18:51 +0000842 self.gerrit_skip_ensure_authenticated = self._GetConfig(
843 'gerrit.skip-ensure-authenticated').lower() == 'true'
tandrii@chromium.org28253532016-04-14 13:46:56 +0000844 return self.gerrit_skip_ensure_authenticated
845
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000846 def GetGitEditor(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000847 """Returns the editor specified in the git config, or None if none is."""
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000848 if self.git_editor is None:
Raul Tambre5a525872019-02-12 19:08:08 +0000849 # Git requires single quotes for paths with spaces. We need to replace
850 # them with double quotes for Windows to treat such paths as a single
851 # path.
Edward Lemur26964072020-02-19 19:18:51 +0000852 self.git_editor = self._GetConfig('core.editor').replace('\'', '"')
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000853 return self.git_editor or None
854
thestig@chromium.org44202a22014-03-11 19:22:18 +0000855 def GetLintRegex(self):
Edward Lemur26964072020-02-19 19:18:51 +0000856 return self._GetConfig('rietveld.cpplint-regex', DEFAULT_LINT_REGEX)
thestig@chromium.org44202a22014-03-11 19:22:18 +0000857
858 def GetLintIgnoreRegex(self):
Edward Lemur26964072020-02-19 19:18:51 +0000859 return self._GetConfig(
860 'rietveld.cpplint-ignore-regex', DEFAULT_LINT_IGNORE_REGEX)
thestig@chromium.org44202a22014-03-11 19:22:18 +0000861
Jamie Madilldc4d19e2019-10-24 21:50:02 +0000862 def GetFormatFullByDefault(self):
863 if self.format_full_by_default is None:
Jamie Madillac6f6232021-07-07 20:54:08 +0000864 self._LazyUpdateIfNeeded()
Jamie Madilldc4d19e2019-10-24 21:50:02 +0000865 result = (
866 RunGit(['config', '--bool', 'rietveld.format-full-by-default'],
867 error_ok=True).strip())
868 self.format_full_by_default = (result == 'true')
869 return self.format_full_by_default
870
Sigurd Schneider1bfda8e2021-06-30 14:46:25 +0000871 def IsStatusCommitOrderByDate(self):
872 if self.is_status_commit_order_by_date is None:
873 result = (RunGit(['config', '--bool', 'cl.date-order'],
874 error_ok=True).strip())
875 self.is_status_commit_order_by_date = (result == 'true')
876 return self.is_status_commit_order_by_date
877
Edward Lemur26964072020-02-19 19:18:51 +0000878 def _GetConfig(self, key, default=''):
879 self._LazyUpdateIfNeeded()
880 return scm.GIT.GetConfig(self.GetRoot(), key, default)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000881
882
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +0000883class _CQState(object):
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +0000884 """Enum for states of CL with respect to CQ."""
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +0000885 NONE = 'none'
Greg Gutermanbe5fccd2021-06-14 17:58:20 +0000886 QUICK_RUN = 'quick_run'
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +0000887 DRY_RUN = 'dry_run'
888 COMMIT = 'commit'
889
Greg Gutermanbe5fccd2021-06-14 17:58:20 +0000890 ALL_STATES = [NONE, QUICK_RUN, DRY_RUN, COMMIT]
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +0000891
892
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000893class _ParsedIssueNumberArgument(object):
Edward Lemurf38bc172019-09-03 21:02:13 +0000894 def __init__(self, issue=None, patchset=None, hostname=None):
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000895 self.issue = issue
896 self.patchset = patchset
897 self.hostname = hostname
898
899 @property
900 def valid(self):
901 return self.issue is not None
902
903
Edward Lemurf38bc172019-09-03 21:02:13 +0000904def ParseIssueNumberArgument(arg):
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000905 """Parses the issue argument and returns _ParsedIssueNumberArgument."""
906 fail_result = _ParsedIssueNumberArgument()
907
Edward Lemur678a6842019-10-03 22:25:05 +0000908 if isinstance(arg, int):
909 return _ParsedIssueNumberArgument(issue=arg)
910 if not isinstance(arg, basestring):
911 return fail_result
912
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000913 if arg.isdigit():
Edward Lemurf38bc172019-09-03 21:02:13 +0000914 return _ParsedIssueNumberArgument(issue=int(arg))
Aaron Gableaee6c852017-06-26 12:49:01 -0700915
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000916 url = gclient_utils.UpgradeToHttps(arg)
Alex Turner30ae6372022-01-04 02:32:52 +0000917 if not url.startswith('http'):
918 return fail_result
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000919 for gerrit_url, short_url in _KNOWN_GERRIT_TO_SHORT_URLS.items():
920 if url.startswith(short_url):
921 url = gerrit_url + url[len(short_url):]
922 break
923
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000924 try:
Edward Lemur79d4f992019-11-11 23:49:02 +0000925 parsed_url = urllib.parse.urlparse(url)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000926 except ValueError:
927 return fail_result
Andrii Shyshkalov28d840e2017-04-10 15:45:09 +0200928
Alex Turner30ae6372022-01-04 02:32:52 +0000929 # If "https://" was automatically added, fail if `arg` looks unlikely to be a
930 # URL.
931 if not arg.startswith('http') and '.' not in parsed_url.netloc:
932 return fail_result
933
Edward Lemur678a6842019-10-03 22:25:05 +0000934 # Gerrit's new UI is https://domain/c/project/+/<issue_number>[/[patchset]]
935 # But old GWT UI is https://domain/#/c/project/+/<issue_number>[/[patchset]]
936 # Short urls like https://domain/<issue_number> can be used, but don't allow
937 # specifying the patchset (you'd 404), but we allow that here.
938 if parsed_url.path == '/':
939 part = parsed_url.fragment
940 else:
941 part = parsed_url.path
942
943 match = re.match(
944 r'(/c(/.*/\+)?)?/(?P<issue>\d+)(/(?P<patchset>\d+)?/?)?$', part)
945 if not match:
946 return fail_result
947
948 issue = int(match.group('issue'))
949 patchset = match.group('patchset')
950 return _ParsedIssueNumberArgument(
951 issue=issue,
952 patchset=int(patchset) if patchset else None,
953 hostname=parsed_url.netloc)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000954
955
Andrii Shyshkalovb07575f2018-10-16 06:16:21 +0000956def _create_description_from_log(args):
957 """Pulls out the commit log to use as a base for the CL description."""
958 log_args = []
Bruce Dawson13acea32022-05-03 22:13:08 +0000959 if len(args) == 1 and args[0] == None:
960 # Handle the case where None is passed as the branch.
961 return ''
Andrii Shyshkalovb07575f2018-10-16 06:16:21 +0000962 if len(args) == 1 and not args[0].endswith('.'):
963 log_args = [args[0] + '..']
964 elif len(args) == 1 and args[0].endswith('...'):
965 log_args = [args[0][:-1]]
966 elif len(args) == 2:
967 log_args = [args[0] + '..' + args[1]]
968 else:
969 log_args = args[:] # Hope for the best!
Manh Nguyene3644862020-08-05 18:25:46 +0000970 return RunGit(['log', '--pretty=format:%B%n'] + log_args)
Andrii Shyshkalovb07575f2018-10-16 06:16:21 +0000971
972
Aaron Gablea45ee112016-11-22 15:14:38 -0800973class GerritChangeNotExists(Exception):
tandriic2405f52016-10-10 08:13:15 -0700974 def __init__(self, issue, url):
975 self.issue = issue
976 self.url = url
Aaron Gablea45ee112016-11-22 15:14:38 -0800977 super(GerritChangeNotExists, self).__init__()
tandriic2405f52016-10-10 08:13:15 -0700978
979 def __str__(self):
Aaron Gablea45ee112016-11-22 15:14:38 -0800980 return 'change %s at %s does not exist or you have no access to it' % (
tandriic2405f52016-10-10 08:13:15 -0700981 self.issue, self.url)
982
983
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +0100984_CommentSummary = collections.namedtuple(
Quinten Yearsley0e617c02019-02-20 00:37:03 +0000985 '_CommentSummary', ['date', 'message', 'sender', 'autogenerated',
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +0100986 # TODO(tandrii): these two aren't known in Gerrit.
987 'approval', 'disapproval'])
988
989
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000990class Changelist(object):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +0000991 """Changelist works with one changelist in local branch.
992
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +0000993 Notes:
994 * Not safe for concurrent multi-{thread,process} use.
995 * Caches values from current branch. Therefore, re-use after branch change
tandrii5d48c322016-08-18 16:19:37 -0700996 with great care.
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +0000997 """
998
Sigurd Schneider9abde8c2020-11-17 08:44:52 +0000999 def __init__(self,
1000 branchref=None,
1001 issue=None,
1002 codereview_host=None,
1003 commit_date=None):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001004 """Create a new ChangeList instance.
1005
Edward Lemurf38bc172019-09-03 21:02:13 +00001006 **kwargs will be passed directly to Gerrit implementation.
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001007 """
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001008 # Poke settings so we get the "configure your server" message if necessary.
maruel@chromium.org379d07a2011-11-30 14:58:10 +00001009 global settings
1010 if not settings:
1011 # Happens when git_cl.py is used as a utility library.
1012 settings = Settings()
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001013
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001014 self.branchref = branchref
1015 if self.branchref:
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00001016 assert branchref.startswith('refs/heads/')
Edward Lemur85153282020-02-14 22:06:29 +00001017 self.branch = scm.GIT.ShortBranchName(self.branchref)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001018 else:
1019 self.branch = None
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00001020 self.commit_date = commit_date
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001021 self.upstream_branch = None
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001022 self.lookedup_issue = False
1023 self.issue = issue or None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001024 self.description = None
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001025 self.lookedup_patchset = False
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001026 self.patchset = None
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001027 self.cc = None
Daniel Cheng7227d212017-11-17 08:12:37 -08001028 self.more_cc = []
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00001029 self._remote = None
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001030 self._cached_remote_url = (False, None) # (is_cached, value)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00001031
Edward Lemur125d60a2019-09-13 18:25:41 +00001032 # Lazily cached values.
1033 self._gerrit_host = None # e.g. chromium-review.googlesource.com
1034 self._gerrit_server = None # e.g. https://chromium-review.googlesource.com
Edward Lesmese1576912021-02-16 21:53:34 +00001035 self._owners_client = None
Edward Lemur125d60a2019-09-13 18:25:41 +00001036 # Map from change number (issue) to its detail cache.
1037 self._detail_cache = {}
1038
1039 if codereview_host is not None:
1040 assert not codereview_host.startswith('https://'), codereview_host
1041 self._gerrit_host = codereview_host
1042 self._gerrit_server = 'https://%s' % codereview_host
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001043
Edward Lesmese1576912021-02-16 21:53:34 +00001044 @property
1045 def owners_client(self):
1046 if self._owners_client is None:
1047 remote, remote_branch = self.GetRemoteBranch()
1048 branch = GetTargetRef(remote, remote_branch, None)
1049 self._owners_client = owners_client.GetCodeOwnersClient(
Edward Lesmese1576912021-02-16 21:53:34 +00001050 host=self.GetGerritHost(),
1051 project=self.GetGerritProject(),
1052 branch=branch)
1053 return self._owners_client
1054
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001055 def GetCCList(self):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001056 """Returns the users cc'd on this CL.
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001057
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001058 The return value is a string suitable for passing to git cl with the --cc
1059 flag.
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001060 """
1061 if self.cc is None:
tyoshino@chromium.org99918ab2013-09-30 06:17:28 +00001062 base_cc = settings.GetDefaultCCList()
Daniel Cheng7227d212017-11-17 08:12:37 -08001063 more_cc = ','.join(self.more_cc)
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001064 self.cc = ','.join(filter(None, (base_cc, more_cc))) or ''
1065 return self.cc
1066
Daniel Cheng7227d212017-11-17 08:12:37 -08001067 def ExtendCC(self, more_cc):
1068 """Extends the list of users to cc on this CL based on the changed files."""
1069 self.more_cc.extend(more_cc)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001070
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00001071 def GetCommitDate(self):
1072 """Returns the commit date as provided in the constructor"""
1073 return self.commit_date
1074
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001075 def GetBranch(self):
Josip Sokcevicc39ab992020-09-24 20:09:15 +00001076 """Returns the short branch name, e.g. 'main'."""
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001077 if not self.branch:
Edward Lemur85153282020-02-14 22:06:29 +00001078 branchref = scm.GIT.GetBranchRef(settings.GetRoot())
szager@chromium.orgd62c61f2014-10-20 22:33:21 +00001079 if not branchref:
1080 return None
1081 self.branchref = branchref
Edward Lemur85153282020-02-14 22:06:29 +00001082 self.branch = scm.GIT.ShortBranchName(self.branchref)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001083 return self.branch
1084
1085 def GetBranchRef(self):
Josip Sokcevicc39ab992020-09-24 20:09:15 +00001086 """Returns the full branch name, e.g. 'refs/heads/main'."""
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001087 self.GetBranch() # Poke the lazy loader.
1088 return self.branchref
1089
Edward Lemur85153282020-02-14 22:06:29 +00001090 def _GitGetBranchConfigValue(self, key, default=None):
1091 return scm.GIT.GetBranchConfig(
1092 settings.GetRoot(), self.GetBranch(), key, default)
tandrii5d48c322016-08-18 16:19:37 -07001093
Edward Lemur85153282020-02-14 22:06:29 +00001094 def _GitSetBranchConfigValue(self, key, value):
1095 action = 'set %s to %r' % (key, value)
1096 if not value:
1097 action = 'unset %s' % key
1098 assert self.GetBranch(), 'a branch is needed to ' + action
1099 return scm.GIT.SetBranchConfig(
1100 settings.GetRoot(), self.GetBranch(), key, value)
tandrii5d48c322016-08-18 16:19:37 -07001101
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001102 @staticmethod
1103 def FetchUpstreamTuple(branch):
pgervais@chromium.orgd6617f32013-11-19 00:34:54 +00001104 """Returns a tuple containing remote and remote ref,
Josip Sokcevicc39ab992020-09-24 20:09:15 +00001105 e.g. 'origin', 'refs/heads/main'
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001106 """
Edward Lemur15a9b8c2020-02-13 00:52:30 +00001107 remote, upstream_branch = scm.GIT.FetchUpstreamTuple(
1108 settings.GetRoot(), branch)
1109 if not remote or not upstream_branch:
1110 DieWithError(
1111 'Unable to determine default branch to diff against.\n'
Josip Sokcevicb038f722021-01-06 18:28:11 +00001112 'Verify this branch is set up to track another \n'
1113 '(via the --track argument to "git checkout -b ..."). \n'
1114 'or pass complete "git diff"-style arguments if supported, like\n'
1115 ' git cl upload origin/main\n')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001116
1117 return remote, upstream_branch
1118
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00001119 def GetCommonAncestorWithUpstream(self):
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +00001120 upstream_branch = self.GetUpstreamBranch()
Edward Lesmes50da7702020-03-30 19:23:43 +00001121 if not scm.GIT.IsValidRevision(settings.GetRoot(), upstream_branch):
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +00001122 DieWithError('The upstream for the current branch (%s) does not exist '
1123 'anymore.\nPlease fix it and try again.' % self.GetBranch())
iannucci@chromium.org9e849272014-04-04 00:31:55 +00001124 return git_common.get_or_create_merge_base(self.GetBranch(),
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +00001125 upstream_branch)
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00001126
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001127 def GetUpstreamBranch(self):
1128 if self.upstream_branch is None:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001129 remote, upstream_branch = self.FetchUpstreamTuple(self.GetBranch())
Raul Tambrefe1dbe12019-05-02 04:43:57 +00001130 if remote != '.':
mmoss@chromium.orge7585452014-08-24 01:41:11 +00001131 upstream_branch = upstream_branch.replace('refs/heads/',
1132 'refs/remotes/%s/' % remote)
1133 upstream_branch = upstream_branch.replace('refs/branch-heads/',
1134 'refs/remotes/branch-heads/')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001135 self.upstream_branch = upstream_branch
1136 return self.upstream_branch
1137
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001138 def GetRemoteBranch(self):
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001139 if not self._remote:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001140 remote, branch = None, self.GetBranch()
1141 seen_branches = set()
1142 while branch not in seen_branches:
1143 seen_branches.add(branch)
1144 remote, branch = self.FetchUpstreamTuple(branch)
Edward Lemur85153282020-02-14 22:06:29 +00001145 branch = scm.GIT.ShortBranchName(branch)
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001146 if remote != '.' or branch.startswith('refs/remotes'):
1147 break
1148 else:
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001149 remotes = RunGit(['remote'], error_ok=True).split()
1150 if len(remotes) == 1:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001151 remote, = remotes
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001152 elif 'origin' in remotes:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001153 remote = 'origin'
Gavin Make6a62332020-12-04 21:57:10 +00001154 logging.warning('Could not determine which remote this change is '
1155 'associated with, so defaulting to "%s".' %
1156 self._remote)
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001157 else:
Gavin Make6a62332020-12-04 21:57:10 +00001158 logging.warning('Could not determine which remote this change is '
1159 'associated with.')
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001160 branch = 'HEAD'
1161 if branch.startswith('refs/remotes'):
1162 self._remote = (remote, branch)
mmoss@chromium.orge7585452014-08-24 01:41:11 +00001163 elif branch.startswith('refs/branch-heads/'):
1164 self._remote = (remote, branch.replace('refs/', 'refs/remotes/'))
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001165 else:
1166 self._remote = (remote, 'refs/remotes/%s/%s' % (remote, branch))
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001167 return self._remote
1168
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001169 def GetRemoteUrl(self):
1170 """Return the configured remote URL, e.g. 'git://example.org/foo.git/'.
1171
1172 Returns None if there is no remote.
1173 """
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001174 is_cached, value = self._cached_remote_url
1175 if is_cached:
1176 return value
1177
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001178 remote, _ = self.GetRemoteBranch()
Edward Lemur26964072020-02-19 19:18:51 +00001179 url = scm.GIT.GetConfig(settings.GetRoot(), 'remote.%s.url' % remote, '')
dyen@chromium.org2a13d4f2014-06-13 00:06:37 +00001180
Edward Lemur298f2cf2019-02-22 21:40:39 +00001181 # Check if the remote url can be parsed as an URL.
Edward Lemur79d4f992019-11-11 23:49:02 +00001182 host = urllib.parse.urlparse(url).netloc
Edward Lemur298f2cf2019-02-22 21:40:39 +00001183 if host:
1184 self._cached_remote_url = (True, url)
1185 return url
1186
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001187 # If it cannot be parsed as an url, assume it is a local directory,
1188 # probably a git cache.
Edward Lemur298f2cf2019-02-22 21:40:39 +00001189 logging.warning('"%s" doesn\'t appear to point to a git host. '
1190 'Interpreting it as a local directory.', url)
1191 if not os.path.isdir(url):
1192 logging.error(
Josip906bfde2020-01-31 22:38:49 +00001193 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
1194 'but it doesn\'t exist.',
1195 {'remote': remote, 'branch': self.GetBranch(), 'url': url})
Edward Lemur298f2cf2019-02-22 21:40:39 +00001196 return None
1197
1198 cache_path = url
Edward Lemur26964072020-02-19 19:18:51 +00001199 url = scm.GIT.GetConfig(url, 'remote.%s.url' % remote, '')
Edward Lemur298f2cf2019-02-22 21:40:39 +00001200
Edward Lemur79d4f992019-11-11 23:49:02 +00001201 host = urllib.parse.urlparse(url).netloc
Edward Lemur298f2cf2019-02-22 21:40:39 +00001202 if not host:
1203 logging.error(
1204 'Remote "%(remote)s" for branch "%(branch)s" points to '
1205 '"%(cache_path)s", but it is misconfigured.\n'
1206 '"%(cache_path)s" must be a git repo and must have a remote named '
1207 '"%(remote)s" pointing to the git host.', {
1208 'remote': remote,
1209 'cache_path': cache_path,
1210 'branch': self.GetBranch()})
1211 return None
1212
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001213 self._cached_remote_url = (True, url)
dyen@chromium.org2a13d4f2014-06-13 00:06:37 +00001214 return url
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001215
tandrii@chromium.org87985d22016-03-24 17:33:33 +00001216 def GetIssue(self):
maruel@chromium.org52424302012-08-29 15:14:30 +00001217 """Returns the issue number as a int or None if not set."""
tandrii@chromium.org87985d22016-03-24 17:33:33 +00001218 if self.issue is None and not self.lookedup_issue:
Bruce Dawson13acea32022-05-03 22:13:08 +00001219 if self.GetBranch():
1220 self.issue = self._GitGetBranchConfigValue(ISSUE_CONFIG_KEY)
Edward Lemur85153282020-02-14 22:06:29 +00001221 if self.issue is not None:
1222 self.issue = int(self.issue)
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001223 self.lookedup_issue = True
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001224 return self.issue
1225
Andrii Shyshkalov1ee78cd2020-03-12 01:31:53 +00001226 def GetIssueURL(self, short=False):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001227 """Get the URL for a particular issue."""
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001228 issue = self.GetIssue()
1229 if not issue:
dbeam@chromium.org015fd3d2013-06-18 19:02:50 +00001230 return None
Andrii Shyshkalov1ee78cd2020-03-12 01:31:53 +00001231 server = self.GetCodereviewServer()
1232 if short:
1233 server = _KNOWN_GERRIT_TO_SHORT_URLS.get(server, server)
1234 return '%s/%s' % (server, issue)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001235
Dirk Pranke6f0df682021-06-25 00:42:33 +00001236 def GetUsePython3(self):
Josip Sokcevic340edc32021-07-08 17:01:46 +00001237 return settings.GetUsePython3()
Dirk Pranke6f0df682021-06-25 00:42:33 +00001238
Edward Lemur6c6827c2020-02-06 21:15:18 +00001239 def FetchDescription(self, pretty=False):
1240 assert self.GetIssue(), 'issue is required to query Gerrit'
1241
Edward Lemur9aa1a962020-02-25 00:58:38 +00001242 if self.description is None:
Edward Lemur6c6827c2020-02-06 21:15:18 +00001243 data = self._GetChangeDetail(['CURRENT_REVISION', 'CURRENT_COMMIT'])
1244 current_rev = data['current_revision']
1245 self.description = data['revisions'][current_rev]['commit']['message']
Edward Lemur6c6827c2020-02-06 21:15:18 +00001246
1247 if not pretty:
1248 return self.description
1249
1250 # Set width to 72 columns + 2 space indent.
1251 wrapper = textwrap.TextWrapper(width=74, replace_whitespace=True)
1252 wrapper.initial_indent = wrapper.subsequent_indent = ' '
1253 lines = self.description.splitlines()
1254 return '\n'.join([wrapper.fill(line) for line in lines])
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001255
1256 def GetPatchset(self):
maruel@chromium.org52424302012-08-29 15:14:30 +00001257 """Returns the patchset number as a int or None if not set."""
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001258 if self.patchset is None and not self.lookedup_patchset:
Bruce Dawson13acea32022-05-03 22:13:08 +00001259 if self.GetBranch():
1260 self.patchset = self._GitGetBranchConfigValue(PATCHSET_CONFIG_KEY)
Edward Lemur85153282020-02-14 22:06:29 +00001261 if self.patchset is not None:
1262 self.patchset = int(self.patchset)
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001263 self.lookedup_patchset = True
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001264 return self.patchset
1265
Edward Lemur9aa1a962020-02-25 00:58:38 +00001266 def GetAuthor(self):
1267 return scm.GIT.GetConfig(settings.GetRoot(), 'user.email')
1268
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001269 def SetPatchset(self, patchset):
tandrii5d48c322016-08-18 16:19:37 -07001270 """Set this branch's patchset. If patchset=0, clears the patchset."""
1271 assert self.GetBranch()
1272 if not patchset:
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001273 self.patchset = None
tandrii5d48c322016-08-18 16:19:37 -07001274 else:
1275 self.patchset = int(patchset)
Edward Lesmes50da7702020-03-30 19:23:43 +00001276 self._GitSetBranchConfigValue(PATCHSET_CONFIG_KEY, str(self.patchset))
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001277
tandrii@chromium.orga342c922016-03-16 07:08:25 +00001278 def SetIssue(self, issue=None):
tandrii5d48c322016-08-18 16:19:37 -07001279 """Set this branch's issue. If issue isn't given, clears the issue."""
1280 assert self.GetBranch()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001281 if issue:
tandrii5d48c322016-08-18 16:19:37 -07001282 issue = int(issue)
Edward Lesmes50da7702020-03-30 19:23:43 +00001283 self._GitSetBranchConfigValue(ISSUE_CONFIG_KEY, str(issue))
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001284 self.issue = issue
Edward Lemur125d60a2019-09-13 18:25:41 +00001285 codereview_server = self.GetCodereviewServer()
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001286 if codereview_server:
tandrii5d48c322016-08-18 16:19:37 -07001287 self._GitSetBranchConfigValue(
Edward Lesmes50da7702020-03-30 19:23:43 +00001288 CODEREVIEW_SERVER_CONFIG_KEY, codereview_server)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001289 else:
tandrii5d48c322016-08-18 16:19:37 -07001290 # Reset all of these just to be clean.
1291 reset_suffixes = [
1292 'last-upload-hash',
Edward Lesmes50da7702020-03-30 19:23:43 +00001293 ISSUE_CONFIG_KEY,
1294 PATCHSET_CONFIG_KEY,
1295 CODEREVIEW_SERVER_CONFIG_KEY,
1296 'gerritsquashhash',
1297 ]
tandrii5d48c322016-08-18 16:19:37 -07001298 for prop in reset_suffixes:
Edward Lemur85153282020-02-14 22:06:29 +00001299 try:
1300 self._GitSetBranchConfigValue(prop, None)
1301 except subprocess2.CalledProcessError:
1302 pass
Aaron Gableca01e2c2017-07-19 11:16:02 -07001303 msg = RunGit(['log', '-1', '--format=%B']).strip()
1304 if msg and git_footers.get_footer_change_id(msg):
1305 print('WARNING: The change patched into this branch has a Change-Id. '
1306 'Removing it.')
1307 RunGit(['commit', '--amend', '-m',
1308 git_footers.remove_footer(msg, 'Change-Id')])
Edward Lemurf38bc172019-09-03 21:02:13 +00001309 self.lookedup_issue = True
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001310 self.issue = None
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00001311 self.patchset = None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001312
Edward Lemur2c62b332020-03-12 22:12:33 +00001313 def GetAffectedFiles(self, upstream):
maruel@chromium.org2b38e9c2011-10-19 00:04:35 +00001314 try:
Edward Lemur2c62b332020-03-12 22:12:33 +00001315 return [f for _, f in scm.GIT.CaptureStatus(settings.GetRoot(), upstream)]
maruel@chromium.org2b38e9c2011-10-19 00:04:35 +00001316 except subprocess2.CalledProcessError:
1317 DieWithError(
pgervais@chromium.orgd6617f32013-11-19 00:34:54 +00001318 ('\nFailed to diff against upstream branch %s\n\n'
maruel@chromium.org2b38e9c2011-10-19 00:04:35 +00001319 'This branch probably doesn\'t exist anymore. To reset the\n'
1320 'tracking branch, please run\n'
Josip Sokcevicc39ab992020-09-24 20:09:15 +00001321 ' git branch --set-upstream-to origin/main %s\n'
1322 'or replace origin/main with the relevant branch') %
Edward Lemur2c62b332020-03-12 22:12:33 +00001323 (upstream, self.GetBranch()))
bauerb@chromium.org6fb99c62011-04-18 15:57:28 +00001324
dsansomee2d6fd92016-09-08 00:10:47 -07001325 def UpdateDescription(self, description, force=False):
Edward Lemur6c6827c2020-02-06 21:15:18 +00001326 assert self.GetIssue(), 'issue is required to update description'
1327
1328 if gerrit_util.HasPendingChangeEdit(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001329 self.GetGerritHost(), self._GerritChangeIdentifier()):
Edward Lemur6c6827c2020-02-06 21:15:18 +00001330 if not force:
1331 confirm_or_exit(
1332 'The description cannot be modified while the issue has a pending '
1333 'unpublished edit. Either publish the edit in the Gerrit web UI '
1334 'or delete it.\n\n', action='delete the unpublished edit')
1335
1336 gerrit_util.DeletePendingChangeEdit(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001337 self.GetGerritHost(), self._GerritChangeIdentifier())
Edward Lemur6c6827c2020-02-06 21:15:18 +00001338 gerrit_util.SetCommitMessage(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001339 self.GetGerritHost(), self._GerritChangeIdentifier(),
Edward Lemur6c6827c2020-02-06 21:15:18 +00001340 description, notify='NONE')
1341
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001342 self.description = description
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001343
Edward Lemur75526302020-02-27 22:31:05 +00001344 def _GetCommonPresubmitArgs(self, verbose, upstream):
Edward Lemur227d5102020-02-25 23:45:35 +00001345 args = [
Edward Lemur227d5102020-02-25 23:45:35 +00001346 '--root', settings.GetRoot(),
1347 '--upstream', upstream,
1348 ]
1349
1350 args.extend(['--verbose'] * verbose)
1351
Edward Lesmeseb1bd622021-03-01 19:54:07 +00001352 remote, remote_branch = self.GetRemoteBranch()
1353 target_ref = GetTargetRef(remote, remote_branch, None)
Aleksey Khoroshilov35ef5ad2022-06-03 18:29:25 +00001354 if settings.GetIsGerrit():
1355 args.extend(['--gerrit_url', self.GetCodereviewServer()])
1356 args.extend(['--gerrit_project', self.GetGerritProject()])
1357 args.extend(['--gerrit_branch', target_ref])
Edward Lesmeseb1bd622021-03-01 19:54:07 +00001358
Edward Lemur99df04e2020-03-05 19:39:43 +00001359 author = self.GetAuthor()
Edward Lemur227d5102020-02-25 23:45:35 +00001360 issue = self.GetIssue()
1361 patchset = self.GetPatchset()
Edward Lemur99df04e2020-03-05 19:39:43 +00001362 if author:
1363 args.extend(['--author', author])
Edward Lemur227d5102020-02-25 23:45:35 +00001364 if issue:
1365 args.extend(['--issue', str(issue)])
1366 if patchset:
1367 args.extend(['--patchset', str(patchset)])
Edward Lemur227d5102020-02-25 23:45:35 +00001368
Edward Lemur75526302020-02-27 22:31:05 +00001369 return args
1370
Josip Sokcevic017544d2022-03-31 23:47:53 +00001371 def RunHook(self,
1372 committing,
1373 may_prompt,
1374 verbose,
1375 parallel,
1376 upstream,
1377 description,
1378 all_files,
1379 files=None,
1380 resultdb=False,
1381 realm=None):
Edward Lemur75526302020-02-27 22:31:05 +00001382 """Calls sys.exit() if the hook fails; returns a HookResults otherwise."""
1383 args = self._GetCommonPresubmitArgs(verbose, upstream)
1384 args.append('--commit' if committing else '--upload')
Edward Lemur227d5102020-02-25 23:45:35 +00001385 if may_prompt:
1386 args.append('--may_prompt')
1387 if parallel:
1388 args.append('--parallel')
1389 if all_files:
1390 args.append('--all_files')
Josip Sokcevic017544d2022-03-31 23:47:53 +00001391 if files:
1392 args.extend(files.split(';'))
1393 args.append('--source_controlled_only')
Bruce Dawson09c0c072022-05-26 20:28:58 +00001394 if files or all_files:
1395 args.append('--no_diffs')
Edward Lemur227d5102020-02-25 23:45:35 +00001396
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001397 if resultdb and not realm:
1398 # TODO (crbug.com/1113463): store realm somewhere and look it up so
1399 # it is not required to pass the realm flag
1400 print('Note: ResultDB reporting will NOT be performed because --realm'
1401 ' was not specified. To enable ResultDB, please run the command'
1402 ' again with the --realm argument to specify the LUCI realm.')
1403
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001404 py3_results = self._RunPresubmit(args, resultdb, realm, description,
1405 use_python3=True)
Josip Sokcevic632bbc02022-05-19 05:32:50 +00001406 if py3_results.get('skipped_presubmits', 1) == 0:
1407 print('No more presubmits to run - skipping Python 2 presubmits.')
1408 return py3_results
1409
1410 py2_results = self._RunPresubmit(args, resultdb, realm, description,
1411 use_python3=False)
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001412 return self._MergePresubmitResults(py2_results, py3_results)
1413
1414 def _RunPresubmit(self, args, resultdb, realm, description, use_python3):
1415 args = args[:]
1416 vpython = 'vpython3' if use_python3 else 'vpython'
1417
Edward Lemur227d5102020-02-25 23:45:35 +00001418 with gclient_utils.temporary_file() as description_file:
1419 with gclient_utils.temporary_file() as json_output:
Edward Lemur1a83da12020-03-04 21:18:36 +00001420 gclient_utils.FileWrite(description_file, description)
Edward Lemur227d5102020-02-25 23:45:35 +00001421 args.extend(['--json_output', json_output])
1422 args.extend(['--description_file', description_file])
Dirk Pranke6f0df682021-06-25 00:42:33 +00001423 if self.GetUsePython3():
1424 args.append('--use-python3')
Edward Lemur227d5102020-02-25 23:45:35 +00001425 start = time_time()
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001426 cmd = [vpython, PRESUBMIT_SUPPORT] + args
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001427 if resultdb and realm:
1428 cmd = ['rdb', 'stream', '-new', '-realm', realm, '--'] + cmd
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00001429
1430 p = subprocess2.Popen(cmd)
Edward Lemur227d5102020-02-25 23:45:35 +00001431 exit_code = p.wait()
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00001432
Edward Lemur227d5102020-02-25 23:45:35 +00001433 metrics.collector.add_repeated('sub_commands', {
1434 'command': 'presubmit',
1435 'execution_time': time_time() - start,
1436 'exit_code': exit_code,
1437 })
1438
1439 if exit_code:
1440 sys.exit(exit_code)
1441
1442 json_results = gclient_utils.FileRead(json_output)
1443 return json.loads(json_results)
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001444
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001445 def _MergePresubmitResults(self, py2_results, py3_results):
1446 return {
1447 'more_cc': sorted(set(py2_results.get('more_cc', []) +
1448 py3_results.get('more_cc', []))),
1449 'errors': (
1450 py2_results.get('errors', []) + py3_results.get('errors', [])),
1451 'notifications': (
1452 py2_results.get('notifications', []) +
1453 py3_results.get('notifications', [])),
1454 'warnings': (
1455 py2_results.get('warnings', []) + py3_results.get('warnings', []))
1456 }
1457
Edward Lemur75526302020-02-27 22:31:05 +00001458 def RunPostUploadHook(self, verbose, upstream, description):
1459 args = self._GetCommonPresubmitArgs(verbose, upstream)
1460 args.append('--post_upload')
1461
1462 with gclient_utils.temporary_file() as description_file:
Edward Lemur1a83da12020-03-04 21:18:36 +00001463 gclient_utils.FileWrite(description_file, description)
Edward Lemur75526302020-02-27 22:31:05 +00001464 args.extend(['--description_file', description_file])
Josip Sokcevice293d3d2022-02-16 22:52:15 +00001465 p_py2 = subprocess2.Popen(['vpython', PRESUBMIT_SUPPORT] + args)
1466 p_py3 = subprocess2.Popen(['vpython3', PRESUBMIT_SUPPORT] + args +
1467 ['--use-python3'])
1468 p_py2.wait()
1469 p_py3.wait()
Edward Lemur75526302020-02-27 22:31:05 +00001470
Edward Lemur5a644f82020-03-18 16:44:57 +00001471 def _GetDescriptionForUpload(self, options, git_diff_args, files):
1472 # Get description message for upload.
1473 if self.GetIssue():
1474 description = self.FetchDescription()
1475 elif options.message:
1476 description = options.message
1477 else:
1478 description = _create_description_from_log(git_diff_args)
1479 if options.title and options.squash:
Edward Lesmes0dd54822020-03-26 18:24:25 +00001480 description = options.title + '\n\n' + description
Edward Lemur5a644f82020-03-18 16:44:57 +00001481
Edward Lemur5a644f82020-03-18 16:44:57 +00001482 bug = options.bug
1483 fixed = options.fixed
Josip Sokcevic340edc32021-07-08 17:01:46 +00001484 if not self.GetIssue():
1485 # Extract bug number from branch name, but only if issue is being created.
1486 # It must start with bug or fix, followed by _ or - and number.
1487 # Optionally, it may contain _ or - after number with arbitrary text.
1488 # Examples:
1489 # bug-123
1490 # bug_123
1491 # fix-123
1492 # fix-123-some-description
1493 match = re.match(
1494 r'^(?P<type>bug|fix(?:e[sd])?)[_-]?(?P<bugnum>\d+)([-_]|$)',
1495 self.GetBranch())
1496 if not bug and not fixed and match:
1497 if match.group('type') == 'bug':
1498 bug = match.group('bugnum')
1499 else:
1500 fixed = match.group('bugnum')
Edward Lemur5a644f82020-03-18 16:44:57 +00001501
1502 change_description = ChangeDescription(description, bug, fixed)
1503
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001504 # Fill gaps in OWNERS coverage to tbrs/reviewers if requested.
1505 if options.add_owners_to:
1506 assert options.add_owners_to in ('TBR', 'R'), options.add_owners_to
Edward Lesmese1576912021-02-16 21:53:34 +00001507 status = self.owners_client.GetFilesApprovalStatus(
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001508 files, [], options.tbrs + options.reviewers)
1509 missing_files = [
1510 f for f in files
Edward Lesmese1576912021-02-16 21:53:34 +00001511 if status[f] == self._owners_client.INSUFFICIENT_REVIEWERS
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001512 ]
Edward Lesmese1576912021-02-16 21:53:34 +00001513 owners = self.owners_client.SuggestOwners(
1514 missing_files, exclude=[self.GetAuthor()])
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001515 if options.add_owners_to == 'TBR':
1516 assert isinstance(options.tbrs, list), options.tbrs
1517 options.tbrs.extend(owners)
1518 else:
1519 assert isinstance(options.reviewers, list), options.reviewers
1520 options.reviewers.extend(owners)
1521
Edward Lemur5a644f82020-03-18 16:44:57 +00001522 # Set the reviewer list now so that presubmit checks can access it.
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001523 if options.reviewers or options.tbrs:
1524 change_description.update_reviewers(options.reviewers, options.tbrs)
Edward Lemur5a644f82020-03-18 16:44:57 +00001525
1526 return change_description
1527
1528 def _GetTitleForUpload(self, options):
manukh566e9d02022-06-30 19:49:53 +00001529 # When not squashing or options.title is provided, just return
1530 # options.title.
1531 if not options.squash or options.title:
Edward Lemur5a644f82020-03-18 16:44:57 +00001532 return options.title
1533
1534 # On first upload, patchset title is always this string, while options.title
1535 # gets converted to first line of message.
1536 if not self.GetIssue():
1537 return 'Initial upload'
1538
1539 # When uploading subsequent patchsets, options.message is taken as the title
1540 # if options.title is not provided.
Edward Lemur5a644f82020-03-18 16:44:57 +00001541 if options.message:
1542 return options.message.strip()
1543
1544 # Use the subject of the last commit as title by default.
Edward Lesmes50da7702020-03-30 19:23:43 +00001545 title = RunGit(['show', '-s', '--format=%s', 'HEAD']).strip()
Mario Bianuccicebfb4e2020-07-22 23:08:16 +00001546 if options.force or options.skip_title:
Edward Lemur5a644f82020-03-18 16:44:57 +00001547 return title
Edward Lesmesae3586b2020-03-23 21:21:14 +00001548 user_title = gclient_utils.AskForData('Title for patchset [%s]: ' % title)
mlcui3da91712021-05-05 10:00:30 +00001549
1550 # Use the default title if the user confirms the default with a 'y'.
1551 if user_title.lower() == 'y':
1552 return title
Edward Lesmesae3586b2020-03-23 21:21:14 +00001553 return user_title or title
Edward Lemur5a644f82020-03-18 16:44:57 +00001554
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001555 def CMDUpload(self, options, git_diff_args, orig_args):
1556 """Uploads a change to codereview."""
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001557 custom_cl_base = None
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001558 if git_diff_args:
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001559 custom_cl_base = base_branch = git_diff_args[0]
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001560 else:
1561 if self.GetBranch() is None:
1562 DieWithError('Can\'t upload from detached HEAD state. Get on a branch!')
1563
1564 # Default to diffing against common ancestor of upstream branch
1565 base_branch = self.GetCommonAncestorWithUpstream()
1566 git_diff_args = [base_branch, 'HEAD']
1567
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001568 # Fast best-effort checks to abort before running potentially expensive
1569 # hooks if uploading is likely to fail anyway. Passing these checks does
1570 # not guarantee that uploading will not fail.
Edward Lemur125d60a2019-09-13 18:25:41 +00001571 self.EnsureAuthenticated(force=options.force)
1572 self.EnsureCanUploadPatchset(force=options.force)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001573
1574 # Apply watchlists on upload.
Edward Lemur2c62b332020-03-12 22:12:33 +00001575 watchlist = watchlists.Watchlists(settings.GetRoot())
1576 files = self.GetAffectedFiles(base_branch)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001577 if not options.bypass_watchlists:
Daniel Cheng7227d212017-11-17 08:12:37 -08001578 self.ExtendCC(watchlist.GetWatchersForPaths(files))
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001579
Edward Lemur5a644f82020-03-18 16:44:57 +00001580 change_desc = self._GetDescriptionForUpload(options, git_diff_args, files)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001581 if not options.bypass_hooks:
Edward Lemur2c62b332020-03-12 22:12:33 +00001582 hook_results = self.RunHook(
1583 committing=False,
1584 may_prompt=not options.force,
1585 verbose=options.verbose,
1586 parallel=options.parallel,
1587 upstream=base_branch,
Edward Lemur5a644f82020-03-18 16:44:57 +00001588 description=change_desc.description,
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00001589 all_files=False,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001590 resultdb=options.resultdb,
1591 realm=options.realm)
Edward Lemur227d5102020-02-25 23:45:35 +00001592 self.ExtendCC(hook_results['more_cc'])
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001593
Aaron Gable13101a62018-02-09 13:20:41 -08001594 print_stats(git_diff_args)
Edward Lemura12175c2020-03-09 16:58:26 +00001595 ret = self.CMDUploadChange(
Edward Lemur5a644f82020-03-18 16:44:57 +00001596 options, git_diff_args, custom_cl_base, change_desc)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001597 if not ret:
Edward Lemur85153282020-02-14 22:06:29 +00001598 self._GitSetBranchConfigValue(
Edward Lesmes50da7702020-03-30 19:23:43 +00001599 'last-upload-hash', scm.GIT.ResolveCommit(settings.GetRoot(), 'HEAD'))
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001600 # Run post upload hooks, if specified.
1601 if settings.GetRunPostUploadHook():
Edward Lemur5a644f82020-03-18 16:44:57 +00001602 self.RunPostUploadHook(
1603 options.verbose, base_branch, change_desc.description)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001604
1605 # Upload all dependencies if specified.
1606 if options.dependencies:
vapiera7fbd5a2016-06-16 09:17:49 -07001607 print()
1608 print('--dependencies has been specified.')
1609 print('All dependent local branches will be re-uploaded.')
1610 print()
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001611 # Remove the dependencies flag from args so that we do not end up in a
1612 # loop.
1613 orig_args.remove('--dependencies')
Jose Lopes3863fc52020-04-07 17:00:25 +00001614 ret = upload_branch_deps(self, orig_args, options.force)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001615 return ret
1616
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001617 def SetCQState(self, new_state):
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07001618 """Updates the CQ state for the latest patchset.
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001619
Greg Gutermanbe5fccd2021-06-14 17:58:20 +00001620 Issue must have been already uploaded and known. Optionally allows for
1621 updating Quick-Run (QR) state.
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001622 """
1623 assert new_state in _CQState.ALL_STATES
1624 assert self.GetIssue()
qyearsley1fdfcb62016-10-24 13:22:03 -07001625 try:
Edward Lemur125d60a2019-09-13 18:25:41 +00001626 vote_map = {
1627 _CQState.NONE: 0,
Greg Gutermanbe5fccd2021-06-14 17:58:20 +00001628 _CQState.QUICK_RUN: 1,
Edward Lemur125d60a2019-09-13 18:25:41 +00001629 _CQState.DRY_RUN: 1,
1630 _CQState.COMMIT: 2,
1631 }
Greg Gutermanbe5fccd2021-06-14 17:58:20 +00001632 if new_state == _CQState.QUICK_RUN:
1633 labels = {
1634 'Commit-Queue': vote_map[_CQState.DRY_RUN],
1635 'Quick-Run': vote_map[_CQState.QUICK_RUN],
1636 }
1637 else:
1638 labels = {'Commit-Queue': vote_map[new_state]}
Edward Lemur125d60a2019-09-13 18:25:41 +00001639 notify = False if new_state == _CQState.DRY_RUN else None
1640 gerrit_util.SetReview(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001641 self.GetGerritHost(), self._GerritChangeIdentifier(),
Edward Lemur125d60a2019-09-13 18:25:41 +00001642 labels=labels, notify=notify)
qyearsley1fdfcb62016-10-24 13:22:03 -07001643 return 0
1644 except KeyboardInterrupt:
1645 raise
1646 except:
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07001647 print('WARNING: Failed to %s.\n'
qyearsley1fdfcb62016-10-24 13:22:03 -07001648 'Either:\n'
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07001649 ' * Your project has no CQ,\n'
1650 ' * You don\'t have permission to change the CQ state,\n'
1651 ' * There\'s a bug in this code (see stack trace below).\n'
1652 'Consider specifying which bots to trigger manually or asking your '
1653 'project owners for permissions or contacting Chrome Infra at:\n'
1654 'https://www.chromium.org/infra\n\n' %
1655 ('cancel CQ' if new_state == _CQState.NONE else 'trigger CQ'))
qyearsley1fdfcb62016-10-24 13:22:03 -07001656 # Still raise exception so that stack trace is printed.
1657 raise
1658
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001659 def GetGerritHost(self):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001660 # Lazy load of configs.
1661 self.GetCodereviewServer()
tandriie32e3ea2016-06-22 02:52:48 -07001662 if self._gerrit_host and '.' not in self._gerrit_host:
1663 # Abbreviated domain like "chromium" instead of chromium.googlesource.com.
1664 # This happens for internal stuff http://crbug.com/614312.
Edward Lemur79d4f992019-11-11 23:49:02 +00001665 parsed = urllib.parse.urlparse(self.GetRemoteUrl())
tandriie32e3ea2016-06-22 02:52:48 -07001666 if parsed.scheme == 'sso':
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001667 print('WARNING: using non-https URLs for remote is likely broken\n'
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001668 ' Your current remote is: %s' % self.GetRemoteUrl())
tandriie32e3ea2016-06-22 02:52:48 -07001669 self._gerrit_host = '%s.googlesource.com' % self._gerrit_host
1670 self._gerrit_server = 'https://%s' % self._gerrit_host
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001671 return self._gerrit_host
1672
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001673 def _GetGitHost(self):
1674 """Returns git host to be used when uploading change to Gerrit."""
Edward Lemur298f2cf2019-02-22 21:40:39 +00001675 remote_url = self.GetRemoteUrl()
1676 if not remote_url:
1677 return None
Edward Lemur79d4f992019-11-11 23:49:02 +00001678 return urllib.parse.urlparse(remote_url).netloc
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001679
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001680 def GetCodereviewServer(self):
1681 if not self._gerrit_server:
1682 # If we're on a branch then get the server potentially associated
1683 # with that branch.
Edward Lemur85153282020-02-14 22:06:29 +00001684 if self.GetIssue() and self.GetBranch():
tandrii5d48c322016-08-18 16:19:37 -07001685 self._gerrit_server = self._GitGetBranchConfigValue(
Edward Lesmes50da7702020-03-30 19:23:43 +00001686 CODEREVIEW_SERVER_CONFIG_KEY)
tandrii5d48c322016-08-18 16:19:37 -07001687 if self._gerrit_server:
Edward Lemur79d4f992019-11-11 23:49:02 +00001688 self._gerrit_host = urllib.parse.urlparse(self._gerrit_server).netloc
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001689 if not self._gerrit_server:
1690 # We assume repo to be hosted on Gerrit, and hence Gerrit server
1691 # has "-review" suffix for lowest level subdomain.
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001692 parts = self._GetGitHost().split('.')
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001693 parts[0] = parts[0] + '-review'
1694 self._gerrit_host = '.'.join(parts)
1695 self._gerrit_server = 'https://%s' % self._gerrit_host
1696 return self._gerrit_server
1697
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001698 def GetGerritProject(self):
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001699 """Returns Gerrit project name based on remote git URL."""
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00001700 remote_url = self.GetRemoteUrl()
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001701 if remote_url is None:
Josip906bfde2020-01-31 22:38:49 +00001702 logging.warning('can\'t detect Gerrit project.')
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00001703 return None
Edward Lemur79d4f992019-11-11 23:49:02 +00001704 project = urllib.parse.urlparse(remote_url).path.strip('/')
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001705 if project.endswith('.git'):
1706 project = project[:-len('.git')]
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00001707 # *.googlesource.com hosts ensure that Git/Gerrit projects don't start with
1708 # 'a/' prefix, because 'a/' prefix is used to force authentication in
1709 # gitiles/git-over-https protocol. E.g.,
1710 # https://chromium.googlesource.com/a/v8/v8 refers to the same repo/project
1711 # as
1712 # https://chromium.googlesource.com/v8/v8
1713 if project.startswith('a/'):
1714 project = project[len('a/'):]
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001715 return project
1716
Andrii Shyshkalovd06cc782018-08-23 17:24:19 +00001717 def _GerritChangeIdentifier(self):
1718 """Handy method for gerrit_util.ChangeIdentifier for a given CL.
1719
1720 Not to be confused by value of "Change-Id:" footer.
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00001721 If Gerrit project can be determined, this will speed up Gerrit HTTP API RPC.
Andrii Shyshkalovd06cc782018-08-23 17:24:19 +00001722 """
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001723 project = self.GetGerritProject()
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00001724 if project:
1725 return gerrit_util.ChangeIdentifier(project, self.GetIssue())
1726 # Fall back on still unique, but less efficient change number.
1727 return str(self.GetIssue())
Andrii Shyshkalovd06cc782018-08-23 17:24:19 +00001728
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01001729 def EnsureAuthenticated(self, force, refresh=None):
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001730 """Best effort check that user is authenticated with Gerrit server."""
tandrii@chromium.org28253532016-04-14 13:46:56 +00001731 if settings.GetGerritSkipEnsureAuthenticated():
1732 # For projects with unusual authentication schemes.
1733 # See http://crbug.com/603378.
1734 return
Vadim Shtayurab250ec12018-10-04 00:21:08 +00001735
1736 # Check presence of cookies only if using cookies-based auth method.
1737 cookie_auth = gerrit_util.Authenticator.get()
1738 if not isinstance(cookie_auth, gerrit_util.CookiesAuthenticator):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001739 return
Vadim Shtayurab250ec12018-10-04 00:21:08 +00001740
Florian Mayerae510e82020-01-30 21:04:48 +00001741 remote_url = self.GetRemoteUrl()
1742 if remote_url is None:
Josip906bfde2020-01-31 22:38:49 +00001743 logging.warning('invalid remote')
Florian Mayerae510e82020-01-30 21:04:48 +00001744 return
Joanna Wang46ffd1b2022-09-16 20:44:44 +00001745 if urllib.parse.urlparse(remote_url).scheme not in ['https', 'sso']:
1746 logging.warning(
1747 'Ignoring branch %(branch)s with non-https/sso remote '
1748 '%(remote)s', {
1749 'branch': self.branch,
1750 'remote': self.GetRemoteUrl()
1751 })
Daniel Chengcf6269b2019-05-18 01:02:12 +00001752 return
1753
Vadim Shtayurab250ec12018-10-04 00:21:08 +00001754 # Lazy-loader to identify Gerrit and Git hosts.
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001755 self.GetCodereviewServer()
1756 git_host = self._GetGitHost()
Edward Lemur298f2cf2019-02-22 21:40:39 +00001757 assert self._gerrit_server and self._gerrit_host and git_host
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001758
1759 gerrit_auth = cookie_auth.get_auth_header(self._gerrit_host)
1760 git_auth = cookie_auth.get_auth_header(git_host)
1761 if gerrit_auth and git_auth:
1762 if gerrit_auth == git_auth:
1763 return
Andrii Shyshkalov354e1d22017-06-09 19:31:33 +02001764 all_gsrc = cookie_auth.get_auth_header('d0esN0tEx1st.googlesource.com')
Raul Tambre80ee78e2019-05-06 22:41:05 +00001765 print(
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001766 'WARNING: You have different credentials for Gerrit and git hosts:\n'
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001767 ' %s\n'
1768 ' %s\n'
Andrii Shyshkalov51acef92017-04-11 17:19:59 +02001769 ' Consider running the following command:\n'
1770 ' git cl creds-check\n'
Andrii Shyshkalov354e1d22017-06-09 19:31:33 +02001771 ' %s\n'
Raul Tambre80ee78e2019-05-06 22:41:05 +00001772 ' %s' %
Andrii Shyshkalov51acef92017-04-11 17:19:59 +02001773 (git_host, self._gerrit_host,
Andrii Shyshkalov354e1d22017-06-09 19:31:33 +02001774 ('Hint: delete creds for .googlesource.com' if all_gsrc else ''),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001775 cookie_auth.get_new_password_message(git_host)))
1776 if not force:
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001777 confirm_or_exit('If you know what you are doing', action='continue')
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001778 return
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +00001779
1780 missing = (
1781 ([] if gerrit_auth else [self._gerrit_host]) +
1782 ([] if git_auth else [git_host]))
1783 DieWithError('Credentials for the following hosts are required:\n'
1784 ' %s\n'
1785 'These are read from %s (or legacy %s)\n'
1786 '%s' % (
1787 '\n '.join(missing),
1788 cookie_auth.get_gitcookies_path(),
1789 cookie_auth.get_netrc_path(),
1790 cookie_auth.get_new_password_message(git_host)))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001791
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001792 def EnsureCanUploadPatchset(self, force):
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01001793 if not self.GetIssue():
1794 return
1795
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01001796 status = self._GetChangeDetail()['status']
Joanna Wang583ca662022-04-27 21:17:17 +00001797 if status == 'ABANDONED':
Bruce Dawsoneb8426e2022-08-05 23:58:15 +00001798 DieWithError(
1799 'Change %s has been abandoned, new uploads are not allowed' %
1800 (self.GetIssueURL()))
Joanna Wang583ca662022-04-27 21:17:17 +00001801 if status == 'MERGED':
1802 answer = gclient_utils.AskForData(
1803 'Change %s has been submitted, new uploads are not allowed. '
1804 'Would you like to start a new change (Y/n)?' % self.GetIssueURL()
1805 ).lower()
1806 if answer not in ('y', ''):
1807 DieWithError('New uploads are not allowed.')
1808 self.SetIssue()
1809 return
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01001810
Vadim Shtayurab250ec12018-10-04 00:21:08 +00001811 # TODO(vadimsh): For some reason the chunk of code below was skipped if
1812 # 'is_gce' is True. I'm just refactoring it to be 'skip if not cookies'.
1813 # Apparently this check is not very important? Otherwise get_auth_email
1814 # could have been added to other implementations of Authenticator.
1815 cookies_auth = gerrit_util.Authenticator.get()
1816 if not isinstance(cookies_auth, gerrit_util.CookiesAuthenticator):
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001817 return
Vadim Shtayurab250ec12018-10-04 00:21:08 +00001818
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001819 cookies_user = cookies_auth.get_auth_email(self.GetGerritHost())
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001820 if self.GetIssueOwner() == cookies_user:
1821 return
1822 logging.debug('change %s owner is %s, cookies user is %s',
1823 self.GetIssue(), self.GetIssueOwner(), cookies_user)
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001824 # Maybe user has linked accounts or something like that,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001825 # so ask what Gerrit thinks of this user.
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001826 details = gerrit_util.GetAccountDetails(self.GetGerritHost(), 'self')
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001827 if details['email'] == self.GetIssueOwner():
1828 return
1829 if not force:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001830 print('WARNING: Change %s is owned by %s, but you authenticate to Gerrit '
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001831 'as %s.\n'
1832 'Uploading may fail due to lack of permissions.' %
1833 (self.GetIssue(), self.GetIssueOwner(), details['email']))
1834 confirm_or_exit(action='upload')
1835
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001836 def GetStatus(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001837 """Applies a rough heuristic to give a simple summary of an issue's review
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001838 or CQ status, assuming adherence to a common workflow.
1839
1840 Returns None if no issue for this branch, or one of the following keywords:
Aaron Gable9ab38c62017-04-06 14:36:33 -07001841 * 'error' - error from review tool (including deleted issues)
1842 * 'unsent' - no reviewers added
1843 * 'waiting' - waiting for review
1844 * 'reply' - waiting for uploader to reply to review
1845 * 'lgtm' - Code-Review label has been set
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00001846 * 'dry-run' - dry-running in the CQ
1847 * 'commit' - in the CQ
Aaron Gable9ab38c62017-04-06 14:36:33 -07001848 * 'closed' - successfully submitted or abandoned
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001849 """
1850 if not self.GetIssue():
1851 return None
1852
1853 try:
Aaron Gable9ab38c62017-04-06 14:36:33 -07001854 data = self._GetChangeDetail([
1855 'DETAILED_LABELS', 'CURRENT_REVISION', 'SUBMITTABLE'])
Edward Lemur79d4f992019-11-11 23:49:02 +00001856 except GerritChangeNotExists:
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001857 return 'error'
1858
tandrii@chromium.org5e1bf382016-05-17 08:43:24 +00001859 if data['status'] in ('ABANDONED', 'MERGED'):
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001860 return 'closed'
1861
Andrii Shyshkalovb8268ca2019-04-03 23:33:44 +00001862 cq_label = data['labels'].get('Commit-Queue', {})
1863 max_cq_vote = 0
1864 for vote in cq_label.get('all', []):
1865 max_cq_vote = max(max_cq_vote, vote.get('value', 0))
1866 if max_cq_vote == 2:
Aaron Gable9ab38c62017-04-06 14:36:33 -07001867 return 'commit'
Andrii Shyshkalovb8268ca2019-04-03 23:33:44 +00001868 if max_cq_vote == 1:
1869 return 'dry-run'
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001870
Aaron Gable9ab38c62017-04-06 14:36:33 -07001871 if data['labels'].get('Code-Review', {}).get('approved'):
1872 return 'lgtm'
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001873
1874 if not data.get('reviewers', {}).get('REVIEWER', []):
1875 return 'unsent'
1876
Andrii Shyshkalov33e88a42017-01-27 14:45:30 +01001877 owner = data['owner'].get('_account_id')
Edward Lemur79d4f992019-11-11 23:49:02 +00001878 messages = sorted(data.get('messages', []), key=lambda m: m.get('date'))
Andrii Shyshkalov8aa9d622020-03-10 19:15:35 +00001879 while messages:
1880 m = messages.pop()
Andrii Shyshkalov899785a2021-07-09 12:45:37 +00001881 if (m.get('tag', '').startswith('autogenerated:cq') or
1882 m.get('tag', '').startswith('autogenerated:cv')):
1883 # Ignore replies from LUCI CV/CQ.
Andrii Shyshkalov33e88a42017-01-27 14:45:30 +01001884 continue
Andrii Shyshkalov8aa9d622020-03-10 19:15:35 +00001885 if m.get('author', {}).get('_account_id') == owner:
Aaron Gable9ab38c62017-04-06 14:36:33 -07001886 # Most recent message was by owner.
1887 return 'waiting'
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +00001888
1889 # Some reply from non-owner.
1890 return 'reply'
Aaron Gable9ab38c62017-04-06 14:36:33 -07001891
1892 # Somehow there are no messages even though there are reviewers.
1893 return 'unsent'
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001894
1895 def GetMostRecentPatchset(self):
Edward Lemur6c6827c2020-02-06 21:15:18 +00001896 if not self.GetIssue():
1897 return None
1898
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001899 data = self._GetChangeDetail(['CURRENT_REVISION'])
Aaron Gablee8856ee2017-12-07 12:41:46 -08001900 patchset = data['revisions'][data['current_revision']]['_number']
1901 self.SetPatchset(patchset)
1902 return patchset
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001903
Gavin Make61ccc52020-11-13 00:12:57 +00001904 def GetMostRecentDryRunPatchset(self):
1905 """Get patchsets equivalent to the most recent patchset and return
1906 the patchset with the latest dry run. If none have been dry run, return
1907 the latest patchset."""
1908 if not self.GetIssue():
1909 return None
1910
1911 data = self._GetChangeDetail(['ALL_REVISIONS'])
1912 patchset = data['revisions'][data['current_revision']]['_number']
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +00001913 dry_run = {int(m['_revision_number'])
1914 for m in data.get('messages', [])
1915 if m.get('tag', '').endswith('dry-run')}
Gavin Make61ccc52020-11-13 00:12:57 +00001916
1917 for revision_info in sorted(data.get('revisions', {}).values(),
1918 key=lambda c: c['_number'], reverse=True):
1919 if revision_info['_number'] in dry_run:
1920 patchset = revision_info['_number']
1921 break
1922 if revision_info.get('kind', '') not in \
1923 ('NO_CHANGE', 'NO_CODE_CHANGE', 'TRIVIAL_REBASE'):
1924 break
1925 self.SetPatchset(patchset)
1926 return patchset
1927
Aaron Gable636b13f2017-07-14 10:42:48 -07001928 def AddComment(self, message, publish=None):
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00001929 gerrit_util.SetReview(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001930 self.GetGerritHost(), self._GerritChangeIdentifier(),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00001931 msg=message, ready=publish)
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01001932
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001933 def GetCommentsSummary(self, readable=True):
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01001934 # DETAILED_ACCOUNTS is to get emails in accounts.
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001935 # CURRENT_REVISION is included to get the latest patchset so that
1936 # only the robot comments from the latest patchset can be shown.
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001937 messages = self._GetChangeDetail(
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001938 options=['MESSAGES', 'DETAILED_ACCOUNTS',
1939 'CURRENT_REVISION']).get('messages', [])
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001940 file_comments = gerrit_util.GetChangeComments(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001941 self.GetGerritHost(), self._GerritChangeIdentifier())
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001942 robot_file_comments = gerrit_util.GetChangeRobotComments(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001943 self.GetGerritHost(), self._GerritChangeIdentifier())
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001944
1945 # Add the robot comments onto the list of comments, but only
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00001946 # keep those that are from the latest patchset.
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001947 latest_patch_set = self.GetMostRecentPatchset()
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001948 for path, robot_comments in robot_file_comments.items():
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001949 line_comments = file_comments.setdefault(path, [])
1950 line_comments.extend(
1951 [c for c in robot_comments if c['patch_set'] == latest_patch_set])
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001952
1953 # Build dictionary of file comments for easy access and sorting later.
1954 # {author+date: {path: {patchset: {line: url+message}}}}
1955 comments = collections.defaultdict(
1956 lambda: collections.defaultdict(lambda: collections.defaultdict(dict)))
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00001957
1958 server = self.GetCodereviewServer()
1959 if server in _KNOWN_GERRIT_TO_SHORT_URLS:
1960 # /c/ is automatically added by short URL server.
1961 url_prefix = '%s/%s' % (_KNOWN_GERRIT_TO_SHORT_URLS[server],
1962 self.GetIssue())
1963 else:
1964 url_prefix = '%s/c/%s' % (server, self.GetIssue())
1965
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001966 for path, line_comments in file_comments.items():
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001967 for comment in line_comments:
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001968 tag = comment.get('tag', '')
1969 if tag.startswith('autogenerated') and 'robot_id' not in comment:
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001970 continue
1971 key = (comment['author']['email'], comment['updated'])
1972 if comment.get('side', 'REVISION') == 'PARENT':
1973 patchset = 'Base'
1974 else:
1975 patchset = 'PS%d' % comment['patch_set']
1976 line = comment.get('line', 0)
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00001977 url = ('%s/%s/%s#%s%s' %
1978 (url_prefix, comment['patch_set'], path,
1979 'b' if comment.get('side') == 'PARENT' else '',
1980 str(line) if line else ''))
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001981 comments[key][path][patchset][line] = (url, comment['message'])
1982
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001983 summaries = []
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001984 for msg in messages:
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001985 summary = self._BuildCommentSummary(msg, comments, readable)
1986 if summary:
1987 summaries.append(summary)
1988 return summaries
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001989
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001990 @staticmethod
1991 def _BuildCommentSummary(msg, comments, readable):
Josip Sokcevic266129c2021-11-09 00:22:00 +00001992 if 'email' not in msg['author']:
1993 # Some bot accounts may not have an email associated.
1994 return None
1995
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001996 key = (msg['author']['email'], msg['date'])
1997 # Don't bother showing autogenerated messages that don't have associated
1998 # file or line comments. this will filter out most autogenerated
1999 # messages, but will keep robot comments like those from Tricium.
2000 is_autogenerated = msg.get('tag', '').startswith('autogenerated')
2001 if is_autogenerated and not comments.get(key):
2002 return None
2003 message = msg['message']
2004 # Gerrit spits out nanoseconds.
2005 assert len(msg['date'].split('.')[-1]) == 9
2006 date = datetime.datetime.strptime(msg['date'][:-3],
2007 '%Y-%m-%d %H:%M:%S.%f')
2008 if key in comments:
2009 message += '\n'
2010 for path, patchsets in sorted(comments.get(key, {}).items()):
2011 if readable:
2012 message += '\n%s' % path
2013 for patchset, lines in sorted(patchsets.items()):
2014 for line, (url, content) in sorted(lines.items()):
2015 if line:
2016 line_str = 'Line %d' % line
2017 path_str = '%s:%d:' % (path, line)
2018 else:
2019 line_str = 'File comment'
2020 path_str = '%s:0:' % path
2021 if readable:
2022 message += '\n %s, %s: %s' % (patchset, line_str, url)
2023 message += '\n %s\n' % content
2024 else:
2025 message += '\n%s ' % path_str
2026 message += '\n%s\n' % content
2027
2028 return _CommentSummary(
2029 date=date,
2030 message=message,
2031 sender=msg['author']['email'],
2032 autogenerated=is_autogenerated,
2033 # These could be inferred from the text messages and correlated with
2034 # Code-Review label maximum, however this is not reliable.
2035 # Leaving as is until the need arises.
2036 approval=False,
2037 disapproval=False,
2038 )
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01002039
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002040 def CloseIssue(self):
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002041 gerrit_util.AbandonChange(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00002042 self.GetGerritHost(), self._GerritChangeIdentifier(), msg='')
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002043
Xinan Lin1bd4ffa2021-07-28 00:54:22 +00002044 def SubmitIssue(self):
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002045 gerrit_util.SubmitChange(
Xinan Lin1bd4ffa2021-07-28 00:54:22 +00002046 self.GetGerritHost(), self._GerritChangeIdentifier())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002047
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002048 def _GetChangeDetail(self, options=None):
2049 """Returns details of associated Gerrit change and caching results."""
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002050 options = options or []
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002051 assert self.GetIssue(), 'issue is required to query Gerrit'
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002052
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01002053 # Optimization to avoid multiple RPCs:
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002054 if 'CURRENT_REVISION' in options or 'ALL_REVISIONS' in options:
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01002055 options.append('CURRENT_COMMIT')
2056
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002057 # Normalize issue and options for consistent keys in cache.
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002058 cache_key = str(self.GetIssue())
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002059 options_set = frozenset(o.upper() for o in options)
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002060
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002061 for cached_options_set, data in self._detail_cache.get(cache_key, []):
2062 # Assumption: data fetched before with extra options is suitable
2063 # for return for a smaller set of options.
2064 # For example, if we cached data for
2065 # options=[CURRENT_REVISION, DETAILED_FOOTERS]
2066 # and request is for options=[CURRENT_REVISION],
2067 # THEN we can return prior cached data.
2068 if options_set.issubset(cached_options_set):
2069 return data
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002070
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01002071 try:
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002072 data = gerrit_util.GetChangeDetail(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00002073 self.GetGerritHost(), self._GerritChangeIdentifier(), options_set)
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01002074 except gerrit_util.GerritError as e:
2075 if e.http_status == 404:
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002076 raise GerritChangeNotExists(self.GetIssue(), self.GetCodereviewServer())
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01002077 raise
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002078
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002079 self._detail_cache.setdefault(cache_key, []).append((options_set, data))
tandriic2405f52016-10-10 08:13:15 -07002080 return data
tandrii@chromium.org013a2802016-03-29 09:52:33 +00002081
Andrii Shyshkalovcc5f17e2018-08-22 23:35:59 +00002082 def _GetChangeCommit(self):
Andrii Shyshkalove2633162018-08-27 23:50:31 +00002083 assert self.GetIssue(), 'issue must be set to query Gerrit'
Aaron Gable6f5a8d92017-04-18 14:49:05 -07002084 try:
Andrii Shyshkalove2633162018-08-27 23:50:31 +00002085 data = gerrit_util.GetChangeCommit(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00002086 self.GetGerritHost(), self._GerritChangeIdentifier())
Aaron Gable6f5a8d92017-04-18 14:49:05 -07002087 except gerrit_util.GerritError as e:
2088 if e.http_status == 404:
Andrii Shyshkalove2633162018-08-27 23:50:31 +00002089 raise GerritChangeNotExists(self.GetIssue(), self.GetCodereviewServer())
Aaron Gable6f5a8d92017-04-18 14:49:05 -07002090 raise
agable32978d92016-11-01 12:55:02 -07002091 return data
2092
Karen Qian40c19422019-03-13 21:28:29 +00002093 def _IsCqConfigured(self):
2094 detail = self._GetChangeDetail(['LABELS'])
Andrii Shyshkalov8effa4d2020-01-21 13:23:36 +00002095 return u'Commit-Queue' in detail.get('labels', {})
Karen Qian40c19422019-03-13 21:28:29 +00002096
Saagar Sanghavi03b15132020-08-10 16:43:41 +00002097 def CMDLand(self, force, bypass_hooks, verbose, parallel, resultdb, realm):
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002098 if git_common.is_dirty_git_tree('land'):
2099 return 1
Karen Qian40c19422019-03-13 21:28:29 +00002100
tandriid60367b2016-06-22 05:25:12 -07002101 detail = self._GetChangeDetail(['CURRENT_REVISION', 'LABELS'])
Karen Qian40c19422019-03-13 21:28:29 +00002102 if not force and self._IsCqConfigured():
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00002103 confirm_or_exit('\nIt seems this repository has a CQ, '
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002104 'which can test and land changes for you. '
2105 'Are you sure you wish to bypass it?\n',
2106 action='bypass CQ')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002107 differs = True
tandriic4344b52016-08-29 06:04:54 -07002108 last_upload = self._GitGetBranchConfigValue('gerritsquashhash')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002109 # Note: git diff outputs nothing if there is no diff.
2110 if not last_upload or RunGit(['diff', last_upload]).strip():
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002111 print('WARNING: Some changes from local branch haven\'t been uploaded.')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002112 else:
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002113 if detail['current_revision'] == last_upload:
2114 differs = False
2115 else:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002116 print('WARNING: Local branch contents differ from latest uploaded '
2117 'patchset.')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002118 if differs:
2119 if not force:
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002120 confirm_or_exit(
2121 'Do you want to submit latest Gerrit patchset and bypass hooks?\n',
2122 action='submit')
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002123 print('WARNING: Bypassing hooks and submitting latest uploaded patchset.')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002124 elif not bypass_hooks:
Edward Lemur227d5102020-02-25 23:45:35 +00002125 upstream = self.GetCommonAncestorWithUpstream()
2126 if self.GetIssue():
2127 description = self.FetchDescription()
2128 else:
Edward Lemura12175c2020-03-09 16:58:26 +00002129 description = _create_description_from_log([upstream])
Edward Lemur227d5102020-02-25 23:45:35 +00002130 self.RunHook(
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002131 committing=True,
2132 may_prompt=not force,
2133 verbose=verbose,
Edward Lemur227d5102020-02-25 23:45:35 +00002134 parallel=parallel,
2135 upstream=upstream,
2136 description=description,
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00002137 all_files=False,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00002138 resultdb=resultdb,
2139 realm=realm)
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002140
Xinan Lin1bd4ffa2021-07-28 00:54:22 +00002141 self.SubmitIssue()
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002142 print('Issue %s has been submitted.' % self.GetIssueURL())
agable32978d92016-11-01 12:55:02 -07002143 links = self._GetChangeCommit().get('web_links', [])
2144 for link in links:
Michael Mosse371c642021-09-29 16:41:04 +00002145 if link.get('name') in ['gitiles', 'browse'] and link.get('url'):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002146 print('Landed as: %s' % link.get('url'))
agable32978d92016-11-01 12:55:02 -07002147 break
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002148 return 0
2149
Bruce Dawsonf362f6f2021-02-18 23:15:17 +00002150 def CMDPatchWithParsedIssue(self, parsed_issue_arg, nocommit, force,
2151 newbranch):
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002152 assert parsed_issue_arg.valid
2153
Edward Lemur125d60a2019-09-13 18:25:41 +00002154 self.issue = parsed_issue_arg.issue
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002155
2156 if parsed_issue_arg.hostname:
2157 self._gerrit_host = parsed_issue_arg.hostname
2158 self._gerrit_server = 'https://%s' % self._gerrit_host
2159
tandriic2405f52016-10-10 08:13:15 -07002160 try:
2161 detail = self._GetChangeDetail(['ALL_REVISIONS'])
Aaron Gablea45ee112016-11-22 15:14:38 -08002162 except GerritChangeNotExists as e:
tandriic2405f52016-10-10 08:13:15 -07002163 DieWithError(str(e))
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002164
2165 if not parsed_issue_arg.patchset:
2166 # Use current revision by default.
2167 revision_info = detail['revisions'][detail['current_revision']]
2168 patchset = int(revision_info['_number'])
2169 else:
2170 patchset = parsed_issue_arg.patchset
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00002171 for revision_info in detail['revisions'].values():
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002172 if int(revision_info['_number']) == parsed_issue_arg.patchset:
2173 break
2174 else:
Aaron Gablea45ee112016-11-22 15:14:38 -08002175 DieWithError('Couldn\'t find patchset %i in change %i' %
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002176 (parsed_issue_arg.patchset, self.GetIssue()))
2177
Edward Lemur125d60a2019-09-13 18:25:41 +00002178 remote_url = self.GetRemoteUrl()
Aaron Gable697a91b2018-01-19 15:20:15 -08002179 if remote_url.endswith('.git'):
2180 remote_url = remote_url[:-len('.git')]
erikchen0d14d0d2018-08-28 18:57:09 +00002181 remote_url = remote_url.rstrip('/')
2182
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002183 fetch_info = revision_info['fetch']['http']
erikchen0d14d0d2018-08-28 18:57:09 +00002184 fetch_info['url'] = fetch_info['url'].rstrip('/')
Aaron Gable697a91b2018-01-19 15:20:15 -08002185
2186 if remote_url != fetch_info['url']:
2187 DieWithError('Trying to patch a change from %s but this repo appears '
2188 'to be %s.' % (fetch_info['url'], remote_url))
2189
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002190 RunGit(['fetch', fetch_info['url'], fetch_info['ref']])
Aaron Gable9387b4f2017-06-08 10:50:03 -07002191
Bruce Dawsonf362f6f2021-02-18 23:15:17 +00002192 # If we have created a new branch then do the "set issue" immediately in
2193 # case the cherry-pick fails, which happens when resolving conflicts.
2194 if newbranch:
2195 self.SetIssue(parsed_issue_arg.issue)
2196
Aaron Gable62619a32017-06-16 08:22:09 -07002197 if force:
2198 RunGit(['reset', '--hard', 'FETCH_HEAD'])
2199 print('Checked out commit for change %i patchset %i locally' %
2200 (parsed_issue_arg.issue, patchset))
Stefan Zager2d5f0392017-10-10 15:17:53 -07002201 elif nocommit:
2202 RunGit(['cherry-pick', '--no-commit', 'FETCH_HEAD'])
2203 print('Patch applied to index.')
Aaron Gable62619a32017-06-16 08:22:09 -07002204 else:
Aaron Gable9387b4f2017-06-08 10:50:03 -07002205 RunGit(['cherry-pick', 'FETCH_HEAD'])
2206 print('Committed patch for change %i patchset %i locally.' %
Aaron Gable62619a32017-06-16 08:22:09 -07002207 (parsed_issue_arg.issue, patchset))
2208 print('Note: this created a local commit which does not have '
2209 'the same hash as the one uploaded for review. This will make '
2210 'uploading changes based on top of this branch difficult.\n'
2211 'If you want to do that, use "git cl patch --force" instead.')
2212
Stefan Zagerd08043c2017-10-12 12:07:02 -07002213 if self.GetBranch():
2214 self.SetIssue(parsed_issue_arg.issue)
2215 self.SetPatchset(patchset)
Edward Lesmes50da7702020-03-30 19:23:43 +00002216 fetched_hash = scm.GIT.ResolveCommit(settings.GetRoot(), 'FETCH_HEAD')
Stefan Zagerd08043c2017-10-12 12:07:02 -07002217 self._GitSetBranchConfigValue('last-upload-hash', fetched_hash)
2218 self._GitSetBranchConfigValue('gerritsquashhash', fetched_hash)
2219 else:
2220 print('WARNING: You are in detached HEAD state.\n'
2221 'The patch has been applied to your checkout, but you will not be '
2222 'able to upload a new patch set to the gerrit issue.\n'
2223 'Try using the \'-b\' option if you would like to work on a '
2224 'branch and/or upload a new patch set.')
2225
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002226 return 0
2227
tandrii16e0b4e2016-06-07 10:34:28 -07002228 def _GerritCommitMsgHookCheck(self, offer_removal):
2229 hook = os.path.join(settings.GetRoot(), '.git', 'hooks', 'commit-msg')
2230 if not os.path.exists(hook):
2231 return
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002232 # Crude attempt to distinguish Gerrit Codereview hook from a potentially
2233 # custom developer-made one.
tandrii16e0b4e2016-06-07 10:34:28 -07002234 data = gclient_utils.FileRead(hook)
2235 if not('From Gerrit Code Review' in data and 'add_ChangeId()' in data):
2236 return
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002237 print('WARNING: You have Gerrit commit-msg hook installed.\n'
qyearsley12fa6ff2016-08-24 09:18:40 -07002238 'It is not necessary for uploading with git cl in squash mode, '
tandrii16e0b4e2016-06-07 10:34:28 -07002239 'and may interfere with it in subtle ways.\n'
2240 'We recommend you remove the commit-msg hook.')
2241 if offer_removal:
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002242 if ask_for_explicit_yes('Do you want to remove it now?'):
tandrii16e0b4e2016-06-07 10:34:28 -07002243 gclient_utils.rm_file_or_tree(hook)
2244 print('Gerrit commit-msg hook removed.')
2245 else:
2246 print('OK, will keep Gerrit commit-msg hook in place.')
2247
Edward Lemur1b52d872019-05-09 21:12:12 +00002248 def _CleanUpOldTraces(self):
2249 """Keep only the last |MAX_TRACES| traces."""
2250 try:
2251 traces = sorted([
2252 os.path.join(TRACES_DIR, f)
2253 for f in os.listdir(TRACES_DIR)
2254 if (os.path.isfile(os.path.join(TRACES_DIR, f))
2255 and not f.startswith('tmp'))
2256 ])
2257 traces_to_delete = traces[:-MAX_TRACES]
2258 for trace in traces_to_delete:
Daniel Chengcf6269b2019-05-18 01:02:12 +00002259 os.remove(trace)
Edward Lemur1b52d872019-05-09 21:12:12 +00002260 except OSError:
2261 print('WARNING: Failed to remove old git traces from\n'
2262 ' %s'
2263 'Consider removing them manually.' % TRACES_DIR)
Edward Lemurdc8e23d2019-05-07 00:45:48 +00002264
Edward Lemur5737f022019-05-17 01:24:00 +00002265 def _WriteGitPushTraces(self, trace_name, traces_dir, git_push_metadata):
Edward Lemur1b52d872019-05-09 21:12:12 +00002266 """Zip and write the git push traces stored in traces_dir."""
2267 gclient_utils.safe_makedirs(TRACES_DIR)
Edward Lemur1b52d872019-05-09 21:12:12 +00002268 traces_zip = trace_name + '-traces'
2269 traces_readme = trace_name + '-README'
Michael Mosse7f0b4c2019-05-08 04:36:24 +00002270 # Create a temporary dir to store git config and gitcookies in. It will be
2271 # compressed and stored next to the traces.
2272 git_info_dir = tempfile.mkdtemp()
Edward Lemur1b52d872019-05-09 21:12:12 +00002273 git_info_zip = trace_name + '-git-info'
2274
Josip Sokcevic5e18b602020-04-23 21:47:00 +00002275 git_push_metadata['now'] = datetime_now().strftime('%Y-%m-%dT%H:%M:%S.%f')
sangwoo.ko7a614332019-05-22 02:46:19 +00002276
Edward Lemur1b52d872019-05-09 21:12:12 +00002277 git_push_metadata['trace_name'] = trace_name
2278 gclient_utils.FileWrite(
2279 traces_readme, TRACES_README_FORMAT % git_push_metadata)
2280
2281 # Keep only the first 6 characters of the git hashes on the packet
2282 # trace. This greatly decreases size after compression.
2283 packet_traces = os.path.join(traces_dir, 'trace-packet')
2284 if os.path.isfile(packet_traces):
2285 contents = gclient_utils.FileRead(packet_traces)
2286 gclient_utils.FileWrite(
2287 packet_traces, GIT_HASH_RE.sub(r'\1', contents))
2288 shutil.make_archive(traces_zip, 'zip', traces_dir)
2289
2290 # Collect and compress the git config and gitcookies.
2291 git_config = RunGit(['config', '-l'])
2292 gclient_utils.FileWrite(
2293 os.path.join(git_info_dir, 'git-config'),
2294 git_config)
2295
2296 cookie_auth = gerrit_util.Authenticator.get()
2297 if isinstance(cookie_auth, gerrit_util.CookiesAuthenticator):
2298 gitcookies_path = cookie_auth.get_gitcookies_path()
2299 if os.path.isfile(gitcookies_path):
2300 gitcookies = gclient_utils.FileRead(gitcookies_path)
2301 gclient_utils.FileWrite(
2302 os.path.join(git_info_dir, 'gitcookies'),
2303 GITCOOKIES_REDACT_RE.sub('REDACTED', gitcookies))
2304 shutil.make_archive(git_info_zip, 'zip', git_info_dir)
2305
Edward Lemur1b52d872019-05-09 21:12:12 +00002306 gclient_utils.rmtree(git_info_dir)
2307
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +00002308 def _RunGitPushWithTraces(self,
2309 refspec,
2310 refspec_opts,
2311 git_push_metadata,
2312 git_push_options=None):
Edward Lemur1b52d872019-05-09 21:12:12 +00002313 """Run git push and collect the traces resulting from the execution."""
2314 # Create a temporary directory to store traces in. Traces will be compressed
2315 # and stored in a 'traces' dir inside depot_tools.
2316 traces_dir = tempfile.mkdtemp()
Edward Lemur5737f022019-05-17 01:24:00 +00002317 trace_name = os.path.join(
2318 TRACES_DIR, datetime_now().strftime('%Y%m%dT%H%M%S.%f'))
Edward Lemur0f58ae42019-04-30 17:24:12 +00002319
2320 env = os.environ.copy()
2321 env['GIT_REDACT_COOKIES'] = 'o,SSO,GSSO_Uberproxy'
2322 env['GIT_TR2_EVENT'] = os.path.join(traces_dir, 'tr2-event')
Jonathan Nieder9779b142019-05-29 23:19:29 +00002323 env['GIT_TRACE2_EVENT'] = os.path.join(traces_dir, 'tr2-event')
Edward Lemur0f58ae42019-04-30 17:24:12 +00002324 env['GIT_TRACE_CURL'] = os.path.join(traces_dir, 'trace-curl')
2325 env['GIT_TRACE_CURL_NO_DATA'] = '1'
2326 env['GIT_TRACE_PACKET'] = os.path.join(traces_dir, 'trace-packet')
2327
2328 try:
2329 push_returncode = 0
Edward Lemur1b52d872019-05-09 21:12:12 +00002330 remote_url = self.GetRemoteUrl()
Edward Lemur0f58ae42019-04-30 17:24:12 +00002331 before_push = time_time()
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +00002332 push_cmd = ['git', 'push', remote_url, refspec]
2333 if git_push_options:
2334 for opt in git_push_options:
2335 push_cmd.extend(['-o', opt])
2336
Edward Lemur0f58ae42019-04-30 17:24:12 +00002337 push_stdout = gclient_utils.CheckCallAndFilter(
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +00002338 push_cmd,
Edward Lemur0f58ae42019-04-30 17:24:12 +00002339 env=env,
2340 print_stdout=True,
2341 # Flush after every line: useful for seeing progress when running as
2342 # recipe.
2343 filter_fn=lambda _: sys.stdout.flush())
Edward Lemur79d4f992019-11-11 23:49:02 +00002344 push_stdout = push_stdout.decode('utf-8', 'replace')
Edward Lemur0f58ae42019-04-30 17:24:12 +00002345 except subprocess2.CalledProcessError as e:
2346 push_returncode = e.returncode
Josip Sokcevic740825e2021-05-12 18:28:34 +00002347 if 'blocked keyword' in str(e.stdout):
2348 raise GitPushError(
2349 'Failed to create a change, very likely due to blocked keyword. '
2350 'Please examine output above for the reason of the failure.\n'
2351 'If this is a false positive, you can try to bypass blocked '
2352 'keyword by using push option '
2353 '-o uploadvalidator~skip, e.g.:\n'
2354 'git cl upload -o uploadvalidator~skip\n\n'
2355 'If git-cl is not working correctly, file a bug under the '
2356 'Infra>SDK component.')
Josip Sokcevic54e30e72022-02-10 22:32:24 +00002357 if 'git push -o nokeycheck' in str(e.stdout):
2358 raise GitPushError(
2359 'Failed to create a change, very likely due to a private key being '
2360 'detected. Please examine output above for the reason of the '
2361 'failure.\n'
2362 'If this is a false positive, you can try to bypass private key '
2363 'detection by using push option '
2364 '-o nokeycheck, e.g.:\n'
2365 'git cl upload -o nokeycheck\n\n'
2366 'If git-cl is not working correctly, file a bug under the '
2367 'Infra>SDK component.')
Josip Sokcevic740825e2021-05-12 18:28:34 +00002368
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002369 raise GitPushError(
2370 'Failed to create a change. Please examine output above for the '
2371 'reason of the failure.\n'
Josip Sokcevic7386a1e2021-02-12 19:00:34 +00002372 'For emergencies, Googlers can escalate to '
2373 'go/gob-support or go/notify#gob\n'
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002374 'Hint: run command below to diagnose common Git/Gerrit '
2375 'credential problems:\n'
2376 ' git cl creds-check\n'
2377 '\n'
2378 'If git-cl is not working correctly, file a bug under the Infra>SDK '
2379 'component including the files below.\n'
2380 'Review the files before upload, since they might contain sensitive '
2381 'information.\n'
2382 'Set the Restrict-View-Google label so that they are not publicly '
2383 'accessible.\n' + TRACES_MESSAGE % {'trace_name': trace_name})
Edward Lemur0f58ae42019-04-30 17:24:12 +00002384 finally:
2385 execution_time = time_time() - before_push
2386 metrics.collector.add_repeated('sub_commands', {
2387 'command': 'git push',
2388 'execution_time': execution_time,
2389 'exit_code': push_returncode,
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002390 'arguments': metrics_utils.extract_known_subcommand_args(refspec_opts),
Edward Lemur0f58ae42019-04-30 17:24:12 +00002391 })
2392
Edward Lemur1b52d872019-05-09 21:12:12 +00002393 git_push_metadata['execution_time'] = execution_time
2394 git_push_metadata['exit_code'] = push_returncode
Edward Lemur5737f022019-05-17 01:24:00 +00002395 self._WriteGitPushTraces(trace_name, traces_dir, git_push_metadata)
Edward Lemur0f58ae42019-04-30 17:24:12 +00002396
Edward Lemur1b52d872019-05-09 21:12:12 +00002397 self._CleanUpOldTraces()
Edward Lemur0f58ae42019-04-30 17:24:12 +00002398 gclient_utils.rmtree(traces_dir)
2399
2400 return push_stdout
2401
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002402 def CMDUploadChange(self, options, git_diff_args, custom_cl_base,
2403 change_desc):
2404 """Upload the current branch to Gerrit, retry if new remote HEAD is
2405 found. options and change_desc may be mutated."""
Josip Sokcevicb631a882021-01-06 18:18:10 +00002406 remote, remote_branch = self.GetRemoteBranch()
2407 branch = GetTargetRef(remote, remote_branch, options.target_branch)
2408
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002409 try:
2410 return self._CMDUploadChange(options, git_diff_args, custom_cl_base,
Josip Sokcevicb631a882021-01-06 18:18:10 +00002411 change_desc, branch)
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002412 except GitPushError as e:
Josip Sokcevicb631a882021-01-06 18:18:10 +00002413 # Repository might be in the middle of transition to main branch as
2414 # default, and uploads to old default might be blocked.
2415 if remote_branch not in [DEFAULT_OLD_BRANCH, DEFAULT_NEW_BRANCH]:
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002416 DieWithError(str(e), change_desc)
2417
Josip Sokcevicb631a882021-01-06 18:18:10 +00002418 project_head = gerrit_util.GetProjectHead(self._gerrit_host,
2419 self.GetGerritProject())
2420 if project_head == branch:
2421 DieWithError(str(e), change_desc)
2422 branch = project_head
2423
2424 print("WARNING: Fetching remote state and retrying upload to default "
2425 "branch...")
2426 RunGit(['fetch', '--prune', remote])
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002427 options.edit_description = False
2428 options.force = True
2429 try:
Josip Sokcevicb631a882021-01-06 18:18:10 +00002430 self._CMDUploadChange(options, git_diff_args, custom_cl_base,
2431 change_desc, branch)
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002432 except GitPushError as e:
2433 DieWithError(str(e), change_desc)
2434
2435 def _CMDUploadChange(self, options, git_diff_args, custom_cl_base,
Josip Sokcevicb631a882021-01-06 18:18:10 +00002436 change_desc, branch):
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002437 """Upload the current branch to Gerrit."""
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002438 if options.squash:
tandrii16e0b4e2016-06-07 10:34:28 -07002439 self._GerritCommitMsgHookCheck(offer_removal=not options.force)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002440 if self.GetIssue():
Josipe827b0f2020-01-30 00:07:20 +00002441 # User requested to change description
2442 if options.edit_description:
Josipe827b0f2020-01-30 00:07:20 +00002443 change_desc.prompt()
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002444 change_id = self._GetChangeDetail()['change_id']
Edward Lemur5a644f82020-03-18 16:44:57 +00002445 change_desc.ensure_change_id(change_id)
Aaron Gableb56ad332017-01-06 15:24:31 -08002446 else: # if not self.GetIssue()
Gavin Mak68e6cf32021-01-25 18:24:08 +00002447 if not options.force and not options.message_file:
Anthony Polito8b955342019-09-24 19:01:36 +00002448 change_desc.prompt()
Andrii Shyshkalov8c90d032017-04-19 21:27:26 +02002449 change_ids = git_footers.get_footer_change_id(change_desc.description)
Edward Lemur5a644f82020-03-18 16:44:57 +00002450 if len(change_ids) == 1:
2451 change_id = change_ids[0]
2452 else:
2453 change_id = GenerateGerritChangeId(change_desc.description)
2454 change_desc.ensure_change_id(change_id)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002455
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +00002456 if options.preserve_tryjobs:
2457 change_desc.set_preserve_tryjobs()
Robert Iannuccidb02dd02017-04-19 12:18:20 -07002458
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002459 remote, upstream_branch = self.FetchUpstreamTuple(self.GetBranch())
Edward Lemur5a644f82020-03-18 16:44:57 +00002460 parent = self._ComputeParent(
2461 remote, upstream_branch, custom_cl_base, options.force, change_desc)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002462 tree = RunGit(['rev-parse', 'HEAD:']).strip()
Edward Lemur1773f372020-02-22 00:27:14 +00002463 with gclient_utils.temporary_file() as desc_tempfile:
2464 gclient_utils.FileWrite(desc_tempfile, change_desc.description)
2465 ref_to_push = RunGit(
2466 ['commit-tree', tree, '-p', parent, '-F', desc_tempfile]).strip()
Anthony Polito8b955342019-09-24 19:01:36 +00002467 else: # if not options.squash
Gregory Nisbet48d9e1e2021-04-15 23:35:54 +00002468 if options.no_add_changeid:
2469 pass
2470 else: # adding Change-Ids is okay.
2471 if not git_footers.get_footer_change_id(change_desc.description):
2472 DownloadGerritHook(False)
2473 change_desc.set_description(
2474 self._AddChangeIdToCommitMessage(change_desc.description,
2475 git_diff_args))
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002476 ref_to_push = 'HEAD'
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002477 # For no-squash mode, we assume the remote called "origin" is the one we
2478 # want. It is not worthwhile to support different workflows for
2479 # no-squash mode.
2480 parent = 'origin/%s' % branch
Gregory Nisbet48d9e1e2021-04-15 23:35:54 +00002481 # attempt to extract the changeid from the current description
2482 # fail informatively if not possible.
2483 change_id_candidates = git_footers.get_footer_change_id(
2484 change_desc.description)
2485 if not change_id_candidates:
2486 DieWithError("Unable to extract change-id from message.")
2487 change_id = change_id_candidates[0]
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002488
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +00002489 SaveDescriptionBackup(change_desc)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002490 commits = RunGitSilent(['rev-list', '%s..%s' % (parent,
2491 ref_to_push)]).splitlines()
2492 if len(commits) > 1:
2493 print('WARNING: This will upload %d commits. Run the following command '
2494 'to see which commits will be uploaded: ' % len(commits))
2495 print('git log %s..%s' % (parent, ref_to_push))
2496 print('You can also use `git squash-branch` to squash these into a '
2497 'single commit.')
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002498 confirm_or_exit(action='upload')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002499
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00002500 reviewers = sorted(change_desc.get_reviewers())
Edward Lemur4508b422019-10-03 21:56:35 +00002501 cc = []
2502 # Add CCs from WATCHLISTS and rietveld.cc git config unless this is
2503 # the initial upload, the CL is private, or auto-CCing has ben disabled.
2504 if not (self.GetIssue() or options.private or options.no_autocc):
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00002505 cc = self.GetCCList().split(',')
Gavin Makb1c08f62021-04-01 18:05:58 +00002506 if len(cc) > 100:
2507 lsc = ('https://chromium.googlesource.com/chromium/src/+/HEAD/docs/'
2508 'process/lsc/lsc_workflow.md')
2509 print('WARNING: This will auto-CC %s users.' % len(cc))
2510 print('LSC may be more appropriate: %s' % lsc)
2511 print('You can also use the --no-autocc flag to disable auto-CC.')
2512 confirm_or_exit(action='continue')
Edward Lemur4508b422019-10-03 21:56:35 +00002513 # Add cc's from the --cc flag.
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00002514 if options.cc:
2515 cc.extend(options.cc)
Edward Lemur79d4f992019-11-11 23:49:02 +00002516 cc = [email.strip() for email in cc if email.strip()]
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00002517 if change_desc.get_cced():
2518 cc.extend(change_desc.get_cced())
Edward Lesmeseeca9c62020-11-20 00:00:17 +00002519 if self.GetGerritHost() == 'chromium-review.googlesource.com':
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00002520 valid_accounts = set(reviewers + cc)
2521 # TODO(crbug/877717): relax this for all hosts.
2522 else:
2523 valid_accounts = gerrit_util.ValidAccounts(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00002524 self.GetGerritHost(), reviewers + cc)
Andrii Shyshkalovf170af42018-10-30 07:00:44 +00002525 logging.info('accounts %s are recognized, %s invalid',
2526 sorted(valid_accounts),
2527 set(reviewers + cc).difference(set(valid_accounts)))
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00002528
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00002529 # Extra options that can be specified at push time. Doc:
2530 # https://gerrit-review.googlesource.com/Documentation/user-upload.html
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002531 refspec_opts = []
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02002532
Aaron Gable844cf292017-06-28 11:32:59 -07002533 # By default, new changes are started in WIP mode, and subsequent patchsets
Thiago Perrottab0fb8d52022-08-30 21:26:19 +00002534 # don't send email. At any time, passing --send-mail or --send-email will
2535 # mark the change ready and send email for that particular patch.
Aaron Gableafd52772017-06-27 16:40:10 -07002536 if options.send_mail:
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002537 refspec_opts.append('ready')
2538 refspec_opts.append('notify=ALL')
Jamie Madill276da0b2018-04-27 14:41:20 -04002539 elif not self.GetIssue() and options.squash:
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002540 refspec_opts.append('wip')
Aaron Gableafd52772017-06-27 16:40:10 -07002541 else:
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002542 refspec_opts.append('notify=NONE')
Aaron Gable70f4e242017-06-26 10:45:59 -07002543
Thiago Perrottab0fb8d52022-08-30 21:26:19 +00002544 # TODO(tandrii): options.message should be posted as a comment if
2545 # --send-mail or --send-email is set on non-initial upload as Rietveld used
2546 # to do it.
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02002547
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002548 # Set options.title in case user was prompted in _GetTitleForUpload and
2549 # _CMDUploadChange needs to be called again.
2550 options.title = self._GetTitleForUpload(options)
2551 if options.title:
Nick Carter8692b182017-11-06 16:30:38 -08002552 # Punctuation and whitespace in |title| must be percent-encoded.
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002553 refspec_opts.append(
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002554 'm=' + gerrit_util.PercentEncodeForGitRef(options.title))
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00002555
agablec6787972016-09-09 16:13:34 -07002556 if options.private:
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002557 refspec_opts.append('private')
agablec6787972016-09-09 16:13:34 -07002558
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00002559 for r in sorted(reviewers):
2560 if r in valid_accounts:
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002561 refspec_opts.append('r=%s' % r)
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00002562 reviewers.remove(r)
2563 else:
2564 # TODO(tandrii): this should probably be a hard failure.
2565 print('WARNING: reviewer %s doesn\'t have a Gerrit account, skipping'
2566 % r)
2567 for c in sorted(cc):
2568 # refspec option will be rejected if cc doesn't correspond to an
2569 # account, even though REST call to add such arbitrary cc may succeed.
2570 if c in valid_accounts:
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002571 refspec_opts.append('cc=%s' % c)
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00002572 cc.remove(c)
2573
rmistry9eadede2016-09-19 11:22:43 -07002574 if options.topic:
2575 # Documentation on Gerrit topics is here:
2576 # https://gerrit-review.googlesource.com/Documentation/user-upload.html#topic
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002577 refspec_opts.append('topic=%s' % options.topic)
rmistry9eadede2016-09-19 11:22:43 -07002578
Edward Lemur687ca902018-12-05 02:30:30 +00002579 if options.enable_auto_submit:
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002580 refspec_opts.append('l=Auto-Submit+1')
Edward Lesmes10c3dd62021-02-08 21:13:57 +00002581 if options.set_bot_commit:
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002582 refspec_opts.append('l=Bot-Commit+1')
Edward Lemur687ca902018-12-05 02:30:30 +00002583 if options.use_commit_queue:
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002584 refspec_opts.append('l=Commit-Queue+2')
Edward Lemur687ca902018-12-05 02:30:30 +00002585 elif options.cq_dry_run:
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002586 refspec_opts.append('l=Commit-Queue+1')
Greg Gutermanbe5fccd2021-06-14 17:58:20 +00002587 elif options.cq_quick_run:
2588 refspec_opts.append('l=Commit-Queue+1')
2589 refspec_opts.append('l=Quick-Run+1')
Edward Lemur687ca902018-12-05 02:30:30 +00002590
2591 if change_desc.get_reviewers(tbr_only=True):
2592 score = gerrit_util.GetCodeReviewTbrScore(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00002593 self.GetGerritHost(),
2594 self.GetGerritProject())
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002595 refspec_opts.append('l=Code-Review+%s' % score)
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00002596
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08002597 # Gerrit sorts hashtags, so order is not important.
Nodir Turakulov23b82142017-11-16 11:04:25 -08002598 hashtags = {change_desc.sanitize_hash_tag(t) for t in options.hashtags}
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08002599 if not self.GetIssue():
Nodir Turakulov23b82142017-11-16 11:04:25 -08002600 hashtags.update(change_desc.get_hash_tags())
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002601 refspec_opts += ['hashtag=%s' % t for t in sorted(hashtags)]
2602
2603 refspec_suffix = ''
2604 if refspec_opts:
2605 refspec_suffix = '%' + ','.join(refspec_opts)
2606 assert ' ' not in refspec_suffix, (
2607 'spaces not allowed in refspec: "%s"' % refspec_suffix)
2608 refspec = '%s:refs/for/%s%s' % (ref_to_push, branch, refspec_suffix)
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00002609
Edward Lemur1b52d872019-05-09 21:12:12 +00002610 git_push_metadata = {
Edward Lesmeseeca9c62020-11-20 00:00:17 +00002611 'gerrit_host': self.GetGerritHost(),
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002612 'title': options.title or '<untitled>',
Edward Lemur1b52d872019-05-09 21:12:12 +00002613 'change_id': change_id,
2614 'description': change_desc.description,
2615 }
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +00002616
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002617 push_stdout = self._RunGitPushWithTraces(refspec, refspec_opts,
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +00002618 git_push_metadata,
2619 options.push_options)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002620
2621 if options.squash:
Aaron Gable289b4312017-09-13 14:06:16 -07002622 regex = re.compile(r'remote:\s+https?://[\w\-\.\+\/#]*/(\d+)\s.*')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002623 change_numbers = [m.group(1)
2624 for m in map(regex.match, push_stdout.splitlines())
2625 if m]
2626 if len(change_numbers) != 1:
2627 DieWithError(
2628 ('Created|Updated %d issues on Gerrit, but only 1 expected.\n'
Christopher Lamf732cd52017-01-24 12:40:11 +11002629 'Change-Id: %s') % (len(change_numbers), change_id), change_desc)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002630 self.SetIssue(change_numbers[0])
tandrii5d48c322016-08-18 16:19:37 -07002631 self._GitSetBranchConfigValue('gerritsquashhash', ref_to_push)
tandrii88189772016-09-29 04:29:57 -07002632
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00002633 if self.GetIssue() and (reviewers or cc):
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00002634 # GetIssue() is not set in case of non-squash uploads according to tests.
Aaron Gable6e7ddb62020-05-27 22:23:29 +00002635 # TODO(crbug.com/751901): non-squash uploads in git cl should be removed.
Thiago Perrottab0fb8d52022-08-30 21:26:19 +00002636 gerrit_util.AddReviewers(self.GetGerritHost(),
2637 self._GerritChangeIdentifier(),
2638 reviewers,
2639 cc,
2640 notify=bool(options.send_mail))
Aaron Gable6dadfbf2017-05-09 14:27:58 -07002641
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002642 return 0
2643
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002644 def _ComputeParent(self, remote, upstream_branch, custom_cl_base, force,
2645 change_desc):
2646 """Computes parent of the generated commit to be uploaded to Gerrit.
2647
2648 Returns revision or a ref name.
2649 """
2650 if custom_cl_base:
2651 # Try to avoid creating additional unintended CLs when uploading, unless
2652 # user wants to take this risk.
2653 local_ref_of_target_remote = self.GetRemoteBranch()[1]
2654 code, _ = RunGitWithCode(['merge-base', '--is-ancestor', custom_cl_base,
2655 local_ref_of_target_remote])
2656 if code == 1:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002657 print('\nWARNING: Manually specified base of this CL `%s` '
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002658 'doesn\'t seem to belong to target remote branch `%s`.\n\n'
2659 'If you proceed with upload, more than 1 CL may be created by '
2660 'Gerrit as a result, in turn confusing or crashing git cl.\n\n'
2661 'If you are certain that specified base `%s` has already been '
2662 'uploaded to Gerrit as another CL, you may proceed.\n' %
2663 (custom_cl_base, local_ref_of_target_remote, custom_cl_base))
2664 if not force:
2665 confirm_or_exit(
2666 'Do you take responsibility for cleaning up potential mess '
2667 'resulting from proceeding with upload?',
2668 action='upload')
2669 return custom_cl_base
2670
Aaron Gablef97e33d2017-03-30 15:44:27 -07002671 if remote != '.':
2672 return self.GetCommonAncestorWithUpstream()
2673
2674 # If our upstream branch is local, we base our squashed commit on its
2675 # squashed version.
2676 upstream_branch_name = scm.GIT.ShortBranchName(upstream_branch)
2677
Aaron Gablef97e33d2017-03-30 15:44:27 -07002678 if upstream_branch_name == 'master':
Aaron Gable0bbd1c22017-05-08 14:37:08 -07002679 return self.GetCommonAncestorWithUpstream()
Glen Robertson7d98e222020-08-27 17:53:11 +00002680 if upstream_branch_name == 'main':
2681 return self.GetCommonAncestorWithUpstream()
Aaron Gablef97e33d2017-03-30 15:44:27 -07002682
2683 # Check the squashed hash of the parent.
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002684 # TODO(tandrii): consider checking parent change in Gerrit and using its
2685 # hash if tree hash of latest parent revision (patchset) in Gerrit matches
2686 # the tree hash of the parent branch. The upside is less likely bogus
2687 # requests to reupload parent change just because it's uploadhash is
2688 # missing, yet the downside likely exists, too (albeit unknown to me yet).
Edward Lesmesa680c232020-03-31 18:26:44 +00002689 parent = scm.GIT.GetBranchConfig(
2690 settings.GetRoot(), upstream_branch_name, 'gerritsquashhash')
Aaron Gablef97e33d2017-03-30 15:44:27 -07002691 # Verify that the upstream branch has been uploaded too, otherwise
2692 # Gerrit will create additional CLs when uploading.
2693 if not parent or (RunGitSilent(['rev-parse', upstream_branch + ':']) !=
2694 RunGitSilent(['rev-parse', parent + ':'])):
2695 DieWithError(
2696 '\nUpload upstream branch %s first.\n'
2697 'It is likely that this branch has been rebased since its last '
2698 'upload, so you just need to upload it again.\n'
2699 '(If you uploaded it with --no-squash, then branch dependencies '
2700 'are not supported, and you should reupload with --squash.)'
2701 % upstream_branch_name,
2702 change_desc)
2703 return parent
2704
Edward Lemura12175c2020-03-09 16:58:26 +00002705 def _AddChangeIdToCommitMessage(self, log_desc, args):
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00002706 """Re-commits using the current message, assumes the commit hook is in
2707 place.
2708 """
Edward Lemura12175c2020-03-09 16:58:26 +00002709 RunGit(['commit', '--amend', '-m', log_desc])
Andrii Shyshkalovb07575f2018-10-16 06:16:21 +00002710 new_log_desc = _create_description_from_log(args)
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00002711 if git_footers.get_footer_change_id(new_log_desc):
vapiera7fbd5a2016-06-16 09:17:49 -07002712 print('git-cl: Added Change-Id to commit message.')
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00002713 return new_log_desc
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +00002714
2715 DieWithError('ERROR: Gerrit commit-msg hook not installed.')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002716
tandriie113dfd2016-10-11 10:20:12 -07002717 def CannotTriggerTryJobReason(self):
tandrii8c5a3532016-11-04 07:52:02 -07002718 try:
2719 data = self._GetChangeDetail()
Aaron Gablea45ee112016-11-22 15:14:38 -08002720 except GerritChangeNotExists:
2721 return 'Gerrit doesn\'t know about your change %s' % self.GetIssue()
tandrii8c5a3532016-11-04 07:52:02 -07002722
2723 if data['status'] in ('ABANDONED', 'MERGED'):
2724 return 'CL %s is closed' % self.GetIssue()
2725
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002726 def GetGerritChange(self, patchset=None):
2727 """Returns a buildbucket.v2.GerritChange message for the current issue."""
Edward Lemur79d4f992019-11-11 23:49:02 +00002728 host = urllib.parse.urlparse(self.GetCodereviewServer()).hostname
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002729 issue = self.GetIssue()
Edward Lemur2c210a42019-09-16 23:58:35 +00002730 patchset = int(patchset or self.GetPatchset())
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002731 data = self._GetChangeDetail(['ALL_REVISIONS'])
2732
2733 assert host and issue and patchset, 'CL must be uploaded first'
2734
2735 has_patchset = any(
2736 int(revision_data['_number']) == patchset
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00002737 for revision_data in data['revisions'].values())
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002738 if not has_patchset:
Aaron Gablea45ee112016-11-22 15:14:38 -08002739 raise Exception('Patchset %d is not known in Gerrit change %d' %
tandrii8c5a3532016-11-04 07:52:02 -07002740 (patchset, self.GetIssue()))
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002741
tandrii8c5a3532016-11-04 07:52:02 -07002742 return {
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002743 'host': host,
2744 'change': issue,
2745 'project': data['project'],
2746 'patchset': patchset,
tandrii8c5a3532016-11-04 07:52:02 -07002747 }
tandriie113dfd2016-10-11 10:20:12 -07002748
tandriide281ae2016-10-12 06:02:30 -07002749 def GetIssueOwner(self):
tandrii8c5a3532016-11-04 07:52:02 -07002750 return self._GetChangeDetail(['DETAILED_ACCOUNTS'])['owner']['email']
tandriide281ae2016-10-12 06:02:30 -07002751
Edward Lemur707d70b2018-02-07 00:50:14 +01002752 def GetReviewers(self):
2753 details = self._GetChangeDetail(['DETAILED_ACCOUNTS'])
Mohamed Heikal171c0742018-11-09 20:38:51 +00002754 return [r['email'] for r in details['reviewers'].get('REVIEWER', [])]
Edward Lemur707d70b2018-02-07 00:50:14 +01002755
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002756
Lei Zhang8a0efc12020-08-05 19:58:45 +00002757def _get_bug_line_values(default_project_prefix, bugs):
2758 """Given default_project_prefix and comma separated list of bugs, yields bug
2759 line values.
tandriif9aefb72016-07-01 09:06:51 -07002760
2761 Each bug can be either:
Lei Zhang8a0efc12020-08-05 19:58:45 +00002762 * a number, which is combined with default_project_prefix
tandriif9aefb72016-07-01 09:06:51 -07002763 * string, which is left as is.
2764
2765 This function may produce more than one line, because bugdroid expects one
2766 project per line.
2767
Lei Zhang8a0efc12020-08-05 19:58:45 +00002768 >>> list(_get_bug_line_values('v8:', '123,chromium:789'))
tandriif9aefb72016-07-01 09:06:51 -07002769 ['v8:123', 'chromium:789']
2770 """
2771 default_bugs = []
2772 others = []
2773 for bug in bugs.split(','):
2774 bug = bug.strip()
2775 if bug:
2776 try:
2777 default_bugs.append(int(bug))
2778 except ValueError:
2779 others.append(bug)
2780
2781 if default_bugs:
2782 default_bugs = ','.join(map(str, default_bugs))
Lei Zhang8a0efc12020-08-05 19:58:45 +00002783 if default_project_prefix:
2784 if not default_project_prefix.endswith(':'):
2785 default_project_prefix += ':'
2786 yield '%s%s' % (default_project_prefix, default_bugs)
tandriif9aefb72016-07-01 09:06:51 -07002787 else:
2788 yield default_bugs
2789 for other in sorted(others):
2790 # Don't bother finding common prefixes, CLs with >2 bugs are very very rare.
2791 yield other
2792
2793
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00002794class ChangeDescription(object):
2795 """Contains a parsed form of the change description."""
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00002796 R_LINE = r'^[ \t]*(TBR|R)[ \t]*=[ \t]*(.*?)[ \t]*$'
bradnelsond975b302016-10-23 12:20:23 -07002797 CC_LINE = r'^[ \t]*(CC)[ \t]*=[ \t]*(.*?)[ \t]*$'
Aaron Gable3a16ed12017-03-23 10:51:55 -07002798 BUG_LINE = r'^[ \t]*(?:(BUG)[ \t]*=|Bug:)[ \t]*(.*?)[ \t]*$'
Dan Beamd8b04ca2019-10-10 21:23:26 +00002799 FIXED_LINE = r'^[ \t]*Fixed[ \t]*:[ \t]*(.*?)[ \t]*$'
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01002800 CHERRY_PICK_LINE = r'^\(cherry picked from commit [a-fA-F0-9]{40}\)$'
Nodir Turakulov23b82142017-11-16 11:04:25 -08002801 STRIP_HASH_TAG_PREFIX = r'^(\s*(revert|reland)( "|:)?\s*)*'
2802 BRACKET_HASH_TAG = r'\s*\[([^\[\]]+)\]'
Anthony Polito02b5af32019-12-02 19:49:47 +00002803 COLON_SEPARATED_HASH_TAG = r'^([a-zA-Z0-9_\- ]+):($|[^:])'
Nodir Turakulov23b82142017-11-16 11:04:25 -08002804 BAD_HASH_TAG_CHUNK = r'[^a-zA-Z0-9]+'
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00002805
Dan Beamd8b04ca2019-10-10 21:23:26 +00002806 def __init__(self, description, bug=None, fixed=None):
agable@chromium.org42c20792013-09-12 17:34:49 +00002807 self._description_lines = (description or '').strip().splitlines()
Anthony Polito8b955342019-09-24 19:01:36 +00002808 if bug:
2809 regexp = re.compile(self.BUG_LINE)
2810 prefix = settings.GetBugPrefix()
2811 if not any((regexp.match(line) for line in self._description_lines)):
2812 values = list(_get_bug_line_values(prefix, bug))
2813 self.append_footer('Bug: %s' % ', '.join(values))
Dan Beamd8b04ca2019-10-10 21:23:26 +00002814 if fixed:
2815 regexp = re.compile(self.FIXED_LINE)
2816 prefix = settings.GetBugPrefix()
2817 if not any((regexp.match(line) for line in self._description_lines)):
2818 values = list(_get_bug_line_values(prefix, fixed))
2819 self.append_footer('Fixed: %s' % ', '.join(values))
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002820
agable@chromium.org42c20792013-09-12 17:34:49 +00002821 @property # www.logilab.org/ticket/89786
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08002822 def description(self): # pylint: disable=method-hidden
agable@chromium.org42c20792013-09-12 17:34:49 +00002823 return '\n'.join(self._description_lines)
2824
2825 def set_description(self, desc):
2826 if isinstance(desc, basestring):
2827 lines = desc.splitlines()
2828 else:
2829 lines = [line.rstrip() for line in desc]
2830 while lines and not lines[0]:
2831 lines.pop(0)
2832 while lines and not lines[-1]:
2833 lines.pop(-1)
2834 self._description_lines = lines
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002835
Edward Lemur5a644f82020-03-18 16:44:57 +00002836 def ensure_change_id(self, change_id):
2837 description = self.description
2838 footer_change_ids = git_footers.get_footer_change_id(description)
2839 # Make sure that the Change-Id in the description matches the given one.
2840 if footer_change_ids != [change_id]:
2841 if footer_change_ids:
2842 # Remove any existing Change-Id footers since they don't match the
2843 # expected change_id footer.
2844 description = git_footers.remove_footer(description, 'Change-Id')
2845 print('WARNING: Change-Id has been set to %s. Use `git cl issue 0` '
2846 'if you want to set a new one.')
2847 # Add the expected Change-Id footer.
2848 description = git_footers.add_footer_change_id(description, change_id)
2849 self.set_description(description)
2850
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00002851 def update_reviewers(self, reviewers, tbrs):
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002852 """Rewrites the R=/TBR= line(s) as a single line each.
2853
2854 Args:
2855 reviewers (list(str)) - list of additional emails to use for reviewers.
2856 tbrs (list(str)) - list of additional emails to use for TBRs.
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002857 """
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00002858 if not reviewers and not tbrs:
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002859 return
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002860
2861 reviewers = set(reviewers)
2862 tbrs = set(tbrs)
2863 LOOKUP = {
2864 'TBR': tbrs,
2865 'R': reviewers,
2866 }
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002867
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002868 # Get the set of R= and TBR= lines and remove them from the description.
agable@chromium.org42c20792013-09-12 17:34:49 +00002869 regexp = re.compile(self.R_LINE)
2870 matches = [regexp.match(line) for line in self._description_lines]
2871 new_desc = [l for i, l in enumerate(self._description_lines)
2872 if not matches[i]]
2873 self.set_description(new_desc)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002874
agable@chromium.org42c20792013-09-12 17:34:49 +00002875 # Construct new unified R= and TBR= lines.
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002876
2877 # First, update tbrs/reviewers with names from the R=/TBR= lines (if any).
agable@chromium.org42c20792013-09-12 17:34:49 +00002878 for match in matches:
2879 if not match:
2880 continue
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002881 LOOKUP[match.group(1)].update(cleanup_list([match.group(2).strip()]))
2882
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002883 # If any folks ended up in both groups, remove them from tbrs.
2884 tbrs -= reviewers
Robert Iannuccif2708bd2017-04-17 15:49:02 -07002885
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002886 new_r_line = 'R=' + ', '.join(sorted(reviewers)) if reviewers else None
2887 new_tbr_line = 'TBR=' + ', '.join(sorted(tbrs)) if tbrs else None
agable@chromium.org42c20792013-09-12 17:34:49 +00002888
2889 # Put the new lines in the description where the old first R= line was.
2890 line_loc = next((i for i, match in enumerate(matches) if match), -1)
2891 if 0 <= line_loc < len(self._description_lines):
2892 if new_tbr_line:
2893 self._description_lines.insert(line_loc, new_tbr_line)
2894 if new_r_line:
2895 self._description_lines.insert(line_loc, new_r_line)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002896 else:
agable@chromium.org42c20792013-09-12 17:34:49 +00002897 if new_r_line:
2898 self.append_footer(new_r_line)
2899 if new_tbr_line:
2900 self.append_footer(new_tbr_line)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002901
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +00002902 def set_preserve_tryjobs(self):
2903 """Ensures description footer contains 'Cq-Do-Not-Cancel-Tryjobs: true'."""
2904 footers = git_footers.parse_footers(self.description)
2905 for v in footers.get('Cq-Do-Not-Cancel-Tryjobs', []):
2906 if v.lower() == 'true':
2907 return
2908 self.append_footer('Cq-Do-Not-Cancel-Tryjobs: true')
2909
Anthony Polito8b955342019-09-24 19:01:36 +00002910 def prompt(self):
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002911 """Asks the user to update the description."""
agable@chromium.org42c20792013-09-12 17:34:49 +00002912 self.set_description([
2913 '# Enter a description of the change.',
2914 '# This will be displayed on the codereview site.',
2915 '# The first line will also be used as the subject of the review.',
alancutter@chromium.orgbd1073e2013-06-01 00:34:38 +00002916 '#--------------------This line is 72 characters long'
agable@chromium.org42c20792013-09-12 17:34:49 +00002917 '--------------------',
2918 ] + self._description_lines)
Dan Beamd8b04ca2019-10-10 21:23:26 +00002919 bug_regexp = re.compile(self.BUG_LINE)
2920 fixed_regexp = re.compile(self.FIXED_LINE)
Jonas Termansend0f79112019-03-22 15:28:26 +00002921 prefix = settings.GetBugPrefix()
Sigurd Schneider8630bb12020-11-11 14:02:49 +00002922 has_issue = lambda l: bug_regexp.match(l) or fixed_regexp.match(l)
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00002923
Dan Beamd8b04ca2019-10-10 21:23:26 +00002924 if not any((has_issue(line) for line in self._description_lines)):
Anthony Polito8b955342019-09-24 19:01:36 +00002925 self.append_footer('Bug: %s' % prefix)
tandriif9aefb72016-07-01 09:06:51 -07002926
Bruce Dawsonfc487042020-10-27 19:11:37 +00002927 print('Waiting for editor...')
agable@chromium.org42c20792013-09-12 17:34:49 +00002928 content = gclient_utils.RunEditor(self.description, True,
Edward Lemur79d4f992019-11-11 23:49:02 +00002929 git_editor=settings.GetGitEditor())
maruel@chromium.org0e0436a2011-10-25 13:32:41 +00002930 if not content:
2931 DieWithError('Running editor failed')
agable@chromium.org42c20792013-09-12 17:34:49 +00002932 lines = content.splitlines()
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002933
Bruce Dawson2377b012018-01-11 16:46:49 -08002934 # Strip off comments and default inserted "Bug:" line.
2935 clean_lines = [line.rstrip() for line in lines if not
Jonas Termansend0f79112019-03-22 15:28:26 +00002936 (line.startswith('#') or
2937 line.rstrip() == "Bug:" or
2938 line.rstrip() == "Bug: " + prefix)]
agable@chromium.org42c20792013-09-12 17:34:49 +00002939 if not clean_lines:
maruel@chromium.org0e0436a2011-10-25 13:32:41 +00002940 DieWithError('No CL description, aborting')
agable@chromium.org42c20792013-09-12 17:34:49 +00002941 self.set_description(clean_lines)
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00002942
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002943 def append_footer(self, line):
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002944 """Adds a footer line to the description.
2945
2946 Differentiates legacy "KEY=xxx" footers (used to be called tags) and
2947 Gerrit's footers in the form of "Footer-Key: footer any value" and ensures
2948 that Gerrit footers are always at the end.
2949 """
2950 parsed_footer_line = git_footers.parse_footer(line)
2951 if parsed_footer_line:
2952 # Line is a gerrit footer in the form: Footer-Key: any value.
2953 # Thus, must be appended observing Gerrit footer rules.
2954 self.set_description(
2955 git_footers.add_footer(self.description,
2956 key=parsed_footer_line[0],
2957 value=parsed_footer_line[1]))
2958 return
2959
2960 if not self._description_lines:
2961 self._description_lines.append(line)
2962 return
2963
2964 top_lines, gerrit_footers, _ = git_footers.split_footers(self.description)
2965 if gerrit_footers:
2966 # git_footers.split_footers ensures that there is an empty line before
2967 # actual (gerrit) footers, if any. We have to keep it that way.
2968 assert top_lines and top_lines[-1] == ''
2969 top_lines, separator = top_lines[:-1], top_lines[-1:]
2970 else:
2971 separator = [] # No need for separator if there are no gerrit_footers.
2972
2973 prev_line = top_lines[-1] if top_lines else ''
2974 if (not presubmit_support.Change.TAG_LINE_RE.match(prev_line) or
2975 not presubmit_support.Change.TAG_LINE_RE.match(line)):
2976 top_lines.append('')
2977 top_lines.append(line)
2978 self._description_lines = top_lines + separator + gerrit_footers
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00002979
tandrii99a72f22016-08-17 14:33:24 -07002980 def get_reviewers(self, tbr_only=False):
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002981 """Retrieves the list of reviewers."""
agable@chromium.org42c20792013-09-12 17:34:49 +00002982 matches = [re.match(self.R_LINE, line) for line in self._description_lines]
tandrii99a72f22016-08-17 14:33:24 -07002983 reviewers = [match.group(2).strip()
2984 for match in matches
2985 if match and (not tbr_only or match.group(1).upper() == 'TBR')]
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002986 return cleanup_list(reviewers)
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00002987
bradnelsond975b302016-10-23 12:20:23 -07002988 def get_cced(self):
2989 """Retrieves the list of reviewers."""
2990 matches = [re.match(self.CC_LINE, line) for line in self._description_lines]
2991 cced = [match.group(2).strip() for match in matches if match]
2992 return cleanup_list(cced)
2993
Nodir Turakulov23b82142017-11-16 11:04:25 -08002994 def get_hash_tags(self):
2995 """Extracts and sanitizes a list of Gerrit hashtags."""
2996 subject = (self._description_lines or ('',))[0]
2997 subject = re.sub(
2998 self.STRIP_HASH_TAG_PREFIX, '', subject, flags=re.IGNORECASE)
2999
3000 tags = []
3001 start = 0
3002 bracket_exp = re.compile(self.BRACKET_HASH_TAG)
3003 while True:
3004 m = bracket_exp.match(subject, start)
3005 if not m:
3006 break
3007 tags.append(self.sanitize_hash_tag(m.group(1)))
3008 start = m.end()
3009
3010 if not tags:
3011 # Try "Tag: " prefix.
3012 m = re.match(self.COLON_SEPARATED_HASH_TAG, subject)
3013 if m:
3014 tags.append(self.sanitize_hash_tag(m.group(1)))
3015 return tags
3016
3017 @classmethod
3018 def sanitize_hash_tag(cls, tag):
3019 """Returns a sanitized Gerrit hash tag.
3020
3021 A sanitized hashtag can be used as a git push refspec parameter value.
3022 """
3023 return re.sub(cls.BAD_HASH_TAG_CHUNK, '-', tag).strip('-').lower()
3024
maruel@chromium.orge52678e2013-04-26 18:34:44 +00003025
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003026def FindCodereviewSettingsFile(filename='codereview.settings'):
3027 """Finds the given file starting in the cwd and going up.
3028
3029 Only looks up to the top of the repository unless an
3030 'inherit-review-settings-ok' file exists in the root of the repository.
3031 """
3032 inherit_ok_file = 'inherit-review-settings-ok'
3033 cwd = os.getcwd()
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00003034 root = settings.GetRoot()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003035 if os.path.isfile(os.path.join(root, inherit_ok_file)):
Aleksey Khoroshilov2a229712022-06-02 16:24:11 +00003036 root = None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003037 while True:
Aleksey Khoroshilov2a229712022-06-02 16:24:11 +00003038 if os.path.isfile(os.path.join(cwd, filename)):
3039 return open(os.path.join(cwd, filename))
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003040 if cwd == root:
3041 break
Aleksey Khoroshilov2a229712022-06-02 16:24:11 +00003042 parent_dir = os.path.dirname(cwd)
3043 if parent_dir == cwd:
3044 # We hit the system root directory.
3045 break
3046 cwd = parent_dir
3047 return None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003048
3049
3050def LoadCodereviewSettingsFromFile(fileobj):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003051 """Parses a codereview.settings file and updates hooks."""
maruel@chromium.org99ac1c52012-01-16 14:52:12 +00003052 keyvals = gclient_utils.ParseCodereviewSettingsContent(fileobj.read())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003053
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003054 def SetProperty(name, setting, unset_error_ok=False):
3055 fullname = 'rietveld.' + name
3056 if setting in keyvals:
3057 RunGit(['config', fullname, keyvals[setting]])
3058 else:
3059 RunGit(['config', '--unset-all', fullname], error_ok=unset_error_ok)
3060
tandrii48df5812016-10-17 03:55:37 -07003061 if not keyvals.get('GERRIT_HOST', False):
3062 SetProperty('server', 'CODE_REVIEW_SERVER')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003063 # Only server setting is required. Other settings can be absent.
3064 # In that case, we ignore errors raised during option deletion attempt.
3065 SetProperty('cc', 'CC_LIST', unset_error_ok=True)
3066 SetProperty('tree-status-url', 'STATUS', unset_error_ok=True)
3067 SetProperty('viewvc-url', 'VIEW_VC', unset_error_ok=True)
rmistry@google.com90752582014-01-14 21:04:50 +00003068 SetProperty('bug-prefix', 'BUG_PREFIX', unset_error_ok=True)
thestig@chromium.org44202a22014-03-11 19:22:18 +00003069 SetProperty('cpplint-regex', 'LINT_REGEX', unset_error_ok=True)
3070 SetProperty('cpplint-ignore-regex', 'LINT_IGNORE_REGEX', unset_error_ok=True)
rmistry@google.com5626a922015-02-26 14:03:30 +00003071 SetProperty('run-post-upload-hook', 'RUN_POST_UPLOAD_HOOK',
3072 unset_error_ok=True)
Jamie Madilldc4d19e2019-10-24 21:50:02 +00003073 SetProperty(
3074 'format-full-by-default', 'FORMAT_FULL_BY_DEFAULT', unset_error_ok=True)
Dirk Pranke6f0df682021-06-25 00:42:33 +00003075 SetProperty('use-python3', 'USE_PYTHON3', unset_error_ok=True)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003076
ukai@chromium.org7044efc2013-11-28 01:51:21 +00003077 if 'GERRIT_HOST' in keyvals:
ukai@chromium.orge8077812012-02-03 03:41:46 +00003078 RunGit(['config', 'gerrit.host', keyvals['GERRIT_HOST']])
ukai@chromium.orge8077812012-02-03 03:41:46 +00003079
bauerb@chromium.org54b400c2016-01-14 10:08:25 +00003080 if 'GERRIT_SQUASH_UPLOADS' in keyvals:
Edward Lesmes4de54132020-05-05 19:41:33 +00003081 RunGit(['config', 'gerrit.squash-uploads',
3082 keyvals['GERRIT_SQUASH_UPLOADS']])
bauerb@chromium.org54b400c2016-01-14 10:08:25 +00003083
tandrii@chromium.org28253532016-04-14 13:46:56 +00003084 if 'GERRIT_SKIP_ENSURE_AUTHENTICATED' in keyvals:
shinyak@chromium.org00dbccd2016-04-15 07:24:43 +00003085 RunGit(['config', 'gerrit.skip-ensure-authenticated',
tandrii@chromium.org28253532016-04-14 13:46:56 +00003086 keyvals['GERRIT_SKIP_ENSURE_AUTHENTICATED']])
3087
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003088 if 'PUSH_URL_CONFIG' in keyvals and 'ORIGIN_URL_CONFIG' in keyvals:
Andrii Shyshkalov18975322017-01-25 16:44:13 +01003089 # should be of the form
3090 # PUSH_URL_CONFIG: url.ssh://gitrw.chromium.org.pushinsteadof
3091 # ORIGIN_URL_CONFIG: http://src.chromium.org/git
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003092 RunGit(['config', keyvals['PUSH_URL_CONFIG'],
3093 keyvals['ORIGIN_URL_CONFIG']])
3094
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003095
joshua.lock@intel.com426f69b2012-08-02 23:41:49 +00003096def urlretrieve(source, destination):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003097 """Downloads a network object to a local file, like urllib.urlretrieve.
3098
3099 This is necessary because urllib is broken for SSL connections via a proxy.
3100 """
Vadim Shtayuraf7b8f8f2021-11-15 19:10:05 +00003101 with open(destination, 'wb') as f:
Edward Lemur79d4f992019-11-11 23:49:02 +00003102 f.write(urllib.request.urlopen(source).read())
joshua.lock@intel.com426f69b2012-08-02 23:41:49 +00003103
3104
ukai@chromium.org712d6102013-11-27 00:52:58 +00003105def hasSheBang(fname):
3106 """Checks fname is a #! script."""
3107 with open(fname) as f:
3108 return f.read(2).startswith('#!')
3109
3110
tandrii@chromium.org18630d62016-03-04 12:06:02 +00003111def DownloadGerritHook(force):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003112 """Downloads and installs a Gerrit commit-msg hook.
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003113
3114 Args:
3115 force: True to update hooks. False to install hooks if not present.
3116 """
ukai@chromium.org712d6102013-11-27 00:52:58 +00003117 src = 'https://gerrit-review.googlesource.com/tools/hooks/commit-msg'
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003118 dst = os.path.join(settings.GetRoot(), '.git', 'hooks', 'commit-msg')
3119 if not os.access(dst, os.X_OK):
3120 if os.path.exists(dst):
3121 if not force:
3122 return
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003123 try:
joshua.lock@intel.com426f69b2012-08-02 23:41:49 +00003124 urlretrieve(src, dst)
ukai@chromium.org712d6102013-11-27 00:52:58 +00003125 if not hasSheBang(dst):
3126 DieWithError('Not a script: %s\n'
3127 'You need to download from\n%s\n'
3128 'into .git/hooks/commit-msg and '
3129 'chmod +x .git/hooks/commit-msg' % (dst, src))
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003130 os.chmod(dst, stat.S_IRUSR | stat.S_IWUSR | stat.S_IXUSR)
3131 except Exception:
3132 if os.path.exists(dst):
3133 os.remove(dst)
ukai@chromium.org712d6102013-11-27 00:52:58 +00003134 DieWithError('\nFailed to download hooks.\n'
3135 'You need to download from\n%s\n'
3136 'into .git/hooks/commit-msg and '
3137 'chmod +x .git/hooks/commit-msg' % src)
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003138
3139
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003140class _GitCookiesChecker(object):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003141 """Provides facilities for validating and suggesting fixes to .gitcookies."""
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003142
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003143 def __init__(self):
3144 # Cached list of [host, identity, source], where source is either
3145 # .gitcookies or .netrc.
3146 self._all_hosts = None
3147
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003148 def ensure_configured_gitcookies(self):
3149 """Runs checks and suggests fixes to make git use .gitcookies from default
3150 path."""
3151 default = gerrit_util.CookiesAuthenticator.get_gitcookies_path()
3152 configured_path = RunGitSilent(
3153 ['config', '--global', 'http.cookiefile']).strip()
Andrii Shyshkalov1e250cd2017-05-10 15:39:31 +02003154 configured_path = os.path.expanduser(configured_path)
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003155 if configured_path:
3156 self._ensure_default_gitcookies_path(configured_path, default)
3157 else:
3158 self._configure_gitcookies_path(default)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003159
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003160 @staticmethod
3161 def _ensure_default_gitcookies_path(configured_path, default_path):
3162 assert configured_path
3163 if configured_path == default_path:
3164 print('git is already configured to use your .gitcookies from %s' %
3165 configured_path)
3166 return
3167
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003168 print('WARNING: You have configured custom path to .gitcookies: %s\n'
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003169 'Gerrit and other depot_tools expect .gitcookies at %s\n' %
3170 (configured_path, default_path))
3171
3172 if not os.path.exists(configured_path):
3173 print('However, your configured .gitcookies file is missing.')
3174 confirm_or_exit('Reconfigure git to use default .gitcookies?',
3175 action='reconfigure')
3176 RunGit(['config', '--global', 'http.cookiefile', default_path])
3177 return
3178
3179 if os.path.exists(default_path):
3180 print('WARNING: default .gitcookies file already exists %s' %
3181 default_path)
3182 DieWithError('Please delete %s manually and re-run git cl creds-check' %
3183 default_path)
3184
3185 confirm_or_exit('Move existing .gitcookies to default location?',
3186 action='move')
3187 shutil.move(configured_path, default_path)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003188 RunGit(['config', '--global', 'http.cookiefile', default_path])
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003189 print('Moved and reconfigured git to use .gitcookies from %s' %
3190 default_path)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003191
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003192 @staticmethod
3193 def _configure_gitcookies_path(default_path):
3194 netrc_path = gerrit_util.CookiesAuthenticator.get_netrc_path()
3195 if os.path.exists(netrc_path):
3196 print('You seem to be using outdated .netrc for git credentials: %s' %
3197 netrc_path)
3198 print('This tool will guide you through setting up recommended '
3199 '.gitcookies store for git credentials.\n'
3200 '\n'
3201 'IMPORTANT: If something goes wrong and you decide to go back, do:\n'
3202 ' git config --global --unset http.cookiefile\n'
3203 ' mv %s %s.backup\n\n' % (default_path, default_path))
3204 confirm_or_exit(action='setup .gitcookies')
3205 RunGit(['config', '--global', 'http.cookiefile', default_path])
3206 print('Configured git to use .gitcookies from %s' % default_path)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003207
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003208 def get_hosts_with_creds(self, include_netrc=False):
3209 if self._all_hosts is None:
3210 a = gerrit_util.CookiesAuthenticator()
Garrett Beaty08bb5c42022-09-21 17:34:20 +00003211 self._all_hosts = [(h, u, s) for h, u, s in itertools.chain((
3212 (h, u, '.netrc') for h, (u, _, _) in a.netrc.hosts.items()), (
3213 (h, u, '.gitcookies') for h, (u, _) in a.gitcookies.items()))
3214 if h.endswith(_GOOGLESOURCE)]
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003215
3216 if include_netrc:
3217 return self._all_hosts
3218 return [(h, u, s) for h, u, s in self._all_hosts if s != '.netrc']
3219
3220 def print_current_creds(self, include_netrc=False):
3221 hosts = sorted(self.get_hosts_with_creds(include_netrc=include_netrc))
3222 if not hosts:
3223 print('No Git/Gerrit credentials found')
3224 return
Edward Lemur79d4f992019-11-11 23:49:02 +00003225 lengths = [max(map(len, (row[i] for row in hosts))) for i in range(3)]
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003226 header = [('Host', 'User', 'Which file'),
3227 ['=' * l for l in lengths]]
3228 for row in (header + hosts):
3229 print('\t'.join((('%%+%ds' % l) % s)
3230 for l, s in zip(lengths, row)))
3231
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003232 @staticmethod
3233 def _parse_identity(identity):
Lei Zhangd3f769a2017-12-15 15:16:14 -08003234 """Parses identity "git-<username>.domain" into <username> and domain."""
3235 # Special case: usernames that contain ".", which are generally not
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +02003236 # distinguishable from sub-domains. But we do know typical domains:
3237 if identity.endswith('.chromium.org'):
3238 domain = 'chromium.org'
3239 username = identity[:-len('.chromium.org')]
3240 else:
3241 username, domain = identity.split('.', 1)
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003242 if username.startswith('git-'):
3243 username = username[len('git-'):]
3244 return username, domain
3245
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003246 def has_generic_host(self):
3247 """Returns whether generic .googlesource.com has been configured.
3248
3249 Chrome Infra recommends to use explicit ${host}.googlesource.com instead.
3250 """
3251 for host, _, _ in self.get_hosts_with_creds(include_netrc=False):
Garrett Beaty08bb5c42022-09-21 17:34:20 +00003252 if host == '.' + _GOOGLESOURCE:
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003253 return True
3254 return False
3255
3256 def _get_git_gerrit_identity_pairs(self):
3257 """Returns map from canonic host to pair of identities (Git, Gerrit).
3258
3259 One of identities might be None, meaning not configured.
3260 """
3261 host_to_identity_pairs = {}
3262 for host, identity, _ in self.get_hosts_with_creds():
Garrett Beaty08bb5c42022-09-21 17:34:20 +00003263 canonical = _canonical_git_googlesource_host(host)
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003264 pair = host_to_identity_pairs.setdefault(canonical, [None, None])
3265 idx = 0 if canonical == host else 1
3266 pair[idx] = identity
3267 return host_to_identity_pairs
3268
3269 def get_partially_configured_hosts(self):
3270 return set(
Garrett Beaty08bb5c42022-09-21 17:34:20 +00003271 (host if i1 else _canonical_gerrit_googlesource_host(host))
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00003272 for host, (i1, i2) in self._get_git_gerrit_identity_pairs().items()
Garrett Beaty08bb5c42022-09-21 17:34:20 +00003273 if None in (i1, i2) and host != '.' + _GOOGLESOURCE)
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003274
3275 def get_conflicting_hosts(self):
3276 return set(
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003277 host
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00003278 for host, (i1, i2) in self._get_git_gerrit_identity_pairs().items()
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003279 if None not in (i1, i2) and i1 != i2)
3280
3281 def get_duplicated_hosts(self):
3282 counters = collections.Counter(h for h, _, _ in self.get_hosts_with_creds())
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00003283 return set(host for host, count in counters.items() if count > 1)
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003284
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003285
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003286 @staticmethod
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003287 def _format_hosts(hosts, extra_column_func=None):
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003288 hosts = sorted(hosts)
3289 assert hosts
3290 if extra_column_func is None:
3291 extras = [''] * len(hosts)
3292 else:
3293 extras = [extra_column_func(host) for host in hosts]
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003294 tmpl = '%%-%ds %%-%ds' % (max(map(len, hosts)), max(map(len, extras)))
3295 lines = []
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003296 for he in zip(hosts, extras):
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003297 lines.append(tmpl % he)
3298 return lines
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003299
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003300 def _find_problems(self):
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003301 if self.has_generic_host():
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003302 yield ('.googlesource.com wildcard record detected',
3303 ['Chrome Infrastructure team recommends to list full host names '
3304 'explicitly.'],
3305 None)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003306
3307 dups = self.get_duplicated_hosts()
3308 if dups:
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003309 yield ('The following hosts were defined twice',
3310 self._format_hosts(dups),
3311 None)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003312
3313 partial = self.get_partially_configured_hosts()
3314 if partial:
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003315 yield ('Credentials should come in pairs for Git and Gerrit hosts. '
3316 'These hosts are missing',
Garrett Beaty08bb5c42022-09-21 17:34:20 +00003317 self._format_hosts(
3318 partial, lambda host: 'but %s defined' % _get_counterpart_host(
3319 host)), partial)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003320
3321 conflicting = self.get_conflicting_hosts()
3322 if conflicting:
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003323 yield ('The following Git hosts have differing credentials from their '
3324 'Gerrit counterparts',
3325 self._format_hosts(conflicting, lambda host: '%s vs %s' %
3326 tuple(self._get_git_gerrit_identity_pairs()[host])),
3327 conflicting)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003328
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003329 def find_and_report_problems(self):
3330 """Returns True if there was at least one problem, else False."""
3331 found = False
3332 bad_hosts = set()
3333 for title, sublines, hosts in self._find_problems():
3334 if not found:
3335 found = True
3336 print('\n\n.gitcookies problem report:\n')
3337 bad_hosts.update(hosts or [])
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003338 print(' %s%s' % (title, (':' if sublines else '')))
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003339 if sublines:
3340 print()
3341 print(' %s' % '\n '.join(sublines))
3342 print()
3343
3344 if bad_hosts:
3345 assert found
3346 print(' You can manually remove corresponding lines in your %s file and '
3347 'visit the following URLs with correct account to generate '
3348 'correct credential lines:\n' %
3349 gerrit_util.CookiesAuthenticator.get_gitcookies_path())
Garrett Beaty08bb5c42022-09-21 17:34:20 +00003350 print(' %s' % '\n '.join(
3351 sorted(
3352 set(gerrit_util.CookiesAuthenticator().get_new_password_url(
3353 _canonical_git_googlesource_host(host))
3354 for host in bad_hosts))))
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003355 return found
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003356
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003357
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003358@metrics.collector.collect_metrics('git cl creds-check')
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003359def CMDcreds_check(parser, args):
3360 """Checks credentials and suggests changes."""
3361 _, _ = parser.parse_args(args)
3362
Vadim Shtayurab250ec12018-10-04 00:21:08 +00003363 # Code below checks .gitcookies. Abort if using something else.
3364 authn = gerrit_util.Authenticator.get()
3365 if not isinstance(authn, gerrit_util.CookiesAuthenticator):
Edward Lemur57d47422020-03-06 20:43:07 +00003366 message = (
Vadim Shtayurab250ec12018-10-04 00:21:08 +00003367 'This command is not designed for bot environment. It checks '
3368 '~/.gitcookies file not generally used on bots.')
Edward Lemur57d47422020-03-06 20:43:07 +00003369 # TODO(crbug.com/1059384): Automatically detect when running on cloudtop.
3370 if isinstance(authn, gerrit_util.GceAuthenticator):
3371 message += (
3372 '\n'
3373 'If you need to run this on GCE or a cloudtop instance, '
3374 'export SKIP_GCE_AUTH_FOR_GIT=1 in your env.')
3375 DieWithError(message)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003376
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003377 checker = _GitCookiesChecker()
3378 checker.ensure_configured_gitcookies()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003379
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003380 print('Your .netrc and .gitcookies have credentials for these hosts:')
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003381 checker.print_current_creds(include_netrc=True)
3382
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003383 if not checker.find_and_report_problems():
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003384 print('\nNo problems detected in your .gitcookies file.')
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003385 return 0
3386 return 1
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003387
3388
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003389@metrics.collector.collect_metrics('git cl baseurl')
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00003390def CMDbaseurl(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003391 """Gets or sets base-url for this branch."""
Thiago Perrotta16d08f02022-07-20 18:18:50 +00003392 _, args = parser.parse_args(args)
Edward Lesmes50da7702020-03-30 19:23:43 +00003393 branchref = scm.GIT.GetBranchRef(settings.GetRoot())
Edward Lemur85153282020-02-14 22:06:29 +00003394 branch = scm.GIT.ShortBranchName(branchref)
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00003395 if not args:
vapiera7fbd5a2016-06-16 09:17:49 -07003396 print('Current base-url:')
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00003397 return RunGit(['config', 'branch.%s.base-url' % branch],
3398 error_ok=False).strip()
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +00003399
3400 print('Setting base-url to %s' % args[0])
3401 return RunGit(['config', 'branch.%s.base-url' % branch, args[0]],
3402 error_ok=False).strip()
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00003403
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003404
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00003405def color_for_status(status):
3406 """Maps a Changelist status to color, for CMDstatus and other tools."""
Bruce Dawsonb73f8a92020-03-27 22:03:08 +00003407 BOLD = '\033[1m'
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00003408 return {
Bruce Dawsonb73f8a92020-03-27 22:03:08 +00003409 'unsent': BOLD + Fore.YELLOW,
3410 'waiting': BOLD + Fore.RED,
3411 'reply': BOLD + Fore.YELLOW,
3412 'not lgtm': BOLD + Fore.RED,
3413 'lgtm': BOLD + Fore.GREEN,
3414 'commit': BOLD + Fore.MAGENTA,
3415 'closed': BOLD + Fore.CYAN,
3416 'error': BOLD + Fore.WHITE,
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00003417 }.get(status, Fore.WHITE)
3418
tandrii@chromium.org04ea8462016-04-25 19:51:21 +00003419
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003420def get_cl_statuses(changes, fine_grained, max_processes=None):
3421 """Returns a blocking iterable of (cl, status) for given branches.
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003422
3423 If fine_grained is true, this will fetch CL statuses from the server.
3424 Otherwise, simply indicate if there's a matching url for the given branches.
3425
3426 If max_processes is specified, it is used as the maximum number of processes
3427 to spawn to fetch CL status from the server. Otherwise 1 process per branch is
3428 spawned.
calamity@chromium.orgcf197482016-04-29 20:15:53 +00003429
3430 See GetStatus() for a list of possible statuses.
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003431 """
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003432 if not changes:
Edward Lemur61bf4172020-02-24 23:22:37 +00003433 return
calamity@chromium.orgcf197482016-04-29 20:15:53 +00003434
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003435 if not fine_grained:
3436 # Fast path which doesn't involve querying codereview servers.
Aaron Gablea1bab272017-04-11 16:38:18 -07003437 # Do not use get_approving_reviewers(), since it requires an HTTP request.
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003438 for cl in changes:
3439 yield (cl, 'waiting' if cl.GetIssueURL() else 'error')
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003440 return
3441
3442 # First, sort out authentication issues.
3443 logging.debug('ensuring credentials exist')
3444 for cl in changes:
3445 cl.EnsureAuthenticated(force=False, refresh=True)
3446
3447 def fetch(cl):
3448 try:
3449 return (cl, cl.GetStatus())
3450 except:
3451 # See http://crbug.com/629863.
Andrii Shyshkalov98824232018-04-19 11:37:15 -07003452 logging.exception('failed to fetch status for cl %s:', cl.GetIssue())
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003453 raise
3454
3455 threads_count = len(changes)
3456 if max_processes:
3457 threads_count = max(1, min(threads_count, max_processes))
3458 logging.debug('querying %d CLs using %d threads', len(changes), threads_count)
3459
Edward Lemur61bf4172020-02-24 23:22:37 +00003460 pool = multiprocessing.pool.ThreadPool(threads_count)
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003461 fetched_cls = set()
3462 try:
3463 it = pool.imap_unordered(fetch, changes).__iter__()
3464 while True:
3465 try:
3466 cl, status = it.next(timeout=5)
Edward Lemur61bf4172020-02-24 23:22:37 +00003467 except (multiprocessing.TimeoutError, StopIteration):
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003468 break
3469 fetched_cls.add(cl)
3470 yield cl, status
3471 finally:
3472 pool.close()
3473
3474 # Add any branches that failed to fetch.
3475 for cl in set(changes) - fetched_cls:
3476 yield (cl, 'error')
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00003477
rmistry@google.com2dd99862015-06-22 12:22:18 +00003478
Jose Lopes3863fc52020-04-07 17:00:25 +00003479def upload_branch_deps(cl, args, force=False):
rmistry@google.com2dd99862015-06-22 12:22:18 +00003480 """Uploads CLs of local branches that are dependents of the current branch.
3481
3482 If the local branch dependency tree looks like:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003483
3484 test1 -> test2.1 -> test3.1
3485 -> test3.2
3486 -> test2.2 -> test3.3
rmistry@google.com2dd99862015-06-22 12:22:18 +00003487
3488 and you run "git cl upload --dependencies" from test1 then "git cl upload" is
3489 run on the dependent branches in this order:
3490 test2.1, test3.1, test3.2, test2.2, test3.3
3491
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003492 Note: This function does not rebase your local dependent branches. Use it
3493 when you make a change to the parent branch that will not conflict
3494 with its dependent branches, and you would like their dependencies
3495 updated in Rietveld.
rmistry@google.com2dd99862015-06-22 12:22:18 +00003496 """
3497 if git_common.is_dirty_git_tree('upload-branch-deps'):
3498 return 1
3499
3500 root_branch = cl.GetBranch()
3501 if root_branch is None:
3502 DieWithError('Can\'t find dependent branches from detached HEAD state. '
3503 'Get on a branch!')
Andrii Shyshkalov9f274432018-10-15 16:40:23 +00003504 if not cl.GetIssue():
rmistry@google.com2dd99862015-06-22 12:22:18 +00003505 DieWithError('Current branch does not have an uploaded CL. We cannot set '
3506 'patchset dependencies without an uploaded CL.')
3507
3508 branches = RunGit(['for-each-ref',
3509 '--format=%(refname:short) %(upstream:short)',
3510 'refs/heads'])
3511 if not branches:
3512 print('No local branches found.')
3513 return 0
3514
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003515 # Create a dictionary of all local branches to the branches that are
3516 # dependent on it.
rmistry@google.com2dd99862015-06-22 12:22:18 +00003517 tracked_to_dependents = collections.defaultdict(list)
3518 for b in branches.splitlines():
3519 tokens = b.split()
3520 if len(tokens) == 2:
3521 branch_name, tracked = tokens
3522 tracked_to_dependents[tracked].append(branch_name)
3523
vapiera7fbd5a2016-06-16 09:17:49 -07003524 print()
3525 print('The dependent local branches of %s are:' % root_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00003526 dependents = []
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003527
rmistry@google.com2dd99862015-06-22 12:22:18 +00003528 def traverse_dependents_preorder(branch, padding=''):
3529 dependents_to_process = tracked_to_dependents.get(branch, [])
3530 padding += ' '
3531 for dependent in dependents_to_process:
vapiera7fbd5a2016-06-16 09:17:49 -07003532 print('%s%s' % (padding, dependent))
rmistry@google.com2dd99862015-06-22 12:22:18 +00003533 dependents.append(dependent)
3534 traverse_dependents_preorder(dependent, padding)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003535
rmistry@google.com2dd99862015-06-22 12:22:18 +00003536 traverse_dependents_preorder(root_branch)
vapiera7fbd5a2016-06-16 09:17:49 -07003537 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00003538
3539 if not dependents:
vapiera7fbd5a2016-06-16 09:17:49 -07003540 print('There are no dependent local branches for %s' % root_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00003541 return 0
3542
Jose Lopes3863fc52020-04-07 17:00:25 +00003543 if not force:
3544 confirm_or_exit('This command will checkout all dependent branches and run '
3545 '"git cl upload".', action='continue')
rmistry@google.com2dd99862015-06-22 12:22:18 +00003546
rmistry@google.com2dd99862015-06-22 12:22:18 +00003547 # Record all dependents that failed to upload.
3548 failures = {}
3549 # Go through all dependents, checkout the branch and upload.
3550 try:
3551 for dependent_branch in dependents:
vapiera7fbd5a2016-06-16 09:17:49 -07003552 print()
3553 print('--------------------------------------')
3554 print('Running "git cl upload" from %s:' % dependent_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00003555 RunGit(['checkout', '-q', dependent_branch])
vapiera7fbd5a2016-06-16 09:17:49 -07003556 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00003557 try:
3558 if CMDupload(OptionParser(), args) != 0:
vapiera7fbd5a2016-06-16 09:17:49 -07003559 print('Upload failed for %s!' % dependent_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00003560 failures[dependent_branch] = 1
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08003561 except: # pylint: disable=bare-except
rmistry@google.com2dd99862015-06-22 12:22:18 +00003562 failures[dependent_branch] = 1
vapiera7fbd5a2016-06-16 09:17:49 -07003563 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00003564 finally:
3565 # Swap back to the original root branch.
3566 RunGit(['checkout', '-q', root_branch])
3567
vapiera7fbd5a2016-06-16 09:17:49 -07003568 print()
3569 print('Upload complete for dependent branches!')
rmistry@google.com2dd99862015-06-22 12:22:18 +00003570 for dependent_branch in dependents:
3571 upload_status = 'failed' if failures.get(dependent_branch) else 'succeeded'
vapiera7fbd5a2016-06-16 09:17:49 -07003572 print(' %s : %s' % (dependent_branch, upload_status))
3573 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00003574
3575 return 0
3576
3577
Tibor Goldschwendt7c5efb22020-03-25 01:23:54 +00003578def GetArchiveTagForBranch(issue_num, branch_name, existing_tags, pattern):
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00003579 """Given a proposed tag name, returns a tag name that is guaranteed to be
3580 unique. If 'foo' is proposed but already exists, then 'foo-2' is used,
3581 or 'foo-3', and so on."""
3582
Tibor Goldschwendt7c5efb22020-03-25 01:23:54 +00003583 proposed_tag = pattern.format(**{'issue': issue_num, 'branch': branch_name})
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00003584 for suffix_num in itertools.count(1):
3585 if suffix_num == 1:
3586 to_check = proposed_tag
3587 else:
3588 to_check = '%s-%d' % (proposed_tag, suffix_num)
3589
3590 if to_check not in existing_tags:
3591 return to_check
3592
3593
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003594@metrics.collector.collect_metrics('git cl archive')
kmarshall3bff56b2016-06-06 18:31:47 -07003595def CMDarchive(parser, args):
3596 """Archives and deletes branches associated with closed changelists."""
3597 parser.add_option(
3598 '-j', '--maxjobs', action='store', type=int,
kmarshall9249e012016-08-23 12:02:16 -07003599 help='The maximum number of jobs to use when retrieving review status.')
kmarshall3bff56b2016-06-06 18:31:47 -07003600 parser.add_option(
3601 '-f', '--force', action='store_true',
3602 help='Bypasses the confirmation prompt.')
kmarshall9249e012016-08-23 12:02:16 -07003603 parser.add_option(
3604 '-d', '--dry-run', action='store_true',
3605 help='Skip the branch tagging and removal steps.')
3606 parser.add_option(
3607 '-t', '--notags', action='store_true',
3608 help='Do not tag archived branches. '
3609 'Note: local commit history may be lost.')
Tibor Goldschwendt7c5efb22020-03-25 01:23:54 +00003610 parser.add_option(
3611 '-p',
3612 '--pattern',
3613 default='git-cl-archived-{issue}-{branch}',
3614 help='Format string for archive tags. '
3615 'E.g. \'archived-{issue}-{branch}\'.')
kmarshall3bff56b2016-06-06 18:31:47 -07003616
kmarshall3bff56b2016-06-06 18:31:47 -07003617 options, args = parser.parse_args(args)
3618 if args:
3619 parser.error('Unsupported args: %s' % ' '.join(args))
kmarshall3bff56b2016-06-06 18:31:47 -07003620
3621 branches = RunGit(['for-each-ref', '--format=%(refname)', 'refs/heads'])
3622 if not branches:
3623 return 0
3624
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00003625 tags = RunGit(['for-each-ref', '--format=%(refname)',
3626 'refs/tags']).splitlines() or []
3627 tags = [t.split('/')[-1] for t in tags]
3628
vapiera7fbd5a2016-06-16 09:17:49 -07003629 print('Finding all branches associated with closed issues...')
Edward Lemur934836a2019-09-09 20:16:54 +00003630 changes = [Changelist(branchref=b)
3631 for b in branches.splitlines()]
kmarshall3bff56b2016-06-06 18:31:47 -07003632 alignment = max(5, max(len(c.GetBranch()) for c in changes))
3633 statuses = get_cl_statuses(changes,
3634 fine_grained=True,
3635 max_processes=options.maxjobs)
3636 proposal = [(cl.GetBranch(),
Tibor Goldschwendt7c5efb22020-03-25 01:23:54 +00003637 GetArchiveTagForBranch(cl.GetIssue(), cl.GetBranch(), tags,
3638 options.pattern))
kmarshall3bff56b2016-06-06 18:31:47 -07003639 for cl, status in statuses
Andrii Shyshkalov51bdf8c2018-10-18 01:07:58 +00003640 if status in ('closed', 'rietveld-not-supported')]
kmarshall3bff56b2016-06-06 18:31:47 -07003641 proposal.sort()
3642
3643 if not proposal:
vapiera7fbd5a2016-06-16 09:17:49 -07003644 print('No branches with closed codereview issues found.')
kmarshall3bff56b2016-06-06 18:31:47 -07003645 return 0
3646
Edward Lemur85153282020-02-14 22:06:29 +00003647 current_branch = scm.GIT.GetBranch(settings.GetRoot())
kmarshall3bff56b2016-06-06 18:31:47 -07003648
vapiera7fbd5a2016-06-16 09:17:49 -07003649 print('\nBranches with closed issues that will be archived:\n')
kmarshall9249e012016-08-23 12:02:16 -07003650 if options.notags:
3651 for next_item in proposal:
3652 print(' ' + next_item[0])
3653 else:
3654 print('%*s | %s' % (alignment, 'Branch name', 'Archival tag name'))
3655 for next_item in proposal:
3656 print('%*s %s' % (alignment, next_item[0], next_item[1]))
kmarshall3bff56b2016-06-06 18:31:47 -07003657
kmarshall9249e012016-08-23 12:02:16 -07003658 # Quit now on precondition failure or if instructed by the user, either
3659 # via an interactive prompt or by command line flags.
3660 if options.dry_run:
3661 print('\nNo changes were made (dry run).\n')
3662 return 0
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +00003663
3664 if any(branch == current_branch for branch, _ in proposal):
kmarshall3bff56b2016-06-06 18:31:47 -07003665 print('You are currently on a branch \'%s\' which is associated with a '
3666 'closed codereview issue, so archive cannot proceed. Please '
3667 'checkout another branch and run this command again.' %
3668 current_branch)
3669 return 1
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +00003670
3671 if not options.force:
Edward Lesmesae3586b2020-03-23 21:21:14 +00003672 answer = gclient_utils.AskForData('\nProceed with deletion (Y/n)? ').lower()
sergiyb4a5ecbe2016-06-20 09:46:00 -07003673 if answer not in ('y', ''):
vapiera7fbd5a2016-06-16 09:17:49 -07003674 print('Aborted.')
kmarshall3bff56b2016-06-06 18:31:47 -07003675 return 1
3676
3677 for branch, tagname in proposal:
kmarshall9249e012016-08-23 12:02:16 -07003678 if not options.notags:
3679 RunGit(['tag', tagname, branch])
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00003680
3681 if RunGitWithCode(['branch', '-D', branch])[0] != 0:
3682 # Clean up the tag if we failed to delete the branch.
3683 RunGit(['tag', '-d', tagname])
kmarshall9249e012016-08-23 12:02:16 -07003684
vapiera7fbd5a2016-06-16 09:17:49 -07003685 print('\nJob\'s done!')
kmarshall3bff56b2016-06-06 18:31:47 -07003686
3687 return 0
3688
3689
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003690@metrics.collector.collect_metrics('git cl status')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003691def CMDstatus(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003692 """Show status of changelists.
3693
3694 Colors are used to tell the state of the CL unless --fast is used:
jsbell@chromium.orgaeab41a2013-12-10 20:01:22 +00003695 - Blue waiting for review
Aaron Gable9ab38c62017-04-06 14:36:33 -07003696 - Yellow waiting for you to reply to review, or not yet sent
jsbell@chromium.orgaeab41a2013-12-10 20:01:22 +00003697 - Green LGTM'ed
Aaron Gable9ab38c62017-04-06 14:36:33 -07003698 - Red 'not LGTM'ed
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00003699 - Magenta in the CQ
jsbell@chromium.orgaeab41a2013-12-10 20:01:22 +00003700 - Cyan was committed, branch can be deleted
Aaron Gable9ab38c62017-04-06 14:36:33 -07003701 - White error, or unknown status
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003702
3703 Also see 'git cl comments'.
3704 """
Alan Cuttera3be9a52019-03-04 18:50:33 +00003705 parser.add_option(
3706 '--no-branch-color',
3707 action='store_true',
3708 help='Disable colorized branch names')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003709 parser.add_option('--field',
phajdan.jr289d03e2016-08-16 08:21:06 -07003710 help='print only specific field (desc|id|patch|status|url)')
maruel@chromium.org1033efd2013-07-23 23:25:09 +00003711 parser.add_option('-f', '--fast', action='store_true',
3712 help='Do not retrieve review status')
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003713 parser.add_option(
3714 '-j', '--maxjobs', action='store', type=int,
3715 help='The maximum number of jobs to use when retrieving review status')
Edward Lemur52969c92020-02-06 18:15:28 +00003716 parser.add_option(
3717 '-i', '--issue', type=int,
3718 help='Operate on this issue instead of the current branch\'s implicit '
3719 'issue. Requires --field to be set.')
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00003720 parser.add_option('-d',
3721 '--date-order',
3722 action='store_true',
3723 help='Order branches by committer date.')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00003724 options, args = parser.parse_args(args)
maruel@chromium.org39c0b222013-08-17 16:57:01 +00003725 if args:
3726 parser.error('Unsupported args: %s' % args)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003727
iannuccie53c9352016-08-17 14:40:40 -07003728 if options.issue is not None and not options.field:
Edward Lemur6c6827c2020-02-06 21:15:18 +00003729 parser.error('--field must be given when --issue is set.')
iannucci3c972b92016-08-17 13:24:10 -07003730
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003731 if options.field:
Edward Lemur934836a2019-09-09 20:16:54 +00003732 cl = Changelist(issue=options.issue)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003733 if options.field.startswith('desc'):
Edward Lemur6c6827c2020-02-06 21:15:18 +00003734 if cl.GetIssue():
3735 print(cl.FetchDescription())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003736 elif options.field == 'id':
3737 issueid = cl.GetIssue()
3738 if issueid:
vapiera7fbd5a2016-06-16 09:17:49 -07003739 print(issueid)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003740 elif options.field == 'patch':
Aaron Gablee8856ee2017-12-07 12:41:46 -08003741 patchset = cl.GetMostRecentPatchset()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003742 if patchset:
vapiera7fbd5a2016-06-16 09:17:49 -07003743 print(patchset)
phajdan.jr289d03e2016-08-16 08:21:06 -07003744 elif options.field == 'status':
3745 print(cl.GetStatus())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003746 elif options.field == 'url':
3747 url = cl.GetIssueURL()
3748 if url:
vapiera7fbd5a2016-06-16 09:17:49 -07003749 print(url)
maruel@chromium.orge25c75b2013-07-23 18:30:56 +00003750 return 0
3751
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00003752 branches = RunGit([
3753 'for-each-ref', '--format=%(refname) %(committerdate:unix)', 'refs/heads'
3754 ])
maruel@chromium.orge25c75b2013-07-23 18:30:56 +00003755 if not branches:
3756 print('No local branch found.')
3757 return 0
3758
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003759 changes = [
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00003760 Changelist(branchref=b, commit_date=ct)
3761 for b, ct in map(lambda line: line.split(' '), branches.splitlines())
3762 ]
vapiera7fbd5a2016-06-16 09:17:49 -07003763 print('Branches associated with reviews:')
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003764 output = get_cl_statuses(changes,
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003765 fine_grained=not options.fast,
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003766 max_processes=options.maxjobs)
maruel@chromium.org1033efd2013-07-23 23:25:09 +00003767
Edward Lemur85153282020-02-14 22:06:29 +00003768 current_branch = scm.GIT.GetBranch(settings.GetRoot())
Daniel McArdlea23bf592019-02-12 00:25:12 +00003769
3770 def FormatBranchName(branch, colorize=False):
3771 """Simulates 'git branch' behavior. Colorizes and prefixes branch name with
3772 an asterisk when it is the current branch."""
3773
3774 asterisk = ""
3775 color = Fore.RESET
3776 if branch == current_branch:
3777 asterisk = "* "
3778 color = Fore.GREEN
Edward Lemur85153282020-02-14 22:06:29 +00003779 branch_name = scm.GIT.ShortBranchName(branch)
Daniel McArdlea23bf592019-02-12 00:25:12 +00003780
3781 if colorize:
3782 return asterisk + color + branch_name + Fore.RESET
Daniel McArdle452a49f2019-02-14 17:28:31 +00003783 return asterisk + branch_name
3784
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003785 branch_statuses = {}
Daniel McArdlea23bf592019-02-12 00:25:12 +00003786
3787 alignment = max(5, max(len(FormatBranchName(c.GetBranch())) for c in changes))
Sigurd Schneider1bfda8e2021-06-30 14:46:25 +00003788
3789 if options.date_order or settings.IsStatusCommitOrderByDate():
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00003790 sorted_changes = sorted(changes,
3791 key=lambda c: c.GetCommitDate(),
3792 reverse=True)
3793 else:
3794 sorted_changes = sorted(changes, key=lambda c: c.GetBranch())
3795 for cl in sorted_changes:
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003796 branch = cl.GetBranch()
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003797 while branch not in branch_statuses:
Edward Lemur79d4f992019-11-11 23:49:02 +00003798 c, status = next(output)
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003799 branch_statuses[c.GetBranch()] = status
3800 status = branch_statuses.pop(branch)
Andrii Shyshkalov1ee78cd2020-03-12 01:31:53 +00003801 url = cl.GetIssueURL(short=True)
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003802 if url and (not status or status == 'error'):
3803 # The issue probably doesn't exist anymore.
3804 url += ' (broken)'
3805
nodir@chromium.orga6de1f42015-06-10 04:23:17 +00003806 color = color_for_status(status)
Bruce Dawsonb73f8a92020-03-27 22:03:08 +00003807 # Turn off bold as well as colors.
3808 END = '\033[0m'
3809 reset = Fore.RESET + END
iannucci@chromium.org596cd5c2016-04-04 21:34:39 +00003810 if not setup_color.IS_TTY:
maruel@chromium.org885f6512013-07-27 02:17:26 +00003811 color = ''
3812 reset = ''
nodir@chromium.orga6de1f42015-06-10 04:23:17 +00003813 status_str = '(%s)' % status if status else ''
Daniel McArdle452a49f2019-02-14 17:28:31 +00003814
Alan Cuttera3be9a52019-03-04 18:50:33 +00003815 branch_display = FormatBranchName(branch)
3816 padding = ' ' * (alignment - len(branch_display))
3817 if not options.no_branch_color:
3818 branch_display = FormatBranchName(branch, colorize=True)
Daniel McArdle452a49f2019-02-14 17:28:31 +00003819
Alan Cuttera3be9a52019-03-04 18:50:33 +00003820 print(' %s : %s%s %s%s' % (padding + branch_display, color, url,
3821 status_str, reset))
Andrii Shyshkalovd0e1d9d2017-01-24 17:10:51 +01003822
vapiera7fbd5a2016-06-16 09:17:49 -07003823 print()
Daniel McArdlea23bf592019-02-12 00:25:12 +00003824 print('Current branch: %s' % current_branch)
Andrii Shyshkalovd0e1d9d2017-01-24 17:10:51 +01003825 for cl in changes:
Daniel McArdlea23bf592019-02-12 00:25:12 +00003826 if cl.GetBranch() == current_branch:
Andrii Shyshkalovd0e1d9d2017-01-24 17:10:51 +01003827 break
dpranke@chromium.orgee87f582015-07-31 18:46:25 +00003828 if not cl.GetIssue():
vapiera7fbd5a2016-06-16 09:17:49 -07003829 print('No issue assigned.')
dpranke@chromium.orgee87f582015-07-31 18:46:25 +00003830 return 0
vapiera7fbd5a2016-06-16 09:17:49 -07003831 print('Issue number: %s (%s)' % (cl.GetIssue(), cl.GetIssueURL()))
maruel@chromium.org85616e02014-07-28 15:37:55 +00003832 if not options.fast:
vapiera7fbd5a2016-06-16 09:17:49 -07003833 print('Issue description:')
Edward Lemur6c6827c2020-02-06 21:15:18 +00003834 print(cl.FetchDescription(pretty=True))
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003835 return 0
3836
3837
maruel@chromium.org39c0b222013-08-17 16:57:01 +00003838def colorize_CMDstatus_doc():
3839 """To be called once in main() to add colors to git cl status help."""
3840 colors = [i for i in dir(Fore) if i[0].isupper()]
3841
3842 def colorize_line(line):
3843 for color in colors:
3844 if color in line.upper():
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003845 # Extract whitespace first and the leading '-'.
maruel@chromium.org39c0b222013-08-17 16:57:01 +00003846 indent = len(line) - len(line.lstrip(' ')) + 1
3847 return line[:indent] + getattr(Fore, color) + line[indent:] + Fore.RESET
3848 return line
3849
3850 lines = CMDstatus.__doc__.splitlines()
3851 CMDstatus.__doc__ = '\n'.join(colorize_line(l) for l in lines)
3852
3853
phajdan.jre328cf92016-08-22 04:12:17 -07003854def write_json(path, contents):
Stefan Zager1306bd02017-06-22 19:26:46 -07003855 if path == '-':
3856 json.dump(contents, sys.stdout)
3857 else:
3858 with open(path, 'w') as f:
3859 json.dump(contents, f)
phajdan.jre328cf92016-08-22 04:12:17 -07003860
3861
maruel@chromium.org0633fb42013-08-16 20:06:14 +00003862@subcommand.usage('[issue_number]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003863@metrics.collector.collect_metrics('git cl issue')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003864def CMDissue(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003865 """Sets or displays the current code review issue number.
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003866
3867 Pass issue number 0 to clear the current issue.
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003868 """
dnj@chromium.org406c4402015-03-03 17:22:28 +00003869 parser.add_option('-r', '--reverse', action='store_true',
3870 help='Lookup the branch(es) for the specified issues. If '
3871 'no issues are specified, all branches with mapped '
3872 'issues will be listed.')
Stefan Zager1306bd02017-06-22 19:26:46 -07003873 parser.add_option('--json',
3874 help='Path to JSON output file, or "-" for stdout.')
dnj@chromium.org406c4402015-03-03 17:22:28 +00003875 options, args = parser.parse_args(args)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003876
dnj@chromium.org406c4402015-03-03 17:22:28 +00003877 if options.reverse:
3878 branches = RunGit(['for-each-ref', 'refs/heads',
Aaron Gablead64abd2017-12-04 09:49:13 -08003879 '--format=%(refname)']).splitlines()
dnj@chromium.org406c4402015-03-03 17:22:28 +00003880 # Reverse issue lookup.
3881 issue_branch_map = {}
Daniel Bratellb56a43a2018-09-06 15:49:03 +00003882
3883 git_config = {}
3884 for config in RunGit(['config', '--get-regexp',
3885 r'branch\..*issue']).splitlines():
3886 name, _space, val = config.partition(' ')
3887 git_config[name] = val
3888
dnj@chromium.org406c4402015-03-03 17:22:28 +00003889 for branch in branches:
Edward Lesmes50da7702020-03-30 19:23:43 +00003890 issue = git_config.get(
3891 'branch.%s.%s' % (scm.GIT.ShortBranchName(branch), ISSUE_CONFIG_KEY))
Edward Lemur52969c92020-02-06 18:15:28 +00003892 if issue:
3893 issue_branch_map.setdefault(int(issue), []).append(branch)
dnj@chromium.org406c4402015-03-03 17:22:28 +00003894 if not args:
Carlos Caballero81923d62020-07-06 18:22:27 +00003895 args = sorted(issue_branch_map.keys())
phajdan.jre328cf92016-08-22 04:12:17 -07003896 result = {}
dnj@chromium.org406c4402015-03-03 17:22:28 +00003897 for issue in args:
Lei Zhang5a368d42019-03-25 23:18:19 +00003898 try:
3899 issue_num = int(issue)
3900 except ValueError:
3901 print('ERROR cannot parse issue number: %s' % issue, file=sys.stderr)
dnj@chromium.org406c4402015-03-03 17:22:28 +00003902 continue
Lei Zhang5a368d42019-03-25 23:18:19 +00003903 result[issue_num] = issue_branch_map.get(issue_num)
vapiera7fbd5a2016-06-16 09:17:49 -07003904 print('Branch for issue number %s: %s' % (
Lei Zhang5a368d42019-03-25 23:18:19 +00003905 issue, ', '.join(issue_branch_map.get(issue_num) or ('None',))))
phajdan.jre328cf92016-08-22 04:12:17 -07003906 if options.json:
3907 write_json(options.json, result)
Aaron Gable78753da2017-06-15 10:35:49 -07003908 return 0
3909
3910 if len(args) > 0:
Edward Lemurf38bc172019-09-03 21:02:13 +00003911 issue = ParseIssueNumberArgument(args[0])
Aaron Gable78753da2017-06-15 10:35:49 -07003912 if not issue.valid:
3913 DieWithError('Pass a url or number to set the issue, 0 to unset it, '
3914 'or no argument to list it.\n'
3915 'Maybe you want to run git cl status?')
Edward Lemurf38bc172019-09-03 21:02:13 +00003916 cl = Changelist()
Aaron Gable78753da2017-06-15 10:35:49 -07003917 cl.SetIssue(issue.issue)
dnj@chromium.org406c4402015-03-03 17:22:28 +00003918 else:
Edward Lemurf38bc172019-09-03 21:02:13 +00003919 cl = Changelist()
Aaron Gable78753da2017-06-15 10:35:49 -07003920 print('Issue number: %s (%s)' % (cl.GetIssue(), cl.GetIssueURL()))
3921 if options.json:
3922 write_json(options.json, {
Nodir Turakulov27379632021-03-17 18:53:29 +00003923 'gerrit_host': cl.GetGerritHost(),
3924 'gerrit_project': cl.GetGerritProject(),
Aaron Gable78753da2017-06-15 10:35:49 -07003925 'issue_url': cl.GetIssueURL(),
Nodir Turakulov27379632021-03-17 18:53:29 +00003926 'issue': cl.GetIssue(),
Aaron Gable78753da2017-06-15 10:35:49 -07003927 })
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003928 return 0
3929
3930
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003931@metrics.collector.collect_metrics('git cl comments')
maruel@chromium.org9977a2e2012-06-06 22:30:56 +00003932def CMDcomments(parser, args):
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003933 """Shows or posts review comments for any changelist."""
3934 parser.add_option('-a', '--add-comment', dest='comment',
3935 help='comment to add to an issue')
Sergiy Byelozyorovcb629a42018-10-28 19:20:39 +00003936 parser.add_option('-p', '--publish', action='store_true',
3937 help='marks CL as ready and sends comment to reviewers')
Andrii Shyshkalov0d6b46e2017-03-17 22:23:22 +01003938 parser.add_option('-i', '--issue', dest='issue',
Edward Lemurf38bc172019-09-03 21:02:13 +00003939 help='review issue id (defaults to current issue).')
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07003940 parser.add_option('-m', '--machine-readable', dest='readable',
3941 action='store_false', default=True,
3942 help='output comments in a format compatible with '
3943 'editor parsing')
smut@google.comc85ac942015-09-15 16:34:43 +00003944 parser.add_option('-j', '--json-file',
Stefan Zager1306bd02017-06-22 19:26:46 -07003945 help='File to write JSON summary to, or "-" for stdout')
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003946 options, args = parser.parse_args(args)
maruel@chromium.org9977a2e2012-06-06 22:30:56 +00003947
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003948 issue = None
3949 if options.issue:
3950 try:
3951 issue = int(options.issue)
3952 except ValueError:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00003953 DieWithError('A review issue ID is expected to be a number.')
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003954
Edward Lemur934836a2019-09-09 20:16:54 +00003955 cl = Changelist(issue=issue)
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003956
3957 if options.comment:
Sergiy Byelozyorovcb629a42018-10-28 19:20:39 +00003958 cl.AddComment(options.comment, options.publish)
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003959 return 0
3960
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07003961 summary = sorted(cl.GetCommentsSummary(readable=options.readable),
3962 key=lambda c: c.date)
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01003963 for comment in summary:
3964 if comment.disapproval:
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003965 color = Fore.RED
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01003966 elif comment.approval:
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003967 color = Fore.GREEN
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01003968 elif comment.sender == cl.GetIssueOwner():
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003969 color = Fore.MAGENTA
Quinten Yearsley0e617c02019-02-20 00:37:03 +00003970 elif comment.autogenerated:
3971 color = Fore.CYAN
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003972 else:
3973 color = Fore.BLUE
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01003974 print('\n%s%s %s%s\n%s' % (
3975 color,
3976 comment.date.strftime('%Y-%m-%d %H:%M:%S UTC'),
3977 comment.sender,
3978 Fore.RESET,
3979 '\n'.join(' ' + l for l in comment.message.strip().splitlines())))
3980
smut@google.comc85ac942015-09-15 16:34:43 +00003981 if options.json_file:
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01003982 def pre_serialize(c):
Edward Lemur79d4f992019-11-11 23:49:02 +00003983 dct = c._asdict().copy()
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01003984 dct['date'] = dct['date'].strftime('%Y-%m-%d %H:%M:%S.%f')
3985 return dct
Edward Lemur79d4f992019-11-11 23:49:02 +00003986 write_json(options.json_file, [pre_serialize(x) for x in summary])
maruel@chromium.org9977a2e2012-06-06 22:30:56 +00003987 return 0
3988
3989
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00003990@subcommand.usage('[codereview url or issue id]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003991@metrics.collector.collect_metrics('git cl description')
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00003992def CMDdescription(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003993 """Brings up the editor for the current CL's description."""
smut@google.com34fb6b12015-07-13 20:03:26 +00003994 parser.add_option('-d', '--display', action='store_true',
3995 help='Display the description instead of opening an editor')
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00003996 parser.add_option('-n', '--new-description',
dnjba1b0f32016-09-02 12:37:42 -07003997 help='New description to set for this issue (- for stdin, '
3998 '+ to load from local commit HEAD)')
dsansomee2d6fd92016-09-08 00:10:47 -07003999 parser.add_option('-f', '--force', action='store_true',
4000 help='Delete any unpublished Gerrit edits for this issue '
4001 'without prompting')
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00004002
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00004003 options, args = parser.parse_args(args)
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00004004
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01004005 target_issue_arg = None
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00004006 if len(args) > 0:
Edward Lemurf38bc172019-09-03 21:02:13 +00004007 target_issue_arg = ParseIssueNumberArgument(args[0])
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01004008 if not target_issue_arg.valid:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004009 parser.error('Invalid issue ID or URL.')
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00004010
Edward Lemur934836a2019-09-09 20:16:54 +00004011 kwargs = {}
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01004012 if target_issue_arg:
4013 kwargs['issue'] = target_issue_arg.issue
4014 kwargs['codereview_host'] = target_issue_arg.hostname
martiniss6eda05f2016-06-30 10:18:35 -07004015
4016 cl = Changelist(**kwargs)
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00004017 if not cl.GetIssue():
4018 DieWithError('This branch has no associated changelist.')
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004019
Edward Lemur678a6842019-10-03 22:25:05 +00004020 if args and not args[0].isdigit():
Edward Lemurf38bc172019-09-03 21:02:13 +00004021 logging.info('canonical issue/change URL: %s\n', cl.GetIssueURL())
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004022
Edward Lemur6c6827c2020-02-06 21:15:18 +00004023 description = ChangeDescription(cl.FetchDescription())
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00004024
smut@google.com34fb6b12015-07-13 20:03:26 +00004025 if options.display:
vapiera7fbd5a2016-06-16 09:17:49 -07004026 print(description.description)
smut@google.com34fb6b12015-07-13 20:03:26 +00004027 return 0
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00004028
4029 if options.new_description:
4030 text = options.new_description
4031 if text == '-':
4032 text = '\n'.join(l.rstrip() for l in sys.stdin)
dnjba1b0f32016-09-02 12:37:42 -07004033 elif text == '+':
4034 base_branch = cl.GetCommonAncestorWithUpstream()
Edward Lemura12175c2020-03-09 16:58:26 +00004035 text = _create_description_from_log([base_branch])
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00004036
4037 description.set_description(text)
4038 else:
Edward Lemurf38bc172019-09-03 21:02:13 +00004039 description.prompt()
Edward Lemur6c6827c2020-02-06 21:15:18 +00004040 if cl.FetchDescription().strip() != description.description:
dsansomee2d6fd92016-09-08 00:10:47 -07004041 cl.UpdateDescription(description.description, force=options.force)
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00004042 return 0
4043
4044
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004045@metrics.collector.collect_metrics('git cl lint')
thestig@chromium.org44202a22014-03-11 19:22:18 +00004046def CMDlint(parser, args):
4047 """Runs cpplint on the current changelist."""
tzik@chromium.orgf204d4b2014-03-13 07:40:55 +00004048 parser.add_option('--filter', action='append', metavar='-x,+y',
4049 help='Comma-separated list of cpplint\'s category-filters')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004050 options, args = parser.parse_args(args)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004051
4052 # Access to a protected member _XX of a client class
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08004053 # pylint: disable=protected-access
thestig@chromium.org44202a22014-03-11 19:22:18 +00004054 try:
4055 import cpplint
4056 import cpplint_chromium
4057 except ImportError:
vapiera7fbd5a2016-06-16 09:17:49 -07004058 print('Your depot_tools is missing cpplint.py and/or cpplint_chromium.py.')
thestig@chromium.org44202a22014-03-11 19:22:18 +00004059 return 1
4060
4061 # Change the current working directory before calling lint so that it
4062 # shows the correct base.
4063 previous_cwd = os.getcwd()
4064 os.chdir(settings.GetRoot())
4065 try:
Edward Lemur934836a2019-09-09 20:16:54 +00004066 cl = Changelist()
Edward Lemur2c62b332020-03-12 22:12:33 +00004067 files = cl.GetAffectedFiles(cl.GetCommonAncestorWithUpstream())
thestig@chromium.org5839eb52014-05-30 16:20:51 +00004068 if not files:
vapiera7fbd5a2016-06-16 09:17:49 -07004069 print('Cannot lint an empty CL')
thestig@chromium.org5839eb52014-05-30 16:20:51 +00004070 return 1
thestig@chromium.org44202a22014-03-11 19:22:18 +00004071
Lei Zhangb8c62cf2020-07-15 20:09:37 +00004072 # Process cpplint arguments, if any.
4073 filters = presubmit_canned_checks.GetCppLintFilters(options.filter)
4074 command = ['--filter=' + ','.join(filters)] + args + files
tzik@chromium.orgf204d4b2014-03-13 07:40:55 +00004075 filenames = cpplint.ParseArguments(command)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004076
Lei Zhang379d1ad2020-07-15 19:40:06 +00004077 include_regex = re.compile(settings.GetLintRegex())
4078 ignore_regex = re.compile(settings.GetLintIgnoreRegex())
thestig@chromium.org44202a22014-03-11 19:22:18 +00004079 extra_check_functions = [cpplint_chromium.CheckPointerDeclarationWhitespace]
4080 for filename in filenames:
Lei Zhang379d1ad2020-07-15 19:40:06 +00004081 if not include_regex.match(filename):
vapiera7fbd5a2016-06-16 09:17:49 -07004082 print('Skipping file %s' % filename)
Lei Zhang379d1ad2020-07-15 19:40:06 +00004083 continue
4084
4085 if ignore_regex.match(filename):
4086 print('Ignoring file %s' % filename)
4087 continue
4088
4089 cpplint.ProcessFile(filename, cpplint._cpplint_state.verbose_level,
4090 extra_check_functions)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004091 finally:
4092 os.chdir(previous_cwd)
vapiera7fbd5a2016-06-16 09:17:49 -07004093 print('Total errors found: %d\n' % cpplint._cpplint_state.error_count)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004094 if cpplint._cpplint_state.error_count != 0:
4095 return 1
4096 return 0
4097
4098
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004099@metrics.collector.collect_metrics('git cl presubmit')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004100def CMDpresubmit(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004101 """Runs presubmit tests on the current changelist."""
ilevy@chromium.org375a9022013-01-07 01:12:05 +00004102 parser.add_option('-u', '--upload', action='store_true',
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004103 help='Run upload hook instead of the push hook')
ilevy@chromium.org375a9022013-01-07 01:12:05 +00004104 parser.add_option('-f', '--force', action='store_true',
sbc@chromium.org495ad152012-09-04 23:07:42 +00004105 help='Run checks even if tree is dirty')
Aaron Gable8076c282017-11-29 14:39:41 -08004106 parser.add_option('--all', action='store_true',
4107 help='Run checks against all files, not just modified ones')
Josip Sokcevic017544d2022-03-31 23:47:53 +00004108 parser.add_option('--files',
4109 nargs=1,
4110 help='Semicolon-separated list of files to be marked as '
4111 'modified when executing presubmit or post-upload hooks. '
4112 'fnmatch wildcards can also be used.')
Edward Lesmes8e282792018-04-03 18:50:29 -04004113 parser.add_option('--parallel', action='store_true',
4114 help='Run all tests specified by input_api.RunTests in all '
4115 'PRESUBMIT files in parallel.')
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00004116 parser.add_option('--resultdb', action='store_true',
4117 help='Run presubmit checks in the ResultSink environment '
4118 'and send results to the ResultDB database.')
Saagar Sanghavi03b15132020-08-10 16:43:41 +00004119 parser.add_option('--realm', help='LUCI realm if reporting to ResultDB')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004120 options, args = parser.parse_args(args)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004121
sbc@chromium.org71437c02015-04-09 19:29:40 +00004122 if not options.force and git_common.is_dirty_git_tree('presubmit'):
vapiera7fbd5a2016-06-16 09:17:49 -07004123 print('use --force to check even if tree is dirty.')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004124 return 1
4125
Edward Lemur934836a2019-09-09 20:16:54 +00004126 cl = Changelist()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004127 if args:
4128 base_branch = args[0]
4129 else:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00004130 # Default to diffing against the common ancestor of the upstream branch.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00004131 base_branch = cl.GetCommonAncestorWithUpstream()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004132
Bruce Dawsoneb8426e2022-08-05 23:58:15 +00004133 start = time.time()
4134 try:
4135 if not 'PRESUBMIT_SKIP_NETWORK' in os.environ and cl.GetIssue():
4136 description = cl.FetchDescription()
4137 else:
4138 description = _create_description_from_log([base_branch])
4139 except Exception as e:
4140 print('Failed to fetch CL description - %s' % str(e))
Edward Lemura12175c2020-03-09 16:58:26 +00004141 description = _create_description_from_log([base_branch])
Bruce Dawsoneb8426e2022-08-05 23:58:15 +00004142 elapsed = time.time() - start
4143 if elapsed > 5:
4144 print('%.1f s to get CL description.' % elapsed)
Aaron Gable8076c282017-11-29 14:39:41 -08004145
Bruce Dawson13acea32022-05-03 22:13:08 +00004146 if not base_branch:
4147 if not options.force:
4148 print('use --force to check even when not on a branch.')
4149 return 1
4150 base_branch = 'HEAD'
4151
Josip Sokcevic017544d2022-03-31 23:47:53 +00004152 cl.RunHook(committing=not options.upload,
4153 may_prompt=False,
4154 verbose=options.verbose,
4155 parallel=options.parallel,
4156 upstream=base_branch,
4157 description=description,
4158 all_files=options.all,
4159 files=options.files,
4160 resultdb=options.resultdb,
4161 realm=options.realm)
dpranke@chromium.org0a2bb372011-03-25 01:16:22 +00004162 return 0
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004163
4164
tandrii@chromium.org65874e12016-03-04 12:03:02 +00004165def GenerateGerritChangeId(message):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004166 """Returns the Change ID footer value (Ixxxxxx...xxx).
tandrii@chromium.org65874e12016-03-04 12:03:02 +00004167
4168 Works the same way as
4169 https://gerrit-review.googlesource.com/tools/hooks/commit-msg
4170 but can be called on demand on all platforms.
4171
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004172 The basic idea is to generate git hash of a state of the tree, original
4173 commit message, author/committer info and timestamps.
tandrii@chromium.org65874e12016-03-04 12:03:02 +00004174 """
4175 lines = []
4176 tree_hash = RunGitSilent(['write-tree'])
4177 lines.append('tree %s' % tree_hash.strip())
4178 code, parent = RunGitWithCode(['rev-parse', 'HEAD~0'], suppress_stderr=False)
4179 if code == 0:
4180 lines.append('parent %s' % parent.strip())
4181 author = RunGitSilent(['var', 'GIT_AUTHOR_IDENT'])
4182 lines.append('author %s' % author.strip())
4183 committer = RunGitSilent(['var', 'GIT_COMMITTER_IDENT'])
4184 lines.append('committer %s' % committer.strip())
4185 lines.append('')
4186 # Note: Gerrit's commit-hook actually cleans message of some lines and
4187 # whitespace. This code is not doing this, but it clearly won't decrease
4188 # entropy.
4189 lines.append(message)
4190 change_hash = RunCommand(['git', 'hash-object', '-t', 'commit', '--stdin'],
Raul Tambreb946b232019-03-26 14:48:46 +00004191 stdin=('\n'.join(lines)).encode())
tandrii@chromium.org65874e12016-03-04 12:03:02 +00004192 return 'I%s' % change_hash.strip()
4193
4194
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01004195def GetTargetRef(remote, remote_branch, target_branch):
wittman@chromium.org455dc922015-01-26 20:15:50 +00004196 """Computes the remote branch ref to use for the CL.
4197
4198 Args:
4199 remote (str): The git remote for the CL.
4200 remote_branch (str): The git remote branch for the CL.
4201 target_branch (str): The target branch specified by the user.
wittman@chromium.org455dc922015-01-26 20:15:50 +00004202 """
4203 if not (remote and remote_branch):
4204 return None
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00004205
wittman@chromium.org455dc922015-01-26 20:15:50 +00004206 if target_branch:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07004207 # Canonicalize branch references to the equivalent local full symbolic
wittman@chromium.org455dc922015-01-26 20:15:50 +00004208 # refs, which are then translated into the remote full symbolic refs
4209 # below.
4210 if '/' not in target_branch:
4211 remote_branch = 'refs/remotes/%s/%s' % (remote, target_branch)
4212 else:
4213 prefix_replacements = (
4214 ('^((refs/)?remotes/)?branch-heads/', 'refs/remotes/branch-heads/'),
4215 ('^((refs/)?remotes/)?%s/' % remote, 'refs/remotes/%s/' % remote),
4216 ('^(refs/)?heads/', 'refs/remotes/%s/' % remote),
4217 )
4218 match = None
4219 for regex, replacement in prefix_replacements:
4220 match = re.search(regex, target_branch)
4221 if match:
4222 remote_branch = target_branch.replace(match.group(0), replacement)
4223 break
4224 if not match:
4225 # This is a branch path but not one we recognize; use as-is.
4226 remote_branch = target_branch
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +00004227 # pylint: disable=consider-using-get
rmistry@google.comc68112d2015-03-03 12:48:06 +00004228 elif remote_branch in REFS_THAT_ALIAS_TO_OTHER_REFS:
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +00004229 # pylint: enable=consider-using-get
rmistry@google.comc68112d2015-03-03 12:48:06 +00004230 # Handle the refs that need to land in different refs.
4231 remote_branch = REFS_THAT_ALIAS_TO_OTHER_REFS[remote_branch]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00004232
wittman@chromium.org455dc922015-01-26 20:15:50 +00004233 # Create the true path to the remote branch.
4234 # Does the following translation:
4235 # * refs/remotes/origin/refs/diff/test -> refs/diff/test
Josip Sokcevicc39ab992020-09-24 20:09:15 +00004236 # * refs/remotes/origin/main -> refs/heads/main
wittman@chromium.org455dc922015-01-26 20:15:50 +00004237 # * refs/remotes/branch-heads/test -> refs/branch-heads/test
4238 if remote_branch.startswith('refs/remotes/%s/refs/' % remote):
4239 remote_branch = remote_branch.replace('refs/remotes/%s/' % remote, '')
4240 elif remote_branch.startswith('refs/remotes/%s/' % remote):
4241 remote_branch = remote_branch.replace('refs/remotes/%s/' % remote,
4242 'refs/heads/')
4243 elif remote_branch.startswith('refs/remotes/branch-heads'):
4244 remote_branch = remote_branch.replace('refs/remotes/', 'refs/')
Andrii Shyshkalov768f1d82016-12-08 15:10:13 +01004245
wittman@chromium.org455dc922015-01-26 20:15:50 +00004246 return remote_branch
4247
4248
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004249def cleanup_list(l):
4250 """Fixes a list so that comma separated items are put as individual items.
4251
4252 So that "--reviewers joe@c,john@c --reviewers joa@c" results in
4253 options.reviewers == sorted(['joe@c', 'john@c', 'joa@c']).
4254 """
4255 items = sum((i.split(',') for i in l), [])
4256 stripped_items = (i.strip() for i in items)
4257 return sorted(filter(None, stripped_items))
4258
4259
Aaron Gable4db38df2017-11-03 14:59:07 -07004260@subcommand.usage('[flags]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004261@metrics.collector.collect_metrics('git cl upload')
ukai@chromium.orge8077812012-02-03 03:41:46 +00004262def CMDupload(parser, args):
rmistry@google.com78948ed2015-07-08 23:09:57 +00004263 """Uploads the current changelist to codereview.
4264
4265 Can skip dependency patchset uploads for a branch by running:
4266 git config branch.branch_name.skip-deps-uploads True
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004267 To unset, run:
rmistry@google.com78948ed2015-07-08 23:09:57 +00004268 git config --unset branch.branch_name.skip-deps-uploads
4269 Can also set the above globally by using the --global flag.
Dominic Battre7d1c4842017-10-27 09:17:28 +02004270
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004271 If the name of the checked out branch starts with "bug-" or "fix-" followed
4272 by a bug number, this bug number is automatically populated in the CL
Dominic Battre7d1c4842017-10-27 09:17:28 +02004273 description.
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004274
4275 If subject contains text in square brackets or has "<text>: " prefix, such
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004276 text(s) is treated as Gerrit hashtags. For example, CLs with subjects:
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004277 [git-cl] add support for hashtags
4278 Foo bar: implement foo
4279 will be hashtagged with "git-cl" and "foo-bar" respectively.
rmistry@google.com78948ed2015-07-08 23:09:57 +00004280 """
ukai@chromium.orge8077812012-02-03 03:41:46 +00004281 parser.add_option('--bypass-hooks', action='store_true', dest='bypass_hooks',
4282 help='bypass upload presubmit hook')
brettw@chromium.orgb65c43c2013-06-10 22:04:49 +00004283 parser.add_option('--bypass-watchlists', action='store_true',
4284 dest='bypass_watchlists',
4285 help='bypass watchlists auto CC-ing reviewers')
Aaron Gablef7543cd2017-07-20 14:26:31 -07004286 parser.add_option('-f', '--force', action='store_true', dest='force',
ukai@chromium.orge8077812012-02-03 03:41:46 +00004287 help="force yes to questions (don't prompt)")
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004288 parser.add_option('--message', '-m', dest='message',
4289 help='message for patchset')
tandriif9aefb72016-07-01 09:06:51 -07004290 parser.add_option('-b', '--bug',
4291 help='pre-populate the bug number(s) for this issue. '
4292 'If several, separate with commas')
tandriib80458a2016-06-23 12:20:07 -07004293 parser.add_option('--message-file', dest='message_file',
4294 help='file which contains message for patchset')
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004295 parser.add_option('--title', '-t', dest='title',
4296 help='title for patchset')
Mario Bianuccicebfb4e2020-07-22 23:08:16 +00004297 parser.add_option('-T', '--skip-title', action='store_true',
4298 dest='skip_title',
4299 help='Use the most recent commit message as the title of '
4300 'the patchset')
ukai@chromium.orge8077812012-02-03 03:41:46 +00004301 parser.add_option('-r', '--reviewers',
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004302 action='append', default=[],
ukai@chromium.orge8077812012-02-03 03:41:46 +00004303 help='reviewer email addresses')
Robert Iannucci6c98dc62017-04-18 11:38:00 -07004304 parser.add_option('--tbrs',
4305 action='append', default=[],
4306 help='TBR email addresses')
ukai@chromium.orge8077812012-02-03 03:41:46 +00004307 parser.add_option('--cc',
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004308 action='append', default=[],
ukai@chromium.orge8077812012-02-03 03:41:46 +00004309 help='cc email addresses')
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004310 parser.add_option('--hashtag', dest='hashtags',
4311 action='append', default=[],
4312 help=('Gerrit hashtag for new CL; '
4313 'can be applied multiple times'))
Thiago Perrottab0fb8d52022-08-30 21:26:19 +00004314 parser.add_option('-s',
4315 '--send-mail',
4316 '--send-email',
4317 dest='send_mail',
4318 action='store_true',
Aaron Gable59f48512017-01-12 10:54:46 -08004319 help='send email to reviewer(s) and cc(s) immediately')
ukai@chromium.org8ef7ab22012-11-28 04:24:52 +00004320 parser.add_option('--target_branch',
pgervais@chromium.orgb9f27512014-08-08 15:52:33 +00004321 '--target-branch',
wittman@chromium.org455dc922015-01-26 20:15:50 +00004322 metavar='TARGET',
4323 help='Apply CL to remote ref TARGET. ' +
Josip Sokcevicc39ab992020-09-24 20:09:15 +00004324 'Default: remote branch head, or main')
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00004325 parser.add_option('--squash', action='store_true',
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004326 help='Squash multiple commits into one')
Mike Frysingera989d552019-08-14 20:51:23 +00004327 parser.add_option('--no-squash', action='store_false', dest='squash',
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004328 help='Don\'t squash multiple commits into one')
rmistry9eadede2016-09-19 11:22:43 -07004329 parser.add_option('--topic', default=None,
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004330 help='Topic to specify when uploading')
Robert Iannuccif2708bd2017-04-17 15:49:02 -07004331 parser.add_option('--tbr-owners', dest='add_owners_to', action='store_const',
4332 const='TBR', help='add a set of OWNERS to TBR')
4333 parser.add_option('--r-owners', dest='add_owners_to', action='store_const',
4334 const='R', help='add a set of OWNERS to R')
Thiago Perrottab0fb8d52022-08-30 21:26:19 +00004335 parser.add_option('-c',
4336 '--use-commit-queue',
4337 action='store_true',
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004338 default=False,
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00004339 help='tell the CQ to commit this patchset; '
Thiago Perrottab0fb8d52022-08-30 21:26:19 +00004340 'implies --send-mail')
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004341 parser.add_option('-d', '--cq-dry-run',
4342 action='store_true', default=False,
rmistry@google.comef966222015-04-07 11:15:01 +00004343 help='Send the patchset to do a CQ dry run right after '
4344 'upload.')
Greg Gutermanbe5fccd2021-06-14 17:58:20 +00004345 parser.add_option(
4346 '-q',
4347 '--cq-quick-run',
4348 action='store_true',
4349 default=False,
4350 help='Send the patchset to do a CQ quick run right after '
4351 'upload (https://source.chromium.org/chromium/chromium/src/+/main:do'
4352 'cs/cq_quick_run.md) (chromium only).')
Edward Lesmes10c3dd62021-02-08 21:13:57 +00004353 parser.add_option('--set-bot-commit', action='store_true',
4354 help=optparse.SUPPRESS_HELP)
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +00004355 parser.add_option('--preserve-tryjobs', action='store_true',
4356 help='instruct the CQ to let tryjobs running even after '
4357 'new patchsets are uploaded instead of canceling '
4358 'prior patchset\' tryjobs')
rmistry@google.com2dd99862015-06-22 12:22:18 +00004359 parser.add_option('--dependencies', action='store_true',
4360 help='Uploads CLs of all the local branches that depend on '
4361 'the current branch')
Ravi Mistry31e7d562018-04-02 12:53:57 -04004362 parser.add_option('-a', '--enable-auto-submit', action='store_true',
4363 help='Sends your change to the CQ after an approval. Only '
4364 'works on repos that have the Auto-Submit label '
4365 'enabled')
Edward Lesmes8e282792018-04-03 18:50:29 -04004366 parser.add_option('--parallel', action='store_true',
4367 help='Run all tests specified by input_api.RunTests in all '
4368 'PRESUBMIT files in parallel.')
Sergiy Byelozyorov1aa405f2018-09-18 17:38:43 +00004369 parser.add_option('--no-autocc', action='store_true',
4370 help='Disables automatic addition of CC emails')
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004371 parser.add_option('--private', action='store_true',
Sergiy Byelozyorov1aa405f2018-09-18 17:38:43 +00004372 help='Set the review private. This implies --no-autocc.')
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004373 parser.add_option('-R', '--retry-failed', action='store_true',
4374 help='Retry failed tryjobs from old patchset immediately '
4375 'after uploading new patchset. Cannot be used with '
4376 '--use-commit-queue or --cq-dry-run.')
4377 parser.add_option('--buildbucket-host', default='cr-buildbucket.appspot.com',
4378 help='Host of buildbucket. The default host is %default.')
Dan Beamd8b04ca2019-10-10 21:23:26 +00004379 parser.add_option('--fixed', '-x',
4380 help='List of bugs that will be commented on and marked '
4381 'fixed (pre-populates "Fixed:" tag). Same format as '
4382 '-b option / "Bug:" tag. If fixing several issues, '
4383 'separate with commas.')
Josipe827b0f2020-01-30 00:07:20 +00004384 parser.add_option('--edit-description', action='store_true', default=False,
4385 help='Modify description before upload. Cannot be used '
4386 'with --force. It is a noop when --no-squash is set '
4387 'or a new commit is created.')
Ng Zhi Ancdaf0be2020-05-27 20:57:28 +00004388 parser.add_option('--git-completion-helper', action="store_true",
4389 help=optparse.SUPPRESS_HELP)
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00004390 parser.add_option('--resultdb', action='store_true',
4391 help='Run presubmit checks in the ResultSink environment '
4392 'and send results to the ResultDB database.')
Saagar Sanghavi03b15132020-08-10 16:43:41 +00004393 parser.add_option('--realm', help='LUCI realm if reporting to ResultDB')
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +00004394 parser.add_option('-o',
4395 '--push-options',
4396 action='append',
4397 default=[],
4398 help='Transmit the given string to the server when '
4399 'performing git push (pass-through). See git-push '
4400 'documentation for more details.')
Gregory Nisbet48d9e1e2021-04-15 23:35:54 +00004401 parser.add_option('--no-add-changeid',
4402 action='store_true',
4403 dest='no_add_changeid',
4404 help='Do not add change-ids to messages.')
Sergiy Byelozyorov1aa405f2018-09-18 17:38:43 +00004405
rmistry@google.com2dd99862015-06-22 12:22:18 +00004406 orig_args = args
ukai@chromium.orge8077812012-02-03 03:41:46 +00004407 (options, args) = parser.parse_args(args)
4408
Ng Zhi Ancdaf0be2020-05-27 20:57:28 +00004409 if options.git_completion_helper:
Edward Lesmesb7db1832020-06-22 20:22:27 +00004410 print(' '.join(opt.get_opt_string() for opt in parser.option_list
4411 if opt.help != optparse.SUPPRESS_HELP))
4412 return
Ng Zhi Ancdaf0be2020-05-27 20:57:28 +00004413
sbc@chromium.org71437c02015-04-09 19:29:40 +00004414 if git_common.is_dirty_git_tree('upload'):
ukai@chromium.orge8077812012-02-03 03:41:46 +00004415 return 1
4416
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004417 options.reviewers = cleanup_list(options.reviewers)
Robert Iannucci6c98dc62017-04-18 11:38:00 -07004418 options.tbrs = cleanup_list(options.tbrs)
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004419 options.cc = cleanup_list(options.cc)
4420
Josipe827b0f2020-01-30 00:07:20 +00004421 if options.edit_description and options.force:
4422 parser.error('Only one of --force and --edit-description allowed')
4423
tandriib80458a2016-06-23 12:20:07 -07004424 if options.message_file:
4425 if options.message:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004426 parser.error('Only one of --message and --message-file allowed.')
tandriib80458a2016-06-23 12:20:07 -07004427 options.message = gclient_utils.FileRead(options.message_file)
tandriib80458a2016-06-23 12:20:07 -07004428
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004429 if ([options.cq_dry_run,
Greg Gutermanbe5fccd2021-06-14 17:58:20 +00004430 options.cq_quick_run,
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004431 options.use_commit_queue,
4432 options.retry_failed].count(True) > 1):
Greg Gutermanbe5fccd2021-06-14 17:58:20 +00004433 parser.error('Only one of --use-commit-queue, --cq-dry-run, --cq-quick-run '
4434 'or --retry-failed is allowed.')
tandrii4d0545a2016-07-06 03:56:49 -07004435
Mario Bianuccicebfb4e2020-07-22 23:08:16 +00004436 if options.skip_title and options.title:
4437 parser.error('Only one of --title and --skip-title allowed.')
4438
Aaron Gableedbc4132017-09-11 13:22:28 -07004439 if options.use_commit_queue:
4440 options.send_mail = True
4441
Edward Lesmes0dd54822020-03-26 18:24:25 +00004442 if options.squash is None:
4443 # Load default for user, repo, squash=true, in this order.
4444 options.squash = settings.GetSquashGerritUploads()
4445
Josip Sokcevic1cabb172021-04-08 19:15:35 +00004446 cl = Changelist(branchref=options.target_branch)
Edward Lesmes7677e5c2020-02-19 20:39:03 +00004447 # Warm change details cache now to avoid RPCs later, reducing latency for
4448 # developers.
4449 if cl.GetIssue():
4450 cl._GetChangeDetail(
4451 ['DETAILED_ACCOUNTS', 'CURRENT_REVISION', 'CURRENT_COMMIT', 'LABELS'])
4452
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004453 if options.retry_failed and not cl.GetIssue():
4454 print('No previous patchsets, so --retry-failed has no effect.')
4455 options.retry_failed = False
Edward Lesmes7677e5c2020-02-19 20:39:03 +00004456
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004457 # cl.GetMostRecentPatchset uses cached information, and can return the last
4458 # patchset before upload. Calling it here makes it clear that it's the
4459 # last patchset before upload. Note that GetMostRecentPatchset will fail
4460 # if no CL has been uploaded yet.
4461 if options.retry_failed:
4462 patchset = cl.GetMostRecentPatchset()
Andrii Shyshkalov9f274432018-10-15 16:40:23 +00004463
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004464 ret = cl.CMDUpload(options, args, orig_args)
4465
4466 if options.retry_failed:
4467 if ret != 0:
4468 print('Upload failed, so --retry-failed has no effect.')
4469 return ret
Andrii Shyshkalov1ad58112019-10-08 01:46:14 +00004470 builds, _ = _fetch_latest_builds(
Edward Lemur5b929a42019-10-21 17:57:39 +00004471 cl, options.buildbucket_host, latest_patchset=patchset)
Edward Lemur45768512020-03-02 19:03:14 +00004472 jobs = _filter_failed_for_retry(builds)
4473 if len(jobs) == 0:
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004474 print('No failed tryjobs, so --retry-failed has no effect.')
4475 return ret
Quinten Yearsley777660f2020-03-04 23:37:06 +00004476 _trigger_tryjobs(cl, jobs, options, patchset + 1)
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004477
4478 return ret
ukai@chromium.orge8077812012-02-03 03:41:46 +00004479
4480
Francois Dorayd42c6812017-05-30 15:10:20 -04004481@subcommand.usage('--description=<description file>')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004482@metrics.collector.collect_metrics('git cl split')
Francois Dorayd42c6812017-05-30 15:10:20 -04004483def CMDsplit(parser, args):
4484 """Splits a branch into smaller branches and uploads CLs.
4485
4486 Creates a branch and uploads a CL for each group of files modified in the
4487 current branch that share a common OWNERS file. In the CL description and
Edward Lemurac5c55f2020-02-29 00:17:16 +00004488 comment, the string '$directory', is replaced with the directory containing
4489 the shared OWNERS file.
Francois Dorayd42c6812017-05-30 15:10:20 -04004490 """
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004491 parser.add_option('-d', '--description', dest='description_file',
4492 help='A text file containing a CL description in which '
4493 '$directory will be replaced by each CL\'s directory.')
4494 parser.add_option('-c', '--comment', dest='comment_file',
4495 help='A text file containing a CL comment.')
4496 parser.add_option('-n', '--dry-run', dest='dry_run', action='store_true',
Chris Watkinsba28e462017-12-13 11:22:17 +11004497 default=False,
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004498 help='List the files and reviewers for each CL that would '
4499 'be created, but don\'t create branches or CLs.')
4500 parser.add_option('--cq-dry-run', action='store_true',
4501 help='If set, will do a cq dry run for each uploaded CL. '
4502 'Please be careful when doing this; more than ~10 CLs '
4503 'has the potential to overload our build '
4504 'infrastructure. Try to upload these not during high '
4505 'load times (usually 11-3 Mountain View time). Email '
4506 'infra-dev@chromium.org with any questions.')
Takuto Ikuta51eca592019-02-14 19:40:52 +00004507 parser.add_option('-a', '--enable-auto-submit', action='store_true',
4508 default=True,
4509 help='Sends your change to the CQ after an approval. Only '
4510 'works on repos that have the Auto-Submit label '
4511 'enabled')
Francois Dorayd42c6812017-05-30 15:10:20 -04004512 options, _ = parser.parse_args(args)
4513
4514 if not options.description_file:
4515 parser.error('No --description flag specified.')
4516
4517 def WrappedCMDupload(args):
4518 return CMDupload(OptionParser(), args)
4519
Edward Lemur2c62b332020-03-12 22:12:33 +00004520 return split_cl.SplitCl(
4521 options.description_file, options.comment_file, Changelist,
4522 WrappedCMDupload, options.dry_run, options.cq_dry_run,
4523 options.enable_auto_submit, settings.GetRoot())
Francois Dorayd42c6812017-05-30 15:10:20 -04004524
4525
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004526@subcommand.usage('DEPRECATED')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004527@metrics.collector.collect_metrics('git cl commit')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004528def CMDdcommit(parser, args):
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004529 """DEPRECATED: Used to commit the current changelist via git-svn."""
4530 message = ('git-cl no longer supports committing to SVN repositories via '
4531 'git-svn. You probably want to use `git cl land` instead.')
4532 print(message)
4533 return 1
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004534
4535
maruel@chromium.org0633fb42013-08-16 20:06:14 +00004536@subcommand.usage('[upstream branch to apply against]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004537@metrics.collector.collect_metrics('git cl land')
pgervais@chromium.orgcee6dc42014-05-07 17:04:03 +00004538def CMDland(parser, args):
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004539 """Commits the current changelist via git.
4540
4541 In case of Gerrit, uses Gerrit REST api to "submit" the issue, which pushes
4542 upstream and closes the issue automatically and atomically.
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004543 """
4544 parser.add_option('--bypass-hooks', action='store_true', dest='bypass_hooks',
4545 help='bypass upload presubmit hook')
Aaron Gablef7543cd2017-07-20 14:26:31 -07004546 parser.add_option('-f', '--force', action='store_true', dest='force',
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004547 help="force yes to questions (don't prompt)")
Edward Lesmes67b3faa2018-04-13 17:50:52 -04004548 parser.add_option('--parallel', action='store_true',
4549 help='Run all tests specified by input_api.RunTests in all '
4550 'PRESUBMIT files in parallel.')
Saagar Sanghavi03b15132020-08-10 16:43:41 +00004551 parser.add_option('--resultdb', action='store_true',
4552 help='Run presubmit checks in the ResultSink environment '
4553 'and send results to the ResultDB database.')
4554 parser.add_option('--realm', help='LUCI realm if reporting to ResultDB')
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004555 (options, args) = parser.parse_args(args)
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004556
Edward Lemur934836a2019-09-09 20:16:54 +00004557 cl = Changelist()
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004558
Robert Iannucci2e73d432018-03-14 01:10:47 -07004559 if not cl.GetIssue():
4560 DieWithError('You must upload the change first to Gerrit.\n'
4561 ' If you would rather have `git cl land` upload '
4562 'automatically for you, see http://crbug.com/642759')
Saagar Sanghavi03b15132020-08-10 16:43:41 +00004563 return cl.CMDLand(options.force, options.bypass_hooks, options.verbose,
4564 options.parallel, options.resultdb, options.realm)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004565
4566
dsinclair@chromium.orgfbed6562015-09-25 21:22:36 +00004567@subcommand.usage('<patch url or issue id or issue url>')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004568@metrics.collector.collect_metrics('git cl patch')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004569def CMDpatch(parser, args):
marq@chromium.orge5e59002013-10-02 23:21:25 +00004570 """Patches in a code review."""
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004571 parser.add_option('-b', dest='newbranch',
4572 help='create a new branch off trunk for the patch')
qsr@chromium.org1ef44af2013-10-16 16:24:32 +00004573 parser.add_option('-f', '--force', action='store_true',
Aaron Gable62619a32017-06-16 08:22:09 -07004574 help='overwrite state on the current or chosen branch')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004575 parser.add_option('-n', '--no-commit', action='store_true', dest='nocommit',
Edward Lemurf38bc172019-09-03 21:02:13 +00004576 help='don\'t commit after patch applies.')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004577
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00004578 group = optparse.OptionGroup(
4579 parser,
4580 'Options for continuing work on the current issue uploaded from a '
4581 'different clone (e.g. different machine). Must be used independently '
4582 'from the other options. No issue number should be specified, and the '
4583 'branch must have an issue number associated with it')
4584 group.add_option('--reapply', action='store_true', dest='reapply',
4585 help='Reset the branch and reapply the issue.\n'
4586 'CAUTION: This will undo any local changes in this '
4587 'branch')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004588
4589 group.add_option('--pull', action='store_true', dest='pull',
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00004590 help='Performs a pull before reapplying.')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004591 parser.add_option_group(group)
4592
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004593 (options, args) = parser.parse_args(args)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004594
Andrii Shyshkalov18975322017-01-25 16:44:13 +01004595 if options.reapply:
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004596 if options.newbranch:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004597 parser.error('--reapply works on the current branch only.')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004598 if len(args) > 0:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004599 parser.error('--reapply implies no additional arguments.')
dsinclair@chromium.orgfbed6562015-09-25 21:22:36 +00004600
Edward Lemur934836a2019-09-09 20:16:54 +00004601 cl = Changelist()
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004602 if not cl.GetIssue():
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004603 parser.error('Current branch must have an associated issue.')
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004604
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004605 upstream = cl.GetUpstreamBranch()
Andrii Shyshkalov18975322017-01-25 16:44:13 +01004606 if upstream is None:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004607 parser.error('No upstream branch specified. Cannot reset branch.')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004608
4609 RunGit(['reset', '--hard', upstream])
4610 if options.pull:
4611 RunGit(['pull'])
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004612
Edward Lemur678a6842019-10-03 22:25:05 +00004613 target_issue_arg = ParseIssueNumberArgument(cl.GetIssue())
Bruce Dawsonf362f6f2021-02-18 23:15:17 +00004614 return cl.CMDPatchWithParsedIssue(target_issue_arg, options.nocommit, False,
4615 False)
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004616
4617 if len(args) != 1 or not args[0]:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004618 parser.error('Must specify issue number or URL.')
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004619
Edward Lemurf38bc172019-09-03 21:02:13 +00004620 target_issue_arg = ParseIssueNumberArgument(args[0])
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004621 if not target_issue_arg.valid:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004622 parser.error('Invalid issue ID or URL.')
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004623
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004624 # We don't want uncommitted changes mixed up with the patch.
4625 if git_common.is_dirty_git_tree('patch'):
dsinclair@chromium.orgfbed6562015-09-25 21:22:36 +00004626 return 1
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004627
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004628 if options.newbranch:
4629 if options.force:
4630 RunGit(['branch', '-D', options.newbranch],
4631 stderr=subprocess2.PIPE, error_ok=True)
Edward Lemur84101642020-02-21 21:40:34 +00004632 git_new_branch.create_new_branch(options.newbranch)
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004633
Edward Lemur678a6842019-10-03 22:25:05 +00004634 cl = Changelist(
4635 codereview_host=target_issue_arg.hostname, issue=target_issue_arg.issue)
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004636
Edward Lemur678a6842019-10-03 22:25:05 +00004637 if not args[0].isdigit():
Edward Lemurf38bc172019-09-03 21:02:13 +00004638 print('canonical issue/change URL: %s\n' % cl.GetIssueURL())
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004639
Bruce Dawsonf362f6f2021-02-18 23:15:17 +00004640 return cl.CMDPatchWithParsedIssue(target_issue_arg, options.nocommit,
4641 options.force, options.newbranch)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004642
4643
jochen@chromium.org3ec0d542014-01-14 20:00:03 +00004644def GetTreeStatus(url=None):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004645 """Fetches the tree status and returns either 'open', 'closed',
4646 'unknown' or 'unset'."""
jochen@chromium.org3ec0d542014-01-14 20:00:03 +00004647 url = url or settings.GetTreeStatusUrl(error_ok=True)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004648 if url:
Daniel McArdle8b4eeff2020-07-20 17:02:47 +00004649 status = str(urllib.request.urlopen(url).read().lower())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004650 if status.find('closed') != -1 or status == '0':
4651 return 'closed'
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +00004652
4653 if status.find('open') != -1 or status == '1':
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004654 return 'open'
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +00004655
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004656 return 'unknown'
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004657 return 'unset'
4658
dpranke@chromium.org970c5222011-03-12 00:32:24 +00004659
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004660def GetTreeStatusReason():
4661 """Fetches the tree status from a json url and returns the message
4662 with the reason for the tree to be opened or closed."""
msb@chromium.orgbf1a7ba2011-02-01 16:21:46 +00004663 url = settings.GetTreeStatusUrl()
Daniel McArdle8b4eeff2020-07-20 17:02:47 +00004664 json_url = urllib.parse.urljoin(url, '/current?format=json')
Edward Lemur79d4f992019-11-11 23:49:02 +00004665 connection = urllib.request.urlopen(json_url)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004666 status = json.loads(connection.read())
4667 connection.close()
4668 return status['message']
4669
dpranke@chromium.org970c5222011-03-12 00:32:24 +00004670
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004671@metrics.collector.collect_metrics('git cl tree')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004672def CMDtree(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004673 """Shows the status of the tree."""
dpranke@chromium.org97ae58e2011-03-18 00:29:20 +00004674 _, args = parser.parse_args(args)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004675 status = GetTreeStatus()
4676 if 'unset' == status:
vapiera7fbd5a2016-06-16 09:17:49 -07004677 print('You must configure your tree status URL by running "git cl config".')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004678 return 2
4679
vapiera7fbd5a2016-06-16 09:17:49 -07004680 print('The tree is %s' % status)
4681 print()
4682 print(GetTreeStatusReason())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004683 if status != 'open':
4684 return 1
4685 return 0
4686
4687
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004688@metrics.collector.collect_metrics('git cl try')
maruel@chromium.org15192402012-09-06 12:38:29 +00004689def CMDtry(parser, args):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004690 """Triggers tryjobs using either Buildbucket or CQ dry run."""
4691 group = optparse.OptionGroup(parser, 'Tryjob options')
maruel@chromium.org15192402012-09-06 12:38:29 +00004692 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004693 '-b', '--bot', action='append',
4694 help=('IMPORTANT: specify ONE builder per --bot flag. Use it multiple '
4695 'times to specify multiple builders. ex: '
4696 '"-b win_rel -b win_layout". See '
4697 'the try server waterfall for the builders name and the tests '
4698 'available.'))
maruel@chromium.org15192402012-09-06 12:38:29 +00004699 group.add_option(
borenet6c0efe62016-10-19 08:13:29 -07004700 '-B', '--bucket', default='',
Ben Pastene08a30b22022-05-04 17:46:38 +00004701 help=('Buildbucket bucket to send the try requests. Format: '
4702 '"luci.$LUCI_PROJECT.$LUCI_BUCKET". eg: "luci.chromium.try"'))
borenet6c0efe62016-10-19 08:13:29 -07004703 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004704 '-r', '--revision',
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004705 help='Revision to use for the tryjob; default: the revision will '
tandriif7b29d42016-10-07 08:45:41 -07004706 'be determined by the try recipe that builder runs, which usually '
Josip Sokcevicc39ab992020-09-24 20:09:15 +00004707 'defaults to HEAD of origin/master or origin/main')
maruel@chromium.org15192402012-09-06 12:38:29 +00004708 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004709 '-c', '--clobber', action='store_true', default=False,
tandriif7b29d42016-10-07 08:45:41 -07004710 help='Force a clobber before building; that is don\'t do an '
tandrii1838bad2016-10-06 00:10:52 -07004711 'incremental build')
maruel@chromium.org15192402012-09-06 12:38:29 +00004712 group.add_option(
Greg Gutermanbe5fccd2021-06-14 17:58:20 +00004713 '-q',
4714 '--quick-run',
4715 action='store_true',
4716 default=False,
4717 help='trigger in quick run mode '
4718 '(https://source.chromium.org/chromium/chromium/src/+/main:docs/cq_q'
4719 'uick_run.md) (chromium only).')
4720 group.add_option(
Andrii Shyshkalovf9648b52018-02-21 22:32:42 -08004721 '--category', default='git_cl_try', help='Specify custom build category.')
4722 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004723 '--project',
4724 help='Override which project to use. Projects are defined '
tandriif7b29d42016-10-07 08:45:41 -07004725 'in recipe to determine to which repository or directory to '
4726 'apply the patch')
maruel@chromium.org15192402012-09-06 12:38:29 +00004727 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004728 '-p', '--property', dest='properties', action='append', default=[],
4729 help='Specify generic properties in the form -p key1=value1 -p '
tandriif7b29d42016-10-07 08:45:41 -07004730 'key2=value2 etc. The value will be treated as '
4731 'json if decodable, or as string otherwise. '
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004732 'NOTE: using this may make your tryjob not usable for CQ, '
4733 'which will then schedule another tryjob with default properties')
sheyang@chromium.orgdb375572015-08-17 19:22:23 +00004734 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004735 '--buildbucket-host', default='cr-buildbucket.appspot.com',
4736 help='Host of buildbucket. The default host is %default.')
maruel@chromium.org15192402012-09-06 12:38:29 +00004737 parser.add_option_group(group)
Quinten Yearsley983111f2019-09-26 17:18:48 +00004738 parser.add_option(
4739 '-R', '--retry-failed', action='store_true', default=False,
4740 help='Retry failed jobs from the latest set of tryjobs. '
4741 'Not allowed with --bucket and --bot options.')
Edward Lemur52969c92020-02-06 18:15:28 +00004742 parser.add_option(
4743 '-i', '--issue', type=int,
4744 help='Operate on this issue instead of the current branch\'s implicit '
4745 'issue.')
maruel@chromium.org15192402012-09-06 12:38:29 +00004746 options, args = parser.parse_args(args)
4747
machenbach@chromium.org45453142015-09-15 08:45:22 +00004748 # Make sure that all properties are prop=value pairs.
4749 bad_params = [x for x in options.properties if '=' not in x]
4750 if bad_params:
4751 parser.error('Got properties with missing "=": %s' % bad_params)
4752
maruel@chromium.org15192402012-09-06 12:38:29 +00004753 if args:
4754 parser.error('Unknown arguments: %s' % args)
4755
Edward Lemur934836a2019-09-09 20:16:54 +00004756 cl = Changelist(issue=options.issue)
maruel@chromium.org15192402012-09-06 12:38:29 +00004757 if not cl.GetIssue():
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004758 parser.error('Need to upload first.')
maruel@chromium.org15192402012-09-06 12:38:29 +00004759
Edward Lemurf38bc172019-09-03 21:02:13 +00004760 # HACK: warm up Gerrit change detail cache to save on RPCs.
Edward Lemur125d60a2019-09-13 18:25:41 +00004761 cl._GetChangeDetail(['DETAILED_ACCOUNTS', 'ALL_REVISIONS'])
Andrii Shyshkaloveadad922017-01-26 09:38:30 +01004762
tandriie113dfd2016-10-11 10:20:12 -07004763 error_message = cl.CannotTriggerTryJobReason()
4764 if error_message:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004765 parser.error('Can\'t trigger tryjobs: %s' % error_message)
jrobbins@chromium.org16f10f72014-06-24 22:14:36 +00004766
Edward Lemur45768512020-03-02 19:03:14 +00004767 if options.bot:
4768 if options.retry_failed:
4769 parser.error('--bot is not compatible with --retry-failed.')
4770 if not options.bucket:
4771 parser.error('A bucket (e.g. "chromium/try") is required.')
4772
4773 triggered = [b for b in options.bot if 'triggered' in b]
4774 if triggered:
4775 parser.error(
4776 'Cannot schedule builds on triggered bots: %s.\n'
4777 'This type of bot requires an initial job from a parent (usually a '
4778 'builder). Schedule a job on the parent instead.\n' % triggered)
4779
4780 if options.bucket.startswith('.master'):
4781 parser.error('Buildbot masters are not supported.')
4782
4783 project, bucket = _parse_bucket(options.bucket)
4784 if project is None or bucket is None:
4785 parser.error('Invalid bucket: %s.' % options.bucket)
4786 jobs = sorted((project, bucket, bot) for bot in options.bot)
4787 elif options.retry_failed:
Quinten Yearsley983111f2019-09-26 17:18:48 +00004788 print('Searching for failed tryjobs...')
Edward Lemur5b929a42019-10-21 17:57:39 +00004789 builds, patchset = _fetch_latest_builds(cl, options.buildbucket_host)
Quinten Yearsley983111f2019-09-26 17:18:48 +00004790 if options.verbose:
4791 print('Got %d builds in patchset #%d' % (len(builds), patchset))
Edward Lemur45768512020-03-02 19:03:14 +00004792 jobs = _filter_failed_for_retry(builds)
4793 if not jobs:
Quinten Yearsley983111f2019-09-26 17:18:48 +00004794 print('There are no failed jobs in the latest set of jobs '
4795 '(patchset #%d), doing nothing.' % patchset)
4796 return 0
Edward Lemur45768512020-03-02 19:03:14 +00004797 num_builders = len(jobs)
Quinten Yearsley983111f2019-09-26 17:18:48 +00004798 if num_builders > 10:
4799 confirm_or_exit('There are %d builders with failed builds.'
4800 % num_builders, action='continue')
Greg Gutermanbe5fccd2021-06-14 17:58:20 +00004801 elif options.quick_run:
4802 print('Scheduling CQ quick run on: %s' % cl.GetIssueURL())
4803 return cl.SetCQState(_CQState.QUICK_RUN)
Quinten Yearsley983111f2019-09-26 17:18:48 +00004804 else:
qyearsley1fdfcb62016-10-24 13:22:03 -07004805 if options.verbose:
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07004806 print('git cl try with no bots now defaults to CQ dry run.')
4807 print('Scheduling CQ dry run on: %s' % cl.GetIssueURL())
4808 return cl.SetCQState(_CQState.DRY_RUN)
stip@chromium.org43064fd2013-12-18 20:07:44 +00004809
ilevy@chromium.org36e420b2013-08-06 23:21:12 +00004810 patchset = cl.GetMostRecentPatchset()
Edward Lemur2c210a42019-09-16 23:58:35 +00004811 try:
Quinten Yearsley777660f2020-03-04 23:37:06 +00004812 _trigger_tryjobs(cl, jobs, options, patchset)
Edward Lemur2c210a42019-09-16 23:58:35 +00004813 except BuildbucketResponseException as ex:
4814 print('ERROR: %s' % ex)
4815 return 1
4816 return 0
maruel@chromium.org15192402012-09-06 12:38:29 +00004817
4818
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004819@metrics.collector.collect_metrics('git cl try-results')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004820def CMDtry_results(parser, args):
Quinten Yearsleyd242ed72019-07-25 17:17:55 +00004821 """Prints info about results for tryjobs associated with the current CL."""
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004822 group = optparse.OptionGroup(parser, 'Tryjob results options')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004823 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004824 '-p', '--patchset', type=int, help='patchset number if not current.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004825 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004826 '--print-master', action='store_true', help='print master name as well.')
tandrii@chromium.org6cf98c82016-03-15 11:56:00 +00004827 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004828 '--color', action='store_true', default=setup_color.IS_TTY,
4829 help='force color output, useful when piping output.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004830 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004831 '--buildbucket-host', default='cr-buildbucket.appspot.com',
4832 help='Host of buildbucket. The default host is %default.')
qyearsley53f48a12016-09-01 10:45:13 -07004833 group.add_option(
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004834 '--json', help=('Path of JSON output file to write tryjob results to,'
Stefan Zager1306bd02017-06-22 19:26:46 -07004835 'or "-" for stdout.'))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004836 parser.add_option_group(group)
Edward Lemur52969c92020-02-06 18:15:28 +00004837 parser.add_option(
4838 '-i', '--issue', type=int,
4839 help='Operate on this issue instead of the current branch\'s implicit '
4840 'issue.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004841 options, args = parser.parse_args(args)
4842 if args:
4843 parser.error('Unrecognized args: %s' % ' '.join(args))
4844
Edward Lemur934836a2019-09-09 20:16:54 +00004845 cl = Changelist(issue=options.issue)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004846 if not cl.GetIssue():
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004847 parser.error('Need to upload first.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004848
tandrii221ab252016-10-06 08:12:04 -07004849 patchset = options.patchset
4850 if not patchset:
Gavin Make61ccc52020-11-13 00:12:57 +00004851 patchset = cl.GetMostRecentDryRunPatchset()
tandrii221ab252016-10-06 08:12:04 -07004852 if not patchset:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004853 parser.error('Code review host doesn\'t know about issue %s. '
tandrii221ab252016-10-06 08:12:04 -07004854 'No access to issue or wrong issue number?\n'
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004855 'Either upload first, or pass --patchset explicitly.' %
tandrii221ab252016-10-06 08:12:04 -07004856 cl.GetIssue())
4857
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004858 try:
Quinten Yearsley777660f2020-03-04 23:37:06 +00004859 jobs = _fetch_tryjobs(cl, options.buildbucket_host, patchset)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004860 except BuildbucketResponseException as ex:
vapiera7fbd5a2016-06-16 09:17:49 -07004861 print('Buildbucket error: %s' % ex)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004862 return 1
qyearsley53f48a12016-09-01 10:45:13 -07004863 if options.json:
Edward Lemurbaaf6be2019-10-09 18:00:44 +00004864 write_json(options.json, jobs)
qyearsley53f48a12016-09-01 10:45:13 -07004865 else:
Quinten Yearsley777660f2020-03-04 23:37:06 +00004866 _print_tryjobs(options, jobs)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004867 return 0
4868
4869
maruel@chromium.org0633fb42013-08-16 20:06:14 +00004870@subcommand.usage('[new upstream branch]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004871@metrics.collector.collect_metrics('git cl upstream')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004872def CMDupstream(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004873 """Prints or sets the name of the upstream branch, if any."""
dpranke@chromium.org97ae58e2011-03-18 00:29:20 +00004874 _, args = parser.parse_args(args)
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00004875 if len(args) > 1:
maruel@chromium.org27bb3872011-05-30 20:33:19 +00004876 parser.error('Unrecognized args: %s' % ' '.join(args))
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00004877
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004878 cl = Changelist()
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00004879 if args:
4880 # One arg means set upstream branch.
bauerb@chromium.orgc9cf90a2014-04-28 20:32:31 +00004881 branch = cl.GetBranch()
stip7a3dd352016-09-22 17:32:28 -07004882 RunGit(['branch', '--set-upstream-to', args[0], branch])
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00004883 cl = Changelist()
vapiera7fbd5a2016-06-16 09:17:49 -07004884 print('Upstream branch set to %s' % (cl.GetUpstreamBranch(),))
bauerb@chromium.orgc9cf90a2014-04-28 20:32:31 +00004885
4886 # Clear configured merge-base, if there is one.
4887 git_common.remove_merge_base(branch)
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00004888 else:
vapiera7fbd5a2016-06-16 09:17:49 -07004889 print(cl.GetUpstreamBranch())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004890 return 0
4891
4892
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004893@metrics.collector.collect_metrics('git cl web')
thestig@chromium.org00858c82013-12-02 23:08:03 +00004894def CMDweb(parser, args):
4895 """Opens the current CL in the web browser."""
4896 _, args = parser.parse_args(args)
4897 if args:
4898 parser.error('Unrecognized args: %s' % ' '.join(args))
4899
4900 issue_url = Changelist().GetIssueURL()
4901 if not issue_url:
vapiera7fbd5a2016-06-16 09:17:49 -07004902 print('ERROR No issue to open', file=sys.stderr)
thestig@chromium.org00858c82013-12-02 23:08:03 +00004903 return 1
4904
Sergiy Byelozyorov2b718322018-10-24 17:43:31 +00004905 # Redirect I/O before invoking browser to hide its output. For example, this
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004906 # allows us to hide the "Created new window in existing browser session."
4907 # message from Chrome. Based on https://stackoverflow.com/a/2323563.
Sergiy Byelozyorov2b718322018-10-24 17:43:31 +00004908 saved_stdout = os.dup(1)
Sergiy Belozorov06684032019-03-06 16:53:08 +00004909 saved_stderr = os.dup(2)
Sergiy Byelozyorov2b718322018-10-24 17:43:31 +00004910 os.close(1)
Sergiy Belozorov06684032019-03-06 16:53:08 +00004911 os.close(2)
Sergiy Byelozyorov2b718322018-10-24 17:43:31 +00004912 os.open(os.devnull, os.O_RDWR)
4913 try:
4914 webbrowser.open(issue_url)
4915 finally:
4916 os.dup2(saved_stdout, 1)
Sergiy Belozorov06684032019-03-06 16:53:08 +00004917 os.dup2(saved_stderr, 2)
thestig@chromium.org00858c82013-12-02 23:08:03 +00004918 return 0
4919
4920
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004921@metrics.collector.collect_metrics('git cl set-commit')
maruel@chromium.org27bb3872011-05-30 20:33:19 +00004922def CMDset_commit(parser, args):
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00004923 """Sets the commit bit to trigger the CQ."""
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00004924 parser.add_option('-d', '--dry-run', action='store_true',
4925 help='trigger in dry run mode')
Greg Gutermanbe5fccd2021-06-14 17:58:20 +00004926 parser.add_option(
4927 '-q',
4928 '--quick-run',
4929 action='store_true',
4930 help='trigger in quick run mode '
4931 '(https://source.chromium.org/chromium/chromium/src/+/main:docs/cq_qu'
4932 'ick_run.md) (chromium only).')
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00004933 parser.add_option('-c', '--clear', action='store_true',
4934 help='stop CQ run, if any')
Edward Lemur52969c92020-02-06 18:15:28 +00004935 parser.add_option(
4936 '-i', '--issue', type=int,
4937 help='Operate on this issue instead of the current branch\'s implicit '
4938 'issue.')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004939 options, args = parser.parse_args(args)
maruel@chromium.org27bb3872011-05-30 20:33:19 +00004940 if args:
4941 parser.error('Unrecognized args: %s' % ' '.join(args))
Greg Gutermanbe5fccd2021-06-14 17:58:20 +00004942 if [options.dry_run, options.quick_run, options.clear].count(True) > 1:
4943 parser.error('Only one of --dry-run, --quick-run, and --clear are allowed.')
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00004944
Edward Lemur934836a2019-09-09 20:16:54 +00004945 cl = Changelist(issue=options.issue)
Greg Gutermanbe5fccd2021-06-14 17:58:20 +00004946 if not cl.GetIssue():
4947 parser.error('Must upload the issue first.')
4948
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00004949 if options.clear:
tandriid9e5ce52016-07-13 02:32:59 -07004950 state = _CQState.NONE
Greg Gutermanbe5fccd2021-06-14 17:58:20 +00004951 elif options.quick_run:
4952 state = _CQState.QUICK_RUN
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00004953 elif options.dry_run:
4954 state = _CQState.DRY_RUN
4955 else:
4956 state = _CQState.COMMIT
tandrii9de9ec62016-07-13 03:01:59 -07004957 cl.SetCQState(state)
maruel@chromium.org27bb3872011-05-30 20:33:19 +00004958 return 0
4959
4960
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004961@metrics.collector.collect_metrics('git cl set-close')
groby@chromium.org411034a2013-02-26 15:12:01 +00004962def CMDset_close(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004963 """Closes the issue."""
Edward Lemur52969c92020-02-06 18:15:28 +00004964 parser.add_option(
4965 '-i', '--issue', type=int,
4966 help='Operate on this issue instead of the current branch\'s implicit '
4967 'issue.')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004968 options, args = parser.parse_args(args)
groby@chromium.org411034a2013-02-26 15:12:01 +00004969 if args:
4970 parser.error('Unrecognized args: %s' % ' '.join(args))
Edward Lemur934836a2019-09-09 20:16:54 +00004971 cl = Changelist(issue=options.issue)
groby@chromium.org411034a2013-02-26 15:12:01 +00004972 # Ensure there actually is an issue to close.
Aaron Gable7139a4e2017-09-05 17:53:09 -07004973 if not cl.GetIssue():
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004974 DieWithError('ERROR: No issue to close.')
groby@chromium.org411034a2013-02-26 15:12:01 +00004975 cl.CloseIssue()
4976 return 0
4977
4978
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004979@metrics.collector.collect_metrics('git cl diff')
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00004980def CMDdiff(parser, args):
wychen@chromium.org37b2ec02015-04-03 00:49:15 +00004981 """Shows differences between local tree and last upload."""
thomasanderson074beb22016-08-29 14:03:20 -07004982 parser.add_option(
4983 '--stat',
4984 action='store_true',
4985 dest='stat',
4986 help='Generate a diffstat')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004987 options, args = parser.parse_args(args)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004988 if args:
4989 parser.error('Unrecognized args: %s' % ' '.join(args))
wychen@chromium.org46309bf2015-04-03 21:04:49 +00004990
Edward Lemur934836a2019-09-09 20:16:54 +00004991 cl = Changelist()
sbc@chromium.org78dc9842013-11-25 18:43:44 +00004992 issue = cl.GetIssue()
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00004993 branch = cl.GetBranch()
sbc@chromium.org78dc9842013-11-25 18:43:44 +00004994 if not issue:
4995 DieWithError('No issue found for current branch (%s)' % branch)
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00004996
Aaron Gablea718c3e2017-08-28 17:47:28 -07004997 base = cl._GitGetBranchConfigValue('last-upload-hash')
4998 if not base:
4999 base = cl._GitGetBranchConfigValue('gerritsquashhash')
5000 if not base:
5001 detail = cl._GetChangeDetail(['CURRENT_REVISION', 'CURRENT_COMMIT'])
5002 revision_info = detail['revisions'][detail['current_revision']]
5003 fetch_info = revision_info['fetch']['http']
5004 RunGit(['fetch', fetch_info['url'], fetch_info['ref']])
5005 base = 'FETCH_HEAD'
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00005006
Aaron Gablea718c3e2017-08-28 17:47:28 -07005007 cmd = ['git', 'diff']
5008 if options.stat:
5009 cmd.append('--stat')
5010 cmd.append(base)
5011 subprocess2.check_call(cmd)
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00005012
5013 return 0
5014
5015
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005016@metrics.collector.collect_metrics('git cl owners')
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005017def CMDowners(parser, args):
Dirk Prankebf980882017-09-02 15:08:00 -07005018 """Finds potential owners for reviewing."""
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005019 parser.add_option(
Sidney San Martín8e6f58c2018-06-08 01:02:56 +00005020 '--ignore-current',
5021 action='store_true',
5022 help='Ignore the CL\'s current reviewers and start from scratch.')
5023 parser.add_option(
Sylvain Defresneb1f865d2019-02-12 12:38:22 +00005024 '--ignore-self',
5025 action='store_true',
5026 help='Do not consider CL\'s author as an owners.')
5027 parser.add_option(
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005028 '--no-color',
5029 action='store_true',
5030 help='Use this option to disable color output')
Dirk Prankebf980882017-09-02 15:08:00 -07005031 parser.add_option(
5032 '--batch',
5033 action='store_true',
5034 help='Do not run interactively, just suggest some')
Yang Guo6e269a02019-06-26 11:17:02 +00005035 # TODO: Consider moving this to another command, since other
5036 # git-cl owners commands deal with owners for a given CL.
5037 parser.add_option(
5038 '--show-all',
5039 action='store_true',
5040 help='Show all owners for a particular file')
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005041 options, args = parser.parse_args(args)
5042
Edward Lemur934836a2019-09-09 20:16:54 +00005043 cl = Changelist()
Edward Lesmes50da7702020-03-30 19:23:43 +00005044 author = cl.GetAuthor()
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005045
Yang Guo6e269a02019-06-26 11:17:02 +00005046 if options.show_all:
Bruce Dawson97ed44a2020-05-06 17:04:03 +00005047 if len(args) == 0:
5048 print('No files specified for --show-all. Nothing to do.')
5049 return 0
Edward Lesmese1576912021-02-16 21:53:34 +00005050 owners_by_path = cl.owners_client.BatchListOwners(args)
Edward Lesmes0e4e5ae2021-01-08 18:28:46 +00005051 for path in args:
5052 print('Owners for %s:' % path)
5053 print('\n'.join(
5054 ' - %s' % owner
5055 for owner in owners_by_path.get(path, ['No owners found'])))
Yang Guo6e269a02019-06-26 11:17:02 +00005056 return 0
5057
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005058 if args:
5059 if len(args) > 1:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00005060 parser.error('Unknown args.')
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005061 base_branch = args[0]
5062 else:
5063 # Default to diffing against the common ancestor of the upstream branch.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00005064 base_branch = cl.GetCommonAncestorWithUpstream()
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005065
Edward Lemur2c62b332020-03-12 22:12:33 +00005066 affected_files = cl.GetAffectedFiles(base_branch)
Dirk Prankebf980882017-09-02 15:08:00 -07005067
5068 if options.batch:
Edward Lesmese1576912021-02-16 21:53:34 +00005069 owners = cl.owners_client.SuggestOwners(affected_files, exclude=[author])
5070 print('\n'.join(owners))
Dirk Prankebf980882017-09-02 15:08:00 -07005071 return 0
5072
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005073 return owners_finder.OwnersFinder(
Dirk Prankebf980882017-09-02 15:08:00 -07005074 affected_files,
Edward Lemur707d70b2018-02-07 00:50:14 +01005075 author,
Sidney San Martín8e6f58c2018-06-08 01:02:56 +00005076 [] if options.ignore_current else cl.GetReviewers(),
Edward Lesmes5cd75472021-02-19 00:34:25 +00005077 cl.owners_client,
Jochen Eisingerd0573ec2017-04-13 10:55:06 +02005078 disable_color=options.no_color,
Sylvain Defresneb1f865d2019-02-12 12:38:22 +00005079 ignore_author=options.ignore_self).run()
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005080
5081
Aiden Bennerc08566e2018-10-03 17:52:42 +00005082def BuildGitDiffCmd(diff_type, upstream_commit, args, allow_prefix=False):
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005083 """Generates a diff command."""
5084 # Generate diff for the current branch's changes.
Aiden Bennerc08566e2018-10-03 17:52:42 +00005085 diff_cmd = ['-c', 'core.quotePath=false', 'diff', '--no-ext-diff']
5086
Aiden Benner6c18a1a2018-11-23 20:18:23 +00005087 if allow_prefix:
5088 # explicitly setting --src-prefix and --dst-prefix is necessary in the
5089 # case that diff.noprefix is set in the user's git config.
5090 diff_cmd += ['--src-prefix=a/', '--dst-prefix=b/']
5091 else:
Aiden Bennerc08566e2018-10-03 17:52:42 +00005092 diff_cmd += ['--no-prefix']
5093
5094 diff_cmd += [diff_type, upstream_commit, '--']
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005095
5096 if args:
5097 for arg in args:
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005098 if os.path.isdir(arg) or os.path.isfile(arg):
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005099 diff_cmd.append(arg)
5100 else:
5101 DieWithError('Argument "%s" is not a file or a directory' % arg)
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005102
5103 return diff_cmd
5104
Andrii Shyshkalov18975322017-01-25 16:44:13 +01005105
Jamie Madill5e96ad12020-01-13 16:08:35 +00005106def _RunClangFormatDiff(opts, clang_diff_files, top_dir, upstream_commit):
5107 """Runs clang-format-diff and sets a return value if necessary."""
5108
5109 if not clang_diff_files:
5110 return 0
5111
5112 # Set to 2 to signal to CheckPatchFormatted() that this patch isn't
5113 # formatted. This is used to block during the presubmit.
5114 return_value = 0
5115
5116 # Locate the clang-format binary in the checkout
5117 try:
5118 clang_format_tool = clang_format.FindClangFormatToolInChromiumTree()
5119 except clang_format.NotFoundError as e:
5120 DieWithError(e)
5121
5122 if opts.full or settings.GetFormatFullByDefault():
5123 cmd = [clang_format_tool]
5124 if not opts.dry_run and not opts.diff:
5125 cmd.append('-i')
5126 if opts.dry_run:
5127 for diff_file in clang_diff_files:
5128 with open(diff_file, 'r') as myfile:
5129 code = myfile.read().replace('\r\n', '\n')
5130 stdout = RunCommand(cmd + [diff_file], cwd=top_dir)
5131 stdout = stdout.replace('\r\n', '\n')
5132 if opts.diff:
5133 sys.stdout.write(stdout)
5134 if code != stdout:
5135 return_value = 2
5136 else:
5137 stdout = RunCommand(cmd + clang_diff_files, cwd=top_dir)
5138 if opts.diff:
5139 sys.stdout.write(stdout)
5140 else:
Jamie Madill5e96ad12020-01-13 16:08:35 +00005141 try:
5142 script = clang_format.FindClangFormatScriptInChromiumTree(
5143 'clang-format-diff.py')
5144 except clang_format.NotFoundError as e:
5145 DieWithError(e)
5146
Josip Sokcevic2a827fc2022-03-04 17:51:47 +00005147 cmd = ['vpython3', script, '-p0']
Jamie Madill5e96ad12020-01-13 16:08:35 +00005148 if not opts.dry_run and not opts.diff:
5149 cmd.append('-i')
5150
5151 diff_cmd = BuildGitDiffCmd('-U0', upstream_commit, clang_diff_files)
Edward Lemur1a83da12020-03-04 21:18:36 +00005152 diff_output = RunGit(diff_cmd).encode('utf-8')
Jamie Madill5e96ad12020-01-13 16:08:35 +00005153
Edward Lesmes89624cd2020-04-06 17:51:56 +00005154 env = os.environ.copy()
5155 env['PATH'] = (
5156 str(os.path.dirname(clang_format_tool)) + os.pathsep + env['PATH'])
5157 stdout = RunCommand(
5158 cmd, stdin=diff_output, cwd=top_dir, env=env,
Ilya Sherman7aed4bb2020-05-20 22:34:14 +00005159 shell=sys.platform.startswith('win32'))
Jamie Madill5e96ad12020-01-13 16:08:35 +00005160 if opts.diff:
5161 sys.stdout.write(stdout)
5162 if opts.dry_run and len(stdout) > 0:
5163 return_value = 2
5164
5165 return return_value
5166
5167
Lukasz Anforowiczb4d39542021-09-30 23:39:25 +00005168def _RunRustFmt(opts, rust_diff_files, top_dir, upstream_commit):
5169 """Runs rustfmt. Just like _RunClangFormatDiff returns 2 to indicate that
5170 presubmit checks have failed (and returns 0 otherwise)."""
5171
5172 if not rust_diff_files:
5173 return 0
5174
5175 # Locate the rustfmt binary.
5176 try:
5177 rustfmt_tool = rustfmt.FindRustfmtToolInChromiumTree()
5178 except rustfmt.NotFoundError as e:
5179 DieWithError(e)
5180
5181 # TODO(crbug.com/1231317): Support formatting only the changed lines
5182 # if `opts.full or settings.GetFormatFullByDefault()` is False. See also:
5183 # https://github.com/emilio/rustfmt-format-diff
5184 cmd = [rustfmt_tool]
5185 if opts.dry_run:
5186 cmd.append('--check')
5187 cmd += rust_diff_files
5188 rustfmt_exitcode = subprocess2.call(cmd)
5189
5190 if opts.presubmit and rustfmt_exitcode != 0:
5191 return 2
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +00005192
5193 return 0
Lukasz Anforowiczb4d39542021-09-30 23:39:25 +00005194
5195
Olivier Robin0a6b5442022-04-07 07:25:04 +00005196def _RunSwiftFormat(opts, swift_diff_files, top_dir, upstream_commit):
5197 """Runs swift-format. Just like _RunClangFormatDiff returns 2 to indicate
5198 that presubmit checks have failed (and returns 0 otherwise)."""
5199
5200 if not swift_diff_files:
5201 return 0
5202
5203 # Locate the swift-format binary.
5204 try:
5205 swift_format_tool = swift_format.FindSwiftFormatToolInChromiumTree()
5206 except swift_format.NotFoundError as e:
5207 DieWithError(e)
5208
5209 cmd = [swift_format_tool]
5210 if opts.dry_run:
Olivier Robin7f39e3d2022-04-28 08:20:49 +00005211 cmd += ['lint', '-s']
Olivier Robin0a6b5442022-04-07 07:25:04 +00005212 else:
5213 cmd += ['format', '-i']
5214 cmd += swift_diff_files
5215 swift_format_exitcode = subprocess2.call(cmd)
5216
5217 if opts.presubmit and swift_format_exitcode != 0:
5218 return 2
5219
5220 return 0
5221
5222
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005223def MatchingFileType(file_name, extensions):
Quinten Yearsleyd242ed72019-07-25 17:17:55 +00005224 """Returns True if the file name ends with one of the given extensions."""
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005225 return bool([ext for ext in extensions if file_name.lower().endswith(ext)])
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005226
Andrii Shyshkalov18975322017-01-25 16:44:13 +01005227
enne@chromium.org555cfe42014-01-29 18:21:39 +00005228@subcommand.usage('[files or directories to diff]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005229@metrics.collector.collect_metrics('git cl format')
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005230def CMDformat(parser, args):
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00005231 """Runs auto-formatting tools (clang-format etc.) on the diff."""
Christopher Lamc5ba6922017-01-24 11:19:14 +11005232 CLANG_EXTS = ['.cc', '.cpp', '.h', '.m', '.mm', '.proto', '.java']
kylechar58edce22016-06-17 06:07:51 -07005233 GN_EXTS = ['.gn', '.gni', '.typemap']
Lukasz Anforowiczb4d39542021-09-30 23:39:25 +00005234 RUST_EXTS = ['.rs']
Olivier Robin0a6b5442022-04-07 07:25:04 +00005235 SWIFT_EXTS = ['.swift']
enne@chromium.org3b7e15c2014-01-21 17:44:47 +00005236 parser.add_option('--full', action='store_true',
5237 help='Reformat the full content of all touched files')
Tomasz Åšniatowski58194462021-08-27 17:36:16 +00005238 parser.add_option('--upstream', help='Branch to check against')
enne@chromium.org3b7e15c2014-01-21 17:44:47 +00005239 parser.add_option('--dry-run', action='store_true',
5240 help='Don\'t modify any file on disk.')
Aiden Benner99b0ccb2018-11-20 19:53:31 +00005241 parser.add_option(
Garrett Beatyed0cc5f2020-01-06 17:26:13 +00005242 '--no-clang-format',
5243 dest='clang_format',
5244 action='store_false',
5245 default=True,
5246 help='Disables formatting of various file types using clang-format.')
5247 parser.add_option(
Aiden Benner99b0ccb2018-11-20 19:53:31 +00005248 '--python',
5249 action='store_true',
5250 default=None,
5251 help='Enables python formatting on all python files.')
5252 parser.add_option(
5253 '--no-python',
5254 action='store_true',
Garrett Beaty91a6f332020-01-06 16:57:24 +00005255 default=False,
Aiden Benner99b0ccb2018-11-20 19:53:31 +00005256 help='Disables python formatting on all python files. '
Garrett Beaty91a6f332020-01-06 16:57:24 +00005257 'If neither --python or --no-python are set, python files that have a '
5258 '.style.yapf file in an ancestor directory will be formatted. '
5259 'It is an error to set both.')
Garrett Beatyed0cc5f2020-01-06 17:26:13 +00005260 parser.add_option(
5261 '--js',
5262 action='store_true',
5263 help='Format javascript code with clang-format. '
5264 'Has no effect if --no-clang-format is set.')
wittman@chromium.org04d5a222014-03-07 18:30:42 +00005265 parser.add_option('--diff', action='store_true',
5266 help='Print diff to stdout rather than modifying files.')
Ilya Shermane081cbe2017-08-15 17:51:04 -07005267 parser.add_option('--presubmit', action='store_true',
5268 help='Used when running the script from a presubmit.')
Lukasz Anforowiczb4d39542021-09-30 23:39:25 +00005269
5270 parser.add_option('--rust-fmt',
5271 dest='use_rust_fmt',
5272 action='store_true',
5273 default=rustfmt.IsRustfmtSupported(),
5274 help='Enables formatting of Rust file types using rustfmt.')
5275 parser.add_option(
5276 '--no-rust-fmt',
5277 dest='use_rust_fmt',
5278 action='store_false',
5279 help='Disables formatting of Rust file types using rustfmt.')
5280
Olivier Robin0a6b5442022-04-07 07:25:04 +00005281 parser.add_option(
5282 '--swift-format',
5283 dest='use_swift_format',
5284 action='store_true',
Olivier Robin7f39e3d2022-04-28 08:20:49 +00005285 default=swift_format.IsSwiftFormatSupported(),
Olivier Robin0a6b5442022-04-07 07:25:04 +00005286 help='Enables formatting of Swift file types using swift-format '
5287 '(macOS host only).')
5288 parser.add_option(
5289 '--no-swift-format',
5290 dest='use_swift_format',
5291 action='store_false',
5292 help='Disables formatting of Swift file types using swift-format.')
5293
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005294 opts, args = parser.parse_args(args)
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005295
Garrett Beaty91a6f332020-01-06 16:57:24 +00005296 if opts.python is not None and opts.no_python:
5297 raise parser.error('Cannot set both --python and --no-python')
5298 if opts.no_python:
5299 opts.python = False
5300
Daniel Chengc55eecf2016-12-30 03:11:02 -08005301 # Normalize any remaining args against the current path, so paths relative to
5302 # the current directory are still resolved as expected.
5303 args = [os.path.join(os.getcwd(), arg) for arg in args]
5304
enne@chromium.orgff7a1fb2013-12-10 19:21:41 +00005305 # git diff generates paths against the root of the repository. Change
5306 # to that directory so clang-format can find files even within subdirs.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00005307 rel_base_path = settings.GetRelativeRoot()
enne@chromium.orgff7a1fb2013-12-10 19:21:41 +00005308 if rel_base_path:
5309 os.chdir(rel_base_path)
5310
digit@chromium.org29e47272013-05-17 17:01:46 +00005311 # Grab the merge-base commit, i.e. the upstream commit of the current
5312 # branch when it was created or the last time it was rebased. This is
5313 # to cover the case where the user may have called "git fetch origin",
5314 # moving the origin branch to a newer commit, but hasn't rebased yet.
5315 upstream_commit = None
Tomasz Åšniatowski58194462021-08-27 17:36:16 +00005316 upstream_branch = opts.upstream
5317 if not upstream_branch:
5318 cl = Changelist()
5319 upstream_branch = cl.GetUpstreamBranch()
digit@chromium.org29e47272013-05-17 17:01:46 +00005320 if upstream_branch:
5321 upstream_commit = RunGit(['merge-base', 'HEAD', upstream_branch])
5322 upstream_commit = upstream_commit.strip()
5323
5324 if not upstream_commit:
5325 DieWithError('Could not find base commit for this branch. '
5326 'Are you in detached state?')
5327
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005328 changed_files_cmd = BuildGitDiffCmd('--name-only', upstream_commit, args)
5329 diff_output = RunGit(changed_files_cmd)
5330 diff_files = diff_output.splitlines()
jkarlin@chromium.orgad21b922016-01-28 17:48:42 +00005331 # Filter out files deleted by this CL
5332 diff_files = [x for x in diff_files if os.path.isfile(x)]
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005333
Andreas Haas417d89c2020-02-06 10:24:27 +00005334 if opts.js:
Deepanjan Roy605dd312018-07-02 17:48:54 +00005335 CLANG_EXTS.extend(['.js', '.ts'])
Christopher Lamc5ba6922017-01-24 11:19:14 +11005336
Garrett Beatyed0cc5f2020-01-06 17:26:13 +00005337 clang_diff_files = []
5338 if opts.clang_format:
5339 clang_diff_files = [
5340 x for x in diff_files if MatchingFileType(x, CLANG_EXTS)
5341 ]
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005342 python_diff_files = [x for x in diff_files if MatchingFileType(x, ['.py'])]
Lukasz Anforowiczb4d39542021-09-30 23:39:25 +00005343 rust_diff_files = [x for x in diff_files if MatchingFileType(x, RUST_EXTS)]
Olivier Robin0a6b5442022-04-07 07:25:04 +00005344 swift_diff_files = [x for x in diff_files if MatchingFileType(x, SWIFT_EXTS)]
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00005345 gn_diff_files = [x for x in diff_files if MatchingFileType(x, GN_EXTS)]
digit@chromium.org29e47272013-05-17 17:01:46 +00005346
Edward Lesmes50da7702020-03-30 19:23:43 +00005347 top_dir = settings.GetRoot()
nick@chromium.org3ac1c4e2014-01-16 02:44:42 +00005348
Jamie Madill5e96ad12020-01-13 16:08:35 +00005349 return_value = _RunClangFormatDiff(opts, clang_diff_files, top_dir,
5350 upstream_commit)
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005351
Lukasz Anforowiczb4d39542021-09-30 23:39:25 +00005352 if opts.use_rust_fmt:
5353 rust_fmt_return_value = _RunRustFmt(opts, rust_diff_files, top_dir,
5354 upstream_commit)
5355 if rust_fmt_return_value == 2:
5356 return_value = 2
5357
Olivier Robin0a6b5442022-04-07 07:25:04 +00005358 if opts.use_swift_format:
5359 if sys.platform != 'darwin':
5360 DieWithError('swift-format is only supported on macOS.')
5361 swift_format_return_value = _RunSwiftFormat(opts, swift_diff_files, top_dir,
5362 upstream_commit)
5363 if swift_format_return_value == 2:
5364 return_value = 2
5365
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00005366 # Similar code to above, but using yapf on .py files rather than clang-format
5367 # on C/C++ files
Aiden Benner99b0ccb2018-11-20 19:53:31 +00005368 py_explicitly_disabled = opts.python is not None and not opts.python
5369 if python_diff_files and not py_explicitly_disabled:
Aiden Bennere47ac152018-11-20 16:44:03 +00005370 depot_tools_path = os.path.dirname(os.path.abspath(__file__))
5371 yapf_tool = os.path.join(depot_tools_path, 'yapf')
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00005372
Aiden Bennerc08566e2018-10-03 17:52:42 +00005373 # Used for caching.
5374 yapf_configs = {}
5375 for f in python_diff_files:
5376 # Find the yapf style config for the current file, defaults to depot
5377 # tools default.
Aiden Benner99b0ccb2018-11-20 19:53:31 +00005378 _FindYapfConfigFile(f, yapf_configs, top_dir)
5379
5380 # Turn on python formatting by default if a yapf config is specified.
5381 # This breaks in the case of this repo though since the specified
5382 # style file is also the global default.
5383 if opts.python is None:
5384 filtered_py_files = []
5385 for f in python_diff_files:
5386 if _FindYapfConfigFile(f, yapf_configs, top_dir) is not None:
5387 filtered_py_files.append(f)
5388 else:
5389 filtered_py_files = python_diff_files
5390
5391 # Note: yapf still seems to fix indentation of the entire file
5392 # even if line ranges are specified.
5393 # See https://github.com/google/yapf/issues/499
5394 if not opts.full and filtered_py_files:
5395 py_line_diffs = _ComputeDiffLineRanges(filtered_py_files, upstream_commit)
5396
Brian Sheedyb4307d52019-12-02 19:18:17 +00005397 yapfignore_patterns = _GetYapfIgnorePatterns(top_dir)
5398 filtered_py_files = _FilterYapfIgnoredFiles(filtered_py_files,
5399 yapfignore_patterns)
Brian Sheedy59b06a82019-10-14 17:03:29 +00005400
Aiden Benner99b0ccb2018-11-20 19:53:31 +00005401 for f in filtered_py_files:
Andrew Grievefa40bfa2020-01-07 02:32:57 +00005402 yapf_style = _FindYapfConfigFile(f, yapf_configs, top_dir)
5403 # Default to pep8 if not .style.yapf is found.
5404 if not yapf_style:
5405 yapf_style = 'pep8'
Aiden Bennerc08566e2018-10-03 17:52:42 +00005406
Peter Wend9399922020-06-17 17:33:49 +00005407 with open(f, 'r') as py_f:
Andrew Grieveb9e694c2021-11-15 19:04:46 +00005408 if 'python2' in py_f.readline():
Peter Wend9399922020-06-17 17:33:49 +00005409 vpython_script = 'vpython'
Andrew Grieveb9e694c2021-11-15 19:04:46 +00005410 else:
5411 vpython_script = 'vpython3'
Peter Wend9399922020-06-17 17:33:49 +00005412
5413 cmd = [vpython_script, yapf_tool, '--style', yapf_style, f]
Aiden Bennerc08566e2018-10-03 17:52:42 +00005414
5415 has_formattable_lines = False
5416 if not opts.full:
5417 # Only run yapf over changed line ranges.
5418 for diff_start, diff_len in py_line_diffs[f]:
5419 diff_end = diff_start + diff_len - 1
5420 # Yapf errors out if diff_end < diff_start but this
5421 # is a valid line range diff for a removal.
5422 if diff_end >= diff_start:
5423 has_formattable_lines = True
5424 cmd += ['-l', '{}-{}'.format(diff_start, diff_end)]
5425 # If all line diffs were removals we have nothing to format.
5426 if not has_formattable_lines:
5427 continue
5428
5429 if opts.diff or opts.dry_run:
5430 cmd += ['--diff']
5431 # Will return non-zero exit code if non-empty diff.
Edward Lesmesb7db1832020-06-22 20:22:27 +00005432 stdout = RunCommand(cmd,
5433 error_ok=True,
Josip Sokcevic673e8ed2021-10-27 23:46:18 +00005434 stderr=subprocess2.PIPE,
Edward Lesmesb7db1832020-06-22 20:22:27 +00005435 cwd=top_dir,
5436 shell=sys.platform.startswith('win32'))
Aiden Bennerc08566e2018-10-03 17:52:42 +00005437 if opts.diff:
5438 sys.stdout.write(stdout)
5439 elif len(stdout) > 0:
5440 return_value = 2
5441 else:
5442 cmd += ['-i']
Edward Lesmesb7db1832020-06-22 20:22:27 +00005443 RunCommand(cmd, cwd=top_dir, shell=sys.platform.startswith('win32'))
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00005444
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00005445 # Format GN build files. Always run on full build files for canonical form.
5446 if gn_diff_files:
Andrii Shyshkalov18975322017-01-25 16:44:13 +01005447 cmd = ['gn', 'format']
brettw4b8ed592016-08-05 16:19:12 -07005448 if opts.dry_run or opts.diff:
5449 cmd.append('--dry-run')
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00005450 for gn_diff_file in gn_diff_files:
brettw4b8ed592016-08-05 16:19:12 -07005451 gn_ret = subprocess2.call(cmd + [gn_diff_file],
Ilya Sherman7aed4bb2020-05-20 22:34:14 +00005452 shell=sys.platform.startswith('win'),
brettw4b8ed592016-08-05 16:19:12 -07005453 cwd=top_dir)
5454 if opts.dry_run and gn_ret == 2:
5455 return_value = 2 # Not formatted.
5456 elif opts.diff and gn_ret == 2:
5457 # TODO this should compute and print the actual diff.
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005458 print('This change has GN build file diff for ' + gn_diff_file)
brettw4b8ed592016-08-05 16:19:12 -07005459 elif gn_ret != 0:
5460 # For non-dry run cases (and non-2 return values for dry-run), a
5461 # nonzero error code indicates a failure, probably because the file
5462 # doesn't parse.
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005463 DieWithError('gn format failed on ' + gn_diff_file +
5464 '\nTry running `gn format` on this file manually.')
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00005465
Ilya Shermane081cbe2017-08-15 17:51:04 -07005466 # Skip the metrics formatting from the global presubmit hook. These files have
5467 # a separate presubmit hook that issues an error if the files need formatting,
5468 # whereas the top-level presubmit script merely issues a warning. Formatting
5469 # these files is somewhat slow, so it's important not to duplicate the work.
5470 if not opts.presubmit:
Wenhan (Han) Zhang3bd3c992020-08-14 16:27:39 +00005471 for diff_xml in GetDiffXMLs(diff_files):
5472 xml_dir = GetMetricsDir(diff_xml)
5473 if not xml_dir:
5474 continue
5475
Ilya Shermane081cbe2017-08-15 17:51:04 -07005476 tool_dir = os.path.join(top_dir, xml_dir)
Ilya Sherman7aed4bb2020-05-20 22:34:14 +00005477 pretty_print_tool = os.path.join(tool_dir, 'pretty_print.py')
Fabrice de Gansecfab092022-09-15 20:59:01 +00005478 cmd = ['vpython3', pretty_print_tool, '--non-interactive']
Wenhan (Han) Zhang3bd3c992020-08-14 16:27:39 +00005479
5480 # If the XML file is histograms.xml or enums.xml, add the xml path to the
5481 # command as histograms/pretty_print.py now needs a relative path argument
5482 # after splitting the histograms into multiple directories.
5483 # For example, in tools/metrics/ukm, pretty-print could be run using:
5484 # $ python pretty_print.py
5485 # But in tools/metrics/histogrmas, pretty-print should be run with an
5486 # additional relative path argument, like:
Peter Kastingee088882021-08-03 17:57:00 +00005487 # $ python pretty_print.py metadata/UMA/histograms.xml
Wenhan (Han) Zhang3bd3c992020-08-14 16:27:39 +00005488 # $ python pretty_print.py enums.xml
5489
5490 # TODO (crbug/1116488): Remove this check after ensuring that the updated
5491 # version of histograms/pretty_print.py is released.
5492 filepath_required = os.path.exists(
5493 os.path.join(tool_dir, 'validate_prefix.py'))
5494
Weilun Shib92c4b72020-08-27 17:45:11 +00005495 if (diff_xml.endswith('histograms.xml') or diff_xml.endswith('enums.xml')
5496 or diff_xml.endswith('histogram_suffixes_list.xml')
5497 ) and filepath_required:
Wenhan (Han) Zhang3bd3c992020-08-14 16:27:39 +00005498 cmd.append(diff_xml)
5499
Ilya Shermane081cbe2017-08-15 17:51:04 -07005500 if opts.dry_run or opts.diff:
5501 cmd.append('--diff')
Wenhan (Han) Zhang3bd3c992020-08-14 16:27:39 +00005502
Ilya Sherman7aed4bb2020-05-20 22:34:14 +00005503 # TODO(isherman): Once this file runs only on Python 3.3+, drop the
5504 # `shell` param and instead replace `'vpython'` with
5505 # `shutil.which('frob')` above: https://stackoverflow.com/a/32799942
Wenhan (Han) Zhang3bd3c992020-08-14 16:27:39 +00005506 stdout = RunCommand(cmd,
5507 cwd=top_dir,
Ilya Sherman7aed4bb2020-05-20 22:34:14 +00005508 shell=sys.platform.startswith('win32'))
Ilya Shermane081cbe2017-08-15 17:51:04 -07005509 if opts.diff:
5510 sys.stdout.write(stdout)
5511 if opts.dry_run and stdout:
5512 return_value = 2 # Not formatted.
Alexei Svitkinef3cac412017-02-06 11:08:50 -05005513
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005514 return return_value
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005515
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005516
Wenhan (Han) Zhang3bd3c992020-08-14 16:27:39 +00005517def GetDiffXMLs(diff_files):
5518 return [
5519 os.path.normpath(x) for x in diff_files if MatchingFileType(x, ['.xml'])
5520 ]
5521
5522
5523def GetMetricsDir(diff_xml):
Steven Holte2e664bf2017-04-21 13:10:47 -07005524 metrics_xml_dirs = [
5525 os.path.join('tools', 'metrics', 'actions'),
5526 os.path.join('tools', 'metrics', 'histograms'),
5527 os.path.join('tools', 'metrics', 'rappor'),
Ilya Shermanb67e60c2020-05-20 22:27:03 +00005528 os.path.join('tools', 'metrics', 'structured'),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005529 os.path.join('tools', 'metrics', 'ukm'),
5530 ]
Steven Holte2e664bf2017-04-21 13:10:47 -07005531 for xml_dir in metrics_xml_dirs:
Wenhan (Han) Zhang3bd3c992020-08-14 16:27:39 +00005532 if diff_xml.startswith(xml_dir):
5533 return xml_dir
5534 return None
Steven Holte2e664bf2017-04-21 13:10:47 -07005535
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005536
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005537@subcommand.usage('<codereview url or issue id>')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005538@metrics.collector.collect_metrics('git cl checkout')
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005539def CMDcheckout(parser, args):
Edward Lemurf38bc172019-09-03 21:02:13 +00005540 """Checks out a branch associated with a given Gerrit issue."""
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005541 _, args = parser.parse_args(args)
5542
5543 if len(args) != 1:
5544 parser.print_help()
5545 return 1
5546
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00005547 issue_arg = ParseIssueNumberArgument(args[0])
tandrii@chromium.orgde6c9a12016-04-11 15:33:53 +00005548 if not issue_arg.valid:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00005549 parser.error('Invalid issue ID or URL.')
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02005550
tandrii@chromium.orgabd27e52016-04-11 15:43:32 +00005551 target_issue = str(issue_arg.issue)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005552
Edward Lemur52969c92020-02-06 18:15:28 +00005553 output = RunGit(['config', '--local', '--get-regexp',
Edward Lesmes50da7702020-03-30 19:23:43 +00005554 r'branch\..*\.' + ISSUE_CONFIG_KEY],
Edward Lemur52969c92020-02-06 18:15:28 +00005555 error_ok=True)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005556
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00005557 branches = []
Edward Lemur52969c92020-02-06 18:15:28 +00005558 for key, issue in [x.split() for x in output.splitlines()]:
5559 if issue == target_issue:
Edward Lesmes50da7702020-03-30 19:23:43 +00005560 branches.append(re.sub(r'branch\.(.*)\.' + ISSUE_CONFIG_KEY, r'\1', key))
Edward Lemur52969c92020-02-06 18:15:28 +00005561
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005562 if len(branches) == 0:
vapiera7fbd5a2016-06-16 09:17:49 -07005563 print('No branch found for issue %s.' % target_issue)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005564 return 1
5565 if len(branches) == 1:
5566 RunGit(['checkout', branches[0]])
5567 else:
vapiera7fbd5a2016-06-16 09:17:49 -07005568 print('Multiple branches match issue %s:' % target_issue)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005569 for i in range(len(branches)):
vapiera7fbd5a2016-06-16 09:17:49 -07005570 print('%d: %s' % (i, branches[i]))
Edward Lesmesae3586b2020-03-23 21:21:14 +00005571 which = gclient_utils.AskForData('Choose by index: ')
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005572 try:
5573 RunGit(['checkout', branches[int(which)]])
5574 except (IndexError, ValueError):
vapiera7fbd5a2016-06-16 09:17:49 -07005575 print('Invalid selection, not checking out any branch.')
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005576 return 1
5577
5578 return 0
5579
5580
maruel@chromium.org29404b52014-09-08 22:58:00 +00005581def CMDlol(parser, args):
5582 # This command is intentionally undocumented.
vapiera7fbd5a2016-06-16 09:17:49 -07005583 print(zlib.decompress(base64.b64decode(
thakis@chromium.org3421c992014-11-02 02:20:32 +00005584 'eNptkLEOwyAMRHe+wupCIqW57v0Vq84WqWtXyrcXnCBsmgMJ+/SSAxMZgRB6NzE'
5585 'E2ObgCKJooYdu4uAQVffUEoE1sRQLxAcqzd7uK2gmStrll1ucV3uZyaY5sXyDd9'
5586 'JAnN+lAXsOMJ90GANAi43mq5/VeeacylKVgi8o6F1SC63FxnagHfJUTfUYdCR/W'
Gavin Mak18f45d22020-12-04 21:45:10 +00005587 'Ofe+0dHL7PicpytKP750Fh1q2qnLVof4w8OZWNY')).decode('utf-8'))
maruel@chromium.org29404b52014-09-08 22:58:00 +00005588 return 0
5589
5590
Josip Sokcevic0399e172022-03-21 23:11:51 +00005591def CMDversion(parser, args):
5592 import utils
5593 print(utils.depot_tools_version())
5594
5595
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005596class OptionParser(optparse.OptionParser):
5597 """Creates the option parse and add --verbose support."""
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00005598
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005599 def __init__(self, *args, **kwargs):
maruel@chromium.org0633fb42013-08-16 20:06:14 +00005600 optparse.OptionParser.__init__(
5601 self, *args, prog='git cl', version=__version__, **kwargs)
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005602 self.add_option(
5603 '-v', '--verbose', action='count', default=0,
5604 help='Use 2 times for more debugging info')
5605
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005606 def parse_args(self, args=None, _values=None):
Andrii Shyshkalov46f20cd2018-10-30 06:42:54 +00005607 try:
5608 return self._parse_args(args)
5609 finally:
5610 # Regardless of success or failure of args parsing, we want to report
5611 # metrics, but only after logging has been initialized (if parsing
5612 # succeeded).
5613 global settings
5614 settings = Settings()
5615
Edward Lesmes9c349062021-05-06 20:02:39 +00005616 if metrics.collector.config.should_collect_metrics:
Andrii Shyshkalov46f20cd2018-10-30 06:42:54 +00005617 # GetViewVCUrl ultimately calls logging method.
5618 project_url = settings.GetViewVCUrl().strip('/+')
5619 if project_url in metrics_utils.KNOWN_PROJECT_URLS:
5620 metrics.collector.add('project_urls', [project_url])
5621
5622 def _parse_args(self, args=None):
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005623 # Create an optparse.Values object that will store only the actual passed
5624 # options, without the defaults.
5625 actual_options = optparse.Values()
5626 _, args = optparse.OptionParser.parse_args(self, args, actual_options)
5627 # Create an optparse.Values object with the default options.
5628 options = optparse.Values(self.get_default_values().__dict__)
5629 # Update it with the options passed by the user.
5630 options._update_careful(actual_options.__dict__)
5631 # Store the options passed by the user in an _actual_options attribute.
5632 # We store only the keys, and not the values, since the values can contain
5633 # arbitrary information, which might be PII.
Edward Lemur79d4f992019-11-11 23:49:02 +00005634 metrics.collector.add('arguments', list(actual_options.__dict__.keys()))
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005635
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005636 levels = [logging.WARNING, logging.INFO, logging.DEBUG]
Andrii Shyshkalov5b04a572017-01-23 17:44:41 +01005637 logging.basicConfig(
5638 level=levels[min(options.verbose, len(levels) - 1)],
5639 format='[%(levelname).1s%(asctime)s %(process)d %(thread)d '
5640 '%(filename)s] %(message)s')
Edward Lemur83bd7f42018-10-10 00:14:21 +00005641
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005642 return options, args
5643
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005644
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005645def main(argv):
maruel@chromium.org82798cb2012-02-23 18:16:12 +00005646 if sys.hexversion < 0x02060000:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005647 print('\nYour Python version %s is unsupported, please upgrade.\n' %
vapiera7fbd5a2016-06-16 09:17:49 -07005648 (sys.version.split(' ', 1)[0],), file=sys.stderr)
maruel@chromium.org82798cb2012-02-23 18:16:12 +00005649 return 2
maruel@chromium.org2e23ce32013-05-07 12:42:28 +00005650
maruel@chromium.org39c0b222013-08-17 16:57:01 +00005651 colorize_CMDstatus_doc()
maruel@chromium.org0633fb42013-08-16 20:06:14 +00005652 dispatcher = subcommand.CommandDispatcher(__name__)
5653 try:
5654 return dispatcher.execute(OptionParser(), argv)
Edward Lemur5b929a42019-10-21 17:57:39 +00005655 except auth.LoginRequiredError as e:
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +00005656 DieWithError(str(e))
Edward Lemur79d4f992019-11-11 23:49:02 +00005657 except urllib.error.HTTPError as e:
maruel@chromium.org0633fb42013-08-16 20:06:14 +00005658 if e.code != 500:
5659 raise
5660 DieWithError(
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005661 ('App Engine is misbehaving and returned HTTP %d, again. Keep faith '
Quinten Yearsleyc4202212019-07-22 23:34:40 +00005662 'and retry or visit go/isgaeup.\n%s') % (e.code, str(e)))
sbc@chromium.org013731e2015-02-26 18:28:43 +00005663 return 0
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005664
5665
5666if __name__ == '__main__':
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005667 # These affect sys.stdout, so do it outside of main() to simplify mocks in
5668 # the unit tests.
maruel@chromium.org6f09cd92011-04-01 16:38:12 +00005669 fix_encoding.fix_encoding()
iannucci@chromium.org596cd5c2016-04-04 21:34:39 +00005670 setup_color.init()
Edward Lemur6f812e12018-07-31 22:45:57 +00005671 with metrics.collector.print_notice_and_exit():
sbc@chromium.org013731e2015-02-26 18:28:43 +00005672 sys.exit(main(sys.argv[1:]))