blob: 63ac18f37512203d08e495567f704ad7b3678e1e [file] [log] [blame]
maruel@chromium.orgddd59412011-11-30 14:20:38 +00001#!/usr/bin/env python
maruel@chromium.orgeb5edbc2012-01-16 17:03:28 +00002# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
6"""Unit tests for git_cl.py."""
7
Andrii Shyshkalovcd6a9362016-12-07 12:04:12 +01008import contextlib
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01009import datetime
tandriide281ae2016-10-12 06:02:30 -070010import json
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +010011import logging
maruel@chromium.orgddd59412011-11-30 14:20:38 +000012import os
maruel@chromium.orga3353652011-11-30 14:26:57 +000013import StringIO
maruel@chromium.orgddd59412011-11-30 14:20:38 +000014import sys
Aaron Gable9a03ae02017-11-03 11:31:07 -070015import tempfile
maruel@chromium.orgddd59412011-11-30 14:20:38 +000016import unittest
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +000017import urlparse
maruel@chromium.orgddd59412011-11-30 14:20:38 +000018
19sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
20
21from testing_support.auto_stub import TestCase
22
Edward Lemur5ba1e9c2018-07-23 18:19:02 +000023import metrics
24# We have to disable monitoring before importing git_cl.
25metrics.DISABLE_METRICS_COLLECTION = True
26
Eric Boren2fb63102018-10-05 13:05:03 +000027import gerrit_util
maruel@chromium.orgddd59412011-11-30 14:20:38 +000028import git_cl
iannucci@chromium.org9e849272014-04-04 00:31:55 +000029import git_common
tandrii@chromium.org57d86542016-03-04 16:11:32 +000030import git_footers
maruel@chromium.orgddd59412011-11-30 14:20:38 +000031import subprocess2
maruel@chromium.orgddd59412011-11-30 14:20:38 +000032
tandrii5d48c322016-08-18 16:19:37 -070033def callError(code=1, cmd='', cwd='', stdout='', stderr=''):
34 return subprocess2.CalledProcessError(code, cmd, cwd, stdout, stderr)
35
36
37CERR1 = callError(1)
38
39
Aaron Gable9a03ae02017-11-03 11:31:07 -070040def MakeNamedTemporaryFileMock(expected_content):
41 class NamedTemporaryFileMock(object):
42 def __init__(self, *args, **kwargs):
43 self.name = '/tmp/named'
44 self.expected_content = expected_content
45
46 def __enter__(self):
47 return self
48
49 def __exit__(self, _type, _value, _tb):
50 pass
51
52 def write(self, content):
53 if self.expected_content:
54 assert content == self.expected_content
55
56 def close(self):
57 pass
58
59 return NamedTemporaryFileMock
60
61
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000062class ChangelistMock(object):
63 # A class variable so we can access it when we don't have access to the
64 # instance that's being set.
65 desc = ""
66 def __init__(self, **kwargs):
67 pass
68 def GetIssue(self):
69 return 1
Kenneth Russell61e2ed42017-02-15 11:47:13 -080070 def GetDescription(self, force=False):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000071 return ChangelistMock.desc
dsansomee2d6fd92016-09-08 00:10:47 -070072 def UpdateDescription(self, desc, force=False):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000073 ChangelistMock.desc = desc
74
tandrii5d48c322016-08-18 16:19:37 -070075
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000076class PresubmitMock(object):
77 def __init__(self, *args, **kwargs):
78 self.reviewers = []
Daniel Cheng7227d212017-11-17 08:12:37 -080079 self.more_cc = ['chromium-reviews+test-more-cc@chromium.org']
80
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000081 @staticmethod
82 def should_continue():
83 return True
84
85
skobes6468b902016-10-24 08:45:10 -070086class GitCheckoutMock(object):
87 def __init__(self, *args, **kwargs):
88 pass
89
90 @staticmethod
91 def reset():
92 GitCheckoutMock.conflict = False
93
94 def apply_patch(self, p):
95 if GitCheckoutMock.conflict:
96 raise Exception('failed')
97
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000098
99class WatchlistsMock(object):
100 def __init__(self, _):
101 pass
102 @staticmethod
103 def GetWatchersForPaths(_):
104 return ['joe@example.com']
105
106
ukai@chromium.org78c4b982012-02-14 02:20:26 +0000107class CodereviewSettingsFileMock(object):
108 def __init__(self):
109 pass
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800110 # pylint: disable=no-self-use
ukai@chromium.org78c4b982012-02-14 02:20:26 +0000111 def read(self):
112 return ("CODE_REVIEW_SERVER: gerrit.chromium.org\n" +
andybons@chromium.org11f46eb2016-02-02 19:26:51 +0000113 "GERRIT_HOST: True\n")
ukai@chromium.org78c4b982012-02-14 02:20:26 +0000114
115
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000116class AuthenticatorMock(object):
117 def __init__(self, *_args):
118 pass
119 def has_cached_credentials(self):
120 return True
tandrii221ab252016-10-06 08:12:04 -0700121 def authorize(self, http):
122 return http
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000123
124
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100125def CookiesAuthenticatorMockFactory(hosts_with_creds=None, same_auth=False):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000126 """Use to mock Gerrit/Git credentials from ~/.netrc or ~/.gitcookies.
127
128 Usage:
129 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100130 CookiesAuthenticatorMockFactory({'host': ('user', _, 'pass')})
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000131
132 OR
133 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100134 CookiesAuthenticatorMockFactory(
135 same_auth=('user', '', 'pass'))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000136 """
137 class CookiesAuthenticatorMock(git_cl.gerrit_util.CookiesAuthenticator):
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800138 def __init__(self): # pylint: disable=super-init-not-called
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000139 # Intentionally not calling super() because it reads actual cookie files.
140 pass
141 @classmethod
142 def get_gitcookies_path(cls):
143 return '~/.gitcookies'
144 @classmethod
145 def get_netrc_path(cls):
146 return '~/.netrc'
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100147 def _get_auth_for_host(self, host):
148 if same_auth:
149 return same_auth
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000150 return (hosts_with_creds or {}).get(host)
151 return CookiesAuthenticatorMock
152
Aaron Gable9a03ae02017-11-03 11:31:07 -0700153
kmarshall9249e012016-08-23 12:02:16 -0700154class MockChangelistWithBranchAndIssue():
155 def __init__(self, branch, issue):
156 self.branch = branch
157 self.issue = issue
158 def GetBranch(self):
159 return self.branch
160 def GetIssue(self):
161 return self.issue
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000162
tandriic2405f52016-10-10 08:13:15 -0700163
164class SystemExitMock(Exception):
165 pass
166
167
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000168class TestGitClBasic(unittest.TestCase):
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100169 def test_get_description(self):
Andrii Shyshkalovf5569d22018-10-15 03:35:23 +0000170 cl = git_cl.Changelist(issue=1, codereview='gerrit',
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100171 codereview_host='host')
172 cl.description = 'x'
173 cl.has_description = True
Kenneth Russell61e2ed42017-02-15 11:47:13 -0800174 cl._codereview_impl.FetchDescription = lambda *a, **kw: 'y'
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100175 self.assertEquals(cl.GetDescription(), 'x')
176 self.assertEquals(cl.GetDescription(force=True), 'y')
177 self.assertEquals(cl.GetDescription(), 'y')
178
Robert Iannucci09f1f3d2017-03-28 16:54:32 -0700179 def test_description_footers(self):
180 cl = git_cl.Changelist(issue=1, codereview='gerrit',
181 codereview_host='host')
182 cl.description = '\n'.join([
183 'This is some message',
184 '',
185 'It has some lines',
186 'and, also',
187 '',
188 'Some: Really',
189 'Awesome: Footers',
190 ])
191 cl.has_description = True
192 cl._codereview_impl.UpdateDescriptionRemote = lambda *a, **kw: 'y'
193 msg, footers = cl.GetDescriptionFooters()
194 self.assertEquals(
195 msg, ['This is some message', '', 'It has some lines', 'and, also'])
196 self.assertEquals(footers, [('Some', 'Really'), ('Awesome', 'Footers')])
197
198 msg.append('wut')
199 footers.append(('gnarly-dude', 'beans'))
200 cl.UpdateDescriptionFooters(msg, footers)
201 self.assertEquals(cl.GetDescription().splitlines(), [
202 'This is some message',
203 '',
204 'It has some lines',
205 'and, also',
206 'wut'
207 '',
208 'Some: Really',
209 'Awesome: Footers',
210 'Gnarly-Dude: beans',
211 ])
212
tandriif9aefb72016-07-01 09:06:51 -0700213 def test_get_bug_line_values(self):
214 f = lambda p, bugs: list(git_cl._get_bug_line_values(p, bugs))
215 self.assertEqual(f('', ''), [])
216 self.assertEqual(f('', '123,v8:456'), ['123', 'v8:456'])
217 self.assertEqual(f('v8', '456'), ['v8:456'])
218 self.assertEqual(f('v8', 'chromium:123,456'), ['v8:456', 'chromium:123'])
219 # Not nice, but not worth carying.
220 self.assertEqual(f('v8', 'chromium:123,456,v8:123'),
221 ['v8:456', 'chromium:123', 'v8:123'])
222
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100223 def _test_git_number(self, parent_msg, dest_ref, child_msg,
224 parent_hash='parenthash'):
225 desc = git_cl.ChangeDescription(child_msg)
226 desc.update_with_git_number_footers(parent_hash, parent_msg, dest_ref)
227 return desc.description
228
229 def assertEqualByLine(self, actual, expected):
230 self.assertEqual(actual.splitlines(), expected.splitlines())
231
232 def test_git_number_bad_parent(self):
233 with self.assertRaises(ValueError):
234 self._test_git_number('Parent', 'refs/heads/master', 'Child')
235
236 def test_git_number_bad_parent_footer(self):
237 with self.assertRaises(AssertionError):
238 self._test_git_number(
239 'Parent\n'
240 '\n'
241 'Cr-Commit-Position: wrong',
242 'refs/heads/master', 'Child')
243
244 def test_git_number_bad_lineage_ignored(self):
245 actual = self._test_git_number(
246 'Parent\n'
247 '\n'
248 'Cr-Commit-Position: refs/heads/master@{#1}\n'
249 'Cr-Branched-From: mustBeReal40CharHash-branch@{#pos}',
250 'refs/heads/master', 'Child')
251 self.assertEqualByLine(
252 actual,
253 'Child\n'
254 '\n'
255 'Cr-Commit-Position: refs/heads/master@{#2}\n'
256 'Cr-Branched-From: mustBeReal40CharHash-branch@{#pos}')
257
258 def test_git_number_same_branch(self):
259 actual = self._test_git_number(
260 'Parent\n'
261 '\n'
262 'Cr-Commit-Position: refs/heads/master@{#12}',
263 dest_ref='refs/heads/master',
264 child_msg='Child')
265 self.assertEqualByLine(
266 actual,
267 'Child\n'
268 '\n'
269 'Cr-Commit-Position: refs/heads/master@{#13}')
270
Andrii Shyshkalovde37c012017-07-06 21:06:50 +0200271 def test_git_number_same_branch_mixed_footers(self):
272 actual = self._test_git_number(
273 'Parent\n'
274 '\n'
275 'Cr-Commit-Position: refs/heads/master@{#12}',
276 dest_ref='refs/heads/master',
277 child_msg='Child\n'
278 '\n'
279 'Broken-by: design\n'
280 'BUG=123')
281 self.assertEqualByLine(
282 actual,
283 'Child\n'
284 '\n'
285 'Broken-by: design\n'
286 'BUG=123\n'
287 'Cr-Commit-Position: refs/heads/master@{#13}')
288
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100289 def test_git_number_same_branch_with_originals(self):
290 actual = self._test_git_number(
291 'Parent\n'
292 '\n'
293 'Cr-Commit-Position: refs/heads/master@{#12}',
294 dest_ref='refs/heads/master',
295 child_msg='Child\n'
296 '\n'
297 'Some users are smart and insert their own footers\n'
298 '\n'
299 'Cr-Whatever: value\n'
300 'Cr-Commit-Position: refs/copy/paste@{#22}')
301 self.assertEqualByLine(
302 actual,
303 'Child\n'
304 '\n'
305 'Some users are smart and insert their own footers\n'
306 '\n'
307 'Cr-Original-Whatever: value\n'
308 'Cr-Original-Commit-Position: refs/copy/paste@{#22}\n'
309 'Cr-Commit-Position: refs/heads/master@{#13}')
310
311 def test_git_number_new_branch(self):
312 actual = self._test_git_number(
313 'Parent\n'
314 '\n'
315 'Cr-Commit-Position: refs/heads/master@{#12}',
316 dest_ref='refs/heads/branch',
317 child_msg='Child')
318 self.assertEqualByLine(
319 actual,
320 'Child\n'
321 '\n'
322 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
323 'Cr-Branched-From: parenthash-refs/heads/master@{#12}')
324
325 def test_git_number_lineage(self):
326 actual = self._test_git_number(
327 'Parent\n'
328 '\n'
329 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
330 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
331 dest_ref='refs/heads/branch',
332 child_msg='Child')
333 self.assertEqualByLine(
334 actual,
335 'Child\n'
336 '\n'
337 'Cr-Commit-Position: refs/heads/branch@{#2}\n'
338 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
339
340 def test_git_number_moooooooore_lineage(self):
341 actual = self._test_git_number(
342 'Parent\n'
343 '\n'
344 'Cr-Commit-Position: refs/heads/branch@{#5}\n'
345 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
346 dest_ref='refs/heads/mooore',
347 child_msg='Child')
348 self.assertEqualByLine(
349 actual,
350 'Child\n'
351 '\n'
352 'Cr-Commit-Position: refs/heads/mooore@{#1}\n'
353 'Cr-Branched-From: parenthash-refs/heads/branch@{#5}\n'
354 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
355
Andrii Shyshkalovb5effa12016-12-14 19:35:12 +0100356 def test_git_number_ever_moooooooore_lineage(self):
Robert Iannucci456b0d62018-03-13 19:15:50 -0700357 self.maxDiff = 10000 # pylint: disable=attribute-defined-outside-init
Andrii Shyshkalovb5effa12016-12-14 19:35:12 +0100358 actual = self._test_git_number(
359 'CQ commit on fresh new branch + numbering.\n'
360 '\n'
361 'NOTRY=True\n'
362 'NOPRESUBMIT=True\n'
363 'BUG=\n'
364 '\n'
365 'Review-Url: https://codereview.chromium.org/2577703003\n'
366 'Cr-Commit-Position: refs/heads/gnumb-test/br@{#1}\n'
367 'Cr-Branched-From: 0749ff9edc-refs/heads/gnumb-test/cq@{#4}\n'
368 'Cr-Branched-From: 5c49df2da6-refs/heads/master@{#41618}',
369 dest_ref='refs/heads/gnumb-test/cl',
370 child_msg='git cl on fresh new branch + numbering.\n'
371 '\n'
372 'Review-Url: https://codereview.chromium.org/2575043003 .\n')
373 self.assertEqualByLine(
374 actual,
375 'git cl on fresh new branch + numbering.\n'
376 '\n'
377 'Review-Url: https://codereview.chromium.org/2575043003 .\n'
378 'Cr-Commit-Position: refs/heads/gnumb-test/cl@{#1}\n'
379 'Cr-Branched-From: parenthash-refs/heads/gnumb-test/br@{#1}\n'
380 'Cr-Branched-From: 0749ff9edc-refs/heads/gnumb-test/cq@{#4}\n'
381 'Cr-Branched-From: 5c49df2da6-refs/heads/master@{#41618}')
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100382
383 def test_git_number_cherry_pick(self):
384 actual = self._test_git_number(
385 'Parent\n'
386 '\n'
387 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
388 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
389 dest_ref='refs/heads/branch',
390 child_msg='Child, which is cherry-pick from master\n'
391 '\n'
392 'Cr-Commit-Position: refs/heads/master@{#100}\n'
393 '(cherry picked from commit deadbeef12345678deadbeef12345678deadbeef)')
394 self.assertEqualByLine(
395 actual,
396 'Child, which is cherry-pick from master\n'
397 '\n'
398 '(cherry picked from commit deadbeef12345678deadbeef12345678deadbeef)\n'
399 '\n'
400 'Cr-Original-Commit-Position: refs/heads/master@{#100}\n'
401 'Cr-Commit-Position: refs/heads/branch@{#2}\n'
402 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
403
Andrii Shyshkalovd4c86732018-09-25 04:29:31 +0000404 def test_gerrit_mirror_hack(self):
405 cr = 'chromium-review.googlesource.com'
406 url0 = 'https://%s/a/changes/x?a=b' % cr
407 origMirrors = git_cl.gerrit_util._GERRIT_MIRROR_PREFIXES
408 try:
409 git_cl.gerrit_util._GERRIT_MIRROR_PREFIXES = ['us1', 'us2']
410 url1 = git_cl.gerrit_util._UseGerritMirror(url0, cr)
411 url2 = git_cl.gerrit_util._UseGerritMirror(url1, cr)
412 url3 = git_cl.gerrit_util._UseGerritMirror(url2, cr)
413
414 self.assertNotEqual(url1, url2)
415 self.assertEqual(sorted((url1, url2)), [
416 'https://us1-mirror-chromium-review.googlesource.com/a/changes/x?a=b',
417 'https://us2-mirror-chromium-review.googlesource.com/a/changes/x?a=b'])
418 self.assertEqual(url1, url3)
419 finally:
420 git_cl.gerrit_util._GERRIT_MIRROR_PREFIXES = origMirrors
421
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000422 def test_valid_accounts(self):
423 mock_per_account = {
424 'u1': None, # 404, doesn't exist.
425 'u2': {
426 '_account_id': 123124,
427 'avatars': [],
428 'email': 'u2@example.com',
429 'name': 'User Number 2',
430 'status': 'OOO',
431 },
432 'u3': git_cl.gerrit_util.GerritError(500, 'retries didn\'t help :('),
433 }
434 def GetAccountDetailsMock(_, account):
435 # Poor-man's mock library's side_effect.
436 v = mock_per_account.pop(account)
437 if isinstance(v, Exception):
438 raise v
439 return v
440
441 original = git_cl.gerrit_util.GetAccountDetails
442 try:
443 git_cl.gerrit_util.GetAccountDetails = GetAccountDetailsMock
444 actual = git_cl.gerrit_util.ValidAccounts(
445 'host', ['u1', 'u2', 'u3'], max_threads=1)
446 finally:
447 git_cl.gerrit_util.GetAccountDetails = original
448 self.assertEqual(actual, {
449 'u2': {
450 '_account_id': 123124,
451 'avatars': [],
452 'email': 'u2@example.com',
453 'name': 'User Number 2',
454 'status': 'OOO',
455 },
456 })
457
458
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000459
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200460class TestParseIssueURL(unittest.TestCase):
461 def _validate(self, parsed, issue=None, patchset=None, hostname=None,
462 codereview=None, fail=False):
463 self.assertIsNotNone(parsed)
464 if fail:
465 self.assertFalse(parsed.valid)
466 return
467 self.assertTrue(parsed.valid)
468 self.assertEqual(parsed.issue, issue)
469 self.assertEqual(parsed.patchset, patchset)
470 self.assertEqual(parsed.hostname, hostname)
471 self.assertEqual(parsed.codereview, codereview)
472
473 def _run_and_validate(self, func, url, *args, **kwargs):
474 result = func(urlparse.urlparse(url))
475 if kwargs.pop('fail', False):
476 self.assertIsNone(result)
477 return None
478 self._validate(result, *args, fail=False, **kwargs)
479
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200480 def test_gerrit(self):
481 def test(url, issue=None, patchset=None, hostname=None, fail=None):
482 self._test_ParseIssueUrl(
483 git_cl._GerritChangelistImpl.ParseIssueURL,
484 url, issue, patchset, hostname, fail)
485 def test(url, *args, **kwargs):
486 self._run_and_validate(git_cl._GerritChangelistImpl.ParseIssueURL, url,
487 *args, codereview='gerrit', **kwargs)
488
489 test('http://chrome-review.source.com/c/123',
490 123, None, 'chrome-review.source.com')
491 test('https://chrome-review.source.com/c/123/',
492 123, None, 'chrome-review.source.com')
493 test('https://chrome-review.source.com/c/123/4',
494 123, 4, 'chrome-review.source.com')
495 test('https://chrome-review.source.com/#/c/123/4',
496 123, 4, 'chrome-review.source.com')
497 test('https://chrome-review.source.com/c/123/4',
498 123, 4, 'chrome-review.source.com')
499 test('https://chrome-review.source.com/123',
500 123, None, 'chrome-review.source.com')
501 test('https://chrome-review.source.com/123/4',
502 123, 4, 'chrome-review.source.com')
503
504 test('https://chrome-review.source.com/c/123/1/whatisthis', fail=True)
505 test('https://chrome-review.source.com/c/abc/', fail=True)
506 test('ssh://chrome-review.source.com/c/123/1/', fail=True)
507
508 def test_ParseIssueNumberArgument(self):
509 def test(arg, *args, **kwargs):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +0200510 codereview_hint = kwargs.pop('hint', None)
511 self._validate(git_cl.ParseIssueNumberArgument(arg, codereview_hint),
512 *args, **kwargs)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200513
514 test('123', 123)
515 test('', fail=True)
516 test('abc', fail=True)
517 test('123/1', fail=True)
518 test('123a', fail=True)
519 test('ssh://chrome-review.source.com/#/c/123/4/', fail=True)
Andrii Shyshkalovf5569d22018-10-15 03:35:23 +0000520
521 # Looks like Rietveld and Gerrit, but we should select Gerrit now
522 # w/ or w/o hint.
Andrii Shyshkalovc9712392017-04-11 13:35:21 +0200523 test('https://codereview.source.com/123',
524 123, None, 'codereview.source.com', 'gerrit',
525 hint='gerrit')
Andrii Shyshkalovf5569d22018-10-15 03:35:23 +0000526 test('https://codereview.source.com/123',
527 123, None, 'codereview.source.com', 'gerrit')
528
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200529 # Gerrrit.
530 test('https://chrome-review.source.com/c/123/4',
531 123, 4, 'chrome-review.source.com', 'gerrit')
532 test('https://chrome-review.source.com/bad/123/4', fail=True)
533
534
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100535class GitCookiesCheckerTest(TestCase):
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100536 def setUp(self):
537 super(GitCookiesCheckerTest, self).setUp()
538 self.c = git_cl._GitCookiesChecker()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100539 self.c._all_hosts = []
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100540
541 def mock_hosts_creds(self, subhost_identity_pairs):
542 def ensure_googlesource(h):
543 if not h.endswith(self.c._GOOGLESOURCE):
544 assert not h.endswith('.')
545 return h + '.' + self.c._GOOGLESOURCE
546 return h
547 self.c._all_hosts = [(ensure_googlesource(h), i, '.gitcookies')
548 for h, i in subhost_identity_pairs]
549
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200550 def test_identity_parsing(self):
551 self.assertEqual(self.c._parse_identity('ldap.google.com'),
552 ('ldap', 'google.com'))
553 self.assertEqual(self.c._parse_identity('git-ldap.example.com'),
554 ('ldap', 'example.com'))
555 # Specical case because we know there are no subdomains in chromium.org.
556 self.assertEqual(self.c._parse_identity('git-note.period.chromium.org'),
557 ('note.period', 'chromium.org'))
Lei Zhangd3f769a2017-12-15 15:16:14 -0800558 # Pathological: ".period." can be either username OR domain, more likely
559 # domain.
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200560 self.assertEqual(self.c._parse_identity('git-note.period.example.com'),
561 ('note', 'period.example.com'))
562
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100563 def test_analysis_nothing(self):
564 self.c._all_hosts = []
565 self.assertFalse(self.c.has_generic_host())
566 self.assertEqual(set(), self.c.get_conflicting_hosts())
567 self.assertEqual(set(), self.c.get_duplicated_hosts())
568 self.assertEqual(set(), self.c.get_partially_configured_hosts())
569 self.assertEqual(set(), self.c.get_hosts_with_wrong_identities())
570
571 def test_analysis(self):
572 self.mock_hosts_creds([
573 ('.googlesource.com', 'git-example.chromium.org'),
574
575 ('chromium', 'git-example.google.com'),
576 ('chromium-review', 'git-example.google.com'),
577 ('chrome-internal', 'git-example.chromium.org'),
578 ('chrome-internal-review', 'git-example.chromium.org'),
579 ('conflict', 'git-example.google.com'),
580 ('conflict-review', 'git-example.chromium.org'),
581 ('dup', 'git-example.google.com'),
582 ('dup', 'git-example.google.com'),
583 ('dup-review', 'git-example.google.com'),
584 ('partial', 'git-example.google.com'),
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200585 ('gpartial-review', 'git-example.google.com'),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100586 ])
587 self.assertTrue(self.c.has_generic_host())
588 self.assertEqual(set(['conflict.googlesource.com']),
589 self.c.get_conflicting_hosts())
590 self.assertEqual(set(['dup.googlesource.com']),
591 self.c.get_duplicated_hosts())
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200592 self.assertEqual(set(['partial.googlesource.com',
593 'gpartial-review.googlesource.com']),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100594 self.c.get_partially_configured_hosts())
595 self.assertEqual(set(['chromium.googlesource.com',
596 'chrome-internal.googlesource.com']),
597 self.c.get_hosts_with_wrong_identities())
598
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100599 def test_report_no_problems(self):
600 self.test_analysis_nothing()
601 self.mock(sys, 'stdout', StringIO.StringIO())
602 self.assertFalse(self.c.find_and_report_problems())
603 self.assertEqual(sys.stdout.getvalue(), '')
604
605 def test_report(self):
606 self.test_analysis()
607 self.mock(sys, 'stdout', StringIO.StringIO())
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200608 self.mock(git_cl.gerrit_util.CookiesAuthenticator, 'get_gitcookies_path',
609 classmethod(lambda _: '~/.gitcookies'))
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100610 self.assertTrue(self.c.find_and_report_problems())
611 with open(os.path.join(os.path.dirname(__file__),
612 'git_cl_creds_check_report.txt')) as f:
613 expected = f.read()
614 def by_line(text):
615 return [l.rstrip() for l in text.rstrip().splitlines()]
Robert Iannucci456b0d62018-03-13 19:15:50 -0700616 self.maxDiff = 10000 # pylint: disable=attribute-defined-outside-init
Andrii Shyshkalov4812e612017-03-27 17:22:57 +0200617 self.assertEqual(by_line(sys.stdout.getvalue().strip()), by_line(expected))
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100618
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -0800619
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000620class TestGitCl(TestCase):
621 def setUp(self):
622 super(TestGitCl, self).setUp()
623 self.calls = []
tandrii9d206752016-06-20 11:32:47 -0700624 self._calls_done = []
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000625 self.mock(git_cl, 'time_time',
626 lambda: self._mocked_call('time.time'))
627 self.mock(git_cl.metrics.collector, 'add_repeated',
628 lambda *a: self._mocked_call('add_repeated', *a))
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000629 self.mock(subprocess2, 'call', self._mocked_call)
630 self.mock(subprocess2, 'check_call', self._mocked_call)
631 self.mock(subprocess2, 'check_output', self._mocked_call)
tandrii5d48c322016-08-18 16:19:37 -0700632 self.mock(subprocess2, 'communicate',
633 lambda *a, **kw: ([self._mocked_call(*a, **kw), ''], 0))
tandrii@chromium.orga342c922016-03-16 07:08:25 +0000634 self.mock(git_cl.gclient_utils, 'CheckCallAndFilter', self._mocked_call)
sbc@chromium.org71437c02015-04-09 19:29:40 +0000635 self.mock(git_common, 'is_dirty_git_tree', lambda x: False)
iannucci@chromium.org9e849272014-04-04 00:31:55 +0000636 self.mock(git_common, 'get_or_create_merge_base',
637 lambda *a: (
638 self._mocked_call(['get_or_create_merge_base']+list(a))))
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +0000639 self.mock(git_cl, 'BranchExists', lambda _: True)
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000640 self.mock(git_cl, 'FindCodereviewSettingsFile', lambda: '')
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000641 self.mock(git_cl, 'SaveDescriptionBackup', lambda _:
642 self._mocked_call('SaveDescriptionBackup'))
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100643 self.mock(git_cl, 'ask_for_data', lambda *a, **k: self._mocked_call(
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000644 *(['ask_for_data'] + list(a)), **k))
phajdan.jre328cf92016-08-22 04:12:17 -0700645 self.mock(git_cl, 'write_json', lambda path, contents:
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000646 self._mocked_call('write_json', path, contents))
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000647 self.mock(git_cl.presubmit_support, 'DoPresubmitChecks', PresubmitMock)
skobes6468b902016-10-24 08:45:10 -0700648 self.mock(git_cl.checkout, 'GitCheckout', GitCheckoutMock)
649 GitCheckoutMock.reset()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000650 self.mock(git_cl.watchlists, 'Watchlists', WatchlistsMock)
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000651 self.mock(git_cl.auth, 'get_authenticator_for_host', AuthenticatorMock)
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +0100652 self.mock(git_cl.gerrit_util, 'GetChangeDetail',
653 lambda *args, **kwargs: self._mocked_call(
654 'GetChangeDetail', *args, **kwargs))
Aaron Gable0ffdf2d2017-06-05 13:01:17 -0700655 self.mock(git_cl.gerrit_util, 'GetChangeComments',
656 lambda *args, **kwargs: self._mocked_call(
657 'GetChangeComments', *args, **kwargs))
Quinten Yearsley0e617c02019-02-20 00:37:03 +0000658 self.mock(git_cl.gerrit_util, 'GetChangeRobotComments',
659 lambda *args, **kwargs: self._mocked_call(
660 'GetChangeRobotComments', *args, **kwargs))
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +0100661 self.mock(git_cl.gerrit_util, 'AddReviewers',
Aaron Gable6dadfbf2017-05-09 14:27:58 -0700662 lambda h, i, reviewers, ccs, notify: self._mocked_call(
663 'AddReviewers', h, i, reviewers, ccs, notify))
Aaron Gablefd238082017-06-07 13:42:34 -0700664 self.mock(git_cl.gerrit_util, 'SetReview',
Aaron Gablefc62f762017-07-17 11:12:07 -0700665 lambda h, i, msg=None, labels=None, notify=None:
666 self._mocked_call('SetReview', h, i, msg, labels, notify))
Andrii Shyshkalov733d4ec2018-04-19 11:48:58 -0700667 self.mock(git_cl.gerrit_util.LuciContextAuthenticator, 'is_luci',
668 staticmethod(lambda: False))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000669 self.mock(git_cl.gerrit_util.GceAuthenticator, 'is_gce',
670 classmethod(lambda _: False))
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000671 self.mock(git_cl.gerrit_util, 'ValidAccounts',
672 lambda host, accounts:
673 self._mocked_call('ValidAccounts', host, accounts))
tandriic2405f52016-10-10 08:13:15 -0700674 self.mock(git_cl, 'DieWithError',
Christopher Lamf732cd52017-01-24 12:40:11 +1100675 lambda msg, change=None: self._mocked_call(['DieWithError', msg]))
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000676 # It's important to reset settings to not have inter-tests interference.
677 git_cl.settings = None
678
679 def tearDown(self):
wychen@chromium.org445c8962015-04-28 23:30:05 +0000680 try:
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100681 self.assertEquals([], self.calls)
682 except AssertionError:
wychen@chromium.org445c8962015-04-28 23:30:05 +0000683 if not self.has_failed():
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100684 raise
685 # Sadly, has_failed() returns True if this OR any other tests before this
686 # one have failed.
Andrii Shyshkalove05d4882017-04-12 14:34:49 +0200687 git_cl.logging.error(
688 '!!!!!! IF YOU SEE THIS, READ BELOW, IT WILL SAVE YOUR TIME !!!!!\n'
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100689 'There are un-consumed self.calls after this test has finished.\n'
690 'If you don\'t know which test this is, run:\n'
Aaron Gable3a16ed12017-03-23 10:51:55 -0700691 ' tests/git_cl_tests.py -v\n'
Andrii Shyshkalove05d4882017-04-12 14:34:49 +0200692 'If you are already running only this test, then **first** fix the '
693 'problem whose exception is emitted below by unittest runner.\n'
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100694 'Else, to be sure what\'s going on, run this test **alone** with \n'
Aaron Gable3a16ed12017-03-23 10:51:55 -0700695 ' tests/git_cl_tests.py TestGitCl.<name>\n'
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100696 'and follow instructions above.\n' +
697 '=' * 80)
wychen@chromium.org445c8962015-04-28 23:30:05 +0000698 finally:
699 super(TestGitCl, self).tearDown()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000700
iannucci@chromium.org9e849272014-04-04 00:31:55 +0000701 def _mocked_call(self, *args, **_kwargs):
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000702 self.assertTrue(
703 self.calls,
tandrii9d206752016-06-20 11:32:47 -0700704 '@%d Expected: <Missing> Actual: %r' % (len(self._calls_done), args))
wychen@chromium.orga872e752015-04-28 23:42:18 +0000705 top = self.calls.pop(0)
wychen@chromium.orga872e752015-04-28 23:42:18 +0000706 expected_args, result = top
707
maruel@chromium.orge52678e2013-04-26 18:34:44 +0000708 # Also logs otherwise it could get caught in a try/finally and be hard to
709 # diagnose.
710 if expected_args != args:
tandrii9d206752016-06-20 11:32:47 -0700711 N = 5
712 prior_calls = '\n '.join(
713 '@%d: %r' % (len(self._calls_done) - N + i, c[0])
714 for i, c in enumerate(self._calls_done[-N:]))
715 following_calls = '\n '.join(
716 '@%d: %r' % (len(self._calls_done) + i + 1, c[0])
717 for i, c in enumerate(self.calls[:N]))
718 extended_msg = (
719 'A few prior calls:\n %s\n\n'
720 'This (expected):\n @%d: %r\n'
721 'This (actual):\n @%d: %r\n\n'
722 'A few following expected calls:\n %s' %
723 (prior_calls, len(self._calls_done), expected_args,
724 len(self._calls_done), args, following_calls))
725 git_cl.logging.error(extended_msg)
726
tandrii99a72f22016-08-17 14:33:24 -0700727 self.fail('@%d\n'
728 ' Expected: %r\n'
729 ' Actual: %r' % (
tandrii9d206752016-06-20 11:32:47 -0700730 len(self._calls_done), expected_args, args))
731
732 self._calls_done.append(top)
tandrii5d48c322016-08-18 16:19:37 -0700733 if isinstance(result, Exception):
734 raise result
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000735 return result
736
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100737 def test_ask_for_explicit_yes_true(self):
738 self.calls = [
739 (('ask_for_data', 'prompt [Yes/No]: '), 'blah'),
740 (('ask_for_data', 'Please, type yes or no: '), 'ye'),
741 ]
742 self.assertTrue(git_cl.ask_for_explicit_yes('prompt'))
743
tandrii48df5812016-10-17 03:55:37 -0700744 def test_LoadCodereviewSettingsFromFile_gerrit(self):
745 codereview_file = StringIO.StringIO('GERRIT_HOST: true')
746 self.calls = [
747 ((['git', 'config', '--unset-all', 'rietveld.cc'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700748 ((['git', 'config', '--unset-all', 'rietveld.tree-status-url'],), CERR1),
749 ((['git', 'config', '--unset-all', 'rietveld.viewvc-url'],), CERR1),
750 ((['git', 'config', '--unset-all', 'rietveld.bug-prefix'],), CERR1),
751 ((['git', 'config', '--unset-all', 'rietveld.cpplint-regex'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700752 ((['git', 'config', '--unset-all', 'rietveld.cpplint-ignore-regex'],),
753 CERR1),
tandrii48df5812016-10-17 03:55:37 -0700754 ((['git', 'config', '--unset-all', 'rietveld.run-post-upload-hook'],),
755 CERR1),
756 ((['git', 'config', 'gerrit.host', 'true'],), ''),
757 ]
758 self.assertIsNone(git_cl.LoadCodereviewSettingsFromFile(codereview_file))
759
maruel@chromium.orga3353652011-11-30 14:26:57 +0000760 @classmethod
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000761 def _is_gerrit_calls(cls, gerrit=False):
762 return [((['git', 'config', 'rietveld.autoupdate'],), ''),
763 ((['git', 'config', 'gerrit.host'],), 'True' if gerrit else '')]
764
765 @classmethod
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +0000766 def _git_post_upload_calls(cls):
767 return [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000768 ((['git', 'rev-parse', 'HEAD'],), 'hash'),
769 ((['git', 'symbolic-ref', 'HEAD'],), 'hash'),
770 ((['git',
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000771 'config', 'branch.hash.last-upload-hash', 'hash'],), ''),
rmistry@google.com5626a922015-02-26 14:03:30 +0000772 ((['git', 'config', 'rietveld.run-post-upload-hook'],), ''),
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000773 ]
774
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000775 @staticmethod
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000776 def _git_sanity_checks(diff_base, working_branch, get_remote_branch=True):
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000777 fake_ancestor = 'fake_ancestor'
778 fake_cl = 'fake_cl_for_patch'
779 return [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000780 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000781 'rev-parse', '--verify', diff_base],), fake_ancestor),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000782 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000783 'merge-base', fake_ancestor, 'HEAD'],), fake_ancestor),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000784 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000785 'rev-list', '^' + fake_ancestor, 'HEAD'],), fake_cl),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000786 # Mock a config miss (error code 1)
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000787 ((['git',
tandrii5d48c322016-08-18 16:19:37 -0700788 'config', 'gitcl.remotebranch'],), CERR1),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000789 ] + ([
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000790 # Call to GetRemoteBranch()
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000791 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000792 'config', 'branch.%s.merge' % working_branch],),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000793 'refs/heads/master'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000794 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000795 'config', 'branch.%s.remote' % working_branch],), 'origin'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000796 ] if get_remote_branch else []) + [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000797 ((['git', 'rev-list', '^' + fake_ancestor,
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000798 'refs/remotes/origin/master'],), ''),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000799 ]
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000800
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000801 @classmethod
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000802 def _gerrit_ensure_auth_calls(
803 cls, issue=None, skip_auth_check=False, short_hostname='chromium'):
shinyak@chromium.org00dbccd2016-04-15 07:24:43 +0000804 cmd = ['git', 'config', '--bool', 'gerrit.skip-ensure-authenticated']
tandrii@chromium.org28253532016-04-14 13:46:56 +0000805 if skip_auth_check:
806 return [((cmd, ), 'true')]
807
tandrii5d48c322016-08-18 16:19:37 -0700808 calls = [((cmd, ), CERR1)]
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000809 if issue:
810 calls.extend([
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +0100811 ((['git', 'config', 'branch.master.gerritserver'],), CERR1),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000812 ])
813 calls.extend([
814 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
815 ((['git', 'config', 'branch.master.remote'],), 'origin'),
816 ((['git', 'config', 'remote.origin.url'],),
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000817 'https://%s.googlesource.com/my/repo' % short_hostname),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000818 ])
819 return calls
820
821 @classmethod
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100822 def _gerrit_base_calls(cls, issue=None, fetched_description=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200823 fetched_status=None, other_cl_owner=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000824 custom_cl_base=None, short_hostname='chromium'):
Aaron Gable13101a62018-02-09 13:20:41 -0800825 calls = cls._is_gerrit_calls(True)
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100826 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200827 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200828 ((['git', 'config', 'branch.master.gerritissue'],),
829 CERR1 if issue is None else str(issue)),
830 ]
831
832 if custom_cl_base:
833 ancestor_revision = custom_cl_base
834 else:
835 # Determine ancestor_revision to be merge base.
836 ancestor_revision = 'fake_ancestor_sha'
837 calls += [
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000838 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000839 ((['git', 'config', 'branch.master.remote'],), 'origin'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000840 ((['get_or_create_merge_base', 'master',
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200841 'refs/remotes/origin/master'],), ancestor_revision),
842 ]
843
844 # Calls to verify branch point is ancestor
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000845 calls += cls._gerrit_ensure_auth_calls(
846 issue=issue, short_hostname=short_hostname)
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100847
848 if issue:
849 calls += [
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000850 (('GetChangeDetail', '%s-review.googlesource.com' % short_hostname,
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +0000851 'my%2Frepo~123456',
Andrii Shyshkalovc4a73562018-09-25 18:40:17 +0000852 ['DETAILED_ACCOUNTS', 'CURRENT_REVISION', 'CURRENT_COMMIT', 'LABELS']
853 ),
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100854 {
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100855 'owner': {'email': (other_cl_owner or 'owner@example.com')},
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100856 'change_id': '123456789',
857 'current_revision': 'sha1_of_current_revision',
858 'revisions': { 'sha1_of_current_revision': {
859 'commit': {'message': fetched_description},
860 }},
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100861 'status': fetched_status or 'NEW',
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100862 }),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100863 ]
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100864 if fetched_status == 'ABANDONED':
865 calls += [
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000866 (('DieWithError', 'Change https://%s-review.googlesource.com/'
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100867 '123456 has been abandoned, new uploads are not '
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000868 'allowed' % short_hostname), SystemExitMock()),
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100869 ]
870 return calls
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100871 if other_cl_owner:
872 calls += [
873 (('ask_for_data', 'Press Enter to upload, or Ctrl+C to abort'), ''),
874 ]
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100875
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200876 calls += cls._git_sanity_checks(ancestor_revision, 'master',
877 get_remote_branch=False)
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100878 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200879 ((['git', 'rev-parse', '--show-cdup'],), ''),
880 ((['git', 'rev-parse', 'HEAD'],), '12345'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000881
Aaron Gable7817f022017-12-12 09:43:17 -0800882 ((['git', '-c', 'core.quotePath=false', 'diff', '--name-status',
883 '--no-renames', '-r', ancestor_revision + '...', '.'],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200884 'M\t.gitignore\n'),
885 ((['git', 'config', 'branch.master.gerritpatchset'],), CERR1),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100886 ]
887
888 if not issue:
889 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200890 ((['git', 'log', '--pretty=format:%s%n%n%b',
891 ancestor_revision + '...'],),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000892 'foo'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100893 ]
894
895 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200896 ((['git', 'config', 'user.email'],), 'me@example.com'),
897 ((['git', 'diff', '--no-ext-diff', '--stat', '-l100000', '-C50'] +
898 ([custom_cl_base] if custom_cl_base else
899 [ancestor_revision, 'HEAD']),),
900 '+dat'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100901 ]
902 return calls
ukai@chromium.orge8077812012-02-03 03:41:46 +0000903
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +0000904 @classmethod
905 def _gerrit_upload_calls(cls, description, reviewers, squash,
tandriia60502f2016-06-20 02:01:53 -0700906 squash_mode='default',
tandrii@chromium.org10625002016-03-04 20:03:47 +0000907 expected_upstream_ref='origin/refs/heads/master',
Aaron Gablefd238082017-06-07 13:42:34 -0700908 title=None, notify=False,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +0100909 post_amend_description=None, issue=None, cc=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000910 custom_cl_base=None, tbr=None,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +0000911 short_hostname='chromium',
912 labels=None):
tandrii@chromium.org10625002016-03-04 20:03:47 +0000913 if post_amend_description is None:
914 post_amend_description = description
bradnelsond975b302016-10-23 12:20:23 -0700915 cc = cc or []
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200916 # Determined in `_gerrit_base_calls`.
917 determined_ancestor_revision = custom_cl_base or 'fake_ancestor_sha'
918
919 calls = []
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000920
tandriia60502f2016-06-20 02:01:53 -0700921 if squash_mode == 'default':
922 calls.extend([
923 ((['git', 'config', '--bool', 'gerrit.override-squash-uploads'],), ''),
924 ((['git', 'config', '--bool', 'gerrit.squash-uploads'],), ''),
925 ])
926 elif squash_mode in ('override_squash', 'override_nosquash'):
927 calls.extend([
928 ((['git', 'config', '--bool', 'gerrit.override-squash-uploads'],),
929 'true' if squash_mode == 'override_squash' else 'false'),
930 ])
931 else:
932 assert squash_mode in ('squash', 'nosquash')
933
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000934 # If issue is given, then description is fetched from Gerrit instead.
935 if issue is None:
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000936 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200937 ((['git', 'log', '--pretty=format:%s\n\n%b',
938 ((custom_cl_base + '..') if custom_cl_base else
939 'fake_ancestor_sha..HEAD')],),
940 description),
941 ]
Aaron Gableb56ad332017-01-06 15:24:31 -0800942 if squash:
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +0000943 title = 'Initial_upload'
Aaron Gableb56ad332017-01-06 15:24:31 -0800944 else:
945 if not title:
946 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200947 ((['git', 'show', '-s', '--format=%s', 'HEAD'],), ''),
948 (('ask_for_data', 'Title for patchset []: '), 'User input'),
Aaron Gableb56ad332017-01-06 15:24:31 -0800949 ]
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +0000950 title = 'User_input'
tandrii@chromium.org57d86542016-03-04 16:11:32 +0000951 if not git_footers.get_footer_change_id(description) and not squash:
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000952 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200953 (('DownloadGerritHook', False), ''),
954 # Amending of commit message to get the Change-Id.
955 ((['git', 'log', '--pretty=format:%s\n\n%b',
956 determined_ancestor_revision + '..HEAD'],),
957 description),
958 ((['git', 'commit', '--amend', '-m', description],), ''),
959 ((['git', 'log', '--pretty=format:%s\n\n%b',
960 determined_ancestor_revision + '..HEAD'],),
961 post_amend_description)
962 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000963 if squash:
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000964 if not issue:
965 # Prompting to edit description on first upload.
966 calls += [
Jonas Termansend0f79112019-03-22 15:28:26 +0000967 ((['git', 'config', 'rietveld.bug-prefix'],), ''),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200968 ((['git', 'config', 'core.editor'],), ''),
969 ((['RunEditor'],), description),
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000970 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000971 ref_to_push = 'abcdef0123456789'
972 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200973 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
974 ((['git', 'config', 'branch.master.remote'],), 'origin'),
975 ]
976
977 if custom_cl_base is None:
978 calls += [
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000979 ((['get_or_create_merge_base', 'master',
980 'refs/remotes/origin/master'],),
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000981 'origin/master'),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200982 ]
983 parent = 'origin/master'
984 else:
985 calls += [
986 ((['git', 'merge-base', '--is-ancestor', custom_cl_base,
987 'refs/remotes/origin/master'],),
988 callError(1)), # Means not ancenstor.
989 (('ask_for_data',
990 'Do you take responsibility for cleaning up potential mess '
991 'resulting from proceeding with upload? Press Enter to upload, '
992 'or Ctrl+C to abort'), ''),
993 ]
994 parent = custom_cl_base
995
996 calls += [
997 ((['git', 'rev-parse', 'HEAD:'],), # `HEAD:` means HEAD's tree hash.
998 '0123456789abcdef'),
999 ((['git', 'commit-tree', '0123456789abcdef', '-p', parent,
Aaron Gable9a03ae02017-11-03 11:31:07 -07001000 '-F', '/tmp/named'],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001001 ref_to_push),
1002 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001003 else:
1004 ref_to_push = 'HEAD'
1005
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001006 calls += [
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +00001007 (('SaveDescriptionBackup',), None),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001008 ((['git', 'rev-list',
1009 (custom_cl_base if custom_cl_base else expected_upstream_ref) + '..' +
1010 ref_to_push],),
1011 '1hashPerLine\n'),
1012 ]
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001013
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001014 metrics_arguments = []
1015
Aaron Gableafd52772017-06-27 16:40:10 -07001016 if notify:
Aaron Gable844cf292017-06-28 11:32:59 -07001017 ref_suffix = '%ready,notify=ALL'
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001018 metrics_arguments += ['ready', 'notify=ALL']
Aaron Gable844cf292017-06-28 11:32:59 -07001019 else:
Jamie Madill276da0b2018-04-27 14:41:20 -04001020 if not issue and squash:
Aaron Gable844cf292017-06-28 11:32:59 -07001021 ref_suffix = '%wip'
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001022 metrics_arguments.append('wip')
Aaron Gable844cf292017-06-28 11:32:59 -07001023 else:
1024 ref_suffix = '%notify=NONE'
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001025 metrics_arguments.append('notify=NONE')
Aaron Gable9b713dd2016-12-14 16:04:21 -08001026
Aaron Gable70f4e242017-06-26 10:45:59 -07001027 if title:
Aaron Gableafd52772017-06-27 16:40:10 -07001028 ref_suffix += ',m=' + title
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001029 metrics_arguments.append('m')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001030
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00001031 calls += [
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +00001032 ((['git', 'config', 'rietveld.cc'],), ''),
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00001033 ]
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001034 if short_hostname == 'chromium':
1035 # All reviwers and ccs get into ref_suffix.
1036 for r in sorted(reviewers):
1037 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001038 metrics_arguments.append('r')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001039 for c in sorted(['chromium-reviews+test-more-cc@chromium.org',
1040 'joe@example.com'] + cc):
1041 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001042 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001043 reviewers, cc = [], []
1044 else:
1045 # TODO(crbug/877717): remove this case.
1046 calls += [
1047 (('ValidAccounts', '%s-review.googlesource.com' % short_hostname,
1048 sorted(reviewers) + ['joe@example.com',
1049 'chromium-reviews+test-more-cc@chromium.org'] + cc),
1050 {
1051 e: {'email': e}
1052 for e in (reviewers + ['joe@example.com'] + cc)
1053 })
1054 ]
1055 for r in sorted(reviewers):
1056 if r != 'bad-account-or-email':
1057 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001058 metrics_arguments.append('r')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001059 reviewers.remove(r)
1060 for c in sorted(['joe@example.com'] + cc):
1061 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001062 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001063 if c in cc:
1064 cc.remove(c)
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00001065
Edward Lemur687ca902018-12-05 02:30:30 +00001066 for k, v in sorted((labels or {}).items()):
1067 ref_suffix += ',l=%s+%d' % (k, v)
1068 metrics_arguments.append('l=%s+%d' % (k, v))
1069
1070 if tbr:
1071 calls += [
1072 (('GetCodeReviewTbrScore',
1073 '%s-review.googlesource.com' % short_hostname,
1074 'my/repo'),
1075 2,),
1076 ]
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001077
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001078 calls += [
1079 (('time.time',), 1000,),
1080 ((['git', 'push',
1081 'https://%s.googlesource.com/my/repo' % short_hostname,
1082 ref_to_push + ':refs/for/refs/heads/master' + ref_suffix],),
1083 (('remote:\n'
1084 'remote: Processing changes: (\)\n'
1085 'remote: Processing changes: (|)\n'
1086 'remote: Processing changes: (/)\n'
1087 'remote: Processing changes: (-)\n'
1088 'remote: Processing changes: new: 1 (/)\n'
1089 'remote: Processing changes: new: 1, done\n'
1090 'remote:\n'
1091 'remote: New Changes:\n'
1092 'remote: https://%s-review.googlesource.com/#/c/my/repo/+/123456'
1093 ' XXX\n'
1094 'remote:\n'
1095 'To https://%s.googlesource.com/my/repo\n'
1096 ' * [new branch] hhhh -> refs/for/refs/heads/master\n'
1097 ) % (short_hostname, short_hostname)),),
1098 (('time.time',), 2000,),
1099 (('add_repeated',
1100 'sub_commands',
1101 {
1102 'execution_time': 1000,
1103 'command': 'git push',
1104 'exit_code': 0,
1105 'arguments': sorted(metrics_arguments),
1106 }),
1107 None,),
1108 ]
1109
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001110 if squash:
1111 calls += [
tandrii33a46ff2016-08-23 05:53:40 -07001112 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001113 ''),
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001114 ((['git', 'config', 'branch.master.gerritserver',
tandrii5d48c322016-08-18 16:19:37 -07001115 'https://chromium-review.googlesource.com'],), ''),
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001116 ((['git', 'config', 'branch.master.gerritsquashhash',
1117 'abcdef0123456789'],), ''),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001118 ]
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001119 # TODO(crbug/877717): this should never be used.
1120 if squash and short_hostname != 'chromium':
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001121 calls += [
1122 (('AddReviewers',
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00001123 'chromium-review.googlesource.com', 'my%2Frepo~123456',
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001124 sorted(reviewers),
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00001125 cc + ['chromium-reviews+test-more-cc@chromium.org'],
1126 notify),
1127 ''),
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001128 ]
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +00001129 calls += cls._git_post_upload_calls()
ukai@chromium.orge8077812012-02-03 03:41:46 +00001130 return calls
1131
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001132 def _run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001133 self,
1134 upload_args,
1135 description,
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001136 reviewers=None,
tandriia60502f2016-06-20 02:01:53 -07001137 squash=True,
1138 squash_mode=None,
tandrii@chromium.org10625002016-03-04 20:03:47 +00001139 expected_upstream_ref='origin/refs/heads/master',
Aaron Gable9b713dd2016-12-14 16:04:21 -08001140 title=None,
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001141 notify=False,
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001142 post_amend_description=None,
bradnelsond975b302016-10-23 12:20:23 -07001143 issue=None,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +01001144 cc=None,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001145 fetched_status=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001146 other_cl_owner=None,
Aaron Gablefd238082017-06-07 13:42:34 -07001147 custom_cl_base=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001148 tbr=None,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001149 short_hostname='chromium',
1150 labels=None):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001151 """Generic gerrit upload test framework."""
tandriia60502f2016-06-20 02:01:53 -07001152 if squash_mode is None:
1153 if '--no-squash' in upload_args:
1154 squash_mode = 'nosquash'
1155 elif '--squash' in upload_args:
1156 squash_mode = 'squash'
1157 else:
1158 squash_mode = 'default'
1159
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001160 reviewers = reviewers or []
bradnelsond975b302016-10-23 12:20:23 -07001161 cc = cc or []
tandrii@chromium.org28253532016-04-14 13:46:56 +00001162 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii16e0b4e2016-06-07 10:34:28 -07001163 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001164 CookiesAuthenticatorMockFactory(
1165 same_auth=('git-owner.example.com', '', 'pass')))
tandrii16e0b4e2016-06-07 10:34:28 -07001166 self.mock(git_cl._GerritChangelistImpl, '_GerritCommitMsgHookCheck',
1167 lambda _, offer_removal: None)
tandriia60502f2016-06-20 02:01:53 -07001168 self.mock(git_cl.gclient_utils, 'RunEditor',
1169 lambda *_, **__: self._mocked_call(['RunEditor']))
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001170 self.mock(git_cl, 'DownloadGerritHook', lambda force: self._mocked_call(
1171 'DownloadGerritHook', force))
tandriia60502f2016-06-20 02:01:53 -07001172
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001173 self.calls = self._gerrit_base_calls(
1174 issue=issue,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001175 fetched_description=description,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001176 fetched_status=fetched_status,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001177 other_cl_owner=other_cl_owner,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001178 custom_cl_base=custom_cl_base,
1179 short_hostname=short_hostname)
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001180 if fetched_status != 'ABANDONED':
Aaron Gable9a03ae02017-11-03 11:31:07 -07001181 self.mock(tempfile, 'NamedTemporaryFile', MakeNamedTemporaryFileMock(
1182 expected_content=description))
1183 self.mock(os, 'remove', lambda _: True)
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001184 self.calls += self._gerrit_upload_calls(
1185 description, reviewers, squash,
1186 squash_mode=squash_mode,
1187 expected_upstream_ref=expected_upstream_ref,
Aaron Gablefd238082017-06-07 13:42:34 -07001188 title=title, notify=notify,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001189 post_amend_description=post_amend_description,
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001190 issue=issue, cc=cc,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001191 custom_cl_base=custom_cl_base, tbr=tbr,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001192 short_hostname=short_hostname,
1193 labels=labels)
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001194 # Uncomment when debugging.
1195 # print '\n'.join(map(lambda x: '%2i: %s' % x, enumerate(self.calls)))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001196 git_cl.main(['upload'] + upload_args)
1197
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001198 def test_gerrit_upload_without_change_id(self):
tandriia60502f2016-06-20 02:01:53 -07001199 self._run_gerrit_upload_test(
1200 ['--no-squash'],
1201 'desc\n\nBUG=\n',
1202 [],
1203 squash=False,
1204 post_amend_description='desc\n\nBUG=\n\nChange-Id: Ixxx')
1205
1206 def test_gerrit_upload_without_change_id_override_nosquash(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001207 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001208 [],
jamesr@chromium.org35d1a842012-07-27 00:20:43 +00001209 'desc\n\nBUG=\n',
tandrii@chromium.org10625002016-03-04 20:03:47 +00001210 [],
tandriia60502f2016-06-20 02:01:53 -07001211 squash=False,
1212 squash_mode='override_nosquash',
tandrii@chromium.org10625002016-03-04 20:03:47 +00001213 post_amend_description='desc\n\nBUG=\n\nChange-Id: Ixxx')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001214
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001215 def test_gerrit_no_reviewer(self):
1216 self._run_gerrit_upload_test(
1217 [],
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001218 'desc\n\nBUG=\n\nChange-Id: I123456789\n',
tandriia60502f2016-06-20 02:01:53 -07001219 [],
1220 squash=False,
1221 squash_mode='override_nosquash')
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001222
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001223 def test_gerrit_no_reviewer_non_chromium_host(self):
1224 # TODO(crbug/877717): remove this test case.
1225 self._run_gerrit_upload_test(
1226 [],
1227 'desc\n\nBUG=\n\nChange-Id: I123456789\n',
1228 [],
1229 squash=False,
1230 squash_mode='override_nosquash',
1231 short_hostname='other')
1232
Nick Carter8692b182017-11-06 16:30:38 -08001233 def test_gerrit_patchset_title_special_chars(self):
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001234 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
1235 self._run_gerrit_upload_test(
Nick Carter8692b182017-11-06 16:30:38 -08001236 ['-f', '-t', 'We\'ll escape ^_ ^ special chars...@{u}'],
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001237 'desc\n\nBUG=\n\nChange-Id: I123456789',
1238 squash=False,
1239 squash_mode='override_nosquash',
Nick Carter8692b182017-11-06 16:30:38 -08001240 title='We%27ll_escape_%5E%5F_%5E_special_chars%2E%2E%2E%40%7Bu%7D')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001241
ukai@chromium.orge8077812012-02-03 03:41:46 +00001242 def test_gerrit_reviewers_cmd_line(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001243 self._run_gerrit_upload_test(
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001244 ['-r', 'foo@example.com', '--send-mail'],
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001245 'desc\n\nBUG=\n\nChange-Id: I123456789',
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001246 ['foo@example.com'],
tandriia60502f2016-06-20 02:01:53 -07001247 squash=False,
1248 squash_mode='override_nosquash',
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001249 notify=True)
ukai@chromium.orge8077812012-02-03 03:41:46 +00001250
1251 def test_gerrit_reviewer_multiple(self):
Edward Lemur687ca902018-12-05 02:30:30 +00001252 self.mock(git_cl.gerrit_util, 'GetCodeReviewTbrScore',
1253 lambda *a: self._mocked_call('GetCodeReviewTbrScore', *a))
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001254 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001255 [],
bradnelsond975b302016-10-23 12:20:23 -07001256 'desc\nTBR=reviewer@example.com\nBUG=\nR=another@example.com\n'
1257 'CC=more@example.com,people@example.com\n\n'
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001258 'Change-Id: 123456789',
tandriia60502f2016-06-20 02:01:53 -07001259 ['reviewer@example.com', 'another@example.com'],
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001260 expected_upstream_ref='origin/master',
Aaron Gablefd238082017-06-07 13:42:34 -07001261 cc=['more@example.com', 'people@example.com'],
Edward Lemur687ca902018-12-05 02:30:30 +00001262 tbr='reviewer@example.com',
1263 labels={'Code-Review': 2})
tandriia60502f2016-06-20 02:01:53 -07001264
1265 def test_gerrit_upload_squash_first_is_default(self):
tandriia60502f2016-06-20 02:01:53 -07001266 self._run_gerrit_upload_test(
1267 [],
1268 'desc\nBUG=\n\nChange-Id: 123456789',
1269 [],
1270 expected_upstream_ref='origin/master')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001271
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001272 def test_gerrit_upload_squash_first(self):
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001273 self._run_gerrit_upload_test(
1274 ['--squash'],
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001275 'desc\nBUG=\n\nChange-Id: 123456789',
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001276 [],
luqui@chromium.org609f3952015-05-04 22:47:04 +00001277 squash=True,
1278 expected_upstream_ref='origin/master')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001279
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001280 def test_gerrit_upload_squash_first_with_labels(self):
1281 self._run_gerrit_upload_test(
1282 ['--squash', '--cq-dry-run', '--enable-auto-submit'],
1283 'desc\nBUG=\n\nChange-Id: 123456789',
1284 [],
1285 squash=True,
1286 expected_upstream_ref='origin/master',
1287 labels={'Commit-Queue': 1, 'Auto-Submit': 1})
1288
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001289 def test_gerrit_upload_squash_first_against_rev(self):
1290 custom_cl_base = 'custom_cl_base_rev_or_branch'
1291 self._run_gerrit_upload_test(
1292 ['--squash', custom_cl_base],
1293 'desc\nBUG=\n\nChange-Id: 123456789',
1294 [],
1295 squash=True,
1296 expected_upstream_ref='origin/master',
1297 custom_cl_base=custom_cl_base)
1298 self.assertIn(
1299 'If you proceed with upload, more than 1 CL may be created by Gerrit',
1300 sys.stdout.getvalue())
1301
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001302 def test_gerrit_upload_squash_reupload(self):
1303 description = 'desc\nBUG=\n\nChange-Id: 123456789'
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001304 self._run_gerrit_upload_test(
1305 ['--squash'],
1306 description,
1307 [],
1308 squash=True,
1309 expected_upstream_ref='origin/master',
1310 issue=123456)
1311
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001312 def test_gerrit_upload_squash_reupload_to_abandoned(self):
1313 self.mock(git_cl, 'DieWithError',
1314 lambda msg, change=None: self._mocked_call('DieWithError', msg))
1315 description = 'desc\nBUG=\n\nChange-Id: 123456789'
1316 with self.assertRaises(SystemExitMock):
1317 self._run_gerrit_upload_test(
1318 ['--squash'],
1319 description,
1320 [],
1321 squash=True,
1322 expected_upstream_ref='origin/master',
1323 issue=123456,
1324 fetched_status='ABANDONED')
1325
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001326 def test_gerrit_upload_squash_reupload_to_not_owned(self):
1327 self.mock(git_cl.gerrit_util, 'GetAccountDetails',
1328 lambda *_, **__: {'email': 'yet-another@example.com'})
1329 description = 'desc\nBUG=\n\nChange-Id: 123456789'
1330 self._run_gerrit_upload_test(
1331 ['--squash'],
1332 description,
1333 [],
1334 squash=True,
1335 expected_upstream_ref='origin/master',
1336 issue=123456,
1337 other_cl_owner='other@example.com')
1338 self.assertIn(
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001339 'WARNING: Change 123456 is owned by other@example.com, but you '
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001340 'authenticate to Gerrit as yet-another@example.com.\n'
1341 'Uploading may fail due to lack of permissions',
1342 git_cl.sys.stdout.getvalue())
1343
rmistry@google.com2dd99862015-06-22 12:22:18 +00001344 def test_upload_branch_deps(self):
tandrii@chromium.org28253532016-04-14 13:46:56 +00001345 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
rmistry@google.com2dd99862015-06-22 12:22:18 +00001346 def mock_run_git(*args, **_kwargs):
1347 if args[0] == ['for-each-ref',
1348 '--format=%(refname:short) %(upstream:short)',
1349 'refs/heads']:
1350 # Create a local branch dependency tree that looks like this:
1351 # test1 -> test2 -> test3 -> test4 -> test5
1352 # -> test3.1
1353 # test6 -> test0
1354 branch_deps = [
1355 'test2 test1', # test1 -> test2
1356 'test3 test2', # test2 -> test3
1357 'test3.1 test2', # test2 -> test3.1
1358 'test4 test3', # test3 -> test4
1359 'test5 test4', # test4 -> test5
1360 'test6 test0', # test0 -> test6
1361 'test7', # test7
1362 ]
1363 return '\n'.join(branch_deps)
1364 self.mock(git_cl, 'RunGit', mock_run_git)
1365
1366 class RecordCalls:
1367 times_called = 0
1368 record_calls = RecordCalls()
1369 def mock_CMDupload(*args, **_kwargs):
1370 record_calls.times_called += 1
1371 return 0
1372 self.mock(git_cl, 'CMDupload', mock_CMDupload)
1373
1374 self.calls = [
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001375 (('ask_for_data', 'This command will checkout all dependent branches '
1376 'and run "git cl upload". Press Enter to continue, '
1377 'or Ctrl+C to abort'), ''),
1378 ]
rmistry@google.com2dd99862015-06-22 12:22:18 +00001379
1380 class MockChangelist():
1381 def __init__(self):
1382 pass
1383 def GetBranch(self):
1384 return 'test1'
1385 def GetIssue(self):
1386 return '123'
1387 def GetPatchset(self):
1388 return '1001'
tandrii@chromium.org4c72b082016-03-31 22:26:35 +00001389 def IsGerrit(self):
1390 return False
rmistry@google.com2dd99862015-06-22 12:22:18 +00001391
1392 ret = git_cl.upload_branch_deps(MockChangelist(), [])
1393 # CMDupload should have been called 5 times because of 5 dependent branches.
1394 self.assertEquals(5, record_calls.times_called)
1395 self.assertEquals(0, ret)
1396
tandrii@chromium.org65874e12016-03-04 12:03:02 +00001397 def test_gerrit_change_id(self):
1398 self.calls = [
1399 ((['git', 'write-tree'], ),
1400 'hashtree'),
1401 ((['git', 'rev-parse', 'HEAD~0'], ),
1402 'branch-parent'),
1403 ((['git', 'var', 'GIT_AUTHOR_IDENT'], ),
1404 'A B <a@b.org> 1456848326 +0100'),
1405 ((['git', 'var', 'GIT_COMMITTER_IDENT'], ),
1406 'C D <c@d.org> 1456858326 +0100'),
1407 ((['git', 'hash-object', '-t', 'commit', '--stdin'], ),
1408 'hashchange'),
1409 ]
1410 change_id = git_cl.GenerateGerritChangeId('line1\nline2\n')
1411 self.assertEqual(change_id, 'Ihashchange')
1412
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00001413 def test_desecription_append_footer(self):
1414 for init_desc, footer_line, expected_desc in [
1415 # Use unique desc first lines for easy test failure identification.
1416 ('foo', 'R=one', 'foo\n\nR=one'),
1417 ('foo\n\nR=one', 'BUG=', 'foo\n\nR=one\nBUG='),
1418 ('foo\n\nR=one', 'Change-Id: Ixx', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1419 ('foo\n\nChange-Id: Ixx', 'R=one', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1420 ('foo\n\nR=one\n\nChange-Id: Ixx', 'TBR=two',
1421 'foo\n\nR=one\nTBR=two\n\nChange-Id: Ixx'),
1422 ('foo\n\nR=one\n\nChange-Id: Ixx', 'Foo-Bar: baz',
1423 'foo\n\nR=one\n\nChange-Id: Ixx\nFoo-Bar: baz'),
1424 ('foo\n\nChange-Id: Ixx', 'Foo-Bak: baz',
1425 'foo\n\nChange-Id: Ixx\nFoo-Bak: baz'),
1426 ('foo', 'Change-Id: Ixx', 'foo\n\nChange-Id: Ixx'),
1427 ]:
1428 desc = git_cl.ChangeDescription(init_desc)
1429 desc.append_footer(footer_line)
1430 self.assertEqual(desc.description, expected_desc)
1431
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001432 def test_update_reviewers(self):
1433 data = [
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001434 ('foo', [], [],
1435 'foo'),
1436 ('foo\nR=xx', [], [],
1437 'foo\nR=xx'),
1438 ('foo\nTBR=xx', [], [],
1439 'foo\nTBR=xx'),
1440 ('foo', ['a@c'], [],
1441 'foo\n\nR=a@c'),
1442 ('foo\nR=xx', ['a@c'], [],
1443 'foo\n\nR=a@c, xx'),
1444 ('foo\nTBR=xx', ['a@c'], [],
1445 'foo\n\nR=a@c\nTBR=xx'),
1446 ('foo\nTBR=xx\nR=yy', ['a@c'], [],
1447 'foo\n\nR=a@c, yy\nTBR=xx'),
1448 ('foo\nBUG=', ['a@c'], [],
1449 'foo\nBUG=\nR=a@c'),
1450 ('foo\nR=xx\nTBR=yy\nR=bar', ['a@c'], [],
1451 'foo\n\nR=a@c, bar, xx\nTBR=yy'),
1452 ('foo', ['a@c', 'b@c'], [],
1453 'foo\n\nR=a@c, b@c'),
1454 ('foo\nBar\n\nR=\nBUG=', ['c@c'], [],
1455 'foo\nBar\n\nR=c@c\nBUG='),
1456 ('foo\nBar\n\nR=\nBUG=\nR=', ['c@c'], [],
1457 'foo\nBar\n\nR=c@c\nBUG='),
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001458 # Same as the line before, but full of whitespaces.
1459 (
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001460 'foo\nBar\n\n R = \n BUG = \n R = ', ['c@c'], [],
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001461 'foo\nBar\n\nR=c@c\n BUG =',
1462 ),
1463 # Whitespaces aren't interpreted as new lines.
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001464 ('foo BUG=allo R=joe ', ['c@c'], [],
1465 'foo BUG=allo R=joe\n\nR=c@c'),
1466 # Redundant TBRs get promoted to Rs
1467 ('foo\n\nR=a@c\nTBR=t@c', ['b@c', 'a@c'], ['a@c', 't@c'],
1468 'foo\n\nR=a@c, b@c\nTBR=t@c'),
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001469 ]
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001470 expected = [i[-1] for i in data]
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001471 actual = []
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001472 for orig, reviewers, tbrs, _expected in data:
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001473 obj = git_cl.ChangeDescription(orig)
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001474 obj.update_reviewers(reviewers, tbrs)
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001475 actual.append(obj.description)
1476 self.assertEqual(expected, actual)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001477
Nodir Turakulov23b82142017-11-16 11:04:25 -08001478 def test_get_hash_tags(self):
1479 cases = [
1480 ('', []),
1481 ('a', []),
1482 ('[a]', ['a']),
1483 ('[aa]', ['aa']),
1484 ('[a ]', ['a']),
1485 ('[a- ]', ['a']),
1486 ('[a- b]', ['a-b']),
1487 ('[a--b]', ['a-b']),
1488 ('[a', []),
1489 ('[a]x', ['a']),
1490 ('[aa]x', ['aa']),
1491 ('[a b]', ['a-b']),
1492 ('[a b]', ['a-b']),
1493 ('[a__b]', ['a-b']),
1494 ('[a] x', ['a']),
1495 ('[a][b]', ['a', 'b']),
1496 ('[a] [b]', ['a', 'b']),
1497 ('[a][b]x', ['a', 'b']),
1498 ('[a][b] x', ['a', 'b']),
1499 ('[a]\n[b]', ['a']),
1500 ('[a\nb]', []),
1501 ('[a][', ['a']),
1502 ('Revert "[a] feature"', ['a']),
1503 ('Reland "[a] feature"', ['a']),
1504 ('Revert: [a] feature', ['a']),
1505 ('Reland: [a] feature', ['a']),
1506 ('Revert "Reland: [a] feature"', ['a']),
1507 ('Foo: feature', ['foo']),
1508 ('Foo Bar: feature', ['foo-bar']),
1509 ('Revert "Foo bar: feature"', ['foo-bar']),
1510 ('Reland "Foo bar: feature"', ['foo-bar']),
1511 ]
1512 for desc, expected in cases:
1513 change_desc = git_cl.ChangeDescription(desc)
1514 actual = change_desc.get_hash_tags()
1515 self.assertEqual(
1516 actual,
1517 expected,
1518 'GetHashTags(%r) == %r, expected %r' % (desc, actual, expected))
1519
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001520
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001521 self.assertEqual(None, git_cl.GetTargetRef('origin', None, 'master'))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001522 self.assertEqual(None, git_cl.GetTargetRef(None,
1523 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001524 'master'))
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001525
wittman@chromium.org455dc922015-01-26 20:15:50 +00001526 # Check default target refs for branches.
1527 self.assertEqual('refs/heads/master',
1528 git_cl.GetTargetRef('origin', 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001529 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001530 self.assertEqual('refs/heads/master',
1531 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkgr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001532 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001533 self.assertEqual('refs/heads/master',
1534 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkcr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001535 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001536 self.assertEqual('refs/branch-heads/123',
1537 git_cl.GetTargetRef('origin',
1538 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001539 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001540 self.assertEqual('refs/diff/test',
1541 git_cl.GetTargetRef('origin',
1542 'refs/remotes/origin/refs/diff/test',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001543 None))
rmistry@google.comc68112d2015-03-03 12:48:06 +00001544 self.assertEqual('refs/heads/chrome/m42',
1545 git_cl.GetTargetRef('origin',
1546 'refs/remotes/origin/chrome/m42',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001547 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001548
1549 # Check target refs for user-specified target branch.
1550 for branch in ('branch-heads/123', 'remotes/branch-heads/123',
1551 'refs/remotes/branch-heads/123'):
1552 self.assertEqual('refs/branch-heads/123',
1553 git_cl.GetTargetRef('origin',
1554 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001555 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001556 for branch in ('origin/master', 'remotes/origin/master',
1557 'refs/remotes/origin/master'):
1558 self.assertEqual('refs/heads/master',
1559 git_cl.GetTargetRef('origin',
1560 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001561 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001562 for branch in ('master', 'heads/master', 'refs/heads/master'):
1563 self.assertEqual('refs/heads/master',
1564 git_cl.GetTargetRef('origin',
1565 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001566 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001567
wychen@chromium.orga872e752015-04-28 23:42:18 +00001568 def test_patch_when_dirty(self):
1569 # Patch when local tree is dirty
1570 self.mock(git_common, 'is_dirty_git_tree', lambda x: True)
1571 self.assertNotEqual(git_cl.main(['patch', '123456']), 0)
1572
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001573 @staticmethod
1574 def _get_gerrit_codereview_server_calls(branch, value=None,
1575 git_short_host='host',
Aaron Gable697a91b2018-01-19 15:20:15 -08001576 detect_branch=True,
1577 detect_server=True):
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001578 """Returns calls executed by _GerritChangelistImpl.GetCodereviewServer.
1579
1580 If value is given, branch.<BRANCH>.gerritcodereview is already set.
1581 """
1582 calls = []
1583 if detect_branch:
1584 calls.append(((['git', 'symbolic-ref', 'HEAD'],), branch))
Aaron Gable697a91b2018-01-19 15:20:15 -08001585 if detect_server:
1586 calls.append(((['git', 'config', 'branch.' + branch + '.gerritserver'],),
1587 CERR1 if value is None else value))
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001588 if value is None:
1589 calls += [
1590 ((['git', 'config', 'branch.' + branch + '.merge'],),
1591 'refs/heads' + branch),
1592 ((['git', 'config', 'branch.' + branch + '.remote'],),
1593 'origin'),
1594 ((['git', 'config', 'remote.origin.url'],),
1595 'https://%s.googlesource.com/my/repo' % git_short_host),
1596 ]
1597 return calls
1598
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001599 def _patch_common(self, force_codereview=False,
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001600 new_branch=False, git_short_host='host',
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001601 detect_gerrit_server=False,
1602 actual_codereview=None,
1603 codereview_in_url=False):
tandrii@chromium.org28253532016-04-14 13:46:56 +00001604 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
wychen@chromium.orga872e752015-04-28 23:42:18 +00001605 self.mock(git_cl, 'IsGitVersionAtLeast', lambda *args: True)
1606
tandriidf09a462016-08-18 16:23:55 -07001607 if new_branch:
1608 self.calls = [((['git', 'new-branch', 'master'],), ''),]
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001609
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001610 if codereview_in_url and actual_codereview == 'rietveld':
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001611 self.calls += [
1612 ((['git', 'rev-parse', '--show-cdup'],), ''),
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001613 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001614 ]
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001615
1616 if not force_codereview and not codereview_in_url:
1617 # These calls detect codereview to use.
1618 self.calls += [
1619 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001620 ((['git', 'config', 'branch.master.gerritissue'],), CERR1),
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001621 ]
1622 if detect_gerrit_server:
1623 self.calls += self._get_gerrit_codereview_server_calls(
1624 'master', git_short_host=git_short_host,
1625 detect_branch=not new_branch and force_codereview)
1626 actual_codereview = 'gerrit'
1627
1628 if actual_codereview == 'gerrit':
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001629 self.calls += [
1630 (('GetChangeDetail', git_short_host + '-review.googlesource.com',
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001631 'my%2Frepo~123456', ['ALL_REVISIONS', 'CURRENT_COMMIT']),
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001632 {
1633 'current_revision': '7777777777',
1634 'revisions': {
1635 '1111111111': {
1636 '_number': 1,
1637 'fetch': {'http': {
1638 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1639 'ref': 'refs/changes/56/123456/1',
1640 }},
1641 },
1642 '7777777777': {
1643 '_number': 7,
1644 'fetch': {'http': {
1645 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1646 'ref': 'refs/changes/56/123456/7',
1647 }},
1648 },
1649 },
1650 }),
1651 ]
wychen@chromium.orga872e752015-04-28 23:42:18 +00001652
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001653 def test_patch_gerrit_default(self):
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001654 self._patch_common(git_short_host='chromium', detect_gerrit_server=True)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001655 self.calls += [
1656 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1657 'refs/changes/56/123456/7'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001658 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001659 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
Aaron Gable697a91b2018-01-19 15:20:15 -08001660 ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001661 ((['git', 'config', 'branch.master.gerritserver',
1662 'https://chromium-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001663 ((['git', 'config', 'branch.master.gerritpatchset', '7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001664 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1665 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1666 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001667 ]
1668 self.assertEqual(git_cl.main(['patch', '123456']), 0)
1669
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001670 def test_patch_gerrit_new_branch(self):
1671 self._patch_common(
1672 git_short_host='chromium', detect_gerrit_server=True, new_branch=True)
1673 self.calls += [
1674 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1675 'refs/changes/56/123456/7'],), ''),
1676 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
1677 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
1678 ''),
1679 ((['git', 'config', 'branch.master.gerritserver',
1680 'https://chromium-review.googlesource.com'],), ''),
1681 ((['git', 'config', 'branch.master.gerritpatchset', '7'],), ''),
1682 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1683 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1684 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
1685 ]
1686 self.assertEqual(git_cl.main(['patch', '-b', 'master', '123456']), 0)
1687
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001688 def test_patch_gerrit_force(self):
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001689 self._patch_common(
1690 force_codereview=True, git_short_host='host', detect_gerrit_server=True)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001691 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001692 ((['git', 'fetch', 'https://host.googlesource.com/my/repo',
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001693 'refs/changes/56/123456/7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001694 ((['git', 'reset', '--hard', 'FETCH_HEAD'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001695 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001696 ''),
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001697 ((['git', 'config', 'branch.master.gerritserver',
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001698 'https://host-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001699 ((['git', 'config', 'branch.master.gerritpatchset', '7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001700 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1701 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1702 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001703 ]
Aaron Gable62619a32017-06-16 08:22:09 -07001704 self.assertEqual(git_cl.main(['patch', '--gerrit', '123456', '--force']), 0)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001705
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001706 def test_patch_gerrit_guess_by_url(self):
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001707 self.calls += self._get_gerrit_codereview_server_calls(
1708 'master', git_short_host='else', detect_server=False)
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001709 self._patch_common(
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001710 actual_codereview='gerrit', git_short_host='else',
1711 codereview_in_url=True, detect_gerrit_server=False)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001712 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001713 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001714 'refs/changes/56/123456/1'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001715 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001716 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001717 ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001718 ((['git', 'config', 'branch.master.gerritserver',
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001719 'https://else-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001720 ((['git', 'config', 'branch.master.gerritpatchset', '1'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001721 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1722 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1723 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001724 ]
1725 self.assertEqual(git_cl.main(
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001726 ['patch', 'https://else-review.googlesource.com/#/c/123456/1']), 0)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001727
Aaron Gable697a91b2018-01-19 15:20:15 -08001728 def test_patch_gerrit_guess_by_url_with_repo(self):
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001729 self.calls += self._get_gerrit_codereview_server_calls(
1730 'master', git_short_host='else', detect_server=False)
Aaron Gable697a91b2018-01-19 15:20:15 -08001731 self._patch_common(
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001732 actual_codereview='gerrit', git_short_host='else',
1733 codereview_in_url=True, detect_gerrit_server=False)
Aaron Gable697a91b2018-01-19 15:20:15 -08001734 self.calls += [
1735 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
1736 'refs/changes/56/123456/1'],), ''),
1737 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
1738 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
1739 ''),
1740 ((['git', 'config', 'branch.master.gerritserver',
1741 'https://else-review.googlesource.com'],), ''),
1742 ((['git', 'config', 'branch.master.gerritpatchset', '1'],), ''),
1743 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1744 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1745 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
1746 ]
1747 self.assertEqual(git_cl.main(
1748 ['patch', 'https://else-review.googlesource.com/c/my/repo/+/123456/1']),
1749 0)
1750
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001751 def test_patch_gerrit_conflict(self):
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001752 self._patch_common(detect_gerrit_server=True, git_short_host='chromium')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001753 self.calls += [
1754 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001755 'refs/changes/56/123456/7'],), ''),
tandrii5d48c322016-08-18 16:19:37 -07001756 ((['git', 'cherry-pick', 'FETCH_HEAD'],), CERR1),
1757 ((['DieWithError', 'Command "git cherry-pick FETCH_HEAD" failed.\n'],),
1758 SystemExitMock()),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001759 ]
1760 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001761 git_cl.main(['patch', '123456'])
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001762
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001763 def test_patch_gerrit_not_exists(self):
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01001764 def notExists(_issue, *_, **kwargs):
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01001765 raise git_cl.gerrit_util.GerritError(404, '')
1766 self.mock(git_cl.gerrit_util, 'GetChangeDetail', notExists)
1767
tandriic2405f52016-10-10 08:13:15 -07001768 self.calls = [
1769 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
tandriic2405f52016-10-10 08:13:15 -07001770 ((['git', 'config', 'branch.master.gerritissue'],), CERR1),
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001771 ((['git', 'config', 'branch.master.gerritserver'],), CERR1),
1772 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
1773 ((['git', 'config', 'branch.master.remote'],), 'origin'),
1774 ((['git', 'config', 'remote.origin.url'],),
1775 'https://chromium.googlesource.com/my/repo'),
1776 ((['DieWithError',
1777 'change 123456 at https://chromium-review.googlesource.com does not '
1778 'exist or you have no access to it'],), SystemExitMock()),
tandriic2405f52016-10-10 08:13:15 -07001779 ]
1780 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001781 self.assertEqual(1, git_cl.main(['patch', '123456']))
tandriic2405f52016-10-10 08:13:15 -07001782
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001783 def _checkout_calls(self):
1784 return [
1785 ((['git', 'config', '--local', '--get-regexp',
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001786 'branch\\..*\\.gerritissue'], ),
1787 ('branch.ger-branch.gerritissue 123456\n'
1788 'branch.gbranch654.gerritissue 654321\n')),
1789 ]
1790
1791 def test_checkout_gerrit(self):
1792 """Tests git cl checkout <issue>."""
1793 self.calls = self._checkout_calls()
1794 self.calls += [((['git', 'checkout', 'ger-branch'], ), '')]
1795 self.assertEqual(0, git_cl.main(['checkout', '123456']))
1796
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001797 def test_checkout_not_found(self):
1798 """Tests git cl checkout <issue>."""
tandrii@chromium.org28253532016-04-14 13:46:56 +00001799 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001800 self.calls = self._checkout_calls()
1801 self.assertEqual(1, git_cl.main(['checkout', '99999']))
1802
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001803 def test_checkout_no_branch_issues(self):
1804 """Tests git cl checkout <issue>."""
tandrii@chromium.org28253532016-04-14 13:46:56 +00001805 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001806 self.calls = [
1807 ((['git', 'config', '--local', '--get-regexp',
tandrii5d48c322016-08-18 16:19:37 -07001808 'branch\\..*\\.gerritissue'], ), CERR1),
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001809 ]
1810 self.assertEqual(1, git_cl.main(['checkout', '99999']))
1811
tandrii@chromium.org28253532016-04-14 13:46:56 +00001812 def _test_gerrit_ensure_authenticated_common(self, auth,
1813 skip_auth_check=False):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001814 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
1815 CookiesAuthenticatorMockFactory(hosts_with_creds=auth))
1816 self.mock(git_cl, 'DieWithError',
Christopher Lamf732cd52017-01-24 12:40:11 +11001817 lambda msg, change=None: self._mocked_call(['DieWithError', msg]))
tandrii@chromium.org28253532016-04-14 13:46:56 +00001818 self.calls = self._gerrit_ensure_auth_calls(skip_auth_check=skip_auth_check)
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001819 cl = git_cl.Changelist(codereview='gerrit')
tandrii@chromium.org28253532016-04-14 13:46:56 +00001820 cl.branch = 'master'
1821 cl.branchref = 'refs/heads/master'
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001822 cl.lookedup_issue = True
1823 return cl
1824
1825 def test_gerrit_ensure_authenticated_missing(self):
1826 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001827 'chromium.googlesource.com': ('git-is.ok', '', 'but gerrit is missing'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001828 })
1829 self.calls.append(
1830 ((['DieWithError',
1831 'Credentials for the following hosts are required:\n'
1832 ' chromium-review.googlesource.com\n'
1833 'These are read from ~/.gitcookies (or legacy ~/.netrc)\n'
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01001834 'You can (re)generate your credentials by visiting '
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001835 'https://chromium-review.googlesource.com/new-password'],), ''),)
1836 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1837
1838 def test_gerrit_ensure_authenticated_conflict(self):
tandrii@chromium.org28253532016-04-14 13:46:56 +00001839 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001840 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001841 'chromium.googlesource.com':
1842 ('git-one.example.com', None, 'secret1'),
1843 'chromium-review.googlesource.com':
1844 ('git-other.example.com', None, 'secret2'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001845 })
1846 self.calls.append(
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001847 (('ask_for_data', 'If you know what you are doing '
1848 'press Enter to continue, or Ctrl+C to abort'), ''))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001849 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1850
1851 def test_gerrit_ensure_authenticated_ok(self):
1852 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001853 'chromium.googlesource.com':
1854 ('git-same.example.com', None, 'secret'),
1855 'chromium-review.googlesource.com':
1856 ('git-same.example.com', None, 'secret'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001857 })
1858 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1859
tandrii@chromium.org28253532016-04-14 13:46:56 +00001860 def test_gerrit_ensure_authenticated_skipped(self):
1861 cl = self._test_gerrit_ensure_authenticated_common(
1862 auth={}, skip_auth_check=True)
1863 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1864
Eric Boren2fb63102018-10-05 13:05:03 +00001865 def test_gerrit_ensure_authenticated_bearer_token(self):
1866 cl = self._test_gerrit_ensure_authenticated_common(auth={
1867 'chromium.googlesource.com':
1868 ('', None, 'secret'),
1869 'chromium-review.googlesource.com':
1870 ('', None, 'secret'),
1871 })
1872 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1873 header = gerrit_util.CookiesAuthenticator().get_auth_header(
1874 'chromium.googlesource.com')
1875 self.assertTrue('Bearer' in header)
1876
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01001877 def _cmd_set_commit_gerrit_common(self, vote, notify=None):
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001878 self.mock(git_cl.gerrit_util, 'SetReview',
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01001879 lambda h, i, labels, notify=None:
1880 self._mocked_call(['SetReview', h, i, labels, notify]))
1881
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001882 self.calls = [
1883 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07001884 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001885 ((['git', 'config', 'branch.feature.gerritserver'],),
1886 'https://chromium-review.googlesource.com'),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00001887 ((['git', 'config', 'branch.feature.merge'],), 'refs/heads/master'),
1888 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
1889 ((['git', 'config', 'remote.origin.url'],),
1890 'https://chromium.googlesource.com/infra/infra.git'),
1891 ((['SetReview', 'chromium-review.googlesource.com',
1892 'infra%2Finfra~123',
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01001893 {'Commit-Queue': vote}, notify],), ''),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001894 ]
tandriid9e5ce52016-07-13 02:32:59 -07001895
1896 def test_cmd_set_commit_gerrit_clear(self):
1897 self._cmd_set_commit_gerrit_common(0)
1898 self.assertEqual(0, git_cl.main(['set-commit', '-c']))
1899
1900 def test_cmd_set_commit_gerrit_dry(self):
Aaron Gable75e78722017-06-09 10:40:16 -07001901 self._cmd_set_commit_gerrit_common(1, notify=False)
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001902 self.assertEqual(0, git_cl.main(['set-commit', '-d']))
1903
tandriid9e5ce52016-07-13 02:32:59 -07001904 def test_cmd_set_commit_gerrit(self):
1905 self._cmd_set_commit_gerrit_common(2)
1906 self.assertEqual(0, git_cl.main(['set-commit']))
1907
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001908 def test_description_display(self):
1909 out = StringIO.StringIO()
1910 self.mock(git_cl.sys, 'stdout', out)
1911
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00001912 self.mock(git_cl, 'Changelist', ChangelistMock)
1913 ChangelistMock.desc = 'foo\n'
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001914
1915 self.assertEqual(0, git_cl.main(['description', '-d']))
1916 self.assertEqual('foo\n', out.getvalue())
1917
iannucci3c972b92016-08-17 13:24:10 -07001918 def test_StatusFieldOverrideIssueMissingArgs(self):
1919 out = StringIO.StringIO()
1920 self.mock(git_cl.sys, 'stderr', out)
1921
1922 try:
1923 self.assertEqual(git_cl.main(['status', '--issue', '1']), 0)
1924 except SystemExit as ex:
1925 self.assertEqual(ex.code, 2)
iannuccie53c9352016-08-17 14:40:40 -07001926 self.assertRegexpMatches(out.getvalue(), r'--issue must be specified')
iannucci3c972b92016-08-17 13:24:10 -07001927
1928 out = StringIO.StringIO()
1929 self.mock(git_cl.sys, 'stderr', out)
1930
1931 try:
Andrii Shyshkalovfeec80e2018-10-16 01:00:47 +00001932 self.assertEqual(git_cl.main(['status', '--issue', '1', '--gerrit']), 0)
iannucci3c972b92016-08-17 13:24:10 -07001933 except SystemExit as ex:
1934 self.assertEqual(ex.code, 2)
iannuccie53c9352016-08-17 14:40:40 -07001935 self.assertRegexpMatches(out.getvalue(), r'--field must be specified')
iannucci3c972b92016-08-17 13:24:10 -07001936
1937 def test_StatusFieldOverrideIssue(self):
1938 out = StringIO.StringIO()
1939 self.mock(git_cl.sys, 'stdout', out)
1940
1941 def assertIssue(cl_self, *_args):
1942 self.assertEquals(cl_self.issue, 1)
1943 return 'foobar'
1944
1945 self.mock(git_cl.Changelist, 'GetDescription', assertIssue)
iannuccie53c9352016-08-17 14:40:40 -07001946 self.assertEqual(
Andrii Shyshkalovfeec80e2018-10-16 01:00:47 +00001947 git_cl.main(['status', '--issue', '1', '--gerrit', '--field', 'desc']),
iannuccie53c9352016-08-17 14:40:40 -07001948 0)
iannucci3c972b92016-08-17 13:24:10 -07001949 self.assertEqual(out.getvalue(), 'foobar\n')
1950
iannuccie53c9352016-08-17 14:40:40 -07001951 def test_SetCloseOverrideIssue(self):
1952 def assertIssue(cl_self, *_args):
1953 self.assertEquals(cl_self.issue, 1)
1954 return 'foobar'
1955
1956 self.mock(git_cl.Changelist, 'GetDescription', assertIssue)
1957 self.mock(git_cl.Changelist, 'CloseIssue', lambda *_: None)
iannuccie53c9352016-08-17 14:40:40 -07001958 self.assertEqual(
Andrii Shyshkalovfeec80e2018-10-16 01:00:47 +00001959 git_cl.main(['set-close', '--issue', '1', '--gerrit']), 0)
iannuccie53c9352016-08-17 14:40:40 -07001960
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00001961 def test_description(self):
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001962 out = StringIO.StringIO()
1963 self.mock(git_cl.sys, 'stdout', out)
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001964 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001965 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
1966 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
1967 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
1968 ((['git', 'config', 'remote.origin.url'],),
1969 'https://chromium.googlesource.com/my/repo'),
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00001970 (('GetChangeDetail', 'chromium-review.googlesource.com',
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001971 'my%2Frepo~123123', ['CURRENT_REVISION', 'CURRENT_COMMIT']),
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001972 {
1973 'current_revision': 'sha1',
1974 'revisions': {'sha1': {
1975 'commit': {'message': 'foobar'},
1976 }},
1977 }),
1978 ]
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001979 self.assertEqual(0, git_cl.main([
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00001980 'description',
1981 'https://chromium-review.googlesource.com/c/my/repo/+/123123',
1982 '-d']))
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001983 self.assertEqual('foobar\n', out.getvalue())
1984
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00001985 def test_description_set_raw(self):
1986 out = StringIO.StringIO()
1987 self.mock(git_cl.sys, 'stdout', out)
1988
1989 self.mock(git_cl, 'Changelist', ChangelistMock)
1990 self.mock(git_cl.sys, 'stdin', StringIO.StringIO('hihi'))
1991
1992 self.assertEqual(0, git_cl.main(['description', '-n', 'hihi']))
1993 self.assertEqual('hihi', ChangelistMock.desc)
1994
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00001995 def test_description_appends_bug_line(self):
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00001996 current_desc = 'Some.\n\nChange-Id: xxx'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00001997
1998 def RunEditor(desc, _, **kwargs):
1999 self.assertEquals(
2000 '# Enter a description of the change.\n'
2001 '# This will be displayed on the codereview site.\n'
2002 '# The first line will also be used as the subject of the review.\n'
2003 '#--------------------This line is 72 characters long'
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002004 '--------------------\n'
Aaron Gable3a16ed12017-03-23 10:51:55 -07002005 'Some.\n\nChange-Id: xxx\nBug: ',
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002006 desc)
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002007 # Simulate user changing something.
Aaron Gable3a16ed12017-03-23 10:51:55 -07002008 return 'Some.\n\nChange-Id: xxx\nBug: 123'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002009
dsansomee2d6fd92016-09-08 00:10:47 -07002010 def UpdateDescriptionRemote(_, desc, force=False):
Aaron Gable3a16ed12017-03-23 10:51:55 -07002011 self.assertEquals(desc, 'Some.\n\nChange-Id: xxx\nBug: 123')
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002012
2013 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2014 self.mock(git_cl.Changelist, 'GetDescription',
2015 lambda *args: current_desc)
2016 self.mock(git_cl._GerritChangelistImpl, 'UpdateDescriptionRemote',
2017 UpdateDescriptionRemote)
2018 self.mock(git_cl.gclient_utils, 'RunEditor', RunEditor)
2019
2020 self.calls = [
2021 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07002022 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
tandrii5d48c322016-08-18 16:19:37 -07002023 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
2024 ((['git', 'config', 'rietveld.bug-prefix'],), CERR1),
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002025 ((['git', 'config', 'core.editor'],), 'vi'),
2026 ]
2027 self.assertEqual(0, git_cl.main(['description', '--gerrit']))
2028
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002029 def test_description_set_stdin(self):
2030 out = StringIO.StringIO()
2031 self.mock(git_cl.sys, 'stdout', out)
2032
2033 self.mock(git_cl, 'Changelist', ChangelistMock)
2034 self.mock(git_cl.sys, 'stdin', StringIO.StringIO('hi \r\n\t there\n\nman'))
2035
2036 self.assertEqual(0, git_cl.main(['description', '-n', '-']))
2037 self.assertEqual('hi\n\t there\n\nman', ChangelistMock.desc)
2038
kmarshall3bff56b2016-06-06 18:31:47 -07002039 def test_archive(self):
tandrii1c67da62016-06-10 07:35:53 -07002040 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2041
kmarshall3bff56b2016-06-06 18:31:47 -07002042 self.calls = \
2043 [((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2044 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002045 ((['git', 'config', 'branch.master.gerritissue'],), '456'),
2046 ((['git', 'config', 'branch.foo.gerritissue'],), CERR1),
tandrii33a46ff2016-08-23 05:53:40 -07002047 ((['git', 'config', 'branch.bar.gerritissue'],), '789'),
kmarshall3bff56b2016-06-06 18:31:47 -07002048 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2049 ((['git', 'tag', 'git-cl-archived-456-foo', 'foo'],), ''),
2050 ((['git', 'branch', '-D', 'foo'],), '')]
2051
kmarshall3bff56b2016-06-06 18:31:47 -07002052 self.mock(git_cl, 'get_cl_statuses',
2053 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002054 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2055 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2056 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
kmarshall3bff56b2016-06-06 18:31:47 -07002057
2058 self.assertEqual(0, git_cl.main(['archive', '-f']))
2059
2060 def test_archive_current_branch_fails(self):
tandrii1c67da62016-06-10 07:35:53 -07002061 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
kmarshall3bff56b2016-06-06 18:31:47 -07002062 self.calls = \
2063 [((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2064 'refs/heads/master'),
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002065 ((['git', 'config', 'branch.master.gerritissue'],), '1'),
kmarshall3bff56b2016-06-06 18:31:47 -07002066 ((['git', 'symbolic-ref', 'HEAD'],), 'master')]
2067
kmarshall9249e012016-08-23 12:02:16 -07002068 self.mock(git_cl, 'get_cl_statuses',
2069 lambda branches, fine_grained, max_processes:
2070 [(MockChangelistWithBranchAndIssue('master', 1), 'closed')])
2071
2072 self.assertEqual(1, git_cl.main(['archive', '-f']))
2073
2074 def test_archive_dry_run(self):
2075 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2076
2077 self.calls = \
2078 [((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2079 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002080 ((['git', 'config', 'branch.master.gerritissue'],), '456'),
2081 ((['git', 'config', 'branch.foo.gerritissue'],), CERR1),
kmarshall9249e012016-08-23 12:02:16 -07002082 ((['git', 'config', 'branch.bar.gerritissue'],), '789'),
2083 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),]
kmarshall3bff56b2016-06-06 18:31:47 -07002084
2085 self.mock(git_cl, 'get_cl_statuses',
2086 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002087 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2088 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2089 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
kmarshall3bff56b2016-06-06 18:31:47 -07002090
kmarshall9249e012016-08-23 12:02:16 -07002091 self.assertEqual(0, git_cl.main(['archive', '-f', '--dry-run']))
2092
2093 def test_archive_no_tags(self):
2094 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2095
2096 self.calls = \
2097 [((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2098 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002099 ((['git', 'config', 'branch.master.gerritissue'],), '1'),
2100 ((['git', 'config', 'branch.foo.gerritissue'],), '456'),
2101 ((['git', 'config', 'branch.bar.gerritissue'],), CERR1),
kmarshall9249e012016-08-23 12:02:16 -07002102 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2103 ((['git', 'branch', '-D', 'foo'],), '')]
2104
2105 self.mock(git_cl, 'get_cl_statuses',
2106 lambda branches, fine_grained, max_processes:
2107 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2108 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2109 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
2110
2111 self.assertEqual(0, git_cl.main(['archive', '-f', '--notags']))
kmarshall3bff56b2016-06-06 18:31:47 -07002112
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002113 def test_cmd_issue_erase_existing(self):
2114 out = StringIO.StringIO()
2115 self.mock(git_cl.sys, 'stdout', out)
2116 self.calls = [
2117 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07002118 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002119 # Let this command raise exception (retcode=1) - it should be ignored.
2120 ((['git', 'config', '--unset', 'branch.feature.last-upload-hash'],),
tandrii5d48c322016-08-18 16:19:37 -07002121 CERR1),
2122 ((['git', 'config', '--unset', 'branch.feature.gerritissue'],), ''),
2123 ((['git', 'config', '--unset', 'branch.feature.gerritpatchset'],), ''),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002124 ((['git', 'config', '--unset', 'branch.feature.gerritserver'],), ''),
2125 ((['git', 'config', '--unset', 'branch.feature.gerritsquashhash'],),
2126 ''),
Aaron Gableca01e2c2017-07-19 11:16:02 -07002127 ((['git', 'log', '-1', '--format=%B'],), 'This is a description'),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002128 ]
2129 self.assertEqual(0, git_cl.main(['issue', '0']))
2130
Aaron Gable400e9892017-07-12 15:31:21 -07002131 def test_cmd_issue_erase_existing_with_change_id(self):
2132 out = StringIO.StringIO()
2133 self.mock(git_cl.sys, 'stdout', out)
2134 self.mock(git_cl.Changelist, 'GetDescription',
2135 lambda _: 'This is a description\n\nChange-Id: Ideadbeef')
2136 self.calls = [
2137 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
Aaron Gable400e9892017-07-12 15:31:21 -07002138 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
Aaron Gable400e9892017-07-12 15:31:21 -07002139 # Let this command raise exception (retcode=1) - it should be ignored.
2140 ((['git', 'config', '--unset', 'branch.feature.last-upload-hash'],),
2141 CERR1),
2142 ((['git', 'config', '--unset', 'branch.feature.gerritissue'],), ''),
2143 ((['git', 'config', '--unset', 'branch.feature.gerritpatchset'],), ''),
2144 ((['git', 'config', '--unset', 'branch.feature.gerritserver'],), ''),
2145 ((['git', 'config', '--unset', 'branch.feature.gerritsquashhash'],),
2146 ''),
Aaron Gableca01e2c2017-07-19 11:16:02 -07002147 ((['git', 'log', '-1', '--format=%B'],),
2148 'This is a description\n\nChange-Id: Ideadbeef'),
2149 ((['git', 'commit', '--amend', '-m', 'This is a description\n'],), ''),
Aaron Gable400e9892017-07-12 15:31:21 -07002150 ]
2151 self.assertEqual(0, git_cl.main(['issue', '0']))
2152
phajdan.jre328cf92016-08-22 04:12:17 -07002153 def test_cmd_issue_json(self):
2154 out = StringIO.StringIO()
2155 self.mock(git_cl.sys, 'stdout', out)
2156 self.calls = [
2157 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002158 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
2159 ((['git', 'config', 'branch.feature.gerritserver'],),
2160 'https://chromium-review.googlesource.com'),
phajdan.jre328cf92016-08-22 04:12:17 -07002161 (('write_json', 'output.json',
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002162 {'issue': 123,
2163 'issue_url': 'https://chromium-review.googlesource.com/123'}),
phajdan.jre328cf92016-08-22 04:12:17 -07002164 ''),
2165 ]
2166 self.assertEqual(0, git_cl.main(['issue', '--json', 'output.json']))
2167
tandrii8c5a3532016-11-04 07:52:02 -07002168 def test_git_cl_try_default_cq_dry_run_gerrit(self):
2169 self.mock(git_cl.Changelist, 'GetChange',
2170 lambda _, *a: (
2171 self._mocked_call(['GetChange']+list(a))))
2172 self.mock(git_cl.presubmit_support, 'DoGetTryMasters',
2173 lambda *_, **__: (
2174 self._mocked_call(['DoGetTryMasters'])))
2175 self.mock(git_cl._GerritChangelistImpl, 'SetCQState',
2176 lambda _, s: self._mocked_call(['SetCQState', s]))
2177
tandrii8c5a3532016-11-04 07:52:02 -07002178 self.calls = [
2179 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii8c5a3532016-11-04 07:52:02 -07002180 ((['git', 'config', 'branch.feature.gerritissue'],), '123456'),
2181 ((['git', 'config', 'branch.feature.gerritserver'],),
2182 'https://chromium-review.googlesource.com'),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002183 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2184 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2185 ((['git', 'config', 'remote.origin.url'],),
2186 'https://chromium.googlesource.com/depot_tools'),
2187 (('GetChangeDetail', 'chromium-review.googlesource.com',
2188 'depot_tools~123456',
Andrii Shyshkaloveadad922017-01-26 09:38:30 +01002189 ['DETAILED_ACCOUNTS', 'ALL_REVISIONS', 'CURRENT_COMMIT']), {
2190 'project': 'depot_tools',
2191 'status': 'OPEN',
2192 'owner': {'email': 'owner@e.mail'},
2193 'revisions': {
2194 'deadbeaf': {
2195 '_number': 6,
2196 },
2197 'beeeeeef': {
2198 '_number': 7,
2199 'fetch': {'http': {
2200 'url': 'https://chromium.googlesource.com/depot_tools',
2201 'ref': 'refs/changes/56/123456/7'
2202 }},
2203 },
2204 },
2205 }),
tandrii8c5a3532016-11-04 07:52:02 -07002206 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2207 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2208 ((['get_or_create_merge_base', 'feature', 'feature'],),
2209 'fake_ancestor_sha'),
2210 ((['GetChange', 'fake_ancestor_sha', None], ),
2211 git_cl.presubmit_support.GitChange(
2212 '', '', '', '', '', '', '', '')),
2213 ((['git', 'rev-parse', '--show-cdup'],), '../'),
2214 ((['DoGetTryMasters'], ), None),
2215 ((['SetCQState', git_cl._CQState.DRY_RUN], ), None),
2216 ]
2217 out = StringIO.StringIO()
2218 self.mock(git_cl.sys, 'stdout', out)
2219 self.assertEqual(0, git_cl.main(['try']))
2220 self.assertEqual(
2221 out.getvalue(),
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07002222 'Scheduling CQ dry run on: '
tandrii8c5a3532016-11-04 07:52:02 -07002223 'https://chromium-review.googlesource.com/123456\n')
2224
tandrii8c5a3532016-11-04 07:52:02 -07002225 def test_git_cl_try_buildbucket_with_properties_gerrit(self):
2226 self.mock(git_cl.Changelist, 'GetMostRecentPatchset', lambda _: 7)
2227 self.mock(git_cl.uuid, 'uuid4', lambda: 'uuid4')
2228
tandrii8c5a3532016-11-04 07:52:02 -07002229 self.calls = [
2230 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii8c5a3532016-11-04 07:52:02 -07002231 ((['git', 'config', 'branch.feature.gerritissue'],), '123456'),
2232 ((['git', 'config', 'branch.feature.gerritserver'],),
2233 'https://chromium-review.googlesource.com'),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002234 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2235 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2236 ((['git', 'config', 'remote.origin.url'],),
2237 'https://chromium.googlesource.com/depot_tools'),
2238 (('GetChangeDetail', 'chromium-review.googlesource.com',
2239 'depot_tools~123456',
Andrii Shyshkaloveadad922017-01-26 09:38:30 +01002240 ['DETAILED_ACCOUNTS', 'ALL_REVISIONS', 'CURRENT_COMMIT']), {
tandrii8c5a3532016-11-04 07:52:02 -07002241 'project': 'depot_tools',
Andrii Shyshkaloveadad922017-01-26 09:38:30 +01002242 'status': 'OPEN',
2243 'owner': {'email': 'owner@e.mail'},
tandrii8c5a3532016-11-04 07:52:02 -07002244 'revisions': {
2245 'deadbeaf': {
2246 '_number': 6,
2247 },
2248 'beeeeeef': {
2249 '_number': 7,
2250 'fetch': {'http': {
2251 'url': 'https://chromium.googlesource.com/depot_tools',
2252 'ref': 'refs/changes/56/123456/7'
2253 }},
2254 },
2255 },
2256 }),
2257 ]
2258
2259 def _buildbucket_retry(*_, **kw):
2260 # self.maxDiff = 10000
2261 body = json.loads(kw['body'])
2262 self.assertEqual(len(body['builds']), 1)
2263 build = body['builds'][0]
2264 params = json.loads(build.pop('parameters_json'))
2265 self.assertEqual(params, {
2266 u'builder_name': u'win',
2267 u'changes': [{u'author': {u'email': u'owner@e.mail'},
2268 u'revision': None}],
2269 u'properties': {
2270 u'category': u'git_cl_try',
2271 u'key': u'val',
2272 u'json': [{u'a': 1}, None],
tandrii8c5a3532016-11-04 07:52:02 -07002273
2274 u'patch_gerrit_url':
2275 u'https://chromium-review.googlesource.com',
2276 u'patch_issue': 123456,
2277 u'patch_project': u'depot_tools',
2278 u'patch_ref': u'refs/changes/56/123456/7',
2279 u'patch_repository_url':
2280 u'https://chromium.googlesource.com/depot_tools',
2281 u'patch_set': 7,
2282 u'patch_storage': u'gerrit',
2283 }
2284 })
2285 self.assertEqual(build, {
Andrii Shyshkalov03da1502018-10-15 03:42:34 +00002286 u'bucket': u'luci.chromium.try',
tandrii8c5a3532016-11-04 07:52:02 -07002287 u'client_operation_id': u'uuid4',
2288 u'tags': [
2289 u'builder:win',
2290 u'buildset:patch/gerrit/chromium-review.googlesource.com/123456/7',
2291 u'user_agent:git_cl_try',
Andrii Shyshkalov03da1502018-10-15 03:42:34 +00002292 ],
tandrii8c5a3532016-11-04 07:52:02 -07002293 })
2294
2295 self.mock(git_cl, '_buildbucket_retry', _buildbucket_retry)
2296
2297 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2298 self.assertEqual(0, git_cl.main([
Andrii Shyshkalov03da1502018-10-15 03:42:34 +00002299 'try', '-B', 'luci.chromium.try', '-b', 'win',
tandrii8c5a3532016-11-04 07:52:02 -07002300 '-p', 'key=val', '-p', 'json=[{"a":1}, null]']))
2301 self.assertRegexpMatches(
2302 git_cl.sys.stdout.getvalue(),
Andrii Shyshkalov03da1502018-10-15 03:42:34 +00002303 'Tried jobs on:\nBucket: luci.chromium.try')
tandriide281ae2016-10-12 06:02:30 -07002304
qyearsley123a4682016-10-26 09:12:17 -07002305 def test_git_cl_try_bots_on_multiple_masters(self):
Andrii Shyshkalovf5569d22018-10-15 03:35:23 +00002306 self.mock(git_cl.Changelist, 'GetMostRecentPatchset', lambda _: 7)
2307 self.mock(git_cl.Changelist, 'GetChange',
2308 lambda _, *a: (
2309 self._mocked_call(['GetChange']+list(a))))
2310 self.mock(git_cl.presubmit_support, 'DoGetTryMasters',
2311 lambda *_, **__: (
2312 self._mocked_call(['DoGetTryMasters'])))
2313 self.mock(git_cl._GerritChangelistImpl, 'SetCQState',
2314 lambda _, s: self._mocked_call(['SetCQState', s]))
2315
qyearsley123a4682016-10-26 09:12:17 -07002316 self.calls = [
2317 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
Andrii Shyshkalovf5569d22018-10-15 03:35:23 +00002318 ((['git', 'config', 'branch.feature.gerritissue'],), '123456'),
2319 ((['git', 'config', 'branch.feature.gerritserver'],),
2320 'https://chromium-review.googlesource.com'),
2321 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2322 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2323 ((['git', 'config', 'remote.origin.url'],),
2324 'https://chromium.googlesource.com/depot_tools'),
2325 (('GetChangeDetail', 'chromium-review.googlesource.com',
2326 'depot_tools~123456',
2327 ['DETAILED_ACCOUNTS', 'ALL_REVISIONS', 'CURRENT_COMMIT']), {
2328 'project': 'depot_tools',
2329 'status': 'OPEN',
2330 'owner': {'email': 'owner@e.mail'},
2331 'revisions': {
2332 'deadbeaf': {
2333 '_number': 6,
2334 },
2335 'beeeeeef': {
2336 '_number': 7,
2337 'fetch': {'http': {
2338 'url': 'https://chromium.googlesource.com/depot_tools',
2339 'ref': 'refs/changes/56/123456/7'
2340 }},
2341 },
2342 },
2343 }),
qyearsley123a4682016-10-26 09:12:17 -07002344 ]
2345
2346 def _buildbucket_retry(*_, **kw):
2347 body = json.loads(kw['body'])
2348 self.assertEqual(len(body['builds']), 2)
2349
Nodir Turakulovb422e682018-02-20 22:51:30 -08002350 self.assertEqual(body['builds'][0]['bucket'], 'bucket1')
2351 params = json.loads(body['builds'][0]['parameters_json'])
2352 self.assertEqual(params['builder_name'], 'builder1')
qyearsley123a4682016-10-26 09:12:17 -07002353
Nodir Turakulovb422e682018-02-20 22:51:30 -08002354 self.assertEqual(body['builds'][1]['bucket'], 'bucket2')
2355 params = json.loads(body['builds'][1]['parameters_json'])
2356 self.assertEqual(params['builder_name'], 'builder2')
qyearsley123a4682016-10-26 09:12:17 -07002357
2358 self.mock(git_cl, '_buildbucket_retry', _buildbucket_retry)
2359
2360 self.mock(git_cl.urllib2, 'urlopen', lambda _: StringIO.StringIO(
Nodir Turakulovb422e682018-02-20 22:51:30 -08002361 json.dumps({
2362 'builder1': {'bucket': 'bucket1'},
2363 'builder2': {'bucket': 'bucket2'},
2364 })))
qyearsley123a4682016-10-26 09:12:17 -07002365
2366 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2367 self.assertEqual(
2368 0, git_cl.main(['try', '-b', 'builder1', '-b', 'builder2']))
2369 self.assertEqual(
2370 git_cl.sys.stdout.getvalue(),
2371 'Tried jobs on:\n'
Nodir Turakulovb422e682018-02-20 22:51:30 -08002372 'Bucket: bucket1\n'
qyearsley123a4682016-10-26 09:12:17 -07002373 ' builder1: []\n'
Nodir Turakulovb422e682018-02-20 22:51:30 -08002374 'Bucket: bucket2\n'
qyearsley123a4682016-10-26 09:12:17 -07002375 ' builder2: []\n'
2376 'To see results here, run: git cl try-results\n'
2377 'To see results in browser, run: git cl web\n')
2378
tandrii16e0b4e2016-06-07 10:34:28 -07002379 def _common_GerritCommitMsgHookCheck(self):
2380 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2381 self.mock(git_cl.os.path, 'abspath',
2382 lambda path: self._mocked_call(['abspath', path]))
2383 self.mock(git_cl.os.path, 'exists',
2384 lambda path: self._mocked_call(['exists', path]))
2385 self.mock(git_cl.gclient_utils, 'FileRead',
2386 lambda path: self._mocked_call(['FileRead', path]))
2387 self.mock(git_cl.gclient_utils, 'rm_file_or_tree',
2388 lambda path: self._mocked_call(['rm_file_or_tree', path]))
2389 self.calls = [
2390 ((['git', 'rev-parse', '--show-cdup'],), '../'),
2391 ((['abspath', '../'],), '/abs/git_repo_root'),
2392 ]
2393 return git_cl.Changelist(codereview='gerrit', issue=123)
2394
2395 def test_GerritCommitMsgHookCheck_custom_hook(self):
2396 cl = self._common_GerritCommitMsgHookCheck()
2397 self.calls += [
2398 ((['exists', '/abs/git_repo_root/.git/hooks/commit-msg'],), True),
2399 ((['FileRead', '/abs/git_repo_root/.git/hooks/commit-msg'],),
2400 '#!/bin/sh\necho "custom hook"')
2401 ]
2402 cl._codereview_impl._GerritCommitMsgHookCheck(offer_removal=True)
2403
2404 def test_GerritCommitMsgHookCheck_not_exists(self):
2405 cl = self._common_GerritCommitMsgHookCheck()
2406 self.calls += [
2407 ((['exists', '/abs/git_repo_root/.git/hooks/commit-msg'],), False),
2408 ]
2409 cl._codereview_impl._GerritCommitMsgHookCheck(offer_removal=True)
2410
2411 def test_GerritCommitMsgHookCheck(self):
2412 cl = self._common_GerritCommitMsgHookCheck()
2413 self.calls += [
2414 ((['exists', '/abs/git_repo_root/.git/hooks/commit-msg'],), True),
2415 ((['FileRead', '/abs/git_repo_root/.git/hooks/commit-msg'],),
2416 '...\n# From Gerrit Code Review\n...\nadd_ChangeId()\n'),
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002417 (('ask_for_data', 'Do you want to remove it now? [Yes/No]: '), 'Yes'),
tandrii16e0b4e2016-06-07 10:34:28 -07002418 ((['rm_file_or_tree', '/abs/git_repo_root/.git/hooks/commit-msg'],),
2419 ''),
2420 ]
2421 cl._codereview_impl._GerritCommitMsgHookCheck(offer_removal=True)
2422
tandriic4344b52016-08-29 06:04:54 -07002423 def test_GerritCmdLand(self):
2424 self.calls += [
2425 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2426 ((['git', 'config', 'branch.feature.gerritsquashhash'],),
2427 'deadbeaf'),
2428 ((['git', 'diff', 'deadbeaf'],), ''), # No diff.
2429 ((['git', 'config', 'branch.feature.gerritserver'],),
2430 'chromium-review.googlesource.com'),
2431 ]
2432 cl = git_cl.Changelist(issue=123, codereview='gerrit')
2433 cl._codereview_impl._GetChangeDetail = lambda _: {
2434 'labels': {},
2435 'current_revision': 'deadbeaf',
2436 }
agable32978d92016-11-01 12:55:02 -07002437 cl._codereview_impl._GetChangeCommit = lambda: {
2438 'commit': 'deadbeef',
Aaron Gable02cdbb42016-12-13 16:24:25 -08002439 'web_links': [{'name': 'gitiles',
agable32978d92016-11-01 12:55:02 -07002440 'url': 'https://git.googlesource.com/test/+/deadbeef'}],
2441 }
tandriic4344b52016-08-29 06:04:54 -07002442 cl._codereview_impl.SubmitIssue = lambda wait_for_merge: None
tandrii8da412c2016-09-07 16:01:07 -07002443 out = StringIO.StringIO()
2444 self.mock(sys, 'stdout', out)
Olivier Robin75ee7252018-04-13 10:02:56 +02002445 self.assertEqual(0, cl.CMDLand(force=True,
2446 bypass_hooks=True,
2447 verbose=True,
2448 parallel=False))
tandrii8da412c2016-09-07 16:01:07 -07002449 self.assertRegexpMatches(out.getvalue(), 'Issue.*123 has been submitted')
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002450 self.assertRegexpMatches(out.getvalue(), 'Landed as: .*deadbeef')
tandriic4344b52016-08-29 06:04:54 -07002451
tandrii221ab252016-10-06 08:12:04 -07002452 BUILDBUCKET_BUILDS_MAP = {
Quinten Yearsleya563d722017-12-11 16:36:54 -08002453 '9000': {
2454 'id': '9000',
2455 'bucket': 'master.x.y',
2456 'created_by': 'user:someone@chromium.org',
2457 'created_ts': '147200002222000',
2458 'experimental': False,
2459 'parameters_json': json.dumps({
2460 'builder_name': 'my-bot',
2461 'properties': {'category': 'cq'},
2462 }),
2463 'status': 'STARTED',
2464 'tags': [
2465 'build_address:x.y/my-bot/2',
2466 'builder:my-bot',
2467 'experimental:false',
2468 'user_agent:cq',
2469 ],
2470 'url': 'http://build.cr.org/p/x.y/builders/my-bot/builds/2',
2471 },
2472 '8000': {
2473 'id': '8000',
2474 'bucket': 'master.x.y',
2475 'created_by': 'user:someone@chromium.org',
2476 'created_ts': '147200001111000',
2477 'experimental': False,
2478 'failure_reason': 'BUILD_FAILURE',
2479 'parameters_json': json.dumps({
2480 'builder_name': 'my-bot',
2481 'properties': {'category': 'cq'},
2482 }),
2483 'result_details_json': json.dumps({
2484 'properties': {'buildnumber': 1},
2485 }),
2486 'result': 'FAILURE',
2487 'status': 'COMPLETED',
2488 'tags': [
2489 'build_address:x.y/my-bot/1',
2490 'builder:my-bot',
2491 'experimental:false',
2492 'user_agent:cq',
2493 ],
2494 'url': 'http://build.cr.org/p/x.y/builders/my-bot/builds/1',
2495 },
2496 }
tandrii221ab252016-10-06 08:12:04 -07002497
2498 def test_write_try_results_json(self):
2499 expected_output = [
Quinten Yearsleya563d722017-12-11 16:36:54 -08002500 {
2501 'bucket': 'master.x.y',
2502 'buildbucket_id': '8000',
2503 'builder_name': 'my-bot',
2504 'created_ts': '147200001111000',
2505 'experimental': False,
2506 'failure_reason': 'BUILD_FAILURE',
2507 'result': 'FAILURE',
2508 'status': 'COMPLETED',
2509 'tags': [
2510 'build_address:x.y/my-bot/1',
2511 'builder:my-bot',
2512 'experimental:false',
2513 'user_agent:cq',
2514 ],
2515 'url': 'http://build.cr.org/p/x.y/builders/my-bot/builds/1',
2516 },
2517 {
2518 'bucket': 'master.x.y',
2519 'buildbucket_id': '9000',
2520 'builder_name': 'my-bot',
2521 'created_ts': '147200002222000',
2522 'experimental': False,
2523 'failure_reason': None,
2524 'result': None,
2525 'status': 'STARTED',
2526 'tags': [
2527 'build_address:x.y/my-bot/2',
2528 'builder:my-bot',
2529 'experimental:false',
2530 'user_agent:cq',
2531 ],
2532 'url': 'http://build.cr.org/p/x.y/builders/my-bot/builds/2',
2533 },
tandrii221ab252016-10-06 08:12:04 -07002534 ]
2535 self.calls = [(('write_json', 'output.json', expected_output), '')]
2536 git_cl.write_try_results_json('output.json', self.BUILDBUCKET_BUILDS_MAP)
2537
tandrii45b2a582016-10-11 03:14:16 -07002538 def _setup_fetch_try_jobs(self, most_recent_patchset=20001):
tandrii221ab252016-10-06 08:12:04 -07002539 out = StringIO.StringIO()
2540 self.mock(sys, 'stdout', out)
tandrii45b2a582016-10-11 03:14:16 -07002541 self.mock(git_cl.Changelist, 'GetMostRecentPatchset',
2542 lambda *args: most_recent_patchset)
tandrii221ab252016-10-06 08:12:04 -07002543 self.mock(git_cl.auth, 'get_authenticator_for_host', lambda host, _cfg:
2544 self._mocked_call(['get_authenticator_for_host', host]))
2545 self.mock(git_cl, '_buildbucket_retry', lambda *_, **__:
2546 self._mocked_call(['_buildbucket_retry']))
tandrii45b2a582016-10-11 03:14:16 -07002547
tandrii45b2a582016-10-11 03:14:16 -07002548 def _setup_fetch_try_jobs_gerrit(self, *request_results):
2549 self._setup_fetch_try_jobs(most_recent_patchset=13)
2550 self.calls += [
2551 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii45b2a582016-10-11 03:14:16 -07002552 ((['git', 'config', 'branch.feature.gerritissue'],), '1'),
Ravi Mistryfda50ca2016-11-14 10:19:18 -05002553 # TODO(tandrii): Uncomment the below if we decide to support checking
2554 # patchsets for Gerrit.
tandrii45b2a582016-10-11 03:14:16 -07002555 # Simulate that Gerrit has more patchsets than local.
Ravi Mistryfda50ca2016-11-14 10:19:18 -05002556 # ((['git', 'config', 'branch.feature.gerritpatchset'],), '12'),
tandrii45b2a582016-10-11 03:14:16 -07002557 ((['git', 'config', 'branch.feature.gerritserver'],),
2558 'https://x-review.googlesource.com'),
2559 ((['get_authenticator_for_host', 'x-review.googlesource.com'],),
2560 AuthenticatorMock()),
2561 ] + [((['_buildbucket_retry'],), r) for r in request_results]
2562
2563 def test_fetch_try_jobs_none_gerrit(self):
2564 self._setup_fetch_try_jobs_gerrit({})
2565 self.assertEqual(0, git_cl.main(['try-results']))
Ravi Mistryfda50ca2016-11-14 10:19:18 -05002566 # TODO(tandrii): Uncomment the below if we decide to support checking
2567 # patchsets for Gerrit.
2568 # self.assertRegexpMatches(
2569 # sys.stdout.getvalue(),
2570 # r'Warning: Codereview server has newer patchsets \(13\)')
tandrii45b2a582016-10-11 03:14:16 -07002571 self.assertRegexpMatches(sys.stdout.getvalue(), 'No try jobs')
2572
2573 def test_fetch_try_jobs_some_gerrit(self):
2574 self._setup_fetch_try_jobs_gerrit({
2575 'builds': self.BUILDBUCKET_BUILDS_MAP.values(),
2576 })
Ravi Mistryfda50ca2016-11-14 10:19:18 -05002577 # TODO(tandrii): Uncomment the below if we decide to support checking
2578 # patchsets for Gerrit.
2579 # self.calls.remove(
2580 # ((['git', 'config', 'branch.feature.gerritpatchset'],), '12'))
tandrii45b2a582016-10-11 03:14:16 -07002581 self.assertEqual(0, git_cl.main(['try-results', '--patchset', '5']))
2582
2583 # ... and doesn't result in warning.
2584 self.assertNotRegexpMatches(sys.stdout.getvalue(), 'Warning')
2585 self.assertRegexpMatches(sys.stdout.getvalue(), '^Failures:')
tandrii221ab252016-10-06 08:12:04 -07002586 self.assertRegexpMatches(sys.stdout.getvalue(), 'Started:')
2587 self.assertRegexpMatches(sys.stdout.getvalue(), '2 try jobs')
2588
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002589 def _mock_gerrit_changes_for_detail_cache(self):
2590 self.mock(git_cl._GerritChangelistImpl, '_GetGerritHost', lambda _: 'host')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002591
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002592 def test_gerrit_change_detail_cache_simple(self):
2593 self._mock_gerrit_changes_for_detail_cache()
2594 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002595 (('GetChangeDetail', 'host', 'my%2Frepo~1', []), 'a'),
2596 (('GetChangeDetail', 'host', 'ab%2Frepo~2', []), 'b'),
2597 (('GetChangeDetail', 'host', 'ab%2Frepo~2', []), 'b2'),
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002598 ]
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00002599 cl1 = git_cl.Changelist(issue=1, codereview='gerrit')
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002600 cl1._cached_remote_url = (
2601 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00002602 cl2 = git_cl.Changelist(issue=2, codereview='gerrit')
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002603 cl2._cached_remote_url = (
2604 True, 'https://chromium.googlesource.com/ab/repo')
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00002605 self.assertEqual(cl1._GetChangeDetail(), 'a') # Miss.
2606 self.assertEqual(cl1._GetChangeDetail(), 'a')
2607 self.assertEqual(cl2._GetChangeDetail(), 'b') # Miss.
2608 self.assertEqual(cl2._GetChangeDetail(no_cache=True), 'b2') # Miss.
2609 self.assertEqual(cl1._GetChangeDetail(), 'a')
2610 self.assertEqual(cl2._GetChangeDetail(), 'b2')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002611
2612 def test_gerrit_change_detail_cache_options(self):
2613 self._mock_gerrit_changes_for_detail_cache()
2614 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002615 (('GetChangeDetail', 'host', 'repo~1', ['C', 'A', 'B']), 'cab'),
2616 (('GetChangeDetail', 'host', 'repo~1', ['A', 'D']), 'ad'),
2617 (('GetChangeDetail', 'host', 'repo~1', ['A']), 'a'), # no_cache=True
2618 # no longer in cache.
2619 (('GetChangeDetail', 'host', 'repo~1', ['B']), 'b'),
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002620 ]
2621 cl = git_cl.Changelist(issue=1, codereview='gerrit')
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002622 cl._cached_remote_url = (True, 'https://chromium.googlesource.com/repo/')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002623 self.assertEqual(cl._GetChangeDetail(options=['C', 'A', 'B']), 'cab')
2624 self.assertEqual(cl._GetChangeDetail(options=['A', 'B', 'C']), 'cab')
2625 self.assertEqual(cl._GetChangeDetail(options=['B', 'A']), 'cab')
2626 self.assertEqual(cl._GetChangeDetail(options=['C']), 'cab')
2627 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2628 self.assertEqual(cl._GetChangeDetail(), 'cab')
2629
2630 self.assertEqual(cl._GetChangeDetail(options=['A', 'D']), 'ad')
2631 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2632 self.assertEqual(cl._GetChangeDetail(options=['D']), 'ad')
2633 self.assertEqual(cl._GetChangeDetail(), 'cab')
2634
2635 # Finally, no_cache should invalidate all caches for given change.
2636 self.assertEqual(cl._GetChangeDetail(options=['A'], no_cache=True), 'a')
2637 self.assertEqual(cl._GetChangeDetail(options=['B']), 'b')
2638
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002639 def test_gerrit_description_caching(self):
2640 def gen_detail(rev, desc):
2641 return {
2642 'current_revision': rev,
2643 'revisions': {rev: {'commit': {'message': desc}}}
2644 }
2645 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002646 (('GetChangeDetail', 'host', 'my%2Frepo~1',
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002647 ['CURRENT_REVISION', 'CURRENT_COMMIT']),
2648 gen_detail('rev1', 'desc1')),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002649 (('GetChangeDetail', 'host', 'my%2Frepo~1',
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002650 ['CURRENT_REVISION', 'CURRENT_COMMIT']),
2651 gen_detail('rev2', 'desc2')),
2652 ]
2653
2654 self._mock_gerrit_changes_for_detail_cache()
2655 cl = git_cl.Changelist(issue=1, codereview='gerrit')
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002656 cl._cached_remote_url = (
2657 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002658 self.assertEqual(cl.GetDescription(), 'desc1')
2659 self.assertEqual(cl.GetDescription(), 'desc1') # cache hit.
2660 self.assertEqual(cl.GetDescription(force=True), 'desc2')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002661
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002662 def test_print_current_creds(self):
2663 class CookiesAuthenticatorMock(object):
2664 def __init__(self):
2665 self.gitcookies = {
2666 'host.googlesource.com': ('user', 'pass'),
2667 'host-review.googlesource.com': ('user', 'pass'),
2668 }
2669 self.netrc = self
2670 self.netrc.hosts = {
2671 'github.com': ('user2', None, 'pass2'),
2672 'host2.googlesource.com': ('user3', None, 'pass'),
2673 }
2674 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
2675 CookiesAuthenticatorMock)
2676 self.mock(sys, 'stdout', StringIO.StringIO())
2677 git_cl._GitCookiesChecker().print_current_creds(include_netrc=True)
2678 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2679 ' Host\t User\t Which file',
2680 '============================\t=====\t===========',
2681 'host-review.googlesource.com\t user\t.gitcookies',
2682 ' host.googlesource.com\t user\t.gitcookies',
2683 ' host2.googlesource.com\tuser3\t .netrc',
2684 ])
2685 sys.stdout.buf = ''
2686 git_cl._GitCookiesChecker().print_current_creds(include_netrc=False)
2687 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2688 ' Host\tUser\t Which file',
2689 '============================\t====\t===========',
2690 'host-review.googlesource.com\tuser\t.gitcookies',
2691 ' host.googlesource.com\tuser\t.gitcookies',
2692 ])
2693
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002694 def _common_creds_check_mocks(self):
2695 def exists_mock(path):
2696 dirname = os.path.dirname(path)
2697 if dirname == os.path.expanduser('~'):
2698 dirname = '~'
2699 base = os.path.basename(path)
2700 if base in ('.netrc', '.gitcookies'):
2701 return self._mocked_call('os.path.exists', '%s/%s' % (dirname, base))
2702 # git cl also checks for existence other files not relevant to this test.
2703 return None
2704 self.mock(os.path, 'exists', exists_mock)
2705 self.mock(sys, 'stdout', StringIO.StringIO())
2706
2707 def test_creds_check_gitcookies_not_configured(self):
2708 self._common_creds_check_mocks()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002709 self.mock(git_cl._GitCookiesChecker, 'get_hosts_with_creds',
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01002710 lambda _, include_netrc=False: [])
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002711 self.calls = [
Aaron Gable8797cab2018-03-06 13:55:00 -08002712 ((['git', 'config', '--path', 'http.cookiefile'],), CERR1),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002713 ((['git', 'config', '--global', 'http.cookiefile'],), CERR1),
2714 (('os.path.exists', '~/.netrc'), True),
2715 (('ask_for_data', 'Press Enter to setup .gitcookies, '
2716 'or Ctrl+C to abort'), ''),
2717 ((['git', 'config', '--global', 'http.cookiefile',
2718 os.path.expanduser('~/.gitcookies')], ), ''),
2719 ]
2720 self.assertEqual(0, git_cl.main(['creds-check']))
2721 self.assertRegexpMatches(
2722 sys.stdout.getvalue(),
2723 '^You seem to be using outdated .netrc for git credentials:')
2724 self.assertRegexpMatches(
2725 sys.stdout.getvalue(),
2726 '\nConfigured git to use .gitcookies from')
2727
2728 def test_creds_check_gitcookies_configured_custom_broken(self):
2729 self._common_creds_check_mocks()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002730 self.mock(git_cl._GitCookiesChecker, 'get_hosts_with_creds',
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01002731 lambda _, include_netrc=False: [])
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002732 self.calls = [
Aaron Gable8797cab2018-03-06 13:55:00 -08002733 ((['git', 'config', '--path', 'http.cookiefile'],), CERR1),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002734 ((['git', 'config', '--global', 'http.cookiefile'],),
2735 '/custom/.gitcookies'),
2736 (('os.path.exists', '/custom/.gitcookies'), False),
2737 (('ask_for_data', 'Reconfigure git to use default .gitcookies? '
2738 'Press Enter to reconfigure, or Ctrl+C to abort'), ''),
2739 ((['git', 'config', '--global', 'http.cookiefile',
2740 os.path.expanduser('~/.gitcookies')], ), ''),
2741 ]
2742 self.assertEqual(0, git_cl.main(['creds-check']))
2743 self.assertRegexpMatches(
2744 sys.stdout.getvalue(),
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002745 'WARNING: You have configured custom path to .gitcookies: ')
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002746 self.assertRegexpMatches(
2747 sys.stdout.getvalue(),
2748 'However, your configured .gitcookies file is missing.')
2749
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002750 def test_git_cl_comment_add_gerrit(self):
2751 self.mock(git_cl.gerrit_util, 'SetReview',
Aaron Gable636b13f2017-07-14 10:42:48 -07002752 lambda host, change, msg, ready:
2753 self._mocked_call('SetReview', host, change, msg, ready))
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002754 self.calls = [
2755 ((['git', 'symbolic-ref', 'HEAD'],), CERR1),
2756 ((['git', 'symbolic-ref', 'HEAD'],), CERR1),
2757 ((['git', 'config', 'rietveld.upstream-branch'],), CERR1),
2758 ((['git', 'branch', '-r'],), 'origin/HEAD -> origin/master\n'
2759 'origin/master'),
2760 ((['git', 'config', 'remote.origin.url'],),
2761 'https://chromium.googlesource.com/infra/infra'),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002762 (('SetReview', 'chromium-review.googlesource.com', 'infra%2Finfra~10',
2763 'msg', None),
Aaron Gable636b13f2017-07-14 10:42:48 -07002764 None),
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002765 ]
2766 self.assertEqual(0, git_cl.main(['comment', '--gerrit', '-i', '10',
2767 '-a', 'msg']))
2768
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002769 def test_git_cl_comments_fetch_gerrit(self):
2770 self.mock(sys, 'stdout', StringIO.StringIO())
2771 self.calls = [
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002772 ((['git', 'config', 'branch.foo.gerritserver'],), ''),
2773 ((['git', 'config', 'branch.foo.merge'],), ''),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002774 ((['git', 'config', 'rietveld.upstream-branch'],), CERR1),
2775 ((['git', 'branch', '-r'],), 'origin/HEAD -> origin/master\n'
2776 'origin/master'),
2777 ((['git', 'config', 'remote.origin.url'],),
2778 'https://chromium.googlesource.com/infra/infra'),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002779 (('GetChangeDetail', 'chromium-review.googlesource.com',
2780 'infra%2Finfra~1',
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002781 ['MESSAGES', 'DETAILED_ACCOUNTS', 'CURRENT_REVISION',
2782 'CURRENT_COMMIT']), {
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002783 'owner': {'email': 'owner@example.com'},
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002784 'current_revision': 'ba5eba11',
2785 'revisions': {
2786 'deadbeaf': {
2787 '_number': 1,
2788 },
2789 'ba5eba11': {
2790 '_number': 2,
2791 },
2792 },
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002793 'messages': [
2794 {
2795 u'_revision_number': 1,
2796 u'author': {
2797 u'_account_id': 1111084,
2798 u'email': u'commit-bot@chromium.org',
2799 u'name': u'Commit Bot'
2800 },
2801 u'date': u'2017-03-15 20:08:45.000000000',
2802 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
Dirk Prankef6a58802017-10-17 12:49:42 -07002803 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002804 u'tag': u'autogenerated:cq:dry-run'
2805 },
2806 {
2807 u'_revision_number': 2,
2808 u'author': {
2809 u'_account_id': 11151243,
2810 u'email': u'owner@example.com',
2811 u'name': u'owner'
2812 },
2813 u'date': u'2017-03-16 20:00:41.000000000',
2814 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2815 u'message': u'PTAL',
2816 },
2817 {
2818 u'_revision_number': 2,
2819 u'author': {
2820 u'_account_id': 148512 ,
2821 u'email': u'reviewer@example.com',
2822 u'name': u'reviewer'
2823 },
2824 u'date': u'2017-03-17 05:19:37.500000000',
2825 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
2826 u'message': u'Patch Set 2: Code-Review+1',
2827 },
2828 ]
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002829 }),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002830 (('GetChangeComments', 'chromium-review.googlesource.com',
2831 'infra%2Finfra~1'), {
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002832 '/COMMIT_MSG': [
2833 {
2834 'author': {'email': u'reviewer@example.com'},
2835 'updated': u'2017-03-17 05:19:37.500000000',
2836 'patch_set': 2,
2837 'side': 'REVISION',
2838 'message': 'Please include a bug link',
2839 },
2840 ],
2841 'codereview.settings': [
2842 {
2843 'author': {'email': u'owner@example.com'},
2844 'updated': u'2017-03-16 20:00:41.000000000',
2845 'patch_set': 2,
2846 'side': 'PARENT',
2847 'line': 42,
2848 'message': 'I removed this because it is bad',
2849 },
2850 ]
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002851 }),
2852 (('GetChangeRobotComments', 'chromium-review.googlesource.com',
2853 'infra%2Finfra~1'), {}),
2854 ((['git', 'config', 'branch.foo.gerritpatchset', '2'],), ''),
Leszek Swirski45b20c42018-09-17 17:05:26 +00002855 ] * 2 + [
2856 (('write_json', 'output.json', [
2857 {
2858 u'date': u'2017-03-16 20:00:41.000000',
2859 u'message': (
2860 u'PTAL\n' +
2861 u'\n' +
2862 u'codereview.settings\n' +
2863 u' Base, Line 42: https://chromium-review.googlesource.com/' +
2864 u'c/1/2/codereview.settings#b42\n' +
2865 u' I removed this because it is bad\n'),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002866 u'autogenerated': False,
Leszek Swirski45b20c42018-09-17 17:05:26 +00002867 u'approval': False,
2868 u'disapproval': False,
2869 u'sender': u'owner@example.com'
2870 }, {
2871 u'date': u'2017-03-17 05:19:37.500000',
2872 u'message': (
2873 u'Patch Set 2: Code-Review+1\n' +
2874 u'\n' +
2875 u'/COMMIT_MSG\n' +
2876 u' PS2, File comment: https://chromium-review.googlesource' +
2877 u'.com/c/1/2//COMMIT_MSG#\n' +
2878 u' Please include a bug link\n'),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002879 u'autogenerated': False,
Leszek Swirski45b20c42018-09-17 17:05:26 +00002880 u'approval': False,
2881 u'disapproval': False,
2882 u'sender': u'reviewer@example.com'
2883 }
2884 ]),'')
2885 ]
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002886 expected_comments_summary = [
2887 git_cl._CommentSummary(
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002888 message=(
2889 u'PTAL\n' +
2890 u'\n' +
2891 u'codereview.settings\n' +
2892 u' Base, Line 42: https://chromium-review.googlesource.com/' +
2893 u'c/1/2/codereview.settings#b42\n' +
2894 u' I removed this because it is bad\n'),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002895 date=datetime.datetime(2017, 3, 16, 20, 0, 41, 0),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002896 autogenerated=False,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002897 disapproval=False, approval=False, sender=u'owner@example.com'),
2898 git_cl._CommentSummary(
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002899 message=(
2900 u'Patch Set 2: Code-Review+1\n' +
2901 u'\n' +
2902 u'/COMMIT_MSG\n' +
2903 u' PS2, File comment: https://chromium-review.googlesource.com/' +
2904 u'c/1/2//COMMIT_MSG#\n' +
2905 u' Please include a bug link\n'),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002906 date=datetime.datetime(2017, 3, 17, 5, 19, 37, 500000),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002907 autogenerated=False,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002908 disapproval=False, approval=False, sender=u'reviewer@example.com'),
2909 ]
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002910 cl = git_cl.Changelist(
2911 codereview='gerrit', issue=1, branchref='refs/heads/foo')
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002912 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002913 self.mock(git_cl.Changelist, 'GetBranch', lambda _: 'foo')
2914 self.assertEqual(
2915 0, git_cl.main(['comments', '-i', '1', '-j', 'output.json']))
2916
2917 def test_git_cl_comments_robot_comments(self):
2918 # git cl comments also fetches robot comments (which are considered a type
2919 # of autogenerated comment), and unlike other types of comments, only robot
2920 # comments from the latest patchset are shown.
2921 self.mock(sys, 'stdout', StringIO.StringIO())
2922 self.calls = [
2923 ((['git', 'config', 'branch.foo.gerritserver'],), ''),
2924 ((['git', 'config', 'branch.foo.merge'],), ''),
2925 ((['git', 'config', 'rietveld.upstream-branch'],), CERR1),
2926 ((['git', 'branch', '-r'],), 'origin/HEAD -> origin/master\n'
2927 'origin/master'),
2928 ((['git', 'config', 'remote.origin.url'],),
2929 'https://chromium.googlesource.com/infra/infra'),
2930 (('GetChangeDetail', 'chromium-review.googlesource.com',
2931 'infra%2Finfra~1',
2932 ['MESSAGES', 'DETAILED_ACCOUNTS', 'CURRENT_REVISION',
2933 'CURRENT_COMMIT']), {
2934 'owner': {'email': 'owner@example.com'},
2935 'current_revision': 'ba5eba11',
2936 'revisions': {
2937 'deadbeaf': {
2938 '_number': 1,
2939 },
2940 'ba5eba11': {
2941 '_number': 2,
2942 },
2943 },
2944 'messages': [
2945 {
2946 u'_revision_number': 1,
2947 u'author': {
2948 u'_account_id': 1111084,
2949 u'email': u'commit-bot@chromium.org',
2950 u'name': u'Commit Bot'
2951 },
2952 u'date': u'2017-03-15 20:08:45.000000000',
2953 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
2954 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
2955 u'tag': u'autogenerated:cq:dry-run'
2956 },
2957 {
2958 u'_revision_number': 1,
2959 u'author': {
2960 u'_account_id': 123,
2961 u'email': u'tricium@serviceaccount.com',
2962 u'name': u'Tricium'
2963 },
2964 u'date': u'2017-03-16 20:00:41.000000000',
2965 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2966 u'message': u'(1 comment)',
2967 u'tag': u'autogenerated:tricium',
2968 },
2969 {
2970 u'_revision_number': 1,
2971 u'author': {
2972 u'_account_id': 123,
2973 u'email': u'tricium@serviceaccount.com',
2974 u'name': u'Tricium'
2975 },
2976 u'date': u'2017-03-16 20:00:41.000000000',
2977 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2978 u'message': u'(1 comment)',
2979 u'tag': u'autogenerated:tricium',
2980 },
2981 {
2982 u'_revision_number': 2,
2983 u'author': {
2984 u'_account_id': 123 ,
2985 u'email': u'tricium@serviceaccount.com',
2986 u'name': u'reviewer'
2987 },
2988 u'date': u'2017-03-17 05:30:37.000000000',
2989 u'tag': u'autogenerated:tricium',
2990 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
2991 u'message': u'(1 comment)',
2992 },
2993 ]
2994 }),
2995 (('GetChangeComments', 'chromium-review.googlesource.com',
2996 'infra%2Finfra~1'), {}),
2997 (('GetChangeRobotComments', 'chromium-review.googlesource.com',
2998 'infra%2Finfra~1'), {
2999 'codereview.settings': [
3000 {
3001 u'author': {u'email': u'tricium@serviceaccount.com'},
3002 u'updated': u'2017-03-17 05:30:37.000000000',
3003 u'robot_run_id': u'5565031076855808',
3004 u'robot_id': u'Linter/Category',
3005 u'tag': u'autogenerated:tricium',
3006 u'patch_set': 2,
3007 u'side': u'REVISION',
3008 u'message': u'Linter warning message text',
3009 u'line': 32,
3010 },
3011 ],
3012 }),
3013 ((['git', 'config', 'branch.foo.gerritpatchset', '2'],), ''),
3014 ]
3015 expected_comments_summary = [
3016 git_cl._CommentSummary(date=datetime.datetime(2017, 3, 17, 5, 30, 37),
3017 message=(
3018 u'(1 comment)\n\ncodereview.settings\n'
3019 u' PS2, Line 32: https://chromium-review.googlesource.com/'
3020 u'c/1/2/codereview.settings#32\n'
3021 u' Linter warning message text\n'),
3022 sender=u'tricium@serviceaccount.com',
3023 autogenerated=True, approval=False, disapproval=False)
3024 ]
3025 cl = git_cl.Changelist(
3026 codereview='gerrit', issue=1, branchref='refs/heads/foo')
3027 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003028
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00003029 def test_get_remote_url_with_mirror(self):
3030 original_os_path_isdir = os.path.isdir
3031 def selective_os_path_isdir_mock(path):
3032 if path == '/cache/this-dir-exists':
3033 return self._mocked_call('os.path.isdir', path)
3034 return original_os_path_isdir(path)
3035 self.mock(os.path, 'isdir', selective_os_path_isdir_mock)
3036
3037 url = 'https://chromium.googlesource.com/my/repo'
3038 self.calls = [
3039 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
3040 ((['git', 'config', 'branch.master.merge'],), 'master'),
3041 ((['git', 'config', 'branch.master.remote'],), 'origin'),
3042 ((['git', 'config', 'remote.origin.url'],),
3043 '/cache/this-dir-exists'),
3044 (('os.path.isdir', '/cache/this-dir-exists'),
3045 True),
3046 # Runs in /cache/this-dir-exists.
3047 ((['git', 'config', 'remote.origin.url'],),
3048 url),
3049 ]
3050 cl = git_cl.Changelist(codereview='gerrit', issue=1)
3051 self.assertEqual(cl.GetRemoteUrl(), url)
3052 self.assertEqual(cl.GetRemoteUrl(), url) # Must be cached.
3053
Edward Lemur298f2cf2019-02-22 21:40:39 +00003054 def test_get_remote_url_non_existing_mirror(self):
3055 original_os_path_isdir = os.path.isdir
3056 def selective_os_path_isdir_mock(path):
3057 if path == '/cache/this-dir-doesnt-exist':
3058 return self._mocked_call('os.path.isdir', path)
3059 return original_os_path_isdir(path)
3060 self.mock(os.path, 'isdir', selective_os_path_isdir_mock)
3061 self.mock(logging, 'error',
3062 lambda fmt, *a: self._mocked_call('logging.error', fmt % a))
3063
3064 self.calls = [
3065 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
3066 ((['git', 'config', 'branch.master.merge'],), 'master'),
3067 ((['git', 'config', 'branch.master.remote'],), 'origin'),
3068 ((['git', 'config', 'remote.origin.url'],),
3069 '/cache/this-dir-doesnt-exist'),
3070 (('os.path.isdir', '/cache/this-dir-doesnt-exist'),
3071 False),
3072 (('logging.error',
3073 'Remote "origin" for branch "/cache/this-dir-doesnt-exist" points to'
3074 ' "master", but it doesn\'t exist.'), None),
3075 ]
3076 cl = git_cl.Changelist(codereview='gerrit', issue=1)
3077 self.assertIsNone(cl.GetRemoteUrl())
3078
3079 def test_get_remote_url_misconfigured_mirror(self):
3080 original_os_path_isdir = os.path.isdir
3081 def selective_os_path_isdir_mock(path):
3082 if path == '/cache/this-dir-exists':
3083 return self._mocked_call('os.path.isdir', path)
3084 return original_os_path_isdir(path)
3085 self.mock(os.path, 'isdir', selective_os_path_isdir_mock)
3086 self.mock(logging, 'error',
3087 lambda *a: self._mocked_call('logging.error', *a))
3088
3089 self.calls = [
3090 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
3091 ((['git', 'config', 'branch.master.merge'],), 'master'),
3092 ((['git', 'config', 'branch.master.remote'],), 'origin'),
3093 ((['git', 'config', 'remote.origin.url'],),
3094 '/cache/this-dir-exists'),
3095 (('os.path.isdir', '/cache/this-dir-exists'), True),
3096 # Runs in /cache/this-dir-exists.
3097 ((['git', 'config', 'remote.origin.url'],), ''),
3098 (('logging.error',
3099 'Remote "%(remote)s" for branch "%(branch)s" points to '
3100 '"%(cache_path)s", but it is misconfigured.\n'
3101 '"%(cache_path)s" must be a git repo and must have a remote named '
3102 '"%(remote)s" pointing to the git host.', {
3103 'remote': 'origin',
3104 'cache_path': '/cache/this-dir-exists',
3105 'branch': 'master'}
3106 ), None),
3107 ]
3108 cl = git_cl.Changelist(codereview='gerrit', issue=1)
3109 self.assertIsNone(cl.GetRemoteUrl())
3110
3111
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00003112 def test_gerrit_change_identifier_with_project(self):
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00003113 self.calls = [
3114 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
3115 ((['git', 'config', 'branch.master.merge'],), 'master'),
3116 ((['git', 'config', 'branch.master.remote'],), 'origin'),
3117 ((['git', 'config', 'remote.origin.url'],),
3118 'https://chromium.googlesource.com/a/my/repo.git/'),
3119 ]
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00003120 cl = git_cl.Changelist(codereview='gerrit', issue=123456)
3121 self.assertEqual(cl._GerritChangeIdentifier(), 'my%2Frepo~123456')
3122
3123 def test_gerrit_change_identifier_without_project(self):
3124 self.calls = [
3125 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
3126 ((['git', 'config', 'branch.master.merge'],), 'master'),
3127 ((['git', 'config', 'branch.master.remote'],), 'origin'),
3128 ((['git', 'config', 'remote.origin.url'],), CERR1),
3129 ]
3130 cl = git_cl.Changelist(codereview='gerrit', issue=123456)
3131 self.assertEqual(cl._GerritChangeIdentifier(), '123456')
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00003132
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003133
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003134if __name__ == '__main__':
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +01003135 logging.basicConfig(
3136 level=logging.DEBUG if '-v' in sys.argv else logging.ERROR)
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003137 unittest.main()