blob: a756e99b83e8541e4efe3bada841135406f2e990 [file] [log] [blame]
Mark Lobodzinskic0df6b62021-01-08 12:34:11 -07001/* Copyright (c) 2015-2021 The Khronos Group Inc.
2 * Copyright (c) 2015-2021 Valve Corporation
3 * Copyright (c) 2015-2021 LunarG, Inc.
4 * Copyright (C) 2015-2021 Google Inc.
Mark Lobodzinskid4950072017-08-01 13:02:20 -06005 *
6 * Licensed under the Apache License, Version 2.0 (the "License");
7 * you may not use this file except in compliance with the License.
8 * You may obtain a copy of the License at
9 *
10 * http://www.apache.org/licenses/LICENSE-2.0
11 *
12 * Unless required by applicable law or agreed to in writing, software
13 * distributed under the License is distributed on an "AS IS" BASIS,
14 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15 * See the License for the specific language governing permissions and
16 * limitations under the License.
17 *
18 * Author: Mark Lobodzinski <mark@LunarG.com>
John Zulaufa999d1b2018-11-29 13:38:40 -070019 * Author: John Zulauf <jzulauf@lunarg.com>
Mark Lobodzinskid4950072017-08-01 13:02:20 -060020 */
21
orbea80ddc062019-09-10 10:33:19 -070022#include <cmath>
Shahbaz Youssefi6be11412019-01-10 15:29:30 -050023
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -070024#include "chassis.h"
25#include "stateless_validation.h"
Mark Lobodzinskie514d1a2019-03-12 08:47:45 -060026#include "layer_chassis_dispatch.h"
Tobias Hectord942eb92018-10-22 15:18:56 +010027
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -070028static const int kMaxParamCheckerStringLength = 256;
Mark Lobodzinskid4950072017-08-01 13:02:20 -060029
John Zulauf71968502017-10-26 13:51:15 -060030template <typename T>
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -070031inline bool in_inclusive_range(const T &value, const T &min, const T &max) {
John Zulauf71968502017-10-26 13:51:15 -060032 // Using only < for generality and || for early abort
33 return !((value < min) || (max < value));
34}
35
Mark Lobodzinski21b91fe2020-12-03 15:44:24 -070036read_lock_guard_t StatelessValidation::read_lock() { return read_lock_guard_t(validation_object_mutex, std::defer_lock); }
37write_lock_guard_t StatelessValidation::write_lock() { return write_lock_guard_t(validation_object_mutex, std::defer_lock); }
38
Tony-LunarG3c287f62020-12-17 12:39:49 -070039static std::unordered_map<VkCommandBuffer, VkCommandPool> secondary_cb_map{};
40static ReadWriteLock secondary_cb_map_mutex;
Mark Lobodzinski1f887d32020-12-30 15:31:33 -070041static read_lock_guard_t cb_read_lock() { return read_lock_guard_t(secondary_cb_map_mutex); }
42static write_lock_guard_t cb_write_lock() { return write_lock_guard_t(secondary_cb_map_mutex); }
Tony-LunarG3c287f62020-12-17 12:39:49 -070043
Mark Lobodzinskibf599b92018-12-31 12:15:55 -070044bool StatelessValidation::validate_string(const char *apiName, const ParameterName &stringName, const std::string &vuid,
Jeff Bolz46c0ea02019-10-09 13:06:29 -050045 const char *validateString) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -060046 bool skip = false;
47
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -070048 VkStringErrorFlags result = vk_string_validate(kMaxParamCheckerStringLength, validateString);
Mark Lobodzinskid4950072017-08-01 13:02:20 -060049
50 if (result == VK_STRING_ERROR_NONE) {
51 return skip;
52 } else if (result & VK_STRING_ERROR_LENGTH) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -070053 skip = LogError(device, vuid, "%s: string %s exceeds max length %d", apiName, stringName.get_name().c_str(),
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -070054 kMaxParamCheckerStringLength);
Mark Lobodzinskid4950072017-08-01 13:02:20 -060055 } else if (result & VK_STRING_ERROR_BAD_DATA) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -070056 skip = LogError(device, vuid, "%s: string %s contains invalid characters or is badly formed", apiName,
57 stringName.get_name().c_str());
Mark Lobodzinskid4950072017-08-01 13:02:20 -060058 }
59 return skip;
60}
61
Jeff Bolz46c0ea02019-10-09 13:06:29 -050062bool StatelessValidation::validate_api_version(uint32_t api_version, uint32_t effective_api_version) const {
John Zulauf620755c2018-04-16 11:00:43 -060063 bool skip = false;
64 uint32_t api_version_nopatch = VK_MAKE_VERSION(VK_VERSION_MAJOR(api_version), VK_VERSION_MINOR(api_version), 0);
65 if (api_version_nopatch != effective_api_version) {
sfricke-samsung6aec21b2020-11-01 07:49:43 -080066 if ((api_version_nopatch < VK_API_VERSION_1_0) && (api_version != 0)) {
67 skip |= LogError(instance, "VUID-VkApplicationInfo-apiVersion-04010",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -070068 "Invalid CreateInstance->pCreateInfo->pApplicationInfo.apiVersion number (0x%08x). "
69 "Using VK_API_VERSION_%" PRIu32 "_%" PRIu32 ".",
70 api_version, VK_VERSION_MAJOR(effective_api_version), VK_VERSION_MINOR(effective_api_version));
John Zulauf620755c2018-04-16 11:00:43 -060071 } else {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -070072 skip |= LogWarning(instance, kVUIDUndefined,
73 "Unrecognized CreateInstance->pCreateInfo->pApplicationInfo.apiVersion number (0x%08x). "
74 "Assuming VK_API_VERSION_%" PRIu32 "_%" PRIu32 ".",
75 api_version, VK_VERSION_MAJOR(effective_api_version), VK_VERSION_MINOR(effective_api_version));
John Zulauf620755c2018-04-16 11:00:43 -060076 }
77 }
78 return skip;
79}
80
Jeff Bolz46c0ea02019-10-09 13:06:29 -050081bool StatelessValidation::validate_instance_extensions(const VkInstanceCreateInfo *pCreateInfo) const {
John Zulauf620755c2018-04-16 11:00:43 -060082 bool skip = false;
Mark Lobodzinski05cce202019-08-27 10:28:37 -060083 // Create and use a local instance extension object, as an actual instance has not been created yet
84 uint32_t specified_version = (pCreateInfo->pApplicationInfo ? pCreateInfo->pApplicationInfo->apiVersion : VK_API_VERSION_1_0);
85 InstanceExtensions local_instance_extensions;
86 local_instance_extensions.InitFromInstanceCreateInfo(specified_version, pCreateInfo);
87
John Zulauf620755c2018-04-16 11:00:43 -060088 for (uint32_t i = 0; i < pCreateInfo->enabledExtensionCount; i++) {
Mark Lobodzinski05cce202019-08-27 10:28:37 -060089 skip |= validate_extension_reqs(local_instance_extensions, "VUID-vkCreateInstance-ppEnabledExtensionNames-01388",
90 "instance", pCreateInfo->ppEnabledExtensionNames[i]);
John Zulauf620755c2018-04-16 11:00:43 -060091 }
92
93 return skip;
94}
95
Mark Lobodzinskibece6c12020-08-27 15:34:02 -060096bool StatelessValidation::SupportedByPdev(const VkPhysicalDevice physical_device, const std::string ext_name) const {
97 if (instance_extensions.vk_khr_get_physical_device_properties_2) {
98 // Struct is legal IF it's supported
99 const auto &dev_exts_enumerated = device_extensions_enumerated.find(physical_device);
100 if (dev_exts_enumerated == device_extensions_enumerated.end()) return true;
101 auto enum_iter = dev_exts_enumerated->second.find(ext_name);
102 if (enum_iter != dev_exts_enumerated->second.cend()) {
103 return true;
104 }
105 }
106 return false;
107}
108
Tony-LunarG866843d2020-05-13 11:22:42 -0600109bool StatelessValidation::validate_validation_features(const VkInstanceCreateInfo *pCreateInfo,
110 const VkValidationFeaturesEXT *validation_features) const {
111 bool skip = false;
112 bool debug_printf = false;
113 bool gpu_assisted = false;
114 bool reserve_slot = false;
115 for (uint32_t i = 0; i < validation_features->enabledValidationFeatureCount; i++) {
116 switch (validation_features->pEnabledValidationFeatures[i]) {
117 case VK_VALIDATION_FEATURE_ENABLE_GPU_ASSISTED_EXT:
118 gpu_assisted = true;
119 break;
120
121 case VK_VALIDATION_FEATURE_ENABLE_DEBUG_PRINTF_EXT:
122 debug_printf = true;
123 break;
124
125 case VK_VALIDATION_FEATURE_ENABLE_GPU_ASSISTED_RESERVE_BINDING_SLOT_EXT:
126 reserve_slot = true;
127 break;
128
129 default:
130 break;
131 }
132 }
133 if (reserve_slot && !gpu_assisted) {
134 skip |= LogError(instance, "VUID-VkValidationFeaturesEXT-pEnabledValidationFeatures-02967",
135 "If VK_VALIDATION_FEATURE_ENABLE_GPU_ASSISTED_RESERVE_BINDING_SLOT_EXT is in pEnabledValidationFeatures, "
136 "VK_VALIDATION_FEATURE_ENABLE_GPU_ASSISTED_EXT must also be in pEnabledValidationFeatures.");
137 }
138 if (gpu_assisted && debug_printf) {
139 skip |= LogError(instance, "VUID-VkValidationFeaturesEXT-pEnabledValidationFeatures-02968",
140 "If VK_VALIDATION_FEATURE_ENABLE_GPU_ASSISTED_EXT is in pEnabledValidationFeatures, "
141 "VK_VALIDATION_FEATURE_ENABLE_DEBUG_PRINTF_EXT must not also be in pEnabledValidationFeatures.");
142 }
143
144 return skip;
145}
146
John Zulauf620755c2018-04-16 11:00:43 -0600147template <typename ExtensionState>
Tony-LunarG2ec96bb2019-11-26 13:43:02 -0700148ExtEnabled extension_state_by_name(const ExtensionState &extensions, const char *extension_name) {
149 if (!extension_name) return kNotEnabled; // null strings specify nothing
John Zulauf620755c2018-04-16 11:00:43 -0600150 auto info = ExtensionState::get_info(extension_name);
Tony-LunarG2ec96bb2019-11-26 13:43:02 -0700151 ExtEnabled state =
152 info.state ? extensions.*(info.state) : kNotEnabled; // unknown extensions can't be enabled in extension struct
John Zulauf620755c2018-04-16 11:00:43 -0600153 return state;
154}
155
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700156bool StatelessValidation::manual_PreCallValidateCreateInstance(const VkInstanceCreateInfo *pCreateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -0500157 const VkAllocationCallbacks *pAllocator,
158 VkInstance *pInstance) const {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700159 bool skip = false;
160 // Note: From the spec--
161 // Providing a NULL VkInstanceCreateInfo::pApplicationInfo or providing an apiVersion of 0 is equivalent to providing
162 // an apiVersion of VK_MAKE_VERSION(1, 0, 0). (a.k.a. VK_API_VERSION_1_0)
163 uint32_t local_api_version = (pCreateInfo->pApplicationInfo && pCreateInfo->pApplicationInfo->apiVersion)
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700164 ? pCreateInfo->pApplicationInfo->apiVersion
165 : VK_API_VERSION_1_0;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700166 skip |= validate_api_version(local_api_version, api_version);
167 skip |= validate_instance_extensions(pCreateInfo);
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700168 const auto *validation_features = LvlFindInChain<VkValidationFeaturesEXT>(pCreateInfo->pNext);
Tony-LunarG866843d2020-05-13 11:22:42 -0600169 if (validation_features) skip |= validate_validation_features(pCreateInfo, validation_features);
170
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700171 return skip;
172}
173
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700174void StatelessValidation::PostCallRecordCreateInstance(const VkInstanceCreateInfo *pCreateInfo,
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -0700175 const VkAllocationCallbacks *pAllocator, VkInstance *pInstance,
176 VkResult result) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700177 auto instance_data = GetLayerDataPtr(get_dispatch_key(*pInstance), layer_data_map);
178 // Copy extension data into local object
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -0700179 if (result != VK_SUCCESS) return;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700180 this->instance_extensions = instance_data->instance_extensions;
Nathaniel Cesario645a15b2021-01-08 22:40:21 -0700181}
Mark Lobodzinski2e40a132020-08-10 14:51:41 -0600182
Nathaniel Cesario645a15b2021-01-08 22:40:21 -0700183void StatelessValidation::CommonPostCallRecordEnumeratePhysicalDevice(const VkPhysicalDevice *phys_devices, const int count) {
184 // Assume phys_devices is valid
185 assert(phys_devices);
186 for (int i = 0; i < count; ++i) {
187 const auto &phys_device = phys_devices[i];
188 if (0 == physical_device_properties_map.count(phys_device)) {
189 auto phys_dev_props = new VkPhysicalDeviceProperties;
190 DispatchGetPhysicalDeviceProperties(phys_device, phys_dev_props);
191 physical_device_properties_map[phys_device] = phys_dev_props;
Mark Lobodzinski2e40a132020-08-10 14:51:41 -0600192
Nathaniel Cesario645a15b2021-01-08 22:40:21 -0700193 // Enumerate the Device Ext Properties to save the PhysicalDevice supported extension state
194 uint32_t ext_count = 0;
195 std::unordered_set<std::string> dev_exts_enumerated{};
196 std::vector<VkExtensionProperties> ext_props{};
197 instance_dispatch_table.EnumerateDeviceExtensionProperties(phys_device, nullptr, &ext_count, nullptr);
198 ext_props.resize(ext_count);
199 instance_dispatch_table.EnumerateDeviceExtensionProperties(phys_device, nullptr, &ext_count, ext_props.data());
200 for (uint32_t j = 0; j < ext_count; j++) {
201 dev_exts_enumerated.insert(ext_props[j].extensionName);
202 }
203 device_extensions_enumerated[phys_device] = std::move(dev_exts_enumerated);
Mark Lobodzinskibece6c12020-08-27 15:34:02 -0600204 }
Nathaniel Cesario645a15b2021-01-08 22:40:21 -0700205 }
206}
207
208void StatelessValidation::PostCallRecordEnumeratePhysicalDevices(VkInstance instance, uint32_t *pPhysicalDeviceCount,
209 VkPhysicalDevice *pPhysicalDevices, VkResult result) {
210 if ((VK_SUCCESS != result) && (VK_INCOMPLETE != result)) {
211 return;
212 }
213
214 if (pPhysicalDeviceCount && pPhysicalDevices) {
215 CommonPostCallRecordEnumeratePhysicalDevice(pPhysicalDevices, *pPhysicalDeviceCount);
216 }
217}
218
219void StatelessValidation::PostCallRecordEnumeratePhysicalDeviceGroups(
220 VkInstance instance, uint32_t *pPhysicalDeviceGroupCount, VkPhysicalDeviceGroupProperties *pPhysicalDeviceGroupProperties,
221 VkResult result) {
222 if ((VK_SUCCESS != result) && (VK_INCOMPLETE != result)) {
223 return;
224 }
225
226 if (pPhysicalDeviceGroupCount && pPhysicalDeviceGroupProperties) {
227 for (uint32_t i = 0; i < *pPhysicalDeviceGroupCount; i++) {
228 const auto &group = pPhysicalDeviceGroupProperties[i];
229 CommonPostCallRecordEnumeratePhysicalDevice(group.physicalDevices, group.physicalDeviceCount);
230 }
Mark Lobodzinski2e40a132020-08-10 14:51:41 -0600231 }
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700232}
233
Mark Lobodzinski2e40a132020-08-10 14:51:41 -0600234void StatelessValidation::PreCallRecordDestroyInstance(VkInstance instance, const VkAllocationCallbacks *pAllocator) {
235 for (auto it = physical_device_properties_map.begin(); it != physical_device_properties_map.end();) {
236 delete (it->second);
237 it = physical_device_properties_map.erase(it);
238 }
239};
240
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700241void StatelessValidation::PostCallRecordCreateDevice(VkPhysicalDevice physicalDevice, const VkDeviceCreateInfo *pCreateInfo,
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -0700242 const VkAllocationCallbacks *pAllocator, VkDevice *pDevice, VkResult result) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700243 auto device_data = GetLayerDataPtr(get_dispatch_key(*pDevice), layer_data_map);
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -0700244 if (result != VK_SUCCESS) return;
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700245 ValidationObject *validation_data = GetValidationObject(device_data->object_dispatch, LayerObjectTypeParameterValidation);
246 StatelessValidation *stateless_validation = static_cast<StatelessValidation *>(validation_data);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700247
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700248 // Parmeter validation also uses extension data
249 stateless_validation->device_extensions = this->device_extensions;
250
251 VkPhysicalDeviceProperties device_properties = {};
252 // Need to get instance and do a getlayerdata call...
Tony-LunarG152a88b2019-03-20 15:42:24 -0600253 DispatchGetPhysicalDeviceProperties(physicalDevice, &device_properties);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700254 memcpy(&stateless_validation->device_limits, &device_properties.limits, sizeof(VkPhysicalDeviceLimits));
255
256 if (device_extensions.vk_nv_shading_rate_image) {
257 // Get the needed shading rate image limits
Mark Lobodzinski6fe9e702020-12-30 15:36:39 -0700258 auto shading_rate_image_props = LvlInitStruct<VkPhysicalDeviceShadingRateImagePropertiesNV>();
259 auto prop2 = LvlInitStruct<VkPhysicalDeviceProperties2>(&shading_rate_image_props);
Tony-LunarG152a88b2019-03-20 15:42:24 -0600260 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700261 phys_dev_ext_props.shading_rate_image_props = shading_rate_image_props;
262 }
263
264 if (device_extensions.vk_nv_mesh_shader) {
265 // Get the needed mesh shader limits
Mark Lobodzinski6fe9e702020-12-30 15:36:39 -0700266 auto mesh_shader_props = LvlInitStruct<VkPhysicalDeviceMeshShaderPropertiesNV>();
267 auto prop2 = LvlInitStruct<VkPhysicalDeviceProperties2>(&mesh_shader_props);
Tony-LunarG152a88b2019-03-20 15:42:24 -0600268 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700269 phys_dev_ext_props.mesh_shader_props = mesh_shader_props;
270 }
271
Jason Macnak5c954952019-07-09 15:46:12 -0700272 if (device_extensions.vk_nv_ray_tracing) {
273 // Get the needed ray tracing limits
Mark Lobodzinski6fe9e702020-12-30 15:36:39 -0700274 auto ray_tracing_props = LvlInitStruct<VkPhysicalDeviceRayTracingPropertiesNV>();
275 auto prop2 = LvlInitStruct<VkPhysicalDeviceProperties2>(&ray_tracing_props);
Jason Macnak5c954952019-07-09 15:46:12 -0700276 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
Jeff Bolz443c2ca2020-03-19 12:11:51 -0500277 phys_dev_ext_props.ray_tracing_propsNV = ray_tracing_props;
278 }
279
sourav parmarcd5fb182020-07-17 12:58:44 -0700280 if (device_extensions.vk_khr_ray_tracing_pipeline) {
Jeff Bolz443c2ca2020-03-19 12:11:51 -0500281 // Get the needed ray tracing limits
Mark Lobodzinski6fe9e702020-12-30 15:36:39 -0700282 auto ray_tracing_props = LvlInitStruct<VkPhysicalDeviceRayTracingPipelinePropertiesKHR>();
283 auto prop2 = LvlInitStruct<VkPhysicalDeviceProperties2>(&ray_tracing_props);
Jeff Bolz443c2ca2020-03-19 12:11:51 -0500284 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
285 phys_dev_ext_props.ray_tracing_propsKHR = ray_tracing_props;
Jason Macnak5c954952019-07-09 15:46:12 -0700286 }
287
sourav parmarcd5fb182020-07-17 12:58:44 -0700288 if (device_extensions.vk_khr_acceleration_structure) {
289 // Get the needed ray tracing acc structure limits
Mark Lobodzinski6fe9e702020-12-30 15:36:39 -0700290 auto acc_structure_props = LvlInitStruct<VkPhysicalDeviceAccelerationStructurePropertiesKHR>();
291 auto prop2 = LvlInitStruct<VkPhysicalDeviceProperties2>(&acc_structure_props);
sourav parmarcd5fb182020-07-17 12:58:44 -0700292 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
293 phys_dev_ext_props.acc_structure_props = acc_structure_props;
294 }
295
Mark Lobodzinski953b7bc2019-12-19 13:50:10 -0700296 if (device_extensions.vk_ext_transform_feedback) {
297 // Get the needed transform feedback limits
Mark Lobodzinski6fe9e702020-12-30 15:36:39 -0700298 auto transform_feedback_props = LvlInitStruct<VkPhysicalDeviceTransformFeedbackPropertiesEXT>();
299 auto prop2 = LvlInitStruct<VkPhysicalDeviceProperties2>(&transform_feedback_props);
Mark Lobodzinski953b7bc2019-12-19 13:50:10 -0700300 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
301 phys_dev_ext_props.transform_feedback_props = transform_feedback_props;
302 }
303
Jasper St. Pierrea49b4be2019-02-05 17:48:57 -0800304 stateless_validation->phys_dev_ext_props = this->phys_dev_ext_props;
305
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700306 // Save app-enabled features in this device's validation object
307 // The enabled features can come from either pEnabledFeatures, or from the pNext chain
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700308 const auto *features2 = LvlFindInChain<VkPhysicalDeviceFeatures2>(pCreateInfo->pNext);
Petr Kraus715bcc72019-08-15 17:17:33 +0200309 safe_VkPhysicalDeviceFeatures2 tmp_features2_state;
310 tmp_features2_state.sType = VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_FEATURES_2;
311 if (features2) {
312 tmp_features2_state.features = features2->features;
313 } else if (pCreateInfo->pEnabledFeatures) {
314 tmp_features2_state.features = *pCreateInfo->pEnabledFeatures;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700315 } else {
Petr Kraus715bcc72019-08-15 17:17:33 +0200316 tmp_features2_state.features = {};
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700317 }
Petr Kraus715bcc72019-08-15 17:17:33 +0200318 // Use pCreateInfo->pNext to get full chain
Tony-LunarG6c3c5452019-12-13 10:37:38 -0700319 stateless_validation->device_createinfo_pnext = SafePnextCopy(pCreateInfo->pNext);
Petr Kraus715bcc72019-08-15 17:17:33 +0200320 stateless_validation->physical_device_features2 = tmp_features2_state;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700321}
322
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700323bool StatelessValidation::manual_PreCallValidateCreateDevice(VkPhysicalDevice physicalDevice, const VkDeviceCreateInfo *pCreateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -0500324 const VkAllocationCallbacks *pAllocator, VkDevice *pDevice) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600325 bool skip = false;
326
Petr Kraus6c4bdce2019-08-27 17:35:01 +0200327 for (size_t i = 0; i < pCreateInfo->enabledLayerCount; i++) {
328 skip |= validate_string("vkCreateDevice", "pCreateInfo->ppEnabledLayerNames",
329 "VUID-VkDeviceCreateInfo-ppEnabledLayerNames-parameter", pCreateInfo->ppEnabledLayerNames[i]);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600330 }
331
Nathaniel Cesariob3f2d702020-11-09 09:20:49 -0700332 // If this device supports VK_KHR_portability_subset, it must be enabled
333 const std::string portability_extension_name("VK_KHR_portability_subset");
334 const auto &dev_extensions = device_extensions_enumerated.at(physicalDevice);
335 const bool portability_supported = dev_extensions.count(portability_extension_name) != 0;
336 bool portability_requested = false;
337
Petr Kraus6c4bdce2019-08-27 17:35:01 +0200338 for (size_t i = 0; i < pCreateInfo->enabledExtensionCount; i++) {
339 skip |=
340 validate_string("vkCreateDevice", "pCreateInfo->ppEnabledExtensionNames",
341 "VUID-VkDeviceCreateInfo-ppEnabledExtensionNames-parameter", pCreateInfo->ppEnabledExtensionNames[i]);
342 skip |= validate_extension_reqs(device_extensions, "VUID-vkCreateDevice-ppEnabledExtensionNames-01387", "device",
343 pCreateInfo->ppEnabledExtensionNames[i]);
Nathaniel Cesariob3f2d702020-11-09 09:20:49 -0700344 if (portability_extension_name == pCreateInfo->ppEnabledExtensionNames[i]) {
345 portability_requested = true;
346 }
347 }
348
349 if (portability_supported && !portability_requested) {
350 skip |= LogError(physicalDevice, "VUID-VkDeviceCreateInfo-pProperties-04451",
351 "vkCreateDevice: VK_KHR_portability_subset must be enabled because physical device %s supports it",
352 report_data->FormatHandle(physicalDevice).c_str());
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600353 }
354
Petr Kraus6c4bdce2019-08-27 17:35:01 +0200355 {
Tony-LunarG2ec96bb2019-11-26 13:43:02 -0700356 bool maint1 = IsExtEnabled(extension_state_by_name(device_extensions, VK_KHR_MAINTENANCE1_EXTENSION_NAME));
357 bool negative_viewport =
358 IsExtEnabled(extension_state_by_name(device_extensions, VK_AMD_NEGATIVE_VIEWPORT_HEIGHT_EXTENSION_NAME));
Petr Kraus6c4bdce2019-08-27 17:35:01 +0200359 if (maint1 && negative_viewport) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700360 skip |= LogError(device, "VUID-VkDeviceCreateInfo-ppEnabledExtensionNames-00374",
361 "VkDeviceCreateInfo->ppEnabledExtensionNames must not simultaneously include VK_KHR_maintenance1 and "
362 "VK_AMD_negative_viewport_height.");
Petr Kraus6c4bdce2019-08-27 17:35:01 +0200363 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600364 }
365
Jeff Bolz4563f2a2019-12-10 13:30:30 -0600366 {
367 bool khr_bda = IsExtEnabled(extension_state_by_name(device_extensions, VK_KHR_BUFFER_DEVICE_ADDRESS_EXTENSION_NAME));
368 bool ext_bda = IsExtEnabled(extension_state_by_name(device_extensions, VK_EXT_BUFFER_DEVICE_ADDRESS_EXTENSION_NAME));
369 if (khr_bda && ext_bda) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700370 skip |= LogError(device, "VUID-VkDeviceCreateInfo-ppEnabledExtensionNames-03328",
371 "VkDeviceCreateInfo->ppEnabledExtensionNames must not contain both VK_KHR_buffer_device_address and "
372 "VK_EXT_buffer_device_address.");
Jeff Bolz4563f2a2019-12-10 13:30:30 -0600373 }
374 }
375
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600376 if (pCreateInfo->pNext != NULL && pCreateInfo->pEnabledFeatures) {
377 // Check for get_physical_device_properties2 struct
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700378 const auto *features2 = LvlFindInChain<VkPhysicalDeviceFeatures2>(pCreateInfo->pNext);
John Zulaufde972ac2017-10-26 12:07:05 -0600379 if (features2) {
Mike Schuchardt2df08912020-12-15 16:28:09 -0800380 // Cannot include VkPhysicalDeviceFeatures2 and have non-null pEnabledFeatures
sfricke-samsung590ae1e2020-04-25 01:18:05 -0700381 skip |= LogError(device, "VUID-VkDeviceCreateInfo-pNext-00373",
Mike Schuchardt2df08912020-12-15 16:28:09 -0800382 "VkDeviceCreateInfo->pNext includes a VkPhysicalDeviceFeatures2 struct when "
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700383 "pCreateInfo->pEnabledFeatures is non-NULL.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600384 }
385 }
386
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700387 auto features2 = LvlFindInChain<VkPhysicalDeviceFeatures2>(pCreateInfo->pNext);
Jeff Bolz165818a2020-05-08 11:19:03 -0500388 const VkPhysicalDeviceFeatures *features = features2 ? &features2->features : pCreateInfo->pEnabledFeatures;
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700389 const auto *robustness2_features = LvlFindInChain<VkPhysicalDeviceRobustness2FeaturesEXT>(pCreateInfo->pNext);
Jeff Bolz165818a2020-05-08 11:19:03 -0500390 if (features && robustness2_features && robustness2_features->robustBufferAccess2 && !features->robustBufferAccess) {
391 skip |= LogError(device, "VUID-VkPhysicalDeviceRobustness2FeaturesEXT-robustBufferAccess2-04000",
392 "If robustBufferAccess2 is enabled then robustBufferAccess must be enabled.");
393 }
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700394 const auto *raytracing_features = LvlFindInChain<VkPhysicalDeviceRayTracingPipelineFeaturesKHR>(pCreateInfo->pNext);
sourav parmarcd5fb182020-07-17 12:58:44 -0700395 if (raytracing_features && raytracing_features->rayTracingPipelineShaderGroupHandleCaptureReplayMixed &&
396 !raytracing_features->rayTracingPipelineShaderGroupHandleCaptureReplay) {
397 skip |= LogError(
398 device,
399 "VUID-VkPhysicalDeviceRayTracingPipelineFeaturesKHR-rayTracingPipelineShaderGroupHandleCaptureReplayMixed-03575",
400 "If rayTracingPipelineShaderGroupHandleCaptureReplayMixed is VK_TRUE, rayTracingPipelineShaderGroupHandleCaptureReplay "
401 "must also be VK_TRUE.");
sourav parmara24fb7b2020-05-26 10:50:04 -0700402 }
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700403 auto vertex_attribute_divisor_features = LvlFindInChain<VkPhysicalDeviceVertexAttributeDivisorFeaturesEXT>(pCreateInfo->pNext);
Mark Lobodzinski3e66ae82020-08-12 16:27:29 -0600404 if (vertex_attribute_divisor_features && (!device_extensions.vk_ext_vertex_attribute_divisor)) {
405 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
406 "VkDeviceCreateInfo->pNext includes a VkPhysicalDeviceVertexAttributeDivisorFeaturesEXT "
407 "struct, VK_EXT_vertex_attribute_divisor must be enabled when it creates a device.");
Locke77fad1c2019-04-16 13:09:03 -0600408 }
409
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700410 const auto *vulkan_11_features = LvlFindInChain<VkPhysicalDeviceVulkan11Features>(pCreateInfo->pNext);
Tony-LunarG28017bc2020-01-23 14:40:25 -0700411 if (vulkan_11_features) {
412 const VkBaseOutStructure *current = reinterpret_cast<const VkBaseOutStructure *>(pCreateInfo->pNext);
413 while (current) {
414 if (current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_16BIT_STORAGE_FEATURES ||
415 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_MULTIVIEW_FEATURES ||
416 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_VARIABLE_POINTERS_FEATURES ||
417 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_PROTECTED_MEMORY_FEATURES ||
418 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SAMPLER_YCBCR_CONVERSION_FEATURES ||
419 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SHADER_DRAW_PARAMETERS_FEATURES) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700420 skip |= LogError(
421 instance, "VUID-VkDeviceCreateInfo-pNext-02829",
Tony-LunarG28017bc2020-01-23 14:40:25 -0700422 "If the pNext chain includes a VkPhysicalDeviceVulkan11Features structure, then it must not include a "
423 "VkPhysicalDevice16BitStorageFeatures, VkPhysicalDeviceMultiviewFeatures, "
424 "VkPhysicalDeviceVariablePointersFeatures, VkPhysicalDeviceProtectedMemoryFeatures, "
425 "VkPhysicalDeviceSamplerYcbcrConversionFeatures, or VkPhysicalDeviceShaderDrawParametersFeatures structure");
426 break;
427 }
428 current = reinterpret_cast<const VkBaseOutStructure *>(current->pNext);
429 }
sfricke-samsungebda6792021-01-16 08:57:52 -0800430
431 // Check features are enabled if matching extension is passed in as well
432 for (uint32_t i = 0; i < pCreateInfo->enabledExtensionCount; i++) {
433 const char *extension = pCreateInfo->ppEnabledExtensionNames[i];
434 if ((0 == strncmp(extension, VK_KHR_SHADER_DRAW_PARAMETERS_EXTENSION_NAME, VK_MAX_EXTENSION_NAME_SIZE)) &&
435 (vulkan_11_features->shaderDrawParameters == VK_FALSE)) {
436 skip |= LogError(
437 instance, "VUID-VkDeviceCreateInfo-ppEnabledExtensions-04476",
438 "vkCreateDevice(): %s is enabled but VkPhysicalDeviceVulkan11Features::shaderDrawParameters is not VK_TRUE.",
439 VK_KHR_SHADER_DRAW_PARAMETERS_EXTENSION_NAME);
440 }
441 }
Tony-LunarG28017bc2020-01-23 14:40:25 -0700442 }
443
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700444 const auto *vulkan_12_features = LvlFindInChain<VkPhysicalDeviceVulkan12Features>(pCreateInfo->pNext);
Tony-LunarG28017bc2020-01-23 14:40:25 -0700445 if (vulkan_12_features) {
446 const VkBaseOutStructure *current = reinterpret_cast<const VkBaseOutStructure *>(pCreateInfo->pNext);
447 while (current) {
448 if (current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_8BIT_STORAGE_FEATURES ||
449 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SHADER_ATOMIC_INT64_FEATURES ||
450 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SHADER_FLOAT16_INT8_FEATURES ||
451 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_DESCRIPTOR_INDEXING_FEATURES ||
452 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SCALAR_BLOCK_LAYOUT_FEATURES ||
453 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_IMAGELESS_FRAMEBUFFER_FEATURES ||
454 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_UNIFORM_BUFFER_STANDARD_LAYOUT_FEATURES ||
455 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SHADER_SUBGROUP_EXTENDED_TYPES_FEATURES ||
456 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SEPARATE_DEPTH_STENCIL_LAYOUTS_FEATURES ||
457 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_HOST_QUERY_RESET_FEATURES ||
458 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_TIMELINE_SEMAPHORE_FEATURES ||
459 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_BUFFER_DEVICE_ADDRESS_FEATURES ||
460 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_VULKAN_MEMORY_MODEL_FEATURES) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700461 skip |= LogError(
462 instance, "VUID-VkDeviceCreateInfo-pNext-02830",
Tony-LunarG28017bc2020-01-23 14:40:25 -0700463 "If the pNext chain includes a VkPhysicalDeviceVulkan12Features structure, then it must not include a "
464 "VkPhysicalDevice8BitStorageFeatures, VkPhysicalDeviceShaderAtomicInt64Features, "
465 "VkPhysicalDeviceShaderFloat16Int8Features, VkPhysicalDeviceDescriptorIndexingFeatures, "
466 "VkPhysicalDeviceScalarBlockLayoutFeatures, VkPhysicalDeviceImagelessFramebufferFeatures, "
467 "VkPhysicalDeviceUniformBufferStandardLayoutFeatures, VkPhysicalDeviceShaderSubgroupExtendedTypesFeatures, "
468 "VkPhysicalDeviceSeparateDepthStencilLayoutsFeatures, VkPhysicalDeviceHostQueryResetFeatures, "
469 "VkPhysicalDeviceTimelineSemaphoreFeatures, VkPhysicalDeviceBufferDeviceAddressFeatures, or "
470 "VkPhysicalDeviceVulkanMemoryModelFeatures structure");
471 break;
472 }
473 current = reinterpret_cast<const VkBaseOutStructure *>(current->pNext);
474 }
sfricke-samsungabab4632020-05-04 06:51:46 -0700475 // Check features are enabled if matching extension is passed in as well
476 for (uint32_t i = 0; i < pCreateInfo->enabledExtensionCount; i++) {
477 const char *extension = pCreateInfo->ppEnabledExtensionNames[i];
478 if ((0 == strncmp(extension, VK_KHR_DRAW_INDIRECT_COUNT_EXTENSION_NAME, VK_MAX_EXTENSION_NAME_SIZE)) &&
479 (vulkan_12_features->drawIndirectCount == VK_FALSE)) {
480 skip |= LogError(
481 instance, "VUID-VkDeviceCreateInfo-ppEnabledExtensions-02831",
482 "vkCreateDevice(): %s is enabled but VkPhysicalDeviceVulkan12Features::drawIndirectCount is not VK_TRUE.",
483 VK_KHR_DRAW_INDIRECT_COUNT_EXTENSION_NAME);
484 }
485 if ((0 == strncmp(extension, VK_KHR_SAMPLER_MIRROR_CLAMP_TO_EDGE_EXTENSION_NAME, VK_MAX_EXTENSION_NAME_SIZE)) &&
486 (vulkan_12_features->samplerMirrorClampToEdge == VK_FALSE)) {
487 skip |= LogError(instance, "VUID-VkDeviceCreateInfo-ppEnabledExtensions-02832",
488 "vkCreateDevice(): %s is enabled but VkPhysicalDeviceVulkan12Features::samplerMirrorClampToEdge "
489 "is not VK_TRUE.",
490 VK_KHR_SAMPLER_MIRROR_CLAMP_TO_EDGE_EXTENSION_NAME);
491 }
492 if ((0 == strncmp(extension, VK_EXT_DESCRIPTOR_INDEXING_EXTENSION_NAME, VK_MAX_EXTENSION_NAME_SIZE)) &&
493 (vulkan_12_features->descriptorIndexing == VK_FALSE)) {
494 skip |= LogError(
495 instance, "VUID-VkDeviceCreateInfo-ppEnabledExtensions-02833",
496 "vkCreateDevice(): %s is enabled but VkPhysicalDeviceVulkan12Features::descriptorIndexing is not VK_TRUE.",
497 VK_EXT_DESCRIPTOR_INDEXING_EXTENSION_NAME);
498 }
499 if ((0 == strncmp(extension, VK_EXT_SAMPLER_FILTER_MINMAX_EXTENSION_NAME, VK_MAX_EXTENSION_NAME_SIZE)) &&
500 (vulkan_12_features->samplerFilterMinmax == VK_FALSE)) {
501 skip |= LogError(
502 instance, "VUID-VkDeviceCreateInfo-ppEnabledExtensions-02834",
503 "vkCreateDevice(): %s is enabled but VkPhysicalDeviceVulkan12Features::samplerFilterMinmax is not VK_TRUE.",
504 VK_EXT_SAMPLER_FILTER_MINMAX_EXTENSION_NAME);
505 }
506 if ((0 == strncmp(extension, VK_EXT_SHADER_VIEWPORT_INDEX_LAYER_EXTENSION_NAME, VK_MAX_EXTENSION_NAME_SIZE)) &&
507 ((vulkan_12_features->shaderOutputViewportIndex == VK_FALSE) ||
508 (vulkan_12_features->shaderOutputLayer == VK_FALSE))) {
509 skip |=
510 LogError(instance, "VUID-VkDeviceCreateInfo-ppEnabledExtensions-02835",
511 "vkCreateDevice(): %s is enabled but both VkPhysicalDeviceVulkan12Features::shaderOutputViewportIndex "
512 "and VkPhysicalDeviceVulkan12Features::shaderOutputLayer are not VK_TRUE.",
513 VK_EXT_SHADER_VIEWPORT_INDEX_LAYER_EXTENSION_NAME);
514 }
515 }
Tony-LunarG28017bc2020-01-23 14:40:25 -0700516 }
517
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600518 // Validate pCreateInfo->pQueueCreateInfos
519 if (pCreateInfo->pQueueCreateInfos) {
520 std::unordered_set<uint32_t> set;
521
522 for (uint32_t i = 0; i < pCreateInfo->queueCreateInfoCount; ++i) {
sfricke-samsung590ae1e2020-04-25 01:18:05 -0700523 const VkDeviceQueueCreateInfo &queue_create_info = pCreateInfo->pQueueCreateInfos[i];
524 const uint32_t requested_queue_family = queue_create_info.queueFamilyIndex;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600525 if (requested_queue_family == VK_QUEUE_FAMILY_IGNORED) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700526 skip |=
527 LogError(physicalDevice, "VUID-VkDeviceQueueCreateInfo-queueFamilyIndex-00381",
528 "vkCreateDevice: pCreateInfo->pQueueCreateInfos[%" PRIu32
529 "].queueFamilyIndex is VK_QUEUE_FAMILY_IGNORED, but it is required to provide a valid queue family "
530 "index value.",
531 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600532 } else if (set.count(requested_queue_family)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700533 skip |= LogError(physicalDevice, "VUID-VkDeviceCreateInfo-queueFamilyIndex-00372",
534 "vkCreateDevice: pCreateInfo->pQueueCreateInfos[%" PRIu32 "].queueFamilyIndex (=%" PRIu32
535 ") is not unique within pCreateInfo->pQueueCreateInfos array.",
536 i, requested_queue_family);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600537 } else {
538 set.insert(requested_queue_family);
539 }
540
sfricke-samsung590ae1e2020-04-25 01:18:05 -0700541 if (queue_create_info.pQueuePriorities != nullptr) {
542 for (uint32_t j = 0; j < queue_create_info.queueCount; ++j) {
543 const float queue_priority = queue_create_info.pQueuePriorities[j];
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600544 if (!(queue_priority >= 0.f) || !(queue_priority <= 1.f)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700545 skip |= LogError(physicalDevice, "VUID-VkDeviceQueueCreateInfo-pQueuePriorities-00383",
546 "vkCreateDevice: pCreateInfo->pQueueCreateInfos[%" PRIu32 "].pQueuePriorities[%" PRIu32
547 "] (=%f) is not between 0 and 1 (inclusive).",
548 i, j, queue_priority);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600549 }
550 }
551 }
sfricke-samsung590ae1e2020-04-25 01:18:05 -0700552
553 // Need to know if protectedMemory feature is passed in preCall to creating the device
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700554 VkBool32 protected_memory = VK_FALSE;
sfricke-samsung590ae1e2020-04-25 01:18:05 -0700555 const VkPhysicalDeviceProtectedMemoryFeatures *protected_features =
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700556 LvlFindInChain<VkPhysicalDeviceProtectedMemoryFeatures>(pCreateInfo->pNext);
sfricke-samsung590ae1e2020-04-25 01:18:05 -0700557 if (protected_features) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700558 protected_memory = protected_features->protectedMemory;
sfricke-samsung590ae1e2020-04-25 01:18:05 -0700559 } else if (vulkan_11_features) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700560 protected_memory = vulkan_11_features->protectedMemory;
sfricke-samsung590ae1e2020-04-25 01:18:05 -0700561 }
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700562 if ((queue_create_info.flags == VK_DEVICE_QUEUE_CREATE_PROTECTED_BIT) && (protected_memory == VK_FALSE)) {
sfricke-samsung590ae1e2020-04-25 01:18:05 -0700563 skip |= LogError(physicalDevice, "VUID-VkDeviceQueueCreateInfo-flags-02861",
564 "vkCreateDevice: pCreateInfo->flags set to VK_DEVICE_QUEUE_CREATE_PROTECTED_BIT without the "
565 "protectedMemory feature being set as well.");
566 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600567 }
568 }
569
sfricke-samsung30a57412020-05-15 21:14:54 -0700570 // feature dependencies for VK_KHR_variable_pointers
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700571 const auto *variable_pointers_features = LvlFindInChain<VkPhysicalDeviceVariablePointersFeatures>(pCreateInfo->pNext);
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700572 VkBool32 variable_pointers = VK_FALSE;
573 VkBool32 variable_pointers_storage_buffer = VK_FALSE;
sfricke-samsung30a57412020-05-15 21:14:54 -0700574 if (vulkan_11_features) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700575 variable_pointers = vulkan_11_features->variablePointers;
576 variable_pointers_storage_buffer = vulkan_11_features->variablePointersStorageBuffer;
sfricke-samsung30a57412020-05-15 21:14:54 -0700577 } else if (variable_pointers_features) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700578 variable_pointers = variable_pointers_features->variablePointers;
579 variable_pointers_storage_buffer = variable_pointers_features->variablePointersStorageBuffer;
sfricke-samsung30a57412020-05-15 21:14:54 -0700580 }
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700581 if ((variable_pointers == VK_TRUE) && (variable_pointers_storage_buffer == VK_FALSE)) {
sfricke-samsung30a57412020-05-15 21:14:54 -0700582 skip |= LogError(instance, "VUID-VkPhysicalDeviceVariablePointersFeatures-variablePointers-01431",
583 "If variablePointers is VK_TRUE then variablePointersStorageBuffer also needs to be VK_TRUE");
584 }
585
sfricke-samsungfd76c342020-05-29 23:13:43 -0700586 // feature dependencies for VK_KHR_multiview
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700587 const auto *multiview_features = LvlFindInChain<VkPhysicalDeviceMultiviewFeatures>(pCreateInfo->pNext);
sfricke-samsungfd76c342020-05-29 23:13:43 -0700588 VkBool32 multiview = VK_FALSE;
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700589 VkBool32 multiview_geometry_shader = VK_FALSE;
590 VkBool32 multiview_tessellation_shader = VK_FALSE;
sfricke-samsungfd76c342020-05-29 23:13:43 -0700591 if (vulkan_11_features) {
592 multiview = vulkan_11_features->multiview;
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700593 multiview_geometry_shader = vulkan_11_features->multiviewGeometryShader;
594 multiview_tessellation_shader = vulkan_11_features->multiviewTessellationShader;
sfricke-samsungfd76c342020-05-29 23:13:43 -0700595 } else if (multiview_features) {
596 multiview = multiview_features->multiview;
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700597 multiview_geometry_shader = multiview_features->multiviewGeometryShader;
598 multiview_tessellation_shader = multiview_features->multiviewTessellationShader;
sfricke-samsungfd76c342020-05-29 23:13:43 -0700599 }
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700600 if ((multiview == VK_FALSE) && (multiview_geometry_shader == VK_TRUE)) {
sfricke-samsungfd76c342020-05-29 23:13:43 -0700601 skip |= LogError(instance, "VUID-VkPhysicalDeviceMultiviewFeatures-multiviewGeometryShader-00580",
602 "If multiviewGeometryShader is VK_TRUE then multiview also needs to be VK_TRUE");
603 }
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700604 if ((multiview == VK_FALSE) && (multiview_tessellation_shader == VK_TRUE)) {
sfricke-samsungfd76c342020-05-29 23:13:43 -0700605 skip |= LogError(instance, "VUID-VkPhysicalDeviceMultiviewFeatures-multiviewTessellationShader-00581",
606 "If multiviewTessellationShader is VK_TRUE then multiview also needs to be VK_TRUE");
607 }
608
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600609 return skip;
610}
611
Jeff Bolz46c0ea02019-10-09 13:06:29 -0500612bool StatelessValidation::require_device_extension(bool flag, char const *function_name, char const *extension_name) const {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700613 if (!flag) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700614 return LogError(device, kVUID_PVError_ExtensionNotEnabled,
615 "%s() called even though the %s extension was not enabled for this VkDevice.", function_name,
616 extension_name);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600617 }
618
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700619 return false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600620}
621
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700622bool StatelessValidation::manual_PreCallValidateCreateBuffer(VkDevice device, const VkBufferCreateInfo *pCreateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -0500623 const VkAllocationCallbacks *pAllocator, VkBuffer *pBuffer) const {
Petr Krause91f7a12017-12-14 20:57:36 +0100624 bool skip = false;
625
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600626 if (pCreateInfo != nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700627 skip |=
628 ValidateGreaterThanZero(pCreateInfo->size, "pCreateInfo->size", "VUID-VkBufferCreateInfo-size-00912", "vkCreateBuffer");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600629
630 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
631 if (pCreateInfo->sharingMode == VK_SHARING_MODE_CONCURRENT) {
632 // If sharingMode is VK_SHARING_MODE_CONCURRENT, queueFamilyIndexCount must be greater than 1
633 if (pCreateInfo->queueFamilyIndexCount <= 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700634 skip |= LogError(device, "VUID-VkBufferCreateInfo-sharingMode-00914",
635 "vkCreateBuffer: if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
636 "pCreateInfo->queueFamilyIndexCount must be greater than 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600637 }
638
639 // If sharingMode is VK_SHARING_MODE_CONCURRENT, pQueueFamilyIndices must be a pointer to an array of
640 // queueFamilyIndexCount uint32_t values
641 if (pCreateInfo->pQueueFamilyIndices == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700642 skip |= LogError(device, "VUID-VkBufferCreateInfo-sharingMode-00913",
643 "vkCreateBuffer: if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
644 "pCreateInfo->pQueueFamilyIndices must be a pointer to an array of "
645 "pCreateInfo->queueFamilyIndexCount uint32_t values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600646 }
647 }
648
sfricke-samsung8f8cf052020-07-03 22:44:29 -0700649 if ((pCreateInfo->flags & VK_BUFFER_CREATE_SPARSE_BINDING_BIT) && (!physical_device_features.sparseBinding)) {
650 skip |= LogError(device, "VUID-VkBufferCreateInfo-flags-00915",
651 "vkCreateBuffer(): the sparseBinding device feature is disabled: Buffers cannot be created with the "
652 "VK_BUFFER_CREATE_SPARSE_BINDING_BIT set.");
653 }
654
655 if ((pCreateInfo->flags & VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT) && (!physical_device_features.sparseResidencyBuffer)) {
656 skip |=
657 LogError(device, "VUID-VkBufferCreateInfo-flags-00916",
658 "vkCreateBuffer(): the sparseResidencyBuffer device feature is disabled: Buffers cannot be created with "
659 "the VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT set.");
660 }
661
662 if ((pCreateInfo->flags & VK_BUFFER_CREATE_SPARSE_ALIASED_BIT) && (!physical_device_features.sparseResidencyAliased)) {
663 skip |=
664 LogError(device, "VUID-VkBufferCreateInfo-flags-00917",
665 "vkCreateBuffer(): the sparseResidencyAliased device feature is disabled: Buffers cannot be created with "
666 "the VK_BUFFER_CREATE_SPARSE_ALIASED_BIT set.");
667 }
668
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600669 // If flags contains VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT or VK_BUFFER_CREATE_SPARSE_ALIASED_BIT, it must also contain
670 // VK_BUFFER_CREATE_SPARSE_BINDING_BIT
671 if (((pCreateInfo->flags & (VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT | VK_BUFFER_CREATE_SPARSE_ALIASED_BIT)) != 0) &&
672 ((pCreateInfo->flags & VK_BUFFER_CREATE_SPARSE_BINDING_BIT) != VK_BUFFER_CREATE_SPARSE_BINDING_BIT)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700673 skip |= LogError(device, "VUID-VkBufferCreateInfo-flags-00918",
674 "vkCreateBuffer: if pCreateInfo->flags contains VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT or "
675 "VK_BUFFER_CREATE_SPARSE_ALIASED_BIT, it must also contain VK_BUFFER_CREATE_SPARSE_BINDING_BIT.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600676 }
677 }
678
679 return skip;
680}
681
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700682bool StatelessValidation::manual_PreCallValidateCreateImage(VkDevice device, const VkImageCreateInfo *pCreateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -0500683 const VkAllocationCallbacks *pAllocator, VkImage *pImage) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600684 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600685
686 if (pCreateInfo != nullptr) {
sfricke-samsung61a57c02021-01-10 21:35:12 -0800687 const VkFormat image_format = pCreateInfo->format;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600688 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
689 if (pCreateInfo->sharingMode == VK_SHARING_MODE_CONCURRENT) {
690 // If sharingMode is VK_SHARING_MODE_CONCURRENT, queueFamilyIndexCount must be greater than 1
691 if (pCreateInfo->queueFamilyIndexCount <= 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700692 skip |= LogError(device, "VUID-VkImageCreateInfo-sharingMode-00942",
693 "vkCreateImage(): if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
694 "pCreateInfo->queueFamilyIndexCount must be greater than 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600695 }
696
697 // If sharingMode is VK_SHARING_MODE_CONCURRENT, pQueueFamilyIndices must be a pointer to an array of
698 // queueFamilyIndexCount uint32_t values
699 if (pCreateInfo->pQueueFamilyIndices == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700700 skip |= LogError(device, "VUID-VkImageCreateInfo-sharingMode-00941",
701 "vkCreateImage(): if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
702 "pCreateInfo->pQueueFamilyIndices must be a pointer to an array of "
703 "pCreateInfo->queueFamilyIndexCount uint32_t values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600704 }
705 }
706
Dave Houlton413a6782018-05-22 13:01:54 -0600707 skip |= ValidateGreaterThanZero(pCreateInfo->extent.width, "pCreateInfo->extent.width",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700708 "VUID-VkImageCreateInfo-extent-00944", "vkCreateImage");
Dave Houlton413a6782018-05-22 13:01:54 -0600709 skip |= ValidateGreaterThanZero(pCreateInfo->extent.height, "pCreateInfo->extent.height",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700710 "VUID-VkImageCreateInfo-extent-00945", "vkCreateImage");
Dave Houlton413a6782018-05-22 13:01:54 -0600711 skip |= ValidateGreaterThanZero(pCreateInfo->extent.depth, "pCreateInfo->extent.depth",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700712 "VUID-VkImageCreateInfo-extent-00946", "vkCreateImage");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600713
Dave Houlton413a6782018-05-22 13:01:54 -0600714 skip |= ValidateGreaterThanZero(pCreateInfo->mipLevels, "pCreateInfo->mipLevels", "VUID-VkImageCreateInfo-mipLevels-00947",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700715 "vkCreateImage");
Dave Houlton413a6782018-05-22 13:01:54 -0600716 skip |= ValidateGreaterThanZero(pCreateInfo->arrayLayers, "pCreateInfo->arrayLayers",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700717 "VUID-VkImageCreateInfo-arrayLayers-00948", "vkCreateImage");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600718
Dave Houlton130c0212018-01-29 13:39:56 -0700719 // InitialLayout must be PREINITIALIZED or UNDEFINED
Dave Houltone19e20d2018-02-02 16:32:41 -0700720 if ((pCreateInfo->initialLayout != VK_IMAGE_LAYOUT_UNDEFINED) &&
721 (pCreateInfo->initialLayout != VK_IMAGE_LAYOUT_PREINITIALIZED)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700722 skip |= LogError(
723 device, "VUID-VkImageCreateInfo-initialLayout-00993",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600724 "vkCreateImage(): initialLayout is %s, must be VK_IMAGE_LAYOUT_UNDEFINED or VK_IMAGE_LAYOUT_PREINITIALIZED.",
725 string_VkImageLayout(pCreateInfo->initialLayout));
Dave Houlton130c0212018-01-29 13:39:56 -0700726 }
727
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600728 // If imageType is VK_IMAGE_TYPE_1D, both extent.height and extent.depth must be 1
Petr Kraus3ac9e812018-03-13 12:31:08 +0100729 if ((pCreateInfo->imageType == VK_IMAGE_TYPE_1D) &&
730 ((pCreateInfo->extent.height != 1) || (pCreateInfo->extent.depth != 1))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700731 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00956",
732 "vkCreateImage(): if pCreateInfo->imageType is VK_IMAGE_TYPE_1D, both pCreateInfo->extent.height and "
733 "pCreateInfo->extent.depth must be 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600734 }
735
736 if (pCreateInfo->imageType == VK_IMAGE_TYPE_2D) {
Petr Kraus3f433212018-03-13 12:31:27 +0100737 if (pCreateInfo->flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) {
738 if (pCreateInfo->extent.width != pCreateInfo->extent.height) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700739 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00954",
740 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT, but "
741 "pCreateInfo->extent.width (=%" PRIu32 ") and pCreateInfo->extent.height (=%" PRIu32
742 ") are not equal.",
743 pCreateInfo->extent.width, pCreateInfo->extent.height);
Petr Kraus3f433212018-03-13 12:31:27 +0100744 }
745
746 if (pCreateInfo->arrayLayers < 6) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700747 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00954",
748 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT, but "
749 "pCreateInfo->arrayLayers (=%" PRIu32 ") is not greater than or equal to 6.",
750 pCreateInfo->arrayLayers);
Petr Kraus3f433212018-03-13 12:31:27 +0100751 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600752 }
753
754 if (pCreateInfo->extent.depth != 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700755 skip |= LogError(
756 device, "VUID-VkImageCreateInfo-imageType-00957",
757 "vkCreateImage(): if pCreateInfo->imageType is VK_IMAGE_TYPE_2D, pCreateInfo->extent.depth must be 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600758 }
759 }
760
Dave Houlton130c0212018-01-29 13:39:56 -0700761 // 3D image may have only 1 layer
762 if ((pCreateInfo->imageType == VK_IMAGE_TYPE_3D) && (pCreateInfo->arrayLayers != 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700763 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00961",
764 "vkCreateImage(): if pCreateInfo->imageType is VK_IMAGE_TYPE_3D, pCreateInfo->arrayLayers must be 1.");
Dave Houlton130c0212018-01-29 13:39:56 -0700765 }
766
Dave Houlton130c0212018-01-29 13:39:56 -0700767 if (0 != (pCreateInfo->usage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT)) {
768 VkImageUsageFlags legal_flags = (VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT | VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT |
769 VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT);
770 // At least one of the legal attachment bits must be set
771 if (0 == (pCreateInfo->usage & legal_flags)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700772 skip |= LogError(device, "VUID-VkImageCreateInfo-usage-00966",
773 "vkCreateImage(): Transient attachment image without a compatible attachment flag set.");
Dave Houlton130c0212018-01-29 13:39:56 -0700774 }
775 // No flags other than the legal attachment bits may be set
776 legal_flags |= VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT;
777 if (0 != (pCreateInfo->usage & ~legal_flags)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700778 skip |= LogError(device, "VUID-VkImageCreateInfo-usage-00963",
779 "vkCreateImage(): Transient attachment image with incompatible usage flags set.");
Dave Houlton130c0212018-01-29 13:39:56 -0700780 }
781 }
782
Jeff Bolzef40fec2018-09-01 22:04:34 -0500783 // mipLevels must be less than or equal to the number of levels in the complete mipmap chain
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700784 uint32_t max_dim = std::max(std::max(pCreateInfo->extent.width, pCreateInfo->extent.height), pCreateInfo->extent.depth);
Jeff Bolzef40fec2018-09-01 22:04:34 -0500785 // Max mip levels is different for corner-sampled images vs normal images.
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700786 uint32_t max_mip_levels = (pCreateInfo->flags & VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV)
787 ? static_cast<uint32_t>(ceil(log2(max_dim)))
788 : static_cast<uint32_t>(floor(log2(max_dim)) + 1);
789 if (max_dim > 0 && pCreateInfo->mipLevels > max_mip_levels) {
Dave Houlton413a6782018-05-22 13:01:54 -0600790 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700791 LogError(device, "VUID-VkImageCreateInfo-mipLevels-00958",
792 "vkCreateImage(): pCreateInfo->mipLevels must be less than or equal to "
793 "floor(log2(max(pCreateInfo->extent.width, pCreateInfo->extent.height, pCreateInfo->extent.depth)))+1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600794 }
795
Mark Lobodzinski69259c52018-09-18 15:14:58 -0600796 if ((pCreateInfo->flags & VK_IMAGE_CREATE_2D_ARRAY_COMPATIBLE_BIT) && (pCreateInfo->imageType != VK_IMAGE_TYPE_3D)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700797 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-00950",
798 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_2D_ARRAY_COMPATIBLE_BIT but "
799 "pCreateInfo->imageType is not VK_IMAGE_TYPE_3D.");
Mark Lobodzinski69259c52018-09-18 15:14:58 -0600800 }
801
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700802 if ((pCreateInfo->flags & VK_IMAGE_CREATE_SPARSE_BINDING_BIT) && (!physical_device_features.sparseBinding)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700803 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-00969",
804 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_SPARSE_BINDING_BIT, but the "
805 "VkPhysicalDeviceFeatures::sparseBinding feature is disabled.");
Petr Krausb6f97802018-03-13 12:31:39 +0100806 }
807
sfricke-samsung8f8cf052020-07-03 22:44:29 -0700808 if ((pCreateInfo->flags & VK_IMAGE_CREATE_SPARSE_ALIASED_BIT) && (!physical_device_features.sparseResidencyAliased)) {
809 skip |= LogError(
810 device, "VUID-VkImageCreateInfo-flags-01924",
811 "vkCreateImage(): the sparseResidencyAliased device feature is disabled: Images cannot be created with the "
812 "VK_IMAGE_CREATE_SPARSE_ALIASED_BIT set.");
813 }
814
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600815 // If flags contains VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT or VK_IMAGE_CREATE_SPARSE_ALIASED_BIT, it must also contain
816 // VK_IMAGE_CREATE_SPARSE_BINDING_BIT
817 if (((pCreateInfo->flags & (VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT | VK_IMAGE_CREATE_SPARSE_ALIASED_BIT)) != 0) &&
818 ((pCreateInfo->flags & VK_IMAGE_CREATE_SPARSE_BINDING_BIT) != VK_IMAGE_CREATE_SPARSE_BINDING_BIT)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700819 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-00987",
820 "vkCreateImage: if pCreateInfo->flags contains VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT or "
821 "VK_IMAGE_CREATE_SPARSE_ALIASED_BIT, it must also contain VK_IMAGE_CREATE_SPARSE_BINDING_BIT.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600822 }
823
824 // Check for combinations of attributes that are incompatible with having VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT set
825 if ((pCreateInfo->flags & VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT) != 0) {
826 // Linear tiling is unsupported
827 if (VK_IMAGE_TILING_LINEAR == pCreateInfo->tiling) {
sfricke-samsung9801d752020-08-23 22:00:16 -0700828 skip |= LogError(device, "VUID-VkImageCreateInfo-tiling-04121",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700829 "vkCreateImage: if pCreateInfo->flags contains VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT then image "
830 "tiling of VK_IMAGE_TILING_LINEAR is not supported");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600831 }
832
833 // Sparse 1D image isn't valid
834 if (VK_IMAGE_TYPE_1D == pCreateInfo->imageType) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700835 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00970",
836 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 1D image.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600837 }
838
839 // Sparse 2D image when device doesn't support it
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700840 if ((VK_FALSE == physical_device_features.sparseResidencyImage2D) && (VK_IMAGE_TYPE_2D == pCreateInfo->imageType)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700841 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00971",
842 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 2D image if corresponding "
843 "feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600844 }
845
846 // Sparse 3D image when device doesn't support it
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700847 if ((VK_FALSE == physical_device_features.sparseResidencyImage3D) && (VK_IMAGE_TYPE_3D == pCreateInfo->imageType)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700848 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00972",
849 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 3D image if corresponding "
850 "feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600851 }
852
853 // Multi-sample 2D image when device doesn't support it
854 if (VK_IMAGE_TYPE_2D == pCreateInfo->imageType) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700855 if ((VK_FALSE == physical_device_features.sparseResidency2Samples) &&
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600856 (VK_SAMPLE_COUNT_2_BIT == pCreateInfo->samples)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700857 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00973",
858 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 2-sample image if "
859 "corresponding feature is not enabled on the device.");
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700860 } else if ((VK_FALSE == physical_device_features.sparseResidency4Samples) &&
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600861 (VK_SAMPLE_COUNT_4_BIT == pCreateInfo->samples)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700862 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00974",
863 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 4-sample image if "
864 "corresponding feature is not enabled on the device.");
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700865 } else if ((VK_FALSE == physical_device_features.sparseResidency8Samples) &&
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600866 (VK_SAMPLE_COUNT_8_BIT == pCreateInfo->samples)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700867 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00975",
868 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 8-sample image if "
869 "corresponding feature is not enabled on the device.");
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700870 } else if ((VK_FALSE == physical_device_features.sparseResidency16Samples) &&
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600871 (VK_SAMPLE_COUNT_16_BIT == pCreateInfo->samples)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700872 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00976",
873 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 16-sample image if "
874 "corresponding feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600875 }
876 }
877 }
Jeff Bolzef40fec2018-09-01 22:04:34 -0500878
Jeff Bolz9af91c52018-09-01 21:53:57 -0500879 if (pCreateInfo->usage & VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV) {
880 if (pCreateInfo->imageType != VK_IMAGE_TYPE_2D) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700881 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-02082",
882 "vkCreateImage: if usage includes VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV, "
883 "imageType must be VK_IMAGE_TYPE_2D.");
Jeff Bolz9af91c52018-09-01 21:53:57 -0500884 }
885 if (pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700886 skip |= LogError(device, "VUID-VkImageCreateInfo-samples-02083",
887 "vkCreateImage: if usage includes VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV, "
888 "samples must be VK_SAMPLE_COUNT_1_BIT.");
Jeff Bolz9af91c52018-09-01 21:53:57 -0500889 }
890 if (pCreateInfo->tiling != VK_IMAGE_TILING_OPTIMAL) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700891 skip |= LogError(device, "VUID-VkImageCreateInfo-tiling-02084",
892 "vkCreateImage: if usage includes VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV, "
893 "tiling must be VK_IMAGE_TILING_OPTIMAL.");
Jeff Bolz9af91c52018-09-01 21:53:57 -0500894 }
895 }
Jeff Bolzef40fec2018-09-01 22:04:34 -0500896
897 if (pCreateInfo->flags & VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV) {
Dave Houlton142c4cb2018-10-17 15:04:41 -0600898 if (pCreateInfo->imageType != VK_IMAGE_TYPE_2D && pCreateInfo->imageType != VK_IMAGE_TYPE_3D) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700899 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02050",
900 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV, "
901 "imageType must be VK_IMAGE_TYPE_2D or VK_IMAGE_TYPE_3D.");
Jeff Bolzef40fec2018-09-01 22:04:34 -0500902 }
903
sfricke-samsung61a57c02021-01-10 21:35:12 -0800904 if ((pCreateInfo->flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) || FormatIsDepthOrStencil(image_format)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700905 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02051",
906 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV, "
sfricke-samsung61a57c02021-01-10 21:35:12 -0800907 "it must not also contain VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT and format (%s) must not be a "
908 "depth/stencil format.",
909 string_VkFormat(image_format));
Jeff Bolzef40fec2018-09-01 22:04:34 -0500910 }
911
Dave Houlton142c4cb2018-10-17 15:04:41 -0600912 if (pCreateInfo->imageType == VK_IMAGE_TYPE_2D && (pCreateInfo->extent.width == 1 || pCreateInfo->extent.height == 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700913 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02052",
914 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV and "
915 "imageType is VK_IMAGE_TYPE_2D, extent.width and extent.height must be "
916 "greater than 1.");
Jeff Bolzb8a8dd02018-09-18 02:39:24 -0500917 } else if (pCreateInfo->imageType == VK_IMAGE_TYPE_3D &&
Dave Houlton142c4cb2018-10-17 15:04:41 -0600918 (pCreateInfo->extent.width == 1 || pCreateInfo->extent.height == 1 || pCreateInfo->extent.depth == 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700919 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02053",
920 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV and "
921 "imageType is VK_IMAGE_TYPE_3D, extent.width, extent.height, and extent.depth "
922 "must be greater than 1.");
Jeff Bolzef40fec2018-09-01 22:04:34 -0500923 }
924 }
Andrew Fobel3abeb992020-01-20 16:33:22 -0500925
sfricke-samsung8f658d42020-05-03 20:12:24 -0700926 if (((pCreateInfo->flags & VK_IMAGE_CREATE_SAMPLE_LOCATIONS_COMPATIBLE_DEPTH_BIT_EXT) != 0) &&
sfricke-samsung61a57c02021-01-10 21:35:12 -0800927 (FormatHasDepth(image_format) == false)) {
sfricke-samsung8f658d42020-05-03 20:12:24 -0700928 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-01533",
929 "vkCreateImage(): if flags contain VK_IMAGE_CREATE_SAMPLE_LOCATIONS_COMPATIBLE_DEPTH_BIT_EXT the "
sfricke-samsung61a57c02021-01-10 21:35:12 -0800930 "format (%s) must be a depth or depth/stencil format.",
931 string_VkFormat(image_format));
sfricke-samsung8f658d42020-05-03 20:12:24 -0700932 }
933
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700934 const auto image_stencil_struct = LvlFindInChain<VkImageStencilUsageCreateInfo>(pCreateInfo->pNext);
Andrew Fobel3abeb992020-01-20 16:33:22 -0500935 if (image_stencil_struct != nullptr) {
936 if ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT) != 0) {
937 VkImageUsageFlags legal_flags = (VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT | VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT);
938 // No flags other than the legal attachment bits may be set
939 legal_flags |= VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT;
940 if ((image_stencil_struct->stencilUsage & ~legal_flags) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700941 skip |= LogError(device, "VUID-VkImageStencilUsageCreateInfo-stencilUsage-02539",
942 "vkCreateImage(): in pNext chain, VkImageStencilUsageCreateInfo::stencilUsage includes "
943 "VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT, it must not include bits other than "
944 "VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT or VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT");
Andrew Fobel3abeb992020-01-20 16:33:22 -0500945 }
946 }
947
sfricke-samsung61a57c02021-01-10 21:35:12 -0800948 if (FormatIsDepthOrStencil(image_format)) {
Andrew Fobel3abeb992020-01-20 16:33:22 -0500949 if ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT) != 0) {
950 if (pCreateInfo->extent.width > device_limits.maxFramebufferWidth) {
sfricke-samsungf3a9b5b2021-01-13 13:05:52 -0800951 skip |= LogError(
952 device, "VUID-VkImageCreateInfo-Format-02536",
953 "vkCreateImage(): Depth-stencil image contains VkImageStencilUsageCreateInfo structure with "
954 "stencilUsage including VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT and image width (%u) exceeds device "
955 "maxFramebufferWidth (%u)",
956 pCreateInfo->extent.width, device_limits.maxFramebufferWidth);
Andrew Fobel3abeb992020-01-20 16:33:22 -0500957 }
958
959 if (pCreateInfo->extent.height > device_limits.maxFramebufferHeight) {
sfricke-samsungf3a9b5b2021-01-13 13:05:52 -0800960 skip |= LogError(
961 device, "VUID-VkImageCreateInfo-format-02537",
962 "vkCreateImage(): Depth-stencil image contains VkImageStencilUsageCreateInfo structure with "
963 "stencilUsage including VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT and image height (%u) exceeds device "
964 "maxFramebufferHeight (%u)",
965 pCreateInfo->extent.height, device_limits.maxFramebufferHeight);
Andrew Fobel3abeb992020-01-20 16:33:22 -0500966 }
967 }
968
969 if (!physical_device_features.shaderStorageImageMultisample &&
970 ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_STORAGE_BIT) != 0) &&
971 (pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT)) {
972 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700973 LogError(device, "VUID-VkImageCreateInfo-format-02538",
974 "vkCreateImage(): Depth-stencil image contains VkImageStencilUsageCreateInfo structure with "
975 "stencilUsage including VK_IMAGE_USAGE_STORAGE_BIT and the multisampled storage images feature is "
976 "not enabled, image samples must be VK_SAMPLE_COUNT_1_BIT");
Andrew Fobel3abeb992020-01-20 16:33:22 -0500977 }
978
979 if (((pCreateInfo->usage & VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT) != 0) &&
980 ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT) == 0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700981 skip |= LogError(
982 device, "VUID-VkImageCreateInfo-format-02795",
Andrew Fobel3abeb992020-01-20 16:33:22 -0500983 "vkCreateImage(): Depth-stencil image in which usage includes VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT "
984 "contains VkImageStencilUsageCreateInfo structure, VkImageStencilUsageCreateInfo::stencilUsage must "
985 "also include VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT");
986 } else if (((pCreateInfo->usage & VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT) == 0) &&
987 ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT) != 0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700988 skip |= LogError(
989 device, "VUID-VkImageCreateInfo-format-02796",
Andrew Fobel3abeb992020-01-20 16:33:22 -0500990 "vkCreateImage(): Depth-stencil image in which usage does not include "
991 "VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT "
992 "contains VkImageStencilUsageCreateInfo structure, VkImageStencilUsageCreateInfo::stencilUsage must "
993 "also not include VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT");
994 }
995
996 if (((pCreateInfo->usage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT) != 0) &&
997 ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT) == 0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700998 skip |= LogError(
999 device, "VUID-VkImageCreateInfo-format-02797",
Andrew Fobel3abeb992020-01-20 16:33:22 -05001000 "vkCreateImage(): Depth-stencil image in which usage includes VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT "
1001 "contains VkImageStencilUsageCreateInfo structure, VkImageStencilUsageCreateInfo::stencilUsage must "
1002 "also include VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT");
1003 } else if (((pCreateInfo->usage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT) == 0) &&
1004 ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT) != 0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001005 skip |= LogError(
1006 device, "VUID-VkImageCreateInfo-format-02798",
Andrew Fobel3abeb992020-01-20 16:33:22 -05001007 "vkCreateImage(): Depth-stencil image in which usage does not include "
1008 "VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT "
1009 "contains VkImageStencilUsageCreateInfo structure, VkImageStencilUsageCreateInfo::stencilUsage must "
1010 "also not include VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT");
1011 }
1012 }
1013 }
Spencer Frickeca52b5c2020-03-16 17:34:00 -07001014
1015 if ((!physical_device_features.shaderStorageImageMultisample) && ((pCreateInfo->usage & VK_IMAGE_USAGE_STORAGE_BIT) != 0) &&
1016 (pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT)) {
1017 skip |= LogError(device, "VUID-VkImageCreateInfo-usage-00968",
1018 "vkCreateImage(): usage contains VK_IMAGE_USAGE_STORAGE_BIT and the multisampled storage images "
1019 "feature is not enabled, image samples must be VK_SAMPLE_COUNT_1_BIT");
1020 }
Spencer Fricke6f8b8ac2020-04-06 07:36:50 -07001021
Mark Lobodzinski09b4caa2020-11-20 17:26:46 -07001022 std::vector<uint64_t> image_create_drm_format_modifiers;
Spencer Fricke6f8b8ac2020-04-06 07:36:50 -07001023 if (device_extensions.vk_ext_image_drm_format_modifier) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07001024 const auto drm_format_mod_list = LvlFindInChain<VkImageDrmFormatModifierListCreateInfoEXT>(pCreateInfo->pNext);
1025 const auto drm_format_mod_explict = LvlFindInChain<VkImageDrmFormatModifierExplicitCreateInfoEXT>(pCreateInfo->pNext);
Spencer Fricke6f8b8ac2020-04-06 07:36:50 -07001026 if (pCreateInfo->tiling == VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT) {
1027 if (((drm_format_mod_list != nullptr) && (drm_format_mod_explict != nullptr)) ||
1028 ((drm_format_mod_list == nullptr) && (drm_format_mod_explict == nullptr))) {
1029 skip |= LogError(device, "VUID-VkImageCreateInfo-tiling-02261",
1030 "vkCreateImage(): Tiling is VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT but pNext must have "
1031 "either VkImageDrmFormatModifierListCreateInfoEXT or "
1032 "VkImageDrmFormatModifierExplicitCreateInfoEXT in the pNext chain");
Mark Lobodzinski09b4caa2020-11-20 17:26:46 -07001033 } else if (drm_format_mod_list != nullptr) {
1034 image_create_drm_format_modifiers.push_back(drm_format_mod_explict->drmFormatModifier);
1035 } else if (drm_format_mod_list != nullptr) {
1036 for (uint32_t i = 0; i < drm_format_mod_list->drmFormatModifierCount; i++) {
1037 image_create_drm_format_modifiers.push_back(*drm_format_mod_list->pDrmFormatModifiers);
1038 }
Spencer Fricke6f8b8ac2020-04-06 07:36:50 -07001039 }
1040 } else if ((drm_format_mod_list != nullptr) || (drm_format_mod_explict != nullptr)) {
1041 skip |= LogError(device, "VUID-VkImageCreateInfo-pNext-02262",
1042 "vkCreateImage(): Tiling is not VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT but there is a "
1043 "VkImageDrmFormatModifierListCreateInfoEXT or VkImageDrmFormatModifierExplicitCreateInfoEXT "
1044 "in the pNext chain");
1045 }
1046 }
janharaldfredriksen-arm3b793772020-05-12 18:55:53 +02001047
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001048 static const uint64_t drm_format_mod_linear = 0;
Mark Lobodzinski09b4caa2020-11-20 17:26:46 -07001049 bool image_create_maybe_linear = false;
1050 if (pCreateInfo->tiling == VK_IMAGE_TILING_LINEAR) {
1051 image_create_maybe_linear = true;
1052 } else if (pCreateInfo->tiling == VK_IMAGE_TILING_OPTIMAL) {
1053 image_create_maybe_linear = false;
1054 } else if (pCreateInfo->tiling == VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT) {
1055 image_create_maybe_linear =
1056 (std::find(image_create_drm_format_modifiers.begin(), image_create_drm_format_modifiers.end(),
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001057 drm_format_mod_linear) != image_create_drm_format_modifiers.end());
Mark Lobodzinski09b4caa2020-11-20 17:26:46 -07001058 }
1059
1060 // If multi-sample, validate type, usage, tiling and mip levels.
1061 if ((pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT) &&
1062 ((pCreateInfo->imageType != VK_IMAGE_TYPE_2D) || (pCreateInfo->flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) ||
1063 (pCreateInfo->mipLevels != 1) || image_create_maybe_linear)) {
1064 skip |= LogError(device, "VUID-VkImageCreateInfo-samples-02257",
1065 "vkCreateImage(): Multi-sample image with incompatible type, usage, tiling, or mips.");
1066 }
1067
1068 if ((pCreateInfo->flags & VK_IMAGE_CREATE_SPLIT_INSTANCE_BIND_REGIONS_BIT) &&
1069 ((pCreateInfo->mipLevels != 1) || (pCreateInfo->arrayLayers != 1) || (pCreateInfo->imageType != VK_IMAGE_TYPE_2D) ||
1070 image_create_maybe_linear)) {
1071 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02259",
1072 "vkCreateImage(): Multi-device image with incompatible type, usage, tiling, or mips.");
1073 }
1074
janharaldfredriksen-arm3b793772020-05-12 18:55:53 +02001075 if (pCreateInfo->usage & VK_IMAGE_USAGE_FRAGMENT_DENSITY_MAP_BIT_EXT) {
1076 if (pCreateInfo->imageType != VK_IMAGE_TYPE_2D) {
1077 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02557",
1078 "vkCreateImage: if usage includes VK_IMAGE_USAGE_FRAGMENT_DENSITY_MAP_BIT_EXT, "
1079 "imageType must be VK_IMAGE_TYPE_2D.");
1080 }
1081 if (pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT) {
1082 skip |= LogError(device, "VUID-VkImageCreateInfo-samples-02558",
1083 "vkCreateImage: if usage includes VK_IMAGE_USAGE_FRAGMENT_DENSITY_MAP_BIT_EXT, "
1084 "samples must be VK_SAMPLE_COUNT_1_BIT.");
1085 }
janharaldfredriksen-arm3b793772020-05-12 18:55:53 +02001086 }
1087 if (pCreateInfo->flags & VK_IMAGE_CREATE_SUBSAMPLED_BIT_EXT) {
1088 if (pCreateInfo->tiling != VK_IMAGE_TILING_OPTIMAL) {
1089 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02565",
1090 "vkCreateImage: if usage includes VK_IMAGE_CREATE_SUBSAMPLED_BIT_EXT, "
1091 "tiling must be VK_IMAGE_TILING_OPTIMAL.");
1092 }
1093 if (pCreateInfo->imageType != VK_IMAGE_TYPE_2D) {
1094 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02566",
1095 "vkCreateImage: if flags includes VK_IMAGE_CREATE_SUBSAMPLED_BIT_EXT, "
1096 "imageType must be VK_IMAGE_TYPE_2D.");
1097 }
1098 if (pCreateInfo->flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) {
1099 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02567",
1100 "vkCreateImage: if flags includes VK_IMAGE_CREATE_SUBSAMPLED_BIT_EXT, "
1101 "flags must not include VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT.");
1102 }
1103 if (pCreateInfo->mipLevels != 1) {
1104 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02568",
1105 "vkCreateImage: if flags includes VK_IMAGE_CREATE_SUBSAMPLED_BIT_EXT, mipLevels (%d) must be 1.",
1106 pCreateInfo->mipLevels);
1107 }
1108 }
sfricke-samsungddaf72b2020-06-23 21:39:28 -07001109
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07001110 const auto swapchain_create_info = LvlFindInChain<VkImageSwapchainCreateInfoKHR>(pCreateInfo->pNext);
sfricke-samsungddaf72b2020-06-23 21:39:28 -07001111 if (swapchain_create_info != nullptr) {
1112 if (swapchain_create_info->swapchain != VK_NULL_HANDLE) {
1113 // All the following fall under the same VU that checks that the swapchain image uses parameters limited by the
1114 // table in #swapchain-wsi-image-create-info. Breaking up into multiple checks allows for more useful information
1115 // returned why this error occured. Check for matching Swapchain flags is done later in state tracking validation
1116 const char *vuid = "VUID-VkImageSwapchainCreateInfoKHR-swapchain-00995";
1117 const char *base_message = "vkCreateImage(): The image used for creating a presentable swapchain image";
1118
1119 if (pCreateInfo->imageType != VK_IMAGE_TYPE_2D) {
1120 // also implicitly forces the check above that extent.depth is 1
1121 skip |= LogError(device, vuid, "%s must have a imageType value VK_IMAGE_TYPE_2D instead of %s.", base_message,
1122 string_VkImageType(pCreateInfo->imageType));
1123 }
1124 if (pCreateInfo->mipLevels != 1) {
1125 skip |= LogError(device, vuid, "%s must have a mipLevels value of 1 instead of %u.", base_message,
1126 pCreateInfo->mipLevels);
1127 }
1128 if (pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT) {
1129 skip |= LogError(device, vuid, "%s must have a samples value of VK_SAMPLE_COUNT_1_BIT instead of %s.",
1130 base_message, string_VkSampleCountFlagBits(pCreateInfo->samples));
1131 }
1132 if (pCreateInfo->tiling != VK_IMAGE_TILING_OPTIMAL) {
1133 skip |= LogError(device, vuid, "%s must have a tiling value of VK_IMAGE_TILING_OPTIMAL instead of %s.",
1134 base_message, string_VkImageTiling(pCreateInfo->tiling));
1135 }
1136 if (pCreateInfo->initialLayout != VK_IMAGE_LAYOUT_UNDEFINED) {
1137 skip |= LogError(device, vuid, "%s must have a initialLayout value of VK_IMAGE_LAYOUT_UNDEFINED instead of %s.",
1138 base_message, string_VkImageLayout(pCreateInfo->initialLayout));
1139 }
1140 const VkImageCreateFlags valid_flags =
1141 (VK_IMAGE_CREATE_SPLIT_INSTANCE_BIND_REGIONS_BIT | VK_IMAGE_CREATE_PROTECTED_BIT |
Mike Schuchardt2df08912020-12-15 16:28:09 -08001142 VK_IMAGE_CREATE_MUTABLE_FORMAT_BIT | VK_IMAGE_CREATE_EXTENDED_USAGE_BIT);
sfricke-samsungddaf72b2020-06-23 21:39:28 -07001143 if ((pCreateInfo->flags & ~valid_flags) != 0) {
1144 skip |= LogError(device, vuid, "%s flags are %" PRIu32 "and must only have valid flags set.", base_message,
1145 pCreateInfo->flags);
1146 }
1147 }
1148 }
sfricke-samsung61a57c02021-01-10 21:35:12 -08001149
1150 // If Chroma subsampled format ( _420_ or _422_ )
1151 if (FormatIsXChromaSubsampled(image_format) && (SafeModulo(pCreateInfo->extent.width, 2) != 0)) {
1152 skip |=
1153 LogError(device, "VUID-VkImageCreateInfo-format-04712",
1154 "vkCreateImage(): The format (%s) is X Chroma Subsampled (has _422 or _420 suffix) so the width (=%" PRIu32
1155 ") must be a multiple of 2.",
1156 string_VkFormat(image_format), pCreateInfo->extent.width);
1157 }
1158 if (FormatIsYChromaSubsampled(image_format) && (SafeModulo(pCreateInfo->extent.height, 2) != 0)) {
1159 skip |= LogError(device, "VUID-VkImageCreateInfo-format-04713",
1160 "vkCreateImage(): The format (%s) is Y Chroma Subsampled (has _420 suffix) so the height (=%" PRIu32
1161 ") must be a multiple of 2.",
1162 string_VkFormat(image_format), pCreateInfo->extent.height);
1163 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001164 }
Jeff Bolzef40fec2018-09-01 22:04:34 -05001165
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001166 return skip;
1167}
1168
Jeff Bolz99e3f632020-03-24 22:59:22 -05001169bool StatelessValidation::manual_PreCallValidateCreateImageView(VkDevice device, const VkImageViewCreateInfo *pCreateInfo,
1170 const VkAllocationCallbacks *pAllocator, VkImageView *pView) const {
1171 bool skip = false;
1172
1173 if (pCreateInfo != nullptr) {
Spencer Fricke528e0982020-04-19 18:46:01 -07001174 // Validate feature set if using CUBE_ARRAY
1175 if ((pCreateInfo->viewType == VK_IMAGE_VIEW_TYPE_CUBE_ARRAY) && (physical_device_features.imageCubeArray == false)) {
1176 skip |= LogError(pCreateInfo->image, "VUID-VkImageViewCreateInfo-viewType-01004",
1177 "vkCreateImageView(): pCreateInfo->viewType can't be VK_IMAGE_VIEW_TYPE_CUBE_ARRAY without "
1178 "enabling the imageCubeArray feature.");
1179 }
1180
Jeff Bolz99e3f632020-03-24 22:59:22 -05001181 if (pCreateInfo->subresourceRange.layerCount != VK_REMAINING_ARRAY_LAYERS) {
1182 if (pCreateInfo->viewType == VK_IMAGE_VIEW_TYPE_CUBE && pCreateInfo->subresourceRange.layerCount != 6) {
1183 skip |= LogError(device, "VUID-VkImageViewCreateInfo-viewType-02960",
Spencer Fricke528e0982020-04-19 18:46:01 -07001184 "vkCreateImageView(): subresourceRange.layerCount (%d) must be 6 or VK_REMAINING_ARRAY_LAYERS.",
Jeff Bolz99e3f632020-03-24 22:59:22 -05001185 pCreateInfo->subresourceRange.layerCount);
1186 }
1187 if (pCreateInfo->viewType == VK_IMAGE_VIEW_TYPE_CUBE_ARRAY && (pCreateInfo->subresourceRange.layerCount % 6) != 0) {
Spencer Fricke528e0982020-04-19 18:46:01 -07001188 skip |= LogError(
1189 device, "VUID-VkImageViewCreateInfo-viewType-02961",
1190 "vkCreateImageView(): subresourceRange.layerCount (%d) must be a multiple of 6 or VK_REMAINING_ARRAY_LAYERS.",
1191 pCreateInfo->subresourceRange.layerCount);
Jeff Bolz99e3f632020-03-24 22:59:22 -05001192 }
1193 }
sfricke-samsung0c4a06f2020-06-27 01:24:32 -07001194
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07001195 auto astc_decode_mode = LvlFindInChain<VkImageViewASTCDecodeModeEXT>(pCreateInfo->pNext);
sfricke-samsung0c4a06f2020-06-27 01:24:32 -07001196 if ((device_extensions.vk_ext_astc_decode_mode) && (astc_decode_mode != nullptr)) {
1197 if ((astc_decode_mode->decodeMode != VK_FORMAT_R16G16B16A16_SFLOAT) &&
1198 (astc_decode_mode->decodeMode != VK_FORMAT_R8G8B8A8_UNORM) &&
1199 (astc_decode_mode->decodeMode != VK_FORMAT_E5B9G9R9_UFLOAT_PACK32)) {
1200 skip |= LogError(device, "VUID-VkImageViewASTCDecodeModeEXT-decodeMode-02230",
1201 "vkCreateImageView(): VkImageViewASTCDecodeModeEXT::decodeMode must be "
1202 "VK_FORMAT_R16G16B16A16_SFLOAT, VK_FORMAT_R8G8B8A8_UNORM, or VK_FORMAT_E5B9G9R9_UFLOAT_PACK32.");
1203 }
1204 if (FormatIsCompressed_ASTC(pCreateInfo->format) == false) {
1205 skip |= LogError(device, "VUID-VkImageViewASTCDecodeModeEXT-format-04084",
1206 "vkCreateImageView(): is using a VkImageViewASTCDecodeModeEXT but the image view format is %s and "
1207 "not an ASTC format.",
1208 string_VkFormat(pCreateInfo->format));
1209 }
1210 }
sfricke-samsung83d98122020-07-04 06:21:15 -07001211
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07001212 auto ycbcr_conversion = LvlFindInChain<VkSamplerYcbcrConversionInfo>(pCreateInfo->pNext);
sfricke-samsung83d98122020-07-04 06:21:15 -07001213 if (ycbcr_conversion != nullptr) {
1214 if (ycbcr_conversion->conversion != VK_NULL_HANDLE) {
1215 if (IsIdentitySwizzle(pCreateInfo->components) == false) {
1216 skip |= LogError(
1217 device, "VUID-VkImageViewCreateInfo-pNext-01970",
1218 "vkCreateImageView(): If there is a VkSamplerYcbcrConversion, the imageView must "
1219 "be created with the identity swizzle. Here are the actual swizzle values:\n"
1220 "r swizzle = %s\n"
1221 "g swizzle = %s\n"
1222 "b swizzle = %s\n"
1223 "a swizzle = %s\n",
1224 string_VkComponentSwizzle(pCreateInfo->components.r), string_VkComponentSwizzle(pCreateInfo->components.g),
1225 string_VkComponentSwizzle(pCreateInfo->components.b), string_VkComponentSwizzle(pCreateInfo->components.a));
1226 }
1227 }
1228 }
Jeff Bolz99e3f632020-03-24 22:59:22 -05001229 }
1230 return skip;
1231}
1232
Jeff Bolz6d3beaa2019-02-09 21:00:05 -06001233bool StatelessValidation::manual_PreCallValidateViewport(const VkViewport &viewport, const char *fn_name,
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001234 const ParameterName &parameter_name, VkCommandBuffer object) const {
Petr Krausb3fcdb42018-01-09 22:09:09 +01001235 bool skip = false;
Petr Krausb3fcdb42018-01-09 22:09:09 +01001236
1237 // Note: for numerical correctness
1238 // - float comparisons should expect NaN (comparison always false).
1239 // - VkPhysicalDeviceLimits::maxViewportDimensions is uint32_t, not float -> careful.
1240
1241 const auto f_lte_u32_exact = [](const float v1_f, const uint32_t v2_u32) {
John Zulaufac0876c2018-02-19 10:09:35 -07001242 if (std::isnan(v1_f)) return false;
Petr Krausb3fcdb42018-01-09 22:09:09 +01001243 if (v1_f <= 0.0f) return true;
1244
1245 float intpart;
1246 const float fract = modff(v1_f, &intpart);
1247
1248 assert(std::numeric_limits<float>::radix == 2);
1249 const float u32_max_plus1 = ldexpf(1.0f, 32); // hopefully exact
1250 if (intpart >= u32_max_plus1) return false;
1251
1252 uint32_t v1_u32 = static_cast<uint32_t>(intpart);
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001253 if (v1_u32 < v2_u32) {
Petr Krausb3fcdb42018-01-09 22:09:09 +01001254 return true;
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001255 } else if (v1_u32 == v2_u32 && fract == 0.0f) {
Petr Krausb3fcdb42018-01-09 22:09:09 +01001256 return true;
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001257 } else {
Petr Krausb3fcdb42018-01-09 22:09:09 +01001258 return false;
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001259 }
Petr Krausb3fcdb42018-01-09 22:09:09 +01001260 };
1261
1262 const auto f_lte_u32_direct = [](const float v1_f, const uint32_t v2_u32) {
1263 const float v2_f = static_cast<float>(v2_u32); // not accurate for > radix^digits; and undefined rounding mode
1264 return (v1_f <= v2_f);
1265 };
1266
1267 // width
1268 bool width_healthy = true;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001269 const auto max_w = device_limits.maxViewportDimensions[0];
Petr Krausb3fcdb42018-01-09 22:09:09 +01001270
1271 if (!(viewport.width > 0.0f)) {
1272 width_healthy = false;
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001273 skip |= LogError(object, "VUID-VkViewport-width-01770", "%s: %s.width (=%f) is not greater than 0.0.", fn_name,
1274 parameter_name.get_name().c_str(), viewport.width);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001275 } else if (!(f_lte_u32_exact(viewport.width, max_w) || f_lte_u32_direct(viewport.width, max_w))) {
1276 width_healthy = false;
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001277 skip |= LogError(object, "VUID-VkViewport-width-01771",
1278 "%s: %s.width (=%f) exceeds VkPhysicalDeviceLimits::maxViewportDimensions[0] (=%" PRIu32 ").", fn_name,
1279 parameter_name.get_name().c_str(), viewport.width, max_w);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001280 }
1281
1282 // height
1283 bool height_healthy = true;
Mark Lobodzinskia09ab942020-02-20 11:01:59 -07001284 const bool negative_height_enabled = device_extensions.vk_khr_maintenance1 || device_extensions.vk_amd_negative_viewport_height;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001285 const auto max_h = device_limits.maxViewportDimensions[1];
Petr Krausb3fcdb42018-01-09 22:09:09 +01001286
1287 if (!negative_height_enabled && !(viewport.height > 0.0f)) {
1288 height_healthy = false;
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001289 skip |= LogError(object, "VUID-VkViewport-height-01772", "%s: %s.height (=%f) is not greater 0.0.", fn_name,
1290 parameter_name.get_name().c_str(), viewport.height);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001291 } else if (!(f_lte_u32_exact(fabsf(viewport.height), max_h) || f_lte_u32_direct(fabsf(viewport.height), max_h))) {
1292 height_healthy = false;
1293
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001294 skip |= LogError(object, "VUID-VkViewport-height-01773",
1295 "%s: Absolute value of %s.height (=%f) exceeds VkPhysicalDeviceLimits::maxViewportDimensions[1] (=%" PRIu32
1296 ").",
1297 fn_name, parameter_name.get_name().c_str(), viewport.height, max_h);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001298 }
1299
1300 // x
1301 bool x_healthy = true;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001302 if (!(viewport.x >= device_limits.viewportBoundsRange[0])) {
Petr Krausb3fcdb42018-01-09 22:09:09 +01001303 x_healthy = false;
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001304 skip |= LogError(object, "VUID-VkViewport-x-01774",
1305 "%s: %s.x (=%f) is less than VkPhysicalDeviceLimits::viewportBoundsRange[0] (=%f).", fn_name,
1306 parameter_name.get_name().c_str(), viewport.x, device_limits.viewportBoundsRange[0]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001307 }
1308
1309 // x + width
1310 if (x_healthy && width_healthy) {
1311 const float right_bound = viewport.x + viewport.width;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001312 if (!(right_bound <= device_limits.viewportBoundsRange[1])) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001313 skip |= LogError(
1314 object, "VUID-VkViewport-x-01232",
1315 "%s: %s.x + %s.width (=%f + %f = %f) is greater than VkPhysicalDeviceLimits::viewportBoundsRange[1] (=%f).",
1316 fn_name, parameter_name.get_name().c_str(), parameter_name.get_name().c_str(), viewport.x, viewport.width,
1317 right_bound, device_limits.viewportBoundsRange[1]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001318 }
1319 }
1320
1321 // y
1322 bool y_healthy = true;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001323 if (!(viewport.y >= device_limits.viewportBoundsRange[0])) {
Petr Krausb3fcdb42018-01-09 22:09:09 +01001324 y_healthy = false;
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001325 skip |= LogError(object, "VUID-VkViewport-y-01775",
1326 "%s: %s.y (=%f) is less than VkPhysicalDeviceLimits::viewportBoundsRange[0] (=%f).", fn_name,
1327 parameter_name.get_name().c_str(), viewport.y, device_limits.viewportBoundsRange[0]);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001328 } else if (negative_height_enabled && !(viewport.y <= device_limits.viewportBoundsRange[1])) {
Petr Krausb3fcdb42018-01-09 22:09:09 +01001329 y_healthy = false;
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001330 skip |= LogError(object, "VUID-VkViewport-y-01776",
1331 "%s: %s.y (=%f) exceeds VkPhysicalDeviceLimits::viewportBoundsRange[1] (=%f).", fn_name,
1332 parameter_name.get_name().c_str(), viewport.y, device_limits.viewportBoundsRange[1]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001333 }
1334
1335 // y + height
1336 if (y_healthy && height_healthy) {
1337 const float boundary = viewport.y + viewport.height;
1338
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001339 if (!(boundary <= device_limits.viewportBoundsRange[1])) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001340 skip |= LogError(object, "VUID-VkViewport-y-01233",
1341 "%s: %s.y + %s.height (=%f + %f = %f) exceeds VkPhysicalDeviceLimits::viewportBoundsRange[1] (=%f).",
1342 fn_name, parameter_name.get_name().c_str(), parameter_name.get_name().c_str(), viewport.y,
1343 viewport.height, boundary, device_limits.viewportBoundsRange[1]);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001344 } else if (negative_height_enabled && !(boundary >= device_limits.viewportBoundsRange[0])) {
Jeff Bolz6d3beaa2019-02-09 21:00:05 -06001345 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001346 LogError(object, "VUID-VkViewport-y-01777",
1347 "%s: %s.y + %s.height (=%f + %f = %f) is less than VkPhysicalDeviceLimits::viewportBoundsRange[0] (=%f).",
1348 fn_name, parameter_name.get_name().c_str(), parameter_name.get_name().c_str(), viewport.y, viewport.height,
1349 boundary, device_limits.viewportBoundsRange[0]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001350 }
1351 }
1352
sfricke-samsungfd06d422021-01-22 02:17:21 -08001353 // The extension was not created with a feature bit whichs prevents displaying the 2 variations of the VUIDs
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001354 if (!device_extensions.vk_ext_depth_range_unrestricted) {
Petr Krausb3fcdb42018-01-09 22:09:09 +01001355 // minDepth
1356 if (!(viewport.minDepth >= 0.0) || !(viewport.minDepth <= 1.0)) {
sfricke-samsungfd06d422021-01-22 02:17:21 -08001357 // Also VUID-VkViewport-minDepth-02540
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001358 skip |= LogError(object, "VUID-VkViewport-minDepth-01234",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001359 "%s: VK_EXT_depth_range_unrestricted extension is not enabled and %s.minDepth (=%f) is not within the "
1360 "[0.0, 1.0] range.",
1361 fn_name, parameter_name.get_name().c_str(), viewport.minDepth);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001362 }
1363
1364 // maxDepth
1365 if (!(viewport.maxDepth >= 0.0) || !(viewport.maxDepth <= 1.0)) {
sfricke-samsungfd06d422021-01-22 02:17:21 -08001366 // Also VUID-VkViewport-maxDepth-02541
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001367 skip |= LogError(object, "VUID-VkViewport-maxDepth-01235",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001368 "%s: VK_EXT_depth_range_unrestricted extension is not enabled and %s.maxDepth (=%f) is not within the "
1369 "[0.0, 1.0] range.",
1370 fn_name, parameter_name.get_name().c_str(), viewport.maxDepth);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001371 }
1372 }
1373
1374 return skip;
1375}
1376
Dave Houlton142c4cb2018-10-17 15:04:41 -06001377struct SampleOrderInfo {
Jeff Bolz9af91c52018-09-01 21:53:57 -05001378 VkShadingRatePaletteEntryNV shadingRate;
1379 uint32_t width;
1380 uint32_t height;
1381};
1382
1383// All palette entries with more than one pixel per fragment
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001384static SampleOrderInfo sample_order_infos[] = {
Dave Houlton142c4cb2018-10-17 15:04:41 -06001385 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_1X2_PIXELS_NV, 1, 2},
1386 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_2X1_PIXELS_NV, 2, 1},
1387 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_2X2_PIXELS_NV, 2, 2},
1388 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_4X2_PIXELS_NV, 4, 2},
1389 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_2X4_PIXELS_NV, 2, 4},
1390 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_4X4_PIXELS_NV, 4, 4},
Jeff Bolz9af91c52018-09-01 21:53:57 -05001391};
1392
Jeff Bolz46c0ea02019-10-09 13:06:29 -05001393bool StatelessValidation::ValidateCoarseSampleOrderCustomNV(const VkCoarseSampleOrderCustomNV *order) const {
Jeff Bolz9af91c52018-09-01 21:53:57 -05001394 bool skip = false;
Jeff Bolz9af91c52018-09-01 21:53:57 -05001395
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001396 SampleOrderInfo *sample_order_info;
1397 uint32_t info_idx = 0;
1398 for (sample_order_info = nullptr; info_idx < ARRAY_SIZE(sample_order_infos); ++info_idx) {
1399 if (sample_order_infos[info_idx].shadingRate == order->shadingRate) {
1400 sample_order_info = &sample_order_infos[info_idx];
Jeff Bolz9af91c52018-09-01 21:53:57 -05001401 break;
1402 }
1403 }
1404
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001405 if (sample_order_info == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001406 skip |= LogError(device, "VUID-VkCoarseSampleOrderCustomNV-shadingRate-02073",
1407 "VkCoarseSampleOrderCustomNV shadingRate must be a shading rate "
1408 "that generates fragments with more than one pixel.");
Jeff Bolz9af91c52018-09-01 21:53:57 -05001409 return skip;
1410 }
1411
Dave Houlton142c4cb2018-10-17 15:04:41 -06001412 if (order->sampleCount == 0 || (order->sampleCount & (order->sampleCount - 1)) ||
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001413 !(order->sampleCount & device_limits.framebufferNoAttachmentsSampleCounts)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001414 skip |= LogError(device, "VUID-VkCoarseSampleOrderCustomNV-sampleCount-02074",
1415 "VkCoarseSampleOrderCustomNV sampleCount (=%" PRIu32
1416 ") must "
1417 "correspond to a sample count enumerated in VkSampleCountFlags whose corresponding bit "
1418 "is set in framebufferNoAttachmentsSampleCounts.",
1419 order->sampleCount);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001420 }
1421
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001422 if (order->sampleLocationCount != order->sampleCount * sample_order_info->width * sample_order_info->height) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001423 skip |= LogError(device, "VUID-VkCoarseSampleOrderCustomNV-sampleLocationCount-02075",
1424 "VkCoarseSampleOrderCustomNV sampleLocationCount (=%" PRIu32
1425 ") must "
1426 "be equal to the product of sampleCount (=%" PRIu32
1427 "), the fragment width for shadingRate "
1428 "(=%" PRIu32 "), and the fragment height for shadingRate (=%" PRIu32 ").",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001429 order->sampleLocationCount, order->sampleCount, sample_order_info->width, sample_order_info->height);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001430 }
1431
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001432 if (order->sampleLocationCount > phys_dev_ext_props.shading_rate_image_props.shadingRateMaxCoarseSamples) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001433 skip |= LogError(
1434 device, "VUID-VkCoarseSampleOrderCustomNV-sampleLocationCount-02076",
Dave Houlton142c4cb2018-10-17 15:04:41 -06001435 "VkCoarseSampleOrderCustomNV sampleLocationCount (=%" PRIu32
1436 ") must "
1437 "be less than or equal to VkPhysicalDeviceShadingRateImagePropertiesNV shadingRateMaxCoarseSamples (=%" PRIu32 ").",
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001438 order->sampleLocationCount, phys_dev_ext_props.shading_rate_image_props.shadingRateMaxCoarseSamples);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001439 }
Jeff Bolz9af91c52018-09-01 21:53:57 -05001440
1441 // Accumulate a bitmask tracking which (x,y,sample) tuples are seen. Expect
Jeff Bolzb8a8dd02018-09-18 02:39:24 -05001442 // the first width*height*sampleCount bits to all be set. Note: There is no
1443 // guarantee that 64 bits is enough, but practically it's unlikely for an
1444 // implementation to support more than 32 bits for samplemask.
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001445 assert(phys_dev_ext_props.shading_rate_image_props.shadingRateMaxCoarseSamples <= 64);
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001446 uint64_t sample_locations_mask = 0;
Jeff Bolz9af91c52018-09-01 21:53:57 -05001447 for (uint32_t i = 0; i < order->sampleLocationCount; ++i) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001448 const VkCoarseSampleLocationNV *sample_loc = &order->pSampleLocations[i];
1449 if (sample_loc->pixelX >= sample_order_info->width) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001450 skip |= LogError(device, "VUID-VkCoarseSampleLocationNV-pixelX-02078",
1451 "pixelX must be less than the width (in pixels) of the fragment.");
Jeff Bolz9af91c52018-09-01 21:53:57 -05001452 }
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001453 if (sample_loc->pixelY >= sample_order_info->height) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001454 skip |= LogError(device, "VUID-VkCoarseSampleLocationNV-pixelY-02079",
1455 "pixelY must be less than the height (in pixels) of the fragment.");
Jeff Bolz9af91c52018-09-01 21:53:57 -05001456 }
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001457 if (sample_loc->sample >= order->sampleCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001458 skip |= LogError(device, "VUID-VkCoarseSampleLocationNV-sample-02080",
1459 "sample must be less than the number of coverage samples in each pixel belonging to the fragment.");
Jeff Bolz9af91c52018-09-01 21:53:57 -05001460 }
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001461 uint32_t idx =
1462 sample_loc->sample + order->sampleCount * (sample_loc->pixelX + sample_order_info->width * sample_loc->pixelY);
1463 sample_locations_mask |= 1ULL << idx;
Jeff Bolz9af91c52018-09-01 21:53:57 -05001464 }
1465
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001466 uint64_t expected_mask = (order->sampleLocationCount == 64) ? ~0ULL : ((1ULL << order->sampleLocationCount) - 1);
1467 if (sample_locations_mask != expected_mask) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001468 skip |= LogError(
1469 device, "VUID-VkCoarseSampleOrderCustomNV-pSampleLocations-02077",
Dave Houlton142c4cb2018-10-17 15:04:41 -06001470 "The array pSampleLocations must contain exactly one entry for "
1471 "every combination of valid values for pixelX, pixelY, and sample in the structure VkCoarseSampleOrderCustomNV.");
Jeff Bolz9af91c52018-09-01 21:53:57 -05001472 }
1473
1474 return skip;
1475}
1476
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07001477bool StatelessValidation::manual_PreCallValidateCreateGraphicsPipelines(VkDevice device, VkPipelineCache pipelineCache,
1478 uint32_t createInfoCount,
1479 const VkGraphicsPipelineCreateInfo *pCreateInfos,
1480 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05001481 VkPipeline *pPipelines) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001482 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001483
1484 if (pCreateInfos != nullptr) {
1485 for (uint32_t i = 0; i < createInfoCount; ++i) {
Petr Kraus299ba622017-11-24 03:09:03 +01001486 bool has_dynamic_viewport = false;
1487 bool has_dynamic_scissor = false;
1488 bool has_dynamic_line_width = false;
Spencer Fricke8d428882020-03-16 17:23:33 -07001489 bool has_dynamic_depth_bias = false;
1490 bool has_dynamic_blend_constant = false;
1491 bool has_dynamic_depth_bounds = false;
1492 bool has_dynamic_stencil_compare = false;
1493 bool has_dynamic_stencil_write = false;
1494 bool has_dynamic_stencil_reference = false;
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001495 bool has_dynamic_viewport_w_scaling_nv = false;
1496 bool has_dynamic_discard_rectangle_ext = false;
1497 bool has_dynamic_sample_locations_ext = false;
Jeff Bolz3e71f782018-08-29 23:15:45 -05001498 bool has_dynamic_exclusive_scissor_nv = false;
Jeff Bolz9af91c52018-09-01 21:53:57 -05001499 bool has_dynamic_shading_rate_palette_nv = false;
Spencer Fricke8d428882020-03-16 17:23:33 -07001500 bool has_dynamic_viewport_course_sample_order_nv = false;
Jeff Bolz8125a8b2019-08-16 16:29:45 -05001501 bool has_dynamic_line_stipple = false;
Piers Daniell39842ee2020-07-10 16:42:33 -06001502 bool has_dynamic_cull_mode = false;
1503 bool has_dynamic_front_face = false;
1504 bool has_dynamic_primitive_topology = false;
1505 bool has_dynamic_viewport_with_count = false;
1506 bool has_dynamic_scissor_with_count = false;
1507 bool has_dynamic_vertex_input_binding_stride = false;
1508 bool has_dynamic_depth_test_enable = false;
1509 bool has_dynamic_depth_write_enable = false;
1510 bool has_dynamic_depth_compare_op = false;
1511 bool has_dynamic_depth_bounds_test_enable = false;
1512 bool has_dynamic_stencil_test_enable = false;
1513 bool has_dynamic_stencil_op = false;
sourav parmarcd5fb182020-07-17 12:58:44 -07001514 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_SKIP_AABBS_BIT_KHR) {
1515 skip |=
1516 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-03377",
1517 "vkCreateGraphicsPipelines: flags must not include VK_PIPELINE_CREATE_RAY_TRACING_SKIP_AABBS_BIT_KHR");
1518 }
Petr Kraus299ba622017-11-24 03:09:03 +01001519 if (pCreateInfos[i].pDynamicState != nullptr) {
1520 const auto &dynamic_state_info = *pCreateInfos[i].pDynamicState;
1521 for (uint32_t state_index = 0; state_index < dynamic_state_info.dynamicStateCount; ++state_index) {
1522 const auto &dynamic_state = dynamic_state_info.pDynamicStates[state_index];
Spencer Fricke8d428882020-03-16 17:23:33 -07001523 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT) {
1524 if (has_dynamic_viewport == true) {
1525 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1526 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_VIEWPORT was listed twice in the "
1527 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1528 i);
1529 }
1530 has_dynamic_viewport = true;
1531 }
1532 if (dynamic_state == VK_DYNAMIC_STATE_SCISSOR) {
1533 if (has_dynamic_scissor == true) {
1534 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1535 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_SCISSOR was listed twice in the "
1536 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1537 i);
1538 }
1539 has_dynamic_scissor = true;
1540 }
1541 if (dynamic_state == VK_DYNAMIC_STATE_LINE_WIDTH) {
1542 if (has_dynamic_line_width == true) {
1543 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1544 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_LINE_WIDTH was listed twice in the "
1545 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1546 i);
1547 }
1548 has_dynamic_line_width = true;
1549 }
1550 if (dynamic_state == VK_DYNAMIC_STATE_DEPTH_BIAS) {
1551 if (has_dynamic_depth_bias == true) {
1552 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1553 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DEPTH_BIAS was listed twice in the "
1554 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1555 i);
1556 }
1557 has_dynamic_depth_bias = true;
1558 }
1559 if (dynamic_state == VK_DYNAMIC_STATE_BLEND_CONSTANTS) {
1560 if (has_dynamic_blend_constant == true) {
1561 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1562 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_BLEND_CONSTANTS was listed twice in the "
1563 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1564 i);
1565 }
1566 has_dynamic_blend_constant = true;
1567 }
1568 if (dynamic_state == VK_DYNAMIC_STATE_DEPTH_BOUNDS) {
1569 if (has_dynamic_depth_bounds == true) {
1570 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1571 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DEPTH_BOUNDS was listed twice in the "
1572 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1573 i);
1574 }
1575 has_dynamic_depth_bounds = true;
1576 }
1577 if (dynamic_state == VK_DYNAMIC_STATE_STENCIL_COMPARE_MASK) {
1578 if (has_dynamic_stencil_compare == true) {
1579 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1580 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_STENCIL_COMPARE_MASK was listed twice in "
1581 "the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1582 i);
1583 }
1584 has_dynamic_stencil_compare = true;
1585 }
1586 if (dynamic_state == VK_DYNAMIC_STATE_STENCIL_WRITE_MASK) {
1587 if (has_dynamic_stencil_write == true) {
1588 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1589 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_STENCIL_WRITE_MASK was listed twice in "
1590 "the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1591 i);
1592 }
1593 has_dynamic_stencil_write = true;
1594 }
1595 if (dynamic_state == VK_DYNAMIC_STATE_STENCIL_REFERENCE) {
1596 if (has_dynamic_stencil_reference == true) {
1597 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1598 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_STENCIL_REFERENCE was listed twice in "
1599 "the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1600 i);
1601 }
1602 has_dynamic_stencil_reference = true;
1603 }
1604 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT_W_SCALING_NV) {
1605 if (has_dynamic_viewport_w_scaling_nv == true) {
1606 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1607 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_VIEWPORT_W_SCALING_NV was listed twice "
1608 "in the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1609 i);
1610 }
1611 has_dynamic_viewport_w_scaling_nv = true;
1612 }
1613 if (dynamic_state == VK_DYNAMIC_STATE_DISCARD_RECTANGLE_EXT) {
1614 if (has_dynamic_discard_rectangle_ext == true) {
1615 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1616 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DISCARD_RECTANGLE_EXT was listed twice "
1617 "in the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1618 i);
1619 }
1620 has_dynamic_discard_rectangle_ext = true;
1621 }
1622 if (dynamic_state == VK_DYNAMIC_STATE_SAMPLE_LOCATIONS_EXT) {
1623 if (has_dynamic_sample_locations_ext == true) {
1624 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1625 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_SAMPLE_LOCATIONS_EXT was listed twice in "
1626 "the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1627 i);
1628 }
1629 has_dynamic_sample_locations_ext = true;
1630 }
1631 if (dynamic_state == VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV) {
1632 if (has_dynamic_exclusive_scissor_nv == true) {
1633 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1634 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV was listed twice in "
1635 "the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1636 i);
1637 }
1638 has_dynamic_exclusive_scissor_nv = true;
1639 }
1640 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT_SHADING_RATE_PALETTE_NV) {
1641 if (has_dynamic_shading_rate_palette_nv == true) {
1642 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1643 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_VIEWPORT_SHADING_RATE_PALETTE_NV was "
1644 "listed twice in the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1645 i);
1646 }
Dave Houlton142c4cb2018-10-17 15:04:41 -06001647 has_dynamic_shading_rate_palette_nv = true;
Spencer Fricke8d428882020-03-16 17:23:33 -07001648 }
1649 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT_COARSE_SAMPLE_ORDER_NV) {
1650 if (has_dynamic_viewport_course_sample_order_nv == true) {
1651 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1652 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_VIEWPORT_COARSE_SAMPLE_ORDER_NV was "
1653 "listed twice in the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1654 i);
1655 }
1656 has_dynamic_viewport_course_sample_order_nv = true;
1657 }
1658 if (dynamic_state == VK_DYNAMIC_STATE_LINE_STIPPLE_EXT) {
1659 if (has_dynamic_line_stipple == true) {
1660 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1661 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_LINE_STIPPLE_EXT was listed twice in the "
1662 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1663 i);
1664 }
1665 has_dynamic_line_stipple = true;
1666 }
Piers Daniell39842ee2020-07-10 16:42:33 -06001667 if (dynamic_state == VK_DYNAMIC_STATE_CULL_MODE_EXT) {
1668 if (has_dynamic_cull_mode) {
1669 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1670 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_CULL_MODE_EXT was listed twice in the "
1671 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1672 i);
1673 }
1674 has_dynamic_cull_mode = true;
1675 }
1676 if (dynamic_state == VK_DYNAMIC_STATE_FRONT_FACE_EXT) {
1677 if (has_dynamic_front_face) {
1678 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1679 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_FRONT_FACE_EXT was listed twice in the "
1680 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1681 i);
1682 }
1683 has_dynamic_front_face = true;
1684 }
1685 if (dynamic_state == VK_DYNAMIC_STATE_PRIMITIVE_TOPOLOGY_EXT) {
1686 if (has_dynamic_primitive_topology) {
1687 skip |= LogError(
1688 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1689 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_PRIMITIVE_TOPOLOGY_EXT was listed twice in the "
1690 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1691 i);
1692 }
1693 has_dynamic_primitive_topology = true;
1694 }
1695 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT_WITH_COUNT_EXT) {
1696 if (has_dynamic_viewport_with_count) {
1697 skip |= LogError(
1698 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1699 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_VIEWPORT_WITH_COUNT_EXT was listed twice in the "
1700 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1701 i);
1702 }
1703 has_dynamic_viewport_with_count = true;
1704 }
1705 if (dynamic_state == VK_DYNAMIC_STATE_SCISSOR_WITH_COUNT_EXT) {
1706 if (has_dynamic_scissor_with_count) {
1707 skip |= LogError(
1708 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1709 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_SCISSOR_WITH_COUNT_EXT was listed twice in the "
1710 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1711 i);
1712 }
1713 has_dynamic_scissor_with_count = true;
1714 }
1715 if (dynamic_state == VK_DYNAMIC_STATE_VERTEX_INPUT_BINDING_STRIDE_EXT) {
1716 if (has_dynamic_vertex_input_binding_stride) {
1717 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1718 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_VERTEX_INPUT_BINDING_STRIDE_EXT was "
1719 "listed twice in the "
1720 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1721 i);
1722 }
1723 has_dynamic_vertex_input_binding_stride = true;
1724 }
1725 if (dynamic_state == VK_DYNAMIC_STATE_DEPTH_TEST_ENABLE_EXT) {
1726 if (has_dynamic_depth_test_enable) {
1727 skip |= LogError(
1728 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1729 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DEPTH_TEST_ENABLE_EXT was listed twice in the "
1730 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1731 i);
1732 }
1733 has_dynamic_depth_test_enable = true;
1734 }
1735 if (dynamic_state == VK_DYNAMIC_STATE_DEPTH_WRITE_ENABLE_EXT) {
1736 if (has_dynamic_depth_write_enable) {
1737 skip |= LogError(
1738 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1739 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DEPTH_WRITE_ENABLE_EXT was listed twice in the "
1740 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1741 i);
1742 }
1743 has_dynamic_depth_write_enable = true;
1744 }
1745 if (dynamic_state == VK_DYNAMIC_STATE_DEPTH_COMPARE_OP_EXT) {
1746 if (has_dynamic_depth_compare_op) {
1747 skip |=
1748 LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1749 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DEPTH_COMPARE_OP_EXT was listed twice in the "
1750 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1751 i);
1752 }
1753 has_dynamic_depth_compare_op = true;
1754 }
1755 if (dynamic_state == VK_DYNAMIC_STATE_DEPTH_BOUNDS_TEST_ENABLE_EXT) {
1756 if (has_dynamic_depth_bounds_test_enable) {
1757 skip |= LogError(
1758 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1759 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DEPTH_BOUNDS_TEST_ENABLE_EXT was listed twice in the "
1760 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1761 i);
1762 }
1763 has_dynamic_depth_bounds_test_enable = true;
1764 }
1765 if (dynamic_state == VK_DYNAMIC_STATE_STENCIL_TEST_ENABLE_EXT) {
1766 if (has_dynamic_stencil_test_enable) {
1767 skip |= LogError(
1768 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1769 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_STENCIL_TEST_ENABLE_EXT was listed twice in the "
1770 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1771 i);
1772 }
1773 has_dynamic_stencil_test_enable = true;
1774 }
1775 if (dynamic_state == VK_DYNAMIC_STATE_STENCIL_OP_EXT) {
1776 if (has_dynamic_stencil_op) {
1777 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1778 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_STENCIL_OP_EXT was listed twice in the "
1779 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1780 i);
1781 }
1782 has_dynamic_stencil_op = true;
1783 }
Petr Kraus299ba622017-11-24 03:09:03 +01001784 }
1785 }
1786
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07001787 auto feedback_struct = LvlFindInChain<VkPipelineCreationFeedbackCreateInfoEXT>(pCreateInfos[i].pNext);
Peter Chen85366392019-05-14 15:20:11 -04001788 if ((feedback_struct != nullptr) &&
1789 (feedback_struct->pipelineStageCreationFeedbackCount != pCreateInfos[i].stageCount)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001790 skip |= LogError(device, "VUID-VkPipelineCreationFeedbackCreateInfoEXT-pipelineStageCreationFeedbackCount-02668",
1791 "vkCreateGraphicsPipelines(): in pCreateInfo[%" PRIu32
1792 "], VkPipelineCreationFeedbackEXT::pipelineStageCreationFeedbackCount"
1793 "(=%" PRIu32 ") must equal VkGraphicsPipelineCreateInfo::stageCount(=%" PRIu32 ").",
1794 i, feedback_struct->pipelineStageCreationFeedbackCount, pCreateInfos[i].stageCount);
Peter Chen85366392019-05-14 15:20:11 -04001795 }
1796
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001797 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001798
Spencer Frickef1b0a7d2020-03-16 17:38:55 -07001799 // Collect active stages and other information
1800 // Only want to loop through pStages once
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001801 uint32_t active_shaders = 0;
Spencer Frickef1b0a7d2020-03-16 17:38:55 -07001802 bool has_eval = false;
1803 bool has_control = false;
1804 if (pCreateInfos[i].pStages != nullptr) {
1805 for (uint32_t stage_index = 0; stage_index < pCreateInfos[i].stageCount; ++stage_index) {
1806 active_shaders |= pCreateInfos[i].pStages[stage_index].stage;
1807
1808 if (pCreateInfos[i].pStages[stage_index].stage == VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) {
1809 has_control = true;
1810 } else if (pCreateInfos[i].pStages[stage_index].stage == VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT) {
1811 has_eval = true;
1812 }
1813
1814 skip |= validate_string(
1815 "vkCreateGraphicsPipelines",
1816 ParameterName("pCreateInfos[%i].pStages[%i].pName", ParameterName::IndexVector{i, stage_index}),
1817 "VUID-VkGraphicsPipelineCreateInfo-pStages-parameter", pCreateInfos[i].pStages[stage_index].pName);
1818 }
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001819 }
1820
1821 if ((active_shaders & VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) &&
1822 (active_shaders & VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT) && (pCreateInfos[i].pTessellationState != nullptr)) {
1823 skip |= validate_struct_type("vkCreateGraphicsPipelines", "pCreateInfos[i].pTessellationState",
1824 "VK_STRUCTURE_TYPE_PIPELINE_TESSELLATION_STATE_CREATE_INFO",
1825 pCreateInfos[i].pTessellationState,
1826 VK_STRUCTURE_TYPE_PIPELINE_TESSELLATION_STATE_CREATE_INFO, false, kVUIDUndefined,
1827 "VUID-VkPipelineTessellationStateCreateInfo-sType-sType");
1828
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001829 const VkStructureType allowed_structs_vk_pipeline_tessellation_state_create_info[] = {
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001830 VK_STRUCTURE_TYPE_PIPELINE_TESSELLATION_DOMAIN_ORIGIN_STATE_CREATE_INFO};
1831
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001832 skip |= validate_struct_pnext(
1833 "vkCreateGraphicsPipelines", "pCreateInfos[i].pTessellationState->pNext",
1834 "VkPipelineTessellationDomainOriginStateCreateInfo", pCreateInfos[i].pTessellationState->pNext,
1835 ARRAY_SIZE(allowed_structs_vk_pipeline_tessellation_state_create_info),
1836 allowed_structs_vk_pipeline_tessellation_state_create_info, GeneratedVulkanHeaderVersion,
1837 "VUID-VkPipelineTessellationStateCreateInfo-pNext-pNext",
1838 "VUID-VkPipelineTessellationStateCreateInfo-sType-unique");
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001839
1840 skip |= validate_reserved_flags("vkCreateGraphicsPipelines", "pCreateInfos[i].pTessellationState->flags",
1841 pCreateInfos[i].pTessellationState->flags,
1842 "VUID-VkPipelineTessellationStateCreateInfo-flags-zerobitmask");
1843 }
1844
1845 if (!(active_shaders & VK_SHADER_STAGE_MESH_BIT_NV) && (pCreateInfos[i].pInputAssemblyState != nullptr)) {
1846 skip |= validate_struct_type("vkCreateGraphicsPipelines", "pCreateInfos[i].pInputAssemblyState",
1847 "VK_STRUCTURE_TYPE_PIPELINE_INPUT_ASSEMBLY_STATE_CREATE_INFO",
1848 pCreateInfos[i].pInputAssemblyState,
1849 VK_STRUCTURE_TYPE_PIPELINE_INPUT_ASSEMBLY_STATE_CREATE_INFO, false, kVUIDUndefined,
1850 "VUID-VkPipelineInputAssemblyStateCreateInfo-sType-sType");
1851
1852 skip |= validate_struct_pnext("vkCreateGraphicsPipelines", "pCreateInfos[i].pInputAssemblyState->pNext", NULL,
1853 pCreateInfos[i].pInputAssemblyState->pNext, 0, NULL, GeneratedVulkanHeaderVersion,
sfricke-samsung32a27362020-02-28 09:06:42 -08001854 "VUID-VkPipelineInputAssemblyStateCreateInfo-pNext-pNext", nullptr);
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001855
1856 skip |= validate_reserved_flags("vkCreateGraphicsPipelines", "pCreateInfos[i].pInputAssemblyState->flags",
1857 pCreateInfos[i].pInputAssemblyState->flags,
1858 "VUID-VkPipelineInputAssemblyStateCreateInfo-flags-zerobitmask");
1859
1860 skip |= validate_ranged_enum("vkCreateGraphicsPipelines", "pCreateInfos[i].pInputAssemblyState->topology",
1861 "VkPrimitiveTopology", AllVkPrimitiveTopologyEnums,
1862 pCreateInfos[i].pInputAssemblyState->topology,
1863 "VUID-VkPipelineInputAssemblyStateCreateInfo-topology-parameter");
1864
1865 skip |= validate_bool32("vkCreateGraphicsPipelines", "pCreateInfos[i].pInputAssemblyState->primitiveRestartEnable",
1866 pCreateInfos[i].pInputAssemblyState->primitiveRestartEnable);
1867 }
1868
1869 if (!(active_shaders & VK_SHADER_STAGE_MESH_BIT_NV) && (pCreateInfos[i].pVertexInputState != nullptr)) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001870 auto const &vertex_input_state = pCreateInfos[i].pVertexInputState;
Peter Kohautc7d9d392018-07-15 00:34:07 +02001871
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001872 if (pCreateInfos[i].pVertexInputState->flags != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001873 skip |= LogError(device, "VUID-VkPipelineVertexInputStateCreateInfo-flags-zerobitmask",
1874 "vkCreateGraphicsPipelines: pararameter "
1875 "pCreateInfos[%d].pVertexInputState->flags (%u) is reserved and must be zero.",
1876 i, vertex_input_state->flags);
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001877 }
1878
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001879 const VkStructureType allowed_structs_vk_pipeline_vertex_input_state_create_info[] = {
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001880 VK_STRUCTURE_TYPE_PIPELINE_VERTEX_INPUT_DIVISOR_STATE_CREATE_INFO_EXT};
1881 skip |= validate_struct_pnext("vkCreateGraphicsPipelines", "pCreateInfos[i].pVertexInputState->pNext",
1882 "VkPipelineVertexInputDivisorStateCreateInfoEXT",
1883 pCreateInfos[i].pVertexInputState->pNext, 1,
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001884 allowed_structs_vk_pipeline_vertex_input_state_create_info,
1885 GeneratedVulkanHeaderVersion, "VUID-VkPipelineVertexInputStateCreateInfo-pNext-pNext",
sfricke-samsung32a27362020-02-28 09:06:42 -08001886 "VUID-VkPipelineVertexInputStateCreateInfo-sType-unique");
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001887 skip |= validate_struct_type("vkCreateGraphicsPipelines", "pCreateInfos[i].pVertexInputState",
1888 "VK_STRUCTURE_TYPE_PIPELINE_VERTEX_INPUT_STATE_CREATE_INFO", vertex_input_state,
Shannon McPherson3cc90bc2019-08-13 11:28:22 -06001889 VK_STRUCTURE_TYPE_PIPELINE_VERTEX_INPUT_STATE_CREATE_INFO, false, kVUIDUndefined,
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001890 "VUID-VkPipelineVertexInputStateCreateInfo-sType-sType");
1891 skip |=
1892 validate_array("vkCreateGraphicsPipelines", "pCreateInfos[i].pVertexInputState->vertexBindingDescriptionCount",
1893 "pCreateInfos[i].pVertexInputState->pVertexBindingDescriptions",
1894 pCreateInfos[i].pVertexInputState->vertexBindingDescriptionCount,
1895 &pCreateInfos[i].pVertexInputState->pVertexBindingDescriptions, false, true, kVUIDUndefined,
1896 "VUID-VkPipelineVertexInputStateCreateInfo-pVertexBindingDescriptions-parameter");
1897
1898 skip |= validate_array(
1899 "vkCreateGraphicsPipelines", "pCreateInfos[i].pVertexInputState->vertexAttributeDescriptionCount",
1900 "pCreateInfos[i]->pVertexAttributeDescriptions", vertex_input_state->vertexAttributeDescriptionCount,
1901 &vertex_input_state->pVertexAttributeDescriptions, false, true, kVUIDUndefined,
1902 "VUID-VkPipelineVertexInputStateCreateInfo-pVertexAttributeDescriptions-parameter");
1903
1904 if (pCreateInfos[i].pVertexInputState->pVertexBindingDescriptions != NULL) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001905 for (uint32_t vertex_binding_description_index = 0;
1906 vertex_binding_description_index < pCreateInfos[i].pVertexInputState->vertexBindingDescriptionCount;
1907 ++vertex_binding_description_index) {
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001908 skip |= validate_ranged_enum(
1909 "vkCreateGraphicsPipelines",
1910 "pCreateInfos[i].pVertexInputState->pVertexBindingDescriptions[j].inputRate", "VkVertexInputRate",
1911 AllVkVertexInputRateEnums,
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001912 pCreateInfos[i]
1913 .pVertexInputState->pVertexBindingDescriptions[vertex_binding_description_index]
1914 .inputRate,
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001915 "VUID-VkVertexInputBindingDescription-inputRate-parameter");
1916 }
1917 }
1918
1919 if (pCreateInfos[i].pVertexInputState->pVertexAttributeDescriptions != NULL) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001920 for (uint32_t vertex_attribute_description_index = 0;
1921 vertex_attribute_description_index < pCreateInfos[i].pVertexInputState->vertexAttributeDescriptionCount;
1922 ++vertex_attribute_description_index) {
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001923 skip |= validate_ranged_enum(
1924 "vkCreateGraphicsPipelines",
1925 "pCreateInfos[i].pVertexInputState->pVertexAttributeDescriptions[i].format", "VkFormat",
1926 AllVkFormatEnums,
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001927 pCreateInfos[i]
1928 .pVertexInputState->pVertexAttributeDescriptions[vertex_attribute_description_index]
1929 .format,
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001930 "VUID-VkVertexInputAttributeDescription-format-parameter");
1931 }
1932 }
1933
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001934 if (vertex_input_state->vertexBindingDescriptionCount > device_limits.maxVertexInputBindings) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001935 skip |= LogError(device, "VUID-VkPipelineVertexInputStateCreateInfo-vertexBindingDescriptionCount-00613",
1936 "vkCreateGraphicsPipelines: pararameter "
1937 "pCreateInfo[%d].pVertexInputState->vertexBindingDescriptionCount (%u) is "
1938 "greater than VkPhysicalDeviceLimits::maxVertexInputBindings (%u).",
1939 i, vertex_input_state->vertexBindingDescriptionCount, device_limits.maxVertexInputBindings);
Peter Kohautc7d9d392018-07-15 00:34:07 +02001940 }
1941
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001942 if (vertex_input_state->vertexAttributeDescriptionCount > device_limits.maxVertexInputAttributes) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001943 skip |=
1944 LogError(device, "VUID-VkPipelineVertexInputStateCreateInfo-vertexAttributeDescriptionCount-00614",
1945 "vkCreateGraphicsPipelines: pararameter "
1946 "pCreateInfo[%d].pVertexInputState->vertexAttributeDescriptionCount (%u) is "
1947 "greater than VkPhysicalDeviceLimits::maxVertexInputAttributes (%u).",
1948 i, vertex_input_state->vertexAttributeDescriptionCount, device_limits.maxVertexInputAttributes);
Peter Kohautc7d9d392018-07-15 00:34:07 +02001949 }
1950
1951 std::unordered_set<uint32_t> vertex_bindings(vertex_input_state->vertexBindingDescriptionCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001952 for (uint32_t d = 0; d < vertex_input_state->vertexBindingDescriptionCount; ++d) {
1953 auto const &vertex_bind_desc = vertex_input_state->pVertexBindingDescriptions[d];
Peter Kohautc7d9d392018-07-15 00:34:07 +02001954 auto const &binding_it = vertex_bindings.find(vertex_bind_desc.binding);
1955 if (binding_it != vertex_bindings.cend()) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001956 skip |= LogError(device, "VUID-VkPipelineVertexInputStateCreateInfo-pVertexBindingDescriptions-00616",
1957 "vkCreateGraphicsPipelines: parameter "
1958 "pCreateInfo[%d].pVertexInputState->pVertexBindingDescription[%d].binding "
1959 "(%" PRIu32 ") is not distinct.",
1960 i, d, vertex_bind_desc.binding);
Peter Kohautc7d9d392018-07-15 00:34:07 +02001961 }
1962 vertex_bindings.insert(vertex_bind_desc.binding);
1963
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001964 if (vertex_bind_desc.binding >= device_limits.maxVertexInputBindings) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001965 skip |= LogError(device, "VUID-VkVertexInputBindingDescription-binding-00618",
1966 "vkCreateGraphicsPipelines: parameter "
1967 "pCreateInfos[%u].pVertexInputState->pVertexBindingDescriptions[%u].binding (%u) is "
1968 "greater than or equal to VkPhysicalDeviceLimits::maxVertexInputBindings (%u).",
1969 i, d, vertex_bind_desc.binding, device_limits.maxVertexInputBindings);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001970 }
1971
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001972 if (vertex_bind_desc.stride > device_limits.maxVertexInputBindingStride) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001973 skip |=
1974 LogError(device, "VUID-VkVertexInputBindingDescription-stride-00619",
1975 "vkCreateGraphicsPipelines: parameter "
1976 "pCreateInfos[%u].pVertexInputState->pVertexBindingDescriptions[%u].stride (%u) is greater "
1977 "than VkPhysicalDeviceLimits::maxVertexInputBindingStride (%u).",
1978 i, d, vertex_bind_desc.stride, device_limits.maxVertexInputBindingStride);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001979 }
1980 }
1981
Peter Kohautc7d9d392018-07-15 00:34:07 +02001982 std::unordered_set<uint32_t> attribute_locations(vertex_input_state->vertexAttributeDescriptionCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001983 for (uint32_t d = 0; d < vertex_input_state->vertexAttributeDescriptionCount; ++d) {
1984 auto const &vertex_attrib_desc = vertex_input_state->pVertexAttributeDescriptions[d];
Peter Kohautc7d9d392018-07-15 00:34:07 +02001985 auto const &location_it = attribute_locations.find(vertex_attrib_desc.location);
1986 if (location_it != attribute_locations.cend()) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001987 skip |= LogError(
1988 device, "VUID-VkPipelineVertexInputStateCreateInfo-pVertexAttributeDescriptions-00617",
Peter Kohautc7d9d392018-07-15 00:34:07 +02001989 "vkCreateGraphicsPipelines: parameter "
1990 "pCreateInfo[%d].pVertexInputState->vertexAttributeDescriptions[%d].location (%u) is not distinct.",
1991 i, d, vertex_attrib_desc.location);
1992 }
1993 attribute_locations.insert(vertex_attrib_desc.location);
1994
1995 auto const &binding_it = vertex_bindings.find(vertex_attrib_desc.binding);
1996 if (binding_it == vertex_bindings.cend()) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001997 skip |= LogError(
1998 device, "VUID-VkPipelineVertexInputStateCreateInfo-binding-00615",
Peter Kohautc7d9d392018-07-15 00:34:07 +02001999 "vkCreateGraphicsPipelines: parameter "
2000 " pCreateInfo[%d].pVertexInputState->vertexAttributeDescriptions[%d].binding (%u) does not exist "
2001 "in any pCreateInfo[%d].pVertexInputState->pVertexBindingDescription.",
2002 i, d, vertex_attrib_desc.binding, i);
2003 }
2004
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002005 if (vertex_attrib_desc.location >= device_limits.maxVertexInputAttributes) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002006 skip |= LogError(device, "VUID-VkVertexInputAttributeDescription-location-00620",
2007 "vkCreateGraphicsPipelines: parameter "
2008 "pCreateInfos[%u].pVertexInputState->pVertexAttributeDescriptions[%u].location (%u) is "
2009 "greater than or equal to VkPhysicalDeviceLimits::maxVertexInputAttributes (%u).",
2010 i, d, vertex_attrib_desc.location, device_limits.maxVertexInputAttributes);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002011 }
2012
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002013 if (vertex_attrib_desc.binding >= device_limits.maxVertexInputBindings) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002014 skip |= LogError(device, "VUID-VkVertexInputAttributeDescription-binding-00621",
2015 "vkCreateGraphicsPipelines: parameter "
2016 "pCreateInfos[%u].pVertexInputState->pVertexAttributeDescriptions[%u].binding (%u) is "
2017 "greater than or equal to VkPhysicalDeviceLimits::maxVertexInputBindings (%u).",
2018 i, d, vertex_attrib_desc.binding, device_limits.maxVertexInputBindings);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002019 }
2020
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002021 if (vertex_attrib_desc.offset > device_limits.maxVertexInputAttributeOffset) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002022 skip |= LogError(device, "VUID-VkVertexInputAttributeDescription-offset-00622",
2023 "vkCreateGraphicsPipelines: parameter "
2024 "pCreateInfos[%u].pVertexInputState->pVertexAttributeDescriptions[%u].offset (%u) is "
2025 "greater than VkPhysicalDeviceLimits::maxVertexInputAttributeOffset (%u).",
2026 i, d, vertex_attrib_desc.offset, device_limits.maxVertexInputAttributeOffset);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002027 }
2028 }
2029 }
2030
Spencer Frickef1b0a7d2020-03-16 17:38:55 -07002031 // pTessellationState is ignored without both tessellation control and tessellation evaluation shaders stages
2032 if (has_control && has_eval) {
2033 if (pCreateInfos[i].pTessellationState == nullptr) {
2034 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-pStages-00731",
2035 "vkCreateGraphicsPipelines: if pCreateInfos[%d].pStages includes a tessellation control "
2036 "shader stage and a tessellation evaluation shader stage, "
2037 "pCreateInfos[%d].pTessellationState must not be NULL.",
2038 i, i);
2039 } else {
2040 const VkStructureType allowed_type = VK_STRUCTURE_TYPE_PIPELINE_TESSELLATION_DOMAIN_ORIGIN_STATE_CREATE_INFO;
2041 skip |= validate_struct_pnext(
2042 "vkCreateGraphicsPipelines",
2043 ParameterName("pCreateInfos[%i].pTessellationState->pNext", ParameterName::IndexVector{i}),
2044 "VkPipelineTessellationDomainOriginStateCreateInfo", pCreateInfos[i].pTessellationState->pNext, 1,
2045 &allowed_type, GeneratedVulkanHeaderVersion, "VUID-VkGraphicsPipelineCreateInfo-pNext-pNext",
2046 "VUID-VkGraphicsPipelineCreateInfo-sType-unique");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002047
Spencer Frickef1b0a7d2020-03-16 17:38:55 -07002048 skip |= validate_reserved_flags(
2049 "vkCreateGraphicsPipelines",
2050 ParameterName("pCreateInfos[%i].pTessellationState->flags", ParameterName::IndexVector{i}),
2051 pCreateInfos[i].pTessellationState->flags, "VUID-VkPipelineTessellationStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002052
Spencer Frickef1b0a7d2020-03-16 17:38:55 -07002053 if (pCreateInfos[i].pTessellationState->patchControlPoints == 0 ||
2054 pCreateInfos[i].pTessellationState->patchControlPoints > device_limits.maxTessellationPatchSize) {
2055 skip |= LogError(device, "VUID-VkPipelineTessellationStateCreateInfo-patchControlPoints-01214",
2056 "vkCreateGraphicsPipelines: invalid parameter "
2057 "pCreateInfos[%d].pTessellationState->patchControlPoints value %u. patchControlPoints "
2058 "should be >0 and <=%u.",
2059 i, pCreateInfos[i].pTessellationState->patchControlPoints,
2060 device_limits.maxTessellationPatchSize);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002061 }
2062 }
2063 }
2064
2065 // pViewportState, pMultisampleState, pDepthStencilState, and pColorBlendState ignored when rasterization is disabled
2066 if ((pCreateInfos[i].pRasterizationState != nullptr) &&
2067 (pCreateInfos[i].pRasterizationState->rasterizerDiscardEnable == VK_FALSE)) {
2068 if (pCreateInfos[i].pViewportState == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002069 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-rasterizerDiscardEnable-00750",
2070 "vkCreateGraphicsPipelines: Rasterization is enabled (pCreateInfos[%" PRIu32
2071 "].pRasterizationState->rasterizerDiscardEnable is VK_FALSE), but pCreateInfos[%" PRIu32
2072 "].pViewportState (=NULL) is not a valid pointer.",
2073 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002074 } else {
Petr Krausa6103552017-11-16 21:21:58 +01002075 const auto &viewport_state = *pCreateInfos[i].pViewportState;
2076
2077 if (viewport_state.sType != VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_STATE_CREATE_INFO) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002078 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-sType-sType",
2079 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2080 "].pViewportState->sType is not VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_STATE_CREATE_INFO.",
2081 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002082 }
2083
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002084 const VkStructureType allowed_structs_vk_pipeline_viewport_state_create_info[] = {
Petr Krausa6103552017-11-16 21:21:58 +01002085 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_SWIZZLE_STATE_CREATE_INFO_NV,
Jeff Bolz3e71f782018-08-29 23:15:45 -05002086 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_W_SCALING_STATE_CREATE_INFO_NV,
2087 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_EXCLUSIVE_SCISSOR_STATE_CREATE_INFO_NV,
Jeff Bolz9af91c52018-09-01 21:53:57 -05002088 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_SHADING_RATE_IMAGE_STATE_CREATE_INFO_NV,
2089 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_COARSE_SAMPLE_ORDER_STATE_CREATE_INFO_NV,
Jeff Bolz3e71f782018-08-29 23:15:45 -05002090 };
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002091 skip |= validate_struct_pnext(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002092 "vkCreateGraphicsPipelines",
Petr Krausa6103552017-11-16 21:21:58 +01002093 ParameterName("pCreateInfos[%i].pViewportState->pNext", ParameterName::IndexVector{i}),
Jeff Bolz9af91c52018-09-01 21:53:57 -05002094 "VkPipelineViewportSwizzleStateCreateInfoNV, VkPipelineViewportWScalingStateCreateInfoNV, "
Jeff Bolzb8a8dd02018-09-18 02:39:24 -05002095 "VkPipelineViewportExclusiveScissorStateCreateInfoNV, VkPipelineViewportShadingRateImageStateCreateInfoNV, "
2096 "VkPipelineViewportCoarseSampleOrderStateCreateInfoNV",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002097 viewport_state.pNext, ARRAY_SIZE(allowed_structs_vk_pipeline_viewport_state_create_info),
2098 allowed_structs_vk_pipeline_viewport_state_create_info, 65,
2099 "VUID-VkPipelineViewportStateCreateInfo-pNext-pNext",
sfricke-samsung32a27362020-02-28 09:06:42 -08002100 "VUID-VkPipelineViewportStateCreateInfo-sType-unique");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002101
2102 skip |= validate_reserved_flags(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002103 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002104 ParameterName("pCreateInfos[%i].pViewportState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06002105 viewport_state.flags, "VUID-VkPipelineViewportStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002106
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07002107 auto exclusive_scissor_struct =
2108 LvlFindInChain<VkPipelineViewportExclusiveScissorStateCreateInfoNV>(pCreateInfos[i].pViewportState->pNext);
2109 auto shading_rate_image_struct =
2110 LvlFindInChain<VkPipelineViewportShadingRateImageStateCreateInfoNV>(pCreateInfos[i].pViewportState->pNext);
2111 auto coarse_sample_order_struct =
2112 LvlFindInChain<VkPipelineViewportCoarseSampleOrderStateCreateInfoNV>(pCreateInfos[i].pViewportState->pNext);
Chris Mayer328d8212018-12-11 14:16:18 +01002113 const auto vp_swizzle_struct =
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07002114 LvlFindInChain<VkPipelineViewportSwizzleStateCreateInfoNV>(pCreateInfos[i].pViewportState->pNext);
Chris Mayer9ded5eb2019-09-19 16:33:26 +02002115 const auto vp_w_scaling_struct =
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07002116 LvlFindInChain<VkPipelineViewportWScalingStateCreateInfoNV>(pCreateInfos[i].pViewportState->pNext);
Jeff Bolz3e71f782018-08-29 23:15:45 -05002117
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002118 if (!physical_device_features.multiViewport) {
Mark Lobodzinski8b9ddab2020-10-15 14:38:43 -06002119 if (!has_dynamic_viewport_with_count && (viewport_state.viewportCount != 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002120 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-viewportCount-01216",
2121 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
2122 "disabled, but pCreateInfos[%" PRIu32 "].pViewportState->viewportCount (=%" PRIu32
2123 ") is not 1.",
2124 i, viewport_state.viewportCount);
Petr Krausa6103552017-11-16 21:21:58 +01002125 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002126
Mark Lobodzinski8b9ddab2020-10-15 14:38:43 -06002127 if (!has_dynamic_scissor_with_count && (viewport_state.scissorCount != 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002128 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-01217",
2129 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
2130 "disabled, but pCreateInfos[%" PRIu32 "].pViewportState->scissorCount (=%" PRIu32
2131 ") is not 1.",
2132 i, viewport_state.scissorCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002133 }
Jeff Bolz3e71f782018-08-29 23:15:45 -05002134
Dave Houlton142c4cb2018-10-17 15:04:41 -06002135 if (exclusive_scissor_struct && (exclusive_scissor_struct->exclusiveScissorCount != 0 &&
2136 exclusive_scissor_struct->exclusiveScissorCount != 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002137 skip |= LogError(
2138 device, "VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-exclusiveScissorCount-02027",
2139 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
2140 "disabled, but pCreateInfos[%" PRIu32
2141 "] VkPipelineViewportExclusiveScissorStateCreateInfoNV::exclusiveScissorCount (=%" PRIu32
2142 ") is not 1.",
2143 i, exclusive_scissor_struct->exclusiveScissorCount);
Jeff Bolz3e71f782018-08-29 23:15:45 -05002144 }
2145
Jeff Bolz9af91c52018-09-01 21:53:57 -05002146 if (shading_rate_image_struct &&
2147 (shading_rate_image_struct->viewportCount != 0 && shading_rate_image_struct->viewportCount != 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002148 skip |= LogError(device, "VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-viewportCount-02054",
2149 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
2150 "disabled, but pCreateInfos[%" PRIu32
2151 "] VkPipelineViewportShadingRateImageStateCreateInfoNV::viewportCount (=%" PRIu32
2152 ") is neither 0 nor 1.",
2153 i, shading_rate_image_struct->viewportCount);
Jeff Bolz9af91c52018-09-01 21:53:57 -05002154 }
2155
Petr Krausa6103552017-11-16 21:21:58 +01002156 } else { // multiViewport enabled
2157 if (viewport_state.viewportCount == 0) {
Piers Daniell39842ee2020-07-10 16:42:33 -06002158 if (!has_dynamic_viewport_with_count) {
2159 skip |= LogError(
2160 device, "VUID-VkPipelineViewportStateCreateInfo-viewportCount-arraylength",
2161 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "].pViewportState->viewportCount is 0.", i);
2162 }
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002163 } else if (viewport_state.viewportCount > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002164 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-viewportCount-01218",
2165 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2166 "].pViewportState->viewportCount (=%" PRIu32
2167 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
2168 i, viewport_state.viewportCount, device_limits.maxViewports);
Piers Daniell39842ee2020-07-10 16:42:33 -06002169 } else if (has_dynamic_viewport_with_count) {
2170 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-03379",
2171 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2172 "].pViewportState->viewportCount (=%" PRIu32
2173 ") must be zero when VK_DYNAMIC_STATE_VIEWPORT_WITH_COUNT_EXT is used.",
2174 i, viewport_state.viewportCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002175 }
Petr Krausa6103552017-11-16 21:21:58 +01002176
2177 if (viewport_state.scissorCount == 0) {
Piers Daniell39842ee2020-07-10 16:42:33 -06002178 if (!has_dynamic_scissor_with_count) {
2179 skip |= LogError(
2180 device, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-arraylength",
2181 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "].pViewportState->scissorCount is 0.", i);
2182 }
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002183 } else if (viewport_state.scissorCount > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002184 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-01219",
2185 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2186 "].pViewportState->scissorCount (=%" PRIu32
2187 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
2188 i, viewport_state.scissorCount, device_limits.maxViewports);
Piers Daniell39842ee2020-07-10 16:42:33 -06002189 } else if (has_dynamic_scissor_with_count) {
2190 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-03380",
2191 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2192 "].pViewportState->scissorCount (=%" PRIu32
2193 ") must be zero when VK_DYNAMIC_STATE_SCISSOR_WITH_COUNT_EXT is used.",
2194 i, viewport_state.viewportCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002195 }
2196 }
2197
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002198 if (exclusive_scissor_struct && exclusive_scissor_struct->exclusiveScissorCount > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002199 skip |=
2200 LogError(device, "VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-exclusiveScissorCount-02028",
2201 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "] exclusiveScissorCount (=%" PRIu32
2202 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
2203 i, exclusive_scissor_struct->exclusiveScissorCount, device_limits.maxViewports);
Jeff Bolz3e71f782018-08-29 23:15:45 -05002204 }
2205
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002206 if (shading_rate_image_struct && shading_rate_image_struct->viewportCount > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002207 skip |= LogError(device, "VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-viewportCount-02055",
2208 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2209 "] VkPipelineViewportShadingRateImageStateCreateInfoNV viewportCount (=%" PRIu32
2210 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
2211 i, shading_rate_image_struct->viewportCount, device_limits.maxViewports);
Jeff Bolz9af91c52018-09-01 21:53:57 -05002212 }
2213
Piers Daniell39842ee2020-07-10 16:42:33 -06002214 if (viewport_state.scissorCount != viewport_state.viewportCount &&
2215 !(has_dynamic_viewport_with_count || has_dynamic_scissor_with_count)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002216 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-01220",
2217 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2218 "].pViewportState->scissorCount (=%" PRIu32 ") is not identical to pCreateInfos[%" PRIu32
2219 "].pViewportState->viewportCount (=%" PRIu32 ").",
2220 i, viewport_state.scissorCount, i, viewport_state.viewportCount);
Petr Krausa6103552017-11-16 21:21:58 +01002221 }
2222
Dave Houlton142c4cb2018-10-17 15:04:41 -06002223 if (exclusive_scissor_struct && exclusive_scissor_struct->exclusiveScissorCount != 0 &&
Jeff Bolz3e71f782018-08-29 23:15:45 -05002224 exclusive_scissor_struct->exclusiveScissorCount != viewport_state.viewportCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002225 skip |=
2226 LogError(device, "VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-exclusiveScissorCount-02029",
2227 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "] exclusiveScissorCount (=%" PRIu32
2228 ") must be zero or identical to pCreateInfos[%" PRIu32
2229 "].pViewportState->viewportCount (=%" PRIu32 ").",
2230 i, exclusive_scissor_struct->exclusiveScissorCount, i, viewport_state.viewportCount);
Jeff Bolz3e71f782018-08-29 23:15:45 -05002231 }
2232
Dave Houlton142c4cb2018-10-17 15:04:41 -06002233 if (shading_rate_image_struct && shading_rate_image_struct->shadingRateImageEnable &&
Jeff Bolz9af91c52018-09-01 21:53:57 -05002234 shading_rate_image_struct->viewportCount != viewport_state.viewportCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002235 skip |= LogError(
2236 device, "VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-shadingRateImageEnable-02056",
Dave Houlton142c4cb2018-10-17 15:04:41 -06002237 "vkCreateGraphicsPipelines: If shadingRateImageEnable is enabled, pCreateInfos[%" PRIu32
2238 "] "
2239 "VkPipelineViewportShadingRateImageStateCreateInfoNV viewportCount (=%" PRIu32
2240 ") must identical to pCreateInfos[%" PRIu32 "].pViewportState->viewportCount (=%" PRIu32 ").",
2241 i, shading_rate_image_struct->viewportCount, i, viewport_state.viewportCount);
Jeff Bolz9af91c52018-09-01 21:53:57 -05002242 }
2243
Petr Krausa6103552017-11-16 21:21:58 +01002244 if (!has_dynamic_viewport && viewport_state.viewportCount > 0 && viewport_state.pViewports == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002245 skip |= LogError(
2246 device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-00747",
Petr Krausa6103552017-11-16 21:21:58 +01002247 "vkCreateGraphicsPipelines: The viewport state is static (pCreateInfos[%" PRIu32
2248 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_VIEWPORT), but pCreateInfos[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002249 "].pViewportState->pViewports (=NULL) is an invalid pointer.",
2250 i, i);
Petr Krausa6103552017-11-16 21:21:58 +01002251 }
2252
2253 if (!has_dynamic_scissor && viewport_state.scissorCount > 0 && viewport_state.pScissors == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002254 skip |= LogError(
2255 device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-00748",
Petr Krausa6103552017-11-16 21:21:58 +01002256 "vkCreateGraphicsPipelines: The scissor state is static (pCreateInfos[%" PRIu32
2257 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_SCISSOR), but pCreateInfos[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002258 "].pViewportState->pScissors (=NULL) is an invalid pointer.",
2259 i, i);
Petr Krausa6103552017-11-16 21:21:58 +01002260 }
2261
Jeff Bolz3e71f782018-08-29 23:15:45 -05002262 if (!has_dynamic_exclusive_scissor_nv && exclusive_scissor_struct &&
Dave Houlton142c4cb2018-10-17 15:04:41 -06002263 exclusive_scissor_struct->exclusiveScissorCount > 0 &&
2264 exclusive_scissor_struct->pExclusiveScissors == nullptr) {
2265 skip |=
Shannon McPherson24c13d12020-06-18 15:51:41 -06002266 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-04056",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002267 "vkCreateGraphicsPipelines: The exclusive scissor state is static (pCreateInfos[%" PRIu32
2268 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV), but "
2269 "pCreateInfos[%" PRIu32 "] pExclusiveScissors (=NULL) is an invalid pointer.",
2270 i, i);
Jeff Bolz3e71f782018-08-29 23:15:45 -05002271 }
2272
Jeff Bolz9af91c52018-09-01 21:53:57 -05002273 if (!has_dynamic_shading_rate_palette_nv && shading_rate_image_struct &&
Dave Houlton142c4cb2018-10-17 15:04:41 -06002274 shading_rate_image_struct->viewportCount > 0 &&
2275 shading_rate_image_struct->pShadingRatePalettes == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002276 skip |= LogError(
Shannon McPherson24c13d12020-06-18 15:51:41 -06002277 device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-04057",
Jeff Bolz9af91c52018-09-01 21:53:57 -05002278 "vkCreateGraphicsPipelines: The shading rate palette state is static (pCreateInfos[%" PRIu32
Dave Houlton142c4cb2018-10-17 15:04:41 -06002279 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_VIEWPORT_SHADING_RATE_PALETTE_NV), "
2280 "but pCreateInfos[%" PRIu32 "] pShadingRatePalettes (=NULL) is an invalid pointer.",
Jeff Bolz9af91c52018-09-01 21:53:57 -05002281 i, i);
2282 }
2283
Chris Mayer328d8212018-12-11 14:16:18 +01002284 if (vp_swizzle_struct) {
2285 if (vp_swizzle_struct->viewportCount != viewport_state.viewportCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002286 skip |= LogError(device, "VUID-VkPipelineViewportSwizzleStateCreateInfoNV-viewportCount-01215",
2287 "vkCreateGraphicsPipelines: The viewport swizzle state vieport count of %" PRIu32
2288 " does "
2289 "not match the viewport count of %" PRIu32 " in VkPipelineViewportStateCreateInfo.",
2290 vp_swizzle_struct->viewportCount, viewport_state.viewportCount);
Chris Mayer328d8212018-12-11 14:16:18 +01002291 }
2292 }
2293
Petr Krausb3fcdb42018-01-09 22:09:09 +01002294 // validate the VkViewports
2295 if (!has_dynamic_viewport && viewport_state.pViewports) {
2296 for (uint32_t viewport_i = 0; viewport_i < viewport_state.viewportCount; ++viewport_i) {
2297 const auto &viewport = viewport_state.pViewports[viewport_i]; // will crash on invalid ptr
Jeff Bolz6d3beaa2019-02-09 21:00:05 -06002298 const char *fn_name = "vkCreateGraphicsPipelines";
2299 skip |= manual_PreCallValidateViewport(viewport, fn_name,
2300 ParameterName("pCreateInfos[%i].pViewportState->pViewports[%i]",
2301 ParameterName::IndexVector{i, viewport_i}),
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002302 VkCommandBuffer(0));
Petr Krausb3fcdb42018-01-09 22:09:09 +01002303 }
2304 }
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07002305
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002306 if (has_dynamic_viewport_w_scaling_nv && !device_extensions.vk_nv_clip_space_w_scaling) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002307 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
2308 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2309 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_VIEWPORT_W_SCALING_NV, but "
2310 "VK_NV_clip_space_w_scaling extension is not enabled.",
2311 i);
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07002312 }
2313
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002314 if (has_dynamic_discard_rectangle_ext && !device_extensions.vk_ext_discard_rectangles) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002315 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
2316 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2317 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_DISCARD_RECTANGLE_EXT, but "
2318 "VK_EXT_discard_rectangles extension is not enabled.",
2319 i);
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07002320 }
2321
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002322 if (has_dynamic_sample_locations_ext && !device_extensions.vk_ext_sample_locations) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002323 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
2324 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2325 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_SAMPLE_LOCATIONS_EXT, but "
2326 "VK_EXT_sample_locations extension is not enabled.",
2327 i);
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07002328 }
Jeff Bolz3e71f782018-08-29 23:15:45 -05002329
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002330 if (has_dynamic_exclusive_scissor_nv && !device_extensions.vk_nv_scissor_exclusive) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002331 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
2332 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2333 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV, but "
2334 "VK_NV_scissor_exclusive extension is not enabled.",
2335 i);
Jeff Bolz3e71f782018-08-29 23:15:45 -05002336 }
Jeff Bolz9af91c52018-09-01 21:53:57 -05002337
2338 if (coarse_sample_order_struct &&
2339 coarse_sample_order_struct->sampleOrderType != VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV &&
2340 coarse_sample_order_struct->customSampleOrderCount != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002341 skip |= LogError(device, "VUID-VkPipelineViewportCoarseSampleOrderStateCreateInfoNV-sampleOrderType-02072",
2342 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2343 "] "
2344 "VkPipelineViewportCoarseSampleOrderStateCreateInfoNV sampleOrderType is not "
2345 "VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV and customSampleOrderCount is not 0.",
2346 i);
Jeff Bolz9af91c52018-09-01 21:53:57 -05002347 }
2348
2349 if (coarse_sample_order_struct) {
2350 for (uint32_t order_i = 0; order_i < coarse_sample_order_struct->customSampleOrderCount; ++order_i) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002351 skip |= ValidateCoarseSampleOrderCustomNV(&coarse_sample_order_struct->pCustomSampleOrders[order_i]);
Jeff Bolz9af91c52018-09-01 21:53:57 -05002352 }
2353 }
Chris Mayer9ded5eb2019-09-19 16:33:26 +02002354
2355 if (vp_w_scaling_struct && (vp_w_scaling_struct->viewportWScalingEnable == VK_TRUE)) {
2356 if (vp_w_scaling_struct->viewportCount != viewport_state.viewportCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002357 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-viewportWScalingEnable-01726",
2358 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2359 "] "
2360 "VkPipelineViewportWScalingStateCreateInfoNV.viewportCount (=%" PRIu32
2361 ") "
2362 "is not equal to VkPipelineViewportStateCreateInfo.viewportCount (=%" PRIu32 ").",
2363 i, vp_w_scaling_struct->viewportCount, viewport_state.viewportCount);
Chris Mayer9ded5eb2019-09-19 16:33:26 +02002364 }
2365 if (!has_dynamic_viewport_w_scaling_nv && !vp_w_scaling_struct->pViewportWScalings) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002366 skip |= LogError(
2367 device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-01715",
Chris Mayer9ded5eb2019-09-19 16:33:26 +02002368 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2369 "] "
2370 "VkPipelineViewportWScalingStateCreateInfoNV.pViewportWScalings (=NULL) is not a valid array.",
2371 i);
2372 }
2373 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002374 }
2375
2376 if (pCreateInfos[i].pMultisampleState == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002377 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-rasterizerDiscardEnable-00751",
2378 "vkCreateGraphicsPipelines: if pCreateInfos[%d].pRasterizationState->rasterizerDiscardEnable "
2379 "is VK_FALSE, pCreateInfos[%d].pMultisampleState must not be NULL.",
2380 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002381 } else {
Dave Houltonb3bbec72018-01-17 10:13:33 -07002382 const VkStructureType valid_next_stypes[] = {LvlTypeMap<VkPipelineCoverageModulationStateCreateInfoNV>::kSType,
Mark Lobodzinski1ddf16f2020-08-13 08:58:13 -06002383 LvlTypeMap<VkPipelineCoverageReductionStateCreateInfoNV>::kSType,
Dave Houltonb3bbec72018-01-17 10:13:33 -07002384 LvlTypeMap<VkPipelineCoverageToColorStateCreateInfoNV>::kSType,
2385 LvlTypeMap<VkPipelineSampleLocationsStateCreateInfoEXT>::kSType};
Mike Schuchardt97662b02017-12-06 13:31:29 -07002386 const char *valid_struct_names =
Dave Houltona9df0ce2018-02-07 10:51:23 -07002387 "VkPipelineCoverageModulationStateCreateInfoNV, VkPipelineCoverageToColorStateCreateInfoNV, "
John Zulauf96b0e422017-11-14 11:43:19 -07002388 "VkPipelineSampleLocationsStateCreateInfoEXT";
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002389 skip |= validate_struct_pnext(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002390 "vkCreateGraphicsPipelines",
John Zulauf96b0e422017-11-14 11:43:19 -07002391 ParameterName("pCreateInfos[%i].pMultisampleState->pNext", ParameterName::IndexVector{i}),
Mark Lobodzinski1ddf16f2020-08-13 08:58:13 -06002392 valid_struct_names, pCreateInfos[i].pMultisampleState->pNext, 4, valid_next_stypes,
sfricke-samsung32a27362020-02-28 09:06:42 -08002393 GeneratedVulkanHeaderVersion, "VUID-VkPipelineMultisampleStateCreateInfo-pNext-pNext",
2394 "VUID-VkPipelineMultisampleStateCreateInfo-sType-unique");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002395
2396 skip |= validate_reserved_flags(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002397 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002398 ParameterName("pCreateInfos[%i].pMultisampleState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06002399 pCreateInfos[i].pMultisampleState->flags, "VUID-VkPipelineMultisampleStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002400
2401 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002402 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002403 ParameterName("pCreateInfos[%i].pMultisampleState->sampleShadingEnable", ParameterName::IndexVector{i}),
2404 pCreateInfos[i].pMultisampleState->sampleShadingEnable);
2405
2406 skip |= validate_array(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002407 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002408 ParameterName("pCreateInfos[%i].pMultisampleState->rasterizationSamples", ParameterName::IndexVector{i}),
2409 ParameterName("pCreateInfos[%i].pMultisampleState->pSampleMask", ParameterName::IndexVector{i}),
Gabríel Arthúr Pétursson092b29b2018-03-21 22:44:11 +00002410 pCreateInfos[i].pMultisampleState->rasterizationSamples, &pCreateInfos[i].pMultisampleState->pSampleMask,
Dave Houlton413a6782018-05-22 13:01:54 -06002411 true, false, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002412
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002413 skip |= validate_flags(
2414 "vkCreateGraphicsPipelines",
2415 ParameterName("pCreateInfos[%i].pMultisampleState->rasterizationSamples", ParameterName::IndexVector{i}),
2416 "VkSampleCountFlagBits", AllVkSampleCountFlagBits, pCreateInfos[i].pMultisampleState->rasterizationSamples,
Petr Kraus52758be2019-08-12 00:53:58 +02002417 kRequiredSingleBit, "VUID-VkPipelineMultisampleStateCreateInfo-rasterizationSamples-parameter");
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002418
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002419 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002420 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002421 ParameterName("pCreateInfos[%i].pMultisampleState->alphaToCoverageEnable", ParameterName::IndexVector{i}),
2422 pCreateInfos[i].pMultisampleState->alphaToCoverageEnable);
2423
2424 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002425 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002426 ParameterName("pCreateInfos[%i].pMultisampleState->alphaToOneEnable", ParameterName::IndexVector{i}),
2427 pCreateInfos[i].pMultisampleState->alphaToOneEnable);
2428
2429 if (pCreateInfos[i].pMultisampleState->sType != VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO) {
sfricke-samsung81c56f72020-08-23 22:14:41 -07002430 skip |= LogError(device, "VUID-VkPipelineMultisampleStateCreateInfo-sType-sType",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002431 "vkCreateGraphicsPipelines: parameter pCreateInfos[%d].pMultisampleState->sType must be "
2432 "VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO",
2433 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002434 }
John Zulauf7acac592017-11-06 11:15:53 -07002435 if (pCreateInfos[i].pMultisampleState->sampleShadingEnable == VK_TRUE) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002436 if (!physical_device_features.sampleRateShading) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002437 skip |= LogError(device, "VUID-VkPipelineMultisampleStateCreateInfo-sampleShadingEnable-00784",
2438 "vkCreateGraphicsPipelines(): parameter "
2439 "pCreateInfos[%d].pMultisampleState->sampleShadingEnable.",
2440 i);
John Zulauf7acac592017-11-06 11:15:53 -07002441 }
2442 // TODO Add documentation issue about when minSampleShading must be in range and when it is ignored
2443 // For now a "least noise" test *only* when sampleShadingEnable is VK_TRUE.
2444 if (!in_inclusive_range(pCreateInfos[i].pMultisampleState->minSampleShading, 0.F, 1.0F)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002445 skip |= LogError(
2446 device,
2447
Dave Houlton413a6782018-05-22 13:01:54 -06002448 "VUID-VkPipelineMultisampleStateCreateInfo-minSampleShading-00786",
Mark Lobodzinski88529492018-04-01 10:38:15 -06002449 "vkCreateGraphicsPipelines(): parameter pCreateInfos[%d].pMultisampleState->minSampleShading.", i);
John Zulauf7acac592017-11-06 11:15:53 -07002450 }
2451 }
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002452
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07002453 const auto *line_state =
2454 LvlFindInChain<VkPipelineRasterizationLineStateCreateInfoEXT>(pCreateInfos[i].pRasterizationState->pNext);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002455
2456 if (line_state) {
2457 if ((line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_BRESENHAM_EXT ||
2458 line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_RECTANGULAR_SMOOTH_EXT)) {
2459 if (pCreateInfos[i].pMultisampleState->alphaToCoverageEnable) {
2460 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002461 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-lineRasterizationMode-02766",
2462 "vkCreateGraphicsPipelines(): Bresenham/Smooth line rasterization not supported with "
2463 "pCreateInfos[%d].pMultisampleState->alphaToCoverageEnable == VK_TRUE.",
2464 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002465 }
2466 if (pCreateInfos[i].pMultisampleState->alphaToOneEnable) {
2467 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002468 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-lineRasterizationMode-02766",
2469 "vkCreateGraphicsPipelines(): Bresenham/Smooth line rasterization not supported with "
2470 "pCreateInfos[%d].pMultisampleState->alphaToOneEnable == VK_TRUE.",
2471 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002472 }
2473 if (pCreateInfos[i].pMultisampleState->sampleShadingEnable) {
2474 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002475 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-lineRasterizationMode-02766",
2476 "vkCreateGraphicsPipelines(): Bresenham/Smooth line rasterization not supported with "
2477 "pCreateInfos[%d].pMultisampleState->sampleShadingEnable == VK_TRUE.",
2478 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002479 }
2480 }
2481 if (line_state->stippledLineEnable && !has_dynamic_line_stipple) {
2482 if (line_state->lineStippleFactor < 1 || line_state->lineStippleFactor > 256) {
2483 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002484 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-stippledLineEnable-02767",
2485 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineStippleFactor = %d must be in the "
2486 "range [1,256].",
2487 i, line_state->lineStippleFactor);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002488 }
2489 }
2490 const auto *line_features =
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07002491 LvlFindInChain<VkPhysicalDeviceLineRasterizationFeaturesEXT>(device_createinfo_pnext);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002492 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_RECTANGULAR_EXT &&
2493 (!line_features || !line_features->rectangularLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002494 skip |=
2495 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-lineRasterizationMode-02768",
2496 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineRasterizationMode = "
2497 "VK_LINE_RASTERIZATION_MODE_RECTANGULAR_EXT requires the rectangularLines feature.",
2498 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002499 }
2500 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_BRESENHAM_EXT &&
2501 (!line_features || !line_features->bresenhamLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002502 skip |=
2503 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-lineRasterizationMode-02769",
2504 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineRasterizationMode = "
2505 "VK_LINE_RASTERIZATION_MODE_BRESENHAM_EXT requires the bresenhamLines feature.",
2506 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002507 }
2508 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_RECTANGULAR_SMOOTH_EXT &&
2509 (!line_features || !line_features->smoothLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002510 skip |=
2511 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-lineRasterizationMode-02770",
2512 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineRasterizationMode = "
2513 "VK_LINE_RASTERIZATION_MODE_RECTANGULAR_SMOOTH_EXT requires the smoothLines feature.",
2514 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002515 }
2516 if (line_state->stippledLineEnable) {
2517 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_RECTANGULAR_EXT &&
2518 (!line_features || !line_features->stippledRectangularLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002519 skip |=
2520 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-stippledLineEnable-02771",
2521 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineRasterizationMode = "
2522 "VK_LINE_RASTERIZATION_MODE_RECTANGULAR_EXT with stipple requires the "
2523 "stippledRectangularLines feature.",
2524 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002525 }
2526 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_BRESENHAM_EXT &&
2527 (!line_features || !line_features->stippledBresenhamLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002528 skip |=
2529 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-stippledLineEnable-02772",
2530 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineRasterizationMode = "
2531 "VK_LINE_RASTERIZATION_MODE_BRESENHAM_EXT with stipple requires the "
2532 "stippledBresenhamLines feature.",
2533 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002534 }
2535 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_RECTANGULAR_SMOOTH_EXT &&
2536 (!line_features || !line_features->stippledSmoothLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002537 skip |=
2538 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-stippledLineEnable-02773",
2539 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineRasterizationMode = "
2540 "VK_LINE_RASTERIZATION_MODE_RECTANGULAR_SMOOTH_EXT with stipple requires the "
2541 "stippledSmoothLines feature.",
2542 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002543 }
2544 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_DEFAULT_EXT &&
2545 (!line_features || !line_features->stippledSmoothLines || !device_limits.strictLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002546 skip |=
2547 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-stippledLineEnable-02774",
2548 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineRasterizationMode = "
2549 "VK_LINE_RASTERIZATION_MODE_DEFAULT_EXT with stipple requires the "
2550 "stippledRectangularLines and strictLines features.",
2551 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002552 }
2553 }
2554 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002555 }
2556
Petr Krause91f7a12017-12-14 20:57:36 +01002557 bool uses_color_attachment = false;
2558 bool uses_depthstencil_attachment = false;
2559 {
Mark Lobodzinskif27a6bc2019-02-04 13:00:49 -07002560 std::unique_lock<std::mutex> lock(renderpass_map_mutex);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002561 const auto subpasses_uses_it = renderpasses_states.find(pCreateInfos[i].renderPass);
2562 if (subpasses_uses_it != renderpasses_states.end()) {
Petr Krause91f7a12017-12-14 20:57:36 +01002563 const auto &subpasses_uses = subpasses_uses_it->second;
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002564 if (subpasses_uses.subpasses_using_color_attachment.count(pCreateInfos[i].subpass)) {
Petr Krause91f7a12017-12-14 20:57:36 +01002565 uses_color_attachment = true;
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002566 }
2567 if (subpasses_uses.subpasses_using_depthstencil_attachment.count(pCreateInfos[i].subpass)) {
Petr Krause91f7a12017-12-14 20:57:36 +01002568 uses_depthstencil_attachment = true;
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002569 }
Petr Krause91f7a12017-12-14 20:57:36 +01002570 }
Mark Lobodzinskif27a6bc2019-02-04 13:00:49 -07002571 lock.unlock();
Petr Krause91f7a12017-12-14 20:57:36 +01002572 }
2573
2574 if (pCreateInfos[i].pDepthStencilState != nullptr && uses_depthstencil_attachment) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002575 skip |= validate_struct_pnext(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002576 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002577 ParameterName("pCreateInfos[%i].pDepthStencilState->pNext", ParameterName::IndexVector{i}), NULL,
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002578 pCreateInfos[i].pDepthStencilState->pNext, 0, NULL, GeneratedVulkanHeaderVersion,
sfricke-samsung32a27362020-02-28 09:06:42 -08002579 "VUID-VkPipelineDepthStencilStateCreateInfo-pNext-pNext", nullptr);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002580
2581 skip |= validate_reserved_flags(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002582 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002583 ParameterName("pCreateInfos[%i].pDepthStencilState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06002584 pCreateInfos[i].pDepthStencilState->flags, "VUID-VkPipelineDepthStencilStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002585
2586 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002587 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002588 ParameterName("pCreateInfos[%i].pDepthStencilState->depthTestEnable", ParameterName::IndexVector{i}),
2589 pCreateInfos[i].pDepthStencilState->depthTestEnable);
2590
2591 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002592 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002593 ParameterName("pCreateInfos[%i].pDepthStencilState->depthWriteEnable", ParameterName::IndexVector{i}),
2594 pCreateInfos[i].pDepthStencilState->depthWriteEnable);
2595
2596 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002597 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002598 ParameterName("pCreateInfos[%i].pDepthStencilState->depthCompareOp", ParameterName::IndexVector{i}),
2599 "VkCompareOp", AllVkCompareOpEnums, pCreateInfos[i].pDepthStencilState->depthCompareOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002600 "VUID-VkPipelineDepthStencilStateCreateInfo-depthCompareOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002601
2602 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002603 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002604 ParameterName("pCreateInfos[%i].pDepthStencilState->depthBoundsTestEnable", ParameterName::IndexVector{i}),
2605 pCreateInfos[i].pDepthStencilState->depthBoundsTestEnable);
2606
2607 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002608 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002609 ParameterName("pCreateInfos[%i].pDepthStencilState->stencilTestEnable", ParameterName::IndexVector{i}),
2610 pCreateInfos[i].pDepthStencilState->stencilTestEnable);
2611
2612 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002613 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002614 ParameterName("pCreateInfos[%i].pDepthStencilState->front.failOp", ParameterName::IndexVector{i}),
2615 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->front.failOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002616 "VUID-VkStencilOpState-failOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002617
2618 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002619 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002620 ParameterName("pCreateInfos[%i].pDepthStencilState->front.passOp", ParameterName::IndexVector{i}),
2621 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->front.passOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002622 "VUID-VkStencilOpState-passOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002623
2624 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002625 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002626 ParameterName("pCreateInfos[%i].pDepthStencilState->front.depthFailOp", ParameterName::IndexVector{i}),
2627 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->front.depthFailOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002628 "VUID-VkStencilOpState-depthFailOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002629
2630 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002631 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002632 ParameterName("pCreateInfos[%i].pDepthStencilState->front.compareOp", ParameterName::IndexVector{i}),
2633 "VkCompareOp", AllVkCompareOpEnums, pCreateInfos[i].pDepthStencilState->front.compareOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002634 "VUID-VkPipelineDepthStencilStateCreateInfo-depthCompareOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002635
2636 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002637 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002638 ParameterName("pCreateInfos[%i].pDepthStencilState->back.failOp", ParameterName::IndexVector{i}),
2639 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->back.failOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002640 "VUID-VkStencilOpState-failOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002641
2642 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002643 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002644 ParameterName("pCreateInfos[%i].pDepthStencilState->back.passOp", ParameterName::IndexVector{i}),
2645 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->back.passOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002646 "VUID-VkStencilOpState-passOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002647
2648 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002649 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002650 ParameterName("pCreateInfos[%i].pDepthStencilState->back.depthFailOp", ParameterName::IndexVector{i}),
2651 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->back.depthFailOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002652 "VUID-VkStencilOpState-depthFailOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002653
2654 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002655 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002656 ParameterName("pCreateInfos[%i].pDepthStencilState->back.compareOp", ParameterName::IndexVector{i}),
2657 "VkCompareOp", AllVkCompareOpEnums, pCreateInfos[i].pDepthStencilState->back.compareOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002658 "VUID-VkPipelineDepthStencilStateCreateInfo-depthCompareOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002659
2660 if (pCreateInfos[i].pDepthStencilState->sType != VK_STRUCTURE_TYPE_PIPELINE_DEPTH_STENCIL_STATE_CREATE_INFO) {
sfricke-samsung81c56f72020-08-23 22:14:41 -07002661 skip |= LogError(device, "VUID-VkPipelineDepthStencilStateCreateInfo-sType-sType",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002662 "vkCreateGraphicsPipelines: parameter pCreateInfos[%d].pDepthStencilState->sType must be "
2663 "VK_STRUCTURE_TYPE_PIPELINE_DEPTH_STENCIL_STATE_CREATE_INFO",
2664 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002665 }
2666 }
2667
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002668 const VkStructureType allowed_structs_vk_pipeline_color_blend_state_create_info[] = {
Shannon McPherson9b9532b2018-10-24 12:00:09 -06002669 VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_ADVANCED_STATE_CREATE_INFO_EXT};
2670
Petr Krause91f7a12017-12-14 20:57:36 +01002671 if (pCreateInfos[i].pColorBlendState != nullptr && uses_color_attachment) {
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002672 skip |= validate_struct_type("vkCreateGraphicsPipelines",
2673 ParameterName("pCreateInfos[%i].pColorBlendState", ParameterName::IndexVector{i}),
2674 "VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO",
2675 pCreateInfos[i].pColorBlendState,
2676 VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO, false, kVUIDUndefined,
2677 "VUID-VkPipelineColorBlendStateCreateInfo-sType-sType");
2678
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002679 skip |= validate_struct_pnext(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002680 "vkCreateGraphicsPipelines",
Shannon McPherson9b9532b2018-10-24 12:00:09 -06002681 ParameterName("pCreateInfos[%i].pColorBlendState->pNext", ParameterName::IndexVector{i}),
2682 "VkPipelineColorBlendAdvancedStateCreateInfoEXT", pCreateInfos[i].pColorBlendState->pNext,
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002683 ARRAY_SIZE(allowed_structs_vk_pipeline_color_blend_state_create_info),
2684 allowed_structs_vk_pipeline_color_blend_state_create_info, GeneratedVulkanHeaderVersion,
sfricke-samsung32a27362020-02-28 09:06:42 -08002685 "VUID-VkPipelineColorBlendStateCreateInfo-pNext-pNext",
2686 "VUID-VkPipelineColorBlendStateCreateInfo-sType-unique");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002687
2688 skip |= validate_reserved_flags(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002689 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002690 ParameterName("pCreateInfos[%i].pColorBlendState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06002691 pCreateInfos[i].pColorBlendState->flags, "VUID-VkPipelineColorBlendStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002692
2693 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002694 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002695 ParameterName("pCreateInfos[%i].pColorBlendState->logicOpEnable", ParameterName::IndexVector{i}),
2696 pCreateInfos[i].pColorBlendState->logicOpEnable);
2697
2698 skip |= validate_array(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002699 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002700 ParameterName("pCreateInfos[%i].pColorBlendState->attachmentCount", ParameterName::IndexVector{i}),
2701 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments", ParameterName::IndexVector{i}),
Gabríel Arthúr Pétursson092b29b2018-03-21 22:44:11 +00002702 pCreateInfos[i].pColorBlendState->attachmentCount, &pCreateInfos[i].pColorBlendState->pAttachments, false,
Dave Houlton413a6782018-05-22 13:01:54 -06002703 true, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002704
2705 if (pCreateInfos[i].pColorBlendState->pAttachments != NULL) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002706 for (uint32_t attachment_index = 0; attachment_index < pCreateInfos[i].pColorBlendState->attachmentCount;
2707 ++attachment_index) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002708 skip |= validate_bool32("vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002709 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].blendEnable",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002710 ParameterName::IndexVector{i, attachment_index}),
2711 pCreateInfos[i].pColorBlendState->pAttachments[attachment_index].blendEnable);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002712
2713 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002714 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002715 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].srcColorBlendFactor",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002716 ParameterName::IndexVector{i, attachment_index}),
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002717 "VkBlendFactor", AllVkBlendFactorEnums,
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002718 pCreateInfos[i].pColorBlendState->pAttachments[attachment_index].srcColorBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06002719 "VUID-VkPipelineColorBlendAttachmentState-srcColorBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002720
2721 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002722 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002723 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].dstColorBlendFactor",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002724 ParameterName::IndexVector{i, attachment_index}),
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002725 "VkBlendFactor", AllVkBlendFactorEnums,
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002726 pCreateInfos[i].pColorBlendState->pAttachments[attachment_index].dstColorBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06002727 "VUID-VkPipelineColorBlendAttachmentState-dstColorBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002728
2729 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002730 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002731 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].colorBlendOp",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002732 ParameterName::IndexVector{i, attachment_index}),
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002733 "VkBlendOp", AllVkBlendOpEnums,
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002734 pCreateInfos[i].pColorBlendState->pAttachments[attachment_index].colorBlendOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002735 "VUID-VkPipelineColorBlendAttachmentState-colorBlendOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002736
2737 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002738 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002739 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].srcAlphaBlendFactor",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002740 ParameterName::IndexVector{i, attachment_index}),
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002741 "VkBlendFactor", AllVkBlendFactorEnums,
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002742 pCreateInfos[i].pColorBlendState->pAttachments[attachment_index].srcAlphaBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06002743 "VUID-VkPipelineColorBlendAttachmentState-srcAlphaBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002744
2745 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002746 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002747 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].dstAlphaBlendFactor",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002748 ParameterName::IndexVector{i, attachment_index}),
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002749 "VkBlendFactor", AllVkBlendFactorEnums,
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002750 pCreateInfos[i].pColorBlendState->pAttachments[attachment_index].dstAlphaBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06002751 "VUID-VkPipelineColorBlendAttachmentState-dstAlphaBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002752
2753 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002754 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002755 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].alphaBlendOp",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002756 ParameterName::IndexVector{i, attachment_index}),
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002757 "VkBlendOp", AllVkBlendOpEnums,
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002758 pCreateInfos[i].pColorBlendState->pAttachments[attachment_index].alphaBlendOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002759 "VUID-VkPipelineColorBlendAttachmentState-alphaBlendOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002760
2761 skip |=
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002762 validate_flags("vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002763 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].colorWriteMask",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002764 ParameterName::IndexVector{i, attachment_index}),
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002765 "VkColorComponentFlagBits", AllVkColorComponentFlagBits,
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002766 pCreateInfos[i].pColorBlendState->pAttachments[attachment_index].colorWriteMask,
Petr Kraus52758be2019-08-12 00:53:58 +02002767 kOptionalFlags, "VUID-VkPipelineColorBlendAttachmentState-colorWriteMask-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002768 }
2769 }
2770
2771 if (pCreateInfos[i].pColorBlendState->sType != VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO) {
sfricke-samsung81c56f72020-08-23 22:14:41 -07002772 skip |= LogError(device, "VUID-VkPipelineColorBlendStateCreateInfo-sType-sType",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002773 "vkCreateGraphicsPipelines: parameter pCreateInfos[%d].pColorBlendState->sType must be "
2774 "VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO",
2775 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002776 }
2777
2778 // If logicOpEnable is VK_TRUE, logicOp must be a valid VkLogicOp value
2779 if (pCreateInfos[i].pColorBlendState->logicOpEnable == VK_TRUE) {
2780 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002781 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002782 ParameterName("pCreateInfos[%i].pColorBlendState->logicOp", ParameterName::IndexVector{i}), "VkLogicOp",
Dave Houlton413a6782018-05-22 13:01:54 -06002783 AllVkLogicOpEnums, pCreateInfos[i].pColorBlendState->logicOp,
2784 "VUID-VkPipelineColorBlendStateCreateInfo-logicOpEnable-00607");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002785 }
2786 }
2787 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002788
Petr Kraus9752aae2017-11-24 03:05:50 +01002789 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_DERIVATIVE_BIT) {
2790 if (pCreateInfos[i].basePipelineIndex != -1) {
2791 if (pCreateInfos[i].basePipelineHandle != VK_NULL_HANDLE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002792 skip |=
2793 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-00724",
sfricke-samsunga470e0e2020-05-16 00:47:36 -07002794 "vkCreateGraphicsPipelines parameter, pCreateInfos[%u]->basePipelineHandle, must be "
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002795 "VK_NULL_HANDLE if pCreateInfos->flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT flag "
sfricke-samsunga470e0e2020-05-16 00:47:36 -07002796 "and pCreateInfos->basePipelineIndex is not -1.",
2797 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002798 }
2799 }
2800
Petr Kraus9752aae2017-11-24 03:05:50 +01002801 if (pCreateInfos[i].basePipelineHandle != VK_NULL_HANDLE) {
2802 if (pCreateInfos[i].basePipelineIndex != -1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002803 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-00725",
sfricke-samsunga470e0e2020-05-16 00:47:36 -07002804 "vkCreateGraphicsPipelines parameter, pCreateInfos[%u]->basePipelineIndex, must be -1 if "
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002805 "pCreateInfos->flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT flag and "
sfricke-samsunga470e0e2020-05-16 00:47:36 -07002806 "pCreateInfos->basePipelineHandle is not VK_NULL_HANDLE.",
2807 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002808 }
Mark Lobodzinski4dfeb942019-09-13 12:11:13 -06002809 } else {
Mike Schuchardte5c15cf2020-04-06 22:57:13 -07002810 if (static_cast<uint32_t>(pCreateInfos[i].basePipelineIndex) >= createInfoCount) {
sfricke-samsunga470e0e2020-05-16 00:47:36 -07002811 skip |=
2812 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-00723",
2813 "vkCreateGraphicsPipelines parameter pCreateInfos[%u]->basePipelineIndex (%d) must be a valid"
2814 "index into the pCreateInfos array, of size %d.",
2815 i, pCreateInfos[i].basePipelineIndex, createInfoCount);
Mark Lobodzinski4dfeb942019-09-13 12:11:13 -06002816 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002817 }
2818 }
2819
sfricke-samsung898cf222020-05-15 23:10:19 -07002820 if ((pCreateInfos[i].flags & VK_PIPELINE_CREATE_DISPATCH_BASE) != 0) {
2821 skip |= LogError(
2822 device, "VUID-VkGraphicsPipelineCreateInfo-flags-00764",
2823 "vkCreateGraphicsPipelines parameter pCreateInfos[%u]->flags must not contain VK_PIPELINE_CREATE_DISPATCH_BASE",
2824 i);
2825 }
2826
Petr Kraus9752aae2017-11-24 03:05:50 +01002827 if (pCreateInfos[i].pRasterizationState) {
Chris Mayer840b2c42019-08-22 18:12:22 +02002828 if (!device_extensions.vk_nv_fill_rectangle) {
2829 if (pCreateInfos[i].pRasterizationState->polygonMode == VK_POLYGON_MODE_FILL_RECTANGLE_NV) {
2830 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002831 LogError(device, "VUID-VkPipelineRasterizationStateCreateInfo-polygonMode-01414",
2832 "vkCreateGraphicsPipelines parameter, VkPolygonMode "
2833 "pCreateInfos->pRasterizationState->polygonMode cannot be VK_POLYGON_MODE_FILL_RECTANGLE_NV "
2834 "if the extension VK_NV_fill_rectangle is not enabled.");
Chris Mayer840b2c42019-08-22 18:12:22 +02002835 } else if ((pCreateInfos[i].pRasterizationState->polygonMode != VK_POLYGON_MODE_FILL) &&
2836 (physical_device_features.fillModeNonSolid == false)) {
sfricke-samsunga44586f2020-08-23 22:19:44 -07002837 skip |= LogError(device, "VUID-VkPipelineRasterizationStateCreateInfo-polygonMode-01413",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002838 "vkCreateGraphicsPipelines parameter, VkPolygonMode "
sfricke-samsunga470e0e2020-05-16 00:47:36 -07002839 "pCreateInfos[%u]->pRasterizationState->polygonMode cannot be VK_POLYGON_MODE_POINT or "
2840 "VK_POLYGON_MODE_LINE if VkPhysicalDeviceFeatures->fillModeNonSolid is false.",
2841 i);
Chris Mayer840b2c42019-08-22 18:12:22 +02002842 }
2843 } else {
2844 if ((pCreateInfos[i].pRasterizationState->polygonMode != VK_POLYGON_MODE_FILL) &&
2845 (pCreateInfos[i].pRasterizationState->polygonMode != VK_POLYGON_MODE_FILL_RECTANGLE_NV) &&
2846 (physical_device_features.fillModeNonSolid == false)) {
2847 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002848 LogError(device, "VUID-VkPipelineRasterizationStateCreateInfo-polygonMode-01507",
2849 "vkCreateGraphicsPipelines parameter, VkPolygonMode "
sfricke-samsunga470e0e2020-05-16 00:47:36 -07002850 "pCreateInfos[%u]->pRasterizationState->polygonMode must be VK_POLYGON_MODE_FILL or "
2851 "VK_POLYGON_MODE_FILL_RECTANGLE_NV if VkPhysicalDeviceFeatures->fillModeNonSolid is false.",
2852 i);
Chris Mayer840b2c42019-08-22 18:12:22 +02002853 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002854 }
Petr Kraus299ba622017-11-24 03:09:03 +01002855
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002856 if (!has_dynamic_line_width && !physical_device_features.wideLines &&
Petr Kraus299ba622017-11-24 03:09:03 +01002857 (pCreateInfos[i].pRasterizationState->lineWidth != 1.0f)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002858 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-00749",
2859 "The line width state is static (pCreateInfos[%" PRIu32
2860 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_LINE_WIDTH) and "
2861 "VkPhysicalDeviceFeatures::wideLines is disabled, but pCreateInfos[%" PRIu32
2862 "].pRasterizationState->lineWidth (=%f) is not 1.0.",
2863 i, i, pCreateInfos[i].pRasterizationState->lineWidth);
Petr Kraus299ba622017-11-24 03:09:03 +01002864 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002865 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002866 }
2867 }
2868
2869 return skip;
2870}
2871
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002872bool StatelessValidation::manual_PreCallValidateCreateComputePipelines(VkDevice device, VkPipelineCache pipelineCache,
2873 uint32_t createInfoCount,
2874 const VkComputePipelineCreateInfo *pCreateInfos,
2875 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05002876 VkPipeline *pPipelines) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002877 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002878 for (uint32_t i = 0; i < createInfoCount; i++) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002879 skip |= validate_string("vkCreateComputePipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002880 ParameterName("pCreateInfos[%i].stage.pName", ParameterName::IndexVector{i}),
Mark Lobodzinskiebee3552018-05-29 09:55:54 -06002881 "VUID-VkPipelineShaderStageCreateInfo-pName-parameter", pCreateInfos[i].stage.pName);
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07002882 auto feedback_struct = LvlFindInChain<VkPipelineCreationFeedbackCreateInfoEXT>(pCreateInfos[i].pNext);
Peter Chen85366392019-05-14 15:20:11 -04002883 if ((feedback_struct != nullptr) && (feedback_struct->pipelineStageCreationFeedbackCount != 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002884 skip |=
2885 LogError(device, "VUID-VkPipelineCreationFeedbackCreateInfoEXT-pipelineStageCreationFeedbackCount-02669",
2886 "vkCreateComputePipelines(): in pCreateInfo[%" PRIu32
2887 "], VkPipelineCreationFeedbackEXT::pipelineStageCreationFeedbackCount must equal 1, found %" PRIu32 ".",
2888 i, feedback_struct->pipelineStageCreationFeedbackCount);
Peter Chen85366392019-05-14 15:20:11 -04002889 }
sfricke-samsungc5227152020-02-09 17:36:31 -08002890
2891 // Make sure compute stage is selected
2892 if (pCreateInfos[i].stage.stage != VK_SHADER_STAGE_COMPUTE_BIT) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002893 skip |= LogError(device, "VUID-VkComputePipelineCreateInfo-stage-00701",
2894 "vkCreateComputePipelines(): the pCreateInfo[%u].stage.stage (%s) is not VK_SHADER_STAGE_COMPUTE_BIT",
2895 i, string_VkShaderStageFlagBits(pCreateInfos[i].stage.stage));
sfricke-samsungc5227152020-02-09 17:36:31 -08002896 }
sourav parmarcd5fb182020-07-17 12:58:44 -07002897
2898 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_SKIP_AABBS_BIT_KHR) {
2899 skip |=
2900 LogError(device, "VUID-VkComputePipelineCreateInfo-flags-03370",
2901 "vkCreateComputePipelines(): flags must not include VK_PIPELINE_CREATE_RAY_TRACING_SKIP_AABBS_BIT_KHR");
2902 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002903 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002904 return skip;
2905}
2906
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002907bool StatelessValidation::manual_PreCallValidateCreateSampler(VkDevice device, const VkSamplerCreateInfo *pCreateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -05002908 const VkAllocationCallbacks *pAllocator, VkSampler *pSampler) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002909 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002910
2911 if (pCreateInfo != nullptr) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002912 const auto &features = physical_device_features;
2913 const auto &limits = device_limits;
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002914
John Zulauf71968502017-10-26 13:51:15 -06002915 if (pCreateInfo->anisotropyEnable == VK_TRUE) {
2916 if (!in_inclusive_range(pCreateInfo->maxAnisotropy, 1.0F, limits.maxSamplerAnisotropy)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002917 skip |= LogError(device, "VUID-VkSamplerCreateInfo-anisotropyEnable-01071",
2918 "vkCreateSampler(): value of %s must be in range [1.0, %f] %s, but %f found.",
2919 "pCreateInfo->maxAnisotropy", limits.maxSamplerAnisotropy,
2920 "VkPhysicalDeviceLimits::maxSamplerAnistropy", pCreateInfo->maxAnisotropy);
John Zulauf71968502017-10-26 13:51:15 -06002921 }
2922
2923 // Anistropy cannot be enabled in sampler unless enabled as a feature
2924 if (features.samplerAnisotropy == VK_FALSE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002925 skip |= LogError(device, "VUID-VkSamplerCreateInfo-anisotropyEnable-01070",
2926 "vkCreateSampler(): Anisotropic sampling feature is not enabled, %s must be VK_FALSE.",
2927 "pCreateInfo->anisotropyEnable");
John Zulauf71968502017-10-26 13:51:15 -06002928 }
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002929 }
John Zulauf71968502017-10-26 13:51:15 -06002930
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002931 if (pCreateInfo->unnormalizedCoordinates == VK_TRUE) {
2932 if (pCreateInfo->minFilter != pCreateInfo->magFilter) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002933 skip |= LogError(device, "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01072",
2934 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
2935 "pCreateInfo->minFilter (%s) and pCreateInfo->magFilter (%s) must be equal.",
2936 string_VkFilter(pCreateInfo->minFilter), string_VkFilter(pCreateInfo->magFilter));
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002937 }
2938 if (pCreateInfo->mipmapMode != VK_SAMPLER_MIPMAP_MODE_NEAREST) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002939 skip |= LogError(device, "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01073",
2940 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
2941 "pCreateInfo->mipmapMode (%s) must be VK_SAMPLER_MIPMAP_MODE_NEAREST.",
2942 string_VkSamplerMipmapMode(pCreateInfo->mipmapMode));
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002943 }
2944 if (pCreateInfo->minLod != 0.0f || pCreateInfo->maxLod != 0.0f) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002945 skip |= LogError(device, "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01074",
2946 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
2947 "pCreateInfo->minLod (%f) and pCreateInfo->maxLod (%f) must both be zero.",
2948 pCreateInfo->minLod, pCreateInfo->maxLod);
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002949 }
2950 if ((pCreateInfo->addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE &&
2951 pCreateInfo->addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER) ||
2952 (pCreateInfo->addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE &&
2953 pCreateInfo->addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002954 skip |= LogError(device, "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01075",
2955 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
2956 "pCreateInfo->addressModeU (%s) and pCreateInfo->addressModeV (%s) must both be "
2957 "VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE or VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER.",
2958 string_VkSamplerAddressMode(pCreateInfo->addressModeU),
2959 string_VkSamplerAddressMode(pCreateInfo->addressModeV));
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002960 }
2961 if (pCreateInfo->anisotropyEnable == VK_TRUE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002962 skip |= LogError(device, "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01076",
2963 "vkCreateSampler(): pCreateInfo->anisotropyEnable and pCreateInfo->unnormalizedCoordinates must "
2964 "not both be VK_TRUE.");
John Zulauf71968502017-10-26 13:51:15 -06002965 }
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002966 if (pCreateInfo->compareEnable == VK_TRUE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002967 skip |= LogError(device, "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01077",
2968 "vkCreateSampler(): pCreateInfo->compareEnable and pCreateInfo->unnormalizedCoordinates must "
2969 "not both be VK_TRUE.");
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002970 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002971 }
2972
2973 // If compareEnable is VK_TRUE, compareOp must be a valid VkCompareOp value
2974 if (pCreateInfo->compareEnable == VK_TRUE) {
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002975 skip |= validate_ranged_enum("vkCreateSampler", "pCreateInfo->compareOp", "VkCompareOp", AllVkCompareOpEnums,
2976 pCreateInfo->compareOp, "VUID-VkSamplerCreateInfo-compareEnable-01080");
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07002977 const auto *sampler_reduction = LvlFindInChain<VkSamplerReductionModeCreateInfo>(pCreateInfo->pNext);
sfricke-samsung85252fb2020-05-08 20:44:06 -07002978 if (sampler_reduction != nullptr) {
2979 if (sampler_reduction->reductionMode != VK_SAMPLER_REDUCTION_MODE_WEIGHTED_AVERAGE) {
2980 skip |= LogError(
2981 device, "VUID-VkSamplerCreateInfo-compareEnable-01423",
2982 "copmareEnable is true so the sampler reduction mode must be VK_SAMPLER_REDUCTION_MODE_WEIGHTED_AVERAGE.");
2983 }
2984 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002985 }
2986
2987 // If any of addressModeU, addressModeV or addressModeW are VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER, borderColor must be a
2988 // valid VkBorderColor value
2989 if ((pCreateInfo->addressModeU == VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER) ||
2990 (pCreateInfo->addressModeV == VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER) ||
2991 (pCreateInfo->addressModeW == VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER)) {
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002992 skip |= validate_ranged_enum("vkCreateSampler", "pCreateInfo->borderColor", "VkBorderColor", AllVkBorderColorEnums,
2993 pCreateInfo->borderColor, "VUID-VkSamplerCreateInfo-addressModeU-01078");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002994 }
2995
2996 // If any of addressModeU, addressModeV or addressModeW are VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE, the
2997 // VK_KHR_sampler_mirror_clamp_to_edge extension must be enabled
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002998 if (!device_extensions.vk_khr_sampler_mirror_clamp_to_edge &&
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002999 ((pCreateInfo->addressModeU == VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE) ||
3000 (pCreateInfo->addressModeV == VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE) ||
3001 (pCreateInfo->addressModeW == VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE))) {
Dave Houlton413a6782018-05-22 13:01:54 -06003002 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003003 LogError(device, "VUID-VkSamplerCreateInfo-addressModeU-01079",
3004 "vkCreateSampler(): A VkSamplerAddressMode value is set to VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE "
3005 "but the VK_KHR_sampler_mirror_clamp_to_edge extension has not been enabled.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003006 }
John Zulauf275805c2017-10-26 15:34:49 -06003007
3008 // Checks for the IMG cubic filtering extension
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003009 if (device_extensions.vk_img_filter_cubic) {
John Zulauf275805c2017-10-26 15:34:49 -06003010 if ((pCreateInfo->anisotropyEnable == VK_TRUE) &&
3011 ((pCreateInfo->minFilter == VK_FILTER_CUBIC_IMG) || (pCreateInfo->magFilter == VK_FILTER_CUBIC_IMG))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003012 skip |= LogError(device, "VUID-VkSamplerCreateInfo-magFilter-01081",
3013 "vkCreateSampler(): Anisotropic sampling must not be VK_TRUE when either minFilter or magFilter "
3014 "are VK_FILTER_CUBIC_IMG.");
John Zulauf275805c2017-10-26 15:34:49 -06003015 }
3016 }
Mark Lobodzinski61992fc2020-01-14 14:00:08 -07003017
sfricke-samsungd91da4a2020-02-09 17:19:04 -08003018 // Check for valid Lod range
3019 if (pCreateInfo->minLod > pCreateInfo->maxLod) {
Mark Lobodzinski728ab482020-02-12 13:46:47 -07003020 skip |=
3021 LogError(device, "VUID-VkSamplerCreateInfo-maxLod-01973",
3022 "vkCreateSampler(): minLod (%f) is greater than maxLod (%f)", pCreateInfo->minLod, pCreateInfo->maxLod);
sfricke-samsungd91da4a2020-02-09 17:19:04 -08003023 }
3024
3025 // Check mipLodBias to device limit
3026 if (pCreateInfo->mipLodBias > limits.maxSamplerLodBias) {
Mark Lobodzinski728ab482020-02-12 13:46:47 -07003027 skip |= LogError(device, "VUID-VkSamplerCreateInfo-mipLodBias-01069",
3028 "vkCreateSampler(): mipLodBias (%f) is greater than VkPhysicalDeviceLimits::maxSamplerLodBias (%f)",
3029 pCreateInfo->mipLodBias, limits.maxSamplerLodBias);
sfricke-samsungd91da4a2020-02-09 17:19:04 -08003030 }
3031
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003032 const auto *sampler_conversion = LvlFindInChain<VkSamplerYcbcrConversionInfo>(pCreateInfo->pNext);
Mark Lobodzinski61992fc2020-01-14 14:00:08 -07003033 if (sampler_conversion != nullptr) {
3034 if ((pCreateInfo->addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE) ||
3035 (pCreateInfo->addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE) ||
3036 (pCreateInfo->addressModeW != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE) ||
3037 (pCreateInfo->anisotropyEnable != VK_FALSE) || (pCreateInfo->unnormalizedCoordinates != VK_FALSE)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003038 skip |= LogError(
Mark Lobodzinski728ab482020-02-12 13:46:47 -07003039 device, "VUID-VkSamplerCreateInfo-addressModeU-01646",
Mark Lobodzinski61992fc2020-01-14 14:00:08 -07003040 "vkCreateSampler(): SamplerYCbCrConversion is enabled: "
3041 "addressModeU (%s), addressModeV (%s), addressModeW (%s) must be CLAMP_TO_EDGE, and anisotropyEnable (%s) "
3042 "and unnormalizedCoordinates (%s) must be VK_FALSE.",
3043 string_VkSamplerAddressMode(pCreateInfo->addressModeU), string_VkSamplerAddressMode(pCreateInfo->addressModeV),
3044 string_VkSamplerAddressMode(pCreateInfo->addressModeW), pCreateInfo->anisotropyEnable ? "VK_TRUE" : "VK_FALSE",
3045 pCreateInfo->unnormalizedCoordinates ? "VK_TRUE" : "VK_FALSE");
3046 }
3047 }
janharaldfredriksen-arm3b793772020-05-12 18:55:53 +02003048
3049 if (pCreateInfo->flags & VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT) {
3050 if (pCreateInfo->minFilter != pCreateInfo->magFilter) {
3051 skip |= LogError(device, "VUID-VkSamplerCreateInfo-flags-02574",
3052 "vkCreateSampler(): when flags includes VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT, "
3053 "pCreateInfo->minFilter (%s) and pCreateInfo->magFilter (%s) must be equal.",
3054 string_VkFilter(pCreateInfo->minFilter), string_VkFilter(pCreateInfo->magFilter));
3055 }
3056 if (pCreateInfo->mipmapMode != VK_SAMPLER_MIPMAP_MODE_NEAREST) {
3057 skip |= LogError(device, "VUID-VkSamplerCreateInfo-flags-02575",
3058 "vkCreateSampler(): when flags includes VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT, "
3059 "pCreateInfo->mipmapMode (%s) must be VK_SAMPLER_MIPMAP_MODE_NEAREST.",
3060 string_VkSamplerMipmapMode(pCreateInfo->mipmapMode));
3061 }
3062 if (pCreateInfo->minLod != 0.0 || pCreateInfo->maxLod != 0.0) {
3063 skip |= LogError(device, "VUID-VkSamplerCreateInfo-flags-02576",
3064 "vkCreateSampler(): when flags includes VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT, "
3065 "pCreateInfo->minLod (%f) and pCreateInfo->maxLod (%f) must be zero.",
3066 pCreateInfo->minLod, pCreateInfo->maxLod);
3067 }
3068 if (((pCreateInfo->addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE) &&
3069 (pCreateInfo->addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER)) ||
3070 ((pCreateInfo->addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE) &&
3071 (pCreateInfo->addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER))) {
3072 skip |= LogError(device, "VUID-VkSamplerCreateInfo-flags-02577",
3073 "vkCreateSampler(): when flags includes VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT, "
3074 "pCreateInfo->addressModeU (%s) and pCreateInfo->addressModeV (%s) must be "
3075 "VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE or VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER",
3076 string_VkSamplerAddressMode(pCreateInfo->addressModeU),
3077 string_VkSamplerAddressMode(pCreateInfo->addressModeV));
3078 }
3079 if (pCreateInfo->anisotropyEnable) {
3080 skip |= LogError(device, "VUID-VkSamplerCreateInfo-flags-02578",
3081 "vkCreateSampler(): when flags includes VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT, "
3082 "pCreateInfo->anisotropyEnable must be VK_FALSE");
3083 }
3084 if (pCreateInfo->compareEnable) {
3085 skip |= LogError(device, "VUID-VkSamplerCreateInfo-flags-02579",
3086 "vkCreateSampler(): when flags includes VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT, "
3087 "pCreateInfo->compareEnable must be VK_FALSE");
3088 }
3089 if (pCreateInfo->unnormalizedCoordinates) {
3090 skip |= LogError(device, "VUID-VkSamplerCreateInfo-flags-02580",
3091 "vkCreateSampler(): when flags includes VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT, "
3092 "pCreateInfo->unnormalizedCoordinates must be VK_FALSE");
3093 }
3094 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003095 }
3096
Tony-LunarG7337b312020-04-15 16:40:25 -06003097 if (pCreateInfo->borderColor == VK_BORDER_COLOR_INT_CUSTOM_EXT ||
3098 pCreateInfo->borderColor == VK_BORDER_COLOR_FLOAT_CUSTOM_EXT) {
3099 if (!device_extensions.vk_ext_custom_border_color) {
3100 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
3101 "VkSamplerCreateInfo->borderColor is %s but %s is not enabled.\n",
3102 string_VkBorderColor(pCreateInfo->borderColor), VK_EXT_CUSTOM_BORDER_COLOR_EXTENSION_NAME);
3103 }
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003104 auto custom_create_info = LvlFindInChain<VkSamplerCustomBorderColorCreateInfoEXT>(pCreateInfo->pNext);
Tony-LunarG7337b312020-04-15 16:40:25 -06003105 if (!custom_create_info) {
3106 skip |=
3107 LogError(device, "VUID-VkSamplerCreateInfo-borderColor-04011",
3108 "VkSamplerCreateInfo->borderColor is set to %s but there is no VkSamplerCustomBorderColorCreateInfoEXT "
3109 "struct in pNext chain.\n",
3110 string_VkBorderColor(pCreateInfo->borderColor));
3111 } else {
3112 if ((custom_create_info->format != VK_FORMAT_UNDEFINED) &&
3113 ((pCreateInfo->borderColor == VK_BORDER_COLOR_INT_CUSTOM_EXT && !FormatIsSampledInt(custom_create_info->format)) ||
3114 (pCreateInfo->borderColor == VK_BORDER_COLOR_FLOAT_CUSTOM_EXT &&
3115 !FormatIsSampledFloat(custom_create_info->format)))) {
3116 skip |= LogError(device, "VUID-VkSamplerCustomBorderColorCreateInfoEXT-format-04013",
3117 "VkSamplerCreateInfo->borderColor is %s but VkSamplerCustomBorderColorCreateInfoEXT.format = %s "
3118 "whose type does not match\n",
3119 string_VkBorderColor(pCreateInfo->borderColor), string_VkFormat(custom_create_info->format));
3120 ;
3121 }
3122 }
3123 }
3124
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003125 return skip;
3126}
3127
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003128bool StatelessValidation::manual_PreCallValidateCreateDescriptorSetLayout(VkDevice device,
3129 const VkDescriptorSetLayoutCreateInfo *pCreateInfo,
3130 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003131 VkDescriptorSetLayout *pSetLayout) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003132 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003133
3134 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
3135 if ((pCreateInfo != nullptr) && (pCreateInfo->pBindings != nullptr)) {
3136 for (uint32_t i = 0; i < pCreateInfo->bindingCount; ++i) {
3137 if (pCreateInfo->pBindings[i].descriptorCount != 0) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003138 if (((pCreateInfo->pBindings[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLER) ||
3139 (pCreateInfo->pBindings[i].descriptorType == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER)) &&
3140 (pCreateInfo->pBindings[i].pImmutableSamplers != nullptr)) {
3141 for (uint32_t descriptor_index = 0; descriptor_index < pCreateInfo->pBindings[i].descriptorCount;
3142 ++descriptor_index) {
3143 if (pCreateInfo->pBindings[i].pImmutableSamplers[descriptor_index] == VK_NULL_HANDLE) {
Spencer Frickeb0e30822020-03-23 10:32:30 -07003144 skip |= LogError(device, "VUID-VkDescriptorSetLayoutBinding-descriptorType-00282",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003145 "vkCreateDescriptorSetLayout: required parameter "
3146 "pCreateInfo->pBindings[%d].pImmutableSamplers[%d] specified as VK_NULL_HANDLE",
3147 i, descriptor_index);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003148 }
3149 }
3150 }
3151
3152 // If descriptorCount is not 0, stageFlags must be a valid combination of VkShaderStageFlagBits values
3153 if ((pCreateInfo->pBindings[i].stageFlags != 0) &&
3154 ((pCreateInfo->pBindings[i].stageFlags & (~AllVkShaderStageFlagBits)) != 0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003155 skip |= LogError(device, "VUID-VkDescriptorSetLayoutBinding-descriptorCount-00283",
3156 "vkCreateDescriptorSetLayout(): if pCreateInfo->pBindings[%d].descriptorCount is not 0, "
3157 "pCreateInfo->pBindings[%d].stageFlags must be a valid combination of VkShaderStageFlagBits "
3158 "values.",
3159 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003160 }
Spencer Fricke84d0cc02020-03-16 17:21:59 -07003161
3162 if ((pCreateInfo->pBindings[i].descriptorType == VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT) &&
3163 (pCreateInfo->pBindings[i].stageFlags != 0) &&
3164 (pCreateInfo->pBindings[i].stageFlags != VK_SHADER_STAGE_FRAGMENT_BIT)) {
3165 skip |=
3166 LogError(device, "VUID-VkDescriptorSetLayoutBinding-descriptorType-01510",
3167 "vkCreateDescriptorSetLayout(): if pCreateInfo->pBindings[%d].descriptorCount is not 0 and "
3168 "descriptorType is VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT then pCreateInfo->pBindings[%d].stageFlags "
3169 "must be 0 or VK_SHADER_STAGE_FRAGMENT_BIT but is currently %s",
3170 i, i, string_VkShaderStageFlags(pCreateInfo->pBindings[i].stageFlags).c_str());
3171 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003172 }
3173 }
3174 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003175 return skip;
3176}
3177
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003178bool StatelessValidation::manual_PreCallValidateFreeDescriptorSets(VkDevice device, VkDescriptorPool descriptorPool,
3179 uint32_t descriptorSetCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003180 const VkDescriptorSet *pDescriptorSets) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003181 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
3182 // This is an array of handles, where the elements are allowed to be VK_NULL_HANDLE, and does not require any validation beyond
3183 // validate_array()
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003184 return validate_array("vkFreeDescriptorSets", "descriptorSetCount", "pDescriptorSets", descriptorSetCount, &pDescriptorSets,
3185 true, true, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003186}
3187
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07003188bool StatelessValidation::validate_WriteDescriptorSet(const char *vkCallingFunction, const uint32_t descriptorWriteCount,
3189 const VkWriteDescriptorSet *pDescriptorWrites,
3190 const bool validateDstSet) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003191 bool skip = false;
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07003192
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003193 if (pDescriptorWrites != NULL) {
3194 for (uint32_t i = 0; i < descriptorWriteCount; ++i) {
3195 // descriptorCount must be greater than 0
3196 if (pDescriptorWrites[i].descriptorCount == 0) {
3197 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003198 LogError(device, "VUID-VkWriteDescriptorSet-descriptorCount-arraylength",
3199 "%s(): parameter pDescriptorWrites[%d].descriptorCount must be greater than 0.", vkCallingFunction, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003200 }
3201
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07003202 // If called from vkCmdPushDescriptorSetKHR, the dstSet member is ignored.
3203 if (validateDstSet) {
3204 // dstSet must be a valid VkDescriptorSet handle
3205 skip |= validate_required_handle(vkCallingFunction,
3206 ParameterName("pDescriptorWrites[%i].dstSet", ParameterName::IndexVector{i}),
3207 pDescriptorWrites[i].dstSet);
3208 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003209
3210 if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLER) ||
3211 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER) ||
3212 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE) ||
3213 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_IMAGE) ||
3214 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT)) {
3215 // If descriptorType is VK_DESCRIPTOR_TYPE_SAMPLER, VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER,
3216 // VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE, VK_DESCRIPTOR_TYPE_STORAGE_IMAGE or VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT,
Jeff Bolz165818a2020-05-08 11:19:03 -05003217 // pImageInfo must be a pointer to an array of descriptorCount valid VkDescriptorImageInfo structures.
3218 // Valid imageView handles are checked in ObjectLifetimes::ValidateDescriptorWrite.
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003219 if (pDescriptorWrites[i].pImageInfo == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003220 skip |= LogError(device, "VUID-VkWriteDescriptorSet-descriptorType-00322",
3221 "%s(): if pDescriptorWrites[%d].descriptorType is "
3222 "VK_DESCRIPTOR_TYPE_SAMPLER, VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER, "
3223 "VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE, VK_DESCRIPTOR_TYPE_STORAGE_IMAGE or "
3224 "VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT, pDescriptorWrites[%d].pImageInfo must not be NULL.",
3225 vkCallingFunction, i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003226 } else if (pDescriptorWrites[i].descriptorType != VK_DESCRIPTOR_TYPE_SAMPLER) {
3227 // If descriptorType is VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER, VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE,
Jeff Bolz165818a2020-05-08 11:19:03 -05003228 // VK_DESCRIPTOR_TYPE_STORAGE_IMAGE or VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT, the imageLayout
3229 // member of any given element of pImageInfo must be a valid VkImageLayout
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003230 for (uint32_t descriptor_index = 0; descriptor_index < pDescriptorWrites[i].descriptorCount;
3231 ++descriptor_index) {
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07003232 skip |= validate_ranged_enum(vkCallingFunction,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003233 ParameterName("pDescriptorWrites[%i].pImageInfo[%i].imageLayout",
3234 ParameterName::IndexVector{i, descriptor_index}),
3235 "VkImageLayout", AllVkImageLayoutEnums,
Dave Houlton413a6782018-05-22 13:01:54 -06003236 pDescriptorWrites[i].pImageInfo[descriptor_index].imageLayout, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003237 }
3238 }
3239 } else if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER) ||
3240 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER) ||
3241 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC) ||
3242 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC)) {
3243 // If descriptorType is VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER, VK_DESCRIPTOR_TYPE_STORAGE_BUFFER,
3244 // VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC or VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC, pBufferInfo must be a
3245 // pointer to an array of descriptorCount valid VkDescriptorBufferInfo structures
Jeff Bolz165818a2020-05-08 11:19:03 -05003246 // Valid buffer handles are checked in ObjectLifetimes::ValidateDescriptorWrite.
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003247 if (pDescriptorWrites[i].pBufferInfo == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003248 skip |= LogError(device, "VUID-VkWriteDescriptorSet-descriptorType-00324",
3249 "%s(): if pDescriptorWrites[%d].descriptorType is "
3250 "VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER, VK_DESCRIPTOR_TYPE_STORAGE_BUFFER, "
3251 "VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC or VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC, "
3252 "pDescriptorWrites[%d].pBufferInfo must not be NULL.",
3253 vkCallingFunction, i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003254 } else {
Jeff Bolz165818a2020-05-08 11:19:03 -05003255 const auto *robustness2_features =
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003256 LvlFindInChain<VkPhysicalDeviceRobustness2FeaturesEXT>(device_createinfo_pnext);
Jeff Bolz165818a2020-05-08 11:19:03 -05003257 if (robustness2_features && robustness2_features->nullDescriptor) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003258 for (uint32_t descriptor_index = 0; descriptor_index < pDescriptorWrites[i].descriptorCount;
3259 ++descriptor_index) {
3260 if (pDescriptorWrites[i].pBufferInfo[descriptor_index].buffer == VK_NULL_HANDLE &&
3261 (pDescriptorWrites[i].pBufferInfo[descriptor_index].offset != 0 ||
3262 pDescriptorWrites[i].pBufferInfo[descriptor_index].range != VK_WHOLE_SIZE)) {
Jeff Bolz165818a2020-05-08 11:19:03 -05003263 skip |= LogError(device, "VUID-VkDescriptorBufferInfo-buffer-02999",
3264 "%s(): if pDescriptorWrites[%d].buffer is VK_NULL_HANDLE, "
baldurk751594b2020-09-09 09:41:02 +01003265 "offset (%" PRIu64 ") must be zero and range (%" PRIu64 ") must be VK_WHOLE_SIZE.",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003266 vkCallingFunction, i, pDescriptorWrites[i].pBufferInfo[descriptor_index].offset,
3267 pDescriptorWrites[i].pBufferInfo[descriptor_index].range);
Jeff Bolz165818a2020-05-08 11:19:03 -05003268 }
3269 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003270 }
3271 }
3272 } else if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER) ||
3273 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER)) {
Jeff Bolz165818a2020-05-08 11:19:03 -05003274 // Valid bufferView handles are checked in ObjectLifetimes::ValidateDescriptorWrite.
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003275 }
3276
3277 if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER) ||
3278 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC)) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003279 VkDeviceSize uniform_alignment = device_limits.minUniformBufferOffsetAlignment;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003280 for (uint32_t j = 0; j < pDescriptorWrites[i].descriptorCount; j++) {
3281 if (pDescriptorWrites[i].pBufferInfo != NULL) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003282 if (SafeModulo(pDescriptorWrites[i].pBufferInfo[j].offset, uniform_alignment) != 0) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06003283 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003284 LogError(device, "VUID-VkWriteDescriptorSet-descriptorType-00327",
3285 "%s(): pDescriptorWrites[%d].pBufferInfo[%d].offset (0x%" PRIxLEAST64
3286 ") must be a multiple of device limit minUniformBufferOffsetAlignment 0x%" PRIxLEAST64 ".",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003287 vkCallingFunction, i, j, pDescriptorWrites[i].pBufferInfo[j].offset, uniform_alignment);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003288 }
3289 }
3290 }
3291 } else if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER) ||
3292 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC)) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003293 VkDeviceSize storage_alignment = device_limits.minStorageBufferOffsetAlignment;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003294 for (uint32_t j = 0; j < pDescriptorWrites[i].descriptorCount; j++) {
3295 if (pDescriptorWrites[i].pBufferInfo != NULL) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003296 if (SafeModulo(pDescriptorWrites[i].pBufferInfo[j].offset, storage_alignment) != 0) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06003297 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003298 LogError(device, "VUID-VkWriteDescriptorSet-descriptorType-00328",
3299 "%s(): pDescriptorWrites[%d].pBufferInfo[%d].offset (0x%" PRIxLEAST64
3300 ") must be a multiple of device limit minStorageBufferOffsetAlignment 0x%" PRIxLEAST64 ".",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003301 vkCallingFunction, i, j, pDescriptorWrites[i].pBufferInfo[j].offset, storage_alignment);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003302 }
3303 }
3304 }
3305 }
sourav parmara96ab1a2020-04-25 16:28:23 -07003306 // pNext chain must be either NULL or a pointer to a valid instance of VkWriteDescriptorSetAccelerationStructureKHR
3307 // or VkWriteDescriptorSetInlineUniformBlockEX
sourav parmarbcee7512020-12-28 14:34:49 -08003308 if (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_ACCELERATION_STRUCTURE_KHR) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003309 const auto *pnext_struct = LvlFindInChain<VkWriteDescriptorSetAccelerationStructureKHR>(pDescriptorWrites[i].pNext);
sourav parmarbcee7512020-12-28 14:34:49 -08003310 if (!pnext_struct || (pnext_struct->accelerationStructureCount != pDescriptorWrites[i].descriptorCount)) {
3311 skip |= LogError(device, "VUID-VkWriteDescriptorSet-descriptorType-02382",
3312 "%s(): If descriptorType is VK_DESCRIPTOR_TYPE_ACCELERATION_STRUCTURE_KHR, the pNext"
3313 "chain must include a VkWriteDescriptorSetAccelerationStructureKHR structure whose "
3314 "accelerationStructureCount %d member equals descriptorCount %d.",
3315 vkCallingFunction, pnext_struct ? pnext_struct->accelerationStructureCount : -1,
3316 pDescriptorWrites[i].descriptorCount);
3317 }
3318 // further checks only if we have right structtype
3319 if (pnext_struct) {
3320 if (pnext_struct->accelerationStructureCount != pDescriptorWrites[i].descriptorCount) {
3321 skip |= LogError(
3322 device, "VUID-VkWriteDescriptorSetAccelerationStructureKHR-accelerationStructureCount-02236",
3323 "%s(): accelerationStructureCount %d must be equal to descriptorCount %d in the extended structure "
3324 ".",
3325 vkCallingFunction, pnext_struct->accelerationStructureCount, pDescriptorWrites[i].descriptorCount);
sourav parmara96ab1a2020-04-25 16:28:23 -07003326 }
sourav parmarbcee7512020-12-28 14:34:49 -08003327 if (pnext_struct->accelerationStructureCount == 0) {
3328 skip |= LogError(device,
3329 "VUID-VkWriteDescriptorSetAccelerationStructureKHR-accelerationStructureCount-arraylength",
3330 "%s(): accelerationStructureCount must be greater than 0 .");
3331 }
3332 const auto *robustness2_features =
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003333 LvlFindInChain<VkPhysicalDeviceRobustness2FeaturesEXT>(device_createinfo_pnext);
sourav parmarbcee7512020-12-28 14:34:49 -08003334 if (robustness2_features && robustness2_features->nullDescriptor == VK_FALSE) {
3335 for (uint32_t j = 0; j < pnext_struct->accelerationStructureCount; ++j) {
3336 if (pnext_struct->pAccelerationStructures[j] == VK_NULL_HANDLE) {
3337 skip |= LogError(device,
3338 "VUID-VkWriteDescriptorSetAccelerationStructureKHR-pAccelerationStructures-03580",
3339 "%s(): If the nullDescriptor feature is not enabled, each member of "
3340 "pAccelerationStructures must not be VK_NULL_HANDLE.");
sourav parmarcd5fb182020-07-17 12:58:44 -07003341 }
3342 }
3343 }
sourav parmarbcee7512020-12-28 14:34:49 -08003344 }
3345 } else if (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_ACCELERATION_STRUCTURE_NV) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003346 const auto *pnext_struct = LvlFindInChain<VkWriteDescriptorSetAccelerationStructureNV>(pDescriptorWrites[i].pNext);
sourav parmarbcee7512020-12-28 14:34:49 -08003347 if (!pnext_struct || (pnext_struct->accelerationStructureCount != pDescriptorWrites[i].descriptorCount)) {
3348 skip |= LogError(device, "VUID-VkWriteDescriptorSet-descriptorType-03817",
3349 "%s(): If descriptorType is VK_DESCRIPTOR_TYPE_ACCELERATION_STRUCTURE_NV, the pNext"
3350 "chain must include a VkWriteDescriptorSetAccelerationStructureNV structure whose "
3351 "accelerationStructureCount %d member equals descriptorCount %d.",
3352 vkCallingFunction, pnext_struct ? pnext_struct->accelerationStructureCount : -1,
3353 pDescriptorWrites[i].descriptorCount);
3354 }
3355 // further checks only if we have right structtype
3356 if (pnext_struct) {
3357 if (pnext_struct->accelerationStructureCount != pDescriptorWrites[i].descriptorCount) {
3358 skip |= LogError(
3359 device, "VUID-VkWriteDescriptorSetAccelerationStructureNV-accelerationStructureCount-03747",
3360 "%s(): accelerationStructureCount %d must be equal to descriptorCount %d in the extended structure "
3361 ".",
3362 vkCallingFunction, pnext_struct->accelerationStructureCount, pDescriptorWrites[i].descriptorCount);
sourav parmarcd5fb182020-07-17 12:58:44 -07003363 }
sourav parmarbcee7512020-12-28 14:34:49 -08003364 if (pnext_struct->accelerationStructureCount == 0) {
3365 skip |= LogError(device,
3366 "VUID-VkWriteDescriptorSetAccelerationStructureNV-accelerationStructureCount-arraylength",
3367 "%s(): accelerationStructureCount must be greater than 0 .");
3368 }
3369 const auto *robustness2_features =
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003370 LvlFindInChain<VkPhysicalDeviceRobustness2FeaturesEXT>(device_createinfo_pnext);
sourav parmarbcee7512020-12-28 14:34:49 -08003371 if (robustness2_features && robustness2_features->nullDescriptor == VK_FALSE) {
3372 for (uint32_t j = 0; j < pnext_struct->accelerationStructureCount; ++j) {
3373 if (pnext_struct->pAccelerationStructures[j] == VK_NULL_HANDLE) {
3374 skip |= LogError(device,
3375 "VUID-VkWriteDescriptorSetAccelerationStructureNV-pAccelerationStructures-03749",
3376 "%s(): If the nullDescriptor feature is not enabled, each member of "
3377 "pAccelerationStructures must not be VK_NULL_HANDLE.");
sourav parmarcd5fb182020-07-17 12:58:44 -07003378 }
3379 }
sourav parmara96ab1a2020-04-25 16:28:23 -07003380 }
3381 }
3382 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003383 }
3384 }
3385 return skip;
3386}
3387
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07003388bool StatelessValidation::manual_PreCallValidateUpdateDescriptorSets(VkDevice device, uint32_t descriptorWriteCount,
3389 const VkWriteDescriptorSet *pDescriptorWrites,
3390 uint32_t descriptorCopyCount,
3391 const VkCopyDescriptorSet *pDescriptorCopies) const {
3392 return validate_WriteDescriptorSet("vkUpdateDescriptorSets", descriptorWriteCount, pDescriptorWrites);
3393}
3394
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003395bool StatelessValidation::manual_PreCallValidateCreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo,
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003396 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003397 VkRenderPass *pRenderPass) const {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003398 return CreateRenderPassGeneric(device, pCreateInfo, pAllocator, pRenderPass, RENDER_PASS_VERSION_1);
3399}
3400
sfricke-samsung681ab7b2020-10-29 01:53:35 -07003401bool StatelessValidation::manual_PreCallValidateCreateRenderPass2(VkDevice device, const VkRenderPassCreateInfo2 *pCreateInfo,
3402 const VkAllocationCallbacks *pAllocator,
3403 VkRenderPass *pRenderPass) const {
3404 return CreateRenderPassGeneric(device, pCreateInfo, pAllocator, pRenderPass, RENDER_PASS_VERSION_2);
3405}
3406
Mike Schuchardt2df08912020-12-15 16:28:09 -08003407bool StatelessValidation::manual_PreCallValidateCreateRenderPass2KHR(VkDevice device, const VkRenderPassCreateInfo2 *pCreateInfo,
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003408 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003409 VkRenderPass *pRenderPass) const {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003410 return CreateRenderPassGeneric(device, pCreateInfo, pAllocator, pRenderPass, RENDER_PASS_VERSION_2);
3411}
3412
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003413bool StatelessValidation::manual_PreCallValidateFreeCommandBuffers(VkDevice device, VkCommandPool commandPool,
3414 uint32_t commandBufferCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003415 const VkCommandBuffer *pCommandBuffers) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003416 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003417
3418 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
3419 // This is an array of handles, where the elements are allowed to be VK_NULL_HANDLE, and does not require any validation beyond
3420 // validate_array()
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003421 skip |= validate_array("vkFreeCommandBuffers", "commandBufferCount", "pCommandBuffers", commandBufferCount, &pCommandBuffers,
3422 true, true, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003423 return skip;
3424}
3425
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003426bool StatelessValidation::manual_PreCallValidateBeginCommandBuffer(VkCommandBuffer commandBuffer,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003427 const VkCommandBufferBeginInfo *pBeginInfo) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003428 bool skip = false;
Petr Krause7bb9e82019-08-11 21:34:43 +02003429
3430 // VkCommandBufferInheritanceInfo validation, due to a 'noautovalidity' of pBeginInfo->pInheritanceInfo in vkBeginCommandBuffer
3431 const char *cmd_name = "vkBeginCommandBuffer";
Tony-LunarG3c287f62020-12-17 12:39:49 -07003432 bool cb_is_secondary;
3433 {
3434 auto lock = cb_read_lock();
3435 cb_is_secondary = (secondary_cb_map.find(commandBuffer) != secondary_cb_map.end());
3436 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003437
Tony-LunarG3c287f62020-12-17 12:39:49 -07003438 if (cb_is_secondary) {
3439 // Implicit VUs
3440 // validate only sType here; pointer has to be validated in core_validation
3441 const bool k_not_required = false;
3442 const char *k_no_vuid = nullptr;
3443 const VkCommandBufferInheritanceInfo *info = pBeginInfo->pInheritanceInfo;
3444 skip |= validate_struct_type(cmd_name, "pBeginInfo->pInheritanceInfo", "VK_STRUCTURE_TYPE_COMMAND_BUFFER_INHERITANCE_INFO",
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003445 info, VK_STRUCTURE_TYPE_COMMAND_BUFFER_INHERITANCE_INFO, k_not_required, k_no_vuid,
3446 "VUID-VkCommandBufferInheritanceInfo-sType-sType");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003447
Tony-LunarG3c287f62020-12-17 12:39:49 -07003448 if (info) {
3449 const VkStructureType allowed_structs_vk_command_buffer_inheritance_info[] = {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003450 VK_STRUCTURE_TYPE_COMMAND_BUFFER_INHERITANCE_CONDITIONAL_RENDERING_INFO_EXT};
Tony-LunarG3c287f62020-12-17 12:39:49 -07003451 skip |= validate_struct_pnext(
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003452 cmd_name, "pBeginInfo->pInheritanceInfo->pNext", "VkCommandBufferInheritanceConditionalRenderingInfoEXT",
3453 info->pNext, ARRAY_SIZE(allowed_structs_vk_command_buffer_inheritance_info),
3454 allowed_structs_vk_command_buffer_inheritance_info, GeneratedVulkanHeaderVersion,
3455 "VUID-VkCommandBufferInheritanceInfo-pNext-pNext", "VUID-VkCommandBufferInheritanceInfo-sType-unique");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003456
Tony-LunarG3c287f62020-12-17 12:39:49 -07003457 skip |= validate_bool32(cmd_name, "pBeginInfo->pInheritanceInfo->occlusionQueryEnable", info->occlusionQueryEnable);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003458
Tony-LunarG3c287f62020-12-17 12:39:49 -07003459 // Explicit VUs
3460 if (!physical_device_features.inheritedQueries && info->occlusionQueryEnable == VK_TRUE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003461 skip |= LogError(
Tony-LunarG3c287f62020-12-17 12:39:49 -07003462 commandBuffer, "VUID-VkCommandBufferInheritanceInfo-occlusionQueryEnable-00056",
3463 "%s: Inherited queries feature is disabled, but pBeginInfo->pInheritanceInfo->occlusionQueryEnable is VK_TRUE.",
3464 cmd_name);
3465 }
3466
3467 if (physical_device_features.inheritedQueries) {
3468 skip |= validate_flags(cmd_name, "pBeginInfo->pInheritanceInfo->queryFlags", "VkQueryControlFlagBits",
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003469 AllVkQueryControlFlagBits, info->queryFlags, kOptionalFlags,
3470 "VUID-VkCommandBufferInheritanceInfo-queryFlags-00057");
3471 } else { // !inheritedQueries
Tony-LunarG3c287f62020-12-17 12:39:49 -07003472 skip |= validate_reserved_flags(cmd_name, "pBeginInfo->pInheritanceInfo->queryFlags", info->queryFlags,
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003473 "VUID-VkCommandBufferInheritanceInfo-queryFlags-02788");
Tony-LunarG3c287f62020-12-17 12:39:49 -07003474 }
3475
3476 if (physical_device_features.pipelineStatisticsQuery) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003477 skip |=
3478 validate_flags(cmd_name, "pBeginInfo->pInheritanceInfo->pipelineStatistics", "VkQueryPipelineStatisticFlagBits",
3479 AllVkQueryPipelineStatisticFlagBits, info->pipelineStatistics, kOptionalFlags,
3480 "VUID-VkCommandBufferInheritanceInfo-pipelineStatistics-02789");
3481 } else { // !pipelineStatisticsQuery
3482 skip |=
3483 validate_reserved_flags(cmd_name, "pBeginInfo->pInheritanceInfo->pipelineStatistics", info->pipelineStatistics,
3484 "VUID-VkCommandBufferInheritanceInfo-pipelineStatistics-00058");
Tony-LunarG3c287f62020-12-17 12:39:49 -07003485 }
3486
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003487 const auto *conditional_rendering = LvlFindInChain<VkCommandBufferInheritanceConditionalRenderingInfoEXT>(info->pNext);
Tony-LunarG3c287f62020-12-17 12:39:49 -07003488 if (conditional_rendering) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003489 const auto *cr_features = LvlFindInChain<VkPhysicalDeviceConditionalRenderingFeaturesEXT>(device_createinfo_pnext);
Tony-LunarG3c287f62020-12-17 12:39:49 -07003490 const auto inherited_conditional_rendering = cr_features && cr_features->inheritedConditionalRendering;
3491 if (!inherited_conditional_rendering && conditional_rendering->conditionalRenderingEnable == VK_TRUE) {
3492 skip |= LogError(
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003493 commandBuffer,
3494 "VUID-VkCommandBufferInheritanceConditionalRenderingInfoEXT-conditionalRenderingEnable-01977",
Tony-LunarG3c287f62020-12-17 12:39:49 -07003495 "vkBeginCommandBuffer: Inherited conditional rendering is disabled, but "
3496 "pBeginInfo->pInheritanceInfo->pNext<VkCommandBufferInheritanceConditionalRenderingInfoEXT> is VK_TRUE.");
3497 }
Petr Kraus139757b2019-08-15 17:19:33 +02003498 }
3499 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003500 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003501 return skip;
3502}
3503
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003504bool StatelessValidation::manual_PreCallValidateCmdSetViewport(VkCommandBuffer commandBuffer, uint32_t firstViewport,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003505 uint32_t viewportCount, const VkViewport *pViewports) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003506 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003507
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003508 if (!physical_device_features.multiViewport) {
Petr Krausd55e77c2018-01-09 22:09:25 +01003509 if (firstViewport != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003510 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewport-firstViewport-01224",
3511 "vkCmdSetViewport: The multiViewport feature is disabled, but firstViewport (=%" PRIu32 ") is not 0.",
3512 firstViewport);
Petr Krausd55e77c2018-01-09 22:09:25 +01003513 }
3514 if (viewportCount > 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003515 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewport-viewportCount-01225",
3516 "vkCmdSetViewport: The multiViewport feature is disabled, but viewportCount (=%" PRIu32 ") is not 1.",
3517 viewportCount);
Petr Krausd55e77c2018-01-09 22:09:25 +01003518 }
3519 } else { // multiViewport enabled
Petr Kraus7dfeed12018-02-27 20:51:20 +01003520 const uint64_t sum = static_cast<uint64_t>(firstViewport) + static_cast<uint64_t>(viewportCount);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003521 if (sum > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003522 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewport-firstViewport-01223",
3523 "vkCmdSetViewport: firstViewport + viewportCount (=%" PRIu32 " + %" PRIu32 " = %" PRIu64
3524 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
3525 firstViewport, viewportCount, sum, device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003526 }
3527 }
Petr Krausb3fcdb42018-01-09 22:09:09 +01003528
3529 if (pViewports) {
3530 for (uint32_t viewport_i = 0; viewport_i < viewportCount; ++viewport_i) {
3531 const auto &viewport = pViewports[viewport_i]; // will crash on invalid ptr
Jeff Bolz6d3beaa2019-02-09 21:00:05 -06003532 const char *fn_name = "vkCmdSetViewport";
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003533 skip |= manual_PreCallValidateViewport(
3534 viewport, fn_name, ParameterName("pViewports[%i]", ParameterName::IndexVector{viewport_i}), commandBuffer);
Petr Krausb3fcdb42018-01-09 22:09:09 +01003535 }
3536 }
3537
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003538 return skip;
3539}
3540
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003541bool StatelessValidation::manual_PreCallValidateCmdSetScissor(VkCommandBuffer commandBuffer, uint32_t firstScissor,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003542 uint32_t scissorCount, const VkRect2D *pScissors) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003543 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003544
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003545 if (!physical_device_features.multiViewport) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003546 if (firstScissor != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003547 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-firstScissor-00593",
3548 "vkCmdSetScissor: The multiViewport feature is disabled, but firstScissor (=%" PRIu32 ") is not 0.",
3549 firstScissor);
Petr Kraus6260f0a2018-02-27 21:15:55 +01003550 }
3551 if (scissorCount > 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003552 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-scissorCount-00594",
3553 "vkCmdSetScissor: The multiViewport feature is disabled, but scissorCount (=%" PRIu32 ") is not 1.",
3554 scissorCount);
Petr Kraus6260f0a2018-02-27 21:15:55 +01003555 }
3556 } else { // multiViewport enabled
3557 const uint64_t sum = static_cast<uint64_t>(firstScissor) + static_cast<uint64_t>(scissorCount);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003558 if (sum > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003559 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-firstScissor-00592",
3560 "vkCmdSetScissor: firstScissor + scissorCount (=%" PRIu32 " + %" PRIu32 " = %" PRIu64
3561 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
3562 firstScissor, scissorCount, sum, device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003563 }
3564 }
3565
Petr Kraus6260f0a2018-02-27 21:15:55 +01003566 if (pScissors) {
3567 for (uint32_t scissor_i = 0; scissor_i < scissorCount; ++scissor_i) {
3568 const auto &scissor = pScissors[scissor_i]; // will crash on invalid ptr
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003569
Petr Kraus6260f0a2018-02-27 21:15:55 +01003570 if (scissor.offset.x < 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003571 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-x-00595",
3572 "vkCmdSetScissor: pScissors[%" PRIu32 "].offset.x (=%" PRIi32 ") is negative.", scissor_i,
3573 scissor.offset.x);
Petr Kraus6260f0a2018-02-27 21:15:55 +01003574 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003575
Petr Kraus6260f0a2018-02-27 21:15:55 +01003576 if (scissor.offset.y < 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003577 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-x-00595",
3578 "vkCmdSetScissor: pScissors[%" PRIu32 "].offset.y (=%" PRIi32 ") is negative.", scissor_i,
3579 scissor.offset.y);
Petr Kraus6260f0a2018-02-27 21:15:55 +01003580 }
3581
3582 const int64_t x_sum = static_cast<int64_t>(scissor.offset.x) + static_cast<int64_t>(scissor.extent.width);
3583 if (x_sum > INT32_MAX) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003584 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-offset-00596",
3585 "vkCmdSetScissor: offset.x + extent.width (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
3586 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
3587 scissor.offset.x, scissor.extent.width, x_sum, scissor_i);
Petr Kraus6260f0a2018-02-27 21:15:55 +01003588 }
3589
3590 const int64_t y_sum = static_cast<int64_t>(scissor.offset.y) + static_cast<int64_t>(scissor.extent.height);
3591 if (y_sum > INT32_MAX) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003592 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-offset-00597",
3593 "vkCmdSetScissor: offset.y + extent.height (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
3594 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
3595 scissor.offset.y, scissor.extent.height, y_sum, scissor_i);
Petr Kraus6260f0a2018-02-27 21:15:55 +01003596 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003597 }
3598 }
Petr Kraus6260f0a2018-02-27 21:15:55 +01003599
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003600 return skip;
3601}
3602
Jeff Bolz5c801d12019-10-09 10:38:45 -05003603bool StatelessValidation::manual_PreCallValidateCmdSetLineWidth(VkCommandBuffer commandBuffer, float lineWidth) const {
Petr Kraus299ba622017-11-24 03:09:03 +01003604 bool skip = false;
Petr Kraus299ba622017-11-24 03:09:03 +01003605
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003606 if (!physical_device_features.wideLines && (lineWidth != 1.0f)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003607 skip |= LogError(commandBuffer, "VUID-vkCmdSetLineWidth-lineWidth-00788",
3608 "VkPhysicalDeviceFeatures::wideLines is disabled, but lineWidth (=%f) is not 1.0.", lineWidth);
Petr Kraus299ba622017-11-24 03:09:03 +01003609 }
3610
3611 return skip;
3612}
3613
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003614bool StatelessValidation::manual_PreCallValidateCmdDrawIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset,
Tony-LunarGc0c3df52020-11-20 13:47:10 -07003615 uint32_t drawCount, uint32_t stride) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003616 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003617
Tony-LunarGc0c3df52020-11-20 13:47:10 -07003618 if (!physical_device_features.multiDrawIndirect && ((drawCount > 1))) {
Mark Lobodzinski41ce65b2020-10-30 12:17:06 -06003619 skip |= LogError(device, "VUID-vkCmdDrawIndirect-drawCount-02718",
Tony-LunarGc0c3df52020-11-20 13:47:10 -07003620 "CmdDrawIndirect(): Device feature multiDrawIndirect disabled: count must be 0 or 1 but is %d", drawCount);
3621 }
3622 if (drawCount > device_limits.maxDrawIndirectCount) {
3623 skip |= LogError(commandBuffer, "VUID-vkCmdDrawIndirect-drawCount-02719",
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003624 "CmdDrawIndirect(): drawCount (%u) is not less than or equal to the maximum allowed (%u).", drawCount,
3625 device_limits.maxDrawIndirectCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003626 }
3627 return skip;
3628}
3629
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003630bool StatelessValidation::manual_PreCallValidateCmdDrawIndexedIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer,
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003631 VkDeviceSize offset, uint32_t drawCount,
3632 uint32_t stride) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003633 bool skip = false;
Tony-LunarGc0c3df52020-11-20 13:47:10 -07003634 if (!physical_device_features.multiDrawIndirect && ((drawCount > 1))) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003635 skip |= LogError(device, "VUID-vkCmdDrawIndexedIndirect-drawCount-02718",
3636 "CmdDrawIndexedIndirect(): Device feature multiDrawIndirect disabled: count must be 0 or 1 but is %d",
3637 drawCount);
Tony-LunarGc0c3df52020-11-20 13:47:10 -07003638 }
3639 if (drawCount > device_limits.maxDrawIndirectCount) {
3640 skip |= LogError(commandBuffer, "VUID-vkCmdDrawIndexedIndirect-drawCount-02719",
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003641 "CmdDrawIndexedIndirect(): drawCount (%u) is not less than or equal to the maximum allowed (%u).",
3642 drawCount, device_limits.maxDrawIndirectCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003643 }
3644 return skip;
3645}
3646
sfricke-samsungf692b972020-05-02 08:00:45 -07003647bool StatelessValidation::ValidateCmdDrawIndirectCount(VkCommandBuffer commandBuffer, VkDeviceSize offset,
3648 VkDeviceSize countBufferOffset, bool khr) const {
3649 bool skip = false;
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003650 const char *api_name = khr ? "vkCmdDrawIndirectCountKHR()" : "vkCmdDrawIndirectCount()";
sfricke-samsungf692b972020-05-02 08:00:45 -07003651 if (offset & 3) {
3652 skip |= LogError(commandBuffer, "VUID-vkCmdDrawIndirectCount-offset-02710",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003653 "%s: parameter, VkDeviceSize offset (0x%" PRIxLEAST64 "), is not a multiple of 4.", api_name, offset);
sfricke-samsungf692b972020-05-02 08:00:45 -07003654 }
3655
3656 if (countBufferOffset & 3) {
3657 skip |= LogError(commandBuffer, "VUID-vkCmdDrawIndirectCount-countBufferOffset-02716",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003658 "%s: parameter, VkDeviceSize countBufferOffset (0x%" PRIxLEAST64 "), is not a multiple of 4.", api_name,
sfricke-samsungf692b972020-05-02 08:00:45 -07003659 countBufferOffset);
3660 }
3661 return skip;
3662}
3663
3664bool StatelessValidation::manual_PreCallValidateCmdDrawIndirectCount(VkCommandBuffer commandBuffer, VkBuffer buffer,
3665 VkDeviceSize offset, VkBuffer countBuffer,
3666 VkDeviceSize countBufferOffset, uint32_t maxDrawCount,
3667 uint32_t stride) const {
3668 return ValidateCmdDrawIndirectCount(commandBuffer, offset, countBufferOffset, false);
3669}
3670
3671bool StatelessValidation::manual_PreCallValidateCmdDrawIndirectCountKHR(VkCommandBuffer commandBuffer, VkBuffer buffer,
3672 VkDeviceSize offset, VkBuffer countBuffer,
3673 VkDeviceSize countBufferOffset, uint32_t maxDrawCount,
3674 uint32_t stride) const {
3675 return ValidateCmdDrawIndirectCount(commandBuffer, offset, countBufferOffset, true);
3676}
3677
3678bool StatelessValidation::ValidateCmdDrawIndexedIndirectCount(VkCommandBuffer commandBuffer, VkDeviceSize offset,
3679 VkDeviceSize countBufferOffset, bool khr) const {
3680 bool skip = false;
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003681 const char *api_name = khr ? "vkCmdDrawIndexedIndirectCountKHR()" : "vkCmdDrawIndexedIndirectCount()";
sfricke-samsungf692b972020-05-02 08:00:45 -07003682 if (offset & 3) {
3683 skip |= LogError(commandBuffer, "VUID-vkCmdDrawIndexedIndirectCount-offset-02710",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003684 "%s: parameter, VkDeviceSize offset (0x%" PRIxLEAST64 "), is not a multiple of 4.", api_name, offset);
sfricke-samsungf692b972020-05-02 08:00:45 -07003685 }
3686
3687 if (countBufferOffset & 3) {
3688 skip |= LogError(commandBuffer, "VUID-vkCmdDrawIndexedIndirectCount-countBufferOffset-02716",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003689 "%s: parameter, VkDeviceSize countBufferOffset (0x%" PRIxLEAST64 "), is not a multiple of 4.", api_name,
sfricke-samsungf692b972020-05-02 08:00:45 -07003690 countBufferOffset);
3691 }
3692 return skip;
3693}
3694
3695bool StatelessValidation::manual_PreCallValidateCmdDrawIndexedIndirectCount(VkCommandBuffer commandBuffer, VkBuffer buffer,
3696 VkDeviceSize offset, VkBuffer countBuffer,
3697 VkDeviceSize countBufferOffset, uint32_t maxDrawCount,
3698 uint32_t stride) const {
3699 return ValidateCmdDrawIndexedIndirectCount(commandBuffer, offset, countBufferOffset, false);
3700}
3701
3702bool StatelessValidation::manual_PreCallValidateCmdDrawIndexedIndirectCountKHR(VkCommandBuffer commandBuffer, VkBuffer buffer,
3703 VkDeviceSize offset, VkBuffer countBuffer,
3704 VkDeviceSize countBufferOffset,
3705 uint32_t maxDrawCount, uint32_t stride) const {
3706 return ValidateCmdDrawIndexedIndirectCount(commandBuffer, offset, countBufferOffset, true);
3707}
3708
Mark Lobodzinskif77a4ac2019-06-27 15:30:51 -06003709bool StatelessValidation::manual_PreCallValidateCmdClearAttachments(VkCommandBuffer commandBuffer, uint32_t attachmentCount,
3710 const VkClearAttachment *pAttachments, uint32_t rectCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003711 const VkClearRect *pRects) const {
Mark Lobodzinskif77a4ac2019-06-27 15:30:51 -06003712 bool skip = false;
3713 for (uint32_t rect = 0; rect < rectCount; rect++) {
3714 if (pRects[rect].layerCount == 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003715 skip |= LogError(commandBuffer, "VUID-vkCmdClearAttachments-layerCount-01934",
3716 "CmdClearAttachments(): pRects[%d].layerCount is zero.", rect);
Mark Lobodzinskif77a4ac2019-06-27 15:30:51 -06003717 }
sfricke-samsung10867682020-04-25 02:20:39 -07003718 if (pRects[rect].rect.extent.width == 0) {
3719 skip |= LogError(commandBuffer, "VUID-vkCmdClearAttachments-rect-02682",
3720 "CmdClearAttachments(): pRects[%d].rect.extent.width is zero.", rect);
3721 }
3722 if (pRects[rect].rect.extent.height == 0) {
3723 skip |= LogError(commandBuffer, "VUID-vkCmdClearAttachments-rect-02683",
3724 "CmdClearAttachments(): pRects[%d].rect.extent.height is zero.", rect);
3725 }
Mark Lobodzinskif77a4ac2019-06-27 15:30:51 -06003726 }
3727 return skip;
3728}
3729
Andrew Fobel3abeb992020-01-20 16:33:22 -05003730bool StatelessValidation::ValidateGetPhysicalDeviceImageFormatProperties2(VkPhysicalDevice physicalDevice,
3731 const VkPhysicalDeviceImageFormatInfo2 *pImageFormatInfo,
3732 VkImageFormatProperties2 *pImageFormatProperties,
3733 const char *apiName) const {
3734 bool skip = false;
3735
3736 if (pImageFormatInfo != nullptr) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003737 const auto image_stencil_struct = LvlFindInChain<VkImageStencilUsageCreateInfo>(pImageFormatInfo->pNext);
Andrew Fobel3abeb992020-01-20 16:33:22 -05003738 if (image_stencil_struct != nullptr) {
3739 if ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT) != 0) {
3740 VkImageUsageFlags legal_flags = (VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT | VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT);
3741 // No flags other than the legal attachment bits may be set
3742 legal_flags |= VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT;
3743 if ((image_stencil_struct->stencilUsage & ~legal_flags) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003744 skip |= LogError(physicalDevice, "VUID-VkImageStencilUsageCreateInfo-stencilUsage-02539",
3745 "%s(): in pNext chain, VkImageStencilUsageCreateInfo::stencilUsage "
3746 "includes VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT, it must not include bits other than "
3747 "VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT or VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT",
3748 apiName);
Andrew Fobel3abeb992020-01-20 16:33:22 -05003749 }
3750 }
3751 }
3752 }
3753
3754 return skip;
3755}
3756
3757bool StatelessValidation::manual_PreCallValidateGetPhysicalDeviceImageFormatProperties2(
3758 VkPhysicalDevice physicalDevice, const VkPhysicalDeviceImageFormatInfo2 *pImageFormatInfo,
3759 VkImageFormatProperties2 *pImageFormatProperties) const {
3760 return ValidateGetPhysicalDeviceImageFormatProperties2(physicalDevice, pImageFormatInfo, pImageFormatProperties,
3761 "vkGetPhysicalDeviceImageFormatProperties2");
3762}
3763
3764bool StatelessValidation::manual_PreCallValidateGetPhysicalDeviceImageFormatProperties2KHR(
3765 VkPhysicalDevice physicalDevice, const VkPhysicalDeviceImageFormatInfo2 *pImageFormatInfo,
3766 VkImageFormatProperties2 *pImageFormatProperties) const {
3767 return ValidateGetPhysicalDeviceImageFormatProperties2(physicalDevice, pImageFormatInfo, pImageFormatProperties,
3768 "vkGetPhysicalDeviceImageFormatProperties2KHR");
3769}
3770
Lionel Landwerlin5fe52752020-07-22 08:18:14 +03003771bool StatelessValidation::manual_PreCallValidateGetPhysicalDeviceImageFormatProperties(
3772 VkPhysicalDevice physicalDevice, VkFormat format, VkImageType type, VkImageTiling tiling, VkImageUsageFlags usage,
3773 VkImageCreateFlags flags, VkImageFormatProperties *pImageFormatProperties) const {
3774 bool skip = false;
3775
3776 if (tiling == VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT) {
3777 skip |= LogError(physicalDevice, "VUID-vkGetPhysicalDeviceImageFormatProperties-tiling-02248",
3778 "vkGetPhysicalDeviceImageFormatProperties(): tiling must not be VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT.");
3779 }
3780
3781 return skip;
3782}
3783
sfricke-samsung3999ef62020-02-09 17:05:59 -08003784bool StatelessValidation::manual_PreCallValidateCmdCopyBuffer(VkCommandBuffer commandBuffer, VkBuffer srcBuffer, VkBuffer dstBuffer,
3785 uint32_t regionCount, const VkBufferCopy *pRegions) const {
3786 bool skip = false;
3787
3788 if (pRegions != nullptr) {
3789 for (uint32_t i = 0; i < regionCount; i++) {
3790 if (pRegions[i].size == 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003791 skip |= LogError(device, "VUID-VkBufferCopy-size-01988",
3792 "vkCmdCopyBuffer() pRegions[%u].size must be greater than zero", i);
sfricke-samsung3999ef62020-02-09 17:05:59 -08003793 }
3794 }
3795 }
3796 return skip;
3797}
3798
Jeff Leger178b1e52020-10-05 12:22:23 -04003799bool StatelessValidation::manual_PreCallValidateCmdCopyBuffer2KHR(VkCommandBuffer commandBuffer,
3800 const VkCopyBufferInfo2KHR *pCopyBufferInfo) const {
3801 bool skip = false;
3802
3803 if (pCopyBufferInfo->pRegions != nullptr) {
3804 for (uint32_t i = 0; i < pCopyBufferInfo->regionCount; i++) {
3805 if (pCopyBufferInfo->pRegions[i].size == 0) {
3806 skip |= LogError(device, "VUID-VkBufferCopy2KHR-size-01988",
3807 "vkCmdCopyBuffer2KHR() pCopyBufferInfo->pRegions[%u].size must be greater than zero", i);
3808 }
3809 }
3810 }
3811 return skip;
3812}
3813
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003814bool StatelessValidation::manual_PreCallValidateCmdUpdateBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003815 VkDeviceSize dstOffset, VkDeviceSize dataSize,
3816 const void *pData) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003817 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003818
3819 if (dstOffset & 3) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003820 skip |= LogError(device, "VUID-vkCmdUpdateBuffer-dstOffset-00036",
3821 "vkCmdUpdateBuffer() parameter, VkDeviceSize dstOffset (0x%" PRIxLEAST64 "), is not a multiple of 4.",
3822 dstOffset);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003823 }
3824
3825 if ((dataSize <= 0) || (dataSize > 65536)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003826 skip |= LogError(device, "VUID-vkCmdUpdateBuffer-dataSize-00037",
3827 "vkCmdUpdateBuffer() parameter, VkDeviceSize dataSize (0x%" PRIxLEAST64
3828 "), must be greater than zero and less than or equal to 65536.",
3829 dataSize);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003830 } else if (dataSize & 3) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003831 skip |= LogError(device, "VUID-vkCmdUpdateBuffer-dataSize-00038",
3832 "vkCmdUpdateBuffer() parameter, VkDeviceSize dataSize (0x%" PRIxLEAST64 "), is not a multiple of 4.",
3833 dataSize);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003834 }
3835 return skip;
3836}
3837
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003838bool StatelessValidation::manual_PreCallValidateCmdFillBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003839 VkDeviceSize dstOffset, VkDeviceSize size, uint32_t data) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003840 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003841
3842 if (dstOffset & 3) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003843 skip |= LogError(device, "VUID-vkCmdFillBuffer-dstOffset-00025",
3844 "vkCmdFillBuffer() parameter, VkDeviceSize dstOffset (0x%" PRIxLEAST64 "), is not a multiple of 4.",
3845 dstOffset);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003846 }
3847
3848 if (size != VK_WHOLE_SIZE) {
3849 if (size <= 0) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003850 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003851 LogError(device, "VUID-vkCmdFillBuffer-size-00026",
3852 "vkCmdFillBuffer() parameter, VkDeviceSize size (0x%" PRIxLEAST64 "), must be greater than zero.", size);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003853 } else if (size & 3) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003854 skip |= LogError(device, "VUID-vkCmdFillBuffer-size-00028",
3855 "vkCmdFillBuffer() parameter, VkDeviceSize size (0x%" PRIxLEAST64 "), is not a multiple of 4.", size);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003856 }
3857 }
3858 return skip;
3859}
3860
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003861bool StatelessValidation::manual_PreCallValidateCreateSwapchainKHR(VkDevice device, const VkSwapchainCreateInfoKHR *pCreateInfo,
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003862 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003863 VkSwapchainKHR *pSwapchain) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003864 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003865
3866 if (pCreateInfo != nullptr) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003867 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
3868 if (pCreateInfo->imageSharingMode == VK_SHARING_MODE_CONCURRENT) {
3869 // If imageSharingMode is VK_SHARING_MODE_CONCURRENT, queueFamilyIndexCount must be greater than 1
3870 if (pCreateInfo->queueFamilyIndexCount <= 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003871 skip |= LogError(device, "VUID-VkSwapchainCreateInfoKHR-imageSharingMode-01278",
3872 "vkCreateSwapchainKHR(): if pCreateInfo->imageSharingMode is VK_SHARING_MODE_CONCURRENT, "
3873 "pCreateInfo->queueFamilyIndexCount must be greater than 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003874 }
3875
3876 // If imageSharingMode is VK_SHARING_MODE_CONCURRENT, pQueueFamilyIndices must be a pointer to an array of
3877 // queueFamilyIndexCount uint32_t values
3878 if (pCreateInfo->pQueueFamilyIndices == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003879 skip |= LogError(device, "VUID-VkSwapchainCreateInfoKHR-imageSharingMode-01277",
3880 "vkCreateSwapchainKHR(): if pCreateInfo->imageSharingMode is VK_SHARING_MODE_CONCURRENT, "
3881 "pCreateInfo->pQueueFamilyIndices must be a pointer to an array of "
3882 "pCreateInfo->queueFamilyIndexCount uint32_t values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003883 }
3884 }
3885
Dave Houlton413a6782018-05-22 13:01:54 -06003886 skip |= ValidateGreaterThanZero(pCreateInfo->imageArrayLayers, "pCreateInfo->imageArrayLayers",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003887 "VUID-VkSwapchainCreateInfoKHR-imageArrayLayers-01275", "vkCreateSwapchainKHR");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003888 }
3889
3890 return skip;
3891}
3892
Jeff Bolz5c801d12019-10-09 10:38:45 -05003893bool StatelessValidation::manual_PreCallValidateQueuePresentKHR(VkQueue queue, const VkPresentInfoKHR *pPresentInfo) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003894 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003895
3896 if (pPresentInfo && pPresentInfo->pNext) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003897 const auto *present_regions = LvlFindInChain<VkPresentRegionsKHR>(pPresentInfo->pNext);
John Zulaufde972ac2017-10-26 12:07:05 -06003898 if (present_regions) {
3899 // TODO: This and all other pNext extension dependencies should be added to code-generation
Tony-LunarG2ec96bb2019-11-26 13:43:02 -07003900 skip |= require_device_extension(IsExtEnabled(device_extensions.vk_khr_incremental_present), "vkQueuePresentKHR",
John Zulaufde972ac2017-10-26 12:07:05 -06003901 VK_KHR_INCREMENTAL_PRESENT_EXTENSION_NAME);
3902 if (present_regions->swapchainCount != pPresentInfo->swapchainCount) {
sfricke-samsunga4cc4ff2020-08-23 22:05:49 -07003903 skip |= LogError(device, "VUID-VkPresentRegionsKHR-swapchainCount-01260",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003904 "QueuePresentKHR(): pPresentInfo->swapchainCount has a value of %i but VkPresentRegionsKHR "
3905 "extension swapchainCount is %i. These values must be equal.",
3906 pPresentInfo->swapchainCount, present_regions->swapchainCount);
John Zulaufde972ac2017-10-26 12:07:05 -06003907 }
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003908 skip |= validate_struct_pnext("QueuePresentKHR", "pCreateInfo->pNext->pNext", NULL, present_regions->pNext, 0, NULL,
sfricke-samsung32a27362020-02-28 09:06:42 -08003909 GeneratedVulkanHeaderVersion, "VUID-VkPresentInfoKHR-pNext-pNext",
3910 "VUID-VkPresentInfoKHR-sType-unique");
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003911 skip |= validate_array("QueuePresentKHR", "pCreateInfo->pNext->swapchainCount", "pCreateInfo->pNext->pRegions",
3912 present_regions->swapchainCount, &present_regions->pRegions, true, false, kVUIDUndefined,
3913 kVUIDUndefined);
John Zulaufde972ac2017-10-26 12:07:05 -06003914 for (uint32_t i = 0; i < present_regions->swapchainCount; ++i) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003915 skip |= validate_array("QueuePresentKHR", "pCreateInfo->pNext->pRegions[].rectangleCount",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003916 "pCreateInfo->pNext->pRegions[].pRectangles", present_regions->pRegions[i].rectangleCount,
Dave Houlton413a6782018-05-22 13:01:54 -06003917 &present_regions->pRegions[i].pRectangles, true, false, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003918 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003919 }
3920 }
3921
3922 return skip;
3923}
3924
sfricke-samsung5c1b7392020-12-13 22:17:15 -08003925bool StatelessValidation::manual_PreCallValidateCreateDisplayModeKHR(VkPhysicalDevice physicalDevice, VkDisplayKHR display,
3926 const VkDisplayModeCreateInfoKHR *pCreateInfo,
3927 const VkAllocationCallbacks *pAllocator,
3928 VkDisplayModeKHR *pMode) const {
3929 bool skip = false;
3930
3931 const VkDisplayModeParametersKHR display_mode_parameters = pCreateInfo->parameters;
3932 if (display_mode_parameters.visibleRegion.width == 0) {
3933 skip |= LogError(device, "VUID-VkDisplayModeParametersKHR-width-01990",
3934 "vkCreateDisplayModeKHR(): pCreateInfo->parameters.visibleRegion.width must be greater than 0.");
3935 }
3936 if (display_mode_parameters.visibleRegion.height == 0) {
3937 skip |= LogError(device, "VUID-VkDisplayModeParametersKHR-height-01991",
3938 "vkCreateDisplayModeKHR(): pCreateInfo->parameters.visibleRegion.height must be greater than 0.");
3939 }
3940 if (display_mode_parameters.refreshRate == 0) {
3941 skip |= LogError(device, "VUID-VkDisplayModeParametersKHR-refreshRate-01992",
3942 "vkCreateDisplayModeKHR(): pCreateInfo->parameters.refreshRate must be greater than 0.");
3943 }
3944
3945 return skip;
3946}
3947
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003948#ifdef VK_USE_PLATFORM_WIN32_KHR
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003949bool StatelessValidation::manual_PreCallValidateCreateWin32SurfaceKHR(VkInstance instance,
3950 const VkWin32SurfaceCreateInfoKHR *pCreateInfo,
3951 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003952 VkSurfaceKHR *pSurface) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003953 bool skip = false;
3954
3955 if (pCreateInfo->hwnd == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003956 skip |= LogError(device, "VUID-VkWin32SurfaceCreateInfoKHR-hwnd-01308",
3957 "vkCreateWin32SurfaceKHR(): hwnd must be a valid Win32 HWND but hwnd is NULL.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003958 }
3959
3960 return skip;
3961}
3962#endif // VK_USE_PLATFORM_WIN32_KHR
3963
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003964bool StatelessValidation::manual_PreCallValidateCreateDescriptorPool(VkDevice device, const VkDescriptorPoolCreateInfo *pCreateInfo,
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003965 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003966 VkDescriptorPool *pDescriptorPool) const {
Petr Krausc8655be2017-09-27 18:56:51 +02003967 bool skip = false;
3968
3969 if (pCreateInfo) {
3970 if (pCreateInfo->maxSets <= 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003971 skip |= LogError(device, "VUID-VkDescriptorPoolCreateInfo-maxSets-00301",
3972 "vkCreateDescriptorPool(): pCreateInfo->maxSets is not greater than 0.");
Petr Krausc8655be2017-09-27 18:56:51 +02003973 }
3974
3975 if (pCreateInfo->pPoolSizes) {
3976 for (uint32_t i = 0; i < pCreateInfo->poolSizeCount; ++i) {
3977 if (pCreateInfo->pPoolSizes[i].descriptorCount <= 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003978 skip |= LogError(
3979 device, "VUID-VkDescriptorPoolSize-descriptorCount-00302",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003980 "vkCreateDescriptorPool(): pCreateInfo->pPoolSizes[%" PRIu32 "].descriptorCount is not greater than 0.", i);
Petr Krausc8655be2017-09-27 18:56:51 +02003981 }
Jeff Bolze54ae892018-09-08 12:16:29 -05003982 if (pCreateInfo->pPoolSizes[i].type == VK_DESCRIPTOR_TYPE_INLINE_UNIFORM_BLOCK_EXT &&
3983 (pCreateInfo->pPoolSizes[i].descriptorCount % 4) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003984 skip |= LogError(device, "VUID-VkDescriptorPoolSize-type-02218",
3985 "vkCreateDescriptorPool(): pCreateInfo->pPoolSizes[%" PRIu32
3986 "].type is VK_DESCRIPTOR_TYPE_INLINE_UNIFORM_BLOCK_EXT "
3987 " and pCreateInfo->pPoolSizes[%" PRIu32 "].descriptorCount is not a multiple of 4.",
3988 i, i);
Jeff Bolze54ae892018-09-08 12:16:29 -05003989 }
Petr Krausc8655be2017-09-27 18:56:51 +02003990 }
3991 }
3992 }
3993
3994 return skip;
3995}
3996
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003997bool StatelessValidation::manual_PreCallValidateCmdDispatch(VkCommandBuffer commandBuffer, uint32_t groupCountX,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003998 uint32_t groupCountY, uint32_t groupCountZ) const {
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003999 bool skip = false;
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07004000
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004001 if (groupCountX > device_limits.maxComputeWorkGroupCount[0]) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06004002 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004003 LogError(commandBuffer, "VUID-vkCmdDispatch-groupCountX-00386",
4004 "vkCmdDispatch(): groupCountX (%" PRIu32 ") exceeds device limit maxComputeWorkGroupCount[0] (%" PRIu32 ").",
4005 groupCountX, device_limits.maxComputeWorkGroupCount[0]);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07004006 }
4007
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004008 if (groupCountY > device_limits.maxComputeWorkGroupCount[1]) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06004009 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004010 LogError(commandBuffer, "VUID-vkCmdDispatch-groupCountY-00387",
4011 "vkCmdDispatch(): groupCountY (%" PRIu32 ") exceeds device limit maxComputeWorkGroupCount[1] (%" PRIu32 ").",
4012 groupCountY, device_limits.maxComputeWorkGroupCount[1]);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07004013 }
4014
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004015 if (groupCountZ > device_limits.maxComputeWorkGroupCount[2]) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06004016 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004017 LogError(commandBuffer, "VUID-vkCmdDispatch-groupCountZ-00388",
4018 "vkCmdDispatch(): groupCountZ (%" PRIu32 ") exceeds device limit maxComputeWorkGroupCount[2] (%" PRIu32 ").",
4019 groupCountZ, device_limits.maxComputeWorkGroupCount[2]);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07004020 }
4021
4022 return skip;
4023}
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004024
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004025bool StatelessValidation::manual_PreCallValidateCmdDispatchIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004026 VkDeviceSize offset) const {
John Zulaufa999d1b2018-11-29 13:38:40 -07004027 bool skip = false;
John Zulaufa999d1b2018-11-29 13:38:40 -07004028
4029 if ((offset % 4) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004030 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchIndirect-offset-02710",
4031 "vkCmdDispatchIndirect(): offset (%" PRIu64 ") must be a multiple of 4.", offset);
John Zulaufa999d1b2018-11-29 13:38:40 -07004032 }
4033 return skip;
4034}
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07004035
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004036bool StatelessValidation::manual_PreCallValidateCmdDispatchBaseKHR(VkCommandBuffer commandBuffer, uint32_t baseGroupX,
4037 uint32_t baseGroupY, uint32_t baseGroupZ, uint32_t groupCountX,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004038 uint32_t groupCountY, uint32_t groupCountZ) const {
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07004039 bool skip = false;
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07004040
4041 // Paired if {} else if {} tests used to avoid any possible uint underflow
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004042 uint32_t limit = device_limits.maxComputeWorkGroupCount[0];
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07004043 if (baseGroupX >= limit) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004044 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchBase-baseGroupX-00421",
4045 "vkCmdDispatch(): baseGroupX (%" PRIu32
4046 ") equals or exceeds device limit maxComputeWorkGroupCount[0] (%" PRIu32 ").",
4047 baseGroupX, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07004048 } else if (groupCountX > (limit - baseGroupX)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004049 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchBase-groupCountX-00424",
4050 "vkCmdDispatchBaseKHR(): baseGroupX (%" PRIu32 ") + groupCountX (%" PRIu32
4051 ") exceeds device limit maxComputeWorkGroupCount[0] (%" PRIu32 ").",
4052 baseGroupX, groupCountX, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07004053 }
4054
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004055 limit = device_limits.maxComputeWorkGroupCount[1];
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07004056 if (baseGroupY >= limit) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004057 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchBase-baseGroupX-00422",
4058 "vkCmdDispatch(): baseGroupY (%" PRIu32
4059 ") equals or exceeds device limit maxComputeWorkGroupCount[1] (%" PRIu32 ").",
4060 baseGroupY, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07004061 } else if (groupCountY > (limit - baseGroupY)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004062 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchBase-groupCountY-00425",
4063 "vkCmdDispatchBaseKHR(): baseGroupY (%" PRIu32 ") + groupCountY (%" PRIu32
4064 ") exceeds device limit maxComputeWorkGroupCount[1] (%" PRIu32 ").",
4065 baseGroupY, groupCountY, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07004066 }
4067
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004068 limit = device_limits.maxComputeWorkGroupCount[2];
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07004069 if (baseGroupZ >= limit) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004070 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchBase-baseGroupZ-00423",
4071 "vkCmdDispatch(): baseGroupZ (%" PRIu32
4072 ") equals or exceeds device limit maxComputeWorkGroupCount[2] (%" PRIu32 ").",
4073 baseGroupZ, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07004074 } else if (groupCountZ > (limit - baseGroupZ)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004075 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchBase-groupCountZ-00426",
4076 "vkCmdDispatchBaseKHR(): baseGroupZ (%" PRIu32 ") + groupCountZ (%" PRIu32
4077 ") exceeds device limit maxComputeWorkGroupCount[2] (%" PRIu32 ").",
4078 baseGroupZ, groupCountZ, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07004079 }
4080
4081 return skip;
4082}
4083
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07004084bool StatelessValidation::manual_PreCallValidateCmdPushDescriptorSetKHR(VkCommandBuffer commandBuffer,
4085 VkPipelineBindPoint pipelineBindPoint,
4086 VkPipelineLayout layout, uint32_t set,
4087 uint32_t descriptorWriteCount,
4088 const VkWriteDescriptorSet *pDescriptorWrites) const {
4089 return validate_WriteDescriptorSet("vkCmdPushDescriptorSetKHR", descriptorWriteCount, pDescriptorWrites, false);
4090}
4091
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004092bool StatelessValidation::manual_PreCallValidateCmdSetExclusiveScissorNV(VkCommandBuffer commandBuffer,
4093 uint32_t firstExclusiveScissor,
4094 uint32_t exclusiveScissorCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004095 const VkRect2D *pExclusiveScissors) const {
Jeff Bolz3e71f782018-08-29 23:15:45 -05004096 bool skip = false;
4097
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004098 if (!physical_device_features.multiViewport) {
Jeff Bolz3e71f782018-08-29 23:15:45 -05004099 if (firstExclusiveScissor != 0) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06004100 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004101 LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-firstExclusiveScissor-02035",
4102 "vkCmdSetExclusiveScissorNV: The multiViewport feature is disabled, but firstExclusiveScissor (=%" PRIu32
4103 ") is not 0.",
4104 firstExclusiveScissor);
Jeff Bolz3e71f782018-08-29 23:15:45 -05004105 }
4106 if (exclusiveScissorCount > 1) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06004107 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004108 LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-exclusiveScissorCount-02036",
4109 "vkCmdSetExclusiveScissorNV: The multiViewport feature is disabled, but exclusiveScissorCount (=%" PRIu32
4110 ") is not 1.",
4111 exclusiveScissorCount);
Jeff Bolz3e71f782018-08-29 23:15:45 -05004112 }
4113 } else { // multiViewport enabled
4114 const uint64_t sum = static_cast<uint64_t>(firstExclusiveScissor) + static_cast<uint64_t>(exclusiveScissorCount);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004115 if (sum > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004116 skip |= LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-firstExclusiveScissor-02034",
4117 "vkCmdSetExclusiveScissorNV: firstExclusiveScissor + exclusiveScissorCount (=%" PRIu32 " + %" PRIu32
4118 " = %" PRIu64 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
4119 firstExclusiveScissor, exclusiveScissorCount, sum, device_limits.maxViewports);
Jeff Bolz3e71f782018-08-29 23:15:45 -05004120 }
4121 }
4122
Jeff Bolz3e71f782018-08-29 23:15:45 -05004123 if (pExclusiveScissors) {
4124 for (uint32_t scissor_i = 0; scissor_i < exclusiveScissorCount; ++scissor_i) {
4125 const auto &scissor = pExclusiveScissors[scissor_i]; // will crash on invalid ptr
4126
4127 if (scissor.offset.x < 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004128 skip |= LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-x-02037",
4129 "vkCmdSetExclusiveScissorNV: pScissors[%" PRIu32 "].offset.x (=%" PRIi32 ") is negative.",
4130 scissor_i, scissor.offset.x);
Jeff Bolz3e71f782018-08-29 23:15:45 -05004131 }
4132
4133 if (scissor.offset.y < 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004134 skip |= LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-x-02037",
4135 "vkCmdSetExclusiveScissorNV: pScissors[%" PRIu32 "].offset.y (=%" PRIi32 ") is negative.",
4136 scissor_i, scissor.offset.y);
Jeff Bolz3e71f782018-08-29 23:15:45 -05004137 }
4138
4139 const int64_t x_sum = static_cast<int64_t>(scissor.offset.x) + static_cast<int64_t>(scissor.extent.width);
4140 if (x_sum > INT32_MAX) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004141 skip |= LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-offset-02038",
4142 "vkCmdSetExclusiveScissorNV: offset.x + extent.width (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
4143 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
4144 scissor.offset.x, scissor.extent.width, x_sum, scissor_i);
Jeff Bolz3e71f782018-08-29 23:15:45 -05004145 }
4146
4147 const int64_t y_sum = static_cast<int64_t>(scissor.offset.y) + static_cast<int64_t>(scissor.extent.height);
4148 if (y_sum > INT32_MAX) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004149 skip |= LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-offset-02039",
4150 "vkCmdSetExclusiveScissorNV: offset.y + extent.height (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
4151 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
4152 scissor.offset.y, scissor.extent.height, y_sum, scissor_i);
Jeff Bolz3e71f782018-08-29 23:15:45 -05004153 }
4154 }
4155 }
4156
4157 return skip;
4158}
4159
Chris Mayer9ded5eb2019-09-19 16:33:26 +02004160bool StatelessValidation::manual_PreCallValidateCmdSetViewportWScalingNV(VkCommandBuffer commandBuffer, uint32_t firstViewport,
4161 uint32_t viewportCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004162 const VkViewportWScalingNV *pViewportWScalings) const {
Chris Mayer9ded5eb2019-09-19 16:33:26 +02004163 bool skip = false;
Shannon McPherson169d0c72020-11-13 18:48:19 -07004164 const uint64_t sum = static_cast<uint64_t>(firstViewport) + static_cast<uint64_t>(viewportCount);
4165 if ((sum < 1) || (sum > device_limits.maxViewports)) {
4166 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewportWScalingNV-firstViewport-01324",
4167 "vkCmdSetViewportWScalingNV: firstViewport + viewportCount (=%" PRIu32 " + %" PRIu32 " = %" PRIu64
4168 ") must be between 1 and VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 "), inculsive.",
4169 firstViewport, viewportCount, sum, device_limits.maxViewports);
Chris Mayer9ded5eb2019-09-19 16:33:26 +02004170 }
4171
4172 return skip;
4173}
4174
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004175bool StatelessValidation::manual_PreCallValidateCmdSetViewportShadingRatePaletteNV(
4176 VkCommandBuffer commandBuffer, uint32_t firstViewport, uint32_t viewportCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004177 const VkShadingRatePaletteNV *pShadingRatePalettes) const {
Jeff Bolz9af91c52018-09-01 21:53:57 -05004178 bool skip = false;
4179
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004180 if (!physical_device_features.multiViewport) {
Jeff Bolz9af91c52018-09-01 21:53:57 -05004181 if (firstViewport != 0) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06004182 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004183 LogError(commandBuffer, "VUID-vkCmdSetViewportShadingRatePaletteNV-firstViewport-02068",
4184 "vkCmdSetViewportShadingRatePaletteNV: The multiViewport feature is disabled, but firstViewport (=%" PRIu32
4185 ") is not 0.",
4186 firstViewport);
Jeff Bolz9af91c52018-09-01 21:53:57 -05004187 }
4188 if (viewportCount > 1) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06004189 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004190 LogError(commandBuffer, "VUID-vkCmdSetViewportShadingRatePaletteNV-viewportCount-02069",
4191 "vkCmdSetViewportShadingRatePaletteNV: The multiViewport feature is disabled, but viewportCount (=%" PRIu32
4192 ") is not 1.",
4193 viewportCount);
Jeff Bolz9af91c52018-09-01 21:53:57 -05004194 }
4195 }
4196
Jeff Bolz9af91c52018-09-01 21:53:57 -05004197 const uint64_t sum = static_cast<uint64_t>(firstViewport) + static_cast<uint64_t>(viewportCount);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004198 if (sum > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004199 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewportShadingRatePaletteNV-firstViewport-02067",
4200 "vkCmdSetViewportShadingRatePaletteNV: firstViewport + viewportCount (=%" PRIu32 " + %" PRIu32
4201 " = %" PRIu64 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
4202 firstViewport, viewportCount, sum, device_limits.maxViewports);
Jeff Bolz9af91c52018-09-01 21:53:57 -05004203 }
4204
4205 return skip;
4206}
4207
Jeff Bolz5c801d12019-10-09 10:38:45 -05004208bool StatelessValidation::manual_PreCallValidateCmdSetCoarseSampleOrderNV(
4209 VkCommandBuffer commandBuffer, VkCoarseSampleOrderTypeNV sampleOrderType, uint32_t customSampleOrderCount,
4210 const VkCoarseSampleOrderCustomNV *pCustomSampleOrders) const {
Jeff Bolz9af91c52018-09-01 21:53:57 -05004211 bool skip = false;
4212
Dave Houlton142c4cb2018-10-17 15:04:41 -06004213 if (sampleOrderType != VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV && customSampleOrderCount != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004214 skip |= LogError(commandBuffer, "VUID-vkCmdSetCoarseSampleOrderNV-sampleOrderType-02081",
4215 "vkCmdSetCoarseSampleOrderNV: If sampleOrderType is not VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV, "
4216 "customSampleOrderCount must be 0.");
Jeff Bolz9af91c52018-09-01 21:53:57 -05004217 }
4218
4219 for (uint32_t order_i = 0; order_i < customSampleOrderCount; ++order_i) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004220 skip |= ValidateCoarseSampleOrderCustomNV(&pCustomSampleOrders[order_i]);
Jeff Bolz9af91c52018-09-01 21:53:57 -05004221 }
4222
4223 return skip;
4224}
4225
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004226bool StatelessValidation::manual_PreCallValidateCmdDrawMeshTasksNV(VkCommandBuffer commandBuffer, uint32_t taskCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004227 uint32_t firstTask) const {
Jeff Bolz45bf7d62018-09-18 15:39:58 -05004228 bool skip = false;
4229
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004230 if (taskCount > phys_dev_ext_props.mesh_shader_props.maxDrawMeshTasksCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004231 skip |= LogError(
4232 commandBuffer, "VUID-vkCmdDrawMeshTasksNV-taskCount-02119",
Dave Houlton142c4cb2018-10-17 15:04:41 -06004233 "vkCmdDrawMeshTasksNV() parameter, uint32_t taskCount (0x%" PRIxLEAST32
4234 "), must be less than or equal to VkPhysicalDeviceMeshShaderPropertiesNV::maxDrawMeshTasksCount (0x%" PRIxLEAST32 ").",
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004235 taskCount, phys_dev_ext_props.mesh_shader_props.maxDrawMeshTasksCount);
Jeff Bolz45bf7d62018-09-18 15:39:58 -05004236 }
4237
4238 return skip;
4239}
4240
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004241bool StatelessValidation::manual_PreCallValidateCmdDrawMeshTasksIndirectNV(VkCommandBuffer commandBuffer, VkBuffer buffer,
4242 VkDeviceSize offset, uint32_t drawCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004243 uint32_t stride) const {
Jeff Bolz45bf7d62018-09-18 15:39:58 -05004244 bool skip = false;
Lockee1c22882019-06-10 16:02:54 -06004245 static const int condition_multiples = 0b0011;
4246 if (offset & condition_multiples) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004247 skip |= LogError(
4248 commandBuffer, "VUID-vkCmdDrawMeshTasksIndirectNV-offset-02710",
Dave Houlton142c4cb2018-10-17 15:04:41 -06004249 "vkCmdDrawMeshTasksIndirectNV() parameter, VkDeviceSize offset (0x%" PRIxLEAST64 "), is not a multiple of 4.", offset);
Jeff Bolz45bf7d62018-09-18 15:39:58 -05004250 }
Lockee1c22882019-06-10 16:02:54 -06004251 if (drawCount > 1 && ((stride & condition_multiples) || stride < sizeof(VkDrawMeshTasksIndirectCommandNV))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004252 skip |= LogError(commandBuffer, "VUID-vkCmdDrawMeshTasksIndirectNV-drawCount-02146",
4253 "vkCmdDrawMeshTasksIndirectNV() parameter, uint32_t stride (0x%" PRIxLEAST32
4254 "), is not a multiple of 4 or smaller than sizeof (VkDrawMeshTasksIndirectCommandNV).",
4255 stride);
Lockee1c22882019-06-10 16:02:54 -06004256 }
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004257 if (!physical_device_features.multiDrawIndirect && ((drawCount > 1))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004258 skip |= LogError(
4259 commandBuffer, "VUID-vkCmdDrawMeshTasksIndirectNV-drawCount-02718",
4260 "vkCmdDrawMeshTasksIndirectNV(): Device feature multiDrawIndirect disabled: count must be 0 or 1 but is %d", drawCount);
Jeff Bolzb574c342018-11-08 15:36:57 -06004261 }
Tony-LunarGc0c3df52020-11-20 13:47:10 -07004262 if (drawCount > device_limits.maxDrawIndirectCount) {
4263 skip |= LogError(commandBuffer, "VUID-vkCmdDrawMeshTasksIndirectNV-drawCount-02719",
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004264 "vkCmdDrawMeshTasksIndirectNV: drawCount (%u) is not less than or equal to the maximum allowed (%u).",
4265 drawCount, device_limits.maxDrawIndirectCount);
Tony-LunarGc0c3df52020-11-20 13:47:10 -07004266 }
Jeff Bolz45bf7d62018-09-18 15:39:58 -05004267 return skip;
4268}
4269
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004270bool StatelessValidation::manual_PreCallValidateCmdDrawMeshTasksIndirectCountNV(VkCommandBuffer commandBuffer, VkBuffer buffer,
4271 VkDeviceSize offset, VkBuffer countBuffer,
4272 VkDeviceSize countBufferOffset,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004273 uint32_t maxDrawCount, uint32_t stride) const {
Jeff Bolz45bf7d62018-09-18 15:39:58 -05004274 bool skip = false;
4275
Jeff Bolz45bf7d62018-09-18 15:39:58 -05004276 if (offset & 3) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004277 skip |= LogError(commandBuffer, "VUID-vkCmdDrawMeshTasksIndirectCountNV-offset-02710",
4278 "vkCmdDrawMeshTasksIndirectCountNV() parameter, VkDeviceSize offset (0x%" PRIxLEAST64
4279 "), is not a multiple of 4.",
4280 offset);
Jeff Bolz45bf7d62018-09-18 15:39:58 -05004281 }
4282
4283 if (countBufferOffset & 3) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004284 skip |= LogError(commandBuffer, "VUID-vkCmdDrawMeshTasksIndirectCountNV-countBufferOffset-02716",
4285 "vkCmdDrawMeshTasksIndirectCountNV() parameter, VkDeviceSize countBufferOffset (0x%" PRIxLEAST64
4286 "), is not a multiple of 4.",
4287 countBufferOffset);
Jeff Bolz45bf7d62018-09-18 15:39:58 -05004288 }
4289
Jeff Bolz45bf7d62018-09-18 15:39:58 -05004290 return skip;
4291}
4292
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004293bool StatelessValidation::manual_PreCallValidateCreateQueryPool(VkDevice device, const VkQueryPoolCreateInfo *pCreateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004294 const VkAllocationCallbacks *pAllocator,
4295 VkQueryPool *pQueryPool) const {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004296 bool skip = false;
4297
4298 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
4299 if (pCreateInfo != nullptr) {
4300 // If queryType is VK_QUERY_TYPE_PIPELINE_STATISTICS, pipelineStatistics must be a valid combination of
4301 // VkQueryPipelineStatisticFlagBits values
4302 if ((pCreateInfo->queryType == VK_QUERY_TYPE_PIPELINE_STATISTICS) && (pCreateInfo->pipelineStatistics != 0) &&
4303 ((pCreateInfo->pipelineStatistics & (~AllVkQueryPipelineStatisticFlagBits)) != 0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004304 skip |= LogError(device, "VUID-VkQueryPoolCreateInfo-queryType-00792",
4305 "vkCreateQueryPool(): if pCreateInfo->queryType is VK_QUERY_TYPE_PIPELINE_STATISTICS, "
4306 "pCreateInfo->pipelineStatistics must be a valid combination of VkQueryPipelineStatisticFlagBits "
4307 "values.");
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004308 }
sfricke-samsung7d69d0d2020-04-25 10:27:27 -07004309 if (pCreateInfo->queryCount == 0) {
4310 skip |= LogError(device, "VUID-VkQueryPoolCreateInfo-queryCount-02763",
4311 "vkCreateQueryPool(): queryCount must be greater than zero.");
4312 }
Mark Lobodzinskib7a26382018-07-02 13:14:26 -06004313 }
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004314 return skip;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004315}
4316
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004317bool StatelessValidation::manual_PreCallValidateEnumerateDeviceExtensionProperties(VkPhysicalDevice physicalDevice,
4318 const char *pLayerName, uint32_t *pPropertyCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004319 VkExtensionProperties *pProperties) const {
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004320 return validate_array("vkEnumerateDeviceExtensionProperties", "pPropertyCount", "pProperties", pPropertyCount, &pProperties,
4321 true, false, false, kVUIDUndefined, "VUID-vkEnumerateDeviceExtensionProperties-pProperties-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004322}
4323
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004324void StatelessValidation::PostCallRecordCreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo,
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -07004325 const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass,
4326 VkResult result) {
4327 if (result != VK_SUCCESS) return;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004328 RecordRenderPass(*pRenderPass, pCreateInfo);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004329}
4330
Mike Schuchardt2df08912020-12-15 16:28:09 -08004331void StatelessValidation::PostCallRecordCreateRenderPass2KHR(VkDevice device, const VkRenderPassCreateInfo2 *pCreateInfo,
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -07004332 const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass,
4333 VkResult result) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004334 // Track the state necessary for checking vkCreateGraphicsPipeline (subpass usage of depth and color attachments)
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -07004335 if (result != VK_SUCCESS) return;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004336 RecordRenderPass(*pRenderPass, pCreateInfo);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004337}
4338
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004339void StatelessValidation::PostCallRecordDestroyRenderPass(VkDevice device, VkRenderPass renderPass,
4340 const VkAllocationCallbacks *pAllocator) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004341 // Track the state necessary for checking vkCreateGraphicsPipeline (subpass usage of depth and color attachments)
Mark Lobodzinskif27a6bc2019-02-04 13:00:49 -07004342 std::unique_lock<std::mutex> lock(renderpass_map_mutex);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004343 renderpasses_states.erase(renderPass);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004344}
Jeff Bolz7e7e6e02019-01-11 22:53:41 -06004345
Tony-LunarG3c287f62020-12-17 12:39:49 -07004346void StatelessValidation::PostCallRecordAllocateCommandBuffers(VkDevice device, const VkCommandBufferAllocateInfo *pAllocateInfo,
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004347 VkCommandBuffer *pCommandBuffers, VkResult result) {
Tony-LunarG3c287f62020-12-17 12:39:49 -07004348 if ((result == VK_SUCCESS) && pAllocateInfo && (pAllocateInfo->level == VK_COMMAND_BUFFER_LEVEL_SECONDARY)) {
4349 auto lock = cb_write_lock();
4350 for (uint32_t cb_index = 0; cb_index < pAllocateInfo->commandBufferCount; cb_index++) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004351 secondary_cb_map.insert({pCommandBuffers[cb_index], pAllocateInfo->commandPool});
Tony-LunarG3c287f62020-12-17 12:39:49 -07004352 }
4353 }
4354}
4355
4356void StatelessValidation::PostCallRecordFreeCommandBuffers(VkDevice device, VkCommandPool commandPool, uint32_t commandBufferCount,
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004357 const VkCommandBuffer *pCommandBuffers) {
Tony-LunarG3c287f62020-12-17 12:39:49 -07004358 auto lock = cb_write_lock();
4359 for (uint32_t cb_index = 0; cb_index < commandBufferCount; cb_index++) {
4360 secondary_cb_map.erase(pCommandBuffers[cb_index]);
4361 }
4362}
4363
4364void StatelessValidation::PostCallRecordDestroyCommandPool(VkDevice device, VkCommandPool commandPool,
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004365 const VkAllocationCallbacks *pAllocator) {
Tony-LunarG3c287f62020-12-17 12:39:49 -07004366 auto lock = cb_write_lock();
4367 for (auto item = secondary_cb_map.begin(); item != secondary_cb_map.end();) {
4368 if (item->second == commandPool) {
4369 item = secondary_cb_map.erase(item);
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004370 } else {
Tony-LunarG3c287f62020-12-17 12:39:49 -07004371 ++item;
4372 }
4373 }
4374}
4375
Jeff Bolz7e7e6e02019-01-11 22:53:41 -06004376bool StatelessValidation::manual_PreCallValidateAllocateMemory(VkDevice device, const VkMemoryAllocateInfo *pAllocateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004377 const VkAllocationCallbacks *pAllocator,
4378 VkDeviceMemory *pMemory) const {
Jeff Bolz7e7e6e02019-01-11 22:53:41 -06004379 bool skip = false;
4380
4381 if (pAllocateInfo) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004382 auto chained_prio_struct = LvlFindInChain<VkMemoryPriorityAllocateInfoEXT>(pAllocateInfo->pNext);
Jeff Bolz7e7e6e02019-01-11 22:53:41 -06004383 if (chained_prio_struct && (chained_prio_struct->priority < 0.0f || chained_prio_struct->priority > 1.0f)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004384 skip |= LogError(device, "VUID-VkMemoryPriorityAllocateInfoEXT-priority-02602",
4385 "priority (=%f) must be between `0` and `1`, inclusive.", chained_prio_struct->priority);
Jeff Bolz7e7e6e02019-01-11 22:53:41 -06004386 }
Jeff Bolz4563f2a2019-12-10 13:30:30 -06004387
4388 VkMemoryAllocateFlags flags = 0;
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004389 auto flags_info = LvlFindInChain<VkMemoryAllocateFlagsInfo>(pAllocateInfo->pNext);
Jeff Bolz4563f2a2019-12-10 13:30:30 -06004390 if (flags_info) {
4391 flags = flags_info->flags;
4392 }
4393
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004394 auto opaque_alloc_info = LvlFindInChain<VkMemoryOpaqueCaptureAddressAllocateInfo>(pAllocateInfo->pNext);
Jeff Bolz4563f2a2019-12-10 13:30:30 -06004395 if (opaque_alloc_info && opaque_alloc_info->opaqueCaptureAddress != 0) {
Mike Schuchardt2df08912020-12-15 16:28:09 -08004396 if (!(flags & VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004397 skip |= LogError(device, "VUID-VkMemoryAllocateInfo-opaqueCaptureAddress-03329",
4398 "If opaqueCaptureAddress is non-zero, VkMemoryAllocateFlagsInfo::flags must include "
Mike Schuchardt2df08912020-12-15 16:28:09 -08004399 "VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT.");
Jeff Bolz4563f2a2019-12-10 13:30:30 -06004400 }
4401
4402#ifdef VK_USE_PLATFORM_WIN32_KHR
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004403 auto import_memory_win32_handle = LvlFindInChain<VkImportMemoryWin32HandleInfoKHR>(pAllocateInfo->pNext);
Jeff Bolz4563f2a2019-12-10 13:30:30 -06004404#endif
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004405 auto import_memory_fd = LvlFindInChain<VkImportMemoryFdInfoKHR>(pAllocateInfo->pNext);
4406 auto import_memory_host_pointer = LvlFindInChain<VkImportMemoryHostPointerInfoEXT>(pAllocateInfo->pNext);
Jeff Bolz4563f2a2019-12-10 13:30:30 -06004407#ifdef VK_USE_PLATFORM_ANDROID_KHR
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004408 auto import_memory_ahb = LvlFindInChain<VkImportAndroidHardwareBufferInfoANDROID>(pAllocateInfo->pNext);
Jeff Bolz4563f2a2019-12-10 13:30:30 -06004409#endif
4410
4411 if (import_memory_host_pointer) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004412 skip |= LogError(
4413 device, "VUID-VkMemoryAllocateInfo-pNext-03332",
Jeff Bolz4563f2a2019-12-10 13:30:30 -06004414 "If the pNext chain includes a VkImportMemoryHostPointerInfoEXT structure, opaqueCaptureAddress must be zero.");
4415 }
4416 if (
4417#ifdef VK_USE_PLATFORM_WIN32_KHR
4418 (import_memory_win32_handle && import_memory_win32_handle->handleType) ||
4419#endif
4420 (import_memory_fd && import_memory_fd->handleType) ||
4421#ifdef VK_USE_PLATFORM_ANDROID_KHR
4422 (import_memory_ahb && import_memory_ahb->buffer) ||
4423#endif
4424 (import_memory_host_pointer && import_memory_host_pointer->handleType)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004425 skip |= LogError(device, "VUID-VkMemoryAllocateInfo-opaqueCaptureAddress-03333",
4426 "If the parameters define an import operation, opaqueCaptureAddress must be zero.");
Jeff Bolz4563f2a2019-12-10 13:30:30 -06004427 }
4428 }
4429
4430 if (flags) {
Tony-LunarGa74d3fe2019-11-22 15:43:20 -07004431 VkBool32 capture_replay = false;
4432 VkBool32 buffer_device_address = false;
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004433 const auto *vulkan_12_features = LvlFindInChain<VkPhysicalDeviceVulkan12Features>(device_createinfo_pnext);
Tony-LunarGa74d3fe2019-11-22 15:43:20 -07004434 if (vulkan_12_features) {
4435 capture_replay = vulkan_12_features->bufferDeviceAddressCaptureReplay;
4436 buffer_device_address = vulkan_12_features->bufferDeviceAddress;
4437 } else {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004438 const auto *bda_features = LvlFindInChain<VkPhysicalDeviceBufferDeviceAddressFeatures>(device_createinfo_pnext);
Tony-LunarGa74d3fe2019-11-22 15:43:20 -07004439 if (bda_features) {
4440 capture_replay = bda_features->bufferDeviceAddressCaptureReplay;
4441 buffer_device_address = bda_features->bufferDeviceAddress;
4442 }
4443 }
Mike Schuchardt2df08912020-12-15 16:28:09 -08004444 if ((flags & VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT) && !capture_replay) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004445 skip |= LogError(device, "VUID-VkMemoryAllocateInfo-flags-03330",
Mike Schuchardt2df08912020-12-15 16:28:09 -08004446 "If VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT is set, "
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004447 "bufferDeviceAddressCaptureReplay must be enabled.");
Jeff Bolz4563f2a2019-12-10 13:30:30 -06004448 }
Mike Schuchardt2df08912020-12-15 16:28:09 -08004449 if ((flags & VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_BIT) && !buffer_device_address) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004450 skip |= LogError(device, "VUID-VkMemoryAllocateInfo-flags-03331",
Mike Schuchardt2df08912020-12-15 16:28:09 -08004451 "If VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_BIT is set, bufferDeviceAddress must be enabled.");
Jeff Bolz4563f2a2019-12-10 13:30:30 -06004452 }
4453 }
Jeff Bolz7e7e6e02019-01-11 22:53:41 -06004454 }
4455 return skip;
4456}
Ricardo Garciaa4935972019-02-21 17:43:18 +01004457
Jason Macnak192fa0e2019-07-26 15:07:16 -07004458bool StatelessValidation::ValidateGeometryTrianglesNV(const VkGeometryTrianglesNV &triangles,
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004459 VkAccelerationStructureNV object_handle, const char *func_name) const {
Jason Macnak192fa0e2019-07-26 15:07:16 -07004460 bool skip = false;
4461
4462 if (triangles.vertexFormat != VK_FORMAT_R32G32B32_SFLOAT && triangles.vertexFormat != VK_FORMAT_R16G16B16_SFLOAT &&
4463 triangles.vertexFormat != VK_FORMAT_R16G16B16_SNORM && triangles.vertexFormat != VK_FORMAT_R32G32_SFLOAT &&
4464 triangles.vertexFormat != VK_FORMAT_R16G16_SFLOAT && triangles.vertexFormat != VK_FORMAT_R16G16_SNORM) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004465 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-vertexFormat-02430", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004466 } else {
4467 uint32_t vertex_component_size = 0;
4468 if (triangles.vertexFormat == VK_FORMAT_R32G32B32_SFLOAT || triangles.vertexFormat == VK_FORMAT_R32G32_SFLOAT) {
4469 vertex_component_size = 4;
4470 } else if (triangles.vertexFormat == VK_FORMAT_R16G16B16_SFLOAT || triangles.vertexFormat == VK_FORMAT_R16G16B16_SNORM ||
4471 triangles.vertexFormat == VK_FORMAT_R16G16_SFLOAT || triangles.vertexFormat == VK_FORMAT_R16G16_SNORM) {
4472 vertex_component_size = 2;
4473 }
4474 if (vertex_component_size > 0 && SafeModulo(triangles.vertexOffset, vertex_component_size) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004475 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-vertexOffset-02429", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004476 }
4477 }
4478
4479 if (triangles.indexType != VK_INDEX_TYPE_UINT32 && triangles.indexType != VK_INDEX_TYPE_UINT16 &&
4480 triangles.indexType != VK_INDEX_TYPE_NONE_NV) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004481 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-indexType-02433", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004482 } else {
4483 uint32_t index_element_size = 0;
4484 if (triangles.indexType == VK_INDEX_TYPE_UINT32) {
4485 index_element_size = 4;
4486 } else if (triangles.indexType == VK_INDEX_TYPE_UINT16) {
4487 index_element_size = 2;
4488 }
4489 if (index_element_size > 0 && SafeModulo(triangles.indexOffset, index_element_size) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004490 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-indexOffset-02432", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004491 }
4492 }
4493 if (triangles.indexType == VK_INDEX_TYPE_NONE_NV) {
4494 if (triangles.indexCount != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004495 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-indexCount-02436", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004496 }
4497 if (triangles.indexData != VK_NULL_HANDLE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004498 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-indexData-02434", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004499 }
4500 }
4501
4502 if (SafeModulo(triangles.transformOffset, 16) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004503 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-transformOffset-02438", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004504 }
4505
4506 return skip;
4507}
4508
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004509bool StatelessValidation::ValidateGeometryAABBNV(const VkGeometryAABBNV &aabbs, VkAccelerationStructureNV object_handle,
4510 const char *func_name) const {
Jason Macnak192fa0e2019-07-26 15:07:16 -07004511 bool skip = false;
4512
4513 if (SafeModulo(aabbs.offset, 8) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004514 skip |= LogError(object_handle, "VUID-VkGeometryAABBNV-offset-02440", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004515 }
4516 if (SafeModulo(aabbs.stride, 8) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004517 skip |= LogError(object_handle, "VUID-VkGeometryAABBNV-stride-02441", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004518 }
4519
4520 return skip;
4521}
4522
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004523bool StatelessValidation::ValidateGeometryNV(const VkGeometryNV &geometry, VkAccelerationStructureNV object_handle,
4524 const char *func_name) const {
Jason Macnak192fa0e2019-07-26 15:07:16 -07004525 bool skip = false;
4526 if (geometry.geometryType == VK_GEOMETRY_TYPE_TRIANGLES_NV) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004527 skip = ValidateGeometryTrianglesNV(geometry.geometry.triangles, object_handle, func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004528 } else if (geometry.geometryType == VK_GEOMETRY_TYPE_AABBS_NV) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004529 skip = ValidateGeometryAABBNV(geometry.geometry.aabbs, object_handle, func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004530 }
4531 return skip;
4532}
4533
4534bool StatelessValidation::ValidateAccelerationStructureInfoNV(const VkAccelerationStructureInfoNV &info,
sourav parmara24fb7b2020-05-26 10:50:04 -07004535 VkAccelerationStructureNV object_handle, const char *func_name,
Mark Lobodzinski17dc4602020-05-29 07:48:40 -06004536 bool is_cmd) const {
Jason Macnak5c954952019-07-09 15:46:12 -07004537 bool skip = false;
4538 if (info.type == VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_NV && info.geometryCount != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004539 skip |= LogError(object_handle, "VUID-VkAccelerationStructureInfoNV-type-02425",
4540 "VkAccelerationStructureInfoNV: If type is VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_NV then "
4541 "geometryCount must be 0.");
Jason Macnak5c954952019-07-09 15:46:12 -07004542 }
4543 if (info.type == VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_NV && info.instanceCount != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004544 skip |= LogError(object_handle, "VUID-VkAccelerationStructureInfoNV-type-02426",
4545 "VkAccelerationStructureInfoNV: If type is VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_NV then "
4546 "instanceCount must be 0.");
Jason Macnak5c954952019-07-09 15:46:12 -07004547 }
4548 if (info.flags & VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_TRACE_BIT_NV &&
4549 info.flags & VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_BUILD_BIT_NV) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004550 skip |= LogError(object_handle, "VUID-VkAccelerationStructureInfoNV-flags-02592",
4551 "VkAccelerationStructureInfoNV: If flags has the VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_TRACE_BIT_NV"
4552 "bit set, then it must not have the VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_BUILD_BIT_NV bit set.");
Jason Macnak5c954952019-07-09 15:46:12 -07004553 }
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004554 if (info.geometryCount > phys_dev_ext_props.ray_tracing_propsNV.maxGeometryCount) {
sourav parmara24fb7b2020-05-26 10:50:04 -07004555 skip |= LogError(object_handle,
Mark Lobodzinski17dc4602020-05-29 07:48:40 -06004556 is_cmd ? "VUID-vkCmdBuildAccelerationStructureNV-geometryCount-02241"
4557 : "VUID-VkAccelerationStructureInfoNV-geometryCount-02422",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004558 "VkAccelerationStructureInfoNV: geometryCount must be less than or equal to "
4559 "VkPhysicalDeviceRayTracingPropertiesNV::maxGeometryCount.");
Jason Macnak5c954952019-07-09 15:46:12 -07004560 }
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004561 if (info.instanceCount > phys_dev_ext_props.ray_tracing_propsNV.maxInstanceCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004562 skip |= LogError(object_handle, "VUID-VkAccelerationStructureInfoNV-instanceCount-02423",
4563 "VkAccelerationStructureInfoNV: instanceCount must be less than or equal to "
4564 "VkPhysicalDeviceRayTracingPropertiesNV::maxInstanceCount.");
Jason Macnak5c954952019-07-09 15:46:12 -07004565 }
Jason Macnak21ba97e2019-08-09 12:57:44 -07004566 if (info.type == VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_NV && info.geometryCount > 0) {
Jason Macnak5c954952019-07-09 15:46:12 -07004567 uint64_t total_triangle_count = 0;
4568 for (uint32_t i = 0; i < info.geometryCount; i++) {
4569 const VkGeometryNV &geometry = info.pGeometries[i];
Jason Macnak192fa0e2019-07-26 15:07:16 -07004570
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004571 skip |= ValidateGeometryNV(geometry, object_handle, func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004572
Jason Macnak5c954952019-07-09 15:46:12 -07004573 if (geometry.geometryType != VK_GEOMETRY_TYPE_TRIANGLES_NV) {
4574 continue;
4575 }
4576 total_triangle_count += geometry.geometry.triangles.indexCount / 3;
4577 }
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004578 if (total_triangle_count > phys_dev_ext_props.ray_tracing_propsNV.maxTriangleCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004579 skip |= LogError(object_handle, "VUID-VkAccelerationStructureInfoNV-maxTriangleCount-02424",
4580 "VkAccelerationStructureInfoNV: The total number of triangles in all geometries must be less than "
4581 "or equal to VkPhysicalDeviceRayTracingPropertiesNV::maxTriangleCount.");
Jason Macnak5c954952019-07-09 15:46:12 -07004582 }
4583 }
Jason Macnak21ba97e2019-08-09 12:57:44 -07004584 if (info.type == VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_NV && info.geometryCount > 1) {
4585 const VkGeometryTypeNV first_geometry_type = info.pGeometries[0].geometryType;
4586 for (uint32_t i = 1; i < info.geometryCount; i++) {
4587 const VkGeometryNV &geometry = info.pGeometries[i];
4588 if (geometry.geometryType != first_geometry_type) {
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004589 skip |= LogError(device, "VUID-VkAccelerationStructureInfoNV-type-02786",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004590 "VkAccelerationStructureInfoNV: info.pGeometries[%d].geometryType does not match "
4591 "info.pGeometries[0].geometryType.",
4592 i);
Jason Macnak21ba97e2019-08-09 12:57:44 -07004593 }
4594 }
4595 }
sourav parmara96ab1a2020-04-25 16:28:23 -07004596 for (uint32_t geometry_index = 0; geometry_index < info.geometryCount; ++geometry_index) {
4597 if (!(info.pGeometries[geometry_index].geometryType == VK_GEOMETRY_TYPE_TRIANGLES_NV ||
4598 info.pGeometries[geometry_index].geometryType == VK_GEOMETRY_TYPE_AABBS_NV)) {
4599 skip |= LogError(device, "VUID-VkGeometryNV-geometryType-03503",
4600 "VkGeometryNV: geometryType must be VK_GEOMETRY_TYPE_TRIANGLES_NV"
4601 "or VK_GEOMETRY_TYPE_AABBS_NV.");
4602 }
4603 }
4604 skip |=
4605 validate_flags(func_name, "info.flags", "VkBuildAccelerationStructureFlagBitsNV", AllVkBuildAccelerationStructureFlagBitsNV,
Shannon McPherson93970b12020-06-12 14:34:35 -06004606 info.flags, kOptionalFlags, "VUID-VkAccelerationStructureInfoNV-flags-parameter");
Jason Macnak5c954952019-07-09 15:46:12 -07004607 return skip;
4608}
4609
Ricardo Garciaa4935972019-02-21 17:43:18 +01004610bool StatelessValidation::manual_PreCallValidateCreateAccelerationStructureNV(
4611 VkDevice device, const VkAccelerationStructureCreateInfoNV *pCreateInfo, const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004612 VkAccelerationStructureNV *pAccelerationStructure) const {
Ricardo Garciaa4935972019-02-21 17:43:18 +01004613 bool skip = false;
Ricardo Garciaa4935972019-02-21 17:43:18 +01004614 if (pCreateInfo) {
4615 if ((pCreateInfo->compactedSize != 0) &&
4616 ((pCreateInfo->info.geometryCount != 0) || (pCreateInfo->info.instanceCount != 0))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004617 skip |= LogError(device, "VUID-VkAccelerationStructureCreateInfoNV-compactedSize-02421",
4618 "vkCreateAccelerationStructureNV(): pCreateInfo->compactedSize nonzero (%" PRIu64
4619 ") with info.geometryCount (%" PRIu32 ") or info.instanceCount (%" PRIu32 ") nonzero.",
4620 pCreateInfo->compactedSize, pCreateInfo->info.geometryCount, pCreateInfo->info.instanceCount);
Ricardo Garciaa4935972019-02-21 17:43:18 +01004621 }
Jason Macnak5c954952019-07-09 15:46:12 -07004622
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004623 skip |= ValidateAccelerationStructureInfoNV(pCreateInfo->info, VkAccelerationStructureNV(0),
sourav parmara24fb7b2020-05-26 10:50:04 -07004624 "vkCreateAccelerationStructureNV()", false);
Ricardo Garciaa4935972019-02-21 17:43:18 +01004625 }
Ricardo Garciaa4935972019-02-21 17:43:18 +01004626 return skip;
4627}
Mike Schuchardt21638df2019-03-16 10:52:02 -07004628
Jeff Bolz5c801d12019-10-09 10:38:45 -05004629bool StatelessValidation::manual_PreCallValidateCmdBuildAccelerationStructureNV(VkCommandBuffer commandBuffer,
4630 const VkAccelerationStructureInfoNV *pInfo,
4631 VkBuffer instanceData, VkDeviceSize instanceOffset,
4632 VkBool32 update, VkAccelerationStructureNV dst,
4633 VkAccelerationStructureNV src, VkBuffer scratch,
4634 VkDeviceSize scratchOffset) const {
Jason Macnak5c954952019-07-09 15:46:12 -07004635 bool skip = false;
4636
4637 if (pInfo != nullptr) {
sourav parmara24fb7b2020-05-26 10:50:04 -07004638 skip |= ValidateAccelerationStructureInfoNV(*pInfo, dst, "vkCmdBuildAccelerationStructureNV()", true);
Jason Macnak5c954952019-07-09 15:46:12 -07004639 }
4640
4641 return skip;
4642}
4643
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004644bool StatelessValidation::manual_PreCallValidateCreateAccelerationStructureKHR(
4645 VkDevice device, const VkAccelerationStructureCreateInfoKHR *pCreateInfo, const VkAllocationCallbacks *pAllocator,
4646 VkAccelerationStructureKHR *pAccelerationStructure) const {
4647 bool skip = false;
sourav parmarcd5fb182020-07-17 12:58:44 -07004648 const auto *acceleration_structure_features =
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004649 LvlFindInChain<VkPhysicalDeviceAccelerationStructureFeaturesKHR>(device_createinfo_pnext);
sourav parmarcd5fb182020-07-17 12:58:44 -07004650 if (!acceleration_structure_features ||
4651 (acceleration_structure_features && acceleration_structure_features->accelerationStructure == VK_FALSE)) {
4652 skip |= LogError(device, "VUID-vkCreateAccelerationStructureKHR-accelerationStructure-03611",
4653 "vkCreateAccelerationStructureKHR(): The accelerationStructure feature must be enabled");
4654 }
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004655 if (pCreateInfo) {
sourav parmarcd5fb182020-07-17 12:58:44 -07004656 if (pCreateInfo->createFlags & VK_ACCELERATION_STRUCTURE_CREATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT_KHR &&
4657 (!acceleration_structure_features ||
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004658 (acceleration_structure_features &&
4659 acceleration_structure_features->accelerationStructureCaptureReplay == VK_FALSE))) {
sourav parmara96ab1a2020-04-25 16:28:23 -07004660 skip |=
sourav parmarcd5fb182020-07-17 12:58:44 -07004661 LogError(device, "VUID-VkAccelerationStructureCreateInfoKHR-createFlags-03613",
4662 "vkCreateAccelerationStructureKHR(): If createFlags includes "
4663 "VK_ACCELERATION_STRUCTURE_CREATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT_KHR, "
4664 "VkPhysicalDeviceAccelerationStructureFeaturesKHR::accelerationStructureCaptureReplay must be VK_TRUE");
sourav parmara96ab1a2020-04-25 16:28:23 -07004665 }
sourav parmarcd5fb182020-07-17 12:58:44 -07004666 if (pCreateInfo->deviceAddress &&
4667 !(pCreateInfo->createFlags & VK_ACCELERATION_STRUCTURE_CREATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT_KHR)) {
4668 skip |= LogError(device, "VUID-VkAccelerationStructureCreateInfoKHR-deviceAddress-03612",
4669 "vkCreateAccelerationStructureKHR(): If deviceAddress is not zero, createFlags must include "
4670 "VK_ACCELERATION_STRUCTURE_CREATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT_KHR");
4671 }
4672 if (SafeModulo(pCreateInfo->offset, 256) != 0) {
4673 skip |= LogError(device, "VUID-VkAccelerationStructureCreateInfoKHR-offset-03734",
4674 "vkCreateAccelerationStructureKHR(): offset must be a multiple of 256 bytes", pCreateInfo->offset);
4675 }
sourav parmar83c31b12020-05-06 12:30:54 -07004676 }
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004677 return skip;
4678}
4679
Jason Macnak5c954952019-07-09 15:46:12 -07004680bool StatelessValidation::manual_PreCallValidateGetAccelerationStructureHandleNV(VkDevice device,
4681 VkAccelerationStructureNV accelerationStructure,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004682 size_t dataSize, void *pData) const {
Jason Macnak5c954952019-07-09 15:46:12 -07004683 bool skip = false;
4684 if (dataSize < 8) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004685 skip = LogError(accelerationStructure, "VUID-vkGetAccelerationStructureHandleNV-dataSize-02240",
4686 "vkGetAccelerationStructureHandleNV(): dataSize must be greater than or equal to 8.");
Jason Macnak5c954952019-07-09 15:46:12 -07004687 }
4688 return skip;
4689}
4690
sourav parmarcd5fb182020-07-17 12:58:44 -07004691bool StatelessValidation::manual_PreCallValidateCmdWriteAccelerationStructuresPropertiesNV(
4692 VkCommandBuffer commandBuffer, uint32_t accelerationStructureCount, const VkAccelerationStructureNV *pAccelerationStructures,
4693 VkQueryType queryType, VkQueryPool queryPool, uint32_t firstQuery) const {
4694 bool skip = false;
Mark Lobodzinskic0df6b62021-01-08 12:34:11 -07004695 if (queryType != VK_QUERY_TYPE_ACCELERATION_STRUCTURE_COMPACTED_SIZE_NV) {
sourav parmarcd5fb182020-07-17 12:58:44 -07004696 skip |= LogError(device, "VUID-vkCmdWriteAccelerationStructuresPropertiesNV-queryType-03432",
4697 "vkCmdWriteAccelerationStructuresPropertiesNV: queryType must be "
Mark Lobodzinskic0df6b62021-01-08 12:34:11 -07004698 "VK_QUERY_TYPE_ACCELERATION_STRUCTURE_COMPACTED_SIZE_NV.");
sourav parmarcd5fb182020-07-17 12:58:44 -07004699 }
4700 return skip;
4701}
4702
Peter Chen85366392019-05-14 15:20:11 -04004703bool StatelessValidation::manual_PreCallValidateCreateRayTracingPipelinesNV(VkDevice device, VkPipelineCache pipelineCache,
4704 uint32_t createInfoCount,
4705 const VkRayTracingPipelineCreateInfoNV *pCreateInfos,
4706 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004707 VkPipeline *pPipelines) const {
Peter Chen85366392019-05-14 15:20:11 -04004708 bool skip = false;
4709
4710 for (uint32_t i = 0; i < createInfoCount; i++) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004711 auto feedback_struct = LvlFindInChain<VkPipelineCreationFeedbackCreateInfoEXT>(pCreateInfos[i].pNext);
Peter Chen85366392019-05-14 15:20:11 -04004712 if ((feedback_struct != nullptr) && (feedback_struct->pipelineStageCreationFeedbackCount != pCreateInfos[i].stageCount)) {
sourav parmar83c31b12020-05-06 12:30:54 -07004713 skip |= LogError(device, "VUID-VkPipelineCreationFeedbackCreateInfoEXT-pipelineStageCreationFeedbackCount-02969",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004714 "vkCreateRayTracingPipelinesNV(): in pCreateInfo[%" PRIu32
4715 "], VkPipelineCreationFeedbackEXT::pipelineStageCreationFeedbackCount"
4716 "(=%" PRIu32 ") must equal VkRayTracingPipelineCreateInfoNV::stageCount(=%" PRIu32 ").",
4717 i, feedback_struct->pipelineStageCreationFeedbackCount, pCreateInfos[i].stageCount);
Peter Chen85366392019-05-14 15:20:11 -04004718 }
sourav parmara96ab1a2020-04-25 16:28:23 -07004719
4720 const auto *pipeline_cache_contol_features =
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004721 LvlFindInChain<VkPhysicalDevicePipelineCreationCacheControlFeaturesEXT>(device_createinfo_pnext);
sourav parmara96ab1a2020-04-25 16:28:23 -07004722 if (!pipeline_cache_contol_features || pipeline_cache_contol_features->pipelineCreationCacheControl == VK_FALSE) {
4723 if (pCreateInfos[i].flags & (VK_PIPELINE_CREATE_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT_EXT |
4724 VK_PIPELINE_CREATE_EARLY_RETURN_ON_FAILURE_BIT_EXT)) {
4725 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-pipelineCreationCacheControl-02905",
4726 "vkCreateRayTracingPipelinesNV(): If the pipelineCreationCacheControl feature is not enabled,"
4727 "flags must not include VK_PIPELINE_CREATE_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT_EXT or"
4728 "VK_PIPELINE_CREATE_EARLY_RETURN_ON_FAILURE_BIT_EXT.");
4729 }
4730 }
4731
sourav parmarf4a78252020-04-10 13:04:21 -07004732 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_INDIRECT_BINDABLE_BIT_NV) {
4733 skip |=
4734 LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-02904",
4735 "vkCreateRayTracingPipelinesNV(): flags must not include VK_PIPELINE_CREATE_INDIRECT_BINDABLE_BIT_NV.");
4736 }
4737 if ((pCreateInfos[i].flags & VK_PIPELINE_CREATE_DEFER_COMPILE_BIT_NV) &&
4738 (pCreateInfos[i].flags & VK_PIPELINE_CREATE_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT_EXT)) {
4739 skip |=
4740 LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-02957",
4741 "vkCreateRayTracingPipelinesNV(): flags must not include both VK_PIPELINE_CREATE_DEFER_COMPILE_BIT_NV and"
4742 "VK_PIPELINE_CREATE_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT_EXT at the same time.");
4743 }
4744 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_DERIVATIVE_BIT) {
4745 if (pCreateInfos[i].basePipelineIndex != -1) {
4746 if (pCreateInfos[i].basePipelineHandle != VK_NULL_HANDLE) {
4747 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03423",
4748 "vkCreateRayTracingPipelinesNV parameter, pCreateInfos->basePipelineHandle, must be "
4749 "VK_NULL_HANDLE if pCreateInfos->flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT flag "
4750 "and pCreateInfos->basePipelineIndex is not -1.");
4751 }
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07004752 if (pCreateInfos[i].basePipelineIndex > static_cast<int32_t>(i)) {
sourav parmara24fb7b2020-05-26 10:50:04 -07004753 skip |=
4754 LogError(device, "VUID-vkCreateRayTracingPipelinesNV-flags-03415",
4755 "vkCreateRayTracingPipelinesNV: If the flags member of any element of pCreateInfos contains the"
4756 "VK_PIPELINE_CREATE_DERIVATIVE_BIT flag, and the basePipelineIndex member of that same element"
4757 "is not -1, basePipelineIndex must be less than the index into pCreateInfos that corresponds to "
4758 "that element.");
4759 }
sourav parmarf4a78252020-04-10 13:04:21 -07004760 }
4761 if (pCreateInfos[i].basePipelineHandle == VK_NULL_HANDLE) {
David Netod9d7b762020-07-27 15:37:58 -04004762 if (static_cast<uint32_t>(pCreateInfos[i].basePipelineIndex) >= createInfoCount) {
sourav parmarf4a78252020-04-10 13:04:21 -07004763 skip |=
4764 LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03422",
4765 "vkCreateRayTracingPipelinesNV if flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT and"
4766 "basePipelineHandle is VK_NULL_HANDLE, basePipelineIndex must be a valid index into the calling"
4767 "commands pCreateInfos parameter.");
4768 }
4769 } else {
4770 if (pCreateInfos[i].basePipelineIndex != -1) {
4771 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03424",
4772 "vkCreateRayTracingPipelinesNV if flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT and"
4773 "basePipelineHandle is not VK_NULL_HANDLE, basePipelineIndex must be -1.");
4774 }
4775 }
4776 }
4777 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_LIBRARY_BIT_KHR) {
4778 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03456",
4779 "vkCreateRayTracingPipelinesNV: flags must not include VK_PIPELINE_CREATE_LIBRARY_BIT_KHR.");
4780 }
4781 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_ANY_HIT_SHADERS_BIT_KHR) {
4782 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03458",
4783 "vkCreateRayTracingPipelinesNV: flags must not include "
4784 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_ANY_HIT_SHADERS_BIT_KHR.");
4785 }
4786 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_CLOSEST_HIT_SHADERS_BIT_KHR) {
4787 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03459",
4788 "vkCreateRayTracingPipelinesNV: flags must not include "
4789 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_CLOSEST_HIT_SHADERS_BIT_KHR.");
4790 }
4791 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_MISS_SHADERS_BIT_KHR) {
4792 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03460",
4793 "vkCreateRayTracingPipelinesNV: flags must not include "
4794 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_MISS_SHADERS_BIT_KHR.");
4795 }
4796 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_INTERSECTION_SHADERS_BIT_KHR) {
4797 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03461",
4798 "vkCreateRayTracingPipelinesNV: flags must not include "
4799 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_INTERSECTION_SHADERS_BIT_KHR.");
4800 }
4801 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_SKIP_AABBS_BIT_KHR) {
4802 skip |= LogError(
4803 device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03462",
4804 "vkCreateRayTracingPipelinesNV: flags must not include VK_PIPELINE_CREATE_RAY_TRACING_SKIP_AABBS_BIT_KHR.");
4805 }
4806 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_SKIP_TRIANGLES_BIT_KHR) {
4807 skip |= LogError(
4808 device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03463",
4809 "vkCreateRayTracingPipelinesNV: flags must not include VK_PIPELINE_CREATE_RAY_TRACING_SKIP_TRIANGLES_BIT_KHR .");
4810 }
sourav parmarcd5fb182020-07-17 12:58:44 -07004811 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_SHADER_GROUP_HANDLE_CAPTURE_REPLAY_BIT_KHR) {
4812 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03588",
4813 "vkCreateRayTracingPipelinesNV: flags must not include "
4814 "VK_PIPELINE_CREATE_RAY_TRACING_SHADER_GROUP_HANDLE_CAPTURE_REPLAY_BIT_KHR.");
4815 }
4816 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_DISPATCH_BASE) {
4817 skip |= LogError(device, "VUID-vkCreateRayTracingPipelinesNV-flags-03816",
4818 "vkCreateRayTracingPipelinesNV: flags must not contain the VK_PIPELINE_CREATE_DISPATCH_BASE flag.");
4819 }
Peter Chen85366392019-05-14 15:20:11 -04004820 }
4821
4822 return skip;
4823}
4824
sourav parmarcd5fb182020-07-17 12:58:44 -07004825bool StatelessValidation::manual_PreCallValidateCreateRayTracingPipelinesKHR(
4826 VkDevice device, VkDeferredOperationKHR deferredOperation, VkPipelineCache pipelineCache, uint32_t createInfoCount,
4827 const VkRayTracingPipelineCreateInfoKHR *pCreateInfos, const VkAllocationCallbacks *pAllocator, VkPipeline *pPipelines) const {
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004828 bool skip = false;
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004829 const auto *raytracing_features = LvlFindInChain<VkPhysicalDeviceRayTracingPipelineFeaturesKHR>(device_createinfo_pnext);
sourav parmarcd5fb182020-07-17 12:58:44 -07004830 if (!raytracing_features || raytracing_features->rayTracingPipeline == VK_FALSE) {
4831 skip |= LogError(device, "VUID-vkCreateRayTracingPipelinesKHR-rayTracingPipeline-03586",
4832 "vkCreateRayTracingPipelinesKHR: The rayTracingPipeline feature must be enabled.");
sourav parmar83c31b12020-05-06 12:30:54 -07004833 }
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004834 for (uint32_t i = 0; i < createInfoCount; i++) {
sourav parmarcd5fb182020-07-17 12:58:44 -07004835 if (!raytracing_features || (raytracing_features && raytracing_features->rayTraversalPrimitiveCulling == VK_FALSE)) {
4836 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_SKIP_AABBS_BIT_KHR) {
4837 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-rayTraversalPrimitiveCulling-03596",
4838 "vkCreateRayTracingPipelinesKHR: If the rayTraversalPrimitiveCulling feature is not enabled, "
4839 "flags must not include VK_PIPELINE_CREATE_RAY_TRACING_SKIP_AABBS_BIT_KHR.");
4840 }
4841 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_SKIP_TRIANGLES_BIT_KHR) {
4842 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-rayTraversalPrimitiveCulling-03597",
4843 "vkCreateRayTracingPipelinesKHR: If the rayTraversalPrimitiveCulling feature is not enabled, "
4844 "flags must not include VK_PIPELINE_CREATE_RAY_TRACING_SKIP_TRIANGLES_BIT_KHR.");
4845 }
4846 }
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004847 auto feedback_struct = LvlFindInChain<VkPipelineCreationFeedbackCreateInfoEXT>(pCreateInfos[i].pNext);
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004848 if ((feedback_struct != nullptr) && (feedback_struct->pipelineStageCreationFeedbackCount != pCreateInfos[i].stageCount)) {
4849 skip |= LogError(device, "VUID-VkPipelineCreationFeedbackCreateInfoEXT-pipelineStageCreationFeedbackCount-02670",
sourav parmarcd5fb182020-07-17 12:58:44 -07004850 "vkCreateRayTracingPipelinesKHR: in pCreateInfo[%" PRIu32
4851 "], When chained to VkRayTracingPipelineCreateInfoKHR, "
4852 "VkPipelineCreationFeedbackEXT::pipelineStageCreationFeedbackCount"
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004853 "(=%" PRIu32 ") must equal VkRayTracingPipelineCreateInfoKHR::stageCount(=%" PRIu32 ").",
4854 i, feedback_struct->pipelineStageCreationFeedbackCount, pCreateInfos[i].stageCount);
4855 }
sourav parmara96ab1a2020-04-25 16:28:23 -07004856 const auto *pipeline_cache_contol_features =
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004857 LvlFindInChain<VkPhysicalDevicePipelineCreationCacheControlFeaturesEXT>(device_createinfo_pnext);
sourav parmara96ab1a2020-04-25 16:28:23 -07004858 if (!pipeline_cache_contol_features || pipeline_cache_contol_features->pipelineCreationCacheControl == VK_FALSE) {
4859 if (pCreateInfos[i].flags & (VK_PIPELINE_CREATE_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT_EXT |
4860 VK_PIPELINE_CREATE_EARLY_RETURN_ON_FAILURE_BIT_EXT)) {
4861 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-pipelineCreationCacheControl-02905",
sourav parmarcd5fb182020-07-17 12:58:44 -07004862 "vkCreateRayTracingPipelinesKHR: If the pipelineCreationCacheControl feature is not enabled,"
sourav parmara96ab1a2020-04-25 16:28:23 -07004863 "flags must not include VK_PIPELINE_CREATE_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT_EXT or"
4864 "VK_PIPELINE_CREATE_EARLY_RETURN_ON_FAILURE_BIT_EXT.");
4865 }
4866 }
sourav parmarf4a78252020-04-10 13:04:21 -07004867 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_INDIRECT_BINDABLE_BIT_NV) {
sourav parmarcd5fb182020-07-17 12:58:44 -07004868 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-02904",
4869 "vkCreateRayTracingPipelinesKHR: flags must not include VK_PIPELINE_CREATE_INDIRECT_BINDABLE_BIT_NV.");
sourav parmarf4a78252020-04-10 13:04:21 -07004870 }
4871 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_LIBRARY_BIT_KHR) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07004872 if (pCreateInfos[i].pLibraryInterface == NULL) {
sourav parmarf4a78252020-04-10 13:04:21 -07004873 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-03465",
sourav parmarcd5fb182020-07-17 12:58:44 -07004874 "vkCreateRayTracingPipelinesKHR: If flags includes VK_PIPELINE_CREATE_LIBRARY_BIT_KHR, "
4875 "pLibraryInterface must not be NULL.");
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07004876 }
sourav parmarcd5fb182020-07-17 12:58:44 -07004877 }
4878 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_DISPATCH_BASE) {
4879 skip |= LogError(device, "VUID-vkCreateRayTracingPipelinesKHR-flags-03816",
4880 "vkCreateRayTracingPipelinesKHR: flags must not contain the VK_PIPELINE_CREATE_DISPATCH_BASE flag.");
sourav parmarf4a78252020-04-10 13:04:21 -07004881 }
4882 for (uint32_t group_index = 0; group_index < pCreateInfos[i].groupCount; ++group_index) {
4883 if ((pCreateInfos[i].pGroups[group_index].type == VK_RAY_TRACING_SHADER_GROUP_TYPE_TRIANGLES_HIT_GROUP_KHR) ||
4884 (pCreateInfos[i].pGroups[group_index].type == VK_RAY_TRACING_SHADER_GROUP_TYPE_PROCEDURAL_HIT_GROUP_KHR)) {
4885 if ((pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_ANY_HIT_SHADERS_BIT_KHR) &&
4886 (pCreateInfos[i].pGroups[group_index].anyHitShader == VK_SHADER_UNUSED_KHR)) {
4887 skip |= LogError(
4888 device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-03470",
sourav parmarcd5fb182020-07-17 12:58:44 -07004889 "vkCreateRayTracingPipelinesKHR: If flags includes "
4890 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_ANY_HIT_SHADERS_BIT_KHR,"
sourav parmarf4a78252020-04-10 13:04:21 -07004891 "for any element of pGroups with a type of VK_RAY_TRACING_SHADER_GROUP_TYPE_TRIANGLES_HIT_GROUP_KHR"
4892 "or VK_RAY_TRACING_SHADER_GROUP_TYPE_PROCEDURAL_HIT_GROUP_KHR, the anyHitShader of that element "
4893 "must not be VK_SHADER_UNUSED_KHR");
4894 }
4895 if ((pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_CLOSEST_HIT_SHADERS_BIT_KHR) &&
4896 (pCreateInfos[i].pGroups[group_index].closestHitShader == VK_SHADER_UNUSED_KHR)) {
4897 skip |= LogError(
4898 device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-03471",
sourav parmarcd5fb182020-07-17 12:58:44 -07004899 "vkCreateRayTracingPipelinesKHR: If flags includes "
4900 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_CLOSEST_HIT_SHADERS_BIT_KHR,"
sourav parmarf4a78252020-04-10 13:04:21 -07004901 "for any element of pGroups with a type of VK_RAY_TRACING_SHADER_GROUP_TYPE_TRIANGLES_HIT_GROUP_KHR"
4902 "or VK_RAY_TRACING_SHADER_GROUP_TYPE_PROCEDURAL_HIT_GROUP_KHR, the closestHitShader of that "
4903 "element must not be VK_SHADER_UNUSED_KHR");
4904 }
4905 }
sourav parmarcd5fb182020-07-17 12:58:44 -07004906 if (raytracing_features && raytracing_features->rayTracingPipelineShaderGroupHandleCaptureReplay == VK_TRUE &&
4907 pCreateInfos[i].pGroups[group_index].pShaderGroupCaptureReplayHandle) {
4908 if (!(pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_SHADER_GROUP_HANDLE_CAPTURE_REPLAY_BIT_KHR)) {
4909 skip |= LogError(
4910 device, "VUID-VkRayTracingPipelineCreateInfoKHR-rayTracingPipelineShaderGroupHandleCaptureReplay-03599",
4911 "vkCreateRayTracingPipelinesKHR: If "
4912 "VkPhysicalDeviceRayTracingPipelineFeaturesKHR::rayTracingPipelineShaderGroupHandleCaptureReplay is "
4913 "VK_TRUE and the pShaderGroupCaptureReplayHandle member of any element of pGroups is not NULL, flags must "
4914 "include VK_PIPELINE_CREATE_RAY_TRACING_SHADER_GROUP_HANDLE_CAPTURE_REPLAY_BIT_KHR.");
4915 }
4916 }
sourav parmarf4a78252020-04-10 13:04:21 -07004917 }
4918 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_DERIVATIVE_BIT) {
4919 if (pCreateInfos[i].basePipelineIndex != -1) {
4920 if (pCreateInfos[i].basePipelineHandle != VK_NULL_HANDLE) {
4921 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-03423",
sourav parmarcd5fb182020-07-17 12:58:44 -07004922 "vkCreateRayTracingPipelinesKHR: parameter, pCreateInfos->basePipelineHandle, must be "
sourav parmarf4a78252020-04-10 13:04:21 -07004923 "VK_NULL_HANDLE if pCreateInfos->flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT flag "
4924 "and pCreateInfos->basePipelineIndex is not -1.");
4925 }
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07004926 if (pCreateInfos[i].basePipelineIndex > static_cast<int32_t>(i)) {
sourav parmara24fb7b2020-05-26 10:50:04 -07004927 skip |=
4928 LogError(device, "VUID-vkCreateRayTracingPipelinesKHR-flags-03415",
4929 "vkCreateRayTracingPipelinesKHR: If the flags member of any element of pCreateInfos contains the"
4930 "VK_PIPELINE_CREATE_DERIVATIVE_BIT flag, and the basePipelineIndex member of that same element is"
4931 "not -1, basePipelineIndex must be less than the index into pCreateInfos that corresponds to that "
4932 "element.");
4933 }
sourav parmarf4a78252020-04-10 13:04:21 -07004934 }
4935 if (pCreateInfos[i].basePipelineHandle == VK_NULL_HANDLE) {
David Netod9d7b762020-07-27 15:37:58 -04004936 if (static_cast<uint32_t>(pCreateInfos[i].basePipelineIndex) >= createInfoCount) {
sourav parmarf4a78252020-04-10 13:04:21 -07004937 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-03422",
sourav parmarcd5fb182020-07-17 12:58:44 -07004938 "vkCreateRayTracingPipelinesKHR: if flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT and"
sourav parmarf4a78252020-04-10 13:04:21 -07004939 "basePipelineHandle is VK_NULL_HANDLE, basePipelineIndex (%d) must be a valid into the calling"
4940 "commands pCreateInfos parameter %d.",
4941 pCreateInfos[i].basePipelineIndex, createInfoCount);
4942 }
4943 } else {
4944 if (pCreateInfos[i].basePipelineIndex != -1) {
4945 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-03424",
sourav parmarcd5fb182020-07-17 12:58:44 -07004946 "vkCreateRayTracingPipelinesKHR: if flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT and"
sourav parmarf4a78252020-04-10 13:04:21 -07004947 "basePipelineHandle is not VK_NULL_HANDLE, basePipelineIndex must be -1.");
4948 }
4949 }
4950 }
sourav parmarcd5fb182020-07-17 12:58:44 -07004951 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_SHADER_GROUP_HANDLE_CAPTURE_REPLAY_BIT_KHR &&
4952 (raytracing_features && raytracing_features->rayTracingPipelineShaderGroupHandleCaptureReplay == VK_FALSE)) {
4953 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-03598",
4954 "vkCreateRayTracingPipelinesKHR: If flags includes "
4955 "VK_PIPELINE_CREATE_RAY_TRACING_SHADER_GROUP_HANDLE_CAPTURE_REPLAY_BIT_KHR, "
4956 "rayTracingPipelineShaderGroupHandleCaptureReplay must be enabled.");
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004957 }
4958 bool library_enabled = IsExtEnabled(device_extensions.vk_khr_pipeline_library);
4959 if (!library_enabled && (pCreateInfos[i].pLibraryInfo || pCreateInfos[i].pLibraryInterface)) {
4960 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-pLibraryInfo-03595",
4961 "vkCreateRayTracingPipelinesKHR: If the VK_KHR_pipeline_library extension is not enabled, "
4962 "pLibraryInfo and pLibraryInterface must be NULL.");
4963 }
4964 if (pCreateInfos[i].pLibraryInfo) {
4965 if (pCreateInfos[i].pLibraryInfo->libraryCount == 0) {
4966 if (pCreateInfos[i].stageCount == 0) {
4967 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-pLibraryInfo-03600",
4968 "vkCreateRayTracingPipelinesKHR: If pLibraryInfo is not NULL and its libraryCount is 0, "
4969 "stageCount must not be 0.");
4970 }
4971 if (pCreateInfos[i].groupCount == 0) {
4972 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-pLibraryInfo-03601",
4973 "vkCreateRayTracingPipelinesKHR: If pLibraryInfo is not NULL and its libraryCount is 0, "
4974 "groupCount must not be 0.");
4975 }
4976 } else {
4977 if (pCreateInfos[i].pLibraryInterface == NULL) {
4978 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-pLibraryInfo-03590",
4979 "vkCreateRayTracingPipelinesKHR: If pLibraryInfo is not NULL and its libraryCount member "
4980 "is greater than 0, its "
4981 "pLibraryInterface member must not be NULL.");
sourav parmarcd5fb182020-07-17 12:58:44 -07004982 }
4983 }
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004984 }
4985 if (pCreateInfos[i].pLibraryInterface) {
4986 if (pCreateInfos[i].pLibraryInterface->maxPipelineRayHitAttributeSize >
4987 phys_dev_ext_props.ray_tracing_propsKHR.maxRayHitAttributeSize) {
4988 skip |= LogError(device, "VUID-VkRayTracingPipelineInterfaceCreateInfoKHR-maxPipelineRayHitAttributeSize-03605",
4989 "vkCreateRayTracingPipelinesKHR: maxPipelineRayHitAttributeSize must be less than or equal to "
4990 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::maxRayHitAttributeSize.");
4991 }
sourav parmarcd5fb182020-07-17 12:58:44 -07004992 }
4993 if (deferredOperation != VK_NULL_HANDLE) {
4994 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_EARLY_RETURN_ON_FAILURE_BIT_EXT) {
4995 skip |= LogError(device, "VUID-vkCreateRayTracingPipelinesKHR-deferredOperation-03587",
4996 "vkCreateRayTracingPipelinesKHR: If deferredOperation is not VK_NULL_HANDLE, the flags member of "
4997 "elements of pCreateInfos must not include VK_PIPELINE_CREATE_EARLY_RETURN_ON_FAILURE_BIT_EXT.");
sourav parmarf4a78252020-04-10 13:04:21 -07004998 }
4999 }
Jeff Bolz443c2ca2020-03-19 12:11:51 -05005000 }
5001
5002 return skip;
5003}
5004
Mike Schuchardt21638df2019-03-16 10:52:02 -07005005#ifdef VK_USE_PLATFORM_WIN32_KHR
5006bool StatelessValidation::PreCallValidateGetDeviceGroupSurfacePresentModes2EXT(VkDevice device,
5007 const VkPhysicalDeviceSurfaceInfo2KHR *pSurfaceInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -05005008 VkDeviceGroupPresentModeFlagsKHR *pModes) const {
Mike Schuchardt21638df2019-03-16 10:52:02 -07005009 bool skip = false;
5010 if (!device_extensions.vk_khr_swapchain)
5011 skip |= OutputExtensionError("vkGetDeviceGroupSurfacePresentModes2EXT", VK_KHR_SWAPCHAIN_EXTENSION_NAME);
5012 if (!device_extensions.vk_khr_get_surface_capabilities_2)
5013 skip |= OutputExtensionError("vkGetDeviceGroupSurfacePresentModes2EXT", VK_KHR_GET_SURFACE_CAPABILITIES_2_EXTENSION_NAME);
5014 if (!device_extensions.vk_khr_surface)
5015 skip |= OutputExtensionError("vkGetDeviceGroupSurfacePresentModes2EXT", VK_KHR_SURFACE_EXTENSION_NAME);
5016 if (!device_extensions.vk_khr_get_physical_device_properties_2)
5017 skip |=
5018 OutputExtensionError("vkGetDeviceGroupSurfacePresentModes2EXT", VK_KHR_GET_PHYSICAL_DEVICE_PROPERTIES_2_EXTENSION_NAME);
5019 if (!device_extensions.vk_ext_full_screen_exclusive)
5020 skip |= OutputExtensionError("vkGetDeviceGroupSurfacePresentModes2EXT", VK_EXT_FULL_SCREEN_EXCLUSIVE_EXTENSION_NAME);
5021 skip |= validate_struct_type(
5022 "vkGetDeviceGroupSurfacePresentModes2EXT", "pSurfaceInfo", "VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SURFACE_INFO_2_KHR",
5023 pSurfaceInfo, VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SURFACE_INFO_2_KHR, true,
5024 "VUID-vkGetDeviceGroupSurfacePresentModes2EXT-pSurfaceInfo-parameter", "VUID-VkPhysicalDeviceSurfaceInfo2KHR-sType-sType");
5025 if (pSurfaceInfo != NULL) {
5026 const VkStructureType allowed_structs_VkPhysicalDeviceSurfaceInfo2KHR[] = {
5027 VK_STRUCTURE_TYPE_SURFACE_FULL_SCREEN_EXCLUSIVE_INFO_EXT,
5028 VK_STRUCTURE_TYPE_SURFACE_FULL_SCREEN_EXCLUSIVE_WIN32_INFO_EXT};
5029
5030 skip |= validate_struct_pnext("vkGetDeviceGroupSurfacePresentModes2EXT", "pSurfaceInfo->pNext",
5031 "VkSurfaceFullScreenExclusiveInfoEXT, VkSurfaceFullScreenExclusiveWin32InfoEXT",
5032 pSurfaceInfo->pNext, ARRAY_SIZE(allowed_structs_VkPhysicalDeviceSurfaceInfo2KHR),
5033 allowed_structs_VkPhysicalDeviceSurfaceInfo2KHR, GeneratedVulkanHeaderVersion,
sfricke-samsung32a27362020-02-28 09:06:42 -08005034 "VUID-VkPhysicalDeviceSurfaceInfo2KHR-pNext-pNext",
5035 "VUID-VkPhysicalDeviceSurfaceInfo2KHR-sType-unique");
Mike Schuchardt21638df2019-03-16 10:52:02 -07005036
5037 skip |= validate_required_handle("vkGetDeviceGroupSurfacePresentModes2EXT", "pSurfaceInfo->surface", pSurfaceInfo->surface);
5038 }
5039 return skip;
5040}
5041#endif
Tobias Hectorebb855f2019-07-23 12:17:33 +01005042
5043bool StatelessValidation::manual_PreCallValidateCreateFramebuffer(VkDevice device, const VkFramebufferCreateInfo *pCreateInfo,
5044 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05005045 VkFramebuffer *pFramebuffer) const {
Tobias Hectorebb855f2019-07-23 12:17:33 +01005046 // Validation for pAttachments which is excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
5047 bool skip = false;
Mike Schuchardt2df08912020-12-15 16:28:09 -08005048 if ((pCreateInfo->flags & VK_FRAMEBUFFER_CREATE_IMAGELESS_BIT) == 0) {
Tobias Hectorebb855f2019-07-23 12:17:33 +01005049 skip |= validate_array("vkCreateFramebuffer", "attachmentCount", "pAttachments", pCreateInfo->attachmentCount,
5050 &pCreateInfo->pAttachments, false, true, kVUIDUndefined, kVUIDUndefined);
5051 }
5052 return skip;
5053}
Jeff Bolz8125a8b2019-08-16 16:29:45 -05005054
5055bool StatelessValidation::manual_PreCallValidateCmdSetLineStippleEXT(VkCommandBuffer commandBuffer, uint32_t lineStippleFactor,
Jeff Bolz5c801d12019-10-09 10:38:45 -05005056 uint16_t lineStipplePattern) const {
Jeff Bolz8125a8b2019-08-16 16:29:45 -05005057 bool skip = false;
5058
5059 if (lineStippleFactor < 1 || lineStippleFactor > 256) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005060 skip |= LogError(commandBuffer, "VUID-vkCmdSetLineStippleEXT-lineStippleFactor-02776",
5061 "vkCmdSetLineStippleEXT::lineStippleFactor=%d is not in [1,256].", lineStippleFactor);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05005062 }
5063
5064 return skip;
5065}
Piers Daniell8fd03f52019-08-21 12:07:53 -06005066
5067bool StatelessValidation::manual_PreCallValidateCmdBindIndexBuffer(VkCommandBuffer commandBuffer, VkBuffer buffer,
Jeff Bolz5c801d12019-10-09 10:38:45 -05005068 VkDeviceSize offset, VkIndexType indexType) const {
Piers Daniell8fd03f52019-08-21 12:07:53 -06005069 bool skip = false;
5070
5071 if (indexType == VK_INDEX_TYPE_NONE_NV) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005072 skip |= LogError(commandBuffer, "VUID-vkCmdBindIndexBuffer-indexType-02507",
5073 "vkCmdBindIndexBuffer() indexType must not be VK_INDEX_TYPE_NONE_NV.");
Piers Daniell8fd03f52019-08-21 12:07:53 -06005074 }
5075
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005076 const auto *index_type_uint8_features = LvlFindInChain<VkPhysicalDeviceIndexTypeUint8FeaturesEXT>(device_createinfo_pnext);
Mark Lobodzinski804fde82020-05-08 07:49:25 -06005077 if (indexType == VK_INDEX_TYPE_UINT8_EXT && (!index_type_uint8_features || !index_type_uint8_features->indexTypeUint8)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005078 skip |= LogError(commandBuffer, "VUID-vkCmdBindIndexBuffer-indexType-02765",
5079 "vkCmdBindIndexBuffer() indexType is VK_INDEX_TYPE_UINT8_EXT but indexTypeUint8 feature is not enabled.");
Piers Daniell8fd03f52019-08-21 12:07:53 -06005080 }
5081
5082 return skip;
5083}
Mark Lobodzinski84988402019-09-11 15:27:30 -06005084
sfricke-samsung4ada8d42020-02-09 17:43:11 -08005085bool StatelessValidation::manual_PreCallValidateCmdBindVertexBuffers(VkCommandBuffer commandBuffer, uint32_t firstBinding,
5086 uint32_t bindingCount, const VkBuffer *pBuffers,
5087 const VkDeviceSize *pOffsets) const {
5088 bool skip = false;
5089 if (firstBinding > device_limits.maxVertexInputBindings) {
5090 skip |= LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers-firstBinding-00624",
5091 "vkCmdBindVertexBuffers() firstBinding (%u) must be less than maxVertexInputBindings (%u)", firstBinding,
5092 device_limits.maxVertexInputBindings);
5093 } else if ((firstBinding + bindingCount) > device_limits.maxVertexInputBindings) {
5094 skip |= LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers-firstBinding-00625",
5095 "vkCmdBindVertexBuffers() sum of firstBinding (%u) and bindingCount (%u) must be less than "
5096 "maxVertexInputBindings (%u)",
5097 firstBinding, bindingCount, device_limits.maxVertexInputBindings);
5098 }
5099
Jeff Bolz165818a2020-05-08 11:19:03 -05005100 for (uint32_t i = 0; i < bindingCount; ++i) {
5101 if (pBuffers[i] == VK_NULL_HANDLE) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005102 const auto *robustness2_features = LvlFindInChain<VkPhysicalDeviceRobustness2FeaturesEXT>(device_createinfo_pnext);
Jeff Bolz165818a2020-05-08 11:19:03 -05005103 if (!(robustness2_features && robustness2_features->nullDescriptor)) {
5104 skip |= LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers-pBuffers-04001",
5105 "vkCmdBindVertexBuffers() required parameter pBuffers[%d] specified as VK_NULL_HANDLE", i);
5106 } else {
5107 if (pOffsets[i] != 0) {
5108 skip |= LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers-pBuffers-04002",
5109 "vkCmdBindVertexBuffers() pBuffers[%d] is VK_NULL_HANDLE, but pOffsets[%d] is not 0", i, i);
5110 }
5111 }
5112 }
5113 }
5114
sfricke-samsung4ada8d42020-02-09 17:43:11 -08005115 return skip;
5116}
5117
Mark Lobodzinski84988402019-09-11 15:27:30 -06005118bool StatelessValidation::manual_PreCallValidateSetDebugUtilsObjectNameEXT(VkDevice device,
Jeff Bolz5c801d12019-10-09 10:38:45 -05005119 const VkDebugUtilsObjectNameInfoEXT *pNameInfo) const {
Mark Lobodzinski84988402019-09-11 15:27:30 -06005120 bool skip = false;
5121 if (pNameInfo->objectType == VK_OBJECT_TYPE_UNKNOWN) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005122 skip |= LogError(device, "VUID-VkDebugUtilsObjectNameInfoEXT-objectType-02589",
5123 "vkSetDebugUtilsObjectNameEXT() pNameInfo->objectType cannot be VK_OBJECT_TYPE_UNKNOWN.");
Mark Lobodzinski84988402019-09-11 15:27:30 -06005124 }
5125 return skip;
5126}
5127
5128bool StatelessValidation::manual_PreCallValidateSetDebugUtilsObjectTagEXT(VkDevice device,
Jeff Bolz5c801d12019-10-09 10:38:45 -05005129 const VkDebugUtilsObjectTagInfoEXT *pTagInfo) const {
Mark Lobodzinski84988402019-09-11 15:27:30 -06005130 bool skip = false;
5131 if (pTagInfo->objectType == VK_OBJECT_TYPE_UNKNOWN) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005132 skip |= LogError(device, "VUID-VkDebugUtilsObjectTagInfoEXT-objectType-01908",
5133 "vkSetDebugUtilsObjectTagEXT() pTagInfo->objectType cannot be VK_OBJECT_TYPE_UNKNOWN.");
Mark Lobodzinski84988402019-09-11 15:27:30 -06005134 }
5135 return skip;
5136}
Petr Kraus3d720392019-11-13 02:52:39 +01005137
5138bool StatelessValidation::manual_PreCallValidateAcquireNextImageKHR(VkDevice device, VkSwapchainKHR swapchain, uint64_t timeout,
5139 VkSemaphore semaphore, VkFence fence,
5140 uint32_t *pImageIndex) const {
5141 bool skip = false;
5142
5143 if (semaphore == VK_NULL_HANDLE && fence == VK_NULL_HANDLE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005144 skip |= LogError(swapchain, "VUID-vkAcquireNextImageKHR-semaphore-01780",
5145 "vkAcquireNextImageKHR: semaphore and fence are both VK_NULL_HANDLE.");
Petr Kraus3d720392019-11-13 02:52:39 +01005146 }
5147
5148 return skip;
5149}
5150
5151bool StatelessValidation::manual_PreCallValidateAcquireNextImage2KHR(VkDevice device, const VkAcquireNextImageInfoKHR *pAcquireInfo,
5152 uint32_t *pImageIndex) const {
5153 bool skip = false;
5154
5155 if (pAcquireInfo->semaphore == VK_NULL_HANDLE && pAcquireInfo->fence == VK_NULL_HANDLE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005156 skip |= LogError(pAcquireInfo->swapchain, "VUID-VkAcquireNextImageInfoKHR-semaphore-01782",
5157 "vkAcquireNextImage2KHR: pAcquireInfo->semaphore and pAcquireInfo->fence are both VK_NULL_HANDLE.");
Petr Kraus3d720392019-11-13 02:52:39 +01005158 }
5159
5160 return skip;
5161}
Mark Lobodzinski953b7bc2019-12-19 13:50:10 -07005162
Jeremy Hayes9bda85a2020-05-21 16:36:17 -06005163bool StatelessValidation::manual_PreCallValidateCmdBindTransformFeedbackBuffersEXT(VkCommandBuffer commandBuffer,
5164 uint32_t firstBinding, uint32_t bindingCount,
5165 const VkBuffer *pBuffers,
5166 const VkDeviceSize *pOffsets,
5167 const VkDeviceSize *pSizes) const {
5168 bool skip = false;
5169
5170 char const *const cmd_name = "CmdBindTransformFeedbackBuffersEXT";
5171 for (uint32_t i = 0; i < bindingCount; ++i) {
5172 if (pOffsets[i] & 3) {
5173 skip |= LogError(commandBuffer, "VUID-vkCmdBindTransformFeedbackBuffersEXT-pOffsets-02359",
5174 "%s: pOffsets[%" PRIu32 "](0x%" PRIxLEAST64 ") is not a multiple of 4.", cmd_name, i, pOffsets[i]);
5175 }
5176 }
5177
5178 if (firstBinding >= phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers) {
5179 skip |= LogError(commandBuffer, "VUID-vkCmdBindTransformFeedbackBuffersEXT-firstBinding-02356",
5180 "%s: The firstBinding(%" PRIu32
5181 ") index is greater than or equal to "
5182 "VkPhysicalDeviceTransformFeedbackPropertiesEXT::maxTransformFeedbackBuffers(%" PRIu32 ").",
5183 cmd_name, firstBinding, phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers);
5184 }
5185
5186 if (firstBinding + bindingCount > phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers) {
5187 skip |=
5188 LogError(commandBuffer, "VUID-vkCmdBindTransformFeedbackBuffersEXT-firstBinding-02357",
5189 "%s: The sum of firstBinding(%" PRIu32 ") and bindCount(%" PRIu32
5190 ") is greater than VkPhysicalDeviceTransformFeedbackPropertiesEXT::maxTransformFeedbackBuffers(%" PRIu32 ").",
5191 cmd_name, firstBinding, bindingCount, phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers);
5192 }
5193
5194 for (uint32_t i = 0; i < bindingCount; ++i) {
5195 // pSizes is optional and may be nullptr.
5196 if (pSizes != nullptr) {
5197 if (pSizes[i] != VK_WHOLE_SIZE &&
5198 pSizes[i] > phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBufferSize) {
5199 skip |= LogError(commandBuffer, "VUID-vkCmdBindTransformFeedbackBuffersEXT-pSize-02361",
5200 "%s: pSizes[%" PRIu32 "] (0x%" PRIxLEAST64
5201 ") is not VK_WHOLE_SIZE and is greater than "
5202 "VkPhysicalDeviceTransformFeedbackPropertiesEXT::maxTransformFeedbackBufferSize.",
5203 cmd_name, i, pSizes[i]);
5204 }
5205 }
5206 }
5207
5208 return skip;
5209}
5210
5211bool StatelessValidation::manual_PreCallValidateCmdBeginTransformFeedbackEXT(VkCommandBuffer commandBuffer,
5212 uint32_t firstCounterBuffer,
5213 uint32_t counterBufferCount,
5214 const VkBuffer *pCounterBuffers,
5215 const VkDeviceSize *pCounterBufferOffsets) const {
5216 bool skip = false;
5217
5218 char const *const cmd_name = "CmdBeginTransformFeedbackEXT";
5219 if (firstCounterBuffer >= phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers) {
5220 skip |= LogError(commandBuffer, "VUID-vkCmdBeginTransformFeedbackEXT-firstCounterBuffer-02368",
5221 "%s: The firstCounterBuffer(%" PRIu32
5222 ") index is greater than or equal to "
5223 "VkPhysicalDeviceTransformFeedbackPropertiesEXT::maxTransformFeedbackBuffers(%" PRIu32 ").",
5224 cmd_name, firstCounterBuffer, phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers);
5225 }
5226
5227 if (firstCounterBuffer + counterBufferCount > phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers) {
5228 skip |=
5229 LogError(commandBuffer, "VUID-vkCmdBeginTransformFeedbackEXT-firstCounterBuffer-02369",
5230 "%s: The sum of firstCounterBuffer(%" PRIu32 ") and counterBufferCount(%" PRIu32
5231 ") is greater than VkPhysicalDeviceTransformFeedbackPropertiesEXT::maxTransformFeedbackBuffers(%" PRIu32 ").",
5232 cmd_name, firstCounterBuffer, counterBufferCount,
5233 phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers);
5234 }
5235
5236 return skip;
5237}
5238
5239bool StatelessValidation::manual_PreCallValidateCmdEndTransformFeedbackEXT(VkCommandBuffer commandBuffer,
5240 uint32_t firstCounterBuffer, uint32_t counterBufferCount,
5241 const VkBuffer *pCounterBuffers,
5242 const VkDeviceSize *pCounterBufferOffsets) const {
5243 bool skip = false;
5244
5245 char const *const cmd_name = "CmdEndTransformFeedbackEXT";
5246 if (firstCounterBuffer >= phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers) {
5247 skip |= LogError(commandBuffer, "VUID-vkCmdEndTransformFeedbackEXT-firstCounterBuffer-02376",
5248 "%s: The firstCounterBuffer(%" PRIu32
5249 ") index is greater than or equal to "
5250 "VkPhysicalDeviceTransformFeedbackPropertiesEXT::maxTransformFeedbackBuffers(%" PRIu32 ").",
5251 cmd_name, firstCounterBuffer, phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers);
5252 }
5253
5254 if (firstCounterBuffer + counterBufferCount > phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers) {
5255 skip |=
5256 LogError(commandBuffer, "VUID-vkCmdEndTransformFeedbackEXT-firstCounterBuffer-02377",
5257 "%s: The sum of firstCounterBuffer(%" PRIu32 ") and counterBufferCount(%" PRIu32
5258 ") is greater than VkPhysicalDeviceTransformFeedbackPropertiesEXT::maxTransformFeedbackBuffers(%" PRIu32 ").",
5259 cmd_name, firstCounterBuffer, counterBufferCount,
5260 phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers);
5261 }
5262
5263 return skip;
5264}
5265
Mark Lobodzinski953b7bc2019-12-19 13:50:10 -07005266bool StatelessValidation::manual_PreCallValidateCmdDrawIndirectByteCountEXT(VkCommandBuffer commandBuffer, uint32_t instanceCount,
5267 uint32_t firstInstance, VkBuffer counterBuffer,
5268 VkDeviceSize counterBufferOffset,
5269 uint32_t counterOffset, uint32_t vertexStride) const {
5270 bool skip = false;
5271
5272 if ((vertexStride <= 0) || (vertexStride > phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBufferDataStride)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005273 skip |= LogError(
5274 counterBuffer, "VUID-vkCmdDrawIndirectByteCountEXT-vertexStride-02289",
Mark Lobodzinski953b7bc2019-12-19 13:50:10 -07005275 "vkCmdDrawIndirectByteCountEXT: vertexStride (%d) must be between 0 and maxTransformFeedbackBufferDataStride (%d).",
5276 vertexStride, phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBufferDataStride);
5277 }
5278
sfricke-samsungd5e9adb2020-10-26 03:59:29 -07005279 if ((counterOffset % 4) != 0) {
sfricke-samsung6886c4b2021-01-16 08:37:35 -08005280 skip |= LogError(commandBuffer, "VUID-vkCmdDrawIndirectByteCountEXT-counterBufferOffset-04568",
sfricke-samsungd5e9adb2020-10-26 03:59:29 -07005281 "vkCmdDrawIndirectByteCountEXT(): offset (%" PRIu64 ") must be a multiple of 4.", counterOffset);
5282 }
5283
Mark Lobodzinski953b7bc2019-12-19 13:50:10 -07005284 return skip;
5285}
sfricke-samsung11ea8ed2020-01-07 22:24:56 -08005286
5287bool StatelessValidation::ValidateCreateSamplerYcbcrConversion(VkDevice device,
5288 const VkSamplerYcbcrConversionCreateInfo *pCreateInfo,
5289 const VkAllocationCallbacks *pAllocator,
5290 VkSamplerYcbcrConversion *pYcbcrConversion,
5291 const char *apiName) const {
5292 bool skip = false;
5293
5294 // Check samplerYcbcrConversion feature is set
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005295 const auto *ycbcr_features = LvlFindInChain<VkPhysicalDeviceSamplerYcbcrConversionFeatures>(device_createinfo_pnext);
sfricke-samsung11ea8ed2020-01-07 22:24:56 -08005296 if ((ycbcr_features == nullptr) || (ycbcr_features->samplerYcbcrConversion == VK_FALSE)) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005297 const auto *vulkan_11_features = LvlFindInChain<VkPhysicalDeviceVulkan11Features>(device_createinfo_pnext);
Ricardo Garcia3a34ffb2020-06-24 09:36:18 +02005298 if ((vulkan_11_features == nullptr) || (vulkan_11_features->samplerYcbcrConversion == VK_FALSE)) {
5299 skip |= LogError(device, "VUID-vkCreateSamplerYcbcrConversion-None-01648",
sfricke-samsung83d98122020-07-04 06:21:15 -07005300 "%s: samplerYcbcrConversion must be enabled.", apiName);
Ricardo Garcia3a34ffb2020-06-24 09:36:18 +02005301 }
sfricke-samsung11ea8ed2020-01-07 22:24:56 -08005302 }
sfricke-samsung83d98122020-07-04 06:21:15 -07005303
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005304#ifdef VK_USE_PLATFORM_ANDROID_KHR
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005305 const VkExternalFormatANDROID *external_format_android = LvlFindInChain<VkExternalFormatANDROID>(pCreateInfo);
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07005306 const bool is_external_format = external_format_android != nullptr && external_format_android->externalFormat != 0;
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005307#else
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07005308 const bool is_external_format = false;
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005309#endif
5310
sfricke-samsung1a72f942020-07-25 12:09:18 -07005311 const VkFormat format = pCreateInfo->format;
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005312
5313 // If there is a VkExternalFormatANDROID with externalFormat != 0, the value of components is ignored.
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07005314 if (!is_external_format) {
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005315 const VkComponentMapping components = pCreateInfo->components;
5316 // XChroma Subsampled is same as "the format has a _422 or _420 suffix" from spec
5317 if (FormatIsXChromaSubsampled(format) == true) {
5318 if ((components.g != VK_COMPONENT_SWIZZLE_G) && (components.g != VK_COMPONENT_SWIZZLE_IDENTITY)) {
5319 skip |=
5320 LogError(device, "VUID-VkSamplerYcbcrConversionCreateInfo-components-02581",
sfricke-samsung83d98122020-07-04 06:21:15 -07005321 "%s: When using a XChroma subsampled format (%s) the components.g needs to be VK_COMPONENT_SWIZZLE_G "
5322 "or VK_COMPONENT_SWIZZLE_IDENTITY, but is %s.",
sfricke-samsung1a72f942020-07-25 12:09:18 -07005323 apiName, string_VkFormat(format), string_VkComponentSwizzle(components.g));
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005324 }
sfricke-samsung83d98122020-07-04 06:21:15 -07005325
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005326 if ((components.a != VK_COMPONENT_SWIZZLE_A) && (components.a != VK_COMPONENT_SWIZZLE_IDENTITY) &&
5327 (components.a != VK_COMPONENT_SWIZZLE_ONE) && (components.a != VK_COMPONENT_SWIZZLE_ZERO)) {
5328 skip |= LogError(
5329 device, "VUID-VkSamplerYcbcrConversionCreateInfo-components-02582",
5330 "%s: When using a XChroma subsampled format (%s) the components.a needs to be VK_COMPONENT_SWIZZLE_A or "
5331 "VK_COMPONENT_SWIZZLE_IDENTITY or VK_COMPONENT_SWIZZLE_ONE or VK_COMPONENT_SWIZZLE_ZERO, but is %s.",
5332 apiName, string_VkFormat(format), string_VkComponentSwizzle(components.a));
5333 }
sfricke-samsung83d98122020-07-04 06:21:15 -07005334
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005335 if ((components.r != VK_COMPONENT_SWIZZLE_R) && (components.r != VK_COMPONENT_SWIZZLE_IDENTITY) &&
5336 (components.r != VK_COMPONENT_SWIZZLE_B)) {
5337 skip |=
5338 LogError(device, "VUID-VkSamplerYcbcrConversionCreateInfo-components-02583",
sfricke-samsung83d98122020-07-04 06:21:15 -07005339 "%s: When using a XChroma subsampled format (%s) the components.r needs to be VK_COMPONENT_SWIZZLE_R "
5340 "or VK_COMPONENT_SWIZZLE_IDENTITY or VK_COMPONENT_SWIZZLE_B, but is %s.",
sfricke-samsung1a72f942020-07-25 12:09:18 -07005341 apiName, string_VkFormat(format), string_VkComponentSwizzle(components.r));
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005342 }
sfricke-samsung83d98122020-07-04 06:21:15 -07005343
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005344 if ((components.b != VK_COMPONENT_SWIZZLE_B) && (components.b != VK_COMPONENT_SWIZZLE_IDENTITY) &&
5345 (components.b != VK_COMPONENT_SWIZZLE_R)) {
5346 skip |=
5347 LogError(device, "VUID-VkSamplerYcbcrConversionCreateInfo-components-02584",
sfricke-samsung83d98122020-07-04 06:21:15 -07005348 "%s: When using a XChroma subsampled format (%s) the components.b needs to be VK_COMPONENT_SWIZZLE_B "
5349 "or VK_COMPONENT_SWIZZLE_IDENTITY or VK_COMPONENT_SWIZZLE_R, but is %s.",
sfricke-samsung1a72f942020-07-25 12:09:18 -07005350 apiName, string_VkFormat(format), string_VkComponentSwizzle(components.b));
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005351 }
sfricke-samsung83d98122020-07-04 06:21:15 -07005352
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005353 // If one is identity, both need to be
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07005354 const bool r_identity = ((components.r == VK_COMPONENT_SWIZZLE_R) || (components.r == VK_COMPONENT_SWIZZLE_IDENTITY));
5355 const bool b_identity = ((components.b == VK_COMPONENT_SWIZZLE_B) || (components.b == VK_COMPONENT_SWIZZLE_IDENTITY));
5356 if ((r_identity != b_identity) && ((r_identity == true) || (b_identity == true))) {
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005357 skip |=
5358 LogError(device, "VUID-VkSamplerYcbcrConversionCreateInfo-components-02585",
sfricke-samsung83d98122020-07-04 06:21:15 -07005359 "%s: When using a XChroma subsampled format (%s) if either the components.r (%s) or components.b (%s) "
5360 "are an identity swizzle, then both need to be an identity swizzle.",
sfricke-samsung1a72f942020-07-25 12:09:18 -07005361 apiName, string_VkFormat(format), string_VkComponentSwizzle(components.r),
5362 string_VkComponentSwizzle(components.b));
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005363 }
sfricke-samsung1a72f942020-07-25 12:09:18 -07005364 }
5365
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005366 if (pCreateInfo->ycbcrModel != VK_SAMPLER_YCBCR_MODEL_CONVERSION_RGB_IDENTITY) {
5367 // Checks same VU multiple ways in order to give a more useful error message
5368 const char *vuid = "VUID-VkSamplerYcbcrConversionCreateInfo-ycbcrModel-01655";
5369 if ((components.r == VK_COMPONENT_SWIZZLE_ONE) || (components.r == VK_COMPONENT_SWIZZLE_ZERO) ||
5370 (components.g == VK_COMPONENT_SWIZZLE_ONE) || (components.g == VK_COMPONENT_SWIZZLE_ZERO) ||
5371 (components.b == VK_COMPONENT_SWIZZLE_ONE) || (components.b == VK_COMPONENT_SWIZZLE_ZERO)) {
5372 skip |= LogError(
5373 device, vuid,
5374 "%s: The ycbcrModel is not VK_SAMPLER_YCBCR_MODEL_CONVERSION_RGB_IDENTITY so components.r (%s), "
5375 "components.g (%s), nor components.b (%s) can't be VK_COMPONENT_SWIZZLE_ZERO or VK_COMPONENT_SWIZZLE_ONE.",
5376 apiName, string_VkComponentSwizzle(components.r), string_VkComponentSwizzle(components.g),
5377 string_VkComponentSwizzle(components.b));
5378 }
sfricke-samsung1a72f942020-07-25 12:09:18 -07005379
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005380 // "must not correspond to a channel which contains zero or one as a consequence of conversion to RGBA"
5381 // 4 channel format = no issue
5382 // 3 = no [a]
5383 // 2 = no [b,a]
5384 // 1 = no [g,b,a]
5385 // depth/stencil = no [g,b,a] (shouldn't ever occur, but no VU preventing it)
5386 const uint32_t channels = (FormatIsDepthOrStencil(format) == true) ? 1 : FormatChannelCount(format);
5387
5388 if ((channels < 4) && ((components.r == VK_COMPONENT_SWIZZLE_A) || (components.g == VK_COMPONENT_SWIZZLE_A) ||
5389 (components.b == VK_COMPONENT_SWIZZLE_A))) {
5390 skip |= LogError(device, vuid,
5391 "%s: The ycbcrModel is not VK_SAMPLER_YCBCR_MODEL_CONVERSION_RGB_IDENTITY so components.r (%s), "
5392 "components.g (%s), or components.b (%s) can't be VK_COMPONENT_SWIZZLE_A.",
5393 apiName, string_VkComponentSwizzle(components.r), string_VkComponentSwizzle(components.g),
5394 string_VkComponentSwizzle(components.b));
5395 } else if ((channels < 3) &&
5396 ((components.r == VK_COMPONENT_SWIZZLE_B) || (components.g == VK_COMPONENT_SWIZZLE_B) ||
5397 (components.b == VK_COMPONENT_SWIZZLE_B) || (components.b == VK_COMPONENT_SWIZZLE_IDENTITY))) {
5398 skip |= LogError(device, vuid,
5399 "%s: The ycbcrModel is not VK_SAMPLER_YCBCR_MODEL_CONVERSION_RGB_IDENTITY so components.r (%s), "
5400 "components.g (%s), or components.b (%s) can't be VK_COMPONENT_SWIZZLE_B "
5401 "(components.b also can't be VK_COMPONENT_SWIZZLE_IDENTITY).",
5402 apiName, string_VkComponentSwizzle(components.r), string_VkComponentSwizzle(components.g),
5403 string_VkComponentSwizzle(components.b));
5404 } else if ((channels < 2) &&
5405 ((components.r == VK_COMPONENT_SWIZZLE_G) || (components.g == VK_COMPONENT_SWIZZLE_G) ||
5406 (components.g == VK_COMPONENT_SWIZZLE_IDENTITY) || (components.b == VK_COMPONENT_SWIZZLE_G))) {
5407 skip |= LogError(device, vuid,
5408 "%s: The ycbcrModel is not VK_SAMPLER_YCBCR_MODEL_CONVERSION_RGB_IDENTITY so components.r (%s), "
5409 "components.g (%s), or components.b (%s) can't be VK_COMPONENT_SWIZZLE_G "
5410 "(components.g also can't be VK_COMPONENT_SWIZZLE_IDENTITY).",
5411 apiName, string_VkComponentSwizzle(components.r), string_VkComponentSwizzle(components.g),
5412 string_VkComponentSwizzle(components.b));
5413 }
sfricke-samsung83d98122020-07-04 06:21:15 -07005414 }
5415 }
5416
sfricke-samsung11ea8ed2020-01-07 22:24:56 -08005417 return skip;
5418}
5419
5420bool StatelessValidation::manual_PreCallValidateCreateSamplerYcbcrConversion(VkDevice device,
5421 const VkSamplerYcbcrConversionCreateInfo *pCreateInfo,
5422 const VkAllocationCallbacks *pAllocator,
5423 VkSamplerYcbcrConversion *pYcbcrConversion) const {
5424 return ValidateCreateSamplerYcbcrConversion(device, pCreateInfo, pAllocator, pYcbcrConversion,
5425 "vkCreateSamplerYcbcrConversion");
5426}
5427
5428bool StatelessValidation::manual_PreCallValidateCreateSamplerYcbcrConversionKHR(
5429 VkDevice device, const VkSamplerYcbcrConversionCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
5430 VkSamplerYcbcrConversion *pYcbcrConversion) const {
5431 return ValidateCreateSamplerYcbcrConversion(device, pCreateInfo, pAllocator, pYcbcrConversion,
5432 "vkCreateSamplerYcbcrConversionKHR");
5433}
sfricke-samsung1708a8c2020-02-10 00:35:06 -08005434
5435bool StatelessValidation::manual_PreCallValidateImportSemaphoreFdKHR(
5436 VkDevice device, const VkImportSemaphoreFdInfoKHR *pImportSemaphoreFdInfo) const {
5437 bool skip = false;
5438 VkExternalSemaphoreHandleTypeFlags supported_handle_types =
5439 VK_EXTERNAL_SEMAPHORE_HANDLE_TYPE_OPAQUE_FD_BIT | VK_EXTERNAL_SEMAPHORE_HANDLE_TYPE_SYNC_FD_BIT;
5440
5441 if (0 == (pImportSemaphoreFdInfo->handleType & supported_handle_types)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005442 skip |= LogError(device, "VUID-VkImportSemaphoreFdInfoKHR-handleType-01143",
5443 "vkImportSemaphoreFdKHR() to semaphore %s handleType %s is not one of the supported handleTypes (%s).",
5444 report_data->FormatHandle(pImportSemaphoreFdInfo->semaphore).c_str(),
5445 string_VkExternalSemaphoreHandleTypeFlagBits(pImportSemaphoreFdInfo->handleType),
5446 string_VkExternalSemaphoreHandleTypeFlags(supported_handle_types).c_str());
sfricke-samsung1708a8c2020-02-10 00:35:06 -08005447 }
5448 return skip;
5449}
sourav parmara96ab1a2020-04-25 16:28:23 -07005450
5451bool StatelessValidation::manual_PreCallValidateCopyAccelerationStructureToMemoryKHR(
sourav parmarcd5fb182020-07-17 12:58:44 -07005452 VkDevice device, VkDeferredOperationKHR deferredOperation, const VkCopyAccelerationStructureToMemoryInfoKHR *pInfo) const {
sourav parmara96ab1a2020-04-25 16:28:23 -07005453 bool skip = false;
5454 if (pInfo->mode != VK_COPY_ACCELERATION_STRUCTURE_MODE_SERIALIZE_KHR) {
5455 skip |= LogError(device, "VUID-VkCopyAccelerationStructureToMemoryInfoKHR-mode-03412",
5456 "vkCopyAccelerationStructureToMemoryKHR: mode must be VK_COPY_ACCELERATION_STRUCTURE_MODE_SERIALIZE_KHR.");
5457 }
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005458 const auto *acc_struct_features = LvlFindInChain<VkPhysicalDeviceAccelerationStructureFeaturesKHR>(device_createinfo_pnext);
sourav parmarcd5fb182020-07-17 12:58:44 -07005459 if (!acc_struct_features || acc_struct_features->accelerationStructureHostCommands == VK_FALSE) {
5460 skip |= LogError(
5461 device, "VUID-vkCopyAccelerationStructureToMemoryKHR-accelerationStructureHostCommands-03584",
5462 "vkCopyAccelerationStructureToMemoryKHR: The "
5463 "VkPhysicalDeviceAccelerationStructureFeaturesKHR::accelerationStructureHostCommands feature must be enabled.");
5464 }
5465 skip |= validate_required_pointer("vkCopyAccelerationStructureToMemoryKHR", "pInfo->dst.hostAddress", pInfo->dst.hostAddress,
5466 "VUID-vkCopyAccelerationStructureToMemoryKHR-pInfo-03732");
5467 if (SafeModulo((VkDeviceSize)pInfo->dst.hostAddress, 16) != 0) {
5468 skip |= LogError(device, "VUID-vkCopyAccelerationStructureToMemoryKHR-pInfo-03751",
5469 "vkCopyAccelerationStructureToMemoryKHR(): pInfo->dst.hostAddress must be aligned to 16 bytes.");
5470 }
sourav parmara96ab1a2020-04-25 16:28:23 -07005471 return skip;
5472}
5473
5474bool StatelessValidation::manual_PreCallValidateCmdCopyAccelerationStructureToMemoryKHR(
5475 VkCommandBuffer commandBuffer, const VkCopyAccelerationStructureToMemoryInfoKHR *pInfo) const {
5476 bool skip = false;
5477 if (pInfo->mode != VK_COPY_ACCELERATION_STRUCTURE_MODE_SERIALIZE_KHR) {
5478 skip |= // to update VUID to VkCmdCopyAccelerationStructureToMemoryInfoKHR after spec update
5479 LogError(commandBuffer, "VUID-VkCopyAccelerationStructureToMemoryInfoKHR-mode-03412",
5480 "vkCmdCopyAccelerationStructureToMemoryKHR: mode must be VK_COPY_ACCELERATION_STRUCTURE_MODE_SERIALIZE_KHR.");
5481 }
sourav parmarcd5fb182020-07-17 12:58:44 -07005482 if (SafeModulo(pInfo->dst.deviceAddress, 256) != 0) {
5483 skip |= LogError(device, "VUID-vkCmdCopyAccelerationStructureToMemoryKHR-pInfo-03740",
5484 "vkCmdCopyAccelerationStructureToMemoryKHR(): pInfo->dst.deviceAddress must be aligned to 256 bytes.",
5485 pInfo->dst.deviceAddress);
sourav parmar83c31b12020-05-06 12:30:54 -07005486 }
sourav parmara96ab1a2020-04-25 16:28:23 -07005487 return skip;
5488}
5489
5490bool StatelessValidation::ValidateCopyAccelerationStructureInfoKHR(const VkCopyAccelerationStructureInfoKHR *pInfo,
5491 const char *api_name) const {
5492 bool skip = false;
5493 if (!(pInfo->mode == VK_COPY_ACCELERATION_STRUCTURE_MODE_COMPACT_KHR ||
5494 pInfo->mode == VK_COPY_ACCELERATION_STRUCTURE_MODE_CLONE_KHR)) {
5495 skip |= LogError(device, "VUID-VkCopyAccelerationStructureInfoKHR-mode-03410",
5496 "(%s): mode must be VK_COPY_ACCELERATION_STRUCTURE_MODE_COMPACT_KHR"
5497 "or VK_COPY_ACCELERATION_STRUCTURE_MODE_CLONE_KHR.",
5498 api_name);
5499 }
5500 return skip;
5501}
5502
5503bool StatelessValidation::manual_PreCallValidateCopyAccelerationStructureKHR(
sourav parmarcd5fb182020-07-17 12:58:44 -07005504 VkDevice device, VkDeferredOperationKHR deferredOperation, const VkCopyAccelerationStructureInfoKHR *pInfo) const {
sourav parmara96ab1a2020-04-25 16:28:23 -07005505 bool skip = false;
5506 skip |= ValidateCopyAccelerationStructureInfoKHR(pInfo, "vkCopyAccelerationStructureKHR()");
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005507 const auto *acc_struct_features = LvlFindInChain<VkPhysicalDeviceAccelerationStructureFeaturesKHR>(device_createinfo_pnext);
sourav parmarcd5fb182020-07-17 12:58:44 -07005508 if (!acc_struct_features || acc_struct_features->accelerationStructureHostCommands == VK_FALSE) {
sourav parmar83c31b12020-05-06 12:30:54 -07005509 skip |= LogError(
sourav parmarcd5fb182020-07-17 12:58:44 -07005510 device, "VUID-vkCopyAccelerationStructureKHR-accelerationStructureHostCommands-03582",
5511 "vkCopyAccelerationStructureKHR: The "
5512 "VkPhysicalDeviceAccelerationStructureFeaturesKHR::accelerationStructureHostCommands feature must be enabled.");
sourav parmar83c31b12020-05-06 12:30:54 -07005513 }
sourav parmara96ab1a2020-04-25 16:28:23 -07005514 return skip;
5515}
5516
5517bool StatelessValidation::manual_PreCallValidateCmdCopyAccelerationStructureKHR(
5518 VkCommandBuffer commandBuffer, const VkCopyAccelerationStructureInfoKHR *pInfo) const {
5519 bool skip = false;
5520 skip |= ValidateCopyAccelerationStructureInfoKHR(pInfo, "vkCmdCopyAccelerationStructureKHR()");
5521 return skip;
5522}
5523
5524bool StatelessValidation::ValidateCopyMemoryToAccelerationStructureInfoKHR(const VkCopyMemoryToAccelerationStructureInfoKHR *pInfo,
Mark Lobodzinskiaad69e42020-05-12 08:44:21 -06005525 const char *api_name, bool is_cmd) const {
sourav parmara96ab1a2020-04-25 16:28:23 -07005526 bool skip = false;
5527 if (pInfo->mode != VK_COPY_ACCELERATION_STRUCTURE_MODE_DESERIALIZE_KHR) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005528 skip |= LogError(device, "VUID-VkCopyMemoryToAccelerationStructureInfoKHR-mode-03413",
sourav parmara96ab1a2020-04-25 16:28:23 -07005529 "(%s): mode must be VK_COPY_ACCELERATION_STRUCTURE_MODE_DESERIALIZE_KHR.", api_name);
5530 }
5531 return skip;
5532}
5533
5534bool StatelessValidation::manual_PreCallValidateCopyMemoryToAccelerationStructureKHR(
sourav parmarcd5fb182020-07-17 12:58:44 -07005535 VkDevice device, VkDeferredOperationKHR deferredOperation, const VkCopyMemoryToAccelerationStructureInfoKHR *pInfo) const {
sourav parmara96ab1a2020-04-25 16:28:23 -07005536 bool skip = false;
sourav parmar83c31b12020-05-06 12:30:54 -07005537 skip |= ValidateCopyMemoryToAccelerationStructureInfoKHR(pInfo, "vkCopyMemoryToAccelerationStructureKHR()", true);
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005538 const auto *acc_struct_features = LvlFindInChain<VkPhysicalDeviceAccelerationStructureFeaturesKHR>(device_createinfo_pnext);
sourav parmarcd5fb182020-07-17 12:58:44 -07005539 if (!acc_struct_features || acc_struct_features->accelerationStructureHostCommands == VK_FALSE) {
5540 skip |= LogError(
5541 device, "VUID-vkCopyMemoryToAccelerationStructureKHR-accelerationStructureHostCommands-03583",
5542 "vkCopyMemoryToAccelerationStructureKHR: The "
5543 "VkPhysicalDeviceAccelerationStructureFeaturesKHR::accelerationStructureHostCommands feature must be enabled.");
sourav parmar83c31b12020-05-06 12:30:54 -07005544 }
sourav parmarcd5fb182020-07-17 12:58:44 -07005545 skip |= validate_required_pointer("vkCopyMemoryToAccelerationStructureKHR", "pInfo->src.hostAddress", pInfo->src.hostAddress,
5546 "VUID-vkCopyMemoryToAccelerationStructureKHR-pInfo-03729");
sourav parmara96ab1a2020-04-25 16:28:23 -07005547 return skip;
5548}
Jeremy Hayes9bda85a2020-05-21 16:36:17 -06005549
sourav parmara96ab1a2020-04-25 16:28:23 -07005550bool StatelessValidation::manual_PreCallValidateCmdCopyMemoryToAccelerationStructureKHR(
5551 VkCommandBuffer commandBuffer, const VkCopyMemoryToAccelerationStructureInfoKHR *pInfo) const {
5552 bool skip = false;
sourav parmar83c31b12020-05-06 12:30:54 -07005553 skip |= ValidateCopyMemoryToAccelerationStructureInfoKHR(pInfo, "vkCmdCopyMemoryToAccelerationStructureKHR()", false);
sourav parmarcd5fb182020-07-17 12:58:44 -07005554 if (SafeModulo(pInfo->src.deviceAddress, 256) != 0) {
5555 skip |= LogError(device, "VUID-vkCmdCopyMemoryToAccelerationStructureKHR-pInfo-03743",
5556 "vkCmdCopyMemoryToAccelerationStructureKHR(): pInfo->src.deviceAddress must be aligned to 256 bytes.",
5557 pInfo->src.deviceAddress);
5558 }
sourav parmar83c31b12020-05-06 12:30:54 -07005559 return skip;
5560}
5561bool StatelessValidation::manual_PreCallValidateCmdWriteAccelerationStructuresPropertiesKHR(
5562 VkCommandBuffer commandBuffer, uint32_t accelerationStructureCount, const VkAccelerationStructureKHR *pAccelerationStructures,
5563 VkQueryType queryType, VkQueryPool queryPool, uint32_t firstQuery) const {
5564 bool skip = false;
5565 if (!(queryType == VK_QUERY_TYPE_ACCELERATION_STRUCTURE_COMPACTED_SIZE_KHR ||
5566 queryType == VK_QUERY_TYPE_ACCELERATION_STRUCTURE_SERIALIZATION_SIZE_KHR)) {
5567 skip |= LogError(device, "VUID-vkCmdWriteAccelerationStructuresPropertiesKHR-queryType-03432",
5568 "vkCmdWriteAccelerationStructuresPropertiesKHR: queryType must be "
5569 "VK_QUERY_TYPE_ACCELERATION_STRUCTURE_COMPACTED_SIZE_KHR or "
5570 "VK_QUERY_TYPE_ACCELERATION_STRUCTURE_SERIALIZATION_SIZE_KHR.");
5571 }
5572 return skip;
5573}
5574bool StatelessValidation::manual_PreCallValidateWriteAccelerationStructuresPropertiesKHR(
5575 VkDevice device, uint32_t accelerationStructureCount, const VkAccelerationStructureKHR *pAccelerationStructures,
5576 VkQueryType queryType, size_t dataSize, void *pData, size_t stride) const {
5577 bool skip = false;
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005578 const auto *acc_structure_features = LvlFindInChain<VkPhysicalDeviceAccelerationStructureFeaturesKHR>(device_createinfo_pnext);
sourav parmarcd5fb182020-07-17 12:58:44 -07005579 if (!acc_structure_features || acc_structure_features->accelerationStructureHostCommands == VK_FALSE) {
5580 skip |= LogError(
5581 device, "VUID-vkWriteAccelerationStructuresPropertiesKHR-accelerationStructureHostCommands-03585",
5582 "vkCmdWriteAccelerationStructuresPropertiesKHR: The "
5583 "VkPhysicalDeviceAccelerationStructureFeaturesKHR::accelerationStructureHostCommands feature must be enabled.");
5584 }
sourav parmar83c31b12020-05-06 12:30:54 -07005585 if (dataSize < accelerationStructureCount * stride) {
5586 skip |= LogError(device, "VUID-vkWriteAccelerationStructuresPropertiesKHR-dataSize-03452",
5587 "vkWriteAccelerationStructuresPropertiesKHR: dataSize (%zu) must be greater than or equal to "
5588 "accelerationStructureCount (%d) *stride(%zu).",
5589 dataSize, accelerationStructureCount, stride);
5590 }
5591 if (!(queryType == VK_QUERY_TYPE_ACCELERATION_STRUCTURE_COMPACTED_SIZE_KHR ||
5592 queryType == VK_QUERY_TYPE_ACCELERATION_STRUCTURE_SERIALIZATION_SIZE_KHR)) {
5593 skip |= LogError(device, "VUID-vkWriteAccelerationStructuresPropertiesKHR-queryType-03432",
5594 "vkWriteAccelerationStructuresPropertiesKHR: queryType must be "
5595 "VK_QUERY_TYPE_ACCELERATION_STRUCTURE_COMPACTED_SIZE_KHR or "
5596 "VK_QUERY_TYPE_ACCELERATION_STRUCTURE_SERIALIZATION_SIZE_KHR.");
5597 }
5598 if (queryType == VK_QUERY_TYPE_ACCELERATION_STRUCTURE_COMPACTED_SIZE_KHR) {
5599 if (SafeModulo(stride, sizeof(VkDeviceSize)) != 0) {
5600 skip |= LogError(device, "VUID-vkWriteAccelerationStructuresPropertiesKHR-queryType-03448",
5601 "vkWriteAccelerationStructuresPropertiesKHR: If queryType is "
5602 "VK_QUERY_TYPE_ACCELERATION_STRUCTURE_COMPACTED_SIZE_KHR,"
5603 "then stride (%zu) must be a multiple of the size of VkDeviceSize",
5604 stride);
5605 }
5606 }
5607 if (queryType == VK_QUERY_TYPE_ACCELERATION_STRUCTURE_SERIALIZATION_SIZE_KHR) {
5608 if (SafeModulo(stride, sizeof(VkDeviceSize)) != 0) {
5609 skip |= LogError(device, "VUID-vkWriteAccelerationStructuresPropertiesKHR-queryType-03450",
5610 "vkWriteAccelerationStructuresPropertiesKHR: If queryType is "
5611 "VK_QUERY_TYPE_ACCELERATION_STRUCTURE_SERIALIZATION_SIZE_KHR,"
5612 "then stride (%zu) must be a multiple of the size of VkDeviceSize",
5613 stride);
5614 }
5615 }
sourav parmar83c31b12020-05-06 12:30:54 -07005616 return skip;
5617}
5618bool StatelessValidation::manual_PreCallValidateGetRayTracingCaptureReplayShaderGroupHandlesKHR(
5619 VkDevice device, VkPipeline pipeline, uint32_t firstGroup, uint32_t groupCount, size_t dataSize, void *pData) const {
5620 bool skip = false;
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005621 const auto *raytracing_features = LvlFindInChain<VkPhysicalDeviceRayTracingPipelineFeaturesKHR>(device_createinfo_pnext);
sourav parmarcd5fb182020-07-17 12:58:44 -07005622 if (!raytracing_features || raytracing_features->rayTracingPipelineShaderGroupHandleCaptureReplay == VK_FALSE) {
5623 skip |= LogError(
5624 device, "VUID-vkGetRayTracingCaptureReplayShaderGroupHandlesKHR-rayTracingPipelineShaderGroupHandleCaptureReplay-03606",
5625 "vkGetRayTracingCaptureReplayShaderGroupHandlesKHR:VkPhysicalDeviceRayTracingPipelineFeaturesKHR::"
5626 "rayTracingPipelineShaderGroupHandleCaptureReplay must be enabled to call this function.");
sourav parmar83c31b12020-05-06 12:30:54 -07005627 }
5628 return skip;
5629}
5630
5631bool StatelessValidation::manual_PreCallValidateCmdTraceRaysKHR(VkCommandBuffer commandBuffer,
sourav parmarcd5fb182020-07-17 12:58:44 -07005632 const VkStridedDeviceAddressRegionKHR *pRaygenShaderBindingTable,
5633 const VkStridedDeviceAddressRegionKHR *pMissShaderBindingTable,
5634 const VkStridedDeviceAddressRegionKHR *pHitShaderBindingTable,
5635 const VkStridedDeviceAddressRegionKHR *pCallableShaderBindingTable,
sourav parmar83c31b12020-05-06 12:30:54 -07005636 uint32_t width, uint32_t height, uint32_t depth) const {
5637 bool skip = false;
sourav parmarcd5fb182020-07-17 12:58:44 -07005638 // RayGen
5639 if (pRaygenShaderBindingTable->size != pRaygenShaderBindingTable->stride) {
5640 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-size-04023",
5641 "vkCmdTraceRaysKHR: The size member of pRayGenShaderBindingTable must be equal to its stride member");
sourav parmar83c31b12020-05-06 12:30:54 -07005642 }
sourav parmarcd5fb182020-07-17 12:58:44 -07005643 if (SafeModulo(pRaygenShaderBindingTable->deviceAddress, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) !=
5644 0) {
5645 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-pRayGenShaderBindingTable-03682",
5646 "vkCmdTraceRaysKHR: pRaygenShaderBindingTable->deviceAddress must be a multiple of "
5647 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupBaseAlignment.");
5648 }
5649 // Callable
5650 if (SafeModulo(pCallableShaderBindingTable->stride, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupHandleAlignment) != 0) {
5651 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-stride-03694",
5652 "vkCmdTraceRaysKHR: The stride member of pCallableShaderBindingTable must be a multiple of "
5653 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupHandleAlignment.");
sourav parmar83c31b12020-05-06 12:30:54 -07005654 }
5655 if (pCallableShaderBindingTable->stride > phys_dev_ext_props.ray_tracing_propsKHR.maxShaderGroupStride) {
5656 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-stride-04041",
5657 "vkCmdTraceRaysKHR: The stride member of pCallableShaderBindingTable must be"
sourav parmarcd5fb182020-07-17 12:58:44 -07005658 "less than or equal to VkPhysicalDeviceRayTracingPipelinePropertiesKHR::maxShaderGroupStride.");
5659 }
5660 if (SafeModulo(pCallableShaderBindingTable->deviceAddress, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) !=
5661 0) {
5662 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-pCallableShaderBindingTable-03693",
5663 "vkCmdTraceRaysKHR: pCallableShaderBindingTable->deviceAddress must be a multiple of "
5664 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupBaseAlignment.");
sourav parmar83c31b12020-05-06 12:30:54 -07005665 }
5666 // hitShader
sourav parmarcd5fb182020-07-17 12:58:44 -07005667 if (SafeModulo(pHitShaderBindingTable->stride, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupHandleAlignment) != 0) {
5668 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-stride-03690",
5669 "vkCmdTraceRaysKHR: The stride member of pHitShaderBindingTable must be a multiple of "
5670 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupHandleAlignment.");
sourav parmar83c31b12020-05-06 12:30:54 -07005671 }
5672 if (pHitShaderBindingTable->stride > phys_dev_ext_props.ray_tracing_propsKHR.maxShaderGroupStride) {
5673 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-stride-04035",
sourav parmarcd5fb182020-07-17 12:58:44 -07005674 "vkCmdTraceRaysKHR: TThe stride member of pHitShaderBindingTable must be less than or equal to "
5675 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::maxShaderGroupStride");
sourav parmar83c31b12020-05-06 12:30:54 -07005676 }
sourav parmarcd5fb182020-07-17 12:58:44 -07005677 if (SafeModulo(pHitShaderBindingTable->deviceAddress, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) != 0) {
5678 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-pHitShaderBindingTable-03689",
5679 "vkCmdTraceRaysKHR: pHitShaderBindingTable->deviceAddress must be a multiple of "
5680 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupBaseAlignment.");
5681 }
sourav parmar83c31b12020-05-06 12:30:54 -07005682 // missShader
sourav parmarcd5fb182020-07-17 12:58:44 -07005683 if (SafeModulo(pMissShaderBindingTable->stride, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupHandleAlignment) != 0) {
5684 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-stride-03686",
5685 "vkCmdTraceRaysKHR: The stride member of pMissShaderBindingTable must be a multiple of "
5686 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupHandleAlignment");
sourav parmar83c31b12020-05-06 12:30:54 -07005687 }
5688 if (pMissShaderBindingTable->stride > phys_dev_ext_props.ray_tracing_propsKHR.maxShaderGroupStride) {
5689 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-stride-04029",
5690 "vkCmdTraceRaysKHR: The stride member of pMissShaderBindingTable must be"
sourav parmarcd5fb182020-07-17 12:58:44 -07005691 "less than or equal to VkPhysicalDeviceRayTracingPipelinePropertiesKHR::maxShaderGroupStride.");
5692 }
5693 if (SafeModulo(pMissShaderBindingTable->deviceAddress, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) != 0) {
5694 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-pMissShaderBindingTable-03685",
5695 "vkCmdTraceRaysKHR: pMissShaderBindingTable->deviceAddress must be a multiple of "
5696 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupBaseAlignment.");
5697 }
5698 if (width * depth * height > phys_dev_ext_props.ray_tracing_propsKHR.maxRayDispatchInvocationCount) {
5699 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-width-03629",
5700 "vkCmdTraceRaysKHR: width {times} height {times} depth must be less than or equal to "
5701 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::maxRayDispatchInvocationCount");
5702 }
5703 if (width > device_limits.maxComputeWorkGroupCount[0] * device_limits.maxComputeWorkGroupSize[0]) {
5704 skip |=
5705 LogError(device, "VUID-vkCmdTraceRaysKHR-width-03626",
5706 "vkCmdTraceRaysKHR: width must be less than or equal to VkPhysicalDeviceLimits::maxComputeWorkGroupCount[0] "
5707 "{times} VkPhysicalDeviceLimits::maxComputeWorkGroupSize[0]");
sourav parmar83c31b12020-05-06 12:30:54 -07005708 }
5709
sourav parmarcd5fb182020-07-17 12:58:44 -07005710 if (height > device_limits.maxComputeWorkGroupCount[1] * device_limits.maxComputeWorkGroupSize[1]) {
5711 skip |=
5712 LogError(device, "VUID-vkCmdTraceRaysKHR-height-03627",
5713 "vkCmdTraceRaysKHR: height must be less than or equal to VkPhysicalDeviceLimits::maxComputeWorkGroupCount[1] "
5714 "{times} VkPhysicalDeviceLimits::maxComputeWorkGroupSize[1]");
5715 }
5716
5717 if (depth > device_limits.maxComputeWorkGroupCount[2] * device_limits.maxComputeWorkGroupSize[2]) {
5718 skip |=
5719 LogError(device, "VUID-vkCmdTraceRaysKHR-depth-03628",
5720 "vkCmdTraceRaysKHR: depth must be less than or equal to VkPhysicalDeviceLimits::maxComputeWorkGroupCount[2] "
5721 "{times} VkPhysicalDeviceLimits::maxComputeWorkGroupSize[2]");
sourav parmar83c31b12020-05-06 12:30:54 -07005722 }
5723 return skip;
5724}
5725
sourav parmarcd5fb182020-07-17 12:58:44 -07005726bool StatelessValidation::manual_PreCallValidateCmdTraceRaysIndirectKHR(
5727 VkCommandBuffer commandBuffer, const VkStridedDeviceAddressRegionKHR *pRaygenShaderBindingTable,
5728 const VkStridedDeviceAddressRegionKHR *pMissShaderBindingTable, const VkStridedDeviceAddressRegionKHR *pHitShaderBindingTable,
5729 const VkStridedDeviceAddressRegionKHR *pCallableShaderBindingTable, VkDeviceAddress indirectDeviceAddress) const {
sourav parmar83c31b12020-05-06 12:30:54 -07005730 bool skip = false;
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005731 const auto *raytracing_features = LvlFindInChain<VkPhysicalDeviceRayTracingPipelineFeaturesKHR>(device_createinfo_pnext);
sourav parmarcd5fb182020-07-17 12:58:44 -07005732 if (!raytracing_features || raytracing_features->rayTracingPipelineTraceRaysIndirect == VK_FALSE) {
5733 skip |= LogError(
5734 device, "VUID-vkCmdTraceRaysIndirectKHR-rayTracingPipelineTraceRaysIndirect-03637",
5735 "vkCmdTraceRaysIndirectKHR: the VkPhysicalDeviceRayTracingPipelineFeaturesKHR::rayTracingPipelineTraceRaysIndirect "
5736 "feature must be enabled.");
sourav parmar83c31b12020-05-06 12:30:54 -07005737 }
sourav parmarcd5fb182020-07-17 12:58:44 -07005738 // RayGen
5739 if (pRaygenShaderBindingTable->size != pRaygenShaderBindingTable->stride) {
5740 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-size-04023",
5741 "vkCmdTraceRaysKHR: The size member of pRayGenShaderBindingTable must be equal to its stride member");
sourav parmar83c31b12020-05-06 12:30:54 -07005742 }
sourav parmarcd5fb182020-07-17 12:58:44 -07005743 if (SafeModulo(pRaygenShaderBindingTable->deviceAddress, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) !=
5744 0) {
5745 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-pRayGenShaderBindingTable-03682",
5746 "vkCmdTraceRaysIndirectKHR: pRaygenShaderBindingTable->deviceAddress must be a multiple of "
5747 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupBaseAlignment.");
5748 }
5749 // Callabe
5750 if (SafeModulo(pCallableShaderBindingTable->stride, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupHandleAlignment) != 0) {
5751 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-stride-03694",
5752 "vkCmdTraceRaysIndirectKHR: The stride member of pCallableShaderBindingTable must be a multiple of "
5753 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupHandleAlignment.");
sourav parmar83c31b12020-05-06 12:30:54 -07005754 }
5755 if (pCallableShaderBindingTable->stride > phys_dev_ext_props.ray_tracing_propsKHR.maxShaderGroupStride) {
5756 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-stride-04041",
sourav parmarcd5fb182020-07-17 12:58:44 -07005757 "vkCmdTraceRaysIndirectKHR: The stride member of pCallableShaderBindingTable must be less than or equal "
5758 "to VkPhysicalDeviceRayTracingPipelinePropertiesKHR::maxShaderGroupStride.");
5759 }
5760 if (SafeModulo(pCallableShaderBindingTable->deviceAddress, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) !=
5761 0) {
5762 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-pCallableShaderBindingTable-03693",
5763 "vkCmdTraceRaysIndirectKHR: pCallableShaderBindingTable->deviceAddress must be a multiple of "
5764 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupBaseAlignment.");
sourav parmar83c31b12020-05-06 12:30:54 -07005765 }
5766 // hitShader
sourav parmarcd5fb182020-07-17 12:58:44 -07005767 if (SafeModulo(pHitShaderBindingTable->stride, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupHandleAlignment) != 0) {
5768 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-stride-03690",
5769 "vkCmdTraceRaysIndirectKHR: The stride member of pHitShaderBindingTable must be a multiple of "
5770 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupHandleAlignment.");
sourav parmar83c31b12020-05-06 12:30:54 -07005771 }
5772 if (pHitShaderBindingTable->stride > phys_dev_ext_props.ray_tracing_propsKHR.maxShaderGroupStride) {
5773 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-stride-04035",
sourav parmarcd5fb182020-07-17 12:58:44 -07005774 "vkCmdTraceRaysIndirectKHR: The stride member of pHitShaderBindingTable must be less than or equal to "
5775 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::maxShaderGroupStride.");
sourav parmar83c31b12020-05-06 12:30:54 -07005776 }
sourav parmarcd5fb182020-07-17 12:58:44 -07005777 if (SafeModulo(pHitShaderBindingTable->deviceAddress, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) != 0) {
5778 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-pHitShaderBindingTable-03689",
5779 "vkCmdTraceRaysIndirectKHR: pHitShaderBindingTable->deviceAddress must be a multiple of "
5780 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupBaseAlignment.");
5781 }
sourav parmar83c31b12020-05-06 12:30:54 -07005782 // missShader
sourav parmarcd5fb182020-07-17 12:58:44 -07005783 if (SafeModulo(pMissShaderBindingTable->stride, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupHandleAlignment) != 0) {
5784 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-stride-03686",
5785 "vkCmdTraceRaysIndirectKHR:The stride member of pMissShaderBindingTable must be a multiple of "
5786 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupHandleAlignment.");
sourav parmar83c31b12020-05-06 12:30:54 -07005787 }
5788 if (pMissShaderBindingTable->stride > phys_dev_ext_props.ray_tracing_propsKHR.maxShaderGroupStride) {
5789 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-stride-04029",
sourav parmarcd5fb182020-07-17 12:58:44 -07005790 "vkCmdTraceRaysIndirectKHR: The stride member of pMissShaderBindingTable must be less than or equal to "
5791 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::maxShaderGroupStride.");
5792 }
5793 if (SafeModulo(pMissShaderBindingTable->deviceAddress, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) != 0) {
5794 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-pMissShaderBindingTable-03685",
5795 "vkCmdTraceRaysIndirectKHR: pMissShaderBindingTable->deviceAddress must be a multiple of "
5796 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupBaseAlignment.");
sourav parmar83c31b12020-05-06 12:30:54 -07005797 }
5798
sourav parmarcd5fb182020-07-17 12:58:44 -07005799 if (SafeModulo(indirectDeviceAddress, 4) != 0) {
5800 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-indirectDeviceAddress-03634",
5801 "vkCmdTraceRaysIndirectKHR: indirectDeviceAddress must be a multiple of 4.");
sourav parmar83c31b12020-05-06 12:30:54 -07005802 }
5803 return skip;
5804}
5805bool StatelessValidation::manual_PreCallValidateCmdTraceRaysNV(
5806 VkCommandBuffer commandBuffer, VkBuffer raygenShaderBindingTableBuffer, VkDeviceSize raygenShaderBindingOffset,
5807 VkBuffer missShaderBindingTableBuffer, VkDeviceSize missShaderBindingOffset, VkDeviceSize missShaderBindingStride,
5808 VkBuffer hitShaderBindingTableBuffer, VkDeviceSize hitShaderBindingOffset, VkDeviceSize hitShaderBindingStride,
5809 VkBuffer callableShaderBindingTableBuffer, VkDeviceSize callableShaderBindingOffset, VkDeviceSize callableShaderBindingStride,
5810 uint32_t width, uint32_t height, uint32_t depth) const {
5811 bool skip = false;
5812 if (SafeModulo(callableShaderBindingOffset, phys_dev_ext_props.ray_tracing_propsNV.shaderGroupBaseAlignment) != 0) {
5813 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-callableShaderBindingOffset-02462",
5814 "vkCmdTraceRaysNV: callableShaderBindingOffset must be a multiple of "
5815 "VkPhysicalDeviceRayTracingPropertiesNV::shaderGroupBaseAlignment.");
5816 }
5817 if (SafeModulo(callableShaderBindingStride, phys_dev_ext_props.ray_tracing_propsNV.shaderGroupHandleSize) != 0) {
5818 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-callableShaderBindingStride-02465",
5819 "vkCmdTraceRaysNV: callableShaderBindingStride must be a multiple of "
5820 "VkPhysicalDeviceRayTracingPropertiesNV::shaderGroupHandleSize.");
5821 }
5822 if (callableShaderBindingStride > phys_dev_ext_props.ray_tracing_propsNV.maxShaderGroupStride) {
5823 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-callableShaderBindingStride-02468",
5824 "vkCmdTraceRaysNV: callableShaderBindingStride must be less than or equal to "
5825 "VkPhysicalDeviceRayTracingPropertiesNV::maxShaderGroupStride. ");
5826 }
5827
5828 // hitShader
5829 if (SafeModulo(hitShaderBindingOffset, phys_dev_ext_props.ray_tracing_propsNV.shaderGroupBaseAlignment) != 0) {
5830 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-hitShaderBindingOffset-02460",
5831 "vkCmdTraceRaysNV: hitShaderBindingOffset must be a multiple of "
5832 "VkPhysicalDeviceRayTracingPropertiesNV::shaderGroupBaseAlignment.");
5833 }
5834 if (SafeModulo(hitShaderBindingStride, phys_dev_ext_props.ray_tracing_propsNV.shaderGroupHandleSize) != 0) {
5835 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-hitShaderBindingStride-02464",
5836 "vkCmdTraceRaysNV: hitShaderBindingStride must be a multiple of "
5837 "VkPhysicalDeviceRayTracingPropertiesNV::shaderGroupHandleSize.");
5838 }
5839 if (hitShaderBindingStride > phys_dev_ext_props.ray_tracing_propsNV.maxShaderGroupStride) {
5840 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-hitShaderBindingStride-02467",
5841 "vkCmdTraceRaysNV: hitShaderBindingStride must be less than or equal to "
5842 "VkPhysicalDeviceRayTracingPropertiesNV::maxShaderGroupStride.");
5843 }
5844
5845 // missShader
5846 if (SafeModulo(missShaderBindingOffset, phys_dev_ext_props.ray_tracing_propsNV.shaderGroupBaseAlignment) != 0) {
5847 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-missShaderBindingOffset-02458",
5848 "vkCmdTraceRaysNV: missShaderBindingOffset must be a multiple of "
5849 "VkPhysicalDeviceRayTracingPropertiesNV::shaderGroupBaseAlignment.");
5850 }
5851 if (SafeModulo(missShaderBindingStride, phys_dev_ext_props.ray_tracing_propsNV.shaderGroupHandleSize) != 0) {
5852 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-missShaderBindingStride-02463",
5853 "vkCmdTraceRaysNV: missShaderBindingStride must be a multiple of "
5854 "VkPhysicalDeviceRayTracingPropertiesNV::shaderGroupHandleSize.");
5855 }
5856 if (missShaderBindingStride > phys_dev_ext_props.ray_tracing_propsNV.maxShaderGroupStride) {
5857 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-missShaderBindingStride-02466",
5858 "vkCmdTraceRaysNV: missShaderBindingStride must be less than or equal to "
5859 "VkPhysicalDeviceRayTracingPropertiesNV::maxShaderGroupStride.");
5860 }
5861
5862 // raygenShader
5863 if (SafeModulo(raygenShaderBindingOffset, phys_dev_ext_props.ray_tracing_propsNV.shaderGroupBaseAlignment) != 0) {
5864 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-raygenShaderBindingOffset-02456",
5865 "vkCmdTraceRaysNV: raygenShaderBindingOffset must be a multiple of "
sourav parmard1521802020-06-07 21:49:02 -07005866 "VkPhysicalDeviceRayTracingPropertiesNV::shaderGroupBaseAlignment.");
5867 }
5868 if (width > device_limits.maxComputeWorkGroupCount[0]) {
5869 skip |=
5870 LogError(device, "VUID-vkCmdTraceRaysNV-width-02469",
5871 "vkCmdTraceRaysNV: width must be less than or equal to VkPhysicalDeviceLimits::maxComputeWorkGroupCount[o].");
5872 }
5873 if (height > device_limits.maxComputeWorkGroupCount[1]) {
5874 skip |=
5875 LogError(device, "VUID-vkCmdTraceRaysNV-height-02470",
5876 "vkCmdTraceRaysNV: height must be less than or equal to VkPhysicalDeviceLimits::maxComputeWorkGroupCount[1].");
5877 }
5878 if (depth > device_limits.maxComputeWorkGroupCount[2]) {
5879 skip |=
5880 LogError(device, "VUID-vkCmdTraceRaysNV-depth-02471",
5881 "vkCmdTraceRaysNV: depth must be less than or equal to VkPhysicalDeviceLimits::maxComputeWorkGroupCount[2].");
sourav parmar83c31b12020-05-06 12:30:54 -07005882 }
5883 return skip;
5884}
5885
sourav parmar83c31b12020-05-06 12:30:54 -07005886bool StatelessValidation::manual_PreCallValidateGetDeviceAccelerationStructureCompatibilityKHR(
sourav parmarcd5fb182020-07-17 12:58:44 -07005887 VkDevice device, const VkAccelerationStructureVersionInfoKHR *pVersionInfo,
5888 VkAccelerationStructureCompatibilityKHR *pCompatibility) const {
sourav parmar83c31b12020-05-06 12:30:54 -07005889 bool skip = false;
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005890 const auto *ray_query_features = LvlFindInChain<VkPhysicalDeviceRayQueryFeaturesKHR>(device_createinfo_pnext);
5891 const auto *raytracing_features = LvlFindInChain<VkPhysicalDeviceRayTracingPipelineFeaturesKHR>(device_createinfo_pnext);
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07005892 if ((!raytracing_features && !ray_query_features) || ((ray_query_features && !(ray_query_features->rayQuery)) ||
5893 (raytracing_features && !raytracing_features->rayTracingPipeline))) {
sourav parmarcd5fb182020-07-17 12:58:44 -07005894 skip |= LogError(device, "VUID-vkGetDeviceAccelerationStructureCompatibilityKHR-rayTracingPipeline-03661",
sourav parmar83c31b12020-05-06 12:30:54 -07005895 "vkGetDeviceAccelerationStructureCompatibilityKHR: The rayTracing or rayQuery feature must be enabled.");
5896 }
5897 return skip;
5898}
5899
Piers Daniell39842ee2020-07-10 16:42:33 -06005900bool StatelessValidation::manual_PreCallValidateCmdSetViewportWithCountEXT(VkCommandBuffer commandBuffer, uint32_t viewportCount,
5901 const VkViewport *pViewports) const {
5902 bool skip = false;
5903
5904 if (!physical_device_features.multiViewport) {
5905 if (viewportCount != 1) {
5906 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewportWithCountEXT-viewportCount-03395",
5907 "vkCmdSetViewportWithCountEXT: The multiViewport feature is disabled, but viewportCount (=%" PRIu32
5908 ") is not 1.",
5909 viewportCount);
5910 }
5911 } else { // multiViewport enabled
5912 if (viewportCount < 1 || viewportCount > device_limits.maxViewports) {
5913 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewportWithCountEXT-viewportCount-03394",
5914 "vkCmdSetViewportWithCountEXT: viewportCount (=%" PRIu32
5915 ") must "
5916 "not be greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
5917 viewportCount, device_limits.maxViewports);
5918 }
5919 }
5920
5921 if (pViewports) {
5922 for (uint32_t viewport_i = 0; viewport_i < viewportCount; ++viewport_i) {
5923 const auto &viewport = pViewports[viewport_i]; // will crash on invalid ptr
5924 const char *fn_name = "vkCmdSetViewportWithCountEXT";
5925 skip |= manual_PreCallValidateViewport(
5926 viewport, fn_name, ParameterName("pViewports[%i]", ParameterName::IndexVector{viewport_i}), commandBuffer);
5927 }
5928 }
5929
5930 return skip;
5931}
5932
5933bool StatelessValidation::manual_PreCallValidateCmdSetScissorWithCountEXT(VkCommandBuffer commandBuffer, uint32_t scissorCount,
5934 const VkRect2D *pScissors) const {
5935 bool skip = false;
5936
5937 if (!physical_device_features.multiViewport) {
5938 if (scissorCount != 1) {
5939 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissorWithCountEXT-scissorCount-03398",
5940 "vkCmdSetScissorWithCountEXT: scissorCount (=%" PRIu32
5941 ") must "
5942 "be 1 when the multiViewport feature is disabled.",
5943 scissorCount);
5944 }
5945 } else { // multiViewport enabled
5946 if (scissorCount == 0) {
5947 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissorWithCountEXT-scissorCount-03397",
5948 "vkCmdSetScissorWithCountEXT: scissorCount (=%" PRIu32
5949 ") must "
5950 "be great than zero.",
5951 scissorCount);
5952 } else if (scissorCount > device_limits.maxViewports) {
5953 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissorWithCountEXT-scissorCount-03397",
5954 "vkCmdSetScissorWithCountEXT: scissorCount (=%" PRIu32
5955 ") must "
5956 "not be greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
5957 scissorCount, device_limits.maxViewports);
5958 }
5959 }
5960
5961 if (pScissors) {
5962 for (uint32_t scissor_i = 0; scissor_i < scissorCount; ++scissor_i) {
5963 const auto &scissor = pScissors[scissor_i]; // will crash on invalid ptr
5964
5965 if (scissor.offset.x < 0) {
5966 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissorWithCountEXT-x-03399",
5967 "vkCmdSetScissor: pScissors[%" PRIu32 "].offset.x (=%" PRIi32 ") is negative.", scissor_i,
5968 scissor.offset.x);
5969 }
5970
5971 if (scissor.offset.y < 0) {
5972 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissorWithCountEXT-x-03399",
5973 "vkCmdSetScissor: pScissors[%" PRIu32 "].offset.y (=%" PRIi32 ") is negative.", scissor_i,
5974 scissor.offset.y);
5975 }
5976
5977 const int64_t x_sum = static_cast<int64_t>(scissor.offset.x) + static_cast<int64_t>(scissor.extent.width);
5978 if (x_sum > INT32_MAX) {
5979 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissorWithCountEXT-offset-03400",
5980 "vkCmdSetScissor: offset.x + extent.width (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
5981 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
5982 scissor.offset.x, scissor.extent.width, x_sum, scissor_i);
5983 }
5984
5985 const int64_t y_sum = static_cast<int64_t>(scissor.offset.y) + static_cast<int64_t>(scissor.extent.height);
5986 if (y_sum > INT32_MAX) {
5987 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissorWithCountEXT-offset-03401",
5988 "vkCmdSetScissor: offset.y + extent.height (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
5989 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
5990 scissor.offset.y, scissor.extent.height, y_sum, scissor_i);
5991 }
5992 }
5993 }
5994
5995 return skip;
5996}
5997
5998bool StatelessValidation::manual_PreCallValidateCmdBindVertexBuffers2EXT(VkCommandBuffer commandBuffer, uint32_t firstBinding,
5999 uint32_t bindingCount, const VkBuffer *pBuffers,
6000 const VkDeviceSize *pOffsets, const VkDeviceSize *pSizes,
6001 const VkDeviceSize *pStrides) const {
6002 bool skip = false;
6003 if (firstBinding >= device_limits.maxVertexInputBindings) {
6004 skip |= LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers2EXT-firstBinding-03355",
6005 "vkCmdBindVertexBuffers2EXT() firstBinding (%u) must be less than maxVertexInputBindings (%u)",
6006 firstBinding, device_limits.maxVertexInputBindings);
6007 } else if ((firstBinding + bindingCount) > device_limits.maxVertexInputBindings) {
6008 skip |= LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers2EXT-firstBinding-03356",
6009 "vkCmdBindVertexBuffers2EXT() sum of firstBinding (%u) and bindingCount (%u) must be less than "
6010 "maxVertexInputBindings (%u)",
6011 firstBinding, bindingCount, device_limits.maxVertexInputBindings);
6012 }
6013
6014 for (uint32_t i = 0; i < bindingCount; ++i) {
6015 if (pBuffers[i] == VK_NULL_HANDLE) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07006016 const auto *robustness2_features = LvlFindInChain<VkPhysicalDeviceRobustness2FeaturesEXT>(device_createinfo_pnext);
Piers Daniell39842ee2020-07-10 16:42:33 -06006017 if (!(robustness2_features && robustness2_features->nullDescriptor)) {
6018 skip |= LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers2EXT-pBuffers-04111",
6019 "vkCmdBindVertexBuffers2EXT() required parameter pBuffers[%d] specified as VK_NULL_HANDLE", i);
6020 } else {
6021 if (pOffsets[i] != 0) {
6022 skip |=
6023 LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers2EXT-pBuffers-04112",
6024 "vkCmdBindVertexBuffers2EXT() pBuffers[%d] is VK_NULL_HANDLE, but pOffsets[%d] is not 0", i, i);
6025 }
6026 }
6027 }
6028 if (pStrides) {
6029 if (pStrides[i] > device_limits.maxVertexInputBindingStride) {
6030 skip |=
6031 LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers2EXT-pStrides-03362",
6032 "vkCmdBindVertexBuffers2EXT() pStrides[%d] (%u) must be less than maxVertexInputBindingStride (%u)", i,
6033 pStrides[i], device_limits.maxVertexInputBindingStride);
6034 }
6035 }
6036 }
6037
6038 return skip;
6039}
sourav parmarcd5fb182020-07-17 12:58:44 -07006040
6041bool StatelessValidation::ValidateAccelerationStructureBuildGeometryInfoKHR(
6042 const VkAccelerationStructureBuildGeometryInfoKHR *pInfos, uint32_t infoCount, const char *api_name) const {
6043 bool skip = false;
6044 for (uint32_t i = 0; i < infoCount; ++i) {
6045 if (pInfos[i].type == VK_ACCELERATION_STRUCTURE_TYPE_GENERIC_KHR) {
6046 skip |= LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-type-03654",
6047 "(%s): type must not be VK_ACCELERATION_STRUCTURE_TYPE_GENERIC_KHR.", api_name);
6048 }
6049 if (pInfos[i].flags & VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_TRACE_BIT_KHR &&
6050 pInfos[i].flags & VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_BUILD_BIT_KHR) {
6051 skip |= LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-flags-03796",
6052 "(%s): If flags has the VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_TRACE_BIT_KHR bit set,"
6053 "then it must not have the VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_BUILD_BIT_KHR bit set.",
6054 api_name);
6055 }
6056 if (pInfos[i].pGeometries && pInfos[i].ppGeometries) {
6057 skip |=
6058 LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-pGeometries-03788",
6059 "(%s): Only one of pGeometries or ppGeometries can be a valid pointer, the other must be NULL", api_name);
6060 }
6061 if (pInfos[i].type == VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_KHR && pInfos[i].geometryCount != 1) {
6062 skip |= LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-type-03790",
6063 "(%s): If type is VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_KHR, geometryCount must be 1", api_name);
6064 }
6065 if (pInfos[i].type == VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_KHR &&
6066 pInfos[i].geometryCount > phys_dev_ext_props.acc_structure_props.maxGeometryCount) {
6067 skip |= LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-type-03793",
6068 "(%s): If type is VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_KHR then geometryCount must be"
6069 " less than or equal to VkPhysicalDeviceAccelerationStructurePropertiesKHR::maxGeometryCount",
6070 api_name);
6071 }
6072 if (pInfos[i].pGeometries) {
6073 for (uint32_t j = 0; j < pInfos[i].geometryCount; ++j) {
6074 skip |= validate_ranged_enum(
6075 api_name, ParameterName("pInfos[%i].pGeometries[%i].geometryType", ParameterName::IndexVector{i, j}),
6076 "VkGeometryTypeKHR", AllVkGeometryTypeKHREnums, pInfos[i].pGeometries[j].geometryType,
6077 "VUID-VkAccelerationStructureGeometryKHR-geometryType-parameter");
6078 if (pInfos[i].pGeometries[j].geometryType == VK_GEOMETRY_TYPE_TRIANGLES_KHR) {
sourav parmarcd5fb182020-07-17 12:58:44 -07006079 skip |= validate_struct_type(
6080 api_name, ParameterName("pInfos[%i].pGeometries[%i].geometry.triangles", ParameterName::IndexVector{i, j}),
6081 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_TRIANGLES_DATA_KHR",
6082 &(pInfos[i].pGeometries[j].geometry.triangles),
6083 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_TRIANGLES_DATA_KHR, false, kVUIDUndefined,
6084 "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-sType-sType");
6085 skip |= validate_struct_pnext(
6086 api_name,
6087 ParameterName("pInfos[%i].pGeometries[%i].geometry.triangles.pNext", ParameterName::IndexVector{i, j}),
6088 NULL, pInfos[i].pGeometries[j].geometry.triangles.pNext, 0, NULL, GeneratedVulkanHeaderVersion,
6089 "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-pNext-pNext", kVUIDUndefined);
6090 skip |=
6091 validate_ranged_enum(api_name,
6092 ParameterName("pInfos[%i].pGeometries[%i].geometry.triangles.vertexFormat",
6093 ParameterName::IndexVector{i, j}),
6094 "VkFormat", AllVkFormatEnums, pInfos[i].pGeometries[j].geometry.triangles.vertexFormat,
6095 "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-vertexFormat-parameter");
6096 skip |= validate_struct_type(api_name, "pInfos[i].pGeometries[j].geometry.triangles",
6097 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_TRIANGLES_DATA_KHR",
6098 &pInfos[i].pGeometries[j].geometry.triangles,
6099 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_TRIANGLES_DATA_KHR, true,
6100 "VUID-VkAccelerationStructureGeometryKHR-triangles-parameter", kVUIDUndefined);
6101 skip |= validate_ranged_enum(
6102 api_name,
6103 ParameterName("pInfos[%i].pGeometries[%i].geometry.triangles.indexType", ParameterName::IndexVector{i, j}),
6104 "VkIndexType", AllVkIndexTypeEnums, pInfos[i].pGeometries[j].geometry.triangles.indexType,
6105 "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-indexType-parameter");
6106
6107 if (pInfos[i].pGeometries[j].geometry.triangles.vertexStride > UINT32_MAX) {
6108 skip |= LogError(device, "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-vertexStride-03819",
6109 "(%s):vertexStride must be less than or equal to 2^32-1", api_name);
6110 }
6111 if (pInfos[i].pGeometries[j].geometry.triangles.indexType != VK_INDEX_TYPE_UINT16 &&
6112 pInfos[i].pGeometries[j].geometry.triangles.indexType != VK_INDEX_TYPE_UINT32 &&
6113 pInfos[i].pGeometries[j].geometry.triangles.indexType != VK_INDEX_TYPE_NONE_KHR) {
6114 skip |=
6115 LogError(device, "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-indexType-03798",
6116 "(%s):indexType must be VK_INDEX_TYPE_UINT16, VK_INDEX_TYPE_UINT32, or VK_INDEX_TYPE_NONE_KHR",
6117 api_name);
6118 }
6119 }
6120 if (pInfos[i].pGeometries[j].geometryType == VK_GEOMETRY_TYPE_INSTANCES_KHR) {
6121 skip |= validate_struct_type(api_name, "pInfos[i].pGeometries[j].geometry.instances",
6122 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_INSTANCES_DATA_KHR",
6123 &pInfos[i].pGeometries[j].geometry.instances,
6124 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_INSTANCES_DATA_KHR, true,
6125 "VUID-VkAccelerationStructureGeometryKHR-instances-parameter", kVUIDUndefined);
6126 skip |= validate_struct_type(
6127 api_name, ParameterName("pInfos[%i].pGeometries[%i].geometry.instances", ParameterName::IndexVector{i, j}),
6128 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_INSTANCES_DATA_KHR",
6129 &(pInfos[i].pGeometries[j].geometry.instances),
6130 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_INSTANCES_DATA_KHR, false, kVUIDUndefined,
6131 "VUID-VkAccelerationStructureGeometryInstancesDataKHR-sType-sType");
6132 skip |= validate_struct_pnext(
6133 api_name,
6134 ParameterName("pInfos[%i].pGeometries[%i].geometry.instances.pNext", ParameterName::IndexVector{i, j}),
6135 NULL, pInfos[i].pGeometries[j].geometry.instances.pNext, 0, NULL, GeneratedVulkanHeaderVersion,
6136 "VUID-VkAccelerationStructureGeometryInstancesDataKHR-pNext-pNext", kVUIDUndefined);
6137
6138 skip |= validate_bool32(api_name,
6139 ParameterName("pInfos[%i].pGeometries[%i].geometry.instances.arrayOfPointers",
6140 ParameterName::IndexVector{i, j}),
6141 pInfos[i].pGeometries[j].geometry.instances.arrayOfPointers);
6142 }
6143 if (pInfos[i].pGeometries[j].geometryType == VK_GEOMETRY_TYPE_AABBS_KHR) {
6144 skip |= validate_struct_type(api_name, "pInfos[i].pGeometries[j].geometry.aabbs",
6145 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_AABBS_DATA_KHR",
6146 &pInfos[i].pGeometries[j].geometry.aabbs,
6147 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_AABBS_DATA_KHR, true,
6148 "VUID-VkAccelerationStructureGeometryKHR-aabbs-parameter", kVUIDUndefined);
6149 skip |= validate_struct_type(
6150 api_name, ParameterName("pInfos[%i].pGeometries[%i].geometry.aabbs", ParameterName::IndexVector{i, j}),
6151 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_AABBS_DATA_KHR",
6152 &(pInfos[i].pGeometries[j].geometry.aabbs),
6153 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_AABBS_DATA_KHR, false, kVUIDUndefined,
6154 "VUID-VkAccelerationStructureGeometryAabbsDataKHR-sType-sType");
6155 skip |= validate_struct_pnext(
6156 api_name,
6157 ParameterName("pInfos[%i].pGeometries[%i].geometry.aabbs.pNext", ParameterName::IndexVector{i, j}), NULL,
6158 pInfos[i].pGeometries[j].geometry.aabbs.pNext, 0, NULL, GeneratedVulkanHeaderVersion,
6159 "VUID-VkAccelerationStructureGeometryAabbsDataKHR-pNext-pNext", kVUIDUndefined);
6160 if (pInfos[i].pGeometries[j].geometry.aabbs.stride > UINT32_MAX) {
6161 skip |= LogError(device, "VUID-VkAccelerationStructureGeometryAabbsDataKHR-stride-03820",
6162 "(%s):stride must be less than or equal to 2^32-1", api_name);
6163 }
6164 }
6165 if (pInfos[i].type == VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_KHR &&
6166 pInfos[i].pGeometries[j].geometryType != VK_GEOMETRY_TYPE_INSTANCES_KHR) {
6167 skip |= LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-type-03789",
6168 "(%s): If type is VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_KHR, the geometryType member"
6169 " of elements of either pGeometries or ppGeometries must be VK_GEOMETRY_TYPE_INSTANCES_KHR",
6170 api_name);
6171 }
6172 if (pInfos[i].type == VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_KHR) {
6173 if (pInfos[i].pGeometries[j].geometryType == VK_GEOMETRY_TYPE_INSTANCES_KHR) {
6174 skip |= LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-type-03791",
6175 "(%s): If type is VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_KHR the geometryType member "
6176 "of elements of"
6177 " either pGeometries or ppGeometries must not be VK_GEOMETRY_TYPE_INSTANCES_KHR",
6178 api_name);
6179 }
6180 if (pInfos[i].pGeometries[j].geometryType != pInfos[i].pGeometries[0].geometryType) {
6181 skip |= LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-type-03792",
6182 "(%s): If type is VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_KHR then the geometryType"
6183 " member of each geometry in either pGeometries or ppGeometries must be the same.",
6184 api_name);
6185 }
6186 }
6187 }
6188 }
6189 if (pInfos[i].ppGeometries != NULL) {
6190 for (uint32_t j = 0; j < pInfos[i].geometryCount; ++j) {
6191 skip |= validate_ranged_enum(
6192 api_name, ParameterName("pInfos[%i].ppGeometries[%i]->geometryType", ParameterName::IndexVector{i, j}),
6193 "VkGeometryTypeKHR", AllVkGeometryTypeKHREnums, pInfos[i].ppGeometries[j]->geometryType,
6194 "VUID-VkAccelerationStructureGeometryKHR-geometryType-parameter");
6195 if (pInfos[i].ppGeometries[j]->geometryType == VK_GEOMETRY_TYPE_TRIANGLES_KHR) {
sourav parmarcd5fb182020-07-17 12:58:44 -07006196 skip |= validate_struct_type(api_name, "pInfos[i].pGeometries[j].geometry.triangles",
6197 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_TRIANGLES_DATA_KHR",
6198 &pInfos[i].ppGeometries[j]->geometry.triangles,
6199 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_TRIANGLES_DATA_KHR, true,
6200 "VUID-VkAccelerationStructureGeometryKHR-triangles-parameter", kVUIDUndefined);
6201 skip |= validate_struct_type(
6202 api_name,
6203 ParameterName("pInfos[%i].ppGeometries[%i]->geometry.triangles", ParameterName::IndexVector{i, j}),
6204 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_TRIANGLES_DATA_KHR",
6205 &(pInfos[i].ppGeometries[j]->geometry.triangles),
6206 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_TRIANGLES_DATA_KHR, false, kVUIDUndefined,
6207 "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-sType-sType");
6208 skip |= validate_struct_pnext(
6209 api_name,
6210 ParameterName("pInfos[%i].ppGeometries[%i]->geometry.triangles.pNext", ParameterName::IndexVector{i, j}),
6211 NULL, pInfos[i].ppGeometries[j]->geometry.triangles.pNext, 0, NULL, GeneratedVulkanHeaderVersion,
6212 "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-pNext-pNext", kVUIDUndefined);
6213 skip |= validate_ranged_enum(api_name,
6214 ParameterName("pInfos[%i].ppGeometries[%i]->geometry.triangles.vertexFormat",
6215 ParameterName::IndexVector{i, j}),
6216 "VkFormat", AllVkFormatEnums,
6217 pInfos[i].ppGeometries[j]->geometry.triangles.vertexFormat,
6218 "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-vertexFormat-parameter");
6219 skip |= validate_ranged_enum(api_name,
6220 ParameterName("pInfos[%i].ppGeometries[%i]->geometry.triangles.indexType",
6221 ParameterName::IndexVector{i, j}),
6222 "VkIndexType", AllVkIndexTypeEnums,
6223 pInfos[i].ppGeometries[j]->geometry.triangles.indexType,
6224 "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-indexType-parameter");
6225 if (pInfos[i].ppGeometries[j]->geometry.triangles.vertexStride > UINT32_MAX) {
6226 skip |= LogError(device, "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-vertexStride-03819",
6227 "(%s):vertexStride must be less than or equal to 2^32-1", api_name);
6228 }
6229 if (pInfos[i].ppGeometries[j]->geometry.triangles.indexType != VK_INDEX_TYPE_UINT16 &&
6230 pInfos[i].ppGeometries[j]->geometry.triangles.indexType != VK_INDEX_TYPE_UINT32 &&
6231 pInfos[i].ppGeometries[j]->geometry.triangles.indexType != VK_INDEX_TYPE_NONE_KHR) {
6232 skip |=
6233 LogError(device, "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-indexType-03798",
6234 "(%s):indexType must be VK_INDEX_TYPE_UINT16, VK_INDEX_TYPE_UINT32, or VK_INDEX_TYPE_NONE_KHR",
6235 api_name);
6236 }
6237 }
6238 if (pInfos[i].ppGeometries[j]->geometryType == VK_GEOMETRY_TYPE_INSTANCES_KHR) {
6239 skip |= validate_struct_type(api_name, "pInfos[i].pGeometries[j].geometry.instances",
6240 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_INSTANCES_DATA_KHR",
6241 &pInfos[i].ppGeometries[j]->geometry.instances,
6242 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_INSTANCES_DATA_KHR, true,
6243 "VUID-VkAccelerationStructureGeometryKHR-instances-parameter", kVUIDUndefined);
6244 skip |= validate_struct_type(
6245 api_name,
6246 ParameterName("pInfos[%i].ppGeometries[%i]->geometry.instances", ParameterName::IndexVector{i, j}),
6247 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_INSTANCES_DATA_KHR",
6248 &(pInfos[i].ppGeometries[j]->geometry.instances),
6249 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_INSTANCES_DATA_KHR, false, kVUIDUndefined,
6250 "VUID-VkAccelerationStructureGeometryInstancesDataKHR-sType-sType");
6251 skip |= validate_struct_pnext(
6252 api_name,
6253 ParameterName("pInfos[%i].ppGeometries[%i]->geometry.instances.pNext", ParameterName::IndexVector{i, j}),
6254 NULL, pInfos[i].ppGeometries[j]->geometry.instances.pNext, 0, NULL, GeneratedVulkanHeaderVersion,
6255 "VUID-VkAccelerationStructureGeometryInstancesDataKHR-pNext-pNext", kVUIDUndefined);
6256 skip |= validate_bool32(api_name,
6257 ParameterName("pInfos[%i].ppGeometries[%i]->geometry.instances.arrayOfPointers",
6258 ParameterName::IndexVector{i, j}),
6259 pInfos[i].ppGeometries[j]->geometry.instances.arrayOfPointers);
6260 }
6261 if (pInfos[i].ppGeometries[j]->geometryType == VK_GEOMETRY_TYPE_AABBS_KHR) {
6262 skip |= validate_struct_type(api_name, "pInfos[i].pGeometries[j].geometry.aabbs",
6263 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_AABBS_DATA_KHR",
6264 &pInfos[i].ppGeometries[j]->geometry.aabbs,
6265 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_AABBS_DATA_KHR, true,
6266 "VUID-VkAccelerationStructureGeometryKHR-aabbs-parameter", kVUIDUndefined);
6267 skip |= validate_struct_type(
6268 api_name, ParameterName("pInfos[%i].ppGeometries[%i]->geometry.aabbs", ParameterName::IndexVector{i, j}),
6269 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_AABBS_DATA_KHR",
6270 &(pInfos[i].ppGeometries[j]->geometry.aabbs),
6271 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_AABBS_DATA_KHR, false, kVUIDUndefined,
6272 "VUID-VkAccelerationStructureGeometryAabbsDataKHR-sType-sType");
6273 skip |= validate_struct_pnext(
6274 api_name,
6275 ParameterName("pInfos[%i].ppGeometries[%i]->geometry.aabbs.pNext", ParameterName::IndexVector{i, j}), NULL,
6276 pInfos[i].ppGeometries[j]->geometry.aabbs.pNext, 0, NULL, GeneratedVulkanHeaderVersion,
6277 "VUID-VkAccelerationStructureGeometryAabbsDataKHR-pNext-pNext", kVUIDUndefined);
6278 if (pInfos[i].ppGeometries[j]->geometry.aabbs.stride > UINT32_MAX) {
6279 skip |= LogError(device, "VUID-VkAccelerationStructureGeometryAabbsDataKHR-stride-03820",
6280 "(%s):stride must be less than or equal to 2^32-1", api_name);
6281 }
6282 }
6283 if (pInfos[i].type == VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_KHR &&
6284 pInfos[i].ppGeometries[j]->geometryType != VK_GEOMETRY_TYPE_INSTANCES_KHR) {
6285 skip |= LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-type-03789",
6286 "(%s): If type is VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_KHR, the geometryType member"
6287 " of elements of either pGeometries or ppGeometries must be VK_GEOMETRY_TYPE_INSTANCES_KHR",
6288 api_name);
6289 }
6290 if (pInfos[i].type == VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_KHR) {
6291 if (pInfos[i].ppGeometries[j]->geometryType == VK_GEOMETRY_TYPE_INSTANCES_KHR) {
6292 skip |= LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-type-03791",
6293 "(%s): If type is VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_KHR the geometryType member "
6294 "of elements of"
6295 " either pGeometries or ppGeometries must not be VK_GEOMETRY_TYPE_INSTANCES_KHR",
6296 api_name);
6297 }
6298 if (pInfos[i].ppGeometries[j]->geometryType != pInfos[i].ppGeometries[0]->geometryType) {
6299 skip |= LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-type-03792",
6300 "(%s): If type is VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_KHR then the geometryType"
6301 " member of each geometry in either pGeometries or ppGeometries must be the same.",
6302 api_name);
6303 }
6304 }
6305 }
6306 }
6307 }
6308 return skip;
6309}
6310bool StatelessValidation::manual_PreCallValidateCmdBuildAccelerationStructuresKHR(
6311 VkCommandBuffer commandBuffer, uint32_t infoCount, const VkAccelerationStructureBuildGeometryInfoKHR *pInfos,
6312 const VkAccelerationStructureBuildRangeInfoKHR *const *ppBuildRangeInfos) const {
6313 bool skip = false;
6314 skip |= ValidateAccelerationStructureBuildGeometryInfoKHR(pInfos, infoCount, "vkCmdBuildAccelerationStructuresKHR");
6315 for (uint32_t i = 0; i < infoCount; ++i) {
6316 if (SafeModulo(pInfos[i].scratchData.deviceAddress,
6317 phys_dev_ext_props.acc_structure_props.minAccelerationStructureScratchOffsetAlignment) != 0) {
6318 skip |= LogError(device, "VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-03710",
6319 "vkCmdBuildAccelerationStructuresKHR:For each element of pInfos, its "
6320 "scratchData.deviceAddress member must be a multiple of "
6321 "VkPhysicalDeviceAccelerationStructurePropertiesKHR::minAccelerationStructureScratchOffsetAlignment.");
6322 }
6323 for (uint32_t k = 0; k < infoCount; ++k) {
6324 if (i == k) continue;
6325 bool found = false;
6326 if (pInfos[i].dstAccelerationStructure == pInfos[k].dstAccelerationStructure) {
6327 skip |= LogError(
6328 device, "VUID-vkCmdBuildAccelerationStructuresKHR-dstAccelerationStructure-03698",
6329 "vkCmdBuildAccelerationStructuresKHR:The dstAccelerationStructure member of any element (%d) of pInfos must "
6330 "not be "
6331 "the same acceleration structure as the dstAccelerationStructure member of any other element (%d) of pInfos.",
6332 i, k);
6333 found = true;
6334 }
6335 if (pInfos[i].srcAccelerationStructure == pInfos[k].dstAccelerationStructure) {
6336 skip |= LogError(
6337 device, "VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-03403",
6338 "vkCmdBuildAccelerationStructuresKHR:The srcAccelerationStructure member of any element (%d) of pInfos must "
6339 "not be "
6340 "the same acceleration structure as the dstAccelerationStructure member of any other element (%d) of pInfos.",
6341 i, k);
6342 found = true;
6343 }
6344 if (found) break;
6345 }
6346 for (uint32_t j = 0; j < pInfos[i].geometryCount; ++j) {
6347 if (pInfos[i].pGeometries) {
6348 if (pInfos[i].pGeometries[j].geometryType == VK_GEOMETRY_TYPE_INSTANCES_KHR) {
6349 if (pInfos[i].pGeometries[j].geometry.instances.arrayOfPointers == VK_TRUE) {
6350 if (SafeModulo(pInfos[i].pGeometries[j].geometry.instances.data.deviceAddress, 8) != 0) {
6351 skip |= LogError(device, "VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-03716",
6352 "vkCmdBuildAccelerationStructuresKHR:For any element of pInfos[i].pGeometries with a "
6353 "geometryType of VK_GEOMETRY_TYPE_INSTANCES_KHR, if geometry.arrayOfPointers is "
6354 "VK_TRUE, geometry.data->deviceAddress must be aligned to 8 bytes.");
6355 }
6356 } else {
6357 if (SafeModulo(pInfos[i].pGeometries[j].geometry.instances.data.deviceAddress, 16) != 0) {
6358 skip |=
6359 LogError(device, "VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-03715",
6360 "vkCmdBuildAccelerationStructuresKHR:For any element of pInfos[i].pGeometries with a "
6361 "geometryType of VK_GEOMETRY_TYPE_INSTANCES_KHR, if geometry.arrayOfPointers is VK_FALSE, "
6362 "geometry.data->deviceAddress must be aligned to 16 bytes.");
6363 }
6364 }
Ricardo Garcia2ba3da82020-12-02 11:27:53 +01006365 } else if (pInfos[i].pGeometries[j].geometryType == VK_GEOMETRY_TYPE_AABBS_KHR) {
sourav parmarcd5fb182020-07-17 12:58:44 -07006366 if (SafeModulo(pInfos[i].pGeometries[j].geometry.instances.data.deviceAddress, 8) != 0) {
6367 skip |= LogError(
6368 device, "VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-03714",
6369 "vkCmdBuildAccelerationStructuresKHR:For any element of pInfos[i].pGeometries with a "
6370 "geometryType of VK_GEOMETRY_TYPE_AABBS_KHR, geometry.data->deviceAddress must be aligned to 8 bytes.");
6371 }
Ricardo Garcia2ba3da82020-12-02 11:27:53 +01006372 } else if (pInfos[i].pGeometries[j].geometryType == VK_GEOMETRY_TYPE_TRIANGLES_KHR) {
6373 if (SafeModulo(pInfos[i].pGeometries[j].geometry.triangles.transformData.deviceAddress, 16) != 0) {
sourav parmarcd5fb182020-07-17 12:58:44 -07006374 skip |= LogError(device, "VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-03810",
6375 "vkCmdBuildAccelerationStructuresKHR:For any element of pInfos[i].pGeometries "
6376 "with a geometryType of VK_GEOMETRY_TYPE_TRIANGLES_KHR, "
6377 "geometry.transformData->deviceAddress must be aligned to 16 bytes.");
6378 }
6379 }
6380 } else if (pInfos[i].ppGeometries) {
6381 if (pInfos[i].ppGeometries[j]->geometryType == VK_GEOMETRY_TYPE_INSTANCES_KHR) {
6382 if (pInfos[i].ppGeometries[j]->geometry.instances.arrayOfPointers == VK_TRUE) {
6383 if (SafeModulo(pInfos[i].ppGeometries[j]->geometry.instances.data.deviceAddress, 8) != 0) {
6384 skip |= LogError(device, "VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-03716",
6385 "vkCmdBuildAccelerationStructuresKHR:For any element of pInfos[i].pGeometries with a "
6386 "geometryType of VK_GEOMETRY_TYPE_INSTANCES_KHR, if geometry.arrayOfPointers is "
6387 "VK_TRUE, geometry.data->deviceAddress must be aligned to 8 bytes.");
6388 }
6389 } else {
6390 if (SafeModulo(pInfos[i].ppGeometries[j]->geometry.instances.data.deviceAddress, 16) != 0) {
6391 skip |=
6392 LogError(device, "VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-03715",
6393 "vkCmdBuildAccelerationStructuresKHR:For any element of pInfos[i].pGeometries with a "
6394 "geometryType of VK_GEOMETRY_TYPE_INSTANCES_KHR, if geometry.arrayOfPointers is VK_FALSE, "
6395 "geometry.data->deviceAddress must be aligned to 16 bytes.");
6396 }
6397 }
Ricardo Garcia2ba3da82020-12-02 11:27:53 +01006398 } else if (pInfos[i].ppGeometries[j]->geometryType == VK_GEOMETRY_TYPE_AABBS_KHR) {
sourav parmarcd5fb182020-07-17 12:58:44 -07006399 if (SafeModulo(pInfos[i].ppGeometries[j]->geometry.instances.data.deviceAddress, 8) != 0) {
6400 skip |= LogError(
6401 device, "VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-03714",
6402 "vkCmdBuildAccelerationStructuresKHR:For any element of pInfos[i].pGeometries with a "
6403 "geometryType of VK_GEOMETRY_TYPE_AABBS_KHR, geometry.data->deviceAddress must be aligned to 8 bytes.");
6404 }
Ricardo Garcia2ba3da82020-12-02 11:27:53 +01006405 } else if (pInfos[i].ppGeometries[j]->geometryType == VK_GEOMETRY_TYPE_TRIANGLES_KHR) {
6406 if (SafeModulo(pInfos[i].ppGeometries[j]->geometry.triangles.transformData.deviceAddress, 16) != 0) {
sourav parmarcd5fb182020-07-17 12:58:44 -07006407 skip |= LogError(device, "VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-03810",
6408 "vkCmdBuildAccelerationStructuresKHR:For any element of pInfos[i].pGeometries "
6409 "with a geometryType of VK_GEOMETRY_TYPE_TRIANGLES_KHR, "
6410 "geometry.transformData->deviceAddress must be aligned to 16 bytes.");
6411 }
6412 }
6413 }
6414 }
6415 }
6416 return skip;
6417}
6418
6419bool StatelessValidation::manual_PreCallValidateCmdBuildAccelerationStructuresIndirectKHR(
6420 VkCommandBuffer commandBuffer, uint32_t infoCount, const VkAccelerationStructureBuildGeometryInfoKHR *pInfos,
6421 const VkDeviceAddress *pIndirectDeviceAddresses, const uint32_t *pIndirectStrides,
6422 const uint32_t *const *ppMaxPrimitiveCounts) const {
6423 bool skip = false;
6424 skip |= ValidateAccelerationStructureBuildGeometryInfoKHR(pInfos, infoCount, "vkCmdBuildAccelerationStructuresIndirectKHR");
6425 const auto *ray_tracing_acceleration_structure_features =
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07006426 LvlFindInChain<VkPhysicalDeviceAccelerationStructureFeaturesKHR>(device_createinfo_pnext);
sourav parmarcd5fb182020-07-17 12:58:44 -07006427 if (!ray_tracing_acceleration_structure_features ||
6428 ray_tracing_acceleration_structure_features->accelerationStructureIndirectBuild == VK_FALSE) {
6429 skip |= LogError(
6430 device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-accelerationStructureIndirectBuild-03650",
6431 "vkCmdBuildAccelerationStructuresIndirectKHR: The "
6432 "VkPhysicalDeviceAccelerationStructureFeaturesKHR::accelerationStructureIndirectBuild feature must be enabled.");
6433 }
6434 for (uint32_t i = 0; i < infoCount; ++i) {
6435 if (pInfos[i].mode == VK_BUILD_ACCELERATION_STRUCTURE_MODE_UPDATE_KHR) {
6436 if (pInfos[i].srcAccelerationStructure == VK_NULL_HANDLE) {
6437 skip |= LogError(device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-03666",
6438 "vkCmdBuildAccelerationStructuresIndirectKHR:For each element of pInfos, if its mode member is "
6439 "VK_BUILD_ACCELERATION_STRUCTURE_MODE_UPDATE_KHR, its srcAccelerationStructure member must not be "
6440 "VK_NULL_HANDLE.");
6441 }
6442 }
6443 if (SafeModulo(pInfos[i].scratchData.deviceAddress,
6444 phys_dev_ext_props.acc_structure_props.minAccelerationStructureScratchOffsetAlignment) != 0) {
6445 skip |= LogError(device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-03710",
6446 "vkCmdBuildAccelerationStructuresIndirectKHR:For each element of pInfos, its "
6447 "scratchData.deviceAddress member must be a multiple of "
6448 "VkPhysicalDeviceAccelerationStructurePropertiesKHR::minAccelerationStructureScratchOffsetAlignment.");
6449 }
6450 for (uint32_t k = 0; k < infoCount; ++k) {
6451 if (i == k) continue;
6452 if (pInfos[i].srcAccelerationStructure == pInfos[k].dstAccelerationStructure) {
6453 skip |=
6454 LogError(device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-03403",
6455 "vkCmdBuildAccelerationStructuresIndirectKHR:The srcAccelerationStructure member of any element (%d) "
6456 "of pInfos must not be the same acceleration structure as the dstAccelerationStructure member of "
6457 "any other element [%d) of pInfos.",
6458 i, k);
6459 break;
6460 }
6461 }
6462 for (uint32_t j = 0; j < pInfos[i].geometryCount; ++j) {
6463 if (pInfos[i].pGeometries) {
6464 if (pInfos[i].pGeometries[j].geometryType == VK_GEOMETRY_TYPE_INSTANCES_KHR) {
6465 if (pInfos[i].pGeometries[j].geometry.instances.arrayOfPointers == VK_TRUE) {
6466 if (SafeModulo(pInfos[i].pGeometries[j].geometry.instances.data.deviceAddress, 8) != 0) {
6467 skip |= LogError(
6468 device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-03716",
6469 "vkCmdBuildAccelerationStructuresIndirectKHR:For any element of pInfos[i].pGeometries with a "
6470 "geometryType of VK_GEOMETRY_TYPE_INSTANCES_KHR, if geometry.arrayOfPointers is "
6471 "VK_TRUE, geometry.data->deviceAddress must be aligned to 8 bytes.");
6472 }
6473 } else {
6474 if (SafeModulo(pInfos[i].pGeometries[j].geometry.instances.data.deviceAddress, 16) != 0) {
6475 skip |= LogError(
6476 device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-03715",
6477 "vkCmdBuildAccelerationStructuresIndirectKHR:For any element of pInfos[i].pGeometries with a "
6478 "geometryType of VK_GEOMETRY_TYPE_INSTANCES_KHR, if geometry.arrayOfPointers is VK_FALSE, "
6479 "geometry.data->deviceAddress must be aligned to 16 bytes.");
6480 }
6481 }
6482 }
6483 if (pInfos[i].pGeometries[j].geometryType == VK_GEOMETRY_TYPE_AABBS_KHR) {
6484 if (SafeModulo(pInfos[i].pGeometries[j].geometry.instances.data.deviceAddress, 8) != 0) {
6485 skip |= LogError(
6486 device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-03714",
6487 "vkCmdBuildAccelerationStructuresIndirectKHR:For any element of pInfos[i].pGeometries with a "
6488 "geometryType of VK_GEOMETRY_TYPE_AABBS_KHR, geometry.data->deviceAddress must be aligned to 8 bytes.");
6489 }
6490 }
6491 if (pInfos[i].pGeometries[j].geometryType == VK_GEOMETRY_TYPE_TRIANGLES_KHR) {
6492 if (SafeModulo(pInfos[i].pGeometries[j].geometry.triangles.indexData.deviceAddress, 16) != 0) {
6493 skip |= LogError(device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-03810",
6494 "vkCmdBuildAccelerationStructuresIndirectKHR:For any element of pInfos[i].pGeometries "
6495 "with a geometryType of VK_GEOMETRY_TYPE_TRIANGLES_KHR, "
6496 "geometry.transformData->deviceAddress must be aligned to 16 bytes.");
6497 }
6498 }
6499 } else if (pInfos[i].ppGeometries) {
6500 if (pInfos[i].ppGeometries[j]->geometryType == VK_GEOMETRY_TYPE_INSTANCES_KHR) {
6501 if (pInfos[i].ppGeometries[j]->geometry.instances.arrayOfPointers == VK_TRUE) {
6502 if (SafeModulo(pInfos[i].ppGeometries[j]->geometry.instances.data.deviceAddress, 8) != 0) {
6503 skip |= LogError(
6504 device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-03716",
6505 "vkCmdBuildAccelerationStructuresIndirectKHR:For any element of pInfos[i].pGeometries with a "
6506 "geometryType of VK_GEOMETRY_TYPE_INSTANCES_KHR, if geometry.arrayOfPointers is "
6507 "VK_TRUE, geometry.data->deviceAddress must be aligned to 8 bytes.");
6508 }
6509 } else {
6510 if (SafeModulo(pInfos[i].ppGeometries[j]->geometry.instances.data.deviceAddress, 16) != 0) {
6511 skip |= LogError(
6512 device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-03715",
6513 "vkCmdBuildAccelerationStructuresIndirectKHR:For any element of pInfos[i].pGeometries with a "
6514 "geometryType of VK_GEOMETRY_TYPE_INSTANCES_KHR, if geometry.arrayOfPointers is VK_FALSE, "
6515 "geometry.data->deviceAddress must be aligned to 16 bytes.");
6516 }
6517 }
6518 }
6519 if (pInfos[i].ppGeometries[j]->geometryType == VK_GEOMETRY_TYPE_AABBS_KHR) {
6520 if (SafeModulo(pInfos[i].ppGeometries[j]->geometry.instances.data.deviceAddress, 8) != 0) {
6521 skip |= LogError(
6522 device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-03714",
6523 "vkCmdBuildAccelerationStructuresIndirectKHR:For any element of pInfos[i].pGeometries with a "
6524 "geometryType of VK_GEOMETRY_TYPE_AABBS_KHR, geometry.data->deviceAddress must be aligned to 8 bytes.");
6525 }
6526 }
6527 if (pInfos[i].ppGeometries[j]->geometryType == VK_GEOMETRY_TYPE_TRIANGLES_KHR) {
6528 if (SafeModulo(pInfos[i].ppGeometries[j]->geometry.triangles.indexData.deviceAddress, 16) != 0) {
6529 skip |= LogError(device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-03810",
6530 "vkCmdBuildAccelerationStructuresIndirectKHR:For any element of pInfos[i].pGeometries "
6531 "with a geometryType of VK_GEOMETRY_TYPE_TRIANGLES_KHR, "
6532 "geometry.transformData->deviceAddress must be aligned to 16 bytes.");
6533 }
6534 }
6535 }
6536 }
6537 }
6538 return skip;
6539}
6540
6541bool StatelessValidation::manual_PreCallValidateBuildAccelerationStructuresKHR(
6542 VkDevice device, VkDeferredOperationKHR deferredOperation, uint32_t infoCount,
6543 const VkAccelerationStructureBuildGeometryInfoKHR *pInfos,
6544 const VkAccelerationStructureBuildRangeInfoKHR *const *ppBuildRangeInfos) const {
6545 bool skip = false;
6546 skip |= ValidateAccelerationStructureBuildGeometryInfoKHR(pInfos, infoCount, "vkBuildAccelerationStructuresKHR");
6547 const auto *ray_tracing_acceleration_structure_features =
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07006548 LvlFindInChain<VkPhysicalDeviceAccelerationStructureFeaturesKHR>(device_createinfo_pnext);
sourav parmarcd5fb182020-07-17 12:58:44 -07006549 if (!ray_tracing_acceleration_structure_features ||
6550 ray_tracing_acceleration_structure_features->accelerationStructureHostCommands == VK_FALSE) {
6551 skip |=
6552 LogError(device, "VUID-vkBuildAccelerationStructuresKHR-accelerationStructureHostCommands-03581",
6553 "vkBuildAccelerationStructuresKHR: The "
6554 "VkPhysicalDeviceAccelerationStructureFeaturesKHR::accelerationStructureHostCommands feature must be enabled");
6555 }
6556 for (uint32_t i = 0; i < infoCount; ++i) {
6557 for (uint32_t j = 0; j < infoCount; ++j) {
6558 if (i == j) continue;
6559 bool found = false;
6560 if (pInfos[i].dstAccelerationStructure == pInfos[j].dstAccelerationStructure) {
6561 skip |= LogError(
6562 device, "VUID-vkBuildAccelerationStructuresKHR-dstAccelerationStructure-03698",
6563 "vkBuildAccelerationStructuresKHR(): The dstAccelerationStructure member of any element (%d) of pInfos must "
6564 "not be "
6565 "the same acceleration structure as the dstAccelerationStructure member of any other element (%d) of pInfos.",
6566 i, j);
6567 found = true;
6568 }
6569 if (pInfos[i].srcAccelerationStructure == pInfos[j].dstAccelerationStructure) {
6570 skip |= LogError(
6571 device, "VUID-vkBuildAccelerationStructuresKHR-pInfos-03403",
6572 "vkBuildAccelerationStructuresKHR(): The srcAccelerationStructure member of any element (%d) of pInfos must "
6573 "not be "
6574 "the same acceleration structure as the dstAccelerationStructure member of any other element (%d) of pInfos.",
6575 i, j);
6576 found = true;
6577 }
6578 if (found) break;
6579 }
6580 }
6581 return skip;
6582}
6583
6584bool StatelessValidation::manual_PreCallValidateGetAccelerationStructureBuildSizesKHR(
6585 VkDevice device, VkAccelerationStructureBuildTypeKHR buildType, const VkAccelerationStructureBuildGeometryInfoKHR *pBuildInfo,
6586 const uint32_t *pMaxPrimitiveCounts, VkAccelerationStructureBuildSizesInfoKHR *pSizeInfo) const {
6587 bool skip = false;
6588 skip |= ValidateAccelerationStructureBuildGeometryInfoKHR(pBuildInfo, 1, "vkGetAccelerationStructureBuildSizesKHR");
6589 const auto *ray_tracing_pipeline_features =
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07006590 LvlFindInChain<VkPhysicalDeviceRayTracingPipelineFeaturesKHR>(device_createinfo_pnext);
6591 const auto *ray_query_features = LvlFindInChain<VkPhysicalDeviceRayQueryFeaturesKHR>(device_createinfo_pnext);
sourav parmarcd5fb182020-07-17 12:58:44 -07006592 if (!(ray_tracing_pipeline_features || ray_query_features) ||
6593 ((ray_tracing_pipeline_features && ray_tracing_pipeline_features->rayTracingPipeline == VK_FALSE) ||
6594 (ray_query_features && ray_query_features->rayQuery == VK_FALSE))) {
6595 skip |= LogError(device, "VUID-vkGetAccelerationStructureBuildSizesKHR-rayTracingPipeline-03617",
6596 "vkGetAccelerationStructureBuildSizesKHR:The rayTracingPipeline or rayQuery feature must be enabled");
6597 }
6598 return skip;
6599}
sfricke-samsungecafb192021-01-17 08:21:14 -08006600
6601bool StatelessValidation::manual_PreCallValidateCreatePrivateDataSlotEXT(VkDevice device,
6602 const VkPrivateDataSlotCreateInfoEXT *pCreateInfo,
6603 const VkAllocationCallbacks *pAllocator,
6604 VkPrivateDataSlotEXT *pPrivateDataSlot) const {
6605 bool skip = false;
6606 const auto *private_data_features = LvlFindInChain<VkPhysicalDevicePrivateDataFeaturesEXT>(device_createinfo_pnext);
6607 if (private_data_features && private_data_features->privateData == VK_FALSE) {
6608 skip |= LogError(device, "VUID-vkCreatePrivateDataSlotEXT-privateData-04564",
6609 "vkCreatePrivateDataSlotEXT(): The privateData feature must be enabled.");
6610 }
6611 return skip;
6612}