blob: dac95b4def15f71d701684f414b066c01c0cae6f [file] [log] [blame]
sfricke-samsung11ea8ed2020-01-07 22:24:56 -08001/* Copyright (c) 2015-2020 The Khronos Group Inc.
2 * Copyright (c) 2015-2020 Valve Corporation
3 * Copyright (c) 2015-2020 LunarG, Inc.
4 * Copyright (C) 2015-2020 Google Inc.
Mark Lobodzinskid4950072017-08-01 13:02:20 -06005 *
6 * Licensed under the Apache License, Version 2.0 (the "License");
7 * you may not use this file except in compliance with the License.
8 * You may obtain a copy of the License at
9 *
10 * http://www.apache.org/licenses/LICENSE-2.0
11 *
12 * Unless required by applicable law or agreed to in writing, software
13 * distributed under the License is distributed on an "AS IS" BASIS,
14 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15 * See the License for the specific language governing permissions and
16 * limitations under the License.
17 *
18 * Author: Mark Lobodzinski <mark@LunarG.com>
John Zulaufa999d1b2018-11-29 13:38:40 -070019 * Author: John Zulauf <jzulauf@lunarg.com>
Mark Lobodzinskid4950072017-08-01 13:02:20 -060020 */
21
orbea80ddc062019-09-10 10:33:19 -070022#include <cmath>
Shahbaz Youssefi6be11412019-01-10 15:29:30 -050023
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -070024#include "chassis.h"
25#include "stateless_validation.h"
Mark Lobodzinskie514d1a2019-03-12 08:47:45 -060026#include "layer_chassis_dispatch.h"
Tobias Hectord942eb92018-10-22 15:18:56 +010027
Mark Lobodzinskid4950072017-08-01 13:02:20 -060028static const int MaxParamCheckerStringLength = 256;
29
John Zulauf71968502017-10-26 13:51:15 -060030template <typename T>
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -070031inline bool in_inclusive_range(const T &value, const T &min, const T &max) {
John Zulauf71968502017-10-26 13:51:15 -060032 // Using only < for generality and || for early abort
33 return !((value < min) || (max < value));
34}
35
Mark Lobodzinskibf599b92018-12-31 12:15:55 -070036bool StatelessValidation::validate_string(const char *apiName, const ParameterName &stringName, const std::string &vuid,
Jeff Bolz46c0ea02019-10-09 13:06:29 -050037 const char *validateString) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -060038 bool skip = false;
39
40 VkStringErrorFlags result = vk_string_validate(MaxParamCheckerStringLength, validateString);
41
42 if (result == VK_STRING_ERROR_NONE) {
43 return skip;
44 } else if (result & VK_STRING_ERROR_LENGTH) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -070045 skip = LogError(device, vuid, "%s: string %s exceeds max length %d", apiName, stringName.get_name().c_str(),
46 MaxParamCheckerStringLength);
Mark Lobodzinskid4950072017-08-01 13:02:20 -060047 } else if (result & VK_STRING_ERROR_BAD_DATA) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -070048 skip = LogError(device, vuid, "%s: string %s contains invalid characters or is badly formed", apiName,
49 stringName.get_name().c_str());
Mark Lobodzinskid4950072017-08-01 13:02:20 -060050 }
51 return skip;
52}
53
Jeff Bolz46c0ea02019-10-09 13:06:29 -050054bool StatelessValidation::validate_api_version(uint32_t api_version, uint32_t effective_api_version) const {
John Zulauf620755c2018-04-16 11:00:43 -060055 bool skip = false;
56 uint32_t api_version_nopatch = VK_MAKE_VERSION(VK_VERSION_MAJOR(api_version), VK_VERSION_MINOR(api_version), 0);
57 if (api_version_nopatch != effective_api_version) {
58 if (api_version_nopatch < VK_API_VERSION_1_0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -070059 skip |= LogError(instance, kVUIDUndefined,
60 "Invalid CreateInstance->pCreateInfo->pApplicationInfo.apiVersion number (0x%08x). "
61 "Using VK_API_VERSION_%" PRIu32 "_%" PRIu32 ".",
62 api_version, VK_VERSION_MAJOR(effective_api_version), VK_VERSION_MINOR(effective_api_version));
John Zulauf620755c2018-04-16 11:00:43 -060063 } else {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -070064 skip |= LogWarning(instance, kVUIDUndefined,
65 "Unrecognized CreateInstance->pCreateInfo->pApplicationInfo.apiVersion number (0x%08x). "
66 "Assuming VK_API_VERSION_%" PRIu32 "_%" PRIu32 ".",
67 api_version, VK_VERSION_MAJOR(effective_api_version), VK_VERSION_MINOR(effective_api_version));
John Zulauf620755c2018-04-16 11:00:43 -060068 }
69 }
70 return skip;
71}
72
Jeff Bolz46c0ea02019-10-09 13:06:29 -050073bool StatelessValidation::validate_instance_extensions(const VkInstanceCreateInfo *pCreateInfo) const {
John Zulauf620755c2018-04-16 11:00:43 -060074 bool skip = false;
Mark Lobodzinski05cce202019-08-27 10:28:37 -060075 // Create and use a local instance extension object, as an actual instance has not been created yet
76 uint32_t specified_version = (pCreateInfo->pApplicationInfo ? pCreateInfo->pApplicationInfo->apiVersion : VK_API_VERSION_1_0);
77 InstanceExtensions local_instance_extensions;
78 local_instance_extensions.InitFromInstanceCreateInfo(specified_version, pCreateInfo);
79
John Zulauf620755c2018-04-16 11:00:43 -060080 for (uint32_t i = 0; i < pCreateInfo->enabledExtensionCount; i++) {
Mark Lobodzinski05cce202019-08-27 10:28:37 -060081 skip |= validate_extension_reqs(local_instance_extensions, "VUID-vkCreateInstance-ppEnabledExtensionNames-01388",
82 "instance", pCreateInfo->ppEnabledExtensionNames[i]);
John Zulauf620755c2018-04-16 11:00:43 -060083 }
84
85 return skip;
86}
87
John Zulauf620755c2018-04-16 11:00:43 -060088template <typename ExtensionState>
Tony-LunarG2ec96bb2019-11-26 13:43:02 -070089ExtEnabled extension_state_by_name(const ExtensionState &extensions, const char *extension_name) {
90 if (!extension_name) return kNotEnabled; // null strings specify nothing
John Zulauf620755c2018-04-16 11:00:43 -060091 auto info = ExtensionState::get_info(extension_name);
Tony-LunarG2ec96bb2019-11-26 13:43:02 -070092 ExtEnabled state =
93 info.state ? extensions.*(info.state) : kNotEnabled; // unknown extensions can't be enabled in extension struct
John Zulauf620755c2018-04-16 11:00:43 -060094 return state;
95}
96
Mark Lobodzinskibf599b92018-12-31 12:15:55 -070097bool StatelessValidation::manual_PreCallValidateCreateInstance(const VkInstanceCreateInfo *pCreateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -050098 const VkAllocationCallbacks *pAllocator,
99 VkInstance *pInstance) const {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700100 bool skip = false;
101 // Note: From the spec--
102 // Providing a NULL VkInstanceCreateInfo::pApplicationInfo or providing an apiVersion of 0 is equivalent to providing
103 // an apiVersion of VK_MAKE_VERSION(1, 0, 0). (a.k.a. VK_API_VERSION_1_0)
104 uint32_t local_api_version = (pCreateInfo->pApplicationInfo && pCreateInfo->pApplicationInfo->apiVersion)
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700105 ? pCreateInfo->pApplicationInfo->apiVersion
106 : VK_API_VERSION_1_0;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700107 skip |= validate_api_version(local_api_version, api_version);
108 skip |= validate_instance_extensions(pCreateInfo);
109 return skip;
110}
111
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700112void StatelessValidation::PostCallRecordCreateInstance(const VkInstanceCreateInfo *pCreateInfo,
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -0700113 const VkAllocationCallbacks *pAllocator, VkInstance *pInstance,
114 VkResult result) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700115 auto instance_data = GetLayerDataPtr(get_dispatch_key(*pInstance), layer_data_map);
116 // Copy extension data into local object
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -0700117 if (result != VK_SUCCESS) return;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700118 this->instance_extensions = instance_data->instance_extensions;
119}
120
121void StatelessValidation::PostCallRecordCreateDevice(VkPhysicalDevice physicalDevice, const VkDeviceCreateInfo *pCreateInfo,
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -0700122 const VkAllocationCallbacks *pAllocator, VkDevice *pDevice, VkResult result) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700123 auto device_data = GetLayerDataPtr(get_dispatch_key(*pDevice), layer_data_map);
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -0700124 if (result != VK_SUCCESS) return;
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700125 ValidationObject *validation_data = GetValidationObject(device_data->object_dispatch, LayerObjectTypeParameterValidation);
126 StatelessValidation *stateless_validation = static_cast<StatelessValidation *>(validation_data);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700127
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700128 // Parmeter validation also uses extension data
129 stateless_validation->device_extensions = this->device_extensions;
130
131 VkPhysicalDeviceProperties device_properties = {};
132 // Need to get instance and do a getlayerdata call...
Tony-LunarG152a88b2019-03-20 15:42:24 -0600133 DispatchGetPhysicalDeviceProperties(physicalDevice, &device_properties);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700134 memcpy(&stateless_validation->device_limits, &device_properties.limits, sizeof(VkPhysicalDeviceLimits));
135
136 if (device_extensions.vk_nv_shading_rate_image) {
137 // Get the needed shading rate image limits
138 auto shading_rate_image_props = lvl_init_struct<VkPhysicalDeviceShadingRateImagePropertiesNV>();
139 auto prop2 = lvl_init_struct<VkPhysicalDeviceProperties2KHR>(&shading_rate_image_props);
Tony-LunarG152a88b2019-03-20 15:42:24 -0600140 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700141 phys_dev_ext_props.shading_rate_image_props = shading_rate_image_props;
142 }
143
144 if (device_extensions.vk_nv_mesh_shader) {
145 // Get the needed mesh shader limits
146 auto mesh_shader_props = lvl_init_struct<VkPhysicalDeviceMeshShaderPropertiesNV>();
147 auto prop2 = lvl_init_struct<VkPhysicalDeviceProperties2KHR>(&mesh_shader_props);
Tony-LunarG152a88b2019-03-20 15:42:24 -0600148 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700149 phys_dev_ext_props.mesh_shader_props = mesh_shader_props;
150 }
151
Jason Macnak5c954952019-07-09 15:46:12 -0700152 if (device_extensions.vk_nv_ray_tracing) {
153 // Get the needed ray tracing limits
154 auto ray_tracing_props = lvl_init_struct<VkPhysicalDeviceRayTracingPropertiesNV>();
155 auto prop2 = lvl_init_struct<VkPhysicalDeviceProperties2KHR>(&ray_tracing_props);
156 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
Jeff Bolz443c2ca2020-03-19 12:11:51 -0500157 phys_dev_ext_props.ray_tracing_propsNV = ray_tracing_props;
158 }
159
160 if (device_extensions.vk_khr_ray_tracing) {
161 // Get the needed ray tracing limits
162 auto ray_tracing_props = lvl_init_struct<VkPhysicalDeviceRayTracingPropertiesKHR>();
163 auto prop2 = lvl_init_struct<VkPhysicalDeviceProperties2KHR>(&ray_tracing_props);
164 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
165 phys_dev_ext_props.ray_tracing_propsKHR = ray_tracing_props;
Jason Macnak5c954952019-07-09 15:46:12 -0700166 }
167
Mark Lobodzinski953b7bc2019-12-19 13:50:10 -0700168 if (device_extensions.vk_ext_transform_feedback) {
169 // Get the needed transform feedback limits
170 auto transform_feedback_props = lvl_init_struct<VkPhysicalDeviceTransformFeedbackPropertiesEXT>();
171 auto prop2 = lvl_init_struct<VkPhysicalDeviceProperties2KHR>(&transform_feedback_props);
172 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
173 phys_dev_ext_props.transform_feedback_props = transform_feedback_props;
174 }
175
Jasper St. Pierrea49b4be2019-02-05 17:48:57 -0800176 stateless_validation->phys_dev_ext_props = this->phys_dev_ext_props;
177
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700178 // Save app-enabled features in this device's validation object
179 // The enabled features can come from either pEnabledFeatures, or from the pNext chain
Petr Kraus715bcc72019-08-15 17:17:33 +0200180 const auto *features2 = lvl_find_in_chain<VkPhysicalDeviceFeatures2>(pCreateInfo->pNext);
181 safe_VkPhysicalDeviceFeatures2 tmp_features2_state;
182 tmp_features2_state.sType = VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_FEATURES_2;
183 if (features2) {
184 tmp_features2_state.features = features2->features;
185 } else if (pCreateInfo->pEnabledFeatures) {
186 tmp_features2_state.features = *pCreateInfo->pEnabledFeatures;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700187 } else {
Petr Kraus715bcc72019-08-15 17:17:33 +0200188 tmp_features2_state.features = {};
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700189 }
Petr Kraus715bcc72019-08-15 17:17:33 +0200190 // Use pCreateInfo->pNext to get full chain
Tony-LunarG6c3c5452019-12-13 10:37:38 -0700191 stateless_validation->device_createinfo_pnext = SafePnextCopy(pCreateInfo->pNext);
Petr Kraus715bcc72019-08-15 17:17:33 +0200192 stateless_validation->physical_device_features2 = tmp_features2_state;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700193}
194
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700195bool StatelessValidation::manual_PreCallValidateCreateDevice(VkPhysicalDevice physicalDevice, const VkDeviceCreateInfo *pCreateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -0500196 const VkAllocationCallbacks *pAllocator, VkDevice *pDevice) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600197 bool skip = false;
198
Petr Kraus6c4bdce2019-08-27 17:35:01 +0200199 for (size_t i = 0; i < pCreateInfo->enabledLayerCount; i++) {
200 skip |= validate_string("vkCreateDevice", "pCreateInfo->ppEnabledLayerNames",
201 "VUID-VkDeviceCreateInfo-ppEnabledLayerNames-parameter", pCreateInfo->ppEnabledLayerNames[i]);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600202 }
203
Petr Kraus6c4bdce2019-08-27 17:35:01 +0200204 for (size_t i = 0; i < pCreateInfo->enabledExtensionCount; i++) {
205 skip |=
206 validate_string("vkCreateDevice", "pCreateInfo->ppEnabledExtensionNames",
207 "VUID-VkDeviceCreateInfo-ppEnabledExtensionNames-parameter", pCreateInfo->ppEnabledExtensionNames[i]);
208 skip |= validate_extension_reqs(device_extensions, "VUID-vkCreateDevice-ppEnabledExtensionNames-01387", "device",
209 pCreateInfo->ppEnabledExtensionNames[i]);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600210 }
211
Petr Kraus6c4bdce2019-08-27 17:35:01 +0200212 {
Tony-LunarG2ec96bb2019-11-26 13:43:02 -0700213 bool maint1 = IsExtEnabled(extension_state_by_name(device_extensions, VK_KHR_MAINTENANCE1_EXTENSION_NAME));
214 bool negative_viewport =
215 IsExtEnabled(extension_state_by_name(device_extensions, VK_AMD_NEGATIVE_VIEWPORT_HEIGHT_EXTENSION_NAME));
Petr Kraus6c4bdce2019-08-27 17:35:01 +0200216 if (maint1 && negative_viewport) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700217 skip |= LogError(device, "VUID-VkDeviceCreateInfo-ppEnabledExtensionNames-00374",
218 "VkDeviceCreateInfo->ppEnabledExtensionNames must not simultaneously include VK_KHR_maintenance1 and "
219 "VK_AMD_negative_viewport_height.");
Petr Kraus6c4bdce2019-08-27 17:35:01 +0200220 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600221 }
222
Jeff Bolz4563f2a2019-12-10 13:30:30 -0600223 {
224 bool khr_bda = IsExtEnabled(extension_state_by_name(device_extensions, VK_KHR_BUFFER_DEVICE_ADDRESS_EXTENSION_NAME));
225 bool ext_bda = IsExtEnabled(extension_state_by_name(device_extensions, VK_EXT_BUFFER_DEVICE_ADDRESS_EXTENSION_NAME));
226 if (khr_bda && ext_bda) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700227 skip |= LogError(device, "VUID-VkDeviceCreateInfo-ppEnabledExtensionNames-03328",
228 "VkDeviceCreateInfo->ppEnabledExtensionNames must not contain both VK_KHR_buffer_device_address and "
229 "VK_EXT_buffer_device_address.");
Jeff Bolz4563f2a2019-12-10 13:30:30 -0600230 }
231 }
232
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600233 if (pCreateInfo->pNext != NULL && pCreateInfo->pEnabledFeatures) {
234 // Check for get_physical_device_properties2 struct
John Zulaufde972ac2017-10-26 12:07:05 -0600235 const auto *features2 = lvl_find_in_chain<VkPhysicalDeviceFeatures2KHR>(pCreateInfo->pNext);
236 if (features2) {
237 // Cannot include VkPhysicalDeviceFeatures2KHR and have non-null pEnabledFeatures
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700238 skip |= LogError(device, kVUID_PVError_InvalidUsage,
239 "VkDeviceCreateInfo->pNext includes a VkPhysicalDeviceFeatures2KHR struct when "
240 "pCreateInfo->pEnabledFeatures is non-NULL.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600241 }
242 }
243
Locke77fad1c2019-04-16 13:09:03 -0600244 auto features2 = lvl_find_in_chain<VkPhysicalDeviceFeatures2>(pCreateInfo->pNext);
245 if (features2) {
246 if (!instance_extensions.vk_khr_get_physical_device_properties_2) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700247 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
248 "VkDeviceCreateInfo->pNext includes a VkPhysicalDeviceFeatures2 struct, "
249 "VK_KHR_get_physical_device_properties2 must be enabled when it creates an instance.");
Locke77fad1c2019-04-16 13:09:03 -0600250 }
251 }
252
253 auto vertex_attribute_divisor_features =
254 lvl_find_in_chain<VkPhysicalDeviceVertexAttributeDivisorFeaturesEXT>(pCreateInfo->pNext);
255 if (vertex_attribute_divisor_features) {
256 bool extension_found = false;
257 for (uint32_t i = 0; i < pCreateInfo->enabledExtensionCount; ++i) {
258 if (0 == strncmp(pCreateInfo->ppEnabledExtensionNames[i], VK_EXT_VERTEX_ATTRIBUTE_DIVISOR_EXTENSION_NAME,
259 VK_MAX_EXTENSION_NAME_SIZE)) {
260 extension_found = true;
261 break;
262 }
263 }
264 if (!extension_found) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700265 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
266 "VkDeviceCreateInfo->pNext includes a VkPhysicalDeviceVertexAttributeDivisorFeaturesEXT "
267 "struct, VK_EXT_vertex_attribute_divisor must be enabled when it creates a device.");
Locke77fad1c2019-04-16 13:09:03 -0600268 }
269 }
270
Tony-LunarG28017bc2020-01-23 14:40:25 -0700271 const auto *vulkan_11_features = lvl_find_in_chain<VkPhysicalDeviceVulkan11Features>(pCreateInfo->pNext);
272 if (vulkan_11_features) {
273 const VkBaseOutStructure *current = reinterpret_cast<const VkBaseOutStructure *>(pCreateInfo->pNext);
274 while (current) {
275 if (current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_16BIT_STORAGE_FEATURES ||
276 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_MULTIVIEW_FEATURES ||
277 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_VARIABLE_POINTERS_FEATURES ||
278 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_PROTECTED_MEMORY_FEATURES ||
279 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SAMPLER_YCBCR_CONVERSION_FEATURES ||
280 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SHADER_DRAW_PARAMETERS_FEATURES) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700281 skip |= LogError(
282 instance, "VUID-VkDeviceCreateInfo-pNext-02829",
Tony-LunarG28017bc2020-01-23 14:40:25 -0700283 "If the pNext chain includes a VkPhysicalDeviceVulkan11Features structure, then it must not include a "
284 "VkPhysicalDevice16BitStorageFeatures, VkPhysicalDeviceMultiviewFeatures, "
285 "VkPhysicalDeviceVariablePointersFeatures, VkPhysicalDeviceProtectedMemoryFeatures, "
286 "VkPhysicalDeviceSamplerYcbcrConversionFeatures, or VkPhysicalDeviceShaderDrawParametersFeatures structure");
287 break;
288 }
289 current = reinterpret_cast<const VkBaseOutStructure *>(current->pNext);
290 }
291 }
292
293 const auto *vulkan_12_features = lvl_find_in_chain<VkPhysicalDeviceVulkan12Features>(pCreateInfo->pNext);
294 if (vulkan_12_features) {
295 const VkBaseOutStructure *current = reinterpret_cast<const VkBaseOutStructure *>(pCreateInfo->pNext);
296 while (current) {
297 if (current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_8BIT_STORAGE_FEATURES ||
298 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SHADER_ATOMIC_INT64_FEATURES ||
299 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SHADER_FLOAT16_INT8_FEATURES ||
300 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_DESCRIPTOR_INDEXING_FEATURES ||
301 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SCALAR_BLOCK_LAYOUT_FEATURES ||
302 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_IMAGELESS_FRAMEBUFFER_FEATURES ||
303 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_UNIFORM_BUFFER_STANDARD_LAYOUT_FEATURES ||
304 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SHADER_SUBGROUP_EXTENDED_TYPES_FEATURES ||
305 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SEPARATE_DEPTH_STENCIL_LAYOUTS_FEATURES ||
306 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_HOST_QUERY_RESET_FEATURES ||
307 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_TIMELINE_SEMAPHORE_FEATURES ||
308 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_BUFFER_DEVICE_ADDRESS_FEATURES ||
309 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_VULKAN_MEMORY_MODEL_FEATURES) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700310 skip |= LogError(
311 instance, "VUID-VkDeviceCreateInfo-pNext-02830",
Tony-LunarG28017bc2020-01-23 14:40:25 -0700312 "If the pNext chain includes a VkPhysicalDeviceVulkan12Features structure, then it must not include a "
313 "VkPhysicalDevice8BitStorageFeatures, VkPhysicalDeviceShaderAtomicInt64Features, "
314 "VkPhysicalDeviceShaderFloat16Int8Features, VkPhysicalDeviceDescriptorIndexingFeatures, "
315 "VkPhysicalDeviceScalarBlockLayoutFeatures, VkPhysicalDeviceImagelessFramebufferFeatures, "
316 "VkPhysicalDeviceUniformBufferStandardLayoutFeatures, VkPhysicalDeviceShaderSubgroupExtendedTypesFeatures, "
317 "VkPhysicalDeviceSeparateDepthStencilLayoutsFeatures, VkPhysicalDeviceHostQueryResetFeatures, "
318 "VkPhysicalDeviceTimelineSemaphoreFeatures, VkPhysicalDeviceBufferDeviceAddressFeatures, or "
319 "VkPhysicalDeviceVulkanMemoryModelFeatures structure");
320 break;
321 }
322 current = reinterpret_cast<const VkBaseOutStructure *>(current->pNext);
323 }
324 }
325
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600326 // Validate pCreateInfo->pQueueCreateInfos
327 if (pCreateInfo->pQueueCreateInfos) {
328 std::unordered_set<uint32_t> set;
329
330 for (uint32_t i = 0; i < pCreateInfo->queueCreateInfoCount; ++i) {
331 const uint32_t requested_queue_family = pCreateInfo->pQueueCreateInfos[i].queueFamilyIndex;
332 if (requested_queue_family == VK_QUEUE_FAMILY_IGNORED) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700333 skip |=
334 LogError(physicalDevice, "VUID-VkDeviceQueueCreateInfo-queueFamilyIndex-00381",
335 "vkCreateDevice: pCreateInfo->pQueueCreateInfos[%" PRIu32
336 "].queueFamilyIndex is VK_QUEUE_FAMILY_IGNORED, but it is required to provide a valid queue family "
337 "index value.",
338 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600339 } else if (set.count(requested_queue_family)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700340 skip |= LogError(physicalDevice, "VUID-VkDeviceCreateInfo-queueFamilyIndex-00372",
341 "vkCreateDevice: pCreateInfo->pQueueCreateInfos[%" PRIu32 "].queueFamilyIndex (=%" PRIu32
342 ") is not unique within pCreateInfo->pQueueCreateInfos array.",
343 i, requested_queue_family);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600344 } else {
345 set.insert(requested_queue_family);
346 }
347
348 if (pCreateInfo->pQueueCreateInfos[i].pQueuePriorities != nullptr) {
349 for (uint32_t j = 0; j < pCreateInfo->pQueueCreateInfos[i].queueCount; ++j) {
350 const float queue_priority = pCreateInfo->pQueueCreateInfos[i].pQueuePriorities[j];
351 if (!(queue_priority >= 0.f) || !(queue_priority <= 1.f)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700352 skip |= LogError(physicalDevice, "VUID-VkDeviceQueueCreateInfo-pQueuePriorities-00383",
353 "vkCreateDevice: pCreateInfo->pQueueCreateInfos[%" PRIu32 "].pQueuePriorities[%" PRIu32
354 "] (=%f) is not between 0 and 1 (inclusive).",
355 i, j, queue_priority);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600356 }
357 }
358 }
359 }
360 }
361
362 return skip;
363}
364
Jeff Bolz46c0ea02019-10-09 13:06:29 -0500365bool StatelessValidation::require_device_extension(bool flag, char const *function_name, char const *extension_name) const {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700366 if (!flag) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700367 return LogError(device, kVUID_PVError_ExtensionNotEnabled,
368 "%s() called even though the %s extension was not enabled for this VkDevice.", function_name,
369 extension_name);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600370 }
371
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700372 return false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600373}
374
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700375bool StatelessValidation::manual_PreCallValidateCreateBuffer(VkDevice device, const VkBufferCreateInfo *pCreateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -0500376 const VkAllocationCallbacks *pAllocator, VkBuffer *pBuffer) const {
Petr Krause91f7a12017-12-14 20:57:36 +0100377 bool skip = false;
378
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600379 if (pCreateInfo != nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700380 skip |=
381 ValidateGreaterThanZero(pCreateInfo->size, "pCreateInfo->size", "VUID-VkBufferCreateInfo-size-00912", "vkCreateBuffer");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600382
383 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
384 if (pCreateInfo->sharingMode == VK_SHARING_MODE_CONCURRENT) {
385 // If sharingMode is VK_SHARING_MODE_CONCURRENT, queueFamilyIndexCount must be greater than 1
386 if (pCreateInfo->queueFamilyIndexCount <= 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700387 skip |= LogError(device, "VUID-VkBufferCreateInfo-sharingMode-00914",
388 "vkCreateBuffer: if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
389 "pCreateInfo->queueFamilyIndexCount must be greater than 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600390 }
391
392 // If sharingMode is VK_SHARING_MODE_CONCURRENT, pQueueFamilyIndices must be a pointer to an array of
393 // queueFamilyIndexCount uint32_t values
394 if (pCreateInfo->pQueueFamilyIndices == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700395 skip |= LogError(device, "VUID-VkBufferCreateInfo-sharingMode-00913",
396 "vkCreateBuffer: if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
397 "pCreateInfo->pQueueFamilyIndices must be a pointer to an array of "
398 "pCreateInfo->queueFamilyIndexCount uint32_t values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600399 }
400 }
401
402 // If flags contains VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT or VK_BUFFER_CREATE_SPARSE_ALIASED_BIT, it must also contain
403 // VK_BUFFER_CREATE_SPARSE_BINDING_BIT
404 if (((pCreateInfo->flags & (VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT | VK_BUFFER_CREATE_SPARSE_ALIASED_BIT)) != 0) &&
405 ((pCreateInfo->flags & VK_BUFFER_CREATE_SPARSE_BINDING_BIT) != VK_BUFFER_CREATE_SPARSE_BINDING_BIT)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700406 skip |= LogError(device, "VUID-VkBufferCreateInfo-flags-00918",
407 "vkCreateBuffer: if pCreateInfo->flags contains VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT or "
408 "VK_BUFFER_CREATE_SPARSE_ALIASED_BIT, it must also contain VK_BUFFER_CREATE_SPARSE_BINDING_BIT.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600409 }
410 }
411
412 return skip;
413}
414
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700415bool StatelessValidation::manual_PreCallValidateCreateImage(VkDevice device, const VkImageCreateInfo *pCreateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -0500416 const VkAllocationCallbacks *pAllocator, VkImage *pImage) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600417 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600418
419 if (pCreateInfo != nullptr) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600420 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
421 if (pCreateInfo->sharingMode == VK_SHARING_MODE_CONCURRENT) {
422 // If sharingMode is VK_SHARING_MODE_CONCURRENT, queueFamilyIndexCount must be greater than 1
423 if (pCreateInfo->queueFamilyIndexCount <= 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700424 skip |= LogError(device, "VUID-VkImageCreateInfo-sharingMode-00942",
425 "vkCreateImage(): if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
426 "pCreateInfo->queueFamilyIndexCount must be greater than 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600427 }
428
429 // If sharingMode is VK_SHARING_MODE_CONCURRENT, pQueueFamilyIndices must be a pointer to an array of
430 // queueFamilyIndexCount uint32_t values
431 if (pCreateInfo->pQueueFamilyIndices == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700432 skip |= LogError(device, "VUID-VkImageCreateInfo-sharingMode-00941",
433 "vkCreateImage(): if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
434 "pCreateInfo->pQueueFamilyIndices must be a pointer to an array of "
435 "pCreateInfo->queueFamilyIndexCount uint32_t values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600436 }
437 }
438
Dave Houlton413a6782018-05-22 13:01:54 -0600439 skip |= ValidateGreaterThanZero(pCreateInfo->extent.width, "pCreateInfo->extent.width",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700440 "VUID-VkImageCreateInfo-extent-00944", "vkCreateImage");
Dave Houlton413a6782018-05-22 13:01:54 -0600441 skip |= ValidateGreaterThanZero(pCreateInfo->extent.height, "pCreateInfo->extent.height",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700442 "VUID-VkImageCreateInfo-extent-00945", "vkCreateImage");
Dave Houlton413a6782018-05-22 13:01:54 -0600443 skip |= ValidateGreaterThanZero(pCreateInfo->extent.depth, "pCreateInfo->extent.depth",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700444 "VUID-VkImageCreateInfo-extent-00946", "vkCreateImage");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600445
Dave Houlton413a6782018-05-22 13:01:54 -0600446 skip |= ValidateGreaterThanZero(pCreateInfo->mipLevels, "pCreateInfo->mipLevels", "VUID-VkImageCreateInfo-mipLevels-00947",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700447 "vkCreateImage");
Dave Houlton413a6782018-05-22 13:01:54 -0600448 skip |= ValidateGreaterThanZero(pCreateInfo->arrayLayers, "pCreateInfo->arrayLayers",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700449 "VUID-VkImageCreateInfo-arrayLayers-00948", "vkCreateImage");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600450
Dave Houlton130c0212018-01-29 13:39:56 -0700451 // InitialLayout must be PREINITIALIZED or UNDEFINED
Dave Houltone19e20d2018-02-02 16:32:41 -0700452 if ((pCreateInfo->initialLayout != VK_IMAGE_LAYOUT_UNDEFINED) &&
453 (pCreateInfo->initialLayout != VK_IMAGE_LAYOUT_PREINITIALIZED)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700454 skip |= LogError(
455 device, "VUID-VkImageCreateInfo-initialLayout-00993",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600456 "vkCreateImage(): initialLayout is %s, must be VK_IMAGE_LAYOUT_UNDEFINED or VK_IMAGE_LAYOUT_PREINITIALIZED.",
457 string_VkImageLayout(pCreateInfo->initialLayout));
Dave Houlton130c0212018-01-29 13:39:56 -0700458 }
459
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600460 // If imageType is VK_IMAGE_TYPE_1D, both extent.height and extent.depth must be 1
Petr Kraus3ac9e812018-03-13 12:31:08 +0100461 if ((pCreateInfo->imageType == VK_IMAGE_TYPE_1D) &&
462 ((pCreateInfo->extent.height != 1) || (pCreateInfo->extent.depth != 1))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700463 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00956",
464 "vkCreateImage(): if pCreateInfo->imageType is VK_IMAGE_TYPE_1D, both pCreateInfo->extent.height and "
465 "pCreateInfo->extent.depth must be 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600466 }
467
468 if (pCreateInfo->imageType == VK_IMAGE_TYPE_2D) {
Petr Kraus3f433212018-03-13 12:31:27 +0100469 if (pCreateInfo->flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) {
470 if (pCreateInfo->extent.width != pCreateInfo->extent.height) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700471 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00954",
472 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT, but "
473 "pCreateInfo->extent.width (=%" PRIu32 ") and pCreateInfo->extent.height (=%" PRIu32
474 ") are not equal.",
475 pCreateInfo->extent.width, pCreateInfo->extent.height);
Petr Kraus3f433212018-03-13 12:31:27 +0100476 }
477
478 if (pCreateInfo->arrayLayers < 6) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700479 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00954",
480 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT, but "
481 "pCreateInfo->arrayLayers (=%" PRIu32 ") is not greater than or equal to 6.",
482 pCreateInfo->arrayLayers);
Petr Kraus3f433212018-03-13 12:31:27 +0100483 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600484 }
485
486 if (pCreateInfo->extent.depth != 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700487 skip |= LogError(
488 device, "VUID-VkImageCreateInfo-imageType-00957",
489 "vkCreateImage(): if pCreateInfo->imageType is VK_IMAGE_TYPE_2D, pCreateInfo->extent.depth must be 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600490 }
491 }
492
Dave Houlton130c0212018-01-29 13:39:56 -0700493 // 3D image may have only 1 layer
494 if ((pCreateInfo->imageType == VK_IMAGE_TYPE_3D) && (pCreateInfo->arrayLayers != 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700495 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00961",
496 "vkCreateImage(): if pCreateInfo->imageType is VK_IMAGE_TYPE_3D, pCreateInfo->arrayLayers must be 1.");
Dave Houlton130c0212018-01-29 13:39:56 -0700497 }
498
499 // If multi-sample, validate type, usage, tiling and mip levels.
500 if ((pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT) &&
501 ((pCreateInfo->imageType != VK_IMAGE_TYPE_2D) || (pCreateInfo->flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) ||
Shannon McPhersona886c2a2018-10-12 14:38:20 -0600502 (pCreateInfo->mipLevels != 1) || (pCreateInfo->tiling != VK_IMAGE_TILING_OPTIMAL))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700503 skip |= LogError(device, "VUID-VkImageCreateInfo-samples-02257",
504 "vkCreateImage(): Multi-sample image with incompatible type, usage, tiling, or mips.");
Dave Houlton130c0212018-01-29 13:39:56 -0700505 }
506
507 if (0 != (pCreateInfo->usage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT)) {
508 VkImageUsageFlags legal_flags = (VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT | VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT |
509 VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT);
510 // At least one of the legal attachment bits must be set
511 if (0 == (pCreateInfo->usage & legal_flags)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700512 skip |= LogError(device, "VUID-VkImageCreateInfo-usage-00966",
513 "vkCreateImage(): Transient attachment image without a compatible attachment flag set.");
Dave Houlton130c0212018-01-29 13:39:56 -0700514 }
515 // No flags other than the legal attachment bits may be set
516 legal_flags |= VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT;
517 if (0 != (pCreateInfo->usage & ~legal_flags)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700518 skip |= LogError(device, "VUID-VkImageCreateInfo-usage-00963",
519 "vkCreateImage(): Transient attachment image with incompatible usage flags set.");
Dave Houlton130c0212018-01-29 13:39:56 -0700520 }
521 }
522
Jeff Bolzef40fec2018-09-01 22:04:34 -0500523 // mipLevels must be less than or equal to the number of levels in the complete mipmap chain
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600524 uint32_t maxDim = std::max(std::max(pCreateInfo->extent.width, pCreateInfo->extent.height), pCreateInfo->extent.depth);
Jeff Bolzef40fec2018-09-01 22:04:34 -0500525 // Max mip levels is different for corner-sampled images vs normal images.
Dave Houlton142c4cb2018-10-17 15:04:41 -0600526 uint32_t maxMipLevels = (pCreateInfo->flags & VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV) ? (uint32_t)(ceil(log2(maxDim)))
527 : (uint32_t)(floor(log2(maxDim)) + 1);
Jeff Bolzef40fec2018-09-01 22:04:34 -0500528 if (maxDim > 0 && pCreateInfo->mipLevels > maxMipLevels) {
Dave Houlton413a6782018-05-22 13:01:54 -0600529 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700530 LogError(device, "VUID-VkImageCreateInfo-mipLevels-00958",
531 "vkCreateImage(): pCreateInfo->mipLevels must be less than or equal to "
532 "floor(log2(max(pCreateInfo->extent.width, pCreateInfo->extent.height, pCreateInfo->extent.depth)))+1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600533 }
534
Mark Lobodzinski69259c52018-09-18 15:14:58 -0600535 if ((pCreateInfo->flags & VK_IMAGE_CREATE_2D_ARRAY_COMPATIBLE_BIT) && (pCreateInfo->imageType != VK_IMAGE_TYPE_3D)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700536 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-00950",
537 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_2D_ARRAY_COMPATIBLE_BIT but "
538 "pCreateInfo->imageType is not VK_IMAGE_TYPE_3D.");
Mark Lobodzinski69259c52018-09-18 15:14:58 -0600539 }
540
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700541 if ((pCreateInfo->flags & VK_IMAGE_CREATE_SPARSE_BINDING_BIT) && (!physical_device_features.sparseBinding)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700542 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-00969",
543 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_SPARSE_BINDING_BIT, but the "
544 "VkPhysicalDeviceFeatures::sparseBinding feature is disabled.");
Petr Krausb6f97802018-03-13 12:31:39 +0100545 }
546
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600547 // If flags contains VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT or VK_IMAGE_CREATE_SPARSE_ALIASED_BIT, it must also contain
548 // VK_IMAGE_CREATE_SPARSE_BINDING_BIT
549 if (((pCreateInfo->flags & (VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT | VK_IMAGE_CREATE_SPARSE_ALIASED_BIT)) != 0) &&
550 ((pCreateInfo->flags & VK_IMAGE_CREATE_SPARSE_BINDING_BIT) != VK_IMAGE_CREATE_SPARSE_BINDING_BIT)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700551 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-00987",
552 "vkCreateImage: if pCreateInfo->flags contains VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT or "
553 "VK_IMAGE_CREATE_SPARSE_ALIASED_BIT, it must also contain VK_IMAGE_CREATE_SPARSE_BINDING_BIT.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600554 }
555
556 // Check for combinations of attributes that are incompatible with having VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT set
557 if ((pCreateInfo->flags & VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT) != 0) {
558 // Linear tiling is unsupported
559 if (VK_IMAGE_TILING_LINEAR == pCreateInfo->tiling) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700560 skip |= LogError(device, kVUID_PVError_InvalidUsage,
561 "vkCreateImage: if pCreateInfo->flags contains VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT then image "
562 "tiling of VK_IMAGE_TILING_LINEAR is not supported");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600563 }
564
565 // Sparse 1D image isn't valid
566 if (VK_IMAGE_TYPE_1D == pCreateInfo->imageType) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700567 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00970",
568 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 1D image.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600569 }
570
571 // Sparse 2D image when device doesn't support it
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700572 if ((VK_FALSE == physical_device_features.sparseResidencyImage2D) && (VK_IMAGE_TYPE_2D == pCreateInfo->imageType)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700573 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00971",
574 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 2D image if corresponding "
575 "feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600576 }
577
578 // Sparse 3D image when device doesn't support it
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700579 if ((VK_FALSE == physical_device_features.sparseResidencyImage3D) && (VK_IMAGE_TYPE_3D == pCreateInfo->imageType)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700580 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00972",
581 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 3D image if corresponding "
582 "feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600583 }
584
585 // Multi-sample 2D image when device doesn't support it
586 if (VK_IMAGE_TYPE_2D == pCreateInfo->imageType) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700587 if ((VK_FALSE == physical_device_features.sparseResidency2Samples) &&
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600588 (VK_SAMPLE_COUNT_2_BIT == pCreateInfo->samples)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700589 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00973",
590 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 2-sample image if "
591 "corresponding feature is not enabled on the device.");
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700592 } else if ((VK_FALSE == physical_device_features.sparseResidency4Samples) &&
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600593 (VK_SAMPLE_COUNT_4_BIT == pCreateInfo->samples)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700594 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00974",
595 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 4-sample image if "
596 "corresponding feature is not enabled on the device.");
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700597 } else if ((VK_FALSE == physical_device_features.sparseResidency8Samples) &&
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600598 (VK_SAMPLE_COUNT_8_BIT == pCreateInfo->samples)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700599 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00975",
600 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 8-sample image if "
601 "corresponding feature is not enabled on the device.");
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700602 } else if ((VK_FALSE == physical_device_features.sparseResidency16Samples) &&
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600603 (VK_SAMPLE_COUNT_16_BIT == pCreateInfo->samples)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700604 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00976",
605 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 16-sample image if "
606 "corresponding feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600607 }
608 }
609 }
Jeff Bolzef40fec2018-09-01 22:04:34 -0500610
Jeff Bolz9af91c52018-09-01 21:53:57 -0500611 if (pCreateInfo->usage & VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV) {
612 if (pCreateInfo->imageType != VK_IMAGE_TYPE_2D) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700613 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-02082",
614 "vkCreateImage: if usage includes VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV, "
615 "imageType must be VK_IMAGE_TYPE_2D.");
Jeff Bolz9af91c52018-09-01 21:53:57 -0500616 }
617 if (pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700618 skip |= LogError(device, "VUID-VkImageCreateInfo-samples-02083",
619 "vkCreateImage: if usage includes VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV, "
620 "samples must be VK_SAMPLE_COUNT_1_BIT.");
Jeff Bolz9af91c52018-09-01 21:53:57 -0500621 }
622 if (pCreateInfo->tiling != VK_IMAGE_TILING_OPTIMAL) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700623 skip |= LogError(device, "VUID-VkImageCreateInfo-tiling-02084",
624 "vkCreateImage: if usage includes VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV, "
625 "tiling must be VK_IMAGE_TILING_OPTIMAL.");
Jeff Bolz9af91c52018-09-01 21:53:57 -0500626 }
627 }
Jeff Bolzef40fec2018-09-01 22:04:34 -0500628
629 if (pCreateInfo->flags & VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV) {
Dave Houlton142c4cb2018-10-17 15:04:41 -0600630 if (pCreateInfo->imageType != VK_IMAGE_TYPE_2D && pCreateInfo->imageType != VK_IMAGE_TYPE_3D) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700631 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02050",
632 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV, "
633 "imageType must be VK_IMAGE_TYPE_2D or VK_IMAGE_TYPE_3D.");
Jeff Bolzef40fec2018-09-01 22:04:34 -0500634 }
635
Dave Houlton142c4cb2018-10-17 15:04:41 -0600636 if ((pCreateInfo->flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) || FormatIsDepthOrStencil(pCreateInfo->format)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700637 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02051",
638 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV, "
639 "it must not also contain VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT and format must "
640 "not be a depth/stencil format.");
Jeff Bolzef40fec2018-09-01 22:04:34 -0500641 }
642
Dave Houlton142c4cb2018-10-17 15:04:41 -0600643 if (pCreateInfo->imageType == VK_IMAGE_TYPE_2D && (pCreateInfo->extent.width == 1 || pCreateInfo->extent.height == 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700644 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02052",
645 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV and "
646 "imageType is VK_IMAGE_TYPE_2D, extent.width and extent.height must be "
647 "greater than 1.");
Jeff Bolzb8a8dd02018-09-18 02:39:24 -0500648 } else if (pCreateInfo->imageType == VK_IMAGE_TYPE_3D &&
Dave Houlton142c4cb2018-10-17 15:04:41 -0600649 (pCreateInfo->extent.width == 1 || pCreateInfo->extent.height == 1 || pCreateInfo->extent.depth == 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700650 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02053",
651 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV and "
652 "imageType is VK_IMAGE_TYPE_3D, extent.width, extent.height, and extent.depth "
653 "must be greater than 1.");
Jeff Bolzef40fec2018-09-01 22:04:34 -0500654 }
655 }
Andrew Fobel3abeb992020-01-20 16:33:22 -0500656
657 const auto image_stencil_struct = lvl_find_in_chain<VkImageStencilUsageCreateInfoEXT>(pCreateInfo->pNext);
658 if (image_stencil_struct != nullptr) {
659 if ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT) != 0) {
660 VkImageUsageFlags legal_flags = (VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT | VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT);
661 // No flags other than the legal attachment bits may be set
662 legal_flags |= VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT;
663 if ((image_stencil_struct->stencilUsage & ~legal_flags) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700664 skip |= LogError(device, "VUID-VkImageStencilUsageCreateInfo-stencilUsage-02539",
665 "vkCreateImage(): in pNext chain, VkImageStencilUsageCreateInfo::stencilUsage includes "
666 "VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT, it must not include bits other than "
667 "VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT or VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT");
Andrew Fobel3abeb992020-01-20 16:33:22 -0500668 }
669 }
670
671 if (FormatIsDepthOrStencil(pCreateInfo->format)) {
672 if ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT) != 0) {
673 if (pCreateInfo->extent.width > device_limits.maxFramebufferWidth) {
674 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700675 LogError(device, "VUID-VkImageCreateInfo-Format-02536",
676 "vkCreateImage(): Depth-stencil image contains VkImageStencilUsageCreateInfo structure with "
677 "stencilUsage including VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT and image width exceeds device "
678 "maxFramebufferWidth");
Andrew Fobel3abeb992020-01-20 16:33:22 -0500679 }
680
681 if (pCreateInfo->extent.height > device_limits.maxFramebufferHeight) {
682 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700683 LogError(device, "VUID-VkImageCreateInfo-format-02537",
684 "vkCreateImage(): Depth-stencil image contains VkImageStencilUsageCreateInfo structure with "
685 "stencilUsage including VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT and image height exceeds device "
686 "maxFramebufferHeight");
Andrew Fobel3abeb992020-01-20 16:33:22 -0500687 }
688 }
689
690 if (!physical_device_features.shaderStorageImageMultisample &&
691 ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_STORAGE_BIT) != 0) &&
692 (pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT)) {
693 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700694 LogError(device, "VUID-VkImageCreateInfo-format-02538",
695 "vkCreateImage(): Depth-stencil image contains VkImageStencilUsageCreateInfo structure with "
696 "stencilUsage including VK_IMAGE_USAGE_STORAGE_BIT and the multisampled storage images feature is "
697 "not enabled, image samples must be VK_SAMPLE_COUNT_1_BIT");
Andrew Fobel3abeb992020-01-20 16:33:22 -0500698 }
699
700 if (((pCreateInfo->usage & VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT) != 0) &&
701 ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT) == 0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700702 skip |= LogError(
703 device, "VUID-VkImageCreateInfo-format-02795",
Andrew Fobel3abeb992020-01-20 16:33:22 -0500704 "vkCreateImage(): Depth-stencil image in which usage includes VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT "
705 "contains VkImageStencilUsageCreateInfo structure, VkImageStencilUsageCreateInfo::stencilUsage must "
706 "also include VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT");
707 } else if (((pCreateInfo->usage & VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT) == 0) &&
708 ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT) != 0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700709 skip |= LogError(
710 device, "VUID-VkImageCreateInfo-format-02796",
Andrew Fobel3abeb992020-01-20 16:33:22 -0500711 "vkCreateImage(): Depth-stencil image in which usage does not include "
712 "VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT "
713 "contains VkImageStencilUsageCreateInfo structure, VkImageStencilUsageCreateInfo::stencilUsage must "
714 "also not include VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT");
715 }
716
717 if (((pCreateInfo->usage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT) != 0) &&
718 ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT) == 0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700719 skip |= LogError(
720 device, "VUID-VkImageCreateInfo-format-02797",
Andrew Fobel3abeb992020-01-20 16:33:22 -0500721 "vkCreateImage(): Depth-stencil image in which usage includes VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT "
722 "contains VkImageStencilUsageCreateInfo structure, VkImageStencilUsageCreateInfo::stencilUsage must "
723 "also include VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT");
724 } else if (((pCreateInfo->usage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT) == 0) &&
725 ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT) != 0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700726 skip |= LogError(
727 device, "VUID-VkImageCreateInfo-format-02798",
Andrew Fobel3abeb992020-01-20 16:33:22 -0500728 "vkCreateImage(): Depth-stencil image in which usage does not include "
729 "VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT "
730 "contains VkImageStencilUsageCreateInfo structure, VkImageStencilUsageCreateInfo::stencilUsage must "
731 "also not include VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT");
732 }
733 }
734 }
Spencer Frickeca52b5c2020-03-16 17:34:00 -0700735
736 if ((!physical_device_features.shaderStorageImageMultisample) && ((pCreateInfo->usage & VK_IMAGE_USAGE_STORAGE_BIT) != 0) &&
737 (pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT)) {
738 skip |= LogError(device, "VUID-VkImageCreateInfo-usage-00968",
739 "vkCreateImage(): usage contains VK_IMAGE_USAGE_STORAGE_BIT and the multisampled storage images "
740 "feature is not enabled, image samples must be VK_SAMPLE_COUNT_1_BIT");
741 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600742 }
Jeff Bolzef40fec2018-09-01 22:04:34 -0500743
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600744 return skip;
745}
746
Jeff Bolz6d3beaa2019-02-09 21:00:05 -0600747bool StatelessValidation::manual_PreCallValidateViewport(const VkViewport &viewport, const char *fn_name,
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700748 const ParameterName &parameter_name, VkCommandBuffer object) const {
Petr Krausb3fcdb42018-01-09 22:09:09 +0100749 bool skip = false;
Petr Krausb3fcdb42018-01-09 22:09:09 +0100750
751 // Note: for numerical correctness
752 // - float comparisons should expect NaN (comparison always false).
753 // - VkPhysicalDeviceLimits::maxViewportDimensions is uint32_t, not float -> careful.
754
755 const auto f_lte_u32_exact = [](const float v1_f, const uint32_t v2_u32) {
John Zulaufac0876c2018-02-19 10:09:35 -0700756 if (std::isnan(v1_f)) return false;
Petr Krausb3fcdb42018-01-09 22:09:09 +0100757 if (v1_f <= 0.0f) return true;
758
759 float intpart;
760 const float fract = modff(v1_f, &intpart);
761
762 assert(std::numeric_limits<float>::radix == 2);
763 const float u32_max_plus1 = ldexpf(1.0f, 32); // hopefully exact
764 if (intpart >= u32_max_plus1) return false;
765
766 uint32_t v1_u32 = static_cast<uint32_t>(intpart);
767 if (v1_u32 < v2_u32)
768 return true;
769 else if (v1_u32 == v2_u32 && fract == 0.0f)
770 return true;
771 else
772 return false;
773 };
774
775 const auto f_lte_u32_direct = [](const float v1_f, const uint32_t v2_u32) {
776 const float v2_f = static_cast<float>(v2_u32); // not accurate for > radix^digits; and undefined rounding mode
777 return (v1_f <= v2_f);
778 };
779
780 // width
781 bool width_healthy = true;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700782 const auto max_w = device_limits.maxViewportDimensions[0];
Petr Krausb3fcdb42018-01-09 22:09:09 +0100783
784 if (!(viewport.width > 0.0f)) {
785 width_healthy = false;
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700786 skip |= LogError(object, "VUID-VkViewport-width-01770", "%s: %s.width (=%f) is not greater than 0.0.", fn_name,
787 parameter_name.get_name().c_str(), viewport.width);
Petr Krausb3fcdb42018-01-09 22:09:09 +0100788 } else if (!(f_lte_u32_exact(viewport.width, max_w) || f_lte_u32_direct(viewport.width, max_w))) {
789 width_healthy = false;
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700790 skip |= LogError(object, "VUID-VkViewport-width-01771",
791 "%s: %s.width (=%f) exceeds VkPhysicalDeviceLimits::maxViewportDimensions[0] (=%" PRIu32 ").", fn_name,
792 parameter_name.get_name().c_str(), viewport.width, max_w);
Petr Krausb3fcdb42018-01-09 22:09:09 +0100793 } else if (!f_lte_u32_exact(viewport.width, max_w) && f_lte_u32_direct(viewport.width, max_w)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700794 skip |= LogWarning(object, kVUID_PVError_NONE,
795 "%s: %s.width (=%f) technically exceeds VkPhysicalDeviceLimits::maxViewportDimensions[0] (=%" PRIu32
796 "), but it is within the static_cast<float>(maxViewportDimensions[0]) limit.",
797 fn_name, parameter_name.get_name().c_str(), viewport.width, max_w);
Petr Krausb3fcdb42018-01-09 22:09:09 +0100798 }
799
800 // height
801 bool height_healthy = true;
Mark Lobodzinskia09ab942020-02-20 11:01:59 -0700802 const bool negative_height_enabled = device_extensions.vk_khr_maintenance1 || device_extensions.vk_amd_negative_viewport_height;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700803 const auto max_h = device_limits.maxViewportDimensions[1];
Petr Krausb3fcdb42018-01-09 22:09:09 +0100804
805 if (!negative_height_enabled && !(viewport.height > 0.0f)) {
806 height_healthy = false;
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700807 skip |= LogError(object, "VUID-VkViewport-height-01772", "%s: %s.height (=%f) is not greater 0.0.", fn_name,
808 parameter_name.get_name().c_str(), viewport.height);
Petr Krausb3fcdb42018-01-09 22:09:09 +0100809 } else if (!(f_lte_u32_exact(fabsf(viewport.height), max_h) || f_lte_u32_direct(fabsf(viewport.height), max_h))) {
810 height_healthy = false;
811
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700812 skip |= LogError(object, "VUID-VkViewport-height-01773",
813 "%s: Absolute value of %s.height (=%f) exceeds VkPhysicalDeviceLimits::maxViewportDimensions[1] (=%" PRIu32
814 ").",
815 fn_name, parameter_name.get_name().c_str(), viewport.height, max_h);
Petr Krausb3fcdb42018-01-09 22:09:09 +0100816 } else if (!f_lte_u32_exact(fabsf(viewport.height), max_h) && f_lte_u32_direct(fabsf(viewport.height), max_h)) {
817 height_healthy = false;
818
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700819 skip |= LogWarning(
820 object, kVUID_PVError_NONE,
Petr Krausb3fcdb42018-01-09 22:09:09 +0100821 "%s: Absolute value of %s.height (=%f) technically exceeds VkPhysicalDeviceLimits::maxViewportDimensions[1] (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600822 "), but it is within the static_cast<float>(maxViewportDimensions[1]) limit.",
Jeff Bolz6d3beaa2019-02-09 21:00:05 -0600823 fn_name, parameter_name.get_name().c_str(), viewport.height, max_h);
Petr Krausb3fcdb42018-01-09 22:09:09 +0100824 }
825
826 // x
827 bool x_healthy = true;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700828 if (!(viewport.x >= device_limits.viewportBoundsRange[0])) {
Petr Krausb3fcdb42018-01-09 22:09:09 +0100829 x_healthy = false;
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700830 skip |= LogError(object, "VUID-VkViewport-x-01774",
831 "%s: %s.x (=%f) is less than VkPhysicalDeviceLimits::viewportBoundsRange[0] (=%f).", fn_name,
832 parameter_name.get_name().c_str(), viewport.x, device_limits.viewportBoundsRange[0]);
Petr Krausb3fcdb42018-01-09 22:09:09 +0100833 }
834
835 // x + width
836 if (x_healthy && width_healthy) {
837 const float right_bound = viewport.x + viewport.width;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700838 if (!(right_bound <= device_limits.viewportBoundsRange[1])) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700839 skip |= LogError(
840 object, "VUID-VkViewport-x-01232",
841 "%s: %s.x + %s.width (=%f + %f = %f) is greater than VkPhysicalDeviceLimits::viewportBoundsRange[1] (=%f).",
842 fn_name, parameter_name.get_name().c_str(), parameter_name.get_name().c_str(), viewport.x, viewport.width,
843 right_bound, device_limits.viewportBoundsRange[1]);
Petr Krausb3fcdb42018-01-09 22:09:09 +0100844 }
845 }
846
847 // y
848 bool y_healthy = true;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700849 if (!(viewport.y >= device_limits.viewportBoundsRange[0])) {
Petr Krausb3fcdb42018-01-09 22:09:09 +0100850 y_healthy = false;
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700851 skip |= LogError(object, "VUID-VkViewport-y-01775",
852 "%s: %s.y (=%f) is less than VkPhysicalDeviceLimits::viewportBoundsRange[0] (=%f).", fn_name,
853 parameter_name.get_name().c_str(), viewport.y, device_limits.viewportBoundsRange[0]);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700854 } else if (negative_height_enabled && !(viewport.y <= device_limits.viewportBoundsRange[1])) {
Petr Krausb3fcdb42018-01-09 22:09:09 +0100855 y_healthy = false;
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700856 skip |= LogError(object, "VUID-VkViewport-y-01776",
857 "%s: %s.y (=%f) exceeds VkPhysicalDeviceLimits::viewportBoundsRange[1] (=%f).", fn_name,
858 parameter_name.get_name().c_str(), viewport.y, device_limits.viewportBoundsRange[1]);
Petr Krausb3fcdb42018-01-09 22:09:09 +0100859 }
860
861 // y + height
862 if (y_healthy && height_healthy) {
863 const float boundary = viewport.y + viewport.height;
864
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700865 if (!(boundary <= device_limits.viewportBoundsRange[1])) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700866 skip |= LogError(object, "VUID-VkViewport-y-01233",
867 "%s: %s.y + %s.height (=%f + %f = %f) exceeds VkPhysicalDeviceLimits::viewportBoundsRange[1] (=%f).",
868 fn_name, parameter_name.get_name().c_str(), parameter_name.get_name().c_str(), viewport.y,
869 viewport.height, boundary, device_limits.viewportBoundsRange[1]);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700870 } else if (negative_height_enabled && !(boundary >= device_limits.viewportBoundsRange[0])) {
Jeff Bolz6d3beaa2019-02-09 21:00:05 -0600871 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700872 LogError(object, "VUID-VkViewport-y-01777",
873 "%s: %s.y + %s.height (=%f + %f = %f) is less than VkPhysicalDeviceLimits::viewportBoundsRange[0] (=%f).",
874 fn_name, parameter_name.get_name().c_str(), parameter_name.get_name().c_str(), viewport.y, viewport.height,
875 boundary, device_limits.viewportBoundsRange[0]);
Petr Krausb3fcdb42018-01-09 22:09:09 +0100876 }
877 }
878
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700879 if (!device_extensions.vk_ext_depth_range_unrestricted) {
Petr Krausb3fcdb42018-01-09 22:09:09 +0100880 // minDepth
881 if (!(viewport.minDepth >= 0.0) || !(viewport.minDepth <= 1.0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700882 skip |= LogError(object, "VUID-VkViewport-minDepth-01234",
Mark Lobodzinski88529492018-04-01 10:38:15 -0600883
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700884 "%s: VK_EXT_depth_range_unrestricted extension is not enabled and %s.minDepth (=%f) is not within the "
885 "[0.0, 1.0] range.",
886 fn_name, parameter_name.get_name().c_str(), viewport.minDepth);
Petr Krausb3fcdb42018-01-09 22:09:09 +0100887 }
888
889 // maxDepth
890 if (!(viewport.maxDepth >= 0.0) || !(viewport.maxDepth <= 1.0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700891 skip |= LogError(object, "VUID-VkViewport-maxDepth-01235",
Mark Lobodzinski88529492018-04-01 10:38:15 -0600892
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700893 "%s: VK_EXT_depth_range_unrestricted extension is not enabled and %s.maxDepth (=%f) is not within the "
894 "[0.0, 1.0] range.",
895 fn_name, parameter_name.get_name().c_str(), viewport.maxDepth);
Petr Krausb3fcdb42018-01-09 22:09:09 +0100896 }
897 }
898
899 return skip;
900}
901
Dave Houlton142c4cb2018-10-17 15:04:41 -0600902struct SampleOrderInfo {
Jeff Bolz9af91c52018-09-01 21:53:57 -0500903 VkShadingRatePaletteEntryNV shadingRate;
904 uint32_t width;
905 uint32_t height;
906};
907
908// All palette entries with more than one pixel per fragment
Dave Houlton142c4cb2018-10-17 15:04:41 -0600909static SampleOrderInfo sampleOrderInfos[] = {
910 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_1X2_PIXELS_NV, 1, 2},
911 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_2X1_PIXELS_NV, 2, 1},
912 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_2X2_PIXELS_NV, 2, 2},
913 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_4X2_PIXELS_NV, 4, 2},
914 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_2X4_PIXELS_NV, 2, 4},
915 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_4X4_PIXELS_NV, 4, 4},
Jeff Bolz9af91c52018-09-01 21:53:57 -0500916};
917
Jeff Bolz46c0ea02019-10-09 13:06:29 -0500918bool StatelessValidation::ValidateCoarseSampleOrderCustomNV(const VkCoarseSampleOrderCustomNV *order) const {
Jeff Bolz9af91c52018-09-01 21:53:57 -0500919 bool skip = false;
Jeff Bolz9af91c52018-09-01 21:53:57 -0500920
Jeff Bolz45bf7d62018-09-18 15:39:58 -0500921 SampleOrderInfo *sampleOrderInfo;
Jeff Bolz9af91c52018-09-01 21:53:57 -0500922 uint32_t infoIdx = 0;
Jeff Bolz45bf7d62018-09-18 15:39:58 -0500923 for (sampleOrderInfo = nullptr; infoIdx < ARRAY_SIZE(sampleOrderInfos); ++infoIdx) {
Jeff Bolz9af91c52018-09-01 21:53:57 -0500924 if (sampleOrderInfos[infoIdx].shadingRate == order->shadingRate) {
Jeff Bolzb8a8dd02018-09-18 02:39:24 -0500925 sampleOrderInfo = &sampleOrderInfos[infoIdx];
Jeff Bolz9af91c52018-09-01 21:53:57 -0500926 break;
927 }
928 }
929
Jeff Bolzb8a8dd02018-09-18 02:39:24 -0500930 if (sampleOrderInfo == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700931 skip |= LogError(device, "VUID-VkCoarseSampleOrderCustomNV-shadingRate-02073",
932 "VkCoarseSampleOrderCustomNV shadingRate must be a shading rate "
933 "that generates fragments with more than one pixel.");
Jeff Bolz9af91c52018-09-01 21:53:57 -0500934 return skip;
935 }
936
Dave Houlton142c4cb2018-10-17 15:04:41 -0600937 if (order->sampleCount == 0 || (order->sampleCount & (order->sampleCount - 1)) ||
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700938 !(order->sampleCount & device_limits.framebufferNoAttachmentsSampleCounts)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700939 skip |= LogError(device, "VUID-VkCoarseSampleOrderCustomNV-sampleCount-02074",
940 "VkCoarseSampleOrderCustomNV sampleCount (=%" PRIu32
941 ") must "
942 "correspond to a sample count enumerated in VkSampleCountFlags whose corresponding bit "
943 "is set in framebufferNoAttachmentsSampleCounts.",
944 order->sampleCount);
Jeff Bolz9af91c52018-09-01 21:53:57 -0500945 }
946
Jeff Bolz9af91c52018-09-01 21:53:57 -0500947 if (order->sampleLocationCount != order->sampleCount * sampleOrderInfo->width * sampleOrderInfo->height) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700948 skip |= LogError(device, "VUID-VkCoarseSampleOrderCustomNV-sampleLocationCount-02075",
949 "VkCoarseSampleOrderCustomNV sampleLocationCount (=%" PRIu32
950 ") must "
951 "be equal to the product of sampleCount (=%" PRIu32
952 "), the fragment width for shadingRate "
953 "(=%" PRIu32 "), and the fragment height for shadingRate (=%" PRIu32 ").",
954 order->sampleLocationCount, order->sampleCount, sampleOrderInfo->width, sampleOrderInfo->height);
Jeff Bolz9af91c52018-09-01 21:53:57 -0500955 }
956
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700957 if (order->sampleLocationCount > phys_dev_ext_props.shading_rate_image_props.shadingRateMaxCoarseSamples) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700958 skip |= LogError(
959 device, "VUID-VkCoarseSampleOrderCustomNV-sampleLocationCount-02076",
Dave Houlton142c4cb2018-10-17 15:04:41 -0600960 "VkCoarseSampleOrderCustomNV sampleLocationCount (=%" PRIu32
961 ") must "
962 "be less than or equal to VkPhysicalDeviceShadingRateImagePropertiesNV shadingRateMaxCoarseSamples (=%" PRIu32 ").",
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700963 order->sampleLocationCount, phys_dev_ext_props.shading_rate_image_props.shadingRateMaxCoarseSamples);
Jeff Bolz9af91c52018-09-01 21:53:57 -0500964 }
Jeff Bolz9af91c52018-09-01 21:53:57 -0500965
966 // Accumulate a bitmask tracking which (x,y,sample) tuples are seen. Expect
Jeff Bolzb8a8dd02018-09-18 02:39:24 -0500967 // the first width*height*sampleCount bits to all be set. Note: There is no
968 // guarantee that 64 bits is enough, but practically it's unlikely for an
969 // implementation to support more than 32 bits for samplemask.
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700970 assert(phys_dev_ext_props.shading_rate_image_props.shadingRateMaxCoarseSamples <= 64);
Jeff Bolz9af91c52018-09-01 21:53:57 -0500971 uint64_t sampleLocationsMask = 0;
972 for (uint32_t i = 0; i < order->sampleLocationCount; ++i) {
973 const VkCoarseSampleLocationNV *sampleLoc = &order->pSampleLocations[i];
974 if (sampleLoc->pixelX >= sampleOrderInfo->width) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700975 skip |= LogError(device, "VUID-VkCoarseSampleLocationNV-pixelX-02078",
976 "pixelX must be less than the width (in pixels) of the fragment.");
Jeff Bolz9af91c52018-09-01 21:53:57 -0500977 }
978 if (sampleLoc->pixelY >= sampleOrderInfo->height) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700979 skip |= LogError(device, "VUID-VkCoarseSampleLocationNV-pixelY-02079",
980 "pixelY must be less than the height (in pixels) of the fragment.");
Jeff Bolz9af91c52018-09-01 21:53:57 -0500981 }
982 if (sampleLoc->sample >= order->sampleCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700983 skip |= LogError(device, "VUID-VkCoarseSampleLocationNV-sample-02080",
984 "sample must be less than the number of coverage samples in each pixel belonging to the fragment.");
Jeff Bolz9af91c52018-09-01 21:53:57 -0500985 }
986 uint32_t idx = sampleLoc->sample + order->sampleCount * (sampleLoc->pixelX + sampleOrderInfo->width * sampleLoc->pixelY);
987 sampleLocationsMask |= 1ULL << idx;
988 }
989
990 uint64_t expectedMask = (order->sampleLocationCount == 64) ? ~0ULL : ((1ULL << order->sampleLocationCount) - 1);
991 if (sampleLocationsMask != expectedMask) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700992 skip |= LogError(
993 device, "VUID-VkCoarseSampleOrderCustomNV-pSampleLocations-02077",
Dave Houlton142c4cb2018-10-17 15:04:41 -0600994 "The array pSampleLocations must contain exactly one entry for "
995 "every combination of valid values for pixelX, pixelY, and sample in the structure VkCoarseSampleOrderCustomNV.");
Jeff Bolz9af91c52018-09-01 21:53:57 -0500996 }
997
998 return skip;
999}
1000
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07001001bool StatelessValidation::manual_PreCallValidateCreateGraphicsPipelines(VkDevice device, VkPipelineCache pipelineCache,
1002 uint32_t createInfoCount,
1003 const VkGraphicsPipelineCreateInfo *pCreateInfos,
1004 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05001005 VkPipeline *pPipelines) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001006 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001007
1008 if (pCreateInfos != nullptr) {
1009 for (uint32_t i = 0; i < createInfoCount; ++i) {
Petr Kraus299ba622017-11-24 03:09:03 +01001010 bool has_dynamic_viewport = false;
1011 bool has_dynamic_scissor = false;
1012 bool has_dynamic_line_width = false;
Spencer Fricke8d428882020-03-16 17:23:33 -07001013 bool has_dynamic_depth_bias = false;
1014 bool has_dynamic_blend_constant = false;
1015 bool has_dynamic_depth_bounds = false;
1016 bool has_dynamic_stencil_compare = false;
1017 bool has_dynamic_stencil_write = false;
1018 bool has_dynamic_stencil_reference = false;
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001019 bool has_dynamic_viewport_w_scaling_nv = false;
1020 bool has_dynamic_discard_rectangle_ext = false;
1021 bool has_dynamic_sample_locations_ext = false;
Jeff Bolz3e71f782018-08-29 23:15:45 -05001022 bool has_dynamic_exclusive_scissor_nv = false;
Jeff Bolz9af91c52018-09-01 21:53:57 -05001023 bool has_dynamic_shading_rate_palette_nv = false;
Spencer Fricke8d428882020-03-16 17:23:33 -07001024 bool has_dynamic_viewport_course_sample_order_nv = false;
Jeff Bolz8125a8b2019-08-16 16:29:45 -05001025 bool has_dynamic_line_stipple = false;
Petr Kraus299ba622017-11-24 03:09:03 +01001026 if (pCreateInfos[i].pDynamicState != nullptr) {
1027 const auto &dynamic_state_info = *pCreateInfos[i].pDynamicState;
1028 for (uint32_t state_index = 0; state_index < dynamic_state_info.dynamicStateCount; ++state_index) {
1029 const auto &dynamic_state = dynamic_state_info.pDynamicStates[state_index];
Spencer Fricke8d428882020-03-16 17:23:33 -07001030 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT) {
1031 if (has_dynamic_viewport == true) {
1032 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1033 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_VIEWPORT was listed twice in the "
1034 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1035 i);
1036 }
1037 has_dynamic_viewport = true;
1038 }
1039 if (dynamic_state == VK_DYNAMIC_STATE_SCISSOR) {
1040 if (has_dynamic_scissor == true) {
1041 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1042 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_SCISSOR was listed twice in the "
1043 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1044 i);
1045 }
1046 has_dynamic_scissor = true;
1047 }
1048 if (dynamic_state == VK_DYNAMIC_STATE_LINE_WIDTH) {
1049 if (has_dynamic_line_width == true) {
1050 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1051 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_LINE_WIDTH was listed twice in the "
1052 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1053 i);
1054 }
1055 has_dynamic_line_width = true;
1056 }
1057 if (dynamic_state == VK_DYNAMIC_STATE_DEPTH_BIAS) {
1058 if (has_dynamic_depth_bias == true) {
1059 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1060 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DEPTH_BIAS was listed twice in the "
1061 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1062 i);
1063 }
1064 has_dynamic_depth_bias = true;
1065 }
1066 if (dynamic_state == VK_DYNAMIC_STATE_BLEND_CONSTANTS) {
1067 if (has_dynamic_blend_constant == true) {
1068 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1069 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_BLEND_CONSTANTS was listed twice in the "
1070 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1071 i);
1072 }
1073 has_dynamic_blend_constant = true;
1074 }
1075 if (dynamic_state == VK_DYNAMIC_STATE_DEPTH_BOUNDS) {
1076 if (has_dynamic_depth_bounds == true) {
1077 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1078 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DEPTH_BOUNDS was listed twice in the "
1079 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1080 i);
1081 }
1082 has_dynamic_depth_bounds = true;
1083 }
1084 if (dynamic_state == VK_DYNAMIC_STATE_STENCIL_COMPARE_MASK) {
1085 if (has_dynamic_stencil_compare == true) {
1086 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1087 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_STENCIL_COMPARE_MASK was listed twice in "
1088 "the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1089 i);
1090 }
1091 has_dynamic_stencil_compare = true;
1092 }
1093 if (dynamic_state == VK_DYNAMIC_STATE_STENCIL_WRITE_MASK) {
1094 if (has_dynamic_stencil_write == true) {
1095 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1096 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_STENCIL_WRITE_MASK was listed twice in "
1097 "the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1098 i);
1099 }
1100 has_dynamic_stencil_write = true;
1101 }
1102 if (dynamic_state == VK_DYNAMIC_STATE_STENCIL_REFERENCE) {
1103 if (has_dynamic_stencil_reference == true) {
1104 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1105 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_STENCIL_REFERENCE was listed twice in "
1106 "the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1107 i);
1108 }
1109 has_dynamic_stencil_reference = true;
1110 }
1111 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT_W_SCALING_NV) {
1112 if (has_dynamic_viewport_w_scaling_nv == true) {
1113 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1114 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_VIEWPORT_W_SCALING_NV was listed twice "
1115 "in the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1116 i);
1117 }
1118 has_dynamic_viewport_w_scaling_nv = true;
1119 }
1120 if (dynamic_state == VK_DYNAMIC_STATE_DISCARD_RECTANGLE_EXT) {
1121 if (has_dynamic_discard_rectangle_ext == true) {
1122 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1123 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DISCARD_RECTANGLE_EXT was listed twice "
1124 "in the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1125 i);
1126 }
1127 has_dynamic_discard_rectangle_ext = true;
1128 }
1129 if (dynamic_state == VK_DYNAMIC_STATE_SAMPLE_LOCATIONS_EXT) {
1130 if (has_dynamic_sample_locations_ext == true) {
1131 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1132 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_SAMPLE_LOCATIONS_EXT was listed twice in "
1133 "the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1134 i);
1135 }
1136 has_dynamic_sample_locations_ext = true;
1137 }
1138 if (dynamic_state == VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV) {
1139 if (has_dynamic_exclusive_scissor_nv == true) {
1140 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1141 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV was listed twice in "
1142 "the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1143 i);
1144 }
1145 has_dynamic_exclusive_scissor_nv = true;
1146 }
1147 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT_SHADING_RATE_PALETTE_NV) {
1148 if (has_dynamic_shading_rate_palette_nv == true) {
1149 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1150 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_VIEWPORT_SHADING_RATE_PALETTE_NV was "
1151 "listed twice in the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1152 i);
1153 }
Dave Houlton142c4cb2018-10-17 15:04:41 -06001154 has_dynamic_shading_rate_palette_nv = true;
Spencer Fricke8d428882020-03-16 17:23:33 -07001155 }
1156 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT_COARSE_SAMPLE_ORDER_NV) {
1157 if (has_dynamic_viewport_course_sample_order_nv == true) {
1158 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1159 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_VIEWPORT_COARSE_SAMPLE_ORDER_NV was "
1160 "listed twice in the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1161 i);
1162 }
1163 has_dynamic_viewport_course_sample_order_nv = true;
1164 }
1165 if (dynamic_state == VK_DYNAMIC_STATE_LINE_STIPPLE_EXT) {
1166 if (has_dynamic_line_stipple == true) {
1167 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1168 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_LINE_STIPPLE_EXT was listed twice in the "
1169 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1170 i);
1171 }
1172 has_dynamic_line_stipple = true;
1173 }
Petr Kraus299ba622017-11-24 03:09:03 +01001174 }
1175 }
1176
Peter Chen85366392019-05-14 15:20:11 -04001177 auto feedback_struct = lvl_find_in_chain<VkPipelineCreationFeedbackCreateInfoEXT>(pCreateInfos[i].pNext);
1178 if ((feedback_struct != nullptr) &&
1179 (feedback_struct->pipelineStageCreationFeedbackCount != pCreateInfos[i].stageCount)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001180 skip |= LogError(device, "VUID-VkPipelineCreationFeedbackCreateInfoEXT-pipelineStageCreationFeedbackCount-02668",
1181 "vkCreateGraphicsPipelines(): in pCreateInfo[%" PRIu32
1182 "], VkPipelineCreationFeedbackEXT::pipelineStageCreationFeedbackCount"
1183 "(=%" PRIu32 ") must equal VkGraphicsPipelineCreateInfo::stageCount(=%" PRIu32 ").",
1184 i, feedback_struct->pipelineStageCreationFeedbackCount, pCreateInfos[i].stageCount);
Peter Chen85366392019-05-14 15:20:11 -04001185 }
1186
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001187 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001188
Spencer Frickef1b0a7d2020-03-16 17:38:55 -07001189 // Collect active stages and other information
1190 // Only want to loop through pStages once
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001191 uint32_t active_shaders = 0;
Spencer Frickef1b0a7d2020-03-16 17:38:55 -07001192 bool has_eval = false;
1193 bool has_control = false;
1194 if (pCreateInfos[i].pStages != nullptr) {
1195 for (uint32_t stage_index = 0; stage_index < pCreateInfos[i].stageCount; ++stage_index) {
1196 active_shaders |= pCreateInfos[i].pStages[stage_index].stage;
1197
1198 if (pCreateInfos[i].pStages[stage_index].stage == VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) {
1199 has_control = true;
1200 } else if (pCreateInfos[i].pStages[stage_index].stage == VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT) {
1201 has_eval = true;
1202 }
1203
1204 skip |= validate_string(
1205 "vkCreateGraphicsPipelines",
1206 ParameterName("pCreateInfos[%i].pStages[%i].pName", ParameterName::IndexVector{i, stage_index}),
1207 "VUID-VkGraphicsPipelineCreateInfo-pStages-parameter", pCreateInfos[i].pStages[stage_index].pName);
1208 }
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001209 }
1210
1211 if ((active_shaders & VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) &&
1212 (active_shaders & VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT) && (pCreateInfos[i].pTessellationState != nullptr)) {
1213 skip |= validate_struct_type("vkCreateGraphicsPipelines", "pCreateInfos[i].pTessellationState",
1214 "VK_STRUCTURE_TYPE_PIPELINE_TESSELLATION_STATE_CREATE_INFO",
1215 pCreateInfos[i].pTessellationState,
1216 VK_STRUCTURE_TYPE_PIPELINE_TESSELLATION_STATE_CREATE_INFO, false, kVUIDUndefined,
1217 "VUID-VkPipelineTessellationStateCreateInfo-sType-sType");
1218
1219 const VkStructureType allowed_structs_VkPipelineTessellationStateCreateInfo[] = {
1220 VK_STRUCTURE_TYPE_PIPELINE_TESSELLATION_DOMAIN_ORIGIN_STATE_CREATE_INFO};
1221
1222 skip |= validate_struct_pnext("vkCreateGraphicsPipelines", "pCreateInfos[i].pTessellationState->pNext",
1223 "VkPipelineTessellationDomainOriginStateCreateInfo",
1224 pCreateInfos[i].pTessellationState->pNext,
1225 ARRAY_SIZE(allowed_structs_VkPipelineTessellationStateCreateInfo),
1226 allowed_structs_VkPipelineTessellationStateCreateInfo, GeneratedVulkanHeaderVersion,
sfricke-samsung32a27362020-02-28 09:06:42 -08001227 "VUID-VkPipelineTessellationStateCreateInfo-pNext-pNext",
1228 "VUID-VkPipelineTessellationStateCreateInfo-sType-unique");
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001229
1230 skip |= validate_reserved_flags("vkCreateGraphicsPipelines", "pCreateInfos[i].pTessellationState->flags",
1231 pCreateInfos[i].pTessellationState->flags,
1232 "VUID-VkPipelineTessellationStateCreateInfo-flags-zerobitmask");
1233 }
1234
1235 if (!(active_shaders & VK_SHADER_STAGE_MESH_BIT_NV) && (pCreateInfos[i].pInputAssemblyState != nullptr)) {
1236 skip |= validate_struct_type("vkCreateGraphicsPipelines", "pCreateInfos[i].pInputAssemblyState",
1237 "VK_STRUCTURE_TYPE_PIPELINE_INPUT_ASSEMBLY_STATE_CREATE_INFO",
1238 pCreateInfos[i].pInputAssemblyState,
1239 VK_STRUCTURE_TYPE_PIPELINE_INPUT_ASSEMBLY_STATE_CREATE_INFO, false, kVUIDUndefined,
1240 "VUID-VkPipelineInputAssemblyStateCreateInfo-sType-sType");
1241
1242 skip |= validate_struct_pnext("vkCreateGraphicsPipelines", "pCreateInfos[i].pInputAssemblyState->pNext", NULL,
1243 pCreateInfos[i].pInputAssemblyState->pNext, 0, NULL, GeneratedVulkanHeaderVersion,
sfricke-samsung32a27362020-02-28 09:06:42 -08001244 "VUID-VkPipelineInputAssemblyStateCreateInfo-pNext-pNext", nullptr);
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001245
1246 skip |= validate_reserved_flags("vkCreateGraphicsPipelines", "pCreateInfos[i].pInputAssemblyState->flags",
1247 pCreateInfos[i].pInputAssemblyState->flags,
1248 "VUID-VkPipelineInputAssemblyStateCreateInfo-flags-zerobitmask");
1249
1250 skip |= validate_ranged_enum("vkCreateGraphicsPipelines", "pCreateInfos[i].pInputAssemblyState->topology",
1251 "VkPrimitiveTopology", AllVkPrimitiveTopologyEnums,
1252 pCreateInfos[i].pInputAssemblyState->topology,
1253 "VUID-VkPipelineInputAssemblyStateCreateInfo-topology-parameter");
1254
1255 skip |= validate_bool32("vkCreateGraphicsPipelines", "pCreateInfos[i].pInputAssemblyState->primitiveRestartEnable",
1256 pCreateInfos[i].pInputAssemblyState->primitiveRestartEnable);
1257 }
1258
1259 if (!(active_shaders & VK_SHADER_STAGE_MESH_BIT_NV) && (pCreateInfos[i].pVertexInputState != nullptr)) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001260 auto const &vertex_input_state = pCreateInfos[i].pVertexInputState;
Peter Kohautc7d9d392018-07-15 00:34:07 +02001261
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001262 if (pCreateInfos[i].pVertexInputState->flags != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001263 skip |= LogError(device, "VUID-VkPipelineVertexInputStateCreateInfo-flags-zerobitmask",
1264 "vkCreateGraphicsPipelines: pararameter "
1265 "pCreateInfos[%d].pVertexInputState->flags (%u) is reserved and must be zero.",
1266 i, vertex_input_state->flags);
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001267 }
1268
1269 const VkStructureType allowed_structs_VkPipelineVertexInputStateCreateInfo[] = {
1270 VK_STRUCTURE_TYPE_PIPELINE_VERTEX_INPUT_DIVISOR_STATE_CREATE_INFO_EXT};
1271 skip |= validate_struct_pnext("vkCreateGraphicsPipelines", "pCreateInfos[i].pVertexInputState->pNext",
1272 "VkPipelineVertexInputDivisorStateCreateInfoEXT",
1273 pCreateInfos[i].pVertexInputState->pNext, 1,
1274 allowed_structs_VkPipelineVertexInputStateCreateInfo, GeneratedVulkanHeaderVersion,
sfricke-samsung32a27362020-02-28 09:06:42 -08001275 "VUID-VkPipelineVertexInputStateCreateInfo-pNext-pNext",
1276 "VUID-VkPipelineVertexInputStateCreateInfo-sType-unique");
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001277 skip |= validate_struct_type("vkCreateGraphicsPipelines", "pCreateInfos[i].pVertexInputState",
1278 "VK_STRUCTURE_TYPE_PIPELINE_VERTEX_INPUT_STATE_CREATE_INFO", vertex_input_state,
Shannon McPherson3cc90bc2019-08-13 11:28:22 -06001279 VK_STRUCTURE_TYPE_PIPELINE_VERTEX_INPUT_STATE_CREATE_INFO, false, kVUIDUndefined,
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001280 "VUID-VkPipelineVertexInputStateCreateInfo-sType-sType");
1281 skip |=
1282 validate_array("vkCreateGraphicsPipelines", "pCreateInfos[i].pVertexInputState->vertexBindingDescriptionCount",
1283 "pCreateInfos[i].pVertexInputState->pVertexBindingDescriptions",
1284 pCreateInfos[i].pVertexInputState->vertexBindingDescriptionCount,
1285 &pCreateInfos[i].pVertexInputState->pVertexBindingDescriptions, false, true, kVUIDUndefined,
1286 "VUID-VkPipelineVertexInputStateCreateInfo-pVertexBindingDescriptions-parameter");
1287
1288 skip |= validate_array(
1289 "vkCreateGraphicsPipelines", "pCreateInfos[i].pVertexInputState->vertexAttributeDescriptionCount",
1290 "pCreateInfos[i]->pVertexAttributeDescriptions", vertex_input_state->vertexAttributeDescriptionCount,
1291 &vertex_input_state->pVertexAttributeDescriptions, false, true, kVUIDUndefined,
1292 "VUID-VkPipelineVertexInputStateCreateInfo-pVertexAttributeDescriptions-parameter");
1293
1294 if (pCreateInfos[i].pVertexInputState->pVertexBindingDescriptions != NULL) {
1295 for (uint32_t vertexBindingDescriptionIndex = 0;
1296 vertexBindingDescriptionIndex < pCreateInfos[i].pVertexInputState->vertexBindingDescriptionCount;
1297 ++vertexBindingDescriptionIndex) {
1298 skip |= validate_ranged_enum(
1299 "vkCreateGraphicsPipelines",
1300 "pCreateInfos[i].pVertexInputState->pVertexBindingDescriptions[j].inputRate", "VkVertexInputRate",
1301 AllVkVertexInputRateEnums,
1302 pCreateInfos[i].pVertexInputState->pVertexBindingDescriptions[vertexBindingDescriptionIndex].inputRate,
1303 "VUID-VkVertexInputBindingDescription-inputRate-parameter");
1304 }
1305 }
1306
1307 if (pCreateInfos[i].pVertexInputState->pVertexAttributeDescriptions != NULL) {
1308 for (uint32_t vertexAttributeDescriptionIndex = 0;
1309 vertexAttributeDescriptionIndex < pCreateInfos[i].pVertexInputState->vertexAttributeDescriptionCount;
1310 ++vertexAttributeDescriptionIndex) {
1311 skip |= validate_ranged_enum(
1312 "vkCreateGraphicsPipelines",
1313 "pCreateInfos[i].pVertexInputState->pVertexAttributeDescriptions[i].format", "VkFormat",
1314 AllVkFormatEnums,
1315 pCreateInfos[i].pVertexInputState->pVertexAttributeDescriptions[vertexAttributeDescriptionIndex].format,
1316 "VUID-VkVertexInputAttributeDescription-format-parameter");
1317 }
1318 }
1319
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001320 if (vertex_input_state->vertexBindingDescriptionCount > device_limits.maxVertexInputBindings) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001321 skip |= LogError(device, "VUID-VkPipelineVertexInputStateCreateInfo-vertexBindingDescriptionCount-00613",
1322 "vkCreateGraphicsPipelines: pararameter "
1323 "pCreateInfo[%d].pVertexInputState->vertexBindingDescriptionCount (%u) is "
1324 "greater than VkPhysicalDeviceLimits::maxVertexInputBindings (%u).",
1325 i, vertex_input_state->vertexBindingDescriptionCount, device_limits.maxVertexInputBindings);
Peter Kohautc7d9d392018-07-15 00:34:07 +02001326 }
1327
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001328 if (vertex_input_state->vertexAttributeDescriptionCount > device_limits.maxVertexInputAttributes) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001329 skip |=
1330 LogError(device, "VUID-VkPipelineVertexInputStateCreateInfo-vertexAttributeDescriptionCount-00614",
1331 "vkCreateGraphicsPipelines: pararameter "
1332 "pCreateInfo[%d].pVertexInputState->vertexAttributeDescriptionCount (%u) is "
1333 "greater than VkPhysicalDeviceLimits::maxVertexInputAttributes (%u).",
1334 i, vertex_input_state->vertexAttributeDescriptionCount, device_limits.maxVertexInputAttributes);
Peter Kohautc7d9d392018-07-15 00:34:07 +02001335 }
1336
1337 std::unordered_set<uint32_t> vertex_bindings(vertex_input_state->vertexBindingDescriptionCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001338 for (uint32_t d = 0; d < vertex_input_state->vertexBindingDescriptionCount; ++d) {
1339 auto const &vertex_bind_desc = vertex_input_state->pVertexBindingDescriptions[d];
Peter Kohautc7d9d392018-07-15 00:34:07 +02001340 auto const &binding_it = vertex_bindings.find(vertex_bind_desc.binding);
1341 if (binding_it != vertex_bindings.cend()) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001342 skip |= LogError(device, "VUID-VkPipelineVertexInputStateCreateInfo-pVertexBindingDescriptions-00616",
1343 "vkCreateGraphicsPipelines: parameter "
1344 "pCreateInfo[%d].pVertexInputState->pVertexBindingDescription[%d].binding "
1345 "(%" PRIu32 ") is not distinct.",
1346 i, d, vertex_bind_desc.binding);
Peter Kohautc7d9d392018-07-15 00:34:07 +02001347 }
1348 vertex_bindings.insert(vertex_bind_desc.binding);
1349
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001350 if (vertex_bind_desc.binding >= device_limits.maxVertexInputBindings) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001351 skip |= LogError(device, "VUID-VkVertexInputBindingDescription-binding-00618",
1352 "vkCreateGraphicsPipelines: parameter "
1353 "pCreateInfos[%u].pVertexInputState->pVertexBindingDescriptions[%u].binding (%u) is "
1354 "greater than or equal to VkPhysicalDeviceLimits::maxVertexInputBindings (%u).",
1355 i, d, vertex_bind_desc.binding, device_limits.maxVertexInputBindings);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001356 }
1357
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001358 if (vertex_bind_desc.stride > device_limits.maxVertexInputBindingStride) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001359 skip |=
1360 LogError(device, "VUID-VkVertexInputBindingDescription-stride-00619",
1361 "vkCreateGraphicsPipelines: parameter "
1362 "pCreateInfos[%u].pVertexInputState->pVertexBindingDescriptions[%u].stride (%u) is greater "
1363 "than VkPhysicalDeviceLimits::maxVertexInputBindingStride (%u).",
1364 i, d, vertex_bind_desc.stride, device_limits.maxVertexInputBindingStride);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001365 }
1366 }
1367
Peter Kohautc7d9d392018-07-15 00:34:07 +02001368 std::unordered_set<uint32_t> attribute_locations(vertex_input_state->vertexAttributeDescriptionCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001369 for (uint32_t d = 0; d < vertex_input_state->vertexAttributeDescriptionCount; ++d) {
1370 auto const &vertex_attrib_desc = vertex_input_state->pVertexAttributeDescriptions[d];
Peter Kohautc7d9d392018-07-15 00:34:07 +02001371 auto const &location_it = attribute_locations.find(vertex_attrib_desc.location);
1372 if (location_it != attribute_locations.cend()) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001373 skip |= LogError(
1374 device, "VUID-VkPipelineVertexInputStateCreateInfo-pVertexAttributeDescriptions-00617",
Peter Kohautc7d9d392018-07-15 00:34:07 +02001375 "vkCreateGraphicsPipelines: parameter "
1376 "pCreateInfo[%d].pVertexInputState->vertexAttributeDescriptions[%d].location (%u) is not distinct.",
1377 i, d, vertex_attrib_desc.location);
1378 }
1379 attribute_locations.insert(vertex_attrib_desc.location);
1380
1381 auto const &binding_it = vertex_bindings.find(vertex_attrib_desc.binding);
1382 if (binding_it == vertex_bindings.cend()) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001383 skip |= LogError(
1384 device, "VUID-VkPipelineVertexInputStateCreateInfo-binding-00615",
Peter Kohautc7d9d392018-07-15 00:34:07 +02001385 "vkCreateGraphicsPipelines: parameter "
1386 " pCreateInfo[%d].pVertexInputState->vertexAttributeDescriptions[%d].binding (%u) does not exist "
1387 "in any pCreateInfo[%d].pVertexInputState->pVertexBindingDescription.",
1388 i, d, vertex_attrib_desc.binding, i);
1389 }
1390
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001391 if (vertex_attrib_desc.location >= device_limits.maxVertexInputAttributes) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001392 skip |= LogError(device, "VUID-VkVertexInputAttributeDescription-location-00620",
1393 "vkCreateGraphicsPipelines: parameter "
1394 "pCreateInfos[%u].pVertexInputState->pVertexAttributeDescriptions[%u].location (%u) is "
1395 "greater than or equal to VkPhysicalDeviceLimits::maxVertexInputAttributes (%u).",
1396 i, d, vertex_attrib_desc.location, device_limits.maxVertexInputAttributes);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001397 }
1398
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001399 if (vertex_attrib_desc.binding >= device_limits.maxVertexInputBindings) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001400 skip |= LogError(device, "VUID-VkVertexInputAttributeDescription-binding-00621",
1401 "vkCreateGraphicsPipelines: parameter "
1402 "pCreateInfos[%u].pVertexInputState->pVertexAttributeDescriptions[%u].binding (%u) is "
1403 "greater than or equal to VkPhysicalDeviceLimits::maxVertexInputBindings (%u).",
1404 i, d, vertex_attrib_desc.binding, device_limits.maxVertexInputBindings);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001405 }
1406
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001407 if (vertex_attrib_desc.offset > device_limits.maxVertexInputAttributeOffset) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001408 skip |= LogError(device, "VUID-VkVertexInputAttributeDescription-offset-00622",
1409 "vkCreateGraphicsPipelines: parameter "
1410 "pCreateInfos[%u].pVertexInputState->pVertexAttributeDescriptions[%u].offset (%u) is "
1411 "greater than VkPhysicalDeviceLimits::maxVertexInputAttributeOffset (%u).",
1412 i, d, vertex_attrib_desc.offset, device_limits.maxVertexInputAttributeOffset);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001413 }
1414 }
1415 }
1416
Spencer Frickef1b0a7d2020-03-16 17:38:55 -07001417 // pTessellationState is ignored without both tessellation control and tessellation evaluation shaders stages
1418 if (has_control && has_eval) {
1419 if (pCreateInfos[i].pTessellationState == nullptr) {
1420 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-pStages-00731",
1421 "vkCreateGraphicsPipelines: if pCreateInfos[%d].pStages includes a tessellation control "
1422 "shader stage and a tessellation evaluation shader stage, "
1423 "pCreateInfos[%d].pTessellationState must not be NULL.",
1424 i, i);
1425 } else {
1426 const VkStructureType allowed_type = VK_STRUCTURE_TYPE_PIPELINE_TESSELLATION_DOMAIN_ORIGIN_STATE_CREATE_INFO;
1427 skip |= validate_struct_pnext(
1428 "vkCreateGraphicsPipelines",
1429 ParameterName("pCreateInfos[%i].pTessellationState->pNext", ParameterName::IndexVector{i}),
1430 "VkPipelineTessellationDomainOriginStateCreateInfo", pCreateInfos[i].pTessellationState->pNext, 1,
1431 &allowed_type, GeneratedVulkanHeaderVersion, "VUID-VkGraphicsPipelineCreateInfo-pNext-pNext",
1432 "VUID-VkGraphicsPipelineCreateInfo-sType-unique");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001433
Spencer Frickef1b0a7d2020-03-16 17:38:55 -07001434 skip |= validate_reserved_flags(
1435 "vkCreateGraphicsPipelines",
1436 ParameterName("pCreateInfos[%i].pTessellationState->flags", ParameterName::IndexVector{i}),
1437 pCreateInfos[i].pTessellationState->flags, "VUID-VkPipelineTessellationStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001438
Spencer Frickef1b0a7d2020-03-16 17:38:55 -07001439 if (pCreateInfos[i].pTessellationState->patchControlPoints == 0 ||
1440 pCreateInfos[i].pTessellationState->patchControlPoints > device_limits.maxTessellationPatchSize) {
1441 skip |= LogError(device, "VUID-VkPipelineTessellationStateCreateInfo-patchControlPoints-01214",
1442 "vkCreateGraphicsPipelines: invalid parameter "
1443 "pCreateInfos[%d].pTessellationState->patchControlPoints value %u. patchControlPoints "
1444 "should be >0 and <=%u.",
1445 i, pCreateInfos[i].pTessellationState->patchControlPoints,
1446 device_limits.maxTessellationPatchSize);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001447 }
1448 }
1449 }
1450
1451 // pViewportState, pMultisampleState, pDepthStencilState, and pColorBlendState ignored when rasterization is disabled
1452 if ((pCreateInfos[i].pRasterizationState != nullptr) &&
1453 (pCreateInfos[i].pRasterizationState->rasterizerDiscardEnable == VK_FALSE)) {
1454 if (pCreateInfos[i].pViewportState == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001455 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-rasterizerDiscardEnable-00750",
1456 "vkCreateGraphicsPipelines: Rasterization is enabled (pCreateInfos[%" PRIu32
1457 "].pRasterizationState->rasterizerDiscardEnable is VK_FALSE), but pCreateInfos[%" PRIu32
1458 "].pViewportState (=NULL) is not a valid pointer.",
1459 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001460 } else {
Petr Krausa6103552017-11-16 21:21:58 +01001461 const auto &viewport_state = *pCreateInfos[i].pViewportState;
1462
1463 if (viewport_state.sType != VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_STATE_CREATE_INFO) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001464 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-sType-sType",
1465 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1466 "].pViewportState->sType is not VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_STATE_CREATE_INFO.",
1467 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001468 }
1469
Petr Krausa6103552017-11-16 21:21:58 +01001470 const VkStructureType allowed_structs_VkPipelineViewportStateCreateInfo[] = {
1471 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_SWIZZLE_STATE_CREATE_INFO_NV,
Jeff Bolz3e71f782018-08-29 23:15:45 -05001472 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_W_SCALING_STATE_CREATE_INFO_NV,
1473 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_EXCLUSIVE_SCISSOR_STATE_CREATE_INFO_NV,
Jeff Bolz9af91c52018-09-01 21:53:57 -05001474 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_SHADING_RATE_IMAGE_STATE_CREATE_INFO_NV,
1475 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_COARSE_SAMPLE_ORDER_STATE_CREATE_INFO_NV,
Jeff Bolz3e71f782018-08-29 23:15:45 -05001476 };
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001477 skip |= validate_struct_pnext(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001478 "vkCreateGraphicsPipelines",
Petr Krausa6103552017-11-16 21:21:58 +01001479 ParameterName("pCreateInfos[%i].pViewportState->pNext", ParameterName::IndexVector{i}),
Jeff Bolz9af91c52018-09-01 21:53:57 -05001480 "VkPipelineViewportSwizzleStateCreateInfoNV, VkPipelineViewportWScalingStateCreateInfoNV, "
Jeff Bolzb8a8dd02018-09-18 02:39:24 -05001481 "VkPipelineViewportExclusiveScissorStateCreateInfoNV, VkPipelineViewportShadingRateImageStateCreateInfoNV, "
1482 "VkPipelineViewportCoarseSampleOrderStateCreateInfoNV",
Petr Krausa6103552017-11-16 21:21:58 +01001483 viewport_state.pNext, ARRAY_SIZE(allowed_structs_VkPipelineViewportStateCreateInfo),
sfricke-samsung32a27362020-02-28 09:06:42 -08001484 allowed_structs_VkPipelineViewportStateCreateInfo, 65, "VUID-VkPipelineViewportStateCreateInfo-pNext-pNext",
1485 "VUID-VkPipelineViewportStateCreateInfo-sType-unique");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001486
1487 skip |= validate_reserved_flags(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001488 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001489 ParameterName("pCreateInfos[%i].pViewportState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06001490 viewport_state.flags, "VUID-VkPipelineViewportStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001491
Dave Houlton142c4cb2018-10-17 15:04:41 -06001492 auto exclusive_scissor_struct = lvl_find_in_chain<VkPipelineViewportExclusiveScissorStateCreateInfoNV>(
1493 pCreateInfos[i].pViewportState->pNext);
1494 auto shading_rate_image_struct = lvl_find_in_chain<VkPipelineViewportShadingRateImageStateCreateInfoNV>(
1495 pCreateInfos[i].pViewportState->pNext);
1496 auto coarse_sample_order_struct = lvl_find_in_chain<VkPipelineViewportCoarseSampleOrderStateCreateInfoNV>(
1497 pCreateInfos[i].pViewportState->pNext);
Chris Mayer328d8212018-12-11 14:16:18 +01001498 const auto vp_swizzle_struct =
1499 lvl_find_in_chain<VkPipelineViewportSwizzleStateCreateInfoNV>(pCreateInfos[i].pViewportState->pNext);
Chris Mayer9ded5eb2019-09-19 16:33:26 +02001500 const auto vp_w_scaling_struct =
1501 lvl_find_in_chain<VkPipelineViewportWScalingStateCreateInfoNV>(pCreateInfos[i].pViewportState->pNext);
Jeff Bolz3e71f782018-08-29 23:15:45 -05001502
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001503 if (!physical_device_features.multiViewport) {
Petr Krausa6103552017-11-16 21:21:58 +01001504 if (viewport_state.viewportCount != 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001505 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-viewportCount-01216",
1506 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
1507 "disabled, but pCreateInfos[%" PRIu32 "].pViewportState->viewportCount (=%" PRIu32
1508 ") is not 1.",
1509 i, viewport_state.viewportCount);
Petr Krausa6103552017-11-16 21:21:58 +01001510 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001511
Petr Krausa6103552017-11-16 21:21:58 +01001512 if (viewport_state.scissorCount != 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001513 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-01217",
1514 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
1515 "disabled, but pCreateInfos[%" PRIu32 "].pViewportState->scissorCount (=%" PRIu32
1516 ") is not 1.",
1517 i, viewport_state.scissorCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001518 }
Jeff Bolz3e71f782018-08-29 23:15:45 -05001519
Dave Houlton142c4cb2018-10-17 15:04:41 -06001520 if (exclusive_scissor_struct && (exclusive_scissor_struct->exclusiveScissorCount != 0 &&
1521 exclusive_scissor_struct->exclusiveScissorCount != 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001522 skip |= LogError(
1523 device, "VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-exclusiveScissorCount-02027",
1524 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
1525 "disabled, but pCreateInfos[%" PRIu32
1526 "] VkPipelineViewportExclusiveScissorStateCreateInfoNV::exclusiveScissorCount (=%" PRIu32
1527 ") is not 1.",
1528 i, exclusive_scissor_struct->exclusiveScissorCount);
Jeff Bolz3e71f782018-08-29 23:15:45 -05001529 }
1530
Jeff Bolz9af91c52018-09-01 21:53:57 -05001531 if (shading_rate_image_struct &&
1532 (shading_rate_image_struct->viewportCount != 0 && shading_rate_image_struct->viewportCount != 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001533 skip |= LogError(device, "VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-viewportCount-02054",
1534 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
1535 "disabled, but pCreateInfos[%" PRIu32
1536 "] VkPipelineViewportShadingRateImageStateCreateInfoNV::viewportCount (=%" PRIu32
1537 ") is neither 0 nor 1.",
1538 i, shading_rate_image_struct->viewportCount);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001539 }
1540
Petr Krausa6103552017-11-16 21:21:58 +01001541 } else { // multiViewport enabled
1542 if (viewport_state.viewportCount == 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001543 skip |= LogError(
1544 device, "VUID-VkPipelineViewportStateCreateInfo-viewportCount-arraylength",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001545 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "].pViewportState->viewportCount is 0.", i);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001546 } else if (viewport_state.viewportCount > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001547 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-viewportCount-01218",
1548 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1549 "].pViewportState->viewportCount (=%" PRIu32
1550 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
1551 i, viewport_state.viewportCount, device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001552 }
Petr Krausa6103552017-11-16 21:21:58 +01001553
1554 if (viewport_state.scissorCount == 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001555 skip |= LogError(
1556 device, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-arraylength",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001557 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "].pViewportState->scissorCount is 0.", i);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001558 } else if (viewport_state.scissorCount > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001559 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-01219",
1560 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1561 "].pViewportState->scissorCount (=%" PRIu32
1562 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
1563 i, viewport_state.scissorCount, device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001564 }
1565 }
1566
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07001567 if (exclusive_scissor_struct && exclusive_scissor_struct->exclusiveScissorCount > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001568 skip |=
1569 LogError(device, "VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-exclusiveScissorCount-02028",
1570 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "] exclusiveScissorCount (=%" PRIu32
1571 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
1572 i, exclusive_scissor_struct->exclusiveScissorCount, device_limits.maxViewports);
Jeff Bolz3e71f782018-08-29 23:15:45 -05001573 }
1574
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07001575 if (shading_rate_image_struct && shading_rate_image_struct->viewportCount > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001576 skip |= LogError(device, "VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-viewportCount-02055",
1577 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1578 "] VkPipelineViewportShadingRateImageStateCreateInfoNV viewportCount (=%" PRIu32
1579 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
1580 i, shading_rate_image_struct->viewportCount, device_limits.maxViewports);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001581 }
1582
Petr Krausa6103552017-11-16 21:21:58 +01001583 if (viewport_state.scissorCount != viewport_state.viewportCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001584 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-01220",
1585 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1586 "].pViewportState->scissorCount (=%" PRIu32 ") is not identical to pCreateInfos[%" PRIu32
1587 "].pViewportState->viewportCount (=%" PRIu32 ").",
1588 i, viewport_state.scissorCount, i, viewport_state.viewportCount);
Petr Krausa6103552017-11-16 21:21:58 +01001589 }
1590
Dave Houlton142c4cb2018-10-17 15:04:41 -06001591 if (exclusive_scissor_struct && exclusive_scissor_struct->exclusiveScissorCount != 0 &&
Jeff Bolz3e71f782018-08-29 23:15:45 -05001592 exclusive_scissor_struct->exclusiveScissorCount != viewport_state.viewportCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001593 skip |=
1594 LogError(device, "VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-exclusiveScissorCount-02029",
1595 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "] exclusiveScissorCount (=%" PRIu32
1596 ") must be zero or identical to pCreateInfos[%" PRIu32
1597 "].pViewportState->viewportCount (=%" PRIu32 ").",
1598 i, exclusive_scissor_struct->exclusiveScissorCount, i, viewport_state.viewportCount);
Jeff Bolz3e71f782018-08-29 23:15:45 -05001599 }
1600
Dave Houlton142c4cb2018-10-17 15:04:41 -06001601 if (shading_rate_image_struct && shading_rate_image_struct->shadingRateImageEnable &&
Jeff Bolz9af91c52018-09-01 21:53:57 -05001602 shading_rate_image_struct->viewportCount != viewport_state.viewportCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001603 skip |= LogError(
1604 device, "VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-shadingRateImageEnable-02056",
Dave Houlton142c4cb2018-10-17 15:04:41 -06001605 "vkCreateGraphicsPipelines: If shadingRateImageEnable is enabled, pCreateInfos[%" PRIu32
1606 "] "
1607 "VkPipelineViewportShadingRateImageStateCreateInfoNV viewportCount (=%" PRIu32
1608 ") must identical to pCreateInfos[%" PRIu32 "].pViewportState->viewportCount (=%" PRIu32 ").",
1609 i, shading_rate_image_struct->viewportCount, i, viewport_state.viewportCount);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001610 }
1611
Petr Krausa6103552017-11-16 21:21:58 +01001612 if (!has_dynamic_viewport && viewport_state.viewportCount > 0 && viewport_state.pViewports == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001613 skip |= LogError(
1614 device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-00747",
Petr Krausa6103552017-11-16 21:21:58 +01001615 "vkCreateGraphicsPipelines: The viewport state is static (pCreateInfos[%" PRIu32
1616 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_VIEWPORT), but pCreateInfos[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001617 "].pViewportState->pViewports (=NULL) is an invalid pointer.",
1618 i, i);
Petr Krausa6103552017-11-16 21:21:58 +01001619 }
1620
1621 if (!has_dynamic_scissor && viewport_state.scissorCount > 0 && viewport_state.pScissors == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001622 skip |= LogError(
1623 device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-00748",
Petr Krausa6103552017-11-16 21:21:58 +01001624 "vkCreateGraphicsPipelines: The scissor state is static (pCreateInfos[%" PRIu32
1625 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_SCISSOR), but pCreateInfos[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001626 "].pViewportState->pScissors (=NULL) is an invalid pointer.",
1627 i, i);
Petr Krausa6103552017-11-16 21:21:58 +01001628 }
1629
Jeff Bolz3e71f782018-08-29 23:15:45 -05001630 if (!has_dynamic_exclusive_scissor_nv && exclusive_scissor_struct &&
Dave Houlton142c4cb2018-10-17 15:04:41 -06001631 exclusive_scissor_struct->exclusiveScissorCount > 0 &&
1632 exclusive_scissor_struct->pExclusiveScissors == nullptr) {
1633 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001634 LogError(device, "VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-pDynamicStates-02030",
1635 "vkCreateGraphicsPipelines: The exclusive scissor state is static (pCreateInfos[%" PRIu32
1636 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV), but "
1637 "pCreateInfos[%" PRIu32 "] pExclusiveScissors (=NULL) is an invalid pointer.",
1638 i, i);
Jeff Bolz3e71f782018-08-29 23:15:45 -05001639 }
1640
Jeff Bolz9af91c52018-09-01 21:53:57 -05001641 if (!has_dynamic_shading_rate_palette_nv && shading_rate_image_struct &&
Dave Houlton142c4cb2018-10-17 15:04:41 -06001642 shading_rate_image_struct->viewportCount > 0 &&
1643 shading_rate_image_struct->pShadingRatePalettes == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001644 skip |= LogError(
1645 device, "VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-pDynamicStates-02057",
Jeff Bolz9af91c52018-09-01 21:53:57 -05001646 "vkCreateGraphicsPipelines: The shading rate palette state is static (pCreateInfos[%" PRIu32
Dave Houlton142c4cb2018-10-17 15:04:41 -06001647 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_VIEWPORT_SHADING_RATE_PALETTE_NV), "
1648 "but pCreateInfos[%" PRIu32 "] pShadingRatePalettes (=NULL) is an invalid pointer.",
Jeff Bolz9af91c52018-09-01 21:53:57 -05001649 i, i);
1650 }
1651
Chris Mayer328d8212018-12-11 14:16:18 +01001652 if (vp_swizzle_struct) {
1653 if (vp_swizzle_struct->viewportCount != viewport_state.viewportCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001654 skip |= LogError(device, "VUID-VkPipelineViewportSwizzleStateCreateInfoNV-viewportCount-01215",
1655 "vkCreateGraphicsPipelines: The viewport swizzle state vieport count of %" PRIu32
1656 " does "
1657 "not match the viewport count of %" PRIu32 " in VkPipelineViewportStateCreateInfo.",
1658 vp_swizzle_struct->viewportCount, viewport_state.viewportCount);
Chris Mayer328d8212018-12-11 14:16:18 +01001659 }
1660 }
1661
Petr Krausb3fcdb42018-01-09 22:09:09 +01001662 // validate the VkViewports
1663 if (!has_dynamic_viewport && viewport_state.pViewports) {
1664 for (uint32_t viewport_i = 0; viewport_i < viewport_state.viewportCount; ++viewport_i) {
1665 const auto &viewport = viewport_state.pViewports[viewport_i]; // will crash on invalid ptr
Jeff Bolz6d3beaa2019-02-09 21:00:05 -06001666 const char *fn_name = "vkCreateGraphicsPipelines";
1667 skip |= manual_PreCallValidateViewport(viewport, fn_name,
1668 ParameterName("pCreateInfos[%i].pViewportState->pViewports[%i]",
1669 ParameterName::IndexVector{i, viewport_i}),
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001670 VkCommandBuffer(0));
Petr Krausb3fcdb42018-01-09 22:09:09 +01001671 }
1672 }
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001673
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001674 if (has_dynamic_viewport_w_scaling_nv && !device_extensions.vk_nv_clip_space_w_scaling) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001675 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
1676 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1677 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_VIEWPORT_W_SCALING_NV, but "
1678 "VK_NV_clip_space_w_scaling extension is not enabled.",
1679 i);
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001680 }
1681
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001682 if (has_dynamic_discard_rectangle_ext && !device_extensions.vk_ext_discard_rectangles) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001683 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
1684 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1685 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_DISCARD_RECTANGLE_EXT, but "
1686 "VK_EXT_discard_rectangles extension is not enabled.",
1687 i);
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001688 }
1689
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001690 if (has_dynamic_sample_locations_ext && !device_extensions.vk_ext_sample_locations) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001691 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
1692 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1693 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_SAMPLE_LOCATIONS_EXT, but "
1694 "VK_EXT_sample_locations extension is not enabled.",
1695 i);
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001696 }
Jeff Bolz3e71f782018-08-29 23:15:45 -05001697
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001698 if (has_dynamic_exclusive_scissor_nv && !device_extensions.vk_nv_scissor_exclusive) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001699 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
1700 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1701 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV, but "
1702 "VK_NV_scissor_exclusive extension is not enabled.",
1703 i);
Jeff Bolz3e71f782018-08-29 23:15:45 -05001704 }
Jeff Bolz9af91c52018-09-01 21:53:57 -05001705
1706 if (coarse_sample_order_struct &&
1707 coarse_sample_order_struct->sampleOrderType != VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV &&
1708 coarse_sample_order_struct->customSampleOrderCount != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001709 skip |= LogError(device, "VUID-VkPipelineViewportCoarseSampleOrderStateCreateInfoNV-sampleOrderType-02072",
1710 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1711 "] "
1712 "VkPipelineViewportCoarseSampleOrderStateCreateInfoNV sampleOrderType is not "
1713 "VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV and customSampleOrderCount is not 0.",
1714 i);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001715 }
1716
1717 if (coarse_sample_order_struct) {
1718 for (uint32_t order_i = 0; order_i < coarse_sample_order_struct->customSampleOrderCount; ++order_i) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001719 skip |= ValidateCoarseSampleOrderCustomNV(&coarse_sample_order_struct->pCustomSampleOrders[order_i]);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001720 }
1721 }
Chris Mayer9ded5eb2019-09-19 16:33:26 +02001722
1723 if (vp_w_scaling_struct && (vp_w_scaling_struct->viewportWScalingEnable == VK_TRUE)) {
1724 if (vp_w_scaling_struct->viewportCount != viewport_state.viewportCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001725 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-viewportWScalingEnable-01726",
1726 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1727 "] "
1728 "VkPipelineViewportWScalingStateCreateInfoNV.viewportCount (=%" PRIu32
1729 ") "
1730 "is not equal to VkPipelineViewportStateCreateInfo.viewportCount (=%" PRIu32 ").",
1731 i, vp_w_scaling_struct->viewportCount, viewport_state.viewportCount);
Chris Mayer9ded5eb2019-09-19 16:33:26 +02001732 }
1733 if (!has_dynamic_viewport_w_scaling_nv && !vp_w_scaling_struct->pViewportWScalings) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001734 skip |= LogError(
1735 device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-01715",
Chris Mayer9ded5eb2019-09-19 16:33:26 +02001736 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1737 "] "
1738 "VkPipelineViewportWScalingStateCreateInfoNV.pViewportWScalings (=NULL) is not a valid array.",
1739 i);
1740 }
1741 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001742 }
1743
1744 if (pCreateInfos[i].pMultisampleState == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001745 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-rasterizerDiscardEnable-00751",
1746 "vkCreateGraphicsPipelines: if pCreateInfos[%d].pRasterizationState->rasterizerDiscardEnable "
1747 "is VK_FALSE, pCreateInfos[%d].pMultisampleState must not be NULL.",
1748 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001749 } else {
Dave Houltonb3bbec72018-01-17 10:13:33 -07001750 const VkStructureType valid_next_stypes[] = {LvlTypeMap<VkPipelineCoverageModulationStateCreateInfoNV>::kSType,
1751 LvlTypeMap<VkPipelineCoverageToColorStateCreateInfoNV>::kSType,
1752 LvlTypeMap<VkPipelineSampleLocationsStateCreateInfoEXT>::kSType};
Mike Schuchardt97662b02017-12-06 13:31:29 -07001753 const char *valid_struct_names =
Dave Houltona9df0ce2018-02-07 10:51:23 -07001754 "VkPipelineCoverageModulationStateCreateInfoNV, VkPipelineCoverageToColorStateCreateInfoNV, "
John Zulauf96b0e422017-11-14 11:43:19 -07001755 "VkPipelineSampleLocationsStateCreateInfoEXT";
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001756 skip |= validate_struct_pnext(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001757 "vkCreateGraphicsPipelines",
John Zulauf96b0e422017-11-14 11:43:19 -07001758 ParameterName("pCreateInfos[%i].pMultisampleState->pNext", ParameterName::IndexVector{i}),
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07001759 valid_struct_names, pCreateInfos[i].pMultisampleState->pNext, 3, valid_next_stypes,
sfricke-samsung32a27362020-02-28 09:06:42 -08001760 GeneratedVulkanHeaderVersion, "VUID-VkPipelineMultisampleStateCreateInfo-pNext-pNext",
1761 "VUID-VkPipelineMultisampleStateCreateInfo-sType-unique");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001762
1763 skip |= validate_reserved_flags(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001764 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001765 ParameterName("pCreateInfos[%i].pMultisampleState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06001766 pCreateInfos[i].pMultisampleState->flags, "VUID-VkPipelineMultisampleStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001767
1768 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001769 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001770 ParameterName("pCreateInfos[%i].pMultisampleState->sampleShadingEnable", ParameterName::IndexVector{i}),
1771 pCreateInfos[i].pMultisampleState->sampleShadingEnable);
1772
1773 skip |= validate_array(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001774 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001775 ParameterName("pCreateInfos[%i].pMultisampleState->rasterizationSamples", ParameterName::IndexVector{i}),
1776 ParameterName("pCreateInfos[%i].pMultisampleState->pSampleMask", ParameterName::IndexVector{i}),
Gabríel Arthúr Pétursson092b29b2018-03-21 22:44:11 +00001777 pCreateInfos[i].pMultisampleState->rasterizationSamples, &pCreateInfos[i].pMultisampleState->pSampleMask,
Dave Houlton413a6782018-05-22 13:01:54 -06001778 true, false, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001779
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001780 skip |= validate_flags(
1781 "vkCreateGraphicsPipelines",
1782 ParameterName("pCreateInfos[%i].pMultisampleState->rasterizationSamples", ParameterName::IndexVector{i}),
1783 "VkSampleCountFlagBits", AllVkSampleCountFlagBits, pCreateInfos[i].pMultisampleState->rasterizationSamples,
Petr Kraus52758be2019-08-12 00:53:58 +02001784 kRequiredSingleBit, "VUID-VkPipelineMultisampleStateCreateInfo-rasterizationSamples-parameter");
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001785
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001786 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001787 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001788 ParameterName("pCreateInfos[%i].pMultisampleState->alphaToCoverageEnable", ParameterName::IndexVector{i}),
1789 pCreateInfos[i].pMultisampleState->alphaToCoverageEnable);
1790
1791 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001792 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001793 ParameterName("pCreateInfos[%i].pMultisampleState->alphaToOneEnable", ParameterName::IndexVector{i}),
1794 pCreateInfos[i].pMultisampleState->alphaToOneEnable);
1795
1796 if (pCreateInfos[i].pMultisampleState->sType != VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001797 skip |= LogError(device, kVUID_PVError_InvalidStructSType,
1798 "vkCreateGraphicsPipelines: parameter pCreateInfos[%d].pMultisampleState->sType must be "
1799 "VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO",
1800 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001801 }
John Zulauf7acac592017-11-06 11:15:53 -07001802 if (pCreateInfos[i].pMultisampleState->sampleShadingEnable == VK_TRUE) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001803 if (!physical_device_features.sampleRateShading) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001804 skip |= LogError(device, "VUID-VkPipelineMultisampleStateCreateInfo-sampleShadingEnable-00784",
1805 "vkCreateGraphicsPipelines(): parameter "
1806 "pCreateInfos[%d].pMultisampleState->sampleShadingEnable.",
1807 i);
John Zulauf7acac592017-11-06 11:15:53 -07001808 }
1809 // TODO Add documentation issue about when minSampleShading must be in range and when it is ignored
1810 // For now a "least noise" test *only* when sampleShadingEnable is VK_TRUE.
1811 if (!in_inclusive_range(pCreateInfos[i].pMultisampleState->minSampleShading, 0.F, 1.0F)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001812 skip |= LogError(
1813 device,
1814
Dave Houlton413a6782018-05-22 13:01:54 -06001815 "VUID-VkPipelineMultisampleStateCreateInfo-minSampleShading-00786",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001816 "vkCreateGraphicsPipelines(): parameter pCreateInfos[%d].pMultisampleState->minSampleShading.", i);
John Zulauf7acac592017-11-06 11:15:53 -07001817 }
1818 }
Jeff Bolz8125a8b2019-08-16 16:29:45 -05001819
1820 const auto *line_state = lvl_find_in_chain<VkPipelineRasterizationLineStateCreateInfoEXT>(
1821 pCreateInfos[i].pRasterizationState->pNext);
1822
1823 if (line_state) {
1824 if ((line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_BRESENHAM_EXT ||
1825 line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_RECTANGULAR_SMOOTH_EXT)) {
1826 if (pCreateInfos[i].pMultisampleState->alphaToCoverageEnable) {
1827 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001828 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-lineRasterizationMode-02766",
1829 "vkCreateGraphicsPipelines(): Bresenham/Smooth line rasterization not supported with "
1830 "pCreateInfos[%d].pMultisampleState->alphaToCoverageEnable == VK_TRUE.",
1831 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05001832 }
1833 if (pCreateInfos[i].pMultisampleState->alphaToOneEnable) {
1834 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001835 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-lineRasterizationMode-02766",
1836 "vkCreateGraphicsPipelines(): Bresenham/Smooth line rasterization not supported with "
1837 "pCreateInfos[%d].pMultisampleState->alphaToOneEnable == VK_TRUE.",
1838 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05001839 }
1840 if (pCreateInfos[i].pMultisampleState->sampleShadingEnable) {
1841 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001842 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-lineRasterizationMode-02766",
1843 "vkCreateGraphicsPipelines(): Bresenham/Smooth line rasterization not supported with "
1844 "pCreateInfos[%d].pMultisampleState->sampleShadingEnable == VK_TRUE.",
1845 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05001846 }
1847 }
1848 if (line_state->stippledLineEnable && !has_dynamic_line_stipple) {
1849 if (line_state->lineStippleFactor < 1 || line_state->lineStippleFactor > 256) {
1850 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001851 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-stippledLineEnable-02767",
1852 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineStippleFactor = %d must be in the "
1853 "range [1,256].",
1854 i, line_state->lineStippleFactor);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05001855 }
1856 }
1857 const auto *line_features =
Tony-LunarG6c3c5452019-12-13 10:37:38 -07001858 lvl_find_in_chain<VkPhysicalDeviceLineRasterizationFeaturesEXT>(device_createinfo_pnext);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05001859 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_RECTANGULAR_EXT &&
1860 (!line_features || !line_features->rectangularLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001861 skip |=
1862 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-lineRasterizationMode-02768",
1863 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineRasterizationMode = "
1864 "VK_LINE_RASTERIZATION_MODE_RECTANGULAR_EXT requires the rectangularLines feature.",
1865 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05001866 }
1867 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_BRESENHAM_EXT &&
1868 (!line_features || !line_features->bresenhamLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001869 skip |=
1870 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-lineRasterizationMode-02769",
1871 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineRasterizationMode = "
1872 "VK_LINE_RASTERIZATION_MODE_BRESENHAM_EXT requires the bresenhamLines feature.",
1873 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05001874 }
1875 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_RECTANGULAR_SMOOTH_EXT &&
1876 (!line_features || !line_features->smoothLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001877 skip |=
1878 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-lineRasterizationMode-02770",
1879 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineRasterizationMode = "
1880 "VK_LINE_RASTERIZATION_MODE_RECTANGULAR_SMOOTH_EXT requires the smoothLines feature.",
1881 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05001882 }
1883 if (line_state->stippledLineEnable) {
1884 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_RECTANGULAR_EXT &&
1885 (!line_features || !line_features->stippledRectangularLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001886 skip |=
1887 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-stippledLineEnable-02771",
1888 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineRasterizationMode = "
1889 "VK_LINE_RASTERIZATION_MODE_RECTANGULAR_EXT with stipple requires the "
1890 "stippledRectangularLines feature.",
1891 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05001892 }
1893 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_BRESENHAM_EXT &&
1894 (!line_features || !line_features->stippledBresenhamLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001895 skip |=
1896 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-stippledLineEnable-02772",
1897 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineRasterizationMode = "
1898 "VK_LINE_RASTERIZATION_MODE_BRESENHAM_EXT with stipple requires the "
1899 "stippledBresenhamLines feature.",
1900 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05001901 }
1902 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_RECTANGULAR_SMOOTH_EXT &&
1903 (!line_features || !line_features->stippledSmoothLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001904 skip |=
1905 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-stippledLineEnable-02773",
1906 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineRasterizationMode = "
1907 "VK_LINE_RASTERIZATION_MODE_RECTANGULAR_SMOOTH_EXT with stipple requires the "
1908 "stippledSmoothLines feature.",
1909 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05001910 }
1911 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_DEFAULT_EXT &&
1912 (!line_features || !line_features->stippledSmoothLines || !device_limits.strictLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001913 skip |=
1914 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-stippledLineEnable-02774",
1915 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineRasterizationMode = "
1916 "VK_LINE_RASTERIZATION_MODE_DEFAULT_EXT with stipple requires the "
1917 "stippledRectangularLines and strictLines features.",
1918 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05001919 }
1920 }
1921 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001922 }
1923
Petr Krause91f7a12017-12-14 20:57:36 +01001924 bool uses_color_attachment = false;
1925 bool uses_depthstencil_attachment = false;
1926 {
Mark Lobodzinskif27a6bc2019-02-04 13:00:49 -07001927 std::unique_lock<std::mutex> lock(renderpass_map_mutex);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001928 const auto subpasses_uses_it = renderpasses_states.find(pCreateInfos[i].renderPass);
1929 if (subpasses_uses_it != renderpasses_states.end()) {
Petr Krause91f7a12017-12-14 20:57:36 +01001930 const auto &subpasses_uses = subpasses_uses_it->second;
1931 if (subpasses_uses.subpasses_using_color_attachment.count(pCreateInfos[i].subpass))
1932 uses_color_attachment = true;
1933 if (subpasses_uses.subpasses_using_depthstencil_attachment.count(pCreateInfos[i].subpass))
1934 uses_depthstencil_attachment = true;
1935 }
Mark Lobodzinskif27a6bc2019-02-04 13:00:49 -07001936 lock.unlock();
Petr Krause91f7a12017-12-14 20:57:36 +01001937 }
1938
1939 if (pCreateInfos[i].pDepthStencilState != nullptr && uses_depthstencil_attachment) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001940 skip |= validate_struct_pnext(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001941 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001942 ParameterName("pCreateInfos[%i].pDepthStencilState->pNext", ParameterName::IndexVector{i}), NULL,
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001943 pCreateInfos[i].pDepthStencilState->pNext, 0, NULL, GeneratedVulkanHeaderVersion,
sfricke-samsung32a27362020-02-28 09:06:42 -08001944 "VUID-VkPipelineDepthStencilStateCreateInfo-pNext-pNext", nullptr);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001945
1946 skip |= validate_reserved_flags(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001947 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001948 ParameterName("pCreateInfos[%i].pDepthStencilState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06001949 pCreateInfos[i].pDepthStencilState->flags, "VUID-VkPipelineDepthStencilStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001950
1951 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001952 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001953 ParameterName("pCreateInfos[%i].pDepthStencilState->depthTestEnable", ParameterName::IndexVector{i}),
1954 pCreateInfos[i].pDepthStencilState->depthTestEnable);
1955
1956 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001957 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001958 ParameterName("pCreateInfos[%i].pDepthStencilState->depthWriteEnable", ParameterName::IndexVector{i}),
1959 pCreateInfos[i].pDepthStencilState->depthWriteEnable);
1960
1961 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001962 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001963 ParameterName("pCreateInfos[%i].pDepthStencilState->depthCompareOp", ParameterName::IndexVector{i}),
1964 "VkCompareOp", AllVkCompareOpEnums, pCreateInfos[i].pDepthStencilState->depthCompareOp,
Dave Houlton413a6782018-05-22 13:01:54 -06001965 "VUID-VkPipelineDepthStencilStateCreateInfo-depthCompareOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001966
1967 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001968 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001969 ParameterName("pCreateInfos[%i].pDepthStencilState->depthBoundsTestEnable", ParameterName::IndexVector{i}),
1970 pCreateInfos[i].pDepthStencilState->depthBoundsTestEnable);
1971
1972 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001973 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001974 ParameterName("pCreateInfos[%i].pDepthStencilState->stencilTestEnable", ParameterName::IndexVector{i}),
1975 pCreateInfos[i].pDepthStencilState->stencilTestEnable);
1976
1977 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001978 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001979 ParameterName("pCreateInfos[%i].pDepthStencilState->front.failOp", ParameterName::IndexVector{i}),
1980 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->front.failOp,
Dave Houlton413a6782018-05-22 13:01:54 -06001981 "VUID-VkStencilOpState-failOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001982
1983 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001984 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001985 ParameterName("pCreateInfos[%i].pDepthStencilState->front.passOp", ParameterName::IndexVector{i}),
1986 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->front.passOp,
Dave Houlton413a6782018-05-22 13:01:54 -06001987 "VUID-VkStencilOpState-passOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001988
1989 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001990 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001991 ParameterName("pCreateInfos[%i].pDepthStencilState->front.depthFailOp", ParameterName::IndexVector{i}),
1992 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->front.depthFailOp,
Dave Houlton413a6782018-05-22 13:01:54 -06001993 "VUID-VkStencilOpState-depthFailOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001994
1995 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001996 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001997 ParameterName("pCreateInfos[%i].pDepthStencilState->front.compareOp", ParameterName::IndexVector{i}),
1998 "VkCompareOp", AllVkCompareOpEnums, pCreateInfos[i].pDepthStencilState->front.compareOp,
Dave Houlton413a6782018-05-22 13:01:54 -06001999 "VUID-VkPipelineDepthStencilStateCreateInfo-depthCompareOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002000
2001 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002002 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002003 ParameterName("pCreateInfos[%i].pDepthStencilState->back.failOp", ParameterName::IndexVector{i}),
2004 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->back.failOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002005 "VUID-VkStencilOpState-failOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002006
2007 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002008 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002009 ParameterName("pCreateInfos[%i].pDepthStencilState->back.passOp", ParameterName::IndexVector{i}),
2010 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->back.passOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002011 "VUID-VkStencilOpState-passOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002012
2013 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002014 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002015 ParameterName("pCreateInfos[%i].pDepthStencilState->back.depthFailOp", ParameterName::IndexVector{i}),
2016 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->back.depthFailOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002017 "VUID-VkStencilOpState-depthFailOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002018
2019 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002020 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002021 ParameterName("pCreateInfos[%i].pDepthStencilState->back.compareOp", ParameterName::IndexVector{i}),
2022 "VkCompareOp", AllVkCompareOpEnums, pCreateInfos[i].pDepthStencilState->back.compareOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002023 "VUID-VkPipelineDepthStencilStateCreateInfo-depthCompareOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002024
2025 if (pCreateInfos[i].pDepthStencilState->sType != VK_STRUCTURE_TYPE_PIPELINE_DEPTH_STENCIL_STATE_CREATE_INFO) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002026 skip |= LogError(device, kVUID_PVError_InvalidStructSType,
2027 "vkCreateGraphicsPipelines: parameter pCreateInfos[%d].pDepthStencilState->sType must be "
2028 "VK_STRUCTURE_TYPE_PIPELINE_DEPTH_STENCIL_STATE_CREATE_INFO",
2029 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002030 }
2031 }
2032
Shannon McPherson9b9532b2018-10-24 12:00:09 -06002033 const VkStructureType allowed_structs_VkPipelineColorBlendStateCreateInfo[] = {
2034 VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_ADVANCED_STATE_CREATE_INFO_EXT};
2035
Petr Krause91f7a12017-12-14 20:57:36 +01002036 if (pCreateInfos[i].pColorBlendState != nullptr && uses_color_attachment) {
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002037 skip |= validate_struct_type("vkCreateGraphicsPipelines",
2038 ParameterName("pCreateInfos[%i].pColorBlendState", ParameterName::IndexVector{i}),
2039 "VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO",
2040 pCreateInfos[i].pColorBlendState,
2041 VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO, false, kVUIDUndefined,
2042 "VUID-VkPipelineColorBlendStateCreateInfo-sType-sType");
2043
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002044 skip |= validate_struct_pnext(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002045 "vkCreateGraphicsPipelines",
Shannon McPherson9b9532b2018-10-24 12:00:09 -06002046 ParameterName("pCreateInfos[%i].pColorBlendState->pNext", ParameterName::IndexVector{i}),
2047 "VkPipelineColorBlendAdvancedStateCreateInfoEXT", pCreateInfos[i].pColorBlendState->pNext,
2048 ARRAY_SIZE(allowed_structs_VkPipelineColorBlendStateCreateInfo),
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002049 allowed_structs_VkPipelineColorBlendStateCreateInfo, GeneratedVulkanHeaderVersion,
sfricke-samsung32a27362020-02-28 09:06:42 -08002050 "VUID-VkPipelineColorBlendStateCreateInfo-pNext-pNext",
2051 "VUID-VkPipelineColorBlendStateCreateInfo-sType-unique");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002052
2053 skip |= validate_reserved_flags(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002054 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002055 ParameterName("pCreateInfos[%i].pColorBlendState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06002056 pCreateInfos[i].pColorBlendState->flags, "VUID-VkPipelineColorBlendStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002057
2058 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002059 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002060 ParameterName("pCreateInfos[%i].pColorBlendState->logicOpEnable", ParameterName::IndexVector{i}),
2061 pCreateInfos[i].pColorBlendState->logicOpEnable);
2062
2063 skip |= validate_array(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002064 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002065 ParameterName("pCreateInfos[%i].pColorBlendState->attachmentCount", ParameterName::IndexVector{i}),
2066 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments", ParameterName::IndexVector{i}),
Gabríel Arthúr Pétursson092b29b2018-03-21 22:44:11 +00002067 pCreateInfos[i].pColorBlendState->attachmentCount, &pCreateInfos[i].pColorBlendState->pAttachments, false,
Dave Houlton413a6782018-05-22 13:01:54 -06002068 true, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002069
2070 if (pCreateInfos[i].pColorBlendState->pAttachments != NULL) {
2071 for (uint32_t attachmentIndex = 0; attachmentIndex < pCreateInfos[i].pColorBlendState->attachmentCount;
2072 ++attachmentIndex) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002073 skip |= validate_bool32("vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002074 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].blendEnable",
2075 ParameterName::IndexVector{i, attachmentIndex}),
2076 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].blendEnable);
2077
2078 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002079 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002080 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].srcColorBlendFactor",
2081 ParameterName::IndexVector{i, attachmentIndex}),
2082 "VkBlendFactor", AllVkBlendFactorEnums,
2083 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].srcColorBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06002084 "VUID-VkPipelineColorBlendAttachmentState-srcColorBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002085
2086 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002087 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002088 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].dstColorBlendFactor",
2089 ParameterName::IndexVector{i, attachmentIndex}),
2090 "VkBlendFactor", AllVkBlendFactorEnums,
2091 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].dstColorBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06002092 "VUID-VkPipelineColorBlendAttachmentState-dstColorBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002093
2094 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002095 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002096 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].colorBlendOp",
2097 ParameterName::IndexVector{i, attachmentIndex}),
2098 "VkBlendOp", AllVkBlendOpEnums,
2099 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].colorBlendOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002100 "VUID-VkPipelineColorBlendAttachmentState-colorBlendOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002101
2102 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002103 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002104 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].srcAlphaBlendFactor",
2105 ParameterName::IndexVector{i, attachmentIndex}),
2106 "VkBlendFactor", AllVkBlendFactorEnums,
2107 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].srcAlphaBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06002108 "VUID-VkPipelineColorBlendAttachmentState-srcAlphaBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002109
2110 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002111 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002112 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].dstAlphaBlendFactor",
2113 ParameterName::IndexVector{i, attachmentIndex}),
2114 "VkBlendFactor", AllVkBlendFactorEnums,
2115 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].dstAlphaBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06002116 "VUID-VkPipelineColorBlendAttachmentState-dstAlphaBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002117
2118 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002119 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002120 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].alphaBlendOp",
2121 ParameterName::IndexVector{i, attachmentIndex}),
2122 "VkBlendOp", AllVkBlendOpEnums,
2123 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].alphaBlendOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002124 "VUID-VkPipelineColorBlendAttachmentState-alphaBlendOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002125
2126 skip |=
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002127 validate_flags("vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002128 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].colorWriteMask",
2129 ParameterName::IndexVector{i, attachmentIndex}),
2130 "VkColorComponentFlagBits", AllVkColorComponentFlagBits,
2131 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].colorWriteMask,
Petr Kraus52758be2019-08-12 00:53:58 +02002132 kOptionalFlags, "VUID-VkPipelineColorBlendAttachmentState-colorWriteMask-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002133 }
2134 }
2135
2136 if (pCreateInfos[i].pColorBlendState->sType != VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002137 skip |= LogError(device, kVUID_PVError_InvalidStructSType,
2138 "vkCreateGraphicsPipelines: parameter pCreateInfos[%d].pColorBlendState->sType must be "
2139 "VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO",
2140 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002141 }
2142
2143 // If logicOpEnable is VK_TRUE, logicOp must be a valid VkLogicOp value
2144 if (pCreateInfos[i].pColorBlendState->logicOpEnable == VK_TRUE) {
2145 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002146 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002147 ParameterName("pCreateInfos[%i].pColorBlendState->logicOp", ParameterName::IndexVector{i}), "VkLogicOp",
Dave Houlton413a6782018-05-22 13:01:54 -06002148 AllVkLogicOpEnums, pCreateInfos[i].pColorBlendState->logicOp,
2149 "VUID-VkPipelineColorBlendStateCreateInfo-logicOpEnable-00607");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002150 }
2151 }
2152 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002153
Petr Kraus9752aae2017-11-24 03:05:50 +01002154 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_DERIVATIVE_BIT) {
2155 if (pCreateInfos[i].basePipelineIndex != -1) {
2156 if (pCreateInfos[i].basePipelineHandle != VK_NULL_HANDLE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002157 skip |=
2158 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-00724",
2159 "vkCreateGraphicsPipelines parameter, pCreateInfos->basePipelineHandle, must be "
2160 "VK_NULL_HANDLE if pCreateInfos->flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT flag "
2161 "and pCreateInfos->basePipelineIndex is not -1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002162 }
2163 }
2164
Petr Kraus9752aae2017-11-24 03:05:50 +01002165 if (pCreateInfos[i].basePipelineHandle != VK_NULL_HANDLE) {
2166 if (pCreateInfos[i].basePipelineIndex != -1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002167 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-00725",
2168 "vkCreateGraphicsPipelines parameter, pCreateInfos->basePipelineIndex, must be -1 if "
2169 "pCreateInfos->flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT flag and "
2170 "pCreateInfos->basePipelineHandle is not VK_NULL_HANDLE.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002171 }
Mark Lobodzinski4dfeb942019-09-13 12:11:13 -06002172 } else {
2173 if (static_cast<const uint32_t>(pCreateInfos[i].basePipelineIndex) >= createInfoCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002174 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-00723",
2175 "vkCreateGraphicsPipelines parameter pCreateInfos->basePipelineIndex (%d) must be a valid"
2176 "index into the pCreateInfos array, of size %d.",
2177 pCreateInfos[i].basePipelineIndex, createInfoCount);
Mark Lobodzinski4dfeb942019-09-13 12:11:13 -06002178 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002179 }
2180 }
2181
Petr Kraus9752aae2017-11-24 03:05:50 +01002182 if (pCreateInfos[i].pRasterizationState) {
Chris Mayer840b2c42019-08-22 18:12:22 +02002183 if (!device_extensions.vk_nv_fill_rectangle) {
2184 if (pCreateInfos[i].pRasterizationState->polygonMode == VK_POLYGON_MODE_FILL_RECTANGLE_NV) {
2185 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002186 LogError(device, "VUID-VkPipelineRasterizationStateCreateInfo-polygonMode-01414",
2187 "vkCreateGraphicsPipelines parameter, VkPolygonMode "
2188 "pCreateInfos->pRasterizationState->polygonMode cannot be VK_POLYGON_MODE_FILL_RECTANGLE_NV "
2189 "if the extension VK_NV_fill_rectangle is not enabled.");
Chris Mayer840b2c42019-08-22 18:12:22 +02002190 } else if ((pCreateInfos[i].pRasterizationState->polygonMode != VK_POLYGON_MODE_FILL) &&
2191 (physical_device_features.fillModeNonSolid == false)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002192 skip |= LogError(device, kVUID_PVError_DeviceFeature,
2193 "vkCreateGraphicsPipelines parameter, VkPolygonMode "
2194 "pCreateInfos->pRasterizationState->polygonMode cannot be VK_POLYGON_MODE_POINT or "
2195 "VK_POLYGON_MODE_LINE if VkPhysicalDeviceFeatures->fillModeNonSolid is false.");
Chris Mayer840b2c42019-08-22 18:12:22 +02002196 }
2197 } else {
2198 if ((pCreateInfos[i].pRasterizationState->polygonMode != VK_POLYGON_MODE_FILL) &&
2199 (pCreateInfos[i].pRasterizationState->polygonMode != VK_POLYGON_MODE_FILL_RECTANGLE_NV) &&
2200 (physical_device_features.fillModeNonSolid == false)) {
2201 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002202 LogError(device, "VUID-VkPipelineRasterizationStateCreateInfo-polygonMode-01507",
2203 "vkCreateGraphicsPipelines parameter, VkPolygonMode "
2204 "pCreateInfos->pRasterizationState->polygonMode must be VK_POLYGON_MODE_FILL or "
2205 "VK_POLYGON_MODE_FILL_RECTANGLE_NV if VkPhysicalDeviceFeatures->fillModeNonSolid is false.");
Chris Mayer840b2c42019-08-22 18:12:22 +02002206 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002207 }
Petr Kraus299ba622017-11-24 03:09:03 +01002208
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002209 if (!has_dynamic_line_width && !physical_device_features.wideLines &&
Petr Kraus299ba622017-11-24 03:09:03 +01002210 (pCreateInfos[i].pRasterizationState->lineWidth != 1.0f)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002211 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-00749",
2212 "The line width state is static (pCreateInfos[%" PRIu32
2213 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_LINE_WIDTH) and "
2214 "VkPhysicalDeviceFeatures::wideLines is disabled, but pCreateInfos[%" PRIu32
2215 "].pRasterizationState->lineWidth (=%f) is not 1.0.",
2216 i, i, pCreateInfos[i].pRasterizationState->lineWidth);
Petr Kraus299ba622017-11-24 03:09:03 +01002217 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002218 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002219 }
2220 }
2221
2222 return skip;
2223}
2224
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002225bool StatelessValidation::manual_PreCallValidateCreateComputePipelines(VkDevice device, VkPipelineCache pipelineCache,
2226 uint32_t createInfoCount,
2227 const VkComputePipelineCreateInfo *pCreateInfos,
2228 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05002229 VkPipeline *pPipelines) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002230 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002231 for (uint32_t i = 0; i < createInfoCount; i++) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002232 skip |= validate_string("vkCreateComputePipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002233 ParameterName("pCreateInfos[%i].stage.pName", ParameterName::IndexVector{i}),
Mark Lobodzinskiebee3552018-05-29 09:55:54 -06002234 "VUID-VkPipelineShaderStageCreateInfo-pName-parameter", pCreateInfos[i].stage.pName);
Peter Chen85366392019-05-14 15:20:11 -04002235 auto feedback_struct = lvl_find_in_chain<VkPipelineCreationFeedbackCreateInfoEXT>(pCreateInfos[i].pNext);
2236 if ((feedback_struct != nullptr) && (feedback_struct->pipelineStageCreationFeedbackCount != 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002237 skip |=
2238 LogError(device, "VUID-VkPipelineCreationFeedbackCreateInfoEXT-pipelineStageCreationFeedbackCount-02669",
2239 "vkCreateComputePipelines(): in pCreateInfo[%" PRIu32
2240 "], VkPipelineCreationFeedbackEXT::pipelineStageCreationFeedbackCount must equal 1, found %" PRIu32 ".",
2241 i, feedback_struct->pipelineStageCreationFeedbackCount);
Peter Chen85366392019-05-14 15:20:11 -04002242 }
sfricke-samsungc5227152020-02-09 17:36:31 -08002243
2244 // Make sure compute stage is selected
2245 if (pCreateInfos[i].stage.stage != VK_SHADER_STAGE_COMPUTE_BIT) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002246 skip |= LogError(device, "VUID-VkComputePipelineCreateInfo-stage-00701",
2247 "vkCreateComputePipelines(): the pCreateInfo[%u].stage.stage (%s) is not VK_SHADER_STAGE_COMPUTE_BIT",
2248 i, string_VkShaderStageFlagBits(pCreateInfos[i].stage.stage));
sfricke-samsungc5227152020-02-09 17:36:31 -08002249 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002250 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002251 return skip;
2252}
2253
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002254bool StatelessValidation::manual_PreCallValidateCreateSampler(VkDevice device, const VkSamplerCreateInfo *pCreateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -05002255 const VkAllocationCallbacks *pAllocator, VkSampler *pSampler) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002256 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002257
2258 if (pCreateInfo != nullptr) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002259 const auto &features = physical_device_features;
2260 const auto &limits = device_limits;
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002261
John Zulauf71968502017-10-26 13:51:15 -06002262 if (pCreateInfo->anisotropyEnable == VK_TRUE) {
2263 if (!in_inclusive_range(pCreateInfo->maxAnisotropy, 1.0F, limits.maxSamplerAnisotropy)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002264 skip |= LogError(device, "VUID-VkSamplerCreateInfo-anisotropyEnable-01071",
2265 "vkCreateSampler(): value of %s must be in range [1.0, %f] %s, but %f found.",
2266 "pCreateInfo->maxAnisotropy", limits.maxSamplerAnisotropy,
2267 "VkPhysicalDeviceLimits::maxSamplerAnistropy", pCreateInfo->maxAnisotropy);
John Zulauf71968502017-10-26 13:51:15 -06002268 }
2269
2270 // Anistropy cannot be enabled in sampler unless enabled as a feature
2271 if (features.samplerAnisotropy == VK_FALSE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002272 skip |= LogError(device, "VUID-VkSamplerCreateInfo-anisotropyEnable-01070",
2273 "vkCreateSampler(): Anisotropic sampling feature is not enabled, %s must be VK_FALSE.",
2274 "pCreateInfo->anisotropyEnable");
John Zulauf71968502017-10-26 13:51:15 -06002275 }
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002276 }
John Zulauf71968502017-10-26 13:51:15 -06002277
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002278 if (pCreateInfo->unnormalizedCoordinates == VK_TRUE) {
2279 if (pCreateInfo->minFilter != pCreateInfo->magFilter) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002280 skip |= LogError(device, "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01072",
2281 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
2282 "pCreateInfo->minFilter (%s) and pCreateInfo->magFilter (%s) must be equal.",
2283 string_VkFilter(pCreateInfo->minFilter), string_VkFilter(pCreateInfo->magFilter));
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002284 }
2285 if (pCreateInfo->mipmapMode != VK_SAMPLER_MIPMAP_MODE_NEAREST) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002286 skip |= LogError(device, "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01073",
2287 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
2288 "pCreateInfo->mipmapMode (%s) must be VK_SAMPLER_MIPMAP_MODE_NEAREST.",
2289 string_VkSamplerMipmapMode(pCreateInfo->mipmapMode));
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002290 }
2291 if (pCreateInfo->minLod != 0.0f || pCreateInfo->maxLod != 0.0f) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002292 skip |= LogError(device, "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01074",
2293 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
2294 "pCreateInfo->minLod (%f) and pCreateInfo->maxLod (%f) must both be zero.",
2295 pCreateInfo->minLod, pCreateInfo->maxLod);
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002296 }
2297 if ((pCreateInfo->addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE &&
2298 pCreateInfo->addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER) ||
2299 (pCreateInfo->addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE &&
2300 pCreateInfo->addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002301 skip |= LogError(device, "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01075",
2302 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
2303 "pCreateInfo->addressModeU (%s) and pCreateInfo->addressModeV (%s) must both be "
2304 "VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE or VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER.",
2305 string_VkSamplerAddressMode(pCreateInfo->addressModeU),
2306 string_VkSamplerAddressMode(pCreateInfo->addressModeV));
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002307 }
2308 if (pCreateInfo->anisotropyEnable == VK_TRUE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002309 skip |= LogError(device, "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01076",
2310 "vkCreateSampler(): pCreateInfo->anisotropyEnable and pCreateInfo->unnormalizedCoordinates must "
2311 "not both be VK_TRUE.");
John Zulauf71968502017-10-26 13:51:15 -06002312 }
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002313 if (pCreateInfo->compareEnable == VK_TRUE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002314 skip |= LogError(device, "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01077",
2315 "vkCreateSampler(): pCreateInfo->compareEnable and pCreateInfo->unnormalizedCoordinates must "
2316 "not both be VK_TRUE.");
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002317 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002318 }
2319
2320 // If compareEnable is VK_TRUE, compareOp must be a valid VkCompareOp value
2321 if (pCreateInfo->compareEnable == VK_TRUE) {
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002322 skip |= validate_ranged_enum("vkCreateSampler", "pCreateInfo->compareOp", "VkCompareOp", AllVkCompareOpEnums,
2323 pCreateInfo->compareOp, "VUID-VkSamplerCreateInfo-compareEnable-01080");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002324 }
2325
2326 // If any of addressModeU, addressModeV or addressModeW are VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER, borderColor must be a
2327 // valid VkBorderColor value
2328 if ((pCreateInfo->addressModeU == VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER) ||
2329 (pCreateInfo->addressModeV == VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER) ||
2330 (pCreateInfo->addressModeW == VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER)) {
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002331 skip |= validate_ranged_enum("vkCreateSampler", "pCreateInfo->borderColor", "VkBorderColor", AllVkBorderColorEnums,
2332 pCreateInfo->borderColor, "VUID-VkSamplerCreateInfo-addressModeU-01078");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002333 }
2334
2335 // If any of addressModeU, addressModeV or addressModeW are VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE, the
2336 // VK_KHR_sampler_mirror_clamp_to_edge extension must be enabled
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002337 if (!device_extensions.vk_khr_sampler_mirror_clamp_to_edge &&
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002338 ((pCreateInfo->addressModeU == VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE) ||
2339 (pCreateInfo->addressModeV == VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE) ||
2340 (pCreateInfo->addressModeW == VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE))) {
Dave Houlton413a6782018-05-22 13:01:54 -06002341 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002342 LogError(device, "VUID-VkSamplerCreateInfo-addressModeU-01079",
2343 "vkCreateSampler(): A VkSamplerAddressMode value is set to VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE "
2344 "but the VK_KHR_sampler_mirror_clamp_to_edge extension has not been enabled.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002345 }
John Zulauf275805c2017-10-26 15:34:49 -06002346
2347 // Checks for the IMG cubic filtering extension
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002348 if (device_extensions.vk_img_filter_cubic) {
John Zulauf275805c2017-10-26 15:34:49 -06002349 if ((pCreateInfo->anisotropyEnable == VK_TRUE) &&
2350 ((pCreateInfo->minFilter == VK_FILTER_CUBIC_IMG) || (pCreateInfo->magFilter == VK_FILTER_CUBIC_IMG))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002351 skip |= LogError(device, "VUID-VkSamplerCreateInfo-magFilter-01081",
2352 "vkCreateSampler(): Anisotropic sampling must not be VK_TRUE when either minFilter or magFilter "
2353 "are VK_FILTER_CUBIC_IMG.");
John Zulauf275805c2017-10-26 15:34:49 -06002354 }
2355 }
Mark Lobodzinski61992fc2020-01-14 14:00:08 -07002356
sfricke-samsungd91da4a2020-02-09 17:19:04 -08002357 // Check for valid Lod range
2358 if (pCreateInfo->minLod > pCreateInfo->maxLod) {
Mark Lobodzinski728ab482020-02-12 13:46:47 -07002359 skip |=
2360 LogError(device, "VUID-VkSamplerCreateInfo-maxLod-01973",
2361 "vkCreateSampler(): minLod (%f) is greater than maxLod (%f)", pCreateInfo->minLod, pCreateInfo->maxLod);
sfricke-samsungd91da4a2020-02-09 17:19:04 -08002362 }
2363
2364 // Check mipLodBias to device limit
2365 if (pCreateInfo->mipLodBias > limits.maxSamplerLodBias) {
Mark Lobodzinski728ab482020-02-12 13:46:47 -07002366 skip |= LogError(device, "VUID-VkSamplerCreateInfo-mipLodBias-01069",
2367 "vkCreateSampler(): mipLodBias (%f) is greater than VkPhysicalDeviceLimits::maxSamplerLodBias (%f)",
2368 pCreateInfo->mipLodBias, limits.maxSamplerLodBias);
sfricke-samsungd91da4a2020-02-09 17:19:04 -08002369 }
2370
Mark Lobodzinski61992fc2020-01-14 14:00:08 -07002371 const auto *sampler_conversion = lvl_find_in_chain<VkSamplerYcbcrConversionInfo>(pCreateInfo->pNext);
2372 if (sampler_conversion != nullptr) {
2373 if ((pCreateInfo->addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE) ||
2374 (pCreateInfo->addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE) ||
2375 (pCreateInfo->addressModeW != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE) ||
2376 (pCreateInfo->anisotropyEnable != VK_FALSE) || (pCreateInfo->unnormalizedCoordinates != VK_FALSE)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002377 skip |= LogError(
Mark Lobodzinski728ab482020-02-12 13:46:47 -07002378 device, "VUID-VkSamplerCreateInfo-addressModeU-01646",
Mark Lobodzinski61992fc2020-01-14 14:00:08 -07002379 "vkCreateSampler(): SamplerYCbCrConversion is enabled: "
2380 "addressModeU (%s), addressModeV (%s), addressModeW (%s) must be CLAMP_TO_EDGE, and anisotropyEnable (%s) "
2381 "and unnormalizedCoordinates (%s) must be VK_FALSE.",
2382 string_VkSamplerAddressMode(pCreateInfo->addressModeU), string_VkSamplerAddressMode(pCreateInfo->addressModeV),
2383 string_VkSamplerAddressMode(pCreateInfo->addressModeW), pCreateInfo->anisotropyEnable ? "VK_TRUE" : "VK_FALSE",
2384 pCreateInfo->unnormalizedCoordinates ? "VK_TRUE" : "VK_FALSE");
2385 }
2386 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002387 }
2388
2389 return skip;
2390}
2391
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002392bool StatelessValidation::manual_PreCallValidateCreateDescriptorSetLayout(VkDevice device,
2393 const VkDescriptorSetLayoutCreateInfo *pCreateInfo,
2394 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05002395 VkDescriptorSetLayout *pSetLayout) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002396 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002397
2398 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
2399 if ((pCreateInfo != nullptr) && (pCreateInfo->pBindings != nullptr)) {
2400 for (uint32_t i = 0; i < pCreateInfo->bindingCount; ++i) {
2401 if (pCreateInfo->pBindings[i].descriptorCount != 0) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002402 if (((pCreateInfo->pBindings[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLER) ||
2403 (pCreateInfo->pBindings[i].descriptorType == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER)) &&
2404 (pCreateInfo->pBindings[i].pImmutableSamplers != nullptr)) {
2405 for (uint32_t descriptor_index = 0; descriptor_index < pCreateInfo->pBindings[i].descriptorCount;
2406 ++descriptor_index) {
2407 if (pCreateInfo->pBindings[i].pImmutableSamplers[descriptor_index] == VK_NULL_HANDLE) {
Spencer Frickeb0e30822020-03-23 10:32:30 -07002408 skip |= LogError(device, "VUID-VkDescriptorSetLayoutBinding-descriptorType-00282",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002409 "vkCreateDescriptorSetLayout: required parameter "
2410 "pCreateInfo->pBindings[%d].pImmutableSamplers[%d] specified as VK_NULL_HANDLE",
2411 i, descriptor_index);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002412 }
2413 }
2414 }
2415
2416 // If descriptorCount is not 0, stageFlags must be a valid combination of VkShaderStageFlagBits values
2417 if ((pCreateInfo->pBindings[i].stageFlags != 0) &&
2418 ((pCreateInfo->pBindings[i].stageFlags & (~AllVkShaderStageFlagBits)) != 0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002419 skip |= LogError(device, "VUID-VkDescriptorSetLayoutBinding-descriptorCount-00283",
2420 "vkCreateDescriptorSetLayout(): if pCreateInfo->pBindings[%d].descriptorCount is not 0, "
2421 "pCreateInfo->pBindings[%d].stageFlags must be a valid combination of VkShaderStageFlagBits "
2422 "values.",
2423 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002424 }
Spencer Fricke84d0cc02020-03-16 17:21:59 -07002425
2426 if ((pCreateInfo->pBindings[i].descriptorType == VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT) &&
2427 (pCreateInfo->pBindings[i].stageFlags != 0) &&
2428 (pCreateInfo->pBindings[i].stageFlags != VK_SHADER_STAGE_FRAGMENT_BIT)) {
2429 skip |=
2430 LogError(device, "VUID-VkDescriptorSetLayoutBinding-descriptorType-01510",
2431 "vkCreateDescriptorSetLayout(): if pCreateInfo->pBindings[%d].descriptorCount is not 0 and "
2432 "descriptorType is VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT then pCreateInfo->pBindings[%d].stageFlags "
2433 "must be 0 or VK_SHADER_STAGE_FRAGMENT_BIT but is currently %s",
2434 i, i, string_VkShaderStageFlags(pCreateInfo->pBindings[i].stageFlags).c_str());
2435 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002436 }
2437 }
2438 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002439 return skip;
2440}
2441
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002442bool StatelessValidation::manual_PreCallValidateFreeDescriptorSets(VkDevice device, VkDescriptorPool descriptorPool,
2443 uint32_t descriptorSetCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05002444 const VkDescriptorSet *pDescriptorSets) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002445 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
2446 // This is an array of handles, where the elements are allowed to be VK_NULL_HANDLE, and does not require any validation beyond
2447 // validate_array()
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002448 return validate_array("vkFreeDescriptorSets", "descriptorSetCount", "pDescriptorSets", descriptorSetCount, &pDescriptorSets,
2449 true, true, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002450}
2451
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07002452bool StatelessValidation::validate_WriteDescriptorSet(const char *vkCallingFunction, const uint32_t descriptorWriteCount,
2453 const VkWriteDescriptorSet *pDescriptorWrites,
2454 const bool validateDstSet) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002455 bool skip = false;
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07002456
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002457 if (pDescriptorWrites != NULL) {
2458 for (uint32_t i = 0; i < descriptorWriteCount; ++i) {
2459 // descriptorCount must be greater than 0
2460 if (pDescriptorWrites[i].descriptorCount == 0) {
2461 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002462 LogError(device, "VUID-VkWriteDescriptorSet-descriptorCount-arraylength",
2463 "%s(): parameter pDescriptorWrites[%d].descriptorCount must be greater than 0.", vkCallingFunction, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002464 }
2465
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07002466 // If called from vkCmdPushDescriptorSetKHR, the dstSet member is ignored.
2467 if (validateDstSet) {
2468 // dstSet must be a valid VkDescriptorSet handle
2469 skip |= validate_required_handle(vkCallingFunction,
2470 ParameterName("pDescriptorWrites[%i].dstSet", ParameterName::IndexVector{i}),
2471 pDescriptorWrites[i].dstSet);
2472 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002473
2474 if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLER) ||
2475 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER) ||
2476 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE) ||
2477 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_IMAGE) ||
2478 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT)) {
2479 // If descriptorType is VK_DESCRIPTOR_TYPE_SAMPLER, VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER,
2480 // VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE, VK_DESCRIPTOR_TYPE_STORAGE_IMAGE or VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT,
2481 // pImageInfo must be a pointer to an array of descriptorCount valid VkDescriptorImageInfo structures
2482 if (pDescriptorWrites[i].pImageInfo == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002483 skip |= LogError(device, "VUID-VkWriteDescriptorSet-descriptorType-00322",
2484 "%s(): if pDescriptorWrites[%d].descriptorType is "
2485 "VK_DESCRIPTOR_TYPE_SAMPLER, VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER, "
2486 "VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE, VK_DESCRIPTOR_TYPE_STORAGE_IMAGE or "
2487 "VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT, pDescriptorWrites[%d].pImageInfo must not be NULL.",
2488 vkCallingFunction, i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002489 } else if (pDescriptorWrites[i].descriptorType != VK_DESCRIPTOR_TYPE_SAMPLER) {
2490 // If descriptorType is VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER, VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE,
2491 // VK_DESCRIPTOR_TYPE_STORAGE_IMAGE or VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT, the imageView and imageLayout
2492 // members of any given element of pImageInfo must be a valid VkImageView and VkImageLayout, respectively
2493 for (uint32_t descriptor_index = 0; descriptor_index < pDescriptorWrites[i].descriptorCount;
2494 ++descriptor_index) {
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07002495 skip |= validate_required_handle(vkCallingFunction,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002496 ParameterName("pDescriptorWrites[%i].pImageInfo[%i].imageView",
2497 ParameterName::IndexVector{i, descriptor_index}),
2498 pDescriptorWrites[i].pImageInfo[descriptor_index].imageView);
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07002499 skip |= validate_ranged_enum(vkCallingFunction,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002500 ParameterName("pDescriptorWrites[%i].pImageInfo[%i].imageLayout",
2501 ParameterName::IndexVector{i, descriptor_index}),
2502 "VkImageLayout", AllVkImageLayoutEnums,
Dave Houlton413a6782018-05-22 13:01:54 -06002503 pDescriptorWrites[i].pImageInfo[descriptor_index].imageLayout, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002504 }
2505 }
2506 } else if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER) ||
2507 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER) ||
2508 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC) ||
2509 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC)) {
2510 // If descriptorType is VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER, VK_DESCRIPTOR_TYPE_STORAGE_BUFFER,
2511 // VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC or VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC, pBufferInfo must be a
2512 // pointer to an array of descriptorCount valid VkDescriptorBufferInfo structures
2513 if (pDescriptorWrites[i].pBufferInfo == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002514 skip |= LogError(device, "VUID-VkWriteDescriptorSet-descriptorType-00324",
2515 "%s(): if pDescriptorWrites[%d].descriptorType is "
2516 "VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER, VK_DESCRIPTOR_TYPE_STORAGE_BUFFER, "
2517 "VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC or VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC, "
2518 "pDescriptorWrites[%d].pBufferInfo must not be NULL.",
2519 vkCallingFunction, i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002520 } else {
2521 for (uint32_t descriptorIndex = 0; descriptorIndex < pDescriptorWrites[i].descriptorCount; ++descriptorIndex) {
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07002522 skip |= validate_required_handle(vkCallingFunction,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002523 ParameterName("pDescriptorWrites[%i].pBufferInfo[%i].buffer",
2524 ParameterName::IndexVector{i, descriptorIndex}),
2525 pDescriptorWrites[i].pBufferInfo[descriptorIndex].buffer);
2526 }
2527 }
2528 } else if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER) ||
2529 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER)) {
2530 // If descriptorType is VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER or VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER,
2531 // pTexelBufferView must be a pointer to an array of descriptorCount valid VkBufferView handles
2532 if (pDescriptorWrites[i].pTexelBufferView == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002533 skip |= LogError(device, "VUID-VkWriteDescriptorSet-descriptorType-00323",
2534 "%s(): if pDescriptorWrites[%d].descriptorType is "
2535 "VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER or VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER, "
2536 "pDescriptorWrites[%d].pTexelBufferView must not be NULL.",
2537 vkCallingFunction, i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002538 } else {
2539 for (uint32_t descriptor_index = 0; descriptor_index < pDescriptorWrites[i].descriptorCount;
2540 ++descriptor_index) {
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07002541 skip |= validate_required_handle(vkCallingFunction,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002542 ParameterName("pDescriptorWrites[%i].pTexelBufferView[%i]",
2543 ParameterName::IndexVector{i, descriptor_index}),
2544 pDescriptorWrites[i].pTexelBufferView[descriptor_index]);
2545 }
2546 }
2547 }
2548
2549 if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER) ||
2550 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC)) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002551 VkDeviceSize uniformAlignment = device_limits.minUniformBufferOffsetAlignment;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002552 for (uint32_t j = 0; j < pDescriptorWrites[i].descriptorCount; j++) {
2553 if (pDescriptorWrites[i].pBufferInfo != NULL) {
2554 if (SafeModulo(pDescriptorWrites[i].pBufferInfo[j].offset, uniformAlignment) != 0) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06002555 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002556 LogError(device, "VUID-VkWriteDescriptorSet-descriptorType-00327",
2557 "%s(): pDescriptorWrites[%d].pBufferInfo[%d].offset (0x%" PRIxLEAST64
2558 ") must be a multiple of device limit minUniformBufferOffsetAlignment 0x%" PRIxLEAST64 ".",
2559 vkCallingFunction, i, j, pDescriptorWrites[i].pBufferInfo[j].offset, uniformAlignment);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002560 }
2561 }
2562 }
2563 } else if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER) ||
2564 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC)) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002565 VkDeviceSize storageAlignment = device_limits.minStorageBufferOffsetAlignment;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002566 for (uint32_t j = 0; j < pDescriptorWrites[i].descriptorCount; j++) {
2567 if (pDescriptorWrites[i].pBufferInfo != NULL) {
2568 if (SafeModulo(pDescriptorWrites[i].pBufferInfo[j].offset, storageAlignment) != 0) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06002569 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002570 LogError(device, "VUID-VkWriteDescriptorSet-descriptorType-00328",
2571 "%s(): pDescriptorWrites[%d].pBufferInfo[%d].offset (0x%" PRIxLEAST64
2572 ") must be a multiple of device limit minStorageBufferOffsetAlignment 0x%" PRIxLEAST64 ".",
2573 vkCallingFunction, i, j, pDescriptorWrites[i].pBufferInfo[j].offset, storageAlignment);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002574 }
2575 }
2576 }
2577 }
2578 }
2579 }
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07002580
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002581 return skip;
2582}
2583
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07002584bool StatelessValidation::manual_PreCallValidateUpdateDescriptorSets(VkDevice device, uint32_t descriptorWriteCount,
2585 const VkWriteDescriptorSet *pDescriptorWrites,
2586 uint32_t descriptorCopyCount,
2587 const VkCopyDescriptorSet *pDescriptorCopies) const {
2588 return validate_WriteDescriptorSet("vkUpdateDescriptorSets", descriptorWriteCount, pDescriptorWrites);
2589}
2590
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002591bool StatelessValidation::manual_PreCallValidateCreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo,
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002592 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05002593 VkRenderPass *pRenderPass) const {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002594 return CreateRenderPassGeneric(device, pCreateInfo, pAllocator, pRenderPass, RENDER_PASS_VERSION_1);
2595}
2596
2597bool StatelessValidation::manual_PreCallValidateCreateRenderPass2KHR(VkDevice device, const VkRenderPassCreateInfo2KHR *pCreateInfo,
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002598 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05002599 VkRenderPass *pRenderPass) const {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002600 return CreateRenderPassGeneric(device, pCreateInfo, pAllocator, pRenderPass, RENDER_PASS_VERSION_2);
2601}
2602
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002603bool StatelessValidation::manual_PreCallValidateFreeCommandBuffers(VkDevice device, VkCommandPool commandPool,
2604 uint32_t commandBufferCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05002605 const VkCommandBuffer *pCommandBuffers) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002606 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002607
2608 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
2609 // This is an array of handles, where the elements are allowed to be VK_NULL_HANDLE, and does not require any validation beyond
2610 // validate_array()
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002611 skip |= validate_array("vkFreeCommandBuffers", "commandBufferCount", "pCommandBuffers", commandBufferCount, &pCommandBuffers,
2612 true, true, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002613 return skip;
2614}
2615
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002616bool StatelessValidation::manual_PreCallValidateBeginCommandBuffer(VkCommandBuffer commandBuffer,
Jeff Bolz5c801d12019-10-09 10:38:45 -05002617 const VkCommandBufferBeginInfo *pBeginInfo) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002618 bool skip = false;
Petr Krause7bb9e82019-08-11 21:34:43 +02002619
2620 // VkCommandBufferInheritanceInfo validation, due to a 'noautovalidity' of pBeginInfo->pInheritanceInfo in vkBeginCommandBuffer
2621 const char *cmd_name = "vkBeginCommandBuffer";
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002622 const VkCommandBufferInheritanceInfo *pInfo = pBeginInfo->pInheritanceInfo;
2623
Petr Krause7bb9e82019-08-11 21:34:43 +02002624 // Implicit VUs
2625 // validate only sType here; pointer has to be validated in core_validation
2626 const bool kNotRequired = false;
2627 const char *kNoVUID = nullptr;
2628 skip |= validate_struct_type(cmd_name, "pBeginInfo->pInheritanceInfo", "VK_STRUCTURE_TYPE_COMMAND_BUFFER_INHERITANCE_INFO",
2629 pInfo, VK_STRUCTURE_TYPE_COMMAND_BUFFER_INHERITANCE_INFO, kNotRequired, kNoVUID,
2630 "VUID-VkCommandBufferInheritanceInfo-sType-sType");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002631
Petr Krause7bb9e82019-08-11 21:34:43 +02002632 if (pInfo) {
2633 const VkStructureType allowed_structs_VkCommandBufferInheritanceInfo[] = {
2634 VK_STRUCTURE_TYPE_COMMAND_BUFFER_INHERITANCE_CONDITIONAL_RENDERING_INFO_EXT};
2635 skip |= validate_struct_pnext(
2636 cmd_name, "pBeginInfo->pInheritanceInfo->pNext", "VkCommandBufferInheritanceConditionalRenderingInfoEXT", pInfo->pNext,
2637 ARRAY_SIZE(allowed_structs_VkCommandBufferInheritanceInfo), allowed_structs_VkCommandBufferInheritanceInfo,
sfricke-samsung32a27362020-02-28 09:06:42 -08002638 GeneratedVulkanHeaderVersion, "VUID-VkCommandBufferInheritanceInfo-pNext-pNext",
2639 "VUID-VkCommandBufferInheritanceInfo-sType-unique");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002640
Petr Krause7bb9e82019-08-11 21:34:43 +02002641 skip |= validate_bool32(cmd_name, "pBeginInfo->pInheritanceInfo->occlusionQueryEnable", pInfo->occlusionQueryEnable);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002642
Petr Krause7bb9e82019-08-11 21:34:43 +02002643 // Explicit VUs
2644 if (!physical_device_features.inheritedQueries && pInfo->occlusionQueryEnable == VK_TRUE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002645 skip |= LogError(
2646 commandBuffer, "VUID-VkCommandBufferInheritanceInfo-occlusionQueryEnable-00056",
Petr Krause7bb9e82019-08-11 21:34:43 +02002647 "%s: Inherited queries feature is disabled, but pBeginInfo->pInheritanceInfo->occlusionQueryEnable is VK_TRUE.",
2648 cmd_name);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002649 }
Petr Krause7bb9e82019-08-11 21:34:43 +02002650
2651 if (physical_device_features.inheritedQueries) {
2652 skip |= validate_flags(cmd_name, "pBeginInfo->pInheritanceInfo->queryFlags", "VkQueryControlFlagBits",
Petr Kraus52758be2019-08-12 00:53:58 +02002653 AllVkQueryControlFlagBits, pInfo->queryFlags, kOptionalFlags,
Dave Houlton413a6782018-05-22 13:01:54 -06002654 "VUID-VkCommandBufferInheritanceInfo-queryFlags-00057");
Petr Krause7bb9e82019-08-11 21:34:43 +02002655 } else { // !inheritedQueries
Petr Krause7bb9e82019-08-11 21:34:43 +02002656 skip |= validate_reserved_flags(cmd_name, "pBeginInfo->pInheritanceInfo->queryFlags", pInfo->queryFlags,
Petr Kraus43aed2c2019-08-18 13:59:16 +02002657 "VUID-VkCommandBufferInheritanceInfo-queryFlags-02788");
Petr Krause7bb9e82019-08-11 21:34:43 +02002658 }
2659
2660 if (physical_device_features.pipelineStatisticsQuery) {
Petr Krause7bb9e82019-08-11 21:34:43 +02002661 skip |= validate_flags(cmd_name, "pBeginInfo->pInheritanceInfo->pipelineStatistics", "VkQueryPipelineStatisticFlagBits",
Petr Kraus52758be2019-08-12 00:53:58 +02002662 AllVkQueryPipelineStatisticFlagBits, pInfo->pipelineStatistics, kOptionalFlags,
Petr Kraus43aed2c2019-08-18 13:59:16 +02002663 "VUID-VkCommandBufferInheritanceInfo-pipelineStatistics-02789");
Petr Krause7bb9e82019-08-11 21:34:43 +02002664 } else { // !pipelineStatisticsQuery
2665 skip |= validate_reserved_flags(cmd_name, "pBeginInfo->pInheritanceInfo->pipelineStatistics", pInfo->pipelineStatistics,
2666 "VUID-VkCommandBufferInheritanceInfo-pipelineStatistics-00058");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002667 }
Petr Kraus139757b2019-08-15 17:19:33 +02002668
2669 const auto *conditional_rendering = lvl_find_in_chain<VkCommandBufferInheritanceConditionalRenderingInfoEXT>(pInfo->pNext);
2670 if (conditional_rendering) {
Tony-LunarG6c3c5452019-12-13 10:37:38 -07002671 const auto *cr_features = lvl_find_in_chain<VkPhysicalDeviceConditionalRenderingFeaturesEXT>(device_createinfo_pnext);
Petr Kraus139757b2019-08-15 17:19:33 +02002672 const auto inherited_conditional_rendering = cr_features && cr_features->inheritedConditionalRendering;
2673 if (!inherited_conditional_rendering && conditional_rendering->conditionalRenderingEnable == VK_TRUE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002674 skip |= LogError(
2675 commandBuffer, "VUID-VkCommandBufferInheritanceConditionalRenderingInfoEXT-conditionalRenderingEnable-01977",
Petr Kraus139757b2019-08-15 17:19:33 +02002676 "vkBeginCommandBuffer: Inherited conditional rendering is disabled, but "
2677 "pBeginInfo->pInheritanceInfo->pNext<VkCommandBufferInheritanceConditionalRenderingInfoEXT> is VK_TRUE.");
2678 }
2679 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002680 }
2681
2682 return skip;
2683}
2684
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002685bool StatelessValidation::manual_PreCallValidateCmdSetViewport(VkCommandBuffer commandBuffer, uint32_t firstViewport,
Jeff Bolz5c801d12019-10-09 10:38:45 -05002686 uint32_t viewportCount, const VkViewport *pViewports) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002687 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002688
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002689 if (!physical_device_features.multiViewport) {
Petr Krausd55e77c2018-01-09 22:09:25 +01002690 if (firstViewport != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002691 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewport-firstViewport-01224",
2692 "vkCmdSetViewport: The multiViewport feature is disabled, but firstViewport (=%" PRIu32 ") is not 0.",
2693 firstViewport);
Petr Krausd55e77c2018-01-09 22:09:25 +01002694 }
2695 if (viewportCount > 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002696 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewport-viewportCount-01225",
2697 "vkCmdSetViewport: The multiViewport feature is disabled, but viewportCount (=%" PRIu32 ") is not 1.",
2698 viewportCount);
Petr Krausd55e77c2018-01-09 22:09:25 +01002699 }
2700 } else { // multiViewport enabled
Petr Kraus7dfeed12018-02-27 20:51:20 +01002701 const uint64_t sum = static_cast<uint64_t>(firstViewport) + static_cast<uint64_t>(viewportCount);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002702 if (sum > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002703 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewport-firstViewport-01223",
2704 "vkCmdSetViewport: firstViewport + viewportCount (=%" PRIu32 " + %" PRIu32 " = %" PRIu64
2705 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
2706 firstViewport, viewportCount, sum, device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002707 }
2708 }
Petr Krausb3fcdb42018-01-09 22:09:09 +01002709
2710 if (pViewports) {
2711 for (uint32_t viewport_i = 0; viewport_i < viewportCount; ++viewport_i) {
2712 const auto &viewport = pViewports[viewport_i]; // will crash on invalid ptr
Jeff Bolz6d3beaa2019-02-09 21:00:05 -06002713 const char *fn_name = "vkCmdSetViewport";
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002714 skip |= manual_PreCallValidateViewport(
2715 viewport, fn_name, ParameterName("pViewports[%i]", ParameterName::IndexVector{viewport_i}), commandBuffer);
Petr Krausb3fcdb42018-01-09 22:09:09 +01002716 }
2717 }
2718
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002719 return skip;
2720}
2721
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002722bool StatelessValidation::manual_PreCallValidateCmdSetScissor(VkCommandBuffer commandBuffer, uint32_t firstScissor,
Jeff Bolz5c801d12019-10-09 10:38:45 -05002723 uint32_t scissorCount, const VkRect2D *pScissors) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002724 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002725
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002726 if (!physical_device_features.multiViewport) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002727 if (firstScissor != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002728 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-firstScissor-00593",
2729 "vkCmdSetScissor: The multiViewport feature is disabled, but firstScissor (=%" PRIu32 ") is not 0.",
2730 firstScissor);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002731 }
2732 if (scissorCount > 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002733 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-scissorCount-00594",
2734 "vkCmdSetScissor: The multiViewport feature is disabled, but scissorCount (=%" PRIu32 ") is not 1.",
2735 scissorCount);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002736 }
2737 } else { // multiViewport enabled
2738 const uint64_t sum = static_cast<uint64_t>(firstScissor) + static_cast<uint64_t>(scissorCount);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002739 if (sum > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002740 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-firstScissor-00592",
2741 "vkCmdSetScissor: firstScissor + scissorCount (=%" PRIu32 " + %" PRIu32 " = %" PRIu64
2742 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
2743 firstScissor, scissorCount, sum, device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002744 }
2745 }
2746
Petr Kraus6260f0a2018-02-27 21:15:55 +01002747 if (pScissors) {
2748 for (uint32_t scissor_i = 0; scissor_i < scissorCount; ++scissor_i) {
2749 const auto &scissor = pScissors[scissor_i]; // will crash on invalid ptr
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002750
Petr Kraus6260f0a2018-02-27 21:15:55 +01002751 if (scissor.offset.x < 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002752 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-x-00595",
2753 "vkCmdSetScissor: pScissors[%" PRIu32 "].offset.x (=%" PRIi32 ") is negative.", scissor_i,
2754 scissor.offset.x);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002755 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002756
Petr Kraus6260f0a2018-02-27 21:15:55 +01002757 if (scissor.offset.y < 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002758 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-x-00595",
2759 "vkCmdSetScissor: pScissors[%" PRIu32 "].offset.y (=%" PRIi32 ") is negative.", scissor_i,
2760 scissor.offset.y);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002761 }
2762
2763 const int64_t x_sum = static_cast<int64_t>(scissor.offset.x) + static_cast<int64_t>(scissor.extent.width);
2764 if (x_sum > INT32_MAX) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002765 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-offset-00596",
2766 "vkCmdSetScissor: offset.x + extent.width (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
2767 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
2768 scissor.offset.x, scissor.extent.width, x_sum, scissor_i);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002769 }
2770
2771 const int64_t y_sum = static_cast<int64_t>(scissor.offset.y) + static_cast<int64_t>(scissor.extent.height);
2772 if (y_sum > INT32_MAX) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002773 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-offset-00597",
2774 "vkCmdSetScissor: offset.y + extent.height (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
2775 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
2776 scissor.offset.y, scissor.extent.height, y_sum, scissor_i);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002777 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002778 }
2779 }
Petr Kraus6260f0a2018-02-27 21:15:55 +01002780
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002781 return skip;
2782}
2783
Jeff Bolz5c801d12019-10-09 10:38:45 -05002784bool StatelessValidation::manual_PreCallValidateCmdSetLineWidth(VkCommandBuffer commandBuffer, float lineWidth) const {
Petr Kraus299ba622017-11-24 03:09:03 +01002785 bool skip = false;
Petr Kraus299ba622017-11-24 03:09:03 +01002786
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002787 if (!physical_device_features.wideLines && (lineWidth != 1.0f)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002788 skip |= LogError(commandBuffer, "VUID-vkCmdSetLineWidth-lineWidth-00788",
2789 "VkPhysicalDeviceFeatures::wideLines is disabled, but lineWidth (=%f) is not 1.0.", lineWidth);
Petr Kraus299ba622017-11-24 03:09:03 +01002790 }
2791
2792 return skip;
2793}
2794
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002795bool StatelessValidation::manual_PreCallValidateCmdDraw(VkCommandBuffer commandBuffer, uint32_t vertexCount, uint32_t instanceCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05002796 uint32_t firstVertex, uint32_t firstInstance) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002797 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002798 if (vertexCount == 0) {
2799 // TODO: Verify against Valid Usage section. I don't see a non-zero vertexCount listed, may need to add that and make
2800 // this an error or leave as is.
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002801 skip |= LogWarning(device, kVUID_PVError_RequiredParameter, "vkCmdDraw parameter, uint32_t vertexCount, is 0");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002802 }
2803
2804 if (instanceCount == 0) {
2805 // TODO: Verify against Valid Usage section. I don't see a non-zero instanceCount listed, may need to add that and make
2806 // this an error or leave as is.
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002807 skip |= LogWarning(device, kVUID_PVError_RequiredParameter, "vkCmdDraw parameter, uint32_t instanceCount, is 0");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002808 }
2809 return skip;
2810}
2811
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002812bool StatelessValidation::manual_PreCallValidateCmdDrawIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset,
Jeff Bolz5c801d12019-10-09 10:38:45 -05002813 uint32_t count, uint32_t stride) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002814 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002815
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002816 if (!physical_device_features.multiDrawIndirect && ((count > 1))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002817 skip |= LogError(device, kVUID_PVError_DeviceFeature,
2818 "CmdDrawIndirect(): Device feature multiDrawIndirect disabled: count must be 0 or 1 but is %d", count);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002819 }
2820 return skip;
2821}
2822
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002823bool StatelessValidation::manual_PreCallValidateCmdDrawIndexedIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer,
Jeff Bolz5c801d12019-10-09 10:38:45 -05002824 VkDeviceSize offset, uint32_t count, uint32_t stride) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002825 bool skip = false;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002826 if (!physical_device_features.multiDrawIndirect && ((count > 1))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002827 skip |=
2828 LogError(device, kVUID_PVError_DeviceFeature,
2829 "CmdDrawIndexedIndirect(): Device feature multiDrawIndirect disabled: count must be 0 or 1 but is %d", count);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002830 }
2831 return skip;
2832}
2833
Mark Lobodzinskif77a4ac2019-06-27 15:30:51 -06002834bool StatelessValidation::manual_PreCallValidateCmdClearAttachments(VkCommandBuffer commandBuffer, uint32_t attachmentCount,
2835 const VkClearAttachment *pAttachments, uint32_t rectCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05002836 const VkClearRect *pRects) const {
Mark Lobodzinskif77a4ac2019-06-27 15:30:51 -06002837 bool skip = false;
2838 for (uint32_t rect = 0; rect < rectCount; rect++) {
2839 if (pRects[rect].layerCount == 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002840 skip |= LogError(commandBuffer, "VUID-vkCmdClearAttachments-layerCount-01934",
2841 "CmdClearAttachments(): pRects[%d].layerCount is zero.", rect);
Mark Lobodzinskif77a4ac2019-06-27 15:30:51 -06002842 }
2843 }
2844 return skip;
2845}
2846
Andrew Fobel3abeb992020-01-20 16:33:22 -05002847bool StatelessValidation::ValidateGetPhysicalDeviceImageFormatProperties2(VkPhysicalDevice physicalDevice,
2848 const VkPhysicalDeviceImageFormatInfo2 *pImageFormatInfo,
2849 VkImageFormatProperties2 *pImageFormatProperties,
2850 const char *apiName) const {
2851 bool skip = false;
2852
2853 if (pImageFormatInfo != nullptr) {
2854 const auto image_stencil_struct = lvl_find_in_chain<VkImageStencilUsageCreateInfoEXT>(pImageFormatInfo->pNext);
2855 if (image_stencil_struct != nullptr) {
2856 if ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT) != 0) {
2857 VkImageUsageFlags legal_flags = (VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT | VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT);
2858 // No flags other than the legal attachment bits may be set
2859 legal_flags |= VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT;
2860 if ((image_stencil_struct->stencilUsage & ~legal_flags) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002861 skip |= LogError(physicalDevice, "VUID-VkImageStencilUsageCreateInfo-stencilUsage-02539",
2862 "%s(): in pNext chain, VkImageStencilUsageCreateInfo::stencilUsage "
2863 "includes VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT, it must not include bits other than "
2864 "VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT or VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT",
2865 apiName);
Andrew Fobel3abeb992020-01-20 16:33:22 -05002866 }
2867 }
2868 }
2869 }
2870
2871 return skip;
2872}
2873
2874bool StatelessValidation::manual_PreCallValidateGetPhysicalDeviceImageFormatProperties2(
2875 VkPhysicalDevice physicalDevice, const VkPhysicalDeviceImageFormatInfo2 *pImageFormatInfo,
2876 VkImageFormatProperties2 *pImageFormatProperties) const {
2877 return ValidateGetPhysicalDeviceImageFormatProperties2(physicalDevice, pImageFormatInfo, pImageFormatProperties,
2878 "vkGetPhysicalDeviceImageFormatProperties2");
2879}
2880
2881bool StatelessValidation::manual_PreCallValidateGetPhysicalDeviceImageFormatProperties2KHR(
2882 VkPhysicalDevice physicalDevice, const VkPhysicalDeviceImageFormatInfo2 *pImageFormatInfo,
2883 VkImageFormatProperties2 *pImageFormatProperties) const {
2884 return ValidateGetPhysicalDeviceImageFormatProperties2(physicalDevice, pImageFormatInfo, pImageFormatProperties,
2885 "vkGetPhysicalDeviceImageFormatProperties2KHR");
2886}
2887
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002888bool StatelessValidation::manual_PreCallValidateCmdCopyImage(VkCommandBuffer commandBuffer, VkImage srcImage,
2889 VkImageLayout srcImageLayout, VkImage dstImage,
2890 VkImageLayout dstImageLayout, uint32_t regionCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05002891 const VkImageCopy *pRegions) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002892 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002893
Dave Houltonf5217612018-02-02 16:18:52 -07002894 VkImageAspectFlags legal_aspect_flags =
2895 VK_IMAGE_ASPECT_COLOR_BIT | VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT | VK_IMAGE_ASPECT_METADATA_BIT;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002896 if (device_extensions.vk_khr_sampler_ycbcr_conversion) {
Dave Houltonf5217612018-02-02 16:18:52 -07002897 legal_aspect_flags |= (VK_IMAGE_ASPECT_PLANE_0_BIT_KHR | VK_IMAGE_ASPECT_PLANE_1_BIT_KHR | VK_IMAGE_ASPECT_PLANE_2_BIT_KHR);
2898 }
2899
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002900 if (pRegions != nullptr) {
Dave Houltonf5217612018-02-02 16:18:52 -07002901 if ((pRegions->srcSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002902 skip |= LogError(
2903 device, "VUID-VkImageSubresourceLayers-aspectMask-parameter",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002904 "vkCmdCopyImage() parameter, VkImageAspect pRegions->srcSubresource.aspectMask, is an unrecognized enumerator.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002905 }
Dave Houltonf5217612018-02-02 16:18:52 -07002906 if ((pRegions->dstSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002907 skip |= LogError(
2908 device, "VUID-VkImageSubresourceLayers-aspectMask-parameter",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002909 "vkCmdCopyImage() parameter, VkImageAspect pRegions->dstSubresource.aspectMask, is an unrecognized enumerator.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002910 }
2911 }
2912 return skip;
2913}
2914
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002915bool StatelessValidation::manual_PreCallValidateCmdBlitImage(VkCommandBuffer commandBuffer, VkImage srcImage,
2916 VkImageLayout srcImageLayout, VkImage dstImage,
2917 VkImageLayout dstImageLayout, uint32_t regionCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05002918 const VkImageBlit *pRegions, VkFilter filter) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002919 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002920
Dave Houltonf5217612018-02-02 16:18:52 -07002921 VkImageAspectFlags legal_aspect_flags =
2922 VK_IMAGE_ASPECT_COLOR_BIT | VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT | VK_IMAGE_ASPECT_METADATA_BIT;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002923 if (device_extensions.vk_khr_sampler_ycbcr_conversion) {
Dave Houltonf5217612018-02-02 16:18:52 -07002924 legal_aspect_flags |= (VK_IMAGE_ASPECT_PLANE_0_BIT_KHR | VK_IMAGE_ASPECT_PLANE_1_BIT_KHR | VK_IMAGE_ASPECT_PLANE_2_BIT_KHR);
2925 }
2926
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002927 if (pRegions != nullptr) {
Dave Houltonf5217612018-02-02 16:18:52 -07002928 if ((pRegions->srcSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002929 skip |= LogError(
2930 device, kVUID_PVError_UnrecognizedValue,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002931 "vkCmdBlitImage() parameter, VkImageAspect pRegions->srcSubresource.aspectMask, is an unrecognized enumerator");
2932 }
Dave Houltonf5217612018-02-02 16:18:52 -07002933 if ((pRegions->dstSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002934 skip |= LogError(
2935 device, kVUID_PVError_UnrecognizedValue,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002936 "vkCmdBlitImage() parameter, VkImageAspect pRegions->dstSubresource.aspectMask, is an unrecognized enumerator");
2937 }
2938 }
2939 return skip;
2940}
2941
sfricke-samsung3999ef62020-02-09 17:05:59 -08002942bool StatelessValidation::manual_PreCallValidateCmdCopyBuffer(VkCommandBuffer commandBuffer, VkBuffer srcBuffer, VkBuffer dstBuffer,
2943 uint32_t regionCount, const VkBufferCopy *pRegions) const {
2944 bool skip = false;
2945
2946 if (pRegions != nullptr) {
2947 for (uint32_t i = 0; i < regionCount; i++) {
2948 if (pRegions[i].size == 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002949 skip |= LogError(device, "VUID-VkBufferCopy-size-01988",
2950 "vkCmdCopyBuffer() pRegions[%u].size must be greater than zero", i);
sfricke-samsung3999ef62020-02-09 17:05:59 -08002951 }
2952 }
2953 }
2954 return skip;
2955}
2956
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002957bool StatelessValidation::manual_PreCallValidateCmdCopyBufferToImage(VkCommandBuffer commandBuffer, VkBuffer srcBuffer,
2958 VkImage dstImage, VkImageLayout dstImageLayout,
Jeff Bolz5c801d12019-10-09 10:38:45 -05002959 uint32_t regionCount,
2960 const VkBufferImageCopy *pRegions) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002961 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002962
Dave Houltonf5217612018-02-02 16:18:52 -07002963 VkImageAspectFlags legal_aspect_flags =
2964 VK_IMAGE_ASPECT_COLOR_BIT | VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT | VK_IMAGE_ASPECT_METADATA_BIT;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002965 if (device_extensions.vk_khr_sampler_ycbcr_conversion) {
Dave Houltonf5217612018-02-02 16:18:52 -07002966 legal_aspect_flags |= (VK_IMAGE_ASPECT_PLANE_0_BIT_KHR | VK_IMAGE_ASPECT_PLANE_1_BIT_KHR | VK_IMAGE_ASPECT_PLANE_2_BIT_KHR);
2967 }
2968
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002969 if (pRegions != nullptr) {
Dave Houltonf5217612018-02-02 16:18:52 -07002970 if ((pRegions->imageSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002971 skip |= LogError(device, kVUID_PVError_UnrecognizedValue,
2972 "vkCmdCopyBufferToImage() parameter, VkImageAspect pRegions->imageSubresource.aspectMask, is an "
2973 "unrecognized enumerator");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002974 }
2975 }
2976 return skip;
2977}
2978
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002979bool StatelessValidation::manual_PreCallValidateCmdCopyImageToBuffer(VkCommandBuffer commandBuffer, VkImage srcImage,
2980 VkImageLayout srcImageLayout, VkBuffer dstBuffer,
Jeff Bolz5c801d12019-10-09 10:38:45 -05002981 uint32_t regionCount,
2982 const VkBufferImageCopy *pRegions) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002983 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002984
Dave Houltonf5217612018-02-02 16:18:52 -07002985 VkImageAspectFlags legal_aspect_flags =
2986 VK_IMAGE_ASPECT_COLOR_BIT | VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT | VK_IMAGE_ASPECT_METADATA_BIT;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002987 if (device_extensions.vk_khr_sampler_ycbcr_conversion) {
Dave Houltonf5217612018-02-02 16:18:52 -07002988 legal_aspect_flags |= (VK_IMAGE_ASPECT_PLANE_0_BIT_KHR | VK_IMAGE_ASPECT_PLANE_1_BIT_KHR | VK_IMAGE_ASPECT_PLANE_2_BIT_KHR);
2989 }
2990
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002991 if (pRegions != nullptr) {
Dave Houltonf5217612018-02-02 16:18:52 -07002992 if ((pRegions->imageSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002993 LogError(device, kVUID_PVError_UnrecognizedValue,
2994 "vkCmdCopyImageToBuffer parameter, VkImageAspect pRegions->imageSubresource.aspectMask, is an unrecognized "
2995 "enumerator");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002996 }
2997 }
2998 return skip;
2999}
3000
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003001bool StatelessValidation::manual_PreCallValidateCmdUpdateBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003002 VkDeviceSize dstOffset, VkDeviceSize dataSize,
3003 const void *pData) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003004 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003005
3006 if (dstOffset & 3) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003007 skip |= LogError(device, "VUID-vkCmdUpdateBuffer-dstOffset-00036",
3008 "vkCmdUpdateBuffer() parameter, VkDeviceSize dstOffset (0x%" PRIxLEAST64 "), is not a multiple of 4.",
3009 dstOffset);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003010 }
3011
3012 if ((dataSize <= 0) || (dataSize > 65536)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003013 skip |= LogError(device, "VUID-vkCmdUpdateBuffer-dataSize-00037",
3014 "vkCmdUpdateBuffer() parameter, VkDeviceSize dataSize (0x%" PRIxLEAST64
3015 "), must be greater than zero and less than or equal to 65536.",
3016 dataSize);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003017 } else if (dataSize & 3) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003018 skip |= LogError(device, "VUID-vkCmdUpdateBuffer-dataSize-00038",
3019 "vkCmdUpdateBuffer() parameter, VkDeviceSize dataSize (0x%" PRIxLEAST64 "), is not a multiple of 4.",
3020 dataSize);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003021 }
3022 return skip;
3023}
3024
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003025bool StatelessValidation::manual_PreCallValidateCmdFillBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003026 VkDeviceSize dstOffset, VkDeviceSize size, uint32_t data) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003027 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003028
3029 if (dstOffset & 3) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003030 skip |= LogError(device, "VUID-vkCmdFillBuffer-dstOffset-00025",
3031 "vkCmdFillBuffer() parameter, VkDeviceSize dstOffset (0x%" PRIxLEAST64 "), is not a multiple of 4.",
3032 dstOffset);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003033 }
3034
3035 if (size != VK_WHOLE_SIZE) {
3036 if (size <= 0) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003037 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003038 LogError(device, "VUID-vkCmdFillBuffer-size-00026",
3039 "vkCmdFillBuffer() parameter, VkDeviceSize size (0x%" PRIxLEAST64 "), must be greater than zero.", size);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003040 } else if (size & 3) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003041 skip |= LogError(device, "VUID-vkCmdFillBuffer-size-00028",
3042 "vkCmdFillBuffer() parameter, VkDeviceSize size (0x%" PRIxLEAST64 "), is not a multiple of 4.", size);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003043 }
3044 }
3045 return skip;
3046}
3047
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003048bool StatelessValidation::manual_PreCallValidateCreateSwapchainKHR(VkDevice device, const VkSwapchainCreateInfoKHR *pCreateInfo,
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003049 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003050 VkSwapchainKHR *pSwapchain) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003051 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003052
3053 if (pCreateInfo != nullptr) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003054 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
3055 if (pCreateInfo->imageSharingMode == VK_SHARING_MODE_CONCURRENT) {
3056 // If imageSharingMode is VK_SHARING_MODE_CONCURRENT, queueFamilyIndexCount must be greater than 1
3057 if (pCreateInfo->queueFamilyIndexCount <= 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003058 skip |= LogError(device, "VUID-VkSwapchainCreateInfoKHR-imageSharingMode-01278",
3059 "vkCreateSwapchainKHR(): if pCreateInfo->imageSharingMode is VK_SHARING_MODE_CONCURRENT, "
3060 "pCreateInfo->queueFamilyIndexCount must be greater than 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003061 }
3062
3063 // If imageSharingMode is VK_SHARING_MODE_CONCURRENT, pQueueFamilyIndices must be a pointer to an array of
3064 // queueFamilyIndexCount uint32_t values
3065 if (pCreateInfo->pQueueFamilyIndices == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003066 skip |= LogError(device, "VUID-VkSwapchainCreateInfoKHR-imageSharingMode-01277",
3067 "vkCreateSwapchainKHR(): if pCreateInfo->imageSharingMode is VK_SHARING_MODE_CONCURRENT, "
3068 "pCreateInfo->pQueueFamilyIndices must be a pointer to an array of "
3069 "pCreateInfo->queueFamilyIndexCount uint32_t values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003070 }
3071 }
3072
Dave Houlton413a6782018-05-22 13:01:54 -06003073 skip |= ValidateGreaterThanZero(pCreateInfo->imageArrayLayers, "pCreateInfo->imageArrayLayers",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003074 "VUID-VkSwapchainCreateInfoKHR-imageArrayLayers-01275", "vkCreateSwapchainKHR");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003075 }
3076
3077 return skip;
3078}
3079
Jeff Bolz5c801d12019-10-09 10:38:45 -05003080bool StatelessValidation::manual_PreCallValidateQueuePresentKHR(VkQueue queue, const VkPresentInfoKHR *pPresentInfo) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003081 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003082
3083 if (pPresentInfo && pPresentInfo->pNext) {
John Zulaufde972ac2017-10-26 12:07:05 -06003084 const auto *present_regions = lvl_find_in_chain<VkPresentRegionsKHR>(pPresentInfo->pNext);
3085 if (present_regions) {
3086 // TODO: This and all other pNext extension dependencies should be added to code-generation
Tony-LunarG2ec96bb2019-11-26 13:43:02 -07003087 skip |= require_device_extension(IsExtEnabled(device_extensions.vk_khr_incremental_present), "vkQueuePresentKHR",
John Zulaufde972ac2017-10-26 12:07:05 -06003088 VK_KHR_INCREMENTAL_PRESENT_EXTENSION_NAME);
3089 if (present_regions->swapchainCount != pPresentInfo->swapchainCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003090 skip |= LogError(device, kVUID_PVError_InvalidUsage,
3091 "QueuePresentKHR(): pPresentInfo->swapchainCount has a value of %i but VkPresentRegionsKHR "
3092 "extension swapchainCount is %i. These values must be equal.",
3093 pPresentInfo->swapchainCount, present_regions->swapchainCount);
John Zulaufde972ac2017-10-26 12:07:05 -06003094 }
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003095 skip |= validate_struct_pnext("QueuePresentKHR", "pCreateInfo->pNext->pNext", NULL, present_regions->pNext, 0, NULL,
sfricke-samsung32a27362020-02-28 09:06:42 -08003096 GeneratedVulkanHeaderVersion, "VUID-VkPresentInfoKHR-pNext-pNext",
3097 "VUID-VkPresentInfoKHR-sType-unique");
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003098 skip |= validate_array("QueuePresentKHR", "pCreateInfo->pNext->swapchainCount", "pCreateInfo->pNext->pRegions",
3099 present_regions->swapchainCount, &present_regions->pRegions, true, false, kVUIDUndefined,
3100 kVUIDUndefined);
John Zulaufde972ac2017-10-26 12:07:05 -06003101 for (uint32_t i = 0; i < present_regions->swapchainCount; ++i) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003102 skip |= validate_array("QueuePresentKHR", "pCreateInfo->pNext->pRegions[].rectangleCount",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003103 "pCreateInfo->pNext->pRegions[].pRectangles", present_regions->pRegions[i].rectangleCount,
Dave Houlton413a6782018-05-22 13:01:54 -06003104 &present_regions->pRegions[i].pRectangles, true, false, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003105 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003106 }
3107 }
3108
3109 return skip;
3110}
3111
3112#ifdef VK_USE_PLATFORM_WIN32_KHR
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003113bool StatelessValidation::manual_PreCallValidateCreateWin32SurfaceKHR(VkInstance instance,
3114 const VkWin32SurfaceCreateInfoKHR *pCreateInfo,
3115 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003116 VkSurfaceKHR *pSurface) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003117 bool skip = false;
3118
3119 if (pCreateInfo->hwnd == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003120 skip |= LogError(device, "VUID-VkWin32SurfaceCreateInfoKHR-hwnd-01308",
3121 "vkCreateWin32SurfaceKHR(): hwnd must be a valid Win32 HWND but hwnd is NULL.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003122 }
3123
3124 return skip;
3125}
3126#endif // VK_USE_PLATFORM_WIN32_KHR
3127
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003128bool StatelessValidation::manual_PreCallValidateCreateDescriptorPool(VkDevice device, const VkDescriptorPoolCreateInfo *pCreateInfo,
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003129 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003130 VkDescriptorPool *pDescriptorPool) const {
Petr Krausc8655be2017-09-27 18:56:51 +02003131 bool skip = false;
3132
3133 if (pCreateInfo) {
3134 if (pCreateInfo->maxSets <= 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003135 skip |= LogError(device, "VUID-VkDescriptorPoolCreateInfo-maxSets-00301",
3136 "vkCreateDescriptorPool(): pCreateInfo->maxSets is not greater than 0.");
Petr Krausc8655be2017-09-27 18:56:51 +02003137 }
3138
3139 if (pCreateInfo->pPoolSizes) {
3140 for (uint32_t i = 0; i < pCreateInfo->poolSizeCount; ++i) {
3141 if (pCreateInfo->pPoolSizes[i].descriptorCount <= 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003142 skip |= LogError(
3143 device, "VUID-VkDescriptorPoolSize-descriptorCount-00302",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003144 "vkCreateDescriptorPool(): pCreateInfo->pPoolSizes[%" PRIu32 "].descriptorCount is not greater than 0.", i);
Petr Krausc8655be2017-09-27 18:56:51 +02003145 }
Jeff Bolze54ae892018-09-08 12:16:29 -05003146 if (pCreateInfo->pPoolSizes[i].type == VK_DESCRIPTOR_TYPE_INLINE_UNIFORM_BLOCK_EXT &&
3147 (pCreateInfo->pPoolSizes[i].descriptorCount % 4) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003148 skip |= LogError(device, "VUID-VkDescriptorPoolSize-type-02218",
3149 "vkCreateDescriptorPool(): pCreateInfo->pPoolSizes[%" PRIu32
3150 "].type is VK_DESCRIPTOR_TYPE_INLINE_UNIFORM_BLOCK_EXT "
3151 " and pCreateInfo->pPoolSizes[%" PRIu32 "].descriptorCount is not a multiple of 4.",
3152 i, i);
Jeff Bolze54ae892018-09-08 12:16:29 -05003153 }
Petr Krausc8655be2017-09-27 18:56:51 +02003154 }
3155 }
3156 }
3157
3158 return skip;
3159}
3160
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003161bool StatelessValidation::manual_PreCallValidateCmdDispatch(VkCommandBuffer commandBuffer, uint32_t groupCountX,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003162 uint32_t groupCountY, uint32_t groupCountZ) const {
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003163 bool skip = false;
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003164
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003165 if (groupCountX > device_limits.maxComputeWorkGroupCount[0]) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003166 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003167 LogError(commandBuffer, "VUID-vkCmdDispatch-groupCountX-00386",
3168 "vkCmdDispatch(): groupCountX (%" PRIu32 ") exceeds device limit maxComputeWorkGroupCount[0] (%" PRIu32 ").",
3169 groupCountX, device_limits.maxComputeWorkGroupCount[0]);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003170 }
3171
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003172 if (groupCountY > device_limits.maxComputeWorkGroupCount[1]) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003173 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003174 LogError(commandBuffer, "VUID-vkCmdDispatch-groupCountY-00387",
3175 "vkCmdDispatch(): groupCountY (%" PRIu32 ") exceeds device limit maxComputeWorkGroupCount[1] (%" PRIu32 ").",
3176 groupCountY, device_limits.maxComputeWorkGroupCount[1]);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003177 }
3178
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003179 if (groupCountZ > device_limits.maxComputeWorkGroupCount[2]) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003180 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003181 LogError(commandBuffer, "VUID-vkCmdDispatch-groupCountZ-00388",
3182 "vkCmdDispatch(): groupCountZ (%" PRIu32 ") exceeds device limit maxComputeWorkGroupCount[2] (%" PRIu32 ").",
3183 groupCountZ, device_limits.maxComputeWorkGroupCount[2]);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003184 }
3185
3186 return skip;
3187}
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003188
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003189bool StatelessValidation::manual_PreCallValidateCmdDispatchIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003190 VkDeviceSize offset) const {
John Zulaufa999d1b2018-11-29 13:38:40 -07003191 bool skip = false;
John Zulaufa999d1b2018-11-29 13:38:40 -07003192
3193 if ((offset % 4) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003194 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchIndirect-offset-02710",
3195 "vkCmdDispatchIndirect(): offset (%" PRIu64 ") must be a multiple of 4.", offset);
John Zulaufa999d1b2018-11-29 13:38:40 -07003196 }
3197 return skip;
3198}
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003199
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003200bool StatelessValidation::manual_PreCallValidateCmdDispatchBaseKHR(VkCommandBuffer commandBuffer, uint32_t baseGroupX,
3201 uint32_t baseGroupY, uint32_t baseGroupZ, uint32_t groupCountX,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003202 uint32_t groupCountY, uint32_t groupCountZ) const {
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003203 bool skip = false;
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003204
3205 // Paired if {} else if {} tests used to avoid any possible uint underflow
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003206 uint32_t limit = device_limits.maxComputeWorkGroupCount[0];
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003207 if (baseGroupX >= limit) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003208 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchBase-baseGroupX-00421",
3209 "vkCmdDispatch(): baseGroupX (%" PRIu32
3210 ") equals or exceeds device limit maxComputeWorkGroupCount[0] (%" PRIu32 ").",
3211 baseGroupX, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003212 } else if (groupCountX > (limit - baseGroupX)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003213 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchBase-groupCountX-00424",
3214 "vkCmdDispatchBaseKHR(): baseGroupX (%" PRIu32 ") + groupCountX (%" PRIu32
3215 ") exceeds device limit maxComputeWorkGroupCount[0] (%" PRIu32 ").",
3216 baseGroupX, groupCountX, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003217 }
3218
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003219 limit = device_limits.maxComputeWorkGroupCount[1];
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003220 if (baseGroupY >= limit) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003221 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchBase-baseGroupX-00422",
3222 "vkCmdDispatch(): baseGroupY (%" PRIu32
3223 ") equals or exceeds device limit maxComputeWorkGroupCount[1] (%" PRIu32 ").",
3224 baseGroupY, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003225 } else if (groupCountY > (limit - baseGroupY)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003226 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchBase-groupCountY-00425",
3227 "vkCmdDispatchBaseKHR(): baseGroupY (%" PRIu32 ") + groupCountY (%" PRIu32
3228 ") exceeds device limit maxComputeWorkGroupCount[1] (%" PRIu32 ").",
3229 baseGroupY, groupCountY, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003230 }
3231
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003232 limit = device_limits.maxComputeWorkGroupCount[2];
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003233 if (baseGroupZ >= limit) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003234 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchBase-baseGroupZ-00423",
3235 "vkCmdDispatch(): baseGroupZ (%" PRIu32
3236 ") equals or exceeds device limit maxComputeWorkGroupCount[2] (%" PRIu32 ").",
3237 baseGroupZ, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003238 } else if (groupCountZ > (limit - baseGroupZ)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003239 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchBase-groupCountZ-00426",
3240 "vkCmdDispatchBaseKHR(): baseGroupZ (%" PRIu32 ") + groupCountZ (%" PRIu32
3241 ") exceeds device limit maxComputeWorkGroupCount[2] (%" PRIu32 ").",
3242 baseGroupZ, groupCountZ, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003243 }
3244
3245 return skip;
3246}
3247
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07003248bool StatelessValidation::manual_PreCallValidateCmdPushDescriptorSetKHR(VkCommandBuffer commandBuffer,
3249 VkPipelineBindPoint pipelineBindPoint,
3250 VkPipelineLayout layout, uint32_t set,
3251 uint32_t descriptorWriteCount,
3252 const VkWriteDescriptorSet *pDescriptorWrites) const {
3253 return validate_WriteDescriptorSet("vkCmdPushDescriptorSetKHR", descriptorWriteCount, pDescriptorWrites, false);
3254}
3255
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003256bool StatelessValidation::manual_PreCallValidateCmdSetExclusiveScissorNV(VkCommandBuffer commandBuffer,
3257 uint32_t firstExclusiveScissor,
3258 uint32_t exclusiveScissorCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003259 const VkRect2D *pExclusiveScissors) const {
Jeff Bolz3e71f782018-08-29 23:15:45 -05003260 bool skip = false;
3261
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003262 if (!physical_device_features.multiViewport) {
Jeff Bolz3e71f782018-08-29 23:15:45 -05003263 if (firstExclusiveScissor != 0) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06003264 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003265 LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-firstExclusiveScissor-02035",
3266 "vkCmdSetExclusiveScissorNV: The multiViewport feature is disabled, but firstExclusiveScissor (=%" PRIu32
3267 ") is not 0.",
3268 firstExclusiveScissor);
Jeff Bolz3e71f782018-08-29 23:15:45 -05003269 }
3270 if (exclusiveScissorCount > 1) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06003271 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003272 LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-exclusiveScissorCount-02036",
3273 "vkCmdSetExclusiveScissorNV: The multiViewport feature is disabled, but exclusiveScissorCount (=%" PRIu32
3274 ") is not 1.",
3275 exclusiveScissorCount);
Jeff Bolz3e71f782018-08-29 23:15:45 -05003276 }
3277 } else { // multiViewport enabled
3278 const uint64_t sum = static_cast<uint64_t>(firstExclusiveScissor) + static_cast<uint64_t>(exclusiveScissorCount);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003279 if (sum > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003280 skip |= LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-firstExclusiveScissor-02034",
3281 "vkCmdSetExclusiveScissorNV: firstExclusiveScissor + exclusiveScissorCount (=%" PRIu32 " + %" PRIu32
3282 " = %" PRIu64 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
3283 firstExclusiveScissor, exclusiveScissorCount, sum, device_limits.maxViewports);
Jeff Bolz3e71f782018-08-29 23:15:45 -05003284 }
3285 }
3286
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003287 if (firstExclusiveScissor >= device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003288 skip |= LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-firstExclusiveScissor-02033",
3289 "vkCmdSetExclusiveScissorNV: firstExclusiveScissor (=%" PRIu32
3290 ") must be less than maxViewports (=%" PRIu32 ").",
3291 firstExclusiveScissor, device_limits.maxViewports);
Jeff Bolz3e71f782018-08-29 23:15:45 -05003292 }
3293
3294 if (pExclusiveScissors) {
3295 for (uint32_t scissor_i = 0; scissor_i < exclusiveScissorCount; ++scissor_i) {
3296 const auto &scissor = pExclusiveScissors[scissor_i]; // will crash on invalid ptr
3297
3298 if (scissor.offset.x < 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003299 skip |= LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-x-02037",
3300 "vkCmdSetExclusiveScissorNV: pScissors[%" PRIu32 "].offset.x (=%" PRIi32 ") is negative.",
3301 scissor_i, scissor.offset.x);
Jeff Bolz3e71f782018-08-29 23:15:45 -05003302 }
3303
3304 if (scissor.offset.y < 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003305 skip |= LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-x-02037",
3306 "vkCmdSetExclusiveScissorNV: pScissors[%" PRIu32 "].offset.y (=%" PRIi32 ") is negative.",
3307 scissor_i, scissor.offset.y);
Jeff Bolz3e71f782018-08-29 23:15:45 -05003308 }
3309
3310 const int64_t x_sum = static_cast<int64_t>(scissor.offset.x) + static_cast<int64_t>(scissor.extent.width);
3311 if (x_sum > INT32_MAX) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003312 skip |= LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-offset-02038",
3313 "vkCmdSetExclusiveScissorNV: offset.x + extent.width (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
3314 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
3315 scissor.offset.x, scissor.extent.width, x_sum, scissor_i);
Jeff Bolz3e71f782018-08-29 23:15:45 -05003316 }
3317
3318 const int64_t y_sum = static_cast<int64_t>(scissor.offset.y) + static_cast<int64_t>(scissor.extent.height);
3319 if (y_sum > INT32_MAX) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003320 skip |= LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-offset-02039",
3321 "vkCmdSetExclusiveScissorNV: offset.y + extent.height (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
3322 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
3323 scissor.offset.y, scissor.extent.height, y_sum, scissor_i);
Jeff Bolz3e71f782018-08-29 23:15:45 -05003324 }
3325 }
3326 }
3327
3328 return skip;
3329}
3330
Chris Mayer9ded5eb2019-09-19 16:33:26 +02003331bool StatelessValidation::manual_PreCallValidateCmdSetViewportWScalingNV(VkCommandBuffer commandBuffer, uint32_t firstViewport,
3332 uint32_t viewportCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003333 const VkViewportWScalingNV *pViewportWScalings) const {
Chris Mayer9ded5eb2019-09-19 16:33:26 +02003334 bool skip = false;
3335 if (firstViewport >= device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003336 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewportWScalingNV-firstViewport-01323",
3337 "vkCmdSetViewportWScalingNV: firstViewport (=%" PRIu32 ") must be less than maxViewports (=%" PRIu32 ").",
3338 firstViewport, device_limits.maxViewports);
Chris Mayer9ded5eb2019-09-19 16:33:26 +02003339 } else {
3340 const uint64_t sum = static_cast<uint64_t>(firstViewport) + static_cast<uint64_t>(viewportCount);
3341 if ((sum < 1) || (sum > device_limits.maxViewports)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003342 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewportWScalingNV-firstViewport-01324",
3343 "vkCmdSetViewportWScalingNV: firstViewport + viewportCount (=%" PRIu32 " + %" PRIu32 " = %" PRIu64
3344 ") must be between 1 and VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 "), inculsive.",
3345 firstViewport, viewportCount, sum, device_limits.maxViewports);
Chris Mayer9ded5eb2019-09-19 16:33:26 +02003346 }
3347 }
3348
3349 return skip;
3350}
3351
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003352bool StatelessValidation::manual_PreCallValidateCmdSetViewportShadingRatePaletteNV(
3353 VkCommandBuffer commandBuffer, uint32_t firstViewport, uint32_t viewportCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003354 const VkShadingRatePaletteNV *pShadingRatePalettes) const {
Jeff Bolz9af91c52018-09-01 21:53:57 -05003355 bool skip = false;
3356
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003357 if (!physical_device_features.multiViewport) {
Jeff Bolz9af91c52018-09-01 21:53:57 -05003358 if (firstViewport != 0) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06003359 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003360 LogError(commandBuffer, "VUID-vkCmdSetViewportShadingRatePaletteNV-firstViewport-02068",
3361 "vkCmdSetViewportShadingRatePaletteNV: The multiViewport feature is disabled, but firstViewport (=%" PRIu32
3362 ") is not 0.",
3363 firstViewport);
Jeff Bolz9af91c52018-09-01 21:53:57 -05003364 }
3365 if (viewportCount > 1) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06003366 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003367 LogError(commandBuffer, "VUID-vkCmdSetViewportShadingRatePaletteNV-viewportCount-02069",
3368 "vkCmdSetViewportShadingRatePaletteNV: The multiViewport feature is disabled, but viewportCount (=%" PRIu32
3369 ") is not 1.",
3370 viewportCount);
Jeff Bolz9af91c52018-09-01 21:53:57 -05003371 }
3372 }
3373
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003374 if (firstViewport >= device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003375 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewportShadingRatePaletteNV-firstViewport-02066",
3376 "vkCmdSetViewportShadingRatePaletteNV: firstViewport (=%" PRIu32
3377 ") must be less than maxViewports (=%" PRIu32 ").",
3378 firstViewport, device_limits.maxViewports);
Jeff Bolz9af91c52018-09-01 21:53:57 -05003379 }
3380
3381 const uint64_t sum = static_cast<uint64_t>(firstViewport) + static_cast<uint64_t>(viewportCount);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003382 if (sum > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003383 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewportShadingRatePaletteNV-firstViewport-02067",
3384 "vkCmdSetViewportShadingRatePaletteNV: firstViewport + viewportCount (=%" PRIu32 " + %" PRIu32
3385 " = %" PRIu64 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
3386 firstViewport, viewportCount, sum, device_limits.maxViewports);
Jeff Bolz9af91c52018-09-01 21:53:57 -05003387 }
3388
3389 return skip;
3390}
3391
Jeff Bolz5c801d12019-10-09 10:38:45 -05003392bool StatelessValidation::manual_PreCallValidateCmdSetCoarseSampleOrderNV(
3393 VkCommandBuffer commandBuffer, VkCoarseSampleOrderTypeNV sampleOrderType, uint32_t customSampleOrderCount,
3394 const VkCoarseSampleOrderCustomNV *pCustomSampleOrders) const {
Jeff Bolz9af91c52018-09-01 21:53:57 -05003395 bool skip = false;
3396
Dave Houlton142c4cb2018-10-17 15:04:41 -06003397 if (sampleOrderType != VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV && customSampleOrderCount != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003398 skip |= LogError(commandBuffer, "VUID-vkCmdSetCoarseSampleOrderNV-sampleOrderType-02081",
3399 "vkCmdSetCoarseSampleOrderNV: If sampleOrderType is not VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV, "
3400 "customSampleOrderCount must be 0.");
Jeff Bolz9af91c52018-09-01 21:53:57 -05003401 }
3402
3403 for (uint32_t order_i = 0; order_i < customSampleOrderCount; ++order_i) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003404 skip |= ValidateCoarseSampleOrderCustomNV(&pCustomSampleOrders[order_i]);
Jeff Bolz9af91c52018-09-01 21:53:57 -05003405 }
3406
3407 return skip;
3408}
3409
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003410bool StatelessValidation::manual_PreCallValidateCmdDrawMeshTasksNV(VkCommandBuffer commandBuffer, uint32_t taskCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003411 uint32_t firstTask) const {
Jeff Bolz45bf7d62018-09-18 15:39:58 -05003412 bool skip = false;
3413
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003414 if (taskCount > phys_dev_ext_props.mesh_shader_props.maxDrawMeshTasksCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003415 skip |= LogError(
3416 commandBuffer, "VUID-vkCmdDrawMeshTasksNV-taskCount-02119",
Dave Houlton142c4cb2018-10-17 15:04:41 -06003417 "vkCmdDrawMeshTasksNV() parameter, uint32_t taskCount (0x%" PRIxLEAST32
3418 "), must be less than or equal to VkPhysicalDeviceMeshShaderPropertiesNV::maxDrawMeshTasksCount (0x%" PRIxLEAST32 ").",
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003419 taskCount, phys_dev_ext_props.mesh_shader_props.maxDrawMeshTasksCount);
Jeff Bolz45bf7d62018-09-18 15:39:58 -05003420 }
3421
3422 return skip;
3423}
3424
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003425bool StatelessValidation::manual_PreCallValidateCmdDrawMeshTasksIndirectNV(VkCommandBuffer commandBuffer, VkBuffer buffer,
3426 VkDeviceSize offset, uint32_t drawCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003427 uint32_t stride) const {
Jeff Bolz45bf7d62018-09-18 15:39:58 -05003428 bool skip = false;
Lockee1c22882019-06-10 16:02:54 -06003429 static const int condition_multiples = 0b0011;
3430 if (offset & condition_multiples) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003431 skip |= LogError(
3432 commandBuffer, "VUID-vkCmdDrawMeshTasksIndirectNV-offset-02710",
Dave Houlton142c4cb2018-10-17 15:04:41 -06003433 "vkCmdDrawMeshTasksIndirectNV() parameter, VkDeviceSize offset (0x%" PRIxLEAST64 "), is not a multiple of 4.", offset);
Jeff Bolz45bf7d62018-09-18 15:39:58 -05003434 }
Lockee1c22882019-06-10 16:02:54 -06003435 if (drawCount > 1 && ((stride & condition_multiples) || stride < sizeof(VkDrawMeshTasksIndirectCommandNV))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003436 skip |= LogError(commandBuffer, "VUID-vkCmdDrawMeshTasksIndirectNV-drawCount-02146",
3437 "vkCmdDrawMeshTasksIndirectNV() parameter, uint32_t stride (0x%" PRIxLEAST32
3438 "), is not a multiple of 4 or smaller than sizeof (VkDrawMeshTasksIndirectCommandNV).",
3439 stride);
Lockee1c22882019-06-10 16:02:54 -06003440 }
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003441 if (!physical_device_features.multiDrawIndirect && ((drawCount > 1))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003442 skip |= LogError(
3443 commandBuffer, "VUID-vkCmdDrawMeshTasksIndirectNV-drawCount-02718",
3444 "vkCmdDrawMeshTasksIndirectNV(): Device feature multiDrawIndirect disabled: count must be 0 or 1 but is %d", drawCount);
Jeff Bolzb574c342018-11-08 15:36:57 -06003445 }
3446
Jeff Bolz45bf7d62018-09-18 15:39:58 -05003447 return skip;
3448}
3449
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003450bool StatelessValidation::manual_PreCallValidateCmdDrawMeshTasksIndirectCountNV(VkCommandBuffer commandBuffer, VkBuffer buffer,
3451 VkDeviceSize offset, VkBuffer countBuffer,
3452 VkDeviceSize countBufferOffset,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003453 uint32_t maxDrawCount, uint32_t stride) const {
Jeff Bolz45bf7d62018-09-18 15:39:58 -05003454 bool skip = false;
3455
Jeff Bolz45bf7d62018-09-18 15:39:58 -05003456 if (offset & 3) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003457 skip |= LogError(commandBuffer, "VUID-vkCmdDrawMeshTasksIndirectCountNV-offset-02710",
3458 "vkCmdDrawMeshTasksIndirectCountNV() parameter, VkDeviceSize offset (0x%" PRIxLEAST64
3459 "), is not a multiple of 4.",
3460 offset);
Jeff Bolz45bf7d62018-09-18 15:39:58 -05003461 }
3462
3463 if (countBufferOffset & 3) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003464 skip |= LogError(commandBuffer, "VUID-vkCmdDrawMeshTasksIndirectCountNV-countBufferOffset-02716",
3465 "vkCmdDrawMeshTasksIndirectCountNV() parameter, VkDeviceSize countBufferOffset (0x%" PRIxLEAST64
3466 "), is not a multiple of 4.",
3467 countBufferOffset);
Jeff Bolz45bf7d62018-09-18 15:39:58 -05003468 }
3469
Jeff Bolz45bf7d62018-09-18 15:39:58 -05003470 return skip;
3471}
3472
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003473bool StatelessValidation::manual_PreCallValidateCreateQueryPool(VkDevice device, const VkQueryPoolCreateInfo *pCreateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003474 const VkAllocationCallbacks *pAllocator,
3475 VkQueryPool *pQueryPool) const {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003476 bool skip = false;
3477
3478 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
3479 if (pCreateInfo != nullptr) {
3480 // If queryType is VK_QUERY_TYPE_PIPELINE_STATISTICS, pipelineStatistics must be a valid combination of
3481 // VkQueryPipelineStatisticFlagBits values
3482 if ((pCreateInfo->queryType == VK_QUERY_TYPE_PIPELINE_STATISTICS) && (pCreateInfo->pipelineStatistics != 0) &&
3483 ((pCreateInfo->pipelineStatistics & (~AllVkQueryPipelineStatisticFlagBits)) != 0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003484 skip |= LogError(device, "VUID-VkQueryPoolCreateInfo-queryType-00792",
3485 "vkCreateQueryPool(): if pCreateInfo->queryType is VK_QUERY_TYPE_PIPELINE_STATISTICS, "
3486 "pCreateInfo->pipelineStatistics must be a valid combination of VkQueryPipelineStatisticFlagBits "
3487 "values.");
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003488 }
Mark Lobodzinskib7a26382018-07-02 13:14:26 -06003489 }
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003490 return skip;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003491}
3492
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003493bool StatelessValidation::manual_PreCallValidateEnumerateDeviceExtensionProperties(VkPhysicalDevice physicalDevice,
3494 const char *pLayerName, uint32_t *pPropertyCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003495 VkExtensionProperties *pProperties) const {
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003496 return validate_array("vkEnumerateDeviceExtensionProperties", "pPropertyCount", "pProperties", pPropertyCount, &pProperties,
3497 true, false, false, kVUIDUndefined, "VUID-vkEnumerateDeviceExtensionProperties-pProperties-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003498}
3499
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003500void StatelessValidation::PostCallRecordCreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo,
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -07003501 const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass,
3502 VkResult result) {
3503 if (result != VK_SUCCESS) return;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003504 RecordRenderPass(*pRenderPass, pCreateInfo);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003505}
3506
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003507void StatelessValidation::PostCallRecordCreateRenderPass2KHR(VkDevice device, const VkRenderPassCreateInfo2KHR *pCreateInfo,
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -07003508 const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass,
3509 VkResult result) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003510 // Track the state necessary for checking vkCreateGraphicsPipeline (subpass usage of depth and color attachments)
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -07003511 if (result != VK_SUCCESS) return;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003512 RecordRenderPass(*pRenderPass, pCreateInfo);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003513}
3514
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003515void StatelessValidation::PostCallRecordDestroyRenderPass(VkDevice device, VkRenderPass renderPass,
3516 const VkAllocationCallbacks *pAllocator) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003517 // Track the state necessary for checking vkCreateGraphicsPipeline (subpass usage of depth and color attachments)
Mark Lobodzinskif27a6bc2019-02-04 13:00:49 -07003518 std::unique_lock<std::mutex> lock(renderpass_map_mutex);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003519 renderpasses_states.erase(renderPass);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003520}
Jeff Bolz7e7e6e02019-01-11 22:53:41 -06003521
3522bool StatelessValidation::manual_PreCallValidateAllocateMemory(VkDevice device, const VkMemoryAllocateInfo *pAllocateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003523 const VkAllocationCallbacks *pAllocator,
3524 VkDeviceMemory *pMemory) const {
Jeff Bolz7e7e6e02019-01-11 22:53:41 -06003525 bool skip = false;
3526
3527 if (pAllocateInfo) {
3528 auto chained_prio_struct = lvl_find_in_chain<VkMemoryPriorityAllocateInfoEXT>(pAllocateInfo->pNext);
3529 if (chained_prio_struct && (chained_prio_struct->priority < 0.0f || chained_prio_struct->priority > 1.0f)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003530 skip |= LogError(device, "VUID-VkMemoryPriorityAllocateInfoEXT-priority-02602",
3531 "priority (=%f) must be between `0` and `1`, inclusive.", chained_prio_struct->priority);
Jeff Bolz7e7e6e02019-01-11 22:53:41 -06003532 }
Jeff Bolz4563f2a2019-12-10 13:30:30 -06003533
3534 VkMemoryAllocateFlags flags = 0;
3535 auto flags_info = lvl_find_in_chain<VkMemoryAllocateFlagsInfo>(pAllocateInfo->pNext);
3536 if (flags_info) {
3537 flags = flags_info->flags;
3538 }
3539
3540 auto opaque_alloc_info = lvl_find_in_chain<VkMemoryOpaqueCaptureAddressAllocateInfoKHR>(pAllocateInfo->pNext);
3541 if (opaque_alloc_info && opaque_alloc_info->opaqueCaptureAddress != 0) {
3542 if (!(flags & VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT_KHR)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003543 skip |= LogError(device, "VUID-VkMemoryAllocateInfo-opaqueCaptureAddress-03329",
3544 "If opaqueCaptureAddress is non-zero, VkMemoryAllocateFlagsInfo::flags must include "
3545 "VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT_KHR.");
Jeff Bolz4563f2a2019-12-10 13:30:30 -06003546 }
3547
3548#ifdef VK_USE_PLATFORM_WIN32_KHR
3549 auto import_memory_win32_handle = lvl_find_in_chain<VkImportMemoryWin32HandleInfoKHR>(pAllocateInfo->pNext);
3550#endif
3551 auto import_memory_fd = lvl_find_in_chain<VkImportMemoryFdInfoKHR>(pAllocateInfo->pNext);
3552 auto import_memory_host_pointer = lvl_find_in_chain<VkImportMemoryHostPointerInfoEXT>(pAllocateInfo->pNext);
3553#ifdef VK_USE_PLATFORM_ANDROID_KHR
3554 auto import_memory_ahb = lvl_find_in_chain<VkImportAndroidHardwareBufferInfoANDROID>(pAllocateInfo->pNext);
3555#endif
3556
3557 if (import_memory_host_pointer) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003558 skip |= LogError(
3559 device, "VUID-VkMemoryAllocateInfo-pNext-03332",
Jeff Bolz4563f2a2019-12-10 13:30:30 -06003560 "If the pNext chain includes a VkImportMemoryHostPointerInfoEXT structure, opaqueCaptureAddress must be zero.");
3561 }
3562 if (
3563#ifdef VK_USE_PLATFORM_WIN32_KHR
3564 (import_memory_win32_handle && import_memory_win32_handle->handleType) ||
3565#endif
3566 (import_memory_fd && import_memory_fd->handleType) ||
3567#ifdef VK_USE_PLATFORM_ANDROID_KHR
3568 (import_memory_ahb && import_memory_ahb->buffer) ||
3569#endif
3570 (import_memory_host_pointer && import_memory_host_pointer->handleType)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003571 skip |= LogError(device, "VUID-VkMemoryAllocateInfo-opaqueCaptureAddress-03333",
3572 "If the parameters define an import operation, opaqueCaptureAddress must be zero.");
Jeff Bolz4563f2a2019-12-10 13:30:30 -06003573 }
3574 }
3575
3576 if (flags) {
Tony-LunarGa74d3fe2019-11-22 15:43:20 -07003577 VkBool32 capture_replay = false;
3578 VkBool32 buffer_device_address = false;
3579 const auto *vulkan_12_features = lvl_find_in_chain<VkPhysicalDeviceVulkan12Features>(device_createinfo_pnext);
3580 if (vulkan_12_features) {
3581 capture_replay = vulkan_12_features->bufferDeviceAddressCaptureReplay;
3582 buffer_device_address = vulkan_12_features->bufferDeviceAddress;
3583 } else {
3584 const auto *bda_features =
3585 lvl_find_in_chain<VkPhysicalDeviceBufferDeviceAddressFeaturesKHR>(device_createinfo_pnext);
3586 if (bda_features) {
3587 capture_replay = bda_features->bufferDeviceAddressCaptureReplay;
3588 buffer_device_address = bda_features->bufferDeviceAddress;
3589 }
3590 }
3591 if ((flags & VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT_KHR) && !capture_replay) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003592 skip |= LogError(device, "VUID-VkMemoryAllocateInfo-flags-03330",
3593 "If VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT_KHR is set, "
3594 "bufferDeviceAddressCaptureReplay must be enabled.");
Jeff Bolz4563f2a2019-12-10 13:30:30 -06003595 }
Tony-LunarGa74d3fe2019-11-22 15:43:20 -07003596 if ((flags & VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_BIT_KHR) && !buffer_device_address) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003597 skip |= LogError(device, "VUID-VkMemoryAllocateInfo-flags-03331",
3598 "If VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_BIT_KHR is set, bufferDeviceAddress must be enabled.");
Jeff Bolz4563f2a2019-12-10 13:30:30 -06003599 }
3600 }
Jeff Bolz7e7e6e02019-01-11 22:53:41 -06003601 }
3602 return skip;
3603}
Ricardo Garciaa4935972019-02-21 17:43:18 +01003604
Jason Macnak192fa0e2019-07-26 15:07:16 -07003605bool StatelessValidation::ValidateGeometryTrianglesNV(const VkGeometryTrianglesNV &triangles,
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003606 VkAccelerationStructureNV object_handle, const char *func_name) const {
Jason Macnak192fa0e2019-07-26 15:07:16 -07003607 bool skip = false;
3608
3609 if (triangles.vertexFormat != VK_FORMAT_R32G32B32_SFLOAT && triangles.vertexFormat != VK_FORMAT_R16G16B16_SFLOAT &&
3610 triangles.vertexFormat != VK_FORMAT_R16G16B16_SNORM && triangles.vertexFormat != VK_FORMAT_R32G32_SFLOAT &&
3611 triangles.vertexFormat != VK_FORMAT_R16G16_SFLOAT && triangles.vertexFormat != VK_FORMAT_R16G16_SNORM) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003612 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-vertexFormat-02430", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07003613 } else {
3614 uint32_t vertex_component_size = 0;
3615 if (triangles.vertexFormat == VK_FORMAT_R32G32B32_SFLOAT || triangles.vertexFormat == VK_FORMAT_R32G32_SFLOAT) {
3616 vertex_component_size = 4;
3617 } else if (triangles.vertexFormat == VK_FORMAT_R16G16B16_SFLOAT || triangles.vertexFormat == VK_FORMAT_R16G16B16_SNORM ||
3618 triangles.vertexFormat == VK_FORMAT_R16G16_SFLOAT || triangles.vertexFormat == VK_FORMAT_R16G16_SNORM) {
3619 vertex_component_size = 2;
3620 }
3621 if (vertex_component_size > 0 && SafeModulo(triangles.vertexOffset, vertex_component_size) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003622 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-vertexOffset-02429", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07003623 }
3624 }
3625
3626 if (triangles.indexType != VK_INDEX_TYPE_UINT32 && triangles.indexType != VK_INDEX_TYPE_UINT16 &&
3627 triangles.indexType != VK_INDEX_TYPE_NONE_NV) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003628 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-indexType-02433", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07003629 } else {
3630 uint32_t index_element_size = 0;
3631 if (triangles.indexType == VK_INDEX_TYPE_UINT32) {
3632 index_element_size = 4;
3633 } else if (triangles.indexType == VK_INDEX_TYPE_UINT16) {
3634 index_element_size = 2;
3635 }
3636 if (index_element_size > 0 && SafeModulo(triangles.indexOffset, index_element_size) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003637 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-indexOffset-02432", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07003638 }
3639 }
3640 if (triangles.indexType == VK_INDEX_TYPE_NONE_NV) {
3641 if (triangles.indexCount != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003642 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-indexCount-02436", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07003643 }
3644 if (triangles.indexData != VK_NULL_HANDLE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003645 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-indexData-02434", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07003646 }
3647 }
3648
3649 if (SafeModulo(triangles.transformOffset, 16) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003650 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-transformOffset-02438", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07003651 }
3652
3653 return skip;
3654}
3655
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003656bool StatelessValidation::ValidateGeometryAABBNV(const VkGeometryAABBNV &aabbs, VkAccelerationStructureNV object_handle,
3657 const char *func_name) const {
Jason Macnak192fa0e2019-07-26 15:07:16 -07003658 bool skip = false;
3659
3660 if (SafeModulo(aabbs.offset, 8) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003661 skip |= LogError(object_handle, "VUID-VkGeometryAABBNV-offset-02440", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07003662 }
3663 if (SafeModulo(aabbs.stride, 8) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003664 skip |= LogError(object_handle, "VUID-VkGeometryAABBNV-stride-02441", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07003665 }
3666
3667 return skip;
3668}
3669
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003670bool StatelessValidation::ValidateGeometryNV(const VkGeometryNV &geometry, VkAccelerationStructureNV object_handle,
3671 const char *func_name) const {
Jason Macnak192fa0e2019-07-26 15:07:16 -07003672 bool skip = false;
3673 if (geometry.geometryType == VK_GEOMETRY_TYPE_TRIANGLES_NV) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003674 skip = ValidateGeometryTrianglesNV(geometry.geometry.triangles, object_handle, func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07003675 } else if (geometry.geometryType == VK_GEOMETRY_TYPE_AABBS_NV) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003676 skip = ValidateGeometryAABBNV(geometry.geometry.aabbs, object_handle, func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07003677 }
3678 return skip;
3679}
3680
3681bool StatelessValidation::ValidateAccelerationStructureInfoNV(const VkAccelerationStructureInfoNV &info,
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003682 VkAccelerationStructureNV object_handle,
Jason Macnak192fa0e2019-07-26 15:07:16 -07003683 const char *func_name) const {
Jason Macnak5c954952019-07-09 15:46:12 -07003684 bool skip = false;
3685 if (info.type == VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_NV && info.geometryCount != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003686 skip |= LogError(object_handle, "VUID-VkAccelerationStructureInfoNV-type-02425",
3687 "VkAccelerationStructureInfoNV: If type is VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_NV then "
3688 "geometryCount must be 0.");
Jason Macnak5c954952019-07-09 15:46:12 -07003689 }
3690 if (info.type == VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_NV && info.instanceCount != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003691 skip |= LogError(object_handle, "VUID-VkAccelerationStructureInfoNV-type-02426",
3692 "VkAccelerationStructureInfoNV: If type is VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_NV then "
3693 "instanceCount must be 0.");
Jason Macnak5c954952019-07-09 15:46:12 -07003694 }
3695 if (info.flags & VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_TRACE_BIT_NV &&
3696 info.flags & VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_BUILD_BIT_NV) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003697 skip |= LogError(object_handle, "VUID-VkAccelerationStructureInfoNV-flags-02592",
3698 "VkAccelerationStructureInfoNV: If flags has the VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_TRACE_BIT_NV"
3699 "bit set, then it must not have the VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_BUILD_BIT_NV bit set.");
Jason Macnak5c954952019-07-09 15:46:12 -07003700 }
Jeff Bolz443c2ca2020-03-19 12:11:51 -05003701 if (info.geometryCount > phys_dev_ext_props.ray_tracing_propsNV.maxGeometryCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003702 skip |= LogError(object_handle, "VUID-VkAccelerationStructureInfoNV-geometryCount-02422",
3703 "VkAccelerationStructureInfoNV: geometryCount must be less than or equal to "
3704 "VkPhysicalDeviceRayTracingPropertiesNV::maxGeometryCount.");
Jason Macnak5c954952019-07-09 15:46:12 -07003705 }
Jeff Bolz443c2ca2020-03-19 12:11:51 -05003706 if (info.instanceCount > phys_dev_ext_props.ray_tracing_propsNV.maxInstanceCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003707 skip |= LogError(object_handle, "VUID-VkAccelerationStructureInfoNV-instanceCount-02423",
3708 "VkAccelerationStructureInfoNV: instanceCount must be less than or equal to "
3709 "VkPhysicalDeviceRayTracingPropertiesNV::maxInstanceCount.");
Jason Macnak5c954952019-07-09 15:46:12 -07003710 }
Jason Macnak21ba97e2019-08-09 12:57:44 -07003711 if (info.type == VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_NV && info.geometryCount > 0) {
Jason Macnak5c954952019-07-09 15:46:12 -07003712 uint64_t total_triangle_count = 0;
3713 for (uint32_t i = 0; i < info.geometryCount; i++) {
3714 const VkGeometryNV &geometry = info.pGeometries[i];
Jason Macnak192fa0e2019-07-26 15:07:16 -07003715
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003716 skip |= ValidateGeometryNV(geometry, object_handle, func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07003717
Jason Macnak5c954952019-07-09 15:46:12 -07003718 if (geometry.geometryType != VK_GEOMETRY_TYPE_TRIANGLES_NV) {
3719 continue;
3720 }
3721 total_triangle_count += geometry.geometry.triangles.indexCount / 3;
3722 }
Jeff Bolz443c2ca2020-03-19 12:11:51 -05003723 if (total_triangle_count > phys_dev_ext_props.ray_tracing_propsNV.maxTriangleCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003724 skip |= LogError(object_handle, "VUID-VkAccelerationStructureInfoNV-maxTriangleCount-02424",
3725 "VkAccelerationStructureInfoNV: The total number of triangles in all geometries must be less than "
3726 "or equal to VkPhysicalDeviceRayTracingPropertiesNV::maxTriangleCount.");
Jason Macnak5c954952019-07-09 15:46:12 -07003727 }
3728 }
Jason Macnak21ba97e2019-08-09 12:57:44 -07003729 if (info.type == VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_NV && info.geometryCount > 1) {
3730 const VkGeometryTypeNV first_geometry_type = info.pGeometries[0].geometryType;
3731 for (uint32_t i = 1; i < info.geometryCount; i++) {
3732 const VkGeometryNV &geometry = info.pGeometries[i];
3733 if (geometry.geometryType != first_geometry_type) {
Jeff Bolz443c2ca2020-03-19 12:11:51 -05003734 skip |= LogError(device, "VUID-VkAccelerationStructureInfoNV-type-02786",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003735 "VkAccelerationStructureInfoNV: info.pGeometries[%d].geometryType does not match "
3736 "info.pGeometries[0].geometryType.",
3737 i);
Jason Macnak21ba97e2019-08-09 12:57:44 -07003738 }
3739 }
3740 }
Jason Macnak5c954952019-07-09 15:46:12 -07003741 return skip;
3742}
3743
Ricardo Garciaa4935972019-02-21 17:43:18 +01003744bool StatelessValidation::manual_PreCallValidateCreateAccelerationStructureNV(
3745 VkDevice device, const VkAccelerationStructureCreateInfoNV *pCreateInfo, const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003746 VkAccelerationStructureNV *pAccelerationStructure) const {
Ricardo Garciaa4935972019-02-21 17:43:18 +01003747 bool skip = false;
3748
3749 if (pCreateInfo) {
3750 if ((pCreateInfo->compactedSize != 0) &&
3751 ((pCreateInfo->info.geometryCount != 0) || (pCreateInfo->info.instanceCount != 0))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003752 skip |= LogError(device, "VUID-VkAccelerationStructureCreateInfoNV-compactedSize-02421",
3753 "vkCreateAccelerationStructureNV(): pCreateInfo->compactedSize nonzero (%" PRIu64
3754 ") with info.geometryCount (%" PRIu32 ") or info.instanceCount (%" PRIu32 ") nonzero.",
3755 pCreateInfo->compactedSize, pCreateInfo->info.geometryCount, pCreateInfo->info.instanceCount);
Ricardo Garciaa4935972019-02-21 17:43:18 +01003756 }
Jason Macnak5c954952019-07-09 15:46:12 -07003757
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003758 skip |= ValidateAccelerationStructureInfoNV(pCreateInfo->info, VkAccelerationStructureNV(0),
Jason Macnak192fa0e2019-07-26 15:07:16 -07003759 "vkCreateAccelerationStructureNV()");
Ricardo Garciaa4935972019-02-21 17:43:18 +01003760 }
3761
3762 return skip;
3763}
Mike Schuchardt21638df2019-03-16 10:52:02 -07003764
Jeff Bolz5c801d12019-10-09 10:38:45 -05003765bool StatelessValidation::manual_PreCallValidateCmdBuildAccelerationStructureNV(VkCommandBuffer commandBuffer,
3766 const VkAccelerationStructureInfoNV *pInfo,
3767 VkBuffer instanceData, VkDeviceSize instanceOffset,
3768 VkBool32 update, VkAccelerationStructureNV dst,
3769 VkAccelerationStructureNV src, VkBuffer scratch,
3770 VkDeviceSize scratchOffset) const {
Jason Macnak5c954952019-07-09 15:46:12 -07003771 bool skip = false;
3772
3773 if (pInfo != nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003774 skip |= ValidateAccelerationStructureInfoNV(*pInfo, dst, "vkCmdBuildAccelerationStructureNV()");
Jason Macnak5c954952019-07-09 15:46:12 -07003775 }
3776
3777 return skip;
3778}
3779
Jeff Bolz443c2ca2020-03-19 12:11:51 -05003780bool StatelessValidation::manual_PreCallValidateCreateAccelerationStructureKHR(
3781 VkDevice device, const VkAccelerationStructureCreateInfoKHR *pCreateInfo, const VkAllocationCallbacks *pAllocator,
3782 VkAccelerationStructureKHR *pAccelerationStructure) const {
3783 bool skip = false;
3784
3785 if (pCreateInfo) {
3786 for (uint32_t i = 0; i < pCreateInfo->maxGeometryCount; ++i) {
3787 if (pCreateInfo->type == VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_KHR && pCreateInfo->compactedSize == 0) {
3788 if (pCreateInfo->pGeometryInfos[i].geometryType != VK_GEOMETRY_TYPE_INSTANCES_KHR) {
3789 skip |= LogError(device, "VUID-VkAccelerationStructureCreateInfoKHR-type-03496",
3790 "VkAccelerationStructureCreateInfoKHR: Top-level acceleration structure "
3791 "pGeometryInfos[%d].geometryType must be VK_GEOMETRY_TYPE_INSTANCES_KHR",
3792 i);
3793 }
3794 }
3795
3796 if (pCreateInfo->type == VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_KHR && pCreateInfo->compactedSize == 0) {
3797 if (pCreateInfo->pGeometryInfos[i].geometryType == VK_GEOMETRY_TYPE_INSTANCES_KHR) {
3798 skip |= LogError(device, "VUID-VkAccelerationStructureCreateInfoKHR-type-03497",
3799 "VkAccelerationStructureCreateInfoKHR: Bottom-level acceleration structure "
3800 "pGeometryInfos[%d].geometryType must not be VK_GEOMETRY_TYPE_INSTANCES_KHR",
3801 i);
3802 }
3803 }
3804 }
3805
3806 if (pCreateInfo->flags & VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_TRACE_BIT_KHR &&
3807 pCreateInfo->flags & VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_BUILD_BIT_KHR) {
3808 skip |= LogError(
3809 device, "VUID-VkAccelerationStructureCreateInfoKHR-flags-03499",
3810 "VkAccelerationStructureCreateInfoKHR: If flags has the VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_TRACE_BIT_KHR"
3811 "bit set, then it must not have the VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_BUILD_BIT_KHR bit set.");
3812 }
3813
3814 if (pCreateInfo->compactedSize != 0 && pCreateInfo->maxGeometryCount != 0) {
3815 skip |= LogError(device, "VUID-VkAccelerationStructureCreateInfoKHR-compactedSize-03490",
3816 "VkAccelerationStructureCreateInfoKHR: pCreateInfo->compactedSize nonzero (%" PRIu64
3817 ") with maxGeometryCount (%" PRIu32 ") nonzero.",
3818 pCreateInfo->compactedSize, pCreateInfo->maxGeometryCount);
3819 }
3820
3821 if (pCreateInfo->type == VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_NV && pCreateInfo->maxGeometryCount > 1) {
3822 const VkGeometryTypeKHR first_geometry_type = pCreateInfo->pGeometryInfos[0].geometryType;
3823 for (uint32_t i = 1; i < pCreateInfo->maxGeometryCount; i++) {
3824 const VkGeometryTypeKHR geometry_type = pCreateInfo->pGeometryInfos[i].geometryType;
3825 if (geometry_type != first_geometry_type) {
3826 skip |= LogError(device, "VUID-VkAccelerationStructureCreateInfoKHR-type-03498",
3827 "VkAccelerationStructureCreateInfoKHR: pGeometryInfos[%d].geometryType does not match "
3828 "pGeometryInfos[0].geometryType.",
3829 i);
3830 }
3831 }
3832 }
3833 }
3834
3835 return skip;
3836}
3837
Jason Macnak5c954952019-07-09 15:46:12 -07003838bool StatelessValidation::manual_PreCallValidateGetAccelerationStructureHandleNV(VkDevice device,
3839 VkAccelerationStructureNV accelerationStructure,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003840 size_t dataSize, void *pData) const {
Jason Macnak5c954952019-07-09 15:46:12 -07003841 bool skip = false;
3842 if (dataSize < 8) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003843 skip = LogError(accelerationStructure, "VUID-vkGetAccelerationStructureHandleNV-dataSize-02240",
3844 "vkGetAccelerationStructureHandleNV(): dataSize must be greater than or equal to 8.");
Jason Macnak5c954952019-07-09 15:46:12 -07003845 }
3846 return skip;
3847}
3848
Peter Chen85366392019-05-14 15:20:11 -04003849bool StatelessValidation::manual_PreCallValidateCreateRayTracingPipelinesNV(VkDevice device, VkPipelineCache pipelineCache,
3850 uint32_t createInfoCount,
3851 const VkRayTracingPipelineCreateInfoNV *pCreateInfos,
3852 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003853 VkPipeline *pPipelines) const {
Peter Chen85366392019-05-14 15:20:11 -04003854 bool skip = false;
3855
3856 for (uint32_t i = 0; i < createInfoCount; i++) {
3857 auto feedback_struct = lvl_find_in_chain<VkPipelineCreationFeedbackCreateInfoEXT>(pCreateInfos[i].pNext);
3858 if ((feedback_struct != nullptr) && (feedback_struct->pipelineStageCreationFeedbackCount != pCreateInfos[i].stageCount)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003859 skip |= LogError(device, "VUID-VkPipelineCreationFeedbackCreateInfoEXT-pipelineStageCreationFeedbackCount-02670",
3860 "vkCreateRayTracingPipelinesNV(): in pCreateInfo[%" PRIu32
3861 "], VkPipelineCreationFeedbackEXT::pipelineStageCreationFeedbackCount"
3862 "(=%" PRIu32 ") must equal VkRayTracingPipelineCreateInfoNV::stageCount(=%" PRIu32 ").",
3863 i, feedback_struct->pipelineStageCreationFeedbackCount, pCreateInfos[i].stageCount);
Peter Chen85366392019-05-14 15:20:11 -04003864 }
3865 }
3866
3867 return skip;
3868}
3869
Jeff Bolz443c2ca2020-03-19 12:11:51 -05003870bool StatelessValidation::manual_PreCallValidateCreateRayTracingPipelinesKHR(VkDevice device, VkPipelineCache pipelineCache,
3871 uint32_t createInfoCount,
3872 const VkRayTracingPipelineCreateInfoKHR *pCreateInfos,
3873 const VkAllocationCallbacks *pAllocator,
3874 VkPipeline *pPipelines) const {
3875 bool skip = false;
3876
3877 for (uint32_t i = 0; i < createInfoCount; i++) {
3878 auto feedback_struct = lvl_find_in_chain<VkPipelineCreationFeedbackCreateInfoEXT>(pCreateInfos[i].pNext);
3879 if ((feedback_struct != nullptr) && (feedback_struct->pipelineStageCreationFeedbackCount != pCreateInfos[i].stageCount)) {
3880 skip |= LogError(device, "VUID-VkPipelineCreationFeedbackCreateInfoEXT-pipelineStageCreationFeedbackCount-02670",
3881 "vkCreateRayTracingPipelinesKHR(): in pCreateInfo[%" PRIu32
3882 "], VkPipelineCreationFeedbackEXT::pipelineStageCreationFeedbackCount"
3883 "(=%" PRIu32 ") must equal VkRayTracingPipelineCreateInfoKHR::stageCount(=%" PRIu32 ").",
3884 i, feedback_struct->pipelineStageCreationFeedbackCount, pCreateInfos[i].stageCount);
3885 }
3886 }
3887
3888 return skip;
3889}
3890
Mike Schuchardt21638df2019-03-16 10:52:02 -07003891#ifdef VK_USE_PLATFORM_WIN32_KHR
3892bool StatelessValidation::PreCallValidateGetDeviceGroupSurfacePresentModes2EXT(VkDevice device,
3893 const VkPhysicalDeviceSurfaceInfo2KHR *pSurfaceInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003894 VkDeviceGroupPresentModeFlagsKHR *pModes) const {
Mike Schuchardt21638df2019-03-16 10:52:02 -07003895 bool skip = false;
3896 if (!device_extensions.vk_khr_swapchain)
3897 skip |= OutputExtensionError("vkGetDeviceGroupSurfacePresentModes2EXT", VK_KHR_SWAPCHAIN_EXTENSION_NAME);
3898 if (!device_extensions.vk_khr_get_surface_capabilities_2)
3899 skip |= OutputExtensionError("vkGetDeviceGroupSurfacePresentModes2EXT", VK_KHR_GET_SURFACE_CAPABILITIES_2_EXTENSION_NAME);
3900 if (!device_extensions.vk_khr_surface)
3901 skip |= OutputExtensionError("vkGetDeviceGroupSurfacePresentModes2EXT", VK_KHR_SURFACE_EXTENSION_NAME);
3902 if (!device_extensions.vk_khr_get_physical_device_properties_2)
3903 skip |=
3904 OutputExtensionError("vkGetDeviceGroupSurfacePresentModes2EXT", VK_KHR_GET_PHYSICAL_DEVICE_PROPERTIES_2_EXTENSION_NAME);
3905 if (!device_extensions.vk_ext_full_screen_exclusive)
3906 skip |= OutputExtensionError("vkGetDeviceGroupSurfacePresentModes2EXT", VK_EXT_FULL_SCREEN_EXCLUSIVE_EXTENSION_NAME);
3907 skip |= validate_struct_type(
3908 "vkGetDeviceGroupSurfacePresentModes2EXT", "pSurfaceInfo", "VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SURFACE_INFO_2_KHR",
3909 pSurfaceInfo, VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SURFACE_INFO_2_KHR, true,
3910 "VUID-vkGetDeviceGroupSurfacePresentModes2EXT-pSurfaceInfo-parameter", "VUID-VkPhysicalDeviceSurfaceInfo2KHR-sType-sType");
3911 if (pSurfaceInfo != NULL) {
3912 const VkStructureType allowed_structs_VkPhysicalDeviceSurfaceInfo2KHR[] = {
3913 VK_STRUCTURE_TYPE_SURFACE_FULL_SCREEN_EXCLUSIVE_INFO_EXT,
3914 VK_STRUCTURE_TYPE_SURFACE_FULL_SCREEN_EXCLUSIVE_WIN32_INFO_EXT};
3915
3916 skip |= validate_struct_pnext("vkGetDeviceGroupSurfacePresentModes2EXT", "pSurfaceInfo->pNext",
3917 "VkSurfaceFullScreenExclusiveInfoEXT, VkSurfaceFullScreenExclusiveWin32InfoEXT",
3918 pSurfaceInfo->pNext, ARRAY_SIZE(allowed_structs_VkPhysicalDeviceSurfaceInfo2KHR),
3919 allowed_structs_VkPhysicalDeviceSurfaceInfo2KHR, GeneratedVulkanHeaderVersion,
sfricke-samsung32a27362020-02-28 09:06:42 -08003920 "VUID-VkPhysicalDeviceSurfaceInfo2KHR-pNext-pNext",
3921 "VUID-VkPhysicalDeviceSurfaceInfo2KHR-sType-unique");
Mike Schuchardt21638df2019-03-16 10:52:02 -07003922
3923 skip |= validate_required_handle("vkGetDeviceGroupSurfacePresentModes2EXT", "pSurfaceInfo->surface", pSurfaceInfo->surface);
3924 }
3925 return skip;
3926}
3927#endif
Tobias Hectorebb855f2019-07-23 12:17:33 +01003928
3929bool StatelessValidation::manual_PreCallValidateCreateFramebuffer(VkDevice device, const VkFramebufferCreateInfo *pCreateInfo,
3930 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003931 VkFramebuffer *pFramebuffer) const {
Tobias Hectorebb855f2019-07-23 12:17:33 +01003932 // Validation for pAttachments which is excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
3933 bool skip = false;
3934 if ((pCreateInfo->flags & VK_FRAMEBUFFER_CREATE_IMAGELESS_BIT_KHR) == 0) {
3935 skip |= validate_array("vkCreateFramebuffer", "attachmentCount", "pAttachments", pCreateInfo->attachmentCount,
3936 &pCreateInfo->pAttachments, false, true, kVUIDUndefined, kVUIDUndefined);
3937 }
3938 return skip;
3939}
Jeff Bolz8125a8b2019-08-16 16:29:45 -05003940
3941bool StatelessValidation::manual_PreCallValidateCmdSetLineStippleEXT(VkCommandBuffer commandBuffer, uint32_t lineStippleFactor,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003942 uint16_t lineStipplePattern) const {
Jeff Bolz8125a8b2019-08-16 16:29:45 -05003943 bool skip = false;
3944
3945 if (lineStippleFactor < 1 || lineStippleFactor > 256) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003946 skip |= LogError(commandBuffer, "VUID-vkCmdSetLineStippleEXT-lineStippleFactor-02776",
3947 "vkCmdSetLineStippleEXT::lineStippleFactor=%d is not in [1,256].", lineStippleFactor);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05003948 }
3949
3950 return skip;
3951}
Piers Daniell8fd03f52019-08-21 12:07:53 -06003952
3953bool StatelessValidation::manual_PreCallValidateCmdBindIndexBuffer(VkCommandBuffer commandBuffer, VkBuffer buffer,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003954 VkDeviceSize offset, VkIndexType indexType) const {
Piers Daniell8fd03f52019-08-21 12:07:53 -06003955 bool skip = false;
3956
3957 if (indexType == VK_INDEX_TYPE_NONE_NV) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003958 skip |= LogError(commandBuffer, "VUID-vkCmdBindIndexBuffer-indexType-02507",
3959 "vkCmdBindIndexBuffer() indexType must not be VK_INDEX_TYPE_NONE_NV.");
Piers Daniell8fd03f52019-08-21 12:07:53 -06003960 }
3961
Tony-LunarG6c3c5452019-12-13 10:37:38 -07003962 const auto *index_type_uint8_features = lvl_find_in_chain<VkPhysicalDeviceIndexTypeUint8FeaturesEXT>(device_createinfo_pnext);
Piers Daniell8fd03f52019-08-21 12:07:53 -06003963 if (indexType == VK_INDEX_TYPE_UINT8_EXT && !index_type_uint8_features->indexTypeUint8) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003964 skip |= LogError(commandBuffer, "VUID-vkCmdBindIndexBuffer-indexType-02765",
3965 "vkCmdBindIndexBuffer() indexType is VK_INDEX_TYPE_UINT8_EXT but indexTypeUint8 feature is not enabled.");
Piers Daniell8fd03f52019-08-21 12:07:53 -06003966 }
3967
3968 return skip;
3969}
Mark Lobodzinski84988402019-09-11 15:27:30 -06003970
sfricke-samsung4ada8d42020-02-09 17:43:11 -08003971bool StatelessValidation::manual_PreCallValidateCmdBindVertexBuffers(VkCommandBuffer commandBuffer, uint32_t firstBinding,
3972 uint32_t bindingCount, const VkBuffer *pBuffers,
3973 const VkDeviceSize *pOffsets) const {
3974 bool skip = false;
3975 if (firstBinding > device_limits.maxVertexInputBindings) {
3976 skip |= LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers-firstBinding-00624",
3977 "vkCmdBindVertexBuffers() firstBinding (%u) must be less than maxVertexInputBindings (%u)", firstBinding,
3978 device_limits.maxVertexInputBindings);
3979 } else if ((firstBinding + bindingCount) > device_limits.maxVertexInputBindings) {
3980 skip |= LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers-firstBinding-00625",
3981 "vkCmdBindVertexBuffers() sum of firstBinding (%u) and bindingCount (%u) must be less than "
3982 "maxVertexInputBindings (%u)",
3983 firstBinding, bindingCount, device_limits.maxVertexInputBindings);
3984 }
3985
3986 return skip;
3987}
3988
Mark Lobodzinski84988402019-09-11 15:27:30 -06003989bool StatelessValidation::manual_PreCallValidateSetDebugUtilsObjectNameEXT(VkDevice device,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003990 const VkDebugUtilsObjectNameInfoEXT *pNameInfo) const {
Mark Lobodzinski84988402019-09-11 15:27:30 -06003991 bool skip = false;
3992 if (pNameInfo->objectType == VK_OBJECT_TYPE_UNKNOWN) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003993 skip |= LogError(device, "VUID-VkDebugUtilsObjectNameInfoEXT-objectType-02589",
3994 "vkSetDebugUtilsObjectNameEXT() pNameInfo->objectType cannot be VK_OBJECT_TYPE_UNKNOWN.");
Mark Lobodzinski84988402019-09-11 15:27:30 -06003995 }
3996 return skip;
3997}
3998
3999bool StatelessValidation::manual_PreCallValidateSetDebugUtilsObjectTagEXT(VkDevice device,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004000 const VkDebugUtilsObjectTagInfoEXT *pTagInfo) const {
Mark Lobodzinski84988402019-09-11 15:27:30 -06004001 bool skip = false;
4002 if (pTagInfo->objectType == VK_OBJECT_TYPE_UNKNOWN) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004003 skip |= LogError(device, "VUID-VkDebugUtilsObjectTagInfoEXT-objectType-01908",
4004 "vkSetDebugUtilsObjectTagEXT() pTagInfo->objectType cannot be VK_OBJECT_TYPE_UNKNOWN.");
Mark Lobodzinski84988402019-09-11 15:27:30 -06004005 }
4006 return skip;
4007}
Petr Kraus3d720392019-11-13 02:52:39 +01004008
4009bool StatelessValidation::manual_PreCallValidateAcquireNextImageKHR(VkDevice device, VkSwapchainKHR swapchain, uint64_t timeout,
4010 VkSemaphore semaphore, VkFence fence,
4011 uint32_t *pImageIndex) const {
4012 bool skip = false;
4013
4014 if (semaphore == VK_NULL_HANDLE && fence == VK_NULL_HANDLE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004015 skip |= LogError(swapchain, "VUID-vkAcquireNextImageKHR-semaphore-01780",
4016 "vkAcquireNextImageKHR: semaphore and fence are both VK_NULL_HANDLE.");
Petr Kraus3d720392019-11-13 02:52:39 +01004017 }
4018
4019 return skip;
4020}
4021
4022bool StatelessValidation::manual_PreCallValidateAcquireNextImage2KHR(VkDevice device, const VkAcquireNextImageInfoKHR *pAcquireInfo,
4023 uint32_t *pImageIndex) const {
4024 bool skip = false;
4025
4026 if (pAcquireInfo->semaphore == VK_NULL_HANDLE && pAcquireInfo->fence == VK_NULL_HANDLE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004027 skip |= LogError(pAcquireInfo->swapchain, "VUID-VkAcquireNextImageInfoKHR-semaphore-01782",
4028 "vkAcquireNextImage2KHR: pAcquireInfo->semaphore and pAcquireInfo->fence are both VK_NULL_HANDLE.");
Petr Kraus3d720392019-11-13 02:52:39 +01004029 }
4030
4031 return skip;
4032}
Mark Lobodzinski953b7bc2019-12-19 13:50:10 -07004033
4034bool StatelessValidation::manual_PreCallValidateCmdDrawIndirectByteCountEXT(VkCommandBuffer commandBuffer, uint32_t instanceCount,
4035 uint32_t firstInstance, VkBuffer counterBuffer,
4036 VkDeviceSize counterBufferOffset,
4037 uint32_t counterOffset, uint32_t vertexStride) const {
4038 bool skip = false;
4039
4040 if ((vertexStride <= 0) || (vertexStride > phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBufferDataStride)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004041 skip |= LogError(
4042 counterBuffer, "VUID-vkCmdDrawIndirectByteCountEXT-vertexStride-02289",
Mark Lobodzinski953b7bc2019-12-19 13:50:10 -07004043 "vkCmdDrawIndirectByteCountEXT: vertexStride (%d) must be between 0 and maxTransformFeedbackBufferDataStride (%d).",
4044 vertexStride, phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBufferDataStride);
4045 }
4046
4047 return skip;
4048}
sfricke-samsung11ea8ed2020-01-07 22:24:56 -08004049
4050bool StatelessValidation::ValidateCreateSamplerYcbcrConversion(VkDevice device,
4051 const VkSamplerYcbcrConversionCreateInfo *pCreateInfo,
4052 const VkAllocationCallbacks *pAllocator,
4053 VkSamplerYcbcrConversion *pYcbcrConversion,
4054 const char *apiName) const {
4055 bool skip = false;
4056
4057 // Check samplerYcbcrConversion feature is set
Tony-LunarG6c3c5452019-12-13 10:37:38 -07004058 const auto *ycbcr_features = lvl_find_in_chain<VkPhysicalDeviceSamplerYcbcrConversionFeatures>(device_createinfo_pnext);
sfricke-samsung11ea8ed2020-01-07 22:24:56 -08004059 if ((ycbcr_features == nullptr) || (ycbcr_features->samplerYcbcrConversion == VK_FALSE)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004060 skip |= LogError(device, "VUID-vkCreateSamplerYcbcrConversion-None-01648",
4061 "samplerYcbcrConversion must be enabled to call %s.", apiName);
sfricke-samsung11ea8ed2020-01-07 22:24:56 -08004062 }
4063 return skip;
4064}
4065
4066bool StatelessValidation::manual_PreCallValidateCreateSamplerYcbcrConversion(VkDevice device,
4067 const VkSamplerYcbcrConversionCreateInfo *pCreateInfo,
4068 const VkAllocationCallbacks *pAllocator,
4069 VkSamplerYcbcrConversion *pYcbcrConversion) const {
4070 return ValidateCreateSamplerYcbcrConversion(device, pCreateInfo, pAllocator, pYcbcrConversion,
4071 "vkCreateSamplerYcbcrConversion");
4072}
4073
4074bool StatelessValidation::manual_PreCallValidateCreateSamplerYcbcrConversionKHR(
4075 VkDevice device, const VkSamplerYcbcrConversionCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
4076 VkSamplerYcbcrConversion *pYcbcrConversion) const {
4077 return ValidateCreateSamplerYcbcrConversion(device, pCreateInfo, pAllocator, pYcbcrConversion,
4078 "vkCreateSamplerYcbcrConversionKHR");
4079}
sfricke-samsung1708a8c2020-02-10 00:35:06 -08004080
4081bool StatelessValidation::manual_PreCallValidateImportSemaphoreFdKHR(
4082 VkDevice device, const VkImportSemaphoreFdInfoKHR *pImportSemaphoreFdInfo) const {
4083 bool skip = false;
4084 VkExternalSemaphoreHandleTypeFlags supported_handle_types =
4085 VK_EXTERNAL_SEMAPHORE_HANDLE_TYPE_OPAQUE_FD_BIT | VK_EXTERNAL_SEMAPHORE_HANDLE_TYPE_SYNC_FD_BIT;
4086
4087 if (0 == (pImportSemaphoreFdInfo->handleType & supported_handle_types)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004088 skip |= LogError(device, "VUID-VkImportSemaphoreFdInfoKHR-handleType-01143",
4089 "vkImportSemaphoreFdKHR() to semaphore %s handleType %s is not one of the supported handleTypes (%s).",
4090 report_data->FormatHandle(pImportSemaphoreFdInfo->semaphore).c_str(),
4091 string_VkExternalSemaphoreHandleTypeFlagBits(pImportSemaphoreFdInfo->handleType),
4092 string_VkExternalSemaphoreHandleTypeFlags(supported_handle_types).c_str());
sfricke-samsung1708a8c2020-02-10 00:35:06 -08004093 }
4094 return skip;
4095}