blob: 69116ec5c5887f408a3cc6d40abd81a625fa6e00 [file] [log] [blame]
Mark Lobodzinskic0df6b62021-01-08 12:34:11 -07001/* Copyright (c) 2015-2021 The Khronos Group Inc.
2 * Copyright (c) 2015-2021 Valve Corporation
3 * Copyright (c) 2015-2021 LunarG, Inc.
4 * Copyright (C) 2015-2021 Google Inc.
Mark Lobodzinskid4950072017-08-01 13:02:20 -06005 *
6 * Licensed under the Apache License, Version 2.0 (the "License");
7 * you may not use this file except in compliance with the License.
8 * You may obtain a copy of the License at
9 *
10 * http://www.apache.org/licenses/LICENSE-2.0
11 *
12 * Unless required by applicable law or agreed to in writing, software
13 * distributed under the License is distributed on an "AS IS" BASIS,
14 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15 * See the License for the specific language governing permissions and
16 * limitations under the License.
17 *
18 * Author: Mark Lobodzinski <mark@LunarG.com>
John Zulaufa999d1b2018-11-29 13:38:40 -070019 * Author: John Zulauf <jzulauf@lunarg.com>
Mark Lobodzinskid4950072017-08-01 13:02:20 -060020 */
21
orbea80ddc062019-09-10 10:33:19 -070022#include <cmath>
Shahbaz Youssefi6be11412019-01-10 15:29:30 -050023
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -070024#include "chassis.h"
25#include "stateless_validation.h"
Mark Lobodzinskie514d1a2019-03-12 08:47:45 -060026#include "layer_chassis_dispatch.h"
Tobias Hectord942eb92018-10-22 15:18:56 +010027
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -070028static const int kMaxParamCheckerStringLength = 256;
Mark Lobodzinskid4950072017-08-01 13:02:20 -060029
John Zulauf71968502017-10-26 13:51:15 -060030template <typename T>
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -070031inline bool in_inclusive_range(const T &value, const T &min, const T &max) {
John Zulauf71968502017-10-26 13:51:15 -060032 // Using only < for generality and || for early abort
33 return !((value < min) || (max < value));
34}
35
Mark Lobodzinski21b91fe2020-12-03 15:44:24 -070036read_lock_guard_t StatelessValidation::read_lock() { return read_lock_guard_t(validation_object_mutex, std::defer_lock); }
37write_lock_guard_t StatelessValidation::write_lock() { return write_lock_guard_t(validation_object_mutex, std::defer_lock); }
38
Tony-LunarG3c287f62020-12-17 12:39:49 -070039static std::unordered_map<VkCommandBuffer, VkCommandPool> secondary_cb_map{};
40static ReadWriteLock secondary_cb_map_mutex;
Mark Lobodzinski1f887d32020-12-30 15:31:33 -070041static read_lock_guard_t cb_read_lock() { return read_lock_guard_t(secondary_cb_map_mutex); }
42static write_lock_guard_t cb_write_lock() { return write_lock_guard_t(secondary_cb_map_mutex); }
Tony-LunarG3c287f62020-12-17 12:39:49 -070043
Mark Lobodzinskibf599b92018-12-31 12:15:55 -070044bool StatelessValidation::validate_string(const char *apiName, const ParameterName &stringName, const std::string &vuid,
Jeff Bolz46c0ea02019-10-09 13:06:29 -050045 const char *validateString) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -060046 bool skip = false;
47
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -070048 VkStringErrorFlags result = vk_string_validate(kMaxParamCheckerStringLength, validateString);
Mark Lobodzinskid4950072017-08-01 13:02:20 -060049
50 if (result == VK_STRING_ERROR_NONE) {
51 return skip;
52 } else if (result & VK_STRING_ERROR_LENGTH) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -070053 skip = LogError(device, vuid, "%s: string %s exceeds max length %d", apiName, stringName.get_name().c_str(),
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -070054 kMaxParamCheckerStringLength);
Mark Lobodzinskid4950072017-08-01 13:02:20 -060055 } else if (result & VK_STRING_ERROR_BAD_DATA) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -070056 skip = LogError(device, vuid, "%s: string %s contains invalid characters or is badly formed", apiName,
57 stringName.get_name().c_str());
Mark Lobodzinskid4950072017-08-01 13:02:20 -060058 }
59 return skip;
60}
61
Jeff Bolz46c0ea02019-10-09 13:06:29 -050062bool StatelessValidation::validate_api_version(uint32_t api_version, uint32_t effective_api_version) const {
John Zulauf620755c2018-04-16 11:00:43 -060063 bool skip = false;
64 uint32_t api_version_nopatch = VK_MAKE_VERSION(VK_VERSION_MAJOR(api_version), VK_VERSION_MINOR(api_version), 0);
65 if (api_version_nopatch != effective_api_version) {
sfricke-samsung6aec21b2020-11-01 07:49:43 -080066 if ((api_version_nopatch < VK_API_VERSION_1_0) && (api_version != 0)) {
67 skip |= LogError(instance, "VUID-VkApplicationInfo-apiVersion-04010",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -070068 "Invalid CreateInstance->pCreateInfo->pApplicationInfo.apiVersion number (0x%08x). "
69 "Using VK_API_VERSION_%" PRIu32 "_%" PRIu32 ".",
70 api_version, VK_VERSION_MAJOR(effective_api_version), VK_VERSION_MINOR(effective_api_version));
John Zulauf620755c2018-04-16 11:00:43 -060071 } else {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -070072 skip |= LogWarning(instance, kVUIDUndefined,
73 "Unrecognized CreateInstance->pCreateInfo->pApplicationInfo.apiVersion number (0x%08x). "
74 "Assuming VK_API_VERSION_%" PRIu32 "_%" PRIu32 ".",
75 api_version, VK_VERSION_MAJOR(effective_api_version), VK_VERSION_MINOR(effective_api_version));
John Zulauf620755c2018-04-16 11:00:43 -060076 }
77 }
78 return skip;
79}
80
Jeff Bolz46c0ea02019-10-09 13:06:29 -050081bool StatelessValidation::validate_instance_extensions(const VkInstanceCreateInfo *pCreateInfo) const {
John Zulauf620755c2018-04-16 11:00:43 -060082 bool skip = false;
Mark Lobodzinski05cce202019-08-27 10:28:37 -060083 // Create and use a local instance extension object, as an actual instance has not been created yet
84 uint32_t specified_version = (pCreateInfo->pApplicationInfo ? pCreateInfo->pApplicationInfo->apiVersion : VK_API_VERSION_1_0);
85 InstanceExtensions local_instance_extensions;
86 local_instance_extensions.InitFromInstanceCreateInfo(specified_version, pCreateInfo);
87
John Zulauf620755c2018-04-16 11:00:43 -060088 for (uint32_t i = 0; i < pCreateInfo->enabledExtensionCount; i++) {
Mark Lobodzinski05cce202019-08-27 10:28:37 -060089 skip |= validate_extension_reqs(local_instance_extensions, "VUID-vkCreateInstance-ppEnabledExtensionNames-01388",
90 "instance", pCreateInfo->ppEnabledExtensionNames[i]);
John Zulauf620755c2018-04-16 11:00:43 -060091 }
92
93 return skip;
94}
95
Mark Lobodzinskibece6c12020-08-27 15:34:02 -060096bool StatelessValidation::SupportedByPdev(const VkPhysicalDevice physical_device, const std::string ext_name) const {
97 if (instance_extensions.vk_khr_get_physical_device_properties_2) {
98 // Struct is legal IF it's supported
99 const auto &dev_exts_enumerated = device_extensions_enumerated.find(physical_device);
100 if (dev_exts_enumerated == device_extensions_enumerated.end()) return true;
101 auto enum_iter = dev_exts_enumerated->second.find(ext_name);
102 if (enum_iter != dev_exts_enumerated->second.cend()) {
103 return true;
104 }
105 }
106 return false;
107}
108
Tony-LunarG866843d2020-05-13 11:22:42 -0600109bool StatelessValidation::validate_validation_features(const VkInstanceCreateInfo *pCreateInfo,
110 const VkValidationFeaturesEXT *validation_features) const {
111 bool skip = false;
112 bool debug_printf = false;
113 bool gpu_assisted = false;
114 bool reserve_slot = false;
115 for (uint32_t i = 0; i < validation_features->enabledValidationFeatureCount; i++) {
116 switch (validation_features->pEnabledValidationFeatures[i]) {
117 case VK_VALIDATION_FEATURE_ENABLE_GPU_ASSISTED_EXT:
118 gpu_assisted = true;
119 break;
120
121 case VK_VALIDATION_FEATURE_ENABLE_DEBUG_PRINTF_EXT:
122 debug_printf = true;
123 break;
124
125 case VK_VALIDATION_FEATURE_ENABLE_GPU_ASSISTED_RESERVE_BINDING_SLOT_EXT:
126 reserve_slot = true;
127 break;
128
129 default:
130 break;
131 }
132 }
133 if (reserve_slot && !gpu_assisted) {
134 skip |= LogError(instance, "VUID-VkValidationFeaturesEXT-pEnabledValidationFeatures-02967",
135 "If VK_VALIDATION_FEATURE_ENABLE_GPU_ASSISTED_RESERVE_BINDING_SLOT_EXT is in pEnabledValidationFeatures, "
136 "VK_VALIDATION_FEATURE_ENABLE_GPU_ASSISTED_EXT must also be in pEnabledValidationFeatures.");
137 }
138 if (gpu_assisted && debug_printf) {
139 skip |= LogError(instance, "VUID-VkValidationFeaturesEXT-pEnabledValidationFeatures-02968",
140 "If VK_VALIDATION_FEATURE_ENABLE_GPU_ASSISTED_EXT is in pEnabledValidationFeatures, "
141 "VK_VALIDATION_FEATURE_ENABLE_DEBUG_PRINTF_EXT must not also be in pEnabledValidationFeatures.");
142 }
143
144 return skip;
145}
146
John Zulauf620755c2018-04-16 11:00:43 -0600147template <typename ExtensionState>
Tony-LunarG2ec96bb2019-11-26 13:43:02 -0700148ExtEnabled extension_state_by_name(const ExtensionState &extensions, const char *extension_name) {
149 if (!extension_name) return kNotEnabled; // null strings specify nothing
John Zulauf620755c2018-04-16 11:00:43 -0600150 auto info = ExtensionState::get_info(extension_name);
Tony-LunarG2ec96bb2019-11-26 13:43:02 -0700151 ExtEnabled state =
152 info.state ? extensions.*(info.state) : kNotEnabled; // unknown extensions can't be enabled in extension struct
John Zulauf620755c2018-04-16 11:00:43 -0600153 return state;
154}
155
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700156bool StatelessValidation::manual_PreCallValidateCreateInstance(const VkInstanceCreateInfo *pCreateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -0500157 const VkAllocationCallbacks *pAllocator,
158 VkInstance *pInstance) const {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700159 bool skip = false;
160 // Note: From the spec--
161 // Providing a NULL VkInstanceCreateInfo::pApplicationInfo or providing an apiVersion of 0 is equivalent to providing
162 // an apiVersion of VK_MAKE_VERSION(1, 0, 0). (a.k.a. VK_API_VERSION_1_0)
163 uint32_t local_api_version = (pCreateInfo->pApplicationInfo && pCreateInfo->pApplicationInfo->apiVersion)
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700164 ? pCreateInfo->pApplicationInfo->apiVersion
165 : VK_API_VERSION_1_0;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700166 skip |= validate_api_version(local_api_version, api_version);
167 skip |= validate_instance_extensions(pCreateInfo);
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700168 const auto *validation_features = LvlFindInChain<VkValidationFeaturesEXT>(pCreateInfo->pNext);
Tony-LunarG866843d2020-05-13 11:22:42 -0600169 if (validation_features) skip |= validate_validation_features(pCreateInfo, validation_features);
170
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700171 return skip;
172}
173
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700174void StatelessValidation::PostCallRecordCreateInstance(const VkInstanceCreateInfo *pCreateInfo,
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -0700175 const VkAllocationCallbacks *pAllocator, VkInstance *pInstance,
176 VkResult result) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700177 auto instance_data = GetLayerDataPtr(get_dispatch_key(*pInstance), layer_data_map);
178 // Copy extension data into local object
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -0700179 if (result != VK_SUCCESS) return;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700180 this->instance_extensions = instance_data->instance_extensions;
Nathaniel Cesario645a15b2021-01-08 22:40:21 -0700181}
Mark Lobodzinski2e40a132020-08-10 14:51:41 -0600182
Nathaniel Cesario645a15b2021-01-08 22:40:21 -0700183void StatelessValidation::CommonPostCallRecordEnumeratePhysicalDevice(const VkPhysicalDevice *phys_devices, const int count) {
184 // Assume phys_devices is valid
185 assert(phys_devices);
186 for (int i = 0; i < count; ++i) {
187 const auto &phys_device = phys_devices[i];
188 if (0 == physical_device_properties_map.count(phys_device)) {
189 auto phys_dev_props = new VkPhysicalDeviceProperties;
190 DispatchGetPhysicalDeviceProperties(phys_device, phys_dev_props);
191 physical_device_properties_map[phys_device] = phys_dev_props;
Mark Lobodzinski2e40a132020-08-10 14:51:41 -0600192
Nathaniel Cesario645a15b2021-01-08 22:40:21 -0700193 // Enumerate the Device Ext Properties to save the PhysicalDevice supported extension state
194 uint32_t ext_count = 0;
195 std::unordered_set<std::string> dev_exts_enumerated{};
196 std::vector<VkExtensionProperties> ext_props{};
197 instance_dispatch_table.EnumerateDeviceExtensionProperties(phys_device, nullptr, &ext_count, nullptr);
198 ext_props.resize(ext_count);
199 instance_dispatch_table.EnumerateDeviceExtensionProperties(phys_device, nullptr, &ext_count, ext_props.data());
200 for (uint32_t j = 0; j < ext_count; j++) {
201 dev_exts_enumerated.insert(ext_props[j].extensionName);
202 }
203 device_extensions_enumerated[phys_device] = std::move(dev_exts_enumerated);
Mark Lobodzinskibece6c12020-08-27 15:34:02 -0600204 }
Nathaniel Cesario645a15b2021-01-08 22:40:21 -0700205 }
206}
207
208void StatelessValidation::PostCallRecordEnumeratePhysicalDevices(VkInstance instance, uint32_t *pPhysicalDeviceCount,
209 VkPhysicalDevice *pPhysicalDevices, VkResult result) {
210 if ((VK_SUCCESS != result) && (VK_INCOMPLETE != result)) {
211 return;
212 }
213
214 if (pPhysicalDeviceCount && pPhysicalDevices) {
215 CommonPostCallRecordEnumeratePhysicalDevice(pPhysicalDevices, *pPhysicalDeviceCount);
216 }
217}
218
219void StatelessValidation::PostCallRecordEnumeratePhysicalDeviceGroups(
220 VkInstance instance, uint32_t *pPhysicalDeviceGroupCount, VkPhysicalDeviceGroupProperties *pPhysicalDeviceGroupProperties,
221 VkResult result) {
222 if ((VK_SUCCESS != result) && (VK_INCOMPLETE != result)) {
223 return;
224 }
225
226 if (pPhysicalDeviceGroupCount && pPhysicalDeviceGroupProperties) {
227 for (uint32_t i = 0; i < *pPhysicalDeviceGroupCount; i++) {
228 const auto &group = pPhysicalDeviceGroupProperties[i];
229 CommonPostCallRecordEnumeratePhysicalDevice(group.physicalDevices, group.physicalDeviceCount);
230 }
Mark Lobodzinski2e40a132020-08-10 14:51:41 -0600231 }
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700232}
233
Mark Lobodzinski2e40a132020-08-10 14:51:41 -0600234void StatelessValidation::PreCallRecordDestroyInstance(VkInstance instance, const VkAllocationCallbacks *pAllocator) {
235 for (auto it = physical_device_properties_map.begin(); it != physical_device_properties_map.end();) {
236 delete (it->second);
237 it = physical_device_properties_map.erase(it);
238 }
239};
240
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700241void StatelessValidation::PostCallRecordCreateDevice(VkPhysicalDevice physicalDevice, const VkDeviceCreateInfo *pCreateInfo,
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -0700242 const VkAllocationCallbacks *pAllocator, VkDevice *pDevice, VkResult result) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700243 auto device_data = GetLayerDataPtr(get_dispatch_key(*pDevice), layer_data_map);
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -0700244 if (result != VK_SUCCESS) return;
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700245 ValidationObject *validation_data = GetValidationObject(device_data->object_dispatch, LayerObjectTypeParameterValidation);
246 StatelessValidation *stateless_validation = static_cast<StatelessValidation *>(validation_data);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700247
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700248 // Parmeter validation also uses extension data
249 stateless_validation->device_extensions = this->device_extensions;
250
251 VkPhysicalDeviceProperties device_properties = {};
252 // Need to get instance and do a getlayerdata call...
Tony-LunarG152a88b2019-03-20 15:42:24 -0600253 DispatchGetPhysicalDeviceProperties(physicalDevice, &device_properties);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700254 memcpy(&stateless_validation->device_limits, &device_properties.limits, sizeof(VkPhysicalDeviceLimits));
255
256 if (device_extensions.vk_nv_shading_rate_image) {
257 // Get the needed shading rate image limits
Mark Lobodzinski6fe9e702020-12-30 15:36:39 -0700258 auto shading_rate_image_props = LvlInitStruct<VkPhysicalDeviceShadingRateImagePropertiesNV>();
259 auto prop2 = LvlInitStruct<VkPhysicalDeviceProperties2>(&shading_rate_image_props);
Tony-LunarG152a88b2019-03-20 15:42:24 -0600260 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700261 phys_dev_ext_props.shading_rate_image_props = shading_rate_image_props;
262 }
263
264 if (device_extensions.vk_nv_mesh_shader) {
265 // Get the needed mesh shader limits
Mark Lobodzinski6fe9e702020-12-30 15:36:39 -0700266 auto mesh_shader_props = LvlInitStruct<VkPhysicalDeviceMeshShaderPropertiesNV>();
267 auto prop2 = LvlInitStruct<VkPhysicalDeviceProperties2>(&mesh_shader_props);
Tony-LunarG152a88b2019-03-20 15:42:24 -0600268 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700269 phys_dev_ext_props.mesh_shader_props = mesh_shader_props;
270 }
271
Jason Macnak5c954952019-07-09 15:46:12 -0700272 if (device_extensions.vk_nv_ray_tracing) {
273 // Get the needed ray tracing limits
Mark Lobodzinski6fe9e702020-12-30 15:36:39 -0700274 auto ray_tracing_props = LvlInitStruct<VkPhysicalDeviceRayTracingPropertiesNV>();
275 auto prop2 = LvlInitStruct<VkPhysicalDeviceProperties2>(&ray_tracing_props);
Jason Macnak5c954952019-07-09 15:46:12 -0700276 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
Jeff Bolz443c2ca2020-03-19 12:11:51 -0500277 phys_dev_ext_props.ray_tracing_propsNV = ray_tracing_props;
278 }
279
sourav parmarcd5fb182020-07-17 12:58:44 -0700280 if (device_extensions.vk_khr_ray_tracing_pipeline) {
Jeff Bolz443c2ca2020-03-19 12:11:51 -0500281 // Get the needed ray tracing limits
Mark Lobodzinski6fe9e702020-12-30 15:36:39 -0700282 auto ray_tracing_props = LvlInitStruct<VkPhysicalDeviceRayTracingPipelinePropertiesKHR>();
283 auto prop2 = LvlInitStruct<VkPhysicalDeviceProperties2>(&ray_tracing_props);
Jeff Bolz443c2ca2020-03-19 12:11:51 -0500284 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
285 phys_dev_ext_props.ray_tracing_propsKHR = ray_tracing_props;
Jason Macnak5c954952019-07-09 15:46:12 -0700286 }
287
sourav parmarcd5fb182020-07-17 12:58:44 -0700288 if (device_extensions.vk_khr_acceleration_structure) {
289 // Get the needed ray tracing acc structure limits
Mark Lobodzinski6fe9e702020-12-30 15:36:39 -0700290 auto acc_structure_props = LvlInitStruct<VkPhysicalDeviceAccelerationStructurePropertiesKHR>();
291 auto prop2 = LvlInitStruct<VkPhysicalDeviceProperties2>(&acc_structure_props);
sourav parmarcd5fb182020-07-17 12:58:44 -0700292 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
293 phys_dev_ext_props.acc_structure_props = acc_structure_props;
294 }
295
Mark Lobodzinski953b7bc2019-12-19 13:50:10 -0700296 if (device_extensions.vk_ext_transform_feedback) {
297 // Get the needed transform feedback limits
Mark Lobodzinski6fe9e702020-12-30 15:36:39 -0700298 auto transform_feedback_props = LvlInitStruct<VkPhysicalDeviceTransformFeedbackPropertiesEXT>();
299 auto prop2 = LvlInitStruct<VkPhysicalDeviceProperties2>(&transform_feedback_props);
Mark Lobodzinski953b7bc2019-12-19 13:50:10 -0700300 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
301 phys_dev_ext_props.transform_feedback_props = transform_feedback_props;
302 }
303
Jasper St. Pierrea49b4be2019-02-05 17:48:57 -0800304 stateless_validation->phys_dev_ext_props = this->phys_dev_ext_props;
305
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700306 // Save app-enabled features in this device's validation object
307 // The enabled features can come from either pEnabledFeatures, or from the pNext chain
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700308 const auto *features2 = LvlFindInChain<VkPhysicalDeviceFeatures2>(pCreateInfo->pNext);
Petr Kraus715bcc72019-08-15 17:17:33 +0200309 safe_VkPhysicalDeviceFeatures2 tmp_features2_state;
310 tmp_features2_state.sType = VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_FEATURES_2;
311 if (features2) {
312 tmp_features2_state.features = features2->features;
313 } else if (pCreateInfo->pEnabledFeatures) {
314 tmp_features2_state.features = *pCreateInfo->pEnabledFeatures;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700315 } else {
Petr Kraus715bcc72019-08-15 17:17:33 +0200316 tmp_features2_state.features = {};
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700317 }
Petr Kraus715bcc72019-08-15 17:17:33 +0200318 // Use pCreateInfo->pNext to get full chain
Tony-LunarG6c3c5452019-12-13 10:37:38 -0700319 stateless_validation->device_createinfo_pnext = SafePnextCopy(pCreateInfo->pNext);
Petr Kraus715bcc72019-08-15 17:17:33 +0200320 stateless_validation->physical_device_features2 = tmp_features2_state;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700321}
322
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700323bool StatelessValidation::manual_PreCallValidateCreateDevice(VkPhysicalDevice physicalDevice, const VkDeviceCreateInfo *pCreateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -0500324 const VkAllocationCallbacks *pAllocator, VkDevice *pDevice) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600325 bool skip = false;
326
Petr Kraus6c4bdce2019-08-27 17:35:01 +0200327 for (size_t i = 0; i < pCreateInfo->enabledLayerCount; i++) {
328 skip |= validate_string("vkCreateDevice", "pCreateInfo->ppEnabledLayerNames",
329 "VUID-VkDeviceCreateInfo-ppEnabledLayerNames-parameter", pCreateInfo->ppEnabledLayerNames[i]);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600330 }
331
Nathaniel Cesariob3f2d702020-11-09 09:20:49 -0700332 // If this device supports VK_KHR_portability_subset, it must be enabled
333 const std::string portability_extension_name("VK_KHR_portability_subset");
334 const auto &dev_extensions = device_extensions_enumerated.at(physicalDevice);
335 const bool portability_supported = dev_extensions.count(portability_extension_name) != 0;
336 bool portability_requested = false;
337
Petr Kraus6c4bdce2019-08-27 17:35:01 +0200338 for (size_t i = 0; i < pCreateInfo->enabledExtensionCount; i++) {
339 skip |=
340 validate_string("vkCreateDevice", "pCreateInfo->ppEnabledExtensionNames",
341 "VUID-VkDeviceCreateInfo-ppEnabledExtensionNames-parameter", pCreateInfo->ppEnabledExtensionNames[i]);
342 skip |= validate_extension_reqs(device_extensions, "VUID-vkCreateDevice-ppEnabledExtensionNames-01387", "device",
343 pCreateInfo->ppEnabledExtensionNames[i]);
Nathaniel Cesariob3f2d702020-11-09 09:20:49 -0700344 if (portability_extension_name == pCreateInfo->ppEnabledExtensionNames[i]) {
345 portability_requested = true;
346 }
347 }
348
349 if (portability_supported && !portability_requested) {
350 skip |= LogError(physicalDevice, "VUID-VkDeviceCreateInfo-pProperties-04451",
351 "vkCreateDevice: VK_KHR_portability_subset must be enabled because physical device %s supports it",
352 report_data->FormatHandle(physicalDevice).c_str());
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600353 }
354
Petr Kraus6c4bdce2019-08-27 17:35:01 +0200355 {
Tony-LunarG2ec96bb2019-11-26 13:43:02 -0700356 bool maint1 = IsExtEnabled(extension_state_by_name(device_extensions, VK_KHR_MAINTENANCE1_EXTENSION_NAME));
357 bool negative_viewport =
358 IsExtEnabled(extension_state_by_name(device_extensions, VK_AMD_NEGATIVE_VIEWPORT_HEIGHT_EXTENSION_NAME));
Petr Kraus6c4bdce2019-08-27 17:35:01 +0200359 if (maint1 && negative_viewport) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700360 skip |= LogError(device, "VUID-VkDeviceCreateInfo-ppEnabledExtensionNames-00374",
361 "VkDeviceCreateInfo->ppEnabledExtensionNames must not simultaneously include VK_KHR_maintenance1 and "
362 "VK_AMD_negative_viewport_height.");
Petr Kraus6c4bdce2019-08-27 17:35:01 +0200363 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600364 }
365
Jeff Bolz4563f2a2019-12-10 13:30:30 -0600366 {
367 bool khr_bda = IsExtEnabled(extension_state_by_name(device_extensions, VK_KHR_BUFFER_DEVICE_ADDRESS_EXTENSION_NAME));
368 bool ext_bda = IsExtEnabled(extension_state_by_name(device_extensions, VK_EXT_BUFFER_DEVICE_ADDRESS_EXTENSION_NAME));
369 if (khr_bda && ext_bda) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700370 skip |= LogError(device, "VUID-VkDeviceCreateInfo-ppEnabledExtensionNames-03328",
371 "VkDeviceCreateInfo->ppEnabledExtensionNames must not contain both VK_KHR_buffer_device_address and "
372 "VK_EXT_buffer_device_address.");
Jeff Bolz4563f2a2019-12-10 13:30:30 -0600373 }
374 }
375
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600376 if (pCreateInfo->pNext != NULL && pCreateInfo->pEnabledFeatures) {
377 // Check for get_physical_device_properties2 struct
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700378 const auto *features2 = LvlFindInChain<VkPhysicalDeviceFeatures2>(pCreateInfo->pNext);
John Zulaufde972ac2017-10-26 12:07:05 -0600379 if (features2) {
Mike Schuchardt2df08912020-12-15 16:28:09 -0800380 // Cannot include VkPhysicalDeviceFeatures2 and have non-null pEnabledFeatures
sfricke-samsung590ae1e2020-04-25 01:18:05 -0700381 skip |= LogError(device, "VUID-VkDeviceCreateInfo-pNext-00373",
Mike Schuchardt2df08912020-12-15 16:28:09 -0800382 "VkDeviceCreateInfo->pNext includes a VkPhysicalDeviceFeatures2 struct when "
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700383 "pCreateInfo->pEnabledFeatures is non-NULL.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600384 }
385 }
386
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700387 auto features2 = LvlFindInChain<VkPhysicalDeviceFeatures2>(pCreateInfo->pNext);
Jeff Bolz165818a2020-05-08 11:19:03 -0500388 const VkPhysicalDeviceFeatures *features = features2 ? &features2->features : pCreateInfo->pEnabledFeatures;
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700389 const auto *robustness2_features = LvlFindInChain<VkPhysicalDeviceRobustness2FeaturesEXT>(pCreateInfo->pNext);
Jeff Bolz165818a2020-05-08 11:19:03 -0500390 if (features && robustness2_features && robustness2_features->robustBufferAccess2 && !features->robustBufferAccess) {
391 skip |= LogError(device, "VUID-VkPhysicalDeviceRobustness2FeaturesEXT-robustBufferAccess2-04000",
392 "If robustBufferAccess2 is enabled then robustBufferAccess must be enabled.");
393 }
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700394 const auto *raytracing_features = LvlFindInChain<VkPhysicalDeviceRayTracingPipelineFeaturesKHR>(pCreateInfo->pNext);
sourav parmarcd5fb182020-07-17 12:58:44 -0700395 if (raytracing_features && raytracing_features->rayTracingPipelineShaderGroupHandleCaptureReplayMixed &&
396 !raytracing_features->rayTracingPipelineShaderGroupHandleCaptureReplay) {
397 skip |= LogError(
398 device,
399 "VUID-VkPhysicalDeviceRayTracingPipelineFeaturesKHR-rayTracingPipelineShaderGroupHandleCaptureReplayMixed-03575",
400 "If rayTracingPipelineShaderGroupHandleCaptureReplayMixed is VK_TRUE, rayTracingPipelineShaderGroupHandleCaptureReplay "
401 "must also be VK_TRUE.");
sourav parmara24fb7b2020-05-26 10:50:04 -0700402 }
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700403 auto vertex_attribute_divisor_features = LvlFindInChain<VkPhysicalDeviceVertexAttributeDivisorFeaturesEXT>(pCreateInfo->pNext);
Mark Lobodzinski3e66ae82020-08-12 16:27:29 -0600404 if (vertex_attribute_divisor_features && (!device_extensions.vk_ext_vertex_attribute_divisor)) {
405 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
406 "VkDeviceCreateInfo->pNext includes a VkPhysicalDeviceVertexAttributeDivisorFeaturesEXT "
407 "struct, VK_EXT_vertex_attribute_divisor must be enabled when it creates a device.");
Locke77fad1c2019-04-16 13:09:03 -0600408 }
409
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700410 const auto *vulkan_11_features = LvlFindInChain<VkPhysicalDeviceVulkan11Features>(pCreateInfo->pNext);
Tony-LunarG28017bc2020-01-23 14:40:25 -0700411 if (vulkan_11_features) {
412 const VkBaseOutStructure *current = reinterpret_cast<const VkBaseOutStructure *>(pCreateInfo->pNext);
413 while (current) {
414 if (current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_16BIT_STORAGE_FEATURES ||
415 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_MULTIVIEW_FEATURES ||
416 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_VARIABLE_POINTERS_FEATURES ||
417 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_PROTECTED_MEMORY_FEATURES ||
418 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SAMPLER_YCBCR_CONVERSION_FEATURES ||
419 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SHADER_DRAW_PARAMETERS_FEATURES) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700420 skip |= LogError(
421 instance, "VUID-VkDeviceCreateInfo-pNext-02829",
Tony-LunarG28017bc2020-01-23 14:40:25 -0700422 "If the pNext chain includes a VkPhysicalDeviceVulkan11Features structure, then it must not include a "
423 "VkPhysicalDevice16BitStorageFeatures, VkPhysicalDeviceMultiviewFeatures, "
424 "VkPhysicalDeviceVariablePointersFeatures, VkPhysicalDeviceProtectedMemoryFeatures, "
425 "VkPhysicalDeviceSamplerYcbcrConversionFeatures, or VkPhysicalDeviceShaderDrawParametersFeatures structure");
426 break;
427 }
428 current = reinterpret_cast<const VkBaseOutStructure *>(current->pNext);
429 }
sfricke-samsungebda6792021-01-16 08:57:52 -0800430
431 // Check features are enabled if matching extension is passed in as well
432 for (uint32_t i = 0; i < pCreateInfo->enabledExtensionCount; i++) {
433 const char *extension = pCreateInfo->ppEnabledExtensionNames[i];
434 if ((0 == strncmp(extension, VK_KHR_SHADER_DRAW_PARAMETERS_EXTENSION_NAME, VK_MAX_EXTENSION_NAME_SIZE)) &&
435 (vulkan_11_features->shaderDrawParameters == VK_FALSE)) {
436 skip |= LogError(
437 instance, "VUID-VkDeviceCreateInfo-ppEnabledExtensions-04476",
438 "vkCreateDevice(): %s is enabled but VkPhysicalDeviceVulkan11Features::shaderDrawParameters is not VK_TRUE.",
439 VK_KHR_SHADER_DRAW_PARAMETERS_EXTENSION_NAME);
440 }
441 }
Tony-LunarG28017bc2020-01-23 14:40:25 -0700442 }
443
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700444 const auto *vulkan_12_features = LvlFindInChain<VkPhysicalDeviceVulkan12Features>(pCreateInfo->pNext);
Tony-LunarG28017bc2020-01-23 14:40:25 -0700445 if (vulkan_12_features) {
446 const VkBaseOutStructure *current = reinterpret_cast<const VkBaseOutStructure *>(pCreateInfo->pNext);
447 while (current) {
448 if (current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_8BIT_STORAGE_FEATURES ||
449 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SHADER_ATOMIC_INT64_FEATURES ||
450 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SHADER_FLOAT16_INT8_FEATURES ||
451 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_DESCRIPTOR_INDEXING_FEATURES ||
452 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SCALAR_BLOCK_LAYOUT_FEATURES ||
453 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_IMAGELESS_FRAMEBUFFER_FEATURES ||
454 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_UNIFORM_BUFFER_STANDARD_LAYOUT_FEATURES ||
455 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SHADER_SUBGROUP_EXTENDED_TYPES_FEATURES ||
456 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SEPARATE_DEPTH_STENCIL_LAYOUTS_FEATURES ||
457 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_HOST_QUERY_RESET_FEATURES ||
458 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_TIMELINE_SEMAPHORE_FEATURES ||
459 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_BUFFER_DEVICE_ADDRESS_FEATURES ||
460 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_VULKAN_MEMORY_MODEL_FEATURES) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700461 skip |= LogError(
462 instance, "VUID-VkDeviceCreateInfo-pNext-02830",
Tony-LunarG28017bc2020-01-23 14:40:25 -0700463 "If the pNext chain includes a VkPhysicalDeviceVulkan12Features structure, then it must not include a "
464 "VkPhysicalDevice8BitStorageFeatures, VkPhysicalDeviceShaderAtomicInt64Features, "
465 "VkPhysicalDeviceShaderFloat16Int8Features, VkPhysicalDeviceDescriptorIndexingFeatures, "
466 "VkPhysicalDeviceScalarBlockLayoutFeatures, VkPhysicalDeviceImagelessFramebufferFeatures, "
467 "VkPhysicalDeviceUniformBufferStandardLayoutFeatures, VkPhysicalDeviceShaderSubgroupExtendedTypesFeatures, "
468 "VkPhysicalDeviceSeparateDepthStencilLayoutsFeatures, VkPhysicalDeviceHostQueryResetFeatures, "
469 "VkPhysicalDeviceTimelineSemaphoreFeatures, VkPhysicalDeviceBufferDeviceAddressFeatures, or "
470 "VkPhysicalDeviceVulkanMemoryModelFeatures structure");
471 break;
472 }
473 current = reinterpret_cast<const VkBaseOutStructure *>(current->pNext);
474 }
sfricke-samsungabab4632020-05-04 06:51:46 -0700475 // Check features are enabled if matching extension is passed in as well
476 for (uint32_t i = 0; i < pCreateInfo->enabledExtensionCount; i++) {
477 const char *extension = pCreateInfo->ppEnabledExtensionNames[i];
478 if ((0 == strncmp(extension, VK_KHR_DRAW_INDIRECT_COUNT_EXTENSION_NAME, VK_MAX_EXTENSION_NAME_SIZE)) &&
479 (vulkan_12_features->drawIndirectCount == VK_FALSE)) {
480 skip |= LogError(
481 instance, "VUID-VkDeviceCreateInfo-ppEnabledExtensions-02831",
482 "vkCreateDevice(): %s is enabled but VkPhysicalDeviceVulkan12Features::drawIndirectCount is not VK_TRUE.",
483 VK_KHR_DRAW_INDIRECT_COUNT_EXTENSION_NAME);
484 }
485 if ((0 == strncmp(extension, VK_KHR_SAMPLER_MIRROR_CLAMP_TO_EDGE_EXTENSION_NAME, VK_MAX_EXTENSION_NAME_SIZE)) &&
486 (vulkan_12_features->samplerMirrorClampToEdge == VK_FALSE)) {
487 skip |= LogError(instance, "VUID-VkDeviceCreateInfo-ppEnabledExtensions-02832",
488 "vkCreateDevice(): %s is enabled but VkPhysicalDeviceVulkan12Features::samplerMirrorClampToEdge "
489 "is not VK_TRUE.",
490 VK_KHR_SAMPLER_MIRROR_CLAMP_TO_EDGE_EXTENSION_NAME);
491 }
492 if ((0 == strncmp(extension, VK_EXT_DESCRIPTOR_INDEXING_EXTENSION_NAME, VK_MAX_EXTENSION_NAME_SIZE)) &&
493 (vulkan_12_features->descriptorIndexing == VK_FALSE)) {
494 skip |= LogError(
495 instance, "VUID-VkDeviceCreateInfo-ppEnabledExtensions-02833",
496 "vkCreateDevice(): %s is enabled but VkPhysicalDeviceVulkan12Features::descriptorIndexing is not VK_TRUE.",
497 VK_EXT_DESCRIPTOR_INDEXING_EXTENSION_NAME);
498 }
499 if ((0 == strncmp(extension, VK_EXT_SAMPLER_FILTER_MINMAX_EXTENSION_NAME, VK_MAX_EXTENSION_NAME_SIZE)) &&
500 (vulkan_12_features->samplerFilterMinmax == VK_FALSE)) {
501 skip |= LogError(
502 instance, "VUID-VkDeviceCreateInfo-ppEnabledExtensions-02834",
503 "vkCreateDevice(): %s is enabled but VkPhysicalDeviceVulkan12Features::samplerFilterMinmax is not VK_TRUE.",
504 VK_EXT_SAMPLER_FILTER_MINMAX_EXTENSION_NAME);
505 }
506 if ((0 == strncmp(extension, VK_EXT_SHADER_VIEWPORT_INDEX_LAYER_EXTENSION_NAME, VK_MAX_EXTENSION_NAME_SIZE)) &&
507 ((vulkan_12_features->shaderOutputViewportIndex == VK_FALSE) ||
508 (vulkan_12_features->shaderOutputLayer == VK_FALSE))) {
509 skip |=
510 LogError(instance, "VUID-VkDeviceCreateInfo-ppEnabledExtensions-02835",
511 "vkCreateDevice(): %s is enabled but both VkPhysicalDeviceVulkan12Features::shaderOutputViewportIndex "
512 "and VkPhysicalDeviceVulkan12Features::shaderOutputLayer are not VK_TRUE.",
513 VK_EXT_SHADER_VIEWPORT_INDEX_LAYER_EXTENSION_NAME);
514 }
515 }
Tony-LunarG28017bc2020-01-23 14:40:25 -0700516 }
517
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600518 // Validate pCreateInfo->pQueueCreateInfos
519 if (pCreateInfo->pQueueCreateInfos) {
520 std::unordered_set<uint32_t> set;
521
522 for (uint32_t i = 0; i < pCreateInfo->queueCreateInfoCount; ++i) {
sfricke-samsung590ae1e2020-04-25 01:18:05 -0700523 const VkDeviceQueueCreateInfo &queue_create_info = pCreateInfo->pQueueCreateInfos[i];
524 const uint32_t requested_queue_family = queue_create_info.queueFamilyIndex;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600525 if (requested_queue_family == VK_QUEUE_FAMILY_IGNORED) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700526 skip |=
527 LogError(physicalDevice, "VUID-VkDeviceQueueCreateInfo-queueFamilyIndex-00381",
528 "vkCreateDevice: pCreateInfo->pQueueCreateInfos[%" PRIu32
529 "].queueFamilyIndex is VK_QUEUE_FAMILY_IGNORED, but it is required to provide a valid queue family "
530 "index value.",
531 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600532 } else if (set.count(requested_queue_family)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700533 skip |= LogError(physicalDevice, "VUID-VkDeviceCreateInfo-queueFamilyIndex-00372",
534 "vkCreateDevice: pCreateInfo->pQueueCreateInfos[%" PRIu32 "].queueFamilyIndex (=%" PRIu32
535 ") is not unique within pCreateInfo->pQueueCreateInfos array.",
536 i, requested_queue_family);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600537 } else {
538 set.insert(requested_queue_family);
539 }
540
sfricke-samsung590ae1e2020-04-25 01:18:05 -0700541 if (queue_create_info.pQueuePriorities != nullptr) {
542 for (uint32_t j = 0; j < queue_create_info.queueCount; ++j) {
543 const float queue_priority = queue_create_info.pQueuePriorities[j];
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600544 if (!(queue_priority >= 0.f) || !(queue_priority <= 1.f)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700545 skip |= LogError(physicalDevice, "VUID-VkDeviceQueueCreateInfo-pQueuePriorities-00383",
546 "vkCreateDevice: pCreateInfo->pQueueCreateInfos[%" PRIu32 "].pQueuePriorities[%" PRIu32
547 "] (=%f) is not between 0 and 1 (inclusive).",
548 i, j, queue_priority);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600549 }
550 }
551 }
sfricke-samsung590ae1e2020-04-25 01:18:05 -0700552
553 // Need to know if protectedMemory feature is passed in preCall to creating the device
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700554 VkBool32 protected_memory = VK_FALSE;
sfricke-samsung590ae1e2020-04-25 01:18:05 -0700555 const VkPhysicalDeviceProtectedMemoryFeatures *protected_features =
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700556 LvlFindInChain<VkPhysicalDeviceProtectedMemoryFeatures>(pCreateInfo->pNext);
sfricke-samsung590ae1e2020-04-25 01:18:05 -0700557 if (protected_features) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700558 protected_memory = protected_features->protectedMemory;
sfricke-samsung590ae1e2020-04-25 01:18:05 -0700559 } else if (vulkan_11_features) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700560 protected_memory = vulkan_11_features->protectedMemory;
sfricke-samsung590ae1e2020-04-25 01:18:05 -0700561 }
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700562 if ((queue_create_info.flags == VK_DEVICE_QUEUE_CREATE_PROTECTED_BIT) && (protected_memory == VK_FALSE)) {
sfricke-samsung590ae1e2020-04-25 01:18:05 -0700563 skip |= LogError(physicalDevice, "VUID-VkDeviceQueueCreateInfo-flags-02861",
564 "vkCreateDevice: pCreateInfo->flags set to VK_DEVICE_QUEUE_CREATE_PROTECTED_BIT without the "
565 "protectedMemory feature being set as well.");
566 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600567 }
568 }
569
sfricke-samsung30a57412020-05-15 21:14:54 -0700570 // feature dependencies for VK_KHR_variable_pointers
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700571 const auto *variable_pointers_features = LvlFindInChain<VkPhysicalDeviceVariablePointersFeatures>(pCreateInfo->pNext);
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700572 VkBool32 variable_pointers = VK_FALSE;
573 VkBool32 variable_pointers_storage_buffer = VK_FALSE;
sfricke-samsung30a57412020-05-15 21:14:54 -0700574 if (vulkan_11_features) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700575 variable_pointers = vulkan_11_features->variablePointers;
576 variable_pointers_storage_buffer = vulkan_11_features->variablePointersStorageBuffer;
sfricke-samsung30a57412020-05-15 21:14:54 -0700577 } else if (variable_pointers_features) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700578 variable_pointers = variable_pointers_features->variablePointers;
579 variable_pointers_storage_buffer = variable_pointers_features->variablePointersStorageBuffer;
sfricke-samsung30a57412020-05-15 21:14:54 -0700580 }
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700581 if ((variable_pointers == VK_TRUE) && (variable_pointers_storage_buffer == VK_FALSE)) {
sfricke-samsung30a57412020-05-15 21:14:54 -0700582 skip |= LogError(instance, "VUID-VkPhysicalDeviceVariablePointersFeatures-variablePointers-01431",
583 "If variablePointers is VK_TRUE then variablePointersStorageBuffer also needs to be VK_TRUE");
584 }
585
sfricke-samsungfd76c342020-05-29 23:13:43 -0700586 // feature dependencies for VK_KHR_multiview
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700587 const auto *multiview_features = LvlFindInChain<VkPhysicalDeviceMultiviewFeatures>(pCreateInfo->pNext);
sfricke-samsungfd76c342020-05-29 23:13:43 -0700588 VkBool32 multiview = VK_FALSE;
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700589 VkBool32 multiview_geometry_shader = VK_FALSE;
590 VkBool32 multiview_tessellation_shader = VK_FALSE;
sfricke-samsungfd76c342020-05-29 23:13:43 -0700591 if (vulkan_11_features) {
592 multiview = vulkan_11_features->multiview;
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700593 multiview_geometry_shader = vulkan_11_features->multiviewGeometryShader;
594 multiview_tessellation_shader = vulkan_11_features->multiviewTessellationShader;
sfricke-samsungfd76c342020-05-29 23:13:43 -0700595 } else if (multiview_features) {
596 multiview = multiview_features->multiview;
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700597 multiview_geometry_shader = multiview_features->multiviewGeometryShader;
598 multiview_tessellation_shader = multiview_features->multiviewTessellationShader;
sfricke-samsungfd76c342020-05-29 23:13:43 -0700599 }
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700600 if ((multiview == VK_FALSE) && (multiview_geometry_shader == VK_TRUE)) {
sfricke-samsungfd76c342020-05-29 23:13:43 -0700601 skip |= LogError(instance, "VUID-VkPhysicalDeviceMultiviewFeatures-multiviewGeometryShader-00580",
602 "If multiviewGeometryShader is VK_TRUE then multiview also needs to be VK_TRUE");
603 }
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700604 if ((multiview == VK_FALSE) && (multiview_tessellation_shader == VK_TRUE)) {
sfricke-samsungfd76c342020-05-29 23:13:43 -0700605 skip |= LogError(instance, "VUID-VkPhysicalDeviceMultiviewFeatures-multiviewTessellationShader-00581",
606 "If multiviewTessellationShader is VK_TRUE then multiview also needs to be VK_TRUE");
607 }
608
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600609 return skip;
610}
611
Jeff Bolz46c0ea02019-10-09 13:06:29 -0500612bool StatelessValidation::require_device_extension(bool flag, char const *function_name, char const *extension_name) const {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700613 if (!flag) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700614 return LogError(device, kVUID_PVError_ExtensionNotEnabled,
615 "%s() called even though the %s extension was not enabled for this VkDevice.", function_name,
616 extension_name);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600617 }
618
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700619 return false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600620}
621
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700622bool StatelessValidation::manual_PreCallValidateCreateBuffer(VkDevice device, const VkBufferCreateInfo *pCreateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -0500623 const VkAllocationCallbacks *pAllocator, VkBuffer *pBuffer) const {
Petr Krause91f7a12017-12-14 20:57:36 +0100624 bool skip = false;
625
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600626 if (pCreateInfo != nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700627 skip |=
628 ValidateGreaterThanZero(pCreateInfo->size, "pCreateInfo->size", "VUID-VkBufferCreateInfo-size-00912", "vkCreateBuffer");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600629
630 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
631 if (pCreateInfo->sharingMode == VK_SHARING_MODE_CONCURRENT) {
632 // If sharingMode is VK_SHARING_MODE_CONCURRENT, queueFamilyIndexCount must be greater than 1
633 if (pCreateInfo->queueFamilyIndexCount <= 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700634 skip |= LogError(device, "VUID-VkBufferCreateInfo-sharingMode-00914",
635 "vkCreateBuffer: if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
636 "pCreateInfo->queueFamilyIndexCount must be greater than 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600637 }
638
639 // If sharingMode is VK_SHARING_MODE_CONCURRENT, pQueueFamilyIndices must be a pointer to an array of
640 // queueFamilyIndexCount uint32_t values
641 if (pCreateInfo->pQueueFamilyIndices == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700642 skip |= LogError(device, "VUID-VkBufferCreateInfo-sharingMode-00913",
643 "vkCreateBuffer: if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
644 "pCreateInfo->pQueueFamilyIndices must be a pointer to an array of "
645 "pCreateInfo->queueFamilyIndexCount uint32_t values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600646 }
647 }
648
sfricke-samsung8f8cf052020-07-03 22:44:29 -0700649 if ((pCreateInfo->flags & VK_BUFFER_CREATE_SPARSE_BINDING_BIT) && (!physical_device_features.sparseBinding)) {
650 skip |= LogError(device, "VUID-VkBufferCreateInfo-flags-00915",
651 "vkCreateBuffer(): the sparseBinding device feature is disabled: Buffers cannot be created with the "
652 "VK_BUFFER_CREATE_SPARSE_BINDING_BIT set.");
653 }
654
655 if ((pCreateInfo->flags & VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT) && (!physical_device_features.sparseResidencyBuffer)) {
656 skip |=
657 LogError(device, "VUID-VkBufferCreateInfo-flags-00916",
658 "vkCreateBuffer(): the sparseResidencyBuffer device feature is disabled: Buffers cannot be created with "
659 "the VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT set.");
660 }
661
662 if ((pCreateInfo->flags & VK_BUFFER_CREATE_SPARSE_ALIASED_BIT) && (!physical_device_features.sparseResidencyAliased)) {
663 skip |=
664 LogError(device, "VUID-VkBufferCreateInfo-flags-00917",
665 "vkCreateBuffer(): the sparseResidencyAliased device feature is disabled: Buffers cannot be created with "
666 "the VK_BUFFER_CREATE_SPARSE_ALIASED_BIT set.");
667 }
668
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600669 // If flags contains VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT or VK_BUFFER_CREATE_SPARSE_ALIASED_BIT, it must also contain
670 // VK_BUFFER_CREATE_SPARSE_BINDING_BIT
671 if (((pCreateInfo->flags & (VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT | VK_BUFFER_CREATE_SPARSE_ALIASED_BIT)) != 0) &&
672 ((pCreateInfo->flags & VK_BUFFER_CREATE_SPARSE_BINDING_BIT) != VK_BUFFER_CREATE_SPARSE_BINDING_BIT)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700673 skip |= LogError(device, "VUID-VkBufferCreateInfo-flags-00918",
674 "vkCreateBuffer: if pCreateInfo->flags contains VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT or "
675 "VK_BUFFER_CREATE_SPARSE_ALIASED_BIT, it must also contain VK_BUFFER_CREATE_SPARSE_BINDING_BIT.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600676 }
677 }
678
679 return skip;
680}
681
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700682bool StatelessValidation::manual_PreCallValidateCreateImage(VkDevice device, const VkImageCreateInfo *pCreateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -0500683 const VkAllocationCallbacks *pAllocator, VkImage *pImage) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600684 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600685
686 if (pCreateInfo != nullptr) {
sfricke-samsung61a57c02021-01-10 21:35:12 -0800687 const VkFormat image_format = pCreateInfo->format;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600688 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
689 if (pCreateInfo->sharingMode == VK_SHARING_MODE_CONCURRENT) {
690 // If sharingMode is VK_SHARING_MODE_CONCURRENT, queueFamilyIndexCount must be greater than 1
691 if (pCreateInfo->queueFamilyIndexCount <= 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700692 skip |= LogError(device, "VUID-VkImageCreateInfo-sharingMode-00942",
693 "vkCreateImage(): if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
694 "pCreateInfo->queueFamilyIndexCount must be greater than 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600695 }
696
697 // If sharingMode is VK_SHARING_MODE_CONCURRENT, pQueueFamilyIndices must be a pointer to an array of
698 // queueFamilyIndexCount uint32_t values
699 if (pCreateInfo->pQueueFamilyIndices == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700700 skip |= LogError(device, "VUID-VkImageCreateInfo-sharingMode-00941",
701 "vkCreateImage(): if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
702 "pCreateInfo->pQueueFamilyIndices must be a pointer to an array of "
703 "pCreateInfo->queueFamilyIndexCount uint32_t values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600704 }
705 }
706
Dave Houlton413a6782018-05-22 13:01:54 -0600707 skip |= ValidateGreaterThanZero(pCreateInfo->extent.width, "pCreateInfo->extent.width",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700708 "VUID-VkImageCreateInfo-extent-00944", "vkCreateImage");
Dave Houlton413a6782018-05-22 13:01:54 -0600709 skip |= ValidateGreaterThanZero(pCreateInfo->extent.height, "pCreateInfo->extent.height",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700710 "VUID-VkImageCreateInfo-extent-00945", "vkCreateImage");
Dave Houlton413a6782018-05-22 13:01:54 -0600711 skip |= ValidateGreaterThanZero(pCreateInfo->extent.depth, "pCreateInfo->extent.depth",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700712 "VUID-VkImageCreateInfo-extent-00946", "vkCreateImage");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600713
Dave Houlton413a6782018-05-22 13:01:54 -0600714 skip |= ValidateGreaterThanZero(pCreateInfo->mipLevels, "pCreateInfo->mipLevels", "VUID-VkImageCreateInfo-mipLevels-00947",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700715 "vkCreateImage");
Dave Houlton413a6782018-05-22 13:01:54 -0600716 skip |= ValidateGreaterThanZero(pCreateInfo->arrayLayers, "pCreateInfo->arrayLayers",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700717 "VUID-VkImageCreateInfo-arrayLayers-00948", "vkCreateImage");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600718
Dave Houlton130c0212018-01-29 13:39:56 -0700719 // InitialLayout must be PREINITIALIZED or UNDEFINED
Dave Houltone19e20d2018-02-02 16:32:41 -0700720 if ((pCreateInfo->initialLayout != VK_IMAGE_LAYOUT_UNDEFINED) &&
721 (pCreateInfo->initialLayout != VK_IMAGE_LAYOUT_PREINITIALIZED)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700722 skip |= LogError(
723 device, "VUID-VkImageCreateInfo-initialLayout-00993",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600724 "vkCreateImage(): initialLayout is %s, must be VK_IMAGE_LAYOUT_UNDEFINED or VK_IMAGE_LAYOUT_PREINITIALIZED.",
725 string_VkImageLayout(pCreateInfo->initialLayout));
Dave Houlton130c0212018-01-29 13:39:56 -0700726 }
727
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600728 // If imageType is VK_IMAGE_TYPE_1D, both extent.height and extent.depth must be 1
Petr Kraus3ac9e812018-03-13 12:31:08 +0100729 if ((pCreateInfo->imageType == VK_IMAGE_TYPE_1D) &&
730 ((pCreateInfo->extent.height != 1) || (pCreateInfo->extent.depth != 1))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700731 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00956",
732 "vkCreateImage(): if pCreateInfo->imageType is VK_IMAGE_TYPE_1D, both pCreateInfo->extent.height and "
733 "pCreateInfo->extent.depth must be 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600734 }
735
736 if (pCreateInfo->imageType == VK_IMAGE_TYPE_2D) {
Petr Kraus3f433212018-03-13 12:31:27 +0100737 if (pCreateInfo->flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) {
738 if (pCreateInfo->extent.width != pCreateInfo->extent.height) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700739 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00954",
740 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT, but "
741 "pCreateInfo->extent.width (=%" PRIu32 ") and pCreateInfo->extent.height (=%" PRIu32
742 ") are not equal.",
743 pCreateInfo->extent.width, pCreateInfo->extent.height);
Petr Kraus3f433212018-03-13 12:31:27 +0100744 }
745
746 if (pCreateInfo->arrayLayers < 6) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700747 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00954",
748 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT, but "
749 "pCreateInfo->arrayLayers (=%" PRIu32 ") is not greater than or equal to 6.",
750 pCreateInfo->arrayLayers);
Petr Kraus3f433212018-03-13 12:31:27 +0100751 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600752 }
753
754 if (pCreateInfo->extent.depth != 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700755 skip |= LogError(
756 device, "VUID-VkImageCreateInfo-imageType-00957",
757 "vkCreateImage(): if pCreateInfo->imageType is VK_IMAGE_TYPE_2D, pCreateInfo->extent.depth must be 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600758 }
759 }
760
Dave Houlton130c0212018-01-29 13:39:56 -0700761 // 3D image may have only 1 layer
762 if ((pCreateInfo->imageType == VK_IMAGE_TYPE_3D) && (pCreateInfo->arrayLayers != 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700763 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00961",
764 "vkCreateImage(): if pCreateInfo->imageType is VK_IMAGE_TYPE_3D, pCreateInfo->arrayLayers must be 1.");
Dave Houlton130c0212018-01-29 13:39:56 -0700765 }
766
Dave Houlton130c0212018-01-29 13:39:56 -0700767 if (0 != (pCreateInfo->usage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT)) {
768 VkImageUsageFlags legal_flags = (VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT | VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT |
769 VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT);
770 // At least one of the legal attachment bits must be set
771 if (0 == (pCreateInfo->usage & legal_flags)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700772 skip |= LogError(device, "VUID-VkImageCreateInfo-usage-00966",
773 "vkCreateImage(): Transient attachment image without a compatible attachment flag set.");
Dave Houlton130c0212018-01-29 13:39:56 -0700774 }
775 // No flags other than the legal attachment bits may be set
776 legal_flags |= VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT;
777 if (0 != (pCreateInfo->usage & ~legal_flags)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700778 skip |= LogError(device, "VUID-VkImageCreateInfo-usage-00963",
779 "vkCreateImage(): Transient attachment image with incompatible usage flags set.");
Dave Houlton130c0212018-01-29 13:39:56 -0700780 }
781 }
782
Jeff Bolzef40fec2018-09-01 22:04:34 -0500783 // mipLevels must be less than or equal to the number of levels in the complete mipmap chain
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700784 uint32_t max_dim = std::max(std::max(pCreateInfo->extent.width, pCreateInfo->extent.height), pCreateInfo->extent.depth);
Jeff Bolzef40fec2018-09-01 22:04:34 -0500785 // Max mip levels is different for corner-sampled images vs normal images.
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700786 uint32_t max_mip_levels = (pCreateInfo->flags & VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV)
787 ? static_cast<uint32_t>(ceil(log2(max_dim)))
788 : static_cast<uint32_t>(floor(log2(max_dim)) + 1);
789 if (max_dim > 0 && pCreateInfo->mipLevels > max_mip_levels) {
Dave Houlton413a6782018-05-22 13:01:54 -0600790 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700791 LogError(device, "VUID-VkImageCreateInfo-mipLevels-00958",
792 "vkCreateImage(): pCreateInfo->mipLevels must be less than or equal to "
793 "floor(log2(max(pCreateInfo->extent.width, pCreateInfo->extent.height, pCreateInfo->extent.depth)))+1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600794 }
795
Mark Lobodzinski69259c52018-09-18 15:14:58 -0600796 if ((pCreateInfo->flags & VK_IMAGE_CREATE_2D_ARRAY_COMPATIBLE_BIT) && (pCreateInfo->imageType != VK_IMAGE_TYPE_3D)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700797 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-00950",
798 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_2D_ARRAY_COMPATIBLE_BIT but "
799 "pCreateInfo->imageType is not VK_IMAGE_TYPE_3D.");
Mark Lobodzinski69259c52018-09-18 15:14:58 -0600800 }
801
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700802 if ((pCreateInfo->flags & VK_IMAGE_CREATE_SPARSE_BINDING_BIT) && (!physical_device_features.sparseBinding)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700803 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-00969",
804 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_SPARSE_BINDING_BIT, but the "
805 "VkPhysicalDeviceFeatures::sparseBinding feature is disabled.");
Petr Krausb6f97802018-03-13 12:31:39 +0100806 }
807
sfricke-samsung8f8cf052020-07-03 22:44:29 -0700808 if ((pCreateInfo->flags & VK_IMAGE_CREATE_SPARSE_ALIASED_BIT) && (!physical_device_features.sparseResidencyAliased)) {
809 skip |= LogError(
810 device, "VUID-VkImageCreateInfo-flags-01924",
811 "vkCreateImage(): the sparseResidencyAliased device feature is disabled: Images cannot be created with the "
812 "VK_IMAGE_CREATE_SPARSE_ALIASED_BIT set.");
813 }
814
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600815 // If flags contains VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT or VK_IMAGE_CREATE_SPARSE_ALIASED_BIT, it must also contain
816 // VK_IMAGE_CREATE_SPARSE_BINDING_BIT
817 if (((pCreateInfo->flags & (VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT | VK_IMAGE_CREATE_SPARSE_ALIASED_BIT)) != 0) &&
818 ((pCreateInfo->flags & VK_IMAGE_CREATE_SPARSE_BINDING_BIT) != VK_IMAGE_CREATE_SPARSE_BINDING_BIT)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700819 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-00987",
820 "vkCreateImage: if pCreateInfo->flags contains VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT or "
821 "VK_IMAGE_CREATE_SPARSE_ALIASED_BIT, it must also contain VK_IMAGE_CREATE_SPARSE_BINDING_BIT.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600822 }
823
824 // Check for combinations of attributes that are incompatible with having VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT set
825 if ((pCreateInfo->flags & VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT) != 0) {
826 // Linear tiling is unsupported
827 if (VK_IMAGE_TILING_LINEAR == pCreateInfo->tiling) {
sfricke-samsung9801d752020-08-23 22:00:16 -0700828 skip |= LogError(device, "VUID-VkImageCreateInfo-tiling-04121",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700829 "vkCreateImage: if pCreateInfo->flags contains VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT then image "
830 "tiling of VK_IMAGE_TILING_LINEAR is not supported");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600831 }
832
833 // Sparse 1D image isn't valid
834 if (VK_IMAGE_TYPE_1D == pCreateInfo->imageType) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700835 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00970",
836 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 1D image.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600837 }
838
839 // Sparse 2D image when device doesn't support it
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700840 if ((VK_FALSE == physical_device_features.sparseResidencyImage2D) && (VK_IMAGE_TYPE_2D == pCreateInfo->imageType)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700841 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00971",
842 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 2D image if corresponding "
843 "feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600844 }
845
846 // Sparse 3D image when device doesn't support it
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700847 if ((VK_FALSE == physical_device_features.sparseResidencyImage3D) && (VK_IMAGE_TYPE_3D == pCreateInfo->imageType)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700848 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00972",
849 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 3D image if corresponding "
850 "feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600851 }
852
853 // Multi-sample 2D image when device doesn't support it
854 if (VK_IMAGE_TYPE_2D == pCreateInfo->imageType) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700855 if ((VK_FALSE == physical_device_features.sparseResidency2Samples) &&
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600856 (VK_SAMPLE_COUNT_2_BIT == pCreateInfo->samples)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700857 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00973",
858 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 2-sample image if "
859 "corresponding feature is not enabled on the device.");
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700860 } else if ((VK_FALSE == physical_device_features.sparseResidency4Samples) &&
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600861 (VK_SAMPLE_COUNT_4_BIT == pCreateInfo->samples)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700862 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00974",
863 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 4-sample image if "
864 "corresponding feature is not enabled on the device.");
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700865 } else if ((VK_FALSE == physical_device_features.sparseResidency8Samples) &&
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600866 (VK_SAMPLE_COUNT_8_BIT == pCreateInfo->samples)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700867 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00975",
868 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 8-sample image if "
869 "corresponding feature is not enabled on the device.");
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700870 } else if ((VK_FALSE == physical_device_features.sparseResidency16Samples) &&
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600871 (VK_SAMPLE_COUNT_16_BIT == pCreateInfo->samples)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700872 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00976",
873 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 16-sample image if "
874 "corresponding feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600875 }
876 }
877 }
Jeff Bolzef40fec2018-09-01 22:04:34 -0500878
Jeff Bolz9af91c52018-09-01 21:53:57 -0500879 if (pCreateInfo->usage & VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV) {
880 if (pCreateInfo->imageType != VK_IMAGE_TYPE_2D) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700881 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-02082",
882 "vkCreateImage: if usage includes VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV, "
883 "imageType must be VK_IMAGE_TYPE_2D.");
Jeff Bolz9af91c52018-09-01 21:53:57 -0500884 }
885 if (pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700886 skip |= LogError(device, "VUID-VkImageCreateInfo-samples-02083",
887 "vkCreateImage: if usage includes VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV, "
888 "samples must be VK_SAMPLE_COUNT_1_BIT.");
Jeff Bolz9af91c52018-09-01 21:53:57 -0500889 }
890 if (pCreateInfo->tiling != VK_IMAGE_TILING_OPTIMAL) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700891 skip |= LogError(device, "VUID-VkImageCreateInfo-tiling-02084",
892 "vkCreateImage: if usage includes VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV, "
893 "tiling must be VK_IMAGE_TILING_OPTIMAL.");
Jeff Bolz9af91c52018-09-01 21:53:57 -0500894 }
895 }
Jeff Bolzef40fec2018-09-01 22:04:34 -0500896
897 if (pCreateInfo->flags & VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV) {
Dave Houlton142c4cb2018-10-17 15:04:41 -0600898 if (pCreateInfo->imageType != VK_IMAGE_TYPE_2D && pCreateInfo->imageType != VK_IMAGE_TYPE_3D) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700899 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02050",
900 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV, "
901 "imageType must be VK_IMAGE_TYPE_2D or VK_IMAGE_TYPE_3D.");
Jeff Bolzef40fec2018-09-01 22:04:34 -0500902 }
903
sfricke-samsung61a57c02021-01-10 21:35:12 -0800904 if ((pCreateInfo->flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) || FormatIsDepthOrStencil(image_format)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700905 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02051",
906 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV, "
sfricke-samsung61a57c02021-01-10 21:35:12 -0800907 "it must not also contain VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT and format (%s) must not be a "
908 "depth/stencil format.",
909 string_VkFormat(image_format));
Jeff Bolzef40fec2018-09-01 22:04:34 -0500910 }
911
Dave Houlton142c4cb2018-10-17 15:04:41 -0600912 if (pCreateInfo->imageType == VK_IMAGE_TYPE_2D && (pCreateInfo->extent.width == 1 || pCreateInfo->extent.height == 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700913 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02052",
914 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV and "
915 "imageType is VK_IMAGE_TYPE_2D, extent.width and extent.height must be "
916 "greater than 1.");
Jeff Bolzb8a8dd02018-09-18 02:39:24 -0500917 } else if (pCreateInfo->imageType == VK_IMAGE_TYPE_3D &&
Dave Houlton142c4cb2018-10-17 15:04:41 -0600918 (pCreateInfo->extent.width == 1 || pCreateInfo->extent.height == 1 || pCreateInfo->extent.depth == 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700919 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02053",
920 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV and "
921 "imageType is VK_IMAGE_TYPE_3D, extent.width, extent.height, and extent.depth "
922 "must be greater than 1.");
Jeff Bolzef40fec2018-09-01 22:04:34 -0500923 }
924 }
Andrew Fobel3abeb992020-01-20 16:33:22 -0500925
sfricke-samsung8f658d42020-05-03 20:12:24 -0700926 if (((pCreateInfo->flags & VK_IMAGE_CREATE_SAMPLE_LOCATIONS_COMPATIBLE_DEPTH_BIT_EXT) != 0) &&
sfricke-samsung61a57c02021-01-10 21:35:12 -0800927 (FormatHasDepth(image_format) == false)) {
sfricke-samsung8f658d42020-05-03 20:12:24 -0700928 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-01533",
929 "vkCreateImage(): if flags contain VK_IMAGE_CREATE_SAMPLE_LOCATIONS_COMPATIBLE_DEPTH_BIT_EXT the "
sfricke-samsung61a57c02021-01-10 21:35:12 -0800930 "format (%s) must be a depth or depth/stencil format.",
931 string_VkFormat(image_format));
sfricke-samsung8f658d42020-05-03 20:12:24 -0700932 }
933
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700934 const auto image_stencil_struct = LvlFindInChain<VkImageStencilUsageCreateInfo>(pCreateInfo->pNext);
Andrew Fobel3abeb992020-01-20 16:33:22 -0500935 if (image_stencil_struct != nullptr) {
936 if ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT) != 0) {
937 VkImageUsageFlags legal_flags = (VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT | VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT);
938 // No flags other than the legal attachment bits may be set
939 legal_flags |= VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT;
940 if ((image_stencil_struct->stencilUsage & ~legal_flags) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700941 skip |= LogError(device, "VUID-VkImageStencilUsageCreateInfo-stencilUsage-02539",
942 "vkCreateImage(): in pNext chain, VkImageStencilUsageCreateInfo::stencilUsage includes "
943 "VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT, it must not include bits other than "
944 "VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT or VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT");
Andrew Fobel3abeb992020-01-20 16:33:22 -0500945 }
946 }
947
sfricke-samsung61a57c02021-01-10 21:35:12 -0800948 if (FormatIsDepthOrStencil(image_format)) {
Andrew Fobel3abeb992020-01-20 16:33:22 -0500949 if ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT) != 0) {
950 if (pCreateInfo->extent.width > device_limits.maxFramebufferWidth) {
951 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700952 LogError(device, "VUID-VkImageCreateInfo-Format-02536",
953 "vkCreateImage(): Depth-stencil image contains VkImageStencilUsageCreateInfo structure with "
954 "stencilUsage including VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT and image width exceeds device "
955 "maxFramebufferWidth");
Andrew Fobel3abeb992020-01-20 16:33:22 -0500956 }
957
958 if (pCreateInfo->extent.height > device_limits.maxFramebufferHeight) {
959 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700960 LogError(device, "VUID-VkImageCreateInfo-format-02537",
961 "vkCreateImage(): Depth-stencil image contains VkImageStencilUsageCreateInfo structure with "
962 "stencilUsage including VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT and image height exceeds device "
963 "maxFramebufferHeight");
Andrew Fobel3abeb992020-01-20 16:33:22 -0500964 }
965 }
966
967 if (!physical_device_features.shaderStorageImageMultisample &&
968 ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_STORAGE_BIT) != 0) &&
969 (pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT)) {
970 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700971 LogError(device, "VUID-VkImageCreateInfo-format-02538",
972 "vkCreateImage(): Depth-stencil image contains VkImageStencilUsageCreateInfo structure with "
973 "stencilUsage including VK_IMAGE_USAGE_STORAGE_BIT and the multisampled storage images feature is "
974 "not enabled, image samples must be VK_SAMPLE_COUNT_1_BIT");
Andrew Fobel3abeb992020-01-20 16:33:22 -0500975 }
976
977 if (((pCreateInfo->usage & VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT) != 0) &&
978 ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT) == 0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700979 skip |= LogError(
980 device, "VUID-VkImageCreateInfo-format-02795",
Andrew Fobel3abeb992020-01-20 16:33:22 -0500981 "vkCreateImage(): Depth-stencil image in which usage includes VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT "
982 "contains VkImageStencilUsageCreateInfo structure, VkImageStencilUsageCreateInfo::stencilUsage must "
983 "also include VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT");
984 } else if (((pCreateInfo->usage & VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT) == 0) &&
985 ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT) != 0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700986 skip |= LogError(
987 device, "VUID-VkImageCreateInfo-format-02796",
Andrew Fobel3abeb992020-01-20 16:33:22 -0500988 "vkCreateImage(): Depth-stencil image in which usage does not include "
989 "VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT "
990 "contains VkImageStencilUsageCreateInfo structure, VkImageStencilUsageCreateInfo::stencilUsage must "
991 "also not include VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT");
992 }
993
994 if (((pCreateInfo->usage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT) != 0) &&
995 ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT) == 0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700996 skip |= LogError(
997 device, "VUID-VkImageCreateInfo-format-02797",
Andrew Fobel3abeb992020-01-20 16:33:22 -0500998 "vkCreateImage(): Depth-stencil image in which usage includes VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT "
999 "contains VkImageStencilUsageCreateInfo structure, VkImageStencilUsageCreateInfo::stencilUsage must "
1000 "also include VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT");
1001 } else if (((pCreateInfo->usage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT) == 0) &&
1002 ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT) != 0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001003 skip |= LogError(
1004 device, "VUID-VkImageCreateInfo-format-02798",
Andrew Fobel3abeb992020-01-20 16:33:22 -05001005 "vkCreateImage(): Depth-stencil image in which usage does not include "
1006 "VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT "
1007 "contains VkImageStencilUsageCreateInfo structure, VkImageStencilUsageCreateInfo::stencilUsage must "
1008 "also not include VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT");
1009 }
1010 }
1011 }
Spencer Frickeca52b5c2020-03-16 17:34:00 -07001012
1013 if ((!physical_device_features.shaderStorageImageMultisample) && ((pCreateInfo->usage & VK_IMAGE_USAGE_STORAGE_BIT) != 0) &&
1014 (pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT)) {
1015 skip |= LogError(device, "VUID-VkImageCreateInfo-usage-00968",
1016 "vkCreateImage(): usage contains VK_IMAGE_USAGE_STORAGE_BIT and the multisampled storage images "
1017 "feature is not enabled, image samples must be VK_SAMPLE_COUNT_1_BIT");
1018 }
Spencer Fricke6f8b8ac2020-04-06 07:36:50 -07001019
Mark Lobodzinski09b4caa2020-11-20 17:26:46 -07001020 std::vector<uint64_t> image_create_drm_format_modifiers;
Spencer Fricke6f8b8ac2020-04-06 07:36:50 -07001021 if (device_extensions.vk_ext_image_drm_format_modifier) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07001022 const auto drm_format_mod_list = LvlFindInChain<VkImageDrmFormatModifierListCreateInfoEXT>(pCreateInfo->pNext);
1023 const auto drm_format_mod_explict = LvlFindInChain<VkImageDrmFormatModifierExplicitCreateInfoEXT>(pCreateInfo->pNext);
Spencer Fricke6f8b8ac2020-04-06 07:36:50 -07001024 if (pCreateInfo->tiling == VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT) {
1025 if (((drm_format_mod_list != nullptr) && (drm_format_mod_explict != nullptr)) ||
1026 ((drm_format_mod_list == nullptr) && (drm_format_mod_explict == nullptr))) {
1027 skip |= LogError(device, "VUID-VkImageCreateInfo-tiling-02261",
1028 "vkCreateImage(): Tiling is VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT but pNext must have "
1029 "either VkImageDrmFormatModifierListCreateInfoEXT or "
1030 "VkImageDrmFormatModifierExplicitCreateInfoEXT in the pNext chain");
Mark Lobodzinski09b4caa2020-11-20 17:26:46 -07001031 } else if (drm_format_mod_list != nullptr) {
1032 image_create_drm_format_modifiers.push_back(drm_format_mod_explict->drmFormatModifier);
1033 } else if (drm_format_mod_list != nullptr) {
1034 for (uint32_t i = 0; i < drm_format_mod_list->drmFormatModifierCount; i++) {
1035 image_create_drm_format_modifiers.push_back(*drm_format_mod_list->pDrmFormatModifiers);
1036 }
Spencer Fricke6f8b8ac2020-04-06 07:36:50 -07001037 }
1038 } else if ((drm_format_mod_list != nullptr) || (drm_format_mod_explict != nullptr)) {
1039 skip |= LogError(device, "VUID-VkImageCreateInfo-pNext-02262",
1040 "vkCreateImage(): Tiling is not VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT but there is a "
1041 "VkImageDrmFormatModifierListCreateInfoEXT or VkImageDrmFormatModifierExplicitCreateInfoEXT "
1042 "in the pNext chain");
1043 }
1044 }
janharaldfredriksen-arm3b793772020-05-12 18:55:53 +02001045
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001046 static const uint64_t drm_format_mod_linear = 0;
Mark Lobodzinski09b4caa2020-11-20 17:26:46 -07001047 bool image_create_maybe_linear = false;
1048 if (pCreateInfo->tiling == VK_IMAGE_TILING_LINEAR) {
1049 image_create_maybe_linear = true;
1050 } else if (pCreateInfo->tiling == VK_IMAGE_TILING_OPTIMAL) {
1051 image_create_maybe_linear = false;
1052 } else if (pCreateInfo->tiling == VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT) {
1053 image_create_maybe_linear =
1054 (std::find(image_create_drm_format_modifiers.begin(), image_create_drm_format_modifiers.end(),
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001055 drm_format_mod_linear) != image_create_drm_format_modifiers.end());
Mark Lobodzinski09b4caa2020-11-20 17:26:46 -07001056 }
1057
1058 // If multi-sample, validate type, usage, tiling and mip levels.
1059 if ((pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT) &&
1060 ((pCreateInfo->imageType != VK_IMAGE_TYPE_2D) || (pCreateInfo->flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) ||
1061 (pCreateInfo->mipLevels != 1) || image_create_maybe_linear)) {
1062 skip |= LogError(device, "VUID-VkImageCreateInfo-samples-02257",
1063 "vkCreateImage(): Multi-sample image with incompatible type, usage, tiling, or mips.");
1064 }
1065
1066 if ((pCreateInfo->flags & VK_IMAGE_CREATE_SPLIT_INSTANCE_BIND_REGIONS_BIT) &&
1067 ((pCreateInfo->mipLevels != 1) || (pCreateInfo->arrayLayers != 1) || (pCreateInfo->imageType != VK_IMAGE_TYPE_2D) ||
1068 image_create_maybe_linear)) {
1069 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02259",
1070 "vkCreateImage(): Multi-device image with incompatible type, usage, tiling, or mips.");
1071 }
1072
janharaldfredriksen-arm3b793772020-05-12 18:55:53 +02001073 if (pCreateInfo->usage & VK_IMAGE_USAGE_FRAGMENT_DENSITY_MAP_BIT_EXT) {
1074 if (pCreateInfo->imageType != VK_IMAGE_TYPE_2D) {
1075 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02557",
1076 "vkCreateImage: if usage includes VK_IMAGE_USAGE_FRAGMENT_DENSITY_MAP_BIT_EXT, "
1077 "imageType must be VK_IMAGE_TYPE_2D.");
1078 }
1079 if (pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT) {
1080 skip |= LogError(device, "VUID-VkImageCreateInfo-samples-02558",
1081 "vkCreateImage: if usage includes VK_IMAGE_USAGE_FRAGMENT_DENSITY_MAP_BIT_EXT, "
1082 "samples must be VK_SAMPLE_COUNT_1_BIT.");
1083 }
janharaldfredriksen-arm3b793772020-05-12 18:55:53 +02001084 }
1085 if (pCreateInfo->flags & VK_IMAGE_CREATE_SUBSAMPLED_BIT_EXT) {
1086 if (pCreateInfo->tiling != VK_IMAGE_TILING_OPTIMAL) {
1087 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02565",
1088 "vkCreateImage: if usage includes VK_IMAGE_CREATE_SUBSAMPLED_BIT_EXT, "
1089 "tiling must be VK_IMAGE_TILING_OPTIMAL.");
1090 }
1091 if (pCreateInfo->imageType != VK_IMAGE_TYPE_2D) {
1092 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02566",
1093 "vkCreateImage: if flags includes VK_IMAGE_CREATE_SUBSAMPLED_BIT_EXT, "
1094 "imageType must be VK_IMAGE_TYPE_2D.");
1095 }
1096 if (pCreateInfo->flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) {
1097 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02567",
1098 "vkCreateImage: if flags includes VK_IMAGE_CREATE_SUBSAMPLED_BIT_EXT, "
1099 "flags must not include VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT.");
1100 }
1101 if (pCreateInfo->mipLevels != 1) {
1102 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02568",
1103 "vkCreateImage: if flags includes VK_IMAGE_CREATE_SUBSAMPLED_BIT_EXT, mipLevels (%d) must be 1.",
1104 pCreateInfo->mipLevels);
1105 }
1106 }
sfricke-samsungddaf72b2020-06-23 21:39:28 -07001107
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07001108 const auto swapchain_create_info = LvlFindInChain<VkImageSwapchainCreateInfoKHR>(pCreateInfo->pNext);
sfricke-samsungddaf72b2020-06-23 21:39:28 -07001109 if (swapchain_create_info != nullptr) {
1110 if (swapchain_create_info->swapchain != VK_NULL_HANDLE) {
1111 // All the following fall under the same VU that checks that the swapchain image uses parameters limited by the
1112 // table in #swapchain-wsi-image-create-info. Breaking up into multiple checks allows for more useful information
1113 // returned why this error occured. Check for matching Swapchain flags is done later in state tracking validation
1114 const char *vuid = "VUID-VkImageSwapchainCreateInfoKHR-swapchain-00995";
1115 const char *base_message = "vkCreateImage(): The image used for creating a presentable swapchain image";
1116
1117 if (pCreateInfo->imageType != VK_IMAGE_TYPE_2D) {
1118 // also implicitly forces the check above that extent.depth is 1
1119 skip |= LogError(device, vuid, "%s must have a imageType value VK_IMAGE_TYPE_2D instead of %s.", base_message,
1120 string_VkImageType(pCreateInfo->imageType));
1121 }
1122 if (pCreateInfo->mipLevels != 1) {
1123 skip |= LogError(device, vuid, "%s must have a mipLevels value of 1 instead of %u.", base_message,
1124 pCreateInfo->mipLevels);
1125 }
1126 if (pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT) {
1127 skip |= LogError(device, vuid, "%s must have a samples value of VK_SAMPLE_COUNT_1_BIT instead of %s.",
1128 base_message, string_VkSampleCountFlagBits(pCreateInfo->samples));
1129 }
1130 if (pCreateInfo->tiling != VK_IMAGE_TILING_OPTIMAL) {
1131 skip |= LogError(device, vuid, "%s must have a tiling value of VK_IMAGE_TILING_OPTIMAL instead of %s.",
1132 base_message, string_VkImageTiling(pCreateInfo->tiling));
1133 }
1134 if (pCreateInfo->initialLayout != VK_IMAGE_LAYOUT_UNDEFINED) {
1135 skip |= LogError(device, vuid, "%s must have a initialLayout value of VK_IMAGE_LAYOUT_UNDEFINED instead of %s.",
1136 base_message, string_VkImageLayout(pCreateInfo->initialLayout));
1137 }
1138 const VkImageCreateFlags valid_flags =
1139 (VK_IMAGE_CREATE_SPLIT_INSTANCE_BIND_REGIONS_BIT | VK_IMAGE_CREATE_PROTECTED_BIT |
Mike Schuchardt2df08912020-12-15 16:28:09 -08001140 VK_IMAGE_CREATE_MUTABLE_FORMAT_BIT | VK_IMAGE_CREATE_EXTENDED_USAGE_BIT);
sfricke-samsungddaf72b2020-06-23 21:39:28 -07001141 if ((pCreateInfo->flags & ~valid_flags) != 0) {
1142 skip |= LogError(device, vuid, "%s flags are %" PRIu32 "and must only have valid flags set.", base_message,
1143 pCreateInfo->flags);
1144 }
1145 }
1146 }
sfricke-samsung61a57c02021-01-10 21:35:12 -08001147
1148 // If Chroma subsampled format ( _420_ or _422_ )
1149 if (FormatIsXChromaSubsampled(image_format) && (SafeModulo(pCreateInfo->extent.width, 2) != 0)) {
1150 skip |=
1151 LogError(device, "VUID-VkImageCreateInfo-format-04712",
1152 "vkCreateImage(): The format (%s) is X Chroma Subsampled (has _422 or _420 suffix) so the width (=%" PRIu32
1153 ") must be a multiple of 2.",
1154 string_VkFormat(image_format), pCreateInfo->extent.width);
1155 }
1156 if (FormatIsYChromaSubsampled(image_format) && (SafeModulo(pCreateInfo->extent.height, 2) != 0)) {
1157 skip |= LogError(device, "VUID-VkImageCreateInfo-format-04713",
1158 "vkCreateImage(): The format (%s) is Y Chroma Subsampled (has _420 suffix) so the height (=%" PRIu32
1159 ") must be a multiple of 2.",
1160 string_VkFormat(image_format), pCreateInfo->extent.height);
1161 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001162 }
Jeff Bolzef40fec2018-09-01 22:04:34 -05001163
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001164 return skip;
1165}
1166
Jeff Bolz99e3f632020-03-24 22:59:22 -05001167bool StatelessValidation::manual_PreCallValidateCreateImageView(VkDevice device, const VkImageViewCreateInfo *pCreateInfo,
1168 const VkAllocationCallbacks *pAllocator, VkImageView *pView) const {
1169 bool skip = false;
1170
1171 if (pCreateInfo != nullptr) {
Spencer Fricke528e0982020-04-19 18:46:01 -07001172 // Validate feature set if using CUBE_ARRAY
1173 if ((pCreateInfo->viewType == VK_IMAGE_VIEW_TYPE_CUBE_ARRAY) && (physical_device_features.imageCubeArray == false)) {
1174 skip |= LogError(pCreateInfo->image, "VUID-VkImageViewCreateInfo-viewType-01004",
1175 "vkCreateImageView(): pCreateInfo->viewType can't be VK_IMAGE_VIEW_TYPE_CUBE_ARRAY without "
1176 "enabling the imageCubeArray feature.");
1177 }
1178
Jeff Bolz99e3f632020-03-24 22:59:22 -05001179 if (pCreateInfo->subresourceRange.layerCount != VK_REMAINING_ARRAY_LAYERS) {
1180 if (pCreateInfo->viewType == VK_IMAGE_VIEW_TYPE_CUBE && pCreateInfo->subresourceRange.layerCount != 6) {
1181 skip |= LogError(device, "VUID-VkImageViewCreateInfo-viewType-02960",
Spencer Fricke528e0982020-04-19 18:46:01 -07001182 "vkCreateImageView(): subresourceRange.layerCount (%d) must be 6 or VK_REMAINING_ARRAY_LAYERS.",
Jeff Bolz99e3f632020-03-24 22:59:22 -05001183 pCreateInfo->subresourceRange.layerCount);
1184 }
1185 if (pCreateInfo->viewType == VK_IMAGE_VIEW_TYPE_CUBE_ARRAY && (pCreateInfo->subresourceRange.layerCount % 6) != 0) {
Spencer Fricke528e0982020-04-19 18:46:01 -07001186 skip |= LogError(
1187 device, "VUID-VkImageViewCreateInfo-viewType-02961",
1188 "vkCreateImageView(): subresourceRange.layerCount (%d) must be a multiple of 6 or VK_REMAINING_ARRAY_LAYERS.",
1189 pCreateInfo->subresourceRange.layerCount);
Jeff Bolz99e3f632020-03-24 22:59:22 -05001190 }
1191 }
sfricke-samsung0c4a06f2020-06-27 01:24:32 -07001192
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07001193 auto astc_decode_mode = LvlFindInChain<VkImageViewASTCDecodeModeEXT>(pCreateInfo->pNext);
sfricke-samsung0c4a06f2020-06-27 01:24:32 -07001194 if ((device_extensions.vk_ext_astc_decode_mode) && (astc_decode_mode != nullptr)) {
1195 if ((astc_decode_mode->decodeMode != VK_FORMAT_R16G16B16A16_SFLOAT) &&
1196 (astc_decode_mode->decodeMode != VK_FORMAT_R8G8B8A8_UNORM) &&
1197 (astc_decode_mode->decodeMode != VK_FORMAT_E5B9G9R9_UFLOAT_PACK32)) {
1198 skip |= LogError(device, "VUID-VkImageViewASTCDecodeModeEXT-decodeMode-02230",
1199 "vkCreateImageView(): VkImageViewASTCDecodeModeEXT::decodeMode must be "
1200 "VK_FORMAT_R16G16B16A16_SFLOAT, VK_FORMAT_R8G8B8A8_UNORM, or VK_FORMAT_E5B9G9R9_UFLOAT_PACK32.");
1201 }
1202 if (FormatIsCompressed_ASTC(pCreateInfo->format) == false) {
1203 skip |= LogError(device, "VUID-VkImageViewASTCDecodeModeEXT-format-04084",
1204 "vkCreateImageView(): is using a VkImageViewASTCDecodeModeEXT but the image view format is %s and "
1205 "not an ASTC format.",
1206 string_VkFormat(pCreateInfo->format));
1207 }
1208 }
sfricke-samsung83d98122020-07-04 06:21:15 -07001209
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07001210 auto ycbcr_conversion = LvlFindInChain<VkSamplerYcbcrConversionInfo>(pCreateInfo->pNext);
sfricke-samsung83d98122020-07-04 06:21:15 -07001211 if (ycbcr_conversion != nullptr) {
1212 if (ycbcr_conversion->conversion != VK_NULL_HANDLE) {
1213 if (IsIdentitySwizzle(pCreateInfo->components) == false) {
1214 skip |= LogError(
1215 device, "VUID-VkImageViewCreateInfo-pNext-01970",
1216 "vkCreateImageView(): If there is a VkSamplerYcbcrConversion, the imageView must "
1217 "be created with the identity swizzle. Here are the actual swizzle values:\n"
1218 "r swizzle = %s\n"
1219 "g swizzle = %s\n"
1220 "b swizzle = %s\n"
1221 "a swizzle = %s\n",
1222 string_VkComponentSwizzle(pCreateInfo->components.r), string_VkComponentSwizzle(pCreateInfo->components.g),
1223 string_VkComponentSwizzle(pCreateInfo->components.b), string_VkComponentSwizzle(pCreateInfo->components.a));
1224 }
1225 }
1226 }
Jeff Bolz99e3f632020-03-24 22:59:22 -05001227 }
1228 return skip;
1229}
1230
Jeff Bolz6d3beaa2019-02-09 21:00:05 -06001231bool StatelessValidation::manual_PreCallValidateViewport(const VkViewport &viewport, const char *fn_name,
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001232 const ParameterName &parameter_name, VkCommandBuffer object) const {
Petr Krausb3fcdb42018-01-09 22:09:09 +01001233 bool skip = false;
Petr Krausb3fcdb42018-01-09 22:09:09 +01001234
1235 // Note: for numerical correctness
1236 // - float comparisons should expect NaN (comparison always false).
1237 // - VkPhysicalDeviceLimits::maxViewportDimensions is uint32_t, not float -> careful.
1238
1239 const auto f_lte_u32_exact = [](const float v1_f, const uint32_t v2_u32) {
John Zulaufac0876c2018-02-19 10:09:35 -07001240 if (std::isnan(v1_f)) return false;
Petr Krausb3fcdb42018-01-09 22:09:09 +01001241 if (v1_f <= 0.0f) return true;
1242
1243 float intpart;
1244 const float fract = modff(v1_f, &intpart);
1245
1246 assert(std::numeric_limits<float>::radix == 2);
1247 const float u32_max_plus1 = ldexpf(1.0f, 32); // hopefully exact
1248 if (intpart >= u32_max_plus1) return false;
1249
1250 uint32_t v1_u32 = static_cast<uint32_t>(intpart);
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001251 if (v1_u32 < v2_u32) {
Petr Krausb3fcdb42018-01-09 22:09:09 +01001252 return true;
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001253 } else if (v1_u32 == v2_u32 && fract == 0.0f) {
Petr Krausb3fcdb42018-01-09 22:09:09 +01001254 return true;
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001255 } else {
Petr Krausb3fcdb42018-01-09 22:09:09 +01001256 return false;
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001257 }
Petr Krausb3fcdb42018-01-09 22:09:09 +01001258 };
1259
1260 const auto f_lte_u32_direct = [](const float v1_f, const uint32_t v2_u32) {
1261 const float v2_f = static_cast<float>(v2_u32); // not accurate for > radix^digits; and undefined rounding mode
1262 return (v1_f <= v2_f);
1263 };
1264
1265 // width
1266 bool width_healthy = true;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001267 const auto max_w = device_limits.maxViewportDimensions[0];
Petr Krausb3fcdb42018-01-09 22:09:09 +01001268
1269 if (!(viewport.width > 0.0f)) {
1270 width_healthy = false;
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001271 skip |= LogError(object, "VUID-VkViewport-width-01770", "%s: %s.width (=%f) is not greater than 0.0.", fn_name,
1272 parameter_name.get_name().c_str(), viewport.width);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001273 } else if (!(f_lte_u32_exact(viewport.width, max_w) || f_lte_u32_direct(viewport.width, max_w))) {
1274 width_healthy = false;
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001275 skip |= LogError(object, "VUID-VkViewport-width-01771",
1276 "%s: %s.width (=%f) exceeds VkPhysicalDeviceLimits::maxViewportDimensions[0] (=%" PRIu32 ").", fn_name,
1277 parameter_name.get_name().c_str(), viewport.width, max_w);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001278 }
1279
1280 // height
1281 bool height_healthy = true;
Mark Lobodzinskia09ab942020-02-20 11:01:59 -07001282 const bool negative_height_enabled = device_extensions.vk_khr_maintenance1 || device_extensions.vk_amd_negative_viewport_height;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001283 const auto max_h = device_limits.maxViewportDimensions[1];
Petr Krausb3fcdb42018-01-09 22:09:09 +01001284
1285 if (!negative_height_enabled && !(viewport.height > 0.0f)) {
1286 height_healthy = false;
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001287 skip |= LogError(object, "VUID-VkViewport-height-01772", "%s: %s.height (=%f) is not greater 0.0.", fn_name,
1288 parameter_name.get_name().c_str(), viewport.height);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001289 } else if (!(f_lte_u32_exact(fabsf(viewport.height), max_h) || f_lte_u32_direct(fabsf(viewport.height), max_h))) {
1290 height_healthy = false;
1291
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001292 skip |= LogError(object, "VUID-VkViewport-height-01773",
1293 "%s: Absolute value of %s.height (=%f) exceeds VkPhysicalDeviceLimits::maxViewportDimensions[1] (=%" PRIu32
1294 ").",
1295 fn_name, parameter_name.get_name().c_str(), viewport.height, max_h);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001296 }
1297
1298 // x
1299 bool x_healthy = true;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001300 if (!(viewport.x >= device_limits.viewportBoundsRange[0])) {
Petr Krausb3fcdb42018-01-09 22:09:09 +01001301 x_healthy = false;
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001302 skip |= LogError(object, "VUID-VkViewport-x-01774",
1303 "%s: %s.x (=%f) is less than VkPhysicalDeviceLimits::viewportBoundsRange[0] (=%f).", fn_name,
1304 parameter_name.get_name().c_str(), viewport.x, device_limits.viewportBoundsRange[0]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001305 }
1306
1307 // x + width
1308 if (x_healthy && width_healthy) {
1309 const float right_bound = viewport.x + viewport.width;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001310 if (!(right_bound <= device_limits.viewportBoundsRange[1])) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001311 skip |= LogError(
1312 object, "VUID-VkViewport-x-01232",
1313 "%s: %s.x + %s.width (=%f + %f = %f) is greater than VkPhysicalDeviceLimits::viewportBoundsRange[1] (=%f).",
1314 fn_name, parameter_name.get_name().c_str(), parameter_name.get_name().c_str(), viewport.x, viewport.width,
1315 right_bound, device_limits.viewportBoundsRange[1]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001316 }
1317 }
1318
1319 // y
1320 bool y_healthy = true;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001321 if (!(viewport.y >= device_limits.viewportBoundsRange[0])) {
Petr Krausb3fcdb42018-01-09 22:09:09 +01001322 y_healthy = false;
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001323 skip |= LogError(object, "VUID-VkViewport-y-01775",
1324 "%s: %s.y (=%f) is less than VkPhysicalDeviceLimits::viewportBoundsRange[0] (=%f).", fn_name,
1325 parameter_name.get_name().c_str(), viewport.y, device_limits.viewportBoundsRange[0]);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001326 } else if (negative_height_enabled && !(viewport.y <= device_limits.viewportBoundsRange[1])) {
Petr Krausb3fcdb42018-01-09 22:09:09 +01001327 y_healthy = false;
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001328 skip |= LogError(object, "VUID-VkViewport-y-01776",
1329 "%s: %s.y (=%f) exceeds VkPhysicalDeviceLimits::viewportBoundsRange[1] (=%f).", fn_name,
1330 parameter_name.get_name().c_str(), viewport.y, device_limits.viewportBoundsRange[1]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001331 }
1332
1333 // y + height
1334 if (y_healthy && height_healthy) {
1335 const float boundary = viewport.y + viewport.height;
1336
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001337 if (!(boundary <= device_limits.viewportBoundsRange[1])) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001338 skip |= LogError(object, "VUID-VkViewport-y-01233",
1339 "%s: %s.y + %s.height (=%f + %f = %f) exceeds VkPhysicalDeviceLimits::viewportBoundsRange[1] (=%f).",
1340 fn_name, parameter_name.get_name().c_str(), parameter_name.get_name().c_str(), viewport.y,
1341 viewport.height, boundary, device_limits.viewportBoundsRange[1]);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001342 } else if (negative_height_enabled && !(boundary >= device_limits.viewportBoundsRange[0])) {
Jeff Bolz6d3beaa2019-02-09 21:00:05 -06001343 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001344 LogError(object, "VUID-VkViewport-y-01777",
1345 "%s: %s.y + %s.height (=%f + %f = %f) is less than VkPhysicalDeviceLimits::viewportBoundsRange[0] (=%f).",
1346 fn_name, parameter_name.get_name().c_str(), parameter_name.get_name().c_str(), viewport.y, viewport.height,
1347 boundary, device_limits.viewportBoundsRange[0]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001348 }
1349 }
1350
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001351 if (!device_extensions.vk_ext_depth_range_unrestricted) {
Petr Krausb3fcdb42018-01-09 22:09:09 +01001352 // minDepth
1353 if (!(viewport.minDepth >= 0.0) || !(viewport.minDepth <= 1.0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001354 skip |= LogError(object, "VUID-VkViewport-minDepth-01234",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001355
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001356 "%s: VK_EXT_depth_range_unrestricted extension is not enabled and %s.minDepth (=%f) is not within the "
1357 "[0.0, 1.0] range.",
1358 fn_name, parameter_name.get_name().c_str(), viewport.minDepth);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001359 }
1360
1361 // maxDepth
1362 if (!(viewport.maxDepth >= 0.0) || !(viewport.maxDepth <= 1.0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001363 skip |= LogError(object, "VUID-VkViewport-maxDepth-01235",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001364
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001365 "%s: VK_EXT_depth_range_unrestricted extension is not enabled and %s.maxDepth (=%f) is not within the "
1366 "[0.0, 1.0] range.",
1367 fn_name, parameter_name.get_name().c_str(), viewport.maxDepth);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001368 }
1369 }
1370
1371 return skip;
1372}
1373
Dave Houlton142c4cb2018-10-17 15:04:41 -06001374struct SampleOrderInfo {
Jeff Bolz9af91c52018-09-01 21:53:57 -05001375 VkShadingRatePaletteEntryNV shadingRate;
1376 uint32_t width;
1377 uint32_t height;
1378};
1379
1380// All palette entries with more than one pixel per fragment
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001381static SampleOrderInfo sample_order_infos[] = {
Dave Houlton142c4cb2018-10-17 15:04:41 -06001382 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_1X2_PIXELS_NV, 1, 2},
1383 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_2X1_PIXELS_NV, 2, 1},
1384 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_2X2_PIXELS_NV, 2, 2},
1385 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_4X2_PIXELS_NV, 4, 2},
1386 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_2X4_PIXELS_NV, 2, 4},
1387 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_4X4_PIXELS_NV, 4, 4},
Jeff Bolz9af91c52018-09-01 21:53:57 -05001388};
1389
Jeff Bolz46c0ea02019-10-09 13:06:29 -05001390bool StatelessValidation::ValidateCoarseSampleOrderCustomNV(const VkCoarseSampleOrderCustomNV *order) const {
Jeff Bolz9af91c52018-09-01 21:53:57 -05001391 bool skip = false;
Jeff Bolz9af91c52018-09-01 21:53:57 -05001392
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001393 SampleOrderInfo *sample_order_info;
1394 uint32_t info_idx = 0;
1395 for (sample_order_info = nullptr; info_idx < ARRAY_SIZE(sample_order_infos); ++info_idx) {
1396 if (sample_order_infos[info_idx].shadingRate == order->shadingRate) {
1397 sample_order_info = &sample_order_infos[info_idx];
Jeff Bolz9af91c52018-09-01 21:53:57 -05001398 break;
1399 }
1400 }
1401
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001402 if (sample_order_info == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001403 skip |= LogError(device, "VUID-VkCoarseSampleOrderCustomNV-shadingRate-02073",
1404 "VkCoarseSampleOrderCustomNV shadingRate must be a shading rate "
1405 "that generates fragments with more than one pixel.");
Jeff Bolz9af91c52018-09-01 21:53:57 -05001406 return skip;
1407 }
1408
Dave Houlton142c4cb2018-10-17 15:04:41 -06001409 if (order->sampleCount == 0 || (order->sampleCount & (order->sampleCount - 1)) ||
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001410 !(order->sampleCount & device_limits.framebufferNoAttachmentsSampleCounts)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001411 skip |= LogError(device, "VUID-VkCoarseSampleOrderCustomNV-sampleCount-02074",
1412 "VkCoarseSampleOrderCustomNV sampleCount (=%" PRIu32
1413 ") must "
1414 "correspond to a sample count enumerated in VkSampleCountFlags whose corresponding bit "
1415 "is set in framebufferNoAttachmentsSampleCounts.",
1416 order->sampleCount);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001417 }
1418
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001419 if (order->sampleLocationCount != order->sampleCount * sample_order_info->width * sample_order_info->height) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001420 skip |= LogError(device, "VUID-VkCoarseSampleOrderCustomNV-sampleLocationCount-02075",
1421 "VkCoarseSampleOrderCustomNV sampleLocationCount (=%" PRIu32
1422 ") must "
1423 "be equal to the product of sampleCount (=%" PRIu32
1424 "), the fragment width for shadingRate "
1425 "(=%" PRIu32 "), and the fragment height for shadingRate (=%" PRIu32 ").",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001426 order->sampleLocationCount, order->sampleCount, sample_order_info->width, sample_order_info->height);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001427 }
1428
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001429 if (order->sampleLocationCount > phys_dev_ext_props.shading_rate_image_props.shadingRateMaxCoarseSamples) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001430 skip |= LogError(
1431 device, "VUID-VkCoarseSampleOrderCustomNV-sampleLocationCount-02076",
Dave Houlton142c4cb2018-10-17 15:04:41 -06001432 "VkCoarseSampleOrderCustomNV sampleLocationCount (=%" PRIu32
1433 ") must "
1434 "be less than or equal to VkPhysicalDeviceShadingRateImagePropertiesNV shadingRateMaxCoarseSamples (=%" PRIu32 ").",
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001435 order->sampleLocationCount, phys_dev_ext_props.shading_rate_image_props.shadingRateMaxCoarseSamples);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001436 }
Jeff Bolz9af91c52018-09-01 21:53:57 -05001437
1438 // Accumulate a bitmask tracking which (x,y,sample) tuples are seen. Expect
Jeff Bolzb8a8dd02018-09-18 02:39:24 -05001439 // the first width*height*sampleCount bits to all be set. Note: There is no
1440 // guarantee that 64 bits is enough, but practically it's unlikely for an
1441 // implementation to support more than 32 bits for samplemask.
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001442 assert(phys_dev_ext_props.shading_rate_image_props.shadingRateMaxCoarseSamples <= 64);
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001443 uint64_t sample_locations_mask = 0;
Jeff Bolz9af91c52018-09-01 21:53:57 -05001444 for (uint32_t i = 0; i < order->sampleLocationCount; ++i) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001445 const VkCoarseSampleLocationNV *sample_loc = &order->pSampleLocations[i];
1446 if (sample_loc->pixelX >= sample_order_info->width) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001447 skip |= LogError(device, "VUID-VkCoarseSampleLocationNV-pixelX-02078",
1448 "pixelX must be less than the width (in pixels) of the fragment.");
Jeff Bolz9af91c52018-09-01 21:53:57 -05001449 }
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001450 if (sample_loc->pixelY >= sample_order_info->height) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001451 skip |= LogError(device, "VUID-VkCoarseSampleLocationNV-pixelY-02079",
1452 "pixelY must be less than the height (in pixels) of the fragment.");
Jeff Bolz9af91c52018-09-01 21:53:57 -05001453 }
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001454 if (sample_loc->sample >= order->sampleCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001455 skip |= LogError(device, "VUID-VkCoarseSampleLocationNV-sample-02080",
1456 "sample must be less than the number of coverage samples in each pixel belonging to the fragment.");
Jeff Bolz9af91c52018-09-01 21:53:57 -05001457 }
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001458 uint32_t idx =
1459 sample_loc->sample + order->sampleCount * (sample_loc->pixelX + sample_order_info->width * sample_loc->pixelY);
1460 sample_locations_mask |= 1ULL << idx;
Jeff Bolz9af91c52018-09-01 21:53:57 -05001461 }
1462
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001463 uint64_t expected_mask = (order->sampleLocationCount == 64) ? ~0ULL : ((1ULL << order->sampleLocationCount) - 1);
1464 if (sample_locations_mask != expected_mask) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001465 skip |= LogError(
1466 device, "VUID-VkCoarseSampleOrderCustomNV-pSampleLocations-02077",
Dave Houlton142c4cb2018-10-17 15:04:41 -06001467 "The array pSampleLocations must contain exactly one entry for "
1468 "every combination of valid values for pixelX, pixelY, and sample in the structure VkCoarseSampleOrderCustomNV.");
Jeff Bolz9af91c52018-09-01 21:53:57 -05001469 }
1470
1471 return skip;
1472}
1473
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07001474bool StatelessValidation::manual_PreCallValidateCreateGraphicsPipelines(VkDevice device, VkPipelineCache pipelineCache,
1475 uint32_t createInfoCount,
1476 const VkGraphicsPipelineCreateInfo *pCreateInfos,
1477 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05001478 VkPipeline *pPipelines) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001479 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001480
1481 if (pCreateInfos != nullptr) {
1482 for (uint32_t i = 0; i < createInfoCount; ++i) {
Petr Kraus299ba622017-11-24 03:09:03 +01001483 bool has_dynamic_viewport = false;
1484 bool has_dynamic_scissor = false;
1485 bool has_dynamic_line_width = false;
Spencer Fricke8d428882020-03-16 17:23:33 -07001486 bool has_dynamic_depth_bias = false;
1487 bool has_dynamic_blend_constant = false;
1488 bool has_dynamic_depth_bounds = false;
1489 bool has_dynamic_stencil_compare = false;
1490 bool has_dynamic_stencil_write = false;
1491 bool has_dynamic_stencil_reference = false;
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001492 bool has_dynamic_viewport_w_scaling_nv = false;
1493 bool has_dynamic_discard_rectangle_ext = false;
1494 bool has_dynamic_sample_locations_ext = false;
Jeff Bolz3e71f782018-08-29 23:15:45 -05001495 bool has_dynamic_exclusive_scissor_nv = false;
Jeff Bolz9af91c52018-09-01 21:53:57 -05001496 bool has_dynamic_shading_rate_palette_nv = false;
Spencer Fricke8d428882020-03-16 17:23:33 -07001497 bool has_dynamic_viewport_course_sample_order_nv = false;
Jeff Bolz8125a8b2019-08-16 16:29:45 -05001498 bool has_dynamic_line_stipple = false;
Piers Daniell39842ee2020-07-10 16:42:33 -06001499 bool has_dynamic_cull_mode = false;
1500 bool has_dynamic_front_face = false;
1501 bool has_dynamic_primitive_topology = false;
1502 bool has_dynamic_viewport_with_count = false;
1503 bool has_dynamic_scissor_with_count = false;
1504 bool has_dynamic_vertex_input_binding_stride = false;
1505 bool has_dynamic_depth_test_enable = false;
1506 bool has_dynamic_depth_write_enable = false;
1507 bool has_dynamic_depth_compare_op = false;
1508 bool has_dynamic_depth_bounds_test_enable = false;
1509 bool has_dynamic_stencil_test_enable = false;
1510 bool has_dynamic_stencil_op = false;
sourav parmarcd5fb182020-07-17 12:58:44 -07001511 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_SKIP_AABBS_BIT_KHR) {
1512 skip |=
1513 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-03377",
1514 "vkCreateGraphicsPipelines: flags must not include VK_PIPELINE_CREATE_RAY_TRACING_SKIP_AABBS_BIT_KHR");
1515 }
Petr Kraus299ba622017-11-24 03:09:03 +01001516 if (pCreateInfos[i].pDynamicState != nullptr) {
1517 const auto &dynamic_state_info = *pCreateInfos[i].pDynamicState;
1518 for (uint32_t state_index = 0; state_index < dynamic_state_info.dynamicStateCount; ++state_index) {
1519 const auto &dynamic_state = dynamic_state_info.pDynamicStates[state_index];
Spencer Fricke8d428882020-03-16 17:23:33 -07001520 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT) {
1521 if (has_dynamic_viewport == true) {
1522 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1523 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_VIEWPORT was listed twice in the "
1524 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1525 i);
1526 }
1527 has_dynamic_viewport = true;
1528 }
1529 if (dynamic_state == VK_DYNAMIC_STATE_SCISSOR) {
1530 if (has_dynamic_scissor == true) {
1531 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1532 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_SCISSOR was listed twice in the "
1533 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1534 i);
1535 }
1536 has_dynamic_scissor = true;
1537 }
1538 if (dynamic_state == VK_DYNAMIC_STATE_LINE_WIDTH) {
1539 if (has_dynamic_line_width == true) {
1540 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1541 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_LINE_WIDTH was listed twice in the "
1542 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1543 i);
1544 }
1545 has_dynamic_line_width = true;
1546 }
1547 if (dynamic_state == VK_DYNAMIC_STATE_DEPTH_BIAS) {
1548 if (has_dynamic_depth_bias == true) {
1549 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1550 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DEPTH_BIAS was listed twice in the "
1551 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1552 i);
1553 }
1554 has_dynamic_depth_bias = true;
1555 }
1556 if (dynamic_state == VK_DYNAMIC_STATE_BLEND_CONSTANTS) {
1557 if (has_dynamic_blend_constant == true) {
1558 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1559 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_BLEND_CONSTANTS was listed twice in the "
1560 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1561 i);
1562 }
1563 has_dynamic_blend_constant = true;
1564 }
1565 if (dynamic_state == VK_DYNAMIC_STATE_DEPTH_BOUNDS) {
1566 if (has_dynamic_depth_bounds == true) {
1567 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1568 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DEPTH_BOUNDS was listed twice in the "
1569 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1570 i);
1571 }
1572 has_dynamic_depth_bounds = true;
1573 }
1574 if (dynamic_state == VK_DYNAMIC_STATE_STENCIL_COMPARE_MASK) {
1575 if (has_dynamic_stencil_compare == true) {
1576 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1577 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_STENCIL_COMPARE_MASK was listed twice in "
1578 "the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1579 i);
1580 }
1581 has_dynamic_stencil_compare = true;
1582 }
1583 if (dynamic_state == VK_DYNAMIC_STATE_STENCIL_WRITE_MASK) {
1584 if (has_dynamic_stencil_write == true) {
1585 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1586 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_STENCIL_WRITE_MASK was listed twice in "
1587 "the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1588 i);
1589 }
1590 has_dynamic_stencil_write = true;
1591 }
1592 if (dynamic_state == VK_DYNAMIC_STATE_STENCIL_REFERENCE) {
1593 if (has_dynamic_stencil_reference == true) {
1594 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1595 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_STENCIL_REFERENCE was listed twice in "
1596 "the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1597 i);
1598 }
1599 has_dynamic_stencil_reference = true;
1600 }
1601 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT_W_SCALING_NV) {
1602 if (has_dynamic_viewport_w_scaling_nv == true) {
1603 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1604 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_VIEWPORT_W_SCALING_NV was listed twice "
1605 "in the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1606 i);
1607 }
1608 has_dynamic_viewport_w_scaling_nv = true;
1609 }
1610 if (dynamic_state == VK_DYNAMIC_STATE_DISCARD_RECTANGLE_EXT) {
1611 if (has_dynamic_discard_rectangle_ext == true) {
1612 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1613 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DISCARD_RECTANGLE_EXT was listed twice "
1614 "in the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1615 i);
1616 }
1617 has_dynamic_discard_rectangle_ext = true;
1618 }
1619 if (dynamic_state == VK_DYNAMIC_STATE_SAMPLE_LOCATIONS_EXT) {
1620 if (has_dynamic_sample_locations_ext == true) {
1621 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1622 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_SAMPLE_LOCATIONS_EXT was listed twice in "
1623 "the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1624 i);
1625 }
1626 has_dynamic_sample_locations_ext = true;
1627 }
1628 if (dynamic_state == VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV) {
1629 if (has_dynamic_exclusive_scissor_nv == true) {
1630 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1631 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV was listed twice in "
1632 "the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1633 i);
1634 }
1635 has_dynamic_exclusive_scissor_nv = true;
1636 }
1637 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT_SHADING_RATE_PALETTE_NV) {
1638 if (has_dynamic_shading_rate_palette_nv == true) {
1639 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1640 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_VIEWPORT_SHADING_RATE_PALETTE_NV was "
1641 "listed twice in the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1642 i);
1643 }
Dave Houlton142c4cb2018-10-17 15:04:41 -06001644 has_dynamic_shading_rate_palette_nv = true;
Spencer Fricke8d428882020-03-16 17:23:33 -07001645 }
1646 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT_COARSE_SAMPLE_ORDER_NV) {
1647 if (has_dynamic_viewport_course_sample_order_nv == true) {
1648 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1649 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_VIEWPORT_COARSE_SAMPLE_ORDER_NV was "
1650 "listed twice in the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1651 i);
1652 }
1653 has_dynamic_viewport_course_sample_order_nv = true;
1654 }
1655 if (dynamic_state == VK_DYNAMIC_STATE_LINE_STIPPLE_EXT) {
1656 if (has_dynamic_line_stipple == true) {
1657 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1658 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_LINE_STIPPLE_EXT was listed twice in the "
1659 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1660 i);
1661 }
1662 has_dynamic_line_stipple = true;
1663 }
Piers Daniell39842ee2020-07-10 16:42:33 -06001664 if (dynamic_state == VK_DYNAMIC_STATE_CULL_MODE_EXT) {
1665 if (has_dynamic_cull_mode) {
1666 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1667 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_CULL_MODE_EXT was listed twice in the "
1668 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1669 i);
1670 }
1671 has_dynamic_cull_mode = true;
1672 }
1673 if (dynamic_state == VK_DYNAMIC_STATE_FRONT_FACE_EXT) {
1674 if (has_dynamic_front_face) {
1675 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1676 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_FRONT_FACE_EXT was listed twice in the "
1677 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1678 i);
1679 }
1680 has_dynamic_front_face = true;
1681 }
1682 if (dynamic_state == VK_DYNAMIC_STATE_PRIMITIVE_TOPOLOGY_EXT) {
1683 if (has_dynamic_primitive_topology) {
1684 skip |= LogError(
1685 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1686 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_PRIMITIVE_TOPOLOGY_EXT was listed twice in the "
1687 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1688 i);
1689 }
1690 has_dynamic_primitive_topology = true;
1691 }
1692 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT_WITH_COUNT_EXT) {
1693 if (has_dynamic_viewport_with_count) {
1694 skip |= LogError(
1695 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1696 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_VIEWPORT_WITH_COUNT_EXT was listed twice in the "
1697 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1698 i);
1699 }
1700 has_dynamic_viewport_with_count = true;
1701 }
1702 if (dynamic_state == VK_DYNAMIC_STATE_SCISSOR_WITH_COUNT_EXT) {
1703 if (has_dynamic_scissor_with_count) {
1704 skip |= LogError(
1705 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1706 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_SCISSOR_WITH_COUNT_EXT was listed twice in the "
1707 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1708 i);
1709 }
1710 has_dynamic_scissor_with_count = true;
1711 }
1712 if (dynamic_state == VK_DYNAMIC_STATE_VERTEX_INPUT_BINDING_STRIDE_EXT) {
1713 if (has_dynamic_vertex_input_binding_stride) {
1714 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1715 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_VERTEX_INPUT_BINDING_STRIDE_EXT was "
1716 "listed twice in the "
1717 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1718 i);
1719 }
1720 has_dynamic_vertex_input_binding_stride = true;
1721 }
1722 if (dynamic_state == VK_DYNAMIC_STATE_DEPTH_TEST_ENABLE_EXT) {
1723 if (has_dynamic_depth_test_enable) {
1724 skip |= LogError(
1725 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1726 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DEPTH_TEST_ENABLE_EXT was listed twice in the "
1727 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1728 i);
1729 }
1730 has_dynamic_depth_test_enable = true;
1731 }
1732 if (dynamic_state == VK_DYNAMIC_STATE_DEPTH_WRITE_ENABLE_EXT) {
1733 if (has_dynamic_depth_write_enable) {
1734 skip |= LogError(
1735 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1736 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DEPTH_WRITE_ENABLE_EXT was listed twice in the "
1737 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1738 i);
1739 }
1740 has_dynamic_depth_write_enable = true;
1741 }
1742 if (dynamic_state == VK_DYNAMIC_STATE_DEPTH_COMPARE_OP_EXT) {
1743 if (has_dynamic_depth_compare_op) {
1744 skip |=
1745 LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1746 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DEPTH_COMPARE_OP_EXT was listed twice in the "
1747 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1748 i);
1749 }
1750 has_dynamic_depth_compare_op = true;
1751 }
1752 if (dynamic_state == VK_DYNAMIC_STATE_DEPTH_BOUNDS_TEST_ENABLE_EXT) {
1753 if (has_dynamic_depth_bounds_test_enable) {
1754 skip |= LogError(
1755 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1756 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DEPTH_BOUNDS_TEST_ENABLE_EXT was listed twice in the "
1757 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1758 i);
1759 }
1760 has_dynamic_depth_bounds_test_enable = true;
1761 }
1762 if (dynamic_state == VK_DYNAMIC_STATE_STENCIL_TEST_ENABLE_EXT) {
1763 if (has_dynamic_stencil_test_enable) {
1764 skip |= LogError(
1765 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1766 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_STENCIL_TEST_ENABLE_EXT was listed twice in the "
1767 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1768 i);
1769 }
1770 has_dynamic_stencil_test_enable = true;
1771 }
1772 if (dynamic_state == VK_DYNAMIC_STATE_STENCIL_OP_EXT) {
1773 if (has_dynamic_stencil_op) {
1774 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1775 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_STENCIL_OP_EXT was listed twice in the "
1776 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1777 i);
1778 }
1779 has_dynamic_stencil_op = true;
1780 }
Petr Kraus299ba622017-11-24 03:09:03 +01001781 }
1782 }
1783
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07001784 auto feedback_struct = LvlFindInChain<VkPipelineCreationFeedbackCreateInfoEXT>(pCreateInfos[i].pNext);
Peter Chen85366392019-05-14 15:20:11 -04001785 if ((feedback_struct != nullptr) &&
1786 (feedback_struct->pipelineStageCreationFeedbackCount != pCreateInfos[i].stageCount)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001787 skip |= LogError(device, "VUID-VkPipelineCreationFeedbackCreateInfoEXT-pipelineStageCreationFeedbackCount-02668",
1788 "vkCreateGraphicsPipelines(): in pCreateInfo[%" PRIu32
1789 "], VkPipelineCreationFeedbackEXT::pipelineStageCreationFeedbackCount"
1790 "(=%" PRIu32 ") must equal VkGraphicsPipelineCreateInfo::stageCount(=%" PRIu32 ").",
1791 i, feedback_struct->pipelineStageCreationFeedbackCount, pCreateInfos[i].stageCount);
Peter Chen85366392019-05-14 15:20:11 -04001792 }
1793
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001794 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001795
Spencer Frickef1b0a7d2020-03-16 17:38:55 -07001796 // Collect active stages and other information
1797 // Only want to loop through pStages once
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001798 uint32_t active_shaders = 0;
Spencer Frickef1b0a7d2020-03-16 17:38:55 -07001799 bool has_eval = false;
1800 bool has_control = false;
1801 if (pCreateInfos[i].pStages != nullptr) {
1802 for (uint32_t stage_index = 0; stage_index < pCreateInfos[i].stageCount; ++stage_index) {
1803 active_shaders |= pCreateInfos[i].pStages[stage_index].stage;
1804
1805 if (pCreateInfos[i].pStages[stage_index].stage == VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) {
1806 has_control = true;
1807 } else if (pCreateInfos[i].pStages[stage_index].stage == VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT) {
1808 has_eval = true;
1809 }
1810
1811 skip |= validate_string(
1812 "vkCreateGraphicsPipelines",
1813 ParameterName("pCreateInfos[%i].pStages[%i].pName", ParameterName::IndexVector{i, stage_index}),
1814 "VUID-VkGraphicsPipelineCreateInfo-pStages-parameter", pCreateInfos[i].pStages[stage_index].pName);
1815 }
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001816 }
1817
1818 if ((active_shaders & VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) &&
1819 (active_shaders & VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT) && (pCreateInfos[i].pTessellationState != nullptr)) {
1820 skip |= validate_struct_type("vkCreateGraphicsPipelines", "pCreateInfos[i].pTessellationState",
1821 "VK_STRUCTURE_TYPE_PIPELINE_TESSELLATION_STATE_CREATE_INFO",
1822 pCreateInfos[i].pTessellationState,
1823 VK_STRUCTURE_TYPE_PIPELINE_TESSELLATION_STATE_CREATE_INFO, false, kVUIDUndefined,
1824 "VUID-VkPipelineTessellationStateCreateInfo-sType-sType");
1825
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001826 const VkStructureType allowed_structs_vk_pipeline_tessellation_state_create_info[] = {
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001827 VK_STRUCTURE_TYPE_PIPELINE_TESSELLATION_DOMAIN_ORIGIN_STATE_CREATE_INFO};
1828
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001829 skip |= validate_struct_pnext(
1830 "vkCreateGraphicsPipelines", "pCreateInfos[i].pTessellationState->pNext",
1831 "VkPipelineTessellationDomainOriginStateCreateInfo", pCreateInfos[i].pTessellationState->pNext,
1832 ARRAY_SIZE(allowed_structs_vk_pipeline_tessellation_state_create_info),
1833 allowed_structs_vk_pipeline_tessellation_state_create_info, GeneratedVulkanHeaderVersion,
1834 "VUID-VkPipelineTessellationStateCreateInfo-pNext-pNext",
1835 "VUID-VkPipelineTessellationStateCreateInfo-sType-unique");
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001836
1837 skip |= validate_reserved_flags("vkCreateGraphicsPipelines", "pCreateInfos[i].pTessellationState->flags",
1838 pCreateInfos[i].pTessellationState->flags,
1839 "VUID-VkPipelineTessellationStateCreateInfo-flags-zerobitmask");
1840 }
1841
1842 if (!(active_shaders & VK_SHADER_STAGE_MESH_BIT_NV) && (pCreateInfos[i].pInputAssemblyState != nullptr)) {
1843 skip |= validate_struct_type("vkCreateGraphicsPipelines", "pCreateInfos[i].pInputAssemblyState",
1844 "VK_STRUCTURE_TYPE_PIPELINE_INPUT_ASSEMBLY_STATE_CREATE_INFO",
1845 pCreateInfos[i].pInputAssemblyState,
1846 VK_STRUCTURE_TYPE_PIPELINE_INPUT_ASSEMBLY_STATE_CREATE_INFO, false, kVUIDUndefined,
1847 "VUID-VkPipelineInputAssemblyStateCreateInfo-sType-sType");
1848
1849 skip |= validate_struct_pnext("vkCreateGraphicsPipelines", "pCreateInfos[i].pInputAssemblyState->pNext", NULL,
1850 pCreateInfos[i].pInputAssemblyState->pNext, 0, NULL, GeneratedVulkanHeaderVersion,
sfricke-samsung32a27362020-02-28 09:06:42 -08001851 "VUID-VkPipelineInputAssemblyStateCreateInfo-pNext-pNext", nullptr);
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001852
1853 skip |= validate_reserved_flags("vkCreateGraphicsPipelines", "pCreateInfos[i].pInputAssemblyState->flags",
1854 pCreateInfos[i].pInputAssemblyState->flags,
1855 "VUID-VkPipelineInputAssemblyStateCreateInfo-flags-zerobitmask");
1856
1857 skip |= validate_ranged_enum("vkCreateGraphicsPipelines", "pCreateInfos[i].pInputAssemblyState->topology",
1858 "VkPrimitiveTopology", AllVkPrimitiveTopologyEnums,
1859 pCreateInfos[i].pInputAssemblyState->topology,
1860 "VUID-VkPipelineInputAssemblyStateCreateInfo-topology-parameter");
1861
1862 skip |= validate_bool32("vkCreateGraphicsPipelines", "pCreateInfos[i].pInputAssemblyState->primitiveRestartEnable",
1863 pCreateInfos[i].pInputAssemblyState->primitiveRestartEnable);
1864 }
1865
1866 if (!(active_shaders & VK_SHADER_STAGE_MESH_BIT_NV) && (pCreateInfos[i].pVertexInputState != nullptr)) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001867 auto const &vertex_input_state = pCreateInfos[i].pVertexInputState;
Peter Kohautc7d9d392018-07-15 00:34:07 +02001868
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001869 if (pCreateInfos[i].pVertexInputState->flags != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001870 skip |= LogError(device, "VUID-VkPipelineVertexInputStateCreateInfo-flags-zerobitmask",
1871 "vkCreateGraphicsPipelines: pararameter "
1872 "pCreateInfos[%d].pVertexInputState->flags (%u) is reserved and must be zero.",
1873 i, vertex_input_state->flags);
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001874 }
1875
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001876 const VkStructureType allowed_structs_vk_pipeline_vertex_input_state_create_info[] = {
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001877 VK_STRUCTURE_TYPE_PIPELINE_VERTEX_INPUT_DIVISOR_STATE_CREATE_INFO_EXT};
1878 skip |= validate_struct_pnext("vkCreateGraphicsPipelines", "pCreateInfos[i].pVertexInputState->pNext",
1879 "VkPipelineVertexInputDivisorStateCreateInfoEXT",
1880 pCreateInfos[i].pVertexInputState->pNext, 1,
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001881 allowed_structs_vk_pipeline_vertex_input_state_create_info,
1882 GeneratedVulkanHeaderVersion, "VUID-VkPipelineVertexInputStateCreateInfo-pNext-pNext",
sfricke-samsung32a27362020-02-28 09:06:42 -08001883 "VUID-VkPipelineVertexInputStateCreateInfo-sType-unique");
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001884 skip |= validate_struct_type("vkCreateGraphicsPipelines", "pCreateInfos[i].pVertexInputState",
1885 "VK_STRUCTURE_TYPE_PIPELINE_VERTEX_INPUT_STATE_CREATE_INFO", vertex_input_state,
Shannon McPherson3cc90bc2019-08-13 11:28:22 -06001886 VK_STRUCTURE_TYPE_PIPELINE_VERTEX_INPUT_STATE_CREATE_INFO, false, kVUIDUndefined,
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001887 "VUID-VkPipelineVertexInputStateCreateInfo-sType-sType");
1888 skip |=
1889 validate_array("vkCreateGraphicsPipelines", "pCreateInfos[i].pVertexInputState->vertexBindingDescriptionCount",
1890 "pCreateInfos[i].pVertexInputState->pVertexBindingDescriptions",
1891 pCreateInfos[i].pVertexInputState->vertexBindingDescriptionCount,
1892 &pCreateInfos[i].pVertexInputState->pVertexBindingDescriptions, false, true, kVUIDUndefined,
1893 "VUID-VkPipelineVertexInputStateCreateInfo-pVertexBindingDescriptions-parameter");
1894
1895 skip |= validate_array(
1896 "vkCreateGraphicsPipelines", "pCreateInfos[i].pVertexInputState->vertexAttributeDescriptionCount",
1897 "pCreateInfos[i]->pVertexAttributeDescriptions", vertex_input_state->vertexAttributeDescriptionCount,
1898 &vertex_input_state->pVertexAttributeDescriptions, false, true, kVUIDUndefined,
1899 "VUID-VkPipelineVertexInputStateCreateInfo-pVertexAttributeDescriptions-parameter");
1900
1901 if (pCreateInfos[i].pVertexInputState->pVertexBindingDescriptions != NULL) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001902 for (uint32_t vertex_binding_description_index = 0;
1903 vertex_binding_description_index < pCreateInfos[i].pVertexInputState->vertexBindingDescriptionCount;
1904 ++vertex_binding_description_index) {
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001905 skip |= validate_ranged_enum(
1906 "vkCreateGraphicsPipelines",
1907 "pCreateInfos[i].pVertexInputState->pVertexBindingDescriptions[j].inputRate", "VkVertexInputRate",
1908 AllVkVertexInputRateEnums,
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001909 pCreateInfos[i]
1910 .pVertexInputState->pVertexBindingDescriptions[vertex_binding_description_index]
1911 .inputRate,
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001912 "VUID-VkVertexInputBindingDescription-inputRate-parameter");
1913 }
1914 }
1915
1916 if (pCreateInfos[i].pVertexInputState->pVertexAttributeDescriptions != NULL) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001917 for (uint32_t vertex_attribute_description_index = 0;
1918 vertex_attribute_description_index < pCreateInfos[i].pVertexInputState->vertexAttributeDescriptionCount;
1919 ++vertex_attribute_description_index) {
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001920 skip |= validate_ranged_enum(
1921 "vkCreateGraphicsPipelines",
1922 "pCreateInfos[i].pVertexInputState->pVertexAttributeDescriptions[i].format", "VkFormat",
1923 AllVkFormatEnums,
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001924 pCreateInfos[i]
1925 .pVertexInputState->pVertexAttributeDescriptions[vertex_attribute_description_index]
1926 .format,
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001927 "VUID-VkVertexInputAttributeDescription-format-parameter");
1928 }
1929 }
1930
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001931 if (vertex_input_state->vertexBindingDescriptionCount > device_limits.maxVertexInputBindings) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001932 skip |= LogError(device, "VUID-VkPipelineVertexInputStateCreateInfo-vertexBindingDescriptionCount-00613",
1933 "vkCreateGraphicsPipelines: pararameter "
1934 "pCreateInfo[%d].pVertexInputState->vertexBindingDescriptionCount (%u) is "
1935 "greater than VkPhysicalDeviceLimits::maxVertexInputBindings (%u).",
1936 i, vertex_input_state->vertexBindingDescriptionCount, device_limits.maxVertexInputBindings);
Peter Kohautc7d9d392018-07-15 00:34:07 +02001937 }
1938
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001939 if (vertex_input_state->vertexAttributeDescriptionCount > device_limits.maxVertexInputAttributes) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001940 skip |=
1941 LogError(device, "VUID-VkPipelineVertexInputStateCreateInfo-vertexAttributeDescriptionCount-00614",
1942 "vkCreateGraphicsPipelines: pararameter "
1943 "pCreateInfo[%d].pVertexInputState->vertexAttributeDescriptionCount (%u) is "
1944 "greater than VkPhysicalDeviceLimits::maxVertexInputAttributes (%u).",
1945 i, vertex_input_state->vertexAttributeDescriptionCount, device_limits.maxVertexInputAttributes);
Peter Kohautc7d9d392018-07-15 00:34:07 +02001946 }
1947
1948 std::unordered_set<uint32_t> vertex_bindings(vertex_input_state->vertexBindingDescriptionCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001949 for (uint32_t d = 0; d < vertex_input_state->vertexBindingDescriptionCount; ++d) {
1950 auto const &vertex_bind_desc = vertex_input_state->pVertexBindingDescriptions[d];
Peter Kohautc7d9d392018-07-15 00:34:07 +02001951 auto const &binding_it = vertex_bindings.find(vertex_bind_desc.binding);
1952 if (binding_it != vertex_bindings.cend()) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001953 skip |= LogError(device, "VUID-VkPipelineVertexInputStateCreateInfo-pVertexBindingDescriptions-00616",
1954 "vkCreateGraphicsPipelines: parameter "
1955 "pCreateInfo[%d].pVertexInputState->pVertexBindingDescription[%d].binding "
1956 "(%" PRIu32 ") is not distinct.",
1957 i, d, vertex_bind_desc.binding);
Peter Kohautc7d9d392018-07-15 00:34:07 +02001958 }
1959 vertex_bindings.insert(vertex_bind_desc.binding);
1960
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001961 if (vertex_bind_desc.binding >= device_limits.maxVertexInputBindings) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001962 skip |= LogError(device, "VUID-VkVertexInputBindingDescription-binding-00618",
1963 "vkCreateGraphicsPipelines: parameter "
1964 "pCreateInfos[%u].pVertexInputState->pVertexBindingDescriptions[%u].binding (%u) is "
1965 "greater than or equal to VkPhysicalDeviceLimits::maxVertexInputBindings (%u).",
1966 i, d, vertex_bind_desc.binding, device_limits.maxVertexInputBindings);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001967 }
1968
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001969 if (vertex_bind_desc.stride > device_limits.maxVertexInputBindingStride) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001970 skip |=
1971 LogError(device, "VUID-VkVertexInputBindingDescription-stride-00619",
1972 "vkCreateGraphicsPipelines: parameter "
1973 "pCreateInfos[%u].pVertexInputState->pVertexBindingDescriptions[%u].stride (%u) is greater "
1974 "than VkPhysicalDeviceLimits::maxVertexInputBindingStride (%u).",
1975 i, d, vertex_bind_desc.stride, device_limits.maxVertexInputBindingStride);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001976 }
1977 }
1978
Peter Kohautc7d9d392018-07-15 00:34:07 +02001979 std::unordered_set<uint32_t> attribute_locations(vertex_input_state->vertexAttributeDescriptionCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001980 for (uint32_t d = 0; d < vertex_input_state->vertexAttributeDescriptionCount; ++d) {
1981 auto const &vertex_attrib_desc = vertex_input_state->pVertexAttributeDescriptions[d];
Peter Kohautc7d9d392018-07-15 00:34:07 +02001982 auto const &location_it = attribute_locations.find(vertex_attrib_desc.location);
1983 if (location_it != attribute_locations.cend()) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001984 skip |= LogError(
1985 device, "VUID-VkPipelineVertexInputStateCreateInfo-pVertexAttributeDescriptions-00617",
Peter Kohautc7d9d392018-07-15 00:34:07 +02001986 "vkCreateGraphicsPipelines: parameter "
1987 "pCreateInfo[%d].pVertexInputState->vertexAttributeDescriptions[%d].location (%u) is not distinct.",
1988 i, d, vertex_attrib_desc.location);
1989 }
1990 attribute_locations.insert(vertex_attrib_desc.location);
1991
1992 auto const &binding_it = vertex_bindings.find(vertex_attrib_desc.binding);
1993 if (binding_it == vertex_bindings.cend()) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001994 skip |= LogError(
1995 device, "VUID-VkPipelineVertexInputStateCreateInfo-binding-00615",
Peter Kohautc7d9d392018-07-15 00:34:07 +02001996 "vkCreateGraphicsPipelines: parameter "
1997 " pCreateInfo[%d].pVertexInputState->vertexAttributeDescriptions[%d].binding (%u) does not exist "
1998 "in any pCreateInfo[%d].pVertexInputState->pVertexBindingDescription.",
1999 i, d, vertex_attrib_desc.binding, i);
2000 }
2001
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002002 if (vertex_attrib_desc.location >= device_limits.maxVertexInputAttributes) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002003 skip |= LogError(device, "VUID-VkVertexInputAttributeDescription-location-00620",
2004 "vkCreateGraphicsPipelines: parameter "
2005 "pCreateInfos[%u].pVertexInputState->pVertexAttributeDescriptions[%u].location (%u) is "
2006 "greater than or equal to VkPhysicalDeviceLimits::maxVertexInputAttributes (%u).",
2007 i, d, vertex_attrib_desc.location, device_limits.maxVertexInputAttributes);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002008 }
2009
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002010 if (vertex_attrib_desc.binding >= device_limits.maxVertexInputBindings) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002011 skip |= LogError(device, "VUID-VkVertexInputAttributeDescription-binding-00621",
2012 "vkCreateGraphicsPipelines: parameter "
2013 "pCreateInfos[%u].pVertexInputState->pVertexAttributeDescriptions[%u].binding (%u) is "
2014 "greater than or equal to VkPhysicalDeviceLimits::maxVertexInputBindings (%u).",
2015 i, d, vertex_attrib_desc.binding, device_limits.maxVertexInputBindings);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002016 }
2017
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002018 if (vertex_attrib_desc.offset > device_limits.maxVertexInputAttributeOffset) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002019 skip |= LogError(device, "VUID-VkVertexInputAttributeDescription-offset-00622",
2020 "vkCreateGraphicsPipelines: parameter "
2021 "pCreateInfos[%u].pVertexInputState->pVertexAttributeDescriptions[%u].offset (%u) is "
2022 "greater than VkPhysicalDeviceLimits::maxVertexInputAttributeOffset (%u).",
2023 i, d, vertex_attrib_desc.offset, device_limits.maxVertexInputAttributeOffset);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002024 }
2025 }
2026 }
2027
Spencer Frickef1b0a7d2020-03-16 17:38:55 -07002028 // pTessellationState is ignored without both tessellation control and tessellation evaluation shaders stages
2029 if (has_control && has_eval) {
2030 if (pCreateInfos[i].pTessellationState == nullptr) {
2031 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-pStages-00731",
2032 "vkCreateGraphicsPipelines: if pCreateInfos[%d].pStages includes a tessellation control "
2033 "shader stage and a tessellation evaluation shader stage, "
2034 "pCreateInfos[%d].pTessellationState must not be NULL.",
2035 i, i);
2036 } else {
2037 const VkStructureType allowed_type = VK_STRUCTURE_TYPE_PIPELINE_TESSELLATION_DOMAIN_ORIGIN_STATE_CREATE_INFO;
2038 skip |= validate_struct_pnext(
2039 "vkCreateGraphicsPipelines",
2040 ParameterName("pCreateInfos[%i].pTessellationState->pNext", ParameterName::IndexVector{i}),
2041 "VkPipelineTessellationDomainOriginStateCreateInfo", pCreateInfos[i].pTessellationState->pNext, 1,
2042 &allowed_type, GeneratedVulkanHeaderVersion, "VUID-VkGraphicsPipelineCreateInfo-pNext-pNext",
2043 "VUID-VkGraphicsPipelineCreateInfo-sType-unique");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002044
Spencer Frickef1b0a7d2020-03-16 17:38:55 -07002045 skip |= validate_reserved_flags(
2046 "vkCreateGraphicsPipelines",
2047 ParameterName("pCreateInfos[%i].pTessellationState->flags", ParameterName::IndexVector{i}),
2048 pCreateInfos[i].pTessellationState->flags, "VUID-VkPipelineTessellationStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002049
Spencer Frickef1b0a7d2020-03-16 17:38:55 -07002050 if (pCreateInfos[i].pTessellationState->patchControlPoints == 0 ||
2051 pCreateInfos[i].pTessellationState->patchControlPoints > device_limits.maxTessellationPatchSize) {
2052 skip |= LogError(device, "VUID-VkPipelineTessellationStateCreateInfo-patchControlPoints-01214",
2053 "vkCreateGraphicsPipelines: invalid parameter "
2054 "pCreateInfos[%d].pTessellationState->patchControlPoints value %u. patchControlPoints "
2055 "should be >0 and <=%u.",
2056 i, pCreateInfos[i].pTessellationState->patchControlPoints,
2057 device_limits.maxTessellationPatchSize);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002058 }
2059 }
2060 }
2061
2062 // pViewportState, pMultisampleState, pDepthStencilState, and pColorBlendState ignored when rasterization is disabled
2063 if ((pCreateInfos[i].pRasterizationState != nullptr) &&
2064 (pCreateInfos[i].pRasterizationState->rasterizerDiscardEnable == VK_FALSE)) {
2065 if (pCreateInfos[i].pViewportState == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002066 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-rasterizerDiscardEnable-00750",
2067 "vkCreateGraphicsPipelines: Rasterization is enabled (pCreateInfos[%" PRIu32
2068 "].pRasterizationState->rasterizerDiscardEnable is VK_FALSE), but pCreateInfos[%" PRIu32
2069 "].pViewportState (=NULL) is not a valid pointer.",
2070 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002071 } else {
Petr Krausa6103552017-11-16 21:21:58 +01002072 const auto &viewport_state = *pCreateInfos[i].pViewportState;
2073
2074 if (viewport_state.sType != VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_STATE_CREATE_INFO) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002075 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-sType-sType",
2076 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2077 "].pViewportState->sType is not VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_STATE_CREATE_INFO.",
2078 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002079 }
2080
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002081 const VkStructureType allowed_structs_vk_pipeline_viewport_state_create_info[] = {
Petr Krausa6103552017-11-16 21:21:58 +01002082 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_SWIZZLE_STATE_CREATE_INFO_NV,
Jeff Bolz3e71f782018-08-29 23:15:45 -05002083 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_W_SCALING_STATE_CREATE_INFO_NV,
2084 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_EXCLUSIVE_SCISSOR_STATE_CREATE_INFO_NV,
Jeff Bolz9af91c52018-09-01 21:53:57 -05002085 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_SHADING_RATE_IMAGE_STATE_CREATE_INFO_NV,
2086 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_COARSE_SAMPLE_ORDER_STATE_CREATE_INFO_NV,
Jeff Bolz3e71f782018-08-29 23:15:45 -05002087 };
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002088 skip |= validate_struct_pnext(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002089 "vkCreateGraphicsPipelines",
Petr Krausa6103552017-11-16 21:21:58 +01002090 ParameterName("pCreateInfos[%i].pViewportState->pNext", ParameterName::IndexVector{i}),
Jeff Bolz9af91c52018-09-01 21:53:57 -05002091 "VkPipelineViewportSwizzleStateCreateInfoNV, VkPipelineViewportWScalingStateCreateInfoNV, "
Jeff Bolzb8a8dd02018-09-18 02:39:24 -05002092 "VkPipelineViewportExclusiveScissorStateCreateInfoNV, VkPipelineViewportShadingRateImageStateCreateInfoNV, "
2093 "VkPipelineViewportCoarseSampleOrderStateCreateInfoNV",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002094 viewport_state.pNext, ARRAY_SIZE(allowed_structs_vk_pipeline_viewport_state_create_info),
2095 allowed_structs_vk_pipeline_viewport_state_create_info, 65,
2096 "VUID-VkPipelineViewportStateCreateInfo-pNext-pNext",
sfricke-samsung32a27362020-02-28 09:06:42 -08002097 "VUID-VkPipelineViewportStateCreateInfo-sType-unique");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002098
2099 skip |= validate_reserved_flags(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002100 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002101 ParameterName("pCreateInfos[%i].pViewportState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06002102 viewport_state.flags, "VUID-VkPipelineViewportStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002103
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07002104 auto exclusive_scissor_struct =
2105 LvlFindInChain<VkPipelineViewportExclusiveScissorStateCreateInfoNV>(pCreateInfos[i].pViewportState->pNext);
2106 auto shading_rate_image_struct =
2107 LvlFindInChain<VkPipelineViewportShadingRateImageStateCreateInfoNV>(pCreateInfos[i].pViewportState->pNext);
2108 auto coarse_sample_order_struct =
2109 LvlFindInChain<VkPipelineViewportCoarseSampleOrderStateCreateInfoNV>(pCreateInfos[i].pViewportState->pNext);
Chris Mayer328d8212018-12-11 14:16:18 +01002110 const auto vp_swizzle_struct =
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07002111 LvlFindInChain<VkPipelineViewportSwizzleStateCreateInfoNV>(pCreateInfos[i].pViewportState->pNext);
Chris Mayer9ded5eb2019-09-19 16:33:26 +02002112 const auto vp_w_scaling_struct =
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07002113 LvlFindInChain<VkPipelineViewportWScalingStateCreateInfoNV>(pCreateInfos[i].pViewportState->pNext);
Jeff Bolz3e71f782018-08-29 23:15:45 -05002114
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002115 if (!physical_device_features.multiViewport) {
Mark Lobodzinski8b9ddab2020-10-15 14:38:43 -06002116 if (!has_dynamic_viewport_with_count && (viewport_state.viewportCount != 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002117 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-viewportCount-01216",
2118 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
2119 "disabled, but pCreateInfos[%" PRIu32 "].pViewportState->viewportCount (=%" PRIu32
2120 ") is not 1.",
2121 i, viewport_state.viewportCount);
Petr Krausa6103552017-11-16 21:21:58 +01002122 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002123
Mark Lobodzinski8b9ddab2020-10-15 14:38:43 -06002124 if (!has_dynamic_scissor_with_count && (viewport_state.scissorCount != 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002125 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-01217",
2126 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
2127 "disabled, but pCreateInfos[%" PRIu32 "].pViewportState->scissorCount (=%" PRIu32
2128 ") is not 1.",
2129 i, viewport_state.scissorCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002130 }
Jeff Bolz3e71f782018-08-29 23:15:45 -05002131
Dave Houlton142c4cb2018-10-17 15:04:41 -06002132 if (exclusive_scissor_struct && (exclusive_scissor_struct->exclusiveScissorCount != 0 &&
2133 exclusive_scissor_struct->exclusiveScissorCount != 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002134 skip |= LogError(
2135 device, "VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-exclusiveScissorCount-02027",
2136 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
2137 "disabled, but pCreateInfos[%" PRIu32
2138 "] VkPipelineViewportExclusiveScissorStateCreateInfoNV::exclusiveScissorCount (=%" PRIu32
2139 ") is not 1.",
2140 i, exclusive_scissor_struct->exclusiveScissorCount);
Jeff Bolz3e71f782018-08-29 23:15:45 -05002141 }
2142
Jeff Bolz9af91c52018-09-01 21:53:57 -05002143 if (shading_rate_image_struct &&
2144 (shading_rate_image_struct->viewportCount != 0 && shading_rate_image_struct->viewportCount != 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002145 skip |= LogError(device, "VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-viewportCount-02054",
2146 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
2147 "disabled, but pCreateInfos[%" PRIu32
2148 "] VkPipelineViewportShadingRateImageStateCreateInfoNV::viewportCount (=%" PRIu32
2149 ") is neither 0 nor 1.",
2150 i, shading_rate_image_struct->viewportCount);
Jeff Bolz9af91c52018-09-01 21:53:57 -05002151 }
2152
Petr Krausa6103552017-11-16 21:21:58 +01002153 } else { // multiViewport enabled
2154 if (viewport_state.viewportCount == 0) {
Piers Daniell39842ee2020-07-10 16:42:33 -06002155 if (!has_dynamic_viewport_with_count) {
2156 skip |= LogError(
2157 device, "VUID-VkPipelineViewportStateCreateInfo-viewportCount-arraylength",
2158 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "].pViewportState->viewportCount is 0.", i);
2159 }
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002160 } else if (viewport_state.viewportCount > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002161 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-viewportCount-01218",
2162 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2163 "].pViewportState->viewportCount (=%" PRIu32
2164 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
2165 i, viewport_state.viewportCount, device_limits.maxViewports);
Piers Daniell39842ee2020-07-10 16:42:33 -06002166 } else if (has_dynamic_viewport_with_count) {
2167 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-03379",
2168 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2169 "].pViewportState->viewportCount (=%" PRIu32
2170 ") must be zero when VK_DYNAMIC_STATE_VIEWPORT_WITH_COUNT_EXT is used.",
2171 i, viewport_state.viewportCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002172 }
Petr Krausa6103552017-11-16 21:21:58 +01002173
2174 if (viewport_state.scissorCount == 0) {
Piers Daniell39842ee2020-07-10 16:42:33 -06002175 if (!has_dynamic_scissor_with_count) {
2176 skip |= LogError(
2177 device, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-arraylength",
2178 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "].pViewportState->scissorCount is 0.", i);
2179 }
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002180 } else if (viewport_state.scissorCount > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002181 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-01219",
2182 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2183 "].pViewportState->scissorCount (=%" PRIu32
2184 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
2185 i, viewport_state.scissorCount, device_limits.maxViewports);
Piers Daniell39842ee2020-07-10 16:42:33 -06002186 } else if (has_dynamic_scissor_with_count) {
2187 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-03380",
2188 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2189 "].pViewportState->scissorCount (=%" PRIu32
2190 ") must be zero when VK_DYNAMIC_STATE_SCISSOR_WITH_COUNT_EXT is used.",
2191 i, viewport_state.viewportCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002192 }
2193 }
2194
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002195 if (exclusive_scissor_struct && exclusive_scissor_struct->exclusiveScissorCount > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002196 skip |=
2197 LogError(device, "VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-exclusiveScissorCount-02028",
2198 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "] exclusiveScissorCount (=%" PRIu32
2199 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
2200 i, exclusive_scissor_struct->exclusiveScissorCount, device_limits.maxViewports);
Jeff Bolz3e71f782018-08-29 23:15:45 -05002201 }
2202
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002203 if (shading_rate_image_struct && shading_rate_image_struct->viewportCount > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002204 skip |= LogError(device, "VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-viewportCount-02055",
2205 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2206 "] VkPipelineViewportShadingRateImageStateCreateInfoNV viewportCount (=%" PRIu32
2207 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
2208 i, shading_rate_image_struct->viewportCount, device_limits.maxViewports);
Jeff Bolz9af91c52018-09-01 21:53:57 -05002209 }
2210
Piers Daniell39842ee2020-07-10 16:42:33 -06002211 if (viewport_state.scissorCount != viewport_state.viewportCount &&
2212 !(has_dynamic_viewport_with_count || has_dynamic_scissor_with_count)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002213 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-01220",
2214 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2215 "].pViewportState->scissorCount (=%" PRIu32 ") is not identical to pCreateInfos[%" PRIu32
2216 "].pViewportState->viewportCount (=%" PRIu32 ").",
2217 i, viewport_state.scissorCount, i, viewport_state.viewportCount);
Petr Krausa6103552017-11-16 21:21:58 +01002218 }
2219
Dave Houlton142c4cb2018-10-17 15:04:41 -06002220 if (exclusive_scissor_struct && exclusive_scissor_struct->exclusiveScissorCount != 0 &&
Jeff Bolz3e71f782018-08-29 23:15:45 -05002221 exclusive_scissor_struct->exclusiveScissorCount != viewport_state.viewportCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002222 skip |=
2223 LogError(device, "VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-exclusiveScissorCount-02029",
2224 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "] exclusiveScissorCount (=%" PRIu32
2225 ") must be zero or identical to pCreateInfos[%" PRIu32
2226 "].pViewportState->viewportCount (=%" PRIu32 ").",
2227 i, exclusive_scissor_struct->exclusiveScissorCount, i, viewport_state.viewportCount);
Jeff Bolz3e71f782018-08-29 23:15:45 -05002228 }
2229
Dave Houlton142c4cb2018-10-17 15:04:41 -06002230 if (shading_rate_image_struct && shading_rate_image_struct->shadingRateImageEnable &&
Jeff Bolz9af91c52018-09-01 21:53:57 -05002231 shading_rate_image_struct->viewportCount != viewport_state.viewportCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002232 skip |= LogError(
2233 device, "VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-shadingRateImageEnable-02056",
Dave Houlton142c4cb2018-10-17 15:04:41 -06002234 "vkCreateGraphicsPipelines: If shadingRateImageEnable is enabled, pCreateInfos[%" PRIu32
2235 "] "
2236 "VkPipelineViewportShadingRateImageStateCreateInfoNV viewportCount (=%" PRIu32
2237 ") must identical to pCreateInfos[%" PRIu32 "].pViewportState->viewportCount (=%" PRIu32 ").",
2238 i, shading_rate_image_struct->viewportCount, i, viewport_state.viewportCount);
Jeff Bolz9af91c52018-09-01 21:53:57 -05002239 }
2240
Petr Krausa6103552017-11-16 21:21:58 +01002241 if (!has_dynamic_viewport && viewport_state.viewportCount > 0 && viewport_state.pViewports == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002242 skip |= LogError(
2243 device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-00747",
Petr Krausa6103552017-11-16 21:21:58 +01002244 "vkCreateGraphicsPipelines: The viewport state is static (pCreateInfos[%" PRIu32
2245 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_VIEWPORT), but pCreateInfos[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002246 "].pViewportState->pViewports (=NULL) is an invalid pointer.",
2247 i, i);
Petr Krausa6103552017-11-16 21:21:58 +01002248 }
2249
2250 if (!has_dynamic_scissor && viewport_state.scissorCount > 0 && viewport_state.pScissors == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002251 skip |= LogError(
2252 device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-00748",
Petr Krausa6103552017-11-16 21:21:58 +01002253 "vkCreateGraphicsPipelines: The scissor state is static (pCreateInfos[%" PRIu32
2254 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_SCISSOR), but pCreateInfos[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002255 "].pViewportState->pScissors (=NULL) is an invalid pointer.",
2256 i, i);
Petr Krausa6103552017-11-16 21:21:58 +01002257 }
2258
Jeff Bolz3e71f782018-08-29 23:15:45 -05002259 if (!has_dynamic_exclusive_scissor_nv && exclusive_scissor_struct &&
Dave Houlton142c4cb2018-10-17 15:04:41 -06002260 exclusive_scissor_struct->exclusiveScissorCount > 0 &&
2261 exclusive_scissor_struct->pExclusiveScissors == nullptr) {
2262 skip |=
Shannon McPherson24c13d12020-06-18 15:51:41 -06002263 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-04056",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002264 "vkCreateGraphicsPipelines: The exclusive scissor state is static (pCreateInfos[%" PRIu32
2265 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV), but "
2266 "pCreateInfos[%" PRIu32 "] pExclusiveScissors (=NULL) is an invalid pointer.",
2267 i, i);
Jeff Bolz3e71f782018-08-29 23:15:45 -05002268 }
2269
Jeff Bolz9af91c52018-09-01 21:53:57 -05002270 if (!has_dynamic_shading_rate_palette_nv && shading_rate_image_struct &&
Dave Houlton142c4cb2018-10-17 15:04:41 -06002271 shading_rate_image_struct->viewportCount > 0 &&
2272 shading_rate_image_struct->pShadingRatePalettes == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002273 skip |= LogError(
Shannon McPherson24c13d12020-06-18 15:51:41 -06002274 device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-04057",
Jeff Bolz9af91c52018-09-01 21:53:57 -05002275 "vkCreateGraphicsPipelines: The shading rate palette state is static (pCreateInfos[%" PRIu32
Dave Houlton142c4cb2018-10-17 15:04:41 -06002276 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_VIEWPORT_SHADING_RATE_PALETTE_NV), "
2277 "but pCreateInfos[%" PRIu32 "] pShadingRatePalettes (=NULL) is an invalid pointer.",
Jeff Bolz9af91c52018-09-01 21:53:57 -05002278 i, i);
2279 }
2280
Chris Mayer328d8212018-12-11 14:16:18 +01002281 if (vp_swizzle_struct) {
2282 if (vp_swizzle_struct->viewportCount != viewport_state.viewportCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002283 skip |= LogError(device, "VUID-VkPipelineViewportSwizzleStateCreateInfoNV-viewportCount-01215",
2284 "vkCreateGraphicsPipelines: The viewport swizzle state vieport count of %" PRIu32
2285 " does "
2286 "not match the viewport count of %" PRIu32 " in VkPipelineViewportStateCreateInfo.",
2287 vp_swizzle_struct->viewportCount, viewport_state.viewportCount);
Chris Mayer328d8212018-12-11 14:16:18 +01002288 }
2289 }
2290
Petr Krausb3fcdb42018-01-09 22:09:09 +01002291 // validate the VkViewports
2292 if (!has_dynamic_viewport && viewport_state.pViewports) {
2293 for (uint32_t viewport_i = 0; viewport_i < viewport_state.viewportCount; ++viewport_i) {
2294 const auto &viewport = viewport_state.pViewports[viewport_i]; // will crash on invalid ptr
Jeff Bolz6d3beaa2019-02-09 21:00:05 -06002295 const char *fn_name = "vkCreateGraphicsPipelines";
2296 skip |= manual_PreCallValidateViewport(viewport, fn_name,
2297 ParameterName("pCreateInfos[%i].pViewportState->pViewports[%i]",
2298 ParameterName::IndexVector{i, viewport_i}),
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002299 VkCommandBuffer(0));
Petr Krausb3fcdb42018-01-09 22:09:09 +01002300 }
2301 }
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07002302
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002303 if (has_dynamic_viewport_w_scaling_nv && !device_extensions.vk_nv_clip_space_w_scaling) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002304 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
2305 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2306 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_VIEWPORT_W_SCALING_NV, but "
2307 "VK_NV_clip_space_w_scaling extension is not enabled.",
2308 i);
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07002309 }
2310
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002311 if (has_dynamic_discard_rectangle_ext && !device_extensions.vk_ext_discard_rectangles) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002312 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
2313 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2314 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_DISCARD_RECTANGLE_EXT, but "
2315 "VK_EXT_discard_rectangles extension is not enabled.",
2316 i);
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07002317 }
2318
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002319 if (has_dynamic_sample_locations_ext && !device_extensions.vk_ext_sample_locations) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002320 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
2321 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2322 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_SAMPLE_LOCATIONS_EXT, but "
2323 "VK_EXT_sample_locations extension is not enabled.",
2324 i);
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07002325 }
Jeff Bolz3e71f782018-08-29 23:15:45 -05002326
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002327 if (has_dynamic_exclusive_scissor_nv && !device_extensions.vk_nv_scissor_exclusive) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002328 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
2329 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2330 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV, but "
2331 "VK_NV_scissor_exclusive extension is not enabled.",
2332 i);
Jeff Bolz3e71f782018-08-29 23:15:45 -05002333 }
Jeff Bolz9af91c52018-09-01 21:53:57 -05002334
2335 if (coarse_sample_order_struct &&
2336 coarse_sample_order_struct->sampleOrderType != VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV &&
2337 coarse_sample_order_struct->customSampleOrderCount != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002338 skip |= LogError(device, "VUID-VkPipelineViewportCoarseSampleOrderStateCreateInfoNV-sampleOrderType-02072",
2339 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2340 "] "
2341 "VkPipelineViewportCoarseSampleOrderStateCreateInfoNV sampleOrderType is not "
2342 "VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV and customSampleOrderCount is not 0.",
2343 i);
Jeff Bolz9af91c52018-09-01 21:53:57 -05002344 }
2345
2346 if (coarse_sample_order_struct) {
2347 for (uint32_t order_i = 0; order_i < coarse_sample_order_struct->customSampleOrderCount; ++order_i) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002348 skip |= ValidateCoarseSampleOrderCustomNV(&coarse_sample_order_struct->pCustomSampleOrders[order_i]);
Jeff Bolz9af91c52018-09-01 21:53:57 -05002349 }
2350 }
Chris Mayer9ded5eb2019-09-19 16:33:26 +02002351
2352 if (vp_w_scaling_struct && (vp_w_scaling_struct->viewportWScalingEnable == VK_TRUE)) {
2353 if (vp_w_scaling_struct->viewportCount != viewport_state.viewportCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002354 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-viewportWScalingEnable-01726",
2355 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2356 "] "
2357 "VkPipelineViewportWScalingStateCreateInfoNV.viewportCount (=%" PRIu32
2358 ") "
2359 "is not equal to VkPipelineViewportStateCreateInfo.viewportCount (=%" PRIu32 ").",
2360 i, vp_w_scaling_struct->viewportCount, viewport_state.viewportCount);
Chris Mayer9ded5eb2019-09-19 16:33:26 +02002361 }
2362 if (!has_dynamic_viewport_w_scaling_nv && !vp_w_scaling_struct->pViewportWScalings) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002363 skip |= LogError(
2364 device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-01715",
Chris Mayer9ded5eb2019-09-19 16:33:26 +02002365 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2366 "] "
2367 "VkPipelineViewportWScalingStateCreateInfoNV.pViewportWScalings (=NULL) is not a valid array.",
2368 i);
2369 }
2370 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002371 }
2372
2373 if (pCreateInfos[i].pMultisampleState == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002374 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-rasterizerDiscardEnable-00751",
2375 "vkCreateGraphicsPipelines: if pCreateInfos[%d].pRasterizationState->rasterizerDiscardEnable "
2376 "is VK_FALSE, pCreateInfos[%d].pMultisampleState must not be NULL.",
2377 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002378 } else {
Dave Houltonb3bbec72018-01-17 10:13:33 -07002379 const VkStructureType valid_next_stypes[] = {LvlTypeMap<VkPipelineCoverageModulationStateCreateInfoNV>::kSType,
Mark Lobodzinski1ddf16f2020-08-13 08:58:13 -06002380 LvlTypeMap<VkPipelineCoverageReductionStateCreateInfoNV>::kSType,
Dave Houltonb3bbec72018-01-17 10:13:33 -07002381 LvlTypeMap<VkPipelineCoverageToColorStateCreateInfoNV>::kSType,
2382 LvlTypeMap<VkPipelineSampleLocationsStateCreateInfoEXT>::kSType};
Mike Schuchardt97662b02017-12-06 13:31:29 -07002383 const char *valid_struct_names =
Dave Houltona9df0ce2018-02-07 10:51:23 -07002384 "VkPipelineCoverageModulationStateCreateInfoNV, VkPipelineCoverageToColorStateCreateInfoNV, "
John Zulauf96b0e422017-11-14 11:43:19 -07002385 "VkPipelineSampleLocationsStateCreateInfoEXT";
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002386 skip |= validate_struct_pnext(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002387 "vkCreateGraphicsPipelines",
John Zulauf96b0e422017-11-14 11:43:19 -07002388 ParameterName("pCreateInfos[%i].pMultisampleState->pNext", ParameterName::IndexVector{i}),
Mark Lobodzinski1ddf16f2020-08-13 08:58:13 -06002389 valid_struct_names, pCreateInfos[i].pMultisampleState->pNext, 4, valid_next_stypes,
sfricke-samsung32a27362020-02-28 09:06:42 -08002390 GeneratedVulkanHeaderVersion, "VUID-VkPipelineMultisampleStateCreateInfo-pNext-pNext",
2391 "VUID-VkPipelineMultisampleStateCreateInfo-sType-unique");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002392
2393 skip |= validate_reserved_flags(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002394 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002395 ParameterName("pCreateInfos[%i].pMultisampleState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06002396 pCreateInfos[i].pMultisampleState->flags, "VUID-VkPipelineMultisampleStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002397
2398 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002399 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002400 ParameterName("pCreateInfos[%i].pMultisampleState->sampleShadingEnable", ParameterName::IndexVector{i}),
2401 pCreateInfos[i].pMultisampleState->sampleShadingEnable);
2402
2403 skip |= validate_array(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002404 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002405 ParameterName("pCreateInfos[%i].pMultisampleState->rasterizationSamples", ParameterName::IndexVector{i}),
2406 ParameterName("pCreateInfos[%i].pMultisampleState->pSampleMask", ParameterName::IndexVector{i}),
Gabríel Arthúr Pétursson092b29b2018-03-21 22:44:11 +00002407 pCreateInfos[i].pMultisampleState->rasterizationSamples, &pCreateInfos[i].pMultisampleState->pSampleMask,
Dave Houlton413a6782018-05-22 13:01:54 -06002408 true, false, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002409
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002410 skip |= validate_flags(
2411 "vkCreateGraphicsPipelines",
2412 ParameterName("pCreateInfos[%i].pMultisampleState->rasterizationSamples", ParameterName::IndexVector{i}),
2413 "VkSampleCountFlagBits", AllVkSampleCountFlagBits, pCreateInfos[i].pMultisampleState->rasterizationSamples,
Petr Kraus52758be2019-08-12 00:53:58 +02002414 kRequiredSingleBit, "VUID-VkPipelineMultisampleStateCreateInfo-rasterizationSamples-parameter");
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002415
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002416 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002417 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002418 ParameterName("pCreateInfos[%i].pMultisampleState->alphaToCoverageEnable", ParameterName::IndexVector{i}),
2419 pCreateInfos[i].pMultisampleState->alphaToCoverageEnable);
2420
2421 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002422 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002423 ParameterName("pCreateInfos[%i].pMultisampleState->alphaToOneEnable", ParameterName::IndexVector{i}),
2424 pCreateInfos[i].pMultisampleState->alphaToOneEnable);
2425
2426 if (pCreateInfos[i].pMultisampleState->sType != VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO) {
sfricke-samsung81c56f72020-08-23 22:14:41 -07002427 skip |= LogError(device, "VUID-VkPipelineMultisampleStateCreateInfo-sType-sType",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002428 "vkCreateGraphicsPipelines: parameter pCreateInfos[%d].pMultisampleState->sType must be "
2429 "VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO",
2430 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002431 }
John Zulauf7acac592017-11-06 11:15:53 -07002432 if (pCreateInfos[i].pMultisampleState->sampleShadingEnable == VK_TRUE) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002433 if (!physical_device_features.sampleRateShading) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002434 skip |= LogError(device, "VUID-VkPipelineMultisampleStateCreateInfo-sampleShadingEnable-00784",
2435 "vkCreateGraphicsPipelines(): parameter "
2436 "pCreateInfos[%d].pMultisampleState->sampleShadingEnable.",
2437 i);
John Zulauf7acac592017-11-06 11:15:53 -07002438 }
2439 // TODO Add documentation issue about when minSampleShading must be in range and when it is ignored
2440 // For now a "least noise" test *only* when sampleShadingEnable is VK_TRUE.
2441 if (!in_inclusive_range(pCreateInfos[i].pMultisampleState->minSampleShading, 0.F, 1.0F)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002442 skip |= LogError(
2443 device,
2444
Dave Houlton413a6782018-05-22 13:01:54 -06002445 "VUID-VkPipelineMultisampleStateCreateInfo-minSampleShading-00786",
Mark Lobodzinski88529492018-04-01 10:38:15 -06002446 "vkCreateGraphicsPipelines(): parameter pCreateInfos[%d].pMultisampleState->minSampleShading.", i);
John Zulauf7acac592017-11-06 11:15:53 -07002447 }
2448 }
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002449
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07002450 const auto *line_state =
2451 LvlFindInChain<VkPipelineRasterizationLineStateCreateInfoEXT>(pCreateInfos[i].pRasterizationState->pNext);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002452
2453 if (line_state) {
2454 if ((line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_BRESENHAM_EXT ||
2455 line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_RECTANGULAR_SMOOTH_EXT)) {
2456 if (pCreateInfos[i].pMultisampleState->alphaToCoverageEnable) {
2457 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002458 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-lineRasterizationMode-02766",
2459 "vkCreateGraphicsPipelines(): Bresenham/Smooth line rasterization not supported with "
2460 "pCreateInfos[%d].pMultisampleState->alphaToCoverageEnable == VK_TRUE.",
2461 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002462 }
2463 if (pCreateInfos[i].pMultisampleState->alphaToOneEnable) {
2464 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002465 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-lineRasterizationMode-02766",
2466 "vkCreateGraphicsPipelines(): Bresenham/Smooth line rasterization not supported with "
2467 "pCreateInfos[%d].pMultisampleState->alphaToOneEnable == VK_TRUE.",
2468 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002469 }
2470 if (pCreateInfos[i].pMultisampleState->sampleShadingEnable) {
2471 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002472 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-lineRasterizationMode-02766",
2473 "vkCreateGraphicsPipelines(): Bresenham/Smooth line rasterization not supported with "
2474 "pCreateInfos[%d].pMultisampleState->sampleShadingEnable == VK_TRUE.",
2475 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002476 }
2477 }
2478 if (line_state->stippledLineEnable && !has_dynamic_line_stipple) {
2479 if (line_state->lineStippleFactor < 1 || line_state->lineStippleFactor > 256) {
2480 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002481 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-stippledLineEnable-02767",
2482 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineStippleFactor = %d must be in the "
2483 "range [1,256].",
2484 i, line_state->lineStippleFactor);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002485 }
2486 }
2487 const auto *line_features =
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07002488 LvlFindInChain<VkPhysicalDeviceLineRasterizationFeaturesEXT>(device_createinfo_pnext);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002489 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_RECTANGULAR_EXT &&
2490 (!line_features || !line_features->rectangularLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002491 skip |=
2492 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-lineRasterizationMode-02768",
2493 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineRasterizationMode = "
2494 "VK_LINE_RASTERIZATION_MODE_RECTANGULAR_EXT requires the rectangularLines feature.",
2495 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002496 }
2497 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_BRESENHAM_EXT &&
2498 (!line_features || !line_features->bresenhamLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002499 skip |=
2500 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-lineRasterizationMode-02769",
2501 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineRasterizationMode = "
2502 "VK_LINE_RASTERIZATION_MODE_BRESENHAM_EXT requires the bresenhamLines feature.",
2503 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002504 }
2505 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_RECTANGULAR_SMOOTH_EXT &&
2506 (!line_features || !line_features->smoothLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002507 skip |=
2508 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-lineRasterizationMode-02770",
2509 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineRasterizationMode = "
2510 "VK_LINE_RASTERIZATION_MODE_RECTANGULAR_SMOOTH_EXT requires the smoothLines feature.",
2511 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002512 }
2513 if (line_state->stippledLineEnable) {
2514 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_RECTANGULAR_EXT &&
2515 (!line_features || !line_features->stippledRectangularLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002516 skip |=
2517 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-stippledLineEnable-02771",
2518 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineRasterizationMode = "
2519 "VK_LINE_RASTERIZATION_MODE_RECTANGULAR_EXT with stipple requires the "
2520 "stippledRectangularLines feature.",
2521 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002522 }
2523 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_BRESENHAM_EXT &&
2524 (!line_features || !line_features->stippledBresenhamLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002525 skip |=
2526 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-stippledLineEnable-02772",
2527 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineRasterizationMode = "
2528 "VK_LINE_RASTERIZATION_MODE_BRESENHAM_EXT with stipple requires the "
2529 "stippledBresenhamLines feature.",
2530 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002531 }
2532 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_RECTANGULAR_SMOOTH_EXT &&
2533 (!line_features || !line_features->stippledSmoothLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002534 skip |=
2535 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-stippledLineEnable-02773",
2536 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineRasterizationMode = "
2537 "VK_LINE_RASTERIZATION_MODE_RECTANGULAR_SMOOTH_EXT with stipple requires the "
2538 "stippledSmoothLines feature.",
2539 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002540 }
2541 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_DEFAULT_EXT &&
2542 (!line_features || !line_features->stippledSmoothLines || !device_limits.strictLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002543 skip |=
2544 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-stippledLineEnable-02774",
2545 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineRasterizationMode = "
2546 "VK_LINE_RASTERIZATION_MODE_DEFAULT_EXT with stipple requires the "
2547 "stippledRectangularLines and strictLines features.",
2548 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002549 }
2550 }
2551 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002552 }
2553
Petr Krause91f7a12017-12-14 20:57:36 +01002554 bool uses_color_attachment = false;
2555 bool uses_depthstencil_attachment = false;
2556 {
Mark Lobodzinskif27a6bc2019-02-04 13:00:49 -07002557 std::unique_lock<std::mutex> lock(renderpass_map_mutex);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002558 const auto subpasses_uses_it = renderpasses_states.find(pCreateInfos[i].renderPass);
2559 if (subpasses_uses_it != renderpasses_states.end()) {
Petr Krause91f7a12017-12-14 20:57:36 +01002560 const auto &subpasses_uses = subpasses_uses_it->second;
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002561 if (subpasses_uses.subpasses_using_color_attachment.count(pCreateInfos[i].subpass)) {
Petr Krause91f7a12017-12-14 20:57:36 +01002562 uses_color_attachment = true;
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002563 }
2564 if (subpasses_uses.subpasses_using_depthstencil_attachment.count(pCreateInfos[i].subpass)) {
Petr Krause91f7a12017-12-14 20:57:36 +01002565 uses_depthstencil_attachment = true;
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002566 }
Petr Krause91f7a12017-12-14 20:57:36 +01002567 }
Mark Lobodzinskif27a6bc2019-02-04 13:00:49 -07002568 lock.unlock();
Petr Krause91f7a12017-12-14 20:57:36 +01002569 }
2570
2571 if (pCreateInfos[i].pDepthStencilState != nullptr && uses_depthstencil_attachment) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002572 skip |= validate_struct_pnext(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002573 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002574 ParameterName("pCreateInfos[%i].pDepthStencilState->pNext", ParameterName::IndexVector{i}), NULL,
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002575 pCreateInfos[i].pDepthStencilState->pNext, 0, NULL, GeneratedVulkanHeaderVersion,
sfricke-samsung32a27362020-02-28 09:06:42 -08002576 "VUID-VkPipelineDepthStencilStateCreateInfo-pNext-pNext", nullptr);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002577
2578 skip |= validate_reserved_flags(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002579 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002580 ParameterName("pCreateInfos[%i].pDepthStencilState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06002581 pCreateInfos[i].pDepthStencilState->flags, "VUID-VkPipelineDepthStencilStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002582
2583 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002584 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002585 ParameterName("pCreateInfos[%i].pDepthStencilState->depthTestEnable", ParameterName::IndexVector{i}),
2586 pCreateInfos[i].pDepthStencilState->depthTestEnable);
2587
2588 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002589 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002590 ParameterName("pCreateInfos[%i].pDepthStencilState->depthWriteEnable", ParameterName::IndexVector{i}),
2591 pCreateInfos[i].pDepthStencilState->depthWriteEnable);
2592
2593 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002594 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002595 ParameterName("pCreateInfos[%i].pDepthStencilState->depthCompareOp", ParameterName::IndexVector{i}),
2596 "VkCompareOp", AllVkCompareOpEnums, pCreateInfos[i].pDepthStencilState->depthCompareOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002597 "VUID-VkPipelineDepthStencilStateCreateInfo-depthCompareOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002598
2599 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002600 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002601 ParameterName("pCreateInfos[%i].pDepthStencilState->depthBoundsTestEnable", ParameterName::IndexVector{i}),
2602 pCreateInfos[i].pDepthStencilState->depthBoundsTestEnable);
2603
2604 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002605 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002606 ParameterName("pCreateInfos[%i].pDepthStencilState->stencilTestEnable", ParameterName::IndexVector{i}),
2607 pCreateInfos[i].pDepthStencilState->stencilTestEnable);
2608
2609 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002610 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002611 ParameterName("pCreateInfos[%i].pDepthStencilState->front.failOp", ParameterName::IndexVector{i}),
2612 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->front.failOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002613 "VUID-VkStencilOpState-failOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002614
2615 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002616 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002617 ParameterName("pCreateInfos[%i].pDepthStencilState->front.passOp", ParameterName::IndexVector{i}),
2618 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->front.passOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002619 "VUID-VkStencilOpState-passOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002620
2621 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002622 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002623 ParameterName("pCreateInfos[%i].pDepthStencilState->front.depthFailOp", ParameterName::IndexVector{i}),
2624 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->front.depthFailOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002625 "VUID-VkStencilOpState-depthFailOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002626
2627 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002628 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002629 ParameterName("pCreateInfos[%i].pDepthStencilState->front.compareOp", ParameterName::IndexVector{i}),
2630 "VkCompareOp", AllVkCompareOpEnums, pCreateInfos[i].pDepthStencilState->front.compareOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002631 "VUID-VkPipelineDepthStencilStateCreateInfo-depthCompareOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002632
2633 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002634 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002635 ParameterName("pCreateInfos[%i].pDepthStencilState->back.failOp", ParameterName::IndexVector{i}),
2636 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->back.failOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002637 "VUID-VkStencilOpState-failOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002638
2639 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002640 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002641 ParameterName("pCreateInfos[%i].pDepthStencilState->back.passOp", ParameterName::IndexVector{i}),
2642 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->back.passOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002643 "VUID-VkStencilOpState-passOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002644
2645 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002646 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002647 ParameterName("pCreateInfos[%i].pDepthStencilState->back.depthFailOp", ParameterName::IndexVector{i}),
2648 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->back.depthFailOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002649 "VUID-VkStencilOpState-depthFailOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002650
2651 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002652 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002653 ParameterName("pCreateInfos[%i].pDepthStencilState->back.compareOp", ParameterName::IndexVector{i}),
2654 "VkCompareOp", AllVkCompareOpEnums, pCreateInfos[i].pDepthStencilState->back.compareOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002655 "VUID-VkPipelineDepthStencilStateCreateInfo-depthCompareOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002656
2657 if (pCreateInfos[i].pDepthStencilState->sType != VK_STRUCTURE_TYPE_PIPELINE_DEPTH_STENCIL_STATE_CREATE_INFO) {
sfricke-samsung81c56f72020-08-23 22:14:41 -07002658 skip |= LogError(device, "VUID-VkPipelineDepthStencilStateCreateInfo-sType-sType",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002659 "vkCreateGraphicsPipelines: parameter pCreateInfos[%d].pDepthStencilState->sType must be "
2660 "VK_STRUCTURE_TYPE_PIPELINE_DEPTH_STENCIL_STATE_CREATE_INFO",
2661 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002662 }
2663 }
2664
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002665 const VkStructureType allowed_structs_vk_pipeline_color_blend_state_create_info[] = {
Shannon McPherson9b9532b2018-10-24 12:00:09 -06002666 VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_ADVANCED_STATE_CREATE_INFO_EXT};
2667
Petr Krause91f7a12017-12-14 20:57:36 +01002668 if (pCreateInfos[i].pColorBlendState != nullptr && uses_color_attachment) {
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002669 skip |= validate_struct_type("vkCreateGraphicsPipelines",
2670 ParameterName("pCreateInfos[%i].pColorBlendState", ParameterName::IndexVector{i}),
2671 "VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO",
2672 pCreateInfos[i].pColorBlendState,
2673 VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO, false, kVUIDUndefined,
2674 "VUID-VkPipelineColorBlendStateCreateInfo-sType-sType");
2675
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002676 skip |= validate_struct_pnext(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002677 "vkCreateGraphicsPipelines",
Shannon McPherson9b9532b2018-10-24 12:00:09 -06002678 ParameterName("pCreateInfos[%i].pColorBlendState->pNext", ParameterName::IndexVector{i}),
2679 "VkPipelineColorBlendAdvancedStateCreateInfoEXT", pCreateInfos[i].pColorBlendState->pNext,
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002680 ARRAY_SIZE(allowed_structs_vk_pipeline_color_blend_state_create_info),
2681 allowed_structs_vk_pipeline_color_blend_state_create_info, GeneratedVulkanHeaderVersion,
sfricke-samsung32a27362020-02-28 09:06:42 -08002682 "VUID-VkPipelineColorBlendStateCreateInfo-pNext-pNext",
2683 "VUID-VkPipelineColorBlendStateCreateInfo-sType-unique");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002684
2685 skip |= validate_reserved_flags(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002686 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002687 ParameterName("pCreateInfos[%i].pColorBlendState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06002688 pCreateInfos[i].pColorBlendState->flags, "VUID-VkPipelineColorBlendStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002689
2690 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002691 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002692 ParameterName("pCreateInfos[%i].pColorBlendState->logicOpEnable", ParameterName::IndexVector{i}),
2693 pCreateInfos[i].pColorBlendState->logicOpEnable);
2694
2695 skip |= validate_array(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002696 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002697 ParameterName("pCreateInfos[%i].pColorBlendState->attachmentCount", ParameterName::IndexVector{i}),
2698 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments", ParameterName::IndexVector{i}),
Gabríel Arthúr Pétursson092b29b2018-03-21 22:44:11 +00002699 pCreateInfos[i].pColorBlendState->attachmentCount, &pCreateInfos[i].pColorBlendState->pAttachments, false,
Dave Houlton413a6782018-05-22 13:01:54 -06002700 true, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002701
2702 if (pCreateInfos[i].pColorBlendState->pAttachments != NULL) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002703 for (uint32_t attachment_index = 0; attachment_index < pCreateInfos[i].pColorBlendState->attachmentCount;
2704 ++attachment_index) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002705 skip |= validate_bool32("vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002706 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].blendEnable",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002707 ParameterName::IndexVector{i, attachment_index}),
2708 pCreateInfos[i].pColorBlendState->pAttachments[attachment_index].blendEnable);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002709
2710 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002711 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002712 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].srcColorBlendFactor",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002713 ParameterName::IndexVector{i, attachment_index}),
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002714 "VkBlendFactor", AllVkBlendFactorEnums,
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002715 pCreateInfos[i].pColorBlendState->pAttachments[attachment_index].srcColorBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06002716 "VUID-VkPipelineColorBlendAttachmentState-srcColorBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002717
2718 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002719 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002720 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].dstColorBlendFactor",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002721 ParameterName::IndexVector{i, attachment_index}),
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002722 "VkBlendFactor", AllVkBlendFactorEnums,
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002723 pCreateInfos[i].pColorBlendState->pAttachments[attachment_index].dstColorBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06002724 "VUID-VkPipelineColorBlendAttachmentState-dstColorBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002725
2726 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002727 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002728 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].colorBlendOp",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002729 ParameterName::IndexVector{i, attachment_index}),
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002730 "VkBlendOp", AllVkBlendOpEnums,
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002731 pCreateInfos[i].pColorBlendState->pAttachments[attachment_index].colorBlendOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002732 "VUID-VkPipelineColorBlendAttachmentState-colorBlendOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002733
2734 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002735 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002736 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].srcAlphaBlendFactor",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002737 ParameterName::IndexVector{i, attachment_index}),
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002738 "VkBlendFactor", AllVkBlendFactorEnums,
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002739 pCreateInfos[i].pColorBlendState->pAttachments[attachment_index].srcAlphaBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06002740 "VUID-VkPipelineColorBlendAttachmentState-srcAlphaBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002741
2742 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002743 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002744 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].dstAlphaBlendFactor",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002745 ParameterName::IndexVector{i, attachment_index}),
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002746 "VkBlendFactor", AllVkBlendFactorEnums,
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002747 pCreateInfos[i].pColorBlendState->pAttachments[attachment_index].dstAlphaBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06002748 "VUID-VkPipelineColorBlendAttachmentState-dstAlphaBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002749
2750 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002751 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002752 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].alphaBlendOp",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002753 ParameterName::IndexVector{i, attachment_index}),
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002754 "VkBlendOp", AllVkBlendOpEnums,
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002755 pCreateInfos[i].pColorBlendState->pAttachments[attachment_index].alphaBlendOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002756 "VUID-VkPipelineColorBlendAttachmentState-alphaBlendOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002757
2758 skip |=
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002759 validate_flags("vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002760 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].colorWriteMask",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002761 ParameterName::IndexVector{i, attachment_index}),
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002762 "VkColorComponentFlagBits", AllVkColorComponentFlagBits,
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002763 pCreateInfos[i].pColorBlendState->pAttachments[attachment_index].colorWriteMask,
Petr Kraus52758be2019-08-12 00:53:58 +02002764 kOptionalFlags, "VUID-VkPipelineColorBlendAttachmentState-colorWriteMask-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002765 }
2766 }
2767
2768 if (pCreateInfos[i].pColorBlendState->sType != VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO) {
sfricke-samsung81c56f72020-08-23 22:14:41 -07002769 skip |= LogError(device, "VUID-VkPipelineColorBlendStateCreateInfo-sType-sType",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002770 "vkCreateGraphicsPipelines: parameter pCreateInfos[%d].pColorBlendState->sType must be "
2771 "VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO",
2772 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002773 }
2774
2775 // If logicOpEnable is VK_TRUE, logicOp must be a valid VkLogicOp value
2776 if (pCreateInfos[i].pColorBlendState->logicOpEnable == VK_TRUE) {
2777 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002778 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002779 ParameterName("pCreateInfos[%i].pColorBlendState->logicOp", ParameterName::IndexVector{i}), "VkLogicOp",
Dave Houlton413a6782018-05-22 13:01:54 -06002780 AllVkLogicOpEnums, pCreateInfos[i].pColorBlendState->logicOp,
2781 "VUID-VkPipelineColorBlendStateCreateInfo-logicOpEnable-00607");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002782 }
2783 }
2784 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002785
Petr Kraus9752aae2017-11-24 03:05:50 +01002786 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_DERIVATIVE_BIT) {
2787 if (pCreateInfos[i].basePipelineIndex != -1) {
2788 if (pCreateInfos[i].basePipelineHandle != VK_NULL_HANDLE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002789 skip |=
2790 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-00724",
sfricke-samsunga470e0e2020-05-16 00:47:36 -07002791 "vkCreateGraphicsPipelines parameter, pCreateInfos[%u]->basePipelineHandle, must be "
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002792 "VK_NULL_HANDLE if pCreateInfos->flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT flag "
sfricke-samsunga470e0e2020-05-16 00:47:36 -07002793 "and pCreateInfos->basePipelineIndex is not -1.",
2794 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002795 }
2796 }
2797
Petr Kraus9752aae2017-11-24 03:05:50 +01002798 if (pCreateInfos[i].basePipelineHandle != VK_NULL_HANDLE) {
2799 if (pCreateInfos[i].basePipelineIndex != -1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002800 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-00725",
sfricke-samsunga470e0e2020-05-16 00:47:36 -07002801 "vkCreateGraphicsPipelines parameter, pCreateInfos[%u]->basePipelineIndex, must be -1 if "
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002802 "pCreateInfos->flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT flag and "
sfricke-samsunga470e0e2020-05-16 00:47:36 -07002803 "pCreateInfos->basePipelineHandle is not VK_NULL_HANDLE.",
2804 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002805 }
Mark Lobodzinski4dfeb942019-09-13 12:11:13 -06002806 } else {
Mike Schuchardte5c15cf2020-04-06 22:57:13 -07002807 if (static_cast<uint32_t>(pCreateInfos[i].basePipelineIndex) >= createInfoCount) {
sfricke-samsunga470e0e2020-05-16 00:47:36 -07002808 skip |=
2809 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-00723",
2810 "vkCreateGraphicsPipelines parameter pCreateInfos[%u]->basePipelineIndex (%d) must be a valid"
2811 "index into the pCreateInfos array, of size %d.",
2812 i, pCreateInfos[i].basePipelineIndex, createInfoCount);
Mark Lobodzinski4dfeb942019-09-13 12:11:13 -06002813 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002814 }
2815 }
2816
sfricke-samsung898cf222020-05-15 23:10:19 -07002817 if ((pCreateInfos[i].flags & VK_PIPELINE_CREATE_DISPATCH_BASE) != 0) {
2818 skip |= LogError(
2819 device, "VUID-VkGraphicsPipelineCreateInfo-flags-00764",
2820 "vkCreateGraphicsPipelines parameter pCreateInfos[%u]->flags must not contain VK_PIPELINE_CREATE_DISPATCH_BASE",
2821 i);
2822 }
2823
Petr Kraus9752aae2017-11-24 03:05:50 +01002824 if (pCreateInfos[i].pRasterizationState) {
Chris Mayer840b2c42019-08-22 18:12:22 +02002825 if (!device_extensions.vk_nv_fill_rectangle) {
2826 if (pCreateInfos[i].pRasterizationState->polygonMode == VK_POLYGON_MODE_FILL_RECTANGLE_NV) {
2827 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002828 LogError(device, "VUID-VkPipelineRasterizationStateCreateInfo-polygonMode-01414",
2829 "vkCreateGraphicsPipelines parameter, VkPolygonMode "
2830 "pCreateInfos->pRasterizationState->polygonMode cannot be VK_POLYGON_MODE_FILL_RECTANGLE_NV "
2831 "if the extension VK_NV_fill_rectangle is not enabled.");
Chris Mayer840b2c42019-08-22 18:12:22 +02002832 } else if ((pCreateInfos[i].pRasterizationState->polygonMode != VK_POLYGON_MODE_FILL) &&
2833 (physical_device_features.fillModeNonSolid == false)) {
sfricke-samsunga44586f2020-08-23 22:19:44 -07002834 skip |= LogError(device, "VUID-VkPipelineRasterizationStateCreateInfo-polygonMode-01413",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002835 "vkCreateGraphicsPipelines parameter, VkPolygonMode "
sfricke-samsunga470e0e2020-05-16 00:47:36 -07002836 "pCreateInfos[%u]->pRasterizationState->polygonMode cannot be VK_POLYGON_MODE_POINT or "
2837 "VK_POLYGON_MODE_LINE if VkPhysicalDeviceFeatures->fillModeNonSolid is false.",
2838 i);
Chris Mayer840b2c42019-08-22 18:12:22 +02002839 }
2840 } else {
2841 if ((pCreateInfos[i].pRasterizationState->polygonMode != VK_POLYGON_MODE_FILL) &&
2842 (pCreateInfos[i].pRasterizationState->polygonMode != VK_POLYGON_MODE_FILL_RECTANGLE_NV) &&
2843 (physical_device_features.fillModeNonSolid == false)) {
2844 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002845 LogError(device, "VUID-VkPipelineRasterizationStateCreateInfo-polygonMode-01507",
2846 "vkCreateGraphicsPipelines parameter, VkPolygonMode "
sfricke-samsunga470e0e2020-05-16 00:47:36 -07002847 "pCreateInfos[%u]->pRasterizationState->polygonMode must be VK_POLYGON_MODE_FILL or "
2848 "VK_POLYGON_MODE_FILL_RECTANGLE_NV if VkPhysicalDeviceFeatures->fillModeNonSolid is false.",
2849 i);
Chris Mayer840b2c42019-08-22 18:12:22 +02002850 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002851 }
Petr Kraus299ba622017-11-24 03:09:03 +01002852
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002853 if (!has_dynamic_line_width && !physical_device_features.wideLines &&
Petr Kraus299ba622017-11-24 03:09:03 +01002854 (pCreateInfos[i].pRasterizationState->lineWidth != 1.0f)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002855 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-00749",
2856 "The line width state is static (pCreateInfos[%" PRIu32
2857 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_LINE_WIDTH) and "
2858 "VkPhysicalDeviceFeatures::wideLines is disabled, but pCreateInfos[%" PRIu32
2859 "].pRasterizationState->lineWidth (=%f) is not 1.0.",
2860 i, i, pCreateInfos[i].pRasterizationState->lineWidth);
Petr Kraus299ba622017-11-24 03:09:03 +01002861 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002862 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002863 }
2864 }
2865
2866 return skip;
2867}
2868
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002869bool StatelessValidation::manual_PreCallValidateCreateComputePipelines(VkDevice device, VkPipelineCache pipelineCache,
2870 uint32_t createInfoCount,
2871 const VkComputePipelineCreateInfo *pCreateInfos,
2872 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05002873 VkPipeline *pPipelines) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002874 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002875 for (uint32_t i = 0; i < createInfoCount; i++) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002876 skip |= validate_string("vkCreateComputePipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002877 ParameterName("pCreateInfos[%i].stage.pName", ParameterName::IndexVector{i}),
Mark Lobodzinskiebee3552018-05-29 09:55:54 -06002878 "VUID-VkPipelineShaderStageCreateInfo-pName-parameter", pCreateInfos[i].stage.pName);
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07002879 auto feedback_struct = LvlFindInChain<VkPipelineCreationFeedbackCreateInfoEXT>(pCreateInfos[i].pNext);
Peter Chen85366392019-05-14 15:20:11 -04002880 if ((feedback_struct != nullptr) && (feedback_struct->pipelineStageCreationFeedbackCount != 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002881 skip |=
2882 LogError(device, "VUID-VkPipelineCreationFeedbackCreateInfoEXT-pipelineStageCreationFeedbackCount-02669",
2883 "vkCreateComputePipelines(): in pCreateInfo[%" PRIu32
2884 "], VkPipelineCreationFeedbackEXT::pipelineStageCreationFeedbackCount must equal 1, found %" PRIu32 ".",
2885 i, feedback_struct->pipelineStageCreationFeedbackCount);
Peter Chen85366392019-05-14 15:20:11 -04002886 }
sfricke-samsungc5227152020-02-09 17:36:31 -08002887
2888 // Make sure compute stage is selected
2889 if (pCreateInfos[i].stage.stage != VK_SHADER_STAGE_COMPUTE_BIT) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002890 skip |= LogError(device, "VUID-VkComputePipelineCreateInfo-stage-00701",
2891 "vkCreateComputePipelines(): the pCreateInfo[%u].stage.stage (%s) is not VK_SHADER_STAGE_COMPUTE_BIT",
2892 i, string_VkShaderStageFlagBits(pCreateInfos[i].stage.stage));
sfricke-samsungc5227152020-02-09 17:36:31 -08002893 }
sourav parmarcd5fb182020-07-17 12:58:44 -07002894
2895 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_SKIP_AABBS_BIT_KHR) {
2896 skip |=
2897 LogError(device, "VUID-VkComputePipelineCreateInfo-flags-03370",
2898 "vkCreateComputePipelines(): flags must not include VK_PIPELINE_CREATE_RAY_TRACING_SKIP_AABBS_BIT_KHR");
2899 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002900 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002901 return skip;
2902}
2903
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002904bool StatelessValidation::manual_PreCallValidateCreateSampler(VkDevice device, const VkSamplerCreateInfo *pCreateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -05002905 const VkAllocationCallbacks *pAllocator, VkSampler *pSampler) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002906 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002907
2908 if (pCreateInfo != nullptr) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002909 const auto &features = physical_device_features;
2910 const auto &limits = device_limits;
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002911
John Zulauf71968502017-10-26 13:51:15 -06002912 if (pCreateInfo->anisotropyEnable == VK_TRUE) {
2913 if (!in_inclusive_range(pCreateInfo->maxAnisotropy, 1.0F, limits.maxSamplerAnisotropy)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002914 skip |= LogError(device, "VUID-VkSamplerCreateInfo-anisotropyEnable-01071",
2915 "vkCreateSampler(): value of %s must be in range [1.0, %f] %s, but %f found.",
2916 "pCreateInfo->maxAnisotropy", limits.maxSamplerAnisotropy,
2917 "VkPhysicalDeviceLimits::maxSamplerAnistropy", pCreateInfo->maxAnisotropy);
John Zulauf71968502017-10-26 13:51:15 -06002918 }
2919
2920 // Anistropy cannot be enabled in sampler unless enabled as a feature
2921 if (features.samplerAnisotropy == VK_FALSE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002922 skip |= LogError(device, "VUID-VkSamplerCreateInfo-anisotropyEnable-01070",
2923 "vkCreateSampler(): Anisotropic sampling feature is not enabled, %s must be VK_FALSE.",
2924 "pCreateInfo->anisotropyEnable");
John Zulauf71968502017-10-26 13:51:15 -06002925 }
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002926 }
John Zulauf71968502017-10-26 13:51:15 -06002927
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002928 if (pCreateInfo->unnormalizedCoordinates == VK_TRUE) {
2929 if (pCreateInfo->minFilter != pCreateInfo->magFilter) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002930 skip |= LogError(device, "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01072",
2931 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
2932 "pCreateInfo->minFilter (%s) and pCreateInfo->magFilter (%s) must be equal.",
2933 string_VkFilter(pCreateInfo->minFilter), string_VkFilter(pCreateInfo->magFilter));
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002934 }
2935 if (pCreateInfo->mipmapMode != VK_SAMPLER_MIPMAP_MODE_NEAREST) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002936 skip |= LogError(device, "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01073",
2937 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
2938 "pCreateInfo->mipmapMode (%s) must be VK_SAMPLER_MIPMAP_MODE_NEAREST.",
2939 string_VkSamplerMipmapMode(pCreateInfo->mipmapMode));
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002940 }
2941 if (pCreateInfo->minLod != 0.0f || pCreateInfo->maxLod != 0.0f) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002942 skip |= LogError(device, "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01074",
2943 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
2944 "pCreateInfo->minLod (%f) and pCreateInfo->maxLod (%f) must both be zero.",
2945 pCreateInfo->minLod, pCreateInfo->maxLod);
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002946 }
2947 if ((pCreateInfo->addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE &&
2948 pCreateInfo->addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER) ||
2949 (pCreateInfo->addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE &&
2950 pCreateInfo->addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002951 skip |= LogError(device, "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01075",
2952 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
2953 "pCreateInfo->addressModeU (%s) and pCreateInfo->addressModeV (%s) must both be "
2954 "VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE or VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER.",
2955 string_VkSamplerAddressMode(pCreateInfo->addressModeU),
2956 string_VkSamplerAddressMode(pCreateInfo->addressModeV));
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002957 }
2958 if (pCreateInfo->anisotropyEnable == VK_TRUE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002959 skip |= LogError(device, "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01076",
2960 "vkCreateSampler(): pCreateInfo->anisotropyEnable and pCreateInfo->unnormalizedCoordinates must "
2961 "not both be VK_TRUE.");
John Zulauf71968502017-10-26 13:51:15 -06002962 }
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002963 if (pCreateInfo->compareEnable == VK_TRUE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002964 skip |= LogError(device, "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01077",
2965 "vkCreateSampler(): pCreateInfo->compareEnable and pCreateInfo->unnormalizedCoordinates must "
2966 "not both be VK_TRUE.");
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002967 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002968 }
2969
2970 // If compareEnable is VK_TRUE, compareOp must be a valid VkCompareOp value
2971 if (pCreateInfo->compareEnable == VK_TRUE) {
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002972 skip |= validate_ranged_enum("vkCreateSampler", "pCreateInfo->compareOp", "VkCompareOp", AllVkCompareOpEnums,
2973 pCreateInfo->compareOp, "VUID-VkSamplerCreateInfo-compareEnable-01080");
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07002974 const auto *sampler_reduction = LvlFindInChain<VkSamplerReductionModeCreateInfo>(pCreateInfo->pNext);
sfricke-samsung85252fb2020-05-08 20:44:06 -07002975 if (sampler_reduction != nullptr) {
2976 if (sampler_reduction->reductionMode != VK_SAMPLER_REDUCTION_MODE_WEIGHTED_AVERAGE) {
2977 skip |= LogError(
2978 device, "VUID-VkSamplerCreateInfo-compareEnable-01423",
2979 "copmareEnable is true so the sampler reduction mode must be VK_SAMPLER_REDUCTION_MODE_WEIGHTED_AVERAGE.");
2980 }
2981 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002982 }
2983
2984 // If any of addressModeU, addressModeV or addressModeW are VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER, borderColor must be a
2985 // valid VkBorderColor value
2986 if ((pCreateInfo->addressModeU == VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER) ||
2987 (pCreateInfo->addressModeV == VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER) ||
2988 (pCreateInfo->addressModeW == VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER)) {
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002989 skip |= validate_ranged_enum("vkCreateSampler", "pCreateInfo->borderColor", "VkBorderColor", AllVkBorderColorEnums,
2990 pCreateInfo->borderColor, "VUID-VkSamplerCreateInfo-addressModeU-01078");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002991 }
2992
2993 // If any of addressModeU, addressModeV or addressModeW are VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE, the
2994 // VK_KHR_sampler_mirror_clamp_to_edge extension must be enabled
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002995 if (!device_extensions.vk_khr_sampler_mirror_clamp_to_edge &&
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002996 ((pCreateInfo->addressModeU == VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE) ||
2997 (pCreateInfo->addressModeV == VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE) ||
2998 (pCreateInfo->addressModeW == VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE))) {
Dave Houlton413a6782018-05-22 13:01:54 -06002999 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003000 LogError(device, "VUID-VkSamplerCreateInfo-addressModeU-01079",
3001 "vkCreateSampler(): A VkSamplerAddressMode value is set to VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE "
3002 "but the VK_KHR_sampler_mirror_clamp_to_edge extension has not been enabled.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003003 }
John Zulauf275805c2017-10-26 15:34:49 -06003004
3005 // Checks for the IMG cubic filtering extension
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003006 if (device_extensions.vk_img_filter_cubic) {
John Zulauf275805c2017-10-26 15:34:49 -06003007 if ((pCreateInfo->anisotropyEnable == VK_TRUE) &&
3008 ((pCreateInfo->minFilter == VK_FILTER_CUBIC_IMG) || (pCreateInfo->magFilter == VK_FILTER_CUBIC_IMG))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003009 skip |= LogError(device, "VUID-VkSamplerCreateInfo-magFilter-01081",
3010 "vkCreateSampler(): Anisotropic sampling must not be VK_TRUE when either minFilter or magFilter "
3011 "are VK_FILTER_CUBIC_IMG.");
John Zulauf275805c2017-10-26 15:34:49 -06003012 }
3013 }
Mark Lobodzinski61992fc2020-01-14 14:00:08 -07003014
sfricke-samsungd91da4a2020-02-09 17:19:04 -08003015 // Check for valid Lod range
3016 if (pCreateInfo->minLod > pCreateInfo->maxLod) {
Mark Lobodzinski728ab482020-02-12 13:46:47 -07003017 skip |=
3018 LogError(device, "VUID-VkSamplerCreateInfo-maxLod-01973",
3019 "vkCreateSampler(): minLod (%f) is greater than maxLod (%f)", pCreateInfo->minLod, pCreateInfo->maxLod);
sfricke-samsungd91da4a2020-02-09 17:19:04 -08003020 }
3021
3022 // Check mipLodBias to device limit
3023 if (pCreateInfo->mipLodBias > limits.maxSamplerLodBias) {
Mark Lobodzinski728ab482020-02-12 13:46:47 -07003024 skip |= LogError(device, "VUID-VkSamplerCreateInfo-mipLodBias-01069",
3025 "vkCreateSampler(): mipLodBias (%f) is greater than VkPhysicalDeviceLimits::maxSamplerLodBias (%f)",
3026 pCreateInfo->mipLodBias, limits.maxSamplerLodBias);
sfricke-samsungd91da4a2020-02-09 17:19:04 -08003027 }
3028
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003029 const auto *sampler_conversion = LvlFindInChain<VkSamplerYcbcrConversionInfo>(pCreateInfo->pNext);
Mark Lobodzinski61992fc2020-01-14 14:00:08 -07003030 if (sampler_conversion != nullptr) {
3031 if ((pCreateInfo->addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE) ||
3032 (pCreateInfo->addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE) ||
3033 (pCreateInfo->addressModeW != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE) ||
3034 (pCreateInfo->anisotropyEnable != VK_FALSE) || (pCreateInfo->unnormalizedCoordinates != VK_FALSE)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003035 skip |= LogError(
Mark Lobodzinski728ab482020-02-12 13:46:47 -07003036 device, "VUID-VkSamplerCreateInfo-addressModeU-01646",
Mark Lobodzinski61992fc2020-01-14 14:00:08 -07003037 "vkCreateSampler(): SamplerYCbCrConversion is enabled: "
3038 "addressModeU (%s), addressModeV (%s), addressModeW (%s) must be CLAMP_TO_EDGE, and anisotropyEnable (%s) "
3039 "and unnormalizedCoordinates (%s) must be VK_FALSE.",
3040 string_VkSamplerAddressMode(pCreateInfo->addressModeU), string_VkSamplerAddressMode(pCreateInfo->addressModeV),
3041 string_VkSamplerAddressMode(pCreateInfo->addressModeW), pCreateInfo->anisotropyEnable ? "VK_TRUE" : "VK_FALSE",
3042 pCreateInfo->unnormalizedCoordinates ? "VK_TRUE" : "VK_FALSE");
3043 }
3044 }
janharaldfredriksen-arm3b793772020-05-12 18:55:53 +02003045
3046 if (pCreateInfo->flags & VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT) {
3047 if (pCreateInfo->minFilter != pCreateInfo->magFilter) {
3048 skip |= LogError(device, "VUID-VkSamplerCreateInfo-flags-02574",
3049 "vkCreateSampler(): when flags includes VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT, "
3050 "pCreateInfo->minFilter (%s) and pCreateInfo->magFilter (%s) must be equal.",
3051 string_VkFilter(pCreateInfo->minFilter), string_VkFilter(pCreateInfo->magFilter));
3052 }
3053 if (pCreateInfo->mipmapMode != VK_SAMPLER_MIPMAP_MODE_NEAREST) {
3054 skip |= LogError(device, "VUID-VkSamplerCreateInfo-flags-02575",
3055 "vkCreateSampler(): when flags includes VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT, "
3056 "pCreateInfo->mipmapMode (%s) must be VK_SAMPLER_MIPMAP_MODE_NEAREST.",
3057 string_VkSamplerMipmapMode(pCreateInfo->mipmapMode));
3058 }
3059 if (pCreateInfo->minLod != 0.0 || pCreateInfo->maxLod != 0.0) {
3060 skip |= LogError(device, "VUID-VkSamplerCreateInfo-flags-02576",
3061 "vkCreateSampler(): when flags includes VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT, "
3062 "pCreateInfo->minLod (%f) and pCreateInfo->maxLod (%f) must be zero.",
3063 pCreateInfo->minLod, pCreateInfo->maxLod);
3064 }
3065 if (((pCreateInfo->addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE) &&
3066 (pCreateInfo->addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER)) ||
3067 ((pCreateInfo->addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE) &&
3068 (pCreateInfo->addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER))) {
3069 skip |= LogError(device, "VUID-VkSamplerCreateInfo-flags-02577",
3070 "vkCreateSampler(): when flags includes VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT, "
3071 "pCreateInfo->addressModeU (%s) and pCreateInfo->addressModeV (%s) must be "
3072 "VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE or VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER",
3073 string_VkSamplerAddressMode(pCreateInfo->addressModeU),
3074 string_VkSamplerAddressMode(pCreateInfo->addressModeV));
3075 }
3076 if (pCreateInfo->anisotropyEnable) {
3077 skip |= LogError(device, "VUID-VkSamplerCreateInfo-flags-02578",
3078 "vkCreateSampler(): when flags includes VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT, "
3079 "pCreateInfo->anisotropyEnable must be VK_FALSE");
3080 }
3081 if (pCreateInfo->compareEnable) {
3082 skip |= LogError(device, "VUID-VkSamplerCreateInfo-flags-02579",
3083 "vkCreateSampler(): when flags includes VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT, "
3084 "pCreateInfo->compareEnable must be VK_FALSE");
3085 }
3086 if (pCreateInfo->unnormalizedCoordinates) {
3087 skip |= LogError(device, "VUID-VkSamplerCreateInfo-flags-02580",
3088 "vkCreateSampler(): when flags includes VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT, "
3089 "pCreateInfo->unnormalizedCoordinates must be VK_FALSE");
3090 }
3091 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003092 }
3093
Tony-LunarG7337b312020-04-15 16:40:25 -06003094 if (pCreateInfo->borderColor == VK_BORDER_COLOR_INT_CUSTOM_EXT ||
3095 pCreateInfo->borderColor == VK_BORDER_COLOR_FLOAT_CUSTOM_EXT) {
3096 if (!device_extensions.vk_ext_custom_border_color) {
3097 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
3098 "VkSamplerCreateInfo->borderColor is %s but %s is not enabled.\n",
3099 string_VkBorderColor(pCreateInfo->borderColor), VK_EXT_CUSTOM_BORDER_COLOR_EXTENSION_NAME);
3100 }
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003101 auto custom_create_info = LvlFindInChain<VkSamplerCustomBorderColorCreateInfoEXT>(pCreateInfo->pNext);
Tony-LunarG7337b312020-04-15 16:40:25 -06003102 if (!custom_create_info) {
3103 skip |=
3104 LogError(device, "VUID-VkSamplerCreateInfo-borderColor-04011",
3105 "VkSamplerCreateInfo->borderColor is set to %s but there is no VkSamplerCustomBorderColorCreateInfoEXT "
3106 "struct in pNext chain.\n",
3107 string_VkBorderColor(pCreateInfo->borderColor));
3108 } else {
3109 if ((custom_create_info->format != VK_FORMAT_UNDEFINED) &&
3110 ((pCreateInfo->borderColor == VK_BORDER_COLOR_INT_CUSTOM_EXT && !FormatIsSampledInt(custom_create_info->format)) ||
3111 (pCreateInfo->borderColor == VK_BORDER_COLOR_FLOAT_CUSTOM_EXT &&
3112 !FormatIsSampledFloat(custom_create_info->format)))) {
3113 skip |= LogError(device, "VUID-VkSamplerCustomBorderColorCreateInfoEXT-format-04013",
3114 "VkSamplerCreateInfo->borderColor is %s but VkSamplerCustomBorderColorCreateInfoEXT.format = %s "
3115 "whose type does not match\n",
3116 string_VkBorderColor(pCreateInfo->borderColor), string_VkFormat(custom_create_info->format));
3117 ;
3118 }
3119 }
3120 }
3121
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003122 return skip;
3123}
3124
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003125bool StatelessValidation::manual_PreCallValidateCreateDescriptorSetLayout(VkDevice device,
3126 const VkDescriptorSetLayoutCreateInfo *pCreateInfo,
3127 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003128 VkDescriptorSetLayout *pSetLayout) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003129 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003130
3131 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
3132 if ((pCreateInfo != nullptr) && (pCreateInfo->pBindings != nullptr)) {
3133 for (uint32_t i = 0; i < pCreateInfo->bindingCount; ++i) {
3134 if (pCreateInfo->pBindings[i].descriptorCount != 0) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003135 if (((pCreateInfo->pBindings[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLER) ||
3136 (pCreateInfo->pBindings[i].descriptorType == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER)) &&
3137 (pCreateInfo->pBindings[i].pImmutableSamplers != nullptr)) {
3138 for (uint32_t descriptor_index = 0; descriptor_index < pCreateInfo->pBindings[i].descriptorCount;
3139 ++descriptor_index) {
3140 if (pCreateInfo->pBindings[i].pImmutableSamplers[descriptor_index] == VK_NULL_HANDLE) {
Spencer Frickeb0e30822020-03-23 10:32:30 -07003141 skip |= LogError(device, "VUID-VkDescriptorSetLayoutBinding-descriptorType-00282",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003142 "vkCreateDescriptorSetLayout: required parameter "
3143 "pCreateInfo->pBindings[%d].pImmutableSamplers[%d] specified as VK_NULL_HANDLE",
3144 i, descriptor_index);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003145 }
3146 }
3147 }
3148
3149 // If descriptorCount is not 0, stageFlags must be a valid combination of VkShaderStageFlagBits values
3150 if ((pCreateInfo->pBindings[i].stageFlags != 0) &&
3151 ((pCreateInfo->pBindings[i].stageFlags & (~AllVkShaderStageFlagBits)) != 0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003152 skip |= LogError(device, "VUID-VkDescriptorSetLayoutBinding-descriptorCount-00283",
3153 "vkCreateDescriptorSetLayout(): if pCreateInfo->pBindings[%d].descriptorCount is not 0, "
3154 "pCreateInfo->pBindings[%d].stageFlags must be a valid combination of VkShaderStageFlagBits "
3155 "values.",
3156 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003157 }
Spencer Fricke84d0cc02020-03-16 17:21:59 -07003158
3159 if ((pCreateInfo->pBindings[i].descriptorType == VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT) &&
3160 (pCreateInfo->pBindings[i].stageFlags != 0) &&
3161 (pCreateInfo->pBindings[i].stageFlags != VK_SHADER_STAGE_FRAGMENT_BIT)) {
3162 skip |=
3163 LogError(device, "VUID-VkDescriptorSetLayoutBinding-descriptorType-01510",
3164 "vkCreateDescriptorSetLayout(): if pCreateInfo->pBindings[%d].descriptorCount is not 0 and "
3165 "descriptorType is VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT then pCreateInfo->pBindings[%d].stageFlags "
3166 "must be 0 or VK_SHADER_STAGE_FRAGMENT_BIT but is currently %s",
3167 i, i, string_VkShaderStageFlags(pCreateInfo->pBindings[i].stageFlags).c_str());
3168 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003169 }
3170 }
3171 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003172 return skip;
3173}
3174
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003175bool StatelessValidation::manual_PreCallValidateFreeDescriptorSets(VkDevice device, VkDescriptorPool descriptorPool,
3176 uint32_t descriptorSetCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003177 const VkDescriptorSet *pDescriptorSets) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003178 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
3179 // This is an array of handles, where the elements are allowed to be VK_NULL_HANDLE, and does not require any validation beyond
3180 // validate_array()
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003181 return validate_array("vkFreeDescriptorSets", "descriptorSetCount", "pDescriptorSets", descriptorSetCount, &pDescriptorSets,
3182 true, true, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003183}
3184
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07003185bool StatelessValidation::validate_WriteDescriptorSet(const char *vkCallingFunction, const uint32_t descriptorWriteCount,
3186 const VkWriteDescriptorSet *pDescriptorWrites,
3187 const bool validateDstSet) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003188 bool skip = false;
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07003189
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003190 if (pDescriptorWrites != NULL) {
3191 for (uint32_t i = 0; i < descriptorWriteCount; ++i) {
3192 // descriptorCount must be greater than 0
3193 if (pDescriptorWrites[i].descriptorCount == 0) {
3194 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003195 LogError(device, "VUID-VkWriteDescriptorSet-descriptorCount-arraylength",
3196 "%s(): parameter pDescriptorWrites[%d].descriptorCount must be greater than 0.", vkCallingFunction, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003197 }
3198
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07003199 // If called from vkCmdPushDescriptorSetKHR, the dstSet member is ignored.
3200 if (validateDstSet) {
3201 // dstSet must be a valid VkDescriptorSet handle
3202 skip |= validate_required_handle(vkCallingFunction,
3203 ParameterName("pDescriptorWrites[%i].dstSet", ParameterName::IndexVector{i}),
3204 pDescriptorWrites[i].dstSet);
3205 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003206
3207 if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLER) ||
3208 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER) ||
3209 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE) ||
3210 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_IMAGE) ||
3211 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT)) {
3212 // If descriptorType is VK_DESCRIPTOR_TYPE_SAMPLER, VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER,
3213 // VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE, VK_DESCRIPTOR_TYPE_STORAGE_IMAGE or VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT,
Jeff Bolz165818a2020-05-08 11:19:03 -05003214 // pImageInfo must be a pointer to an array of descriptorCount valid VkDescriptorImageInfo structures.
3215 // Valid imageView handles are checked in ObjectLifetimes::ValidateDescriptorWrite.
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003216 if (pDescriptorWrites[i].pImageInfo == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003217 skip |= LogError(device, "VUID-VkWriteDescriptorSet-descriptorType-00322",
3218 "%s(): if pDescriptorWrites[%d].descriptorType is "
3219 "VK_DESCRIPTOR_TYPE_SAMPLER, VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER, "
3220 "VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE, VK_DESCRIPTOR_TYPE_STORAGE_IMAGE or "
3221 "VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT, pDescriptorWrites[%d].pImageInfo must not be NULL.",
3222 vkCallingFunction, i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003223 } else if (pDescriptorWrites[i].descriptorType != VK_DESCRIPTOR_TYPE_SAMPLER) {
3224 // If descriptorType is VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER, VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE,
Jeff Bolz165818a2020-05-08 11:19:03 -05003225 // VK_DESCRIPTOR_TYPE_STORAGE_IMAGE or VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT, the imageLayout
3226 // member of any given element of pImageInfo must be a valid VkImageLayout
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003227 for (uint32_t descriptor_index = 0; descriptor_index < pDescriptorWrites[i].descriptorCount;
3228 ++descriptor_index) {
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07003229 skip |= validate_ranged_enum(vkCallingFunction,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003230 ParameterName("pDescriptorWrites[%i].pImageInfo[%i].imageLayout",
3231 ParameterName::IndexVector{i, descriptor_index}),
3232 "VkImageLayout", AllVkImageLayoutEnums,
Dave Houlton413a6782018-05-22 13:01:54 -06003233 pDescriptorWrites[i].pImageInfo[descriptor_index].imageLayout, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003234 }
3235 }
3236 } else if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER) ||
3237 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER) ||
3238 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC) ||
3239 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC)) {
3240 // If descriptorType is VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER, VK_DESCRIPTOR_TYPE_STORAGE_BUFFER,
3241 // VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC or VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC, pBufferInfo must be a
3242 // pointer to an array of descriptorCount valid VkDescriptorBufferInfo structures
Jeff Bolz165818a2020-05-08 11:19:03 -05003243 // Valid buffer handles are checked in ObjectLifetimes::ValidateDescriptorWrite.
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003244 if (pDescriptorWrites[i].pBufferInfo == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003245 skip |= LogError(device, "VUID-VkWriteDescriptorSet-descriptorType-00324",
3246 "%s(): if pDescriptorWrites[%d].descriptorType is "
3247 "VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER, VK_DESCRIPTOR_TYPE_STORAGE_BUFFER, "
3248 "VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC or VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC, "
3249 "pDescriptorWrites[%d].pBufferInfo must not be NULL.",
3250 vkCallingFunction, i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003251 } else {
Jeff Bolz165818a2020-05-08 11:19:03 -05003252 const auto *robustness2_features =
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003253 LvlFindInChain<VkPhysicalDeviceRobustness2FeaturesEXT>(device_createinfo_pnext);
Jeff Bolz165818a2020-05-08 11:19:03 -05003254 if (robustness2_features && robustness2_features->nullDescriptor) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003255 for (uint32_t descriptor_index = 0; descriptor_index < pDescriptorWrites[i].descriptorCount;
3256 ++descriptor_index) {
3257 if (pDescriptorWrites[i].pBufferInfo[descriptor_index].buffer == VK_NULL_HANDLE &&
3258 (pDescriptorWrites[i].pBufferInfo[descriptor_index].offset != 0 ||
3259 pDescriptorWrites[i].pBufferInfo[descriptor_index].range != VK_WHOLE_SIZE)) {
Jeff Bolz165818a2020-05-08 11:19:03 -05003260 skip |= LogError(device, "VUID-VkDescriptorBufferInfo-buffer-02999",
3261 "%s(): if pDescriptorWrites[%d].buffer is VK_NULL_HANDLE, "
baldurk751594b2020-09-09 09:41:02 +01003262 "offset (%" PRIu64 ") must be zero and range (%" PRIu64 ") must be VK_WHOLE_SIZE.",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003263 vkCallingFunction, i, pDescriptorWrites[i].pBufferInfo[descriptor_index].offset,
3264 pDescriptorWrites[i].pBufferInfo[descriptor_index].range);
Jeff Bolz165818a2020-05-08 11:19:03 -05003265 }
3266 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003267 }
3268 }
3269 } else if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER) ||
3270 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER)) {
Jeff Bolz165818a2020-05-08 11:19:03 -05003271 // Valid bufferView handles are checked in ObjectLifetimes::ValidateDescriptorWrite.
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003272 }
3273
3274 if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER) ||
3275 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC)) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003276 VkDeviceSize uniform_alignment = device_limits.minUniformBufferOffsetAlignment;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003277 for (uint32_t j = 0; j < pDescriptorWrites[i].descriptorCount; j++) {
3278 if (pDescriptorWrites[i].pBufferInfo != NULL) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003279 if (SafeModulo(pDescriptorWrites[i].pBufferInfo[j].offset, uniform_alignment) != 0) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06003280 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003281 LogError(device, "VUID-VkWriteDescriptorSet-descriptorType-00327",
3282 "%s(): pDescriptorWrites[%d].pBufferInfo[%d].offset (0x%" PRIxLEAST64
3283 ") must be a multiple of device limit minUniformBufferOffsetAlignment 0x%" PRIxLEAST64 ".",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003284 vkCallingFunction, i, j, pDescriptorWrites[i].pBufferInfo[j].offset, uniform_alignment);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003285 }
3286 }
3287 }
3288 } else if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER) ||
3289 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC)) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003290 VkDeviceSize storage_alignment = device_limits.minStorageBufferOffsetAlignment;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003291 for (uint32_t j = 0; j < pDescriptorWrites[i].descriptorCount; j++) {
3292 if (pDescriptorWrites[i].pBufferInfo != NULL) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003293 if (SafeModulo(pDescriptorWrites[i].pBufferInfo[j].offset, storage_alignment) != 0) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06003294 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003295 LogError(device, "VUID-VkWriteDescriptorSet-descriptorType-00328",
3296 "%s(): pDescriptorWrites[%d].pBufferInfo[%d].offset (0x%" PRIxLEAST64
3297 ") must be a multiple of device limit minStorageBufferOffsetAlignment 0x%" PRIxLEAST64 ".",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003298 vkCallingFunction, i, j, pDescriptorWrites[i].pBufferInfo[j].offset, storage_alignment);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003299 }
3300 }
3301 }
3302 }
sourav parmara96ab1a2020-04-25 16:28:23 -07003303 // pNext chain must be either NULL or a pointer to a valid instance of VkWriteDescriptorSetAccelerationStructureKHR
3304 // or VkWriteDescriptorSetInlineUniformBlockEX
sourav parmarbcee7512020-12-28 14:34:49 -08003305 if (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_ACCELERATION_STRUCTURE_KHR) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003306 const auto *pnext_struct = LvlFindInChain<VkWriteDescriptorSetAccelerationStructureKHR>(pDescriptorWrites[i].pNext);
sourav parmarbcee7512020-12-28 14:34:49 -08003307 if (!pnext_struct || (pnext_struct->accelerationStructureCount != pDescriptorWrites[i].descriptorCount)) {
3308 skip |= LogError(device, "VUID-VkWriteDescriptorSet-descriptorType-02382",
3309 "%s(): If descriptorType is VK_DESCRIPTOR_TYPE_ACCELERATION_STRUCTURE_KHR, the pNext"
3310 "chain must include a VkWriteDescriptorSetAccelerationStructureKHR structure whose "
3311 "accelerationStructureCount %d member equals descriptorCount %d.",
3312 vkCallingFunction, pnext_struct ? pnext_struct->accelerationStructureCount : -1,
3313 pDescriptorWrites[i].descriptorCount);
3314 }
3315 // further checks only if we have right structtype
3316 if (pnext_struct) {
3317 if (pnext_struct->accelerationStructureCount != pDescriptorWrites[i].descriptorCount) {
3318 skip |= LogError(
3319 device, "VUID-VkWriteDescriptorSetAccelerationStructureKHR-accelerationStructureCount-02236",
3320 "%s(): accelerationStructureCount %d must be equal to descriptorCount %d in the extended structure "
3321 ".",
3322 vkCallingFunction, pnext_struct->accelerationStructureCount, pDescriptorWrites[i].descriptorCount);
sourav parmara96ab1a2020-04-25 16:28:23 -07003323 }
sourav parmarbcee7512020-12-28 14:34:49 -08003324 if (pnext_struct->accelerationStructureCount == 0) {
3325 skip |= LogError(device,
3326 "VUID-VkWriteDescriptorSetAccelerationStructureKHR-accelerationStructureCount-arraylength",
3327 "%s(): accelerationStructureCount must be greater than 0 .");
3328 }
3329 const auto *robustness2_features =
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003330 LvlFindInChain<VkPhysicalDeviceRobustness2FeaturesEXT>(device_createinfo_pnext);
sourav parmarbcee7512020-12-28 14:34:49 -08003331 if (robustness2_features && robustness2_features->nullDescriptor == VK_FALSE) {
3332 for (uint32_t j = 0; j < pnext_struct->accelerationStructureCount; ++j) {
3333 if (pnext_struct->pAccelerationStructures[j] == VK_NULL_HANDLE) {
3334 skip |= LogError(device,
3335 "VUID-VkWriteDescriptorSetAccelerationStructureKHR-pAccelerationStructures-03580",
3336 "%s(): If the nullDescriptor feature is not enabled, each member of "
3337 "pAccelerationStructures must not be VK_NULL_HANDLE.");
sourav parmarcd5fb182020-07-17 12:58:44 -07003338 }
3339 }
3340 }
sourav parmarbcee7512020-12-28 14:34:49 -08003341 }
3342 } else if (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_ACCELERATION_STRUCTURE_NV) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003343 const auto *pnext_struct = LvlFindInChain<VkWriteDescriptorSetAccelerationStructureNV>(pDescriptorWrites[i].pNext);
sourav parmarbcee7512020-12-28 14:34:49 -08003344 if (!pnext_struct || (pnext_struct->accelerationStructureCount != pDescriptorWrites[i].descriptorCount)) {
3345 skip |= LogError(device, "VUID-VkWriteDescriptorSet-descriptorType-03817",
3346 "%s(): If descriptorType is VK_DESCRIPTOR_TYPE_ACCELERATION_STRUCTURE_NV, the pNext"
3347 "chain must include a VkWriteDescriptorSetAccelerationStructureNV structure whose "
3348 "accelerationStructureCount %d member equals descriptorCount %d.",
3349 vkCallingFunction, pnext_struct ? pnext_struct->accelerationStructureCount : -1,
3350 pDescriptorWrites[i].descriptorCount);
3351 }
3352 // further checks only if we have right structtype
3353 if (pnext_struct) {
3354 if (pnext_struct->accelerationStructureCount != pDescriptorWrites[i].descriptorCount) {
3355 skip |= LogError(
3356 device, "VUID-VkWriteDescriptorSetAccelerationStructureNV-accelerationStructureCount-03747",
3357 "%s(): accelerationStructureCount %d must be equal to descriptorCount %d in the extended structure "
3358 ".",
3359 vkCallingFunction, pnext_struct->accelerationStructureCount, pDescriptorWrites[i].descriptorCount);
sourav parmarcd5fb182020-07-17 12:58:44 -07003360 }
sourav parmarbcee7512020-12-28 14:34:49 -08003361 if (pnext_struct->accelerationStructureCount == 0) {
3362 skip |= LogError(device,
3363 "VUID-VkWriteDescriptorSetAccelerationStructureNV-accelerationStructureCount-arraylength",
3364 "%s(): accelerationStructureCount must be greater than 0 .");
3365 }
3366 const auto *robustness2_features =
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003367 LvlFindInChain<VkPhysicalDeviceRobustness2FeaturesEXT>(device_createinfo_pnext);
sourav parmarbcee7512020-12-28 14:34:49 -08003368 if (robustness2_features && robustness2_features->nullDescriptor == VK_FALSE) {
3369 for (uint32_t j = 0; j < pnext_struct->accelerationStructureCount; ++j) {
3370 if (pnext_struct->pAccelerationStructures[j] == VK_NULL_HANDLE) {
3371 skip |= LogError(device,
3372 "VUID-VkWriteDescriptorSetAccelerationStructureNV-pAccelerationStructures-03749",
3373 "%s(): If the nullDescriptor feature is not enabled, each member of "
3374 "pAccelerationStructures must not be VK_NULL_HANDLE.");
sourav parmarcd5fb182020-07-17 12:58:44 -07003375 }
3376 }
sourav parmara96ab1a2020-04-25 16:28:23 -07003377 }
3378 }
3379 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003380 }
3381 }
3382 return skip;
3383}
3384
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07003385bool StatelessValidation::manual_PreCallValidateUpdateDescriptorSets(VkDevice device, uint32_t descriptorWriteCount,
3386 const VkWriteDescriptorSet *pDescriptorWrites,
3387 uint32_t descriptorCopyCount,
3388 const VkCopyDescriptorSet *pDescriptorCopies) const {
3389 return validate_WriteDescriptorSet("vkUpdateDescriptorSets", descriptorWriteCount, pDescriptorWrites);
3390}
3391
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003392bool StatelessValidation::manual_PreCallValidateCreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo,
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003393 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003394 VkRenderPass *pRenderPass) const {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003395 return CreateRenderPassGeneric(device, pCreateInfo, pAllocator, pRenderPass, RENDER_PASS_VERSION_1);
3396}
3397
sfricke-samsung681ab7b2020-10-29 01:53:35 -07003398bool StatelessValidation::manual_PreCallValidateCreateRenderPass2(VkDevice device, const VkRenderPassCreateInfo2 *pCreateInfo,
3399 const VkAllocationCallbacks *pAllocator,
3400 VkRenderPass *pRenderPass) const {
3401 return CreateRenderPassGeneric(device, pCreateInfo, pAllocator, pRenderPass, RENDER_PASS_VERSION_2);
3402}
3403
Mike Schuchardt2df08912020-12-15 16:28:09 -08003404bool StatelessValidation::manual_PreCallValidateCreateRenderPass2KHR(VkDevice device, const VkRenderPassCreateInfo2 *pCreateInfo,
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003405 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003406 VkRenderPass *pRenderPass) const {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003407 return CreateRenderPassGeneric(device, pCreateInfo, pAllocator, pRenderPass, RENDER_PASS_VERSION_2);
3408}
3409
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003410bool StatelessValidation::manual_PreCallValidateFreeCommandBuffers(VkDevice device, VkCommandPool commandPool,
3411 uint32_t commandBufferCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003412 const VkCommandBuffer *pCommandBuffers) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003413 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003414
3415 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
3416 // This is an array of handles, where the elements are allowed to be VK_NULL_HANDLE, and does not require any validation beyond
3417 // validate_array()
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003418 skip |= validate_array("vkFreeCommandBuffers", "commandBufferCount", "pCommandBuffers", commandBufferCount, &pCommandBuffers,
3419 true, true, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003420 return skip;
3421}
3422
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003423bool StatelessValidation::manual_PreCallValidateBeginCommandBuffer(VkCommandBuffer commandBuffer,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003424 const VkCommandBufferBeginInfo *pBeginInfo) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003425 bool skip = false;
Petr Krause7bb9e82019-08-11 21:34:43 +02003426
3427 // VkCommandBufferInheritanceInfo validation, due to a 'noautovalidity' of pBeginInfo->pInheritanceInfo in vkBeginCommandBuffer
3428 const char *cmd_name = "vkBeginCommandBuffer";
Tony-LunarG3c287f62020-12-17 12:39:49 -07003429 bool cb_is_secondary;
3430 {
3431 auto lock = cb_read_lock();
3432 cb_is_secondary = (secondary_cb_map.find(commandBuffer) != secondary_cb_map.end());
3433 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003434
Tony-LunarG3c287f62020-12-17 12:39:49 -07003435 if (cb_is_secondary) {
3436 // Implicit VUs
3437 // validate only sType here; pointer has to be validated in core_validation
3438 const bool k_not_required = false;
3439 const char *k_no_vuid = nullptr;
3440 const VkCommandBufferInheritanceInfo *info = pBeginInfo->pInheritanceInfo;
3441 skip |= validate_struct_type(cmd_name, "pBeginInfo->pInheritanceInfo", "VK_STRUCTURE_TYPE_COMMAND_BUFFER_INHERITANCE_INFO",
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003442 info, VK_STRUCTURE_TYPE_COMMAND_BUFFER_INHERITANCE_INFO, k_not_required, k_no_vuid,
3443 "VUID-VkCommandBufferInheritanceInfo-sType-sType");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003444
Tony-LunarG3c287f62020-12-17 12:39:49 -07003445 if (info) {
3446 const VkStructureType allowed_structs_vk_command_buffer_inheritance_info[] = {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003447 VK_STRUCTURE_TYPE_COMMAND_BUFFER_INHERITANCE_CONDITIONAL_RENDERING_INFO_EXT};
Tony-LunarG3c287f62020-12-17 12:39:49 -07003448 skip |= validate_struct_pnext(
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003449 cmd_name, "pBeginInfo->pInheritanceInfo->pNext", "VkCommandBufferInheritanceConditionalRenderingInfoEXT",
3450 info->pNext, ARRAY_SIZE(allowed_structs_vk_command_buffer_inheritance_info),
3451 allowed_structs_vk_command_buffer_inheritance_info, GeneratedVulkanHeaderVersion,
3452 "VUID-VkCommandBufferInheritanceInfo-pNext-pNext", "VUID-VkCommandBufferInheritanceInfo-sType-unique");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003453
Tony-LunarG3c287f62020-12-17 12:39:49 -07003454 skip |= validate_bool32(cmd_name, "pBeginInfo->pInheritanceInfo->occlusionQueryEnable", info->occlusionQueryEnable);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003455
Tony-LunarG3c287f62020-12-17 12:39:49 -07003456 // Explicit VUs
3457 if (!physical_device_features.inheritedQueries && info->occlusionQueryEnable == VK_TRUE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003458 skip |= LogError(
Tony-LunarG3c287f62020-12-17 12:39:49 -07003459 commandBuffer, "VUID-VkCommandBufferInheritanceInfo-occlusionQueryEnable-00056",
3460 "%s: Inherited queries feature is disabled, but pBeginInfo->pInheritanceInfo->occlusionQueryEnable is VK_TRUE.",
3461 cmd_name);
3462 }
3463
3464 if (physical_device_features.inheritedQueries) {
3465 skip |= validate_flags(cmd_name, "pBeginInfo->pInheritanceInfo->queryFlags", "VkQueryControlFlagBits",
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003466 AllVkQueryControlFlagBits, info->queryFlags, kOptionalFlags,
3467 "VUID-VkCommandBufferInheritanceInfo-queryFlags-00057");
3468 } else { // !inheritedQueries
Tony-LunarG3c287f62020-12-17 12:39:49 -07003469 skip |= validate_reserved_flags(cmd_name, "pBeginInfo->pInheritanceInfo->queryFlags", info->queryFlags,
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003470 "VUID-VkCommandBufferInheritanceInfo-queryFlags-02788");
Tony-LunarG3c287f62020-12-17 12:39:49 -07003471 }
3472
3473 if (physical_device_features.pipelineStatisticsQuery) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003474 skip |=
3475 validate_flags(cmd_name, "pBeginInfo->pInheritanceInfo->pipelineStatistics", "VkQueryPipelineStatisticFlagBits",
3476 AllVkQueryPipelineStatisticFlagBits, info->pipelineStatistics, kOptionalFlags,
3477 "VUID-VkCommandBufferInheritanceInfo-pipelineStatistics-02789");
3478 } else { // !pipelineStatisticsQuery
3479 skip |=
3480 validate_reserved_flags(cmd_name, "pBeginInfo->pInheritanceInfo->pipelineStatistics", info->pipelineStatistics,
3481 "VUID-VkCommandBufferInheritanceInfo-pipelineStatistics-00058");
Tony-LunarG3c287f62020-12-17 12:39:49 -07003482 }
3483
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003484 const auto *conditional_rendering = LvlFindInChain<VkCommandBufferInheritanceConditionalRenderingInfoEXT>(info->pNext);
Tony-LunarG3c287f62020-12-17 12:39:49 -07003485 if (conditional_rendering) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003486 const auto *cr_features = LvlFindInChain<VkPhysicalDeviceConditionalRenderingFeaturesEXT>(device_createinfo_pnext);
Tony-LunarG3c287f62020-12-17 12:39:49 -07003487 const auto inherited_conditional_rendering = cr_features && cr_features->inheritedConditionalRendering;
3488 if (!inherited_conditional_rendering && conditional_rendering->conditionalRenderingEnable == VK_TRUE) {
3489 skip |= LogError(
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003490 commandBuffer,
3491 "VUID-VkCommandBufferInheritanceConditionalRenderingInfoEXT-conditionalRenderingEnable-01977",
Tony-LunarG3c287f62020-12-17 12:39:49 -07003492 "vkBeginCommandBuffer: Inherited conditional rendering is disabled, but "
3493 "pBeginInfo->pInheritanceInfo->pNext<VkCommandBufferInheritanceConditionalRenderingInfoEXT> is VK_TRUE.");
3494 }
Petr Kraus139757b2019-08-15 17:19:33 +02003495 }
3496 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003497 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003498 return skip;
3499}
3500
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003501bool StatelessValidation::manual_PreCallValidateCmdSetViewport(VkCommandBuffer commandBuffer, uint32_t firstViewport,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003502 uint32_t viewportCount, const VkViewport *pViewports) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003503 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003504
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003505 if (!physical_device_features.multiViewport) {
Petr Krausd55e77c2018-01-09 22:09:25 +01003506 if (firstViewport != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003507 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewport-firstViewport-01224",
3508 "vkCmdSetViewport: The multiViewport feature is disabled, but firstViewport (=%" PRIu32 ") is not 0.",
3509 firstViewport);
Petr Krausd55e77c2018-01-09 22:09:25 +01003510 }
3511 if (viewportCount > 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003512 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewport-viewportCount-01225",
3513 "vkCmdSetViewport: The multiViewport feature is disabled, but viewportCount (=%" PRIu32 ") is not 1.",
3514 viewportCount);
Petr Krausd55e77c2018-01-09 22:09:25 +01003515 }
3516 } else { // multiViewport enabled
Petr Kraus7dfeed12018-02-27 20:51:20 +01003517 const uint64_t sum = static_cast<uint64_t>(firstViewport) + static_cast<uint64_t>(viewportCount);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003518 if (sum > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003519 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewport-firstViewport-01223",
3520 "vkCmdSetViewport: firstViewport + viewportCount (=%" PRIu32 " + %" PRIu32 " = %" PRIu64
3521 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
3522 firstViewport, viewportCount, sum, device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003523 }
3524 }
Petr Krausb3fcdb42018-01-09 22:09:09 +01003525
3526 if (pViewports) {
3527 for (uint32_t viewport_i = 0; viewport_i < viewportCount; ++viewport_i) {
3528 const auto &viewport = pViewports[viewport_i]; // will crash on invalid ptr
Jeff Bolz6d3beaa2019-02-09 21:00:05 -06003529 const char *fn_name = "vkCmdSetViewport";
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003530 skip |= manual_PreCallValidateViewport(
3531 viewport, fn_name, ParameterName("pViewports[%i]", ParameterName::IndexVector{viewport_i}), commandBuffer);
Petr Krausb3fcdb42018-01-09 22:09:09 +01003532 }
3533 }
3534
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003535 return skip;
3536}
3537
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003538bool StatelessValidation::manual_PreCallValidateCmdSetScissor(VkCommandBuffer commandBuffer, uint32_t firstScissor,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003539 uint32_t scissorCount, const VkRect2D *pScissors) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003540 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003541
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003542 if (!physical_device_features.multiViewport) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003543 if (firstScissor != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003544 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-firstScissor-00593",
3545 "vkCmdSetScissor: The multiViewport feature is disabled, but firstScissor (=%" PRIu32 ") is not 0.",
3546 firstScissor);
Petr Kraus6260f0a2018-02-27 21:15:55 +01003547 }
3548 if (scissorCount > 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003549 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-scissorCount-00594",
3550 "vkCmdSetScissor: The multiViewport feature is disabled, but scissorCount (=%" PRIu32 ") is not 1.",
3551 scissorCount);
Petr Kraus6260f0a2018-02-27 21:15:55 +01003552 }
3553 } else { // multiViewport enabled
3554 const uint64_t sum = static_cast<uint64_t>(firstScissor) + static_cast<uint64_t>(scissorCount);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003555 if (sum > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003556 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-firstScissor-00592",
3557 "vkCmdSetScissor: firstScissor + scissorCount (=%" PRIu32 " + %" PRIu32 " = %" PRIu64
3558 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
3559 firstScissor, scissorCount, sum, device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003560 }
3561 }
3562
Petr Kraus6260f0a2018-02-27 21:15:55 +01003563 if (pScissors) {
3564 for (uint32_t scissor_i = 0; scissor_i < scissorCount; ++scissor_i) {
3565 const auto &scissor = pScissors[scissor_i]; // will crash on invalid ptr
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003566
Petr Kraus6260f0a2018-02-27 21:15:55 +01003567 if (scissor.offset.x < 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003568 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-x-00595",
3569 "vkCmdSetScissor: pScissors[%" PRIu32 "].offset.x (=%" PRIi32 ") is negative.", scissor_i,
3570 scissor.offset.x);
Petr Kraus6260f0a2018-02-27 21:15:55 +01003571 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003572
Petr Kraus6260f0a2018-02-27 21:15:55 +01003573 if (scissor.offset.y < 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003574 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-x-00595",
3575 "vkCmdSetScissor: pScissors[%" PRIu32 "].offset.y (=%" PRIi32 ") is negative.", scissor_i,
3576 scissor.offset.y);
Petr Kraus6260f0a2018-02-27 21:15:55 +01003577 }
3578
3579 const int64_t x_sum = static_cast<int64_t>(scissor.offset.x) + static_cast<int64_t>(scissor.extent.width);
3580 if (x_sum > INT32_MAX) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003581 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-offset-00596",
3582 "vkCmdSetScissor: offset.x + extent.width (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
3583 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
3584 scissor.offset.x, scissor.extent.width, x_sum, scissor_i);
Petr Kraus6260f0a2018-02-27 21:15:55 +01003585 }
3586
3587 const int64_t y_sum = static_cast<int64_t>(scissor.offset.y) + static_cast<int64_t>(scissor.extent.height);
3588 if (y_sum > INT32_MAX) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003589 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-offset-00597",
3590 "vkCmdSetScissor: offset.y + extent.height (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
3591 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
3592 scissor.offset.y, scissor.extent.height, y_sum, scissor_i);
Petr Kraus6260f0a2018-02-27 21:15:55 +01003593 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003594 }
3595 }
Petr Kraus6260f0a2018-02-27 21:15:55 +01003596
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003597 return skip;
3598}
3599
Jeff Bolz5c801d12019-10-09 10:38:45 -05003600bool StatelessValidation::manual_PreCallValidateCmdSetLineWidth(VkCommandBuffer commandBuffer, float lineWidth) const {
Petr Kraus299ba622017-11-24 03:09:03 +01003601 bool skip = false;
Petr Kraus299ba622017-11-24 03:09:03 +01003602
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003603 if (!physical_device_features.wideLines && (lineWidth != 1.0f)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003604 skip |= LogError(commandBuffer, "VUID-vkCmdSetLineWidth-lineWidth-00788",
3605 "VkPhysicalDeviceFeatures::wideLines is disabled, but lineWidth (=%f) is not 1.0.", lineWidth);
Petr Kraus299ba622017-11-24 03:09:03 +01003606 }
3607
3608 return skip;
3609}
3610
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003611bool StatelessValidation::manual_PreCallValidateCmdDrawIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset,
Tony-LunarGc0c3df52020-11-20 13:47:10 -07003612 uint32_t drawCount, uint32_t stride) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003613 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003614
Tony-LunarGc0c3df52020-11-20 13:47:10 -07003615 if (!physical_device_features.multiDrawIndirect && ((drawCount > 1))) {
Mark Lobodzinski41ce65b2020-10-30 12:17:06 -06003616 skip |= LogError(device, "VUID-vkCmdDrawIndirect-drawCount-02718",
Tony-LunarGc0c3df52020-11-20 13:47:10 -07003617 "CmdDrawIndirect(): Device feature multiDrawIndirect disabled: count must be 0 or 1 but is %d", drawCount);
3618 }
3619 if (drawCount > device_limits.maxDrawIndirectCount) {
3620 skip |= LogError(commandBuffer, "VUID-vkCmdDrawIndirect-drawCount-02719",
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003621 "CmdDrawIndirect(): drawCount (%u) is not less than or equal to the maximum allowed (%u).", drawCount,
3622 device_limits.maxDrawIndirectCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003623 }
3624 return skip;
3625}
3626
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003627bool StatelessValidation::manual_PreCallValidateCmdDrawIndexedIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer,
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003628 VkDeviceSize offset, uint32_t drawCount,
3629 uint32_t stride) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003630 bool skip = false;
Tony-LunarGc0c3df52020-11-20 13:47:10 -07003631 if (!physical_device_features.multiDrawIndirect && ((drawCount > 1))) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003632 skip |= LogError(device, "VUID-vkCmdDrawIndexedIndirect-drawCount-02718",
3633 "CmdDrawIndexedIndirect(): Device feature multiDrawIndirect disabled: count must be 0 or 1 but is %d",
3634 drawCount);
Tony-LunarGc0c3df52020-11-20 13:47:10 -07003635 }
3636 if (drawCount > device_limits.maxDrawIndirectCount) {
3637 skip |= LogError(commandBuffer, "VUID-vkCmdDrawIndexedIndirect-drawCount-02719",
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003638 "CmdDrawIndexedIndirect(): drawCount (%u) is not less than or equal to the maximum allowed (%u).",
3639 drawCount, device_limits.maxDrawIndirectCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003640 }
3641 return skip;
3642}
3643
sfricke-samsungf692b972020-05-02 08:00:45 -07003644bool StatelessValidation::ValidateCmdDrawIndirectCount(VkCommandBuffer commandBuffer, VkDeviceSize offset,
3645 VkDeviceSize countBufferOffset, bool khr) const {
3646 bool skip = false;
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003647 const char *api_name = khr ? "vkCmdDrawIndirectCountKHR()" : "vkCmdDrawIndirectCount()";
sfricke-samsungf692b972020-05-02 08:00:45 -07003648 if (offset & 3) {
3649 skip |= LogError(commandBuffer, "VUID-vkCmdDrawIndirectCount-offset-02710",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003650 "%s: parameter, VkDeviceSize offset (0x%" PRIxLEAST64 "), is not a multiple of 4.", api_name, offset);
sfricke-samsungf692b972020-05-02 08:00:45 -07003651 }
3652
3653 if (countBufferOffset & 3) {
3654 skip |= LogError(commandBuffer, "VUID-vkCmdDrawIndirectCount-countBufferOffset-02716",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003655 "%s: parameter, VkDeviceSize countBufferOffset (0x%" PRIxLEAST64 "), is not a multiple of 4.", api_name,
sfricke-samsungf692b972020-05-02 08:00:45 -07003656 countBufferOffset);
3657 }
3658 return skip;
3659}
3660
3661bool StatelessValidation::manual_PreCallValidateCmdDrawIndirectCount(VkCommandBuffer commandBuffer, VkBuffer buffer,
3662 VkDeviceSize offset, VkBuffer countBuffer,
3663 VkDeviceSize countBufferOffset, uint32_t maxDrawCount,
3664 uint32_t stride) const {
3665 return ValidateCmdDrawIndirectCount(commandBuffer, offset, countBufferOffset, false);
3666}
3667
3668bool StatelessValidation::manual_PreCallValidateCmdDrawIndirectCountKHR(VkCommandBuffer commandBuffer, VkBuffer buffer,
3669 VkDeviceSize offset, VkBuffer countBuffer,
3670 VkDeviceSize countBufferOffset, uint32_t maxDrawCount,
3671 uint32_t stride) const {
3672 return ValidateCmdDrawIndirectCount(commandBuffer, offset, countBufferOffset, true);
3673}
3674
3675bool StatelessValidation::ValidateCmdDrawIndexedIndirectCount(VkCommandBuffer commandBuffer, VkDeviceSize offset,
3676 VkDeviceSize countBufferOffset, bool khr) const {
3677 bool skip = false;
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003678 const char *api_name = khr ? "vkCmdDrawIndexedIndirectCountKHR()" : "vkCmdDrawIndexedIndirectCount()";
sfricke-samsungf692b972020-05-02 08:00:45 -07003679 if (offset & 3) {
3680 skip |= LogError(commandBuffer, "VUID-vkCmdDrawIndexedIndirectCount-offset-02710",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003681 "%s: parameter, VkDeviceSize offset (0x%" PRIxLEAST64 "), is not a multiple of 4.", api_name, offset);
sfricke-samsungf692b972020-05-02 08:00:45 -07003682 }
3683
3684 if (countBufferOffset & 3) {
3685 skip |= LogError(commandBuffer, "VUID-vkCmdDrawIndexedIndirectCount-countBufferOffset-02716",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003686 "%s: parameter, VkDeviceSize countBufferOffset (0x%" PRIxLEAST64 "), is not a multiple of 4.", api_name,
sfricke-samsungf692b972020-05-02 08:00:45 -07003687 countBufferOffset);
3688 }
3689 return skip;
3690}
3691
3692bool StatelessValidation::manual_PreCallValidateCmdDrawIndexedIndirectCount(VkCommandBuffer commandBuffer, VkBuffer buffer,
3693 VkDeviceSize offset, VkBuffer countBuffer,
3694 VkDeviceSize countBufferOffset, uint32_t maxDrawCount,
3695 uint32_t stride) const {
3696 return ValidateCmdDrawIndexedIndirectCount(commandBuffer, offset, countBufferOffset, false);
3697}
3698
3699bool StatelessValidation::manual_PreCallValidateCmdDrawIndexedIndirectCountKHR(VkCommandBuffer commandBuffer, VkBuffer buffer,
3700 VkDeviceSize offset, VkBuffer countBuffer,
3701 VkDeviceSize countBufferOffset,
3702 uint32_t maxDrawCount, uint32_t stride) const {
3703 return ValidateCmdDrawIndexedIndirectCount(commandBuffer, offset, countBufferOffset, true);
3704}
3705
Mark Lobodzinskif77a4ac2019-06-27 15:30:51 -06003706bool StatelessValidation::manual_PreCallValidateCmdClearAttachments(VkCommandBuffer commandBuffer, uint32_t attachmentCount,
3707 const VkClearAttachment *pAttachments, uint32_t rectCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003708 const VkClearRect *pRects) const {
Mark Lobodzinskif77a4ac2019-06-27 15:30:51 -06003709 bool skip = false;
3710 for (uint32_t rect = 0; rect < rectCount; rect++) {
3711 if (pRects[rect].layerCount == 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003712 skip |= LogError(commandBuffer, "VUID-vkCmdClearAttachments-layerCount-01934",
3713 "CmdClearAttachments(): pRects[%d].layerCount is zero.", rect);
Mark Lobodzinskif77a4ac2019-06-27 15:30:51 -06003714 }
sfricke-samsung10867682020-04-25 02:20:39 -07003715 if (pRects[rect].rect.extent.width == 0) {
3716 skip |= LogError(commandBuffer, "VUID-vkCmdClearAttachments-rect-02682",
3717 "CmdClearAttachments(): pRects[%d].rect.extent.width is zero.", rect);
3718 }
3719 if (pRects[rect].rect.extent.height == 0) {
3720 skip |= LogError(commandBuffer, "VUID-vkCmdClearAttachments-rect-02683",
3721 "CmdClearAttachments(): pRects[%d].rect.extent.height is zero.", rect);
3722 }
Mark Lobodzinskif77a4ac2019-06-27 15:30:51 -06003723 }
3724 return skip;
3725}
3726
Andrew Fobel3abeb992020-01-20 16:33:22 -05003727bool StatelessValidation::ValidateGetPhysicalDeviceImageFormatProperties2(VkPhysicalDevice physicalDevice,
3728 const VkPhysicalDeviceImageFormatInfo2 *pImageFormatInfo,
3729 VkImageFormatProperties2 *pImageFormatProperties,
3730 const char *apiName) const {
3731 bool skip = false;
3732
3733 if (pImageFormatInfo != nullptr) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003734 const auto image_stencil_struct = LvlFindInChain<VkImageStencilUsageCreateInfo>(pImageFormatInfo->pNext);
Andrew Fobel3abeb992020-01-20 16:33:22 -05003735 if (image_stencil_struct != nullptr) {
3736 if ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT) != 0) {
3737 VkImageUsageFlags legal_flags = (VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT | VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT);
3738 // No flags other than the legal attachment bits may be set
3739 legal_flags |= VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT;
3740 if ((image_stencil_struct->stencilUsage & ~legal_flags) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003741 skip |= LogError(physicalDevice, "VUID-VkImageStencilUsageCreateInfo-stencilUsage-02539",
3742 "%s(): in pNext chain, VkImageStencilUsageCreateInfo::stencilUsage "
3743 "includes VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT, it must not include bits other than "
3744 "VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT or VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT",
3745 apiName);
Andrew Fobel3abeb992020-01-20 16:33:22 -05003746 }
3747 }
3748 }
3749 }
3750
3751 return skip;
3752}
3753
3754bool StatelessValidation::manual_PreCallValidateGetPhysicalDeviceImageFormatProperties2(
3755 VkPhysicalDevice physicalDevice, const VkPhysicalDeviceImageFormatInfo2 *pImageFormatInfo,
3756 VkImageFormatProperties2 *pImageFormatProperties) const {
3757 return ValidateGetPhysicalDeviceImageFormatProperties2(physicalDevice, pImageFormatInfo, pImageFormatProperties,
3758 "vkGetPhysicalDeviceImageFormatProperties2");
3759}
3760
3761bool StatelessValidation::manual_PreCallValidateGetPhysicalDeviceImageFormatProperties2KHR(
3762 VkPhysicalDevice physicalDevice, const VkPhysicalDeviceImageFormatInfo2 *pImageFormatInfo,
3763 VkImageFormatProperties2 *pImageFormatProperties) const {
3764 return ValidateGetPhysicalDeviceImageFormatProperties2(physicalDevice, pImageFormatInfo, pImageFormatProperties,
3765 "vkGetPhysicalDeviceImageFormatProperties2KHR");
3766}
3767
Lionel Landwerlin5fe52752020-07-22 08:18:14 +03003768bool StatelessValidation::manual_PreCallValidateGetPhysicalDeviceImageFormatProperties(
3769 VkPhysicalDevice physicalDevice, VkFormat format, VkImageType type, VkImageTiling tiling, VkImageUsageFlags usage,
3770 VkImageCreateFlags flags, VkImageFormatProperties *pImageFormatProperties) const {
3771 bool skip = false;
3772
3773 if (tiling == VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT) {
3774 skip |= LogError(physicalDevice, "VUID-vkGetPhysicalDeviceImageFormatProperties-tiling-02248",
3775 "vkGetPhysicalDeviceImageFormatProperties(): tiling must not be VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT.");
3776 }
3777
3778 return skip;
3779}
3780
sfricke-samsung3999ef62020-02-09 17:05:59 -08003781bool StatelessValidation::manual_PreCallValidateCmdCopyBuffer(VkCommandBuffer commandBuffer, VkBuffer srcBuffer, VkBuffer dstBuffer,
3782 uint32_t regionCount, const VkBufferCopy *pRegions) const {
3783 bool skip = false;
3784
3785 if (pRegions != nullptr) {
3786 for (uint32_t i = 0; i < regionCount; i++) {
3787 if (pRegions[i].size == 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003788 skip |= LogError(device, "VUID-VkBufferCopy-size-01988",
3789 "vkCmdCopyBuffer() pRegions[%u].size must be greater than zero", i);
sfricke-samsung3999ef62020-02-09 17:05:59 -08003790 }
3791 }
3792 }
3793 return skip;
3794}
3795
Jeff Leger178b1e52020-10-05 12:22:23 -04003796bool StatelessValidation::manual_PreCallValidateCmdCopyBuffer2KHR(VkCommandBuffer commandBuffer,
3797 const VkCopyBufferInfo2KHR *pCopyBufferInfo) const {
3798 bool skip = false;
3799
3800 if (pCopyBufferInfo->pRegions != nullptr) {
3801 for (uint32_t i = 0; i < pCopyBufferInfo->regionCount; i++) {
3802 if (pCopyBufferInfo->pRegions[i].size == 0) {
3803 skip |= LogError(device, "VUID-VkBufferCopy2KHR-size-01988",
3804 "vkCmdCopyBuffer2KHR() pCopyBufferInfo->pRegions[%u].size must be greater than zero", i);
3805 }
3806 }
3807 }
3808 return skip;
3809}
3810
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003811bool StatelessValidation::manual_PreCallValidateCmdUpdateBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003812 VkDeviceSize dstOffset, VkDeviceSize dataSize,
3813 const void *pData) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003814 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003815
3816 if (dstOffset & 3) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003817 skip |= LogError(device, "VUID-vkCmdUpdateBuffer-dstOffset-00036",
3818 "vkCmdUpdateBuffer() parameter, VkDeviceSize dstOffset (0x%" PRIxLEAST64 "), is not a multiple of 4.",
3819 dstOffset);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003820 }
3821
3822 if ((dataSize <= 0) || (dataSize > 65536)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003823 skip |= LogError(device, "VUID-vkCmdUpdateBuffer-dataSize-00037",
3824 "vkCmdUpdateBuffer() parameter, VkDeviceSize dataSize (0x%" PRIxLEAST64
3825 "), must be greater than zero and less than or equal to 65536.",
3826 dataSize);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003827 } else if (dataSize & 3) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003828 skip |= LogError(device, "VUID-vkCmdUpdateBuffer-dataSize-00038",
3829 "vkCmdUpdateBuffer() parameter, VkDeviceSize dataSize (0x%" PRIxLEAST64 "), is not a multiple of 4.",
3830 dataSize);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003831 }
3832 return skip;
3833}
3834
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003835bool StatelessValidation::manual_PreCallValidateCmdFillBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003836 VkDeviceSize dstOffset, VkDeviceSize size, uint32_t data) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003837 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003838
3839 if (dstOffset & 3) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003840 skip |= LogError(device, "VUID-vkCmdFillBuffer-dstOffset-00025",
3841 "vkCmdFillBuffer() parameter, VkDeviceSize dstOffset (0x%" PRIxLEAST64 "), is not a multiple of 4.",
3842 dstOffset);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003843 }
3844
3845 if (size != VK_WHOLE_SIZE) {
3846 if (size <= 0) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003847 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003848 LogError(device, "VUID-vkCmdFillBuffer-size-00026",
3849 "vkCmdFillBuffer() parameter, VkDeviceSize size (0x%" PRIxLEAST64 "), must be greater than zero.", size);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003850 } else if (size & 3) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003851 skip |= LogError(device, "VUID-vkCmdFillBuffer-size-00028",
3852 "vkCmdFillBuffer() parameter, VkDeviceSize size (0x%" PRIxLEAST64 "), is not a multiple of 4.", size);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003853 }
3854 }
3855 return skip;
3856}
3857
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003858bool StatelessValidation::manual_PreCallValidateCreateSwapchainKHR(VkDevice device, const VkSwapchainCreateInfoKHR *pCreateInfo,
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003859 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003860 VkSwapchainKHR *pSwapchain) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003861 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003862
3863 if (pCreateInfo != nullptr) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003864 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
3865 if (pCreateInfo->imageSharingMode == VK_SHARING_MODE_CONCURRENT) {
3866 // If imageSharingMode is VK_SHARING_MODE_CONCURRENT, queueFamilyIndexCount must be greater than 1
3867 if (pCreateInfo->queueFamilyIndexCount <= 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003868 skip |= LogError(device, "VUID-VkSwapchainCreateInfoKHR-imageSharingMode-01278",
3869 "vkCreateSwapchainKHR(): if pCreateInfo->imageSharingMode is VK_SHARING_MODE_CONCURRENT, "
3870 "pCreateInfo->queueFamilyIndexCount must be greater than 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003871 }
3872
3873 // If imageSharingMode is VK_SHARING_MODE_CONCURRENT, pQueueFamilyIndices must be a pointer to an array of
3874 // queueFamilyIndexCount uint32_t values
3875 if (pCreateInfo->pQueueFamilyIndices == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003876 skip |= LogError(device, "VUID-VkSwapchainCreateInfoKHR-imageSharingMode-01277",
3877 "vkCreateSwapchainKHR(): if pCreateInfo->imageSharingMode is VK_SHARING_MODE_CONCURRENT, "
3878 "pCreateInfo->pQueueFamilyIndices must be a pointer to an array of "
3879 "pCreateInfo->queueFamilyIndexCount uint32_t values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003880 }
3881 }
3882
Dave Houlton413a6782018-05-22 13:01:54 -06003883 skip |= ValidateGreaterThanZero(pCreateInfo->imageArrayLayers, "pCreateInfo->imageArrayLayers",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003884 "VUID-VkSwapchainCreateInfoKHR-imageArrayLayers-01275", "vkCreateSwapchainKHR");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003885 }
3886
3887 return skip;
3888}
3889
Jeff Bolz5c801d12019-10-09 10:38:45 -05003890bool StatelessValidation::manual_PreCallValidateQueuePresentKHR(VkQueue queue, const VkPresentInfoKHR *pPresentInfo) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003891 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003892
3893 if (pPresentInfo && pPresentInfo->pNext) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003894 const auto *present_regions = LvlFindInChain<VkPresentRegionsKHR>(pPresentInfo->pNext);
John Zulaufde972ac2017-10-26 12:07:05 -06003895 if (present_regions) {
3896 // TODO: This and all other pNext extension dependencies should be added to code-generation
Tony-LunarG2ec96bb2019-11-26 13:43:02 -07003897 skip |= require_device_extension(IsExtEnabled(device_extensions.vk_khr_incremental_present), "vkQueuePresentKHR",
John Zulaufde972ac2017-10-26 12:07:05 -06003898 VK_KHR_INCREMENTAL_PRESENT_EXTENSION_NAME);
3899 if (present_regions->swapchainCount != pPresentInfo->swapchainCount) {
sfricke-samsunga4cc4ff2020-08-23 22:05:49 -07003900 skip |= LogError(device, "VUID-VkPresentRegionsKHR-swapchainCount-01260",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003901 "QueuePresentKHR(): pPresentInfo->swapchainCount has a value of %i but VkPresentRegionsKHR "
3902 "extension swapchainCount is %i. These values must be equal.",
3903 pPresentInfo->swapchainCount, present_regions->swapchainCount);
John Zulaufde972ac2017-10-26 12:07:05 -06003904 }
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003905 skip |= validate_struct_pnext("QueuePresentKHR", "pCreateInfo->pNext->pNext", NULL, present_regions->pNext, 0, NULL,
sfricke-samsung32a27362020-02-28 09:06:42 -08003906 GeneratedVulkanHeaderVersion, "VUID-VkPresentInfoKHR-pNext-pNext",
3907 "VUID-VkPresentInfoKHR-sType-unique");
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003908 skip |= validate_array("QueuePresentKHR", "pCreateInfo->pNext->swapchainCount", "pCreateInfo->pNext->pRegions",
3909 present_regions->swapchainCount, &present_regions->pRegions, true, false, kVUIDUndefined,
3910 kVUIDUndefined);
John Zulaufde972ac2017-10-26 12:07:05 -06003911 for (uint32_t i = 0; i < present_regions->swapchainCount; ++i) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003912 skip |= validate_array("QueuePresentKHR", "pCreateInfo->pNext->pRegions[].rectangleCount",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003913 "pCreateInfo->pNext->pRegions[].pRectangles", present_regions->pRegions[i].rectangleCount,
Dave Houlton413a6782018-05-22 13:01:54 -06003914 &present_regions->pRegions[i].pRectangles, true, false, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003915 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003916 }
3917 }
3918
3919 return skip;
3920}
3921
sfricke-samsung5c1b7392020-12-13 22:17:15 -08003922bool StatelessValidation::manual_PreCallValidateCreateDisplayModeKHR(VkPhysicalDevice physicalDevice, VkDisplayKHR display,
3923 const VkDisplayModeCreateInfoKHR *pCreateInfo,
3924 const VkAllocationCallbacks *pAllocator,
3925 VkDisplayModeKHR *pMode) const {
3926 bool skip = false;
3927
3928 const VkDisplayModeParametersKHR display_mode_parameters = pCreateInfo->parameters;
3929 if (display_mode_parameters.visibleRegion.width == 0) {
3930 skip |= LogError(device, "VUID-VkDisplayModeParametersKHR-width-01990",
3931 "vkCreateDisplayModeKHR(): pCreateInfo->parameters.visibleRegion.width must be greater than 0.");
3932 }
3933 if (display_mode_parameters.visibleRegion.height == 0) {
3934 skip |= LogError(device, "VUID-VkDisplayModeParametersKHR-height-01991",
3935 "vkCreateDisplayModeKHR(): pCreateInfo->parameters.visibleRegion.height must be greater than 0.");
3936 }
3937 if (display_mode_parameters.refreshRate == 0) {
3938 skip |= LogError(device, "VUID-VkDisplayModeParametersKHR-refreshRate-01992",
3939 "vkCreateDisplayModeKHR(): pCreateInfo->parameters.refreshRate must be greater than 0.");
3940 }
3941
3942 return skip;
3943}
3944
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003945#ifdef VK_USE_PLATFORM_WIN32_KHR
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003946bool StatelessValidation::manual_PreCallValidateCreateWin32SurfaceKHR(VkInstance instance,
3947 const VkWin32SurfaceCreateInfoKHR *pCreateInfo,
3948 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003949 VkSurfaceKHR *pSurface) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003950 bool skip = false;
3951
3952 if (pCreateInfo->hwnd == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003953 skip |= LogError(device, "VUID-VkWin32SurfaceCreateInfoKHR-hwnd-01308",
3954 "vkCreateWin32SurfaceKHR(): hwnd must be a valid Win32 HWND but hwnd is NULL.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003955 }
3956
3957 return skip;
3958}
3959#endif // VK_USE_PLATFORM_WIN32_KHR
3960
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003961bool StatelessValidation::manual_PreCallValidateCreateDescriptorPool(VkDevice device, const VkDescriptorPoolCreateInfo *pCreateInfo,
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003962 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003963 VkDescriptorPool *pDescriptorPool) const {
Petr Krausc8655be2017-09-27 18:56:51 +02003964 bool skip = false;
3965
3966 if (pCreateInfo) {
3967 if (pCreateInfo->maxSets <= 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003968 skip |= LogError(device, "VUID-VkDescriptorPoolCreateInfo-maxSets-00301",
3969 "vkCreateDescriptorPool(): pCreateInfo->maxSets is not greater than 0.");
Petr Krausc8655be2017-09-27 18:56:51 +02003970 }
3971
3972 if (pCreateInfo->pPoolSizes) {
3973 for (uint32_t i = 0; i < pCreateInfo->poolSizeCount; ++i) {
3974 if (pCreateInfo->pPoolSizes[i].descriptorCount <= 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003975 skip |= LogError(
3976 device, "VUID-VkDescriptorPoolSize-descriptorCount-00302",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003977 "vkCreateDescriptorPool(): pCreateInfo->pPoolSizes[%" PRIu32 "].descriptorCount is not greater than 0.", i);
Petr Krausc8655be2017-09-27 18:56:51 +02003978 }
Jeff Bolze54ae892018-09-08 12:16:29 -05003979 if (pCreateInfo->pPoolSizes[i].type == VK_DESCRIPTOR_TYPE_INLINE_UNIFORM_BLOCK_EXT &&
3980 (pCreateInfo->pPoolSizes[i].descriptorCount % 4) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003981 skip |= LogError(device, "VUID-VkDescriptorPoolSize-type-02218",
3982 "vkCreateDescriptorPool(): pCreateInfo->pPoolSizes[%" PRIu32
3983 "].type is VK_DESCRIPTOR_TYPE_INLINE_UNIFORM_BLOCK_EXT "
3984 " and pCreateInfo->pPoolSizes[%" PRIu32 "].descriptorCount is not a multiple of 4.",
3985 i, i);
Jeff Bolze54ae892018-09-08 12:16:29 -05003986 }
Petr Krausc8655be2017-09-27 18:56:51 +02003987 }
3988 }
3989 }
3990
3991 return skip;
3992}
3993
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003994bool StatelessValidation::manual_PreCallValidateCmdDispatch(VkCommandBuffer commandBuffer, uint32_t groupCountX,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003995 uint32_t groupCountY, uint32_t groupCountZ) const {
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003996 bool skip = false;
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003997
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003998 if (groupCountX > device_limits.maxComputeWorkGroupCount[0]) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003999 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004000 LogError(commandBuffer, "VUID-vkCmdDispatch-groupCountX-00386",
4001 "vkCmdDispatch(): groupCountX (%" PRIu32 ") exceeds device limit maxComputeWorkGroupCount[0] (%" PRIu32 ").",
4002 groupCountX, device_limits.maxComputeWorkGroupCount[0]);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07004003 }
4004
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004005 if (groupCountY > device_limits.maxComputeWorkGroupCount[1]) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06004006 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004007 LogError(commandBuffer, "VUID-vkCmdDispatch-groupCountY-00387",
4008 "vkCmdDispatch(): groupCountY (%" PRIu32 ") exceeds device limit maxComputeWorkGroupCount[1] (%" PRIu32 ").",
4009 groupCountY, device_limits.maxComputeWorkGroupCount[1]);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07004010 }
4011
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004012 if (groupCountZ > device_limits.maxComputeWorkGroupCount[2]) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06004013 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004014 LogError(commandBuffer, "VUID-vkCmdDispatch-groupCountZ-00388",
4015 "vkCmdDispatch(): groupCountZ (%" PRIu32 ") exceeds device limit maxComputeWorkGroupCount[2] (%" PRIu32 ").",
4016 groupCountZ, device_limits.maxComputeWorkGroupCount[2]);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07004017 }
4018
4019 return skip;
4020}
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004021
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004022bool StatelessValidation::manual_PreCallValidateCmdDispatchIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004023 VkDeviceSize offset) const {
John Zulaufa999d1b2018-11-29 13:38:40 -07004024 bool skip = false;
John Zulaufa999d1b2018-11-29 13:38:40 -07004025
4026 if ((offset % 4) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004027 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchIndirect-offset-02710",
4028 "vkCmdDispatchIndirect(): offset (%" PRIu64 ") must be a multiple of 4.", offset);
John Zulaufa999d1b2018-11-29 13:38:40 -07004029 }
4030 return skip;
4031}
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07004032
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004033bool StatelessValidation::manual_PreCallValidateCmdDispatchBaseKHR(VkCommandBuffer commandBuffer, uint32_t baseGroupX,
4034 uint32_t baseGroupY, uint32_t baseGroupZ, uint32_t groupCountX,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004035 uint32_t groupCountY, uint32_t groupCountZ) const {
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07004036 bool skip = false;
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07004037
4038 // Paired if {} else if {} tests used to avoid any possible uint underflow
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004039 uint32_t limit = device_limits.maxComputeWorkGroupCount[0];
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07004040 if (baseGroupX >= limit) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004041 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchBase-baseGroupX-00421",
4042 "vkCmdDispatch(): baseGroupX (%" PRIu32
4043 ") equals or exceeds device limit maxComputeWorkGroupCount[0] (%" PRIu32 ").",
4044 baseGroupX, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07004045 } else if (groupCountX > (limit - baseGroupX)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004046 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchBase-groupCountX-00424",
4047 "vkCmdDispatchBaseKHR(): baseGroupX (%" PRIu32 ") + groupCountX (%" PRIu32
4048 ") exceeds device limit maxComputeWorkGroupCount[0] (%" PRIu32 ").",
4049 baseGroupX, groupCountX, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07004050 }
4051
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004052 limit = device_limits.maxComputeWorkGroupCount[1];
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07004053 if (baseGroupY >= limit) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004054 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchBase-baseGroupX-00422",
4055 "vkCmdDispatch(): baseGroupY (%" PRIu32
4056 ") equals or exceeds device limit maxComputeWorkGroupCount[1] (%" PRIu32 ").",
4057 baseGroupY, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07004058 } else if (groupCountY > (limit - baseGroupY)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004059 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchBase-groupCountY-00425",
4060 "vkCmdDispatchBaseKHR(): baseGroupY (%" PRIu32 ") + groupCountY (%" PRIu32
4061 ") exceeds device limit maxComputeWorkGroupCount[1] (%" PRIu32 ").",
4062 baseGroupY, groupCountY, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07004063 }
4064
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004065 limit = device_limits.maxComputeWorkGroupCount[2];
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07004066 if (baseGroupZ >= limit) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004067 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchBase-baseGroupZ-00423",
4068 "vkCmdDispatch(): baseGroupZ (%" PRIu32
4069 ") equals or exceeds device limit maxComputeWorkGroupCount[2] (%" PRIu32 ").",
4070 baseGroupZ, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07004071 } else if (groupCountZ > (limit - baseGroupZ)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004072 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchBase-groupCountZ-00426",
4073 "vkCmdDispatchBaseKHR(): baseGroupZ (%" PRIu32 ") + groupCountZ (%" PRIu32
4074 ") exceeds device limit maxComputeWorkGroupCount[2] (%" PRIu32 ").",
4075 baseGroupZ, groupCountZ, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07004076 }
4077
4078 return skip;
4079}
4080
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07004081bool StatelessValidation::manual_PreCallValidateCmdPushDescriptorSetKHR(VkCommandBuffer commandBuffer,
4082 VkPipelineBindPoint pipelineBindPoint,
4083 VkPipelineLayout layout, uint32_t set,
4084 uint32_t descriptorWriteCount,
4085 const VkWriteDescriptorSet *pDescriptorWrites) const {
4086 return validate_WriteDescriptorSet("vkCmdPushDescriptorSetKHR", descriptorWriteCount, pDescriptorWrites, false);
4087}
4088
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004089bool StatelessValidation::manual_PreCallValidateCmdSetExclusiveScissorNV(VkCommandBuffer commandBuffer,
4090 uint32_t firstExclusiveScissor,
4091 uint32_t exclusiveScissorCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004092 const VkRect2D *pExclusiveScissors) const {
Jeff Bolz3e71f782018-08-29 23:15:45 -05004093 bool skip = false;
4094
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004095 if (!physical_device_features.multiViewport) {
Jeff Bolz3e71f782018-08-29 23:15:45 -05004096 if (firstExclusiveScissor != 0) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06004097 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004098 LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-firstExclusiveScissor-02035",
4099 "vkCmdSetExclusiveScissorNV: The multiViewport feature is disabled, but firstExclusiveScissor (=%" PRIu32
4100 ") is not 0.",
4101 firstExclusiveScissor);
Jeff Bolz3e71f782018-08-29 23:15:45 -05004102 }
4103 if (exclusiveScissorCount > 1) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06004104 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004105 LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-exclusiveScissorCount-02036",
4106 "vkCmdSetExclusiveScissorNV: The multiViewport feature is disabled, but exclusiveScissorCount (=%" PRIu32
4107 ") is not 1.",
4108 exclusiveScissorCount);
Jeff Bolz3e71f782018-08-29 23:15:45 -05004109 }
4110 } else { // multiViewport enabled
4111 const uint64_t sum = static_cast<uint64_t>(firstExclusiveScissor) + static_cast<uint64_t>(exclusiveScissorCount);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004112 if (sum > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004113 skip |= LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-firstExclusiveScissor-02034",
4114 "vkCmdSetExclusiveScissorNV: firstExclusiveScissor + exclusiveScissorCount (=%" PRIu32 " + %" PRIu32
4115 " = %" PRIu64 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
4116 firstExclusiveScissor, exclusiveScissorCount, sum, device_limits.maxViewports);
Jeff Bolz3e71f782018-08-29 23:15:45 -05004117 }
4118 }
4119
Jeff Bolz3e71f782018-08-29 23:15:45 -05004120 if (pExclusiveScissors) {
4121 for (uint32_t scissor_i = 0; scissor_i < exclusiveScissorCount; ++scissor_i) {
4122 const auto &scissor = pExclusiveScissors[scissor_i]; // will crash on invalid ptr
4123
4124 if (scissor.offset.x < 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004125 skip |= LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-x-02037",
4126 "vkCmdSetExclusiveScissorNV: pScissors[%" PRIu32 "].offset.x (=%" PRIi32 ") is negative.",
4127 scissor_i, scissor.offset.x);
Jeff Bolz3e71f782018-08-29 23:15:45 -05004128 }
4129
4130 if (scissor.offset.y < 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004131 skip |= LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-x-02037",
4132 "vkCmdSetExclusiveScissorNV: pScissors[%" PRIu32 "].offset.y (=%" PRIi32 ") is negative.",
4133 scissor_i, scissor.offset.y);
Jeff Bolz3e71f782018-08-29 23:15:45 -05004134 }
4135
4136 const int64_t x_sum = static_cast<int64_t>(scissor.offset.x) + static_cast<int64_t>(scissor.extent.width);
4137 if (x_sum > INT32_MAX) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004138 skip |= LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-offset-02038",
4139 "vkCmdSetExclusiveScissorNV: offset.x + extent.width (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
4140 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
4141 scissor.offset.x, scissor.extent.width, x_sum, scissor_i);
Jeff Bolz3e71f782018-08-29 23:15:45 -05004142 }
4143
4144 const int64_t y_sum = static_cast<int64_t>(scissor.offset.y) + static_cast<int64_t>(scissor.extent.height);
4145 if (y_sum > INT32_MAX) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004146 skip |= LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-offset-02039",
4147 "vkCmdSetExclusiveScissorNV: offset.y + extent.height (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
4148 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
4149 scissor.offset.y, scissor.extent.height, y_sum, scissor_i);
Jeff Bolz3e71f782018-08-29 23:15:45 -05004150 }
4151 }
4152 }
4153
4154 return skip;
4155}
4156
Chris Mayer9ded5eb2019-09-19 16:33:26 +02004157bool StatelessValidation::manual_PreCallValidateCmdSetViewportWScalingNV(VkCommandBuffer commandBuffer, uint32_t firstViewport,
4158 uint32_t viewportCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004159 const VkViewportWScalingNV *pViewportWScalings) const {
Chris Mayer9ded5eb2019-09-19 16:33:26 +02004160 bool skip = false;
Shannon McPherson169d0c72020-11-13 18:48:19 -07004161 const uint64_t sum = static_cast<uint64_t>(firstViewport) + static_cast<uint64_t>(viewportCount);
4162 if ((sum < 1) || (sum > device_limits.maxViewports)) {
4163 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewportWScalingNV-firstViewport-01324",
4164 "vkCmdSetViewportWScalingNV: firstViewport + viewportCount (=%" PRIu32 " + %" PRIu32 " = %" PRIu64
4165 ") must be between 1 and VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 "), inculsive.",
4166 firstViewport, viewportCount, sum, device_limits.maxViewports);
Chris Mayer9ded5eb2019-09-19 16:33:26 +02004167 }
4168
4169 return skip;
4170}
4171
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004172bool StatelessValidation::manual_PreCallValidateCmdSetViewportShadingRatePaletteNV(
4173 VkCommandBuffer commandBuffer, uint32_t firstViewport, uint32_t viewportCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004174 const VkShadingRatePaletteNV *pShadingRatePalettes) const {
Jeff Bolz9af91c52018-09-01 21:53:57 -05004175 bool skip = false;
4176
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004177 if (!physical_device_features.multiViewport) {
Jeff Bolz9af91c52018-09-01 21:53:57 -05004178 if (firstViewport != 0) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06004179 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004180 LogError(commandBuffer, "VUID-vkCmdSetViewportShadingRatePaletteNV-firstViewport-02068",
4181 "vkCmdSetViewportShadingRatePaletteNV: The multiViewport feature is disabled, but firstViewport (=%" PRIu32
4182 ") is not 0.",
4183 firstViewport);
Jeff Bolz9af91c52018-09-01 21:53:57 -05004184 }
4185 if (viewportCount > 1) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06004186 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004187 LogError(commandBuffer, "VUID-vkCmdSetViewportShadingRatePaletteNV-viewportCount-02069",
4188 "vkCmdSetViewportShadingRatePaletteNV: The multiViewport feature is disabled, but viewportCount (=%" PRIu32
4189 ") is not 1.",
4190 viewportCount);
Jeff Bolz9af91c52018-09-01 21:53:57 -05004191 }
4192 }
4193
Jeff Bolz9af91c52018-09-01 21:53:57 -05004194 const uint64_t sum = static_cast<uint64_t>(firstViewport) + static_cast<uint64_t>(viewportCount);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004195 if (sum > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004196 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewportShadingRatePaletteNV-firstViewport-02067",
4197 "vkCmdSetViewportShadingRatePaletteNV: firstViewport + viewportCount (=%" PRIu32 " + %" PRIu32
4198 " = %" PRIu64 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
4199 firstViewport, viewportCount, sum, device_limits.maxViewports);
Jeff Bolz9af91c52018-09-01 21:53:57 -05004200 }
4201
4202 return skip;
4203}
4204
Jeff Bolz5c801d12019-10-09 10:38:45 -05004205bool StatelessValidation::manual_PreCallValidateCmdSetCoarseSampleOrderNV(
4206 VkCommandBuffer commandBuffer, VkCoarseSampleOrderTypeNV sampleOrderType, uint32_t customSampleOrderCount,
4207 const VkCoarseSampleOrderCustomNV *pCustomSampleOrders) const {
Jeff Bolz9af91c52018-09-01 21:53:57 -05004208 bool skip = false;
4209
Dave Houlton142c4cb2018-10-17 15:04:41 -06004210 if (sampleOrderType != VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV && customSampleOrderCount != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004211 skip |= LogError(commandBuffer, "VUID-vkCmdSetCoarseSampleOrderNV-sampleOrderType-02081",
4212 "vkCmdSetCoarseSampleOrderNV: If sampleOrderType is not VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV, "
4213 "customSampleOrderCount must be 0.");
Jeff Bolz9af91c52018-09-01 21:53:57 -05004214 }
4215
4216 for (uint32_t order_i = 0; order_i < customSampleOrderCount; ++order_i) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004217 skip |= ValidateCoarseSampleOrderCustomNV(&pCustomSampleOrders[order_i]);
Jeff Bolz9af91c52018-09-01 21:53:57 -05004218 }
4219
4220 return skip;
4221}
4222
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004223bool StatelessValidation::manual_PreCallValidateCmdDrawMeshTasksNV(VkCommandBuffer commandBuffer, uint32_t taskCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004224 uint32_t firstTask) const {
Jeff Bolz45bf7d62018-09-18 15:39:58 -05004225 bool skip = false;
4226
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004227 if (taskCount > phys_dev_ext_props.mesh_shader_props.maxDrawMeshTasksCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004228 skip |= LogError(
4229 commandBuffer, "VUID-vkCmdDrawMeshTasksNV-taskCount-02119",
Dave Houlton142c4cb2018-10-17 15:04:41 -06004230 "vkCmdDrawMeshTasksNV() parameter, uint32_t taskCount (0x%" PRIxLEAST32
4231 "), must be less than or equal to VkPhysicalDeviceMeshShaderPropertiesNV::maxDrawMeshTasksCount (0x%" PRIxLEAST32 ").",
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004232 taskCount, phys_dev_ext_props.mesh_shader_props.maxDrawMeshTasksCount);
Jeff Bolz45bf7d62018-09-18 15:39:58 -05004233 }
4234
4235 return skip;
4236}
4237
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004238bool StatelessValidation::manual_PreCallValidateCmdDrawMeshTasksIndirectNV(VkCommandBuffer commandBuffer, VkBuffer buffer,
4239 VkDeviceSize offset, uint32_t drawCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004240 uint32_t stride) const {
Jeff Bolz45bf7d62018-09-18 15:39:58 -05004241 bool skip = false;
Lockee1c22882019-06-10 16:02:54 -06004242 static const int condition_multiples = 0b0011;
4243 if (offset & condition_multiples) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004244 skip |= LogError(
4245 commandBuffer, "VUID-vkCmdDrawMeshTasksIndirectNV-offset-02710",
Dave Houlton142c4cb2018-10-17 15:04:41 -06004246 "vkCmdDrawMeshTasksIndirectNV() parameter, VkDeviceSize offset (0x%" PRIxLEAST64 "), is not a multiple of 4.", offset);
Jeff Bolz45bf7d62018-09-18 15:39:58 -05004247 }
Lockee1c22882019-06-10 16:02:54 -06004248 if (drawCount > 1 && ((stride & condition_multiples) || stride < sizeof(VkDrawMeshTasksIndirectCommandNV))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004249 skip |= LogError(commandBuffer, "VUID-vkCmdDrawMeshTasksIndirectNV-drawCount-02146",
4250 "vkCmdDrawMeshTasksIndirectNV() parameter, uint32_t stride (0x%" PRIxLEAST32
4251 "), is not a multiple of 4 or smaller than sizeof (VkDrawMeshTasksIndirectCommandNV).",
4252 stride);
Lockee1c22882019-06-10 16:02:54 -06004253 }
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004254 if (!physical_device_features.multiDrawIndirect && ((drawCount > 1))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004255 skip |= LogError(
4256 commandBuffer, "VUID-vkCmdDrawMeshTasksIndirectNV-drawCount-02718",
4257 "vkCmdDrawMeshTasksIndirectNV(): Device feature multiDrawIndirect disabled: count must be 0 or 1 but is %d", drawCount);
Jeff Bolzb574c342018-11-08 15:36:57 -06004258 }
Tony-LunarGc0c3df52020-11-20 13:47:10 -07004259 if (drawCount > device_limits.maxDrawIndirectCount) {
4260 skip |= LogError(commandBuffer, "VUID-vkCmdDrawMeshTasksIndirectNV-drawCount-02719",
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004261 "vkCmdDrawMeshTasksIndirectNV: drawCount (%u) is not less than or equal to the maximum allowed (%u).",
4262 drawCount, device_limits.maxDrawIndirectCount);
Tony-LunarGc0c3df52020-11-20 13:47:10 -07004263 }
Jeff Bolz45bf7d62018-09-18 15:39:58 -05004264 return skip;
4265}
4266
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004267bool StatelessValidation::manual_PreCallValidateCmdDrawMeshTasksIndirectCountNV(VkCommandBuffer commandBuffer, VkBuffer buffer,
4268 VkDeviceSize offset, VkBuffer countBuffer,
4269 VkDeviceSize countBufferOffset,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004270 uint32_t maxDrawCount, uint32_t stride) const {
Jeff Bolz45bf7d62018-09-18 15:39:58 -05004271 bool skip = false;
4272
Jeff Bolz45bf7d62018-09-18 15:39:58 -05004273 if (offset & 3) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004274 skip |= LogError(commandBuffer, "VUID-vkCmdDrawMeshTasksIndirectCountNV-offset-02710",
4275 "vkCmdDrawMeshTasksIndirectCountNV() parameter, VkDeviceSize offset (0x%" PRIxLEAST64
4276 "), is not a multiple of 4.",
4277 offset);
Jeff Bolz45bf7d62018-09-18 15:39:58 -05004278 }
4279
4280 if (countBufferOffset & 3) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004281 skip |= LogError(commandBuffer, "VUID-vkCmdDrawMeshTasksIndirectCountNV-countBufferOffset-02716",
4282 "vkCmdDrawMeshTasksIndirectCountNV() parameter, VkDeviceSize countBufferOffset (0x%" PRIxLEAST64
4283 "), is not a multiple of 4.",
4284 countBufferOffset);
Jeff Bolz45bf7d62018-09-18 15:39:58 -05004285 }
4286
Jeff Bolz45bf7d62018-09-18 15:39:58 -05004287 return skip;
4288}
4289
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004290bool StatelessValidation::manual_PreCallValidateCreateQueryPool(VkDevice device, const VkQueryPoolCreateInfo *pCreateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004291 const VkAllocationCallbacks *pAllocator,
4292 VkQueryPool *pQueryPool) const {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004293 bool skip = false;
4294
4295 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
4296 if (pCreateInfo != nullptr) {
4297 // If queryType is VK_QUERY_TYPE_PIPELINE_STATISTICS, pipelineStatistics must be a valid combination of
4298 // VkQueryPipelineStatisticFlagBits values
4299 if ((pCreateInfo->queryType == VK_QUERY_TYPE_PIPELINE_STATISTICS) && (pCreateInfo->pipelineStatistics != 0) &&
4300 ((pCreateInfo->pipelineStatistics & (~AllVkQueryPipelineStatisticFlagBits)) != 0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004301 skip |= LogError(device, "VUID-VkQueryPoolCreateInfo-queryType-00792",
4302 "vkCreateQueryPool(): if pCreateInfo->queryType is VK_QUERY_TYPE_PIPELINE_STATISTICS, "
4303 "pCreateInfo->pipelineStatistics must be a valid combination of VkQueryPipelineStatisticFlagBits "
4304 "values.");
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004305 }
sfricke-samsung7d69d0d2020-04-25 10:27:27 -07004306 if (pCreateInfo->queryCount == 0) {
4307 skip |= LogError(device, "VUID-VkQueryPoolCreateInfo-queryCount-02763",
4308 "vkCreateQueryPool(): queryCount must be greater than zero.");
4309 }
Mark Lobodzinskib7a26382018-07-02 13:14:26 -06004310 }
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004311 return skip;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004312}
4313
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004314bool StatelessValidation::manual_PreCallValidateEnumerateDeviceExtensionProperties(VkPhysicalDevice physicalDevice,
4315 const char *pLayerName, uint32_t *pPropertyCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004316 VkExtensionProperties *pProperties) const {
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004317 return validate_array("vkEnumerateDeviceExtensionProperties", "pPropertyCount", "pProperties", pPropertyCount, &pProperties,
4318 true, false, false, kVUIDUndefined, "VUID-vkEnumerateDeviceExtensionProperties-pProperties-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004319}
4320
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004321void StatelessValidation::PostCallRecordCreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo,
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -07004322 const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass,
4323 VkResult result) {
4324 if (result != VK_SUCCESS) return;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004325 RecordRenderPass(*pRenderPass, pCreateInfo);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004326}
4327
Mike Schuchardt2df08912020-12-15 16:28:09 -08004328void StatelessValidation::PostCallRecordCreateRenderPass2KHR(VkDevice device, const VkRenderPassCreateInfo2 *pCreateInfo,
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -07004329 const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass,
4330 VkResult result) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004331 // Track the state necessary for checking vkCreateGraphicsPipeline (subpass usage of depth and color attachments)
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -07004332 if (result != VK_SUCCESS) return;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004333 RecordRenderPass(*pRenderPass, pCreateInfo);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004334}
4335
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004336void StatelessValidation::PostCallRecordDestroyRenderPass(VkDevice device, VkRenderPass renderPass,
4337 const VkAllocationCallbacks *pAllocator) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004338 // Track the state necessary for checking vkCreateGraphicsPipeline (subpass usage of depth and color attachments)
Mark Lobodzinskif27a6bc2019-02-04 13:00:49 -07004339 std::unique_lock<std::mutex> lock(renderpass_map_mutex);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004340 renderpasses_states.erase(renderPass);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004341}
Jeff Bolz7e7e6e02019-01-11 22:53:41 -06004342
Tony-LunarG3c287f62020-12-17 12:39:49 -07004343void StatelessValidation::PostCallRecordAllocateCommandBuffers(VkDevice device, const VkCommandBufferAllocateInfo *pAllocateInfo,
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004344 VkCommandBuffer *pCommandBuffers, VkResult result) {
Tony-LunarG3c287f62020-12-17 12:39:49 -07004345 if ((result == VK_SUCCESS) && pAllocateInfo && (pAllocateInfo->level == VK_COMMAND_BUFFER_LEVEL_SECONDARY)) {
4346 auto lock = cb_write_lock();
4347 for (uint32_t cb_index = 0; cb_index < pAllocateInfo->commandBufferCount; cb_index++) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004348 secondary_cb_map.insert({pCommandBuffers[cb_index], pAllocateInfo->commandPool});
Tony-LunarG3c287f62020-12-17 12:39:49 -07004349 }
4350 }
4351}
4352
4353void StatelessValidation::PostCallRecordFreeCommandBuffers(VkDevice device, VkCommandPool commandPool, uint32_t commandBufferCount,
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004354 const VkCommandBuffer *pCommandBuffers) {
Tony-LunarG3c287f62020-12-17 12:39:49 -07004355 auto lock = cb_write_lock();
4356 for (uint32_t cb_index = 0; cb_index < commandBufferCount; cb_index++) {
4357 secondary_cb_map.erase(pCommandBuffers[cb_index]);
4358 }
4359}
4360
4361void StatelessValidation::PostCallRecordDestroyCommandPool(VkDevice device, VkCommandPool commandPool,
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004362 const VkAllocationCallbacks *pAllocator) {
Tony-LunarG3c287f62020-12-17 12:39:49 -07004363 auto lock = cb_write_lock();
4364 for (auto item = secondary_cb_map.begin(); item != secondary_cb_map.end();) {
4365 if (item->second == commandPool) {
4366 item = secondary_cb_map.erase(item);
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004367 } else {
Tony-LunarG3c287f62020-12-17 12:39:49 -07004368 ++item;
4369 }
4370 }
4371}
4372
Jeff Bolz7e7e6e02019-01-11 22:53:41 -06004373bool StatelessValidation::manual_PreCallValidateAllocateMemory(VkDevice device, const VkMemoryAllocateInfo *pAllocateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004374 const VkAllocationCallbacks *pAllocator,
4375 VkDeviceMemory *pMemory) const {
Jeff Bolz7e7e6e02019-01-11 22:53:41 -06004376 bool skip = false;
4377
4378 if (pAllocateInfo) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004379 auto chained_prio_struct = LvlFindInChain<VkMemoryPriorityAllocateInfoEXT>(pAllocateInfo->pNext);
Jeff Bolz7e7e6e02019-01-11 22:53:41 -06004380 if (chained_prio_struct && (chained_prio_struct->priority < 0.0f || chained_prio_struct->priority > 1.0f)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004381 skip |= LogError(device, "VUID-VkMemoryPriorityAllocateInfoEXT-priority-02602",
4382 "priority (=%f) must be between `0` and `1`, inclusive.", chained_prio_struct->priority);
Jeff Bolz7e7e6e02019-01-11 22:53:41 -06004383 }
Jeff Bolz4563f2a2019-12-10 13:30:30 -06004384
4385 VkMemoryAllocateFlags flags = 0;
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004386 auto flags_info = LvlFindInChain<VkMemoryAllocateFlagsInfo>(pAllocateInfo->pNext);
Jeff Bolz4563f2a2019-12-10 13:30:30 -06004387 if (flags_info) {
4388 flags = flags_info->flags;
4389 }
4390
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004391 auto opaque_alloc_info = LvlFindInChain<VkMemoryOpaqueCaptureAddressAllocateInfo>(pAllocateInfo->pNext);
Jeff Bolz4563f2a2019-12-10 13:30:30 -06004392 if (opaque_alloc_info && opaque_alloc_info->opaqueCaptureAddress != 0) {
Mike Schuchardt2df08912020-12-15 16:28:09 -08004393 if (!(flags & VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004394 skip |= LogError(device, "VUID-VkMemoryAllocateInfo-opaqueCaptureAddress-03329",
4395 "If opaqueCaptureAddress is non-zero, VkMemoryAllocateFlagsInfo::flags must include "
Mike Schuchardt2df08912020-12-15 16:28:09 -08004396 "VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT.");
Jeff Bolz4563f2a2019-12-10 13:30:30 -06004397 }
4398
4399#ifdef VK_USE_PLATFORM_WIN32_KHR
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004400 auto import_memory_win32_handle = LvlFindInChain<VkImportMemoryWin32HandleInfoKHR>(pAllocateInfo->pNext);
Jeff Bolz4563f2a2019-12-10 13:30:30 -06004401#endif
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004402 auto import_memory_fd = LvlFindInChain<VkImportMemoryFdInfoKHR>(pAllocateInfo->pNext);
4403 auto import_memory_host_pointer = LvlFindInChain<VkImportMemoryHostPointerInfoEXT>(pAllocateInfo->pNext);
Jeff Bolz4563f2a2019-12-10 13:30:30 -06004404#ifdef VK_USE_PLATFORM_ANDROID_KHR
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004405 auto import_memory_ahb = LvlFindInChain<VkImportAndroidHardwareBufferInfoANDROID>(pAllocateInfo->pNext);
Jeff Bolz4563f2a2019-12-10 13:30:30 -06004406#endif
4407
4408 if (import_memory_host_pointer) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004409 skip |= LogError(
4410 device, "VUID-VkMemoryAllocateInfo-pNext-03332",
Jeff Bolz4563f2a2019-12-10 13:30:30 -06004411 "If the pNext chain includes a VkImportMemoryHostPointerInfoEXT structure, opaqueCaptureAddress must be zero.");
4412 }
4413 if (
4414#ifdef VK_USE_PLATFORM_WIN32_KHR
4415 (import_memory_win32_handle && import_memory_win32_handle->handleType) ||
4416#endif
4417 (import_memory_fd && import_memory_fd->handleType) ||
4418#ifdef VK_USE_PLATFORM_ANDROID_KHR
4419 (import_memory_ahb && import_memory_ahb->buffer) ||
4420#endif
4421 (import_memory_host_pointer && import_memory_host_pointer->handleType)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004422 skip |= LogError(device, "VUID-VkMemoryAllocateInfo-opaqueCaptureAddress-03333",
4423 "If the parameters define an import operation, opaqueCaptureAddress must be zero.");
Jeff Bolz4563f2a2019-12-10 13:30:30 -06004424 }
4425 }
4426
4427 if (flags) {
Tony-LunarGa74d3fe2019-11-22 15:43:20 -07004428 VkBool32 capture_replay = false;
4429 VkBool32 buffer_device_address = false;
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004430 const auto *vulkan_12_features = LvlFindInChain<VkPhysicalDeviceVulkan12Features>(device_createinfo_pnext);
Tony-LunarGa74d3fe2019-11-22 15:43:20 -07004431 if (vulkan_12_features) {
4432 capture_replay = vulkan_12_features->bufferDeviceAddressCaptureReplay;
4433 buffer_device_address = vulkan_12_features->bufferDeviceAddress;
4434 } else {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004435 const auto *bda_features = LvlFindInChain<VkPhysicalDeviceBufferDeviceAddressFeatures>(device_createinfo_pnext);
Tony-LunarGa74d3fe2019-11-22 15:43:20 -07004436 if (bda_features) {
4437 capture_replay = bda_features->bufferDeviceAddressCaptureReplay;
4438 buffer_device_address = bda_features->bufferDeviceAddress;
4439 }
4440 }
Mike Schuchardt2df08912020-12-15 16:28:09 -08004441 if ((flags & VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT) && !capture_replay) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004442 skip |= LogError(device, "VUID-VkMemoryAllocateInfo-flags-03330",
Mike Schuchardt2df08912020-12-15 16:28:09 -08004443 "If VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT is set, "
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004444 "bufferDeviceAddressCaptureReplay must be enabled.");
Jeff Bolz4563f2a2019-12-10 13:30:30 -06004445 }
Mike Schuchardt2df08912020-12-15 16:28:09 -08004446 if ((flags & VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_BIT) && !buffer_device_address) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004447 skip |= LogError(device, "VUID-VkMemoryAllocateInfo-flags-03331",
Mike Schuchardt2df08912020-12-15 16:28:09 -08004448 "If VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_BIT is set, bufferDeviceAddress must be enabled.");
Jeff Bolz4563f2a2019-12-10 13:30:30 -06004449 }
4450 }
Jeff Bolz7e7e6e02019-01-11 22:53:41 -06004451 }
4452 return skip;
4453}
Ricardo Garciaa4935972019-02-21 17:43:18 +01004454
Jason Macnak192fa0e2019-07-26 15:07:16 -07004455bool StatelessValidation::ValidateGeometryTrianglesNV(const VkGeometryTrianglesNV &triangles,
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004456 VkAccelerationStructureNV object_handle, const char *func_name) const {
Jason Macnak192fa0e2019-07-26 15:07:16 -07004457 bool skip = false;
4458
4459 if (triangles.vertexFormat != VK_FORMAT_R32G32B32_SFLOAT && triangles.vertexFormat != VK_FORMAT_R16G16B16_SFLOAT &&
4460 triangles.vertexFormat != VK_FORMAT_R16G16B16_SNORM && triangles.vertexFormat != VK_FORMAT_R32G32_SFLOAT &&
4461 triangles.vertexFormat != VK_FORMAT_R16G16_SFLOAT && triangles.vertexFormat != VK_FORMAT_R16G16_SNORM) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004462 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-vertexFormat-02430", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004463 } else {
4464 uint32_t vertex_component_size = 0;
4465 if (triangles.vertexFormat == VK_FORMAT_R32G32B32_SFLOAT || triangles.vertexFormat == VK_FORMAT_R32G32_SFLOAT) {
4466 vertex_component_size = 4;
4467 } else if (triangles.vertexFormat == VK_FORMAT_R16G16B16_SFLOAT || triangles.vertexFormat == VK_FORMAT_R16G16B16_SNORM ||
4468 triangles.vertexFormat == VK_FORMAT_R16G16_SFLOAT || triangles.vertexFormat == VK_FORMAT_R16G16_SNORM) {
4469 vertex_component_size = 2;
4470 }
4471 if (vertex_component_size > 0 && SafeModulo(triangles.vertexOffset, vertex_component_size) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004472 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-vertexOffset-02429", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004473 }
4474 }
4475
4476 if (triangles.indexType != VK_INDEX_TYPE_UINT32 && triangles.indexType != VK_INDEX_TYPE_UINT16 &&
4477 triangles.indexType != VK_INDEX_TYPE_NONE_NV) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004478 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-indexType-02433", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004479 } else {
4480 uint32_t index_element_size = 0;
4481 if (triangles.indexType == VK_INDEX_TYPE_UINT32) {
4482 index_element_size = 4;
4483 } else if (triangles.indexType == VK_INDEX_TYPE_UINT16) {
4484 index_element_size = 2;
4485 }
4486 if (index_element_size > 0 && SafeModulo(triangles.indexOffset, index_element_size) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004487 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-indexOffset-02432", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004488 }
4489 }
4490 if (triangles.indexType == VK_INDEX_TYPE_NONE_NV) {
4491 if (triangles.indexCount != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004492 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-indexCount-02436", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004493 }
4494 if (triangles.indexData != VK_NULL_HANDLE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004495 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-indexData-02434", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004496 }
4497 }
4498
4499 if (SafeModulo(triangles.transformOffset, 16) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004500 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-transformOffset-02438", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004501 }
4502
4503 return skip;
4504}
4505
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004506bool StatelessValidation::ValidateGeometryAABBNV(const VkGeometryAABBNV &aabbs, VkAccelerationStructureNV object_handle,
4507 const char *func_name) const {
Jason Macnak192fa0e2019-07-26 15:07:16 -07004508 bool skip = false;
4509
4510 if (SafeModulo(aabbs.offset, 8) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004511 skip |= LogError(object_handle, "VUID-VkGeometryAABBNV-offset-02440", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004512 }
4513 if (SafeModulo(aabbs.stride, 8) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004514 skip |= LogError(object_handle, "VUID-VkGeometryAABBNV-stride-02441", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004515 }
4516
4517 return skip;
4518}
4519
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004520bool StatelessValidation::ValidateGeometryNV(const VkGeometryNV &geometry, VkAccelerationStructureNV object_handle,
4521 const char *func_name) const {
Jason Macnak192fa0e2019-07-26 15:07:16 -07004522 bool skip = false;
4523 if (geometry.geometryType == VK_GEOMETRY_TYPE_TRIANGLES_NV) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004524 skip = ValidateGeometryTrianglesNV(geometry.geometry.triangles, object_handle, func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004525 } else if (geometry.geometryType == VK_GEOMETRY_TYPE_AABBS_NV) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004526 skip = ValidateGeometryAABBNV(geometry.geometry.aabbs, object_handle, func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004527 }
4528 return skip;
4529}
4530
4531bool StatelessValidation::ValidateAccelerationStructureInfoNV(const VkAccelerationStructureInfoNV &info,
sourav parmara24fb7b2020-05-26 10:50:04 -07004532 VkAccelerationStructureNV object_handle, const char *func_name,
Mark Lobodzinski17dc4602020-05-29 07:48:40 -06004533 bool is_cmd) const {
Jason Macnak5c954952019-07-09 15:46:12 -07004534 bool skip = false;
4535 if (info.type == VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_NV && info.geometryCount != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004536 skip |= LogError(object_handle, "VUID-VkAccelerationStructureInfoNV-type-02425",
4537 "VkAccelerationStructureInfoNV: If type is VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_NV then "
4538 "geometryCount must be 0.");
Jason Macnak5c954952019-07-09 15:46:12 -07004539 }
4540 if (info.type == VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_NV && info.instanceCount != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004541 skip |= LogError(object_handle, "VUID-VkAccelerationStructureInfoNV-type-02426",
4542 "VkAccelerationStructureInfoNV: If type is VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_NV then "
4543 "instanceCount must be 0.");
Jason Macnak5c954952019-07-09 15:46:12 -07004544 }
4545 if (info.flags & VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_TRACE_BIT_NV &&
4546 info.flags & VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_BUILD_BIT_NV) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004547 skip |= LogError(object_handle, "VUID-VkAccelerationStructureInfoNV-flags-02592",
4548 "VkAccelerationStructureInfoNV: If flags has the VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_TRACE_BIT_NV"
4549 "bit set, then it must not have the VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_BUILD_BIT_NV bit set.");
Jason Macnak5c954952019-07-09 15:46:12 -07004550 }
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004551 if (info.geometryCount > phys_dev_ext_props.ray_tracing_propsNV.maxGeometryCount) {
sourav parmara24fb7b2020-05-26 10:50:04 -07004552 skip |= LogError(object_handle,
Mark Lobodzinski17dc4602020-05-29 07:48:40 -06004553 is_cmd ? "VUID-vkCmdBuildAccelerationStructureNV-geometryCount-02241"
4554 : "VUID-VkAccelerationStructureInfoNV-geometryCount-02422",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004555 "VkAccelerationStructureInfoNV: geometryCount must be less than or equal to "
4556 "VkPhysicalDeviceRayTracingPropertiesNV::maxGeometryCount.");
Jason Macnak5c954952019-07-09 15:46:12 -07004557 }
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004558 if (info.instanceCount > phys_dev_ext_props.ray_tracing_propsNV.maxInstanceCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004559 skip |= LogError(object_handle, "VUID-VkAccelerationStructureInfoNV-instanceCount-02423",
4560 "VkAccelerationStructureInfoNV: instanceCount must be less than or equal to "
4561 "VkPhysicalDeviceRayTracingPropertiesNV::maxInstanceCount.");
Jason Macnak5c954952019-07-09 15:46:12 -07004562 }
Jason Macnak21ba97e2019-08-09 12:57:44 -07004563 if (info.type == VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_NV && info.geometryCount > 0) {
Jason Macnak5c954952019-07-09 15:46:12 -07004564 uint64_t total_triangle_count = 0;
4565 for (uint32_t i = 0; i < info.geometryCount; i++) {
4566 const VkGeometryNV &geometry = info.pGeometries[i];
Jason Macnak192fa0e2019-07-26 15:07:16 -07004567
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004568 skip |= ValidateGeometryNV(geometry, object_handle, func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004569
Jason Macnak5c954952019-07-09 15:46:12 -07004570 if (geometry.geometryType != VK_GEOMETRY_TYPE_TRIANGLES_NV) {
4571 continue;
4572 }
4573 total_triangle_count += geometry.geometry.triangles.indexCount / 3;
4574 }
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004575 if (total_triangle_count > phys_dev_ext_props.ray_tracing_propsNV.maxTriangleCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004576 skip |= LogError(object_handle, "VUID-VkAccelerationStructureInfoNV-maxTriangleCount-02424",
4577 "VkAccelerationStructureInfoNV: The total number of triangles in all geometries must be less than "
4578 "or equal to VkPhysicalDeviceRayTracingPropertiesNV::maxTriangleCount.");
Jason Macnak5c954952019-07-09 15:46:12 -07004579 }
4580 }
Jason Macnak21ba97e2019-08-09 12:57:44 -07004581 if (info.type == VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_NV && info.geometryCount > 1) {
4582 const VkGeometryTypeNV first_geometry_type = info.pGeometries[0].geometryType;
4583 for (uint32_t i = 1; i < info.geometryCount; i++) {
4584 const VkGeometryNV &geometry = info.pGeometries[i];
4585 if (geometry.geometryType != first_geometry_type) {
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004586 skip |= LogError(device, "VUID-VkAccelerationStructureInfoNV-type-02786",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004587 "VkAccelerationStructureInfoNV: info.pGeometries[%d].geometryType does not match "
4588 "info.pGeometries[0].geometryType.",
4589 i);
Jason Macnak21ba97e2019-08-09 12:57:44 -07004590 }
4591 }
4592 }
sourav parmara96ab1a2020-04-25 16:28:23 -07004593 for (uint32_t geometry_index = 0; geometry_index < info.geometryCount; ++geometry_index) {
4594 if (!(info.pGeometries[geometry_index].geometryType == VK_GEOMETRY_TYPE_TRIANGLES_NV ||
4595 info.pGeometries[geometry_index].geometryType == VK_GEOMETRY_TYPE_AABBS_NV)) {
4596 skip |= LogError(device, "VUID-VkGeometryNV-geometryType-03503",
4597 "VkGeometryNV: geometryType must be VK_GEOMETRY_TYPE_TRIANGLES_NV"
4598 "or VK_GEOMETRY_TYPE_AABBS_NV.");
4599 }
4600 }
4601 skip |=
4602 validate_flags(func_name, "info.flags", "VkBuildAccelerationStructureFlagBitsNV", AllVkBuildAccelerationStructureFlagBitsNV,
Shannon McPherson93970b12020-06-12 14:34:35 -06004603 info.flags, kOptionalFlags, "VUID-VkAccelerationStructureInfoNV-flags-parameter");
Jason Macnak5c954952019-07-09 15:46:12 -07004604 return skip;
4605}
4606
Ricardo Garciaa4935972019-02-21 17:43:18 +01004607bool StatelessValidation::manual_PreCallValidateCreateAccelerationStructureNV(
4608 VkDevice device, const VkAccelerationStructureCreateInfoNV *pCreateInfo, const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004609 VkAccelerationStructureNV *pAccelerationStructure) const {
Ricardo Garciaa4935972019-02-21 17:43:18 +01004610 bool skip = false;
Ricardo Garciaa4935972019-02-21 17:43:18 +01004611 if (pCreateInfo) {
4612 if ((pCreateInfo->compactedSize != 0) &&
4613 ((pCreateInfo->info.geometryCount != 0) || (pCreateInfo->info.instanceCount != 0))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004614 skip |= LogError(device, "VUID-VkAccelerationStructureCreateInfoNV-compactedSize-02421",
4615 "vkCreateAccelerationStructureNV(): pCreateInfo->compactedSize nonzero (%" PRIu64
4616 ") with info.geometryCount (%" PRIu32 ") or info.instanceCount (%" PRIu32 ") nonzero.",
4617 pCreateInfo->compactedSize, pCreateInfo->info.geometryCount, pCreateInfo->info.instanceCount);
Ricardo Garciaa4935972019-02-21 17:43:18 +01004618 }
Jason Macnak5c954952019-07-09 15:46:12 -07004619
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004620 skip |= ValidateAccelerationStructureInfoNV(pCreateInfo->info, VkAccelerationStructureNV(0),
sourav parmara24fb7b2020-05-26 10:50:04 -07004621 "vkCreateAccelerationStructureNV()", false);
Ricardo Garciaa4935972019-02-21 17:43:18 +01004622 }
Ricardo Garciaa4935972019-02-21 17:43:18 +01004623 return skip;
4624}
Mike Schuchardt21638df2019-03-16 10:52:02 -07004625
Jeff Bolz5c801d12019-10-09 10:38:45 -05004626bool StatelessValidation::manual_PreCallValidateCmdBuildAccelerationStructureNV(VkCommandBuffer commandBuffer,
4627 const VkAccelerationStructureInfoNV *pInfo,
4628 VkBuffer instanceData, VkDeviceSize instanceOffset,
4629 VkBool32 update, VkAccelerationStructureNV dst,
4630 VkAccelerationStructureNV src, VkBuffer scratch,
4631 VkDeviceSize scratchOffset) const {
Jason Macnak5c954952019-07-09 15:46:12 -07004632 bool skip = false;
4633
4634 if (pInfo != nullptr) {
sourav parmara24fb7b2020-05-26 10:50:04 -07004635 skip |= ValidateAccelerationStructureInfoNV(*pInfo, dst, "vkCmdBuildAccelerationStructureNV()", true);
Jason Macnak5c954952019-07-09 15:46:12 -07004636 }
4637
4638 return skip;
4639}
4640
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004641bool StatelessValidation::manual_PreCallValidateCreateAccelerationStructureKHR(
4642 VkDevice device, const VkAccelerationStructureCreateInfoKHR *pCreateInfo, const VkAllocationCallbacks *pAllocator,
4643 VkAccelerationStructureKHR *pAccelerationStructure) const {
4644 bool skip = false;
sourav parmarcd5fb182020-07-17 12:58:44 -07004645 const auto *acceleration_structure_features =
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004646 LvlFindInChain<VkPhysicalDeviceAccelerationStructureFeaturesKHR>(device_createinfo_pnext);
sourav parmarcd5fb182020-07-17 12:58:44 -07004647 if (!acceleration_structure_features ||
4648 (acceleration_structure_features && acceleration_structure_features->accelerationStructure == VK_FALSE)) {
4649 skip |= LogError(device, "VUID-vkCreateAccelerationStructureKHR-accelerationStructure-03611",
4650 "vkCreateAccelerationStructureKHR(): The accelerationStructure feature must be enabled");
4651 }
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004652 if (pCreateInfo) {
sourav parmarcd5fb182020-07-17 12:58:44 -07004653 if (pCreateInfo->createFlags & VK_ACCELERATION_STRUCTURE_CREATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT_KHR &&
4654 (!acceleration_structure_features ||
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004655 (acceleration_structure_features &&
4656 acceleration_structure_features->accelerationStructureCaptureReplay == VK_FALSE))) {
sourav parmara96ab1a2020-04-25 16:28:23 -07004657 skip |=
sourav parmarcd5fb182020-07-17 12:58:44 -07004658 LogError(device, "VUID-VkAccelerationStructureCreateInfoKHR-createFlags-03613",
4659 "vkCreateAccelerationStructureKHR(): If createFlags includes "
4660 "VK_ACCELERATION_STRUCTURE_CREATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT_KHR, "
4661 "VkPhysicalDeviceAccelerationStructureFeaturesKHR::accelerationStructureCaptureReplay must be VK_TRUE");
sourav parmara96ab1a2020-04-25 16:28:23 -07004662 }
sourav parmarcd5fb182020-07-17 12:58:44 -07004663 if (pCreateInfo->deviceAddress &&
4664 !(pCreateInfo->createFlags & VK_ACCELERATION_STRUCTURE_CREATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT_KHR)) {
4665 skip |= LogError(device, "VUID-VkAccelerationStructureCreateInfoKHR-deviceAddress-03612",
4666 "vkCreateAccelerationStructureKHR(): If deviceAddress is not zero, createFlags must include "
4667 "VK_ACCELERATION_STRUCTURE_CREATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT_KHR");
4668 }
4669 if (SafeModulo(pCreateInfo->offset, 256) != 0) {
4670 skip |= LogError(device, "VUID-VkAccelerationStructureCreateInfoKHR-offset-03734",
4671 "vkCreateAccelerationStructureKHR(): offset must be a multiple of 256 bytes", pCreateInfo->offset);
4672 }
sourav parmar83c31b12020-05-06 12:30:54 -07004673 }
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004674 return skip;
4675}
4676
Jason Macnak5c954952019-07-09 15:46:12 -07004677bool StatelessValidation::manual_PreCallValidateGetAccelerationStructureHandleNV(VkDevice device,
4678 VkAccelerationStructureNV accelerationStructure,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004679 size_t dataSize, void *pData) const {
Jason Macnak5c954952019-07-09 15:46:12 -07004680 bool skip = false;
4681 if (dataSize < 8) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004682 skip = LogError(accelerationStructure, "VUID-vkGetAccelerationStructureHandleNV-dataSize-02240",
4683 "vkGetAccelerationStructureHandleNV(): dataSize must be greater than or equal to 8.");
Jason Macnak5c954952019-07-09 15:46:12 -07004684 }
4685 return skip;
4686}
4687
sourav parmarcd5fb182020-07-17 12:58:44 -07004688bool StatelessValidation::manual_PreCallValidateCmdWriteAccelerationStructuresPropertiesNV(
4689 VkCommandBuffer commandBuffer, uint32_t accelerationStructureCount, const VkAccelerationStructureNV *pAccelerationStructures,
4690 VkQueryType queryType, VkQueryPool queryPool, uint32_t firstQuery) const {
4691 bool skip = false;
Mark Lobodzinskic0df6b62021-01-08 12:34:11 -07004692 if (queryType != VK_QUERY_TYPE_ACCELERATION_STRUCTURE_COMPACTED_SIZE_NV) {
sourav parmarcd5fb182020-07-17 12:58:44 -07004693 skip |= LogError(device, "VUID-vkCmdWriteAccelerationStructuresPropertiesNV-queryType-03432",
4694 "vkCmdWriteAccelerationStructuresPropertiesNV: queryType must be "
Mark Lobodzinskic0df6b62021-01-08 12:34:11 -07004695 "VK_QUERY_TYPE_ACCELERATION_STRUCTURE_COMPACTED_SIZE_NV.");
sourav parmarcd5fb182020-07-17 12:58:44 -07004696 }
4697 return skip;
4698}
4699
Peter Chen85366392019-05-14 15:20:11 -04004700bool StatelessValidation::manual_PreCallValidateCreateRayTracingPipelinesNV(VkDevice device, VkPipelineCache pipelineCache,
4701 uint32_t createInfoCount,
4702 const VkRayTracingPipelineCreateInfoNV *pCreateInfos,
4703 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004704 VkPipeline *pPipelines) const {
Peter Chen85366392019-05-14 15:20:11 -04004705 bool skip = false;
4706
4707 for (uint32_t i = 0; i < createInfoCount; i++) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004708 auto feedback_struct = LvlFindInChain<VkPipelineCreationFeedbackCreateInfoEXT>(pCreateInfos[i].pNext);
Peter Chen85366392019-05-14 15:20:11 -04004709 if ((feedback_struct != nullptr) && (feedback_struct->pipelineStageCreationFeedbackCount != pCreateInfos[i].stageCount)) {
sourav parmar83c31b12020-05-06 12:30:54 -07004710 skip |= LogError(device, "VUID-VkPipelineCreationFeedbackCreateInfoEXT-pipelineStageCreationFeedbackCount-02969",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004711 "vkCreateRayTracingPipelinesNV(): in pCreateInfo[%" PRIu32
4712 "], VkPipelineCreationFeedbackEXT::pipelineStageCreationFeedbackCount"
4713 "(=%" PRIu32 ") must equal VkRayTracingPipelineCreateInfoNV::stageCount(=%" PRIu32 ").",
4714 i, feedback_struct->pipelineStageCreationFeedbackCount, pCreateInfos[i].stageCount);
Peter Chen85366392019-05-14 15:20:11 -04004715 }
sourav parmara96ab1a2020-04-25 16:28:23 -07004716
4717 const auto *pipeline_cache_contol_features =
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004718 LvlFindInChain<VkPhysicalDevicePipelineCreationCacheControlFeaturesEXT>(device_createinfo_pnext);
sourav parmara96ab1a2020-04-25 16:28:23 -07004719 if (!pipeline_cache_contol_features || pipeline_cache_contol_features->pipelineCreationCacheControl == VK_FALSE) {
4720 if (pCreateInfos[i].flags & (VK_PIPELINE_CREATE_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT_EXT |
4721 VK_PIPELINE_CREATE_EARLY_RETURN_ON_FAILURE_BIT_EXT)) {
4722 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-pipelineCreationCacheControl-02905",
4723 "vkCreateRayTracingPipelinesNV(): If the pipelineCreationCacheControl feature is not enabled,"
4724 "flags must not include VK_PIPELINE_CREATE_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT_EXT or"
4725 "VK_PIPELINE_CREATE_EARLY_RETURN_ON_FAILURE_BIT_EXT.");
4726 }
4727 }
4728
sourav parmarf4a78252020-04-10 13:04:21 -07004729 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_INDIRECT_BINDABLE_BIT_NV) {
4730 skip |=
4731 LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-02904",
4732 "vkCreateRayTracingPipelinesNV(): flags must not include VK_PIPELINE_CREATE_INDIRECT_BINDABLE_BIT_NV.");
4733 }
4734 if ((pCreateInfos[i].flags & VK_PIPELINE_CREATE_DEFER_COMPILE_BIT_NV) &&
4735 (pCreateInfos[i].flags & VK_PIPELINE_CREATE_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT_EXT)) {
4736 skip |=
4737 LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-02957",
4738 "vkCreateRayTracingPipelinesNV(): flags must not include both VK_PIPELINE_CREATE_DEFER_COMPILE_BIT_NV and"
4739 "VK_PIPELINE_CREATE_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT_EXT at the same time.");
4740 }
4741 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_DERIVATIVE_BIT) {
4742 if (pCreateInfos[i].basePipelineIndex != -1) {
4743 if (pCreateInfos[i].basePipelineHandle != VK_NULL_HANDLE) {
4744 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03423",
4745 "vkCreateRayTracingPipelinesNV parameter, pCreateInfos->basePipelineHandle, must be "
4746 "VK_NULL_HANDLE if pCreateInfos->flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT flag "
4747 "and pCreateInfos->basePipelineIndex is not -1.");
4748 }
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07004749 if (pCreateInfos[i].basePipelineIndex > static_cast<int32_t>(i)) {
sourav parmara24fb7b2020-05-26 10:50:04 -07004750 skip |=
4751 LogError(device, "VUID-vkCreateRayTracingPipelinesNV-flags-03415",
4752 "vkCreateRayTracingPipelinesNV: If the flags member of any element of pCreateInfos contains the"
4753 "VK_PIPELINE_CREATE_DERIVATIVE_BIT flag, and the basePipelineIndex member of that same element"
4754 "is not -1, basePipelineIndex must be less than the index into pCreateInfos that corresponds to "
4755 "that element.");
4756 }
sourav parmarf4a78252020-04-10 13:04:21 -07004757 }
4758 if (pCreateInfos[i].basePipelineHandle == VK_NULL_HANDLE) {
David Netod9d7b762020-07-27 15:37:58 -04004759 if (static_cast<uint32_t>(pCreateInfos[i].basePipelineIndex) >= createInfoCount) {
sourav parmarf4a78252020-04-10 13:04:21 -07004760 skip |=
4761 LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03422",
4762 "vkCreateRayTracingPipelinesNV if flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT and"
4763 "basePipelineHandle is VK_NULL_HANDLE, basePipelineIndex must be a valid index into the calling"
4764 "commands pCreateInfos parameter.");
4765 }
4766 } else {
4767 if (pCreateInfos[i].basePipelineIndex != -1) {
4768 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03424",
4769 "vkCreateRayTracingPipelinesNV if flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT and"
4770 "basePipelineHandle is not VK_NULL_HANDLE, basePipelineIndex must be -1.");
4771 }
4772 }
4773 }
4774 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_LIBRARY_BIT_KHR) {
4775 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03456",
4776 "vkCreateRayTracingPipelinesNV: flags must not include VK_PIPELINE_CREATE_LIBRARY_BIT_KHR.");
4777 }
4778 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_ANY_HIT_SHADERS_BIT_KHR) {
4779 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03458",
4780 "vkCreateRayTracingPipelinesNV: flags must not include "
4781 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_ANY_HIT_SHADERS_BIT_KHR.");
4782 }
4783 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_CLOSEST_HIT_SHADERS_BIT_KHR) {
4784 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03459",
4785 "vkCreateRayTracingPipelinesNV: flags must not include "
4786 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_CLOSEST_HIT_SHADERS_BIT_KHR.");
4787 }
4788 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_MISS_SHADERS_BIT_KHR) {
4789 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03460",
4790 "vkCreateRayTracingPipelinesNV: flags must not include "
4791 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_MISS_SHADERS_BIT_KHR.");
4792 }
4793 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_INTERSECTION_SHADERS_BIT_KHR) {
4794 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03461",
4795 "vkCreateRayTracingPipelinesNV: flags must not include "
4796 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_INTERSECTION_SHADERS_BIT_KHR.");
4797 }
4798 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_SKIP_AABBS_BIT_KHR) {
4799 skip |= LogError(
4800 device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03462",
4801 "vkCreateRayTracingPipelinesNV: flags must not include VK_PIPELINE_CREATE_RAY_TRACING_SKIP_AABBS_BIT_KHR.");
4802 }
4803 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_SKIP_TRIANGLES_BIT_KHR) {
4804 skip |= LogError(
4805 device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03463",
4806 "vkCreateRayTracingPipelinesNV: flags must not include VK_PIPELINE_CREATE_RAY_TRACING_SKIP_TRIANGLES_BIT_KHR .");
4807 }
sourav parmarcd5fb182020-07-17 12:58:44 -07004808 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_SHADER_GROUP_HANDLE_CAPTURE_REPLAY_BIT_KHR) {
4809 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03588",
4810 "vkCreateRayTracingPipelinesNV: flags must not include "
4811 "VK_PIPELINE_CREATE_RAY_TRACING_SHADER_GROUP_HANDLE_CAPTURE_REPLAY_BIT_KHR.");
4812 }
4813 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_DISPATCH_BASE) {
4814 skip |= LogError(device, "VUID-vkCreateRayTracingPipelinesNV-flags-03816",
4815 "vkCreateRayTracingPipelinesNV: flags must not contain the VK_PIPELINE_CREATE_DISPATCH_BASE flag.");
4816 }
Peter Chen85366392019-05-14 15:20:11 -04004817 }
4818
4819 return skip;
4820}
4821
sourav parmarcd5fb182020-07-17 12:58:44 -07004822bool StatelessValidation::manual_PreCallValidateCreateRayTracingPipelinesKHR(
4823 VkDevice device, VkDeferredOperationKHR deferredOperation, VkPipelineCache pipelineCache, uint32_t createInfoCount,
4824 const VkRayTracingPipelineCreateInfoKHR *pCreateInfos, const VkAllocationCallbacks *pAllocator, VkPipeline *pPipelines) const {
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004825 bool skip = false;
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004826 const auto *raytracing_features = LvlFindInChain<VkPhysicalDeviceRayTracingPipelineFeaturesKHR>(device_createinfo_pnext);
sourav parmarcd5fb182020-07-17 12:58:44 -07004827 if (!raytracing_features || raytracing_features->rayTracingPipeline == VK_FALSE) {
4828 skip |= LogError(device, "VUID-vkCreateRayTracingPipelinesKHR-rayTracingPipeline-03586",
4829 "vkCreateRayTracingPipelinesKHR: The rayTracingPipeline feature must be enabled.");
sourav parmar83c31b12020-05-06 12:30:54 -07004830 }
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004831 for (uint32_t i = 0; i < createInfoCount; i++) {
sourav parmarcd5fb182020-07-17 12:58:44 -07004832 if (!raytracing_features || (raytracing_features && raytracing_features->rayTraversalPrimitiveCulling == VK_FALSE)) {
4833 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_SKIP_AABBS_BIT_KHR) {
4834 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-rayTraversalPrimitiveCulling-03596",
4835 "vkCreateRayTracingPipelinesKHR: If the rayTraversalPrimitiveCulling feature is not enabled, "
4836 "flags must not include VK_PIPELINE_CREATE_RAY_TRACING_SKIP_AABBS_BIT_KHR.");
4837 }
4838 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_SKIP_TRIANGLES_BIT_KHR) {
4839 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-rayTraversalPrimitiveCulling-03597",
4840 "vkCreateRayTracingPipelinesKHR: If the rayTraversalPrimitiveCulling feature is not enabled, "
4841 "flags must not include VK_PIPELINE_CREATE_RAY_TRACING_SKIP_TRIANGLES_BIT_KHR.");
4842 }
4843 }
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004844 auto feedback_struct = LvlFindInChain<VkPipelineCreationFeedbackCreateInfoEXT>(pCreateInfos[i].pNext);
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004845 if ((feedback_struct != nullptr) && (feedback_struct->pipelineStageCreationFeedbackCount != pCreateInfos[i].stageCount)) {
4846 skip |= LogError(device, "VUID-VkPipelineCreationFeedbackCreateInfoEXT-pipelineStageCreationFeedbackCount-02670",
sourav parmarcd5fb182020-07-17 12:58:44 -07004847 "vkCreateRayTracingPipelinesKHR: in pCreateInfo[%" PRIu32
4848 "], When chained to VkRayTracingPipelineCreateInfoKHR, "
4849 "VkPipelineCreationFeedbackEXT::pipelineStageCreationFeedbackCount"
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004850 "(=%" PRIu32 ") must equal VkRayTracingPipelineCreateInfoKHR::stageCount(=%" PRIu32 ").",
4851 i, feedback_struct->pipelineStageCreationFeedbackCount, pCreateInfos[i].stageCount);
4852 }
sourav parmara96ab1a2020-04-25 16:28:23 -07004853 const auto *pipeline_cache_contol_features =
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004854 LvlFindInChain<VkPhysicalDevicePipelineCreationCacheControlFeaturesEXT>(device_createinfo_pnext);
sourav parmara96ab1a2020-04-25 16:28:23 -07004855 if (!pipeline_cache_contol_features || pipeline_cache_contol_features->pipelineCreationCacheControl == VK_FALSE) {
4856 if (pCreateInfos[i].flags & (VK_PIPELINE_CREATE_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT_EXT |
4857 VK_PIPELINE_CREATE_EARLY_RETURN_ON_FAILURE_BIT_EXT)) {
4858 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-pipelineCreationCacheControl-02905",
sourav parmarcd5fb182020-07-17 12:58:44 -07004859 "vkCreateRayTracingPipelinesKHR: If the pipelineCreationCacheControl feature is not enabled,"
sourav parmara96ab1a2020-04-25 16:28:23 -07004860 "flags must not include VK_PIPELINE_CREATE_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT_EXT or"
4861 "VK_PIPELINE_CREATE_EARLY_RETURN_ON_FAILURE_BIT_EXT.");
4862 }
4863 }
sourav parmarf4a78252020-04-10 13:04:21 -07004864 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_INDIRECT_BINDABLE_BIT_NV) {
sourav parmarcd5fb182020-07-17 12:58:44 -07004865 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-02904",
4866 "vkCreateRayTracingPipelinesKHR: flags must not include VK_PIPELINE_CREATE_INDIRECT_BINDABLE_BIT_NV.");
sourav parmarf4a78252020-04-10 13:04:21 -07004867 }
4868 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_LIBRARY_BIT_KHR) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07004869 if (pCreateInfos[i].pLibraryInterface == NULL) {
sourav parmarf4a78252020-04-10 13:04:21 -07004870 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-03465",
sourav parmarcd5fb182020-07-17 12:58:44 -07004871 "vkCreateRayTracingPipelinesKHR: If flags includes VK_PIPELINE_CREATE_LIBRARY_BIT_KHR, "
4872 "pLibraryInterface must not be NULL.");
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07004873 }
sourav parmarcd5fb182020-07-17 12:58:44 -07004874 }
4875 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_DISPATCH_BASE) {
4876 skip |= LogError(device, "VUID-vkCreateRayTracingPipelinesKHR-flags-03816",
4877 "vkCreateRayTracingPipelinesKHR: flags must not contain the VK_PIPELINE_CREATE_DISPATCH_BASE flag.");
sourav parmarf4a78252020-04-10 13:04:21 -07004878 }
4879 for (uint32_t group_index = 0; group_index < pCreateInfos[i].groupCount; ++group_index) {
4880 if ((pCreateInfos[i].pGroups[group_index].type == VK_RAY_TRACING_SHADER_GROUP_TYPE_TRIANGLES_HIT_GROUP_KHR) ||
4881 (pCreateInfos[i].pGroups[group_index].type == VK_RAY_TRACING_SHADER_GROUP_TYPE_PROCEDURAL_HIT_GROUP_KHR)) {
4882 if ((pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_ANY_HIT_SHADERS_BIT_KHR) &&
4883 (pCreateInfos[i].pGroups[group_index].anyHitShader == VK_SHADER_UNUSED_KHR)) {
4884 skip |= LogError(
4885 device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-03470",
sourav parmarcd5fb182020-07-17 12:58:44 -07004886 "vkCreateRayTracingPipelinesKHR: If flags includes "
4887 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_ANY_HIT_SHADERS_BIT_KHR,"
sourav parmarf4a78252020-04-10 13:04:21 -07004888 "for any element of pGroups with a type of VK_RAY_TRACING_SHADER_GROUP_TYPE_TRIANGLES_HIT_GROUP_KHR"
4889 "or VK_RAY_TRACING_SHADER_GROUP_TYPE_PROCEDURAL_HIT_GROUP_KHR, the anyHitShader of that element "
4890 "must not be VK_SHADER_UNUSED_KHR");
4891 }
4892 if ((pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_CLOSEST_HIT_SHADERS_BIT_KHR) &&
4893 (pCreateInfos[i].pGroups[group_index].closestHitShader == VK_SHADER_UNUSED_KHR)) {
4894 skip |= LogError(
4895 device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-03471",
sourav parmarcd5fb182020-07-17 12:58:44 -07004896 "vkCreateRayTracingPipelinesKHR: If flags includes "
4897 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_CLOSEST_HIT_SHADERS_BIT_KHR,"
sourav parmarf4a78252020-04-10 13:04:21 -07004898 "for any element of pGroups with a type of VK_RAY_TRACING_SHADER_GROUP_TYPE_TRIANGLES_HIT_GROUP_KHR"
4899 "or VK_RAY_TRACING_SHADER_GROUP_TYPE_PROCEDURAL_HIT_GROUP_KHR, the closestHitShader of that "
4900 "element must not be VK_SHADER_UNUSED_KHR");
4901 }
4902 }
sourav parmarcd5fb182020-07-17 12:58:44 -07004903 if (raytracing_features && raytracing_features->rayTracingPipelineShaderGroupHandleCaptureReplay == VK_TRUE &&
4904 pCreateInfos[i].pGroups[group_index].pShaderGroupCaptureReplayHandle) {
4905 if (!(pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_SHADER_GROUP_HANDLE_CAPTURE_REPLAY_BIT_KHR)) {
4906 skip |= LogError(
4907 device, "VUID-VkRayTracingPipelineCreateInfoKHR-rayTracingPipelineShaderGroupHandleCaptureReplay-03599",
4908 "vkCreateRayTracingPipelinesKHR: If "
4909 "VkPhysicalDeviceRayTracingPipelineFeaturesKHR::rayTracingPipelineShaderGroupHandleCaptureReplay is "
4910 "VK_TRUE and the pShaderGroupCaptureReplayHandle member of any element of pGroups is not NULL, flags must "
4911 "include VK_PIPELINE_CREATE_RAY_TRACING_SHADER_GROUP_HANDLE_CAPTURE_REPLAY_BIT_KHR.");
4912 }
4913 }
sourav parmarf4a78252020-04-10 13:04:21 -07004914 }
4915 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_DERIVATIVE_BIT) {
4916 if (pCreateInfos[i].basePipelineIndex != -1) {
4917 if (pCreateInfos[i].basePipelineHandle != VK_NULL_HANDLE) {
4918 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-03423",
sourav parmarcd5fb182020-07-17 12:58:44 -07004919 "vkCreateRayTracingPipelinesKHR: parameter, pCreateInfos->basePipelineHandle, must be "
sourav parmarf4a78252020-04-10 13:04:21 -07004920 "VK_NULL_HANDLE if pCreateInfos->flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT flag "
4921 "and pCreateInfos->basePipelineIndex is not -1.");
4922 }
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07004923 if (pCreateInfos[i].basePipelineIndex > static_cast<int32_t>(i)) {
sourav parmara24fb7b2020-05-26 10:50:04 -07004924 skip |=
4925 LogError(device, "VUID-vkCreateRayTracingPipelinesKHR-flags-03415",
4926 "vkCreateRayTracingPipelinesKHR: If the flags member of any element of pCreateInfos contains the"
4927 "VK_PIPELINE_CREATE_DERIVATIVE_BIT flag, and the basePipelineIndex member of that same element is"
4928 "not -1, basePipelineIndex must be less than the index into pCreateInfos that corresponds to that "
4929 "element.");
4930 }
sourav parmarf4a78252020-04-10 13:04:21 -07004931 }
4932 if (pCreateInfos[i].basePipelineHandle == VK_NULL_HANDLE) {
David Netod9d7b762020-07-27 15:37:58 -04004933 if (static_cast<uint32_t>(pCreateInfos[i].basePipelineIndex) >= createInfoCount) {
sourav parmarf4a78252020-04-10 13:04:21 -07004934 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-03422",
sourav parmarcd5fb182020-07-17 12:58:44 -07004935 "vkCreateRayTracingPipelinesKHR: if flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT and"
sourav parmarf4a78252020-04-10 13:04:21 -07004936 "basePipelineHandle is VK_NULL_HANDLE, basePipelineIndex (%d) must be a valid into the calling"
4937 "commands pCreateInfos parameter %d.",
4938 pCreateInfos[i].basePipelineIndex, createInfoCount);
4939 }
4940 } else {
4941 if (pCreateInfos[i].basePipelineIndex != -1) {
4942 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-03424",
sourav parmarcd5fb182020-07-17 12:58:44 -07004943 "vkCreateRayTracingPipelinesKHR: if flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT and"
sourav parmarf4a78252020-04-10 13:04:21 -07004944 "basePipelineHandle is not VK_NULL_HANDLE, basePipelineIndex must be -1.");
4945 }
4946 }
4947 }
sourav parmarcd5fb182020-07-17 12:58:44 -07004948 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_SHADER_GROUP_HANDLE_CAPTURE_REPLAY_BIT_KHR &&
4949 (raytracing_features && raytracing_features->rayTracingPipelineShaderGroupHandleCaptureReplay == VK_FALSE)) {
4950 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-03598",
4951 "vkCreateRayTracingPipelinesKHR: If flags includes "
4952 "VK_PIPELINE_CREATE_RAY_TRACING_SHADER_GROUP_HANDLE_CAPTURE_REPLAY_BIT_KHR, "
4953 "rayTracingPipelineShaderGroupHandleCaptureReplay must be enabled.");
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004954 }
4955 bool library_enabled = IsExtEnabled(device_extensions.vk_khr_pipeline_library);
4956 if (!library_enabled && (pCreateInfos[i].pLibraryInfo || pCreateInfos[i].pLibraryInterface)) {
4957 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-pLibraryInfo-03595",
4958 "vkCreateRayTracingPipelinesKHR: If the VK_KHR_pipeline_library extension is not enabled, "
4959 "pLibraryInfo and pLibraryInterface must be NULL.");
4960 }
4961 if (pCreateInfos[i].pLibraryInfo) {
4962 if (pCreateInfos[i].pLibraryInfo->libraryCount == 0) {
4963 if (pCreateInfos[i].stageCount == 0) {
4964 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-pLibraryInfo-03600",
4965 "vkCreateRayTracingPipelinesKHR: If pLibraryInfo is not NULL and its libraryCount is 0, "
4966 "stageCount must not be 0.");
4967 }
4968 if (pCreateInfos[i].groupCount == 0) {
4969 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-pLibraryInfo-03601",
4970 "vkCreateRayTracingPipelinesKHR: If pLibraryInfo is not NULL and its libraryCount is 0, "
4971 "groupCount must not be 0.");
4972 }
4973 } else {
4974 if (pCreateInfos[i].pLibraryInterface == NULL) {
4975 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-pLibraryInfo-03590",
4976 "vkCreateRayTracingPipelinesKHR: If pLibraryInfo is not NULL and its libraryCount member "
4977 "is greater than 0, its "
4978 "pLibraryInterface member must not be NULL.");
sourav parmarcd5fb182020-07-17 12:58:44 -07004979 }
4980 }
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004981 }
4982 if (pCreateInfos[i].pLibraryInterface) {
4983 if (pCreateInfos[i].pLibraryInterface->maxPipelineRayHitAttributeSize >
4984 phys_dev_ext_props.ray_tracing_propsKHR.maxRayHitAttributeSize) {
4985 skip |= LogError(device, "VUID-VkRayTracingPipelineInterfaceCreateInfoKHR-maxPipelineRayHitAttributeSize-03605",
4986 "vkCreateRayTracingPipelinesKHR: maxPipelineRayHitAttributeSize must be less than or equal to "
4987 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::maxRayHitAttributeSize.");
4988 }
sourav parmarcd5fb182020-07-17 12:58:44 -07004989 }
4990 if (deferredOperation != VK_NULL_HANDLE) {
4991 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_EARLY_RETURN_ON_FAILURE_BIT_EXT) {
4992 skip |= LogError(device, "VUID-vkCreateRayTracingPipelinesKHR-deferredOperation-03587",
4993 "vkCreateRayTracingPipelinesKHR: If deferredOperation is not VK_NULL_HANDLE, the flags member of "
4994 "elements of pCreateInfos must not include VK_PIPELINE_CREATE_EARLY_RETURN_ON_FAILURE_BIT_EXT.");
sourav parmarf4a78252020-04-10 13:04:21 -07004995 }
4996 }
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004997 }
4998
4999 return skip;
5000}
5001
Mike Schuchardt21638df2019-03-16 10:52:02 -07005002#ifdef VK_USE_PLATFORM_WIN32_KHR
5003bool StatelessValidation::PreCallValidateGetDeviceGroupSurfacePresentModes2EXT(VkDevice device,
5004 const VkPhysicalDeviceSurfaceInfo2KHR *pSurfaceInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -05005005 VkDeviceGroupPresentModeFlagsKHR *pModes) const {
Mike Schuchardt21638df2019-03-16 10:52:02 -07005006 bool skip = false;
5007 if (!device_extensions.vk_khr_swapchain)
5008 skip |= OutputExtensionError("vkGetDeviceGroupSurfacePresentModes2EXT", VK_KHR_SWAPCHAIN_EXTENSION_NAME);
5009 if (!device_extensions.vk_khr_get_surface_capabilities_2)
5010 skip |= OutputExtensionError("vkGetDeviceGroupSurfacePresentModes2EXT", VK_KHR_GET_SURFACE_CAPABILITIES_2_EXTENSION_NAME);
5011 if (!device_extensions.vk_khr_surface)
5012 skip |= OutputExtensionError("vkGetDeviceGroupSurfacePresentModes2EXT", VK_KHR_SURFACE_EXTENSION_NAME);
5013 if (!device_extensions.vk_khr_get_physical_device_properties_2)
5014 skip |=
5015 OutputExtensionError("vkGetDeviceGroupSurfacePresentModes2EXT", VK_KHR_GET_PHYSICAL_DEVICE_PROPERTIES_2_EXTENSION_NAME);
5016 if (!device_extensions.vk_ext_full_screen_exclusive)
5017 skip |= OutputExtensionError("vkGetDeviceGroupSurfacePresentModes2EXT", VK_EXT_FULL_SCREEN_EXCLUSIVE_EXTENSION_NAME);
5018 skip |= validate_struct_type(
5019 "vkGetDeviceGroupSurfacePresentModes2EXT", "pSurfaceInfo", "VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SURFACE_INFO_2_KHR",
5020 pSurfaceInfo, VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SURFACE_INFO_2_KHR, true,
5021 "VUID-vkGetDeviceGroupSurfacePresentModes2EXT-pSurfaceInfo-parameter", "VUID-VkPhysicalDeviceSurfaceInfo2KHR-sType-sType");
5022 if (pSurfaceInfo != NULL) {
5023 const VkStructureType allowed_structs_VkPhysicalDeviceSurfaceInfo2KHR[] = {
5024 VK_STRUCTURE_TYPE_SURFACE_FULL_SCREEN_EXCLUSIVE_INFO_EXT,
5025 VK_STRUCTURE_TYPE_SURFACE_FULL_SCREEN_EXCLUSIVE_WIN32_INFO_EXT};
5026
5027 skip |= validate_struct_pnext("vkGetDeviceGroupSurfacePresentModes2EXT", "pSurfaceInfo->pNext",
5028 "VkSurfaceFullScreenExclusiveInfoEXT, VkSurfaceFullScreenExclusiveWin32InfoEXT",
5029 pSurfaceInfo->pNext, ARRAY_SIZE(allowed_structs_VkPhysicalDeviceSurfaceInfo2KHR),
5030 allowed_structs_VkPhysicalDeviceSurfaceInfo2KHR, GeneratedVulkanHeaderVersion,
sfricke-samsung32a27362020-02-28 09:06:42 -08005031 "VUID-VkPhysicalDeviceSurfaceInfo2KHR-pNext-pNext",
5032 "VUID-VkPhysicalDeviceSurfaceInfo2KHR-sType-unique");
Mike Schuchardt21638df2019-03-16 10:52:02 -07005033
5034 skip |= validate_required_handle("vkGetDeviceGroupSurfacePresentModes2EXT", "pSurfaceInfo->surface", pSurfaceInfo->surface);
5035 }
5036 return skip;
5037}
5038#endif
Tobias Hectorebb855f2019-07-23 12:17:33 +01005039
5040bool StatelessValidation::manual_PreCallValidateCreateFramebuffer(VkDevice device, const VkFramebufferCreateInfo *pCreateInfo,
5041 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05005042 VkFramebuffer *pFramebuffer) const {
Tobias Hectorebb855f2019-07-23 12:17:33 +01005043 // Validation for pAttachments which is excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
5044 bool skip = false;
Mike Schuchardt2df08912020-12-15 16:28:09 -08005045 if ((pCreateInfo->flags & VK_FRAMEBUFFER_CREATE_IMAGELESS_BIT) == 0) {
Tobias Hectorebb855f2019-07-23 12:17:33 +01005046 skip |= validate_array("vkCreateFramebuffer", "attachmentCount", "pAttachments", pCreateInfo->attachmentCount,
5047 &pCreateInfo->pAttachments, false, true, kVUIDUndefined, kVUIDUndefined);
5048 }
5049 return skip;
5050}
Jeff Bolz8125a8b2019-08-16 16:29:45 -05005051
5052bool StatelessValidation::manual_PreCallValidateCmdSetLineStippleEXT(VkCommandBuffer commandBuffer, uint32_t lineStippleFactor,
Jeff Bolz5c801d12019-10-09 10:38:45 -05005053 uint16_t lineStipplePattern) const {
Jeff Bolz8125a8b2019-08-16 16:29:45 -05005054 bool skip = false;
5055
5056 if (lineStippleFactor < 1 || lineStippleFactor > 256) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005057 skip |= LogError(commandBuffer, "VUID-vkCmdSetLineStippleEXT-lineStippleFactor-02776",
5058 "vkCmdSetLineStippleEXT::lineStippleFactor=%d is not in [1,256].", lineStippleFactor);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05005059 }
5060
5061 return skip;
5062}
Piers Daniell8fd03f52019-08-21 12:07:53 -06005063
5064bool StatelessValidation::manual_PreCallValidateCmdBindIndexBuffer(VkCommandBuffer commandBuffer, VkBuffer buffer,
Jeff Bolz5c801d12019-10-09 10:38:45 -05005065 VkDeviceSize offset, VkIndexType indexType) const {
Piers Daniell8fd03f52019-08-21 12:07:53 -06005066 bool skip = false;
5067
5068 if (indexType == VK_INDEX_TYPE_NONE_NV) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005069 skip |= LogError(commandBuffer, "VUID-vkCmdBindIndexBuffer-indexType-02507",
5070 "vkCmdBindIndexBuffer() indexType must not be VK_INDEX_TYPE_NONE_NV.");
Piers Daniell8fd03f52019-08-21 12:07:53 -06005071 }
5072
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005073 const auto *index_type_uint8_features = LvlFindInChain<VkPhysicalDeviceIndexTypeUint8FeaturesEXT>(device_createinfo_pnext);
Mark Lobodzinski804fde82020-05-08 07:49:25 -06005074 if (indexType == VK_INDEX_TYPE_UINT8_EXT && (!index_type_uint8_features || !index_type_uint8_features->indexTypeUint8)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005075 skip |= LogError(commandBuffer, "VUID-vkCmdBindIndexBuffer-indexType-02765",
5076 "vkCmdBindIndexBuffer() indexType is VK_INDEX_TYPE_UINT8_EXT but indexTypeUint8 feature is not enabled.");
Piers Daniell8fd03f52019-08-21 12:07:53 -06005077 }
5078
5079 return skip;
5080}
Mark Lobodzinski84988402019-09-11 15:27:30 -06005081
sfricke-samsung4ada8d42020-02-09 17:43:11 -08005082bool StatelessValidation::manual_PreCallValidateCmdBindVertexBuffers(VkCommandBuffer commandBuffer, uint32_t firstBinding,
5083 uint32_t bindingCount, const VkBuffer *pBuffers,
5084 const VkDeviceSize *pOffsets) const {
5085 bool skip = false;
5086 if (firstBinding > device_limits.maxVertexInputBindings) {
5087 skip |= LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers-firstBinding-00624",
5088 "vkCmdBindVertexBuffers() firstBinding (%u) must be less than maxVertexInputBindings (%u)", firstBinding,
5089 device_limits.maxVertexInputBindings);
5090 } else if ((firstBinding + bindingCount) > device_limits.maxVertexInputBindings) {
5091 skip |= LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers-firstBinding-00625",
5092 "vkCmdBindVertexBuffers() sum of firstBinding (%u) and bindingCount (%u) must be less than "
5093 "maxVertexInputBindings (%u)",
5094 firstBinding, bindingCount, device_limits.maxVertexInputBindings);
5095 }
5096
Jeff Bolz165818a2020-05-08 11:19:03 -05005097 for (uint32_t i = 0; i < bindingCount; ++i) {
5098 if (pBuffers[i] == VK_NULL_HANDLE) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005099 const auto *robustness2_features = LvlFindInChain<VkPhysicalDeviceRobustness2FeaturesEXT>(device_createinfo_pnext);
Jeff Bolz165818a2020-05-08 11:19:03 -05005100 if (!(robustness2_features && robustness2_features->nullDescriptor)) {
5101 skip |= LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers-pBuffers-04001",
5102 "vkCmdBindVertexBuffers() required parameter pBuffers[%d] specified as VK_NULL_HANDLE", i);
5103 } else {
5104 if (pOffsets[i] != 0) {
5105 skip |= LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers-pBuffers-04002",
5106 "vkCmdBindVertexBuffers() pBuffers[%d] is VK_NULL_HANDLE, but pOffsets[%d] is not 0", i, i);
5107 }
5108 }
5109 }
5110 }
5111
sfricke-samsung4ada8d42020-02-09 17:43:11 -08005112 return skip;
5113}
5114
Mark Lobodzinski84988402019-09-11 15:27:30 -06005115bool StatelessValidation::manual_PreCallValidateSetDebugUtilsObjectNameEXT(VkDevice device,
Jeff Bolz5c801d12019-10-09 10:38:45 -05005116 const VkDebugUtilsObjectNameInfoEXT *pNameInfo) const {
Mark Lobodzinski84988402019-09-11 15:27:30 -06005117 bool skip = false;
5118 if (pNameInfo->objectType == VK_OBJECT_TYPE_UNKNOWN) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005119 skip |= LogError(device, "VUID-VkDebugUtilsObjectNameInfoEXT-objectType-02589",
5120 "vkSetDebugUtilsObjectNameEXT() pNameInfo->objectType cannot be VK_OBJECT_TYPE_UNKNOWN.");
Mark Lobodzinski84988402019-09-11 15:27:30 -06005121 }
5122 return skip;
5123}
5124
5125bool StatelessValidation::manual_PreCallValidateSetDebugUtilsObjectTagEXT(VkDevice device,
Jeff Bolz5c801d12019-10-09 10:38:45 -05005126 const VkDebugUtilsObjectTagInfoEXT *pTagInfo) const {
Mark Lobodzinski84988402019-09-11 15:27:30 -06005127 bool skip = false;
5128 if (pTagInfo->objectType == VK_OBJECT_TYPE_UNKNOWN) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005129 skip |= LogError(device, "VUID-VkDebugUtilsObjectTagInfoEXT-objectType-01908",
5130 "vkSetDebugUtilsObjectTagEXT() pTagInfo->objectType cannot be VK_OBJECT_TYPE_UNKNOWN.");
Mark Lobodzinski84988402019-09-11 15:27:30 -06005131 }
5132 return skip;
5133}
Petr Kraus3d720392019-11-13 02:52:39 +01005134
5135bool StatelessValidation::manual_PreCallValidateAcquireNextImageKHR(VkDevice device, VkSwapchainKHR swapchain, uint64_t timeout,
5136 VkSemaphore semaphore, VkFence fence,
5137 uint32_t *pImageIndex) const {
5138 bool skip = false;
5139
5140 if (semaphore == VK_NULL_HANDLE && fence == VK_NULL_HANDLE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005141 skip |= LogError(swapchain, "VUID-vkAcquireNextImageKHR-semaphore-01780",
5142 "vkAcquireNextImageKHR: semaphore and fence are both VK_NULL_HANDLE.");
Petr Kraus3d720392019-11-13 02:52:39 +01005143 }
5144
5145 return skip;
5146}
5147
5148bool StatelessValidation::manual_PreCallValidateAcquireNextImage2KHR(VkDevice device, const VkAcquireNextImageInfoKHR *pAcquireInfo,
5149 uint32_t *pImageIndex) const {
5150 bool skip = false;
5151
5152 if (pAcquireInfo->semaphore == VK_NULL_HANDLE && pAcquireInfo->fence == VK_NULL_HANDLE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005153 skip |= LogError(pAcquireInfo->swapchain, "VUID-VkAcquireNextImageInfoKHR-semaphore-01782",
5154 "vkAcquireNextImage2KHR: pAcquireInfo->semaphore and pAcquireInfo->fence are both VK_NULL_HANDLE.");
Petr Kraus3d720392019-11-13 02:52:39 +01005155 }
5156
5157 return skip;
5158}
Mark Lobodzinski953b7bc2019-12-19 13:50:10 -07005159
Jeremy Hayes9bda85a2020-05-21 16:36:17 -06005160bool StatelessValidation::manual_PreCallValidateCmdBindTransformFeedbackBuffersEXT(VkCommandBuffer commandBuffer,
5161 uint32_t firstBinding, uint32_t bindingCount,
5162 const VkBuffer *pBuffers,
5163 const VkDeviceSize *pOffsets,
5164 const VkDeviceSize *pSizes) const {
5165 bool skip = false;
5166
5167 char const *const cmd_name = "CmdBindTransformFeedbackBuffersEXT";
5168 for (uint32_t i = 0; i < bindingCount; ++i) {
5169 if (pOffsets[i] & 3) {
5170 skip |= LogError(commandBuffer, "VUID-vkCmdBindTransformFeedbackBuffersEXT-pOffsets-02359",
5171 "%s: pOffsets[%" PRIu32 "](0x%" PRIxLEAST64 ") is not a multiple of 4.", cmd_name, i, pOffsets[i]);
5172 }
5173 }
5174
5175 if (firstBinding >= phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers) {
5176 skip |= LogError(commandBuffer, "VUID-vkCmdBindTransformFeedbackBuffersEXT-firstBinding-02356",
5177 "%s: The firstBinding(%" PRIu32
5178 ") index is greater than or equal to "
5179 "VkPhysicalDeviceTransformFeedbackPropertiesEXT::maxTransformFeedbackBuffers(%" PRIu32 ").",
5180 cmd_name, firstBinding, phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers);
5181 }
5182
5183 if (firstBinding + bindingCount > phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers) {
5184 skip |=
5185 LogError(commandBuffer, "VUID-vkCmdBindTransformFeedbackBuffersEXT-firstBinding-02357",
5186 "%s: The sum of firstBinding(%" PRIu32 ") and bindCount(%" PRIu32
5187 ") is greater than VkPhysicalDeviceTransformFeedbackPropertiesEXT::maxTransformFeedbackBuffers(%" PRIu32 ").",
5188 cmd_name, firstBinding, bindingCount, phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers);
5189 }
5190
5191 for (uint32_t i = 0; i < bindingCount; ++i) {
5192 // pSizes is optional and may be nullptr.
5193 if (pSizes != nullptr) {
5194 if (pSizes[i] != VK_WHOLE_SIZE &&
5195 pSizes[i] > phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBufferSize) {
5196 skip |= LogError(commandBuffer, "VUID-vkCmdBindTransformFeedbackBuffersEXT-pSize-02361",
5197 "%s: pSizes[%" PRIu32 "] (0x%" PRIxLEAST64
5198 ") is not VK_WHOLE_SIZE and is greater than "
5199 "VkPhysicalDeviceTransformFeedbackPropertiesEXT::maxTransformFeedbackBufferSize.",
5200 cmd_name, i, pSizes[i]);
5201 }
5202 }
5203 }
5204
5205 return skip;
5206}
5207
5208bool StatelessValidation::manual_PreCallValidateCmdBeginTransformFeedbackEXT(VkCommandBuffer commandBuffer,
5209 uint32_t firstCounterBuffer,
5210 uint32_t counterBufferCount,
5211 const VkBuffer *pCounterBuffers,
5212 const VkDeviceSize *pCounterBufferOffsets) const {
5213 bool skip = false;
5214
5215 char const *const cmd_name = "CmdBeginTransformFeedbackEXT";
5216 if (firstCounterBuffer >= phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers) {
5217 skip |= LogError(commandBuffer, "VUID-vkCmdBeginTransformFeedbackEXT-firstCounterBuffer-02368",
5218 "%s: The firstCounterBuffer(%" PRIu32
5219 ") index is greater than or equal to "
5220 "VkPhysicalDeviceTransformFeedbackPropertiesEXT::maxTransformFeedbackBuffers(%" PRIu32 ").",
5221 cmd_name, firstCounterBuffer, phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers);
5222 }
5223
5224 if (firstCounterBuffer + counterBufferCount > phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers) {
5225 skip |=
5226 LogError(commandBuffer, "VUID-vkCmdBeginTransformFeedbackEXT-firstCounterBuffer-02369",
5227 "%s: The sum of firstCounterBuffer(%" PRIu32 ") and counterBufferCount(%" PRIu32
5228 ") is greater than VkPhysicalDeviceTransformFeedbackPropertiesEXT::maxTransformFeedbackBuffers(%" PRIu32 ").",
5229 cmd_name, firstCounterBuffer, counterBufferCount,
5230 phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers);
5231 }
5232
5233 return skip;
5234}
5235
5236bool StatelessValidation::manual_PreCallValidateCmdEndTransformFeedbackEXT(VkCommandBuffer commandBuffer,
5237 uint32_t firstCounterBuffer, uint32_t counterBufferCount,
5238 const VkBuffer *pCounterBuffers,
5239 const VkDeviceSize *pCounterBufferOffsets) const {
5240 bool skip = false;
5241
5242 char const *const cmd_name = "CmdEndTransformFeedbackEXT";
5243 if (firstCounterBuffer >= phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers) {
5244 skip |= LogError(commandBuffer, "VUID-vkCmdEndTransformFeedbackEXT-firstCounterBuffer-02376",
5245 "%s: The firstCounterBuffer(%" PRIu32
5246 ") index is greater than or equal to "
5247 "VkPhysicalDeviceTransformFeedbackPropertiesEXT::maxTransformFeedbackBuffers(%" PRIu32 ").",
5248 cmd_name, firstCounterBuffer, phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers);
5249 }
5250
5251 if (firstCounterBuffer + counterBufferCount > phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers) {
5252 skip |=
5253 LogError(commandBuffer, "VUID-vkCmdEndTransformFeedbackEXT-firstCounterBuffer-02377",
5254 "%s: The sum of firstCounterBuffer(%" PRIu32 ") and counterBufferCount(%" PRIu32
5255 ") is greater than VkPhysicalDeviceTransformFeedbackPropertiesEXT::maxTransformFeedbackBuffers(%" PRIu32 ").",
5256 cmd_name, firstCounterBuffer, counterBufferCount,
5257 phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers);
5258 }
5259
5260 return skip;
5261}
5262
Mark Lobodzinski953b7bc2019-12-19 13:50:10 -07005263bool StatelessValidation::manual_PreCallValidateCmdDrawIndirectByteCountEXT(VkCommandBuffer commandBuffer, uint32_t instanceCount,
5264 uint32_t firstInstance, VkBuffer counterBuffer,
5265 VkDeviceSize counterBufferOffset,
5266 uint32_t counterOffset, uint32_t vertexStride) const {
5267 bool skip = false;
5268
5269 if ((vertexStride <= 0) || (vertexStride > phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBufferDataStride)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005270 skip |= LogError(
5271 counterBuffer, "VUID-vkCmdDrawIndirectByteCountEXT-vertexStride-02289",
Mark Lobodzinski953b7bc2019-12-19 13:50:10 -07005272 "vkCmdDrawIndirectByteCountEXT: vertexStride (%d) must be between 0 and maxTransformFeedbackBufferDataStride (%d).",
5273 vertexStride, phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBufferDataStride);
5274 }
5275
sfricke-samsungd5e9adb2020-10-26 03:59:29 -07005276 if ((counterOffset % 4) != 0) {
sfricke-samsung6886c4b2021-01-16 08:37:35 -08005277 skip |= LogError(commandBuffer, "VUID-vkCmdDrawIndirectByteCountEXT-counterBufferOffset-04568",
sfricke-samsungd5e9adb2020-10-26 03:59:29 -07005278 "vkCmdDrawIndirectByteCountEXT(): offset (%" PRIu64 ") must be a multiple of 4.", counterOffset);
5279 }
5280
Mark Lobodzinski953b7bc2019-12-19 13:50:10 -07005281 return skip;
5282}
sfricke-samsung11ea8ed2020-01-07 22:24:56 -08005283
5284bool StatelessValidation::ValidateCreateSamplerYcbcrConversion(VkDevice device,
5285 const VkSamplerYcbcrConversionCreateInfo *pCreateInfo,
5286 const VkAllocationCallbacks *pAllocator,
5287 VkSamplerYcbcrConversion *pYcbcrConversion,
5288 const char *apiName) const {
5289 bool skip = false;
5290
5291 // Check samplerYcbcrConversion feature is set
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005292 const auto *ycbcr_features = LvlFindInChain<VkPhysicalDeviceSamplerYcbcrConversionFeatures>(device_createinfo_pnext);
sfricke-samsung11ea8ed2020-01-07 22:24:56 -08005293 if ((ycbcr_features == nullptr) || (ycbcr_features->samplerYcbcrConversion == VK_FALSE)) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005294 const auto *vulkan_11_features = LvlFindInChain<VkPhysicalDeviceVulkan11Features>(device_createinfo_pnext);
Ricardo Garcia3a34ffb2020-06-24 09:36:18 +02005295 if ((vulkan_11_features == nullptr) || (vulkan_11_features->samplerYcbcrConversion == VK_FALSE)) {
5296 skip |= LogError(device, "VUID-vkCreateSamplerYcbcrConversion-None-01648",
sfricke-samsung83d98122020-07-04 06:21:15 -07005297 "%s: samplerYcbcrConversion must be enabled.", apiName);
Ricardo Garcia3a34ffb2020-06-24 09:36:18 +02005298 }
sfricke-samsung11ea8ed2020-01-07 22:24:56 -08005299 }
sfricke-samsung83d98122020-07-04 06:21:15 -07005300
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005301#ifdef VK_USE_PLATFORM_ANDROID_KHR
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005302 const VkExternalFormatANDROID *external_format_android = LvlFindInChain<VkExternalFormatANDROID>(pCreateInfo);
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07005303 const bool is_external_format = external_format_android != nullptr && external_format_android->externalFormat != 0;
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005304#else
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07005305 const bool is_external_format = false;
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005306#endif
5307
sfricke-samsung1a72f942020-07-25 12:09:18 -07005308 const VkFormat format = pCreateInfo->format;
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005309
5310 // If there is a VkExternalFormatANDROID with externalFormat != 0, the value of components is ignored.
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07005311 if (!is_external_format) {
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005312 const VkComponentMapping components = pCreateInfo->components;
5313 // XChroma Subsampled is same as "the format has a _422 or _420 suffix" from spec
5314 if (FormatIsXChromaSubsampled(format) == true) {
5315 if ((components.g != VK_COMPONENT_SWIZZLE_G) && (components.g != VK_COMPONENT_SWIZZLE_IDENTITY)) {
5316 skip |=
5317 LogError(device, "VUID-VkSamplerYcbcrConversionCreateInfo-components-02581",
sfricke-samsung83d98122020-07-04 06:21:15 -07005318 "%s: When using a XChroma subsampled format (%s) the components.g needs to be VK_COMPONENT_SWIZZLE_G "
5319 "or VK_COMPONENT_SWIZZLE_IDENTITY, but is %s.",
sfricke-samsung1a72f942020-07-25 12:09:18 -07005320 apiName, string_VkFormat(format), string_VkComponentSwizzle(components.g));
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005321 }
sfricke-samsung83d98122020-07-04 06:21:15 -07005322
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005323 if ((components.a != VK_COMPONENT_SWIZZLE_A) && (components.a != VK_COMPONENT_SWIZZLE_IDENTITY) &&
5324 (components.a != VK_COMPONENT_SWIZZLE_ONE) && (components.a != VK_COMPONENT_SWIZZLE_ZERO)) {
5325 skip |= LogError(
5326 device, "VUID-VkSamplerYcbcrConversionCreateInfo-components-02582",
5327 "%s: When using a XChroma subsampled format (%s) the components.a needs to be VK_COMPONENT_SWIZZLE_A or "
5328 "VK_COMPONENT_SWIZZLE_IDENTITY or VK_COMPONENT_SWIZZLE_ONE or VK_COMPONENT_SWIZZLE_ZERO, but is %s.",
5329 apiName, string_VkFormat(format), string_VkComponentSwizzle(components.a));
5330 }
sfricke-samsung83d98122020-07-04 06:21:15 -07005331
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005332 if ((components.r != VK_COMPONENT_SWIZZLE_R) && (components.r != VK_COMPONENT_SWIZZLE_IDENTITY) &&
5333 (components.r != VK_COMPONENT_SWIZZLE_B)) {
5334 skip |=
5335 LogError(device, "VUID-VkSamplerYcbcrConversionCreateInfo-components-02583",
sfricke-samsung83d98122020-07-04 06:21:15 -07005336 "%s: When using a XChroma subsampled format (%s) the components.r needs to be VK_COMPONENT_SWIZZLE_R "
5337 "or VK_COMPONENT_SWIZZLE_IDENTITY or VK_COMPONENT_SWIZZLE_B, but is %s.",
sfricke-samsung1a72f942020-07-25 12:09:18 -07005338 apiName, string_VkFormat(format), string_VkComponentSwizzle(components.r));
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005339 }
sfricke-samsung83d98122020-07-04 06:21:15 -07005340
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005341 if ((components.b != VK_COMPONENT_SWIZZLE_B) && (components.b != VK_COMPONENT_SWIZZLE_IDENTITY) &&
5342 (components.b != VK_COMPONENT_SWIZZLE_R)) {
5343 skip |=
5344 LogError(device, "VUID-VkSamplerYcbcrConversionCreateInfo-components-02584",
sfricke-samsung83d98122020-07-04 06:21:15 -07005345 "%s: When using a XChroma subsampled format (%s) the components.b needs to be VK_COMPONENT_SWIZZLE_B "
5346 "or VK_COMPONENT_SWIZZLE_IDENTITY or VK_COMPONENT_SWIZZLE_R, but is %s.",
sfricke-samsung1a72f942020-07-25 12:09:18 -07005347 apiName, string_VkFormat(format), string_VkComponentSwizzle(components.b));
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005348 }
sfricke-samsung83d98122020-07-04 06:21:15 -07005349
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005350 // If one is identity, both need to be
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07005351 const bool r_identity = ((components.r == VK_COMPONENT_SWIZZLE_R) || (components.r == VK_COMPONENT_SWIZZLE_IDENTITY));
5352 const bool b_identity = ((components.b == VK_COMPONENT_SWIZZLE_B) || (components.b == VK_COMPONENT_SWIZZLE_IDENTITY));
5353 if ((r_identity != b_identity) && ((r_identity == true) || (b_identity == true))) {
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005354 skip |=
5355 LogError(device, "VUID-VkSamplerYcbcrConversionCreateInfo-components-02585",
sfricke-samsung83d98122020-07-04 06:21:15 -07005356 "%s: When using a XChroma subsampled format (%s) if either the components.r (%s) or components.b (%s) "
5357 "are an identity swizzle, then both need to be an identity swizzle.",
sfricke-samsung1a72f942020-07-25 12:09:18 -07005358 apiName, string_VkFormat(format), string_VkComponentSwizzle(components.r),
5359 string_VkComponentSwizzle(components.b));
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005360 }
sfricke-samsung1a72f942020-07-25 12:09:18 -07005361 }
5362
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005363 if (pCreateInfo->ycbcrModel != VK_SAMPLER_YCBCR_MODEL_CONVERSION_RGB_IDENTITY) {
5364 // Checks same VU multiple ways in order to give a more useful error message
5365 const char *vuid = "VUID-VkSamplerYcbcrConversionCreateInfo-ycbcrModel-01655";
5366 if ((components.r == VK_COMPONENT_SWIZZLE_ONE) || (components.r == VK_COMPONENT_SWIZZLE_ZERO) ||
5367 (components.g == VK_COMPONENT_SWIZZLE_ONE) || (components.g == VK_COMPONENT_SWIZZLE_ZERO) ||
5368 (components.b == VK_COMPONENT_SWIZZLE_ONE) || (components.b == VK_COMPONENT_SWIZZLE_ZERO)) {
5369 skip |= LogError(
5370 device, vuid,
5371 "%s: The ycbcrModel is not VK_SAMPLER_YCBCR_MODEL_CONVERSION_RGB_IDENTITY so components.r (%s), "
5372 "components.g (%s), nor components.b (%s) can't be VK_COMPONENT_SWIZZLE_ZERO or VK_COMPONENT_SWIZZLE_ONE.",
5373 apiName, string_VkComponentSwizzle(components.r), string_VkComponentSwizzle(components.g),
5374 string_VkComponentSwizzle(components.b));
5375 }
sfricke-samsung1a72f942020-07-25 12:09:18 -07005376
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005377 // "must not correspond to a channel which contains zero or one as a consequence of conversion to RGBA"
5378 // 4 channel format = no issue
5379 // 3 = no [a]
5380 // 2 = no [b,a]
5381 // 1 = no [g,b,a]
5382 // depth/stencil = no [g,b,a] (shouldn't ever occur, but no VU preventing it)
5383 const uint32_t channels = (FormatIsDepthOrStencil(format) == true) ? 1 : FormatChannelCount(format);
5384
5385 if ((channels < 4) && ((components.r == VK_COMPONENT_SWIZZLE_A) || (components.g == VK_COMPONENT_SWIZZLE_A) ||
5386 (components.b == VK_COMPONENT_SWIZZLE_A))) {
5387 skip |= LogError(device, vuid,
5388 "%s: The ycbcrModel is not VK_SAMPLER_YCBCR_MODEL_CONVERSION_RGB_IDENTITY so components.r (%s), "
5389 "components.g (%s), or components.b (%s) can't be VK_COMPONENT_SWIZZLE_A.",
5390 apiName, string_VkComponentSwizzle(components.r), string_VkComponentSwizzle(components.g),
5391 string_VkComponentSwizzle(components.b));
5392 } else if ((channels < 3) &&
5393 ((components.r == VK_COMPONENT_SWIZZLE_B) || (components.g == VK_COMPONENT_SWIZZLE_B) ||
5394 (components.b == VK_COMPONENT_SWIZZLE_B) || (components.b == VK_COMPONENT_SWIZZLE_IDENTITY))) {
5395 skip |= LogError(device, vuid,
5396 "%s: The ycbcrModel is not VK_SAMPLER_YCBCR_MODEL_CONVERSION_RGB_IDENTITY so components.r (%s), "
5397 "components.g (%s), or components.b (%s) can't be VK_COMPONENT_SWIZZLE_B "
5398 "(components.b also can't be VK_COMPONENT_SWIZZLE_IDENTITY).",
5399 apiName, string_VkComponentSwizzle(components.r), string_VkComponentSwizzle(components.g),
5400 string_VkComponentSwizzle(components.b));
5401 } else if ((channels < 2) &&
5402 ((components.r == VK_COMPONENT_SWIZZLE_G) || (components.g == VK_COMPONENT_SWIZZLE_G) ||
5403 (components.g == VK_COMPONENT_SWIZZLE_IDENTITY) || (components.b == VK_COMPONENT_SWIZZLE_G))) {
5404 skip |= LogError(device, vuid,
5405 "%s: The ycbcrModel is not VK_SAMPLER_YCBCR_MODEL_CONVERSION_RGB_IDENTITY so components.r (%s), "
5406 "components.g (%s), or components.b (%s) can't be VK_COMPONENT_SWIZZLE_G "
5407 "(components.g also can't be VK_COMPONENT_SWIZZLE_IDENTITY).",
5408 apiName, string_VkComponentSwizzle(components.r), string_VkComponentSwizzle(components.g),
5409 string_VkComponentSwizzle(components.b));
5410 }
sfricke-samsung83d98122020-07-04 06:21:15 -07005411 }
5412 }
5413
sfricke-samsung11ea8ed2020-01-07 22:24:56 -08005414 return skip;
5415}
5416
5417bool StatelessValidation::manual_PreCallValidateCreateSamplerYcbcrConversion(VkDevice device,
5418 const VkSamplerYcbcrConversionCreateInfo *pCreateInfo,
5419 const VkAllocationCallbacks *pAllocator,
5420 VkSamplerYcbcrConversion *pYcbcrConversion) const {
5421 return ValidateCreateSamplerYcbcrConversion(device, pCreateInfo, pAllocator, pYcbcrConversion,
5422 "vkCreateSamplerYcbcrConversion");
5423}
5424
5425bool StatelessValidation::manual_PreCallValidateCreateSamplerYcbcrConversionKHR(
5426 VkDevice device, const VkSamplerYcbcrConversionCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
5427 VkSamplerYcbcrConversion *pYcbcrConversion) const {
5428 return ValidateCreateSamplerYcbcrConversion(device, pCreateInfo, pAllocator, pYcbcrConversion,
5429 "vkCreateSamplerYcbcrConversionKHR");
5430}
sfricke-samsung1708a8c2020-02-10 00:35:06 -08005431
5432bool StatelessValidation::manual_PreCallValidateImportSemaphoreFdKHR(
5433 VkDevice device, const VkImportSemaphoreFdInfoKHR *pImportSemaphoreFdInfo) const {
5434 bool skip = false;
5435 VkExternalSemaphoreHandleTypeFlags supported_handle_types =
5436 VK_EXTERNAL_SEMAPHORE_HANDLE_TYPE_OPAQUE_FD_BIT | VK_EXTERNAL_SEMAPHORE_HANDLE_TYPE_SYNC_FD_BIT;
5437
5438 if (0 == (pImportSemaphoreFdInfo->handleType & supported_handle_types)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005439 skip |= LogError(device, "VUID-VkImportSemaphoreFdInfoKHR-handleType-01143",
5440 "vkImportSemaphoreFdKHR() to semaphore %s handleType %s is not one of the supported handleTypes (%s).",
5441 report_data->FormatHandle(pImportSemaphoreFdInfo->semaphore).c_str(),
5442 string_VkExternalSemaphoreHandleTypeFlagBits(pImportSemaphoreFdInfo->handleType),
5443 string_VkExternalSemaphoreHandleTypeFlags(supported_handle_types).c_str());
sfricke-samsung1708a8c2020-02-10 00:35:06 -08005444 }
5445 return skip;
5446}
sourav parmara96ab1a2020-04-25 16:28:23 -07005447
5448bool StatelessValidation::manual_PreCallValidateCopyAccelerationStructureToMemoryKHR(
sourav parmarcd5fb182020-07-17 12:58:44 -07005449 VkDevice device, VkDeferredOperationKHR deferredOperation, const VkCopyAccelerationStructureToMemoryInfoKHR *pInfo) const {
sourav parmara96ab1a2020-04-25 16:28:23 -07005450 bool skip = false;
5451 if (pInfo->mode != VK_COPY_ACCELERATION_STRUCTURE_MODE_SERIALIZE_KHR) {
5452 skip |= LogError(device, "VUID-VkCopyAccelerationStructureToMemoryInfoKHR-mode-03412",
5453 "vkCopyAccelerationStructureToMemoryKHR: mode must be VK_COPY_ACCELERATION_STRUCTURE_MODE_SERIALIZE_KHR.");
5454 }
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005455 const auto *acc_struct_features = LvlFindInChain<VkPhysicalDeviceAccelerationStructureFeaturesKHR>(device_createinfo_pnext);
sourav parmarcd5fb182020-07-17 12:58:44 -07005456 if (!acc_struct_features || acc_struct_features->accelerationStructureHostCommands == VK_FALSE) {
5457 skip |= LogError(
5458 device, "VUID-vkCopyAccelerationStructureToMemoryKHR-accelerationStructureHostCommands-03584",
5459 "vkCopyAccelerationStructureToMemoryKHR: The "
5460 "VkPhysicalDeviceAccelerationStructureFeaturesKHR::accelerationStructureHostCommands feature must be enabled.");
5461 }
5462 skip |= validate_required_pointer("vkCopyAccelerationStructureToMemoryKHR", "pInfo->dst.hostAddress", pInfo->dst.hostAddress,
5463 "VUID-vkCopyAccelerationStructureToMemoryKHR-pInfo-03732");
5464 if (SafeModulo((VkDeviceSize)pInfo->dst.hostAddress, 16) != 0) {
5465 skip |= LogError(device, "VUID-vkCopyAccelerationStructureToMemoryKHR-pInfo-03751",
5466 "vkCopyAccelerationStructureToMemoryKHR(): pInfo->dst.hostAddress must be aligned to 16 bytes.");
5467 }
sourav parmara96ab1a2020-04-25 16:28:23 -07005468 return skip;
5469}
5470
5471bool StatelessValidation::manual_PreCallValidateCmdCopyAccelerationStructureToMemoryKHR(
5472 VkCommandBuffer commandBuffer, const VkCopyAccelerationStructureToMemoryInfoKHR *pInfo) const {
5473 bool skip = false;
5474 if (pInfo->mode != VK_COPY_ACCELERATION_STRUCTURE_MODE_SERIALIZE_KHR) {
5475 skip |= // to update VUID to VkCmdCopyAccelerationStructureToMemoryInfoKHR after spec update
5476 LogError(commandBuffer, "VUID-VkCopyAccelerationStructureToMemoryInfoKHR-mode-03412",
5477 "vkCmdCopyAccelerationStructureToMemoryKHR: mode must be VK_COPY_ACCELERATION_STRUCTURE_MODE_SERIALIZE_KHR.");
5478 }
sourav parmarcd5fb182020-07-17 12:58:44 -07005479 if (SafeModulo(pInfo->dst.deviceAddress, 256) != 0) {
5480 skip |= LogError(device, "VUID-vkCmdCopyAccelerationStructureToMemoryKHR-pInfo-03740",
5481 "vkCmdCopyAccelerationStructureToMemoryKHR(): pInfo->dst.deviceAddress must be aligned to 256 bytes.",
5482 pInfo->dst.deviceAddress);
sourav parmar83c31b12020-05-06 12:30:54 -07005483 }
sourav parmara96ab1a2020-04-25 16:28:23 -07005484 return skip;
5485}
5486
5487bool StatelessValidation::ValidateCopyAccelerationStructureInfoKHR(const VkCopyAccelerationStructureInfoKHR *pInfo,
5488 const char *api_name) const {
5489 bool skip = false;
5490 if (!(pInfo->mode == VK_COPY_ACCELERATION_STRUCTURE_MODE_COMPACT_KHR ||
5491 pInfo->mode == VK_COPY_ACCELERATION_STRUCTURE_MODE_CLONE_KHR)) {
5492 skip |= LogError(device, "VUID-VkCopyAccelerationStructureInfoKHR-mode-03410",
5493 "(%s): mode must be VK_COPY_ACCELERATION_STRUCTURE_MODE_COMPACT_KHR"
5494 "or VK_COPY_ACCELERATION_STRUCTURE_MODE_CLONE_KHR.",
5495 api_name);
5496 }
5497 return skip;
5498}
5499
5500bool StatelessValidation::manual_PreCallValidateCopyAccelerationStructureKHR(
sourav parmarcd5fb182020-07-17 12:58:44 -07005501 VkDevice device, VkDeferredOperationKHR deferredOperation, const VkCopyAccelerationStructureInfoKHR *pInfo) const {
sourav parmara96ab1a2020-04-25 16:28:23 -07005502 bool skip = false;
5503 skip |= ValidateCopyAccelerationStructureInfoKHR(pInfo, "vkCopyAccelerationStructureKHR()");
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005504 const auto *acc_struct_features = LvlFindInChain<VkPhysicalDeviceAccelerationStructureFeaturesKHR>(device_createinfo_pnext);
sourav parmarcd5fb182020-07-17 12:58:44 -07005505 if (!acc_struct_features || acc_struct_features->accelerationStructureHostCommands == VK_FALSE) {
sourav parmar83c31b12020-05-06 12:30:54 -07005506 skip |= LogError(
sourav parmarcd5fb182020-07-17 12:58:44 -07005507 device, "VUID-vkCopyAccelerationStructureKHR-accelerationStructureHostCommands-03582",
5508 "vkCopyAccelerationStructureKHR: The "
5509 "VkPhysicalDeviceAccelerationStructureFeaturesKHR::accelerationStructureHostCommands feature must be enabled.");
sourav parmar83c31b12020-05-06 12:30:54 -07005510 }
sourav parmara96ab1a2020-04-25 16:28:23 -07005511 return skip;
5512}
5513
5514bool StatelessValidation::manual_PreCallValidateCmdCopyAccelerationStructureKHR(
5515 VkCommandBuffer commandBuffer, const VkCopyAccelerationStructureInfoKHR *pInfo) const {
5516 bool skip = false;
5517 skip |= ValidateCopyAccelerationStructureInfoKHR(pInfo, "vkCmdCopyAccelerationStructureKHR()");
5518 return skip;
5519}
5520
5521bool StatelessValidation::ValidateCopyMemoryToAccelerationStructureInfoKHR(const VkCopyMemoryToAccelerationStructureInfoKHR *pInfo,
Mark Lobodzinskiaad69e42020-05-12 08:44:21 -06005522 const char *api_name, bool is_cmd) const {
sourav parmara96ab1a2020-04-25 16:28:23 -07005523 bool skip = false;
5524 if (pInfo->mode != VK_COPY_ACCELERATION_STRUCTURE_MODE_DESERIALIZE_KHR) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005525 skip |= LogError(device, "VUID-VkCopyMemoryToAccelerationStructureInfoKHR-mode-03413",
sourav parmara96ab1a2020-04-25 16:28:23 -07005526 "(%s): mode must be VK_COPY_ACCELERATION_STRUCTURE_MODE_DESERIALIZE_KHR.", api_name);
5527 }
5528 return skip;
5529}
5530
5531bool StatelessValidation::manual_PreCallValidateCopyMemoryToAccelerationStructureKHR(
sourav parmarcd5fb182020-07-17 12:58:44 -07005532 VkDevice device, VkDeferredOperationKHR deferredOperation, const VkCopyMemoryToAccelerationStructureInfoKHR *pInfo) const {
sourav parmara96ab1a2020-04-25 16:28:23 -07005533 bool skip = false;
sourav parmar83c31b12020-05-06 12:30:54 -07005534 skip |= ValidateCopyMemoryToAccelerationStructureInfoKHR(pInfo, "vkCopyMemoryToAccelerationStructureKHR()", true);
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005535 const auto *acc_struct_features = LvlFindInChain<VkPhysicalDeviceAccelerationStructureFeaturesKHR>(device_createinfo_pnext);
sourav parmarcd5fb182020-07-17 12:58:44 -07005536 if (!acc_struct_features || acc_struct_features->accelerationStructureHostCommands == VK_FALSE) {
5537 skip |= LogError(
5538 device, "VUID-vkCopyMemoryToAccelerationStructureKHR-accelerationStructureHostCommands-03583",
5539 "vkCopyMemoryToAccelerationStructureKHR: The "
5540 "VkPhysicalDeviceAccelerationStructureFeaturesKHR::accelerationStructureHostCommands feature must be enabled.");
sourav parmar83c31b12020-05-06 12:30:54 -07005541 }
sourav parmarcd5fb182020-07-17 12:58:44 -07005542 skip |= validate_required_pointer("vkCopyMemoryToAccelerationStructureKHR", "pInfo->src.hostAddress", pInfo->src.hostAddress,
5543 "VUID-vkCopyMemoryToAccelerationStructureKHR-pInfo-03729");
sourav parmara96ab1a2020-04-25 16:28:23 -07005544 return skip;
5545}
Jeremy Hayes9bda85a2020-05-21 16:36:17 -06005546
sourav parmara96ab1a2020-04-25 16:28:23 -07005547bool StatelessValidation::manual_PreCallValidateCmdCopyMemoryToAccelerationStructureKHR(
5548 VkCommandBuffer commandBuffer, const VkCopyMemoryToAccelerationStructureInfoKHR *pInfo) const {
5549 bool skip = false;
sourav parmar83c31b12020-05-06 12:30:54 -07005550 skip |= ValidateCopyMemoryToAccelerationStructureInfoKHR(pInfo, "vkCmdCopyMemoryToAccelerationStructureKHR()", false);
sourav parmarcd5fb182020-07-17 12:58:44 -07005551 if (SafeModulo(pInfo->src.deviceAddress, 256) != 0) {
5552 skip |= LogError(device, "VUID-vkCmdCopyMemoryToAccelerationStructureKHR-pInfo-03743",
5553 "vkCmdCopyMemoryToAccelerationStructureKHR(): pInfo->src.deviceAddress must be aligned to 256 bytes.",
5554 pInfo->src.deviceAddress);
5555 }
sourav parmar83c31b12020-05-06 12:30:54 -07005556 return skip;
5557}
5558bool StatelessValidation::manual_PreCallValidateCmdWriteAccelerationStructuresPropertiesKHR(
5559 VkCommandBuffer commandBuffer, uint32_t accelerationStructureCount, const VkAccelerationStructureKHR *pAccelerationStructures,
5560 VkQueryType queryType, VkQueryPool queryPool, uint32_t firstQuery) const {
5561 bool skip = false;
5562 if (!(queryType == VK_QUERY_TYPE_ACCELERATION_STRUCTURE_COMPACTED_SIZE_KHR ||
5563 queryType == VK_QUERY_TYPE_ACCELERATION_STRUCTURE_SERIALIZATION_SIZE_KHR)) {
5564 skip |= LogError(device, "VUID-vkCmdWriteAccelerationStructuresPropertiesKHR-queryType-03432",
5565 "vkCmdWriteAccelerationStructuresPropertiesKHR: queryType must be "
5566 "VK_QUERY_TYPE_ACCELERATION_STRUCTURE_COMPACTED_SIZE_KHR or "
5567 "VK_QUERY_TYPE_ACCELERATION_STRUCTURE_SERIALIZATION_SIZE_KHR.");
5568 }
5569 return skip;
5570}
5571bool StatelessValidation::manual_PreCallValidateWriteAccelerationStructuresPropertiesKHR(
5572 VkDevice device, uint32_t accelerationStructureCount, const VkAccelerationStructureKHR *pAccelerationStructures,
5573 VkQueryType queryType, size_t dataSize, void *pData, size_t stride) const {
5574 bool skip = false;
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005575 const auto *acc_structure_features = LvlFindInChain<VkPhysicalDeviceAccelerationStructureFeaturesKHR>(device_createinfo_pnext);
sourav parmarcd5fb182020-07-17 12:58:44 -07005576 if (!acc_structure_features || acc_structure_features->accelerationStructureHostCommands == VK_FALSE) {
5577 skip |= LogError(
5578 device, "VUID-vkWriteAccelerationStructuresPropertiesKHR-accelerationStructureHostCommands-03585",
5579 "vkCmdWriteAccelerationStructuresPropertiesKHR: The "
5580 "VkPhysicalDeviceAccelerationStructureFeaturesKHR::accelerationStructureHostCommands feature must be enabled.");
5581 }
sourav parmar83c31b12020-05-06 12:30:54 -07005582 if (dataSize < accelerationStructureCount * stride) {
5583 skip |= LogError(device, "VUID-vkWriteAccelerationStructuresPropertiesKHR-dataSize-03452",
5584 "vkWriteAccelerationStructuresPropertiesKHR: dataSize (%zu) must be greater than or equal to "
5585 "accelerationStructureCount (%d) *stride(%zu).",
5586 dataSize, accelerationStructureCount, stride);
5587 }
5588 if (!(queryType == VK_QUERY_TYPE_ACCELERATION_STRUCTURE_COMPACTED_SIZE_KHR ||
5589 queryType == VK_QUERY_TYPE_ACCELERATION_STRUCTURE_SERIALIZATION_SIZE_KHR)) {
5590 skip |= LogError(device, "VUID-vkWriteAccelerationStructuresPropertiesKHR-queryType-03432",
5591 "vkWriteAccelerationStructuresPropertiesKHR: queryType must be "
5592 "VK_QUERY_TYPE_ACCELERATION_STRUCTURE_COMPACTED_SIZE_KHR or "
5593 "VK_QUERY_TYPE_ACCELERATION_STRUCTURE_SERIALIZATION_SIZE_KHR.");
5594 }
5595 if (queryType == VK_QUERY_TYPE_ACCELERATION_STRUCTURE_COMPACTED_SIZE_KHR) {
5596 if (SafeModulo(stride, sizeof(VkDeviceSize)) != 0) {
5597 skip |= LogError(device, "VUID-vkWriteAccelerationStructuresPropertiesKHR-queryType-03448",
5598 "vkWriteAccelerationStructuresPropertiesKHR: If queryType is "
5599 "VK_QUERY_TYPE_ACCELERATION_STRUCTURE_COMPACTED_SIZE_KHR,"
5600 "then stride (%zu) must be a multiple of the size of VkDeviceSize",
5601 stride);
5602 }
5603 }
5604 if (queryType == VK_QUERY_TYPE_ACCELERATION_STRUCTURE_SERIALIZATION_SIZE_KHR) {
5605 if (SafeModulo(stride, sizeof(VkDeviceSize)) != 0) {
5606 skip |= LogError(device, "VUID-vkWriteAccelerationStructuresPropertiesKHR-queryType-03450",
5607 "vkWriteAccelerationStructuresPropertiesKHR: If queryType is "
5608 "VK_QUERY_TYPE_ACCELERATION_STRUCTURE_SERIALIZATION_SIZE_KHR,"
5609 "then stride (%zu) must be a multiple of the size of VkDeviceSize",
5610 stride);
5611 }
5612 }
sourav parmar83c31b12020-05-06 12:30:54 -07005613 return skip;
5614}
5615bool StatelessValidation::manual_PreCallValidateGetRayTracingCaptureReplayShaderGroupHandlesKHR(
5616 VkDevice device, VkPipeline pipeline, uint32_t firstGroup, uint32_t groupCount, size_t dataSize, void *pData) const {
5617 bool skip = false;
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005618 const auto *raytracing_features = LvlFindInChain<VkPhysicalDeviceRayTracingPipelineFeaturesKHR>(device_createinfo_pnext);
sourav parmarcd5fb182020-07-17 12:58:44 -07005619 if (!raytracing_features || raytracing_features->rayTracingPipelineShaderGroupHandleCaptureReplay == VK_FALSE) {
5620 skip |= LogError(
5621 device, "VUID-vkGetRayTracingCaptureReplayShaderGroupHandlesKHR-rayTracingPipelineShaderGroupHandleCaptureReplay-03606",
5622 "vkGetRayTracingCaptureReplayShaderGroupHandlesKHR:VkPhysicalDeviceRayTracingPipelineFeaturesKHR::"
5623 "rayTracingPipelineShaderGroupHandleCaptureReplay must be enabled to call this function.");
sourav parmar83c31b12020-05-06 12:30:54 -07005624 }
5625 return skip;
5626}
5627
5628bool StatelessValidation::manual_PreCallValidateCmdTraceRaysKHR(VkCommandBuffer commandBuffer,
sourav parmarcd5fb182020-07-17 12:58:44 -07005629 const VkStridedDeviceAddressRegionKHR *pRaygenShaderBindingTable,
5630 const VkStridedDeviceAddressRegionKHR *pMissShaderBindingTable,
5631 const VkStridedDeviceAddressRegionKHR *pHitShaderBindingTable,
5632 const VkStridedDeviceAddressRegionKHR *pCallableShaderBindingTable,
sourav parmar83c31b12020-05-06 12:30:54 -07005633 uint32_t width, uint32_t height, uint32_t depth) const {
5634 bool skip = false;
sourav parmarcd5fb182020-07-17 12:58:44 -07005635 // RayGen
5636 if (pRaygenShaderBindingTable->size != pRaygenShaderBindingTable->stride) {
5637 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-size-04023",
5638 "vkCmdTraceRaysKHR: The size member of pRayGenShaderBindingTable must be equal to its stride member");
sourav parmar83c31b12020-05-06 12:30:54 -07005639 }
sourav parmarcd5fb182020-07-17 12:58:44 -07005640 if (SafeModulo(pRaygenShaderBindingTable->deviceAddress, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) !=
5641 0) {
5642 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-pRayGenShaderBindingTable-03682",
5643 "vkCmdTraceRaysKHR: pRaygenShaderBindingTable->deviceAddress must be a multiple of "
5644 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupBaseAlignment.");
5645 }
5646 // Callable
5647 if (SafeModulo(pCallableShaderBindingTable->stride, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupHandleAlignment) != 0) {
5648 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-stride-03694",
5649 "vkCmdTraceRaysKHR: The stride member of pCallableShaderBindingTable must be a multiple of "
5650 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupHandleAlignment.");
sourav parmar83c31b12020-05-06 12:30:54 -07005651 }
5652 if (pCallableShaderBindingTable->stride > phys_dev_ext_props.ray_tracing_propsKHR.maxShaderGroupStride) {
5653 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-stride-04041",
5654 "vkCmdTraceRaysKHR: The stride member of pCallableShaderBindingTable must be"
sourav parmarcd5fb182020-07-17 12:58:44 -07005655 "less than or equal to VkPhysicalDeviceRayTracingPipelinePropertiesKHR::maxShaderGroupStride.");
5656 }
5657 if (SafeModulo(pCallableShaderBindingTable->deviceAddress, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) !=
5658 0) {
5659 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-pCallableShaderBindingTable-03693",
5660 "vkCmdTraceRaysKHR: pCallableShaderBindingTable->deviceAddress must be a multiple of "
5661 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupBaseAlignment.");
sourav parmar83c31b12020-05-06 12:30:54 -07005662 }
5663 // hitShader
sourav parmarcd5fb182020-07-17 12:58:44 -07005664 if (SafeModulo(pHitShaderBindingTable->stride, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupHandleAlignment) != 0) {
5665 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-stride-03690",
5666 "vkCmdTraceRaysKHR: The stride member of pHitShaderBindingTable must be a multiple of "
5667 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupHandleAlignment.");
sourav parmar83c31b12020-05-06 12:30:54 -07005668 }
5669 if (pHitShaderBindingTable->stride > phys_dev_ext_props.ray_tracing_propsKHR.maxShaderGroupStride) {
5670 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-stride-04035",
sourav parmarcd5fb182020-07-17 12:58:44 -07005671 "vkCmdTraceRaysKHR: TThe stride member of pHitShaderBindingTable must be less than or equal to "
5672 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::maxShaderGroupStride");
sourav parmar83c31b12020-05-06 12:30:54 -07005673 }
sourav parmarcd5fb182020-07-17 12:58:44 -07005674 if (SafeModulo(pHitShaderBindingTable->deviceAddress, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) != 0) {
5675 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-pHitShaderBindingTable-03689",
5676 "vkCmdTraceRaysKHR: pHitShaderBindingTable->deviceAddress must be a multiple of "
5677 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupBaseAlignment.");
5678 }
sourav parmar83c31b12020-05-06 12:30:54 -07005679 // missShader
sourav parmarcd5fb182020-07-17 12:58:44 -07005680 if (SafeModulo(pMissShaderBindingTable->stride, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupHandleAlignment) != 0) {
5681 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-stride-03686",
5682 "vkCmdTraceRaysKHR: The stride member of pMissShaderBindingTable must be a multiple of "
5683 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupHandleAlignment");
sourav parmar83c31b12020-05-06 12:30:54 -07005684 }
5685 if (pMissShaderBindingTable->stride > phys_dev_ext_props.ray_tracing_propsKHR.maxShaderGroupStride) {
5686 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-stride-04029",
5687 "vkCmdTraceRaysKHR: The stride member of pMissShaderBindingTable must be"
sourav parmarcd5fb182020-07-17 12:58:44 -07005688 "less than or equal to VkPhysicalDeviceRayTracingPipelinePropertiesKHR::maxShaderGroupStride.");
5689 }
5690 if (SafeModulo(pMissShaderBindingTable->deviceAddress, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) != 0) {
5691 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-pMissShaderBindingTable-03685",
5692 "vkCmdTraceRaysKHR: pMissShaderBindingTable->deviceAddress must be a multiple of "
5693 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupBaseAlignment.");
5694 }
5695 if (width * depth * height > phys_dev_ext_props.ray_tracing_propsKHR.maxRayDispatchInvocationCount) {
5696 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-width-03629",
5697 "vkCmdTraceRaysKHR: width {times} height {times} depth must be less than or equal to "
5698 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::maxRayDispatchInvocationCount");
5699 }
5700 if (width > device_limits.maxComputeWorkGroupCount[0] * device_limits.maxComputeWorkGroupSize[0]) {
5701 skip |=
5702 LogError(device, "VUID-vkCmdTraceRaysKHR-width-03626",
5703 "vkCmdTraceRaysKHR: width must be less than or equal to VkPhysicalDeviceLimits::maxComputeWorkGroupCount[0] "
5704 "{times} VkPhysicalDeviceLimits::maxComputeWorkGroupSize[0]");
sourav parmar83c31b12020-05-06 12:30:54 -07005705 }
5706
sourav parmarcd5fb182020-07-17 12:58:44 -07005707 if (height > device_limits.maxComputeWorkGroupCount[1] * device_limits.maxComputeWorkGroupSize[1]) {
5708 skip |=
5709 LogError(device, "VUID-vkCmdTraceRaysKHR-height-03627",
5710 "vkCmdTraceRaysKHR: height must be less than or equal to VkPhysicalDeviceLimits::maxComputeWorkGroupCount[1] "
5711 "{times} VkPhysicalDeviceLimits::maxComputeWorkGroupSize[1]");
5712 }
5713
5714 if (depth > device_limits.maxComputeWorkGroupCount[2] * device_limits.maxComputeWorkGroupSize[2]) {
5715 skip |=
5716 LogError(device, "VUID-vkCmdTraceRaysKHR-depth-03628",
5717 "vkCmdTraceRaysKHR: depth must be less than or equal to VkPhysicalDeviceLimits::maxComputeWorkGroupCount[2] "
5718 "{times} VkPhysicalDeviceLimits::maxComputeWorkGroupSize[2]");
sourav parmar83c31b12020-05-06 12:30:54 -07005719 }
5720 return skip;
5721}
5722
sourav parmarcd5fb182020-07-17 12:58:44 -07005723bool StatelessValidation::manual_PreCallValidateCmdTraceRaysIndirectKHR(
5724 VkCommandBuffer commandBuffer, const VkStridedDeviceAddressRegionKHR *pRaygenShaderBindingTable,
5725 const VkStridedDeviceAddressRegionKHR *pMissShaderBindingTable, const VkStridedDeviceAddressRegionKHR *pHitShaderBindingTable,
5726 const VkStridedDeviceAddressRegionKHR *pCallableShaderBindingTable, VkDeviceAddress indirectDeviceAddress) const {
sourav parmar83c31b12020-05-06 12:30:54 -07005727 bool skip = false;
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005728 const auto *raytracing_features = LvlFindInChain<VkPhysicalDeviceRayTracingPipelineFeaturesKHR>(device_createinfo_pnext);
sourav parmarcd5fb182020-07-17 12:58:44 -07005729 if (!raytracing_features || raytracing_features->rayTracingPipelineTraceRaysIndirect == VK_FALSE) {
5730 skip |= LogError(
5731 device, "VUID-vkCmdTraceRaysIndirectKHR-rayTracingPipelineTraceRaysIndirect-03637",
5732 "vkCmdTraceRaysIndirectKHR: the VkPhysicalDeviceRayTracingPipelineFeaturesKHR::rayTracingPipelineTraceRaysIndirect "
5733 "feature must be enabled.");
sourav parmar83c31b12020-05-06 12:30:54 -07005734 }
sourav parmarcd5fb182020-07-17 12:58:44 -07005735 // RayGen
5736 if (pRaygenShaderBindingTable->size != pRaygenShaderBindingTable->stride) {
5737 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-size-04023",
5738 "vkCmdTraceRaysKHR: The size member of pRayGenShaderBindingTable must be equal to its stride member");
sourav parmar83c31b12020-05-06 12:30:54 -07005739 }
sourav parmarcd5fb182020-07-17 12:58:44 -07005740 if (SafeModulo(pRaygenShaderBindingTable->deviceAddress, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) !=
5741 0) {
5742 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-pRayGenShaderBindingTable-03682",
5743 "vkCmdTraceRaysIndirectKHR: pRaygenShaderBindingTable->deviceAddress must be a multiple of "
5744 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupBaseAlignment.");
5745 }
5746 // Callabe
5747 if (SafeModulo(pCallableShaderBindingTable->stride, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupHandleAlignment) != 0) {
5748 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-stride-03694",
5749 "vkCmdTraceRaysIndirectKHR: The stride member of pCallableShaderBindingTable must be a multiple of "
5750 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupHandleAlignment.");
sourav parmar83c31b12020-05-06 12:30:54 -07005751 }
5752 if (pCallableShaderBindingTable->stride > phys_dev_ext_props.ray_tracing_propsKHR.maxShaderGroupStride) {
5753 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-stride-04041",
sourav parmarcd5fb182020-07-17 12:58:44 -07005754 "vkCmdTraceRaysIndirectKHR: The stride member of pCallableShaderBindingTable must be less than or equal "
5755 "to VkPhysicalDeviceRayTracingPipelinePropertiesKHR::maxShaderGroupStride.");
5756 }
5757 if (SafeModulo(pCallableShaderBindingTable->deviceAddress, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) !=
5758 0) {
5759 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-pCallableShaderBindingTable-03693",
5760 "vkCmdTraceRaysIndirectKHR: pCallableShaderBindingTable->deviceAddress must be a multiple of "
5761 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupBaseAlignment.");
sourav parmar83c31b12020-05-06 12:30:54 -07005762 }
5763 // hitShader
sourav parmarcd5fb182020-07-17 12:58:44 -07005764 if (SafeModulo(pHitShaderBindingTable->stride, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupHandleAlignment) != 0) {
5765 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-stride-03690",
5766 "vkCmdTraceRaysIndirectKHR: The stride member of pHitShaderBindingTable must be a multiple of "
5767 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupHandleAlignment.");
sourav parmar83c31b12020-05-06 12:30:54 -07005768 }
5769 if (pHitShaderBindingTable->stride > phys_dev_ext_props.ray_tracing_propsKHR.maxShaderGroupStride) {
5770 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-stride-04035",
sourav parmarcd5fb182020-07-17 12:58:44 -07005771 "vkCmdTraceRaysIndirectKHR: The stride member of pHitShaderBindingTable must be less than or equal to "
5772 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::maxShaderGroupStride.");
sourav parmar83c31b12020-05-06 12:30:54 -07005773 }
sourav parmarcd5fb182020-07-17 12:58:44 -07005774 if (SafeModulo(pHitShaderBindingTable->deviceAddress, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) != 0) {
5775 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-pHitShaderBindingTable-03689",
5776 "vkCmdTraceRaysIndirectKHR: pHitShaderBindingTable->deviceAddress must be a multiple of "
5777 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupBaseAlignment.");
5778 }
sourav parmar83c31b12020-05-06 12:30:54 -07005779 // missShader
sourav parmarcd5fb182020-07-17 12:58:44 -07005780 if (SafeModulo(pMissShaderBindingTable->stride, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupHandleAlignment) != 0) {
5781 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-stride-03686",
5782 "vkCmdTraceRaysIndirectKHR:The stride member of pMissShaderBindingTable must be a multiple of "
5783 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupHandleAlignment.");
sourav parmar83c31b12020-05-06 12:30:54 -07005784 }
5785 if (pMissShaderBindingTable->stride > phys_dev_ext_props.ray_tracing_propsKHR.maxShaderGroupStride) {
5786 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-stride-04029",
sourav parmarcd5fb182020-07-17 12:58:44 -07005787 "vkCmdTraceRaysIndirectKHR: The stride member of pMissShaderBindingTable must be less than or equal to "
5788 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::maxShaderGroupStride.");
5789 }
5790 if (SafeModulo(pMissShaderBindingTable->deviceAddress, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) != 0) {
5791 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-pMissShaderBindingTable-03685",
5792 "vkCmdTraceRaysIndirectKHR: pMissShaderBindingTable->deviceAddress must be a multiple of "
5793 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupBaseAlignment.");
sourav parmar83c31b12020-05-06 12:30:54 -07005794 }
5795
sourav parmarcd5fb182020-07-17 12:58:44 -07005796 if (SafeModulo(indirectDeviceAddress, 4) != 0) {
5797 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-indirectDeviceAddress-03634",
5798 "vkCmdTraceRaysIndirectKHR: indirectDeviceAddress must be a multiple of 4.");
sourav parmar83c31b12020-05-06 12:30:54 -07005799 }
5800 return skip;
5801}
5802bool StatelessValidation::manual_PreCallValidateCmdTraceRaysNV(
5803 VkCommandBuffer commandBuffer, VkBuffer raygenShaderBindingTableBuffer, VkDeviceSize raygenShaderBindingOffset,
5804 VkBuffer missShaderBindingTableBuffer, VkDeviceSize missShaderBindingOffset, VkDeviceSize missShaderBindingStride,
5805 VkBuffer hitShaderBindingTableBuffer, VkDeviceSize hitShaderBindingOffset, VkDeviceSize hitShaderBindingStride,
5806 VkBuffer callableShaderBindingTableBuffer, VkDeviceSize callableShaderBindingOffset, VkDeviceSize callableShaderBindingStride,
5807 uint32_t width, uint32_t height, uint32_t depth) const {
5808 bool skip = false;
5809 if (SafeModulo(callableShaderBindingOffset, phys_dev_ext_props.ray_tracing_propsNV.shaderGroupBaseAlignment) != 0) {
5810 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-callableShaderBindingOffset-02462",
5811 "vkCmdTraceRaysNV: callableShaderBindingOffset must be a multiple of "
5812 "VkPhysicalDeviceRayTracingPropertiesNV::shaderGroupBaseAlignment.");
5813 }
5814 if (SafeModulo(callableShaderBindingStride, phys_dev_ext_props.ray_tracing_propsNV.shaderGroupHandleSize) != 0) {
5815 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-callableShaderBindingStride-02465",
5816 "vkCmdTraceRaysNV: callableShaderBindingStride must be a multiple of "
5817 "VkPhysicalDeviceRayTracingPropertiesNV::shaderGroupHandleSize.");
5818 }
5819 if (callableShaderBindingStride > phys_dev_ext_props.ray_tracing_propsNV.maxShaderGroupStride) {
5820 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-callableShaderBindingStride-02468",
5821 "vkCmdTraceRaysNV: callableShaderBindingStride must be less than or equal to "
5822 "VkPhysicalDeviceRayTracingPropertiesNV::maxShaderGroupStride. ");
5823 }
5824
5825 // hitShader
5826 if (SafeModulo(hitShaderBindingOffset, phys_dev_ext_props.ray_tracing_propsNV.shaderGroupBaseAlignment) != 0) {
5827 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-hitShaderBindingOffset-02460",
5828 "vkCmdTraceRaysNV: hitShaderBindingOffset must be a multiple of "
5829 "VkPhysicalDeviceRayTracingPropertiesNV::shaderGroupBaseAlignment.");
5830 }
5831 if (SafeModulo(hitShaderBindingStride, phys_dev_ext_props.ray_tracing_propsNV.shaderGroupHandleSize) != 0) {
5832 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-hitShaderBindingStride-02464",
5833 "vkCmdTraceRaysNV: hitShaderBindingStride must be a multiple of "
5834 "VkPhysicalDeviceRayTracingPropertiesNV::shaderGroupHandleSize.");
5835 }
5836 if (hitShaderBindingStride > phys_dev_ext_props.ray_tracing_propsNV.maxShaderGroupStride) {
5837 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-hitShaderBindingStride-02467",
5838 "vkCmdTraceRaysNV: hitShaderBindingStride must be less than or equal to "
5839 "VkPhysicalDeviceRayTracingPropertiesNV::maxShaderGroupStride.");
5840 }
5841
5842 // missShader
5843 if (SafeModulo(missShaderBindingOffset, phys_dev_ext_props.ray_tracing_propsNV.shaderGroupBaseAlignment) != 0) {
5844 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-missShaderBindingOffset-02458",
5845 "vkCmdTraceRaysNV: missShaderBindingOffset must be a multiple of "
5846 "VkPhysicalDeviceRayTracingPropertiesNV::shaderGroupBaseAlignment.");
5847 }
5848 if (SafeModulo(missShaderBindingStride, phys_dev_ext_props.ray_tracing_propsNV.shaderGroupHandleSize) != 0) {
5849 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-missShaderBindingStride-02463",
5850 "vkCmdTraceRaysNV: missShaderBindingStride must be a multiple of "
5851 "VkPhysicalDeviceRayTracingPropertiesNV::shaderGroupHandleSize.");
5852 }
5853 if (missShaderBindingStride > phys_dev_ext_props.ray_tracing_propsNV.maxShaderGroupStride) {
5854 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-missShaderBindingStride-02466",
5855 "vkCmdTraceRaysNV: missShaderBindingStride must be less than or equal to "
5856 "VkPhysicalDeviceRayTracingPropertiesNV::maxShaderGroupStride.");
5857 }
5858
5859 // raygenShader
5860 if (SafeModulo(raygenShaderBindingOffset, phys_dev_ext_props.ray_tracing_propsNV.shaderGroupBaseAlignment) != 0) {
5861 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-raygenShaderBindingOffset-02456",
5862 "vkCmdTraceRaysNV: raygenShaderBindingOffset must be a multiple of "
sourav parmard1521802020-06-07 21:49:02 -07005863 "VkPhysicalDeviceRayTracingPropertiesNV::shaderGroupBaseAlignment.");
5864 }
5865 if (width > device_limits.maxComputeWorkGroupCount[0]) {
5866 skip |=
5867 LogError(device, "VUID-vkCmdTraceRaysNV-width-02469",
5868 "vkCmdTraceRaysNV: width must be less than or equal to VkPhysicalDeviceLimits::maxComputeWorkGroupCount[o].");
5869 }
5870 if (height > device_limits.maxComputeWorkGroupCount[1]) {
5871 skip |=
5872 LogError(device, "VUID-vkCmdTraceRaysNV-height-02470",
5873 "vkCmdTraceRaysNV: height must be less than or equal to VkPhysicalDeviceLimits::maxComputeWorkGroupCount[1].");
5874 }
5875 if (depth > device_limits.maxComputeWorkGroupCount[2]) {
5876 skip |=
5877 LogError(device, "VUID-vkCmdTraceRaysNV-depth-02471",
5878 "vkCmdTraceRaysNV: depth must be less than or equal to VkPhysicalDeviceLimits::maxComputeWorkGroupCount[2].");
sourav parmar83c31b12020-05-06 12:30:54 -07005879 }
5880 return skip;
5881}
5882
sourav parmar83c31b12020-05-06 12:30:54 -07005883bool StatelessValidation::manual_PreCallValidateGetDeviceAccelerationStructureCompatibilityKHR(
sourav parmarcd5fb182020-07-17 12:58:44 -07005884 VkDevice device, const VkAccelerationStructureVersionInfoKHR *pVersionInfo,
5885 VkAccelerationStructureCompatibilityKHR *pCompatibility) const {
sourav parmar83c31b12020-05-06 12:30:54 -07005886 bool skip = false;
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005887 const auto *ray_query_features = LvlFindInChain<VkPhysicalDeviceRayQueryFeaturesKHR>(device_createinfo_pnext);
5888 const auto *raytracing_features = LvlFindInChain<VkPhysicalDeviceRayTracingPipelineFeaturesKHR>(device_createinfo_pnext);
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07005889 if ((!raytracing_features && !ray_query_features) || ((ray_query_features && !(ray_query_features->rayQuery)) ||
5890 (raytracing_features && !raytracing_features->rayTracingPipeline))) {
sourav parmarcd5fb182020-07-17 12:58:44 -07005891 skip |= LogError(device, "VUID-vkGetDeviceAccelerationStructureCompatibilityKHR-rayTracingPipeline-03661",
sourav parmar83c31b12020-05-06 12:30:54 -07005892 "vkGetDeviceAccelerationStructureCompatibilityKHR: The rayTracing or rayQuery feature must be enabled.");
5893 }
5894 return skip;
5895}
5896
Piers Daniell39842ee2020-07-10 16:42:33 -06005897bool StatelessValidation::manual_PreCallValidateCmdSetViewportWithCountEXT(VkCommandBuffer commandBuffer, uint32_t viewportCount,
5898 const VkViewport *pViewports) const {
5899 bool skip = false;
5900
5901 if (!physical_device_features.multiViewport) {
5902 if (viewportCount != 1) {
5903 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewportWithCountEXT-viewportCount-03395",
5904 "vkCmdSetViewportWithCountEXT: The multiViewport feature is disabled, but viewportCount (=%" PRIu32
5905 ") is not 1.",
5906 viewportCount);
5907 }
5908 } else { // multiViewport enabled
5909 if (viewportCount < 1 || viewportCount > device_limits.maxViewports) {
5910 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewportWithCountEXT-viewportCount-03394",
5911 "vkCmdSetViewportWithCountEXT: viewportCount (=%" PRIu32
5912 ") must "
5913 "not be greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
5914 viewportCount, device_limits.maxViewports);
5915 }
5916 }
5917
5918 if (pViewports) {
5919 for (uint32_t viewport_i = 0; viewport_i < viewportCount; ++viewport_i) {
5920 const auto &viewport = pViewports[viewport_i]; // will crash on invalid ptr
5921 const char *fn_name = "vkCmdSetViewportWithCountEXT";
5922 skip |= manual_PreCallValidateViewport(
5923 viewport, fn_name, ParameterName("pViewports[%i]", ParameterName::IndexVector{viewport_i}), commandBuffer);
5924 }
5925 }
5926
5927 return skip;
5928}
5929
5930bool StatelessValidation::manual_PreCallValidateCmdSetScissorWithCountEXT(VkCommandBuffer commandBuffer, uint32_t scissorCount,
5931 const VkRect2D *pScissors) const {
5932 bool skip = false;
5933
5934 if (!physical_device_features.multiViewport) {
5935 if (scissorCount != 1) {
5936 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissorWithCountEXT-scissorCount-03398",
5937 "vkCmdSetScissorWithCountEXT: scissorCount (=%" PRIu32
5938 ") must "
5939 "be 1 when the multiViewport feature is disabled.",
5940 scissorCount);
5941 }
5942 } else { // multiViewport enabled
5943 if (scissorCount == 0) {
5944 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissorWithCountEXT-scissorCount-03397",
5945 "vkCmdSetScissorWithCountEXT: scissorCount (=%" PRIu32
5946 ") must "
5947 "be great than zero.",
5948 scissorCount);
5949 } else if (scissorCount > device_limits.maxViewports) {
5950 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissorWithCountEXT-scissorCount-03397",
5951 "vkCmdSetScissorWithCountEXT: scissorCount (=%" PRIu32
5952 ") must "
5953 "not be greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
5954 scissorCount, device_limits.maxViewports);
5955 }
5956 }
5957
5958 if (pScissors) {
5959 for (uint32_t scissor_i = 0; scissor_i < scissorCount; ++scissor_i) {
5960 const auto &scissor = pScissors[scissor_i]; // will crash on invalid ptr
5961
5962 if (scissor.offset.x < 0) {
5963 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissorWithCountEXT-x-03399",
5964 "vkCmdSetScissor: pScissors[%" PRIu32 "].offset.x (=%" PRIi32 ") is negative.", scissor_i,
5965 scissor.offset.x);
5966 }
5967
5968 if (scissor.offset.y < 0) {
5969 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissorWithCountEXT-x-03399",
5970 "vkCmdSetScissor: pScissors[%" PRIu32 "].offset.y (=%" PRIi32 ") is negative.", scissor_i,
5971 scissor.offset.y);
5972 }
5973
5974 const int64_t x_sum = static_cast<int64_t>(scissor.offset.x) + static_cast<int64_t>(scissor.extent.width);
5975 if (x_sum > INT32_MAX) {
5976 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissorWithCountEXT-offset-03400",
5977 "vkCmdSetScissor: offset.x + extent.width (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
5978 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
5979 scissor.offset.x, scissor.extent.width, x_sum, scissor_i);
5980 }
5981
5982 const int64_t y_sum = static_cast<int64_t>(scissor.offset.y) + static_cast<int64_t>(scissor.extent.height);
5983 if (y_sum > INT32_MAX) {
5984 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissorWithCountEXT-offset-03401",
5985 "vkCmdSetScissor: offset.y + extent.height (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
5986 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
5987 scissor.offset.y, scissor.extent.height, y_sum, scissor_i);
5988 }
5989 }
5990 }
5991
5992 return skip;
5993}
5994
5995bool StatelessValidation::manual_PreCallValidateCmdBindVertexBuffers2EXT(VkCommandBuffer commandBuffer, uint32_t firstBinding,
5996 uint32_t bindingCount, const VkBuffer *pBuffers,
5997 const VkDeviceSize *pOffsets, const VkDeviceSize *pSizes,
5998 const VkDeviceSize *pStrides) const {
5999 bool skip = false;
6000 if (firstBinding >= device_limits.maxVertexInputBindings) {
6001 skip |= LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers2EXT-firstBinding-03355",
6002 "vkCmdBindVertexBuffers2EXT() firstBinding (%u) must be less than maxVertexInputBindings (%u)",
6003 firstBinding, device_limits.maxVertexInputBindings);
6004 } else if ((firstBinding + bindingCount) > device_limits.maxVertexInputBindings) {
6005 skip |= LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers2EXT-firstBinding-03356",
6006 "vkCmdBindVertexBuffers2EXT() sum of firstBinding (%u) and bindingCount (%u) must be less than "
6007 "maxVertexInputBindings (%u)",
6008 firstBinding, bindingCount, device_limits.maxVertexInputBindings);
6009 }
6010
6011 for (uint32_t i = 0; i < bindingCount; ++i) {
6012 if (pBuffers[i] == VK_NULL_HANDLE) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07006013 const auto *robustness2_features = LvlFindInChain<VkPhysicalDeviceRobustness2FeaturesEXT>(device_createinfo_pnext);
Piers Daniell39842ee2020-07-10 16:42:33 -06006014 if (!(robustness2_features && robustness2_features->nullDescriptor)) {
6015 skip |= LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers2EXT-pBuffers-04111",
6016 "vkCmdBindVertexBuffers2EXT() required parameter pBuffers[%d] specified as VK_NULL_HANDLE", i);
6017 } else {
6018 if (pOffsets[i] != 0) {
6019 skip |=
6020 LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers2EXT-pBuffers-04112",
6021 "vkCmdBindVertexBuffers2EXT() pBuffers[%d] is VK_NULL_HANDLE, but pOffsets[%d] is not 0", i, i);
6022 }
6023 }
6024 }
6025 if (pStrides) {
6026 if (pStrides[i] > device_limits.maxVertexInputBindingStride) {
6027 skip |=
6028 LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers2EXT-pStrides-03362",
6029 "vkCmdBindVertexBuffers2EXT() pStrides[%d] (%u) must be less than maxVertexInputBindingStride (%u)", i,
6030 pStrides[i], device_limits.maxVertexInputBindingStride);
6031 }
6032 }
6033 }
6034
6035 return skip;
6036}
sourav parmarcd5fb182020-07-17 12:58:44 -07006037
6038bool StatelessValidation::ValidateAccelerationStructureBuildGeometryInfoKHR(
6039 const VkAccelerationStructureBuildGeometryInfoKHR *pInfos, uint32_t infoCount, const char *api_name) const {
6040 bool skip = false;
6041 for (uint32_t i = 0; i < infoCount; ++i) {
6042 if (pInfos[i].type == VK_ACCELERATION_STRUCTURE_TYPE_GENERIC_KHR) {
6043 skip |= LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-type-03654",
6044 "(%s): type must not be VK_ACCELERATION_STRUCTURE_TYPE_GENERIC_KHR.", api_name);
6045 }
6046 if (pInfos[i].flags & VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_TRACE_BIT_KHR &&
6047 pInfos[i].flags & VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_BUILD_BIT_KHR) {
6048 skip |= LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-flags-03796",
6049 "(%s): If flags has the VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_TRACE_BIT_KHR bit set,"
6050 "then it must not have the VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_BUILD_BIT_KHR bit set.",
6051 api_name);
6052 }
6053 if (pInfos[i].pGeometries && pInfos[i].ppGeometries) {
6054 skip |=
6055 LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-pGeometries-03788",
6056 "(%s): Only one of pGeometries or ppGeometries can be a valid pointer, the other must be NULL", api_name);
6057 }
6058 if (pInfos[i].type == VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_KHR && pInfos[i].geometryCount != 1) {
6059 skip |= LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-type-03790",
6060 "(%s): If type is VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_KHR, geometryCount must be 1", api_name);
6061 }
6062 if (pInfos[i].type == VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_KHR &&
6063 pInfos[i].geometryCount > phys_dev_ext_props.acc_structure_props.maxGeometryCount) {
6064 skip |= LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-type-03793",
6065 "(%s): If type is VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_KHR then geometryCount must be"
6066 " less than or equal to VkPhysicalDeviceAccelerationStructurePropertiesKHR::maxGeometryCount",
6067 api_name);
6068 }
6069 if (pInfos[i].pGeometries) {
6070 for (uint32_t j = 0; j < pInfos[i].geometryCount; ++j) {
6071 skip |= validate_ranged_enum(
6072 api_name, ParameterName("pInfos[%i].pGeometries[%i].geometryType", ParameterName::IndexVector{i, j}),
6073 "VkGeometryTypeKHR", AllVkGeometryTypeKHREnums, pInfos[i].pGeometries[j].geometryType,
6074 "VUID-VkAccelerationStructureGeometryKHR-geometryType-parameter");
6075 if (pInfos[i].pGeometries[j].geometryType == VK_GEOMETRY_TYPE_TRIANGLES_KHR) {
sourav parmarcd5fb182020-07-17 12:58:44 -07006076 skip |= validate_struct_type(
6077 api_name, ParameterName("pInfos[%i].pGeometries[%i].geometry.triangles", ParameterName::IndexVector{i, j}),
6078 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_TRIANGLES_DATA_KHR",
6079 &(pInfos[i].pGeometries[j].geometry.triangles),
6080 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_TRIANGLES_DATA_KHR, false, kVUIDUndefined,
6081 "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-sType-sType");
6082 skip |= validate_struct_pnext(
6083 api_name,
6084 ParameterName("pInfos[%i].pGeometries[%i].geometry.triangles.pNext", ParameterName::IndexVector{i, j}),
6085 NULL, pInfos[i].pGeometries[j].geometry.triangles.pNext, 0, NULL, GeneratedVulkanHeaderVersion,
6086 "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-pNext-pNext", kVUIDUndefined);
6087 skip |=
6088 validate_ranged_enum(api_name,
6089 ParameterName("pInfos[%i].pGeometries[%i].geometry.triangles.vertexFormat",
6090 ParameterName::IndexVector{i, j}),
6091 "VkFormat", AllVkFormatEnums, pInfos[i].pGeometries[j].geometry.triangles.vertexFormat,
6092 "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-vertexFormat-parameter");
6093 skip |= validate_struct_type(api_name, "pInfos[i].pGeometries[j].geometry.triangles",
6094 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_TRIANGLES_DATA_KHR",
6095 &pInfos[i].pGeometries[j].geometry.triangles,
6096 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_TRIANGLES_DATA_KHR, true,
6097 "VUID-VkAccelerationStructureGeometryKHR-triangles-parameter", kVUIDUndefined);
6098 skip |= validate_ranged_enum(
6099 api_name,
6100 ParameterName("pInfos[%i].pGeometries[%i].geometry.triangles.indexType", ParameterName::IndexVector{i, j}),
6101 "VkIndexType", AllVkIndexTypeEnums, pInfos[i].pGeometries[j].geometry.triangles.indexType,
6102 "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-indexType-parameter");
6103
6104 if (pInfos[i].pGeometries[j].geometry.triangles.vertexStride > UINT32_MAX) {
6105 skip |= LogError(device, "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-vertexStride-03819",
6106 "(%s):vertexStride must be less than or equal to 2^32-1", api_name);
6107 }
6108 if (pInfos[i].pGeometries[j].geometry.triangles.indexType != VK_INDEX_TYPE_UINT16 &&
6109 pInfos[i].pGeometries[j].geometry.triangles.indexType != VK_INDEX_TYPE_UINT32 &&
6110 pInfos[i].pGeometries[j].geometry.triangles.indexType != VK_INDEX_TYPE_NONE_KHR) {
6111 skip |=
6112 LogError(device, "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-indexType-03798",
6113 "(%s):indexType must be VK_INDEX_TYPE_UINT16, VK_INDEX_TYPE_UINT32, or VK_INDEX_TYPE_NONE_KHR",
6114 api_name);
6115 }
6116 }
6117 if (pInfos[i].pGeometries[j].geometryType == VK_GEOMETRY_TYPE_INSTANCES_KHR) {
6118 skip |= validate_struct_type(api_name, "pInfos[i].pGeometries[j].geometry.instances",
6119 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_INSTANCES_DATA_KHR",
6120 &pInfos[i].pGeometries[j].geometry.instances,
6121 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_INSTANCES_DATA_KHR, true,
6122 "VUID-VkAccelerationStructureGeometryKHR-instances-parameter", kVUIDUndefined);
6123 skip |= validate_struct_type(
6124 api_name, ParameterName("pInfos[%i].pGeometries[%i].geometry.instances", ParameterName::IndexVector{i, j}),
6125 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_INSTANCES_DATA_KHR",
6126 &(pInfos[i].pGeometries[j].geometry.instances),
6127 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_INSTANCES_DATA_KHR, false, kVUIDUndefined,
6128 "VUID-VkAccelerationStructureGeometryInstancesDataKHR-sType-sType");
6129 skip |= validate_struct_pnext(
6130 api_name,
6131 ParameterName("pInfos[%i].pGeometries[%i].geometry.instances.pNext", ParameterName::IndexVector{i, j}),
6132 NULL, pInfos[i].pGeometries[j].geometry.instances.pNext, 0, NULL, GeneratedVulkanHeaderVersion,
6133 "VUID-VkAccelerationStructureGeometryInstancesDataKHR-pNext-pNext", kVUIDUndefined);
6134
6135 skip |= validate_bool32(api_name,
6136 ParameterName("pInfos[%i].pGeometries[%i].geometry.instances.arrayOfPointers",
6137 ParameterName::IndexVector{i, j}),
6138 pInfos[i].pGeometries[j].geometry.instances.arrayOfPointers);
6139 }
6140 if (pInfos[i].pGeometries[j].geometryType == VK_GEOMETRY_TYPE_AABBS_KHR) {
6141 skip |= validate_struct_type(api_name, "pInfos[i].pGeometries[j].geometry.aabbs",
6142 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_AABBS_DATA_KHR",
6143 &pInfos[i].pGeometries[j].geometry.aabbs,
6144 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_AABBS_DATA_KHR, true,
6145 "VUID-VkAccelerationStructureGeometryKHR-aabbs-parameter", kVUIDUndefined);
6146 skip |= validate_struct_type(
6147 api_name, ParameterName("pInfos[%i].pGeometries[%i].geometry.aabbs", ParameterName::IndexVector{i, j}),
6148 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_AABBS_DATA_KHR",
6149 &(pInfos[i].pGeometries[j].geometry.aabbs),
6150 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_AABBS_DATA_KHR, false, kVUIDUndefined,
6151 "VUID-VkAccelerationStructureGeometryAabbsDataKHR-sType-sType");
6152 skip |= validate_struct_pnext(
6153 api_name,
6154 ParameterName("pInfos[%i].pGeometries[%i].geometry.aabbs.pNext", ParameterName::IndexVector{i, j}), NULL,
6155 pInfos[i].pGeometries[j].geometry.aabbs.pNext, 0, NULL, GeneratedVulkanHeaderVersion,
6156 "VUID-VkAccelerationStructureGeometryAabbsDataKHR-pNext-pNext", kVUIDUndefined);
6157 if (pInfos[i].pGeometries[j].geometry.aabbs.stride > UINT32_MAX) {
6158 skip |= LogError(device, "VUID-VkAccelerationStructureGeometryAabbsDataKHR-stride-03820",
6159 "(%s):stride must be less than or equal to 2^32-1", api_name);
6160 }
6161 }
6162 if (pInfos[i].type == VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_KHR &&
6163 pInfos[i].pGeometries[j].geometryType != VK_GEOMETRY_TYPE_INSTANCES_KHR) {
6164 skip |= LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-type-03789",
6165 "(%s): If type is VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_KHR, the geometryType member"
6166 " of elements of either pGeometries or ppGeometries must be VK_GEOMETRY_TYPE_INSTANCES_KHR",
6167 api_name);
6168 }
6169 if (pInfos[i].type == VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_KHR) {
6170 if (pInfos[i].pGeometries[j].geometryType == VK_GEOMETRY_TYPE_INSTANCES_KHR) {
6171 skip |= LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-type-03791",
6172 "(%s): If type is VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_KHR the geometryType member "
6173 "of elements of"
6174 " either pGeometries or ppGeometries must not be VK_GEOMETRY_TYPE_INSTANCES_KHR",
6175 api_name);
6176 }
6177 if (pInfos[i].pGeometries[j].geometryType != pInfos[i].pGeometries[0].geometryType) {
6178 skip |= LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-type-03792",
6179 "(%s): If type is VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_KHR then the geometryType"
6180 " member of each geometry in either pGeometries or ppGeometries must be the same.",
6181 api_name);
6182 }
6183 }
6184 }
6185 }
6186 if (pInfos[i].ppGeometries != NULL) {
6187 for (uint32_t j = 0; j < pInfos[i].geometryCount; ++j) {
6188 skip |= validate_ranged_enum(
6189 api_name, ParameterName("pInfos[%i].ppGeometries[%i]->geometryType", ParameterName::IndexVector{i, j}),
6190 "VkGeometryTypeKHR", AllVkGeometryTypeKHREnums, pInfos[i].ppGeometries[j]->geometryType,
6191 "VUID-VkAccelerationStructureGeometryKHR-geometryType-parameter");
6192 if (pInfos[i].ppGeometries[j]->geometryType == VK_GEOMETRY_TYPE_TRIANGLES_KHR) {
sourav parmarcd5fb182020-07-17 12:58:44 -07006193 skip |= validate_struct_type(api_name, "pInfos[i].pGeometries[j].geometry.triangles",
6194 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_TRIANGLES_DATA_KHR",
6195 &pInfos[i].ppGeometries[j]->geometry.triangles,
6196 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_TRIANGLES_DATA_KHR, true,
6197 "VUID-VkAccelerationStructureGeometryKHR-triangles-parameter", kVUIDUndefined);
6198 skip |= validate_struct_type(
6199 api_name,
6200 ParameterName("pInfos[%i].ppGeometries[%i]->geometry.triangles", ParameterName::IndexVector{i, j}),
6201 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_TRIANGLES_DATA_KHR",
6202 &(pInfos[i].ppGeometries[j]->geometry.triangles),
6203 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_TRIANGLES_DATA_KHR, false, kVUIDUndefined,
6204 "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-sType-sType");
6205 skip |= validate_struct_pnext(
6206 api_name,
6207 ParameterName("pInfos[%i].ppGeometries[%i]->geometry.triangles.pNext", ParameterName::IndexVector{i, j}),
6208 NULL, pInfos[i].ppGeometries[j]->geometry.triangles.pNext, 0, NULL, GeneratedVulkanHeaderVersion,
6209 "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-pNext-pNext", kVUIDUndefined);
6210 skip |= validate_ranged_enum(api_name,
6211 ParameterName("pInfos[%i].ppGeometries[%i]->geometry.triangles.vertexFormat",
6212 ParameterName::IndexVector{i, j}),
6213 "VkFormat", AllVkFormatEnums,
6214 pInfos[i].ppGeometries[j]->geometry.triangles.vertexFormat,
6215 "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-vertexFormat-parameter");
6216 skip |= validate_ranged_enum(api_name,
6217 ParameterName("pInfos[%i].ppGeometries[%i]->geometry.triangles.indexType",
6218 ParameterName::IndexVector{i, j}),
6219 "VkIndexType", AllVkIndexTypeEnums,
6220 pInfos[i].ppGeometries[j]->geometry.triangles.indexType,
6221 "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-indexType-parameter");
6222 if (pInfos[i].ppGeometries[j]->geometry.triangles.vertexStride > UINT32_MAX) {
6223 skip |= LogError(device, "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-vertexStride-03819",
6224 "(%s):vertexStride must be less than or equal to 2^32-1", api_name);
6225 }
6226 if (pInfos[i].ppGeometries[j]->geometry.triangles.indexType != VK_INDEX_TYPE_UINT16 &&
6227 pInfos[i].ppGeometries[j]->geometry.triangles.indexType != VK_INDEX_TYPE_UINT32 &&
6228 pInfos[i].ppGeometries[j]->geometry.triangles.indexType != VK_INDEX_TYPE_NONE_KHR) {
6229 skip |=
6230 LogError(device, "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-indexType-03798",
6231 "(%s):indexType must be VK_INDEX_TYPE_UINT16, VK_INDEX_TYPE_UINT32, or VK_INDEX_TYPE_NONE_KHR",
6232 api_name);
6233 }
6234 }
6235 if (pInfos[i].ppGeometries[j]->geometryType == VK_GEOMETRY_TYPE_INSTANCES_KHR) {
6236 skip |= validate_struct_type(api_name, "pInfos[i].pGeometries[j].geometry.instances",
6237 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_INSTANCES_DATA_KHR",
6238 &pInfos[i].ppGeometries[j]->geometry.instances,
6239 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_INSTANCES_DATA_KHR, true,
6240 "VUID-VkAccelerationStructureGeometryKHR-instances-parameter", kVUIDUndefined);
6241 skip |= validate_struct_type(
6242 api_name,
6243 ParameterName("pInfos[%i].ppGeometries[%i]->geometry.instances", ParameterName::IndexVector{i, j}),
6244 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_INSTANCES_DATA_KHR",
6245 &(pInfos[i].ppGeometries[j]->geometry.instances),
6246 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_INSTANCES_DATA_KHR, false, kVUIDUndefined,
6247 "VUID-VkAccelerationStructureGeometryInstancesDataKHR-sType-sType");
6248 skip |= validate_struct_pnext(
6249 api_name,
6250 ParameterName("pInfos[%i].ppGeometries[%i]->geometry.instances.pNext", ParameterName::IndexVector{i, j}),
6251 NULL, pInfos[i].ppGeometries[j]->geometry.instances.pNext, 0, NULL, GeneratedVulkanHeaderVersion,
6252 "VUID-VkAccelerationStructureGeometryInstancesDataKHR-pNext-pNext", kVUIDUndefined);
6253 skip |= validate_bool32(api_name,
6254 ParameterName("pInfos[%i].ppGeometries[%i]->geometry.instances.arrayOfPointers",
6255 ParameterName::IndexVector{i, j}),
6256 pInfos[i].ppGeometries[j]->geometry.instances.arrayOfPointers);
6257 }
6258 if (pInfos[i].ppGeometries[j]->geometryType == VK_GEOMETRY_TYPE_AABBS_KHR) {
6259 skip |= validate_struct_type(api_name, "pInfos[i].pGeometries[j].geometry.aabbs",
6260 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_AABBS_DATA_KHR",
6261 &pInfos[i].ppGeometries[j]->geometry.aabbs,
6262 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_AABBS_DATA_KHR, true,
6263 "VUID-VkAccelerationStructureGeometryKHR-aabbs-parameter", kVUIDUndefined);
6264 skip |= validate_struct_type(
6265 api_name, ParameterName("pInfos[%i].ppGeometries[%i]->geometry.aabbs", ParameterName::IndexVector{i, j}),
6266 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_AABBS_DATA_KHR",
6267 &(pInfos[i].ppGeometries[j]->geometry.aabbs),
6268 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_AABBS_DATA_KHR, false, kVUIDUndefined,
6269 "VUID-VkAccelerationStructureGeometryAabbsDataKHR-sType-sType");
6270 skip |= validate_struct_pnext(
6271 api_name,
6272 ParameterName("pInfos[%i].ppGeometries[%i]->geometry.aabbs.pNext", ParameterName::IndexVector{i, j}), NULL,
6273 pInfos[i].ppGeometries[j]->geometry.aabbs.pNext, 0, NULL, GeneratedVulkanHeaderVersion,
6274 "VUID-VkAccelerationStructureGeometryAabbsDataKHR-pNext-pNext", kVUIDUndefined);
6275 if (pInfos[i].ppGeometries[j]->geometry.aabbs.stride > UINT32_MAX) {
6276 skip |= LogError(device, "VUID-VkAccelerationStructureGeometryAabbsDataKHR-stride-03820",
6277 "(%s):stride must be less than or equal to 2^32-1", api_name);
6278 }
6279 }
6280 if (pInfos[i].type == VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_KHR &&
6281 pInfos[i].ppGeometries[j]->geometryType != VK_GEOMETRY_TYPE_INSTANCES_KHR) {
6282 skip |= LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-type-03789",
6283 "(%s): If type is VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_KHR, the geometryType member"
6284 " of elements of either pGeometries or ppGeometries must be VK_GEOMETRY_TYPE_INSTANCES_KHR",
6285 api_name);
6286 }
6287 if (pInfos[i].type == VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_KHR) {
6288 if (pInfos[i].ppGeometries[j]->geometryType == VK_GEOMETRY_TYPE_INSTANCES_KHR) {
6289 skip |= LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-type-03791",
6290 "(%s): If type is VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_KHR the geometryType member "
6291 "of elements of"
6292 " either pGeometries or ppGeometries must not be VK_GEOMETRY_TYPE_INSTANCES_KHR",
6293 api_name);
6294 }
6295 if (pInfos[i].ppGeometries[j]->geometryType != pInfos[i].ppGeometries[0]->geometryType) {
6296 skip |= LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-type-03792",
6297 "(%s): If type is VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_KHR then the geometryType"
6298 " member of each geometry in either pGeometries or ppGeometries must be the same.",
6299 api_name);
6300 }
6301 }
6302 }
6303 }
6304 }
6305 return skip;
6306}
6307bool StatelessValidation::manual_PreCallValidateCmdBuildAccelerationStructuresKHR(
6308 VkCommandBuffer commandBuffer, uint32_t infoCount, const VkAccelerationStructureBuildGeometryInfoKHR *pInfos,
6309 const VkAccelerationStructureBuildRangeInfoKHR *const *ppBuildRangeInfos) const {
6310 bool skip = false;
6311 skip |= ValidateAccelerationStructureBuildGeometryInfoKHR(pInfos, infoCount, "vkCmdBuildAccelerationStructuresKHR");
6312 for (uint32_t i = 0; i < infoCount; ++i) {
6313 if (SafeModulo(pInfos[i].scratchData.deviceAddress,
6314 phys_dev_ext_props.acc_structure_props.minAccelerationStructureScratchOffsetAlignment) != 0) {
6315 skip |= LogError(device, "VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-03710",
6316 "vkCmdBuildAccelerationStructuresKHR:For each element of pInfos, its "
6317 "scratchData.deviceAddress member must be a multiple of "
6318 "VkPhysicalDeviceAccelerationStructurePropertiesKHR::minAccelerationStructureScratchOffsetAlignment.");
6319 }
6320 for (uint32_t k = 0; k < infoCount; ++k) {
6321 if (i == k) continue;
6322 bool found = false;
6323 if (pInfos[i].dstAccelerationStructure == pInfos[k].dstAccelerationStructure) {
6324 skip |= LogError(
6325 device, "VUID-vkCmdBuildAccelerationStructuresKHR-dstAccelerationStructure-03698",
6326 "vkCmdBuildAccelerationStructuresKHR:The dstAccelerationStructure member of any element (%d) of pInfos must "
6327 "not be "
6328 "the same acceleration structure as the dstAccelerationStructure member of any other element (%d) of pInfos.",
6329 i, k);
6330 found = true;
6331 }
6332 if (pInfos[i].srcAccelerationStructure == pInfos[k].dstAccelerationStructure) {
6333 skip |= LogError(
6334 device, "VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-03403",
6335 "vkCmdBuildAccelerationStructuresKHR:The srcAccelerationStructure member of any element (%d) of pInfos must "
6336 "not be "
6337 "the same acceleration structure as the dstAccelerationStructure member of any other element (%d) of pInfos.",
6338 i, k);
6339 found = true;
6340 }
6341 if (found) break;
6342 }
6343 for (uint32_t j = 0; j < pInfos[i].geometryCount; ++j) {
6344 if (pInfos[i].pGeometries) {
6345 if (pInfos[i].pGeometries[j].geometryType == VK_GEOMETRY_TYPE_INSTANCES_KHR) {
6346 if (pInfos[i].pGeometries[j].geometry.instances.arrayOfPointers == VK_TRUE) {
6347 if (SafeModulo(pInfos[i].pGeometries[j].geometry.instances.data.deviceAddress, 8) != 0) {
6348 skip |= LogError(device, "VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-03716",
6349 "vkCmdBuildAccelerationStructuresKHR:For any element of pInfos[i].pGeometries with a "
6350 "geometryType of VK_GEOMETRY_TYPE_INSTANCES_KHR, if geometry.arrayOfPointers is "
6351 "VK_TRUE, geometry.data->deviceAddress must be aligned to 8 bytes.");
6352 }
6353 } else {
6354 if (SafeModulo(pInfos[i].pGeometries[j].geometry.instances.data.deviceAddress, 16) != 0) {
6355 skip |=
6356 LogError(device, "VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-03715",
6357 "vkCmdBuildAccelerationStructuresKHR:For any element of pInfos[i].pGeometries with a "
6358 "geometryType of VK_GEOMETRY_TYPE_INSTANCES_KHR, if geometry.arrayOfPointers is VK_FALSE, "
6359 "geometry.data->deviceAddress must be aligned to 16 bytes.");
6360 }
6361 }
Ricardo Garcia2ba3da82020-12-02 11:27:53 +01006362 } else if (pInfos[i].pGeometries[j].geometryType == VK_GEOMETRY_TYPE_AABBS_KHR) {
sourav parmarcd5fb182020-07-17 12:58:44 -07006363 if (SafeModulo(pInfos[i].pGeometries[j].geometry.instances.data.deviceAddress, 8) != 0) {
6364 skip |= LogError(
6365 device, "VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-03714",
6366 "vkCmdBuildAccelerationStructuresKHR:For any element of pInfos[i].pGeometries with a "
6367 "geometryType of VK_GEOMETRY_TYPE_AABBS_KHR, geometry.data->deviceAddress must be aligned to 8 bytes.");
6368 }
Ricardo Garcia2ba3da82020-12-02 11:27:53 +01006369 } else if (pInfos[i].pGeometries[j].geometryType == VK_GEOMETRY_TYPE_TRIANGLES_KHR) {
6370 if (SafeModulo(pInfos[i].pGeometries[j].geometry.triangles.transformData.deviceAddress, 16) != 0) {
sourav parmarcd5fb182020-07-17 12:58:44 -07006371 skip |= LogError(device, "VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-03810",
6372 "vkCmdBuildAccelerationStructuresKHR:For any element of pInfos[i].pGeometries "
6373 "with a geometryType of VK_GEOMETRY_TYPE_TRIANGLES_KHR, "
6374 "geometry.transformData->deviceAddress must be aligned to 16 bytes.");
6375 }
6376 }
6377 } else if (pInfos[i].ppGeometries) {
6378 if (pInfos[i].ppGeometries[j]->geometryType == VK_GEOMETRY_TYPE_INSTANCES_KHR) {
6379 if (pInfos[i].ppGeometries[j]->geometry.instances.arrayOfPointers == VK_TRUE) {
6380 if (SafeModulo(pInfos[i].ppGeometries[j]->geometry.instances.data.deviceAddress, 8) != 0) {
6381 skip |= LogError(device, "VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-03716",
6382 "vkCmdBuildAccelerationStructuresKHR:For any element of pInfos[i].pGeometries with a "
6383 "geometryType of VK_GEOMETRY_TYPE_INSTANCES_KHR, if geometry.arrayOfPointers is "
6384 "VK_TRUE, geometry.data->deviceAddress must be aligned to 8 bytes.");
6385 }
6386 } else {
6387 if (SafeModulo(pInfos[i].ppGeometries[j]->geometry.instances.data.deviceAddress, 16) != 0) {
6388 skip |=
6389 LogError(device, "VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-03715",
6390 "vkCmdBuildAccelerationStructuresKHR:For any element of pInfos[i].pGeometries with a "
6391 "geometryType of VK_GEOMETRY_TYPE_INSTANCES_KHR, if geometry.arrayOfPointers is VK_FALSE, "
6392 "geometry.data->deviceAddress must be aligned to 16 bytes.");
6393 }
6394 }
Ricardo Garcia2ba3da82020-12-02 11:27:53 +01006395 } else if (pInfos[i].ppGeometries[j]->geometryType == VK_GEOMETRY_TYPE_AABBS_KHR) {
sourav parmarcd5fb182020-07-17 12:58:44 -07006396 if (SafeModulo(pInfos[i].ppGeometries[j]->geometry.instances.data.deviceAddress, 8) != 0) {
6397 skip |= LogError(
6398 device, "VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-03714",
6399 "vkCmdBuildAccelerationStructuresKHR:For any element of pInfos[i].pGeometries with a "
6400 "geometryType of VK_GEOMETRY_TYPE_AABBS_KHR, geometry.data->deviceAddress must be aligned to 8 bytes.");
6401 }
Ricardo Garcia2ba3da82020-12-02 11:27:53 +01006402 } else if (pInfos[i].ppGeometries[j]->geometryType == VK_GEOMETRY_TYPE_TRIANGLES_KHR) {
6403 if (SafeModulo(pInfos[i].ppGeometries[j]->geometry.triangles.transformData.deviceAddress, 16) != 0) {
sourav parmarcd5fb182020-07-17 12:58:44 -07006404 skip |= LogError(device, "VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-03810",
6405 "vkCmdBuildAccelerationStructuresKHR:For any element of pInfos[i].pGeometries "
6406 "with a geometryType of VK_GEOMETRY_TYPE_TRIANGLES_KHR, "
6407 "geometry.transformData->deviceAddress must be aligned to 16 bytes.");
6408 }
6409 }
6410 }
6411 }
6412 }
6413 return skip;
6414}
6415
6416bool StatelessValidation::manual_PreCallValidateCmdBuildAccelerationStructuresIndirectKHR(
6417 VkCommandBuffer commandBuffer, uint32_t infoCount, const VkAccelerationStructureBuildGeometryInfoKHR *pInfos,
6418 const VkDeviceAddress *pIndirectDeviceAddresses, const uint32_t *pIndirectStrides,
6419 const uint32_t *const *ppMaxPrimitiveCounts) const {
6420 bool skip = false;
6421 skip |= ValidateAccelerationStructureBuildGeometryInfoKHR(pInfos, infoCount, "vkCmdBuildAccelerationStructuresIndirectKHR");
6422 const auto *ray_tracing_acceleration_structure_features =
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07006423 LvlFindInChain<VkPhysicalDeviceAccelerationStructureFeaturesKHR>(device_createinfo_pnext);
sourav parmarcd5fb182020-07-17 12:58:44 -07006424 if (!ray_tracing_acceleration_structure_features ||
6425 ray_tracing_acceleration_structure_features->accelerationStructureIndirectBuild == VK_FALSE) {
6426 skip |= LogError(
6427 device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-accelerationStructureIndirectBuild-03650",
6428 "vkCmdBuildAccelerationStructuresIndirectKHR: The "
6429 "VkPhysicalDeviceAccelerationStructureFeaturesKHR::accelerationStructureIndirectBuild feature must be enabled.");
6430 }
6431 for (uint32_t i = 0; i < infoCount; ++i) {
6432 if (pInfos[i].mode == VK_BUILD_ACCELERATION_STRUCTURE_MODE_UPDATE_KHR) {
6433 if (pInfos[i].srcAccelerationStructure == VK_NULL_HANDLE) {
6434 skip |= LogError(device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-03666",
6435 "vkCmdBuildAccelerationStructuresIndirectKHR:For each element of pInfos, if its mode member is "
6436 "VK_BUILD_ACCELERATION_STRUCTURE_MODE_UPDATE_KHR, its srcAccelerationStructure member must not be "
6437 "VK_NULL_HANDLE.");
6438 }
6439 }
6440 if (SafeModulo(pInfos[i].scratchData.deviceAddress,
6441 phys_dev_ext_props.acc_structure_props.minAccelerationStructureScratchOffsetAlignment) != 0) {
6442 skip |= LogError(device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-03710",
6443 "vkCmdBuildAccelerationStructuresIndirectKHR:For each element of pInfos, its "
6444 "scratchData.deviceAddress member must be a multiple of "
6445 "VkPhysicalDeviceAccelerationStructurePropertiesKHR::minAccelerationStructureScratchOffsetAlignment.");
6446 }
6447 for (uint32_t k = 0; k < infoCount; ++k) {
6448 if (i == k) continue;
6449 if (pInfos[i].srcAccelerationStructure == pInfos[k].dstAccelerationStructure) {
6450 skip |=
6451 LogError(device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-03403",
6452 "vkCmdBuildAccelerationStructuresIndirectKHR:The srcAccelerationStructure member of any element (%d) "
6453 "of pInfos must not be the same acceleration structure as the dstAccelerationStructure member of "
6454 "any other element [%d) of pInfos.",
6455 i, k);
6456 break;
6457 }
6458 }
6459 for (uint32_t j = 0; j < pInfos[i].geometryCount; ++j) {
6460 if (pInfos[i].pGeometries) {
6461 if (pInfos[i].pGeometries[j].geometryType == VK_GEOMETRY_TYPE_INSTANCES_KHR) {
6462 if (pInfos[i].pGeometries[j].geometry.instances.arrayOfPointers == VK_TRUE) {
6463 if (SafeModulo(pInfos[i].pGeometries[j].geometry.instances.data.deviceAddress, 8) != 0) {
6464 skip |= LogError(
6465 device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-03716",
6466 "vkCmdBuildAccelerationStructuresIndirectKHR:For any element of pInfos[i].pGeometries with a "
6467 "geometryType of VK_GEOMETRY_TYPE_INSTANCES_KHR, if geometry.arrayOfPointers is "
6468 "VK_TRUE, geometry.data->deviceAddress must be aligned to 8 bytes.");
6469 }
6470 } else {
6471 if (SafeModulo(pInfos[i].pGeometries[j].geometry.instances.data.deviceAddress, 16) != 0) {
6472 skip |= LogError(
6473 device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-03715",
6474 "vkCmdBuildAccelerationStructuresIndirectKHR:For any element of pInfos[i].pGeometries with a "
6475 "geometryType of VK_GEOMETRY_TYPE_INSTANCES_KHR, if geometry.arrayOfPointers is VK_FALSE, "
6476 "geometry.data->deviceAddress must be aligned to 16 bytes.");
6477 }
6478 }
6479 }
6480 if (pInfos[i].pGeometries[j].geometryType == VK_GEOMETRY_TYPE_AABBS_KHR) {
6481 if (SafeModulo(pInfos[i].pGeometries[j].geometry.instances.data.deviceAddress, 8) != 0) {
6482 skip |= LogError(
6483 device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-03714",
6484 "vkCmdBuildAccelerationStructuresIndirectKHR:For any element of pInfos[i].pGeometries with a "
6485 "geometryType of VK_GEOMETRY_TYPE_AABBS_KHR, geometry.data->deviceAddress must be aligned to 8 bytes.");
6486 }
6487 }
6488 if (pInfos[i].pGeometries[j].geometryType == VK_GEOMETRY_TYPE_TRIANGLES_KHR) {
6489 if (SafeModulo(pInfos[i].pGeometries[j].geometry.triangles.indexData.deviceAddress, 16) != 0) {
6490 skip |= LogError(device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-03810",
6491 "vkCmdBuildAccelerationStructuresIndirectKHR:For any element of pInfos[i].pGeometries "
6492 "with a geometryType of VK_GEOMETRY_TYPE_TRIANGLES_KHR, "
6493 "geometry.transformData->deviceAddress must be aligned to 16 bytes.");
6494 }
6495 }
6496 } else if (pInfos[i].ppGeometries) {
6497 if (pInfos[i].ppGeometries[j]->geometryType == VK_GEOMETRY_TYPE_INSTANCES_KHR) {
6498 if (pInfos[i].ppGeometries[j]->geometry.instances.arrayOfPointers == VK_TRUE) {
6499 if (SafeModulo(pInfos[i].ppGeometries[j]->geometry.instances.data.deviceAddress, 8) != 0) {
6500 skip |= LogError(
6501 device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-03716",
6502 "vkCmdBuildAccelerationStructuresIndirectKHR:For any element of pInfos[i].pGeometries with a "
6503 "geometryType of VK_GEOMETRY_TYPE_INSTANCES_KHR, if geometry.arrayOfPointers is "
6504 "VK_TRUE, geometry.data->deviceAddress must be aligned to 8 bytes.");
6505 }
6506 } else {
6507 if (SafeModulo(pInfos[i].ppGeometries[j]->geometry.instances.data.deviceAddress, 16) != 0) {
6508 skip |= LogError(
6509 device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-03715",
6510 "vkCmdBuildAccelerationStructuresIndirectKHR:For any element of pInfos[i].pGeometries with a "
6511 "geometryType of VK_GEOMETRY_TYPE_INSTANCES_KHR, if geometry.arrayOfPointers is VK_FALSE, "
6512 "geometry.data->deviceAddress must be aligned to 16 bytes.");
6513 }
6514 }
6515 }
6516 if (pInfos[i].ppGeometries[j]->geometryType == VK_GEOMETRY_TYPE_AABBS_KHR) {
6517 if (SafeModulo(pInfos[i].ppGeometries[j]->geometry.instances.data.deviceAddress, 8) != 0) {
6518 skip |= LogError(
6519 device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-03714",
6520 "vkCmdBuildAccelerationStructuresIndirectKHR:For any element of pInfos[i].pGeometries with a "
6521 "geometryType of VK_GEOMETRY_TYPE_AABBS_KHR, geometry.data->deviceAddress must be aligned to 8 bytes.");
6522 }
6523 }
6524 if (pInfos[i].ppGeometries[j]->geometryType == VK_GEOMETRY_TYPE_TRIANGLES_KHR) {
6525 if (SafeModulo(pInfos[i].ppGeometries[j]->geometry.triangles.indexData.deviceAddress, 16) != 0) {
6526 skip |= LogError(device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-03810",
6527 "vkCmdBuildAccelerationStructuresIndirectKHR:For any element of pInfos[i].pGeometries "
6528 "with a geometryType of VK_GEOMETRY_TYPE_TRIANGLES_KHR, "
6529 "geometry.transformData->deviceAddress must be aligned to 16 bytes.");
6530 }
6531 }
6532 }
6533 }
6534 }
6535 return skip;
6536}
6537
6538bool StatelessValidation::manual_PreCallValidateBuildAccelerationStructuresKHR(
6539 VkDevice device, VkDeferredOperationKHR deferredOperation, uint32_t infoCount,
6540 const VkAccelerationStructureBuildGeometryInfoKHR *pInfos,
6541 const VkAccelerationStructureBuildRangeInfoKHR *const *ppBuildRangeInfos) const {
6542 bool skip = false;
6543 skip |= ValidateAccelerationStructureBuildGeometryInfoKHR(pInfos, infoCount, "vkBuildAccelerationStructuresKHR");
6544 const auto *ray_tracing_acceleration_structure_features =
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07006545 LvlFindInChain<VkPhysicalDeviceAccelerationStructureFeaturesKHR>(device_createinfo_pnext);
sourav parmarcd5fb182020-07-17 12:58:44 -07006546 if (!ray_tracing_acceleration_structure_features ||
6547 ray_tracing_acceleration_structure_features->accelerationStructureHostCommands == VK_FALSE) {
6548 skip |=
6549 LogError(device, "VUID-vkBuildAccelerationStructuresKHR-accelerationStructureHostCommands-03581",
6550 "vkBuildAccelerationStructuresKHR: The "
6551 "VkPhysicalDeviceAccelerationStructureFeaturesKHR::accelerationStructureHostCommands feature must be enabled");
6552 }
6553 for (uint32_t i = 0; i < infoCount; ++i) {
6554 for (uint32_t j = 0; j < infoCount; ++j) {
6555 if (i == j) continue;
6556 bool found = false;
6557 if (pInfos[i].dstAccelerationStructure == pInfos[j].dstAccelerationStructure) {
6558 skip |= LogError(
6559 device, "VUID-vkBuildAccelerationStructuresKHR-dstAccelerationStructure-03698",
6560 "vkBuildAccelerationStructuresKHR(): The dstAccelerationStructure member of any element (%d) of pInfos must "
6561 "not be "
6562 "the same acceleration structure as the dstAccelerationStructure member of any other element (%d) of pInfos.",
6563 i, j);
6564 found = true;
6565 }
6566 if (pInfos[i].srcAccelerationStructure == pInfos[j].dstAccelerationStructure) {
6567 skip |= LogError(
6568 device, "VUID-vkBuildAccelerationStructuresKHR-pInfos-03403",
6569 "vkBuildAccelerationStructuresKHR(): The srcAccelerationStructure member of any element (%d) of pInfos must "
6570 "not be "
6571 "the same acceleration structure as the dstAccelerationStructure member of any other element (%d) of pInfos.",
6572 i, j);
6573 found = true;
6574 }
6575 if (found) break;
6576 }
6577 }
6578 return skip;
6579}
6580
6581bool StatelessValidation::manual_PreCallValidateGetAccelerationStructureBuildSizesKHR(
6582 VkDevice device, VkAccelerationStructureBuildTypeKHR buildType, const VkAccelerationStructureBuildGeometryInfoKHR *pBuildInfo,
6583 const uint32_t *pMaxPrimitiveCounts, VkAccelerationStructureBuildSizesInfoKHR *pSizeInfo) const {
6584 bool skip = false;
6585 skip |= ValidateAccelerationStructureBuildGeometryInfoKHR(pBuildInfo, 1, "vkGetAccelerationStructureBuildSizesKHR");
6586 const auto *ray_tracing_pipeline_features =
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07006587 LvlFindInChain<VkPhysicalDeviceRayTracingPipelineFeaturesKHR>(device_createinfo_pnext);
6588 const auto *ray_query_features = LvlFindInChain<VkPhysicalDeviceRayQueryFeaturesKHR>(device_createinfo_pnext);
sourav parmarcd5fb182020-07-17 12:58:44 -07006589 if (!(ray_tracing_pipeline_features || ray_query_features) ||
6590 ((ray_tracing_pipeline_features && ray_tracing_pipeline_features->rayTracingPipeline == VK_FALSE) ||
6591 (ray_query_features && ray_query_features->rayQuery == VK_FALSE))) {
6592 skip |= LogError(device, "VUID-vkGetAccelerationStructureBuildSizesKHR-rayTracingPipeline-03617",
6593 "vkGetAccelerationStructureBuildSizesKHR:The rayTracingPipeline or rayQuery feature must be enabled");
6594 }
6595 return skip;
6596}