blob: 65a048bbc51aab71538e8ab3008383b3ece807f6 [file] [log] [blame]
Shahbaz Youssefi6be11412019-01-10 15:29:30 -05001/* Copyright (c) 2015-2019 The Khronos Group Inc.
2 * Copyright (c) 2015-2019 Valve Corporation
3 * Copyright (c) 2015-2019 LunarG, Inc.
4 * Copyright (C) 2015-2019 Google Inc.
Mark Lobodzinskid4950072017-08-01 13:02:20 -06005 *
6 * Licensed under the Apache License, Version 2.0 (the "License");
7 * you may not use this file except in compliance with the License.
8 * You may obtain a copy of the License at
9 *
10 * http://www.apache.org/licenses/LICENSE-2.0
11 *
12 * Unless required by applicable law or agreed to in writing, software
13 * distributed under the License is distributed on an "AS IS" BASIS,
14 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15 * See the License for the specific language governing permissions and
16 * limitations under the License.
17 *
18 * Author: Mark Lobodzinski <mark@LunarG.com>
John Zulaufa999d1b2018-11-29 13:38:40 -070019 * Author: John Zulauf <jzulauf@lunarg.com>
Mark Lobodzinskid4950072017-08-01 13:02:20 -060020 */
21
22#define NOMINMAX
Shahbaz Youssefi6be11412019-01-10 15:29:30 -050023
24#include <math.h>
25
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -070026#include "chassis.h"
27#include "stateless_validation.h"
Tobias Hectord942eb92018-10-22 15:18:56 +010028
Mark Lobodzinskid4950072017-08-01 13:02:20 -060029static const int MaxParamCheckerStringLength = 256;
30
John Zulauf71968502017-10-26 13:51:15 -060031template <typename T>
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -070032inline bool in_inclusive_range(const T &value, const T &min, const T &max) {
John Zulauf71968502017-10-26 13:51:15 -060033 // Using only < for generality and || for early abort
34 return !((value < min) || (max < value));
35}
36
Mark Lobodzinskibf599b92018-12-31 12:15:55 -070037bool StatelessValidation::validate_string(const char *apiName, const ParameterName &stringName, const std::string &vuid,
38 const char *validateString) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -060039 bool skip = false;
40
41 VkStringErrorFlags result = vk_string_validate(MaxParamCheckerStringLength, validateString);
42
43 if (result == VK_STRING_ERROR_NONE) {
44 return skip;
45 } else if (result & VK_STRING_ERROR_LENGTH) {
Mark Lobodzinskiebee3552018-05-29 09:55:54 -060046 skip = log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, vuid,
47 "%s: string %s exceeds max length %d", apiName, stringName.get_name().c_str(), MaxParamCheckerStringLength);
Mark Lobodzinskid4950072017-08-01 13:02:20 -060048 } else if (result & VK_STRING_ERROR_BAD_DATA) {
Mark Lobodzinskiebee3552018-05-29 09:55:54 -060049 skip = log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, vuid,
50 "%s: string %s contains invalid characters or is badly formed", apiName, stringName.get_name().c_str());
Mark Lobodzinskid4950072017-08-01 13:02:20 -060051 }
52 return skip;
53}
54
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -070055bool StatelessValidation::validate_api_version(uint32_t api_version, uint32_t effective_api_version) {
John Zulauf620755c2018-04-16 11:00:43 -060056 bool skip = false;
57 uint32_t api_version_nopatch = VK_MAKE_VERSION(VK_VERSION_MAJOR(api_version), VK_VERSION_MINOR(api_version), 0);
58 if (api_version_nopatch != effective_api_version) {
59 if (api_version_nopatch < VK_API_VERSION_1_0) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -070060 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_INSTANCE_EXT,
61 HandleToUint64(instance), kVUIDUndefined,
John Zulauf620755c2018-04-16 11:00:43 -060062 "Invalid CreateInstance->pCreateInfo->pApplicationInfo.apiVersion number (0x%08x). "
63 "Using VK_API_VERSION_%" PRIu32 "_%" PRIu32 ".",
64 api_version, VK_VERSION_MAJOR(effective_api_version), VK_VERSION_MINOR(effective_api_version));
65 } else {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -070066 skip |= log_msg(report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_INSTANCE_EXT,
67 HandleToUint64(instance), kVUIDUndefined,
John Zulauf620755c2018-04-16 11:00:43 -060068 "Unrecognized CreateInstance->pCreateInfo->pApplicationInfo.apiVersion number (0x%08x). "
69 "Assuming VK_API_VERSION_%" PRIu32 "_%" PRIu32 ".",
70 api_version, VK_VERSION_MAJOR(effective_api_version), VK_VERSION_MINOR(effective_api_version));
71 }
72 }
73 return skip;
74}
75
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -070076bool StatelessValidation::validate_instance_extensions(const VkInstanceCreateInfo *pCreateInfo) {
John Zulauf620755c2018-04-16 11:00:43 -060077 bool skip = false;
78 for (uint32_t i = 0; i < pCreateInfo->enabledExtensionCount; i++) {
Mark Lobodzinskibf599b92018-12-31 12:15:55 -070079 skip |= validate_extension_reqs(instance_extensions, "VUID-vkCreateInstance-ppEnabledExtensionNames-01388", "instance",
80 pCreateInfo->ppEnabledExtensionNames[i]);
John Zulauf620755c2018-04-16 11:00:43 -060081 }
82
83 return skip;
84}
85
John Zulauf620755c2018-04-16 11:00:43 -060086template <typename ExtensionState>
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -070087bool extension_state_by_name(const ExtensionState &extensions, const char *extension_name) {
John Zulauf620755c2018-04-16 11:00:43 -060088 if (!extension_name) return false; // null strings specify nothing
89 auto info = ExtensionState::get_info(extension_name);
90 bool state = info.state ? extensions.*(info.state) : false; // unknown extensions can't be enabled in extension struct
91 return state;
92}
93
Mark Lobodzinskibf599b92018-12-31 12:15:55 -070094bool StatelessValidation::manual_PreCallValidateCreateInstance(const VkInstanceCreateInfo *pCreateInfo,
95 const VkAllocationCallbacks *pAllocator, VkInstance *pInstance) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -070096 bool skip = false;
97 // Note: From the spec--
98 // Providing a NULL VkInstanceCreateInfo::pApplicationInfo or providing an apiVersion of 0 is equivalent to providing
99 // an apiVersion of VK_MAKE_VERSION(1, 0, 0). (a.k.a. VK_API_VERSION_1_0)
100 uint32_t local_api_version = (pCreateInfo->pApplicationInfo && pCreateInfo->pApplicationInfo->apiVersion)
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700101 ? pCreateInfo->pApplicationInfo->apiVersion
102 : VK_API_VERSION_1_0;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700103 skip |= validate_api_version(local_api_version, api_version);
104 skip |= validate_instance_extensions(pCreateInfo);
105 return skip;
106}
107
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700108void StatelessValidation::PostCallRecordCreateInstance(const VkInstanceCreateInfo *pCreateInfo,
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -0700109 const VkAllocationCallbacks *pAllocator, VkInstance *pInstance,
110 VkResult result) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700111 auto instance_data = GetLayerDataPtr(get_dispatch_key(*pInstance), layer_data_map);
112 // Copy extension data into local object
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -0700113 if (result != VK_SUCCESS) return;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700114 this->instance_extensions = instance_data->instance_extensions;
115}
116
117void StatelessValidation::PostCallRecordCreateDevice(VkPhysicalDevice physicalDevice, const VkDeviceCreateInfo *pCreateInfo,
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -0700118 const VkAllocationCallbacks *pAllocator, VkDevice *pDevice, VkResult result) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700119 auto device_data = GetLayerDataPtr(get_dispatch_key(*pDevice), layer_data_map);
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -0700120 if (result != VK_SUCCESS) return;
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700121 ValidationObject *validation_data = GetValidationObject(device_data->object_dispatch, LayerObjectTypeParameterValidation);
122 StatelessValidation *stateless_validation = static_cast<StatelessValidation *>(validation_data);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700123
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700124 // Parmeter validation also uses extension data
125 stateless_validation->device_extensions = this->device_extensions;
126
127 VkPhysicalDeviceProperties device_properties = {};
128 // Need to get instance and do a getlayerdata call...
129 ValidationObject *instance_object = GetLayerDataPtr(get_dispatch_key(physicalDevice), layer_data_map);
130 instance_object->instance_dispatch_table.GetPhysicalDeviceProperties(physicalDevice, &device_properties);
131 memcpy(&stateless_validation->device_limits, &device_properties.limits, sizeof(VkPhysicalDeviceLimits));
132
133 if (device_extensions.vk_nv_shading_rate_image) {
134 // Get the needed shading rate image limits
135 auto shading_rate_image_props = lvl_init_struct<VkPhysicalDeviceShadingRateImagePropertiesNV>();
136 auto prop2 = lvl_init_struct<VkPhysicalDeviceProperties2KHR>(&shading_rate_image_props);
137 instance_object->instance_dispatch_table.GetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
138 phys_dev_ext_props.shading_rate_image_props = shading_rate_image_props;
139 }
140
141 if (device_extensions.vk_nv_mesh_shader) {
142 // Get the needed mesh shader limits
143 auto mesh_shader_props = lvl_init_struct<VkPhysicalDeviceMeshShaderPropertiesNV>();
144 auto prop2 = lvl_init_struct<VkPhysicalDeviceProperties2KHR>(&mesh_shader_props);
145 instance_object->instance_dispatch_table.GetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
146 phys_dev_ext_props.mesh_shader_props = mesh_shader_props;
147 }
148
Jasper St. Pierrea49b4be2019-02-05 17:48:57 -0800149 stateless_validation->phys_dev_ext_props = this->phys_dev_ext_props;
150
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700151 // Save app-enabled features in this device's validation object
152 // The enabled features can come from either pEnabledFeatures, or from the pNext chain
153 const VkPhysicalDeviceFeatures *enabled_features_found = pCreateInfo->pEnabledFeatures;
154 if ((nullptr == enabled_features_found) && device_extensions.vk_khr_get_physical_device_properties_2) {
155 const auto *features2 = lvl_find_in_chain<VkPhysicalDeviceFeatures2KHR>(pCreateInfo->pNext);
156 if (features2) {
157 enabled_features_found = &(features2->features);
158 }
159 }
160 if (enabled_features_found) {
161 stateless_validation->physical_device_features = *enabled_features_found;
162 } else {
163 memset(&stateless_validation->physical_device_features, 0, sizeof(VkPhysicalDeviceFeatures));
164 }
165}
166
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700167bool StatelessValidation::manual_PreCallValidateCreateDevice(VkPhysicalDevice physicalDevice, const VkDeviceCreateInfo *pCreateInfo,
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700168 const VkAllocationCallbacks *pAllocator, VkDevice *pDevice) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600169 bool skip = false;
John Zulauf620755c2018-04-16 11:00:43 -0600170 bool maint1 = false;
171 bool negative_viewport = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600172
173 if ((pCreateInfo->enabledLayerCount > 0) && (pCreateInfo->ppEnabledLayerNames != NULL)) {
174 for (size_t i = 0; i < pCreateInfo->enabledLayerCount; i++) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700175 skip |= validate_string("vkCreateDevice", "pCreateInfo->ppEnabledLayerNames",
Mark Lobodzinskiebee3552018-05-29 09:55:54 -0600176 "VUID-VkDeviceCreateInfo-ppEnabledLayerNames-parameter", pCreateInfo->ppEnabledLayerNames[i]);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600177 }
178 }
179
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600180 if ((pCreateInfo->enabledExtensionCount > 0) && (pCreateInfo->ppEnabledExtensionNames != NULL)) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700181 maint1 = extension_state_by_name(device_extensions, VK_KHR_MAINTENANCE1_EXTENSION_NAME);
182 negative_viewport = extension_state_by_name(device_extensions, VK_AMD_NEGATIVE_VIEWPORT_HEIGHT_EXTENSION_NAME);
John Zulauf620755c2018-04-16 11:00:43 -0600183
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600184 for (size_t i = 0; i < pCreateInfo->enabledExtensionCount; i++) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700185 skip |= validate_string("vkCreateDevice", "pCreateInfo->ppEnabledExtensionNames",
Mark Lobodzinskiebee3552018-05-29 09:55:54 -0600186 "VUID-VkDeviceCreateInfo-ppEnabledExtensionNames-parameter",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600187 pCreateInfo->ppEnabledExtensionNames[i]);
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700188 skip |= validate_extension_reqs(device_extensions, "VUID-vkCreateDevice-ppEnabledExtensionNames-01387", "device",
189 pCreateInfo->ppEnabledExtensionNames[i]);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600190 }
191 }
192
193 if (maint1 && negative_viewport) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700194 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600195 "VUID-VkDeviceCreateInfo-ppEnabledExtensionNames-00374",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600196 "VkDeviceCreateInfo->ppEnabledExtensionNames must not simultaneously include VK_KHR_maintenance1 and "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600197 "VK_AMD_negative_viewport_height.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600198 }
199
200 if (pCreateInfo->pNext != NULL && pCreateInfo->pEnabledFeatures) {
201 // Check for get_physical_device_properties2 struct
John Zulaufde972ac2017-10-26 12:07:05 -0600202 const auto *features2 = lvl_find_in_chain<VkPhysicalDeviceFeatures2KHR>(pCreateInfo->pNext);
203 if (features2) {
204 // Cannot include VkPhysicalDeviceFeatures2KHR and have non-null pEnabledFeatures
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700205 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600206 kVUID_PVError_InvalidUsage,
John Zulaufde972ac2017-10-26 12:07:05 -0600207 "VkDeviceCreateInfo->pNext includes a VkPhysicalDeviceFeatures2KHR struct when "
208 "pCreateInfo->pEnabledFeatures is non-NULL.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600209 }
210 }
211
212 // Validate pCreateInfo->pQueueCreateInfos
213 if (pCreateInfo->pQueueCreateInfos) {
214 std::unordered_set<uint32_t> set;
215
216 for (uint32_t i = 0; i < pCreateInfo->queueCreateInfoCount; ++i) {
217 const uint32_t requested_queue_family = pCreateInfo->pQueueCreateInfos[i].queueFamilyIndex;
218 if (requested_queue_family == VK_QUEUE_FAMILY_IGNORED) {
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700219 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT,
220 HandleToUint64(physicalDevice), "VUID-VkDeviceQueueCreateInfo-queueFamilyIndex-00381",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600221 "vkCreateDevice: pCreateInfo->pQueueCreateInfos[%" PRIu32
Dave Houltona9df0ce2018-02-07 10:51:23 -0700222 "].queueFamilyIndex is VK_QUEUE_FAMILY_IGNORED, but it is required to provide a valid queue family "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600223 "index value.",
224 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600225 } else if (set.count(requested_queue_family)) {
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700226 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT,
227 HandleToUint64(physicalDevice), "VUID-VkDeviceCreateInfo-queueFamilyIndex-00372",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600228 "vkCreateDevice: pCreateInfo->pQueueCreateInfos[%" PRIu32 "].queueFamilyIndex (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600229 ") is not unique within pCreateInfo->pQueueCreateInfos array.",
230 i, requested_queue_family);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600231 } else {
232 set.insert(requested_queue_family);
233 }
234
235 if (pCreateInfo->pQueueCreateInfos[i].pQueuePriorities != nullptr) {
236 for (uint32_t j = 0; j < pCreateInfo->pQueueCreateInfos[i].queueCount; ++j) {
237 const float queue_priority = pCreateInfo->pQueueCreateInfos[i].pQueuePriorities[j];
238 if (!(queue_priority >= 0.f) || !(queue_priority <= 1.f)) {
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700239 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT,
240 HandleToUint64(physicalDevice), "VUID-VkDeviceQueueCreateInfo-pQueuePriorities-00383",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600241 "vkCreateDevice: pCreateInfo->pQueueCreateInfos[%" PRIu32 "].pQueuePriorities[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600242 "] (=%f) is not between 0 and 1 (inclusive).",
243 i, j, queue_priority);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600244 }
245 }
246 }
247 }
248 }
249
250 return skip;
251}
252
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700253bool StatelessValidation::require_device_extension(bool flag, char const *function_name, char const *extension_name) {
254 if (!flag) {
255 return log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
256 kVUID_PVError_ExtensionNotEnabled,
257 "%s() called even though the %s extension was not enabled for this VkDevice.", function_name,
258 extension_name);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600259 }
260
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700261 return false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600262}
263
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700264bool StatelessValidation::manual_PreCallValidateCreateBuffer(VkDevice device, const VkBufferCreateInfo *pCreateInfo,
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700265 const VkAllocationCallbacks *pAllocator, VkBuffer *pBuffer) {
Petr Krause91f7a12017-12-14 20:57:36 +0100266 bool skip = false;
267
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700268 const LogMiscParams log_misc{VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, VK_NULL_HANDLE, "vkCreateBuffer"};
Petr Krause5c37652018-01-05 04:05:12 +0100269
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600270 if (pCreateInfo != nullptr) {
Dave Houlton413a6782018-05-22 13:01:54 -0600271 skip |= ValidateGreaterThanZero(pCreateInfo->size, "pCreateInfo->size", "VUID-VkBufferCreateInfo-size-00912", log_misc);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600272
273 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
274 if (pCreateInfo->sharingMode == VK_SHARING_MODE_CONCURRENT) {
275 // If sharingMode is VK_SHARING_MODE_CONCURRENT, queueFamilyIndexCount must be greater than 1
276 if (pCreateInfo->queueFamilyIndexCount <= 1) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600277 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600278 "VUID-VkBufferCreateInfo-sharingMode-00914",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600279 "vkCreateBuffer: if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600280 "pCreateInfo->queueFamilyIndexCount must be greater than 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600281 }
282
283 // If sharingMode is VK_SHARING_MODE_CONCURRENT, pQueueFamilyIndices must be a pointer to an array of
284 // queueFamilyIndexCount uint32_t values
285 if (pCreateInfo->pQueueFamilyIndices == nullptr) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600286 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600287 "VUID-VkBufferCreateInfo-sharingMode-00913",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600288 "vkCreateBuffer: if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
289 "pCreateInfo->pQueueFamilyIndices must be a pointer to an array of "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600290 "pCreateInfo->queueFamilyIndexCount uint32_t values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600291 }
292 }
293
294 // If flags contains VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT or VK_BUFFER_CREATE_SPARSE_ALIASED_BIT, it must also contain
295 // VK_BUFFER_CREATE_SPARSE_BINDING_BIT
296 if (((pCreateInfo->flags & (VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT | VK_BUFFER_CREATE_SPARSE_ALIASED_BIT)) != 0) &&
297 ((pCreateInfo->flags & VK_BUFFER_CREATE_SPARSE_BINDING_BIT) != VK_BUFFER_CREATE_SPARSE_BINDING_BIT)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600298 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600299 "VUID-VkBufferCreateInfo-flags-00918",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600300 "vkCreateBuffer: if pCreateInfo->flags contains VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT or "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600301 "VK_BUFFER_CREATE_SPARSE_ALIASED_BIT, it must also contain VK_BUFFER_CREATE_SPARSE_BINDING_BIT.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600302 }
303 }
304
305 return skip;
306}
307
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700308bool StatelessValidation::manual_PreCallValidateCreateImage(VkDevice device, const VkImageCreateInfo *pCreateInfo,
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700309 const VkAllocationCallbacks *pAllocator, VkImage *pImage) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600310 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600311
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700312 const LogMiscParams log_misc{VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, VK_NULL_HANDLE, "vkCreateImage"};
Petr Krause5c37652018-01-05 04:05:12 +0100313
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600314 if (pCreateInfo != nullptr) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600315 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
316 if (pCreateInfo->sharingMode == VK_SHARING_MODE_CONCURRENT) {
317 // If sharingMode is VK_SHARING_MODE_CONCURRENT, queueFamilyIndexCount must be greater than 1
318 if (pCreateInfo->queueFamilyIndexCount <= 1) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600319 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600320 "VUID-VkImageCreateInfo-sharingMode-00942",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600321 "vkCreateImage(): if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600322 "pCreateInfo->queueFamilyIndexCount must be greater than 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600323 }
324
325 // If sharingMode is VK_SHARING_MODE_CONCURRENT, pQueueFamilyIndices must be a pointer to an array of
326 // queueFamilyIndexCount uint32_t values
327 if (pCreateInfo->pQueueFamilyIndices == nullptr) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600328 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600329 "VUID-VkImageCreateInfo-sharingMode-00941",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600330 "vkCreateImage(): if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
331 "pCreateInfo->pQueueFamilyIndices must be a pointer to an array of "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600332 "pCreateInfo->queueFamilyIndexCount uint32_t values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600333 }
334 }
335
Dave Houlton413a6782018-05-22 13:01:54 -0600336 skip |= ValidateGreaterThanZero(pCreateInfo->extent.width, "pCreateInfo->extent.width",
337 "VUID-VkImageCreateInfo-extent-00944", log_misc);
338 skip |= ValidateGreaterThanZero(pCreateInfo->extent.height, "pCreateInfo->extent.height",
339 "VUID-VkImageCreateInfo-extent-00945", log_misc);
340 skip |= ValidateGreaterThanZero(pCreateInfo->extent.depth, "pCreateInfo->extent.depth",
341 "VUID-VkImageCreateInfo-extent-00946", log_misc);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600342
Dave Houlton413a6782018-05-22 13:01:54 -0600343 skip |= ValidateGreaterThanZero(pCreateInfo->mipLevels, "pCreateInfo->mipLevels", "VUID-VkImageCreateInfo-mipLevels-00947",
344 log_misc);
345 skip |= ValidateGreaterThanZero(pCreateInfo->arrayLayers, "pCreateInfo->arrayLayers",
346 "VUID-VkImageCreateInfo-arrayLayers-00948", log_misc);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600347
Dave Houlton130c0212018-01-29 13:39:56 -0700348 // InitialLayout must be PREINITIALIZED or UNDEFINED
Dave Houltone19e20d2018-02-02 16:32:41 -0700349 if ((pCreateInfo->initialLayout != VK_IMAGE_LAYOUT_UNDEFINED) &&
350 (pCreateInfo->initialLayout != VK_IMAGE_LAYOUT_PREINITIALIZED)) {
351 skip |= log_msg(
Dave Houlton413a6782018-05-22 13:01:54 -0600352 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
353 "VUID-VkImageCreateInfo-initialLayout-00993",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600354 "vkCreateImage(): initialLayout is %s, must be VK_IMAGE_LAYOUT_UNDEFINED or VK_IMAGE_LAYOUT_PREINITIALIZED.",
355 string_VkImageLayout(pCreateInfo->initialLayout));
Dave Houlton130c0212018-01-29 13:39:56 -0700356 }
357
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600358 // If imageType is VK_IMAGE_TYPE_1D, both extent.height and extent.depth must be 1
Petr Kraus3ac9e812018-03-13 12:31:08 +0100359 if ((pCreateInfo->imageType == VK_IMAGE_TYPE_1D) &&
360 ((pCreateInfo->extent.height != 1) || (pCreateInfo->extent.depth != 1))) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600361 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600362 "VUID-VkImageCreateInfo-imageType-00956",
Dave Houltona9df0ce2018-02-07 10:51:23 -0700363 "vkCreateImage(): if pCreateInfo->imageType is VK_IMAGE_TYPE_1D, both pCreateInfo->extent.height and "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600364 "pCreateInfo->extent.depth must be 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600365 }
366
367 if (pCreateInfo->imageType == VK_IMAGE_TYPE_2D) {
Petr Kraus3f433212018-03-13 12:31:27 +0100368 if (pCreateInfo->flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) {
369 if (pCreateInfo->extent.width != pCreateInfo->extent.height) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600370 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -0600371 VK_NULL_HANDLE, "VUID-VkImageCreateInfo-imageType-00954",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600372 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT, but "
373 "pCreateInfo->extent.width (=%" PRIu32 ") and pCreateInfo->extent.height (=%" PRIu32
374 ") are not equal.",
375 pCreateInfo->extent.width, pCreateInfo->extent.height);
Petr Kraus3f433212018-03-13 12:31:27 +0100376 }
377
378 if (pCreateInfo->arrayLayers < 6) {
379 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -0600380 VK_NULL_HANDLE, "VUID-VkImageCreateInfo-imageType-00954",
Petr Kraus3f433212018-03-13 12:31:27 +0100381 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT, but "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600382 "pCreateInfo->arrayLayers (=%" PRIu32 ") is not greater than or equal to 6.",
383 pCreateInfo->arrayLayers);
Petr Kraus3f433212018-03-13 12:31:27 +0100384 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600385 }
386
387 if (pCreateInfo->extent.depth != 1) {
Mark Lobodzinski88529492018-04-01 10:38:15 -0600388 skip |=
389 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600390 "VUID-VkImageCreateInfo-imageType-00957",
Mark Lobodzinski88529492018-04-01 10:38:15 -0600391 "vkCreateImage(): if pCreateInfo->imageType is VK_IMAGE_TYPE_2D, pCreateInfo->extent.depth must be 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600392 }
393 }
394
Dave Houlton130c0212018-01-29 13:39:56 -0700395 // 3D image may have only 1 layer
396 if ((pCreateInfo->imageType == VK_IMAGE_TYPE_3D) && (pCreateInfo->arrayLayers != 1)) {
Mark Lobodzinski88529492018-04-01 10:38:15 -0600397 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600398 "VUID-VkImageCreateInfo-imageType-00961",
Mark Lobodzinski88529492018-04-01 10:38:15 -0600399 "vkCreateImage(): if pCreateInfo->imageType is VK_IMAGE_TYPE_3D, pCreateInfo->arrayLayers must be 1.");
Dave Houlton130c0212018-01-29 13:39:56 -0700400 }
401
402 // If multi-sample, validate type, usage, tiling and mip levels.
403 if ((pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT) &&
404 ((pCreateInfo->imageType != VK_IMAGE_TYPE_2D) || (pCreateInfo->flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) ||
Shannon McPhersona886c2a2018-10-12 14:38:20 -0600405 (pCreateInfo->mipLevels != 1) || (pCreateInfo->tiling != VK_IMAGE_TILING_OPTIMAL))) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600406 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Shannon McPhersona886c2a2018-10-12 14:38:20 -0600407 "VUID-VkImageCreateInfo-samples-02257",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600408 "vkCreateImage(): Multi-sample image with incompatible type, usage, tiling, or mips.");
Dave Houlton130c0212018-01-29 13:39:56 -0700409 }
410
411 if (0 != (pCreateInfo->usage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT)) {
412 VkImageUsageFlags legal_flags = (VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT | VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT |
413 VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT);
414 // At least one of the legal attachment bits must be set
415 if (0 == (pCreateInfo->usage & legal_flags)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600416 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600417 "VUID-VkImageCreateInfo-usage-00966",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600418 "vkCreateImage(): Transient attachment image without a compatible attachment flag set.");
Dave Houlton130c0212018-01-29 13:39:56 -0700419 }
420 // No flags other than the legal attachment bits may be set
421 legal_flags |= VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT;
422 if (0 != (pCreateInfo->usage & ~legal_flags)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600423 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600424 "VUID-VkImageCreateInfo-usage-00963",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600425 "vkCreateImage(): Transient attachment image with incompatible usage flags set.");
Dave Houlton130c0212018-01-29 13:39:56 -0700426 }
427 }
428
Jeff Bolzef40fec2018-09-01 22:04:34 -0500429 // mipLevels must be less than or equal to the number of levels in the complete mipmap chain
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600430 uint32_t maxDim = std::max(std::max(pCreateInfo->extent.width, pCreateInfo->extent.height), pCreateInfo->extent.depth);
Jeff Bolzef40fec2018-09-01 22:04:34 -0500431 // Max mip levels is different for corner-sampled images vs normal images.
Dave Houlton142c4cb2018-10-17 15:04:41 -0600432 uint32_t maxMipLevels = (pCreateInfo->flags & VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV) ? (uint32_t)(ceil(log2(maxDim)))
433 : (uint32_t)(floor(log2(maxDim)) + 1);
Jeff Bolzef40fec2018-09-01 22:04:34 -0500434 if (maxDim > 0 && pCreateInfo->mipLevels > maxMipLevels) {
Dave Houlton413a6782018-05-22 13:01:54 -0600435 skip |=
436 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
437 "VUID-VkImageCreateInfo-mipLevels-00958",
438 "vkCreateImage(): pCreateInfo->mipLevels must be less than or equal to "
439 "floor(log2(max(pCreateInfo->extent.width, pCreateInfo->extent.height, pCreateInfo->extent.depth)))+1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600440 }
441
Mark Lobodzinski69259c52018-09-18 15:14:58 -0600442 if ((pCreateInfo->flags & VK_IMAGE_CREATE_2D_ARRAY_COMPATIBLE_BIT) && (pCreateInfo->imageType != VK_IMAGE_TYPE_3D)) {
443 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, VK_NULL_HANDLE,
444 "VUID-VkImageCreateInfo-flags-00950",
445 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_2D_ARRAY_COMPATIBLE_BIT but "
446 "pCreateInfo->imageType is not VK_IMAGE_TYPE_3D.");
447 }
448
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700449 if ((pCreateInfo->flags & VK_IMAGE_CREATE_SPARSE_BINDING_BIT) && (!physical_device_features.sparseBinding)) {
Petr Krausb6f97802018-03-13 12:31:39 +0100450 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, VK_NULL_HANDLE,
Dave Houlton413a6782018-05-22 13:01:54 -0600451 "VUID-VkImageCreateInfo-flags-00969",
Petr Krausb6f97802018-03-13 12:31:39 +0100452 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_SPARSE_BINDING_BIT, but the "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600453 "VkPhysicalDeviceFeatures::sparseBinding feature is disabled.");
Petr Krausb6f97802018-03-13 12:31:39 +0100454 }
455
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600456 // If flags contains VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT or VK_IMAGE_CREATE_SPARSE_ALIASED_BIT, it must also contain
457 // VK_IMAGE_CREATE_SPARSE_BINDING_BIT
458 if (((pCreateInfo->flags & (VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT | VK_IMAGE_CREATE_SPARSE_ALIASED_BIT)) != 0) &&
459 ((pCreateInfo->flags & VK_IMAGE_CREATE_SPARSE_BINDING_BIT) != VK_IMAGE_CREATE_SPARSE_BINDING_BIT)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600460 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600461 "VUID-VkImageCreateInfo-flags-00987",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600462 "vkCreateImage: if pCreateInfo->flags contains VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT or "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600463 "VK_IMAGE_CREATE_SPARSE_ALIASED_BIT, it must also contain VK_IMAGE_CREATE_SPARSE_BINDING_BIT.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600464 }
465
466 // Check for combinations of attributes that are incompatible with having VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT set
467 if ((pCreateInfo->flags & VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT) != 0) {
468 // Linear tiling is unsupported
469 if (VK_IMAGE_TILING_LINEAR == pCreateInfo->tiling) {
Dave Houlton413a6782018-05-22 13:01:54 -0600470 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
471 kVUID_PVError_InvalidUsage,
472 "vkCreateImage: if pCreateInfo->flags contains VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT then image "
473 "tiling of VK_IMAGE_TILING_LINEAR is not supported");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600474 }
475
476 // Sparse 1D image isn't valid
477 if (VK_IMAGE_TYPE_1D == pCreateInfo->imageType) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600478 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600479 "VUID-VkImageCreateInfo-imageType-00970",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600480 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 1D image.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600481 }
482
483 // Sparse 2D image when device doesn't support it
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700484 if ((VK_FALSE == physical_device_features.sparseResidencyImage2D) && (VK_IMAGE_TYPE_2D == pCreateInfo->imageType)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600485 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600486 "VUID-VkImageCreateInfo-imageType-00971",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600487 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 2D image if corresponding "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600488 "feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600489 }
490
491 // Sparse 3D image when device doesn't support it
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700492 if ((VK_FALSE == physical_device_features.sparseResidencyImage3D) && (VK_IMAGE_TYPE_3D == pCreateInfo->imageType)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600493 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600494 "VUID-VkImageCreateInfo-imageType-00972",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600495 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 3D image if corresponding "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600496 "feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600497 }
498
499 // Multi-sample 2D image when device doesn't support it
500 if (VK_IMAGE_TYPE_2D == pCreateInfo->imageType) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700501 if ((VK_FALSE == physical_device_features.sparseResidency2Samples) &&
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600502 (VK_SAMPLE_COUNT_2_BIT == pCreateInfo->samples)) {
Dave Houltona9df0ce2018-02-07 10:51:23 -0700503 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600504 "VUID-VkImageCreateInfo-imageType-00973",
Dave Houltona9df0ce2018-02-07 10:51:23 -0700505 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 2-sample image if "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600506 "corresponding feature is not enabled on the device.");
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700507 } else if ((VK_FALSE == physical_device_features.sparseResidency4Samples) &&
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600508 (VK_SAMPLE_COUNT_4_BIT == pCreateInfo->samples)) {
Dave Houltona9df0ce2018-02-07 10:51:23 -0700509 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600510 "VUID-VkImageCreateInfo-imageType-00974",
Dave Houltona9df0ce2018-02-07 10:51:23 -0700511 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 4-sample image if "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600512 "corresponding feature is not enabled on the device.");
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700513 } else if ((VK_FALSE == physical_device_features.sparseResidency8Samples) &&
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600514 (VK_SAMPLE_COUNT_8_BIT == pCreateInfo->samples)) {
Dave Houltona9df0ce2018-02-07 10:51:23 -0700515 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600516 "VUID-VkImageCreateInfo-imageType-00975",
Dave Houltona9df0ce2018-02-07 10:51:23 -0700517 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 8-sample image if "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600518 "corresponding feature is not enabled on the device.");
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700519 } else if ((VK_FALSE == physical_device_features.sparseResidency16Samples) &&
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600520 (VK_SAMPLE_COUNT_16_BIT == pCreateInfo->samples)) {
Dave Houltona9df0ce2018-02-07 10:51:23 -0700521 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600522 "VUID-VkImageCreateInfo-imageType-00976",
Dave Houltona9df0ce2018-02-07 10:51:23 -0700523 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 16-sample image if "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600524 "corresponding feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600525 }
526 }
527 }
Jeff Bolzef40fec2018-09-01 22:04:34 -0500528
Jeff Bolz9af91c52018-09-01 21:53:57 -0500529 if (pCreateInfo->usage & VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV) {
530 if (pCreateInfo->imageType != VK_IMAGE_TYPE_2D) {
531 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
532 "VUID-VkImageCreateInfo-imageType-02082",
533 "vkCreateImage: if usage includes VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV, "
534 "imageType must be VK_IMAGE_TYPE_2D.");
535 }
536 if (pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT) {
537 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
538 "VUID-VkImageCreateInfo-samples-02083",
539 "vkCreateImage: if usage includes VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV, "
540 "samples must be VK_SAMPLE_COUNT_1_BIT.");
541 }
542 if (pCreateInfo->tiling != VK_IMAGE_TILING_OPTIMAL) {
543 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
544 "VUID-VkImageCreateInfo-tiling-02084",
545 "vkCreateImage: if usage includes VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV, "
546 "tiling must be VK_IMAGE_TILING_OPTIMAL.");
547 }
548 }
Jeff Bolzef40fec2018-09-01 22:04:34 -0500549
550 if (pCreateInfo->flags & VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV) {
Dave Houlton142c4cb2018-10-17 15:04:41 -0600551 if (pCreateInfo->imageType != VK_IMAGE_TYPE_2D && pCreateInfo->imageType != VK_IMAGE_TYPE_3D) {
Jeff Bolzef40fec2018-09-01 22:04:34 -0500552 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
553 "VUID-VkImageCreateInfo-flags-02050",
554 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV, "
555 "imageType must be VK_IMAGE_TYPE_2D or VK_IMAGE_TYPE_3D.");
556 }
557
Dave Houlton142c4cb2018-10-17 15:04:41 -0600558 if ((pCreateInfo->flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) || FormatIsDepthOrStencil(pCreateInfo->format)) {
Jeff Bolzef40fec2018-09-01 22:04:34 -0500559 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
560 "VUID-VkImageCreateInfo-flags-02051",
561 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV, "
562 "it must not also contain VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT and format must "
563 "not be a depth/stencil format.");
564 }
565
Dave Houlton142c4cb2018-10-17 15:04:41 -0600566 if (pCreateInfo->imageType == VK_IMAGE_TYPE_2D && (pCreateInfo->extent.width == 1 || pCreateInfo->extent.height == 1)) {
Jeff Bolzef40fec2018-09-01 22:04:34 -0500567 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
568 "VUID-VkImageCreateInfo-flags-02052",
569 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV and "
570 "imageType is VK_IMAGE_TYPE_2D, extent.width and extent.height must be "
571 "greater than 1.");
Jeff Bolzb8a8dd02018-09-18 02:39:24 -0500572 } else if (pCreateInfo->imageType == VK_IMAGE_TYPE_3D &&
Dave Houlton142c4cb2018-10-17 15:04:41 -0600573 (pCreateInfo->extent.width == 1 || pCreateInfo->extent.height == 1 || pCreateInfo->extent.depth == 1)) {
Jeff Bolzef40fec2018-09-01 22:04:34 -0500574 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
575 "VUID-VkImageCreateInfo-flags-02053",
576 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV and "
577 "imageType is VK_IMAGE_TYPE_3D, extent.width, extent.height, and extent.depth "
578 "must be greater than 1.");
Jeff Bolzef40fec2018-09-01 22:04:34 -0500579 }
580 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600581 }
Jeff Bolzef40fec2018-09-01 22:04:34 -0500582
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600583 return skip;
584}
585
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700586bool StatelessValidation::manual_PreCallValidateCreateImageView(VkDevice device, const VkImageViewCreateInfo *pCreateInfo,
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700587 const VkAllocationCallbacks *pAllocator, VkImageView *pView) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600588 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600589
590 if (pCreateInfo != nullptr) {
Dave Houltonbd2e2622018-04-10 16:41:14 -0600591 // Validate chained VkImageViewUsageCreateInfo struct, if present
592 if (nullptr != pCreateInfo->pNext) {
593 auto chained_ivuci_struct = lvl_find_in_chain<VkImageViewUsageCreateInfoKHR>(pCreateInfo->pNext);
594 if (chained_ivuci_struct) {
595 if (0 == chained_ivuci_struct->usage) {
596 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600597 "VUID-VkImageViewUsageCreateInfo-usage-requiredbitmask",
Dave Houlton0f3795b2018-04-13 15:04:35 -0600598 "vkCreateImageView: Chained VkImageViewUsageCreateInfo usage field must not be 0.");
Dave Houltonbd2e2622018-04-10 16:41:14 -0600599 } else if (chained_ivuci_struct->usage & ~AllVkImageUsageFlagBits) {
600 std::stringstream ss;
601 ss << "vkCreateImageView: Chained VkImageViewUsageCreateInfo usage field (0x" << std::hex
602 << chained_ivuci_struct->usage << ") contains invalid flag bits.";
603 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600604 "VUID-VkImageViewUsageCreateInfo-usage-parameter", "%s", ss.str().c_str());
Dave Houltonbd2e2622018-04-10 16:41:14 -0600605 }
606 }
607 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600608 }
609 return skip;
610}
611
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700612bool StatelessValidation::manual_PreCallValidateViewport(const VkViewport &viewport, const char *fn_name, const char *param_name,
613 VkDebugReportObjectTypeEXT object_type, uint64_t object = 0) {
Petr Krausb3fcdb42018-01-09 22:09:09 +0100614 bool skip = false;
Petr Krausb3fcdb42018-01-09 22:09:09 +0100615
616 // Note: for numerical correctness
617 // - float comparisons should expect NaN (comparison always false).
618 // - VkPhysicalDeviceLimits::maxViewportDimensions is uint32_t, not float -> careful.
619
620 const auto f_lte_u32_exact = [](const float v1_f, const uint32_t v2_u32) {
John Zulaufac0876c2018-02-19 10:09:35 -0700621 if (std::isnan(v1_f)) return false;
Petr Krausb3fcdb42018-01-09 22:09:09 +0100622 if (v1_f <= 0.0f) return true;
623
624 float intpart;
625 const float fract = modff(v1_f, &intpart);
626
627 assert(std::numeric_limits<float>::radix == 2);
628 const float u32_max_plus1 = ldexpf(1.0f, 32); // hopefully exact
629 if (intpart >= u32_max_plus1) return false;
630
631 uint32_t v1_u32 = static_cast<uint32_t>(intpart);
632 if (v1_u32 < v2_u32)
633 return true;
634 else if (v1_u32 == v2_u32 && fract == 0.0f)
635 return true;
636 else
637 return false;
638 };
639
640 const auto f_lte_u32_direct = [](const float v1_f, const uint32_t v2_u32) {
641 const float v2_f = static_cast<float>(v2_u32); // not accurate for > radix^digits; and undefined rounding mode
642 return (v1_f <= v2_f);
643 };
644
645 // width
646 bool width_healthy = true;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700647 const auto max_w = device_limits.maxViewportDimensions[0];
Petr Krausb3fcdb42018-01-09 22:09:09 +0100648
649 if (!(viewport.width > 0.0f)) {
650 width_healthy = false;
Dave Houlton413a6782018-05-22 13:01:54 -0600651 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-width-01770",
Mark Lobodzinski88529492018-04-01 10:38:15 -0600652 "%s: %s.width (=%f) is not greater than 0.0.", fn_name, param_name, viewport.width);
Petr Krausb3fcdb42018-01-09 22:09:09 +0100653 } else if (!(f_lte_u32_exact(viewport.width, max_w) || f_lte_u32_direct(viewport.width, max_w))) {
654 width_healthy = false;
Dave Houlton413a6782018-05-22 13:01:54 -0600655 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-width-01771",
Mark Lobodzinski88529492018-04-01 10:38:15 -0600656 "%s: %s.width (=%f) exceeds VkPhysicalDeviceLimits::maxViewportDimensions[0] (=%" PRIu32 ").", fn_name,
657 param_name, viewport.width, max_w);
Petr Krausb3fcdb42018-01-09 22:09:09 +0100658 } else if (!f_lte_u32_exact(viewport.width, max_w) && f_lte_u32_direct(viewport.width, max_w)) {
Dave Houlton413a6782018-05-22 13:01:54 -0600659 skip |= log_msg(report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, object_type, object, kVUID_PVError_NONE,
Petr Krausb3fcdb42018-01-09 22:09:09 +0100660 "%s: %s.width (=%f) technically exceeds VkPhysicalDeviceLimits::maxViewportDimensions[0] (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600661 "), but it is within the static_cast<float>(maxViewportDimensions[0]) limit.",
662 fn_name, param_name, viewport.width, max_w);
Petr Krausb3fcdb42018-01-09 22:09:09 +0100663 }
664
665 // height
666 bool height_healthy = true;
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700667 const bool negative_height_enabled = api_version >= VK_API_VERSION_1_1 || device_extensions.vk_khr_maintenance1 ||
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700668 device_extensions.vk_amd_negative_viewport_height;
669 const auto max_h = device_limits.maxViewportDimensions[1];
Petr Krausb3fcdb42018-01-09 22:09:09 +0100670
671 if (!negative_height_enabled && !(viewport.height > 0.0f)) {
672 height_healthy = false;
Dave Houlton413a6782018-05-22 13:01:54 -0600673 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-height-01772",
Mark Lobodzinski88529492018-04-01 10:38:15 -0600674 "%s: %s.height (=%f) is not greater 0.0.", fn_name, param_name, viewport.height);
Petr Krausb3fcdb42018-01-09 22:09:09 +0100675 } else if (!(f_lte_u32_exact(fabsf(viewport.height), max_h) || f_lte_u32_direct(fabsf(viewport.height), max_h))) {
676 height_healthy = false;
677
Dave Houlton413a6782018-05-22 13:01:54 -0600678 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-height-01773",
Mark Lobodzinski88529492018-04-01 10:38:15 -0600679 "%s: Absolute value of %s.height (=%f) exceeds VkPhysicalDeviceLimits::maxViewportDimensions[1] (=%" PRIu32
680 ").",
681 fn_name, param_name, viewport.height, max_h);
Petr Krausb3fcdb42018-01-09 22:09:09 +0100682 } else if (!f_lte_u32_exact(fabsf(viewport.height), max_h) && f_lte_u32_direct(fabsf(viewport.height), max_h)) {
683 height_healthy = false;
684
685 skip |= log_msg(
Dave Houlton413a6782018-05-22 13:01:54 -0600686 report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, object_type, object, kVUID_PVError_NONE,
Petr Krausb3fcdb42018-01-09 22:09:09 +0100687 "%s: Absolute value of %s.height (=%f) technically exceeds VkPhysicalDeviceLimits::maxViewportDimensions[1] (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600688 "), but it is within the static_cast<float>(maxViewportDimensions[1]) limit.",
689 fn_name, param_name, viewport.height, max_h);
Petr Krausb3fcdb42018-01-09 22:09:09 +0100690 }
691
692 // x
693 bool x_healthy = true;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700694 if (!(viewport.x >= device_limits.viewportBoundsRange[0])) {
Petr Krausb3fcdb42018-01-09 22:09:09 +0100695 x_healthy = false;
Dave Houlton413a6782018-05-22 13:01:54 -0600696 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-x-01774",
Mark Lobodzinski88529492018-04-01 10:38:15 -0600697 "%s: %s.x (=%f) is less than VkPhysicalDeviceLimits::viewportBoundsRange[0] (=%f).", fn_name, param_name,
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700698 viewport.x, device_limits.viewportBoundsRange[0]);
Petr Krausb3fcdb42018-01-09 22:09:09 +0100699 }
700
701 // x + width
702 if (x_healthy && width_healthy) {
703 const float right_bound = viewport.x + viewport.width;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700704 if (!(right_bound <= device_limits.viewportBoundsRange[1])) {
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700705 skip |= log_msg(
706 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-x-01232",
707 "%s: %s.x + %s.width (=%f + %f = %f) is greater than VkPhysicalDeviceLimits::viewportBoundsRange[1] (=%f).",
708 fn_name, param_name, param_name, viewport.x, viewport.width, right_bound, device_limits.viewportBoundsRange[1]);
Petr Krausb3fcdb42018-01-09 22:09:09 +0100709 }
710 }
711
712 // y
713 bool y_healthy = true;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700714 if (!(viewport.y >= device_limits.viewportBoundsRange[0])) {
Petr Krausb3fcdb42018-01-09 22:09:09 +0100715 y_healthy = false;
Dave Houlton413a6782018-05-22 13:01:54 -0600716 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-y-01775",
Mark Lobodzinski88529492018-04-01 10:38:15 -0600717 "%s: %s.y (=%f) is less than VkPhysicalDeviceLimits::viewportBoundsRange[0] (=%f).", fn_name, param_name,
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700718 viewport.y, device_limits.viewportBoundsRange[0]);
719 } else if (negative_height_enabled && !(viewport.y <= device_limits.viewportBoundsRange[1])) {
Petr Krausb3fcdb42018-01-09 22:09:09 +0100720 y_healthy = false;
Dave Houlton413a6782018-05-22 13:01:54 -0600721 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-y-01776",
Mark Lobodzinski88529492018-04-01 10:38:15 -0600722 "%s: %s.y (=%f) exceeds VkPhysicalDeviceLimits::viewportBoundsRange[1] (=%f).", fn_name, param_name,
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700723 viewport.y, device_limits.viewportBoundsRange[1]);
Petr Krausb3fcdb42018-01-09 22:09:09 +0100724 }
725
726 // y + height
727 if (y_healthy && height_healthy) {
728 const float boundary = viewport.y + viewport.height;
729
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700730 if (!(boundary <= device_limits.viewportBoundsRange[1])) {
Dave Houlton413a6782018-05-22 13:01:54 -0600731 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-y-01233",
Mark Lobodzinski88529492018-04-01 10:38:15 -0600732 "%s: %s.y + %s.height (=%f + %f = %f) exceeds VkPhysicalDeviceLimits::viewportBoundsRange[1] (=%f).",
733 fn_name, param_name, param_name, viewport.y, viewport.height, boundary,
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700734 device_limits.viewportBoundsRange[1]);
735 } else if (negative_height_enabled && !(boundary >= device_limits.viewportBoundsRange[0])) {
Petr Krausb3fcdb42018-01-09 22:09:09 +0100736 skip |= log_msg(
Dave Houlton413a6782018-05-22 13:01:54 -0600737 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-y-01777",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600738 "%s: %s.y + %s.height (=%f + %f = %f) is less than VkPhysicalDeviceLimits::viewportBoundsRange[0] (=%f).", fn_name,
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700739 param_name, param_name, viewport.y, viewport.height, boundary, device_limits.viewportBoundsRange[0]);
Petr Krausb3fcdb42018-01-09 22:09:09 +0100740 }
741 }
742
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700743 if (!device_extensions.vk_ext_depth_range_unrestricted) {
Petr Krausb3fcdb42018-01-09 22:09:09 +0100744 // minDepth
745 if (!(viewport.minDepth >= 0.0) || !(viewport.minDepth <= 1.0)) {
Dave Houlton413a6782018-05-22 13:01:54 -0600746 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-minDepth-01234",
Mark Lobodzinski88529492018-04-01 10:38:15 -0600747
Petr Krausb3fcdb42018-01-09 22:09:09 +0100748 "%s: VK_EXT_depth_range_unrestricted extension is not enabled and %s.minDepth (=%f) is not within the "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600749 "[0.0, 1.0] range.",
750 fn_name, param_name, viewport.minDepth);
Petr Krausb3fcdb42018-01-09 22:09:09 +0100751 }
752
753 // maxDepth
754 if (!(viewport.maxDepth >= 0.0) || !(viewport.maxDepth <= 1.0)) {
Dave Houlton413a6782018-05-22 13:01:54 -0600755 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-maxDepth-01235",
Mark Lobodzinski88529492018-04-01 10:38:15 -0600756
Petr Krausb3fcdb42018-01-09 22:09:09 +0100757 "%s: VK_EXT_depth_range_unrestricted extension is not enabled and %s.maxDepth (=%f) is not within the "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600758 "[0.0, 1.0] range.",
759 fn_name, param_name, viewport.maxDepth);
Petr Krausb3fcdb42018-01-09 22:09:09 +0100760 }
761 }
762
763 return skip;
764}
765
Dave Houlton142c4cb2018-10-17 15:04:41 -0600766struct SampleOrderInfo {
Jeff Bolz9af91c52018-09-01 21:53:57 -0500767 VkShadingRatePaletteEntryNV shadingRate;
768 uint32_t width;
769 uint32_t height;
770};
771
772// All palette entries with more than one pixel per fragment
Dave Houlton142c4cb2018-10-17 15:04:41 -0600773static SampleOrderInfo sampleOrderInfos[] = {
774 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_1X2_PIXELS_NV, 1, 2},
775 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_2X1_PIXELS_NV, 2, 1},
776 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_2X2_PIXELS_NV, 2, 2},
777 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_4X2_PIXELS_NV, 4, 2},
778 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_2X4_PIXELS_NV, 2, 4},
779 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_4X4_PIXELS_NV, 4, 4},
Jeff Bolz9af91c52018-09-01 21:53:57 -0500780};
781
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700782bool StatelessValidation::ValidateCoarseSampleOrderCustomNV(const VkCoarseSampleOrderCustomNV *order) {
Jeff Bolz9af91c52018-09-01 21:53:57 -0500783 bool skip = false;
Jeff Bolz9af91c52018-09-01 21:53:57 -0500784
Jeff Bolz45bf7d62018-09-18 15:39:58 -0500785 SampleOrderInfo *sampleOrderInfo;
Jeff Bolz9af91c52018-09-01 21:53:57 -0500786 uint32_t infoIdx = 0;
Jeff Bolz45bf7d62018-09-18 15:39:58 -0500787 for (sampleOrderInfo = nullptr; infoIdx < ARRAY_SIZE(sampleOrderInfos); ++infoIdx) {
Jeff Bolz9af91c52018-09-01 21:53:57 -0500788 if (sampleOrderInfos[infoIdx].shadingRate == order->shadingRate) {
Jeff Bolzb8a8dd02018-09-18 02:39:24 -0500789 sampleOrderInfo = &sampleOrderInfos[infoIdx];
Jeff Bolz9af91c52018-09-01 21:53:57 -0500790 break;
791 }
792 }
793
Jeff Bolzb8a8dd02018-09-18 02:39:24 -0500794 if (sampleOrderInfo == nullptr) {
Jeff Bolz9af91c52018-09-01 21:53:57 -0500795 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
796 "VUID-VkCoarseSampleOrderCustomNV-shadingRate-02073",
797 "VkCoarseSampleOrderCustomNV shadingRate must be a shading rate "
798 "that generates fragments with more than one pixel.");
799 return skip;
800 }
801
Dave Houlton142c4cb2018-10-17 15:04:41 -0600802 if (order->sampleCount == 0 || (order->sampleCount & (order->sampleCount - 1)) ||
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700803 !(order->sampleCount & device_limits.framebufferNoAttachmentsSampleCounts)) {
Jeff Bolz9af91c52018-09-01 21:53:57 -0500804 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
805 "VUID-VkCoarseSampleOrderCustomNV-sampleCount-02074",
Dave Houlton142c4cb2018-10-17 15:04:41 -0600806 "VkCoarseSampleOrderCustomNV sampleCount (=%" PRIu32
807 ") must "
Jeff Bolz9af91c52018-09-01 21:53:57 -0500808 "correspond to a sample count enumerated in VkSampleCountFlags whose corresponding bit "
809 "is set in framebufferNoAttachmentsSampleCounts.",
810 order->sampleCount);
811 }
812
Jeff Bolz9af91c52018-09-01 21:53:57 -0500813 if (order->sampleLocationCount != order->sampleCount * sampleOrderInfo->width * sampleOrderInfo->height) {
814 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
815 "VUID-VkCoarseSampleOrderCustomNV-sampleLocationCount-02075",
Dave Houlton142c4cb2018-10-17 15:04:41 -0600816 "VkCoarseSampleOrderCustomNV sampleLocationCount (=%" PRIu32
817 ") must "
818 "be equal to the product of sampleCount (=%" PRIu32
819 "), the fragment width for shadingRate "
Jeff Bolz9af91c52018-09-01 21:53:57 -0500820 "(=%" PRIu32 "), and the fragment height for shadingRate (=%" PRIu32 ").",
821 order->sampleLocationCount, order->sampleCount, sampleOrderInfo->width, sampleOrderInfo->height);
822 }
823
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700824 if (order->sampleLocationCount > phys_dev_ext_props.shading_rate_image_props.shadingRateMaxCoarseSamples) {
Dave Houlton142c4cb2018-10-17 15:04:41 -0600825 skip |= log_msg(
826 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
827 "VUID-VkCoarseSampleOrderCustomNV-sampleLocationCount-02076",
828 "VkCoarseSampleOrderCustomNV sampleLocationCount (=%" PRIu32
829 ") must "
830 "be less than or equal to VkPhysicalDeviceShadingRateImagePropertiesNV shadingRateMaxCoarseSamples (=%" PRIu32 ").",
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700831 order->sampleLocationCount, phys_dev_ext_props.shading_rate_image_props.shadingRateMaxCoarseSamples);
Jeff Bolz9af91c52018-09-01 21:53:57 -0500832 }
Jeff Bolz9af91c52018-09-01 21:53:57 -0500833
834 // Accumulate a bitmask tracking which (x,y,sample) tuples are seen. Expect
Jeff Bolzb8a8dd02018-09-18 02:39:24 -0500835 // the first width*height*sampleCount bits to all be set. Note: There is no
836 // guarantee that 64 bits is enough, but practically it's unlikely for an
837 // implementation to support more than 32 bits for samplemask.
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700838 assert(phys_dev_ext_props.shading_rate_image_props.shadingRateMaxCoarseSamples <= 64);
Jeff Bolz9af91c52018-09-01 21:53:57 -0500839 uint64_t sampleLocationsMask = 0;
840 for (uint32_t i = 0; i < order->sampleLocationCount; ++i) {
841 const VkCoarseSampleLocationNV *sampleLoc = &order->pSampleLocations[i];
842 if (sampleLoc->pixelX >= sampleOrderInfo->width) {
843 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
844 "VUID-VkCoarseSampleLocationNV-pixelX-02078",
845 "pixelX must be less than the width (in pixels) of the fragment.");
846 }
847 if (sampleLoc->pixelY >= sampleOrderInfo->height) {
848 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
849 "VUID-VkCoarseSampleLocationNV-pixelY-02079",
850 "pixelY must be less than the height (in pixels) of the fragment.");
851 }
852 if (sampleLoc->sample >= order->sampleCount) {
853 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
854 "VUID-VkCoarseSampleLocationNV-sample-02080",
855 "sample must be less than the number of coverage samples in each pixel belonging to the fragment.");
856 }
857 uint32_t idx = sampleLoc->sample + order->sampleCount * (sampleLoc->pixelX + sampleOrderInfo->width * sampleLoc->pixelY);
858 sampleLocationsMask |= 1ULL << idx;
859 }
860
861 uint64_t expectedMask = (order->sampleLocationCount == 64) ? ~0ULL : ((1ULL << order->sampleLocationCount) - 1);
862 if (sampleLocationsMask != expectedMask) {
Dave Houlton142c4cb2018-10-17 15:04:41 -0600863 skip |= log_msg(
864 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
865 "VUID-VkCoarseSampleOrderCustomNV-pSampleLocations-02077",
866 "The array pSampleLocations must contain exactly one entry for "
867 "every combination of valid values for pixelX, pixelY, and sample in the structure VkCoarseSampleOrderCustomNV.");
Jeff Bolz9af91c52018-09-01 21:53:57 -0500868 }
869
870 return skip;
871}
872
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700873bool StatelessValidation::manual_PreCallValidateCreateGraphicsPipelines(VkDevice device, VkPipelineCache pipelineCache,
874 uint32_t createInfoCount,
875 const VkGraphicsPipelineCreateInfo *pCreateInfos,
876 const VkAllocationCallbacks *pAllocator,
877 VkPipeline *pPipelines) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600878 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600879
880 if (pCreateInfos != nullptr) {
881 for (uint32_t i = 0; i < createInfoCount; ++i) {
Petr Kraus299ba622017-11-24 03:09:03 +0100882 bool has_dynamic_viewport = false;
883 bool has_dynamic_scissor = false;
884 bool has_dynamic_line_width = false;
Jeremy Kniager71fd5f02017-11-15 13:27:03 -0700885 bool has_dynamic_viewport_w_scaling_nv = false;
886 bool has_dynamic_discard_rectangle_ext = false;
887 bool has_dynamic_sample_locations_ext = false;
Jeff Bolz3e71f782018-08-29 23:15:45 -0500888 bool has_dynamic_exclusive_scissor_nv = false;
Jeff Bolz9af91c52018-09-01 21:53:57 -0500889 bool has_dynamic_shading_rate_palette_nv = false;
Petr Kraus299ba622017-11-24 03:09:03 +0100890 if (pCreateInfos[i].pDynamicState != nullptr) {
891 const auto &dynamic_state_info = *pCreateInfos[i].pDynamicState;
892 for (uint32_t state_index = 0; state_index < dynamic_state_info.dynamicStateCount; ++state_index) {
893 const auto &dynamic_state = dynamic_state_info.pDynamicStates[state_index];
894 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT) has_dynamic_viewport = true;
895 if (dynamic_state == VK_DYNAMIC_STATE_SCISSOR) has_dynamic_scissor = true;
896 if (dynamic_state == VK_DYNAMIC_STATE_LINE_WIDTH) has_dynamic_line_width = true;
Jeremy Kniager71fd5f02017-11-15 13:27:03 -0700897 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT_W_SCALING_NV) has_dynamic_viewport_w_scaling_nv = true;
898 if (dynamic_state == VK_DYNAMIC_STATE_DISCARD_RECTANGLE_EXT) has_dynamic_discard_rectangle_ext = true;
899 if (dynamic_state == VK_DYNAMIC_STATE_SAMPLE_LOCATIONS_EXT) has_dynamic_sample_locations_ext = true;
Jeff Bolz3e71f782018-08-29 23:15:45 -0500900 if (dynamic_state == VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV) has_dynamic_exclusive_scissor_nv = true;
Dave Houlton142c4cb2018-10-17 15:04:41 -0600901 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT_SHADING_RATE_PALETTE_NV)
902 has_dynamic_shading_rate_palette_nv = true;
Petr Kraus299ba622017-11-24 03:09:03 +0100903 }
904 }
905
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600906 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
907 if (pCreateInfos[i].pVertexInputState != nullptr) {
908 auto const &vertex_input_state = pCreateInfos[i].pVertexInputState;
Peter Kohautc7d9d392018-07-15 00:34:07 +0200909
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700910 if (vertex_input_state->vertexBindingDescriptionCount > device_limits.maxVertexInputBindings) {
Peter Kohautc7d9d392018-07-15 00:34:07 +0200911 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
912 "VUID-VkPipelineVertexInputStateCreateInfo-vertexBindingDescriptionCount-00613",
913 "vkCreateGraphicsPipelines: pararameter "
914 "pCreateInfo[%d].pVertexInputState->vertexBindingDescriptionCount (%u) is "
915 "greater than VkPhysicalDeviceLimits::maxVertexInputBindings (%u).",
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700916 i, vertex_input_state->vertexBindingDescriptionCount, device_limits.maxVertexInputBindings);
Peter Kohautc7d9d392018-07-15 00:34:07 +0200917 }
918
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700919 if (vertex_input_state->vertexAttributeDescriptionCount > device_limits.maxVertexInputAttributes) {
Peter Kohautc7d9d392018-07-15 00:34:07 +0200920 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
921 "VUID-VkPipelineVertexInputStateCreateInfo-vertexAttributeDescriptionCount-00614",
922 "vkCreateGraphicsPipelines: pararameter "
Peter Kohaut9e92c5c2018-07-17 10:32:17 +0200923 "pCreateInfo[%d].pVertexInputState->vertexAttributeDescriptionCount (%u) is "
Peter Kohautc7d9d392018-07-15 00:34:07 +0200924 "greater than VkPhysicalDeviceLimits::maxVertexInputAttributes (%u).",
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700925 i, vertex_input_state->vertexBindingDescriptionCount, device_limits.maxVertexInputAttributes);
Peter Kohautc7d9d392018-07-15 00:34:07 +0200926 }
927
928 std::unordered_set<uint32_t> vertex_bindings(vertex_input_state->vertexBindingDescriptionCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600929 for (uint32_t d = 0; d < vertex_input_state->vertexBindingDescriptionCount; ++d) {
930 auto const &vertex_bind_desc = vertex_input_state->pVertexBindingDescriptions[d];
Peter Kohautc7d9d392018-07-15 00:34:07 +0200931 auto const &binding_it = vertex_bindings.find(vertex_bind_desc.binding);
932 if (binding_it != vertex_bindings.cend()) {
933 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
934 "VUID-VkPipelineVertexInputStateCreateInfo-pVertexBindingDescriptions-00616",
935 "vkCreateGraphicsPipelines: parameter "
936 "pCreateInfo[%d].pVertexInputState->pVertexBindingDescription[%d].binding "
937 "(%" PRIu32 ") is not distinct.",
938 i, d, vertex_bind_desc.binding);
939 }
940 vertex_bindings.insert(vertex_bind_desc.binding);
941
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700942 if (vertex_bind_desc.binding >= device_limits.maxVertexInputBindings) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600943 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600944 "VUID-VkVertexInputBindingDescription-binding-00618",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600945 "vkCreateGraphicsPipelines: parameter "
946 "pCreateInfos[%u].pVertexInputState->pVertexBindingDescriptions[%u].binding (%u) is "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600947 "greater than or equal to VkPhysicalDeviceLimits::maxVertexInputBindings (%u).",
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700948 i, d, vertex_bind_desc.binding, device_limits.maxVertexInputBindings);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600949 }
950
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700951 if (vertex_bind_desc.stride > device_limits.maxVertexInputBindingStride) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600952 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600953 "VUID-VkVertexInputBindingDescription-stride-00619",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600954 "vkCreateGraphicsPipelines: parameter "
955 "pCreateInfos[%u].pVertexInputState->pVertexBindingDescriptions[%u].stride (%u) is greater "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600956 "than VkPhysicalDeviceLimits::maxVertexInputBindingStride (%u).",
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700957 i, d, vertex_bind_desc.stride, device_limits.maxVertexInputBindingStride);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600958 }
959 }
960
Peter Kohautc7d9d392018-07-15 00:34:07 +0200961 std::unordered_set<uint32_t> attribute_locations(vertex_input_state->vertexAttributeDescriptionCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600962 for (uint32_t d = 0; d < vertex_input_state->vertexAttributeDescriptionCount; ++d) {
963 auto const &vertex_attrib_desc = vertex_input_state->pVertexAttributeDescriptions[d];
Peter Kohautc7d9d392018-07-15 00:34:07 +0200964 auto const &location_it = attribute_locations.find(vertex_attrib_desc.location);
965 if (location_it != attribute_locations.cend()) {
966 skip |= log_msg(
967 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
968 "VUID-VkPipelineVertexInputStateCreateInfo-pVertexAttributeDescriptions-00617",
969 "vkCreateGraphicsPipelines: parameter "
970 "pCreateInfo[%d].pVertexInputState->vertexAttributeDescriptions[%d].location (%u) is not distinct.",
971 i, d, vertex_attrib_desc.location);
972 }
973 attribute_locations.insert(vertex_attrib_desc.location);
974
975 auto const &binding_it = vertex_bindings.find(vertex_attrib_desc.binding);
976 if (binding_it == vertex_bindings.cend()) {
977 skip |= log_msg(
978 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
979 "VUID-VkPipelineVertexInputStateCreateInfo-binding-00615",
980 "vkCreateGraphicsPipelines: parameter "
981 " pCreateInfo[%d].pVertexInputState->vertexAttributeDescriptions[%d].binding (%u) does not exist "
982 "in any pCreateInfo[%d].pVertexInputState->pVertexBindingDescription.",
983 i, d, vertex_attrib_desc.binding, i);
984 }
985
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700986 if (vertex_attrib_desc.location >= device_limits.maxVertexInputAttributes) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600987 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600988 "VUID-VkVertexInputAttributeDescription-location-00620",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600989 "vkCreateGraphicsPipelines: parameter "
990 "pCreateInfos[%u].pVertexInputState->pVertexAttributeDescriptions[%u].location (%u) is "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600991 "greater than or equal to VkPhysicalDeviceLimits::maxVertexInputAttributes (%u).",
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700992 i, d, vertex_attrib_desc.location, device_limits.maxVertexInputAttributes);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600993 }
994
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700995 if (vertex_attrib_desc.binding >= device_limits.maxVertexInputBindings) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600996 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600997 "VUID-VkVertexInputAttributeDescription-binding-00621",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600998 "vkCreateGraphicsPipelines: parameter "
999 "pCreateInfos[%u].pVertexInputState->pVertexAttributeDescriptions[%u].binding (%u) is "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001000 "greater than or equal to VkPhysicalDeviceLimits::maxVertexInputBindings (%u).",
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001001 i, d, vertex_attrib_desc.binding, device_limits.maxVertexInputBindings);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001002 }
1003
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001004 if (vertex_attrib_desc.offset > device_limits.maxVertexInputAttributeOffset) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06001005 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001006 "VUID-VkVertexInputAttributeDescription-offset-00622",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001007 "vkCreateGraphicsPipelines: parameter "
1008 "pCreateInfos[%u].pVertexInputState->pVertexAttributeDescriptions[%u].offset (%u) is "
1009 "greater than VkPhysicalDeviceLimits::maxVertexInputAttributeOffset (%u).",
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001010 i, d, vertex_attrib_desc.offset, device_limits.maxVertexInputAttributeOffset);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001011 }
1012 }
1013 }
1014
1015 if (pCreateInfos[i].pStages != nullptr) {
1016 bool has_control = false;
1017 bool has_eval = false;
1018
1019 for (uint32_t stage_index = 0; stage_index < pCreateInfos[i].stageCount; ++stage_index) {
1020 if (pCreateInfos[i].pStages[stage_index].stage == VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) {
1021 has_control = true;
1022 } else if (pCreateInfos[i].pStages[stage_index].stage == VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT) {
1023 has_eval = true;
1024 }
1025 }
1026
1027 // pTessellationState is ignored without both tessellation control and tessellation evaluation shaders stages
1028 if (has_control && has_eval) {
1029 if (pCreateInfos[i].pTessellationState == nullptr) {
1030 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001031 "VUID-VkGraphicsPipelineCreateInfo-pStages-00731",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001032 "vkCreateGraphicsPipelines: if pCreateInfos[%d].pStages includes a tessellation control "
1033 "shader stage and a tessellation evaluation shader stage, "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001034 "pCreateInfos[%d].pTessellationState must not be NULL.",
1035 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001036 } else {
1037 skip |= validate_struct_pnext(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001038 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001039 ParameterName("pCreateInfos[%i].pTessellationState->pNext", ParameterName::IndexVector{i}), NULL,
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001040 pCreateInfos[i].pTessellationState->pNext, 0, NULL, GeneratedVulkanHeaderVersion,
Dave Houlton413a6782018-05-22 13:01:54 -06001041 "VUID-VkGraphicsPipelineCreateInfo-pNext-pNext");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001042
1043 skip |= validate_reserved_flags(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001044 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001045 ParameterName("pCreateInfos[%i].pTessellationState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06001046 pCreateInfos[i].pTessellationState->flags,
1047 "VUID-VkPipelineTessellationStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001048
1049 if (pCreateInfos[i].pTessellationState->sType !=
1050 VK_STRUCTURE_TYPE_PIPELINE_TESSELLATION_STATE_CREATE_INFO) {
1051 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001052 "VUID-VkPipelineTessellationStateCreateInfo-sType-sType",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001053 "vkCreateGraphicsPipelines: parameter pCreateInfos[%d].pTessellationState->sType must "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001054 "be VK_STRUCTURE_TYPE_PIPELINE_TESSELLATION_STATE_CREATE_INFO.",
1055 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001056 }
1057
1058 if (pCreateInfos[i].pTessellationState->patchControlPoints == 0 ||
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07001059 pCreateInfos[i].pTessellationState->patchControlPoints > device_limits.maxTessellationPatchSize) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001060 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001061 "VUID-VkPipelineTessellationStateCreateInfo-patchControlPoints-01214",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001062 "vkCreateGraphicsPipelines: invalid parameter "
1063 "pCreateInfos[%d].pTessellationState->patchControlPoints value %u. patchControlPoints "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001064 "should be >0 and <=%u.",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001065 i, pCreateInfos[i].pTessellationState->patchControlPoints,
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001066 device_limits.maxTessellationPatchSize);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001067 }
1068 }
1069 }
1070 }
1071
1072 // pViewportState, pMultisampleState, pDepthStencilState, and pColorBlendState ignored when rasterization is disabled
1073 if ((pCreateInfos[i].pRasterizationState != nullptr) &&
1074 (pCreateInfos[i].pRasterizationState->rasterizerDiscardEnable == VK_FALSE)) {
1075 if (pCreateInfos[i].pViewportState == nullptr) {
Petr Krausa6103552017-11-16 21:21:58 +01001076 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001077 VK_NULL_HANDLE, "VUID-VkGraphicsPipelineCreateInfo-rasterizerDiscardEnable-00750",
Petr Krausa6103552017-11-16 21:21:58 +01001078 "vkCreateGraphicsPipelines: Rasterization is enabled (pCreateInfos[%" PRIu32
1079 "].pRasterizationState->rasterizerDiscardEnable is VK_FALSE), but pCreateInfos[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001080 "].pViewportState (=NULL) is not a valid pointer.",
1081 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001082 } else {
Petr Krausa6103552017-11-16 21:21:58 +01001083 const auto &viewport_state = *pCreateInfos[i].pViewportState;
1084
1085 if (viewport_state.sType != VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_STATE_CREATE_INFO) {
1086 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001087 VK_NULL_HANDLE, "VUID-VkPipelineViewportStateCreateInfo-sType-sType",
Petr Krausa6103552017-11-16 21:21:58 +01001088 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001089 "].pViewportState->sType is not VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_STATE_CREATE_INFO.",
1090 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001091 }
1092
Petr Krausa6103552017-11-16 21:21:58 +01001093 const VkStructureType allowed_structs_VkPipelineViewportStateCreateInfo[] = {
1094 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_SWIZZLE_STATE_CREATE_INFO_NV,
Jeff Bolz3e71f782018-08-29 23:15:45 -05001095 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_W_SCALING_STATE_CREATE_INFO_NV,
1096 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_EXCLUSIVE_SCISSOR_STATE_CREATE_INFO_NV,
Jeff Bolz9af91c52018-09-01 21:53:57 -05001097 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_SHADING_RATE_IMAGE_STATE_CREATE_INFO_NV,
1098 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_COARSE_SAMPLE_ORDER_STATE_CREATE_INFO_NV,
Jeff Bolz3e71f782018-08-29 23:15:45 -05001099 };
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001100 skip |= validate_struct_pnext(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001101 "vkCreateGraphicsPipelines",
Petr Krausa6103552017-11-16 21:21:58 +01001102 ParameterName("pCreateInfos[%i].pViewportState->pNext", ParameterName::IndexVector{i}),
Jeff Bolz9af91c52018-09-01 21:53:57 -05001103 "VkPipelineViewportSwizzleStateCreateInfoNV, VkPipelineViewportWScalingStateCreateInfoNV, "
Jeff Bolzb8a8dd02018-09-18 02:39:24 -05001104 "VkPipelineViewportExclusiveScissorStateCreateInfoNV, VkPipelineViewportShadingRateImageStateCreateInfoNV, "
1105 "VkPipelineViewportCoarseSampleOrderStateCreateInfoNV",
Petr Krausa6103552017-11-16 21:21:58 +01001106 viewport_state.pNext, ARRAY_SIZE(allowed_structs_VkPipelineViewportStateCreateInfo),
Dave Houlton413a6782018-05-22 13:01:54 -06001107 allowed_structs_VkPipelineViewportStateCreateInfo, 65,
1108 "VUID-VkPipelineViewportStateCreateInfo-pNext-pNext");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001109
1110 skip |= validate_reserved_flags(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001111 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001112 ParameterName("pCreateInfos[%i].pViewportState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06001113 viewport_state.flags, "VUID-VkPipelineViewportStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001114
Dave Houlton142c4cb2018-10-17 15:04:41 -06001115 auto exclusive_scissor_struct = lvl_find_in_chain<VkPipelineViewportExclusiveScissorStateCreateInfoNV>(
1116 pCreateInfos[i].pViewportState->pNext);
1117 auto shading_rate_image_struct = lvl_find_in_chain<VkPipelineViewportShadingRateImageStateCreateInfoNV>(
1118 pCreateInfos[i].pViewportState->pNext);
1119 auto coarse_sample_order_struct = lvl_find_in_chain<VkPipelineViewportCoarseSampleOrderStateCreateInfoNV>(
1120 pCreateInfos[i].pViewportState->pNext);
Chris Mayer328d8212018-12-11 14:16:18 +01001121 const auto vp_swizzle_struct =
1122 lvl_find_in_chain<VkPipelineViewportSwizzleStateCreateInfoNV>(pCreateInfos[i].pViewportState->pNext);
Jeff Bolz3e71f782018-08-29 23:15:45 -05001123
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001124 if (!physical_device_features.multiViewport) {
Petr Krausa6103552017-11-16 21:21:58 +01001125 if (viewport_state.viewportCount != 1) {
1126 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001127 VK_NULL_HANDLE, "VUID-VkPipelineViewportStateCreateInfo-viewportCount-01216",
Petr Krausa6103552017-11-16 21:21:58 +01001128 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
1129 "disabled, but pCreateInfos[%" PRIu32 "].pViewportState->viewportCount (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001130 ") is not 1.",
1131 i, viewport_state.viewportCount);
Petr Krausa6103552017-11-16 21:21:58 +01001132 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001133
Petr Krausa6103552017-11-16 21:21:58 +01001134 if (viewport_state.scissorCount != 1) {
1135 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001136 VK_NULL_HANDLE, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-01217",
Petr Krausa6103552017-11-16 21:21:58 +01001137 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
1138 "disabled, but pCreateInfos[%" PRIu32 "].pViewportState->scissorCount (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001139 ") is not 1.",
1140 i, viewport_state.scissorCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001141 }
Jeff Bolz3e71f782018-08-29 23:15:45 -05001142
Dave Houlton142c4cb2018-10-17 15:04:41 -06001143 if (exclusive_scissor_struct && (exclusive_scissor_struct->exclusiveScissorCount != 0 &&
1144 exclusive_scissor_struct->exclusiveScissorCount != 1)) {
1145 skip |=
1146 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
1147 VK_NULL_HANDLE,
1148 "VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-exclusiveScissorCount-02027",
1149 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
1150 "disabled, but pCreateInfos[%" PRIu32
1151 "] VkPipelineViewportExclusiveScissorStateCreateInfoNV::exclusiveScissorCount (=%" PRIu32
1152 ") is not 1.",
1153 i, exclusive_scissor_struct->exclusiveScissorCount);
Jeff Bolz3e71f782018-08-29 23:15:45 -05001154 }
1155
Jeff Bolz9af91c52018-09-01 21:53:57 -05001156 if (shading_rate_image_struct &&
1157 (shading_rate_image_struct->viewportCount != 0 && shading_rate_image_struct->viewportCount != 1)) {
1158 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton142c4cb2018-10-17 15:04:41 -06001159 VK_NULL_HANDLE,
1160 "VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-viewportCount-02054",
Jeff Bolz9af91c52018-09-01 21:53:57 -05001161 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
Dave Houlton142c4cb2018-10-17 15:04:41 -06001162 "disabled, but pCreateInfos[%" PRIu32
1163 "] VkPipelineViewportShadingRateImageStateCreateInfoNV::viewportCount (=%" PRIu32
Jeff Bolzb8a8dd02018-09-18 02:39:24 -05001164 ") is neither 0 nor 1.",
Jeff Bolz9af91c52018-09-01 21:53:57 -05001165 i, shading_rate_image_struct->viewportCount);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001166 }
1167
Petr Krausa6103552017-11-16 21:21:58 +01001168 } else { // multiViewport enabled
1169 if (viewport_state.viewportCount == 0) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001170 skip |= log_msg(
1171 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001172 VK_NULL_HANDLE, "VUID-VkPipelineViewportStateCreateInfo-viewportCount-arraylength",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001173 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "].pViewportState->viewportCount is 0.", i);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001174 } else if (viewport_state.viewportCount > device_limits.maxViewports) {
Petr Krausa6103552017-11-16 21:21:58 +01001175 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001176 VK_NULL_HANDLE, "VUID-VkPipelineViewportStateCreateInfo-viewportCount-01218",
Petr Krausa6103552017-11-16 21:21:58 +01001177 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1178 "].pViewportState->viewportCount (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001179 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001180 i, viewport_state.viewportCount, device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001181 }
Petr Krausa6103552017-11-16 21:21:58 +01001182
1183 if (viewport_state.scissorCount == 0) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001184 skip |= log_msg(
1185 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001186 VK_NULL_HANDLE, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-arraylength",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001187 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "].pViewportState->scissorCount is 0.", i);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001188 } else if (viewport_state.scissorCount > device_limits.maxViewports) {
Petr Krausa6103552017-11-16 21:21:58 +01001189 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001190 VK_NULL_HANDLE, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-01219",
Petr Krausa6103552017-11-16 21:21:58 +01001191 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1192 "].pViewportState->scissorCount (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001193 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001194 i, viewport_state.scissorCount, device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001195 }
1196 }
1197
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07001198 if (exclusive_scissor_struct && exclusive_scissor_struct->exclusiveScissorCount > device_limits.maxViewports) {
1199 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
1200 VK_NULL_HANDLE,
1201 "VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-exclusiveScissorCount-02028",
1202 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "] exclusiveScissorCount (=%" PRIu32
1203 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
1204 i, exclusive_scissor_struct->exclusiveScissorCount, device_limits.maxViewports);
Jeff Bolz3e71f782018-08-29 23:15:45 -05001205 }
1206
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07001207 if (shading_rate_image_struct && shading_rate_image_struct->viewportCount > device_limits.maxViewports) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06001208 skip |=
1209 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
1210 VK_NULL_HANDLE, "VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-viewportCount-02055",
1211 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1212 "] VkPipelineViewportShadingRateImageStateCreateInfoNV viewportCount (=%" PRIu32
1213 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001214 i, shading_rate_image_struct->viewportCount, device_limits.maxViewports);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001215 }
1216
Petr Krausa6103552017-11-16 21:21:58 +01001217 if (viewport_state.scissorCount != viewport_state.viewportCount) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001218 skip |=
1219 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001220 VK_NULL_HANDLE, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-01220",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001221 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "].pViewportState->scissorCount (=%" PRIu32
1222 ") is not identical to pCreateInfos[%" PRIu32 "].pViewportState->viewportCount (=%" PRIu32 ").",
1223 i, viewport_state.scissorCount, i, viewport_state.viewportCount);
Petr Krausa6103552017-11-16 21:21:58 +01001224 }
1225
Dave Houlton142c4cb2018-10-17 15:04:41 -06001226 if (exclusive_scissor_struct && exclusive_scissor_struct->exclusiveScissorCount != 0 &&
Jeff Bolz3e71f782018-08-29 23:15:45 -05001227 exclusive_scissor_struct->exclusiveScissorCount != viewport_state.viewportCount) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06001228 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
1229 VK_NULL_HANDLE,
1230 "VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-exclusiveScissorCount-02029",
1231 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "] exclusiveScissorCount (=%" PRIu32
1232 ") must be zero or identical to pCreateInfos[%" PRIu32
1233 "].pViewportState->viewportCount (=%" PRIu32 ").",
1234 i, exclusive_scissor_struct->exclusiveScissorCount, i, viewport_state.viewportCount);
Jeff Bolz3e71f782018-08-29 23:15:45 -05001235 }
1236
Dave Houlton142c4cb2018-10-17 15:04:41 -06001237 if (shading_rate_image_struct && shading_rate_image_struct->shadingRateImageEnable &&
Jeff Bolz9af91c52018-09-01 21:53:57 -05001238 shading_rate_image_struct->viewportCount != viewport_state.viewportCount) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06001239 skip |= log_msg(
1240 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, VK_NULL_HANDLE,
1241 "VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-shadingRateImageEnable-02056",
1242 "vkCreateGraphicsPipelines: If shadingRateImageEnable is enabled, pCreateInfos[%" PRIu32
1243 "] "
1244 "VkPipelineViewportShadingRateImageStateCreateInfoNV viewportCount (=%" PRIu32
1245 ") must identical to pCreateInfos[%" PRIu32 "].pViewportState->viewportCount (=%" PRIu32 ").",
1246 i, shading_rate_image_struct->viewportCount, i, viewport_state.viewportCount);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001247 }
1248
Petr Krausa6103552017-11-16 21:21:58 +01001249 if (!has_dynamic_viewport && viewport_state.viewportCount > 0 && viewport_state.pViewports == nullptr) {
1250 skip |= log_msg(
1251 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, VK_NULL_HANDLE,
Dave Houlton413a6782018-05-22 13:01:54 -06001252 "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-00747",
Petr Krausa6103552017-11-16 21:21:58 +01001253 "vkCreateGraphicsPipelines: The viewport state is static (pCreateInfos[%" PRIu32
1254 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_VIEWPORT), but pCreateInfos[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001255 "].pViewportState->pViewports (=NULL) is an invalid pointer.",
1256 i, i);
Petr Krausa6103552017-11-16 21:21:58 +01001257 }
1258
1259 if (!has_dynamic_scissor && viewport_state.scissorCount > 0 && viewport_state.pScissors == nullptr) {
1260 skip |= log_msg(
1261 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, VK_NULL_HANDLE,
Dave Houlton413a6782018-05-22 13:01:54 -06001262 "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-00748",
Petr Krausa6103552017-11-16 21:21:58 +01001263 "vkCreateGraphicsPipelines: The scissor state is static (pCreateInfos[%" PRIu32
1264 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_SCISSOR), but pCreateInfos[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001265 "].pViewportState->pScissors (=NULL) is an invalid pointer.",
1266 i, i);
Petr Krausa6103552017-11-16 21:21:58 +01001267 }
1268
Jeff Bolz3e71f782018-08-29 23:15:45 -05001269 if (!has_dynamic_exclusive_scissor_nv && exclusive_scissor_struct &&
Dave Houlton142c4cb2018-10-17 15:04:41 -06001270 exclusive_scissor_struct->exclusiveScissorCount > 0 &&
1271 exclusive_scissor_struct->pExclusiveScissors == nullptr) {
1272 skip |=
1273 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
1274 VK_NULL_HANDLE, "VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-pDynamicStates-02030",
1275 "vkCreateGraphicsPipelines: The exclusive scissor state is static (pCreateInfos[%" PRIu32
1276 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV), but "
1277 "pCreateInfos[%" PRIu32 "] pExclusiveScissors (=NULL) is an invalid pointer.",
1278 i, i);
Jeff Bolz3e71f782018-08-29 23:15:45 -05001279 }
1280
Jeff Bolz9af91c52018-09-01 21:53:57 -05001281 if (!has_dynamic_shading_rate_palette_nv && shading_rate_image_struct &&
Dave Houlton142c4cb2018-10-17 15:04:41 -06001282 shading_rate_image_struct->viewportCount > 0 &&
1283 shading_rate_image_struct->pShadingRatePalettes == nullptr) {
Jeff Bolz9af91c52018-09-01 21:53:57 -05001284 skip |= log_msg(
1285 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, VK_NULL_HANDLE,
1286 "VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-pDynamicStates-02057",
1287 "vkCreateGraphicsPipelines: The shading rate palette state is static (pCreateInfos[%" PRIu32
Dave Houlton142c4cb2018-10-17 15:04:41 -06001288 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_VIEWPORT_SHADING_RATE_PALETTE_NV), "
1289 "but pCreateInfos[%" PRIu32 "] pShadingRatePalettes (=NULL) is an invalid pointer.",
Jeff Bolz9af91c52018-09-01 21:53:57 -05001290 i, i);
1291 }
1292
Chris Mayer328d8212018-12-11 14:16:18 +01001293 if (vp_swizzle_struct) {
1294 if (vp_swizzle_struct->viewportCount != viewport_state.viewportCount) {
1295 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
1296 VK_NULL_HANDLE, "VUID-VkPipelineViewportSwizzleStateCreateInfoNV-viewportCount-01215",
1297 "vkCreateGraphicsPipelines: The viewport swizzle state vieport count of %" PRIu32
1298 " does "
1299 "not match the viewport count of %" PRIu32 " in VkPipelineViewportStateCreateInfo.",
1300 vp_swizzle_struct->viewportCount, viewport_state.viewportCount);
1301 }
1302 }
1303
Petr Krausb3fcdb42018-01-09 22:09:09 +01001304 // validate the VkViewports
1305 if (!has_dynamic_viewport && viewport_state.pViewports) {
1306 for (uint32_t viewport_i = 0; viewport_i < viewport_state.viewportCount; ++viewport_i) {
1307 const auto &viewport = viewport_state.pViewports[viewport_i]; // will crash on invalid ptr
1308 const char fn_name[] = "vkCreateGraphicsPipelines";
1309 const std::string param_name = "pCreateInfos[" + std::to_string(i) + "].pViewportState->pViewports[" +
1310 std::to_string(viewport_i) + "]";
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001311 skip |= manual_PreCallValidateViewport(viewport, fn_name, param_name.c_str(),
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07001312 VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001313 }
1314 }
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001315
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001316 if (has_dynamic_viewport_w_scaling_nv && !device_extensions.vk_nv_clip_space_w_scaling) {
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001317 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001318 VK_NULL_HANDLE, kVUID_PVError_ExtensionNotEnabled,
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001319 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
Dave Houltona9df0ce2018-02-07 10:51:23 -07001320 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_VIEWPORT_W_SCALING_NV, but "
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001321 "VK_NV_clip_space_w_scaling extension is not enabled.",
1322 i);
1323 }
1324
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001325 if (has_dynamic_discard_rectangle_ext && !device_extensions.vk_ext_discard_rectangles) {
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001326 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001327 VK_NULL_HANDLE, kVUID_PVError_ExtensionNotEnabled,
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001328 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
Dave Houltona9df0ce2018-02-07 10:51:23 -07001329 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_DISCARD_RECTANGLE_EXT, but "
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001330 "VK_EXT_discard_rectangles extension is not enabled.",
1331 i);
1332 }
1333
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001334 if (has_dynamic_sample_locations_ext && !device_extensions.vk_ext_sample_locations) {
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001335 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001336 VK_NULL_HANDLE, kVUID_PVError_ExtensionNotEnabled,
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001337 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
Dave Houltona9df0ce2018-02-07 10:51:23 -07001338 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_SAMPLE_LOCATIONS_EXT, but "
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001339 "VK_EXT_sample_locations extension is not enabled.",
1340 i);
1341 }
Jeff Bolz3e71f782018-08-29 23:15:45 -05001342
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001343 if (has_dynamic_exclusive_scissor_nv && !device_extensions.vk_nv_scissor_exclusive) {
Jeff Bolz3e71f782018-08-29 23:15:45 -05001344 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
1345 VK_NULL_HANDLE, kVUID_PVError_ExtensionNotEnabled,
1346 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1347 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV, but "
1348 "VK_NV_scissor_exclusive extension is not enabled.",
1349 i);
1350 }
Jeff Bolz9af91c52018-09-01 21:53:57 -05001351
1352 if (coarse_sample_order_struct &&
1353 coarse_sample_order_struct->sampleOrderType != VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV &&
1354 coarse_sample_order_struct->customSampleOrderCount != 0) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06001355 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
1356 VK_NULL_HANDLE,
1357 "VUID-VkPipelineViewportCoarseSampleOrderStateCreateInfoNV-sampleOrderType-02072",
1358 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1359 "] "
1360 "VkPipelineViewportCoarseSampleOrderStateCreateInfoNV sampleOrderType is not "
1361 "VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV and customSampleOrderCount is not 0.",
1362 i);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001363 }
1364
1365 if (coarse_sample_order_struct) {
1366 for (uint32_t order_i = 0; order_i < coarse_sample_order_struct->customSampleOrderCount; ++order_i) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001367 skip |= ValidateCoarseSampleOrderCustomNV(&coarse_sample_order_struct->pCustomSampleOrders[order_i]);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001368 }
1369 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001370 }
1371
1372 if (pCreateInfos[i].pMultisampleState == nullptr) {
1373 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001374 "VUID-VkGraphicsPipelineCreateInfo-rasterizerDiscardEnable-00751",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001375 "vkCreateGraphicsPipelines: if pCreateInfos[%d].pRasterizationState->rasterizerDiscardEnable "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001376 "is VK_FALSE, pCreateInfos[%d].pMultisampleState must not be NULL.",
1377 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001378 } else {
Dave Houltonb3bbec72018-01-17 10:13:33 -07001379 const VkStructureType valid_next_stypes[] = {LvlTypeMap<VkPipelineCoverageModulationStateCreateInfoNV>::kSType,
1380 LvlTypeMap<VkPipelineCoverageToColorStateCreateInfoNV>::kSType,
1381 LvlTypeMap<VkPipelineSampleLocationsStateCreateInfoEXT>::kSType};
Mike Schuchardt97662b02017-12-06 13:31:29 -07001382 const char *valid_struct_names =
Dave Houltona9df0ce2018-02-07 10:51:23 -07001383 "VkPipelineCoverageModulationStateCreateInfoNV, VkPipelineCoverageToColorStateCreateInfoNV, "
John Zulauf96b0e422017-11-14 11:43:19 -07001384 "VkPipelineSampleLocationsStateCreateInfoEXT";
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001385 skip |= validate_struct_pnext(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001386 "vkCreateGraphicsPipelines",
John Zulauf96b0e422017-11-14 11:43:19 -07001387 ParameterName("pCreateInfos[%i].pMultisampleState->pNext", ParameterName::IndexVector{i}),
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07001388 valid_struct_names, pCreateInfos[i].pMultisampleState->pNext, 3, valid_next_stypes,
1389 GeneratedVulkanHeaderVersion, "VUID-VkPipelineMultisampleStateCreateInfo-pNext-pNext");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001390
1391 skip |= validate_reserved_flags(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001392 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001393 ParameterName("pCreateInfos[%i].pMultisampleState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06001394 pCreateInfos[i].pMultisampleState->flags, "VUID-VkPipelineMultisampleStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001395
1396 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001397 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001398 ParameterName("pCreateInfos[%i].pMultisampleState->sampleShadingEnable", ParameterName::IndexVector{i}),
1399 pCreateInfos[i].pMultisampleState->sampleShadingEnable);
1400
1401 skip |= validate_array(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001402 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001403 ParameterName("pCreateInfos[%i].pMultisampleState->rasterizationSamples", ParameterName::IndexVector{i}),
1404 ParameterName("pCreateInfos[%i].pMultisampleState->pSampleMask", ParameterName::IndexVector{i}),
Gabríel Arthúr Pétursson092b29b2018-03-21 22:44:11 +00001405 pCreateInfos[i].pMultisampleState->rasterizationSamples, &pCreateInfos[i].pMultisampleState->pSampleMask,
Dave Houlton413a6782018-05-22 13:01:54 -06001406 true, false, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001407
1408 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001409 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001410 ParameterName("pCreateInfos[%i].pMultisampleState->alphaToCoverageEnable", ParameterName::IndexVector{i}),
1411 pCreateInfos[i].pMultisampleState->alphaToCoverageEnable);
1412
1413 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001414 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001415 ParameterName("pCreateInfos[%i].pMultisampleState->alphaToOneEnable", ParameterName::IndexVector{i}),
1416 pCreateInfos[i].pMultisampleState->alphaToOneEnable);
1417
1418 if (pCreateInfos[i].pMultisampleState->sType != VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO) {
1419 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001420 kVUID_PVError_InvalidStructSType,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001421 "vkCreateGraphicsPipelines: parameter pCreateInfos[%d].pMultisampleState->sType must be "
1422 "VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO",
1423 i);
1424 }
John Zulauf7acac592017-11-06 11:15:53 -07001425 if (pCreateInfos[i].pMultisampleState->sampleShadingEnable == VK_TRUE) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001426 if (!physical_device_features.sampleRateShading) {
John Zulauf7acac592017-11-06 11:15:53 -07001427 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001428 "VUID-VkPipelineMultisampleStateCreateInfo-sampleShadingEnable-00784",
John Zulauf7acac592017-11-06 11:15:53 -07001429 "vkCreateGraphicsPipelines(): parameter "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001430 "pCreateInfos[%d].pMultisampleState->sampleShadingEnable.",
1431 i);
John Zulauf7acac592017-11-06 11:15:53 -07001432 }
1433 // TODO Add documentation issue about when minSampleShading must be in range and when it is ignored
1434 // For now a "least noise" test *only* when sampleShadingEnable is VK_TRUE.
1435 if (!in_inclusive_range(pCreateInfos[i].pMultisampleState->minSampleShading, 0.F, 1.0F)) {
1436 skip |= log_msg(
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001437 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001438 "VUID-VkPipelineMultisampleStateCreateInfo-minSampleShading-00786",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001439 "vkCreateGraphicsPipelines(): parameter pCreateInfos[%d].pMultisampleState->minSampleShading.", i);
John Zulauf7acac592017-11-06 11:15:53 -07001440 }
1441 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001442 }
1443
Petr Krause91f7a12017-12-14 20:57:36 +01001444 bool uses_color_attachment = false;
1445 bool uses_depthstencil_attachment = false;
1446 {
Mark Lobodzinskif27a6bc2019-02-04 13:00:49 -07001447 std::unique_lock<std::mutex> lock(renderpass_map_mutex);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001448 const auto subpasses_uses_it = renderpasses_states.find(pCreateInfos[i].renderPass);
1449 if (subpasses_uses_it != renderpasses_states.end()) {
Petr Krause91f7a12017-12-14 20:57:36 +01001450 const auto &subpasses_uses = subpasses_uses_it->second;
1451 if (subpasses_uses.subpasses_using_color_attachment.count(pCreateInfos[i].subpass))
1452 uses_color_attachment = true;
1453 if (subpasses_uses.subpasses_using_depthstencil_attachment.count(pCreateInfos[i].subpass))
1454 uses_depthstencil_attachment = true;
1455 }
Mark Lobodzinskif27a6bc2019-02-04 13:00:49 -07001456 lock.unlock();
Petr Krause91f7a12017-12-14 20:57:36 +01001457 }
1458
1459 if (pCreateInfos[i].pDepthStencilState != nullptr && uses_depthstencil_attachment) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001460 skip |= validate_struct_pnext(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001461 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001462 ParameterName("pCreateInfos[%i].pDepthStencilState->pNext", ParameterName::IndexVector{i}), NULL,
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001463 pCreateInfos[i].pDepthStencilState->pNext, 0, NULL, GeneratedVulkanHeaderVersion,
Dave Houlton413a6782018-05-22 13:01:54 -06001464 "VUID-VkPipelineDepthStencilStateCreateInfo-pNext-pNext");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001465
1466 skip |= validate_reserved_flags(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001467 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001468 ParameterName("pCreateInfos[%i].pDepthStencilState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06001469 pCreateInfos[i].pDepthStencilState->flags, "VUID-VkPipelineDepthStencilStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001470
1471 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001472 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001473 ParameterName("pCreateInfos[%i].pDepthStencilState->depthTestEnable", ParameterName::IndexVector{i}),
1474 pCreateInfos[i].pDepthStencilState->depthTestEnable);
1475
1476 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001477 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001478 ParameterName("pCreateInfos[%i].pDepthStencilState->depthWriteEnable", ParameterName::IndexVector{i}),
1479 pCreateInfos[i].pDepthStencilState->depthWriteEnable);
1480
1481 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001482 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001483 ParameterName("pCreateInfos[%i].pDepthStencilState->depthCompareOp", ParameterName::IndexVector{i}),
1484 "VkCompareOp", AllVkCompareOpEnums, pCreateInfos[i].pDepthStencilState->depthCompareOp,
Dave Houlton413a6782018-05-22 13:01:54 -06001485 "VUID-VkPipelineDepthStencilStateCreateInfo-depthCompareOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001486
1487 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001488 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001489 ParameterName("pCreateInfos[%i].pDepthStencilState->depthBoundsTestEnable", ParameterName::IndexVector{i}),
1490 pCreateInfos[i].pDepthStencilState->depthBoundsTestEnable);
1491
1492 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001493 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001494 ParameterName("pCreateInfos[%i].pDepthStencilState->stencilTestEnable", ParameterName::IndexVector{i}),
1495 pCreateInfos[i].pDepthStencilState->stencilTestEnable);
1496
1497 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001498 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001499 ParameterName("pCreateInfos[%i].pDepthStencilState->front.failOp", ParameterName::IndexVector{i}),
1500 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->front.failOp,
Dave Houlton413a6782018-05-22 13:01:54 -06001501 "VUID-VkStencilOpState-failOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001502
1503 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001504 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001505 ParameterName("pCreateInfos[%i].pDepthStencilState->front.passOp", ParameterName::IndexVector{i}),
1506 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->front.passOp,
Dave Houlton413a6782018-05-22 13:01:54 -06001507 "VUID-VkStencilOpState-passOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001508
1509 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001510 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001511 ParameterName("pCreateInfos[%i].pDepthStencilState->front.depthFailOp", ParameterName::IndexVector{i}),
1512 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->front.depthFailOp,
Dave Houlton413a6782018-05-22 13:01:54 -06001513 "VUID-VkStencilOpState-depthFailOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001514
1515 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001516 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001517 ParameterName("pCreateInfos[%i].pDepthStencilState->front.compareOp", ParameterName::IndexVector{i}),
1518 "VkCompareOp", AllVkCompareOpEnums, pCreateInfos[i].pDepthStencilState->front.compareOp,
Dave Houlton413a6782018-05-22 13:01:54 -06001519 "VUID-VkPipelineDepthStencilStateCreateInfo-depthCompareOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001520
1521 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001522 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001523 ParameterName("pCreateInfos[%i].pDepthStencilState->back.failOp", ParameterName::IndexVector{i}),
1524 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->back.failOp,
Dave Houlton413a6782018-05-22 13:01:54 -06001525 "VUID-VkStencilOpState-failOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001526
1527 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001528 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001529 ParameterName("pCreateInfos[%i].pDepthStencilState->back.passOp", ParameterName::IndexVector{i}),
1530 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->back.passOp,
Dave Houlton413a6782018-05-22 13:01:54 -06001531 "VUID-VkStencilOpState-passOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001532
1533 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001534 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001535 ParameterName("pCreateInfos[%i].pDepthStencilState->back.depthFailOp", ParameterName::IndexVector{i}),
1536 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->back.depthFailOp,
Dave Houlton413a6782018-05-22 13:01:54 -06001537 "VUID-VkStencilOpState-depthFailOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001538
1539 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001540 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001541 ParameterName("pCreateInfos[%i].pDepthStencilState->back.compareOp", ParameterName::IndexVector{i}),
1542 "VkCompareOp", AllVkCompareOpEnums, pCreateInfos[i].pDepthStencilState->back.compareOp,
Dave Houlton413a6782018-05-22 13:01:54 -06001543 "VUID-VkPipelineDepthStencilStateCreateInfo-depthCompareOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001544
1545 if (pCreateInfos[i].pDepthStencilState->sType != VK_STRUCTURE_TYPE_PIPELINE_DEPTH_STENCIL_STATE_CREATE_INFO) {
1546 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001547 kVUID_PVError_InvalidStructSType,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001548 "vkCreateGraphicsPipelines: parameter pCreateInfos[%d].pDepthStencilState->sType must be "
1549 "VK_STRUCTURE_TYPE_PIPELINE_DEPTH_STENCIL_STATE_CREATE_INFO",
1550 i);
1551 }
1552 }
1553
Shannon McPherson9b9532b2018-10-24 12:00:09 -06001554 const VkStructureType allowed_structs_VkPipelineColorBlendStateCreateInfo[] = {
1555 VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_ADVANCED_STATE_CREATE_INFO_EXT};
1556
Petr Krause91f7a12017-12-14 20:57:36 +01001557 if (pCreateInfos[i].pColorBlendState != nullptr && uses_color_attachment) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001558 skip |= validate_struct_pnext(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001559 "vkCreateGraphicsPipelines",
Shannon McPherson9b9532b2018-10-24 12:00:09 -06001560 ParameterName("pCreateInfos[%i].pColorBlendState->pNext", ParameterName::IndexVector{i}),
1561 "VkPipelineColorBlendAdvancedStateCreateInfoEXT", pCreateInfos[i].pColorBlendState->pNext,
1562 ARRAY_SIZE(allowed_structs_VkPipelineColorBlendStateCreateInfo),
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001563 allowed_structs_VkPipelineColorBlendStateCreateInfo, GeneratedVulkanHeaderVersion,
Dave Houlton413a6782018-05-22 13:01:54 -06001564 "VUID-VkPipelineColorBlendStateCreateInfo-pNext-pNext");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001565
1566 skip |= validate_reserved_flags(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001567 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001568 ParameterName("pCreateInfos[%i].pColorBlendState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06001569 pCreateInfos[i].pColorBlendState->flags, "VUID-VkPipelineColorBlendStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001570
1571 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001572 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001573 ParameterName("pCreateInfos[%i].pColorBlendState->logicOpEnable", ParameterName::IndexVector{i}),
1574 pCreateInfos[i].pColorBlendState->logicOpEnable);
1575
1576 skip |= validate_array(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001577 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001578 ParameterName("pCreateInfos[%i].pColorBlendState->attachmentCount", ParameterName::IndexVector{i}),
1579 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments", ParameterName::IndexVector{i}),
Gabríel Arthúr Pétursson092b29b2018-03-21 22:44:11 +00001580 pCreateInfos[i].pColorBlendState->attachmentCount, &pCreateInfos[i].pColorBlendState->pAttachments, false,
Dave Houlton413a6782018-05-22 13:01:54 -06001581 true, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001582
1583 if (pCreateInfos[i].pColorBlendState->pAttachments != NULL) {
1584 for (uint32_t attachmentIndex = 0; attachmentIndex < pCreateInfos[i].pColorBlendState->attachmentCount;
1585 ++attachmentIndex) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001586 skip |= validate_bool32("vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001587 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].blendEnable",
1588 ParameterName::IndexVector{i, attachmentIndex}),
1589 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].blendEnable);
1590
1591 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001592 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001593 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].srcColorBlendFactor",
1594 ParameterName::IndexVector{i, attachmentIndex}),
1595 "VkBlendFactor", AllVkBlendFactorEnums,
1596 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].srcColorBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06001597 "VUID-VkPipelineColorBlendAttachmentState-srcColorBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001598
1599 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001600 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001601 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].dstColorBlendFactor",
1602 ParameterName::IndexVector{i, attachmentIndex}),
1603 "VkBlendFactor", AllVkBlendFactorEnums,
1604 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].dstColorBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06001605 "VUID-VkPipelineColorBlendAttachmentState-dstColorBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001606
1607 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001608 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001609 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].colorBlendOp",
1610 ParameterName::IndexVector{i, attachmentIndex}),
1611 "VkBlendOp", AllVkBlendOpEnums,
1612 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].colorBlendOp,
Dave Houlton413a6782018-05-22 13:01:54 -06001613 "VUID-VkPipelineColorBlendAttachmentState-colorBlendOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001614
1615 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001616 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001617 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].srcAlphaBlendFactor",
1618 ParameterName::IndexVector{i, attachmentIndex}),
1619 "VkBlendFactor", AllVkBlendFactorEnums,
1620 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].srcAlphaBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06001621 "VUID-VkPipelineColorBlendAttachmentState-srcAlphaBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001622
1623 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001624 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001625 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].dstAlphaBlendFactor",
1626 ParameterName::IndexVector{i, attachmentIndex}),
1627 "VkBlendFactor", AllVkBlendFactorEnums,
1628 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].dstAlphaBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06001629 "VUID-VkPipelineColorBlendAttachmentState-dstAlphaBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001630
1631 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001632 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001633 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].alphaBlendOp",
1634 ParameterName::IndexVector{i, attachmentIndex}),
1635 "VkBlendOp", AllVkBlendOpEnums,
1636 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].alphaBlendOp,
Dave Houlton413a6782018-05-22 13:01:54 -06001637 "VUID-VkPipelineColorBlendAttachmentState-alphaBlendOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001638
1639 skip |=
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001640 validate_flags("vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001641 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].colorWriteMask",
1642 ParameterName::IndexVector{i, attachmentIndex}),
1643 "VkColorComponentFlagBits", AllVkColorComponentFlagBits,
1644 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].colorWriteMask,
Dave Houlton413a6782018-05-22 13:01:54 -06001645 false, false, "VUID-VkPipelineColorBlendAttachmentState-colorWriteMask-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001646 }
1647 }
1648
1649 if (pCreateInfos[i].pColorBlendState->sType != VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO) {
1650 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001651 kVUID_PVError_InvalidStructSType,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001652 "vkCreateGraphicsPipelines: parameter pCreateInfos[%d].pColorBlendState->sType must be "
1653 "VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO",
1654 i);
1655 }
1656
1657 // If logicOpEnable is VK_TRUE, logicOp must be a valid VkLogicOp value
1658 if (pCreateInfos[i].pColorBlendState->logicOpEnable == VK_TRUE) {
1659 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001660 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001661 ParameterName("pCreateInfos[%i].pColorBlendState->logicOp", ParameterName::IndexVector{i}), "VkLogicOp",
Dave Houlton413a6782018-05-22 13:01:54 -06001662 AllVkLogicOpEnums, pCreateInfos[i].pColorBlendState->logicOp,
1663 "VUID-VkPipelineColorBlendStateCreateInfo-logicOpEnable-00607");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001664 }
1665 }
1666 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001667
Petr Kraus9752aae2017-11-24 03:05:50 +01001668 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_DERIVATIVE_BIT) {
1669 if (pCreateInfos[i].basePipelineIndex != -1) {
1670 if (pCreateInfos[i].basePipelineHandle != VK_NULL_HANDLE) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07001671 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001672 "VUID-VkGraphicsPipelineCreateInfo-flags-00724",
Dave Houltona9df0ce2018-02-07 10:51:23 -07001673 "vkCreateGraphicsPipelines parameter, pCreateInfos->basePipelineHandle, must be "
1674 "VK_NULL_HANDLE if pCreateInfos->flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT flag "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001675 "and pCreateInfos->basePipelineIndex is not -1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001676 }
1677 }
1678
Petr Kraus9752aae2017-11-24 03:05:50 +01001679 if (pCreateInfos[i].basePipelineHandle != VK_NULL_HANDLE) {
1680 if (pCreateInfos[i].basePipelineIndex != -1) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07001681 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001682 "VUID-VkGraphicsPipelineCreateInfo-flags-00725",
Dave Houltona9df0ce2018-02-07 10:51:23 -07001683 "vkCreateGraphicsPipelines parameter, pCreateInfos->basePipelineIndex, must be -1 if "
1684 "pCreateInfos->flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT flag and "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001685 "pCreateInfos->basePipelineHandle is not VK_NULL_HANDLE.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001686 }
1687 }
1688 }
1689
Petr Kraus9752aae2017-11-24 03:05:50 +01001690 if (pCreateInfos[i].pRasterizationState) {
1691 if ((pCreateInfos[i].pRasterizationState->polygonMode != VK_POLYGON_MODE_FILL) &&
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001692 (physical_device_features.fillModeNonSolid == false)) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07001693 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001694 kVUID_PVError_DeviceFeature,
Dave Houltona9df0ce2018-02-07 10:51:23 -07001695 "vkCreateGraphicsPipelines parameter, VkPolygonMode "
1696 "pCreateInfos->pRasterizationState->polygonMode cannot be VK_POLYGON_MODE_POINT or "
1697 "VK_POLYGON_MODE_LINE if VkPhysicalDeviceFeatures->fillModeNonSolid is false.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001698 }
Petr Kraus299ba622017-11-24 03:09:03 +01001699
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001700 if (!has_dynamic_line_width && !physical_device_features.wideLines &&
Petr Kraus299ba622017-11-24 03:09:03 +01001701 (pCreateInfos[i].pRasterizationState->lineWidth != 1.0f)) {
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07001702 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, 0,
1703 "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-00749",
1704 "The line width state is static (pCreateInfos[%" PRIu32
1705 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_LINE_WIDTH) and "
1706 "VkPhysicalDeviceFeatures::wideLines is disabled, but pCreateInfos[%" PRIu32
1707 "].pRasterizationState->lineWidth (=%f) is not 1.0.",
1708 i, i, pCreateInfos[i].pRasterizationState->lineWidth);
Petr Kraus299ba622017-11-24 03:09:03 +01001709 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001710 }
1711
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001712 for (size_t j = 0; j < pCreateInfos[i].stageCount; j++) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001713 skip |= validate_string("vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001714 ParameterName("pCreateInfos[%i].pStages[%i].pName", ParameterName::IndexVector{i, j}),
Mark Lobodzinskiebee3552018-05-29 09:55:54 -06001715 "VUID-VkGraphicsPipelineCreateInfo-pStages-parameter", pCreateInfos[i].pStages[j].pName);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001716 }
1717 }
1718 }
1719
1720 return skip;
1721}
1722
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07001723bool StatelessValidation::manual_PreCallValidateCreateComputePipelines(VkDevice device, VkPipelineCache pipelineCache,
1724 uint32_t createInfoCount,
1725 const VkComputePipelineCreateInfo *pCreateInfos,
1726 const VkAllocationCallbacks *pAllocator,
1727 VkPipeline *pPipelines) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001728 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001729 for (uint32_t i = 0; i < createInfoCount; i++) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001730 skip |= validate_string("vkCreateComputePipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001731 ParameterName("pCreateInfos[%i].stage.pName", ParameterName::IndexVector{i}),
Mark Lobodzinskiebee3552018-05-29 09:55:54 -06001732 "VUID-VkPipelineShaderStageCreateInfo-pName-parameter", pCreateInfos[i].stage.pName);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001733 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001734 return skip;
1735}
1736
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001737bool StatelessValidation::manual_PreCallValidateCreateSampler(VkDevice device, const VkSamplerCreateInfo *pCreateInfo,
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07001738 const VkAllocationCallbacks *pAllocator, VkSampler *pSampler) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001739 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001740
1741 if (pCreateInfo != nullptr) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001742 const auto &features = physical_device_features;
1743 const auto &limits = device_limits;
Jesse Hallcc1fbef2018-06-03 15:58:56 -07001744
John Zulauf71968502017-10-26 13:51:15 -06001745 if (pCreateInfo->anisotropyEnable == VK_TRUE) {
1746 if (!in_inclusive_range(pCreateInfo->maxAnisotropy, 1.0F, limits.maxSamplerAnisotropy)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001747 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001748 "VUID-VkSamplerCreateInfo-anisotropyEnable-01071",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001749 "vkCreateSampler(): value of %s must be in range [1.0, %f] %s, but %f found.",
John Zulauf71968502017-10-26 13:51:15 -06001750 "pCreateInfo->maxAnisotropy", limits.maxSamplerAnisotropy,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001751 "VkPhysicalDeviceLimits::maxSamplerAnistropy", pCreateInfo->maxAnisotropy);
John Zulauf71968502017-10-26 13:51:15 -06001752 }
1753
1754 // Anistropy cannot be enabled in sampler unless enabled as a feature
1755 if (features.samplerAnisotropy == VK_FALSE) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001756 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001757 "VUID-VkSamplerCreateInfo-anisotropyEnable-01070",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001758 "vkCreateSampler(): Anisotropic sampling feature is not enabled, %s must be VK_FALSE.",
1759 "pCreateInfo->anisotropyEnable");
John Zulauf71968502017-10-26 13:51:15 -06001760 }
Jesse Hallcc1fbef2018-06-03 15:58:56 -07001761 }
John Zulauf71968502017-10-26 13:51:15 -06001762
Jesse Hallcc1fbef2018-06-03 15:58:56 -07001763 if (pCreateInfo->unnormalizedCoordinates == VK_TRUE) {
1764 if (pCreateInfo->minFilter != pCreateInfo->magFilter) {
1765 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1766 "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01072",
1767 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
1768 "pCreateInfo->minFilter (%s) and pCreateInfo->magFilter (%s) must be equal.",
1769 string_VkFilter(pCreateInfo->minFilter), string_VkFilter(pCreateInfo->magFilter));
1770 }
1771 if (pCreateInfo->mipmapMode != VK_SAMPLER_MIPMAP_MODE_NEAREST) {
1772 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1773 "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01073",
1774 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
1775 "pCreateInfo->mipmapMode (%s) must be VK_SAMPLER_MIPMAP_MODE_NEAREST.",
1776 string_VkSamplerMipmapMode(pCreateInfo->mipmapMode));
1777 }
1778 if (pCreateInfo->minLod != 0.0f || pCreateInfo->maxLod != 0.0f) {
1779 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1780 "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01074",
1781 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
1782 "pCreateInfo->minLod (%f) and pCreateInfo->maxLod (%f) must both be zero.",
1783 pCreateInfo->minLod, pCreateInfo->maxLod);
1784 }
1785 if ((pCreateInfo->addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE &&
1786 pCreateInfo->addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER) ||
1787 (pCreateInfo->addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE &&
1788 pCreateInfo->addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER)) {
1789 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1790 "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01075",
1791 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
1792 "pCreateInfo->addressModeU (%s) and pCreateInfo->addressModeV (%s) must both be "
1793 "VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE or VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER.",
1794 string_VkSamplerAddressMode(pCreateInfo->addressModeU),
1795 string_VkSamplerAddressMode(pCreateInfo->addressModeV));
1796 }
1797 if (pCreateInfo->anisotropyEnable == VK_TRUE) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001798 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001799 "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01076",
Dave Houltona9df0ce2018-02-07 10:51:23 -07001800 "vkCreateSampler(): pCreateInfo->anisotropyEnable and pCreateInfo->unnormalizedCoordinates must "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001801 "not both be VK_TRUE.");
John Zulauf71968502017-10-26 13:51:15 -06001802 }
Jesse Hallcc1fbef2018-06-03 15:58:56 -07001803 if (pCreateInfo->compareEnable == VK_TRUE) {
1804 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1805 "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01077",
1806 "vkCreateSampler(): pCreateInfo->compareEnable and pCreateInfo->unnormalizedCoordinates must "
1807 "not both be VK_TRUE.");
1808 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001809 }
1810
1811 // If compareEnable is VK_TRUE, compareOp must be a valid VkCompareOp value
1812 if (pCreateInfo->compareEnable == VK_TRUE) {
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07001813 skip |= validate_ranged_enum("vkCreateSampler", "pCreateInfo->compareOp", "VkCompareOp", AllVkCompareOpEnums,
1814 pCreateInfo->compareOp, "VUID-VkSamplerCreateInfo-compareEnable-01080");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001815 }
1816
1817 // If any of addressModeU, addressModeV or addressModeW are VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER, borderColor must be a
1818 // valid VkBorderColor value
1819 if ((pCreateInfo->addressModeU == VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER) ||
1820 (pCreateInfo->addressModeV == VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER) ||
1821 (pCreateInfo->addressModeW == VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER)) {
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07001822 skip |= validate_ranged_enum("vkCreateSampler", "pCreateInfo->borderColor", "VkBorderColor", AllVkBorderColorEnums,
1823 pCreateInfo->borderColor, "VUID-VkSamplerCreateInfo-addressModeU-01078");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001824 }
1825
1826 // If any of addressModeU, addressModeV or addressModeW are VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE, the
1827 // VK_KHR_sampler_mirror_clamp_to_edge extension must be enabled
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001828 if (!device_extensions.vk_khr_sampler_mirror_clamp_to_edge &&
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001829 ((pCreateInfo->addressModeU == VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE) ||
1830 (pCreateInfo->addressModeV == VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE) ||
1831 (pCreateInfo->addressModeW == VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE))) {
Dave Houlton413a6782018-05-22 13:01:54 -06001832 skip |=
1833 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1834 "VUID-VkSamplerCreateInfo-addressModeU-01079",
1835 "vkCreateSampler(): A VkSamplerAddressMode value is set to VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE "
1836 "but the VK_KHR_sampler_mirror_clamp_to_edge extension has not been enabled.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001837 }
John Zulauf275805c2017-10-26 15:34:49 -06001838
1839 // Checks for the IMG cubic filtering extension
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001840 if (device_extensions.vk_img_filter_cubic) {
John Zulauf275805c2017-10-26 15:34:49 -06001841 if ((pCreateInfo->anisotropyEnable == VK_TRUE) &&
1842 ((pCreateInfo->minFilter == VK_FILTER_CUBIC_IMG) || (pCreateInfo->magFilter == VK_FILTER_CUBIC_IMG))) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001843 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001844 "VUID-VkSamplerCreateInfo-magFilter-01081",
Dave Houltona9df0ce2018-02-07 10:51:23 -07001845 "vkCreateSampler(): Anisotropic sampling must not be VK_TRUE when either minFilter or magFilter "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001846 "are VK_FILTER_CUBIC_IMG.");
John Zulauf275805c2017-10-26 15:34:49 -06001847 }
1848 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001849 }
1850
1851 return skip;
1852}
1853
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07001854bool StatelessValidation::manual_PreCallValidateCreateDescriptorSetLayout(VkDevice device,
1855 const VkDescriptorSetLayoutCreateInfo *pCreateInfo,
1856 const VkAllocationCallbacks *pAllocator,
1857 VkDescriptorSetLayout *pSetLayout) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001858 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001859
1860 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
1861 if ((pCreateInfo != nullptr) && (pCreateInfo->pBindings != nullptr)) {
1862 for (uint32_t i = 0; i < pCreateInfo->bindingCount; ++i) {
1863 if (pCreateInfo->pBindings[i].descriptorCount != 0) {
1864 // If descriptorType is VK_DESCRIPTOR_TYPE_SAMPLER or VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER, and descriptorCount
1865 // is not 0 and pImmutableSamplers is not NULL, pImmutableSamplers must be a pointer to an array of descriptorCount
1866 // valid VkSampler handles
1867 if (((pCreateInfo->pBindings[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLER) ||
1868 (pCreateInfo->pBindings[i].descriptorType == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER)) &&
1869 (pCreateInfo->pBindings[i].pImmutableSamplers != nullptr)) {
1870 for (uint32_t descriptor_index = 0; descriptor_index < pCreateInfo->pBindings[i].descriptorCount;
1871 ++descriptor_index) {
1872 if (pCreateInfo->pBindings[i].pImmutableSamplers[descriptor_index] == VK_NULL_HANDLE) {
1873 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001874 kVUID_PVError_RequiredParameter,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001875 "vkCreateDescriptorSetLayout: required parameter "
Dave Houltona9df0ce2018-02-07 10:51:23 -07001876 "pCreateInfo->pBindings[%d].pImmutableSamplers[%d] specified as VK_NULL_HANDLE",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001877 i, descriptor_index);
1878 }
1879 }
1880 }
1881
1882 // If descriptorCount is not 0, stageFlags must be a valid combination of VkShaderStageFlagBits values
1883 if ((pCreateInfo->pBindings[i].stageFlags != 0) &&
1884 ((pCreateInfo->pBindings[i].stageFlags & (~AllVkShaderStageFlagBits)) != 0)) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07001885 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001886 "VUID-VkDescriptorSetLayoutBinding-descriptorCount-00283",
Dave Houltona9df0ce2018-02-07 10:51:23 -07001887 "vkCreateDescriptorSetLayout(): if pCreateInfo->pBindings[%d].descriptorCount is not 0, "
1888 "pCreateInfo->pBindings[%d].stageFlags must be a valid combination of VkShaderStageFlagBits "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001889 "values.",
1890 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001891 }
1892 }
1893 }
1894 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001895 return skip;
1896}
1897
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07001898bool StatelessValidation::manual_PreCallValidateFreeDescriptorSets(VkDevice device, VkDescriptorPool descriptorPool,
1899 uint32_t descriptorSetCount,
1900 const VkDescriptorSet *pDescriptorSets) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001901 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
1902 // This is an array of handles, where the elements are allowed to be VK_NULL_HANDLE, and does not require any validation beyond
1903 // validate_array()
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07001904 return validate_array("vkFreeDescriptorSets", "descriptorSetCount", "pDescriptorSets", descriptorSetCount, &pDescriptorSets,
1905 true, true, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001906}
1907
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001908bool StatelessValidation::manual_PreCallValidateUpdateDescriptorSets(VkDevice device, uint32_t descriptorWriteCount,
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07001909 const VkWriteDescriptorSet *pDescriptorWrites,
1910 uint32_t descriptorCopyCount,
1911 const VkCopyDescriptorSet *pDescriptorCopies) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001912 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001913 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
1914 if (pDescriptorWrites != NULL) {
1915 for (uint32_t i = 0; i < descriptorWriteCount; ++i) {
1916 // descriptorCount must be greater than 0
1917 if (pDescriptorWrites[i].descriptorCount == 0) {
1918 skip |=
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001919 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001920 "VUID-VkWriteDescriptorSet-descriptorCount-arraylength",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001921 "vkUpdateDescriptorSets(): parameter pDescriptorWrites[%d].descriptorCount must be greater than 0.", i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001922 }
1923
1924 // dstSet must be a valid VkDescriptorSet handle
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001925 skip |= validate_required_handle("vkUpdateDescriptorSets",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001926 ParameterName("pDescriptorWrites[%i].dstSet", ParameterName::IndexVector{i}),
1927 pDescriptorWrites[i].dstSet);
1928
1929 if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLER) ||
1930 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER) ||
1931 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE) ||
1932 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_IMAGE) ||
1933 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT)) {
1934 // If descriptorType is VK_DESCRIPTOR_TYPE_SAMPLER, VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER,
1935 // VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE, VK_DESCRIPTOR_TYPE_STORAGE_IMAGE or VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT,
1936 // pImageInfo must be a pointer to an array of descriptorCount valid VkDescriptorImageInfo structures
1937 if (pDescriptorWrites[i].pImageInfo == nullptr) {
1938 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001939 "VUID-VkWriteDescriptorSet-descriptorType-00322",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001940 "vkUpdateDescriptorSets(): if pDescriptorWrites[%d].descriptorType is "
1941 "VK_DESCRIPTOR_TYPE_SAMPLER, VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER, "
1942 "VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE, VK_DESCRIPTOR_TYPE_STORAGE_IMAGE or "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001943 "VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT, pDescriptorWrites[%d].pImageInfo must not be NULL.",
1944 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001945 } else if (pDescriptorWrites[i].descriptorType != VK_DESCRIPTOR_TYPE_SAMPLER) {
1946 // If descriptorType is VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER, VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE,
1947 // VK_DESCRIPTOR_TYPE_STORAGE_IMAGE or VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT, the imageView and imageLayout
1948 // members of any given element of pImageInfo must be a valid VkImageView and VkImageLayout, respectively
1949 for (uint32_t descriptor_index = 0; descriptor_index < pDescriptorWrites[i].descriptorCount;
1950 ++descriptor_index) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001951 skip |= validate_required_handle("vkUpdateDescriptorSets",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001952 ParameterName("pDescriptorWrites[%i].pImageInfo[%i].imageView",
1953 ParameterName::IndexVector{i, descriptor_index}),
1954 pDescriptorWrites[i].pImageInfo[descriptor_index].imageView);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001955 skip |= validate_ranged_enum("vkUpdateDescriptorSets",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001956 ParameterName("pDescriptorWrites[%i].pImageInfo[%i].imageLayout",
1957 ParameterName::IndexVector{i, descriptor_index}),
1958 "VkImageLayout", AllVkImageLayoutEnums,
Dave Houlton413a6782018-05-22 13:01:54 -06001959 pDescriptorWrites[i].pImageInfo[descriptor_index].imageLayout, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001960 }
1961 }
1962 } else if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER) ||
1963 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER) ||
1964 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC) ||
1965 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC)) {
1966 // If descriptorType is VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER, VK_DESCRIPTOR_TYPE_STORAGE_BUFFER,
1967 // VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC or VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC, pBufferInfo must be a
1968 // pointer to an array of descriptorCount valid VkDescriptorBufferInfo structures
1969 if (pDescriptorWrites[i].pBufferInfo == nullptr) {
1970 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001971 "VUID-VkWriteDescriptorSet-descriptorType-00324",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001972 "vkUpdateDescriptorSets(): if pDescriptorWrites[%d].descriptorType is "
1973 "VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER, VK_DESCRIPTOR_TYPE_STORAGE_BUFFER, "
1974 "VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC or VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC, "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001975 "pDescriptorWrites[%d].pBufferInfo must not be NULL.",
1976 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001977 } else {
1978 for (uint32_t descriptorIndex = 0; descriptorIndex < pDescriptorWrites[i].descriptorCount; ++descriptorIndex) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001979 skip |= validate_required_handle("vkUpdateDescriptorSets",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001980 ParameterName("pDescriptorWrites[%i].pBufferInfo[%i].buffer",
1981 ParameterName::IndexVector{i, descriptorIndex}),
1982 pDescriptorWrites[i].pBufferInfo[descriptorIndex].buffer);
1983 }
1984 }
1985 } else if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER) ||
1986 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER)) {
1987 // If descriptorType is VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER or VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER,
1988 // pTexelBufferView must be a pointer to an array of descriptorCount valid VkBufferView handles
1989 if (pDescriptorWrites[i].pTexelBufferView == nullptr) {
1990 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001991 "VUID-VkWriteDescriptorSet-descriptorType-00323",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001992 "vkUpdateDescriptorSets(): if pDescriptorWrites[%d].descriptorType is "
1993 "VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER or VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER, "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001994 "pDescriptorWrites[%d].pTexelBufferView must not be NULL.",
1995 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001996 } else {
1997 for (uint32_t descriptor_index = 0; descriptor_index < pDescriptorWrites[i].descriptorCount;
1998 ++descriptor_index) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001999 skip |= validate_required_handle("vkUpdateDescriptorSets",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002000 ParameterName("pDescriptorWrites[%i].pTexelBufferView[%i]",
2001 ParameterName::IndexVector{i, descriptor_index}),
2002 pDescriptorWrites[i].pTexelBufferView[descriptor_index]);
2003 }
2004 }
2005 }
2006
2007 if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER) ||
2008 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC)) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002009 VkDeviceSize uniformAlignment = device_limits.minUniformBufferOffsetAlignment;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002010 for (uint32_t j = 0; j < pDescriptorWrites[i].descriptorCount; j++) {
2011 if (pDescriptorWrites[i].pBufferInfo != NULL) {
2012 if (SafeModulo(pDescriptorWrites[i].pBufferInfo[j].offset, uniformAlignment) != 0) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06002013 skip |=
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002014 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT,
2015 0, "VUID-VkWriteDescriptorSet-descriptorType-00327",
Mark Lobodzinski88529492018-04-01 10:38:15 -06002016 "vkUpdateDescriptorSets(): pDescriptorWrites[%d].pBufferInfo[%d].offset (0x%" PRIxLEAST64
2017 ") must be a multiple of device limit minUniformBufferOffsetAlignment 0x%" PRIxLEAST64 ".",
2018 i, j, pDescriptorWrites[i].pBufferInfo[j].offset, uniformAlignment);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002019 }
2020 }
2021 }
2022 } else if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER) ||
2023 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC)) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002024 VkDeviceSize storageAlignment = device_limits.minStorageBufferOffsetAlignment;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002025 for (uint32_t j = 0; j < pDescriptorWrites[i].descriptorCount; j++) {
2026 if (pDescriptorWrites[i].pBufferInfo != NULL) {
2027 if (SafeModulo(pDescriptorWrites[i].pBufferInfo[j].offset, storageAlignment) != 0) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06002028 skip |=
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002029 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT,
2030 0, "VUID-VkWriteDescriptorSet-descriptorType-00328",
Mark Lobodzinski88529492018-04-01 10:38:15 -06002031 "vkUpdateDescriptorSets(): pDescriptorWrites[%d].pBufferInfo[%d].offset (0x%" PRIxLEAST64
2032 ") must be a multiple of device limit minStorageBufferOffsetAlignment 0x%" PRIxLEAST64 ".",
2033 i, j, pDescriptorWrites[i].pBufferInfo[j].offset, storageAlignment);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002034 }
2035 }
2036 }
2037 }
2038 }
2039 }
2040 return skip;
2041}
2042
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002043bool StatelessValidation::manual_PreCallValidateCreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo,
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002044 const VkAllocationCallbacks *pAllocator,
2045 VkRenderPass *pRenderPass) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002046 return CreateRenderPassGeneric(device, pCreateInfo, pAllocator, pRenderPass, RENDER_PASS_VERSION_1);
2047}
2048
2049bool StatelessValidation::manual_PreCallValidateCreateRenderPass2KHR(VkDevice device, const VkRenderPassCreateInfo2KHR *pCreateInfo,
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002050 const VkAllocationCallbacks *pAllocator,
2051 VkRenderPass *pRenderPass) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002052 return CreateRenderPassGeneric(device, pCreateInfo, pAllocator, pRenderPass, RENDER_PASS_VERSION_2);
2053}
2054
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002055bool StatelessValidation::manual_PreCallValidateFreeCommandBuffers(VkDevice device, VkCommandPool commandPool,
2056 uint32_t commandBufferCount,
2057 const VkCommandBuffer *pCommandBuffers) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002058 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002059
2060 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
2061 // This is an array of handles, where the elements are allowed to be VK_NULL_HANDLE, and does not require any validation beyond
2062 // validate_array()
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002063 skip |= validate_array("vkFreeCommandBuffers", "commandBufferCount", "pCommandBuffers", commandBufferCount, &pCommandBuffers,
2064 true, true, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002065 return skip;
2066}
2067
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002068bool StatelessValidation::manual_PreCallValidateBeginCommandBuffer(VkCommandBuffer commandBuffer,
2069 const VkCommandBufferBeginInfo *pBeginInfo) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002070 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002071 const VkCommandBufferInheritanceInfo *pInfo = pBeginInfo->pInheritanceInfo;
2072
2073 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
2074 // TODO: pBeginInfo->pInheritanceInfo must not be NULL if commandBuffer is a secondary command buffer
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002075 skip |= validate_struct_type("vkBeginCommandBuffer", "pBeginInfo->pInheritanceInfo",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002076 "VK_STRUCTURE_TYPE_COMMAND_BUFFER_INHERITANCE_INFO", pBeginInfo->pInheritanceInfo,
Mark Lobodzinskia16ebc72018-06-15 14:47:39 -06002077 VK_STRUCTURE_TYPE_COMMAND_BUFFER_INHERITANCE_INFO, false,
2078 "VUID_vkBeginCommandBuffer-pBeginInfo-parameter", "VUID_VkCommandBufferBeginInfo-sType-sType");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002079
2080 if (pBeginInfo->pInheritanceInfo != NULL) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002081 skip |= validate_struct_pnext("vkBeginCommandBuffer", "pBeginInfo->pInheritanceInfo->pNext", NULL,
2082 pBeginInfo->pInheritanceInfo->pNext, 0, NULL, GeneratedVulkanHeaderVersion,
Dave Houlton413a6782018-05-22 13:01:54 -06002083 "VUID-VkCommandBufferBeginInfo-pNext-pNext");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002084
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002085 skip |= validate_bool32("vkBeginCommandBuffer", "pBeginInfo->pInheritanceInfo->occlusionQueryEnable",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002086 pBeginInfo->pInheritanceInfo->occlusionQueryEnable);
2087
2088 // TODO: This only needs to be validated when the inherited queries feature is enabled
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002089 // skip |= validate_flags("vkBeginCommandBuffer", "pBeginInfo->pInheritanceInfo->queryFlags",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002090 // "VkQueryControlFlagBits", AllVkQueryControlFlagBits, pBeginInfo->pInheritanceInfo->queryFlags, false);
2091
2092 // TODO: This must be 0 if the pipeline statistics queries feature is not enabled
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002093 skip |= validate_flags("vkBeginCommandBuffer", "pBeginInfo->pInheritanceInfo->pipelineStatistics",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002094 "VkQueryPipelineStatisticFlagBits", AllVkQueryPipelineStatisticFlagBits,
Dave Houlton413a6782018-05-22 13:01:54 -06002095 pBeginInfo->pInheritanceInfo->pipelineStatistics, false, false, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002096 }
2097
2098 if (pInfo != NULL) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002099 if ((physical_device_features.inheritedQueries == VK_FALSE) && (pInfo->occlusionQueryEnable != VK_FALSE)) {
2100 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002101 HandleToUint64(commandBuffer), "VUID-VkCommandBufferInheritanceInfo-occlusionQueryEnable-00056",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002102 "Cannot set inherited occlusionQueryEnable in vkBeginCommandBuffer() when device does not support "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002103 "inheritedQueries.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002104 }
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002105 if ((physical_device_features.inheritedQueries != VK_FALSE) && (pInfo->occlusionQueryEnable != VK_FALSE)) {
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002106 skip |= validate_flags("vkBeginCommandBuffer", "pBeginInfo->pInheritanceInfo->queryFlags", "VkQueryControlFlagBits",
2107 AllVkQueryControlFlagBits, pInfo->queryFlags, false, false,
Dave Houlton413a6782018-05-22 13:01:54 -06002108 "VUID-VkCommandBufferInheritanceInfo-queryFlags-00057");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002109 }
2110 }
2111
2112 return skip;
2113}
2114
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002115bool StatelessValidation::manual_PreCallValidateCmdSetViewport(VkCommandBuffer commandBuffer, uint32_t firstViewport,
2116 uint32_t viewportCount, const VkViewport *pViewports) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002117 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002118
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002119 if (!physical_device_features.multiViewport) {
Petr Krausd55e77c2018-01-09 22:09:25 +01002120 if (firstViewport != 0) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002121 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002122 HandleToUint64(commandBuffer), "VUID-vkCmdSetViewport-firstViewport-01224",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002123 "vkCmdSetViewport: The multiViewport feature is disabled, but firstViewport (=%" PRIu32 ") is not 0.",
2124 firstViewport);
Petr Krausd55e77c2018-01-09 22:09:25 +01002125 }
2126 if (viewportCount > 1) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002127 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002128 HandleToUint64(commandBuffer), "VUID-vkCmdSetViewport-viewportCount-01225",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002129 "vkCmdSetViewport: The multiViewport feature is disabled, but viewportCount (=%" PRIu32 ") is not 1.",
2130 viewportCount);
Petr Krausd55e77c2018-01-09 22:09:25 +01002131 }
2132 } else { // multiViewport enabled
Petr Kraus7dfeed12018-02-27 20:51:20 +01002133 const uint64_t sum = static_cast<uint64_t>(firstViewport) + static_cast<uint64_t>(viewportCount);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002134 if (sum > device_limits.maxViewports) {
2135 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002136 HandleToUint64(commandBuffer), "VUID-vkCmdSetViewport-firstViewport-01223",
Petr Krausd55e77c2018-01-09 22:09:25 +01002137 "vkCmdSetViewport: firstViewport + viewportCount (=%" PRIu32 " + %" PRIu32 " = %" PRIu64
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002138 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002139 firstViewport, viewportCount, sum, device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002140 }
2141 }
Petr Krausb3fcdb42018-01-09 22:09:09 +01002142
2143 if (pViewports) {
2144 for (uint32_t viewport_i = 0; viewport_i < viewportCount; ++viewport_i) {
2145 const auto &viewport = pViewports[viewport_i]; // will crash on invalid ptr
2146 const char fn_name[] = "vkCmdSetViewport";
2147 const std::string param_name = "pViewports[" + std::to_string(viewport_i) + "]";
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002148 skip |= manual_PreCallValidateViewport(viewport, fn_name, param_name.c_str(),
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002149 VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, HandleToUint64(commandBuffer));
Petr Krausb3fcdb42018-01-09 22:09:09 +01002150 }
2151 }
2152
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002153 return skip;
2154}
2155
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002156bool StatelessValidation::manual_PreCallValidateCmdSetScissor(VkCommandBuffer commandBuffer, uint32_t firstScissor,
2157 uint32_t scissorCount, const VkRect2D *pScissors) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002158 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002159
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002160 if (!physical_device_features.multiViewport) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002161 if (firstScissor != 0) {
Petr Kraus6260f0a2018-02-27 21:15:55 +01002162 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002163 HandleToUint64(commandBuffer), "VUID-vkCmdSetScissor-firstScissor-00593",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002164 "vkCmdSetScissor: The multiViewport feature is disabled, but firstScissor (=%" PRIu32 ") is not 0.",
2165 firstScissor);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002166 }
2167 if (scissorCount > 1) {
2168 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002169 HandleToUint64(commandBuffer), "VUID-vkCmdSetScissor-scissorCount-00594",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002170 "vkCmdSetScissor: The multiViewport feature is disabled, but scissorCount (=%" PRIu32 ") is not 1.",
2171 scissorCount);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002172 }
2173 } else { // multiViewport enabled
2174 const uint64_t sum = static_cast<uint64_t>(firstScissor) + static_cast<uint64_t>(scissorCount);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002175 if (sum > device_limits.maxViewports) {
2176 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002177 HandleToUint64(commandBuffer), "VUID-vkCmdSetScissor-firstScissor-00592",
Petr Kraus6260f0a2018-02-27 21:15:55 +01002178 "vkCmdSetScissor: firstScissor + scissorCount (=%" PRIu32 " + %" PRIu32 " = %" PRIu64
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002179 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002180 firstScissor, scissorCount, sum, device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002181 }
2182 }
2183
Petr Kraus6260f0a2018-02-27 21:15:55 +01002184 if (pScissors) {
2185 for (uint32_t scissor_i = 0; scissor_i < scissorCount; ++scissor_i) {
2186 const auto &scissor = pScissors[scissor_i]; // will crash on invalid ptr
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002187
Petr Kraus6260f0a2018-02-27 21:15:55 +01002188 if (scissor.offset.x < 0) {
2189 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002190 HandleToUint64(commandBuffer), "VUID-vkCmdSetScissor-x-00595",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002191 "vkCmdSetScissor: pScissors[%" PRIu32 "].offset.x (=%" PRIi32 ") is negative.", scissor_i,
2192 scissor.offset.x);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002193 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002194
Petr Kraus6260f0a2018-02-27 21:15:55 +01002195 if (scissor.offset.y < 0) {
2196 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002197 HandleToUint64(commandBuffer), "VUID-vkCmdSetScissor-x-00595",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002198 "vkCmdSetScissor: pScissors[%" PRIu32 "].offset.y (=%" PRIi32 ") is negative.", scissor_i,
2199 scissor.offset.y);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002200 }
2201
2202 const int64_t x_sum = static_cast<int64_t>(scissor.offset.x) + static_cast<int64_t>(scissor.extent.width);
2203 if (x_sum > INT32_MAX) {
2204 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002205 HandleToUint64(commandBuffer), "VUID-vkCmdSetScissor-offset-00596",
Petr Kraus6260f0a2018-02-27 21:15:55 +01002206 "vkCmdSetScissor: offset.x + extent.width (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002207 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
2208 scissor.offset.x, scissor.extent.width, x_sum, scissor_i);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002209 }
2210
2211 const int64_t y_sum = static_cast<int64_t>(scissor.offset.y) + static_cast<int64_t>(scissor.extent.height);
2212 if (y_sum > INT32_MAX) {
2213 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002214 HandleToUint64(commandBuffer), "VUID-vkCmdSetScissor-offset-00597",
Petr Kraus6260f0a2018-02-27 21:15:55 +01002215 "vkCmdSetScissor: offset.y + extent.height (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002216 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
2217 scissor.offset.y, scissor.extent.height, y_sum, scissor_i);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002218 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002219 }
2220 }
Petr Kraus6260f0a2018-02-27 21:15:55 +01002221
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002222 return skip;
2223}
2224
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002225bool StatelessValidation::manual_PreCallValidateCmdSetLineWidth(VkCommandBuffer commandBuffer, float lineWidth) {
Petr Kraus299ba622017-11-24 03:09:03 +01002226 bool skip = false;
Petr Kraus299ba622017-11-24 03:09:03 +01002227
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002228 if (!physical_device_features.wideLines && (lineWidth != 1.0f)) {
Petr Kraus299ba622017-11-24 03:09:03 +01002229 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002230 HandleToUint64(commandBuffer), "VUID-vkCmdSetLineWidth-lineWidth-00788",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002231 "VkPhysicalDeviceFeatures::wideLines is disabled, but lineWidth (=%f) is not 1.0.", lineWidth);
Petr Kraus299ba622017-11-24 03:09:03 +01002232 }
2233
2234 return skip;
2235}
2236
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002237bool StatelessValidation::manual_PreCallValidateCmdDraw(VkCommandBuffer commandBuffer, uint32_t vertexCount, uint32_t instanceCount,
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002238 uint32_t firstVertex, uint32_t firstInstance) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002239 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002240 if (vertexCount == 0) {
2241 // TODO: Verify against Valid Usage section. I don't see a non-zero vertexCount listed, may need to add that and make
2242 // this an error or leave as is.
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002243 skip |= log_msg(report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002244 kVUID_PVError_RequiredParameter, "vkCmdDraw parameter, uint32_t vertexCount, is 0");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002245 }
2246
2247 if (instanceCount == 0) {
2248 // TODO: Verify against Valid Usage section. I don't see a non-zero instanceCount listed, may need to add that and make
2249 // this an error or leave as is.
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002250 skip |= log_msg(report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002251 kVUID_PVError_RequiredParameter, "vkCmdDraw parameter, uint32_t instanceCount, is 0");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002252 }
2253 return skip;
2254}
2255
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002256bool StatelessValidation::manual_PreCallValidateCmdDrawIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset,
2257 uint32_t count, uint32_t stride) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002258 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002259
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002260 if (!physical_device_features.multiDrawIndirect && ((count > 1))) {
2261 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002262 kVUID_PVError_DeviceFeature,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002263 "CmdDrawIndirect(): Device feature multiDrawIndirect disabled: count must be 0 or 1 but is %d", count);
2264 }
2265 return skip;
2266}
2267
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002268bool StatelessValidation::manual_PreCallValidateCmdDrawIndexedIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer,
2269 VkDeviceSize offset, uint32_t count, uint32_t stride) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002270 bool skip = false;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002271 if (!physical_device_features.multiDrawIndirect && ((count > 1))) {
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002272 skip |= log_msg(
2273 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, kVUID_PVError_DeviceFeature,
2274 "CmdDrawIndexedIndirect(): Device feature multiDrawIndirect disabled: count must be 0 or 1 but is %d", count);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002275 }
2276 return skip;
2277}
2278
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002279bool StatelessValidation::manual_PreCallValidateCmdCopyImage(VkCommandBuffer commandBuffer, VkImage srcImage,
2280 VkImageLayout srcImageLayout, VkImage dstImage,
2281 VkImageLayout dstImageLayout, uint32_t regionCount,
2282 const VkImageCopy *pRegions) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002283 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002284
Dave Houltonf5217612018-02-02 16:18:52 -07002285 VkImageAspectFlags legal_aspect_flags =
2286 VK_IMAGE_ASPECT_COLOR_BIT | VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT | VK_IMAGE_ASPECT_METADATA_BIT;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002287 if (device_extensions.vk_khr_sampler_ycbcr_conversion) {
Dave Houltonf5217612018-02-02 16:18:52 -07002288 legal_aspect_flags |= (VK_IMAGE_ASPECT_PLANE_0_BIT_KHR | VK_IMAGE_ASPECT_PLANE_1_BIT_KHR | VK_IMAGE_ASPECT_PLANE_2_BIT_KHR);
2289 }
2290
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002291 if (pRegions != nullptr) {
Dave Houltonf5217612018-02-02 16:18:52 -07002292 if ((pRegions->srcSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002293 skip |= log_msg(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002294 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002295 "VUID-VkImageSubresourceLayers-aspectMask-parameter",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002296 "vkCmdCopyImage() parameter, VkImageAspect pRegions->srcSubresource.aspectMask, is an unrecognized enumerator.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002297 }
Dave Houltonf5217612018-02-02 16:18:52 -07002298 if ((pRegions->dstSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002299 skip |= log_msg(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002300 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002301 "VUID-VkImageSubresourceLayers-aspectMask-parameter",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002302 "vkCmdCopyImage() parameter, VkImageAspect pRegions->dstSubresource.aspectMask, is an unrecognized enumerator.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002303 }
2304 }
2305 return skip;
2306}
2307
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002308bool StatelessValidation::manual_PreCallValidateCmdBlitImage(VkCommandBuffer commandBuffer, VkImage srcImage,
2309 VkImageLayout srcImageLayout, VkImage dstImage,
2310 VkImageLayout dstImageLayout, uint32_t regionCount,
2311 const VkImageBlit *pRegions, VkFilter filter) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002312 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002313
Dave Houltonf5217612018-02-02 16:18:52 -07002314 VkImageAspectFlags legal_aspect_flags =
2315 VK_IMAGE_ASPECT_COLOR_BIT | VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT | VK_IMAGE_ASPECT_METADATA_BIT;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002316 if (device_extensions.vk_khr_sampler_ycbcr_conversion) {
Dave Houltonf5217612018-02-02 16:18:52 -07002317 legal_aspect_flags |= (VK_IMAGE_ASPECT_PLANE_0_BIT_KHR | VK_IMAGE_ASPECT_PLANE_1_BIT_KHR | VK_IMAGE_ASPECT_PLANE_2_BIT_KHR);
2318 }
2319
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002320 if (pRegions != nullptr) {
Dave Houltonf5217612018-02-02 16:18:52 -07002321 if ((pRegions->srcSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002322 skip |= log_msg(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002323 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002324 kVUID_PVError_UnrecognizedValue,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002325 "vkCmdBlitImage() parameter, VkImageAspect pRegions->srcSubresource.aspectMask, is an unrecognized enumerator");
2326 }
Dave Houltonf5217612018-02-02 16:18:52 -07002327 if ((pRegions->dstSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002328 skip |= log_msg(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002329 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002330 kVUID_PVError_UnrecognizedValue,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002331 "vkCmdBlitImage() parameter, VkImageAspect pRegions->dstSubresource.aspectMask, is an unrecognized enumerator");
2332 }
2333 }
2334 return skip;
2335}
2336
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002337bool StatelessValidation::manual_PreCallValidateCmdCopyBufferToImage(VkCommandBuffer commandBuffer, VkBuffer srcBuffer,
2338 VkImage dstImage, VkImageLayout dstImageLayout,
2339 uint32_t regionCount, const VkBufferImageCopy *pRegions) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002340 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002341
Dave Houltonf5217612018-02-02 16:18:52 -07002342 VkImageAspectFlags legal_aspect_flags =
2343 VK_IMAGE_ASPECT_COLOR_BIT | VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT | VK_IMAGE_ASPECT_METADATA_BIT;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002344 if (device_extensions.vk_khr_sampler_ycbcr_conversion) {
Dave Houltonf5217612018-02-02 16:18:52 -07002345 legal_aspect_flags |= (VK_IMAGE_ASPECT_PLANE_0_BIT_KHR | VK_IMAGE_ASPECT_PLANE_1_BIT_KHR | VK_IMAGE_ASPECT_PLANE_2_BIT_KHR);
2346 }
2347
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002348 if (pRegions != nullptr) {
Dave Houltonf5217612018-02-02 16:18:52 -07002349 if ((pRegions->imageSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002350 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002351 kVUID_PVError_UnrecognizedValue,
Dave Houltona9df0ce2018-02-07 10:51:23 -07002352 "vkCmdCopyBufferToImage() parameter, VkImageAspect pRegions->imageSubresource.aspectMask, is an "
2353 "unrecognized enumerator");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002354 }
2355 }
2356 return skip;
2357}
2358
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002359bool StatelessValidation::manual_PreCallValidateCmdCopyImageToBuffer(VkCommandBuffer commandBuffer, VkImage srcImage,
2360 VkImageLayout srcImageLayout, VkBuffer dstBuffer,
2361 uint32_t regionCount, const VkBufferImageCopy *pRegions) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002362 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002363
Dave Houltonf5217612018-02-02 16:18:52 -07002364 VkImageAspectFlags legal_aspect_flags =
2365 VK_IMAGE_ASPECT_COLOR_BIT | VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT | VK_IMAGE_ASPECT_METADATA_BIT;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002366 if (device_extensions.vk_khr_sampler_ycbcr_conversion) {
Dave Houltonf5217612018-02-02 16:18:52 -07002367 legal_aspect_flags |= (VK_IMAGE_ASPECT_PLANE_0_BIT_KHR | VK_IMAGE_ASPECT_PLANE_1_BIT_KHR | VK_IMAGE_ASPECT_PLANE_2_BIT_KHR);
2368 }
2369
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002370 if (pRegions != nullptr) {
Dave Houltonf5217612018-02-02 16:18:52 -07002371 if ((pRegions->imageSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002372 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002373 kVUID_PVError_UnrecognizedValue,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002374 "vkCmdCopyImageToBuffer parameter, VkImageAspect pRegions->imageSubresource.aspectMask, is an unrecognized "
2375 "enumerator");
2376 }
2377 }
2378 return skip;
2379}
2380
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002381bool StatelessValidation::manual_PreCallValidateCmdUpdateBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer,
2382 VkDeviceSize dstOffset, VkDeviceSize dataSize, const void *pData) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002383 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002384
2385 if (dstOffset & 3) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002386 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002387 "VUID-vkCmdUpdateBuffer-dstOffset-00036",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002388 "vkCmdUpdateBuffer() parameter, VkDeviceSize dstOffset (0x%" PRIxLEAST64 "), is not a multiple of 4.",
2389 dstOffset);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002390 }
2391
2392 if ((dataSize <= 0) || (dataSize > 65536)) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002393 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002394 "VUID-vkCmdUpdateBuffer-dataSize-00037",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002395 "vkCmdUpdateBuffer() parameter, VkDeviceSize dataSize (0x%" PRIxLEAST64
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002396 "), must be greater than zero and less than or equal to 65536.",
2397 dataSize);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002398 } else if (dataSize & 3) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002399 skip |=
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002400 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002401 "VUID-vkCmdUpdateBuffer-dataSize-00038",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002402 "vkCmdUpdateBuffer() parameter, VkDeviceSize dataSize (0x%" PRIxLEAST64 "), is not a multiple of 4.", dataSize);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002403 }
2404 return skip;
2405}
2406
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002407bool StatelessValidation::manual_PreCallValidateCmdFillBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer,
2408 VkDeviceSize dstOffset, VkDeviceSize size, uint32_t data) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002409 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002410
2411 if (dstOffset & 3) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002412 skip |=
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002413 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002414 "VUID-vkCmdFillBuffer-dstOffset-00025",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002415 "vkCmdFillBuffer() parameter, VkDeviceSize dstOffset (0x%" PRIxLEAST64 "), is not a multiple of 4.", dstOffset);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002416 }
2417
2418 if (size != VK_WHOLE_SIZE) {
2419 if (size <= 0) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002420 skip |=
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002421 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002422 "VUID-vkCmdFillBuffer-size-00026",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002423 "vkCmdFillBuffer() parameter, VkDeviceSize size (0x%" PRIxLEAST64 "), must be greater than zero.", size);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002424 } else if (size & 3) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002425 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002426 "VUID-vkCmdFillBuffer-size-00028",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002427 "vkCmdFillBuffer() parameter, VkDeviceSize size (0x%" PRIxLEAST64 "), is not a multiple of 4.", size);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002428 }
2429 }
2430 return skip;
2431}
2432
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002433bool StatelessValidation::manual_PreCallValidateCreateSwapchainKHR(VkDevice device, const VkSwapchainCreateInfoKHR *pCreateInfo,
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002434 const VkAllocationCallbacks *pAllocator,
2435 VkSwapchainKHR *pSwapchain) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002436 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002437
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002438 const LogMiscParams log_misc{VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT, VK_NULL_HANDLE, "vkCreateSwapchainKHR"};
Petr Krause5c37652018-01-05 04:05:12 +01002439
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002440 if (pCreateInfo != nullptr) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002441 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
2442 if (pCreateInfo->imageSharingMode == VK_SHARING_MODE_CONCURRENT) {
2443 // If imageSharingMode is VK_SHARING_MODE_CONCURRENT, queueFamilyIndexCount must be greater than 1
2444 if (pCreateInfo->queueFamilyIndexCount <= 1) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002445 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002446 "VUID-VkSwapchainCreateInfoKHR-imageSharingMode-01278",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002447 "vkCreateSwapchainKHR(): if pCreateInfo->imageSharingMode is VK_SHARING_MODE_CONCURRENT, "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002448 "pCreateInfo->queueFamilyIndexCount must be greater than 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002449 }
2450
2451 // If imageSharingMode is VK_SHARING_MODE_CONCURRENT, pQueueFamilyIndices must be a pointer to an array of
2452 // queueFamilyIndexCount uint32_t values
2453 if (pCreateInfo->pQueueFamilyIndices == nullptr) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002454 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002455 "VUID-VkSwapchainCreateInfoKHR-imageSharingMode-01277",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002456 "vkCreateSwapchainKHR(): if pCreateInfo->imageSharingMode is VK_SHARING_MODE_CONCURRENT, "
2457 "pCreateInfo->pQueueFamilyIndices must be a pointer to an array of "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002458 "pCreateInfo->queueFamilyIndexCount uint32_t values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002459 }
2460 }
2461
Dave Houlton413a6782018-05-22 13:01:54 -06002462 skip |= ValidateGreaterThanZero(pCreateInfo->imageArrayLayers, "pCreateInfo->imageArrayLayers",
2463 "VUID-VkSwapchainCreateInfoKHR-imageArrayLayers-01275", log_misc);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002464 }
2465
2466 return skip;
2467}
2468
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002469bool StatelessValidation::manual_PreCallValidateQueuePresentKHR(VkQueue queue, const VkPresentInfoKHR *pPresentInfo) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002470 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002471
2472 if (pPresentInfo && pPresentInfo->pNext) {
John Zulaufde972ac2017-10-26 12:07:05 -06002473 const auto *present_regions = lvl_find_in_chain<VkPresentRegionsKHR>(pPresentInfo->pNext);
2474 if (present_regions) {
2475 // TODO: This and all other pNext extension dependencies should be added to code-generation
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002476 skip |= require_device_extension(device_extensions.vk_khr_incremental_present, "vkQueuePresentKHR",
John Zulaufde972ac2017-10-26 12:07:05 -06002477 VK_KHR_INCREMENTAL_PRESENT_EXTENSION_NAME);
2478 if (present_regions->swapchainCount != pPresentInfo->swapchainCount) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002479 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002480 kVUID_PVError_InvalidUsage,
Dave Houltona9df0ce2018-02-07 10:51:23 -07002481 "QueuePresentKHR(): pPresentInfo->swapchainCount has a value of %i but VkPresentRegionsKHR "
2482 "extension swapchainCount is %i. These values must be equal.",
John Zulaufde972ac2017-10-26 12:07:05 -06002483 pPresentInfo->swapchainCount, present_regions->swapchainCount);
2484 }
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002485 skip |= validate_struct_pnext("QueuePresentKHR", "pCreateInfo->pNext->pNext", NULL, present_regions->pNext, 0, NULL,
2486 GeneratedVulkanHeaderVersion, "VUID-VkPresentInfoKHR-pNext-pNext");
2487 skip |= validate_array("QueuePresentKHR", "pCreateInfo->pNext->swapchainCount", "pCreateInfo->pNext->pRegions",
2488 present_regions->swapchainCount, &present_regions->pRegions, true, false, kVUIDUndefined,
2489 kVUIDUndefined);
John Zulaufde972ac2017-10-26 12:07:05 -06002490 for (uint32_t i = 0; i < present_regions->swapchainCount; ++i) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002491 skip |= validate_array("QueuePresentKHR", "pCreateInfo->pNext->pRegions[].rectangleCount",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002492 "pCreateInfo->pNext->pRegions[].pRectangles", present_regions->pRegions[i].rectangleCount,
Dave Houlton413a6782018-05-22 13:01:54 -06002493 &present_regions->pRegions[i].pRectangles, true, false, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002494 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002495 }
2496 }
2497
2498 return skip;
2499}
2500
2501#ifdef VK_USE_PLATFORM_WIN32_KHR
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002502bool StatelessValidation::manual_PreCallValidateCreateWin32SurfaceKHR(VkInstance instance,
2503 const VkWin32SurfaceCreateInfoKHR *pCreateInfo,
2504 const VkAllocationCallbacks *pAllocator,
2505 VkSurfaceKHR *pSurface) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002506 bool skip = false;
2507
2508 if (pCreateInfo->hwnd == nullptr) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002509 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002510 "VUID-VkWin32SurfaceCreateInfoKHR-hwnd-01308",
2511 "vkCreateWin32SurfaceKHR(): hwnd must be a valid Win32 HWND but hwnd is NULL.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002512 }
2513
2514 return skip;
2515}
2516#endif // VK_USE_PLATFORM_WIN32_KHR
2517
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002518bool StatelessValidation::manual_PreCallValidateDebugMarkerSetObjectNameEXT(VkDevice device,
2519 const VkDebugMarkerObjectNameInfoEXT *pNameInfo) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002520 if (pNameInfo->pObjectName) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002521 report_data->debugObjectNameMap->insert(
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002522 std::make_pair<uint64_t, std::string>((uint64_t &&) pNameInfo->object, pNameInfo->pObjectName));
2523 } else {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002524 report_data->debugObjectNameMap->erase(pNameInfo->object);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002525 }
2526 return false;
2527}
2528
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002529bool StatelessValidation::manual_PreCallValidateCreateDescriptorPool(VkDevice device, const VkDescriptorPoolCreateInfo *pCreateInfo,
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002530 const VkAllocationCallbacks *pAllocator,
2531 VkDescriptorPool *pDescriptorPool) {
Petr Krausc8655be2017-09-27 18:56:51 +02002532 bool skip = false;
2533
2534 if (pCreateInfo) {
2535 if (pCreateInfo->maxSets <= 0) {
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002536 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT,
2537 VK_NULL_HANDLE, "VUID-VkDescriptorPoolCreateInfo-maxSets-00301",
2538 "vkCreateDescriptorPool(): pCreateInfo->maxSets is not greater than 0.");
Petr Krausc8655be2017-09-27 18:56:51 +02002539 }
2540
2541 if (pCreateInfo->pPoolSizes) {
2542 for (uint32_t i = 0; i < pCreateInfo->poolSizeCount; ++i) {
2543 if (pCreateInfo->pPoolSizes[i].descriptorCount <= 0) {
2544 skip |= log_msg(
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002545 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, VK_NULL_HANDLE,
2546 "VUID-VkDescriptorPoolSize-descriptorCount-00302",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002547 "vkCreateDescriptorPool(): pCreateInfo->pPoolSizes[%" PRIu32 "].descriptorCount is not greater than 0.", i);
Petr Krausc8655be2017-09-27 18:56:51 +02002548 }
Jeff Bolze54ae892018-09-08 12:16:29 -05002549 if (pCreateInfo->pPoolSizes[i].type == VK_DESCRIPTOR_TYPE_INLINE_UNIFORM_BLOCK_EXT &&
2550 (pCreateInfo->pPoolSizes[i].descriptorCount % 4) != 0) {
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002551 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT,
2552 VK_NULL_HANDLE, "VUID-VkDescriptorPoolSize-type-02218",
Dave Houlton142c4cb2018-10-17 15:04:41 -06002553 "vkCreateDescriptorPool(): pCreateInfo->pPoolSizes[%" PRIu32
2554 "].type is VK_DESCRIPTOR_TYPE_INLINE_UNIFORM_BLOCK_EXT "
2555 " and pCreateInfo->pPoolSizes[%" PRIu32 "].descriptorCount is not a multiple of 4.",
2556 i, i);
Jeff Bolze54ae892018-09-08 12:16:29 -05002557 }
Petr Krausc8655be2017-09-27 18:56:51 +02002558 }
2559 }
2560 }
2561
2562 return skip;
2563}
2564
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002565bool StatelessValidation::manual_PreCallValidateCmdDispatch(VkCommandBuffer commandBuffer, uint32_t groupCountX,
2566 uint32_t groupCountY, uint32_t groupCountZ) {
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07002567 bool skip = false;
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07002568
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002569 if (groupCountX > device_limits.maxComputeWorkGroupCount[0]) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002570 skip |=
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002571 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002572 HandleToUint64(commandBuffer), "VUID-vkCmdDispatch-groupCountX-00386",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002573 "vkCmdDispatch(): groupCountX (%" PRIu32 ") exceeds device limit maxComputeWorkGroupCount[0] (%" PRIu32 ").",
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002574 groupCountX, device_limits.maxComputeWorkGroupCount[0]);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07002575 }
2576
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002577 if (groupCountY > device_limits.maxComputeWorkGroupCount[1]) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002578 skip |=
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002579 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002580 HandleToUint64(commandBuffer), "VUID-vkCmdDispatch-groupCountY-00387",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002581 "vkCmdDispatch(): groupCountY (%" PRIu32 ") exceeds device limit maxComputeWorkGroupCount[1] (%" PRIu32 ").",
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002582 groupCountY, device_limits.maxComputeWorkGroupCount[1]);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07002583 }
2584
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002585 if (groupCountZ > device_limits.maxComputeWorkGroupCount[2]) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002586 skip |=
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002587 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002588 HandleToUint64(commandBuffer), "VUID-vkCmdDispatch-groupCountZ-00388",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002589 "vkCmdDispatch(): groupCountZ (%" PRIu32 ") exceeds device limit maxComputeWorkGroupCount[2] (%" PRIu32 ").",
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002590 groupCountZ, device_limits.maxComputeWorkGroupCount[2]);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07002591 }
2592
2593 return skip;
2594}
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002595
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002596bool StatelessValidation::manual_PreCallValidateCmdDispatchIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer,
2597 VkDeviceSize offset) {
John Zulaufa999d1b2018-11-29 13:38:40 -07002598 bool skip = false;
John Zulaufa999d1b2018-11-29 13:38:40 -07002599
2600 if ((offset % 4) != 0) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002601 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
John Zulaufa999d1b2018-11-29 13:38:40 -07002602 HandleToUint64(commandBuffer), "VUID-vkCmdDispatchIndirect-offset-00406",
2603 "vkCmdDispatchIndirect(): offset (%" PRIu64 ") must be a multiple of 4.", offset);
2604 }
2605 return skip;
2606}
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07002607
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002608bool StatelessValidation::manual_PreCallValidateCmdDispatchBaseKHR(VkCommandBuffer commandBuffer, uint32_t baseGroupX,
2609 uint32_t baseGroupY, uint32_t baseGroupZ, uint32_t groupCountX,
2610 uint32_t groupCountY, uint32_t groupCountZ) {
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07002611 bool skip = false;
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07002612
2613 // Paired if {} else if {} tests used to avoid any possible uint underflow
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002614 uint32_t limit = device_limits.maxComputeWorkGroupCount[0];
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07002615 if (baseGroupX >= limit) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002616 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002617 HandleToUint64(commandBuffer), "VUID-vkCmdDispatchBase-baseGroupX-00421",
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07002618 "vkCmdDispatch(): baseGroupX (%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002619 ") equals or exceeds device limit maxComputeWorkGroupCount[0] (%" PRIu32 ").",
2620 baseGroupX, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07002621 } else if (groupCountX > (limit - baseGroupX)) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002622 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002623 HandleToUint64(commandBuffer), "VUID-vkCmdDispatchBase-groupCountX-00424",
Mark Lobodzinskibf973a12018-03-01 08:50:21 -07002624 "vkCmdDispatchBaseKHR(): baseGroupX (%" PRIu32 ") + groupCountX (%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002625 ") exceeds device limit maxComputeWorkGroupCount[0] (%" PRIu32 ").",
2626 baseGroupX, groupCountX, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07002627 }
2628
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002629 limit = device_limits.maxComputeWorkGroupCount[1];
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07002630 if (baseGroupY >= limit) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002631 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002632 HandleToUint64(commandBuffer), "VUID-vkCmdDispatchBase-baseGroupX-00422",
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07002633 "vkCmdDispatch(): baseGroupY (%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002634 ") equals or exceeds device limit maxComputeWorkGroupCount[1] (%" PRIu32 ").",
2635 baseGroupY, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07002636 } else if (groupCountY > (limit - baseGroupY)) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002637 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002638 HandleToUint64(commandBuffer), "VUID-vkCmdDispatchBase-groupCountY-00425",
Mark Lobodzinskibf973a12018-03-01 08:50:21 -07002639 "vkCmdDispatchBaseKHR(): baseGroupY (%" PRIu32 ") + groupCountY (%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002640 ") exceeds device limit maxComputeWorkGroupCount[1] (%" PRIu32 ").",
2641 baseGroupY, groupCountY, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07002642 }
2643
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002644 limit = device_limits.maxComputeWorkGroupCount[2];
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07002645 if (baseGroupZ >= limit) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002646 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002647 HandleToUint64(commandBuffer), "VUID-vkCmdDispatchBase-baseGroupZ-00423",
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07002648 "vkCmdDispatch(): baseGroupZ (%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002649 ") equals or exceeds device limit maxComputeWorkGroupCount[2] (%" PRIu32 ").",
2650 baseGroupZ, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07002651 } else if (groupCountZ > (limit - baseGroupZ)) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002652 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002653 HandleToUint64(commandBuffer), "VUID-vkCmdDispatchBase-groupCountZ-00426",
Mark Lobodzinskibf973a12018-03-01 08:50:21 -07002654 "vkCmdDispatchBaseKHR(): baseGroupZ (%" PRIu32 ") + groupCountZ (%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002655 ") exceeds device limit maxComputeWorkGroupCount[2] (%" PRIu32 ").",
2656 baseGroupZ, groupCountZ, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07002657 }
2658
2659 return skip;
2660}
2661
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002662bool StatelessValidation::manual_PreCallValidateCmdSetExclusiveScissorNV(VkCommandBuffer commandBuffer,
2663 uint32_t firstExclusiveScissor,
2664 uint32_t exclusiveScissorCount,
2665 const VkRect2D *pExclusiveScissors) {
Jeff Bolz3e71f782018-08-29 23:15:45 -05002666 bool skip = false;
2667
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002668 if (!physical_device_features.multiViewport) {
Jeff Bolz3e71f782018-08-29 23:15:45 -05002669 if (firstExclusiveScissor != 0) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06002670 skip |=
2671 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
2672 HandleToUint64(commandBuffer), "VUID-vkCmdSetExclusiveScissorNV-firstExclusiveScissor-02035",
2673 "vkCmdSetExclusiveScissorNV: The multiViewport feature is disabled, but firstExclusiveScissor (=%" PRIu32
2674 ") is not 0.",
2675 firstExclusiveScissor);
Jeff Bolz3e71f782018-08-29 23:15:45 -05002676 }
2677 if (exclusiveScissorCount > 1) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06002678 skip |=
2679 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
2680 HandleToUint64(commandBuffer), "VUID-vkCmdSetExclusiveScissorNV-exclusiveScissorCount-02036",
2681 "vkCmdSetExclusiveScissorNV: The multiViewport feature is disabled, but exclusiveScissorCount (=%" PRIu32
2682 ") is not 1.",
2683 exclusiveScissorCount);
Jeff Bolz3e71f782018-08-29 23:15:45 -05002684 }
2685 } else { // multiViewport enabled
2686 const uint64_t sum = static_cast<uint64_t>(firstExclusiveScissor) + static_cast<uint64_t>(exclusiveScissorCount);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002687 if (sum > device_limits.maxViewports) {
2688 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Jeff Bolz3e71f782018-08-29 23:15:45 -05002689 HandleToUint64(commandBuffer), "VUID-vkCmdSetExclusiveScissorNV-firstExclusiveScissor-02034",
Dave Houlton142c4cb2018-10-17 15:04:41 -06002690 "vkCmdSetExclusiveScissorNV: firstExclusiveScissor + exclusiveScissorCount (=%" PRIu32 " + %" PRIu32
2691 " = %" PRIu64 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002692 firstExclusiveScissor, exclusiveScissorCount, sum, device_limits.maxViewports);
Jeff Bolz3e71f782018-08-29 23:15:45 -05002693 }
2694 }
2695
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002696 if (firstExclusiveScissor >= device_limits.maxViewports) {
Jeff Bolz3e71f782018-08-29 23:15:45 -05002697 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
2698 HandleToUint64(commandBuffer), "VUID-vkCmdSetExclusiveScissorNV-firstExclusiveScissor-02033",
Dave Houlton142c4cb2018-10-17 15:04:41 -06002699 "vkCmdSetExclusiveScissorNV: firstExclusiveScissor (=%" PRIu32 ") must be less than maxViewports (=%" PRIu32
2700 ").",
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002701 firstExclusiveScissor, device_limits.maxViewports);
Jeff Bolz3e71f782018-08-29 23:15:45 -05002702 }
2703
2704 if (pExclusiveScissors) {
2705 for (uint32_t scissor_i = 0; scissor_i < exclusiveScissorCount; ++scissor_i) {
2706 const auto &scissor = pExclusiveScissors[scissor_i]; // will crash on invalid ptr
2707
2708 if (scissor.offset.x < 0) {
2709 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
2710 HandleToUint64(commandBuffer), "VUID-vkCmdSetExclusiveScissorNV-x-02037",
Dave Houlton142c4cb2018-10-17 15:04:41 -06002711 "vkCmdSetExclusiveScissorNV: pScissors[%" PRIu32 "].offset.x (=%" PRIi32 ") is negative.",
2712 scissor_i, scissor.offset.x);
Jeff Bolz3e71f782018-08-29 23:15:45 -05002713 }
2714
2715 if (scissor.offset.y < 0) {
2716 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
2717 HandleToUint64(commandBuffer), "VUID-vkCmdSetExclusiveScissorNV-x-02037",
Dave Houlton142c4cb2018-10-17 15:04:41 -06002718 "vkCmdSetExclusiveScissorNV: pScissors[%" PRIu32 "].offset.y (=%" PRIi32 ") is negative.",
2719 scissor_i, scissor.offset.y);
Jeff Bolz3e71f782018-08-29 23:15:45 -05002720 }
2721
2722 const int64_t x_sum = static_cast<int64_t>(scissor.offset.x) + static_cast<int64_t>(scissor.extent.width);
2723 if (x_sum > INT32_MAX) {
2724 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
2725 HandleToUint64(commandBuffer), "VUID-vkCmdSetExclusiveScissorNV-offset-02038",
2726 "vkCmdSetExclusiveScissorNV: offset.x + extent.width (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
2727 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
2728 scissor.offset.x, scissor.extent.width, x_sum, scissor_i);
2729 }
2730
2731 const int64_t y_sum = static_cast<int64_t>(scissor.offset.y) + static_cast<int64_t>(scissor.extent.height);
2732 if (y_sum > INT32_MAX) {
2733 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
2734 HandleToUint64(commandBuffer), "VUID-vkCmdSetExclusiveScissorNV-offset-02039",
2735 "vkCmdSetExclusiveScissorNV: offset.y + extent.height (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
2736 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
2737 scissor.offset.y, scissor.extent.height, y_sum, scissor_i);
2738 }
2739 }
2740 }
2741
2742 return skip;
2743}
2744
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002745bool StatelessValidation::manual_PreCallValidateCmdSetViewportShadingRatePaletteNV(
2746 VkCommandBuffer commandBuffer, uint32_t firstViewport, uint32_t viewportCount,
2747 const VkShadingRatePaletteNV *pShadingRatePalettes) {
Jeff Bolz9af91c52018-09-01 21:53:57 -05002748 bool skip = false;
2749
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002750 if (!physical_device_features.multiViewport) {
Jeff Bolz9af91c52018-09-01 21:53:57 -05002751 if (firstViewport != 0) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06002752 skip |=
2753 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
2754 HandleToUint64(commandBuffer), "VUID-vkCmdSetViewportShadingRatePaletteNV-firstViewport-02068",
2755 "vkCmdSetViewportShadingRatePaletteNV: The multiViewport feature is disabled, but firstViewport (=%" PRIu32
2756 ") is not 0.",
2757 firstViewport);
Jeff Bolz9af91c52018-09-01 21:53:57 -05002758 }
2759 if (viewportCount > 1) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06002760 skip |=
2761 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
2762 HandleToUint64(commandBuffer), "VUID-vkCmdSetViewportShadingRatePaletteNV-viewportCount-02069",
2763 "vkCmdSetViewportShadingRatePaletteNV: The multiViewport feature is disabled, but viewportCount (=%" PRIu32
2764 ") is not 1.",
2765 viewportCount);
Jeff Bolz9af91c52018-09-01 21:53:57 -05002766 }
2767 }
2768
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002769 if (firstViewport >= device_limits.maxViewports) {
Jeff Bolz9af91c52018-09-01 21:53:57 -05002770 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
2771 HandleToUint64(commandBuffer), "VUID-vkCmdSetViewportShadingRatePaletteNV-firstViewport-02066",
Dave Houlton142c4cb2018-10-17 15:04:41 -06002772 "vkCmdSetViewportShadingRatePaletteNV: firstViewport (=%" PRIu32
2773 ") must be less than maxViewports (=%" PRIu32 ").",
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002774 firstViewport, device_limits.maxViewports);
Jeff Bolz9af91c52018-09-01 21:53:57 -05002775 }
2776
2777 const uint64_t sum = static_cast<uint64_t>(firstViewport) + static_cast<uint64_t>(viewportCount);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002778 if (sum > device_limits.maxViewports) {
2779 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Jeff Bolz9af91c52018-09-01 21:53:57 -05002780 HandleToUint64(commandBuffer), "VUID-vkCmdSetViewportShadingRatePaletteNV-firstViewport-02067",
2781 "vkCmdSetViewportShadingRatePaletteNV: firstViewport + viewportCount (=%" PRIu32 " + %" PRIu32 " = %" PRIu64
2782 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002783 firstViewport, viewportCount, sum, device_limits.maxViewports);
Jeff Bolz9af91c52018-09-01 21:53:57 -05002784 }
2785
2786 return skip;
2787}
2788
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002789bool StatelessValidation::manual_PreCallValidateCmdSetCoarseSampleOrderNV(VkCommandBuffer commandBuffer,
2790 VkCoarseSampleOrderTypeNV sampleOrderType,
2791 uint32_t customSampleOrderCount,
2792 const VkCoarseSampleOrderCustomNV *pCustomSampleOrders) {
Jeff Bolz9af91c52018-09-01 21:53:57 -05002793 bool skip = false;
2794
Dave Houlton142c4cb2018-10-17 15:04:41 -06002795 if (sampleOrderType != VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV && customSampleOrderCount != 0) {
Jeff Bolz9af91c52018-09-01 21:53:57 -05002796 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
2797 HandleToUint64(commandBuffer), "VUID-vkCmdSetCoarseSampleOrderNV-sampleOrderType-02081",
2798 "vkCmdSetCoarseSampleOrderNV: If sampleOrderType is not VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV, "
2799 "customSampleOrderCount must be 0.");
2800 }
2801
2802 for (uint32_t order_i = 0; order_i < customSampleOrderCount; ++order_i) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002803 skip |= ValidateCoarseSampleOrderCustomNV(&pCustomSampleOrders[order_i]);
Jeff Bolz9af91c52018-09-01 21:53:57 -05002804 }
2805
2806 return skip;
2807}
2808
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002809bool StatelessValidation::manual_PreCallValidateCmdDrawMeshTasksNV(VkCommandBuffer commandBuffer, uint32_t taskCount,
2810 uint32_t firstTask) {
Jeff Bolz45bf7d62018-09-18 15:39:58 -05002811 bool skip = false;
2812
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002813 if (taskCount > phys_dev_ext_props.mesh_shader_props.maxDrawMeshTasksCount) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06002814 skip |= log_msg(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002815 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton142c4cb2018-10-17 15:04:41 -06002816 HandleToUint64(commandBuffer), "VUID-vkCmdDrawMeshTasksNV-taskCount-02119",
2817 "vkCmdDrawMeshTasksNV() parameter, uint32_t taskCount (0x%" PRIxLEAST32
2818 "), must be less than or equal to VkPhysicalDeviceMeshShaderPropertiesNV::maxDrawMeshTasksCount (0x%" PRIxLEAST32 ").",
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002819 taskCount, phys_dev_ext_props.mesh_shader_props.maxDrawMeshTasksCount);
Jeff Bolz45bf7d62018-09-18 15:39:58 -05002820 }
2821
2822 return skip;
2823}
2824
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002825bool StatelessValidation::manual_PreCallValidateCmdDrawMeshTasksIndirectNV(VkCommandBuffer commandBuffer, VkBuffer buffer,
2826 VkDeviceSize offset, uint32_t drawCount,
2827 uint32_t stride) {
Jeff Bolz45bf7d62018-09-18 15:39:58 -05002828 bool skip = false;
2829
Jeff Bolz45bf7d62018-09-18 15:39:58 -05002830 if (offset & 3) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06002831 skip |= log_msg(
2832 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
2833 HandleToUint64(commandBuffer), "VUID-vkCmdDrawMeshTasksIndirectNV-offset-02145",
2834 "vkCmdDrawMeshTasksIndirectNV() parameter, VkDeviceSize offset (0x%" PRIxLEAST64 "), is not a multiple of 4.", offset);
Jeff Bolz45bf7d62018-09-18 15:39:58 -05002835 }
2836
2837 if (drawCount > 1 && ((stride & 3) || stride < sizeof(VkDrawMeshTasksIndirectCommandNV))) {
2838 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
2839 HandleToUint64(commandBuffer), "VUID-vkCmdDrawMeshTasksIndirectNV-drawCount-02146",
2840 "vkCmdDrawMeshTasksIndirectNV() parameter, uint32_t stride (0x%" PRIxLEAST32
2841 "), is not a multiple of 4 or smaller than sizeof (VkDrawMeshTasksIndirectCommandNV).",
2842 stride);
2843 }
2844
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002845 if (!physical_device_features.multiDrawIndirect && ((drawCount > 1))) {
Jeff Bolzb574c342018-11-08 15:36:57 -06002846 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
2847 HandleToUint64(commandBuffer), "VUID-vkCmdDrawMeshTasksIndirectNV-drawCount-02147",
2848 "vkCmdDrawMeshTasksIndirectNV(): Device feature multiDrawIndirect disabled: count must be 0 or 1 but is %d",
2849 drawCount);
2850 }
2851
Jeff Bolz45bf7d62018-09-18 15:39:58 -05002852 return skip;
2853}
2854
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002855bool StatelessValidation::manual_PreCallValidateCmdDrawMeshTasksIndirectCountNV(VkCommandBuffer commandBuffer, VkBuffer buffer,
2856 VkDeviceSize offset, VkBuffer countBuffer,
2857 VkDeviceSize countBufferOffset,
2858 uint32_t maxDrawCount, uint32_t stride) {
Jeff Bolz45bf7d62018-09-18 15:39:58 -05002859 bool skip = false;
2860
Jeff Bolz45bf7d62018-09-18 15:39:58 -05002861 if (offset & 3) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002862 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Jeff Bolz45bf7d62018-09-18 15:39:58 -05002863 HandleToUint64(commandBuffer), "VUID-vkCmdDrawMeshTasksIndirectCountNV-offset-02180",
2864 "vkCmdDrawMeshTasksIndirectCountNV() parameter, VkDeviceSize offset (0x%" PRIxLEAST64
2865 "), is not a multiple of 4.",
2866 offset);
2867 }
2868
2869 if (countBufferOffset & 3) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002870 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Jeff Bolz45bf7d62018-09-18 15:39:58 -05002871 HandleToUint64(commandBuffer), "VUID-vkCmdDrawMeshTasksIndirectCountNV-countBufferOffset-02181",
2872 "vkCmdDrawMeshTasksIndirectCountNV() parameter, VkDeviceSize countBufferOffset (0x%" PRIxLEAST64
2873 "), is not a multiple of 4.",
2874 countBufferOffset);
2875 }
2876
2877 if ((stride & 3) || stride < sizeof(VkDrawMeshTasksIndirectCommandNV)) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002878 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Jeff Bolz45bf7d62018-09-18 15:39:58 -05002879 HandleToUint64(commandBuffer), "VUID-vkCmdDrawMeshTasksIndirectCountNV-stride-02182",
2880 "vkCmdDrawMeshTasksIndirectCountNV() parameter, uint32_t stride (0x%" PRIxLEAST32
2881 "), is not a multiple of 4 or smaller than sizeof (VkDrawMeshTasksIndirectCommandNV).",
2882 stride);
2883 }
2884
2885 return skip;
2886}
2887
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002888bool StatelessValidation::manual_PreCallValidateCreateQueryPool(VkDevice device, const VkQueryPoolCreateInfo *pCreateInfo,
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002889 const VkAllocationCallbacks *pAllocator, VkQueryPool *pQueryPool) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002890 bool skip = false;
2891
2892 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
2893 if (pCreateInfo != nullptr) {
2894 // If queryType is VK_QUERY_TYPE_PIPELINE_STATISTICS, pipelineStatistics must be a valid combination of
2895 // VkQueryPipelineStatisticFlagBits values
2896 if ((pCreateInfo->queryType == VK_QUERY_TYPE_PIPELINE_STATISTICS) && (pCreateInfo->pipelineStatistics != 0) &&
2897 ((pCreateInfo->pipelineStatistics & (~AllVkQueryPipelineStatisticFlagBits)) != 0)) {
2898 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
2899 "VUID-VkQueryPoolCreateInfo-queryType-00792",
2900 "vkCreateQueryPool(): if pCreateInfo->queryType is VK_QUERY_TYPE_PIPELINE_STATISTICS, "
2901 "pCreateInfo->pipelineStatistics must be a valid combination of VkQueryPipelineStatisticFlagBits "
2902 "values.");
2903 }
Mark Lobodzinskib7a26382018-07-02 13:14:26 -06002904 }
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002905 return skip;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002906}
2907
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002908bool StatelessValidation::manual_PreCallValidateEnumerateDeviceExtensionProperties(VkPhysicalDevice physicalDevice,
2909 const char *pLayerName, uint32_t *pPropertyCount,
2910 VkExtensionProperties *pProperties) {
2911 return validate_array("vkEnumerateDeviceExtensionProperties", "pPropertyCount", "pProperties", pPropertyCount, &pProperties,
2912 true, false, false, kVUIDUndefined, "VUID-vkEnumerateDeviceExtensionProperties-pProperties-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002913}
2914
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002915void StatelessValidation::PostCallRecordCreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo,
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -07002916 const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass,
2917 VkResult result) {
2918 if (result != VK_SUCCESS) return;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002919 RecordRenderPass(*pRenderPass, pCreateInfo);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002920}
2921
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002922void StatelessValidation::PostCallRecordCreateRenderPass2KHR(VkDevice device, const VkRenderPassCreateInfo2KHR *pCreateInfo,
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -07002923 const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass,
2924 VkResult result) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002925 // Track the state necessary for checking vkCreateGraphicsPipeline (subpass usage of depth and color attachments)
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -07002926 if (result != VK_SUCCESS) return;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002927 RecordRenderPass(*pRenderPass, pCreateInfo);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002928}
2929
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002930void StatelessValidation::PostCallRecordDestroyRenderPass(VkDevice device, VkRenderPass renderPass,
2931 const VkAllocationCallbacks *pAllocator) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002932 // Track the state necessary for checking vkCreateGraphicsPipeline (subpass usage of depth and color attachments)
Mark Lobodzinskif27a6bc2019-02-04 13:00:49 -07002933 std::unique_lock<std::mutex> lock(renderpass_map_mutex);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002934 renderpasses_states.erase(renderPass);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002935}
Jeff Bolz7e7e6e02019-01-11 22:53:41 -06002936
2937bool StatelessValidation::manual_PreCallValidateAllocateMemory(VkDevice device, const VkMemoryAllocateInfo *pAllocateInfo,
2938 const VkAllocationCallbacks *pAllocator, VkDeviceMemory *pMemory) {
2939 bool skip = false;
2940
2941 if (pAllocateInfo) {
2942 auto chained_prio_struct = lvl_find_in_chain<VkMemoryPriorityAllocateInfoEXT>(pAllocateInfo->pNext);
2943 if (chained_prio_struct && (chained_prio_struct->priority < 0.0f || chained_prio_struct->priority > 1.0f)) {
2944 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
2945 "VUID-VkMemoryPriorityAllocateInfoEXT-priority-02602",
2946 "priority (=%f) must be between `0` and `1`, inclusive.", chained_prio_struct->priority);
2947 }
2948 }
2949 return skip;
2950}