blob: 6691363989f94b6a5f188d6c4d9b4a2e36c7d178 [file] [log] [blame]
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001/* Copyright (c) 2015-2017 The Khronos Group Inc.
2 * Copyright (c) 2015-2017 Valve Corporation
3 * Copyright (c) 2015-2017 LunarG, Inc.
4 * Copyright (C) 2015-2017 Google Inc.
5 *
6 * Licensed under the Apache License, Version 2.0 (the "License");
7 * you may not use this file except in compliance with the License.
8 * You may obtain a copy of the License at
9 *
10 * http://www.apache.org/licenses/LICENSE-2.0
11 *
12 * Unless required by applicable law or agreed to in writing, software
13 * distributed under the License is distributed on an "AS IS" BASIS,
14 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15 * See the License for the specific language governing permissions and
16 * limitations under the License.
17 *
18 * Author: Mark Lobodzinski <mark@LunarG.com>
19 */
20
21#define NOMINMAX
John Zulauf0fe5bfe2018-05-23 09:36:00 -060022#define VALIDATION_ERROR_MAP_IMPL
Mark Lobodzinskid4950072017-08-01 13:02:20 -060023
24#include <limits.h>
25#include <math.h>
26#include <stdio.h>
27#include <stdlib.h>
28#include <string.h>
Mark Lobodzinskid4950072017-08-01 13:02:20 -060029
30#include <iostream>
31#include <string>
32#include <sstream>
33#include <unordered_map>
34#include <unordered_set>
35#include <vector>
36#include <mutex>
37
38#include "vk_loader_platform.h"
39#include "vulkan/vk_layer.h"
40#include "vk_layer_config.h"
41#include "vk_dispatch_table_helper.h"
John Zulaufde972ac2017-10-26 12:07:05 -060042#include "vk_typemap_helper.h"
Mark Lobodzinskid4950072017-08-01 13:02:20 -060043
Mark Lobodzinskid4950072017-08-01 13:02:20 -060044#include "vk_layer_data.h"
45#include "vk_layer_logging.h"
46#include "vk_layer_extension_utils.h"
47#include "vk_layer_utils.h"
Lenny Komow4c0da772018-07-03 10:17:21 -060048#include "vk_layer_dispatch_table.h"
Mark Lobodzinskid4950072017-08-01 13:02:20 -060049
50#include "parameter_name.h"
51#include "parameter_validation.h"
52
Mark Lobodzinskibfb7ab92017-10-27 13:22:23 -060053#if defined __ANDROID__
54#include <android/log.h>
Mark Lobodzinski88529492018-04-01 10:38:15 -060055#define LOGCONSOLE(...) ((void)__android_log_print(ANDROID_LOG_INFO, "PARAMETER_VALIDATION", __VA_ARGS__))
Mark Lobodzinskibfb7ab92017-10-27 13:22:23 -060056#else
57#define LOGCONSOLE(...) \
58 { \
59 printf(__VA_ARGS__); \
60 printf("\n"); \
61 }
62#endif
63
Mark Lobodzinskid4950072017-08-01 13:02:20 -060064namespace parameter_validation {
65
Mark Lobodzinski78a12a92017-08-08 14:16:51 -060066extern std::unordered_map<std::string, void *> custom_functions;
67
Mark Lobodzinskid4950072017-08-01 13:02:20 -060068extern bool parameter_validation_vkCreateInstance(VkInstance instance, const VkInstanceCreateInfo *pCreateInfo,
69 const VkAllocationCallbacks *pAllocator, VkInstance *pInstance);
70extern bool parameter_validation_vkDestroyInstance(VkInstance instance, const VkAllocationCallbacks *pAllocator);
71extern bool parameter_validation_vkCreateDevice(VkPhysicalDevice physicalDevice, const VkDeviceCreateInfo *pCreateInfo,
72 const VkAllocationCallbacks *pAllocator, VkDevice *pDevice);
73extern bool parameter_validation_vkDestroyDevice(VkDevice device, const VkAllocationCallbacks *pAllocator);
74extern bool parameter_validation_vkCreateQueryPool(VkDevice device, const VkQueryPoolCreateInfo *pCreateInfo,
75 const VkAllocationCallbacks *pAllocator, VkQueryPool *pQueryPool);
76extern bool parameter_validation_vkCreateDebugReportCallbackEXT(VkInstance instance,
77 const VkDebugReportCallbackCreateInfoEXT *pCreateInfo,
78 const VkAllocationCallbacks *pAllocator,
79 VkDebugReportCallbackEXT *pMsgCallback);
80extern bool parameter_validation_vkDestroyDebugReportCallbackEXT(VkInstance instance, VkDebugReportCallbackEXT msgCallback,
81 const VkAllocationCallbacks *pAllocator);
Mark Young6ba8abe2017-11-09 10:37:04 -070082extern bool parameter_validation_vkCreateDebugUtilsMessengerEXT(VkInstance instance,
83 const VkDebugUtilsMessengerCreateInfoEXT *pCreateInfo,
84 const VkAllocationCallbacks *pAllocator,
85 VkDebugUtilsMessengerEXT *pMessenger);
86extern bool parameter_validation_vkDestroyDebugUtilsMessengerEXT(VkInstance instance, VkDebugUtilsMessengerEXT messenger,
87 const VkAllocationCallbacks *pAllocator);
Mark Lobodzinskid4950072017-08-01 13:02:20 -060088extern bool parameter_validation_vkCreateCommandPool(VkDevice device, const VkCommandPoolCreateInfo *pCreateInfo,
89 const VkAllocationCallbacks *pAllocator, VkCommandPool *pCommandPool);
Petr Krause91f7a12017-12-14 20:57:36 +010090extern bool parameter_validation_vkCreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo,
91 const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass);
92extern bool parameter_validation_vkDestroyRenderPass(VkDevice device, VkRenderPass renderPass,
93 const VkAllocationCallbacks *pAllocator);
Mark Lobodzinskid4950072017-08-01 13:02:20 -060094
95// TODO : This can be much smarter, using separate locks for separate global data
96std::mutex global_lock;
97
98static uint32_t loader_layer_if_version = CURRENT_LOADER_LAYER_INTERFACE_VERSION;
99std::unordered_map<void *, layer_data *> layer_data_map;
100std::unordered_map<void *, instance_layer_data *> instance_layer_data_map;
101
102void InitializeManualParameterValidationFunctionPointers(void);
103
104static void init_parameter_validation(instance_layer_data *instance_data, const VkAllocationCallbacks *pAllocator) {
Mark Young6ba8abe2017-11-09 10:37:04 -0700105 layer_debug_report_actions(instance_data->report_data, instance_data->logging_callback, pAllocator,
106 "lunarg_parameter_validation");
107 layer_debug_messenger_actions(instance_data->report_data, instance_data->logging_messenger, pAllocator,
108 "lunarg_parameter_validation");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600109}
110
Mark Young6ba8abe2017-11-09 10:37:04 -0700111static const VkExtensionProperties instance_extensions[] = {{VK_EXT_DEBUG_REPORT_EXTENSION_NAME, VK_EXT_DEBUG_REPORT_SPEC_VERSION},
112 {VK_EXT_DEBUG_UTILS_EXTENSION_NAME, VK_EXT_DEBUG_UTILS_SPEC_VERSION}};
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600113
114static const VkLayerProperties global_layer = {
Dave Houltonb3bbec72018-01-17 10:13:33 -0700115 "VK_LAYER_LUNARG_parameter_validation",
116 VK_LAYER_API_VERSION,
117 1,
118 "LunarG Validation Layer",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600119};
120
121static const int MaxParamCheckerStringLength = 256;
122
John Zulauf71968502017-10-26 13:51:15 -0600123template <typename T>
124static inline bool in_inclusive_range(const T &value, const T &min, const T &max) {
125 // Using only < for generality and || for early abort
126 return !((value < min) || (max < value));
127}
128
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600129static bool validate_string(debug_report_data *report_data, const char *apiName, const ParameterName &stringName,
Mark Lobodzinskiebee3552018-05-29 09:55:54 -0600130 const std::string &vuid, const char *validateString) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600131 bool skip = false;
132
133 VkStringErrorFlags result = vk_string_validate(MaxParamCheckerStringLength, validateString);
134
135 if (result == VK_STRING_ERROR_NONE) {
136 return skip;
137 } else if (result & VK_STRING_ERROR_LENGTH) {
Mark Lobodzinskiebee3552018-05-29 09:55:54 -0600138 skip = log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, vuid,
139 "%s: string %s exceeds max length %d", apiName, stringName.get_name().c_str(), MaxParamCheckerStringLength);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600140 } else if (result & VK_STRING_ERROR_BAD_DATA) {
Mark Lobodzinskiebee3552018-05-29 09:55:54 -0600141 skip = log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, vuid,
142 "%s: string %s contains invalid characters or is badly formed", apiName, stringName.get_name().c_str());
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600143 }
144 return skip;
145}
146
147static bool ValidateDeviceQueueFamily(layer_data *device_data, uint32_t queue_family, const char *cmd_name,
Dave Houlton13b65502018-05-23 13:35:24 -0600148 const char *parameter_name, const std::string &error_code, bool optional = false) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600149 bool skip = false;
150
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600151 if (!optional && queue_family == VK_QUEUE_FAMILY_IGNORED) {
152 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -0600153 HandleToUint64(device_data->device), error_code,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600154 "%s: %s is VK_QUEUE_FAMILY_IGNORED, but it is required to provide a valid queue family index value.",
155 cmd_name, parameter_name);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600156 } else if (device_data->queueFamilyIndexMap.find(queue_family) == device_data->queueFamilyIndexMap.end()) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600157 skip |=
158 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -0600159 HandleToUint64(device_data->device), error_code,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600160 "%s: %s (= %" PRIu32
161 ") is not one of the queue families given via VkDeviceQueueCreateInfo structures when the device was created.",
162 cmd_name, parameter_name, queue_family);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600163 }
164
165 return skip;
166}
167
168static bool ValidateQueueFamilies(layer_data *device_data, uint32_t queue_family_count, const uint32_t *queue_families,
Dave Houlton13b65502018-05-23 13:35:24 -0600169 const char *cmd_name, const char *array_parameter_name, const std::string &unique_error_code,
170 const std::string &valid_error_code, bool optional = false) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600171 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600172 if (queue_families) {
173 std::unordered_set<uint32_t> set;
174 for (uint32_t i = 0; i < queue_family_count; ++i) {
175 std::string parameter_name = std::string(array_parameter_name) + "[" + std::to_string(i) + "]";
176
177 if (set.count(queue_families[i])) {
178 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -0600179 HandleToUint64(device_data->device), "VUID-VkDeviceCreateInfo-queueFamilyIndex-00372",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600180 "%s: %s (=%" PRIu32 ") is not unique within %s array.", cmd_name, parameter_name.c_str(),
181 queue_families[i], array_parameter_name);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600182 } else {
183 set.insert(queue_families[i]);
184 skip |= ValidateDeviceQueueFamily(device_data, queue_families[i], cmd_name, parameter_name.c_str(),
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600185 valid_error_code, optional);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600186 }
187 }
188 }
189 return skip;
190}
191
John Zulauf620755c2018-04-16 11:00:43 -0600192static bool validate_api_version(const instance_layer_data *instance_data, uint32_t api_version, uint32_t effective_api_version) {
193 bool skip = false;
194 uint32_t api_version_nopatch = VK_MAKE_VERSION(VK_VERSION_MAJOR(api_version), VK_VERSION_MINOR(api_version), 0);
195 if (api_version_nopatch != effective_api_version) {
196 if (api_version_nopatch < VK_API_VERSION_1_0) {
197 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_INSTANCE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -0600198 HandleToUint64(instance_data->instance), kVUIDUndefined,
John Zulauf620755c2018-04-16 11:00:43 -0600199 "Invalid CreateInstance->pCreateInfo->pApplicationInfo.apiVersion number (0x%08x). "
200 "Using VK_API_VERSION_%" PRIu32 "_%" PRIu32 ".",
201 api_version, VK_VERSION_MAJOR(effective_api_version), VK_VERSION_MINOR(effective_api_version));
202 } else {
203 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_INSTANCE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -0600204 HandleToUint64(instance_data->instance), kVUIDUndefined,
John Zulauf620755c2018-04-16 11:00:43 -0600205 "Unrecognized CreateInstance->pCreateInfo->pApplicationInfo.apiVersion number (0x%08x). "
206 "Assuming VK_API_VERSION_%" PRIu32 "_%" PRIu32 ".",
207 api_version, VK_VERSION_MAJOR(effective_api_version), VK_VERSION_MINOR(effective_api_version));
208 }
209 }
210 return skip;
211}
212
213template <typename ExtensionState>
Dave Houlton13b65502018-05-23 13:35:24 -0600214static bool validate_extension_reqs(const instance_layer_data *instance_data, const ExtensionState &extensions,
215 const std::string &vuid, const char *extension_type, const char *extension_name) {
John Zulauf620755c2018-04-16 11:00:43 -0600216 bool skip = false;
217 if (!extension_name) {
218 return skip; // Robust to invalid char *
219 }
220 auto info = ExtensionState::get_info(extension_name);
221
222 if (!info.state) {
223 return skip; // Unknown extensions cannot be checked so report OK
224 }
225
Pat Brown3eddb062018-09-05 14:07:37 -0400226 // Check against the required list in the info
John Zulauf620755c2018-04-16 11:00:43 -0600227 std::vector<const char *> missing;
228 for (const auto &req : info.requires) {
229 if (!(extensions.*(req.enabled))) {
230 missing.push_back(req.name);
231 }
232 }
233
234 // Report any missing requirements
235 if (missing.size()) {
236 std::string missing_joined_list = string_join(", ", missing);
237 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_INSTANCE_EXT,
Pat Brown3eddb062018-09-05 14:07:37 -0400238 HandleToUint64(instance_data->instance), vuid, "Missing extension%s required by the %s extension %s: %s.",
239 ((missing.size() > 1) ? "s" : ""), extension_type, extension_name, missing_joined_list.c_str());
John Zulauf620755c2018-04-16 11:00:43 -0600240 }
241 return skip;
242}
243
244bool validate_instance_extensions(const instance_layer_data *instance_data, const VkInstanceCreateInfo *pCreateInfo) {
245 bool skip = false;
246 for (uint32_t i = 0; i < pCreateInfo->enabledExtensionCount; i++) {
Dave Houlton413a6782018-05-22 13:01:54 -0600247 skip |=
248 validate_extension_reqs(instance_data, instance_data->extensions, "VUID-vkCreateInstance-ppEnabledExtensionNames-01388",
249 "instance", pCreateInfo->ppEnabledExtensionNames[i]);
John Zulauf620755c2018-04-16 11:00:43 -0600250 }
251
252 return skip;
253}
254
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600255VKAPI_ATTR VkResult VKAPI_CALL vkCreateInstance(const VkInstanceCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600256 VkInstance *pInstance) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600257 VkResult result = VK_ERROR_VALIDATION_FAILED_EXT;
258
259 VkLayerInstanceCreateInfo *chain_info = get_chain_info(pCreateInfo, VK_LAYER_LINK_INFO);
260 assert(chain_info != nullptr);
261 assert(chain_info->u.pLayerInfo != nullptr);
262
263 PFN_vkGetInstanceProcAddr fpGetInstanceProcAddr = chain_info->u.pLayerInfo->pfnNextGetInstanceProcAddr;
264 PFN_vkCreateInstance fpCreateInstance = (PFN_vkCreateInstance)fpGetInstanceProcAddr(NULL, "vkCreateInstance");
265 if (fpCreateInstance == NULL) {
266 return VK_ERROR_INITIALIZATION_FAILED;
267 }
268
269 // Advance the link info for the next element on the chain
270 chain_info->u.pLayerInfo = chain_info->u.pLayerInfo->pNext;
271
272 result = fpCreateInstance(pCreateInfo, pAllocator, pInstance);
273
274 if (result == VK_SUCCESS) {
275 InitializeManualParameterValidationFunctionPointers();
276 auto my_instance_data = GetLayerDataPtr(get_dispatch_key(*pInstance), instance_layer_data_map);
277 assert(my_instance_data != nullptr);
278
279 layer_init_instance_dispatch_table(*pInstance, &my_instance_data->dispatch_table, fpGetInstanceProcAddr);
280 my_instance_data->instance = *pInstance;
281 my_instance_data->report_data =
Mark Young6ba8abe2017-11-09 10:37:04 -0700282 debug_utils_create_instance(&my_instance_data->dispatch_table, *pInstance, pCreateInfo->enabledExtensionCount,
283 pCreateInfo->ppEnabledExtensionNames);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600284
285 // Look for one or more debug report create info structures
286 // and setup a callback(s) for each one found.
Mark Young6ba8abe2017-11-09 10:37:04 -0700287 if (!layer_copy_tmp_debug_messengers(pCreateInfo->pNext, &my_instance_data->num_tmp_debug_messengers,
288 &my_instance_data->tmp_messenger_create_infos,
289 &my_instance_data->tmp_debug_messengers)) {
290 if (my_instance_data->num_tmp_debug_messengers > 0) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600291 // Setup the temporary callback(s) here to catch early issues:
Mark Young6ba8abe2017-11-09 10:37:04 -0700292 if (layer_enable_tmp_debug_messengers(my_instance_data->report_data, my_instance_data->num_tmp_debug_messengers,
293 my_instance_data->tmp_messenger_create_infos,
294 my_instance_data->tmp_debug_messengers)) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600295 // Failure of setting up one or more of the callback.
296 // Therefore, clean up and don't use those callbacks:
Mark Young6ba8abe2017-11-09 10:37:04 -0700297 layer_free_tmp_debug_messengers(my_instance_data->tmp_messenger_create_infos,
298 my_instance_data->tmp_debug_messengers);
299 my_instance_data->num_tmp_debug_messengers = 0;
300 }
301 }
302 }
303 if (!layer_copy_tmp_report_callbacks(pCreateInfo->pNext, &my_instance_data->num_tmp_report_callbacks,
304 &my_instance_data->tmp_report_create_infos, &my_instance_data->tmp_report_callbacks)) {
305 if (my_instance_data->num_tmp_report_callbacks > 0) {
306 // Setup the temporary callback(s) here to catch early issues:
307 if (layer_enable_tmp_report_callbacks(my_instance_data->report_data, my_instance_data->num_tmp_report_callbacks,
308 my_instance_data->tmp_report_create_infos,
309 my_instance_data->tmp_report_callbacks)) {
310 // Failure of setting up one or more of the callback.
311 // Therefore, clean up and don't use those callbacks:
312 layer_free_tmp_report_callbacks(my_instance_data->tmp_report_create_infos,
313 my_instance_data->tmp_report_callbacks);
314 my_instance_data->num_tmp_report_callbacks = 0;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600315 }
316 }
317 }
318
319 init_parameter_validation(my_instance_data, pAllocator);
John Zulaufe6db8a32018-03-30 14:51:59 -0600320 // Note: From the spec--
321 // Providing a NULL VkInstanceCreateInfo::pApplicationInfo or providing an apiVersion of 0 is equivalent to providing
322 // an apiVersion of VK_MAKE_VERSION(1, 0, 0). (a.k.a. VK_API_VERSION_1_0)
323 uint32_t api_version = (pCreateInfo->pApplicationInfo && pCreateInfo->pApplicationInfo->apiVersion)
324 ? pCreateInfo->pApplicationInfo->apiVersion
325 : VK_API_VERSION_1_0;
Mark Lobodzinskibfb7ab92017-10-27 13:22:23 -0600326
John Zulauf1909e6a2018-09-05 11:43:11 -0600327 my_instance_data->api_version = my_instance_data->extensions.InitFromInstanceCreateInfo(api_version, pCreateInfo);
Mark Lobodzinskibfb7ab92017-10-27 13:22:23 -0600328
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600329 // Ordinarily we'd check these before calling down the chain, but none of the layer support is in place until now, if we
330 // survive we can report the issue now.
John Zulauf1909e6a2018-09-05 11:43:11 -0600331 validate_api_version(my_instance_data, api_version, my_instance_data->api_version);
John Zulauf620755c2018-04-16 11:00:43 -0600332 validate_instance_extensions(my_instance_data, pCreateInfo);
333
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600334 parameter_validation_vkCreateInstance(*pInstance, pCreateInfo, pAllocator, pInstance);
335
336 if (pCreateInfo->pApplicationInfo) {
337 if (pCreateInfo->pApplicationInfo->pApplicationName) {
Mark Lobodzinskiebee3552018-05-29 09:55:54 -0600338 validate_string(
339 my_instance_data->report_data, "vkCreateInstance", "pCreateInfo->VkApplicationInfo->pApplicationName",
340 "VUID-VkApplicationInfo-pApplicationName-parameter", pCreateInfo->pApplicationInfo->pApplicationName);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600341 }
342
343 if (pCreateInfo->pApplicationInfo->pEngineName) {
344 validate_string(my_instance_data->report_data, "vkCreateInstance", "pCreateInfo->VkApplicationInfo->pEngineName",
Mark Lobodzinskiebee3552018-05-29 09:55:54 -0600345 "VUID-VkApplicationInfo-pEngineName-parameter", pCreateInfo->pApplicationInfo->pEngineName);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600346 }
347 }
348
349 // Disable the tmp callbacks:
Mark Young6ba8abe2017-11-09 10:37:04 -0700350 if (my_instance_data->num_tmp_debug_messengers > 0) {
351 layer_disable_tmp_debug_messengers(my_instance_data->report_data, my_instance_data->num_tmp_debug_messengers,
352 my_instance_data->tmp_debug_messengers);
353 }
354 if (my_instance_data->num_tmp_report_callbacks > 0) {
355 layer_disable_tmp_report_callbacks(my_instance_data->report_data, my_instance_data->num_tmp_report_callbacks,
356 my_instance_data->tmp_report_callbacks);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600357 }
358 }
359
360 return result;
361}
362
363VKAPI_ATTR void VKAPI_CALL vkDestroyInstance(VkInstance instance, const VkAllocationCallbacks *pAllocator) {
364 // Grab the key before the instance is destroyed.
365 dispatch_key key = get_dispatch_key(instance);
366 bool skip = false;
367 auto instance_data = GetLayerDataPtr(key, instance_layer_data_map);
368
369 // Enable the temporary callback(s) here to catch vkDestroyInstance issues:
370 bool callback_setup = false;
Mark Young6ba8abe2017-11-09 10:37:04 -0700371 if (instance_data->num_tmp_debug_messengers > 0) {
372 if (!layer_enable_tmp_debug_messengers(instance_data->report_data, instance_data->num_tmp_debug_messengers,
373 instance_data->tmp_messenger_create_infos, instance_data->tmp_debug_messengers)) {
374 callback_setup = true;
375 }
376 }
377 if (instance_data->num_tmp_report_callbacks > 0) {
378 if (!layer_enable_tmp_report_callbacks(instance_data->report_data, instance_data->num_tmp_report_callbacks,
379 instance_data->tmp_report_create_infos, instance_data->tmp_report_callbacks)) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600380 callback_setup = true;
381 }
382 }
383
384 skip |= parameter_validation_vkDestroyInstance(instance, pAllocator);
385
386 // Disable and cleanup the temporary callback(s):
387 if (callback_setup) {
Mark Young6ba8abe2017-11-09 10:37:04 -0700388 layer_disable_tmp_debug_messengers(instance_data->report_data, instance_data->num_tmp_debug_messengers,
389 instance_data->tmp_debug_messengers);
390 layer_disable_tmp_report_callbacks(instance_data->report_data, instance_data->num_tmp_report_callbacks,
391 instance_data->tmp_report_callbacks);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600392 }
Mark Young6ba8abe2017-11-09 10:37:04 -0700393 if (instance_data->num_tmp_debug_messengers > 0) {
394 layer_free_tmp_debug_messengers(instance_data->tmp_messenger_create_infos, instance_data->tmp_debug_messengers);
395 instance_data->num_tmp_debug_messengers = 0;
396 }
397 if (instance_data->num_tmp_report_callbacks > 0) {
398 layer_free_tmp_report_callbacks(instance_data->tmp_report_create_infos, instance_data->tmp_report_callbacks);
399 instance_data->num_tmp_report_callbacks = 0;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600400 }
401
402 if (!skip) {
403 instance_data->dispatch_table.DestroyInstance(instance, pAllocator);
404
405 // Clean up logging callback, if any
Mark Young6ba8abe2017-11-09 10:37:04 -0700406 while (instance_data->logging_messenger.size() > 0) {
407 VkDebugUtilsMessengerEXT messenger = instance_data->logging_messenger.back();
408 layer_destroy_messenger_callback(instance_data->report_data, messenger, pAllocator);
409 instance_data->logging_messenger.pop_back();
410 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600411 while (instance_data->logging_callback.size() > 0) {
412 VkDebugReportCallbackEXT callback = instance_data->logging_callback.back();
Mark Young6ba8abe2017-11-09 10:37:04 -0700413 layer_destroy_report_callback(instance_data->report_data, callback, pAllocator);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600414 instance_data->logging_callback.pop_back();
415 }
416
Mark Young6ba8abe2017-11-09 10:37:04 -0700417 layer_debug_utils_destroy_instance(instance_data->report_data);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600418 }
419
420 FreeLayerDataPtr(key, instance_layer_data_map);
421}
422
423VKAPI_ATTR VkResult VKAPI_CALL vkCreateDebugReportCallbackEXT(VkInstance instance,
424 const VkDebugReportCallbackCreateInfoEXT *pCreateInfo,
425 const VkAllocationCallbacks *pAllocator,
426 VkDebugReportCallbackEXT *pMsgCallback) {
427 bool skip = parameter_validation_vkCreateDebugReportCallbackEXT(instance, pCreateInfo, pAllocator, pMsgCallback);
428 if (skip) return VK_ERROR_VALIDATION_FAILED_EXT;
429
430 auto instance_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map);
431 VkResult result = instance_data->dispatch_table.CreateDebugReportCallbackEXT(instance, pCreateInfo, pAllocator, pMsgCallback);
432 if (result == VK_SUCCESS) {
Mark Young6ba8abe2017-11-09 10:37:04 -0700433 result = layer_create_report_callback(instance_data->report_data, false, pCreateInfo, pAllocator, pMsgCallback);
434 // If something happened during this call, clean up the message callback that was created earlier in the lower levels
435 if (VK_SUCCESS != result) {
436 instance_data->dispatch_table.DestroyDebugReportCallbackEXT(instance, *pMsgCallback, pAllocator);
437 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600438 }
439 return result;
440}
441
442VKAPI_ATTR void VKAPI_CALL vkDestroyDebugReportCallbackEXT(VkInstance instance, VkDebugReportCallbackEXT msgCallback,
443 const VkAllocationCallbacks *pAllocator) {
444 bool skip = parameter_validation_vkDestroyDebugReportCallbackEXT(instance, msgCallback, pAllocator);
445 if (!skip) {
446 auto instance_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map);
447 instance_data->dispatch_table.DestroyDebugReportCallbackEXT(instance, msgCallback, pAllocator);
Mark Young6ba8abe2017-11-09 10:37:04 -0700448 layer_destroy_report_callback(instance_data->report_data, msgCallback, pAllocator);
449 }
450}
451
452VKAPI_ATTR VkResult VKAPI_CALL vkCreateDebugUtilsMessengerEXT(VkInstance instance,
453 const VkDebugUtilsMessengerCreateInfoEXT *pCreateInfo,
454 const VkAllocationCallbacks *pAllocator,
455 VkDebugUtilsMessengerEXT *pMessenger) {
456 bool skip = parameter_validation_vkCreateDebugUtilsMessengerEXT(instance, pCreateInfo, pAllocator, pMessenger);
457 if (skip) return VK_ERROR_VALIDATION_FAILED_EXT;
458
459 auto instance_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map);
460 VkResult result = instance_data->dispatch_table.CreateDebugUtilsMessengerEXT(instance, pCreateInfo, pAllocator, pMessenger);
461 if (VK_SUCCESS == result) {
462 result = layer_create_messenger_callback(instance_data->report_data, false, pCreateInfo, pAllocator, pMessenger);
463 // If something happened during this call, clean up the message callback that was created earlier in the lower levels
464 if (VK_SUCCESS != result) {
465 instance_data->dispatch_table.DestroyDebugUtilsMessengerEXT(instance, *pMessenger, pAllocator);
466 }
467 }
468 return result;
469}
470
471VKAPI_ATTR void VKAPI_CALL vkDestroyDebugUtilsMessengerEXT(VkInstance instance, VkDebugUtilsMessengerEXT messenger,
472 const VkAllocationCallbacks *pAllocator) {
473 bool skip = parameter_validation_vkDestroyDebugUtilsMessengerEXT(instance, messenger, pAllocator);
474 if (!skip) {
475 auto instance_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map);
476 instance_data->dispatch_table.DestroyDebugUtilsMessengerEXT(instance, messenger, pAllocator);
477 layer_destroy_messenger_callback(instance_data->report_data, messenger, pAllocator);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600478 }
479}
480
John Zulauf620755c2018-04-16 11:00:43 -0600481template <typename ExtensionState>
482static bool extension_state_by_name(const ExtensionState &extensions, const char *extension_name) {
483 if (!extension_name) return false; // null strings specify nothing
484 auto info = ExtensionState::get_info(extension_name);
485 bool state = info.state ? extensions.*(info.state) : false; // unknown extensions can't be enabled in extension struct
486 return state;
487}
488
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600489static bool ValidateDeviceCreateInfo(instance_layer_data *instance_data, VkPhysicalDevice physicalDevice,
John Zulauf620755c2018-04-16 11:00:43 -0600490 const VkDeviceCreateInfo *pCreateInfo, const DeviceExtensions &extensions) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600491 bool skip = false;
John Zulauf620755c2018-04-16 11:00:43 -0600492 bool maint1 = false;
493 bool negative_viewport = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600494
495 if ((pCreateInfo->enabledLayerCount > 0) && (pCreateInfo->ppEnabledLayerNames != NULL)) {
496 for (size_t i = 0; i < pCreateInfo->enabledLayerCount; i++) {
497 skip |= validate_string(instance_data->report_data, "vkCreateDevice", "pCreateInfo->ppEnabledLayerNames",
Mark Lobodzinskiebee3552018-05-29 09:55:54 -0600498 "VUID-VkDeviceCreateInfo-ppEnabledLayerNames-parameter", pCreateInfo->ppEnabledLayerNames[i]);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600499 }
500 }
501
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600502 if ((pCreateInfo->enabledExtensionCount > 0) && (pCreateInfo->ppEnabledExtensionNames != NULL)) {
John Zulauf620755c2018-04-16 11:00:43 -0600503 maint1 = extension_state_by_name(extensions, VK_KHR_MAINTENANCE1_EXTENSION_NAME);
504 negative_viewport = extension_state_by_name(extensions, VK_AMD_NEGATIVE_VIEWPORT_HEIGHT_EXTENSION_NAME);
505
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600506 for (size_t i = 0; i < pCreateInfo->enabledExtensionCount; i++) {
507 skip |= validate_string(instance_data->report_data, "vkCreateDevice", "pCreateInfo->ppEnabledExtensionNames",
Mark Lobodzinskiebee3552018-05-29 09:55:54 -0600508 "VUID-VkDeviceCreateInfo-ppEnabledExtensionNames-parameter",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600509 pCreateInfo->ppEnabledExtensionNames[i]);
Dave Houlton413a6782018-05-22 13:01:54 -0600510 skip |= validate_extension_reqs(instance_data, extensions, "VUID-vkCreateDevice-ppEnabledExtensionNames-01387",
511 "device", pCreateInfo->ppEnabledExtensionNames[i]);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600512 }
513 }
514
515 if (maint1 && negative_viewport) {
516 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600517 "VUID-VkDeviceCreateInfo-ppEnabledExtensionNames-00374",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600518 "VkDeviceCreateInfo->ppEnabledExtensionNames must not simultaneously include VK_KHR_maintenance1 and "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600519 "VK_AMD_negative_viewport_height.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600520 }
521
522 if (pCreateInfo->pNext != NULL && pCreateInfo->pEnabledFeatures) {
523 // Check for get_physical_device_properties2 struct
John Zulaufde972ac2017-10-26 12:07:05 -0600524 const auto *features2 = lvl_find_in_chain<VkPhysicalDeviceFeatures2KHR>(pCreateInfo->pNext);
525 if (features2) {
526 // Cannot include VkPhysicalDeviceFeatures2KHR and have non-null pEnabledFeatures
527 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600528 kVUID_PVError_InvalidUsage,
John Zulaufde972ac2017-10-26 12:07:05 -0600529 "VkDeviceCreateInfo->pNext includes a VkPhysicalDeviceFeatures2KHR struct when "
530 "pCreateInfo->pEnabledFeatures is non-NULL.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600531 }
532 }
533
534 // Validate pCreateInfo->pQueueCreateInfos
535 if (pCreateInfo->pQueueCreateInfos) {
536 std::unordered_set<uint32_t> set;
537
538 for (uint32_t i = 0; i < pCreateInfo->queueCreateInfoCount; ++i) {
539 const uint32_t requested_queue_family = pCreateInfo->pQueueCreateInfos[i].queueFamilyIndex;
540 if (requested_queue_family == VK_QUEUE_FAMILY_IGNORED) {
541 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT,
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600542 VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, HandleToUint64(physicalDevice),
Dave Houlton413a6782018-05-22 13:01:54 -0600543 "VUID-VkDeviceQueueCreateInfo-queueFamilyIndex-00381",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600544 "vkCreateDevice: pCreateInfo->pQueueCreateInfos[%" PRIu32
Dave Houltona9df0ce2018-02-07 10:51:23 -0700545 "].queueFamilyIndex is VK_QUEUE_FAMILY_IGNORED, but it is required to provide a valid queue family "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600546 "index value.",
547 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600548 } else if (set.count(requested_queue_family)) {
549 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT,
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600550 VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, HandleToUint64(physicalDevice),
Dave Houlton413a6782018-05-22 13:01:54 -0600551 "VUID-VkDeviceCreateInfo-queueFamilyIndex-00372",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600552 "vkCreateDevice: pCreateInfo->pQueueCreateInfos[%" PRIu32 "].queueFamilyIndex (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600553 ") is not unique within pCreateInfo->pQueueCreateInfos array.",
554 i, requested_queue_family);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600555 } else {
556 set.insert(requested_queue_family);
557 }
558
559 if (pCreateInfo->pQueueCreateInfos[i].pQueuePriorities != nullptr) {
560 for (uint32_t j = 0; j < pCreateInfo->pQueueCreateInfos[i].queueCount; ++j) {
561 const float queue_priority = pCreateInfo->pQueueCreateInfos[i].pQueuePriorities[j];
562 if (!(queue_priority >= 0.f) || !(queue_priority <= 1.f)) {
563 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT,
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600564 VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, HandleToUint64(physicalDevice),
Dave Houlton413a6782018-05-22 13:01:54 -0600565 "VUID-VkDeviceQueueCreateInfo-pQueuePriorities-00383",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600566 "vkCreateDevice: pCreateInfo->pQueueCreateInfos[%" PRIu32 "].pQueuePriorities[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600567 "] (=%f) is not between 0 and 1 (inclusive).",
568 i, j, queue_priority);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600569 }
570 }
571 }
572 }
573 }
574
575 return skip;
576}
577
578VKAPI_ATTR VkResult VKAPI_CALL vkCreateDevice(VkPhysicalDevice physicalDevice, const VkDeviceCreateInfo *pCreateInfo,
579 const VkAllocationCallbacks *pAllocator, VkDevice *pDevice) {
580 // NOTE: Don't validate physicalDevice or any dispatchable object as the first parameter. We couldn't get here if it was wrong!
581
582 VkResult result = VK_ERROR_VALIDATION_FAILED_EXT;
583 bool skip = false;
584 auto my_instance_data = GetLayerDataPtr(get_dispatch_key(physicalDevice), instance_layer_data_map);
585 assert(my_instance_data != nullptr);
John Zulauf620755c2018-04-16 11:00:43 -0600586
587 // Query and save physical device limits for this device, needed for validation
588 VkPhysicalDeviceProperties device_properties = {};
589 my_instance_data->dispatch_table.GetPhysicalDeviceProperties(physicalDevice, &device_properties);
590
John Zulauf1909e6a2018-09-05 11:43:11 -0600591 // Setup the validation tables based on the application API version from the instance and the capabilities of the device driver.
592 uint32_t effective_api_version = std::min(device_properties.apiVersion, my_instance_data->api_version);
John Zulauf620755c2018-04-16 11:00:43 -0600593 DeviceExtensions extensions;
John Zulauf1909e6a2018-09-05 11:43:11 -0600594 uint32_t api_version = extensions.InitFromDeviceCreateInfo(&my_instance_data->extensions, effective_api_version, pCreateInfo);
John Zulauf620755c2018-04-16 11:00:43 -0600595
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600596 std::unique_lock<std::mutex> lock(global_lock);
597
598 skip |= parameter_validation_vkCreateDevice(physicalDevice, pCreateInfo, pAllocator, pDevice);
599
John Zulauf620755c2018-04-16 11:00:43 -0600600 if (pCreateInfo != NULL) skip |= ValidateDeviceCreateInfo(my_instance_data, physicalDevice, pCreateInfo, extensions);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600601
602 if (!skip) {
603 VkLayerDeviceCreateInfo *chain_info = get_chain_info(pCreateInfo, VK_LAYER_LINK_INFO);
604 assert(chain_info != nullptr);
605 assert(chain_info->u.pLayerInfo != nullptr);
606
607 PFN_vkGetInstanceProcAddr fpGetInstanceProcAddr = chain_info->u.pLayerInfo->pfnNextGetInstanceProcAddr;
608 PFN_vkGetDeviceProcAddr fpGetDeviceProcAddr = chain_info->u.pLayerInfo->pfnNextGetDeviceProcAddr;
609 PFN_vkCreateDevice fpCreateDevice = (PFN_vkCreateDevice)fpGetInstanceProcAddr(my_instance_data->instance, "vkCreateDevice");
610 if (fpCreateDevice == NULL) {
611 return VK_ERROR_INITIALIZATION_FAILED;
612 }
613
614 // Advance the link info for the next element on the chain
615 chain_info->u.pLayerInfo = chain_info->u.pLayerInfo->pNext;
616
617 lock.unlock();
618
619 result = fpCreateDevice(physicalDevice, pCreateInfo, pAllocator, pDevice);
620
621 lock.lock();
622
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600623 if (result == VK_SUCCESS) {
624 layer_data *my_device_data = GetLayerDataPtr(get_dispatch_key(*pDevice), layer_data_map);
625 assert(my_device_data != nullptr);
626
Mark Young6ba8abe2017-11-09 10:37:04 -0700627 my_device_data->report_data = layer_debug_utils_create_device(my_instance_data->report_data, *pDevice);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600628 layer_init_device_dispatch_table(*pDevice, &my_device_data->dispatch_table, fpGetDeviceProcAddr);
629
John Zulauf620755c2018-04-16 11:00:43 -0600630 my_device_data->api_version = api_version;
631 my_device_data->extensions = extensions;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600632
633 // Store createdevice data
634 if ((pCreateInfo != nullptr) && (pCreateInfo->pQueueCreateInfos != nullptr)) {
635 for (uint32_t i = 0; i < pCreateInfo->queueCreateInfoCount; ++i) {
636 my_device_data->queueFamilyIndexMap.insert(std::make_pair(pCreateInfo->pQueueCreateInfos[i].queueFamilyIndex,
637 pCreateInfo->pQueueCreateInfos[i].queueCount));
638 }
639 }
640
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600641 memcpy(&my_device_data->device_limits, &device_properties.limits, sizeof(VkPhysicalDeviceLimits));
642 my_device_data->physical_device = physicalDevice;
643 my_device_data->device = *pDevice;
644
Jeff Bolz5d2b7432018-09-06 10:32:36 -0500645 if (my_device_data->extensions.vk_nv_shading_rate_image) {
646 // Get the needed shading rate image limits
647 auto shading_rate_image_props = lvl_init_struct<VkPhysicalDeviceShadingRateImagePropertiesNV>();
648 auto prop2 = lvl_init_struct<VkPhysicalDeviceProperties2KHR>(&shading_rate_image_props);
649 my_instance_data->dispatch_table.GetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
650 my_device_data->phys_dev_ext_props.shading_rate_image_props = shading_rate_image_props;
651 }
652
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600653 // Save app-enabled features in this device's layer_data structure
John Zulauf1bde5bb2017-10-18 18:21:23 -0600654 // The enabled features can come from either pEnabledFeatures, or from the pNext chain
655 const VkPhysicalDeviceFeatures *enabled_features_found = pCreateInfo->pEnabledFeatures;
656 if ((nullptr == enabled_features_found) && my_device_data->extensions.vk_khr_get_physical_device_properties_2) {
John Zulaufde972ac2017-10-26 12:07:05 -0600657 const auto *features2 = lvl_find_in_chain<VkPhysicalDeviceFeatures2KHR>(pCreateInfo->pNext);
658 if (features2) {
659 enabled_features_found = &(features2->features);
John Zulauf1bde5bb2017-10-18 18:21:23 -0600660 }
661 }
662 if (enabled_features_found) {
Dave Houltonb3bbec72018-01-17 10:13:33 -0700663 my_device_data->physical_device_features = *enabled_features_found;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600664 } else {
665 memset(&my_device_data->physical_device_features, 0, sizeof(VkPhysicalDeviceFeatures));
666 }
667 }
668 }
669
670 return result;
671}
672
673VKAPI_ATTR void VKAPI_CALL vkDestroyDevice(VkDevice device, const VkAllocationCallbacks *pAllocator) {
674 dispatch_key key = get_dispatch_key(device);
675 bool skip = false;
676 layer_data *device_data = GetLayerDataPtr(key, layer_data_map);
677 {
678 std::unique_lock<std::mutex> lock(global_lock);
679 skip |= parameter_validation_vkDestroyDevice(device, pAllocator);
680 }
681
682 if (!skip) {
Mark Young6ba8abe2017-11-09 10:37:04 -0700683 layer_debug_utils_destroy_device(device);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600684 device_data->dispatch_table.DestroyDevice(device, pAllocator);
685 }
686 FreeLayerDataPtr(key, layer_data_map);
687}
688
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600689bool pv_vkGetDeviceQueue(VkDevice device, uint32_t queueFamilyIndex, uint32_t queueIndex, VkQueue *pQueue) {
690 bool skip = false;
691 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
692
Dave Houlton413a6782018-05-22 13:01:54 -0600693 skip |= ValidateDeviceQueueFamily(device_data, queueFamilyIndex, "vkGetDeviceQueue", "queueFamilyIndex",
694 "VUID-vkGetDeviceQueue-queueFamilyIndex-00384");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600695 const auto &queue_data = device_data->queueFamilyIndexMap.find(queueFamilyIndex);
696 if (queue_data != device_data->queueFamilyIndexMap.end() && queue_data->second <= queueIndex) {
697 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -0600698 HandleToUint64(device), "VUID-vkGetDeviceQueue-queueIndex-00385",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600699 "vkGetDeviceQueue: queueIndex (=%" PRIu32
Dave Houltona9df0ce2018-02-07 10:51:23 -0700700 ") is not less than the number of queues requested from queueFamilyIndex (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600701 ") when the device was created (i.e. is not less than %" PRIu32 ").",
702 queueIndex, queueFamilyIndex, queue_data->second);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600703 }
704 return skip;
705}
706
707VKAPI_ATTR VkResult VKAPI_CALL vkCreateCommandPool(VkDevice device, const VkCommandPoolCreateInfo *pCreateInfo,
708 const VkAllocationCallbacks *pAllocator, VkCommandPool *pCommandPool) {
709 layer_data *local_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
710 bool skip = false;
711 VkResult result = VK_ERROR_VALIDATION_FAILED_EXT;
712 std::unique_lock<std::mutex> lock(global_lock);
713
714 skip |= ValidateDeviceQueueFamily(local_data, pCreateInfo->queueFamilyIndex, "vkCreateCommandPool",
Dave Houlton341c0052018-06-21 15:00:45 -0600715 "pCreateInfo->queueFamilyIndex", "VUID-vkCreateCommandPool-queueFamilyIndex-01937");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600716
717 skip |= parameter_validation_vkCreateCommandPool(device, pCreateInfo, pAllocator, pCommandPool);
718
719 lock.unlock();
720 if (!skip) {
721 result = local_data->dispatch_table.CreateCommandPool(device, pCreateInfo, pAllocator, pCommandPool);
722 }
723 return result;
724}
725
726VKAPI_ATTR VkResult VKAPI_CALL vkCreateQueryPool(VkDevice device, const VkQueryPoolCreateInfo *pCreateInfo,
727 const VkAllocationCallbacks *pAllocator, VkQueryPool *pQueryPool) {
728 VkResult result = VK_ERROR_VALIDATION_FAILED_EXT;
729 bool skip = false;
730 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
731
732 skip |= parameter_validation_vkCreateQueryPool(device, pCreateInfo, pAllocator, pQueryPool);
733
734 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
735 if (pCreateInfo != nullptr) {
736 // If queryType is VK_QUERY_TYPE_PIPELINE_STATISTICS, pipelineStatistics must be a valid combination of
737 // VkQueryPipelineStatisticFlagBits values
738 if ((pCreateInfo->queryType == VK_QUERY_TYPE_PIPELINE_STATISTICS) && (pCreateInfo->pipelineStatistics != 0) &&
739 ((pCreateInfo->pipelineStatistics & (~AllVkQueryPipelineStatisticFlagBits)) != 0)) {
740 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600741 "VUID-VkQueryPoolCreateInfo-queryType-00792",
Dave Houltona9df0ce2018-02-07 10:51:23 -0700742 "vkCreateQueryPool(): if pCreateInfo->queryType is VK_QUERY_TYPE_PIPELINE_STATISTICS, "
743 "pCreateInfo->pipelineStatistics must be a valid combination of VkQueryPipelineStatisticFlagBits "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600744 "values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600745 }
746 }
747 if (!skip) {
748 result = device_data->dispatch_table.CreateQueryPool(device, pCreateInfo, pAllocator, pQueryPool);
749 }
750 return result;
751}
752
Petr Krause91f7a12017-12-14 20:57:36 +0100753VKAPI_ATTR VkResult VKAPI_CALL vkCreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo,
754 const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass) {
755 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
756 bool skip = false;
757 VkResult result = VK_ERROR_VALIDATION_FAILED_EXT;
758
759 {
760 std::unique_lock<std::mutex> lock(global_lock);
761 skip |= parameter_validation_vkCreateRenderPass(device, pCreateInfo, pAllocator, pRenderPass);
762
Dave Houltonb3bbec72018-01-17 10:13:33 -0700763 typedef bool (*PFN_manual_vkCreateRenderPass)(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo,
764 const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass);
Petr Krause91f7a12017-12-14 20:57:36 +0100765 PFN_manual_vkCreateRenderPass custom_func = (PFN_manual_vkCreateRenderPass)custom_functions["vkCreateRenderPass"];
766 if (custom_func != nullptr) {
767 skip |= custom_func(device, pCreateInfo, pAllocator, pRenderPass);
768 }
769 }
770
771 if (!skip) {
772 result = device_data->dispatch_table.CreateRenderPass(device, pCreateInfo, pAllocator, pRenderPass);
773
774 // track the state necessary for checking vkCreateGraphicsPipeline (subpass usage of depth and color attachments)
775 if (result == VK_SUCCESS) {
776 std::unique_lock<std::mutex> lock(global_lock);
777 const auto renderPass = *pRenderPass;
778 auto &renderpass_state = device_data->renderpasses_states[renderPass];
779
780 for (uint32_t subpass = 0; subpass < pCreateInfo->subpassCount; ++subpass) {
781 bool uses_color = false;
782 for (uint32_t i = 0; i < pCreateInfo->pSubpasses[subpass].colorAttachmentCount && !uses_color; ++i)
783 if (pCreateInfo->pSubpasses[subpass].pColorAttachments[i].attachment != VK_ATTACHMENT_UNUSED) uses_color = true;
784
785 bool uses_depthstencil = false;
786 if (pCreateInfo->pSubpasses[subpass].pDepthStencilAttachment)
787 if (pCreateInfo->pSubpasses[subpass].pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED)
788 uses_depthstencil = true;
789
790 if (uses_color) renderpass_state.subpasses_using_color_attachment.insert(subpass);
791 if (uses_depthstencil) renderpass_state.subpasses_using_depthstencil_attachment.insert(subpass);
792 }
793 }
794 }
795 return result;
796}
797
798VKAPI_ATTR void VKAPI_CALL vkDestroyRenderPass(VkDevice device, VkRenderPass renderPass, const VkAllocationCallbacks *pAllocator) {
799 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
800 bool skip = false;
801
802 {
803 std::unique_lock<std::mutex> lock(global_lock);
804 skip |= parameter_validation_vkDestroyRenderPass(device, renderPass, pAllocator);
805
Dave Houltonb3bbec72018-01-17 10:13:33 -0700806 typedef bool (*PFN_manual_vkDestroyRenderPass)(VkDevice device, VkRenderPass renderPass,
807 const VkAllocationCallbacks *pAllocator);
Petr Krause91f7a12017-12-14 20:57:36 +0100808 PFN_manual_vkDestroyRenderPass custom_func = (PFN_manual_vkDestroyRenderPass)custom_functions["vkDestroyRenderPass"];
809 if (custom_func != nullptr) {
810 skip |= custom_func(device, renderPass, pAllocator);
811 }
812 }
813
814 if (!skip) {
815 device_data->dispatch_table.DestroyRenderPass(device, renderPass, pAllocator);
816
817 // track the state necessary for checking vkCreateGraphicsPipeline (subpass usage of depth and color attachments)
818 {
819 std::unique_lock<std::mutex> lock(global_lock);
820 device_data->renderpasses_states.erase(renderPass);
821 }
822 }
823}
824
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600825bool pv_vkCreateBuffer(VkDevice device, const VkBufferCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
826 VkBuffer *pBuffer) {
827 bool skip = false;
828 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
829 debug_report_data *report_data = device_data->report_data;
830
Mark Lobodzinski88529492018-04-01 10:38:15 -0600831 const LogMiscParams log_misc{report_data, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, VK_NULL_HANDLE, "vkCreateBuffer"};
Petr Krause5c37652018-01-05 04:05:12 +0100832
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600833 if (pCreateInfo != nullptr) {
Dave Houlton413a6782018-05-22 13:01:54 -0600834 skip |= ValidateGreaterThanZero(pCreateInfo->size, "pCreateInfo->size", "VUID-VkBufferCreateInfo-size-00912", log_misc);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600835
836 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
837 if (pCreateInfo->sharingMode == VK_SHARING_MODE_CONCURRENT) {
838 // If sharingMode is VK_SHARING_MODE_CONCURRENT, queueFamilyIndexCount must be greater than 1
839 if (pCreateInfo->queueFamilyIndexCount <= 1) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600840 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600841 "VUID-VkBufferCreateInfo-sharingMode-00914",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600842 "vkCreateBuffer: if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600843 "pCreateInfo->queueFamilyIndexCount must be greater than 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600844 }
845
846 // If sharingMode is VK_SHARING_MODE_CONCURRENT, pQueueFamilyIndices must be a pointer to an array of
847 // queueFamilyIndexCount uint32_t values
848 if (pCreateInfo->pQueueFamilyIndices == nullptr) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600849 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600850 "VUID-VkBufferCreateInfo-sharingMode-00913",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600851 "vkCreateBuffer: if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
852 "pCreateInfo->pQueueFamilyIndices must be a pointer to an array of "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600853 "pCreateInfo->queueFamilyIndexCount uint32_t values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600854 } else {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600855 skip |= ValidateQueueFamilies(device_data, pCreateInfo->queueFamilyIndexCount, pCreateInfo->pQueueFamilyIndices,
Dave Houlton413a6782018-05-22 13:01:54 -0600856 "vkCreateBuffer", "pCreateInfo->pQueueFamilyIndices", kVUID_PVError_InvalidUsage,
857 kVUID_PVError_InvalidUsage, false);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600858 }
859 }
860
861 // If flags contains VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT or VK_BUFFER_CREATE_SPARSE_ALIASED_BIT, it must also contain
862 // VK_BUFFER_CREATE_SPARSE_BINDING_BIT
863 if (((pCreateInfo->flags & (VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT | VK_BUFFER_CREATE_SPARSE_ALIASED_BIT)) != 0) &&
864 ((pCreateInfo->flags & VK_BUFFER_CREATE_SPARSE_BINDING_BIT) != VK_BUFFER_CREATE_SPARSE_BINDING_BIT)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600865 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600866 "VUID-VkBufferCreateInfo-flags-00918",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600867 "vkCreateBuffer: if pCreateInfo->flags contains VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT or "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600868 "VK_BUFFER_CREATE_SPARSE_ALIASED_BIT, it must also contain VK_BUFFER_CREATE_SPARSE_BINDING_BIT.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600869 }
870 }
871
872 return skip;
873}
874
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600875bool pv_vkCreateImage(VkDevice device, const VkImageCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
876 VkImage *pImage) {
877 bool skip = false;
878 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
879 debug_report_data *report_data = device_data->report_data;
880
Mark Lobodzinski88529492018-04-01 10:38:15 -0600881 const LogMiscParams log_misc{report_data, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, VK_NULL_HANDLE, "vkCreateImage"};
Petr Krause5c37652018-01-05 04:05:12 +0100882
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600883 if (pCreateInfo != nullptr) {
884 if ((device_data->physical_device_features.textureCompressionETC2 == false) &&
885 FormatIsCompressed_ETC2_EAC(pCreateInfo->format)) {
Dave Houlton413a6782018-05-22 13:01:54 -0600886 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
887 kVUID_PVError_DeviceFeature,
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600888 "vkCreateImage(): Attempting to create VkImage with format %s. The textureCompressionETC2 feature is "
889 "not enabled: neither ETC2 nor EAC formats can be used to create images.",
890 string_VkFormat(pCreateInfo->format));
891 }
892
893 if ((device_data->physical_device_features.textureCompressionASTC_LDR == false) &&
894 FormatIsCompressed_ASTC_LDR(pCreateInfo->format)) {
Dave Houlton413a6782018-05-22 13:01:54 -0600895 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
896 kVUID_PVError_DeviceFeature,
Dave Houltona9df0ce2018-02-07 10:51:23 -0700897 "vkCreateImage(): Attempting to create VkImage with format %s. The textureCompressionASTC_LDR feature "
898 "is not enabled: ASTC formats cannot be used to create images.",
899 string_VkFormat(pCreateInfo->format));
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600900 }
901
902 if ((device_data->physical_device_features.textureCompressionBC == false) && FormatIsCompressed_BC(pCreateInfo->format)) {
Dave Houlton413a6782018-05-22 13:01:54 -0600903 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
904 kVUID_PVError_DeviceFeature,
Dave Houltona9df0ce2018-02-07 10:51:23 -0700905 "vkCreateImage(): Attempting to create VkImage with format %s. The textureCompressionBC feature is not "
906 "enabled: BC compressed formats cannot be used to create images.",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600907 string_VkFormat(pCreateInfo->format));
908 }
909
910 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
911 if (pCreateInfo->sharingMode == VK_SHARING_MODE_CONCURRENT) {
912 // If sharingMode is VK_SHARING_MODE_CONCURRENT, queueFamilyIndexCount must be greater than 1
913 if (pCreateInfo->queueFamilyIndexCount <= 1) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600914 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600915 "VUID-VkImageCreateInfo-sharingMode-00942",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600916 "vkCreateImage(): if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600917 "pCreateInfo->queueFamilyIndexCount must be greater than 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600918 }
919
920 // If sharingMode is VK_SHARING_MODE_CONCURRENT, pQueueFamilyIndices must be a pointer to an array of
921 // queueFamilyIndexCount uint32_t values
922 if (pCreateInfo->pQueueFamilyIndices == nullptr) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600923 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600924 "VUID-VkImageCreateInfo-sharingMode-00941",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600925 "vkCreateImage(): if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
926 "pCreateInfo->pQueueFamilyIndices must be a pointer to an array of "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600927 "pCreateInfo->queueFamilyIndexCount uint32_t values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600928 } else {
Dave Houlton413a6782018-05-22 13:01:54 -0600929 skip |= ValidateQueueFamilies(device_data, pCreateInfo->queueFamilyIndexCount, pCreateInfo->pQueueFamilyIndices,
930 "vkCreateImage", "pCreateInfo->pQueueFamilyIndices", kVUID_PVError_InvalidUsage,
931 kVUID_PVError_InvalidUsage, false);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600932 }
933 }
934
Dave Houlton413a6782018-05-22 13:01:54 -0600935 skip |= ValidateGreaterThanZero(pCreateInfo->extent.width, "pCreateInfo->extent.width",
936 "VUID-VkImageCreateInfo-extent-00944", log_misc);
937 skip |= ValidateGreaterThanZero(pCreateInfo->extent.height, "pCreateInfo->extent.height",
938 "VUID-VkImageCreateInfo-extent-00945", log_misc);
939 skip |= ValidateGreaterThanZero(pCreateInfo->extent.depth, "pCreateInfo->extent.depth",
940 "VUID-VkImageCreateInfo-extent-00946", log_misc);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600941
Dave Houlton413a6782018-05-22 13:01:54 -0600942 skip |= ValidateGreaterThanZero(pCreateInfo->mipLevels, "pCreateInfo->mipLevels", "VUID-VkImageCreateInfo-mipLevels-00947",
943 log_misc);
944 skip |= ValidateGreaterThanZero(pCreateInfo->arrayLayers, "pCreateInfo->arrayLayers",
945 "VUID-VkImageCreateInfo-arrayLayers-00948", log_misc);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600946
Dave Houlton130c0212018-01-29 13:39:56 -0700947 // InitialLayout must be PREINITIALIZED or UNDEFINED
Dave Houltone19e20d2018-02-02 16:32:41 -0700948 if ((pCreateInfo->initialLayout != VK_IMAGE_LAYOUT_UNDEFINED) &&
949 (pCreateInfo->initialLayout != VK_IMAGE_LAYOUT_PREINITIALIZED)) {
950 skip |= log_msg(
Dave Houlton413a6782018-05-22 13:01:54 -0600951 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
952 "VUID-VkImageCreateInfo-initialLayout-00993",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600953 "vkCreateImage(): initialLayout is %s, must be VK_IMAGE_LAYOUT_UNDEFINED or VK_IMAGE_LAYOUT_PREINITIALIZED.",
954 string_VkImageLayout(pCreateInfo->initialLayout));
Dave Houlton130c0212018-01-29 13:39:56 -0700955 }
956
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600957 // If imageType is VK_IMAGE_TYPE_1D, both extent.height and extent.depth must be 1
Petr Kraus3ac9e812018-03-13 12:31:08 +0100958 if ((pCreateInfo->imageType == VK_IMAGE_TYPE_1D) &&
959 ((pCreateInfo->extent.height != 1) || (pCreateInfo->extent.depth != 1))) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600960 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600961 "VUID-VkImageCreateInfo-imageType-00956",
Dave Houltona9df0ce2018-02-07 10:51:23 -0700962 "vkCreateImage(): if pCreateInfo->imageType is VK_IMAGE_TYPE_1D, both pCreateInfo->extent.height and "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600963 "pCreateInfo->extent.depth must be 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600964 }
965
966 if (pCreateInfo->imageType == VK_IMAGE_TYPE_2D) {
Petr Kraus3f433212018-03-13 12:31:27 +0100967 if (pCreateInfo->flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) {
968 if (pCreateInfo->extent.width != pCreateInfo->extent.height) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600969 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -0600970 VK_NULL_HANDLE, "VUID-VkImageCreateInfo-imageType-00954",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600971 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT, but "
972 "pCreateInfo->extent.width (=%" PRIu32 ") and pCreateInfo->extent.height (=%" PRIu32
973 ") are not equal.",
974 pCreateInfo->extent.width, pCreateInfo->extent.height);
Petr Kraus3f433212018-03-13 12:31:27 +0100975 }
976
977 if (pCreateInfo->arrayLayers < 6) {
978 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -0600979 VK_NULL_HANDLE, "VUID-VkImageCreateInfo-imageType-00954",
Petr Kraus3f433212018-03-13 12:31:27 +0100980 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT, but "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600981 "pCreateInfo->arrayLayers (=%" PRIu32 ") is not greater than or equal to 6.",
982 pCreateInfo->arrayLayers);
Petr Kraus3f433212018-03-13 12:31:27 +0100983 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600984 }
985
986 if (pCreateInfo->extent.depth != 1) {
Mark Lobodzinski88529492018-04-01 10:38:15 -0600987 skip |=
988 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600989 "VUID-VkImageCreateInfo-imageType-00957",
Mark Lobodzinski88529492018-04-01 10:38:15 -0600990 "vkCreateImage(): if pCreateInfo->imageType is VK_IMAGE_TYPE_2D, pCreateInfo->extent.depth must be 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600991 }
992 }
993
Dave Houlton130c0212018-01-29 13:39:56 -0700994 // 3D image may have only 1 layer
995 if ((pCreateInfo->imageType == VK_IMAGE_TYPE_3D) && (pCreateInfo->arrayLayers != 1)) {
Mark Lobodzinski88529492018-04-01 10:38:15 -0600996 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600997 "VUID-VkImageCreateInfo-imageType-00961",
Mark Lobodzinski88529492018-04-01 10:38:15 -0600998 "vkCreateImage(): if pCreateInfo->imageType is VK_IMAGE_TYPE_3D, pCreateInfo->arrayLayers must be 1.");
Dave Houlton130c0212018-01-29 13:39:56 -0700999 }
1000
1001 // If multi-sample, validate type, usage, tiling and mip levels.
1002 if ((pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT) &&
1003 ((pCreateInfo->imageType != VK_IMAGE_TYPE_2D) || (pCreateInfo->flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) ||
1004 (pCreateInfo->tiling != VK_IMAGE_TILING_OPTIMAL) || (pCreateInfo->mipLevels != 1))) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001005 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001006 "VUID-VkImageCreateInfo-samples-00962",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001007 "vkCreateImage(): Multi-sample image with incompatible type, usage, tiling, or mips.");
Dave Houlton130c0212018-01-29 13:39:56 -07001008 }
1009
1010 if (0 != (pCreateInfo->usage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT)) {
1011 VkImageUsageFlags legal_flags = (VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT | VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT |
1012 VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT);
1013 // At least one of the legal attachment bits must be set
1014 if (0 == (pCreateInfo->usage & legal_flags)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001015 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001016 "VUID-VkImageCreateInfo-usage-00966",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001017 "vkCreateImage(): Transient attachment image without a compatible attachment flag set.");
Dave Houlton130c0212018-01-29 13:39:56 -07001018 }
1019 // No flags other than the legal attachment bits may be set
1020 legal_flags |= VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT;
1021 if (0 != (pCreateInfo->usage & ~legal_flags)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001022 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001023 "VUID-VkImageCreateInfo-usage-00963",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001024 "vkCreateImage(): Transient attachment image with incompatible usage flags set.");
Dave Houlton130c0212018-01-29 13:39:56 -07001025 }
1026 }
1027
Jeff Bolzef40fec2018-09-01 22:04:34 -05001028 // mipLevels must be less than or equal to the number of levels in the complete mipmap chain
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001029 uint32_t maxDim = std::max(std::max(pCreateInfo->extent.width, pCreateInfo->extent.height), pCreateInfo->extent.depth);
Jeff Bolzef40fec2018-09-01 22:04:34 -05001030 // Max mip levels is different for corner-sampled images vs normal images.
1031 uint32_t maxMipLevels = (pCreateInfo->flags & VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV)
1032 ? (uint32_t)(ceil(log2(maxDim)))
1033 : (uint32_t)(floor(log2(maxDim)) + 1);
1034 if (maxDim > 0 && pCreateInfo->mipLevels > maxMipLevels) {
Dave Houlton413a6782018-05-22 13:01:54 -06001035 skip |=
1036 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1037 "VUID-VkImageCreateInfo-mipLevels-00958",
1038 "vkCreateImage(): pCreateInfo->mipLevels must be less than or equal to "
1039 "floor(log2(max(pCreateInfo->extent.width, pCreateInfo->extent.height, pCreateInfo->extent.depth)))+1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001040 }
1041
Mark Lobodzinski69259c52018-09-18 15:14:58 -06001042 if ((pCreateInfo->flags & VK_IMAGE_CREATE_2D_ARRAY_COMPATIBLE_BIT) && (pCreateInfo->imageType != VK_IMAGE_TYPE_3D)) {
1043 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, VK_NULL_HANDLE,
1044 "VUID-VkImageCreateInfo-flags-00950",
1045 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_2D_ARRAY_COMPATIBLE_BIT but "
1046 "pCreateInfo->imageType is not VK_IMAGE_TYPE_3D.");
1047 }
1048
Petr Krausb6f97802018-03-13 12:31:39 +01001049 if ((pCreateInfo->flags & VK_IMAGE_CREATE_SPARSE_BINDING_BIT) && (!device_data->physical_device_features.sparseBinding)) {
1050 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, VK_NULL_HANDLE,
Dave Houlton413a6782018-05-22 13:01:54 -06001051 "VUID-VkImageCreateInfo-flags-00969",
Petr Krausb6f97802018-03-13 12:31:39 +01001052 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_SPARSE_BINDING_BIT, but the "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001053 "VkPhysicalDeviceFeatures::sparseBinding feature is disabled.");
Petr Krausb6f97802018-03-13 12:31:39 +01001054 }
1055
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001056 // If flags contains VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT or VK_IMAGE_CREATE_SPARSE_ALIASED_BIT, it must also contain
1057 // VK_IMAGE_CREATE_SPARSE_BINDING_BIT
1058 if (((pCreateInfo->flags & (VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT | VK_IMAGE_CREATE_SPARSE_ALIASED_BIT)) != 0) &&
1059 ((pCreateInfo->flags & VK_IMAGE_CREATE_SPARSE_BINDING_BIT) != VK_IMAGE_CREATE_SPARSE_BINDING_BIT)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001060 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001061 "VUID-VkImageCreateInfo-flags-00987",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001062 "vkCreateImage: if pCreateInfo->flags contains VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT or "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001063 "VK_IMAGE_CREATE_SPARSE_ALIASED_BIT, it must also contain VK_IMAGE_CREATE_SPARSE_BINDING_BIT.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001064 }
1065
1066 // Check for combinations of attributes that are incompatible with having VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT set
1067 if ((pCreateInfo->flags & VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT) != 0) {
1068 // Linear tiling is unsupported
1069 if (VK_IMAGE_TILING_LINEAR == pCreateInfo->tiling) {
Dave Houlton413a6782018-05-22 13:01:54 -06001070 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1071 kVUID_PVError_InvalidUsage,
1072 "vkCreateImage: if pCreateInfo->flags contains VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT then image "
1073 "tiling of VK_IMAGE_TILING_LINEAR is not supported");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001074 }
1075
1076 // Sparse 1D image isn't valid
1077 if (VK_IMAGE_TYPE_1D == pCreateInfo->imageType) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001078 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001079 "VUID-VkImageCreateInfo-imageType-00970",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001080 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 1D image.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001081 }
1082
1083 // Sparse 2D image when device doesn't support it
1084 if ((VK_FALSE == device_data->physical_device_features.sparseResidencyImage2D) &&
1085 (VK_IMAGE_TYPE_2D == pCreateInfo->imageType)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001086 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001087 "VUID-VkImageCreateInfo-imageType-00971",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001088 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 2D image if corresponding "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001089 "feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001090 }
1091
1092 // Sparse 3D image when device doesn't support it
1093 if ((VK_FALSE == device_data->physical_device_features.sparseResidencyImage3D) &&
1094 (VK_IMAGE_TYPE_3D == pCreateInfo->imageType)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001095 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001096 "VUID-VkImageCreateInfo-imageType-00972",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001097 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 3D image if corresponding "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001098 "feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001099 }
1100
1101 // Multi-sample 2D image when device doesn't support it
1102 if (VK_IMAGE_TYPE_2D == pCreateInfo->imageType) {
1103 if ((VK_FALSE == device_data->physical_device_features.sparseResidency2Samples) &&
1104 (VK_SAMPLE_COUNT_2_BIT == pCreateInfo->samples)) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07001105 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001106 "VUID-VkImageCreateInfo-imageType-00973",
Dave Houltona9df0ce2018-02-07 10:51:23 -07001107 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 2-sample image if "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001108 "corresponding feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001109 } else if ((VK_FALSE == device_data->physical_device_features.sparseResidency4Samples) &&
1110 (VK_SAMPLE_COUNT_4_BIT == pCreateInfo->samples)) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07001111 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001112 "VUID-VkImageCreateInfo-imageType-00974",
Dave Houltona9df0ce2018-02-07 10:51:23 -07001113 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 4-sample image if "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001114 "corresponding feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001115 } else if ((VK_FALSE == device_data->physical_device_features.sparseResidency8Samples) &&
1116 (VK_SAMPLE_COUNT_8_BIT == pCreateInfo->samples)) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07001117 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001118 "VUID-VkImageCreateInfo-imageType-00975",
Dave Houltona9df0ce2018-02-07 10:51:23 -07001119 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 8-sample image if "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001120 "corresponding feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001121 } else if ((VK_FALSE == device_data->physical_device_features.sparseResidency16Samples) &&
1122 (VK_SAMPLE_COUNT_16_BIT == pCreateInfo->samples)) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07001123 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001124 "VUID-VkImageCreateInfo-imageType-00976",
Dave Houltona9df0ce2018-02-07 10:51:23 -07001125 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 16-sample image if "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001126 "corresponding feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001127 }
1128 }
1129 }
Jeff Bolzef40fec2018-09-01 22:04:34 -05001130
Jeff Bolz9af91c52018-09-01 21:53:57 -05001131 if (pCreateInfo->usage & VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV) {
1132 if (pCreateInfo->imageType != VK_IMAGE_TYPE_2D) {
1133 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1134 "VUID-VkImageCreateInfo-imageType-02082",
1135 "vkCreateImage: if usage includes VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV, "
1136 "imageType must be VK_IMAGE_TYPE_2D.");
1137 }
1138 if (pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT) {
1139 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1140 "VUID-VkImageCreateInfo-samples-02083",
1141 "vkCreateImage: if usage includes VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV, "
1142 "samples must be VK_SAMPLE_COUNT_1_BIT.");
1143 }
1144 if (pCreateInfo->tiling != VK_IMAGE_TILING_OPTIMAL) {
1145 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1146 "VUID-VkImageCreateInfo-tiling-02084",
1147 "vkCreateImage: if usage includes VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV, "
1148 "tiling must be VK_IMAGE_TILING_OPTIMAL.");
1149 }
1150 }
Jeff Bolzef40fec2018-09-01 22:04:34 -05001151
1152 if (pCreateInfo->flags & VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV) {
1153 if (pCreateInfo->imageType != VK_IMAGE_TYPE_2D &&
1154 pCreateInfo->imageType != VK_IMAGE_TYPE_3D) {
1155 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1156 "VUID-VkImageCreateInfo-flags-02050",
1157 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV, "
1158 "imageType must be VK_IMAGE_TYPE_2D or VK_IMAGE_TYPE_3D.");
1159 }
1160
1161 if ((pCreateInfo->flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) ||
1162 FormatIsDepthOrStencil(pCreateInfo->format)) {
1163 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1164 "VUID-VkImageCreateInfo-flags-02051",
1165 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV, "
1166 "it must not also contain VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT and format must "
1167 "not be a depth/stencil format.");
1168 }
1169
1170 if (pCreateInfo->imageType == VK_IMAGE_TYPE_2D &&
1171 (pCreateInfo->extent.width == 1 || pCreateInfo->extent.height == 1)) {
1172 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1173 "VUID-VkImageCreateInfo-flags-02052",
1174 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV and "
1175 "imageType is VK_IMAGE_TYPE_2D, extent.width and extent.height must be "
1176 "greater than 1.");
1177 }
1178
1179 if (pCreateInfo->imageType == VK_IMAGE_TYPE_3D &&
1180 (pCreateInfo->extent.width == 1 || pCreateInfo->extent.height == 1 || pCreateInfo->extent.depth == 1)) {
1181 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1182 "VUID-VkImageCreateInfo-flags-02053",
1183 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV and "
1184 "imageType is VK_IMAGE_TYPE_3D, extent.width, extent.height, and extent.depth "
1185 "must be greater than 1.");
1186
1187 }
1188 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001189 }
Jeff Bolzef40fec2018-09-01 22:04:34 -05001190
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001191 return skip;
1192}
1193
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001194bool pv_vkCreateImageView(VkDevice device, const VkImageViewCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
1195 VkImageView *pView) {
1196 bool skip = false;
1197 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
1198 debug_report_data *report_data = device_data->report_data;
1199
1200 if (pCreateInfo != nullptr) {
Dave Houltonbd2e2622018-04-10 16:41:14 -06001201 // Validate chained VkImageViewUsageCreateInfo struct, if present
1202 if (nullptr != pCreateInfo->pNext) {
1203 auto chained_ivuci_struct = lvl_find_in_chain<VkImageViewUsageCreateInfoKHR>(pCreateInfo->pNext);
1204 if (chained_ivuci_struct) {
1205 if (0 == chained_ivuci_struct->usage) {
1206 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001207 "VUID-VkImageViewUsageCreateInfo-usage-requiredbitmask",
Dave Houlton0f3795b2018-04-13 15:04:35 -06001208 "vkCreateImageView: Chained VkImageViewUsageCreateInfo usage field must not be 0.");
Dave Houltonbd2e2622018-04-10 16:41:14 -06001209 } else if (chained_ivuci_struct->usage & ~AllVkImageUsageFlagBits) {
1210 std::stringstream ss;
1211 ss << "vkCreateImageView: Chained VkImageViewUsageCreateInfo usage field (0x" << std::hex
1212 << chained_ivuci_struct->usage << ") contains invalid flag bits.";
1213 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001214 "VUID-VkImageViewUsageCreateInfo-usage-parameter", "%s", ss.str().c_str());
Dave Houltonbd2e2622018-04-10 16:41:14 -06001215 }
1216 }
1217 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001218 }
1219 return skip;
1220}
1221
Petr Krausb3fcdb42018-01-09 22:09:09 +01001222bool pv_VkViewport(const layer_data *device_data, const VkViewport &viewport, const char *fn_name, const char *param_name,
1223 VkDebugReportObjectTypeEXT object_type, uint64_t object = 0) {
1224 bool skip = false;
1225 debug_report_data *report_data = device_data->report_data;
1226
1227 // Note: for numerical correctness
1228 // - float comparisons should expect NaN (comparison always false).
1229 // - VkPhysicalDeviceLimits::maxViewportDimensions is uint32_t, not float -> careful.
1230
1231 const auto f_lte_u32_exact = [](const float v1_f, const uint32_t v2_u32) {
John Zulaufac0876c2018-02-19 10:09:35 -07001232 if (std::isnan(v1_f)) return false;
Petr Krausb3fcdb42018-01-09 22:09:09 +01001233 if (v1_f <= 0.0f) return true;
1234
1235 float intpart;
1236 const float fract = modff(v1_f, &intpart);
1237
1238 assert(std::numeric_limits<float>::radix == 2);
1239 const float u32_max_plus1 = ldexpf(1.0f, 32); // hopefully exact
1240 if (intpart >= u32_max_plus1) return false;
1241
1242 uint32_t v1_u32 = static_cast<uint32_t>(intpart);
1243 if (v1_u32 < v2_u32)
1244 return true;
1245 else if (v1_u32 == v2_u32 && fract == 0.0f)
1246 return true;
1247 else
1248 return false;
1249 };
1250
1251 const auto f_lte_u32_direct = [](const float v1_f, const uint32_t v2_u32) {
1252 const float v2_f = static_cast<float>(v2_u32); // not accurate for > radix^digits; and undefined rounding mode
1253 return (v1_f <= v2_f);
1254 };
1255
1256 // width
1257 bool width_healthy = true;
1258 const auto max_w = device_data->device_limits.maxViewportDimensions[0];
1259
1260 if (!(viewport.width > 0.0f)) {
1261 width_healthy = false;
Dave Houlton413a6782018-05-22 13:01:54 -06001262 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-width-01770",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001263 "%s: %s.width (=%f) is not greater than 0.0.", fn_name, param_name, viewport.width);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001264 } else if (!(f_lte_u32_exact(viewport.width, max_w) || f_lte_u32_direct(viewport.width, max_w))) {
1265 width_healthy = false;
Dave Houlton413a6782018-05-22 13:01:54 -06001266 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-width-01771",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001267 "%s: %s.width (=%f) exceeds VkPhysicalDeviceLimits::maxViewportDimensions[0] (=%" PRIu32 ").", fn_name,
1268 param_name, viewport.width, max_w);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001269 } else if (!f_lte_u32_exact(viewport.width, max_w) && f_lte_u32_direct(viewport.width, max_w)) {
Dave Houlton413a6782018-05-22 13:01:54 -06001270 skip |= log_msg(report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, object_type, object, kVUID_PVError_NONE,
Petr Krausb3fcdb42018-01-09 22:09:09 +01001271 "%s: %s.width (=%f) technically exceeds VkPhysicalDeviceLimits::maxViewportDimensions[0] (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001272 "), but it is within the static_cast<float>(maxViewportDimensions[0]) limit.",
1273 fn_name, param_name, viewport.width, max_w);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001274 }
1275
1276 // height
1277 bool height_healthy = true;
Petr Krausaf9c1222018-03-10 02:39:47 +01001278 const bool negative_height_enabled = device_data->api_version >= VK_API_VERSION_1_1 ||
1279 device_data->extensions.vk_khr_maintenance1 ||
1280 device_data->extensions.vk_amd_negative_viewport_height;
Petr Krausb3fcdb42018-01-09 22:09:09 +01001281 const auto max_h = device_data->device_limits.maxViewportDimensions[1];
1282
1283 if (!negative_height_enabled && !(viewport.height > 0.0f)) {
1284 height_healthy = false;
Dave Houlton413a6782018-05-22 13:01:54 -06001285 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-height-01772",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001286 "%s: %s.height (=%f) is not greater 0.0.", fn_name, param_name, viewport.height);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001287 } else if (!(f_lte_u32_exact(fabsf(viewport.height), max_h) || f_lte_u32_direct(fabsf(viewport.height), max_h))) {
1288 height_healthy = false;
1289
Dave Houlton413a6782018-05-22 13:01:54 -06001290 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-height-01773",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001291 "%s: Absolute value of %s.height (=%f) exceeds VkPhysicalDeviceLimits::maxViewportDimensions[1] (=%" PRIu32
1292 ").",
1293 fn_name, param_name, viewport.height, max_h);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001294 } else if (!f_lte_u32_exact(fabsf(viewport.height), max_h) && f_lte_u32_direct(fabsf(viewport.height), max_h)) {
1295 height_healthy = false;
1296
1297 skip |= log_msg(
Dave Houlton413a6782018-05-22 13:01:54 -06001298 report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, object_type, object, kVUID_PVError_NONE,
Petr Krausb3fcdb42018-01-09 22:09:09 +01001299 "%s: Absolute value of %s.height (=%f) technically exceeds VkPhysicalDeviceLimits::maxViewportDimensions[1] (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001300 "), but it is within the static_cast<float>(maxViewportDimensions[1]) limit.",
1301 fn_name, param_name, viewport.height, max_h);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001302 }
1303
1304 // x
1305 bool x_healthy = true;
1306 if (!(viewport.x >= device_data->device_limits.viewportBoundsRange[0])) {
1307 x_healthy = false;
Dave Houlton413a6782018-05-22 13:01:54 -06001308 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-x-01774",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001309 "%s: %s.x (=%f) is less than VkPhysicalDeviceLimits::viewportBoundsRange[0] (=%f).", fn_name, param_name,
1310 viewport.x, device_data->device_limits.viewportBoundsRange[0]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001311 }
1312
1313 // x + width
1314 if (x_healthy && width_healthy) {
1315 const float right_bound = viewport.x + viewport.width;
1316 if (!(right_bound <= device_data->device_limits.viewportBoundsRange[1])) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06001317 skip |=
Dave Houlton413a6782018-05-22 13:01:54 -06001318 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-x-01232",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001319 "%s: %s.x + %s.width (=%f + %f = %f) is greater than VkPhysicalDeviceLimits::viewportBoundsRange[1] (=%f).",
1320 fn_name, param_name, param_name, viewport.x, viewport.width, right_bound,
1321 device_data->device_limits.viewportBoundsRange[1]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001322 }
1323 }
1324
1325 // y
1326 bool y_healthy = true;
1327 if (!(viewport.y >= device_data->device_limits.viewportBoundsRange[0])) {
1328 y_healthy = false;
Dave Houlton413a6782018-05-22 13:01:54 -06001329 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-y-01775",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001330 "%s: %s.y (=%f) is less than VkPhysicalDeviceLimits::viewportBoundsRange[0] (=%f).", fn_name, param_name,
1331 viewport.y, device_data->device_limits.viewportBoundsRange[0]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001332 } else if (negative_height_enabled && !(viewport.y <= device_data->device_limits.viewportBoundsRange[1])) {
1333 y_healthy = false;
Dave Houlton413a6782018-05-22 13:01:54 -06001334 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-y-01776",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001335 "%s: %s.y (=%f) exceeds VkPhysicalDeviceLimits::viewportBoundsRange[1] (=%f).", fn_name, param_name,
1336 viewport.y, device_data->device_limits.viewportBoundsRange[1]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001337 }
1338
1339 // y + height
1340 if (y_healthy && height_healthy) {
1341 const float boundary = viewport.y + viewport.height;
1342
1343 if (!(boundary <= device_data->device_limits.viewportBoundsRange[1])) {
Dave Houlton413a6782018-05-22 13:01:54 -06001344 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-y-01233",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001345 "%s: %s.y + %s.height (=%f + %f = %f) exceeds VkPhysicalDeviceLimits::viewportBoundsRange[1] (=%f).",
1346 fn_name, param_name, param_name, viewport.y, viewport.height, boundary,
1347 device_data->device_limits.viewportBoundsRange[1]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001348 } else if (negative_height_enabled && !(boundary >= device_data->device_limits.viewportBoundsRange[0])) {
1349 skip |= log_msg(
Dave Houlton413a6782018-05-22 13:01:54 -06001350 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-y-01777",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001351 "%s: %s.y + %s.height (=%f + %f = %f) is less than VkPhysicalDeviceLimits::viewportBoundsRange[0] (=%f).", fn_name,
1352 param_name, param_name, viewport.y, viewport.height, boundary, device_data->device_limits.viewportBoundsRange[0]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001353 }
1354 }
1355
1356 if (!device_data->extensions.vk_ext_depth_range_unrestricted) {
1357 // minDepth
1358 if (!(viewport.minDepth >= 0.0) || !(viewport.minDepth <= 1.0)) {
Dave Houlton413a6782018-05-22 13:01:54 -06001359 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-minDepth-01234",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001360
Petr Krausb3fcdb42018-01-09 22:09:09 +01001361 "%s: VK_EXT_depth_range_unrestricted extension is not enabled and %s.minDepth (=%f) is not within the "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001362 "[0.0, 1.0] range.",
1363 fn_name, param_name, viewport.minDepth);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001364 }
1365
1366 // maxDepth
1367 if (!(viewport.maxDepth >= 0.0) || !(viewport.maxDepth <= 1.0)) {
Dave Houlton413a6782018-05-22 13:01:54 -06001368 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-maxDepth-01235",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001369
Petr Krausb3fcdb42018-01-09 22:09:09 +01001370 "%s: VK_EXT_depth_range_unrestricted extension is not enabled and %s.maxDepth (=%f) is not within the "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001371 "[0.0, 1.0] range.",
1372 fn_name, param_name, viewport.maxDepth);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001373 }
1374 }
1375
1376 return skip;
1377}
1378
Jeff Bolz9af91c52018-09-01 21:53:57 -05001379struct SampleOrderInfo
1380{
1381 VkShadingRatePaletteEntryNV shadingRate;
1382 uint32_t width;
1383 uint32_t height;
1384};
1385
1386// All palette entries with more than one pixel per fragment
1387static SampleOrderInfo sampleOrderInfos[] =
1388{
1389 { VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_1X2_PIXELS_NV, 1, 2},
1390 { VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_2X1_PIXELS_NV, 2, 1},
1391 { VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_2X2_PIXELS_NV, 2, 2},
1392 { VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_4X2_PIXELS_NV, 4, 2},
1393 { VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_2X4_PIXELS_NV, 2, 4},
1394 { VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_4X4_PIXELS_NV, 4, 4},
1395};
1396
1397bool ValidateCoarseSampleOrderCustomNV(layer_data *device_data, const VkCoarseSampleOrderCustomNV *order)
1398{
1399 bool skip = false;
1400 debug_report_data *report_data = device_data->report_data;
1401
1402 uint32_t infoIdx = 0;
1403 for (; infoIdx < ARRAY_SIZE(sampleOrderInfos); ++infoIdx) {
1404 if (sampleOrderInfos[infoIdx].shadingRate == order->shadingRate) {
1405 break;
1406 }
1407 }
1408
1409 if (infoIdx == ARRAY_SIZE(sampleOrderInfos)) {
1410 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1411 "VUID-VkCoarseSampleOrderCustomNV-shadingRate-02073",
1412 "VkCoarseSampleOrderCustomNV shadingRate must be a shading rate "
1413 "that generates fragments with more than one pixel.");
1414 return skip;
1415 }
1416
1417 if (order->sampleCount == 0 ||
1418 (order->sampleCount & (order->sampleCount - 1)) ||
1419 !(order->sampleCount & device_data->device_limits.framebufferNoAttachmentsSampleCounts)) {
1420 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1421 "VUID-VkCoarseSampleOrderCustomNV-sampleCount-02074",
1422 "VkCoarseSampleOrderCustomNV sampleCount (=%" PRIu32 ") must "
1423 "correspond to a sample count enumerated in VkSampleCountFlags whose corresponding bit "
1424 "is set in framebufferNoAttachmentsSampleCounts.",
1425 order->sampleCount);
1426 }
1427
1428 SampleOrderInfo *sampleOrderInfo = &sampleOrderInfos[infoIdx];
1429
1430 if (order->sampleLocationCount != order->sampleCount * sampleOrderInfo->width * sampleOrderInfo->height) {
1431 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1432 "VUID-VkCoarseSampleOrderCustomNV-sampleLocationCount-02075",
1433 "VkCoarseSampleOrderCustomNV sampleLocationCount (=%" PRIu32 ") must "
1434 "be equal to the product of sampleCount (=%" PRIu32 "), the fragment width for shadingRate "
1435 "(=%" PRIu32 "), and the fragment height for shadingRate (=%" PRIu32 ").",
1436 order->sampleLocationCount, order->sampleCount, sampleOrderInfo->width, sampleOrderInfo->height);
1437 }
1438
Jeff Bolz5d2b7432018-09-06 10:32:36 -05001439 if (order->sampleLocationCount > device_data->phys_dev_ext_props.shading_rate_image_props.shadingRateMaxCoarseSamples) {
1440 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1441 "VUID-VkCoarseSampleOrderCustomNV-sampleLocationCount-02076",
1442 "VkCoarseSampleOrderCustomNV sampleLocationCount (=%" PRIu32 ") must "
1443 "be less than or equal to VkPhysicalDeviceShadingRateImagePropertiesNV shadingRateMaxCoarseSamples (=%" PRIu32 ").",
1444 order->sampleLocationCount, device_data->phys_dev_ext_props.shading_rate_image_props.shadingRateMaxCoarseSamples);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001445 }
Jeff Bolz9af91c52018-09-01 21:53:57 -05001446
1447 // Accumulate a bitmask tracking which (x,y,sample) tuples are seen. Expect
1448 // the first width*height*sampleCount bits to all be set
1449 uint64_t sampleLocationsMask = 0;
1450 for (uint32_t i = 0; i < order->sampleLocationCount; ++i) {
1451 const VkCoarseSampleLocationNV *sampleLoc = &order->pSampleLocations[i];
1452 if (sampleLoc->pixelX >= sampleOrderInfo->width) {
1453 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1454 "VUID-VkCoarseSampleLocationNV-pixelX-02078",
1455 "pixelX must be less than the width (in pixels) of the fragment.");
1456 }
1457 if (sampleLoc->pixelY >= sampleOrderInfo->height) {
1458 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1459 "VUID-VkCoarseSampleLocationNV-pixelY-02079",
1460 "pixelY must be less than the height (in pixels) of the fragment.");
1461 }
1462 if (sampleLoc->sample >= order->sampleCount) {
1463 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1464 "VUID-VkCoarseSampleLocationNV-sample-02080",
1465 "sample must be less than the number of coverage samples in each pixel belonging to the fragment.");
1466 }
1467 uint32_t idx = sampleLoc->sample + order->sampleCount * (sampleLoc->pixelX + sampleOrderInfo->width * sampleLoc->pixelY);
1468 sampleLocationsMask |= 1ULL << idx;
1469 }
1470
1471 uint64_t expectedMask = (order->sampleLocationCount == 64) ? ~0ULL : ((1ULL << order->sampleLocationCount) - 1);
1472 if (sampleLocationsMask != expectedMask) {
1473 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1474 "VUID-VkCoarseSampleOrderCustomNV-pSampleLocations-02077",
1475 "The array pSampleLocations must contain exactly one entry for "
1476 "every combination of valid values for pixelX, pixelY, and sample in the structure VkCoarseSampleOrderCustomNV.");
1477 }
1478
1479 return skip;
1480}
1481
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001482bool pv_vkCreateGraphicsPipelines(VkDevice device, VkPipelineCache pipelineCache, uint32_t createInfoCount,
1483 const VkGraphicsPipelineCreateInfo *pCreateInfos, const VkAllocationCallbacks *pAllocator,
1484 VkPipeline *pPipelines) {
1485 bool skip = false;
1486 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
1487 debug_report_data *report_data = device_data->report_data;
1488
1489 if (pCreateInfos != nullptr) {
1490 for (uint32_t i = 0; i < createInfoCount; ++i) {
Petr Kraus299ba622017-11-24 03:09:03 +01001491 bool has_dynamic_viewport = false;
1492 bool has_dynamic_scissor = false;
1493 bool has_dynamic_line_width = false;
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001494 bool has_dynamic_viewport_w_scaling_nv = false;
1495 bool has_dynamic_discard_rectangle_ext = false;
1496 bool has_dynamic_sample_locations_ext = false;
Jeff Bolz3e71f782018-08-29 23:15:45 -05001497 bool has_dynamic_exclusive_scissor_nv = false;
Jeff Bolz9af91c52018-09-01 21:53:57 -05001498 bool has_dynamic_shading_rate_palette_nv = false;
Petr Kraus299ba622017-11-24 03:09:03 +01001499 if (pCreateInfos[i].pDynamicState != nullptr) {
1500 const auto &dynamic_state_info = *pCreateInfos[i].pDynamicState;
1501 for (uint32_t state_index = 0; state_index < dynamic_state_info.dynamicStateCount; ++state_index) {
1502 const auto &dynamic_state = dynamic_state_info.pDynamicStates[state_index];
1503 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT) has_dynamic_viewport = true;
1504 if (dynamic_state == VK_DYNAMIC_STATE_SCISSOR) has_dynamic_scissor = true;
1505 if (dynamic_state == VK_DYNAMIC_STATE_LINE_WIDTH) has_dynamic_line_width = true;
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001506 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT_W_SCALING_NV) has_dynamic_viewport_w_scaling_nv = true;
1507 if (dynamic_state == VK_DYNAMIC_STATE_DISCARD_RECTANGLE_EXT) has_dynamic_discard_rectangle_ext = true;
1508 if (dynamic_state == VK_DYNAMIC_STATE_SAMPLE_LOCATIONS_EXT) has_dynamic_sample_locations_ext = true;
Jeff Bolz3e71f782018-08-29 23:15:45 -05001509 if (dynamic_state == VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV) has_dynamic_exclusive_scissor_nv = true;
Jeff Bolz9af91c52018-09-01 21:53:57 -05001510 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT_SHADING_RATE_PALETTE_NV) has_dynamic_shading_rate_palette_nv = true;
Petr Kraus299ba622017-11-24 03:09:03 +01001511 }
1512 }
1513
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001514 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
1515 if (pCreateInfos[i].pVertexInputState != nullptr) {
1516 auto const &vertex_input_state = pCreateInfos[i].pVertexInputState;
Peter Kohautc7d9d392018-07-15 00:34:07 +02001517
1518 if (vertex_input_state->vertexBindingDescriptionCount > device_data->device_limits.maxVertexInputBindings) {
1519 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1520 "VUID-VkPipelineVertexInputStateCreateInfo-vertexBindingDescriptionCount-00613",
1521 "vkCreateGraphicsPipelines: pararameter "
1522 "pCreateInfo[%d].pVertexInputState->vertexBindingDescriptionCount (%u) is "
1523 "greater than VkPhysicalDeviceLimits::maxVertexInputBindings (%u).",
1524 i, vertex_input_state->vertexBindingDescriptionCount,
1525 device_data->device_limits.maxVertexInputBindings);
1526 }
1527
1528 if (vertex_input_state->vertexAttributeDescriptionCount > device_data->device_limits.maxVertexInputAttributes) {
1529 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1530 "VUID-VkPipelineVertexInputStateCreateInfo-vertexAttributeDescriptionCount-00614",
1531 "vkCreateGraphicsPipelines: pararameter "
Peter Kohaut9e92c5c2018-07-17 10:32:17 +02001532 "pCreateInfo[%d].pVertexInputState->vertexAttributeDescriptionCount (%u) is "
Peter Kohautc7d9d392018-07-15 00:34:07 +02001533 "greater than VkPhysicalDeviceLimits::maxVertexInputAttributes (%u).",
1534 i, vertex_input_state->vertexBindingDescriptionCount,
1535 device_data->device_limits.maxVertexInputAttributes);
1536 }
1537
1538 std::unordered_set<uint32_t> vertex_bindings(vertex_input_state->vertexBindingDescriptionCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001539 for (uint32_t d = 0; d < vertex_input_state->vertexBindingDescriptionCount; ++d) {
1540 auto const &vertex_bind_desc = vertex_input_state->pVertexBindingDescriptions[d];
Peter Kohautc7d9d392018-07-15 00:34:07 +02001541 auto const &binding_it = vertex_bindings.find(vertex_bind_desc.binding);
1542 if (binding_it != vertex_bindings.cend()) {
1543 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1544 "VUID-VkPipelineVertexInputStateCreateInfo-pVertexBindingDescriptions-00616",
1545 "vkCreateGraphicsPipelines: parameter "
1546 "pCreateInfo[%d].pVertexInputState->pVertexBindingDescription[%d].binding "
1547 "(%" PRIu32 ") is not distinct.",
1548 i, d, vertex_bind_desc.binding);
1549 }
1550 vertex_bindings.insert(vertex_bind_desc.binding);
1551
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001552 if (vertex_bind_desc.binding >= device_data->device_limits.maxVertexInputBindings) {
1553 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001554 "VUID-VkVertexInputBindingDescription-binding-00618",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001555 "vkCreateGraphicsPipelines: parameter "
1556 "pCreateInfos[%u].pVertexInputState->pVertexBindingDescriptions[%u].binding (%u) is "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001557 "greater than or equal to VkPhysicalDeviceLimits::maxVertexInputBindings (%u).",
1558 i, d, vertex_bind_desc.binding, device_data->device_limits.maxVertexInputBindings);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001559 }
1560
1561 if (vertex_bind_desc.stride > device_data->device_limits.maxVertexInputBindingStride) {
1562 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001563 "VUID-VkVertexInputBindingDescription-stride-00619",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001564 "vkCreateGraphicsPipelines: parameter "
1565 "pCreateInfos[%u].pVertexInputState->pVertexBindingDescriptions[%u].stride (%u) is greater "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001566 "than VkPhysicalDeviceLimits::maxVertexInputBindingStride (%u).",
1567 i, d, vertex_bind_desc.stride, device_data->device_limits.maxVertexInputBindingStride);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001568 }
1569 }
1570
Peter Kohautc7d9d392018-07-15 00:34:07 +02001571 std::unordered_set<uint32_t> attribute_locations(vertex_input_state->vertexAttributeDescriptionCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001572 for (uint32_t d = 0; d < vertex_input_state->vertexAttributeDescriptionCount; ++d) {
1573 auto const &vertex_attrib_desc = vertex_input_state->pVertexAttributeDescriptions[d];
Peter Kohautc7d9d392018-07-15 00:34:07 +02001574 auto const &location_it = attribute_locations.find(vertex_attrib_desc.location);
1575 if (location_it != attribute_locations.cend()) {
1576 skip |= log_msg(
1577 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1578 "VUID-VkPipelineVertexInputStateCreateInfo-pVertexAttributeDescriptions-00617",
1579 "vkCreateGraphicsPipelines: parameter "
1580 "pCreateInfo[%d].pVertexInputState->vertexAttributeDescriptions[%d].location (%u) is not distinct.",
1581 i, d, vertex_attrib_desc.location);
1582 }
1583 attribute_locations.insert(vertex_attrib_desc.location);
1584
1585 auto const &binding_it = vertex_bindings.find(vertex_attrib_desc.binding);
1586 if (binding_it == vertex_bindings.cend()) {
1587 skip |= log_msg(
1588 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1589 "VUID-VkPipelineVertexInputStateCreateInfo-binding-00615",
1590 "vkCreateGraphicsPipelines: parameter "
1591 " pCreateInfo[%d].pVertexInputState->vertexAttributeDescriptions[%d].binding (%u) does not exist "
1592 "in any pCreateInfo[%d].pVertexInputState->pVertexBindingDescription.",
1593 i, d, vertex_attrib_desc.binding, i);
1594 }
1595
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001596 if (vertex_attrib_desc.location >= device_data->device_limits.maxVertexInputAttributes) {
1597 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001598 "VUID-VkVertexInputAttributeDescription-location-00620",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001599 "vkCreateGraphicsPipelines: parameter "
1600 "pCreateInfos[%u].pVertexInputState->pVertexAttributeDescriptions[%u].location (%u) is "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001601 "greater than or equal to VkPhysicalDeviceLimits::maxVertexInputAttributes (%u).",
1602 i, d, vertex_attrib_desc.location, device_data->device_limits.maxVertexInputAttributes);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001603 }
1604
1605 if (vertex_attrib_desc.binding >= device_data->device_limits.maxVertexInputBindings) {
1606 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001607 "VUID-VkVertexInputAttributeDescription-binding-00621",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001608 "vkCreateGraphicsPipelines: parameter "
1609 "pCreateInfos[%u].pVertexInputState->pVertexAttributeDescriptions[%u].binding (%u) is "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001610 "greater than or equal to VkPhysicalDeviceLimits::maxVertexInputBindings (%u).",
1611 i, d, vertex_attrib_desc.binding, device_data->device_limits.maxVertexInputBindings);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001612 }
1613
1614 if (vertex_attrib_desc.offset > device_data->device_limits.maxVertexInputAttributeOffset) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06001615 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001616 "VUID-VkVertexInputAttributeDescription-offset-00622",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001617 "vkCreateGraphicsPipelines: parameter "
1618 "pCreateInfos[%u].pVertexInputState->pVertexAttributeDescriptions[%u].offset (%u) is "
1619 "greater than VkPhysicalDeviceLimits::maxVertexInputAttributeOffset (%u).",
1620 i, d, vertex_attrib_desc.offset, device_data->device_limits.maxVertexInputAttributeOffset);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001621 }
1622 }
1623 }
1624
1625 if (pCreateInfos[i].pStages != nullptr) {
1626 bool has_control = false;
1627 bool has_eval = false;
1628
1629 for (uint32_t stage_index = 0; stage_index < pCreateInfos[i].stageCount; ++stage_index) {
1630 if (pCreateInfos[i].pStages[stage_index].stage == VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) {
1631 has_control = true;
1632 } else if (pCreateInfos[i].pStages[stage_index].stage == VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT) {
1633 has_eval = true;
1634 }
1635 }
1636
1637 // pTessellationState is ignored without both tessellation control and tessellation evaluation shaders stages
1638 if (has_control && has_eval) {
1639 if (pCreateInfos[i].pTessellationState == nullptr) {
1640 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001641 "VUID-VkGraphicsPipelineCreateInfo-pStages-00731",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001642 "vkCreateGraphicsPipelines: if pCreateInfos[%d].pStages includes a tessellation control "
1643 "shader stage and a tessellation evaluation shader stage, "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001644 "pCreateInfos[%d].pTessellationState must not be NULL.",
1645 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001646 } else {
1647 skip |= validate_struct_pnext(
1648 report_data, "vkCreateGraphicsPipelines",
1649 ParameterName("pCreateInfos[%i].pTessellationState->pNext", ParameterName::IndexVector{i}), NULL,
Dave Houlton413a6782018-05-22 13:01:54 -06001650 pCreateInfos[i].pTessellationState->pNext, 0, NULL, GeneratedHeaderVersion,
1651 "VUID-VkGraphicsPipelineCreateInfo-pNext-pNext");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001652
1653 skip |= validate_reserved_flags(
1654 report_data, "vkCreateGraphicsPipelines",
1655 ParameterName("pCreateInfos[%i].pTessellationState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06001656 pCreateInfos[i].pTessellationState->flags,
1657 "VUID-VkPipelineTessellationStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001658
1659 if (pCreateInfos[i].pTessellationState->sType !=
1660 VK_STRUCTURE_TYPE_PIPELINE_TESSELLATION_STATE_CREATE_INFO) {
1661 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001662 "VUID-VkPipelineTessellationStateCreateInfo-sType-sType",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001663 "vkCreateGraphicsPipelines: parameter pCreateInfos[%d].pTessellationState->sType must "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001664 "be VK_STRUCTURE_TYPE_PIPELINE_TESSELLATION_STATE_CREATE_INFO.",
1665 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001666 }
1667
1668 if (pCreateInfos[i].pTessellationState->patchControlPoints == 0 ||
1669 pCreateInfos[i].pTessellationState->patchControlPoints >
1670 device_data->device_limits.maxTessellationPatchSize) {
1671 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001672 "VUID-VkPipelineTessellationStateCreateInfo-patchControlPoints-01214",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001673 "vkCreateGraphicsPipelines: invalid parameter "
1674 "pCreateInfos[%d].pTessellationState->patchControlPoints value %u. patchControlPoints "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001675 "should be >0 and <=%u.",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001676 i, pCreateInfos[i].pTessellationState->patchControlPoints,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001677 device_data->device_limits.maxTessellationPatchSize);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001678 }
1679 }
1680 }
1681 }
1682
1683 // pViewportState, pMultisampleState, pDepthStencilState, and pColorBlendState ignored when rasterization is disabled
1684 if ((pCreateInfos[i].pRasterizationState != nullptr) &&
1685 (pCreateInfos[i].pRasterizationState->rasterizerDiscardEnable == VK_FALSE)) {
1686 if (pCreateInfos[i].pViewportState == nullptr) {
Petr Krausa6103552017-11-16 21:21:58 +01001687 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001688 VK_NULL_HANDLE, "VUID-VkGraphicsPipelineCreateInfo-rasterizerDiscardEnable-00750",
Petr Krausa6103552017-11-16 21:21:58 +01001689 "vkCreateGraphicsPipelines: Rasterization is enabled (pCreateInfos[%" PRIu32
1690 "].pRasterizationState->rasterizerDiscardEnable is VK_FALSE), but pCreateInfos[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001691 "].pViewportState (=NULL) is not a valid pointer.",
1692 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001693 } else {
Petr Krausa6103552017-11-16 21:21:58 +01001694 const auto &viewport_state = *pCreateInfos[i].pViewportState;
1695
1696 if (viewport_state.sType != VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_STATE_CREATE_INFO) {
1697 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001698 VK_NULL_HANDLE, "VUID-VkPipelineViewportStateCreateInfo-sType-sType",
Petr Krausa6103552017-11-16 21:21:58 +01001699 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001700 "].pViewportState->sType is not VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_STATE_CREATE_INFO.",
1701 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001702 }
1703
Petr Krausa6103552017-11-16 21:21:58 +01001704 const VkStructureType allowed_structs_VkPipelineViewportStateCreateInfo[] = {
1705 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_SWIZZLE_STATE_CREATE_INFO_NV,
Jeff Bolz3e71f782018-08-29 23:15:45 -05001706 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_W_SCALING_STATE_CREATE_INFO_NV,
1707 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_EXCLUSIVE_SCISSOR_STATE_CREATE_INFO_NV,
Jeff Bolz9af91c52018-09-01 21:53:57 -05001708 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_SHADING_RATE_IMAGE_STATE_CREATE_INFO_NV,
1709 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_COARSE_SAMPLE_ORDER_STATE_CREATE_INFO_NV,
Jeff Bolz3e71f782018-08-29 23:15:45 -05001710 };
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001711 skip |= validate_struct_pnext(
1712 report_data, "vkCreateGraphicsPipelines",
Petr Krausa6103552017-11-16 21:21:58 +01001713 ParameterName("pCreateInfos[%i].pViewportState->pNext", ParameterName::IndexVector{i}),
Jeff Bolz9af91c52018-09-01 21:53:57 -05001714 "VkPipelineViewportSwizzleStateCreateInfoNV, VkPipelineViewportWScalingStateCreateInfoNV, "
1715 "VkPipelineViewportExclusiveScissorStateCreateInfoNV, VkPipelineViewportShadingRateImageStateCreateInfoNV, VkPipelineViewportCoarseSampleOrderStateCreateInfoNV",
Petr Krausa6103552017-11-16 21:21:58 +01001716 viewport_state.pNext, ARRAY_SIZE(allowed_structs_VkPipelineViewportStateCreateInfo),
Dave Houlton413a6782018-05-22 13:01:54 -06001717 allowed_structs_VkPipelineViewportStateCreateInfo, 65,
1718 "VUID-VkPipelineViewportStateCreateInfo-pNext-pNext");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001719
1720 skip |= validate_reserved_flags(
1721 report_data, "vkCreateGraphicsPipelines",
1722 ParameterName("pCreateInfos[%i].pViewportState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06001723 viewport_state.flags, "VUID-VkPipelineViewportStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001724
Jeff Bolz3e71f782018-08-29 23:15:45 -05001725 auto exclusive_scissor_struct = lvl_find_in_chain<VkPipelineViewportExclusiveScissorStateCreateInfoNV>(pCreateInfos[i].pViewportState->pNext);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001726 auto shading_rate_image_struct = lvl_find_in_chain<VkPipelineViewportShadingRateImageStateCreateInfoNV>(pCreateInfos[i].pViewportState->pNext);
1727 auto coarse_sample_order_struct = lvl_find_in_chain<VkPipelineViewportCoarseSampleOrderStateCreateInfoNV>(pCreateInfos[i].pViewportState->pNext);
Jeff Bolz3e71f782018-08-29 23:15:45 -05001728
Petr Krausa6103552017-11-16 21:21:58 +01001729 if (!device_data->physical_device_features.multiViewport) {
1730 if (viewport_state.viewportCount != 1) {
1731 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001732 VK_NULL_HANDLE, "VUID-VkPipelineViewportStateCreateInfo-viewportCount-01216",
Petr Krausa6103552017-11-16 21:21:58 +01001733 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
1734 "disabled, but pCreateInfos[%" PRIu32 "].pViewportState->viewportCount (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001735 ") is not 1.",
1736 i, viewport_state.viewportCount);
Petr Krausa6103552017-11-16 21:21:58 +01001737 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001738
Petr Krausa6103552017-11-16 21:21:58 +01001739 if (viewport_state.scissorCount != 1) {
1740 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001741 VK_NULL_HANDLE, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-01217",
Petr Krausa6103552017-11-16 21:21:58 +01001742 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
1743 "disabled, but pCreateInfos[%" PRIu32 "].pViewportState->scissorCount (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001744 ") is not 1.",
1745 i, viewport_state.scissorCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001746 }
Jeff Bolz3e71f782018-08-29 23:15:45 -05001747
1748 if (exclusive_scissor_struct &&
1749 (exclusive_scissor_struct->exclusiveScissorCount != 0 && exclusive_scissor_struct->exclusiveScissorCount != 1)) {
1750 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
1751 VK_NULL_HANDLE, "VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-exclusiveScissorCount-02027",
1752 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
Jeff Bolz9af91c52018-09-01 21:53:57 -05001753 "disabled, but pCreateInfos[%" PRIu32 "] VkPipelineViewportExclusiveScissorStateCreateInfoNV::exclusiveScissorCount (=%" PRIu32
Jeff Bolz3e71f782018-08-29 23:15:45 -05001754 ") is not 1.",
1755 i, exclusive_scissor_struct->exclusiveScissorCount);
1756
1757 }
1758
Jeff Bolz9af91c52018-09-01 21:53:57 -05001759 if (shading_rate_image_struct &&
1760 (shading_rate_image_struct->viewportCount != 0 && shading_rate_image_struct->viewportCount != 1)) {
1761 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
1762 VK_NULL_HANDLE, "VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-viewportCount-02054",
1763 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
1764 "disabled, but pCreateInfos[%" PRIu32 "] VkPipelineViewportShadingRateImageStateCreateInfoNV::viewportCount (=%" PRIu32
1765 ") is not 1.",
1766 i, shading_rate_image_struct->viewportCount);
1767
1768 }
1769
Petr Krausa6103552017-11-16 21:21:58 +01001770 } else { // multiViewport enabled
1771 if (viewport_state.viewportCount == 0) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001772 skip |= log_msg(
1773 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001774 VK_NULL_HANDLE, "VUID-VkPipelineViewportStateCreateInfo-viewportCount-arraylength",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001775 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "].pViewportState->viewportCount is 0.", i);
Petr Krausa6103552017-11-16 21:21:58 +01001776 } else if (viewport_state.viewportCount > device_data->device_limits.maxViewports) {
1777 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001778 VK_NULL_HANDLE, "VUID-VkPipelineViewportStateCreateInfo-viewportCount-01218",
Petr Krausa6103552017-11-16 21:21:58 +01001779 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1780 "].pViewportState->viewportCount (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001781 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
1782 i, viewport_state.viewportCount, device_data->device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001783 }
Petr Krausa6103552017-11-16 21:21:58 +01001784
1785 if (viewport_state.scissorCount == 0) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001786 skip |= log_msg(
1787 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001788 VK_NULL_HANDLE, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-arraylength",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001789 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "].pViewportState->scissorCount is 0.", i);
Petr Krausa6103552017-11-16 21:21:58 +01001790 } else if (viewport_state.scissorCount > device_data->device_limits.maxViewports) {
1791 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001792 VK_NULL_HANDLE, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-01219",
Petr Krausa6103552017-11-16 21:21:58 +01001793 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1794 "].pViewportState->scissorCount (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001795 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
1796 i, viewport_state.scissorCount, device_data->device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001797 }
1798 }
1799
Jeff Bolz3e71f782018-08-29 23:15:45 -05001800 if (exclusive_scissor_struct &&
1801 exclusive_scissor_struct->exclusiveScissorCount > device_data->device_limits.maxViewports) {
1802 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
1803 VK_NULL_HANDLE, "VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-exclusiveScissorCount-02028",
1804 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1805 "] exclusiveScissorCount (=%" PRIu32
1806 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
1807 i, exclusive_scissor_struct->exclusiveScissorCount, device_data->device_limits.maxViewports);
1808 }
1809
Jeff Bolz9af91c52018-09-01 21:53:57 -05001810 if (shading_rate_image_struct &&
1811 shading_rate_image_struct->viewportCount > device_data->device_limits.maxViewports) {
1812 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
1813 VK_NULL_HANDLE, "VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-viewportCount-02055",
1814 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1815 "] VkPipelineViewportShadingRateImageStateCreateInfoNV viewportCount (=%" PRIu32
1816 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
1817 i, shading_rate_image_struct->viewportCount, device_data->device_limits.maxViewports);
1818 }
1819
Petr Krausa6103552017-11-16 21:21:58 +01001820 if (viewport_state.scissorCount != viewport_state.viewportCount) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001821 skip |=
1822 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001823 VK_NULL_HANDLE, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-01220",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001824 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "].pViewportState->scissorCount (=%" PRIu32
1825 ") is not identical to pCreateInfos[%" PRIu32 "].pViewportState->viewportCount (=%" PRIu32 ").",
1826 i, viewport_state.scissorCount, i, viewport_state.viewportCount);
Petr Krausa6103552017-11-16 21:21:58 +01001827 }
1828
Jeff Bolz3e71f782018-08-29 23:15:45 -05001829 if (exclusive_scissor_struct &&
1830 exclusive_scissor_struct->exclusiveScissorCount != 0 &&
1831 exclusive_scissor_struct->exclusiveScissorCount != viewport_state.viewportCount) {
1832 skip |=
1833 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
1834 VK_NULL_HANDLE, "VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-exclusiveScissorCount-02029",
1835 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "] exclusiveScissorCount (=%" PRIu32
1836 ") must be zero or identical to pCreateInfos[%" PRIu32 "].pViewportState->viewportCount (=%" PRIu32 ").",
1837 i, exclusive_scissor_struct->exclusiveScissorCount, i, viewport_state.viewportCount);
1838 }
1839
Jeff Bolz9af91c52018-09-01 21:53:57 -05001840 if (shading_rate_image_struct &&
1841 shading_rate_image_struct->shadingRateImageEnable &&
1842 shading_rate_image_struct->viewportCount != viewport_state.viewportCount) {
1843 skip |=
1844 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
1845 VK_NULL_HANDLE, "VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-shadingRateImageEnable-02056",
1846 "vkCreateGraphicsPipelines: If shadingRateImageEnable is enabled, pCreateInfos[%" PRIu32 "] "
1847 "VkPipelineViewportShadingRateImageStateCreateInfoNV viewportCount (=%" PRIu32
1848 ") must identical to pCreateInfos[%" PRIu32 "].pViewportState->viewportCount (=%" PRIu32 ").",
1849 i, shading_rate_image_struct->viewportCount, i, viewport_state.viewportCount);
1850 }
1851
Petr Krausa6103552017-11-16 21:21:58 +01001852 if (!has_dynamic_viewport && viewport_state.viewportCount > 0 && viewport_state.pViewports == nullptr) {
1853 skip |= log_msg(
1854 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, VK_NULL_HANDLE,
Dave Houlton413a6782018-05-22 13:01:54 -06001855 "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-00747",
Petr Krausa6103552017-11-16 21:21:58 +01001856 "vkCreateGraphicsPipelines: The viewport state is static (pCreateInfos[%" PRIu32
1857 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_VIEWPORT), but pCreateInfos[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001858 "].pViewportState->pViewports (=NULL) is an invalid pointer.",
1859 i, i);
Petr Krausa6103552017-11-16 21:21:58 +01001860 }
1861
1862 if (!has_dynamic_scissor && viewport_state.scissorCount > 0 && viewport_state.pScissors == nullptr) {
1863 skip |= log_msg(
1864 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, VK_NULL_HANDLE,
Dave Houlton413a6782018-05-22 13:01:54 -06001865 "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-00748",
Petr Krausa6103552017-11-16 21:21:58 +01001866 "vkCreateGraphicsPipelines: The scissor state is static (pCreateInfos[%" PRIu32
1867 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_SCISSOR), but pCreateInfos[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001868 "].pViewportState->pScissors (=NULL) is an invalid pointer.",
1869 i, i);
Petr Krausa6103552017-11-16 21:21:58 +01001870 }
1871
Jeff Bolz3e71f782018-08-29 23:15:45 -05001872 if (!has_dynamic_exclusive_scissor_nv && exclusive_scissor_struct &&
1873 exclusive_scissor_struct->exclusiveScissorCount > 0 && exclusive_scissor_struct->pExclusiveScissors == nullptr) {
1874 skip |= log_msg(
1875 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, VK_NULL_HANDLE,
1876 "VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-pDynamicStates-02030",
1877 "vkCreateGraphicsPipelines: The exclusive scissor state is static (pCreateInfos[%" PRIu32
1878 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV), but pCreateInfos[%" PRIu32
1879 "] pExclusiveScissors (=NULL) is an invalid pointer.",
1880 i, i);
1881 }
1882
Jeff Bolz9af91c52018-09-01 21:53:57 -05001883 if (!has_dynamic_shading_rate_palette_nv && shading_rate_image_struct &&
1884 shading_rate_image_struct->viewportCount > 0 && shading_rate_image_struct->pShadingRatePalettes == nullptr) {
1885 skip |= log_msg(
1886 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, VK_NULL_HANDLE,
1887 "VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-pDynamicStates-02057",
1888 "vkCreateGraphicsPipelines: The shading rate palette state is static (pCreateInfos[%" PRIu32
1889 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_VIEWPORT_SHADING_RATE_PALETTE_NV), but pCreateInfos[%" PRIu32
1890 "] pShadingRatePalettes (=NULL) is an invalid pointer.",
1891 i, i);
1892 }
1893
Petr Krausb3fcdb42018-01-09 22:09:09 +01001894 // validate the VkViewports
1895 if (!has_dynamic_viewport && viewport_state.pViewports) {
1896 for (uint32_t viewport_i = 0; viewport_i < viewport_state.viewportCount; ++viewport_i) {
1897 const auto &viewport = viewport_state.pViewports[viewport_i]; // will crash on invalid ptr
1898 const char fn_name[] = "vkCreateGraphicsPipelines";
1899 const std::string param_name = "pCreateInfos[" + std::to_string(i) + "].pViewportState->pViewports[" +
1900 std::to_string(viewport_i) + "]";
1901 skip |= pv_VkViewport(device_data, viewport, fn_name, param_name.c_str(),
1902 VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT);
1903 }
1904 }
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001905
1906 if (has_dynamic_viewport_w_scaling_nv && !device_data->extensions.vk_nv_clip_space_w_scaling) {
1907 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001908 VK_NULL_HANDLE, kVUID_PVError_ExtensionNotEnabled,
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001909 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
Dave Houltona9df0ce2018-02-07 10:51:23 -07001910 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_VIEWPORT_W_SCALING_NV, but "
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001911 "VK_NV_clip_space_w_scaling extension is not enabled.",
1912 i);
1913 }
1914
1915 if (has_dynamic_discard_rectangle_ext && !device_data->extensions.vk_ext_discard_rectangles) {
1916 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001917 VK_NULL_HANDLE, kVUID_PVError_ExtensionNotEnabled,
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001918 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
Dave Houltona9df0ce2018-02-07 10:51:23 -07001919 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_DISCARD_RECTANGLE_EXT, but "
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001920 "VK_EXT_discard_rectangles extension is not enabled.",
1921 i);
1922 }
1923
1924 if (has_dynamic_sample_locations_ext && !device_data->extensions.vk_ext_sample_locations) {
1925 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001926 VK_NULL_HANDLE, kVUID_PVError_ExtensionNotEnabled,
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001927 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
Dave Houltona9df0ce2018-02-07 10:51:23 -07001928 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_SAMPLE_LOCATIONS_EXT, but "
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001929 "VK_EXT_sample_locations extension is not enabled.",
1930 i);
1931 }
Jeff Bolz3e71f782018-08-29 23:15:45 -05001932
1933 if (has_dynamic_exclusive_scissor_nv && !device_data->extensions.vk_nv_scissor_exclusive) {
1934 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
1935 VK_NULL_HANDLE, kVUID_PVError_ExtensionNotEnabled,
1936 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1937 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV, but "
1938 "VK_NV_scissor_exclusive extension is not enabled.",
1939 i);
1940 }
Jeff Bolz9af91c52018-09-01 21:53:57 -05001941
1942 if (coarse_sample_order_struct &&
1943 coarse_sample_order_struct->sampleOrderType != VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV &&
1944 coarse_sample_order_struct->customSampleOrderCount != 0) {
1945 skip |=
1946 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
1947 VK_NULL_HANDLE, "VUID-VkPipelineViewportCoarseSampleOrderStateCreateInfoNV-sampleOrderType-02072",
1948 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "] "
1949 "VkPipelineViewportCoarseSampleOrderStateCreateInfoNV sampleOrderType is not "
1950 "VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV and customSampleOrderCount is not 0.",
1951 i);
1952 }
1953
1954 if (coarse_sample_order_struct) {
1955 for (uint32_t order_i = 0; order_i < coarse_sample_order_struct->customSampleOrderCount; ++order_i) {
1956 skip |= ValidateCoarseSampleOrderCustomNV(device_data, &coarse_sample_order_struct->pCustomSampleOrders[order_i]);
1957 }
1958 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001959 }
1960
1961 if (pCreateInfos[i].pMultisampleState == nullptr) {
1962 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001963 "VUID-VkGraphicsPipelineCreateInfo-rasterizerDiscardEnable-00751",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001964 "vkCreateGraphicsPipelines: if pCreateInfos[%d].pRasterizationState->rasterizerDiscardEnable "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001965 "is VK_FALSE, pCreateInfos[%d].pMultisampleState must not be NULL.",
1966 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001967 } else {
Dave Houltonb3bbec72018-01-17 10:13:33 -07001968 const VkStructureType valid_next_stypes[] = {LvlTypeMap<VkPipelineCoverageModulationStateCreateInfoNV>::kSType,
1969 LvlTypeMap<VkPipelineCoverageToColorStateCreateInfoNV>::kSType,
1970 LvlTypeMap<VkPipelineSampleLocationsStateCreateInfoEXT>::kSType};
Mike Schuchardt97662b02017-12-06 13:31:29 -07001971 const char *valid_struct_names =
Dave Houltona9df0ce2018-02-07 10:51:23 -07001972 "VkPipelineCoverageModulationStateCreateInfoNV, VkPipelineCoverageToColorStateCreateInfoNV, "
John Zulauf96b0e422017-11-14 11:43:19 -07001973 "VkPipelineSampleLocationsStateCreateInfoEXT";
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001974 skip |= validate_struct_pnext(
1975 report_data, "vkCreateGraphicsPipelines",
John Zulauf96b0e422017-11-14 11:43:19 -07001976 ParameterName("pCreateInfos[%i].pMultisampleState->pNext", ParameterName::IndexVector{i}),
1977 valid_struct_names, pCreateInfos[i].pMultisampleState->pNext, 3, valid_next_stypes, GeneratedHeaderVersion,
Dave Houlton413a6782018-05-22 13:01:54 -06001978 "VUID-VkPipelineMultisampleStateCreateInfo-pNext-pNext");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001979
1980 skip |= validate_reserved_flags(
1981 report_data, "vkCreateGraphicsPipelines",
1982 ParameterName("pCreateInfos[%i].pMultisampleState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06001983 pCreateInfos[i].pMultisampleState->flags, "VUID-VkPipelineMultisampleStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001984
1985 skip |= validate_bool32(
1986 report_data, "vkCreateGraphicsPipelines",
1987 ParameterName("pCreateInfos[%i].pMultisampleState->sampleShadingEnable", ParameterName::IndexVector{i}),
1988 pCreateInfos[i].pMultisampleState->sampleShadingEnable);
1989
1990 skip |= validate_array(
1991 report_data, "vkCreateGraphicsPipelines",
1992 ParameterName("pCreateInfos[%i].pMultisampleState->rasterizationSamples", ParameterName::IndexVector{i}),
1993 ParameterName("pCreateInfos[%i].pMultisampleState->pSampleMask", ParameterName::IndexVector{i}),
Gabríel Arthúr Pétursson092b29b2018-03-21 22:44:11 +00001994 pCreateInfos[i].pMultisampleState->rasterizationSamples, &pCreateInfos[i].pMultisampleState->pSampleMask,
Dave Houlton413a6782018-05-22 13:01:54 -06001995 true, false, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001996
1997 skip |= validate_bool32(
1998 report_data, "vkCreateGraphicsPipelines",
1999 ParameterName("pCreateInfos[%i].pMultisampleState->alphaToCoverageEnable", ParameterName::IndexVector{i}),
2000 pCreateInfos[i].pMultisampleState->alphaToCoverageEnable);
2001
2002 skip |= validate_bool32(
2003 report_data, "vkCreateGraphicsPipelines",
2004 ParameterName("pCreateInfos[%i].pMultisampleState->alphaToOneEnable", ParameterName::IndexVector{i}),
2005 pCreateInfos[i].pMultisampleState->alphaToOneEnable);
2006
2007 if (pCreateInfos[i].pMultisampleState->sType != VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO) {
2008 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002009 kVUID_PVError_InvalidStructSType,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002010 "vkCreateGraphicsPipelines: parameter pCreateInfos[%d].pMultisampleState->sType must be "
2011 "VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO",
2012 i);
2013 }
John Zulauf7acac592017-11-06 11:15:53 -07002014 if (pCreateInfos[i].pMultisampleState->sampleShadingEnable == VK_TRUE) {
2015 if (!device_data->physical_device_features.sampleRateShading) {
2016 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002017 "VUID-VkPipelineMultisampleStateCreateInfo-sampleShadingEnable-00784",
John Zulauf7acac592017-11-06 11:15:53 -07002018 "vkCreateGraphicsPipelines(): parameter "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002019 "pCreateInfos[%d].pMultisampleState->sampleShadingEnable.",
2020 i);
John Zulauf7acac592017-11-06 11:15:53 -07002021 }
2022 // TODO Add documentation issue about when minSampleShading must be in range and when it is ignored
2023 // For now a "least noise" test *only* when sampleShadingEnable is VK_TRUE.
2024 if (!in_inclusive_range(pCreateInfos[i].pMultisampleState->minSampleShading, 0.F, 1.0F)) {
2025 skip |= log_msg(
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002026 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002027 "VUID-VkPipelineMultisampleStateCreateInfo-minSampleShading-00786",
Mark Lobodzinski88529492018-04-01 10:38:15 -06002028 "vkCreateGraphicsPipelines(): parameter pCreateInfos[%d].pMultisampleState->minSampleShading.", i);
John Zulauf7acac592017-11-06 11:15:53 -07002029 }
2030 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002031 }
2032
Petr Krause91f7a12017-12-14 20:57:36 +01002033 bool uses_color_attachment = false;
2034 bool uses_depthstencil_attachment = false;
2035 {
2036 const auto subpasses_uses_it = device_data->renderpasses_states.find(pCreateInfos[i].renderPass);
2037 if (subpasses_uses_it != device_data->renderpasses_states.end()) {
2038 const auto &subpasses_uses = subpasses_uses_it->second;
2039 if (subpasses_uses.subpasses_using_color_attachment.count(pCreateInfos[i].subpass))
2040 uses_color_attachment = true;
2041 if (subpasses_uses.subpasses_using_depthstencil_attachment.count(pCreateInfos[i].subpass))
2042 uses_depthstencil_attachment = true;
2043 }
2044 }
2045
2046 if (pCreateInfos[i].pDepthStencilState != nullptr && uses_depthstencil_attachment) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002047 skip |= validate_struct_pnext(
2048 report_data, "vkCreateGraphicsPipelines",
2049 ParameterName("pCreateInfos[%i].pDepthStencilState->pNext", ParameterName::IndexVector{i}), NULL,
Dave Houlton413a6782018-05-22 13:01:54 -06002050 pCreateInfos[i].pDepthStencilState->pNext, 0, NULL, GeneratedHeaderVersion,
2051 "VUID-VkPipelineDepthStencilStateCreateInfo-pNext-pNext");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002052
2053 skip |= validate_reserved_flags(
2054 report_data, "vkCreateGraphicsPipelines",
2055 ParameterName("pCreateInfos[%i].pDepthStencilState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06002056 pCreateInfos[i].pDepthStencilState->flags, "VUID-VkPipelineDepthStencilStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002057
2058 skip |= validate_bool32(
2059 report_data, "vkCreateGraphicsPipelines",
2060 ParameterName("pCreateInfos[%i].pDepthStencilState->depthTestEnable", ParameterName::IndexVector{i}),
2061 pCreateInfos[i].pDepthStencilState->depthTestEnable);
2062
2063 skip |= validate_bool32(
2064 report_data, "vkCreateGraphicsPipelines",
2065 ParameterName("pCreateInfos[%i].pDepthStencilState->depthWriteEnable", ParameterName::IndexVector{i}),
2066 pCreateInfos[i].pDepthStencilState->depthWriteEnable);
2067
2068 skip |= validate_ranged_enum(
2069 report_data, "vkCreateGraphicsPipelines",
2070 ParameterName("pCreateInfos[%i].pDepthStencilState->depthCompareOp", ParameterName::IndexVector{i}),
2071 "VkCompareOp", AllVkCompareOpEnums, pCreateInfos[i].pDepthStencilState->depthCompareOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002072 "VUID-VkPipelineDepthStencilStateCreateInfo-depthCompareOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002073
2074 skip |= validate_bool32(
2075 report_data, "vkCreateGraphicsPipelines",
2076 ParameterName("pCreateInfos[%i].pDepthStencilState->depthBoundsTestEnable", ParameterName::IndexVector{i}),
2077 pCreateInfos[i].pDepthStencilState->depthBoundsTestEnable);
2078
2079 skip |= validate_bool32(
2080 report_data, "vkCreateGraphicsPipelines",
2081 ParameterName("pCreateInfos[%i].pDepthStencilState->stencilTestEnable", ParameterName::IndexVector{i}),
2082 pCreateInfos[i].pDepthStencilState->stencilTestEnable);
2083
2084 skip |= validate_ranged_enum(
2085 report_data, "vkCreateGraphicsPipelines",
2086 ParameterName("pCreateInfos[%i].pDepthStencilState->front.failOp", ParameterName::IndexVector{i}),
2087 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->front.failOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002088 "VUID-VkStencilOpState-failOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002089
2090 skip |= validate_ranged_enum(
2091 report_data, "vkCreateGraphicsPipelines",
2092 ParameterName("pCreateInfos[%i].pDepthStencilState->front.passOp", ParameterName::IndexVector{i}),
2093 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->front.passOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002094 "VUID-VkStencilOpState-passOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002095
2096 skip |= validate_ranged_enum(
2097 report_data, "vkCreateGraphicsPipelines",
2098 ParameterName("pCreateInfos[%i].pDepthStencilState->front.depthFailOp", ParameterName::IndexVector{i}),
2099 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->front.depthFailOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002100 "VUID-VkStencilOpState-depthFailOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002101
2102 skip |= validate_ranged_enum(
2103 report_data, "vkCreateGraphicsPipelines",
2104 ParameterName("pCreateInfos[%i].pDepthStencilState->front.compareOp", ParameterName::IndexVector{i}),
2105 "VkCompareOp", AllVkCompareOpEnums, pCreateInfos[i].pDepthStencilState->front.compareOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002106 "VUID-VkPipelineDepthStencilStateCreateInfo-depthCompareOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002107
2108 skip |= validate_ranged_enum(
2109 report_data, "vkCreateGraphicsPipelines",
2110 ParameterName("pCreateInfos[%i].pDepthStencilState->back.failOp", ParameterName::IndexVector{i}),
2111 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->back.failOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002112 "VUID-VkStencilOpState-failOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002113
2114 skip |= validate_ranged_enum(
2115 report_data, "vkCreateGraphicsPipelines",
2116 ParameterName("pCreateInfos[%i].pDepthStencilState->back.passOp", ParameterName::IndexVector{i}),
2117 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->back.passOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002118 "VUID-VkStencilOpState-passOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002119
2120 skip |= validate_ranged_enum(
2121 report_data, "vkCreateGraphicsPipelines",
2122 ParameterName("pCreateInfos[%i].pDepthStencilState->back.depthFailOp", ParameterName::IndexVector{i}),
2123 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->back.depthFailOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002124 "VUID-VkStencilOpState-depthFailOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002125
2126 skip |= validate_ranged_enum(
2127 report_data, "vkCreateGraphicsPipelines",
2128 ParameterName("pCreateInfos[%i].pDepthStencilState->back.compareOp", ParameterName::IndexVector{i}),
2129 "VkCompareOp", AllVkCompareOpEnums, pCreateInfos[i].pDepthStencilState->back.compareOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002130 "VUID-VkPipelineDepthStencilStateCreateInfo-depthCompareOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002131
2132 if (pCreateInfos[i].pDepthStencilState->sType != VK_STRUCTURE_TYPE_PIPELINE_DEPTH_STENCIL_STATE_CREATE_INFO) {
2133 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002134 kVUID_PVError_InvalidStructSType,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002135 "vkCreateGraphicsPipelines: parameter pCreateInfos[%d].pDepthStencilState->sType must be "
2136 "VK_STRUCTURE_TYPE_PIPELINE_DEPTH_STENCIL_STATE_CREATE_INFO",
2137 i);
2138 }
2139 }
2140
Petr Krause91f7a12017-12-14 20:57:36 +01002141 if (pCreateInfos[i].pColorBlendState != nullptr && uses_color_attachment) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002142 skip |= validate_struct_pnext(
2143 report_data, "vkCreateGraphicsPipelines",
2144 ParameterName("pCreateInfos[%i].pColorBlendState->pNext", ParameterName::IndexVector{i}), NULL,
Dave Houlton413a6782018-05-22 13:01:54 -06002145 pCreateInfos[i].pColorBlendState->pNext, 0, NULL, GeneratedHeaderVersion,
2146 "VUID-VkPipelineColorBlendStateCreateInfo-pNext-pNext");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002147
2148 skip |= validate_reserved_flags(
2149 report_data, "vkCreateGraphicsPipelines",
2150 ParameterName("pCreateInfos[%i].pColorBlendState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06002151 pCreateInfos[i].pColorBlendState->flags, "VUID-VkPipelineColorBlendStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002152
2153 skip |= validate_bool32(
2154 report_data, "vkCreateGraphicsPipelines",
2155 ParameterName("pCreateInfos[%i].pColorBlendState->logicOpEnable", ParameterName::IndexVector{i}),
2156 pCreateInfos[i].pColorBlendState->logicOpEnable);
2157
2158 skip |= validate_array(
2159 report_data, "vkCreateGraphicsPipelines",
2160 ParameterName("pCreateInfos[%i].pColorBlendState->attachmentCount", ParameterName::IndexVector{i}),
2161 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments", ParameterName::IndexVector{i}),
Gabríel Arthúr Pétursson092b29b2018-03-21 22:44:11 +00002162 pCreateInfos[i].pColorBlendState->attachmentCount, &pCreateInfos[i].pColorBlendState->pAttachments, false,
Dave Houlton413a6782018-05-22 13:01:54 -06002163 true, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002164
2165 if (pCreateInfos[i].pColorBlendState->pAttachments != NULL) {
2166 for (uint32_t attachmentIndex = 0; attachmentIndex < pCreateInfos[i].pColorBlendState->attachmentCount;
2167 ++attachmentIndex) {
2168 skip |= validate_bool32(report_data, "vkCreateGraphicsPipelines",
2169 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].blendEnable",
2170 ParameterName::IndexVector{i, attachmentIndex}),
2171 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].blendEnable);
2172
2173 skip |= validate_ranged_enum(
2174 report_data, "vkCreateGraphicsPipelines",
2175 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].srcColorBlendFactor",
2176 ParameterName::IndexVector{i, attachmentIndex}),
2177 "VkBlendFactor", AllVkBlendFactorEnums,
2178 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].srcColorBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06002179 "VUID-VkPipelineColorBlendAttachmentState-srcColorBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002180
2181 skip |= validate_ranged_enum(
2182 report_data, "vkCreateGraphicsPipelines",
2183 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].dstColorBlendFactor",
2184 ParameterName::IndexVector{i, attachmentIndex}),
2185 "VkBlendFactor", AllVkBlendFactorEnums,
2186 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].dstColorBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06002187 "VUID-VkPipelineColorBlendAttachmentState-dstColorBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002188
2189 skip |= validate_ranged_enum(
2190 report_data, "vkCreateGraphicsPipelines",
2191 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].colorBlendOp",
2192 ParameterName::IndexVector{i, attachmentIndex}),
2193 "VkBlendOp", AllVkBlendOpEnums,
2194 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].colorBlendOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002195 "VUID-VkPipelineColorBlendAttachmentState-colorBlendOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002196
2197 skip |= validate_ranged_enum(
2198 report_data, "vkCreateGraphicsPipelines",
2199 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].srcAlphaBlendFactor",
2200 ParameterName::IndexVector{i, attachmentIndex}),
2201 "VkBlendFactor", AllVkBlendFactorEnums,
2202 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].srcAlphaBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06002203 "VUID-VkPipelineColorBlendAttachmentState-srcAlphaBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002204
2205 skip |= validate_ranged_enum(
2206 report_data, "vkCreateGraphicsPipelines",
2207 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].dstAlphaBlendFactor",
2208 ParameterName::IndexVector{i, attachmentIndex}),
2209 "VkBlendFactor", AllVkBlendFactorEnums,
2210 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].dstAlphaBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06002211 "VUID-VkPipelineColorBlendAttachmentState-dstAlphaBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002212
2213 skip |= validate_ranged_enum(
2214 report_data, "vkCreateGraphicsPipelines",
2215 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].alphaBlendOp",
2216 ParameterName::IndexVector{i, attachmentIndex}),
2217 "VkBlendOp", AllVkBlendOpEnums,
2218 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].alphaBlendOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002219 "VUID-VkPipelineColorBlendAttachmentState-alphaBlendOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002220
2221 skip |=
2222 validate_flags(report_data, "vkCreateGraphicsPipelines",
2223 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].colorWriteMask",
2224 ParameterName::IndexVector{i, attachmentIndex}),
2225 "VkColorComponentFlagBits", AllVkColorComponentFlagBits,
2226 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].colorWriteMask,
Dave Houlton413a6782018-05-22 13:01:54 -06002227 false, false, "VUID-VkPipelineColorBlendAttachmentState-colorWriteMask-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002228 }
2229 }
2230
2231 if (pCreateInfos[i].pColorBlendState->sType != VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO) {
2232 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002233 kVUID_PVError_InvalidStructSType,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002234 "vkCreateGraphicsPipelines: parameter pCreateInfos[%d].pColorBlendState->sType must be "
2235 "VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO",
2236 i);
2237 }
2238
2239 // If logicOpEnable is VK_TRUE, logicOp must be a valid VkLogicOp value
2240 if (pCreateInfos[i].pColorBlendState->logicOpEnable == VK_TRUE) {
2241 skip |= validate_ranged_enum(
2242 report_data, "vkCreateGraphicsPipelines",
2243 ParameterName("pCreateInfos[%i].pColorBlendState->logicOp", ParameterName::IndexVector{i}), "VkLogicOp",
Dave Houlton413a6782018-05-22 13:01:54 -06002244 AllVkLogicOpEnums, pCreateInfos[i].pColorBlendState->logicOp,
2245 "VUID-VkPipelineColorBlendStateCreateInfo-logicOpEnable-00607");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002246 }
2247 }
2248 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002249
Petr Kraus9752aae2017-11-24 03:05:50 +01002250 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_DERIVATIVE_BIT) {
2251 if (pCreateInfos[i].basePipelineIndex != -1) {
2252 if (pCreateInfos[i].basePipelineHandle != VK_NULL_HANDLE) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07002253 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002254 "VUID-VkGraphicsPipelineCreateInfo-flags-00724",
Dave Houltona9df0ce2018-02-07 10:51:23 -07002255 "vkCreateGraphicsPipelines parameter, pCreateInfos->basePipelineHandle, must be "
2256 "VK_NULL_HANDLE if pCreateInfos->flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT flag "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002257 "and pCreateInfos->basePipelineIndex is not -1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002258 }
2259 }
2260
Petr Kraus9752aae2017-11-24 03:05:50 +01002261 if (pCreateInfos[i].basePipelineHandle != VK_NULL_HANDLE) {
2262 if (pCreateInfos[i].basePipelineIndex != -1) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07002263 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002264 "VUID-VkGraphicsPipelineCreateInfo-flags-00725",
Dave Houltona9df0ce2018-02-07 10:51:23 -07002265 "vkCreateGraphicsPipelines parameter, pCreateInfos->basePipelineIndex, must be -1 if "
2266 "pCreateInfos->flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT flag and "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002267 "pCreateInfos->basePipelineHandle is not VK_NULL_HANDLE.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002268 }
2269 }
2270 }
2271
Petr Kraus9752aae2017-11-24 03:05:50 +01002272 if (pCreateInfos[i].pRasterizationState) {
2273 if ((pCreateInfos[i].pRasterizationState->polygonMode != VK_POLYGON_MODE_FILL) &&
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002274 (device_data->physical_device_features.fillModeNonSolid == false)) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07002275 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002276 kVUID_PVError_DeviceFeature,
Dave Houltona9df0ce2018-02-07 10:51:23 -07002277 "vkCreateGraphicsPipelines parameter, VkPolygonMode "
2278 "pCreateInfos->pRasterizationState->polygonMode cannot be VK_POLYGON_MODE_POINT or "
2279 "VK_POLYGON_MODE_LINE if VkPhysicalDeviceFeatures->fillModeNonSolid is false.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002280 }
Petr Kraus299ba622017-11-24 03:09:03 +01002281
2282 if (!has_dynamic_line_width && !device_data->physical_device_features.wideLines &&
2283 (pCreateInfos[i].pRasterizationState->lineWidth != 1.0f)) {
Dave Houlton413a6782018-05-22 13:01:54 -06002284 skip |=
2285 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
2286 0, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-00749",
2287 "The line width state is static (pCreateInfos[%" PRIu32
2288 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_LINE_WIDTH) and "
2289 "VkPhysicalDeviceFeatures::wideLines is disabled, but pCreateInfos[%" PRIu32
2290 "].pRasterizationState->lineWidth (=%f) is not 1.0.",
2291 i, i, pCreateInfos[i].pRasterizationState->lineWidth);
Petr Kraus299ba622017-11-24 03:09:03 +01002292 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002293 }
2294
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002295 for (size_t j = 0; j < pCreateInfos[i].stageCount; j++) {
2296 skip |= validate_string(device_data->report_data, "vkCreateGraphicsPipelines",
2297 ParameterName("pCreateInfos[%i].pStages[%i].pName", ParameterName::IndexVector{i, j}),
Mark Lobodzinskiebee3552018-05-29 09:55:54 -06002298 "VUID-VkGraphicsPipelineCreateInfo-pStages-parameter", pCreateInfos[i].pStages[j].pName);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002299 }
2300 }
2301 }
2302
2303 return skip;
2304}
2305
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002306bool pv_vkCreateComputePipelines(VkDevice device, VkPipelineCache pipelineCache, uint32_t createInfoCount,
2307 const VkComputePipelineCreateInfo *pCreateInfos, const VkAllocationCallbacks *pAllocator,
2308 VkPipeline *pPipelines) {
2309 bool skip = false;
2310 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2311
2312 for (uint32_t i = 0; i < createInfoCount; i++) {
2313 skip |= validate_string(device_data->report_data, "vkCreateComputePipelines",
2314 ParameterName("pCreateInfos[%i].stage.pName", ParameterName::IndexVector{i}),
Mark Lobodzinskiebee3552018-05-29 09:55:54 -06002315 "VUID-VkPipelineShaderStageCreateInfo-pName-parameter", pCreateInfos[i].stage.pName);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002316 }
2317
2318 return skip;
2319}
2320
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002321bool pv_vkCreateSampler(VkDevice device, const VkSamplerCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
2322 VkSampler *pSampler) {
2323 bool skip = false;
2324 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2325 debug_report_data *report_data = device_data->report_data;
2326
2327 if (pCreateInfo != nullptr) {
John Zulauf71968502017-10-26 13:51:15 -06002328 const auto &features = device_data->physical_device_features;
2329 const auto &limits = device_data->device_limits;
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002330
John Zulauf71968502017-10-26 13:51:15 -06002331 if (pCreateInfo->anisotropyEnable == VK_TRUE) {
2332 if (!in_inclusive_range(pCreateInfo->maxAnisotropy, 1.0F, limits.maxSamplerAnisotropy)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002333 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002334 "VUID-VkSamplerCreateInfo-anisotropyEnable-01071",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002335 "vkCreateSampler(): value of %s must be in range [1.0, %f] %s, but %f found.",
John Zulauf71968502017-10-26 13:51:15 -06002336 "pCreateInfo->maxAnisotropy", limits.maxSamplerAnisotropy,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002337 "VkPhysicalDeviceLimits::maxSamplerAnistropy", pCreateInfo->maxAnisotropy);
John Zulauf71968502017-10-26 13:51:15 -06002338 }
2339
2340 // Anistropy cannot be enabled in sampler unless enabled as a feature
2341 if (features.samplerAnisotropy == VK_FALSE) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002342 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002343 "VUID-VkSamplerCreateInfo-anisotropyEnable-01070",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002344 "vkCreateSampler(): Anisotropic sampling feature is not enabled, %s must be VK_FALSE.",
2345 "pCreateInfo->anisotropyEnable");
John Zulauf71968502017-10-26 13:51:15 -06002346 }
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002347 }
John Zulauf71968502017-10-26 13:51:15 -06002348
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002349 if (pCreateInfo->unnormalizedCoordinates == VK_TRUE) {
2350 if (pCreateInfo->minFilter != pCreateInfo->magFilter) {
2351 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
2352 "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01072",
2353 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
2354 "pCreateInfo->minFilter (%s) and pCreateInfo->magFilter (%s) must be equal.",
2355 string_VkFilter(pCreateInfo->minFilter), string_VkFilter(pCreateInfo->magFilter));
2356 }
2357 if (pCreateInfo->mipmapMode != VK_SAMPLER_MIPMAP_MODE_NEAREST) {
2358 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
2359 "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01073",
2360 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
2361 "pCreateInfo->mipmapMode (%s) must be VK_SAMPLER_MIPMAP_MODE_NEAREST.",
2362 string_VkSamplerMipmapMode(pCreateInfo->mipmapMode));
2363 }
2364 if (pCreateInfo->minLod != 0.0f || pCreateInfo->maxLod != 0.0f) {
2365 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
2366 "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01074",
2367 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
2368 "pCreateInfo->minLod (%f) and pCreateInfo->maxLod (%f) must both be zero.",
2369 pCreateInfo->minLod, pCreateInfo->maxLod);
2370 }
2371 if ((pCreateInfo->addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE &&
2372 pCreateInfo->addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER) ||
2373 (pCreateInfo->addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE &&
2374 pCreateInfo->addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER)) {
2375 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
2376 "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01075",
2377 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
2378 "pCreateInfo->addressModeU (%s) and pCreateInfo->addressModeV (%s) must both be "
2379 "VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE or VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER.",
2380 string_VkSamplerAddressMode(pCreateInfo->addressModeU),
2381 string_VkSamplerAddressMode(pCreateInfo->addressModeV));
2382 }
2383 if (pCreateInfo->anisotropyEnable == VK_TRUE) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002384 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002385 "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01076",
Dave Houltona9df0ce2018-02-07 10:51:23 -07002386 "vkCreateSampler(): pCreateInfo->anisotropyEnable and pCreateInfo->unnormalizedCoordinates must "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002387 "not both be VK_TRUE.");
John Zulauf71968502017-10-26 13:51:15 -06002388 }
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002389 if (pCreateInfo->compareEnable == VK_TRUE) {
2390 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
2391 "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01077",
2392 "vkCreateSampler(): pCreateInfo->compareEnable and pCreateInfo->unnormalizedCoordinates must "
2393 "not both be VK_TRUE.");
2394 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002395 }
2396
2397 // If compareEnable is VK_TRUE, compareOp must be a valid VkCompareOp value
2398 if (pCreateInfo->compareEnable == VK_TRUE) {
Dave Houlton413a6782018-05-22 13:01:54 -06002399 skip |=
2400 validate_ranged_enum(report_data, "vkCreateSampler", "pCreateInfo->compareOp", "VkCompareOp", AllVkCompareOpEnums,
2401 pCreateInfo->compareOp, "VUID-VkSamplerCreateInfo-compareEnable-01080");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002402 }
2403
2404 // If any of addressModeU, addressModeV or addressModeW are VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER, borderColor must be a
2405 // valid VkBorderColor value
2406 if ((pCreateInfo->addressModeU == VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER) ||
2407 (pCreateInfo->addressModeV == VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER) ||
2408 (pCreateInfo->addressModeW == VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER)) {
2409 skip |= validate_ranged_enum(report_data, "vkCreateSampler", "pCreateInfo->borderColor", "VkBorderColor",
Dave Houlton413a6782018-05-22 13:01:54 -06002410 AllVkBorderColorEnums, pCreateInfo->borderColor,
2411 "VUID-VkSamplerCreateInfo-addressModeU-01078");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002412 }
2413
2414 // If any of addressModeU, addressModeV or addressModeW are VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE, the
2415 // VK_KHR_sampler_mirror_clamp_to_edge extension must be enabled
2416 if (!device_data->extensions.vk_khr_sampler_mirror_clamp_to_edge &&
2417 ((pCreateInfo->addressModeU == VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE) ||
2418 (pCreateInfo->addressModeV == VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE) ||
2419 (pCreateInfo->addressModeW == VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE))) {
Dave Houlton413a6782018-05-22 13:01:54 -06002420 skip |=
2421 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
2422 "VUID-VkSamplerCreateInfo-addressModeU-01079",
2423 "vkCreateSampler(): A VkSamplerAddressMode value is set to VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE "
2424 "but the VK_KHR_sampler_mirror_clamp_to_edge extension has not been enabled.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002425 }
John Zulauf275805c2017-10-26 15:34:49 -06002426
2427 // Checks for the IMG cubic filtering extension
2428 if (device_data->extensions.vk_img_filter_cubic) {
2429 if ((pCreateInfo->anisotropyEnable == VK_TRUE) &&
2430 ((pCreateInfo->minFilter == VK_FILTER_CUBIC_IMG) || (pCreateInfo->magFilter == VK_FILTER_CUBIC_IMG))) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002431 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002432 "VUID-VkSamplerCreateInfo-magFilter-01081",
Dave Houltona9df0ce2018-02-07 10:51:23 -07002433 "vkCreateSampler(): Anisotropic sampling must not be VK_TRUE when either minFilter or magFilter "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002434 "are VK_FILTER_CUBIC_IMG.");
John Zulauf275805c2017-10-26 15:34:49 -06002435 }
2436 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002437 }
2438
2439 return skip;
2440}
2441
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002442bool pv_vkCreateDescriptorSetLayout(VkDevice device, const VkDescriptorSetLayoutCreateInfo *pCreateInfo,
2443 const VkAllocationCallbacks *pAllocator, VkDescriptorSetLayout *pSetLayout) {
2444 bool skip = false;
2445 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2446 debug_report_data *report_data = device_data->report_data;
2447
2448 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
2449 if ((pCreateInfo != nullptr) && (pCreateInfo->pBindings != nullptr)) {
2450 for (uint32_t i = 0; i < pCreateInfo->bindingCount; ++i) {
2451 if (pCreateInfo->pBindings[i].descriptorCount != 0) {
2452 // If descriptorType is VK_DESCRIPTOR_TYPE_SAMPLER or VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER, and descriptorCount
2453 // is not 0 and pImmutableSamplers is not NULL, pImmutableSamplers must be a pointer to an array of descriptorCount
2454 // valid VkSampler handles
2455 if (((pCreateInfo->pBindings[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLER) ||
2456 (pCreateInfo->pBindings[i].descriptorType == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER)) &&
2457 (pCreateInfo->pBindings[i].pImmutableSamplers != nullptr)) {
2458 for (uint32_t descriptor_index = 0; descriptor_index < pCreateInfo->pBindings[i].descriptorCount;
2459 ++descriptor_index) {
2460 if (pCreateInfo->pBindings[i].pImmutableSamplers[descriptor_index] == VK_NULL_HANDLE) {
2461 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002462 kVUID_PVError_RequiredParameter,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002463 "vkCreateDescriptorSetLayout: required parameter "
Dave Houltona9df0ce2018-02-07 10:51:23 -07002464 "pCreateInfo->pBindings[%d].pImmutableSamplers[%d] specified as VK_NULL_HANDLE",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002465 i, descriptor_index);
2466 }
2467 }
2468 }
2469
2470 // If descriptorCount is not 0, stageFlags must be a valid combination of VkShaderStageFlagBits values
2471 if ((pCreateInfo->pBindings[i].stageFlags != 0) &&
2472 ((pCreateInfo->pBindings[i].stageFlags & (~AllVkShaderStageFlagBits)) != 0)) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07002473 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002474 "VUID-VkDescriptorSetLayoutBinding-descriptorCount-00283",
Dave Houltona9df0ce2018-02-07 10:51:23 -07002475 "vkCreateDescriptorSetLayout(): if pCreateInfo->pBindings[%d].descriptorCount is not 0, "
2476 "pCreateInfo->pBindings[%d].stageFlags must be a valid combination of VkShaderStageFlagBits "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002477 "values.",
2478 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002479 }
2480 }
2481 }
2482 }
2483
2484 return skip;
2485}
2486
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002487bool pv_vkFreeDescriptorSets(VkDevice device, VkDescriptorPool descriptorPool, uint32_t descriptorSetCount,
2488 const VkDescriptorSet *pDescriptorSets) {
2489 bool skip = false;
2490 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2491 debug_report_data *report_data = device_data->report_data;
2492
2493 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
2494 // This is an array of handles, where the elements are allowed to be VK_NULL_HANDLE, and does not require any validation beyond
2495 // validate_array()
2496 skip |= validate_array(report_data, "vkFreeDescriptorSets", "descriptorSetCount", "pDescriptorSets", descriptorSetCount,
Dave Houlton413a6782018-05-22 13:01:54 -06002497 &pDescriptorSets, true, true, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002498 return skip;
2499}
2500
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002501bool pv_vkUpdateDescriptorSets(VkDevice device, uint32_t descriptorWriteCount, const VkWriteDescriptorSet *pDescriptorWrites,
2502 uint32_t descriptorCopyCount, const VkCopyDescriptorSet *pDescriptorCopies) {
2503 bool skip = false;
2504 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2505 debug_report_data *report_data = device_data->report_data;
2506
2507 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
2508 if (pDescriptorWrites != NULL) {
2509 for (uint32_t i = 0; i < descriptorWriteCount; ++i) {
2510 // descriptorCount must be greater than 0
2511 if (pDescriptorWrites[i].descriptorCount == 0) {
2512 skip |=
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002513 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002514 "VUID-VkWriteDescriptorSet-descriptorCount-arraylength",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002515 "vkUpdateDescriptorSets(): parameter pDescriptorWrites[%d].descriptorCount must be greater than 0.", i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002516 }
2517
2518 // dstSet must be a valid VkDescriptorSet handle
2519 skip |= validate_required_handle(report_data, "vkUpdateDescriptorSets",
2520 ParameterName("pDescriptorWrites[%i].dstSet", ParameterName::IndexVector{i}),
2521 pDescriptorWrites[i].dstSet);
2522
2523 if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLER) ||
2524 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER) ||
2525 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE) ||
2526 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_IMAGE) ||
2527 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT)) {
2528 // If descriptorType is VK_DESCRIPTOR_TYPE_SAMPLER, VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER,
2529 // VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE, VK_DESCRIPTOR_TYPE_STORAGE_IMAGE or VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT,
2530 // pImageInfo must be a pointer to an array of descriptorCount valid VkDescriptorImageInfo structures
2531 if (pDescriptorWrites[i].pImageInfo == nullptr) {
2532 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002533 "VUID-VkWriteDescriptorSet-descriptorType-00322",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002534 "vkUpdateDescriptorSets(): if pDescriptorWrites[%d].descriptorType is "
2535 "VK_DESCRIPTOR_TYPE_SAMPLER, VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER, "
2536 "VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE, VK_DESCRIPTOR_TYPE_STORAGE_IMAGE or "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002537 "VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT, pDescriptorWrites[%d].pImageInfo must not be NULL.",
2538 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002539 } else if (pDescriptorWrites[i].descriptorType != VK_DESCRIPTOR_TYPE_SAMPLER) {
2540 // If descriptorType is VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER, VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE,
2541 // VK_DESCRIPTOR_TYPE_STORAGE_IMAGE or VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT, the imageView and imageLayout
2542 // members of any given element of pImageInfo must be a valid VkImageView and VkImageLayout, respectively
2543 for (uint32_t descriptor_index = 0; descriptor_index < pDescriptorWrites[i].descriptorCount;
2544 ++descriptor_index) {
2545 skip |= validate_required_handle(report_data, "vkUpdateDescriptorSets",
2546 ParameterName("pDescriptorWrites[%i].pImageInfo[%i].imageView",
2547 ParameterName::IndexVector{i, descriptor_index}),
2548 pDescriptorWrites[i].pImageInfo[descriptor_index].imageView);
2549 skip |= validate_ranged_enum(report_data, "vkUpdateDescriptorSets",
2550 ParameterName("pDescriptorWrites[%i].pImageInfo[%i].imageLayout",
2551 ParameterName::IndexVector{i, descriptor_index}),
2552 "VkImageLayout", AllVkImageLayoutEnums,
Dave Houlton413a6782018-05-22 13:01:54 -06002553 pDescriptorWrites[i].pImageInfo[descriptor_index].imageLayout, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002554 }
2555 }
2556 } else if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER) ||
2557 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER) ||
2558 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC) ||
2559 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC)) {
2560 // If descriptorType is VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER, VK_DESCRIPTOR_TYPE_STORAGE_BUFFER,
2561 // VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC or VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC, pBufferInfo must be a
2562 // pointer to an array of descriptorCount valid VkDescriptorBufferInfo structures
2563 if (pDescriptorWrites[i].pBufferInfo == nullptr) {
2564 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002565 "VUID-VkWriteDescriptorSet-descriptorType-00324",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002566 "vkUpdateDescriptorSets(): if pDescriptorWrites[%d].descriptorType is "
2567 "VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER, VK_DESCRIPTOR_TYPE_STORAGE_BUFFER, "
2568 "VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC or VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC, "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002569 "pDescriptorWrites[%d].pBufferInfo must not be NULL.",
2570 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002571 } else {
2572 for (uint32_t descriptorIndex = 0; descriptorIndex < pDescriptorWrites[i].descriptorCount; ++descriptorIndex) {
2573 skip |= validate_required_handle(report_data, "vkUpdateDescriptorSets",
2574 ParameterName("pDescriptorWrites[%i].pBufferInfo[%i].buffer",
2575 ParameterName::IndexVector{i, descriptorIndex}),
2576 pDescriptorWrites[i].pBufferInfo[descriptorIndex].buffer);
2577 }
2578 }
2579 } else if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER) ||
2580 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER)) {
2581 // If descriptorType is VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER or VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER,
2582 // pTexelBufferView must be a pointer to an array of descriptorCount valid VkBufferView handles
2583 if (pDescriptorWrites[i].pTexelBufferView == nullptr) {
2584 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002585 "VUID-VkWriteDescriptorSet-descriptorType-00323",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002586 "vkUpdateDescriptorSets(): if pDescriptorWrites[%d].descriptorType is "
2587 "VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER or VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER, "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002588 "pDescriptorWrites[%d].pTexelBufferView must not be NULL.",
2589 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002590 } else {
2591 for (uint32_t descriptor_index = 0; descriptor_index < pDescriptorWrites[i].descriptorCount;
2592 ++descriptor_index) {
2593 skip |= validate_required_handle(report_data, "vkUpdateDescriptorSets",
2594 ParameterName("pDescriptorWrites[%i].pTexelBufferView[%i]",
2595 ParameterName::IndexVector{i, descriptor_index}),
2596 pDescriptorWrites[i].pTexelBufferView[descriptor_index]);
2597 }
2598 }
2599 }
2600
2601 if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER) ||
2602 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC)) {
2603 VkDeviceSize uniformAlignment = device_data->device_limits.minUniformBufferOffsetAlignment;
2604 for (uint32_t j = 0; j < pDescriptorWrites[i].descriptorCount; j++) {
2605 if (pDescriptorWrites[i].pBufferInfo != NULL) {
2606 if (SafeModulo(pDescriptorWrites[i].pBufferInfo[j].offset, uniformAlignment) != 0) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06002607 skip |=
2608 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002609 VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0,
2610 "VUID-VkWriteDescriptorSet-descriptorType-00327",
Mark Lobodzinski88529492018-04-01 10:38:15 -06002611 "vkUpdateDescriptorSets(): pDescriptorWrites[%d].pBufferInfo[%d].offset (0x%" PRIxLEAST64
2612 ") must be a multiple of device limit minUniformBufferOffsetAlignment 0x%" PRIxLEAST64 ".",
2613 i, j, pDescriptorWrites[i].pBufferInfo[j].offset, uniformAlignment);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002614 }
2615 }
2616 }
2617 } else if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER) ||
2618 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC)) {
2619 VkDeviceSize storageAlignment = device_data->device_limits.minStorageBufferOffsetAlignment;
2620 for (uint32_t j = 0; j < pDescriptorWrites[i].descriptorCount; j++) {
2621 if (pDescriptorWrites[i].pBufferInfo != NULL) {
2622 if (SafeModulo(pDescriptorWrites[i].pBufferInfo[j].offset, storageAlignment) != 0) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06002623 skip |=
2624 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002625 VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0,
2626 "VUID-VkWriteDescriptorSet-descriptorType-00328",
Mark Lobodzinski88529492018-04-01 10:38:15 -06002627 "vkUpdateDescriptorSets(): pDescriptorWrites[%d].pBufferInfo[%d].offset (0x%" PRIxLEAST64
2628 ") must be a multiple of device limit minStorageBufferOffsetAlignment 0x%" PRIxLEAST64 ".",
2629 i, j, pDescriptorWrites[i].pBufferInfo[j].offset, storageAlignment);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002630 }
2631 }
2632 }
2633 }
2634 }
2635 }
2636 return skip;
2637}
2638
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002639bool pv_vkCreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
2640 VkRenderPass *pRenderPass) {
2641 bool skip = false;
2642 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2643 uint32_t max_color_attachments = device_data->device_limits.maxColorAttachments;
2644
2645 for (uint32_t i = 0; i < pCreateInfo->attachmentCount; ++i) {
2646 if (pCreateInfo->pAttachments[i].format == VK_FORMAT_UNDEFINED) {
2647 std::stringstream ss;
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002648 ss << "vkCreateRenderPass: pCreateInfo->pAttachments[" << i << "].format is VK_FORMAT_UNDEFINED. ";
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002649 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002650 "VUID-VkAttachmentDescription-format-parameter", "%s", ss.str().c_str());
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002651 }
2652 if (pCreateInfo->pAttachments[i].finalLayout == VK_IMAGE_LAYOUT_UNDEFINED ||
2653 pCreateInfo->pAttachments[i].finalLayout == VK_IMAGE_LAYOUT_PREINITIALIZED) {
2654 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002655 "VUID-VkAttachmentDescription-finalLayout-00843",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002656 "pCreateInfo->pAttachments[%d].finalLayout must not be VK_IMAGE_LAYOUT_UNDEFINED or "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002657 "VK_IMAGE_LAYOUT_PREINITIALIZED.",
2658 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002659 }
2660 }
2661
2662 for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) {
2663 if (pCreateInfo->pSubpasses[i].colorAttachmentCount > max_color_attachments) {
2664 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002665 "VUID-VkSubpassDescription-colorAttachmentCount-00845",
2666 "Cannot create a render pass with %d color attachments. Max is %d.",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002667 pCreateInfo->pSubpasses[i].colorAttachmentCount, max_color_attachments);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002668 }
2669 }
2670 return skip;
2671}
2672
2673bool pv_vkFreeCommandBuffers(VkDevice device, VkCommandPool commandPool, uint32_t commandBufferCount,
2674 const VkCommandBuffer *pCommandBuffers) {
2675 bool skip = false;
2676 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2677 debug_report_data *report_data = device_data->report_data;
2678
2679 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
2680 // This is an array of handles, where the elements are allowed to be VK_NULL_HANDLE, and does not require any validation beyond
2681 // validate_array()
2682 skip |= validate_array(report_data, "vkFreeCommandBuffers", "commandBufferCount", "pCommandBuffers", commandBufferCount,
Dave Houlton413a6782018-05-22 13:01:54 -06002683 &pCommandBuffers, true, true, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002684 return skip;
2685}
2686
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002687bool pv_vkBeginCommandBuffer(VkCommandBuffer commandBuffer, const VkCommandBufferBeginInfo *pBeginInfo) {
2688 bool skip = false;
2689 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2690 debug_report_data *report_data = device_data->report_data;
2691 const VkCommandBufferInheritanceInfo *pInfo = pBeginInfo->pInheritanceInfo;
2692
2693 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
2694 // TODO: pBeginInfo->pInheritanceInfo must not be NULL if commandBuffer is a secondary command buffer
2695 skip |= validate_struct_type(report_data, "vkBeginCommandBuffer", "pBeginInfo->pInheritanceInfo",
2696 "VK_STRUCTURE_TYPE_COMMAND_BUFFER_INHERITANCE_INFO", pBeginInfo->pInheritanceInfo,
Mark Lobodzinskia16ebc72018-06-15 14:47:39 -06002697 VK_STRUCTURE_TYPE_COMMAND_BUFFER_INHERITANCE_INFO, false,
2698 "VUID_vkBeginCommandBuffer-pBeginInfo-parameter", "VUID_VkCommandBufferBeginInfo-sType-sType");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002699
2700 if (pBeginInfo->pInheritanceInfo != NULL) {
Dave Houlton413a6782018-05-22 13:01:54 -06002701 skip |= validate_struct_pnext(report_data, "vkBeginCommandBuffer", "pBeginInfo->pInheritanceInfo->pNext", NULL,
2702 pBeginInfo->pInheritanceInfo->pNext, 0, NULL, GeneratedHeaderVersion,
2703 "VUID-VkCommandBufferBeginInfo-pNext-pNext");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002704
2705 skip |= validate_bool32(report_data, "vkBeginCommandBuffer", "pBeginInfo->pInheritanceInfo->occlusionQueryEnable",
2706 pBeginInfo->pInheritanceInfo->occlusionQueryEnable);
2707
2708 // TODO: This only needs to be validated when the inherited queries feature is enabled
2709 // skip |= validate_flags(report_data, "vkBeginCommandBuffer", "pBeginInfo->pInheritanceInfo->queryFlags",
2710 // "VkQueryControlFlagBits", AllVkQueryControlFlagBits, pBeginInfo->pInheritanceInfo->queryFlags, false);
2711
2712 // TODO: This must be 0 if the pipeline statistics queries feature is not enabled
2713 skip |= validate_flags(report_data, "vkBeginCommandBuffer", "pBeginInfo->pInheritanceInfo->pipelineStatistics",
2714 "VkQueryPipelineStatisticFlagBits", AllVkQueryPipelineStatisticFlagBits,
Dave Houlton413a6782018-05-22 13:01:54 -06002715 pBeginInfo->pInheritanceInfo->pipelineStatistics, false, false, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002716 }
2717
2718 if (pInfo != NULL) {
2719 if ((device_data->physical_device_features.inheritedQueries == VK_FALSE) && (pInfo->occlusionQueryEnable != VK_FALSE)) {
2720 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002721 HandleToUint64(commandBuffer), "VUID-VkCommandBufferInheritanceInfo-occlusionQueryEnable-00056",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002722 "Cannot set inherited occlusionQueryEnable in vkBeginCommandBuffer() when device does not support "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002723 "inheritedQueries.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002724 }
2725 if ((device_data->physical_device_features.inheritedQueries != VK_FALSE) && (pInfo->occlusionQueryEnable != VK_FALSE)) {
2726 skip |= validate_flags(device_data->report_data, "vkBeginCommandBuffer", "pBeginInfo->pInheritanceInfo->queryFlags",
2727 "VkQueryControlFlagBits", AllVkQueryControlFlagBits, pInfo->queryFlags, false, false,
Dave Houlton413a6782018-05-22 13:01:54 -06002728 "VUID-VkCommandBufferInheritanceInfo-queryFlags-00057");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002729 }
2730 }
2731
2732 return skip;
2733}
2734
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002735bool pv_vkCmdSetViewport(VkCommandBuffer commandBuffer, uint32_t firstViewport, uint32_t viewportCount,
2736 const VkViewport *pViewports) {
2737 bool skip = false;
2738 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2739
Petr Krausd55e77c2018-01-09 22:09:25 +01002740 if (!device_data->physical_device_features.multiViewport) {
2741 if (firstViewport != 0) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002742 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002743 HandleToUint64(commandBuffer), "VUID-vkCmdSetViewport-firstViewport-01224",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002744 "vkCmdSetViewport: The multiViewport feature is disabled, but firstViewport (=%" PRIu32 ") is not 0.",
2745 firstViewport);
Petr Krausd55e77c2018-01-09 22:09:25 +01002746 }
2747 if (viewportCount > 1) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002748 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002749 HandleToUint64(commandBuffer), "VUID-vkCmdSetViewport-viewportCount-01225",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002750 "vkCmdSetViewport: The multiViewport feature is disabled, but viewportCount (=%" PRIu32 ") is not 1.",
2751 viewportCount);
Petr Krausd55e77c2018-01-09 22:09:25 +01002752 }
2753 } else { // multiViewport enabled
Petr Kraus7dfeed12018-02-27 20:51:20 +01002754 const uint64_t sum = static_cast<uint64_t>(firstViewport) + static_cast<uint64_t>(viewportCount);
Petr Krausd55e77c2018-01-09 22:09:25 +01002755 if (sum > device_data->device_limits.maxViewports) {
2756 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002757 HandleToUint64(commandBuffer), "VUID-vkCmdSetViewport-firstViewport-01223",
Petr Krausd55e77c2018-01-09 22:09:25 +01002758 "vkCmdSetViewport: firstViewport + viewportCount (=%" PRIu32 " + %" PRIu32 " = %" PRIu64
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002759 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
2760 firstViewport, viewportCount, sum, device_data->device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002761 }
2762 }
Petr Krausb3fcdb42018-01-09 22:09:09 +01002763
2764 if (pViewports) {
2765 for (uint32_t viewport_i = 0; viewport_i < viewportCount; ++viewport_i) {
2766 const auto &viewport = pViewports[viewport_i]; // will crash on invalid ptr
2767 const char fn_name[] = "vkCmdSetViewport";
2768 const std::string param_name = "pViewports[" + std::to_string(viewport_i) + "]";
2769 skip |= pv_VkViewport(device_data, viewport, fn_name, param_name.c_str(),
2770 VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, HandleToUint64(commandBuffer));
2771 }
2772 }
2773
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002774 return skip;
2775}
2776
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002777bool pv_vkCmdSetScissor(VkCommandBuffer commandBuffer, uint32_t firstScissor, uint32_t scissorCount, const VkRect2D *pScissors) {
2778 bool skip = false;
2779 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2780 debug_report_data *report_data = device_data->report_data;
2781
Petr Kraus6260f0a2018-02-27 21:15:55 +01002782 if (!device_data->physical_device_features.multiViewport) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002783 if (firstScissor != 0) {
Petr Kraus6260f0a2018-02-27 21:15:55 +01002784 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002785 HandleToUint64(commandBuffer), "VUID-vkCmdSetScissor-firstScissor-00593",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002786 "vkCmdSetScissor: The multiViewport feature is disabled, but firstScissor (=%" PRIu32 ") is not 0.",
2787 firstScissor);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002788 }
2789 if (scissorCount > 1) {
2790 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002791 HandleToUint64(commandBuffer), "VUID-vkCmdSetScissor-scissorCount-00594",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002792 "vkCmdSetScissor: The multiViewport feature is disabled, but scissorCount (=%" PRIu32 ") is not 1.",
2793 scissorCount);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002794 }
2795 } else { // multiViewport enabled
2796 const uint64_t sum = static_cast<uint64_t>(firstScissor) + static_cast<uint64_t>(scissorCount);
2797 if (sum > device_data->device_limits.maxViewports) {
2798 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002799 HandleToUint64(commandBuffer), "VUID-vkCmdSetScissor-firstScissor-00592",
Petr Kraus6260f0a2018-02-27 21:15:55 +01002800 "vkCmdSetScissor: firstScissor + scissorCount (=%" PRIu32 " + %" PRIu32 " = %" PRIu64
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002801 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
2802 firstScissor, scissorCount, sum, device_data->device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002803 }
2804 }
2805
Petr Kraus6260f0a2018-02-27 21:15:55 +01002806 if (pScissors) {
2807 for (uint32_t scissor_i = 0; scissor_i < scissorCount; ++scissor_i) {
2808 const auto &scissor = pScissors[scissor_i]; // will crash on invalid ptr
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002809
Petr Kraus6260f0a2018-02-27 21:15:55 +01002810 if (scissor.offset.x < 0) {
2811 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002812 HandleToUint64(commandBuffer), "VUID-vkCmdSetScissor-x-00595",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002813 "vkCmdSetScissor: pScissors[%" PRIu32 "].offset.x (=%" PRIi32 ") is negative.", scissor_i,
2814 scissor.offset.x);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002815 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002816
Petr Kraus6260f0a2018-02-27 21:15:55 +01002817 if (scissor.offset.y < 0) {
2818 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002819 HandleToUint64(commandBuffer), "VUID-vkCmdSetScissor-x-00595",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002820 "vkCmdSetScissor: pScissors[%" PRIu32 "].offset.y (=%" PRIi32 ") is negative.", scissor_i,
2821 scissor.offset.y);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002822 }
2823
2824 const int64_t x_sum = static_cast<int64_t>(scissor.offset.x) + static_cast<int64_t>(scissor.extent.width);
2825 if (x_sum > INT32_MAX) {
2826 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002827 HandleToUint64(commandBuffer), "VUID-vkCmdSetScissor-offset-00596",
Petr Kraus6260f0a2018-02-27 21:15:55 +01002828 "vkCmdSetScissor: offset.x + extent.width (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002829 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
2830 scissor.offset.x, scissor.extent.width, x_sum, scissor_i);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002831 }
2832
2833 const int64_t y_sum = static_cast<int64_t>(scissor.offset.y) + static_cast<int64_t>(scissor.extent.height);
2834 if (y_sum > INT32_MAX) {
2835 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002836 HandleToUint64(commandBuffer), "VUID-vkCmdSetScissor-offset-00597",
Petr Kraus6260f0a2018-02-27 21:15:55 +01002837 "vkCmdSetScissor: offset.y + extent.height (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002838 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
2839 scissor.offset.y, scissor.extent.height, y_sum, scissor_i);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002840 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002841 }
2842 }
Petr Kraus6260f0a2018-02-27 21:15:55 +01002843
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002844 return skip;
2845}
2846
Petr Kraus299ba622017-11-24 03:09:03 +01002847bool pv_vkCmdSetLineWidth(VkCommandBuffer commandBuffer, float lineWidth) {
2848 bool skip = false;
2849 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2850 debug_report_data *report_data = device_data->report_data;
2851
2852 if (!device_data->physical_device_features.wideLines && (lineWidth != 1.0f)) {
2853 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002854 HandleToUint64(commandBuffer), "VUID-vkCmdSetLineWidth-lineWidth-00788",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002855 "VkPhysicalDeviceFeatures::wideLines is disabled, but lineWidth (=%f) is not 1.0.", lineWidth);
Petr Kraus299ba622017-11-24 03:09:03 +01002856 }
2857
2858 return skip;
2859}
2860
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002861bool pv_vkCmdDraw(VkCommandBuffer commandBuffer, uint32_t vertexCount, uint32_t instanceCount, uint32_t firstVertex,
2862 uint32_t firstInstance) {
2863 bool skip = false;
2864 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2865 if (vertexCount == 0) {
2866 // TODO: Verify against Valid Usage section. I don't see a non-zero vertexCount listed, may need to add that and make
2867 // this an error or leave as is.
2868 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002869 kVUID_PVError_RequiredParameter, "vkCmdDraw parameter, uint32_t vertexCount, is 0");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002870 }
2871
2872 if (instanceCount == 0) {
2873 // TODO: Verify against Valid Usage section. I don't see a non-zero instanceCount listed, may need to add that and make
2874 // this an error or leave as is.
2875 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002876 kVUID_PVError_RequiredParameter, "vkCmdDraw parameter, uint32_t instanceCount, is 0");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002877 }
2878 return skip;
2879}
2880
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002881bool pv_vkCmdDrawIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, uint32_t count, uint32_t stride) {
2882 bool skip = false;
2883 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2884
2885 if (!device_data->physical_device_features.multiDrawIndirect && ((count > 1))) {
2886 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002887 kVUID_PVError_DeviceFeature,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002888 "CmdDrawIndirect(): Device feature multiDrawIndirect disabled: count must be 0 or 1 but is %d", count);
2889 }
2890 return skip;
2891}
2892
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002893bool pv_vkCmdDrawIndexedIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, uint32_t count,
2894 uint32_t stride) {
2895 bool skip = false;
2896 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2897 if (!device_data->physical_device_features.multiDrawIndirect && ((count > 1))) {
Dave Houlton413a6782018-05-22 13:01:54 -06002898 skip |=
2899 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
2900 kVUID_PVError_DeviceFeature,
2901 "CmdDrawIndexedIndirect(): Device feature multiDrawIndirect disabled: count must be 0 or 1 but is %d", count);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002902 }
2903 return skip;
2904}
2905
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002906bool pv_vkCmdCopyImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkImage dstImage,
2907 VkImageLayout dstImageLayout, uint32_t regionCount, const VkImageCopy *pRegions) {
2908 bool skip = false;
2909 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2910
Dave Houltonf5217612018-02-02 16:18:52 -07002911 VkImageAspectFlags legal_aspect_flags =
2912 VK_IMAGE_ASPECT_COLOR_BIT | VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT | VK_IMAGE_ASPECT_METADATA_BIT;
2913 if (device_data->extensions.vk_khr_sampler_ycbcr_conversion) {
2914 legal_aspect_flags |= (VK_IMAGE_ASPECT_PLANE_0_BIT_KHR | VK_IMAGE_ASPECT_PLANE_1_BIT_KHR | VK_IMAGE_ASPECT_PLANE_2_BIT_KHR);
2915 }
2916
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002917 if (pRegions != nullptr) {
Dave Houltonf5217612018-02-02 16:18:52 -07002918 if ((pRegions->srcSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002919 skip |= log_msg(
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002920 device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002921 "VUID-VkImageSubresourceLayers-aspectMask-parameter",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002922 "vkCmdCopyImage() parameter, VkImageAspect pRegions->srcSubresource.aspectMask, is an unrecognized enumerator.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002923 }
Dave Houltonf5217612018-02-02 16:18:52 -07002924 if ((pRegions->dstSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002925 skip |= log_msg(
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002926 device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002927 "VUID-VkImageSubresourceLayers-aspectMask-parameter",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002928 "vkCmdCopyImage() parameter, VkImageAspect pRegions->dstSubresource.aspectMask, is an unrecognized enumerator.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002929 }
2930 }
2931 return skip;
2932}
2933
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002934bool pv_vkCmdBlitImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkImage dstImage,
2935 VkImageLayout dstImageLayout, uint32_t regionCount, const VkImageBlit *pRegions, VkFilter filter) {
2936 bool skip = false;
2937 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2938
Dave Houltonf5217612018-02-02 16:18:52 -07002939 VkImageAspectFlags legal_aspect_flags =
2940 VK_IMAGE_ASPECT_COLOR_BIT | VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT | VK_IMAGE_ASPECT_METADATA_BIT;
2941 if (device_data->extensions.vk_khr_sampler_ycbcr_conversion) {
2942 legal_aspect_flags |= (VK_IMAGE_ASPECT_PLANE_0_BIT_KHR | VK_IMAGE_ASPECT_PLANE_1_BIT_KHR | VK_IMAGE_ASPECT_PLANE_2_BIT_KHR);
2943 }
2944
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002945 if (pRegions != nullptr) {
Dave Houltonf5217612018-02-02 16:18:52 -07002946 if ((pRegions->srcSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002947 skip |= log_msg(
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002948 device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002949 kVUID_PVError_UnrecognizedValue,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002950 "vkCmdBlitImage() parameter, VkImageAspect pRegions->srcSubresource.aspectMask, is an unrecognized enumerator");
2951 }
Dave Houltonf5217612018-02-02 16:18:52 -07002952 if ((pRegions->dstSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002953 skip |= log_msg(
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002954 device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002955 kVUID_PVError_UnrecognizedValue,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002956 "vkCmdBlitImage() parameter, VkImageAspect pRegions->dstSubresource.aspectMask, is an unrecognized enumerator");
2957 }
2958 }
2959 return skip;
2960}
2961
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002962bool pv_vkCmdCopyBufferToImage(VkCommandBuffer commandBuffer, VkBuffer srcBuffer, VkImage dstImage, VkImageLayout dstImageLayout,
2963 uint32_t regionCount, const VkBufferImageCopy *pRegions) {
2964 bool skip = false;
2965 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2966
Dave Houltonf5217612018-02-02 16:18:52 -07002967 VkImageAspectFlags legal_aspect_flags =
2968 VK_IMAGE_ASPECT_COLOR_BIT | VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT | VK_IMAGE_ASPECT_METADATA_BIT;
2969 if (device_data->extensions.vk_khr_sampler_ycbcr_conversion) {
2970 legal_aspect_flags |= (VK_IMAGE_ASPECT_PLANE_0_BIT_KHR | VK_IMAGE_ASPECT_PLANE_1_BIT_KHR | VK_IMAGE_ASPECT_PLANE_2_BIT_KHR);
2971 }
2972
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002973 if (pRegions != nullptr) {
Dave Houltonf5217612018-02-02 16:18:52 -07002974 if ((pRegions->imageSubresource.aspectMask & legal_aspect_flags) == 0) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07002975 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002976 kVUID_PVError_UnrecognizedValue,
Dave Houltona9df0ce2018-02-07 10:51:23 -07002977 "vkCmdCopyBufferToImage() parameter, VkImageAspect pRegions->imageSubresource.aspectMask, is an "
2978 "unrecognized enumerator");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002979 }
2980 }
2981 return skip;
2982}
2983
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002984bool pv_vkCmdCopyImageToBuffer(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkBuffer dstBuffer,
2985 uint32_t regionCount, const VkBufferImageCopy *pRegions) {
2986 bool skip = false;
2987 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2988
Dave Houltonf5217612018-02-02 16:18:52 -07002989 VkImageAspectFlags legal_aspect_flags =
2990 VK_IMAGE_ASPECT_COLOR_BIT | VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT | VK_IMAGE_ASPECT_METADATA_BIT;
2991 if (device_data->extensions.vk_khr_sampler_ycbcr_conversion) {
2992 legal_aspect_flags |= (VK_IMAGE_ASPECT_PLANE_0_BIT_KHR | VK_IMAGE_ASPECT_PLANE_1_BIT_KHR | VK_IMAGE_ASPECT_PLANE_2_BIT_KHR);
2993 }
2994
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002995 if (pRegions != nullptr) {
Dave Houltonf5217612018-02-02 16:18:52 -07002996 if ((pRegions->imageSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002997 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002998 kVUID_PVError_UnrecognizedValue,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002999 "vkCmdCopyImageToBuffer parameter, VkImageAspect pRegions->imageSubresource.aspectMask, is an unrecognized "
3000 "enumerator");
3001 }
3002 }
3003 return skip;
3004}
3005
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003006bool pv_vkCmdUpdateBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer, VkDeviceSize dstOffset, VkDeviceSize dataSize,
3007 const void *pData) {
3008 bool skip = false;
3009 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3010
3011 if (dstOffset & 3) {
3012 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003013 "VUID-vkCmdUpdateBuffer-dstOffset-00036",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003014 "vkCmdUpdateBuffer() parameter, VkDeviceSize dstOffset (0x%" PRIxLEAST64 "), is not a multiple of 4.",
3015 dstOffset);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003016 }
3017
3018 if ((dataSize <= 0) || (dataSize > 65536)) {
3019 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003020 "VUID-vkCmdUpdateBuffer-dataSize-00037",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003021 "vkCmdUpdateBuffer() parameter, VkDeviceSize dataSize (0x%" PRIxLEAST64
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003022 "), must be greater than zero and less than or equal to 65536.",
3023 dataSize);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003024 } else if (dataSize & 3) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003025 skip |=
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06003026 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003027 "VUID-vkCmdUpdateBuffer-dataSize-00038",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003028 "vkCmdUpdateBuffer() parameter, VkDeviceSize dataSize (0x%" PRIxLEAST64 "), is not a multiple of 4.", dataSize);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003029 }
3030 return skip;
3031}
3032
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003033bool pv_vkCmdFillBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer, VkDeviceSize dstOffset, VkDeviceSize size,
3034 uint32_t data) {
3035 bool skip = false;
3036 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3037
3038 if (dstOffset & 3) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003039 skip |=
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06003040 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003041 "VUID-vkCmdFillBuffer-dstOffset-00025",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003042 "vkCmdFillBuffer() parameter, VkDeviceSize dstOffset (0x%" PRIxLEAST64 "), is not a multiple of 4.", dstOffset);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003043 }
3044
3045 if (size != VK_WHOLE_SIZE) {
3046 if (size <= 0) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003047 skip |=
3048 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003049 "VUID-vkCmdFillBuffer-size-00026",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003050 "vkCmdFillBuffer() parameter, VkDeviceSize size (0x%" PRIxLEAST64 "), must be greater than zero.", size);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003051 } else if (size & 3) {
3052 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003053 "VUID-vkCmdFillBuffer-size-00028",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003054 "vkCmdFillBuffer() parameter, VkDeviceSize size (0x%" PRIxLEAST64 "), is not a multiple of 4.", size);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003055 }
3056 }
3057 return skip;
3058}
3059
3060VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateInstanceLayerProperties(uint32_t *pCount, VkLayerProperties *pProperties) {
3061 return util_GetLayerProperties(1, &global_layer, pCount, pProperties);
3062}
3063
3064VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateDeviceLayerProperties(VkPhysicalDevice physicalDevice, uint32_t *pCount,
3065 VkLayerProperties *pProperties) {
3066 return util_GetLayerProperties(1, &global_layer, pCount, pProperties);
3067}
3068
3069VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateInstanceExtensionProperties(const char *pLayerName, uint32_t *pCount,
3070 VkExtensionProperties *pProperties) {
3071 if (pLayerName && !strcmp(pLayerName, global_layer.layerName))
3072 return util_GetExtensionProperties(1, instance_extensions, pCount, pProperties);
3073
3074 return VK_ERROR_LAYER_NOT_PRESENT;
3075}
3076
3077VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateDeviceExtensionProperties(VkPhysicalDevice physicalDevice, const char *pLayerName,
3078 uint32_t *pPropertyCount, VkExtensionProperties *pProperties) {
3079 // Parameter_validation does not have any physical device extensions
3080 if (pLayerName && !strcmp(pLayerName, global_layer.layerName))
3081 return util_GetExtensionProperties(0, NULL, pPropertyCount, pProperties);
3082
3083 instance_layer_data *local_data = GetLayerDataPtr(get_dispatch_key(physicalDevice), instance_layer_data_map);
Dave Houlton413a6782018-05-22 13:01:54 -06003084 bool skip = validate_array(local_data->report_data, "vkEnumerateDeviceExtensionProperties", "pPropertyCount", "pProperties",
3085 pPropertyCount, &pProperties, true, false, false, kVUIDUndefined,
3086 "VUID-vkEnumerateDeviceExtensionProperties-pProperties-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003087 if (skip) return VK_ERROR_VALIDATION_FAILED_EXT;
3088
3089 return local_data->dispatch_table.EnumerateDeviceExtensionProperties(physicalDevice, NULL, pPropertyCount, pProperties);
3090}
3091
3092static bool require_device_extension(layer_data *device_data, bool flag, char const *function_name, char const *extension_name) {
3093 if (!flag) {
3094 return log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003095 kVUID_PVError_ExtensionNotEnabled,
3096 "%s() called even though the %s extension was not enabled for this VkDevice.", function_name,
3097 extension_name);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003098 }
3099
3100 return false;
3101}
3102
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003103bool pv_vkCreateSwapchainKHR(VkDevice device, const VkSwapchainCreateInfoKHR *pCreateInfo, const VkAllocationCallbacks *pAllocator,
3104 VkSwapchainKHR *pSwapchain) {
3105 bool skip = false;
3106 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
3107 debug_report_data *report_data = device_data->report_data;
3108
Mark Lobodzinski88529492018-04-01 10:38:15 -06003109 const LogMiscParams log_misc{report_data, VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT, VK_NULL_HANDLE,
Petr Krause5c37652018-01-05 04:05:12 +01003110 "vkCreateSwapchainKHR"};
3111
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003112 if (pCreateInfo != nullptr) {
3113 if ((device_data->physical_device_features.textureCompressionETC2 == false) &&
3114 FormatIsCompressed_ETC2_EAC(pCreateInfo->imageFormat)) {
Dave Houlton413a6782018-05-22 13:01:54 -06003115 skip |= log_msg(
3116 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, kVUID_PVError_DeviceFeature,
3117 "vkCreateSwapchainKHR(): Attempting to create swapchain VkImage with format %s. The textureCompressionETC2 "
3118 "feature is not enabled: neither ETC2 nor EAC formats can be used to create images.",
3119 string_VkFormat(pCreateInfo->imageFormat));
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003120 }
3121
3122 if ((device_data->physical_device_features.textureCompressionASTC_LDR == false) &&
3123 FormatIsCompressed_ASTC_LDR(pCreateInfo->imageFormat)) {
Dave Houlton413a6782018-05-22 13:01:54 -06003124 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
3125 kVUID_PVError_DeviceFeature,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003126 "vkCreateSwapchainKHR(): Attempting to create swapchain VkImage with format %s. The "
3127 "textureCompressionASTC_LDR feature is not enabled: ASTC formats cannot be used to create images.",
3128 string_VkFormat(pCreateInfo->imageFormat));
3129 }
3130
3131 if ((device_data->physical_device_features.textureCompressionBC == false) &&
3132 FormatIsCompressed_BC(pCreateInfo->imageFormat)) {
Dave Houlton413a6782018-05-22 13:01:54 -06003133 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
3134 kVUID_PVError_DeviceFeature,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003135 "vkCreateSwapchainKHR(): Attempting to create swapchain VkImage with format %s. The "
3136 "textureCompressionBC feature is not enabled: BC compressed formats cannot be used to create images.",
3137 string_VkFormat(pCreateInfo->imageFormat));
3138 }
3139
3140 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
3141 if (pCreateInfo->imageSharingMode == VK_SHARING_MODE_CONCURRENT) {
3142 // If imageSharingMode is VK_SHARING_MODE_CONCURRENT, queueFamilyIndexCount must be greater than 1
3143 if (pCreateInfo->queueFamilyIndexCount <= 1) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06003144 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003145 "VUID-VkSwapchainCreateInfoKHR-imageSharingMode-01278",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003146 "vkCreateSwapchainKHR(): if pCreateInfo->imageSharingMode is VK_SHARING_MODE_CONCURRENT, "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003147 "pCreateInfo->queueFamilyIndexCount must be greater than 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003148 }
3149
3150 // If imageSharingMode is VK_SHARING_MODE_CONCURRENT, pQueueFamilyIndices must be a pointer to an array of
3151 // queueFamilyIndexCount uint32_t values
3152 if (pCreateInfo->pQueueFamilyIndices == nullptr) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06003153 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003154 "VUID-VkSwapchainCreateInfoKHR-imageSharingMode-01277",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003155 "vkCreateSwapchainKHR(): if pCreateInfo->imageSharingMode is VK_SHARING_MODE_CONCURRENT, "
3156 "pCreateInfo->pQueueFamilyIndices must be a pointer to an array of "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003157 "pCreateInfo->queueFamilyIndexCount uint32_t values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003158 } else {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003159 skip |= ValidateQueueFamilies(device_data, pCreateInfo->queueFamilyIndexCount, pCreateInfo->pQueueFamilyIndices,
Dave Houlton413a6782018-05-22 13:01:54 -06003160 "vkCreateSwapchainKHR", "pCreateInfo->pQueueFamilyIndices",
3161 kVUID_PVError_InvalidUsage, kVUID_PVError_InvalidUsage, false);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003162 }
3163 }
3164
Dave Houlton413a6782018-05-22 13:01:54 -06003165 skip |= ValidateGreaterThanZero(pCreateInfo->imageArrayLayers, "pCreateInfo->imageArrayLayers",
3166 "VUID-VkSwapchainCreateInfoKHR-imageArrayLayers-01275", log_misc);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003167 }
3168
3169 return skip;
3170}
3171
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003172bool pv_vkQueuePresentKHR(VkQueue queue, const VkPresentInfoKHR *pPresentInfo) {
3173 bool skip = false;
3174 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(queue), layer_data_map);
3175
3176 if (pPresentInfo && pPresentInfo->pNext) {
John Zulaufde972ac2017-10-26 12:07:05 -06003177 const auto *present_regions = lvl_find_in_chain<VkPresentRegionsKHR>(pPresentInfo->pNext);
3178 if (present_regions) {
3179 // TODO: This and all other pNext extension dependencies should be added to code-generation
3180 skip |= require_device_extension(device_data, device_data->extensions.vk_khr_incremental_present, "vkQueuePresentKHR",
3181 VK_KHR_INCREMENTAL_PRESENT_EXTENSION_NAME);
3182 if (present_regions->swapchainCount != pPresentInfo->swapchainCount) {
3183 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003184 kVUID_PVError_InvalidUsage,
Dave Houltona9df0ce2018-02-07 10:51:23 -07003185 "QueuePresentKHR(): pPresentInfo->swapchainCount has a value of %i but VkPresentRegionsKHR "
3186 "extension swapchainCount is %i. These values must be equal.",
John Zulaufde972ac2017-10-26 12:07:05 -06003187 pPresentInfo->swapchainCount, present_regions->swapchainCount);
3188 }
Dave Houlton413a6782018-05-22 13:01:54 -06003189 skip |=
3190 validate_struct_pnext(device_data->report_data, "QueuePresentKHR", "pCreateInfo->pNext->pNext", NULL,
3191 present_regions->pNext, 0, NULL, GeneratedHeaderVersion, "VUID-VkPresentInfoKHR-pNext-pNext");
John Zulaufde972ac2017-10-26 12:07:05 -06003192 skip |= validate_array(device_data->report_data, "QueuePresentKHR", "pCreateInfo->pNext->swapchainCount",
Gabríel Arthúr Pétursson092b29b2018-03-21 22:44:11 +00003193 "pCreateInfo->pNext->pRegions", present_regions->swapchainCount, &present_regions->pRegions,
Dave Houlton413a6782018-05-22 13:01:54 -06003194 true, false, kVUIDUndefined, kVUIDUndefined);
John Zulaufde972ac2017-10-26 12:07:05 -06003195 for (uint32_t i = 0; i < present_regions->swapchainCount; ++i) {
3196 skip |= validate_array(device_data->report_data, "QueuePresentKHR", "pCreateInfo->pNext->pRegions[].rectangleCount",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003197 "pCreateInfo->pNext->pRegions[].pRectangles", present_regions->pRegions[i].rectangleCount,
Dave Houlton413a6782018-05-22 13:01:54 -06003198 &present_regions->pRegions[i].pRectangles, true, false, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003199 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003200 }
3201 }
3202
3203 return skip;
3204}
3205
3206#ifdef VK_USE_PLATFORM_WIN32_KHR
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003207bool pv_vkCreateWin32SurfaceKHR(VkInstance instance, const VkWin32SurfaceCreateInfoKHR *pCreateInfo,
3208 const VkAllocationCallbacks *pAllocator, VkSurfaceKHR *pSurface) {
3209 auto device_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map);
3210 bool skip = false;
3211
3212 if (pCreateInfo->hwnd == nullptr) {
3213 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003214 "VUID-VkWin32SurfaceCreateInfoKHR-hwnd-01308",
3215 "vkCreateWin32SurfaceKHR(): hwnd must be a valid Win32 HWND but hwnd is NULL.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003216 }
3217
3218 return skip;
3219}
3220#endif // VK_USE_PLATFORM_WIN32_KHR
3221
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003222bool pv_vkDebugMarkerSetObjectNameEXT(VkDevice device, const VkDebugMarkerObjectNameInfoEXT *pNameInfo) {
3223 auto device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
3224 if (pNameInfo->pObjectName) {
3225 device_data->report_data->debugObjectNameMap->insert(
3226 std::make_pair<uint64_t, std::string>((uint64_t &&) pNameInfo->object, pNameInfo->pObjectName));
3227 } else {
3228 device_data->report_data->debugObjectNameMap->erase(pNameInfo->object);
3229 }
3230 return false;
3231}
3232
Petr Krausc8655be2017-09-27 18:56:51 +02003233bool pv_vkCreateDescriptorPool(VkDevice device, const VkDescriptorPoolCreateInfo *pCreateInfo,
3234 const VkAllocationCallbacks *pAllocator, VkDescriptorPool *pDescriptorPool) {
3235 auto device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
3236 bool skip = false;
3237
3238 if (pCreateInfo) {
3239 if (pCreateInfo->maxSets <= 0) {
Dave Houlton413a6782018-05-22 13:01:54 -06003240 skip |=
3241 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT,
3242 VK_NULL_HANDLE, "VUID-VkDescriptorPoolCreateInfo-maxSets-00301",
3243 "vkCreateDescriptorPool(): pCreateInfo->maxSets is not greater than 0.");
Petr Krausc8655be2017-09-27 18:56:51 +02003244 }
3245
3246 if (pCreateInfo->pPoolSizes) {
3247 for (uint32_t i = 0; i < pCreateInfo->poolSizeCount; ++i) {
3248 if (pCreateInfo->pPoolSizes[i].descriptorCount <= 0) {
3249 skip |= log_msg(
3250 device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003251 VK_NULL_HANDLE, "VUID-VkDescriptorPoolSize-descriptorCount-00302",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003252 "vkCreateDescriptorPool(): pCreateInfo->pPoolSizes[%" PRIu32 "].descriptorCount is not greater than 0.", i);
Petr Krausc8655be2017-09-27 18:56:51 +02003253 }
Jeff Bolze54ae892018-09-08 12:16:29 -05003254 if (pCreateInfo->pPoolSizes[i].type == VK_DESCRIPTOR_TYPE_INLINE_UNIFORM_BLOCK_EXT &&
3255 (pCreateInfo->pPoolSizes[i].descriptorCount % 4) != 0) {
3256 skip |= log_msg(
3257 device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT,
3258 VK_NULL_HANDLE, "VUID-VkDescriptorPoolSize-type-02218",
3259 "vkCreateDescriptorPool(): pCreateInfo->pPoolSizes[%" PRIu32 "].type is VK_DESCRIPTOR_TYPE_INLINE_UNIFORM_BLOCK_EXT "
3260 " and pCreateInfo->pPoolSizes[%" PRIu32 "].descriptorCount is not a multiple of 4.", i, i);
3261 }
Petr Krausc8655be2017-09-27 18:56:51 +02003262 }
3263 }
3264 }
3265
3266 return skip;
3267}
3268
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003269bool pv_vkCmdDispatch(VkCommandBuffer commandBuffer, uint32_t groupCountX, uint32_t groupCountY, uint32_t groupCountZ) {
3270 bool skip = false;
3271 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3272
3273 if (groupCountX > device_data->device_limits.maxComputeWorkGroupCount[0]) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003274 skip |=
3275 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003276 HandleToUint64(commandBuffer), "VUID-vkCmdDispatch-groupCountX-00386",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003277 "vkCmdDispatch(): groupCountX (%" PRIu32 ") exceeds device limit maxComputeWorkGroupCount[0] (%" PRIu32 ").",
3278 groupCountX, device_data->device_limits.maxComputeWorkGroupCount[0]);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003279 }
3280
3281 if (groupCountY > device_data->device_limits.maxComputeWorkGroupCount[1]) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003282 skip |=
3283 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003284 HandleToUint64(commandBuffer), "VUID-vkCmdDispatch-groupCountY-00387",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003285 "vkCmdDispatch(): groupCountY (%" PRIu32 ") exceeds device limit maxComputeWorkGroupCount[1] (%" PRIu32 ").",
3286 groupCountY, device_data->device_limits.maxComputeWorkGroupCount[1]);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003287 }
3288
3289 if (groupCountZ > device_data->device_limits.maxComputeWorkGroupCount[2]) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003290 skip |=
3291 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003292 HandleToUint64(commandBuffer), "VUID-vkCmdDispatch-groupCountZ-00388",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003293 "vkCmdDispatch(): groupCountZ (%" PRIu32 ") exceeds device limit maxComputeWorkGroupCount[2] (%" PRIu32 ").",
3294 groupCountZ, device_data->device_limits.maxComputeWorkGroupCount[2]);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003295 }
3296
3297 return skip;
3298}
3299
Mark Lobodzinskibf973a12018-03-01 08:50:21 -07003300bool pv_vkCmdDispatchBaseKHR(VkCommandBuffer commandBuffer, uint32_t baseGroupX, uint32_t baseGroupY, uint32_t baseGroupZ,
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003301 uint32_t groupCountX, uint32_t groupCountY, uint32_t groupCountZ) {
3302 bool skip = false;
3303 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3304
3305 // Paired if {} else if {} tests used to avoid any possible uint underflow
3306 uint32_t limit = device_data->device_limits.maxComputeWorkGroupCount[0];
3307 if (baseGroupX >= limit) {
3308 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003309 HandleToUint64(commandBuffer), "VUID-vkCmdDispatchBase-baseGroupX-00421",
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003310 "vkCmdDispatch(): baseGroupX (%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003311 ") equals or exceeds device limit maxComputeWorkGroupCount[0] (%" PRIu32 ").",
3312 baseGroupX, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003313 } else if (groupCountX > (limit - baseGroupX)) {
3314 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003315 HandleToUint64(commandBuffer), "VUID-vkCmdDispatchBase-groupCountX-00424",
Mark Lobodzinskibf973a12018-03-01 08:50:21 -07003316 "vkCmdDispatchBaseKHR(): baseGroupX (%" PRIu32 ") + groupCountX (%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003317 ") exceeds device limit maxComputeWorkGroupCount[0] (%" PRIu32 ").",
3318 baseGroupX, groupCountX, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003319 }
3320
3321 limit = device_data->device_limits.maxComputeWorkGroupCount[1];
3322 if (baseGroupY >= limit) {
3323 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003324 HandleToUint64(commandBuffer), "VUID-vkCmdDispatchBase-baseGroupX-00422",
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003325 "vkCmdDispatch(): baseGroupY (%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003326 ") equals or exceeds device limit maxComputeWorkGroupCount[1] (%" PRIu32 ").",
3327 baseGroupY, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003328 } else if (groupCountY > (limit - baseGroupY)) {
3329 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003330 HandleToUint64(commandBuffer), "VUID-vkCmdDispatchBase-groupCountY-00425",
Mark Lobodzinskibf973a12018-03-01 08:50:21 -07003331 "vkCmdDispatchBaseKHR(): baseGroupY (%" PRIu32 ") + groupCountY (%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003332 ") exceeds device limit maxComputeWorkGroupCount[1] (%" PRIu32 ").",
3333 baseGroupY, groupCountY, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003334 }
3335
3336 limit = device_data->device_limits.maxComputeWorkGroupCount[2];
3337 if (baseGroupZ >= limit) {
3338 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003339 HandleToUint64(commandBuffer), "VUID-vkCmdDispatchBase-baseGroupZ-00423",
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003340 "vkCmdDispatch(): baseGroupZ (%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003341 ") equals or exceeds device limit maxComputeWorkGroupCount[2] (%" PRIu32 ").",
3342 baseGroupZ, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003343 } else if (groupCountZ > (limit - baseGroupZ)) {
3344 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003345 HandleToUint64(commandBuffer), "VUID-vkCmdDispatchBase-groupCountZ-00426",
Mark Lobodzinskibf973a12018-03-01 08:50:21 -07003346 "vkCmdDispatchBaseKHR(): baseGroupZ (%" PRIu32 ") + groupCountZ (%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003347 ") exceeds device limit maxComputeWorkGroupCount[2] (%" PRIu32 ").",
3348 baseGroupZ, groupCountZ, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003349 }
3350
3351 return skip;
3352}
3353
Jeff Bolz3e71f782018-08-29 23:15:45 -05003354bool pv_vkCmdSetExclusiveScissorNV(
3355 VkCommandBuffer commandBuffer,
3356 uint32_t firstExclusiveScissor,
3357 uint32_t exclusiveScissorCount,
3358 const VkRect2D* pExclusiveScissors)
3359{
3360 bool skip = false;
3361
3362 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3363 debug_report_data *report_data = device_data->report_data;
3364
3365 if (!device_data->physical_device_features.multiViewport) {
3366 if (firstExclusiveScissor != 0) {
3367 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3368 HandleToUint64(commandBuffer), "VUID-vkCmdSetExclusiveScissorNV-firstExclusiveScissor-02035",
3369 "vkCmdSetExclusiveScissorNV: The multiViewport feature is disabled, but firstExclusiveScissor (=%" PRIu32 ") is not 0.",
3370 firstExclusiveScissor);
3371 }
3372 if (exclusiveScissorCount > 1) {
3373 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3374 HandleToUint64(commandBuffer), "VUID-vkCmdSetExclusiveScissorNV-exclusiveScissorCount-02036",
3375 "vkCmdSetExclusiveScissorNV: The multiViewport feature is disabled, but exclusiveScissorCount (=%" PRIu32 ") is not 1.",
3376 exclusiveScissorCount);
3377 }
3378 } else { // multiViewport enabled
3379 const uint64_t sum = static_cast<uint64_t>(firstExclusiveScissor) + static_cast<uint64_t>(exclusiveScissorCount);
3380 if (sum > device_data->device_limits.maxViewports) {
3381 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3382 HandleToUint64(commandBuffer), "VUID-vkCmdSetExclusiveScissorNV-firstExclusiveScissor-02034",
3383 "vkCmdSetExclusiveScissorNV: firstExclusiveScissor + exclusiveScissorCount (=%" PRIu32 " + %" PRIu32 " = %" PRIu64
3384 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
3385 firstExclusiveScissor, exclusiveScissorCount, sum, device_data->device_limits.maxViewports);
3386 }
3387 }
3388
3389 if (firstExclusiveScissor >= device_data->device_limits.maxViewports) {
3390 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3391 HandleToUint64(commandBuffer), "VUID-vkCmdSetExclusiveScissorNV-firstExclusiveScissor-02033",
3392 "vkCmdSetExclusiveScissorNV: firstExclusiveScissor (=%" PRIu32 ") must be less than maxViewports (=%" PRIu32 ").",
3393 firstExclusiveScissor, device_data->device_limits.maxViewports);
3394 }
3395
3396 if (pExclusiveScissors) {
3397 for (uint32_t scissor_i = 0; scissor_i < exclusiveScissorCount; ++scissor_i) {
3398 const auto &scissor = pExclusiveScissors[scissor_i]; // will crash on invalid ptr
3399
3400 if (scissor.offset.x < 0) {
3401 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3402 HandleToUint64(commandBuffer), "VUID-vkCmdSetExclusiveScissorNV-x-02037",
3403 "vkCmdSetExclusiveScissorNV: pScissors[%" PRIu32 "].offset.x (=%" PRIi32 ") is negative.", scissor_i,
3404 scissor.offset.x);
3405 }
3406
3407 if (scissor.offset.y < 0) {
3408 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3409 HandleToUint64(commandBuffer), "VUID-vkCmdSetExclusiveScissorNV-x-02037",
3410 "vkCmdSetExclusiveScissorNV: pScissors[%" PRIu32 "].offset.y (=%" PRIi32 ") is negative.", scissor_i,
3411 scissor.offset.y);
3412 }
3413
3414 const int64_t x_sum = static_cast<int64_t>(scissor.offset.x) + static_cast<int64_t>(scissor.extent.width);
3415 if (x_sum > INT32_MAX) {
3416 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3417 HandleToUint64(commandBuffer), "VUID-vkCmdSetExclusiveScissorNV-offset-02038",
3418 "vkCmdSetExclusiveScissorNV: offset.x + extent.width (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
3419 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
3420 scissor.offset.x, scissor.extent.width, x_sum, scissor_i);
3421 }
3422
3423 const int64_t y_sum = static_cast<int64_t>(scissor.offset.y) + static_cast<int64_t>(scissor.extent.height);
3424 if (y_sum > INT32_MAX) {
3425 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3426 HandleToUint64(commandBuffer), "VUID-vkCmdSetExclusiveScissorNV-offset-02039",
3427 "vkCmdSetExclusiveScissorNV: offset.y + extent.height (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
3428 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
3429 scissor.offset.y, scissor.extent.height, y_sum, scissor_i);
3430 }
3431 }
3432 }
3433
3434 return skip;
3435}
3436
Jeff Bolz9af91c52018-09-01 21:53:57 -05003437bool pv_vkCmdSetViewportShadingRatePaletteNV(
3438 VkCommandBuffer commandBuffer,
3439 uint32_t firstViewport,
3440 uint32_t viewportCount,
3441 const VkShadingRatePaletteNV* pShadingRatePalettes)
3442{
3443 bool skip = false;
3444
3445 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3446 debug_report_data *report_data = device_data->report_data;
3447
3448 if (!device_data->physical_device_features.multiViewport) {
3449 if (firstViewport != 0) {
3450 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3451 HandleToUint64(commandBuffer), "VUID-vkCmdSetViewportShadingRatePaletteNV-firstViewport-02068",
3452 "vkCmdSetViewportShadingRatePaletteNV: The multiViewport feature is disabled, but firstViewport (=%" PRIu32 ") is not 0.",
3453 firstViewport);
3454 }
3455 if (viewportCount > 1) {
3456 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3457 HandleToUint64(commandBuffer), "VUID-vkCmdSetViewportShadingRatePaletteNV-viewportCount-02069",
3458 "vkCmdSetViewportShadingRatePaletteNV: The multiViewport feature is disabled, but viewportCount (=%" PRIu32 ") is not 1.",
3459 viewportCount);
3460 }
3461 }
3462
3463 if (firstViewport >= device_data->device_limits.maxViewports) {
3464 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3465 HandleToUint64(commandBuffer), "VUID-vkCmdSetViewportShadingRatePaletteNV-firstViewport-02066",
3466 "vkCmdSetViewportShadingRatePaletteNV: firstViewport (=%" PRIu32 ") must be less than maxViewports (=%" PRIu32 ").",
3467 firstViewport, device_data->device_limits.maxViewports);
3468 }
3469
3470 const uint64_t sum = static_cast<uint64_t>(firstViewport) + static_cast<uint64_t>(viewportCount);
3471 if (sum > device_data->device_limits.maxViewports) {
3472 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3473 HandleToUint64(commandBuffer), "VUID-vkCmdSetViewportShadingRatePaletteNV-firstViewport-02067",
3474 "vkCmdSetViewportShadingRatePaletteNV: firstViewport + viewportCount (=%" PRIu32 " + %" PRIu32 " = %" PRIu64
3475 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
3476 firstViewport, viewportCount, sum, device_data->device_limits.maxViewports);
3477 }
3478
3479 return skip;
3480}
3481
3482
3483bool pv_vkCmdSetCoarseSampleOrderNV(
3484 VkCommandBuffer commandBuffer,
3485 VkCoarseSampleOrderTypeNV sampleOrderType,
3486 uint32_t customSampleOrderCount,
3487 const VkCoarseSampleOrderCustomNV* pCustomSampleOrders)
3488{
3489 bool skip = false;
3490
3491 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3492 debug_report_data *report_data = device_data->report_data;
3493
3494 if (sampleOrderType != VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV &&
3495 customSampleOrderCount != 0) {
3496 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3497 HandleToUint64(commandBuffer), "VUID-vkCmdSetCoarseSampleOrderNV-sampleOrderType-02081",
3498 "vkCmdSetCoarseSampleOrderNV: If sampleOrderType is not VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV, "
3499 "customSampleOrderCount must be 0.");
3500 }
3501
3502 for (uint32_t order_i = 0; order_i < customSampleOrderCount; ++order_i) {
3503 skip |= ValidateCoarseSampleOrderCustomNV(device_data, &pCustomSampleOrders[order_i]);
3504 }
3505
3506 return skip;
3507}
3508
3509
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003510VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetDeviceProcAddr(VkDevice device, const char *funcName) {
Mark Lobodzinskib7a26382018-07-02 13:14:26 -06003511 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
3512 if (!ApiParentExtensionEnabled(funcName, device_data->extensions.device_extension_set)) {
3513 return nullptr;
3514 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003515 const auto item = name_to_funcptr_map.find(funcName);
3516 if (item != name_to_funcptr_map.end()) {
3517 return reinterpret_cast<PFN_vkVoidFunction>(item->second);
3518 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003519 const auto &table = device_data->dispatch_table;
3520 if (!table.GetDeviceProcAddr) return nullptr;
3521 return table.GetDeviceProcAddr(device, funcName);
3522}
3523
3524VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetInstanceProcAddr(VkInstance instance, const char *funcName) {
3525 const auto item = name_to_funcptr_map.find(funcName);
3526 if (item != name_to_funcptr_map.end()) {
3527 return reinterpret_cast<PFN_vkVoidFunction>(item->second);
3528 }
3529
3530 auto instance_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map);
3531 auto &table = instance_data->dispatch_table;
3532 if (!table.GetInstanceProcAddr) return nullptr;
3533 return table.GetInstanceProcAddr(instance, funcName);
3534}
3535
3536VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetPhysicalDeviceProcAddr(VkInstance instance, const char *funcName) {
3537 assert(instance);
3538 auto instance_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map);
3539
3540 if (!instance_data->dispatch_table.GetPhysicalDeviceProcAddr) return nullptr;
3541 return instance_data->dispatch_table.GetPhysicalDeviceProcAddr(instance, funcName);
3542}
3543
3544// If additional validation is needed outside of the generated checks, a manual routine can be added to this file
3545// and the address filled in here. The autogenerated source will call these routines if the pointers are not NULL.
Petr Krausc8655be2017-09-27 18:56:51 +02003546void InitializeManualParameterValidationFunctionPointers() {
Dave Houltonb3bbec72018-01-17 10:13:33 -07003547 custom_functions["vkGetDeviceQueue"] = (void *)pv_vkGetDeviceQueue;
3548 custom_functions["vkCreateBuffer"] = (void *)pv_vkCreateBuffer;
3549 custom_functions["vkCreateImage"] = (void *)pv_vkCreateImage;
3550 custom_functions["vkCreateImageView"] = (void *)pv_vkCreateImageView;
3551 custom_functions["vkCreateGraphicsPipelines"] = (void *)pv_vkCreateGraphicsPipelines;
3552 custom_functions["vkCreateComputePipelines"] = (void *)pv_vkCreateComputePipelines;
3553 custom_functions["vkCreateSampler"] = (void *)pv_vkCreateSampler;
3554 custom_functions["vkCreateDescriptorSetLayout"] = (void *)pv_vkCreateDescriptorSetLayout;
3555 custom_functions["vkFreeDescriptorSets"] = (void *)pv_vkFreeDescriptorSets;
3556 custom_functions["vkUpdateDescriptorSets"] = (void *)pv_vkUpdateDescriptorSets;
3557 custom_functions["vkCreateRenderPass"] = (void *)pv_vkCreateRenderPass;
3558 custom_functions["vkBeginCommandBuffer"] = (void *)pv_vkBeginCommandBuffer;
3559 custom_functions["vkCmdSetViewport"] = (void *)pv_vkCmdSetViewport;
3560 custom_functions["vkCmdSetScissor"] = (void *)pv_vkCmdSetScissor;
Petr Kraus299ba622017-11-24 03:09:03 +01003561 custom_functions["vkCmdSetLineWidth"] = (void *)pv_vkCmdSetLineWidth;
Dave Houltonb3bbec72018-01-17 10:13:33 -07003562 custom_functions["vkCmdDraw"] = (void *)pv_vkCmdDraw;
3563 custom_functions["vkCmdDrawIndirect"] = (void *)pv_vkCmdDrawIndirect;
3564 custom_functions["vkCmdDrawIndexedIndirect"] = (void *)pv_vkCmdDrawIndexedIndirect;
3565 custom_functions["vkCmdCopyImage"] = (void *)pv_vkCmdCopyImage;
3566 custom_functions["vkCmdBlitImage"] = (void *)pv_vkCmdBlitImage;
3567 custom_functions["vkCmdCopyBufferToImage"] = (void *)pv_vkCmdCopyBufferToImage;
3568 custom_functions["vkCmdCopyImageToBuffer"] = (void *)pv_vkCmdCopyImageToBuffer;
3569 custom_functions["vkCmdUpdateBuffer"] = (void *)pv_vkCmdUpdateBuffer;
3570 custom_functions["vkCmdFillBuffer"] = (void *)pv_vkCmdFillBuffer;
3571 custom_functions["vkCreateSwapchainKHR"] = (void *)pv_vkCreateSwapchainKHR;
3572 custom_functions["vkQueuePresentKHR"] = (void *)pv_vkQueuePresentKHR;
3573 custom_functions["vkCreateDescriptorPool"] = (void *)pv_vkCreateDescriptorPool;
3574 custom_functions["vkCmdDispatch"] = (void *)pv_vkCmdDispatch;
Mark Lobodzinskibf973a12018-03-01 08:50:21 -07003575 custom_functions["vkCmdDispatchBaseKHR"] = (void *)pv_vkCmdDispatchBaseKHR;
Jeff Bolz3e71f782018-08-29 23:15:45 -05003576 custom_functions["vkCmdSetExclusiveScissorNV"] = (void *)pv_vkCmdSetExclusiveScissorNV;
Jeff Bolz9af91c52018-09-01 21:53:57 -05003577 custom_functions["vkCmdSetViewportShadingRatePaletteNV"] = (void *)pv_vkCmdSetViewportShadingRatePaletteNV;
3578 custom_functions["vkCmdSetCoarseSampleOrderNV"] = (void *)pv_vkCmdSetCoarseSampleOrderNV;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003579}
3580
3581} // namespace parameter_validation
3582
3583VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateInstanceExtensionProperties(const char *pLayerName, uint32_t *pCount,
3584 VkExtensionProperties *pProperties) {
3585 return parameter_validation::vkEnumerateInstanceExtensionProperties(pLayerName, pCount, pProperties);
3586}
3587
3588VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateInstanceLayerProperties(uint32_t *pCount,
3589 VkLayerProperties *pProperties) {
3590 return parameter_validation::vkEnumerateInstanceLayerProperties(pCount, pProperties);
3591}
3592
3593VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateDeviceLayerProperties(VkPhysicalDevice physicalDevice, uint32_t *pCount,
3594 VkLayerProperties *pProperties) {
3595 // the layer command handles VK_NULL_HANDLE just fine internally
3596 assert(physicalDevice == VK_NULL_HANDLE);
3597 return parameter_validation::vkEnumerateDeviceLayerProperties(VK_NULL_HANDLE, pCount, pProperties);
3598}
3599
3600VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateDeviceExtensionProperties(VkPhysicalDevice physicalDevice,
3601 const char *pLayerName, uint32_t *pCount,
3602 VkExtensionProperties *pProperties) {
3603 // the layer command handles VK_NULL_HANDLE just fine internally
3604 assert(physicalDevice == VK_NULL_HANDLE);
3605 return parameter_validation::vkEnumerateDeviceExtensionProperties(VK_NULL_HANDLE, pLayerName, pCount, pProperties);
3606}
3607
3608VK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetDeviceProcAddr(VkDevice dev, const char *funcName) {
3609 return parameter_validation::vkGetDeviceProcAddr(dev, funcName);
3610}
3611
3612VK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetInstanceProcAddr(VkInstance instance, const char *funcName) {
3613 return parameter_validation::vkGetInstanceProcAddr(instance, funcName);
3614}
3615
3616VK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vk_layerGetPhysicalDeviceProcAddr(VkInstance instance,
3617 const char *funcName) {
3618 return parameter_validation::vkGetPhysicalDeviceProcAddr(instance, funcName);
3619}
3620
Lenny Komow2d0cbbe2018-05-24 13:38:05 -06003621VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL VKAPI_CALL
3622vkNegotiateLoaderLayerInterfaceVersion(VkNegotiateLayerInterface *pVersionStruct) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003623 assert(pVersionStruct != NULL);
3624 assert(pVersionStruct->sType == LAYER_NEGOTIATE_INTERFACE_STRUCT);
3625
3626 // Fill in the function pointers if our version is at least capable of having the structure contain them.
3627 if (pVersionStruct->loaderLayerInterfaceVersion >= 2) {
3628 pVersionStruct->pfnGetInstanceProcAddr = vkGetInstanceProcAddr;
3629 pVersionStruct->pfnGetDeviceProcAddr = vkGetDeviceProcAddr;
3630 pVersionStruct->pfnGetPhysicalDeviceProcAddr = vk_layerGetPhysicalDeviceProcAddr;
3631 }
3632
3633 if (pVersionStruct->loaderLayerInterfaceVersion < CURRENT_LOADER_LAYER_INTERFACE_VERSION) {
3634 parameter_validation::loader_layer_if_version = pVersionStruct->loaderLayerInterfaceVersion;
3635 } else if (pVersionStruct->loaderLayerInterfaceVersion > CURRENT_LOADER_LAYER_INTERFACE_VERSION) {
3636 pVersionStruct->loaderLayerInterfaceVersion = CURRENT_LOADER_LAYER_INTERFACE_VERSION;
3637 }
3638
3639 return VK_SUCCESS;
3640}