blob: 81f5c61ed9214c33c04f1d6ebf1db1047ec54e8a [file] [log] [blame]
sfricke-samsung11ea8ed2020-01-07 22:24:56 -08001/* Copyright (c) 2015-2020 The Khronos Group Inc.
2 * Copyright (c) 2015-2020 Valve Corporation
3 * Copyright (c) 2015-2020 LunarG, Inc.
4 * Copyright (C) 2015-2020 Google Inc.
Mark Lobodzinskid4950072017-08-01 13:02:20 -06005 *
6 * Licensed under the Apache License, Version 2.0 (the "License");
7 * you may not use this file except in compliance with the License.
8 * You may obtain a copy of the License at
9 *
10 * http://www.apache.org/licenses/LICENSE-2.0
11 *
12 * Unless required by applicable law or agreed to in writing, software
13 * distributed under the License is distributed on an "AS IS" BASIS,
14 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15 * See the License for the specific language governing permissions and
16 * limitations under the License.
17 *
18 * Author: Mark Lobodzinski <mark@LunarG.com>
John Zulaufa999d1b2018-11-29 13:38:40 -070019 * Author: John Zulauf <jzulauf@lunarg.com>
Mark Lobodzinskid4950072017-08-01 13:02:20 -060020 */
21
orbea80ddc062019-09-10 10:33:19 -070022#include <cmath>
Shahbaz Youssefi6be11412019-01-10 15:29:30 -050023
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -070024#include "chassis.h"
25#include "stateless_validation.h"
Mark Lobodzinskie514d1a2019-03-12 08:47:45 -060026#include "layer_chassis_dispatch.h"
Tobias Hectord942eb92018-10-22 15:18:56 +010027
Mark Lobodzinskid4950072017-08-01 13:02:20 -060028static const int MaxParamCheckerStringLength = 256;
29
John Zulauf71968502017-10-26 13:51:15 -060030template <typename T>
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -070031inline bool in_inclusive_range(const T &value, const T &min, const T &max) {
John Zulauf71968502017-10-26 13:51:15 -060032 // Using only < for generality and || for early abort
33 return !((value < min) || (max < value));
34}
35
Mark Lobodzinskibf599b92018-12-31 12:15:55 -070036bool StatelessValidation::validate_string(const char *apiName, const ParameterName &stringName, const std::string &vuid,
Jeff Bolz46c0ea02019-10-09 13:06:29 -050037 const char *validateString) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -060038 bool skip = false;
39
40 VkStringErrorFlags result = vk_string_validate(MaxParamCheckerStringLength, validateString);
41
42 if (result == VK_STRING_ERROR_NONE) {
43 return skip;
44 } else if (result & VK_STRING_ERROR_LENGTH) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -070045 skip = LogError(device, vuid, "%s: string %s exceeds max length %d", apiName, stringName.get_name().c_str(),
46 MaxParamCheckerStringLength);
Mark Lobodzinskid4950072017-08-01 13:02:20 -060047 } else if (result & VK_STRING_ERROR_BAD_DATA) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -070048 skip = LogError(device, vuid, "%s: string %s contains invalid characters or is badly formed", apiName,
49 stringName.get_name().c_str());
Mark Lobodzinskid4950072017-08-01 13:02:20 -060050 }
51 return skip;
52}
53
Jeff Bolz46c0ea02019-10-09 13:06:29 -050054bool StatelessValidation::validate_api_version(uint32_t api_version, uint32_t effective_api_version) const {
John Zulauf620755c2018-04-16 11:00:43 -060055 bool skip = false;
56 uint32_t api_version_nopatch = VK_MAKE_VERSION(VK_VERSION_MAJOR(api_version), VK_VERSION_MINOR(api_version), 0);
57 if (api_version_nopatch != effective_api_version) {
58 if (api_version_nopatch < VK_API_VERSION_1_0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -070059 skip |= LogError(instance, kVUIDUndefined,
60 "Invalid CreateInstance->pCreateInfo->pApplicationInfo.apiVersion number (0x%08x). "
61 "Using VK_API_VERSION_%" PRIu32 "_%" PRIu32 ".",
62 api_version, VK_VERSION_MAJOR(effective_api_version), VK_VERSION_MINOR(effective_api_version));
John Zulauf620755c2018-04-16 11:00:43 -060063 } else {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -070064 skip |= LogWarning(instance, kVUIDUndefined,
65 "Unrecognized CreateInstance->pCreateInfo->pApplicationInfo.apiVersion number (0x%08x). "
66 "Assuming VK_API_VERSION_%" PRIu32 "_%" PRIu32 ".",
67 api_version, VK_VERSION_MAJOR(effective_api_version), VK_VERSION_MINOR(effective_api_version));
John Zulauf620755c2018-04-16 11:00:43 -060068 }
69 }
70 return skip;
71}
72
Jeff Bolz46c0ea02019-10-09 13:06:29 -050073bool StatelessValidation::validate_instance_extensions(const VkInstanceCreateInfo *pCreateInfo) const {
John Zulauf620755c2018-04-16 11:00:43 -060074 bool skip = false;
Mark Lobodzinski05cce202019-08-27 10:28:37 -060075 // Create and use a local instance extension object, as an actual instance has not been created yet
76 uint32_t specified_version = (pCreateInfo->pApplicationInfo ? pCreateInfo->pApplicationInfo->apiVersion : VK_API_VERSION_1_0);
77 InstanceExtensions local_instance_extensions;
78 local_instance_extensions.InitFromInstanceCreateInfo(specified_version, pCreateInfo);
79
John Zulauf620755c2018-04-16 11:00:43 -060080 for (uint32_t i = 0; i < pCreateInfo->enabledExtensionCount; i++) {
Mark Lobodzinski05cce202019-08-27 10:28:37 -060081 skip |= validate_extension_reqs(local_instance_extensions, "VUID-vkCreateInstance-ppEnabledExtensionNames-01388",
82 "instance", pCreateInfo->ppEnabledExtensionNames[i]);
John Zulauf620755c2018-04-16 11:00:43 -060083 }
84
85 return skip;
86}
87
Mark Lobodzinskibece6c12020-08-27 15:34:02 -060088bool StatelessValidation::SupportedByPdev(const VkPhysicalDevice physical_device, const std::string ext_name) const {
89 if (instance_extensions.vk_khr_get_physical_device_properties_2) {
90 // Struct is legal IF it's supported
91 const auto &dev_exts_enumerated = device_extensions_enumerated.find(physical_device);
92 if (dev_exts_enumerated == device_extensions_enumerated.end()) return true;
93 auto enum_iter = dev_exts_enumerated->second.find(ext_name);
94 if (enum_iter != dev_exts_enumerated->second.cend()) {
95 return true;
96 }
97 }
98 return false;
99}
100
Tony-LunarG866843d2020-05-13 11:22:42 -0600101bool StatelessValidation::validate_validation_features(const VkInstanceCreateInfo *pCreateInfo,
102 const VkValidationFeaturesEXT *validation_features) const {
103 bool skip = false;
104 bool debug_printf = false;
105 bool gpu_assisted = false;
106 bool reserve_slot = false;
107 for (uint32_t i = 0; i < validation_features->enabledValidationFeatureCount; i++) {
108 switch (validation_features->pEnabledValidationFeatures[i]) {
109 case VK_VALIDATION_FEATURE_ENABLE_GPU_ASSISTED_EXT:
110 gpu_assisted = true;
111 break;
112
113 case VK_VALIDATION_FEATURE_ENABLE_DEBUG_PRINTF_EXT:
114 debug_printf = true;
115 break;
116
117 case VK_VALIDATION_FEATURE_ENABLE_GPU_ASSISTED_RESERVE_BINDING_SLOT_EXT:
118 reserve_slot = true;
119 break;
120
121 default:
122 break;
123 }
124 }
125 if (reserve_slot && !gpu_assisted) {
126 skip |= LogError(instance, "VUID-VkValidationFeaturesEXT-pEnabledValidationFeatures-02967",
127 "If VK_VALIDATION_FEATURE_ENABLE_GPU_ASSISTED_RESERVE_BINDING_SLOT_EXT is in pEnabledValidationFeatures, "
128 "VK_VALIDATION_FEATURE_ENABLE_GPU_ASSISTED_EXT must also be in pEnabledValidationFeatures.");
129 }
130 if (gpu_assisted && debug_printf) {
131 skip |= LogError(instance, "VUID-VkValidationFeaturesEXT-pEnabledValidationFeatures-02968",
132 "If VK_VALIDATION_FEATURE_ENABLE_GPU_ASSISTED_EXT is in pEnabledValidationFeatures, "
133 "VK_VALIDATION_FEATURE_ENABLE_DEBUG_PRINTF_EXT must not also be in pEnabledValidationFeatures.");
134 }
135
136 return skip;
137}
138
John Zulauf620755c2018-04-16 11:00:43 -0600139template <typename ExtensionState>
Tony-LunarG2ec96bb2019-11-26 13:43:02 -0700140ExtEnabled extension_state_by_name(const ExtensionState &extensions, const char *extension_name) {
141 if (!extension_name) return kNotEnabled; // null strings specify nothing
John Zulauf620755c2018-04-16 11:00:43 -0600142 auto info = ExtensionState::get_info(extension_name);
Tony-LunarG2ec96bb2019-11-26 13:43:02 -0700143 ExtEnabled state =
144 info.state ? extensions.*(info.state) : kNotEnabled; // unknown extensions can't be enabled in extension struct
John Zulauf620755c2018-04-16 11:00:43 -0600145 return state;
146}
147
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700148bool StatelessValidation::manual_PreCallValidateCreateInstance(const VkInstanceCreateInfo *pCreateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -0500149 const VkAllocationCallbacks *pAllocator,
150 VkInstance *pInstance) const {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700151 bool skip = false;
152 // Note: From the spec--
153 // Providing a NULL VkInstanceCreateInfo::pApplicationInfo or providing an apiVersion of 0 is equivalent to providing
154 // an apiVersion of VK_MAKE_VERSION(1, 0, 0). (a.k.a. VK_API_VERSION_1_0)
155 uint32_t local_api_version = (pCreateInfo->pApplicationInfo && pCreateInfo->pApplicationInfo->apiVersion)
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700156 ? pCreateInfo->pApplicationInfo->apiVersion
157 : VK_API_VERSION_1_0;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700158 skip |= validate_api_version(local_api_version, api_version);
159 skip |= validate_instance_extensions(pCreateInfo);
Tony-LunarG866843d2020-05-13 11:22:42 -0600160 const auto *validation_features = lvl_find_in_chain<VkValidationFeaturesEXT>(pCreateInfo->pNext);
161 if (validation_features) skip |= validate_validation_features(pCreateInfo, validation_features);
162
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700163 return skip;
164}
165
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700166void StatelessValidation::PostCallRecordCreateInstance(const VkInstanceCreateInfo *pCreateInfo,
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -0700167 const VkAllocationCallbacks *pAllocator, VkInstance *pInstance,
168 VkResult result) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700169 auto instance_data = GetLayerDataPtr(get_dispatch_key(*pInstance), layer_data_map);
170 // Copy extension data into local object
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -0700171 if (result != VK_SUCCESS) return;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700172 this->instance_extensions = instance_data->instance_extensions;
Mark Lobodzinski2e40a132020-08-10 14:51:41 -0600173
174 uint32_t pdev_count = 0;
175 DispatchEnumeratePhysicalDevices(*pInstance, &pdev_count, nullptr);
176 std::vector<VkPhysicalDevice> physical_devices;
177 physical_devices.resize(pdev_count);
178 DispatchEnumeratePhysicalDevices(*pInstance, &pdev_count, physical_devices.data());
179
Mark Lobodzinski2e40a132020-08-10 14:51:41 -0600180 for (uint32_t i = 0; i < physical_devices.size(); i++) {
181 auto phys_dev_props = new VkPhysicalDeviceProperties;
182 DispatchGetPhysicalDeviceProperties(physical_devices[i], phys_dev_props);
183 physical_device_properties_map[physical_devices[i]] = phys_dev_props;
Mark Lobodzinskibece6c12020-08-27 15:34:02 -0600184
185 // Enumerate the Device Ext Properties to save the PhysicalDevice supported extension state
186 uint32_t ext_count = 0;
187 std::unordered_set<std::string> dev_exts_enumerated{};
188 std::vector<VkExtensionProperties> ext_props{};
189 instance_dispatch_table.EnumerateDeviceExtensionProperties(physical_devices[i], nullptr, &ext_count, nullptr);
190 ext_props.resize(ext_count);
191 instance_dispatch_table.EnumerateDeviceExtensionProperties(physical_devices[i], nullptr, &ext_count, ext_props.data());
192 for (uint32_t j = 0; j < ext_count; j++) {
193 dev_exts_enumerated.insert(ext_props[j].extensionName);
194 }
195 device_extensions_enumerated[physical_devices[i]] = std::move(dev_exts_enumerated);
Mark Lobodzinski2e40a132020-08-10 14:51:41 -0600196 }
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700197}
198
Mark Lobodzinski2e40a132020-08-10 14:51:41 -0600199void StatelessValidation::PreCallRecordDestroyInstance(VkInstance instance, const VkAllocationCallbacks *pAllocator) {
200 for (auto it = physical_device_properties_map.begin(); it != physical_device_properties_map.end();) {
201 delete (it->second);
202 it = physical_device_properties_map.erase(it);
203 }
204};
205
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700206void StatelessValidation::PostCallRecordCreateDevice(VkPhysicalDevice physicalDevice, const VkDeviceCreateInfo *pCreateInfo,
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -0700207 const VkAllocationCallbacks *pAllocator, VkDevice *pDevice, VkResult result) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700208 auto device_data = GetLayerDataPtr(get_dispatch_key(*pDevice), layer_data_map);
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -0700209 if (result != VK_SUCCESS) return;
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700210 ValidationObject *validation_data = GetValidationObject(device_data->object_dispatch, LayerObjectTypeParameterValidation);
211 StatelessValidation *stateless_validation = static_cast<StatelessValidation *>(validation_data);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700212
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700213 // Parmeter validation also uses extension data
214 stateless_validation->device_extensions = this->device_extensions;
215
216 VkPhysicalDeviceProperties device_properties = {};
217 // Need to get instance and do a getlayerdata call...
Tony-LunarG152a88b2019-03-20 15:42:24 -0600218 DispatchGetPhysicalDeviceProperties(physicalDevice, &device_properties);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700219 memcpy(&stateless_validation->device_limits, &device_properties.limits, sizeof(VkPhysicalDeviceLimits));
220
221 if (device_extensions.vk_nv_shading_rate_image) {
222 // Get the needed shading rate image limits
223 auto shading_rate_image_props = lvl_init_struct<VkPhysicalDeviceShadingRateImagePropertiesNV>();
224 auto prop2 = lvl_init_struct<VkPhysicalDeviceProperties2KHR>(&shading_rate_image_props);
Tony-LunarG152a88b2019-03-20 15:42:24 -0600225 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700226 phys_dev_ext_props.shading_rate_image_props = shading_rate_image_props;
227 }
228
229 if (device_extensions.vk_nv_mesh_shader) {
230 // Get the needed mesh shader limits
231 auto mesh_shader_props = lvl_init_struct<VkPhysicalDeviceMeshShaderPropertiesNV>();
232 auto prop2 = lvl_init_struct<VkPhysicalDeviceProperties2KHR>(&mesh_shader_props);
Tony-LunarG152a88b2019-03-20 15:42:24 -0600233 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700234 phys_dev_ext_props.mesh_shader_props = mesh_shader_props;
235 }
236
Jason Macnak5c954952019-07-09 15:46:12 -0700237 if (device_extensions.vk_nv_ray_tracing) {
238 // Get the needed ray tracing limits
239 auto ray_tracing_props = lvl_init_struct<VkPhysicalDeviceRayTracingPropertiesNV>();
240 auto prop2 = lvl_init_struct<VkPhysicalDeviceProperties2KHR>(&ray_tracing_props);
241 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
Jeff Bolz443c2ca2020-03-19 12:11:51 -0500242 phys_dev_ext_props.ray_tracing_propsNV = ray_tracing_props;
243 }
244
245 if (device_extensions.vk_khr_ray_tracing) {
246 // Get the needed ray tracing limits
247 auto ray_tracing_props = lvl_init_struct<VkPhysicalDeviceRayTracingPropertiesKHR>();
248 auto prop2 = lvl_init_struct<VkPhysicalDeviceProperties2KHR>(&ray_tracing_props);
249 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
250 phys_dev_ext_props.ray_tracing_propsKHR = ray_tracing_props;
Jason Macnak5c954952019-07-09 15:46:12 -0700251 }
252
Mark Lobodzinski953b7bc2019-12-19 13:50:10 -0700253 if (device_extensions.vk_ext_transform_feedback) {
254 // Get the needed transform feedback limits
255 auto transform_feedback_props = lvl_init_struct<VkPhysicalDeviceTransformFeedbackPropertiesEXT>();
256 auto prop2 = lvl_init_struct<VkPhysicalDeviceProperties2KHR>(&transform_feedback_props);
257 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
258 phys_dev_ext_props.transform_feedback_props = transform_feedback_props;
259 }
260
Jasper St. Pierrea49b4be2019-02-05 17:48:57 -0800261 stateless_validation->phys_dev_ext_props = this->phys_dev_ext_props;
262
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700263 // Save app-enabled features in this device's validation object
264 // The enabled features can come from either pEnabledFeatures, or from the pNext chain
Petr Kraus715bcc72019-08-15 17:17:33 +0200265 const auto *features2 = lvl_find_in_chain<VkPhysicalDeviceFeatures2>(pCreateInfo->pNext);
266 safe_VkPhysicalDeviceFeatures2 tmp_features2_state;
267 tmp_features2_state.sType = VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_FEATURES_2;
268 if (features2) {
269 tmp_features2_state.features = features2->features;
270 } else if (pCreateInfo->pEnabledFeatures) {
271 tmp_features2_state.features = *pCreateInfo->pEnabledFeatures;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700272 } else {
Petr Kraus715bcc72019-08-15 17:17:33 +0200273 tmp_features2_state.features = {};
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700274 }
Petr Kraus715bcc72019-08-15 17:17:33 +0200275 // Use pCreateInfo->pNext to get full chain
Tony-LunarG6c3c5452019-12-13 10:37:38 -0700276 stateless_validation->device_createinfo_pnext = SafePnextCopy(pCreateInfo->pNext);
Petr Kraus715bcc72019-08-15 17:17:33 +0200277 stateless_validation->physical_device_features2 = tmp_features2_state;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700278}
279
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700280bool StatelessValidation::manual_PreCallValidateCreateDevice(VkPhysicalDevice physicalDevice, const VkDeviceCreateInfo *pCreateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -0500281 const VkAllocationCallbacks *pAllocator, VkDevice *pDevice) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600282 bool skip = false;
283
Petr Kraus6c4bdce2019-08-27 17:35:01 +0200284 for (size_t i = 0; i < pCreateInfo->enabledLayerCount; i++) {
285 skip |= validate_string("vkCreateDevice", "pCreateInfo->ppEnabledLayerNames",
286 "VUID-VkDeviceCreateInfo-ppEnabledLayerNames-parameter", pCreateInfo->ppEnabledLayerNames[i]);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600287 }
288
Petr Kraus6c4bdce2019-08-27 17:35:01 +0200289 for (size_t i = 0; i < pCreateInfo->enabledExtensionCount; i++) {
290 skip |=
291 validate_string("vkCreateDevice", "pCreateInfo->ppEnabledExtensionNames",
292 "VUID-VkDeviceCreateInfo-ppEnabledExtensionNames-parameter", pCreateInfo->ppEnabledExtensionNames[i]);
293 skip |= validate_extension_reqs(device_extensions, "VUID-vkCreateDevice-ppEnabledExtensionNames-01387", "device",
294 pCreateInfo->ppEnabledExtensionNames[i]);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600295 }
296
Petr Kraus6c4bdce2019-08-27 17:35:01 +0200297 {
Tony-LunarG2ec96bb2019-11-26 13:43:02 -0700298 bool maint1 = IsExtEnabled(extension_state_by_name(device_extensions, VK_KHR_MAINTENANCE1_EXTENSION_NAME));
299 bool negative_viewport =
300 IsExtEnabled(extension_state_by_name(device_extensions, VK_AMD_NEGATIVE_VIEWPORT_HEIGHT_EXTENSION_NAME));
Petr Kraus6c4bdce2019-08-27 17:35:01 +0200301 if (maint1 && negative_viewport) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700302 skip |= LogError(device, "VUID-VkDeviceCreateInfo-ppEnabledExtensionNames-00374",
303 "VkDeviceCreateInfo->ppEnabledExtensionNames must not simultaneously include VK_KHR_maintenance1 and "
304 "VK_AMD_negative_viewport_height.");
Petr Kraus6c4bdce2019-08-27 17:35:01 +0200305 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600306 }
307
Jeff Bolz4563f2a2019-12-10 13:30:30 -0600308 {
309 bool khr_bda = IsExtEnabled(extension_state_by_name(device_extensions, VK_KHR_BUFFER_DEVICE_ADDRESS_EXTENSION_NAME));
310 bool ext_bda = IsExtEnabled(extension_state_by_name(device_extensions, VK_EXT_BUFFER_DEVICE_ADDRESS_EXTENSION_NAME));
311 if (khr_bda && ext_bda) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700312 skip |= LogError(device, "VUID-VkDeviceCreateInfo-ppEnabledExtensionNames-03328",
313 "VkDeviceCreateInfo->ppEnabledExtensionNames must not contain both VK_KHR_buffer_device_address and "
314 "VK_EXT_buffer_device_address.");
Jeff Bolz4563f2a2019-12-10 13:30:30 -0600315 }
316 }
317
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600318 if (pCreateInfo->pNext != NULL && pCreateInfo->pEnabledFeatures) {
319 // Check for get_physical_device_properties2 struct
John Zulaufde972ac2017-10-26 12:07:05 -0600320 const auto *features2 = lvl_find_in_chain<VkPhysicalDeviceFeatures2KHR>(pCreateInfo->pNext);
321 if (features2) {
322 // Cannot include VkPhysicalDeviceFeatures2KHR and have non-null pEnabledFeatures
sfricke-samsung590ae1e2020-04-25 01:18:05 -0700323 skip |= LogError(device, "VUID-VkDeviceCreateInfo-pNext-00373",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700324 "VkDeviceCreateInfo->pNext includes a VkPhysicalDeviceFeatures2KHR struct when "
325 "pCreateInfo->pEnabledFeatures is non-NULL.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600326 }
327 }
328
Locke77fad1c2019-04-16 13:09:03 -0600329 auto features2 = lvl_find_in_chain<VkPhysicalDeviceFeatures2>(pCreateInfo->pNext);
Jeff Bolz165818a2020-05-08 11:19:03 -0500330 const VkPhysicalDeviceFeatures *features = features2 ? &features2->features : pCreateInfo->pEnabledFeatures;
331 const auto *robustness2_features = lvl_find_in_chain<VkPhysicalDeviceRobustness2FeaturesEXT>(pCreateInfo->pNext);
332 if (features && robustness2_features && robustness2_features->robustBufferAccess2 && !features->robustBufferAccess) {
333 skip |= LogError(device, "VUID-VkPhysicalDeviceRobustness2FeaturesEXT-robustBufferAccess2-04000",
334 "If robustBufferAccess2 is enabled then robustBufferAccess must be enabled.");
335 }
sourav parmara24fb7b2020-05-26 10:50:04 -0700336 const auto *raytracing_features = lvl_find_in_chain<VkPhysicalDeviceRayTracingFeaturesKHR>(pCreateInfo->pNext);
337 if (raytracing_features && raytracing_features->rayTracingShaderGroupHandleCaptureReplayMixed &&
338 !raytracing_features->rayTracingShaderGroupHandleCaptureReplay) {
339 skip |= LogError(device, "VUID-VkPhysicalDeviceRayTracingFeaturesKHR-rayTracingShaderGroupHandleCaptureReplayMixed-03348",
340 "If rayTracingShaderGroupHandleCaptureReplayMixed is VK_TRUE, rayTracingShaderGroupHandleCaptureReplay "
341 "must also be VK_TRUE.");
342 }
Locke77fad1c2019-04-16 13:09:03 -0600343 auto vertex_attribute_divisor_features =
344 lvl_find_in_chain<VkPhysicalDeviceVertexAttributeDivisorFeaturesEXT>(pCreateInfo->pNext);
Mark Lobodzinski3e66ae82020-08-12 16:27:29 -0600345 if (vertex_attribute_divisor_features && (!device_extensions.vk_ext_vertex_attribute_divisor)) {
346 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
347 "VkDeviceCreateInfo->pNext includes a VkPhysicalDeviceVertexAttributeDivisorFeaturesEXT "
348 "struct, VK_EXT_vertex_attribute_divisor must be enabled when it creates a device.");
Locke77fad1c2019-04-16 13:09:03 -0600349 }
350
Tony-LunarG28017bc2020-01-23 14:40:25 -0700351 const auto *vulkan_11_features = lvl_find_in_chain<VkPhysicalDeviceVulkan11Features>(pCreateInfo->pNext);
352 if (vulkan_11_features) {
353 const VkBaseOutStructure *current = reinterpret_cast<const VkBaseOutStructure *>(pCreateInfo->pNext);
354 while (current) {
355 if (current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_16BIT_STORAGE_FEATURES ||
356 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_MULTIVIEW_FEATURES ||
357 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_VARIABLE_POINTERS_FEATURES ||
358 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_PROTECTED_MEMORY_FEATURES ||
359 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SAMPLER_YCBCR_CONVERSION_FEATURES ||
360 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SHADER_DRAW_PARAMETERS_FEATURES) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700361 skip |= LogError(
362 instance, "VUID-VkDeviceCreateInfo-pNext-02829",
Tony-LunarG28017bc2020-01-23 14:40:25 -0700363 "If the pNext chain includes a VkPhysicalDeviceVulkan11Features structure, then it must not include a "
364 "VkPhysicalDevice16BitStorageFeatures, VkPhysicalDeviceMultiviewFeatures, "
365 "VkPhysicalDeviceVariablePointersFeatures, VkPhysicalDeviceProtectedMemoryFeatures, "
366 "VkPhysicalDeviceSamplerYcbcrConversionFeatures, or VkPhysicalDeviceShaderDrawParametersFeatures structure");
367 break;
368 }
369 current = reinterpret_cast<const VkBaseOutStructure *>(current->pNext);
370 }
371 }
372
373 const auto *vulkan_12_features = lvl_find_in_chain<VkPhysicalDeviceVulkan12Features>(pCreateInfo->pNext);
374 if (vulkan_12_features) {
375 const VkBaseOutStructure *current = reinterpret_cast<const VkBaseOutStructure *>(pCreateInfo->pNext);
376 while (current) {
377 if (current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_8BIT_STORAGE_FEATURES ||
378 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SHADER_ATOMIC_INT64_FEATURES ||
379 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SHADER_FLOAT16_INT8_FEATURES ||
380 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_DESCRIPTOR_INDEXING_FEATURES ||
381 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SCALAR_BLOCK_LAYOUT_FEATURES ||
382 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_IMAGELESS_FRAMEBUFFER_FEATURES ||
383 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_UNIFORM_BUFFER_STANDARD_LAYOUT_FEATURES ||
384 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SHADER_SUBGROUP_EXTENDED_TYPES_FEATURES ||
385 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SEPARATE_DEPTH_STENCIL_LAYOUTS_FEATURES ||
386 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_HOST_QUERY_RESET_FEATURES ||
387 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_TIMELINE_SEMAPHORE_FEATURES ||
388 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_BUFFER_DEVICE_ADDRESS_FEATURES ||
389 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_VULKAN_MEMORY_MODEL_FEATURES) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700390 skip |= LogError(
391 instance, "VUID-VkDeviceCreateInfo-pNext-02830",
Tony-LunarG28017bc2020-01-23 14:40:25 -0700392 "If the pNext chain includes a VkPhysicalDeviceVulkan12Features structure, then it must not include a "
393 "VkPhysicalDevice8BitStorageFeatures, VkPhysicalDeviceShaderAtomicInt64Features, "
394 "VkPhysicalDeviceShaderFloat16Int8Features, VkPhysicalDeviceDescriptorIndexingFeatures, "
395 "VkPhysicalDeviceScalarBlockLayoutFeatures, VkPhysicalDeviceImagelessFramebufferFeatures, "
396 "VkPhysicalDeviceUniformBufferStandardLayoutFeatures, VkPhysicalDeviceShaderSubgroupExtendedTypesFeatures, "
397 "VkPhysicalDeviceSeparateDepthStencilLayoutsFeatures, VkPhysicalDeviceHostQueryResetFeatures, "
398 "VkPhysicalDeviceTimelineSemaphoreFeatures, VkPhysicalDeviceBufferDeviceAddressFeatures, or "
399 "VkPhysicalDeviceVulkanMemoryModelFeatures structure");
400 break;
401 }
402 current = reinterpret_cast<const VkBaseOutStructure *>(current->pNext);
403 }
sfricke-samsungabab4632020-05-04 06:51:46 -0700404 // Check features are enabled if matching extension is passed in as well
405 for (uint32_t i = 0; i < pCreateInfo->enabledExtensionCount; i++) {
406 const char *extension = pCreateInfo->ppEnabledExtensionNames[i];
407 if ((0 == strncmp(extension, VK_KHR_DRAW_INDIRECT_COUNT_EXTENSION_NAME, VK_MAX_EXTENSION_NAME_SIZE)) &&
408 (vulkan_12_features->drawIndirectCount == VK_FALSE)) {
409 skip |= LogError(
410 instance, "VUID-VkDeviceCreateInfo-ppEnabledExtensions-02831",
411 "vkCreateDevice(): %s is enabled but VkPhysicalDeviceVulkan12Features::drawIndirectCount is not VK_TRUE.",
412 VK_KHR_DRAW_INDIRECT_COUNT_EXTENSION_NAME);
413 }
414 if ((0 == strncmp(extension, VK_KHR_SAMPLER_MIRROR_CLAMP_TO_EDGE_EXTENSION_NAME, VK_MAX_EXTENSION_NAME_SIZE)) &&
415 (vulkan_12_features->samplerMirrorClampToEdge == VK_FALSE)) {
416 skip |= LogError(instance, "VUID-VkDeviceCreateInfo-ppEnabledExtensions-02832",
417 "vkCreateDevice(): %s is enabled but VkPhysicalDeviceVulkan12Features::samplerMirrorClampToEdge "
418 "is not VK_TRUE.",
419 VK_KHR_SAMPLER_MIRROR_CLAMP_TO_EDGE_EXTENSION_NAME);
420 }
421 if ((0 == strncmp(extension, VK_EXT_DESCRIPTOR_INDEXING_EXTENSION_NAME, VK_MAX_EXTENSION_NAME_SIZE)) &&
422 (vulkan_12_features->descriptorIndexing == VK_FALSE)) {
423 skip |= LogError(
424 instance, "VUID-VkDeviceCreateInfo-ppEnabledExtensions-02833",
425 "vkCreateDevice(): %s is enabled but VkPhysicalDeviceVulkan12Features::descriptorIndexing is not VK_TRUE.",
426 VK_EXT_DESCRIPTOR_INDEXING_EXTENSION_NAME);
427 }
428 if ((0 == strncmp(extension, VK_EXT_SAMPLER_FILTER_MINMAX_EXTENSION_NAME, VK_MAX_EXTENSION_NAME_SIZE)) &&
429 (vulkan_12_features->samplerFilterMinmax == VK_FALSE)) {
430 skip |= LogError(
431 instance, "VUID-VkDeviceCreateInfo-ppEnabledExtensions-02834",
432 "vkCreateDevice(): %s is enabled but VkPhysicalDeviceVulkan12Features::samplerFilterMinmax is not VK_TRUE.",
433 VK_EXT_SAMPLER_FILTER_MINMAX_EXTENSION_NAME);
434 }
435 if ((0 == strncmp(extension, VK_EXT_SHADER_VIEWPORT_INDEX_LAYER_EXTENSION_NAME, VK_MAX_EXTENSION_NAME_SIZE)) &&
436 ((vulkan_12_features->shaderOutputViewportIndex == VK_FALSE) ||
437 (vulkan_12_features->shaderOutputLayer == VK_FALSE))) {
438 skip |=
439 LogError(instance, "VUID-VkDeviceCreateInfo-ppEnabledExtensions-02835",
440 "vkCreateDevice(): %s is enabled but both VkPhysicalDeviceVulkan12Features::shaderOutputViewportIndex "
441 "and VkPhysicalDeviceVulkan12Features::shaderOutputLayer are not VK_TRUE.",
442 VK_EXT_SHADER_VIEWPORT_INDEX_LAYER_EXTENSION_NAME);
443 }
444 }
Tony-LunarG28017bc2020-01-23 14:40:25 -0700445 }
446
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600447 // Validate pCreateInfo->pQueueCreateInfos
448 if (pCreateInfo->pQueueCreateInfos) {
449 std::unordered_set<uint32_t> set;
450
451 for (uint32_t i = 0; i < pCreateInfo->queueCreateInfoCount; ++i) {
sfricke-samsung590ae1e2020-04-25 01:18:05 -0700452 const VkDeviceQueueCreateInfo &queue_create_info = pCreateInfo->pQueueCreateInfos[i];
453 const uint32_t requested_queue_family = queue_create_info.queueFamilyIndex;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600454 if (requested_queue_family == VK_QUEUE_FAMILY_IGNORED) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700455 skip |=
456 LogError(physicalDevice, "VUID-VkDeviceQueueCreateInfo-queueFamilyIndex-00381",
457 "vkCreateDevice: pCreateInfo->pQueueCreateInfos[%" PRIu32
458 "].queueFamilyIndex is VK_QUEUE_FAMILY_IGNORED, but it is required to provide a valid queue family "
459 "index value.",
460 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600461 } else if (set.count(requested_queue_family)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700462 skip |= LogError(physicalDevice, "VUID-VkDeviceCreateInfo-queueFamilyIndex-00372",
463 "vkCreateDevice: pCreateInfo->pQueueCreateInfos[%" PRIu32 "].queueFamilyIndex (=%" PRIu32
464 ") is not unique within pCreateInfo->pQueueCreateInfos array.",
465 i, requested_queue_family);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600466 } else {
467 set.insert(requested_queue_family);
468 }
469
sfricke-samsung590ae1e2020-04-25 01:18:05 -0700470 if (queue_create_info.pQueuePriorities != nullptr) {
471 for (uint32_t j = 0; j < queue_create_info.queueCount; ++j) {
472 const float queue_priority = queue_create_info.pQueuePriorities[j];
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600473 if (!(queue_priority >= 0.f) || !(queue_priority <= 1.f)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700474 skip |= LogError(physicalDevice, "VUID-VkDeviceQueueCreateInfo-pQueuePriorities-00383",
475 "vkCreateDevice: pCreateInfo->pQueueCreateInfos[%" PRIu32 "].pQueuePriorities[%" PRIu32
476 "] (=%f) is not between 0 and 1 (inclusive).",
477 i, j, queue_priority);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600478 }
479 }
480 }
sfricke-samsung590ae1e2020-04-25 01:18:05 -0700481
482 // Need to know if protectedMemory feature is passed in preCall to creating the device
483 VkBool32 protectedMemory = VK_FALSE;
484 const VkPhysicalDeviceProtectedMemoryFeatures *protected_features =
485 lvl_find_in_chain<VkPhysicalDeviceProtectedMemoryFeatures>(pCreateInfo->pNext);
486 if (protected_features) {
487 protectedMemory = protected_features->protectedMemory;
488 } else if (vulkan_11_features) {
489 protectedMemory = vulkan_11_features->protectedMemory;
490 }
491 if ((queue_create_info.flags == VK_DEVICE_QUEUE_CREATE_PROTECTED_BIT) && (protectedMemory == VK_FALSE)) {
492 skip |= LogError(physicalDevice, "VUID-VkDeviceQueueCreateInfo-flags-02861",
493 "vkCreateDevice: pCreateInfo->flags set to VK_DEVICE_QUEUE_CREATE_PROTECTED_BIT without the "
494 "protectedMemory feature being set as well.");
495 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600496 }
497 }
498
sfricke-samsung30a57412020-05-15 21:14:54 -0700499 // feature dependencies for VK_KHR_variable_pointers
500 const auto *variable_pointers_features = lvl_find_in_chain<VkPhysicalDeviceVariablePointersFeatures>(pCreateInfo->pNext);
501 VkBool32 variablePointers = VK_FALSE;
502 VkBool32 variablePointersStorageBuffer = VK_FALSE;
503 if (vulkan_11_features) {
504 variablePointers = vulkan_11_features->variablePointers;
505 variablePointersStorageBuffer = vulkan_11_features->variablePointersStorageBuffer;
506 } else if (variable_pointers_features) {
507 variablePointers = variable_pointers_features->variablePointers;
508 variablePointersStorageBuffer = variable_pointers_features->variablePointersStorageBuffer;
509 }
510 if ((variablePointers == VK_TRUE) && (variablePointersStorageBuffer == VK_FALSE)) {
511 skip |= LogError(instance, "VUID-VkPhysicalDeviceVariablePointersFeatures-variablePointers-01431",
512 "If variablePointers is VK_TRUE then variablePointersStorageBuffer also needs to be VK_TRUE");
513 }
514
sfricke-samsungfd76c342020-05-29 23:13:43 -0700515 // feature dependencies for VK_KHR_multiview
516 const auto *multiview_features = lvl_find_in_chain<VkPhysicalDeviceMultiviewFeatures>(pCreateInfo->pNext);
517 VkBool32 multiview = VK_FALSE;
518 VkBool32 multiviewGeometryShader = VK_FALSE;
519 VkBool32 multiviewTessellationShader = VK_FALSE;
520 if (vulkan_11_features) {
521 multiview = vulkan_11_features->multiview;
522 multiviewGeometryShader = vulkan_11_features->multiviewGeometryShader;
523 multiviewTessellationShader = vulkan_11_features->multiviewTessellationShader;
524 } else if (multiview_features) {
525 multiview = multiview_features->multiview;
526 multiviewGeometryShader = multiview_features->multiviewGeometryShader;
527 multiviewTessellationShader = multiview_features->multiviewTessellationShader;
528 }
529 if ((multiview == VK_FALSE) && (multiviewGeometryShader == VK_TRUE)) {
530 skip |= LogError(instance, "VUID-VkPhysicalDeviceMultiviewFeatures-multiviewGeometryShader-00580",
531 "If multiviewGeometryShader is VK_TRUE then multiview also needs to be VK_TRUE");
532 }
533 if ((multiview == VK_FALSE) && (multiviewTessellationShader == VK_TRUE)) {
534 skip |= LogError(instance, "VUID-VkPhysicalDeviceMultiviewFeatures-multiviewTessellationShader-00581",
535 "If multiviewTessellationShader is VK_TRUE then multiview also needs to be VK_TRUE");
536 }
537
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600538 return skip;
539}
540
Jeff Bolz46c0ea02019-10-09 13:06:29 -0500541bool StatelessValidation::require_device_extension(bool flag, char const *function_name, char const *extension_name) const {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700542 if (!flag) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700543 return LogError(device, kVUID_PVError_ExtensionNotEnabled,
544 "%s() called even though the %s extension was not enabled for this VkDevice.", function_name,
545 extension_name);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600546 }
547
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700548 return false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600549}
550
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700551bool StatelessValidation::manual_PreCallValidateCreateBuffer(VkDevice device, const VkBufferCreateInfo *pCreateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -0500552 const VkAllocationCallbacks *pAllocator, VkBuffer *pBuffer) const {
Petr Krause91f7a12017-12-14 20:57:36 +0100553 bool skip = false;
554
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600555 if (pCreateInfo != nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700556 skip |=
557 ValidateGreaterThanZero(pCreateInfo->size, "pCreateInfo->size", "VUID-VkBufferCreateInfo-size-00912", "vkCreateBuffer");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600558
559 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
560 if (pCreateInfo->sharingMode == VK_SHARING_MODE_CONCURRENT) {
561 // If sharingMode is VK_SHARING_MODE_CONCURRENT, queueFamilyIndexCount must be greater than 1
562 if (pCreateInfo->queueFamilyIndexCount <= 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700563 skip |= LogError(device, "VUID-VkBufferCreateInfo-sharingMode-00914",
564 "vkCreateBuffer: if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
565 "pCreateInfo->queueFamilyIndexCount must be greater than 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600566 }
567
568 // If sharingMode is VK_SHARING_MODE_CONCURRENT, pQueueFamilyIndices must be a pointer to an array of
569 // queueFamilyIndexCount uint32_t values
570 if (pCreateInfo->pQueueFamilyIndices == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700571 skip |= LogError(device, "VUID-VkBufferCreateInfo-sharingMode-00913",
572 "vkCreateBuffer: if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
573 "pCreateInfo->pQueueFamilyIndices must be a pointer to an array of "
574 "pCreateInfo->queueFamilyIndexCount uint32_t values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600575 }
576 }
577
sfricke-samsung8f8cf052020-07-03 22:44:29 -0700578 if ((pCreateInfo->flags & VK_BUFFER_CREATE_SPARSE_BINDING_BIT) && (!physical_device_features.sparseBinding)) {
579 skip |= LogError(device, "VUID-VkBufferCreateInfo-flags-00915",
580 "vkCreateBuffer(): the sparseBinding device feature is disabled: Buffers cannot be created with the "
581 "VK_BUFFER_CREATE_SPARSE_BINDING_BIT set.");
582 }
583
584 if ((pCreateInfo->flags & VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT) && (!physical_device_features.sparseResidencyBuffer)) {
585 skip |=
586 LogError(device, "VUID-VkBufferCreateInfo-flags-00916",
587 "vkCreateBuffer(): the sparseResidencyBuffer device feature is disabled: Buffers cannot be created with "
588 "the VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT set.");
589 }
590
591 if ((pCreateInfo->flags & VK_BUFFER_CREATE_SPARSE_ALIASED_BIT) && (!physical_device_features.sparseResidencyAliased)) {
592 skip |=
593 LogError(device, "VUID-VkBufferCreateInfo-flags-00917",
594 "vkCreateBuffer(): the sparseResidencyAliased device feature is disabled: Buffers cannot be created with "
595 "the VK_BUFFER_CREATE_SPARSE_ALIASED_BIT set.");
596 }
597
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600598 // If flags contains VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT or VK_BUFFER_CREATE_SPARSE_ALIASED_BIT, it must also contain
599 // VK_BUFFER_CREATE_SPARSE_BINDING_BIT
600 if (((pCreateInfo->flags & (VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT | VK_BUFFER_CREATE_SPARSE_ALIASED_BIT)) != 0) &&
601 ((pCreateInfo->flags & VK_BUFFER_CREATE_SPARSE_BINDING_BIT) != VK_BUFFER_CREATE_SPARSE_BINDING_BIT)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700602 skip |= LogError(device, "VUID-VkBufferCreateInfo-flags-00918",
603 "vkCreateBuffer: if pCreateInfo->flags contains VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT or "
604 "VK_BUFFER_CREATE_SPARSE_ALIASED_BIT, it must also contain VK_BUFFER_CREATE_SPARSE_BINDING_BIT.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600605 }
606 }
607
608 return skip;
609}
610
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700611bool StatelessValidation::manual_PreCallValidateCreateImage(VkDevice device, const VkImageCreateInfo *pCreateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -0500612 const VkAllocationCallbacks *pAllocator, VkImage *pImage) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600613 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600614
615 if (pCreateInfo != nullptr) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600616 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
617 if (pCreateInfo->sharingMode == VK_SHARING_MODE_CONCURRENT) {
618 // If sharingMode is VK_SHARING_MODE_CONCURRENT, queueFamilyIndexCount must be greater than 1
619 if (pCreateInfo->queueFamilyIndexCount <= 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700620 skip |= LogError(device, "VUID-VkImageCreateInfo-sharingMode-00942",
621 "vkCreateImage(): if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
622 "pCreateInfo->queueFamilyIndexCount must be greater than 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600623 }
624
625 // If sharingMode is VK_SHARING_MODE_CONCURRENT, pQueueFamilyIndices must be a pointer to an array of
626 // queueFamilyIndexCount uint32_t values
627 if (pCreateInfo->pQueueFamilyIndices == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700628 skip |= LogError(device, "VUID-VkImageCreateInfo-sharingMode-00941",
629 "vkCreateImage(): if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
630 "pCreateInfo->pQueueFamilyIndices must be a pointer to an array of "
631 "pCreateInfo->queueFamilyIndexCount uint32_t values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600632 }
633 }
634
Dave Houlton413a6782018-05-22 13:01:54 -0600635 skip |= ValidateGreaterThanZero(pCreateInfo->extent.width, "pCreateInfo->extent.width",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700636 "VUID-VkImageCreateInfo-extent-00944", "vkCreateImage");
Dave Houlton413a6782018-05-22 13:01:54 -0600637 skip |= ValidateGreaterThanZero(pCreateInfo->extent.height, "pCreateInfo->extent.height",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700638 "VUID-VkImageCreateInfo-extent-00945", "vkCreateImage");
Dave Houlton413a6782018-05-22 13:01:54 -0600639 skip |= ValidateGreaterThanZero(pCreateInfo->extent.depth, "pCreateInfo->extent.depth",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700640 "VUID-VkImageCreateInfo-extent-00946", "vkCreateImage");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600641
Dave Houlton413a6782018-05-22 13:01:54 -0600642 skip |= ValidateGreaterThanZero(pCreateInfo->mipLevels, "pCreateInfo->mipLevels", "VUID-VkImageCreateInfo-mipLevels-00947",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700643 "vkCreateImage");
Dave Houlton413a6782018-05-22 13:01:54 -0600644 skip |= ValidateGreaterThanZero(pCreateInfo->arrayLayers, "pCreateInfo->arrayLayers",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700645 "VUID-VkImageCreateInfo-arrayLayers-00948", "vkCreateImage");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600646
Dave Houlton130c0212018-01-29 13:39:56 -0700647 // InitialLayout must be PREINITIALIZED or UNDEFINED
Dave Houltone19e20d2018-02-02 16:32:41 -0700648 if ((pCreateInfo->initialLayout != VK_IMAGE_LAYOUT_UNDEFINED) &&
649 (pCreateInfo->initialLayout != VK_IMAGE_LAYOUT_PREINITIALIZED)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700650 skip |= LogError(
651 device, "VUID-VkImageCreateInfo-initialLayout-00993",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600652 "vkCreateImage(): initialLayout is %s, must be VK_IMAGE_LAYOUT_UNDEFINED or VK_IMAGE_LAYOUT_PREINITIALIZED.",
653 string_VkImageLayout(pCreateInfo->initialLayout));
Dave Houlton130c0212018-01-29 13:39:56 -0700654 }
655
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600656 // If imageType is VK_IMAGE_TYPE_1D, both extent.height and extent.depth must be 1
Petr Kraus3ac9e812018-03-13 12:31:08 +0100657 if ((pCreateInfo->imageType == VK_IMAGE_TYPE_1D) &&
658 ((pCreateInfo->extent.height != 1) || (pCreateInfo->extent.depth != 1))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700659 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00956",
660 "vkCreateImage(): if pCreateInfo->imageType is VK_IMAGE_TYPE_1D, both pCreateInfo->extent.height and "
661 "pCreateInfo->extent.depth must be 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600662 }
663
664 if (pCreateInfo->imageType == VK_IMAGE_TYPE_2D) {
Petr Kraus3f433212018-03-13 12:31:27 +0100665 if (pCreateInfo->flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) {
666 if (pCreateInfo->extent.width != pCreateInfo->extent.height) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700667 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00954",
668 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT, but "
669 "pCreateInfo->extent.width (=%" PRIu32 ") and pCreateInfo->extent.height (=%" PRIu32
670 ") are not equal.",
671 pCreateInfo->extent.width, pCreateInfo->extent.height);
Petr Kraus3f433212018-03-13 12:31:27 +0100672 }
673
674 if (pCreateInfo->arrayLayers < 6) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700675 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00954",
676 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT, but "
677 "pCreateInfo->arrayLayers (=%" PRIu32 ") is not greater than or equal to 6.",
678 pCreateInfo->arrayLayers);
Petr Kraus3f433212018-03-13 12:31:27 +0100679 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600680 }
681
682 if (pCreateInfo->extent.depth != 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700683 skip |= LogError(
684 device, "VUID-VkImageCreateInfo-imageType-00957",
685 "vkCreateImage(): if pCreateInfo->imageType is VK_IMAGE_TYPE_2D, pCreateInfo->extent.depth must be 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600686 }
687 }
688
Dave Houlton130c0212018-01-29 13:39:56 -0700689 // 3D image may have only 1 layer
690 if ((pCreateInfo->imageType == VK_IMAGE_TYPE_3D) && (pCreateInfo->arrayLayers != 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700691 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00961",
692 "vkCreateImage(): if pCreateInfo->imageType is VK_IMAGE_TYPE_3D, pCreateInfo->arrayLayers must be 1.");
Dave Houlton130c0212018-01-29 13:39:56 -0700693 }
694
695 // If multi-sample, validate type, usage, tiling and mip levels.
696 if ((pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT) &&
697 ((pCreateInfo->imageType != VK_IMAGE_TYPE_2D) || (pCreateInfo->flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) ||
Shannon McPhersona886c2a2018-10-12 14:38:20 -0600698 (pCreateInfo->mipLevels != 1) || (pCreateInfo->tiling != VK_IMAGE_TILING_OPTIMAL))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700699 skip |= LogError(device, "VUID-VkImageCreateInfo-samples-02257",
700 "vkCreateImage(): Multi-sample image with incompatible type, usage, tiling, or mips.");
Dave Houlton130c0212018-01-29 13:39:56 -0700701 }
702
703 if (0 != (pCreateInfo->usage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT)) {
704 VkImageUsageFlags legal_flags = (VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT | VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT |
705 VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT);
706 // At least one of the legal attachment bits must be set
707 if (0 == (pCreateInfo->usage & legal_flags)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700708 skip |= LogError(device, "VUID-VkImageCreateInfo-usage-00966",
709 "vkCreateImage(): Transient attachment image without a compatible attachment flag set.");
Dave Houlton130c0212018-01-29 13:39:56 -0700710 }
711 // No flags other than the legal attachment bits may be set
712 legal_flags |= VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT;
713 if (0 != (pCreateInfo->usage & ~legal_flags)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700714 skip |= LogError(device, "VUID-VkImageCreateInfo-usage-00963",
715 "vkCreateImage(): Transient attachment image with incompatible usage flags set.");
Dave Houlton130c0212018-01-29 13:39:56 -0700716 }
717 }
718
Jeff Bolzef40fec2018-09-01 22:04:34 -0500719 // mipLevels must be less than or equal to the number of levels in the complete mipmap chain
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600720 uint32_t maxDim = std::max(std::max(pCreateInfo->extent.width, pCreateInfo->extent.height), pCreateInfo->extent.depth);
Jeff Bolzef40fec2018-09-01 22:04:34 -0500721 // Max mip levels is different for corner-sampled images vs normal images.
Dave Houlton142c4cb2018-10-17 15:04:41 -0600722 uint32_t maxMipLevels = (pCreateInfo->flags & VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV) ? (uint32_t)(ceil(log2(maxDim)))
723 : (uint32_t)(floor(log2(maxDim)) + 1);
Jeff Bolzef40fec2018-09-01 22:04:34 -0500724 if (maxDim > 0 && pCreateInfo->mipLevels > maxMipLevels) {
Dave Houlton413a6782018-05-22 13:01:54 -0600725 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700726 LogError(device, "VUID-VkImageCreateInfo-mipLevels-00958",
727 "vkCreateImage(): pCreateInfo->mipLevels must be less than or equal to "
728 "floor(log2(max(pCreateInfo->extent.width, pCreateInfo->extent.height, pCreateInfo->extent.depth)))+1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600729 }
730
Mark Lobodzinski69259c52018-09-18 15:14:58 -0600731 if ((pCreateInfo->flags & VK_IMAGE_CREATE_2D_ARRAY_COMPATIBLE_BIT) && (pCreateInfo->imageType != VK_IMAGE_TYPE_3D)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700732 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-00950",
733 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_2D_ARRAY_COMPATIBLE_BIT but "
734 "pCreateInfo->imageType is not VK_IMAGE_TYPE_3D.");
Mark Lobodzinski69259c52018-09-18 15:14:58 -0600735 }
736
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700737 if ((pCreateInfo->flags & VK_IMAGE_CREATE_SPARSE_BINDING_BIT) && (!physical_device_features.sparseBinding)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700738 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-00969",
739 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_SPARSE_BINDING_BIT, but the "
740 "VkPhysicalDeviceFeatures::sparseBinding feature is disabled.");
Petr Krausb6f97802018-03-13 12:31:39 +0100741 }
742
sfricke-samsung8f8cf052020-07-03 22:44:29 -0700743 if ((pCreateInfo->flags & VK_IMAGE_CREATE_SPARSE_ALIASED_BIT) && (!physical_device_features.sparseResidencyAliased)) {
744 skip |= LogError(
745 device, "VUID-VkImageCreateInfo-flags-01924",
746 "vkCreateImage(): the sparseResidencyAliased device feature is disabled: Images cannot be created with the "
747 "VK_IMAGE_CREATE_SPARSE_ALIASED_BIT set.");
748 }
749
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600750 // If flags contains VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT or VK_IMAGE_CREATE_SPARSE_ALIASED_BIT, it must also contain
751 // VK_IMAGE_CREATE_SPARSE_BINDING_BIT
752 if (((pCreateInfo->flags & (VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT | VK_IMAGE_CREATE_SPARSE_ALIASED_BIT)) != 0) &&
753 ((pCreateInfo->flags & VK_IMAGE_CREATE_SPARSE_BINDING_BIT) != VK_IMAGE_CREATE_SPARSE_BINDING_BIT)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700754 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-00987",
755 "vkCreateImage: if pCreateInfo->flags contains VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT or "
756 "VK_IMAGE_CREATE_SPARSE_ALIASED_BIT, it must also contain VK_IMAGE_CREATE_SPARSE_BINDING_BIT.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600757 }
758
759 // Check for combinations of attributes that are incompatible with having VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT set
760 if ((pCreateInfo->flags & VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT) != 0) {
761 // Linear tiling is unsupported
762 if (VK_IMAGE_TILING_LINEAR == pCreateInfo->tiling) {
sfricke-samsung9801d752020-08-23 22:00:16 -0700763 skip |= LogError(device, "VUID-VkImageCreateInfo-tiling-04121",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700764 "vkCreateImage: if pCreateInfo->flags contains VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT then image "
765 "tiling of VK_IMAGE_TILING_LINEAR is not supported");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600766 }
767
768 // Sparse 1D image isn't valid
769 if (VK_IMAGE_TYPE_1D == pCreateInfo->imageType) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700770 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00970",
771 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 1D image.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600772 }
773
774 // Sparse 2D image when device doesn't support it
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700775 if ((VK_FALSE == physical_device_features.sparseResidencyImage2D) && (VK_IMAGE_TYPE_2D == pCreateInfo->imageType)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700776 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00971",
777 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 2D image if corresponding "
778 "feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600779 }
780
781 // Sparse 3D image when device doesn't support it
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700782 if ((VK_FALSE == physical_device_features.sparseResidencyImage3D) && (VK_IMAGE_TYPE_3D == pCreateInfo->imageType)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700783 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00972",
784 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 3D image if corresponding "
785 "feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600786 }
787
788 // Multi-sample 2D image when device doesn't support it
789 if (VK_IMAGE_TYPE_2D == pCreateInfo->imageType) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700790 if ((VK_FALSE == physical_device_features.sparseResidency2Samples) &&
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600791 (VK_SAMPLE_COUNT_2_BIT == pCreateInfo->samples)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700792 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00973",
793 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 2-sample image if "
794 "corresponding feature is not enabled on the device.");
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700795 } else if ((VK_FALSE == physical_device_features.sparseResidency4Samples) &&
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600796 (VK_SAMPLE_COUNT_4_BIT == pCreateInfo->samples)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700797 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00974",
798 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 4-sample image if "
799 "corresponding feature is not enabled on the device.");
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700800 } else if ((VK_FALSE == physical_device_features.sparseResidency8Samples) &&
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600801 (VK_SAMPLE_COUNT_8_BIT == pCreateInfo->samples)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700802 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00975",
803 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 8-sample image if "
804 "corresponding feature is not enabled on the device.");
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700805 } else if ((VK_FALSE == physical_device_features.sparseResidency16Samples) &&
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600806 (VK_SAMPLE_COUNT_16_BIT == pCreateInfo->samples)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700807 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00976",
808 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 16-sample image if "
809 "corresponding feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600810 }
811 }
812 }
Jeff Bolzef40fec2018-09-01 22:04:34 -0500813
Jeff Bolz9af91c52018-09-01 21:53:57 -0500814 if (pCreateInfo->usage & VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV) {
815 if (pCreateInfo->imageType != VK_IMAGE_TYPE_2D) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700816 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-02082",
817 "vkCreateImage: if usage includes VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV, "
818 "imageType must be VK_IMAGE_TYPE_2D.");
Jeff Bolz9af91c52018-09-01 21:53:57 -0500819 }
820 if (pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700821 skip |= LogError(device, "VUID-VkImageCreateInfo-samples-02083",
822 "vkCreateImage: if usage includes VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV, "
823 "samples must be VK_SAMPLE_COUNT_1_BIT.");
Jeff Bolz9af91c52018-09-01 21:53:57 -0500824 }
825 if (pCreateInfo->tiling != VK_IMAGE_TILING_OPTIMAL) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700826 skip |= LogError(device, "VUID-VkImageCreateInfo-tiling-02084",
827 "vkCreateImage: if usage includes VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV, "
828 "tiling must be VK_IMAGE_TILING_OPTIMAL.");
Jeff Bolz9af91c52018-09-01 21:53:57 -0500829 }
830 }
Jeff Bolzef40fec2018-09-01 22:04:34 -0500831
832 if (pCreateInfo->flags & VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV) {
Dave Houlton142c4cb2018-10-17 15:04:41 -0600833 if (pCreateInfo->imageType != VK_IMAGE_TYPE_2D && pCreateInfo->imageType != VK_IMAGE_TYPE_3D) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700834 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02050",
835 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV, "
836 "imageType must be VK_IMAGE_TYPE_2D or VK_IMAGE_TYPE_3D.");
Jeff Bolzef40fec2018-09-01 22:04:34 -0500837 }
838
Dave Houlton142c4cb2018-10-17 15:04:41 -0600839 if ((pCreateInfo->flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) || FormatIsDepthOrStencil(pCreateInfo->format)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700840 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02051",
841 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV, "
842 "it must not also contain VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT and format must "
843 "not be a depth/stencil format.");
Jeff Bolzef40fec2018-09-01 22:04:34 -0500844 }
845
Dave Houlton142c4cb2018-10-17 15:04:41 -0600846 if (pCreateInfo->imageType == VK_IMAGE_TYPE_2D && (pCreateInfo->extent.width == 1 || pCreateInfo->extent.height == 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700847 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02052",
848 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV and "
849 "imageType is VK_IMAGE_TYPE_2D, extent.width and extent.height must be "
850 "greater than 1.");
Jeff Bolzb8a8dd02018-09-18 02:39:24 -0500851 } else if (pCreateInfo->imageType == VK_IMAGE_TYPE_3D &&
Dave Houlton142c4cb2018-10-17 15:04:41 -0600852 (pCreateInfo->extent.width == 1 || pCreateInfo->extent.height == 1 || pCreateInfo->extent.depth == 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700853 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02053",
854 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV and "
855 "imageType is VK_IMAGE_TYPE_3D, extent.width, extent.height, and extent.depth "
856 "must be greater than 1.");
Jeff Bolzef40fec2018-09-01 22:04:34 -0500857 }
858 }
Andrew Fobel3abeb992020-01-20 16:33:22 -0500859
sfricke-samsung8f658d42020-05-03 20:12:24 -0700860 if (((pCreateInfo->flags & VK_IMAGE_CREATE_SAMPLE_LOCATIONS_COMPATIBLE_DEPTH_BIT_EXT) != 0) &&
861 (FormatHasDepth(pCreateInfo->format) == false)) {
862 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-01533",
863 "vkCreateImage(): if flags contain VK_IMAGE_CREATE_SAMPLE_LOCATIONS_COMPATIBLE_DEPTH_BIT_EXT the "
864 "format must be a depth or depth/stencil format.");
865 }
866
Andrew Fobel3abeb992020-01-20 16:33:22 -0500867 const auto image_stencil_struct = lvl_find_in_chain<VkImageStencilUsageCreateInfoEXT>(pCreateInfo->pNext);
868 if (image_stencil_struct != nullptr) {
869 if ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT) != 0) {
870 VkImageUsageFlags legal_flags = (VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT | VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT);
871 // No flags other than the legal attachment bits may be set
872 legal_flags |= VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT;
873 if ((image_stencil_struct->stencilUsage & ~legal_flags) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700874 skip |= LogError(device, "VUID-VkImageStencilUsageCreateInfo-stencilUsage-02539",
875 "vkCreateImage(): in pNext chain, VkImageStencilUsageCreateInfo::stencilUsage includes "
876 "VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT, it must not include bits other than "
877 "VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT or VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT");
Andrew Fobel3abeb992020-01-20 16:33:22 -0500878 }
879 }
880
881 if (FormatIsDepthOrStencil(pCreateInfo->format)) {
882 if ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT) != 0) {
883 if (pCreateInfo->extent.width > device_limits.maxFramebufferWidth) {
884 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700885 LogError(device, "VUID-VkImageCreateInfo-Format-02536",
886 "vkCreateImage(): Depth-stencil image contains VkImageStencilUsageCreateInfo structure with "
887 "stencilUsage including VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT and image width exceeds device "
888 "maxFramebufferWidth");
Andrew Fobel3abeb992020-01-20 16:33:22 -0500889 }
890
891 if (pCreateInfo->extent.height > device_limits.maxFramebufferHeight) {
892 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700893 LogError(device, "VUID-VkImageCreateInfo-format-02537",
894 "vkCreateImage(): Depth-stencil image contains VkImageStencilUsageCreateInfo structure with "
895 "stencilUsage including VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT and image height exceeds device "
896 "maxFramebufferHeight");
Andrew Fobel3abeb992020-01-20 16:33:22 -0500897 }
898 }
899
900 if (!physical_device_features.shaderStorageImageMultisample &&
901 ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_STORAGE_BIT) != 0) &&
902 (pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT)) {
903 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700904 LogError(device, "VUID-VkImageCreateInfo-format-02538",
905 "vkCreateImage(): Depth-stencil image contains VkImageStencilUsageCreateInfo structure with "
906 "stencilUsage including VK_IMAGE_USAGE_STORAGE_BIT and the multisampled storage images feature is "
907 "not enabled, image samples must be VK_SAMPLE_COUNT_1_BIT");
Andrew Fobel3abeb992020-01-20 16:33:22 -0500908 }
909
910 if (((pCreateInfo->usage & VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT) != 0) &&
911 ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT) == 0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700912 skip |= LogError(
913 device, "VUID-VkImageCreateInfo-format-02795",
Andrew Fobel3abeb992020-01-20 16:33:22 -0500914 "vkCreateImage(): Depth-stencil image in which usage includes VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT "
915 "contains VkImageStencilUsageCreateInfo structure, VkImageStencilUsageCreateInfo::stencilUsage must "
916 "also include VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT");
917 } else if (((pCreateInfo->usage & VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT) == 0) &&
918 ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT) != 0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700919 skip |= LogError(
920 device, "VUID-VkImageCreateInfo-format-02796",
Andrew Fobel3abeb992020-01-20 16:33:22 -0500921 "vkCreateImage(): Depth-stencil image in which usage does not include "
922 "VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT "
923 "contains VkImageStencilUsageCreateInfo structure, VkImageStencilUsageCreateInfo::stencilUsage must "
924 "also not include VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT");
925 }
926
927 if (((pCreateInfo->usage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT) != 0) &&
928 ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT) == 0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700929 skip |= LogError(
930 device, "VUID-VkImageCreateInfo-format-02797",
Andrew Fobel3abeb992020-01-20 16:33:22 -0500931 "vkCreateImage(): Depth-stencil image in which usage includes VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT "
932 "contains VkImageStencilUsageCreateInfo structure, VkImageStencilUsageCreateInfo::stencilUsage must "
933 "also include VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT");
934 } else if (((pCreateInfo->usage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT) == 0) &&
935 ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT) != 0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700936 skip |= LogError(
937 device, "VUID-VkImageCreateInfo-format-02798",
Andrew Fobel3abeb992020-01-20 16:33:22 -0500938 "vkCreateImage(): Depth-stencil image in which usage does not include "
939 "VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT "
940 "contains VkImageStencilUsageCreateInfo structure, VkImageStencilUsageCreateInfo::stencilUsage must "
941 "also not include VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT");
942 }
943 }
944 }
Spencer Frickeca52b5c2020-03-16 17:34:00 -0700945
946 if ((!physical_device_features.shaderStorageImageMultisample) && ((pCreateInfo->usage & VK_IMAGE_USAGE_STORAGE_BIT) != 0) &&
947 (pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT)) {
948 skip |= LogError(device, "VUID-VkImageCreateInfo-usage-00968",
949 "vkCreateImage(): usage contains VK_IMAGE_USAGE_STORAGE_BIT and the multisampled storage images "
950 "feature is not enabled, image samples must be VK_SAMPLE_COUNT_1_BIT");
951 }
Spencer Fricke6f8b8ac2020-04-06 07:36:50 -0700952
953 if (device_extensions.vk_ext_image_drm_format_modifier) {
954 const auto drm_format_mod_list = lvl_find_in_chain<VkImageDrmFormatModifierListCreateInfoEXT>(pCreateInfo->pNext);
955 const auto drm_format_mod_explict =
956 lvl_find_in_chain<VkImageDrmFormatModifierExplicitCreateInfoEXT>(pCreateInfo->pNext);
957 if (pCreateInfo->tiling == VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT) {
958 if (((drm_format_mod_list != nullptr) && (drm_format_mod_explict != nullptr)) ||
959 ((drm_format_mod_list == nullptr) && (drm_format_mod_explict == nullptr))) {
960 skip |= LogError(device, "VUID-VkImageCreateInfo-tiling-02261",
961 "vkCreateImage(): Tiling is VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT but pNext must have "
962 "either VkImageDrmFormatModifierListCreateInfoEXT or "
963 "VkImageDrmFormatModifierExplicitCreateInfoEXT in the pNext chain");
964 }
965 } else if ((drm_format_mod_list != nullptr) || (drm_format_mod_explict != nullptr)) {
966 skip |= LogError(device, "VUID-VkImageCreateInfo-pNext-02262",
967 "vkCreateImage(): Tiling is not VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT but there is a "
968 "VkImageDrmFormatModifierListCreateInfoEXT or VkImageDrmFormatModifierExplicitCreateInfoEXT "
969 "in the pNext chain");
970 }
971 }
janharaldfredriksen-arm3b793772020-05-12 18:55:53 +0200972
973 if (pCreateInfo->usage & VK_IMAGE_USAGE_FRAGMENT_DENSITY_MAP_BIT_EXT) {
974 if (pCreateInfo->imageType != VK_IMAGE_TYPE_2D) {
975 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02557",
976 "vkCreateImage: if usage includes VK_IMAGE_USAGE_FRAGMENT_DENSITY_MAP_BIT_EXT, "
977 "imageType must be VK_IMAGE_TYPE_2D.");
978 }
979 if (pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT) {
980 skip |= LogError(device, "VUID-VkImageCreateInfo-samples-02558",
981 "vkCreateImage: if usage includes VK_IMAGE_USAGE_FRAGMENT_DENSITY_MAP_BIT_EXT, "
982 "samples must be VK_SAMPLE_COUNT_1_BIT.");
983 }
984 if (pCreateInfo->tiling != VK_IMAGE_TILING_OPTIMAL) {
985 skip |= LogError(device, "VUID-VkImageCreateInfo-tiling-02084",
986 "vkCreateImage: if usage includes VK_IMAGE_USAGE_FRAGMENT_DENSITY_MAP_BIT_EXT, "
987 "tiling must be VK_IMAGE_TILING_OPTIMAL.");
988 }
989 }
990 if (pCreateInfo->flags & VK_IMAGE_CREATE_SUBSAMPLED_BIT_EXT) {
991 if (pCreateInfo->tiling != VK_IMAGE_TILING_OPTIMAL) {
992 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02565",
993 "vkCreateImage: if usage includes VK_IMAGE_CREATE_SUBSAMPLED_BIT_EXT, "
994 "tiling must be VK_IMAGE_TILING_OPTIMAL.");
995 }
996 if (pCreateInfo->imageType != VK_IMAGE_TYPE_2D) {
997 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02566",
998 "vkCreateImage: if flags includes VK_IMAGE_CREATE_SUBSAMPLED_BIT_EXT, "
999 "imageType must be VK_IMAGE_TYPE_2D.");
1000 }
1001 if (pCreateInfo->flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) {
1002 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02567",
1003 "vkCreateImage: if flags includes VK_IMAGE_CREATE_SUBSAMPLED_BIT_EXT, "
1004 "flags must not include VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT.");
1005 }
1006 if (pCreateInfo->mipLevels != 1) {
1007 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02568",
1008 "vkCreateImage: if flags includes VK_IMAGE_CREATE_SUBSAMPLED_BIT_EXT, mipLevels (%d) must be 1.",
1009 pCreateInfo->mipLevels);
1010 }
1011 }
sfricke-samsungddaf72b2020-06-23 21:39:28 -07001012
1013 const auto swapchain_create_info = lvl_find_in_chain<VkImageSwapchainCreateInfoKHR>(pCreateInfo->pNext);
1014 if (swapchain_create_info != nullptr) {
1015 if (swapchain_create_info->swapchain != VK_NULL_HANDLE) {
1016 // All the following fall under the same VU that checks that the swapchain image uses parameters limited by the
1017 // table in #swapchain-wsi-image-create-info. Breaking up into multiple checks allows for more useful information
1018 // returned why this error occured. Check for matching Swapchain flags is done later in state tracking validation
1019 const char *vuid = "VUID-VkImageSwapchainCreateInfoKHR-swapchain-00995";
1020 const char *base_message = "vkCreateImage(): The image used for creating a presentable swapchain image";
1021
1022 if (pCreateInfo->imageType != VK_IMAGE_TYPE_2D) {
1023 // also implicitly forces the check above that extent.depth is 1
1024 skip |= LogError(device, vuid, "%s must have a imageType value VK_IMAGE_TYPE_2D instead of %s.", base_message,
1025 string_VkImageType(pCreateInfo->imageType));
1026 }
1027 if (pCreateInfo->mipLevels != 1) {
1028 skip |= LogError(device, vuid, "%s must have a mipLevels value of 1 instead of %u.", base_message,
1029 pCreateInfo->mipLevels);
1030 }
1031 if (pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT) {
1032 skip |= LogError(device, vuid, "%s must have a samples value of VK_SAMPLE_COUNT_1_BIT instead of %s.",
1033 base_message, string_VkSampleCountFlagBits(pCreateInfo->samples));
1034 }
1035 if (pCreateInfo->tiling != VK_IMAGE_TILING_OPTIMAL) {
1036 skip |= LogError(device, vuid, "%s must have a tiling value of VK_IMAGE_TILING_OPTIMAL instead of %s.",
1037 base_message, string_VkImageTiling(pCreateInfo->tiling));
1038 }
1039 if (pCreateInfo->initialLayout != VK_IMAGE_LAYOUT_UNDEFINED) {
1040 skip |= LogError(device, vuid, "%s must have a initialLayout value of VK_IMAGE_LAYOUT_UNDEFINED instead of %s.",
1041 base_message, string_VkImageLayout(pCreateInfo->initialLayout));
1042 }
1043 const VkImageCreateFlags valid_flags =
1044 (VK_IMAGE_CREATE_SPLIT_INSTANCE_BIND_REGIONS_BIT | VK_IMAGE_CREATE_PROTECTED_BIT |
1045 VK_IMAGE_CREATE_MUTABLE_FORMAT_BIT | VK_IMAGE_CREATE_EXTENDED_USAGE_BIT_KHR);
1046 if ((pCreateInfo->flags & ~valid_flags) != 0) {
1047 skip |= LogError(device, vuid, "%s flags are %" PRIu32 "and must only have valid flags set.", base_message,
1048 pCreateInfo->flags);
1049 }
1050 }
1051 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001052 }
Jeff Bolzef40fec2018-09-01 22:04:34 -05001053
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001054 return skip;
1055}
1056
Jeff Bolz99e3f632020-03-24 22:59:22 -05001057bool StatelessValidation::manual_PreCallValidateCreateImageView(VkDevice device, const VkImageViewCreateInfo *pCreateInfo,
1058 const VkAllocationCallbacks *pAllocator, VkImageView *pView) const {
1059 bool skip = false;
1060
1061 if (pCreateInfo != nullptr) {
Spencer Fricke528e0982020-04-19 18:46:01 -07001062 // Validate feature set if using CUBE_ARRAY
1063 if ((pCreateInfo->viewType == VK_IMAGE_VIEW_TYPE_CUBE_ARRAY) && (physical_device_features.imageCubeArray == false)) {
1064 skip |= LogError(pCreateInfo->image, "VUID-VkImageViewCreateInfo-viewType-01004",
1065 "vkCreateImageView(): pCreateInfo->viewType can't be VK_IMAGE_VIEW_TYPE_CUBE_ARRAY without "
1066 "enabling the imageCubeArray feature.");
1067 }
1068
Jeff Bolz99e3f632020-03-24 22:59:22 -05001069 if (pCreateInfo->subresourceRange.layerCount != VK_REMAINING_ARRAY_LAYERS) {
1070 if (pCreateInfo->viewType == VK_IMAGE_VIEW_TYPE_CUBE && pCreateInfo->subresourceRange.layerCount != 6) {
1071 skip |= LogError(device, "VUID-VkImageViewCreateInfo-viewType-02960",
Spencer Fricke528e0982020-04-19 18:46:01 -07001072 "vkCreateImageView(): subresourceRange.layerCount (%d) must be 6 or VK_REMAINING_ARRAY_LAYERS.",
Jeff Bolz99e3f632020-03-24 22:59:22 -05001073 pCreateInfo->subresourceRange.layerCount);
1074 }
1075 if (pCreateInfo->viewType == VK_IMAGE_VIEW_TYPE_CUBE_ARRAY && (pCreateInfo->subresourceRange.layerCount % 6) != 0) {
Spencer Fricke528e0982020-04-19 18:46:01 -07001076 skip |= LogError(
1077 device, "VUID-VkImageViewCreateInfo-viewType-02961",
1078 "vkCreateImageView(): subresourceRange.layerCount (%d) must be a multiple of 6 or VK_REMAINING_ARRAY_LAYERS.",
1079 pCreateInfo->subresourceRange.layerCount);
Jeff Bolz99e3f632020-03-24 22:59:22 -05001080 }
1081 }
sfricke-samsung0c4a06f2020-06-27 01:24:32 -07001082
1083 auto astc_decode_mode = lvl_find_in_chain<VkImageViewASTCDecodeModeEXT>(pCreateInfo->pNext);
1084 if ((device_extensions.vk_ext_astc_decode_mode) && (astc_decode_mode != nullptr)) {
1085 if ((astc_decode_mode->decodeMode != VK_FORMAT_R16G16B16A16_SFLOAT) &&
1086 (astc_decode_mode->decodeMode != VK_FORMAT_R8G8B8A8_UNORM) &&
1087 (astc_decode_mode->decodeMode != VK_FORMAT_E5B9G9R9_UFLOAT_PACK32)) {
1088 skip |= LogError(device, "VUID-VkImageViewASTCDecodeModeEXT-decodeMode-02230",
1089 "vkCreateImageView(): VkImageViewASTCDecodeModeEXT::decodeMode must be "
1090 "VK_FORMAT_R16G16B16A16_SFLOAT, VK_FORMAT_R8G8B8A8_UNORM, or VK_FORMAT_E5B9G9R9_UFLOAT_PACK32.");
1091 }
1092 if (FormatIsCompressed_ASTC(pCreateInfo->format) == false) {
1093 skip |= LogError(device, "VUID-VkImageViewASTCDecodeModeEXT-format-04084",
1094 "vkCreateImageView(): is using a VkImageViewASTCDecodeModeEXT but the image view format is %s and "
1095 "not an ASTC format.",
1096 string_VkFormat(pCreateInfo->format));
1097 }
1098 }
sfricke-samsung83d98122020-07-04 06:21:15 -07001099
1100 auto ycbcr_conversion = lvl_find_in_chain<VkSamplerYcbcrConversionInfo>(pCreateInfo->pNext);
1101 if (ycbcr_conversion != nullptr) {
1102 if (ycbcr_conversion->conversion != VK_NULL_HANDLE) {
1103 if (IsIdentitySwizzle(pCreateInfo->components) == false) {
1104 skip |= LogError(
1105 device, "VUID-VkImageViewCreateInfo-pNext-01970",
1106 "vkCreateImageView(): If there is a VkSamplerYcbcrConversion, the imageView must "
1107 "be created with the identity swizzle. Here are the actual swizzle values:\n"
1108 "r swizzle = %s\n"
1109 "g swizzle = %s\n"
1110 "b swizzle = %s\n"
1111 "a swizzle = %s\n",
1112 string_VkComponentSwizzle(pCreateInfo->components.r), string_VkComponentSwizzle(pCreateInfo->components.g),
1113 string_VkComponentSwizzle(pCreateInfo->components.b), string_VkComponentSwizzle(pCreateInfo->components.a));
1114 }
1115 }
1116 }
Jeff Bolz99e3f632020-03-24 22:59:22 -05001117 }
1118 return skip;
1119}
1120
Jeff Bolz6d3beaa2019-02-09 21:00:05 -06001121bool StatelessValidation::manual_PreCallValidateViewport(const VkViewport &viewport, const char *fn_name,
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001122 const ParameterName &parameter_name, VkCommandBuffer object) const {
Petr Krausb3fcdb42018-01-09 22:09:09 +01001123 bool skip = false;
Petr Krausb3fcdb42018-01-09 22:09:09 +01001124
1125 // Note: for numerical correctness
1126 // - float comparisons should expect NaN (comparison always false).
1127 // - VkPhysicalDeviceLimits::maxViewportDimensions is uint32_t, not float -> careful.
1128
1129 const auto f_lte_u32_exact = [](const float v1_f, const uint32_t v2_u32) {
John Zulaufac0876c2018-02-19 10:09:35 -07001130 if (std::isnan(v1_f)) return false;
Petr Krausb3fcdb42018-01-09 22:09:09 +01001131 if (v1_f <= 0.0f) return true;
1132
1133 float intpart;
1134 const float fract = modff(v1_f, &intpart);
1135
1136 assert(std::numeric_limits<float>::radix == 2);
1137 const float u32_max_plus1 = ldexpf(1.0f, 32); // hopefully exact
1138 if (intpart >= u32_max_plus1) return false;
1139
1140 uint32_t v1_u32 = static_cast<uint32_t>(intpart);
1141 if (v1_u32 < v2_u32)
1142 return true;
1143 else if (v1_u32 == v2_u32 && fract == 0.0f)
1144 return true;
1145 else
1146 return false;
1147 };
1148
1149 const auto f_lte_u32_direct = [](const float v1_f, const uint32_t v2_u32) {
1150 const float v2_f = static_cast<float>(v2_u32); // not accurate for > radix^digits; and undefined rounding mode
1151 return (v1_f <= v2_f);
1152 };
1153
1154 // width
1155 bool width_healthy = true;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001156 const auto max_w = device_limits.maxViewportDimensions[0];
Petr Krausb3fcdb42018-01-09 22:09:09 +01001157
1158 if (!(viewport.width > 0.0f)) {
1159 width_healthy = false;
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001160 skip |= LogError(object, "VUID-VkViewport-width-01770", "%s: %s.width (=%f) is not greater than 0.0.", fn_name,
1161 parameter_name.get_name().c_str(), viewport.width);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001162 } else if (!(f_lte_u32_exact(viewport.width, max_w) || f_lte_u32_direct(viewport.width, max_w))) {
1163 width_healthy = false;
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001164 skip |= LogError(object, "VUID-VkViewport-width-01771",
1165 "%s: %s.width (=%f) exceeds VkPhysicalDeviceLimits::maxViewportDimensions[0] (=%" PRIu32 ").", fn_name,
1166 parameter_name.get_name().c_str(), viewport.width, max_w);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001167 } else if (!f_lte_u32_exact(viewport.width, max_w) && f_lte_u32_direct(viewport.width, max_w)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001168 skip |= LogWarning(object, kVUID_PVError_NONE,
1169 "%s: %s.width (=%f) technically exceeds VkPhysicalDeviceLimits::maxViewportDimensions[0] (=%" PRIu32
1170 "), but it is within the static_cast<float>(maxViewportDimensions[0]) limit.",
1171 fn_name, parameter_name.get_name().c_str(), viewport.width, max_w);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001172 }
1173
1174 // height
1175 bool height_healthy = true;
Mark Lobodzinskia09ab942020-02-20 11:01:59 -07001176 const bool negative_height_enabled = device_extensions.vk_khr_maintenance1 || device_extensions.vk_amd_negative_viewport_height;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001177 const auto max_h = device_limits.maxViewportDimensions[1];
Petr Krausb3fcdb42018-01-09 22:09:09 +01001178
1179 if (!negative_height_enabled && !(viewport.height > 0.0f)) {
1180 height_healthy = false;
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001181 skip |= LogError(object, "VUID-VkViewport-height-01772", "%s: %s.height (=%f) is not greater 0.0.", fn_name,
1182 parameter_name.get_name().c_str(), viewport.height);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001183 } else if (!(f_lte_u32_exact(fabsf(viewport.height), max_h) || f_lte_u32_direct(fabsf(viewport.height), max_h))) {
1184 height_healthy = false;
1185
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001186 skip |= LogError(object, "VUID-VkViewport-height-01773",
1187 "%s: Absolute value of %s.height (=%f) exceeds VkPhysicalDeviceLimits::maxViewportDimensions[1] (=%" PRIu32
1188 ").",
1189 fn_name, parameter_name.get_name().c_str(), viewport.height, max_h);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001190 } else if (!f_lte_u32_exact(fabsf(viewport.height), max_h) && f_lte_u32_direct(fabsf(viewport.height), max_h)) {
1191 height_healthy = false;
1192
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001193 skip |= LogWarning(
1194 object, kVUID_PVError_NONE,
Petr Krausb3fcdb42018-01-09 22:09:09 +01001195 "%s: Absolute value of %s.height (=%f) technically exceeds VkPhysicalDeviceLimits::maxViewportDimensions[1] (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001196 "), but it is within the static_cast<float>(maxViewportDimensions[1]) limit.",
Jeff Bolz6d3beaa2019-02-09 21:00:05 -06001197 fn_name, parameter_name.get_name().c_str(), viewport.height, max_h);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001198 }
1199
1200 // x
1201 bool x_healthy = true;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001202 if (!(viewport.x >= device_limits.viewportBoundsRange[0])) {
Petr Krausb3fcdb42018-01-09 22:09:09 +01001203 x_healthy = false;
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001204 skip |= LogError(object, "VUID-VkViewport-x-01774",
1205 "%s: %s.x (=%f) is less than VkPhysicalDeviceLimits::viewportBoundsRange[0] (=%f).", fn_name,
1206 parameter_name.get_name().c_str(), viewport.x, device_limits.viewportBoundsRange[0]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001207 }
1208
1209 // x + width
1210 if (x_healthy && width_healthy) {
1211 const float right_bound = viewport.x + viewport.width;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001212 if (!(right_bound <= device_limits.viewportBoundsRange[1])) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001213 skip |= LogError(
1214 object, "VUID-VkViewport-x-01232",
1215 "%s: %s.x + %s.width (=%f + %f = %f) is greater than VkPhysicalDeviceLimits::viewportBoundsRange[1] (=%f).",
1216 fn_name, parameter_name.get_name().c_str(), parameter_name.get_name().c_str(), viewport.x, viewport.width,
1217 right_bound, device_limits.viewportBoundsRange[1]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001218 }
1219 }
1220
1221 // y
1222 bool y_healthy = true;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001223 if (!(viewport.y >= device_limits.viewportBoundsRange[0])) {
Petr Krausb3fcdb42018-01-09 22:09:09 +01001224 y_healthy = false;
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001225 skip |= LogError(object, "VUID-VkViewport-y-01775",
1226 "%s: %s.y (=%f) is less than VkPhysicalDeviceLimits::viewportBoundsRange[0] (=%f).", fn_name,
1227 parameter_name.get_name().c_str(), viewport.y, device_limits.viewportBoundsRange[0]);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001228 } else if (negative_height_enabled && !(viewport.y <= device_limits.viewportBoundsRange[1])) {
Petr Krausb3fcdb42018-01-09 22:09:09 +01001229 y_healthy = false;
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001230 skip |= LogError(object, "VUID-VkViewport-y-01776",
1231 "%s: %s.y (=%f) exceeds VkPhysicalDeviceLimits::viewportBoundsRange[1] (=%f).", fn_name,
1232 parameter_name.get_name().c_str(), viewport.y, device_limits.viewportBoundsRange[1]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001233 }
1234
1235 // y + height
1236 if (y_healthy && height_healthy) {
1237 const float boundary = viewport.y + viewport.height;
1238
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001239 if (!(boundary <= device_limits.viewportBoundsRange[1])) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001240 skip |= LogError(object, "VUID-VkViewport-y-01233",
1241 "%s: %s.y + %s.height (=%f + %f = %f) exceeds VkPhysicalDeviceLimits::viewportBoundsRange[1] (=%f).",
1242 fn_name, parameter_name.get_name().c_str(), parameter_name.get_name().c_str(), viewport.y,
1243 viewport.height, boundary, device_limits.viewportBoundsRange[1]);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001244 } else if (negative_height_enabled && !(boundary >= device_limits.viewportBoundsRange[0])) {
Jeff Bolz6d3beaa2019-02-09 21:00:05 -06001245 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001246 LogError(object, "VUID-VkViewport-y-01777",
1247 "%s: %s.y + %s.height (=%f + %f = %f) is less than VkPhysicalDeviceLimits::viewportBoundsRange[0] (=%f).",
1248 fn_name, parameter_name.get_name().c_str(), parameter_name.get_name().c_str(), viewport.y, viewport.height,
1249 boundary, device_limits.viewportBoundsRange[0]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001250 }
1251 }
1252
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001253 if (!device_extensions.vk_ext_depth_range_unrestricted) {
Petr Krausb3fcdb42018-01-09 22:09:09 +01001254 // minDepth
1255 if (!(viewport.minDepth >= 0.0) || !(viewport.minDepth <= 1.0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001256 skip |= LogError(object, "VUID-VkViewport-minDepth-01234",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001257
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001258 "%s: VK_EXT_depth_range_unrestricted extension is not enabled and %s.minDepth (=%f) is not within the "
1259 "[0.0, 1.0] range.",
1260 fn_name, parameter_name.get_name().c_str(), viewport.minDepth);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001261 }
1262
1263 // maxDepth
1264 if (!(viewport.maxDepth >= 0.0) || !(viewport.maxDepth <= 1.0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001265 skip |= LogError(object, "VUID-VkViewport-maxDepth-01235",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001266
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001267 "%s: VK_EXT_depth_range_unrestricted extension is not enabled and %s.maxDepth (=%f) is not within the "
1268 "[0.0, 1.0] range.",
1269 fn_name, parameter_name.get_name().c_str(), viewport.maxDepth);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001270 }
1271 }
1272
1273 return skip;
1274}
1275
Dave Houlton142c4cb2018-10-17 15:04:41 -06001276struct SampleOrderInfo {
Jeff Bolz9af91c52018-09-01 21:53:57 -05001277 VkShadingRatePaletteEntryNV shadingRate;
1278 uint32_t width;
1279 uint32_t height;
1280};
1281
1282// All palette entries with more than one pixel per fragment
Dave Houlton142c4cb2018-10-17 15:04:41 -06001283static SampleOrderInfo sampleOrderInfos[] = {
1284 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_1X2_PIXELS_NV, 1, 2},
1285 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_2X1_PIXELS_NV, 2, 1},
1286 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_2X2_PIXELS_NV, 2, 2},
1287 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_4X2_PIXELS_NV, 4, 2},
1288 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_2X4_PIXELS_NV, 2, 4},
1289 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_4X4_PIXELS_NV, 4, 4},
Jeff Bolz9af91c52018-09-01 21:53:57 -05001290};
1291
Jeff Bolz46c0ea02019-10-09 13:06:29 -05001292bool StatelessValidation::ValidateCoarseSampleOrderCustomNV(const VkCoarseSampleOrderCustomNV *order) const {
Jeff Bolz9af91c52018-09-01 21:53:57 -05001293 bool skip = false;
Jeff Bolz9af91c52018-09-01 21:53:57 -05001294
Jeff Bolz45bf7d62018-09-18 15:39:58 -05001295 SampleOrderInfo *sampleOrderInfo;
Jeff Bolz9af91c52018-09-01 21:53:57 -05001296 uint32_t infoIdx = 0;
Jeff Bolz45bf7d62018-09-18 15:39:58 -05001297 for (sampleOrderInfo = nullptr; infoIdx < ARRAY_SIZE(sampleOrderInfos); ++infoIdx) {
Jeff Bolz9af91c52018-09-01 21:53:57 -05001298 if (sampleOrderInfos[infoIdx].shadingRate == order->shadingRate) {
Jeff Bolzb8a8dd02018-09-18 02:39:24 -05001299 sampleOrderInfo = &sampleOrderInfos[infoIdx];
Jeff Bolz9af91c52018-09-01 21:53:57 -05001300 break;
1301 }
1302 }
1303
Jeff Bolzb8a8dd02018-09-18 02:39:24 -05001304 if (sampleOrderInfo == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001305 skip |= LogError(device, "VUID-VkCoarseSampleOrderCustomNV-shadingRate-02073",
1306 "VkCoarseSampleOrderCustomNV shadingRate must be a shading rate "
1307 "that generates fragments with more than one pixel.");
Jeff Bolz9af91c52018-09-01 21:53:57 -05001308 return skip;
1309 }
1310
Dave Houlton142c4cb2018-10-17 15:04:41 -06001311 if (order->sampleCount == 0 || (order->sampleCount & (order->sampleCount - 1)) ||
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001312 !(order->sampleCount & device_limits.framebufferNoAttachmentsSampleCounts)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001313 skip |= LogError(device, "VUID-VkCoarseSampleOrderCustomNV-sampleCount-02074",
1314 "VkCoarseSampleOrderCustomNV sampleCount (=%" PRIu32
1315 ") must "
1316 "correspond to a sample count enumerated in VkSampleCountFlags whose corresponding bit "
1317 "is set in framebufferNoAttachmentsSampleCounts.",
1318 order->sampleCount);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001319 }
1320
Jeff Bolz9af91c52018-09-01 21:53:57 -05001321 if (order->sampleLocationCount != order->sampleCount * sampleOrderInfo->width * sampleOrderInfo->height) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001322 skip |= LogError(device, "VUID-VkCoarseSampleOrderCustomNV-sampleLocationCount-02075",
1323 "VkCoarseSampleOrderCustomNV sampleLocationCount (=%" PRIu32
1324 ") must "
1325 "be equal to the product of sampleCount (=%" PRIu32
1326 "), the fragment width for shadingRate "
1327 "(=%" PRIu32 "), and the fragment height for shadingRate (=%" PRIu32 ").",
1328 order->sampleLocationCount, order->sampleCount, sampleOrderInfo->width, sampleOrderInfo->height);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001329 }
1330
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001331 if (order->sampleLocationCount > phys_dev_ext_props.shading_rate_image_props.shadingRateMaxCoarseSamples) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001332 skip |= LogError(
1333 device, "VUID-VkCoarseSampleOrderCustomNV-sampleLocationCount-02076",
Dave Houlton142c4cb2018-10-17 15:04:41 -06001334 "VkCoarseSampleOrderCustomNV sampleLocationCount (=%" PRIu32
1335 ") must "
1336 "be less than or equal to VkPhysicalDeviceShadingRateImagePropertiesNV shadingRateMaxCoarseSamples (=%" PRIu32 ").",
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001337 order->sampleLocationCount, phys_dev_ext_props.shading_rate_image_props.shadingRateMaxCoarseSamples);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001338 }
Jeff Bolz9af91c52018-09-01 21:53:57 -05001339
1340 // Accumulate a bitmask tracking which (x,y,sample) tuples are seen. Expect
Jeff Bolzb8a8dd02018-09-18 02:39:24 -05001341 // the first width*height*sampleCount bits to all be set. Note: There is no
1342 // guarantee that 64 bits is enough, but practically it's unlikely for an
1343 // implementation to support more than 32 bits for samplemask.
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001344 assert(phys_dev_ext_props.shading_rate_image_props.shadingRateMaxCoarseSamples <= 64);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001345 uint64_t sampleLocationsMask = 0;
1346 for (uint32_t i = 0; i < order->sampleLocationCount; ++i) {
1347 const VkCoarseSampleLocationNV *sampleLoc = &order->pSampleLocations[i];
1348 if (sampleLoc->pixelX >= sampleOrderInfo->width) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001349 skip |= LogError(device, "VUID-VkCoarseSampleLocationNV-pixelX-02078",
1350 "pixelX must be less than the width (in pixels) of the fragment.");
Jeff Bolz9af91c52018-09-01 21:53:57 -05001351 }
1352 if (sampleLoc->pixelY >= sampleOrderInfo->height) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001353 skip |= LogError(device, "VUID-VkCoarseSampleLocationNV-pixelY-02079",
1354 "pixelY must be less than the height (in pixels) of the fragment.");
Jeff Bolz9af91c52018-09-01 21:53:57 -05001355 }
1356 if (sampleLoc->sample >= order->sampleCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001357 skip |= LogError(device, "VUID-VkCoarseSampleLocationNV-sample-02080",
1358 "sample must be less than the number of coverage samples in each pixel belonging to the fragment.");
Jeff Bolz9af91c52018-09-01 21:53:57 -05001359 }
1360 uint32_t idx = sampleLoc->sample + order->sampleCount * (sampleLoc->pixelX + sampleOrderInfo->width * sampleLoc->pixelY);
1361 sampleLocationsMask |= 1ULL << idx;
1362 }
1363
1364 uint64_t expectedMask = (order->sampleLocationCount == 64) ? ~0ULL : ((1ULL << order->sampleLocationCount) - 1);
1365 if (sampleLocationsMask != expectedMask) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001366 skip |= LogError(
1367 device, "VUID-VkCoarseSampleOrderCustomNV-pSampleLocations-02077",
Dave Houlton142c4cb2018-10-17 15:04:41 -06001368 "The array pSampleLocations must contain exactly one entry for "
1369 "every combination of valid values for pixelX, pixelY, and sample in the structure VkCoarseSampleOrderCustomNV.");
Jeff Bolz9af91c52018-09-01 21:53:57 -05001370 }
1371
1372 return skip;
1373}
1374
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07001375bool StatelessValidation::manual_PreCallValidateCreateGraphicsPipelines(VkDevice device, VkPipelineCache pipelineCache,
1376 uint32_t createInfoCount,
1377 const VkGraphicsPipelineCreateInfo *pCreateInfos,
1378 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05001379 VkPipeline *pPipelines) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001380 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001381
1382 if (pCreateInfos != nullptr) {
1383 for (uint32_t i = 0; i < createInfoCount; ++i) {
Petr Kraus299ba622017-11-24 03:09:03 +01001384 bool has_dynamic_viewport = false;
1385 bool has_dynamic_scissor = false;
1386 bool has_dynamic_line_width = false;
Spencer Fricke8d428882020-03-16 17:23:33 -07001387 bool has_dynamic_depth_bias = false;
1388 bool has_dynamic_blend_constant = false;
1389 bool has_dynamic_depth_bounds = false;
1390 bool has_dynamic_stencil_compare = false;
1391 bool has_dynamic_stencil_write = false;
1392 bool has_dynamic_stencil_reference = false;
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001393 bool has_dynamic_viewport_w_scaling_nv = false;
1394 bool has_dynamic_discard_rectangle_ext = false;
1395 bool has_dynamic_sample_locations_ext = false;
Jeff Bolz3e71f782018-08-29 23:15:45 -05001396 bool has_dynamic_exclusive_scissor_nv = false;
Jeff Bolz9af91c52018-09-01 21:53:57 -05001397 bool has_dynamic_shading_rate_palette_nv = false;
Spencer Fricke8d428882020-03-16 17:23:33 -07001398 bool has_dynamic_viewport_course_sample_order_nv = false;
Jeff Bolz8125a8b2019-08-16 16:29:45 -05001399 bool has_dynamic_line_stipple = false;
Piers Daniell39842ee2020-07-10 16:42:33 -06001400 bool has_dynamic_cull_mode = false;
1401 bool has_dynamic_front_face = false;
1402 bool has_dynamic_primitive_topology = false;
1403 bool has_dynamic_viewport_with_count = false;
1404 bool has_dynamic_scissor_with_count = false;
1405 bool has_dynamic_vertex_input_binding_stride = false;
1406 bool has_dynamic_depth_test_enable = false;
1407 bool has_dynamic_depth_write_enable = false;
1408 bool has_dynamic_depth_compare_op = false;
1409 bool has_dynamic_depth_bounds_test_enable = false;
1410 bool has_dynamic_stencil_test_enable = false;
1411 bool has_dynamic_stencil_op = false;
Petr Kraus299ba622017-11-24 03:09:03 +01001412 if (pCreateInfos[i].pDynamicState != nullptr) {
1413 const auto &dynamic_state_info = *pCreateInfos[i].pDynamicState;
1414 for (uint32_t state_index = 0; state_index < dynamic_state_info.dynamicStateCount; ++state_index) {
1415 const auto &dynamic_state = dynamic_state_info.pDynamicStates[state_index];
Spencer Fricke8d428882020-03-16 17:23:33 -07001416 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT) {
1417 if (has_dynamic_viewport == true) {
1418 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1419 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_VIEWPORT was listed twice in the "
1420 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1421 i);
1422 }
1423 has_dynamic_viewport = true;
1424 }
1425 if (dynamic_state == VK_DYNAMIC_STATE_SCISSOR) {
1426 if (has_dynamic_scissor == true) {
1427 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1428 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_SCISSOR was listed twice in the "
1429 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1430 i);
1431 }
1432 has_dynamic_scissor = true;
1433 }
1434 if (dynamic_state == VK_DYNAMIC_STATE_LINE_WIDTH) {
1435 if (has_dynamic_line_width == true) {
1436 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1437 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_LINE_WIDTH was listed twice in the "
1438 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1439 i);
1440 }
1441 has_dynamic_line_width = true;
1442 }
1443 if (dynamic_state == VK_DYNAMIC_STATE_DEPTH_BIAS) {
1444 if (has_dynamic_depth_bias == true) {
1445 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1446 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DEPTH_BIAS was listed twice in the "
1447 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1448 i);
1449 }
1450 has_dynamic_depth_bias = true;
1451 }
1452 if (dynamic_state == VK_DYNAMIC_STATE_BLEND_CONSTANTS) {
1453 if (has_dynamic_blend_constant == true) {
1454 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1455 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_BLEND_CONSTANTS was listed twice in the "
1456 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1457 i);
1458 }
1459 has_dynamic_blend_constant = true;
1460 }
1461 if (dynamic_state == VK_DYNAMIC_STATE_DEPTH_BOUNDS) {
1462 if (has_dynamic_depth_bounds == true) {
1463 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1464 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DEPTH_BOUNDS was listed twice in the "
1465 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1466 i);
1467 }
1468 has_dynamic_depth_bounds = true;
1469 }
1470 if (dynamic_state == VK_DYNAMIC_STATE_STENCIL_COMPARE_MASK) {
1471 if (has_dynamic_stencil_compare == true) {
1472 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1473 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_STENCIL_COMPARE_MASK was listed twice in "
1474 "the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1475 i);
1476 }
1477 has_dynamic_stencil_compare = true;
1478 }
1479 if (dynamic_state == VK_DYNAMIC_STATE_STENCIL_WRITE_MASK) {
1480 if (has_dynamic_stencil_write == true) {
1481 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1482 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_STENCIL_WRITE_MASK was listed twice in "
1483 "the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1484 i);
1485 }
1486 has_dynamic_stencil_write = true;
1487 }
1488 if (dynamic_state == VK_DYNAMIC_STATE_STENCIL_REFERENCE) {
1489 if (has_dynamic_stencil_reference == true) {
1490 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1491 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_STENCIL_REFERENCE was listed twice in "
1492 "the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1493 i);
1494 }
1495 has_dynamic_stencil_reference = true;
1496 }
1497 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT_W_SCALING_NV) {
1498 if (has_dynamic_viewport_w_scaling_nv == true) {
1499 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1500 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_VIEWPORT_W_SCALING_NV was listed twice "
1501 "in the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1502 i);
1503 }
1504 has_dynamic_viewport_w_scaling_nv = true;
1505 }
1506 if (dynamic_state == VK_DYNAMIC_STATE_DISCARD_RECTANGLE_EXT) {
1507 if (has_dynamic_discard_rectangle_ext == true) {
1508 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1509 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DISCARD_RECTANGLE_EXT was listed twice "
1510 "in the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1511 i);
1512 }
1513 has_dynamic_discard_rectangle_ext = true;
1514 }
1515 if (dynamic_state == VK_DYNAMIC_STATE_SAMPLE_LOCATIONS_EXT) {
1516 if (has_dynamic_sample_locations_ext == true) {
1517 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1518 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_SAMPLE_LOCATIONS_EXT was listed twice in "
1519 "the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1520 i);
1521 }
1522 has_dynamic_sample_locations_ext = true;
1523 }
1524 if (dynamic_state == VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV) {
1525 if (has_dynamic_exclusive_scissor_nv == true) {
1526 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1527 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV was listed twice in "
1528 "the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1529 i);
1530 }
1531 has_dynamic_exclusive_scissor_nv = true;
1532 }
1533 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT_SHADING_RATE_PALETTE_NV) {
1534 if (has_dynamic_shading_rate_palette_nv == true) {
1535 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1536 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_VIEWPORT_SHADING_RATE_PALETTE_NV was "
1537 "listed twice in the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1538 i);
1539 }
Dave Houlton142c4cb2018-10-17 15:04:41 -06001540 has_dynamic_shading_rate_palette_nv = true;
Spencer Fricke8d428882020-03-16 17:23:33 -07001541 }
1542 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT_COARSE_SAMPLE_ORDER_NV) {
1543 if (has_dynamic_viewport_course_sample_order_nv == true) {
1544 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1545 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_VIEWPORT_COARSE_SAMPLE_ORDER_NV was "
1546 "listed twice in the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1547 i);
1548 }
1549 has_dynamic_viewport_course_sample_order_nv = true;
1550 }
1551 if (dynamic_state == VK_DYNAMIC_STATE_LINE_STIPPLE_EXT) {
1552 if (has_dynamic_line_stipple == true) {
1553 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1554 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_LINE_STIPPLE_EXT was listed twice in the "
1555 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1556 i);
1557 }
1558 has_dynamic_line_stipple = true;
1559 }
Piers Daniell39842ee2020-07-10 16:42:33 -06001560 if (dynamic_state == VK_DYNAMIC_STATE_CULL_MODE_EXT) {
1561 if (has_dynamic_cull_mode) {
1562 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1563 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_CULL_MODE_EXT was listed twice in the "
1564 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1565 i);
1566 }
1567 has_dynamic_cull_mode = true;
1568 }
1569 if (dynamic_state == VK_DYNAMIC_STATE_FRONT_FACE_EXT) {
1570 if (has_dynamic_front_face) {
1571 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1572 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_FRONT_FACE_EXT was listed twice in the "
1573 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1574 i);
1575 }
1576 has_dynamic_front_face = true;
1577 }
1578 if (dynamic_state == VK_DYNAMIC_STATE_PRIMITIVE_TOPOLOGY_EXT) {
1579 if (has_dynamic_primitive_topology) {
1580 skip |= LogError(
1581 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1582 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_PRIMITIVE_TOPOLOGY_EXT was listed twice in the "
1583 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1584 i);
1585 }
1586 has_dynamic_primitive_topology = true;
1587 }
1588 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT_WITH_COUNT_EXT) {
1589 if (has_dynamic_viewport_with_count) {
1590 skip |= LogError(
1591 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1592 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_VIEWPORT_WITH_COUNT_EXT was listed twice in the "
1593 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1594 i);
1595 }
1596 has_dynamic_viewport_with_count = true;
1597 }
1598 if (dynamic_state == VK_DYNAMIC_STATE_SCISSOR_WITH_COUNT_EXT) {
1599 if (has_dynamic_scissor_with_count) {
1600 skip |= LogError(
1601 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1602 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_SCISSOR_WITH_COUNT_EXT was listed twice in the "
1603 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1604 i);
1605 }
1606 has_dynamic_scissor_with_count = true;
1607 }
1608 if (dynamic_state == VK_DYNAMIC_STATE_VERTEX_INPUT_BINDING_STRIDE_EXT) {
1609 if (has_dynamic_vertex_input_binding_stride) {
1610 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1611 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_VERTEX_INPUT_BINDING_STRIDE_EXT was "
1612 "listed twice in the "
1613 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1614 i);
1615 }
1616 has_dynamic_vertex_input_binding_stride = true;
1617 }
1618 if (dynamic_state == VK_DYNAMIC_STATE_DEPTH_TEST_ENABLE_EXT) {
1619 if (has_dynamic_depth_test_enable) {
1620 skip |= LogError(
1621 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1622 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DEPTH_TEST_ENABLE_EXT was listed twice in the "
1623 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1624 i);
1625 }
1626 has_dynamic_depth_test_enable = true;
1627 }
1628 if (dynamic_state == VK_DYNAMIC_STATE_DEPTH_WRITE_ENABLE_EXT) {
1629 if (has_dynamic_depth_write_enable) {
1630 skip |= LogError(
1631 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1632 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DEPTH_WRITE_ENABLE_EXT was listed twice in the "
1633 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1634 i);
1635 }
1636 has_dynamic_depth_write_enable = true;
1637 }
1638 if (dynamic_state == VK_DYNAMIC_STATE_DEPTH_COMPARE_OP_EXT) {
1639 if (has_dynamic_depth_compare_op) {
1640 skip |=
1641 LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1642 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DEPTH_COMPARE_OP_EXT was listed twice in the "
1643 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1644 i);
1645 }
1646 has_dynamic_depth_compare_op = true;
1647 }
1648 if (dynamic_state == VK_DYNAMIC_STATE_DEPTH_BOUNDS_TEST_ENABLE_EXT) {
1649 if (has_dynamic_depth_bounds_test_enable) {
1650 skip |= LogError(
1651 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1652 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DEPTH_BOUNDS_TEST_ENABLE_EXT was listed twice in the "
1653 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1654 i);
1655 }
1656 has_dynamic_depth_bounds_test_enable = true;
1657 }
1658 if (dynamic_state == VK_DYNAMIC_STATE_STENCIL_TEST_ENABLE_EXT) {
1659 if (has_dynamic_stencil_test_enable) {
1660 skip |= LogError(
1661 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1662 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_STENCIL_TEST_ENABLE_EXT was listed twice in the "
1663 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1664 i);
1665 }
1666 has_dynamic_stencil_test_enable = true;
1667 }
1668 if (dynamic_state == VK_DYNAMIC_STATE_STENCIL_OP_EXT) {
1669 if (has_dynamic_stencil_op) {
1670 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1671 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_STENCIL_OP_EXT was listed twice in the "
1672 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1673 i);
1674 }
1675 has_dynamic_stencil_op = true;
1676 }
Petr Kraus299ba622017-11-24 03:09:03 +01001677 }
1678 }
1679
Peter Chen85366392019-05-14 15:20:11 -04001680 auto feedback_struct = lvl_find_in_chain<VkPipelineCreationFeedbackCreateInfoEXT>(pCreateInfos[i].pNext);
1681 if ((feedback_struct != nullptr) &&
1682 (feedback_struct->pipelineStageCreationFeedbackCount != pCreateInfos[i].stageCount)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001683 skip |= LogError(device, "VUID-VkPipelineCreationFeedbackCreateInfoEXT-pipelineStageCreationFeedbackCount-02668",
1684 "vkCreateGraphicsPipelines(): in pCreateInfo[%" PRIu32
1685 "], VkPipelineCreationFeedbackEXT::pipelineStageCreationFeedbackCount"
1686 "(=%" PRIu32 ") must equal VkGraphicsPipelineCreateInfo::stageCount(=%" PRIu32 ").",
1687 i, feedback_struct->pipelineStageCreationFeedbackCount, pCreateInfos[i].stageCount);
Peter Chen85366392019-05-14 15:20:11 -04001688 }
1689
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001690 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001691
Spencer Frickef1b0a7d2020-03-16 17:38:55 -07001692 // Collect active stages and other information
1693 // Only want to loop through pStages once
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001694 uint32_t active_shaders = 0;
Spencer Frickef1b0a7d2020-03-16 17:38:55 -07001695 bool has_eval = false;
1696 bool has_control = false;
1697 if (pCreateInfos[i].pStages != nullptr) {
1698 for (uint32_t stage_index = 0; stage_index < pCreateInfos[i].stageCount; ++stage_index) {
1699 active_shaders |= pCreateInfos[i].pStages[stage_index].stage;
1700
1701 if (pCreateInfos[i].pStages[stage_index].stage == VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) {
1702 has_control = true;
1703 } else if (pCreateInfos[i].pStages[stage_index].stage == VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT) {
1704 has_eval = true;
1705 }
1706
1707 skip |= validate_string(
1708 "vkCreateGraphicsPipelines",
1709 ParameterName("pCreateInfos[%i].pStages[%i].pName", ParameterName::IndexVector{i, stage_index}),
1710 "VUID-VkGraphicsPipelineCreateInfo-pStages-parameter", pCreateInfos[i].pStages[stage_index].pName);
1711 }
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001712 }
1713
1714 if ((active_shaders & VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) &&
1715 (active_shaders & VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT) && (pCreateInfos[i].pTessellationState != nullptr)) {
1716 skip |= validate_struct_type("vkCreateGraphicsPipelines", "pCreateInfos[i].pTessellationState",
1717 "VK_STRUCTURE_TYPE_PIPELINE_TESSELLATION_STATE_CREATE_INFO",
1718 pCreateInfos[i].pTessellationState,
1719 VK_STRUCTURE_TYPE_PIPELINE_TESSELLATION_STATE_CREATE_INFO, false, kVUIDUndefined,
1720 "VUID-VkPipelineTessellationStateCreateInfo-sType-sType");
1721
1722 const VkStructureType allowed_structs_VkPipelineTessellationStateCreateInfo[] = {
1723 VK_STRUCTURE_TYPE_PIPELINE_TESSELLATION_DOMAIN_ORIGIN_STATE_CREATE_INFO};
1724
1725 skip |= validate_struct_pnext("vkCreateGraphicsPipelines", "pCreateInfos[i].pTessellationState->pNext",
1726 "VkPipelineTessellationDomainOriginStateCreateInfo",
1727 pCreateInfos[i].pTessellationState->pNext,
1728 ARRAY_SIZE(allowed_structs_VkPipelineTessellationStateCreateInfo),
1729 allowed_structs_VkPipelineTessellationStateCreateInfo, GeneratedVulkanHeaderVersion,
sfricke-samsung32a27362020-02-28 09:06:42 -08001730 "VUID-VkPipelineTessellationStateCreateInfo-pNext-pNext",
1731 "VUID-VkPipelineTessellationStateCreateInfo-sType-unique");
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001732
1733 skip |= validate_reserved_flags("vkCreateGraphicsPipelines", "pCreateInfos[i].pTessellationState->flags",
1734 pCreateInfos[i].pTessellationState->flags,
1735 "VUID-VkPipelineTessellationStateCreateInfo-flags-zerobitmask");
1736 }
1737
1738 if (!(active_shaders & VK_SHADER_STAGE_MESH_BIT_NV) && (pCreateInfos[i].pInputAssemblyState != nullptr)) {
1739 skip |= validate_struct_type("vkCreateGraphicsPipelines", "pCreateInfos[i].pInputAssemblyState",
1740 "VK_STRUCTURE_TYPE_PIPELINE_INPUT_ASSEMBLY_STATE_CREATE_INFO",
1741 pCreateInfos[i].pInputAssemblyState,
1742 VK_STRUCTURE_TYPE_PIPELINE_INPUT_ASSEMBLY_STATE_CREATE_INFO, false, kVUIDUndefined,
1743 "VUID-VkPipelineInputAssemblyStateCreateInfo-sType-sType");
1744
1745 skip |= validate_struct_pnext("vkCreateGraphicsPipelines", "pCreateInfos[i].pInputAssemblyState->pNext", NULL,
1746 pCreateInfos[i].pInputAssemblyState->pNext, 0, NULL, GeneratedVulkanHeaderVersion,
sfricke-samsung32a27362020-02-28 09:06:42 -08001747 "VUID-VkPipelineInputAssemblyStateCreateInfo-pNext-pNext", nullptr);
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001748
1749 skip |= validate_reserved_flags("vkCreateGraphicsPipelines", "pCreateInfos[i].pInputAssemblyState->flags",
1750 pCreateInfos[i].pInputAssemblyState->flags,
1751 "VUID-VkPipelineInputAssemblyStateCreateInfo-flags-zerobitmask");
1752
1753 skip |= validate_ranged_enum("vkCreateGraphicsPipelines", "pCreateInfos[i].pInputAssemblyState->topology",
1754 "VkPrimitiveTopology", AllVkPrimitiveTopologyEnums,
1755 pCreateInfos[i].pInputAssemblyState->topology,
1756 "VUID-VkPipelineInputAssemblyStateCreateInfo-topology-parameter");
1757
1758 skip |= validate_bool32("vkCreateGraphicsPipelines", "pCreateInfos[i].pInputAssemblyState->primitiveRestartEnable",
1759 pCreateInfos[i].pInputAssemblyState->primitiveRestartEnable);
1760 }
1761
1762 if (!(active_shaders & VK_SHADER_STAGE_MESH_BIT_NV) && (pCreateInfos[i].pVertexInputState != nullptr)) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001763 auto const &vertex_input_state = pCreateInfos[i].pVertexInputState;
Peter Kohautc7d9d392018-07-15 00:34:07 +02001764
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001765 if (pCreateInfos[i].pVertexInputState->flags != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001766 skip |= LogError(device, "VUID-VkPipelineVertexInputStateCreateInfo-flags-zerobitmask",
1767 "vkCreateGraphicsPipelines: pararameter "
1768 "pCreateInfos[%d].pVertexInputState->flags (%u) is reserved and must be zero.",
1769 i, vertex_input_state->flags);
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001770 }
1771
1772 const VkStructureType allowed_structs_VkPipelineVertexInputStateCreateInfo[] = {
1773 VK_STRUCTURE_TYPE_PIPELINE_VERTEX_INPUT_DIVISOR_STATE_CREATE_INFO_EXT};
1774 skip |= validate_struct_pnext("vkCreateGraphicsPipelines", "pCreateInfos[i].pVertexInputState->pNext",
1775 "VkPipelineVertexInputDivisorStateCreateInfoEXT",
1776 pCreateInfos[i].pVertexInputState->pNext, 1,
1777 allowed_structs_VkPipelineVertexInputStateCreateInfo, GeneratedVulkanHeaderVersion,
sfricke-samsung32a27362020-02-28 09:06:42 -08001778 "VUID-VkPipelineVertexInputStateCreateInfo-pNext-pNext",
1779 "VUID-VkPipelineVertexInputStateCreateInfo-sType-unique");
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001780 skip |= validate_struct_type("vkCreateGraphicsPipelines", "pCreateInfos[i].pVertexInputState",
1781 "VK_STRUCTURE_TYPE_PIPELINE_VERTEX_INPUT_STATE_CREATE_INFO", vertex_input_state,
Shannon McPherson3cc90bc2019-08-13 11:28:22 -06001782 VK_STRUCTURE_TYPE_PIPELINE_VERTEX_INPUT_STATE_CREATE_INFO, false, kVUIDUndefined,
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001783 "VUID-VkPipelineVertexInputStateCreateInfo-sType-sType");
1784 skip |=
1785 validate_array("vkCreateGraphicsPipelines", "pCreateInfos[i].pVertexInputState->vertexBindingDescriptionCount",
1786 "pCreateInfos[i].pVertexInputState->pVertexBindingDescriptions",
1787 pCreateInfos[i].pVertexInputState->vertexBindingDescriptionCount,
1788 &pCreateInfos[i].pVertexInputState->pVertexBindingDescriptions, false, true, kVUIDUndefined,
1789 "VUID-VkPipelineVertexInputStateCreateInfo-pVertexBindingDescriptions-parameter");
1790
1791 skip |= validate_array(
1792 "vkCreateGraphicsPipelines", "pCreateInfos[i].pVertexInputState->vertexAttributeDescriptionCount",
1793 "pCreateInfos[i]->pVertexAttributeDescriptions", vertex_input_state->vertexAttributeDescriptionCount,
1794 &vertex_input_state->pVertexAttributeDescriptions, false, true, kVUIDUndefined,
1795 "VUID-VkPipelineVertexInputStateCreateInfo-pVertexAttributeDescriptions-parameter");
1796
1797 if (pCreateInfos[i].pVertexInputState->pVertexBindingDescriptions != NULL) {
1798 for (uint32_t vertexBindingDescriptionIndex = 0;
1799 vertexBindingDescriptionIndex < pCreateInfos[i].pVertexInputState->vertexBindingDescriptionCount;
1800 ++vertexBindingDescriptionIndex) {
1801 skip |= validate_ranged_enum(
1802 "vkCreateGraphicsPipelines",
1803 "pCreateInfos[i].pVertexInputState->pVertexBindingDescriptions[j].inputRate", "VkVertexInputRate",
1804 AllVkVertexInputRateEnums,
1805 pCreateInfos[i].pVertexInputState->pVertexBindingDescriptions[vertexBindingDescriptionIndex].inputRate,
1806 "VUID-VkVertexInputBindingDescription-inputRate-parameter");
1807 }
1808 }
1809
1810 if (pCreateInfos[i].pVertexInputState->pVertexAttributeDescriptions != NULL) {
1811 for (uint32_t vertexAttributeDescriptionIndex = 0;
1812 vertexAttributeDescriptionIndex < pCreateInfos[i].pVertexInputState->vertexAttributeDescriptionCount;
1813 ++vertexAttributeDescriptionIndex) {
1814 skip |= validate_ranged_enum(
1815 "vkCreateGraphicsPipelines",
1816 "pCreateInfos[i].pVertexInputState->pVertexAttributeDescriptions[i].format", "VkFormat",
1817 AllVkFormatEnums,
1818 pCreateInfos[i].pVertexInputState->pVertexAttributeDescriptions[vertexAttributeDescriptionIndex].format,
1819 "VUID-VkVertexInputAttributeDescription-format-parameter");
1820 }
1821 }
1822
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001823 if (vertex_input_state->vertexBindingDescriptionCount > device_limits.maxVertexInputBindings) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001824 skip |= LogError(device, "VUID-VkPipelineVertexInputStateCreateInfo-vertexBindingDescriptionCount-00613",
1825 "vkCreateGraphicsPipelines: pararameter "
1826 "pCreateInfo[%d].pVertexInputState->vertexBindingDescriptionCount (%u) is "
1827 "greater than VkPhysicalDeviceLimits::maxVertexInputBindings (%u).",
1828 i, vertex_input_state->vertexBindingDescriptionCount, device_limits.maxVertexInputBindings);
Peter Kohautc7d9d392018-07-15 00:34:07 +02001829 }
1830
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001831 if (vertex_input_state->vertexAttributeDescriptionCount > device_limits.maxVertexInputAttributes) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001832 skip |=
1833 LogError(device, "VUID-VkPipelineVertexInputStateCreateInfo-vertexAttributeDescriptionCount-00614",
1834 "vkCreateGraphicsPipelines: pararameter "
1835 "pCreateInfo[%d].pVertexInputState->vertexAttributeDescriptionCount (%u) is "
1836 "greater than VkPhysicalDeviceLimits::maxVertexInputAttributes (%u).",
1837 i, vertex_input_state->vertexAttributeDescriptionCount, device_limits.maxVertexInputAttributes);
Peter Kohautc7d9d392018-07-15 00:34:07 +02001838 }
1839
1840 std::unordered_set<uint32_t> vertex_bindings(vertex_input_state->vertexBindingDescriptionCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001841 for (uint32_t d = 0; d < vertex_input_state->vertexBindingDescriptionCount; ++d) {
1842 auto const &vertex_bind_desc = vertex_input_state->pVertexBindingDescriptions[d];
Peter Kohautc7d9d392018-07-15 00:34:07 +02001843 auto const &binding_it = vertex_bindings.find(vertex_bind_desc.binding);
1844 if (binding_it != vertex_bindings.cend()) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001845 skip |= LogError(device, "VUID-VkPipelineVertexInputStateCreateInfo-pVertexBindingDescriptions-00616",
1846 "vkCreateGraphicsPipelines: parameter "
1847 "pCreateInfo[%d].pVertexInputState->pVertexBindingDescription[%d].binding "
1848 "(%" PRIu32 ") is not distinct.",
1849 i, d, vertex_bind_desc.binding);
Peter Kohautc7d9d392018-07-15 00:34:07 +02001850 }
1851 vertex_bindings.insert(vertex_bind_desc.binding);
1852
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001853 if (vertex_bind_desc.binding >= device_limits.maxVertexInputBindings) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001854 skip |= LogError(device, "VUID-VkVertexInputBindingDescription-binding-00618",
1855 "vkCreateGraphicsPipelines: parameter "
1856 "pCreateInfos[%u].pVertexInputState->pVertexBindingDescriptions[%u].binding (%u) is "
1857 "greater than or equal to VkPhysicalDeviceLimits::maxVertexInputBindings (%u).",
1858 i, d, vertex_bind_desc.binding, device_limits.maxVertexInputBindings);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001859 }
1860
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001861 if (vertex_bind_desc.stride > device_limits.maxVertexInputBindingStride) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001862 skip |=
1863 LogError(device, "VUID-VkVertexInputBindingDescription-stride-00619",
1864 "vkCreateGraphicsPipelines: parameter "
1865 "pCreateInfos[%u].pVertexInputState->pVertexBindingDescriptions[%u].stride (%u) is greater "
1866 "than VkPhysicalDeviceLimits::maxVertexInputBindingStride (%u).",
1867 i, d, vertex_bind_desc.stride, device_limits.maxVertexInputBindingStride);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001868 }
1869 }
1870
Peter Kohautc7d9d392018-07-15 00:34:07 +02001871 std::unordered_set<uint32_t> attribute_locations(vertex_input_state->vertexAttributeDescriptionCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001872 for (uint32_t d = 0; d < vertex_input_state->vertexAttributeDescriptionCount; ++d) {
1873 auto const &vertex_attrib_desc = vertex_input_state->pVertexAttributeDescriptions[d];
Peter Kohautc7d9d392018-07-15 00:34:07 +02001874 auto const &location_it = attribute_locations.find(vertex_attrib_desc.location);
1875 if (location_it != attribute_locations.cend()) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001876 skip |= LogError(
1877 device, "VUID-VkPipelineVertexInputStateCreateInfo-pVertexAttributeDescriptions-00617",
Peter Kohautc7d9d392018-07-15 00:34:07 +02001878 "vkCreateGraphicsPipelines: parameter "
1879 "pCreateInfo[%d].pVertexInputState->vertexAttributeDescriptions[%d].location (%u) is not distinct.",
1880 i, d, vertex_attrib_desc.location);
1881 }
1882 attribute_locations.insert(vertex_attrib_desc.location);
1883
1884 auto const &binding_it = vertex_bindings.find(vertex_attrib_desc.binding);
1885 if (binding_it == vertex_bindings.cend()) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001886 skip |= LogError(
1887 device, "VUID-VkPipelineVertexInputStateCreateInfo-binding-00615",
Peter Kohautc7d9d392018-07-15 00:34:07 +02001888 "vkCreateGraphicsPipelines: parameter "
1889 " pCreateInfo[%d].pVertexInputState->vertexAttributeDescriptions[%d].binding (%u) does not exist "
1890 "in any pCreateInfo[%d].pVertexInputState->pVertexBindingDescription.",
1891 i, d, vertex_attrib_desc.binding, i);
1892 }
1893
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001894 if (vertex_attrib_desc.location >= device_limits.maxVertexInputAttributes) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001895 skip |= LogError(device, "VUID-VkVertexInputAttributeDescription-location-00620",
1896 "vkCreateGraphicsPipelines: parameter "
1897 "pCreateInfos[%u].pVertexInputState->pVertexAttributeDescriptions[%u].location (%u) is "
1898 "greater than or equal to VkPhysicalDeviceLimits::maxVertexInputAttributes (%u).",
1899 i, d, vertex_attrib_desc.location, device_limits.maxVertexInputAttributes);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001900 }
1901
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001902 if (vertex_attrib_desc.binding >= device_limits.maxVertexInputBindings) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001903 skip |= LogError(device, "VUID-VkVertexInputAttributeDescription-binding-00621",
1904 "vkCreateGraphicsPipelines: parameter "
1905 "pCreateInfos[%u].pVertexInputState->pVertexAttributeDescriptions[%u].binding (%u) is "
1906 "greater than or equal to VkPhysicalDeviceLimits::maxVertexInputBindings (%u).",
1907 i, d, vertex_attrib_desc.binding, device_limits.maxVertexInputBindings);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001908 }
1909
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001910 if (vertex_attrib_desc.offset > device_limits.maxVertexInputAttributeOffset) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001911 skip |= LogError(device, "VUID-VkVertexInputAttributeDescription-offset-00622",
1912 "vkCreateGraphicsPipelines: parameter "
1913 "pCreateInfos[%u].pVertexInputState->pVertexAttributeDescriptions[%u].offset (%u) is "
1914 "greater than VkPhysicalDeviceLimits::maxVertexInputAttributeOffset (%u).",
1915 i, d, vertex_attrib_desc.offset, device_limits.maxVertexInputAttributeOffset);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001916 }
1917 }
1918 }
1919
Spencer Frickef1b0a7d2020-03-16 17:38:55 -07001920 // pTessellationState is ignored without both tessellation control and tessellation evaluation shaders stages
1921 if (has_control && has_eval) {
1922 if (pCreateInfos[i].pTessellationState == nullptr) {
1923 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-pStages-00731",
1924 "vkCreateGraphicsPipelines: if pCreateInfos[%d].pStages includes a tessellation control "
1925 "shader stage and a tessellation evaluation shader stage, "
1926 "pCreateInfos[%d].pTessellationState must not be NULL.",
1927 i, i);
1928 } else {
1929 const VkStructureType allowed_type = VK_STRUCTURE_TYPE_PIPELINE_TESSELLATION_DOMAIN_ORIGIN_STATE_CREATE_INFO;
1930 skip |= validate_struct_pnext(
1931 "vkCreateGraphicsPipelines",
1932 ParameterName("pCreateInfos[%i].pTessellationState->pNext", ParameterName::IndexVector{i}),
1933 "VkPipelineTessellationDomainOriginStateCreateInfo", pCreateInfos[i].pTessellationState->pNext, 1,
1934 &allowed_type, GeneratedVulkanHeaderVersion, "VUID-VkGraphicsPipelineCreateInfo-pNext-pNext",
1935 "VUID-VkGraphicsPipelineCreateInfo-sType-unique");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001936
Spencer Frickef1b0a7d2020-03-16 17:38:55 -07001937 skip |= validate_reserved_flags(
1938 "vkCreateGraphicsPipelines",
1939 ParameterName("pCreateInfos[%i].pTessellationState->flags", ParameterName::IndexVector{i}),
1940 pCreateInfos[i].pTessellationState->flags, "VUID-VkPipelineTessellationStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001941
Spencer Frickef1b0a7d2020-03-16 17:38:55 -07001942 if (pCreateInfos[i].pTessellationState->patchControlPoints == 0 ||
1943 pCreateInfos[i].pTessellationState->patchControlPoints > device_limits.maxTessellationPatchSize) {
1944 skip |= LogError(device, "VUID-VkPipelineTessellationStateCreateInfo-patchControlPoints-01214",
1945 "vkCreateGraphicsPipelines: invalid parameter "
1946 "pCreateInfos[%d].pTessellationState->patchControlPoints value %u. patchControlPoints "
1947 "should be >0 and <=%u.",
1948 i, pCreateInfos[i].pTessellationState->patchControlPoints,
1949 device_limits.maxTessellationPatchSize);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001950 }
1951 }
1952 }
1953
1954 // pViewportState, pMultisampleState, pDepthStencilState, and pColorBlendState ignored when rasterization is disabled
1955 if ((pCreateInfos[i].pRasterizationState != nullptr) &&
1956 (pCreateInfos[i].pRasterizationState->rasterizerDiscardEnable == VK_FALSE)) {
1957 if (pCreateInfos[i].pViewportState == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001958 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-rasterizerDiscardEnable-00750",
1959 "vkCreateGraphicsPipelines: Rasterization is enabled (pCreateInfos[%" PRIu32
1960 "].pRasterizationState->rasterizerDiscardEnable is VK_FALSE), but pCreateInfos[%" PRIu32
1961 "].pViewportState (=NULL) is not a valid pointer.",
1962 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001963 } else {
Petr Krausa6103552017-11-16 21:21:58 +01001964 const auto &viewport_state = *pCreateInfos[i].pViewportState;
1965
1966 if (viewport_state.sType != VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_STATE_CREATE_INFO) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001967 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-sType-sType",
1968 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1969 "].pViewportState->sType is not VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_STATE_CREATE_INFO.",
1970 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001971 }
1972
Petr Krausa6103552017-11-16 21:21:58 +01001973 const VkStructureType allowed_structs_VkPipelineViewportStateCreateInfo[] = {
1974 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_SWIZZLE_STATE_CREATE_INFO_NV,
Jeff Bolz3e71f782018-08-29 23:15:45 -05001975 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_W_SCALING_STATE_CREATE_INFO_NV,
1976 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_EXCLUSIVE_SCISSOR_STATE_CREATE_INFO_NV,
Jeff Bolz9af91c52018-09-01 21:53:57 -05001977 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_SHADING_RATE_IMAGE_STATE_CREATE_INFO_NV,
1978 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_COARSE_SAMPLE_ORDER_STATE_CREATE_INFO_NV,
Jeff Bolz3e71f782018-08-29 23:15:45 -05001979 };
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001980 skip |= validate_struct_pnext(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001981 "vkCreateGraphicsPipelines",
Petr Krausa6103552017-11-16 21:21:58 +01001982 ParameterName("pCreateInfos[%i].pViewportState->pNext", ParameterName::IndexVector{i}),
Jeff Bolz9af91c52018-09-01 21:53:57 -05001983 "VkPipelineViewportSwizzleStateCreateInfoNV, VkPipelineViewportWScalingStateCreateInfoNV, "
Jeff Bolzb8a8dd02018-09-18 02:39:24 -05001984 "VkPipelineViewportExclusiveScissorStateCreateInfoNV, VkPipelineViewportShadingRateImageStateCreateInfoNV, "
1985 "VkPipelineViewportCoarseSampleOrderStateCreateInfoNV",
Petr Krausa6103552017-11-16 21:21:58 +01001986 viewport_state.pNext, ARRAY_SIZE(allowed_structs_VkPipelineViewportStateCreateInfo),
sfricke-samsung32a27362020-02-28 09:06:42 -08001987 allowed_structs_VkPipelineViewportStateCreateInfo, 65, "VUID-VkPipelineViewportStateCreateInfo-pNext-pNext",
1988 "VUID-VkPipelineViewportStateCreateInfo-sType-unique");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001989
1990 skip |= validate_reserved_flags(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001991 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001992 ParameterName("pCreateInfos[%i].pViewportState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06001993 viewport_state.flags, "VUID-VkPipelineViewportStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001994
Dave Houlton142c4cb2018-10-17 15:04:41 -06001995 auto exclusive_scissor_struct = lvl_find_in_chain<VkPipelineViewportExclusiveScissorStateCreateInfoNV>(
1996 pCreateInfos[i].pViewportState->pNext);
1997 auto shading_rate_image_struct = lvl_find_in_chain<VkPipelineViewportShadingRateImageStateCreateInfoNV>(
1998 pCreateInfos[i].pViewportState->pNext);
1999 auto coarse_sample_order_struct = lvl_find_in_chain<VkPipelineViewportCoarseSampleOrderStateCreateInfoNV>(
2000 pCreateInfos[i].pViewportState->pNext);
Chris Mayer328d8212018-12-11 14:16:18 +01002001 const auto vp_swizzle_struct =
2002 lvl_find_in_chain<VkPipelineViewportSwizzleStateCreateInfoNV>(pCreateInfos[i].pViewportState->pNext);
Chris Mayer9ded5eb2019-09-19 16:33:26 +02002003 const auto vp_w_scaling_struct =
2004 lvl_find_in_chain<VkPipelineViewportWScalingStateCreateInfoNV>(pCreateInfos[i].pViewportState->pNext);
Jeff Bolz3e71f782018-08-29 23:15:45 -05002005
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002006 if (!physical_device_features.multiViewport) {
Mark Lobodzinski8b9ddab2020-10-15 14:38:43 -06002007 if (!has_dynamic_viewport_with_count && (viewport_state.viewportCount != 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002008 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-viewportCount-01216",
2009 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
2010 "disabled, but pCreateInfos[%" PRIu32 "].pViewportState->viewportCount (=%" PRIu32
2011 ") is not 1.",
2012 i, viewport_state.viewportCount);
Petr Krausa6103552017-11-16 21:21:58 +01002013 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002014
Mark Lobodzinski8b9ddab2020-10-15 14:38:43 -06002015 if (!has_dynamic_scissor_with_count && (viewport_state.scissorCount != 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002016 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-01217",
2017 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
2018 "disabled, but pCreateInfos[%" PRIu32 "].pViewportState->scissorCount (=%" PRIu32
2019 ") is not 1.",
2020 i, viewport_state.scissorCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002021 }
Jeff Bolz3e71f782018-08-29 23:15:45 -05002022
Dave Houlton142c4cb2018-10-17 15:04:41 -06002023 if (exclusive_scissor_struct && (exclusive_scissor_struct->exclusiveScissorCount != 0 &&
2024 exclusive_scissor_struct->exclusiveScissorCount != 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002025 skip |= LogError(
2026 device, "VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-exclusiveScissorCount-02027",
2027 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
2028 "disabled, but pCreateInfos[%" PRIu32
2029 "] VkPipelineViewportExclusiveScissorStateCreateInfoNV::exclusiveScissorCount (=%" PRIu32
2030 ") is not 1.",
2031 i, exclusive_scissor_struct->exclusiveScissorCount);
Jeff Bolz3e71f782018-08-29 23:15:45 -05002032 }
2033
Jeff Bolz9af91c52018-09-01 21:53:57 -05002034 if (shading_rate_image_struct &&
2035 (shading_rate_image_struct->viewportCount != 0 && shading_rate_image_struct->viewportCount != 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002036 skip |= LogError(device, "VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-viewportCount-02054",
2037 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
2038 "disabled, but pCreateInfos[%" PRIu32
2039 "] VkPipelineViewportShadingRateImageStateCreateInfoNV::viewportCount (=%" PRIu32
2040 ") is neither 0 nor 1.",
2041 i, shading_rate_image_struct->viewportCount);
Jeff Bolz9af91c52018-09-01 21:53:57 -05002042 }
2043
Petr Krausa6103552017-11-16 21:21:58 +01002044 } else { // multiViewport enabled
2045 if (viewport_state.viewportCount == 0) {
Piers Daniell39842ee2020-07-10 16:42:33 -06002046 if (!has_dynamic_viewport_with_count) {
2047 skip |= LogError(
2048 device, "VUID-VkPipelineViewportStateCreateInfo-viewportCount-arraylength",
2049 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "].pViewportState->viewportCount is 0.", i);
2050 }
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002051 } else if (viewport_state.viewportCount > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002052 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-viewportCount-01218",
2053 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2054 "].pViewportState->viewportCount (=%" PRIu32
2055 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
2056 i, viewport_state.viewportCount, device_limits.maxViewports);
Piers Daniell39842ee2020-07-10 16:42:33 -06002057 } else if (has_dynamic_viewport_with_count) {
2058 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-03379",
2059 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2060 "].pViewportState->viewportCount (=%" PRIu32
2061 ") must be zero when VK_DYNAMIC_STATE_VIEWPORT_WITH_COUNT_EXT is used.",
2062 i, viewport_state.viewportCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002063 }
Petr Krausa6103552017-11-16 21:21:58 +01002064
2065 if (viewport_state.scissorCount == 0) {
Piers Daniell39842ee2020-07-10 16:42:33 -06002066 if (!has_dynamic_scissor_with_count) {
2067 skip |= LogError(
2068 device, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-arraylength",
2069 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "].pViewportState->scissorCount is 0.", i);
2070 }
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002071 } else if (viewport_state.scissorCount > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002072 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-01219",
2073 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2074 "].pViewportState->scissorCount (=%" PRIu32
2075 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
2076 i, viewport_state.scissorCount, device_limits.maxViewports);
Piers Daniell39842ee2020-07-10 16:42:33 -06002077 } else if (has_dynamic_scissor_with_count) {
2078 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-03380",
2079 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2080 "].pViewportState->scissorCount (=%" PRIu32
2081 ") must be zero when VK_DYNAMIC_STATE_SCISSOR_WITH_COUNT_EXT is used.",
2082 i, viewport_state.viewportCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002083 }
2084 }
2085
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002086 if (exclusive_scissor_struct && exclusive_scissor_struct->exclusiveScissorCount > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002087 skip |=
2088 LogError(device, "VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-exclusiveScissorCount-02028",
2089 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "] exclusiveScissorCount (=%" PRIu32
2090 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
2091 i, exclusive_scissor_struct->exclusiveScissorCount, device_limits.maxViewports);
Jeff Bolz3e71f782018-08-29 23:15:45 -05002092 }
2093
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002094 if (shading_rate_image_struct && shading_rate_image_struct->viewportCount > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002095 skip |= LogError(device, "VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-viewportCount-02055",
2096 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2097 "] VkPipelineViewportShadingRateImageStateCreateInfoNV viewportCount (=%" PRIu32
2098 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
2099 i, shading_rate_image_struct->viewportCount, device_limits.maxViewports);
Jeff Bolz9af91c52018-09-01 21:53:57 -05002100 }
2101
Piers Daniell39842ee2020-07-10 16:42:33 -06002102 if (viewport_state.scissorCount != viewport_state.viewportCount &&
2103 !(has_dynamic_viewport_with_count || has_dynamic_scissor_with_count)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002104 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-01220",
2105 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2106 "].pViewportState->scissorCount (=%" PRIu32 ") is not identical to pCreateInfos[%" PRIu32
2107 "].pViewportState->viewportCount (=%" PRIu32 ").",
2108 i, viewport_state.scissorCount, i, viewport_state.viewportCount);
Petr Krausa6103552017-11-16 21:21:58 +01002109 }
2110
Dave Houlton142c4cb2018-10-17 15:04:41 -06002111 if (exclusive_scissor_struct && exclusive_scissor_struct->exclusiveScissorCount != 0 &&
Jeff Bolz3e71f782018-08-29 23:15:45 -05002112 exclusive_scissor_struct->exclusiveScissorCount != viewport_state.viewportCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002113 skip |=
2114 LogError(device, "VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-exclusiveScissorCount-02029",
2115 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "] exclusiveScissorCount (=%" PRIu32
2116 ") must be zero or identical to pCreateInfos[%" PRIu32
2117 "].pViewportState->viewportCount (=%" PRIu32 ").",
2118 i, exclusive_scissor_struct->exclusiveScissorCount, i, viewport_state.viewportCount);
Jeff Bolz3e71f782018-08-29 23:15:45 -05002119 }
2120
Dave Houlton142c4cb2018-10-17 15:04:41 -06002121 if (shading_rate_image_struct && shading_rate_image_struct->shadingRateImageEnable &&
Jeff Bolz9af91c52018-09-01 21:53:57 -05002122 shading_rate_image_struct->viewportCount != viewport_state.viewportCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002123 skip |= LogError(
2124 device, "VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-shadingRateImageEnable-02056",
Dave Houlton142c4cb2018-10-17 15:04:41 -06002125 "vkCreateGraphicsPipelines: If shadingRateImageEnable is enabled, pCreateInfos[%" PRIu32
2126 "] "
2127 "VkPipelineViewportShadingRateImageStateCreateInfoNV viewportCount (=%" PRIu32
2128 ") must identical to pCreateInfos[%" PRIu32 "].pViewportState->viewportCount (=%" PRIu32 ").",
2129 i, shading_rate_image_struct->viewportCount, i, viewport_state.viewportCount);
Jeff Bolz9af91c52018-09-01 21:53:57 -05002130 }
2131
Petr Krausa6103552017-11-16 21:21:58 +01002132 if (!has_dynamic_viewport && viewport_state.viewportCount > 0 && viewport_state.pViewports == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002133 skip |= LogError(
2134 device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-00747",
Petr Krausa6103552017-11-16 21:21:58 +01002135 "vkCreateGraphicsPipelines: The viewport state is static (pCreateInfos[%" PRIu32
2136 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_VIEWPORT), but pCreateInfos[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002137 "].pViewportState->pViewports (=NULL) is an invalid pointer.",
2138 i, i);
Petr Krausa6103552017-11-16 21:21:58 +01002139 }
2140
2141 if (!has_dynamic_scissor && viewport_state.scissorCount > 0 && viewport_state.pScissors == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002142 skip |= LogError(
2143 device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-00748",
Petr Krausa6103552017-11-16 21:21:58 +01002144 "vkCreateGraphicsPipelines: The scissor state is static (pCreateInfos[%" PRIu32
2145 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_SCISSOR), but pCreateInfos[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002146 "].pViewportState->pScissors (=NULL) is an invalid pointer.",
2147 i, i);
Petr Krausa6103552017-11-16 21:21:58 +01002148 }
2149
Jeff Bolz3e71f782018-08-29 23:15:45 -05002150 if (!has_dynamic_exclusive_scissor_nv && exclusive_scissor_struct &&
Dave Houlton142c4cb2018-10-17 15:04:41 -06002151 exclusive_scissor_struct->exclusiveScissorCount > 0 &&
2152 exclusive_scissor_struct->pExclusiveScissors == nullptr) {
2153 skip |=
Shannon McPherson24c13d12020-06-18 15:51:41 -06002154 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-04056",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002155 "vkCreateGraphicsPipelines: The exclusive scissor state is static (pCreateInfos[%" PRIu32
2156 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV), but "
2157 "pCreateInfos[%" PRIu32 "] pExclusiveScissors (=NULL) is an invalid pointer.",
2158 i, i);
Jeff Bolz3e71f782018-08-29 23:15:45 -05002159 }
2160
Jeff Bolz9af91c52018-09-01 21:53:57 -05002161 if (!has_dynamic_shading_rate_palette_nv && shading_rate_image_struct &&
Dave Houlton142c4cb2018-10-17 15:04:41 -06002162 shading_rate_image_struct->viewportCount > 0 &&
2163 shading_rate_image_struct->pShadingRatePalettes == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002164 skip |= LogError(
Shannon McPherson24c13d12020-06-18 15:51:41 -06002165 device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-04057",
Jeff Bolz9af91c52018-09-01 21:53:57 -05002166 "vkCreateGraphicsPipelines: The shading rate palette state is static (pCreateInfos[%" PRIu32
Dave Houlton142c4cb2018-10-17 15:04:41 -06002167 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_VIEWPORT_SHADING_RATE_PALETTE_NV), "
2168 "but pCreateInfos[%" PRIu32 "] pShadingRatePalettes (=NULL) is an invalid pointer.",
Jeff Bolz9af91c52018-09-01 21:53:57 -05002169 i, i);
2170 }
2171
Chris Mayer328d8212018-12-11 14:16:18 +01002172 if (vp_swizzle_struct) {
2173 if (vp_swizzle_struct->viewportCount != viewport_state.viewportCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002174 skip |= LogError(device, "VUID-VkPipelineViewportSwizzleStateCreateInfoNV-viewportCount-01215",
2175 "vkCreateGraphicsPipelines: The viewport swizzle state vieport count of %" PRIu32
2176 " does "
2177 "not match the viewport count of %" PRIu32 " in VkPipelineViewportStateCreateInfo.",
2178 vp_swizzle_struct->viewportCount, viewport_state.viewportCount);
Chris Mayer328d8212018-12-11 14:16:18 +01002179 }
2180 }
2181
Petr Krausb3fcdb42018-01-09 22:09:09 +01002182 // validate the VkViewports
2183 if (!has_dynamic_viewport && viewport_state.pViewports) {
2184 for (uint32_t viewport_i = 0; viewport_i < viewport_state.viewportCount; ++viewport_i) {
2185 const auto &viewport = viewport_state.pViewports[viewport_i]; // will crash on invalid ptr
Jeff Bolz6d3beaa2019-02-09 21:00:05 -06002186 const char *fn_name = "vkCreateGraphicsPipelines";
2187 skip |= manual_PreCallValidateViewport(viewport, fn_name,
2188 ParameterName("pCreateInfos[%i].pViewportState->pViewports[%i]",
2189 ParameterName::IndexVector{i, viewport_i}),
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002190 VkCommandBuffer(0));
Petr Krausb3fcdb42018-01-09 22:09:09 +01002191 }
2192 }
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07002193
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002194 if (has_dynamic_viewport_w_scaling_nv && !device_extensions.vk_nv_clip_space_w_scaling) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002195 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
2196 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2197 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_VIEWPORT_W_SCALING_NV, but "
2198 "VK_NV_clip_space_w_scaling extension is not enabled.",
2199 i);
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07002200 }
2201
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002202 if (has_dynamic_discard_rectangle_ext && !device_extensions.vk_ext_discard_rectangles) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002203 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
2204 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2205 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_DISCARD_RECTANGLE_EXT, but "
2206 "VK_EXT_discard_rectangles extension is not enabled.",
2207 i);
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07002208 }
2209
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002210 if (has_dynamic_sample_locations_ext && !device_extensions.vk_ext_sample_locations) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002211 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
2212 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2213 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_SAMPLE_LOCATIONS_EXT, but "
2214 "VK_EXT_sample_locations extension is not enabled.",
2215 i);
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07002216 }
Jeff Bolz3e71f782018-08-29 23:15:45 -05002217
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002218 if (has_dynamic_exclusive_scissor_nv && !device_extensions.vk_nv_scissor_exclusive) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002219 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
2220 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2221 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV, but "
2222 "VK_NV_scissor_exclusive extension is not enabled.",
2223 i);
Jeff Bolz3e71f782018-08-29 23:15:45 -05002224 }
Jeff Bolz9af91c52018-09-01 21:53:57 -05002225
2226 if (coarse_sample_order_struct &&
2227 coarse_sample_order_struct->sampleOrderType != VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV &&
2228 coarse_sample_order_struct->customSampleOrderCount != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002229 skip |= LogError(device, "VUID-VkPipelineViewportCoarseSampleOrderStateCreateInfoNV-sampleOrderType-02072",
2230 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2231 "] "
2232 "VkPipelineViewportCoarseSampleOrderStateCreateInfoNV sampleOrderType is not "
2233 "VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV and customSampleOrderCount is not 0.",
2234 i);
Jeff Bolz9af91c52018-09-01 21:53:57 -05002235 }
2236
2237 if (coarse_sample_order_struct) {
2238 for (uint32_t order_i = 0; order_i < coarse_sample_order_struct->customSampleOrderCount; ++order_i) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002239 skip |= ValidateCoarseSampleOrderCustomNV(&coarse_sample_order_struct->pCustomSampleOrders[order_i]);
Jeff Bolz9af91c52018-09-01 21:53:57 -05002240 }
2241 }
Chris Mayer9ded5eb2019-09-19 16:33:26 +02002242
2243 if (vp_w_scaling_struct && (vp_w_scaling_struct->viewportWScalingEnable == VK_TRUE)) {
2244 if (vp_w_scaling_struct->viewportCount != viewport_state.viewportCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002245 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-viewportWScalingEnable-01726",
2246 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2247 "] "
2248 "VkPipelineViewportWScalingStateCreateInfoNV.viewportCount (=%" PRIu32
2249 ") "
2250 "is not equal to VkPipelineViewportStateCreateInfo.viewportCount (=%" PRIu32 ").",
2251 i, vp_w_scaling_struct->viewportCount, viewport_state.viewportCount);
Chris Mayer9ded5eb2019-09-19 16:33:26 +02002252 }
2253 if (!has_dynamic_viewport_w_scaling_nv && !vp_w_scaling_struct->pViewportWScalings) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002254 skip |= LogError(
2255 device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-01715",
Chris Mayer9ded5eb2019-09-19 16:33:26 +02002256 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2257 "] "
2258 "VkPipelineViewportWScalingStateCreateInfoNV.pViewportWScalings (=NULL) is not a valid array.",
2259 i);
2260 }
2261 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002262 }
2263
2264 if (pCreateInfos[i].pMultisampleState == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002265 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-rasterizerDiscardEnable-00751",
2266 "vkCreateGraphicsPipelines: if pCreateInfos[%d].pRasterizationState->rasterizerDiscardEnable "
2267 "is VK_FALSE, pCreateInfos[%d].pMultisampleState must not be NULL.",
2268 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002269 } else {
Dave Houltonb3bbec72018-01-17 10:13:33 -07002270 const VkStructureType valid_next_stypes[] = {LvlTypeMap<VkPipelineCoverageModulationStateCreateInfoNV>::kSType,
Mark Lobodzinski1ddf16f2020-08-13 08:58:13 -06002271 LvlTypeMap<VkPipelineCoverageReductionStateCreateInfoNV>::kSType,
Dave Houltonb3bbec72018-01-17 10:13:33 -07002272 LvlTypeMap<VkPipelineCoverageToColorStateCreateInfoNV>::kSType,
2273 LvlTypeMap<VkPipelineSampleLocationsStateCreateInfoEXT>::kSType};
Mike Schuchardt97662b02017-12-06 13:31:29 -07002274 const char *valid_struct_names =
Dave Houltona9df0ce2018-02-07 10:51:23 -07002275 "VkPipelineCoverageModulationStateCreateInfoNV, VkPipelineCoverageToColorStateCreateInfoNV, "
John Zulauf96b0e422017-11-14 11:43:19 -07002276 "VkPipelineSampleLocationsStateCreateInfoEXT";
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002277 skip |= validate_struct_pnext(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002278 "vkCreateGraphicsPipelines",
John Zulauf96b0e422017-11-14 11:43:19 -07002279 ParameterName("pCreateInfos[%i].pMultisampleState->pNext", ParameterName::IndexVector{i}),
Mark Lobodzinski1ddf16f2020-08-13 08:58:13 -06002280 valid_struct_names, pCreateInfos[i].pMultisampleState->pNext, 4, valid_next_stypes,
sfricke-samsung32a27362020-02-28 09:06:42 -08002281 GeneratedVulkanHeaderVersion, "VUID-VkPipelineMultisampleStateCreateInfo-pNext-pNext",
2282 "VUID-VkPipelineMultisampleStateCreateInfo-sType-unique");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002283
2284 skip |= validate_reserved_flags(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002285 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002286 ParameterName("pCreateInfos[%i].pMultisampleState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06002287 pCreateInfos[i].pMultisampleState->flags, "VUID-VkPipelineMultisampleStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002288
2289 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002290 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002291 ParameterName("pCreateInfos[%i].pMultisampleState->sampleShadingEnable", ParameterName::IndexVector{i}),
2292 pCreateInfos[i].pMultisampleState->sampleShadingEnable);
2293
2294 skip |= validate_array(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002295 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002296 ParameterName("pCreateInfos[%i].pMultisampleState->rasterizationSamples", ParameterName::IndexVector{i}),
2297 ParameterName("pCreateInfos[%i].pMultisampleState->pSampleMask", ParameterName::IndexVector{i}),
Gabríel Arthúr Pétursson092b29b2018-03-21 22:44:11 +00002298 pCreateInfos[i].pMultisampleState->rasterizationSamples, &pCreateInfos[i].pMultisampleState->pSampleMask,
Dave Houlton413a6782018-05-22 13:01:54 -06002299 true, false, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002300
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002301 skip |= validate_flags(
2302 "vkCreateGraphicsPipelines",
2303 ParameterName("pCreateInfos[%i].pMultisampleState->rasterizationSamples", ParameterName::IndexVector{i}),
2304 "VkSampleCountFlagBits", AllVkSampleCountFlagBits, pCreateInfos[i].pMultisampleState->rasterizationSamples,
Petr Kraus52758be2019-08-12 00:53:58 +02002305 kRequiredSingleBit, "VUID-VkPipelineMultisampleStateCreateInfo-rasterizationSamples-parameter");
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002306
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002307 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002308 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002309 ParameterName("pCreateInfos[%i].pMultisampleState->alphaToCoverageEnable", ParameterName::IndexVector{i}),
2310 pCreateInfos[i].pMultisampleState->alphaToCoverageEnable);
2311
2312 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002313 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002314 ParameterName("pCreateInfos[%i].pMultisampleState->alphaToOneEnable", ParameterName::IndexVector{i}),
2315 pCreateInfos[i].pMultisampleState->alphaToOneEnable);
2316
2317 if (pCreateInfos[i].pMultisampleState->sType != VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO) {
sfricke-samsung81c56f72020-08-23 22:14:41 -07002318 skip |= LogError(device, "VUID-VkPipelineMultisampleStateCreateInfo-sType-sType",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002319 "vkCreateGraphicsPipelines: parameter pCreateInfos[%d].pMultisampleState->sType must be "
2320 "VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO",
2321 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002322 }
John Zulauf7acac592017-11-06 11:15:53 -07002323 if (pCreateInfos[i].pMultisampleState->sampleShadingEnable == VK_TRUE) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002324 if (!physical_device_features.sampleRateShading) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002325 skip |= LogError(device, "VUID-VkPipelineMultisampleStateCreateInfo-sampleShadingEnable-00784",
2326 "vkCreateGraphicsPipelines(): parameter "
2327 "pCreateInfos[%d].pMultisampleState->sampleShadingEnable.",
2328 i);
John Zulauf7acac592017-11-06 11:15:53 -07002329 }
2330 // TODO Add documentation issue about when minSampleShading must be in range and when it is ignored
2331 // For now a "least noise" test *only* when sampleShadingEnable is VK_TRUE.
2332 if (!in_inclusive_range(pCreateInfos[i].pMultisampleState->minSampleShading, 0.F, 1.0F)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002333 skip |= LogError(
2334 device,
2335
Dave Houlton413a6782018-05-22 13:01:54 -06002336 "VUID-VkPipelineMultisampleStateCreateInfo-minSampleShading-00786",
Mark Lobodzinski88529492018-04-01 10:38:15 -06002337 "vkCreateGraphicsPipelines(): parameter pCreateInfos[%d].pMultisampleState->minSampleShading.", i);
John Zulauf7acac592017-11-06 11:15:53 -07002338 }
2339 }
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002340
2341 const auto *line_state = lvl_find_in_chain<VkPipelineRasterizationLineStateCreateInfoEXT>(
2342 pCreateInfos[i].pRasterizationState->pNext);
2343
2344 if (line_state) {
2345 if ((line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_BRESENHAM_EXT ||
2346 line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_RECTANGULAR_SMOOTH_EXT)) {
2347 if (pCreateInfos[i].pMultisampleState->alphaToCoverageEnable) {
2348 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002349 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-lineRasterizationMode-02766",
2350 "vkCreateGraphicsPipelines(): Bresenham/Smooth line rasterization not supported with "
2351 "pCreateInfos[%d].pMultisampleState->alphaToCoverageEnable == VK_TRUE.",
2352 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002353 }
2354 if (pCreateInfos[i].pMultisampleState->alphaToOneEnable) {
2355 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002356 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-lineRasterizationMode-02766",
2357 "vkCreateGraphicsPipelines(): Bresenham/Smooth line rasterization not supported with "
2358 "pCreateInfos[%d].pMultisampleState->alphaToOneEnable == VK_TRUE.",
2359 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002360 }
2361 if (pCreateInfos[i].pMultisampleState->sampleShadingEnable) {
2362 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002363 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-lineRasterizationMode-02766",
2364 "vkCreateGraphicsPipelines(): Bresenham/Smooth line rasterization not supported with "
2365 "pCreateInfos[%d].pMultisampleState->sampleShadingEnable == VK_TRUE.",
2366 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002367 }
2368 }
2369 if (line_state->stippledLineEnable && !has_dynamic_line_stipple) {
2370 if (line_state->lineStippleFactor < 1 || line_state->lineStippleFactor > 256) {
2371 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002372 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-stippledLineEnable-02767",
2373 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineStippleFactor = %d must be in the "
2374 "range [1,256].",
2375 i, line_state->lineStippleFactor);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002376 }
2377 }
2378 const auto *line_features =
Tony-LunarG6c3c5452019-12-13 10:37:38 -07002379 lvl_find_in_chain<VkPhysicalDeviceLineRasterizationFeaturesEXT>(device_createinfo_pnext);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002380 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_RECTANGULAR_EXT &&
2381 (!line_features || !line_features->rectangularLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002382 skip |=
2383 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-lineRasterizationMode-02768",
2384 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineRasterizationMode = "
2385 "VK_LINE_RASTERIZATION_MODE_RECTANGULAR_EXT requires the rectangularLines feature.",
2386 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002387 }
2388 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_BRESENHAM_EXT &&
2389 (!line_features || !line_features->bresenhamLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002390 skip |=
2391 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-lineRasterizationMode-02769",
2392 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineRasterizationMode = "
2393 "VK_LINE_RASTERIZATION_MODE_BRESENHAM_EXT requires the bresenhamLines feature.",
2394 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002395 }
2396 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_RECTANGULAR_SMOOTH_EXT &&
2397 (!line_features || !line_features->smoothLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002398 skip |=
2399 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-lineRasterizationMode-02770",
2400 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineRasterizationMode = "
2401 "VK_LINE_RASTERIZATION_MODE_RECTANGULAR_SMOOTH_EXT requires the smoothLines feature.",
2402 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002403 }
2404 if (line_state->stippledLineEnable) {
2405 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_RECTANGULAR_EXT &&
2406 (!line_features || !line_features->stippledRectangularLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002407 skip |=
2408 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-stippledLineEnable-02771",
2409 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineRasterizationMode = "
2410 "VK_LINE_RASTERIZATION_MODE_RECTANGULAR_EXT with stipple requires the "
2411 "stippledRectangularLines feature.",
2412 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002413 }
2414 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_BRESENHAM_EXT &&
2415 (!line_features || !line_features->stippledBresenhamLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002416 skip |=
2417 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-stippledLineEnable-02772",
2418 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineRasterizationMode = "
2419 "VK_LINE_RASTERIZATION_MODE_BRESENHAM_EXT with stipple requires the "
2420 "stippledBresenhamLines feature.",
2421 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002422 }
2423 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_RECTANGULAR_SMOOTH_EXT &&
2424 (!line_features || !line_features->stippledSmoothLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002425 skip |=
2426 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-stippledLineEnable-02773",
2427 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineRasterizationMode = "
2428 "VK_LINE_RASTERIZATION_MODE_RECTANGULAR_SMOOTH_EXT with stipple requires the "
2429 "stippledSmoothLines feature.",
2430 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002431 }
2432 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_DEFAULT_EXT &&
2433 (!line_features || !line_features->stippledSmoothLines || !device_limits.strictLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002434 skip |=
2435 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-stippledLineEnable-02774",
2436 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineRasterizationMode = "
2437 "VK_LINE_RASTERIZATION_MODE_DEFAULT_EXT with stipple requires the "
2438 "stippledRectangularLines and strictLines features.",
2439 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002440 }
2441 }
2442 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002443 }
2444
Petr Krause91f7a12017-12-14 20:57:36 +01002445 bool uses_color_attachment = false;
2446 bool uses_depthstencil_attachment = false;
2447 {
Mark Lobodzinskif27a6bc2019-02-04 13:00:49 -07002448 std::unique_lock<std::mutex> lock(renderpass_map_mutex);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002449 const auto subpasses_uses_it = renderpasses_states.find(pCreateInfos[i].renderPass);
2450 if (subpasses_uses_it != renderpasses_states.end()) {
Petr Krause91f7a12017-12-14 20:57:36 +01002451 const auto &subpasses_uses = subpasses_uses_it->second;
2452 if (subpasses_uses.subpasses_using_color_attachment.count(pCreateInfos[i].subpass))
2453 uses_color_attachment = true;
2454 if (subpasses_uses.subpasses_using_depthstencil_attachment.count(pCreateInfos[i].subpass))
2455 uses_depthstencil_attachment = true;
2456 }
Mark Lobodzinskif27a6bc2019-02-04 13:00:49 -07002457 lock.unlock();
Petr Krause91f7a12017-12-14 20:57:36 +01002458 }
2459
2460 if (pCreateInfos[i].pDepthStencilState != nullptr && uses_depthstencil_attachment) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002461 skip |= validate_struct_pnext(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002462 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002463 ParameterName("pCreateInfos[%i].pDepthStencilState->pNext", ParameterName::IndexVector{i}), NULL,
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002464 pCreateInfos[i].pDepthStencilState->pNext, 0, NULL, GeneratedVulkanHeaderVersion,
sfricke-samsung32a27362020-02-28 09:06:42 -08002465 "VUID-VkPipelineDepthStencilStateCreateInfo-pNext-pNext", nullptr);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002466
2467 skip |= validate_reserved_flags(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002468 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002469 ParameterName("pCreateInfos[%i].pDepthStencilState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06002470 pCreateInfos[i].pDepthStencilState->flags, "VUID-VkPipelineDepthStencilStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002471
2472 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002473 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002474 ParameterName("pCreateInfos[%i].pDepthStencilState->depthTestEnable", ParameterName::IndexVector{i}),
2475 pCreateInfos[i].pDepthStencilState->depthTestEnable);
2476
2477 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002478 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002479 ParameterName("pCreateInfos[%i].pDepthStencilState->depthWriteEnable", ParameterName::IndexVector{i}),
2480 pCreateInfos[i].pDepthStencilState->depthWriteEnable);
2481
2482 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002483 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002484 ParameterName("pCreateInfos[%i].pDepthStencilState->depthCompareOp", ParameterName::IndexVector{i}),
2485 "VkCompareOp", AllVkCompareOpEnums, pCreateInfos[i].pDepthStencilState->depthCompareOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002486 "VUID-VkPipelineDepthStencilStateCreateInfo-depthCompareOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002487
2488 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002489 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002490 ParameterName("pCreateInfos[%i].pDepthStencilState->depthBoundsTestEnable", ParameterName::IndexVector{i}),
2491 pCreateInfos[i].pDepthStencilState->depthBoundsTestEnable);
2492
2493 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002494 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002495 ParameterName("pCreateInfos[%i].pDepthStencilState->stencilTestEnable", ParameterName::IndexVector{i}),
2496 pCreateInfos[i].pDepthStencilState->stencilTestEnable);
2497
2498 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002499 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002500 ParameterName("pCreateInfos[%i].pDepthStencilState->front.failOp", ParameterName::IndexVector{i}),
2501 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->front.failOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002502 "VUID-VkStencilOpState-failOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002503
2504 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002505 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002506 ParameterName("pCreateInfos[%i].pDepthStencilState->front.passOp", ParameterName::IndexVector{i}),
2507 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->front.passOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002508 "VUID-VkStencilOpState-passOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002509
2510 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002511 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002512 ParameterName("pCreateInfos[%i].pDepthStencilState->front.depthFailOp", ParameterName::IndexVector{i}),
2513 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->front.depthFailOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002514 "VUID-VkStencilOpState-depthFailOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002515
2516 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002517 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002518 ParameterName("pCreateInfos[%i].pDepthStencilState->front.compareOp", ParameterName::IndexVector{i}),
2519 "VkCompareOp", AllVkCompareOpEnums, pCreateInfos[i].pDepthStencilState->front.compareOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002520 "VUID-VkPipelineDepthStencilStateCreateInfo-depthCompareOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002521
2522 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002523 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002524 ParameterName("pCreateInfos[%i].pDepthStencilState->back.failOp", ParameterName::IndexVector{i}),
2525 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->back.failOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002526 "VUID-VkStencilOpState-failOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002527
2528 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002529 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002530 ParameterName("pCreateInfos[%i].pDepthStencilState->back.passOp", ParameterName::IndexVector{i}),
2531 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->back.passOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002532 "VUID-VkStencilOpState-passOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002533
2534 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002535 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002536 ParameterName("pCreateInfos[%i].pDepthStencilState->back.depthFailOp", ParameterName::IndexVector{i}),
2537 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->back.depthFailOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002538 "VUID-VkStencilOpState-depthFailOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002539
2540 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002541 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002542 ParameterName("pCreateInfos[%i].pDepthStencilState->back.compareOp", ParameterName::IndexVector{i}),
2543 "VkCompareOp", AllVkCompareOpEnums, pCreateInfos[i].pDepthStencilState->back.compareOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002544 "VUID-VkPipelineDepthStencilStateCreateInfo-depthCompareOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002545
2546 if (pCreateInfos[i].pDepthStencilState->sType != VK_STRUCTURE_TYPE_PIPELINE_DEPTH_STENCIL_STATE_CREATE_INFO) {
sfricke-samsung81c56f72020-08-23 22:14:41 -07002547 skip |= LogError(device, "VUID-VkPipelineDepthStencilStateCreateInfo-sType-sType",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002548 "vkCreateGraphicsPipelines: parameter pCreateInfos[%d].pDepthStencilState->sType must be "
2549 "VK_STRUCTURE_TYPE_PIPELINE_DEPTH_STENCIL_STATE_CREATE_INFO",
2550 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002551 }
2552 }
2553
Shannon McPherson9b9532b2018-10-24 12:00:09 -06002554 const VkStructureType allowed_structs_VkPipelineColorBlendStateCreateInfo[] = {
2555 VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_ADVANCED_STATE_CREATE_INFO_EXT};
2556
Petr Krause91f7a12017-12-14 20:57:36 +01002557 if (pCreateInfos[i].pColorBlendState != nullptr && uses_color_attachment) {
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002558 skip |= validate_struct_type("vkCreateGraphicsPipelines",
2559 ParameterName("pCreateInfos[%i].pColorBlendState", ParameterName::IndexVector{i}),
2560 "VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO",
2561 pCreateInfos[i].pColorBlendState,
2562 VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO, false, kVUIDUndefined,
2563 "VUID-VkPipelineColorBlendStateCreateInfo-sType-sType");
2564
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002565 skip |= validate_struct_pnext(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002566 "vkCreateGraphicsPipelines",
Shannon McPherson9b9532b2018-10-24 12:00:09 -06002567 ParameterName("pCreateInfos[%i].pColorBlendState->pNext", ParameterName::IndexVector{i}),
2568 "VkPipelineColorBlendAdvancedStateCreateInfoEXT", pCreateInfos[i].pColorBlendState->pNext,
2569 ARRAY_SIZE(allowed_structs_VkPipelineColorBlendStateCreateInfo),
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002570 allowed_structs_VkPipelineColorBlendStateCreateInfo, GeneratedVulkanHeaderVersion,
sfricke-samsung32a27362020-02-28 09:06:42 -08002571 "VUID-VkPipelineColorBlendStateCreateInfo-pNext-pNext",
2572 "VUID-VkPipelineColorBlendStateCreateInfo-sType-unique");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002573
2574 skip |= validate_reserved_flags(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002575 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002576 ParameterName("pCreateInfos[%i].pColorBlendState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06002577 pCreateInfos[i].pColorBlendState->flags, "VUID-VkPipelineColorBlendStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002578
2579 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002580 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002581 ParameterName("pCreateInfos[%i].pColorBlendState->logicOpEnable", ParameterName::IndexVector{i}),
2582 pCreateInfos[i].pColorBlendState->logicOpEnable);
2583
2584 skip |= validate_array(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002585 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002586 ParameterName("pCreateInfos[%i].pColorBlendState->attachmentCount", ParameterName::IndexVector{i}),
2587 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments", ParameterName::IndexVector{i}),
Gabríel Arthúr Pétursson092b29b2018-03-21 22:44:11 +00002588 pCreateInfos[i].pColorBlendState->attachmentCount, &pCreateInfos[i].pColorBlendState->pAttachments, false,
Dave Houlton413a6782018-05-22 13:01:54 -06002589 true, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002590
2591 if (pCreateInfos[i].pColorBlendState->pAttachments != NULL) {
2592 for (uint32_t attachmentIndex = 0; attachmentIndex < pCreateInfos[i].pColorBlendState->attachmentCount;
2593 ++attachmentIndex) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002594 skip |= validate_bool32("vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002595 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].blendEnable",
2596 ParameterName::IndexVector{i, attachmentIndex}),
2597 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].blendEnable);
2598
2599 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002600 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002601 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].srcColorBlendFactor",
2602 ParameterName::IndexVector{i, attachmentIndex}),
2603 "VkBlendFactor", AllVkBlendFactorEnums,
2604 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].srcColorBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06002605 "VUID-VkPipelineColorBlendAttachmentState-srcColorBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002606
2607 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002608 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002609 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].dstColorBlendFactor",
2610 ParameterName::IndexVector{i, attachmentIndex}),
2611 "VkBlendFactor", AllVkBlendFactorEnums,
2612 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].dstColorBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06002613 "VUID-VkPipelineColorBlendAttachmentState-dstColorBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002614
2615 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002616 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002617 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].colorBlendOp",
2618 ParameterName::IndexVector{i, attachmentIndex}),
2619 "VkBlendOp", AllVkBlendOpEnums,
2620 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].colorBlendOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002621 "VUID-VkPipelineColorBlendAttachmentState-colorBlendOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002622
2623 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002624 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002625 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].srcAlphaBlendFactor",
2626 ParameterName::IndexVector{i, attachmentIndex}),
2627 "VkBlendFactor", AllVkBlendFactorEnums,
2628 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].srcAlphaBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06002629 "VUID-VkPipelineColorBlendAttachmentState-srcAlphaBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002630
2631 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002632 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002633 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].dstAlphaBlendFactor",
2634 ParameterName::IndexVector{i, attachmentIndex}),
2635 "VkBlendFactor", AllVkBlendFactorEnums,
2636 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].dstAlphaBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06002637 "VUID-VkPipelineColorBlendAttachmentState-dstAlphaBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002638
2639 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002640 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002641 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].alphaBlendOp",
2642 ParameterName::IndexVector{i, attachmentIndex}),
2643 "VkBlendOp", AllVkBlendOpEnums,
2644 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].alphaBlendOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002645 "VUID-VkPipelineColorBlendAttachmentState-alphaBlendOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002646
2647 skip |=
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002648 validate_flags("vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002649 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].colorWriteMask",
2650 ParameterName::IndexVector{i, attachmentIndex}),
2651 "VkColorComponentFlagBits", AllVkColorComponentFlagBits,
2652 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].colorWriteMask,
Petr Kraus52758be2019-08-12 00:53:58 +02002653 kOptionalFlags, "VUID-VkPipelineColorBlendAttachmentState-colorWriteMask-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002654 }
2655 }
2656
2657 if (pCreateInfos[i].pColorBlendState->sType != VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO) {
sfricke-samsung81c56f72020-08-23 22:14:41 -07002658 skip |= LogError(device, "VUID-VkPipelineColorBlendStateCreateInfo-sType-sType",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002659 "vkCreateGraphicsPipelines: parameter pCreateInfos[%d].pColorBlendState->sType must be "
2660 "VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO",
2661 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002662 }
2663
2664 // If logicOpEnable is VK_TRUE, logicOp must be a valid VkLogicOp value
2665 if (pCreateInfos[i].pColorBlendState->logicOpEnable == VK_TRUE) {
2666 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002667 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002668 ParameterName("pCreateInfos[%i].pColorBlendState->logicOp", ParameterName::IndexVector{i}), "VkLogicOp",
Dave Houlton413a6782018-05-22 13:01:54 -06002669 AllVkLogicOpEnums, pCreateInfos[i].pColorBlendState->logicOp,
2670 "VUID-VkPipelineColorBlendStateCreateInfo-logicOpEnable-00607");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002671 }
2672 }
2673 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002674
Petr Kraus9752aae2017-11-24 03:05:50 +01002675 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_DERIVATIVE_BIT) {
2676 if (pCreateInfos[i].basePipelineIndex != -1) {
2677 if (pCreateInfos[i].basePipelineHandle != VK_NULL_HANDLE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002678 skip |=
2679 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-00724",
sfricke-samsunga470e0e2020-05-16 00:47:36 -07002680 "vkCreateGraphicsPipelines parameter, pCreateInfos[%u]->basePipelineHandle, must be "
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002681 "VK_NULL_HANDLE if pCreateInfos->flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT flag "
sfricke-samsunga470e0e2020-05-16 00:47:36 -07002682 "and pCreateInfos->basePipelineIndex is not -1.",
2683 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002684 }
2685 }
2686
Petr Kraus9752aae2017-11-24 03:05:50 +01002687 if (pCreateInfos[i].basePipelineHandle != VK_NULL_HANDLE) {
2688 if (pCreateInfos[i].basePipelineIndex != -1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002689 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-00725",
sfricke-samsunga470e0e2020-05-16 00:47:36 -07002690 "vkCreateGraphicsPipelines parameter, pCreateInfos[%u]->basePipelineIndex, must be -1 if "
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002691 "pCreateInfos->flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT flag and "
sfricke-samsunga470e0e2020-05-16 00:47:36 -07002692 "pCreateInfos->basePipelineHandle is not VK_NULL_HANDLE.",
2693 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002694 }
Mark Lobodzinski4dfeb942019-09-13 12:11:13 -06002695 } else {
Mike Schuchardte5c15cf2020-04-06 22:57:13 -07002696 if (static_cast<uint32_t>(pCreateInfos[i].basePipelineIndex) >= createInfoCount) {
sfricke-samsunga470e0e2020-05-16 00:47:36 -07002697 skip |=
2698 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-00723",
2699 "vkCreateGraphicsPipelines parameter pCreateInfos[%u]->basePipelineIndex (%d) must be a valid"
2700 "index into the pCreateInfos array, of size %d.",
2701 i, pCreateInfos[i].basePipelineIndex, createInfoCount);
Mark Lobodzinski4dfeb942019-09-13 12:11:13 -06002702 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002703 }
2704 }
2705
sfricke-samsung898cf222020-05-15 23:10:19 -07002706 if ((pCreateInfos[i].flags & VK_PIPELINE_CREATE_DISPATCH_BASE) != 0) {
2707 skip |= LogError(
2708 device, "VUID-VkGraphicsPipelineCreateInfo-flags-00764",
2709 "vkCreateGraphicsPipelines parameter pCreateInfos[%u]->flags must not contain VK_PIPELINE_CREATE_DISPATCH_BASE",
2710 i);
2711 }
2712
Petr Kraus9752aae2017-11-24 03:05:50 +01002713 if (pCreateInfos[i].pRasterizationState) {
Chris Mayer840b2c42019-08-22 18:12:22 +02002714 if (!device_extensions.vk_nv_fill_rectangle) {
2715 if (pCreateInfos[i].pRasterizationState->polygonMode == VK_POLYGON_MODE_FILL_RECTANGLE_NV) {
2716 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002717 LogError(device, "VUID-VkPipelineRasterizationStateCreateInfo-polygonMode-01414",
2718 "vkCreateGraphicsPipelines parameter, VkPolygonMode "
2719 "pCreateInfos->pRasterizationState->polygonMode cannot be VK_POLYGON_MODE_FILL_RECTANGLE_NV "
2720 "if the extension VK_NV_fill_rectangle is not enabled.");
Chris Mayer840b2c42019-08-22 18:12:22 +02002721 } else if ((pCreateInfos[i].pRasterizationState->polygonMode != VK_POLYGON_MODE_FILL) &&
2722 (physical_device_features.fillModeNonSolid == false)) {
sfricke-samsunga44586f2020-08-23 22:19:44 -07002723 skip |= LogError(device, "VUID-VkPipelineRasterizationStateCreateInfo-polygonMode-01413",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002724 "vkCreateGraphicsPipelines parameter, VkPolygonMode "
sfricke-samsunga470e0e2020-05-16 00:47:36 -07002725 "pCreateInfos[%u]->pRasterizationState->polygonMode cannot be VK_POLYGON_MODE_POINT or "
2726 "VK_POLYGON_MODE_LINE if VkPhysicalDeviceFeatures->fillModeNonSolid is false.",
2727 i);
Chris Mayer840b2c42019-08-22 18:12:22 +02002728 }
2729 } else {
2730 if ((pCreateInfos[i].pRasterizationState->polygonMode != VK_POLYGON_MODE_FILL) &&
2731 (pCreateInfos[i].pRasterizationState->polygonMode != VK_POLYGON_MODE_FILL_RECTANGLE_NV) &&
2732 (physical_device_features.fillModeNonSolid == false)) {
2733 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002734 LogError(device, "VUID-VkPipelineRasterizationStateCreateInfo-polygonMode-01507",
2735 "vkCreateGraphicsPipelines parameter, VkPolygonMode "
sfricke-samsunga470e0e2020-05-16 00:47:36 -07002736 "pCreateInfos[%u]->pRasterizationState->polygonMode must be VK_POLYGON_MODE_FILL or "
2737 "VK_POLYGON_MODE_FILL_RECTANGLE_NV if VkPhysicalDeviceFeatures->fillModeNonSolid is false.",
2738 i);
Chris Mayer840b2c42019-08-22 18:12:22 +02002739 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002740 }
Petr Kraus299ba622017-11-24 03:09:03 +01002741
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002742 if (!has_dynamic_line_width && !physical_device_features.wideLines &&
Petr Kraus299ba622017-11-24 03:09:03 +01002743 (pCreateInfos[i].pRasterizationState->lineWidth != 1.0f)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002744 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-00749",
2745 "The line width state is static (pCreateInfos[%" PRIu32
2746 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_LINE_WIDTH) and "
2747 "VkPhysicalDeviceFeatures::wideLines is disabled, but pCreateInfos[%" PRIu32
2748 "].pRasterizationState->lineWidth (=%f) is not 1.0.",
2749 i, i, pCreateInfos[i].pRasterizationState->lineWidth);
Petr Kraus299ba622017-11-24 03:09:03 +01002750 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002751 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002752 }
2753 }
2754
2755 return skip;
2756}
2757
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002758bool StatelessValidation::manual_PreCallValidateCreateComputePipelines(VkDevice device, VkPipelineCache pipelineCache,
2759 uint32_t createInfoCount,
2760 const VkComputePipelineCreateInfo *pCreateInfos,
2761 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05002762 VkPipeline *pPipelines) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002763 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002764 for (uint32_t i = 0; i < createInfoCount; i++) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002765 skip |= validate_string("vkCreateComputePipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002766 ParameterName("pCreateInfos[%i].stage.pName", ParameterName::IndexVector{i}),
Mark Lobodzinskiebee3552018-05-29 09:55:54 -06002767 "VUID-VkPipelineShaderStageCreateInfo-pName-parameter", pCreateInfos[i].stage.pName);
Peter Chen85366392019-05-14 15:20:11 -04002768 auto feedback_struct = lvl_find_in_chain<VkPipelineCreationFeedbackCreateInfoEXT>(pCreateInfos[i].pNext);
2769 if ((feedback_struct != nullptr) && (feedback_struct->pipelineStageCreationFeedbackCount != 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002770 skip |=
2771 LogError(device, "VUID-VkPipelineCreationFeedbackCreateInfoEXT-pipelineStageCreationFeedbackCount-02669",
2772 "vkCreateComputePipelines(): in pCreateInfo[%" PRIu32
2773 "], VkPipelineCreationFeedbackEXT::pipelineStageCreationFeedbackCount must equal 1, found %" PRIu32 ".",
2774 i, feedback_struct->pipelineStageCreationFeedbackCount);
Peter Chen85366392019-05-14 15:20:11 -04002775 }
sfricke-samsungc5227152020-02-09 17:36:31 -08002776
2777 // Make sure compute stage is selected
2778 if (pCreateInfos[i].stage.stage != VK_SHADER_STAGE_COMPUTE_BIT) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002779 skip |= LogError(device, "VUID-VkComputePipelineCreateInfo-stage-00701",
2780 "vkCreateComputePipelines(): the pCreateInfo[%u].stage.stage (%s) is not VK_SHADER_STAGE_COMPUTE_BIT",
2781 i, string_VkShaderStageFlagBits(pCreateInfos[i].stage.stage));
sfricke-samsungc5227152020-02-09 17:36:31 -08002782 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002783 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002784 return skip;
2785}
2786
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002787bool StatelessValidation::manual_PreCallValidateCreateSampler(VkDevice device, const VkSamplerCreateInfo *pCreateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -05002788 const VkAllocationCallbacks *pAllocator, VkSampler *pSampler) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002789 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002790
2791 if (pCreateInfo != nullptr) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002792 const auto &features = physical_device_features;
2793 const auto &limits = device_limits;
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002794
John Zulauf71968502017-10-26 13:51:15 -06002795 if (pCreateInfo->anisotropyEnable == VK_TRUE) {
2796 if (!in_inclusive_range(pCreateInfo->maxAnisotropy, 1.0F, limits.maxSamplerAnisotropy)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002797 skip |= LogError(device, "VUID-VkSamplerCreateInfo-anisotropyEnable-01071",
2798 "vkCreateSampler(): value of %s must be in range [1.0, %f] %s, but %f found.",
2799 "pCreateInfo->maxAnisotropy", limits.maxSamplerAnisotropy,
2800 "VkPhysicalDeviceLimits::maxSamplerAnistropy", pCreateInfo->maxAnisotropy);
John Zulauf71968502017-10-26 13:51:15 -06002801 }
2802
2803 // Anistropy cannot be enabled in sampler unless enabled as a feature
2804 if (features.samplerAnisotropy == VK_FALSE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002805 skip |= LogError(device, "VUID-VkSamplerCreateInfo-anisotropyEnable-01070",
2806 "vkCreateSampler(): Anisotropic sampling feature is not enabled, %s must be VK_FALSE.",
2807 "pCreateInfo->anisotropyEnable");
John Zulauf71968502017-10-26 13:51:15 -06002808 }
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002809 }
John Zulauf71968502017-10-26 13:51:15 -06002810
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002811 if (pCreateInfo->unnormalizedCoordinates == VK_TRUE) {
2812 if (pCreateInfo->minFilter != pCreateInfo->magFilter) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002813 skip |= LogError(device, "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01072",
2814 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
2815 "pCreateInfo->minFilter (%s) and pCreateInfo->magFilter (%s) must be equal.",
2816 string_VkFilter(pCreateInfo->minFilter), string_VkFilter(pCreateInfo->magFilter));
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002817 }
2818 if (pCreateInfo->mipmapMode != VK_SAMPLER_MIPMAP_MODE_NEAREST) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002819 skip |= LogError(device, "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01073",
2820 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
2821 "pCreateInfo->mipmapMode (%s) must be VK_SAMPLER_MIPMAP_MODE_NEAREST.",
2822 string_VkSamplerMipmapMode(pCreateInfo->mipmapMode));
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002823 }
2824 if (pCreateInfo->minLod != 0.0f || pCreateInfo->maxLod != 0.0f) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002825 skip |= LogError(device, "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01074",
2826 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
2827 "pCreateInfo->minLod (%f) and pCreateInfo->maxLod (%f) must both be zero.",
2828 pCreateInfo->minLod, pCreateInfo->maxLod);
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002829 }
2830 if ((pCreateInfo->addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE &&
2831 pCreateInfo->addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER) ||
2832 (pCreateInfo->addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE &&
2833 pCreateInfo->addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002834 skip |= LogError(device, "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01075",
2835 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
2836 "pCreateInfo->addressModeU (%s) and pCreateInfo->addressModeV (%s) must both be "
2837 "VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE or VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER.",
2838 string_VkSamplerAddressMode(pCreateInfo->addressModeU),
2839 string_VkSamplerAddressMode(pCreateInfo->addressModeV));
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002840 }
2841 if (pCreateInfo->anisotropyEnable == VK_TRUE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002842 skip |= LogError(device, "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01076",
2843 "vkCreateSampler(): pCreateInfo->anisotropyEnable and pCreateInfo->unnormalizedCoordinates must "
2844 "not both be VK_TRUE.");
John Zulauf71968502017-10-26 13:51:15 -06002845 }
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002846 if (pCreateInfo->compareEnable == VK_TRUE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002847 skip |= LogError(device, "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01077",
2848 "vkCreateSampler(): pCreateInfo->compareEnable and pCreateInfo->unnormalizedCoordinates must "
2849 "not both be VK_TRUE.");
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002850 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002851 }
2852
2853 // If compareEnable is VK_TRUE, compareOp must be a valid VkCompareOp value
2854 if (pCreateInfo->compareEnable == VK_TRUE) {
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002855 skip |= validate_ranged_enum("vkCreateSampler", "pCreateInfo->compareOp", "VkCompareOp", AllVkCompareOpEnums,
2856 pCreateInfo->compareOp, "VUID-VkSamplerCreateInfo-compareEnable-01080");
sfricke-samsung85252fb2020-05-08 20:44:06 -07002857 const auto *sampler_reduction = lvl_find_in_chain<VkSamplerReductionModeCreateInfo>(pCreateInfo->pNext);
2858 if (sampler_reduction != nullptr) {
2859 if (sampler_reduction->reductionMode != VK_SAMPLER_REDUCTION_MODE_WEIGHTED_AVERAGE) {
2860 skip |= LogError(
2861 device, "VUID-VkSamplerCreateInfo-compareEnable-01423",
2862 "copmareEnable is true so the sampler reduction mode must be VK_SAMPLER_REDUCTION_MODE_WEIGHTED_AVERAGE.");
2863 }
2864 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002865 }
2866
2867 // If any of addressModeU, addressModeV or addressModeW are VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER, borderColor must be a
2868 // valid VkBorderColor value
2869 if ((pCreateInfo->addressModeU == VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER) ||
2870 (pCreateInfo->addressModeV == VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER) ||
2871 (pCreateInfo->addressModeW == VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER)) {
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002872 skip |= validate_ranged_enum("vkCreateSampler", "pCreateInfo->borderColor", "VkBorderColor", AllVkBorderColorEnums,
2873 pCreateInfo->borderColor, "VUID-VkSamplerCreateInfo-addressModeU-01078");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002874 }
2875
2876 // If any of addressModeU, addressModeV or addressModeW are VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE, the
2877 // VK_KHR_sampler_mirror_clamp_to_edge extension must be enabled
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002878 if (!device_extensions.vk_khr_sampler_mirror_clamp_to_edge &&
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002879 ((pCreateInfo->addressModeU == VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE) ||
2880 (pCreateInfo->addressModeV == VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE) ||
2881 (pCreateInfo->addressModeW == VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE))) {
Dave Houlton413a6782018-05-22 13:01:54 -06002882 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002883 LogError(device, "VUID-VkSamplerCreateInfo-addressModeU-01079",
2884 "vkCreateSampler(): A VkSamplerAddressMode value is set to VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE "
2885 "but the VK_KHR_sampler_mirror_clamp_to_edge extension has not been enabled.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002886 }
John Zulauf275805c2017-10-26 15:34:49 -06002887
2888 // Checks for the IMG cubic filtering extension
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002889 if (device_extensions.vk_img_filter_cubic) {
John Zulauf275805c2017-10-26 15:34:49 -06002890 if ((pCreateInfo->anisotropyEnable == VK_TRUE) &&
2891 ((pCreateInfo->minFilter == VK_FILTER_CUBIC_IMG) || (pCreateInfo->magFilter == VK_FILTER_CUBIC_IMG))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002892 skip |= LogError(device, "VUID-VkSamplerCreateInfo-magFilter-01081",
2893 "vkCreateSampler(): Anisotropic sampling must not be VK_TRUE when either minFilter or magFilter "
2894 "are VK_FILTER_CUBIC_IMG.");
John Zulauf275805c2017-10-26 15:34:49 -06002895 }
2896 }
Mark Lobodzinski61992fc2020-01-14 14:00:08 -07002897
sfricke-samsungd91da4a2020-02-09 17:19:04 -08002898 // Check for valid Lod range
2899 if (pCreateInfo->minLod > pCreateInfo->maxLod) {
Mark Lobodzinski728ab482020-02-12 13:46:47 -07002900 skip |=
2901 LogError(device, "VUID-VkSamplerCreateInfo-maxLod-01973",
2902 "vkCreateSampler(): minLod (%f) is greater than maxLod (%f)", pCreateInfo->minLod, pCreateInfo->maxLod);
sfricke-samsungd91da4a2020-02-09 17:19:04 -08002903 }
2904
2905 // Check mipLodBias to device limit
2906 if (pCreateInfo->mipLodBias > limits.maxSamplerLodBias) {
Mark Lobodzinski728ab482020-02-12 13:46:47 -07002907 skip |= LogError(device, "VUID-VkSamplerCreateInfo-mipLodBias-01069",
2908 "vkCreateSampler(): mipLodBias (%f) is greater than VkPhysicalDeviceLimits::maxSamplerLodBias (%f)",
2909 pCreateInfo->mipLodBias, limits.maxSamplerLodBias);
sfricke-samsungd91da4a2020-02-09 17:19:04 -08002910 }
2911
Mark Lobodzinski61992fc2020-01-14 14:00:08 -07002912 const auto *sampler_conversion = lvl_find_in_chain<VkSamplerYcbcrConversionInfo>(pCreateInfo->pNext);
2913 if (sampler_conversion != nullptr) {
2914 if ((pCreateInfo->addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE) ||
2915 (pCreateInfo->addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE) ||
2916 (pCreateInfo->addressModeW != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE) ||
2917 (pCreateInfo->anisotropyEnable != VK_FALSE) || (pCreateInfo->unnormalizedCoordinates != VK_FALSE)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002918 skip |= LogError(
Mark Lobodzinski728ab482020-02-12 13:46:47 -07002919 device, "VUID-VkSamplerCreateInfo-addressModeU-01646",
Mark Lobodzinski61992fc2020-01-14 14:00:08 -07002920 "vkCreateSampler(): SamplerYCbCrConversion is enabled: "
2921 "addressModeU (%s), addressModeV (%s), addressModeW (%s) must be CLAMP_TO_EDGE, and anisotropyEnable (%s) "
2922 "and unnormalizedCoordinates (%s) must be VK_FALSE.",
2923 string_VkSamplerAddressMode(pCreateInfo->addressModeU), string_VkSamplerAddressMode(pCreateInfo->addressModeV),
2924 string_VkSamplerAddressMode(pCreateInfo->addressModeW), pCreateInfo->anisotropyEnable ? "VK_TRUE" : "VK_FALSE",
2925 pCreateInfo->unnormalizedCoordinates ? "VK_TRUE" : "VK_FALSE");
2926 }
2927 }
janharaldfredriksen-arm3b793772020-05-12 18:55:53 +02002928
2929 if (pCreateInfo->flags & VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT) {
2930 if (pCreateInfo->minFilter != pCreateInfo->magFilter) {
2931 skip |= LogError(device, "VUID-VkSamplerCreateInfo-flags-02574",
2932 "vkCreateSampler(): when flags includes VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT, "
2933 "pCreateInfo->minFilter (%s) and pCreateInfo->magFilter (%s) must be equal.",
2934 string_VkFilter(pCreateInfo->minFilter), string_VkFilter(pCreateInfo->magFilter));
2935 }
2936 if (pCreateInfo->mipmapMode != VK_SAMPLER_MIPMAP_MODE_NEAREST) {
2937 skip |= LogError(device, "VUID-VkSamplerCreateInfo-flags-02575",
2938 "vkCreateSampler(): when flags includes VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT, "
2939 "pCreateInfo->mipmapMode (%s) must be VK_SAMPLER_MIPMAP_MODE_NEAREST.",
2940 string_VkSamplerMipmapMode(pCreateInfo->mipmapMode));
2941 }
2942 if (pCreateInfo->minLod != 0.0 || pCreateInfo->maxLod != 0.0) {
2943 skip |= LogError(device, "VUID-VkSamplerCreateInfo-flags-02576",
2944 "vkCreateSampler(): when flags includes VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT, "
2945 "pCreateInfo->minLod (%f) and pCreateInfo->maxLod (%f) must be zero.",
2946 pCreateInfo->minLod, pCreateInfo->maxLod);
2947 }
2948 if (((pCreateInfo->addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE) &&
2949 (pCreateInfo->addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER)) ||
2950 ((pCreateInfo->addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE) &&
2951 (pCreateInfo->addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER))) {
2952 skip |= LogError(device, "VUID-VkSamplerCreateInfo-flags-02577",
2953 "vkCreateSampler(): when flags includes VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT, "
2954 "pCreateInfo->addressModeU (%s) and pCreateInfo->addressModeV (%s) must be "
2955 "VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE or VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER",
2956 string_VkSamplerAddressMode(pCreateInfo->addressModeU),
2957 string_VkSamplerAddressMode(pCreateInfo->addressModeV));
2958 }
2959 if (pCreateInfo->anisotropyEnable) {
2960 skip |= LogError(device, "VUID-VkSamplerCreateInfo-flags-02578",
2961 "vkCreateSampler(): when flags includes VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT, "
2962 "pCreateInfo->anisotropyEnable must be VK_FALSE");
2963 }
2964 if (pCreateInfo->compareEnable) {
2965 skip |= LogError(device, "VUID-VkSamplerCreateInfo-flags-02579",
2966 "vkCreateSampler(): when flags includes VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT, "
2967 "pCreateInfo->compareEnable must be VK_FALSE");
2968 }
2969 if (pCreateInfo->unnormalizedCoordinates) {
2970 skip |= LogError(device, "VUID-VkSamplerCreateInfo-flags-02580",
2971 "vkCreateSampler(): when flags includes VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT, "
2972 "pCreateInfo->unnormalizedCoordinates must be VK_FALSE");
2973 }
2974 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002975 }
2976
Tony-LunarG7337b312020-04-15 16:40:25 -06002977 if (pCreateInfo->borderColor == VK_BORDER_COLOR_INT_CUSTOM_EXT ||
2978 pCreateInfo->borderColor == VK_BORDER_COLOR_FLOAT_CUSTOM_EXT) {
2979 if (!device_extensions.vk_ext_custom_border_color) {
2980 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
2981 "VkSamplerCreateInfo->borderColor is %s but %s is not enabled.\n",
2982 string_VkBorderColor(pCreateInfo->borderColor), VK_EXT_CUSTOM_BORDER_COLOR_EXTENSION_NAME);
2983 }
2984 auto custom_create_info = lvl_find_in_chain<VkSamplerCustomBorderColorCreateInfoEXT>(pCreateInfo->pNext);
2985 if (!custom_create_info) {
2986 skip |=
2987 LogError(device, "VUID-VkSamplerCreateInfo-borderColor-04011",
2988 "VkSamplerCreateInfo->borderColor is set to %s but there is no VkSamplerCustomBorderColorCreateInfoEXT "
2989 "struct in pNext chain.\n",
2990 string_VkBorderColor(pCreateInfo->borderColor));
2991 } else {
2992 if ((custom_create_info->format != VK_FORMAT_UNDEFINED) &&
2993 ((pCreateInfo->borderColor == VK_BORDER_COLOR_INT_CUSTOM_EXT && !FormatIsSampledInt(custom_create_info->format)) ||
2994 (pCreateInfo->borderColor == VK_BORDER_COLOR_FLOAT_CUSTOM_EXT &&
2995 !FormatIsSampledFloat(custom_create_info->format)))) {
2996 skip |= LogError(device, "VUID-VkSamplerCustomBorderColorCreateInfoEXT-format-04013",
2997 "VkSamplerCreateInfo->borderColor is %s but VkSamplerCustomBorderColorCreateInfoEXT.format = %s "
2998 "whose type does not match\n",
2999 string_VkBorderColor(pCreateInfo->borderColor), string_VkFormat(custom_create_info->format));
3000 ;
3001 }
3002 }
3003 }
3004
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003005 return skip;
3006}
3007
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003008bool StatelessValidation::manual_PreCallValidateCreateDescriptorSetLayout(VkDevice device,
3009 const VkDescriptorSetLayoutCreateInfo *pCreateInfo,
3010 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003011 VkDescriptorSetLayout *pSetLayout) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003012 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003013
3014 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
3015 if ((pCreateInfo != nullptr) && (pCreateInfo->pBindings != nullptr)) {
3016 for (uint32_t i = 0; i < pCreateInfo->bindingCount; ++i) {
3017 if (pCreateInfo->pBindings[i].descriptorCount != 0) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003018 if (((pCreateInfo->pBindings[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLER) ||
3019 (pCreateInfo->pBindings[i].descriptorType == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER)) &&
3020 (pCreateInfo->pBindings[i].pImmutableSamplers != nullptr)) {
3021 for (uint32_t descriptor_index = 0; descriptor_index < pCreateInfo->pBindings[i].descriptorCount;
3022 ++descriptor_index) {
3023 if (pCreateInfo->pBindings[i].pImmutableSamplers[descriptor_index] == VK_NULL_HANDLE) {
Spencer Frickeb0e30822020-03-23 10:32:30 -07003024 skip |= LogError(device, "VUID-VkDescriptorSetLayoutBinding-descriptorType-00282",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003025 "vkCreateDescriptorSetLayout: required parameter "
3026 "pCreateInfo->pBindings[%d].pImmutableSamplers[%d] specified as VK_NULL_HANDLE",
3027 i, descriptor_index);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003028 }
3029 }
3030 }
3031
3032 // If descriptorCount is not 0, stageFlags must be a valid combination of VkShaderStageFlagBits values
3033 if ((pCreateInfo->pBindings[i].stageFlags != 0) &&
3034 ((pCreateInfo->pBindings[i].stageFlags & (~AllVkShaderStageFlagBits)) != 0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003035 skip |= LogError(device, "VUID-VkDescriptorSetLayoutBinding-descriptorCount-00283",
3036 "vkCreateDescriptorSetLayout(): if pCreateInfo->pBindings[%d].descriptorCount is not 0, "
3037 "pCreateInfo->pBindings[%d].stageFlags must be a valid combination of VkShaderStageFlagBits "
3038 "values.",
3039 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003040 }
Spencer Fricke84d0cc02020-03-16 17:21:59 -07003041
3042 if ((pCreateInfo->pBindings[i].descriptorType == VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT) &&
3043 (pCreateInfo->pBindings[i].stageFlags != 0) &&
3044 (pCreateInfo->pBindings[i].stageFlags != VK_SHADER_STAGE_FRAGMENT_BIT)) {
3045 skip |=
3046 LogError(device, "VUID-VkDescriptorSetLayoutBinding-descriptorType-01510",
3047 "vkCreateDescriptorSetLayout(): if pCreateInfo->pBindings[%d].descriptorCount is not 0 and "
3048 "descriptorType is VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT then pCreateInfo->pBindings[%d].stageFlags "
3049 "must be 0 or VK_SHADER_STAGE_FRAGMENT_BIT but is currently %s",
3050 i, i, string_VkShaderStageFlags(pCreateInfo->pBindings[i].stageFlags).c_str());
3051 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003052 }
3053 }
3054 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003055 return skip;
3056}
3057
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003058bool StatelessValidation::manual_PreCallValidateFreeDescriptorSets(VkDevice device, VkDescriptorPool descriptorPool,
3059 uint32_t descriptorSetCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003060 const VkDescriptorSet *pDescriptorSets) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003061 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
3062 // This is an array of handles, where the elements are allowed to be VK_NULL_HANDLE, and does not require any validation beyond
3063 // validate_array()
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003064 return validate_array("vkFreeDescriptorSets", "descriptorSetCount", "pDescriptorSets", descriptorSetCount, &pDescriptorSets,
3065 true, true, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003066}
3067
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07003068bool StatelessValidation::validate_WriteDescriptorSet(const char *vkCallingFunction, const uint32_t descriptorWriteCount,
3069 const VkWriteDescriptorSet *pDescriptorWrites,
3070 const bool validateDstSet) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003071 bool skip = false;
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07003072
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003073 if (pDescriptorWrites != NULL) {
3074 for (uint32_t i = 0; i < descriptorWriteCount; ++i) {
3075 // descriptorCount must be greater than 0
3076 if (pDescriptorWrites[i].descriptorCount == 0) {
3077 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003078 LogError(device, "VUID-VkWriteDescriptorSet-descriptorCount-arraylength",
3079 "%s(): parameter pDescriptorWrites[%d].descriptorCount must be greater than 0.", vkCallingFunction, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003080 }
3081
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07003082 // If called from vkCmdPushDescriptorSetKHR, the dstSet member is ignored.
3083 if (validateDstSet) {
3084 // dstSet must be a valid VkDescriptorSet handle
3085 skip |= validate_required_handle(vkCallingFunction,
3086 ParameterName("pDescriptorWrites[%i].dstSet", ParameterName::IndexVector{i}),
3087 pDescriptorWrites[i].dstSet);
3088 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003089
3090 if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLER) ||
3091 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER) ||
3092 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE) ||
3093 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_IMAGE) ||
3094 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT)) {
3095 // If descriptorType is VK_DESCRIPTOR_TYPE_SAMPLER, VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER,
3096 // VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE, VK_DESCRIPTOR_TYPE_STORAGE_IMAGE or VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT,
Jeff Bolz165818a2020-05-08 11:19:03 -05003097 // pImageInfo must be a pointer to an array of descriptorCount valid VkDescriptorImageInfo structures.
3098 // Valid imageView handles are checked in ObjectLifetimes::ValidateDescriptorWrite.
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003099 if (pDescriptorWrites[i].pImageInfo == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003100 skip |= LogError(device, "VUID-VkWriteDescriptorSet-descriptorType-00322",
3101 "%s(): if pDescriptorWrites[%d].descriptorType is "
3102 "VK_DESCRIPTOR_TYPE_SAMPLER, VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER, "
3103 "VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE, VK_DESCRIPTOR_TYPE_STORAGE_IMAGE or "
3104 "VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT, pDescriptorWrites[%d].pImageInfo must not be NULL.",
3105 vkCallingFunction, i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003106 } else if (pDescriptorWrites[i].descriptorType != VK_DESCRIPTOR_TYPE_SAMPLER) {
3107 // If descriptorType is VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER, VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE,
Jeff Bolz165818a2020-05-08 11:19:03 -05003108 // VK_DESCRIPTOR_TYPE_STORAGE_IMAGE or VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT, the imageLayout
3109 // member of any given element of pImageInfo must be a valid VkImageLayout
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003110 for (uint32_t descriptor_index = 0; descriptor_index < pDescriptorWrites[i].descriptorCount;
3111 ++descriptor_index) {
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07003112 skip |= validate_ranged_enum(vkCallingFunction,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003113 ParameterName("pDescriptorWrites[%i].pImageInfo[%i].imageLayout",
3114 ParameterName::IndexVector{i, descriptor_index}),
3115 "VkImageLayout", AllVkImageLayoutEnums,
Dave Houlton413a6782018-05-22 13:01:54 -06003116 pDescriptorWrites[i].pImageInfo[descriptor_index].imageLayout, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003117 }
3118 }
3119 } else if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER) ||
3120 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER) ||
3121 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC) ||
3122 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC)) {
3123 // If descriptorType is VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER, VK_DESCRIPTOR_TYPE_STORAGE_BUFFER,
3124 // VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC or VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC, pBufferInfo must be a
3125 // pointer to an array of descriptorCount valid VkDescriptorBufferInfo structures
Jeff Bolz165818a2020-05-08 11:19:03 -05003126 // Valid buffer handles are checked in ObjectLifetimes::ValidateDescriptorWrite.
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003127 if (pDescriptorWrites[i].pBufferInfo == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003128 skip |= LogError(device, "VUID-VkWriteDescriptorSet-descriptorType-00324",
3129 "%s(): if pDescriptorWrites[%d].descriptorType is "
3130 "VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER, VK_DESCRIPTOR_TYPE_STORAGE_BUFFER, "
3131 "VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC or VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC, "
3132 "pDescriptorWrites[%d].pBufferInfo must not be NULL.",
3133 vkCallingFunction, i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003134 } else {
Jeff Bolz165818a2020-05-08 11:19:03 -05003135 const auto *robustness2_features =
3136 lvl_find_in_chain<VkPhysicalDeviceRobustness2FeaturesEXT>(device_createinfo_pnext);
3137 if (robustness2_features && robustness2_features->nullDescriptor) {
3138 for (uint32_t descriptorIndex = 0; descriptorIndex < pDescriptorWrites[i].descriptorCount;
3139 ++descriptorIndex) {
3140 if (pDescriptorWrites[i].pBufferInfo[descriptorIndex].buffer == VK_NULL_HANDLE &&
3141 (pDescriptorWrites[i].pBufferInfo[descriptorIndex].offset != 0 ||
3142 pDescriptorWrites[i].pBufferInfo[descriptorIndex].range != VK_WHOLE_SIZE)) {
3143 skip |= LogError(device, "VUID-VkDescriptorBufferInfo-buffer-02999",
3144 "%s(): if pDescriptorWrites[%d].buffer is VK_NULL_HANDLE, "
baldurk751594b2020-09-09 09:41:02 +01003145 "offset (%" PRIu64 ") must be zero and range (%" PRIu64 ") must be VK_WHOLE_SIZE.",
Jeff Bolz165818a2020-05-08 11:19:03 -05003146 vkCallingFunction, i, pDescriptorWrites[i].pBufferInfo[descriptorIndex].offset,
3147 pDescriptorWrites[i].pBufferInfo[descriptorIndex].range);
3148 }
3149 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003150 }
3151 }
3152 } else if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER) ||
3153 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER)) {
Jeff Bolz165818a2020-05-08 11:19:03 -05003154 // Valid bufferView handles are checked in ObjectLifetimes::ValidateDescriptorWrite.
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003155 }
3156
3157 if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER) ||
3158 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC)) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003159 VkDeviceSize uniformAlignment = device_limits.minUniformBufferOffsetAlignment;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003160 for (uint32_t j = 0; j < pDescriptorWrites[i].descriptorCount; j++) {
3161 if (pDescriptorWrites[i].pBufferInfo != NULL) {
3162 if (SafeModulo(pDescriptorWrites[i].pBufferInfo[j].offset, uniformAlignment) != 0) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06003163 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003164 LogError(device, "VUID-VkWriteDescriptorSet-descriptorType-00327",
3165 "%s(): pDescriptorWrites[%d].pBufferInfo[%d].offset (0x%" PRIxLEAST64
3166 ") must be a multiple of device limit minUniformBufferOffsetAlignment 0x%" PRIxLEAST64 ".",
3167 vkCallingFunction, i, j, pDescriptorWrites[i].pBufferInfo[j].offset, uniformAlignment);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003168 }
3169 }
3170 }
3171 } else if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER) ||
3172 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC)) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003173 VkDeviceSize storageAlignment = device_limits.minStorageBufferOffsetAlignment;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003174 for (uint32_t j = 0; j < pDescriptorWrites[i].descriptorCount; j++) {
3175 if (pDescriptorWrites[i].pBufferInfo != NULL) {
3176 if (SafeModulo(pDescriptorWrites[i].pBufferInfo[j].offset, storageAlignment) != 0) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06003177 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003178 LogError(device, "VUID-VkWriteDescriptorSet-descriptorType-00328",
3179 "%s(): pDescriptorWrites[%d].pBufferInfo[%d].offset (0x%" PRIxLEAST64
3180 ") must be a multiple of device limit minStorageBufferOffsetAlignment 0x%" PRIxLEAST64 ".",
3181 vkCallingFunction, i, j, pDescriptorWrites[i].pBufferInfo[j].offset, storageAlignment);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003182 }
3183 }
3184 }
3185 }
sourav parmara96ab1a2020-04-25 16:28:23 -07003186 // pNext chain must be either NULL or a pointer to a valid instance of VkWriteDescriptorSetAccelerationStructureKHR
3187 // or VkWriteDescriptorSetInlineUniformBlockEX
3188 if (pDescriptorWrites[i].pNext) {
3189 if (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_ACCELERATION_STRUCTURE_KHR) {
Mark Lobodzinski17dc4602020-05-29 07:48:40 -06003190 const auto *pnext_struct =
sourav parmara96ab1a2020-04-25 16:28:23 -07003191 lvl_find_in_chain<VkWriteDescriptorSetAccelerationStructureKHR>(pDescriptorWrites[i].pNext);
Mark Lobodzinski17dc4602020-05-29 07:48:40 -06003192 if (!pnext_struct || (pnext_struct->accelerationStructureCount != pDescriptorWrites[i].descriptorCount)) {
sourav parmara96ab1a2020-04-25 16:28:23 -07003193 skip |= LogError(device, "VUID-VkWriteDescriptorSet-descriptorType-02382",
3194 "%s(): If descriptorType is VK_DESCRIPTOR_TYPE_ACCELERATION_STRUCTURE_KHR, the pNext"
3195 "chain must include a VkWriteDescriptorSetAccelerationStructureKHR structure whose "
3196 "accelerationStructureCount %d member equals descriptorCount %d.",
Mark Lobodzinski17dc4602020-05-29 07:48:40 -06003197 vkCallingFunction, pnext_struct ? pnext_struct->accelerationStructureCount : -1,
sourav parmara96ab1a2020-04-25 16:28:23 -07003198 pDescriptorWrites[i].descriptorCount);
3199 }
3200 // further checks only if we have right structtype
Mark Lobodzinski17dc4602020-05-29 07:48:40 -06003201 if (pnext_struct) {
3202 if (pnext_struct->accelerationStructureCount != pDescriptorWrites[i].descriptorCount) {
sourav parmara96ab1a2020-04-25 16:28:23 -07003203 skip |= LogError(
3204 device, "VUID-VkWriteDescriptorSetAccelerationStructureKHR-accelerationStructureCount-02236",
3205 "%s(): accelerationStructureCount %d must be equal to descriptorCount %d in the extended structure "
3206 ".",
Mark Lobodzinski17dc4602020-05-29 07:48:40 -06003207 vkCallingFunction, pnext_struct->accelerationStructureCount, pDescriptorWrites[i].descriptorCount);
sourav parmara96ab1a2020-04-25 16:28:23 -07003208 }
Mark Lobodzinski17dc4602020-05-29 07:48:40 -06003209 if (pnext_struct->accelerationStructureCount == 0) {
sourav parmara96ab1a2020-04-25 16:28:23 -07003210 skip |= LogError(
3211 device, "VUID-VkWriteDescriptorSetAccelerationStructureKHR-accelerationStructureCount-arraylength",
3212 "%s(): accelerationStructureCount must be greater than 0 .");
3213 }
3214 }
3215 }
3216 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003217 }
3218 }
3219 return skip;
3220}
3221
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07003222bool StatelessValidation::manual_PreCallValidateUpdateDescriptorSets(VkDevice device, uint32_t descriptorWriteCount,
3223 const VkWriteDescriptorSet *pDescriptorWrites,
3224 uint32_t descriptorCopyCount,
3225 const VkCopyDescriptorSet *pDescriptorCopies) const {
3226 return validate_WriteDescriptorSet("vkUpdateDescriptorSets", descriptorWriteCount, pDescriptorWrites);
3227}
3228
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003229bool StatelessValidation::manual_PreCallValidateCreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo,
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003230 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003231 VkRenderPass *pRenderPass) const {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003232 return CreateRenderPassGeneric(device, pCreateInfo, pAllocator, pRenderPass, RENDER_PASS_VERSION_1);
3233}
3234
sfricke-samsung681ab7b2020-10-29 01:53:35 -07003235bool StatelessValidation::manual_PreCallValidateCreateRenderPass2(VkDevice device, const VkRenderPassCreateInfo2 *pCreateInfo,
3236 const VkAllocationCallbacks *pAllocator,
3237 VkRenderPass *pRenderPass) const {
3238 return CreateRenderPassGeneric(device, pCreateInfo, pAllocator, pRenderPass, RENDER_PASS_VERSION_2);
3239}
3240
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003241bool StatelessValidation::manual_PreCallValidateCreateRenderPass2KHR(VkDevice device, const VkRenderPassCreateInfo2KHR *pCreateInfo,
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003242 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003243 VkRenderPass *pRenderPass) const {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003244 return CreateRenderPassGeneric(device, pCreateInfo, pAllocator, pRenderPass, RENDER_PASS_VERSION_2);
3245}
3246
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003247bool StatelessValidation::manual_PreCallValidateFreeCommandBuffers(VkDevice device, VkCommandPool commandPool,
3248 uint32_t commandBufferCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003249 const VkCommandBuffer *pCommandBuffers) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003250 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003251
3252 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
3253 // This is an array of handles, where the elements are allowed to be VK_NULL_HANDLE, and does not require any validation beyond
3254 // validate_array()
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003255 skip |= validate_array("vkFreeCommandBuffers", "commandBufferCount", "pCommandBuffers", commandBufferCount, &pCommandBuffers,
3256 true, true, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003257 return skip;
3258}
3259
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003260bool StatelessValidation::manual_PreCallValidateBeginCommandBuffer(VkCommandBuffer commandBuffer,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003261 const VkCommandBufferBeginInfo *pBeginInfo) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003262 bool skip = false;
Petr Krause7bb9e82019-08-11 21:34:43 +02003263
3264 // VkCommandBufferInheritanceInfo validation, due to a 'noautovalidity' of pBeginInfo->pInheritanceInfo in vkBeginCommandBuffer
3265 const char *cmd_name = "vkBeginCommandBuffer";
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003266 const VkCommandBufferInheritanceInfo *pInfo = pBeginInfo->pInheritanceInfo;
3267
Petr Krause7bb9e82019-08-11 21:34:43 +02003268 // Implicit VUs
3269 // validate only sType here; pointer has to be validated in core_validation
3270 const bool kNotRequired = false;
3271 const char *kNoVUID = nullptr;
3272 skip |= validate_struct_type(cmd_name, "pBeginInfo->pInheritanceInfo", "VK_STRUCTURE_TYPE_COMMAND_BUFFER_INHERITANCE_INFO",
3273 pInfo, VK_STRUCTURE_TYPE_COMMAND_BUFFER_INHERITANCE_INFO, kNotRequired, kNoVUID,
3274 "VUID-VkCommandBufferInheritanceInfo-sType-sType");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003275
Petr Krause7bb9e82019-08-11 21:34:43 +02003276 if (pInfo) {
3277 const VkStructureType allowed_structs_VkCommandBufferInheritanceInfo[] = {
3278 VK_STRUCTURE_TYPE_COMMAND_BUFFER_INHERITANCE_CONDITIONAL_RENDERING_INFO_EXT};
3279 skip |= validate_struct_pnext(
3280 cmd_name, "pBeginInfo->pInheritanceInfo->pNext", "VkCommandBufferInheritanceConditionalRenderingInfoEXT", pInfo->pNext,
3281 ARRAY_SIZE(allowed_structs_VkCommandBufferInheritanceInfo), allowed_structs_VkCommandBufferInheritanceInfo,
sfricke-samsung32a27362020-02-28 09:06:42 -08003282 GeneratedVulkanHeaderVersion, "VUID-VkCommandBufferInheritanceInfo-pNext-pNext",
3283 "VUID-VkCommandBufferInheritanceInfo-sType-unique");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003284
Petr Krause7bb9e82019-08-11 21:34:43 +02003285 skip |= validate_bool32(cmd_name, "pBeginInfo->pInheritanceInfo->occlusionQueryEnable", pInfo->occlusionQueryEnable);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003286
Petr Krause7bb9e82019-08-11 21:34:43 +02003287 // Explicit VUs
3288 if (!physical_device_features.inheritedQueries && pInfo->occlusionQueryEnable == VK_TRUE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003289 skip |= LogError(
3290 commandBuffer, "VUID-VkCommandBufferInheritanceInfo-occlusionQueryEnable-00056",
Petr Krause7bb9e82019-08-11 21:34:43 +02003291 "%s: Inherited queries feature is disabled, but pBeginInfo->pInheritanceInfo->occlusionQueryEnable is VK_TRUE.",
3292 cmd_name);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003293 }
Petr Krause7bb9e82019-08-11 21:34:43 +02003294
3295 if (physical_device_features.inheritedQueries) {
3296 skip |= validate_flags(cmd_name, "pBeginInfo->pInheritanceInfo->queryFlags", "VkQueryControlFlagBits",
Petr Kraus52758be2019-08-12 00:53:58 +02003297 AllVkQueryControlFlagBits, pInfo->queryFlags, kOptionalFlags,
Dave Houlton413a6782018-05-22 13:01:54 -06003298 "VUID-VkCommandBufferInheritanceInfo-queryFlags-00057");
Petr Krause7bb9e82019-08-11 21:34:43 +02003299 } else { // !inheritedQueries
Petr Krause7bb9e82019-08-11 21:34:43 +02003300 skip |= validate_reserved_flags(cmd_name, "pBeginInfo->pInheritanceInfo->queryFlags", pInfo->queryFlags,
Petr Kraus43aed2c2019-08-18 13:59:16 +02003301 "VUID-VkCommandBufferInheritanceInfo-queryFlags-02788");
Petr Krause7bb9e82019-08-11 21:34:43 +02003302 }
3303
3304 if (physical_device_features.pipelineStatisticsQuery) {
Petr Krause7bb9e82019-08-11 21:34:43 +02003305 skip |= validate_flags(cmd_name, "pBeginInfo->pInheritanceInfo->pipelineStatistics", "VkQueryPipelineStatisticFlagBits",
Petr Kraus52758be2019-08-12 00:53:58 +02003306 AllVkQueryPipelineStatisticFlagBits, pInfo->pipelineStatistics, kOptionalFlags,
Petr Kraus43aed2c2019-08-18 13:59:16 +02003307 "VUID-VkCommandBufferInheritanceInfo-pipelineStatistics-02789");
Petr Krause7bb9e82019-08-11 21:34:43 +02003308 } else { // !pipelineStatisticsQuery
3309 skip |= validate_reserved_flags(cmd_name, "pBeginInfo->pInheritanceInfo->pipelineStatistics", pInfo->pipelineStatistics,
3310 "VUID-VkCommandBufferInheritanceInfo-pipelineStatistics-00058");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003311 }
Petr Kraus139757b2019-08-15 17:19:33 +02003312
3313 const auto *conditional_rendering = lvl_find_in_chain<VkCommandBufferInheritanceConditionalRenderingInfoEXT>(pInfo->pNext);
3314 if (conditional_rendering) {
Tony-LunarG6c3c5452019-12-13 10:37:38 -07003315 const auto *cr_features = lvl_find_in_chain<VkPhysicalDeviceConditionalRenderingFeaturesEXT>(device_createinfo_pnext);
Petr Kraus139757b2019-08-15 17:19:33 +02003316 const auto inherited_conditional_rendering = cr_features && cr_features->inheritedConditionalRendering;
3317 if (!inherited_conditional_rendering && conditional_rendering->conditionalRenderingEnable == VK_TRUE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003318 skip |= LogError(
3319 commandBuffer, "VUID-VkCommandBufferInheritanceConditionalRenderingInfoEXT-conditionalRenderingEnable-01977",
Petr Kraus139757b2019-08-15 17:19:33 +02003320 "vkBeginCommandBuffer: Inherited conditional rendering is disabled, but "
3321 "pBeginInfo->pInheritanceInfo->pNext<VkCommandBufferInheritanceConditionalRenderingInfoEXT> is VK_TRUE.");
3322 }
3323 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003324 }
3325
3326 return skip;
3327}
3328
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003329bool StatelessValidation::manual_PreCallValidateCmdSetViewport(VkCommandBuffer commandBuffer, uint32_t firstViewport,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003330 uint32_t viewportCount, const VkViewport *pViewports) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003331 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003332
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003333 if (!physical_device_features.multiViewport) {
Petr Krausd55e77c2018-01-09 22:09:25 +01003334 if (firstViewport != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003335 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewport-firstViewport-01224",
3336 "vkCmdSetViewport: The multiViewport feature is disabled, but firstViewport (=%" PRIu32 ") is not 0.",
3337 firstViewport);
Petr Krausd55e77c2018-01-09 22:09:25 +01003338 }
3339 if (viewportCount > 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003340 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewport-viewportCount-01225",
3341 "vkCmdSetViewport: The multiViewport feature is disabled, but viewportCount (=%" PRIu32 ") is not 1.",
3342 viewportCount);
Petr Krausd55e77c2018-01-09 22:09:25 +01003343 }
3344 } else { // multiViewport enabled
Petr Kraus7dfeed12018-02-27 20:51:20 +01003345 const uint64_t sum = static_cast<uint64_t>(firstViewport) + static_cast<uint64_t>(viewportCount);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003346 if (sum > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003347 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewport-firstViewport-01223",
3348 "vkCmdSetViewport: firstViewport + viewportCount (=%" PRIu32 " + %" PRIu32 " = %" PRIu64
3349 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
3350 firstViewport, viewportCount, sum, device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003351 }
3352 }
Petr Krausb3fcdb42018-01-09 22:09:09 +01003353
3354 if (pViewports) {
3355 for (uint32_t viewport_i = 0; viewport_i < viewportCount; ++viewport_i) {
3356 const auto &viewport = pViewports[viewport_i]; // will crash on invalid ptr
Jeff Bolz6d3beaa2019-02-09 21:00:05 -06003357 const char *fn_name = "vkCmdSetViewport";
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003358 skip |= manual_PreCallValidateViewport(
3359 viewport, fn_name, ParameterName("pViewports[%i]", ParameterName::IndexVector{viewport_i}), commandBuffer);
Petr Krausb3fcdb42018-01-09 22:09:09 +01003360 }
3361 }
3362
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003363 return skip;
3364}
3365
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003366bool StatelessValidation::manual_PreCallValidateCmdSetScissor(VkCommandBuffer commandBuffer, uint32_t firstScissor,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003367 uint32_t scissorCount, const VkRect2D *pScissors) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003368 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003369
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003370 if (!physical_device_features.multiViewport) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003371 if (firstScissor != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003372 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-firstScissor-00593",
3373 "vkCmdSetScissor: The multiViewport feature is disabled, but firstScissor (=%" PRIu32 ") is not 0.",
3374 firstScissor);
Petr Kraus6260f0a2018-02-27 21:15:55 +01003375 }
3376 if (scissorCount > 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003377 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-scissorCount-00594",
3378 "vkCmdSetScissor: The multiViewport feature is disabled, but scissorCount (=%" PRIu32 ") is not 1.",
3379 scissorCount);
Petr Kraus6260f0a2018-02-27 21:15:55 +01003380 }
3381 } else { // multiViewport enabled
3382 const uint64_t sum = static_cast<uint64_t>(firstScissor) + static_cast<uint64_t>(scissorCount);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003383 if (sum > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003384 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-firstScissor-00592",
3385 "vkCmdSetScissor: firstScissor + scissorCount (=%" PRIu32 " + %" PRIu32 " = %" PRIu64
3386 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
3387 firstScissor, scissorCount, sum, device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003388 }
3389 }
3390
Petr Kraus6260f0a2018-02-27 21:15:55 +01003391 if (pScissors) {
3392 for (uint32_t scissor_i = 0; scissor_i < scissorCount; ++scissor_i) {
3393 const auto &scissor = pScissors[scissor_i]; // will crash on invalid ptr
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003394
Petr Kraus6260f0a2018-02-27 21:15:55 +01003395 if (scissor.offset.x < 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003396 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-x-00595",
3397 "vkCmdSetScissor: pScissors[%" PRIu32 "].offset.x (=%" PRIi32 ") is negative.", scissor_i,
3398 scissor.offset.x);
Petr Kraus6260f0a2018-02-27 21:15:55 +01003399 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003400
Petr Kraus6260f0a2018-02-27 21:15:55 +01003401 if (scissor.offset.y < 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003402 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-x-00595",
3403 "vkCmdSetScissor: pScissors[%" PRIu32 "].offset.y (=%" PRIi32 ") is negative.", scissor_i,
3404 scissor.offset.y);
Petr Kraus6260f0a2018-02-27 21:15:55 +01003405 }
3406
3407 const int64_t x_sum = static_cast<int64_t>(scissor.offset.x) + static_cast<int64_t>(scissor.extent.width);
3408 if (x_sum > INT32_MAX) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003409 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-offset-00596",
3410 "vkCmdSetScissor: offset.x + extent.width (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
3411 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
3412 scissor.offset.x, scissor.extent.width, x_sum, scissor_i);
Petr Kraus6260f0a2018-02-27 21:15:55 +01003413 }
3414
3415 const int64_t y_sum = static_cast<int64_t>(scissor.offset.y) + static_cast<int64_t>(scissor.extent.height);
3416 if (y_sum > INT32_MAX) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003417 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-offset-00597",
3418 "vkCmdSetScissor: offset.y + extent.height (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
3419 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
3420 scissor.offset.y, scissor.extent.height, y_sum, scissor_i);
Petr Kraus6260f0a2018-02-27 21:15:55 +01003421 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003422 }
3423 }
Petr Kraus6260f0a2018-02-27 21:15:55 +01003424
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003425 return skip;
3426}
3427
Jeff Bolz5c801d12019-10-09 10:38:45 -05003428bool StatelessValidation::manual_PreCallValidateCmdSetLineWidth(VkCommandBuffer commandBuffer, float lineWidth) const {
Petr Kraus299ba622017-11-24 03:09:03 +01003429 bool skip = false;
Petr Kraus299ba622017-11-24 03:09:03 +01003430
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003431 if (!physical_device_features.wideLines && (lineWidth != 1.0f)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003432 skip |= LogError(commandBuffer, "VUID-vkCmdSetLineWidth-lineWidth-00788",
3433 "VkPhysicalDeviceFeatures::wideLines is disabled, but lineWidth (=%f) is not 1.0.", lineWidth);
Petr Kraus299ba622017-11-24 03:09:03 +01003434 }
3435
3436 return skip;
3437}
3438
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003439bool StatelessValidation::manual_PreCallValidateCmdDrawIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003440 uint32_t count, uint32_t stride) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003441 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003442
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003443 if (!physical_device_features.multiDrawIndirect && ((count > 1))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003444 skip |= LogError(device, kVUID_PVError_DeviceFeature,
3445 "CmdDrawIndirect(): Device feature multiDrawIndirect disabled: count must be 0 or 1 but is %d", count);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003446 }
3447 return skip;
3448}
3449
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003450bool StatelessValidation::manual_PreCallValidateCmdDrawIndexedIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003451 VkDeviceSize offset, uint32_t count, uint32_t stride) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003452 bool skip = false;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003453 if (!physical_device_features.multiDrawIndirect && ((count > 1))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003454 skip |=
3455 LogError(device, kVUID_PVError_DeviceFeature,
3456 "CmdDrawIndexedIndirect(): Device feature multiDrawIndirect disabled: count must be 0 or 1 but is %d", count);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003457 }
3458 return skip;
3459}
3460
sfricke-samsungf692b972020-05-02 08:00:45 -07003461bool StatelessValidation::ValidateCmdDrawIndirectCount(VkCommandBuffer commandBuffer, VkDeviceSize offset,
3462 VkDeviceSize countBufferOffset, bool khr) const {
3463 bool skip = false;
3464 const char *apiName = khr ? "vkCmdDrawIndirectCountKHR()" : "vkCmdDrawIndirectCount()";
3465 if (offset & 3) {
3466 skip |= LogError(commandBuffer, "VUID-vkCmdDrawIndirectCount-offset-02710",
3467 "%s: parameter, VkDeviceSize offset (0x%" PRIxLEAST64 "), is not a multiple of 4.", apiName, offset);
3468 }
3469
3470 if (countBufferOffset & 3) {
3471 skip |= LogError(commandBuffer, "VUID-vkCmdDrawIndirectCount-countBufferOffset-02716",
3472 "%s: parameter, VkDeviceSize countBufferOffset (0x%" PRIxLEAST64 "), is not a multiple of 4.", apiName,
3473 countBufferOffset);
3474 }
3475 return skip;
3476}
3477
3478bool StatelessValidation::manual_PreCallValidateCmdDrawIndirectCount(VkCommandBuffer commandBuffer, VkBuffer buffer,
3479 VkDeviceSize offset, VkBuffer countBuffer,
3480 VkDeviceSize countBufferOffset, uint32_t maxDrawCount,
3481 uint32_t stride) const {
3482 return ValidateCmdDrawIndirectCount(commandBuffer, offset, countBufferOffset, false);
3483}
3484
3485bool StatelessValidation::manual_PreCallValidateCmdDrawIndirectCountKHR(VkCommandBuffer commandBuffer, VkBuffer buffer,
3486 VkDeviceSize offset, VkBuffer countBuffer,
3487 VkDeviceSize countBufferOffset, uint32_t maxDrawCount,
3488 uint32_t stride) const {
3489 return ValidateCmdDrawIndirectCount(commandBuffer, offset, countBufferOffset, true);
3490}
3491
3492bool StatelessValidation::ValidateCmdDrawIndexedIndirectCount(VkCommandBuffer commandBuffer, VkDeviceSize offset,
3493 VkDeviceSize countBufferOffset, bool khr) const {
3494 bool skip = false;
3495 const char *apiName = khr ? "vkCmdDrawIndexedIndirectCountKHR()" : "vkCmdDrawIndexedIndirectCount()";
3496 if (offset & 3) {
3497 skip |= LogError(commandBuffer, "VUID-vkCmdDrawIndexedIndirectCount-offset-02710",
3498 "%s: parameter, VkDeviceSize offset (0x%" PRIxLEAST64 "), is not a multiple of 4.", apiName, offset);
3499 }
3500
3501 if (countBufferOffset & 3) {
3502 skip |= LogError(commandBuffer, "VUID-vkCmdDrawIndexedIndirectCount-countBufferOffset-02716",
3503 "%s: parameter, VkDeviceSize countBufferOffset (0x%" PRIxLEAST64 "), is not a multiple of 4.", apiName,
3504 countBufferOffset);
3505 }
3506 return skip;
3507}
3508
3509bool StatelessValidation::manual_PreCallValidateCmdDrawIndexedIndirectCount(VkCommandBuffer commandBuffer, VkBuffer buffer,
3510 VkDeviceSize offset, VkBuffer countBuffer,
3511 VkDeviceSize countBufferOffset, uint32_t maxDrawCount,
3512 uint32_t stride) const {
3513 return ValidateCmdDrawIndexedIndirectCount(commandBuffer, offset, countBufferOffset, false);
3514}
3515
3516bool StatelessValidation::manual_PreCallValidateCmdDrawIndexedIndirectCountKHR(VkCommandBuffer commandBuffer, VkBuffer buffer,
3517 VkDeviceSize offset, VkBuffer countBuffer,
3518 VkDeviceSize countBufferOffset,
3519 uint32_t maxDrawCount, uint32_t stride) const {
3520 return ValidateCmdDrawIndexedIndirectCount(commandBuffer, offset, countBufferOffset, true);
3521}
3522
Mark Lobodzinskif77a4ac2019-06-27 15:30:51 -06003523bool StatelessValidation::manual_PreCallValidateCmdClearAttachments(VkCommandBuffer commandBuffer, uint32_t attachmentCount,
3524 const VkClearAttachment *pAttachments, uint32_t rectCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003525 const VkClearRect *pRects) const {
Mark Lobodzinskif77a4ac2019-06-27 15:30:51 -06003526 bool skip = false;
3527 for (uint32_t rect = 0; rect < rectCount; rect++) {
3528 if (pRects[rect].layerCount == 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003529 skip |= LogError(commandBuffer, "VUID-vkCmdClearAttachments-layerCount-01934",
3530 "CmdClearAttachments(): pRects[%d].layerCount is zero.", rect);
Mark Lobodzinskif77a4ac2019-06-27 15:30:51 -06003531 }
sfricke-samsung10867682020-04-25 02:20:39 -07003532 if (pRects[rect].rect.extent.width == 0) {
3533 skip |= LogError(commandBuffer, "VUID-vkCmdClearAttachments-rect-02682",
3534 "CmdClearAttachments(): pRects[%d].rect.extent.width is zero.", rect);
3535 }
3536 if (pRects[rect].rect.extent.height == 0) {
3537 skip |= LogError(commandBuffer, "VUID-vkCmdClearAttachments-rect-02683",
3538 "CmdClearAttachments(): pRects[%d].rect.extent.height is zero.", rect);
3539 }
Mark Lobodzinskif77a4ac2019-06-27 15:30:51 -06003540 }
3541 return skip;
3542}
3543
Andrew Fobel3abeb992020-01-20 16:33:22 -05003544bool StatelessValidation::ValidateGetPhysicalDeviceImageFormatProperties2(VkPhysicalDevice physicalDevice,
3545 const VkPhysicalDeviceImageFormatInfo2 *pImageFormatInfo,
3546 VkImageFormatProperties2 *pImageFormatProperties,
3547 const char *apiName) const {
3548 bool skip = false;
3549
3550 if (pImageFormatInfo != nullptr) {
3551 const auto image_stencil_struct = lvl_find_in_chain<VkImageStencilUsageCreateInfoEXT>(pImageFormatInfo->pNext);
3552 if (image_stencil_struct != nullptr) {
3553 if ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT) != 0) {
3554 VkImageUsageFlags legal_flags = (VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT | VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT);
3555 // No flags other than the legal attachment bits may be set
3556 legal_flags |= VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT;
3557 if ((image_stencil_struct->stencilUsage & ~legal_flags) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003558 skip |= LogError(physicalDevice, "VUID-VkImageStencilUsageCreateInfo-stencilUsage-02539",
3559 "%s(): in pNext chain, VkImageStencilUsageCreateInfo::stencilUsage "
3560 "includes VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT, it must not include bits other than "
3561 "VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT or VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT",
3562 apiName);
Andrew Fobel3abeb992020-01-20 16:33:22 -05003563 }
3564 }
3565 }
3566 }
3567
3568 return skip;
3569}
3570
3571bool StatelessValidation::manual_PreCallValidateGetPhysicalDeviceImageFormatProperties2(
3572 VkPhysicalDevice physicalDevice, const VkPhysicalDeviceImageFormatInfo2 *pImageFormatInfo,
3573 VkImageFormatProperties2 *pImageFormatProperties) const {
3574 return ValidateGetPhysicalDeviceImageFormatProperties2(physicalDevice, pImageFormatInfo, pImageFormatProperties,
3575 "vkGetPhysicalDeviceImageFormatProperties2");
3576}
3577
3578bool StatelessValidation::manual_PreCallValidateGetPhysicalDeviceImageFormatProperties2KHR(
3579 VkPhysicalDevice physicalDevice, const VkPhysicalDeviceImageFormatInfo2 *pImageFormatInfo,
3580 VkImageFormatProperties2 *pImageFormatProperties) const {
3581 return ValidateGetPhysicalDeviceImageFormatProperties2(physicalDevice, pImageFormatInfo, pImageFormatProperties,
3582 "vkGetPhysicalDeviceImageFormatProperties2KHR");
3583}
3584
sfricke-samsung3999ef62020-02-09 17:05:59 -08003585bool StatelessValidation::manual_PreCallValidateCmdCopyBuffer(VkCommandBuffer commandBuffer, VkBuffer srcBuffer, VkBuffer dstBuffer,
3586 uint32_t regionCount, const VkBufferCopy *pRegions) const {
3587 bool skip = false;
3588
3589 if (pRegions != nullptr) {
3590 for (uint32_t i = 0; i < regionCount; i++) {
3591 if (pRegions[i].size == 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003592 skip |= LogError(device, "VUID-VkBufferCopy-size-01988",
3593 "vkCmdCopyBuffer() pRegions[%u].size must be greater than zero", i);
sfricke-samsung3999ef62020-02-09 17:05:59 -08003594 }
3595 }
3596 }
3597 return skip;
3598}
3599
Jeff Leger178b1e52020-10-05 12:22:23 -04003600bool StatelessValidation::manual_PreCallValidateCmdCopyBuffer2KHR(VkCommandBuffer commandBuffer,
3601 const VkCopyBufferInfo2KHR *pCopyBufferInfo) const {
3602 bool skip = false;
3603
3604 if (pCopyBufferInfo->pRegions != nullptr) {
3605 for (uint32_t i = 0; i < pCopyBufferInfo->regionCount; i++) {
3606 if (pCopyBufferInfo->pRegions[i].size == 0) {
3607 skip |= LogError(device, "VUID-VkBufferCopy2KHR-size-01988",
3608 "vkCmdCopyBuffer2KHR() pCopyBufferInfo->pRegions[%u].size must be greater than zero", i);
3609 }
3610 }
3611 }
3612 return skip;
3613}
3614
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003615bool StatelessValidation::manual_PreCallValidateCmdUpdateBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003616 VkDeviceSize dstOffset, VkDeviceSize dataSize,
3617 const void *pData) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003618 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003619
3620 if (dstOffset & 3) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003621 skip |= LogError(device, "VUID-vkCmdUpdateBuffer-dstOffset-00036",
3622 "vkCmdUpdateBuffer() parameter, VkDeviceSize dstOffset (0x%" PRIxLEAST64 "), is not a multiple of 4.",
3623 dstOffset);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003624 }
3625
3626 if ((dataSize <= 0) || (dataSize > 65536)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003627 skip |= LogError(device, "VUID-vkCmdUpdateBuffer-dataSize-00037",
3628 "vkCmdUpdateBuffer() parameter, VkDeviceSize dataSize (0x%" PRIxLEAST64
3629 "), must be greater than zero and less than or equal to 65536.",
3630 dataSize);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003631 } else if (dataSize & 3) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003632 skip |= LogError(device, "VUID-vkCmdUpdateBuffer-dataSize-00038",
3633 "vkCmdUpdateBuffer() parameter, VkDeviceSize dataSize (0x%" PRIxLEAST64 "), is not a multiple of 4.",
3634 dataSize);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003635 }
3636 return skip;
3637}
3638
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003639bool StatelessValidation::manual_PreCallValidateCmdFillBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003640 VkDeviceSize dstOffset, VkDeviceSize size, uint32_t data) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003641 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003642
3643 if (dstOffset & 3) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003644 skip |= LogError(device, "VUID-vkCmdFillBuffer-dstOffset-00025",
3645 "vkCmdFillBuffer() parameter, VkDeviceSize dstOffset (0x%" PRIxLEAST64 "), is not a multiple of 4.",
3646 dstOffset);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003647 }
3648
3649 if (size != VK_WHOLE_SIZE) {
3650 if (size <= 0) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003651 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003652 LogError(device, "VUID-vkCmdFillBuffer-size-00026",
3653 "vkCmdFillBuffer() parameter, VkDeviceSize size (0x%" PRIxLEAST64 "), must be greater than zero.", size);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003654 } else if (size & 3) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003655 skip |= LogError(device, "VUID-vkCmdFillBuffer-size-00028",
3656 "vkCmdFillBuffer() parameter, VkDeviceSize size (0x%" PRIxLEAST64 "), is not a multiple of 4.", size);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003657 }
3658 }
3659 return skip;
3660}
3661
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003662bool StatelessValidation::manual_PreCallValidateCreateSwapchainKHR(VkDevice device, const VkSwapchainCreateInfoKHR *pCreateInfo,
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003663 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003664 VkSwapchainKHR *pSwapchain) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003665 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003666
3667 if (pCreateInfo != nullptr) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003668 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
3669 if (pCreateInfo->imageSharingMode == VK_SHARING_MODE_CONCURRENT) {
3670 // If imageSharingMode is VK_SHARING_MODE_CONCURRENT, queueFamilyIndexCount must be greater than 1
3671 if (pCreateInfo->queueFamilyIndexCount <= 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003672 skip |= LogError(device, "VUID-VkSwapchainCreateInfoKHR-imageSharingMode-01278",
3673 "vkCreateSwapchainKHR(): if pCreateInfo->imageSharingMode is VK_SHARING_MODE_CONCURRENT, "
3674 "pCreateInfo->queueFamilyIndexCount must be greater than 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003675 }
3676
3677 // If imageSharingMode is VK_SHARING_MODE_CONCURRENT, pQueueFamilyIndices must be a pointer to an array of
3678 // queueFamilyIndexCount uint32_t values
3679 if (pCreateInfo->pQueueFamilyIndices == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003680 skip |= LogError(device, "VUID-VkSwapchainCreateInfoKHR-imageSharingMode-01277",
3681 "vkCreateSwapchainKHR(): if pCreateInfo->imageSharingMode is VK_SHARING_MODE_CONCURRENT, "
3682 "pCreateInfo->pQueueFamilyIndices must be a pointer to an array of "
3683 "pCreateInfo->queueFamilyIndexCount uint32_t values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003684 }
3685 }
3686
Dave Houlton413a6782018-05-22 13:01:54 -06003687 skip |= ValidateGreaterThanZero(pCreateInfo->imageArrayLayers, "pCreateInfo->imageArrayLayers",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003688 "VUID-VkSwapchainCreateInfoKHR-imageArrayLayers-01275", "vkCreateSwapchainKHR");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003689 }
3690
3691 return skip;
3692}
3693
Jeff Bolz5c801d12019-10-09 10:38:45 -05003694bool StatelessValidation::manual_PreCallValidateQueuePresentKHR(VkQueue queue, const VkPresentInfoKHR *pPresentInfo) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003695 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003696
3697 if (pPresentInfo && pPresentInfo->pNext) {
John Zulaufde972ac2017-10-26 12:07:05 -06003698 const auto *present_regions = lvl_find_in_chain<VkPresentRegionsKHR>(pPresentInfo->pNext);
3699 if (present_regions) {
3700 // TODO: This and all other pNext extension dependencies should be added to code-generation
Tony-LunarG2ec96bb2019-11-26 13:43:02 -07003701 skip |= require_device_extension(IsExtEnabled(device_extensions.vk_khr_incremental_present), "vkQueuePresentKHR",
John Zulaufde972ac2017-10-26 12:07:05 -06003702 VK_KHR_INCREMENTAL_PRESENT_EXTENSION_NAME);
3703 if (present_regions->swapchainCount != pPresentInfo->swapchainCount) {
sfricke-samsunga4cc4ff2020-08-23 22:05:49 -07003704 skip |= LogError(device, "VUID-VkPresentRegionsKHR-swapchainCount-01260",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003705 "QueuePresentKHR(): pPresentInfo->swapchainCount has a value of %i but VkPresentRegionsKHR "
3706 "extension swapchainCount is %i. These values must be equal.",
3707 pPresentInfo->swapchainCount, present_regions->swapchainCount);
John Zulaufde972ac2017-10-26 12:07:05 -06003708 }
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003709 skip |= validate_struct_pnext("QueuePresentKHR", "pCreateInfo->pNext->pNext", NULL, present_regions->pNext, 0, NULL,
sfricke-samsung32a27362020-02-28 09:06:42 -08003710 GeneratedVulkanHeaderVersion, "VUID-VkPresentInfoKHR-pNext-pNext",
3711 "VUID-VkPresentInfoKHR-sType-unique");
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003712 skip |= validate_array("QueuePresentKHR", "pCreateInfo->pNext->swapchainCount", "pCreateInfo->pNext->pRegions",
3713 present_regions->swapchainCount, &present_regions->pRegions, true, false, kVUIDUndefined,
3714 kVUIDUndefined);
John Zulaufde972ac2017-10-26 12:07:05 -06003715 for (uint32_t i = 0; i < present_regions->swapchainCount; ++i) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003716 skip |= validate_array("QueuePresentKHR", "pCreateInfo->pNext->pRegions[].rectangleCount",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003717 "pCreateInfo->pNext->pRegions[].pRectangles", present_regions->pRegions[i].rectangleCount,
Dave Houlton413a6782018-05-22 13:01:54 -06003718 &present_regions->pRegions[i].pRectangles, true, false, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003719 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003720 }
3721 }
3722
3723 return skip;
3724}
3725
3726#ifdef VK_USE_PLATFORM_WIN32_KHR
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003727bool StatelessValidation::manual_PreCallValidateCreateWin32SurfaceKHR(VkInstance instance,
3728 const VkWin32SurfaceCreateInfoKHR *pCreateInfo,
3729 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003730 VkSurfaceKHR *pSurface) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003731 bool skip = false;
3732
3733 if (pCreateInfo->hwnd == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003734 skip |= LogError(device, "VUID-VkWin32SurfaceCreateInfoKHR-hwnd-01308",
3735 "vkCreateWin32SurfaceKHR(): hwnd must be a valid Win32 HWND but hwnd is NULL.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003736 }
3737
3738 return skip;
3739}
3740#endif // VK_USE_PLATFORM_WIN32_KHR
3741
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003742bool StatelessValidation::manual_PreCallValidateCreateDescriptorPool(VkDevice device, const VkDescriptorPoolCreateInfo *pCreateInfo,
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003743 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003744 VkDescriptorPool *pDescriptorPool) const {
Petr Krausc8655be2017-09-27 18:56:51 +02003745 bool skip = false;
3746
3747 if (pCreateInfo) {
3748 if (pCreateInfo->maxSets <= 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003749 skip |= LogError(device, "VUID-VkDescriptorPoolCreateInfo-maxSets-00301",
3750 "vkCreateDescriptorPool(): pCreateInfo->maxSets is not greater than 0.");
Petr Krausc8655be2017-09-27 18:56:51 +02003751 }
3752
3753 if (pCreateInfo->pPoolSizes) {
3754 for (uint32_t i = 0; i < pCreateInfo->poolSizeCount; ++i) {
3755 if (pCreateInfo->pPoolSizes[i].descriptorCount <= 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003756 skip |= LogError(
3757 device, "VUID-VkDescriptorPoolSize-descriptorCount-00302",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003758 "vkCreateDescriptorPool(): pCreateInfo->pPoolSizes[%" PRIu32 "].descriptorCount is not greater than 0.", i);
Petr Krausc8655be2017-09-27 18:56:51 +02003759 }
Jeff Bolze54ae892018-09-08 12:16:29 -05003760 if (pCreateInfo->pPoolSizes[i].type == VK_DESCRIPTOR_TYPE_INLINE_UNIFORM_BLOCK_EXT &&
3761 (pCreateInfo->pPoolSizes[i].descriptorCount % 4) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003762 skip |= LogError(device, "VUID-VkDescriptorPoolSize-type-02218",
3763 "vkCreateDescriptorPool(): pCreateInfo->pPoolSizes[%" PRIu32
3764 "].type is VK_DESCRIPTOR_TYPE_INLINE_UNIFORM_BLOCK_EXT "
3765 " and pCreateInfo->pPoolSizes[%" PRIu32 "].descriptorCount is not a multiple of 4.",
3766 i, i);
Jeff Bolze54ae892018-09-08 12:16:29 -05003767 }
Petr Krausc8655be2017-09-27 18:56:51 +02003768 }
3769 }
3770 }
3771
3772 return skip;
3773}
3774
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003775bool StatelessValidation::manual_PreCallValidateCmdDispatch(VkCommandBuffer commandBuffer, uint32_t groupCountX,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003776 uint32_t groupCountY, uint32_t groupCountZ) const {
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003777 bool skip = false;
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003778
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003779 if (groupCountX > device_limits.maxComputeWorkGroupCount[0]) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003780 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003781 LogError(commandBuffer, "VUID-vkCmdDispatch-groupCountX-00386",
3782 "vkCmdDispatch(): groupCountX (%" PRIu32 ") exceeds device limit maxComputeWorkGroupCount[0] (%" PRIu32 ").",
3783 groupCountX, device_limits.maxComputeWorkGroupCount[0]);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003784 }
3785
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003786 if (groupCountY > device_limits.maxComputeWorkGroupCount[1]) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003787 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003788 LogError(commandBuffer, "VUID-vkCmdDispatch-groupCountY-00387",
3789 "vkCmdDispatch(): groupCountY (%" PRIu32 ") exceeds device limit maxComputeWorkGroupCount[1] (%" PRIu32 ").",
3790 groupCountY, device_limits.maxComputeWorkGroupCount[1]);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003791 }
3792
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003793 if (groupCountZ > device_limits.maxComputeWorkGroupCount[2]) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003794 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003795 LogError(commandBuffer, "VUID-vkCmdDispatch-groupCountZ-00388",
3796 "vkCmdDispatch(): groupCountZ (%" PRIu32 ") exceeds device limit maxComputeWorkGroupCount[2] (%" PRIu32 ").",
3797 groupCountZ, device_limits.maxComputeWorkGroupCount[2]);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003798 }
3799
3800 return skip;
3801}
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003802
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003803bool StatelessValidation::manual_PreCallValidateCmdDispatchIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003804 VkDeviceSize offset) const {
John Zulaufa999d1b2018-11-29 13:38:40 -07003805 bool skip = false;
John Zulaufa999d1b2018-11-29 13:38:40 -07003806
3807 if ((offset % 4) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003808 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchIndirect-offset-02710",
3809 "vkCmdDispatchIndirect(): offset (%" PRIu64 ") must be a multiple of 4.", offset);
John Zulaufa999d1b2018-11-29 13:38:40 -07003810 }
3811 return skip;
3812}
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003813
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003814bool StatelessValidation::manual_PreCallValidateCmdDispatchBaseKHR(VkCommandBuffer commandBuffer, uint32_t baseGroupX,
3815 uint32_t baseGroupY, uint32_t baseGroupZ, uint32_t groupCountX,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003816 uint32_t groupCountY, uint32_t groupCountZ) const {
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003817 bool skip = false;
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003818
3819 // Paired if {} else if {} tests used to avoid any possible uint underflow
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003820 uint32_t limit = device_limits.maxComputeWorkGroupCount[0];
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003821 if (baseGroupX >= limit) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003822 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchBase-baseGroupX-00421",
3823 "vkCmdDispatch(): baseGroupX (%" PRIu32
3824 ") equals or exceeds device limit maxComputeWorkGroupCount[0] (%" PRIu32 ").",
3825 baseGroupX, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003826 } else if (groupCountX > (limit - baseGroupX)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003827 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchBase-groupCountX-00424",
3828 "vkCmdDispatchBaseKHR(): baseGroupX (%" PRIu32 ") + groupCountX (%" PRIu32
3829 ") exceeds device limit maxComputeWorkGroupCount[0] (%" PRIu32 ").",
3830 baseGroupX, groupCountX, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003831 }
3832
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003833 limit = device_limits.maxComputeWorkGroupCount[1];
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003834 if (baseGroupY >= limit) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003835 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchBase-baseGroupX-00422",
3836 "vkCmdDispatch(): baseGroupY (%" PRIu32
3837 ") equals or exceeds device limit maxComputeWorkGroupCount[1] (%" PRIu32 ").",
3838 baseGroupY, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003839 } else if (groupCountY > (limit - baseGroupY)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003840 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchBase-groupCountY-00425",
3841 "vkCmdDispatchBaseKHR(): baseGroupY (%" PRIu32 ") + groupCountY (%" PRIu32
3842 ") exceeds device limit maxComputeWorkGroupCount[1] (%" PRIu32 ").",
3843 baseGroupY, groupCountY, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003844 }
3845
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003846 limit = device_limits.maxComputeWorkGroupCount[2];
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003847 if (baseGroupZ >= limit) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003848 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchBase-baseGroupZ-00423",
3849 "vkCmdDispatch(): baseGroupZ (%" PRIu32
3850 ") equals or exceeds device limit maxComputeWorkGroupCount[2] (%" PRIu32 ").",
3851 baseGroupZ, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003852 } else if (groupCountZ > (limit - baseGroupZ)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003853 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchBase-groupCountZ-00426",
3854 "vkCmdDispatchBaseKHR(): baseGroupZ (%" PRIu32 ") + groupCountZ (%" PRIu32
3855 ") exceeds device limit maxComputeWorkGroupCount[2] (%" PRIu32 ").",
3856 baseGroupZ, groupCountZ, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003857 }
3858
3859 return skip;
3860}
3861
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07003862bool StatelessValidation::manual_PreCallValidateCmdPushDescriptorSetKHR(VkCommandBuffer commandBuffer,
3863 VkPipelineBindPoint pipelineBindPoint,
3864 VkPipelineLayout layout, uint32_t set,
3865 uint32_t descriptorWriteCount,
3866 const VkWriteDescriptorSet *pDescriptorWrites) const {
3867 return validate_WriteDescriptorSet("vkCmdPushDescriptorSetKHR", descriptorWriteCount, pDescriptorWrites, false);
3868}
3869
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003870bool StatelessValidation::manual_PreCallValidateCmdSetExclusiveScissorNV(VkCommandBuffer commandBuffer,
3871 uint32_t firstExclusiveScissor,
3872 uint32_t exclusiveScissorCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003873 const VkRect2D *pExclusiveScissors) const {
Jeff Bolz3e71f782018-08-29 23:15:45 -05003874 bool skip = false;
3875
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003876 if (!physical_device_features.multiViewport) {
Jeff Bolz3e71f782018-08-29 23:15:45 -05003877 if (firstExclusiveScissor != 0) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06003878 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003879 LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-firstExclusiveScissor-02035",
3880 "vkCmdSetExclusiveScissorNV: The multiViewport feature is disabled, but firstExclusiveScissor (=%" PRIu32
3881 ") is not 0.",
3882 firstExclusiveScissor);
Jeff Bolz3e71f782018-08-29 23:15:45 -05003883 }
3884 if (exclusiveScissorCount > 1) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06003885 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003886 LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-exclusiveScissorCount-02036",
3887 "vkCmdSetExclusiveScissorNV: The multiViewport feature is disabled, but exclusiveScissorCount (=%" PRIu32
3888 ") is not 1.",
3889 exclusiveScissorCount);
Jeff Bolz3e71f782018-08-29 23:15:45 -05003890 }
3891 } else { // multiViewport enabled
3892 const uint64_t sum = static_cast<uint64_t>(firstExclusiveScissor) + static_cast<uint64_t>(exclusiveScissorCount);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003893 if (sum > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003894 skip |= LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-firstExclusiveScissor-02034",
3895 "vkCmdSetExclusiveScissorNV: firstExclusiveScissor + exclusiveScissorCount (=%" PRIu32 " + %" PRIu32
3896 " = %" PRIu64 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
3897 firstExclusiveScissor, exclusiveScissorCount, sum, device_limits.maxViewports);
Jeff Bolz3e71f782018-08-29 23:15:45 -05003898 }
3899 }
3900
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003901 if (firstExclusiveScissor >= device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003902 skip |= LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-firstExclusiveScissor-02033",
3903 "vkCmdSetExclusiveScissorNV: firstExclusiveScissor (=%" PRIu32
3904 ") must be less than maxViewports (=%" PRIu32 ").",
3905 firstExclusiveScissor, device_limits.maxViewports);
Jeff Bolz3e71f782018-08-29 23:15:45 -05003906 }
3907
3908 if (pExclusiveScissors) {
3909 for (uint32_t scissor_i = 0; scissor_i < exclusiveScissorCount; ++scissor_i) {
3910 const auto &scissor = pExclusiveScissors[scissor_i]; // will crash on invalid ptr
3911
3912 if (scissor.offset.x < 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003913 skip |= LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-x-02037",
3914 "vkCmdSetExclusiveScissorNV: pScissors[%" PRIu32 "].offset.x (=%" PRIi32 ") is negative.",
3915 scissor_i, scissor.offset.x);
Jeff Bolz3e71f782018-08-29 23:15:45 -05003916 }
3917
3918 if (scissor.offset.y < 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003919 skip |= LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-x-02037",
3920 "vkCmdSetExclusiveScissorNV: pScissors[%" PRIu32 "].offset.y (=%" PRIi32 ") is negative.",
3921 scissor_i, scissor.offset.y);
Jeff Bolz3e71f782018-08-29 23:15:45 -05003922 }
3923
3924 const int64_t x_sum = static_cast<int64_t>(scissor.offset.x) + static_cast<int64_t>(scissor.extent.width);
3925 if (x_sum > INT32_MAX) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003926 skip |= LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-offset-02038",
3927 "vkCmdSetExclusiveScissorNV: offset.x + extent.width (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
3928 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
3929 scissor.offset.x, scissor.extent.width, x_sum, scissor_i);
Jeff Bolz3e71f782018-08-29 23:15:45 -05003930 }
3931
3932 const int64_t y_sum = static_cast<int64_t>(scissor.offset.y) + static_cast<int64_t>(scissor.extent.height);
3933 if (y_sum > INT32_MAX) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003934 skip |= LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-offset-02039",
3935 "vkCmdSetExclusiveScissorNV: offset.y + extent.height (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
3936 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
3937 scissor.offset.y, scissor.extent.height, y_sum, scissor_i);
Jeff Bolz3e71f782018-08-29 23:15:45 -05003938 }
3939 }
3940 }
3941
3942 return skip;
3943}
3944
Chris Mayer9ded5eb2019-09-19 16:33:26 +02003945bool StatelessValidation::manual_PreCallValidateCmdSetViewportWScalingNV(VkCommandBuffer commandBuffer, uint32_t firstViewport,
3946 uint32_t viewportCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003947 const VkViewportWScalingNV *pViewportWScalings) const {
Chris Mayer9ded5eb2019-09-19 16:33:26 +02003948 bool skip = false;
3949 if (firstViewport >= device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003950 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewportWScalingNV-firstViewport-01323",
3951 "vkCmdSetViewportWScalingNV: firstViewport (=%" PRIu32 ") must be less than maxViewports (=%" PRIu32 ").",
3952 firstViewport, device_limits.maxViewports);
Chris Mayer9ded5eb2019-09-19 16:33:26 +02003953 } else {
3954 const uint64_t sum = static_cast<uint64_t>(firstViewport) + static_cast<uint64_t>(viewportCount);
3955 if ((sum < 1) || (sum > device_limits.maxViewports)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003956 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewportWScalingNV-firstViewport-01324",
3957 "vkCmdSetViewportWScalingNV: firstViewport + viewportCount (=%" PRIu32 " + %" PRIu32 " = %" PRIu64
3958 ") must be between 1 and VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 "), inculsive.",
3959 firstViewport, viewportCount, sum, device_limits.maxViewports);
Chris Mayer9ded5eb2019-09-19 16:33:26 +02003960 }
3961 }
3962
3963 return skip;
3964}
3965
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003966bool StatelessValidation::manual_PreCallValidateCmdSetViewportShadingRatePaletteNV(
3967 VkCommandBuffer commandBuffer, uint32_t firstViewport, uint32_t viewportCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003968 const VkShadingRatePaletteNV *pShadingRatePalettes) const {
Jeff Bolz9af91c52018-09-01 21:53:57 -05003969 bool skip = false;
3970
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003971 if (!physical_device_features.multiViewport) {
Jeff Bolz9af91c52018-09-01 21:53:57 -05003972 if (firstViewport != 0) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06003973 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003974 LogError(commandBuffer, "VUID-vkCmdSetViewportShadingRatePaletteNV-firstViewport-02068",
3975 "vkCmdSetViewportShadingRatePaletteNV: The multiViewport feature is disabled, but firstViewport (=%" PRIu32
3976 ") is not 0.",
3977 firstViewport);
Jeff Bolz9af91c52018-09-01 21:53:57 -05003978 }
3979 if (viewportCount > 1) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06003980 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003981 LogError(commandBuffer, "VUID-vkCmdSetViewportShadingRatePaletteNV-viewportCount-02069",
3982 "vkCmdSetViewportShadingRatePaletteNV: The multiViewport feature is disabled, but viewportCount (=%" PRIu32
3983 ") is not 1.",
3984 viewportCount);
Jeff Bolz9af91c52018-09-01 21:53:57 -05003985 }
3986 }
3987
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003988 if (firstViewport >= device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003989 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewportShadingRatePaletteNV-firstViewport-02066",
3990 "vkCmdSetViewportShadingRatePaletteNV: firstViewport (=%" PRIu32
3991 ") must be less than maxViewports (=%" PRIu32 ").",
3992 firstViewport, device_limits.maxViewports);
Jeff Bolz9af91c52018-09-01 21:53:57 -05003993 }
3994
3995 const uint64_t sum = static_cast<uint64_t>(firstViewport) + static_cast<uint64_t>(viewportCount);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003996 if (sum > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003997 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewportShadingRatePaletteNV-firstViewport-02067",
3998 "vkCmdSetViewportShadingRatePaletteNV: firstViewport + viewportCount (=%" PRIu32 " + %" PRIu32
3999 " = %" PRIu64 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
4000 firstViewport, viewportCount, sum, device_limits.maxViewports);
Jeff Bolz9af91c52018-09-01 21:53:57 -05004001 }
4002
4003 return skip;
4004}
4005
Jeff Bolz5c801d12019-10-09 10:38:45 -05004006bool StatelessValidation::manual_PreCallValidateCmdSetCoarseSampleOrderNV(
4007 VkCommandBuffer commandBuffer, VkCoarseSampleOrderTypeNV sampleOrderType, uint32_t customSampleOrderCount,
4008 const VkCoarseSampleOrderCustomNV *pCustomSampleOrders) const {
Jeff Bolz9af91c52018-09-01 21:53:57 -05004009 bool skip = false;
4010
Dave Houlton142c4cb2018-10-17 15:04:41 -06004011 if (sampleOrderType != VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV && customSampleOrderCount != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004012 skip |= LogError(commandBuffer, "VUID-vkCmdSetCoarseSampleOrderNV-sampleOrderType-02081",
4013 "vkCmdSetCoarseSampleOrderNV: If sampleOrderType is not VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV, "
4014 "customSampleOrderCount must be 0.");
Jeff Bolz9af91c52018-09-01 21:53:57 -05004015 }
4016
4017 for (uint32_t order_i = 0; order_i < customSampleOrderCount; ++order_i) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004018 skip |= ValidateCoarseSampleOrderCustomNV(&pCustomSampleOrders[order_i]);
Jeff Bolz9af91c52018-09-01 21:53:57 -05004019 }
4020
4021 return skip;
4022}
4023
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004024bool StatelessValidation::manual_PreCallValidateCmdDrawMeshTasksNV(VkCommandBuffer commandBuffer, uint32_t taskCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004025 uint32_t firstTask) const {
Jeff Bolz45bf7d62018-09-18 15:39:58 -05004026 bool skip = false;
4027
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004028 if (taskCount > phys_dev_ext_props.mesh_shader_props.maxDrawMeshTasksCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004029 skip |= LogError(
4030 commandBuffer, "VUID-vkCmdDrawMeshTasksNV-taskCount-02119",
Dave Houlton142c4cb2018-10-17 15:04:41 -06004031 "vkCmdDrawMeshTasksNV() parameter, uint32_t taskCount (0x%" PRIxLEAST32
4032 "), must be less than or equal to VkPhysicalDeviceMeshShaderPropertiesNV::maxDrawMeshTasksCount (0x%" PRIxLEAST32 ").",
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004033 taskCount, phys_dev_ext_props.mesh_shader_props.maxDrawMeshTasksCount);
Jeff Bolz45bf7d62018-09-18 15:39:58 -05004034 }
4035
4036 return skip;
4037}
4038
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004039bool StatelessValidation::manual_PreCallValidateCmdDrawMeshTasksIndirectNV(VkCommandBuffer commandBuffer, VkBuffer buffer,
4040 VkDeviceSize offset, uint32_t drawCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004041 uint32_t stride) const {
Jeff Bolz45bf7d62018-09-18 15:39:58 -05004042 bool skip = false;
Lockee1c22882019-06-10 16:02:54 -06004043 static const int condition_multiples = 0b0011;
4044 if (offset & condition_multiples) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004045 skip |= LogError(
4046 commandBuffer, "VUID-vkCmdDrawMeshTasksIndirectNV-offset-02710",
Dave Houlton142c4cb2018-10-17 15:04:41 -06004047 "vkCmdDrawMeshTasksIndirectNV() parameter, VkDeviceSize offset (0x%" PRIxLEAST64 "), is not a multiple of 4.", offset);
Jeff Bolz45bf7d62018-09-18 15:39:58 -05004048 }
Lockee1c22882019-06-10 16:02:54 -06004049 if (drawCount > 1 && ((stride & condition_multiples) || stride < sizeof(VkDrawMeshTasksIndirectCommandNV))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004050 skip |= LogError(commandBuffer, "VUID-vkCmdDrawMeshTasksIndirectNV-drawCount-02146",
4051 "vkCmdDrawMeshTasksIndirectNV() parameter, uint32_t stride (0x%" PRIxLEAST32
4052 "), is not a multiple of 4 or smaller than sizeof (VkDrawMeshTasksIndirectCommandNV).",
4053 stride);
Lockee1c22882019-06-10 16:02:54 -06004054 }
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004055 if (!physical_device_features.multiDrawIndirect && ((drawCount > 1))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004056 skip |= LogError(
4057 commandBuffer, "VUID-vkCmdDrawMeshTasksIndirectNV-drawCount-02718",
4058 "vkCmdDrawMeshTasksIndirectNV(): Device feature multiDrawIndirect disabled: count must be 0 or 1 but is %d", drawCount);
Jeff Bolzb574c342018-11-08 15:36:57 -06004059 }
4060
Jeff Bolz45bf7d62018-09-18 15:39:58 -05004061 return skip;
4062}
4063
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004064bool StatelessValidation::manual_PreCallValidateCmdDrawMeshTasksIndirectCountNV(VkCommandBuffer commandBuffer, VkBuffer buffer,
4065 VkDeviceSize offset, VkBuffer countBuffer,
4066 VkDeviceSize countBufferOffset,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004067 uint32_t maxDrawCount, uint32_t stride) const {
Jeff Bolz45bf7d62018-09-18 15:39:58 -05004068 bool skip = false;
4069
Jeff Bolz45bf7d62018-09-18 15:39:58 -05004070 if (offset & 3) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004071 skip |= LogError(commandBuffer, "VUID-vkCmdDrawMeshTasksIndirectCountNV-offset-02710",
4072 "vkCmdDrawMeshTasksIndirectCountNV() parameter, VkDeviceSize offset (0x%" PRIxLEAST64
4073 "), is not a multiple of 4.",
4074 offset);
Jeff Bolz45bf7d62018-09-18 15:39:58 -05004075 }
4076
4077 if (countBufferOffset & 3) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004078 skip |= LogError(commandBuffer, "VUID-vkCmdDrawMeshTasksIndirectCountNV-countBufferOffset-02716",
4079 "vkCmdDrawMeshTasksIndirectCountNV() parameter, VkDeviceSize countBufferOffset (0x%" PRIxLEAST64
4080 "), is not a multiple of 4.",
4081 countBufferOffset);
Jeff Bolz45bf7d62018-09-18 15:39:58 -05004082 }
4083
Jeff Bolz45bf7d62018-09-18 15:39:58 -05004084 return skip;
4085}
4086
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004087bool StatelessValidation::manual_PreCallValidateCreateQueryPool(VkDevice device, const VkQueryPoolCreateInfo *pCreateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004088 const VkAllocationCallbacks *pAllocator,
4089 VkQueryPool *pQueryPool) const {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004090 bool skip = false;
4091
4092 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
4093 if (pCreateInfo != nullptr) {
4094 // If queryType is VK_QUERY_TYPE_PIPELINE_STATISTICS, pipelineStatistics must be a valid combination of
4095 // VkQueryPipelineStatisticFlagBits values
4096 if ((pCreateInfo->queryType == VK_QUERY_TYPE_PIPELINE_STATISTICS) && (pCreateInfo->pipelineStatistics != 0) &&
4097 ((pCreateInfo->pipelineStatistics & (~AllVkQueryPipelineStatisticFlagBits)) != 0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004098 skip |= LogError(device, "VUID-VkQueryPoolCreateInfo-queryType-00792",
4099 "vkCreateQueryPool(): if pCreateInfo->queryType is VK_QUERY_TYPE_PIPELINE_STATISTICS, "
4100 "pCreateInfo->pipelineStatistics must be a valid combination of VkQueryPipelineStatisticFlagBits "
4101 "values.");
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004102 }
sfricke-samsung7d69d0d2020-04-25 10:27:27 -07004103 if (pCreateInfo->queryCount == 0) {
4104 skip |= LogError(device, "VUID-VkQueryPoolCreateInfo-queryCount-02763",
4105 "vkCreateQueryPool(): queryCount must be greater than zero.");
4106 }
Mark Lobodzinskib7a26382018-07-02 13:14:26 -06004107 }
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004108 return skip;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004109}
4110
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004111bool StatelessValidation::manual_PreCallValidateEnumerateDeviceExtensionProperties(VkPhysicalDevice physicalDevice,
4112 const char *pLayerName, uint32_t *pPropertyCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004113 VkExtensionProperties *pProperties) const {
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004114 return validate_array("vkEnumerateDeviceExtensionProperties", "pPropertyCount", "pProperties", pPropertyCount, &pProperties,
4115 true, false, false, kVUIDUndefined, "VUID-vkEnumerateDeviceExtensionProperties-pProperties-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004116}
4117
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004118void StatelessValidation::PostCallRecordCreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo,
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -07004119 const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass,
4120 VkResult result) {
4121 if (result != VK_SUCCESS) return;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004122 RecordRenderPass(*pRenderPass, pCreateInfo);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004123}
4124
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004125void StatelessValidation::PostCallRecordCreateRenderPass2KHR(VkDevice device, const VkRenderPassCreateInfo2KHR *pCreateInfo,
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -07004126 const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass,
4127 VkResult result) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004128 // Track the state necessary for checking vkCreateGraphicsPipeline (subpass usage of depth and color attachments)
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -07004129 if (result != VK_SUCCESS) return;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004130 RecordRenderPass(*pRenderPass, pCreateInfo);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004131}
4132
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004133void StatelessValidation::PostCallRecordDestroyRenderPass(VkDevice device, VkRenderPass renderPass,
4134 const VkAllocationCallbacks *pAllocator) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004135 // Track the state necessary for checking vkCreateGraphicsPipeline (subpass usage of depth and color attachments)
Mark Lobodzinskif27a6bc2019-02-04 13:00:49 -07004136 std::unique_lock<std::mutex> lock(renderpass_map_mutex);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004137 renderpasses_states.erase(renderPass);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004138}
Jeff Bolz7e7e6e02019-01-11 22:53:41 -06004139
4140bool StatelessValidation::manual_PreCallValidateAllocateMemory(VkDevice device, const VkMemoryAllocateInfo *pAllocateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004141 const VkAllocationCallbacks *pAllocator,
4142 VkDeviceMemory *pMemory) const {
Jeff Bolz7e7e6e02019-01-11 22:53:41 -06004143 bool skip = false;
4144
4145 if (pAllocateInfo) {
4146 auto chained_prio_struct = lvl_find_in_chain<VkMemoryPriorityAllocateInfoEXT>(pAllocateInfo->pNext);
4147 if (chained_prio_struct && (chained_prio_struct->priority < 0.0f || chained_prio_struct->priority > 1.0f)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004148 skip |= LogError(device, "VUID-VkMemoryPriorityAllocateInfoEXT-priority-02602",
4149 "priority (=%f) must be between `0` and `1`, inclusive.", chained_prio_struct->priority);
Jeff Bolz7e7e6e02019-01-11 22:53:41 -06004150 }
Jeff Bolz4563f2a2019-12-10 13:30:30 -06004151
4152 VkMemoryAllocateFlags flags = 0;
4153 auto flags_info = lvl_find_in_chain<VkMemoryAllocateFlagsInfo>(pAllocateInfo->pNext);
4154 if (flags_info) {
4155 flags = flags_info->flags;
4156 }
4157
4158 auto opaque_alloc_info = lvl_find_in_chain<VkMemoryOpaqueCaptureAddressAllocateInfoKHR>(pAllocateInfo->pNext);
4159 if (opaque_alloc_info && opaque_alloc_info->opaqueCaptureAddress != 0) {
4160 if (!(flags & VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT_KHR)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004161 skip |= LogError(device, "VUID-VkMemoryAllocateInfo-opaqueCaptureAddress-03329",
4162 "If opaqueCaptureAddress is non-zero, VkMemoryAllocateFlagsInfo::flags must include "
4163 "VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT_KHR.");
Jeff Bolz4563f2a2019-12-10 13:30:30 -06004164 }
4165
4166#ifdef VK_USE_PLATFORM_WIN32_KHR
4167 auto import_memory_win32_handle = lvl_find_in_chain<VkImportMemoryWin32HandleInfoKHR>(pAllocateInfo->pNext);
4168#endif
4169 auto import_memory_fd = lvl_find_in_chain<VkImportMemoryFdInfoKHR>(pAllocateInfo->pNext);
4170 auto import_memory_host_pointer = lvl_find_in_chain<VkImportMemoryHostPointerInfoEXT>(pAllocateInfo->pNext);
4171#ifdef VK_USE_PLATFORM_ANDROID_KHR
4172 auto import_memory_ahb = lvl_find_in_chain<VkImportAndroidHardwareBufferInfoANDROID>(pAllocateInfo->pNext);
4173#endif
4174
4175 if (import_memory_host_pointer) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004176 skip |= LogError(
4177 device, "VUID-VkMemoryAllocateInfo-pNext-03332",
Jeff Bolz4563f2a2019-12-10 13:30:30 -06004178 "If the pNext chain includes a VkImportMemoryHostPointerInfoEXT structure, opaqueCaptureAddress must be zero.");
4179 }
4180 if (
4181#ifdef VK_USE_PLATFORM_WIN32_KHR
4182 (import_memory_win32_handle && import_memory_win32_handle->handleType) ||
4183#endif
4184 (import_memory_fd && import_memory_fd->handleType) ||
4185#ifdef VK_USE_PLATFORM_ANDROID_KHR
4186 (import_memory_ahb && import_memory_ahb->buffer) ||
4187#endif
4188 (import_memory_host_pointer && import_memory_host_pointer->handleType)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004189 skip |= LogError(device, "VUID-VkMemoryAllocateInfo-opaqueCaptureAddress-03333",
4190 "If the parameters define an import operation, opaqueCaptureAddress must be zero.");
Jeff Bolz4563f2a2019-12-10 13:30:30 -06004191 }
4192 }
4193
4194 if (flags) {
Tony-LunarGa74d3fe2019-11-22 15:43:20 -07004195 VkBool32 capture_replay = false;
4196 VkBool32 buffer_device_address = false;
4197 const auto *vulkan_12_features = lvl_find_in_chain<VkPhysicalDeviceVulkan12Features>(device_createinfo_pnext);
4198 if (vulkan_12_features) {
4199 capture_replay = vulkan_12_features->bufferDeviceAddressCaptureReplay;
4200 buffer_device_address = vulkan_12_features->bufferDeviceAddress;
4201 } else {
4202 const auto *bda_features =
4203 lvl_find_in_chain<VkPhysicalDeviceBufferDeviceAddressFeaturesKHR>(device_createinfo_pnext);
4204 if (bda_features) {
4205 capture_replay = bda_features->bufferDeviceAddressCaptureReplay;
4206 buffer_device_address = bda_features->bufferDeviceAddress;
4207 }
4208 }
4209 if ((flags & VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT_KHR) && !capture_replay) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004210 skip |= LogError(device, "VUID-VkMemoryAllocateInfo-flags-03330",
4211 "If VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT_KHR is set, "
4212 "bufferDeviceAddressCaptureReplay must be enabled.");
Jeff Bolz4563f2a2019-12-10 13:30:30 -06004213 }
Tony-LunarGa74d3fe2019-11-22 15:43:20 -07004214 if ((flags & VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_BIT_KHR) && !buffer_device_address) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004215 skip |= LogError(device, "VUID-VkMemoryAllocateInfo-flags-03331",
4216 "If VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_BIT_KHR is set, bufferDeviceAddress must be enabled.");
Jeff Bolz4563f2a2019-12-10 13:30:30 -06004217 }
4218 }
Jeff Bolz7e7e6e02019-01-11 22:53:41 -06004219 }
4220 return skip;
4221}
Ricardo Garciaa4935972019-02-21 17:43:18 +01004222
Jason Macnak192fa0e2019-07-26 15:07:16 -07004223bool StatelessValidation::ValidateGeometryTrianglesNV(const VkGeometryTrianglesNV &triangles,
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004224 VkAccelerationStructureNV object_handle, const char *func_name) const {
Jason Macnak192fa0e2019-07-26 15:07:16 -07004225 bool skip = false;
4226
4227 if (triangles.vertexFormat != VK_FORMAT_R32G32B32_SFLOAT && triangles.vertexFormat != VK_FORMAT_R16G16B16_SFLOAT &&
4228 triangles.vertexFormat != VK_FORMAT_R16G16B16_SNORM && triangles.vertexFormat != VK_FORMAT_R32G32_SFLOAT &&
4229 triangles.vertexFormat != VK_FORMAT_R16G16_SFLOAT && triangles.vertexFormat != VK_FORMAT_R16G16_SNORM) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004230 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-vertexFormat-02430", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004231 } else {
4232 uint32_t vertex_component_size = 0;
4233 if (triangles.vertexFormat == VK_FORMAT_R32G32B32_SFLOAT || triangles.vertexFormat == VK_FORMAT_R32G32_SFLOAT) {
4234 vertex_component_size = 4;
4235 } else if (triangles.vertexFormat == VK_FORMAT_R16G16B16_SFLOAT || triangles.vertexFormat == VK_FORMAT_R16G16B16_SNORM ||
4236 triangles.vertexFormat == VK_FORMAT_R16G16_SFLOAT || triangles.vertexFormat == VK_FORMAT_R16G16_SNORM) {
4237 vertex_component_size = 2;
4238 }
4239 if (vertex_component_size > 0 && SafeModulo(triangles.vertexOffset, vertex_component_size) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004240 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-vertexOffset-02429", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004241 }
4242 }
4243
4244 if (triangles.indexType != VK_INDEX_TYPE_UINT32 && triangles.indexType != VK_INDEX_TYPE_UINT16 &&
4245 triangles.indexType != VK_INDEX_TYPE_NONE_NV) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004246 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-indexType-02433", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004247 } else {
4248 uint32_t index_element_size = 0;
4249 if (triangles.indexType == VK_INDEX_TYPE_UINT32) {
4250 index_element_size = 4;
4251 } else if (triangles.indexType == VK_INDEX_TYPE_UINT16) {
4252 index_element_size = 2;
4253 }
4254 if (index_element_size > 0 && SafeModulo(triangles.indexOffset, index_element_size) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004255 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-indexOffset-02432", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004256 }
4257 }
4258 if (triangles.indexType == VK_INDEX_TYPE_NONE_NV) {
4259 if (triangles.indexCount != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004260 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-indexCount-02436", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004261 }
4262 if (triangles.indexData != VK_NULL_HANDLE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004263 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-indexData-02434", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004264 }
4265 }
4266
4267 if (SafeModulo(triangles.transformOffset, 16) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004268 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-transformOffset-02438", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004269 }
4270
4271 return skip;
4272}
4273
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004274bool StatelessValidation::ValidateGeometryAABBNV(const VkGeometryAABBNV &aabbs, VkAccelerationStructureNV object_handle,
4275 const char *func_name) const {
Jason Macnak192fa0e2019-07-26 15:07:16 -07004276 bool skip = false;
4277
4278 if (SafeModulo(aabbs.offset, 8) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004279 skip |= LogError(object_handle, "VUID-VkGeometryAABBNV-offset-02440", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004280 }
4281 if (SafeModulo(aabbs.stride, 8) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004282 skip |= LogError(object_handle, "VUID-VkGeometryAABBNV-stride-02441", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004283 }
4284
4285 return skip;
4286}
4287
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004288bool StatelessValidation::ValidateGeometryNV(const VkGeometryNV &geometry, VkAccelerationStructureNV object_handle,
4289 const char *func_name) const {
Jason Macnak192fa0e2019-07-26 15:07:16 -07004290 bool skip = false;
4291 if (geometry.geometryType == VK_GEOMETRY_TYPE_TRIANGLES_NV) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004292 skip = ValidateGeometryTrianglesNV(geometry.geometry.triangles, object_handle, func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004293 } else if (geometry.geometryType == VK_GEOMETRY_TYPE_AABBS_NV) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004294 skip = ValidateGeometryAABBNV(geometry.geometry.aabbs, object_handle, func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004295 }
4296 return skip;
4297}
4298
4299bool StatelessValidation::ValidateAccelerationStructureInfoNV(const VkAccelerationStructureInfoNV &info,
sourav parmara24fb7b2020-05-26 10:50:04 -07004300 VkAccelerationStructureNV object_handle, const char *func_name,
Mark Lobodzinski17dc4602020-05-29 07:48:40 -06004301 bool is_cmd) const {
Jason Macnak5c954952019-07-09 15:46:12 -07004302 bool skip = false;
4303 if (info.type == VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_NV && info.geometryCount != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004304 skip |= LogError(object_handle, "VUID-VkAccelerationStructureInfoNV-type-02425",
4305 "VkAccelerationStructureInfoNV: If type is VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_NV then "
4306 "geometryCount must be 0.");
Jason Macnak5c954952019-07-09 15:46:12 -07004307 }
4308 if (info.type == VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_NV && info.instanceCount != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004309 skip |= LogError(object_handle, "VUID-VkAccelerationStructureInfoNV-type-02426",
4310 "VkAccelerationStructureInfoNV: If type is VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_NV then "
4311 "instanceCount must be 0.");
Jason Macnak5c954952019-07-09 15:46:12 -07004312 }
4313 if (info.flags & VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_TRACE_BIT_NV &&
4314 info.flags & VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_BUILD_BIT_NV) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004315 skip |= LogError(object_handle, "VUID-VkAccelerationStructureInfoNV-flags-02592",
4316 "VkAccelerationStructureInfoNV: If flags has the VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_TRACE_BIT_NV"
4317 "bit set, then it must not have the VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_BUILD_BIT_NV bit set.");
Jason Macnak5c954952019-07-09 15:46:12 -07004318 }
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004319 if (info.geometryCount > phys_dev_ext_props.ray_tracing_propsNV.maxGeometryCount) {
sourav parmara24fb7b2020-05-26 10:50:04 -07004320 skip |= LogError(object_handle,
Mark Lobodzinski17dc4602020-05-29 07:48:40 -06004321 is_cmd ? "VUID-vkCmdBuildAccelerationStructureNV-geometryCount-02241"
4322 : "VUID-VkAccelerationStructureInfoNV-geometryCount-02422",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004323 "VkAccelerationStructureInfoNV: geometryCount must be less than or equal to "
4324 "VkPhysicalDeviceRayTracingPropertiesNV::maxGeometryCount.");
Jason Macnak5c954952019-07-09 15:46:12 -07004325 }
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004326 if (info.instanceCount > phys_dev_ext_props.ray_tracing_propsNV.maxInstanceCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004327 skip |= LogError(object_handle, "VUID-VkAccelerationStructureInfoNV-instanceCount-02423",
4328 "VkAccelerationStructureInfoNV: instanceCount must be less than or equal to "
4329 "VkPhysicalDeviceRayTracingPropertiesNV::maxInstanceCount.");
Jason Macnak5c954952019-07-09 15:46:12 -07004330 }
Jason Macnak21ba97e2019-08-09 12:57:44 -07004331 if (info.type == VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_NV && info.geometryCount > 0) {
Jason Macnak5c954952019-07-09 15:46:12 -07004332 uint64_t total_triangle_count = 0;
4333 for (uint32_t i = 0; i < info.geometryCount; i++) {
4334 const VkGeometryNV &geometry = info.pGeometries[i];
Jason Macnak192fa0e2019-07-26 15:07:16 -07004335
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004336 skip |= ValidateGeometryNV(geometry, object_handle, func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004337
Jason Macnak5c954952019-07-09 15:46:12 -07004338 if (geometry.geometryType != VK_GEOMETRY_TYPE_TRIANGLES_NV) {
4339 continue;
4340 }
4341 total_triangle_count += geometry.geometry.triangles.indexCount / 3;
4342 }
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004343 if (total_triangle_count > phys_dev_ext_props.ray_tracing_propsNV.maxTriangleCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004344 skip |= LogError(object_handle, "VUID-VkAccelerationStructureInfoNV-maxTriangleCount-02424",
4345 "VkAccelerationStructureInfoNV: The total number of triangles in all geometries must be less than "
4346 "or equal to VkPhysicalDeviceRayTracingPropertiesNV::maxTriangleCount.");
Jason Macnak5c954952019-07-09 15:46:12 -07004347 }
4348 }
Jason Macnak21ba97e2019-08-09 12:57:44 -07004349 if (info.type == VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_NV && info.geometryCount > 1) {
4350 const VkGeometryTypeNV first_geometry_type = info.pGeometries[0].geometryType;
4351 for (uint32_t i = 1; i < info.geometryCount; i++) {
4352 const VkGeometryNV &geometry = info.pGeometries[i];
4353 if (geometry.geometryType != first_geometry_type) {
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004354 skip |= LogError(device, "VUID-VkAccelerationStructureInfoNV-type-02786",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004355 "VkAccelerationStructureInfoNV: info.pGeometries[%d].geometryType does not match "
4356 "info.pGeometries[0].geometryType.",
4357 i);
Jason Macnak21ba97e2019-08-09 12:57:44 -07004358 }
4359 }
4360 }
sourav parmara96ab1a2020-04-25 16:28:23 -07004361 for (uint32_t geometry_index = 0; geometry_index < info.geometryCount; ++geometry_index) {
4362 if (!(info.pGeometries[geometry_index].geometryType == VK_GEOMETRY_TYPE_TRIANGLES_NV ||
4363 info.pGeometries[geometry_index].geometryType == VK_GEOMETRY_TYPE_AABBS_NV)) {
4364 skip |= LogError(device, "VUID-VkGeometryNV-geometryType-03503",
4365 "VkGeometryNV: geometryType must be VK_GEOMETRY_TYPE_TRIANGLES_NV"
4366 "or VK_GEOMETRY_TYPE_AABBS_NV.");
4367 }
4368 }
4369 skip |=
4370 validate_flags(func_name, "info.flags", "VkBuildAccelerationStructureFlagBitsNV", AllVkBuildAccelerationStructureFlagBitsNV,
Shannon McPherson93970b12020-06-12 14:34:35 -06004371 info.flags, kOptionalFlags, "VUID-VkAccelerationStructureInfoNV-flags-parameter");
Jason Macnak5c954952019-07-09 15:46:12 -07004372 return skip;
4373}
4374
Ricardo Garciaa4935972019-02-21 17:43:18 +01004375bool StatelessValidation::manual_PreCallValidateCreateAccelerationStructureNV(
4376 VkDevice device, const VkAccelerationStructureCreateInfoNV *pCreateInfo, const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004377 VkAccelerationStructureNV *pAccelerationStructure) const {
Ricardo Garciaa4935972019-02-21 17:43:18 +01004378 bool skip = false;
Ricardo Garciaa4935972019-02-21 17:43:18 +01004379 if (pCreateInfo) {
4380 if ((pCreateInfo->compactedSize != 0) &&
4381 ((pCreateInfo->info.geometryCount != 0) || (pCreateInfo->info.instanceCount != 0))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004382 skip |= LogError(device, "VUID-VkAccelerationStructureCreateInfoNV-compactedSize-02421",
4383 "vkCreateAccelerationStructureNV(): pCreateInfo->compactedSize nonzero (%" PRIu64
4384 ") with info.geometryCount (%" PRIu32 ") or info.instanceCount (%" PRIu32 ") nonzero.",
4385 pCreateInfo->compactedSize, pCreateInfo->info.geometryCount, pCreateInfo->info.instanceCount);
Ricardo Garciaa4935972019-02-21 17:43:18 +01004386 }
Jason Macnak5c954952019-07-09 15:46:12 -07004387
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004388 skip |= ValidateAccelerationStructureInfoNV(pCreateInfo->info, VkAccelerationStructureNV(0),
sourav parmara24fb7b2020-05-26 10:50:04 -07004389 "vkCreateAccelerationStructureNV()", false);
Ricardo Garciaa4935972019-02-21 17:43:18 +01004390 }
Ricardo Garciaa4935972019-02-21 17:43:18 +01004391 return skip;
4392}
Mike Schuchardt21638df2019-03-16 10:52:02 -07004393
Jeff Bolz5c801d12019-10-09 10:38:45 -05004394bool StatelessValidation::manual_PreCallValidateCmdBuildAccelerationStructureNV(VkCommandBuffer commandBuffer,
4395 const VkAccelerationStructureInfoNV *pInfo,
4396 VkBuffer instanceData, VkDeviceSize instanceOffset,
4397 VkBool32 update, VkAccelerationStructureNV dst,
4398 VkAccelerationStructureNV src, VkBuffer scratch,
4399 VkDeviceSize scratchOffset) const {
Jason Macnak5c954952019-07-09 15:46:12 -07004400 bool skip = false;
4401
4402 if (pInfo != nullptr) {
sourav parmara24fb7b2020-05-26 10:50:04 -07004403 skip |= ValidateAccelerationStructureInfoNV(*pInfo, dst, "vkCmdBuildAccelerationStructureNV()", true);
Jason Macnak5c954952019-07-09 15:46:12 -07004404 }
4405
4406 return skip;
4407}
4408
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004409bool StatelessValidation::manual_PreCallValidateCreateAccelerationStructureKHR(
4410 VkDevice device, const VkAccelerationStructureCreateInfoKHR *pCreateInfo, const VkAllocationCallbacks *pAllocator,
4411 VkAccelerationStructureKHR *pAccelerationStructure) const {
4412 bool skip = false;
4413
4414 if (pCreateInfo) {
4415 for (uint32_t i = 0; i < pCreateInfo->maxGeometryCount; ++i) {
4416 if (pCreateInfo->type == VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_KHR && pCreateInfo->compactedSize == 0) {
4417 if (pCreateInfo->pGeometryInfos[i].geometryType != VK_GEOMETRY_TYPE_INSTANCES_KHR) {
4418 skip |= LogError(device, "VUID-VkAccelerationStructureCreateInfoKHR-type-03496",
4419 "VkAccelerationStructureCreateInfoKHR: Top-level acceleration structure "
4420 "pGeometryInfos[%d].geometryType must be VK_GEOMETRY_TYPE_INSTANCES_KHR",
4421 i);
4422 }
4423 }
4424
4425 if (pCreateInfo->type == VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_KHR && pCreateInfo->compactedSize == 0) {
4426 if (pCreateInfo->pGeometryInfos[i].geometryType == VK_GEOMETRY_TYPE_INSTANCES_KHR) {
4427 skip |= LogError(device, "VUID-VkAccelerationStructureCreateInfoKHR-type-03497",
4428 "VkAccelerationStructureCreateInfoKHR: Bottom-level acceleration structure "
4429 "pGeometryInfos[%d].geometryType must not be VK_GEOMETRY_TYPE_INSTANCES_KHR",
4430 i);
4431 }
4432 }
sourav parmara96ab1a2020-04-25 16:28:23 -07004433 if (pCreateInfo->pGeometryInfos[i].geometryType == VK_GEOMETRY_TYPE_TRIANGLES_KHR) {
4434 if (!(pCreateInfo->pGeometryInfos[i].indexType == VK_INDEX_TYPE_UINT16 ||
4435 pCreateInfo->pGeometryInfos[i].indexType == VK_INDEX_TYPE_UINT32 ||
4436 pCreateInfo->pGeometryInfos[i].indexType == VK_INDEX_TYPE_NONE_KHR)) {
4437 skip |= LogError(
4438 device, "VUID-VkAccelerationStructureCreateGeometryTypeInfoKHR-geometryType-03502",
4439 "VkAccelerationStructureCreateInfoKHR: If geometryType is VK_GEOMETRY_TYPE_TRIANGLES_KHR, indexType"
4440 "must be VK_INDEX_TYPE_UINT16, VK_INDEX_TYPE_UINT32, or VK_INDEX_TYPE_NONE_KHR.");
4441 }
4442 }
4443 if (pCreateInfo->type == VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_KHR) {
4444 if (pCreateInfo->pGeometryInfos[i].maxPrimitiveCount > phys_dev_ext_props.ray_tracing_propsKHR.maxInstanceCount) {
4445 skip |= LogError(device, "VUID-VkAccelerationStructureCreateInfoKHR-type-03492",
4446 "VkAccelerationStructureCreateInfoKHR: If type is VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_KHR"
4447 "then pGeometryInfos->maxPrimitiveCount %d must be less than or equal to "
4448 "VkPhysicalDeviceRayTracingPropertiesKHR::maxInstanceCount %d.",
4449 pCreateInfo->pGeometryInfos[i].maxPrimitiveCount,
4450 phys_dev_ext_props.ray_tracing_propsKHR.maxInstanceCount);
4451 }
4452 }
4453 }
4454
4455 if (pCreateInfo->type == VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_KHR && pCreateInfo->compactedSize == 0 &&
4456 pCreateInfo->maxGeometryCount != 1) {
4457 skip |= LogError(device, "VUID-VkAccelerationStructureCreateInfoKHR-type-03495",
4458 "VkAccelerationStructureCreateInfoKHR: If type is VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_KHR"
4459 "and compactedSize is 0, maxGeometryCount must be 1.");
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004460 }
sourav parmard1521802020-06-07 21:49:02 -07004461 // or VUID-VkAccelerationStructureCreateInfoKHR-compactedSize-03490
4462 if (pCreateInfo->compactedSize == 0 && pCreateInfo->maxGeometryCount == 0) {
4463 skip |= LogError(device, "VUID-VkAccelerationStructureCreateInfoKHR-compactedSize-02993",
4464 "VkAccelerationStructureCreateInfoKHR: If compactedSize is 0 then maxGeometryCount must not be 0.");
4465 }
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004466
4467 if (pCreateInfo->flags & VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_TRACE_BIT_KHR &&
4468 pCreateInfo->flags & VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_BUILD_BIT_KHR) {
4469 skip |= LogError(
4470 device, "VUID-VkAccelerationStructureCreateInfoKHR-flags-03499",
4471 "VkAccelerationStructureCreateInfoKHR: If flags has the VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_TRACE_BIT_KHR"
4472 "bit set, then it must not have the VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_BUILD_BIT_KHR bit set.");
4473 }
4474
4475 if (pCreateInfo->compactedSize != 0 && pCreateInfo->maxGeometryCount != 0) {
4476 skip |= LogError(device, "VUID-VkAccelerationStructureCreateInfoKHR-compactedSize-03490",
4477 "VkAccelerationStructureCreateInfoKHR: pCreateInfo->compactedSize nonzero (%" PRIu64
4478 ") with maxGeometryCount (%" PRIu32 ") nonzero.",
4479 pCreateInfo->compactedSize, pCreateInfo->maxGeometryCount);
4480 }
4481
4482 if (pCreateInfo->type == VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_NV && pCreateInfo->maxGeometryCount > 1) {
4483 const VkGeometryTypeKHR first_geometry_type = pCreateInfo->pGeometryInfos[0].geometryType;
4484 for (uint32_t i = 1; i < pCreateInfo->maxGeometryCount; i++) {
4485 const VkGeometryTypeKHR geometry_type = pCreateInfo->pGeometryInfos[i].geometryType;
4486 if (geometry_type != first_geometry_type) {
4487 skip |= LogError(device, "VUID-VkAccelerationStructureCreateInfoKHR-type-03498",
4488 "VkAccelerationStructureCreateInfoKHR: pGeometryInfos[%d].geometryType does not match "
4489 "pGeometryInfos[0].geometryType.",
4490 i);
4491 }
4492 }
4493 }
sourav parmara96ab1a2020-04-25 16:28:23 -07004494 if (pCreateInfo->type == VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_KHR &&
4495 (pCreateInfo->maxGeometryCount > phys_dev_ext_props.ray_tracing_propsKHR.maxGeometryCount)) {
4496 skip |= LogError(device, "VUID-VkAccelerationStructureCreateInfoKHR-type-03491",
4497 "VkAccelerationStructureCreateInfoKHR: If type is VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_KHR"
4498 "then maxGeometryCount %d must be less than or equal to VkPhysicalDeviceRayTracingPropertiesKHR "
4499 "maxGeometryCount %d.",
4500 pCreateInfo->maxGeometryCount, phys_dev_ext_props.ray_tracing_propsKHR.maxGeometryCount);
4501 }
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004502 }
sourav parmara96ab1a2020-04-25 16:28:23 -07004503 const auto *raytracing_features = lvl_find_in_chain<VkPhysicalDeviceRayTracingFeaturesKHR>(device_createinfo_pnext);
4504 if (!raytracing_features || raytracing_features->rayTracingAccelerationStructureCaptureReplay == VK_FALSE) {
4505 if (pCreateInfo->deviceAddress != 0) {
4506 skip |=
4507 LogError(device, "VUID-VkAccelerationStructureCreateInfoKHR-deviceAddress-03500",
4508 "VkAccelerationStructureCreateInfoKHR: If deviceAddress is not 0, "
4509 "VkPhysicalDeviceRayTracingFeaturesKHR::rayTracingAccelerationStructureCaptureReplay must be VK_TRUE.");
4510 }
4511 }
sourav parmar83c31b12020-05-06 12:30:54 -07004512 if (!raytracing_features || !(raytracing_features->rayQuery == VK_TRUE || raytracing_features->rayTracing == VK_TRUE)) {
4513 skip |= LogError(device, "VUID-vkCreateAccelerationStructureKHR-rayTracing-03487",
4514 "vkCreateAccelerationStructureKHR: The rayTracing or rayQuery feature must be enabled.");
4515 }
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004516 return skip;
4517}
4518
Jason Macnak5c954952019-07-09 15:46:12 -07004519bool StatelessValidation::manual_PreCallValidateGetAccelerationStructureHandleNV(VkDevice device,
4520 VkAccelerationStructureNV accelerationStructure,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004521 size_t dataSize, void *pData) const {
Jason Macnak5c954952019-07-09 15:46:12 -07004522 bool skip = false;
4523 if (dataSize < 8) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004524 skip = LogError(accelerationStructure, "VUID-vkGetAccelerationStructureHandleNV-dataSize-02240",
4525 "vkGetAccelerationStructureHandleNV(): dataSize must be greater than or equal to 8.");
Jason Macnak5c954952019-07-09 15:46:12 -07004526 }
4527 return skip;
4528}
4529
Peter Chen85366392019-05-14 15:20:11 -04004530bool StatelessValidation::manual_PreCallValidateCreateRayTracingPipelinesNV(VkDevice device, VkPipelineCache pipelineCache,
4531 uint32_t createInfoCount,
4532 const VkRayTracingPipelineCreateInfoNV *pCreateInfos,
4533 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004534 VkPipeline *pPipelines) const {
Peter Chen85366392019-05-14 15:20:11 -04004535 bool skip = false;
4536
4537 for (uint32_t i = 0; i < createInfoCount; i++) {
4538 auto feedback_struct = lvl_find_in_chain<VkPipelineCreationFeedbackCreateInfoEXT>(pCreateInfos[i].pNext);
4539 if ((feedback_struct != nullptr) && (feedback_struct->pipelineStageCreationFeedbackCount != pCreateInfos[i].stageCount)) {
sourav parmar83c31b12020-05-06 12:30:54 -07004540 skip |= LogError(device, "VUID-VkPipelineCreationFeedbackCreateInfoEXT-pipelineStageCreationFeedbackCount-02969",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004541 "vkCreateRayTracingPipelinesNV(): in pCreateInfo[%" PRIu32
4542 "], VkPipelineCreationFeedbackEXT::pipelineStageCreationFeedbackCount"
4543 "(=%" PRIu32 ") must equal VkRayTracingPipelineCreateInfoNV::stageCount(=%" PRIu32 ").",
4544 i, feedback_struct->pipelineStageCreationFeedbackCount, pCreateInfos[i].stageCount);
Peter Chen85366392019-05-14 15:20:11 -04004545 }
sourav parmara96ab1a2020-04-25 16:28:23 -07004546
4547 const auto *pipeline_cache_contol_features =
4548 lvl_find_in_chain<VkPhysicalDevicePipelineCreationCacheControlFeaturesEXT>(device_createinfo_pnext);
4549 if (!pipeline_cache_contol_features || pipeline_cache_contol_features->pipelineCreationCacheControl == VK_FALSE) {
4550 if (pCreateInfos[i].flags & (VK_PIPELINE_CREATE_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT_EXT |
4551 VK_PIPELINE_CREATE_EARLY_RETURN_ON_FAILURE_BIT_EXT)) {
4552 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-pipelineCreationCacheControl-02905",
4553 "vkCreateRayTracingPipelinesNV(): If the pipelineCreationCacheControl feature is not enabled,"
4554 "flags must not include VK_PIPELINE_CREATE_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT_EXT or"
4555 "VK_PIPELINE_CREATE_EARLY_RETURN_ON_FAILURE_BIT_EXT.");
4556 }
4557 }
4558
sourav parmarf4a78252020-04-10 13:04:21 -07004559 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_INDIRECT_BINDABLE_BIT_NV) {
4560 skip |=
4561 LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-02904",
4562 "vkCreateRayTracingPipelinesNV(): flags must not include VK_PIPELINE_CREATE_INDIRECT_BINDABLE_BIT_NV.");
4563 }
4564 if ((pCreateInfos[i].flags & VK_PIPELINE_CREATE_DEFER_COMPILE_BIT_NV) &&
4565 (pCreateInfos[i].flags & VK_PIPELINE_CREATE_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT_EXT)) {
4566 skip |=
4567 LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-02957",
4568 "vkCreateRayTracingPipelinesNV(): flags must not include both VK_PIPELINE_CREATE_DEFER_COMPILE_BIT_NV and"
4569 "VK_PIPELINE_CREATE_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT_EXT at the same time.");
4570 }
4571 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_DERIVATIVE_BIT) {
4572 if (pCreateInfos[i].basePipelineIndex != -1) {
4573 if (pCreateInfos[i].basePipelineHandle != VK_NULL_HANDLE) {
4574 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03423",
4575 "vkCreateRayTracingPipelinesNV parameter, pCreateInfos->basePipelineHandle, must be "
4576 "VK_NULL_HANDLE if pCreateInfos->flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT flag "
4577 "and pCreateInfos->basePipelineIndex is not -1.");
4578 }
sourav parmara24fb7b2020-05-26 10:50:04 -07004579 if (pCreateInfos[i].basePipelineIndex > (int32_t)(i)) {
4580 skip |=
4581 LogError(device, "VUID-vkCreateRayTracingPipelinesNV-flags-03415",
4582 "vkCreateRayTracingPipelinesNV: If the flags member of any element of pCreateInfos contains the"
4583 "VK_PIPELINE_CREATE_DERIVATIVE_BIT flag, and the basePipelineIndex member of that same element"
4584 "is not -1, basePipelineIndex must be less than the index into pCreateInfos that corresponds to "
4585 "that element.");
4586 }
sourav parmarf4a78252020-04-10 13:04:21 -07004587 }
4588 if (pCreateInfos[i].basePipelineHandle == VK_NULL_HANDLE) {
David Netod9d7b762020-07-27 15:37:58 -04004589 if (static_cast<uint32_t>(pCreateInfos[i].basePipelineIndex) >= createInfoCount) {
sourav parmarf4a78252020-04-10 13:04:21 -07004590 skip |=
4591 LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03422",
4592 "vkCreateRayTracingPipelinesNV if flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT and"
4593 "basePipelineHandle is VK_NULL_HANDLE, basePipelineIndex must be a valid index into the calling"
4594 "commands pCreateInfos parameter.");
4595 }
4596 } else {
4597 if (pCreateInfos[i].basePipelineIndex != -1) {
4598 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03424",
4599 "vkCreateRayTracingPipelinesNV if flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT and"
4600 "basePipelineHandle is not VK_NULL_HANDLE, basePipelineIndex must be -1.");
4601 }
4602 }
4603 }
4604 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_LIBRARY_BIT_KHR) {
4605 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03456",
4606 "vkCreateRayTracingPipelinesNV: flags must not include VK_PIPELINE_CREATE_LIBRARY_BIT_KHR.");
4607 }
4608 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_ANY_HIT_SHADERS_BIT_KHR) {
4609 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03458",
4610 "vkCreateRayTracingPipelinesNV: flags must not include "
4611 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_ANY_HIT_SHADERS_BIT_KHR.");
4612 }
4613 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_CLOSEST_HIT_SHADERS_BIT_KHR) {
4614 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03459",
4615 "vkCreateRayTracingPipelinesNV: flags must not include "
4616 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_CLOSEST_HIT_SHADERS_BIT_KHR.");
4617 }
4618 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_MISS_SHADERS_BIT_KHR) {
4619 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03460",
4620 "vkCreateRayTracingPipelinesNV: flags must not include "
4621 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_MISS_SHADERS_BIT_KHR.");
4622 }
4623 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_INTERSECTION_SHADERS_BIT_KHR) {
4624 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03461",
4625 "vkCreateRayTracingPipelinesNV: flags must not include "
4626 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_INTERSECTION_SHADERS_BIT_KHR.");
4627 }
4628 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_SKIP_AABBS_BIT_KHR) {
4629 skip |= LogError(
4630 device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03462",
4631 "vkCreateRayTracingPipelinesNV: flags must not include VK_PIPELINE_CREATE_RAY_TRACING_SKIP_AABBS_BIT_KHR.");
4632 }
4633 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_SKIP_TRIANGLES_BIT_KHR) {
4634 skip |= LogError(
4635 device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03463",
4636 "vkCreateRayTracingPipelinesNV: flags must not include VK_PIPELINE_CREATE_RAY_TRACING_SKIP_TRIANGLES_BIT_KHR .");
4637 }
Peter Chen85366392019-05-14 15:20:11 -04004638 }
4639
4640 return skip;
4641}
4642
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004643bool StatelessValidation::manual_PreCallValidateCreateRayTracingPipelinesKHR(VkDevice device, VkPipelineCache pipelineCache,
4644 uint32_t createInfoCount,
4645 const VkRayTracingPipelineCreateInfoKHR *pCreateInfos,
4646 const VkAllocationCallbacks *pAllocator,
4647 VkPipeline *pPipelines) const {
4648 bool skip = false;
sourav parmar83c31b12020-05-06 12:30:54 -07004649 const auto *raytracing_features = lvl_find_in_chain<VkPhysicalDeviceRayTracingFeaturesKHR>(device_createinfo_pnext);
4650 if (!raytracing_features || raytracing_features->rayTracing == VK_FALSE) {
4651 skip |= LogError(device, "VUID-vkCreateRayTracingPipelinesKHR-rayTracing-03455",
4652 "vkCreateRayTracingPipelinesKHR(): The rayTracing feature must be enabled.");
4653 }
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004654 for (uint32_t i = 0; i < createInfoCount; i++) {
4655 auto feedback_struct = lvl_find_in_chain<VkPipelineCreationFeedbackCreateInfoEXT>(pCreateInfos[i].pNext);
4656 if ((feedback_struct != nullptr) && (feedback_struct->pipelineStageCreationFeedbackCount != pCreateInfos[i].stageCount)) {
4657 skip |= LogError(device, "VUID-VkPipelineCreationFeedbackCreateInfoEXT-pipelineStageCreationFeedbackCount-02670",
4658 "vkCreateRayTracingPipelinesKHR(): in pCreateInfo[%" PRIu32
4659 "], VkPipelineCreationFeedbackEXT::pipelineStageCreationFeedbackCount"
4660 "(=%" PRIu32 ") must equal VkRayTracingPipelineCreateInfoKHR::stageCount(=%" PRIu32 ").",
4661 i, feedback_struct->pipelineStageCreationFeedbackCount, pCreateInfos[i].stageCount);
4662 }
sourav parmara96ab1a2020-04-25 16:28:23 -07004663 const auto *pipeline_cache_contol_features =
4664 lvl_find_in_chain<VkPhysicalDevicePipelineCreationCacheControlFeaturesEXT>(device_createinfo_pnext);
4665 if (!pipeline_cache_contol_features || pipeline_cache_contol_features->pipelineCreationCacheControl == VK_FALSE) {
4666 if (pCreateInfos[i].flags & (VK_PIPELINE_CREATE_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT_EXT |
4667 VK_PIPELINE_CREATE_EARLY_RETURN_ON_FAILURE_BIT_EXT)) {
4668 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-pipelineCreationCacheControl-02905",
4669 "vkCreateRayTracingPipelinesKHR(): If the pipelineCreationCacheControl feature is not enabled,"
4670 "flags must not include VK_PIPELINE_CREATE_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT_EXT or"
4671 "VK_PIPELINE_CREATE_EARLY_RETURN_ON_FAILURE_BIT_EXT.");
4672 }
4673 }
sourav parmara96ab1a2020-04-25 16:28:23 -07004674 if (!raytracing_features || raytracing_features->rayTracingPrimitiveCulling == VK_FALSE) {
4675 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_SKIP_AABBS_BIT_KHR) {
4676 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-rayTracingPrimitiveCulling-03472",
4677 "vkCreateRayTracingPipelinesKHR(): If the rayTracingPrimitiveCulling feature is not enabled,"
4678 "flags must not include VK_PIPELINE_CREATE_RAY_TRACING_SKIP_AABBS_BIT_KHR.");
4679 }
4680 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_SKIP_TRIANGLES_BIT_KHR) {
4681 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-rayTracingPrimitiveCulling-03473",
4682 "vkCreateRayTracingPipelinesKHR(): If the rayTracingPrimitiveCulling feature is not enabled,"
4683 "flags must not include VK_PIPELINE_CREATE_RAY_TRACING_SKIP_TRIANGLES_BIT_KHR .");
4684 }
4685 }
4686
sourav parmarf4a78252020-04-10 13:04:21 -07004687 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_INDIRECT_BINDABLE_BIT_NV) {
4688 skip |=
4689 LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-02904",
4690 "vkCreateRayTracingPipelinesKHR(): flags must not include VK_PIPELINE_CREATE_INDIRECT_BINDABLE_BIT_NV.");
4691 }
4692 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_LIBRARY_BIT_KHR) {
4693 if (pCreateInfos[i].pLibraryInterface == NULL)
4694 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-03465",
4695 "If flags includes VK_PIPELINE_CREATE_LIBRARY_BIT_KHR, pLibraryInterface must not be NULL.");
4696 }
4697 for (uint32_t group_index = 0; group_index < pCreateInfos[i].groupCount; ++group_index) {
4698 if ((pCreateInfos[i].pGroups[group_index].type == VK_RAY_TRACING_SHADER_GROUP_TYPE_TRIANGLES_HIT_GROUP_KHR) ||
4699 (pCreateInfos[i].pGroups[group_index].type == VK_RAY_TRACING_SHADER_GROUP_TYPE_PROCEDURAL_HIT_GROUP_KHR)) {
4700 if ((pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_ANY_HIT_SHADERS_BIT_KHR) &&
4701 (pCreateInfos[i].pGroups[group_index].anyHitShader == VK_SHADER_UNUSED_KHR)) {
4702 skip |= LogError(
4703 device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-03470",
4704 "If flags includes VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_ANY_HIT_SHADERS_BIT_KHR,"
4705 "for any element of pGroups with a type of VK_RAY_TRACING_SHADER_GROUP_TYPE_TRIANGLES_HIT_GROUP_KHR"
4706 "or VK_RAY_TRACING_SHADER_GROUP_TYPE_PROCEDURAL_HIT_GROUP_KHR, the anyHitShader of that element "
4707 "must not be VK_SHADER_UNUSED_KHR");
4708 }
4709 if ((pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_CLOSEST_HIT_SHADERS_BIT_KHR) &&
4710 (pCreateInfos[i].pGroups[group_index].closestHitShader == VK_SHADER_UNUSED_KHR)) {
4711 skip |= LogError(
4712 device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-03471",
4713 "If flags includes VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_CLOSEST_HIT_SHADERS_BIT_KHR,"
4714 "for any element of pGroups with a type of VK_RAY_TRACING_SHADER_GROUP_TYPE_TRIANGLES_HIT_GROUP_KHR"
4715 "or VK_RAY_TRACING_SHADER_GROUP_TYPE_PROCEDURAL_HIT_GROUP_KHR, the closestHitShader of that "
4716 "element must not be VK_SHADER_UNUSED_KHR");
4717 }
4718 }
4719 }
4720 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_DERIVATIVE_BIT) {
4721 if (pCreateInfos[i].basePipelineIndex != -1) {
4722 if (pCreateInfos[i].basePipelineHandle != VK_NULL_HANDLE) {
4723 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-03423",
4724 "vkCreateRayTracingPipelinesKHR parameter, pCreateInfos->basePipelineHandle, must be "
4725 "VK_NULL_HANDLE if pCreateInfos->flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT flag "
4726 "and pCreateInfos->basePipelineIndex is not -1.");
4727 }
sourav parmara24fb7b2020-05-26 10:50:04 -07004728 if (pCreateInfos[i].basePipelineIndex > (int32_t)i) {
4729 skip |=
4730 LogError(device, "VUID-vkCreateRayTracingPipelinesKHR-flags-03415",
4731 "vkCreateRayTracingPipelinesKHR: If the flags member of any element of pCreateInfos contains the"
4732 "VK_PIPELINE_CREATE_DERIVATIVE_BIT flag, and the basePipelineIndex member of that same element is"
4733 "not -1, basePipelineIndex must be less than the index into pCreateInfos that corresponds to that "
4734 "element.");
4735 }
sourav parmarf4a78252020-04-10 13:04:21 -07004736 }
4737 if (pCreateInfos[i].basePipelineHandle == VK_NULL_HANDLE) {
David Netod9d7b762020-07-27 15:37:58 -04004738 if (static_cast<uint32_t>(pCreateInfos[i].basePipelineIndex) >= createInfoCount) {
sourav parmarf4a78252020-04-10 13:04:21 -07004739 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-03422",
4740 "vkCreateRayTracingPipelinesKHR if flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT and"
4741 "basePipelineHandle is VK_NULL_HANDLE, basePipelineIndex (%d) must be a valid into the calling"
4742 "commands pCreateInfos parameter %d.",
4743 pCreateInfos[i].basePipelineIndex, createInfoCount);
4744 }
4745 } else {
4746 if (pCreateInfos[i].basePipelineIndex != -1) {
4747 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-03424",
4748 "vkCreateRayTracingPipelinesKHR if flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT and"
4749 "basePipelineHandle is not VK_NULL_HANDLE, basePipelineIndex must be -1.");
4750 }
4751 }
4752 }
4753 if (pCreateInfos[i].libraries.libraryCount == 0) {
4754 if (pCreateInfos[i].stageCount == 0) {
4755 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-libraries-02958",
4756 "If libraries.libraryCount is zero, then stageCount must not be zero .");
4757 }
4758 if (pCreateInfos[i].groupCount == 0) {
4759 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-libraries-02959",
4760 "If libraries.libraryCount is zero, then groupCount must not be zero .");
4761 }
4762 } else {
4763 if (pCreateInfos[i].pLibraryInterface == NULL) {
4764 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-libraryCount-03466",
4765 "If the libraryCount member of libraries is greater than 0, pLibraryInterface must not be NULL.");
4766 }
4767 }
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004768 }
4769
4770 return skip;
4771}
4772
Mike Schuchardt21638df2019-03-16 10:52:02 -07004773#ifdef VK_USE_PLATFORM_WIN32_KHR
4774bool StatelessValidation::PreCallValidateGetDeviceGroupSurfacePresentModes2EXT(VkDevice device,
4775 const VkPhysicalDeviceSurfaceInfo2KHR *pSurfaceInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004776 VkDeviceGroupPresentModeFlagsKHR *pModes) const {
Mike Schuchardt21638df2019-03-16 10:52:02 -07004777 bool skip = false;
4778 if (!device_extensions.vk_khr_swapchain)
4779 skip |= OutputExtensionError("vkGetDeviceGroupSurfacePresentModes2EXT", VK_KHR_SWAPCHAIN_EXTENSION_NAME);
4780 if (!device_extensions.vk_khr_get_surface_capabilities_2)
4781 skip |= OutputExtensionError("vkGetDeviceGroupSurfacePresentModes2EXT", VK_KHR_GET_SURFACE_CAPABILITIES_2_EXTENSION_NAME);
4782 if (!device_extensions.vk_khr_surface)
4783 skip |= OutputExtensionError("vkGetDeviceGroupSurfacePresentModes2EXT", VK_KHR_SURFACE_EXTENSION_NAME);
4784 if (!device_extensions.vk_khr_get_physical_device_properties_2)
4785 skip |=
4786 OutputExtensionError("vkGetDeviceGroupSurfacePresentModes2EXT", VK_KHR_GET_PHYSICAL_DEVICE_PROPERTIES_2_EXTENSION_NAME);
4787 if (!device_extensions.vk_ext_full_screen_exclusive)
4788 skip |= OutputExtensionError("vkGetDeviceGroupSurfacePresentModes2EXT", VK_EXT_FULL_SCREEN_EXCLUSIVE_EXTENSION_NAME);
4789 skip |= validate_struct_type(
4790 "vkGetDeviceGroupSurfacePresentModes2EXT", "pSurfaceInfo", "VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SURFACE_INFO_2_KHR",
4791 pSurfaceInfo, VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SURFACE_INFO_2_KHR, true,
4792 "VUID-vkGetDeviceGroupSurfacePresentModes2EXT-pSurfaceInfo-parameter", "VUID-VkPhysicalDeviceSurfaceInfo2KHR-sType-sType");
4793 if (pSurfaceInfo != NULL) {
4794 const VkStructureType allowed_structs_VkPhysicalDeviceSurfaceInfo2KHR[] = {
4795 VK_STRUCTURE_TYPE_SURFACE_FULL_SCREEN_EXCLUSIVE_INFO_EXT,
4796 VK_STRUCTURE_TYPE_SURFACE_FULL_SCREEN_EXCLUSIVE_WIN32_INFO_EXT};
4797
4798 skip |= validate_struct_pnext("vkGetDeviceGroupSurfacePresentModes2EXT", "pSurfaceInfo->pNext",
4799 "VkSurfaceFullScreenExclusiveInfoEXT, VkSurfaceFullScreenExclusiveWin32InfoEXT",
4800 pSurfaceInfo->pNext, ARRAY_SIZE(allowed_structs_VkPhysicalDeviceSurfaceInfo2KHR),
4801 allowed_structs_VkPhysicalDeviceSurfaceInfo2KHR, GeneratedVulkanHeaderVersion,
sfricke-samsung32a27362020-02-28 09:06:42 -08004802 "VUID-VkPhysicalDeviceSurfaceInfo2KHR-pNext-pNext",
4803 "VUID-VkPhysicalDeviceSurfaceInfo2KHR-sType-unique");
Mike Schuchardt21638df2019-03-16 10:52:02 -07004804
4805 skip |= validate_required_handle("vkGetDeviceGroupSurfacePresentModes2EXT", "pSurfaceInfo->surface", pSurfaceInfo->surface);
4806 }
4807 return skip;
4808}
4809#endif
Tobias Hectorebb855f2019-07-23 12:17:33 +01004810
4811bool StatelessValidation::manual_PreCallValidateCreateFramebuffer(VkDevice device, const VkFramebufferCreateInfo *pCreateInfo,
4812 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004813 VkFramebuffer *pFramebuffer) const {
Tobias Hectorebb855f2019-07-23 12:17:33 +01004814 // Validation for pAttachments which is excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
4815 bool skip = false;
4816 if ((pCreateInfo->flags & VK_FRAMEBUFFER_CREATE_IMAGELESS_BIT_KHR) == 0) {
4817 skip |= validate_array("vkCreateFramebuffer", "attachmentCount", "pAttachments", pCreateInfo->attachmentCount,
4818 &pCreateInfo->pAttachments, false, true, kVUIDUndefined, kVUIDUndefined);
4819 }
4820 return skip;
4821}
Jeff Bolz8125a8b2019-08-16 16:29:45 -05004822
4823bool StatelessValidation::manual_PreCallValidateCmdSetLineStippleEXT(VkCommandBuffer commandBuffer, uint32_t lineStippleFactor,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004824 uint16_t lineStipplePattern) const {
Jeff Bolz8125a8b2019-08-16 16:29:45 -05004825 bool skip = false;
4826
4827 if (lineStippleFactor < 1 || lineStippleFactor > 256) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004828 skip |= LogError(commandBuffer, "VUID-vkCmdSetLineStippleEXT-lineStippleFactor-02776",
4829 "vkCmdSetLineStippleEXT::lineStippleFactor=%d is not in [1,256].", lineStippleFactor);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05004830 }
4831
4832 return skip;
4833}
Piers Daniell8fd03f52019-08-21 12:07:53 -06004834
4835bool StatelessValidation::manual_PreCallValidateCmdBindIndexBuffer(VkCommandBuffer commandBuffer, VkBuffer buffer,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004836 VkDeviceSize offset, VkIndexType indexType) const {
Piers Daniell8fd03f52019-08-21 12:07:53 -06004837 bool skip = false;
4838
4839 if (indexType == VK_INDEX_TYPE_NONE_NV) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004840 skip |= LogError(commandBuffer, "VUID-vkCmdBindIndexBuffer-indexType-02507",
4841 "vkCmdBindIndexBuffer() indexType must not be VK_INDEX_TYPE_NONE_NV.");
Piers Daniell8fd03f52019-08-21 12:07:53 -06004842 }
4843
Tony-LunarG6c3c5452019-12-13 10:37:38 -07004844 const auto *index_type_uint8_features = lvl_find_in_chain<VkPhysicalDeviceIndexTypeUint8FeaturesEXT>(device_createinfo_pnext);
Mark Lobodzinski804fde82020-05-08 07:49:25 -06004845 if (indexType == VK_INDEX_TYPE_UINT8_EXT && (!index_type_uint8_features || !index_type_uint8_features->indexTypeUint8)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004846 skip |= LogError(commandBuffer, "VUID-vkCmdBindIndexBuffer-indexType-02765",
4847 "vkCmdBindIndexBuffer() indexType is VK_INDEX_TYPE_UINT8_EXT but indexTypeUint8 feature is not enabled.");
Piers Daniell8fd03f52019-08-21 12:07:53 -06004848 }
4849
4850 return skip;
4851}
Mark Lobodzinski84988402019-09-11 15:27:30 -06004852
sfricke-samsung4ada8d42020-02-09 17:43:11 -08004853bool StatelessValidation::manual_PreCallValidateCmdBindVertexBuffers(VkCommandBuffer commandBuffer, uint32_t firstBinding,
4854 uint32_t bindingCount, const VkBuffer *pBuffers,
4855 const VkDeviceSize *pOffsets) const {
4856 bool skip = false;
4857 if (firstBinding > device_limits.maxVertexInputBindings) {
4858 skip |= LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers-firstBinding-00624",
4859 "vkCmdBindVertexBuffers() firstBinding (%u) must be less than maxVertexInputBindings (%u)", firstBinding,
4860 device_limits.maxVertexInputBindings);
4861 } else if ((firstBinding + bindingCount) > device_limits.maxVertexInputBindings) {
4862 skip |= LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers-firstBinding-00625",
4863 "vkCmdBindVertexBuffers() sum of firstBinding (%u) and bindingCount (%u) must be less than "
4864 "maxVertexInputBindings (%u)",
4865 firstBinding, bindingCount, device_limits.maxVertexInputBindings);
4866 }
4867
Jeff Bolz165818a2020-05-08 11:19:03 -05004868 for (uint32_t i = 0; i < bindingCount; ++i) {
4869 if (pBuffers[i] == VK_NULL_HANDLE) {
4870 const auto *robustness2_features = lvl_find_in_chain<VkPhysicalDeviceRobustness2FeaturesEXT>(device_createinfo_pnext);
4871 if (!(robustness2_features && robustness2_features->nullDescriptor)) {
4872 skip |= LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers-pBuffers-04001",
4873 "vkCmdBindVertexBuffers() required parameter pBuffers[%d] specified as VK_NULL_HANDLE", i);
4874 } else {
4875 if (pOffsets[i] != 0) {
4876 skip |= LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers-pBuffers-04002",
4877 "vkCmdBindVertexBuffers() pBuffers[%d] is VK_NULL_HANDLE, but pOffsets[%d] is not 0", i, i);
4878 }
4879 }
4880 }
4881 }
4882
sfricke-samsung4ada8d42020-02-09 17:43:11 -08004883 return skip;
4884}
4885
Mark Lobodzinski84988402019-09-11 15:27:30 -06004886bool StatelessValidation::manual_PreCallValidateSetDebugUtilsObjectNameEXT(VkDevice device,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004887 const VkDebugUtilsObjectNameInfoEXT *pNameInfo) const {
Mark Lobodzinski84988402019-09-11 15:27:30 -06004888 bool skip = false;
4889 if (pNameInfo->objectType == VK_OBJECT_TYPE_UNKNOWN) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004890 skip |= LogError(device, "VUID-VkDebugUtilsObjectNameInfoEXT-objectType-02589",
4891 "vkSetDebugUtilsObjectNameEXT() pNameInfo->objectType cannot be VK_OBJECT_TYPE_UNKNOWN.");
Mark Lobodzinski84988402019-09-11 15:27:30 -06004892 }
4893 return skip;
4894}
4895
4896bool StatelessValidation::manual_PreCallValidateSetDebugUtilsObjectTagEXT(VkDevice device,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004897 const VkDebugUtilsObjectTagInfoEXT *pTagInfo) const {
Mark Lobodzinski84988402019-09-11 15:27:30 -06004898 bool skip = false;
4899 if (pTagInfo->objectType == VK_OBJECT_TYPE_UNKNOWN) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004900 skip |= LogError(device, "VUID-VkDebugUtilsObjectTagInfoEXT-objectType-01908",
4901 "vkSetDebugUtilsObjectTagEXT() pTagInfo->objectType cannot be VK_OBJECT_TYPE_UNKNOWN.");
Mark Lobodzinski84988402019-09-11 15:27:30 -06004902 }
4903 return skip;
4904}
Petr Kraus3d720392019-11-13 02:52:39 +01004905
4906bool StatelessValidation::manual_PreCallValidateAcquireNextImageKHR(VkDevice device, VkSwapchainKHR swapchain, uint64_t timeout,
4907 VkSemaphore semaphore, VkFence fence,
4908 uint32_t *pImageIndex) const {
4909 bool skip = false;
4910
4911 if (semaphore == VK_NULL_HANDLE && fence == VK_NULL_HANDLE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004912 skip |= LogError(swapchain, "VUID-vkAcquireNextImageKHR-semaphore-01780",
4913 "vkAcquireNextImageKHR: semaphore and fence are both VK_NULL_HANDLE.");
Petr Kraus3d720392019-11-13 02:52:39 +01004914 }
4915
4916 return skip;
4917}
4918
4919bool StatelessValidation::manual_PreCallValidateAcquireNextImage2KHR(VkDevice device, const VkAcquireNextImageInfoKHR *pAcquireInfo,
4920 uint32_t *pImageIndex) const {
4921 bool skip = false;
4922
4923 if (pAcquireInfo->semaphore == VK_NULL_HANDLE && pAcquireInfo->fence == VK_NULL_HANDLE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004924 skip |= LogError(pAcquireInfo->swapchain, "VUID-VkAcquireNextImageInfoKHR-semaphore-01782",
4925 "vkAcquireNextImage2KHR: pAcquireInfo->semaphore and pAcquireInfo->fence are both VK_NULL_HANDLE.");
Petr Kraus3d720392019-11-13 02:52:39 +01004926 }
4927
4928 return skip;
4929}
Mark Lobodzinski953b7bc2019-12-19 13:50:10 -07004930
Jeremy Hayes9bda85a2020-05-21 16:36:17 -06004931bool StatelessValidation::manual_PreCallValidateCmdBindTransformFeedbackBuffersEXT(VkCommandBuffer commandBuffer,
4932 uint32_t firstBinding, uint32_t bindingCount,
4933 const VkBuffer *pBuffers,
4934 const VkDeviceSize *pOffsets,
4935 const VkDeviceSize *pSizes) const {
4936 bool skip = false;
4937
4938 char const *const cmd_name = "CmdBindTransformFeedbackBuffersEXT";
4939 for (uint32_t i = 0; i < bindingCount; ++i) {
4940 if (pOffsets[i] & 3) {
4941 skip |= LogError(commandBuffer, "VUID-vkCmdBindTransformFeedbackBuffersEXT-pOffsets-02359",
4942 "%s: pOffsets[%" PRIu32 "](0x%" PRIxLEAST64 ") is not a multiple of 4.", cmd_name, i, pOffsets[i]);
4943 }
4944 }
4945
4946 if (firstBinding >= phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers) {
4947 skip |= LogError(commandBuffer, "VUID-vkCmdBindTransformFeedbackBuffersEXT-firstBinding-02356",
4948 "%s: The firstBinding(%" PRIu32
4949 ") index is greater than or equal to "
4950 "VkPhysicalDeviceTransformFeedbackPropertiesEXT::maxTransformFeedbackBuffers(%" PRIu32 ").",
4951 cmd_name, firstBinding, phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers);
4952 }
4953
4954 if (firstBinding + bindingCount > phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers) {
4955 skip |=
4956 LogError(commandBuffer, "VUID-vkCmdBindTransformFeedbackBuffersEXT-firstBinding-02357",
4957 "%s: The sum of firstBinding(%" PRIu32 ") and bindCount(%" PRIu32
4958 ") is greater than VkPhysicalDeviceTransformFeedbackPropertiesEXT::maxTransformFeedbackBuffers(%" PRIu32 ").",
4959 cmd_name, firstBinding, bindingCount, phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers);
4960 }
4961
4962 for (uint32_t i = 0; i < bindingCount; ++i) {
4963 // pSizes is optional and may be nullptr.
4964 if (pSizes != nullptr) {
4965 if (pSizes[i] != VK_WHOLE_SIZE &&
4966 pSizes[i] > phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBufferSize) {
4967 skip |= LogError(commandBuffer, "VUID-vkCmdBindTransformFeedbackBuffersEXT-pSize-02361",
4968 "%s: pSizes[%" PRIu32 "] (0x%" PRIxLEAST64
4969 ") is not VK_WHOLE_SIZE and is greater than "
4970 "VkPhysicalDeviceTransformFeedbackPropertiesEXT::maxTransformFeedbackBufferSize.",
4971 cmd_name, i, pSizes[i]);
4972 }
4973 }
4974 }
4975
4976 return skip;
4977}
4978
4979bool StatelessValidation::manual_PreCallValidateCmdBeginTransformFeedbackEXT(VkCommandBuffer commandBuffer,
4980 uint32_t firstCounterBuffer,
4981 uint32_t counterBufferCount,
4982 const VkBuffer *pCounterBuffers,
4983 const VkDeviceSize *pCounterBufferOffsets) const {
4984 bool skip = false;
4985
4986 char const *const cmd_name = "CmdBeginTransformFeedbackEXT";
4987 if (firstCounterBuffer >= phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers) {
4988 skip |= LogError(commandBuffer, "VUID-vkCmdBeginTransformFeedbackEXT-firstCounterBuffer-02368",
4989 "%s: The firstCounterBuffer(%" PRIu32
4990 ") index is greater than or equal to "
4991 "VkPhysicalDeviceTransformFeedbackPropertiesEXT::maxTransformFeedbackBuffers(%" PRIu32 ").",
4992 cmd_name, firstCounterBuffer, phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers);
4993 }
4994
4995 if (firstCounterBuffer + counterBufferCount > phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers) {
4996 skip |=
4997 LogError(commandBuffer, "VUID-vkCmdBeginTransformFeedbackEXT-firstCounterBuffer-02369",
4998 "%s: The sum of firstCounterBuffer(%" PRIu32 ") and counterBufferCount(%" PRIu32
4999 ") is greater than VkPhysicalDeviceTransformFeedbackPropertiesEXT::maxTransformFeedbackBuffers(%" PRIu32 ").",
5000 cmd_name, firstCounterBuffer, counterBufferCount,
5001 phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers);
5002 }
5003
5004 return skip;
5005}
5006
5007bool StatelessValidation::manual_PreCallValidateCmdEndTransformFeedbackEXT(VkCommandBuffer commandBuffer,
5008 uint32_t firstCounterBuffer, uint32_t counterBufferCount,
5009 const VkBuffer *pCounterBuffers,
5010 const VkDeviceSize *pCounterBufferOffsets) const {
5011 bool skip = false;
5012
5013 char const *const cmd_name = "CmdEndTransformFeedbackEXT";
5014 if (firstCounterBuffer >= phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers) {
5015 skip |= LogError(commandBuffer, "VUID-vkCmdEndTransformFeedbackEXT-firstCounterBuffer-02376",
5016 "%s: The firstCounterBuffer(%" PRIu32
5017 ") index is greater than or equal to "
5018 "VkPhysicalDeviceTransformFeedbackPropertiesEXT::maxTransformFeedbackBuffers(%" PRIu32 ").",
5019 cmd_name, firstCounterBuffer, phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers);
5020 }
5021
5022 if (firstCounterBuffer + counterBufferCount > phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers) {
5023 skip |=
5024 LogError(commandBuffer, "VUID-vkCmdEndTransformFeedbackEXT-firstCounterBuffer-02377",
5025 "%s: The sum of firstCounterBuffer(%" PRIu32 ") and counterBufferCount(%" PRIu32
5026 ") is greater than VkPhysicalDeviceTransformFeedbackPropertiesEXT::maxTransformFeedbackBuffers(%" PRIu32 ").",
5027 cmd_name, firstCounterBuffer, counterBufferCount,
5028 phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers);
5029 }
5030
5031 return skip;
5032}
5033
Mark Lobodzinski953b7bc2019-12-19 13:50:10 -07005034bool StatelessValidation::manual_PreCallValidateCmdDrawIndirectByteCountEXT(VkCommandBuffer commandBuffer, uint32_t instanceCount,
5035 uint32_t firstInstance, VkBuffer counterBuffer,
5036 VkDeviceSize counterBufferOffset,
5037 uint32_t counterOffset, uint32_t vertexStride) const {
5038 bool skip = false;
5039
5040 if ((vertexStride <= 0) || (vertexStride > phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBufferDataStride)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005041 skip |= LogError(
5042 counterBuffer, "VUID-vkCmdDrawIndirectByteCountEXT-vertexStride-02289",
Mark Lobodzinski953b7bc2019-12-19 13:50:10 -07005043 "vkCmdDrawIndirectByteCountEXT: vertexStride (%d) must be between 0 and maxTransformFeedbackBufferDataStride (%d).",
5044 vertexStride, phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBufferDataStride);
5045 }
5046
sfricke-samsungd5e9adb2020-10-26 03:59:29 -07005047 if ((counterOffset % 4) != 0) {
5048 // TODO - Update when header are updated
5049 skip |= LogError(commandBuffer, "UNASSIGNED-vkCmdDrawIndirectByteCountEXT-offset",
5050 "vkCmdDrawIndirectByteCountEXT(): offset (%" PRIu64 ") must be a multiple of 4.", counterOffset);
5051 }
5052
Mark Lobodzinski953b7bc2019-12-19 13:50:10 -07005053 return skip;
5054}
sfricke-samsung11ea8ed2020-01-07 22:24:56 -08005055
5056bool StatelessValidation::ValidateCreateSamplerYcbcrConversion(VkDevice device,
5057 const VkSamplerYcbcrConversionCreateInfo *pCreateInfo,
5058 const VkAllocationCallbacks *pAllocator,
5059 VkSamplerYcbcrConversion *pYcbcrConversion,
5060 const char *apiName) const {
5061 bool skip = false;
5062
5063 // Check samplerYcbcrConversion feature is set
Tony-LunarG6c3c5452019-12-13 10:37:38 -07005064 const auto *ycbcr_features = lvl_find_in_chain<VkPhysicalDeviceSamplerYcbcrConversionFeatures>(device_createinfo_pnext);
sfricke-samsung11ea8ed2020-01-07 22:24:56 -08005065 if ((ycbcr_features == nullptr) || (ycbcr_features->samplerYcbcrConversion == VK_FALSE)) {
Ricardo Garcia3a34ffb2020-06-24 09:36:18 +02005066 const auto *vulkan_11_features = lvl_find_in_chain<VkPhysicalDeviceVulkan11Features>(device_createinfo_pnext);
5067 if ((vulkan_11_features == nullptr) || (vulkan_11_features->samplerYcbcrConversion == VK_FALSE)) {
5068 skip |= LogError(device, "VUID-vkCreateSamplerYcbcrConversion-None-01648",
sfricke-samsung83d98122020-07-04 06:21:15 -07005069 "%s: samplerYcbcrConversion must be enabled.", apiName);
Ricardo Garcia3a34ffb2020-06-24 09:36:18 +02005070 }
sfricke-samsung11ea8ed2020-01-07 22:24:56 -08005071 }
sfricke-samsung83d98122020-07-04 06:21:15 -07005072
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005073#ifdef VK_USE_PLATFORM_ANDROID_KHR
5074 const VkExternalFormatANDROID *pExternalFormatANDROID = lvl_find_in_chain<VkExternalFormatANDROID>(pCreateInfo);
5075 const bool isExternalFormat = pExternalFormatANDROID != nullptr && pExternalFormatANDROID->externalFormat != 0;
5076#else
5077 const bool isExternalFormat = false;
5078#endif
5079
sfricke-samsung1a72f942020-07-25 12:09:18 -07005080 const VkFormat format = pCreateInfo->format;
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005081
5082 // If there is a VkExternalFormatANDROID with externalFormat != 0, the value of components is ignored.
5083 if (!isExternalFormat) {
5084 const VkComponentMapping components = pCreateInfo->components;
5085 // XChroma Subsampled is same as "the format has a _422 or _420 suffix" from spec
5086 if (FormatIsXChromaSubsampled(format) == true) {
5087 if ((components.g != VK_COMPONENT_SWIZZLE_G) && (components.g != VK_COMPONENT_SWIZZLE_IDENTITY)) {
5088 skip |=
5089 LogError(device, "VUID-VkSamplerYcbcrConversionCreateInfo-components-02581",
sfricke-samsung83d98122020-07-04 06:21:15 -07005090 "%s: When using a XChroma subsampled format (%s) the components.g needs to be VK_COMPONENT_SWIZZLE_G "
5091 "or VK_COMPONENT_SWIZZLE_IDENTITY, but is %s.",
sfricke-samsung1a72f942020-07-25 12:09:18 -07005092 apiName, string_VkFormat(format), string_VkComponentSwizzle(components.g));
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005093 }
sfricke-samsung83d98122020-07-04 06:21:15 -07005094
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005095 if ((components.a != VK_COMPONENT_SWIZZLE_A) && (components.a != VK_COMPONENT_SWIZZLE_IDENTITY) &&
5096 (components.a != VK_COMPONENT_SWIZZLE_ONE) && (components.a != VK_COMPONENT_SWIZZLE_ZERO)) {
5097 skip |= LogError(
5098 device, "VUID-VkSamplerYcbcrConversionCreateInfo-components-02582",
5099 "%s: When using a XChroma subsampled format (%s) the components.a needs to be VK_COMPONENT_SWIZZLE_A or "
5100 "VK_COMPONENT_SWIZZLE_IDENTITY or VK_COMPONENT_SWIZZLE_ONE or VK_COMPONENT_SWIZZLE_ZERO, but is %s.",
5101 apiName, string_VkFormat(format), string_VkComponentSwizzle(components.a));
5102 }
sfricke-samsung83d98122020-07-04 06:21:15 -07005103
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005104 if ((components.r != VK_COMPONENT_SWIZZLE_R) && (components.r != VK_COMPONENT_SWIZZLE_IDENTITY) &&
5105 (components.r != VK_COMPONENT_SWIZZLE_B)) {
5106 skip |=
5107 LogError(device, "VUID-VkSamplerYcbcrConversionCreateInfo-components-02583",
sfricke-samsung83d98122020-07-04 06:21:15 -07005108 "%s: When using a XChroma subsampled format (%s) the components.r needs to be VK_COMPONENT_SWIZZLE_R "
5109 "or VK_COMPONENT_SWIZZLE_IDENTITY or VK_COMPONENT_SWIZZLE_B, but is %s.",
sfricke-samsung1a72f942020-07-25 12:09:18 -07005110 apiName, string_VkFormat(format), string_VkComponentSwizzle(components.r));
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005111 }
sfricke-samsung83d98122020-07-04 06:21:15 -07005112
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005113 if ((components.b != VK_COMPONENT_SWIZZLE_B) && (components.b != VK_COMPONENT_SWIZZLE_IDENTITY) &&
5114 (components.b != VK_COMPONENT_SWIZZLE_R)) {
5115 skip |=
5116 LogError(device, "VUID-VkSamplerYcbcrConversionCreateInfo-components-02584",
sfricke-samsung83d98122020-07-04 06:21:15 -07005117 "%s: When using a XChroma subsampled format (%s) the components.b needs to be VK_COMPONENT_SWIZZLE_B "
5118 "or VK_COMPONENT_SWIZZLE_IDENTITY or VK_COMPONENT_SWIZZLE_R, but is %s.",
sfricke-samsung1a72f942020-07-25 12:09:18 -07005119 apiName, string_VkFormat(format), string_VkComponentSwizzle(components.b));
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005120 }
sfricke-samsung83d98122020-07-04 06:21:15 -07005121
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005122 // If one is identity, both need to be
5123 const bool rIdentity = ((components.r == VK_COMPONENT_SWIZZLE_R) || (components.r == VK_COMPONENT_SWIZZLE_IDENTITY));
5124 const bool bIdentity = ((components.b == VK_COMPONENT_SWIZZLE_B) || (components.b == VK_COMPONENT_SWIZZLE_IDENTITY));
5125 if ((rIdentity != bIdentity) && ((rIdentity == true) || (bIdentity == true))) {
5126 skip |=
5127 LogError(device, "VUID-VkSamplerYcbcrConversionCreateInfo-components-02585",
sfricke-samsung83d98122020-07-04 06:21:15 -07005128 "%s: When using a XChroma subsampled format (%s) if either the components.r (%s) or components.b (%s) "
5129 "are an identity swizzle, then both need to be an identity swizzle.",
sfricke-samsung1a72f942020-07-25 12:09:18 -07005130 apiName, string_VkFormat(format), string_VkComponentSwizzle(components.r),
5131 string_VkComponentSwizzle(components.b));
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005132 }
sfricke-samsung1a72f942020-07-25 12:09:18 -07005133 }
5134
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005135 if (pCreateInfo->ycbcrModel != VK_SAMPLER_YCBCR_MODEL_CONVERSION_RGB_IDENTITY) {
5136 // Checks same VU multiple ways in order to give a more useful error message
5137 const char *vuid = "VUID-VkSamplerYcbcrConversionCreateInfo-ycbcrModel-01655";
5138 if ((components.r == VK_COMPONENT_SWIZZLE_ONE) || (components.r == VK_COMPONENT_SWIZZLE_ZERO) ||
5139 (components.g == VK_COMPONENT_SWIZZLE_ONE) || (components.g == VK_COMPONENT_SWIZZLE_ZERO) ||
5140 (components.b == VK_COMPONENT_SWIZZLE_ONE) || (components.b == VK_COMPONENT_SWIZZLE_ZERO)) {
5141 skip |= LogError(
5142 device, vuid,
5143 "%s: The ycbcrModel is not VK_SAMPLER_YCBCR_MODEL_CONVERSION_RGB_IDENTITY so components.r (%s), "
5144 "components.g (%s), nor components.b (%s) can't be VK_COMPONENT_SWIZZLE_ZERO or VK_COMPONENT_SWIZZLE_ONE.",
5145 apiName, string_VkComponentSwizzle(components.r), string_VkComponentSwizzle(components.g),
5146 string_VkComponentSwizzle(components.b));
5147 }
sfricke-samsung1a72f942020-07-25 12:09:18 -07005148
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005149 // "must not correspond to a channel which contains zero or one as a consequence of conversion to RGBA"
5150 // 4 channel format = no issue
5151 // 3 = no [a]
5152 // 2 = no [b,a]
5153 // 1 = no [g,b,a]
5154 // depth/stencil = no [g,b,a] (shouldn't ever occur, but no VU preventing it)
5155 const uint32_t channels = (FormatIsDepthOrStencil(format) == true) ? 1 : FormatChannelCount(format);
5156
5157 if ((channels < 4) && ((components.r == VK_COMPONENT_SWIZZLE_A) || (components.g == VK_COMPONENT_SWIZZLE_A) ||
5158 (components.b == VK_COMPONENT_SWIZZLE_A))) {
5159 skip |= LogError(device, vuid,
5160 "%s: The ycbcrModel is not VK_SAMPLER_YCBCR_MODEL_CONVERSION_RGB_IDENTITY so components.r (%s), "
5161 "components.g (%s), or components.b (%s) can't be VK_COMPONENT_SWIZZLE_A.",
5162 apiName, string_VkComponentSwizzle(components.r), string_VkComponentSwizzle(components.g),
5163 string_VkComponentSwizzle(components.b));
5164 } else if ((channels < 3) &&
5165 ((components.r == VK_COMPONENT_SWIZZLE_B) || (components.g == VK_COMPONENT_SWIZZLE_B) ||
5166 (components.b == VK_COMPONENT_SWIZZLE_B) || (components.b == VK_COMPONENT_SWIZZLE_IDENTITY))) {
5167 skip |= LogError(device, vuid,
5168 "%s: The ycbcrModel is not VK_SAMPLER_YCBCR_MODEL_CONVERSION_RGB_IDENTITY so components.r (%s), "
5169 "components.g (%s), or components.b (%s) can't be VK_COMPONENT_SWIZZLE_B "
5170 "(components.b also can't be VK_COMPONENT_SWIZZLE_IDENTITY).",
5171 apiName, string_VkComponentSwizzle(components.r), string_VkComponentSwizzle(components.g),
5172 string_VkComponentSwizzle(components.b));
5173 } else if ((channels < 2) &&
5174 ((components.r == VK_COMPONENT_SWIZZLE_G) || (components.g == VK_COMPONENT_SWIZZLE_G) ||
5175 (components.g == VK_COMPONENT_SWIZZLE_IDENTITY) || (components.b == VK_COMPONENT_SWIZZLE_G))) {
5176 skip |= LogError(device, vuid,
5177 "%s: The ycbcrModel is not VK_SAMPLER_YCBCR_MODEL_CONVERSION_RGB_IDENTITY so components.r (%s), "
5178 "components.g (%s), or components.b (%s) can't be VK_COMPONENT_SWIZZLE_G "
5179 "(components.g also can't be VK_COMPONENT_SWIZZLE_IDENTITY).",
5180 apiName, string_VkComponentSwizzle(components.r), string_VkComponentSwizzle(components.g),
5181 string_VkComponentSwizzle(components.b));
5182 }
sfricke-samsung83d98122020-07-04 06:21:15 -07005183 }
5184 }
5185
sfricke-samsung11ea8ed2020-01-07 22:24:56 -08005186 return skip;
5187}
5188
5189bool StatelessValidation::manual_PreCallValidateCreateSamplerYcbcrConversion(VkDevice device,
5190 const VkSamplerYcbcrConversionCreateInfo *pCreateInfo,
5191 const VkAllocationCallbacks *pAllocator,
5192 VkSamplerYcbcrConversion *pYcbcrConversion) const {
5193 return ValidateCreateSamplerYcbcrConversion(device, pCreateInfo, pAllocator, pYcbcrConversion,
5194 "vkCreateSamplerYcbcrConversion");
5195}
5196
5197bool StatelessValidation::manual_PreCallValidateCreateSamplerYcbcrConversionKHR(
5198 VkDevice device, const VkSamplerYcbcrConversionCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
5199 VkSamplerYcbcrConversion *pYcbcrConversion) const {
5200 return ValidateCreateSamplerYcbcrConversion(device, pCreateInfo, pAllocator, pYcbcrConversion,
5201 "vkCreateSamplerYcbcrConversionKHR");
5202}
sfricke-samsung1708a8c2020-02-10 00:35:06 -08005203
5204bool StatelessValidation::manual_PreCallValidateImportSemaphoreFdKHR(
5205 VkDevice device, const VkImportSemaphoreFdInfoKHR *pImportSemaphoreFdInfo) const {
5206 bool skip = false;
5207 VkExternalSemaphoreHandleTypeFlags supported_handle_types =
5208 VK_EXTERNAL_SEMAPHORE_HANDLE_TYPE_OPAQUE_FD_BIT | VK_EXTERNAL_SEMAPHORE_HANDLE_TYPE_SYNC_FD_BIT;
5209
5210 if (0 == (pImportSemaphoreFdInfo->handleType & supported_handle_types)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005211 skip |= LogError(device, "VUID-VkImportSemaphoreFdInfoKHR-handleType-01143",
5212 "vkImportSemaphoreFdKHR() to semaphore %s handleType %s is not one of the supported handleTypes (%s).",
5213 report_data->FormatHandle(pImportSemaphoreFdInfo->semaphore).c_str(),
5214 string_VkExternalSemaphoreHandleTypeFlagBits(pImportSemaphoreFdInfo->handleType),
5215 string_VkExternalSemaphoreHandleTypeFlags(supported_handle_types).c_str());
sfricke-samsung1708a8c2020-02-10 00:35:06 -08005216 }
5217 return skip;
5218}
sourav parmara96ab1a2020-04-25 16:28:23 -07005219
5220bool StatelessValidation::manual_PreCallValidateCopyAccelerationStructureToMemoryKHR(
5221 VkDevice device, const VkCopyAccelerationStructureToMemoryInfoKHR *pInfo) const {
5222 bool skip = false;
sourav parmar83c31b12020-05-06 12:30:54 -07005223 const auto *raytracing_features = lvl_find_in_chain<VkPhysicalDeviceRayTracingFeaturesKHR>(device_createinfo_pnext);
5224 if (!raytracing_features || raytracing_features->rayTracingHostAccelerationStructureCommands == VK_FALSE) {
5225 skip |=
5226 LogError(device, "", "VUID-vkCopyAccelerationStructureToMemoryKHR-rayTracingHostAccelerationStructureCommands-03447",
5227 "vkCopyAccelerationStructureToMemoryKHR: the "
5228 "VkPhysicalDeviceRayTracingFeaturesKHR::rayTracingHostAccelerationStructureCommands feature must be enabled.");
5229 }
sourav parmara96ab1a2020-04-25 16:28:23 -07005230 if (pInfo->mode != VK_COPY_ACCELERATION_STRUCTURE_MODE_SERIALIZE_KHR) {
5231 skip |= LogError(device, "VUID-VkCopyAccelerationStructureToMemoryInfoKHR-mode-03412",
5232 "vkCopyAccelerationStructureToMemoryKHR: mode must be VK_COPY_ACCELERATION_STRUCTURE_MODE_SERIALIZE_KHR.");
5233 }
5234 return skip;
5235}
5236
5237bool StatelessValidation::manual_PreCallValidateCmdCopyAccelerationStructureToMemoryKHR(
5238 VkCommandBuffer commandBuffer, const VkCopyAccelerationStructureToMemoryInfoKHR *pInfo) const {
5239 bool skip = false;
5240 if (pInfo->mode != VK_COPY_ACCELERATION_STRUCTURE_MODE_SERIALIZE_KHR) {
5241 skip |= // to update VUID to VkCmdCopyAccelerationStructureToMemoryInfoKHR after spec update
5242 LogError(commandBuffer, "VUID-VkCopyAccelerationStructureToMemoryInfoKHR-mode-03412",
5243 "vkCmdCopyAccelerationStructureToMemoryKHR: mode must be VK_COPY_ACCELERATION_STRUCTURE_MODE_SERIALIZE_KHR.");
5244 }
Mark Lobodzinski17dc4602020-05-29 07:48:40 -06005245 const auto *pnext_struct = lvl_find_in_chain<VkDeferredOperationInfoKHR>(pInfo->pNext);
5246 if (pnext_struct) {
sourav parmar83c31b12020-05-06 12:30:54 -07005247 skip |= LogError(
5248 commandBuffer, "VUID-vkCmdCopyAccelerationStructureToMemoryKHR-pNext-03560",
5249 "vkCmdCopyAccelerationStructureToMemoryKHR: The VkDeferredOperationInfoKHR structure must not be included in the"
5250 "pNext chain of the VkCopyAccelerationStructureToMemoryInfoKHR structure.");
5251 }
sourav parmara96ab1a2020-04-25 16:28:23 -07005252 return skip;
5253}
5254
5255bool StatelessValidation::ValidateCopyAccelerationStructureInfoKHR(const VkCopyAccelerationStructureInfoKHR *pInfo,
5256 const char *api_name) const {
5257 bool skip = false;
5258 if (!(pInfo->mode == VK_COPY_ACCELERATION_STRUCTURE_MODE_COMPACT_KHR ||
5259 pInfo->mode == VK_COPY_ACCELERATION_STRUCTURE_MODE_CLONE_KHR)) {
5260 skip |= LogError(device, "VUID-VkCopyAccelerationStructureInfoKHR-mode-03410",
5261 "(%s): mode must be VK_COPY_ACCELERATION_STRUCTURE_MODE_COMPACT_KHR"
5262 "or VK_COPY_ACCELERATION_STRUCTURE_MODE_CLONE_KHR.",
5263 api_name);
5264 }
5265 return skip;
5266}
5267
5268bool StatelessValidation::manual_PreCallValidateCopyAccelerationStructureKHR(
5269 VkDevice device, const VkCopyAccelerationStructureInfoKHR *pInfo) const {
5270 bool skip = false;
5271 skip |= ValidateCopyAccelerationStructureInfoKHR(pInfo, "vkCopyAccelerationStructureKHR()");
sourav parmar83c31b12020-05-06 12:30:54 -07005272 const auto *raytracing_features = lvl_find_in_chain<VkPhysicalDeviceRayTracingFeaturesKHR>(device_createinfo_pnext);
5273 if (!raytracing_features || raytracing_features->rayTracingHostAccelerationStructureCommands == VK_FALSE) {
5274 skip |= LogError(
5275 device, "VUID-vkCopyAccelerationStructureKHR-rayTracingHostAccelerationStructureCommands-03441",
5276 "vkCopyAccelerationStructureKHR(): the "
5277 "VkPhysicalDeviceRayTracingFeaturesKHR::rayTracingHostAccelerationStructureCommands feature must be enabled .");
5278 }
sourav parmara96ab1a2020-04-25 16:28:23 -07005279 return skip;
5280}
5281
5282bool StatelessValidation::manual_PreCallValidateCmdCopyAccelerationStructureKHR(
5283 VkCommandBuffer commandBuffer, const VkCopyAccelerationStructureInfoKHR *pInfo) const {
5284 bool skip = false;
Mark Lobodzinski17dc4602020-05-29 07:48:40 -06005285 const auto *pnext_struct = lvl_find_in_chain<VkDeferredOperationInfoKHR>(pInfo->pNext);
5286 if (pnext_struct) {
sourav parmar83c31b12020-05-06 12:30:54 -07005287 skip |= LogError(device, "VUID-vkCmdCopyAccelerationStructureKHR-pNext-03557",
5288 "vkCmdCopyAccelerationStructureKHR(): The VkDeferredOperationInfoKHR structure must not be included in "
5289 "the pNext chain of the VkCopyAccelerationStructureInfoKHR structure.");
5290 }
sourav parmara96ab1a2020-04-25 16:28:23 -07005291 skip |= ValidateCopyAccelerationStructureInfoKHR(pInfo, "vkCmdCopyAccelerationStructureKHR()");
5292 return skip;
5293}
5294
5295bool StatelessValidation::ValidateCopyMemoryToAccelerationStructureInfoKHR(const VkCopyMemoryToAccelerationStructureInfoKHR *pInfo,
Mark Lobodzinskiaad69e42020-05-12 08:44:21 -06005296 const char *api_name, bool is_cmd) const {
sourav parmara96ab1a2020-04-25 16:28:23 -07005297 bool skip = false;
5298 if (pInfo->mode != VK_COPY_ACCELERATION_STRUCTURE_MODE_DESERIALIZE_KHR) {
sourav parmar83c31b12020-05-06 12:30:54 -07005299 skip |= LogError(device,
Mark Lobodzinskiaad69e42020-05-12 08:44:21 -06005300 is_cmd ? "VUID-vkCmdCopyMemoryToAccelerationStructureKHR-mode-03413"
Shannon McPhersonafe55122020-05-25 16:20:19 -06005301 : "VUID-VkCopyMemoryToAccelerationStructureInfoKHR-mode-03413",
sourav parmara96ab1a2020-04-25 16:28:23 -07005302 "(%s): mode must be VK_COPY_ACCELERATION_STRUCTURE_MODE_DESERIALIZE_KHR.", api_name);
5303 }
5304 return skip;
5305}
5306
5307bool StatelessValidation::manual_PreCallValidateCopyMemoryToAccelerationStructureKHR(
5308 VkDevice device, const VkCopyMemoryToAccelerationStructureInfoKHR *pInfo) const {
5309 bool skip = false;
sourav parmar83c31b12020-05-06 12:30:54 -07005310 skip |= ValidateCopyMemoryToAccelerationStructureInfoKHR(pInfo, "vkCopyMemoryToAccelerationStructureKHR()", true);
5311 const auto *raytracing_features = lvl_find_in_chain<VkPhysicalDeviceRayTracingFeaturesKHR>(device_createinfo_pnext);
5312 if (!raytracing_features || raytracing_features->rayTracingHostAccelerationStructureCommands == VK_FALSE) {
5313 skip |=
5314 LogError(device, "VUID-vkCopyMemoryToAccelerationStructureKHR-rayTracingHostAccelerationStructureCommands-03444",
5315 "vkCopyMemoryToAccelerationStructureKHR() :the "
5316 "VkPhysicalDeviceRayTracingFeaturesKHR::rayTracingHostAccelerationStructureCommands feature must be enabled.");
5317 }
sourav parmara96ab1a2020-04-25 16:28:23 -07005318 return skip;
5319}
Jeremy Hayes9bda85a2020-05-21 16:36:17 -06005320
sourav parmara96ab1a2020-04-25 16:28:23 -07005321bool StatelessValidation::manual_PreCallValidateCmdCopyMemoryToAccelerationStructureKHR(
5322 VkCommandBuffer commandBuffer, const VkCopyMemoryToAccelerationStructureInfoKHR *pInfo) const {
5323 bool skip = false;
Mark Lobodzinski17dc4602020-05-29 07:48:40 -06005324 const auto *pnext_struct = lvl_find_in_chain<VkDeferredOperationInfoKHR>(pInfo->pNext);
5325 if (pnext_struct) {
sourav parmara24fb7b2020-05-26 10:50:04 -07005326 skip |= LogError(device, "VUID-vkCmdCopyMemoryToAccelerationStructureKHR-pNext-03564",
5327 "vkCmdCopyMemoryToAccelerationStructureKHR: The VkDeferredOperationInfoKHR structure must"
5328 "not be included in the pNext chain of the VkCopyMemoryToAccelerationStructureInfoKHR structure.");
5329 }
sourav parmar83c31b12020-05-06 12:30:54 -07005330 skip |= ValidateCopyMemoryToAccelerationStructureInfoKHR(pInfo, "vkCmdCopyMemoryToAccelerationStructureKHR()", false);
5331 return skip;
5332}
5333bool StatelessValidation::manual_PreCallValidateCmdWriteAccelerationStructuresPropertiesKHR(
5334 VkCommandBuffer commandBuffer, uint32_t accelerationStructureCount, const VkAccelerationStructureKHR *pAccelerationStructures,
5335 VkQueryType queryType, VkQueryPool queryPool, uint32_t firstQuery) const {
5336 bool skip = false;
5337 if (!(queryType == VK_QUERY_TYPE_ACCELERATION_STRUCTURE_COMPACTED_SIZE_KHR ||
5338 queryType == VK_QUERY_TYPE_ACCELERATION_STRUCTURE_SERIALIZATION_SIZE_KHR)) {
5339 skip |= LogError(device, "VUID-vkCmdWriteAccelerationStructuresPropertiesKHR-queryType-03432",
5340 "vkCmdWriteAccelerationStructuresPropertiesKHR: queryType must be "
5341 "VK_QUERY_TYPE_ACCELERATION_STRUCTURE_COMPACTED_SIZE_KHR or "
5342 "VK_QUERY_TYPE_ACCELERATION_STRUCTURE_SERIALIZATION_SIZE_KHR.");
5343 }
5344 return skip;
5345}
5346bool StatelessValidation::manual_PreCallValidateWriteAccelerationStructuresPropertiesKHR(
5347 VkDevice device, uint32_t accelerationStructureCount, const VkAccelerationStructureKHR *pAccelerationStructures,
5348 VkQueryType queryType, size_t dataSize, void *pData, size_t stride) const {
5349 bool skip = false;
5350 if (dataSize < accelerationStructureCount * stride) {
5351 skip |= LogError(device, "VUID-vkWriteAccelerationStructuresPropertiesKHR-dataSize-03452",
5352 "vkWriteAccelerationStructuresPropertiesKHR: dataSize (%zu) must be greater than or equal to "
5353 "accelerationStructureCount (%d) *stride(%zu).",
5354 dataSize, accelerationStructureCount, stride);
5355 }
5356 if (!(queryType == VK_QUERY_TYPE_ACCELERATION_STRUCTURE_COMPACTED_SIZE_KHR ||
5357 queryType == VK_QUERY_TYPE_ACCELERATION_STRUCTURE_SERIALIZATION_SIZE_KHR)) {
5358 skip |= LogError(device, "VUID-vkWriteAccelerationStructuresPropertiesKHR-queryType-03432",
5359 "vkWriteAccelerationStructuresPropertiesKHR: queryType must be "
5360 "VK_QUERY_TYPE_ACCELERATION_STRUCTURE_COMPACTED_SIZE_KHR or "
5361 "VK_QUERY_TYPE_ACCELERATION_STRUCTURE_SERIALIZATION_SIZE_KHR.");
5362 }
5363 if (queryType == VK_QUERY_TYPE_ACCELERATION_STRUCTURE_COMPACTED_SIZE_KHR) {
5364 if (SafeModulo(stride, sizeof(VkDeviceSize)) != 0) {
5365 skip |= LogError(device, "VUID-vkWriteAccelerationStructuresPropertiesKHR-queryType-03448",
5366 "vkWriteAccelerationStructuresPropertiesKHR: If queryType is "
5367 "VK_QUERY_TYPE_ACCELERATION_STRUCTURE_COMPACTED_SIZE_KHR,"
5368 "then stride (%zu) must be a multiple of the size of VkDeviceSize",
5369 stride);
5370 }
5371 }
5372 if (queryType == VK_QUERY_TYPE_ACCELERATION_STRUCTURE_SERIALIZATION_SIZE_KHR) {
5373 if (SafeModulo(stride, sizeof(VkDeviceSize)) != 0) {
5374 skip |= LogError(device, "VUID-vkWriteAccelerationStructuresPropertiesKHR-queryType-03450",
5375 "vkWriteAccelerationStructuresPropertiesKHR: If queryType is "
5376 "VK_QUERY_TYPE_ACCELERATION_STRUCTURE_SERIALIZATION_SIZE_KHR,"
5377 "then stride (%zu) must be a multiple of the size of VkDeviceSize",
5378 stride);
5379 }
5380 }
5381 const auto *raytracing_features = lvl_find_in_chain<VkPhysicalDeviceRayTracingFeaturesKHR>(device_createinfo_pnext);
5382 if (!raytracing_features || raytracing_features->rayTracingHostAccelerationStructureCommands == VK_FALSE) {
5383 skip |=
5384 LogError(device, "VUID-vkWriteAccelerationStructuresPropertiesKHR-rayTracingHostAccelerationStructureCommands-03454",
5385 "vkWriteAccelerationStructuresPropertiesKHR: the "
5386 "vkPhysicalDeviceRayTracingFeaturesKHR::rayTracingHostAccelerationStructureCommands"
5387 "feature must be enabled ");
5388 }
5389 return skip;
5390}
5391bool StatelessValidation::manual_PreCallValidateGetRayTracingCaptureReplayShaderGroupHandlesKHR(
5392 VkDevice device, VkPipeline pipeline, uint32_t firstGroup, uint32_t groupCount, size_t dataSize, void *pData) const {
5393 bool skip = false;
5394 const auto *raytracing_features = lvl_find_in_chain<VkPhysicalDeviceRayTracingFeaturesKHR>(device_createinfo_pnext);
5395 if (!raytracing_features || raytracing_features->rayTracingShaderGroupHandleCaptureReplay == VK_FALSE) {
5396 skip |= LogError(device,
5397 "VUID-vkGetRayTracingCaptureReplayShaderGroupHandlesKHR-rayTracingShaderGroupHandleCaptureReplay-03485",
5398 "vkGetRayTracingCaptureReplayShaderGroupHandlesKHR: "
5399 "VkPhysicalDeviceRayTracingFeaturesKHR::rayTracingShaderGroupHandleCaptureReplay"
5400 "must be enabled to call this function.");
5401 }
5402 return skip;
5403}
5404
5405bool StatelessValidation::manual_PreCallValidateCmdTraceRaysKHR(VkCommandBuffer commandBuffer,
5406 const VkStridedBufferRegionKHR *pRaygenShaderBindingTable,
5407 const VkStridedBufferRegionKHR *pMissShaderBindingTable,
5408 const VkStridedBufferRegionKHR *pHitShaderBindingTable,
5409 const VkStridedBufferRegionKHR *pCallableShaderBindingTable,
5410 uint32_t width, uint32_t height, uint32_t depth) const {
5411 bool skip = false;
5412 if (SafeModulo(pCallableShaderBindingTable->offset, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) != 0) {
5413 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-offset-04038",
5414 "vkCmdTraceRaysKHR: The offset member of pCallableShaderBindingTable"
5415 "must be a multiple of VkPhysicalDeviceRayTracingPropertiesKHR::shaderGroupBaseAlignment.");
5416 }
5417 if (SafeModulo(pCallableShaderBindingTable->stride, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupHandleSize) != 0) {
5418 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-stride-04040",
5419 "vkCmdTraceRaysKHR: The stride member of pCallableShaderBindingTable must be a multiple"
5420 "of VkPhysicalDeviceRayTracingPropertiesKHR::shaderGroupHandleSize.");
5421 }
5422 if (pCallableShaderBindingTable->stride > phys_dev_ext_props.ray_tracing_propsKHR.maxShaderGroupStride) {
5423 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-stride-04041",
5424 "vkCmdTraceRaysKHR: The stride member of pCallableShaderBindingTable must be"
5425 "less than or equal to VkPhysicalDeviceRayTracingPropertiesKHR::maxShaderGroupStride.");
5426 }
5427 // hitShader
5428 if (SafeModulo(pHitShaderBindingTable->offset, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) != 0) {
5429 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-offset-04032",
5430 "vkCmdTraceRaysKHR: The offset member of pHitShaderBindingTable must be a multiple"
5431 "of VkPhysicalDeviceRayTracingPropertiesKHR::shaderGroupBaseAlignment.");
5432 }
5433 if (SafeModulo(pHitShaderBindingTable->stride, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupHandleSize) != 0) {
5434 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-stride-04034",
5435 "vkCmdTraceRaysKHR: The stride member of pHitShaderBindingTable must be a multiple"
5436 "of VkPhysicalDeviceRayTracingPropertiesKHR::shaderGroupHandleSize.");
5437 }
5438 if (pHitShaderBindingTable->stride > phys_dev_ext_props.ray_tracing_propsKHR.maxShaderGroupStride) {
5439 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-stride-04035",
5440 "vkCmdTraceRaysKHR: The stride member of pHitShaderBindingTable must be"
5441 "less than or equal to VkPhysicalDeviceRayTracingPropertiesKHR::maxShaderGroupStride.");
5442 }
5443
5444 // missShader
5445 if (SafeModulo(pMissShaderBindingTable->offset, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) != 0) {
5446 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-offset-04026",
5447 "vkCmdTraceRaysKHR: The offset member of pMissShaderBindingTable must be a multiple"
5448 "of VkPhysicalDeviceRayTracingPropertiesKHR::shaderGroupBaseAlignment.");
5449 }
5450 if (SafeModulo(pMissShaderBindingTable->stride, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupHandleSize) != 0) {
5451 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-stride-04028",
5452 "vkCmdTraceRaysKHR: The stride member of pMissShaderBindingTable must be a multiple"
5453 "of VkPhysicalDeviceRayTracingPropertiesKHR::shaderGroupHandleSize.");
5454 }
5455 if (pMissShaderBindingTable->stride > phys_dev_ext_props.ray_tracing_propsKHR.maxShaderGroupStride) {
5456 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-stride-04029",
5457 "vkCmdTraceRaysKHR: The stride member of pMissShaderBindingTable must be"
5458 "less than or equal to VkPhysicalDeviceRayTracingPropertiesKHR::maxShaderGroupStride.");
5459 }
5460
5461 // raygenShader
5462 if (SafeModulo(pRaygenShaderBindingTable->offset, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) != 0) {
5463 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-pRayGenShaderBindingTable-04021",
5464 "vkCmdTraceRaysKHR: pRayGenShaderBindingTable->offset must be a multiple"
5465 "of VkPhysicalDeviceRayTracingPropertiesKHR::shaderGroupBaseAlignment.");
5466 }
5467 return skip;
5468}
5469
5470bool StatelessValidation::manual_PreCallValidateCmdTraceRaysIndirectKHR(VkCommandBuffer commandBuffer,
5471 const VkStridedBufferRegionKHR *pRaygenShaderBindingTable,
5472 const VkStridedBufferRegionKHR *pMissShaderBindingTable,
5473 const VkStridedBufferRegionKHR *pHitShaderBindingTable,
5474 const VkStridedBufferRegionKHR *pCallableShaderBindingTable,
5475 VkBuffer buffer, VkDeviceSize offset) const {
5476 bool skip = false;
5477 const auto *raytracing_features = lvl_find_in_chain<VkPhysicalDeviceRayTracingFeaturesKHR>(device_createinfo_pnext);
5478 if (!raytracing_features || raytracing_features->rayTracingIndirectTraceRays == VK_FALSE) {
5479 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-rayTracingIndirectTraceRays-03518",
5480 "vkCmdTraceRaysIndirectKHR: the VkPhysicalDeviceRayTracingFeaturesKHR::rayTracingIndirectTraceRays "
5481 "feature must be enabled.");
5482 }
5483 if (SafeModulo(pCallableShaderBindingTable->offset, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) != 0) {
5484 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-offset-04038",
5485 "vkCmdTraceRaysIndirectKHR: The offset member of pCallableShaderBindingTable"
5486 "must be a multiple of VkPhysicalDeviceRayTracingPropertiesKHR::shaderGroupBaseAlignment.");
5487 }
5488 if (SafeModulo(pCallableShaderBindingTable->stride, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupHandleSize) != 0) {
5489 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-stride-04040",
5490 "vkCmdTraceRaysIndirectKHR: The stride member of pCallableShaderBindingTable must be a multiple"
5491 "of VkPhysicalDeviceRayTracingPropertiesKHR::shaderGroupHandleSize.");
5492 }
5493 if (pCallableShaderBindingTable->stride > phys_dev_ext_props.ray_tracing_propsKHR.maxShaderGroupStride) {
5494 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-stride-04041",
5495 "vkCmdTraceRaysIndirectKHR: The stride member of pCallableShaderBindingTable must be"
5496 "less than or equal to VkPhysicalDeviceRayTracingPropertiesKHR::maxShaderGroupStride.");
5497 }
5498 // hitShader
5499 if (SafeModulo(pHitShaderBindingTable->offset, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) != 0) {
5500 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-offset-04032",
5501 "vkCmdTraceRaysIndirectKHR: The offset member of pHitShaderBindingTable must be a multiple"
5502 "of VkPhysicalDeviceRayTracingPropertiesKHR::shaderGroupBaseAlignment.");
5503 }
5504 if (SafeModulo(pHitShaderBindingTable->stride, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupHandleSize) != 0) {
5505 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-stride-04034",
5506 "vkCmdTraceRaysIndirectKHR: The stride member of pHitShaderBindingTable must be a multiple"
5507 "of VkPhysicalDeviceRayTracingPropertiesKHR::shaderGroupHandleSize.");
5508 }
5509 if (pHitShaderBindingTable->stride > phys_dev_ext_props.ray_tracing_propsKHR.maxShaderGroupStride) {
5510 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-stride-04035",
5511 "vkCmdTraceRaysIndirectKHR: The stride member of pHitShaderBindingTable must be"
5512 "less than or equal to VkPhysicalDeviceRayTracingPropertiesKHR::maxShaderGroupStride.");
5513 }
5514
5515 // missShader
5516 if (SafeModulo(pMissShaderBindingTable->offset, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) != 0) {
5517 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-offset-04026",
5518 "vkCmdTraceRaysIndirectKHR: The offset member of pMissShaderBindingTable must be a multiple"
5519 "of VkPhysicalDeviceRayTracingPropertiesKHR::shaderGroupBaseAlignment.");
5520 }
5521 if (SafeModulo(pMissShaderBindingTable->stride, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupHandleSize) != 0) {
5522 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-stride-04028",
5523 "vkCmdTraceRaysIndirectKHR: The stride member of pMissShaderBindingTable must be a multiple"
5524 "of VkPhysicalDeviceRayTracingPropertiesKHR::shaderGroupHandleSize.");
5525 }
5526 if (pMissShaderBindingTable->stride > phys_dev_ext_props.ray_tracing_propsKHR.maxShaderGroupStride) {
5527 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-stride-04029",
5528 "vkCmdTraceRaysIndirectKHR: The stride member of pMissShaderBindingTable must be"
5529 "less than or equal to VkPhysicalDeviceRayTracingPropertiesKHR::maxShaderGroupStride.");
5530 }
5531
5532 // raygenShader
5533 if (SafeModulo(pRaygenShaderBindingTable->offset, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) != 0) {
5534 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-pRayGenShaderBindingTable-04021",
5535 "vkCmdTraceRaysIndirectKHR: pRayGenShaderBindingTable->offset must be a multiple"
5536 "of VkPhysicalDeviceRayTracingPropertiesKHR::shaderGroupBaseAlignment.");
5537 }
5538 return skip;
5539}
5540bool StatelessValidation::manual_PreCallValidateCmdTraceRaysNV(
5541 VkCommandBuffer commandBuffer, VkBuffer raygenShaderBindingTableBuffer, VkDeviceSize raygenShaderBindingOffset,
5542 VkBuffer missShaderBindingTableBuffer, VkDeviceSize missShaderBindingOffset, VkDeviceSize missShaderBindingStride,
5543 VkBuffer hitShaderBindingTableBuffer, VkDeviceSize hitShaderBindingOffset, VkDeviceSize hitShaderBindingStride,
5544 VkBuffer callableShaderBindingTableBuffer, VkDeviceSize callableShaderBindingOffset, VkDeviceSize callableShaderBindingStride,
5545 uint32_t width, uint32_t height, uint32_t depth) const {
5546 bool skip = false;
5547 if (SafeModulo(callableShaderBindingOffset, phys_dev_ext_props.ray_tracing_propsNV.shaderGroupBaseAlignment) != 0) {
5548 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-callableShaderBindingOffset-02462",
5549 "vkCmdTraceRaysNV: callableShaderBindingOffset must be a multiple of "
5550 "VkPhysicalDeviceRayTracingPropertiesNV::shaderGroupBaseAlignment.");
5551 }
5552 if (SafeModulo(callableShaderBindingStride, phys_dev_ext_props.ray_tracing_propsNV.shaderGroupHandleSize) != 0) {
5553 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-callableShaderBindingStride-02465",
5554 "vkCmdTraceRaysNV: callableShaderBindingStride must be a multiple of "
5555 "VkPhysicalDeviceRayTracingPropertiesNV::shaderGroupHandleSize.");
5556 }
5557 if (callableShaderBindingStride > phys_dev_ext_props.ray_tracing_propsNV.maxShaderGroupStride) {
5558 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-callableShaderBindingStride-02468",
5559 "vkCmdTraceRaysNV: callableShaderBindingStride must be less than or equal to "
5560 "VkPhysicalDeviceRayTracingPropertiesNV::maxShaderGroupStride. ");
5561 }
5562
5563 // hitShader
5564 if (SafeModulo(hitShaderBindingOffset, phys_dev_ext_props.ray_tracing_propsNV.shaderGroupBaseAlignment) != 0) {
5565 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-hitShaderBindingOffset-02460",
5566 "vkCmdTraceRaysNV: hitShaderBindingOffset must be a multiple of "
5567 "VkPhysicalDeviceRayTracingPropertiesNV::shaderGroupBaseAlignment.");
5568 }
5569 if (SafeModulo(hitShaderBindingStride, phys_dev_ext_props.ray_tracing_propsNV.shaderGroupHandleSize) != 0) {
5570 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-hitShaderBindingStride-02464",
5571 "vkCmdTraceRaysNV: hitShaderBindingStride must be a multiple of "
5572 "VkPhysicalDeviceRayTracingPropertiesNV::shaderGroupHandleSize.");
5573 }
5574 if (hitShaderBindingStride > phys_dev_ext_props.ray_tracing_propsNV.maxShaderGroupStride) {
5575 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-hitShaderBindingStride-02467",
5576 "vkCmdTraceRaysNV: hitShaderBindingStride must be less than or equal to "
5577 "VkPhysicalDeviceRayTracingPropertiesNV::maxShaderGroupStride.");
5578 }
5579
5580 // missShader
5581 if (SafeModulo(missShaderBindingOffset, phys_dev_ext_props.ray_tracing_propsNV.shaderGroupBaseAlignment) != 0) {
5582 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-missShaderBindingOffset-02458",
5583 "vkCmdTraceRaysNV: missShaderBindingOffset must be a multiple of "
5584 "VkPhysicalDeviceRayTracingPropertiesNV::shaderGroupBaseAlignment.");
5585 }
5586 if (SafeModulo(missShaderBindingStride, phys_dev_ext_props.ray_tracing_propsNV.shaderGroupHandleSize) != 0) {
5587 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-missShaderBindingStride-02463",
5588 "vkCmdTraceRaysNV: missShaderBindingStride must be a multiple of "
5589 "VkPhysicalDeviceRayTracingPropertiesNV::shaderGroupHandleSize.");
5590 }
5591 if (missShaderBindingStride > phys_dev_ext_props.ray_tracing_propsNV.maxShaderGroupStride) {
5592 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-missShaderBindingStride-02466",
5593 "vkCmdTraceRaysNV: missShaderBindingStride must be less than or equal to "
5594 "VkPhysicalDeviceRayTracingPropertiesNV::maxShaderGroupStride.");
5595 }
5596
5597 // raygenShader
5598 if (SafeModulo(raygenShaderBindingOffset, phys_dev_ext_props.ray_tracing_propsNV.shaderGroupBaseAlignment) != 0) {
5599 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-raygenShaderBindingOffset-02456",
5600 "vkCmdTraceRaysNV: raygenShaderBindingOffset must be a multiple of "
sourav parmard1521802020-06-07 21:49:02 -07005601 "VkPhysicalDeviceRayTracingPropertiesNV::shaderGroupBaseAlignment.");
5602 }
5603 if (width > device_limits.maxComputeWorkGroupCount[0]) {
5604 skip |=
5605 LogError(device, "VUID-vkCmdTraceRaysNV-width-02469",
5606 "vkCmdTraceRaysNV: width must be less than or equal to VkPhysicalDeviceLimits::maxComputeWorkGroupCount[o].");
5607 }
5608 if (height > device_limits.maxComputeWorkGroupCount[1]) {
5609 skip |=
5610 LogError(device, "VUID-vkCmdTraceRaysNV-height-02470",
5611 "vkCmdTraceRaysNV: height must be less than or equal to VkPhysicalDeviceLimits::maxComputeWorkGroupCount[1].");
5612 }
5613 if (depth > device_limits.maxComputeWorkGroupCount[2]) {
5614 skip |=
5615 LogError(device, "VUID-vkCmdTraceRaysNV-depth-02471",
5616 "vkCmdTraceRaysNV: depth must be less than or equal to VkPhysicalDeviceLimits::maxComputeWorkGroupCount[2].");
sourav parmar83c31b12020-05-06 12:30:54 -07005617 }
5618 return skip;
5619}
5620
5621bool StatelessValidation::manual_PreCallValidateCmdBuildAccelerationStructureIndirectKHR(
5622 VkCommandBuffer commandBuffer, const VkAccelerationStructureBuildGeometryInfoKHR *pInfo, VkBuffer indirectBuffer,
5623 VkDeviceSize indirectOffset, uint32_t indirectStride) const {
5624 bool skip = false;
5625 const auto *raytracing_features = lvl_find_in_chain<VkPhysicalDeviceRayTracingFeaturesKHR>(device_createinfo_pnext);
5626 if (!raytracing_features || raytracing_features->rayTracingIndirectAccelerationStructureBuild == VK_FALSE) {
5627 skip |= LogError(
5628 device, "VUID-vkCmdBuildAccelerationStructureIndirectKHR-rayTracingIndirectAccelerationStructureBuild-03535",
5629 "vkCmdBuildAccelerationStructureIndirectKHR: The "
5630 "VkPhysicalDeviceRayTracingFeaturesKHR::rayTracingIndirectAccelerationStructureBuild feature must be enabled.");
5631 }
Mark Lobodzinski17dc4602020-05-29 07:48:40 -06005632 const auto *pnext_struct = lvl_find_in_chain<VkDeferredOperationInfoKHR>(pInfo->pNext);
5633 if (pnext_struct) {
sourav parmar83c31b12020-05-06 12:30:54 -07005634 skip |=
5635 LogError(device, "VUID-vkCmdBuildAccelerationStructureIndirectKHR-pNext-03536",
5636 "vkCmdBuildAccelerationStructureIndirectKHR: The VkDeferredOperationInfoKHR structure must not be included in "
5637 "the pNext chain of any of the provided VkAccelerationStructureBuildGeometryInfoKHR structures.");
5638 }
5639 return false;
5640}
5641
5642bool StatelessValidation::manual_PreCallValidateGetDeviceAccelerationStructureCompatibilityKHR(
5643 VkDevice device, const VkAccelerationStructureVersionKHR *version) const {
5644 bool skip = false;
5645 const auto *raytracing_features = lvl_find_in_chain<VkPhysicalDeviceRayTracingFeaturesKHR>(device_createinfo_pnext);
5646 if (!raytracing_features || !(raytracing_features->rayQuery || raytracing_features->rayTracing)) {
5647 skip |= LogError(device, "VUID-vkGetDeviceAccelerationStructureCompatibilityKHR-rayTracing-03565",
5648 "vkGetDeviceAccelerationStructureCompatibilityKHR: The rayTracing or rayQuery feature must be enabled.");
5649 }
5650 return skip;
5651}
5652
5653bool StatelessValidation::manual_PreCallValidateBuildAccelerationStructureKHR(
5654 VkDevice device, uint32_t infoCount, const VkAccelerationStructureBuildGeometryInfoKHR *pInfos,
5655 const VkAccelerationStructureBuildOffsetInfoKHR *const *ppOffsetInfos) const {
5656 bool skip = false;
5657 const auto *raytracing_features = lvl_find_in_chain<VkPhysicalDeviceRayTracingFeaturesKHR>(device_createinfo_pnext);
5658 if (!raytracing_features || raytracing_features->rayTracingHostAccelerationStructureCommands == VK_FALSE) {
sourav parmara24fb7b2020-05-26 10:50:04 -07005659 skip |= LogError(device, "VUID-vkBuildAccelerationStructureKHR-rayTracingHostAccelerationStructureCommands-03439",
5660 "vkBuildAccelerationStructureKHR: The "
5661 "vkPhysicalDeviceRayTracingFeaturesKHR::rayTracingHostAccelerationStructureCommands"
5662 "feature must be enabled .");
sourav parmar83c31b12020-05-06 12:30:54 -07005663 }
sourav parmara96ab1a2020-04-25 16:28:23 -07005664 return skip;
5665}
sourav parmara24fb7b2020-05-26 10:50:04 -07005666bool StatelessValidation::manual_PreCallValidateCmdBuildAccelerationStructureKHR(
5667 VkCommandBuffer commandBuffer, uint32_t infoCount, const VkAccelerationStructureBuildGeometryInfoKHR *pInfos,
5668 const VkAccelerationStructureBuildOffsetInfoKHR *const *ppOffsetInfos) const {
5669 bool skip = false;
5670 for (uint32_t i = 0; i < infoCount; ++i) {
Mark Lobodzinski17dc4602020-05-29 07:48:40 -06005671 const auto *pnext_struct = lvl_find_in_chain<VkDeferredOperationInfoKHR>(pInfos->pNext);
5672 if (pnext_struct) {
sourav parmara24fb7b2020-05-26 10:50:04 -07005673 skip |=
5674 LogError(commandBuffer, "VUID-vkCmdBuildAccelerationStructureKHR-pNext-03532",
5675 "vkCmdBuildAccelerationStructureKHR: The VkDeferredOperationInfoKHR structure must not be included in the"
5676 "pNext chain of any of the provided VkAccelerationStructureBuildGeometryInfoKHR structures.");
5677 }
5678 }
5679 return skip;
Mark Lobodzinski17dc4602020-05-29 07:48:40 -06005680}
Piers Daniell39842ee2020-07-10 16:42:33 -06005681
5682bool StatelessValidation::manual_PreCallValidateCmdSetViewportWithCountEXT(VkCommandBuffer commandBuffer, uint32_t viewportCount,
5683 const VkViewport *pViewports) const {
5684 bool skip = false;
5685
5686 if (!physical_device_features.multiViewport) {
5687 if (viewportCount != 1) {
5688 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewportWithCountEXT-viewportCount-03395",
5689 "vkCmdSetViewportWithCountEXT: The multiViewport feature is disabled, but viewportCount (=%" PRIu32
5690 ") is not 1.",
5691 viewportCount);
5692 }
5693 } else { // multiViewport enabled
5694 if (viewportCount < 1 || viewportCount > device_limits.maxViewports) {
5695 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewportWithCountEXT-viewportCount-03394",
5696 "vkCmdSetViewportWithCountEXT: viewportCount (=%" PRIu32
5697 ") must "
5698 "not be greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
5699 viewportCount, device_limits.maxViewports);
5700 }
5701 }
5702
5703 if (pViewports) {
5704 for (uint32_t viewport_i = 0; viewport_i < viewportCount; ++viewport_i) {
5705 const auto &viewport = pViewports[viewport_i]; // will crash on invalid ptr
5706 const char *fn_name = "vkCmdSetViewportWithCountEXT";
5707 skip |= manual_PreCallValidateViewport(
5708 viewport, fn_name, ParameterName("pViewports[%i]", ParameterName::IndexVector{viewport_i}), commandBuffer);
5709 }
5710 }
5711
5712 return skip;
5713}
5714
5715bool StatelessValidation::manual_PreCallValidateCmdSetScissorWithCountEXT(VkCommandBuffer commandBuffer, uint32_t scissorCount,
5716 const VkRect2D *pScissors) const {
5717 bool skip = false;
5718
5719 if (!physical_device_features.multiViewport) {
5720 if (scissorCount != 1) {
5721 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissorWithCountEXT-scissorCount-03398",
5722 "vkCmdSetScissorWithCountEXT: scissorCount (=%" PRIu32
5723 ") must "
5724 "be 1 when the multiViewport feature is disabled.",
5725 scissorCount);
5726 }
5727 } else { // multiViewport enabled
5728 if (scissorCount == 0) {
5729 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissorWithCountEXT-scissorCount-03397",
5730 "vkCmdSetScissorWithCountEXT: scissorCount (=%" PRIu32
5731 ") must "
5732 "be great than zero.",
5733 scissorCount);
5734 } else if (scissorCount > device_limits.maxViewports) {
5735 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissorWithCountEXT-scissorCount-03397",
5736 "vkCmdSetScissorWithCountEXT: scissorCount (=%" PRIu32
5737 ") must "
5738 "not be greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
5739 scissorCount, device_limits.maxViewports);
5740 }
5741 }
5742
5743 if (pScissors) {
5744 for (uint32_t scissor_i = 0; scissor_i < scissorCount; ++scissor_i) {
5745 const auto &scissor = pScissors[scissor_i]; // will crash on invalid ptr
5746
5747 if (scissor.offset.x < 0) {
5748 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissorWithCountEXT-x-03399",
5749 "vkCmdSetScissor: pScissors[%" PRIu32 "].offset.x (=%" PRIi32 ") is negative.", scissor_i,
5750 scissor.offset.x);
5751 }
5752
5753 if (scissor.offset.y < 0) {
5754 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissorWithCountEXT-x-03399",
5755 "vkCmdSetScissor: pScissors[%" PRIu32 "].offset.y (=%" PRIi32 ") is negative.", scissor_i,
5756 scissor.offset.y);
5757 }
5758
5759 const int64_t x_sum = static_cast<int64_t>(scissor.offset.x) + static_cast<int64_t>(scissor.extent.width);
5760 if (x_sum > INT32_MAX) {
5761 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissorWithCountEXT-offset-03400",
5762 "vkCmdSetScissor: offset.x + extent.width (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
5763 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
5764 scissor.offset.x, scissor.extent.width, x_sum, scissor_i);
5765 }
5766
5767 const int64_t y_sum = static_cast<int64_t>(scissor.offset.y) + static_cast<int64_t>(scissor.extent.height);
5768 if (y_sum > INT32_MAX) {
5769 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissorWithCountEXT-offset-03401",
5770 "vkCmdSetScissor: offset.y + extent.height (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
5771 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
5772 scissor.offset.y, scissor.extent.height, y_sum, scissor_i);
5773 }
5774 }
5775 }
5776
5777 return skip;
5778}
5779
5780bool StatelessValidation::manual_PreCallValidateCmdBindVertexBuffers2EXT(VkCommandBuffer commandBuffer, uint32_t firstBinding,
5781 uint32_t bindingCount, const VkBuffer *pBuffers,
5782 const VkDeviceSize *pOffsets, const VkDeviceSize *pSizes,
5783 const VkDeviceSize *pStrides) const {
5784 bool skip = false;
5785 if (firstBinding >= device_limits.maxVertexInputBindings) {
5786 skip |= LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers2EXT-firstBinding-03355",
5787 "vkCmdBindVertexBuffers2EXT() firstBinding (%u) must be less than maxVertexInputBindings (%u)",
5788 firstBinding, device_limits.maxVertexInputBindings);
5789 } else if ((firstBinding + bindingCount) > device_limits.maxVertexInputBindings) {
5790 skip |= LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers2EXT-firstBinding-03356",
5791 "vkCmdBindVertexBuffers2EXT() sum of firstBinding (%u) and bindingCount (%u) must be less than "
5792 "maxVertexInputBindings (%u)",
5793 firstBinding, bindingCount, device_limits.maxVertexInputBindings);
5794 }
5795
5796 for (uint32_t i = 0; i < bindingCount; ++i) {
5797 if (pBuffers[i] == VK_NULL_HANDLE) {
5798 const auto *robustness2_features = lvl_find_in_chain<VkPhysicalDeviceRobustness2FeaturesEXT>(device_createinfo_pnext);
5799 if (!(robustness2_features && robustness2_features->nullDescriptor)) {
5800 skip |= LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers2EXT-pBuffers-04111",
5801 "vkCmdBindVertexBuffers2EXT() required parameter pBuffers[%d] specified as VK_NULL_HANDLE", i);
5802 } else {
5803 if (pOffsets[i] != 0) {
5804 skip |=
5805 LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers2EXT-pBuffers-04112",
5806 "vkCmdBindVertexBuffers2EXT() pBuffers[%d] is VK_NULL_HANDLE, but pOffsets[%d] is not 0", i, i);
5807 }
5808 }
5809 }
5810 if (pStrides) {
5811 if (pStrides[i] > device_limits.maxVertexInputBindingStride) {
5812 skip |=
5813 LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers2EXT-pStrides-03362",
5814 "vkCmdBindVertexBuffers2EXT() pStrides[%d] (%u) must be less than maxVertexInputBindingStride (%u)", i,
5815 pStrides[i], device_limits.maxVertexInputBindingStride);
5816 }
5817 }
5818 }
5819
5820 return skip;
5821}