blob: e14cf101a863e79c279ba3fabd3d3e0d0c60a2fd [file] [log] [blame]
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001/* Copyright (c) 2015-2017 The Khronos Group Inc.
2 * Copyright (c) 2015-2017 Valve Corporation
3 * Copyright (c) 2015-2017 LunarG, Inc.
4 * Copyright (C) 2015-2017 Google Inc.
5 *
6 * Licensed under the Apache License, Version 2.0 (the "License");
7 * you may not use this file except in compliance with the License.
8 * You may obtain a copy of the License at
9 *
10 * http://www.apache.org/licenses/LICENSE-2.0
11 *
12 * Unless required by applicable law or agreed to in writing, software
13 * distributed under the License is distributed on an "AS IS" BASIS,
14 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15 * See the License for the specific language governing permissions and
16 * limitations under the License.
17 *
18 * Author: Mark Lobodzinski <mark@LunarG.com>
19 */
20
21#define NOMINMAX
John Zulauf0fe5bfe2018-05-23 09:36:00 -060022#define VALIDATION_ERROR_MAP_IMPL
Mark Lobodzinskid4950072017-08-01 13:02:20 -060023
24#include <limits.h>
25#include <math.h>
26#include <stdio.h>
27#include <stdlib.h>
28#include <string.h>
Mark Lobodzinskid4950072017-08-01 13:02:20 -060029
30#include <iostream>
31#include <string>
32#include <sstream>
33#include <unordered_map>
34#include <unordered_set>
35#include <vector>
36#include <mutex>
37
38#include "vk_loader_platform.h"
39#include "vulkan/vk_layer.h"
40#include "vk_layer_config.h"
41#include "vk_dispatch_table_helper.h"
John Zulaufde972ac2017-10-26 12:07:05 -060042#include "vk_typemap_helper.h"
Mark Lobodzinskid4950072017-08-01 13:02:20 -060043
Mark Lobodzinskid4950072017-08-01 13:02:20 -060044#include "vk_layer_data.h"
45#include "vk_layer_logging.h"
46#include "vk_layer_extension_utils.h"
47#include "vk_layer_utils.h"
Lenny Komow4c0da772018-07-03 10:17:21 -060048#include "vk_layer_dispatch_table.h"
Mark Lobodzinskid4950072017-08-01 13:02:20 -060049
50#include "parameter_name.h"
51#include "parameter_validation.h"
52
Mark Lobodzinskibfb7ab92017-10-27 13:22:23 -060053#if defined __ANDROID__
54#include <android/log.h>
Mark Lobodzinski88529492018-04-01 10:38:15 -060055#define LOGCONSOLE(...) ((void)__android_log_print(ANDROID_LOG_INFO, "PARAMETER_VALIDATION", __VA_ARGS__))
Mark Lobodzinskibfb7ab92017-10-27 13:22:23 -060056#else
57#define LOGCONSOLE(...) \
58 { \
59 printf(__VA_ARGS__); \
60 printf("\n"); \
61 }
62#endif
63
Mark Lobodzinskid4950072017-08-01 13:02:20 -060064namespace parameter_validation {
65
Mark Lobodzinski78a12a92017-08-08 14:16:51 -060066extern std::unordered_map<std::string, void *> custom_functions;
67
Mark Lobodzinskid4950072017-08-01 13:02:20 -060068extern bool parameter_validation_vkCreateInstance(VkInstance instance, const VkInstanceCreateInfo *pCreateInfo,
69 const VkAllocationCallbacks *pAllocator, VkInstance *pInstance);
70extern bool parameter_validation_vkDestroyInstance(VkInstance instance, const VkAllocationCallbacks *pAllocator);
71extern bool parameter_validation_vkCreateDevice(VkPhysicalDevice physicalDevice, const VkDeviceCreateInfo *pCreateInfo,
72 const VkAllocationCallbacks *pAllocator, VkDevice *pDevice);
73extern bool parameter_validation_vkDestroyDevice(VkDevice device, const VkAllocationCallbacks *pAllocator);
74extern bool parameter_validation_vkCreateQueryPool(VkDevice device, const VkQueryPoolCreateInfo *pCreateInfo,
75 const VkAllocationCallbacks *pAllocator, VkQueryPool *pQueryPool);
76extern bool parameter_validation_vkCreateDebugReportCallbackEXT(VkInstance instance,
77 const VkDebugReportCallbackCreateInfoEXT *pCreateInfo,
78 const VkAllocationCallbacks *pAllocator,
79 VkDebugReportCallbackEXT *pMsgCallback);
80extern bool parameter_validation_vkDestroyDebugReportCallbackEXT(VkInstance instance, VkDebugReportCallbackEXT msgCallback,
81 const VkAllocationCallbacks *pAllocator);
Mark Young6ba8abe2017-11-09 10:37:04 -070082extern bool parameter_validation_vkCreateDebugUtilsMessengerEXT(VkInstance instance,
83 const VkDebugUtilsMessengerCreateInfoEXT *pCreateInfo,
84 const VkAllocationCallbacks *pAllocator,
85 VkDebugUtilsMessengerEXT *pMessenger);
86extern bool parameter_validation_vkDestroyDebugUtilsMessengerEXT(VkInstance instance, VkDebugUtilsMessengerEXT messenger,
87 const VkAllocationCallbacks *pAllocator);
Mark Lobodzinskid4950072017-08-01 13:02:20 -060088extern bool parameter_validation_vkCreateCommandPool(VkDevice device, const VkCommandPoolCreateInfo *pCreateInfo,
89 const VkAllocationCallbacks *pAllocator, VkCommandPool *pCommandPool);
Petr Krause91f7a12017-12-14 20:57:36 +010090extern bool parameter_validation_vkCreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo,
91 const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass);
92extern bool parameter_validation_vkDestroyRenderPass(VkDevice device, VkRenderPass renderPass,
93 const VkAllocationCallbacks *pAllocator);
Mark Lobodzinskid4950072017-08-01 13:02:20 -060094
95// TODO : This can be much smarter, using separate locks for separate global data
96std::mutex global_lock;
97
98static uint32_t loader_layer_if_version = CURRENT_LOADER_LAYER_INTERFACE_VERSION;
99std::unordered_map<void *, layer_data *> layer_data_map;
100std::unordered_map<void *, instance_layer_data *> instance_layer_data_map;
101
102void InitializeManualParameterValidationFunctionPointers(void);
103
104static void init_parameter_validation(instance_layer_data *instance_data, const VkAllocationCallbacks *pAllocator) {
Mark Young6ba8abe2017-11-09 10:37:04 -0700105 layer_debug_report_actions(instance_data->report_data, instance_data->logging_callback, pAllocator,
106 "lunarg_parameter_validation");
107 layer_debug_messenger_actions(instance_data->report_data, instance_data->logging_messenger, pAllocator,
108 "lunarg_parameter_validation");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600109}
110
Mark Young6ba8abe2017-11-09 10:37:04 -0700111static const VkExtensionProperties instance_extensions[] = {{VK_EXT_DEBUG_REPORT_EXTENSION_NAME, VK_EXT_DEBUG_REPORT_SPEC_VERSION},
112 {VK_EXT_DEBUG_UTILS_EXTENSION_NAME, VK_EXT_DEBUG_UTILS_SPEC_VERSION}};
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600113
114static const VkLayerProperties global_layer = {
Dave Houltonb3bbec72018-01-17 10:13:33 -0700115 "VK_LAYER_LUNARG_parameter_validation",
116 VK_LAYER_API_VERSION,
117 1,
118 "LunarG Validation Layer",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600119};
120
121static const int MaxParamCheckerStringLength = 256;
122
John Zulauf71968502017-10-26 13:51:15 -0600123template <typename T>
124static inline bool in_inclusive_range(const T &value, const T &min, const T &max) {
125 // Using only < for generality and || for early abort
126 return !((value < min) || (max < value));
127}
128
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600129static bool validate_string(debug_report_data *report_data, const char *apiName, const ParameterName &stringName,
Mark Lobodzinskiebee3552018-05-29 09:55:54 -0600130 const std::string &vuid, const char *validateString) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600131 bool skip = false;
132
133 VkStringErrorFlags result = vk_string_validate(MaxParamCheckerStringLength, validateString);
134
135 if (result == VK_STRING_ERROR_NONE) {
136 return skip;
137 } else if (result & VK_STRING_ERROR_LENGTH) {
Mark Lobodzinskiebee3552018-05-29 09:55:54 -0600138 skip = log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, vuid,
139 "%s: string %s exceeds max length %d", apiName, stringName.get_name().c_str(), MaxParamCheckerStringLength);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600140 } else if (result & VK_STRING_ERROR_BAD_DATA) {
Mark Lobodzinskiebee3552018-05-29 09:55:54 -0600141 skip = log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, vuid,
142 "%s: string %s contains invalid characters or is badly formed", apiName, stringName.get_name().c_str());
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600143 }
144 return skip;
145}
146
147static bool ValidateDeviceQueueFamily(layer_data *device_data, uint32_t queue_family, const char *cmd_name,
Dave Houlton13b65502018-05-23 13:35:24 -0600148 const char *parameter_name, const std::string &error_code, bool optional = false) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600149 bool skip = false;
150
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600151 if (!optional && queue_family == VK_QUEUE_FAMILY_IGNORED) {
152 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -0600153 HandleToUint64(device_data->device), error_code,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600154 "%s: %s is VK_QUEUE_FAMILY_IGNORED, but it is required to provide a valid queue family index value.",
155 cmd_name, parameter_name);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600156 } else if (device_data->queueFamilyIndexMap.find(queue_family) == device_data->queueFamilyIndexMap.end()) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600157 skip |=
158 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -0600159 HandleToUint64(device_data->device), error_code,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600160 "%s: %s (= %" PRIu32
161 ") is not one of the queue families given via VkDeviceQueueCreateInfo structures when the device was created.",
162 cmd_name, parameter_name, queue_family);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600163 }
164
165 return skip;
166}
167
168static bool ValidateQueueFamilies(layer_data *device_data, uint32_t queue_family_count, const uint32_t *queue_families,
Dave Houlton13b65502018-05-23 13:35:24 -0600169 const char *cmd_name, const char *array_parameter_name, const std::string &unique_error_code,
170 const std::string &valid_error_code, bool optional = false) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600171 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600172 if (queue_families) {
173 std::unordered_set<uint32_t> set;
174 for (uint32_t i = 0; i < queue_family_count; ++i) {
175 std::string parameter_name = std::string(array_parameter_name) + "[" + std::to_string(i) + "]";
176
177 if (set.count(queue_families[i])) {
178 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -0600179 HandleToUint64(device_data->device), "VUID-VkDeviceCreateInfo-queueFamilyIndex-00372",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600180 "%s: %s (=%" PRIu32 ") is not unique within %s array.", cmd_name, parameter_name.c_str(),
181 queue_families[i], array_parameter_name);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600182 } else {
183 set.insert(queue_families[i]);
184 skip |= ValidateDeviceQueueFamily(device_data, queue_families[i], cmd_name, parameter_name.c_str(),
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600185 valid_error_code, optional);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600186 }
187 }
188 }
189 return skip;
190}
191
John Zulauf620755c2018-04-16 11:00:43 -0600192static bool validate_api_version(const instance_layer_data *instance_data, uint32_t api_version, uint32_t effective_api_version) {
193 bool skip = false;
194 uint32_t api_version_nopatch = VK_MAKE_VERSION(VK_VERSION_MAJOR(api_version), VK_VERSION_MINOR(api_version), 0);
195 if (api_version_nopatch != effective_api_version) {
196 if (api_version_nopatch < VK_API_VERSION_1_0) {
197 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_INSTANCE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -0600198 HandleToUint64(instance_data->instance), kVUIDUndefined,
John Zulauf620755c2018-04-16 11:00:43 -0600199 "Invalid CreateInstance->pCreateInfo->pApplicationInfo.apiVersion number (0x%08x). "
200 "Using VK_API_VERSION_%" PRIu32 "_%" PRIu32 ".",
201 api_version, VK_VERSION_MAJOR(effective_api_version), VK_VERSION_MINOR(effective_api_version));
202 } else {
203 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_INSTANCE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -0600204 HandleToUint64(instance_data->instance), kVUIDUndefined,
John Zulauf620755c2018-04-16 11:00:43 -0600205 "Unrecognized CreateInstance->pCreateInfo->pApplicationInfo.apiVersion number (0x%08x). "
206 "Assuming VK_API_VERSION_%" PRIu32 "_%" PRIu32 ".",
207 api_version, VK_VERSION_MAJOR(effective_api_version), VK_VERSION_MINOR(effective_api_version));
208 }
209 }
210 return skip;
211}
212
213template <typename ExtensionState>
Dave Houlton13b65502018-05-23 13:35:24 -0600214static bool validate_extension_reqs(const instance_layer_data *instance_data, const ExtensionState &extensions,
215 const std::string &vuid, const char *extension_type, const char *extension_name) {
John Zulauf620755c2018-04-16 11:00:43 -0600216 bool skip = false;
217 if (!extension_name) {
218 return skip; // Robust to invalid char *
219 }
220 auto info = ExtensionState::get_info(extension_name);
221
222 if (!info.state) {
223 return skip; // Unknown extensions cannot be checked so report OK
224 }
225
Pat Brown3eddb062018-09-05 14:07:37 -0400226 // Check against the required list in the info
John Zulauf620755c2018-04-16 11:00:43 -0600227 std::vector<const char *> missing;
228 for (const auto &req : info.requires) {
229 if (!(extensions.*(req.enabled))) {
230 missing.push_back(req.name);
231 }
232 }
233
234 // Report any missing requirements
235 if (missing.size()) {
236 std::string missing_joined_list = string_join(", ", missing);
237 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_INSTANCE_EXT,
Pat Brown3eddb062018-09-05 14:07:37 -0400238 HandleToUint64(instance_data->instance), vuid, "Missing extension%s required by the %s extension %s: %s.",
239 ((missing.size() > 1) ? "s" : ""), extension_type, extension_name, missing_joined_list.c_str());
John Zulauf620755c2018-04-16 11:00:43 -0600240 }
241 return skip;
242}
243
244bool validate_instance_extensions(const instance_layer_data *instance_data, const VkInstanceCreateInfo *pCreateInfo) {
245 bool skip = false;
246 for (uint32_t i = 0; i < pCreateInfo->enabledExtensionCount; i++) {
Dave Houlton413a6782018-05-22 13:01:54 -0600247 skip |=
248 validate_extension_reqs(instance_data, instance_data->extensions, "VUID-vkCreateInstance-ppEnabledExtensionNames-01388",
249 "instance", pCreateInfo->ppEnabledExtensionNames[i]);
John Zulauf620755c2018-04-16 11:00:43 -0600250 }
251
252 return skip;
253}
254
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600255VKAPI_ATTR VkResult VKAPI_CALL vkCreateInstance(const VkInstanceCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600256 VkInstance *pInstance) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600257 VkResult result = VK_ERROR_VALIDATION_FAILED_EXT;
258
259 VkLayerInstanceCreateInfo *chain_info = get_chain_info(pCreateInfo, VK_LAYER_LINK_INFO);
260 assert(chain_info != nullptr);
261 assert(chain_info->u.pLayerInfo != nullptr);
262
263 PFN_vkGetInstanceProcAddr fpGetInstanceProcAddr = chain_info->u.pLayerInfo->pfnNextGetInstanceProcAddr;
264 PFN_vkCreateInstance fpCreateInstance = (PFN_vkCreateInstance)fpGetInstanceProcAddr(NULL, "vkCreateInstance");
265 if (fpCreateInstance == NULL) {
266 return VK_ERROR_INITIALIZATION_FAILED;
267 }
268
269 // Advance the link info for the next element on the chain
270 chain_info->u.pLayerInfo = chain_info->u.pLayerInfo->pNext;
271
272 result = fpCreateInstance(pCreateInfo, pAllocator, pInstance);
273
274 if (result == VK_SUCCESS) {
275 InitializeManualParameterValidationFunctionPointers();
276 auto my_instance_data = GetLayerDataPtr(get_dispatch_key(*pInstance), instance_layer_data_map);
277 assert(my_instance_data != nullptr);
278
279 layer_init_instance_dispatch_table(*pInstance, &my_instance_data->dispatch_table, fpGetInstanceProcAddr);
280 my_instance_data->instance = *pInstance;
281 my_instance_data->report_data =
Mark Young6ba8abe2017-11-09 10:37:04 -0700282 debug_utils_create_instance(&my_instance_data->dispatch_table, *pInstance, pCreateInfo->enabledExtensionCount,
283 pCreateInfo->ppEnabledExtensionNames);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600284
285 // Look for one or more debug report create info structures
286 // and setup a callback(s) for each one found.
Mark Young6ba8abe2017-11-09 10:37:04 -0700287 if (!layer_copy_tmp_debug_messengers(pCreateInfo->pNext, &my_instance_data->num_tmp_debug_messengers,
288 &my_instance_data->tmp_messenger_create_infos,
289 &my_instance_data->tmp_debug_messengers)) {
290 if (my_instance_data->num_tmp_debug_messengers > 0) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600291 // Setup the temporary callback(s) here to catch early issues:
Mark Young6ba8abe2017-11-09 10:37:04 -0700292 if (layer_enable_tmp_debug_messengers(my_instance_data->report_data, my_instance_data->num_tmp_debug_messengers,
293 my_instance_data->tmp_messenger_create_infos,
294 my_instance_data->tmp_debug_messengers)) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600295 // Failure of setting up one or more of the callback.
296 // Therefore, clean up and don't use those callbacks:
Mark Young6ba8abe2017-11-09 10:37:04 -0700297 layer_free_tmp_debug_messengers(my_instance_data->tmp_messenger_create_infos,
298 my_instance_data->tmp_debug_messengers);
299 my_instance_data->num_tmp_debug_messengers = 0;
300 }
301 }
302 }
303 if (!layer_copy_tmp_report_callbacks(pCreateInfo->pNext, &my_instance_data->num_tmp_report_callbacks,
304 &my_instance_data->tmp_report_create_infos, &my_instance_data->tmp_report_callbacks)) {
305 if (my_instance_data->num_tmp_report_callbacks > 0) {
306 // Setup the temporary callback(s) here to catch early issues:
307 if (layer_enable_tmp_report_callbacks(my_instance_data->report_data, my_instance_data->num_tmp_report_callbacks,
308 my_instance_data->tmp_report_create_infos,
309 my_instance_data->tmp_report_callbacks)) {
310 // Failure of setting up one or more of the callback.
311 // Therefore, clean up and don't use those callbacks:
312 layer_free_tmp_report_callbacks(my_instance_data->tmp_report_create_infos,
313 my_instance_data->tmp_report_callbacks);
314 my_instance_data->num_tmp_report_callbacks = 0;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600315 }
316 }
317 }
318
319 init_parameter_validation(my_instance_data, pAllocator);
John Zulaufe6db8a32018-03-30 14:51:59 -0600320 // Note: From the spec--
321 // Providing a NULL VkInstanceCreateInfo::pApplicationInfo or providing an apiVersion of 0 is equivalent to providing
322 // an apiVersion of VK_MAKE_VERSION(1, 0, 0). (a.k.a. VK_API_VERSION_1_0)
323 uint32_t api_version = (pCreateInfo->pApplicationInfo && pCreateInfo->pApplicationInfo->apiVersion)
324 ? pCreateInfo->pApplicationInfo->apiVersion
325 : VK_API_VERSION_1_0;
Mark Lobodzinskibfb7ab92017-10-27 13:22:23 -0600326
John Zulauf1909e6a2018-09-05 11:43:11 -0600327 my_instance_data->api_version = my_instance_data->extensions.InitFromInstanceCreateInfo(api_version, pCreateInfo);
Mark Lobodzinskibfb7ab92017-10-27 13:22:23 -0600328
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600329 // Ordinarily we'd check these before calling down the chain, but none of the layer support is in place until now, if we
330 // survive we can report the issue now.
John Zulauf1909e6a2018-09-05 11:43:11 -0600331 validate_api_version(my_instance_data, api_version, my_instance_data->api_version);
John Zulauf620755c2018-04-16 11:00:43 -0600332 validate_instance_extensions(my_instance_data, pCreateInfo);
333
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600334 parameter_validation_vkCreateInstance(*pInstance, pCreateInfo, pAllocator, pInstance);
335
336 if (pCreateInfo->pApplicationInfo) {
337 if (pCreateInfo->pApplicationInfo->pApplicationName) {
Mark Lobodzinskiebee3552018-05-29 09:55:54 -0600338 validate_string(
339 my_instance_data->report_data, "vkCreateInstance", "pCreateInfo->VkApplicationInfo->pApplicationName",
340 "VUID-VkApplicationInfo-pApplicationName-parameter", pCreateInfo->pApplicationInfo->pApplicationName);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600341 }
342
343 if (pCreateInfo->pApplicationInfo->pEngineName) {
344 validate_string(my_instance_data->report_data, "vkCreateInstance", "pCreateInfo->VkApplicationInfo->pEngineName",
Mark Lobodzinskiebee3552018-05-29 09:55:54 -0600345 "VUID-VkApplicationInfo-pEngineName-parameter", pCreateInfo->pApplicationInfo->pEngineName);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600346 }
347 }
348
349 // Disable the tmp callbacks:
Mark Young6ba8abe2017-11-09 10:37:04 -0700350 if (my_instance_data->num_tmp_debug_messengers > 0) {
351 layer_disable_tmp_debug_messengers(my_instance_data->report_data, my_instance_data->num_tmp_debug_messengers,
352 my_instance_data->tmp_debug_messengers);
353 }
354 if (my_instance_data->num_tmp_report_callbacks > 0) {
355 layer_disable_tmp_report_callbacks(my_instance_data->report_data, my_instance_data->num_tmp_report_callbacks,
356 my_instance_data->tmp_report_callbacks);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600357 }
358 }
359
360 return result;
361}
362
363VKAPI_ATTR void VKAPI_CALL vkDestroyInstance(VkInstance instance, const VkAllocationCallbacks *pAllocator) {
364 // Grab the key before the instance is destroyed.
365 dispatch_key key = get_dispatch_key(instance);
366 bool skip = false;
367 auto instance_data = GetLayerDataPtr(key, instance_layer_data_map);
368
369 // Enable the temporary callback(s) here to catch vkDestroyInstance issues:
370 bool callback_setup = false;
Mark Young6ba8abe2017-11-09 10:37:04 -0700371 if (instance_data->num_tmp_debug_messengers > 0) {
372 if (!layer_enable_tmp_debug_messengers(instance_data->report_data, instance_data->num_tmp_debug_messengers,
373 instance_data->tmp_messenger_create_infos, instance_data->tmp_debug_messengers)) {
374 callback_setup = true;
375 }
376 }
377 if (instance_data->num_tmp_report_callbacks > 0) {
378 if (!layer_enable_tmp_report_callbacks(instance_data->report_data, instance_data->num_tmp_report_callbacks,
379 instance_data->tmp_report_create_infos, instance_data->tmp_report_callbacks)) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600380 callback_setup = true;
381 }
382 }
383
384 skip |= parameter_validation_vkDestroyInstance(instance, pAllocator);
385
386 // Disable and cleanup the temporary callback(s):
387 if (callback_setup) {
Mark Young6ba8abe2017-11-09 10:37:04 -0700388 layer_disable_tmp_debug_messengers(instance_data->report_data, instance_data->num_tmp_debug_messengers,
389 instance_data->tmp_debug_messengers);
390 layer_disable_tmp_report_callbacks(instance_data->report_data, instance_data->num_tmp_report_callbacks,
391 instance_data->tmp_report_callbacks);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600392 }
Mark Young6ba8abe2017-11-09 10:37:04 -0700393 if (instance_data->num_tmp_debug_messengers > 0) {
394 layer_free_tmp_debug_messengers(instance_data->tmp_messenger_create_infos, instance_data->tmp_debug_messengers);
395 instance_data->num_tmp_debug_messengers = 0;
396 }
397 if (instance_data->num_tmp_report_callbacks > 0) {
398 layer_free_tmp_report_callbacks(instance_data->tmp_report_create_infos, instance_data->tmp_report_callbacks);
399 instance_data->num_tmp_report_callbacks = 0;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600400 }
401
402 if (!skip) {
403 instance_data->dispatch_table.DestroyInstance(instance, pAllocator);
404
405 // Clean up logging callback, if any
Mark Young6ba8abe2017-11-09 10:37:04 -0700406 while (instance_data->logging_messenger.size() > 0) {
407 VkDebugUtilsMessengerEXT messenger = instance_data->logging_messenger.back();
408 layer_destroy_messenger_callback(instance_data->report_data, messenger, pAllocator);
409 instance_data->logging_messenger.pop_back();
410 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600411 while (instance_data->logging_callback.size() > 0) {
412 VkDebugReportCallbackEXT callback = instance_data->logging_callback.back();
Mark Young6ba8abe2017-11-09 10:37:04 -0700413 layer_destroy_report_callback(instance_data->report_data, callback, pAllocator);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600414 instance_data->logging_callback.pop_back();
415 }
416
Mark Young6ba8abe2017-11-09 10:37:04 -0700417 layer_debug_utils_destroy_instance(instance_data->report_data);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600418 }
419
420 FreeLayerDataPtr(key, instance_layer_data_map);
421}
422
423VKAPI_ATTR VkResult VKAPI_CALL vkCreateDebugReportCallbackEXT(VkInstance instance,
424 const VkDebugReportCallbackCreateInfoEXT *pCreateInfo,
425 const VkAllocationCallbacks *pAllocator,
426 VkDebugReportCallbackEXT *pMsgCallback) {
427 bool skip = parameter_validation_vkCreateDebugReportCallbackEXT(instance, pCreateInfo, pAllocator, pMsgCallback);
428 if (skip) return VK_ERROR_VALIDATION_FAILED_EXT;
429
430 auto instance_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map);
431 VkResult result = instance_data->dispatch_table.CreateDebugReportCallbackEXT(instance, pCreateInfo, pAllocator, pMsgCallback);
432 if (result == VK_SUCCESS) {
Mark Young6ba8abe2017-11-09 10:37:04 -0700433 result = layer_create_report_callback(instance_data->report_data, false, pCreateInfo, pAllocator, pMsgCallback);
434 // If something happened during this call, clean up the message callback that was created earlier in the lower levels
435 if (VK_SUCCESS != result) {
436 instance_data->dispatch_table.DestroyDebugReportCallbackEXT(instance, *pMsgCallback, pAllocator);
437 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600438 }
439 return result;
440}
441
442VKAPI_ATTR void VKAPI_CALL vkDestroyDebugReportCallbackEXT(VkInstance instance, VkDebugReportCallbackEXT msgCallback,
443 const VkAllocationCallbacks *pAllocator) {
444 bool skip = parameter_validation_vkDestroyDebugReportCallbackEXT(instance, msgCallback, pAllocator);
445 if (!skip) {
446 auto instance_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map);
447 instance_data->dispatch_table.DestroyDebugReportCallbackEXT(instance, msgCallback, pAllocator);
Mark Young6ba8abe2017-11-09 10:37:04 -0700448 layer_destroy_report_callback(instance_data->report_data, msgCallback, pAllocator);
449 }
450}
451
452VKAPI_ATTR VkResult VKAPI_CALL vkCreateDebugUtilsMessengerEXT(VkInstance instance,
453 const VkDebugUtilsMessengerCreateInfoEXT *pCreateInfo,
454 const VkAllocationCallbacks *pAllocator,
455 VkDebugUtilsMessengerEXT *pMessenger) {
456 bool skip = parameter_validation_vkCreateDebugUtilsMessengerEXT(instance, pCreateInfo, pAllocator, pMessenger);
457 if (skip) return VK_ERROR_VALIDATION_FAILED_EXT;
458
459 auto instance_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map);
460 VkResult result = instance_data->dispatch_table.CreateDebugUtilsMessengerEXT(instance, pCreateInfo, pAllocator, pMessenger);
461 if (VK_SUCCESS == result) {
462 result = layer_create_messenger_callback(instance_data->report_data, false, pCreateInfo, pAllocator, pMessenger);
463 // If something happened during this call, clean up the message callback that was created earlier in the lower levels
464 if (VK_SUCCESS != result) {
465 instance_data->dispatch_table.DestroyDebugUtilsMessengerEXT(instance, *pMessenger, pAllocator);
466 }
467 }
468 return result;
469}
470
471VKAPI_ATTR void VKAPI_CALL vkDestroyDebugUtilsMessengerEXT(VkInstance instance, VkDebugUtilsMessengerEXT messenger,
472 const VkAllocationCallbacks *pAllocator) {
473 bool skip = parameter_validation_vkDestroyDebugUtilsMessengerEXT(instance, messenger, pAllocator);
474 if (!skip) {
475 auto instance_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map);
476 instance_data->dispatch_table.DestroyDebugUtilsMessengerEXT(instance, messenger, pAllocator);
477 layer_destroy_messenger_callback(instance_data->report_data, messenger, pAllocator);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600478 }
479}
480
John Zulauf620755c2018-04-16 11:00:43 -0600481template <typename ExtensionState>
482static bool extension_state_by_name(const ExtensionState &extensions, const char *extension_name) {
483 if (!extension_name) return false; // null strings specify nothing
484 auto info = ExtensionState::get_info(extension_name);
485 bool state = info.state ? extensions.*(info.state) : false; // unknown extensions can't be enabled in extension struct
486 return state;
487}
488
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600489static bool ValidateDeviceCreateInfo(instance_layer_data *instance_data, VkPhysicalDevice physicalDevice,
John Zulauf620755c2018-04-16 11:00:43 -0600490 const VkDeviceCreateInfo *pCreateInfo, const DeviceExtensions &extensions) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600491 bool skip = false;
John Zulauf620755c2018-04-16 11:00:43 -0600492 bool maint1 = false;
493 bool negative_viewport = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600494
495 if ((pCreateInfo->enabledLayerCount > 0) && (pCreateInfo->ppEnabledLayerNames != NULL)) {
496 for (size_t i = 0; i < pCreateInfo->enabledLayerCount; i++) {
497 skip |= validate_string(instance_data->report_data, "vkCreateDevice", "pCreateInfo->ppEnabledLayerNames",
Mark Lobodzinskiebee3552018-05-29 09:55:54 -0600498 "VUID-VkDeviceCreateInfo-ppEnabledLayerNames-parameter", pCreateInfo->ppEnabledLayerNames[i]);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600499 }
500 }
501
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600502 if ((pCreateInfo->enabledExtensionCount > 0) && (pCreateInfo->ppEnabledExtensionNames != NULL)) {
John Zulauf620755c2018-04-16 11:00:43 -0600503 maint1 = extension_state_by_name(extensions, VK_KHR_MAINTENANCE1_EXTENSION_NAME);
504 negative_viewport = extension_state_by_name(extensions, VK_AMD_NEGATIVE_VIEWPORT_HEIGHT_EXTENSION_NAME);
505
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600506 for (size_t i = 0; i < pCreateInfo->enabledExtensionCount; i++) {
507 skip |= validate_string(instance_data->report_data, "vkCreateDevice", "pCreateInfo->ppEnabledExtensionNames",
Mark Lobodzinskiebee3552018-05-29 09:55:54 -0600508 "VUID-VkDeviceCreateInfo-ppEnabledExtensionNames-parameter",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600509 pCreateInfo->ppEnabledExtensionNames[i]);
Dave Houlton413a6782018-05-22 13:01:54 -0600510 skip |= validate_extension_reqs(instance_data, extensions, "VUID-vkCreateDevice-ppEnabledExtensionNames-01387",
511 "device", pCreateInfo->ppEnabledExtensionNames[i]);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600512 }
513 }
514
515 if (maint1 && negative_viewport) {
516 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600517 "VUID-VkDeviceCreateInfo-ppEnabledExtensionNames-00374",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600518 "VkDeviceCreateInfo->ppEnabledExtensionNames must not simultaneously include VK_KHR_maintenance1 and "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600519 "VK_AMD_negative_viewport_height.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600520 }
521
522 if (pCreateInfo->pNext != NULL && pCreateInfo->pEnabledFeatures) {
523 // Check for get_physical_device_properties2 struct
John Zulaufde972ac2017-10-26 12:07:05 -0600524 const auto *features2 = lvl_find_in_chain<VkPhysicalDeviceFeatures2KHR>(pCreateInfo->pNext);
525 if (features2) {
526 // Cannot include VkPhysicalDeviceFeatures2KHR and have non-null pEnabledFeatures
527 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600528 kVUID_PVError_InvalidUsage,
John Zulaufde972ac2017-10-26 12:07:05 -0600529 "VkDeviceCreateInfo->pNext includes a VkPhysicalDeviceFeatures2KHR struct when "
530 "pCreateInfo->pEnabledFeatures is non-NULL.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600531 }
532 }
533
534 // Validate pCreateInfo->pQueueCreateInfos
535 if (pCreateInfo->pQueueCreateInfos) {
536 std::unordered_set<uint32_t> set;
537
538 for (uint32_t i = 0; i < pCreateInfo->queueCreateInfoCount; ++i) {
539 const uint32_t requested_queue_family = pCreateInfo->pQueueCreateInfos[i].queueFamilyIndex;
540 if (requested_queue_family == VK_QUEUE_FAMILY_IGNORED) {
541 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT,
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600542 VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, HandleToUint64(physicalDevice),
Dave Houlton413a6782018-05-22 13:01:54 -0600543 "VUID-VkDeviceQueueCreateInfo-queueFamilyIndex-00381",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600544 "vkCreateDevice: pCreateInfo->pQueueCreateInfos[%" PRIu32
Dave Houltona9df0ce2018-02-07 10:51:23 -0700545 "].queueFamilyIndex is VK_QUEUE_FAMILY_IGNORED, but it is required to provide a valid queue family "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600546 "index value.",
547 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600548 } else if (set.count(requested_queue_family)) {
549 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT,
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600550 VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, HandleToUint64(physicalDevice),
Dave Houlton413a6782018-05-22 13:01:54 -0600551 "VUID-VkDeviceCreateInfo-queueFamilyIndex-00372",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600552 "vkCreateDevice: pCreateInfo->pQueueCreateInfos[%" PRIu32 "].queueFamilyIndex (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600553 ") is not unique within pCreateInfo->pQueueCreateInfos array.",
554 i, requested_queue_family);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600555 } else {
556 set.insert(requested_queue_family);
557 }
558
559 if (pCreateInfo->pQueueCreateInfos[i].pQueuePriorities != nullptr) {
560 for (uint32_t j = 0; j < pCreateInfo->pQueueCreateInfos[i].queueCount; ++j) {
561 const float queue_priority = pCreateInfo->pQueueCreateInfos[i].pQueuePriorities[j];
562 if (!(queue_priority >= 0.f) || !(queue_priority <= 1.f)) {
563 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT,
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600564 VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, HandleToUint64(physicalDevice),
Dave Houlton413a6782018-05-22 13:01:54 -0600565 "VUID-VkDeviceQueueCreateInfo-pQueuePriorities-00383",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600566 "vkCreateDevice: pCreateInfo->pQueueCreateInfos[%" PRIu32 "].pQueuePriorities[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600567 "] (=%f) is not between 0 and 1 (inclusive).",
568 i, j, queue_priority);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600569 }
570 }
571 }
572 }
573 }
574
575 return skip;
576}
577
578VKAPI_ATTR VkResult VKAPI_CALL vkCreateDevice(VkPhysicalDevice physicalDevice, const VkDeviceCreateInfo *pCreateInfo,
579 const VkAllocationCallbacks *pAllocator, VkDevice *pDevice) {
580 // NOTE: Don't validate physicalDevice or any dispatchable object as the first parameter. We couldn't get here if it was wrong!
581
582 VkResult result = VK_ERROR_VALIDATION_FAILED_EXT;
583 bool skip = false;
584 auto my_instance_data = GetLayerDataPtr(get_dispatch_key(physicalDevice), instance_layer_data_map);
585 assert(my_instance_data != nullptr);
John Zulauf620755c2018-04-16 11:00:43 -0600586
587 // Query and save physical device limits for this device, needed for validation
588 VkPhysicalDeviceProperties device_properties = {};
589 my_instance_data->dispatch_table.GetPhysicalDeviceProperties(physicalDevice, &device_properties);
590
John Zulauf1909e6a2018-09-05 11:43:11 -0600591 // Setup the validation tables based on the application API version from the instance and the capabilities of the device driver.
592 uint32_t effective_api_version = std::min(device_properties.apiVersion, my_instance_data->api_version);
John Zulauf620755c2018-04-16 11:00:43 -0600593 DeviceExtensions extensions;
John Zulauf1909e6a2018-09-05 11:43:11 -0600594 uint32_t api_version = extensions.InitFromDeviceCreateInfo(&my_instance_data->extensions, effective_api_version, pCreateInfo);
John Zulauf620755c2018-04-16 11:00:43 -0600595
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600596 std::unique_lock<std::mutex> lock(global_lock);
597
598 skip |= parameter_validation_vkCreateDevice(physicalDevice, pCreateInfo, pAllocator, pDevice);
599
John Zulauf620755c2018-04-16 11:00:43 -0600600 if (pCreateInfo != NULL) skip |= ValidateDeviceCreateInfo(my_instance_data, physicalDevice, pCreateInfo, extensions);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600601
602 if (!skip) {
603 VkLayerDeviceCreateInfo *chain_info = get_chain_info(pCreateInfo, VK_LAYER_LINK_INFO);
604 assert(chain_info != nullptr);
605 assert(chain_info->u.pLayerInfo != nullptr);
606
607 PFN_vkGetInstanceProcAddr fpGetInstanceProcAddr = chain_info->u.pLayerInfo->pfnNextGetInstanceProcAddr;
608 PFN_vkGetDeviceProcAddr fpGetDeviceProcAddr = chain_info->u.pLayerInfo->pfnNextGetDeviceProcAddr;
609 PFN_vkCreateDevice fpCreateDevice = (PFN_vkCreateDevice)fpGetInstanceProcAddr(my_instance_data->instance, "vkCreateDevice");
610 if (fpCreateDevice == NULL) {
611 return VK_ERROR_INITIALIZATION_FAILED;
612 }
613
614 // Advance the link info for the next element on the chain
615 chain_info->u.pLayerInfo = chain_info->u.pLayerInfo->pNext;
616
617 lock.unlock();
618
619 result = fpCreateDevice(physicalDevice, pCreateInfo, pAllocator, pDevice);
620
621 lock.lock();
622
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600623 if (result == VK_SUCCESS) {
624 layer_data *my_device_data = GetLayerDataPtr(get_dispatch_key(*pDevice), layer_data_map);
625 assert(my_device_data != nullptr);
626
Mark Young6ba8abe2017-11-09 10:37:04 -0700627 my_device_data->report_data = layer_debug_utils_create_device(my_instance_data->report_data, *pDevice);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600628 layer_init_device_dispatch_table(*pDevice, &my_device_data->dispatch_table, fpGetDeviceProcAddr);
629
John Zulauf620755c2018-04-16 11:00:43 -0600630 my_device_data->api_version = api_version;
631 my_device_data->extensions = extensions;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600632
633 // Store createdevice data
634 if ((pCreateInfo != nullptr) && (pCreateInfo->pQueueCreateInfos != nullptr)) {
635 for (uint32_t i = 0; i < pCreateInfo->queueCreateInfoCount; ++i) {
636 my_device_data->queueFamilyIndexMap.insert(std::make_pair(pCreateInfo->pQueueCreateInfos[i].queueFamilyIndex,
637 pCreateInfo->pQueueCreateInfos[i].queueCount));
638 }
639 }
640
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600641 memcpy(&my_device_data->device_limits, &device_properties.limits, sizeof(VkPhysicalDeviceLimits));
642 my_device_data->physical_device = physicalDevice;
643 my_device_data->device = *pDevice;
644
Jeff Bolz5d2b7432018-09-06 10:32:36 -0500645 if (my_device_data->extensions.vk_nv_shading_rate_image) {
646 // Get the needed shading rate image limits
647 auto shading_rate_image_props = lvl_init_struct<VkPhysicalDeviceShadingRateImagePropertiesNV>();
648 auto prop2 = lvl_init_struct<VkPhysicalDeviceProperties2KHR>(&shading_rate_image_props);
649 my_instance_data->dispatch_table.GetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
650 my_device_data->phys_dev_ext_props.shading_rate_image_props = shading_rate_image_props;
651 }
652
Jeff Bolz45bf7d62018-09-18 15:39:58 -0500653 if (my_device_data->extensions.vk_nv_mesh_shader) {
654 // Get the needed mesh shader limits
655 auto mesh_shader_props = lvl_init_struct<VkPhysicalDeviceMeshShaderPropertiesNV>();
656 auto prop2 = lvl_init_struct<VkPhysicalDeviceProperties2KHR>(&mesh_shader_props);
657 my_instance_data->dispatch_table.GetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
658 my_device_data->phys_dev_ext_props.mesh_shader_props = mesh_shader_props;
659 }
660
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600661 // Save app-enabled features in this device's layer_data structure
John Zulauf1bde5bb2017-10-18 18:21:23 -0600662 // The enabled features can come from either pEnabledFeatures, or from the pNext chain
663 const VkPhysicalDeviceFeatures *enabled_features_found = pCreateInfo->pEnabledFeatures;
664 if ((nullptr == enabled_features_found) && my_device_data->extensions.vk_khr_get_physical_device_properties_2) {
John Zulaufde972ac2017-10-26 12:07:05 -0600665 const auto *features2 = lvl_find_in_chain<VkPhysicalDeviceFeatures2KHR>(pCreateInfo->pNext);
666 if (features2) {
667 enabled_features_found = &(features2->features);
John Zulauf1bde5bb2017-10-18 18:21:23 -0600668 }
669 }
670 if (enabled_features_found) {
Dave Houltonb3bbec72018-01-17 10:13:33 -0700671 my_device_data->physical_device_features = *enabled_features_found;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600672 } else {
673 memset(&my_device_data->physical_device_features, 0, sizeof(VkPhysicalDeviceFeatures));
674 }
675 }
676 }
677
678 return result;
679}
680
681VKAPI_ATTR void VKAPI_CALL vkDestroyDevice(VkDevice device, const VkAllocationCallbacks *pAllocator) {
682 dispatch_key key = get_dispatch_key(device);
683 bool skip = false;
684 layer_data *device_data = GetLayerDataPtr(key, layer_data_map);
685 {
686 std::unique_lock<std::mutex> lock(global_lock);
687 skip |= parameter_validation_vkDestroyDevice(device, pAllocator);
688 }
689
690 if (!skip) {
Mark Young6ba8abe2017-11-09 10:37:04 -0700691 layer_debug_utils_destroy_device(device);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600692 device_data->dispatch_table.DestroyDevice(device, pAllocator);
693 }
694 FreeLayerDataPtr(key, layer_data_map);
695}
696
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600697bool pv_vkGetDeviceQueue(VkDevice device, uint32_t queueFamilyIndex, uint32_t queueIndex, VkQueue *pQueue) {
698 bool skip = false;
699 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
700
Dave Houlton413a6782018-05-22 13:01:54 -0600701 skip |= ValidateDeviceQueueFamily(device_data, queueFamilyIndex, "vkGetDeviceQueue", "queueFamilyIndex",
702 "VUID-vkGetDeviceQueue-queueFamilyIndex-00384");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600703 const auto &queue_data = device_data->queueFamilyIndexMap.find(queueFamilyIndex);
704 if (queue_data != device_data->queueFamilyIndexMap.end() && queue_data->second <= queueIndex) {
705 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -0600706 HandleToUint64(device), "VUID-vkGetDeviceQueue-queueIndex-00385",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600707 "vkGetDeviceQueue: queueIndex (=%" PRIu32
Dave Houltona9df0ce2018-02-07 10:51:23 -0700708 ") is not less than the number of queues requested from queueFamilyIndex (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600709 ") when the device was created (i.e. is not less than %" PRIu32 ").",
710 queueIndex, queueFamilyIndex, queue_data->second);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600711 }
712 return skip;
713}
714
715VKAPI_ATTR VkResult VKAPI_CALL vkCreateCommandPool(VkDevice device, const VkCommandPoolCreateInfo *pCreateInfo,
716 const VkAllocationCallbacks *pAllocator, VkCommandPool *pCommandPool) {
717 layer_data *local_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
718 bool skip = false;
719 VkResult result = VK_ERROR_VALIDATION_FAILED_EXT;
720 std::unique_lock<std::mutex> lock(global_lock);
721
722 skip |= ValidateDeviceQueueFamily(local_data, pCreateInfo->queueFamilyIndex, "vkCreateCommandPool",
Dave Houlton341c0052018-06-21 15:00:45 -0600723 "pCreateInfo->queueFamilyIndex", "VUID-vkCreateCommandPool-queueFamilyIndex-01937");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600724
725 skip |= parameter_validation_vkCreateCommandPool(device, pCreateInfo, pAllocator, pCommandPool);
726
727 lock.unlock();
728 if (!skip) {
729 result = local_data->dispatch_table.CreateCommandPool(device, pCreateInfo, pAllocator, pCommandPool);
730 }
731 return result;
732}
733
734VKAPI_ATTR VkResult VKAPI_CALL vkCreateQueryPool(VkDevice device, const VkQueryPoolCreateInfo *pCreateInfo,
735 const VkAllocationCallbacks *pAllocator, VkQueryPool *pQueryPool) {
736 VkResult result = VK_ERROR_VALIDATION_FAILED_EXT;
737 bool skip = false;
738 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
739
740 skip |= parameter_validation_vkCreateQueryPool(device, pCreateInfo, pAllocator, pQueryPool);
741
742 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
743 if (pCreateInfo != nullptr) {
744 // If queryType is VK_QUERY_TYPE_PIPELINE_STATISTICS, pipelineStatistics must be a valid combination of
745 // VkQueryPipelineStatisticFlagBits values
746 if ((pCreateInfo->queryType == VK_QUERY_TYPE_PIPELINE_STATISTICS) && (pCreateInfo->pipelineStatistics != 0) &&
747 ((pCreateInfo->pipelineStatistics & (~AllVkQueryPipelineStatisticFlagBits)) != 0)) {
748 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600749 "VUID-VkQueryPoolCreateInfo-queryType-00792",
Dave Houltona9df0ce2018-02-07 10:51:23 -0700750 "vkCreateQueryPool(): if pCreateInfo->queryType is VK_QUERY_TYPE_PIPELINE_STATISTICS, "
751 "pCreateInfo->pipelineStatistics must be a valid combination of VkQueryPipelineStatisticFlagBits "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600752 "values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600753 }
754 }
755 if (!skip) {
756 result = device_data->dispatch_table.CreateQueryPool(device, pCreateInfo, pAllocator, pQueryPool);
757 }
758 return result;
759}
760
Petr Krause91f7a12017-12-14 20:57:36 +0100761VKAPI_ATTR VkResult VKAPI_CALL vkCreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo,
762 const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass) {
763 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
764 bool skip = false;
765 VkResult result = VK_ERROR_VALIDATION_FAILED_EXT;
766
767 {
768 std::unique_lock<std::mutex> lock(global_lock);
769 skip |= parameter_validation_vkCreateRenderPass(device, pCreateInfo, pAllocator, pRenderPass);
770
Dave Houltonb3bbec72018-01-17 10:13:33 -0700771 typedef bool (*PFN_manual_vkCreateRenderPass)(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo,
772 const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass);
Petr Krause91f7a12017-12-14 20:57:36 +0100773 PFN_manual_vkCreateRenderPass custom_func = (PFN_manual_vkCreateRenderPass)custom_functions["vkCreateRenderPass"];
774 if (custom_func != nullptr) {
775 skip |= custom_func(device, pCreateInfo, pAllocator, pRenderPass);
776 }
777 }
778
779 if (!skip) {
780 result = device_data->dispatch_table.CreateRenderPass(device, pCreateInfo, pAllocator, pRenderPass);
781
782 // track the state necessary for checking vkCreateGraphicsPipeline (subpass usage of depth and color attachments)
783 if (result == VK_SUCCESS) {
784 std::unique_lock<std::mutex> lock(global_lock);
785 const auto renderPass = *pRenderPass;
786 auto &renderpass_state = device_data->renderpasses_states[renderPass];
787
788 for (uint32_t subpass = 0; subpass < pCreateInfo->subpassCount; ++subpass) {
789 bool uses_color = false;
790 for (uint32_t i = 0; i < pCreateInfo->pSubpasses[subpass].colorAttachmentCount && !uses_color; ++i)
791 if (pCreateInfo->pSubpasses[subpass].pColorAttachments[i].attachment != VK_ATTACHMENT_UNUSED) uses_color = true;
792
793 bool uses_depthstencil = false;
794 if (pCreateInfo->pSubpasses[subpass].pDepthStencilAttachment)
795 if (pCreateInfo->pSubpasses[subpass].pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED)
796 uses_depthstencil = true;
797
798 if (uses_color) renderpass_state.subpasses_using_color_attachment.insert(subpass);
799 if (uses_depthstencil) renderpass_state.subpasses_using_depthstencil_attachment.insert(subpass);
800 }
801 }
802 }
803 return result;
804}
805
806VKAPI_ATTR void VKAPI_CALL vkDestroyRenderPass(VkDevice device, VkRenderPass renderPass, const VkAllocationCallbacks *pAllocator) {
807 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
808 bool skip = false;
809
810 {
811 std::unique_lock<std::mutex> lock(global_lock);
812 skip |= parameter_validation_vkDestroyRenderPass(device, renderPass, pAllocator);
813
Dave Houltonb3bbec72018-01-17 10:13:33 -0700814 typedef bool (*PFN_manual_vkDestroyRenderPass)(VkDevice device, VkRenderPass renderPass,
815 const VkAllocationCallbacks *pAllocator);
Petr Krause91f7a12017-12-14 20:57:36 +0100816 PFN_manual_vkDestroyRenderPass custom_func = (PFN_manual_vkDestroyRenderPass)custom_functions["vkDestroyRenderPass"];
817 if (custom_func != nullptr) {
818 skip |= custom_func(device, renderPass, pAllocator);
819 }
820 }
821
822 if (!skip) {
823 device_data->dispatch_table.DestroyRenderPass(device, renderPass, pAllocator);
824
825 // track the state necessary for checking vkCreateGraphicsPipeline (subpass usage of depth and color attachments)
826 {
827 std::unique_lock<std::mutex> lock(global_lock);
828 device_data->renderpasses_states.erase(renderPass);
829 }
830 }
831}
832
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600833bool pv_vkCreateBuffer(VkDevice device, const VkBufferCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
834 VkBuffer *pBuffer) {
835 bool skip = false;
836 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
837 debug_report_data *report_data = device_data->report_data;
838
Mark Lobodzinski88529492018-04-01 10:38:15 -0600839 const LogMiscParams log_misc{report_data, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, VK_NULL_HANDLE, "vkCreateBuffer"};
Petr Krause5c37652018-01-05 04:05:12 +0100840
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600841 if (pCreateInfo != nullptr) {
Dave Houlton413a6782018-05-22 13:01:54 -0600842 skip |= ValidateGreaterThanZero(pCreateInfo->size, "pCreateInfo->size", "VUID-VkBufferCreateInfo-size-00912", log_misc);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600843
844 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
845 if (pCreateInfo->sharingMode == VK_SHARING_MODE_CONCURRENT) {
846 // If sharingMode is VK_SHARING_MODE_CONCURRENT, queueFamilyIndexCount must be greater than 1
847 if (pCreateInfo->queueFamilyIndexCount <= 1) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600848 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600849 "VUID-VkBufferCreateInfo-sharingMode-00914",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600850 "vkCreateBuffer: if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600851 "pCreateInfo->queueFamilyIndexCount must be greater than 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600852 }
853
854 // If sharingMode is VK_SHARING_MODE_CONCURRENT, pQueueFamilyIndices must be a pointer to an array of
855 // queueFamilyIndexCount uint32_t values
856 if (pCreateInfo->pQueueFamilyIndices == nullptr) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600857 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600858 "VUID-VkBufferCreateInfo-sharingMode-00913",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600859 "vkCreateBuffer: if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
860 "pCreateInfo->pQueueFamilyIndices must be a pointer to an array of "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600861 "pCreateInfo->queueFamilyIndexCount uint32_t values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600862 } else {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600863 skip |= ValidateQueueFamilies(device_data, pCreateInfo->queueFamilyIndexCount, pCreateInfo->pQueueFamilyIndices,
Dave Houlton413a6782018-05-22 13:01:54 -0600864 "vkCreateBuffer", "pCreateInfo->pQueueFamilyIndices", kVUID_PVError_InvalidUsage,
865 kVUID_PVError_InvalidUsage, false);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600866 }
867 }
868
869 // If flags contains VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT or VK_BUFFER_CREATE_SPARSE_ALIASED_BIT, it must also contain
870 // VK_BUFFER_CREATE_SPARSE_BINDING_BIT
871 if (((pCreateInfo->flags & (VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT | VK_BUFFER_CREATE_SPARSE_ALIASED_BIT)) != 0) &&
872 ((pCreateInfo->flags & VK_BUFFER_CREATE_SPARSE_BINDING_BIT) != VK_BUFFER_CREATE_SPARSE_BINDING_BIT)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600873 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600874 "VUID-VkBufferCreateInfo-flags-00918",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600875 "vkCreateBuffer: if pCreateInfo->flags contains VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT or "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600876 "VK_BUFFER_CREATE_SPARSE_ALIASED_BIT, it must also contain VK_BUFFER_CREATE_SPARSE_BINDING_BIT.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600877 }
878 }
879
880 return skip;
881}
882
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600883bool pv_vkCreateImage(VkDevice device, const VkImageCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
884 VkImage *pImage) {
885 bool skip = false;
886 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
887 debug_report_data *report_data = device_data->report_data;
888
Mark Lobodzinski88529492018-04-01 10:38:15 -0600889 const LogMiscParams log_misc{report_data, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, VK_NULL_HANDLE, "vkCreateImage"};
Petr Krause5c37652018-01-05 04:05:12 +0100890
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600891 if (pCreateInfo != nullptr) {
892 if ((device_data->physical_device_features.textureCompressionETC2 == false) &&
893 FormatIsCompressed_ETC2_EAC(pCreateInfo->format)) {
Dave Houlton413a6782018-05-22 13:01:54 -0600894 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
895 kVUID_PVError_DeviceFeature,
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600896 "vkCreateImage(): Attempting to create VkImage with format %s. The textureCompressionETC2 feature is "
897 "not enabled: neither ETC2 nor EAC formats can be used to create images.",
898 string_VkFormat(pCreateInfo->format));
899 }
900
901 if ((device_data->physical_device_features.textureCompressionASTC_LDR == false) &&
902 FormatIsCompressed_ASTC_LDR(pCreateInfo->format)) {
Dave Houlton413a6782018-05-22 13:01:54 -0600903 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
904 kVUID_PVError_DeviceFeature,
Dave Houltona9df0ce2018-02-07 10:51:23 -0700905 "vkCreateImage(): Attempting to create VkImage with format %s. The textureCompressionASTC_LDR feature "
906 "is not enabled: ASTC formats cannot be used to create images.",
907 string_VkFormat(pCreateInfo->format));
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600908 }
909
910 if ((device_data->physical_device_features.textureCompressionBC == false) && FormatIsCompressed_BC(pCreateInfo->format)) {
Dave Houlton413a6782018-05-22 13:01:54 -0600911 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
912 kVUID_PVError_DeviceFeature,
Dave Houltona9df0ce2018-02-07 10:51:23 -0700913 "vkCreateImage(): Attempting to create VkImage with format %s. The textureCompressionBC feature is not "
914 "enabled: BC compressed formats cannot be used to create images.",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600915 string_VkFormat(pCreateInfo->format));
916 }
917
918 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
919 if (pCreateInfo->sharingMode == VK_SHARING_MODE_CONCURRENT) {
920 // If sharingMode is VK_SHARING_MODE_CONCURRENT, queueFamilyIndexCount must be greater than 1
921 if (pCreateInfo->queueFamilyIndexCount <= 1) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600922 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600923 "VUID-VkImageCreateInfo-sharingMode-00942",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600924 "vkCreateImage(): if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600925 "pCreateInfo->queueFamilyIndexCount must be greater than 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600926 }
927
928 // If sharingMode is VK_SHARING_MODE_CONCURRENT, pQueueFamilyIndices must be a pointer to an array of
929 // queueFamilyIndexCount uint32_t values
930 if (pCreateInfo->pQueueFamilyIndices == nullptr) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600931 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600932 "VUID-VkImageCreateInfo-sharingMode-00941",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600933 "vkCreateImage(): if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
934 "pCreateInfo->pQueueFamilyIndices must be a pointer to an array of "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600935 "pCreateInfo->queueFamilyIndexCount uint32_t values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600936 } else {
Dave Houlton413a6782018-05-22 13:01:54 -0600937 skip |= ValidateQueueFamilies(device_data, pCreateInfo->queueFamilyIndexCount, pCreateInfo->pQueueFamilyIndices,
938 "vkCreateImage", "pCreateInfo->pQueueFamilyIndices", kVUID_PVError_InvalidUsage,
939 kVUID_PVError_InvalidUsage, false);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600940 }
941 }
942
Dave Houlton413a6782018-05-22 13:01:54 -0600943 skip |= ValidateGreaterThanZero(pCreateInfo->extent.width, "pCreateInfo->extent.width",
944 "VUID-VkImageCreateInfo-extent-00944", log_misc);
945 skip |= ValidateGreaterThanZero(pCreateInfo->extent.height, "pCreateInfo->extent.height",
946 "VUID-VkImageCreateInfo-extent-00945", log_misc);
947 skip |= ValidateGreaterThanZero(pCreateInfo->extent.depth, "pCreateInfo->extent.depth",
948 "VUID-VkImageCreateInfo-extent-00946", log_misc);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600949
Dave Houlton413a6782018-05-22 13:01:54 -0600950 skip |= ValidateGreaterThanZero(pCreateInfo->mipLevels, "pCreateInfo->mipLevels", "VUID-VkImageCreateInfo-mipLevels-00947",
951 log_misc);
952 skip |= ValidateGreaterThanZero(pCreateInfo->arrayLayers, "pCreateInfo->arrayLayers",
953 "VUID-VkImageCreateInfo-arrayLayers-00948", log_misc);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600954
Dave Houlton130c0212018-01-29 13:39:56 -0700955 // InitialLayout must be PREINITIALIZED or UNDEFINED
Dave Houltone19e20d2018-02-02 16:32:41 -0700956 if ((pCreateInfo->initialLayout != VK_IMAGE_LAYOUT_UNDEFINED) &&
957 (pCreateInfo->initialLayout != VK_IMAGE_LAYOUT_PREINITIALIZED)) {
958 skip |= log_msg(
Dave Houlton413a6782018-05-22 13:01:54 -0600959 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
960 "VUID-VkImageCreateInfo-initialLayout-00993",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600961 "vkCreateImage(): initialLayout is %s, must be VK_IMAGE_LAYOUT_UNDEFINED or VK_IMAGE_LAYOUT_PREINITIALIZED.",
962 string_VkImageLayout(pCreateInfo->initialLayout));
Dave Houlton130c0212018-01-29 13:39:56 -0700963 }
964
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600965 // If imageType is VK_IMAGE_TYPE_1D, both extent.height and extent.depth must be 1
Petr Kraus3ac9e812018-03-13 12:31:08 +0100966 if ((pCreateInfo->imageType == VK_IMAGE_TYPE_1D) &&
967 ((pCreateInfo->extent.height != 1) || (pCreateInfo->extent.depth != 1))) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600968 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600969 "VUID-VkImageCreateInfo-imageType-00956",
Dave Houltona9df0ce2018-02-07 10:51:23 -0700970 "vkCreateImage(): if pCreateInfo->imageType is VK_IMAGE_TYPE_1D, both pCreateInfo->extent.height and "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600971 "pCreateInfo->extent.depth must be 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600972 }
973
974 if (pCreateInfo->imageType == VK_IMAGE_TYPE_2D) {
Petr Kraus3f433212018-03-13 12:31:27 +0100975 if (pCreateInfo->flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) {
976 if (pCreateInfo->extent.width != pCreateInfo->extent.height) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600977 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -0600978 VK_NULL_HANDLE, "VUID-VkImageCreateInfo-imageType-00954",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600979 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT, but "
980 "pCreateInfo->extent.width (=%" PRIu32 ") and pCreateInfo->extent.height (=%" PRIu32
981 ") are not equal.",
982 pCreateInfo->extent.width, pCreateInfo->extent.height);
Petr Kraus3f433212018-03-13 12:31:27 +0100983 }
984
985 if (pCreateInfo->arrayLayers < 6) {
986 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -0600987 VK_NULL_HANDLE, "VUID-VkImageCreateInfo-imageType-00954",
Petr Kraus3f433212018-03-13 12:31:27 +0100988 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT, but "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600989 "pCreateInfo->arrayLayers (=%" PRIu32 ") is not greater than or equal to 6.",
990 pCreateInfo->arrayLayers);
Petr Kraus3f433212018-03-13 12:31:27 +0100991 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600992 }
993
994 if (pCreateInfo->extent.depth != 1) {
Mark Lobodzinski88529492018-04-01 10:38:15 -0600995 skip |=
996 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600997 "VUID-VkImageCreateInfo-imageType-00957",
Mark Lobodzinski88529492018-04-01 10:38:15 -0600998 "vkCreateImage(): if pCreateInfo->imageType is VK_IMAGE_TYPE_2D, pCreateInfo->extent.depth must be 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600999 }
1000 }
1001
Dave Houlton130c0212018-01-29 13:39:56 -07001002 // 3D image may have only 1 layer
1003 if ((pCreateInfo->imageType == VK_IMAGE_TYPE_3D) && (pCreateInfo->arrayLayers != 1)) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06001004 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001005 "VUID-VkImageCreateInfo-imageType-00961",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001006 "vkCreateImage(): if pCreateInfo->imageType is VK_IMAGE_TYPE_3D, pCreateInfo->arrayLayers must be 1.");
Dave Houlton130c0212018-01-29 13:39:56 -07001007 }
1008
1009 // If multi-sample, validate type, usage, tiling and mip levels.
1010 if ((pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT) &&
1011 ((pCreateInfo->imageType != VK_IMAGE_TYPE_2D) || (pCreateInfo->flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) ||
1012 (pCreateInfo->tiling != VK_IMAGE_TILING_OPTIMAL) || (pCreateInfo->mipLevels != 1))) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001013 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001014 "VUID-VkImageCreateInfo-samples-00962",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001015 "vkCreateImage(): Multi-sample image with incompatible type, usage, tiling, or mips.");
Dave Houlton130c0212018-01-29 13:39:56 -07001016 }
1017
1018 if (0 != (pCreateInfo->usage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT)) {
1019 VkImageUsageFlags legal_flags = (VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT | VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT |
1020 VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT);
1021 // At least one of the legal attachment bits must be set
1022 if (0 == (pCreateInfo->usage & legal_flags)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001023 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001024 "VUID-VkImageCreateInfo-usage-00966",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001025 "vkCreateImage(): Transient attachment image without a compatible attachment flag set.");
Dave Houlton130c0212018-01-29 13:39:56 -07001026 }
1027 // No flags other than the legal attachment bits may be set
1028 legal_flags |= VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT;
1029 if (0 != (pCreateInfo->usage & ~legal_flags)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001030 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001031 "VUID-VkImageCreateInfo-usage-00963",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001032 "vkCreateImage(): Transient attachment image with incompatible usage flags set.");
Dave Houlton130c0212018-01-29 13:39:56 -07001033 }
1034 }
1035
Jeff Bolzef40fec2018-09-01 22:04:34 -05001036 // mipLevels must be less than or equal to the number of levels in the complete mipmap chain
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001037 uint32_t maxDim = std::max(std::max(pCreateInfo->extent.width, pCreateInfo->extent.height), pCreateInfo->extent.depth);
Jeff Bolzef40fec2018-09-01 22:04:34 -05001038 // Max mip levels is different for corner-sampled images vs normal images.
1039 uint32_t maxMipLevels = (pCreateInfo->flags & VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV)
1040 ? (uint32_t)(ceil(log2(maxDim)))
1041 : (uint32_t)(floor(log2(maxDim)) + 1);
1042 if (maxDim > 0 && pCreateInfo->mipLevels > maxMipLevels) {
Dave Houlton413a6782018-05-22 13:01:54 -06001043 skip |=
1044 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1045 "VUID-VkImageCreateInfo-mipLevels-00958",
1046 "vkCreateImage(): pCreateInfo->mipLevels must be less than or equal to "
1047 "floor(log2(max(pCreateInfo->extent.width, pCreateInfo->extent.height, pCreateInfo->extent.depth)))+1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001048 }
1049
Mark Lobodzinski69259c52018-09-18 15:14:58 -06001050 if ((pCreateInfo->flags & VK_IMAGE_CREATE_2D_ARRAY_COMPATIBLE_BIT) && (pCreateInfo->imageType != VK_IMAGE_TYPE_3D)) {
1051 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, VK_NULL_HANDLE,
1052 "VUID-VkImageCreateInfo-flags-00950",
1053 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_2D_ARRAY_COMPATIBLE_BIT but "
1054 "pCreateInfo->imageType is not VK_IMAGE_TYPE_3D.");
1055 }
1056
Petr Krausb6f97802018-03-13 12:31:39 +01001057 if ((pCreateInfo->flags & VK_IMAGE_CREATE_SPARSE_BINDING_BIT) && (!device_data->physical_device_features.sparseBinding)) {
1058 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, VK_NULL_HANDLE,
Dave Houlton413a6782018-05-22 13:01:54 -06001059 "VUID-VkImageCreateInfo-flags-00969",
Petr Krausb6f97802018-03-13 12:31:39 +01001060 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_SPARSE_BINDING_BIT, but the "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001061 "VkPhysicalDeviceFeatures::sparseBinding feature is disabled.");
Petr Krausb6f97802018-03-13 12:31:39 +01001062 }
1063
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001064 // If flags contains VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT or VK_IMAGE_CREATE_SPARSE_ALIASED_BIT, it must also contain
1065 // VK_IMAGE_CREATE_SPARSE_BINDING_BIT
1066 if (((pCreateInfo->flags & (VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT | VK_IMAGE_CREATE_SPARSE_ALIASED_BIT)) != 0) &&
1067 ((pCreateInfo->flags & VK_IMAGE_CREATE_SPARSE_BINDING_BIT) != VK_IMAGE_CREATE_SPARSE_BINDING_BIT)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001068 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001069 "VUID-VkImageCreateInfo-flags-00987",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001070 "vkCreateImage: if pCreateInfo->flags contains VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT or "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001071 "VK_IMAGE_CREATE_SPARSE_ALIASED_BIT, it must also contain VK_IMAGE_CREATE_SPARSE_BINDING_BIT.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001072 }
1073
1074 // Check for combinations of attributes that are incompatible with having VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT set
1075 if ((pCreateInfo->flags & VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT) != 0) {
1076 // Linear tiling is unsupported
1077 if (VK_IMAGE_TILING_LINEAR == pCreateInfo->tiling) {
Dave Houlton413a6782018-05-22 13:01:54 -06001078 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1079 kVUID_PVError_InvalidUsage,
1080 "vkCreateImage: if pCreateInfo->flags contains VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT then image "
1081 "tiling of VK_IMAGE_TILING_LINEAR is not supported");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001082 }
1083
1084 // Sparse 1D image isn't valid
1085 if (VK_IMAGE_TYPE_1D == pCreateInfo->imageType) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001086 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001087 "VUID-VkImageCreateInfo-imageType-00970",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001088 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 1D image.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001089 }
1090
1091 // Sparse 2D image when device doesn't support it
1092 if ((VK_FALSE == device_data->physical_device_features.sparseResidencyImage2D) &&
1093 (VK_IMAGE_TYPE_2D == pCreateInfo->imageType)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001094 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001095 "VUID-VkImageCreateInfo-imageType-00971",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001096 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 2D image if corresponding "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001097 "feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001098 }
1099
1100 // Sparse 3D image when device doesn't support it
1101 if ((VK_FALSE == device_data->physical_device_features.sparseResidencyImage3D) &&
1102 (VK_IMAGE_TYPE_3D == pCreateInfo->imageType)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001103 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001104 "VUID-VkImageCreateInfo-imageType-00972",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001105 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 3D image if corresponding "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001106 "feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001107 }
1108
1109 // Multi-sample 2D image when device doesn't support it
1110 if (VK_IMAGE_TYPE_2D == pCreateInfo->imageType) {
1111 if ((VK_FALSE == device_data->physical_device_features.sparseResidency2Samples) &&
1112 (VK_SAMPLE_COUNT_2_BIT == pCreateInfo->samples)) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07001113 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001114 "VUID-VkImageCreateInfo-imageType-00973",
Dave Houltona9df0ce2018-02-07 10:51:23 -07001115 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 2-sample image if "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001116 "corresponding feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001117 } else if ((VK_FALSE == device_data->physical_device_features.sparseResidency4Samples) &&
1118 (VK_SAMPLE_COUNT_4_BIT == pCreateInfo->samples)) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07001119 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001120 "VUID-VkImageCreateInfo-imageType-00974",
Dave Houltona9df0ce2018-02-07 10:51:23 -07001121 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 4-sample image if "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001122 "corresponding feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001123 } else if ((VK_FALSE == device_data->physical_device_features.sparseResidency8Samples) &&
1124 (VK_SAMPLE_COUNT_8_BIT == pCreateInfo->samples)) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07001125 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001126 "VUID-VkImageCreateInfo-imageType-00975",
Dave Houltona9df0ce2018-02-07 10:51:23 -07001127 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 8-sample image if "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001128 "corresponding feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001129 } else if ((VK_FALSE == device_data->physical_device_features.sparseResidency16Samples) &&
1130 (VK_SAMPLE_COUNT_16_BIT == pCreateInfo->samples)) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07001131 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001132 "VUID-VkImageCreateInfo-imageType-00976",
Dave Houltona9df0ce2018-02-07 10:51:23 -07001133 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 16-sample image if "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001134 "corresponding feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001135 }
1136 }
1137 }
Jeff Bolzef40fec2018-09-01 22:04:34 -05001138
Jeff Bolz9af91c52018-09-01 21:53:57 -05001139 if (pCreateInfo->usage & VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV) {
1140 if (pCreateInfo->imageType != VK_IMAGE_TYPE_2D) {
1141 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1142 "VUID-VkImageCreateInfo-imageType-02082",
1143 "vkCreateImage: if usage includes VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV, "
1144 "imageType must be VK_IMAGE_TYPE_2D.");
1145 }
1146 if (pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT) {
1147 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1148 "VUID-VkImageCreateInfo-samples-02083",
1149 "vkCreateImage: if usage includes VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV, "
1150 "samples must be VK_SAMPLE_COUNT_1_BIT.");
1151 }
1152 if (pCreateInfo->tiling != VK_IMAGE_TILING_OPTIMAL) {
1153 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1154 "VUID-VkImageCreateInfo-tiling-02084",
1155 "vkCreateImage: if usage includes VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV, "
1156 "tiling must be VK_IMAGE_TILING_OPTIMAL.");
1157 }
1158 }
Jeff Bolzef40fec2018-09-01 22:04:34 -05001159
1160 if (pCreateInfo->flags & VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV) {
1161 if (pCreateInfo->imageType != VK_IMAGE_TYPE_2D &&
1162 pCreateInfo->imageType != VK_IMAGE_TYPE_3D) {
1163 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1164 "VUID-VkImageCreateInfo-flags-02050",
1165 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV, "
1166 "imageType must be VK_IMAGE_TYPE_2D or VK_IMAGE_TYPE_3D.");
1167 }
1168
1169 if ((pCreateInfo->flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) ||
1170 FormatIsDepthOrStencil(pCreateInfo->format)) {
1171 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1172 "VUID-VkImageCreateInfo-flags-02051",
1173 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV, "
1174 "it must not also contain VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT and format must "
1175 "not be a depth/stencil format.");
1176 }
1177
1178 if (pCreateInfo->imageType == VK_IMAGE_TYPE_2D &&
1179 (pCreateInfo->extent.width == 1 || pCreateInfo->extent.height == 1)) {
1180 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1181 "VUID-VkImageCreateInfo-flags-02052",
1182 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV and "
1183 "imageType is VK_IMAGE_TYPE_2D, extent.width and extent.height must be "
1184 "greater than 1.");
Jeff Bolzb8a8dd02018-09-18 02:39:24 -05001185 } else if (pCreateInfo->imageType == VK_IMAGE_TYPE_3D &&
Jeff Bolzef40fec2018-09-01 22:04:34 -05001186 (pCreateInfo->extent.width == 1 || pCreateInfo->extent.height == 1 || pCreateInfo->extent.depth == 1)) {
1187 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1188 "VUID-VkImageCreateInfo-flags-02053",
1189 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV and "
1190 "imageType is VK_IMAGE_TYPE_3D, extent.width, extent.height, and extent.depth "
1191 "must be greater than 1.");
1192
1193 }
1194 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001195 }
Jeff Bolzef40fec2018-09-01 22:04:34 -05001196
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001197 return skip;
1198}
1199
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001200bool pv_vkCreateImageView(VkDevice device, const VkImageViewCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
1201 VkImageView *pView) {
1202 bool skip = false;
1203 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
1204 debug_report_data *report_data = device_data->report_data;
1205
1206 if (pCreateInfo != nullptr) {
Dave Houltonbd2e2622018-04-10 16:41:14 -06001207 // Validate chained VkImageViewUsageCreateInfo struct, if present
1208 if (nullptr != pCreateInfo->pNext) {
1209 auto chained_ivuci_struct = lvl_find_in_chain<VkImageViewUsageCreateInfoKHR>(pCreateInfo->pNext);
1210 if (chained_ivuci_struct) {
1211 if (0 == chained_ivuci_struct->usage) {
1212 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001213 "VUID-VkImageViewUsageCreateInfo-usage-requiredbitmask",
Dave Houlton0f3795b2018-04-13 15:04:35 -06001214 "vkCreateImageView: Chained VkImageViewUsageCreateInfo usage field must not be 0.");
Dave Houltonbd2e2622018-04-10 16:41:14 -06001215 } else if (chained_ivuci_struct->usage & ~AllVkImageUsageFlagBits) {
1216 std::stringstream ss;
1217 ss << "vkCreateImageView: Chained VkImageViewUsageCreateInfo usage field (0x" << std::hex
1218 << chained_ivuci_struct->usage << ") contains invalid flag bits.";
1219 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001220 "VUID-VkImageViewUsageCreateInfo-usage-parameter", "%s", ss.str().c_str());
Dave Houltonbd2e2622018-04-10 16:41:14 -06001221 }
1222 }
1223 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001224 }
1225 return skip;
1226}
1227
Petr Krausb3fcdb42018-01-09 22:09:09 +01001228bool pv_VkViewport(const layer_data *device_data, const VkViewport &viewport, const char *fn_name, const char *param_name,
1229 VkDebugReportObjectTypeEXT object_type, uint64_t object = 0) {
1230 bool skip = false;
1231 debug_report_data *report_data = device_data->report_data;
1232
1233 // Note: for numerical correctness
1234 // - float comparisons should expect NaN (comparison always false).
1235 // - VkPhysicalDeviceLimits::maxViewportDimensions is uint32_t, not float -> careful.
1236
1237 const auto f_lte_u32_exact = [](const float v1_f, const uint32_t v2_u32) {
John Zulaufac0876c2018-02-19 10:09:35 -07001238 if (std::isnan(v1_f)) return false;
Petr Krausb3fcdb42018-01-09 22:09:09 +01001239 if (v1_f <= 0.0f) return true;
1240
1241 float intpart;
1242 const float fract = modff(v1_f, &intpart);
1243
1244 assert(std::numeric_limits<float>::radix == 2);
1245 const float u32_max_plus1 = ldexpf(1.0f, 32); // hopefully exact
1246 if (intpart >= u32_max_plus1) return false;
1247
1248 uint32_t v1_u32 = static_cast<uint32_t>(intpart);
1249 if (v1_u32 < v2_u32)
1250 return true;
1251 else if (v1_u32 == v2_u32 && fract == 0.0f)
1252 return true;
1253 else
1254 return false;
1255 };
1256
1257 const auto f_lte_u32_direct = [](const float v1_f, const uint32_t v2_u32) {
1258 const float v2_f = static_cast<float>(v2_u32); // not accurate for > radix^digits; and undefined rounding mode
1259 return (v1_f <= v2_f);
1260 };
1261
1262 // width
1263 bool width_healthy = true;
1264 const auto max_w = device_data->device_limits.maxViewportDimensions[0];
1265
1266 if (!(viewport.width > 0.0f)) {
1267 width_healthy = false;
Dave Houlton413a6782018-05-22 13:01:54 -06001268 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-width-01770",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001269 "%s: %s.width (=%f) is not greater than 0.0.", fn_name, param_name, viewport.width);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001270 } else if (!(f_lte_u32_exact(viewport.width, max_w) || f_lte_u32_direct(viewport.width, max_w))) {
1271 width_healthy = false;
Dave Houlton413a6782018-05-22 13:01:54 -06001272 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-width-01771",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001273 "%s: %s.width (=%f) exceeds VkPhysicalDeviceLimits::maxViewportDimensions[0] (=%" PRIu32 ").", fn_name,
1274 param_name, viewport.width, max_w);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001275 } else if (!f_lte_u32_exact(viewport.width, max_w) && f_lte_u32_direct(viewport.width, max_w)) {
Dave Houlton413a6782018-05-22 13:01:54 -06001276 skip |= log_msg(report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, object_type, object, kVUID_PVError_NONE,
Petr Krausb3fcdb42018-01-09 22:09:09 +01001277 "%s: %s.width (=%f) technically exceeds VkPhysicalDeviceLimits::maxViewportDimensions[0] (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001278 "), but it is within the static_cast<float>(maxViewportDimensions[0]) limit.",
1279 fn_name, param_name, viewport.width, max_w);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001280 }
1281
1282 // height
1283 bool height_healthy = true;
Petr Krausaf9c1222018-03-10 02:39:47 +01001284 const bool negative_height_enabled = device_data->api_version >= VK_API_VERSION_1_1 ||
1285 device_data->extensions.vk_khr_maintenance1 ||
1286 device_data->extensions.vk_amd_negative_viewport_height;
Petr Krausb3fcdb42018-01-09 22:09:09 +01001287 const auto max_h = device_data->device_limits.maxViewportDimensions[1];
1288
1289 if (!negative_height_enabled && !(viewport.height > 0.0f)) {
1290 height_healthy = false;
Dave Houlton413a6782018-05-22 13:01:54 -06001291 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-height-01772",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001292 "%s: %s.height (=%f) is not greater 0.0.", fn_name, param_name, viewport.height);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001293 } else if (!(f_lte_u32_exact(fabsf(viewport.height), max_h) || f_lte_u32_direct(fabsf(viewport.height), max_h))) {
1294 height_healthy = false;
1295
Dave Houlton413a6782018-05-22 13:01:54 -06001296 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-height-01773",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001297 "%s: Absolute value of %s.height (=%f) exceeds VkPhysicalDeviceLimits::maxViewportDimensions[1] (=%" PRIu32
1298 ").",
1299 fn_name, param_name, viewport.height, max_h);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001300 } else if (!f_lte_u32_exact(fabsf(viewport.height), max_h) && f_lte_u32_direct(fabsf(viewport.height), max_h)) {
1301 height_healthy = false;
1302
1303 skip |= log_msg(
Dave Houlton413a6782018-05-22 13:01:54 -06001304 report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, object_type, object, kVUID_PVError_NONE,
Petr Krausb3fcdb42018-01-09 22:09:09 +01001305 "%s: Absolute value of %s.height (=%f) technically exceeds VkPhysicalDeviceLimits::maxViewportDimensions[1] (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001306 "), but it is within the static_cast<float>(maxViewportDimensions[1]) limit.",
1307 fn_name, param_name, viewport.height, max_h);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001308 }
1309
1310 // x
1311 bool x_healthy = true;
1312 if (!(viewport.x >= device_data->device_limits.viewportBoundsRange[0])) {
1313 x_healthy = false;
Dave Houlton413a6782018-05-22 13:01:54 -06001314 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-x-01774",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001315 "%s: %s.x (=%f) is less than VkPhysicalDeviceLimits::viewportBoundsRange[0] (=%f).", fn_name, param_name,
1316 viewport.x, device_data->device_limits.viewportBoundsRange[0]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001317 }
1318
1319 // x + width
1320 if (x_healthy && width_healthy) {
1321 const float right_bound = viewport.x + viewport.width;
1322 if (!(right_bound <= device_data->device_limits.viewportBoundsRange[1])) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06001323 skip |=
Dave Houlton413a6782018-05-22 13:01:54 -06001324 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-x-01232",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001325 "%s: %s.x + %s.width (=%f + %f = %f) is greater than VkPhysicalDeviceLimits::viewportBoundsRange[1] (=%f).",
1326 fn_name, param_name, param_name, viewport.x, viewport.width, right_bound,
1327 device_data->device_limits.viewportBoundsRange[1]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001328 }
1329 }
1330
1331 // y
1332 bool y_healthy = true;
1333 if (!(viewport.y >= device_data->device_limits.viewportBoundsRange[0])) {
1334 y_healthy = false;
Dave Houlton413a6782018-05-22 13:01:54 -06001335 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-y-01775",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001336 "%s: %s.y (=%f) is less than VkPhysicalDeviceLimits::viewportBoundsRange[0] (=%f).", fn_name, param_name,
1337 viewport.y, device_data->device_limits.viewportBoundsRange[0]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001338 } else if (negative_height_enabled && !(viewport.y <= device_data->device_limits.viewportBoundsRange[1])) {
1339 y_healthy = false;
Dave Houlton413a6782018-05-22 13:01:54 -06001340 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-y-01776",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001341 "%s: %s.y (=%f) exceeds VkPhysicalDeviceLimits::viewportBoundsRange[1] (=%f).", fn_name, param_name,
1342 viewport.y, device_data->device_limits.viewportBoundsRange[1]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001343 }
1344
1345 // y + height
1346 if (y_healthy && height_healthy) {
1347 const float boundary = viewport.y + viewport.height;
1348
1349 if (!(boundary <= device_data->device_limits.viewportBoundsRange[1])) {
Dave Houlton413a6782018-05-22 13:01:54 -06001350 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-y-01233",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001351 "%s: %s.y + %s.height (=%f + %f = %f) exceeds VkPhysicalDeviceLimits::viewportBoundsRange[1] (=%f).",
1352 fn_name, param_name, param_name, viewport.y, viewport.height, boundary,
1353 device_data->device_limits.viewportBoundsRange[1]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001354 } else if (negative_height_enabled && !(boundary >= device_data->device_limits.viewportBoundsRange[0])) {
1355 skip |= log_msg(
Dave Houlton413a6782018-05-22 13:01:54 -06001356 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-y-01777",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001357 "%s: %s.y + %s.height (=%f + %f = %f) is less than VkPhysicalDeviceLimits::viewportBoundsRange[0] (=%f).", fn_name,
1358 param_name, param_name, viewport.y, viewport.height, boundary, device_data->device_limits.viewportBoundsRange[0]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001359 }
1360 }
1361
1362 if (!device_data->extensions.vk_ext_depth_range_unrestricted) {
1363 // minDepth
1364 if (!(viewport.minDepth >= 0.0) || !(viewport.minDepth <= 1.0)) {
Dave Houlton413a6782018-05-22 13:01:54 -06001365 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-minDepth-01234",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001366
Petr Krausb3fcdb42018-01-09 22:09:09 +01001367 "%s: VK_EXT_depth_range_unrestricted extension is not enabled and %s.minDepth (=%f) is not within the "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001368 "[0.0, 1.0] range.",
1369 fn_name, param_name, viewport.minDepth);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001370 }
1371
1372 // maxDepth
1373 if (!(viewport.maxDepth >= 0.0) || !(viewport.maxDepth <= 1.0)) {
Dave Houlton413a6782018-05-22 13:01:54 -06001374 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-maxDepth-01235",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001375
Petr Krausb3fcdb42018-01-09 22:09:09 +01001376 "%s: VK_EXT_depth_range_unrestricted extension is not enabled and %s.maxDepth (=%f) is not within the "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001377 "[0.0, 1.0] range.",
1378 fn_name, param_name, viewport.maxDepth);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001379 }
1380 }
1381
1382 return skip;
1383}
1384
Jeff Bolz9af91c52018-09-01 21:53:57 -05001385struct SampleOrderInfo
1386{
1387 VkShadingRatePaletteEntryNV shadingRate;
1388 uint32_t width;
1389 uint32_t height;
1390};
1391
1392// All palette entries with more than one pixel per fragment
1393static SampleOrderInfo sampleOrderInfos[] =
1394{
1395 { VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_1X2_PIXELS_NV, 1, 2},
1396 { VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_2X1_PIXELS_NV, 2, 1},
1397 { VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_2X2_PIXELS_NV, 2, 2},
1398 { VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_4X2_PIXELS_NV, 4, 2},
1399 { VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_2X4_PIXELS_NV, 2, 4},
1400 { VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_4X4_PIXELS_NV, 4, 4},
1401};
1402
1403bool ValidateCoarseSampleOrderCustomNV(layer_data *device_data, const VkCoarseSampleOrderCustomNV *order)
1404{
1405 bool skip = false;
1406 debug_report_data *report_data = device_data->report_data;
1407
Jeff Bolz45bf7d62018-09-18 15:39:58 -05001408 SampleOrderInfo *sampleOrderInfo;
Jeff Bolz9af91c52018-09-01 21:53:57 -05001409 uint32_t infoIdx = 0;
Jeff Bolz45bf7d62018-09-18 15:39:58 -05001410 for (sampleOrderInfo = nullptr; infoIdx < ARRAY_SIZE(sampleOrderInfos); ++infoIdx) {
Jeff Bolz9af91c52018-09-01 21:53:57 -05001411 if (sampleOrderInfos[infoIdx].shadingRate == order->shadingRate) {
Jeff Bolzb8a8dd02018-09-18 02:39:24 -05001412 sampleOrderInfo = &sampleOrderInfos[infoIdx];
Jeff Bolz9af91c52018-09-01 21:53:57 -05001413 break;
1414 }
1415 }
1416
Jeff Bolzb8a8dd02018-09-18 02:39:24 -05001417 if (sampleOrderInfo == nullptr) {
Jeff Bolz9af91c52018-09-01 21:53:57 -05001418 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1419 "VUID-VkCoarseSampleOrderCustomNV-shadingRate-02073",
1420 "VkCoarseSampleOrderCustomNV shadingRate must be a shading rate "
1421 "that generates fragments with more than one pixel.");
1422 return skip;
1423 }
1424
1425 if (order->sampleCount == 0 ||
1426 (order->sampleCount & (order->sampleCount - 1)) ||
1427 !(order->sampleCount & device_data->device_limits.framebufferNoAttachmentsSampleCounts)) {
1428 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1429 "VUID-VkCoarseSampleOrderCustomNV-sampleCount-02074",
1430 "VkCoarseSampleOrderCustomNV sampleCount (=%" PRIu32 ") must "
1431 "correspond to a sample count enumerated in VkSampleCountFlags whose corresponding bit "
1432 "is set in framebufferNoAttachmentsSampleCounts.",
1433 order->sampleCount);
1434 }
1435
Jeff Bolz9af91c52018-09-01 21:53:57 -05001436 if (order->sampleLocationCount != order->sampleCount * sampleOrderInfo->width * sampleOrderInfo->height) {
1437 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1438 "VUID-VkCoarseSampleOrderCustomNV-sampleLocationCount-02075",
1439 "VkCoarseSampleOrderCustomNV sampleLocationCount (=%" PRIu32 ") must "
1440 "be equal to the product of sampleCount (=%" PRIu32 "), the fragment width for shadingRate "
1441 "(=%" PRIu32 "), and the fragment height for shadingRate (=%" PRIu32 ").",
1442 order->sampleLocationCount, order->sampleCount, sampleOrderInfo->width, sampleOrderInfo->height);
1443 }
1444
Jeff Bolz5d2b7432018-09-06 10:32:36 -05001445 if (order->sampleLocationCount > device_data->phys_dev_ext_props.shading_rate_image_props.shadingRateMaxCoarseSamples) {
1446 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1447 "VUID-VkCoarseSampleOrderCustomNV-sampleLocationCount-02076",
1448 "VkCoarseSampleOrderCustomNV sampleLocationCount (=%" PRIu32 ") must "
1449 "be less than or equal to VkPhysicalDeviceShadingRateImagePropertiesNV shadingRateMaxCoarseSamples (=%" PRIu32 ").",
1450 order->sampleLocationCount, device_data->phys_dev_ext_props.shading_rate_image_props.shadingRateMaxCoarseSamples);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001451 }
Jeff Bolz9af91c52018-09-01 21:53:57 -05001452
1453 // Accumulate a bitmask tracking which (x,y,sample) tuples are seen. Expect
Jeff Bolzb8a8dd02018-09-18 02:39:24 -05001454 // the first width*height*sampleCount bits to all be set. Note: There is no
1455 // guarantee that 64 bits is enough, but practically it's unlikely for an
1456 // implementation to support more than 32 bits for samplemask.
Jeff Bolz45bf7d62018-09-18 15:39:58 -05001457 assert(device_data->phys_dev_ext_props.shading_rate_image_props.shadingRateMaxCoarseSamples <= 64);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001458 uint64_t sampleLocationsMask = 0;
1459 for (uint32_t i = 0; i < order->sampleLocationCount; ++i) {
1460 const VkCoarseSampleLocationNV *sampleLoc = &order->pSampleLocations[i];
1461 if (sampleLoc->pixelX >= sampleOrderInfo->width) {
1462 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1463 "VUID-VkCoarseSampleLocationNV-pixelX-02078",
1464 "pixelX must be less than the width (in pixels) of the fragment.");
1465 }
1466 if (sampleLoc->pixelY >= sampleOrderInfo->height) {
1467 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1468 "VUID-VkCoarseSampleLocationNV-pixelY-02079",
1469 "pixelY must be less than the height (in pixels) of the fragment.");
1470 }
1471 if (sampleLoc->sample >= order->sampleCount) {
1472 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1473 "VUID-VkCoarseSampleLocationNV-sample-02080",
1474 "sample must be less than the number of coverage samples in each pixel belonging to the fragment.");
1475 }
1476 uint32_t idx = sampleLoc->sample + order->sampleCount * (sampleLoc->pixelX + sampleOrderInfo->width * sampleLoc->pixelY);
1477 sampleLocationsMask |= 1ULL << idx;
1478 }
1479
1480 uint64_t expectedMask = (order->sampleLocationCount == 64) ? ~0ULL : ((1ULL << order->sampleLocationCount) - 1);
1481 if (sampleLocationsMask != expectedMask) {
1482 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1483 "VUID-VkCoarseSampleOrderCustomNV-pSampleLocations-02077",
1484 "The array pSampleLocations must contain exactly one entry for "
1485 "every combination of valid values for pixelX, pixelY, and sample in the structure VkCoarseSampleOrderCustomNV.");
1486 }
1487
1488 return skip;
1489}
1490
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001491bool pv_vkCreateGraphicsPipelines(VkDevice device, VkPipelineCache pipelineCache, uint32_t createInfoCount,
1492 const VkGraphicsPipelineCreateInfo *pCreateInfos, const VkAllocationCallbacks *pAllocator,
1493 VkPipeline *pPipelines) {
1494 bool skip = false;
1495 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
1496 debug_report_data *report_data = device_data->report_data;
1497
1498 if (pCreateInfos != nullptr) {
1499 for (uint32_t i = 0; i < createInfoCount; ++i) {
Petr Kraus299ba622017-11-24 03:09:03 +01001500 bool has_dynamic_viewport = false;
1501 bool has_dynamic_scissor = false;
1502 bool has_dynamic_line_width = false;
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001503 bool has_dynamic_viewport_w_scaling_nv = false;
1504 bool has_dynamic_discard_rectangle_ext = false;
1505 bool has_dynamic_sample_locations_ext = false;
Jeff Bolz3e71f782018-08-29 23:15:45 -05001506 bool has_dynamic_exclusive_scissor_nv = false;
Jeff Bolz9af91c52018-09-01 21:53:57 -05001507 bool has_dynamic_shading_rate_palette_nv = false;
Petr Kraus299ba622017-11-24 03:09:03 +01001508 if (pCreateInfos[i].pDynamicState != nullptr) {
1509 const auto &dynamic_state_info = *pCreateInfos[i].pDynamicState;
1510 for (uint32_t state_index = 0; state_index < dynamic_state_info.dynamicStateCount; ++state_index) {
1511 const auto &dynamic_state = dynamic_state_info.pDynamicStates[state_index];
1512 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT) has_dynamic_viewport = true;
1513 if (dynamic_state == VK_DYNAMIC_STATE_SCISSOR) has_dynamic_scissor = true;
1514 if (dynamic_state == VK_DYNAMIC_STATE_LINE_WIDTH) has_dynamic_line_width = true;
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001515 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT_W_SCALING_NV) has_dynamic_viewport_w_scaling_nv = true;
1516 if (dynamic_state == VK_DYNAMIC_STATE_DISCARD_RECTANGLE_EXT) has_dynamic_discard_rectangle_ext = true;
1517 if (dynamic_state == VK_DYNAMIC_STATE_SAMPLE_LOCATIONS_EXT) has_dynamic_sample_locations_ext = true;
Jeff Bolz3e71f782018-08-29 23:15:45 -05001518 if (dynamic_state == VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV) has_dynamic_exclusive_scissor_nv = true;
Jeff Bolz9af91c52018-09-01 21:53:57 -05001519 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT_SHADING_RATE_PALETTE_NV) has_dynamic_shading_rate_palette_nv = true;
Petr Kraus299ba622017-11-24 03:09:03 +01001520 }
1521 }
1522
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001523 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
1524 if (pCreateInfos[i].pVertexInputState != nullptr) {
1525 auto const &vertex_input_state = pCreateInfos[i].pVertexInputState;
Peter Kohautc7d9d392018-07-15 00:34:07 +02001526
1527 if (vertex_input_state->vertexBindingDescriptionCount > device_data->device_limits.maxVertexInputBindings) {
1528 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1529 "VUID-VkPipelineVertexInputStateCreateInfo-vertexBindingDescriptionCount-00613",
1530 "vkCreateGraphicsPipelines: pararameter "
1531 "pCreateInfo[%d].pVertexInputState->vertexBindingDescriptionCount (%u) is "
1532 "greater than VkPhysicalDeviceLimits::maxVertexInputBindings (%u).",
1533 i, vertex_input_state->vertexBindingDescriptionCount,
1534 device_data->device_limits.maxVertexInputBindings);
1535 }
1536
1537 if (vertex_input_state->vertexAttributeDescriptionCount > device_data->device_limits.maxVertexInputAttributes) {
1538 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1539 "VUID-VkPipelineVertexInputStateCreateInfo-vertexAttributeDescriptionCount-00614",
1540 "vkCreateGraphicsPipelines: pararameter "
Peter Kohaut9e92c5c2018-07-17 10:32:17 +02001541 "pCreateInfo[%d].pVertexInputState->vertexAttributeDescriptionCount (%u) is "
Peter Kohautc7d9d392018-07-15 00:34:07 +02001542 "greater than VkPhysicalDeviceLimits::maxVertexInputAttributes (%u).",
1543 i, vertex_input_state->vertexBindingDescriptionCount,
1544 device_data->device_limits.maxVertexInputAttributes);
1545 }
1546
1547 std::unordered_set<uint32_t> vertex_bindings(vertex_input_state->vertexBindingDescriptionCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001548 for (uint32_t d = 0; d < vertex_input_state->vertexBindingDescriptionCount; ++d) {
1549 auto const &vertex_bind_desc = vertex_input_state->pVertexBindingDescriptions[d];
Peter Kohautc7d9d392018-07-15 00:34:07 +02001550 auto const &binding_it = vertex_bindings.find(vertex_bind_desc.binding);
1551 if (binding_it != vertex_bindings.cend()) {
1552 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1553 "VUID-VkPipelineVertexInputStateCreateInfo-pVertexBindingDescriptions-00616",
1554 "vkCreateGraphicsPipelines: parameter "
1555 "pCreateInfo[%d].pVertexInputState->pVertexBindingDescription[%d].binding "
1556 "(%" PRIu32 ") is not distinct.",
1557 i, d, vertex_bind_desc.binding);
1558 }
1559 vertex_bindings.insert(vertex_bind_desc.binding);
1560
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001561 if (vertex_bind_desc.binding >= device_data->device_limits.maxVertexInputBindings) {
1562 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001563 "VUID-VkVertexInputBindingDescription-binding-00618",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001564 "vkCreateGraphicsPipelines: parameter "
1565 "pCreateInfos[%u].pVertexInputState->pVertexBindingDescriptions[%u].binding (%u) is "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001566 "greater than or equal to VkPhysicalDeviceLimits::maxVertexInputBindings (%u).",
1567 i, d, vertex_bind_desc.binding, device_data->device_limits.maxVertexInputBindings);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001568 }
1569
1570 if (vertex_bind_desc.stride > device_data->device_limits.maxVertexInputBindingStride) {
1571 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001572 "VUID-VkVertexInputBindingDescription-stride-00619",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001573 "vkCreateGraphicsPipelines: parameter "
1574 "pCreateInfos[%u].pVertexInputState->pVertexBindingDescriptions[%u].stride (%u) is greater "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001575 "than VkPhysicalDeviceLimits::maxVertexInputBindingStride (%u).",
1576 i, d, vertex_bind_desc.stride, device_data->device_limits.maxVertexInputBindingStride);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001577 }
1578 }
1579
Peter Kohautc7d9d392018-07-15 00:34:07 +02001580 std::unordered_set<uint32_t> attribute_locations(vertex_input_state->vertexAttributeDescriptionCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001581 for (uint32_t d = 0; d < vertex_input_state->vertexAttributeDescriptionCount; ++d) {
1582 auto const &vertex_attrib_desc = vertex_input_state->pVertexAttributeDescriptions[d];
Peter Kohautc7d9d392018-07-15 00:34:07 +02001583 auto const &location_it = attribute_locations.find(vertex_attrib_desc.location);
1584 if (location_it != attribute_locations.cend()) {
1585 skip |= log_msg(
1586 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1587 "VUID-VkPipelineVertexInputStateCreateInfo-pVertexAttributeDescriptions-00617",
1588 "vkCreateGraphicsPipelines: parameter "
1589 "pCreateInfo[%d].pVertexInputState->vertexAttributeDescriptions[%d].location (%u) is not distinct.",
1590 i, d, vertex_attrib_desc.location);
1591 }
1592 attribute_locations.insert(vertex_attrib_desc.location);
1593
1594 auto const &binding_it = vertex_bindings.find(vertex_attrib_desc.binding);
1595 if (binding_it == vertex_bindings.cend()) {
1596 skip |= log_msg(
1597 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1598 "VUID-VkPipelineVertexInputStateCreateInfo-binding-00615",
1599 "vkCreateGraphicsPipelines: parameter "
1600 " pCreateInfo[%d].pVertexInputState->vertexAttributeDescriptions[%d].binding (%u) does not exist "
1601 "in any pCreateInfo[%d].pVertexInputState->pVertexBindingDescription.",
1602 i, d, vertex_attrib_desc.binding, i);
1603 }
1604
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001605 if (vertex_attrib_desc.location >= device_data->device_limits.maxVertexInputAttributes) {
1606 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001607 "VUID-VkVertexInputAttributeDescription-location-00620",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001608 "vkCreateGraphicsPipelines: parameter "
1609 "pCreateInfos[%u].pVertexInputState->pVertexAttributeDescriptions[%u].location (%u) is "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001610 "greater than or equal to VkPhysicalDeviceLimits::maxVertexInputAttributes (%u).",
1611 i, d, vertex_attrib_desc.location, device_data->device_limits.maxVertexInputAttributes);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001612 }
1613
1614 if (vertex_attrib_desc.binding >= device_data->device_limits.maxVertexInputBindings) {
1615 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001616 "VUID-VkVertexInputAttributeDescription-binding-00621",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001617 "vkCreateGraphicsPipelines: parameter "
1618 "pCreateInfos[%u].pVertexInputState->pVertexAttributeDescriptions[%u].binding (%u) is "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001619 "greater than or equal to VkPhysicalDeviceLimits::maxVertexInputBindings (%u).",
1620 i, d, vertex_attrib_desc.binding, device_data->device_limits.maxVertexInputBindings);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001621 }
1622
1623 if (vertex_attrib_desc.offset > device_data->device_limits.maxVertexInputAttributeOffset) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06001624 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001625 "VUID-VkVertexInputAttributeDescription-offset-00622",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001626 "vkCreateGraphicsPipelines: parameter "
1627 "pCreateInfos[%u].pVertexInputState->pVertexAttributeDescriptions[%u].offset (%u) is "
1628 "greater than VkPhysicalDeviceLimits::maxVertexInputAttributeOffset (%u).",
1629 i, d, vertex_attrib_desc.offset, device_data->device_limits.maxVertexInputAttributeOffset);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001630 }
1631 }
1632 }
1633
1634 if (pCreateInfos[i].pStages != nullptr) {
1635 bool has_control = false;
1636 bool has_eval = false;
1637
1638 for (uint32_t stage_index = 0; stage_index < pCreateInfos[i].stageCount; ++stage_index) {
1639 if (pCreateInfos[i].pStages[stage_index].stage == VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) {
1640 has_control = true;
1641 } else if (pCreateInfos[i].pStages[stage_index].stage == VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT) {
1642 has_eval = true;
1643 }
1644 }
1645
1646 // pTessellationState is ignored without both tessellation control and tessellation evaluation shaders stages
1647 if (has_control && has_eval) {
1648 if (pCreateInfos[i].pTessellationState == nullptr) {
1649 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001650 "VUID-VkGraphicsPipelineCreateInfo-pStages-00731",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001651 "vkCreateGraphicsPipelines: if pCreateInfos[%d].pStages includes a tessellation control "
1652 "shader stage and a tessellation evaluation shader stage, "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001653 "pCreateInfos[%d].pTessellationState must not be NULL.",
1654 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001655 } else {
1656 skip |= validate_struct_pnext(
1657 report_data, "vkCreateGraphicsPipelines",
1658 ParameterName("pCreateInfos[%i].pTessellationState->pNext", ParameterName::IndexVector{i}), NULL,
Dave Houlton413a6782018-05-22 13:01:54 -06001659 pCreateInfos[i].pTessellationState->pNext, 0, NULL, GeneratedHeaderVersion,
1660 "VUID-VkGraphicsPipelineCreateInfo-pNext-pNext");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001661
1662 skip |= validate_reserved_flags(
1663 report_data, "vkCreateGraphicsPipelines",
1664 ParameterName("pCreateInfos[%i].pTessellationState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06001665 pCreateInfos[i].pTessellationState->flags,
1666 "VUID-VkPipelineTessellationStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001667
1668 if (pCreateInfos[i].pTessellationState->sType !=
1669 VK_STRUCTURE_TYPE_PIPELINE_TESSELLATION_STATE_CREATE_INFO) {
1670 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001671 "VUID-VkPipelineTessellationStateCreateInfo-sType-sType",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001672 "vkCreateGraphicsPipelines: parameter pCreateInfos[%d].pTessellationState->sType must "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001673 "be VK_STRUCTURE_TYPE_PIPELINE_TESSELLATION_STATE_CREATE_INFO.",
1674 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001675 }
1676
1677 if (pCreateInfos[i].pTessellationState->patchControlPoints == 0 ||
1678 pCreateInfos[i].pTessellationState->patchControlPoints >
1679 device_data->device_limits.maxTessellationPatchSize) {
1680 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001681 "VUID-VkPipelineTessellationStateCreateInfo-patchControlPoints-01214",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001682 "vkCreateGraphicsPipelines: invalid parameter "
1683 "pCreateInfos[%d].pTessellationState->patchControlPoints value %u. patchControlPoints "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001684 "should be >0 and <=%u.",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001685 i, pCreateInfos[i].pTessellationState->patchControlPoints,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001686 device_data->device_limits.maxTessellationPatchSize);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001687 }
1688 }
1689 }
1690 }
1691
1692 // pViewportState, pMultisampleState, pDepthStencilState, and pColorBlendState ignored when rasterization is disabled
1693 if ((pCreateInfos[i].pRasterizationState != nullptr) &&
1694 (pCreateInfos[i].pRasterizationState->rasterizerDiscardEnable == VK_FALSE)) {
1695 if (pCreateInfos[i].pViewportState == nullptr) {
Petr Krausa6103552017-11-16 21:21:58 +01001696 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001697 VK_NULL_HANDLE, "VUID-VkGraphicsPipelineCreateInfo-rasterizerDiscardEnable-00750",
Petr Krausa6103552017-11-16 21:21:58 +01001698 "vkCreateGraphicsPipelines: Rasterization is enabled (pCreateInfos[%" PRIu32
1699 "].pRasterizationState->rasterizerDiscardEnable is VK_FALSE), but pCreateInfos[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001700 "].pViewportState (=NULL) is not a valid pointer.",
1701 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001702 } else {
Petr Krausa6103552017-11-16 21:21:58 +01001703 const auto &viewport_state = *pCreateInfos[i].pViewportState;
1704
1705 if (viewport_state.sType != VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_STATE_CREATE_INFO) {
1706 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001707 VK_NULL_HANDLE, "VUID-VkPipelineViewportStateCreateInfo-sType-sType",
Petr Krausa6103552017-11-16 21:21:58 +01001708 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001709 "].pViewportState->sType is not VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_STATE_CREATE_INFO.",
1710 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001711 }
1712
Petr Krausa6103552017-11-16 21:21:58 +01001713 const VkStructureType allowed_structs_VkPipelineViewportStateCreateInfo[] = {
1714 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_SWIZZLE_STATE_CREATE_INFO_NV,
Jeff Bolz3e71f782018-08-29 23:15:45 -05001715 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_W_SCALING_STATE_CREATE_INFO_NV,
1716 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_EXCLUSIVE_SCISSOR_STATE_CREATE_INFO_NV,
Jeff Bolz9af91c52018-09-01 21:53:57 -05001717 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_SHADING_RATE_IMAGE_STATE_CREATE_INFO_NV,
1718 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_COARSE_SAMPLE_ORDER_STATE_CREATE_INFO_NV,
Jeff Bolz3e71f782018-08-29 23:15:45 -05001719 };
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001720 skip |= validate_struct_pnext(
1721 report_data, "vkCreateGraphicsPipelines",
Petr Krausa6103552017-11-16 21:21:58 +01001722 ParameterName("pCreateInfos[%i].pViewportState->pNext", ParameterName::IndexVector{i}),
Jeff Bolz9af91c52018-09-01 21:53:57 -05001723 "VkPipelineViewportSwizzleStateCreateInfoNV, VkPipelineViewportWScalingStateCreateInfoNV, "
Jeff Bolzb8a8dd02018-09-18 02:39:24 -05001724 "VkPipelineViewportExclusiveScissorStateCreateInfoNV, VkPipelineViewportShadingRateImageStateCreateInfoNV, "
1725 "VkPipelineViewportCoarseSampleOrderStateCreateInfoNV",
Petr Krausa6103552017-11-16 21:21:58 +01001726 viewport_state.pNext, ARRAY_SIZE(allowed_structs_VkPipelineViewportStateCreateInfo),
Dave Houlton413a6782018-05-22 13:01:54 -06001727 allowed_structs_VkPipelineViewportStateCreateInfo, 65,
1728 "VUID-VkPipelineViewportStateCreateInfo-pNext-pNext");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001729
1730 skip |= validate_reserved_flags(
1731 report_data, "vkCreateGraphicsPipelines",
1732 ParameterName("pCreateInfos[%i].pViewportState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06001733 viewport_state.flags, "VUID-VkPipelineViewportStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001734
Jeff Bolz3e71f782018-08-29 23:15:45 -05001735 auto exclusive_scissor_struct = lvl_find_in_chain<VkPipelineViewportExclusiveScissorStateCreateInfoNV>(pCreateInfos[i].pViewportState->pNext);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001736 auto shading_rate_image_struct = lvl_find_in_chain<VkPipelineViewportShadingRateImageStateCreateInfoNV>(pCreateInfos[i].pViewportState->pNext);
1737 auto coarse_sample_order_struct = lvl_find_in_chain<VkPipelineViewportCoarseSampleOrderStateCreateInfoNV>(pCreateInfos[i].pViewportState->pNext);
Jeff Bolz3e71f782018-08-29 23:15:45 -05001738
Petr Krausa6103552017-11-16 21:21:58 +01001739 if (!device_data->physical_device_features.multiViewport) {
1740 if (viewport_state.viewportCount != 1) {
1741 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001742 VK_NULL_HANDLE, "VUID-VkPipelineViewportStateCreateInfo-viewportCount-01216",
Petr Krausa6103552017-11-16 21:21:58 +01001743 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
1744 "disabled, but pCreateInfos[%" PRIu32 "].pViewportState->viewportCount (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001745 ") is not 1.",
1746 i, viewport_state.viewportCount);
Petr Krausa6103552017-11-16 21:21:58 +01001747 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001748
Petr Krausa6103552017-11-16 21:21:58 +01001749 if (viewport_state.scissorCount != 1) {
1750 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001751 VK_NULL_HANDLE, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-01217",
Petr Krausa6103552017-11-16 21:21:58 +01001752 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
1753 "disabled, but pCreateInfos[%" PRIu32 "].pViewportState->scissorCount (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001754 ") is not 1.",
1755 i, viewport_state.scissorCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001756 }
Jeff Bolz3e71f782018-08-29 23:15:45 -05001757
1758 if (exclusive_scissor_struct &&
1759 (exclusive_scissor_struct->exclusiveScissorCount != 0 && exclusive_scissor_struct->exclusiveScissorCount != 1)) {
1760 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
1761 VK_NULL_HANDLE, "VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-exclusiveScissorCount-02027",
1762 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
Jeff Bolz9af91c52018-09-01 21:53:57 -05001763 "disabled, but pCreateInfos[%" PRIu32 "] VkPipelineViewportExclusiveScissorStateCreateInfoNV::exclusiveScissorCount (=%" PRIu32
Jeff Bolz3e71f782018-08-29 23:15:45 -05001764 ") is not 1.",
1765 i, exclusive_scissor_struct->exclusiveScissorCount);
1766
1767 }
1768
Jeff Bolz9af91c52018-09-01 21:53:57 -05001769 if (shading_rate_image_struct &&
1770 (shading_rate_image_struct->viewportCount != 0 && shading_rate_image_struct->viewportCount != 1)) {
1771 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
1772 VK_NULL_HANDLE, "VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-viewportCount-02054",
1773 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
1774 "disabled, but pCreateInfos[%" PRIu32 "] VkPipelineViewportShadingRateImageStateCreateInfoNV::viewportCount (=%" PRIu32
Jeff Bolzb8a8dd02018-09-18 02:39:24 -05001775 ") is neither 0 nor 1.",
Jeff Bolz9af91c52018-09-01 21:53:57 -05001776 i, shading_rate_image_struct->viewportCount);
1777
1778 }
1779
Petr Krausa6103552017-11-16 21:21:58 +01001780 } else { // multiViewport enabled
1781 if (viewport_state.viewportCount == 0) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001782 skip |= log_msg(
1783 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001784 VK_NULL_HANDLE, "VUID-VkPipelineViewportStateCreateInfo-viewportCount-arraylength",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001785 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "].pViewportState->viewportCount is 0.", i);
Petr Krausa6103552017-11-16 21:21:58 +01001786 } else if (viewport_state.viewportCount > device_data->device_limits.maxViewports) {
1787 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001788 VK_NULL_HANDLE, "VUID-VkPipelineViewportStateCreateInfo-viewportCount-01218",
Petr Krausa6103552017-11-16 21:21:58 +01001789 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1790 "].pViewportState->viewportCount (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001791 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
1792 i, viewport_state.viewportCount, device_data->device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001793 }
Petr Krausa6103552017-11-16 21:21:58 +01001794
1795 if (viewport_state.scissorCount == 0) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001796 skip |= log_msg(
1797 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001798 VK_NULL_HANDLE, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-arraylength",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001799 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "].pViewportState->scissorCount is 0.", i);
Petr Krausa6103552017-11-16 21:21:58 +01001800 } else if (viewport_state.scissorCount > device_data->device_limits.maxViewports) {
1801 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001802 VK_NULL_HANDLE, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-01219",
Petr Krausa6103552017-11-16 21:21:58 +01001803 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1804 "].pViewportState->scissorCount (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001805 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
1806 i, viewport_state.scissorCount, device_data->device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001807 }
1808 }
1809
Jeff Bolz3e71f782018-08-29 23:15:45 -05001810 if (exclusive_scissor_struct &&
1811 exclusive_scissor_struct->exclusiveScissorCount > device_data->device_limits.maxViewports) {
1812 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
1813 VK_NULL_HANDLE, "VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-exclusiveScissorCount-02028",
1814 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1815 "] exclusiveScissorCount (=%" PRIu32
1816 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
1817 i, exclusive_scissor_struct->exclusiveScissorCount, device_data->device_limits.maxViewports);
1818 }
1819
Jeff Bolz9af91c52018-09-01 21:53:57 -05001820 if (shading_rate_image_struct &&
1821 shading_rate_image_struct->viewportCount > device_data->device_limits.maxViewports) {
1822 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
1823 VK_NULL_HANDLE, "VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-viewportCount-02055",
1824 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1825 "] VkPipelineViewportShadingRateImageStateCreateInfoNV viewportCount (=%" PRIu32
1826 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
1827 i, shading_rate_image_struct->viewportCount, device_data->device_limits.maxViewports);
1828 }
1829
Petr Krausa6103552017-11-16 21:21:58 +01001830 if (viewport_state.scissorCount != viewport_state.viewportCount) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001831 skip |=
1832 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001833 VK_NULL_HANDLE, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-01220",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001834 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "].pViewportState->scissorCount (=%" PRIu32
1835 ") is not identical to pCreateInfos[%" PRIu32 "].pViewportState->viewportCount (=%" PRIu32 ").",
1836 i, viewport_state.scissorCount, i, viewport_state.viewportCount);
Petr Krausa6103552017-11-16 21:21:58 +01001837 }
1838
Jeff Bolz3e71f782018-08-29 23:15:45 -05001839 if (exclusive_scissor_struct &&
1840 exclusive_scissor_struct->exclusiveScissorCount != 0 &&
1841 exclusive_scissor_struct->exclusiveScissorCount != viewport_state.viewportCount) {
1842 skip |=
1843 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
1844 VK_NULL_HANDLE, "VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-exclusiveScissorCount-02029",
1845 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "] exclusiveScissorCount (=%" PRIu32
1846 ") must be zero or identical to pCreateInfos[%" PRIu32 "].pViewportState->viewportCount (=%" PRIu32 ").",
1847 i, exclusive_scissor_struct->exclusiveScissorCount, i, viewport_state.viewportCount);
1848 }
1849
Jeff Bolz9af91c52018-09-01 21:53:57 -05001850 if (shading_rate_image_struct &&
1851 shading_rate_image_struct->shadingRateImageEnable &&
1852 shading_rate_image_struct->viewportCount != viewport_state.viewportCount) {
1853 skip |=
1854 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
1855 VK_NULL_HANDLE, "VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-shadingRateImageEnable-02056",
1856 "vkCreateGraphicsPipelines: If shadingRateImageEnable is enabled, pCreateInfos[%" PRIu32 "] "
1857 "VkPipelineViewportShadingRateImageStateCreateInfoNV viewportCount (=%" PRIu32
1858 ") must identical to pCreateInfos[%" PRIu32 "].pViewportState->viewportCount (=%" PRIu32 ").",
1859 i, shading_rate_image_struct->viewportCount, i, viewport_state.viewportCount);
1860 }
1861
Petr Krausa6103552017-11-16 21:21:58 +01001862 if (!has_dynamic_viewport && viewport_state.viewportCount > 0 && viewport_state.pViewports == nullptr) {
1863 skip |= log_msg(
1864 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, VK_NULL_HANDLE,
Dave Houlton413a6782018-05-22 13:01:54 -06001865 "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-00747",
Petr Krausa6103552017-11-16 21:21:58 +01001866 "vkCreateGraphicsPipelines: The viewport state is static (pCreateInfos[%" PRIu32
1867 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_VIEWPORT), but pCreateInfos[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001868 "].pViewportState->pViewports (=NULL) is an invalid pointer.",
1869 i, i);
Petr Krausa6103552017-11-16 21:21:58 +01001870 }
1871
1872 if (!has_dynamic_scissor && viewport_state.scissorCount > 0 && viewport_state.pScissors == nullptr) {
1873 skip |= log_msg(
1874 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, VK_NULL_HANDLE,
Dave Houlton413a6782018-05-22 13:01:54 -06001875 "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-00748",
Petr Krausa6103552017-11-16 21:21:58 +01001876 "vkCreateGraphicsPipelines: The scissor state is static (pCreateInfos[%" PRIu32
1877 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_SCISSOR), but pCreateInfos[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001878 "].pViewportState->pScissors (=NULL) is an invalid pointer.",
1879 i, i);
Petr Krausa6103552017-11-16 21:21:58 +01001880 }
1881
Jeff Bolz3e71f782018-08-29 23:15:45 -05001882 if (!has_dynamic_exclusive_scissor_nv && exclusive_scissor_struct &&
1883 exclusive_scissor_struct->exclusiveScissorCount > 0 && exclusive_scissor_struct->pExclusiveScissors == nullptr) {
1884 skip |= log_msg(
1885 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, VK_NULL_HANDLE,
1886 "VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-pDynamicStates-02030",
1887 "vkCreateGraphicsPipelines: The exclusive scissor state is static (pCreateInfos[%" PRIu32
1888 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV), but pCreateInfos[%" PRIu32
1889 "] pExclusiveScissors (=NULL) is an invalid pointer.",
1890 i, i);
1891 }
1892
Jeff Bolz9af91c52018-09-01 21:53:57 -05001893 if (!has_dynamic_shading_rate_palette_nv && shading_rate_image_struct &&
1894 shading_rate_image_struct->viewportCount > 0 && shading_rate_image_struct->pShadingRatePalettes == nullptr) {
1895 skip |= log_msg(
1896 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, VK_NULL_HANDLE,
1897 "VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-pDynamicStates-02057",
1898 "vkCreateGraphicsPipelines: The shading rate palette state is static (pCreateInfos[%" PRIu32
1899 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_VIEWPORT_SHADING_RATE_PALETTE_NV), but pCreateInfos[%" PRIu32
1900 "] pShadingRatePalettes (=NULL) is an invalid pointer.",
1901 i, i);
1902 }
1903
Petr Krausb3fcdb42018-01-09 22:09:09 +01001904 // validate the VkViewports
1905 if (!has_dynamic_viewport && viewport_state.pViewports) {
1906 for (uint32_t viewport_i = 0; viewport_i < viewport_state.viewportCount; ++viewport_i) {
1907 const auto &viewport = viewport_state.pViewports[viewport_i]; // will crash on invalid ptr
1908 const char fn_name[] = "vkCreateGraphicsPipelines";
1909 const std::string param_name = "pCreateInfos[" + std::to_string(i) + "].pViewportState->pViewports[" +
1910 std::to_string(viewport_i) + "]";
1911 skip |= pv_VkViewport(device_data, viewport, fn_name, param_name.c_str(),
1912 VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT);
1913 }
1914 }
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001915
1916 if (has_dynamic_viewport_w_scaling_nv && !device_data->extensions.vk_nv_clip_space_w_scaling) {
1917 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001918 VK_NULL_HANDLE, kVUID_PVError_ExtensionNotEnabled,
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001919 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
Dave Houltona9df0ce2018-02-07 10:51:23 -07001920 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_VIEWPORT_W_SCALING_NV, but "
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001921 "VK_NV_clip_space_w_scaling extension is not enabled.",
1922 i);
1923 }
1924
1925 if (has_dynamic_discard_rectangle_ext && !device_data->extensions.vk_ext_discard_rectangles) {
1926 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001927 VK_NULL_HANDLE, kVUID_PVError_ExtensionNotEnabled,
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001928 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
Dave Houltona9df0ce2018-02-07 10:51:23 -07001929 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_DISCARD_RECTANGLE_EXT, but "
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001930 "VK_EXT_discard_rectangles extension is not enabled.",
1931 i);
1932 }
1933
1934 if (has_dynamic_sample_locations_ext && !device_data->extensions.vk_ext_sample_locations) {
1935 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001936 VK_NULL_HANDLE, kVUID_PVError_ExtensionNotEnabled,
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001937 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
Dave Houltona9df0ce2018-02-07 10:51:23 -07001938 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_SAMPLE_LOCATIONS_EXT, but "
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001939 "VK_EXT_sample_locations extension is not enabled.",
1940 i);
1941 }
Jeff Bolz3e71f782018-08-29 23:15:45 -05001942
1943 if (has_dynamic_exclusive_scissor_nv && !device_data->extensions.vk_nv_scissor_exclusive) {
1944 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
1945 VK_NULL_HANDLE, kVUID_PVError_ExtensionNotEnabled,
1946 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1947 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV, but "
1948 "VK_NV_scissor_exclusive extension is not enabled.",
1949 i);
1950 }
Jeff Bolz9af91c52018-09-01 21:53:57 -05001951
1952 if (coarse_sample_order_struct &&
1953 coarse_sample_order_struct->sampleOrderType != VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV &&
1954 coarse_sample_order_struct->customSampleOrderCount != 0) {
1955 skip |=
1956 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
1957 VK_NULL_HANDLE, "VUID-VkPipelineViewportCoarseSampleOrderStateCreateInfoNV-sampleOrderType-02072",
1958 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "] "
1959 "VkPipelineViewportCoarseSampleOrderStateCreateInfoNV sampleOrderType is not "
1960 "VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV and customSampleOrderCount is not 0.",
1961 i);
1962 }
1963
1964 if (coarse_sample_order_struct) {
1965 for (uint32_t order_i = 0; order_i < coarse_sample_order_struct->customSampleOrderCount; ++order_i) {
1966 skip |= ValidateCoarseSampleOrderCustomNV(device_data, &coarse_sample_order_struct->pCustomSampleOrders[order_i]);
1967 }
1968 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001969 }
1970
1971 if (pCreateInfos[i].pMultisampleState == nullptr) {
1972 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001973 "VUID-VkGraphicsPipelineCreateInfo-rasterizerDiscardEnable-00751",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001974 "vkCreateGraphicsPipelines: if pCreateInfos[%d].pRasterizationState->rasterizerDiscardEnable "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001975 "is VK_FALSE, pCreateInfos[%d].pMultisampleState must not be NULL.",
1976 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001977 } else {
Dave Houltonb3bbec72018-01-17 10:13:33 -07001978 const VkStructureType valid_next_stypes[] = {LvlTypeMap<VkPipelineCoverageModulationStateCreateInfoNV>::kSType,
1979 LvlTypeMap<VkPipelineCoverageToColorStateCreateInfoNV>::kSType,
1980 LvlTypeMap<VkPipelineSampleLocationsStateCreateInfoEXT>::kSType};
Mike Schuchardt97662b02017-12-06 13:31:29 -07001981 const char *valid_struct_names =
Dave Houltona9df0ce2018-02-07 10:51:23 -07001982 "VkPipelineCoverageModulationStateCreateInfoNV, VkPipelineCoverageToColorStateCreateInfoNV, "
John Zulauf96b0e422017-11-14 11:43:19 -07001983 "VkPipelineSampleLocationsStateCreateInfoEXT";
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001984 skip |= validate_struct_pnext(
1985 report_data, "vkCreateGraphicsPipelines",
John Zulauf96b0e422017-11-14 11:43:19 -07001986 ParameterName("pCreateInfos[%i].pMultisampleState->pNext", ParameterName::IndexVector{i}),
1987 valid_struct_names, pCreateInfos[i].pMultisampleState->pNext, 3, valid_next_stypes, GeneratedHeaderVersion,
Dave Houlton413a6782018-05-22 13:01:54 -06001988 "VUID-VkPipelineMultisampleStateCreateInfo-pNext-pNext");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001989
1990 skip |= validate_reserved_flags(
1991 report_data, "vkCreateGraphicsPipelines",
1992 ParameterName("pCreateInfos[%i].pMultisampleState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06001993 pCreateInfos[i].pMultisampleState->flags, "VUID-VkPipelineMultisampleStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001994
1995 skip |= validate_bool32(
1996 report_data, "vkCreateGraphicsPipelines",
1997 ParameterName("pCreateInfos[%i].pMultisampleState->sampleShadingEnable", ParameterName::IndexVector{i}),
1998 pCreateInfos[i].pMultisampleState->sampleShadingEnable);
1999
2000 skip |= validate_array(
2001 report_data, "vkCreateGraphicsPipelines",
2002 ParameterName("pCreateInfos[%i].pMultisampleState->rasterizationSamples", ParameterName::IndexVector{i}),
2003 ParameterName("pCreateInfos[%i].pMultisampleState->pSampleMask", ParameterName::IndexVector{i}),
Gabríel Arthúr Pétursson092b29b2018-03-21 22:44:11 +00002004 pCreateInfos[i].pMultisampleState->rasterizationSamples, &pCreateInfos[i].pMultisampleState->pSampleMask,
Dave Houlton413a6782018-05-22 13:01:54 -06002005 true, false, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002006
2007 skip |= validate_bool32(
2008 report_data, "vkCreateGraphicsPipelines",
2009 ParameterName("pCreateInfos[%i].pMultisampleState->alphaToCoverageEnable", ParameterName::IndexVector{i}),
2010 pCreateInfos[i].pMultisampleState->alphaToCoverageEnable);
2011
2012 skip |= validate_bool32(
2013 report_data, "vkCreateGraphicsPipelines",
2014 ParameterName("pCreateInfos[%i].pMultisampleState->alphaToOneEnable", ParameterName::IndexVector{i}),
2015 pCreateInfos[i].pMultisampleState->alphaToOneEnable);
2016
2017 if (pCreateInfos[i].pMultisampleState->sType != VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO) {
2018 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002019 kVUID_PVError_InvalidStructSType,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002020 "vkCreateGraphicsPipelines: parameter pCreateInfos[%d].pMultisampleState->sType must be "
2021 "VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO",
2022 i);
2023 }
John Zulauf7acac592017-11-06 11:15:53 -07002024 if (pCreateInfos[i].pMultisampleState->sampleShadingEnable == VK_TRUE) {
2025 if (!device_data->physical_device_features.sampleRateShading) {
2026 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002027 "VUID-VkPipelineMultisampleStateCreateInfo-sampleShadingEnable-00784",
John Zulauf7acac592017-11-06 11:15:53 -07002028 "vkCreateGraphicsPipelines(): parameter "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002029 "pCreateInfos[%d].pMultisampleState->sampleShadingEnable.",
2030 i);
John Zulauf7acac592017-11-06 11:15:53 -07002031 }
2032 // TODO Add documentation issue about when minSampleShading must be in range and when it is ignored
2033 // For now a "least noise" test *only* when sampleShadingEnable is VK_TRUE.
2034 if (!in_inclusive_range(pCreateInfos[i].pMultisampleState->minSampleShading, 0.F, 1.0F)) {
2035 skip |= log_msg(
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002036 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002037 "VUID-VkPipelineMultisampleStateCreateInfo-minSampleShading-00786",
Mark Lobodzinski88529492018-04-01 10:38:15 -06002038 "vkCreateGraphicsPipelines(): parameter pCreateInfos[%d].pMultisampleState->minSampleShading.", i);
John Zulauf7acac592017-11-06 11:15:53 -07002039 }
2040 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002041 }
2042
Petr Krause91f7a12017-12-14 20:57:36 +01002043 bool uses_color_attachment = false;
2044 bool uses_depthstencil_attachment = false;
2045 {
2046 const auto subpasses_uses_it = device_data->renderpasses_states.find(pCreateInfos[i].renderPass);
2047 if (subpasses_uses_it != device_data->renderpasses_states.end()) {
2048 const auto &subpasses_uses = subpasses_uses_it->second;
2049 if (subpasses_uses.subpasses_using_color_attachment.count(pCreateInfos[i].subpass))
2050 uses_color_attachment = true;
2051 if (subpasses_uses.subpasses_using_depthstencil_attachment.count(pCreateInfos[i].subpass))
2052 uses_depthstencil_attachment = true;
2053 }
2054 }
2055
2056 if (pCreateInfos[i].pDepthStencilState != nullptr && uses_depthstencil_attachment) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002057 skip |= validate_struct_pnext(
2058 report_data, "vkCreateGraphicsPipelines",
2059 ParameterName("pCreateInfos[%i].pDepthStencilState->pNext", ParameterName::IndexVector{i}), NULL,
Dave Houlton413a6782018-05-22 13:01:54 -06002060 pCreateInfos[i].pDepthStencilState->pNext, 0, NULL, GeneratedHeaderVersion,
2061 "VUID-VkPipelineDepthStencilStateCreateInfo-pNext-pNext");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002062
2063 skip |= validate_reserved_flags(
2064 report_data, "vkCreateGraphicsPipelines",
2065 ParameterName("pCreateInfos[%i].pDepthStencilState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06002066 pCreateInfos[i].pDepthStencilState->flags, "VUID-VkPipelineDepthStencilStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002067
2068 skip |= validate_bool32(
2069 report_data, "vkCreateGraphicsPipelines",
2070 ParameterName("pCreateInfos[%i].pDepthStencilState->depthTestEnable", ParameterName::IndexVector{i}),
2071 pCreateInfos[i].pDepthStencilState->depthTestEnable);
2072
2073 skip |= validate_bool32(
2074 report_data, "vkCreateGraphicsPipelines",
2075 ParameterName("pCreateInfos[%i].pDepthStencilState->depthWriteEnable", ParameterName::IndexVector{i}),
2076 pCreateInfos[i].pDepthStencilState->depthWriteEnable);
2077
2078 skip |= validate_ranged_enum(
2079 report_data, "vkCreateGraphicsPipelines",
2080 ParameterName("pCreateInfos[%i].pDepthStencilState->depthCompareOp", ParameterName::IndexVector{i}),
2081 "VkCompareOp", AllVkCompareOpEnums, pCreateInfos[i].pDepthStencilState->depthCompareOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002082 "VUID-VkPipelineDepthStencilStateCreateInfo-depthCompareOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002083
2084 skip |= validate_bool32(
2085 report_data, "vkCreateGraphicsPipelines",
2086 ParameterName("pCreateInfos[%i].pDepthStencilState->depthBoundsTestEnable", ParameterName::IndexVector{i}),
2087 pCreateInfos[i].pDepthStencilState->depthBoundsTestEnable);
2088
2089 skip |= validate_bool32(
2090 report_data, "vkCreateGraphicsPipelines",
2091 ParameterName("pCreateInfos[%i].pDepthStencilState->stencilTestEnable", ParameterName::IndexVector{i}),
2092 pCreateInfos[i].pDepthStencilState->stencilTestEnable);
2093
2094 skip |= validate_ranged_enum(
2095 report_data, "vkCreateGraphicsPipelines",
2096 ParameterName("pCreateInfos[%i].pDepthStencilState->front.failOp", ParameterName::IndexVector{i}),
2097 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->front.failOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002098 "VUID-VkStencilOpState-failOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002099
2100 skip |= validate_ranged_enum(
2101 report_data, "vkCreateGraphicsPipelines",
2102 ParameterName("pCreateInfos[%i].pDepthStencilState->front.passOp", ParameterName::IndexVector{i}),
2103 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->front.passOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002104 "VUID-VkStencilOpState-passOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002105
2106 skip |= validate_ranged_enum(
2107 report_data, "vkCreateGraphicsPipelines",
2108 ParameterName("pCreateInfos[%i].pDepthStencilState->front.depthFailOp", ParameterName::IndexVector{i}),
2109 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->front.depthFailOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002110 "VUID-VkStencilOpState-depthFailOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002111
2112 skip |= validate_ranged_enum(
2113 report_data, "vkCreateGraphicsPipelines",
2114 ParameterName("pCreateInfos[%i].pDepthStencilState->front.compareOp", ParameterName::IndexVector{i}),
2115 "VkCompareOp", AllVkCompareOpEnums, pCreateInfos[i].pDepthStencilState->front.compareOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002116 "VUID-VkPipelineDepthStencilStateCreateInfo-depthCompareOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002117
2118 skip |= validate_ranged_enum(
2119 report_data, "vkCreateGraphicsPipelines",
2120 ParameterName("pCreateInfos[%i].pDepthStencilState->back.failOp", ParameterName::IndexVector{i}),
2121 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->back.failOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002122 "VUID-VkStencilOpState-failOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002123
2124 skip |= validate_ranged_enum(
2125 report_data, "vkCreateGraphicsPipelines",
2126 ParameterName("pCreateInfos[%i].pDepthStencilState->back.passOp", ParameterName::IndexVector{i}),
2127 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->back.passOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002128 "VUID-VkStencilOpState-passOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002129
2130 skip |= validate_ranged_enum(
2131 report_data, "vkCreateGraphicsPipelines",
2132 ParameterName("pCreateInfos[%i].pDepthStencilState->back.depthFailOp", ParameterName::IndexVector{i}),
2133 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->back.depthFailOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002134 "VUID-VkStencilOpState-depthFailOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002135
2136 skip |= validate_ranged_enum(
2137 report_data, "vkCreateGraphicsPipelines",
2138 ParameterName("pCreateInfos[%i].pDepthStencilState->back.compareOp", ParameterName::IndexVector{i}),
2139 "VkCompareOp", AllVkCompareOpEnums, pCreateInfos[i].pDepthStencilState->back.compareOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002140 "VUID-VkPipelineDepthStencilStateCreateInfo-depthCompareOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002141
2142 if (pCreateInfos[i].pDepthStencilState->sType != VK_STRUCTURE_TYPE_PIPELINE_DEPTH_STENCIL_STATE_CREATE_INFO) {
2143 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002144 kVUID_PVError_InvalidStructSType,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002145 "vkCreateGraphicsPipelines: parameter pCreateInfos[%d].pDepthStencilState->sType must be "
2146 "VK_STRUCTURE_TYPE_PIPELINE_DEPTH_STENCIL_STATE_CREATE_INFO",
2147 i);
2148 }
2149 }
2150
Petr Krause91f7a12017-12-14 20:57:36 +01002151 if (pCreateInfos[i].pColorBlendState != nullptr && uses_color_attachment) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002152 skip |= validate_struct_pnext(
2153 report_data, "vkCreateGraphicsPipelines",
2154 ParameterName("pCreateInfos[%i].pColorBlendState->pNext", ParameterName::IndexVector{i}), NULL,
Dave Houlton413a6782018-05-22 13:01:54 -06002155 pCreateInfos[i].pColorBlendState->pNext, 0, NULL, GeneratedHeaderVersion,
2156 "VUID-VkPipelineColorBlendStateCreateInfo-pNext-pNext");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002157
2158 skip |= validate_reserved_flags(
2159 report_data, "vkCreateGraphicsPipelines",
2160 ParameterName("pCreateInfos[%i].pColorBlendState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06002161 pCreateInfos[i].pColorBlendState->flags, "VUID-VkPipelineColorBlendStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002162
2163 skip |= validate_bool32(
2164 report_data, "vkCreateGraphicsPipelines",
2165 ParameterName("pCreateInfos[%i].pColorBlendState->logicOpEnable", ParameterName::IndexVector{i}),
2166 pCreateInfos[i].pColorBlendState->logicOpEnable);
2167
2168 skip |= validate_array(
2169 report_data, "vkCreateGraphicsPipelines",
2170 ParameterName("pCreateInfos[%i].pColorBlendState->attachmentCount", ParameterName::IndexVector{i}),
2171 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments", ParameterName::IndexVector{i}),
Gabríel Arthúr Pétursson092b29b2018-03-21 22:44:11 +00002172 pCreateInfos[i].pColorBlendState->attachmentCount, &pCreateInfos[i].pColorBlendState->pAttachments, false,
Dave Houlton413a6782018-05-22 13:01:54 -06002173 true, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002174
2175 if (pCreateInfos[i].pColorBlendState->pAttachments != NULL) {
2176 for (uint32_t attachmentIndex = 0; attachmentIndex < pCreateInfos[i].pColorBlendState->attachmentCount;
2177 ++attachmentIndex) {
2178 skip |= validate_bool32(report_data, "vkCreateGraphicsPipelines",
2179 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].blendEnable",
2180 ParameterName::IndexVector{i, attachmentIndex}),
2181 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].blendEnable);
2182
2183 skip |= validate_ranged_enum(
2184 report_data, "vkCreateGraphicsPipelines",
2185 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].srcColorBlendFactor",
2186 ParameterName::IndexVector{i, attachmentIndex}),
2187 "VkBlendFactor", AllVkBlendFactorEnums,
2188 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].srcColorBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06002189 "VUID-VkPipelineColorBlendAttachmentState-srcColorBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002190
2191 skip |= validate_ranged_enum(
2192 report_data, "vkCreateGraphicsPipelines",
2193 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].dstColorBlendFactor",
2194 ParameterName::IndexVector{i, attachmentIndex}),
2195 "VkBlendFactor", AllVkBlendFactorEnums,
2196 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].dstColorBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06002197 "VUID-VkPipelineColorBlendAttachmentState-dstColorBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002198
2199 skip |= validate_ranged_enum(
2200 report_data, "vkCreateGraphicsPipelines",
2201 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].colorBlendOp",
2202 ParameterName::IndexVector{i, attachmentIndex}),
2203 "VkBlendOp", AllVkBlendOpEnums,
2204 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].colorBlendOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002205 "VUID-VkPipelineColorBlendAttachmentState-colorBlendOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002206
2207 skip |= validate_ranged_enum(
2208 report_data, "vkCreateGraphicsPipelines",
2209 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].srcAlphaBlendFactor",
2210 ParameterName::IndexVector{i, attachmentIndex}),
2211 "VkBlendFactor", AllVkBlendFactorEnums,
2212 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].srcAlphaBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06002213 "VUID-VkPipelineColorBlendAttachmentState-srcAlphaBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002214
2215 skip |= validate_ranged_enum(
2216 report_data, "vkCreateGraphicsPipelines",
2217 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].dstAlphaBlendFactor",
2218 ParameterName::IndexVector{i, attachmentIndex}),
2219 "VkBlendFactor", AllVkBlendFactorEnums,
2220 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].dstAlphaBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06002221 "VUID-VkPipelineColorBlendAttachmentState-dstAlphaBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002222
2223 skip |= validate_ranged_enum(
2224 report_data, "vkCreateGraphicsPipelines",
2225 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].alphaBlendOp",
2226 ParameterName::IndexVector{i, attachmentIndex}),
2227 "VkBlendOp", AllVkBlendOpEnums,
2228 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].alphaBlendOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002229 "VUID-VkPipelineColorBlendAttachmentState-alphaBlendOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002230
2231 skip |=
2232 validate_flags(report_data, "vkCreateGraphicsPipelines",
2233 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].colorWriteMask",
2234 ParameterName::IndexVector{i, attachmentIndex}),
2235 "VkColorComponentFlagBits", AllVkColorComponentFlagBits,
2236 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].colorWriteMask,
Dave Houlton413a6782018-05-22 13:01:54 -06002237 false, false, "VUID-VkPipelineColorBlendAttachmentState-colorWriteMask-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002238 }
2239 }
2240
2241 if (pCreateInfos[i].pColorBlendState->sType != VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO) {
2242 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002243 kVUID_PVError_InvalidStructSType,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002244 "vkCreateGraphicsPipelines: parameter pCreateInfos[%d].pColorBlendState->sType must be "
2245 "VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO",
2246 i);
2247 }
2248
2249 // If logicOpEnable is VK_TRUE, logicOp must be a valid VkLogicOp value
2250 if (pCreateInfos[i].pColorBlendState->logicOpEnable == VK_TRUE) {
2251 skip |= validate_ranged_enum(
2252 report_data, "vkCreateGraphicsPipelines",
2253 ParameterName("pCreateInfos[%i].pColorBlendState->logicOp", ParameterName::IndexVector{i}), "VkLogicOp",
Dave Houlton413a6782018-05-22 13:01:54 -06002254 AllVkLogicOpEnums, pCreateInfos[i].pColorBlendState->logicOp,
2255 "VUID-VkPipelineColorBlendStateCreateInfo-logicOpEnable-00607");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002256 }
2257 }
2258 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002259
Petr Kraus9752aae2017-11-24 03:05:50 +01002260 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_DERIVATIVE_BIT) {
2261 if (pCreateInfos[i].basePipelineIndex != -1) {
2262 if (pCreateInfos[i].basePipelineHandle != VK_NULL_HANDLE) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07002263 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002264 "VUID-VkGraphicsPipelineCreateInfo-flags-00724",
Dave Houltona9df0ce2018-02-07 10:51:23 -07002265 "vkCreateGraphicsPipelines parameter, pCreateInfos->basePipelineHandle, must be "
2266 "VK_NULL_HANDLE if pCreateInfos->flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT flag "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002267 "and pCreateInfos->basePipelineIndex is not -1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002268 }
2269 }
2270
Petr Kraus9752aae2017-11-24 03:05:50 +01002271 if (pCreateInfos[i].basePipelineHandle != VK_NULL_HANDLE) {
2272 if (pCreateInfos[i].basePipelineIndex != -1) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07002273 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002274 "VUID-VkGraphicsPipelineCreateInfo-flags-00725",
Dave Houltona9df0ce2018-02-07 10:51:23 -07002275 "vkCreateGraphicsPipelines parameter, pCreateInfos->basePipelineIndex, must be -1 if "
2276 "pCreateInfos->flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT flag and "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002277 "pCreateInfos->basePipelineHandle is not VK_NULL_HANDLE.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002278 }
2279 }
2280 }
2281
Petr Kraus9752aae2017-11-24 03:05:50 +01002282 if (pCreateInfos[i].pRasterizationState) {
2283 if ((pCreateInfos[i].pRasterizationState->polygonMode != VK_POLYGON_MODE_FILL) &&
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002284 (device_data->physical_device_features.fillModeNonSolid == false)) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07002285 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002286 kVUID_PVError_DeviceFeature,
Dave Houltona9df0ce2018-02-07 10:51:23 -07002287 "vkCreateGraphicsPipelines parameter, VkPolygonMode "
2288 "pCreateInfos->pRasterizationState->polygonMode cannot be VK_POLYGON_MODE_POINT or "
2289 "VK_POLYGON_MODE_LINE if VkPhysicalDeviceFeatures->fillModeNonSolid is false.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002290 }
Petr Kraus299ba622017-11-24 03:09:03 +01002291
2292 if (!has_dynamic_line_width && !device_data->physical_device_features.wideLines &&
2293 (pCreateInfos[i].pRasterizationState->lineWidth != 1.0f)) {
Dave Houlton413a6782018-05-22 13:01:54 -06002294 skip |=
2295 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
2296 0, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-00749",
2297 "The line width state is static (pCreateInfos[%" PRIu32
2298 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_LINE_WIDTH) and "
2299 "VkPhysicalDeviceFeatures::wideLines is disabled, but pCreateInfos[%" PRIu32
2300 "].pRasterizationState->lineWidth (=%f) is not 1.0.",
2301 i, i, pCreateInfos[i].pRasterizationState->lineWidth);
Petr Kraus299ba622017-11-24 03:09:03 +01002302 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002303 }
2304
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002305 for (size_t j = 0; j < pCreateInfos[i].stageCount; j++) {
2306 skip |= validate_string(device_data->report_data, "vkCreateGraphicsPipelines",
2307 ParameterName("pCreateInfos[%i].pStages[%i].pName", ParameterName::IndexVector{i, j}),
Mark Lobodzinskiebee3552018-05-29 09:55:54 -06002308 "VUID-VkGraphicsPipelineCreateInfo-pStages-parameter", pCreateInfos[i].pStages[j].pName);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002309 }
2310 }
2311 }
2312
2313 return skip;
2314}
2315
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002316bool pv_vkCreateComputePipelines(VkDevice device, VkPipelineCache pipelineCache, uint32_t createInfoCount,
2317 const VkComputePipelineCreateInfo *pCreateInfos, const VkAllocationCallbacks *pAllocator,
2318 VkPipeline *pPipelines) {
2319 bool skip = false;
2320 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2321
2322 for (uint32_t i = 0; i < createInfoCount; i++) {
2323 skip |= validate_string(device_data->report_data, "vkCreateComputePipelines",
2324 ParameterName("pCreateInfos[%i].stage.pName", ParameterName::IndexVector{i}),
Mark Lobodzinskiebee3552018-05-29 09:55:54 -06002325 "VUID-VkPipelineShaderStageCreateInfo-pName-parameter", pCreateInfos[i].stage.pName);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002326 }
2327
2328 return skip;
2329}
2330
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002331bool pv_vkCreateSampler(VkDevice device, const VkSamplerCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
2332 VkSampler *pSampler) {
2333 bool skip = false;
2334 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2335 debug_report_data *report_data = device_data->report_data;
2336
2337 if (pCreateInfo != nullptr) {
John Zulauf71968502017-10-26 13:51:15 -06002338 const auto &features = device_data->physical_device_features;
2339 const auto &limits = device_data->device_limits;
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002340
John Zulauf71968502017-10-26 13:51:15 -06002341 if (pCreateInfo->anisotropyEnable == VK_TRUE) {
2342 if (!in_inclusive_range(pCreateInfo->maxAnisotropy, 1.0F, limits.maxSamplerAnisotropy)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002343 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002344 "VUID-VkSamplerCreateInfo-anisotropyEnable-01071",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002345 "vkCreateSampler(): value of %s must be in range [1.0, %f] %s, but %f found.",
John Zulauf71968502017-10-26 13:51:15 -06002346 "pCreateInfo->maxAnisotropy", limits.maxSamplerAnisotropy,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002347 "VkPhysicalDeviceLimits::maxSamplerAnistropy", pCreateInfo->maxAnisotropy);
John Zulauf71968502017-10-26 13:51:15 -06002348 }
2349
2350 // Anistropy cannot be enabled in sampler unless enabled as a feature
2351 if (features.samplerAnisotropy == VK_FALSE) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002352 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002353 "VUID-VkSamplerCreateInfo-anisotropyEnable-01070",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002354 "vkCreateSampler(): Anisotropic sampling feature is not enabled, %s must be VK_FALSE.",
2355 "pCreateInfo->anisotropyEnable");
John Zulauf71968502017-10-26 13:51:15 -06002356 }
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002357 }
John Zulauf71968502017-10-26 13:51:15 -06002358
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002359 if (pCreateInfo->unnormalizedCoordinates == VK_TRUE) {
2360 if (pCreateInfo->minFilter != pCreateInfo->magFilter) {
2361 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
2362 "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01072",
2363 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
2364 "pCreateInfo->minFilter (%s) and pCreateInfo->magFilter (%s) must be equal.",
2365 string_VkFilter(pCreateInfo->minFilter), string_VkFilter(pCreateInfo->magFilter));
2366 }
2367 if (pCreateInfo->mipmapMode != VK_SAMPLER_MIPMAP_MODE_NEAREST) {
2368 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
2369 "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01073",
2370 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
2371 "pCreateInfo->mipmapMode (%s) must be VK_SAMPLER_MIPMAP_MODE_NEAREST.",
2372 string_VkSamplerMipmapMode(pCreateInfo->mipmapMode));
2373 }
2374 if (pCreateInfo->minLod != 0.0f || pCreateInfo->maxLod != 0.0f) {
2375 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
2376 "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01074",
2377 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
2378 "pCreateInfo->minLod (%f) and pCreateInfo->maxLod (%f) must both be zero.",
2379 pCreateInfo->minLod, pCreateInfo->maxLod);
2380 }
2381 if ((pCreateInfo->addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE &&
2382 pCreateInfo->addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER) ||
2383 (pCreateInfo->addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE &&
2384 pCreateInfo->addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER)) {
2385 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
2386 "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01075",
2387 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
2388 "pCreateInfo->addressModeU (%s) and pCreateInfo->addressModeV (%s) must both be "
2389 "VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE or VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER.",
2390 string_VkSamplerAddressMode(pCreateInfo->addressModeU),
2391 string_VkSamplerAddressMode(pCreateInfo->addressModeV));
2392 }
2393 if (pCreateInfo->anisotropyEnable == VK_TRUE) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002394 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002395 "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01076",
Dave Houltona9df0ce2018-02-07 10:51:23 -07002396 "vkCreateSampler(): pCreateInfo->anisotropyEnable and pCreateInfo->unnormalizedCoordinates must "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002397 "not both be VK_TRUE.");
John Zulauf71968502017-10-26 13:51:15 -06002398 }
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002399 if (pCreateInfo->compareEnable == VK_TRUE) {
2400 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
2401 "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01077",
2402 "vkCreateSampler(): pCreateInfo->compareEnable and pCreateInfo->unnormalizedCoordinates must "
2403 "not both be VK_TRUE.");
2404 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002405 }
2406
2407 // If compareEnable is VK_TRUE, compareOp must be a valid VkCompareOp value
2408 if (pCreateInfo->compareEnable == VK_TRUE) {
Dave Houlton413a6782018-05-22 13:01:54 -06002409 skip |=
2410 validate_ranged_enum(report_data, "vkCreateSampler", "pCreateInfo->compareOp", "VkCompareOp", AllVkCompareOpEnums,
2411 pCreateInfo->compareOp, "VUID-VkSamplerCreateInfo-compareEnable-01080");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002412 }
2413
2414 // If any of addressModeU, addressModeV or addressModeW are VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER, borderColor must be a
2415 // valid VkBorderColor value
2416 if ((pCreateInfo->addressModeU == VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER) ||
2417 (pCreateInfo->addressModeV == VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER) ||
2418 (pCreateInfo->addressModeW == VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER)) {
2419 skip |= validate_ranged_enum(report_data, "vkCreateSampler", "pCreateInfo->borderColor", "VkBorderColor",
Dave Houlton413a6782018-05-22 13:01:54 -06002420 AllVkBorderColorEnums, pCreateInfo->borderColor,
2421 "VUID-VkSamplerCreateInfo-addressModeU-01078");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002422 }
2423
2424 // If any of addressModeU, addressModeV or addressModeW are VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE, the
2425 // VK_KHR_sampler_mirror_clamp_to_edge extension must be enabled
2426 if (!device_data->extensions.vk_khr_sampler_mirror_clamp_to_edge &&
2427 ((pCreateInfo->addressModeU == VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE) ||
2428 (pCreateInfo->addressModeV == VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE) ||
2429 (pCreateInfo->addressModeW == VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE))) {
Dave Houlton413a6782018-05-22 13:01:54 -06002430 skip |=
2431 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
2432 "VUID-VkSamplerCreateInfo-addressModeU-01079",
2433 "vkCreateSampler(): A VkSamplerAddressMode value is set to VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE "
2434 "but the VK_KHR_sampler_mirror_clamp_to_edge extension has not been enabled.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002435 }
John Zulauf275805c2017-10-26 15:34:49 -06002436
2437 // Checks for the IMG cubic filtering extension
2438 if (device_data->extensions.vk_img_filter_cubic) {
2439 if ((pCreateInfo->anisotropyEnable == VK_TRUE) &&
2440 ((pCreateInfo->minFilter == VK_FILTER_CUBIC_IMG) || (pCreateInfo->magFilter == VK_FILTER_CUBIC_IMG))) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002441 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002442 "VUID-VkSamplerCreateInfo-magFilter-01081",
Dave Houltona9df0ce2018-02-07 10:51:23 -07002443 "vkCreateSampler(): Anisotropic sampling must not be VK_TRUE when either minFilter or magFilter "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002444 "are VK_FILTER_CUBIC_IMG.");
John Zulauf275805c2017-10-26 15:34:49 -06002445 }
2446 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002447 }
2448
2449 return skip;
2450}
2451
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002452bool pv_vkCreateDescriptorSetLayout(VkDevice device, const VkDescriptorSetLayoutCreateInfo *pCreateInfo,
2453 const VkAllocationCallbacks *pAllocator, VkDescriptorSetLayout *pSetLayout) {
2454 bool skip = false;
2455 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2456 debug_report_data *report_data = device_data->report_data;
2457
2458 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
2459 if ((pCreateInfo != nullptr) && (pCreateInfo->pBindings != nullptr)) {
2460 for (uint32_t i = 0; i < pCreateInfo->bindingCount; ++i) {
2461 if (pCreateInfo->pBindings[i].descriptorCount != 0) {
2462 // If descriptorType is VK_DESCRIPTOR_TYPE_SAMPLER or VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER, and descriptorCount
2463 // is not 0 and pImmutableSamplers is not NULL, pImmutableSamplers must be a pointer to an array of descriptorCount
2464 // valid VkSampler handles
2465 if (((pCreateInfo->pBindings[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLER) ||
2466 (pCreateInfo->pBindings[i].descriptorType == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER)) &&
2467 (pCreateInfo->pBindings[i].pImmutableSamplers != nullptr)) {
2468 for (uint32_t descriptor_index = 0; descriptor_index < pCreateInfo->pBindings[i].descriptorCount;
2469 ++descriptor_index) {
2470 if (pCreateInfo->pBindings[i].pImmutableSamplers[descriptor_index] == VK_NULL_HANDLE) {
2471 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002472 kVUID_PVError_RequiredParameter,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002473 "vkCreateDescriptorSetLayout: required parameter "
Dave Houltona9df0ce2018-02-07 10:51:23 -07002474 "pCreateInfo->pBindings[%d].pImmutableSamplers[%d] specified as VK_NULL_HANDLE",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002475 i, descriptor_index);
2476 }
2477 }
2478 }
2479
2480 // If descriptorCount is not 0, stageFlags must be a valid combination of VkShaderStageFlagBits values
2481 if ((pCreateInfo->pBindings[i].stageFlags != 0) &&
2482 ((pCreateInfo->pBindings[i].stageFlags & (~AllVkShaderStageFlagBits)) != 0)) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07002483 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002484 "VUID-VkDescriptorSetLayoutBinding-descriptorCount-00283",
Dave Houltona9df0ce2018-02-07 10:51:23 -07002485 "vkCreateDescriptorSetLayout(): if pCreateInfo->pBindings[%d].descriptorCount is not 0, "
2486 "pCreateInfo->pBindings[%d].stageFlags must be a valid combination of VkShaderStageFlagBits "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002487 "values.",
2488 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002489 }
2490 }
2491 }
2492 }
2493
2494 return skip;
2495}
2496
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002497bool pv_vkFreeDescriptorSets(VkDevice device, VkDescriptorPool descriptorPool, uint32_t descriptorSetCount,
2498 const VkDescriptorSet *pDescriptorSets) {
2499 bool skip = false;
2500 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2501 debug_report_data *report_data = device_data->report_data;
2502
2503 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
2504 // This is an array of handles, where the elements are allowed to be VK_NULL_HANDLE, and does not require any validation beyond
2505 // validate_array()
2506 skip |= validate_array(report_data, "vkFreeDescriptorSets", "descriptorSetCount", "pDescriptorSets", descriptorSetCount,
Dave Houlton413a6782018-05-22 13:01:54 -06002507 &pDescriptorSets, true, true, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002508 return skip;
2509}
2510
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002511bool pv_vkUpdateDescriptorSets(VkDevice device, uint32_t descriptorWriteCount, const VkWriteDescriptorSet *pDescriptorWrites,
2512 uint32_t descriptorCopyCount, const VkCopyDescriptorSet *pDescriptorCopies) {
2513 bool skip = false;
2514 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2515 debug_report_data *report_data = device_data->report_data;
2516
2517 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
2518 if (pDescriptorWrites != NULL) {
2519 for (uint32_t i = 0; i < descriptorWriteCount; ++i) {
2520 // descriptorCount must be greater than 0
2521 if (pDescriptorWrites[i].descriptorCount == 0) {
2522 skip |=
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002523 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002524 "VUID-VkWriteDescriptorSet-descriptorCount-arraylength",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002525 "vkUpdateDescriptorSets(): parameter pDescriptorWrites[%d].descriptorCount must be greater than 0.", i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002526 }
2527
2528 // dstSet must be a valid VkDescriptorSet handle
2529 skip |= validate_required_handle(report_data, "vkUpdateDescriptorSets",
2530 ParameterName("pDescriptorWrites[%i].dstSet", ParameterName::IndexVector{i}),
2531 pDescriptorWrites[i].dstSet);
2532
2533 if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLER) ||
2534 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER) ||
2535 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE) ||
2536 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_IMAGE) ||
2537 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT)) {
2538 // If descriptorType is VK_DESCRIPTOR_TYPE_SAMPLER, VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER,
2539 // VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE, VK_DESCRIPTOR_TYPE_STORAGE_IMAGE or VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT,
2540 // pImageInfo must be a pointer to an array of descriptorCount valid VkDescriptorImageInfo structures
2541 if (pDescriptorWrites[i].pImageInfo == nullptr) {
2542 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002543 "VUID-VkWriteDescriptorSet-descriptorType-00322",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002544 "vkUpdateDescriptorSets(): if pDescriptorWrites[%d].descriptorType is "
2545 "VK_DESCRIPTOR_TYPE_SAMPLER, VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER, "
2546 "VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE, VK_DESCRIPTOR_TYPE_STORAGE_IMAGE or "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002547 "VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT, pDescriptorWrites[%d].pImageInfo must not be NULL.",
2548 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002549 } else if (pDescriptorWrites[i].descriptorType != VK_DESCRIPTOR_TYPE_SAMPLER) {
2550 // If descriptorType is VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER, VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE,
2551 // VK_DESCRIPTOR_TYPE_STORAGE_IMAGE or VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT, the imageView and imageLayout
2552 // members of any given element of pImageInfo must be a valid VkImageView and VkImageLayout, respectively
2553 for (uint32_t descriptor_index = 0; descriptor_index < pDescriptorWrites[i].descriptorCount;
2554 ++descriptor_index) {
2555 skip |= validate_required_handle(report_data, "vkUpdateDescriptorSets",
2556 ParameterName("pDescriptorWrites[%i].pImageInfo[%i].imageView",
2557 ParameterName::IndexVector{i, descriptor_index}),
2558 pDescriptorWrites[i].pImageInfo[descriptor_index].imageView);
2559 skip |= validate_ranged_enum(report_data, "vkUpdateDescriptorSets",
2560 ParameterName("pDescriptorWrites[%i].pImageInfo[%i].imageLayout",
2561 ParameterName::IndexVector{i, descriptor_index}),
2562 "VkImageLayout", AllVkImageLayoutEnums,
Dave Houlton413a6782018-05-22 13:01:54 -06002563 pDescriptorWrites[i].pImageInfo[descriptor_index].imageLayout, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002564 }
2565 }
2566 } else if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER) ||
2567 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER) ||
2568 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC) ||
2569 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC)) {
2570 // If descriptorType is VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER, VK_DESCRIPTOR_TYPE_STORAGE_BUFFER,
2571 // VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC or VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC, pBufferInfo must be a
2572 // pointer to an array of descriptorCount valid VkDescriptorBufferInfo structures
2573 if (pDescriptorWrites[i].pBufferInfo == nullptr) {
2574 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002575 "VUID-VkWriteDescriptorSet-descriptorType-00324",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002576 "vkUpdateDescriptorSets(): if pDescriptorWrites[%d].descriptorType is "
2577 "VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER, VK_DESCRIPTOR_TYPE_STORAGE_BUFFER, "
2578 "VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC or VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC, "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002579 "pDescriptorWrites[%d].pBufferInfo must not be NULL.",
2580 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002581 } else {
2582 for (uint32_t descriptorIndex = 0; descriptorIndex < pDescriptorWrites[i].descriptorCount; ++descriptorIndex) {
2583 skip |= validate_required_handle(report_data, "vkUpdateDescriptorSets",
2584 ParameterName("pDescriptorWrites[%i].pBufferInfo[%i].buffer",
2585 ParameterName::IndexVector{i, descriptorIndex}),
2586 pDescriptorWrites[i].pBufferInfo[descriptorIndex].buffer);
2587 }
2588 }
2589 } else if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER) ||
2590 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER)) {
2591 // If descriptorType is VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER or VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER,
2592 // pTexelBufferView must be a pointer to an array of descriptorCount valid VkBufferView handles
2593 if (pDescriptorWrites[i].pTexelBufferView == nullptr) {
2594 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002595 "VUID-VkWriteDescriptorSet-descriptorType-00323",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002596 "vkUpdateDescriptorSets(): if pDescriptorWrites[%d].descriptorType is "
2597 "VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER or VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER, "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002598 "pDescriptorWrites[%d].pTexelBufferView must not be NULL.",
2599 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002600 } else {
2601 for (uint32_t descriptor_index = 0; descriptor_index < pDescriptorWrites[i].descriptorCount;
2602 ++descriptor_index) {
2603 skip |= validate_required_handle(report_data, "vkUpdateDescriptorSets",
2604 ParameterName("pDescriptorWrites[%i].pTexelBufferView[%i]",
2605 ParameterName::IndexVector{i, descriptor_index}),
2606 pDescriptorWrites[i].pTexelBufferView[descriptor_index]);
2607 }
2608 }
2609 }
2610
2611 if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER) ||
2612 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC)) {
2613 VkDeviceSize uniformAlignment = device_data->device_limits.minUniformBufferOffsetAlignment;
2614 for (uint32_t j = 0; j < pDescriptorWrites[i].descriptorCount; j++) {
2615 if (pDescriptorWrites[i].pBufferInfo != NULL) {
2616 if (SafeModulo(pDescriptorWrites[i].pBufferInfo[j].offset, uniformAlignment) != 0) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06002617 skip |=
2618 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002619 VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0,
2620 "VUID-VkWriteDescriptorSet-descriptorType-00327",
Mark Lobodzinski88529492018-04-01 10:38:15 -06002621 "vkUpdateDescriptorSets(): pDescriptorWrites[%d].pBufferInfo[%d].offset (0x%" PRIxLEAST64
2622 ") must be a multiple of device limit minUniformBufferOffsetAlignment 0x%" PRIxLEAST64 ".",
2623 i, j, pDescriptorWrites[i].pBufferInfo[j].offset, uniformAlignment);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002624 }
2625 }
2626 }
2627 } else if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER) ||
2628 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC)) {
2629 VkDeviceSize storageAlignment = device_data->device_limits.minStorageBufferOffsetAlignment;
2630 for (uint32_t j = 0; j < pDescriptorWrites[i].descriptorCount; j++) {
2631 if (pDescriptorWrites[i].pBufferInfo != NULL) {
2632 if (SafeModulo(pDescriptorWrites[i].pBufferInfo[j].offset, storageAlignment) != 0) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06002633 skip |=
2634 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002635 VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0,
2636 "VUID-VkWriteDescriptorSet-descriptorType-00328",
Mark Lobodzinski88529492018-04-01 10:38:15 -06002637 "vkUpdateDescriptorSets(): pDescriptorWrites[%d].pBufferInfo[%d].offset (0x%" PRIxLEAST64
2638 ") must be a multiple of device limit minStorageBufferOffsetAlignment 0x%" PRIxLEAST64 ".",
2639 i, j, pDescriptorWrites[i].pBufferInfo[j].offset, storageAlignment);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002640 }
2641 }
2642 }
2643 }
2644 }
2645 }
2646 return skip;
2647}
2648
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002649bool pv_vkCreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
2650 VkRenderPass *pRenderPass) {
2651 bool skip = false;
2652 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2653 uint32_t max_color_attachments = device_data->device_limits.maxColorAttachments;
2654
2655 for (uint32_t i = 0; i < pCreateInfo->attachmentCount; ++i) {
2656 if (pCreateInfo->pAttachments[i].format == VK_FORMAT_UNDEFINED) {
2657 std::stringstream ss;
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002658 ss << "vkCreateRenderPass: pCreateInfo->pAttachments[" << i << "].format is VK_FORMAT_UNDEFINED. ";
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002659 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002660 "VUID-VkAttachmentDescription-format-parameter", "%s", ss.str().c_str());
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002661 }
2662 if (pCreateInfo->pAttachments[i].finalLayout == VK_IMAGE_LAYOUT_UNDEFINED ||
2663 pCreateInfo->pAttachments[i].finalLayout == VK_IMAGE_LAYOUT_PREINITIALIZED) {
2664 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002665 "VUID-VkAttachmentDescription-finalLayout-00843",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002666 "pCreateInfo->pAttachments[%d].finalLayout must not be VK_IMAGE_LAYOUT_UNDEFINED or "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002667 "VK_IMAGE_LAYOUT_PREINITIALIZED.",
2668 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002669 }
2670 }
2671
2672 for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) {
2673 if (pCreateInfo->pSubpasses[i].colorAttachmentCount > max_color_attachments) {
2674 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002675 "VUID-VkSubpassDescription-colorAttachmentCount-00845",
2676 "Cannot create a render pass with %d color attachments. Max is %d.",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002677 pCreateInfo->pSubpasses[i].colorAttachmentCount, max_color_attachments);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002678 }
2679 }
2680 return skip;
2681}
2682
2683bool pv_vkFreeCommandBuffers(VkDevice device, VkCommandPool commandPool, uint32_t commandBufferCount,
2684 const VkCommandBuffer *pCommandBuffers) {
2685 bool skip = false;
2686 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2687 debug_report_data *report_data = device_data->report_data;
2688
2689 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
2690 // This is an array of handles, where the elements are allowed to be VK_NULL_HANDLE, and does not require any validation beyond
2691 // validate_array()
2692 skip |= validate_array(report_data, "vkFreeCommandBuffers", "commandBufferCount", "pCommandBuffers", commandBufferCount,
Dave Houlton413a6782018-05-22 13:01:54 -06002693 &pCommandBuffers, true, true, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002694 return skip;
2695}
2696
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002697bool pv_vkBeginCommandBuffer(VkCommandBuffer commandBuffer, const VkCommandBufferBeginInfo *pBeginInfo) {
2698 bool skip = false;
2699 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2700 debug_report_data *report_data = device_data->report_data;
2701 const VkCommandBufferInheritanceInfo *pInfo = pBeginInfo->pInheritanceInfo;
2702
2703 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
2704 // TODO: pBeginInfo->pInheritanceInfo must not be NULL if commandBuffer is a secondary command buffer
2705 skip |= validate_struct_type(report_data, "vkBeginCommandBuffer", "pBeginInfo->pInheritanceInfo",
2706 "VK_STRUCTURE_TYPE_COMMAND_BUFFER_INHERITANCE_INFO", pBeginInfo->pInheritanceInfo,
Mark Lobodzinskia16ebc72018-06-15 14:47:39 -06002707 VK_STRUCTURE_TYPE_COMMAND_BUFFER_INHERITANCE_INFO, false,
2708 "VUID_vkBeginCommandBuffer-pBeginInfo-parameter", "VUID_VkCommandBufferBeginInfo-sType-sType");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002709
2710 if (pBeginInfo->pInheritanceInfo != NULL) {
Dave Houlton413a6782018-05-22 13:01:54 -06002711 skip |= validate_struct_pnext(report_data, "vkBeginCommandBuffer", "pBeginInfo->pInheritanceInfo->pNext", NULL,
2712 pBeginInfo->pInheritanceInfo->pNext, 0, NULL, GeneratedHeaderVersion,
2713 "VUID-VkCommandBufferBeginInfo-pNext-pNext");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002714
2715 skip |= validate_bool32(report_data, "vkBeginCommandBuffer", "pBeginInfo->pInheritanceInfo->occlusionQueryEnable",
2716 pBeginInfo->pInheritanceInfo->occlusionQueryEnable);
2717
2718 // TODO: This only needs to be validated when the inherited queries feature is enabled
2719 // skip |= validate_flags(report_data, "vkBeginCommandBuffer", "pBeginInfo->pInheritanceInfo->queryFlags",
2720 // "VkQueryControlFlagBits", AllVkQueryControlFlagBits, pBeginInfo->pInheritanceInfo->queryFlags, false);
2721
2722 // TODO: This must be 0 if the pipeline statistics queries feature is not enabled
2723 skip |= validate_flags(report_data, "vkBeginCommandBuffer", "pBeginInfo->pInheritanceInfo->pipelineStatistics",
2724 "VkQueryPipelineStatisticFlagBits", AllVkQueryPipelineStatisticFlagBits,
Dave Houlton413a6782018-05-22 13:01:54 -06002725 pBeginInfo->pInheritanceInfo->pipelineStatistics, false, false, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002726 }
2727
2728 if (pInfo != NULL) {
2729 if ((device_data->physical_device_features.inheritedQueries == VK_FALSE) && (pInfo->occlusionQueryEnable != VK_FALSE)) {
2730 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002731 HandleToUint64(commandBuffer), "VUID-VkCommandBufferInheritanceInfo-occlusionQueryEnable-00056",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002732 "Cannot set inherited occlusionQueryEnable in vkBeginCommandBuffer() when device does not support "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002733 "inheritedQueries.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002734 }
2735 if ((device_data->physical_device_features.inheritedQueries != VK_FALSE) && (pInfo->occlusionQueryEnable != VK_FALSE)) {
2736 skip |= validate_flags(device_data->report_data, "vkBeginCommandBuffer", "pBeginInfo->pInheritanceInfo->queryFlags",
2737 "VkQueryControlFlagBits", AllVkQueryControlFlagBits, pInfo->queryFlags, false, false,
Dave Houlton413a6782018-05-22 13:01:54 -06002738 "VUID-VkCommandBufferInheritanceInfo-queryFlags-00057");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002739 }
2740 }
2741
2742 return skip;
2743}
2744
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002745bool pv_vkCmdSetViewport(VkCommandBuffer commandBuffer, uint32_t firstViewport, uint32_t viewportCount,
2746 const VkViewport *pViewports) {
2747 bool skip = false;
2748 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2749
Petr Krausd55e77c2018-01-09 22:09:25 +01002750 if (!device_data->physical_device_features.multiViewport) {
2751 if (firstViewport != 0) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002752 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002753 HandleToUint64(commandBuffer), "VUID-vkCmdSetViewport-firstViewport-01224",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002754 "vkCmdSetViewport: The multiViewport feature is disabled, but firstViewport (=%" PRIu32 ") is not 0.",
2755 firstViewport);
Petr Krausd55e77c2018-01-09 22:09:25 +01002756 }
2757 if (viewportCount > 1) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002758 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002759 HandleToUint64(commandBuffer), "VUID-vkCmdSetViewport-viewportCount-01225",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002760 "vkCmdSetViewport: The multiViewport feature is disabled, but viewportCount (=%" PRIu32 ") is not 1.",
2761 viewportCount);
Petr Krausd55e77c2018-01-09 22:09:25 +01002762 }
2763 } else { // multiViewport enabled
Petr Kraus7dfeed12018-02-27 20:51:20 +01002764 const uint64_t sum = static_cast<uint64_t>(firstViewport) + static_cast<uint64_t>(viewportCount);
Petr Krausd55e77c2018-01-09 22:09:25 +01002765 if (sum > device_data->device_limits.maxViewports) {
2766 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002767 HandleToUint64(commandBuffer), "VUID-vkCmdSetViewport-firstViewport-01223",
Petr Krausd55e77c2018-01-09 22:09:25 +01002768 "vkCmdSetViewport: firstViewport + viewportCount (=%" PRIu32 " + %" PRIu32 " = %" PRIu64
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002769 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
2770 firstViewport, viewportCount, sum, device_data->device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002771 }
2772 }
Petr Krausb3fcdb42018-01-09 22:09:09 +01002773
2774 if (pViewports) {
2775 for (uint32_t viewport_i = 0; viewport_i < viewportCount; ++viewport_i) {
2776 const auto &viewport = pViewports[viewport_i]; // will crash on invalid ptr
2777 const char fn_name[] = "vkCmdSetViewport";
2778 const std::string param_name = "pViewports[" + std::to_string(viewport_i) + "]";
2779 skip |= pv_VkViewport(device_data, viewport, fn_name, param_name.c_str(),
2780 VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, HandleToUint64(commandBuffer));
2781 }
2782 }
2783
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002784 return skip;
2785}
2786
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002787bool pv_vkCmdSetScissor(VkCommandBuffer commandBuffer, uint32_t firstScissor, uint32_t scissorCount, const VkRect2D *pScissors) {
2788 bool skip = false;
2789 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2790 debug_report_data *report_data = device_data->report_data;
2791
Petr Kraus6260f0a2018-02-27 21:15:55 +01002792 if (!device_data->physical_device_features.multiViewport) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002793 if (firstScissor != 0) {
Petr Kraus6260f0a2018-02-27 21:15:55 +01002794 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002795 HandleToUint64(commandBuffer), "VUID-vkCmdSetScissor-firstScissor-00593",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002796 "vkCmdSetScissor: The multiViewport feature is disabled, but firstScissor (=%" PRIu32 ") is not 0.",
2797 firstScissor);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002798 }
2799 if (scissorCount > 1) {
2800 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002801 HandleToUint64(commandBuffer), "VUID-vkCmdSetScissor-scissorCount-00594",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002802 "vkCmdSetScissor: The multiViewport feature is disabled, but scissorCount (=%" PRIu32 ") is not 1.",
2803 scissorCount);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002804 }
2805 } else { // multiViewport enabled
2806 const uint64_t sum = static_cast<uint64_t>(firstScissor) + static_cast<uint64_t>(scissorCount);
2807 if (sum > device_data->device_limits.maxViewports) {
2808 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002809 HandleToUint64(commandBuffer), "VUID-vkCmdSetScissor-firstScissor-00592",
Petr Kraus6260f0a2018-02-27 21:15:55 +01002810 "vkCmdSetScissor: firstScissor + scissorCount (=%" PRIu32 " + %" PRIu32 " = %" PRIu64
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002811 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
2812 firstScissor, scissorCount, sum, device_data->device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002813 }
2814 }
2815
Petr Kraus6260f0a2018-02-27 21:15:55 +01002816 if (pScissors) {
2817 for (uint32_t scissor_i = 0; scissor_i < scissorCount; ++scissor_i) {
2818 const auto &scissor = pScissors[scissor_i]; // will crash on invalid ptr
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002819
Petr Kraus6260f0a2018-02-27 21:15:55 +01002820 if (scissor.offset.x < 0) {
2821 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002822 HandleToUint64(commandBuffer), "VUID-vkCmdSetScissor-x-00595",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002823 "vkCmdSetScissor: pScissors[%" PRIu32 "].offset.x (=%" PRIi32 ") is negative.", scissor_i,
2824 scissor.offset.x);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002825 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002826
Petr Kraus6260f0a2018-02-27 21:15:55 +01002827 if (scissor.offset.y < 0) {
2828 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002829 HandleToUint64(commandBuffer), "VUID-vkCmdSetScissor-x-00595",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002830 "vkCmdSetScissor: pScissors[%" PRIu32 "].offset.y (=%" PRIi32 ") is negative.", scissor_i,
2831 scissor.offset.y);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002832 }
2833
2834 const int64_t x_sum = static_cast<int64_t>(scissor.offset.x) + static_cast<int64_t>(scissor.extent.width);
2835 if (x_sum > INT32_MAX) {
2836 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002837 HandleToUint64(commandBuffer), "VUID-vkCmdSetScissor-offset-00596",
Petr Kraus6260f0a2018-02-27 21:15:55 +01002838 "vkCmdSetScissor: offset.x + extent.width (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002839 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
2840 scissor.offset.x, scissor.extent.width, x_sum, scissor_i);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002841 }
2842
2843 const int64_t y_sum = static_cast<int64_t>(scissor.offset.y) + static_cast<int64_t>(scissor.extent.height);
2844 if (y_sum > INT32_MAX) {
2845 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002846 HandleToUint64(commandBuffer), "VUID-vkCmdSetScissor-offset-00597",
Petr Kraus6260f0a2018-02-27 21:15:55 +01002847 "vkCmdSetScissor: offset.y + extent.height (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002848 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
2849 scissor.offset.y, scissor.extent.height, y_sum, scissor_i);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002850 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002851 }
2852 }
Petr Kraus6260f0a2018-02-27 21:15:55 +01002853
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002854 return skip;
2855}
2856
Petr Kraus299ba622017-11-24 03:09:03 +01002857bool pv_vkCmdSetLineWidth(VkCommandBuffer commandBuffer, float lineWidth) {
2858 bool skip = false;
2859 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2860 debug_report_data *report_data = device_data->report_data;
2861
2862 if (!device_data->physical_device_features.wideLines && (lineWidth != 1.0f)) {
2863 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002864 HandleToUint64(commandBuffer), "VUID-vkCmdSetLineWidth-lineWidth-00788",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002865 "VkPhysicalDeviceFeatures::wideLines is disabled, but lineWidth (=%f) is not 1.0.", lineWidth);
Petr Kraus299ba622017-11-24 03:09:03 +01002866 }
2867
2868 return skip;
2869}
2870
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002871bool pv_vkCmdDraw(VkCommandBuffer commandBuffer, uint32_t vertexCount, uint32_t instanceCount, uint32_t firstVertex,
2872 uint32_t firstInstance) {
2873 bool skip = false;
2874 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2875 if (vertexCount == 0) {
2876 // TODO: Verify against Valid Usage section. I don't see a non-zero vertexCount listed, may need to add that and make
2877 // this an error or leave as is.
2878 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002879 kVUID_PVError_RequiredParameter, "vkCmdDraw parameter, uint32_t vertexCount, is 0");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002880 }
2881
2882 if (instanceCount == 0) {
2883 // TODO: Verify against Valid Usage section. I don't see a non-zero instanceCount listed, may need to add that and make
2884 // this an error or leave as is.
2885 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002886 kVUID_PVError_RequiredParameter, "vkCmdDraw parameter, uint32_t instanceCount, is 0");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002887 }
2888 return skip;
2889}
2890
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002891bool pv_vkCmdDrawIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, uint32_t count, uint32_t stride) {
2892 bool skip = false;
2893 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2894
2895 if (!device_data->physical_device_features.multiDrawIndirect && ((count > 1))) {
2896 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002897 kVUID_PVError_DeviceFeature,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002898 "CmdDrawIndirect(): Device feature multiDrawIndirect disabled: count must be 0 or 1 but is %d", count);
2899 }
2900 return skip;
2901}
2902
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002903bool pv_vkCmdDrawIndexedIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, uint32_t count,
2904 uint32_t stride) {
2905 bool skip = false;
2906 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2907 if (!device_data->physical_device_features.multiDrawIndirect && ((count > 1))) {
Dave Houlton413a6782018-05-22 13:01:54 -06002908 skip |=
2909 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
2910 kVUID_PVError_DeviceFeature,
2911 "CmdDrawIndexedIndirect(): Device feature multiDrawIndirect disabled: count must be 0 or 1 but is %d", count);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002912 }
2913 return skip;
2914}
2915
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002916bool pv_vkCmdCopyImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkImage dstImage,
2917 VkImageLayout dstImageLayout, uint32_t regionCount, const VkImageCopy *pRegions) {
2918 bool skip = false;
2919 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2920
Dave Houltonf5217612018-02-02 16:18:52 -07002921 VkImageAspectFlags legal_aspect_flags =
2922 VK_IMAGE_ASPECT_COLOR_BIT | VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT | VK_IMAGE_ASPECT_METADATA_BIT;
2923 if (device_data->extensions.vk_khr_sampler_ycbcr_conversion) {
2924 legal_aspect_flags |= (VK_IMAGE_ASPECT_PLANE_0_BIT_KHR | VK_IMAGE_ASPECT_PLANE_1_BIT_KHR | VK_IMAGE_ASPECT_PLANE_2_BIT_KHR);
2925 }
2926
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002927 if (pRegions != nullptr) {
Dave Houltonf5217612018-02-02 16:18:52 -07002928 if ((pRegions->srcSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002929 skip |= log_msg(
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002930 device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002931 "VUID-VkImageSubresourceLayers-aspectMask-parameter",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002932 "vkCmdCopyImage() parameter, VkImageAspect pRegions->srcSubresource.aspectMask, is an unrecognized enumerator.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002933 }
Dave Houltonf5217612018-02-02 16:18:52 -07002934 if ((pRegions->dstSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002935 skip |= log_msg(
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002936 device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002937 "VUID-VkImageSubresourceLayers-aspectMask-parameter",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002938 "vkCmdCopyImage() parameter, VkImageAspect pRegions->dstSubresource.aspectMask, is an unrecognized enumerator.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002939 }
2940 }
2941 return skip;
2942}
2943
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002944bool pv_vkCmdBlitImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkImage dstImage,
2945 VkImageLayout dstImageLayout, uint32_t regionCount, const VkImageBlit *pRegions, VkFilter filter) {
2946 bool skip = false;
2947 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2948
Dave Houltonf5217612018-02-02 16:18:52 -07002949 VkImageAspectFlags legal_aspect_flags =
2950 VK_IMAGE_ASPECT_COLOR_BIT | VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT | VK_IMAGE_ASPECT_METADATA_BIT;
2951 if (device_data->extensions.vk_khr_sampler_ycbcr_conversion) {
2952 legal_aspect_flags |= (VK_IMAGE_ASPECT_PLANE_0_BIT_KHR | VK_IMAGE_ASPECT_PLANE_1_BIT_KHR | VK_IMAGE_ASPECT_PLANE_2_BIT_KHR);
2953 }
2954
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002955 if (pRegions != nullptr) {
Dave Houltonf5217612018-02-02 16:18:52 -07002956 if ((pRegions->srcSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002957 skip |= log_msg(
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002958 device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002959 kVUID_PVError_UnrecognizedValue,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002960 "vkCmdBlitImage() parameter, VkImageAspect pRegions->srcSubresource.aspectMask, is an unrecognized enumerator");
2961 }
Dave Houltonf5217612018-02-02 16:18:52 -07002962 if ((pRegions->dstSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002963 skip |= log_msg(
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002964 device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002965 kVUID_PVError_UnrecognizedValue,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002966 "vkCmdBlitImage() parameter, VkImageAspect pRegions->dstSubresource.aspectMask, is an unrecognized enumerator");
2967 }
2968 }
2969 return skip;
2970}
2971
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002972bool pv_vkCmdCopyBufferToImage(VkCommandBuffer commandBuffer, VkBuffer srcBuffer, VkImage dstImage, VkImageLayout dstImageLayout,
2973 uint32_t regionCount, const VkBufferImageCopy *pRegions) {
2974 bool skip = false;
2975 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2976
Dave Houltonf5217612018-02-02 16:18:52 -07002977 VkImageAspectFlags legal_aspect_flags =
2978 VK_IMAGE_ASPECT_COLOR_BIT | VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT | VK_IMAGE_ASPECT_METADATA_BIT;
2979 if (device_data->extensions.vk_khr_sampler_ycbcr_conversion) {
2980 legal_aspect_flags |= (VK_IMAGE_ASPECT_PLANE_0_BIT_KHR | VK_IMAGE_ASPECT_PLANE_1_BIT_KHR | VK_IMAGE_ASPECT_PLANE_2_BIT_KHR);
2981 }
2982
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002983 if (pRegions != nullptr) {
Dave Houltonf5217612018-02-02 16:18:52 -07002984 if ((pRegions->imageSubresource.aspectMask & legal_aspect_flags) == 0) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07002985 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002986 kVUID_PVError_UnrecognizedValue,
Dave Houltona9df0ce2018-02-07 10:51:23 -07002987 "vkCmdCopyBufferToImage() parameter, VkImageAspect pRegions->imageSubresource.aspectMask, is an "
2988 "unrecognized enumerator");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002989 }
2990 }
2991 return skip;
2992}
2993
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002994bool pv_vkCmdCopyImageToBuffer(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkBuffer dstBuffer,
2995 uint32_t regionCount, const VkBufferImageCopy *pRegions) {
2996 bool skip = false;
2997 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2998
Dave Houltonf5217612018-02-02 16:18:52 -07002999 VkImageAspectFlags legal_aspect_flags =
3000 VK_IMAGE_ASPECT_COLOR_BIT | VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT | VK_IMAGE_ASPECT_METADATA_BIT;
3001 if (device_data->extensions.vk_khr_sampler_ycbcr_conversion) {
3002 legal_aspect_flags |= (VK_IMAGE_ASPECT_PLANE_0_BIT_KHR | VK_IMAGE_ASPECT_PLANE_1_BIT_KHR | VK_IMAGE_ASPECT_PLANE_2_BIT_KHR);
3003 }
3004
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003005 if (pRegions != nullptr) {
Dave Houltonf5217612018-02-02 16:18:52 -07003006 if ((pRegions->imageSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06003007 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003008 kVUID_PVError_UnrecognizedValue,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003009 "vkCmdCopyImageToBuffer parameter, VkImageAspect pRegions->imageSubresource.aspectMask, is an unrecognized "
3010 "enumerator");
3011 }
3012 }
3013 return skip;
3014}
3015
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003016bool pv_vkCmdUpdateBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer, VkDeviceSize dstOffset, VkDeviceSize dataSize,
3017 const void *pData) {
3018 bool skip = false;
3019 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3020
3021 if (dstOffset & 3) {
3022 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003023 "VUID-vkCmdUpdateBuffer-dstOffset-00036",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003024 "vkCmdUpdateBuffer() parameter, VkDeviceSize dstOffset (0x%" PRIxLEAST64 "), is not a multiple of 4.",
3025 dstOffset);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003026 }
3027
3028 if ((dataSize <= 0) || (dataSize > 65536)) {
3029 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003030 "VUID-vkCmdUpdateBuffer-dataSize-00037",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003031 "vkCmdUpdateBuffer() parameter, VkDeviceSize dataSize (0x%" PRIxLEAST64
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003032 "), must be greater than zero and less than or equal to 65536.",
3033 dataSize);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003034 } else if (dataSize & 3) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003035 skip |=
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06003036 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003037 "VUID-vkCmdUpdateBuffer-dataSize-00038",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003038 "vkCmdUpdateBuffer() parameter, VkDeviceSize dataSize (0x%" PRIxLEAST64 "), is not a multiple of 4.", dataSize);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003039 }
3040 return skip;
3041}
3042
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003043bool pv_vkCmdFillBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer, VkDeviceSize dstOffset, VkDeviceSize size,
3044 uint32_t data) {
3045 bool skip = false;
3046 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3047
3048 if (dstOffset & 3) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003049 skip |=
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06003050 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003051 "VUID-vkCmdFillBuffer-dstOffset-00025",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003052 "vkCmdFillBuffer() parameter, VkDeviceSize dstOffset (0x%" PRIxLEAST64 "), is not a multiple of 4.", dstOffset);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003053 }
3054
3055 if (size != VK_WHOLE_SIZE) {
3056 if (size <= 0) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003057 skip |=
3058 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003059 "VUID-vkCmdFillBuffer-size-00026",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003060 "vkCmdFillBuffer() parameter, VkDeviceSize size (0x%" PRIxLEAST64 "), must be greater than zero.", size);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003061 } else if (size & 3) {
3062 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003063 "VUID-vkCmdFillBuffer-size-00028",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003064 "vkCmdFillBuffer() parameter, VkDeviceSize size (0x%" PRIxLEAST64 "), is not a multiple of 4.", size);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003065 }
3066 }
3067 return skip;
3068}
3069
3070VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateInstanceLayerProperties(uint32_t *pCount, VkLayerProperties *pProperties) {
3071 return util_GetLayerProperties(1, &global_layer, pCount, pProperties);
3072}
3073
3074VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateDeviceLayerProperties(VkPhysicalDevice physicalDevice, uint32_t *pCount,
3075 VkLayerProperties *pProperties) {
3076 return util_GetLayerProperties(1, &global_layer, pCount, pProperties);
3077}
3078
3079VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateInstanceExtensionProperties(const char *pLayerName, uint32_t *pCount,
3080 VkExtensionProperties *pProperties) {
3081 if (pLayerName && !strcmp(pLayerName, global_layer.layerName))
3082 return util_GetExtensionProperties(1, instance_extensions, pCount, pProperties);
3083
3084 return VK_ERROR_LAYER_NOT_PRESENT;
3085}
3086
3087VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateDeviceExtensionProperties(VkPhysicalDevice physicalDevice, const char *pLayerName,
3088 uint32_t *pPropertyCount, VkExtensionProperties *pProperties) {
3089 // Parameter_validation does not have any physical device extensions
3090 if (pLayerName && !strcmp(pLayerName, global_layer.layerName))
3091 return util_GetExtensionProperties(0, NULL, pPropertyCount, pProperties);
3092
3093 instance_layer_data *local_data = GetLayerDataPtr(get_dispatch_key(physicalDevice), instance_layer_data_map);
Dave Houlton413a6782018-05-22 13:01:54 -06003094 bool skip = validate_array(local_data->report_data, "vkEnumerateDeviceExtensionProperties", "pPropertyCount", "pProperties",
3095 pPropertyCount, &pProperties, true, false, false, kVUIDUndefined,
3096 "VUID-vkEnumerateDeviceExtensionProperties-pProperties-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003097 if (skip) return VK_ERROR_VALIDATION_FAILED_EXT;
3098
3099 return local_data->dispatch_table.EnumerateDeviceExtensionProperties(physicalDevice, NULL, pPropertyCount, pProperties);
3100}
3101
3102static bool require_device_extension(layer_data *device_data, bool flag, char const *function_name, char const *extension_name) {
3103 if (!flag) {
3104 return log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003105 kVUID_PVError_ExtensionNotEnabled,
3106 "%s() called even though the %s extension was not enabled for this VkDevice.", function_name,
3107 extension_name);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003108 }
3109
3110 return false;
3111}
3112
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003113bool pv_vkCreateSwapchainKHR(VkDevice device, const VkSwapchainCreateInfoKHR *pCreateInfo, const VkAllocationCallbacks *pAllocator,
3114 VkSwapchainKHR *pSwapchain) {
3115 bool skip = false;
3116 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
3117 debug_report_data *report_data = device_data->report_data;
3118
Mark Lobodzinski88529492018-04-01 10:38:15 -06003119 const LogMiscParams log_misc{report_data, VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT, VK_NULL_HANDLE,
Petr Krause5c37652018-01-05 04:05:12 +01003120 "vkCreateSwapchainKHR"};
3121
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003122 if (pCreateInfo != nullptr) {
3123 if ((device_data->physical_device_features.textureCompressionETC2 == false) &&
3124 FormatIsCompressed_ETC2_EAC(pCreateInfo->imageFormat)) {
Dave Houlton413a6782018-05-22 13:01:54 -06003125 skip |= log_msg(
3126 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, kVUID_PVError_DeviceFeature,
3127 "vkCreateSwapchainKHR(): Attempting to create swapchain VkImage with format %s. The textureCompressionETC2 "
3128 "feature is not enabled: neither ETC2 nor EAC formats can be used to create images.",
3129 string_VkFormat(pCreateInfo->imageFormat));
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003130 }
3131
3132 if ((device_data->physical_device_features.textureCompressionASTC_LDR == false) &&
3133 FormatIsCompressed_ASTC_LDR(pCreateInfo->imageFormat)) {
Dave Houlton413a6782018-05-22 13:01:54 -06003134 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
3135 kVUID_PVError_DeviceFeature,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003136 "vkCreateSwapchainKHR(): Attempting to create swapchain VkImage with format %s. The "
3137 "textureCompressionASTC_LDR feature is not enabled: ASTC formats cannot be used to create images.",
3138 string_VkFormat(pCreateInfo->imageFormat));
3139 }
3140
3141 if ((device_data->physical_device_features.textureCompressionBC == false) &&
3142 FormatIsCompressed_BC(pCreateInfo->imageFormat)) {
Dave Houlton413a6782018-05-22 13:01:54 -06003143 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
3144 kVUID_PVError_DeviceFeature,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003145 "vkCreateSwapchainKHR(): Attempting to create swapchain VkImage with format %s. The "
3146 "textureCompressionBC feature is not enabled: BC compressed formats cannot be used to create images.",
3147 string_VkFormat(pCreateInfo->imageFormat));
3148 }
3149
3150 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
3151 if (pCreateInfo->imageSharingMode == VK_SHARING_MODE_CONCURRENT) {
3152 // If imageSharingMode is VK_SHARING_MODE_CONCURRENT, queueFamilyIndexCount must be greater than 1
3153 if (pCreateInfo->queueFamilyIndexCount <= 1) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06003154 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003155 "VUID-VkSwapchainCreateInfoKHR-imageSharingMode-01278",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003156 "vkCreateSwapchainKHR(): if pCreateInfo->imageSharingMode is VK_SHARING_MODE_CONCURRENT, "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003157 "pCreateInfo->queueFamilyIndexCount must be greater than 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003158 }
3159
3160 // If imageSharingMode is VK_SHARING_MODE_CONCURRENT, pQueueFamilyIndices must be a pointer to an array of
3161 // queueFamilyIndexCount uint32_t values
3162 if (pCreateInfo->pQueueFamilyIndices == nullptr) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06003163 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003164 "VUID-VkSwapchainCreateInfoKHR-imageSharingMode-01277",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003165 "vkCreateSwapchainKHR(): if pCreateInfo->imageSharingMode is VK_SHARING_MODE_CONCURRENT, "
3166 "pCreateInfo->pQueueFamilyIndices must be a pointer to an array of "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003167 "pCreateInfo->queueFamilyIndexCount uint32_t values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003168 } else {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003169 skip |= ValidateQueueFamilies(device_data, pCreateInfo->queueFamilyIndexCount, pCreateInfo->pQueueFamilyIndices,
Dave Houlton413a6782018-05-22 13:01:54 -06003170 "vkCreateSwapchainKHR", "pCreateInfo->pQueueFamilyIndices",
3171 kVUID_PVError_InvalidUsage, kVUID_PVError_InvalidUsage, false);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003172 }
3173 }
3174
Dave Houlton413a6782018-05-22 13:01:54 -06003175 skip |= ValidateGreaterThanZero(pCreateInfo->imageArrayLayers, "pCreateInfo->imageArrayLayers",
3176 "VUID-VkSwapchainCreateInfoKHR-imageArrayLayers-01275", log_misc);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003177 }
3178
3179 return skip;
3180}
3181
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003182bool pv_vkQueuePresentKHR(VkQueue queue, const VkPresentInfoKHR *pPresentInfo) {
3183 bool skip = false;
3184 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(queue), layer_data_map);
3185
3186 if (pPresentInfo && pPresentInfo->pNext) {
John Zulaufde972ac2017-10-26 12:07:05 -06003187 const auto *present_regions = lvl_find_in_chain<VkPresentRegionsKHR>(pPresentInfo->pNext);
3188 if (present_regions) {
3189 // TODO: This and all other pNext extension dependencies should be added to code-generation
3190 skip |= require_device_extension(device_data, device_data->extensions.vk_khr_incremental_present, "vkQueuePresentKHR",
3191 VK_KHR_INCREMENTAL_PRESENT_EXTENSION_NAME);
3192 if (present_regions->swapchainCount != pPresentInfo->swapchainCount) {
3193 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003194 kVUID_PVError_InvalidUsage,
Dave Houltona9df0ce2018-02-07 10:51:23 -07003195 "QueuePresentKHR(): pPresentInfo->swapchainCount has a value of %i but VkPresentRegionsKHR "
3196 "extension swapchainCount is %i. These values must be equal.",
John Zulaufde972ac2017-10-26 12:07:05 -06003197 pPresentInfo->swapchainCount, present_regions->swapchainCount);
3198 }
Dave Houlton413a6782018-05-22 13:01:54 -06003199 skip |=
3200 validate_struct_pnext(device_data->report_data, "QueuePresentKHR", "pCreateInfo->pNext->pNext", NULL,
3201 present_regions->pNext, 0, NULL, GeneratedHeaderVersion, "VUID-VkPresentInfoKHR-pNext-pNext");
John Zulaufde972ac2017-10-26 12:07:05 -06003202 skip |= validate_array(device_data->report_data, "QueuePresentKHR", "pCreateInfo->pNext->swapchainCount",
Gabríel Arthúr Pétursson092b29b2018-03-21 22:44:11 +00003203 "pCreateInfo->pNext->pRegions", present_regions->swapchainCount, &present_regions->pRegions,
Dave Houlton413a6782018-05-22 13:01:54 -06003204 true, false, kVUIDUndefined, kVUIDUndefined);
John Zulaufde972ac2017-10-26 12:07:05 -06003205 for (uint32_t i = 0; i < present_regions->swapchainCount; ++i) {
3206 skip |= validate_array(device_data->report_data, "QueuePresentKHR", "pCreateInfo->pNext->pRegions[].rectangleCount",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003207 "pCreateInfo->pNext->pRegions[].pRectangles", present_regions->pRegions[i].rectangleCount,
Dave Houlton413a6782018-05-22 13:01:54 -06003208 &present_regions->pRegions[i].pRectangles, true, false, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003209 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003210 }
3211 }
3212
3213 return skip;
3214}
3215
3216#ifdef VK_USE_PLATFORM_WIN32_KHR
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003217bool pv_vkCreateWin32SurfaceKHR(VkInstance instance, const VkWin32SurfaceCreateInfoKHR *pCreateInfo,
3218 const VkAllocationCallbacks *pAllocator, VkSurfaceKHR *pSurface) {
3219 auto device_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map);
3220 bool skip = false;
3221
3222 if (pCreateInfo->hwnd == nullptr) {
3223 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003224 "VUID-VkWin32SurfaceCreateInfoKHR-hwnd-01308",
3225 "vkCreateWin32SurfaceKHR(): hwnd must be a valid Win32 HWND but hwnd is NULL.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003226 }
3227
3228 return skip;
3229}
3230#endif // VK_USE_PLATFORM_WIN32_KHR
3231
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003232bool pv_vkDebugMarkerSetObjectNameEXT(VkDevice device, const VkDebugMarkerObjectNameInfoEXT *pNameInfo) {
3233 auto device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
3234 if (pNameInfo->pObjectName) {
3235 device_data->report_data->debugObjectNameMap->insert(
3236 std::make_pair<uint64_t, std::string>((uint64_t &&) pNameInfo->object, pNameInfo->pObjectName));
3237 } else {
3238 device_data->report_data->debugObjectNameMap->erase(pNameInfo->object);
3239 }
3240 return false;
3241}
3242
Petr Krausc8655be2017-09-27 18:56:51 +02003243bool pv_vkCreateDescriptorPool(VkDevice device, const VkDescriptorPoolCreateInfo *pCreateInfo,
3244 const VkAllocationCallbacks *pAllocator, VkDescriptorPool *pDescriptorPool) {
3245 auto device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
3246 bool skip = false;
3247
3248 if (pCreateInfo) {
3249 if (pCreateInfo->maxSets <= 0) {
Dave Houlton413a6782018-05-22 13:01:54 -06003250 skip |=
3251 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT,
3252 VK_NULL_HANDLE, "VUID-VkDescriptorPoolCreateInfo-maxSets-00301",
3253 "vkCreateDescriptorPool(): pCreateInfo->maxSets is not greater than 0.");
Petr Krausc8655be2017-09-27 18:56:51 +02003254 }
3255
3256 if (pCreateInfo->pPoolSizes) {
3257 for (uint32_t i = 0; i < pCreateInfo->poolSizeCount; ++i) {
3258 if (pCreateInfo->pPoolSizes[i].descriptorCount <= 0) {
3259 skip |= log_msg(
3260 device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003261 VK_NULL_HANDLE, "VUID-VkDescriptorPoolSize-descriptorCount-00302",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003262 "vkCreateDescriptorPool(): pCreateInfo->pPoolSizes[%" PRIu32 "].descriptorCount is not greater than 0.", i);
Petr Krausc8655be2017-09-27 18:56:51 +02003263 }
Jeff Bolze54ae892018-09-08 12:16:29 -05003264 if (pCreateInfo->pPoolSizes[i].type == VK_DESCRIPTOR_TYPE_INLINE_UNIFORM_BLOCK_EXT &&
3265 (pCreateInfo->pPoolSizes[i].descriptorCount % 4) != 0) {
3266 skip |= log_msg(
3267 device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT,
3268 VK_NULL_HANDLE, "VUID-VkDescriptorPoolSize-type-02218",
3269 "vkCreateDescriptorPool(): pCreateInfo->pPoolSizes[%" PRIu32 "].type is VK_DESCRIPTOR_TYPE_INLINE_UNIFORM_BLOCK_EXT "
3270 " and pCreateInfo->pPoolSizes[%" PRIu32 "].descriptorCount is not a multiple of 4.", i, i);
3271 }
Petr Krausc8655be2017-09-27 18:56:51 +02003272 }
3273 }
3274 }
3275
3276 return skip;
3277}
3278
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003279bool pv_vkCmdDispatch(VkCommandBuffer commandBuffer, uint32_t groupCountX, uint32_t groupCountY, uint32_t groupCountZ) {
3280 bool skip = false;
3281 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3282
3283 if (groupCountX > device_data->device_limits.maxComputeWorkGroupCount[0]) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003284 skip |=
3285 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003286 HandleToUint64(commandBuffer), "VUID-vkCmdDispatch-groupCountX-00386",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003287 "vkCmdDispatch(): groupCountX (%" PRIu32 ") exceeds device limit maxComputeWorkGroupCount[0] (%" PRIu32 ").",
3288 groupCountX, device_data->device_limits.maxComputeWorkGroupCount[0]);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003289 }
3290
3291 if (groupCountY > device_data->device_limits.maxComputeWorkGroupCount[1]) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003292 skip |=
3293 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003294 HandleToUint64(commandBuffer), "VUID-vkCmdDispatch-groupCountY-00387",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003295 "vkCmdDispatch(): groupCountY (%" PRIu32 ") exceeds device limit maxComputeWorkGroupCount[1] (%" PRIu32 ").",
3296 groupCountY, device_data->device_limits.maxComputeWorkGroupCount[1]);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003297 }
3298
3299 if (groupCountZ > device_data->device_limits.maxComputeWorkGroupCount[2]) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003300 skip |=
3301 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003302 HandleToUint64(commandBuffer), "VUID-vkCmdDispatch-groupCountZ-00388",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003303 "vkCmdDispatch(): groupCountZ (%" PRIu32 ") exceeds device limit maxComputeWorkGroupCount[2] (%" PRIu32 ").",
3304 groupCountZ, device_data->device_limits.maxComputeWorkGroupCount[2]);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003305 }
3306
3307 return skip;
3308}
3309
Mark Lobodzinskibf973a12018-03-01 08:50:21 -07003310bool pv_vkCmdDispatchBaseKHR(VkCommandBuffer commandBuffer, uint32_t baseGroupX, uint32_t baseGroupY, uint32_t baseGroupZ,
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003311 uint32_t groupCountX, uint32_t groupCountY, uint32_t groupCountZ) {
3312 bool skip = false;
3313 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3314
3315 // Paired if {} else if {} tests used to avoid any possible uint underflow
3316 uint32_t limit = device_data->device_limits.maxComputeWorkGroupCount[0];
3317 if (baseGroupX >= limit) {
3318 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003319 HandleToUint64(commandBuffer), "VUID-vkCmdDispatchBase-baseGroupX-00421",
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003320 "vkCmdDispatch(): baseGroupX (%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003321 ") equals or exceeds device limit maxComputeWorkGroupCount[0] (%" PRIu32 ").",
3322 baseGroupX, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003323 } else if (groupCountX > (limit - baseGroupX)) {
3324 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003325 HandleToUint64(commandBuffer), "VUID-vkCmdDispatchBase-groupCountX-00424",
Mark Lobodzinskibf973a12018-03-01 08:50:21 -07003326 "vkCmdDispatchBaseKHR(): baseGroupX (%" PRIu32 ") + groupCountX (%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003327 ") exceeds device limit maxComputeWorkGroupCount[0] (%" PRIu32 ").",
3328 baseGroupX, groupCountX, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003329 }
3330
3331 limit = device_data->device_limits.maxComputeWorkGroupCount[1];
3332 if (baseGroupY >= limit) {
3333 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003334 HandleToUint64(commandBuffer), "VUID-vkCmdDispatchBase-baseGroupX-00422",
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003335 "vkCmdDispatch(): baseGroupY (%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003336 ") equals or exceeds device limit maxComputeWorkGroupCount[1] (%" PRIu32 ").",
3337 baseGroupY, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003338 } else if (groupCountY > (limit - baseGroupY)) {
3339 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003340 HandleToUint64(commandBuffer), "VUID-vkCmdDispatchBase-groupCountY-00425",
Mark Lobodzinskibf973a12018-03-01 08:50:21 -07003341 "vkCmdDispatchBaseKHR(): baseGroupY (%" PRIu32 ") + groupCountY (%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003342 ") exceeds device limit maxComputeWorkGroupCount[1] (%" PRIu32 ").",
3343 baseGroupY, groupCountY, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003344 }
3345
3346 limit = device_data->device_limits.maxComputeWorkGroupCount[2];
3347 if (baseGroupZ >= limit) {
3348 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003349 HandleToUint64(commandBuffer), "VUID-vkCmdDispatchBase-baseGroupZ-00423",
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003350 "vkCmdDispatch(): baseGroupZ (%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003351 ") equals or exceeds device limit maxComputeWorkGroupCount[2] (%" PRIu32 ").",
3352 baseGroupZ, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003353 } else if (groupCountZ > (limit - baseGroupZ)) {
3354 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003355 HandleToUint64(commandBuffer), "VUID-vkCmdDispatchBase-groupCountZ-00426",
Mark Lobodzinskibf973a12018-03-01 08:50:21 -07003356 "vkCmdDispatchBaseKHR(): baseGroupZ (%" PRIu32 ") + groupCountZ (%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003357 ") exceeds device limit maxComputeWorkGroupCount[2] (%" PRIu32 ").",
3358 baseGroupZ, groupCountZ, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003359 }
3360
3361 return skip;
3362}
3363
Jeff Bolz3e71f782018-08-29 23:15:45 -05003364bool pv_vkCmdSetExclusiveScissorNV(
3365 VkCommandBuffer commandBuffer,
3366 uint32_t firstExclusiveScissor,
3367 uint32_t exclusiveScissorCount,
3368 const VkRect2D* pExclusiveScissors)
3369{
3370 bool skip = false;
3371
3372 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3373 debug_report_data *report_data = device_data->report_data;
3374
3375 if (!device_data->physical_device_features.multiViewport) {
3376 if (firstExclusiveScissor != 0) {
3377 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3378 HandleToUint64(commandBuffer), "VUID-vkCmdSetExclusiveScissorNV-firstExclusiveScissor-02035",
3379 "vkCmdSetExclusiveScissorNV: The multiViewport feature is disabled, but firstExclusiveScissor (=%" PRIu32 ") is not 0.",
3380 firstExclusiveScissor);
3381 }
3382 if (exclusiveScissorCount > 1) {
3383 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3384 HandleToUint64(commandBuffer), "VUID-vkCmdSetExclusiveScissorNV-exclusiveScissorCount-02036",
3385 "vkCmdSetExclusiveScissorNV: The multiViewport feature is disabled, but exclusiveScissorCount (=%" PRIu32 ") is not 1.",
3386 exclusiveScissorCount);
3387 }
3388 } else { // multiViewport enabled
3389 const uint64_t sum = static_cast<uint64_t>(firstExclusiveScissor) + static_cast<uint64_t>(exclusiveScissorCount);
3390 if (sum > device_data->device_limits.maxViewports) {
3391 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3392 HandleToUint64(commandBuffer), "VUID-vkCmdSetExclusiveScissorNV-firstExclusiveScissor-02034",
3393 "vkCmdSetExclusiveScissorNV: firstExclusiveScissor + exclusiveScissorCount (=%" PRIu32 " + %" PRIu32 " = %" PRIu64
3394 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
3395 firstExclusiveScissor, exclusiveScissorCount, sum, device_data->device_limits.maxViewports);
3396 }
3397 }
3398
3399 if (firstExclusiveScissor >= device_data->device_limits.maxViewports) {
3400 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3401 HandleToUint64(commandBuffer), "VUID-vkCmdSetExclusiveScissorNV-firstExclusiveScissor-02033",
3402 "vkCmdSetExclusiveScissorNV: firstExclusiveScissor (=%" PRIu32 ") must be less than maxViewports (=%" PRIu32 ").",
3403 firstExclusiveScissor, device_data->device_limits.maxViewports);
3404 }
3405
3406 if (pExclusiveScissors) {
3407 for (uint32_t scissor_i = 0; scissor_i < exclusiveScissorCount; ++scissor_i) {
3408 const auto &scissor = pExclusiveScissors[scissor_i]; // will crash on invalid ptr
3409
3410 if (scissor.offset.x < 0) {
3411 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3412 HandleToUint64(commandBuffer), "VUID-vkCmdSetExclusiveScissorNV-x-02037",
3413 "vkCmdSetExclusiveScissorNV: pScissors[%" PRIu32 "].offset.x (=%" PRIi32 ") is negative.", scissor_i,
3414 scissor.offset.x);
3415 }
3416
3417 if (scissor.offset.y < 0) {
3418 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3419 HandleToUint64(commandBuffer), "VUID-vkCmdSetExclusiveScissorNV-x-02037",
3420 "vkCmdSetExclusiveScissorNV: pScissors[%" PRIu32 "].offset.y (=%" PRIi32 ") is negative.", scissor_i,
3421 scissor.offset.y);
3422 }
3423
3424 const int64_t x_sum = static_cast<int64_t>(scissor.offset.x) + static_cast<int64_t>(scissor.extent.width);
3425 if (x_sum > INT32_MAX) {
3426 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3427 HandleToUint64(commandBuffer), "VUID-vkCmdSetExclusiveScissorNV-offset-02038",
3428 "vkCmdSetExclusiveScissorNV: offset.x + extent.width (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
3429 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
3430 scissor.offset.x, scissor.extent.width, x_sum, scissor_i);
3431 }
3432
3433 const int64_t y_sum = static_cast<int64_t>(scissor.offset.y) + static_cast<int64_t>(scissor.extent.height);
3434 if (y_sum > INT32_MAX) {
3435 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3436 HandleToUint64(commandBuffer), "VUID-vkCmdSetExclusiveScissorNV-offset-02039",
3437 "vkCmdSetExclusiveScissorNV: offset.y + extent.height (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
3438 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
3439 scissor.offset.y, scissor.extent.height, y_sum, scissor_i);
3440 }
3441 }
3442 }
3443
3444 return skip;
3445}
3446
Jeff Bolz9af91c52018-09-01 21:53:57 -05003447bool pv_vkCmdSetViewportShadingRatePaletteNV(
3448 VkCommandBuffer commandBuffer,
3449 uint32_t firstViewport,
3450 uint32_t viewportCount,
3451 const VkShadingRatePaletteNV* pShadingRatePalettes)
3452{
3453 bool skip = false;
3454
3455 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3456 debug_report_data *report_data = device_data->report_data;
3457
3458 if (!device_data->physical_device_features.multiViewport) {
3459 if (firstViewport != 0) {
3460 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3461 HandleToUint64(commandBuffer), "VUID-vkCmdSetViewportShadingRatePaletteNV-firstViewport-02068",
3462 "vkCmdSetViewportShadingRatePaletteNV: The multiViewport feature is disabled, but firstViewport (=%" PRIu32 ") is not 0.",
3463 firstViewport);
3464 }
3465 if (viewportCount > 1) {
3466 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3467 HandleToUint64(commandBuffer), "VUID-vkCmdSetViewportShadingRatePaletteNV-viewportCount-02069",
3468 "vkCmdSetViewportShadingRatePaletteNV: The multiViewport feature is disabled, but viewportCount (=%" PRIu32 ") is not 1.",
3469 viewportCount);
3470 }
3471 }
3472
3473 if (firstViewport >= device_data->device_limits.maxViewports) {
3474 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3475 HandleToUint64(commandBuffer), "VUID-vkCmdSetViewportShadingRatePaletteNV-firstViewport-02066",
3476 "vkCmdSetViewportShadingRatePaletteNV: firstViewport (=%" PRIu32 ") must be less than maxViewports (=%" PRIu32 ").",
3477 firstViewport, device_data->device_limits.maxViewports);
3478 }
3479
3480 const uint64_t sum = static_cast<uint64_t>(firstViewport) + static_cast<uint64_t>(viewportCount);
3481 if (sum > device_data->device_limits.maxViewports) {
3482 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3483 HandleToUint64(commandBuffer), "VUID-vkCmdSetViewportShadingRatePaletteNV-firstViewport-02067",
3484 "vkCmdSetViewportShadingRatePaletteNV: firstViewport + viewportCount (=%" PRIu32 " + %" PRIu32 " = %" PRIu64
3485 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
3486 firstViewport, viewportCount, sum, device_data->device_limits.maxViewports);
3487 }
3488
3489 return skip;
3490}
3491
3492
3493bool pv_vkCmdSetCoarseSampleOrderNV(
3494 VkCommandBuffer commandBuffer,
3495 VkCoarseSampleOrderTypeNV sampleOrderType,
3496 uint32_t customSampleOrderCount,
3497 const VkCoarseSampleOrderCustomNV* pCustomSampleOrders)
3498{
3499 bool skip = false;
3500
3501 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3502 debug_report_data *report_data = device_data->report_data;
3503
3504 if (sampleOrderType != VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV &&
3505 customSampleOrderCount != 0) {
3506 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3507 HandleToUint64(commandBuffer), "VUID-vkCmdSetCoarseSampleOrderNV-sampleOrderType-02081",
3508 "vkCmdSetCoarseSampleOrderNV: If sampleOrderType is not VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV, "
3509 "customSampleOrderCount must be 0.");
3510 }
3511
3512 for (uint32_t order_i = 0; order_i < customSampleOrderCount; ++order_i) {
3513 skip |= ValidateCoarseSampleOrderCustomNV(device_data, &pCustomSampleOrders[order_i]);
3514 }
3515
3516 return skip;
3517}
3518
3519
Jeff Bolz45bf7d62018-09-18 15:39:58 -05003520bool pv_vkCmdDrawMeshTasksNV(
3521 VkCommandBuffer commandBuffer,
3522 uint32_t taskCount,
3523 uint32_t firstTask)
3524{
3525 bool skip = false;
3526
3527 layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3528
3529 if (taskCount > dev_data->phys_dev_ext_props.mesh_shader_props.maxDrawMeshTasksCount) {
3530 skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3531 HandleToUint64(commandBuffer), "VUID-vkCmdDrawMeshTasksNV-taskCount-02119",
3532 "vkCmdDrawMeshTasksNV() parameter, uint32_t taskCount (0x%" PRIxLEAST32
3533 "), must be less than or equal to VkPhysicalDeviceMeshShaderPropertiesNV::maxDrawMeshTasksCount (0x%" PRIxLEAST32").",
3534 taskCount, dev_data->phys_dev_ext_props.mesh_shader_props.maxDrawMeshTasksCount);
3535 }
3536
3537 return skip;
3538}
3539
3540
3541bool pv_vkCmdDrawMeshTasksIndirectNV(
3542 VkCommandBuffer commandBuffer,
3543 VkBuffer buffer,
3544 VkDeviceSize offset,
3545 uint32_t drawCount,
3546 uint32_t stride)
3547{
3548 bool skip = false;
3549
3550 layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3551 debug_report_data *report_data = dev_data->report_data;
3552
3553 if (offset & 3) {
3554 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3555 HandleToUint64(commandBuffer), "VUID-vkCmdDrawMeshTasksIndirectNV-offset-02145",
3556 "vkCmdDrawMeshTasksIndirectNV() parameter, VkDeviceSize offset (0x%" PRIxLEAST64
3557 "), is not a multiple of 4.",
3558 offset);
3559 }
3560
3561 if (drawCount > 1 && ((stride & 3) || stride < sizeof(VkDrawMeshTasksIndirectCommandNV))) {
3562 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3563 HandleToUint64(commandBuffer), "VUID-vkCmdDrawMeshTasksIndirectNV-drawCount-02146",
3564 "vkCmdDrawMeshTasksIndirectNV() parameter, uint32_t stride (0x%" PRIxLEAST32
3565 "), is not a multiple of 4 or smaller than sizeof (VkDrawMeshTasksIndirectCommandNV).",
3566 stride);
3567 }
3568
3569 return skip;
3570}
3571
3572bool pv_vkCmdDrawMeshTasksIndirectCountNV(
3573 VkCommandBuffer commandBuffer,
3574 VkBuffer buffer,
3575 VkDeviceSize offset,
3576 VkBuffer countBuffer,
3577 VkDeviceSize countBufferOffset,
3578 uint32_t maxDrawCount,
3579 uint32_t stride)
3580{
3581 bool skip = false;
3582
3583 layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3584
3585 if (offset & 3) {
3586 skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3587 HandleToUint64(commandBuffer), "VUID-vkCmdDrawMeshTasksIndirectCountNV-offset-02180",
3588 "vkCmdDrawMeshTasksIndirectCountNV() parameter, VkDeviceSize offset (0x%" PRIxLEAST64
3589 "), is not a multiple of 4.",
3590 offset);
3591 }
3592
3593 if (countBufferOffset & 3) {
3594 skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3595 HandleToUint64(commandBuffer), "VUID-vkCmdDrawMeshTasksIndirectCountNV-countBufferOffset-02181",
3596 "vkCmdDrawMeshTasksIndirectCountNV() parameter, VkDeviceSize countBufferOffset (0x%" PRIxLEAST64
3597 "), is not a multiple of 4.",
3598 countBufferOffset);
3599 }
3600
3601 if ((stride & 3) || stride < sizeof(VkDrawMeshTasksIndirectCommandNV)) {
3602 skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3603 HandleToUint64(commandBuffer), "VUID-vkCmdDrawMeshTasksIndirectCountNV-stride-02182",
3604 "vkCmdDrawMeshTasksIndirectCountNV() parameter, uint32_t stride (0x%" PRIxLEAST32
3605 "), is not a multiple of 4 or smaller than sizeof (VkDrawMeshTasksIndirectCommandNV).",
3606 stride);
3607 }
3608
3609 return skip;
3610}
3611
3612
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003613VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetDeviceProcAddr(VkDevice device, const char *funcName) {
Mark Lobodzinskib7a26382018-07-02 13:14:26 -06003614 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
3615 if (!ApiParentExtensionEnabled(funcName, device_data->extensions.device_extension_set)) {
3616 return nullptr;
3617 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003618 const auto item = name_to_funcptr_map.find(funcName);
3619 if (item != name_to_funcptr_map.end()) {
3620 return reinterpret_cast<PFN_vkVoidFunction>(item->second);
3621 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003622 const auto &table = device_data->dispatch_table;
3623 if (!table.GetDeviceProcAddr) return nullptr;
3624 return table.GetDeviceProcAddr(device, funcName);
3625}
3626
3627VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetInstanceProcAddr(VkInstance instance, const char *funcName) {
3628 const auto item = name_to_funcptr_map.find(funcName);
3629 if (item != name_to_funcptr_map.end()) {
3630 return reinterpret_cast<PFN_vkVoidFunction>(item->second);
3631 }
3632
3633 auto instance_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map);
3634 auto &table = instance_data->dispatch_table;
3635 if (!table.GetInstanceProcAddr) return nullptr;
3636 return table.GetInstanceProcAddr(instance, funcName);
3637}
3638
3639VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetPhysicalDeviceProcAddr(VkInstance instance, const char *funcName) {
3640 assert(instance);
3641 auto instance_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map);
3642
3643 if (!instance_data->dispatch_table.GetPhysicalDeviceProcAddr) return nullptr;
3644 return instance_data->dispatch_table.GetPhysicalDeviceProcAddr(instance, funcName);
3645}
3646
3647// If additional validation is needed outside of the generated checks, a manual routine can be added to this file
3648// and the address filled in here. The autogenerated source will call these routines if the pointers are not NULL.
Petr Krausc8655be2017-09-27 18:56:51 +02003649void InitializeManualParameterValidationFunctionPointers() {
Dave Houltonb3bbec72018-01-17 10:13:33 -07003650 custom_functions["vkGetDeviceQueue"] = (void *)pv_vkGetDeviceQueue;
3651 custom_functions["vkCreateBuffer"] = (void *)pv_vkCreateBuffer;
3652 custom_functions["vkCreateImage"] = (void *)pv_vkCreateImage;
3653 custom_functions["vkCreateImageView"] = (void *)pv_vkCreateImageView;
3654 custom_functions["vkCreateGraphicsPipelines"] = (void *)pv_vkCreateGraphicsPipelines;
3655 custom_functions["vkCreateComputePipelines"] = (void *)pv_vkCreateComputePipelines;
3656 custom_functions["vkCreateSampler"] = (void *)pv_vkCreateSampler;
3657 custom_functions["vkCreateDescriptorSetLayout"] = (void *)pv_vkCreateDescriptorSetLayout;
3658 custom_functions["vkFreeDescriptorSets"] = (void *)pv_vkFreeDescriptorSets;
3659 custom_functions["vkUpdateDescriptorSets"] = (void *)pv_vkUpdateDescriptorSets;
3660 custom_functions["vkCreateRenderPass"] = (void *)pv_vkCreateRenderPass;
3661 custom_functions["vkBeginCommandBuffer"] = (void *)pv_vkBeginCommandBuffer;
3662 custom_functions["vkCmdSetViewport"] = (void *)pv_vkCmdSetViewport;
3663 custom_functions["vkCmdSetScissor"] = (void *)pv_vkCmdSetScissor;
Petr Kraus299ba622017-11-24 03:09:03 +01003664 custom_functions["vkCmdSetLineWidth"] = (void *)pv_vkCmdSetLineWidth;
Dave Houltonb3bbec72018-01-17 10:13:33 -07003665 custom_functions["vkCmdDraw"] = (void *)pv_vkCmdDraw;
3666 custom_functions["vkCmdDrawIndirect"] = (void *)pv_vkCmdDrawIndirect;
3667 custom_functions["vkCmdDrawIndexedIndirect"] = (void *)pv_vkCmdDrawIndexedIndirect;
3668 custom_functions["vkCmdCopyImage"] = (void *)pv_vkCmdCopyImage;
3669 custom_functions["vkCmdBlitImage"] = (void *)pv_vkCmdBlitImage;
3670 custom_functions["vkCmdCopyBufferToImage"] = (void *)pv_vkCmdCopyBufferToImage;
3671 custom_functions["vkCmdCopyImageToBuffer"] = (void *)pv_vkCmdCopyImageToBuffer;
3672 custom_functions["vkCmdUpdateBuffer"] = (void *)pv_vkCmdUpdateBuffer;
3673 custom_functions["vkCmdFillBuffer"] = (void *)pv_vkCmdFillBuffer;
3674 custom_functions["vkCreateSwapchainKHR"] = (void *)pv_vkCreateSwapchainKHR;
3675 custom_functions["vkQueuePresentKHR"] = (void *)pv_vkQueuePresentKHR;
3676 custom_functions["vkCreateDescriptorPool"] = (void *)pv_vkCreateDescriptorPool;
3677 custom_functions["vkCmdDispatch"] = (void *)pv_vkCmdDispatch;
Mark Lobodzinskibf973a12018-03-01 08:50:21 -07003678 custom_functions["vkCmdDispatchBaseKHR"] = (void *)pv_vkCmdDispatchBaseKHR;
Jeff Bolz3e71f782018-08-29 23:15:45 -05003679 custom_functions["vkCmdSetExclusiveScissorNV"] = (void *)pv_vkCmdSetExclusiveScissorNV;
Jeff Bolz9af91c52018-09-01 21:53:57 -05003680 custom_functions["vkCmdSetViewportShadingRatePaletteNV"] = (void *)pv_vkCmdSetViewportShadingRatePaletteNV;
3681 custom_functions["vkCmdSetCoarseSampleOrderNV"] = (void *)pv_vkCmdSetCoarseSampleOrderNV;
Jeff Bolz45bf7d62018-09-18 15:39:58 -05003682 custom_functions["vkCmdDrawMeshTasksNV"] = (void *)pv_vkCmdDrawMeshTasksNV;
3683 custom_functions["vkCmdDrawMeshTasksIndirectNV"] = (void *)pv_vkCmdDrawMeshTasksIndirectNV;
3684 custom_functions["vkCmdDrawMeshTasksIndirectCountNV"] = (void *)pv_vkCmdDrawMeshTasksIndirectCountNV;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003685}
3686
3687} // namespace parameter_validation
3688
3689VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateInstanceExtensionProperties(const char *pLayerName, uint32_t *pCount,
3690 VkExtensionProperties *pProperties) {
3691 return parameter_validation::vkEnumerateInstanceExtensionProperties(pLayerName, pCount, pProperties);
3692}
3693
3694VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateInstanceLayerProperties(uint32_t *pCount,
3695 VkLayerProperties *pProperties) {
3696 return parameter_validation::vkEnumerateInstanceLayerProperties(pCount, pProperties);
3697}
3698
3699VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateDeviceLayerProperties(VkPhysicalDevice physicalDevice, uint32_t *pCount,
3700 VkLayerProperties *pProperties) {
3701 // the layer command handles VK_NULL_HANDLE just fine internally
3702 assert(physicalDevice == VK_NULL_HANDLE);
3703 return parameter_validation::vkEnumerateDeviceLayerProperties(VK_NULL_HANDLE, pCount, pProperties);
3704}
3705
3706VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateDeviceExtensionProperties(VkPhysicalDevice physicalDevice,
3707 const char *pLayerName, uint32_t *pCount,
3708 VkExtensionProperties *pProperties) {
3709 // the layer command handles VK_NULL_HANDLE just fine internally
3710 assert(physicalDevice == VK_NULL_HANDLE);
3711 return parameter_validation::vkEnumerateDeviceExtensionProperties(VK_NULL_HANDLE, pLayerName, pCount, pProperties);
3712}
3713
3714VK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetDeviceProcAddr(VkDevice dev, const char *funcName) {
3715 return parameter_validation::vkGetDeviceProcAddr(dev, funcName);
3716}
3717
3718VK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetInstanceProcAddr(VkInstance instance, const char *funcName) {
3719 return parameter_validation::vkGetInstanceProcAddr(instance, funcName);
3720}
3721
3722VK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vk_layerGetPhysicalDeviceProcAddr(VkInstance instance,
3723 const char *funcName) {
3724 return parameter_validation::vkGetPhysicalDeviceProcAddr(instance, funcName);
3725}
3726
Lenny Komow2d0cbbe2018-05-24 13:38:05 -06003727VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL VKAPI_CALL
3728vkNegotiateLoaderLayerInterfaceVersion(VkNegotiateLayerInterface *pVersionStruct) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003729 assert(pVersionStruct != NULL);
3730 assert(pVersionStruct->sType == LAYER_NEGOTIATE_INTERFACE_STRUCT);
3731
3732 // Fill in the function pointers if our version is at least capable of having the structure contain them.
3733 if (pVersionStruct->loaderLayerInterfaceVersion >= 2) {
3734 pVersionStruct->pfnGetInstanceProcAddr = vkGetInstanceProcAddr;
3735 pVersionStruct->pfnGetDeviceProcAddr = vkGetDeviceProcAddr;
3736 pVersionStruct->pfnGetPhysicalDeviceProcAddr = vk_layerGetPhysicalDeviceProcAddr;
3737 }
3738
3739 if (pVersionStruct->loaderLayerInterfaceVersion < CURRENT_LOADER_LAYER_INTERFACE_VERSION) {
3740 parameter_validation::loader_layer_if_version = pVersionStruct->loaderLayerInterfaceVersion;
3741 } else if (pVersionStruct->loaderLayerInterfaceVersion > CURRENT_LOADER_LAYER_INTERFACE_VERSION) {
3742 pVersionStruct->loaderLayerInterfaceVersion = CURRENT_LOADER_LAYER_INTERFACE_VERSION;
3743 }
3744
3745 return VK_SUCCESS;
3746}