blob: e80df8e783c7c8a7c342051be233ce53d23e6d1d [file] [log] [blame]
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001/* Copyright (c) 2015-2017 The Khronos Group Inc.
2 * Copyright (c) 2015-2017 Valve Corporation
3 * Copyright (c) 2015-2017 LunarG, Inc.
4 * Copyright (C) 2015-2017 Google Inc.
5 *
6 * Licensed under the Apache License, Version 2.0 (the "License");
7 * you may not use this file except in compliance with the License.
8 * You may obtain a copy of the License at
9 *
10 * http://www.apache.org/licenses/LICENSE-2.0
11 *
12 * Unless required by applicable law or agreed to in writing, software
13 * distributed under the License is distributed on an "AS IS" BASIS,
14 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15 * See the License for the specific language governing permissions and
16 * limitations under the License.
17 *
18 * Author: Mark Lobodzinski <mark@LunarG.com>
19 */
20
21#define NOMINMAX
John Zulauf0fe5bfe2018-05-23 09:36:00 -060022#define VALIDATION_ERROR_MAP_IMPL
Mark Lobodzinskid4950072017-08-01 13:02:20 -060023
24#include <limits.h>
25#include <math.h>
26#include <stdio.h>
27#include <stdlib.h>
28#include <string.h>
Mark Lobodzinskid4950072017-08-01 13:02:20 -060029
30#include <iostream>
31#include <string>
32#include <sstream>
33#include <unordered_map>
34#include <unordered_set>
35#include <vector>
36#include <mutex>
37
38#include "vk_loader_platform.h"
39#include "vulkan/vk_layer.h"
40#include "vk_layer_config.h"
41#include "vk_dispatch_table_helper.h"
John Zulaufde972ac2017-10-26 12:07:05 -060042#include "vk_typemap_helper.h"
Mark Lobodzinskid4950072017-08-01 13:02:20 -060043
Mark Lobodzinskid4950072017-08-01 13:02:20 -060044#include "vk_layer_data.h"
45#include "vk_layer_logging.h"
46#include "vk_layer_extension_utils.h"
47#include "vk_layer_utils.h"
Lenny Komow4c0da772018-07-03 10:17:21 -060048#include "vk_layer_dispatch_table.h"
Mark Lobodzinskid4950072017-08-01 13:02:20 -060049
50#include "parameter_name.h"
51#include "parameter_validation.h"
52
Mark Lobodzinskibfb7ab92017-10-27 13:22:23 -060053#if defined __ANDROID__
54#include <android/log.h>
Mark Lobodzinski88529492018-04-01 10:38:15 -060055#define LOGCONSOLE(...) ((void)__android_log_print(ANDROID_LOG_INFO, "PARAMETER_VALIDATION", __VA_ARGS__))
Mark Lobodzinskibfb7ab92017-10-27 13:22:23 -060056#else
57#define LOGCONSOLE(...) \
58 { \
59 printf(__VA_ARGS__); \
60 printf("\n"); \
61 }
62#endif
63
Mark Lobodzinskid4950072017-08-01 13:02:20 -060064namespace parameter_validation {
65
Mark Lobodzinski78a12a92017-08-08 14:16:51 -060066extern std::unordered_map<std::string, void *> custom_functions;
67
Mark Lobodzinskid4950072017-08-01 13:02:20 -060068extern bool parameter_validation_vkCreateInstance(VkInstance instance, const VkInstanceCreateInfo *pCreateInfo,
69 const VkAllocationCallbacks *pAllocator, VkInstance *pInstance);
70extern bool parameter_validation_vkDestroyInstance(VkInstance instance, const VkAllocationCallbacks *pAllocator);
71extern bool parameter_validation_vkCreateDevice(VkPhysicalDevice physicalDevice, const VkDeviceCreateInfo *pCreateInfo,
72 const VkAllocationCallbacks *pAllocator, VkDevice *pDevice);
73extern bool parameter_validation_vkDestroyDevice(VkDevice device, const VkAllocationCallbacks *pAllocator);
74extern bool parameter_validation_vkCreateQueryPool(VkDevice device, const VkQueryPoolCreateInfo *pCreateInfo,
75 const VkAllocationCallbacks *pAllocator, VkQueryPool *pQueryPool);
76extern bool parameter_validation_vkCreateDebugReportCallbackEXT(VkInstance instance,
77 const VkDebugReportCallbackCreateInfoEXT *pCreateInfo,
78 const VkAllocationCallbacks *pAllocator,
79 VkDebugReportCallbackEXT *pMsgCallback);
80extern bool parameter_validation_vkDestroyDebugReportCallbackEXT(VkInstance instance, VkDebugReportCallbackEXT msgCallback,
81 const VkAllocationCallbacks *pAllocator);
Mark Young6ba8abe2017-11-09 10:37:04 -070082extern bool parameter_validation_vkCreateDebugUtilsMessengerEXT(VkInstance instance,
83 const VkDebugUtilsMessengerCreateInfoEXT *pCreateInfo,
84 const VkAllocationCallbacks *pAllocator,
85 VkDebugUtilsMessengerEXT *pMessenger);
86extern bool parameter_validation_vkDestroyDebugUtilsMessengerEXT(VkInstance instance, VkDebugUtilsMessengerEXT messenger,
87 const VkAllocationCallbacks *pAllocator);
Mark Lobodzinskid4950072017-08-01 13:02:20 -060088extern bool parameter_validation_vkCreateCommandPool(VkDevice device, const VkCommandPoolCreateInfo *pCreateInfo,
89 const VkAllocationCallbacks *pAllocator, VkCommandPool *pCommandPool);
Petr Krause91f7a12017-12-14 20:57:36 +010090extern bool parameter_validation_vkCreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo,
91 const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass);
92extern bool parameter_validation_vkDestroyRenderPass(VkDevice device, VkRenderPass renderPass,
93 const VkAllocationCallbacks *pAllocator);
Mark Lobodzinskid4950072017-08-01 13:02:20 -060094
95// TODO : This can be much smarter, using separate locks for separate global data
96std::mutex global_lock;
97
98static uint32_t loader_layer_if_version = CURRENT_LOADER_LAYER_INTERFACE_VERSION;
99std::unordered_map<void *, layer_data *> layer_data_map;
100std::unordered_map<void *, instance_layer_data *> instance_layer_data_map;
101
102void InitializeManualParameterValidationFunctionPointers(void);
103
104static void init_parameter_validation(instance_layer_data *instance_data, const VkAllocationCallbacks *pAllocator) {
Mark Young6ba8abe2017-11-09 10:37:04 -0700105 layer_debug_report_actions(instance_data->report_data, instance_data->logging_callback, pAllocator,
106 "lunarg_parameter_validation");
107 layer_debug_messenger_actions(instance_data->report_data, instance_data->logging_messenger, pAllocator,
108 "lunarg_parameter_validation");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600109}
110
Mark Young6ba8abe2017-11-09 10:37:04 -0700111static const VkExtensionProperties instance_extensions[] = {{VK_EXT_DEBUG_REPORT_EXTENSION_NAME, VK_EXT_DEBUG_REPORT_SPEC_VERSION},
112 {VK_EXT_DEBUG_UTILS_EXTENSION_NAME, VK_EXT_DEBUG_UTILS_SPEC_VERSION}};
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600113
114static const VkLayerProperties global_layer = {
Dave Houltonb3bbec72018-01-17 10:13:33 -0700115 "VK_LAYER_LUNARG_parameter_validation",
116 VK_LAYER_API_VERSION,
117 1,
118 "LunarG Validation Layer",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600119};
120
121static const int MaxParamCheckerStringLength = 256;
122
John Zulauf71968502017-10-26 13:51:15 -0600123template <typename T>
124static inline bool in_inclusive_range(const T &value, const T &min, const T &max) {
125 // Using only < for generality and || for early abort
126 return !((value < min) || (max < value));
127}
128
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600129static bool validate_string(debug_report_data *report_data, const char *apiName, const ParameterName &stringName,
Mark Lobodzinskiebee3552018-05-29 09:55:54 -0600130 const std::string &vuid, const char *validateString) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600131 bool skip = false;
132
133 VkStringErrorFlags result = vk_string_validate(MaxParamCheckerStringLength, validateString);
134
135 if (result == VK_STRING_ERROR_NONE) {
136 return skip;
137 } else if (result & VK_STRING_ERROR_LENGTH) {
Mark Lobodzinskiebee3552018-05-29 09:55:54 -0600138 skip = log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, vuid,
139 "%s: string %s exceeds max length %d", apiName, stringName.get_name().c_str(), MaxParamCheckerStringLength);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600140 } else if (result & VK_STRING_ERROR_BAD_DATA) {
Mark Lobodzinskiebee3552018-05-29 09:55:54 -0600141 skip = log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, vuid,
142 "%s: string %s contains invalid characters or is badly formed", apiName, stringName.get_name().c_str());
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600143 }
144 return skip;
145}
146
147static bool ValidateDeviceQueueFamily(layer_data *device_data, uint32_t queue_family, const char *cmd_name,
Dave Houlton13b65502018-05-23 13:35:24 -0600148 const char *parameter_name, const std::string &error_code, bool optional = false) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600149 bool skip = false;
150
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600151 if (!optional && queue_family == VK_QUEUE_FAMILY_IGNORED) {
152 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -0600153 HandleToUint64(device_data->device), error_code,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600154 "%s: %s is VK_QUEUE_FAMILY_IGNORED, but it is required to provide a valid queue family index value.",
155 cmd_name, parameter_name);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600156 } else if (device_data->queueFamilyIndexMap.find(queue_family) == device_data->queueFamilyIndexMap.end()) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600157 skip |=
158 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -0600159 HandleToUint64(device_data->device), error_code,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600160 "%s: %s (= %" PRIu32
161 ") is not one of the queue families given via VkDeviceQueueCreateInfo structures when the device was created.",
162 cmd_name, parameter_name, queue_family);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600163 }
164
165 return skip;
166}
167
168static bool ValidateQueueFamilies(layer_data *device_data, uint32_t queue_family_count, const uint32_t *queue_families,
Dave Houlton13b65502018-05-23 13:35:24 -0600169 const char *cmd_name, const char *array_parameter_name, const std::string &unique_error_code,
170 const std::string &valid_error_code, bool optional = false) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600171 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600172 if (queue_families) {
173 std::unordered_set<uint32_t> set;
174 for (uint32_t i = 0; i < queue_family_count; ++i) {
175 std::string parameter_name = std::string(array_parameter_name) + "[" + std::to_string(i) + "]";
176
177 if (set.count(queue_families[i])) {
178 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -0600179 HandleToUint64(device_data->device), "VUID-VkDeviceCreateInfo-queueFamilyIndex-00372",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600180 "%s: %s (=%" PRIu32 ") is not unique within %s array.", cmd_name, parameter_name.c_str(),
181 queue_families[i], array_parameter_name);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600182 } else {
183 set.insert(queue_families[i]);
184 skip |= ValidateDeviceQueueFamily(device_data, queue_families[i], cmd_name, parameter_name.c_str(),
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600185 valid_error_code, optional);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600186 }
187 }
188 }
189 return skip;
190}
191
John Zulauf620755c2018-04-16 11:00:43 -0600192static bool validate_api_version(const instance_layer_data *instance_data, uint32_t api_version, uint32_t effective_api_version) {
193 bool skip = false;
194 uint32_t api_version_nopatch = VK_MAKE_VERSION(VK_VERSION_MAJOR(api_version), VK_VERSION_MINOR(api_version), 0);
195 if (api_version_nopatch != effective_api_version) {
196 if (api_version_nopatch < VK_API_VERSION_1_0) {
197 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_INSTANCE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -0600198 HandleToUint64(instance_data->instance), kVUIDUndefined,
John Zulauf620755c2018-04-16 11:00:43 -0600199 "Invalid CreateInstance->pCreateInfo->pApplicationInfo.apiVersion number (0x%08x). "
200 "Using VK_API_VERSION_%" PRIu32 "_%" PRIu32 ".",
201 api_version, VK_VERSION_MAJOR(effective_api_version), VK_VERSION_MINOR(effective_api_version));
202 } else {
203 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_INSTANCE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -0600204 HandleToUint64(instance_data->instance), kVUIDUndefined,
John Zulauf620755c2018-04-16 11:00:43 -0600205 "Unrecognized CreateInstance->pCreateInfo->pApplicationInfo.apiVersion number (0x%08x). "
206 "Assuming VK_API_VERSION_%" PRIu32 "_%" PRIu32 ".",
207 api_version, VK_VERSION_MAJOR(effective_api_version), VK_VERSION_MINOR(effective_api_version));
208 }
209 }
210 return skip;
211}
212
213template <typename ExtensionState>
Dave Houlton13b65502018-05-23 13:35:24 -0600214static bool validate_extension_reqs(const instance_layer_data *instance_data, const ExtensionState &extensions,
215 const std::string &vuid, const char *extension_type, const char *extension_name) {
John Zulauf620755c2018-04-16 11:00:43 -0600216 bool skip = false;
217 if (!extension_name) {
218 return skip; // Robust to invalid char *
219 }
220 auto info = ExtensionState::get_info(extension_name);
221
222 if (!info.state) {
223 return skip; // Unknown extensions cannot be checked so report OK
224 }
225
Pat Brown3eddb062018-09-05 14:07:37 -0400226 // Check against the required list in the info
John Zulauf620755c2018-04-16 11:00:43 -0600227 std::vector<const char *> missing;
228 for (const auto &req : info.requires) {
229 if (!(extensions.*(req.enabled))) {
230 missing.push_back(req.name);
231 }
232 }
233
234 // Report any missing requirements
235 if (missing.size()) {
236 std::string missing_joined_list = string_join(", ", missing);
237 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_INSTANCE_EXT,
Pat Brown3eddb062018-09-05 14:07:37 -0400238 HandleToUint64(instance_data->instance), vuid, "Missing extension%s required by the %s extension %s: %s.",
239 ((missing.size() > 1) ? "s" : ""), extension_type, extension_name, missing_joined_list.c_str());
John Zulauf620755c2018-04-16 11:00:43 -0600240 }
241 return skip;
242}
243
244bool validate_instance_extensions(const instance_layer_data *instance_data, const VkInstanceCreateInfo *pCreateInfo) {
245 bool skip = false;
246 for (uint32_t i = 0; i < pCreateInfo->enabledExtensionCount; i++) {
Dave Houlton413a6782018-05-22 13:01:54 -0600247 skip |=
248 validate_extension_reqs(instance_data, instance_data->extensions, "VUID-vkCreateInstance-ppEnabledExtensionNames-01388",
249 "instance", pCreateInfo->ppEnabledExtensionNames[i]);
John Zulauf620755c2018-04-16 11:00:43 -0600250 }
251
252 return skip;
253}
254
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600255VKAPI_ATTR VkResult VKAPI_CALL vkCreateInstance(const VkInstanceCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600256 VkInstance *pInstance) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600257 VkResult result = VK_ERROR_VALIDATION_FAILED_EXT;
258
259 VkLayerInstanceCreateInfo *chain_info = get_chain_info(pCreateInfo, VK_LAYER_LINK_INFO);
260 assert(chain_info != nullptr);
261 assert(chain_info->u.pLayerInfo != nullptr);
262
263 PFN_vkGetInstanceProcAddr fpGetInstanceProcAddr = chain_info->u.pLayerInfo->pfnNextGetInstanceProcAddr;
264 PFN_vkCreateInstance fpCreateInstance = (PFN_vkCreateInstance)fpGetInstanceProcAddr(NULL, "vkCreateInstance");
265 if (fpCreateInstance == NULL) {
266 return VK_ERROR_INITIALIZATION_FAILED;
267 }
268
269 // Advance the link info for the next element on the chain
270 chain_info->u.pLayerInfo = chain_info->u.pLayerInfo->pNext;
271
272 result = fpCreateInstance(pCreateInfo, pAllocator, pInstance);
273
274 if (result == VK_SUCCESS) {
275 InitializeManualParameterValidationFunctionPointers();
276 auto my_instance_data = GetLayerDataPtr(get_dispatch_key(*pInstance), instance_layer_data_map);
277 assert(my_instance_data != nullptr);
278
279 layer_init_instance_dispatch_table(*pInstance, &my_instance_data->dispatch_table, fpGetInstanceProcAddr);
280 my_instance_data->instance = *pInstance;
281 my_instance_data->report_data =
Mark Young6ba8abe2017-11-09 10:37:04 -0700282 debug_utils_create_instance(&my_instance_data->dispatch_table, *pInstance, pCreateInfo->enabledExtensionCount,
283 pCreateInfo->ppEnabledExtensionNames);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600284
285 // Look for one or more debug report create info structures
286 // and setup a callback(s) for each one found.
Mark Young6ba8abe2017-11-09 10:37:04 -0700287 if (!layer_copy_tmp_debug_messengers(pCreateInfo->pNext, &my_instance_data->num_tmp_debug_messengers,
288 &my_instance_data->tmp_messenger_create_infos,
289 &my_instance_data->tmp_debug_messengers)) {
290 if (my_instance_data->num_tmp_debug_messengers > 0) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600291 // Setup the temporary callback(s) here to catch early issues:
Mark Young6ba8abe2017-11-09 10:37:04 -0700292 if (layer_enable_tmp_debug_messengers(my_instance_data->report_data, my_instance_data->num_tmp_debug_messengers,
293 my_instance_data->tmp_messenger_create_infos,
294 my_instance_data->tmp_debug_messengers)) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600295 // Failure of setting up one or more of the callback.
296 // Therefore, clean up and don't use those callbacks:
Mark Young6ba8abe2017-11-09 10:37:04 -0700297 layer_free_tmp_debug_messengers(my_instance_data->tmp_messenger_create_infos,
298 my_instance_data->tmp_debug_messengers);
299 my_instance_data->num_tmp_debug_messengers = 0;
300 }
301 }
302 }
303 if (!layer_copy_tmp_report_callbacks(pCreateInfo->pNext, &my_instance_data->num_tmp_report_callbacks,
304 &my_instance_data->tmp_report_create_infos, &my_instance_data->tmp_report_callbacks)) {
305 if (my_instance_data->num_tmp_report_callbacks > 0) {
306 // Setup the temporary callback(s) here to catch early issues:
307 if (layer_enable_tmp_report_callbacks(my_instance_data->report_data, my_instance_data->num_tmp_report_callbacks,
308 my_instance_data->tmp_report_create_infos,
309 my_instance_data->tmp_report_callbacks)) {
310 // Failure of setting up one or more of the callback.
311 // Therefore, clean up and don't use those callbacks:
312 layer_free_tmp_report_callbacks(my_instance_data->tmp_report_create_infos,
313 my_instance_data->tmp_report_callbacks);
314 my_instance_data->num_tmp_report_callbacks = 0;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600315 }
316 }
317 }
318
319 init_parameter_validation(my_instance_data, pAllocator);
John Zulaufe6db8a32018-03-30 14:51:59 -0600320 // Note: From the spec--
321 // Providing a NULL VkInstanceCreateInfo::pApplicationInfo or providing an apiVersion of 0 is equivalent to providing
322 // an apiVersion of VK_MAKE_VERSION(1, 0, 0). (a.k.a. VK_API_VERSION_1_0)
323 uint32_t api_version = (pCreateInfo->pApplicationInfo && pCreateInfo->pApplicationInfo->apiVersion)
324 ? pCreateInfo->pApplicationInfo->apiVersion
325 : VK_API_VERSION_1_0;
Mark Lobodzinskibfb7ab92017-10-27 13:22:23 -0600326
John Zulauf1909e6a2018-09-05 11:43:11 -0600327 my_instance_data->api_version = my_instance_data->extensions.InitFromInstanceCreateInfo(api_version, pCreateInfo);
Mark Lobodzinskibfb7ab92017-10-27 13:22:23 -0600328
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600329 // Ordinarily we'd check these before calling down the chain, but none of the layer support is in place until now, if we
330 // survive we can report the issue now.
John Zulauf1909e6a2018-09-05 11:43:11 -0600331 validate_api_version(my_instance_data, api_version, my_instance_data->api_version);
John Zulauf620755c2018-04-16 11:00:43 -0600332 validate_instance_extensions(my_instance_data, pCreateInfo);
333
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600334 parameter_validation_vkCreateInstance(*pInstance, pCreateInfo, pAllocator, pInstance);
335
336 if (pCreateInfo->pApplicationInfo) {
337 if (pCreateInfo->pApplicationInfo->pApplicationName) {
Mark Lobodzinskiebee3552018-05-29 09:55:54 -0600338 validate_string(
339 my_instance_data->report_data, "vkCreateInstance", "pCreateInfo->VkApplicationInfo->pApplicationName",
340 "VUID-VkApplicationInfo-pApplicationName-parameter", pCreateInfo->pApplicationInfo->pApplicationName);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600341 }
342
343 if (pCreateInfo->pApplicationInfo->pEngineName) {
344 validate_string(my_instance_data->report_data, "vkCreateInstance", "pCreateInfo->VkApplicationInfo->pEngineName",
Mark Lobodzinskiebee3552018-05-29 09:55:54 -0600345 "VUID-VkApplicationInfo-pEngineName-parameter", pCreateInfo->pApplicationInfo->pEngineName);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600346 }
347 }
348
349 // Disable the tmp callbacks:
Mark Young6ba8abe2017-11-09 10:37:04 -0700350 if (my_instance_data->num_tmp_debug_messengers > 0) {
351 layer_disable_tmp_debug_messengers(my_instance_data->report_data, my_instance_data->num_tmp_debug_messengers,
352 my_instance_data->tmp_debug_messengers);
353 }
354 if (my_instance_data->num_tmp_report_callbacks > 0) {
355 layer_disable_tmp_report_callbacks(my_instance_data->report_data, my_instance_data->num_tmp_report_callbacks,
356 my_instance_data->tmp_report_callbacks);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600357 }
358 }
359
360 return result;
361}
362
363VKAPI_ATTR void VKAPI_CALL vkDestroyInstance(VkInstance instance, const VkAllocationCallbacks *pAllocator) {
364 // Grab the key before the instance is destroyed.
365 dispatch_key key = get_dispatch_key(instance);
366 bool skip = false;
367 auto instance_data = GetLayerDataPtr(key, instance_layer_data_map);
368
369 // Enable the temporary callback(s) here to catch vkDestroyInstance issues:
370 bool callback_setup = false;
Mark Young6ba8abe2017-11-09 10:37:04 -0700371 if (instance_data->num_tmp_debug_messengers > 0) {
372 if (!layer_enable_tmp_debug_messengers(instance_data->report_data, instance_data->num_tmp_debug_messengers,
373 instance_data->tmp_messenger_create_infos, instance_data->tmp_debug_messengers)) {
374 callback_setup = true;
375 }
376 }
377 if (instance_data->num_tmp_report_callbacks > 0) {
378 if (!layer_enable_tmp_report_callbacks(instance_data->report_data, instance_data->num_tmp_report_callbacks,
379 instance_data->tmp_report_create_infos, instance_data->tmp_report_callbacks)) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600380 callback_setup = true;
381 }
382 }
383
384 skip |= parameter_validation_vkDestroyInstance(instance, pAllocator);
385
386 // Disable and cleanup the temporary callback(s):
387 if (callback_setup) {
Mark Young6ba8abe2017-11-09 10:37:04 -0700388 layer_disable_tmp_debug_messengers(instance_data->report_data, instance_data->num_tmp_debug_messengers,
389 instance_data->tmp_debug_messengers);
390 layer_disable_tmp_report_callbacks(instance_data->report_data, instance_data->num_tmp_report_callbacks,
391 instance_data->tmp_report_callbacks);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600392 }
Mark Young6ba8abe2017-11-09 10:37:04 -0700393 if (instance_data->num_tmp_debug_messengers > 0) {
394 layer_free_tmp_debug_messengers(instance_data->tmp_messenger_create_infos, instance_data->tmp_debug_messengers);
395 instance_data->num_tmp_debug_messengers = 0;
396 }
397 if (instance_data->num_tmp_report_callbacks > 0) {
398 layer_free_tmp_report_callbacks(instance_data->tmp_report_create_infos, instance_data->tmp_report_callbacks);
399 instance_data->num_tmp_report_callbacks = 0;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600400 }
401
402 if (!skip) {
403 instance_data->dispatch_table.DestroyInstance(instance, pAllocator);
404
405 // Clean up logging callback, if any
Mark Young6ba8abe2017-11-09 10:37:04 -0700406 while (instance_data->logging_messenger.size() > 0) {
407 VkDebugUtilsMessengerEXT messenger = instance_data->logging_messenger.back();
408 layer_destroy_messenger_callback(instance_data->report_data, messenger, pAllocator);
409 instance_data->logging_messenger.pop_back();
410 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600411 while (instance_data->logging_callback.size() > 0) {
412 VkDebugReportCallbackEXT callback = instance_data->logging_callback.back();
Mark Young6ba8abe2017-11-09 10:37:04 -0700413 layer_destroy_report_callback(instance_data->report_data, callback, pAllocator);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600414 instance_data->logging_callback.pop_back();
415 }
416
Mark Young6ba8abe2017-11-09 10:37:04 -0700417 layer_debug_utils_destroy_instance(instance_data->report_data);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600418 }
419
420 FreeLayerDataPtr(key, instance_layer_data_map);
421}
422
423VKAPI_ATTR VkResult VKAPI_CALL vkCreateDebugReportCallbackEXT(VkInstance instance,
424 const VkDebugReportCallbackCreateInfoEXT *pCreateInfo,
425 const VkAllocationCallbacks *pAllocator,
426 VkDebugReportCallbackEXT *pMsgCallback) {
427 bool skip = parameter_validation_vkCreateDebugReportCallbackEXT(instance, pCreateInfo, pAllocator, pMsgCallback);
428 if (skip) return VK_ERROR_VALIDATION_FAILED_EXT;
429
430 auto instance_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map);
431 VkResult result = instance_data->dispatch_table.CreateDebugReportCallbackEXT(instance, pCreateInfo, pAllocator, pMsgCallback);
432 if (result == VK_SUCCESS) {
Mark Young6ba8abe2017-11-09 10:37:04 -0700433 result = layer_create_report_callback(instance_data->report_data, false, pCreateInfo, pAllocator, pMsgCallback);
434 // If something happened during this call, clean up the message callback that was created earlier in the lower levels
435 if (VK_SUCCESS != result) {
436 instance_data->dispatch_table.DestroyDebugReportCallbackEXT(instance, *pMsgCallback, pAllocator);
437 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600438 }
439 return result;
440}
441
442VKAPI_ATTR void VKAPI_CALL vkDestroyDebugReportCallbackEXT(VkInstance instance, VkDebugReportCallbackEXT msgCallback,
443 const VkAllocationCallbacks *pAllocator) {
444 bool skip = parameter_validation_vkDestroyDebugReportCallbackEXT(instance, msgCallback, pAllocator);
445 if (!skip) {
446 auto instance_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map);
447 instance_data->dispatch_table.DestroyDebugReportCallbackEXT(instance, msgCallback, pAllocator);
Mark Young6ba8abe2017-11-09 10:37:04 -0700448 layer_destroy_report_callback(instance_data->report_data, msgCallback, pAllocator);
449 }
450}
451
452VKAPI_ATTR VkResult VKAPI_CALL vkCreateDebugUtilsMessengerEXT(VkInstance instance,
453 const VkDebugUtilsMessengerCreateInfoEXT *pCreateInfo,
454 const VkAllocationCallbacks *pAllocator,
455 VkDebugUtilsMessengerEXT *pMessenger) {
456 bool skip = parameter_validation_vkCreateDebugUtilsMessengerEXT(instance, pCreateInfo, pAllocator, pMessenger);
457 if (skip) return VK_ERROR_VALIDATION_FAILED_EXT;
458
459 auto instance_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map);
460 VkResult result = instance_data->dispatch_table.CreateDebugUtilsMessengerEXT(instance, pCreateInfo, pAllocator, pMessenger);
461 if (VK_SUCCESS == result) {
462 result = layer_create_messenger_callback(instance_data->report_data, false, pCreateInfo, pAllocator, pMessenger);
463 // If something happened during this call, clean up the message callback that was created earlier in the lower levels
464 if (VK_SUCCESS != result) {
465 instance_data->dispatch_table.DestroyDebugUtilsMessengerEXT(instance, *pMessenger, pAllocator);
466 }
467 }
468 return result;
469}
470
471VKAPI_ATTR void VKAPI_CALL vkDestroyDebugUtilsMessengerEXT(VkInstance instance, VkDebugUtilsMessengerEXT messenger,
472 const VkAllocationCallbacks *pAllocator) {
473 bool skip = parameter_validation_vkDestroyDebugUtilsMessengerEXT(instance, messenger, pAllocator);
474 if (!skip) {
475 auto instance_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map);
476 instance_data->dispatch_table.DestroyDebugUtilsMessengerEXT(instance, messenger, pAllocator);
477 layer_destroy_messenger_callback(instance_data->report_data, messenger, pAllocator);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600478 }
479}
480
John Zulauf620755c2018-04-16 11:00:43 -0600481template <typename ExtensionState>
482static bool extension_state_by_name(const ExtensionState &extensions, const char *extension_name) {
483 if (!extension_name) return false; // null strings specify nothing
484 auto info = ExtensionState::get_info(extension_name);
485 bool state = info.state ? extensions.*(info.state) : false; // unknown extensions can't be enabled in extension struct
486 return state;
487}
488
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600489static bool ValidateDeviceCreateInfo(instance_layer_data *instance_data, VkPhysicalDevice physicalDevice,
John Zulauf620755c2018-04-16 11:00:43 -0600490 const VkDeviceCreateInfo *pCreateInfo, const DeviceExtensions &extensions) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600491 bool skip = false;
John Zulauf620755c2018-04-16 11:00:43 -0600492 bool maint1 = false;
493 bool negative_viewport = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600494
495 if ((pCreateInfo->enabledLayerCount > 0) && (pCreateInfo->ppEnabledLayerNames != NULL)) {
496 for (size_t i = 0; i < pCreateInfo->enabledLayerCount; i++) {
497 skip |= validate_string(instance_data->report_data, "vkCreateDevice", "pCreateInfo->ppEnabledLayerNames",
Mark Lobodzinskiebee3552018-05-29 09:55:54 -0600498 "VUID-VkDeviceCreateInfo-ppEnabledLayerNames-parameter", pCreateInfo->ppEnabledLayerNames[i]);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600499 }
500 }
501
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600502 if ((pCreateInfo->enabledExtensionCount > 0) && (pCreateInfo->ppEnabledExtensionNames != NULL)) {
John Zulauf620755c2018-04-16 11:00:43 -0600503 maint1 = extension_state_by_name(extensions, VK_KHR_MAINTENANCE1_EXTENSION_NAME);
504 negative_viewport = extension_state_by_name(extensions, VK_AMD_NEGATIVE_VIEWPORT_HEIGHT_EXTENSION_NAME);
505
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600506 for (size_t i = 0; i < pCreateInfo->enabledExtensionCount; i++) {
507 skip |= validate_string(instance_data->report_data, "vkCreateDevice", "pCreateInfo->ppEnabledExtensionNames",
Mark Lobodzinskiebee3552018-05-29 09:55:54 -0600508 "VUID-VkDeviceCreateInfo-ppEnabledExtensionNames-parameter",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600509 pCreateInfo->ppEnabledExtensionNames[i]);
Dave Houlton413a6782018-05-22 13:01:54 -0600510 skip |= validate_extension_reqs(instance_data, extensions, "VUID-vkCreateDevice-ppEnabledExtensionNames-01387",
511 "device", pCreateInfo->ppEnabledExtensionNames[i]);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600512 }
513 }
514
515 if (maint1 && negative_viewport) {
516 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600517 "VUID-VkDeviceCreateInfo-ppEnabledExtensionNames-00374",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600518 "VkDeviceCreateInfo->ppEnabledExtensionNames must not simultaneously include VK_KHR_maintenance1 and "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600519 "VK_AMD_negative_viewport_height.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600520 }
521
522 if (pCreateInfo->pNext != NULL && pCreateInfo->pEnabledFeatures) {
523 // Check for get_physical_device_properties2 struct
John Zulaufde972ac2017-10-26 12:07:05 -0600524 const auto *features2 = lvl_find_in_chain<VkPhysicalDeviceFeatures2KHR>(pCreateInfo->pNext);
525 if (features2) {
526 // Cannot include VkPhysicalDeviceFeatures2KHR and have non-null pEnabledFeatures
527 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600528 kVUID_PVError_InvalidUsage,
John Zulaufde972ac2017-10-26 12:07:05 -0600529 "VkDeviceCreateInfo->pNext includes a VkPhysicalDeviceFeatures2KHR struct when "
530 "pCreateInfo->pEnabledFeatures is non-NULL.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600531 }
532 }
533
534 // Validate pCreateInfo->pQueueCreateInfos
535 if (pCreateInfo->pQueueCreateInfos) {
536 std::unordered_set<uint32_t> set;
537
538 for (uint32_t i = 0; i < pCreateInfo->queueCreateInfoCount; ++i) {
539 const uint32_t requested_queue_family = pCreateInfo->pQueueCreateInfos[i].queueFamilyIndex;
540 if (requested_queue_family == VK_QUEUE_FAMILY_IGNORED) {
541 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT,
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600542 VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, HandleToUint64(physicalDevice),
Dave Houlton413a6782018-05-22 13:01:54 -0600543 "VUID-VkDeviceQueueCreateInfo-queueFamilyIndex-00381",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600544 "vkCreateDevice: pCreateInfo->pQueueCreateInfos[%" PRIu32
Dave Houltona9df0ce2018-02-07 10:51:23 -0700545 "].queueFamilyIndex is VK_QUEUE_FAMILY_IGNORED, but it is required to provide a valid queue family "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600546 "index value.",
547 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600548 } else if (set.count(requested_queue_family)) {
549 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT,
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600550 VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, HandleToUint64(physicalDevice),
Dave Houlton413a6782018-05-22 13:01:54 -0600551 "VUID-VkDeviceCreateInfo-queueFamilyIndex-00372",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600552 "vkCreateDevice: pCreateInfo->pQueueCreateInfos[%" PRIu32 "].queueFamilyIndex (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600553 ") is not unique within pCreateInfo->pQueueCreateInfos array.",
554 i, requested_queue_family);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600555 } else {
556 set.insert(requested_queue_family);
557 }
558
559 if (pCreateInfo->pQueueCreateInfos[i].pQueuePriorities != nullptr) {
560 for (uint32_t j = 0; j < pCreateInfo->pQueueCreateInfos[i].queueCount; ++j) {
561 const float queue_priority = pCreateInfo->pQueueCreateInfos[i].pQueuePriorities[j];
562 if (!(queue_priority >= 0.f) || !(queue_priority <= 1.f)) {
563 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT,
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600564 VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, HandleToUint64(physicalDevice),
Dave Houlton413a6782018-05-22 13:01:54 -0600565 "VUID-VkDeviceQueueCreateInfo-pQueuePriorities-00383",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600566 "vkCreateDevice: pCreateInfo->pQueueCreateInfos[%" PRIu32 "].pQueuePriorities[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600567 "] (=%f) is not between 0 and 1 (inclusive).",
568 i, j, queue_priority);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600569 }
570 }
571 }
572 }
573 }
574
575 return skip;
576}
577
578VKAPI_ATTR VkResult VKAPI_CALL vkCreateDevice(VkPhysicalDevice physicalDevice, const VkDeviceCreateInfo *pCreateInfo,
579 const VkAllocationCallbacks *pAllocator, VkDevice *pDevice) {
580 // NOTE: Don't validate physicalDevice or any dispatchable object as the first parameter. We couldn't get here if it was wrong!
581
582 VkResult result = VK_ERROR_VALIDATION_FAILED_EXT;
583 bool skip = false;
584 auto my_instance_data = GetLayerDataPtr(get_dispatch_key(physicalDevice), instance_layer_data_map);
585 assert(my_instance_data != nullptr);
John Zulauf620755c2018-04-16 11:00:43 -0600586
587 // Query and save physical device limits for this device, needed for validation
588 VkPhysicalDeviceProperties device_properties = {};
589 my_instance_data->dispatch_table.GetPhysicalDeviceProperties(physicalDevice, &device_properties);
590
John Zulauf1909e6a2018-09-05 11:43:11 -0600591 // Setup the validation tables based on the application API version from the instance and the capabilities of the device driver.
592 uint32_t effective_api_version = std::min(device_properties.apiVersion, my_instance_data->api_version);
John Zulauf620755c2018-04-16 11:00:43 -0600593 DeviceExtensions extensions;
John Zulauf1909e6a2018-09-05 11:43:11 -0600594 uint32_t api_version = extensions.InitFromDeviceCreateInfo(&my_instance_data->extensions, effective_api_version, pCreateInfo);
John Zulauf620755c2018-04-16 11:00:43 -0600595
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600596 std::unique_lock<std::mutex> lock(global_lock);
597
598 skip |= parameter_validation_vkCreateDevice(physicalDevice, pCreateInfo, pAllocator, pDevice);
599
John Zulauf620755c2018-04-16 11:00:43 -0600600 if (pCreateInfo != NULL) skip |= ValidateDeviceCreateInfo(my_instance_data, physicalDevice, pCreateInfo, extensions);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600601
602 if (!skip) {
603 VkLayerDeviceCreateInfo *chain_info = get_chain_info(pCreateInfo, VK_LAYER_LINK_INFO);
604 assert(chain_info != nullptr);
605 assert(chain_info->u.pLayerInfo != nullptr);
606
607 PFN_vkGetInstanceProcAddr fpGetInstanceProcAddr = chain_info->u.pLayerInfo->pfnNextGetInstanceProcAddr;
608 PFN_vkGetDeviceProcAddr fpGetDeviceProcAddr = chain_info->u.pLayerInfo->pfnNextGetDeviceProcAddr;
609 PFN_vkCreateDevice fpCreateDevice = (PFN_vkCreateDevice)fpGetInstanceProcAddr(my_instance_data->instance, "vkCreateDevice");
610 if (fpCreateDevice == NULL) {
611 return VK_ERROR_INITIALIZATION_FAILED;
612 }
613
614 // Advance the link info for the next element on the chain
615 chain_info->u.pLayerInfo = chain_info->u.pLayerInfo->pNext;
616
617 lock.unlock();
618
619 result = fpCreateDevice(physicalDevice, pCreateInfo, pAllocator, pDevice);
620
621 lock.lock();
622
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600623 if (result == VK_SUCCESS) {
624 layer_data *my_device_data = GetLayerDataPtr(get_dispatch_key(*pDevice), layer_data_map);
625 assert(my_device_data != nullptr);
626
Mark Young6ba8abe2017-11-09 10:37:04 -0700627 my_device_data->report_data = layer_debug_utils_create_device(my_instance_data->report_data, *pDevice);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600628 layer_init_device_dispatch_table(*pDevice, &my_device_data->dispatch_table, fpGetDeviceProcAddr);
629
John Zulauf620755c2018-04-16 11:00:43 -0600630 my_device_data->api_version = api_version;
631 my_device_data->extensions = extensions;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600632
633 // Store createdevice data
634 if ((pCreateInfo != nullptr) && (pCreateInfo->pQueueCreateInfos != nullptr)) {
635 for (uint32_t i = 0; i < pCreateInfo->queueCreateInfoCount; ++i) {
636 my_device_data->queueFamilyIndexMap.insert(std::make_pair(pCreateInfo->pQueueCreateInfos[i].queueFamilyIndex,
637 pCreateInfo->pQueueCreateInfos[i].queueCount));
638 }
639 }
640
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600641 memcpy(&my_device_data->device_limits, &device_properties.limits, sizeof(VkPhysicalDeviceLimits));
642 my_device_data->physical_device = physicalDevice;
643 my_device_data->device = *pDevice;
644
645 // Save app-enabled features in this device's layer_data structure
John Zulauf1bde5bb2017-10-18 18:21:23 -0600646 // The enabled features can come from either pEnabledFeatures, or from the pNext chain
647 const VkPhysicalDeviceFeatures *enabled_features_found = pCreateInfo->pEnabledFeatures;
648 if ((nullptr == enabled_features_found) && my_device_data->extensions.vk_khr_get_physical_device_properties_2) {
John Zulaufde972ac2017-10-26 12:07:05 -0600649 const auto *features2 = lvl_find_in_chain<VkPhysicalDeviceFeatures2KHR>(pCreateInfo->pNext);
650 if (features2) {
651 enabled_features_found = &(features2->features);
John Zulauf1bde5bb2017-10-18 18:21:23 -0600652 }
653 }
654 if (enabled_features_found) {
Dave Houltonb3bbec72018-01-17 10:13:33 -0700655 my_device_data->physical_device_features = *enabled_features_found;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600656 } else {
657 memset(&my_device_data->physical_device_features, 0, sizeof(VkPhysicalDeviceFeatures));
658 }
659 }
660 }
661
662 return result;
663}
664
665VKAPI_ATTR void VKAPI_CALL vkDestroyDevice(VkDevice device, const VkAllocationCallbacks *pAllocator) {
666 dispatch_key key = get_dispatch_key(device);
667 bool skip = false;
668 layer_data *device_data = GetLayerDataPtr(key, layer_data_map);
669 {
670 std::unique_lock<std::mutex> lock(global_lock);
671 skip |= parameter_validation_vkDestroyDevice(device, pAllocator);
672 }
673
674 if (!skip) {
Mark Young6ba8abe2017-11-09 10:37:04 -0700675 layer_debug_utils_destroy_device(device);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600676 device_data->dispatch_table.DestroyDevice(device, pAllocator);
677 }
678 FreeLayerDataPtr(key, layer_data_map);
679}
680
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600681bool pv_vkGetDeviceQueue(VkDevice device, uint32_t queueFamilyIndex, uint32_t queueIndex, VkQueue *pQueue) {
682 bool skip = false;
683 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
684
Dave Houlton413a6782018-05-22 13:01:54 -0600685 skip |= ValidateDeviceQueueFamily(device_data, queueFamilyIndex, "vkGetDeviceQueue", "queueFamilyIndex",
686 "VUID-vkGetDeviceQueue-queueFamilyIndex-00384");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600687 const auto &queue_data = device_data->queueFamilyIndexMap.find(queueFamilyIndex);
688 if (queue_data != device_data->queueFamilyIndexMap.end() && queue_data->second <= queueIndex) {
689 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -0600690 HandleToUint64(device), "VUID-vkGetDeviceQueue-queueIndex-00385",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600691 "vkGetDeviceQueue: queueIndex (=%" PRIu32
Dave Houltona9df0ce2018-02-07 10:51:23 -0700692 ") is not less than the number of queues requested from queueFamilyIndex (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600693 ") when the device was created (i.e. is not less than %" PRIu32 ").",
694 queueIndex, queueFamilyIndex, queue_data->second);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600695 }
696 return skip;
697}
698
699VKAPI_ATTR VkResult VKAPI_CALL vkCreateCommandPool(VkDevice device, const VkCommandPoolCreateInfo *pCreateInfo,
700 const VkAllocationCallbacks *pAllocator, VkCommandPool *pCommandPool) {
701 layer_data *local_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
702 bool skip = false;
703 VkResult result = VK_ERROR_VALIDATION_FAILED_EXT;
704 std::unique_lock<std::mutex> lock(global_lock);
705
706 skip |= ValidateDeviceQueueFamily(local_data, pCreateInfo->queueFamilyIndex, "vkCreateCommandPool",
Dave Houlton341c0052018-06-21 15:00:45 -0600707 "pCreateInfo->queueFamilyIndex", "VUID-vkCreateCommandPool-queueFamilyIndex-01937");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600708
709 skip |= parameter_validation_vkCreateCommandPool(device, pCreateInfo, pAllocator, pCommandPool);
710
711 lock.unlock();
712 if (!skip) {
713 result = local_data->dispatch_table.CreateCommandPool(device, pCreateInfo, pAllocator, pCommandPool);
714 }
715 return result;
716}
717
718VKAPI_ATTR VkResult VKAPI_CALL vkCreateQueryPool(VkDevice device, const VkQueryPoolCreateInfo *pCreateInfo,
719 const VkAllocationCallbacks *pAllocator, VkQueryPool *pQueryPool) {
720 VkResult result = VK_ERROR_VALIDATION_FAILED_EXT;
721 bool skip = false;
722 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
723
724 skip |= parameter_validation_vkCreateQueryPool(device, pCreateInfo, pAllocator, pQueryPool);
725
726 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
727 if (pCreateInfo != nullptr) {
728 // If queryType is VK_QUERY_TYPE_PIPELINE_STATISTICS, pipelineStatistics must be a valid combination of
729 // VkQueryPipelineStatisticFlagBits values
730 if ((pCreateInfo->queryType == VK_QUERY_TYPE_PIPELINE_STATISTICS) && (pCreateInfo->pipelineStatistics != 0) &&
731 ((pCreateInfo->pipelineStatistics & (~AllVkQueryPipelineStatisticFlagBits)) != 0)) {
732 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600733 "VUID-VkQueryPoolCreateInfo-queryType-00792",
Dave Houltona9df0ce2018-02-07 10:51:23 -0700734 "vkCreateQueryPool(): if pCreateInfo->queryType is VK_QUERY_TYPE_PIPELINE_STATISTICS, "
735 "pCreateInfo->pipelineStatistics must be a valid combination of VkQueryPipelineStatisticFlagBits "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600736 "values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600737 }
738 }
739 if (!skip) {
740 result = device_data->dispatch_table.CreateQueryPool(device, pCreateInfo, pAllocator, pQueryPool);
741 }
742 return result;
743}
744
Petr Krause91f7a12017-12-14 20:57:36 +0100745VKAPI_ATTR VkResult VKAPI_CALL vkCreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo,
746 const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass) {
747 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
748 bool skip = false;
749 VkResult result = VK_ERROR_VALIDATION_FAILED_EXT;
750
751 {
752 std::unique_lock<std::mutex> lock(global_lock);
753 skip |= parameter_validation_vkCreateRenderPass(device, pCreateInfo, pAllocator, pRenderPass);
754
Dave Houltonb3bbec72018-01-17 10:13:33 -0700755 typedef bool (*PFN_manual_vkCreateRenderPass)(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo,
756 const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass);
Petr Krause91f7a12017-12-14 20:57:36 +0100757 PFN_manual_vkCreateRenderPass custom_func = (PFN_manual_vkCreateRenderPass)custom_functions["vkCreateRenderPass"];
758 if (custom_func != nullptr) {
759 skip |= custom_func(device, pCreateInfo, pAllocator, pRenderPass);
760 }
761 }
762
763 if (!skip) {
764 result = device_data->dispatch_table.CreateRenderPass(device, pCreateInfo, pAllocator, pRenderPass);
765
766 // track the state necessary for checking vkCreateGraphicsPipeline (subpass usage of depth and color attachments)
767 if (result == VK_SUCCESS) {
768 std::unique_lock<std::mutex> lock(global_lock);
769 const auto renderPass = *pRenderPass;
770 auto &renderpass_state = device_data->renderpasses_states[renderPass];
771
772 for (uint32_t subpass = 0; subpass < pCreateInfo->subpassCount; ++subpass) {
773 bool uses_color = false;
774 for (uint32_t i = 0; i < pCreateInfo->pSubpasses[subpass].colorAttachmentCount && !uses_color; ++i)
775 if (pCreateInfo->pSubpasses[subpass].pColorAttachments[i].attachment != VK_ATTACHMENT_UNUSED) uses_color = true;
776
777 bool uses_depthstencil = false;
778 if (pCreateInfo->pSubpasses[subpass].pDepthStencilAttachment)
779 if (pCreateInfo->pSubpasses[subpass].pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED)
780 uses_depthstencil = true;
781
782 if (uses_color) renderpass_state.subpasses_using_color_attachment.insert(subpass);
783 if (uses_depthstencil) renderpass_state.subpasses_using_depthstencil_attachment.insert(subpass);
784 }
785 }
786 }
787 return result;
788}
789
790VKAPI_ATTR void VKAPI_CALL vkDestroyRenderPass(VkDevice device, VkRenderPass renderPass, const VkAllocationCallbacks *pAllocator) {
791 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
792 bool skip = false;
793
794 {
795 std::unique_lock<std::mutex> lock(global_lock);
796 skip |= parameter_validation_vkDestroyRenderPass(device, renderPass, pAllocator);
797
Dave Houltonb3bbec72018-01-17 10:13:33 -0700798 typedef bool (*PFN_manual_vkDestroyRenderPass)(VkDevice device, VkRenderPass renderPass,
799 const VkAllocationCallbacks *pAllocator);
Petr Krause91f7a12017-12-14 20:57:36 +0100800 PFN_manual_vkDestroyRenderPass custom_func = (PFN_manual_vkDestroyRenderPass)custom_functions["vkDestroyRenderPass"];
801 if (custom_func != nullptr) {
802 skip |= custom_func(device, renderPass, pAllocator);
803 }
804 }
805
806 if (!skip) {
807 device_data->dispatch_table.DestroyRenderPass(device, renderPass, pAllocator);
808
809 // track the state necessary for checking vkCreateGraphicsPipeline (subpass usage of depth and color attachments)
810 {
811 std::unique_lock<std::mutex> lock(global_lock);
812 device_data->renderpasses_states.erase(renderPass);
813 }
814 }
815}
816
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600817bool pv_vkCreateBuffer(VkDevice device, const VkBufferCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
818 VkBuffer *pBuffer) {
819 bool skip = false;
820 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
821 debug_report_data *report_data = device_data->report_data;
822
Mark Lobodzinski88529492018-04-01 10:38:15 -0600823 const LogMiscParams log_misc{report_data, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, VK_NULL_HANDLE, "vkCreateBuffer"};
Petr Krause5c37652018-01-05 04:05:12 +0100824
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600825 if (pCreateInfo != nullptr) {
Dave Houlton413a6782018-05-22 13:01:54 -0600826 skip |= ValidateGreaterThanZero(pCreateInfo->size, "pCreateInfo->size", "VUID-VkBufferCreateInfo-size-00912", log_misc);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600827
828 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
829 if (pCreateInfo->sharingMode == VK_SHARING_MODE_CONCURRENT) {
830 // If sharingMode is VK_SHARING_MODE_CONCURRENT, queueFamilyIndexCount must be greater than 1
831 if (pCreateInfo->queueFamilyIndexCount <= 1) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600832 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600833 "VUID-VkBufferCreateInfo-sharingMode-00914",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600834 "vkCreateBuffer: if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600835 "pCreateInfo->queueFamilyIndexCount must be greater than 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600836 }
837
838 // If sharingMode is VK_SHARING_MODE_CONCURRENT, pQueueFamilyIndices must be a pointer to an array of
839 // queueFamilyIndexCount uint32_t values
840 if (pCreateInfo->pQueueFamilyIndices == nullptr) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600841 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600842 "VUID-VkBufferCreateInfo-sharingMode-00913",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600843 "vkCreateBuffer: if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
844 "pCreateInfo->pQueueFamilyIndices must be a pointer to an array of "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600845 "pCreateInfo->queueFamilyIndexCount uint32_t values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600846 } else {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600847 skip |= ValidateQueueFamilies(device_data, pCreateInfo->queueFamilyIndexCount, pCreateInfo->pQueueFamilyIndices,
Dave Houlton413a6782018-05-22 13:01:54 -0600848 "vkCreateBuffer", "pCreateInfo->pQueueFamilyIndices", kVUID_PVError_InvalidUsage,
849 kVUID_PVError_InvalidUsage, false);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600850 }
851 }
852
853 // If flags contains VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT or VK_BUFFER_CREATE_SPARSE_ALIASED_BIT, it must also contain
854 // VK_BUFFER_CREATE_SPARSE_BINDING_BIT
855 if (((pCreateInfo->flags & (VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT | VK_BUFFER_CREATE_SPARSE_ALIASED_BIT)) != 0) &&
856 ((pCreateInfo->flags & VK_BUFFER_CREATE_SPARSE_BINDING_BIT) != VK_BUFFER_CREATE_SPARSE_BINDING_BIT)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600857 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600858 "VUID-VkBufferCreateInfo-flags-00918",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600859 "vkCreateBuffer: if pCreateInfo->flags contains VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT or "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600860 "VK_BUFFER_CREATE_SPARSE_ALIASED_BIT, it must also contain VK_BUFFER_CREATE_SPARSE_BINDING_BIT.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600861 }
862 }
863
864 return skip;
865}
866
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600867bool pv_vkCreateImage(VkDevice device, const VkImageCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
868 VkImage *pImage) {
869 bool skip = false;
870 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
871 debug_report_data *report_data = device_data->report_data;
872
Mark Lobodzinski88529492018-04-01 10:38:15 -0600873 const LogMiscParams log_misc{report_data, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, VK_NULL_HANDLE, "vkCreateImage"};
Petr Krause5c37652018-01-05 04:05:12 +0100874
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600875 if (pCreateInfo != nullptr) {
876 if ((device_data->physical_device_features.textureCompressionETC2 == false) &&
877 FormatIsCompressed_ETC2_EAC(pCreateInfo->format)) {
Dave Houlton413a6782018-05-22 13:01:54 -0600878 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
879 kVUID_PVError_DeviceFeature,
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600880 "vkCreateImage(): Attempting to create VkImage with format %s. The textureCompressionETC2 feature is "
881 "not enabled: neither ETC2 nor EAC formats can be used to create images.",
882 string_VkFormat(pCreateInfo->format));
883 }
884
885 if ((device_data->physical_device_features.textureCompressionASTC_LDR == false) &&
886 FormatIsCompressed_ASTC_LDR(pCreateInfo->format)) {
Dave Houlton413a6782018-05-22 13:01:54 -0600887 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
888 kVUID_PVError_DeviceFeature,
Dave Houltona9df0ce2018-02-07 10:51:23 -0700889 "vkCreateImage(): Attempting to create VkImage with format %s. The textureCompressionASTC_LDR feature "
890 "is not enabled: ASTC formats cannot be used to create images.",
891 string_VkFormat(pCreateInfo->format));
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600892 }
893
894 if ((device_data->physical_device_features.textureCompressionBC == false) && FormatIsCompressed_BC(pCreateInfo->format)) {
Dave Houlton413a6782018-05-22 13:01:54 -0600895 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
896 kVUID_PVError_DeviceFeature,
Dave Houltona9df0ce2018-02-07 10:51:23 -0700897 "vkCreateImage(): Attempting to create VkImage with format %s. The textureCompressionBC feature is not "
898 "enabled: BC compressed formats cannot be used to create images.",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600899 string_VkFormat(pCreateInfo->format));
900 }
901
902 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
903 if (pCreateInfo->sharingMode == VK_SHARING_MODE_CONCURRENT) {
904 // If sharingMode is VK_SHARING_MODE_CONCURRENT, queueFamilyIndexCount must be greater than 1
905 if (pCreateInfo->queueFamilyIndexCount <= 1) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600906 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600907 "VUID-VkImageCreateInfo-sharingMode-00942",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600908 "vkCreateImage(): if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600909 "pCreateInfo->queueFamilyIndexCount must be greater than 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600910 }
911
912 // If sharingMode is VK_SHARING_MODE_CONCURRENT, pQueueFamilyIndices must be a pointer to an array of
913 // queueFamilyIndexCount uint32_t values
914 if (pCreateInfo->pQueueFamilyIndices == nullptr) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600915 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600916 "VUID-VkImageCreateInfo-sharingMode-00941",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600917 "vkCreateImage(): if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
918 "pCreateInfo->pQueueFamilyIndices must be a pointer to an array of "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600919 "pCreateInfo->queueFamilyIndexCount uint32_t values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600920 } else {
Dave Houlton413a6782018-05-22 13:01:54 -0600921 skip |= ValidateQueueFamilies(device_data, pCreateInfo->queueFamilyIndexCount, pCreateInfo->pQueueFamilyIndices,
922 "vkCreateImage", "pCreateInfo->pQueueFamilyIndices", kVUID_PVError_InvalidUsage,
923 kVUID_PVError_InvalidUsage, false);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600924 }
925 }
926
Dave Houlton413a6782018-05-22 13:01:54 -0600927 skip |= ValidateGreaterThanZero(pCreateInfo->extent.width, "pCreateInfo->extent.width",
928 "VUID-VkImageCreateInfo-extent-00944", log_misc);
929 skip |= ValidateGreaterThanZero(pCreateInfo->extent.height, "pCreateInfo->extent.height",
930 "VUID-VkImageCreateInfo-extent-00945", log_misc);
931 skip |= ValidateGreaterThanZero(pCreateInfo->extent.depth, "pCreateInfo->extent.depth",
932 "VUID-VkImageCreateInfo-extent-00946", log_misc);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600933
Dave Houlton413a6782018-05-22 13:01:54 -0600934 skip |= ValidateGreaterThanZero(pCreateInfo->mipLevels, "pCreateInfo->mipLevels", "VUID-VkImageCreateInfo-mipLevels-00947",
935 log_misc);
936 skip |= ValidateGreaterThanZero(pCreateInfo->arrayLayers, "pCreateInfo->arrayLayers",
937 "VUID-VkImageCreateInfo-arrayLayers-00948", log_misc);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600938
Dave Houlton130c0212018-01-29 13:39:56 -0700939 // InitialLayout must be PREINITIALIZED or UNDEFINED
Dave Houltone19e20d2018-02-02 16:32:41 -0700940 if ((pCreateInfo->initialLayout != VK_IMAGE_LAYOUT_UNDEFINED) &&
941 (pCreateInfo->initialLayout != VK_IMAGE_LAYOUT_PREINITIALIZED)) {
942 skip |= log_msg(
Dave Houlton413a6782018-05-22 13:01:54 -0600943 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
944 "VUID-VkImageCreateInfo-initialLayout-00993",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600945 "vkCreateImage(): initialLayout is %s, must be VK_IMAGE_LAYOUT_UNDEFINED or VK_IMAGE_LAYOUT_PREINITIALIZED.",
946 string_VkImageLayout(pCreateInfo->initialLayout));
Dave Houlton130c0212018-01-29 13:39:56 -0700947 }
948
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600949 // If imageType is VK_IMAGE_TYPE_1D, both extent.height and extent.depth must be 1
Petr Kraus3ac9e812018-03-13 12:31:08 +0100950 if ((pCreateInfo->imageType == VK_IMAGE_TYPE_1D) &&
951 ((pCreateInfo->extent.height != 1) || (pCreateInfo->extent.depth != 1))) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600952 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600953 "VUID-VkImageCreateInfo-imageType-00956",
Dave Houltona9df0ce2018-02-07 10:51:23 -0700954 "vkCreateImage(): if pCreateInfo->imageType is VK_IMAGE_TYPE_1D, both pCreateInfo->extent.height and "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600955 "pCreateInfo->extent.depth must be 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600956 }
957
958 if (pCreateInfo->imageType == VK_IMAGE_TYPE_2D) {
Petr Kraus3f433212018-03-13 12:31:27 +0100959 if (pCreateInfo->flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) {
960 if (pCreateInfo->extent.width != pCreateInfo->extent.height) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600961 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -0600962 VK_NULL_HANDLE, "VUID-VkImageCreateInfo-imageType-00954",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600963 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT, but "
964 "pCreateInfo->extent.width (=%" PRIu32 ") and pCreateInfo->extent.height (=%" PRIu32
965 ") are not equal.",
966 pCreateInfo->extent.width, pCreateInfo->extent.height);
Petr Kraus3f433212018-03-13 12:31:27 +0100967 }
968
969 if (pCreateInfo->arrayLayers < 6) {
970 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -0600971 VK_NULL_HANDLE, "VUID-VkImageCreateInfo-imageType-00954",
Petr Kraus3f433212018-03-13 12:31:27 +0100972 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT, but "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600973 "pCreateInfo->arrayLayers (=%" PRIu32 ") is not greater than or equal to 6.",
974 pCreateInfo->arrayLayers);
Petr Kraus3f433212018-03-13 12:31:27 +0100975 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600976 }
977
978 if (pCreateInfo->extent.depth != 1) {
Mark Lobodzinski88529492018-04-01 10:38:15 -0600979 skip |=
980 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600981 "VUID-VkImageCreateInfo-imageType-00957",
Mark Lobodzinski88529492018-04-01 10:38:15 -0600982 "vkCreateImage(): if pCreateInfo->imageType is VK_IMAGE_TYPE_2D, pCreateInfo->extent.depth must be 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600983 }
984 }
985
Dave Houlton130c0212018-01-29 13:39:56 -0700986 // 3D image may have only 1 layer
987 if ((pCreateInfo->imageType == VK_IMAGE_TYPE_3D) && (pCreateInfo->arrayLayers != 1)) {
Mark Lobodzinski88529492018-04-01 10:38:15 -0600988 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600989 "VUID-VkImageCreateInfo-imageType-00961",
Mark Lobodzinski88529492018-04-01 10:38:15 -0600990 "vkCreateImage(): if pCreateInfo->imageType is VK_IMAGE_TYPE_3D, pCreateInfo->arrayLayers must be 1.");
Dave Houlton130c0212018-01-29 13:39:56 -0700991 }
992
993 // If multi-sample, validate type, usage, tiling and mip levels.
994 if ((pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT) &&
995 ((pCreateInfo->imageType != VK_IMAGE_TYPE_2D) || (pCreateInfo->flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) ||
996 (pCreateInfo->tiling != VK_IMAGE_TILING_OPTIMAL) || (pCreateInfo->mipLevels != 1))) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600997 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600998 "VUID-VkImageCreateInfo-samples-00962",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600999 "vkCreateImage(): Multi-sample image with incompatible type, usage, tiling, or mips.");
Dave Houlton130c0212018-01-29 13:39:56 -07001000 }
1001
1002 if (0 != (pCreateInfo->usage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT)) {
1003 VkImageUsageFlags legal_flags = (VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT | VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT |
1004 VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT);
1005 // At least one of the legal attachment bits must be set
1006 if (0 == (pCreateInfo->usage & legal_flags)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001007 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001008 "VUID-VkImageCreateInfo-usage-00966",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001009 "vkCreateImage(): Transient attachment image without a compatible attachment flag set.");
Dave Houlton130c0212018-01-29 13:39:56 -07001010 }
1011 // No flags other than the legal attachment bits may be set
1012 legal_flags |= VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT;
1013 if (0 != (pCreateInfo->usage & ~legal_flags)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001014 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001015 "VUID-VkImageCreateInfo-usage-00963",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001016 "vkCreateImage(): Transient attachment image with incompatible usage flags set.");
Dave Houlton130c0212018-01-29 13:39:56 -07001017 }
1018 }
1019
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001020 // mipLevels must be less than or equal to floor(log2(max(extent.width,extent.height,extent.depth)))+1
1021 uint32_t maxDim = std::max(std::max(pCreateInfo->extent.width, pCreateInfo->extent.height), pCreateInfo->extent.depth);
Petr Krause5c37652018-01-05 04:05:12 +01001022 if (maxDim > 0 && pCreateInfo->mipLevels > (floor(log2(maxDim)) + 1)) {
Dave Houlton413a6782018-05-22 13:01:54 -06001023 skip |=
1024 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1025 "VUID-VkImageCreateInfo-mipLevels-00958",
1026 "vkCreateImage(): pCreateInfo->mipLevels must be less than or equal to "
1027 "floor(log2(max(pCreateInfo->extent.width, pCreateInfo->extent.height, pCreateInfo->extent.depth)))+1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001028 }
1029
Mark Lobodzinski69259c52018-09-18 15:14:58 -06001030 if ((pCreateInfo->flags & VK_IMAGE_CREATE_2D_ARRAY_COMPATIBLE_BIT) && (pCreateInfo->imageType != VK_IMAGE_TYPE_3D)) {
1031 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, VK_NULL_HANDLE,
1032 "VUID-VkImageCreateInfo-flags-00950",
1033 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_2D_ARRAY_COMPATIBLE_BIT but "
1034 "pCreateInfo->imageType is not VK_IMAGE_TYPE_3D.");
1035 }
1036
Petr Krausb6f97802018-03-13 12:31:39 +01001037 if ((pCreateInfo->flags & VK_IMAGE_CREATE_SPARSE_BINDING_BIT) && (!device_data->physical_device_features.sparseBinding)) {
1038 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, VK_NULL_HANDLE,
Dave Houlton413a6782018-05-22 13:01:54 -06001039 "VUID-VkImageCreateInfo-flags-00969",
Petr Krausb6f97802018-03-13 12:31:39 +01001040 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_SPARSE_BINDING_BIT, but the "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001041 "VkPhysicalDeviceFeatures::sparseBinding feature is disabled.");
Petr Krausb6f97802018-03-13 12:31:39 +01001042 }
1043
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001044 // If flags contains VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT or VK_IMAGE_CREATE_SPARSE_ALIASED_BIT, it must also contain
1045 // VK_IMAGE_CREATE_SPARSE_BINDING_BIT
1046 if (((pCreateInfo->flags & (VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT | VK_IMAGE_CREATE_SPARSE_ALIASED_BIT)) != 0) &&
1047 ((pCreateInfo->flags & VK_IMAGE_CREATE_SPARSE_BINDING_BIT) != VK_IMAGE_CREATE_SPARSE_BINDING_BIT)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001048 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001049 "VUID-VkImageCreateInfo-flags-00987",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001050 "vkCreateImage: if pCreateInfo->flags contains VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT or "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001051 "VK_IMAGE_CREATE_SPARSE_ALIASED_BIT, it must also contain VK_IMAGE_CREATE_SPARSE_BINDING_BIT.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001052 }
1053
1054 // Check for combinations of attributes that are incompatible with having VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT set
1055 if ((pCreateInfo->flags & VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT) != 0) {
1056 // Linear tiling is unsupported
1057 if (VK_IMAGE_TILING_LINEAR == pCreateInfo->tiling) {
Dave Houlton413a6782018-05-22 13:01:54 -06001058 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1059 kVUID_PVError_InvalidUsage,
1060 "vkCreateImage: if pCreateInfo->flags contains VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT then image "
1061 "tiling of VK_IMAGE_TILING_LINEAR is not supported");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001062 }
1063
1064 // Sparse 1D image isn't valid
1065 if (VK_IMAGE_TYPE_1D == pCreateInfo->imageType) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001066 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001067 "VUID-VkImageCreateInfo-imageType-00970",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001068 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 1D image.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001069 }
1070
1071 // Sparse 2D image when device doesn't support it
1072 if ((VK_FALSE == device_data->physical_device_features.sparseResidencyImage2D) &&
1073 (VK_IMAGE_TYPE_2D == pCreateInfo->imageType)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001074 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001075 "VUID-VkImageCreateInfo-imageType-00971",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001076 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 2D image if corresponding "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001077 "feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001078 }
1079
1080 // Sparse 3D image when device doesn't support it
1081 if ((VK_FALSE == device_data->physical_device_features.sparseResidencyImage3D) &&
1082 (VK_IMAGE_TYPE_3D == pCreateInfo->imageType)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001083 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001084 "VUID-VkImageCreateInfo-imageType-00972",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001085 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 3D image if corresponding "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001086 "feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001087 }
1088
1089 // Multi-sample 2D image when device doesn't support it
1090 if (VK_IMAGE_TYPE_2D == pCreateInfo->imageType) {
1091 if ((VK_FALSE == device_data->physical_device_features.sparseResidency2Samples) &&
1092 (VK_SAMPLE_COUNT_2_BIT == pCreateInfo->samples)) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07001093 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001094 "VUID-VkImageCreateInfo-imageType-00973",
Dave Houltona9df0ce2018-02-07 10:51:23 -07001095 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 2-sample image if "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001096 "corresponding feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001097 } else if ((VK_FALSE == device_data->physical_device_features.sparseResidency4Samples) &&
1098 (VK_SAMPLE_COUNT_4_BIT == pCreateInfo->samples)) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07001099 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001100 "VUID-VkImageCreateInfo-imageType-00974",
Dave Houltona9df0ce2018-02-07 10:51:23 -07001101 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 4-sample image if "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001102 "corresponding feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001103 } else if ((VK_FALSE == device_data->physical_device_features.sparseResidency8Samples) &&
1104 (VK_SAMPLE_COUNT_8_BIT == pCreateInfo->samples)) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07001105 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001106 "VUID-VkImageCreateInfo-imageType-00975",
Dave Houltona9df0ce2018-02-07 10:51:23 -07001107 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 8-sample image if "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001108 "corresponding feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001109 } else if ((VK_FALSE == device_data->physical_device_features.sparseResidency16Samples) &&
1110 (VK_SAMPLE_COUNT_16_BIT == pCreateInfo->samples)) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07001111 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001112 "VUID-VkImageCreateInfo-imageType-00976",
Dave Houltona9df0ce2018-02-07 10:51:23 -07001113 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 16-sample image if "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001114 "corresponding feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001115 }
1116 }
1117 }
Jeff Bolz9af91c52018-09-01 21:53:57 -05001118 if (pCreateInfo->usage & VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV) {
1119 if (pCreateInfo->imageType != VK_IMAGE_TYPE_2D) {
1120 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1121 "VUID-VkImageCreateInfo-imageType-02082",
1122 "vkCreateImage: if usage includes VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV, "
1123 "imageType must be VK_IMAGE_TYPE_2D.");
1124 }
1125 if (pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT) {
1126 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1127 "VUID-VkImageCreateInfo-samples-02083",
1128 "vkCreateImage: if usage includes VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV, "
1129 "samples must be VK_SAMPLE_COUNT_1_BIT.");
1130 }
1131 if (pCreateInfo->tiling != VK_IMAGE_TILING_OPTIMAL) {
1132 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1133 "VUID-VkImageCreateInfo-tiling-02084",
1134 "vkCreateImage: if usage includes VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV, "
1135 "tiling must be VK_IMAGE_TILING_OPTIMAL.");
1136 }
1137 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001138 }
1139 return skip;
1140}
1141
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001142bool pv_vkCreateImageView(VkDevice device, const VkImageViewCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
1143 VkImageView *pView) {
1144 bool skip = false;
1145 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
1146 debug_report_data *report_data = device_data->report_data;
1147
1148 if (pCreateInfo != nullptr) {
Dave Houltonbd2e2622018-04-10 16:41:14 -06001149 // Validate chained VkImageViewUsageCreateInfo struct, if present
1150 if (nullptr != pCreateInfo->pNext) {
1151 auto chained_ivuci_struct = lvl_find_in_chain<VkImageViewUsageCreateInfoKHR>(pCreateInfo->pNext);
1152 if (chained_ivuci_struct) {
1153 if (0 == chained_ivuci_struct->usage) {
1154 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001155 "VUID-VkImageViewUsageCreateInfo-usage-requiredbitmask",
Dave Houlton0f3795b2018-04-13 15:04:35 -06001156 "vkCreateImageView: Chained VkImageViewUsageCreateInfo usage field must not be 0.");
Dave Houltonbd2e2622018-04-10 16:41:14 -06001157 } else if (chained_ivuci_struct->usage & ~AllVkImageUsageFlagBits) {
1158 std::stringstream ss;
1159 ss << "vkCreateImageView: Chained VkImageViewUsageCreateInfo usage field (0x" << std::hex
1160 << chained_ivuci_struct->usage << ") contains invalid flag bits.";
1161 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001162 "VUID-VkImageViewUsageCreateInfo-usage-parameter", "%s", ss.str().c_str());
Dave Houltonbd2e2622018-04-10 16:41:14 -06001163 }
1164 }
1165 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001166 }
1167 return skip;
1168}
1169
Petr Krausb3fcdb42018-01-09 22:09:09 +01001170bool pv_VkViewport(const layer_data *device_data, const VkViewport &viewport, const char *fn_name, const char *param_name,
1171 VkDebugReportObjectTypeEXT object_type, uint64_t object = 0) {
1172 bool skip = false;
1173 debug_report_data *report_data = device_data->report_data;
1174
1175 // Note: for numerical correctness
1176 // - float comparisons should expect NaN (comparison always false).
1177 // - VkPhysicalDeviceLimits::maxViewportDimensions is uint32_t, not float -> careful.
1178
1179 const auto f_lte_u32_exact = [](const float v1_f, const uint32_t v2_u32) {
John Zulaufac0876c2018-02-19 10:09:35 -07001180 if (std::isnan(v1_f)) return false;
Petr Krausb3fcdb42018-01-09 22:09:09 +01001181 if (v1_f <= 0.0f) return true;
1182
1183 float intpart;
1184 const float fract = modff(v1_f, &intpart);
1185
1186 assert(std::numeric_limits<float>::radix == 2);
1187 const float u32_max_plus1 = ldexpf(1.0f, 32); // hopefully exact
1188 if (intpart >= u32_max_plus1) return false;
1189
1190 uint32_t v1_u32 = static_cast<uint32_t>(intpart);
1191 if (v1_u32 < v2_u32)
1192 return true;
1193 else if (v1_u32 == v2_u32 && fract == 0.0f)
1194 return true;
1195 else
1196 return false;
1197 };
1198
1199 const auto f_lte_u32_direct = [](const float v1_f, const uint32_t v2_u32) {
1200 const float v2_f = static_cast<float>(v2_u32); // not accurate for > radix^digits; and undefined rounding mode
1201 return (v1_f <= v2_f);
1202 };
1203
1204 // width
1205 bool width_healthy = true;
1206 const auto max_w = device_data->device_limits.maxViewportDimensions[0];
1207
1208 if (!(viewport.width > 0.0f)) {
1209 width_healthy = false;
Dave Houlton413a6782018-05-22 13:01:54 -06001210 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-width-01770",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001211 "%s: %s.width (=%f) is not greater than 0.0.", fn_name, param_name, viewport.width);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001212 } else if (!(f_lte_u32_exact(viewport.width, max_w) || f_lte_u32_direct(viewport.width, max_w))) {
1213 width_healthy = false;
Dave Houlton413a6782018-05-22 13:01:54 -06001214 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-width-01771",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001215 "%s: %s.width (=%f) exceeds VkPhysicalDeviceLimits::maxViewportDimensions[0] (=%" PRIu32 ").", fn_name,
1216 param_name, viewport.width, max_w);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001217 } else if (!f_lte_u32_exact(viewport.width, max_w) && f_lte_u32_direct(viewport.width, max_w)) {
Dave Houlton413a6782018-05-22 13:01:54 -06001218 skip |= log_msg(report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, object_type, object, kVUID_PVError_NONE,
Petr Krausb3fcdb42018-01-09 22:09:09 +01001219 "%s: %s.width (=%f) technically exceeds VkPhysicalDeviceLimits::maxViewportDimensions[0] (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001220 "), but it is within the static_cast<float>(maxViewportDimensions[0]) limit.",
1221 fn_name, param_name, viewport.width, max_w);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001222 }
1223
1224 // height
1225 bool height_healthy = true;
Petr Krausaf9c1222018-03-10 02:39:47 +01001226 const bool negative_height_enabled = device_data->api_version >= VK_API_VERSION_1_1 ||
1227 device_data->extensions.vk_khr_maintenance1 ||
1228 device_data->extensions.vk_amd_negative_viewport_height;
Petr Krausb3fcdb42018-01-09 22:09:09 +01001229 const auto max_h = device_data->device_limits.maxViewportDimensions[1];
1230
1231 if (!negative_height_enabled && !(viewport.height > 0.0f)) {
1232 height_healthy = false;
Dave Houlton413a6782018-05-22 13:01:54 -06001233 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-height-01772",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001234 "%s: %s.height (=%f) is not greater 0.0.", fn_name, param_name, viewport.height);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001235 } else if (!(f_lte_u32_exact(fabsf(viewport.height), max_h) || f_lte_u32_direct(fabsf(viewport.height), max_h))) {
1236 height_healthy = false;
1237
Dave Houlton413a6782018-05-22 13:01:54 -06001238 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-height-01773",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001239 "%s: Absolute value of %s.height (=%f) exceeds VkPhysicalDeviceLimits::maxViewportDimensions[1] (=%" PRIu32
1240 ").",
1241 fn_name, param_name, viewport.height, max_h);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001242 } else if (!f_lte_u32_exact(fabsf(viewport.height), max_h) && f_lte_u32_direct(fabsf(viewport.height), max_h)) {
1243 height_healthy = false;
1244
1245 skip |= log_msg(
Dave Houlton413a6782018-05-22 13:01:54 -06001246 report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, object_type, object, kVUID_PVError_NONE,
Petr Krausb3fcdb42018-01-09 22:09:09 +01001247 "%s: Absolute value of %s.height (=%f) technically exceeds VkPhysicalDeviceLimits::maxViewportDimensions[1] (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001248 "), but it is within the static_cast<float>(maxViewportDimensions[1]) limit.",
1249 fn_name, param_name, viewport.height, max_h);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001250 }
1251
1252 // x
1253 bool x_healthy = true;
1254 if (!(viewport.x >= device_data->device_limits.viewportBoundsRange[0])) {
1255 x_healthy = false;
Dave Houlton413a6782018-05-22 13:01:54 -06001256 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-x-01774",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001257 "%s: %s.x (=%f) is less than VkPhysicalDeviceLimits::viewportBoundsRange[0] (=%f).", fn_name, param_name,
1258 viewport.x, device_data->device_limits.viewportBoundsRange[0]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001259 }
1260
1261 // x + width
1262 if (x_healthy && width_healthy) {
1263 const float right_bound = viewport.x + viewport.width;
1264 if (!(right_bound <= device_data->device_limits.viewportBoundsRange[1])) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06001265 skip |=
Dave Houlton413a6782018-05-22 13:01:54 -06001266 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-x-01232",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001267 "%s: %s.x + %s.width (=%f + %f = %f) is greater than VkPhysicalDeviceLimits::viewportBoundsRange[1] (=%f).",
1268 fn_name, param_name, param_name, viewport.x, viewport.width, right_bound,
1269 device_data->device_limits.viewportBoundsRange[1]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001270 }
1271 }
1272
1273 // y
1274 bool y_healthy = true;
1275 if (!(viewport.y >= device_data->device_limits.viewportBoundsRange[0])) {
1276 y_healthy = false;
Dave Houlton413a6782018-05-22 13:01:54 -06001277 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-y-01775",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001278 "%s: %s.y (=%f) is less than VkPhysicalDeviceLimits::viewportBoundsRange[0] (=%f).", fn_name, param_name,
1279 viewport.y, device_data->device_limits.viewportBoundsRange[0]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001280 } else if (negative_height_enabled && !(viewport.y <= device_data->device_limits.viewportBoundsRange[1])) {
1281 y_healthy = false;
Dave Houlton413a6782018-05-22 13:01:54 -06001282 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-y-01776",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001283 "%s: %s.y (=%f) exceeds VkPhysicalDeviceLimits::viewportBoundsRange[1] (=%f).", fn_name, param_name,
1284 viewport.y, device_data->device_limits.viewportBoundsRange[1]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001285 }
1286
1287 // y + height
1288 if (y_healthy && height_healthy) {
1289 const float boundary = viewport.y + viewport.height;
1290
1291 if (!(boundary <= device_data->device_limits.viewportBoundsRange[1])) {
Dave Houlton413a6782018-05-22 13:01:54 -06001292 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-y-01233",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001293 "%s: %s.y + %s.height (=%f + %f = %f) exceeds VkPhysicalDeviceLimits::viewportBoundsRange[1] (=%f).",
1294 fn_name, param_name, param_name, viewport.y, viewport.height, boundary,
1295 device_data->device_limits.viewportBoundsRange[1]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001296 } else if (negative_height_enabled && !(boundary >= device_data->device_limits.viewportBoundsRange[0])) {
1297 skip |= log_msg(
Dave Houlton413a6782018-05-22 13:01:54 -06001298 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-y-01777",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001299 "%s: %s.y + %s.height (=%f + %f = %f) is less than VkPhysicalDeviceLimits::viewportBoundsRange[0] (=%f).", fn_name,
1300 param_name, param_name, viewport.y, viewport.height, boundary, device_data->device_limits.viewportBoundsRange[0]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001301 }
1302 }
1303
1304 if (!device_data->extensions.vk_ext_depth_range_unrestricted) {
1305 // minDepth
1306 if (!(viewport.minDepth >= 0.0) || !(viewport.minDepth <= 1.0)) {
Dave Houlton413a6782018-05-22 13:01:54 -06001307 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-minDepth-01234",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001308
Petr Krausb3fcdb42018-01-09 22:09:09 +01001309 "%s: VK_EXT_depth_range_unrestricted extension is not enabled and %s.minDepth (=%f) is not within the "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001310 "[0.0, 1.0] range.",
1311 fn_name, param_name, viewport.minDepth);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001312 }
1313
1314 // maxDepth
1315 if (!(viewport.maxDepth >= 0.0) || !(viewport.maxDepth <= 1.0)) {
Dave Houlton413a6782018-05-22 13:01:54 -06001316 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-maxDepth-01235",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001317
Petr Krausb3fcdb42018-01-09 22:09:09 +01001318 "%s: VK_EXT_depth_range_unrestricted extension is not enabled and %s.maxDepth (=%f) is not within the "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001319 "[0.0, 1.0] range.",
1320 fn_name, param_name, viewport.maxDepth);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001321 }
1322 }
1323
1324 return skip;
1325}
1326
Jeff Bolz9af91c52018-09-01 21:53:57 -05001327struct SampleOrderInfo
1328{
1329 VkShadingRatePaletteEntryNV shadingRate;
1330 uint32_t width;
1331 uint32_t height;
1332};
1333
1334// All palette entries with more than one pixel per fragment
1335static SampleOrderInfo sampleOrderInfos[] =
1336{
1337 { VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_1X2_PIXELS_NV, 1, 2},
1338 { VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_2X1_PIXELS_NV, 2, 1},
1339 { VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_2X2_PIXELS_NV, 2, 2},
1340 { VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_4X2_PIXELS_NV, 4, 2},
1341 { VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_2X4_PIXELS_NV, 2, 4},
1342 { VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_4X4_PIXELS_NV, 4, 4},
1343};
1344
1345bool ValidateCoarseSampleOrderCustomNV(layer_data *device_data, const VkCoarseSampleOrderCustomNV *order)
1346{
1347 bool skip = false;
1348 debug_report_data *report_data = device_data->report_data;
1349
1350 uint32_t infoIdx = 0;
1351 for (; infoIdx < ARRAY_SIZE(sampleOrderInfos); ++infoIdx) {
1352 if (sampleOrderInfos[infoIdx].shadingRate == order->shadingRate) {
1353 break;
1354 }
1355 }
1356
1357 if (infoIdx == ARRAY_SIZE(sampleOrderInfos)) {
1358 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1359 "VUID-VkCoarseSampleOrderCustomNV-shadingRate-02073",
1360 "VkCoarseSampleOrderCustomNV shadingRate must be a shading rate "
1361 "that generates fragments with more than one pixel.");
1362 return skip;
1363 }
1364
1365 if (order->sampleCount == 0 ||
1366 (order->sampleCount & (order->sampleCount - 1)) ||
1367 !(order->sampleCount & device_data->device_limits.framebufferNoAttachmentsSampleCounts)) {
1368 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1369 "VUID-VkCoarseSampleOrderCustomNV-sampleCount-02074",
1370 "VkCoarseSampleOrderCustomNV sampleCount (=%" PRIu32 ") must "
1371 "correspond to a sample count enumerated in VkSampleCountFlags whose corresponding bit "
1372 "is set in framebufferNoAttachmentsSampleCounts.",
1373 order->sampleCount);
1374 }
1375
1376 SampleOrderInfo *sampleOrderInfo = &sampleOrderInfos[infoIdx];
1377
1378 if (order->sampleLocationCount != order->sampleCount * sampleOrderInfo->width * sampleOrderInfo->height) {
1379 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1380 "VUID-VkCoarseSampleOrderCustomNV-sampleLocationCount-02075",
1381 "VkCoarseSampleOrderCustomNV sampleLocationCount (=%" PRIu32 ") must "
1382 "be equal to the product of sampleCount (=%" PRIu32 "), the fragment width for shadingRate "
1383 "(=%" PRIu32 "), and the fragment height for shadingRate (=%" PRIu32 ").",
1384 order->sampleLocationCount, order->sampleCount, sampleOrderInfo->width, sampleOrderInfo->height);
1385 }
1386
1387 // XXX TODO don't have access to extended limits in this layer right now
1388#if 0
1389 if (order->sampleLocationCount > shadingRateMaxCoarseSamples) {
1390 "VUID-VkCoarseSampleOrderCustomNV-sampleLocationCount-02076";
1391 }
1392#endif
1393
1394 // Accumulate a bitmask tracking which (x,y,sample) tuples are seen. Expect
1395 // the first width*height*sampleCount bits to all be set
1396 uint64_t sampleLocationsMask = 0;
1397 for (uint32_t i = 0; i < order->sampleLocationCount; ++i) {
1398 const VkCoarseSampleLocationNV *sampleLoc = &order->pSampleLocations[i];
1399 if (sampleLoc->pixelX >= sampleOrderInfo->width) {
1400 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1401 "VUID-VkCoarseSampleLocationNV-pixelX-02078",
1402 "pixelX must be less than the width (in pixels) of the fragment.");
1403 }
1404 if (sampleLoc->pixelY >= sampleOrderInfo->height) {
1405 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1406 "VUID-VkCoarseSampleLocationNV-pixelY-02079",
1407 "pixelY must be less than the height (in pixels) of the fragment.");
1408 }
1409 if (sampleLoc->sample >= order->sampleCount) {
1410 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1411 "VUID-VkCoarseSampleLocationNV-sample-02080",
1412 "sample must be less than the number of coverage samples in each pixel belonging to the fragment.");
1413 }
1414 uint32_t idx = sampleLoc->sample + order->sampleCount * (sampleLoc->pixelX + sampleOrderInfo->width * sampleLoc->pixelY);
1415 sampleLocationsMask |= 1ULL << idx;
1416 }
1417
1418 uint64_t expectedMask = (order->sampleLocationCount == 64) ? ~0ULL : ((1ULL << order->sampleLocationCount) - 1);
1419 if (sampleLocationsMask != expectedMask) {
1420 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1421 "VUID-VkCoarseSampleOrderCustomNV-pSampleLocations-02077",
1422 "The array pSampleLocations must contain exactly one entry for "
1423 "every combination of valid values for pixelX, pixelY, and sample in the structure VkCoarseSampleOrderCustomNV.");
1424 }
1425
1426 return skip;
1427}
1428
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001429bool pv_vkCreateGraphicsPipelines(VkDevice device, VkPipelineCache pipelineCache, uint32_t createInfoCount,
1430 const VkGraphicsPipelineCreateInfo *pCreateInfos, const VkAllocationCallbacks *pAllocator,
1431 VkPipeline *pPipelines) {
1432 bool skip = false;
1433 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
1434 debug_report_data *report_data = device_data->report_data;
1435
1436 if (pCreateInfos != nullptr) {
1437 for (uint32_t i = 0; i < createInfoCount; ++i) {
Petr Kraus299ba622017-11-24 03:09:03 +01001438 bool has_dynamic_viewport = false;
1439 bool has_dynamic_scissor = false;
1440 bool has_dynamic_line_width = false;
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001441 bool has_dynamic_viewport_w_scaling_nv = false;
1442 bool has_dynamic_discard_rectangle_ext = false;
1443 bool has_dynamic_sample_locations_ext = false;
Jeff Bolz3e71f782018-08-29 23:15:45 -05001444 bool has_dynamic_exclusive_scissor_nv = false;
Jeff Bolz9af91c52018-09-01 21:53:57 -05001445 bool has_dynamic_shading_rate_palette_nv = false;
Petr Kraus299ba622017-11-24 03:09:03 +01001446 if (pCreateInfos[i].pDynamicState != nullptr) {
1447 const auto &dynamic_state_info = *pCreateInfos[i].pDynamicState;
1448 for (uint32_t state_index = 0; state_index < dynamic_state_info.dynamicStateCount; ++state_index) {
1449 const auto &dynamic_state = dynamic_state_info.pDynamicStates[state_index];
1450 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT) has_dynamic_viewport = true;
1451 if (dynamic_state == VK_DYNAMIC_STATE_SCISSOR) has_dynamic_scissor = true;
1452 if (dynamic_state == VK_DYNAMIC_STATE_LINE_WIDTH) has_dynamic_line_width = true;
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001453 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT_W_SCALING_NV) has_dynamic_viewport_w_scaling_nv = true;
1454 if (dynamic_state == VK_DYNAMIC_STATE_DISCARD_RECTANGLE_EXT) has_dynamic_discard_rectangle_ext = true;
1455 if (dynamic_state == VK_DYNAMIC_STATE_SAMPLE_LOCATIONS_EXT) has_dynamic_sample_locations_ext = true;
Jeff Bolz3e71f782018-08-29 23:15:45 -05001456 if (dynamic_state == VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV) has_dynamic_exclusive_scissor_nv = true;
Jeff Bolz9af91c52018-09-01 21:53:57 -05001457 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT_SHADING_RATE_PALETTE_NV) has_dynamic_shading_rate_palette_nv = true;
Petr Kraus299ba622017-11-24 03:09:03 +01001458 }
1459 }
1460
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001461 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
1462 if (pCreateInfos[i].pVertexInputState != nullptr) {
1463 auto const &vertex_input_state = pCreateInfos[i].pVertexInputState;
Peter Kohautc7d9d392018-07-15 00:34:07 +02001464
1465 if (vertex_input_state->vertexBindingDescriptionCount > device_data->device_limits.maxVertexInputBindings) {
1466 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1467 "VUID-VkPipelineVertexInputStateCreateInfo-vertexBindingDescriptionCount-00613",
1468 "vkCreateGraphicsPipelines: pararameter "
1469 "pCreateInfo[%d].pVertexInputState->vertexBindingDescriptionCount (%u) is "
1470 "greater than VkPhysicalDeviceLimits::maxVertexInputBindings (%u).",
1471 i, vertex_input_state->vertexBindingDescriptionCount,
1472 device_data->device_limits.maxVertexInputBindings);
1473 }
1474
1475 if (vertex_input_state->vertexAttributeDescriptionCount > device_data->device_limits.maxVertexInputAttributes) {
1476 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1477 "VUID-VkPipelineVertexInputStateCreateInfo-vertexAttributeDescriptionCount-00614",
1478 "vkCreateGraphicsPipelines: pararameter "
Peter Kohaut9e92c5c2018-07-17 10:32:17 +02001479 "pCreateInfo[%d].pVertexInputState->vertexAttributeDescriptionCount (%u) is "
Peter Kohautc7d9d392018-07-15 00:34:07 +02001480 "greater than VkPhysicalDeviceLimits::maxVertexInputAttributes (%u).",
1481 i, vertex_input_state->vertexBindingDescriptionCount,
1482 device_data->device_limits.maxVertexInputAttributes);
1483 }
1484
1485 std::unordered_set<uint32_t> vertex_bindings(vertex_input_state->vertexBindingDescriptionCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001486 for (uint32_t d = 0; d < vertex_input_state->vertexBindingDescriptionCount; ++d) {
1487 auto const &vertex_bind_desc = vertex_input_state->pVertexBindingDescriptions[d];
Peter Kohautc7d9d392018-07-15 00:34:07 +02001488 auto const &binding_it = vertex_bindings.find(vertex_bind_desc.binding);
1489 if (binding_it != vertex_bindings.cend()) {
1490 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1491 "VUID-VkPipelineVertexInputStateCreateInfo-pVertexBindingDescriptions-00616",
1492 "vkCreateGraphicsPipelines: parameter "
1493 "pCreateInfo[%d].pVertexInputState->pVertexBindingDescription[%d].binding "
1494 "(%" PRIu32 ") is not distinct.",
1495 i, d, vertex_bind_desc.binding);
1496 }
1497 vertex_bindings.insert(vertex_bind_desc.binding);
1498
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001499 if (vertex_bind_desc.binding >= device_data->device_limits.maxVertexInputBindings) {
1500 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001501 "VUID-VkVertexInputBindingDescription-binding-00618",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001502 "vkCreateGraphicsPipelines: parameter "
1503 "pCreateInfos[%u].pVertexInputState->pVertexBindingDescriptions[%u].binding (%u) is "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001504 "greater than or equal to VkPhysicalDeviceLimits::maxVertexInputBindings (%u).",
1505 i, d, vertex_bind_desc.binding, device_data->device_limits.maxVertexInputBindings);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001506 }
1507
1508 if (vertex_bind_desc.stride > device_data->device_limits.maxVertexInputBindingStride) {
1509 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001510 "VUID-VkVertexInputBindingDescription-stride-00619",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001511 "vkCreateGraphicsPipelines: parameter "
1512 "pCreateInfos[%u].pVertexInputState->pVertexBindingDescriptions[%u].stride (%u) is greater "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001513 "than VkPhysicalDeviceLimits::maxVertexInputBindingStride (%u).",
1514 i, d, vertex_bind_desc.stride, device_data->device_limits.maxVertexInputBindingStride);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001515 }
1516 }
1517
Peter Kohautc7d9d392018-07-15 00:34:07 +02001518 std::unordered_set<uint32_t> attribute_locations(vertex_input_state->vertexAttributeDescriptionCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001519 for (uint32_t d = 0; d < vertex_input_state->vertexAttributeDescriptionCount; ++d) {
1520 auto const &vertex_attrib_desc = vertex_input_state->pVertexAttributeDescriptions[d];
Peter Kohautc7d9d392018-07-15 00:34:07 +02001521 auto const &location_it = attribute_locations.find(vertex_attrib_desc.location);
1522 if (location_it != attribute_locations.cend()) {
1523 skip |= log_msg(
1524 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1525 "VUID-VkPipelineVertexInputStateCreateInfo-pVertexAttributeDescriptions-00617",
1526 "vkCreateGraphicsPipelines: parameter "
1527 "pCreateInfo[%d].pVertexInputState->vertexAttributeDescriptions[%d].location (%u) is not distinct.",
1528 i, d, vertex_attrib_desc.location);
1529 }
1530 attribute_locations.insert(vertex_attrib_desc.location);
1531
1532 auto const &binding_it = vertex_bindings.find(vertex_attrib_desc.binding);
1533 if (binding_it == vertex_bindings.cend()) {
1534 skip |= log_msg(
1535 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1536 "VUID-VkPipelineVertexInputStateCreateInfo-binding-00615",
1537 "vkCreateGraphicsPipelines: parameter "
1538 " pCreateInfo[%d].pVertexInputState->vertexAttributeDescriptions[%d].binding (%u) does not exist "
1539 "in any pCreateInfo[%d].pVertexInputState->pVertexBindingDescription.",
1540 i, d, vertex_attrib_desc.binding, i);
1541 }
1542
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001543 if (vertex_attrib_desc.location >= device_data->device_limits.maxVertexInputAttributes) {
1544 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001545 "VUID-VkVertexInputAttributeDescription-location-00620",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001546 "vkCreateGraphicsPipelines: parameter "
1547 "pCreateInfos[%u].pVertexInputState->pVertexAttributeDescriptions[%u].location (%u) is "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001548 "greater than or equal to VkPhysicalDeviceLimits::maxVertexInputAttributes (%u).",
1549 i, d, vertex_attrib_desc.location, device_data->device_limits.maxVertexInputAttributes);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001550 }
1551
1552 if (vertex_attrib_desc.binding >= device_data->device_limits.maxVertexInputBindings) {
1553 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001554 "VUID-VkVertexInputAttributeDescription-binding-00621",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001555 "vkCreateGraphicsPipelines: parameter "
1556 "pCreateInfos[%u].pVertexInputState->pVertexAttributeDescriptions[%u].binding (%u) is "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001557 "greater than or equal to VkPhysicalDeviceLimits::maxVertexInputBindings (%u).",
1558 i, d, vertex_attrib_desc.binding, device_data->device_limits.maxVertexInputBindings);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001559 }
1560
1561 if (vertex_attrib_desc.offset > device_data->device_limits.maxVertexInputAttributeOffset) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06001562 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001563 "VUID-VkVertexInputAttributeDescription-offset-00622",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001564 "vkCreateGraphicsPipelines: parameter "
1565 "pCreateInfos[%u].pVertexInputState->pVertexAttributeDescriptions[%u].offset (%u) is "
1566 "greater than VkPhysicalDeviceLimits::maxVertexInputAttributeOffset (%u).",
1567 i, d, vertex_attrib_desc.offset, device_data->device_limits.maxVertexInputAttributeOffset);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001568 }
1569 }
1570 }
1571
1572 if (pCreateInfos[i].pStages != nullptr) {
1573 bool has_control = false;
1574 bool has_eval = false;
1575
1576 for (uint32_t stage_index = 0; stage_index < pCreateInfos[i].stageCount; ++stage_index) {
1577 if (pCreateInfos[i].pStages[stage_index].stage == VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) {
1578 has_control = true;
1579 } else if (pCreateInfos[i].pStages[stage_index].stage == VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT) {
1580 has_eval = true;
1581 }
1582 }
1583
1584 // pTessellationState is ignored without both tessellation control and tessellation evaluation shaders stages
1585 if (has_control && has_eval) {
1586 if (pCreateInfos[i].pTessellationState == nullptr) {
1587 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001588 "VUID-VkGraphicsPipelineCreateInfo-pStages-00731",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001589 "vkCreateGraphicsPipelines: if pCreateInfos[%d].pStages includes a tessellation control "
1590 "shader stage and a tessellation evaluation shader stage, "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001591 "pCreateInfos[%d].pTessellationState must not be NULL.",
1592 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001593 } else {
1594 skip |= validate_struct_pnext(
1595 report_data, "vkCreateGraphicsPipelines",
1596 ParameterName("pCreateInfos[%i].pTessellationState->pNext", ParameterName::IndexVector{i}), NULL,
Dave Houlton413a6782018-05-22 13:01:54 -06001597 pCreateInfos[i].pTessellationState->pNext, 0, NULL, GeneratedHeaderVersion,
1598 "VUID-VkGraphicsPipelineCreateInfo-pNext-pNext");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001599
1600 skip |= validate_reserved_flags(
1601 report_data, "vkCreateGraphicsPipelines",
1602 ParameterName("pCreateInfos[%i].pTessellationState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06001603 pCreateInfos[i].pTessellationState->flags,
1604 "VUID-VkPipelineTessellationStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001605
1606 if (pCreateInfos[i].pTessellationState->sType !=
1607 VK_STRUCTURE_TYPE_PIPELINE_TESSELLATION_STATE_CREATE_INFO) {
1608 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001609 "VUID-VkPipelineTessellationStateCreateInfo-sType-sType",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001610 "vkCreateGraphicsPipelines: parameter pCreateInfos[%d].pTessellationState->sType must "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001611 "be VK_STRUCTURE_TYPE_PIPELINE_TESSELLATION_STATE_CREATE_INFO.",
1612 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001613 }
1614
1615 if (pCreateInfos[i].pTessellationState->patchControlPoints == 0 ||
1616 pCreateInfos[i].pTessellationState->patchControlPoints >
1617 device_data->device_limits.maxTessellationPatchSize) {
1618 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001619 "VUID-VkPipelineTessellationStateCreateInfo-patchControlPoints-01214",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001620 "vkCreateGraphicsPipelines: invalid parameter "
1621 "pCreateInfos[%d].pTessellationState->patchControlPoints value %u. patchControlPoints "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001622 "should be >0 and <=%u.",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001623 i, pCreateInfos[i].pTessellationState->patchControlPoints,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001624 device_data->device_limits.maxTessellationPatchSize);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001625 }
1626 }
1627 }
1628 }
1629
1630 // pViewportState, pMultisampleState, pDepthStencilState, and pColorBlendState ignored when rasterization is disabled
1631 if ((pCreateInfos[i].pRasterizationState != nullptr) &&
1632 (pCreateInfos[i].pRasterizationState->rasterizerDiscardEnable == VK_FALSE)) {
1633 if (pCreateInfos[i].pViewportState == nullptr) {
Petr Krausa6103552017-11-16 21:21:58 +01001634 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001635 VK_NULL_HANDLE, "VUID-VkGraphicsPipelineCreateInfo-rasterizerDiscardEnable-00750",
Petr Krausa6103552017-11-16 21:21:58 +01001636 "vkCreateGraphicsPipelines: Rasterization is enabled (pCreateInfos[%" PRIu32
1637 "].pRasterizationState->rasterizerDiscardEnable is VK_FALSE), but pCreateInfos[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001638 "].pViewportState (=NULL) is not a valid pointer.",
1639 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001640 } else {
Petr Krausa6103552017-11-16 21:21:58 +01001641 const auto &viewport_state = *pCreateInfos[i].pViewportState;
1642
1643 if (viewport_state.sType != VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_STATE_CREATE_INFO) {
1644 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001645 VK_NULL_HANDLE, "VUID-VkPipelineViewportStateCreateInfo-sType-sType",
Petr Krausa6103552017-11-16 21:21:58 +01001646 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001647 "].pViewportState->sType is not VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_STATE_CREATE_INFO.",
1648 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001649 }
1650
Petr Krausa6103552017-11-16 21:21:58 +01001651 const VkStructureType allowed_structs_VkPipelineViewportStateCreateInfo[] = {
1652 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_SWIZZLE_STATE_CREATE_INFO_NV,
Jeff Bolz3e71f782018-08-29 23:15:45 -05001653 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_W_SCALING_STATE_CREATE_INFO_NV,
1654 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_EXCLUSIVE_SCISSOR_STATE_CREATE_INFO_NV,
Jeff Bolz9af91c52018-09-01 21:53:57 -05001655 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_SHADING_RATE_IMAGE_STATE_CREATE_INFO_NV,
1656 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_COARSE_SAMPLE_ORDER_STATE_CREATE_INFO_NV,
Jeff Bolz3e71f782018-08-29 23:15:45 -05001657 };
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001658 skip |= validate_struct_pnext(
1659 report_data, "vkCreateGraphicsPipelines",
Petr Krausa6103552017-11-16 21:21:58 +01001660 ParameterName("pCreateInfos[%i].pViewportState->pNext", ParameterName::IndexVector{i}),
Jeff Bolz9af91c52018-09-01 21:53:57 -05001661 "VkPipelineViewportSwizzleStateCreateInfoNV, VkPipelineViewportWScalingStateCreateInfoNV, "
1662 "VkPipelineViewportExclusiveScissorStateCreateInfoNV, VkPipelineViewportShadingRateImageStateCreateInfoNV, VkPipelineViewportCoarseSampleOrderStateCreateInfoNV",
Petr Krausa6103552017-11-16 21:21:58 +01001663 viewport_state.pNext, ARRAY_SIZE(allowed_structs_VkPipelineViewportStateCreateInfo),
Dave Houlton413a6782018-05-22 13:01:54 -06001664 allowed_structs_VkPipelineViewportStateCreateInfo, 65,
1665 "VUID-VkPipelineViewportStateCreateInfo-pNext-pNext");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001666
1667 skip |= validate_reserved_flags(
1668 report_data, "vkCreateGraphicsPipelines",
1669 ParameterName("pCreateInfos[%i].pViewportState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06001670 viewport_state.flags, "VUID-VkPipelineViewportStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001671
Jeff Bolz3e71f782018-08-29 23:15:45 -05001672 auto exclusive_scissor_struct = lvl_find_in_chain<VkPipelineViewportExclusiveScissorStateCreateInfoNV>(pCreateInfos[i].pViewportState->pNext);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001673 auto shading_rate_image_struct = lvl_find_in_chain<VkPipelineViewportShadingRateImageStateCreateInfoNV>(pCreateInfos[i].pViewportState->pNext);
1674 auto coarse_sample_order_struct = lvl_find_in_chain<VkPipelineViewportCoarseSampleOrderStateCreateInfoNV>(pCreateInfos[i].pViewportState->pNext);
Jeff Bolz3e71f782018-08-29 23:15:45 -05001675
Petr Krausa6103552017-11-16 21:21:58 +01001676 if (!device_data->physical_device_features.multiViewport) {
1677 if (viewport_state.viewportCount != 1) {
1678 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001679 VK_NULL_HANDLE, "VUID-VkPipelineViewportStateCreateInfo-viewportCount-01216",
Petr Krausa6103552017-11-16 21:21:58 +01001680 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
1681 "disabled, but pCreateInfos[%" PRIu32 "].pViewportState->viewportCount (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001682 ") is not 1.",
1683 i, viewport_state.viewportCount);
Petr Krausa6103552017-11-16 21:21:58 +01001684 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001685
Petr Krausa6103552017-11-16 21:21:58 +01001686 if (viewport_state.scissorCount != 1) {
1687 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001688 VK_NULL_HANDLE, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-01217",
Petr Krausa6103552017-11-16 21:21:58 +01001689 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
1690 "disabled, but pCreateInfos[%" PRIu32 "].pViewportState->scissorCount (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001691 ") is not 1.",
1692 i, viewport_state.scissorCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001693 }
Jeff Bolz3e71f782018-08-29 23:15:45 -05001694
1695 if (exclusive_scissor_struct &&
1696 (exclusive_scissor_struct->exclusiveScissorCount != 0 && exclusive_scissor_struct->exclusiveScissorCount != 1)) {
1697 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
1698 VK_NULL_HANDLE, "VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-exclusiveScissorCount-02027",
1699 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
Jeff Bolz9af91c52018-09-01 21:53:57 -05001700 "disabled, but pCreateInfos[%" PRIu32 "] VkPipelineViewportExclusiveScissorStateCreateInfoNV::exclusiveScissorCount (=%" PRIu32
Jeff Bolz3e71f782018-08-29 23:15:45 -05001701 ") is not 1.",
1702 i, exclusive_scissor_struct->exclusiveScissorCount);
1703
1704 }
1705
Jeff Bolz9af91c52018-09-01 21:53:57 -05001706 if (shading_rate_image_struct &&
1707 (shading_rate_image_struct->viewportCount != 0 && shading_rate_image_struct->viewportCount != 1)) {
1708 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
1709 VK_NULL_HANDLE, "VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-viewportCount-02054",
1710 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
1711 "disabled, but pCreateInfos[%" PRIu32 "] VkPipelineViewportShadingRateImageStateCreateInfoNV::viewportCount (=%" PRIu32
1712 ") is not 1.",
1713 i, shading_rate_image_struct->viewportCount);
1714
1715 }
1716
Petr Krausa6103552017-11-16 21:21:58 +01001717 } else { // multiViewport enabled
1718 if (viewport_state.viewportCount == 0) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001719 skip |= log_msg(
1720 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001721 VK_NULL_HANDLE, "VUID-VkPipelineViewportStateCreateInfo-viewportCount-arraylength",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001722 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "].pViewportState->viewportCount is 0.", i);
Petr Krausa6103552017-11-16 21:21:58 +01001723 } else if (viewport_state.viewportCount > device_data->device_limits.maxViewports) {
1724 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001725 VK_NULL_HANDLE, "VUID-VkPipelineViewportStateCreateInfo-viewportCount-01218",
Petr Krausa6103552017-11-16 21:21:58 +01001726 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1727 "].pViewportState->viewportCount (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001728 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
1729 i, viewport_state.viewportCount, device_data->device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001730 }
Petr Krausa6103552017-11-16 21:21:58 +01001731
1732 if (viewport_state.scissorCount == 0) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001733 skip |= log_msg(
1734 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001735 VK_NULL_HANDLE, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-arraylength",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001736 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "].pViewportState->scissorCount is 0.", i);
Petr Krausa6103552017-11-16 21:21:58 +01001737 } else if (viewport_state.scissorCount > device_data->device_limits.maxViewports) {
1738 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001739 VK_NULL_HANDLE, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-01219",
Petr Krausa6103552017-11-16 21:21:58 +01001740 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1741 "].pViewportState->scissorCount (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001742 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
1743 i, viewport_state.scissorCount, device_data->device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001744 }
1745 }
1746
Jeff Bolz3e71f782018-08-29 23:15:45 -05001747 if (exclusive_scissor_struct &&
1748 exclusive_scissor_struct->exclusiveScissorCount > device_data->device_limits.maxViewports) {
1749 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
1750 VK_NULL_HANDLE, "VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-exclusiveScissorCount-02028",
1751 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1752 "] exclusiveScissorCount (=%" PRIu32
1753 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
1754 i, exclusive_scissor_struct->exclusiveScissorCount, device_data->device_limits.maxViewports);
1755 }
1756
Jeff Bolz9af91c52018-09-01 21:53:57 -05001757 if (shading_rate_image_struct &&
1758 shading_rate_image_struct->viewportCount > device_data->device_limits.maxViewports) {
1759 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
1760 VK_NULL_HANDLE, "VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-viewportCount-02055",
1761 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1762 "] VkPipelineViewportShadingRateImageStateCreateInfoNV viewportCount (=%" PRIu32
1763 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
1764 i, shading_rate_image_struct->viewportCount, device_data->device_limits.maxViewports);
1765 }
1766
Petr Krausa6103552017-11-16 21:21:58 +01001767 if (viewport_state.scissorCount != viewport_state.viewportCount) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001768 skip |=
1769 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001770 VK_NULL_HANDLE, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-01220",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001771 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "].pViewportState->scissorCount (=%" PRIu32
1772 ") is not identical to pCreateInfos[%" PRIu32 "].pViewportState->viewportCount (=%" PRIu32 ").",
1773 i, viewport_state.scissorCount, i, viewport_state.viewportCount);
Petr Krausa6103552017-11-16 21:21:58 +01001774 }
1775
Jeff Bolz3e71f782018-08-29 23:15:45 -05001776 if (exclusive_scissor_struct &&
1777 exclusive_scissor_struct->exclusiveScissorCount != 0 &&
1778 exclusive_scissor_struct->exclusiveScissorCount != viewport_state.viewportCount) {
1779 skip |=
1780 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
1781 VK_NULL_HANDLE, "VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-exclusiveScissorCount-02029",
1782 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "] exclusiveScissorCount (=%" PRIu32
1783 ") must be zero or identical to pCreateInfos[%" PRIu32 "].pViewportState->viewportCount (=%" PRIu32 ").",
1784 i, exclusive_scissor_struct->exclusiveScissorCount, i, viewport_state.viewportCount);
1785 }
1786
Jeff Bolz9af91c52018-09-01 21:53:57 -05001787 if (shading_rate_image_struct &&
1788 shading_rate_image_struct->shadingRateImageEnable &&
1789 shading_rate_image_struct->viewportCount != viewport_state.viewportCount) {
1790 skip |=
1791 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
1792 VK_NULL_HANDLE, "VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-shadingRateImageEnable-02056",
1793 "vkCreateGraphicsPipelines: If shadingRateImageEnable is enabled, pCreateInfos[%" PRIu32 "] "
1794 "VkPipelineViewportShadingRateImageStateCreateInfoNV viewportCount (=%" PRIu32
1795 ") must identical to pCreateInfos[%" PRIu32 "].pViewportState->viewportCount (=%" PRIu32 ").",
1796 i, shading_rate_image_struct->viewportCount, i, viewport_state.viewportCount);
1797 }
1798
Petr Krausa6103552017-11-16 21:21:58 +01001799 if (!has_dynamic_viewport && viewport_state.viewportCount > 0 && viewport_state.pViewports == nullptr) {
1800 skip |= log_msg(
1801 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, VK_NULL_HANDLE,
Dave Houlton413a6782018-05-22 13:01:54 -06001802 "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-00747",
Petr Krausa6103552017-11-16 21:21:58 +01001803 "vkCreateGraphicsPipelines: The viewport state is static (pCreateInfos[%" PRIu32
1804 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_VIEWPORT), but pCreateInfos[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001805 "].pViewportState->pViewports (=NULL) is an invalid pointer.",
1806 i, i);
Petr Krausa6103552017-11-16 21:21:58 +01001807 }
1808
1809 if (!has_dynamic_scissor && viewport_state.scissorCount > 0 && viewport_state.pScissors == nullptr) {
1810 skip |= log_msg(
1811 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, VK_NULL_HANDLE,
Dave Houlton413a6782018-05-22 13:01:54 -06001812 "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-00748",
Petr Krausa6103552017-11-16 21:21:58 +01001813 "vkCreateGraphicsPipelines: The scissor state is static (pCreateInfos[%" PRIu32
1814 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_SCISSOR), but pCreateInfos[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001815 "].pViewportState->pScissors (=NULL) is an invalid pointer.",
1816 i, i);
Petr Krausa6103552017-11-16 21:21:58 +01001817 }
1818
Jeff Bolz3e71f782018-08-29 23:15:45 -05001819 if (!has_dynamic_exclusive_scissor_nv && exclusive_scissor_struct &&
1820 exclusive_scissor_struct->exclusiveScissorCount > 0 && exclusive_scissor_struct->pExclusiveScissors == nullptr) {
1821 skip |= log_msg(
1822 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, VK_NULL_HANDLE,
1823 "VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-pDynamicStates-02030",
1824 "vkCreateGraphicsPipelines: The exclusive scissor state is static (pCreateInfos[%" PRIu32
1825 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV), but pCreateInfos[%" PRIu32
1826 "] pExclusiveScissors (=NULL) is an invalid pointer.",
1827 i, i);
1828 }
1829
Jeff Bolz9af91c52018-09-01 21:53:57 -05001830 if (!has_dynamic_shading_rate_palette_nv && shading_rate_image_struct &&
1831 shading_rate_image_struct->viewportCount > 0 && shading_rate_image_struct->pShadingRatePalettes == nullptr) {
1832 skip |= log_msg(
1833 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, VK_NULL_HANDLE,
1834 "VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-pDynamicStates-02057",
1835 "vkCreateGraphicsPipelines: The shading rate palette state is static (pCreateInfos[%" PRIu32
1836 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_VIEWPORT_SHADING_RATE_PALETTE_NV), but pCreateInfos[%" PRIu32
1837 "] pShadingRatePalettes (=NULL) is an invalid pointer.",
1838 i, i);
1839 }
1840
Petr Krausb3fcdb42018-01-09 22:09:09 +01001841 // validate the VkViewports
1842 if (!has_dynamic_viewport && viewport_state.pViewports) {
1843 for (uint32_t viewport_i = 0; viewport_i < viewport_state.viewportCount; ++viewport_i) {
1844 const auto &viewport = viewport_state.pViewports[viewport_i]; // will crash on invalid ptr
1845 const char fn_name[] = "vkCreateGraphicsPipelines";
1846 const std::string param_name = "pCreateInfos[" + std::to_string(i) + "].pViewportState->pViewports[" +
1847 std::to_string(viewport_i) + "]";
1848 skip |= pv_VkViewport(device_data, viewport, fn_name, param_name.c_str(),
1849 VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT);
1850 }
1851 }
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001852
1853 if (has_dynamic_viewport_w_scaling_nv && !device_data->extensions.vk_nv_clip_space_w_scaling) {
1854 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001855 VK_NULL_HANDLE, kVUID_PVError_ExtensionNotEnabled,
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001856 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
Dave Houltona9df0ce2018-02-07 10:51:23 -07001857 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_VIEWPORT_W_SCALING_NV, but "
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001858 "VK_NV_clip_space_w_scaling extension is not enabled.",
1859 i);
1860 }
1861
1862 if (has_dynamic_discard_rectangle_ext && !device_data->extensions.vk_ext_discard_rectangles) {
1863 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001864 VK_NULL_HANDLE, kVUID_PVError_ExtensionNotEnabled,
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001865 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
Dave Houltona9df0ce2018-02-07 10:51:23 -07001866 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_DISCARD_RECTANGLE_EXT, but "
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001867 "VK_EXT_discard_rectangles extension is not enabled.",
1868 i);
1869 }
1870
1871 if (has_dynamic_sample_locations_ext && !device_data->extensions.vk_ext_sample_locations) {
1872 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001873 VK_NULL_HANDLE, kVUID_PVError_ExtensionNotEnabled,
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001874 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
Dave Houltona9df0ce2018-02-07 10:51:23 -07001875 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_SAMPLE_LOCATIONS_EXT, but "
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001876 "VK_EXT_sample_locations extension is not enabled.",
1877 i);
1878 }
Jeff Bolz3e71f782018-08-29 23:15:45 -05001879
1880 if (has_dynamic_exclusive_scissor_nv && !device_data->extensions.vk_nv_scissor_exclusive) {
1881 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
1882 VK_NULL_HANDLE, kVUID_PVError_ExtensionNotEnabled,
1883 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1884 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV, but "
1885 "VK_NV_scissor_exclusive extension is not enabled.",
1886 i);
1887 }
Jeff Bolz9af91c52018-09-01 21:53:57 -05001888
1889 if (coarse_sample_order_struct &&
1890 coarse_sample_order_struct->sampleOrderType != VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV &&
1891 coarse_sample_order_struct->customSampleOrderCount != 0) {
1892 skip |=
1893 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
1894 VK_NULL_HANDLE, "VUID-VkPipelineViewportCoarseSampleOrderStateCreateInfoNV-sampleOrderType-02072",
1895 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "] "
1896 "VkPipelineViewportCoarseSampleOrderStateCreateInfoNV sampleOrderType is not "
1897 "VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV and customSampleOrderCount is not 0.",
1898 i);
1899 }
1900
1901 if (coarse_sample_order_struct) {
1902 for (uint32_t order_i = 0; order_i < coarse_sample_order_struct->customSampleOrderCount; ++order_i) {
1903 skip |= ValidateCoarseSampleOrderCustomNV(device_data, &coarse_sample_order_struct->pCustomSampleOrders[order_i]);
1904 }
1905 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001906 }
1907
1908 if (pCreateInfos[i].pMultisampleState == nullptr) {
1909 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001910 "VUID-VkGraphicsPipelineCreateInfo-rasterizerDiscardEnable-00751",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001911 "vkCreateGraphicsPipelines: if pCreateInfos[%d].pRasterizationState->rasterizerDiscardEnable "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001912 "is VK_FALSE, pCreateInfos[%d].pMultisampleState must not be NULL.",
1913 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001914 } else {
Dave Houltonb3bbec72018-01-17 10:13:33 -07001915 const VkStructureType valid_next_stypes[] = {LvlTypeMap<VkPipelineCoverageModulationStateCreateInfoNV>::kSType,
1916 LvlTypeMap<VkPipelineCoverageToColorStateCreateInfoNV>::kSType,
1917 LvlTypeMap<VkPipelineSampleLocationsStateCreateInfoEXT>::kSType};
Mike Schuchardt97662b02017-12-06 13:31:29 -07001918 const char *valid_struct_names =
Dave Houltona9df0ce2018-02-07 10:51:23 -07001919 "VkPipelineCoverageModulationStateCreateInfoNV, VkPipelineCoverageToColorStateCreateInfoNV, "
John Zulauf96b0e422017-11-14 11:43:19 -07001920 "VkPipelineSampleLocationsStateCreateInfoEXT";
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001921 skip |= validate_struct_pnext(
1922 report_data, "vkCreateGraphicsPipelines",
John Zulauf96b0e422017-11-14 11:43:19 -07001923 ParameterName("pCreateInfos[%i].pMultisampleState->pNext", ParameterName::IndexVector{i}),
1924 valid_struct_names, pCreateInfos[i].pMultisampleState->pNext, 3, valid_next_stypes, GeneratedHeaderVersion,
Dave Houlton413a6782018-05-22 13:01:54 -06001925 "VUID-VkPipelineMultisampleStateCreateInfo-pNext-pNext");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001926
1927 skip |= validate_reserved_flags(
1928 report_data, "vkCreateGraphicsPipelines",
1929 ParameterName("pCreateInfos[%i].pMultisampleState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06001930 pCreateInfos[i].pMultisampleState->flags, "VUID-VkPipelineMultisampleStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001931
1932 skip |= validate_bool32(
1933 report_data, "vkCreateGraphicsPipelines",
1934 ParameterName("pCreateInfos[%i].pMultisampleState->sampleShadingEnable", ParameterName::IndexVector{i}),
1935 pCreateInfos[i].pMultisampleState->sampleShadingEnable);
1936
1937 skip |= validate_array(
1938 report_data, "vkCreateGraphicsPipelines",
1939 ParameterName("pCreateInfos[%i].pMultisampleState->rasterizationSamples", ParameterName::IndexVector{i}),
1940 ParameterName("pCreateInfos[%i].pMultisampleState->pSampleMask", ParameterName::IndexVector{i}),
Gabríel Arthúr Pétursson092b29b2018-03-21 22:44:11 +00001941 pCreateInfos[i].pMultisampleState->rasterizationSamples, &pCreateInfos[i].pMultisampleState->pSampleMask,
Dave Houlton413a6782018-05-22 13:01:54 -06001942 true, false, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001943
1944 skip |= validate_bool32(
1945 report_data, "vkCreateGraphicsPipelines",
1946 ParameterName("pCreateInfos[%i].pMultisampleState->alphaToCoverageEnable", ParameterName::IndexVector{i}),
1947 pCreateInfos[i].pMultisampleState->alphaToCoverageEnable);
1948
1949 skip |= validate_bool32(
1950 report_data, "vkCreateGraphicsPipelines",
1951 ParameterName("pCreateInfos[%i].pMultisampleState->alphaToOneEnable", ParameterName::IndexVector{i}),
1952 pCreateInfos[i].pMultisampleState->alphaToOneEnable);
1953
1954 if (pCreateInfos[i].pMultisampleState->sType != VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO) {
1955 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001956 kVUID_PVError_InvalidStructSType,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001957 "vkCreateGraphicsPipelines: parameter pCreateInfos[%d].pMultisampleState->sType must be "
1958 "VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO",
1959 i);
1960 }
John Zulauf7acac592017-11-06 11:15:53 -07001961 if (pCreateInfos[i].pMultisampleState->sampleShadingEnable == VK_TRUE) {
1962 if (!device_data->physical_device_features.sampleRateShading) {
1963 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001964 "VUID-VkPipelineMultisampleStateCreateInfo-sampleShadingEnable-00784",
John Zulauf7acac592017-11-06 11:15:53 -07001965 "vkCreateGraphicsPipelines(): parameter "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001966 "pCreateInfos[%d].pMultisampleState->sampleShadingEnable.",
1967 i);
John Zulauf7acac592017-11-06 11:15:53 -07001968 }
1969 // TODO Add documentation issue about when minSampleShading must be in range and when it is ignored
1970 // For now a "least noise" test *only* when sampleShadingEnable is VK_TRUE.
1971 if (!in_inclusive_range(pCreateInfos[i].pMultisampleState->minSampleShading, 0.F, 1.0F)) {
1972 skip |= log_msg(
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001973 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001974 "VUID-VkPipelineMultisampleStateCreateInfo-minSampleShading-00786",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001975 "vkCreateGraphicsPipelines(): parameter pCreateInfos[%d].pMultisampleState->minSampleShading.", i);
John Zulauf7acac592017-11-06 11:15:53 -07001976 }
1977 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001978 }
1979
Petr Krause91f7a12017-12-14 20:57:36 +01001980 bool uses_color_attachment = false;
1981 bool uses_depthstencil_attachment = false;
1982 {
1983 const auto subpasses_uses_it = device_data->renderpasses_states.find(pCreateInfos[i].renderPass);
1984 if (subpasses_uses_it != device_data->renderpasses_states.end()) {
1985 const auto &subpasses_uses = subpasses_uses_it->second;
1986 if (subpasses_uses.subpasses_using_color_attachment.count(pCreateInfos[i].subpass))
1987 uses_color_attachment = true;
1988 if (subpasses_uses.subpasses_using_depthstencil_attachment.count(pCreateInfos[i].subpass))
1989 uses_depthstencil_attachment = true;
1990 }
1991 }
1992
1993 if (pCreateInfos[i].pDepthStencilState != nullptr && uses_depthstencil_attachment) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001994 skip |= validate_struct_pnext(
1995 report_data, "vkCreateGraphicsPipelines",
1996 ParameterName("pCreateInfos[%i].pDepthStencilState->pNext", ParameterName::IndexVector{i}), NULL,
Dave Houlton413a6782018-05-22 13:01:54 -06001997 pCreateInfos[i].pDepthStencilState->pNext, 0, NULL, GeneratedHeaderVersion,
1998 "VUID-VkPipelineDepthStencilStateCreateInfo-pNext-pNext");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001999
2000 skip |= validate_reserved_flags(
2001 report_data, "vkCreateGraphicsPipelines",
2002 ParameterName("pCreateInfos[%i].pDepthStencilState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06002003 pCreateInfos[i].pDepthStencilState->flags, "VUID-VkPipelineDepthStencilStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002004
2005 skip |= validate_bool32(
2006 report_data, "vkCreateGraphicsPipelines",
2007 ParameterName("pCreateInfos[%i].pDepthStencilState->depthTestEnable", ParameterName::IndexVector{i}),
2008 pCreateInfos[i].pDepthStencilState->depthTestEnable);
2009
2010 skip |= validate_bool32(
2011 report_data, "vkCreateGraphicsPipelines",
2012 ParameterName("pCreateInfos[%i].pDepthStencilState->depthWriteEnable", ParameterName::IndexVector{i}),
2013 pCreateInfos[i].pDepthStencilState->depthWriteEnable);
2014
2015 skip |= validate_ranged_enum(
2016 report_data, "vkCreateGraphicsPipelines",
2017 ParameterName("pCreateInfos[%i].pDepthStencilState->depthCompareOp", ParameterName::IndexVector{i}),
2018 "VkCompareOp", AllVkCompareOpEnums, pCreateInfos[i].pDepthStencilState->depthCompareOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002019 "VUID-VkPipelineDepthStencilStateCreateInfo-depthCompareOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002020
2021 skip |= validate_bool32(
2022 report_data, "vkCreateGraphicsPipelines",
2023 ParameterName("pCreateInfos[%i].pDepthStencilState->depthBoundsTestEnable", ParameterName::IndexVector{i}),
2024 pCreateInfos[i].pDepthStencilState->depthBoundsTestEnable);
2025
2026 skip |= validate_bool32(
2027 report_data, "vkCreateGraphicsPipelines",
2028 ParameterName("pCreateInfos[%i].pDepthStencilState->stencilTestEnable", ParameterName::IndexVector{i}),
2029 pCreateInfos[i].pDepthStencilState->stencilTestEnable);
2030
2031 skip |= validate_ranged_enum(
2032 report_data, "vkCreateGraphicsPipelines",
2033 ParameterName("pCreateInfos[%i].pDepthStencilState->front.failOp", ParameterName::IndexVector{i}),
2034 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->front.failOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002035 "VUID-VkStencilOpState-failOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002036
2037 skip |= validate_ranged_enum(
2038 report_data, "vkCreateGraphicsPipelines",
2039 ParameterName("pCreateInfos[%i].pDepthStencilState->front.passOp", ParameterName::IndexVector{i}),
2040 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->front.passOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002041 "VUID-VkStencilOpState-passOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002042
2043 skip |= validate_ranged_enum(
2044 report_data, "vkCreateGraphicsPipelines",
2045 ParameterName("pCreateInfos[%i].pDepthStencilState->front.depthFailOp", ParameterName::IndexVector{i}),
2046 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->front.depthFailOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002047 "VUID-VkStencilOpState-depthFailOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002048
2049 skip |= validate_ranged_enum(
2050 report_data, "vkCreateGraphicsPipelines",
2051 ParameterName("pCreateInfos[%i].pDepthStencilState->front.compareOp", ParameterName::IndexVector{i}),
2052 "VkCompareOp", AllVkCompareOpEnums, pCreateInfos[i].pDepthStencilState->front.compareOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002053 "VUID-VkPipelineDepthStencilStateCreateInfo-depthCompareOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002054
2055 skip |= validate_ranged_enum(
2056 report_data, "vkCreateGraphicsPipelines",
2057 ParameterName("pCreateInfos[%i].pDepthStencilState->back.failOp", ParameterName::IndexVector{i}),
2058 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->back.failOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002059 "VUID-VkStencilOpState-failOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002060
2061 skip |= validate_ranged_enum(
2062 report_data, "vkCreateGraphicsPipelines",
2063 ParameterName("pCreateInfos[%i].pDepthStencilState->back.passOp", ParameterName::IndexVector{i}),
2064 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->back.passOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002065 "VUID-VkStencilOpState-passOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002066
2067 skip |= validate_ranged_enum(
2068 report_data, "vkCreateGraphicsPipelines",
2069 ParameterName("pCreateInfos[%i].pDepthStencilState->back.depthFailOp", ParameterName::IndexVector{i}),
2070 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->back.depthFailOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002071 "VUID-VkStencilOpState-depthFailOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002072
2073 skip |= validate_ranged_enum(
2074 report_data, "vkCreateGraphicsPipelines",
2075 ParameterName("pCreateInfos[%i].pDepthStencilState->back.compareOp", ParameterName::IndexVector{i}),
2076 "VkCompareOp", AllVkCompareOpEnums, pCreateInfos[i].pDepthStencilState->back.compareOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002077 "VUID-VkPipelineDepthStencilStateCreateInfo-depthCompareOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002078
2079 if (pCreateInfos[i].pDepthStencilState->sType != VK_STRUCTURE_TYPE_PIPELINE_DEPTH_STENCIL_STATE_CREATE_INFO) {
2080 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002081 kVUID_PVError_InvalidStructSType,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002082 "vkCreateGraphicsPipelines: parameter pCreateInfos[%d].pDepthStencilState->sType must be "
2083 "VK_STRUCTURE_TYPE_PIPELINE_DEPTH_STENCIL_STATE_CREATE_INFO",
2084 i);
2085 }
2086 }
2087
Petr Krause91f7a12017-12-14 20:57:36 +01002088 if (pCreateInfos[i].pColorBlendState != nullptr && uses_color_attachment) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002089 skip |= validate_struct_pnext(
2090 report_data, "vkCreateGraphicsPipelines",
2091 ParameterName("pCreateInfos[%i].pColorBlendState->pNext", ParameterName::IndexVector{i}), NULL,
Dave Houlton413a6782018-05-22 13:01:54 -06002092 pCreateInfos[i].pColorBlendState->pNext, 0, NULL, GeneratedHeaderVersion,
2093 "VUID-VkPipelineColorBlendStateCreateInfo-pNext-pNext");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002094
2095 skip |= validate_reserved_flags(
2096 report_data, "vkCreateGraphicsPipelines",
2097 ParameterName("pCreateInfos[%i].pColorBlendState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06002098 pCreateInfos[i].pColorBlendState->flags, "VUID-VkPipelineColorBlendStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002099
2100 skip |= validate_bool32(
2101 report_data, "vkCreateGraphicsPipelines",
2102 ParameterName("pCreateInfos[%i].pColorBlendState->logicOpEnable", ParameterName::IndexVector{i}),
2103 pCreateInfos[i].pColorBlendState->logicOpEnable);
2104
2105 skip |= validate_array(
2106 report_data, "vkCreateGraphicsPipelines",
2107 ParameterName("pCreateInfos[%i].pColorBlendState->attachmentCount", ParameterName::IndexVector{i}),
2108 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments", ParameterName::IndexVector{i}),
Gabríel Arthúr Pétursson092b29b2018-03-21 22:44:11 +00002109 pCreateInfos[i].pColorBlendState->attachmentCount, &pCreateInfos[i].pColorBlendState->pAttachments, false,
Dave Houlton413a6782018-05-22 13:01:54 -06002110 true, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002111
2112 if (pCreateInfos[i].pColorBlendState->pAttachments != NULL) {
2113 for (uint32_t attachmentIndex = 0; attachmentIndex < pCreateInfos[i].pColorBlendState->attachmentCount;
2114 ++attachmentIndex) {
2115 skip |= validate_bool32(report_data, "vkCreateGraphicsPipelines",
2116 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].blendEnable",
2117 ParameterName::IndexVector{i, attachmentIndex}),
2118 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].blendEnable);
2119
2120 skip |= validate_ranged_enum(
2121 report_data, "vkCreateGraphicsPipelines",
2122 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].srcColorBlendFactor",
2123 ParameterName::IndexVector{i, attachmentIndex}),
2124 "VkBlendFactor", AllVkBlendFactorEnums,
2125 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].srcColorBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06002126 "VUID-VkPipelineColorBlendAttachmentState-srcColorBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002127
2128 skip |= validate_ranged_enum(
2129 report_data, "vkCreateGraphicsPipelines",
2130 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].dstColorBlendFactor",
2131 ParameterName::IndexVector{i, attachmentIndex}),
2132 "VkBlendFactor", AllVkBlendFactorEnums,
2133 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].dstColorBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06002134 "VUID-VkPipelineColorBlendAttachmentState-dstColorBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002135
2136 skip |= validate_ranged_enum(
2137 report_data, "vkCreateGraphicsPipelines",
2138 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].colorBlendOp",
2139 ParameterName::IndexVector{i, attachmentIndex}),
2140 "VkBlendOp", AllVkBlendOpEnums,
2141 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].colorBlendOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002142 "VUID-VkPipelineColorBlendAttachmentState-colorBlendOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002143
2144 skip |= validate_ranged_enum(
2145 report_data, "vkCreateGraphicsPipelines",
2146 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].srcAlphaBlendFactor",
2147 ParameterName::IndexVector{i, attachmentIndex}),
2148 "VkBlendFactor", AllVkBlendFactorEnums,
2149 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].srcAlphaBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06002150 "VUID-VkPipelineColorBlendAttachmentState-srcAlphaBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002151
2152 skip |= validate_ranged_enum(
2153 report_data, "vkCreateGraphicsPipelines",
2154 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].dstAlphaBlendFactor",
2155 ParameterName::IndexVector{i, attachmentIndex}),
2156 "VkBlendFactor", AllVkBlendFactorEnums,
2157 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].dstAlphaBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06002158 "VUID-VkPipelineColorBlendAttachmentState-dstAlphaBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002159
2160 skip |= validate_ranged_enum(
2161 report_data, "vkCreateGraphicsPipelines",
2162 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].alphaBlendOp",
2163 ParameterName::IndexVector{i, attachmentIndex}),
2164 "VkBlendOp", AllVkBlendOpEnums,
2165 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].alphaBlendOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002166 "VUID-VkPipelineColorBlendAttachmentState-alphaBlendOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002167
2168 skip |=
2169 validate_flags(report_data, "vkCreateGraphicsPipelines",
2170 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].colorWriteMask",
2171 ParameterName::IndexVector{i, attachmentIndex}),
2172 "VkColorComponentFlagBits", AllVkColorComponentFlagBits,
2173 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].colorWriteMask,
Dave Houlton413a6782018-05-22 13:01:54 -06002174 false, false, "VUID-VkPipelineColorBlendAttachmentState-colorWriteMask-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002175 }
2176 }
2177
2178 if (pCreateInfos[i].pColorBlendState->sType != VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO) {
2179 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002180 kVUID_PVError_InvalidStructSType,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002181 "vkCreateGraphicsPipelines: parameter pCreateInfos[%d].pColorBlendState->sType must be "
2182 "VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO",
2183 i);
2184 }
2185
2186 // If logicOpEnable is VK_TRUE, logicOp must be a valid VkLogicOp value
2187 if (pCreateInfos[i].pColorBlendState->logicOpEnable == VK_TRUE) {
2188 skip |= validate_ranged_enum(
2189 report_data, "vkCreateGraphicsPipelines",
2190 ParameterName("pCreateInfos[%i].pColorBlendState->logicOp", ParameterName::IndexVector{i}), "VkLogicOp",
Dave Houlton413a6782018-05-22 13:01:54 -06002191 AllVkLogicOpEnums, pCreateInfos[i].pColorBlendState->logicOp,
2192 "VUID-VkPipelineColorBlendStateCreateInfo-logicOpEnable-00607");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002193 }
2194 }
2195 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002196
Petr Kraus9752aae2017-11-24 03:05:50 +01002197 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_DERIVATIVE_BIT) {
2198 if (pCreateInfos[i].basePipelineIndex != -1) {
2199 if (pCreateInfos[i].basePipelineHandle != VK_NULL_HANDLE) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07002200 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002201 "VUID-VkGraphicsPipelineCreateInfo-flags-00724",
Dave Houltona9df0ce2018-02-07 10:51:23 -07002202 "vkCreateGraphicsPipelines parameter, pCreateInfos->basePipelineHandle, must be "
2203 "VK_NULL_HANDLE if pCreateInfos->flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT flag "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002204 "and pCreateInfos->basePipelineIndex is not -1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002205 }
2206 }
2207
Petr Kraus9752aae2017-11-24 03:05:50 +01002208 if (pCreateInfos[i].basePipelineHandle != VK_NULL_HANDLE) {
2209 if (pCreateInfos[i].basePipelineIndex != -1) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07002210 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002211 "VUID-VkGraphicsPipelineCreateInfo-flags-00725",
Dave Houltona9df0ce2018-02-07 10:51:23 -07002212 "vkCreateGraphicsPipelines parameter, pCreateInfos->basePipelineIndex, must be -1 if "
2213 "pCreateInfos->flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT flag and "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002214 "pCreateInfos->basePipelineHandle is not VK_NULL_HANDLE.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002215 }
2216 }
2217 }
2218
Petr Kraus9752aae2017-11-24 03:05:50 +01002219 if (pCreateInfos[i].pRasterizationState) {
2220 if ((pCreateInfos[i].pRasterizationState->polygonMode != VK_POLYGON_MODE_FILL) &&
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002221 (device_data->physical_device_features.fillModeNonSolid == false)) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07002222 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002223 kVUID_PVError_DeviceFeature,
Dave Houltona9df0ce2018-02-07 10:51:23 -07002224 "vkCreateGraphicsPipelines parameter, VkPolygonMode "
2225 "pCreateInfos->pRasterizationState->polygonMode cannot be VK_POLYGON_MODE_POINT or "
2226 "VK_POLYGON_MODE_LINE if VkPhysicalDeviceFeatures->fillModeNonSolid is false.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002227 }
Petr Kraus299ba622017-11-24 03:09:03 +01002228
2229 if (!has_dynamic_line_width && !device_data->physical_device_features.wideLines &&
2230 (pCreateInfos[i].pRasterizationState->lineWidth != 1.0f)) {
Dave Houlton413a6782018-05-22 13:01:54 -06002231 skip |=
2232 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
2233 0, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-00749",
2234 "The line width state is static (pCreateInfos[%" PRIu32
2235 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_LINE_WIDTH) and "
2236 "VkPhysicalDeviceFeatures::wideLines is disabled, but pCreateInfos[%" PRIu32
2237 "].pRasterizationState->lineWidth (=%f) is not 1.0.",
2238 i, i, pCreateInfos[i].pRasterizationState->lineWidth);
Petr Kraus299ba622017-11-24 03:09:03 +01002239 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002240 }
2241
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002242 for (size_t j = 0; j < pCreateInfos[i].stageCount; j++) {
2243 skip |= validate_string(device_data->report_data, "vkCreateGraphicsPipelines",
2244 ParameterName("pCreateInfos[%i].pStages[%i].pName", ParameterName::IndexVector{i, j}),
Mark Lobodzinskiebee3552018-05-29 09:55:54 -06002245 "VUID-VkGraphicsPipelineCreateInfo-pStages-parameter", pCreateInfos[i].pStages[j].pName);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002246 }
2247 }
2248 }
2249
2250 return skip;
2251}
2252
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002253bool pv_vkCreateComputePipelines(VkDevice device, VkPipelineCache pipelineCache, uint32_t createInfoCount,
2254 const VkComputePipelineCreateInfo *pCreateInfos, const VkAllocationCallbacks *pAllocator,
2255 VkPipeline *pPipelines) {
2256 bool skip = false;
2257 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2258
2259 for (uint32_t i = 0; i < createInfoCount; i++) {
2260 skip |= validate_string(device_data->report_data, "vkCreateComputePipelines",
2261 ParameterName("pCreateInfos[%i].stage.pName", ParameterName::IndexVector{i}),
Mark Lobodzinskiebee3552018-05-29 09:55:54 -06002262 "VUID-VkPipelineShaderStageCreateInfo-pName-parameter", pCreateInfos[i].stage.pName);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002263 }
2264
2265 return skip;
2266}
2267
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002268bool pv_vkCreateSampler(VkDevice device, const VkSamplerCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
2269 VkSampler *pSampler) {
2270 bool skip = false;
2271 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2272 debug_report_data *report_data = device_data->report_data;
2273
2274 if (pCreateInfo != nullptr) {
John Zulauf71968502017-10-26 13:51:15 -06002275 const auto &features = device_data->physical_device_features;
2276 const auto &limits = device_data->device_limits;
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002277
John Zulauf71968502017-10-26 13:51:15 -06002278 if (pCreateInfo->anisotropyEnable == VK_TRUE) {
2279 if (!in_inclusive_range(pCreateInfo->maxAnisotropy, 1.0F, limits.maxSamplerAnisotropy)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002280 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002281 "VUID-VkSamplerCreateInfo-anisotropyEnable-01071",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002282 "vkCreateSampler(): value of %s must be in range [1.0, %f] %s, but %f found.",
John Zulauf71968502017-10-26 13:51:15 -06002283 "pCreateInfo->maxAnisotropy", limits.maxSamplerAnisotropy,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002284 "VkPhysicalDeviceLimits::maxSamplerAnistropy", pCreateInfo->maxAnisotropy);
John Zulauf71968502017-10-26 13:51:15 -06002285 }
2286
2287 // Anistropy cannot be enabled in sampler unless enabled as a feature
2288 if (features.samplerAnisotropy == VK_FALSE) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002289 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002290 "VUID-VkSamplerCreateInfo-anisotropyEnable-01070",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002291 "vkCreateSampler(): Anisotropic sampling feature is not enabled, %s must be VK_FALSE.",
2292 "pCreateInfo->anisotropyEnable");
John Zulauf71968502017-10-26 13:51:15 -06002293 }
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002294 }
John Zulauf71968502017-10-26 13:51:15 -06002295
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002296 if (pCreateInfo->unnormalizedCoordinates == VK_TRUE) {
2297 if (pCreateInfo->minFilter != pCreateInfo->magFilter) {
2298 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
2299 "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01072",
2300 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
2301 "pCreateInfo->minFilter (%s) and pCreateInfo->magFilter (%s) must be equal.",
2302 string_VkFilter(pCreateInfo->minFilter), string_VkFilter(pCreateInfo->magFilter));
2303 }
2304 if (pCreateInfo->mipmapMode != VK_SAMPLER_MIPMAP_MODE_NEAREST) {
2305 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
2306 "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01073",
2307 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
2308 "pCreateInfo->mipmapMode (%s) must be VK_SAMPLER_MIPMAP_MODE_NEAREST.",
2309 string_VkSamplerMipmapMode(pCreateInfo->mipmapMode));
2310 }
2311 if (pCreateInfo->minLod != 0.0f || pCreateInfo->maxLod != 0.0f) {
2312 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
2313 "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01074",
2314 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
2315 "pCreateInfo->minLod (%f) and pCreateInfo->maxLod (%f) must both be zero.",
2316 pCreateInfo->minLod, pCreateInfo->maxLod);
2317 }
2318 if ((pCreateInfo->addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE &&
2319 pCreateInfo->addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER) ||
2320 (pCreateInfo->addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE &&
2321 pCreateInfo->addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER)) {
2322 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
2323 "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01075",
2324 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
2325 "pCreateInfo->addressModeU (%s) and pCreateInfo->addressModeV (%s) must both be "
2326 "VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE or VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER.",
2327 string_VkSamplerAddressMode(pCreateInfo->addressModeU),
2328 string_VkSamplerAddressMode(pCreateInfo->addressModeV));
2329 }
2330 if (pCreateInfo->anisotropyEnable == VK_TRUE) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002331 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002332 "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01076",
Dave Houltona9df0ce2018-02-07 10:51:23 -07002333 "vkCreateSampler(): pCreateInfo->anisotropyEnable and pCreateInfo->unnormalizedCoordinates must "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002334 "not both be VK_TRUE.");
John Zulauf71968502017-10-26 13:51:15 -06002335 }
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002336 if (pCreateInfo->compareEnable == VK_TRUE) {
2337 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
2338 "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01077",
2339 "vkCreateSampler(): pCreateInfo->compareEnable and pCreateInfo->unnormalizedCoordinates must "
2340 "not both be VK_TRUE.");
2341 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002342 }
2343
2344 // If compareEnable is VK_TRUE, compareOp must be a valid VkCompareOp value
2345 if (pCreateInfo->compareEnable == VK_TRUE) {
Dave Houlton413a6782018-05-22 13:01:54 -06002346 skip |=
2347 validate_ranged_enum(report_data, "vkCreateSampler", "pCreateInfo->compareOp", "VkCompareOp", AllVkCompareOpEnums,
2348 pCreateInfo->compareOp, "VUID-VkSamplerCreateInfo-compareEnable-01080");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002349 }
2350
2351 // If any of addressModeU, addressModeV or addressModeW are VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER, borderColor must be a
2352 // valid VkBorderColor value
2353 if ((pCreateInfo->addressModeU == VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER) ||
2354 (pCreateInfo->addressModeV == VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER) ||
2355 (pCreateInfo->addressModeW == VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER)) {
2356 skip |= validate_ranged_enum(report_data, "vkCreateSampler", "pCreateInfo->borderColor", "VkBorderColor",
Dave Houlton413a6782018-05-22 13:01:54 -06002357 AllVkBorderColorEnums, pCreateInfo->borderColor,
2358 "VUID-VkSamplerCreateInfo-addressModeU-01078");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002359 }
2360
2361 // If any of addressModeU, addressModeV or addressModeW are VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE, the
2362 // VK_KHR_sampler_mirror_clamp_to_edge extension must be enabled
2363 if (!device_data->extensions.vk_khr_sampler_mirror_clamp_to_edge &&
2364 ((pCreateInfo->addressModeU == VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE) ||
2365 (pCreateInfo->addressModeV == VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE) ||
2366 (pCreateInfo->addressModeW == VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE))) {
Dave Houlton413a6782018-05-22 13:01:54 -06002367 skip |=
2368 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
2369 "VUID-VkSamplerCreateInfo-addressModeU-01079",
2370 "vkCreateSampler(): A VkSamplerAddressMode value is set to VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE "
2371 "but the VK_KHR_sampler_mirror_clamp_to_edge extension has not been enabled.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002372 }
John Zulauf275805c2017-10-26 15:34:49 -06002373
2374 // Checks for the IMG cubic filtering extension
2375 if (device_data->extensions.vk_img_filter_cubic) {
2376 if ((pCreateInfo->anisotropyEnable == VK_TRUE) &&
2377 ((pCreateInfo->minFilter == VK_FILTER_CUBIC_IMG) || (pCreateInfo->magFilter == VK_FILTER_CUBIC_IMG))) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002378 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002379 "VUID-VkSamplerCreateInfo-magFilter-01081",
Dave Houltona9df0ce2018-02-07 10:51:23 -07002380 "vkCreateSampler(): Anisotropic sampling must not be VK_TRUE when either minFilter or magFilter "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002381 "are VK_FILTER_CUBIC_IMG.");
John Zulauf275805c2017-10-26 15:34:49 -06002382 }
2383 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002384 }
2385
2386 return skip;
2387}
2388
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002389bool pv_vkCreateDescriptorSetLayout(VkDevice device, const VkDescriptorSetLayoutCreateInfo *pCreateInfo,
2390 const VkAllocationCallbacks *pAllocator, VkDescriptorSetLayout *pSetLayout) {
2391 bool skip = false;
2392 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2393 debug_report_data *report_data = device_data->report_data;
2394
2395 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
2396 if ((pCreateInfo != nullptr) && (pCreateInfo->pBindings != nullptr)) {
2397 for (uint32_t i = 0; i < pCreateInfo->bindingCount; ++i) {
2398 if (pCreateInfo->pBindings[i].descriptorCount != 0) {
2399 // If descriptorType is VK_DESCRIPTOR_TYPE_SAMPLER or VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER, and descriptorCount
2400 // is not 0 and pImmutableSamplers is not NULL, pImmutableSamplers must be a pointer to an array of descriptorCount
2401 // valid VkSampler handles
2402 if (((pCreateInfo->pBindings[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLER) ||
2403 (pCreateInfo->pBindings[i].descriptorType == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER)) &&
2404 (pCreateInfo->pBindings[i].pImmutableSamplers != nullptr)) {
2405 for (uint32_t descriptor_index = 0; descriptor_index < pCreateInfo->pBindings[i].descriptorCount;
2406 ++descriptor_index) {
2407 if (pCreateInfo->pBindings[i].pImmutableSamplers[descriptor_index] == VK_NULL_HANDLE) {
2408 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002409 kVUID_PVError_RequiredParameter,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002410 "vkCreateDescriptorSetLayout: required parameter "
Dave Houltona9df0ce2018-02-07 10:51:23 -07002411 "pCreateInfo->pBindings[%d].pImmutableSamplers[%d] specified as VK_NULL_HANDLE",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002412 i, descriptor_index);
2413 }
2414 }
2415 }
2416
2417 // If descriptorCount is not 0, stageFlags must be a valid combination of VkShaderStageFlagBits values
2418 if ((pCreateInfo->pBindings[i].stageFlags != 0) &&
2419 ((pCreateInfo->pBindings[i].stageFlags & (~AllVkShaderStageFlagBits)) != 0)) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07002420 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002421 "VUID-VkDescriptorSetLayoutBinding-descriptorCount-00283",
Dave Houltona9df0ce2018-02-07 10:51:23 -07002422 "vkCreateDescriptorSetLayout(): if pCreateInfo->pBindings[%d].descriptorCount is not 0, "
2423 "pCreateInfo->pBindings[%d].stageFlags must be a valid combination of VkShaderStageFlagBits "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002424 "values.",
2425 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002426 }
2427 }
2428 }
2429 }
2430
2431 return skip;
2432}
2433
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002434bool pv_vkFreeDescriptorSets(VkDevice device, VkDescriptorPool descriptorPool, uint32_t descriptorSetCount,
2435 const VkDescriptorSet *pDescriptorSets) {
2436 bool skip = false;
2437 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2438 debug_report_data *report_data = device_data->report_data;
2439
2440 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
2441 // This is an array of handles, where the elements are allowed to be VK_NULL_HANDLE, and does not require any validation beyond
2442 // validate_array()
2443 skip |= validate_array(report_data, "vkFreeDescriptorSets", "descriptorSetCount", "pDescriptorSets", descriptorSetCount,
Dave Houlton413a6782018-05-22 13:01:54 -06002444 &pDescriptorSets, true, true, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002445 return skip;
2446}
2447
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002448bool pv_vkUpdateDescriptorSets(VkDevice device, uint32_t descriptorWriteCount, const VkWriteDescriptorSet *pDescriptorWrites,
2449 uint32_t descriptorCopyCount, const VkCopyDescriptorSet *pDescriptorCopies) {
2450 bool skip = false;
2451 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2452 debug_report_data *report_data = device_data->report_data;
2453
2454 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
2455 if (pDescriptorWrites != NULL) {
2456 for (uint32_t i = 0; i < descriptorWriteCount; ++i) {
2457 // descriptorCount must be greater than 0
2458 if (pDescriptorWrites[i].descriptorCount == 0) {
2459 skip |=
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002460 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002461 "VUID-VkWriteDescriptorSet-descriptorCount-arraylength",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002462 "vkUpdateDescriptorSets(): parameter pDescriptorWrites[%d].descriptorCount must be greater than 0.", i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002463 }
2464
2465 // dstSet must be a valid VkDescriptorSet handle
2466 skip |= validate_required_handle(report_data, "vkUpdateDescriptorSets",
2467 ParameterName("pDescriptorWrites[%i].dstSet", ParameterName::IndexVector{i}),
2468 pDescriptorWrites[i].dstSet);
2469
2470 if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLER) ||
2471 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER) ||
2472 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE) ||
2473 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_IMAGE) ||
2474 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT)) {
2475 // If descriptorType is VK_DESCRIPTOR_TYPE_SAMPLER, VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER,
2476 // VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE, VK_DESCRIPTOR_TYPE_STORAGE_IMAGE or VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT,
2477 // pImageInfo must be a pointer to an array of descriptorCount valid VkDescriptorImageInfo structures
2478 if (pDescriptorWrites[i].pImageInfo == nullptr) {
2479 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002480 "VUID-VkWriteDescriptorSet-descriptorType-00322",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002481 "vkUpdateDescriptorSets(): if pDescriptorWrites[%d].descriptorType is "
2482 "VK_DESCRIPTOR_TYPE_SAMPLER, VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER, "
2483 "VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE, VK_DESCRIPTOR_TYPE_STORAGE_IMAGE or "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002484 "VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT, pDescriptorWrites[%d].pImageInfo must not be NULL.",
2485 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002486 } else if (pDescriptorWrites[i].descriptorType != VK_DESCRIPTOR_TYPE_SAMPLER) {
2487 // If descriptorType is VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER, VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE,
2488 // VK_DESCRIPTOR_TYPE_STORAGE_IMAGE or VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT, the imageView and imageLayout
2489 // members of any given element of pImageInfo must be a valid VkImageView and VkImageLayout, respectively
2490 for (uint32_t descriptor_index = 0; descriptor_index < pDescriptorWrites[i].descriptorCount;
2491 ++descriptor_index) {
2492 skip |= validate_required_handle(report_data, "vkUpdateDescriptorSets",
2493 ParameterName("pDescriptorWrites[%i].pImageInfo[%i].imageView",
2494 ParameterName::IndexVector{i, descriptor_index}),
2495 pDescriptorWrites[i].pImageInfo[descriptor_index].imageView);
2496 skip |= validate_ranged_enum(report_data, "vkUpdateDescriptorSets",
2497 ParameterName("pDescriptorWrites[%i].pImageInfo[%i].imageLayout",
2498 ParameterName::IndexVector{i, descriptor_index}),
2499 "VkImageLayout", AllVkImageLayoutEnums,
Dave Houlton413a6782018-05-22 13:01:54 -06002500 pDescriptorWrites[i].pImageInfo[descriptor_index].imageLayout, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002501 }
2502 }
2503 } else if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER) ||
2504 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER) ||
2505 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC) ||
2506 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC)) {
2507 // If descriptorType is VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER, VK_DESCRIPTOR_TYPE_STORAGE_BUFFER,
2508 // VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC or VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC, pBufferInfo must be a
2509 // pointer to an array of descriptorCount valid VkDescriptorBufferInfo structures
2510 if (pDescriptorWrites[i].pBufferInfo == nullptr) {
2511 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002512 "VUID-VkWriteDescriptorSet-descriptorType-00324",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002513 "vkUpdateDescriptorSets(): if pDescriptorWrites[%d].descriptorType is "
2514 "VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER, VK_DESCRIPTOR_TYPE_STORAGE_BUFFER, "
2515 "VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC or VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC, "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002516 "pDescriptorWrites[%d].pBufferInfo must not be NULL.",
2517 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002518 } else {
2519 for (uint32_t descriptorIndex = 0; descriptorIndex < pDescriptorWrites[i].descriptorCount; ++descriptorIndex) {
2520 skip |= validate_required_handle(report_data, "vkUpdateDescriptorSets",
2521 ParameterName("pDescriptorWrites[%i].pBufferInfo[%i].buffer",
2522 ParameterName::IndexVector{i, descriptorIndex}),
2523 pDescriptorWrites[i].pBufferInfo[descriptorIndex].buffer);
2524 }
2525 }
2526 } else if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER) ||
2527 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER)) {
2528 // If descriptorType is VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER or VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER,
2529 // pTexelBufferView must be a pointer to an array of descriptorCount valid VkBufferView handles
2530 if (pDescriptorWrites[i].pTexelBufferView == nullptr) {
2531 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002532 "VUID-VkWriteDescriptorSet-descriptorType-00323",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002533 "vkUpdateDescriptorSets(): if pDescriptorWrites[%d].descriptorType is "
2534 "VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER or VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER, "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002535 "pDescriptorWrites[%d].pTexelBufferView must not be NULL.",
2536 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002537 } else {
2538 for (uint32_t descriptor_index = 0; descriptor_index < pDescriptorWrites[i].descriptorCount;
2539 ++descriptor_index) {
2540 skip |= validate_required_handle(report_data, "vkUpdateDescriptorSets",
2541 ParameterName("pDescriptorWrites[%i].pTexelBufferView[%i]",
2542 ParameterName::IndexVector{i, descriptor_index}),
2543 pDescriptorWrites[i].pTexelBufferView[descriptor_index]);
2544 }
2545 }
2546 }
2547
2548 if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER) ||
2549 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC)) {
2550 VkDeviceSize uniformAlignment = device_data->device_limits.minUniformBufferOffsetAlignment;
2551 for (uint32_t j = 0; j < pDescriptorWrites[i].descriptorCount; j++) {
2552 if (pDescriptorWrites[i].pBufferInfo != NULL) {
2553 if (SafeModulo(pDescriptorWrites[i].pBufferInfo[j].offset, uniformAlignment) != 0) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06002554 skip |=
2555 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002556 VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0,
2557 "VUID-VkWriteDescriptorSet-descriptorType-00327",
Mark Lobodzinski88529492018-04-01 10:38:15 -06002558 "vkUpdateDescriptorSets(): pDescriptorWrites[%d].pBufferInfo[%d].offset (0x%" PRIxLEAST64
2559 ") must be a multiple of device limit minUniformBufferOffsetAlignment 0x%" PRIxLEAST64 ".",
2560 i, j, pDescriptorWrites[i].pBufferInfo[j].offset, uniformAlignment);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002561 }
2562 }
2563 }
2564 } else if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER) ||
2565 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC)) {
2566 VkDeviceSize storageAlignment = device_data->device_limits.minStorageBufferOffsetAlignment;
2567 for (uint32_t j = 0; j < pDescriptorWrites[i].descriptorCount; j++) {
2568 if (pDescriptorWrites[i].pBufferInfo != NULL) {
2569 if (SafeModulo(pDescriptorWrites[i].pBufferInfo[j].offset, storageAlignment) != 0) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06002570 skip |=
2571 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002572 VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0,
2573 "VUID-VkWriteDescriptorSet-descriptorType-00328",
Mark Lobodzinski88529492018-04-01 10:38:15 -06002574 "vkUpdateDescriptorSets(): pDescriptorWrites[%d].pBufferInfo[%d].offset (0x%" PRIxLEAST64
2575 ") must be a multiple of device limit minStorageBufferOffsetAlignment 0x%" PRIxLEAST64 ".",
2576 i, j, pDescriptorWrites[i].pBufferInfo[j].offset, storageAlignment);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002577 }
2578 }
2579 }
2580 }
2581 }
2582 }
2583 return skip;
2584}
2585
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002586bool pv_vkCreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
2587 VkRenderPass *pRenderPass) {
2588 bool skip = false;
2589 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2590 uint32_t max_color_attachments = device_data->device_limits.maxColorAttachments;
2591
2592 for (uint32_t i = 0; i < pCreateInfo->attachmentCount; ++i) {
2593 if (pCreateInfo->pAttachments[i].format == VK_FORMAT_UNDEFINED) {
2594 std::stringstream ss;
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002595 ss << "vkCreateRenderPass: pCreateInfo->pAttachments[" << i << "].format is VK_FORMAT_UNDEFINED. ";
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002596 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002597 "VUID-VkAttachmentDescription-format-parameter", "%s", ss.str().c_str());
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002598 }
2599 if (pCreateInfo->pAttachments[i].finalLayout == VK_IMAGE_LAYOUT_UNDEFINED ||
2600 pCreateInfo->pAttachments[i].finalLayout == VK_IMAGE_LAYOUT_PREINITIALIZED) {
2601 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002602 "VUID-VkAttachmentDescription-finalLayout-00843",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002603 "pCreateInfo->pAttachments[%d].finalLayout must not be VK_IMAGE_LAYOUT_UNDEFINED or "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002604 "VK_IMAGE_LAYOUT_PREINITIALIZED.",
2605 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002606 }
2607 }
2608
2609 for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) {
2610 if (pCreateInfo->pSubpasses[i].colorAttachmentCount > max_color_attachments) {
2611 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002612 "VUID-VkSubpassDescription-colorAttachmentCount-00845",
2613 "Cannot create a render pass with %d color attachments. Max is %d.",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002614 pCreateInfo->pSubpasses[i].colorAttachmentCount, max_color_attachments);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002615 }
2616 }
2617 return skip;
2618}
2619
2620bool pv_vkFreeCommandBuffers(VkDevice device, VkCommandPool commandPool, uint32_t commandBufferCount,
2621 const VkCommandBuffer *pCommandBuffers) {
2622 bool skip = false;
2623 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2624 debug_report_data *report_data = device_data->report_data;
2625
2626 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
2627 // This is an array of handles, where the elements are allowed to be VK_NULL_HANDLE, and does not require any validation beyond
2628 // validate_array()
2629 skip |= validate_array(report_data, "vkFreeCommandBuffers", "commandBufferCount", "pCommandBuffers", commandBufferCount,
Dave Houlton413a6782018-05-22 13:01:54 -06002630 &pCommandBuffers, true, true, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002631 return skip;
2632}
2633
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002634bool pv_vkBeginCommandBuffer(VkCommandBuffer commandBuffer, const VkCommandBufferBeginInfo *pBeginInfo) {
2635 bool skip = false;
2636 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2637 debug_report_data *report_data = device_data->report_data;
2638 const VkCommandBufferInheritanceInfo *pInfo = pBeginInfo->pInheritanceInfo;
2639
2640 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
2641 // TODO: pBeginInfo->pInheritanceInfo must not be NULL if commandBuffer is a secondary command buffer
2642 skip |= validate_struct_type(report_data, "vkBeginCommandBuffer", "pBeginInfo->pInheritanceInfo",
2643 "VK_STRUCTURE_TYPE_COMMAND_BUFFER_INHERITANCE_INFO", pBeginInfo->pInheritanceInfo,
Mark Lobodzinskia16ebc72018-06-15 14:47:39 -06002644 VK_STRUCTURE_TYPE_COMMAND_BUFFER_INHERITANCE_INFO, false,
2645 "VUID_vkBeginCommandBuffer-pBeginInfo-parameter", "VUID_VkCommandBufferBeginInfo-sType-sType");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002646
2647 if (pBeginInfo->pInheritanceInfo != NULL) {
Dave Houlton413a6782018-05-22 13:01:54 -06002648 skip |= validate_struct_pnext(report_data, "vkBeginCommandBuffer", "pBeginInfo->pInheritanceInfo->pNext", NULL,
2649 pBeginInfo->pInheritanceInfo->pNext, 0, NULL, GeneratedHeaderVersion,
2650 "VUID-VkCommandBufferBeginInfo-pNext-pNext");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002651
2652 skip |= validate_bool32(report_data, "vkBeginCommandBuffer", "pBeginInfo->pInheritanceInfo->occlusionQueryEnable",
2653 pBeginInfo->pInheritanceInfo->occlusionQueryEnable);
2654
2655 // TODO: This only needs to be validated when the inherited queries feature is enabled
2656 // skip |= validate_flags(report_data, "vkBeginCommandBuffer", "pBeginInfo->pInheritanceInfo->queryFlags",
2657 // "VkQueryControlFlagBits", AllVkQueryControlFlagBits, pBeginInfo->pInheritanceInfo->queryFlags, false);
2658
2659 // TODO: This must be 0 if the pipeline statistics queries feature is not enabled
2660 skip |= validate_flags(report_data, "vkBeginCommandBuffer", "pBeginInfo->pInheritanceInfo->pipelineStatistics",
2661 "VkQueryPipelineStatisticFlagBits", AllVkQueryPipelineStatisticFlagBits,
Dave Houlton413a6782018-05-22 13:01:54 -06002662 pBeginInfo->pInheritanceInfo->pipelineStatistics, false, false, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002663 }
2664
2665 if (pInfo != NULL) {
2666 if ((device_data->physical_device_features.inheritedQueries == VK_FALSE) && (pInfo->occlusionQueryEnable != VK_FALSE)) {
2667 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002668 HandleToUint64(commandBuffer), "VUID-VkCommandBufferInheritanceInfo-occlusionQueryEnable-00056",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002669 "Cannot set inherited occlusionQueryEnable in vkBeginCommandBuffer() when device does not support "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002670 "inheritedQueries.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002671 }
2672 if ((device_data->physical_device_features.inheritedQueries != VK_FALSE) && (pInfo->occlusionQueryEnable != VK_FALSE)) {
2673 skip |= validate_flags(device_data->report_data, "vkBeginCommandBuffer", "pBeginInfo->pInheritanceInfo->queryFlags",
2674 "VkQueryControlFlagBits", AllVkQueryControlFlagBits, pInfo->queryFlags, false, false,
Dave Houlton413a6782018-05-22 13:01:54 -06002675 "VUID-VkCommandBufferInheritanceInfo-queryFlags-00057");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002676 }
2677 }
2678
2679 return skip;
2680}
2681
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002682bool pv_vkCmdSetViewport(VkCommandBuffer commandBuffer, uint32_t firstViewport, uint32_t viewportCount,
2683 const VkViewport *pViewports) {
2684 bool skip = false;
2685 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2686
Petr Krausd55e77c2018-01-09 22:09:25 +01002687 if (!device_data->physical_device_features.multiViewport) {
2688 if (firstViewport != 0) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002689 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002690 HandleToUint64(commandBuffer), "VUID-vkCmdSetViewport-firstViewport-01224",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002691 "vkCmdSetViewport: The multiViewport feature is disabled, but firstViewport (=%" PRIu32 ") is not 0.",
2692 firstViewport);
Petr Krausd55e77c2018-01-09 22:09:25 +01002693 }
2694 if (viewportCount > 1) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002695 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002696 HandleToUint64(commandBuffer), "VUID-vkCmdSetViewport-viewportCount-01225",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002697 "vkCmdSetViewport: The multiViewport feature is disabled, but viewportCount (=%" PRIu32 ") is not 1.",
2698 viewportCount);
Petr Krausd55e77c2018-01-09 22:09:25 +01002699 }
2700 } else { // multiViewport enabled
Petr Kraus7dfeed12018-02-27 20:51:20 +01002701 const uint64_t sum = static_cast<uint64_t>(firstViewport) + static_cast<uint64_t>(viewportCount);
Petr Krausd55e77c2018-01-09 22:09:25 +01002702 if (sum > device_data->device_limits.maxViewports) {
2703 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002704 HandleToUint64(commandBuffer), "VUID-vkCmdSetViewport-firstViewport-01223",
Petr Krausd55e77c2018-01-09 22:09:25 +01002705 "vkCmdSetViewport: firstViewport + viewportCount (=%" PRIu32 " + %" PRIu32 " = %" PRIu64
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002706 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
2707 firstViewport, viewportCount, sum, device_data->device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002708 }
2709 }
Petr Krausb3fcdb42018-01-09 22:09:09 +01002710
2711 if (pViewports) {
2712 for (uint32_t viewport_i = 0; viewport_i < viewportCount; ++viewport_i) {
2713 const auto &viewport = pViewports[viewport_i]; // will crash on invalid ptr
2714 const char fn_name[] = "vkCmdSetViewport";
2715 const std::string param_name = "pViewports[" + std::to_string(viewport_i) + "]";
2716 skip |= pv_VkViewport(device_data, viewport, fn_name, param_name.c_str(),
2717 VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, HandleToUint64(commandBuffer));
2718 }
2719 }
2720
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002721 return skip;
2722}
2723
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002724bool pv_vkCmdSetScissor(VkCommandBuffer commandBuffer, uint32_t firstScissor, uint32_t scissorCount, const VkRect2D *pScissors) {
2725 bool skip = false;
2726 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2727 debug_report_data *report_data = device_data->report_data;
2728
Petr Kraus6260f0a2018-02-27 21:15:55 +01002729 if (!device_data->physical_device_features.multiViewport) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002730 if (firstScissor != 0) {
Petr Kraus6260f0a2018-02-27 21:15:55 +01002731 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002732 HandleToUint64(commandBuffer), "VUID-vkCmdSetScissor-firstScissor-00593",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002733 "vkCmdSetScissor: The multiViewport feature is disabled, but firstScissor (=%" PRIu32 ") is not 0.",
2734 firstScissor);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002735 }
2736 if (scissorCount > 1) {
2737 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002738 HandleToUint64(commandBuffer), "VUID-vkCmdSetScissor-scissorCount-00594",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002739 "vkCmdSetScissor: The multiViewport feature is disabled, but scissorCount (=%" PRIu32 ") is not 1.",
2740 scissorCount);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002741 }
2742 } else { // multiViewport enabled
2743 const uint64_t sum = static_cast<uint64_t>(firstScissor) + static_cast<uint64_t>(scissorCount);
2744 if (sum > device_data->device_limits.maxViewports) {
2745 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002746 HandleToUint64(commandBuffer), "VUID-vkCmdSetScissor-firstScissor-00592",
Petr Kraus6260f0a2018-02-27 21:15:55 +01002747 "vkCmdSetScissor: firstScissor + scissorCount (=%" PRIu32 " + %" PRIu32 " = %" PRIu64
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002748 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
2749 firstScissor, scissorCount, sum, device_data->device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002750 }
2751 }
2752
Petr Kraus6260f0a2018-02-27 21:15:55 +01002753 if (pScissors) {
2754 for (uint32_t scissor_i = 0; scissor_i < scissorCount; ++scissor_i) {
2755 const auto &scissor = pScissors[scissor_i]; // will crash on invalid ptr
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002756
Petr Kraus6260f0a2018-02-27 21:15:55 +01002757 if (scissor.offset.x < 0) {
2758 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002759 HandleToUint64(commandBuffer), "VUID-vkCmdSetScissor-x-00595",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002760 "vkCmdSetScissor: pScissors[%" PRIu32 "].offset.x (=%" PRIi32 ") is negative.", scissor_i,
2761 scissor.offset.x);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002762 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002763
Petr Kraus6260f0a2018-02-27 21:15:55 +01002764 if (scissor.offset.y < 0) {
2765 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002766 HandleToUint64(commandBuffer), "VUID-vkCmdSetScissor-x-00595",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002767 "vkCmdSetScissor: pScissors[%" PRIu32 "].offset.y (=%" PRIi32 ") is negative.", scissor_i,
2768 scissor.offset.y);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002769 }
2770
2771 const int64_t x_sum = static_cast<int64_t>(scissor.offset.x) + static_cast<int64_t>(scissor.extent.width);
2772 if (x_sum > INT32_MAX) {
2773 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002774 HandleToUint64(commandBuffer), "VUID-vkCmdSetScissor-offset-00596",
Petr Kraus6260f0a2018-02-27 21:15:55 +01002775 "vkCmdSetScissor: offset.x + extent.width (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002776 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
2777 scissor.offset.x, scissor.extent.width, x_sum, scissor_i);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002778 }
2779
2780 const int64_t y_sum = static_cast<int64_t>(scissor.offset.y) + static_cast<int64_t>(scissor.extent.height);
2781 if (y_sum > INT32_MAX) {
2782 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002783 HandleToUint64(commandBuffer), "VUID-vkCmdSetScissor-offset-00597",
Petr Kraus6260f0a2018-02-27 21:15:55 +01002784 "vkCmdSetScissor: offset.y + extent.height (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002785 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
2786 scissor.offset.y, scissor.extent.height, y_sum, scissor_i);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002787 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002788 }
2789 }
Petr Kraus6260f0a2018-02-27 21:15:55 +01002790
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002791 return skip;
2792}
2793
Petr Kraus299ba622017-11-24 03:09:03 +01002794bool pv_vkCmdSetLineWidth(VkCommandBuffer commandBuffer, float lineWidth) {
2795 bool skip = false;
2796 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2797 debug_report_data *report_data = device_data->report_data;
2798
2799 if (!device_data->physical_device_features.wideLines && (lineWidth != 1.0f)) {
2800 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002801 HandleToUint64(commandBuffer), "VUID-vkCmdSetLineWidth-lineWidth-00788",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002802 "VkPhysicalDeviceFeatures::wideLines is disabled, but lineWidth (=%f) is not 1.0.", lineWidth);
Petr Kraus299ba622017-11-24 03:09:03 +01002803 }
2804
2805 return skip;
2806}
2807
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002808bool pv_vkCmdDraw(VkCommandBuffer commandBuffer, uint32_t vertexCount, uint32_t instanceCount, uint32_t firstVertex,
2809 uint32_t firstInstance) {
2810 bool skip = false;
2811 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2812 if (vertexCount == 0) {
2813 // TODO: Verify against Valid Usage section. I don't see a non-zero vertexCount listed, may need to add that and make
2814 // this an error or leave as is.
2815 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002816 kVUID_PVError_RequiredParameter, "vkCmdDraw parameter, uint32_t vertexCount, is 0");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002817 }
2818
2819 if (instanceCount == 0) {
2820 // TODO: Verify against Valid Usage section. I don't see a non-zero instanceCount listed, may need to add that and make
2821 // this an error or leave as is.
2822 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002823 kVUID_PVError_RequiredParameter, "vkCmdDraw parameter, uint32_t instanceCount, is 0");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002824 }
2825 return skip;
2826}
2827
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002828bool pv_vkCmdDrawIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, uint32_t count, uint32_t stride) {
2829 bool skip = false;
2830 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2831
2832 if (!device_data->physical_device_features.multiDrawIndirect && ((count > 1))) {
2833 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002834 kVUID_PVError_DeviceFeature,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002835 "CmdDrawIndirect(): Device feature multiDrawIndirect disabled: count must be 0 or 1 but is %d", count);
2836 }
2837 return skip;
2838}
2839
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002840bool pv_vkCmdDrawIndexedIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, uint32_t count,
2841 uint32_t stride) {
2842 bool skip = false;
2843 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2844 if (!device_data->physical_device_features.multiDrawIndirect && ((count > 1))) {
Dave Houlton413a6782018-05-22 13:01:54 -06002845 skip |=
2846 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
2847 kVUID_PVError_DeviceFeature,
2848 "CmdDrawIndexedIndirect(): Device feature multiDrawIndirect disabled: count must be 0 or 1 but is %d", count);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002849 }
2850 return skip;
2851}
2852
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002853bool pv_vkCmdCopyImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkImage dstImage,
2854 VkImageLayout dstImageLayout, uint32_t regionCount, const VkImageCopy *pRegions) {
2855 bool skip = false;
2856 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2857
Dave Houltonf5217612018-02-02 16:18:52 -07002858 VkImageAspectFlags legal_aspect_flags =
2859 VK_IMAGE_ASPECT_COLOR_BIT | VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT | VK_IMAGE_ASPECT_METADATA_BIT;
2860 if (device_data->extensions.vk_khr_sampler_ycbcr_conversion) {
2861 legal_aspect_flags |= (VK_IMAGE_ASPECT_PLANE_0_BIT_KHR | VK_IMAGE_ASPECT_PLANE_1_BIT_KHR | VK_IMAGE_ASPECT_PLANE_2_BIT_KHR);
2862 }
2863
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002864 if (pRegions != nullptr) {
Dave Houltonf5217612018-02-02 16:18:52 -07002865 if ((pRegions->srcSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002866 skip |= log_msg(
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002867 device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002868 "VUID-VkImageSubresourceLayers-aspectMask-parameter",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002869 "vkCmdCopyImage() parameter, VkImageAspect pRegions->srcSubresource.aspectMask, is an unrecognized enumerator.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002870 }
Dave Houltonf5217612018-02-02 16:18:52 -07002871 if ((pRegions->dstSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002872 skip |= log_msg(
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002873 device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002874 "VUID-VkImageSubresourceLayers-aspectMask-parameter",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002875 "vkCmdCopyImage() parameter, VkImageAspect pRegions->dstSubresource.aspectMask, is an unrecognized enumerator.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002876 }
2877 }
2878 return skip;
2879}
2880
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002881bool pv_vkCmdBlitImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkImage dstImage,
2882 VkImageLayout dstImageLayout, uint32_t regionCount, const VkImageBlit *pRegions, VkFilter filter) {
2883 bool skip = false;
2884 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2885
Dave Houltonf5217612018-02-02 16:18:52 -07002886 VkImageAspectFlags legal_aspect_flags =
2887 VK_IMAGE_ASPECT_COLOR_BIT | VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT | VK_IMAGE_ASPECT_METADATA_BIT;
2888 if (device_data->extensions.vk_khr_sampler_ycbcr_conversion) {
2889 legal_aspect_flags |= (VK_IMAGE_ASPECT_PLANE_0_BIT_KHR | VK_IMAGE_ASPECT_PLANE_1_BIT_KHR | VK_IMAGE_ASPECT_PLANE_2_BIT_KHR);
2890 }
2891
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002892 if (pRegions != nullptr) {
Dave Houltonf5217612018-02-02 16:18:52 -07002893 if ((pRegions->srcSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002894 skip |= log_msg(
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002895 device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002896 kVUID_PVError_UnrecognizedValue,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002897 "vkCmdBlitImage() parameter, VkImageAspect pRegions->srcSubresource.aspectMask, is an unrecognized enumerator");
2898 }
Dave Houltonf5217612018-02-02 16:18:52 -07002899 if ((pRegions->dstSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002900 skip |= log_msg(
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002901 device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002902 kVUID_PVError_UnrecognizedValue,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002903 "vkCmdBlitImage() parameter, VkImageAspect pRegions->dstSubresource.aspectMask, is an unrecognized enumerator");
2904 }
2905 }
2906 return skip;
2907}
2908
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002909bool pv_vkCmdCopyBufferToImage(VkCommandBuffer commandBuffer, VkBuffer srcBuffer, VkImage dstImage, VkImageLayout dstImageLayout,
2910 uint32_t regionCount, const VkBufferImageCopy *pRegions) {
2911 bool skip = false;
2912 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2913
Dave Houltonf5217612018-02-02 16:18:52 -07002914 VkImageAspectFlags legal_aspect_flags =
2915 VK_IMAGE_ASPECT_COLOR_BIT | VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT | VK_IMAGE_ASPECT_METADATA_BIT;
2916 if (device_data->extensions.vk_khr_sampler_ycbcr_conversion) {
2917 legal_aspect_flags |= (VK_IMAGE_ASPECT_PLANE_0_BIT_KHR | VK_IMAGE_ASPECT_PLANE_1_BIT_KHR | VK_IMAGE_ASPECT_PLANE_2_BIT_KHR);
2918 }
2919
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002920 if (pRegions != nullptr) {
Dave Houltonf5217612018-02-02 16:18:52 -07002921 if ((pRegions->imageSubresource.aspectMask & legal_aspect_flags) == 0) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07002922 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002923 kVUID_PVError_UnrecognizedValue,
Dave Houltona9df0ce2018-02-07 10:51:23 -07002924 "vkCmdCopyBufferToImage() parameter, VkImageAspect pRegions->imageSubresource.aspectMask, is an "
2925 "unrecognized enumerator");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002926 }
2927 }
2928 return skip;
2929}
2930
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002931bool pv_vkCmdCopyImageToBuffer(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkBuffer dstBuffer,
2932 uint32_t regionCount, const VkBufferImageCopy *pRegions) {
2933 bool skip = false;
2934 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2935
Dave Houltonf5217612018-02-02 16:18:52 -07002936 VkImageAspectFlags legal_aspect_flags =
2937 VK_IMAGE_ASPECT_COLOR_BIT | VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT | VK_IMAGE_ASPECT_METADATA_BIT;
2938 if (device_data->extensions.vk_khr_sampler_ycbcr_conversion) {
2939 legal_aspect_flags |= (VK_IMAGE_ASPECT_PLANE_0_BIT_KHR | VK_IMAGE_ASPECT_PLANE_1_BIT_KHR | VK_IMAGE_ASPECT_PLANE_2_BIT_KHR);
2940 }
2941
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002942 if (pRegions != nullptr) {
Dave Houltonf5217612018-02-02 16:18:52 -07002943 if ((pRegions->imageSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002944 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002945 kVUID_PVError_UnrecognizedValue,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002946 "vkCmdCopyImageToBuffer parameter, VkImageAspect pRegions->imageSubresource.aspectMask, is an unrecognized "
2947 "enumerator");
2948 }
2949 }
2950 return skip;
2951}
2952
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002953bool pv_vkCmdUpdateBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer, VkDeviceSize dstOffset, VkDeviceSize dataSize,
2954 const void *pData) {
2955 bool skip = false;
2956 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2957
2958 if (dstOffset & 3) {
2959 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002960 "VUID-vkCmdUpdateBuffer-dstOffset-00036",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002961 "vkCmdUpdateBuffer() parameter, VkDeviceSize dstOffset (0x%" PRIxLEAST64 "), is not a multiple of 4.",
2962 dstOffset);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002963 }
2964
2965 if ((dataSize <= 0) || (dataSize > 65536)) {
2966 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002967 "VUID-vkCmdUpdateBuffer-dataSize-00037",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002968 "vkCmdUpdateBuffer() parameter, VkDeviceSize dataSize (0x%" PRIxLEAST64
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002969 "), must be greater than zero and less than or equal to 65536.",
2970 dataSize);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002971 } else if (dataSize & 3) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002972 skip |=
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002973 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002974 "VUID-vkCmdUpdateBuffer-dataSize-00038",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002975 "vkCmdUpdateBuffer() parameter, VkDeviceSize dataSize (0x%" PRIxLEAST64 "), is not a multiple of 4.", dataSize);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002976 }
2977 return skip;
2978}
2979
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002980bool pv_vkCmdFillBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer, VkDeviceSize dstOffset, VkDeviceSize size,
2981 uint32_t data) {
2982 bool skip = false;
2983 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2984
2985 if (dstOffset & 3) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002986 skip |=
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002987 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002988 "VUID-vkCmdFillBuffer-dstOffset-00025",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002989 "vkCmdFillBuffer() parameter, VkDeviceSize dstOffset (0x%" PRIxLEAST64 "), is not a multiple of 4.", dstOffset);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002990 }
2991
2992 if (size != VK_WHOLE_SIZE) {
2993 if (size <= 0) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002994 skip |=
2995 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002996 "VUID-vkCmdFillBuffer-size-00026",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002997 "vkCmdFillBuffer() parameter, VkDeviceSize size (0x%" PRIxLEAST64 "), must be greater than zero.", size);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002998 } else if (size & 3) {
2999 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003000 "VUID-vkCmdFillBuffer-size-00028",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003001 "vkCmdFillBuffer() parameter, VkDeviceSize size (0x%" PRIxLEAST64 "), is not a multiple of 4.", size);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003002 }
3003 }
3004 return skip;
3005}
3006
3007VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateInstanceLayerProperties(uint32_t *pCount, VkLayerProperties *pProperties) {
3008 return util_GetLayerProperties(1, &global_layer, pCount, pProperties);
3009}
3010
3011VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateDeviceLayerProperties(VkPhysicalDevice physicalDevice, uint32_t *pCount,
3012 VkLayerProperties *pProperties) {
3013 return util_GetLayerProperties(1, &global_layer, pCount, pProperties);
3014}
3015
3016VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateInstanceExtensionProperties(const char *pLayerName, uint32_t *pCount,
3017 VkExtensionProperties *pProperties) {
3018 if (pLayerName && !strcmp(pLayerName, global_layer.layerName))
3019 return util_GetExtensionProperties(1, instance_extensions, pCount, pProperties);
3020
3021 return VK_ERROR_LAYER_NOT_PRESENT;
3022}
3023
3024VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateDeviceExtensionProperties(VkPhysicalDevice physicalDevice, const char *pLayerName,
3025 uint32_t *pPropertyCount, VkExtensionProperties *pProperties) {
3026 // Parameter_validation does not have any physical device extensions
3027 if (pLayerName && !strcmp(pLayerName, global_layer.layerName))
3028 return util_GetExtensionProperties(0, NULL, pPropertyCount, pProperties);
3029
3030 instance_layer_data *local_data = GetLayerDataPtr(get_dispatch_key(physicalDevice), instance_layer_data_map);
Dave Houlton413a6782018-05-22 13:01:54 -06003031 bool skip = validate_array(local_data->report_data, "vkEnumerateDeviceExtensionProperties", "pPropertyCount", "pProperties",
3032 pPropertyCount, &pProperties, true, false, false, kVUIDUndefined,
3033 "VUID-vkEnumerateDeviceExtensionProperties-pProperties-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003034 if (skip) return VK_ERROR_VALIDATION_FAILED_EXT;
3035
3036 return local_data->dispatch_table.EnumerateDeviceExtensionProperties(physicalDevice, NULL, pPropertyCount, pProperties);
3037}
3038
3039static bool require_device_extension(layer_data *device_data, bool flag, char const *function_name, char const *extension_name) {
3040 if (!flag) {
3041 return log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003042 kVUID_PVError_ExtensionNotEnabled,
3043 "%s() called even though the %s extension was not enabled for this VkDevice.", function_name,
3044 extension_name);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003045 }
3046
3047 return false;
3048}
3049
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003050bool pv_vkCreateSwapchainKHR(VkDevice device, const VkSwapchainCreateInfoKHR *pCreateInfo, const VkAllocationCallbacks *pAllocator,
3051 VkSwapchainKHR *pSwapchain) {
3052 bool skip = false;
3053 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
3054 debug_report_data *report_data = device_data->report_data;
3055
Mark Lobodzinski88529492018-04-01 10:38:15 -06003056 const LogMiscParams log_misc{report_data, VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT, VK_NULL_HANDLE,
Petr Krause5c37652018-01-05 04:05:12 +01003057 "vkCreateSwapchainKHR"};
3058
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003059 if (pCreateInfo != nullptr) {
3060 if ((device_data->physical_device_features.textureCompressionETC2 == false) &&
3061 FormatIsCompressed_ETC2_EAC(pCreateInfo->imageFormat)) {
Dave Houlton413a6782018-05-22 13:01:54 -06003062 skip |= log_msg(
3063 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, kVUID_PVError_DeviceFeature,
3064 "vkCreateSwapchainKHR(): Attempting to create swapchain VkImage with format %s. The textureCompressionETC2 "
3065 "feature is not enabled: neither ETC2 nor EAC formats can be used to create images.",
3066 string_VkFormat(pCreateInfo->imageFormat));
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003067 }
3068
3069 if ((device_data->physical_device_features.textureCompressionASTC_LDR == false) &&
3070 FormatIsCompressed_ASTC_LDR(pCreateInfo->imageFormat)) {
Dave Houlton413a6782018-05-22 13:01:54 -06003071 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
3072 kVUID_PVError_DeviceFeature,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003073 "vkCreateSwapchainKHR(): Attempting to create swapchain VkImage with format %s. The "
3074 "textureCompressionASTC_LDR feature is not enabled: ASTC formats cannot be used to create images.",
3075 string_VkFormat(pCreateInfo->imageFormat));
3076 }
3077
3078 if ((device_data->physical_device_features.textureCompressionBC == false) &&
3079 FormatIsCompressed_BC(pCreateInfo->imageFormat)) {
Dave Houlton413a6782018-05-22 13:01:54 -06003080 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
3081 kVUID_PVError_DeviceFeature,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003082 "vkCreateSwapchainKHR(): Attempting to create swapchain VkImage with format %s. The "
3083 "textureCompressionBC feature is not enabled: BC compressed formats cannot be used to create images.",
3084 string_VkFormat(pCreateInfo->imageFormat));
3085 }
3086
3087 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
3088 if (pCreateInfo->imageSharingMode == VK_SHARING_MODE_CONCURRENT) {
3089 // If imageSharingMode is VK_SHARING_MODE_CONCURRENT, queueFamilyIndexCount must be greater than 1
3090 if (pCreateInfo->queueFamilyIndexCount <= 1) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06003091 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003092 "VUID-VkSwapchainCreateInfoKHR-imageSharingMode-01278",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003093 "vkCreateSwapchainKHR(): if pCreateInfo->imageSharingMode is VK_SHARING_MODE_CONCURRENT, "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003094 "pCreateInfo->queueFamilyIndexCount must be greater than 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003095 }
3096
3097 // If imageSharingMode is VK_SHARING_MODE_CONCURRENT, pQueueFamilyIndices must be a pointer to an array of
3098 // queueFamilyIndexCount uint32_t values
3099 if (pCreateInfo->pQueueFamilyIndices == nullptr) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06003100 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003101 "VUID-VkSwapchainCreateInfoKHR-imageSharingMode-01277",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003102 "vkCreateSwapchainKHR(): if pCreateInfo->imageSharingMode is VK_SHARING_MODE_CONCURRENT, "
3103 "pCreateInfo->pQueueFamilyIndices must be a pointer to an array of "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003104 "pCreateInfo->queueFamilyIndexCount uint32_t values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003105 } else {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003106 skip |= ValidateQueueFamilies(device_data, pCreateInfo->queueFamilyIndexCount, pCreateInfo->pQueueFamilyIndices,
Dave Houlton413a6782018-05-22 13:01:54 -06003107 "vkCreateSwapchainKHR", "pCreateInfo->pQueueFamilyIndices",
3108 kVUID_PVError_InvalidUsage, kVUID_PVError_InvalidUsage, false);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003109 }
3110 }
3111
Dave Houlton413a6782018-05-22 13:01:54 -06003112 skip |= ValidateGreaterThanZero(pCreateInfo->imageArrayLayers, "pCreateInfo->imageArrayLayers",
3113 "VUID-VkSwapchainCreateInfoKHR-imageArrayLayers-01275", log_misc);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003114 }
3115
3116 return skip;
3117}
3118
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003119bool pv_vkQueuePresentKHR(VkQueue queue, const VkPresentInfoKHR *pPresentInfo) {
3120 bool skip = false;
3121 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(queue), layer_data_map);
3122
3123 if (pPresentInfo && pPresentInfo->pNext) {
John Zulaufde972ac2017-10-26 12:07:05 -06003124 const auto *present_regions = lvl_find_in_chain<VkPresentRegionsKHR>(pPresentInfo->pNext);
3125 if (present_regions) {
3126 // TODO: This and all other pNext extension dependencies should be added to code-generation
3127 skip |= require_device_extension(device_data, device_data->extensions.vk_khr_incremental_present, "vkQueuePresentKHR",
3128 VK_KHR_INCREMENTAL_PRESENT_EXTENSION_NAME);
3129 if (present_regions->swapchainCount != pPresentInfo->swapchainCount) {
3130 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003131 kVUID_PVError_InvalidUsage,
Dave Houltona9df0ce2018-02-07 10:51:23 -07003132 "QueuePresentKHR(): pPresentInfo->swapchainCount has a value of %i but VkPresentRegionsKHR "
3133 "extension swapchainCount is %i. These values must be equal.",
John Zulaufde972ac2017-10-26 12:07:05 -06003134 pPresentInfo->swapchainCount, present_regions->swapchainCount);
3135 }
Dave Houlton413a6782018-05-22 13:01:54 -06003136 skip |=
3137 validate_struct_pnext(device_data->report_data, "QueuePresentKHR", "pCreateInfo->pNext->pNext", NULL,
3138 present_regions->pNext, 0, NULL, GeneratedHeaderVersion, "VUID-VkPresentInfoKHR-pNext-pNext");
John Zulaufde972ac2017-10-26 12:07:05 -06003139 skip |= validate_array(device_data->report_data, "QueuePresentKHR", "pCreateInfo->pNext->swapchainCount",
Gabríel Arthúr Pétursson092b29b2018-03-21 22:44:11 +00003140 "pCreateInfo->pNext->pRegions", present_regions->swapchainCount, &present_regions->pRegions,
Dave Houlton413a6782018-05-22 13:01:54 -06003141 true, false, kVUIDUndefined, kVUIDUndefined);
John Zulaufde972ac2017-10-26 12:07:05 -06003142 for (uint32_t i = 0; i < present_regions->swapchainCount; ++i) {
3143 skip |= validate_array(device_data->report_data, "QueuePresentKHR", "pCreateInfo->pNext->pRegions[].rectangleCount",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003144 "pCreateInfo->pNext->pRegions[].pRectangles", present_regions->pRegions[i].rectangleCount,
Dave Houlton413a6782018-05-22 13:01:54 -06003145 &present_regions->pRegions[i].pRectangles, true, false, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003146 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003147 }
3148 }
3149
3150 return skip;
3151}
3152
3153#ifdef VK_USE_PLATFORM_WIN32_KHR
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003154bool pv_vkCreateWin32SurfaceKHR(VkInstance instance, const VkWin32SurfaceCreateInfoKHR *pCreateInfo,
3155 const VkAllocationCallbacks *pAllocator, VkSurfaceKHR *pSurface) {
3156 auto device_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map);
3157 bool skip = false;
3158
3159 if (pCreateInfo->hwnd == nullptr) {
3160 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003161 "VUID-VkWin32SurfaceCreateInfoKHR-hwnd-01308",
3162 "vkCreateWin32SurfaceKHR(): hwnd must be a valid Win32 HWND but hwnd is NULL.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003163 }
3164
3165 return skip;
3166}
3167#endif // VK_USE_PLATFORM_WIN32_KHR
3168
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003169bool pv_vkDebugMarkerSetObjectNameEXT(VkDevice device, const VkDebugMarkerObjectNameInfoEXT *pNameInfo) {
3170 auto device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
3171 if (pNameInfo->pObjectName) {
3172 device_data->report_data->debugObjectNameMap->insert(
3173 std::make_pair<uint64_t, std::string>((uint64_t &&) pNameInfo->object, pNameInfo->pObjectName));
3174 } else {
3175 device_data->report_data->debugObjectNameMap->erase(pNameInfo->object);
3176 }
3177 return false;
3178}
3179
Petr Krausc8655be2017-09-27 18:56:51 +02003180bool pv_vkCreateDescriptorPool(VkDevice device, const VkDescriptorPoolCreateInfo *pCreateInfo,
3181 const VkAllocationCallbacks *pAllocator, VkDescriptorPool *pDescriptorPool) {
3182 auto device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
3183 bool skip = false;
3184
3185 if (pCreateInfo) {
3186 if (pCreateInfo->maxSets <= 0) {
Dave Houlton413a6782018-05-22 13:01:54 -06003187 skip |=
3188 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT,
3189 VK_NULL_HANDLE, "VUID-VkDescriptorPoolCreateInfo-maxSets-00301",
3190 "vkCreateDescriptorPool(): pCreateInfo->maxSets is not greater than 0.");
Petr Krausc8655be2017-09-27 18:56:51 +02003191 }
3192
3193 if (pCreateInfo->pPoolSizes) {
3194 for (uint32_t i = 0; i < pCreateInfo->poolSizeCount; ++i) {
3195 if (pCreateInfo->pPoolSizes[i].descriptorCount <= 0) {
3196 skip |= log_msg(
3197 device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003198 VK_NULL_HANDLE, "VUID-VkDescriptorPoolSize-descriptorCount-00302",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003199 "vkCreateDescriptorPool(): pCreateInfo->pPoolSizes[%" PRIu32 "].descriptorCount is not greater than 0.", i);
Petr Krausc8655be2017-09-27 18:56:51 +02003200 }
3201 }
3202 }
3203 }
3204
3205 return skip;
3206}
3207
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003208bool pv_vkCmdDispatch(VkCommandBuffer commandBuffer, uint32_t groupCountX, uint32_t groupCountY, uint32_t groupCountZ) {
3209 bool skip = false;
3210 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3211
3212 if (groupCountX > device_data->device_limits.maxComputeWorkGroupCount[0]) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003213 skip |=
3214 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003215 HandleToUint64(commandBuffer), "VUID-vkCmdDispatch-groupCountX-00386",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003216 "vkCmdDispatch(): groupCountX (%" PRIu32 ") exceeds device limit maxComputeWorkGroupCount[0] (%" PRIu32 ").",
3217 groupCountX, device_data->device_limits.maxComputeWorkGroupCount[0]);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003218 }
3219
3220 if (groupCountY > device_data->device_limits.maxComputeWorkGroupCount[1]) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003221 skip |=
3222 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003223 HandleToUint64(commandBuffer), "VUID-vkCmdDispatch-groupCountY-00387",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003224 "vkCmdDispatch(): groupCountY (%" PRIu32 ") exceeds device limit maxComputeWorkGroupCount[1] (%" PRIu32 ").",
3225 groupCountY, device_data->device_limits.maxComputeWorkGroupCount[1]);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003226 }
3227
3228 if (groupCountZ > device_data->device_limits.maxComputeWorkGroupCount[2]) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003229 skip |=
3230 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003231 HandleToUint64(commandBuffer), "VUID-vkCmdDispatch-groupCountZ-00388",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003232 "vkCmdDispatch(): groupCountZ (%" PRIu32 ") exceeds device limit maxComputeWorkGroupCount[2] (%" PRIu32 ").",
3233 groupCountZ, device_data->device_limits.maxComputeWorkGroupCount[2]);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003234 }
3235
3236 return skip;
3237}
3238
Mark Lobodzinskibf973a12018-03-01 08:50:21 -07003239bool pv_vkCmdDispatchBaseKHR(VkCommandBuffer commandBuffer, uint32_t baseGroupX, uint32_t baseGroupY, uint32_t baseGroupZ,
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003240 uint32_t groupCountX, uint32_t groupCountY, uint32_t groupCountZ) {
3241 bool skip = false;
3242 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3243
3244 // Paired if {} else if {} tests used to avoid any possible uint underflow
3245 uint32_t limit = device_data->device_limits.maxComputeWorkGroupCount[0];
3246 if (baseGroupX >= limit) {
3247 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003248 HandleToUint64(commandBuffer), "VUID-vkCmdDispatchBase-baseGroupX-00421",
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003249 "vkCmdDispatch(): baseGroupX (%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003250 ") equals or exceeds device limit maxComputeWorkGroupCount[0] (%" PRIu32 ").",
3251 baseGroupX, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003252 } else if (groupCountX > (limit - baseGroupX)) {
3253 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003254 HandleToUint64(commandBuffer), "VUID-vkCmdDispatchBase-groupCountX-00424",
Mark Lobodzinskibf973a12018-03-01 08:50:21 -07003255 "vkCmdDispatchBaseKHR(): baseGroupX (%" PRIu32 ") + groupCountX (%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003256 ") exceeds device limit maxComputeWorkGroupCount[0] (%" PRIu32 ").",
3257 baseGroupX, groupCountX, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003258 }
3259
3260 limit = device_data->device_limits.maxComputeWorkGroupCount[1];
3261 if (baseGroupY >= limit) {
3262 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003263 HandleToUint64(commandBuffer), "VUID-vkCmdDispatchBase-baseGroupX-00422",
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003264 "vkCmdDispatch(): baseGroupY (%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003265 ") equals or exceeds device limit maxComputeWorkGroupCount[1] (%" PRIu32 ").",
3266 baseGroupY, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003267 } else if (groupCountY > (limit - baseGroupY)) {
3268 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003269 HandleToUint64(commandBuffer), "VUID-vkCmdDispatchBase-groupCountY-00425",
Mark Lobodzinskibf973a12018-03-01 08:50:21 -07003270 "vkCmdDispatchBaseKHR(): baseGroupY (%" PRIu32 ") + groupCountY (%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003271 ") exceeds device limit maxComputeWorkGroupCount[1] (%" PRIu32 ").",
3272 baseGroupY, groupCountY, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003273 }
3274
3275 limit = device_data->device_limits.maxComputeWorkGroupCount[2];
3276 if (baseGroupZ >= limit) {
3277 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003278 HandleToUint64(commandBuffer), "VUID-vkCmdDispatchBase-baseGroupZ-00423",
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003279 "vkCmdDispatch(): baseGroupZ (%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003280 ") equals or exceeds device limit maxComputeWorkGroupCount[2] (%" PRIu32 ").",
3281 baseGroupZ, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003282 } else if (groupCountZ > (limit - baseGroupZ)) {
3283 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003284 HandleToUint64(commandBuffer), "VUID-vkCmdDispatchBase-groupCountZ-00426",
Mark Lobodzinskibf973a12018-03-01 08:50:21 -07003285 "vkCmdDispatchBaseKHR(): baseGroupZ (%" PRIu32 ") + groupCountZ (%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003286 ") exceeds device limit maxComputeWorkGroupCount[2] (%" PRIu32 ").",
3287 baseGroupZ, groupCountZ, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003288 }
3289
3290 return skip;
3291}
3292
Jeff Bolz3e71f782018-08-29 23:15:45 -05003293bool pv_vkCmdSetExclusiveScissorNV(
3294 VkCommandBuffer commandBuffer,
3295 uint32_t firstExclusiveScissor,
3296 uint32_t exclusiveScissorCount,
3297 const VkRect2D* pExclusiveScissors)
3298{
3299 bool skip = false;
3300
3301 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3302 debug_report_data *report_data = device_data->report_data;
3303
3304 if (!device_data->physical_device_features.multiViewport) {
3305 if (firstExclusiveScissor != 0) {
3306 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3307 HandleToUint64(commandBuffer), "VUID-vkCmdSetExclusiveScissorNV-firstExclusiveScissor-02035",
3308 "vkCmdSetExclusiveScissorNV: The multiViewport feature is disabled, but firstExclusiveScissor (=%" PRIu32 ") is not 0.",
3309 firstExclusiveScissor);
3310 }
3311 if (exclusiveScissorCount > 1) {
3312 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3313 HandleToUint64(commandBuffer), "VUID-vkCmdSetExclusiveScissorNV-exclusiveScissorCount-02036",
3314 "vkCmdSetExclusiveScissorNV: The multiViewport feature is disabled, but exclusiveScissorCount (=%" PRIu32 ") is not 1.",
3315 exclusiveScissorCount);
3316 }
3317 } else { // multiViewport enabled
3318 const uint64_t sum = static_cast<uint64_t>(firstExclusiveScissor) + static_cast<uint64_t>(exclusiveScissorCount);
3319 if (sum > device_data->device_limits.maxViewports) {
3320 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3321 HandleToUint64(commandBuffer), "VUID-vkCmdSetExclusiveScissorNV-firstExclusiveScissor-02034",
3322 "vkCmdSetExclusiveScissorNV: firstExclusiveScissor + exclusiveScissorCount (=%" PRIu32 " + %" PRIu32 " = %" PRIu64
3323 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
3324 firstExclusiveScissor, exclusiveScissorCount, sum, device_data->device_limits.maxViewports);
3325 }
3326 }
3327
3328 if (firstExclusiveScissor >= device_data->device_limits.maxViewports) {
3329 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3330 HandleToUint64(commandBuffer), "VUID-vkCmdSetExclusiveScissorNV-firstExclusiveScissor-02033",
3331 "vkCmdSetExclusiveScissorNV: firstExclusiveScissor (=%" PRIu32 ") must be less than maxViewports (=%" PRIu32 ").",
3332 firstExclusiveScissor, device_data->device_limits.maxViewports);
3333 }
3334
3335 if (pExclusiveScissors) {
3336 for (uint32_t scissor_i = 0; scissor_i < exclusiveScissorCount; ++scissor_i) {
3337 const auto &scissor = pExclusiveScissors[scissor_i]; // will crash on invalid ptr
3338
3339 if (scissor.offset.x < 0) {
3340 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3341 HandleToUint64(commandBuffer), "VUID-vkCmdSetExclusiveScissorNV-x-02037",
3342 "vkCmdSetExclusiveScissorNV: pScissors[%" PRIu32 "].offset.x (=%" PRIi32 ") is negative.", scissor_i,
3343 scissor.offset.x);
3344 }
3345
3346 if (scissor.offset.y < 0) {
3347 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3348 HandleToUint64(commandBuffer), "VUID-vkCmdSetExclusiveScissorNV-x-02037",
3349 "vkCmdSetExclusiveScissorNV: pScissors[%" PRIu32 "].offset.y (=%" PRIi32 ") is negative.", scissor_i,
3350 scissor.offset.y);
3351 }
3352
3353 const int64_t x_sum = static_cast<int64_t>(scissor.offset.x) + static_cast<int64_t>(scissor.extent.width);
3354 if (x_sum > INT32_MAX) {
3355 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3356 HandleToUint64(commandBuffer), "VUID-vkCmdSetExclusiveScissorNV-offset-02038",
3357 "vkCmdSetExclusiveScissorNV: offset.x + extent.width (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
3358 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
3359 scissor.offset.x, scissor.extent.width, x_sum, scissor_i);
3360 }
3361
3362 const int64_t y_sum = static_cast<int64_t>(scissor.offset.y) + static_cast<int64_t>(scissor.extent.height);
3363 if (y_sum > INT32_MAX) {
3364 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3365 HandleToUint64(commandBuffer), "VUID-vkCmdSetExclusiveScissorNV-offset-02039",
3366 "vkCmdSetExclusiveScissorNV: offset.y + extent.height (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
3367 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
3368 scissor.offset.y, scissor.extent.height, y_sum, scissor_i);
3369 }
3370 }
3371 }
3372
3373 return skip;
3374}
3375
Jeff Bolz9af91c52018-09-01 21:53:57 -05003376bool pv_vkCmdSetViewportShadingRatePaletteNV(
3377 VkCommandBuffer commandBuffer,
3378 uint32_t firstViewport,
3379 uint32_t viewportCount,
3380 const VkShadingRatePaletteNV* pShadingRatePalettes)
3381{
3382 bool skip = false;
3383
3384 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3385 debug_report_data *report_data = device_data->report_data;
3386
3387 if (!device_data->physical_device_features.multiViewport) {
3388 if (firstViewport != 0) {
3389 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3390 HandleToUint64(commandBuffer), "VUID-vkCmdSetViewportShadingRatePaletteNV-firstViewport-02068",
3391 "vkCmdSetViewportShadingRatePaletteNV: The multiViewport feature is disabled, but firstViewport (=%" PRIu32 ") is not 0.",
3392 firstViewport);
3393 }
3394 if (viewportCount > 1) {
3395 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3396 HandleToUint64(commandBuffer), "VUID-vkCmdSetViewportShadingRatePaletteNV-viewportCount-02069",
3397 "vkCmdSetViewportShadingRatePaletteNV: The multiViewport feature is disabled, but viewportCount (=%" PRIu32 ") is not 1.",
3398 viewportCount);
3399 }
3400 }
3401
3402 if (firstViewport >= device_data->device_limits.maxViewports) {
3403 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3404 HandleToUint64(commandBuffer), "VUID-vkCmdSetViewportShadingRatePaletteNV-firstViewport-02066",
3405 "vkCmdSetViewportShadingRatePaletteNV: firstViewport (=%" PRIu32 ") must be less than maxViewports (=%" PRIu32 ").",
3406 firstViewport, device_data->device_limits.maxViewports);
3407 }
3408
3409 const uint64_t sum = static_cast<uint64_t>(firstViewport) + static_cast<uint64_t>(viewportCount);
3410 if (sum > device_data->device_limits.maxViewports) {
3411 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3412 HandleToUint64(commandBuffer), "VUID-vkCmdSetViewportShadingRatePaletteNV-firstViewport-02067",
3413 "vkCmdSetViewportShadingRatePaletteNV: firstViewport + viewportCount (=%" PRIu32 " + %" PRIu32 " = %" PRIu64
3414 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
3415 firstViewport, viewportCount, sum, device_data->device_limits.maxViewports);
3416 }
3417
3418 return skip;
3419}
3420
3421
3422bool pv_vkCmdSetCoarseSampleOrderNV(
3423 VkCommandBuffer commandBuffer,
3424 VkCoarseSampleOrderTypeNV sampleOrderType,
3425 uint32_t customSampleOrderCount,
3426 const VkCoarseSampleOrderCustomNV* pCustomSampleOrders)
3427{
3428 bool skip = false;
3429
3430 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3431 debug_report_data *report_data = device_data->report_data;
3432
3433 if (sampleOrderType != VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV &&
3434 customSampleOrderCount != 0) {
3435 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3436 HandleToUint64(commandBuffer), "VUID-vkCmdSetCoarseSampleOrderNV-sampleOrderType-02081",
3437 "vkCmdSetCoarseSampleOrderNV: If sampleOrderType is not VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV, "
3438 "customSampleOrderCount must be 0.");
3439 }
3440
3441 for (uint32_t order_i = 0; order_i < customSampleOrderCount; ++order_i) {
3442 skip |= ValidateCoarseSampleOrderCustomNV(device_data, &pCustomSampleOrders[order_i]);
3443 }
3444
3445 return skip;
3446}
3447
3448
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003449VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetDeviceProcAddr(VkDevice device, const char *funcName) {
Mark Lobodzinskib7a26382018-07-02 13:14:26 -06003450 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
3451 if (!ApiParentExtensionEnabled(funcName, device_data->extensions.device_extension_set)) {
3452 return nullptr;
3453 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003454 const auto item = name_to_funcptr_map.find(funcName);
3455 if (item != name_to_funcptr_map.end()) {
3456 return reinterpret_cast<PFN_vkVoidFunction>(item->second);
3457 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003458 const auto &table = device_data->dispatch_table;
3459 if (!table.GetDeviceProcAddr) return nullptr;
3460 return table.GetDeviceProcAddr(device, funcName);
3461}
3462
3463VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetInstanceProcAddr(VkInstance instance, const char *funcName) {
3464 const auto item = name_to_funcptr_map.find(funcName);
3465 if (item != name_to_funcptr_map.end()) {
3466 return reinterpret_cast<PFN_vkVoidFunction>(item->second);
3467 }
3468
3469 auto instance_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map);
3470 auto &table = instance_data->dispatch_table;
3471 if (!table.GetInstanceProcAddr) return nullptr;
3472 return table.GetInstanceProcAddr(instance, funcName);
3473}
3474
3475VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetPhysicalDeviceProcAddr(VkInstance instance, const char *funcName) {
3476 assert(instance);
3477 auto instance_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map);
3478
3479 if (!instance_data->dispatch_table.GetPhysicalDeviceProcAddr) return nullptr;
3480 return instance_data->dispatch_table.GetPhysicalDeviceProcAddr(instance, funcName);
3481}
3482
3483// If additional validation is needed outside of the generated checks, a manual routine can be added to this file
3484// and the address filled in here. The autogenerated source will call these routines if the pointers are not NULL.
Petr Krausc8655be2017-09-27 18:56:51 +02003485void InitializeManualParameterValidationFunctionPointers() {
Dave Houltonb3bbec72018-01-17 10:13:33 -07003486 custom_functions["vkGetDeviceQueue"] = (void *)pv_vkGetDeviceQueue;
3487 custom_functions["vkCreateBuffer"] = (void *)pv_vkCreateBuffer;
3488 custom_functions["vkCreateImage"] = (void *)pv_vkCreateImage;
3489 custom_functions["vkCreateImageView"] = (void *)pv_vkCreateImageView;
3490 custom_functions["vkCreateGraphicsPipelines"] = (void *)pv_vkCreateGraphicsPipelines;
3491 custom_functions["vkCreateComputePipelines"] = (void *)pv_vkCreateComputePipelines;
3492 custom_functions["vkCreateSampler"] = (void *)pv_vkCreateSampler;
3493 custom_functions["vkCreateDescriptorSetLayout"] = (void *)pv_vkCreateDescriptorSetLayout;
3494 custom_functions["vkFreeDescriptorSets"] = (void *)pv_vkFreeDescriptorSets;
3495 custom_functions["vkUpdateDescriptorSets"] = (void *)pv_vkUpdateDescriptorSets;
3496 custom_functions["vkCreateRenderPass"] = (void *)pv_vkCreateRenderPass;
3497 custom_functions["vkBeginCommandBuffer"] = (void *)pv_vkBeginCommandBuffer;
3498 custom_functions["vkCmdSetViewport"] = (void *)pv_vkCmdSetViewport;
3499 custom_functions["vkCmdSetScissor"] = (void *)pv_vkCmdSetScissor;
Petr Kraus299ba622017-11-24 03:09:03 +01003500 custom_functions["vkCmdSetLineWidth"] = (void *)pv_vkCmdSetLineWidth;
Dave Houltonb3bbec72018-01-17 10:13:33 -07003501 custom_functions["vkCmdDraw"] = (void *)pv_vkCmdDraw;
3502 custom_functions["vkCmdDrawIndirect"] = (void *)pv_vkCmdDrawIndirect;
3503 custom_functions["vkCmdDrawIndexedIndirect"] = (void *)pv_vkCmdDrawIndexedIndirect;
3504 custom_functions["vkCmdCopyImage"] = (void *)pv_vkCmdCopyImage;
3505 custom_functions["vkCmdBlitImage"] = (void *)pv_vkCmdBlitImage;
3506 custom_functions["vkCmdCopyBufferToImage"] = (void *)pv_vkCmdCopyBufferToImage;
3507 custom_functions["vkCmdCopyImageToBuffer"] = (void *)pv_vkCmdCopyImageToBuffer;
3508 custom_functions["vkCmdUpdateBuffer"] = (void *)pv_vkCmdUpdateBuffer;
3509 custom_functions["vkCmdFillBuffer"] = (void *)pv_vkCmdFillBuffer;
3510 custom_functions["vkCreateSwapchainKHR"] = (void *)pv_vkCreateSwapchainKHR;
3511 custom_functions["vkQueuePresentKHR"] = (void *)pv_vkQueuePresentKHR;
3512 custom_functions["vkCreateDescriptorPool"] = (void *)pv_vkCreateDescriptorPool;
3513 custom_functions["vkCmdDispatch"] = (void *)pv_vkCmdDispatch;
Mark Lobodzinskibf973a12018-03-01 08:50:21 -07003514 custom_functions["vkCmdDispatchBaseKHR"] = (void *)pv_vkCmdDispatchBaseKHR;
Jeff Bolz3e71f782018-08-29 23:15:45 -05003515 custom_functions["vkCmdSetExclusiveScissorNV"] = (void *)pv_vkCmdSetExclusiveScissorNV;
Jeff Bolz9af91c52018-09-01 21:53:57 -05003516 custom_functions["vkCmdSetViewportShadingRatePaletteNV"] = (void *)pv_vkCmdSetViewportShadingRatePaletteNV;
3517 custom_functions["vkCmdSetCoarseSampleOrderNV"] = (void *)pv_vkCmdSetCoarseSampleOrderNV;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003518}
3519
3520} // namespace parameter_validation
3521
3522VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateInstanceExtensionProperties(const char *pLayerName, uint32_t *pCount,
3523 VkExtensionProperties *pProperties) {
3524 return parameter_validation::vkEnumerateInstanceExtensionProperties(pLayerName, pCount, pProperties);
3525}
3526
3527VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateInstanceLayerProperties(uint32_t *pCount,
3528 VkLayerProperties *pProperties) {
3529 return parameter_validation::vkEnumerateInstanceLayerProperties(pCount, pProperties);
3530}
3531
3532VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateDeviceLayerProperties(VkPhysicalDevice physicalDevice, uint32_t *pCount,
3533 VkLayerProperties *pProperties) {
3534 // the layer command handles VK_NULL_HANDLE just fine internally
3535 assert(physicalDevice == VK_NULL_HANDLE);
3536 return parameter_validation::vkEnumerateDeviceLayerProperties(VK_NULL_HANDLE, pCount, pProperties);
3537}
3538
3539VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateDeviceExtensionProperties(VkPhysicalDevice physicalDevice,
3540 const char *pLayerName, uint32_t *pCount,
3541 VkExtensionProperties *pProperties) {
3542 // the layer command handles VK_NULL_HANDLE just fine internally
3543 assert(physicalDevice == VK_NULL_HANDLE);
3544 return parameter_validation::vkEnumerateDeviceExtensionProperties(VK_NULL_HANDLE, pLayerName, pCount, pProperties);
3545}
3546
3547VK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetDeviceProcAddr(VkDevice dev, const char *funcName) {
3548 return parameter_validation::vkGetDeviceProcAddr(dev, funcName);
3549}
3550
3551VK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetInstanceProcAddr(VkInstance instance, const char *funcName) {
3552 return parameter_validation::vkGetInstanceProcAddr(instance, funcName);
3553}
3554
3555VK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vk_layerGetPhysicalDeviceProcAddr(VkInstance instance,
3556 const char *funcName) {
3557 return parameter_validation::vkGetPhysicalDeviceProcAddr(instance, funcName);
3558}
3559
Lenny Komow2d0cbbe2018-05-24 13:38:05 -06003560VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL VKAPI_CALL
3561vkNegotiateLoaderLayerInterfaceVersion(VkNegotiateLayerInterface *pVersionStruct) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003562 assert(pVersionStruct != NULL);
3563 assert(pVersionStruct->sType == LAYER_NEGOTIATE_INTERFACE_STRUCT);
3564
3565 // Fill in the function pointers if our version is at least capable of having the structure contain them.
3566 if (pVersionStruct->loaderLayerInterfaceVersion >= 2) {
3567 pVersionStruct->pfnGetInstanceProcAddr = vkGetInstanceProcAddr;
3568 pVersionStruct->pfnGetDeviceProcAddr = vkGetDeviceProcAddr;
3569 pVersionStruct->pfnGetPhysicalDeviceProcAddr = vk_layerGetPhysicalDeviceProcAddr;
3570 }
3571
3572 if (pVersionStruct->loaderLayerInterfaceVersion < CURRENT_LOADER_LAYER_INTERFACE_VERSION) {
3573 parameter_validation::loader_layer_if_version = pVersionStruct->loaderLayerInterfaceVersion;
3574 } else if (pVersionStruct->loaderLayerInterfaceVersion > CURRENT_LOADER_LAYER_INTERFACE_VERSION) {
3575 pVersionStruct->loaderLayerInterfaceVersion = CURRENT_LOADER_LAYER_INTERFACE_VERSION;
3576 }
3577
3578 return VK_SUCCESS;
3579}