blob: b9adf037e21d0a4aeb3dd5d0e07c218db54e5b6f [file] [log] [blame]
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001/* Copyright (c) 2015-2017 The Khronos Group Inc.
2 * Copyright (c) 2015-2017 Valve Corporation
3 * Copyright (c) 2015-2017 LunarG, Inc.
4 * Copyright (C) 2015-2017 Google Inc.
5 *
6 * Licensed under the Apache License, Version 2.0 (the "License");
7 * you may not use this file except in compliance with the License.
8 * You may obtain a copy of the License at
9 *
10 * http://www.apache.org/licenses/LICENSE-2.0
11 *
12 * Unless required by applicable law or agreed to in writing, software
13 * distributed under the License is distributed on an "AS IS" BASIS,
14 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15 * See the License for the specific language governing permissions and
16 * limitations under the License.
17 *
18 * Author: Mark Lobodzinski <mark@LunarG.com>
19 */
20
21#define NOMINMAX
22
23#include <limits.h>
24#include <math.h>
25#include <stdio.h>
26#include <stdlib.h>
27#include <string.h>
Mark Lobodzinskid4950072017-08-01 13:02:20 -060028
29#include <iostream>
30#include <string>
31#include <sstream>
32#include <unordered_map>
33#include <unordered_set>
34#include <vector>
35#include <mutex>
36
37#include "vk_loader_platform.h"
38#include "vulkan/vk_layer.h"
39#include "vk_layer_config.h"
40#include "vk_dispatch_table_helper.h"
John Zulaufde972ac2017-10-26 12:07:05 -060041#include "vk_typemap_helper.h"
Mark Lobodzinskid4950072017-08-01 13:02:20 -060042
43#include "vk_layer_table.h"
44#include "vk_layer_data.h"
45#include "vk_layer_logging.h"
46#include "vk_layer_extension_utils.h"
47#include "vk_layer_utils.h"
48
49#include "parameter_name.h"
50#include "parameter_validation.h"
51
Mark Lobodzinskibfb7ab92017-10-27 13:22:23 -060052#if defined __ANDROID__
53#include <android/log.h>
Mark Lobodzinski88529492018-04-01 10:38:15 -060054#define LOGCONSOLE(...) ((void)__android_log_print(ANDROID_LOG_INFO, "PARAMETER_VALIDATION", __VA_ARGS__))
Mark Lobodzinskibfb7ab92017-10-27 13:22:23 -060055#else
56#define LOGCONSOLE(...) \
57 { \
58 printf(__VA_ARGS__); \
59 printf("\n"); \
60 }
61#endif
62
Mark Lobodzinskid4950072017-08-01 13:02:20 -060063namespace parameter_validation {
64
Mark Lobodzinski78a12a92017-08-08 14:16:51 -060065extern std::unordered_map<std::string, void *> custom_functions;
66
Mark Lobodzinskid4950072017-08-01 13:02:20 -060067extern bool parameter_validation_vkCreateInstance(VkInstance instance, const VkInstanceCreateInfo *pCreateInfo,
68 const VkAllocationCallbacks *pAllocator, VkInstance *pInstance);
69extern bool parameter_validation_vkDestroyInstance(VkInstance instance, const VkAllocationCallbacks *pAllocator);
70extern bool parameter_validation_vkCreateDevice(VkPhysicalDevice physicalDevice, const VkDeviceCreateInfo *pCreateInfo,
71 const VkAllocationCallbacks *pAllocator, VkDevice *pDevice);
72extern bool parameter_validation_vkDestroyDevice(VkDevice device, const VkAllocationCallbacks *pAllocator);
73extern bool parameter_validation_vkCreateQueryPool(VkDevice device, const VkQueryPoolCreateInfo *pCreateInfo,
74 const VkAllocationCallbacks *pAllocator, VkQueryPool *pQueryPool);
75extern bool parameter_validation_vkCreateDebugReportCallbackEXT(VkInstance instance,
76 const VkDebugReportCallbackCreateInfoEXT *pCreateInfo,
77 const VkAllocationCallbacks *pAllocator,
78 VkDebugReportCallbackEXT *pMsgCallback);
79extern bool parameter_validation_vkDestroyDebugReportCallbackEXT(VkInstance instance, VkDebugReportCallbackEXT msgCallback,
80 const VkAllocationCallbacks *pAllocator);
Mark Young6ba8abe2017-11-09 10:37:04 -070081extern bool parameter_validation_vkCreateDebugUtilsMessengerEXT(VkInstance instance,
82 const VkDebugUtilsMessengerCreateInfoEXT *pCreateInfo,
83 const VkAllocationCallbacks *pAllocator,
84 VkDebugUtilsMessengerEXT *pMessenger);
85extern bool parameter_validation_vkDestroyDebugUtilsMessengerEXT(VkInstance instance, VkDebugUtilsMessengerEXT messenger,
86 const VkAllocationCallbacks *pAllocator);
Mark Lobodzinskid4950072017-08-01 13:02:20 -060087extern bool parameter_validation_vkCreateCommandPool(VkDevice device, const VkCommandPoolCreateInfo *pCreateInfo,
88 const VkAllocationCallbacks *pAllocator, VkCommandPool *pCommandPool);
Petr Krause91f7a12017-12-14 20:57:36 +010089extern bool parameter_validation_vkCreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo,
90 const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass);
91extern bool parameter_validation_vkDestroyRenderPass(VkDevice device, VkRenderPass renderPass,
92 const VkAllocationCallbacks *pAllocator);
Mark Lobodzinskid4950072017-08-01 13:02:20 -060093
94// TODO : This can be much smarter, using separate locks for separate global data
95std::mutex global_lock;
96
97static uint32_t loader_layer_if_version = CURRENT_LOADER_LAYER_INTERFACE_VERSION;
98std::unordered_map<void *, layer_data *> layer_data_map;
99std::unordered_map<void *, instance_layer_data *> instance_layer_data_map;
100
101void InitializeManualParameterValidationFunctionPointers(void);
102
103static void init_parameter_validation(instance_layer_data *instance_data, const VkAllocationCallbacks *pAllocator) {
Mark Young6ba8abe2017-11-09 10:37:04 -0700104 layer_debug_report_actions(instance_data->report_data, instance_data->logging_callback, pAllocator,
105 "lunarg_parameter_validation");
106 layer_debug_messenger_actions(instance_data->report_data, instance_data->logging_messenger, pAllocator,
107 "lunarg_parameter_validation");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600108}
109
Mark Young6ba8abe2017-11-09 10:37:04 -0700110static const VkExtensionProperties instance_extensions[] = {{VK_EXT_DEBUG_REPORT_EXTENSION_NAME, VK_EXT_DEBUG_REPORT_SPEC_VERSION},
111 {VK_EXT_DEBUG_UTILS_EXTENSION_NAME, VK_EXT_DEBUG_UTILS_SPEC_VERSION}};
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600112
113static const VkLayerProperties global_layer = {
Dave Houltonb3bbec72018-01-17 10:13:33 -0700114 "VK_LAYER_LUNARG_parameter_validation",
115 VK_LAYER_API_VERSION,
116 1,
117 "LunarG Validation Layer",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600118};
119
120static const int MaxParamCheckerStringLength = 256;
121
John Zulauf71968502017-10-26 13:51:15 -0600122template <typename T>
123static inline bool in_inclusive_range(const T &value, const T &min, const T &max) {
124 // Using only < for generality and || for early abort
125 return !((value < min) || (max < value));
126}
127
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600128static bool validate_string(debug_report_data *report_data, const char *apiName, const ParameterName &stringName,
129 const char *validateString) {
130 assert(apiName != nullptr);
131 assert(validateString != nullptr);
132
133 bool skip = false;
134
135 VkStringErrorFlags result = vk_string_validate(MaxParamCheckerStringLength, validateString);
136
137 if (result == VK_STRING_ERROR_NONE) {
138 return skip;
139 } else if (result & VK_STRING_ERROR_LENGTH) {
Mark Lobodzinski88529492018-04-01 10:38:15 -0600140 skip = log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, INVALID_USAGE,
141 "%s: string %s exceeds max length %d", apiName, stringName.get_name().c_str(), MaxParamCheckerStringLength);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600142 } else if (result & VK_STRING_ERROR_BAD_DATA) {
Mark Lobodzinski88529492018-04-01 10:38:15 -0600143 skip = log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, INVALID_USAGE,
144 "%s: string %s contains invalid characters or is badly formed", apiName, stringName.get_name().c_str());
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600145 }
146 return skip;
147}
148
149static bool ValidateDeviceQueueFamily(layer_data *device_data, uint32_t queue_family, const char *cmd_name,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600150 const char *parameter_name, int32_t error_code, bool optional = false) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600151 bool skip = false;
152
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600153 if (!optional && queue_family == VK_QUEUE_FAMILY_IGNORED) {
154 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -0600155 HandleToUint64(device_data->device), error_code,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600156 "%s: %s is VK_QUEUE_FAMILY_IGNORED, but it is required to provide a valid queue family index value.",
157 cmd_name, parameter_name);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600158 } else if (device_data->queueFamilyIndexMap.find(queue_family) == device_data->queueFamilyIndexMap.end()) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600159 skip |=
160 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -0600161 HandleToUint64(device_data->device), error_code,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600162 "%s: %s (= %" PRIu32
163 ") is not one of the queue families given via VkDeviceQueueCreateInfo structures when the device was created.",
164 cmd_name, parameter_name, queue_family);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600165 }
166
167 return skip;
168}
169
170static bool ValidateQueueFamilies(layer_data *device_data, uint32_t queue_family_count, const uint32_t *queue_families,
171 const char *cmd_name, const char *array_parameter_name, int32_t unique_error_code,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600172 int32_t valid_error_code, bool optional = false) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600173 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600174 if (queue_families) {
175 std::unordered_set<uint32_t> set;
176 for (uint32_t i = 0; i < queue_family_count; ++i) {
177 std::string parameter_name = std::string(array_parameter_name) + "[" + std::to_string(i) + "]";
178
179 if (set.count(queue_families[i])) {
180 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -0600181 HandleToUint64(device_data->device), VALIDATION_ERROR_056002e8,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600182 "%s: %s (=%" PRIu32 ") is not unique within %s array.", cmd_name, parameter_name.c_str(),
183 queue_families[i], array_parameter_name);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600184 } else {
185 set.insert(queue_families[i]);
186 skip |= ValidateDeviceQueueFamily(device_data, queue_families[i], cmd_name, parameter_name.c_str(),
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600187 valid_error_code, optional);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600188 }
189 }
190 }
191 return skip;
192}
193
194VKAPI_ATTR VkResult VKAPI_CALL vkCreateInstance(const VkInstanceCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600195 VkInstance *pInstance) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600196 VkResult result = VK_ERROR_VALIDATION_FAILED_EXT;
197
198 VkLayerInstanceCreateInfo *chain_info = get_chain_info(pCreateInfo, VK_LAYER_LINK_INFO);
199 assert(chain_info != nullptr);
200 assert(chain_info->u.pLayerInfo != nullptr);
201
202 PFN_vkGetInstanceProcAddr fpGetInstanceProcAddr = chain_info->u.pLayerInfo->pfnNextGetInstanceProcAddr;
203 PFN_vkCreateInstance fpCreateInstance = (PFN_vkCreateInstance)fpGetInstanceProcAddr(NULL, "vkCreateInstance");
204 if (fpCreateInstance == NULL) {
205 return VK_ERROR_INITIALIZATION_FAILED;
206 }
207
208 // Advance the link info for the next element on the chain
209 chain_info->u.pLayerInfo = chain_info->u.pLayerInfo->pNext;
210
211 result = fpCreateInstance(pCreateInfo, pAllocator, pInstance);
212
213 if (result == VK_SUCCESS) {
214 InitializeManualParameterValidationFunctionPointers();
215 auto my_instance_data = GetLayerDataPtr(get_dispatch_key(*pInstance), instance_layer_data_map);
216 assert(my_instance_data != nullptr);
217
218 layer_init_instance_dispatch_table(*pInstance, &my_instance_data->dispatch_table, fpGetInstanceProcAddr);
219 my_instance_data->instance = *pInstance;
220 my_instance_data->report_data =
Mark Young6ba8abe2017-11-09 10:37:04 -0700221 debug_utils_create_instance(&my_instance_data->dispatch_table, *pInstance, pCreateInfo->enabledExtensionCount,
222 pCreateInfo->ppEnabledExtensionNames);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600223
224 // Look for one or more debug report create info structures
225 // and setup a callback(s) for each one found.
Mark Young6ba8abe2017-11-09 10:37:04 -0700226 if (!layer_copy_tmp_debug_messengers(pCreateInfo->pNext, &my_instance_data->num_tmp_debug_messengers,
227 &my_instance_data->tmp_messenger_create_infos,
228 &my_instance_data->tmp_debug_messengers)) {
229 if (my_instance_data->num_tmp_debug_messengers > 0) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600230 // Setup the temporary callback(s) here to catch early issues:
Mark Young6ba8abe2017-11-09 10:37:04 -0700231 if (layer_enable_tmp_debug_messengers(my_instance_data->report_data, my_instance_data->num_tmp_debug_messengers,
232 my_instance_data->tmp_messenger_create_infos,
233 my_instance_data->tmp_debug_messengers)) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600234 // Failure of setting up one or more of the callback.
235 // Therefore, clean up and don't use those callbacks:
Mark Young6ba8abe2017-11-09 10:37:04 -0700236 layer_free_tmp_debug_messengers(my_instance_data->tmp_messenger_create_infos,
237 my_instance_data->tmp_debug_messengers);
238 my_instance_data->num_tmp_debug_messengers = 0;
239 }
240 }
241 }
242 if (!layer_copy_tmp_report_callbacks(pCreateInfo->pNext, &my_instance_data->num_tmp_report_callbacks,
243 &my_instance_data->tmp_report_create_infos, &my_instance_data->tmp_report_callbacks)) {
244 if (my_instance_data->num_tmp_report_callbacks > 0) {
245 // Setup the temporary callback(s) here to catch early issues:
246 if (layer_enable_tmp_report_callbacks(my_instance_data->report_data, my_instance_data->num_tmp_report_callbacks,
247 my_instance_data->tmp_report_create_infos,
248 my_instance_data->tmp_report_callbacks)) {
249 // Failure of setting up one or more of the callback.
250 // Therefore, clean up and don't use those callbacks:
251 layer_free_tmp_report_callbacks(my_instance_data->tmp_report_create_infos,
252 my_instance_data->tmp_report_callbacks);
253 my_instance_data->num_tmp_report_callbacks = 0;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600254 }
255 }
256 }
257
258 init_parameter_validation(my_instance_data, pAllocator);
John Zulaufe6db8a32018-03-30 14:51:59 -0600259 // Note: From the spec--
260 // Providing a NULL VkInstanceCreateInfo::pApplicationInfo or providing an apiVersion of 0 is equivalent to providing
261 // an apiVersion of VK_MAKE_VERSION(1, 0, 0). (a.k.a. VK_API_VERSION_1_0)
262 uint32_t api_version = (pCreateInfo->pApplicationInfo && pCreateInfo->pApplicationInfo->apiVersion)
263 ? pCreateInfo->pApplicationInfo->apiVersion
264 : VK_API_VERSION_1_0;
Mark Lobodzinskibfb7ab92017-10-27 13:22:23 -0600265
John Zulaufe6db8a32018-03-30 14:51:59 -0600266 uint32_t effective_api_version = my_instance_data->extensions.InitFromInstanceCreateInfo(api_version, pCreateInfo);
Mark Lobodzinskibfb7ab92017-10-27 13:22:23 -0600267
John Zulaufe6db8a32018-03-30 14:51:59 -0600268 uint32_t api_version_nopatch = VK_MAKE_VERSION(VK_VERSION_MAJOR(api_version), VK_VERSION_MINOR(api_version), 0);
269 if (api_version_nopatch != effective_api_version) {
270 const char *effective_api_string =
271 (effective_api_version == VK_API_VERSION_1_0) ? "VK_API_VERSION_1_0" : "VK_API_VERSION_1_1";
272 if (api_version_nopatch < VK_API_VERSION_1_0) {
273 log_msg(my_instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
274 VALIDATION_ERROR_UNDEFINED,
275 "Invalid CreateInstance->pCreateInfo->pApplicationInfo.apiVersion number (0x%08x). Using %s.\n",
276 api_version, effective_api_string);
277 } else {
278 log_msg(my_instance_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
279 VALIDATION_ERROR_UNDEFINED,
280 "Unrecognized CreateInstance->pCreateInfo->pApplicationInfo.apiVersion number (0x%08x). Assuming %s.\n",
281 api_version, effective_api_string);
Mark Lobodzinskibfb7ab92017-10-27 13:22:23 -0600282 }
283 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600284
285 // Ordinarily we'd check these before calling down the chain, but none of the layer support is in place until now, if we
286 // survive we can report the issue now.
287 parameter_validation_vkCreateInstance(*pInstance, pCreateInfo, pAllocator, pInstance);
288
289 if (pCreateInfo->pApplicationInfo) {
290 if (pCreateInfo->pApplicationInfo->pApplicationName) {
291 validate_string(my_instance_data->report_data, "vkCreateInstance",
292 "pCreateInfo->VkApplicationInfo->pApplicationName",
293 pCreateInfo->pApplicationInfo->pApplicationName);
294 }
295
296 if (pCreateInfo->pApplicationInfo->pEngineName) {
297 validate_string(my_instance_data->report_data, "vkCreateInstance", "pCreateInfo->VkApplicationInfo->pEngineName",
298 pCreateInfo->pApplicationInfo->pEngineName);
299 }
300 }
301
302 // Disable the tmp callbacks:
Mark Young6ba8abe2017-11-09 10:37:04 -0700303 if (my_instance_data->num_tmp_debug_messengers > 0) {
304 layer_disable_tmp_debug_messengers(my_instance_data->report_data, my_instance_data->num_tmp_debug_messengers,
305 my_instance_data->tmp_debug_messengers);
306 }
307 if (my_instance_data->num_tmp_report_callbacks > 0) {
308 layer_disable_tmp_report_callbacks(my_instance_data->report_data, my_instance_data->num_tmp_report_callbacks,
309 my_instance_data->tmp_report_callbacks);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600310 }
311 }
312
313 return result;
314}
315
316VKAPI_ATTR void VKAPI_CALL vkDestroyInstance(VkInstance instance, const VkAllocationCallbacks *pAllocator) {
317 // Grab the key before the instance is destroyed.
318 dispatch_key key = get_dispatch_key(instance);
319 bool skip = false;
320 auto instance_data = GetLayerDataPtr(key, instance_layer_data_map);
321
322 // Enable the temporary callback(s) here to catch vkDestroyInstance issues:
323 bool callback_setup = false;
Mark Young6ba8abe2017-11-09 10:37:04 -0700324 if (instance_data->num_tmp_debug_messengers > 0) {
325 if (!layer_enable_tmp_debug_messengers(instance_data->report_data, instance_data->num_tmp_debug_messengers,
326 instance_data->tmp_messenger_create_infos, instance_data->tmp_debug_messengers)) {
327 callback_setup = true;
328 }
329 }
330 if (instance_data->num_tmp_report_callbacks > 0) {
331 if (!layer_enable_tmp_report_callbacks(instance_data->report_data, instance_data->num_tmp_report_callbacks,
332 instance_data->tmp_report_create_infos, instance_data->tmp_report_callbacks)) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600333 callback_setup = true;
334 }
335 }
336
337 skip |= parameter_validation_vkDestroyInstance(instance, pAllocator);
338
339 // Disable and cleanup the temporary callback(s):
340 if (callback_setup) {
Mark Young6ba8abe2017-11-09 10:37:04 -0700341 layer_disable_tmp_debug_messengers(instance_data->report_data, instance_data->num_tmp_debug_messengers,
342 instance_data->tmp_debug_messengers);
343 layer_disable_tmp_report_callbacks(instance_data->report_data, instance_data->num_tmp_report_callbacks,
344 instance_data->tmp_report_callbacks);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600345 }
Mark Young6ba8abe2017-11-09 10:37:04 -0700346 if (instance_data->num_tmp_debug_messengers > 0) {
347 layer_free_tmp_debug_messengers(instance_data->tmp_messenger_create_infos, instance_data->tmp_debug_messengers);
348 instance_data->num_tmp_debug_messengers = 0;
349 }
350 if (instance_data->num_tmp_report_callbacks > 0) {
351 layer_free_tmp_report_callbacks(instance_data->tmp_report_create_infos, instance_data->tmp_report_callbacks);
352 instance_data->num_tmp_report_callbacks = 0;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600353 }
354
355 if (!skip) {
356 instance_data->dispatch_table.DestroyInstance(instance, pAllocator);
357
358 // Clean up logging callback, if any
Mark Young6ba8abe2017-11-09 10:37:04 -0700359 while (instance_data->logging_messenger.size() > 0) {
360 VkDebugUtilsMessengerEXT messenger = instance_data->logging_messenger.back();
361 layer_destroy_messenger_callback(instance_data->report_data, messenger, pAllocator);
362 instance_data->logging_messenger.pop_back();
363 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600364 while (instance_data->logging_callback.size() > 0) {
365 VkDebugReportCallbackEXT callback = instance_data->logging_callback.back();
Mark Young6ba8abe2017-11-09 10:37:04 -0700366 layer_destroy_report_callback(instance_data->report_data, callback, pAllocator);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600367 instance_data->logging_callback.pop_back();
368 }
369
Mark Young6ba8abe2017-11-09 10:37:04 -0700370 layer_debug_utils_destroy_instance(instance_data->report_data);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600371 }
372
373 FreeLayerDataPtr(key, instance_layer_data_map);
374}
375
376VKAPI_ATTR VkResult VKAPI_CALL vkCreateDebugReportCallbackEXT(VkInstance instance,
377 const VkDebugReportCallbackCreateInfoEXT *pCreateInfo,
378 const VkAllocationCallbacks *pAllocator,
379 VkDebugReportCallbackEXT *pMsgCallback) {
380 bool skip = parameter_validation_vkCreateDebugReportCallbackEXT(instance, pCreateInfo, pAllocator, pMsgCallback);
381 if (skip) return VK_ERROR_VALIDATION_FAILED_EXT;
382
383 auto instance_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map);
384 VkResult result = instance_data->dispatch_table.CreateDebugReportCallbackEXT(instance, pCreateInfo, pAllocator, pMsgCallback);
385 if (result == VK_SUCCESS) {
Mark Young6ba8abe2017-11-09 10:37:04 -0700386 result = layer_create_report_callback(instance_data->report_data, false, pCreateInfo, pAllocator, pMsgCallback);
387 // If something happened during this call, clean up the message callback that was created earlier in the lower levels
388 if (VK_SUCCESS != result) {
389 instance_data->dispatch_table.DestroyDebugReportCallbackEXT(instance, *pMsgCallback, pAllocator);
390 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600391 }
392 return result;
393}
394
395VKAPI_ATTR void VKAPI_CALL vkDestroyDebugReportCallbackEXT(VkInstance instance, VkDebugReportCallbackEXT msgCallback,
396 const VkAllocationCallbacks *pAllocator) {
397 bool skip = parameter_validation_vkDestroyDebugReportCallbackEXT(instance, msgCallback, pAllocator);
398 if (!skip) {
399 auto instance_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map);
400 instance_data->dispatch_table.DestroyDebugReportCallbackEXT(instance, msgCallback, pAllocator);
Mark Young6ba8abe2017-11-09 10:37:04 -0700401 layer_destroy_report_callback(instance_data->report_data, msgCallback, pAllocator);
402 }
403}
404
405VKAPI_ATTR VkResult VKAPI_CALL vkCreateDebugUtilsMessengerEXT(VkInstance instance,
406 const VkDebugUtilsMessengerCreateInfoEXT *pCreateInfo,
407 const VkAllocationCallbacks *pAllocator,
408 VkDebugUtilsMessengerEXT *pMessenger) {
409 bool skip = parameter_validation_vkCreateDebugUtilsMessengerEXT(instance, pCreateInfo, pAllocator, pMessenger);
410 if (skip) return VK_ERROR_VALIDATION_FAILED_EXT;
411
412 auto instance_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map);
413 VkResult result = instance_data->dispatch_table.CreateDebugUtilsMessengerEXT(instance, pCreateInfo, pAllocator, pMessenger);
414 if (VK_SUCCESS == result) {
415 result = layer_create_messenger_callback(instance_data->report_data, false, pCreateInfo, pAllocator, pMessenger);
416 // If something happened during this call, clean up the message callback that was created earlier in the lower levels
417 if (VK_SUCCESS != result) {
418 instance_data->dispatch_table.DestroyDebugUtilsMessengerEXT(instance, *pMessenger, pAllocator);
419 }
420 }
421 return result;
422}
423
424VKAPI_ATTR void VKAPI_CALL vkDestroyDebugUtilsMessengerEXT(VkInstance instance, VkDebugUtilsMessengerEXT messenger,
425 const VkAllocationCallbacks *pAllocator) {
426 bool skip = parameter_validation_vkDestroyDebugUtilsMessengerEXT(instance, messenger, pAllocator);
427 if (!skip) {
428 auto instance_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map);
429 instance_data->dispatch_table.DestroyDebugUtilsMessengerEXT(instance, messenger, pAllocator);
430 layer_destroy_messenger_callback(instance_data->report_data, messenger, pAllocator);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600431 }
432}
433
434static bool ValidateDeviceCreateInfo(instance_layer_data *instance_data, VkPhysicalDevice physicalDevice,
435 const VkDeviceCreateInfo *pCreateInfo) {
436 bool skip = false;
437
438 if ((pCreateInfo->enabledLayerCount > 0) && (pCreateInfo->ppEnabledLayerNames != NULL)) {
439 for (size_t i = 0; i < pCreateInfo->enabledLayerCount; i++) {
440 skip |= validate_string(instance_data->report_data, "vkCreateDevice", "pCreateInfo->ppEnabledLayerNames",
441 pCreateInfo->ppEnabledLayerNames[i]);
442 }
443 }
444
445 bool maint1 = false;
446 bool negative_viewport = false;
447
448 if ((pCreateInfo->enabledExtensionCount > 0) && (pCreateInfo->ppEnabledExtensionNames != NULL)) {
449 for (size_t i = 0; i < pCreateInfo->enabledExtensionCount; i++) {
450 skip |= validate_string(instance_data->report_data, "vkCreateDevice", "pCreateInfo->ppEnabledExtensionNames",
451 pCreateInfo->ppEnabledExtensionNames[i]);
452 if (strcmp(pCreateInfo->ppEnabledExtensionNames[i], VK_KHR_MAINTENANCE1_EXTENSION_NAME) == 0) maint1 = true;
453 if (strcmp(pCreateInfo->ppEnabledExtensionNames[i], VK_AMD_NEGATIVE_VIEWPORT_HEIGHT_EXTENSION_NAME) == 0)
454 negative_viewport = true;
455 }
456 }
457
458 if (maint1 && negative_viewport) {
459 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -0600460 VALIDATION_ERROR_056002ec,
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600461 "VkDeviceCreateInfo->ppEnabledExtensionNames must not simultaneously include VK_KHR_maintenance1 and "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600462 "VK_AMD_negative_viewport_height.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600463 }
464
465 if (pCreateInfo->pNext != NULL && pCreateInfo->pEnabledFeatures) {
466 // Check for get_physical_device_properties2 struct
John Zulaufde972ac2017-10-26 12:07:05 -0600467 const auto *features2 = lvl_find_in_chain<VkPhysicalDeviceFeatures2KHR>(pCreateInfo->pNext);
468 if (features2) {
469 // Cannot include VkPhysicalDeviceFeatures2KHR and have non-null pEnabledFeatures
470 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -0600471 INVALID_USAGE,
John Zulaufde972ac2017-10-26 12:07:05 -0600472 "VkDeviceCreateInfo->pNext includes a VkPhysicalDeviceFeatures2KHR struct when "
473 "pCreateInfo->pEnabledFeatures is non-NULL.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600474 }
475 }
476
477 // Validate pCreateInfo->pQueueCreateInfos
478 if (pCreateInfo->pQueueCreateInfos) {
479 std::unordered_set<uint32_t> set;
480
481 for (uint32_t i = 0; i < pCreateInfo->queueCreateInfoCount; ++i) {
482 const uint32_t requested_queue_family = pCreateInfo->pQueueCreateInfos[i].queueFamilyIndex;
483 if (requested_queue_family == VK_QUEUE_FAMILY_IGNORED) {
484 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT,
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600485 VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, HandleToUint64(physicalDevice),
Mark Lobodzinski88529492018-04-01 10:38:15 -0600486 VALIDATION_ERROR_06c002fa,
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600487 "vkCreateDevice: pCreateInfo->pQueueCreateInfos[%" PRIu32
Dave Houltona9df0ce2018-02-07 10:51:23 -0700488 "].queueFamilyIndex is VK_QUEUE_FAMILY_IGNORED, but it is required to provide a valid queue family "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600489 "index value.",
490 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600491 } else if (set.count(requested_queue_family)) {
492 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT,
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600493 VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, HandleToUint64(physicalDevice),
Mark Lobodzinski88529492018-04-01 10:38:15 -0600494 VALIDATION_ERROR_056002e8,
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600495 "vkCreateDevice: pCreateInfo->pQueueCreateInfos[%" PRIu32 "].queueFamilyIndex (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600496 ") is not unique within pCreateInfo->pQueueCreateInfos array.",
497 i, requested_queue_family);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600498 } else {
499 set.insert(requested_queue_family);
500 }
501
502 if (pCreateInfo->pQueueCreateInfos[i].pQueuePriorities != nullptr) {
503 for (uint32_t j = 0; j < pCreateInfo->pQueueCreateInfos[i].queueCount; ++j) {
504 const float queue_priority = pCreateInfo->pQueueCreateInfos[i].pQueuePriorities[j];
505 if (!(queue_priority >= 0.f) || !(queue_priority <= 1.f)) {
506 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT,
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600507 VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, HandleToUint64(physicalDevice),
Mark Lobodzinski88529492018-04-01 10:38:15 -0600508 VALIDATION_ERROR_06c002fe,
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600509 "vkCreateDevice: pCreateInfo->pQueueCreateInfos[%" PRIu32 "].pQueuePriorities[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600510 "] (=%f) is not between 0 and 1 (inclusive).",
511 i, j, queue_priority);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600512 }
513 }
514 }
515 }
516 }
517
518 return skip;
519}
520
521VKAPI_ATTR VkResult VKAPI_CALL vkCreateDevice(VkPhysicalDevice physicalDevice, const VkDeviceCreateInfo *pCreateInfo,
522 const VkAllocationCallbacks *pAllocator, VkDevice *pDevice) {
523 // NOTE: Don't validate physicalDevice or any dispatchable object as the first parameter. We couldn't get here if it was wrong!
524
525 VkResult result = VK_ERROR_VALIDATION_FAILED_EXT;
526 bool skip = false;
527 auto my_instance_data = GetLayerDataPtr(get_dispatch_key(physicalDevice), instance_layer_data_map);
528 assert(my_instance_data != nullptr);
529 std::unique_lock<std::mutex> lock(global_lock);
530
531 skip |= parameter_validation_vkCreateDevice(physicalDevice, pCreateInfo, pAllocator, pDevice);
532
533 if (pCreateInfo != NULL) skip |= ValidateDeviceCreateInfo(my_instance_data, physicalDevice, pCreateInfo);
534
535 if (!skip) {
536 VkLayerDeviceCreateInfo *chain_info = get_chain_info(pCreateInfo, VK_LAYER_LINK_INFO);
537 assert(chain_info != nullptr);
538 assert(chain_info->u.pLayerInfo != nullptr);
539
540 PFN_vkGetInstanceProcAddr fpGetInstanceProcAddr = chain_info->u.pLayerInfo->pfnNextGetInstanceProcAddr;
541 PFN_vkGetDeviceProcAddr fpGetDeviceProcAddr = chain_info->u.pLayerInfo->pfnNextGetDeviceProcAddr;
542 PFN_vkCreateDevice fpCreateDevice = (PFN_vkCreateDevice)fpGetInstanceProcAddr(my_instance_data->instance, "vkCreateDevice");
543 if (fpCreateDevice == NULL) {
544 return VK_ERROR_INITIALIZATION_FAILED;
545 }
546
547 // Advance the link info for the next element on the chain
548 chain_info->u.pLayerInfo = chain_info->u.pLayerInfo->pNext;
549
550 lock.unlock();
551
552 result = fpCreateDevice(physicalDevice, pCreateInfo, pAllocator, pDevice);
553
554 lock.lock();
555
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600556 if (result == VK_SUCCESS) {
557 layer_data *my_device_data = GetLayerDataPtr(get_dispatch_key(*pDevice), layer_data_map);
558 assert(my_device_data != nullptr);
559
Mark Young6ba8abe2017-11-09 10:37:04 -0700560 my_device_data->report_data = layer_debug_utils_create_device(my_instance_data->report_data, *pDevice);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600561 layer_init_device_dispatch_table(*pDevice, &my_device_data->dispatch_table, fpGetDeviceProcAddr);
562
Mark Lobodzinskibfb7ab92017-10-27 13:22:23 -0600563 // Query and save physical device limits for this device
564 VkPhysicalDeviceProperties device_properties = {};
565 my_instance_data->dispatch_table.GetPhysicalDeviceProperties(physicalDevice, &device_properties);
566
567 my_device_data->api_version = my_device_data->extensions.InitFromDeviceCreateInfo(
568 &my_instance_data->extensions, device_properties.apiVersion, pCreateInfo);
569
570 uint32_t specified_api_version = device_properties.apiVersion & ~VK_VERSION_PATCH(~0);
571 if (!(specified_api_version == VK_API_VERSION_1_0) && !(specified_api_version == VK_API_VERSION_1_1)) {
572 LOGCONSOLE(
573 "Warning: Unrecognized CreateInstance->pCreateInfo->pApplicationInfo.apiVersion number -- (0x%8x) assuming "
574 "%s.\n",
575 device_properties.apiVersion,
576 (my_device_data->api_version == VK_API_VERSION_1_0) ? "VK_API_VERSION_1_0" : "VK_API_VERSION_1_1");
577 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600578
579 // Store createdevice data
580 if ((pCreateInfo != nullptr) && (pCreateInfo->pQueueCreateInfos != nullptr)) {
581 for (uint32_t i = 0; i < pCreateInfo->queueCreateInfoCount; ++i) {
582 my_device_data->queueFamilyIndexMap.insert(std::make_pair(pCreateInfo->pQueueCreateInfos[i].queueFamilyIndex,
583 pCreateInfo->pQueueCreateInfos[i].queueCount));
584 }
585 }
586
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600587 memcpy(&my_device_data->device_limits, &device_properties.limits, sizeof(VkPhysicalDeviceLimits));
588 my_device_data->physical_device = physicalDevice;
589 my_device_data->device = *pDevice;
590
591 // Save app-enabled features in this device's layer_data structure
John Zulauf1bde5bb2017-10-18 18:21:23 -0600592 // The enabled features can come from either pEnabledFeatures, or from the pNext chain
593 const VkPhysicalDeviceFeatures *enabled_features_found = pCreateInfo->pEnabledFeatures;
594 if ((nullptr == enabled_features_found) && my_device_data->extensions.vk_khr_get_physical_device_properties_2) {
John Zulaufde972ac2017-10-26 12:07:05 -0600595 const auto *features2 = lvl_find_in_chain<VkPhysicalDeviceFeatures2KHR>(pCreateInfo->pNext);
596 if (features2) {
597 enabled_features_found = &(features2->features);
John Zulauf1bde5bb2017-10-18 18:21:23 -0600598 }
599 }
600 if (enabled_features_found) {
Dave Houltonb3bbec72018-01-17 10:13:33 -0700601 my_device_data->physical_device_features = *enabled_features_found;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600602 } else {
603 memset(&my_device_data->physical_device_features, 0, sizeof(VkPhysicalDeviceFeatures));
604 }
605 }
606 }
607
608 return result;
609}
610
611VKAPI_ATTR void VKAPI_CALL vkDestroyDevice(VkDevice device, const VkAllocationCallbacks *pAllocator) {
612 dispatch_key key = get_dispatch_key(device);
613 bool skip = false;
614 layer_data *device_data = GetLayerDataPtr(key, layer_data_map);
615 {
616 std::unique_lock<std::mutex> lock(global_lock);
617 skip |= parameter_validation_vkDestroyDevice(device, pAllocator);
618 }
619
620 if (!skip) {
Mark Young6ba8abe2017-11-09 10:37:04 -0700621 layer_debug_utils_destroy_device(device);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600622 device_data->dispatch_table.DestroyDevice(device, pAllocator);
623 }
624 FreeLayerDataPtr(key, layer_data_map);
625}
626
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600627bool pv_vkGetDeviceQueue(VkDevice device, uint32_t queueFamilyIndex, uint32_t queueIndex, VkQueue *pQueue) {
628 bool skip = false;
629 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
630
631 skip |=
632 ValidateDeviceQueueFamily(device_data, queueFamilyIndex, "vkGetDeviceQueue", "queueFamilyIndex", VALIDATION_ERROR_29600300);
633 const auto &queue_data = device_data->queueFamilyIndexMap.find(queueFamilyIndex);
634 if (queue_data != device_data->queueFamilyIndexMap.end() && queue_data->second <= queueIndex) {
635 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -0600636 HandleToUint64(device), VALIDATION_ERROR_29600302,
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600637 "vkGetDeviceQueue: queueIndex (=%" PRIu32
Dave Houltona9df0ce2018-02-07 10:51:23 -0700638 ") is not less than the number of queues requested from queueFamilyIndex (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600639 ") when the device was created (i.e. is not less than %" PRIu32 ").",
640 queueIndex, queueFamilyIndex, queue_data->second);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600641 }
642 return skip;
643}
644
645VKAPI_ATTR VkResult VKAPI_CALL vkCreateCommandPool(VkDevice device, const VkCommandPoolCreateInfo *pCreateInfo,
646 const VkAllocationCallbacks *pAllocator, VkCommandPool *pCommandPool) {
647 layer_data *local_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
648 bool skip = false;
649 VkResult result = VK_ERROR_VALIDATION_FAILED_EXT;
650 std::unique_lock<std::mutex> lock(global_lock);
651
652 skip |= ValidateDeviceQueueFamily(local_data, pCreateInfo->queueFamilyIndex, "vkCreateCommandPool",
653 "pCreateInfo->queueFamilyIndex", VALIDATION_ERROR_02c0004e);
654
655 skip |= parameter_validation_vkCreateCommandPool(device, pCreateInfo, pAllocator, pCommandPool);
656
657 lock.unlock();
658 if (!skip) {
659 result = local_data->dispatch_table.CreateCommandPool(device, pCreateInfo, pAllocator, pCommandPool);
660 }
661 return result;
662}
663
664VKAPI_ATTR VkResult VKAPI_CALL vkCreateQueryPool(VkDevice device, const VkQueryPoolCreateInfo *pCreateInfo,
665 const VkAllocationCallbacks *pAllocator, VkQueryPool *pQueryPool) {
666 VkResult result = VK_ERROR_VALIDATION_FAILED_EXT;
667 bool skip = false;
668 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
669
670 skip |= parameter_validation_vkCreateQueryPool(device, pCreateInfo, pAllocator, pQueryPool);
671
672 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
673 if (pCreateInfo != nullptr) {
674 // If queryType is VK_QUERY_TYPE_PIPELINE_STATISTICS, pipelineStatistics must be a valid combination of
675 // VkQueryPipelineStatisticFlagBits values
676 if ((pCreateInfo->queryType == VK_QUERY_TYPE_PIPELINE_STATISTICS) && (pCreateInfo->pipelineStatistics != 0) &&
677 ((pCreateInfo->pipelineStatistics & (~AllVkQueryPipelineStatisticFlagBits)) != 0)) {
678 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -0600679 VALIDATION_ERROR_11c00630,
Dave Houltona9df0ce2018-02-07 10:51:23 -0700680 "vkCreateQueryPool(): if pCreateInfo->queryType is VK_QUERY_TYPE_PIPELINE_STATISTICS, "
681 "pCreateInfo->pipelineStatistics must be a valid combination of VkQueryPipelineStatisticFlagBits "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600682 "values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600683 }
684 }
685 if (!skip) {
686 result = device_data->dispatch_table.CreateQueryPool(device, pCreateInfo, pAllocator, pQueryPool);
687 }
688 return result;
689}
690
Petr Krause91f7a12017-12-14 20:57:36 +0100691VKAPI_ATTR VkResult VKAPI_CALL vkCreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo,
692 const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass) {
693 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
694 bool skip = false;
695 VkResult result = VK_ERROR_VALIDATION_FAILED_EXT;
696
697 {
698 std::unique_lock<std::mutex> lock(global_lock);
699 skip |= parameter_validation_vkCreateRenderPass(device, pCreateInfo, pAllocator, pRenderPass);
700
Dave Houltonb3bbec72018-01-17 10:13:33 -0700701 typedef bool (*PFN_manual_vkCreateRenderPass)(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo,
702 const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass);
Petr Krause91f7a12017-12-14 20:57:36 +0100703 PFN_manual_vkCreateRenderPass custom_func = (PFN_manual_vkCreateRenderPass)custom_functions["vkCreateRenderPass"];
704 if (custom_func != nullptr) {
705 skip |= custom_func(device, pCreateInfo, pAllocator, pRenderPass);
706 }
707 }
708
709 if (!skip) {
710 result = device_data->dispatch_table.CreateRenderPass(device, pCreateInfo, pAllocator, pRenderPass);
711
712 // track the state necessary for checking vkCreateGraphicsPipeline (subpass usage of depth and color attachments)
713 if (result == VK_SUCCESS) {
714 std::unique_lock<std::mutex> lock(global_lock);
715 const auto renderPass = *pRenderPass;
716 auto &renderpass_state = device_data->renderpasses_states[renderPass];
717
718 for (uint32_t subpass = 0; subpass < pCreateInfo->subpassCount; ++subpass) {
719 bool uses_color = false;
720 for (uint32_t i = 0; i < pCreateInfo->pSubpasses[subpass].colorAttachmentCount && !uses_color; ++i)
721 if (pCreateInfo->pSubpasses[subpass].pColorAttachments[i].attachment != VK_ATTACHMENT_UNUSED) uses_color = true;
722
723 bool uses_depthstencil = false;
724 if (pCreateInfo->pSubpasses[subpass].pDepthStencilAttachment)
725 if (pCreateInfo->pSubpasses[subpass].pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED)
726 uses_depthstencil = true;
727
728 if (uses_color) renderpass_state.subpasses_using_color_attachment.insert(subpass);
729 if (uses_depthstencil) renderpass_state.subpasses_using_depthstencil_attachment.insert(subpass);
730 }
731 }
732 }
733 return result;
734}
735
736VKAPI_ATTR void VKAPI_CALL vkDestroyRenderPass(VkDevice device, VkRenderPass renderPass, const VkAllocationCallbacks *pAllocator) {
737 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
738 bool skip = false;
739
740 {
741 std::unique_lock<std::mutex> lock(global_lock);
742 skip |= parameter_validation_vkDestroyRenderPass(device, renderPass, pAllocator);
743
Dave Houltonb3bbec72018-01-17 10:13:33 -0700744 typedef bool (*PFN_manual_vkDestroyRenderPass)(VkDevice device, VkRenderPass renderPass,
745 const VkAllocationCallbacks *pAllocator);
Petr Krause91f7a12017-12-14 20:57:36 +0100746 PFN_manual_vkDestroyRenderPass custom_func = (PFN_manual_vkDestroyRenderPass)custom_functions["vkDestroyRenderPass"];
747 if (custom_func != nullptr) {
748 skip |= custom_func(device, renderPass, pAllocator);
749 }
750 }
751
752 if (!skip) {
753 device_data->dispatch_table.DestroyRenderPass(device, renderPass, pAllocator);
754
755 // track the state necessary for checking vkCreateGraphicsPipeline (subpass usage of depth and color attachments)
756 {
757 std::unique_lock<std::mutex> lock(global_lock);
758 device_data->renderpasses_states.erase(renderPass);
759 }
760 }
761}
762
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600763bool pv_vkCreateBuffer(VkDevice device, const VkBufferCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
764 VkBuffer *pBuffer) {
765 bool skip = false;
766 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
767 debug_report_data *report_data = device_data->report_data;
768
Mark Lobodzinski88529492018-04-01 10:38:15 -0600769 const LogMiscParams log_misc{report_data, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, VK_NULL_HANDLE, "vkCreateBuffer"};
Petr Krause5c37652018-01-05 04:05:12 +0100770
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600771 if (pCreateInfo != nullptr) {
Petr Krause5c37652018-01-05 04:05:12 +0100772 skip |= ValidateGreaterThanZero(pCreateInfo->size, "pCreateInfo->size", VALIDATION_ERROR_01400720, log_misc);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600773
774 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
775 if (pCreateInfo->sharingMode == VK_SHARING_MODE_CONCURRENT) {
776 // If sharingMode is VK_SHARING_MODE_CONCURRENT, queueFamilyIndexCount must be greater than 1
777 if (pCreateInfo->queueFamilyIndexCount <= 1) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600778 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -0600779 VALIDATION_ERROR_01400724,
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600780 "vkCreateBuffer: if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600781 "pCreateInfo->queueFamilyIndexCount must be greater than 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600782 }
783
784 // If sharingMode is VK_SHARING_MODE_CONCURRENT, pQueueFamilyIndices must be a pointer to an array of
785 // queueFamilyIndexCount uint32_t values
786 if (pCreateInfo->pQueueFamilyIndices == nullptr) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600787 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -0600788 VALIDATION_ERROR_01400722,
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600789 "vkCreateBuffer: if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
790 "pCreateInfo->pQueueFamilyIndices must be a pointer to an array of "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600791 "pCreateInfo->queueFamilyIndexCount uint32_t values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600792 } else {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600793 skip |= ValidateQueueFamilies(device_data, pCreateInfo->queueFamilyIndexCount, pCreateInfo->pQueueFamilyIndices,
794 "vkCreateBuffer", "pCreateInfo->pQueueFamilyIndices", INVALID_USAGE, INVALID_USAGE,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600795 false);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600796 }
797 }
798
799 // If flags contains VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT or VK_BUFFER_CREATE_SPARSE_ALIASED_BIT, it must also contain
800 // VK_BUFFER_CREATE_SPARSE_BINDING_BIT
801 if (((pCreateInfo->flags & (VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT | VK_BUFFER_CREATE_SPARSE_ALIASED_BIT)) != 0) &&
802 ((pCreateInfo->flags & VK_BUFFER_CREATE_SPARSE_BINDING_BIT) != VK_BUFFER_CREATE_SPARSE_BINDING_BIT)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600803 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -0600804 VALIDATION_ERROR_0140072c,
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600805 "vkCreateBuffer: if pCreateInfo->flags contains VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT or "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600806 "VK_BUFFER_CREATE_SPARSE_ALIASED_BIT, it must also contain VK_BUFFER_CREATE_SPARSE_BINDING_BIT.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600807 }
808 }
809
810 return skip;
811}
812
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600813bool pv_vkCreateImage(VkDevice device, const VkImageCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
814 VkImage *pImage) {
815 bool skip = false;
816 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
817 debug_report_data *report_data = device_data->report_data;
818
Mark Lobodzinski88529492018-04-01 10:38:15 -0600819 const LogMiscParams log_misc{report_data, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, VK_NULL_HANDLE, "vkCreateImage"};
Petr Krause5c37652018-01-05 04:05:12 +0100820
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600821 if (pCreateInfo != nullptr) {
822 if ((device_data->physical_device_features.textureCompressionETC2 == false) &&
823 FormatIsCompressed_ETC2_EAC(pCreateInfo->format)) {
Mark Lobodzinski88529492018-04-01 10:38:15 -0600824 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, DEVICE_FEATURE,
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600825 "vkCreateImage(): Attempting to create VkImage with format %s. The textureCompressionETC2 feature is "
826 "not enabled: neither ETC2 nor EAC formats can be used to create images.",
827 string_VkFormat(pCreateInfo->format));
828 }
829
830 if ((device_data->physical_device_features.textureCompressionASTC_LDR == false) &&
831 FormatIsCompressed_ASTC_LDR(pCreateInfo->format)) {
Mark Lobodzinski88529492018-04-01 10:38:15 -0600832 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, DEVICE_FEATURE,
Dave Houltona9df0ce2018-02-07 10:51:23 -0700833 "vkCreateImage(): Attempting to create VkImage with format %s. The textureCompressionASTC_LDR feature "
834 "is not enabled: ASTC formats cannot be used to create images.",
835 string_VkFormat(pCreateInfo->format));
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600836 }
837
838 if ((device_data->physical_device_features.textureCompressionBC == false) && FormatIsCompressed_BC(pCreateInfo->format)) {
Mark Lobodzinski88529492018-04-01 10:38:15 -0600839 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, DEVICE_FEATURE,
Dave Houltona9df0ce2018-02-07 10:51:23 -0700840 "vkCreateImage(): Attempting to create VkImage with format %s. The textureCompressionBC feature is not "
841 "enabled: BC compressed formats cannot be used to create images.",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600842 string_VkFormat(pCreateInfo->format));
843 }
844
845 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
846 if (pCreateInfo->sharingMode == VK_SHARING_MODE_CONCURRENT) {
847 // If sharingMode is VK_SHARING_MODE_CONCURRENT, queueFamilyIndexCount must be greater than 1
848 if (pCreateInfo->queueFamilyIndexCount <= 1) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600849 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -0600850 VALIDATION_ERROR_09e0075c,
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600851 "vkCreateImage(): if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600852 "pCreateInfo->queueFamilyIndexCount must be greater than 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600853 }
854
855 // If sharingMode is VK_SHARING_MODE_CONCURRENT, pQueueFamilyIndices must be a pointer to an array of
856 // queueFamilyIndexCount uint32_t values
857 if (pCreateInfo->pQueueFamilyIndices == nullptr) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600858 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -0600859 VALIDATION_ERROR_09e0075a,
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600860 "vkCreateImage(): if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
861 "pCreateInfo->pQueueFamilyIndices must be a pointer to an array of "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600862 "pCreateInfo->queueFamilyIndexCount uint32_t values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600863 } else {
Mark Lobodzinski88529492018-04-01 10:38:15 -0600864 skip |=
865 ValidateQueueFamilies(device_data, pCreateInfo->queueFamilyIndexCount, pCreateInfo->pQueueFamilyIndices,
866 "vkCreateImage", "pCreateInfo->pQueueFamilyIndices", INVALID_USAGE, INVALID_USAGE, false);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600867 }
868 }
869
Petr Krause5c37652018-01-05 04:05:12 +0100870 skip |=
871 ValidateGreaterThanZero(pCreateInfo->extent.width, "pCreateInfo->extent.width", VALIDATION_ERROR_09e00760, log_misc);
872 skip |=
873 ValidateGreaterThanZero(pCreateInfo->extent.height, "pCreateInfo->extent.height", VALIDATION_ERROR_09e00762, log_misc);
874 skip |=
875 ValidateGreaterThanZero(pCreateInfo->extent.depth, "pCreateInfo->extent.depth", VALIDATION_ERROR_09e00764, log_misc);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600876
Petr Krause5c37652018-01-05 04:05:12 +0100877 skip |= ValidateGreaterThanZero(pCreateInfo->mipLevels, "pCreateInfo->mipLevels", VALIDATION_ERROR_09e00766, log_misc);
878 skip |= ValidateGreaterThanZero(pCreateInfo->arrayLayers, "pCreateInfo->arrayLayers", VALIDATION_ERROR_09e00768, log_misc);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600879
Dave Houlton130c0212018-01-29 13:39:56 -0700880 // InitialLayout must be PREINITIALIZED or UNDEFINED
Dave Houltone19e20d2018-02-02 16:32:41 -0700881 if ((pCreateInfo->initialLayout != VK_IMAGE_LAYOUT_UNDEFINED) &&
882 (pCreateInfo->initialLayout != VK_IMAGE_LAYOUT_PREINITIALIZED)) {
883 skip |= log_msg(
Mark Lobodzinski88529492018-04-01 10:38:15 -0600884 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, VALIDATION_ERROR_09e007c2,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600885 "vkCreateImage(): initialLayout is %s, must be VK_IMAGE_LAYOUT_UNDEFINED or VK_IMAGE_LAYOUT_PREINITIALIZED.",
886 string_VkImageLayout(pCreateInfo->initialLayout));
Dave Houlton130c0212018-01-29 13:39:56 -0700887 }
888
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600889 // If imageType is VK_IMAGE_TYPE_1D, both extent.height and extent.depth must be 1
Petr Kraus3ac9e812018-03-13 12:31:08 +0100890 if ((pCreateInfo->imageType == VK_IMAGE_TYPE_1D) &&
891 ((pCreateInfo->extent.height != 1) || (pCreateInfo->extent.depth != 1))) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600892 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -0600893 VALIDATION_ERROR_09e00778,
Dave Houltona9df0ce2018-02-07 10:51:23 -0700894 "vkCreateImage(): if pCreateInfo->imageType is VK_IMAGE_TYPE_1D, both pCreateInfo->extent.height and "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600895 "pCreateInfo->extent.depth must be 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600896 }
897
898 if (pCreateInfo->imageType == VK_IMAGE_TYPE_2D) {
Petr Kraus3f433212018-03-13 12:31:27 +0100899 if (pCreateInfo->flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) {
900 if (pCreateInfo->extent.width != pCreateInfo->extent.height) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600901 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -0600902 VK_NULL_HANDLE, VALIDATION_ERROR_09e00774,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600903 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT, but "
904 "pCreateInfo->extent.width (=%" PRIu32 ") and pCreateInfo->extent.height (=%" PRIu32
905 ") are not equal.",
906 pCreateInfo->extent.width, pCreateInfo->extent.height);
Petr Kraus3f433212018-03-13 12:31:27 +0100907 }
908
909 if (pCreateInfo->arrayLayers < 6) {
910 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -0600911 VK_NULL_HANDLE, VALIDATION_ERROR_09e00774,
Petr Kraus3f433212018-03-13 12:31:27 +0100912 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT, but "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600913 "pCreateInfo->arrayLayers (=%" PRIu32 ") is not greater than or equal to 6.",
914 pCreateInfo->arrayLayers);
Petr Kraus3f433212018-03-13 12:31:27 +0100915 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600916 }
917
918 if (pCreateInfo->extent.depth != 1) {
Mark Lobodzinski88529492018-04-01 10:38:15 -0600919 skip |=
920 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
921 VALIDATION_ERROR_09e0077a,
922 "vkCreateImage(): if pCreateInfo->imageType is VK_IMAGE_TYPE_2D, pCreateInfo->extent.depth must be 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600923 }
924 }
925
Dave Houlton130c0212018-01-29 13:39:56 -0700926 // 3D image may have only 1 layer
927 if ((pCreateInfo->imageType == VK_IMAGE_TYPE_3D) && (pCreateInfo->arrayLayers != 1)) {
Mark Lobodzinski88529492018-04-01 10:38:15 -0600928 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
929 VALIDATION_ERROR_09e00782,
930 "vkCreateImage(): if pCreateInfo->imageType is VK_IMAGE_TYPE_3D, pCreateInfo->arrayLayers must be 1.");
Dave Houlton130c0212018-01-29 13:39:56 -0700931 }
932
933 // If multi-sample, validate type, usage, tiling and mip levels.
934 if ((pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT) &&
935 ((pCreateInfo->imageType != VK_IMAGE_TYPE_2D) || (pCreateInfo->flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) ||
936 (pCreateInfo->tiling != VK_IMAGE_TILING_OPTIMAL) || (pCreateInfo->mipLevels != 1))) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600937 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -0600938 VALIDATION_ERROR_09e00784,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600939 "vkCreateImage(): Multi-sample image with incompatible type, usage, tiling, or mips.");
Dave Houlton130c0212018-01-29 13:39:56 -0700940 }
941
942 if (0 != (pCreateInfo->usage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT)) {
943 VkImageUsageFlags legal_flags = (VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT | VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT |
944 VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT);
945 // At least one of the legal attachment bits must be set
946 if (0 == (pCreateInfo->usage & legal_flags)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600947 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -0600948 VALIDATION_ERROR_09e0078c,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600949 "vkCreateImage(): Transient attachment image without a compatible attachment flag set.");
Dave Houlton130c0212018-01-29 13:39:56 -0700950 }
951 // No flags other than the legal attachment bits may be set
952 legal_flags |= VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT;
953 if (0 != (pCreateInfo->usage & ~legal_flags)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600954 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -0600955 VALIDATION_ERROR_09e00786,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600956 "vkCreateImage(): Transient attachment image with incompatible usage flags set.");
Dave Houlton130c0212018-01-29 13:39:56 -0700957 }
958 }
959
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600960 // mipLevels must be less than or equal to floor(log2(max(extent.width,extent.height,extent.depth)))+1
961 uint32_t maxDim = std::max(std::max(pCreateInfo->extent.width, pCreateInfo->extent.height), pCreateInfo->extent.depth);
Petr Krause5c37652018-01-05 04:05:12 +0100962 if (maxDim > 0 && pCreateInfo->mipLevels > (floor(log2(maxDim)) + 1)) {
Mark Lobodzinski88529492018-04-01 10:38:15 -0600963 skip |= log_msg(
964 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, VALIDATION_ERROR_09e0077c,
965 "vkCreateImage(): pCreateInfo->mipLevels must be less than or equal to "
966 "floor(log2(max(pCreateInfo->extent.width, pCreateInfo->extent.height, pCreateInfo->extent.depth)))+1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600967 }
968
Petr Krausb6f97802018-03-13 12:31:39 +0100969 if ((pCreateInfo->flags & VK_IMAGE_CREATE_SPARSE_BINDING_BIT) && (!device_data->physical_device_features.sparseBinding)) {
970 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, VK_NULL_HANDLE,
Mark Lobodzinski88529492018-04-01 10:38:15 -0600971 VALIDATION_ERROR_09e00792,
Petr Krausb6f97802018-03-13 12:31:39 +0100972 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_SPARSE_BINDING_BIT, but the "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600973 "VkPhysicalDeviceFeatures::sparseBinding feature is disabled.");
Petr Krausb6f97802018-03-13 12:31:39 +0100974 }
975
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600976 // If flags contains VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT or VK_IMAGE_CREATE_SPARSE_ALIASED_BIT, it must also contain
977 // VK_IMAGE_CREATE_SPARSE_BINDING_BIT
978 if (((pCreateInfo->flags & (VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT | VK_IMAGE_CREATE_SPARSE_ALIASED_BIT)) != 0) &&
979 ((pCreateInfo->flags & VK_IMAGE_CREATE_SPARSE_BINDING_BIT) != VK_IMAGE_CREATE_SPARSE_BINDING_BIT)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600980 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -0600981 VALIDATION_ERROR_09e007b6,
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600982 "vkCreateImage: if pCreateInfo->flags contains VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT or "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600983 "VK_IMAGE_CREATE_SPARSE_ALIASED_BIT, it must also contain VK_IMAGE_CREATE_SPARSE_BINDING_BIT.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600984 }
985
986 // Check for combinations of attributes that are incompatible with having VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT set
987 if ((pCreateInfo->flags & VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT) != 0) {
988 // Linear tiling is unsupported
989 if (VK_IMAGE_TILING_LINEAR == pCreateInfo->tiling) {
Mark Lobodzinski88529492018-04-01 10:38:15 -0600990 skip |=
991 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, INVALID_USAGE,
992 "vkCreateImage: if pCreateInfo->flags contains VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT then image "
993 "tiling of VK_IMAGE_TILING_LINEAR is not supported");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600994 }
995
996 // Sparse 1D image isn't valid
997 if (VK_IMAGE_TYPE_1D == pCreateInfo->imageType) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600998 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -0600999 VALIDATION_ERROR_09e00794,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001000 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 1D image.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001001 }
1002
1003 // Sparse 2D image when device doesn't support it
1004 if ((VK_FALSE == device_data->physical_device_features.sparseResidencyImage2D) &&
1005 (VK_IMAGE_TYPE_2D == pCreateInfo->imageType)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001006 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001007 VALIDATION_ERROR_09e00796,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001008 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 2D image if corresponding "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001009 "feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001010 }
1011
1012 // Sparse 3D image when device doesn't support it
1013 if ((VK_FALSE == device_data->physical_device_features.sparseResidencyImage3D) &&
1014 (VK_IMAGE_TYPE_3D == pCreateInfo->imageType)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001015 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001016 VALIDATION_ERROR_09e00798,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001017 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 3D image if corresponding "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001018 "feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001019 }
1020
1021 // Multi-sample 2D image when device doesn't support it
1022 if (VK_IMAGE_TYPE_2D == pCreateInfo->imageType) {
1023 if ((VK_FALSE == device_data->physical_device_features.sparseResidency2Samples) &&
1024 (VK_SAMPLE_COUNT_2_BIT == pCreateInfo->samples)) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07001025 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001026 VALIDATION_ERROR_09e0079a,
Dave Houltona9df0ce2018-02-07 10:51:23 -07001027 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 2-sample image if "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001028 "corresponding feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001029 } else if ((VK_FALSE == device_data->physical_device_features.sparseResidency4Samples) &&
1030 (VK_SAMPLE_COUNT_4_BIT == pCreateInfo->samples)) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07001031 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001032 VALIDATION_ERROR_09e0079c,
Dave Houltona9df0ce2018-02-07 10:51:23 -07001033 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 4-sample image if "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001034 "corresponding feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001035 } else if ((VK_FALSE == device_data->physical_device_features.sparseResidency8Samples) &&
1036 (VK_SAMPLE_COUNT_8_BIT == pCreateInfo->samples)) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07001037 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001038 VALIDATION_ERROR_09e0079e,
Dave Houltona9df0ce2018-02-07 10:51:23 -07001039 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 8-sample image if "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001040 "corresponding feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001041 } else if ((VK_FALSE == device_data->physical_device_features.sparseResidency16Samples) &&
1042 (VK_SAMPLE_COUNT_16_BIT == pCreateInfo->samples)) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07001043 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001044 VALIDATION_ERROR_09e007a0,
Dave Houltona9df0ce2018-02-07 10:51:23 -07001045 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 16-sample image if "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001046 "corresponding feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001047 }
1048 }
1049 }
1050 }
1051 return skip;
1052}
1053
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001054bool pv_vkCreateImageView(VkDevice device, const VkImageViewCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
1055 VkImageView *pView) {
1056 bool skip = false;
1057 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
1058 debug_report_data *report_data = device_data->report_data;
1059
1060 if (pCreateInfo != nullptr) {
1061 if ((pCreateInfo->viewType == VK_IMAGE_VIEW_TYPE_1D) || (pCreateInfo->viewType == VK_IMAGE_VIEW_TYPE_2D)) {
1062 if ((pCreateInfo->subresourceRange.layerCount != 1) &&
1063 (pCreateInfo->subresourceRange.layerCount != VK_REMAINING_ARRAY_LAYERS)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001064 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, 1,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001065
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001066 "vkCreateImageView: if pCreateInfo->viewType is VK_IMAGE_TYPE_%dD, "
1067 "pCreateInfo->subresourceRange.layerCount must be 1",
1068 ((pCreateInfo->viewType == VK_IMAGE_VIEW_TYPE_1D) ? 1 : 2));
1069 }
1070 } else if ((pCreateInfo->viewType == VK_IMAGE_VIEW_TYPE_1D_ARRAY) ||
1071 (pCreateInfo->viewType == VK_IMAGE_VIEW_TYPE_2D_ARRAY)) {
1072 if ((pCreateInfo->subresourceRange.layerCount < 1) &&
1073 (pCreateInfo->subresourceRange.layerCount != VK_REMAINING_ARRAY_LAYERS)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001074 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, 1,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001075
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001076 "vkCreateImageView: if pCreateInfo->viewType is VK_IMAGE_TYPE_%dD_ARRAY, "
1077 "pCreateInfo->subresourceRange.layerCount must be >= 1",
1078 ((pCreateInfo->viewType == VK_IMAGE_VIEW_TYPE_1D_ARRAY) ? 1 : 2));
1079 }
1080 } else if (pCreateInfo->viewType == VK_IMAGE_VIEW_TYPE_CUBE) {
1081 if ((pCreateInfo->subresourceRange.layerCount != 6) &&
1082 (pCreateInfo->subresourceRange.layerCount != VK_REMAINING_ARRAY_LAYERS)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001083 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, 1,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001084
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001085 "vkCreateImageView: if pCreateInfo->viewType is VK_IMAGE_TYPE_CUBE, "
1086 "pCreateInfo->subresourceRange.layerCount must be 6");
1087 }
1088 } else if (pCreateInfo->viewType == VK_IMAGE_VIEW_TYPE_CUBE_ARRAY) {
1089 if (((pCreateInfo->subresourceRange.layerCount == 0) || ((pCreateInfo->subresourceRange.layerCount % 6) != 0)) &&
1090 (pCreateInfo->subresourceRange.layerCount != VK_REMAINING_ARRAY_LAYERS)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001091 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, 1,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001092
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001093 "vkCreateImageView: if pCreateInfo->viewType is VK_IMAGE_TYPE_CUBE_ARRAY, "
1094 "pCreateInfo->subresourceRange.layerCount must be a multiple of 6");
1095 }
1096 if (!device_data->physical_device_features.imageCubeArray) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001097 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, 1,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001098 "vkCreateImageView: Device feature imageCubeArray not enabled.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001099 }
1100 } else if (pCreateInfo->viewType == VK_IMAGE_VIEW_TYPE_3D) {
1101 if (pCreateInfo->subresourceRange.baseArrayLayer != 0) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001102 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, 1,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001103
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001104 "vkCreateImageView: if pCreateInfo->viewType is VK_IMAGE_TYPE_3D, "
1105 "pCreateInfo->subresourceRange.baseArrayLayer must be 0");
1106 }
1107
1108 if ((pCreateInfo->subresourceRange.layerCount != 1) &&
1109 (pCreateInfo->subresourceRange.layerCount != VK_REMAINING_ARRAY_LAYERS)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001110 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, 1,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001111
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001112 "vkCreateImageView: if pCreateInfo->viewType is VK_IMAGE_TYPE_3D, "
1113 "pCreateInfo->subresourceRange.layerCount must be 1");
1114 }
1115 }
1116 }
1117 return skip;
1118}
1119
Petr Krausb3fcdb42018-01-09 22:09:09 +01001120bool pv_VkViewport(const layer_data *device_data, const VkViewport &viewport, const char *fn_name, const char *param_name,
1121 VkDebugReportObjectTypeEXT object_type, uint64_t object = 0) {
1122 bool skip = false;
1123 debug_report_data *report_data = device_data->report_data;
1124
1125 // Note: for numerical correctness
1126 // - float comparisons should expect NaN (comparison always false).
1127 // - VkPhysicalDeviceLimits::maxViewportDimensions is uint32_t, not float -> careful.
1128
1129 const auto f_lte_u32_exact = [](const float v1_f, const uint32_t v2_u32) {
John Zulaufac0876c2018-02-19 10:09:35 -07001130 if (std::isnan(v1_f)) return false;
Petr Krausb3fcdb42018-01-09 22:09:09 +01001131 if (v1_f <= 0.0f) return true;
1132
1133 float intpart;
1134 const float fract = modff(v1_f, &intpart);
1135
1136 assert(std::numeric_limits<float>::radix == 2);
1137 const float u32_max_plus1 = ldexpf(1.0f, 32); // hopefully exact
1138 if (intpart >= u32_max_plus1) return false;
1139
1140 uint32_t v1_u32 = static_cast<uint32_t>(intpart);
1141 if (v1_u32 < v2_u32)
1142 return true;
1143 else if (v1_u32 == v2_u32 && fract == 0.0f)
1144 return true;
1145 else
1146 return false;
1147 };
1148
1149 const auto f_lte_u32_direct = [](const float v1_f, const uint32_t v2_u32) {
1150 const float v2_f = static_cast<float>(v2_u32); // not accurate for > radix^digits; and undefined rounding mode
1151 return (v1_f <= v2_f);
1152 };
1153
1154 // width
1155 bool width_healthy = true;
1156 const auto max_w = device_data->device_limits.maxViewportDimensions[0];
1157
1158 if (!(viewport.width > 0.0f)) {
1159 width_healthy = false;
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001160 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, VALIDATION_ERROR_15000dd4,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001161 "%s: %s.width (=%f) is not greater than 0.0.", fn_name, param_name, viewport.width);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001162 } else if (!(f_lte_u32_exact(viewport.width, max_w) || f_lte_u32_direct(viewport.width, max_w))) {
1163 width_healthy = false;
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001164 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, VALIDATION_ERROR_15000dd6,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001165 "%s: %s.width (=%f) exceeds VkPhysicalDeviceLimits::maxViewportDimensions[0] (=%" PRIu32 ").", fn_name,
1166 param_name, viewport.width, max_w);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001167 } else if (!f_lte_u32_exact(viewport.width, max_w) && f_lte_u32_direct(viewport.width, max_w)) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06001168 skip |= log_msg(report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, object_type, object, NONE,
Petr Krausb3fcdb42018-01-09 22:09:09 +01001169 "%s: %s.width (=%f) technically exceeds VkPhysicalDeviceLimits::maxViewportDimensions[0] (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001170 "), but it is within the static_cast<float>(maxViewportDimensions[0]) limit.",
1171 fn_name, param_name, viewport.width, max_w);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001172 }
1173
1174 // height
1175 bool height_healthy = true;
Petr Krausaf9c1222018-03-10 02:39:47 +01001176 const bool negative_height_enabled = device_data->api_version >= VK_API_VERSION_1_1 ||
1177 device_data->extensions.vk_khr_maintenance1 ||
1178 device_data->extensions.vk_amd_negative_viewport_height;
Petr Krausb3fcdb42018-01-09 22:09:09 +01001179 const auto max_h = device_data->device_limits.maxViewportDimensions[1];
1180
1181 if (!negative_height_enabled && !(viewport.height > 0.0f)) {
1182 height_healthy = false;
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001183 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, VALIDATION_ERROR_15000dd8,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001184 "%s: %s.height (=%f) is not greater 0.0.", fn_name, param_name, viewport.height);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001185 } else if (!(f_lte_u32_exact(fabsf(viewport.height), max_h) || f_lte_u32_direct(fabsf(viewport.height), max_h))) {
1186 height_healthy = false;
1187
Mark Lobodzinski88529492018-04-01 10:38:15 -06001188 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, VALIDATION_ERROR_15000dda,
1189 "%s: Absolute value of %s.height (=%f) exceeds VkPhysicalDeviceLimits::maxViewportDimensions[1] (=%" PRIu32
1190 ").",
1191 fn_name, param_name, viewport.height, max_h);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001192 } else if (!f_lte_u32_exact(fabsf(viewport.height), max_h) && f_lte_u32_direct(fabsf(viewport.height), max_h)) {
1193 height_healthy = false;
1194
1195 skip |= log_msg(
Mark Lobodzinski88529492018-04-01 10:38:15 -06001196 report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, object_type, object, NONE,
Petr Krausb3fcdb42018-01-09 22:09:09 +01001197 "%s: Absolute value of %s.height (=%f) technically exceeds VkPhysicalDeviceLimits::maxViewportDimensions[1] (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001198 "), but it is within the static_cast<float>(maxViewportDimensions[1]) limit.",
1199 fn_name, param_name, viewport.height, max_h);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001200 }
1201
1202 // x
1203 bool x_healthy = true;
1204 if (!(viewport.x >= device_data->device_limits.viewportBoundsRange[0])) {
1205 x_healthy = false;
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001206 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, VALIDATION_ERROR_15000ddc,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001207 "%s: %s.x (=%f) is less than VkPhysicalDeviceLimits::viewportBoundsRange[0] (=%f).", fn_name, param_name,
1208 viewport.x, device_data->device_limits.viewportBoundsRange[0]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001209 }
1210
1211 // x + width
1212 if (x_healthy && width_healthy) {
1213 const float right_bound = viewport.x + viewport.width;
1214 if (!(right_bound <= device_data->device_limits.viewportBoundsRange[1])) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06001215 skip |=
1216 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, VALIDATION_ERROR_150009a0,
1217 "%s: %s.x + %s.width (=%f + %f = %f) is greater than VkPhysicalDeviceLimits::viewportBoundsRange[1] (=%f).",
1218 fn_name, param_name, param_name, viewport.x, viewport.width, right_bound,
1219 device_data->device_limits.viewportBoundsRange[1]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001220 }
1221 }
1222
1223 // y
1224 bool y_healthy = true;
1225 if (!(viewport.y >= device_data->device_limits.viewportBoundsRange[0])) {
1226 y_healthy = false;
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001227 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, VALIDATION_ERROR_15000dde,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001228 "%s: %s.y (=%f) is less than VkPhysicalDeviceLimits::viewportBoundsRange[0] (=%f).", fn_name, param_name,
1229 viewport.y, device_data->device_limits.viewportBoundsRange[0]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001230 } else if (negative_height_enabled && !(viewport.y <= device_data->device_limits.viewportBoundsRange[1])) {
1231 y_healthy = false;
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001232 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, VALIDATION_ERROR_15000de0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001233 "%s: %s.y (=%f) exceeds VkPhysicalDeviceLimits::viewportBoundsRange[1] (=%f).", fn_name, param_name,
1234 viewport.y, device_data->device_limits.viewportBoundsRange[1]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001235 }
1236
1237 // y + height
1238 if (y_healthy && height_healthy) {
1239 const float boundary = viewport.y + viewport.height;
1240
1241 if (!(boundary <= device_data->device_limits.viewportBoundsRange[1])) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06001242 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, VALIDATION_ERROR_150009a2,
1243 "%s: %s.y + %s.height (=%f + %f = %f) exceeds VkPhysicalDeviceLimits::viewportBoundsRange[1] (=%f).",
1244 fn_name, param_name, param_name, viewport.y, viewport.height, boundary,
1245 device_data->device_limits.viewportBoundsRange[1]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001246 } else if (negative_height_enabled && !(boundary >= device_data->device_limits.viewportBoundsRange[0])) {
1247 skip |= log_msg(
Mark Lobodzinski88529492018-04-01 10:38:15 -06001248 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, VALIDATION_ERROR_15000de2,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001249 "%s: %s.y + %s.height (=%f + %f = %f) is less than VkPhysicalDeviceLimits::viewportBoundsRange[0] (=%f).", fn_name,
1250 param_name, param_name, viewport.y, viewport.height, boundary, device_data->device_limits.viewportBoundsRange[0]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001251 }
1252 }
1253
1254 if (!device_data->extensions.vk_ext_depth_range_unrestricted) {
1255 // minDepth
1256 if (!(viewport.minDepth >= 0.0) || !(viewport.minDepth <= 1.0)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001257 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, VALIDATION_ERROR_150009a4,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001258
Petr Krausb3fcdb42018-01-09 22:09:09 +01001259 "%s: VK_EXT_depth_range_unrestricted extension is not enabled and %s.minDepth (=%f) is not within the "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001260 "[0.0, 1.0] range.",
1261 fn_name, param_name, viewport.minDepth);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001262 }
1263
1264 // maxDepth
1265 if (!(viewport.maxDepth >= 0.0) || !(viewport.maxDepth <= 1.0)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001266 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, VALIDATION_ERROR_150009a6,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001267
Petr Krausb3fcdb42018-01-09 22:09:09 +01001268 "%s: VK_EXT_depth_range_unrestricted extension is not enabled and %s.maxDepth (=%f) is not within the "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001269 "[0.0, 1.0] range.",
1270 fn_name, param_name, viewport.maxDepth);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001271 }
1272 }
1273
1274 return skip;
1275}
1276
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001277bool pv_vkCreateGraphicsPipelines(VkDevice device, VkPipelineCache pipelineCache, uint32_t createInfoCount,
1278 const VkGraphicsPipelineCreateInfo *pCreateInfos, const VkAllocationCallbacks *pAllocator,
1279 VkPipeline *pPipelines) {
1280 bool skip = false;
1281 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
1282 debug_report_data *report_data = device_data->report_data;
1283
1284 if (pCreateInfos != nullptr) {
1285 for (uint32_t i = 0; i < createInfoCount; ++i) {
Petr Kraus299ba622017-11-24 03:09:03 +01001286 bool has_dynamic_viewport = false;
1287 bool has_dynamic_scissor = false;
1288 bool has_dynamic_line_width = false;
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001289 bool has_dynamic_viewport_w_scaling_nv = false;
1290 bool has_dynamic_discard_rectangle_ext = false;
1291 bool has_dynamic_sample_locations_ext = false;
Petr Kraus299ba622017-11-24 03:09:03 +01001292 if (pCreateInfos[i].pDynamicState != nullptr) {
1293 const auto &dynamic_state_info = *pCreateInfos[i].pDynamicState;
1294 for (uint32_t state_index = 0; state_index < dynamic_state_info.dynamicStateCount; ++state_index) {
1295 const auto &dynamic_state = dynamic_state_info.pDynamicStates[state_index];
1296 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT) has_dynamic_viewport = true;
1297 if (dynamic_state == VK_DYNAMIC_STATE_SCISSOR) has_dynamic_scissor = true;
1298 if (dynamic_state == VK_DYNAMIC_STATE_LINE_WIDTH) has_dynamic_line_width = true;
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001299 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT_W_SCALING_NV) has_dynamic_viewport_w_scaling_nv = true;
1300 if (dynamic_state == VK_DYNAMIC_STATE_DISCARD_RECTANGLE_EXT) has_dynamic_discard_rectangle_ext = true;
1301 if (dynamic_state == VK_DYNAMIC_STATE_SAMPLE_LOCATIONS_EXT) has_dynamic_sample_locations_ext = true;
Petr Kraus299ba622017-11-24 03:09:03 +01001302 }
1303 }
1304
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001305 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
1306 if (pCreateInfos[i].pVertexInputState != nullptr) {
1307 auto const &vertex_input_state = pCreateInfos[i].pVertexInputState;
1308 for (uint32_t d = 0; d < vertex_input_state->vertexBindingDescriptionCount; ++d) {
1309 auto const &vertex_bind_desc = vertex_input_state->pVertexBindingDescriptions[d];
1310 if (vertex_bind_desc.binding >= device_data->device_limits.maxVertexInputBindings) {
1311 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001312 VALIDATION_ERROR_14c004d4,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001313 "vkCreateGraphicsPipelines: parameter "
1314 "pCreateInfos[%u].pVertexInputState->pVertexBindingDescriptions[%u].binding (%u) is "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001315 "greater than or equal to VkPhysicalDeviceLimits::maxVertexInputBindings (%u).",
1316 i, d, vertex_bind_desc.binding, device_data->device_limits.maxVertexInputBindings);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001317 }
1318
1319 if (vertex_bind_desc.stride > device_data->device_limits.maxVertexInputBindingStride) {
1320 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001321 VALIDATION_ERROR_14c004d6,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001322 "vkCreateGraphicsPipelines: parameter "
1323 "pCreateInfos[%u].pVertexInputState->pVertexBindingDescriptions[%u].stride (%u) is greater "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001324 "than VkPhysicalDeviceLimits::maxVertexInputBindingStride (%u).",
1325 i, d, vertex_bind_desc.stride, device_data->device_limits.maxVertexInputBindingStride);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001326 }
1327 }
1328
1329 for (uint32_t d = 0; d < vertex_input_state->vertexAttributeDescriptionCount; ++d) {
1330 auto const &vertex_attrib_desc = vertex_input_state->pVertexAttributeDescriptions[d];
1331 if (vertex_attrib_desc.location >= device_data->device_limits.maxVertexInputAttributes) {
1332 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001333 VALIDATION_ERROR_14a004d8,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001334 "vkCreateGraphicsPipelines: parameter "
1335 "pCreateInfos[%u].pVertexInputState->pVertexAttributeDescriptions[%u].location (%u) is "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001336 "greater than or equal to VkPhysicalDeviceLimits::maxVertexInputAttributes (%u).",
1337 i, d, vertex_attrib_desc.location, device_data->device_limits.maxVertexInputAttributes);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001338 }
1339
1340 if (vertex_attrib_desc.binding >= device_data->device_limits.maxVertexInputBindings) {
1341 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001342 VALIDATION_ERROR_14a004da,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001343 "vkCreateGraphicsPipelines: parameter "
1344 "pCreateInfos[%u].pVertexInputState->pVertexAttributeDescriptions[%u].binding (%u) is "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001345 "greater than or equal to VkPhysicalDeviceLimits::maxVertexInputBindings (%u).",
1346 i, d, vertex_attrib_desc.binding, device_data->device_limits.maxVertexInputBindings);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001347 }
1348
1349 if (vertex_attrib_desc.offset > device_data->device_limits.maxVertexInputAttributeOffset) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06001350 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1351 VALIDATION_ERROR_14a004dc,
1352 "vkCreateGraphicsPipelines: parameter "
1353 "pCreateInfos[%u].pVertexInputState->pVertexAttributeDescriptions[%u].offset (%u) is "
1354 "greater than VkPhysicalDeviceLimits::maxVertexInputAttributeOffset (%u).",
1355 i, d, vertex_attrib_desc.offset, device_data->device_limits.maxVertexInputAttributeOffset);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001356 }
1357 }
1358 }
1359
1360 if (pCreateInfos[i].pStages != nullptr) {
1361 bool has_control = false;
1362 bool has_eval = false;
1363
1364 for (uint32_t stage_index = 0; stage_index < pCreateInfos[i].stageCount; ++stage_index) {
1365 if (pCreateInfos[i].pStages[stage_index].stage == VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) {
1366 has_control = true;
1367 } else if (pCreateInfos[i].pStages[stage_index].stage == VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT) {
1368 has_eval = true;
1369 }
1370 }
1371
1372 // pTessellationState is ignored without both tessellation control and tessellation evaluation shaders stages
1373 if (has_control && has_eval) {
1374 if (pCreateInfos[i].pTessellationState == nullptr) {
1375 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001376 VALIDATION_ERROR_096005b6,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001377 "vkCreateGraphicsPipelines: if pCreateInfos[%d].pStages includes a tessellation control "
1378 "shader stage and a tessellation evaluation shader stage, "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001379 "pCreateInfos[%d].pTessellationState must not be NULL.",
1380 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001381 } else {
1382 skip |= validate_struct_pnext(
1383 report_data, "vkCreateGraphicsPipelines",
1384 ParameterName("pCreateInfos[%i].pTessellationState->pNext", ParameterName::IndexVector{i}), NULL,
1385 pCreateInfos[i].pTessellationState->pNext, 0, NULL, GeneratedHeaderVersion, VALIDATION_ERROR_0961c40d);
1386
1387 skip |= validate_reserved_flags(
1388 report_data, "vkCreateGraphicsPipelines",
1389 ParameterName("pCreateInfos[%i].pTessellationState->flags", ParameterName::IndexVector{i}),
1390 pCreateInfos[i].pTessellationState->flags, VALIDATION_ERROR_10809005);
1391
1392 if (pCreateInfos[i].pTessellationState->sType !=
1393 VK_STRUCTURE_TYPE_PIPELINE_TESSELLATION_STATE_CREATE_INFO) {
1394 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001395 VALIDATION_ERROR_1082b00b,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001396 "vkCreateGraphicsPipelines: parameter pCreateInfos[%d].pTessellationState->sType must "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001397 "be VK_STRUCTURE_TYPE_PIPELINE_TESSELLATION_STATE_CREATE_INFO.",
1398 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001399 }
1400
1401 if (pCreateInfos[i].pTessellationState->patchControlPoints == 0 ||
1402 pCreateInfos[i].pTessellationState->patchControlPoints >
1403 device_data->device_limits.maxTessellationPatchSize) {
1404 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001405 VALIDATION_ERROR_1080097c,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001406 "vkCreateGraphicsPipelines: invalid parameter "
1407 "pCreateInfos[%d].pTessellationState->patchControlPoints value %u. patchControlPoints "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001408 "should be >0 and <=%u.",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001409 i, pCreateInfos[i].pTessellationState->patchControlPoints,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001410 device_data->device_limits.maxTessellationPatchSize);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001411 }
1412 }
1413 }
1414 }
1415
1416 // pViewportState, pMultisampleState, pDepthStencilState, and pColorBlendState ignored when rasterization is disabled
1417 if ((pCreateInfos[i].pRasterizationState != nullptr) &&
1418 (pCreateInfos[i].pRasterizationState->rasterizerDiscardEnable == VK_FALSE)) {
1419 if (pCreateInfos[i].pViewportState == nullptr) {
Petr Krausa6103552017-11-16 21:21:58 +01001420 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001421 VK_NULL_HANDLE, VALIDATION_ERROR_096005dc,
Petr Krausa6103552017-11-16 21:21:58 +01001422 "vkCreateGraphicsPipelines: Rasterization is enabled (pCreateInfos[%" PRIu32
1423 "].pRasterizationState->rasterizerDiscardEnable is VK_FALSE), but pCreateInfos[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001424 "].pViewportState (=NULL) is not a valid pointer.",
1425 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001426 } else {
Petr Krausa6103552017-11-16 21:21:58 +01001427 const auto &viewport_state = *pCreateInfos[i].pViewportState;
1428
1429 if (viewport_state.sType != VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_STATE_CREATE_INFO) {
1430 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001431 VK_NULL_HANDLE, VALIDATION_ERROR_10c2b00b,
Petr Krausa6103552017-11-16 21:21:58 +01001432 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001433 "].pViewportState->sType is not VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_STATE_CREATE_INFO.",
1434 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001435 }
1436
Petr Krausa6103552017-11-16 21:21:58 +01001437 const VkStructureType allowed_structs_VkPipelineViewportStateCreateInfo[] = {
1438 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_SWIZZLE_STATE_CREATE_INFO_NV,
1439 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_W_SCALING_STATE_CREATE_INFO_NV};
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001440 skip |= validate_struct_pnext(
1441 report_data, "vkCreateGraphicsPipelines",
Petr Krausa6103552017-11-16 21:21:58 +01001442 ParameterName("pCreateInfos[%i].pViewportState->pNext", ParameterName::IndexVector{i}),
1443 "VkPipelineViewportSwizzleStateCreateInfoNV, VkPipelineViewportWScalingStateCreateInfoNV",
1444 viewport_state.pNext, ARRAY_SIZE(allowed_structs_VkPipelineViewportStateCreateInfo),
1445 allowed_structs_VkPipelineViewportStateCreateInfo, 65, VALIDATION_ERROR_10c1c40d);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001446
1447 skip |= validate_reserved_flags(
1448 report_data, "vkCreateGraphicsPipelines",
1449 ParameterName("pCreateInfos[%i].pViewportState->flags", ParameterName::IndexVector{i}),
Petr Krausa6103552017-11-16 21:21:58 +01001450 viewport_state.flags, VALIDATION_ERROR_10c09005);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001451
Petr Krausa6103552017-11-16 21:21:58 +01001452 if (!device_data->physical_device_features.multiViewport) {
1453 if (viewport_state.viewportCount != 1) {
1454 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001455 VK_NULL_HANDLE, VALIDATION_ERROR_10c00980,
Petr Krausa6103552017-11-16 21:21:58 +01001456 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
1457 "disabled, but pCreateInfos[%" PRIu32 "].pViewportState->viewportCount (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001458 ") is not 1.",
1459 i, viewport_state.viewportCount);
Petr Krausa6103552017-11-16 21:21:58 +01001460 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001461
Petr Krausa6103552017-11-16 21:21:58 +01001462 if (viewport_state.scissorCount != 1) {
1463 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001464 VK_NULL_HANDLE, VALIDATION_ERROR_10c00982,
Petr Krausa6103552017-11-16 21:21:58 +01001465 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
1466 "disabled, but pCreateInfos[%" PRIu32 "].pViewportState->scissorCount (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001467 ") is not 1.",
1468 i, viewport_state.scissorCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001469 }
Petr Krausa6103552017-11-16 21:21:58 +01001470 } else { // multiViewport enabled
1471 if (viewport_state.viewportCount == 0) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001472 skip |= log_msg(
1473 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001474 VK_NULL_HANDLE, VALIDATION_ERROR_10c30a1b,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001475 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "].pViewportState->viewportCount is 0.", i);
Petr Krausa6103552017-11-16 21:21:58 +01001476 } else if (viewport_state.viewportCount > device_data->device_limits.maxViewports) {
1477 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001478 VK_NULL_HANDLE, VALIDATION_ERROR_10c00984,
Petr Krausa6103552017-11-16 21:21:58 +01001479 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1480 "].pViewportState->viewportCount (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001481 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
1482 i, viewport_state.viewportCount, device_data->device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001483 }
Petr Krausa6103552017-11-16 21:21:58 +01001484
1485 if (viewport_state.scissorCount == 0) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001486 skip |= log_msg(
1487 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001488 VK_NULL_HANDLE, VALIDATION_ERROR_10c2b61b,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001489 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "].pViewportState->scissorCount is 0.", i);
Petr Krausa6103552017-11-16 21:21:58 +01001490 } else if (viewport_state.scissorCount > device_data->device_limits.maxViewports) {
1491 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001492 VK_NULL_HANDLE, VALIDATION_ERROR_10c00986,
Petr Krausa6103552017-11-16 21:21:58 +01001493 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1494 "].pViewportState->scissorCount (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001495 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
1496 i, viewport_state.scissorCount, device_data->device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001497 }
1498 }
1499
Petr Krausa6103552017-11-16 21:21:58 +01001500 if (viewport_state.scissorCount != viewport_state.viewportCount) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001501 skip |=
1502 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001503 VK_NULL_HANDLE, VALIDATION_ERROR_10c00988,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001504 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "].pViewportState->scissorCount (=%" PRIu32
1505 ") is not identical to pCreateInfos[%" PRIu32 "].pViewportState->viewportCount (=%" PRIu32 ").",
1506 i, viewport_state.scissorCount, i, viewport_state.viewportCount);
Petr Krausa6103552017-11-16 21:21:58 +01001507 }
1508
Petr Krausa6103552017-11-16 21:21:58 +01001509 if (!has_dynamic_viewport && viewport_state.viewportCount > 0 && viewport_state.pViewports == nullptr) {
1510 skip |= log_msg(
1511 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, VK_NULL_HANDLE,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001512 VALIDATION_ERROR_096005d6,
Petr Krausa6103552017-11-16 21:21:58 +01001513 "vkCreateGraphicsPipelines: The viewport state is static (pCreateInfos[%" PRIu32
1514 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_VIEWPORT), but pCreateInfos[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001515 "].pViewportState->pViewports (=NULL) is an invalid pointer.",
1516 i, i);
Petr Krausa6103552017-11-16 21:21:58 +01001517 }
1518
1519 if (!has_dynamic_scissor && viewport_state.scissorCount > 0 && viewport_state.pScissors == nullptr) {
1520 skip |= log_msg(
1521 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, VK_NULL_HANDLE,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001522 VALIDATION_ERROR_096005d8,
Petr Krausa6103552017-11-16 21:21:58 +01001523 "vkCreateGraphicsPipelines: The scissor state is static (pCreateInfos[%" PRIu32
1524 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_SCISSOR), but pCreateInfos[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001525 "].pViewportState->pScissors (=NULL) is an invalid pointer.",
1526 i, i);
Petr Krausa6103552017-11-16 21:21:58 +01001527 }
1528
Petr Krausb3fcdb42018-01-09 22:09:09 +01001529 // validate the VkViewports
1530 if (!has_dynamic_viewport && viewport_state.pViewports) {
1531 for (uint32_t viewport_i = 0; viewport_i < viewport_state.viewportCount; ++viewport_i) {
1532 const auto &viewport = viewport_state.pViewports[viewport_i]; // will crash on invalid ptr
1533 const char fn_name[] = "vkCreateGraphicsPipelines";
1534 const std::string param_name = "pCreateInfos[" + std::to_string(i) + "].pViewportState->pViewports[" +
1535 std::to_string(viewport_i) + "]";
1536 skip |= pv_VkViewport(device_data, viewport, fn_name, param_name.c_str(),
1537 VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT);
1538 }
1539 }
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001540
1541 if (has_dynamic_viewport_w_scaling_nv && !device_data->extensions.vk_nv_clip_space_w_scaling) {
1542 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001543 VK_NULL_HANDLE, EXTENSION_NOT_ENABLED,
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001544 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
Dave Houltona9df0ce2018-02-07 10:51:23 -07001545 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_VIEWPORT_W_SCALING_NV, but "
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001546 "VK_NV_clip_space_w_scaling extension is not enabled.",
1547 i);
1548 }
1549
1550 if (has_dynamic_discard_rectangle_ext && !device_data->extensions.vk_ext_discard_rectangles) {
1551 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001552 VK_NULL_HANDLE, EXTENSION_NOT_ENABLED,
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001553 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
Dave Houltona9df0ce2018-02-07 10:51:23 -07001554 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_DISCARD_RECTANGLE_EXT, but "
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001555 "VK_EXT_discard_rectangles extension is not enabled.",
1556 i);
1557 }
1558
1559 if (has_dynamic_sample_locations_ext && !device_data->extensions.vk_ext_sample_locations) {
1560 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001561 VK_NULL_HANDLE, EXTENSION_NOT_ENABLED,
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001562 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
Dave Houltona9df0ce2018-02-07 10:51:23 -07001563 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_SAMPLE_LOCATIONS_EXT, but "
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001564 "VK_EXT_sample_locations extension is not enabled.",
1565 i);
1566 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001567 }
1568
1569 if (pCreateInfos[i].pMultisampleState == nullptr) {
1570 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001571 VALIDATION_ERROR_096005de,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001572 "vkCreateGraphicsPipelines: if pCreateInfos[%d].pRasterizationState->rasterizerDiscardEnable "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001573 "is VK_FALSE, pCreateInfos[%d].pMultisampleState must not be NULL.",
1574 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001575 } else {
Dave Houltonb3bbec72018-01-17 10:13:33 -07001576 const VkStructureType valid_next_stypes[] = {LvlTypeMap<VkPipelineCoverageModulationStateCreateInfoNV>::kSType,
1577 LvlTypeMap<VkPipelineCoverageToColorStateCreateInfoNV>::kSType,
1578 LvlTypeMap<VkPipelineSampleLocationsStateCreateInfoEXT>::kSType};
Mike Schuchardt97662b02017-12-06 13:31:29 -07001579 const char *valid_struct_names =
Dave Houltona9df0ce2018-02-07 10:51:23 -07001580 "VkPipelineCoverageModulationStateCreateInfoNV, VkPipelineCoverageToColorStateCreateInfoNV, "
John Zulauf96b0e422017-11-14 11:43:19 -07001581 "VkPipelineSampleLocationsStateCreateInfoEXT";
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001582 skip |= validate_struct_pnext(
1583 report_data, "vkCreateGraphicsPipelines",
John Zulauf96b0e422017-11-14 11:43:19 -07001584 ParameterName("pCreateInfos[%i].pMultisampleState->pNext", ParameterName::IndexVector{i}),
1585 valid_struct_names, pCreateInfos[i].pMultisampleState->pNext, 3, valid_next_stypes, GeneratedHeaderVersion,
1586 VALIDATION_ERROR_1001c40d);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001587
1588 skip |= validate_reserved_flags(
1589 report_data, "vkCreateGraphicsPipelines",
1590 ParameterName("pCreateInfos[%i].pMultisampleState->flags", ParameterName::IndexVector{i}),
1591 pCreateInfos[i].pMultisampleState->flags, VALIDATION_ERROR_10009005);
1592
1593 skip |= validate_bool32(
1594 report_data, "vkCreateGraphicsPipelines",
1595 ParameterName("pCreateInfos[%i].pMultisampleState->sampleShadingEnable", ParameterName::IndexVector{i}),
1596 pCreateInfos[i].pMultisampleState->sampleShadingEnable);
1597
1598 skip |= validate_array(
1599 report_data, "vkCreateGraphicsPipelines",
1600 ParameterName("pCreateInfos[%i].pMultisampleState->rasterizationSamples", ParameterName::IndexVector{i}),
1601 ParameterName("pCreateInfos[%i].pMultisampleState->pSampleMask", ParameterName::IndexVector{i}),
1602 pCreateInfos[i].pMultisampleState->rasterizationSamples, pCreateInfos[i].pMultisampleState->pSampleMask,
1603 true, false, VALIDATION_ERROR_UNDEFINED, VALIDATION_ERROR_UNDEFINED);
1604
1605 skip |= validate_bool32(
1606 report_data, "vkCreateGraphicsPipelines",
1607 ParameterName("pCreateInfos[%i].pMultisampleState->alphaToCoverageEnable", ParameterName::IndexVector{i}),
1608 pCreateInfos[i].pMultisampleState->alphaToCoverageEnable);
1609
1610 skip |= validate_bool32(
1611 report_data, "vkCreateGraphicsPipelines",
1612 ParameterName("pCreateInfos[%i].pMultisampleState->alphaToOneEnable", ParameterName::IndexVector{i}),
1613 pCreateInfos[i].pMultisampleState->alphaToOneEnable);
1614
1615 if (pCreateInfos[i].pMultisampleState->sType != VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO) {
1616 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001617 INVALID_STRUCT_STYPE,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001618 "vkCreateGraphicsPipelines: parameter pCreateInfos[%d].pMultisampleState->sType must be "
1619 "VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO",
1620 i);
1621 }
John Zulauf7acac592017-11-06 11:15:53 -07001622 if (pCreateInfos[i].pMultisampleState->sampleShadingEnable == VK_TRUE) {
1623 if (!device_data->physical_device_features.sampleRateShading) {
1624 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001625 VALIDATION_ERROR_10000620,
John Zulauf7acac592017-11-06 11:15:53 -07001626 "vkCreateGraphicsPipelines(): parameter "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001627 "pCreateInfos[%d].pMultisampleState->sampleShadingEnable.",
1628 i);
John Zulauf7acac592017-11-06 11:15:53 -07001629 }
1630 // TODO Add documentation issue about when minSampleShading must be in range and when it is ignored
1631 // For now a "least noise" test *only* when sampleShadingEnable is VK_TRUE.
1632 if (!in_inclusive_range(pCreateInfos[i].pMultisampleState->minSampleShading, 0.F, 1.0F)) {
1633 skip |= log_msg(
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001634 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001635 VALIDATION_ERROR_10000624,
1636 "vkCreateGraphicsPipelines(): parameter pCreateInfos[%d].pMultisampleState->minSampleShading.", i);
John Zulauf7acac592017-11-06 11:15:53 -07001637 }
1638 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001639 }
1640
Petr Krause91f7a12017-12-14 20:57:36 +01001641 bool uses_color_attachment = false;
1642 bool uses_depthstencil_attachment = false;
1643 {
1644 const auto subpasses_uses_it = device_data->renderpasses_states.find(pCreateInfos[i].renderPass);
1645 if (subpasses_uses_it != device_data->renderpasses_states.end()) {
1646 const auto &subpasses_uses = subpasses_uses_it->second;
1647 if (subpasses_uses.subpasses_using_color_attachment.count(pCreateInfos[i].subpass))
1648 uses_color_attachment = true;
1649 if (subpasses_uses.subpasses_using_depthstencil_attachment.count(pCreateInfos[i].subpass))
1650 uses_depthstencil_attachment = true;
1651 }
1652 }
1653
1654 if (pCreateInfos[i].pDepthStencilState != nullptr && uses_depthstencil_attachment) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001655 skip |= validate_struct_pnext(
1656 report_data, "vkCreateGraphicsPipelines",
1657 ParameterName("pCreateInfos[%i].pDepthStencilState->pNext", ParameterName::IndexVector{i}), NULL,
1658 pCreateInfos[i].pDepthStencilState->pNext, 0, NULL, GeneratedHeaderVersion, VALIDATION_ERROR_0f61c40d);
1659
1660 skip |= validate_reserved_flags(
1661 report_data, "vkCreateGraphicsPipelines",
1662 ParameterName("pCreateInfos[%i].pDepthStencilState->flags", ParameterName::IndexVector{i}),
1663 pCreateInfos[i].pDepthStencilState->flags, VALIDATION_ERROR_0f609005);
1664
1665 skip |= validate_bool32(
1666 report_data, "vkCreateGraphicsPipelines",
1667 ParameterName("pCreateInfos[%i].pDepthStencilState->depthTestEnable", ParameterName::IndexVector{i}),
1668 pCreateInfos[i].pDepthStencilState->depthTestEnable);
1669
1670 skip |= validate_bool32(
1671 report_data, "vkCreateGraphicsPipelines",
1672 ParameterName("pCreateInfos[%i].pDepthStencilState->depthWriteEnable", ParameterName::IndexVector{i}),
1673 pCreateInfos[i].pDepthStencilState->depthWriteEnable);
1674
1675 skip |= validate_ranged_enum(
1676 report_data, "vkCreateGraphicsPipelines",
1677 ParameterName("pCreateInfos[%i].pDepthStencilState->depthCompareOp", ParameterName::IndexVector{i}),
1678 "VkCompareOp", AllVkCompareOpEnums, pCreateInfos[i].pDepthStencilState->depthCompareOp,
1679 VALIDATION_ERROR_0f604001);
1680
1681 skip |= validate_bool32(
1682 report_data, "vkCreateGraphicsPipelines",
1683 ParameterName("pCreateInfos[%i].pDepthStencilState->depthBoundsTestEnable", ParameterName::IndexVector{i}),
1684 pCreateInfos[i].pDepthStencilState->depthBoundsTestEnable);
1685
1686 skip |= validate_bool32(
1687 report_data, "vkCreateGraphicsPipelines",
1688 ParameterName("pCreateInfos[%i].pDepthStencilState->stencilTestEnable", ParameterName::IndexVector{i}),
1689 pCreateInfos[i].pDepthStencilState->stencilTestEnable);
1690
1691 skip |= validate_ranged_enum(
1692 report_data, "vkCreateGraphicsPipelines",
1693 ParameterName("pCreateInfos[%i].pDepthStencilState->front.failOp", ParameterName::IndexVector{i}),
1694 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->front.failOp,
1695 VALIDATION_ERROR_13a08601);
1696
1697 skip |= validate_ranged_enum(
1698 report_data, "vkCreateGraphicsPipelines",
1699 ParameterName("pCreateInfos[%i].pDepthStencilState->front.passOp", ParameterName::IndexVector{i}),
1700 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->front.passOp,
1701 VALIDATION_ERROR_13a27801);
1702
1703 skip |= validate_ranged_enum(
1704 report_data, "vkCreateGraphicsPipelines",
1705 ParameterName("pCreateInfos[%i].pDepthStencilState->front.depthFailOp", ParameterName::IndexVector{i}),
1706 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->front.depthFailOp,
1707 VALIDATION_ERROR_13a04201);
1708
1709 skip |= validate_ranged_enum(
1710 report_data, "vkCreateGraphicsPipelines",
1711 ParameterName("pCreateInfos[%i].pDepthStencilState->front.compareOp", ParameterName::IndexVector{i}),
1712 "VkCompareOp", AllVkCompareOpEnums, pCreateInfos[i].pDepthStencilState->front.compareOp,
1713 VALIDATION_ERROR_0f604001);
1714
1715 skip |= validate_ranged_enum(
1716 report_data, "vkCreateGraphicsPipelines",
1717 ParameterName("pCreateInfos[%i].pDepthStencilState->back.failOp", ParameterName::IndexVector{i}),
1718 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->back.failOp,
1719 VALIDATION_ERROR_13a08601);
1720
1721 skip |= validate_ranged_enum(
1722 report_data, "vkCreateGraphicsPipelines",
1723 ParameterName("pCreateInfos[%i].pDepthStencilState->back.passOp", ParameterName::IndexVector{i}),
1724 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->back.passOp,
1725 VALIDATION_ERROR_13a27801);
1726
1727 skip |= validate_ranged_enum(
1728 report_data, "vkCreateGraphicsPipelines",
1729 ParameterName("pCreateInfos[%i].pDepthStencilState->back.depthFailOp", ParameterName::IndexVector{i}),
1730 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->back.depthFailOp,
1731 VALIDATION_ERROR_13a04201);
1732
1733 skip |= validate_ranged_enum(
1734 report_data, "vkCreateGraphicsPipelines",
1735 ParameterName("pCreateInfos[%i].pDepthStencilState->back.compareOp", ParameterName::IndexVector{i}),
1736 "VkCompareOp", AllVkCompareOpEnums, pCreateInfos[i].pDepthStencilState->back.compareOp,
1737 VALIDATION_ERROR_0f604001);
1738
1739 if (pCreateInfos[i].pDepthStencilState->sType != VK_STRUCTURE_TYPE_PIPELINE_DEPTH_STENCIL_STATE_CREATE_INFO) {
1740 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001741 INVALID_STRUCT_STYPE,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001742 "vkCreateGraphicsPipelines: parameter pCreateInfos[%d].pDepthStencilState->sType must be "
1743 "VK_STRUCTURE_TYPE_PIPELINE_DEPTH_STENCIL_STATE_CREATE_INFO",
1744 i);
1745 }
1746 }
1747
Petr Krause91f7a12017-12-14 20:57:36 +01001748 if (pCreateInfos[i].pColorBlendState != nullptr && uses_color_attachment) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001749 skip |= validate_struct_pnext(
1750 report_data, "vkCreateGraphicsPipelines",
1751 ParameterName("pCreateInfos[%i].pColorBlendState->pNext", ParameterName::IndexVector{i}), NULL,
1752 pCreateInfos[i].pColorBlendState->pNext, 0, NULL, GeneratedHeaderVersion, VALIDATION_ERROR_0f41c40d);
1753
1754 skip |= validate_reserved_flags(
1755 report_data, "vkCreateGraphicsPipelines",
1756 ParameterName("pCreateInfos[%i].pColorBlendState->flags", ParameterName::IndexVector{i}),
1757 pCreateInfos[i].pColorBlendState->flags, VALIDATION_ERROR_0f409005);
1758
1759 skip |= validate_bool32(
1760 report_data, "vkCreateGraphicsPipelines",
1761 ParameterName("pCreateInfos[%i].pColorBlendState->logicOpEnable", ParameterName::IndexVector{i}),
1762 pCreateInfos[i].pColorBlendState->logicOpEnable);
1763
1764 skip |= validate_array(
1765 report_data, "vkCreateGraphicsPipelines",
1766 ParameterName("pCreateInfos[%i].pColorBlendState->attachmentCount", ParameterName::IndexVector{i}),
1767 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments", ParameterName::IndexVector{i}),
1768 pCreateInfos[i].pColorBlendState->attachmentCount, pCreateInfos[i].pColorBlendState->pAttachments, false,
1769 true, VALIDATION_ERROR_UNDEFINED, VALIDATION_ERROR_UNDEFINED);
1770
1771 if (pCreateInfos[i].pColorBlendState->pAttachments != NULL) {
1772 for (uint32_t attachmentIndex = 0; attachmentIndex < pCreateInfos[i].pColorBlendState->attachmentCount;
1773 ++attachmentIndex) {
1774 skip |= validate_bool32(report_data, "vkCreateGraphicsPipelines",
1775 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].blendEnable",
1776 ParameterName::IndexVector{i, attachmentIndex}),
1777 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].blendEnable);
1778
1779 skip |= validate_ranged_enum(
1780 report_data, "vkCreateGraphicsPipelines",
1781 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].srcColorBlendFactor",
1782 ParameterName::IndexVector{i, attachmentIndex}),
1783 "VkBlendFactor", AllVkBlendFactorEnums,
1784 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].srcColorBlendFactor,
1785 VALIDATION_ERROR_0f22cc01);
1786
1787 skip |= validate_ranged_enum(
1788 report_data, "vkCreateGraphicsPipelines",
1789 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].dstColorBlendFactor",
1790 ParameterName::IndexVector{i, attachmentIndex}),
1791 "VkBlendFactor", AllVkBlendFactorEnums,
1792 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].dstColorBlendFactor,
1793 VALIDATION_ERROR_0f207001);
1794
1795 skip |= validate_ranged_enum(
1796 report_data, "vkCreateGraphicsPipelines",
1797 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].colorBlendOp",
1798 ParameterName::IndexVector{i, attachmentIndex}),
1799 "VkBlendOp", AllVkBlendOpEnums,
1800 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].colorBlendOp,
1801 VALIDATION_ERROR_0f202001);
1802
1803 skip |= validate_ranged_enum(
1804 report_data, "vkCreateGraphicsPipelines",
1805 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].srcAlphaBlendFactor",
1806 ParameterName::IndexVector{i, attachmentIndex}),
1807 "VkBlendFactor", AllVkBlendFactorEnums,
1808 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].srcAlphaBlendFactor,
1809 VALIDATION_ERROR_0f22c601);
1810
1811 skip |= validate_ranged_enum(
1812 report_data, "vkCreateGraphicsPipelines",
1813 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].dstAlphaBlendFactor",
1814 ParameterName::IndexVector{i, attachmentIndex}),
1815 "VkBlendFactor", AllVkBlendFactorEnums,
1816 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].dstAlphaBlendFactor,
1817 VALIDATION_ERROR_0f206a01);
1818
1819 skip |= validate_ranged_enum(
1820 report_data, "vkCreateGraphicsPipelines",
1821 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].alphaBlendOp",
1822 ParameterName::IndexVector{i, attachmentIndex}),
1823 "VkBlendOp", AllVkBlendOpEnums,
1824 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].alphaBlendOp,
1825 VALIDATION_ERROR_0f200801);
1826
1827 skip |=
1828 validate_flags(report_data, "vkCreateGraphicsPipelines",
1829 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].colorWriteMask",
1830 ParameterName::IndexVector{i, attachmentIndex}),
1831 "VkColorComponentFlagBits", AllVkColorComponentFlagBits,
1832 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].colorWriteMask,
1833 false, false, VALIDATION_ERROR_0f202201);
1834 }
1835 }
1836
1837 if (pCreateInfos[i].pColorBlendState->sType != VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO) {
1838 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001839 INVALID_STRUCT_STYPE,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001840 "vkCreateGraphicsPipelines: parameter pCreateInfos[%d].pColorBlendState->sType must be "
1841 "VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO",
1842 i);
1843 }
1844
1845 // If logicOpEnable is VK_TRUE, logicOp must be a valid VkLogicOp value
1846 if (pCreateInfos[i].pColorBlendState->logicOpEnable == VK_TRUE) {
1847 skip |= validate_ranged_enum(
1848 report_data, "vkCreateGraphicsPipelines",
1849 ParameterName("pCreateInfos[%i].pColorBlendState->logicOp", ParameterName::IndexVector{i}), "VkLogicOp",
1850 AllVkLogicOpEnums, pCreateInfos[i].pColorBlendState->logicOp, VALIDATION_ERROR_0f4004be);
1851 }
1852 }
1853 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001854
Petr Kraus9752aae2017-11-24 03:05:50 +01001855 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_DERIVATIVE_BIT) {
1856 if (pCreateInfos[i].basePipelineIndex != -1) {
1857 if (pCreateInfos[i].basePipelineHandle != VK_NULL_HANDLE) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07001858 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001859 VALIDATION_ERROR_096005a8,
Dave Houltona9df0ce2018-02-07 10:51:23 -07001860 "vkCreateGraphicsPipelines parameter, pCreateInfos->basePipelineHandle, must be "
1861 "VK_NULL_HANDLE if pCreateInfos->flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT flag "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001862 "and pCreateInfos->basePipelineIndex is not -1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001863 }
1864 }
1865
Petr Kraus9752aae2017-11-24 03:05:50 +01001866 if (pCreateInfos[i].basePipelineHandle != VK_NULL_HANDLE) {
1867 if (pCreateInfos[i].basePipelineIndex != -1) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07001868 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001869 VALIDATION_ERROR_096005aa,
Dave Houltona9df0ce2018-02-07 10:51:23 -07001870 "vkCreateGraphicsPipelines parameter, pCreateInfos->basePipelineIndex, must be -1 if "
1871 "pCreateInfos->flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT flag and "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001872 "pCreateInfos->basePipelineHandle is not VK_NULL_HANDLE.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001873 }
1874 }
1875 }
1876
Petr Kraus9752aae2017-11-24 03:05:50 +01001877 if (pCreateInfos[i].pRasterizationState) {
1878 if ((pCreateInfos[i].pRasterizationState->polygonMode != VK_POLYGON_MODE_FILL) &&
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001879 (device_data->physical_device_features.fillModeNonSolid == false)) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07001880 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001881 DEVICE_FEATURE,
Dave Houltona9df0ce2018-02-07 10:51:23 -07001882 "vkCreateGraphicsPipelines parameter, VkPolygonMode "
1883 "pCreateInfos->pRasterizationState->polygonMode cannot be VK_POLYGON_MODE_POINT or "
1884 "VK_POLYGON_MODE_LINE if VkPhysicalDeviceFeatures->fillModeNonSolid is false.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001885 }
Petr Kraus299ba622017-11-24 03:09:03 +01001886
1887 if (!has_dynamic_line_width && !device_data->physical_device_features.wideLines &&
1888 (pCreateInfos[i].pRasterizationState->lineWidth != 1.0f)) {
1889 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001890 VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, 0, VALIDATION_ERROR_096005da,
Petr Kraus299ba622017-11-24 03:09:03 +01001891 "The line width state is static (pCreateInfos[%" PRIu32
1892 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_LINE_WIDTH) and "
1893 "VkPhysicalDeviceFeatures::wideLines is disabled, but pCreateInfos[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001894 "].pRasterizationState->lineWidth (=%f) is not 1.0.",
1895 i, i, pCreateInfos[i].pRasterizationState->lineWidth);
Petr Kraus299ba622017-11-24 03:09:03 +01001896 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001897 }
1898
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001899 for (size_t j = 0; j < pCreateInfos[i].stageCount; j++) {
1900 skip |= validate_string(device_data->report_data, "vkCreateGraphicsPipelines",
1901 ParameterName("pCreateInfos[%i].pStages[%i].pName", ParameterName::IndexVector{i, j}),
1902 pCreateInfos[i].pStages[j].pName);
1903 }
1904 }
1905 }
1906
1907 return skip;
1908}
1909
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001910bool pv_vkCreateComputePipelines(VkDevice device, VkPipelineCache pipelineCache, uint32_t createInfoCount,
1911 const VkComputePipelineCreateInfo *pCreateInfos, const VkAllocationCallbacks *pAllocator,
1912 VkPipeline *pPipelines) {
1913 bool skip = false;
1914 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
1915
1916 for (uint32_t i = 0; i < createInfoCount; i++) {
1917 skip |= validate_string(device_data->report_data, "vkCreateComputePipelines",
1918 ParameterName("pCreateInfos[%i].stage.pName", ParameterName::IndexVector{i}),
1919 pCreateInfos[i].stage.pName);
1920 }
1921
1922 return skip;
1923}
1924
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001925bool pv_vkCreateSampler(VkDevice device, const VkSamplerCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
1926 VkSampler *pSampler) {
1927 bool skip = false;
1928 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
1929 debug_report_data *report_data = device_data->report_data;
1930
1931 if (pCreateInfo != nullptr) {
John Zulauf71968502017-10-26 13:51:15 -06001932 const auto &features = device_data->physical_device_features;
1933 const auto &limits = device_data->device_limits;
1934 if (pCreateInfo->anisotropyEnable == VK_TRUE) {
1935 if (!in_inclusive_range(pCreateInfo->maxAnisotropy, 1.0F, limits.maxSamplerAnisotropy)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001936 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001937 VALIDATION_ERROR_1260085e,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001938 "vkCreateSampler(): value of %s must be in range [1.0, %f] %s, but %f found.",
John Zulauf71968502017-10-26 13:51:15 -06001939 "pCreateInfo->maxAnisotropy", limits.maxSamplerAnisotropy,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001940 "VkPhysicalDeviceLimits::maxSamplerAnistropy", pCreateInfo->maxAnisotropy);
John Zulauf71968502017-10-26 13:51:15 -06001941 }
1942
1943 // Anistropy cannot be enabled in sampler unless enabled as a feature
1944 if (features.samplerAnisotropy == VK_FALSE) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001945 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001946 VALIDATION_ERROR_1260085c,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001947 "vkCreateSampler(): Anisotropic sampling feature is not enabled, %s must be VK_FALSE.",
1948 "pCreateInfo->anisotropyEnable");
John Zulauf71968502017-10-26 13:51:15 -06001949 }
1950
1951 // Anistropy and unnormalized coordinates cannot be enabled simultaneously
1952 if (pCreateInfo->unnormalizedCoordinates == VK_TRUE) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001953 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001954 VALIDATION_ERROR_12600868,
Dave Houltona9df0ce2018-02-07 10:51:23 -07001955 "vkCreateSampler(): pCreateInfo->anisotropyEnable and pCreateInfo->unnormalizedCoordinates must "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001956 "not both be VK_TRUE.");
John Zulauf71968502017-10-26 13:51:15 -06001957 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001958 }
1959
1960 // If compareEnable is VK_TRUE, compareOp must be a valid VkCompareOp value
1961 if (pCreateInfo->compareEnable == VK_TRUE) {
1962 skip |= validate_ranged_enum(report_data, "vkCreateSampler", "pCreateInfo->compareOp", "VkCompareOp",
1963 AllVkCompareOpEnums, pCreateInfo->compareOp, VALIDATION_ERROR_12600870);
1964 }
1965
1966 // If any of addressModeU, addressModeV or addressModeW are VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER, borderColor must be a
1967 // valid VkBorderColor value
1968 if ((pCreateInfo->addressModeU == VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER) ||
1969 (pCreateInfo->addressModeV == VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER) ||
1970 (pCreateInfo->addressModeW == VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER)) {
1971 skip |= validate_ranged_enum(report_data, "vkCreateSampler", "pCreateInfo->borderColor", "VkBorderColor",
1972 AllVkBorderColorEnums, pCreateInfo->borderColor, VALIDATION_ERROR_1260086c);
1973 }
1974
1975 // If any of addressModeU, addressModeV or addressModeW are VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE, the
1976 // VK_KHR_sampler_mirror_clamp_to_edge extension must be enabled
1977 if (!device_data->extensions.vk_khr_sampler_mirror_clamp_to_edge &&
1978 ((pCreateInfo->addressModeU == VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE) ||
1979 (pCreateInfo->addressModeV == VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE) ||
1980 (pCreateInfo->addressModeW == VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE))) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06001981 skip |= log_msg(
1982 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, VALIDATION_ERROR_1260086e,
1983 "vkCreateSampler(): A VkSamplerAddressMode value is set to VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE "
1984 "but the VK_KHR_sampler_mirror_clamp_to_edge extension has not been enabled.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001985 }
John Zulauf275805c2017-10-26 15:34:49 -06001986
1987 // Checks for the IMG cubic filtering extension
1988 if (device_data->extensions.vk_img_filter_cubic) {
1989 if ((pCreateInfo->anisotropyEnable == VK_TRUE) &&
1990 ((pCreateInfo->minFilter == VK_FILTER_CUBIC_IMG) || (pCreateInfo->magFilter == VK_FILTER_CUBIC_IMG))) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001991 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001992 VALIDATION_ERROR_12600872,
Dave Houltona9df0ce2018-02-07 10:51:23 -07001993 "vkCreateSampler(): Anisotropic sampling must not be VK_TRUE when either minFilter or magFilter "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001994 "are VK_FILTER_CUBIC_IMG.");
John Zulauf275805c2017-10-26 15:34:49 -06001995 }
1996 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001997 }
1998
1999 return skip;
2000}
2001
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002002bool pv_vkCreateDescriptorSetLayout(VkDevice device, const VkDescriptorSetLayoutCreateInfo *pCreateInfo,
2003 const VkAllocationCallbacks *pAllocator, VkDescriptorSetLayout *pSetLayout) {
2004 bool skip = false;
2005 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2006 debug_report_data *report_data = device_data->report_data;
2007
2008 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
2009 if ((pCreateInfo != nullptr) && (pCreateInfo->pBindings != nullptr)) {
2010 for (uint32_t i = 0; i < pCreateInfo->bindingCount; ++i) {
2011 if (pCreateInfo->pBindings[i].descriptorCount != 0) {
2012 // If descriptorType is VK_DESCRIPTOR_TYPE_SAMPLER or VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER, and descriptorCount
2013 // is not 0 and pImmutableSamplers is not NULL, pImmutableSamplers must be a pointer to an array of descriptorCount
2014 // valid VkSampler handles
2015 if (((pCreateInfo->pBindings[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLER) ||
2016 (pCreateInfo->pBindings[i].descriptorType == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER)) &&
2017 (pCreateInfo->pBindings[i].pImmutableSamplers != nullptr)) {
2018 for (uint32_t descriptor_index = 0; descriptor_index < pCreateInfo->pBindings[i].descriptorCount;
2019 ++descriptor_index) {
2020 if (pCreateInfo->pBindings[i].pImmutableSamplers[descriptor_index] == VK_NULL_HANDLE) {
2021 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002022 REQUIRED_PARAMETER,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002023 "vkCreateDescriptorSetLayout: required parameter "
Dave Houltona9df0ce2018-02-07 10:51:23 -07002024 "pCreateInfo->pBindings[%d].pImmutableSamplers[%d] specified as VK_NULL_HANDLE",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002025 i, descriptor_index);
2026 }
2027 }
2028 }
2029
2030 // If descriptorCount is not 0, stageFlags must be a valid combination of VkShaderStageFlagBits values
2031 if ((pCreateInfo->pBindings[i].stageFlags != 0) &&
2032 ((pCreateInfo->pBindings[i].stageFlags & (~AllVkShaderStageFlagBits)) != 0)) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07002033 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002034 VALIDATION_ERROR_04e00236,
Dave Houltona9df0ce2018-02-07 10:51:23 -07002035 "vkCreateDescriptorSetLayout(): if pCreateInfo->pBindings[%d].descriptorCount is not 0, "
2036 "pCreateInfo->pBindings[%d].stageFlags must be a valid combination of VkShaderStageFlagBits "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002037 "values.",
2038 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002039 }
2040 }
2041 }
2042 }
2043
2044 return skip;
2045}
2046
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002047bool pv_vkFreeDescriptorSets(VkDevice device, VkDescriptorPool descriptorPool, uint32_t descriptorSetCount,
2048 const VkDescriptorSet *pDescriptorSets) {
2049 bool skip = false;
2050 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2051 debug_report_data *report_data = device_data->report_data;
2052
2053 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
2054 // This is an array of handles, where the elements are allowed to be VK_NULL_HANDLE, and does not require any validation beyond
2055 // validate_array()
2056 skip |= validate_array(report_data, "vkFreeDescriptorSets", "descriptorSetCount", "pDescriptorSets", descriptorSetCount,
2057 pDescriptorSets, true, true, VALIDATION_ERROR_UNDEFINED, VALIDATION_ERROR_UNDEFINED);
2058 return skip;
2059}
2060
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002061bool pv_vkUpdateDescriptorSets(VkDevice device, uint32_t descriptorWriteCount, const VkWriteDescriptorSet *pDescriptorWrites,
2062 uint32_t descriptorCopyCount, const VkCopyDescriptorSet *pDescriptorCopies) {
2063 bool skip = false;
2064 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2065 debug_report_data *report_data = device_data->report_data;
2066
2067 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
2068 if (pDescriptorWrites != NULL) {
2069 for (uint32_t i = 0; i < descriptorWriteCount; ++i) {
2070 // descriptorCount must be greater than 0
2071 if (pDescriptorWrites[i].descriptorCount == 0) {
2072 skip |=
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002073 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002074 VALIDATION_ERROR_15c0441b,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002075 "vkUpdateDescriptorSets(): parameter pDescriptorWrites[%d].descriptorCount must be greater than 0.", i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002076 }
2077
2078 // dstSet must be a valid VkDescriptorSet handle
2079 skip |= validate_required_handle(report_data, "vkUpdateDescriptorSets",
2080 ParameterName("pDescriptorWrites[%i].dstSet", ParameterName::IndexVector{i}),
2081 pDescriptorWrites[i].dstSet);
2082
2083 if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLER) ||
2084 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER) ||
2085 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE) ||
2086 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_IMAGE) ||
2087 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT)) {
2088 // If descriptorType is VK_DESCRIPTOR_TYPE_SAMPLER, VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER,
2089 // VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE, VK_DESCRIPTOR_TYPE_STORAGE_IMAGE or VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT,
2090 // pImageInfo must be a pointer to an array of descriptorCount valid VkDescriptorImageInfo structures
2091 if (pDescriptorWrites[i].pImageInfo == nullptr) {
2092 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002093 VALIDATION_ERROR_15c00284,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002094 "vkUpdateDescriptorSets(): if pDescriptorWrites[%d].descriptorType is "
2095 "VK_DESCRIPTOR_TYPE_SAMPLER, VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER, "
2096 "VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE, VK_DESCRIPTOR_TYPE_STORAGE_IMAGE or "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002097 "VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT, pDescriptorWrites[%d].pImageInfo must not be NULL.",
2098 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002099 } else if (pDescriptorWrites[i].descriptorType != VK_DESCRIPTOR_TYPE_SAMPLER) {
2100 // If descriptorType is VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER, VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE,
2101 // VK_DESCRIPTOR_TYPE_STORAGE_IMAGE or VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT, the imageView and imageLayout
2102 // members of any given element of pImageInfo must be a valid VkImageView and VkImageLayout, respectively
2103 for (uint32_t descriptor_index = 0; descriptor_index < pDescriptorWrites[i].descriptorCount;
2104 ++descriptor_index) {
2105 skip |= validate_required_handle(report_data, "vkUpdateDescriptorSets",
2106 ParameterName("pDescriptorWrites[%i].pImageInfo[%i].imageView",
2107 ParameterName::IndexVector{i, descriptor_index}),
2108 pDescriptorWrites[i].pImageInfo[descriptor_index].imageView);
2109 skip |= validate_ranged_enum(report_data, "vkUpdateDescriptorSets",
2110 ParameterName("pDescriptorWrites[%i].pImageInfo[%i].imageLayout",
2111 ParameterName::IndexVector{i, descriptor_index}),
2112 "VkImageLayout", AllVkImageLayoutEnums,
2113 pDescriptorWrites[i].pImageInfo[descriptor_index].imageLayout,
2114 VALIDATION_ERROR_UNDEFINED);
2115 }
2116 }
2117 } else if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER) ||
2118 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER) ||
2119 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC) ||
2120 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC)) {
2121 // If descriptorType is VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER, VK_DESCRIPTOR_TYPE_STORAGE_BUFFER,
2122 // VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC or VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC, pBufferInfo must be a
2123 // pointer to an array of descriptorCount valid VkDescriptorBufferInfo structures
2124 if (pDescriptorWrites[i].pBufferInfo == nullptr) {
2125 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002126 VALIDATION_ERROR_15c00288,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002127 "vkUpdateDescriptorSets(): if pDescriptorWrites[%d].descriptorType is "
2128 "VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER, VK_DESCRIPTOR_TYPE_STORAGE_BUFFER, "
2129 "VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC or VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC, "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002130 "pDescriptorWrites[%d].pBufferInfo must not be NULL.",
2131 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002132 } else {
2133 for (uint32_t descriptorIndex = 0; descriptorIndex < pDescriptorWrites[i].descriptorCount; ++descriptorIndex) {
2134 skip |= validate_required_handle(report_data, "vkUpdateDescriptorSets",
2135 ParameterName("pDescriptorWrites[%i].pBufferInfo[%i].buffer",
2136 ParameterName::IndexVector{i, descriptorIndex}),
2137 pDescriptorWrites[i].pBufferInfo[descriptorIndex].buffer);
2138 }
2139 }
2140 } else if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER) ||
2141 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER)) {
2142 // If descriptorType is VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER or VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER,
2143 // pTexelBufferView must be a pointer to an array of descriptorCount valid VkBufferView handles
2144 if (pDescriptorWrites[i].pTexelBufferView == nullptr) {
2145 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002146 VALIDATION_ERROR_15c00286,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002147 "vkUpdateDescriptorSets(): if pDescriptorWrites[%d].descriptorType is "
2148 "VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER or VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER, "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002149 "pDescriptorWrites[%d].pTexelBufferView must not be NULL.",
2150 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002151 } else {
2152 for (uint32_t descriptor_index = 0; descriptor_index < pDescriptorWrites[i].descriptorCount;
2153 ++descriptor_index) {
2154 skip |= validate_required_handle(report_data, "vkUpdateDescriptorSets",
2155 ParameterName("pDescriptorWrites[%i].pTexelBufferView[%i]",
2156 ParameterName::IndexVector{i, descriptor_index}),
2157 pDescriptorWrites[i].pTexelBufferView[descriptor_index]);
2158 }
2159 }
2160 }
2161
2162 if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER) ||
2163 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC)) {
2164 VkDeviceSize uniformAlignment = device_data->device_limits.minUniformBufferOffsetAlignment;
2165 for (uint32_t j = 0; j < pDescriptorWrites[i].descriptorCount; j++) {
2166 if (pDescriptorWrites[i].pBufferInfo != NULL) {
2167 if (SafeModulo(pDescriptorWrites[i].pBufferInfo[j].offset, uniformAlignment) != 0) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06002168 skip |=
2169 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT,
2170 VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, VALIDATION_ERROR_15c0028e,
2171 "vkUpdateDescriptorSets(): pDescriptorWrites[%d].pBufferInfo[%d].offset (0x%" PRIxLEAST64
2172 ") must be a multiple of device limit minUniformBufferOffsetAlignment 0x%" PRIxLEAST64 ".",
2173 i, j, pDescriptorWrites[i].pBufferInfo[j].offset, uniformAlignment);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002174 }
2175 }
2176 }
2177 } else if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER) ||
2178 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC)) {
2179 VkDeviceSize storageAlignment = device_data->device_limits.minStorageBufferOffsetAlignment;
2180 for (uint32_t j = 0; j < pDescriptorWrites[i].descriptorCount; j++) {
2181 if (pDescriptorWrites[i].pBufferInfo != NULL) {
2182 if (SafeModulo(pDescriptorWrites[i].pBufferInfo[j].offset, storageAlignment) != 0) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06002183 skip |=
2184 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT,
2185 VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, VALIDATION_ERROR_15c00290,
2186 "vkUpdateDescriptorSets(): pDescriptorWrites[%d].pBufferInfo[%d].offset (0x%" PRIxLEAST64
2187 ") must be a multiple of device limit minStorageBufferOffsetAlignment 0x%" PRIxLEAST64 ".",
2188 i, j, pDescriptorWrites[i].pBufferInfo[j].offset, storageAlignment);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002189 }
2190 }
2191 }
2192 }
2193 }
2194 }
2195 return skip;
2196}
2197
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002198bool pv_vkCreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
2199 VkRenderPass *pRenderPass) {
2200 bool skip = false;
2201 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2202 uint32_t max_color_attachments = device_data->device_limits.maxColorAttachments;
2203
2204 for (uint32_t i = 0; i < pCreateInfo->attachmentCount; ++i) {
2205 if (pCreateInfo->pAttachments[i].format == VK_FORMAT_UNDEFINED) {
2206 std::stringstream ss;
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002207 ss << "vkCreateRenderPass: pCreateInfo->pAttachments[" << i << "].format is VK_FORMAT_UNDEFINED. ";
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002208 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002209 VALIDATION_ERROR_00809201, "%s", ss.str().c_str());
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002210 }
2211 if (pCreateInfo->pAttachments[i].finalLayout == VK_IMAGE_LAYOUT_UNDEFINED ||
2212 pCreateInfo->pAttachments[i].finalLayout == VK_IMAGE_LAYOUT_PREINITIALIZED) {
2213 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002214 VALIDATION_ERROR_00800696,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002215 "pCreateInfo->pAttachments[%d].finalLayout must not be VK_IMAGE_LAYOUT_UNDEFINED or "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002216 "VK_IMAGE_LAYOUT_PREINITIALIZED.",
2217 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002218 }
2219 }
2220
2221 for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) {
2222 if (pCreateInfo->pSubpasses[i].colorAttachmentCount > max_color_attachments) {
2223 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002224 VALIDATION_ERROR_1400069a, "Cannot create a render pass with %d color attachments. Max is %d.",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002225 pCreateInfo->pSubpasses[i].colorAttachmentCount, max_color_attachments);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002226 }
2227 }
2228 return skip;
2229}
2230
2231bool pv_vkFreeCommandBuffers(VkDevice device, VkCommandPool commandPool, uint32_t commandBufferCount,
2232 const VkCommandBuffer *pCommandBuffers) {
2233 bool skip = false;
2234 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2235 debug_report_data *report_data = device_data->report_data;
2236
2237 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
2238 // This is an array of handles, where the elements are allowed to be VK_NULL_HANDLE, and does not require any validation beyond
2239 // validate_array()
2240 skip |= validate_array(report_data, "vkFreeCommandBuffers", "commandBufferCount", "pCommandBuffers", commandBufferCount,
2241 pCommandBuffers, true, true, VALIDATION_ERROR_UNDEFINED, VALIDATION_ERROR_UNDEFINED);
2242 return skip;
2243}
2244
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002245bool pv_vkBeginCommandBuffer(VkCommandBuffer commandBuffer, const VkCommandBufferBeginInfo *pBeginInfo) {
2246 bool skip = false;
2247 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2248 debug_report_data *report_data = device_data->report_data;
2249 const VkCommandBufferInheritanceInfo *pInfo = pBeginInfo->pInheritanceInfo;
2250
2251 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
2252 // TODO: pBeginInfo->pInheritanceInfo must not be NULL if commandBuffer is a secondary command buffer
2253 skip |= validate_struct_type(report_data, "vkBeginCommandBuffer", "pBeginInfo->pInheritanceInfo",
2254 "VK_STRUCTURE_TYPE_COMMAND_BUFFER_INHERITANCE_INFO", pBeginInfo->pInheritanceInfo,
2255 VK_STRUCTURE_TYPE_COMMAND_BUFFER_INHERITANCE_INFO, false, VALIDATION_ERROR_UNDEFINED);
2256
2257 if (pBeginInfo->pInheritanceInfo != NULL) {
2258 skip |=
2259 validate_struct_pnext(report_data, "vkBeginCommandBuffer", "pBeginInfo->pInheritanceInfo->pNext", NULL,
2260 pBeginInfo->pInheritanceInfo->pNext, 0, NULL, GeneratedHeaderVersion, VALIDATION_ERROR_0281c40d);
2261
2262 skip |= validate_bool32(report_data, "vkBeginCommandBuffer", "pBeginInfo->pInheritanceInfo->occlusionQueryEnable",
2263 pBeginInfo->pInheritanceInfo->occlusionQueryEnable);
2264
2265 // TODO: This only needs to be validated when the inherited queries feature is enabled
2266 // skip |= validate_flags(report_data, "vkBeginCommandBuffer", "pBeginInfo->pInheritanceInfo->queryFlags",
2267 // "VkQueryControlFlagBits", AllVkQueryControlFlagBits, pBeginInfo->pInheritanceInfo->queryFlags, false);
2268
2269 // TODO: This must be 0 if the pipeline statistics queries feature is not enabled
2270 skip |= validate_flags(report_data, "vkBeginCommandBuffer", "pBeginInfo->pInheritanceInfo->pipelineStatistics",
2271 "VkQueryPipelineStatisticFlagBits", AllVkQueryPipelineStatisticFlagBits,
2272 pBeginInfo->pInheritanceInfo->pipelineStatistics, false, false, VALIDATION_ERROR_UNDEFINED);
2273 }
2274
2275 if (pInfo != NULL) {
2276 if ((device_data->physical_device_features.inheritedQueries == VK_FALSE) && (pInfo->occlusionQueryEnable != VK_FALSE)) {
2277 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002278 HandleToUint64(commandBuffer), VALIDATION_ERROR_02a00070,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002279 "Cannot set inherited occlusionQueryEnable in vkBeginCommandBuffer() when device does not support "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002280 "inheritedQueries.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002281 }
2282 if ((device_data->physical_device_features.inheritedQueries != VK_FALSE) && (pInfo->occlusionQueryEnable != VK_FALSE)) {
2283 skip |= validate_flags(device_data->report_data, "vkBeginCommandBuffer", "pBeginInfo->pInheritanceInfo->queryFlags",
2284 "VkQueryControlFlagBits", AllVkQueryControlFlagBits, pInfo->queryFlags, false, false,
2285 VALIDATION_ERROR_02a00072);
2286 }
2287 }
2288
2289 return skip;
2290}
2291
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002292bool pv_vkCmdSetViewport(VkCommandBuffer commandBuffer, uint32_t firstViewport, uint32_t viewportCount,
2293 const VkViewport *pViewports) {
2294 bool skip = false;
2295 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2296
Petr Krausd55e77c2018-01-09 22:09:25 +01002297 if (!device_data->physical_device_features.multiViewport) {
2298 if (firstViewport != 0) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002299 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002300 HandleToUint64(commandBuffer), VALIDATION_ERROR_1e000990,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002301 "vkCmdSetViewport: The multiViewport feature is disabled, but firstViewport (=%" PRIu32 ") is not 0.",
2302 firstViewport);
Petr Krausd55e77c2018-01-09 22:09:25 +01002303 }
2304 if (viewportCount > 1) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002305 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002306 HandleToUint64(commandBuffer), VALIDATION_ERROR_1e000992,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002307 "vkCmdSetViewport: The multiViewport feature is disabled, but viewportCount (=%" PRIu32 ") is not 1.",
2308 viewportCount);
Petr Krausd55e77c2018-01-09 22:09:25 +01002309 }
2310 } else { // multiViewport enabled
Petr Kraus7dfeed12018-02-27 20:51:20 +01002311 const uint64_t sum = static_cast<uint64_t>(firstViewport) + static_cast<uint64_t>(viewportCount);
Petr Krausd55e77c2018-01-09 22:09:25 +01002312 if (sum > device_data->device_limits.maxViewports) {
2313 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002314 HandleToUint64(commandBuffer), VALIDATION_ERROR_1e00098e,
Petr Krausd55e77c2018-01-09 22:09:25 +01002315 "vkCmdSetViewport: firstViewport + viewportCount (=%" PRIu32 " + %" PRIu32 " = %" PRIu64
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002316 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
2317 firstViewport, viewportCount, sum, device_data->device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002318 }
2319 }
Petr Krausb3fcdb42018-01-09 22:09:09 +01002320
2321 if (pViewports) {
2322 for (uint32_t viewport_i = 0; viewport_i < viewportCount; ++viewport_i) {
2323 const auto &viewport = pViewports[viewport_i]; // will crash on invalid ptr
2324 const char fn_name[] = "vkCmdSetViewport";
2325 const std::string param_name = "pViewports[" + std::to_string(viewport_i) + "]";
2326 skip |= pv_VkViewport(device_data, viewport, fn_name, param_name.c_str(),
2327 VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, HandleToUint64(commandBuffer));
2328 }
2329 }
2330
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002331 return skip;
2332}
2333
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002334bool pv_vkCmdSetScissor(VkCommandBuffer commandBuffer, uint32_t firstScissor, uint32_t scissorCount, const VkRect2D *pScissors) {
2335 bool skip = false;
2336 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2337 debug_report_data *report_data = device_data->report_data;
2338
Petr Kraus6260f0a2018-02-27 21:15:55 +01002339 if (!device_data->physical_device_features.multiViewport) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002340 if (firstScissor != 0) {
Petr Kraus6260f0a2018-02-27 21:15:55 +01002341 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002342 HandleToUint64(commandBuffer), VALIDATION_ERROR_1d8004a2,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002343 "vkCmdSetScissor: The multiViewport feature is disabled, but firstScissor (=%" PRIu32 ") is not 0.",
2344 firstScissor);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002345 }
2346 if (scissorCount > 1) {
2347 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002348 HandleToUint64(commandBuffer), VALIDATION_ERROR_1d8004a4,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002349 "vkCmdSetScissor: The multiViewport feature is disabled, but scissorCount (=%" PRIu32 ") is not 1.",
2350 scissorCount);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002351 }
2352 } else { // multiViewport enabled
2353 const uint64_t sum = static_cast<uint64_t>(firstScissor) + static_cast<uint64_t>(scissorCount);
2354 if (sum > device_data->device_limits.maxViewports) {
2355 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002356 HandleToUint64(commandBuffer), VALIDATION_ERROR_1d8004a0,
Petr Kraus6260f0a2018-02-27 21:15:55 +01002357 "vkCmdSetScissor: firstScissor + scissorCount (=%" PRIu32 " + %" PRIu32 " = %" PRIu64
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002358 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
2359 firstScissor, scissorCount, sum, device_data->device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002360 }
2361 }
2362
Petr Kraus6260f0a2018-02-27 21:15:55 +01002363 if (pScissors) {
2364 for (uint32_t scissor_i = 0; scissor_i < scissorCount; ++scissor_i) {
2365 const auto &scissor = pScissors[scissor_i]; // will crash on invalid ptr
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002366
Petr Kraus6260f0a2018-02-27 21:15:55 +01002367 if (scissor.offset.x < 0) {
2368 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002369 HandleToUint64(commandBuffer), VALIDATION_ERROR_1d8004a6,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002370 "vkCmdSetScissor: pScissors[%" PRIu32 "].offset.x (=%" PRIi32 ") is negative.", scissor_i,
2371 scissor.offset.x);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002372 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002373
Petr Kraus6260f0a2018-02-27 21:15:55 +01002374 if (scissor.offset.y < 0) {
2375 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002376 HandleToUint64(commandBuffer), VALIDATION_ERROR_1d8004a6,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002377 "vkCmdSetScissor: pScissors[%" PRIu32 "].offset.y (=%" PRIi32 ") is negative.", scissor_i,
2378 scissor.offset.y);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002379 }
2380
2381 const int64_t x_sum = static_cast<int64_t>(scissor.offset.x) + static_cast<int64_t>(scissor.extent.width);
2382 if (x_sum > INT32_MAX) {
2383 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002384 HandleToUint64(commandBuffer), VALIDATION_ERROR_1d8004a8,
Petr Kraus6260f0a2018-02-27 21:15:55 +01002385 "vkCmdSetScissor: offset.x + extent.width (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002386 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
2387 scissor.offset.x, scissor.extent.width, x_sum, scissor_i);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002388 }
2389
2390 const int64_t y_sum = static_cast<int64_t>(scissor.offset.y) + static_cast<int64_t>(scissor.extent.height);
2391 if (y_sum > INT32_MAX) {
2392 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002393 HandleToUint64(commandBuffer), VALIDATION_ERROR_1d8004aa,
Petr Kraus6260f0a2018-02-27 21:15:55 +01002394 "vkCmdSetScissor: offset.y + extent.height (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002395 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
2396 scissor.offset.y, scissor.extent.height, y_sum, scissor_i);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002397 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002398 }
2399 }
Petr Kraus6260f0a2018-02-27 21:15:55 +01002400
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002401 return skip;
2402}
2403
Petr Kraus299ba622017-11-24 03:09:03 +01002404bool pv_vkCmdSetLineWidth(VkCommandBuffer commandBuffer, float lineWidth) {
2405 bool skip = false;
2406 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2407 debug_report_data *report_data = device_data->report_data;
2408
2409 if (!device_data->physical_device_features.wideLines && (lineWidth != 1.0f)) {
2410 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002411 HandleToUint64(commandBuffer), VALIDATION_ERROR_1d600628,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002412 "VkPhysicalDeviceFeatures::wideLines is disabled, but lineWidth (=%f) is not 1.0.", lineWidth);
Petr Kraus299ba622017-11-24 03:09:03 +01002413 }
2414
2415 return skip;
2416}
2417
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002418bool pv_vkCmdDraw(VkCommandBuffer commandBuffer, uint32_t vertexCount, uint32_t instanceCount, uint32_t firstVertex,
2419 uint32_t firstInstance) {
2420 bool skip = false;
2421 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2422 if (vertexCount == 0) {
2423 // TODO: Verify against Valid Usage section. I don't see a non-zero vertexCount listed, may need to add that and make
2424 // this an error or leave as is.
2425 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002426 REQUIRED_PARAMETER, "vkCmdDraw parameter, uint32_t vertexCount, is 0");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002427 }
2428
2429 if (instanceCount == 0) {
2430 // TODO: Verify against Valid Usage section. I don't see a non-zero instanceCount listed, may need to add that and make
2431 // this an error or leave as is.
2432 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002433 REQUIRED_PARAMETER, "vkCmdDraw parameter, uint32_t instanceCount, is 0");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002434 }
2435 return skip;
2436}
2437
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002438bool pv_vkCmdDrawIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, uint32_t count, uint32_t stride) {
2439 bool skip = false;
2440 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2441
2442 if (!device_data->physical_device_features.multiDrawIndirect && ((count > 1))) {
2443 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002444 DEVICE_FEATURE,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002445 "CmdDrawIndirect(): Device feature multiDrawIndirect disabled: count must be 0 or 1 but is %d", count);
2446 }
2447 return skip;
2448}
2449
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002450bool pv_vkCmdDrawIndexedIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, uint32_t count,
2451 uint32_t stride) {
2452 bool skip = false;
2453 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2454 if (!device_data->physical_device_features.multiDrawIndirect && ((count > 1))) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06002455 skip |= log_msg(
2456 device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, DEVICE_FEATURE,
2457 "CmdDrawIndexedIndirect(): Device feature multiDrawIndirect disabled: count must be 0 or 1 but is %d", count);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002458 }
2459 return skip;
2460}
2461
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002462bool pv_vkCmdCopyImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkImage dstImage,
2463 VkImageLayout dstImageLayout, uint32_t regionCount, const VkImageCopy *pRegions) {
2464 bool skip = false;
2465 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2466
Dave Houltonf5217612018-02-02 16:18:52 -07002467 VkImageAspectFlags legal_aspect_flags =
2468 VK_IMAGE_ASPECT_COLOR_BIT | VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT | VK_IMAGE_ASPECT_METADATA_BIT;
2469 if (device_data->extensions.vk_khr_sampler_ycbcr_conversion) {
2470 legal_aspect_flags |= (VK_IMAGE_ASPECT_PLANE_0_BIT_KHR | VK_IMAGE_ASPECT_PLANE_1_BIT_KHR | VK_IMAGE_ASPECT_PLANE_2_BIT_KHR);
2471 }
2472
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002473 if (pRegions != nullptr) {
Dave Houltonf5217612018-02-02 16:18:52 -07002474 if ((pRegions->srcSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002475 skip |= log_msg(
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002476 device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002477 VALIDATION_ERROR_0a600c01,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002478 "vkCmdCopyImage() parameter, VkImageAspect pRegions->srcSubresource.aspectMask, is an unrecognized enumerator.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002479 }
Dave Houltonf5217612018-02-02 16:18:52 -07002480 if ((pRegions->dstSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002481 skip |= log_msg(
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002482 device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002483 VALIDATION_ERROR_0a600c01,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002484 "vkCmdCopyImage() parameter, VkImageAspect pRegions->dstSubresource.aspectMask, is an unrecognized enumerator.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002485 }
2486 }
2487 return skip;
2488}
2489
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002490bool pv_vkCmdBlitImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkImage dstImage,
2491 VkImageLayout dstImageLayout, uint32_t regionCount, const VkImageBlit *pRegions, VkFilter filter) {
2492 bool skip = false;
2493 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2494
Dave Houltonf5217612018-02-02 16:18:52 -07002495 VkImageAspectFlags legal_aspect_flags =
2496 VK_IMAGE_ASPECT_COLOR_BIT | VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT | VK_IMAGE_ASPECT_METADATA_BIT;
2497 if (device_data->extensions.vk_khr_sampler_ycbcr_conversion) {
2498 legal_aspect_flags |= (VK_IMAGE_ASPECT_PLANE_0_BIT_KHR | VK_IMAGE_ASPECT_PLANE_1_BIT_KHR | VK_IMAGE_ASPECT_PLANE_2_BIT_KHR);
2499 }
2500
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002501 if (pRegions != nullptr) {
Dave Houltonf5217612018-02-02 16:18:52 -07002502 if ((pRegions->srcSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002503 skip |= log_msg(
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002504 device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002505 UNRECOGNIZED_VALUE,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002506 "vkCmdBlitImage() parameter, VkImageAspect pRegions->srcSubresource.aspectMask, is an unrecognized enumerator");
2507 }
Dave Houltonf5217612018-02-02 16:18:52 -07002508 if ((pRegions->dstSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002509 skip |= log_msg(
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002510 device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002511 UNRECOGNIZED_VALUE,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002512 "vkCmdBlitImage() parameter, VkImageAspect pRegions->dstSubresource.aspectMask, is an unrecognized enumerator");
2513 }
2514 }
2515 return skip;
2516}
2517
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002518bool pv_vkCmdCopyBufferToImage(VkCommandBuffer commandBuffer, VkBuffer srcBuffer, VkImage dstImage, VkImageLayout dstImageLayout,
2519 uint32_t regionCount, const VkBufferImageCopy *pRegions) {
2520 bool skip = false;
2521 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2522
Dave Houltonf5217612018-02-02 16:18:52 -07002523 VkImageAspectFlags legal_aspect_flags =
2524 VK_IMAGE_ASPECT_COLOR_BIT | VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT | VK_IMAGE_ASPECT_METADATA_BIT;
2525 if (device_data->extensions.vk_khr_sampler_ycbcr_conversion) {
2526 legal_aspect_flags |= (VK_IMAGE_ASPECT_PLANE_0_BIT_KHR | VK_IMAGE_ASPECT_PLANE_1_BIT_KHR | VK_IMAGE_ASPECT_PLANE_2_BIT_KHR);
2527 }
2528
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002529 if (pRegions != nullptr) {
Dave Houltonf5217612018-02-02 16:18:52 -07002530 if ((pRegions->imageSubresource.aspectMask & legal_aspect_flags) == 0) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07002531 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002532 UNRECOGNIZED_VALUE,
Dave Houltona9df0ce2018-02-07 10:51:23 -07002533 "vkCmdCopyBufferToImage() parameter, VkImageAspect pRegions->imageSubresource.aspectMask, is an "
2534 "unrecognized enumerator");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002535 }
2536 }
2537 return skip;
2538}
2539
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002540bool pv_vkCmdCopyImageToBuffer(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkBuffer dstBuffer,
2541 uint32_t regionCount, const VkBufferImageCopy *pRegions) {
2542 bool skip = false;
2543 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2544
Dave Houltonf5217612018-02-02 16:18:52 -07002545 VkImageAspectFlags legal_aspect_flags =
2546 VK_IMAGE_ASPECT_COLOR_BIT | VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT | VK_IMAGE_ASPECT_METADATA_BIT;
2547 if (device_data->extensions.vk_khr_sampler_ycbcr_conversion) {
2548 legal_aspect_flags |= (VK_IMAGE_ASPECT_PLANE_0_BIT_KHR | VK_IMAGE_ASPECT_PLANE_1_BIT_KHR | VK_IMAGE_ASPECT_PLANE_2_BIT_KHR);
2549 }
2550
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002551 if (pRegions != nullptr) {
Dave Houltonf5217612018-02-02 16:18:52 -07002552 if ((pRegions->imageSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002553 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002554 UNRECOGNIZED_VALUE,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002555 "vkCmdCopyImageToBuffer parameter, VkImageAspect pRegions->imageSubresource.aspectMask, is an unrecognized "
2556 "enumerator");
2557 }
2558 }
2559 return skip;
2560}
2561
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002562bool pv_vkCmdUpdateBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer, VkDeviceSize dstOffset, VkDeviceSize dataSize,
2563 const void *pData) {
2564 bool skip = false;
2565 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2566
2567 if (dstOffset & 3) {
2568 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002569 VALIDATION_ERROR_1e400048,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002570 "vkCmdUpdateBuffer() parameter, VkDeviceSize dstOffset (0x%" PRIxLEAST64 "), is not a multiple of 4.",
2571 dstOffset);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002572 }
2573
2574 if ((dataSize <= 0) || (dataSize > 65536)) {
2575 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002576 VALIDATION_ERROR_1e40004a,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002577 "vkCmdUpdateBuffer() parameter, VkDeviceSize dataSize (0x%" PRIxLEAST64
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002578 "), must be greater than zero and less than or equal to 65536.",
2579 dataSize);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002580 } else if (dataSize & 3) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002581 skip |=
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002582 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002583 VALIDATION_ERROR_1e40004c,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002584 "vkCmdUpdateBuffer() parameter, VkDeviceSize dataSize (0x%" PRIxLEAST64 "), is not a multiple of 4.", dataSize);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002585 }
2586 return skip;
2587}
2588
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002589bool pv_vkCmdFillBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer, VkDeviceSize dstOffset, VkDeviceSize size,
2590 uint32_t data) {
2591 bool skip = false;
2592 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2593
2594 if (dstOffset & 3) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002595 skip |=
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002596 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002597 VALIDATION_ERROR_1b400032,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002598 "vkCmdFillBuffer() parameter, VkDeviceSize dstOffset (0x%" PRIxLEAST64 "), is not a multiple of 4.", dstOffset);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002599 }
2600
2601 if (size != VK_WHOLE_SIZE) {
2602 if (size <= 0) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002603 skip |=
2604 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002605 VALIDATION_ERROR_1b400034,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002606 "vkCmdFillBuffer() parameter, VkDeviceSize size (0x%" PRIxLEAST64 "), must be greater than zero.", size);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002607 } else if (size & 3) {
2608 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002609 VALIDATION_ERROR_1b400038,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002610 "vkCmdFillBuffer() parameter, VkDeviceSize size (0x%" PRIxLEAST64 "), is not a multiple of 4.", size);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002611 }
2612 }
2613 return skip;
2614}
2615
2616VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateInstanceLayerProperties(uint32_t *pCount, VkLayerProperties *pProperties) {
2617 return util_GetLayerProperties(1, &global_layer, pCount, pProperties);
2618}
2619
2620VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateDeviceLayerProperties(VkPhysicalDevice physicalDevice, uint32_t *pCount,
2621 VkLayerProperties *pProperties) {
2622 return util_GetLayerProperties(1, &global_layer, pCount, pProperties);
2623}
2624
2625VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateInstanceExtensionProperties(const char *pLayerName, uint32_t *pCount,
2626 VkExtensionProperties *pProperties) {
2627 if (pLayerName && !strcmp(pLayerName, global_layer.layerName))
2628 return util_GetExtensionProperties(1, instance_extensions, pCount, pProperties);
2629
2630 return VK_ERROR_LAYER_NOT_PRESENT;
2631}
2632
2633VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateDeviceExtensionProperties(VkPhysicalDevice physicalDevice, const char *pLayerName,
2634 uint32_t *pPropertyCount, VkExtensionProperties *pProperties) {
2635 // Parameter_validation does not have any physical device extensions
2636 if (pLayerName && !strcmp(pLayerName, global_layer.layerName))
2637 return util_GetExtensionProperties(0, NULL, pPropertyCount, pProperties);
2638
2639 instance_layer_data *local_data = GetLayerDataPtr(get_dispatch_key(physicalDevice), instance_layer_data_map);
2640 bool skip =
2641 validate_array(local_data->report_data, "vkEnumerateDeviceExtensionProperties", "pPropertyCount", "pProperties",
2642 pPropertyCount, pProperties, true, false, false, VALIDATION_ERROR_UNDEFINED, VALIDATION_ERROR_2761f401);
2643 if (skip) return VK_ERROR_VALIDATION_FAILED_EXT;
2644
2645 return local_data->dispatch_table.EnumerateDeviceExtensionProperties(physicalDevice, NULL, pPropertyCount, pProperties);
2646}
2647
2648static bool require_device_extension(layer_data *device_data, bool flag, char const *function_name, char const *extension_name) {
2649 if (!flag) {
2650 return log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002651 EXTENSION_NOT_ENABLED, "%s() called even though the %s extension was not enabled for this VkDevice.",
2652 function_name, extension_name);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002653 }
2654
2655 return false;
2656}
2657
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002658bool pv_vkCreateSwapchainKHR(VkDevice device, const VkSwapchainCreateInfoKHR *pCreateInfo, const VkAllocationCallbacks *pAllocator,
2659 VkSwapchainKHR *pSwapchain) {
2660 bool skip = false;
2661 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2662 debug_report_data *report_data = device_data->report_data;
2663
Mark Lobodzinski88529492018-04-01 10:38:15 -06002664 const LogMiscParams log_misc{report_data, VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT, VK_NULL_HANDLE,
Petr Krause5c37652018-01-05 04:05:12 +01002665 "vkCreateSwapchainKHR"};
2666
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002667 if (pCreateInfo != nullptr) {
2668 if ((device_data->physical_device_features.textureCompressionETC2 == false) &&
2669 FormatIsCompressed_ETC2_EAC(pCreateInfo->imageFormat)) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07002670 skip |=
Mark Lobodzinski88529492018-04-01 10:38:15 -06002671 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, DEVICE_FEATURE,
Dave Houltona9df0ce2018-02-07 10:51:23 -07002672 "vkCreateSwapchainKHR(): Attempting to create swapchain VkImage with format %s. The textureCompressionETC2 "
2673 "feature is not enabled: neither ETC2 nor EAC formats can be used to create images.",
2674 string_VkFormat(pCreateInfo->imageFormat));
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002675 }
2676
2677 if ((device_data->physical_device_features.textureCompressionASTC_LDR == false) &&
2678 FormatIsCompressed_ASTC_LDR(pCreateInfo->imageFormat)) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06002679 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, DEVICE_FEATURE,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002680 "vkCreateSwapchainKHR(): Attempting to create swapchain VkImage with format %s. The "
2681 "textureCompressionASTC_LDR feature is not enabled: ASTC formats cannot be used to create images.",
2682 string_VkFormat(pCreateInfo->imageFormat));
2683 }
2684
2685 if ((device_data->physical_device_features.textureCompressionBC == false) &&
2686 FormatIsCompressed_BC(pCreateInfo->imageFormat)) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06002687 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, DEVICE_FEATURE,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002688 "vkCreateSwapchainKHR(): Attempting to create swapchain VkImage with format %s. The "
2689 "textureCompressionBC feature is not enabled: BC compressed formats cannot be used to create images.",
2690 string_VkFormat(pCreateInfo->imageFormat));
2691 }
2692
2693 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
2694 if (pCreateInfo->imageSharingMode == VK_SHARING_MODE_CONCURRENT) {
2695 // If imageSharingMode is VK_SHARING_MODE_CONCURRENT, queueFamilyIndexCount must be greater than 1
2696 if (pCreateInfo->queueFamilyIndexCount <= 1) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002697 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002698 VALIDATION_ERROR_146009fc,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002699 "vkCreateSwapchainKHR(): if pCreateInfo->imageSharingMode is VK_SHARING_MODE_CONCURRENT, "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002700 "pCreateInfo->queueFamilyIndexCount must be greater than 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002701 }
2702
2703 // If imageSharingMode is VK_SHARING_MODE_CONCURRENT, pQueueFamilyIndices must be a pointer to an array of
2704 // queueFamilyIndexCount uint32_t values
2705 if (pCreateInfo->pQueueFamilyIndices == nullptr) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002706 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002707 VALIDATION_ERROR_146009fa,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002708 "vkCreateSwapchainKHR(): if pCreateInfo->imageSharingMode is VK_SHARING_MODE_CONCURRENT, "
2709 "pCreateInfo->pQueueFamilyIndices must be a pointer to an array of "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002710 "pCreateInfo->queueFamilyIndexCount uint32_t values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002711 } else {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002712 skip |= ValidateQueueFamilies(device_data, pCreateInfo->queueFamilyIndexCount, pCreateInfo->pQueueFamilyIndices,
2713 "vkCreateSwapchainKHR", "pCreateInfo->pQueueFamilyIndices", INVALID_USAGE,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002714 INVALID_USAGE, false);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002715 }
2716 }
2717
Petr Krause5c37652018-01-05 04:05:12 +01002718 skip |= ValidateGreaterThanZero(pCreateInfo->imageArrayLayers, "pCreateInfo->imageArrayLayers", VALIDATION_ERROR_146009f6,
2719 log_misc);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002720 }
2721
2722 return skip;
2723}
2724
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002725bool pv_vkQueuePresentKHR(VkQueue queue, const VkPresentInfoKHR *pPresentInfo) {
2726 bool skip = false;
2727 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(queue), layer_data_map);
2728
2729 if (pPresentInfo && pPresentInfo->pNext) {
John Zulaufde972ac2017-10-26 12:07:05 -06002730 const auto *present_regions = lvl_find_in_chain<VkPresentRegionsKHR>(pPresentInfo->pNext);
2731 if (present_regions) {
2732 // TODO: This and all other pNext extension dependencies should be added to code-generation
2733 skip |= require_device_extension(device_data, device_data->extensions.vk_khr_incremental_present, "vkQueuePresentKHR",
2734 VK_KHR_INCREMENTAL_PRESENT_EXTENSION_NAME);
2735 if (present_regions->swapchainCount != pPresentInfo->swapchainCount) {
2736 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002737 INVALID_USAGE,
Dave Houltona9df0ce2018-02-07 10:51:23 -07002738 "QueuePresentKHR(): pPresentInfo->swapchainCount has a value of %i but VkPresentRegionsKHR "
2739 "extension swapchainCount is %i. These values must be equal.",
John Zulaufde972ac2017-10-26 12:07:05 -06002740 pPresentInfo->swapchainCount, present_regions->swapchainCount);
2741 }
2742 skip |= validate_struct_pnext(device_data->report_data, "QueuePresentKHR", "pCreateInfo->pNext->pNext", NULL,
2743 present_regions->pNext, 0, NULL, GeneratedHeaderVersion, VALIDATION_ERROR_1121c40d);
2744 skip |= validate_array(device_data->report_data, "QueuePresentKHR", "pCreateInfo->pNext->swapchainCount",
2745 "pCreateInfo->pNext->pRegions", present_regions->swapchainCount, present_regions->pRegions, true,
2746 false, VALIDATION_ERROR_UNDEFINED, VALIDATION_ERROR_UNDEFINED);
2747 for (uint32_t i = 0; i < present_regions->swapchainCount; ++i) {
2748 skip |= validate_array(device_data->report_data, "QueuePresentKHR", "pCreateInfo->pNext->pRegions[].rectangleCount",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002749 "pCreateInfo->pNext->pRegions[].pRectangles", present_regions->pRegions[i].rectangleCount,
2750 present_regions->pRegions[i].pRectangles, true, false, VALIDATION_ERROR_UNDEFINED,
2751 VALIDATION_ERROR_UNDEFINED);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002752 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002753 }
2754 }
2755
2756 return skip;
2757}
2758
2759#ifdef VK_USE_PLATFORM_WIN32_KHR
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002760bool pv_vkCreateWin32SurfaceKHR(VkInstance instance, const VkWin32SurfaceCreateInfoKHR *pCreateInfo,
2761 const VkAllocationCallbacks *pAllocator, VkSurfaceKHR *pSurface) {
2762 auto device_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map);
2763 bool skip = false;
2764
2765 if (pCreateInfo->hwnd == nullptr) {
2766 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002767 VALIDATION_ERROR_15a00a38, "vkCreateWin32SurfaceKHR(): hwnd must be a valid Win32 HWND but hwnd is NULL.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002768 }
2769
2770 return skip;
2771}
2772#endif // VK_USE_PLATFORM_WIN32_KHR
2773
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002774bool pv_vkDebugMarkerSetObjectNameEXT(VkDevice device, const VkDebugMarkerObjectNameInfoEXT *pNameInfo) {
2775 auto device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2776 if (pNameInfo->pObjectName) {
2777 device_data->report_data->debugObjectNameMap->insert(
2778 std::make_pair<uint64_t, std::string>((uint64_t &&) pNameInfo->object, pNameInfo->pObjectName));
2779 } else {
2780 device_data->report_data->debugObjectNameMap->erase(pNameInfo->object);
2781 }
2782 return false;
2783}
2784
Petr Krausc8655be2017-09-27 18:56:51 +02002785bool pv_vkCreateDescriptorPool(VkDevice device, const VkDescriptorPoolCreateInfo *pCreateInfo,
2786 const VkAllocationCallbacks *pAllocator, VkDescriptorPool *pDescriptorPool) {
2787 auto device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2788 bool skip = false;
2789
2790 if (pCreateInfo) {
2791 if (pCreateInfo->maxSets <= 0) {
2792 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT,
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002793 VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, VK_NULL_HANDLE, VALIDATION_ERROR_0480025a,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002794 "vkCreateDescriptorPool(): pCreateInfo->maxSets is not greater than 0.");
Petr Krausc8655be2017-09-27 18:56:51 +02002795 }
2796
2797 if (pCreateInfo->pPoolSizes) {
2798 for (uint32_t i = 0; i < pCreateInfo->poolSizeCount; ++i) {
2799 if (pCreateInfo->pPoolSizes[i].descriptorCount <= 0) {
2800 skip |= log_msg(
2801 device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002802 VK_NULL_HANDLE, VALIDATION_ERROR_04a0025c,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002803 "vkCreateDescriptorPool(): pCreateInfo->pPoolSizes[%" PRIu32 "].descriptorCount is not greater than 0.", i);
Petr Krausc8655be2017-09-27 18:56:51 +02002804 }
2805 }
2806 }
2807 }
2808
2809 return skip;
2810}
2811
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07002812bool pv_vkCmdDispatch(VkCommandBuffer commandBuffer, uint32_t groupCountX, uint32_t groupCountY, uint32_t groupCountZ) {
2813 bool skip = false;
2814 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2815
2816 if (groupCountX > device_data->device_limits.maxComputeWorkGroupCount[0]) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002817 skip |=
2818 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002819 HandleToUint64(commandBuffer), VALIDATION_ERROR_19c00304,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002820 "vkCmdDispatch(): groupCountX (%" PRIu32 ") exceeds device limit maxComputeWorkGroupCount[0] (%" PRIu32 ").",
2821 groupCountX, device_data->device_limits.maxComputeWorkGroupCount[0]);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07002822 }
2823
2824 if (groupCountY > device_data->device_limits.maxComputeWorkGroupCount[1]) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002825 skip |=
2826 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002827 HandleToUint64(commandBuffer), VALIDATION_ERROR_19c00306,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002828 "vkCmdDispatch(): groupCountY (%" PRIu32 ") exceeds device limit maxComputeWorkGroupCount[1] (%" PRIu32 ").",
2829 groupCountY, device_data->device_limits.maxComputeWorkGroupCount[1]);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07002830 }
2831
2832 if (groupCountZ > device_data->device_limits.maxComputeWorkGroupCount[2]) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002833 skip |=
2834 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002835 HandleToUint64(commandBuffer), VALIDATION_ERROR_19c00308,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002836 "vkCmdDispatch(): groupCountZ (%" PRIu32 ") exceeds device limit maxComputeWorkGroupCount[2] (%" PRIu32 ").",
2837 groupCountZ, device_data->device_limits.maxComputeWorkGroupCount[2]);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07002838 }
2839
2840 return skip;
2841}
2842
Mark Lobodzinskibf973a12018-03-01 08:50:21 -07002843bool pv_vkCmdDispatchBaseKHR(VkCommandBuffer commandBuffer, uint32_t baseGroupX, uint32_t baseGroupY, uint32_t baseGroupZ,
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07002844 uint32_t groupCountX, uint32_t groupCountY, uint32_t groupCountZ) {
2845 bool skip = false;
2846 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2847
2848 // Paired if {} else if {} tests used to avoid any possible uint underflow
2849 uint32_t limit = device_data->device_limits.maxComputeWorkGroupCount[0];
2850 if (baseGroupX >= limit) {
2851 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002852 HandleToUint64(commandBuffer), VALIDATION_ERROR_19e0034a,
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07002853 "vkCmdDispatch(): baseGroupX (%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002854 ") equals or exceeds device limit maxComputeWorkGroupCount[0] (%" PRIu32 ").",
2855 baseGroupX, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07002856 } else if (groupCountX > (limit - baseGroupX)) {
2857 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002858 HandleToUint64(commandBuffer), VALIDATION_ERROR_19e00350,
Mark Lobodzinskibf973a12018-03-01 08:50:21 -07002859 "vkCmdDispatchBaseKHR(): baseGroupX (%" PRIu32 ") + groupCountX (%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002860 ") exceeds device limit maxComputeWorkGroupCount[0] (%" PRIu32 ").",
2861 baseGroupX, groupCountX, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07002862 }
2863
2864 limit = device_data->device_limits.maxComputeWorkGroupCount[1];
2865 if (baseGroupY >= limit) {
2866 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002867 HandleToUint64(commandBuffer), VALIDATION_ERROR_19e0034c,
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07002868 "vkCmdDispatch(): baseGroupY (%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002869 ") equals or exceeds device limit maxComputeWorkGroupCount[1] (%" PRIu32 ").",
2870 baseGroupY, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07002871 } else if (groupCountY > (limit - baseGroupY)) {
2872 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002873 HandleToUint64(commandBuffer), VALIDATION_ERROR_19e00352,
Mark Lobodzinskibf973a12018-03-01 08:50:21 -07002874 "vkCmdDispatchBaseKHR(): baseGroupY (%" PRIu32 ") + groupCountY (%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002875 ") exceeds device limit maxComputeWorkGroupCount[1] (%" PRIu32 ").",
2876 baseGroupY, groupCountY, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07002877 }
2878
2879 limit = device_data->device_limits.maxComputeWorkGroupCount[2];
2880 if (baseGroupZ >= limit) {
2881 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002882 HandleToUint64(commandBuffer), VALIDATION_ERROR_19e0034e,
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07002883 "vkCmdDispatch(): baseGroupZ (%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002884 ") equals or exceeds device limit maxComputeWorkGroupCount[2] (%" PRIu32 ").",
2885 baseGroupZ, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07002886 } else if (groupCountZ > (limit - baseGroupZ)) {
2887 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002888 HandleToUint64(commandBuffer), VALIDATION_ERROR_19e00354,
Mark Lobodzinskibf973a12018-03-01 08:50:21 -07002889 "vkCmdDispatchBaseKHR(): baseGroupZ (%" PRIu32 ") + groupCountZ (%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002890 ") exceeds device limit maxComputeWorkGroupCount[2] (%" PRIu32 ").",
2891 baseGroupZ, groupCountZ, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07002892 }
2893
2894 return skip;
2895}
2896
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002897VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetDeviceProcAddr(VkDevice device, const char *funcName) {
2898 const auto item = name_to_funcptr_map.find(funcName);
2899 if (item != name_to_funcptr_map.end()) {
2900 return reinterpret_cast<PFN_vkVoidFunction>(item->second);
2901 }
2902
2903 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2904 const auto &table = device_data->dispatch_table;
2905 if (!table.GetDeviceProcAddr) return nullptr;
2906 return table.GetDeviceProcAddr(device, funcName);
2907}
2908
2909VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetInstanceProcAddr(VkInstance instance, const char *funcName) {
2910 const auto item = name_to_funcptr_map.find(funcName);
2911 if (item != name_to_funcptr_map.end()) {
2912 return reinterpret_cast<PFN_vkVoidFunction>(item->second);
2913 }
2914
2915 auto instance_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map);
2916 auto &table = instance_data->dispatch_table;
2917 if (!table.GetInstanceProcAddr) return nullptr;
2918 return table.GetInstanceProcAddr(instance, funcName);
2919}
2920
2921VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetPhysicalDeviceProcAddr(VkInstance instance, const char *funcName) {
2922 assert(instance);
2923 auto instance_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map);
2924
2925 if (!instance_data->dispatch_table.GetPhysicalDeviceProcAddr) return nullptr;
2926 return instance_data->dispatch_table.GetPhysicalDeviceProcAddr(instance, funcName);
2927}
2928
2929// If additional validation is needed outside of the generated checks, a manual routine can be added to this file
2930// and the address filled in here. The autogenerated source will call these routines if the pointers are not NULL.
Petr Krausc8655be2017-09-27 18:56:51 +02002931void InitializeManualParameterValidationFunctionPointers() {
Dave Houltonb3bbec72018-01-17 10:13:33 -07002932 custom_functions["vkGetDeviceQueue"] = (void *)pv_vkGetDeviceQueue;
2933 custom_functions["vkCreateBuffer"] = (void *)pv_vkCreateBuffer;
2934 custom_functions["vkCreateImage"] = (void *)pv_vkCreateImage;
2935 custom_functions["vkCreateImageView"] = (void *)pv_vkCreateImageView;
2936 custom_functions["vkCreateGraphicsPipelines"] = (void *)pv_vkCreateGraphicsPipelines;
2937 custom_functions["vkCreateComputePipelines"] = (void *)pv_vkCreateComputePipelines;
2938 custom_functions["vkCreateSampler"] = (void *)pv_vkCreateSampler;
2939 custom_functions["vkCreateDescriptorSetLayout"] = (void *)pv_vkCreateDescriptorSetLayout;
2940 custom_functions["vkFreeDescriptorSets"] = (void *)pv_vkFreeDescriptorSets;
2941 custom_functions["vkUpdateDescriptorSets"] = (void *)pv_vkUpdateDescriptorSets;
2942 custom_functions["vkCreateRenderPass"] = (void *)pv_vkCreateRenderPass;
2943 custom_functions["vkBeginCommandBuffer"] = (void *)pv_vkBeginCommandBuffer;
2944 custom_functions["vkCmdSetViewport"] = (void *)pv_vkCmdSetViewport;
2945 custom_functions["vkCmdSetScissor"] = (void *)pv_vkCmdSetScissor;
Petr Kraus299ba622017-11-24 03:09:03 +01002946 custom_functions["vkCmdSetLineWidth"] = (void *)pv_vkCmdSetLineWidth;
Dave Houltonb3bbec72018-01-17 10:13:33 -07002947 custom_functions["vkCmdDraw"] = (void *)pv_vkCmdDraw;
2948 custom_functions["vkCmdDrawIndirect"] = (void *)pv_vkCmdDrawIndirect;
2949 custom_functions["vkCmdDrawIndexedIndirect"] = (void *)pv_vkCmdDrawIndexedIndirect;
2950 custom_functions["vkCmdCopyImage"] = (void *)pv_vkCmdCopyImage;
2951 custom_functions["vkCmdBlitImage"] = (void *)pv_vkCmdBlitImage;
2952 custom_functions["vkCmdCopyBufferToImage"] = (void *)pv_vkCmdCopyBufferToImage;
2953 custom_functions["vkCmdCopyImageToBuffer"] = (void *)pv_vkCmdCopyImageToBuffer;
2954 custom_functions["vkCmdUpdateBuffer"] = (void *)pv_vkCmdUpdateBuffer;
2955 custom_functions["vkCmdFillBuffer"] = (void *)pv_vkCmdFillBuffer;
2956 custom_functions["vkCreateSwapchainKHR"] = (void *)pv_vkCreateSwapchainKHR;
2957 custom_functions["vkQueuePresentKHR"] = (void *)pv_vkQueuePresentKHR;
2958 custom_functions["vkCreateDescriptorPool"] = (void *)pv_vkCreateDescriptorPool;
2959 custom_functions["vkCmdDispatch"] = (void *)pv_vkCmdDispatch;
Mark Lobodzinskibf973a12018-03-01 08:50:21 -07002960 custom_functions["vkCmdDispatchBaseKHR"] = (void *)pv_vkCmdDispatchBaseKHR;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002961}
2962
2963} // namespace parameter_validation
2964
2965VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateInstanceExtensionProperties(const char *pLayerName, uint32_t *pCount,
2966 VkExtensionProperties *pProperties) {
2967 return parameter_validation::vkEnumerateInstanceExtensionProperties(pLayerName, pCount, pProperties);
2968}
2969
2970VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateInstanceLayerProperties(uint32_t *pCount,
2971 VkLayerProperties *pProperties) {
2972 return parameter_validation::vkEnumerateInstanceLayerProperties(pCount, pProperties);
2973}
2974
2975VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateDeviceLayerProperties(VkPhysicalDevice physicalDevice, uint32_t *pCount,
2976 VkLayerProperties *pProperties) {
2977 // the layer command handles VK_NULL_HANDLE just fine internally
2978 assert(physicalDevice == VK_NULL_HANDLE);
2979 return parameter_validation::vkEnumerateDeviceLayerProperties(VK_NULL_HANDLE, pCount, pProperties);
2980}
2981
2982VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateDeviceExtensionProperties(VkPhysicalDevice physicalDevice,
2983 const char *pLayerName, uint32_t *pCount,
2984 VkExtensionProperties *pProperties) {
2985 // the layer command handles VK_NULL_HANDLE just fine internally
2986 assert(physicalDevice == VK_NULL_HANDLE);
2987 return parameter_validation::vkEnumerateDeviceExtensionProperties(VK_NULL_HANDLE, pLayerName, pCount, pProperties);
2988}
2989
2990VK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetDeviceProcAddr(VkDevice dev, const char *funcName) {
2991 return parameter_validation::vkGetDeviceProcAddr(dev, funcName);
2992}
2993
2994VK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetInstanceProcAddr(VkInstance instance, const char *funcName) {
2995 return parameter_validation::vkGetInstanceProcAddr(instance, funcName);
2996}
2997
2998VK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vk_layerGetPhysicalDeviceProcAddr(VkInstance instance,
2999 const char *funcName) {
3000 return parameter_validation::vkGetPhysicalDeviceProcAddr(instance, funcName);
3001}
3002
3003VK_LAYER_EXPORT bool pv_vkNegotiateLoaderLayerInterfaceVersion(VkNegotiateLayerInterface *pVersionStruct) {
3004 assert(pVersionStruct != NULL);
3005 assert(pVersionStruct->sType == LAYER_NEGOTIATE_INTERFACE_STRUCT);
3006
3007 // Fill in the function pointers if our version is at least capable of having the structure contain them.
3008 if (pVersionStruct->loaderLayerInterfaceVersion >= 2) {
3009 pVersionStruct->pfnGetInstanceProcAddr = vkGetInstanceProcAddr;
3010 pVersionStruct->pfnGetDeviceProcAddr = vkGetDeviceProcAddr;
3011 pVersionStruct->pfnGetPhysicalDeviceProcAddr = vk_layerGetPhysicalDeviceProcAddr;
3012 }
3013
3014 if (pVersionStruct->loaderLayerInterfaceVersion < CURRENT_LOADER_LAYER_INTERFACE_VERSION) {
3015 parameter_validation::loader_layer_if_version = pVersionStruct->loaderLayerInterfaceVersion;
3016 } else if (pVersionStruct->loaderLayerInterfaceVersion > CURRENT_LOADER_LAYER_INTERFACE_VERSION) {
3017 pVersionStruct->loaderLayerInterfaceVersion = CURRENT_LOADER_LAYER_INTERFACE_VERSION;
3018 }
3019
3020 return VK_SUCCESS;
3021}