blob: 3f859aa26b6523e1acd5ac4412d284c8328e028f [file] [log] [blame]
Dave Houlton4d9b2f82018-10-24 18:21:06 -06001/* Copyright (c) 2015-2018 The Khronos Group Inc.
2 * Copyright (c) 2015-2018 Valve Corporation
3 * Copyright (c) 2015-2018 LunarG, Inc.
4 * Copyright (C) 2015-2018 Google Inc.
Mark Lobodzinskid4950072017-08-01 13:02:20 -06005 *
6 * Licensed under the Apache License, Version 2.0 (the "License");
7 * you may not use this file except in compliance with the License.
8 * You may obtain a copy of the License at
9 *
10 * http://www.apache.org/licenses/LICENSE-2.0
11 *
12 * Unless required by applicable law or agreed to in writing, software
13 * distributed under the License is distributed on an "AS IS" BASIS,
14 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15 * See the License for the specific language governing permissions and
16 * limitations under the License.
17 *
18 * Author: Mark Lobodzinski <mark@LunarG.com>
John Zulaufa999d1b2018-11-29 13:38:40 -070019 * Author: John Zulauf <jzulauf@lunarg.com>
Mark Lobodzinskid4950072017-08-01 13:02:20 -060020 */
21
22#define NOMINMAX
23
24#include <limits.h>
25#include <math.h>
26#include <stdio.h>
27#include <stdlib.h>
28#include <string.h>
Mark Lobodzinskid4950072017-08-01 13:02:20 -060029
30#include <iostream>
31#include <string>
32#include <sstream>
33#include <unordered_map>
34#include <unordered_set>
35#include <vector>
36#include <mutex>
37
38#include "vk_loader_platform.h"
39#include "vulkan/vk_layer.h"
40#include "vk_layer_config.h"
41#include "vk_dispatch_table_helper.h"
John Zulaufde972ac2017-10-26 12:07:05 -060042#include "vk_typemap_helper.h"
Mark Lobodzinskid4950072017-08-01 13:02:20 -060043
Mark Lobodzinskid4950072017-08-01 13:02:20 -060044#include "vk_layer_data.h"
45#include "vk_layer_logging.h"
46#include "vk_layer_extension_utils.h"
47#include "vk_layer_utils.h"
Lenny Komow4c0da772018-07-03 10:17:21 -060048#include "vk_layer_dispatch_table.h"
Mark Lobodzinskid4950072017-08-01 13:02:20 -060049
50#include "parameter_name.h"
51#include "parameter_validation.h"
52
Mark Lobodzinskibfb7ab92017-10-27 13:22:23 -060053#if defined __ANDROID__
54#include <android/log.h>
Mark Lobodzinski88529492018-04-01 10:38:15 -060055#define LOGCONSOLE(...) ((void)__android_log_print(ANDROID_LOG_INFO, "PARAMETER_VALIDATION", __VA_ARGS__))
Mark Lobodzinskibfb7ab92017-10-27 13:22:23 -060056#else
57#define LOGCONSOLE(...) \
58 { \
59 printf(__VA_ARGS__); \
60 printf("\n"); \
61 }
62#endif
63
Mark Lobodzinskid4950072017-08-01 13:02:20 -060064namespace parameter_validation {
65
Mark Lobodzinski78a12a92017-08-08 14:16:51 -060066extern std::unordered_map<std::string, void *> custom_functions;
67
Mark Lobodzinskid4950072017-08-01 13:02:20 -060068extern bool parameter_validation_vkCreateInstance(VkInstance instance, const VkInstanceCreateInfo *pCreateInfo,
69 const VkAllocationCallbacks *pAllocator, VkInstance *pInstance);
70extern bool parameter_validation_vkDestroyInstance(VkInstance instance, const VkAllocationCallbacks *pAllocator);
71extern bool parameter_validation_vkCreateDevice(VkPhysicalDevice physicalDevice, const VkDeviceCreateInfo *pCreateInfo,
72 const VkAllocationCallbacks *pAllocator, VkDevice *pDevice);
73extern bool parameter_validation_vkDestroyDevice(VkDevice device, const VkAllocationCallbacks *pAllocator);
74extern bool parameter_validation_vkCreateQueryPool(VkDevice device, const VkQueryPoolCreateInfo *pCreateInfo,
75 const VkAllocationCallbacks *pAllocator, VkQueryPool *pQueryPool);
76extern bool parameter_validation_vkCreateDebugReportCallbackEXT(VkInstance instance,
77 const VkDebugReportCallbackCreateInfoEXT *pCreateInfo,
78 const VkAllocationCallbacks *pAllocator,
79 VkDebugReportCallbackEXT *pMsgCallback);
80extern bool parameter_validation_vkDestroyDebugReportCallbackEXT(VkInstance instance, VkDebugReportCallbackEXT msgCallback,
81 const VkAllocationCallbacks *pAllocator);
Mark Young6ba8abe2017-11-09 10:37:04 -070082extern bool parameter_validation_vkCreateDebugUtilsMessengerEXT(VkInstance instance,
83 const VkDebugUtilsMessengerCreateInfoEXT *pCreateInfo,
84 const VkAllocationCallbacks *pAllocator,
85 VkDebugUtilsMessengerEXT *pMessenger);
86extern bool parameter_validation_vkDestroyDebugUtilsMessengerEXT(VkInstance instance, VkDebugUtilsMessengerEXT messenger,
87 const VkAllocationCallbacks *pAllocator);
Mark Lobodzinskid4950072017-08-01 13:02:20 -060088extern bool parameter_validation_vkCreateCommandPool(VkDevice device, const VkCommandPoolCreateInfo *pCreateInfo,
89 const VkAllocationCallbacks *pAllocator, VkCommandPool *pCommandPool);
Petr Krause91f7a12017-12-14 20:57:36 +010090extern bool parameter_validation_vkCreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo,
91 const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass);
Tobias Hectord942eb92018-10-22 15:18:56 +010092extern bool parameter_validation_vkCreateRenderPass2KHR(VkDevice device, const VkRenderPassCreateInfo2KHR *pCreateInfo,
93 const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass);
Petr Krause91f7a12017-12-14 20:57:36 +010094extern bool parameter_validation_vkDestroyRenderPass(VkDevice device, VkRenderPass renderPass,
95 const VkAllocationCallbacks *pAllocator);
Mark Lobodzinskid4950072017-08-01 13:02:20 -060096
97// TODO : This can be much smarter, using separate locks for separate global data
98std::mutex global_lock;
99
100static uint32_t loader_layer_if_version = CURRENT_LOADER_LAYER_INTERFACE_VERSION;
101std::unordered_map<void *, layer_data *> layer_data_map;
102std::unordered_map<void *, instance_layer_data *> instance_layer_data_map;
103
104void InitializeManualParameterValidationFunctionPointers(void);
105
106static void init_parameter_validation(instance_layer_data *instance_data, const VkAllocationCallbacks *pAllocator) {
Mark Young6ba8abe2017-11-09 10:37:04 -0700107 layer_debug_messenger_actions(instance_data->report_data, instance_data->logging_messenger, pAllocator,
108 "lunarg_parameter_validation");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600109}
110
Mark Young6ba8abe2017-11-09 10:37:04 -0700111static const VkExtensionProperties instance_extensions[] = {{VK_EXT_DEBUG_REPORT_EXTENSION_NAME, VK_EXT_DEBUG_REPORT_SPEC_VERSION},
112 {VK_EXT_DEBUG_UTILS_EXTENSION_NAME, VK_EXT_DEBUG_UTILS_SPEC_VERSION}};
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600113
114static const VkLayerProperties global_layer = {
Dave Houltonb3bbec72018-01-17 10:13:33 -0700115 "VK_LAYER_LUNARG_parameter_validation",
116 VK_LAYER_API_VERSION,
117 1,
118 "LunarG Validation Layer",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600119};
120
Tobias Hectord942eb92018-10-22 15:18:56 +0100121enum RenderPassCreateVersion { RENDER_PASS_VERSION_1 = 0, RENDER_PASS_VERSION_2 = 1 };
122
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600123static const int MaxParamCheckerStringLength = 256;
124
John Zulauf71968502017-10-26 13:51:15 -0600125template <typename T>
126static inline bool in_inclusive_range(const T &value, const T &min, const T &max) {
127 // Using only < for generality and || for early abort
128 return !((value < min) || (max < value));
129}
130
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600131static bool validate_string(debug_report_data *report_data, const char *apiName, const ParameterName &stringName,
Mark Lobodzinskiebee3552018-05-29 09:55:54 -0600132 const std::string &vuid, const char *validateString) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600133 bool skip = false;
134
135 VkStringErrorFlags result = vk_string_validate(MaxParamCheckerStringLength, validateString);
136
137 if (result == VK_STRING_ERROR_NONE) {
138 return skip;
139 } else if (result & VK_STRING_ERROR_LENGTH) {
Mark Lobodzinskiebee3552018-05-29 09:55:54 -0600140 skip = log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, vuid,
141 "%s: string %s exceeds max length %d", apiName, stringName.get_name().c_str(), MaxParamCheckerStringLength);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600142 } else if (result & VK_STRING_ERROR_BAD_DATA) {
Mark Lobodzinskiebee3552018-05-29 09:55:54 -0600143 skip = log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, vuid,
144 "%s: string %s contains invalid characters or is badly formed", apiName, stringName.get_name().c_str());
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600145 }
146 return skip;
147}
148
149static bool ValidateDeviceQueueFamily(layer_data *device_data, uint32_t queue_family, const char *cmd_name,
Dave Houlton13b65502018-05-23 13:35:24 -0600150 const char *parameter_name, const std::string &error_code, bool optional = false) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600151 bool skip = false;
152
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600153 if (!optional && queue_family == VK_QUEUE_FAMILY_IGNORED) {
154 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -0600155 HandleToUint64(device_data->device), error_code,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600156 "%s: %s is VK_QUEUE_FAMILY_IGNORED, but it is required to provide a valid queue family index value.",
157 cmd_name, parameter_name);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600158 } else if (device_data->queueFamilyIndexMap.find(queue_family) == device_data->queueFamilyIndexMap.end()) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600159 skip |=
160 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -0600161 HandleToUint64(device_data->device), error_code,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600162 "%s: %s (= %" PRIu32
163 ") is not one of the queue families given via VkDeviceQueueCreateInfo structures when the device was created.",
164 cmd_name, parameter_name, queue_family);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600165 }
166
167 return skip;
168}
169
170static bool ValidateQueueFamilies(layer_data *device_data, uint32_t queue_family_count, const uint32_t *queue_families,
Dave Houlton13b65502018-05-23 13:35:24 -0600171 const char *cmd_name, const char *array_parameter_name, const std::string &unique_error_code,
172 const std::string &valid_error_code, bool optional = false) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600173 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600174 if (queue_families) {
175 std::unordered_set<uint32_t> set;
176 for (uint32_t i = 0; i < queue_family_count; ++i) {
177 std::string parameter_name = std::string(array_parameter_name) + "[" + std::to_string(i) + "]";
178
179 if (set.count(queue_families[i])) {
180 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -0600181 HandleToUint64(device_data->device), "VUID-VkDeviceCreateInfo-queueFamilyIndex-00372",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600182 "%s: %s (=%" PRIu32 ") is not unique within %s array.", cmd_name, parameter_name.c_str(),
183 queue_families[i], array_parameter_name);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600184 } else {
185 set.insert(queue_families[i]);
186 skip |= ValidateDeviceQueueFamily(device_data, queue_families[i], cmd_name, parameter_name.c_str(),
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600187 valid_error_code, optional);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600188 }
189 }
190 }
191 return skip;
192}
193
John Zulauf620755c2018-04-16 11:00:43 -0600194static bool validate_api_version(const instance_layer_data *instance_data, uint32_t api_version, uint32_t effective_api_version) {
195 bool skip = false;
196 uint32_t api_version_nopatch = VK_MAKE_VERSION(VK_VERSION_MAJOR(api_version), VK_VERSION_MINOR(api_version), 0);
197 if (api_version_nopatch != effective_api_version) {
198 if (api_version_nopatch < VK_API_VERSION_1_0) {
199 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_INSTANCE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -0600200 HandleToUint64(instance_data->instance), kVUIDUndefined,
John Zulauf620755c2018-04-16 11:00:43 -0600201 "Invalid CreateInstance->pCreateInfo->pApplicationInfo.apiVersion number (0x%08x). "
202 "Using VK_API_VERSION_%" PRIu32 "_%" PRIu32 ".",
203 api_version, VK_VERSION_MAJOR(effective_api_version), VK_VERSION_MINOR(effective_api_version));
204 } else {
205 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_INSTANCE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -0600206 HandleToUint64(instance_data->instance), kVUIDUndefined,
John Zulauf620755c2018-04-16 11:00:43 -0600207 "Unrecognized CreateInstance->pCreateInfo->pApplicationInfo.apiVersion number (0x%08x). "
208 "Assuming VK_API_VERSION_%" PRIu32 "_%" PRIu32 ".",
209 api_version, VK_VERSION_MAJOR(effective_api_version), VK_VERSION_MINOR(effective_api_version));
210 }
211 }
212 return skip;
213}
214
215template <typename ExtensionState>
Dave Houlton13b65502018-05-23 13:35:24 -0600216static bool validate_extension_reqs(const instance_layer_data *instance_data, const ExtensionState &extensions,
217 const std::string &vuid, const char *extension_type, const char *extension_name) {
John Zulauf620755c2018-04-16 11:00:43 -0600218 bool skip = false;
219 if (!extension_name) {
220 return skip; // Robust to invalid char *
221 }
222 auto info = ExtensionState::get_info(extension_name);
223
224 if (!info.state) {
225 return skip; // Unknown extensions cannot be checked so report OK
226 }
227
Pat Brown3eddb062018-09-05 14:07:37 -0400228 // Check against the required list in the info
John Zulauf620755c2018-04-16 11:00:43 -0600229 std::vector<const char *> missing;
230 for (const auto &req : info.requires) {
231 if (!(extensions.*(req.enabled))) {
232 missing.push_back(req.name);
233 }
234 }
235
236 // Report any missing requirements
237 if (missing.size()) {
238 std::string missing_joined_list = string_join(", ", missing);
239 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_INSTANCE_EXT,
Pat Brown3eddb062018-09-05 14:07:37 -0400240 HandleToUint64(instance_data->instance), vuid, "Missing extension%s required by the %s extension %s: %s.",
241 ((missing.size() > 1) ? "s" : ""), extension_type, extension_name, missing_joined_list.c_str());
John Zulauf620755c2018-04-16 11:00:43 -0600242 }
243 return skip;
244}
245
246bool validate_instance_extensions(const instance_layer_data *instance_data, const VkInstanceCreateInfo *pCreateInfo) {
247 bool skip = false;
248 for (uint32_t i = 0; i < pCreateInfo->enabledExtensionCount; i++) {
Dave Houlton413a6782018-05-22 13:01:54 -0600249 skip |=
250 validate_extension_reqs(instance_data, instance_data->extensions, "VUID-vkCreateInstance-ppEnabledExtensionNames-01388",
251 "instance", pCreateInfo->ppEnabledExtensionNames[i]);
John Zulauf620755c2018-04-16 11:00:43 -0600252 }
253
254 return skip;
255}
256
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600257VKAPI_ATTR VkResult VKAPI_CALL vkCreateInstance(const VkInstanceCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600258 VkInstance *pInstance) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600259 VkResult result = VK_ERROR_VALIDATION_FAILED_EXT;
260
261 VkLayerInstanceCreateInfo *chain_info = get_chain_info(pCreateInfo, VK_LAYER_LINK_INFO);
262 assert(chain_info != nullptr);
263 assert(chain_info->u.pLayerInfo != nullptr);
264
265 PFN_vkGetInstanceProcAddr fpGetInstanceProcAddr = chain_info->u.pLayerInfo->pfnNextGetInstanceProcAddr;
266 PFN_vkCreateInstance fpCreateInstance = (PFN_vkCreateInstance)fpGetInstanceProcAddr(NULL, "vkCreateInstance");
267 if (fpCreateInstance == NULL) {
268 return VK_ERROR_INITIALIZATION_FAILED;
269 }
270
271 // Advance the link info for the next element on the chain
272 chain_info->u.pLayerInfo = chain_info->u.pLayerInfo->pNext;
273
274 result = fpCreateInstance(pCreateInfo, pAllocator, pInstance);
275
276 if (result == VK_SUCCESS) {
277 InitializeManualParameterValidationFunctionPointers();
278 auto my_instance_data = GetLayerDataPtr(get_dispatch_key(*pInstance), instance_layer_data_map);
279 assert(my_instance_data != nullptr);
280
281 layer_init_instance_dispatch_table(*pInstance, &my_instance_data->dispatch_table, fpGetInstanceProcAddr);
282 my_instance_data->instance = *pInstance;
283 my_instance_data->report_data =
Mark Young6ba8abe2017-11-09 10:37:04 -0700284 debug_utils_create_instance(&my_instance_data->dispatch_table, *pInstance, pCreateInfo->enabledExtensionCount,
285 pCreateInfo->ppEnabledExtensionNames);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600286
287 // Look for one or more debug report create info structures
288 // and setup a callback(s) for each one found.
Mark Young6ba8abe2017-11-09 10:37:04 -0700289 if (!layer_copy_tmp_debug_messengers(pCreateInfo->pNext, &my_instance_data->num_tmp_debug_messengers,
290 &my_instance_data->tmp_messenger_create_infos,
291 &my_instance_data->tmp_debug_messengers)) {
292 if (my_instance_data->num_tmp_debug_messengers > 0) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600293 // Setup the temporary callback(s) here to catch early issues:
Mark Young6ba8abe2017-11-09 10:37:04 -0700294 if (layer_enable_tmp_debug_messengers(my_instance_data->report_data, my_instance_data->num_tmp_debug_messengers,
295 my_instance_data->tmp_messenger_create_infos,
296 my_instance_data->tmp_debug_messengers)) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600297 // Failure of setting up one or more of the callback.
298 // Therefore, clean up and don't use those callbacks:
Mark Young6ba8abe2017-11-09 10:37:04 -0700299 layer_free_tmp_debug_messengers(my_instance_data->tmp_messenger_create_infos,
300 my_instance_data->tmp_debug_messengers);
301 my_instance_data->num_tmp_debug_messengers = 0;
302 }
303 }
304 }
305 if (!layer_copy_tmp_report_callbacks(pCreateInfo->pNext, &my_instance_data->num_tmp_report_callbacks,
306 &my_instance_data->tmp_report_create_infos, &my_instance_data->tmp_report_callbacks)) {
307 if (my_instance_data->num_tmp_report_callbacks > 0) {
308 // Setup the temporary callback(s) here to catch early issues:
309 if (layer_enable_tmp_report_callbacks(my_instance_data->report_data, my_instance_data->num_tmp_report_callbacks,
310 my_instance_data->tmp_report_create_infos,
311 my_instance_data->tmp_report_callbacks)) {
312 // Failure of setting up one or more of the callback.
313 // Therefore, clean up and don't use those callbacks:
314 layer_free_tmp_report_callbacks(my_instance_data->tmp_report_create_infos,
315 my_instance_data->tmp_report_callbacks);
316 my_instance_data->num_tmp_report_callbacks = 0;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600317 }
318 }
319 }
320
321 init_parameter_validation(my_instance_data, pAllocator);
John Zulaufe6db8a32018-03-30 14:51:59 -0600322 // Note: From the spec--
323 // Providing a NULL VkInstanceCreateInfo::pApplicationInfo or providing an apiVersion of 0 is equivalent to providing
324 // an apiVersion of VK_MAKE_VERSION(1, 0, 0). (a.k.a. VK_API_VERSION_1_0)
325 uint32_t api_version = (pCreateInfo->pApplicationInfo && pCreateInfo->pApplicationInfo->apiVersion)
326 ? pCreateInfo->pApplicationInfo->apiVersion
327 : VK_API_VERSION_1_0;
Mark Lobodzinskibfb7ab92017-10-27 13:22:23 -0600328
John Zulauf1909e6a2018-09-05 11:43:11 -0600329 my_instance_data->api_version = my_instance_data->extensions.InitFromInstanceCreateInfo(api_version, pCreateInfo);
Mark Lobodzinskibfb7ab92017-10-27 13:22:23 -0600330
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600331 // Ordinarily we'd check these before calling down the chain, but none of the layer support is in place until now, if we
332 // survive we can report the issue now.
John Zulauf1909e6a2018-09-05 11:43:11 -0600333 validate_api_version(my_instance_data, api_version, my_instance_data->api_version);
John Zulauf620755c2018-04-16 11:00:43 -0600334 validate_instance_extensions(my_instance_data, pCreateInfo);
335
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600336 parameter_validation_vkCreateInstance(*pInstance, pCreateInfo, pAllocator, pInstance);
337
338 if (pCreateInfo->pApplicationInfo) {
339 if (pCreateInfo->pApplicationInfo->pApplicationName) {
Mark Lobodzinskiebee3552018-05-29 09:55:54 -0600340 validate_string(
341 my_instance_data->report_data, "vkCreateInstance", "pCreateInfo->VkApplicationInfo->pApplicationName",
342 "VUID-VkApplicationInfo-pApplicationName-parameter", pCreateInfo->pApplicationInfo->pApplicationName);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600343 }
344
345 if (pCreateInfo->pApplicationInfo->pEngineName) {
346 validate_string(my_instance_data->report_data, "vkCreateInstance", "pCreateInfo->VkApplicationInfo->pEngineName",
Mark Lobodzinskiebee3552018-05-29 09:55:54 -0600347 "VUID-VkApplicationInfo-pEngineName-parameter", pCreateInfo->pApplicationInfo->pEngineName);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600348 }
349 }
350
351 // Disable the tmp callbacks:
Mark Young6ba8abe2017-11-09 10:37:04 -0700352 if (my_instance_data->num_tmp_debug_messengers > 0) {
353 layer_disable_tmp_debug_messengers(my_instance_data->report_data, my_instance_data->num_tmp_debug_messengers,
354 my_instance_data->tmp_debug_messengers);
355 }
356 if (my_instance_data->num_tmp_report_callbacks > 0) {
357 layer_disable_tmp_report_callbacks(my_instance_data->report_data, my_instance_data->num_tmp_report_callbacks,
358 my_instance_data->tmp_report_callbacks);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600359 }
360 }
361
362 return result;
363}
364
365VKAPI_ATTR void VKAPI_CALL vkDestroyInstance(VkInstance instance, const VkAllocationCallbacks *pAllocator) {
366 // Grab the key before the instance is destroyed.
367 dispatch_key key = get_dispatch_key(instance);
368 bool skip = false;
369 auto instance_data = GetLayerDataPtr(key, instance_layer_data_map);
370
371 // Enable the temporary callback(s) here to catch vkDestroyInstance issues:
372 bool callback_setup = false;
Mark Young6ba8abe2017-11-09 10:37:04 -0700373 if (instance_data->num_tmp_debug_messengers > 0) {
374 if (!layer_enable_tmp_debug_messengers(instance_data->report_data, instance_data->num_tmp_debug_messengers,
375 instance_data->tmp_messenger_create_infos, instance_data->tmp_debug_messengers)) {
376 callback_setup = true;
377 }
378 }
379 if (instance_data->num_tmp_report_callbacks > 0) {
380 if (!layer_enable_tmp_report_callbacks(instance_data->report_data, instance_data->num_tmp_report_callbacks,
381 instance_data->tmp_report_create_infos, instance_data->tmp_report_callbacks)) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600382 callback_setup = true;
383 }
384 }
385
386 skip |= parameter_validation_vkDestroyInstance(instance, pAllocator);
387
388 // Disable and cleanup the temporary callback(s):
389 if (callback_setup) {
Mark Young6ba8abe2017-11-09 10:37:04 -0700390 layer_disable_tmp_debug_messengers(instance_data->report_data, instance_data->num_tmp_debug_messengers,
391 instance_data->tmp_debug_messengers);
392 layer_disable_tmp_report_callbacks(instance_data->report_data, instance_data->num_tmp_report_callbacks,
393 instance_data->tmp_report_callbacks);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600394 }
Mark Young6ba8abe2017-11-09 10:37:04 -0700395 if (instance_data->num_tmp_debug_messengers > 0) {
396 layer_free_tmp_debug_messengers(instance_data->tmp_messenger_create_infos, instance_data->tmp_debug_messengers);
397 instance_data->num_tmp_debug_messengers = 0;
398 }
399 if (instance_data->num_tmp_report_callbacks > 0) {
400 layer_free_tmp_report_callbacks(instance_data->tmp_report_create_infos, instance_data->tmp_report_callbacks);
401 instance_data->num_tmp_report_callbacks = 0;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600402 }
403
404 if (!skip) {
405 instance_data->dispatch_table.DestroyInstance(instance, pAllocator);
406
407 // Clean up logging callback, if any
Mark Young6ba8abe2017-11-09 10:37:04 -0700408 while (instance_data->logging_messenger.size() > 0) {
409 VkDebugUtilsMessengerEXT messenger = instance_data->logging_messenger.back();
410 layer_destroy_messenger_callback(instance_data->report_data, messenger, pAllocator);
411 instance_data->logging_messenger.pop_back();
412 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600413 while (instance_data->logging_callback.size() > 0) {
414 VkDebugReportCallbackEXT callback = instance_data->logging_callback.back();
Mark Young6ba8abe2017-11-09 10:37:04 -0700415 layer_destroy_report_callback(instance_data->report_data, callback, pAllocator);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600416 instance_data->logging_callback.pop_back();
417 }
418
Mark Young6ba8abe2017-11-09 10:37:04 -0700419 layer_debug_utils_destroy_instance(instance_data->report_data);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600420 }
421
422 FreeLayerDataPtr(key, instance_layer_data_map);
423}
424
425VKAPI_ATTR VkResult VKAPI_CALL vkCreateDebugReportCallbackEXT(VkInstance instance,
426 const VkDebugReportCallbackCreateInfoEXT *pCreateInfo,
427 const VkAllocationCallbacks *pAllocator,
428 VkDebugReportCallbackEXT *pMsgCallback) {
429 bool skip = parameter_validation_vkCreateDebugReportCallbackEXT(instance, pCreateInfo, pAllocator, pMsgCallback);
430 if (skip) return VK_ERROR_VALIDATION_FAILED_EXT;
431
432 auto instance_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map);
433 VkResult result = instance_data->dispatch_table.CreateDebugReportCallbackEXT(instance, pCreateInfo, pAllocator, pMsgCallback);
434 if (result == VK_SUCCESS) {
Mark Young6ba8abe2017-11-09 10:37:04 -0700435 result = layer_create_report_callback(instance_data->report_data, false, pCreateInfo, pAllocator, pMsgCallback);
436 // If something happened during this call, clean up the message callback that was created earlier in the lower levels
437 if (VK_SUCCESS != result) {
438 instance_data->dispatch_table.DestroyDebugReportCallbackEXT(instance, *pMsgCallback, pAllocator);
439 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600440 }
441 return result;
442}
443
444VKAPI_ATTR void VKAPI_CALL vkDestroyDebugReportCallbackEXT(VkInstance instance, VkDebugReportCallbackEXT msgCallback,
445 const VkAllocationCallbacks *pAllocator) {
446 bool skip = parameter_validation_vkDestroyDebugReportCallbackEXT(instance, msgCallback, pAllocator);
447 if (!skip) {
448 auto instance_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map);
449 instance_data->dispatch_table.DestroyDebugReportCallbackEXT(instance, msgCallback, pAllocator);
Mark Young6ba8abe2017-11-09 10:37:04 -0700450 layer_destroy_report_callback(instance_data->report_data, msgCallback, pAllocator);
451 }
452}
453
454VKAPI_ATTR VkResult VKAPI_CALL vkCreateDebugUtilsMessengerEXT(VkInstance instance,
455 const VkDebugUtilsMessengerCreateInfoEXT *pCreateInfo,
456 const VkAllocationCallbacks *pAllocator,
457 VkDebugUtilsMessengerEXT *pMessenger) {
458 bool skip = parameter_validation_vkCreateDebugUtilsMessengerEXT(instance, pCreateInfo, pAllocator, pMessenger);
459 if (skip) return VK_ERROR_VALIDATION_FAILED_EXT;
460
461 auto instance_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map);
462 VkResult result = instance_data->dispatch_table.CreateDebugUtilsMessengerEXT(instance, pCreateInfo, pAllocator, pMessenger);
463 if (VK_SUCCESS == result) {
464 result = layer_create_messenger_callback(instance_data->report_data, false, pCreateInfo, pAllocator, pMessenger);
465 // If something happened during this call, clean up the message callback that was created earlier in the lower levels
466 if (VK_SUCCESS != result) {
467 instance_data->dispatch_table.DestroyDebugUtilsMessengerEXT(instance, *pMessenger, pAllocator);
468 }
469 }
470 return result;
471}
472
473VKAPI_ATTR void VKAPI_CALL vkDestroyDebugUtilsMessengerEXT(VkInstance instance, VkDebugUtilsMessengerEXT messenger,
474 const VkAllocationCallbacks *pAllocator) {
475 bool skip = parameter_validation_vkDestroyDebugUtilsMessengerEXT(instance, messenger, pAllocator);
476 if (!skip) {
477 auto instance_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map);
478 instance_data->dispatch_table.DestroyDebugUtilsMessengerEXT(instance, messenger, pAllocator);
479 layer_destroy_messenger_callback(instance_data->report_data, messenger, pAllocator);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600480 }
481}
482
John Zulauf620755c2018-04-16 11:00:43 -0600483template <typename ExtensionState>
484static bool extension_state_by_name(const ExtensionState &extensions, const char *extension_name) {
485 if (!extension_name) return false; // null strings specify nothing
486 auto info = ExtensionState::get_info(extension_name);
487 bool state = info.state ? extensions.*(info.state) : false; // unknown extensions can't be enabled in extension struct
488 return state;
489}
490
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600491static bool ValidateDeviceCreateInfo(instance_layer_data *instance_data, VkPhysicalDevice physicalDevice,
John Zulauf620755c2018-04-16 11:00:43 -0600492 const VkDeviceCreateInfo *pCreateInfo, const DeviceExtensions &extensions) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600493 bool skip = false;
John Zulauf620755c2018-04-16 11:00:43 -0600494 bool maint1 = false;
495 bool negative_viewport = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600496
497 if ((pCreateInfo->enabledLayerCount > 0) && (pCreateInfo->ppEnabledLayerNames != NULL)) {
498 for (size_t i = 0; i < pCreateInfo->enabledLayerCount; i++) {
499 skip |= validate_string(instance_data->report_data, "vkCreateDevice", "pCreateInfo->ppEnabledLayerNames",
Mark Lobodzinskiebee3552018-05-29 09:55:54 -0600500 "VUID-VkDeviceCreateInfo-ppEnabledLayerNames-parameter", pCreateInfo->ppEnabledLayerNames[i]);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600501 }
502 }
503
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600504 if ((pCreateInfo->enabledExtensionCount > 0) && (pCreateInfo->ppEnabledExtensionNames != NULL)) {
John Zulauf620755c2018-04-16 11:00:43 -0600505 maint1 = extension_state_by_name(extensions, VK_KHR_MAINTENANCE1_EXTENSION_NAME);
506 negative_viewport = extension_state_by_name(extensions, VK_AMD_NEGATIVE_VIEWPORT_HEIGHT_EXTENSION_NAME);
507
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600508 for (size_t i = 0; i < pCreateInfo->enabledExtensionCount; i++) {
509 skip |= validate_string(instance_data->report_data, "vkCreateDevice", "pCreateInfo->ppEnabledExtensionNames",
Mark Lobodzinskiebee3552018-05-29 09:55:54 -0600510 "VUID-VkDeviceCreateInfo-ppEnabledExtensionNames-parameter",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600511 pCreateInfo->ppEnabledExtensionNames[i]);
Dave Houlton413a6782018-05-22 13:01:54 -0600512 skip |= validate_extension_reqs(instance_data, extensions, "VUID-vkCreateDevice-ppEnabledExtensionNames-01387",
513 "device", pCreateInfo->ppEnabledExtensionNames[i]);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600514 }
515 }
516
517 if (maint1 && negative_viewport) {
518 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600519 "VUID-VkDeviceCreateInfo-ppEnabledExtensionNames-00374",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600520 "VkDeviceCreateInfo->ppEnabledExtensionNames must not simultaneously include VK_KHR_maintenance1 and "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600521 "VK_AMD_negative_viewport_height.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600522 }
523
524 if (pCreateInfo->pNext != NULL && pCreateInfo->pEnabledFeatures) {
525 // Check for get_physical_device_properties2 struct
John Zulaufde972ac2017-10-26 12:07:05 -0600526 const auto *features2 = lvl_find_in_chain<VkPhysicalDeviceFeatures2KHR>(pCreateInfo->pNext);
527 if (features2) {
528 // Cannot include VkPhysicalDeviceFeatures2KHR and have non-null pEnabledFeatures
529 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600530 kVUID_PVError_InvalidUsage,
John Zulaufde972ac2017-10-26 12:07:05 -0600531 "VkDeviceCreateInfo->pNext includes a VkPhysicalDeviceFeatures2KHR struct when "
532 "pCreateInfo->pEnabledFeatures is non-NULL.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600533 }
534 }
535
536 // Validate pCreateInfo->pQueueCreateInfos
537 if (pCreateInfo->pQueueCreateInfos) {
538 std::unordered_set<uint32_t> set;
539
540 for (uint32_t i = 0; i < pCreateInfo->queueCreateInfoCount; ++i) {
541 const uint32_t requested_queue_family = pCreateInfo->pQueueCreateInfos[i].queueFamilyIndex;
542 if (requested_queue_family == VK_QUEUE_FAMILY_IGNORED) {
543 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT,
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600544 VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, HandleToUint64(physicalDevice),
Dave Houlton413a6782018-05-22 13:01:54 -0600545 "VUID-VkDeviceQueueCreateInfo-queueFamilyIndex-00381",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600546 "vkCreateDevice: pCreateInfo->pQueueCreateInfos[%" PRIu32
Dave Houltona9df0ce2018-02-07 10:51:23 -0700547 "].queueFamilyIndex is VK_QUEUE_FAMILY_IGNORED, but it is required to provide a valid queue family "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600548 "index value.",
549 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600550 } else if (set.count(requested_queue_family)) {
551 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT,
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600552 VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, HandleToUint64(physicalDevice),
Dave Houlton413a6782018-05-22 13:01:54 -0600553 "VUID-VkDeviceCreateInfo-queueFamilyIndex-00372",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600554 "vkCreateDevice: pCreateInfo->pQueueCreateInfos[%" PRIu32 "].queueFamilyIndex (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600555 ") is not unique within pCreateInfo->pQueueCreateInfos array.",
556 i, requested_queue_family);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600557 } else {
558 set.insert(requested_queue_family);
559 }
560
561 if (pCreateInfo->pQueueCreateInfos[i].pQueuePriorities != nullptr) {
562 for (uint32_t j = 0; j < pCreateInfo->pQueueCreateInfos[i].queueCount; ++j) {
563 const float queue_priority = pCreateInfo->pQueueCreateInfos[i].pQueuePriorities[j];
564 if (!(queue_priority >= 0.f) || !(queue_priority <= 1.f)) {
565 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT,
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600566 VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, HandleToUint64(physicalDevice),
Dave Houlton413a6782018-05-22 13:01:54 -0600567 "VUID-VkDeviceQueueCreateInfo-pQueuePriorities-00383",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600568 "vkCreateDevice: pCreateInfo->pQueueCreateInfos[%" PRIu32 "].pQueuePriorities[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600569 "] (=%f) is not between 0 and 1 (inclusive).",
570 i, j, queue_priority);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600571 }
572 }
573 }
574 }
575 }
576
577 return skip;
578}
579
580VKAPI_ATTR VkResult VKAPI_CALL vkCreateDevice(VkPhysicalDevice physicalDevice, const VkDeviceCreateInfo *pCreateInfo,
581 const VkAllocationCallbacks *pAllocator, VkDevice *pDevice) {
582 // NOTE: Don't validate physicalDevice or any dispatchable object as the first parameter. We couldn't get here if it was wrong!
583
584 VkResult result = VK_ERROR_VALIDATION_FAILED_EXT;
585 bool skip = false;
586 auto my_instance_data = GetLayerDataPtr(get_dispatch_key(physicalDevice), instance_layer_data_map);
587 assert(my_instance_data != nullptr);
John Zulauf620755c2018-04-16 11:00:43 -0600588
589 // Query and save physical device limits for this device, needed for validation
590 VkPhysicalDeviceProperties device_properties = {};
591 my_instance_data->dispatch_table.GetPhysicalDeviceProperties(physicalDevice, &device_properties);
592
John Zulauf1909e6a2018-09-05 11:43:11 -0600593 // Setup the validation tables based on the application API version from the instance and the capabilities of the device driver.
594 uint32_t effective_api_version = std::min(device_properties.apiVersion, my_instance_data->api_version);
John Zulauf620755c2018-04-16 11:00:43 -0600595 DeviceExtensions extensions;
John Zulauf1909e6a2018-09-05 11:43:11 -0600596 uint32_t api_version = extensions.InitFromDeviceCreateInfo(&my_instance_data->extensions, effective_api_version, pCreateInfo);
John Zulauf620755c2018-04-16 11:00:43 -0600597
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600598 std::unique_lock<std::mutex> lock(global_lock);
599
600 skip |= parameter_validation_vkCreateDevice(physicalDevice, pCreateInfo, pAllocator, pDevice);
601
John Zulauf620755c2018-04-16 11:00:43 -0600602 if (pCreateInfo != NULL) skip |= ValidateDeviceCreateInfo(my_instance_data, physicalDevice, pCreateInfo, extensions);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600603
604 if (!skip) {
605 VkLayerDeviceCreateInfo *chain_info = get_chain_info(pCreateInfo, VK_LAYER_LINK_INFO);
606 assert(chain_info != nullptr);
607 assert(chain_info->u.pLayerInfo != nullptr);
608
609 PFN_vkGetInstanceProcAddr fpGetInstanceProcAddr = chain_info->u.pLayerInfo->pfnNextGetInstanceProcAddr;
610 PFN_vkGetDeviceProcAddr fpGetDeviceProcAddr = chain_info->u.pLayerInfo->pfnNextGetDeviceProcAddr;
611 PFN_vkCreateDevice fpCreateDevice = (PFN_vkCreateDevice)fpGetInstanceProcAddr(my_instance_data->instance, "vkCreateDevice");
612 if (fpCreateDevice == NULL) {
613 return VK_ERROR_INITIALIZATION_FAILED;
614 }
615
616 // Advance the link info for the next element on the chain
617 chain_info->u.pLayerInfo = chain_info->u.pLayerInfo->pNext;
618
619 lock.unlock();
620
621 result = fpCreateDevice(physicalDevice, pCreateInfo, pAllocator, pDevice);
622
623 lock.lock();
624
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600625 if (result == VK_SUCCESS) {
626 layer_data *my_device_data = GetLayerDataPtr(get_dispatch_key(*pDevice), layer_data_map);
627 assert(my_device_data != nullptr);
628
Mark Young6ba8abe2017-11-09 10:37:04 -0700629 my_device_data->report_data = layer_debug_utils_create_device(my_instance_data->report_data, *pDevice);
John Zulauf9b777302018-10-08 11:15:51 -0600630 layer_init_device_dispatch_table(*pDevice, &my_device_data->dispatch_table, fpGetDeviceProcAddr);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600631
John Zulauf620755c2018-04-16 11:00:43 -0600632 my_device_data->api_version = api_version;
633 my_device_data->extensions = extensions;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600634
635 // Store createdevice data
636 if ((pCreateInfo != nullptr) && (pCreateInfo->pQueueCreateInfos != nullptr)) {
637 for (uint32_t i = 0; i < pCreateInfo->queueCreateInfoCount; ++i) {
638 my_device_data->queueFamilyIndexMap.insert(std::make_pair(pCreateInfo->pQueueCreateInfos[i].queueFamilyIndex,
639 pCreateInfo->pQueueCreateInfos[i].queueCount));
640 }
641 }
642
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600643 memcpy(&my_device_data->device_limits, &device_properties.limits, sizeof(VkPhysicalDeviceLimits));
644 my_device_data->physical_device = physicalDevice;
645 my_device_data->device = *pDevice;
646
Jeff Bolz5d2b7432018-09-06 10:32:36 -0500647 if (my_device_data->extensions.vk_nv_shading_rate_image) {
648 // Get the needed shading rate image limits
649 auto shading_rate_image_props = lvl_init_struct<VkPhysicalDeviceShadingRateImagePropertiesNV>();
650 auto prop2 = lvl_init_struct<VkPhysicalDeviceProperties2KHR>(&shading_rate_image_props);
651 my_instance_data->dispatch_table.GetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
652 my_device_data->phys_dev_ext_props.shading_rate_image_props = shading_rate_image_props;
653 }
654
Jeff Bolz45bf7d62018-09-18 15:39:58 -0500655 if (my_device_data->extensions.vk_nv_mesh_shader) {
656 // Get the needed mesh shader limits
657 auto mesh_shader_props = lvl_init_struct<VkPhysicalDeviceMeshShaderPropertiesNV>();
658 auto prop2 = lvl_init_struct<VkPhysicalDeviceProperties2KHR>(&mesh_shader_props);
659 my_instance_data->dispatch_table.GetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
660 my_device_data->phys_dev_ext_props.mesh_shader_props = mesh_shader_props;
661 }
662
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600663 // Save app-enabled features in this device's layer_data structure
John Zulauf1bde5bb2017-10-18 18:21:23 -0600664 // The enabled features can come from either pEnabledFeatures, or from the pNext chain
665 const VkPhysicalDeviceFeatures *enabled_features_found = pCreateInfo->pEnabledFeatures;
666 if ((nullptr == enabled_features_found) && my_device_data->extensions.vk_khr_get_physical_device_properties_2) {
John Zulaufde972ac2017-10-26 12:07:05 -0600667 const auto *features2 = lvl_find_in_chain<VkPhysicalDeviceFeatures2KHR>(pCreateInfo->pNext);
668 if (features2) {
669 enabled_features_found = &(features2->features);
John Zulauf1bde5bb2017-10-18 18:21:23 -0600670 }
671 }
672 if (enabled_features_found) {
Dave Houltonb3bbec72018-01-17 10:13:33 -0700673 my_device_data->physical_device_features = *enabled_features_found;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600674 } else {
675 memset(&my_device_data->physical_device_features, 0, sizeof(VkPhysicalDeviceFeatures));
676 }
677 }
678 }
679
680 return result;
681}
682
683VKAPI_ATTR void VKAPI_CALL vkDestroyDevice(VkDevice device, const VkAllocationCallbacks *pAllocator) {
684 dispatch_key key = get_dispatch_key(device);
685 bool skip = false;
686 layer_data *device_data = GetLayerDataPtr(key, layer_data_map);
687 {
688 std::unique_lock<std::mutex> lock(global_lock);
689 skip |= parameter_validation_vkDestroyDevice(device, pAllocator);
690 }
691
692 if (!skip) {
Mark Young6ba8abe2017-11-09 10:37:04 -0700693 layer_debug_utils_destroy_device(device);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600694 device_data->dispatch_table.DestroyDevice(device, pAllocator);
695 }
696 FreeLayerDataPtr(key, layer_data_map);
697}
698
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600699bool pv_vkGetDeviceQueue(VkDevice device, uint32_t queueFamilyIndex, uint32_t queueIndex, VkQueue *pQueue) {
700 bool skip = false;
701 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
702
Dave Houlton413a6782018-05-22 13:01:54 -0600703 skip |= ValidateDeviceQueueFamily(device_data, queueFamilyIndex, "vkGetDeviceQueue", "queueFamilyIndex",
704 "VUID-vkGetDeviceQueue-queueFamilyIndex-00384");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600705 const auto &queue_data = device_data->queueFamilyIndexMap.find(queueFamilyIndex);
706 if (queue_data != device_data->queueFamilyIndexMap.end() && queue_data->second <= queueIndex) {
707 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -0600708 HandleToUint64(device), "VUID-vkGetDeviceQueue-queueIndex-00385",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600709 "vkGetDeviceQueue: queueIndex (=%" PRIu32
Dave Houltona9df0ce2018-02-07 10:51:23 -0700710 ") is not less than the number of queues requested from queueFamilyIndex (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600711 ") when the device was created (i.e. is not less than %" PRIu32 ").",
712 queueIndex, queueFamilyIndex, queue_data->second);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600713 }
714 return skip;
715}
716
717VKAPI_ATTR VkResult VKAPI_CALL vkCreateCommandPool(VkDevice device, const VkCommandPoolCreateInfo *pCreateInfo,
718 const VkAllocationCallbacks *pAllocator, VkCommandPool *pCommandPool) {
719 layer_data *local_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
720 bool skip = false;
721 VkResult result = VK_ERROR_VALIDATION_FAILED_EXT;
722 std::unique_lock<std::mutex> lock(global_lock);
723
724 skip |= ValidateDeviceQueueFamily(local_data, pCreateInfo->queueFamilyIndex, "vkCreateCommandPool",
Dave Houlton341c0052018-06-21 15:00:45 -0600725 "pCreateInfo->queueFamilyIndex", "VUID-vkCreateCommandPool-queueFamilyIndex-01937");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600726
727 skip |= parameter_validation_vkCreateCommandPool(device, pCreateInfo, pAllocator, pCommandPool);
728
729 lock.unlock();
730 if (!skip) {
731 result = local_data->dispatch_table.CreateCommandPool(device, pCreateInfo, pAllocator, pCommandPool);
732 }
733 return result;
734}
735
736VKAPI_ATTR VkResult VKAPI_CALL vkCreateQueryPool(VkDevice device, const VkQueryPoolCreateInfo *pCreateInfo,
737 const VkAllocationCallbacks *pAllocator, VkQueryPool *pQueryPool) {
738 VkResult result = VK_ERROR_VALIDATION_FAILED_EXT;
739 bool skip = false;
740 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
741
742 skip |= parameter_validation_vkCreateQueryPool(device, pCreateInfo, pAllocator, pQueryPool);
743
744 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
745 if (pCreateInfo != nullptr) {
746 // If queryType is VK_QUERY_TYPE_PIPELINE_STATISTICS, pipelineStatistics must be a valid combination of
747 // VkQueryPipelineStatisticFlagBits values
748 if ((pCreateInfo->queryType == VK_QUERY_TYPE_PIPELINE_STATISTICS) && (pCreateInfo->pipelineStatistics != 0) &&
749 ((pCreateInfo->pipelineStatistics & (~AllVkQueryPipelineStatisticFlagBits)) != 0)) {
750 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600751 "VUID-VkQueryPoolCreateInfo-queryType-00792",
Dave Houltona9df0ce2018-02-07 10:51:23 -0700752 "vkCreateQueryPool(): if pCreateInfo->queryType is VK_QUERY_TYPE_PIPELINE_STATISTICS, "
753 "pCreateInfo->pipelineStatistics must be a valid combination of VkQueryPipelineStatisticFlagBits "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600754 "values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600755 }
756 }
757 if (!skip) {
758 result = device_data->dispatch_table.CreateQueryPool(device, pCreateInfo, pAllocator, pQueryPool);
759 }
760 return result;
761}
762
Tobias Hectord942eb92018-10-22 15:18:56 +0100763template <typename T>
764static void RecordRenderPass(layer_data *device_data, VkRenderPass renderPass, const T *pCreateInfo) {
765 auto &renderpass_state = device_data->renderpasses_states[renderPass];
766
767 for (uint32_t subpass = 0; subpass < pCreateInfo->subpassCount; ++subpass) {
768 bool uses_color = false;
769 for (uint32_t i = 0; i < pCreateInfo->pSubpasses[subpass].colorAttachmentCount && !uses_color; ++i)
770 if (pCreateInfo->pSubpasses[subpass].pColorAttachments[i].attachment != VK_ATTACHMENT_UNUSED) uses_color = true;
771
772 bool uses_depthstencil = false;
773 if (pCreateInfo->pSubpasses[subpass].pDepthStencilAttachment)
774 if (pCreateInfo->pSubpasses[subpass].pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED)
775 uses_depthstencil = true;
776
777 if (uses_color) renderpass_state.subpasses_using_color_attachment.insert(subpass);
778 if (uses_depthstencil) renderpass_state.subpasses_using_depthstencil_attachment.insert(subpass);
779 }
780}
781
Petr Krause91f7a12017-12-14 20:57:36 +0100782VKAPI_ATTR VkResult VKAPI_CALL vkCreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo,
783 const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass) {
784 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
785 bool skip = false;
786 VkResult result = VK_ERROR_VALIDATION_FAILED_EXT;
787
788 {
789 std::unique_lock<std::mutex> lock(global_lock);
790 skip |= parameter_validation_vkCreateRenderPass(device, pCreateInfo, pAllocator, pRenderPass);
791
Dave Houltonb3bbec72018-01-17 10:13:33 -0700792 typedef bool (*PFN_manual_vkCreateRenderPass)(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo,
793 const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass);
Petr Krause91f7a12017-12-14 20:57:36 +0100794 PFN_manual_vkCreateRenderPass custom_func = (PFN_manual_vkCreateRenderPass)custom_functions["vkCreateRenderPass"];
795 if (custom_func != nullptr) {
796 skip |= custom_func(device, pCreateInfo, pAllocator, pRenderPass);
797 }
798 }
799
800 if (!skip) {
801 result = device_data->dispatch_table.CreateRenderPass(device, pCreateInfo, pAllocator, pRenderPass);
802
803 // track the state necessary for checking vkCreateGraphicsPipeline (subpass usage of depth and color attachments)
804 if (result == VK_SUCCESS) {
805 std::unique_lock<std::mutex> lock(global_lock);
Tobias Hectord942eb92018-10-22 15:18:56 +0100806 RecordRenderPass(device_data, *pRenderPass, pCreateInfo);
807 }
808 }
809 return result;
810}
Petr Krause91f7a12017-12-14 20:57:36 +0100811
Tobias Hectord942eb92018-10-22 15:18:56 +0100812VKAPI_ATTR VkResult VKAPI_CALL vkCreateRenderPass2KHR(VkDevice device, const VkRenderPassCreateInfo2KHR *pCreateInfo,
813 const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass) {
814 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
815 bool skip = false;
816 VkResult result = VK_ERROR_VALIDATION_FAILED_EXT;
Petr Krause91f7a12017-12-14 20:57:36 +0100817
Tobias Hectord942eb92018-10-22 15:18:56 +0100818 {
819 std::unique_lock<std::mutex> lock(global_lock);
820 skip |= parameter_validation_vkCreateRenderPass2KHR(device, pCreateInfo, pAllocator, pRenderPass);
Petr Krause91f7a12017-12-14 20:57:36 +0100821
Tobias Hectord942eb92018-10-22 15:18:56 +0100822 typedef bool (*PFN_manual_vkCreateRenderPass2KHR)(VkDevice device, const VkRenderPassCreateInfo2KHR *pCreateInfo,
823 const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass);
824 PFN_manual_vkCreateRenderPass2KHR custom_func =
825 (PFN_manual_vkCreateRenderPass2KHR)custom_functions["vkCreateRenderPass2KHR"];
826 if (custom_func != nullptr) {
827 skip |= custom_func(device, pCreateInfo, pAllocator, pRenderPass);
828 }
829 }
830
831 if (!skip) {
832 result = device_data->dispatch_table.CreateRenderPass2KHR(device, pCreateInfo, pAllocator, pRenderPass);
833
834 // track the state necessary for checking vkCreateGraphicsPipeline (subpass usage of depth and color attachments)
835 if (result == VK_SUCCESS) {
836 std::unique_lock<std::mutex> lock(global_lock);
837 RecordRenderPass(device_data, *pRenderPass, pCreateInfo);
Petr Krause91f7a12017-12-14 20:57:36 +0100838 }
839 }
840 return result;
841}
842
843VKAPI_ATTR void VKAPI_CALL vkDestroyRenderPass(VkDevice device, VkRenderPass renderPass, const VkAllocationCallbacks *pAllocator) {
844 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
845 bool skip = false;
846
847 {
848 std::unique_lock<std::mutex> lock(global_lock);
849 skip |= parameter_validation_vkDestroyRenderPass(device, renderPass, pAllocator);
850
Dave Houltonb3bbec72018-01-17 10:13:33 -0700851 typedef bool (*PFN_manual_vkDestroyRenderPass)(VkDevice device, VkRenderPass renderPass,
852 const VkAllocationCallbacks *pAllocator);
Petr Krause91f7a12017-12-14 20:57:36 +0100853 PFN_manual_vkDestroyRenderPass custom_func = (PFN_manual_vkDestroyRenderPass)custom_functions["vkDestroyRenderPass"];
854 if (custom_func != nullptr) {
855 skip |= custom_func(device, renderPass, pAllocator);
856 }
857 }
858
859 if (!skip) {
860 device_data->dispatch_table.DestroyRenderPass(device, renderPass, pAllocator);
861
862 // track the state necessary for checking vkCreateGraphicsPipeline (subpass usage of depth and color attachments)
863 {
864 std::unique_lock<std::mutex> lock(global_lock);
865 device_data->renderpasses_states.erase(renderPass);
866 }
867 }
868}
869
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600870bool pv_vkCreateBuffer(VkDevice device, const VkBufferCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
871 VkBuffer *pBuffer) {
872 bool skip = false;
873 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
874 debug_report_data *report_data = device_data->report_data;
875
Mark Lobodzinski88529492018-04-01 10:38:15 -0600876 const LogMiscParams log_misc{report_data, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, VK_NULL_HANDLE, "vkCreateBuffer"};
Petr Krause5c37652018-01-05 04:05:12 +0100877
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600878 if (pCreateInfo != nullptr) {
Dave Houlton413a6782018-05-22 13:01:54 -0600879 skip |= ValidateGreaterThanZero(pCreateInfo->size, "pCreateInfo->size", "VUID-VkBufferCreateInfo-size-00912", log_misc);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600880
881 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
882 if (pCreateInfo->sharingMode == VK_SHARING_MODE_CONCURRENT) {
883 // If sharingMode is VK_SHARING_MODE_CONCURRENT, queueFamilyIndexCount must be greater than 1
884 if (pCreateInfo->queueFamilyIndexCount <= 1) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600885 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600886 "VUID-VkBufferCreateInfo-sharingMode-00914",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600887 "vkCreateBuffer: if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600888 "pCreateInfo->queueFamilyIndexCount must be greater than 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600889 }
890
891 // If sharingMode is VK_SHARING_MODE_CONCURRENT, pQueueFamilyIndices must be a pointer to an array of
892 // queueFamilyIndexCount uint32_t values
893 if (pCreateInfo->pQueueFamilyIndices == nullptr) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600894 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600895 "VUID-VkBufferCreateInfo-sharingMode-00913",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600896 "vkCreateBuffer: if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
897 "pCreateInfo->pQueueFamilyIndices must be a pointer to an array of "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600898 "pCreateInfo->queueFamilyIndexCount uint32_t values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600899 } else {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600900 skip |= ValidateQueueFamilies(device_data, pCreateInfo->queueFamilyIndexCount, pCreateInfo->pQueueFamilyIndices,
Dave Houlton413a6782018-05-22 13:01:54 -0600901 "vkCreateBuffer", "pCreateInfo->pQueueFamilyIndices", kVUID_PVError_InvalidUsage,
902 kVUID_PVError_InvalidUsage, false);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600903 }
904 }
905
906 // If flags contains VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT or VK_BUFFER_CREATE_SPARSE_ALIASED_BIT, it must also contain
907 // VK_BUFFER_CREATE_SPARSE_BINDING_BIT
908 if (((pCreateInfo->flags & (VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT | VK_BUFFER_CREATE_SPARSE_ALIASED_BIT)) != 0) &&
909 ((pCreateInfo->flags & VK_BUFFER_CREATE_SPARSE_BINDING_BIT) != VK_BUFFER_CREATE_SPARSE_BINDING_BIT)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600910 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600911 "VUID-VkBufferCreateInfo-flags-00918",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600912 "vkCreateBuffer: if pCreateInfo->flags contains VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT or "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600913 "VK_BUFFER_CREATE_SPARSE_ALIASED_BIT, it must also contain VK_BUFFER_CREATE_SPARSE_BINDING_BIT.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600914 }
915 }
916
917 return skip;
918}
919
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600920bool pv_vkCreateImage(VkDevice device, const VkImageCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
921 VkImage *pImage) {
922 bool skip = false;
923 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
924 debug_report_data *report_data = device_data->report_data;
925
Mark Lobodzinski88529492018-04-01 10:38:15 -0600926 const LogMiscParams log_misc{report_data, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, VK_NULL_HANDLE, "vkCreateImage"};
Petr Krause5c37652018-01-05 04:05:12 +0100927
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600928 if (pCreateInfo != nullptr) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600929 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
930 if (pCreateInfo->sharingMode == VK_SHARING_MODE_CONCURRENT) {
931 // If sharingMode is VK_SHARING_MODE_CONCURRENT, queueFamilyIndexCount must be greater than 1
932 if (pCreateInfo->queueFamilyIndexCount <= 1) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600933 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600934 "VUID-VkImageCreateInfo-sharingMode-00942",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600935 "vkCreateImage(): if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600936 "pCreateInfo->queueFamilyIndexCount must be greater than 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600937 }
938
939 // If sharingMode is VK_SHARING_MODE_CONCURRENT, pQueueFamilyIndices must be a pointer to an array of
940 // queueFamilyIndexCount uint32_t values
941 if (pCreateInfo->pQueueFamilyIndices == nullptr) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600942 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600943 "VUID-VkImageCreateInfo-sharingMode-00941",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600944 "vkCreateImage(): if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
945 "pCreateInfo->pQueueFamilyIndices must be a pointer to an array of "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600946 "pCreateInfo->queueFamilyIndexCount uint32_t values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600947 } else {
Dave Houlton413a6782018-05-22 13:01:54 -0600948 skip |= ValidateQueueFamilies(device_data, pCreateInfo->queueFamilyIndexCount, pCreateInfo->pQueueFamilyIndices,
949 "vkCreateImage", "pCreateInfo->pQueueFamilyIndices", kVUID_PVError_InvalidUsage,
950 kVUID_PVError_InvalidUsage, false);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600951 }
952 }
953
Dave Houlton413a6782018-05-22 13:01:54 -0600954 skip |= ValidateGreaterThanZero(pCreateInfo->extent.width, "pCreateInfo->extent.width",
955 "VUID-VkImageCreateInfo-extent-00944", log_misc);
956 skip |= ValidateGreaterThanZero(pCreateInfo->extent.height, "pCreateInfo->extent.height",
957 "VUID-VkImageCreateInfo-extent-00945", log_misc);
958 skip |= ValidateGreaterThanZero(pCreateInfo->extent.depth, "pCreateInfo->extent.depth",
959 "VUID-VkImageCreateInfo-extent-00946", log_misc);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600960
Dave Houlton413a6782018-05-22 13:01:54 -0600961 skip |= ValidateGreaterThanZero(pCreateInfo->mipLevels, "pCreateInfo->mipLevels", "VUID-VkImageCreateInfo-mipLevels-00947",
962 log_misc);
963 skip |= ValidateGreaterThanZero(pCreateInfo->arrayLayers, "pCreateInfo->arrayLayers",
964 "VUID-VkImageCreateInfo-arrayLayers-00948", log_misc);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600965
Dave Houlton130c0212018-01-29 13:39:56 -0700966 // InitialLayout must be PREINITIALIZED or UNDEFINED
Dave Houltone19e20d2018-02-02 16:32:41 -0700967 if ((pCreateInfo->initialLayout != VK_IMAGE_LAYOUT_UNDEFINED) &&
968 (pCreateInfo->initialLayout != VK_IMAGE_LAYOUT_PREINITIALIZED)) {
969 skip |= log_msg(
Dave Houlton413a6782018-05-22 13:01:54 -0600970 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
971 "VUID-VkImageCreateInfo-initialLayout-00993",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600972 "vkCreateImage(): initialLayout is %s, must be VK_IMAGE_LAYOUT_UNDEFINED or VK_IMAGE_LAYOUT_PREINITIALIZED.",
973 string_VkImageLayout(pCreateInfo->initialLayout));
Dave Houlton130c0212018-01-29 13:39:56 -0700974 }
975
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600976 // If imageType is VK_IMAGE_TYPE_1D, both extent.height and extent.depth must be 1
Petr Kraus3ac9e812018-03-13 12:31:08 +0100977 if ((pCreateInfo->imageType == VK_IMAGE_TYPE_1D) &&
978 ((pCreateInfo->extent.height != 1) || (pCreateInfo->extent.depth != 1))) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600979 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600980 "VUID-VkImageCreateInfo-imageType-00956",
Dave Houltona9df0ce2018-02-07 10:51:23 -0700981 "vkCreateImage(): if pCreateInfo->imageType is VK_IMAGE_TYPE_1D, both pCreateInfo->extent.height and "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600982 "pCreateInfo->extent.depth must be 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600983 }
984
985 if (pCreateInfo->imageType == VK_IMAGE_TYPE_2D) {
Petr Kraus3f433212018-03-13 12:31:27 +0100986 if (pCreateInfo->flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) {
987 if (pCreateInfo->extent.width != pCreateInfo->extent.height) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600988 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -0600989 VK_NULL_HANDLE, "VUID-VkImageCreateInfo-imageType-00954",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600990 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT, but "
991 "pCreateInfo->extent.width (=%" PRIu32 ") and pCreateInfo->extent.height (=%" PRIu32
992 ") are not equal.",
993 pCreateInfo->extent.width, pCreateInfo->extent.height);
Petr Kraus3f433212018-03-13 12:31:27 +0100994 }
995
996 if (pCreateInfo->arrayLayers < 6) {
997 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -0600998 VK_NULL_HANDLE, "VUID-VkImageCreateInfo-imageType-00954",
Petr Kraus3f433212018-03-13 12:31:27 +0100999 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT, but "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001000 "pCreateInfo->arrayLayers (=%" PRIu32 ") is not greater than or equal to 6.",
1001 pCreateInfo->arrayLayers);
Petr Kraus3f433212018-03-13 12:31:27 +01001002 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001003 }
1004
1005 if (pCreateInfo->extent.depth != 1) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06001006 skip |=
1007 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001008 "VUID-VkImageCreateInfo-imageType-00957",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001009 "vkCreateImage(): if pCreateInfo->imageType is VK_IMAGE_TYPE_2D, pCreateInfo->extent.depth must be 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001010 }
1011 }
1012
Dave Houlton130c0212018-01-29 13:39:56 -07001013 // 3D image may have only 1 layer
1014 if ((pCreateInfo->imageType == VK_IMAGE_TYPE_3D) && (pCreateInfo->arrayLayers != 1)) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06001015 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001016 "VUID-VkImageCreateInfo-imageType-00961",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001017 "vkCreateImage(): if pCreateInfo->imageType is VK_IMAGE_TYPE_3D, pCreateInfo->arrayLayers must be 1.");
Dave Houlton130c0212018-01-29 13:39:56 -07001018 }
1019
1020 // If multi-sample, validate type, usage, tiling and mip levels.
1021 if ((pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT) &&
1022 ((pCreateInfo->imageType != VK_IMAGE_TYPE_2D) || (pCreateInfo->flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) ||
Shannon McPhersona886c2a2018-10-12 14:38:20 -06001023 (pCreateInfo->mipLevels != 1) || (pCreateInfo->tiling != VK_IMAGE_TILING_OPTIMAL))) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001024 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Shannon McPhersona886c2a2018-10-12 14:38:20 -06001025 "VUID-VkImageCreateInfo-samples-02257",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001026 "vkCreateImage(): Multi-sample image with incompatible type, usage, tiling, or mips.");
Dave Houlton130c0212018-01-29 13:39:56 -07001027 }
1028
1029 if (0 != (pCreateInfo->usage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT)) {
1030 VkImageUsageFlags legal_flags = (VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT | VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT |
1031 VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT);
1032 // At least one of the legal attachment bits must be set
1033 if (0 == (pCreateInfo->usage & legal_flags)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001034 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001035 "VUID-VkImageCreateInfo-usage-00966",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001036 "vkCreateImage(): Transient attachment image without a compatible attachment flag set.");
Dave Houlton130c0212018-01-29 13:39:56 -07001037 }
1038 // No flags other than the legal attachment bits may be set
1039 legal_flags |= VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT;
1040 if (0 != (pCreateInfo->usage & ~legal_flags)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001041 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001042 "VUID-VkImageCreateInfo-usage-00963",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001043 "vkCreateImage(): Transient attachment image with incompatible usage flags set.");
Dave Houlton130c0212018-01-29 13:39:56 -07001044 }
1045 }
1046
Jeff Bolzef40fec2018-09-01 22:04:34 -05001047 // mipLevels must be less than or equal to the number of levels in the complete mipmap chain
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001048 uint32_t maxDim = std::max(std::max(pCreateInfo->extent.width, pCreateInfo->extent.height), pCreateInfo->extent.depth);
Jeff Bolzef40fec2018-09-01 22:04:34 -05001049 // Max mip levels is different for corner-sampled images vs normal images.
Dave Houlton142c4cb2018-10-17 15:04:41 -06001050 uint32_t maxMipLevels = (pCreateInfo->flags & VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV) ? (uint32_t)(ceil(log2(maxDim)))
1051 : (uint32_t)(floor(log2(maxDim)) + 1);
Jeff Bolzef40fec2018-09-01 22:04:34 -05001052 if (maxDim > 0 && pCreateInfo->mipLevels > maxMipLevels) {
Dave Houlton413a6782018-05-22 13:01:54 -06001053 skip |=
1054 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1055 "VUID-VkImageCreateInfo-mipLevels-00958",
1056 "vkCreateImage(): pCreateInfo->mipLevels must be less than or equal to "
1057 "floor(log2(max(pCreateInfo->extent.width, pCreateInfo->extent.height, pCreateInfo->extent.depth)))+1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001058 }
1059
Mark Lobodzinski69259c52018-09-18 15:14:58 -06001060 if ((pCreateInfo->flags & VK_IMAGE_CREATE_2D_ARRAY_COMPATIBLE_BIT) && (pCreateInfo->imageType != VK_IMAGE_TYPE_3D)) {
1061 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, VK_NULL_HANDLE,
1062 "VUID-VkImageCreateInfo-flags-00950",
1063 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_2D_ARRAY_COMPATIBLE_BIT but "
1064 "pCreateInfo->imageType is not VK_IMAGE_TYPE_3D.");
1065 }
1066
Petr Krausb6f97802018-03-13 12:31:39 +01001067 if ((pCreateInfo->flags & VK_IMAGE_CREATE_SPARSE_BINDING_BIT) && (!device_data->physical_device_features.sparseBinding)) {
1068 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, VK_NULL_HANDLE,
Dave Houlton413a6782018-05-22 13:01:54 -06001069 "VUID-VkImageCreateInfo-flags-00969",
Petr Krausb6f97802018-03-13 12:31:39 +01001070 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_SPARSE_BINDING_BIT, but the "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001071 "VkPhysicalDeviceFeatures::sparseBinding feature is disabled.");
Petr Krausb6f97802018-03-13 12:31:39 +01001072 }
1073
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001074 // If flags contains VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT or VK_IMAGE_CREATE_SPARSE_ALIASED_BIT, it must also contain
1075 // VK_IMAGE_CREATE_SPARSE_BINDING_BIT
1076 if (((pCreateInfo->flags & (VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT | VK_IMAGE_CREATE_SPARSE_ALIASED_BIT)) != 0) &&
1077 ((pCreateInfo->flags & VK_IMAGE_CREATE_SPARSE_BINDING_BIT) != VK_IMAGE_CREATE_SPARSE_BINDING_BIT)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001078 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001079 "VUID-VkImageCreateInfo-flags-00987",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001080 "vkCreateImage: if pCreateInfo->flags contains VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT or "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001081 "VK_IMAGE_CREATE_SPARSE_ALIASED_BIT, it must also contain VK_IMAGE_CREATE_SPARSE_BINDING_BIT.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001082 }
1083
1084 // Check for combinations of attributes that are incompatible with having VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT set
1085 if ((pCreateInfo->flags & VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT) != 0) {
1086 // Linear tiling is unsupported
1087 if (VK_IMAGE_TILING_LINEAR == pCreateInfo->tiling) {
Dave Houlton413a6782018-05-22 13:01:54 -06001088 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1089 kVUID_PVError_InvalidUsage,
1090 "vkCreateImage: if pCreateInfo->flags contains VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT then image "
1091 "tiling of VK_IMAGE_TILING_LINEAR is not supported");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001092 }
1093
1094 // Sparse 1D image isn't valid
1095 if (VK_IMAGE_TYPE_1D == pCreateInfo->imageType) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001096 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001097 "VUID-VkImageCreateInfo-imageType-00970",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001098 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 1D image.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001099 }
1100
1101 // Sparse 2D image when device doesn't support it
1102 if ((VK_FALSE == device_data->physical_device_features.sparseResidencyImage2D) &&
1103 (VK_IMAGE_TYPE_2D == pCreateInfo->imageType)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001104 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001105 "VUID-VkImageCreateInfo-imageType-00971",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001106 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 2D image if corresponding "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001107 "feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001108 }
1109
1110 // Sparse 3D image when device doesn't support it
1111 if ((VK_FALSE == device_data->physical_device_features.sparseResidencyImage3D) &&
1112 (VK_IMAGE_TYPE_3D == pCreateInfo->imageType)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001113 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001114 "VUID-VkImageCreateInfo-imageType-00972",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001115 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 3D image if corresponding "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001116 "feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001117 }
1118
1119 // Multi-sample 2D image when device doesn't support it
1120 if (VK_IMAGE_TYPE_2D == pCreateInfo->imageType) {
1121 if ((VK_FALSE == device_data->physical_device_features.sparseResidency2Samples) &&
1122 (VK_SAMPLE_COUNT_2_BIT == pCreateInfo->samples)) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07001123 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001124 "VUID-VkImageCreateInfo-imageType-00973",
Dave Houltona9df0ce2018-02-07 10:51:23 -07001125 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 2-sample image if "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001126 "corresponding feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001127 } else if ((VK_FALSE == device_data->physical_device_features.sparseResidency4Samples) &&
1128 (VK_SAMPLE_COUNT_4_BIT == pCreateInfo->samples)) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07001129 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001130 "VUID-VkImageCreateInfo-imageType-00974",
Dave Houltona9df0ce2018-02-07 10:51:23 -07001131 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 4-sample image if "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001132 "corresponding feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001133 } else if ((VK_FALSE == device_data->physical_device_features.sparseResidency8Samples) &&
1134 (VK_SAMPLE_COUNT_8_BIT == pCreateInfo->samples)) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07001135 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001136 "VUID-VkImageCreateInfo-imageType-00975",
Dave Houltona9df0ce2018-02-07 10:51:23 -07001137 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 8-sample image if "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001138 "corresponding feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001139 } else if ((VK_FALSE == device_data->physical_device_features.sparseResidency16Samples) &&
1140 (VK_SAMPLE_COUNT_16_BIT == pCreateInfo->samples)) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07001141 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001142 "VUID-VkImageCreateInfo-imageType-00976",
Dave Houltona9df0ce2018-02-07 10:51:23 -07001143 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 16-sample image if "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001144 "corresponding feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001145 }
1146 }
1147 }
Jeff Bolzef40fec2018-09-01 22:04:34 -05001148
Jeff Bolz9af91c52018-09-01 21:53:57 -05001149 if (pCreateInfo->usage & VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV) {
1150 if (pCreateInfo->imageType != VK_IMAGE_TYPE_2D) {
1151 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1152 "VUID-VkImageCreateInfo-imageType-02082",
1153 "vkCreateImage: if usage includes VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV, "
1154 "imageType must be VK_IMAGE_TYPE_2D.");
1155 }
1156 if (pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT) {
1157 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1158 "VUID-VkImageCreateInfo-samples-02083",
1159 "vkCreateImage: if usage includes VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV, "
1160 "samples must be VK_SAMPLE_COUNT_1_BIT.");
1161 }
1162 if (pCreateInfo->tiling != VK_IMAGE_TILING_OPTIMAL) {
1163 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1164 "VUID-VkImageCreateInfo-tiling-02084",
1165 "vkCreateImage: if usage includes VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV, "
1166 "tiling must be VK_IMAGE_TILING_OPTIMAL.");
1167 }
1168 }
Jeff Bolzef40fec2018-09-01 22:04:34 -05001169
1170 if (pCreateInfo->flags & VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06001171 if (pCreateInfo->imageType != VK_IMAGE_TYPE_2D && pCreateInfo->imageType != VK_IMAGE_TYPE_3D) {
Jeff Bolzef40fec2018-09-01 22:04:34 -05001172 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1173 "VUID-VkImageCreateInfo-flags-02050",
1174 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV, "
1175 "imageType must be VK_IMAGE_TYPE_2D or VK_IMAGE_TYPE_3D.");
1176 }
1177
Dave Houlton142c4cb2018-10-17 15:04:41 -06001178 if ((pCreateInfo->flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) || FormatIsDepthOrStencil(pCreateInfo->format)) {
Jeff Bolzef40fec2018-09-01 22:04:34 -05001179 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1180 "VUID-VkImageCreateInfo-flags-02051",
1181 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV, "
1182 "it must not also contain VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT and format must "
1183 "not be a depth/stencil format.");
1184 }
1185
Dave Houlton142c4cb2018-10-17 15:04:41 -06001186 if (pCreateInfo->imageType == VK_IMAGE_TYPE_2D && (pCreateInfo->extent.width == 1 || pCreateInfo->extent.height == 1)) {
Jeff Bolzef40fec2018-09-01 22:04:34 -05001187 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1188 "VUID-VkImageCreateInfo-flags-02052",
1189 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV and "
1190 "imageType is VK_IMAGE_TYPE_2D, extent.width and extent.height must be "
1191 "greater than 1.");
Jeff Bolzb8a8dd02018-09-18 02:39:24 -05001192 } else if (pCreateInfo->imageType == VK_IMAGE_TYPE_3D &&
Dave Houlton142c4cb2018-10-17 15:04:41 -06001193 (pCreateInfo->extent.width == 1 || pCreateInfo->extent.height == 1 || pCreateInfo->extent.depth == 1)) {
Jeff Bolzef40fec2018-09-01 22:04:34 -05001194 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1195 "VUID-VkImageCreateInfo-flags-02053",
1196 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV and "
1197 "imageType is VK_IMAGE_TYPE_3D, extent.width, extent.height, and extent.depth "
1198 "must be greater than 1.");
Jeff Bolzef40fec2018-09-01 22:04:34 -05001199 }
1200 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001201 }
Jeff Bolzef40fec2018-09-01 22:04:34 -05001202
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001203 return skip;
1204}
1205
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001206bool pv_vkCreateImageView(VkDevice device, const VkImageViewCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
1207 VkImageView *pView) {
1208 bool skip = false;
1209 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
1210 debug_report_data *report_data = device_data->report_data;
1211
1212 if (pCreateInfo != nullptr) {
Dave Houltonbd2e2622018-04-10 16:41:14 -06001213 // Validate chained VkImageViewUsageCreateInfo struct, if present
1214 if (nullptr != pCreateInfo->pNext) {
1215 auto chained_ivuci_struct = lvl_find_in_chain<VkImageViewUsageCreateInfoKHR>(pCreateInfo->pNext);
1216 if (chained_ivuci_struct) {
1217 if (0 == chained_ivuci_struct->usage) {
1218 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001219 "VUID-VkImageViewUsageCreateInfo-usage-requiredbitmask",
Dave Houlton0f3795b2018-04-13 15:04:35 -06001220 "vkCreateImageView: Chained VkImageViewUsageCreateInfo usage field must not be 0.");
Dave Houltonbd2e2622018-04-10 16:41:14 -06001221 } else if (chained_ivuci_struct->usage & ~AllVkImageUsageFlagBits) {
1222 std::stringstream ss;
1223 ss << "vkCreateImageView: Chained VkImageViewUsageCreateInfo usage field (0x" << std::hex
1224 << chained_ivuci_struct->usage << ") contains invalid flag bits.";
1225 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001226 "VUID-VkImageViewUsageCreateInfo-usage-parameter", "%s", ss.str().c_str());
Dave Houltonbd2e2622018-04-10 16:41:14 -06001227 }
1228 }
1229 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001230 }
1231 return skip;
1232}
1233
Petr Krausb3fcdb42018-01-09 22:09:09 +01001234bool pv_VkViewport(const layer_data *device_data, const VkViewport &viewport, const char *fn_name, const char *param_name,
1235 VkDebugReportObjectTypeEXT object_type, uint64_t object = 0) {
1236 bool skip = false;
1237 debug_report_data *report_data = device_data->report_data;
1238
1239 // Note: for numerical correctness
1240 // - float comparisons should expect NaN (comparison always false).
1241 // - VkPhysicalDeviceLimits::maxViewportDimensions is uint32_t, not float -> careful.
1242
1243 const auto f_lte_u32_exact = [](const float v1_f, const uint32_t v2_u32) {
John Zulaufac0876c2018-02-19 10:09:35 -07001244 if (std::isnan(v1_f)) return false;
Petr Krausb3fcdb42018-01-09 22:09:09 +01001245 if (v1_f <= 0.0f) return true;
1246
1247 float intpart;
1248 const float fract = modff(v1_f, &intpart);
1249
1250 assert(std::numeric_limits<float>::radix == 2);
1251 const float u32_max_plus1 = ldexpf(1.0f, 32); // hopefully exact
1252 if (intpart >= u32_max_plus1) return false;
1253
1254 uint32_t v1_u32 = static_cast<uint32_t>(intpart);
1255 if (v1_u32 < v2_u32)
1256 return true;
1257 else if (v1_u32 == v2_u32 && fract == 0.0f)
1258 return true;
1259 else
1260 return false;
1261 };
1262
1263 const auto f_lte_u32_direct = [](const float v1_f, const uint32_t v2_u32) {
1264 const float v2_f = static_cast<float>(v2_u32); // not accurate for > radix^digits; and undefined rounding mode
1265 return (v1_f <= v2_f);
1266 };
1267
1268 // width
1269 bool width_healthy = true;
1270 const auto max_w = device_data->device_limits.maxViewportDimensions[0];
1271
1272 if (!(viewport.width > 0.0f)) {
1273 width_healthy = false;
Dave Houlton413a6782018-05-22 13:01:54 -06001274 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-width-01770",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001275 "%s: %s.width (=%f) is not greater than 0.0.", fn_name, param_name, viewport.width);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001276 } else if (!(f_lte_u32_exact(viewport.width, max_w) || f_lte_u32_direct(viewport.width, max_w))) {
1277 width_healthy = false;
Dave Houlton413a6782018-05-22 13:01:54 -06001278 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-width-01771",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001279 "%s: %s.width (=%f) exceeds VkPhysicalDeviceLimits::maxViewportDimensions[0] (=%" PRIu32 ").", fn_name,
1280 param_name, viewport.width, max_w);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001281 } else if (!f_lte_u32_exact(viewport.width, max_w) && f_lte_u32_direct(viewport.width, max_w)) {
Dave Houlton413a6782018-05-22 13:01:54 -06001282 skip |= log_msg(report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, object_type, object, kVUID_PVError_NONE,
Petr Krausb3fcdb42018-01-09 22:09:09 +01001283 "%s: %s.width (=%f) technically exceeds VkPhysicalDeviceLimits::maxViewportDimensions[0] (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001284 "), but it is within the static_cast<float>(maxViewportDimensions[0]) limit.",
1285 fn_name, param_name, viewport.width, max_w);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001286 }
1287
1288 // height
1289 bool height_healthy = true;
Petr Krausaf9c1222018-03-10 02:39:47 +01001290 const bool negative_height_enabled = device_data->api_version >= VK_API_VERSION_1_1 ||
1291 device_data->extensions.vk_khr_maintenance1 ||
1292 device_data->extensions.vk_amd_negative_viewport_height;
Petr Krausb3fcdb42018-01-09 22:09:09 +01001293 const auto max_h = device_data->device_limits.maxViewportDimensions[1];
1294
1295 if (!negative_height_enabled && !(viewport.height > 0.0f)) {
1296 height_healthy = false;
Dave Houlton413a6782018-05-22 13:01:54 -06001297 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-height-01772",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001298 "%s: %s.height (=%f) is not greater 0.0.", fn_name, param_name, viewport.height);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001299 } else if (!(f_lte_u32_exact(fabsf(viewport.height), max_h) || f_lte_u32_direct(fabsf(viewport.height), max_h))) {
1300 height_healthy = false;
1301
Dave Houlton413a6782018-05-22 13:01:54 -06001302 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-height-01773",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001303 "%s: Absolute value of %s.height (=%f) exceeds VkPhysicalDeviceLimits::maxViewportDimensions[1] (=%" PRIu32
1304 ").",
1305 fn_name, param_name, viewport.height, max_h);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001306 } else if (!f_lte_u32_exact(fabsf(viewport.height), max_h) && f_lte_u32_direct(fabsf(viewport.height), max_h)) {
1307 height_healthy = false;
1308
1309 skip |= log_msg(
Dave Houlton413a6782018-05-22 13:01:54 -06001310 report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, object_type, object, kVUID_PVError_NONE,
Petr Krausb3fcdb42018-01-09 22:09:09 +01001311 "%s: Absolute value of %s.height (=%f) technically exceeds VkPhysicalDeviceLimits::maxViewportDimensions[1] (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001312 "), but it is within the static_cast<float>(maxViewportDimensions[1]) limit.",
1313 fn_name, param_name, viewport.height, max_h);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001314 }
1315
1316 // x
1317 bool x_healthy = true;
1318 if (!(viewport.x >= device_data->device_limits.viewportBoundsRange[0])) {
1319 x_healthy = false;
Dave Houlton413a6782018-05-22 13:01:54 -06001320 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-x-01774",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001321 "%s: %s.x (=%f) is less than VkPhysicalDeviceLimits::viewportBoundsRange[0] (=%f).", fn_name, param_name,
1322 viewport.x, device_data->device_limits.viewportBoundsRange[0]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001323 }
1324
1325 // x + width
1326 if (x_healthy && width_healthy) {
1327 const float right_bound = viewport.x + viewport.width;
1328 if (!(right_bound <= device_data->device_limits.viewportBoundsRange[1])) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06001329 skip |=
Dave Houlton413a6782018-05-22 13:01:54 -06001330 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-x-01232",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001331 "%s: %s.x + %s.width (=%f + %f = %f) is greater than VkPhysicalDeviceLimits::viewportBoundsRange[1] (=%f).",
1332 fn_name, param_name, param_name, viewport.x, viewport.width, right_bound,
1333 device_data->device_limits.viewportBoundsRange[1]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001334 }
1335 }
1336
1337 // y
1338 bool y_healthy = true;
1339 if (!(viewport.y >= device_data->device_limits.viewportBoundsRange[0])) {
1340 y_healthy = false;
Dave Houlton413a6782018-05-22 13:01:54 -06001341 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-y-01775",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001342 "%s: %s.y (=%f) is less than VkPhysicalDeviceLimits::viewportBoundsRange[0] (=%f).", fn_name, param_name,
1343 viewport.y, device_data->device_limits.viewportBoundsRange[0]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001344 } else if (negative_height_enabled && !(viewport.y <= device_data->device_limits.viewportBoundsRange[1])) {
1345 y_healthy = false;
Dave Houlton413a6782018-05-22 13:01:54 -06001346 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-y-01776",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001347 "%s: %s.y (=%f) exceeds VkPhysicalDeviceLimits::viewportBoundsRange[1] (=%f).", fn_name, param_name,
1348 viewport.y, device_data->device_limits.viewportBoundsRange[1]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001349 }
1350
1351 // y + height
1352 if (y_healthy && height_healthy) {
1353 const float boundary = viewport.y + viewport.height;
1354
1355 if (!(boundary <= device_data->device_limits.viewportBoundsRange[1])) {
Dave Houlton413a6782018-05-22 13:01:54 -06001356 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-y-01233",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001357 "%s: %s.y + %s.height (=%f + %f = %f) exceeds VkPhysicalDeviceLimits::viewportBoundsRange[1] (=%f).",
1358 fn_name, param_name, param_name, viewport.y, viewport.height, boundary,
1359 device_data->device_limits.viewportBoundsRange[1]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001360 } else if (negative_height_enabled && !(boundary >= device_data->device_limits.viewportBoundsRange[0])) {
1361 skip |= log_msg(
Dave Houlton413a6782018-05-22 13:01:54 -06001362 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-y-01777",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001363 "%s: %s.y + %s.height (=%f + %f = %f) is less than VkPhysicalDeviceLimits::viewportBoundsRange[0] (=%f).", fn_name,
1364 param_name, param_name, viewport.y, viewport.height, boundary, device_data->device_limits.viewportBoundsRange[0]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001365 }
1366 }
1367
1368 if (!device_data->extensions.vk_ext_depth_range_unrestricted) {
1369 // minDepth
1370 if (!(viewport.minDepth >= 0.0) || !(viewport.minDepth <= 1.0)) {
Dave Houlton413a6782018-05-22 13:01:54 -06001371 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-minDepth-01234",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001372
Petr Krausb3fcdb42018-01-09 22:09:09 +01001373 "%s: VK_EXT_depth_range_unrestricted extension is not enabled and %s.minDepth (=%f) is not within the "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001374 "[0.0, 1.0] range.",
1375 fn_name, param_name, viewport.minDepth);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001376 }
1377
1378 // maxDepth
1379 if (!(viewport.maxDepth >= 0.0) || !(viewport.maxDepth <= 1.0)) {
Dave Houlton413a6782018-05-22 13:01:54 -06001380 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-maxDepth-01235",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001381
Petr Krausb3fcdb42018-01-09 22:09:09 +01001382 "%s: VK_EXT_depth_range_unrestricted extension is not enabled and %s.maxDepth (=%f) is not within the "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001383 "[0.0, 1.0] range.",
1384 fn_name, param_name, viewport.maxDepth);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001385 }
1386 }
1387
1388 return skip;
1389}
1390
Dave Houlton142c4cb2018-10-17 15:04:41 -06001391struct SampleOrderInfo {
Jeff Bolz9af91c52018-09-01 21:53:57 -05001392 VkShadingRatePaletteEntryNV shadingRate;
1393 uint32_t width;
1394 uint32_t height;
1395};
1396
1397// All palette entries with more than one pixel per fragment
Dave Houlton142c4cb2018-10-17 15:04:41 -06001398static SampleOrderInfo sampleOrderInfos[] = {
1399 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_1X2_PIXELS_NV, 1, 2},
1400 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_2X1_PIXELS_NV, 2, 1},
1401 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_2X2_PIXELS_NV, 2, 2},
1402 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_4X2_PIXELS_NV, 4, 2},
1403 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_2X4_PIXELS_NV, 2, 4},
1404 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_4X4_PIXELS_NV, 4, 4},
Jeff Bolz9af91c52018-09-01 21:53:57 -05001405};
1406
Dave Houlton142c4cb2018-10-17 15:04:41 -06001407bool ValidateCoarseSampleOrderCustomNV(layer_data *device_data, const VkCoarseSampleOrderCustomNV *order) {
Jeff Bolz9af91c52018-09-01 21:53:57 -05001408 bool skip = false;
1409 debug_report_data *report_data = device_data->report_data;
1410
Jeff Bolz45bf7d62018-09-18 15:39:58 -05001411 SampleOrderInfo *sampleOrderInfo;
Jeff Bolz9af91c52018-09-01 21:53:57 -05001412 uint32_t infoIdx = 0;
Jeff Bolz45bf7d62018-09-18 15:39:58 -05001413 for (sampleOrderInfo = nullptr; infoIdx < ARRAY_SIZE(sampleOrderInfos); ++infoIdx) {
Jeff Bolz9af91c52018-09-01 21:53:57 -05001414 if (sampleOrderInfos[infoIdx].shadingRate == order->shadingRate) {
Jeff Bolzb8a8dd02018-09-18 02:39:24 -05001415 sampleOrderInfo = &sampleOrderInfos[infoIdx];
Jeff Bolz9af91c52018-09-01 21:53:57 -05001416 break;
1417 }
1418 }
1419
Jeff Bolzb8a8dd02018-09-18 02:39:24 -05001420 if (sampleOrderInfo == nullptr) {
Jeff Bolz9af91c52018-09-01 21:53:57 -05001421 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1422 "VUID-VkCoarseSampleOrderCustomNV-shadingRate-02073",
1423 "VkCoarseSampleOrderCustomNV shadingRate must be a shading rate "
1424 "that generates fragments with more than one pixel.");
1425 return skip;
1426 }
1427
Dave Houlton142c4cb2018-10-17 15:04:41 -06001428 if (order->sampleCount == 0 || (order->sampleCount & (order->sampleCount - 1)) ||
Jeff Bolz9af91c52018-09-01 21:53:57 -05001429 !(order->sampleCount & device_data->device_limits.framebufferNoAttachmentsSampleCounts)) {
1430 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1431 "VUID-VkCoarseSampleOrderCustomNV-sampleCount-02074",
Dave Houlton142c4cb2018-10-17 15:04:41 -06001432 "VkCoarseSampleOrderCustomNV sampleCount (=%" PRIu32
1433 ") must "
Jeff Bolz9af91c52018-09-01 21:53:57 -05001434 "correspond to a sample count enumerated in VkSampleCountFlags whose corresponding bit "
1435 "is set in framebufferNoAttachmentsSampleCounts.",
1436 order->sampleCount);
1437 }
1438
Jeff Bolz9af91c52018-09-01 21:53:57 -05001439 if (order->sampleLocationCount != order->sampleCount * sampleOrderInfo->width * sampleOrderInfo->height) {
1440 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1441 "VUID-VkCoarseSampleOrderCustomNV-sampleLocationCount-02075",
Dave Houlton142c4cb2018-10-17 15:04:41 -06001442 "VkCoarseSampleOrderCustomNV sampleLocationCount (=%" PRIu32
1443 ") must "
1444 "be equal to the product of sampleCount (=%" PRIu32
1445 "), the fragment width for shadingRate "
Jeff Bolz9af91c52018-09-01 21:53:57 -05001446 "(=%" PRIu32 "), and the fragment height for shadingRate (=%" PRIu32 ").",
1447 order->sampleLocationCount, order->sampleCount, sampleOrderInfo->width, sampleOrderInfo->height);
1448 }
1449
Jeff Bolz5d2b7432018-09-06 10:32:36 -05001450 if (order->sampleLocationCount > device_data->phys_dev_ext_props.shading_rate_image_props.shadingRateMaxCoarseSamples) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06001451 skip |= log_msg(
1452 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1453 "VUID-VkCoarseSampleOrderCustomNV-sampleLocationCount-02076",
1454 "VkCoarseSampleOrderCustomNV sampleLocationCount (=%" PRIu32
1455 ") must "
1456 "be less than or equal to VkPhysicalDeviceShadingRateImagePropertiesNV shadingRateMaxCoarseSamples (=%" PRIu32 ").",
1457 order->sampleLocationCount, device_data->phys_dev_ext_props.shading_rate_image_props.shadingRateMaxCoarseSamples);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001458 }
Jeff Bolz9af91c52018-09-01 21:53:57 -05001459
1460 // Accumulate a bitmask tracking which (x,y,sample) tuples are seen. Expect
Jeff Bolzb8a8dd02018-09-18 02:39:24 -05001461 // the first width*height*sampleCount bits to all be set. Note: There is no
1462 // guarantee that 64 bits is enough, but practically it's unlikely for an
1463 // implementation to support more than 32 bits for samplemask.
Jeff Bolz45bf7d62018-09-18 15:39:58 -05001464 assert(device_data->phys_dev_ext_props.shading_rate_image_props.shadingRateMaxCoarseSamples <= 64);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001465 uint64_t sampleLocationsMask = 0;
1466 for (uint32_t i = 0; i < order->sampleLocationCount; ++i) {
1467 const VkCoarseSampleLocationNV *sampleLoc = &order->pSampleLocations[i];
1468 if (sampleLoc->pixelX >= sampleOrderInfo->width) {
1469 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1470 "VUID-VkCoarseSampleLocationNV-pixelX-02078",
1471 "pixelX must be less than the width (in pixels) of the fragment.");
1472 }
1473 if (sampleLoc->pixelY >= sampleOrderInfo->height) {
1474 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1475 "VUID-VkCoarseSampleLocationNV-pixelY-02079",
1476 "pixelY must be less than the height (in pixels) of the fragment.");
1477 }
1478 if (sampleLoc->sample >= order->sampleCount) {
1479 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1480 "VUID-VkCoarseSampleLocationNV-sample-02080",
1481 "sample must be less than the number of coverage samples in each pixel belonging to the fragment.");
1482 }
1483 uint32_t idx = sampleLoc->sample + order->sampleCount * (sampleLoc->pixelX + sampleOrderInfo->width * sampleLoc->pixelY);
1484 sampleLocationsMask |= 1ULL << idx;
1485 }
1486
1487 uint64_t expectedMask = (order->sampleLocationCount == 64) ? ~0ULL : ((1ULL << order->sampleLocationCount) - 1);
1488 if (sampleLocationsMask != expectedMask) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06001489 skip |= log_msg(
1490 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1491 "VUID-VkCoarseSampleOrderCustomNV-pSampleLocations-02077",
1492 "The array pSampleLocations must contain exactly one entry for "
1493 "every combination of valid values for pixelX, pixelY, and sample in the structure VkCoarseSampleOrderCustomNV.");
Jeff Bolz9af91c52018-09-01 21:53:57 -05001494 }
1495
1496 return skip;
1497}
1498
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001499bool pv_vkCreateGraphicsPipelines(VkDevice device, VkPipelineCache pipelineCache, uint32_t createInfoCount,
1500 const VkGraphicsPipelineCreateInfo *pCreateInfos, const VkAllocationCallbacks *pAllocator,
1501 VkPipeline *pPipelines) {
1502 bool skip = false;
1503 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
1504 debug_report_data *report_data = device_data->report_data;
1505
1506 if (pCreateInfos != nullptr) {
1507 for (uint32_t i = 0; i < createInfoCount; ++i) {
Petr Kraus299ba622017-11-24 03:09:03 +01001508 bool has_dynamic_viewport = false;
1509 bool has_dynamic_scissor = false;
1510 bool has_dynamic_line_width = false;
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001511 bool has_dynamic_viewport_w_scaling_nv = false;
1512 bool has_dynamic_discard_rectangle_ext = false;
1513 bool has_dynamic_sample_locations_ext = false;
Jeff Bolz3e71f782018-08-29 23:15:45 -05001514 bool has_dynamic_exclusive_scissor_nv = false;
Jeff Bolz9af91c52018-09-01 21:53:57 -05001515 bool has_dynamic_shading_rate_palette_nv = false;
Petr Kraus299ba622017-11-24 03:09:03 +01001516 if (pCreateInfos[i].pDynamicState != nullptr) {
1517 const auto &dynamic_state_info = *pCreateInfos[i].pDynamicState;
1518 for (uint32_t state_index = 0; state_index < dynamic_state_info.dynamicStateCount; ++state_index) {
1519 const auto &dynamic_state = dynamic_state_info.pDynamicStates[state_index];
1520 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT) has_dynamic_viewport = true;
1521 if (dynamic_state == VK_DYNAMIC_STATE_SCISSOR) has_dynamic_scissor = true;
1522 if (dynamic_state == VK_DYNAMIC_STATE_LINE_WIDTH) has_dynamic_line_width = true;
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001523 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT_W_SCALING_NV) has_dynamic_viewport_w_scaling_nv = true;
1524 if (dynamic_state == VK_DYNAMIC_STATE_DISCARD_RECTANGLE_EXT) has_dynamic_discard_rectangle_ext = true;
1525 if (dynamic_state == VK_DYNAMIC_STATE_SAMPLE_LOCATIONS_EXT) has_dynamic_sample_locations_ext = true;
Jeff Bolz3e71f782018-08-29 23:15:45 -05001526 if (dynamic_state == VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV) has_dynamic_exclusive_scissor_nv = true;
Dave Houlton142c4cb2018-10-17 15:04:41 -06001527 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT_SHADING_RATE_PALETTE_NV)
1528 has_dynamic_shading_rate_palette_nv = true;
Petr Kraus299ba622017-11-24 03:09:03 +01001529 }
1530 }
1531
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001532 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
1533 if (pCreateInfos[i].pVertexInputState != nullptr) {
1534 auto const &vertex_input_state = pCreateInfos[i].pVertexInputState;
Peter Kohautc7d9d392018-07-15 00:34:07 +02001535
1536 if (vertex_input_state->vertexBindingDescriptionCount > device_data->device_limits.maxVertexInputBindings) {
1537 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1538 "VUID-VkPipelineVertexInputStateCreateInfo-vertexBindingDescriptionCount-00613",
1539 "vkCreateGraphicsPipelines: pararameter "
1540 "pCreateInfo[%d].pVertexInputState->vertexBindingDescriptionCount (%u) is "
1541 "greater than VkPhysicalDeviceLimits::maxVertexInputBindings (%u).",
1542 i, vertex_input_state->vertexBindingDescriptionCount,
1543 device_data->device_limits.maxVertexInputBindings);
1544 }
1545
1546 if (vertex_input_state->vertexAttributeDescriptionCount > device_data->device_limits.maxVertexInputAttributes) {
1547 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1548 "VUID-VkPipelineVertexInputStateCreateInfo-vertexAttributeDescriptionCount-00614",
1549 "vkCreateGraphicsPipelines: pararameter "
Peter Kohaut9e92c5c2018-07-17 10:32:17 +02001550 "pCreateInfo[%d].pVertexInputState->vertexAttributeDescriptionCount (%u) is "
Peter Kohautc7d9d392018-07-15 00:34:07 +02001551 "greater than VkPhysicalDeviceLimits::maxVertexInputAttributes (%u).",
1552 i, vertex_input_state->vertexBindingDescriptionCount,
1553 device_data->device_limits.maxVertexInputAttributes);
1554 }
1555
1556 std::unordered_set<uint32_t> vertex_bindings(vertex_input_state->vertexBindingDescriptionCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001557 for (uint32_t d = 0; d < vertex_input_state->vertexBindingDescriptionCount; ++d) {
1558 auto const &vertex_bind_desc = vertex_input_state->pVertexBindingDescriptions[d];
Peter Kohautc7d9d392018-07-15 00:34:07 +02001559 auto const &binding_it = vertex_bindings.find(vertex_bind_desc.binding);
1560 if (binding_it != vertex_bindings.cend()) {
1561 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1562 "VUID-VkPipelineVertexInputStateCreateInfo-pVertexBindingDescriptions-00616",
1563 "vkCreateGraphicsPipelines: parameter "
1564 "pCreateInfo[%d].pVertexInputState->pVertexBindingDescription[%d].binding "
1565 "(%" PRIu32 ") is not distinct.",
1566 i, d, vertex_bind_desc.binding);
1567 }
1568 vertex_bindings.insert(vertex_bind_desc.binding);
1569
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001570 if (vertex_bind_desc.binding >= device_data->device_limits.maxVertexInputBindings) {
1571 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001572 "VUID-VkVertexInputBindingDescription-binding-00618",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001573 "vkCreateGraphicsPipelines: parameter "
1574 "pCreateInfos[%u].pVertexInputState->pVertexBindingDescriptions[%u].binding (%u) is "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001575 "greater than or equal to VkPhysicalDeviceLimits::maxVertexInputBindings (%u).",
1576 i, d, vertex_bind_desc.binding, device_data->device_limits.maxVertexInputBindings);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001577 }
1578
1579 if (vertex_bind_desc.stride > device_data->device_limits.maxVertexInputBindingStride) {
1580 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001581 "VUID-VkVertexInputBindingDescription-stride-00619",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001582 "vkCreateGraphicsPipelines: parameter "
1583 "pCreateInfos[%u].pVertexInputState->pVertexBindingDescriptions[%u].stride (%u) is greater "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001584 "than VkPhysicalDeviceLimits::maxVertexInputBindingStride (%u).",
1585 i, d, vertex_bind_desc.stride, device_data->device_limits.maxVertexInputBindingStride);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001586 }
1587 }
1588
Peter Kohautc7d9d392018-07-15 00:34:07 +02001589 std::unordered_set<uint32_t> attribute_locations(vertex_input_state->vertexAttributeDescriptionCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001590 for (uint32_t d = 0; d < vertex_input_state->vertexAttributeDescriptionCount; ++d) {
1591 auto const &vertex_attrib_desc = vertex_input_state->pVertexAttributeDescriptions[d];
Peter Kohautc7d9d392018-07-15 00:34:07 +02001592 auto const &location_it = attribute_locations.find(vertex_attrib_desc.location);
1593 if (location_it != attribute_locations.cend()) {
1594 skip |= log_msg(
1595 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1596 "VUID-VkPipelineVertexInputStateCreateInfo-pVertexAttributeDescriptions-00617",
1597 "vkCreateGraphicsPipelines: parameter "
1598 "pCreateInfo[%d].pVertexInputState->vertexAttributeDescriptions[%d].location (%u) is not distinct.",
1599 i, d, vertex_attrib_desc.location);
1600 }
1601 attribute_locations.insert(vertex_attrib_desc.location);
1602
1603 auto const &binding_it = vertex_bindings.find(vertex_attrib_desc.binding);
1604 if (binding_it == vertex_bindings.cend()) {
1605 skip |= log_msg(
1606 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1607 "VUID-VkPipelineVertexInputStateCreateInfo-binding-00615",
1608 "vkCreateGraphicsPipelines: parameter "
1609 " pCreateInfo[%d].pVertexInputState->vertexAttributeDescriptions[%d].binding (%u) does not exist "
1610 "in any pCreateInfo[%d].pVertexInputState->pVertexBindingDescription.",
1611 i, d, vertex_attrib_desc.binding, i);
1612 }
1613
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001614 if (vertex_attrib_desc.location >= device_data->device_limits.maxVertexInputAttributes) {
1615 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001616 "VUID-VkVertexInputAttributeDescription-location-00620",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001617 "vkCreateGraphicsPipelines: parameter "
1618 "pCreateInfos[%u].pVertexInputState->pVertexAttributeDescriptions[%u].location (%u) is "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001619 "greater than or equal to VkPhysicalDeviceLimits::maxVertexInputAttributes (%u).",
1620 i, d, vertex_attrib_desc.location, device_data->device_limits.maxVertexInputAttributes);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001621 }
1622
1623 if (vertex_attrib_desc.binding >= device_data->device_limits.maxVertexInputBindings) {
1624 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001625 "VUID-VkVertexInputAttributeDescription-binding-00621",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001626 "vkCreateGraphicsPipelines: parameter "
1627 "pCreateInfos[%u].pVertexInputState->pVertexAttributeDescriptions[%u].binding (%u) is "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001628 "greater than or equal to VkPhysicalDeviceLimits::maxVertexInputBindings (%u).",
1629 i, d, vertex_attrib_desc.binding, device_data->device_limits.maxVertexInputBindings);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001630 }
1631
1632 if (vertex_attrib_desc.offset > device_data->device_limits.maxVertexInputAttributeOffset) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06001633 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001634 "VUID-VkVertexInputAttributeDescription-offset-00622",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001635 "vkCreateGraphicsPipelines: parameter "
1636 "pCreateInfos[%u].pVertexInputState->pVertexAttributeDescriptions[%u].offset (%u) is "
1637 "greater than VkPhysicalDeviceLimits::maxVertexInputAttributeOffset (%u).",
1638 i, d, vertex_attrib_desc.offset, device_data->device_limits.maxVertexInputAttributeOffset);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001639 }
1640 }
1641 }
1642
1643 if (pCreateInfos[i].pStages != nullptr) {
1644 bool has_control = false;
1645 bool has_eval = false;
1646
1647 for (uint32_t stage_index = 0; stage_index < pCreateInfos[i].stageCount; ++stage_index) {
1648 if (pCreateInfos[i].pStages[stage_index].stage == VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) {
1649 has_control = true;
1650 } else if (pCreateInfos[i].pStages[stage_index].stage == VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT) {
1651 has_eval = true;
1652 }
1653 }
1654
1655 // pTessellationState is ignored without both tessellation control and tessellation evaluation shaders stages
1656 if (has_control && has_eval) {
1657 if (pCreateInfos[i].pTessellationState == nullptr) {
1658 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001659 "VUID-VkGraphicsPipelineCreateInfo-pStages-00731",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001660 "vkCreateGraphicsPipelines: if pCreateInfos[%d].pStages includes a tessellation control "
1661 "shader stage and a tessellation evaluation shader stage, "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001662 "pCreateInfos[%d].pTessellationState must not be NULL.",
1663 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001664 } else {
1665 skip |= validate_struct_pnext(
1666 report_data, "vkCreateGraphicsPipelines",
1667 ParameterName("pCreateInfos[%i].pTessellationState->pNext", ParameterName::IndexVector{i}), NULL,
Dave Houlton413a6782018-05-22 13:01:54 -06001668 pCreateInfos[i].pTessellationState->pNext, 0, NULL, GeneratedHeaderVersion,
1669 "VUID-VkGraphicsPipelineCreateInfo-pNext-pNext");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001670
1671 skip |= validate_reserved_flags(
1672 report_data, "vkCreateGraphicsPipelines",
1673 ParameterName("pCreateInfos[%i].pTessellationState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06001674 pCreateInfos[i].pTessellationState->flags,
1675 "VUID-VkPipelineTessellationStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001676
1677 if (pCreateInfos[i].pTessellationState->sType !=
1678 VK_STRUCTURE_TYPE_PIPELINE_TESSELLATION_STATE_CREATE_INFO) {
1679 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001680 "VUID-VkPipelineTessellationStateCreateInfo-sType-sType",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001681 "vkCreateGraphicsPipelines: parameter pCreateInfos[%d].pTessellationState->sType must "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001682 "be VK_STRUCTURE_TYPE_PIPELINE_TESSELLATION_STATE_CREATE_INFO.",
1683 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001684 }
1685
1686 if (pCreateInfos[i].pTessellationState->patchControlPoints == 0 ||
1687 pCreateInfos[i].pTessellationState->patchControlPoints >
1688 device_data->device_limits.maxTessellationPatchSize) {
1689 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001690 "VUID-VkPipelineTessellationStateCreateInfo-patchControlPoints-01214",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001691 "vkCreateGraphicsPipelines: invalid parameter "
1692 "pCreateInfos[%d].pTessellationState->patchControlPoints value %u. patchControlPoints "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001693 "should be >0 and <=%u.",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001694 i, pCreateInfos[i].pTessellationState->patchControlPoints,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001695 device_data->device_limits.maxTessellationPatchSize);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001696 }
1697 }
1698 }
1699 }
1700
1701 // pViewportState, pMultisampleState, pDepthStencilState, and pColorBlendState ignored when rasterization is disabled
1702 if ((pCreateInfos[i].pRasterizationState != nullptr) &&
1703 (pCreateInfos[i].pRasterizationState->rasterizerDiscardEnable == VK_FALSE)) {
1704 if (pCreateInfos[i].pViewportState == nullptr) {
Petr Krausa6103552017-11-16 21:21:58 +01001705 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001706 VK_NULL_HANDLE, "VUID-VkGraphicsPipelineCreateInfo-rasterizerDiscardEnable-00750",
Petr Krausa6103552017-11-16 21:21:58 +01001707 "vkCreateGraphicsPipelines: Rasterization is enabled (pCreateInfos[%" PRIu32
1708 "].pRasterizationState->rasterizerDiscardEnable is VK_FALSE), but pCreateInfos[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001709 "].pViewportState (=NULL) is not a valid pointer.",
1710 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001711 } else {
Petr Krausa6103552017-11-16 21:21:58 +01001712 const auto &viewport_state = *pCreateInfos[i].pViewportState;
1713
1714 if (viewport_state.sType != VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_STATE_CREATE_INFO) {
1715 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001716 VK_NULL_HANDLE, "VUID-VkPipelineViewportStateCreateInfo-sType-sType",
Petr Krausa6103552017-11-16 21:21:58 +01001717 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001718 "].pViewportState->sType is not VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_STATE_CREATE_INFO.",
1719 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001720 }
1721
Petr Krausa6103552017-11-16 21:21:58 +01001722 const VkStructureType allowed_structs_VkPipelineViewportStateCreateInfo[] = {
1723 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_SWIZZLE_STATE_CREATE_INFO_NV,
Jeff Bolz3e71f782018-08-29 23:15:45 -05001724 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_W_SCALING_STATE_CREATE_INFO_NV,
1725 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_EXCLUSIVE_SCISSOR_STATE_CREATE_INFO_NV,
Jeff Bolz9af91c52018-09-01 21:53:57 -05001726 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_SHADING_RATE_IMAGE_STATE_CREATE_INFO_NV,
1727 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_COARSE_SAMPLE_ORDER_STATE_CREATE_INFO_NV,
Jeff Bolz3e71f782018-08-29 23:15:45 -05001728 };
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001729 skip |= validate_struct_pnext(
1730 report_data, "vkCreateGraphicsPipelines",
Petr Krausa6103552017-11-16 21:21:58 +01001731 ParameterName("pCreateInfos[%i].pViewportState->pNext", ParameterName::IndexVector{i}),
Jeff Bolz9af91c52018-09-01 21:53:57 -05001732 "VkPipelineViewportSwizzleStateCreateInfoNV, VkPipelineViewportWScalingStateCreateInfoNV, "
Jeff Bolzb8a8dd02018-09-18 02:39:24 -05001733 "VkPipelineViewportExclusiveScissorStateCreateInfoNV, VkPipelineViewportShadingRateImageStateCreateInfoNV, "
1734 "VkPipelineViewportCoarseSampleOrderStateCreateInfoNV",
Petr Krausa6103552017-11-16 21:21:58 +01001735 viewport_state.pNext, ARRAY_SIZE(allowed_structs_VkPipelineViewportStateCreateInfo),
Dave Houlton413a6782018-05-22 13:01:54 -06001736 allowed_structs_VkPipelineViewportStateCreateInfo, 65,
1737 "VUID-VkPipelineViewportStateCreateInfo-pNext-pNext");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001738
1739 skip |= validate_reserved_flags(
1740 report_data, "vkCreateGraphicsPipelines",
1741 ParameterName("pCreateInfos[%i].pViewportState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06001742 viewport_state.flags, "VUID-VkPipelineViewportStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001743
Dave Houlton142c4cb2018-10-17 15:04:41 -06001744 auto exclusive_scissor_struct = lvl_find_in_chain<VkPipelineViewportExclusiveScissorStateCreateInfoNV>(
1745 pCreateInfos[i].pViewportState->pNext);
1746 auto shading_rate_image_struct = lvl_find_in_chain<VkPipelineViewportShadingRateImageStateCreateInfoNV>(
1747 pCreateInfos[i].pViewportState->pNext);
1748 auto coarse_sample_order_struct = lvl_find_in_chain<VkPipelineViewportCoarseSampleOrderStateCreateInfoNV>(
1749 pCreateInfos[i].pViewportState->pNext);
Jeff Bolz3e71f782018-08-29 23:15:45 -05001750
Petr Krausa6103552017-11-16 21:21:58 +01001751 if (!device_data->physical_device_features.multiViewport) {
1752 if (viewport_state.viewportCount != 1) {
1753 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001754 VK_NULL_HANDLE, "VUID-VkPipelineViewportStateCreateInfo-viewportCount-01216",
Petr Krausa6103552017-11-16 21:21:58 +01001755 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
1756 "disabled, but pCreateInfos[%" PRIu32 "].pViewportState->viewportCount (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001757 ") is not 1.",
1758 i, viewport_state.viewportCount);
Petr Krausa6103552017-11-16 21:21:58 +01001759 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001760
Petr Krausa6103552017-11-16 21:21:58 +01001761 if (viewport_state.scissorCount != 1) {
1762 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001763 VK_NULL_HANDLE, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-01217",
Petr Krausa6103552017-11-16 21:21:58 +01001764 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
1765 "disabled, but pCreateInfos[%" PRIu32 "].pViewportState->scissorCount (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001766 ") is not 1.",
1767 i, viewport_state.scissorCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001768 }
Jeff Bolz3e71f782018-08-29 23:15:45 -05001769
Dave Houlton142c4cb2018-10-17 15:04:41 -06001770 if (exclusive_scissor_struct && (exclusive_scissor_struct->exclusiveScissorCount != 0 &&
1771 exclusive_scissor_struct->exclusiveScissorCount != 1)) {
1772 skip |=
1773 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
1774 VK_NULL_HANDLE,
1775 "VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-exclusiveScissorCount-02027",
1776 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
1777 "disabled, but pCreateInfos[%" PRIu32
1778 "] VkPipelineViewportExclusiveScissorStateCreateInfoNV::exclusiveScissorCount (=%" PRIu32
1779 ") is not 1.",
1780 i, exclusive_scissor_struct->exclusiveScissorCount);
Jeff Bolz3e71f782018-08-29 23:15:45 -05001781 }
1782
Jeff Bolz9af91c52018-09-01 21:53:57 -05001783 if (shading_rate_image_struct &&
1784 (shading_rate_image_struct->viewportCount != 0 && shading_rate_image_struct->viewportCount != 1)) {
1785 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton142c4cb2018-10-17 15:04:41 -06001786 VK_NULL_HANDLE,
1787 "VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-viewportCount-02054",
Jeff Bolz9af91c52018-09-01 21:53:57 -05001788 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
Dave Houlton142c4cb2018-10-17 15:04:41 -06001789 "disabled, but pCreateInfos[%" PRIu32
1790 "] VkPipelineViewportShadingRateImageStateCreateInfoNV::viewportCount (=%" PRIu32
Jeff Bolzb8a8dd02018-09-18 02:39:24 -05001791 ") is neither 0 nor 1.",
Jeff Bolz9af91c52018-09-01 21:53:57 -05001792 i, shading_rate_image_struct->viewportCount);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001793 }
1794
Petr Krausa6103552017-11-16 21:21:58 +01001795 } else { // multiViewport enabled
1796 if (viewport_state.viewportCount == 0) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001797 skip |= log_msg(
1798 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001799 VK_NULL_HANDLE, "VUID-VkPipelineViewportStateCreateInfo-viewportCount-arraylength",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001800 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "].pViewportState->viewportCount is 0.", i);
Petr Krausa6103552017-11-16 21:21:58 +01001801 } else if (viewport_state.viewportCount > device_data->device_limits.maxViewports) {
1802 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001803 VK_NULL_HANDLE, "VUID-VkPipelineViewportStateCreateInfo-viewportCount-01218",
Petr Krausa6103552017-11-16 21:21:58 +01001804 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1805 "].pViewportState->viewportCount (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001806 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
1807 i, viewport_state.viewportCount, device_data->device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001808 }
Petr Krausa6103552017-11-16 21:21:58 +01001809
1810 if (viewport_state.scissorCount == 0) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001811 skip |= log_msg(
1812 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001813 VK_NULL_HANDLE, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-arraylength",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001814 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "].pViewportState->scissorCount is 0.", i);
Petr Krausa6103552017-11-16 21:21:58 +01001815 } else if (viewport_state.scissorCount > device_data->device_limits.maxViewports) {
1816 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001817 VK_NULL_HANDLE, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-01219",
Petr Krausa6103552017-11-16 21:21:58 +01001818 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1819 "].pViewportState->scissorCount (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001820 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
1821 i, viewport_state.scissorCount, device_data->device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001822 }
1823 }
1824
Jeff Bolz3e71f782018-08-29 23:15:45 -05001825 if (exclusive_scissor_struct &&
1826 exclusive_scissor_struct->exclusiveScissorCount > device_data->device_limits.maxViewports) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06001827 skip |= log_msg(
1828 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, VK_NULL_HANDLE,
1829 "VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-exclusiveScissorCount-02028",
1830 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "] exclusiveScissorCount (=%" PRIu32
1831 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
1832 i, exclusive_scissor_struct->exclusiveScissorCount, device_data->device_limits.maxViewports);
Jeff Bolz3e71f782018-08-29 23:15:45 -05001833 }
1834
Jeff Bolz9af91c52018-09-01 21:53:57 -05001835 if (shading_rate_image_struct &&
1836 shading_rate_image_struct->viewportCount > device_data->device_limits.maxViewports) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06001837 skip |=
1838 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
1839 VK_NULL_HANDLE, "VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-viewportCount-02055",
1840 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1841 "] VkPipelineViewportShadingRateImageStateCreateInfoNV viewportCount (=%" PRIu32
1842 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
1843 i, shading_rate_image_struct->viewportCount, device_data->device_limits.maxViewports);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001844 }
1845
Petr Krausa6103552017-11-16 21:21:58 +01001846 if (viewport_state.scissorCount != viewport_state.viewportCount) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001847 skip |=
1848 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001849 VK_NULL_HANDLE, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-01220",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001850 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "].pViewportState->scissorCount (=%" PRIu32
1851 ") is not identical to pCreateInfos[%" PRIu32 "].pViewportState->viewportCount (=%" PRIu32 ").",
1852 i, viewport_state.scissorCount, i, viewport_state.viewportCount);
Petr Krausa6103552017-11-16 21:21:58 +01001853 }
1854
Dave Houlton142c4cb2018-10-17 15:04:41 -06001855 if (exclusive_scissor_struct && exclusive_scissor_struct->exclusiveScissorCount != 0 &&
Jeff Bolz3e71f782018-08-29 23:15:45 -05001856 exclusive_scissor_struct->exclusiveScissorCount != viewport_state.viewportCount) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06001857 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
1858 VK_NULL_HANDLE,
1859 "VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-exclusiveScissorCount-02029",
1860 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "] exclusiveScissorCount (=%" PRIu32
1861 ") must be zero or identical to pCreateInfos[%" PRIu32
1862 "].pViewportState->viewportCount (=%" PRIu32 ").",
1863 i, exclusive_scissor_struct->exclusiveScissorCount, i, viewport_state.viewportCount);
Jeff Bolz3e71f782018-08-29 23:15:45 -05001864 }
1865
Dave Houlton142c4cb2018-10-17 15:04:41 -06001866 if (shading_rate_image_struct && shading_rate_image_struct->shadingRateImageEnable &&
Jeff Bolz9af91c52018-09-01 21:53:57 -05001867 shading_rate_image_struct->viewportCount != viewport_state.viewportCount) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06001868 skip |= log_msg(
1869 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, VK_NULL_HANDLE,
1870 "VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-shadingRateImageEnable-02056",
1871 "vkCreateGraphicsPipelines: If shadingRateImageEnable is enabled, pCreateInfos[%" PRIu32
1872 "] "
1873 "VkPipelineViewportShadingRateImageStateCreateInfoNV viewportCount (=%" PRIu32
1874 ") must identical to pCreateInfos[%" PRIu32 "].pViewportState->viewportCount (=%" PRIu32 ").",
1875 i, shading_rate_image_struct->viewportCount, i, viewport_state.viewportCount);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001876 }
1877
Petr Krausa6103552017-11-16 21:21:58 +01001878 if (!has_dynamic_viewport && viewport_state.viewportCount > 0 && viewport_state.pViewports == nullptr) {
1879 skip |= log_msg(
1880 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, VK_NULL_HANDLE,
Dave Houlton413a6782018-05-22 13:01:54 -06001881 "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-00747",
Petr Krausa6103552017-11-16 21:21:58 +01001882 "vkCreateGraphicsPipelines: The viewport state is static (pCreateInfos[%" PRIu32
1883 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_VIEWPORT), but pCreateInfos[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001884 "].pViewportState->pViewports (=NULL) is an invalid pointer.",
1885 i, i);
Petr Krausa6103552017-11-16 21:21:58 +01001886 }
1887
1888 if (!has_dynamic_scissor && viewport_state.scissorCount > 0 && viewport_state.pScissors == nullptr) {
1889 skip |= log_msg(
1890 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, VK_NULL_HANDLE,
Dave Houlton413a6782018-05-22 13:01:54 -06001891 "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-00748",
Petr Krausa6103552017-11-16 21:21:58 +01001892 "vkCreateGraphicsPipelines: The scissor state is static (pCreateInfos[%" PRIu32
1893 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_SCISSOR), but pCreateInfos[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001894 "].pViewportState->pScissors (=NULL) is an invalid pointer.",
1895 i, i);
Petr Krausa6103552017-11-16 21:21:58 +01001896 }
1897
Jeff Bolz3e71f782018-08-29 23:15:45 -05001898 if (!has_dynamic_exclusive_scissor_nv && exclusive_scissor_struct &&
Dave Houlton142c4cb2018-10-17 15:04:41 -06001899 exclusive_scissor_struct->exclusiveScissorCount > 0 &&
1900 exclusive_scissor_struct->pExclusiveScissors == nullptr) {
1901 skip |=
1902 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
1903 VK_NULL_HANDLE, "VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-pDynamicStates-02030",
1904 "vkCreateGraphicsPipelines: The exclusive scissor state is static (pCreateInfos[%" PRIu32
1905 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV), but "
1906 "pCreateInfos[%" PRIu32 "] pExclusiveScissors (=NULL) is an invalid pointer.",
1907 i, i);
Jeff Bolz3e71f782018-08-29 23:15:45 -05001908 }
1909
Jeff Bolz9af91c52018-09-01 21:53:57 -05001910 if (!has_dynamic_shading_rate_palette_nv && shading_rate_image_struct &&
Dave Houlton142c4cb2018-10-17 15:04:41 -06001911 shading_rate_image_struct->viewportCount > 0 &&
1912 shading_rate_image_struct->pShadingRatePalettes == nullptr) {
Jeff Bolz9af91c52018-09-01 21:53:57 -05001913 skip |= log_msg(
1914 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, VK_NULL_HANDLE,
1915 "VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-pDynamicStates-02057",
1916 "vkCreateGraphicsPipelines: The shading rate palette state is static (pCreateInfos[%" PRIu32
Dave Houlton142c4cb2018-10-17 15:04:41 -06001917 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_VIEWPORT_SHADING_RATE_PALETTE_NV), "
1918 "but pCreateInfos[%" PRIu32 "] pShadingRatePalettes (=NULL) is an invalid pointer.",
Jeff Bolz9af91c52018-09-01 21:53:57 -05001919 i, i);
1920 }
1921
Petr Krausb3fcdb42018-01-09 22:09:09 +01001922 // validate the VkViewports
1923 if (!has_dynamic_viewport && viewport_state.pViewports) {
1924 for (uint32_t viewport_i = 0; viewport_i < viewport_state.viewportCount; ++viewport_i) {
1925 const auto &viewport = viewport_state.pViewports[viewport_i]; // will crash on invalid ptr
1926 const char fn_name[] = "vkCreateGraphicsPipelines";
1927 const std::string param_name = "pCreateInfos[" + std::to_string(i) + "].pViewportState->pViewports[" +
1928 std::to_string(viewport_i) + "]";
1929 skip |= pv_VkViewport(device_data, viewport, fn_name, param_name.c_str(),
1930 VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT);
1931 }
1932 }
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001933
1934 if (has_dynamic_viewport_w_scaling_nv && !device_data->extensions.vk_nv_clip_space_w_scaling) {
1935 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001936 VK_NULL_HANDLE, kVUID_PVError_ExtensionNotEnabled,
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001937 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
Dave Houltona9df0ce2018-02-07 10:51:23 -07001938 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_VIEWPORT_W_SCALING_NV, but "
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001939 "VK_NV_clip_space_w_scaling extension is not enabled.",
1940 i);
1941 }
1942
1943 if (has_dynamic_discard_rectangle_ext && !device_data->extensions.vk_ext_discard_rectangles) {
1944 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001945 VK_NULL_HANDLE, kVUID_PVError_ExtensionNotEnabled,
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001946 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
Dave Houltona9df0ce2018-02-07 10:51:23 -07001947 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_DISCARD_RECTANGLE_EXT, but "
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001948 "VK_EXT_discard_rectangles extension is not enabled.",
1949 i);
1950 }
1951
1952 if (has_dynamic_sample_locations_ext && !device_data->extensions.vk_ext_sample_locations) {
1953 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001954 VK_NULL_HANDLE, kVUID_PVError_ExtensionNotEnabled,
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001955 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
Dave Houltona9df0ce2018-02-07 10:51:23 -07001956 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_SAMPLE_LOCATIONS_EXT, but "
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001957 "VK_EXT_sample_locations extension is not enabled.",
1958 i);
1959 }
Jeff Bolz3e71f782018-08-29 23:15:45 -05001960
1961 if (has_dynamic_exclusive_scissor_nv && !device_data->extensions.vk_nv_scissor_exclusive) {
1962 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
1963 VK_NULL_HANDLE, kVUID_PVError_ExtensionNotEnabled,
1964 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1965 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV, but "
1966 "VK_NV_scissor_exclusive extension is not enabled.",
1967 i);
1968 }
Jeff Bolz9af91c52018-09-01 21:53:57 -05001969
1970 if (coarse_sample_order_struct &&
1971 coarse_sample_order_struct->sampleOrderType != VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV &&
1972 coarse_sample_order_struct->customSampleOrderCount != 0) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06001973 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
1974 VK_NULL_HANDLE,
1975 "VUID-VkPipelineViewportCoarseSampleOrderStateCreateInfoNV-sampleOrderType-02072",
1976 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1977 "] "
1978 "VkPipelineViewportCoarseSampleOrderStateCreateInfoNV sampleOrderType is not "
1979 "VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV and customSampleOrderCount is not 0.",
1980 i);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001981 }
1982
1983 if (coarse_sample_order_struct) {
1984 for (uint32_t order_i = 0; order_i < coarse_sample_order_struct->customSampleOrderCount; ++order_i) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06001985 skip |= ValidateCoarseSampleOrderCustomNV(device_data,
1986 &coarse_sample_order_struct->pCustomSampleOrders[order_i]);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001987 }
1988 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001989 }
1990
1991 if (pCreateInfos[i].pMultisampleState == nullptr) {
1992 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001993 "VUID-VkGraphicsPipelineCreateInfo-rasterizerDiscardEnable-00751",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001994 "vkCreateGraphicsPipelines: if pCreateInfos[%d].pRasterizationState->rasterizerDiscardEnable "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001995 "is VK_FALSE, pCreateInfos[%d].pMultisampleState must not be NULL.",
1996 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001997 } else {
Dave Houltonb3bbec72018-01-17 10:13:33 -07001998 const VkStructureType valid_next_stypes[] = {LvlTypeMap<VkPipelineCoverageModulationStateCreateInfoNV>::kSType,
1999 LvlTypeMap<VkPipelineCoverageToColorStateCreateInfoNV>::kSType,
2000 LvlTypeMap<VkPipelineSampleLocationsStateCreateInfoEXT>::kSType};
Mike Schuchardt97662b02017-12-06 13:31:29 -07002001 const char *valid_struct_names =
Dave Houltona9df0ce2018-02-07 10:51:23 -07002002 "VkPipelineCoverageModulationStateCreateInfoNV, VkPipelineCoverageToColorStateCreateInfoNV, "
John Zulauf96b0e422017-11-14 11:43:19 -07002003 "VkPipelineSampleLocationsStateCreateInfoEXT";
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002004 skip |= validate_struct_pnext(
2005 report_data, "vkCreateGraphicsPipelines",
John Zulauf96b0e422017-11-14 11:43:19 -07002006 ParameterName("pCreateInfos[%i].pMultisampleState->pNext", ParameterName::IndexVector{i}),
2007 valid_struct_names, pCreateInfos[i].pMultisampleState->pNext, 3, valid_next_stypes, GeneratedHeaderVersion,
Dave Houlton413a6782018-05-22 13:01:54 -06002008 "VUID-VkPipelineMultisampleStateCreateInfo-pNext-pNext");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002009
2010 skip |= validate_reserved_flags(
2011 report_data, "vkCreateGraphicsPipelines",
2012 ParameterName("pCreateInfos[%i].pMultisampleState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06002013 pCreateInfos[i].pMultisampleState->flags, "VUID-VkPipelineMultisampleStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002014
2015 skip |= validate_bool32(
2016 report_data, "vkCreateGraphicsPipelines",
2017 ParameterName("pCreateInfos[%i].pMultisampleState->sampleShadingEnable", ParameterName::IndexVector{i}),
2018 pCreateInfos[i].pMultisampleState->sampleShadingEnable);
2019
2020 skip |= validate_array(
2021 report_data, "vkCreateGraphicsPipelines",
2022 ParameterName("pCreateInfos[%i].pMultisampleState->rasterizationSamples", ParameterName::IndexVector{i}),
2023 ParameterName("pCreateInfos[%i].pMultisampleState->pSampleMask", ParameterName::IndexVector{i}),
Gabríel Arthúr Pétursson092b29b2018-03-21 22:44:11 +00002024 pCreateInfos[i].pMultisampleState->rasterizationSamples, &pCreateInfos[i].pMultisampleState->pSampleMask,
Dave Houlton413a6782018-05-22 13:01:54 -06002025 true, false, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002026
2027 skip |= validate_bool32(
2028 report_data, "vkCreateGraphicsPipelines",
2029 ParameterName("pCreateInfos[%i].pMultisampleState->alphaToCoverageEnable", ParameterName::IndexVector{i}),
2030 pCreateInfos[i].pMultisampleState->alphaToCoverageEnable);
2031
2032 skip |= validate_bool32(
2033 report_data, "vkCreateGraphicsPipelines",
2034 ParameterName("pCreateInfos[%i].pMultisampleState->alphaToOneEnable", ParameterName::IndexVector{i}),
2035 pCreateInfos[i].pMultisampleState->alphaToOneEnable);
2036
2037 if (pCreateInfos[i].pMultisampleState->sType != VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO) {
2038 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002039 kVUID_PVError_InvalidStructSType,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002040 "vkCreateGraphicsPipelines: parameter pCreateInfos[%d].pMultisampleState->sType must be "
2041 "VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO",
2042 i);
2043 }
John Zulauf7acac592017-11-06 11:15:53 -07002044 if (pCreateInfos[i].pMultisampleState->sampleShadingEnable == VK_TRUE) {
2045 if (!device_data->physical_device_features.sampleRateShading) {
2046 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002047 "VUID-VkPipelineMultisampleStateCreateInfo-sampleShadingEnable-00784",
John Zulauf7acac592017-11-06 11:15:53 -07002048 "vkCreateGraphicsPipelines(): parameter "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002049 "pCreateInfos[%d].pMultisampleState->sampleShadingEnable.",
2050 i);
John Zulauf7acac592017-11-06 11:15:53 -07002051 }
2052 // TODO Add documentation issue about when minSampleShading must be in range and when it is ignored
2053 // For now a "least noise" test *only* when sampleShadingEnable is VK_TRUE.
2054 if (!in_inclusive_range(pCreateInfos[i].pMultisampleState->minSampleShading, 0.F, 1.0F)) {
2055 skip |= log_msg(
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002056 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002057 "VUID-VkPipelineMultisampleStateCreateInfo-minSampleShading-00786",
Mark Lobodzinski88529492018-04-01 10:38:15 -06002058 "vkCreateGraphicsPipelines(): parameter pCreateInfos[%d].pMultisampleState->minSampleShading.", i);
John Zulauf7acac592017-11-06 11:15:53 -07002059 }
2060 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002061 }
2062
Petr Krause91f7a12017-12-14 20:57:36 +01002063 bool uses_color_attachment = false;
2064 bool uses_depthstencil_attachment = false;
2065 {
2066 const auto subpasses_uses_it = device_data->renderpasses_states.find(pCreateInfos[i].renderPass);
2067 if (subpasses_uses_it != device_data->renderpasses_states.end()) {
2068 const auto &subpasses_uses = subpasses_uses_it->second;
2069 if (subpasses_uses.subpasses_using_color_attachment.count(pCreateInfos[i].subpass))
2070 uses_color_attachment = true;
2071 if (subpasses_uses.subpasses_using_depthstencil_attachment.count(pCreateInfos[i].subpass))
2072 uses_depthstencil_attachment = true;
2073 }
2074 }
2075
2076 if (pCreateInfos[i].pDepthStencilState != nullptr && uses_depthstencil_attachment) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002077 skip |= validate_struct_pnext(
2078 report_data, "vkCreateGraphicsPipelines",
2079 ParameterName("pCreateInfos[%i].pDepthStencilState->pNext", ParameterName::IndexVector{i}), NULL,
Dave Houlton413a6782018-05-22 13:01:54 -06002080 pCreateInfos[i].pDepthStencilState->pNext, 0, NULL, GeneratedHeaderVersion,
2081 "VUID-VkPipelineDepthStencilStateCreateInfo-pNext-pNext");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002082
2083 skip |= validate_reserved_flags(
2084 report_data, "vkCreateGraphicsPipelines",
2085 ParameterName("pCreateInfos[%i].pDepthStencilState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06002086 pCreateInfos[i].pDepthStencilState->flags, "VUID-VkPipelineDepthStencilStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002087
2088 skip |= validate_bool32(
2089 report_data, "vkCreateGraphicsPipelines",
2090 ParameterName("pCreateInfos[%i].pDepthStencilState->depthTestEnable", ParameterName::IndexVector{i}),
2091 pCreateInfos[i].pDepthStencilState->depthTestEnable);
2092
2093 skip |= validate_bool32(
2094 report_data, "vkCreateGraphicsPipelines",
2095 ParameterName("pCreateInfos[%i].pDepthStencilState->depthWriteEnable", ParameterName::IndexVector{i}),
2096 pCreateInfos[i].pDepthStencilState->depthWriteEnable);
2097
2098 skip |= validate_ranged_enum(
2099 report_data, "vkCreateGraphicsPipelines",
2100 ParameterName("pCreateInfos[%i].pDepthStencilState->depthCompareOp", ParameterName::IndexVector{i}),
2101 "VkCompareOp", AllVkCompareOpEnums, pCreateInfos[i].pDepthStencilState->depthCompareOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002102 "VUID-VkPipelineDepthStencilStateCreateInfo-depthCompareOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002103
2104 skip |= validate_bool32(
2105 report_data, "vkCreateGraphicsPipelines",
2106 ParameterName("pCreateInfos[%i].pDepthStencilState->depthBoundsTestEnable", ParameterName::IndexVector{i}),
2107 pCreateInfos[i].pDepthStencilState->depthBoundsTestEnable);
2108
2109 skip |= validate_bool32(
2110 report_data, "vkCreateGraphicsPipelines",
2111 ParameterName("pCreateInfos[%i].pDepthStencilState->stencilTestEnable", ParameterName::IndexVector{i}),
2112 pCreateInfos[i].pDepthStencilState->stencilTestEnable);
2113
2114 skip |= validate_ranged_enum(
2115 report_data, "vkCreateGraphicsPipelines",
2116 ParameterName("pCreateInfos[%i].pDepthStencilState->front.failOp", ParameterName::IndexVector{i}),
2117 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->front.failOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002118 "VUID-VkStencilOpState-failOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002119
2120 skip |= validate_ranged_enum(
2121 report_data, "vkCreateGraphicsPipelines",
2122 ParameterName("pCreateInfos[%i].pDepthStencilState->front.passOp", ParameterName::IndexVector{i}),
2123 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->front.passOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002124 "VUID-VkStencilOpState-passOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002125
2126 skip |= validate_ranged_enum(
2127 report_data, "vkCreateGraphicsPipelines",
2128 ParameterName("pCreateInfos[%i].pDepthStencilState->front.depthFailOp", ParameterName::IndexVector{i}),
2129 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->front.depthFailOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002130 "VUID-VkStencilOpState-depthFailOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002131
2132 skip |= validate_ranged_enum(
2133 report_data, "vkCreateGraphicsPipelines",
2134 ParameterName("pCreateInfos[%i].pDepthStencilState->front.compareOp", ParameterName::IndexVector{i}),
2135 "VkCompareOp", AllVkCompareOpEnums, pCreateInfos[i].pDepthStencilState->front.compareOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002136 "VUID-VkPipelineDepthStencilStateCreateInfo-depthCompareOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002137
2138 skip |= validate_ranged_enum(
2139 report_data, "vkCreateGraphicsPipelines",
2140 ParameterName("pCreateInfos[%i].pDepthStencilState->back.failOp", ParameterName::IndexVector{i}),
2141 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->back.failOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002142 "VUID-VkStencilOpState-failOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002143
2144 skip |= validate_ranged_enum(
2145 report_data, "vkCreateGraphicsPipelines",
2146 ParameterName("pCreateInfos[%i].pDepthStencilState->back.passOp", ParameterName::IndexVector{i}),
2147 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->back.passOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002148 "VUID-VkStencilOpState-passOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002149
2150 skip |= validate_ranged_enum(
2151 report_data, "vkCreateGraphicsPipelines",
2152 ParameterName("pCreateInfos[%i].pDepthStencilState->back.depthFailOp", ParameterName::IndexVector{i}),
2153 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->back.depthFailOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002154 "VUID-VkStencilOpState-depthFailOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002155
2156 skip |= validate_ranged_enum(
2157 report_data, "vkCreateGraphicsPipelines",
2158 ParameterName("pCreateInfos[%i].pDepthStencilState->back.compareOp", ParameterName::IndexVector{i}),
2159 "VkCompareOp", AllVkCompareOpEnums, pCreateInfos[i].pDepthStencilState->back.compareOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002160 "VUID-VkPipelineDepthStencilStateCreateInfo-depthCompareOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002161
2162 if (pCreateInfos[i].pDepthStencilState->sType != VK_STRUCTURE_TYPE_PIPELINE_DEPTH_STENCIL_STATE_CREATE_INFO) {
2163 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002164 kVUID_PVError_InvalidStructSType,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002165 "vkCreateGraphicsPipelines: parameter pCreateInfos[%d].pDepthStencilState->sType must be "
2166 "VK_STRUCTURE_TYPE_PIPELINE_DEPTH_STENCIL_STATE_CREATE_INFO",
2167 i);
2168 }
2169 }
2170
Shannon McPherson9b9532b2018-10-24 12:00:09 -06002171 const VkStructureType allowed_structs_VkPipelineColorBlendStateCreateInfo[] = {
2172 VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_ADVANCED_STATE_CREATE_INFO_EXT};
2173
Petr Krause91f7a12017-12-14 20:57:36 +01002174 if (pCreateInfos[i].pColorBlendState != nullptr && uses_color_attachment) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002175 skip |= validate_struct_pnext(
2176 report_data, "vkCreateGraphicsPipelines",
Shannon McPherson9b9532b2018-10-24 12:00:09 -06002177 ParameterName("pCreateInfos[%i].pColorBlendState->pNext", ParameterName::IndexVector{i}),
2178 "VkPipelineColorBlendAdvancedStateCreateInfoEXT", pCreateInfos[i].pColorBlendState->pNext,
2179 ARRAY_SIZE(allowed_structs_VkPipelineColorBlendStateCreateInfo),
2180 allowed_structs_VkPipelineColorBlendStateCreateInfo, GeneratedHeaderVersion,
Dave Houlton413a6782018-05-22 13:01:54 -06002181 "VUID-VkPipelineColorBlendStateCreateInfo-pNext-pNext");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002182
2183 skip |= validate_reserved_flags(
2184 report_data, "vkCreateGraphicsPipelines",
2185 ParameterName("pCreateInfos[%i].pColorBlendState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06002186 pCreateInfos[i].pColorBlendState->flags, "VUID-VkPipelineColorBlendStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002187
2188 skip |= validate_bool32(
2189 report_data, "vkCreateGraphicsPipelines",
2190 ParameterName("pCreateInfos[%i].pColorBlendState->logicOpEnable", ParameterName::IndexVector{i}),
2191 pCreateInfos[i].pColorBlendState->logicOpEnable);
2192
2193 skip |= validate_array(
2194 report_data, "vkCreateGraphicsPipelines",
2195 ParameterName("pCreateInfos[%i].pColorBlendState->attachmentCount", ParameterName::IndexVector{i}),
2196 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments", ParameterName::IndexVector{i}),
Gabríel Arthúr Pétursson092b29b2018-03-21 22:44:11 +00002197 pCreateInfos[i].pColorBlendState->attachmentCount, &pCreateInfos[i].pColorBlendState->pAttachments, false,
Dave Houlton413a6782018-05-22 13:01:54 -06002198 true, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002199
2200 if (pCreateInfos[i].pColorBlendState->pAttachments != NULL) {
2201 for (uint32_t attachmentIndex = 0; attachmentIndex < pCreateInfos[i].pColorBlendState->attachmentCount;
2202 ++attachmentIndex) {
2203 skip |= validate_bool32(report_data, "vkCreateGraphicsPipelines",
2204 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].blendEnable",
2205 ParameterName::IndexVector{i, attachmentIndex}),
2206 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].blendEnable);
2207
2208 skip |= validate_ranged_enum(
2209 report_data, "vkCreateGraphicsPipelines",
2210 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].srcColorBlendFactor",
2211 ParameterName::IndexVector{i, attachmentIndex}),
2212 "VkBlendFactor", AllVkBlendFactorEnums,
2213 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].srcColorBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06002214 "VUID-VkPipelineColorBlendAttachmentState-srcColorBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002215
2216 skip |= validate_ranged_enum(
2217 report_data, "vkCreateGraphicsPipelines",
2218 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].dstColorBlendFactor",
2219 ParameterName::IndexVector{i, attachmentIndex}),
2220 "VkBlendFactor", AllVkBlendFactorEnums,
2221 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].dstColorBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06002222 "VUID-VkPipelineColorBlendAttachmentState-dstColorBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002223
2224 skip |= validate_ranged_enum(
2225 report_data, "vkCreateGraphicsPipelines",
2226 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].colorBlendOp",
2227 ParameterName::IndexVector{i, attachmentIndex}),
2228 "VkBlendOp", AllVkBlendOpEnums,
2229 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].colorBlendOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002230 "VUID-VkPipelineColorBlendAttachmentState-colorBlendOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002231
2232 skip |= validate_ranged_enum(
2233 report_data, "vkCreateGraphicsPipelines",
2234 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].srcAlphaBlendFactor",
2235 ParameterName::IndexVector{i, attachmentIndex}),
2236 "VkBlendFactor", AllVkBlendFactorEnums,
2237 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].srcAlphaBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06002238 "VUID-VkPipelineColorBlendAttachmentState-srcAlphaBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002239
2240 skip |= validate_ranged_enum(
2241 report_data, "vkCreateGraphicsPipelines",
2242 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].dstAlphaBlendFactor",
2243 ParameterName::IndexVector{i, attachmentIndex}),
2244 "VkBlendFactor", AllVkBlendFactorEnums,
2245 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].dstAlphaBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06002246 "VUID-VkPipelineColorBlendAttachmentState-dstAlphaBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002247
2248 skip |= validate_ranged_enum(
2249 report_data, "vkCreateGraphicsPipelines",
2250 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].alphaBlendOp",
2251 ParameterName::IndexVector{i, attachmentIndex}),
2252 "VkBlendOp", AllVkBlendOpEnums,
2253 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].alphaBlendOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002254 "VUID-VkPipelineColorBlendAttachmentState-alphaBlendOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002255
2256 skip |=
2257 validate_flags(report_data, "vkCreateGraphicsPipelines",
2258 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].colorWriteMask",
2259 ParameterName::IndexVector{i, attachmentIndex}),
2260 "VkColorComponentFlagBits", AllVkColorComponentFlagBits,
2261 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].colorWriteMask,
Dave Houlton413a6782018-05-22 13:01:54 -06002262 false, false, "VUID-VkPipelineColorBlendAttachmentState-colorWriteMask-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002263 }
2264 }
2265
2266 if (pCreateInfos[i].pColorBlendState->sType != VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO) {
2267 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002268 kVUID_PVError_InvalidStructSType,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002269 "vkCreateGraphicsPipelines: parameter pCreateInfos[%d].pColorBlendState->sType must be "
2270 "VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO",
2271 i);
2272 }
2273
2274 // If logicOpEnable is VK_TRUE, logicOp must be a valid VkLogicOp value
2275 if (pCreateInfos[i].pColorBlendState->logicOpEnable == VK_TRUE) {
2276 skip |= validate_ranged_enum(
2277 report_data, "vkCreateGraphicsPipelines",
2278 ParameterName("pCreateInfos[%i].pColorBlendState->logicOp", ParameterName::IndexVector{i}), "VkLogicOp",
Dave Houlton413a6782018-05-22 13:01:54 -06002279 AllVkLogicOpEnums, pCreateInfos[i].pColorBlendState->logicOp,
2280 "VUID-VkPipelineColorBlendStateCreateInfo-logicOpEnable-00607");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002281 }
2282 }
2283 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002284
Petr Kraus9752aae2017-11-24 03:05:50 +01002285 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_DERIVATIVE_BIT) {
2286 if (pCreateInfos[i].basePipelineIndex != -1) {
2287 if (pCreateInfos[i].basePipelineHandle != VK_NULL_HANDLE) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07002288 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002289 "VUID-VkGraphicsPipelineCreateInfo-flags-00724",
Dave Houltona9df0ce2018-02-07 10:51:23 -07002290 "vkCreateGraphicsPipelines parameter, pCreateInfos->basePipelineHandle, must be "
2291 "VK_NULL_HANDLE if pCreateInfos->flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT flag "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002292 "and pCreateInfos->basePipelineIndex is not -1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002293 }
2294 }
2295
Petr Kraus9752aae2017-11-24 03:05:50 +01002296 if (pCreateInfos[i].basePipelineHandle != VK_NULL_HANDLE) {
2297 if (pCreateInfos[i].basePipelineIndex != -1) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07002298 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002299 "VUID-VkGraphicsPipelineCreateInfo-flags-00725",
Dave Houltona9df0ce2018-02-07 10:51:23 -07002300 "vkCreateGraphicsPipelines parameter, pCreateInfos->basePipelineIndex, must be -1 if "
2301 "pCreateInfos->flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT flag and "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002302 "pCreateInfos->basePipelineHandle is not VK_NULL_HANDLE.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002303 }
2304 }
2305 }
2306
Petr Kraus9752aae2017-11-24 03:05:50 +01002307 if (pCreateInfos[i].pRasterizationState) {
2308 if ((pCreateInfos[i].pRasterizationState->polygonMode != VK_POLYGON_MODE_FILL) &&
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002309 (device_data->physical_device_features.fillModeNonSolid == false)) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07002310 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002311 kVUID_PVError_DeviceFeature,
Dave Houltona9df0ce2018-02-07 10:51:23 -07002312 "vkCreateGraphicsPipelines parameter, VkPolygonMode "
2313 "pCreateInfos->pRasterizationState->polygonMode cannot be VK_POLYGON_MODE_POINT or "
2314 "VK_POLYGON_MODE_LINE if VkPhysicalDeviceFeatures->fillModeNonSolid is false.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002315 }
Petr Kraus299ba622017-11-24 03:09:03 +01002316
2317 if (!has_dynamic_line_width && !device_data->physical_device_features.wideLines &&
2318 (pCreateInfos[i].pRasterizationState->lineWidth != 1.0f)) {
Dave Houlton413a6782018-05-22 13:01:54 -06002319 skip |=
2320 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
2321 0, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-00749",
2322 "The line width state is static (pCreateInfos[%" PRIu32
2323 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_LINE_WIDTH) and "
2324 "VkPhysicalDeviceFeatures::wideLines is disabled, but pCreateInfos[%" PRIu32
2325 "].pRasterizationState->lineWidth (=%f) is not 1.0.",
2326 i, i, pCreateInfos[i].pRasterizationState->lineWidth);
Petr Kraus299ba622017-11-24 03:09:03 +01002327 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002328 }
2329
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002330 for (size_t j = 0; j < pCreateInfos[i].stageCount; j++) {
2331 skip |= validate_string(device_data->report_data, "vkCreateGraphicsPipelines",
2332 ParameterName("pCreateInfos[%i].pStages[%i].pName", ParameterName::IndexVector{i, j}),
Mark Lobodzinskiebee3552018-05-29 09:55:54 -06002333 "VUID-VkGraphicsPipelineCreateInfo-pStages-parameter", pCreateInfos[i].pStages[j].pName);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002334 }
2335 }
2336 }
2337
2338 return skip;
2339}
2340
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002341bool pv_vkCreateComputePipelines(VkDevice device, VkPipelineCache pipelineCache, uint32_t createInfoCount,
2342 const VkComputePipelineCreateInfo *pCreateInfos, const VkAllocationCallbacks *pAllocator,
2343 VkPipeline *pPipelines) {
2344 bool skip = false;
2345 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2346
2347 for (uint32_t i = 0; i < createInfoCount; i++) {
2348 skip |= validate_string(device_data->report_data, "vkCreateComputePipelines",
2349 ParameterName("pCreateInfos[%i].stage.pName", ParameterName::IndexVector{i}),
Mark Lobodzinskiebee3552018-05-29 09:55:54 -06002350 "VUID-VkPipelineShaderStageCreateInfo-pName-parameter", pCreateInfos[i].stage.pName);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002351 }
2352
2353 return skip;
2354}
2355
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002356bool pv_vkCreateSampler(VkDevice device, const VkSamplerCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
2357 VkSampler *pSampler) {
2358 bool skip = false;
2359 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2360 debug_report_data *report_data = device_data->report_data;
2361
2362 if (pCreateInfo != nullptr) {
John Zulauf71968502017-10-26 13:51:15 -06002363 const auto &features = device_data->physical_device_features;
2364 const auto &limits = device_data->device_limits;
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002365
John Zulauf71968502017-10-26 13:51:15 -06002366 if (pCreateInfo->anisotropyEnable == VK_TRUE) {
2367 if (!in_inclusive_range(pCreateInfo->maxAnisotropy, 1.0F, limits.maxSamplerAnisotropy)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002368 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002369 "VUID-VkSamplerCreateInfo-anisotropyEnable-01071",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002370 "vkCreateSampler(): value of %s must be in range [1.0, %f] %s, but %f found.",
John Zulauf71968502017-10-26 13:51:15 -06002371 "pCreateInfo->maxAnisotropy", limits.maxSamplerAnisotropy,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002372 "VkPhysicalDeviceLimits::maxSamplerAnistropy", pCreateInfo->maxAnisotropy);
John Zulauf71968502017-10-26 13:51:15 -06002373 }
2374
2375 // Anistropy cannot be enabled in sampler unless enabled as a feature
2376 if (features.samplerAnisotropy == VK_FALSE) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002377 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002378 "VUID-VkSamplerCreateInfo-anisotropyEnable-01070",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002379 "vkCreateSampler(): Anisotropic sampling feature is not enabled, %s must be VK_FALSE.",
2380 "pCreateInfo->anisotropyEnable");
John Zulauf71968502017-10-26 13:51:15 -06002381 }
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002382 }
John Zulauf71968502017-10-26 13:51:15 -06002383
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002384 if (pCreateInfo->unnormalizedCoordinates == VK_TRUE) {
2385 if (pCreateInfo->minFilter != pCreateInfo->magFilter) {
2386 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
2387 "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01072",
2388 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
2389 "pCreateInfo->minFilter (%s) and pCreateInfo->magFilter (%s) must be equal.",
2390 string_VkFilter(pCreateInfo->minFilter), string_VkFilter(pCreateInfo->magFilter));
2391 }
2392 if (pCreateInfo->mipmapMode != VK_SAMPLER_MIPMAP_MODE_NEAREST) {
2393 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
2394 "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01073",
2395 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
2396 "pCreateInfo->mipmapMode (%s) must be VK_SAMPLER_MIPMAP_MODE_NEAREST.",
2397 string_VkSamplerMipmapMode(pCreateInfo->mipmapMode));
2398 }
2399 if (pCreateInfo->minLod != 0.0f || pCreateInfo->maxLod != 0.0f) {
2400 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
2401 "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01074",
2402 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
2403 "pCreateInfo->minLod (%f) and pCreateInfo->maxLod (%f) must both be zero.",
2404 pCreateInfo->minLod, pCreateInfo->maxLod);
2405 }
2406 if ((pCreateInfo->addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE &&
2407 pCreateInfo->addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER) ||
2408 (pCreateInfo->addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE &&
2409 pCreateInfo->addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER)) {
2410 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
2411 "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01075",
2412 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
2413 "pCreateInfo->addressModeU (%s) and pCreateInfo->addressModeV (%s) must both be "
2414 "VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE or VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER.",
2415 string_VkSamplerAddressMode(pCreateInfo->addressModeU),
2416 string_VkSamplerAddressMode(pCreateInfo->addressModeV));
2417 }
2418 if (pCreateInfo->anisotropyEnable == VK_TRUE) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002419 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002420 "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01076",
Dave Houltona9df0ce2018-02-07 10:51:23 -07002421 "vkCreateSampler(): pCreateInfo->anisotropyEnable and pCreateInfo->unnormalizedCoordinates must "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002422 "not both be VK_TRUE.");
John Zulauf71968502017-10-26 13:51:15 -06002423 }
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002424 if (pCreateInfo->compareEnable == VK_TRUE) {
2425 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
2426 "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01077",
2427 "vkCreateSampler(): pCreateInfo->compareEnable and pCreateInfo->unnormalizedCoordinates must "
2428 "not both be VK_TRUE.");
2429 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002430 }
2431
2432 // If compareEnable is VK_TRUE, compareOp must be a valid VkCompareOp value
2433 if (pCreateInfo->compareEnable == VK_TRUE) {
Dave Houlton413a6782018-05-22 13:01:54 -06002434 skip |=
2435 validate_ranged_enum(report_data, "vkCreateSampler", "pCreateInfo->compareOp", "VkCompareOp", AllVkCompareOpEnums,
2436 pCreateInfo->compareOp, "VUID-VkSamplerCreateInfo-compareEnable-01080");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002437 }
2438
2439 // If any of addressModeU, addressModeV or addressModeW are VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER, borderColor must be a
2440 // valid VkBorderColor value
2441 if ((pCreateInfo->addressModeU == VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER) ||
2442 (pCreateInfo->addressModeV == VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER) ||
2443 (pCreateInfo->addressModeW == VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER)) {
2444 skip |= validate_ranged_enum(report_data, "vkCreateSampler", "pCreateInfo->borderColor", "VkBorderColor",
Dave Houlton413a6782018-05-22 13:01:54 -06002445 AllVkBorderColorEnums, pCreateInfo->borderColor,
2446 "VUID-VkSamplerCreateInfo-addressModeU-01078");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002447 }
2448
2449 // If any of addressModeU, addressModeV or addressModeW are VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE, the
2450 // VK_KHR_sampler_mirror_clamp_to_edge extension must be enabled
2451 if (!device_data->extensions.vk_khr_sampler_mirror_clamp_to_edge &&
2452 ((pCreateInfo->addressModeU == VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE) ||
2453 (pCreateInfo->addressModeV == VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE) ||
2454 (pCreateInfo->addressModeW == VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE))) {
Dave Houlton413a6782018-05-22 13:01:54 -06002455 skip |=
2456 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
2457 "VUID-VkSamplerCreateInfo-addressModeU-01079",
2458 "vkCreateSampler(): A VkSamplerAddressMode value is set to VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE "
2459 "but the VK_KHR_sampler_mirror_clamp_to_edge extension has not been enabled.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002460 }
John Zulauf275805c2017-10-26 15:34:49 -06002461
2462 // Checks for the IMG cubic filtering extension
2463 if (device_data->extensions.vk_img_filter_cubic) {
2464 if ((pCreateInfo->anisotropyEnable == VK_TRUE) &&
2465 ((pCreateInfo->minFilter == VK_FILTER_CUBIC_IMG) || (pCreateInfo->magFilter == VK_FILTER_CUBIC_IMG))) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002466 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002467 "VUID-VkSamplerCreateInfo-magFilter-01081",
Dave Houltona9df0ce2018-02-07 10:51:23 -07002468 "vkCreateSampler(): Anisotropic sampling must not be VK_TRUE when either minFilter or magFilter "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002469 "are VK_FILTER_CUBIC_IMG.");
John Zulauf275805c2017-10-26 15:34:49 -06002470 }
2471 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002472 }
2473
2474 return skip;
2475}
2476
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002477bool pv_vkCreateDescriptorSetLayout(VkDevice device, const VkDescriptorSetLayoutCreateInfo *pCreateInfo,
2478 const VkAllocationCallbacks *pAllocator, VkDescriptorSetLayout *pSetLayout) {
2479 bool skip = false;
2480 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2481 debug_report_data *report_data = device_data->report_data;
2482
2483 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
2484 if ((pCreateInfo != nullptr) && (pCreateInfo->pBindings != nullptr)) {
2485 for (uint32_t i = 0; i < pCreateInfo->bindingCount; ++i) {
2486 if (pCreateInfo->pBindings[i].descriptorCount != 0) {
2487 // If descriptorType is VK_DESCRIPTOR_TYPE_SAMPLER or VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER, and descriptorCount
2488 // is not 0 and pImmutableSamplers is not NULL, pImmutableSamplers must be a pointer to an array of descriptorCount
2489 // valid VkSampler handles
2490 if (((pCreateInfo->pBindings[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLER) ||
2491 (pCreateInfo->pBindings[i].descriptorType == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER)) &&
2492 (pCreateInfo->pBindings[i].pImmutableSamplers != nullptr)) {
2493 for (uint32_t descriptor_index = 0; descriptor_index < pCreateInfo->pBindings[i].descriptorCount;
2494 ++descriptor_index) {
2495 if (pCreateInfo->pBindings[i].pImmutableSamplers[descriptor_index] == VK_NULL_HANDLE) {
2496 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002497 kVUID_PVError_RequiredParameter,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002498 "vkCreateDescriptorSetLayout: required parameter "
Dave Houltona9df0ce2018-02-07 10:51:23 -07002499 "pCreateInfo->pBindings[%d].pImmutableSamplers[%d] specified as VK_NULL_HANDLE",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002500 i, descriptor_index);
2501 }
2502 }
2503 }
2504
2505 // If descriptorCount is not 0, stageFlags must be a valid combination of VkShaderStageFlagBits values
2506 if ((pCreateInfo->pBindings[i].stageFlags != 0) &&
2507 ((pCreateInfo->pBindings[i].stageFlags & (~AllVkShaderStageFlagBits)) != 0)) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07002508 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002509 "VUID-VkDescriptorSetLayoutBinding-descriptorCount-00283",
Dave Houltona9df0ce2018-02-07 10:51:23 -07002510 "vkCreateDescriptorSetLayout(): if pCreateInfo->pBindings[%d].descriptorCount is not 0, "
2511 "pCreateInfo->pBindings[%d].stageFlags must be a valid combination of VkShaderStageFlagBits "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002512 "values.",
2513 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002514 }
2515 }
2516 }
2517 }
2518
2519 return skip;
2520}
2521
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002522bool pv_vkFreeDescriptorSets(VkDevice device, VkDescriptorPool descriptorPool, uint32_t descriptorSetCount,
2523 const VkDescriptorSet *pDescriptorSets) {
2524 bool skip = false;
2525 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2526 debug_report_data *report_data = device_data->report_data;
2527
2528 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
2529 // This is an array of handles, where the elements are allowed to be VK_NULL_HANDLE, and does not require any validation beyond
2530 // validate_array()
2531 skip |= validate_array(report_data, "vkFreeDescriptorSets", "descriptorSetCount", "pDescriptorSets", descriptorSetCount,
Dave Houlton413a6782018-05-22 13:01:54 -06002532 &pDescriptorSets, true, true, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002533 return skip;
2534}
2535
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002536bool pv_vkUpdateDescriptorSets(VkDevice device, uint32_t descriptorWriteCount, const VkWriteDescriptorSet *pDescriptorWrites,
2537 uint32_t descriptorCopyCount, const VkCopyDescriptorSet *pDescriptorCopies) {
2538 bool skip = false;
2539 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2540 debug_report_data *report_data = device_data->report_data;
2541
2542 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
2543 if (pDescriptorWrites != NULL) {
2544 for (uint32_t i = 0; i < descriptorWriteCount; ++i) {
2545 // descriptorCount must be greater than 0
2546 if (pDescriptorWrites[i].descriptorCount == 0) {
2547 skip |=
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002548 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002549 "VUID-VkWriteDescriptorSet-descriptorCount-arraylength",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002550 "vkUpdateDescriptorSets(): parameter pDescriptorWrites[%d].descriptorCount must be greater than 0.", i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002551 }
2552
2553 // dstSet must be a valid VkDescriptorSet handle
2554 skip |= validate_required_handle(report_data, "vkUpdateDescriptorSets",
2555 ParameterName("pDescriptorWrites[%i].dstSet", ParameterName::IndexVector{i}),
2556 pDescriptorWrites[i].dstSet);
2557
2558 if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLER) ||
2559 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER) ||
2560 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE) ||
2561 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_IMAGE) ||
2562 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT)) {
2563 // If descriptorType is VK_DESCRIPTOR_TYPE_SAMPLER, VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER,
2564 // VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE, VK_DESCRIPTOR_TYPE_STORAGE_IMAGE or VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT,
2565 // pImageInfo must be a pointer to an array of descriptorCount valid VkDescriptorImageInfo structures
2566 if (pDescriptorWrites[i].pImageInfo == nullptr) {
2567 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002568 "VUID-VkWriteDescriptorSet-descriptorType-00322",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002569 "vkUpdateDescriptorSets(): if pDescriptorWrites[%d].descriptorType is "
2570 "VK_DESCRIPTOR_TYPE_SAMPLER, VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER, "
2571 "VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE, VK_DESCRIPTOR_TYPE_STORAGE_IMAGE or "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002572 "VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT, pDescriptorWrites[%d].pImageInfo must not be NULL.",
2573 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002574 } else if (pDescriptorWrites[i].descriptorType != VK_DESCRIPTOR_TYPE_SAMPLER) {
2575 // If descriptorType is VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER, VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE,
2576 // VK_DESCRIPTOR_TYPE_STORAGE_IMAGE or VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT, the imageView and imageLayout
2577 // members of any given element of pImageInfo must be a valid VkImageView and VkImageLayout, respectively
2578 for (uint32_t descriptor_index = 0; descriptor_index < pDescriptorWrites[i].descriptorCount;
2579 ++descriptor_index) {
2580 skip |= validate_required_handle(report_data, "vkUpdateDescriptorSets",
2581 ParameterName("pDescriptorWrites[%i].pImageInfo[%i].imageView",
2582 ParameterName::IndexVector{i, descriptor_index}),
2583 pDescriptorWrites[i].pImageInfo[descriptor_index].imageView);
2584 skip |= validate_ranged_enum(report_data, "vkUpdateDescriptorSets",
2585 ParameterName("pDescriptorWrites[%i].pImageInfo[%i].imageLayout",
2586 ParameterName::IndexVector{i, descriptor_index}),
2587 "VkImageLayout", AllVkImageLayoutEnums,
Dave Houlton413a6782018-05-22 13:01:54 -06002588 pDescriptorWrites[i].pImageInfo[descriptor_index].imageLayout, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002589 }
2590 }
2591 } else if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER) ||
2592 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER) ||
2593 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC) ||
2594 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC)) {
2595 // If descriptorType is VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER, VK_DESCRIPTOR_TYPE_STORAGE_BUFFER,
2596 // VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC or VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC, pBufferInfo must be a
2597 // pointer to an array of descriptorCount valid VkDescriptorBufferInfo structures
2598 if (pDescriptorWrites[i].pBufferInfo == nullptr) {
2599 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002600 "VUID-VkWriteDescriptorSet-descriptorType-00324",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002601 "vkUpdateDescriptorSets(): if pDescriptorWrites[%d].descriptorType is "
2602 "VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER, VK_DESCRIPTOR_TYPE_STORAGE_BUFFER, "
2603 "VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC or VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC, "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002604 "pDescriptorWrites[%d].pBufferInfo must not be NULL.",
2605 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002606 } else {
2607 for (uint32_t descriptorIndex = 0; descriptorIndex < pDescriptorWrites[i].descriptorCount; ++descriptorIndex) {
2608 skip |= validate_required_handle(report_data, "vkUpdateDescriptorSets",
2609 ParameterName("pDescriptorWrites[%i].pBufferInfo[%i].buffer",
2610 ParameterName::IndexVector{i, descriptorIndex}),
2611 pDescriptorWrites[i].pBufferInfo[descriptorIndex].buffer);
2612 }
2613 }
2614 } else if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER) ||
2615 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER)) {
2616 // If descriptorType is VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER or VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER,
2617 // pTexelBufferView must be a pointer to an array of descriptorCount valid VkBufferView handles
2618 if (pDescriptorWrites[i].pTexelBufferView == nullptr) {
2619 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002620 "VUID-VkWriteDescriptorSet-descriptorType-00323",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002621 "vkUpdateDescriptorSets(): if pDescriptorWrites[%d].descriptorType is "
2622 "VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER or VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER, "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002623 "pDescriptorWrites[%d].pTexelBufferView must not be NULL.",
2624 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002625 } else {
2626 for (uint32_t descriptor_index = 0; descriptor_index < pDescriptorWrites[i].descriptorCount;
2627 ++descriptor_index) {
2628 skip |= validate_required_handle(report_data, "vkUpdateDescriptorSets",
2629 ParameterName("pDescriptorWrites[%i].pTexelBufferView[%i]",
2630 ParameterName::IndexVector{i, descriptor_index}),
2631 pDescriptorWrites[i].pTexelBufferView[descriptor_index]);
2632 }
2633 }
2634 }
2635
2636 if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER) ||
2637 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC)) {
2638 VkDeviceSize uniformAlignment = device_data->device_limits.minUniformBufferOffsetAlignment;
2639 for (uint32_t j = 0; j < pDescriptorWrites[i].descriptorCount; j++) {
2640 if (pDescriptorWrites[i].pBufferInfo != NULL) {
2641 if (SafeModulo(pDescriptorWrites[i].pBufferInfo[j].offset, uniformAlignment) != 0) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06002642 skip |=
2643 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002644 VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0,
2645 "VUID-VkWriteDescriptorSet-descriptorType-00327",
Mark Lobodzinski88529492018-04-01 10:38:15 -06002646 "vkUpdateDescriptorSets(): pDescriptorWrites[%d].pBufferInfo[%d].offset (0x%" PRIxLEAST64
2647 ") must be a multiple of device limit minUniformBufferOffsetAlignment 0x%" PRIxLEAST64 ".",
2648 i, j, pDescriptorWrites[i].pBufferInfo[j].offset, uniformAlignment);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002649 }
2650 }
2651 }
2652 } else if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER) ||
2653 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC)) {
2654 VkDeviceSize storageAlignment = device_data->device_limits.minStorageBufferOffsetAlignment;
2655 for (uint32_t j = 0; j < pDescriptorWrites[i].descriptorCount; j++) {
2656 if (pDescriptorWrites[i].pBufferInfo != NULL) {
2657 if (SafeModulo(pDescriptorWrites[i].pBufferInfo[j].offset, storageAlignment) != 0) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06002658 skip |=
2659 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002660 VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0,
2661 "VUID-VkWriteDescriptorSet-descriptorType-00328",
Mark Lobodzinski88529492018-04-01 10:38:15 -06002662 "vkUpdateDescriptorSets(): pDescriptorWrites[%d].pBufferInfo[%d].offset (0x%" PRIxLEAST64
2663 ") must be a multiple of device limit minStorageBufferOffsetAlignment 0x%" PRIxLEAST64 ".",
2664 i, j, pDescriptorWrites[i].pBufferInfo[j].offset, storageAlignment);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002665 }
2666 }
2667 }
2668 }
2669 }
2670 }
2671 return skip;
2672}
2673
Tobias Hectord942eb92018-10-22 15:18:56 +01002674template <typename RenderPassCreateInfoGeneric>
2675bool pv_CreateRenderPassGeneric(VkDevice device, const RenderPassCreateInfoGeneric *pCreateInfo,
2676 const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass,
2677 RenderPassCreateVersion rp_version) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002678 bool skip = false;
2679 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2680 uint32_t max_color_attachments = device_data->device_limits.maxColorAttachments;
Tobias Hectord942eb92018-10-22 15:18:56 +01002681 bool use_rp2 = (rp_version == RENDER_PASS_VERSION_2);
2682 const char *vuid;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002683
2684 for (uint32_t i = 0; i < pCreateInfo->attachmentCount; ++i) {
2685 if (pCreateInfo->pAttachments[i].format == VK_FORMAT_UNDEFINED) {
2686 std::stringstream ss;
Tobias Hectord942eb92018-10-22 15:18:56 +01002687 ss << (use_rp2 ? "vkCreateRenderPass2KHR" : "vkCreateRenderPass") << ": pCreateInfo->pAttachments[" << i
2688 << "].format is VK_FORMAT_UNDEFINED. ";
2689 vuid = use_rp2 ? "VUID-VkAttachmentDescription2KHR-format-parameter" : "VUID-VkAttachmentDescription-format-parameter";
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002690 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Tobias Hectord942eb92018-10-22 15:18:56 +01002691 vuid, "%s", ss.str().c_str());
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002692 }
2693 if (pCreateInfo->pAttachments[i].finalLayout == VK_IMAGE_LAYOUT_UNDEFINED ||
2694 pCreateInfo->pAttachments[i].finalLayout == VK_IMAGE_LAYOUT_PREINITIALIZED) {
Tobias Hectord942eb92018-10-22 15:18:56 +01002695 vuid =
2696 use_rp2 ? "VUID-VkAttachmentDescription2KHR-finalLayout-03061" : "VUID-VkAttachmentDescription-finalLayout-00843";
2697 skip |=
2698 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, vuid,
2699 "pCreateInfo->pAttachments[%d].finalLayout must not be VK_IMAGE_LAYOUT_UNDEFINED or "
2700 "VK_IMAGE_LAYOUT_PREINITIALIZED.",
2701 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002702 }
2703 }
2704
2705 for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) {
2706 if (pCreateInfo->pSubpasses[i].colorAttachmentCount > max_color_attachments) {
Tobias Hectord942eb92018-10-22 15:18:56 +01002707 vuid = use_rp2 ? "VUID-VkSubpassDescription2KHR-colorAttachmentCount-03063"
2708 : "VUID-VkSubpassDescription-colorAttachmentCount-00845";
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002709 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Tobias Hectord942eb92018-10-22 15:18:56 +01002710 vuid, "Cannot create a render pass with %d color attachments. Max is %d.",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002711 pCreateInfo->pSubpasses[i].colorAttachmentCount, max_color_attachments);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002712 }
2713 }
2714 return skip;
2715}
2716
Tobias Hectord942eb92018-10-22 15:18:56 +01002717bool pv_vkCreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
2718 VkRenderPass *pRenderPass) {
2719 return pv_CreateRenderPassGeneric(device, pCreateInfo, pAllocator, pRenderPass, RENDER_PASS_VERSION_1);
2720}
2721
2722bool pv_vkCreateRenderPass2KHR(VkDevice device, const VkRenderPassCreateInfo2KHR *pCreateInfo,
2723 const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass) {
2724 return pv_CreateRenderPassGeneric(device, pCreateInfo, pAllocator, pRenderPass, RENDER_PASS_VERSION_2);
2725}
2726
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002727bool pv_vkFreeCommandBuffers(VkDevice device, VkCommandPool commandPool, uint32_t commandBufferCount,
2728 const VkCommandBuffer *pCommandBuffers) {
2729 bool skip = false;
2730 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2731 debug_report_data *report_data = device_data->report_data;
2732
2733 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
2734 // This is an array of handles, where the elements are allowed to be VK_NULL_HANDLE, and does not require any validation beyond
2735 // validate_array()
2736 skip |= validate_array(report_data, "vkFreeCommandBuffers", "commandBufferCount", "pCommandBuffers", commandBufferCount,
Dave Houlton413a6782018-05-22 13:01:54 -06002737 &pCommandBuffers, true, true, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002738 return skip;
2739}
2740
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002741bool pv_vkBeginCommandBuffer(VkCommandBuffer commandBuffer, const VkCommandBufferBeginInfo *pBeginInfo) {
2742 bool skip = false;
2743 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2744 debug_report_data *report_data = device_data->report_data;
2745 const VkCommandBufferInheritanceInfo *pInfo = pBeginInfo->pInheritanceInfo;
2746
2747 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
2748 // TODO: pBeginInfo->pInheritanceInfo must not be NULL if commandBuffer is a secondary command buffer
2749 skip |= validate_struct_type(report_data, "vkBeginCommandBuffer", "pBeginInfo->pInheritanceInfo",
2750 "VK_STRUCTURE_TYPE_COMMAND_BUFFER_INHERITANCE_INFO", pBeginInfo->pInheritanceInfo,
Mark Lobodzinskia16ebc72018-06-15 14:47:39 -06002751 VK_STRUCTURE_TYPE_COMMAND_BUFFER_INHERITANCE_INFO, false,
2752 "VUID_vkBeginCommandBuffer-pBeginInfo-parameter", "VUID_VkCommandBufferBeginInfo-sType-sType");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002753
2754 if (pBeginInfo->pInheritanceInfo != NULL) {
Dave Houlton413a6782018-05-22 13:01:54 -06002755 skip |= validate_struct_pnext(report_data, "vkBeginCommandBuffer", "pBeginInfo->pInheritanceInfo->pNext", NULL,
2756 pBeginInfo->pInheritanceInfo->pNext, 0, NULL, GeneratedHeaderVersion,
2757 "VUID-VkCommandBufferBeginInfo-pNext-pNext");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002758
2759 skip |= validate_bool32(report_data, "vkBeginCommandBuffer", "pBeginInfo->pInheritanceInfo->occlusionQueryEnable",
2760 pBeginInfo->pInheritanceInfo->occlusionQueryEnable);
2761
2762 // TODO: This only needs to be validated when the inherited queries feature is enabled
2763 // skip |= validate_flags(report_data, "vkBeginCommandBuffer", "pBeginInfo->pInheritanceInfo->queryFlags",
2764 // "VkQueryControlFlagBits", AllVkQueryControlFlagBits, pBeginInfo->pInheritanceInfo->queryFlags, false);
2765
2766 // TODO: This must be 0 if the pipeline statistics queries feature is not enabled
2767 skip |= validate_flags(report_data, "vkBeginCommandBuffer", "pBeginInfo->pInheritanceInfo->pipelineStatistics",
2768 "VkQueryPipelineStatisticFlagBits", AllVkQueryPipelineStatisticFlagBits,
Dave Houlton413a6782018-05-22 13:01:54 -06002769 pBeginInfo->pInheritanceInfo->pipelineStatistics, false, false, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002770 }
2771
2772 if (pInfo != NULL) {
2773 if ((device_data->physical_device_features.inheritedQueries == VK_FALSE) && (pInfo->occlusionQueryEnable != VK_FALSE)) {
2774 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002775 HandleToUint64(commandBuffer), "VUID-VkCommandBufferInheritanceInfo-occlusionQueryEnable-00056",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002776 "Cannot set inherited occlusionQueryEnable in vkBeginCommandBuffer() when device does not support "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002777 "inheritedQueries.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002778 }
2779 if ((device_data->physical_device_features.inheritedQueries != VK_FALSE) && (pInfo->occlusionQueryEnable != VK_FALSE)) {
2780 skip |= validate_flags(device_data->report_data, "vkBeginCommandBuffer", "pBeginInfo->pInheritanceInfo->queryFlags",
2781 "VkQueryControlFlagBits", AllVkQueryControlFlagBits, pInfo->queryFlags, false, false,
Dave Houlton413a6782018-05-22 13:01:54 -06002782 "VUID-VkCommandBufferInheritanceInfo-queryFlags-00057");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002783 }
2784 }
2785
2786 return skip;
2787}
2788
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002789bool pv_vkCmdSetViewport(VkCommandBuffer commandBuffer, uint32_t firstViewport, uint32_t viewportCount,
2790 const VkViewport *pViewports) {
2791 bool skip = false;
2792 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2793
Petr Krausd55e77c2018-01-09 22:09:25 +01002794 if (!device_data->physical_device_features.multiViewport) {
2795 if (firstViewport != 0) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002796 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002797 HandleToUint64(commandBuffer), "VUID-vkCmdSetViewport-firstViewport-01224",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002798 "vkCmdSetViewport: The multiViewport feature is disabled, but firstViewport (=%" PRIu32 ") is not 0.",
2799 firstViewport);
Petr Krausd55e77c2018-01-09 22:09:25 +01002800 }
2801 if (viewportCount > 1) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002802 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002803 HandleToUint64(commandBuffer), "VUID-vkCmdSetViewport-viewportCount-01225",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002804 "vkCmdSetViewport: The multiViewport feature is disabled, but viewportCount (=%" PRIu32 ") is not 1.",
2805 viewportCount);
Petr Krausd55e77c2018-01-09 22:09:25 +01002806 }
2807 } else { // multiViewport enabled
Petr Kraus7dfeed12018-02-27 20:51:20 +01002808 const uint64_t sum = static_cast<uint64_t>(firstViewport) + static_cast<uint64_t>(viewportCount);
Petr Krausd55e77c2018-01-09 22:09:25 +01002809 if (sum > device_data->device_limits.maxViewports) {
2810 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002811 HandleToUint64(commandBuffer), "VUID-vkCmdSetViewport-firstViewport-01223",
Petr Krausd55e77c2018-01-09 22:09:25 +01002812 "vkCmdSetViewport: firstViewport + viewportCount (=%" PRIu32 " + %" PRIu32 " = %" PRIu64
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002813 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
2814 firstViewport, viewportCount, sum, device_data->device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002815 }
2816 }
Petr Krausb3fcdb42018-01-09 22:09:09 +01002817
2818 if (pViewports) {
2819 for (uint32_t viewport_i = 0; viewport_i < viewportCount; ++viewport_i) {
2820 const auto &viewport = pViewports[viewport_i]; // will crash on invalid ptr
2821 const char fn_name[] = "vkCmdSetViewport";
2822 const std::string param_name = "pViewports[" + std::to_string(viewport_i) + "]";
2823 skip |= pv_VkViewport(device_data, viewport, fn_name, param_name.c_str(),
2824 VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, HandleToUint64(commandBuffer));
2825 }
2826 }
2827
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002828 return skip;
2829}
2830
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002831bool pv_vkCmdSetScissor(VkCommandBuffer commandBuffer, uint32_t firstScissor, uint32_t scissorCount, const VkRect2D *pScissors) {
2832 bool skip = false;
2833 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2834 debug_report_data *report_data = device_data->report_data;
2835
Petr Kraus6260f0a2018-02-27 21:15:55 +01002836 if (!device_data->physical_device_features.multiViewport) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002837 if (firstScissor != 0) {
Petr Kraus6260f0a2018-02-27 21:15:55 +01002838 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002839 HandleToUint64(commandBuffer), "VUID-vkCmdSetScissor-firstScissor-00593",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002840 "vkCmdSetScissor: The multiViewport feature is disabled, but firstScissor (=%" PRIu32 ") is not 0.",
2841 firstScissor);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002842 }
2843 if (scissorCount > 1) {
2844 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002845 HandleToUint64(commandBuffer), "VUID-vkCmdSetScissor-scissorCount-00594",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002846 "vkCmdSetScissor: The multiViewport feature is disabled, but scissorCount (=%" PRIu32 ") is not 1.",
2847 scissorCount);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002848 }
2849 } else { // multiViewport enabled
2850 const uint64_t sum = static_cast<uint64_t>(firstScissor) + static_cast<uint64_t>(scissorCount);
2851 if (sum > device_data->device_limits.maxViewports) {
2852 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002853 HandleToUint64(commandBuffer), "VUID-vkCmdSetScissor-firstScissor-00592",
Petr Kraus6260f0a2018-02-27 21:15:55 +01002854 "vkCmdSetScissor: firstScissor + scissorCount (=%" PRIu32 " + %" PRIu32 " = %" PRIu64
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002855 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
2856 firstScissor, scissorCount, sum, device_data->device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002857 }
2858 }
2859
Petr Kraus6260f0a2018-02-27 21:15:55 +01002860 if (pScissors) {
2861 for (uint32_t scissor_i = 0; scissor_i < scissorCount; ++scissor_i) {
2862 const auto &scissor = pScissors[scissor_i]; // will crash on invalid ptr
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002863
Petr Kraus6260f0a2018-02-27 21:15:55 +01002864 if (scissor.offset.x < 0) {
2865 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002866 HandleToUint64(commandBuffer), "VUID-vkCmdSetScissor-x-00595",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002867 "vkCmdSetScissor: pScissors[%" PRIu32 "].offset.x (=%" PRIi32 ") is negative.", scissor_i,
2868 scissor.offset.x);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002869 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002870
Petr Kraus6260f0a2018-02-27 21:15:55 +01002871 if (scissor.offset.y < 0) {
2872 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002873 HandleToUint64(commandBuffer), "VUID-vkCmdSetScissor-x-00595",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002874 "vkCmdSetScissor: pScissors[%" PRIu32 "].offset.y (=%" PRIi32 ") is negative.", scissor_i,
2875 scissor.offset.y);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002876 }
2877
2878 const int64_t x_sum = static_cast<int64_t>(scissor.offset.x) + static_cast<int64_t>(scissor.extent.width);
2879 if (x_sum > INT32_MAX) {
2880 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002881 HandleToUint64(commandBuffer), "VUID-vkCmdSetScissor-offset-00596",
Petr Kraus6260f0a2018-02-27 21:15:55 +01002882 "vkCmdSetScissor: offset.x + extent.width (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002883 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
2884 scissor.offset.x, scissor.extent.width, x_sum, scissor_i);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002885 }
2886
2887 const int64_t y_sum = static_cast<int64_t>(scissor.offset.y) + static_cast<int64_t>(scissor.extent.height);
2888 if (y_sum > INT32_MAX) {
2889 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002890 HandleToUint64(commandBuffer), "VUID-vkCmdSetScissor-offset-00597",
Petr Kraus6260f0a2018-02-27 21:15:55 +01002891 "vkCmdSetScissor: offset.y + extent.height (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002892 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
2893 scissor.offset.y, scissor.extent.height, y_sum, scissor_i);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002894 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002895 }
2896 }
Petr Kraus6260f0a2018-02-27 21:15:55 +01002897
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002898 return skip;
2899}
2900
Petr Kraus299ba622017-11-24 03:09:03 +01002901bool pv_vkCmdSetLineWidth(VkCommandBuffer commandBuffer, float lineWidth) {
2902 bool skip = false;
2903 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2904 debug_report_data *report_data = device_data->report_data;
2905
2906 if (!device_data->physical_device_features.wideLines && (lineWidth != 1.0f)) {
2907 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002908 HandleToUint64(commandBuffer), "VUID-vkCmdSetLineWidth-lineWidth-00788",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002909 "VkPhysicalDeviceFeatures::wideLines is disabled, but lineWidth (=%f) is not 1.0.", lineWidth);
Petr Kraus299ba622017-11-24 03:09:03 +01002910 }
2911
2912 return skip;
2913}
2914
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002915bool pv_vkCmdDraw(VkCommandBuffer commandBuffer, uint32_t vertexCount, uint32_t instanceCount, uint32_t firstVertex,
2916 uint32_t firstInstance) {
2917 bool skip = false;
2918 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2919 if (vertexCount == 0) {
2920 // TODO: Verify against Valid Usage section. I don't see a non-zero vertexCount listed, may need to add that and make
2921 // this an error or leave as is.
2922 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002923 kVUID_PVError_RequiredParameter, "vkCmdDraw parameter, uint32_t vertexCount, is 0");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002924 }
2925
2926 if (instanceCount == 0) {
2927 // TODO: Verify against Valid Usage section. I don't see a non-zero instanceCount listed, may need to add that and make
2928 // this an error or leave as is.
2929 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002930 kVUID_PVError_RequiredParameter, "vkCmdDraw parameter, uint32_t instanceCount, is 0");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002931 }
2932 return skip;
2933}
2934
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002935bool pv_vkCmdDrawIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, uint32_t count, uint32_t stride) {
2936 bool skip = false;
2937 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2938
2939 if (!device_data->physical_device_features.multiDrawIndirect && ((count > 1))) {
2940 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002941 kVUID_PVError_DeviceFeature,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002942 "CmdDrawIndirect(): Device feature multiDrawIndirect disabled: count must be 0 or 1 but is %d", count);
2943 }
2944 return skip;
2945}
2946
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002947bool pv_vkCmdDrawIndexedIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, uint32_t count,
2948 uint32_t stride) {
2949 bool skip = false;
2950 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2951 if (!device_data->physical_device_features.multiDrawIndirect && ((count > 1))) {
Dave Houlton413a6782018-05-22 13:01:54 -06002952 skip |=
2953 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
2954 kVUID_PVError_DeviceFeature,
2955 "CmdDrawIndexedIndirect(): Device feature multiDrawIndirect disabled: count must be 0 or 1 but is %d", count);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002956 }
2957 return skip;
2958}
2959
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002960bool pv_vkCmdCopyImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkImage dstImage,
2961 VkImageLayout dstImageLayout, uint32_t regionCount, const VkImageCopy *pRegions) {
2962 bool skip = false;
2963 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2964
Dave Houltonf5217612018-02-02 16:18:52 -07002965 VkImageAspectFlags legal_aspect_flags =
2966 VK_IMAGE_ASPECT_COLOR_BIT | VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT | VK_IMAGE_ASPECT_METADATA_BIT;
2967 if (device_data->extensions.vk_khr_sampler_ycbcr_conversion) {
2968 legal_aspect_flags |= (VK_IMAGE_ASPECT_PLANE_0_BIT_KHR | VK_IMAGE_ASPECT_PLANE_1_BIT_KHR | VK_IMAGE_ASPECT_PLANE_2_BIT_KHR);
2969 }
2970
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002971 if (pRegions != nullptr) {
Dave Houltonf5217612018-02-02 16:18:52 -07002972 if ((pRegions->srcSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002973 skip |= log_msg(
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002974 device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002975 "VUID-VkImageSubresourceLayers-aspectMask-parameter",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002976 "vkCmdCopyImage() parameter, VkImageAspect pRegions->srcSubresource.aspectMask, is an unrecognized enumerator.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002977 }
Dave Houltonf5217612018-02-02 16:18:52 -07002978 if ((pRegions->dstSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002979 skip |= log_msg(
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002980 device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002981 "VUID-VkImageSubresourceLayers-aspectMask-parameter",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002982 "vkCmdCopyImage() parameter, VkImageAspect pRegions->dstSubresource.aspectMask, is an unrecognized enumerator.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002983 }
2984 }
2985 return skip;
2986}
2987
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002988bool pv_vkCmdBlitImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkImage dstImage,
2989 VkImageLayout dstImageLayout, uint32_t regionCount, const VkImageBlit *pRegions, VkFilter filter) {
2990 bool skip = false;
2991 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2992
Dave Houltonf5217612018-02-02 16:18:52 -07002993 VkImageAspectFlags legal_aspect_flags =
2994 VK_IMAGE_ASPECT_COLOR_BIT | VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT | VK_IMAGE_ASPECT_METADATA_BIT;
2995 if (device_data->extensions.vk_khr_sampler_ycbcr_conversion) {
2996 legal_aspect_flags |= (VK_IMAGE_ASPECT_PLANE_0_BIT_KHR | VK_IMAGE_ASPECT_PLANE_1_BIT_KHR | VK_IMAGE_ASPECT_PLANE_2_BIT_KHR);
2997 }
2998
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002999 if (pRegions != nullptr) {
Dave Houltonf5217612018-02-02 16:18:52 -07003000 if ((pRegions->srcSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003001 skip |= log_msg(
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06003002 device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003003 kVUID_PVError_UnrecognizedValue,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003004 "vkCmdBlitImage() parameter, VkImageAspect pRegions->srcSubresource.aspectMask, is an unrecognized enumerator");
3005 }
Dave Houltonf5217612018-02-02 16:18:52 -07003006 if ((pRegions->dstSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003007 skip |= log_msg(
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06003008 device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003009 kVUID_PVError_UnrecognizedValue,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003010 "vkCmdBlitImage() parameter, VkImageAspect pRegions->dstSubresource.aspectMask, is an unrecognized enumerator");
3011 }
3012 }
3013 return skip;
3014}
3015
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003016bool pv_vkCmdCopyBufferToImage(VkCommandBuffer commandBuffer, VkBuffer srcBuffer, VkImage dstImage, VkImageLayout dstImageLayout,
3017 uint32_t regionCount, const VkBufferImageCopy *pRegions) {
3018 bool skip = false;
3019 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3020
Dave Houltonf5217612018-02-02 16:18:52 -07003021 VkImageAspectFlags legal_aspect_flags =
3022 VK_IMAGE_ASPECT_COLOR_BIT | VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT | VK_IMAGE_ASPECT_METADATA_BIT;
3023 if (device_data->extensions.vk_khr_sampler_ycbcr_conversion) {
3024 legal_aspect_flags |= (VK_IMAGE_ASPECT_PLANE_0_BIT_KHR | VK_IMAGE_ASPECT_PLANE_1_BIT_KHR | VK_IMAGE_ASPECT_PLANE_2_BIT_KHR);
3025 }
3026
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003027 if (pRegions != nullptr) {
Dave Houltonf5217612018-02-02 16:18:52 -07003028 if ((pRegions->imageSubresource.aspectMask & legal_aspect_flags) == 0) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07003029 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003030 kVUID_PVError_UnrecognizedValue,
Dave Houltona9df0ce2018-02-07 10:51:23 -07003031 "vkCmdCopyBufferToImage() parameter, VkImageAspect pRegions->imageSubresource.aspectMask, is an "
3032 "unrecognized enumerator");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003033 }
3034 }
3035 return skip;
3036}
3037
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003038bool pv_vkCmdCopyImageToBuffer(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkBuffer dstBuffer,
3039 uint32_t regionCount, const VkBufferImageCopy *pRegions) {
3040 bool skip = false;
3041 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3042
Dave Houltonf5217612018-02-02 16:18:52 -07003043 VkImageAspectFlags legal_aspect_flags =
3044 VK_IMAGE_ASPECT_COLOR_BIT | VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT | VK_IMAGE_ASPECT_METADATA_BIT;
3045 if (device_data->extensions.vk_khr_sampler_ycbcr_conversion) {
3046 legal_aspect_flags |= (VK_IMAGE_ASPECT_PLANE_0_BIT_KHR | VK_IMAGE_ASPECT_PLANE_1_BIT_KHR | VK_IMAGE_ASPECT_PLANE_2_BIT_KHR);
3047 }
3048
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003049 if (pRegions != nullptr) {
Dave Houltonf5217612018-02-02 16:18:52 -07003050 if ((pRegions->imageSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06003051 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003052 kVUID_PVError_UnrecognizedValue,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003053 "vkCmdCopyImageToBuffer parameter, VkImageAspect pRegions->imageSubresource.aspectMask, is an unrecognized "
3054 "enumerator");
3055 }
3056 }
3057 return skip;
3058}
3059
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003060bool pv_vkCmdUpdateBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer, VkDeviceSize dstOffset, VkDeviceSize dataSize,
3061 const void *pData) {
3062 bool skip = false;
3063 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3064
3065 if (dstOffset & 3) {
3066 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003067 "VUID-vkCmdUpdateBuffer-dstOffset-00036",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003068 "vkCmdUpdateBuffer() parameter, VkDeviceSize dstOffset (0x%" PRIxLEAST64 "), is not a multiple of 4.",
3069 dstOffset);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003070 }
3071
3072 if ((dataSize <= 0) || (dataSize > 65536)) {
3073 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003074 "VUID-vkCmdUpdateBuffer-dataSize-00037",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003075 "vkCmdUpdateBuffer() parameter, VkDeviceSize dataSize (0x%" PRIxLEAST64
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003076 "), must be greater than zero and less than or equal to 65536.",
3077 dataSize);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003078 } else if (dataSize & 3) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003079 skip |=
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06003080 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003081 "VUID-vkCmdUpdateBuffer-dataSize-00038",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003082 "vkCmdUpdateBuffer() parameter, VkDeviceSize dataSize (0x%" PRIxLEAST64 "), is not a multiple of 4.", dataSize);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003083 }
3084 return skip;
3085}
3086
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003087bool pv_vkCmdFillBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer, VkDeviceSize dstOffset, VkDeviceSize size,
3088 uint32_t data) {
3089 bool skip = false;
3090 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3091
3092 if (dstOffset & 3) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003093 skip |=
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06003094 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003095 "VUID-vkCmdFillBuffer-dstOffset-00025",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003096 "vkCmdFillBuffer() parameter, VkDeviceSize dstOffset (0x%" PRIxLEAST64 "), is not a multiple of 4.", dstOffset);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003097 }
3098
3099 if (size != VK_WHOLE_SIZE) {
3100 if (size <= 0) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003101 skip |=
3102 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003103 "VUID-vkCmdFillBuffer-size-00026",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003104 "vkCmdFillBuffer() parameter, VkDeviceSize size (0x%" PRIxLEAST64 "), must be greater than zero.", size);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003105 } else if (size & 3) {
3106 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003107 "VUID-vkCmdFillBuffer-size-00028",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003108 "vkCmdFillBuffer() parameter, VkDeviceSize size (0x%" PRIxLEAST64 "), is not a multiple of 4.", size);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003109 }
3110 }
3111 return skip;
3112}
3113
3114VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateInstanceLayerProperties(uint32_t *pCount, VkLayerProperties *pProperties) {
3115 return util_GetLayerProperties(1, &global_layer, pCount, pProperties);
3116}
3117
3118VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateDeviceLayerProperties(VkPhysicalDevice physicalDevice, uint32_t *pCount,
3119 VkLayerProperties *pProperties) {
3120 return util_GetLayerProperties(1, &global_layer, pCount, pProperties);
3121}
3122
3123VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateInstanceExtensionProperties(const char *pLayerName, uint32_t *pCount,
3124 VkExtensionProperties *pProperties) {
3125 if (pLayerName && !strcmp(pLayerName, global_layer.layerName))
3126 return util_GetExtensionProperties(1, instance_extensions, pCount, pProperties);
3127
3128 return VK_ERROR_LAYER_NOT_PRESENT;
3129}
3130
3131VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateDeviceExtensionProperties(VkPhysicalDevice physicalDevice, const char *pLayerName,
3132 uint32_t *pPropertyCount, VkExtensionProperties *pProperties) {
3133 // Parameter_validation does not have any physical device extensions
3134 if (pLayerName && !strcmp(pLayerName, global_layer.layerName))
3135 return util_GetExtensionProperties(0, NULL, pPropertyCount, pProperties);
3136
3137 instance_layer_data *local_data = GetLayerDataPtr(get_dispatch_key(physicalDevice), instance_layer_data_map);
Dave Houlton413a6782018-05-22 13:01:54 -06003138 bool skip = validate_array(local_data->report_data, "vkEnumerateDeviceExtensionProperties", "pPropertyCount", "pProperties",
3139 pPropertyCount, &pProperties, true, false, false, kVUIDUndefined,
3140 "VUID-vkEnumerateDeviceExtensionProperties-pProperties-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003141 if (skip) return VK_ERROR_VALIDATION_FAILED_EXT;
3142
3143 return local_data->dispatch_table.EnumerateDeviceExtensionProperties(physicalDevice, NULL, pPropertyCount, pProperties);
3144}
3145
3146static bool require_device_extension(layer_data *device_data, bool flag, char const *function_name, char const *extension_name) {
3147 if (!flag) {
3148 return log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003149 kVUID_PVError_ExtensionNotEnabled,
3150 "%s() called even though the %s extension was not enabled for this VkDevice.", function_name,
3151 extension_name);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003152 }
3153
3154 return false;
3155}
3156
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003157bool pv_vkCreateSwapchainKHR(VkDevice device, const VkSwapchainCreateInfoKHR *pCreateInfo, const VkAllocationCallbacks *pAllocator,
3158 VkSwapchainKHR *pSwapchain) {
3159 bool skip = false;
3160 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
3161 debug_report_data *report_data = device_data->report_data;
3162
Mark Lobodzinski88529492018-04-01 10:38:15 -06003163 const LogMiscParams log_misc{report_data, VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT, VK_NULL_HANDLE,
Petr Krause5c37652018-01-05 04:05:12 +01003164 "vkCreateSwapchainKHR"};
3165
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003166 if (pCreateInfo != nullptr) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003167 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
3168 if (pCreateInfo->imageSharingMode == VK_SHARING_MODE_CONCURRENT) {
3169 // If imageSharingMode is VK_SHARING_MODE_CONCURRENT, queueFamilyIndexCount must be greater than 1
3170 if (pCreateInfo->queueFamilyIndexCount <= 1) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06003171 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003172 "VUID-VkSwapchainCreateInfoKHR-imageSharingMode-01278",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003173 "vkCreateSwapchainKHR(): if pCreateInfo->imageSharingMode is VK_SHARING_MODE_CONCURRENT, "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003174 "pCreateInfo->queueFamilyIndexCount must be greater than 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003175 }
3176
3177 // If imageSharingMode is VK_SHARING_MODE_CONCURRENT, pQueueFamilyIndices must be a pointer to an array of
3178 // queueFamilyIndexCount uint32_t values
3179 if (pCreateInfo->pQueueFamilyIndices == nullptr) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06003180 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003181 "VUID-VkSwapchainCreateInfoKHR-imageSharingMode-01277",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003182 "vkCreateSwapchainKHR(): if pCreateInfo->imageSharingMode is VK_SHARING_MODE_CONCURRENT, "
3183 "pCreateInfo->pQueueFamilyIndices must be a pointer to an array of "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003184 "pCreateInfo->queueFamilyIndexCount uint32_t values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003185 } else {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003186 skip |= ValidateQueueFamilies(device_data, pCreateInfo->queueFamilyIndexCount, pCreateInfo->pQueueFamilyIndices,
Dave Houlton413a6782018-05-22 13:01:54 -06003187 "vkCreateSwapchainKHR", "pCreateInfo->pQueueFamilyIndices",
3188 kVUID_PVError_InvalidUsage, kVUID_PVError_InvalidUsage, false);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003189 }
3190 }
3191
Dave Houlton413a6782018-05-22 13:01:54 -06003192 skip |= ValidateGreaterThanZero(pCreateInfo->imageArrayLayers, "pCreateInfo->imageArrayLayers",
3193 "VUID-VkSwapchainCreateInfoKHR-imageArrayLayers-01275", log_misc);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003194 }
3195
3196 return skip;
3197}
3198
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003199bool pv_vkQueuePresentKHR(VkQueue queue, const VkPresentInfoKHR *pPresentInfo) {
3200 bool skip = false;
3201 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(queue), layer_data_map);
3202
3203 if (pPresentInfo && pPresentInfo->pNext) {
John Zulaufde972ac2017-10-26 12:07:05 -06003204 const auto *present_regions = lvl_find_in_chain<VkPresentRegionsKHR>(pPresentInfo->pNext);
3205 if (present_regions) {
3206 // TODO: This and all other pNext extension dependencies should be added to code-generation
3207 skip |= require_device_extension(device_data, device_data->extensions.vk_khr_incremental_present, "vkQueuePresentKHR",
3208 VK_KHR_INCREMENTAL_PRESENT_EXTENSION_NAME);
3209 if (present_regions->swapchainCount != pPresentInfo->swapchainCount) {
3210 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003211 kVUID_PVError_InvalidUsage,
Dave Houltona9df0ce2018-02-07 10:51:23 -07003212 "QueuePresentKHR(): pPresentInfo->swapchainCount has a value of %i but VkPresentRegionsKHR "
3213 "extension swapchainCount is %i. These values must be equal.",
John Zulaufde972ac2017-10-26 12:07:05 -06003214 pPresentInfo->swapchainCount, present_regions->swapchainCount);
3215 }
Dave Houlton413a6782018-05-22 13:01:54 -06003216 skip |=
3217 validate_struct_pnext(device_data->report_data, "QueuePresentKHR", "pCreateInfo->pNext->pNext", NULL,
3218 present_regions->pNext, 0, NULL, GeneratedHeaderVersion, "VUID-VkPresentInfoKHR-pNext-pNext");
John Zulaufde972ac2017-10-26 12:07:05 -06003219 skip |= validate_array(device_data->report_data, "QueuePresentKHR", "pCreateInfo->pNext->swapchainCount",
Gabríel Arthúr Pétursson092b29b2018-03-21 22:44:11 +00003220 "pCreateInfo->pNext->pRegions", present_regions->swapchainCount, &present_regions->pRegions,
Dave Houlton413a6782018-05-22 13:01:54 -06003221 true, false, kVUIDUndefined, kVUIDUndefined);
John Zulaufde972ac2017-10-26 12:07:05 -06003222 for (uint32_t i = 0; i < present_regions->swapchainCount; ++i) {
3223 skip |= validate_array(device_data->report_data, "QueuePresentKHR", "pCreateInfo->pNext->pRegions[].rectangleCount",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003224 "pCreateInfo->pNext->pRegions[].pRectangles", present_regions->pRegions[i].rectangleCount,
Dave Houlton413a6782018-05-22 13:01:54 -06003225 &present_regions->pRegions[i].pRectangles, true, false, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003226 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003227 }
3228 }
3229
3230 return skip;
3231}
3232
3233#ifdef VK_USE_PLATFORM_WIN32_KHR
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003234bool pv_vkCreateWin32SurfaceKHR(VkInstance instance, const VkWin32SurfaceCreateInfoKHR *pCreateInfo,
3235 const VkAllocationCallbacks *pAllocator, VkSurfaceKHR *pSurface) {
3236 auto device_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map);
3237 bool skip = false;
3238
3239 if (pCreateInfo->hwnd == nullptr) {
3240 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003241 "VUID-VkWin32SurfaceCreateInfoKHR-hwnd-01308",
3242 "vkCreateWin32SurfaceKHR(): hwnd must be a valid Win32 HWND but hwnd is NULL.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003243 }
3244
3245 return skip;
3246}
3247#endif // VK_USE_PLATFORM_WIN32_KHR
3248
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003249bool pv_vkDebugMarkerSetObjectNameEXT(VkDevice device, const VkDebugMarkerObjectNameInfoEXT *pNameInfo) {
3250 auto device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
3251 if (pNameInfo->pObjectName) {
3252 device_data->report_data->debugObjectNameMap->insert(
3253 std::make_pair<uint64_t, std::string>((uint64_t &&) pNameInfo->object, pNameInfo->pObjectName));
3254 } else {
3255 device_data->report_data->debugObjectNameMap->erase(pNameInfo->object);
3256 }
3257 return false;
3258}
3259
Petr Krausc8655be2017-09-27 18:56:51 +02003260bool pv_vkCreateDescriptorPool(VkDevice device, const VkDescriptorPoolCreateInfo *pCreateInfo,
3261 const VkAllocationCallbacks *pAllocator, VkDescriptorPool *pDescriptorPool) {
3262 auto device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
3263 bool skip = false;
3264
3265 if (pCreateInfo) {
3266 if (pCreateInfo->maxSets <= 0) {
Dave Houlton413a6782018-05-22 13:01:54 -06003267 skip |=
3268 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT,
3269 VK_NULL_HANDLE, "VUID-VkDescriptorPoolCreateInfo-maxSets-00301",
3270 "vkCreateDescriptorPool(): pCreateInfo->maxSets is not greater than 0.");
Petr Krausc8655be2017-09-27 18:56:51 +02003271 }
3272
3273 if (pCreateInfo->pPoolSizes) {
3274 for (uint32_t i = 0; i < pCreateInfo->poolSizeCount; ++i) {
3275 if (pCreateInfo->pPoolSizes[i].descriptorCount <= 0) {
3276 skip |= log_msg(
3277 device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003278 VK_NULL_HANDLE, "VUID-VkDescriptorPoolSize-descriptorCount-00302",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003279 "vkCreateDescriptorPool(): pCreateInfo->pPoolSizes[%" PRIu32 "].descriptorCount is not greater than 0.", i);
Petr Krausc8655be2017-09-27 18:56:51 +02003280 }
Jeff Bolze54ae892018-09-08 12:16:29 -05003281 if (pCreateInfo->pPoolSizes[i].type == VK_DESCRIPTOR_TYPE_INLINE_UNIFORM_BLOCK_EXT &&
3282 (pCreateInfo->pPoolSizes[i].descriptorCount % 4) != 0) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06003283 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT,
3284 VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, VK_NULL_HANDLE,
3285 "VUID-VkDescriptorPoolSize-type-02218",
3286 "vkCreateDescriptorPool(): pCreateInfo->pPoolSizes[%" PRIu32
3287 "].type is VK_DESCRIPTOR_TYPE_INLINE_UNIFORM_BLOCK_EXT "
3288 " and pCreateInfo->pPoolSizes[%" PRIu32 "].descriptorCount is not a multiple of 4.",
3289 i, i);
Jeff Bolze54ae892018-09-08 12:16:29 -05003290 }
Petr Krausc8655be2017-09-27 18:56:51 +02003291 }
3292 }
3293 }
3294
3295 return skip;
3296}
3297
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003298bool pv_vkCmdDispatch(VkCommandBuffer commandBuffer, uint32_t groupCountX, uint32_t groupCountY, uint32_t groupCountZ) {
3299 bool skip = false;
3300 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3301
3302 if (groupCountX > device_data->device_limits.maxComputeWorkGroupCount[0]) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003303 skip |=
3304 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003305 HandleToUint64(commandBuffer), "VUID-vkCmdDispatch-groupCountX-00386",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003306 "vkCmdDispatch(): groupCountX (%" PRIu32 ") exceeds device limit maxComputeWorkGroupCount[0] (%" PRIu32 ").",
3307 groupCountX, device_data->device_limits.maxComputeWorkGroupCount[0]);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003308 }
3309
3310 if (groupCountY > device_data->device_limits.maxComputeWorkGroupCount[1]) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003311 skip |=
3312 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003313 HandleToUint64(commandBuffer), "VUID-vkCmdDispatch-groupCountY-00387",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003314 "vkCmdDispatch(): groupCountY (%" PRIu32 ") exceeds device limit maxComputeWorkGroupCount[1] (%" PRIu32 ").",
3315 groupCountY, device_data->device_limits.maxComputeWorkGroupCount[1]);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003316 }
3317
3318 if (groupCountZ > device_data->device_limits.maxComputeWorkGroupCount[2]) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003319 skip |=
3320 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003321 HandleToUint64(commandBuffer), "VUID-vkCmdDispatch-groupCountZ-00388",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003322 "vkCmdDispatch(): groupCountZ (%" PRIu32 ") exceeds device limit maxComputeWorkGroupCount[2] (%" PRIu32 ").",
3323 groupCountZ, device_data->device_limits.maxComputeWorkGroupCount[2]);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003324 }
3325
3326 return skip;
3327}
John Zulaufa999d1b2018-11-29 13:38:40 -07003328bool pv_vkCmdDispatchIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset) {
3329 bool skip = false;
3330 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3331
3332 if ((offset % 4) != 0) {
3333 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3334 HandleToUint64(commandBuffer), "VUID-vkCmdDispatchIndirect-offset-00406",
3335 "vkCmdDispatchIndirect(): offset (%" PRIu64 ") must be a multiple of 4.", offset);
3336 }
3337 return skip;
3338}
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003339
Mark Lobodzinskibf973a12018-03-01 08:50:21 -07003340bool pv_vkCmdDispatchBaseKHR(VkCommandBuffer commandBuffer, uint32_t baseGroupX, uint32_t baseGroupY, uint32_t baseGroupZ,
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003341 uint32_t groupCountX, uint32_t groupCountY, uint32_t groupCountZ) {
3342 bool skip = false;
3343 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3344
3345 // Paired if {} else if {} tests used to avoid any possible uint underflow
3346 uint32_t limit = device_data->device_limits.maxComputeWorkGroupCount[0];
3347 if (baseGroupX >= limit) {
3348 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003349 HandleToUint64(commandBuffer), "VUID-vkCmdDispatchBase-baseGroupX-00421",
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003350 "vkCmdDispatch(): baseGroupX (%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003351 ") equals or exceeds device limit maxComputeWorkGroupCount[0] (%" PRIu32 ").",
3352 baseGroupX, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003353 } else if (groupCountX > (limit - baseGroupX)) {
3354 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003355 HandleToUint64(commandBuffer), "VUID-vkCmdDispatchBase-groupCountX-00424",
Mark Lobodzinskibf973a12018-03-01 08:50:21 -07003356 "vkCmdDispatchBaseKHR(): baseGroupX (%" PRIu32 ") + groupCountX (%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003357 ") exceeds device limit maxComputeWorkGroupCount[0] (%" PRIu32 ").",
3358 baseGroupX, groupCountX, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003359 }
3360
3361 limit = device_data->device_limits.maxComputeWorkGroupCount[1];
3362 if (baseGroupY >= limit) {
3363 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003364 HandleToUint64(commandBuffer), "VUID-vkCmdDispatchBase-baseGroupX-00422",
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003365 "vkCmdDispatch(): baseGroupY (%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003366 ") equals or exceeds device limit maxComputeWorkGroupCount[1] (%" PRIu32 ").",
3367 baseGroupY, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003368 } else if (groupCountY > (limit - baseGroupY)) {
3369 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003370 HandleToUint64(commandBuffer), "VUID-vkCmdDispatchBase-groupCountY-00425",
Mark Lobodzinskibf973a12018-03-01 08:50:21 -07003371 "vkCmdDispatchBaseKHR(): baseGroupY (%" PRIu32 ") + groupCountY (%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003372 ") exceeds device limit maxComputeWorkGroupCount[1] (%" PRIu32 ").",
3373 baseGroupY, groupCountY, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003374 }
3375
3376 limit = device_data->device_limits.maxComputeWorkGroupCount[2];
3377 if (baseGroupZ >= limit) {
3378 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003379 HandleToUint64(commandBuffer), "VUID-vkCmdDispatchBase-baseGroupZ-00423",
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003380 "vkCmdDispatch(): baseGroupZ (%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003381 ") equals or exceeds device limit maxComputeWorkGroupCount[2] (%" PRIu32 ").",
3382 baseGroupZ, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003383 } else if (groupCountZ > (limit - baseGroupZ)) {
3384 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003385 HandleToUint64(commandBuffer), "VUID-vkCmdDispatchBase-groupCountZ-00426",
Mark Lobodzinskibf973a12018-03-01 08:50:21 -07003386 "vkCmdDispatchBaseKHR(): baseGroupZ (%" PRIu32 ") + groupCountZ (%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003387 ") exceeds device limit maxComputeWorkGroupCount[2] (%" PRIu32 ").",
3388 baseGroupZ, groupCountZ, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003389 }
3390
3391 return skip;
3392}
3393
Dave Houlton142c4cb2018-10-17 15:04:41 -06003394bool pv_vkCmdSetExclusiveScissorNV(VkCommandBuffer commandBuffer, uint32_t firstExclusiveScissor, uint32_t exclusiveScissorCount,
3395 const VkRect2D *pExclusiveScissors) {
Jeff Bolz3e71f782018-08-29 23:15:45 -05003396 bool skip = false;
3397
3398 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3399 debug_report_data *report_data = device_data->report_data;
3400
3401 if (!device_data->physical_device_features.multiViewport) {
3402 if (firstExclusiveScissor != 0) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06003403 skip |=
3404 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3405 HandleToUint64(commandBuffer), "VUID-vkCmdSetExclusiveScissorNV-firstExclusiveScissor-02035",
3406 "vkCmdSetExclusiveScissorNV: The multiViewport feature is disabled, but firstExclusiveScissor (=%" PRIu32
3407 ") is not 0.",
3408 firstExclusiveScissor);
Jeff Bolz3e71f782018-08-29 23:15:45 -05003409 }
3410 if (exclusiveScissorCount > 1) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06003411 skip |=
3412 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3413 HandleToUint64(commandBuffer), "VUID-vkCmdSetExclusiveScissorNV-exclusiveScissorCount-02036",
3414 "vkCmdSetExclusiveScissorNV: The multiViewport feature is disabled, but exclusiveScissorCount (=%" PRIu32
3415 ") is not 1.",
3416 exclusiveScissorCount);
Jeff Bolz3e71f782018-08-29 23:15:45 -05003417 }
3418 } else { // multiViewport enabled
3419 const uint64_t sum = static_cast<uint64_t>(firstExclusiveScissor) + static_cast<uint64_t>(exclusiveScissorCount);
3420 if (sum > device_data->device_limits.maxViewports) {
3421 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3422 HandleToUint64(commandBuffer), "VUID-vkCmdSetExclusiveScissorNV-firstExclusiveScissor-02034",
Dave Houlton142c4cb2018-10-17 15:04:41 -06003423 "vkCmdSetExclusiveScissorNV: firstExclusiveScissor + exclusiveScissorCount (=%" PRIu32 " + %" PRIu32
3424 " = %" PRIu64 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
Jeff Bolz3e71f782018-08-29 23:15:45 -05003425 firstExclusiveScissor, exclusiveScissorCount, sum, device_data->device_limits.maxViewports);
3426 }
3427 }
3428
3429 if (firstExclusiveScissor >= device_data->device_limits.maxViewports) {
3430 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3431 HandleToUint64(commandBuffer), "VUID-vkCmdSetExclusiveScissorNV-firstExclusiveScissor-02033",
Dave Houlton142c4cb2018-10-17 15:04:41 -06003432 "vkCmdSetExclusiveScissorNV: firstExclusiveScissor (=%" PRIu32 ") must be less than maxViewports (=%" PRIu32
3433 ").",
Jeff Bolz3e71f782018-08-29 23:15:45 -05003434 firstExclusiveScissor, device_data->device_limits.maxViewports);
3435 }
3436
3437 if (pExclusiveScissors) {
3438 for (uint32_t scissor_i = 0; scissor_i < exclusiveScissorCount; ++scissor_i) {
3439 const auto &scissor = pExclusiveScissors[scissor_i]; // will crash on invalid ptr
3440
3441 if (scissor.offset.x < 0) {
3442 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3443 HandleToUint64(commandBuffer), "VUID-vkCmdSetExclusiveScissorNV-x-02037",
Dave Houlton142c4cb2018-10-17 15:04:41 -06003444 "vkCmdSetExclusiveScissorNV: pScissors[%" PRIu32 "].offset.x (=%" PRIi32 ") is negative.",
3445 scissor_i, scissor.offset.x);
Jeff Bolz3e71f782018-08-29 23:15:45 -05003446 }
3447
3448 if (scissor.offset.y < 0) {
3449 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3450 HandleToUint64(commandBuffer), "VUID-vkCmdSetExclusiveScissorNV-x-02037",
Dave Houlton142c4cb2018-10-17 15:04:41 -06003451 "vkCmdSetExclusiveScissorNV: pScissors[%" PRIu32 "].offset.y (=%" PRIi32 ") is negative.",
3452 scissor_i, scissor.offset.y);
Jeff Bolz3e71f782018-08-29 23:15:45 -05003453 }
3454
3455 const int64_t x_sum = static_cast<int64_t>(scissor.offset.x) + static_cast<int64_t>(scissor.extent.width);
3456 if (x_sum > INT32_MAX) {
3457 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3458 HandleToUint64(commandBuffer), "VUID-vkCmdSetExclusiveScissorNV-offset-02038",
3459 "vkCmdSetExclusiveScissorNV: offset.x + extent.width (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
3460 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
3461 scissor.offset.x, scissor.extent.width, x_sum, scissor_i);
3462 }
3463
3464 const int64_t y_sum = static_cast<int64_t>(scissor.offset.y) + static_cast<int64_t>(scissor.extent.height);
3465 if (y_sum > INT32_MAX) {
3466 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3467 HandleToUint64(commandBuffer), "VUID-vkCmdSetExclusiveScissorNV-offset-02039",
3468 "vkCmdSetExclusiveScissorNV: offset.y + extent.height (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
3469 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
3470 scissor.offset.y, scissor.extent.height, y_sum, scissor_i);
3471 }
3472 }
3473 }
3474
3475 return skip;
3476}
3477
Dave Houlton142c4cb2018-10-17 15:04:41 -06003478bool pv_vkCmdSetViewportShadingRatePaletteNV(VkCommandBuffer commandBuffer, uint32_t firstViewport, uint32_t viewportCount,
3479 const VkShadingRatePaletteNV *pShadingRatePalettes) {
Jeff Bolz9af91c52018-09-01 21:53:57 -05003480 bool skip = false;
3481
3482 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3483 debug_report_data *report_data = device_data->report_data;
3484
3485 if (!device_data->physical_device_features.multiViewport) {
3486 if (firstViewport != 0) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06003487 skip |=
3488 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3489 HandleToUint64(commandBuffer), "VUID-vkCmdSetViewportShadingRatePaletteNV-firstViewport-02068",
3490 "vkCmdSetViewportShadingRatePaletteNV: The multiViewport feature is disabled, but firstViewport (=%" PRIu32
3491 ") is not 0.",
3492 firstViewport);
Jeff Bolz9af91c52018-09-01 21:53:57 -05003493 }
3494 if (viewportCount > 1) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06003495 skip |=
3496 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3497 HandleToUint64(commandBuffer), "VUID-vkCmdSetViewportShadingRatePaletteNV-viewportCount-02069",
3498 "vkCmdSetViewportShadingRatePaletteNV: The multiViewport feature is disabled, but viewportCount (=%" PRIu32
3499 ") is not 1.",
3500 viewportCount);
Jeff Bolz9af91c52018-09-01 21:53:57 -05003501 }
3502 }
3503
3504 if (firstViewport >= device_data->device_limits.maxViewports) {
3505 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3506 HandleToUint64(commandBuffer), "VUID-vkCmdSetViewportShadingRatePaletteNV-firstViewport-02066",
Dave Houlton142c4cb2018-10-17 15:04:41 -06003507 "vkCmdSetViewportShadingRatePaletteNV: firstViewport (=%" PRIu32
3508 ") must be less than maxViewports (=%" PRIu32 ").",
Jeff Bolz9af91c52018-09-01 21:53:57 -05003509 firstViewport, device_data->device_limits.maxViewports);
3510 }
3511
3512 const uint64_t sum = static_cast<uint64_t>(firstViewport) + static_cast<uint64_t>(viewportCount);
3513 if (sum > device_data->device_limits.maxViewports) {
3514 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3515 HandleToUint64(commandBuffer), "VUID-vkCmdSetViewportShadingRatePaletteNV-firstViewport-02067",
3516 "vkCmdSetViewportShadingRatePaletteNV: firstViewport + viewportCount (=%" PRIu32 " + %" PRIu32 " = %" PRIu64
3517 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
3518 firstViewport, viewportCount, sum, device_data->device_limits.maxViewports);
3519 }
3520
3521 return skip;
3522}
3523
Dave Houlton142c4cb2018-10-17 15:04:41 -06003524bool pv_vkCmdSetCoarseSampleOrderNV(VkCommandBuffer commandBuffer, VkCoarseSampleOrderTypeNV sampleOrderType,
3525 uint32_t customSampleOrderCount, const VkCoarseSampleOrderCustomNV *pCustomSampleOrders) {
Jeff Bolz9af91c52018-09-01 21:53:57 -05003526 bool skip = false;
3527
3528 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3529 debug_report_data *report_data = device_data->report_data;
3530
Dave Houlton142c4cb2018-10-17 15:04:41 -06003531 if (sampleOrderType != VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV && customSampleOrderCount != 0) {
Jeff Bolz9af91c52018-09-01 21:53:57 -05003532 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3533 HandleToUint64(commandBuffer), "VUID-vkCmdSetCoarseSampleOrderNV-sampleOrderType-02081",
3534 "vkCmdSetCoarseSampleOrderNV: If sampleOrderType is not VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV, "
3535 "customSampleOrderCount must be 0.");
3536 }
3537
3538 for (uint32_t order_i = 0; order_i < customSampleOrderCount; ++order_i) {
3539 skip |= ValidateCoarseSampleOrderCustomNV(device_data, &pCustomSampleOrders[order_i]);
3540 }
3541
3542 return skip;
3543}
3544
Dave Houlton142c4cb2018-10-17 15:04:41 -06003545bool pv_vkCmdDrawMeshTasksNV(VkCommandBuffer commandBuffer, uint32_t taskCount, uint32_t firstTask) {
Jeff Bolz45bf7d62018-09-18 15:39:58 -05003546 bool skip = false;
3547
3548 layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3549
3550 if (taskCount > dev_data->phys_dev_ext_props.mesh_shader_props.maxDrawMeshTasksCount) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06003551 skip |= log_msg(
3552 dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3553 HandleToUint64(commandBuffer), "VUID-vkCmdDrawMeshTasksNV-taskCount-02119",
3554 "vkCmdDrawMeshTasksNV() parameter, uint32_t taskCount (0x%" PRIxLEAST32
3555 "), must be less than or equal to VkPhysicalDeviceMeshShaderPropertiesNV::maxDrawMeshTasksCount (0x%" PRIxLEAST32 ").",
3556 taskCount, dev_data->phys_dev_ext_props.mesh_shader_props.maxDrawMeshTasksCount);
Jeff Bolz45bf7d62018-09-18 15:39:58 -05003557 }
3558
3559 return skip;
3560}
3561
Dave Houlton142c4cb2018-10-17 15:04:41 -06003562bool pv_vkCmdDrawMeshTasksIndirectNV(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, uint32_t drawCount,
3563 uint32_t stride) {
Jeff Bolz45bf7d62018-09-18 15:39:58 -05003564 bool skip = false;
3565
3566 layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3567 debug_report_data *report_data = dev_data->report_data;
3568
3569 if (offset & 3) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06003570 skip |= log_msg(
3571 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3572 HandleToUint64(commandBuffer), "VUID-vkCmdDrawMeshTasksIndirectNV-offset-02145",
3573 "vkCmdDrawMeshTasksIndirectNV() parameter, VkDeviceSize offset (0x%" PRIxLEAST64 "), is not a multiple of 4.", offset);
Jeff Bolz45bf7d62018-09-18 15:39:58 -05003574 }
3575
3576 if (drawCount > 1 && ((stride & 3) || stride < sizeof(VkDrawMeshTasksIndirectCommandNV))) {
3577 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3578 HandleToUint64(commandBuffer), "VUID-vkCmdDrawMeshTasksIndirectNV-drawCount-02146",
3579 "vkCmdDrawMeshTasksIndirectNV() parameter, uint32_t stride (0x%" PRIxLEAST32
3580 "), is not a multiple of 4 or smaller than sizeof (VkDrawMeshTasksIndirectCommandNV).",
3581 stride);
3582 }
3583
Jeff Bolzb574c342018-11-08 15:36:57 -06003584 if (!dev_data->physical_device_features.multiDrawIndirect && ((drawCount > 1))) {
3585 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3586 HandleToUint64(commandBuffer), "VUID-vkCmdDrawMeshTasksIndirectNV-drawCount-02147",
3587 "vkCmdDrawMeshTasksIndirectNV(): Device feature multiDrawIndirect disabled: count must be 0 or 1 but is %d",
3588 drawCount);
3589 }
3590
Jeff Bolz45bf7d62018-09-18 15:39:58 -05003591 return skip;
3592}
3593
Dave Houlton142c4cb2018-10-17 15:04:41 -06003594bool pv_vkCmdDrawMeshTasksIndirectCountNV(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, VkBuffer countBuffer,
3595 VkDeviceSize countBufferOffset, uint32_t maxDrawCount, uint32_t stride) {
Jeff Bolz45bf7d62018-09-18 15:39:58 -05003596 bool skip = false;
3597
3598 layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3599
3600 if (offset & 3) {
3601 skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3602 HandleToUint64(commandBuffer), "VUID-vkCmdDrawMeshTasksIndirectCountNV-offset-02180",
3603 "vkCmdDrawMeshTasksIndirectCountNV() parameter, VkDeviceSize offset (0x%" PRIxLEAST64
3604 "), is not a multiple of 4.",
3605 offset);
3606 }
3607
3608 if (countBufferOffset & 3) {
3609 skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3610 HandleToUint64(commandBuffer), "VUID-vkCmdDrawMeshTasksIndirectCountNV-countBufferOffset-02181",
3611 "vkCmdDrawMeshTasksIndirectCountNV() parameter, VkDeviceSize countBufferOffset (0x%" PRIxLEAST64
3612 "), is not a multiple of 4.",
3613 countBufferOffset);
3614 }
3615
3616 if ((stride & 3) || stride < sizeof(VkDrawMeshTasksIndirectCommandNV)) {
3617 skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3618 HandleToUint64(commandBuffer), "VUID-vkCmdDrawMeshTasksIndirectCountNV-stride-02182",
3619 "vkCmdDrawMeshTasksIndirectCountNV() parameter, uint32_t stride (0x%" PRIxLEAST32
3620 "), is not a multiple of 4 or smaller than sizeof (VkDrawMeshTasksIndirectCommandNV).",
3621 stride);
3622 }
3623
3624 return skip;
3625}
3626
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003627VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetDeviceProcAddr(VkDevice device, const char *funcName) {
Mark Lobodzinskib7a26382018-07-02 13:14:26 -06003628 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
3629 if (!ApiParentExtensionEnabled(funcName, device_data->extensions.device_extension_set)) {
3630 return nullptr;
3631 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003632 const auto item = name_to_funcptr_map.find(funcName);
3633 if (item != name_to_funcptr_map.end()) {
3634 return reinterpret_cast<PFN_vkVoidFunction>(item->second);
3635 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003636 const auto &table = device_data->dispatch_table;
3637 if (!table.GetDeviceProcAddr) return nullptr;
3638 return table.GetDeviceProcAddr(device, funcName);
3639}
3640
3641VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetInstanceProcAddr(VkInstance instance, const char *funcName) {
3642 const auto item = name_to_funcptr_map.find(funcName);
3643 if (item != name_to_funcptr_map.end()) {
3644 return reinterpret_cast<PFN_vkVoidFunction>(item->second);
3645 }
3646
3647 auto instance_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map);
3648 auto &table = instance_data->dispatch_table;
3649 if (!table.GetInstanceProcAddr) return nullptr;
3650 return table.GetInstanceProcAddr(instance, funcName);
3651}
3652
3653VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetPhysicalDeviceProcAddr(VkInstance instance, const char *funcName) {
3654 assert(instance);
3655 auto instance_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map);
3656
3657 if (!instance_data->dispatch_table.GetPhysicalDeviceProcAddr) return nullptr;
3658 return instance_data->dispatch_table.GetPhysicalDeviceProcAddr(instance, funcName);
3659}
3660
3661// If additional validation is needed outside of the generated checks, a manual routine can be added to this file
3662// and the address filled in here. The autogenerated source will call these routines if the pointers are not NULL.
Petr Krausc8655be2017-09-27 18:56:51 +02003663void InitializeManualParameterValidationFunctionPointers() {
Dave Houltonb3bbec72018-01-17 10:13:33 -07003664 custom_functions["vkGetDeviceQueue"] = (void *)pv_vkGetDeviceQueue;
3665 custom_functions["vkCreateBuffer"] = (void *)pv_vkCreateBuffer;
3666 custom_functions["vkCreateImage"] = (void *)pv_vkCreateImage;
3667 custom_functions["vkCreateImageView"] = (void *)pv_vkCreateImageView;
3668 custom_functions["vkCreateGraphicsPipelines"] = (void *)pv_vkCreateGraphicsPipelines;
3669 custom_functions["vkCreateComputePipelines"] = (void *)pv_vkCreateComputePipelines;
3670 custom_functions["vkCreateSampler"] = (void *)pv_vkCreateSampler;
3671 custom_functions["vkCreateDescriptorSetLayout"] = (void *)pv_vkCreateDescriptorSetLayout;
3672 custom_functions["vkFreeDescriptorSets"] = (void *)pv_vkFreeDescriptorSets;
3673 custom_functions["vkUpdateDescriptorSets"] = (void *)pv_vkUpdateDescriptorSets;
3674 custom_functions["vkCreateRenderPass"] = (void *)pv_vkCreateRenderPass;
Tobias Hectord942eb92018-10-22 15:18:56 +01003675 custom_functions["vkCreateRenderPass2KHR"] = (void *)pv_vkCreateRenderPass2KHR;
Dave Houltonb3bbec72018-01-17 10:13:33 -07003676 custom_functions["vkBeginCommandBuffer"] = (void *)pv_vkBeginCommandBuffer;
3677 custom_functions["vkCmdSetViewport"] = (void *)pv_vkCmdSetViewport;
3678 custom_functions["vkCmdSetScissor"] = (void *)pv_vkCmdSetScissor;
Petr Kraus299ba622017-11-24 03:09:03 +01003679 custom_functions["vkCmdSetLineWidth"] = (void *)pv_vkCmdSetLineWidth;
Dave Houltonb3bbec72018-01-17 10:13:33 -07003680 custom_functions["vkCmdDraw"] = (void *)pv_vkCmdDraw;
3681 custom_functions["vkCmdDrawIndirect"] = (void *)pv_vkCmdDrawIndirect;
3682 custom_functions["vkCmdDrawIndexedIndirect"] = (void *)pv_vkCmdDrawIndexedIndirect;
3683 custom_functions["vkCmdCopyImage"] = (void *)pv_vkCmdCopyImage;
3684 custom_functions["vkCmdBlitImage"] = (void *)pv_vkCmdBlitImage;
3685 custom_functions["vkCmdCopyBufferToImage"] = (void *)pv_vkCmdCopyBufferToImage;
3686 custom_functions["vkCmdCopyImageToBuffer"] = (void *)pv_vkCmdCopyImageToBuffer;
3687 custom_functions["vkCmdUpdateBuffer"] = (void *)pv_vkCmdUpdateBuffer;
3688 custom_functions["vkCmdFillBuffer"] = (void *)pv_vkCmdFillBuffer;
3689 custom_functions["vkCreateSwapchainKHR"] = (void *)pv_vkCreateSwapchainKHR;
3690 custom_functions["vkQueuePresentKHR"] = (void *)pv_vkQueuePresentKHR;
3691 custom_functions["vkCreateDescriptorPool"] = (void *)pv_vkCreateDescriptorPool;
3692 custom_functions["vkCmdDispatch"] = (void *)pv_vkCmdDispatch;
John Zulaufa999d1b2018-11-29 13:38:40 -07003693 custom_functions["vkCmdDispatchIndirect"] = (void *)pv_vkCmdDispatchIndirect;
Mark Lobodzinskibf973a12018-03-01 08:50:21 -07003694 custom_functions["vkCmdDispatchBaseKHR"] = (void *)pv_vkCmdDispatchBaseKHR;
Jeff Bolz3e71f782018-08-29 23:15:45 -05003695 custom_functions["vkCmdSetExclusiveScissorNV"] = (void *)pv_vkCmdSetExclusiveScissorNV;
Jeff Bolz9af91c52018-09-01 21:53:57 -05003696 custom_functions["vkCmdSetViewportShadingRatePaletteNV"] = (void *)pv_vkCmdSetViewportShadingRatePaletteNV;
3697 custom_functions["vkCmdSetCoarseSampleOrderNV"] = (void *)pv_vkCmdSetCoarseSampleOrderNV;
Jeff Bolz45bf7d62018-09-18 15:39:58 -05003698 custom_functions["vkCmdDrawMeshTasksNV"] = (void *)pv_vkCmdDrawMeshTasksNV;
3699 custom_functions["vkCmdDrawMeshTasksIndirectNV"] = (void *)pv_vkCmdDrawMeshTasksIndirectNV;
3700 custom_functions["vkCmdDrawMeshTasksIndirectCountNV"] = (void *)pv_vkCmdDrawMeshTasksIndirectCountNV;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003701}
3702
3703} // namespace parameter_validation
3704
3705VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateInstanceExtensionProperties(const char *pLayerName, uint32_t *pCount,
3706 VkExtensionProperties *pProperties) {
3707 return parameter_validation::vkEnumerateInstanceExtensionProperties(pLayerName, pCount, pProperties);
3708}
3709
3710VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateInstanceLayerProperties(uint32_t *pCount,
3711 VkLayerProperties *pProperties) {
3712 return parameter_validation::vkEnumerateInstanceLayerProperties(pCount, pProperties);
3713}
3714
3715VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateDeviceLayerProperties(VkPhysicalDevice physicalDevice, uint32_t *pCount,
3716 VkLayerProperties *pProperties) {
3717 // the layer command handles VK_NULL_HANDLE just fine internally
3718 assert(physicalDevice == VK_NULL_HANDLE);
3719 return parameter_validation::vkEnumerateDeviceLayerProperties(VK_NULL_HANDLE, pCount, pProperties);
3720}
3721
3722VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateDeviceExtensionProperties(VkPhysicalDevice physicalDevice,
3723 const char *pLayerName, uint32_t *pCount,
3724 VkExtensionProperties *pProperties) {
3725 // the layer command handles VK_NULL_HANDLE just fine internally
3726 assert(physicalDevice == VK_NULL_HANDLE);
3727 return parameter_validation::vkEnumerateDeviceExtensionProperties(VK_NULL_HANDLE, pLayerName, pCount, pProperties);
3728}
3729
3730VK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetDeviceProcAddr(VkDevice dev, const char *funcName) {
3731 return parameter_validation::vkGetDeviceProcAddr(dev, funcName);
3732}
3733
3734VK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetInstanceProcAddr(VkInstance instance, const char *funcName) {
3735 return parameter_validation::vkGetInstanceProcAddr(instance, funcName);
3736}
3737
3738VK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vk_layerGetPhysicalDeviceProcAddr(VkInstance instance,
3739 const char *funcName) {
3740 return parameter_validation::vkGetPhysicalDeviceProcAddr(instance, funcName);
3741}
3742
Lenny Komow2d0cbbe2018-05-24 13:38:05 -06003743VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL VKAPI_CALL
3744vkNegotiateLoaderLayerInterfaceVersion(VkNegotiateLayerInterface *pVersionStruct) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003745 assert(pVersionStruct != NULL);
3746 assert(pVersionStruct->sType == LAYER_NEGOTIATE_INTERFACE_STRUCT);
3747
3748 // Fill in the function pointers if our version is at least capable of having the structure contain them.
3749 if (pVersionStruct->loaderLayerInterfaceVersion >= 2) {
3750 pVersionStruct->pfnGetInstanceProcAddr = vkGetInstanceProcAddr;
3751 pVersionStruct->pfnGetDeviceProcAddr = vkGetDeviceProcAddr;
3752 pVersionStruct->pfnGetPhysicalDeviceProcAddr = vk_layerGetPhysicalDeviceProcAddr;
3753 }
3754
3755 if (pVersionStruct->loaderLayerInterfaceVersion < CURRENT_LOADER_LAYER_INTERFACE_VERSION) {
3756 parameter_validation::loader_layer_if_version = pVersionStruct->loaderLayerInterfaceVersion;
3757 } else if (pVersionStruct->loaderLayerInterfaceVersion > CURRENT_LOADER_LAYER_INTERFACE_VERSION) {
3758 pVersionStruct->loaderLayerInterfaceVersion = CURRENT_LOADER_LAYER_INTERFACE_VERSION;
3759 }
3760
3761 return VK_SUCCESS;
3762}