blob: 436b3405422476a082e656ae8c93e27b0a5feec2 [file] [log] [blame]
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001/* Copyright (c) 2015-2017 The Khronos Group Inc.
2 * Copyright (c) 2015-2017 Valve Corporation
3 * Copyright (c) 2015-2017 LunarG, Inc.
4 * Copyright (C) 2015-2017 Google Inc.
5 *
6 * Licensed under the Apache License, Version 2.0 (the "License");
7 * you may not use this file except in compliance with the License.
8 * You may obtain a copy of the License at
9 *
10 * http://www.apache.org/licenses/LICENSE-2.0
11 *
12 * Unless required by applicable law or agreed to in writing, software
13 * distributed under the License is distributed on an "AS IS" BASIS,
14 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15 * See the License for the specific language governing permissions and
16 * limitations under the License.
17 *
18 * Author: Mark Lobodzinski <mark@LunarG.com>
19 */
20
21#define NOMINMAX
John Zulauf0fe5bfe2018-05-23 09:36:00 -060022#define VALIDATION_ERROR_MAP_IMPL
Mark Lobodzinskid4950072017-08-01 13:02:20 -060023
24#include <limits.h>
25#include <math.h>
26#include <stdio.h>
27#include <stdlib.h>
28#include <string.h>
Mark Lobodzinskid4950072017-08-01 13:02:20 -060029
30#include <iostream>
31#include <string>
32#include <sstream>
33#include <unordered_map>
34#include <unordered_set>
35#include <vector>
36#include <mutex>
37
38#include "vk_loader_platform.h"
39#include "vulkan/vk_layer.h"
40#include "vk_layer_config.h"
41#include "vk_dispatch_table_helper.h"
John Zulaufde972ac2017-10-26 12:07:05 -060042#include "vk_typemap_helper.h"
Mark Lobodzinskid4950072017-08-01 13:02:20 -060043
Mark Lobodzinskid4950072017-08-01 13:02:20 -060044#include "vk_layer_data.h"
45#include "vk_layer_logging.h"
46#include "vk_layer_extension_utils.h"
47#include "vk_layer_utils.h"
Lenny Komow4c0da772018-07-03 10:17:21 -060048#include "vk_layer_dispatch_table.h"
Mark Lobodzinskid4950072017-08-01 13:02:20 -060049
50#include "parameter_name.h"
51#include "parameter_validation.h"
52
Mark Lobodzinskibfb7ab92017-10-27 13:22:23 -060053#if defined __ANDROID__
54#include <android/log.h>
Mark Lobodzinski88529492018-04-01 10:38:15 -060055#define LOGCONSOLE(...) ((void)__android_log_print(ANDROID_LOG_INFO, "PARAMETER_VALIDATION", __VA_ARGS__))
Mark Lobodzinskibfb7ab92017-10-27 13:22:23 -060056#else
57#define LOGCONSOLE(...) \
58 { \
59 printf(__VA_ARGS__); \
60 printf("\n"); \
61 }
62#endif
63
Mark Lobodzinskid4950072017-08-01 13:02:20 -060064namespace parameter_validation {
65
Mark Lobodzinski78a12a92017-08-08 14:16:51 -060066extern std::unordered_map<std::string, void *> custom_functions;
67
Mark Lobodzinskid4950072017-08-01 13:02:20 -060068extern bool parameter_validation_vkCreateInstance(VkInstance instance, const VkInstanceCreateInfo *pCreateInfo,
69 const VkAllocationCallbacks *pAllocator, VkInstance *pInstance);
70extern bool parameter_validation_vkDestroyInstance(VkInstance instance, const VkAllocationCallbacks *pAllocator);
71extern bool parameter_validation_vkCreateDevice(VkPhysicalDevice physicalDevice, const VkDeviceCreateInfo *pCreateInfo,
72 const VkAllocationCallbacks *pAllocator, VkDevice *pDevice);
73extern bool parameter_validation_vkDestroyDevice(VkDevice device, const VkAllocationCallbacks *pAllocator);
74extern bool parameter_validation_vkCreateQueryPool(VkDevice device, const VkQueryPoolCreateInfo *pCreateInfo,
75 const VkAllocationCallbacks *pAllocator, VkQueryPool *pQueryPool);
76extern bool parameter_validation_vkCreateDebugReportCallbackEXT(VkInstance instance,
77 const VkDebugReportCallbackCreateInfoEXT *pCreateInfo,
78 const VkAllocationCallbacks *pAllocator,
79 VkDebugReportCallbackEXT *pMsgCallback);
80extern bool parameter_validation_vkDestroyDebugReportCallbackEXT(VkInstance instance, VkDebugReportCallbackEXT msgCallback,
81 const VkAllocationCallbacks *pAllocator);
Mark Young6ba8abe2017-11-09 10:37:04 -070082extern bool parameter_validation_vkCreateDebugUtilsMessengerEXT(VkInstance instance,
83 const VkDebugUtilsMessengerCreateInfoEXT *pCreateInfo,
84 const VkAllocationCallbacks *pAllocator,
85 VkDebugUtilsMessengerEXT *pMessenger);
86extern bool parameter_validation_vkDestroyDebugUtilsMessengerEXT(VkInstance instance, VkDebugUtilsMessengerEXT messenger,
87 const VkAllocationCallbacks *pAllocator);
Mark Lobodzinskid4950072017-08-01 13:02:20 -060088extern bool parameter_validation_vkCreateCommandPool(VkDevice device, const VkCommandPoolCreateInfo *pCreateInfo,
89 const VkAllocationCallbacks *pAllocator, VkCommandPool *pCommandPool);
Petr Krause91f7a12017-12-14 20:57:36 +010090extern bool parameter_validation_vkCreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo,
91 const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass);
92extern bool parameter_validation_vkDestroyRenderPass(VkDevice device, VkRenderPass renderPass,
93 const VkAllocationCallbacks *pAllocator);
Mark Lobodzinskid4950072017-08-01 13:02:20 -060094
95// TODO : This can be much smarter, using separate locks for separate global data
96std::mutex global_lock;
97
98static uint32_t loader_layer_if_version = CURRENT_LOADER_LAYER_INTERFACE_VERSION;
99std::unordered_map<void *, layer_data *> layer_data_map;
100std::unordered_map<void *, instance_layer_data *> instance_layer_data_map;
101
102void InitializeManualParameterValidationFunctionPointers(void);
103
104static void init_parameter_validation(instance_layer_data *instance_data, const VkAllocationCallbacks *pAllocator) {
Mark Young6ba8abe2017-11-09 10:37:04 -0700105 layer_debug_report_actions(instance_data->report_data, instance_data->logging_callback, pAllocator,
106 "lunarg_parameter_validation");
107 layer_debug_messenger_actions(instance_data->report_data, instance_data->logging_messenger, pAllocator,
108 "lunarg_parameter_validation");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600109}
110
Mark Young6ba8abe2017-11-09 10:37:04 -0700111static const VkExtensionProperties instance_extensions[] = {{VK_EXT_DEBUG_REPORT_EXTENSION_NAME, VK_EXT_DEBUG_REPORT_SPEC_VERSION},
112 {VK_EXT_DEBUG_UTILS_EXTENSION_NAME, VK_EXT_DEBUG_UTILS_SPEC_VERSION}};
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600113
114static const VkLayerProperties global_layer = {
Dave Houltonb3bbec72018-01-17 10:13:33 -0700115 "VK_LAYER_LUNARG_parameter_validation",
116 VK_LAYER_API_VERSION,
117 1,
118 "LunarG Validation Layer",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600119};
120
121static const int MaxParamCheckerStringLength = 256;
122
John Zulauf71968502017-10-26 13:51:15 -0600123template <typename T>
124static inline bool in_inclusive_range(const T &value, const T &min, const T &max) {
125 // Using only < for generality and || for early abort
126 return !((value < min) || (max < value));
127}
128
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600129static bool validate_string(debug_report_data *report_data, const char *apiName, const ParameterName &stringName,
Mark Lobodzinskiebee3552018-05-29 09:55:54 -0600130 const std::string &vuid, const char *validateString) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600131 bool skip = false;
132
133 VkStringErrorFlags result = vk_string_validate(MaxParamCheckerStringLength, validateString);
134
135 if (result == VK_STRING_ERROR_NONE) {
136 return skip;
137 } else if (result & VK_STRING_ERROR_LENGTH) {
Mark Lobodzinskiebee3552018-05-29 09:55:54 -0600138 skip = log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, vuid,
139 "%s: string %s exceeds max length %d", apiName, stringName.get_name().c_str(), MaxParamCheckerStringLength);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600140 } else if (result & VK_STRING_ERROR_BAD_DATA) {
Mark Lobodzinskiebee3552018-05-29 09:55:54 -0600141 skip = log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, vuid,
142 "%s: string %s contains invalid characters or is badly formed", apiName, stringName.get_name().c_str());
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600143 }
144 return skip;
145}
146
147static bool ValidateDeviceQueueFamily(layer_data *device_data, uint32_t queue_family, const char *cmd_name,
Dave Houlton13b65502018-05-23 13:35:24 -0600148 const char *parameter_name, const std::string &error_code, bool optional = false) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600149 bool skip = false;
150
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600151 if (!optional && queue_family == VK_QUEUE_FAMILY_IGNORED) {
152 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -0600153 HandleToUint64(device_data->device), error_code,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600154 "%s: %s is VK_QUEUE_FAMILY_IGNORED, but it is required to provide a valid queue family index value.",
155 cmd_name, parameter_name);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600156 } else if (device_data->queueFamilyIndexMap.find(queue_family) == device_data->queueFamilyIndexMap.end()) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600157 skip |=
158 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -0600159 HandleToUint64(device_data->device), error_code,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600160 "%s: %s (= %" PRIu32
161 ") is not one of the queue families given via VkDeviceQueueCreateInfo structures when the device was created.",
162 cmd_name, parameter_name, queue_family);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600163 }
164
165 return skip;
166}
167
168static bool ValidateQueueFamilies(layer_data *device_data, uint32_t queue_family_count, const uint32_t *queue_families,
Dave Houlton13b65502018-05-23 13:35:24 -0600169 const char *cmd_name, const char *array_parameter_name, const std::string &unique_error_code,
170 const std::string &valid_error_code, bool optional = false) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600171 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600172 if (queue_families) {
173 std::unordered_set<uint32_t> set;
174 for (uint32_t i = 0; i < queue_family_count; ++i) {
175 std::string parameter_name = std::string(array_parameter_name) + "[" + std::to_string(i) + "]";
176
177 if (set.count(queue_families[i])) {
178 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -0600179 HandleToUint64(device_data->device), "VUID-VkDeviceCreateInfo-queueFamilyIndex-00372",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600180 "%s: %s (=%" PRIu32 ") is not unique within %s array.", cmd_name, parameter_name.c_str(),
181 queue_families[i], array_parameter_name);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600182 } else {
183 set.insert(queue_families[i]);
184 skip |= ValidateDeviceQueueFamily(device_data, queue_families[i], cmd_name, parameter_name.c_str(),
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600185 valid_error_code, optional);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600186 }
187 }
188 }
189 return skip;
190}
191
John Zulauf620755c2018-04-16 11:00:43 -0600192static bool validate_api_version(const instance_layer_data *instance_data, uint32_t api_version, uint32_t effective_api_version) {
193 bool skip = false;
194 uint32_t api_version_nopatch = VK_MAKE_VERSION(VK_VERSION_MAJOR(api_version), VK_VERSION_MINOR(api_version), 0);
195 if (api_version_nopatch != effective_api_version) {
196 if (api_version_nopatch < VK_API_VERSION_1_0) {
197 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_INSTANCE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -0600198 HandleToUint64(instance_data->instance), kVUIDUndefined,
John Zulauf620755c2018-04-16 11:00:43 -0600199 "Invalid CreateInstance->pCreateInfo->pApplicationInfo.apiVersion number (0x%08x). "
200 "Using VK_API_VERSION_%" PRIu32 "_%" PRIu32 ".",
201 api_version, VK_VERSION_MAJOR(effective_api_version), VK_VERSION_MINOR(effective_api_version));
202 } else {
203 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_INSTANCE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -0600204 HandleToUint64(instance_data->instance), kVUIDUndefined,
John Zulauf620755c2018-04-16 11:00:43 -0600205 "Unrecognized CreateInstance->pCreateInfo->pApplicationInfo.apiVersion number (0x%08x). "
206 "Assuming VK_API_VERSION_%" PRIu32 "_%" PRIu32 ".",
207 api_version, VK_VERSION_MAJOR(effective_api_version), VK_VERSION_MINOR(effective_api_version));
208 }
209 }
210 return skip;
211}
212
213template <typename ExtensionState>
Dave Houlton13b65502018-05-23 13:35:24 -0600214static bool validate_extension_reqs(const instance_layer_data *instance_data, const ExtensionState &extensions,
215 const std::string &vuid, const char *extension_type, const char *extension_name) {
John Zulauf620755c2018-04-16 11:00:43 -0600216 bool skip = false;
217 if (!extension_name) {
218 return skip; // Robust to invalid char *
219 }
220 auto info = ExtensionState::get_info(extension_name);
221
222 if (!info.state) {
223 return skip; // Unknown extensions cannot be checked so report OK
224 }
225
Pat Brown3eddb062018-09-05 14:07:37 -0400226 // Check against the required list in the info
John Zulauf620755c2018-04-16 11:00:43 -0600227 std::vector<const char *> missing;
228 for (const auto &req : info.requires) {
229 if (!(extensions.*(req.enabled))) {
230 missing.push_back(req.name);
231 }
232 }
233
234 // Report any missing requirements
235 if (missing.size()) {
236 std::string missing_joined_list = string_join(", ", missing);
237 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_INSTANCE_EXT,
Pat Brown3eddb062018-09-05 14:07:37 -0400238 HandleToUint64(instance_data->instance), vuid, "Missing extension%s required by the %s extension %s: %s.",
239 ((missing.size() > 1) ? "s" : ""), extension_type, extension_name, missing_joined_list.c_str());
John Zulauf620755c2018-04-16 11:00:43 -0600240 }
241 return skip;
242}
243
244bool validate_instance_extensions(const instance_layer_data *instance_data, const VkInstanceCreateInfo *pCreateInfo) {
245 bool skip = false;
246 for (uint32_t i = 0; i < pCreateInfo->enabledExtensionCount; i++) {
Dave Houlton413a6782018-05-22 13:01:54 -0600247 skip |=
248 validate_extension_reqs(instance_data, instance_data->extensions, "VUID-vkCreateInstance-ppEnabledExtensionNames-01388",
249 "instance", pCreateInfo->ppEnabledExtensionNames[i]);
John Zulauf620755c2018-04-16 11:00:43 -0600250 }
251
252 return skip;
253}
254
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600255VKAPI_ATTR VkResult VKAPI_CALL vkCreateInstance(const VkInstanceCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600256 VkInstance *pInstance) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600257 VkResult result = VK_ERROR_VALIDATION_FAILED_EXT;
258
259 VkLayerInstanceCreateInfo *chain_info = get_chain_info(pCreateInfo, VK_LAYER_LINK_INFO);
260 assert(chain_info != nullptr);
261 assert(chain_info->u.pLayerInfo != nullptr);
262
263 PFN_vkGetInstanceProcAddr fpGetInstanceProcAddr = chain_info->u.pLayerInfo->pfnNextGetInstanceProcAddr;
264 PFN_vkCreateInstance fpCreateInstance = (PFN_vkCreateInstance)fpGetInstanceProcAddr(NULL, "vkCreateInstance");
265 if (fpCreateInstance == NULL) {
266 return VK_ERROR_INITIALIZATION_FAILED;
267 }
268
269 // Advance the link info for the next element on the chain
270 chain_info->u.pLayerInfo = chain_info->u.pLayerInfo->pNext;
271
272 result = fpCreateInstance(pCreateInfo, pAllocator, pInstance);
273
274 if (result == VK_SUCCESS) {
275 InitializeManualParameterValidationFunctionPointers();
276 auto my_instance_data = GetLayerDataPtr(get_dispatch_key(*pInstance), instance_layer_data_map);
277 assert(my_instance_data != nullptr);
278
279 layer_init_instance_dispatch_table(*pInstance, &my_instance_data->dispatch_table, fpGetInstanceProcAddr);
280 my_instance_data->instance = *pInstance;
281 my_instance_data->report_data =
Mark Young6ba8abe2017-11-09 10:37:04 -0700282 debug_utils_create_instance(&my_instance_data->dispatch_table, *pInstance, pCreateInfo->enabledExtensionCount,
283 pCreateInfo->ppEnabledExtensionNames);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600284
285 // Look for one or more debug report create info structures
286 // and setup a callback(s) for each one found.
Mark Young6ba8abe2017-11-09 10:37:04 -0700287 if (!layer_copy_tmp_debug_messengers(pCreateInfo->pNext, &my_instance_data->num_tmp_debug_messengers,
288 &my_instance_data->tmp_messenger_create_infos,
289 &my_instance_data->tmp_debug_messengers)) {
290 if (my_instance_data->num_tmp_debug_messengers > 0) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600291 // Setup the temporary callback(s) here to catch early issues:
Mark Young6ba8abe2017-11-09 10:37:04 -0700292 if (layer_enable_tmp_debug_messengers(my_instance_data->report_data, my_instance_data->num_tmp_debug_messengers,
293 my_instance_data->tmp_messenger_create_infos,
294 my_instance_data->tmp_debug_messengers)) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600295 // Failure of setting up one or more of the callback.
296 // Therefore, clean up and don't use those callbacks:
Mark Young6ba8abe2017-11-09 10:37:04 -0700297 layer_free_tmp_debug_messengers(my_instance_data->tmp_messenger_create_infos,
298 my_instance_data->tmp_debug_messengers);
299 my_instance_data->num_tmp_debug_messengers = 0;
300 }
301 }
302 }
303 if (!layer_copy_tmp_report_callbacks(pCreateInfo->pNext, &my_instance_data->num_tmp_report_callbacks,
304 &my_instance_data->tmp_report_create_infos, &my_instance_data->tmp_report_callbacks)) {
305 if (my_instance_data->num_tmp_report_callbacks > 0) {
306 // Setup the temporary callback(s) here to catch early issues:
307 if (layer_enable_tmp_report_callbacks(my_instance_data->report_data, my_instance_data->num_tmp_report_callbacks,
308 my_instance_data->tmp_report_create_infos,
309 my_instance_data->tmp_report_callbacks)) {
310 // Failure of setting up one or more of the callback.
311 // Therefore, clean up and don't use those callbacks:
312 layer_free_tmp_report_callbacks(my_instance_data->tmp_report_create_infos,
313 my_instance_data->tmp_report_callbacks);
314 my_instance_data->num_tmp_report_callbacks = 0;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600315 }
316 }
317 }
318
319 init_parameter_validation(my_instance_data, pAllocator);
John Zulaufe6db8a32018-03-30 14:51:59 -0600320 // Note: From the spec--
321 // Providing a NULL VkInstanceCreateInfo::pApplicationInfo or providing an apiVersion of 0 is equivalent to providing
322 // an apiVersion of VK_MAKE_VERSION(1, 0, 0). (a.k.a. VK_API_VERSION_1_0)
323 uint32_t api_version = (pCreateInfo->pApplicationInfo && pCreateInfo->pApplicationInfo->apiVersion)
324 ? pCreateInfo->pApplicationInfo->apiVersion
325 : VK_API_VERSION_1_0;
Mark Lobodzinskibfb7ab92017-10-27 13:22:23 -0600326
John Zulauf1909e6a2018-09-05 11:43:11 -0600327 my_instance_data->api_version = my_instance_data->extensions.InitFromInstanceCreateInfo(api_version, pCreateInfo);
Mark Lobodzinskibfb7ab92017-10-27 13:22:23 -0600328
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600329 // Ordinarily we'd check these before calling down the chain, but none of the layer support is in place until now, if we
330 // survive we can report the issue now.
John Zulauf1909e6a2018-09-05 11:43:11 -0600331 validate_api_version(my_instance_data, api_version, my_instance_data->api_version);
John Zulauf620755c2018-04-16 11:00:43 -0600332 validate_instance_extensions(my_instance_data, pCreateInfo);
333
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600334 parameter_validation_vkCreateInstance(*pInstance, pCreateInfo, pAllocator, pInstance);
335
336 if (pCreateInfo->pApplicationInfo) {
337 if (pCreateInfo->pApplicationInfo->pApplicationName) {
Mark Lobodzinskiebee3552018-05-29 09:55:54 -0600338 validate_string(
339 my_instance_data->report_data, "vkCreateInstance", "pCreateInfo->VkApplicationInfo->pApplicationName",
340 "VUID-VkApplicationInfo-pApplicationName-parameter", pCreateInfo->pApplicationInfo->pApplicationName);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600341 }
342
343 if (pCreateInfo->pApplicationInfo->pEngineName) {
344 validate_string(my_instance_data->report_data, "vkCreateInstance", "pCreateInfo->VkApplicationInfo->pEngineName",
Mark Lobodzinskiebee3552018-05-29 09:55:54 -0600345 "VUID-VkApplicationInfo-pEngineName-parameter", pCreateInfo->pApplicationInfo->pEngineName);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600346 }
347 }
348
349 // Disable the tmp callbacks:
Mark Young6ba8abe2017-11-09 10:37:04 -0700350 if (my_instance_data->num_tmp_debug_messengers > 0) {
351 layer_disable_tmp_debug_messengers(my_instance_data->report_data, my_instance_data->num_tmp_debug_messengers,
352 my_instance_data->tmp_debug_messengers);
353 }
354 if (my_instance_data->num_tmp_report_callbacks > 0) {
355 layer_disable_tmp_report_callbacks(my_instance_data->report_data, my_instance_data->num_tmp_report_callbacks,
356 my_instance_data->tmp_report_callbacks);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600357 }
358 }
359
360 return result;
361}
362
363VKAPI_ATTR void VKAPI_CALL vkDestroyInstance(VkInstance instance, const VkAllocationCallbacks *pAllocator) {
364 // Grab the key before the instance is destroyed.
365 dispatch_key key = get_dispatch_key(instance);
366 bool skip = false;
367 auto instance_data = GetLayerDataPtr(key, instance_layer_data_map);
368
369 // Enable the temporary callback(s) here to catch vkDestroyInstance issues:
370 bool callback_setup = false;
Mark Young6ba8abe2017-11-09 10:37:04 -0700371 if (instance_data->num_tmp_debug_messengers > 0) {
372 if (!layer_enable_tmp_debug_messengers(instance_data->report_data, instance_data->num_tmp_debug_messengers,
373 instance_data->tmp_messenger_create_infos, instance_data->tmp_debug_messengers)) {
374 callback_setup = true;
375 }
376 }
377 if (instance_data->num_tmp_report_callbacks > 0) {
378 if (!layer_enable_tmp_report_callbacks(instance_data->report_data, instance_data->num_tmp_report_callbacks,
379 instance_data->tmp_report_create_infos, instance_data->tmp_report_callbacks)) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600380 callback_setup = true;
381 }
382 }
383
384 skip |= parameter_validation_vkDestroyInstance(instance, pAllocator);
385
386 // Disable and cleanup the temporary callback(s):
387 if (callback_setup) {
Mark Young6ba8abe2017-11-09 10:37:04 -0700388 layer_disable_tmp_debug_messengers(instance_data->report_data, instance_data->num_tmp_debug_messengers,
389 instance_data->tmp_debug_messengers);
390 layer_disable_tmp_report_callbacks(instance_data->report_data, instance_data->num_tmp_report_callbacks,
391 instance_data->tmp_report_callbacks);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600392 }
Mark Young6ba8abe2017-11-09 10:37:04 -0700393 if (instance_data->num_tmp_debug_messengers > 0) {
394 layer_free_tmp_debug_messengers(instance_data->tmp_messenger_create_infos, instance_data->tmp_debug_messengers);
395 instance_data->num_tmp_debug_messengers = 0;
396 }
397 if (instance_data->num_tmp_report_callbacks > 0) {
398 layer_free_tmp_report_callbacks(instance_data->tmp_report_create_infos, instance_data->tmp_report_callbacks);
399 instance_data->num_tmp_report_callbacks = 0;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600400 }
401
402 if (!skip) {
403 instance_data->dispatch_table.DestroyInstance(instance, pAllocator);
404
405 // Clean up logging callback, if any
Mark Young6ba8abe2017-11-09 10:37:04 -0700406 while (instance_data->logging_messenger.size() > 0) {
407 VkDebugUtilsMessengerEXT messenger = instance_data->logging_messenger.back();
408 layer_destroy_messenger_callback(instance_data->report_data, messenger, pAllocator);
409 instance_data->logging_messenger.pop_back();
410 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600411 while (instance_data->logging_callback.size() > 0) {
412 VkDebugReportCallbackEXT callback = instance_data->logging_callback.back();
Mark Young6ba8abe2017-11-09 10:37:04 -0700413 layer_destroy_report_callback(instance_data->report_data, callback, pAllocator);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600414 instance_data->logging_callback.pop_back();
415 }
416
Mark Young6ba8abe2017-11-09 10:37:04 -0700417 layer_debug_utils_destroy_instance(instance_data->report_data);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600418 }
419
420 FreeLayerDataPtr(key, instance_layer_data_map);
421}
422
423VKAPI_ATTR VkResult VKAPI_CALL vkCreateDebugReportCallbackEXT(VkInstance instance,
424 const VkDebugReportCallbackCreateInfoEXT *pCreateInfo,
425 const VkAllocationCallbacks *pAllocator,
426 VkDebugReportCallbackEXT *pMsgCallback) {
427 bool skip = parameter_validation_vkCreateDebugReportCallbackEXT(instance, pCreateInfo, pAllocator, pMsgCallback);
428 if (skip) return VK_ERROR_VALIDATION_FAILED_EXT;
429
430 auto instance_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map);
431 VkResult result = instance_data->dispatch_table.CreateDebugReportCallbackEXT(instance, pCreateInfo, pAllocator, pMsgCallback);
432 if (result == VK_SUCCESS) {
Mark Young6ba8abe2017-11-09 10:37:04 -0700433 result = layer_create_report_callback(instance_data->report_data, false, pCreateInfo, pAllocator, pMsgCallback);
434 // If something happened during this call, clean up the message callback that was created earlier in the lower levels
435 if (VK_SUCCESS != result) {
436 instance_data->dispatch_table.DestroyDebugReportCallbackEXT(instance, *pMsgCallback, pAllocator);
437 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600438 }
439 return result;
440}
441
442VKAPI_ATTR void VKAPI_CALL vkDestroyDebugReportCallbackEXT(VkInstance instance, VkDebugReportCallbackEXT msgCallback,
443 const VkAllocationCallbacks *pAllocator) {
444 bool skip = parameter_validation_vkDestroyDebugReportCallbackEXT(instance, msgCallback, pAllocator);
445 if (!skip) {
446 auto instance_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map);
447 instance_data->dispatch_table.DestroyDebugReportCallbackEXT(instance, msgCallback, pAllocator);
Mark Young6ba8abe2017-11-09 10:37:04 -0700448 layer_destroy_report_callback(instance_data->report_data, msgCallback, pAllocator);
449 }
450}
451
452VKAPI_ATTR VkResult VKAPI_CALL vkCreateDebugUtilsMessengerEXT(VkInstance instance,
453 const VkDebugUtilsMessengerCreateInfoEXT *pCreateInfo,
454 const VkAllocationCallbacks *pAllocator,
455 VkDebugUtilsMessengerEXT *pMessenger) {
456 bool skip = parameter_validation_vkCreateDebugUtilsMessengerEXT(instance, pCreateInfo, pAllocator, pMessenger);
457 if (skip) return VK_ERROR_VALIDATION_FAILED_EXT;
458
459 auto instance_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map);
460 VkResult result = instance_data->dispatch_table.CreateDebugUtilsMessengerEXT(instance, pCreateInfo, pAllocator, pMessenger);
461 if (VK_SUCCESS == result) {
462 result = layer_create_messenger_callback(instance_data->report_data, false, pCreateInfo, pAllocator, pMessenger);
463 // If something happened during this call, clean up the message callback that was created earlier in the lower levels
464 if (VK_SUCCESS != result) {
465 instance_data->dispatch_table.DestroyDebugUtilsMessengerEXT(instance, *pMessenger, pAllocator);
466 }
467 }
468 return result;
469}
470
471VKAPI_ATTR void VKAPI_CALL vkDestroyDebugUtilsMessengerEXT(VkInstance instance, VkDebugUtilsMessengerEXT messenger,
472 const VkAllocationCallbacks *pAllocator) {
473 bool skip = parameter_validation_vkDestroyDebugUtilsMessengerEXT(instance, messenger, pAllocator);
474 if (!skip) {
475 auto instance_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map);
476 instance_data->dispatch_table.DestroyDebugUtilsMessengerEXT(instance, messenger, pAllocator);
477 layer_destroy_messenger_callback(instance_data->report_data, messenger, pAllocator);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600478 }
479}
480
John Zulauf620755c2018-04-16 11:00:43 -0600481template <typename ExtensionState>
482static bool extension_state_by_name(const ExtensionState &extensions, const char *extension_name) {
483 if (!extension_name) return false; // null strings specify nothing
484 auto info = ExtensionState::get_info(extension_name);
485 bool state = info.state ? extensions.*(info.state) : false; // unknown extensions can't be enabled in extension struct
486 return state;
487}
488
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600489static bool ValidateDeviceCreateInfo(instance_layer_data *instance_data, VkPhysicalDevice physicalDevice,
John Zulauf620755c2018-04-16 11:00:43 -0600490 const VkDeviceCreateInfo *pCreateInfo, const DeviceExtensions &extensions) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600491 bool skip = false;
John Zulauf620755c2018-04-16 11:00:43 -0600492 bool maint1 = false;
493 bool negative_viewport = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600494
495 if ((pCreateInfo->enabledLayerCount > 0) && (pCreateInfo->ppEnabledLayerNames != NULL)) {
496 for (size_t i = 0; i < pCreateInfo->enabledLayerCount; i++) {
497 skip |= validate_string(instance_data->report_data, "vkCreateDevice", "pCreateInfo->ppEnabledLayerNames",
Mark Lobodzinskiebee3552018-05-29 09:55:54 -0600498 "VUID-VkDeviceCreateInfo-ppEnabledLayerNames-parameter", pCreateInfo->ppEnabledLayerNames[i]);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600499 }
500 }
501
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600502 if ((pCreateInfo->enabledExtensionCount > 0) && (pCreateInfo->ppEnabledExtensionNames != NULL)) {
John Zulauf620755c2018-04-16 11:00:43 -0600503 maint1 = extension_state_by_name(extensions, VK_KHR_MAINTENANCE1_EXTENSION_NAME);
504 negative_viewport = extension_state_by_name(extensions, VK_AMD_NEGATIVE_VIEWPORT_HEIGHT_EXTENSION_NAME);
505
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600506 for (size_t i = 0; i < pCreateInfo->enabledExtensionCount; i++) {
507 skip |= validate_string(instance_data->report_data, "vkCreateDevice", "pCreateInfo->ppEnabledExtensionNames",
Mark Lobodzinskiebee3552018-05-29 09:55:54 -0600508 "VUID-VkDeviceCreateInfo-ppEnabledExtensionNames-parameter",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600509 pCreateInfo->ppEnabledExtensionNames[i]);
Dave Houlton413a6782018-05-22 13:01:54 -0600510 skip |= validate_extension_reqs(instance_data, extensions, "VUID-vkCreateDevice-ppEnabledExtensionNames-01387",
511 "device", pCreateInfo->ppEnabledExtensionNames[i]);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600512 }
513 }
514
515 if (maint1 && negative_viewport) {
516 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600517 "VUID-VkDeviceCreateInfo-ppEnabledExtensionNames-00374",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600518 "VkDeviceCreateInfo->ppEnabledExtensionNames must not simultaneously include VK_KHR_maintenance1 and "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600519 "VK_AMD_negative_viewport_height.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600520 }
521
522 if (pCreateInfo->pNext != NULL && pCreateInfo->pEnabledFeatures) {
523 // Check for get_physical_device_properties2 struct
John Zulaufde972ac2017-10-26 12:07:05 -0600524 const auto *features2 = lvl_find_in_chain<VkPhysicalDeviceFeatures2KHR>(pCreateInfo->pNext);
525 if (features2) {
526 // Cannot include VkPhysicalDeviceFeatures2KHR and have non-null pEnabledFeatures
527 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600528 kVUID_PVError_InvalidUsage,
John Zulaufde972ac2017-10-26 12:07:05 -0600529 "VkDeviceCreateInfo->pNext includes a VkPhysicalDeviceFeatures2KHR struct when "
530 "pCreateInfo->pEnabledFeatures is non-NULL.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600531 }
532 }
533
534 // Validate pCreateInfo->pQueueCreateInfos
535 if (pCreateInfo->pQueueCreateInfos) {
536 std::unordered_set<uint32_t> set;
537
538 for (uint32_t i = 0; i < pCreateInfo->queueCreateInfoCount; ++i) {
539 const uint32_t requested_queue_family = pCreateInfo->pQueueCreateInfos[i].queueFamilyIndex;
540 if (requested_queue_family == VK_QUEUE_FAMILY_IGNORED) {
541 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT,
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600542 VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, HandleToUint64(physicalDevice),
Dave Houlton413a6782018-05-22 13:01:54 -0600543 "VUID-VkDeviceQueueCreateInfo-queueFamilyIndex-00381",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600544 "vkCreateDevice: pCreateInfo->pQueueCreateInfos[%" PRIu32
Dave Houltona9df0ce2018-02-07 10:51:23 -0700545 "].queueFamilyIndex is VK_QUEUE_FAMILY_IGNORED, but it is required to provide a valid queue family "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600546 "index value.",
547 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600548 } else if (set.count(requested_queue_family)) {
549 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT,
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600550 VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, HandleToUint64(physicalDevice),
Dave Houlton413a6782018-05-22 13:01:54 -0600551 "VUID-VkDeviceCreateInfo-queueFamilyIndex-00372",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600552 "vkCreateDevice: pCreateInfo->pQueueCreateInfos[%" PRIu32 "].queueFamilyIndex (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600553 ") is not unique within pCreateInfo->pQueueCreateInfos array.",
554 i, requested_queue_family);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600555 } else {
556 set.insert(requested_queue_family);
557 }
558
559 if (pCreateInfo->pQueueCreateInfos[i].pQueuePriorities != nullptr) {
560 for (uint32_t j = 0; j < pCreateInfo->pQueueCreateInfos[i].queueCount; ++j) {
561 const float queue_priority = pCreateInfo->pQueueCreateInfos[i].pQueuePriorities[j];
562 if (!(queue_priority >= 0.f) || !(queue_priority <= 1.f)) {
563 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT,
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600564 VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, HandleToUint64(physicalDevice),
Dave Houlton413a6782018-05-22 13:01:54 -0600565 "VUID-VkDeviceQueueCreateInfo-pQueuePriorities-00383",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600566 "vkCreateDevice: pCreateInfo->pQueueCreateInfos[%" PRIu32 "].pQueuePriorities[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600567 "] (=%f) is not between 0 and 1 (inclusive).",
568 i, j, queue_priority);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600569 }
570 }
571 }
572 }
573 }
574
575 return skip;
576}
577
578VKAPI_ATTR VkResult VKAPI_CALL vkCreateDevice(VkPhysicalDevice physicalDevice, const VkDeviceCreateInfo *pCreateInfo,
579 const VkAllocationCallbacks *pAllocator, VkDevice *pDevice) {
580 // NOTE: Don't validate physicalDevice or any dispatchable object as the first parameter. We couldn't get here if it was wrong!
581
582 VkResult result = VK_ERROR_VALIDATION_FAILED_EXT;
583 bool skip = false;
584 auto my_instance_data = GetLayerDataPtr(get_dispatch_key(physicalDevice), instance_layer_data_map);
585 assert(my_instance_data != nullptr);
John Zulauf620755c2018-04-16 11:00:43 -0600586
587 // Query and save physical device limits for this device, needed for validation
588 VkPhysicalDeviceProperties device_properties = {};
589 my_instance_data->dispatch_table.GetPhysicalDeviceProperties(physicalDevice, &device_properties);
590
John Zulauf1909e6a2018-09-05 11:43:11 -0600591 // Setup the validation tables based on the application API version from the instance and the capabilities of the device driver.
592 uint32_t effective_api_version = std::min(device_properties.apiVersion, my_instance_data->api_version);
John Zulauf620755c2018-04-16 11:00:43 -0600593 DeviceExtensions extensions;
John Zulauf1909e6a2018-09-05 11:43:11 -0600594 uint32_t api_version = extensions.InitFromDeviceCreateInfo(&my_instance_data->extensions, effective_api_version, pCreateInfo);
John Zulauf620755c2018-04-16 11:00:43 -0600595
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600596 std::unique_lock<std::mutex> lock(global_lock);
597
598 skip |= parameter_validation_vkCreateDevice(physicalDevice, pCreateInfo, pAllocator, pDevice);
599
John Zulauf620755c2018-04-16 11:00:43 -0600600 if (pCreateInfo != NULL) skip |= ValidateDeviceCreateInfo(my_instance_data, physicalDevice, pCreateInfo, extensions);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600601
602 if (!skip) {
603 VkLayerDeviceCreateInfo *chain_info = get_chain_info(pCreateInfo, VK_LAYER_LINK_INFO);
604 assert(chain_info != nullptr);
605 assert(chain_info->u.pLayerInfo != nullptr);
606
607 PFN_vkGetInstanceProcAddr fpGetInstanceProcAddr = chain_info->u.pLayerInfo->pfnNextGetInstanceProcAddr;
608 PFN_vkGetDeviceProcAddr fpGetDeviceProcAddr = chain_info->u.pLayerInfo->pfnNextGetDeviceProcAddr;
609 PFN_vkCreateDevice fpCreateDevice = (PFN_vkCreateDevice)fpGetInstanceProcAddr(my_instance_data->instance, "vkCreateDevice");
610 if (fpCreateDevice == NULL) {
611 return VK_ERROR_INITIALIZATION_FAILED;
612 }
613
614 // Advance the link info for the next element on the chain
615 chain_info->u.pLayerInfo = chain_info->u.pLayerInfo->pNext;
616
617 lock.unlock();
618
619 result = fpCreateDevice(physicalDevice, pCreateInfo, pAllocator, pDevice);
620
621 lock.lock();
622
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600623 if (result == VK_SUCCESS) {
624 layer_data *my_device_data = GetLayerDataPtr(get_dispatch_key(*pDevice), layer_data_map);
625 assert(my_device_data != nullptr);
626
Mark Young6ba8abe2017-11-09 10:37:04 -0700627 my_device_data->report_data = layer_debug_utils_create_device(my_instance_data->report_data, *pDevice);
John Zulauf9b777302018-10-08 11:15:51 -0600628 layer_init_device_dispatch_table(*pDevice, &my_device_data->dispatch_table, fpGetDeviceProcAddr);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600629
John Zulauf620755c2018-04-16 11:00:43 -0600630 my_device_data->api_version = api_version;
631 my_device_data->extensions = extensions;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600632
633 // Store createdevice data
634 if ((pCreateInfo != nullptr) && (pCreateInfo->pQueueCreateInfos != nullptr)) {
635 for (uint32_t i = 0; i < pCreateInfo->queueCreateInfoCount; ++i) {
636 my_device_data->queueFamilyIndexMap.insert(std::make_pair(pCreateInfo->pQueueCreateInfos[i].queueFamilyIndex,
637 pCreateInfo->pQueueCreateInfos[i].queueCount));
638 }
639 }
640
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600641 memcpy(&my_device_data->device_limits, &device_properties.limits, sizeof(VkPhysicalDeviceLimits));
642 my_device_data->physical_device = physicalDevice;
643 my_device_data->device = *pDevice;
644
Jeff Bolz5d2b7432018-09-06 10:32:36 -0500645 if (my_device_data->extensions.vk_nv_shading_rate_image) {
646 // Get the needed shading rate image limits
647 auto shading_rate_image_props = lvl_init_struct<VkPhysicalDeviceShadingRateImagePropertiesNV>();
648 auto prop2 = lvl_init_struct<VkPhysicalDeviceProperties2KHR>(&shading_rate_image_props);
649 my_instance_data->dispatch_table.GetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
650 my_device_data->phys_dev_ext_props.shading_rate_image_props = shading_rate_image_props;
651 }
652
Jeff Bolz45bf7d62018-09-18 15:39:58 -0500653 if (my_device_data->extensions.vk_nv_mesh_shader) {
654 // Get the needed mesh shader limits
655 auto mesh_shader_props = lvl_init_struct<VkPhysicalDeviceMeshShaderPropertiesNV>();
656 auto prop2 = lvl_init_struct<VkPhysicalDeviceProperties2KHR>(&mesh_shader_props);
657 my_instance_data->dispatch_table.GetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
658 my_device_data->phys_dev_ext_props.mesh_shader_props = mesh_shader_props;
659 }
660
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600661 // Save app-enabled features in this device's layer_data structure
John Zulauf1bde5bb2017-10-18 18:21:23 -0600662 // The enabled features can come from either pEnabledFeatures, or from the pNext chain
663 const VkPhysicalDeviceFeatures *enabled_features_found = pCreateInfo->pEnabledFeatures;
664 if ((nullptr == enabled_features_found) && my_device_data->extensions.vk_khr_get_physical_device_properties_2) {
John Zulaufde972ac2017-10-26 12:07:05 -0600665 const auto *features2 = lvl_find_in_chain<VkPhysicalDeviceFeatures2KHR>(pCreateInfo->pNext);
666 if (features2) {
667 enabled_features_found = &(features2->features);
John Zulauf1bde5bb2017-10-18 18:21:23 -0600668 }
669 }
670 if (enabled_features_found) {
Dave Houltonb3bbec72018-01-17 10:13:33 -0700671 my_device_data->physical_device_features = *enabled_features_found;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600672 } else {
673 memset(&my_device_data->physical_device_features, 0, sizeof(VkPhysicalDeviceFeatures));
674 }
675 }
676 }
677
678 return result;
679}
680
681VKAPI_ATTR void VKAPI_CALL vkDestroyDevice(VkDevice device, const VkAllocationCallbacks *pAllocator) {
682 dispatch_key key = get_dispatch_key(device);
683 bool skip = false;
684 layer_data *device_data = GetLayerDataPtr(key, layer_data_map);
685 {
686 std::unique_lock<std::mutex> lock(global_lock);
687 skip |= parameter_validation_vkDestroyDevice(device, pAllocator);
688 }
689
690 if (!skip) {
Mark Young6ba8abe2017-11-09 10:37:04 -0700691 layer_debug_utils_destroy_device(device);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600692 device_data->dispatch_table.DestroyDevice(device, pAllocator);
693 }
694 FreeLayerDataPtr(key, layer_data_map);
695}
696
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600697bool pv_vkGetDeviceQueue(VkDevice device, uint32_t queueFamilyIndex, uint32_t queueIndex, VkQueue *pQueue) {
698 bool skip = false;
699 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
700
Dave Houlton413a6782018-05-22 13:01:54 -0600701 skip |= ValidateDeviceQueueFamily(device_data, queueFamilyIndex, "vkGetDeviceQueue", "queueFamilyIndex",
702 "VUID-vkGetDeviceQueue-queueFamilyIndex-00384");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600703 const auto &queue_data = device_data->queueFamilyIndexMap.find(queueFamilyIndex);
704 if (queue_data != device_data->queueFamilyIndexMap.end() && queue_data->second <= queueIndex) {
705 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -0600706 HandleToUint64(device), "VUID-vkGetDeviceQueue-queueIndex-00385",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600707 "vkGetDeviceQueue: queueIndex (=%" PRIu32
Dave Houltona9df0ce2018-02-07 10:51:23 -0700708 ") is not less than the number of queues requested from queueFamilyIndex (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600709 ") when the device was created (i.e. is not less than %" PRIu32 ").",
710 queueIndex, queueFamilyIndex, queue_data->second);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600711 }
712 return skip;
713}
714
715VKAPI_ATTR VkResult VKAPI_CALL vkCreateCommandPool(VkDevice device, const VkCommandPoolCreateInfo *pCreateInfo,
716 const VkAllocationCallbacks *pAllocator, VkCommandPool *pCommandPool) {
717 layer_data *local_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
718 bool skip = false;
719 VkResult result = VK_ERROR_VALIDATION_FAILED_EXT;
720 std::unique_lock<std::mutex> lock(global_lock);
721
722 skip |= ValidateDeviceQueueFamily(local_data, pCreateInfo->queueFamilyIndex, "vkCreateCommandPool",
Dave Houlton341c0052018-06-21 15:00:45 -0600723 "pCreateInfo->queueFamilyIndex", "VUID-vkCreateCommandPool-queueFamilyIndex-01937");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600724
725 skip |= parameter_validation_vkCreateCommandPool(device, pCreateInfo, pAllocator, pCommandPool);
726
727 lock.unlock();
728 if (!skip) {
729 result = local_data->dispatch_table.CreateCommandPool(device, pCreateInfo, pAllocator, pCommandPool);
730 }
731 return result;
732}
733
734VKAPI_ATTR VkResult VKAPI_CALL vkCreateQueryPool(VkDevice device, const VkQueryPoolCreateInfo *pCreateInfo,
735 const VkAllocationCallbacks *pAllocator, VkQueryPool *pQueryPool) {
736 VkResult result = VK_ERROR_VALIDATION_FAILED_EXT;
737 bool skip = false;
738 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
739
740 skip |= parameter_validation_vkCreateQueryPool(device, pCreateInfo, pAllocator, pQueryPool);
741
742 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
743 if (pCreateInfo != nullptr) {
744 // If queryType is VK_QUERY_TYPE_PIPELINE_STATISTICS, pipelineStatistics must be a valid combination of
745 // VkQueryPipelineStatisticFlagBits values
746 if ((pCreateInfo->queryType == VK_QUERY_TYPE_PIPELINE_STATISTICS) && (pCreateInfo->pipelineStatistics != 0) &&
747 ((pCreateInfo->pipelineStatistics & (~AllVkQueryPipelineStatisticFlagBits)) != 0)) {
748 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600749 "VUID-VkQueryPoolCreateInfo-queryType-00792",
Dave Houltona9df0ce2018-02-07 10:51:23 -0700750 "vkCreateQueryPool(): if pCreateInfo->queryType is VK_QUERY_TYPE_PIPELINE_STATISTICS, "
751 "pCreateInfo->pipelineStatistics must be a valid combination of VkQueryPipelineStatisticFlagBits "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600752 "values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600753 }
754 }
755 if (!skip) {
756 result = device_data->dispatch_table.CreateQueryPool(device, pCreateInfo, pAllocator, pQueryPool);
757 }
758 return result;
759}
760
Petr Krause91f7a12017-12-14 20:57:36 +0100761VKAPI_ATTR VkResult VKAPI_CALL vkCreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo,
762 const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass) {
763 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
764 bool skip = false;
765 VkResult result = VK_ERROR_VALIDATION_FAILED_EXT;
766
767 {
768 std::unique_lock<std::mutex> lock(global_lock);
769 skip |= parameter_validation_vkCreateRenderPass(device, pCreateInfo, pAllocator, pRenderPass);
770
Dave Houltonb3bbec72018-01-17 10:13:33 -0700771 typedef bool (*PFN_manual_vkCreateRenderPass)(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo,
772 const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass);
Petr Krause91f7a12017-12-14 20:57:36 +0100773 PFN_manual_vkCreateRenderPass custom_func = (PFN_manual_vkCreateRenderPass)custom_functions["vkCreateRenderPass"];
774 if (custom_func != nullptr) {
775 skip |= custom_func(device, pCreateInfo, pAllocator, pRenderPass);
776 }
777 }
778
779 if (!skip) {
780 result = device_data->dispatch_table.CreateRenderPass(device, pCreateInfo, pAllocator, pRenderPass);
781
782 // track the state necessary for checking vkCreateGraphicsPipeline (subpass usage of depth and color attachments)
783 if (result == VK_SUCCESS) {
784 std::unique_lock<std::mutex> lock(global_lock);
785 const auto renderPass = *pRenderPass;
786 auto &renderpass_state = device_data->renderpasses_states[renderPass];
787
788 for (uint32_t subpass = 0; subpass < pCreateInfo->subpassCount; ++subpass) {
789 bool uses_color = false;
790 for (uint32_t i = 0; i < pCreateInfo->pSubpasses[subpass].colorAttachmentCount && !uses_color; ++i)
791 if (pCreateInfo->pSubpasses[subpass].pColorAttachments[i].attachment != VK_ATTACHMENT_UNUSED) uses_color = true;
792
793 bool uses_depthstencil = false;
794 if (pCreateInfo->pSubpasses[subpass].pDepthStencilAttachment)
795 if (pCreateInfo->pSubpasses[subpass].pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED)
796 uses_depthstencil = true;
797
798 if (uses_color) renderpass_state.subpasses_using_color_attachment.insert(subpass);
799 if (uses_depthstencil) renderpass_state.subpasses_using_depthstencil_attachment.insert(subpass);
800 }
801 }
802 }
803 return result;
804}
805
806VKAPI_ATTR void VKAPI_CALL vkDestroyRenderPass(VkDevice device, VkRenderPass renderPass, const VkAllocationCallbacks *pAllocator) {
807 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
808 bool skip = false;
809
810 {
811 std::unique_lock<std::mutex> lock(global_lock);
812 skip |= parameter_validation_vkDestroyRenderPass(device, renderPass, pAllocator);
813
Dave Houltonb3bbec72018-01-17 10:13:33 -0700814 typedef bool (*PFN_manual_vkDestroyRenderPass)(VkDevice device, VkRenderPass renderPass,
815 const VkAllocationCallbacks *pAllocator);
Petr Krause91f7a12017-12-14 20:57:36 +0100816 PFN_manual_vkDestroyRenderPass custom_func = (PFN_manual_vkDestroyRenderPass)custom_functions["vkDestroyRenderPass"];
817 if (custom_func != nullptr) {
818 skip |= custom_func(device, renderPass, pAllocator);
819 }
820 }
821
822 if (!skip) {
823 device_data->dispatch_table.DestroyRenderPass(device, renderPass, pAllocator);
824
825 // track the state necessary for checking vkCreateGraphicsPipeline (subpass usage of depth and color attachments)
826 {
827 std::unique_lock<std::mutex> lock(global_lock);
828 device_data->renderpasses_states.erase(renderPass);
829 }
830 }
831}
832
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600833bool pv_vkCreateBuffer(VkDevice device, const VkBufferCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
834 VkBuffer *pBuffer) {
835 bool skip = false;
836 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
837 debug_report_data *report_data = device_data->report_data;
838
Mark Lobodzinski88529492018-04-01 10:38:15 -0600839 const LogMiscParams log_misc{report_data, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, VK_NULL_HANDLE, "vkCreateBuffer"};
Petr Krause5c37652018-01-05 04:05:12 +0100840
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600841 if (pCreateInfo != nullptr) {
Dave Houlton413a6782018-05-22 13:01:54 -0600842 skip |= ValidateGreaterThanZero(pCreateInfo->size, "pCreateInfo->size", "VUID-VkBufferCreateInfo-size-00912", log_misc);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600843
844 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
845 if (pCreateInfo->sharingMode == VK_SHARING_MODE_CONCURRENT) {
846 // If sharingMode is VK_SHARING_MODE_CONCURRENT, queueFamilyIndexCount must be greater than 1
847 if (pCreateInfo->queueFamilyIndexCount <= 1) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600848 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600849 "VUID-VkBufferCreateInfo-sharingMode-00914",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600850 "vkCreateBuffer: if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600851 "pCreateInfo->queueFamilyIndexCount must be greater than 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600852 }
853
854 // If sharingMode is VK_SHARING_MODE_CONCURRENT, pQueueFamilyIndices must be a pointer to an array of
855 // queueFamilyIndexCount uint32_t values
856 if (pCreateInfo->pQueueFamilyIndices == nullptr) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600857 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600858 "VUID-VkBufferCreateInfo-sharingMode-00913",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600859 "vkCreateBuffer: if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
860 "pCreateInfo->pQueueFamilyIndices must be a pointer to an array of "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600861 "pCreateInfo->queueFamilyIndexCount uint32_t values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600862 } else {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600863 skip |= ValidateQueueFamilies(device_data, pCreateInfo->queueFamilyIndexCount, pCreateInfo->pQueueFamilyIndices,
Dave Houlton413a6782018-05-22 13:01:54 -0600864 "vkCreateBuffer", "pCreateInfo->pQueueFamilyIndices", kVUID_PVError_InvalidUsage,
865 kVUID_PVError_InvalidUsage, false);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600866 }
867 }
868
869 // If flags contains VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT or VK_BUFFER_CREATE_SPARSE_ALIASED_BIT, it must also contain
870 // VK_BUFFER_CREATE_SPARSE_BINDING_BIT
871 if (((pCreateInfo->flags & (VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT | VK_BUFFER_CREATE_SPARSE_ALIASED_BIT)) != 0) &&
872 ((pCreateInfo->flags & VK_BUFFER_CREATE_SPARSE_BINDING_BIT) != VK_BUFFER_CREATE_SPARSE_BINDING_BIT)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600873 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600874 "VUID-VkBufferCreateInfo-flags-00918",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600875 "vkCreateBuffer: if pCreateInfo->flags contains VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT or "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600876 "VK_BUFFER_CREATE_SPARSE_ALIASED_BIT, it must also contain VK_BUFFER_CREATE_SPARSE_BINDING_BIT.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600877 }
878 }
879
880 return skip;
881}
882
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600883bool pv_vkCreateImage(VkDevice device, const VkImageCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
884 VkImage *pImage) {
885 bool skip = false;
886 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
887 debug_report_data *report_data = device_data->report_data;
888
Mark Lobodzinski88529492018-04-01 10:38:15 -0600889 const LogMiscParams log_misc{report_data, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, VK_NULL_HANDLE, "vkCreateImage"};
Petr Krause5c37652018-01-05 04:05:12 +0100890
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600891 if (pCreateInfo != nullptr) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600892 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
893 if (pCreateInfo->sharingMode == VK_SHARING_MODE_CONCURRENT) {
894 // If sharingMode is VK_SHARING_MODE_CONCURRENT, queueFamilyIndexCount must be greater than 1
895 if (pCreateInfo->queueFamilyIndexCount <= 1) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600896 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600897 "VUID-VkImageCreateInfo-sharingMode-00942",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600898 "vkCreateImage(): if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600899 "pCreateInfo->queueFamilyIndexCount must be greater than 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600900 }
901
902 // If sharingMode is VK_SHARING_MODE_CONCURRENT, pQueueFamilyIndices must be a pointer to an array of
903 // queueFamilyIndexCount uint32_t values
904 if (pCreateInfo->pQueueFamilyIndices == nullptr) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600905 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600906 "VUID-VkImageCreateInfo-sharingMode-00941",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600907 "vkCreateImage(): if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
908 "pCreateInfo->pQueueFamilyIndices must be a pointer to an array of "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600909 "pCreateInfo->queueFamilyIndexCount uint32_t values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600910 } else {
Dave Houlton413a6782018-05-22 13:01:54 -0600911 skip |= ValidateQueueFamilies(device_data, pCreateInfo->queueFamilyIndexCount, pCreateInfo->pQueueFamilyIndices,
912 "vkCreateImage", "pCreateInfo->pQueueFamilyIndices", kVUID_PVError_InvalidUsage,
913 kVUID_PVError_InvalidUsage, false);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600914 }
915 }
916
Dave Houlton413a6782018-05-22 13:01:54 -0600917 skip |= ValidateGreaterThanZero(pCreateInfo->extent.width, "pCreateInfo->extent.width",
918 "VUID-VkImageCreateInfo-extent-00944", log_misc);
919 skip |= ValidateGreaterThanZero(pCreateInfo->extent.height, "pCreateInfo->extent.height",
920 "VUID-VkImageCreateInfo-extent-00945", log_misc);
921 skip |= ValidateGreaterThanZero(pCreateInfo->extent.depth, "pCreateInfo->extent.depth",
922 "VUID-VkImageCreateInfo-extent-00946", log_misc);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600923
Dave Houlton413a6782018-05-22 13:01:54 -0600924 skip |= ValidateGreaterThanZero(pCreateInfo->mipLevels, "pCreateInfo->mipLevels", "VUID-VkImageCreateInfo-mipLevels-00947",
925 log_misc);
926 skip |= ValidateGreaterThanZero(pCreateInfo->arrayLayers, "pCreateInfo->arrayLayers",
927 "VUID-VkImageCreateInfo-arrayLayers-00948", log_misc);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600928
Dave Houlton130c0212018-01-29 13:39:56 -0700929 // InitialLayout must be PREINITIALIZED or UNDEFINED
Dave Houltone19e20d2018-02-02 16:32:41 -0700930 if ((pCreateInfo->initialLayout != VK_IMAGE_LAYOUT_UNDEFINED) &&
931 (pCreateInfo->initialLayout != VK_IMAGE_LAYOUT_PREINITIALIZED)) {
932 skip |= log_msg(
Dave Houlton413a6782018-05-22 13:01:54 -0600933 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
934 "VUID-VkImageCreateInfo-initialLayout-00993",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600935 "vkCreateImage(): initialLayout is %s, must be VK_IMAGE_LAYOUT_UNDEFINED or VK_IMAGE_LAYOUT_PREINITIALIZED.",
936 string_VkImageLayout(pCreateInfo->initialLayout));
Dave Houlton130c0212018-01-29 13:39:56 -0700937 }
938
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600939 // If imageType is VK_IMAGE_TYPE_1D, both extent.height and extent.depth must be 1
Petr Kraus3ac9e812018-03-13 12:31:08 +0100940 if ((pCreateInfo->imageType == VK_IMAGE_TYPE_1D) &&
941 ((pCreateInfo->extent.height != 1) || (pCreateInfo->extent.depth != 1))) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600942 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600943 "VUID-VkImageCreateInfo-imageType-00956",
Dave Houltona9df0ce2018-02-07 10:51:23 -0700944 "vkCreateImage(): if pCreateInfo->imageType is VK_IMAGE_TYPE_1D, both pCreateInfo->extent.height and "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600945 "pCreateInfo->extent.depth must be 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600946 }
947
948 if (pCreateInfo->imageType == VK_IMAGE_TYPE_2D) {
Petr Kraus3f433212018-03-13 12:31:27 +0100949 if (pCreateInfo->flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) {
950 if (pCreateInfo->extent.width != pCreateInfo->extent.height) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600951 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -0600952 VK_NULL_HANDLE, "VUID-VkImageCreateInfo-imageType-00954",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600953 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT, but "
954 "pCreateInfo->extent.width (=%" PRIu32 ") and pCreateInfo->extent.height (=%" PRIu32
955 ") are not equal.",
956 pCreateInfo->extent.width, pCreateInfo->extent.height);
Petr Kraus3f433212018-03-13 12:31:27 +0100957 }
958
959 if (pCreateInfo->arrayLayers < 6) {
960 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -0600961 VK_NULL_HANDLE, "VUID-VkImageCreateInfo-imageType-00954",
Petr Kraus3f433212018-03-13 12:31:27 +0100962 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT, but "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600963 "pCreateInfo->arrayLayers (=%" PRIu32 ") is not greater than or equal to 6.",
964 pCreateInfo->arrayLayers);
Petr Kraus3f433212018-03-13 12:31:27 +0100965 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600966 }
967
968 if (pCreateInfo->extent.depth != 1) {
Mark Lobodzinski88529492018-04-01 10:38:15 -0600969 skip |=
970 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600971 "VUID-VkImageCreateInfo-imageType-00957",
Mark Lobodzinski88529492018-04-01 10:38:15 -0600972 "vkCreateImage(): if pCreateInfo->imageType is VK_IMAGE_TYPE_2D, pCreateInfo->extent.depth must be 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600973 }
974 }
975
Dave Houlton130c0212018-01-29 13:39:56 -0700976 // 3D image may have only 1 layer
977 if ((pCreateInfo->imageType == VK_IMAGE_TYPE_3D) && (pCreateInfo->arrayLayers != 1)) {
Mark Lobodzinski88529492018-04-01 10:38:15 -0600978 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600979 "VUID-VkImageCreateInfo-imageType-00961",
Mark Lobodzinski88529492018-04-01 10:38:15 -0600980 "vkCreateImage(): if pCreateInfo->imageType is VK_IMAGE_TYPE_3D, pCreateInfo->arrayLayers must be 1.");
Dave Houlton130c0212018-01-29 13:39:56 -0700981 }
982
983 // If multi-sample, validate type, usage, tiling and mip levels.
984 if ((pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT) &&
985 ((pCreateInfo->imageType != VK_IMAGE_TYPE_2D) || (pCreateInfo->flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) ||
Shannon McPhersona886c2a2018-10-12 14:38:20 -0600986 (pCreateInfo->mipLevels != 1) || (pCreateInfo->tiling != VK_IMAGE_TILING_OPTIMAL))) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600987 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Shannon McPhersona886c2a2018-10-12 14:38:20 -0600988 "VUID-VkImageCreateInfo-samples-02257",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600989 "vkCreateImage(): Multi-sample image with incompatible type, usage, tiling, or mips.");
Dave Houlton130c0212018-01-29 13:39:56 -0700990 }
991
992 if (0 != (pCreateInfo->usage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT)) {
993 VkImageUsageFlags legal_flags = (VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT | VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT |
994 VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT);
995 // At least one of the legal attachment bits must be set
996 if (0 == (pCreateInfo->usage & legal_flags)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600997 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600998 "VUID-VkImageCreateInfo-usage-00966",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600999 "vkCreateImage(): Transient attachment image without a compatible attachment flag set.");
Dave Houlton130c0212018-01-29 13:39:56 -07001000 }
1001 // No flags other than the legal attachment bits may be set
1002 legal_flags |= VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT;
1003 if (0 != (pCreateInfo->usage & ~legal_flags)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001004 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001005 "VUID-VkImageCreateInfo-usage-00963",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001006 "vkCreateImage(): Transient attachment image with incompatible usage flags set.");
Dave Houlton130c0212018-01-29 13:39:56 -07001007 }
1008 }
1009
Jeff Bolzef40fec2018-09-01 22:04:34 -05001010 // mipLevels must be less than or equal to the number of levels in the complete mipmap chain
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001011 uint32_t maxDim = std::max(std::max(pCreateInfo->extent.width, pCreateInfo->extent.height), pCreateInfo->extent.depth);
Jeff Bolzef40fec2018-09-01 22:04:34 -05001012 // Max mip levels is different for corner-sampled images vs normal images.
Dave Houlton142c4cb2018-10-17 15:04:41 -06001013 uint32_t maxMipLevels = (pCreateInfo->flags & VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV) ? (uint32_t)(ceil(log2(maxDim)))
1014 : (uint32_t)(floor(log2(maxDim)) + 1);
Jeff Bolzef40fec2018-09-01 22:04:34 -05001015 if (maxDim > 0 && pCreateInfo->mipLevels > maxMipLevels) {
Dave Houlton413a6782018-05-22 13:01:54 -06001016 skip |=
1017 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1018 "VUID-VkImageCreateInfo-mipLevels-00958",
1019 "vkCreateImage(): pCreateInfo->mipLevels must be less than or equal to "
1020 "floor(log2(max(pCreateInfo->extent.width, pCreateInfo->extent.height, pCreateInfo->extent.depth)))+1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001021 }
1022
Mark Lobodzinski69259c52018-09-18 15:14:58 -06001023 if ((pCreateInfo->flags & VK_IMAGE_CREATE_2D_ARRAY_COMPATIBLE_BIT) && (pCreateInfo->imageType != VK_IMAGE_TYPE_3D)) {
1024 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, VK_NULL_HANDLE,
1025 "VUID-VkImageCreateInfo-flags-00950",
1026 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_2D_ARRAY_COMPATIBLE_BIT but "
1027 "pCreateInfo->imageType is not VK_IMAGE_TYPE_3D.");
1028 }
1029
Petr Krausb6f97802018-03-13 12:31:39 +01001030 if ((pCreateInfo->flags & VK_IMAGE_CREATE_SPARSE_BINDING_BIT) && (!device_data->physical_device_features.sparseBinding)) {
1031 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, VK_NULL_HANDLE,
Dave Houlton413a6782018-05-22 13:01:54 -06001032 "VUID-VkImageCreateInfo-flags-00969",
Petr Krausb6f97802018-03-13 12:31:39 +01001033 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_SPARSE_BINDING_BIT, but the "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001034 "VkPhysicalDeviceFeatures::sparseBinding feature is disabled.");
Petr Krausb6f97802018-03-13 12:31:39 +01001035 }
1036
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001037 // If flags contains VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT or VK_IMAGE_CREATE_SPARSE_ALIASED_BIT, it must also contain
1038 // VK_IMAGE_CREATE_SPARSE_BINDING_BIT
1039 if (((pCreateInfo->flags & (VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT | VK_IMAGE_CREATE_SPARSE_ALIASED_BIT)) != 0) &&
1040 ((pCreateInfo->flags & VK_IMAGE_CREATE_SPARSE_BINDING_BIT) != VK_IMAGE_CREATE_SPARSE_BINDING_BIT)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001041 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001042 "VUID-VkImageCreateInfo-flags-00987",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001043 "vkCreateImage: if pCreateInfo->flags contains VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT or "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001044 "VK_IMAGE_CREATE_SPARSE_ALIASED_BIT, it must also contain VK_IMAGE_CREATE_SPARSE_BINDING_BIT.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001045 }
1046
1047 // Check for combinations of attributes that are incompatible with having VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT set
1048 if ((pCreateInfo->flags & VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT) != 0) {
1049 // Linear tiling is unsupported
1050 if (VK_IMAGE_TILING_LINEAR == pCreateInfo->tiling) {
Dave Houlton413a6782018-05-22 13:01:54 -06001051 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1052 kVUID_PVError_InvalidUsage,
1053 "vkCreateImage: if pCreateInfo->flags contains VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT then image "
1054 "tiling of VK_IMAGE_TILING_LINEAR is not supported");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001055 }
1056
1057 // Sparse 1D image isn't valid
1058 if (VK_IMAGE_TYPE_1D == pCreateInfo->imageType) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001059 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001060 "VUID-VkImageCreateInfo-imageType-00970",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001061 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 1D image.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001062 }
1063
1064 // Sparse 2D image when device doesn't support it
1065 if ((VK_FALSE == device_data->physical_device_features.sparseResidencyImage2D) &&
1066 (VK_IMAGE_TYPE_2D == pCreateInfo->imageType)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001067 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001068 "VUID-VkImageCreateInfo-imageType-00971",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001069 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 2D image if corresponding "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001070 "feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001071 }
1072
1073 // Sparse 3D image when device doesn't support it
1074 if ((VK_FALSE == device_data->physical_device_features.sparseResidencyImage3D) &&
1075 (VK_IMAGE_TYPE_3D == pCreateInfo->imageType)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001076 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001077 "VUID-VkImageCreateInfo-imageType-00972",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001078 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 3D image if corresponding "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001079 "feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001080 }
1081
1082 // Multi-sample 2D image when device doesn't support it
1083 if (VK_IMAGE_TYPE_2D == pCreateInfo->imageType) {
1084 if ((VK_FALSE == device_data->physical_device_features.sparseResidency2Samples) &&
1085 (VK_SAMPLE_COUNT_2_BIT == pCreateInfo->samples)) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07001086 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001087 "VUID-VkImageCreateInfo-imageType-00973",
Dave Houltona9df0ce2018-02-07 10:51:23 -07001088 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 2-sample image if "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001089 "corresponding feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001090 } else if ((VK_FALSE == device_data->physical_device_features.sparseResidency4Samples) &&
1091 (VK_SAMPLE_COUNT_4_BIT == pCreateInfo->samples)) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07001092 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001093 "VUID-VkImageCreateInfo-imageType-00974",
Dave Houltona9df0ce2018-02-07 10:51:23 -07001094 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 4-sample image if "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001095 "corresponding feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001096 } else if ((VK_FALSE == device_data->physical_device_features.sparseResidency8Samples) &&
1097 (VK_SAMPLE_COUNT_8_BIT == pCreateInfo->samples)) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07001098 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001099 "VUID-VkImageCreateInfo-imageType-00975",
Dave Houltona9df0ce2018-02-07 10:51:23 -07001100 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 8-sample image if "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001101 "corresponding feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001102 } else if ((VK_FALSE == device_data->physical_device_features.sparseResidency16Samples) &&
1103 (VK_SAMPLE_COUNT_16_BIT == pCreateInfo->samples)) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07001104 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001105 "VUID-VkImageCreateInfo-imageType-00976",
Dave Houltona9df0ce2018-02-07 10:51:23 -07001106 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 16-sample image if "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001107 "corresponding feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001108 }
1109 }
1110 }
Jeff Bolzef40fec2018-09-01 22:04:34 -05001111
Jeff Bolz9af91c52018-09-01 21:53:57 -05001112 if (pCreateInfo->usage & VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV) {
1113 if (pCreateInfo->imageType != VK_IMAGE_TYPE_2D) {
1114 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1115 "VUID-VkImageCreateInfo-imageType-02082",
1116 "vkCreateImage: if usage includes VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV, "
1117 "imageType must be VK_IMAGE_TYPE_2D.");
1118 }
1119 if (pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT) {
1120 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1121 "VUID-VkImageCreateInfo-samples-02083",
1122 "vkCreateImage: if usage includes VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV, "
1123 "samples must be VK_SAMPLE_COUNT_1_BIT.");
1124 }
1125 if (pCreateInfo->tiling != VK_IMAGE_TILING_OPTIMAL) {
1126 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1127 "VUID-VkImageCreateInfo-tiling-02084",
1128 "vkCreateImage: if usage includes VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV, "
1129 "tiling must be VK_IMAGE_TILING_OPTIMAL.");
1130 }
1131 }
Jeff Bolzef40fec2018-09-01 22:04:34 -05001132
1133 if (pCreateInfo->flags & VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06001134 if (pCreateInfo->imageType != VK_IMAGE_TYPE_2D && pCreateInfo->imageType != VK_IMAGE_TYPE_3D) {
Jeff Bolzef40fec2018-09-01 22:04:34 -05001135 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1136 "VUID-VkImageCreateInfo-flags-02050",
1137 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV, "
1138 "imageType must be VK_IMAGE_TYPE_2D or VK_IMAGE_TYPE_3D.");
1139 }
1140
Dave Houlton142c4cb2018-10-17 15:04:41 -06001141 if ((pCreateInfo->flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) || FormatIsDepthOrStencil(pCreateInfo->format)) {
Jeff Bolzef40fec2018-09-01 22:04:34 -05001142 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1143 "VUID-VkImageCreateInfo-flags-02051",
1144 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV, "
1145 "it must not also contain VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT and format must "
1146 "not be a depth/stencil format.");
1147 }
1148
Dave Houlton142c4cb2018-10-17 15:04:41 -06001149 if (pCreateInfo->imageType == VK_IMAGE_TYPE_2D && (pCreateInfo->extent.width == 1 || pCreateInfo->extent.height == 1)) {
Jeff Bolzef40fec2018-09-01 22:04:34 -05001150 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1151 "VUID-VkImageCreateInfo-flags-02052",
1152 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV and "
1153 "imageType is VK_IMAGE_TYPE_2D, extent.width and extent.height must be "
1154 "greater than 1.");
Jeff Bolzb8a8dd02018-09-18 02:39:24 -05001155 } else if (pCreateInfo->imageType == VK_IMAGE_TYPE_3D &&
Dave Houlton142c4cb2018-10-17 15:04:41 -06001156 (pCreateInfo->extent.width == 1 || pCreateInfo->extent.height == 1 || pCreateInfo->extent.depth == 1)) {
Jeff Bolzef40fec2018-09-01 22:04:34 -05001157 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1158 "VUID-VkImageCreateInfo-flags-02053",
1159 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV and "
1160 "imageType is VK_IMAGE_TYPE_3D, extent.width, extent.height, and extent.depth "
1161 "must be greater than 1.");
Jeff Bolzef40fec2018-09-01 22:04:34 -05001162 }
1163 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001164 }
Jeff Bolzef40fec2018-09-01 22:04:34 -05001165
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001166 return skip;
1167}
1168
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001169bool pv_vkCreateImageView(VkDevice device, const VkImageViewCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
1170 VkImageView *pView) {
1171 bool skip = false;
1172 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
1173 debug_report_data *report_data = device_data->report_data;
1174
1175 if (pCreateInfo != nullptr) {
Dave Houltonbd2e2622018-04-10 16:41:14 -06001176 // Validate chained VkImageViewUsageCreateInfo struct, if present
1177 if (nullptr != pCreateInfo->pNext) {
1178 auto chained_ivuci_struct = lvl_find_in_chain<VkImageViewUsageCreateInfoKHR>(pCreateInfo->pNext);
1179 if (chained_ivuci_struct) {
1180 if (0 == chained_ivuci_struct->usage) {
1181 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001182 "VUID-VkImageViewUsageCreateInfo-usage-requiredbitmask",
Dave Houlton0f3795b2018-04-13 15:04:35 -06001183 "vkCreateImageView: Chained VkImageViewUsageCreateInfo usage field must not be 0.");
Dave Houltonbd2e2622018-04-10 16:41:14 -06001184 } else if (chained_ivuci_struct->usage & ~AllVkImageUsageFlagBits) {
1185 std::stringstream ss;
1186 ss << "vkCreateImageView: Chained VkImageViewUsageCreateInfo usage field (0x" << std::hex
1187 << chained_ivuci_struct->usage << ") contains invalid flag bits.";
1188 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001189 "VUID-VkImageViewUsageCreateInfo-usage-parameter", "%s", ss.str().c_str());
Dave Houltonbd2e2622018-04-10 16:41:14 -06001190 }
1191 }
1192 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001193 }
1194 return skip;
1195}
1196
Petr Krausb3fcdb42018-01-09 22:09:09 +01001197bool pv_VkViewport(const layer_data *device_data, const VkViewport &viewport, const char *fn_name, const char *param_name,
1198 VkDebugReportObjectTypeEXT object_type, uint64_t object = 0) {
1199 bool skip = false;
1200 debug_report_data *report_data = device_data->report_data;
1201
1202 // Note: for numerical correctness
1203 // - float comparisons should expect NaN (comparison always false).
1204 // - VkPhysicalDeviceLimits::maxViewportDimensions is uint32_t, not float -> careful.
1205
1206 const auto f_lte_u32_exact = [](const float v1_f, const uint32_t v2_u32) {
John Zulaufac0876c2018-02-19 10:09:35 -07001207 if (std::isnan(v1_f)) return false;
Petr Krausb3fcdb42018-01-09 22:09:09 +01001208 if (v1_f <= 0.0f) return true;
1209
1210 float intpart;
1211 const float fract = modff(v1_f, &intpart);
1212
1213 assert(std::numeric_limits<float>::radix == 2);
1214 const float u32_max_plus1 = ldexpf(1.0f, 32); // hopefully exact
1215 if (intpart >= u32_max_plus1) return false;
1216
1217 uint32_t v1_u32 = static_cast<uint32_t>(intpart);
1218 if (v1_u32 < v2_u32)
1219 return true;
1220 else if (v1_u32 == v2_u32 && fract == 0.0f)
1221 return true;
1222 else
1223 return false;
1224 };
1225
1226 const auto f_lte_u32_direct = [](const float v1_f, const uint32_t v2_u32) {
1227 const float v2_f = static_cast<float>(v2_u32); // not accurate for > radix^digits; and undefined rounding mode
1228 return (v1_f <= v2_f);
1229 };
1230
1231 // width
1232 bool width_healthy = true;
1233 const auto max_w = device_data->device_limits.maxViewportDimensions[0];
1234
1235 if (!(viewport.width > 0.0f)) {
1236 width_healthy = false;
Dave Houlton413a6782018-05-22 13:01:54 -06001237 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-width-01770",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001238 "%s: %s.width (=%f) is not greater than 0.0.", fn_name, param_name, viewport.width);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001239 } else if (!(f_lte_u32_exact(viewport.width, max_w) || f_lte_u32_direct(viewport.width, max_w))) {
1240 width_healthy = false;
Dave Houlton413a6782018-05-22 13:01:54 -06001241 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-width-01771",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001242 "%s: %s.width (=%f) exceeds VkPhysicalDeviceLimits::maxViewportDimensions[0] (=%" PRIu32 ").", fn_name,
1243 param_name, viewport.width, max_w);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001244 } else if (!f_lte_u32_exact(viewport.width, max_w) && f_lte_u32_direct(viewport.width, max_w)) {
Dave Houlton413a6782018-05-22 13:01:54 -06001245 skip |= log_msg(report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, object_type, object, kVUID_PVError_NONE,
Petr Krausb3fcdb42018-01-09 22:09:09 +01001246 "%s: %s.width (=%f) technically exceeds VkPhysicalDeviceLimits::maxViewportDimensions[0] (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001247 "), but it is within the static_cast<float>(maxViewportDimensions[0]) limit.",
1248 fn_name, param_name, viewport.width, max_w);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001249 }
1250
1251 // height
1252 bool height_healthy = true;
Petr Krausaf9c1222018-03-10 02:39:47 +01001253 const bool negative_height_enabled = device_data->api_version >= VK_API_VERSION_1_1 ||
1254 device_data->extensions.vk_khr_maintenance1 ||
1255 device_data->extensions.vk_amd_negative_viewport_height;
Petr Krausb3fcdb42018-01-09 22:09:09 +01001256 const auto max_h = device_data->device_limits.maxViewportDimensions[1];
1257
1258 if (!negative_height_enabled && !(viewport.height > 0.0f)) {
1259 height_healthy = false;
Dave Houlton413a6782018-05-22 13:01:54 -06001260 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-height-01772",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001261 "%s: %s.height (=%f) is not greater 0.0.", fn_name, param_name, viewport.height);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001262 } else if (!(f_lte_u32_exact(fabsf(viewport.height), max_h) || f_lte_u32_direct(fabsf(viewport.height), max_h))) {
1263 height_healthy = false;
1264
Dave Houlton413a6782018-05-22 13:01:54 -06001265 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-height-01773",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001266 "%s: Absolute value of %s.height (=%f) exceeds VkPhysicalDeviceLimits::maxViewportDimensions[1] (=%" PRIu32
1267 ").",
1268 fn_name, param_name, viewport.height, max_h);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001269 } else if (!f_lte_u32_exact(fabsf(viewport.height), max_h) && f_lte_u32_direct(fabsf(viewport.height), max_h)) {
1270 height_healthy = false;
1271
1272 skip |= log_msg(
Dave Houlton413a6782018-05-22 13:01:54 -06001273 report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, object_type, object, kVUID_PVError_NONE,
Petr Krausb3fcdb42018-01-09 22:09:09 +01001274 "%s: Absolute value of %s.height (=%f) technically exceeds VkPhysicalDeviceLimits::maxViewportDimensions[1] (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001275 "), but it is within the static_cast<float>(maxViewportDimensions[1]) limit.",
1276 fn_name, param_name, viewport.height, max_h);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001277 }
1278
1279 // x
1280 bool x_healthy = true;
1281 if (!(viewport.x >= device_data->device_limits.viewportBoundsRange[0])) {
1282 x_healthy = false;
Dave Houlton413a6782018-05-22 13:01:54 -06001283 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-x-01774",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001284 "%s: %s.x (=%f) is less than VkPhysicalDeviceLimits::viewportBoundsRange[0] (=%f).", fn_name, param_name,
1285 viewport.x, device_data->device_limits.viewportBoundsRange[0]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001286 }
1287
1288 // x + width
1289 if (x_healthy && width_healthy) {
1290 const float right_bound = viewport.x + viewport.width;
1291 if (!(right_bound <= device_data->device_limits.viewportBoundsRange[1])) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06001292 skip |=
Dave Houlton413a6782018-05-22 13:01:54 -06001293 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-x-01232",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001294 "%s: %s.x + %s.width (=%f + %f = %f) is greater than VkPhysicalDeviceLimits::viewportBoundsRange[1] (=%f).",
1295 fn_name, param_name, param_name, viewport.x, viewport.width, right_bound,
1296 device_data->device_limits.viewportBoundsRange[1]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001297 }
1298 }
1299
1300 // y
1301 bool y_healthy = true;
1302 if (!(viewport.y >= device_data->device_limits.viewportBoundsRange[0])) {
1303 y_healthy = false;
Dave Houlton413a6782018-05-22 13:01:54 -06001304 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-y-01775",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001305 "%s: %s.y (=%f) is less than VkPhysicalDeviceLimits::viewportBoundsRange[0] (=%f).", fn_name, param_name,
1306 viewport.y, device_data->device_limits.viewportBoundsRange[0]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001307 } else if (negative_height_enabled && !(viewport.y <= device_data->device_limits.viewportBoundsRange[1])) {
1308 y_healthy = false;
Dave Houlton413a6782018-05-22 13:01:54 -06001309 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-y-01776",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001310 "%s: %s.y (=%f) exceeds VkPhysicalDeviceLimits::viewportBoundsRange[1] (=%f).", fn_name, param_name,
1311 viewport.y, device_data->device_limits.viewportBoundsRange[1]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001312 }
1313
1314 // y + height
1315 if (y_healthy && height_healthy) {
1316 const float boundary = viewport.y + viewport.height;
1317
1318 if (!(boundary <= device_data->device_limits.viewportBoundsRange[1])) {
Dave Houlton413a6782018-05-22 13:01:54 -06001319 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-y-01233",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001320 "%s: %s.y + %s.height (=%f + %f = %f) exceeds VkPhysicalDeviceLimits::viewportBoundsRange[1] (=%f).",
1321 fn_name, param_name, param_name, viewport.y, viewport.height, boundary,
1322 device_data->device_limits.viewportBoundsRange[1]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001323 } else if (negative_height_enabled && !(boundary >= device_data->device_limits.viewportBoundsRange[0])) {
1324 skip |= log_msg(
Dave Houlton413a6782018-05-22 13:01:54 -06001325 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-y-01777",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001326 "%s: %s.y + %s.height (=%f + %f = %f) is less than VkPhysicalDeviceLimits::viewportBoundsRange[0] (=%f).", fn_name,
1327 param_name, param_name, viewport.y, viewport.height, boundary, device_data->device_limits.viewportBoundsRange[0]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001328 }
1329 }
1330
1331 if (!device_data->extensions.vk_ext_depth_range_unrestricted) {
1332 // minDepth
1333 if (!(viewport.minDepth >= 0.0) || !(viewport.minDepth <= 1.0)) {
Dave Houlton413a6782018-05-22 13:01:54 -06001334 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-minDepth-01234",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001335
Petr Krausb3fcdb42018-01-09 22:09:09 +01001336 "%s: VK_EXT_depth_range_unrestricted extension is not enabled and %s.minDepth (=%f) is not within the "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001337 "[0.0, 1.0] range.",
1338 fn_name, param_name, viewport.minDepth);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001339 }
1340
1341 // maxDepth
1342 if (!(viewport.maxDepth >= 0.0) || !(viewport.maxDepth <= 1.0)) {
Dave Houlton413a6782018-05-22 13:01:54 -06001343 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-maxDepth-01235",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001344
Petr Krausb3fcdb42018-01-09 22:09:09 +01001345 "%s: VK_EXT_depth_range_unrestricted extension is not enabled and %s.maxDepth (=%f) is not within the "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001346 "[0.0, 1.0] range.",
1347 fn_name, param_name, viewport.maxDepth);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001348 }
1349 }
1350
1351 return skip;
1352}
1353
Dave Houlton142c4cb2018-10-17 15:04:41 -06001354struct SampleOrderInfo {
Jeff Bolz9af91c52018-09-01 21:53:57 -05001355 VkShadingRatePaletteEntryNV shadingRate;
1356 uint32_t width;
1357 uint32_t height;
1358};
1359
1360// All palette entries with more than one pixel per fragment
Dave Houlton142c4cb2018-10-17 15:04:41 -06001361static SampleOrderInfo sampleOrderInfos[] = {
1362 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_1X2_PIXELS_NV, 1, 2},
1363 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_2X1_PIXELS_NV, 2, 1},
1364 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_2X2_PIXELS_NV, 2, 2},
1365 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_4X2_PIXELS_NV, 4, 2},
1366 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_2X4_PIXELS_NV, 2, 4},
1367 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_4X4_PIXELS_NV, 4, 4},
Jeff Bolz9af91c52018-09-01 21:53:57 -05001368};
1369
Dave Houlton142c4cb2018-10-17 15:04:41 -06001370bool ValidateCoarseSampleOrderCustomNV(layer_data *device_data, const VkCoarseSampleOrderCustomNV *order) {
Jeff Bolz9af91c52018-09-01 21:53:57 -05001371 bool skip = false;
1372 debug_report_data *report_data = device_data->report_data;
1373
Jeff Bolz45bf7d62018-09-18 15:39:58 -05001374 SampleOrderInfo *sampleOrderInfo;
Jeff Bolz9af91c52018-09-01 21:53:57 -05001375 uint32_t infoIdx = 0;
Jeff Bolz45bf7d62018-09-18 15:39:58 -05001376 for (sampleOrderInfo = nullptr; infoIdx < ARRAY_SIZE(sampleOrderInfos); ++infoIdx) {
Jeff Bolz9af91c52018-09-01 21:53:57 -05001377 if (sampleOrderInfos[infoIdx].shadingRate == order->shadingRate) {
Jeff Bolzb8a8dd02018-09-18 02:39:24 -05001378 sampleOrderInfo = &sampleOrderInfos[infoIdx];
Jeff Bolz9af91c52018-09-01 21:53:57 -05001379 break;
1380 }
1381 }
1382
Jeff Bolzb8a8dd02018-09-18 02:39:24 -05001383 if (sampleOrderInfo == nullptr) {
Jeff Bolz9af91c52018-09-01 21:53:57 -05001384 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1385 "VUID-VkCoarseSampleOrderCustomNV-shadingRate-02073",
1386 "VkCoarseSampleOrderCustomNV shadingRate must be a shading rate "
1387 "that generates fragments with more than one pixel.");
1388 return skip;
1389 }
1390
Dave Houlton142c4cb2018-10-17 15:04:41 -06001391 if (order->sampleCount == 0 || (order->sampleCount & (order->sampleCount - 1)) ||
Jeff Bolz9af91c52018-09-01 21:53:57 -05001392 !(order->sampleCount & device_data->device_limits.framebufferNoAttachmentsSampleCounts)) {
1393 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1394 "VUID-VkCoarseSampleOrderCustomNV-sampleCount-02074",
Dave Houlton142c4cb2018-10-17 15:04:41 -06001395 "VkCoarseSampleOrderCustomNV sampleCount (=%" PRIu32
1396 ") must "
Jeff Bolz9af91c52018-09-01 21:53:57 -05001397 "correspond to a sample count enumerated in VkSampleCountFlags whose corresponding bit "
1398 "is set in framebufferNoAttachmentsSampleCounts.",
1399 order->sampleCount);
1400 }
1401
Jeff Bolz9af91c52018-09-01 21:53:57 -05001402 if (order->sampleLocationCount != order->sampleCount * sampleOrderInfo->width * sampleOrderInfo->height) {
1403 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1404 "VUID-VkCoarseSampleOrderCustomNV-sampleLocationCount-02075",
Dave Houlton142c4cb2018-10-17 15:04:41 -06001405 "VkCoarseSampleOrderCustomNV sampleLocationCount (=%" PRIu32
1406 ") must "
1407 "be equal to the product of sampleCount (=%" PRIu32
1408 "), the fragment width for shadingRate "
Jeff Bolz9af91c52018-09-01 21:53:57 -05001409 "(=%" PRIu32 "), and the fragment height for shadingRate (=%" PRIu32 ").",
1410 order->sampleLocationCount, order->sampleCount, sampleOrderInfo->width, sampleOrderInfo->height);
1411 }
1412
Jeff Bolz5d2b7432018-09-06 10:32:36 -05001413 if (order->sampleLocationCount > device_data->phys_dev_ext_props.shading_rate_image_props.shadingRateMaxCoarseSamples) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06001414 skip |= log_msg(
1415 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1416 "VUID-VkCoarseSampleOrderCustomNV-sampleLocationCount-02076",
1417 "VkCoarseSampleOrderCustomNV sampleLocationCount (=%" PRIu32
1418 ") must "
1419 "be less than or equal to VkPhysicalDeviceShadingRateImagePropertiesNV shadingRateMaxCoarseSamples (=%" PRIu32 ").",
1420 order->sampleLocationCount, device_data->phys_dev_ext_props.shading_rate_image_props.shadingRateMaxCoarseSamples);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001421 }
Jeff Bolz9af91c52018-09-01 21:53:57 -05001422
1423 // Accumulate a bitmask tracking which (x,y,sample) tuples are seen. Expect
Jeff Bolzb8a8dd02018-09-18 02:39:24 -05001424 // the first width*height*sampleCount bits to all be set. Note: There is no
1425 // guarantee that 64 bits is enough, but practically it's unlikely for an
1426 // implementation to support more than 32 bits for samplemask.
Jeff Bolz45bf7d62018-09-18 15:39:58 -05001427 assert(device_data->phys_dev_ext_props.shading_rate_image_props.shadingRateMaxCoarseSamples <= 64);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001428 uint64_t sampleLocationsMask = 0;
1429 for (uint32_t i = 0; i < order->sampleLocationCount; ++i) {
1430 const VkCoarseSampleLocationNV *sampleLoc = &order->pSampleLocations[i];
1431 if (sampleLoc->pixelX >= sampleOrderInfo->width) {
1432 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1433 "VUID-VkCoarseSampleLocationNV-pixelX-02078",
1434 "pixelX must be less than the width (in pixels) of the fragment.");
1435 }
1436 if (sampleLoc->pixelY >= sampleOrderInfo->height) {
1437 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1438 "VUID-VkCoarseSampleLocationNV-pixelY-02079",
1439 "pixelY must be less than the height (in pixels) of the fragment.");
1440 }
1441 if (sampleLoc->sample >= order->sampleCount) {
1442 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1443 "VUID-VkCoarseSampleLocationNV-sample-02080",
1444 "sample must be less than the number of coverage samples in each pixel belonging to the fragment.");
1445 }
1446 uint32_t idx = sampleLoc->sample + order->sampleCount * (sampleLoc->pixelX + sampleOrderInfo->width * sampleLoc->pixelY);
1447 sampleLocationsMask |= 1ULL << idx;
1448 }
1449
1450 uint64_t expectedMask = (order->sampleLocationCount == 64) ? ~0ULL : ((1ULL << order->sampleLocationCount) - 1);
1451 if (sampleLocationsMask != expectedMask) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06001452 skip |= log_msg(
1453 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1454 "VUID-VkCoarseSampleOrderCustomNV-pSampleLocations-02077",
1455 "The array pSampleLocations must contain exactly one entry for "
1456 "every combination of valid values for pixelX, pixelY, and sample in the structure VkCoarseSampleOrderCustomNV.");
Jeff Bolz9af91c52018-09-01 21:53:57 -05001457 }
1458
1459 return skip;
1460}
1461
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001462bool pv_vkCreateGraphicsPipelines(VkDevice device, VkPipelineCache pipelineCache, uint32_t createInfoCount,
1463 const VkGraphicsPipelineCreateInfo *pCreateInfos, const VkAllocationCallbacks *pAllocator,
1464 VkPipeline *pPipelines) {
1465 bool skip = false;
1466 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
1467 debug_report_data *report_data = device_data->report_data;
1468
1469 if (pCreateInfos != nullptr) {
1470 for (uint32_t i = 0; i < createInfoCount; ++i) {
Petr Kraus299ba622017-11-24 03:09:03 +01001471 bool has_dynamic_viewport = false;
1472 bool has_dynamic_scissor = false;
1473 bool has_dynamic_line_width = false;
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001474 bool has_dynamic_viewport_w_scaling_nv = false;
1475 bool has_dynamic_discard_rectangle_ext = false;
1476 bool has_dynamic_sample_locations_ext = false;
Jeff Bolz3e71f782018-08-29 23:15:45 -05001477 bool has_dynamic_exclusive_scissor_nv = false;
Jeff Bolz9af91c52018-09-01 21:53:57 -05001478 bool has_dynamic_shading_rate_palette_nv = false;
Petr Kraus299ba622017-11-24 03:09:03 +01001479 if (pCreateInfos[i].pDynamicState != nullptr) {
1480 const auto &dynamic_state_info = *pCreateInfos[i].pDynamicState;
1481 for (uint32_t state_index = 0; state_index < dynamic_state_info.dynamicStateCount; ++state_index) {
1482 const auto &dynamic_state = dynamic_state_info.pDynamicStates[state_index];
1483 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT) has_dynamic_viewport = true;
1484 if (dynamic_state == VK_DYNAMIC_STATE_SCISSOR) has_dynamic_scissor = true;
1485 if (dynamic_state == VK_DYNAMIC_STATE_LINE_WIDTH) has_dynamic_line_width = true;
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001486 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT_W_SCALING_NV) has_dynamic_viewport_w_scaling_nv = true;
1487 if (dynamic_state == VK_DYNAMIC_STATE_DISCARD_RECTANGLE_EXT) has_dynamic_discard_rectangle_ext = true;
1488 if (dynamic_state == VK_DYNAMIC_STATE_SAMPLE_LOCATIONS_EXT) has_dynamic_sample_locations_ext = true;
Jeff Bolz3e71f782018-08-29 23:15:45 -05001489 if (dynamic_state == VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV) has_dynamic_exclusive_scissor_nv = true;
Dave Houlton142c4cb2018-10-17 15:04:41 -06001490 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT_SHADING_RATE_PALETTE_NV)
1491 has_dynamic_shading_rate_palette_nv = true;
Petr Kraus299ba622017-11-24 03:09:03 +01001492 }
1493 }
1494
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001495 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
1496 if (pCreateInfos[i].pVertexInputState != nullptr) {
1497 auto const &vertex_input_state = pCreateInfos[i].pVertexInputState;
Peter Kohautc7d9d392018-07-15 00:34:07 +02001498
1499 if (vertex_input_state->vertexBindingDescriptionCount > device_data->device_limits.maxVertexInputBindings) {
1500 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1501 "VUID-VkPipelineVertexInputStateCreateInfo-vertexBindingDescriptionCount-00613",
1502 "vkCreateGraphicsPipelines: pararameter "
1503 "pCreateInfo[%d].pVertexInputState->vertexBindingDescriptionCount (%u) is "
1504 "greater than VkPhysicalDeviceLimits::maxVertexInputBindings (%u).",
1505 i, vertex_input_state->vertexBindingDescriptionCount,
1506 device_data->device_limits.maxVertexInputBindings);
1507 }
1508
1509 if (vertex_input_state->vertexAttributeDescriptionCount > device_data->device_limits.maxVertexInputAttributes) {
1510 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1511 "VUID-VkPipelineVertexInputStateCreateInfo-vertexAttributeDescriptionCount-00614",
1512 "vkCreateGraphicsPipelines: pararameter "
Peter Kohaut9e92c5c2018-07-17 10:32:17 +02001513 "pCreateInfo[%d].pVertexInputState->vertexAttributeDescriptionCount (%u) is "
Peter Kohautc7d9d392018-07-15 00:34:07 +02001514 "greater than VkPhysicalDeviceLimits::maxVertexInputAttributes (%u).",
1515 i, vertex_input_state->vertexBindingDescriptionCount,
1516 device_data->device_limits.maxVertexInputAttributes);
1517 }
1518
1519 std::unordered_set<uint32_t> vertex_bindings(vertex_input_state->vertexBindingDescriptionCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001520 for (uint32_t d = 0; d < vertex_input_state->vertexBindingDescriptionCount; ++d) {
1521 auto const &vertex_bind_desc = vertex_input_state->pVertexBindingDescriptions[d];
Peter Kohautc7d9d392018-07-15 00:34:07 +02001522 auto const &binding_it = vertex_bindings.find(vertex_bind_desc.binding);
1523 if (binding_it != vertex_bindings.cend()) {
1524 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1525 "VUID-VkPipelineVertexInputStateCreateInfo-pVertexBindingDescriptions-00616",
1526 "vkCreateGraphicsPipelines: parameter "
1527 "pCreateInfo[%d].pVertexInputState->pVertexBindingDescription[%d].binding "
1528 "(%" PRIu32 ") is not distinct.",
1529 i, d, vertex_bind_desc.binding);
1530 }
1531 vertex_bindings.insert(vertex_bind_desc.binding);
1532
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001533 if (vertex_bind_desc.binding >= device_data->device_limits.maxVertexInputBindings) {
1534 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001535 "VUID-VkVertexInputBindingDescription-binding-00618",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001536 "vkCreateGraphicsPipelines: parameter "
1537 "pCreateInfos[%u].pVertexInputState->pVertexBindingDescriptions[%u].binding (%u) is "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001538 "greater than or equal to VkPhysicalDeviceLimits::maxVertexInputBindings (%u).",
1539 i, d, vertex_bind_desc.binding, device_data->device_limits.maxVertexInputBindings);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001540 }
1541
1542 if (vertex_bind_desc.stride > device_data->device_limits.maxVertexInputBindingStride) {
1543 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001544 "VUID-VkVertexInputBindingDescription-stride-00619",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001545 "vkCreateGraphicsPipelines: parameter "
1546 "pCreateInfos[%u].pVertexInputState->pVertexBindingDescriptions[%u].stride (%u) is greater "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001547 "than VkPhysicalDeviceLimits::maxVertexInputBindingStride (%u).",
1548 i, d, vertex_bind_desc.stride, device_data->device_limits.maxVertexInputBindingStride);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001549 }
1550 }
1551
Peter Kohautc7d9d392018-07-15 00:34:07 +02001552 std::unordered_set<uint32_t> attribute_locations(vertex_input_state->vertexAttributeDescriptionCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001553 for (uint32_t d = 0; d < vertex_input_state->vertexAttributeDescriptionCount; ++d) {
1554 auto const &vertex_attrib_desc = vertex_input_state->pVertexAttributeDescriptions[d];
Peter Kohautc7d9d392018-07-15 00:34:07 +02001555 auto const &location_it = attribute_locations.find(vertex_attrib_desc.location);
1556 if (location_it != attribute_locations.cend()) {
1557 skip |= log_msg(
1558 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1559 "VUID-VkPipelineVertexInputStateCreateInfo-pVertexAttributeDescriptions-00617",
1560 "vkCreateGraphicsPipelines: parameter "
1561 "pCreateInfo[%d].pVertexInputState->vertexAttributeDescriptions[%d].location (%u) is not distinct.",
1562 i, d, vertex_attrib_desc.location);
1563 }
1564 attribute_locations.insert(vertex_attrib_desc.location);
1565
1566 auto const &binding_it = vertex_bindings.find(vertex_attrib_desc.binding);
1567 if (binding_it == vertex_bindings.cend()) {
1568 skip |= log_msg(
1569 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1570 "VUID-VkPipelineVertexInputStateCreateInfo-binding-00615",
1571 "vkCreateGraphicsPipelines: parameter "
1572 " pCreateInfo[%d].pVertexInputState->vertexAttributeDescriptions[%d].binding (%u) does not exist "
1573 "in any pCreateInfo[%d].pVertexInputState->pVertexBindingDescription.",
1574 i, d, vertex_attrib_desc.binding, i);
1575 }
1576
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001577 if (vertex_attrib_desc.location >= device_data->device_limits.maxVertexInputAttributes) {
1578 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001579 "VUID-VkVertexInputAttributeDescription-location-00620",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001580 "vkCreateGraphicsPipelines: parameter "
1581 "pCreateInfos[%u].pVertexInputState->pVertexAttributeDescriptions[%u].location (%u) is "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001582 "greater than or equal to VkPhysicalDeviceLimits::maxVertexInputAttributes (%u).",
1583 i, d, vertex_attrib_desc.location, device_data->device_limits.maxVertexInputAttributes);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001584 }
1585
1586 if (vertex_attrib_desc.binding >= device_data->device_limits.maxVertexInputBindings) {
1587 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001588 "VUID-VkVertexInputAttributeDescription-binding-00621",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001589 "vkCreateGraphicsPipelines: parameter "
1590 "pCreateInfos[%u].pVertexInputState->pVertexAttributeDescriptions[%u].binding (%u) is "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001591 "greater than or equal to VkPhysicalDeviceLimits::maxVertexInputBindings (%u).",
1592 i, d, vertex_attrib_desc.binding, device_data->device_limits.maxVertexInputBindings);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001593 }
1594
1595 if (vertex_attrib_desc.offset > device_data->device_limits.maxVertexInputAttributeOffset) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06001596 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001597 "VUID-VkVertexInputAttributeDescription-offset-00622",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001598 "vkCreateGraphicsPipelines: parameter "
1599 "pCreateInfos[%u].pVertexInputState->pVertexAttributeDescriptions[%u].offset (%u) is "
1600 "greater than VkPhysicalDeviceLimits::maxVertexInputAttributeOffset (%u).",
1601 i, d, vertex_attrib_desc.offset, device_data->device_limits.maxVertexInputAttributeOffset);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001602 }
1603 }
1604 }
1605
1606 if (pCreateInfos[i].pStages != nullptr) {
1607 bool has_control = false;
1608 bool has_eval = false;
1609
1610 for (uint32_t stage_index = 0; stage_index < pCreateInfos[i].stageCount; ++stage_index) {
1611 if (pCreateInfos[i].pStages[stage_index].stage == VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) {
1612 has_control = true;
1613 } else if (pCreateInfos[i].pStages[stage_index].stage == VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT) {
1614 has_eval = true;
1615 }
1616 }
1617
1618 // pTessellationState is ignored without both tessellation control and tessellation evaluation shaders stages
1619 if (has_control && has_eval) {
1620 if (pCreateInfos[i].pTessellationState == nullptr) {
1621 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001622 "VUID-VkGraphicsPipelineCreateInfo-pStages-00731",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001623 "vkCreateGraphicsPipelines: if pCreateInfos[%d].pStages includes a tessellation control "
1624 "shader stage and a tessellation evaluation shader stage, "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001625 "pCreateInfos[%d].pTessellationState must not be NULL.",
1626 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001627 } else {
1628 skip |= validate_struct_pnext(
1629 report_data, "vkCreateGraphicsPipelines",
1630 ParameterName("pCreateInfos[%i].pTessellationState->pNext", ParameterName::IndexVector{i}), NULL,
Dave Houlton413a6782018-05-22 13:01:54 -06001631 pCreateInfos[i].pTessellationState->pNext, 0, NULL, GeneratedHeaderVersion,
1632 "VUID-VkGraphicsPipelineCreateInfo-pNext-pNext");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001633
1634 skip |= validate_reserved_flags(
1635 report_data, "vkCreateGraphicsPipelines",
1636 ParameterName("pCreateInfos[%i].pTessellationState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06001637 pCreateInfos[i].pTessellationState->flags,
1638 "VUID-VkPipelineTessellationStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001639
1640 if (pCreateInfos[i].pTessellationState->sType !=
1641 VK_STRUCTURE_TYPE_PIPELINE_TESSELLATION_STATE_CREATE_INFO) {
1642 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001643 "VUID-VkPipelineTessellationStateCreateInfo-sType-sType",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001644 "vkCreateGraphicsPipelines: parameter pCreateInfos[%d].pTessellationState->sType must "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001645 "be VK_STRUCTURE_TYPE_PIPELINE_TESSELLATION_STATE_CREATE_INFO.",
1646 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001647 }
1648
1649 if (pCreateInfos[i].pTessellationState->patchControlPoints == 0 ||
1650 pCreateInfos[i].pTessellationState->patchControlPoints >
1651 device_data->device_limits.maxTessellationPatchSize) {
1652 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001653 "VUID-VkPipelineTessellationStateCreateInfo-patchControlPoints-01214",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001654 "vkCreateGraphicsPipelines: invalid parameter "
1655 "pCreateInfos[%d].pTessellationState->patchControlPoints value %u. patchControlPoints "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001656 "should be >0 and <=%u.",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001657 i, pCreateInfos[i].pTessellationState->patchControlPoints,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001658 device_data->device_limits.maxTessellationPatchSize);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001659 }
1660 }
1661 }
1662 }
1663
1664 // pViewportState, pMultisampleState, pDepthStencilState, and pColorBlendState ignored when rasterization is disabled
1665 if ((pCreateInfos[i].pRasterizationState != nullptr) &&
1666 (pCreateInfos[i].pRasterizationState->rasterizerDiscardEnable == VK_FALSE)) {
1667 if (pCreateInfos[i].pViewportState == nullptr) {
Petr Krausa6103552017-11-16 21:21:58 +01001668 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001669 VK_NULL_HANDLE, "VUID-VkGraphicsPipelineCreateInfo-rasterizerDiscardEnable-00750",
Petr Krausa6103552017-11-16 21:21:58 +01001670 "vkCreateGraphicsPipelines: Rasterization is enabled (pCreateInfos[%" PRIu32
1671 "].pRasterizationState->rasterizerDiscardEnable is VK_FALSE), but pCreateInfos[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001672 "].pViewportState (=NULL) is not a valid pointer.",
1673 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001674 } else {
Petr Krausa6103552017-11-16 21:21:58 +01001675 const auto &viewport_state = *pCreateInfos[i].pViewportState;
1676
1677 if (viewport_state.sType != VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_STATE_CREATE_INFO) {
1678 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001679 VK_NULL_HANDLE, "VUID-VkPipelineViewportStateCreateInfo-sType-sType",
Petr Krausa6103552017-11-16 21:21:58 +01001680 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001681 "].pViewportState->sType is not VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_STATE_CREATE_INFO.",
1682 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001683 }
1684
Petr Krausa6103552017-11-16 21:21:58 +01001685 const VkStructureType allowed_structs_VkPipelineViewportStateCreateInfo[] = {
1686 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_SWIZZLE_STATE_CREATE_INFO_NV,
Jeff Bolz3e71f782018-08-29 23:15:45 -05001687 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_W_SCALING_STATE_CREATE_INFO_NV,
1688 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_EXCLUSIVE_SCISSOR_STATE_CREATE_INFO_NV,
Jeff Bolz9af91c52018-09-01 21:53:57 -05001689 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_SHADING_RATE_IMAGE_STATE_CREATE_INFO_NV,
1690 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_COARSE_SAMPLE_ORDER_STATE_CREATE_INFO_NV,
Jeff Bolz3e71f782018-08-29 23:15:45 -05001691 };
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001692 skip |= validate_struct_pnext(
1693 report_data, "vkCreateGraphicsPipelines",
Petr Krausa6103552017-11-16 21:21:58 +01001694 ParameterName("pCreateInfos[%i].pViewportState->pNext", ParameterName::IndexVector{i}),
Jeff Bolz9af91c52018-09-01 21:53:57 -05001695 "VkPipelineViewportSwizzleStateCreateInfoNV, VkPipelineViewportWScalingStateCreateInfoNV, "
Jeff Bolzb8a8dd02018-09-18 02:39:24 -05001696 "VkPipelineViewportExclusiveScissorStateCreateInfoNV, VkPipelineViewportShadingRateImageStateCreateInfoNV, "
1697 "VkPipelineViewportCoarseSampleOrderStateCreateInfoNV",
Petr Krausa6103552017-11-16 21:21:58 +01001698 viewport_state.pNext, ARRAY_SIZE(allowed_structs_VkPipelineViewportStateCreateInfo),
Dave Houlton413a6782018-05-22 13:01:54 -06001699 allowed_structs_VkPipelineViewportStateCreateInfo, 65,
1700 "VUID-VkPipelineViewportStateCreateInfo-pNext-pNext");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001701
1702 skip |= validate_reserved_flags(
1703 report_data, "vkCreateGraphicsPipelines",
1704 ParameterName("pCreateInfos[%i].pViewportState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06001705 viewport_state.flags, "VUID-VkPipelineViewportStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001706
Dave Houlton142c4cb2018-10-17 15:04:41 -06001707 auto exclusive_scissor_struct = lvl_find_in_chain<VkPipelineViewportExclusiveScissorStateCreateInfoNV>(
1708 pCreateInfos[i].pViewportState->pNext);
1709 auto shading_rate_image_struct = lvl_find_in_chain<VkPipelineViewportShadingRateImageStateCreateInfoNV>(
1710 pCreateInfos[i].pViewportState->pNext);
1711 auto coarse_sample_order_struct = lvl_find_in_chain<VkPipelineViewportCoarseSampleOrderStateCreateInfoNV>(
1712 pCreateInfos[i].pViewportState->pNext);
Jeff Bolz3e71f782018-08-29 23:15:45 -05001713
Petr Krausa6103552017-11-16 21:21:58 +01001714 if (!device_data->physical_device_features.multiViewport) {
1715 if (viewport_state.viewportCount != 1) {
1716 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001717 VK_NULL_HANDLE, "VUID-VkPipelineViewportStateCreateInfo-viewportCount-01216",
Petr Krausa6103552017-11-16 21:21:58 +01001718 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
1719 "disabled, but pCreateInfos[%" PRIu32 "].pViewportState->viewportCount (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001720 ") is not 1.",
1721 i, viewport_state.viewportCount);
Petr Krausa6103552017-11-16 21:21:58 +01001722 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001723
Petr Krausa6103552017-11-16 21:21:58 +01001724 if (viewport_state.scissorCount != 1) {
1725 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001726 VK_NULL_HANDLE, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-01217",
Petr Krausa6103552017-11-16 21:21:58 +01001727 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
1728 "disabled, but pCreateInfos[%" PRIu32 "].pViewportState->scissorCount (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001729 ") is not 1.",
1730 i, viewport_state.scissorCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001731 }
Jeff Bolz3e71f782018-08-29 23:15:45 -05001732
Dave Houlton142c4cb2018-10-17 15:04:41 -06001733 if (exclusive_scissor_struct && (exclusive_scissor_struct->exclusiveScissorCount != 0 &&
1734 exclusive_scissor_struct->exclusiveScissorCount != 1)) {
1735 skip |=
1736 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
1737 VK_NULL_HANDLE,
1738 "VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-exclusiveScissorCount-02027",
1739 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
1740 "disabled, but pCreateInfos[%" PRIu32
1741 "] VkPipelineViewportExclusiveScissorStateCreateInfoNV::exclusiveScissorCount (=%" PRIu32
1742 ") is not 1.",
1743 i, exclusive_scissor_struct->exclusiveScissorCount);
Jeff Bolz3e71f782018-08-29 23:15:45 -05001744 }
1745
Jeff Bolz9af91c52018-09-01 21:53:57 -05001746 if (shading_rate_image_struct &&
1747 (shading_rate_image_struct->viewportCount != 0 && shading_rate_image_struct->viewportCount != 1)) {
1748 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton142c4cb2018-10-17 15:04:41 -06001749 VK_NULL_HANDLE,
1750 "VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-viewportCount-02054",
Jeff Bolz9af91c52018-09-01 21:53:57 -05001751 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
Dave Houlton142c4cb2018-10-17 15:04:41 -06001752 "disabled, but pCreateInfos[%" PRIu32
1753 "] VkPipelineViewportShadingRateImageStateCreateInfoNV::viewportCount (=%" PRIu32
Jeff Bolzb8a8dd02018-09-18 02:39:24 -05001754 ") is neither 0 nor 1.",
Jeff Bolz9af91c52018-09-01 21:53:57 -05001755 i, shading_rate_image_struct->viewportCount);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001756 }
1757
Petr Krausa6103552017-11-16 21:21:58 +01001758 } else { // multiViewport enabled
1759 if (viewport_state.viewportCount == 0) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001760 skip |= log_msg(
1761 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001762 VK_NULL_HANDLE, "VUID-VkPipelineViewportStateCreateInfo-viewportCount-arraylength",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001763 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "].pViewportState->viewportCount is 0.", i);
Petr Krausa6103552017-11-16 21:21:58 +01001764 } else if (viewport_state.viewportCount > device_data->device_limits.maxViewports) {
1765 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001766 VK_NULL_HANDLE, "VUID-VkPipelineViewportStateCreateInfo-viewportCount-01218",
Petr Krausa6103552017-11-16 21:21:58 +01001767 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1768 "].pViewportState->viewportCount (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001769 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
1770 i, viewport_state.viewportCount, device_data->device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001771 }
Petr Krausa6103552017-11-16 21:21:58 +01001772
1773 if (viewport_state.scissorCount == 0) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001774 skip |= log_msg(
1775 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001776 VK_NULL_HANDLE, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-arraylength",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001777 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "].pViewportState->scissorCount is 0.", i);
Petr Krausa6103552017-11-16 21:21:58 +01001778 } else if (viewport_state.scissorCount > device_data->device_limits.maxViewports) {
1779 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001780 VK_NULL_HANDLE, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-01219",
Petr Krausa6103552017-11-16 21:21:58 +01001781 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1782 "].pViewportState->scissorCount (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001783 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
1784 i, viewport_state.scissorCount, device_data->device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001785 }
1786 }
1787
Jeff Bolz3e71f782018-08-29 23:15:45 -05001788 if (exclusive_scissor_struct &&
1789 exclusive_scissor_struct->exclusiveScissorCount > device_data->device_limits.maxViewports) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06001790 skip |= log_msg(
1791 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, VK_NULL_HANDLE,
1792 "VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-exclusiveScissorCount-02028",
1793 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "] exclusiveScissorCount (=%" PRIu32
1794 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
1795 i, exclusive_scissor_struct->exclusiveScissorCount, device_data->device_limits.maxViewports);
Jeff Bolz3e71f782018-08-29 23:15:45 -05001796 }
1797
Jeff Bolz9af91c52018-09-01 21:53:57 -05001798 if (shading_rate_image_struct &&
1799 shading_rate_image_struct->viewportCount > device_data->device_limits.maxViewports) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06001800 skip |=
1801 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
1802 VK_NULL_HANDLE, "VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-viewportCount-02055",
1803 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1804 "] VkPipelineViewportShadingRateImageStateCreateInfoNV viewportCount (=%" PRIu32
1805 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
1806 i, shading_rate_image_struct->viewportCount, device_data->device_limits.maxViewports);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001807 }
1808
Petr Krausa6103552017-11-16 21:21:58 +01001809 if (viewport_state.scissorCount != viewport_state.viewportCount) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001810 skip |=
1811 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001812 VK_NULL_HANDLE, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-01220",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001813 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "].pViewportState->scissorCount (=%" PRIu32
1814 ") is not identical to pCreateInfos[%" PRIu32 "].pViewportState->viewportCount (=%" PRIu32 ").",
1815 i, viewport_state.scissorCount, i, viewport_state.viewportCount);
Petr Krausa6103552017-11-16 21:21:58 +01001816 }
1817
Dave Houlton142c4cb2018-10-17 15:04:41 -06001818 if (exclusive_scissor_struct && exclusive_scissor_struct->exclusiveScissorCount != 0 &&
Jeff Bolz3e71f782018-08-29 23:15:45 -05001819 exclusive_scissor_struct->exclusiveScissorCount != viewport_state.viewportCount) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06001820 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
1821 VK_NULL_HANDLE,
1822 "VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-exclusiveScissorCount-02029",
1823 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "] exclusiveScissorCount (=%" PRIu32
1824 ") must be zero or identical to pCreateInfos[%" PRIu32
1825 "].pViewportState->viewportCount (=%" PRIu32 ").",
1826 i, exclusive_scissor_struct->exclusiveScissorCount, i, viewport_state.viewportCount);
Jeff Bolz3e71f782018-08-29 23:15:45 -05001827 }
1828
Dave Houlton142c4cb2018-10-17 15:04:41 -06001829 if (shading_rate_image_struct && shading_rate_image_struct->shadingRateImageEnable &&
Jeff Bolz9af91c52018-09-01 21:53:57 -05001830 shading_rate_image_struct->viewportCount != viewport_state.viewportCount) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06001831 skip |= log_msg(
1832 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, VK_NULL_HANDLE,
1833 "VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-shadingRateImageEnable-02056",
1834 "vkCreateGraphicsPipelines: If shadingRateImageEnable is enabled, pCreateInfos[%" PRIu32
1835 "] "
1836 "VkPipelineViewportShadingRateImageStateCreateInfoNV viewportCount (=%" PRIu32
1837 ") must identical to pCreateInfos[%" PRIu32 "].pViewportState->viewportCount (=%" PRIu32 ").",
1838 i, shading_rate_image_struct->viewportCount, i, viewport_state.viewportCount);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001839 }
1840
Petr Krausa6103552017-11-16 21:21:58 +01001841 if (!has_dynamic_viewport && viewport_state.viewportCount > 0 && viewport_state.pViewports == nullptr) {
1842 skip |= log_msg(
1843 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, VK_NULL_HANDLE,
Dave Houlton413a6782018-05-22 13:01:54 -06001844 "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-00747",
Petr Krausa6103552017-11-16 21:21:58 +01001845 "vkCreateGraphicsPipelines: The viewport state is static (pCreateInfos[%" PRIu32
1846 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_VIEWPORT), but pCreateInfos[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001847 "].pViewportState->pViewports (=NULL) is an invalid pointer.",
1848 i, i);
Petr Krausa6103552017-11-16 21:21:58 +01001849 }
1850
1851 if (!has_dynamic_scissor && viewport_state.scissorCount > 0 && viewport_state.pScissors == nullptr) {
1852 skip |= log_msg(
1853 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, VK_NULL_HANDLE,
Dave Houlton413a6782018-05-22 13:01:54 -06001854 "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-00748",
Petr Krausa6103552017-11-16 21:21:58 +01001855 "vkCreateGraphicsPipelines: The scissor state is static (pCreateInfos[%" PRIu32
1856 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_SCISSOR), but pCreateInfos[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001857 "].pViewportState->pScissors (=NULL) is an invalid pointer.",
1858 i, i);
Petr Krausa6103552017-11-16 21:21:58 +01001859 }
1860
Jeff Bolz3e71f782018-08-29 23:15:45 -05001861 if (!has_dynamic_exclusive_scissor_nv && exclusive_scissor_struct &&
Dave Houlton142c4cb2018-10-17 15:04:41 -06001862 exclusive_scissor_struct->exclusiveScissorCount > 0 &&
1863 exclusive_scissor_struct->pExclusiveScissors == nullptr) {
1864 skip |=
1865 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
1866 VK_NULL_HANDLE, "VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-pDynamicStates-02030",
1867 "vkCreateGraphicsPipelines: The exclusive scissor state is static (pCreateInfos[%" PRIu32
1868 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV), but "
1869 "pCreateInfos[%" PRIu32 "] pExclusiveScissors (=NULL) is an invalid pointer.",
1870 i, i);
Jeff Bolz3e71f782018-08-29 23:15:45 -05001871 }
1872
Jeff Bolz9af91c52018-09-01 21:53:57 -05001873 if (!has_dynamic_shading_rate_palette_nv && shading_rate_image_struct &&
Dave Houlton142c4cb2018-10-17 15:04:41 -06001874 shading_rate_image_struct->viewportCount > 0 &&
1875 shading_rate_image_struct->pShadingRatePalettes == nullptr) {
Jeff Bolz9af91c52018-09-01 21:53:57 -05001876 skip |= log_msg(
1877 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, VK_NULL_HANDLE,
1878 "VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-pDynamicStates-02057",
1879 "vkCreateGraphicsPipelines: The shading rate palette state is static (pCreateInfos[%" PRIu32
Dave Houlton142c4cb2018-10-17 15:04:41 -06001880 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_VIEWPORT_SHADING_RATE_PALETTE_NV), "
1881 "but pCreateInfos[%" PRIu32 "] pShadingRatePalettes (=NULL) is an invalid pointer.",
Jeff Bolz9af91c52018-09-01 21:53:57 -05001882 i, i);
1883 }
1884
Petr Krausb3fcdb42018-01-09 22:09:09 +01001885 // validate the VkViewports
1886 if (!has_dynamic_viewport && viewport_state.pViewports) {
1887 for (uint32_t viewport_i = 0; viewport_i < viewport_state.viewportCount; ++viewport_i) {
1888 const auto &viewport = viewport_state.pViewports[viewport_i]; // will crash on invalid ptr
1889 const char fn_name[] = "vkCreateGraphicsPipelines";
1890 const std::string param_name = "pCreateInfos[" + std::to_string(i) + "].pViewportState->pViewports[" +
1891 std::to_string(viewport_i) + "]";
1892 skip |= pv_VkViewport(device_data, viewport, fn_name, param_name.c_str(),
1893 VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT);
1894 }
1895 }
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001896
1897 if (has_dynamic_viewport_w_scaling_nv && !device_data->extensions.vk_nv_clip_space_w_scaling) {
1898 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001899 VK_NULL_HANDLE, kVUID_PVError_ExtensionNotEnabled,
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001900 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
Dave Houltona9df0ce2018-02-07 10:51:23 -07001901 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_VIEWPORT_W_SCALING_NV, but "
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001902 "VK_NV_clip_space_w_scaling extension is not enabled.",
1903 i);
1904 }
1905
1906 if (has_dynamic_discard_rectangle_ext && !device_data->extensions.vk_ext_discard_rectangles) {
1907 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001908 VK_NULL_HANDLE, kVUID_PVError_ExtensionNotEnabled,
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001909 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
Dave Houltona9df0ce2018-02-07 10:51:23 -07001910 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_DISCARD_RECTANGLE_EXT, but "
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001911 "VK_EXT_discard_rectangles extension is not enabled.",
1912 i);
1913 }
1914
1915 if (has_dynamic_sample_locations_ext && !device_data->extensions.vk_ext_sample_locations) {
1916 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001917 VK_NULL_HANDLE, kVUID_PVError_ExtensionNotEnabled,
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001918 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
Dave Houltona9df0ce2018-02-07 10:51:23 -07001919 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_SAMPLE_LOCATIONS_EXT, but "
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001920 "VK_EXT_sample_locations extension is not enabled.",
1921 i);
1922 }
Jeff Bolz3e71f782018-08-29 23:15:45 -05001923
1924 if (has_dynamic_exclusive_scissor_nv && !device_data->extensions.vk_nv_scissor_exclusive) {
1925 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
1926 VK_NULL_HANDLE, kVUID_PVError_ExtensionNotEnabled,
1927 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1928 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV, but "
1929 "VK_NV_scissor_exclusive extension is not enabled.",
1930 i);
1931 }
Jeff Bolz9af91c52018-09-01 21:53:57 -05001932
1933 if (coarse_sample_order_struct &&
1934 coarse_sample_order_struct->sampleOrderType != VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV &&
1935 coarse_sample_order_struct->customSampleOrderCount != 0) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06001936 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
1937 VK_NULL_HANDLE,
1938 "VUID-VkPipelineViewportCoarseSampleOrderStateCreateInfoNV-sampleOrderType-02072",
1939 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1940 "] "
1941 "VkPipelineViewportCoarseSampleOrderStateCreateInfoNV sampleOrderType is not "
1942 "VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV and customSampleOrderCount is not 0.",
1943 i);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001944 }
1945
1946 if (coarse_sample_order_struct) {
1947 for (uint32_t order_i = 0; order_i < coarse_sample_order_struct->customSampleOrderCount; ++order_i) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06001948 skip |= ValidateCoarseSampleOrderCustomNV(device_data,
1949 &coarse_sample_order_struct->pCustomSampleOrders[order_i]);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001950 }
1951 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001952 }
1953
1954 if (pCreateInfos[i].pMultisampleState == nullptr) {
1955 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001956 "VUID-VkGraphicsPipelineCreateInfo-rasterizerDiscardEnable-00751",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001957 "vkCreateGraphicsPipelines: if pCreateInfos[%d].pRasterizationState->rasterizerDiscardEnable "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001958 "is VK_FALSE, pCreateInfos[%d].pMultisampleState must not be NULL.",
1959 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001960 } else {
Dave Houltonb3bbec72018-01-17 10:13:33 -07001961 const VkStructureType valid_next_stypes[] = {LvlTypeMap<VkPipelineCoverageModulationStateCreateInfoNV>::kSType,
1962 LvlTypeMap<VkPipelineCoverageToColorStateCreateInfoNV>::kSType,
1963 LvlTypeMap<VkPipelineSampleLocationsStateCreateInfoEXT>::kSType};
Mike Schuchardt97662b02017-12-06 13:31:29 -07001964 const char *valid_struct_names =
Dave Houltona9df0ce2018-02-07 10:51:23 -07001965 "VkPipelineCoverageModulationStateCreateInfoNV, VkPipelineCoverageToColorStateCreateInfoNV, "
John Zulauf96b0e422017-11-14 11:43:19 -07001966 "VkPipelineSampleLocationsStateCreateInfoEXT";
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001967 skip |= validate_struct_pnext(
1968 report_data, "vkCreateGraphicsPipelines",
John Zulauf96b0e422017-11-14 11:43:19 -07001969 ParameterName("pCreateInfos[%i].pMultisampleState->pNext", ParameterName::IndexVector{i}),
1970 valid_struct_names, pCreateInfos[i].pMultisampleState->pNext, 3, valid_next_stypes, GeneratedHeaderVersion,
Dave Houlton413a6782018-05-22 13:01:54 -06001971 "VUID-VkPipelineMultisampleStateCreateInfo-pNext-pNext");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001972
1973 skip |= validate_reserved_flags(
1974 report_data, "vkCreateGraphicsPipelines",
1975 ParameterName("pCreateInfos[%i].pMultisampleState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06001976 pCreateInfos[i].pMultisampleState->flags, "VUID-VkPipelineMultisampleStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001977
1978 skip |= validate_bool32(
1979 report_data, "vkCreateGraphicsPipelines",
1980 ParameterName("pCreateInfos[%i].pMultisampleState->sampleShadingEnable", ParameterName::IndexVector{i}),
1981 pCreateInfos[i].pMultisampleState->sampleShadingEnable);
1982
1983 skip |= validate_array(
1984 report_data, "vkCreateGraphicsPipelines",
1985 ParameterName("pCreateInfos[%i].pMultisampleState->rasterizationSamples", ParameterName::IndexVector{i}),
1986 ParameterName("pCreateInfos[%i].pMultisampleState->pSampleMask", ParameterName::IndexVector{i}),
Gabríel Arthúr Pétursson092b29b2018-03-21 22:44:11 +00001987 pCreateInfos[i].pMultisampleState->rasterizationSamples, &pCreateInfos[i].pMultisampleState->pSampleMask,
Dave Houlton413a6782018-05-22 13:01:54 -06001988 true, false, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001989
1990 skip |= validate_bool32(
1991 report_data, "vkCreateGraphicsPipelines",
1992 ParameterName("pCreateInfos[%i].pMultisampleState->alphaToCoverageEnable", ParameterName::IndexVector{i}),
1993 pCreateInfos[i].pMultisampleState->alphaToCoverageEnable);
1994
1995 skip |= validate_bool32(
1996 report_data, "vkCreateGraphicsPipelines",
1997 ParameterName("pCreateInfos[%i].pMultisampleState->alphaToOneEnable", ParameterName::IndexVector{i}),
1998 pCreateInfos[i].pMultisampleState->alphaToOneEnable);
1999
2000 if (pCreateInfos[i].pMultisampleState->sType != VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO) {
2001 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002002 kVUID_PVError_InvalidStructSType,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002003 "vkCreateGraphicsPipelines: parameter pCreateInfos[%d].pMultisampleState->sType must be "
2004 "VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO",
2005 i);
2006 }
John Zulauf7acac592017-11-06 11:15:53 -07002007 if (pCreateInfos[i].pMultisampleState->sampleShadingEnable == VK_TRUE) {
2008 if (!device_data->physical_device_features.sampleRateShading) {
2009 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002010 "VUID-VkPipelineMultisampleStateCreateInfo-sampleShadingEnable-00784",
John Zulauf7acac592017-11-06 11:15:53 -07002011 "vkCreateGraphicsPipelines(): parameter "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002012 "pCreateInfos[%d].pMultisampleState->sampleShadingEnable.",
2013 i);
John Zulauf7acac592017-11-06 11:15:53 -07002014 }
2015 // TODO Add documentation issue about when minSampleShading must be in range and when it is ignored
2016 // For now a "least noise" test *only* when sampleShadingEnable is VK_TRUE.
2017 if (!in_inclusive_range(pCreateInfos[i].pMultisampleState->minSampleShading, 0.F, 1.0F)) {
2018 skip |= log_msg(
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002019 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002020 "VUID-VkPipelineMultisampleStateCreateInfo-minSampleShading-00786",
Mark Lobodzinski88529492018-04-01 10:38:15 -06002021 "vkCreateGraphicsPipelines(): parameter pCreateInfos[%d].pMultisampleState->minSampleShading.", i);
John Zulauf7acac592017-11-06 11:15:53 -07002022 }
2023 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002024 }
2025
Petr Krause91f7a12017-12-14 20:57:36 +01002026 bool uses_color_attachment = false;
2027 bool uses_depthstencil_attachment = false;
2028 {
2029 const auto subpasses_uses_it = device_data->renderpasses_states.find(pCreateInfos[i].renderPass);
2030 if (subpasses_uses_it != device_data->renderpasses_states.end()) {
2031 const auto &subpasses_uses = subpasses_uses_it->second;
2032 if (subpasses_uses.subpasses_using_color_attachment.count(pCreateInfos[i].subpass))
2033 uses_color_attachment = true;
2034 if (subpasses_uses.subpasses_using_depthstencil_attachment.count(pCreateInfos[i].subpass))
2035 uses_depthstencil_attachment = true;
2036 }
2037 }
2038
2039 if (pCreateInfos[i].pDepthStencilState != nullptr && uses_depthstencil_attachment) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002040 skip |= validate_struct_pnext(
2041 report_data, "vkCreateGraphicsPipelines",
2042 ParameterName("pCreateInfos[%i].pDepthStencilState->pNext", ParameterName::IndexVector{i}), NULL,
Dave Houlton413a6782018-05-22 13:01:54 -06002043 pCreateInfos[i].pDepthStencilState->pNext, 0, NULL, GeneratedHeaderVersion,
2044 "VUID-VkPipelineDepthStencilStateCreateInfo-pNext-pNext");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002045
2046 skip |= validate_reserved_flags(
2047 report_data, "vkCreateGraphicsPipelines",
2048 ParameterName("pCreateInfos[%i].pDepthStencilState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06002049 pCreateInfos[i].pDepthStencilState->flags, "VUID-VkPipelineDepthStencilStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002050
2051 skip |= validate_bool32(
2052 report_data, "vkCreateGraphicsPipelines",
2053 ParameterName("pCreateInfos[%i].pDepthStencilState->depthTestEnable", ParameterName::IndexVector{i}),
2054 pCreateInfos[i].pDepthStencilState->depthTestEnable);
2055
2056 skip |= validate_bool32(
2057 report_data, "vkCreateGraphicsPipelines",
2058 ParameterName("pCreateInfos[%i].pDepthStencilState->depthWriteEnable", ParameterName::IndexVector{i}),
2059 pCreateInfos[i].pDepthStencilState->depthWriteEnable);
2060
2061 skip |= validate_ranged_enum(
2062 report_data, "vkCreateGraphicsPipelines",
2063 ParameterName("pCreateInfos[%i].pDepthStencilState->depthCompareOp", ParameterName::IndexVector{i}),
2064 "VkCompareOp", AllVkCompareOpEnums, pCreateInfos[i].pDepthStencilState->depthCompareOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002065 "VUID-VkPipelineDepthStencilStateCreateInfo-depthCompareOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002066
2067 skip |= validate_bool32(
2068 report_data, "vkCreateGraphicsPipelines",
2069 ParameterName("pCreateInfos[%i].pDepthStencilState->depthBoundsTestEnable", ParameterName::IndexVector{i}),
2070 pCreateInfos[i].pDepthStencilState->depthBoundsTestEnable);
2071
2072 skip |= validate_bool32(
2073 report_data, "vkCreateGraphicsPipelines",
2074 ParameterName("pCreateInfos[%i].pDepthStencilState->stencilTestEnable", ParameterName::IndexVector{i}),
2075 pCreateInfos[i].pDepthStencilState->stencilTestEnable);
2076
2077 skip |= validate_ranged_enum(
2078 report_data, "vkCreateGraphicsPipelines",
2079 ParameterName("pCreateInfos[%i].pDepthStencilState->front.failOp", ParameterName::IndexVector{i}),
2080 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->front.failOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002081 "VUID-VkStencilOpState-failOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002082
2083 skip |= validate_ranged_enum(
2084 report_data, "vkCreateGraphicsPipelines",
2085 ParameterName("pCreateInfos[%i].pDepthStencilState->front.passOp", ParameterName::IndexVector{i}),
2086 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->front.passOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002087 "VUID-VkStencilOpState-passOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002088
2089 skip |= validate_ranged_enum(
2090 report_data, "vkCreateGraphicsPipelines",
2091 ParameterName("pCreateInfos[%i].pDepthStencilState->front.depthFailOp", ParameterName::IndexVector{i}),
2092 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->front.depthFailOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002093 "VUID-VkStencilOpState-depthFailOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002094
2095 skip |= validate_ranged_enum(
2096 report_data, "vkCreateGraphicsPipelines",
2097 ParameterName("pCreateInfos[%i].pDepthStencilState->front.compareOp", ParameterName::IndexVector{i}),
2098 "VkCompareOp", AllVkCompareOpEnums, pCreateInfos[i].pDepthStencilState->front.compareOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002099 "VUID-VkPipelineDepthStencilStateCreateInfo-depthCompareOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002100
2101 skip |= validate_ranged_enum(
2102 report_data, "vkCreateGraphicsPipelines",
2103 ParameterName("pCreateInfos[%i].pDepthStencilState->back.failOp", ParameterName::IndexVector{i}),
2104 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->back.failOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002105 "VUID-VkStencilOpState-failOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002106
2107 skip |= validate_ranged_enum(
2108 report_data, "vkCreateGraphicsPipelines",
2109 ParameterName("pCreateInfos[%i].pDepthStencilState->back.passOp", ParameterName::IndexVector{i}),
2110 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->back.passOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002111 "VUID-VkStencilOpState-passOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002112
2113 skip |= validate_ranged_enum(
2114 report_data, "vkCreateGraphicsPipelines",
2115 ParameterName("pCreateInfos[%i].pDepthStencilState->back.depthFailOp", ParameterName::IndexVector{i}),
2116 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->back.depthFailOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002117 "VUID-VkStencilOpState-depthFailOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002118
2119 skip |= validate_ranged_enum(
2120 report_data, "vkCreateGraphicsPipelines",
2121 ParameterName("pCreateInfos[%i].pDepthStencilState->back.compareOp", ParameterName::IndexVector{i}),
2122 "VkCompareOp", AllVkCompareOpEnums, pCreateInfos[i].pDepthStencilState->back.compareOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002123 "VUID-VkPipelineDepthStencilStateCreateInfo-depthCompareOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002124
2125 if (pCreateInfos[i].pDepthStencilState->sType != VK_STRUCTURE_TYPE_PIPELINE_DEPTH_STENCIL_STATE_CREATE_INFO) {
2126 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002127 kVUID_PVError_InvalidStructSType,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002128 "vkCreateGraphicsPipelines: parameter pCreateInfos[%d].pDepthStencilState->sType must be "
2129 "VK_STRUCTURE_TYPE_PIPELINE_DEPTH_STENCIL_STATE_CREATE_INFO",
2130 i);
2131 }
2132 }
2133
Shannon McPherson9b9532b2018-10-24 12:00:09 -06002134 const VkStructureType allowed_structs_VkPipelineColorBlendStateCreateInfo[] = {
2135 VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_ADVANCED_STATE_CREATE_INFO_EXT};
2136
Petr Krause91f7a12017-12-14 20:57:36 +01002137 if (pCreateInfos[i].pColorBlendState != nullptr && uses_color_attachment) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002138 skip |= validate_struct_pnext(
2139 report_data, "vkCreateGraphicsPipelines",
Shannon McPherson9b9532b2018-10-24 12:00:09 -06002140 ParameterName("pCreateInfos[%i].pColorBlendState->pNext", ParameterName::IndexVector{i}),
2141 "VkPipelineColorBlendAdvancedStateCreateInfoEXT", pCreateInfos[i].pColorBlendState->pNext,
2142 ARRAY_SIZE(allowed_structs_VkPipelineColorBlendStateCreateInfo),
2143 allowed_structs_VkPipelineColorBlendStateCreateInfo, GeneratedHeaderVersion,
Dave Houlton413a6782018-05-22 13:01:54 -06002144 "VUID-VkPipelineColorBlendStateCreateInfo-pNext-pNext");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002145
2146 skip |= validate_reserved_flags(
2147 report_data, "vkCreateGraphicsPipelines",
2148 ParameterName("pCreateInfos[%i].pColorBlendState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06002149 pCreateInfos[i].pColorBlendState->flags, "VUID-VkPipelineColorBlendStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002150
2151 skip |= validate_bool32(
2152 report_data, "vkCreateGraphicsPipelines",
2153 ParameterName("pCreateInfos[%i].pColorBlendState->logicOpEnable", ParameterName::IndexVector{i}),
2154 pCreateInfos[i].pColorBlendState->logicOpEnable);
2155
2156 skip |= validate_array(
2157 report_data, "vkCreateGraphicsPipelines",
2158 ParameterName("pCreateInfos[%i].pColorBlendState->attachmentCount", ParameterName::IndexVector{i}),
2159 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments", ParameterName::IndexVector{i}),
Gabríel Arthúr Pétursson092b29b2018-03-21 22:44:11 +00002160 pCreateInfos[i].pColorBlendState->attachmentCount, &pCreateInfos[i].pColorBlendState->pAttachments, false,
Dave Houlton413a6782018-05-22 13:01:54 -06002161 true, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002162
2163 if (pCreateInfos[i].pColorBlendState->pAttachments != NULL) {
2164 for (uint32_t attachmentIndex = 0; attachmentIndex < pCreateInfos[i].pColorBlendState->attachmentCount;
2165 ++attachmentIndex) {
2166 skip |= validate_bool32(report_data, "vkCreateGraphicsPipelines",
2167 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].blendEnable",
2168 ParameterName::IndexVector{i, attachmentIndex}),
2169 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].blendEnable);
2170
2171 skip |= validate_ranged_enum(
2172 report_data, "vkCreateGraphicsPipelines",
2173 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].srcColorBlendFactor",
2174 ParameterName::IndexVector{i, attachmentIndex}),
2175 "VkBlendFactor", AllVkBlendFactorEnums,
2176 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].srcColorBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06002177 "VUID-VkPipelineColorBlendAttachmentState-srcColorBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002178
2179 skip |= validate_ranged_enum(
2180 report_data, "vkCreateGraphicsPipelines",
2181 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].dstColorBlendFactor",
2182 ParameterName::IndexVector{i, attachmentIndex}),
2183 "VkBlendFactor", AllVkBlendFactorEnums,
2184 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].dstColorBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06002185 "VUID-VkPipelineColorBlendAttachmentState-dstColorBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002186
2187 skip |= validate_ranged_enum(
2188 report_data, "vkCreateGraphicsPipelines",
2189 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].colorBlendOp",
2190 ParameterName::IndexVector{i, attachmentIndex}),
2191 "VkBlendOp", AllVkBlendOpEnums,
2192 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].colorBlendOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002193 "VUID-VkPipelineColorBlendAttachmentState-colorBlendOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002194
2195 skip |= validate_ranged_enum(
2196 report_data, "vkCreateGraphicsPipelines",
2197 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].srcAlphaBlendFactor",
2198 ParameterName::IndexVector{i, attachmentIndex}),
2199 "VkBlendFactor", AllVkBlendFactorEnums,
2200 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].srcAlphaBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06002201 "VUID-VkPipelineColorBlendAttachmentState-srcAlphaBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002202
2203 skip |= validate_ranged_enum(
2204 report_data, "vkCreateGraphicsPipelines",
2205 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].dstAlphaBlendFactor",
2206 ParameterName::IndexVector{i, attachmentIndex}),
2207 "VkBlendFactor", AllVkBlendFactorEnums,
2208 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].dstAlphaBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06002209 "VUID-VkPipelineColorBlendAttachmentState-dstAlphaBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002210
2211 skip |= validate_ranged_enum(
2212 report_data, "vkCreateGraphicsPipelines",
2213 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].alphaBlendOp",
2214 ParameterName::IndexVector{i, attachmentIndex}),
2215 "VkBlendOp", AllVkBlendOpEnums,
2216 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].alphaBlendOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002217 "VUID-VkPipelineColorBlendAttachmentState-alphaBlendOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002218
2219 skip |=
2220 validate_flags(report_data, "vkCreateGraphicsPipelines",
2221 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].colorWriteMask",
2222 ParameterName::IndexVector{i, attachmentIndex}),
2223 "VkColorComponentFlagBits", AllVkColorComponentFlagBits,
2224 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].colorWriteMask,
Dave Houlton413a6782018-05-22 13:01:54 -06002225 false, false, "VUID-VkPipelineColorBlendAttachmentState-colorWriteMask-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002226 }
2227 }
2228
2229 if (pCreateInfos[i].pColorBlendState->sType != VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO) {
2230 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002231 kVUID_PVError_InvalidStructSType,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002232 "vkCreateGraphicsPipelines: parameter pCreateInfos[%d].pColorBlendState->sType must be "
2233 "VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO",
2234 i);
2235 }
2236
2237 // If logicOpEnable is VK_TRUE, logicOp must be a valid VkLogicOp value
2238 if (pCreateInfos[i].pColorBlendState->logicOpEnable == VK_TRUE) {
2239 skip |= validate_ranged_enum(
2240 report_data, "vkCreateGraphicsPipelines",
2241 ParameterName("pCreateInfos[%i].pColorBlendState->logicOp", ParameterName::IndexVector{i}), "VkLogicOp",
Dave Houlton413a6782018-05-22 13:01:54 -06002242 AllVkLogicOpEnums, pCreateInfos[i].pColorBlendState->logicOp,
2243 "VUID-VkPipelineColorBlendStateCreateInfo-logicOpEnable-00607");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002244 }
2245 }
2246 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002247
Petr Kraus9752aae2017-11-24 03:05:50 +01002248 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_DERIVATIVE_BIT) {
2249 if (pCreateInfos[i].basePipelineIndex != -1) {
2250 if (pCreateInfos[i].basePipelineHandle != VK_NULL_HANDLE) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07002251 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002252 "VUID-VkGraphicsPipelineCreateInfo-flags-00724",
Dave Houltona9df0ce2018-02-07 10:51:23 -07002253 "vkCreateGraphicsPipelines parameter, pCreateInfos->basePipelineHandle, must be "
2254 "VK_NULL_HANDLE if pCreateInfos->flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT flag "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002255 "and pCreateInfos->basePipelineIndex is not -1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002256 }
2257 }
2258
Petr Kraus9752aae2017-11-24 03:05:50 +01002259 if (pCreateInfos[i].basePipelineHandle != VK_NULL_HANDLE) {
2260 if (pCreateInfos[i].basePipelineIndex != -1) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07002261 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002262 "VUID-VkGraphicsPipelineCreateInfo-flags-00725",
Dave Houltona9df0ce2018-02-07 10:51:23 -07002263 "vkCreateGraphicsPipelines parameter, pCreateInfos->basePipelineIndex, must be -1 if "
2264 "pCreateInfos->flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT flag and "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002265 "pCreateInfos->basePipelineHandle is not VK_NULL_HANDLE.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002266 }
2267 }
2268 }
2269
Petr Kraus9752aae2017-11-24 03:05:50 +01002270 if (pCreateInfos[i].pRasterizationState) {
2271 if ((pCreateInfos[i].pRasterizationState->polygonMode != VK_POLYGON_MODE_FILL) &&
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002272 (device_data->physical_device_features.fillModeNonSolid == false)) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07002273 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002274 kVUID_PVError_DeviceFeature,
Dave Houltona9df0ce2018-02-07 10:51:23 -07002275 "vkCreateGraphicsPipelines parameter, VkPolygonMode "
2276 "pCreateInfos->pRasterizationState->polygonMode cannot be VK_POLYGON_MODE_POINT or "
2277 "VK_POLYGON_MODE_LINE if VkPhysicalDeviceFeatures->fillModeNonSolid is false.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002278 }
Petr Kraus299ba622017-11-24 03:09:03 +01002279
2280 if (!has_dynamic_line_width && !device_data->physical_device_features.wideLines &&
2281 (pCreateInfos[i].pRasterizationState->lineWidth != 1.0f)) {
Dave Houlton413a6782018-05-22 13:01:54 -06002282 skip |=
2283 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
2284 0, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-00749",
2285 "The line width state is static (pCreateInfos[%" PRIu32
2286 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_LINE_WIDTH) and "
2287 "VkPhysicalDeviceFeatures::wideLines is disabled, but pCreateInfos[%" PRIu32
2288 "].pRasterizationState->lineWidth (=%f) is not 1.0.",
2289 i, i, pCreateInfos[i].pRasterizationState->lineWidth);
Petr Kraus299ba622017-11-24 03:09:03 +01002290 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002291 }
2292
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002293 for (size_t j = 0; j < pCreateInfos[i].stageCount; j++) {
2294 skip |= validate_string(device_data->report_data, "vkCreateGraphicsPipelines",
2295 ParameterName("pCreateInfos[%i].pStages[%i].pName", ParameterName::IndexVector{i, j}),
Mark Lobodzinskiebee3552018-05-29 09:55:54 -06002296 "VUID-VkGraphicsPipelineCreateInfo-pStages-parameter", pCreateInfos[i].pStages[j].pName);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002297 }
2298 }
2299 }
2300
2301 return skip;
2302}
2303
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002304bool pv_vkCreateComputePipelines(VkDevice device, VkPipelineCache pipelineCache, uint32_t createInfoCount,
2305 const VkComputePipelineCreateInfo *pCreateInfos, const VkAllocationCallbacks *pAllocator,
2306 VkPipeline *pPipelines) {
2307 bool skip = false;
2308 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2309
2310 for (uint32_t i = 0; i < createInfoCount; i++) {
2311 skip |= validate_string(device_data->report_data, "vkCreateComputePipelines",
2312 ParameterName("pCreateInfos[%i].stage.pName", ParameterName::IndexVector{i}),
Mark Lobodzinskiebee3552018-05-29 09:55:54 -06002313 "VUID-VkPipelineShaderStageCreateInfo-pName-parameter", pCreateInfos[i].stage.pName);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002314 }
2315
2316 return skip;
2317}
2318
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002319bool pv_vkCreateSampler(VkDevice device, const VkSamplerCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
2320 VkSampler *pSampler) {
2321 bool skip = false;
2322 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2323 debug_report_data *report_data = device_data->report_data;
2324
2325 if (pCreateInfo != nullptr) {
John Zulauf71968502017-10-26 13:51:15 -06002326 const auto &features = device_data->physical_device_features;
2327 const auto &limits = device_data->device_limits;
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002328
John Zulauf71968502017-10-26 13:51:15 -06002329 if (pCreateInfo->anisotropyEnable == VK_TRUE) {
2330 if (!in_inclusive_range(pCreateInfo->maxAnisotropy, 1.0F, limits.maxSamplerAnisotropy)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002331 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002332 "VUID-VkSamplerCreateInfo-anisotropyEnable-01071",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002333 "vkCreateSampler(): value of %s must be in range [1.0, %f] %s, but %f found.",
John Zulauf71968502017-10-26 13:51:15 -06002334 "pCreateInfo->maxAnisotropy", limits.maxSamplerAnisotropy,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002335 "VkPhysicalDeviceLimits::maxSamplerAnistropy", pCreateInfo->maxAnisotropy);
John Zulauf71968502017-10-26 13:51:15 -06002336 }
2337
2338 // Anistropy cannot be enabled in sampler unless enabled as a feature
2339 if (features.samplerAnisotropy == VK_FALSE) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002340 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002341 "VUID-VkSamplerCreateInfo-anisotropyEnable-01070",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002342 "vkCreateSampler(): Anisotropic sampling feature is not enabled, %s must be VK_FALSE.",
2343 "pCreateInfo->anisotropyEnable");
John Zulauf71968502017-10-26 13:51:15 -06002344 }
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002345 }
John Zulauf71968502017-10-26 13:51:15 -06002346
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002347 if (pCreateInfo->unnormalizedCoordinates == VK_TRUE) {
2348 if (pCreateInfo->minFilter != pCreateInfo->magFilter) {
2349 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
2350 "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01072",
2351 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
2352 "pCreateInfo->minFilter (%s) and pCreateInfo->magFilter (%s) must be equal.",
2353 string_VkFilter(pCreateInfo->minFilter), string_VkFilter(pCreateInfo->magFilter));
2354 }
2355 if (pCreateInfo->mipmapMode != VK_SAMPLER_MIPMAP_MODE_NEAREST) {
2356 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
2357 "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01073",
2358 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
2359 "pCreateInfo->mipmapMode (%s) must be VK_SAMPLER_MIPMAP_MODE_NEAREST.",
2360 string_VkSamplerMipmapMode(pCreateInfo->mipmapMode));
2361 }
2362 if (pCreateInfo->minLod != 0.0f || pCreateInfo->maxLod != 0.0f) {
2363 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
2364 "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01074",
2365 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
2366 "pCreateInfo->minLod (%f) and pCreateInfo->maxLod (%f) must both be zero.",
2367 pCreateInfo->minLod, pCreateInfo->maxLod);
2368 }
2369 if ((pCreateInfo->addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE &&
2370 pCreateInfo->addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER) ||
2371 (pCreateInfo->addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE &&
2372 pCreateInfo->addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER)) {
2373 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
2374 "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01075",
2375 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
2376 "pCreateInfo->addressModeU (%s) and pCreateInfo->addressModeV (%s) must both be "
2377 "VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE or VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER.",
2378 string_VkSamplerAddressMode(pCreateInfo->addressModeU),
2379 string_VkSamplerAddressMode(pCreateInfo->addressModeV));
2380 }
2381 if (pCreateInfo->anisotropyEnable == VK_TRUE) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002382 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002383 "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01076",
Dave Houltona9df0ce2018-02-07 10:51:23 -07002384 "vkCreateSampler(): pCreateInfo->anisotropyEnable and pCreateInfo->unnormalizedCoordinates must "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002385 "not both be VK_TRUE.");
John Zulauf71968502017-10-26 13:51:15 -06002386 }
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002387 if (pCreateInfo->compareEnable == VK_TRUE) {
2388 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
2389 "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01077",
2390 "vkCreateSampler(): pCreateInfo->compareEnable and pCreateInfo->unnormalizedCoordinates must "
2391 "not both be VK_TRUE.");
2392 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002393 }
2394
2395 // If compareEnable is VK_TRUE, compareOp must be a valid VkCompareOp value
2396 if (pCreateInfo->compareEnable == VK_TRUE) {
Dave Houlton413a6782018-05-22 13:01:54 -06002397 skip |=
2398 validate_ranged_enum(report_data, "vkCreateSampler", "pCreateInfo->compareOp", "VkCompareOp", AllVkCompareOpEnums,
2399 pCreateInfo->compareOp, "VUID-VkSamplerCreateInfo-compareEnable-01080");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002400 }
2401
2402 // If any of addressModeU, addressModeV or addressModeW are VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER, borderColor must be a
2403 // valid VkBorderColor value
2404 if ((pCreateInfo->addressModeU == VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER) ||
2405 (pCreateInfo->addressModeV == VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER) ||
2406 (pCreateInfo->addressModeW == VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER)) {
2407 skip |= validate_ranged_enum(report_data, "vkCreateSampler", "pCreateInfo->borderColor", "VkBorderColor",
Dave Houlton413a6782018-05-22 13:01:54 -06002408 AllVkBorderColorEnums, pCreateInfo->borderColor,
2409 "VUID-VkSamplerCreateInfo-addressModeU-01078");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002410 }
2411
2412 // If any of addressModeU, addressModeV or addressModeW are VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE, the
2413 // VK_KHR_sampler_mirror_clamp_to_edge extension must be enabled
2414 if (!device_data->extensions.vk_khr_sampler_mirror_clamp_to_edge &&
2415 ((pCreateInfo->addressModeU == VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE) ||
2416 (pCreateInfo->addressModeV == VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE) ||
2417 (pCreateInfo->addressModeW == VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE))) {
Dave Houlton413a6782018-05-22 13:01:54 -06002418 skip |=
2419 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
2420 "VUID-VkSamplerCreateInfo-addressModeU-01079",
2421 "vkCreateSampler(): A VkSamplerAddressMode value is set to VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE "
2422 "but the VK_KHR_sampler_mirror_clamp_to_edge extension has not been enabled.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002423 }
John Zulauf275805c2017-10-26 15:34:49 -06002424
2425 // Checks for the IMG cubic filtering extension
2426 if (device_data->extensions.vk_img_filter_cubic) {
2427 if ((pCreateInfo->anisotropyEnable == VK_TRUE) &&
2428 ((pCreateInfo->minFilter == VK_FILTER_CUBIC_IMG) || (pCreateInfo->magFilter == VK_FILTER_CUBIC_IMG))) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002429 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002430 "VUID-VkSamplerCreateInfo-magFilter-01081",
Dave Houltona9df0ce2018-02-07 10:51:23 -07002431 "vkCreateSampler(): Anisotropic sampling must not be VK_TRUE when either minFilter or magFilter "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002432 "are VK_FILTER_CUBIC_IMG.");
John Zulauf275805c2017-10-26 15:34:49 -06002433 }
2434 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002435 }
2436
2437 return skip;
2438}
2439
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002440bool pv_vkCreateDescriptorSetLayout(VkDevice device, const VkDescriptorSetLayoutCreateInfo *pCreateInfo,
2441 const VkAllocationCallbacks *pAllocator, VkDescriptorSetLayout *pSetLayout) {
2442 bool skip = false;
2443 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2444 debug_report_data *report_data = device_data->report_data;
2445
2446 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
2447 if ((pCreateInfo != nullptr) && (pCreateInfo->pBindings != nullptr)) {
2448 for (uint32_t i = 0; i < pCreateInfo->bindingCount; ++i) {
2449 if (pCreateInfo->pBindings[i].descriptorCount != 0) {
2450 // If descriptorType is VK_DESCRIPTOR_TYPE_SAMPLER or VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER, and descriptorCount
2451 // is not 0 and pImmutableSamplers is not NULL, pImmutableSamplers must be a pointer to an array of descriptorCount
2452 // valid VkSampler handles
2453 if (((pCreateInfo->pBindings[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLER) ||
2454 (pCreateInfo->pBindings[i].descriptorType == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER)) &&
2455 (pCreateInfo->pBindings[i].pImmutableSamplers != nullptr)) {
2456 for (uint32_t descriptor_index = 0; descriptor_index < pCreateInfo->pBindings[i].descriptorCount;
2457 ++descriptor_index) {
2458 if (pCreateInfo->pBindings[i].pImmutableSamplers[descriptor_index] == VK_NULL_HANDLE) {
2459 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002460 kVUID_PVError_RequiredParameter,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002461 "vkCreateDescriptorSetLayout: required parameter "
Dave Houltona9df0ce2018-02-07 10:51:23 -07002462 "pCreateInfo->pBindings[%d].pImmutableSamplers[%d] specified as VK_NULL_HANDLE",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002463 i, descriptor_index);
2464 }
2465 }
2466 }
2467
2468 // If descriptorCount is not 0, stageFlags must be a valid combination of VkShaderStageFlagBits values
2469 if ((pCreateInfo->pBindings[i].stageFlags != 0) &&
2470 ((pCreateInfo->pBindings[i].stageFlags & (~AllVkShaderStageFlagBits)) != 0)) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07002471 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002472 "VUID-VkDescriptorSetLayoutBinding-descriptorCount-00283",
Dave Houltona9df0ce2018-02-07 10:51:23 -07002473 "vkCreateDescriptorSetLayout(): if pCreateInfo->pBindings[%d].descriptorCount is not 0, "
2474 "pCreateInfo->pBindings[%d].stageFlags must be a valid combination of VkShaderStageFlagBits "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002475 "values.",
2476 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002477 }
2478 }
2479 }
2480 }
2481
2482 return skip;
2483}
2484
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002485bool pv_vkFreeDescriptorSets(VkDevice device, VkDescriptorPool descriptorPool, uint32_t descriptorSetCount,
2486 const VkDescriptorSet *pDescriptorSets) {
2487 bool skip = false;
2488 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2489 debug_report_data *report_data = device_data->report_data;
2490
2491 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
2492 // This is an array of handles, where the elements are allowed to be VK_NULL_HANDLE, and does not require any validation beyond
2493 // validate_array()
2494 skip |= validate_array(report_data, "vkFreeDescriptorSets", "descriptorSetCount", "pDescriptorSets", descriptorSetCount,
Dave Houlton413a6782018-05-22 13:01:54 -06002495 &pDescriptorSets, true, true, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002496 return skip;
2497}
2498
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002499bool pv_vkUpdateDescriptorSets(VkDevice device, uint32_t descriptorWriteCount, const VkWriteDescriptorSet *pDescriptorWrites,
2500 uint32_t descriptorCopyCount, const VkCopyDescriptorSet *pDescriptorCopies) {
2501 bool skip = false;
2502 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2503 debug_report_data *report_data = device_data->report_data;
2504
2505 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
2506 if (pDescriptorWrites != NULL) {
2507 for (uint32_t i = 0; i < descriptorWriteCount; ++i) {
2508 // descriptorCount must be greater than 0
2509 if (pDescriptorWrites[i].descriptorCount == 0) {
2510 skip |=
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002511 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002512 "VUID-VkWriteDescriptorSet-descriptorCount-arraylength",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002513 "vkUpdateDescriptorSets(): parameter pDescriptorWrites[%d].descriptorCount must be greater than 0.", i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002514 }
2515
2516 // dstSet must be a valid VkDescriptorSet handle
2517 skip |= validate_required_handle(report_data, "vkUpdateDescriptorSets",
2518 ParameterName("pDescriptorWrites[%i].dstSet", ParameterName::IndexVector{i}),
2519 pDescriptorWrites[i].dstSet);
2520
2521 if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLER) ||
2522 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER) ||
2523 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE) ||
2524 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_IMAGE) ||
2525 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT)) {
2526 // If descriptorType is VK_DESCRIPTOR_TYPE_SAMPLER, VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER,
2527 // VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE, VK_DESCRIPTOR_TYPE_STORAGE_IMAGE or VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT,
2528 // pImageInfo must be a pointer to an array of descriptorCount valid VkDescriptorImageInfo structures
2529 if (pDescriptorWrites[i].pImageInfo == nullptr) {
2530 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002531 "VUID-VkWriteDescriptorSet-descriptorType-00322",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002532 "vkUpdateDescriptorSets(): if pDescriptorWrites[%d].descriptorType is "
2533 "VK_DESCRIPTOR_TYPE_SAMPLER, VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER, "
2534 "VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE, VK_DESCRIPTOR_TYPE_STORAGE_IMAGE or "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002535 "VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT, pDescriptorWrites[%d].pImageInfo must not be NULL.",
2536 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002537 } else if (pDescriptorWrites[i].descriptorType != VK_DESCRIPTOR_TYPE_SAMPLER) {
2538 // If descriptorType is VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER, VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE,
2539 // VK_DESCRIPTOR_TYPE_STORAGE_IMAGE or VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT, the imageView and imageLayout
2540 // members of any given element of pImageInfo must be a valid VkImageView and VkImageLayout, respectively
2541 for (uint32_t descriptor_index = 0; descriptor_index < pDescriptorWrites[i].descriptorCount;
2542 ++descriptor_index) {
2543 skip |= validate_required_handle(report_data, "vkUpdateDescriptorSets",
2544 ParameterName("pDescriptorWrites[%i].pImageInfo[%i].imageView",
2545 ParameterName::IndexVector{i, descriptor_index}),
2546 pDescriptorWrites[i].pImageInfo[descriptor_index].imageView);
2547 skip |= validate_ranged_enum(report_data, "vkUpdateDescriptorSets",
2548 ParameterName("pDescriptorWrites[%i].pImageInfo[%i].imageLayout",
2549 ParameterName::IndexVector{i, descriptor_index}),
2550 "VkImageLayout", AllVkImageLayoutEnums,
Dave Houlton413a6782018-05-22 13:01:54 -06002551 pDescriptorWrites[i].pImageInfo[descriptor_index].imageLayout, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002552 }
2553 }
2554 } else if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER) ||
2555 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER) ||
2556 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC) ||
2557 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC)) {
2558 // If descriptorType is VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER, VK_DESCRIPTOR_TYPE_STORAGE_BUFFER,
2559 // VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC or VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC, pBufferInfo must be a
2560 // pointer to an array of descriptorCount valid VkDescriptorBufferInfo structures
2561 if (pDescriptorWrites[i].pBufferInfo == nullptr) {
2562 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002563 "VUID-VkWriteDescriptorSet-descriptorType-00324",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002564 "vkUpdateDescriptorSets(): if pDescriptorWrites[%d].descriptorType is "
2565 "VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER, VK_DESCRIPTOR_TYPE_STORAGE_BUFFER, "
2566 "VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC or VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC, "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002567 "pDescriptorWrites[%d].pBufferInfo must not be NULL.",
2568 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002569 } else {
2570 for (uint32_t descriptorIndex = 0; descriptorIndex < pDescriptorWrites[i].descriptorCount; ++descriptorIndex) {
2571 skip |= validate_required_handle(report_data, "vkUpdateDescriptorSets",
2572 ParameterName("pDescriptorWrites[%i].pBufferInfo[%i].buffer",
2573 ParameterName::IndexVector{i, descriptorIndex}),
2574 pDescriptorWrites[i].pBufferInfo[descriptorIndex].buffer);
2575 }
2576 }
2577 } else if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER) ||
2578 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER)) {
2579 // If descriptorType is VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER or VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER,
2580 // pTexelBufferView must be a pointer to an array of descriptorCount valid VkBufferView handles
2581 if (pDescriptorWrites[i].pTexelBufferView == nullptr) {
2582 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002583 "VUID-VkWriteDescriptorSet-descriptorType-00323",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002584 "vkUpdateDescriptorSets(): if pDescriptorWrites[%d].descriptorType is "
2585 "VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER or VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER, "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002586 "pDescriptorWrites[%d].pTexelBufferView must not be NULL.",
2587 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002588 } else {
2589 for (uint32_t descriptor_index = 0; descriptor_index < pDescriptorWrites[i].descriptorCount;
2590 ++descriptor_index) {
2591 skip |= validate_required_handle(report_data, "vkUpdateDescriptorSets",
2592 ParameterName("pDescriptorWrites[%i].pTexelBufferView[%i]",
2593 ParameterName::IndexVector{i, descriptor_index}),
2594 pDescriptorWrites[i].pTexelBufferView[descriptor_index]);
2595 }
2596 }
2597 }
2598
2599 if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER) ||
2600 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC)) {
2601 VkDeviceSize uniformAlignment = device_data->device_limits.minUniformBufferOffsetAlignment;
2602 for (uint32_t j = 0; j < pDescriptorWrites[i].descriptorCount; j++) {
2603 if (pDescriptorWrites[i].pBufferInfo != NULL) {
2604 if (SafeModulo(pDescriptorWrites[i].pBufferInfo[j].offset, uniformAlignment) != 0) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06002605 skip |=
2606 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002607 VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0,
2608 "VUID-VkWriteDescriptorSet-descriptorType-00327",
Mark Lobodzinski88529492018-04-01 10:38:15 -06002609 "vkUpdateDescriptorSets(): pDescriptorWrites[%d].pBufferInfo[%d].offset (0x%" PRIxLEAST64
2610 ") must be a multiple of device limit minUniformBufferOffsetAlignment 0x%" PRIxLEAST64 ".",
2611 i, j, pDescriptorWrites[i].pBufferInfo[j].offset, uniformAlignment);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002612 }
2613 }
2614 }
2615 } else if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER) ||
2616 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC)) {
2617 VkDeviceSize storageAlignment = device_data->device_limits.minStorageBufferOffsetAlignment;
2618 for (uint32_t j = 0; j < pDescriptorWrites[i].descriptorCount; j++) {
2619 if (pDescriptorWrites[i].pBufferInfo != NULL) {
2620 if (SafeModulo(pDescriptorWrites[i].pBufferInfo[j].offset, storageAlignment) != 0) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06002621 skip |=
2622 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002623 VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0,
2624 "VUID-VkWriteDescriptorSet-descriptorType-00328",
Mark Lobodzinski88529492018-04-01 10:38:15 -06002625 "vkUpdateDescriptorSets(): pDescriptorWrites[%d].pBufferInfo[%d].offset (0x%" PRIxLEAST64
2626 ") must be a multiple of device limit minStorageBufferOffsetAlignment 0x%" PRIxLEAST64 ".",
2627 i, j, pDescriptorWrites[i].pBufferInfo[j].offset, storageAlignment);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002628 }
2629 }
2630 }
2631 }
2632 }
2633 }
2634 return skip;
2635}
2636
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002637bool pv_vkCreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
2638 VkRenderPass *pRenderPass) {
2639 bool skip = false;
2640 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2641 uint32_t max_color_attachments = device_data->device_limits.maxColorAttachments;
2642
2643 for (uint32_t i = 0; i < pCreateInfo->attachmentCount; ++i) {
2644 if (pCreateInfo->pAttachments[i].format == VK_FORMAT_UNDEFINED) {
2645 std::stringstream ss;
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002646 ss << "vkCreateRenderPass: pCreateInfo->pAttachments[" << i << "].format is VK_FORMAT_UNDEFINED. ";
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002647 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002648 "VUID-VkAttachmentDescription-format-parameter", "%s", ss.str().c_str());
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002649 }
2650 if (pCreateInfo->pAttachments[i].finalLayout == VK_IMAGE_LAYOUT_UNDEFINED ||
2651 pCreateInfo->pAttachments[i].finalLayout == VK_IMAGE_LAYOUT_PREINITIALIZED) {
2652 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002653 "VUID-VkAttachmentDescription-finalLayout-00843",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002654 "pCreateInfo->pAttachments[%d].finalLayout must not be VK_IMAGE_LAYOUT_UNDEFINED or "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002655 "VK_IMAGE_LAYOUT_PREINITIALIZED.",
2656 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002657 }
2658 }
2659
2660 for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) {
2661 if (pCreateInfo->pSubpasses[i].colorAttachmentCount > max_color_attachments) {
2662 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002663 "VUID-VkSubpassDescription-colorAttachmentCount-00845",
2664 "Cannot create a render pass with %d color attachments. Max is %d.",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002665 pCreateInfo->pSubpasses[i].colorAttachmentCount, max_color_attachments);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002666 }
2667 }
2668 return skip;
2669}
2670
2671bool pv_vkFreeCommandBuffers(VkDevice device, VkCommandPool commandPool, uint32_t commandBufferCount,
2672 const VkCommandBuffer *pCommandBuffers) {
2673 bool skip = false;
2674 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2675 debug_report_data *report_data = device_data->report_data;
2676
2677 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
2678 // This is an array of handles, where the elements are allowed to be VK_NULL_HANDLE, and does not require any validation beyond
2679 // validate_array()
2680 skip |= validate_array(report_data, "vkFreeCommandBuffers", "commandBufferCount", "pCommandBuffers", commandBufferCount,
Dave Houlton413a6782018-05-22 13:01:54 -06002681 &pCommandBuffers, true, true, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002682 return skip;
2683}
2684
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002685bool pv_vkBeginCommandBuffer(VkCommandBuffer commandBuffer, const VkCommandBufferBeginInfo *pBeginInfo) {
2686 bool skip = false;
2687 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2688 debug_report_data *report_data = device_data->report_data;
2689 const VkCommandBufferInheritanceInfo *pInfo = pBeginInfo->pInheritanceInfo;
2690
2691 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
2692 // TODO: pBeginInfo->pInheritanceInfo must not be NULL if commandBuffer is a secondary command buffer
2693 skip |= validate_struct_type(report_data, "vkBeginCommandBuffer", "pBeginInfo->pInheritanceInfo",
2694 "VK_STRUCTURE_TYPE_COMMAND_BUFFER_INHERITANCE_INFO", pBeginInfo->pInheritanceInfo,
Mark Lobodzinskia16ebc72018-06-15 14:47:39 -06002695 VK_STRUCTURE_TYPE_COMMAND_BUFFER_INHERITANCE_INFO, false,
2696 "VUID_vkBeginCommandBuffer-pBeginInfo-parameter", "VUID_VkCommandBufferBeginInfo-sType-sType");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002697
2698 if (pBeginInfo->pInheritanceInfo != NULL) {
Dave Houlton413a6782018-05-22 13:01:54 -06002699 skip |= validate_struct_pnext(report_data, "vkBeginCommandBuffer", "pBeginInfo->pInheritanceInfo->pNext", NULL,
2700 pBeginInfo->pInheritanceInfo->pNext, 0, NULL, GeneratedHeaderVersion,
2701 "VUID-VkCommandBufferBeginInfo-pNext-pNext");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002702
2703 skip |= validate_bool32(report_data, "vkBeginCommandBuffer", "pBeginInfo->pInheritanceInfo->occlusionQueryEnable",
2704 pBeginInfo->pInheritanceInfo->occlusionQueryEnable);
2705
2706 // TODO: This only needs to be validated when the inherited queries feature is enabled
2707 // skip |= validate_flags(report_data, "vkBeginCommandBuffer", "pBeginInfo->pInheritanceInfo->queryFlags",
2708 // "VkQueryControlFlagBits", AllVkQueryControlFlagBits, pBeginInfo->pInheritanceInfo->queryFlags, false);
2709
2710 // TODO: This must be 0 if the pipeline statistics queries feature is not enabled
2711 skip |= validate_flags(report_data, "vkBeginCommandBuffer", "pBeginInfo->pInheritanceInfo->pipelineStatistics",
2712 "VkQueryPipelineStatisticFlagBits", AllVkQueryPipelineStatisticFlagBits,
Dave Houlton413a6782018-05-22 13:01:54 -06002713 pBeginInfo->pInheritanceInfo->pipelineStatistics, false, false, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002714 }
2715
2716 if (pInfo != NULL) {
2717 if ((device_data->physical_device_features.inheritedQueries == VK_FALSE) && (pInfo->occlusionQueryEnable != VK_FALSE)) {
2718 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002719 HandleToUint64(commandBuffer), "VUID-VkCommandBufferInheritanceInfo-occlusionQueryEnable-00056",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002720 "Cannot set inherited occlusionQueryEnable in vkBeginCommandBuffer() when device does not support "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002721 "inheritedQueries.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002722 }
2723 if ((device_data->physical_device_features.inheritedQueries != VK_FALSE) && (pInfo->occlusionQueryEnable != VK_FALSE)) {
2724 skip |= validate_flags(device_data->report_data, "vkBeginCommandBuffer", "pBeginInfo->pInheritanceInfo->queryFlags",
2725 "VkQueryControlFlagBits", AllVkQueryControlFlagBits, pInfo->queryFlags, false, false,
Dave Houlton413a6782018-05-22 13:01:54 -06002726 "VUID-VkCommandBufferInheritanceInfo-queryFlags-00057");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002727 }
2728 }
2729
2730 return skip;
2731}
2732
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002733bool pv_vkCmdSetViewport(VkCommandBuffer commandBuffer, uint32_t firstViewport, uint32_t viewportCount,
2734 const VkViewport *pViewports) {
2735 bool skip = false;
2736 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2737
Petr Krausd55e77c2018-01-09 22:09:25 +01002738 if (!device_data->physical_device_features.multiViewport) {
2739 if (firstViewport != 0) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002740 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002741 HandleToUint64(commandBuffer), "VUID-vkCmdSetViewport-firstViewport-01224",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002742 "vkCmdSetViewport: The multiViewport feature is disabled, but firstViewport (=%" PRIu32 ") is not 0.",
2743 firstViewport);
Petr Krausd55e77c2018-01-09 22:09:25 +01002744 }
2745 if (viewportCount > 1) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002746 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002747 HandleToUint64(commandBuffer), "VUID-vkCmdSetViewport-viewportCount-01225",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002748 "vkCmdSetViewport: The multiViewport feature is disabled, but viewportCount (=%" PRIu32 ") is not 1.",
2749 viewportCount);
Petr Krausd55e77c2018-01-09 22:09:25 +01002750 }
2751 } else { // multiViewport enabled
Petr Kraus7dfeed12018-02-27 20:51:20 +01002752 const uint64_t sum = static_cast<uint64_t>(firstViewport) + static_cast<uint64_t>(viewportCount);
Petr Krausd55e77c2018-01-09 22:09:25 +01002753 if (sum > device_data->device_limits.maxViewports) {
2754 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002755 HandleToUint64(commandBuffer), "VUID-vkCmdSetViewport-firstViewport-01223",
Petr Krausd55e77c2018-01-09 22:09:25 +01002756 "vkCmdSetViewport: firstViewport + viewportCount (=%" PRIu32 " + %" PRIu32 " = %" PRIu64
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002757 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
2758 firstViewport, viewportCount, sum, device_data->device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002759 }
2760 }
Petr Krausb3fcdb42018-01-09 22:09:09 +01002761
2762 if (pViewports) {
2763 for (uint32_t viewport_i = 0; viewport_i < viewportCount; ++viewport_i) {
2764 const auto &viewport = pViewports[viewport_i]; // will crash on invalid ptr
2765 const char fn_name[] = "vkCmdSetViewport";
2766 const std::string param_name = "pViewports[" + std::to_string(viewport_i) + "]";
2767 skip |= pv_VkViewport(device_data, viewport, fn_name, param_name.c_str(),
2768 VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, HandleToUint64(commandBuffer));
2769 }
2770 }
2771
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002772 return skip;
2773}
2774
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002775bool pv_vkCmdSetScissor(VkCommandBuffer commandBuffer, uint32_t firstScissor, uint32_t scissorCount, const VkRect2D *pScissors) {
2776 bool skip = false;
2777 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2778 debug_report_data *report_data = device_data->report_data;
2779
Petr Kraus6260f0a2018-02-27 21:15:55 +01002780 if (!device_data->physical_device_features.multiViewport) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002781 if (firstScissor != 0) {
Petr Kraus6260f0a2018-02-27 21:15:55 +01002782 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002783 HandleToUint64(commandBuffer), "VUID-vkCmdSetScissor-firstScissor-00593",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002784 "vkCmdSetScissor: The multiViewport feature is disabled, but firstScissor (=%" PRIu32 ") is not 0.",
2785 firstScissor);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002786 }
2787 if (scissorCount > 1) {
2788 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002789 HandleToUint64(commandBuffer), "VUID-vkCmdSetScissor-scissorCount-00594",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002790 "vkCmdSetScissor: The multiViewport feature is disabled, but scissorCount (=%" PRIu32 ") is not 1.",
2791 scissorCount);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002792 }
2793 } else { // multiViewport enabled
2794 const uint64_t sum = static_cast<uint64_t>(firstScissor) + static_cast<uint64_t>(scissorCount);
2795 if (sum > device_data->device_limits.maxViewports) {
2796 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002797 HandleToUint64(commandBuffer), "VUID-vkCmdSetScissor-firstScissor-00592",
Petr Kraus6260f0a2018-02-27 21:15:55 +01002798 "vkCmdSetScissor: firstScissor + scissorCount (=%" PRIu32 " + %" PRIu32 " = %" PRIu64
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002799 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
2800 firstScissor, scissorCount, sum, device_data->device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002801 }
2802 }
2803
Petr Kraus6260f0a2018-02-27 21:15:55 +01002804 if (pScissors) {
2805 for (uint32_t scissor_i = 0; scissor_i < scissorCount; ++scissor_i) {
2806 const auto &scissor = pScissors[scissor_i]; // will crash on invalid ptr
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002807
Petr Kraus6260f0a2018-02-27 21:15:55 +01002808 if (scissor.offset.x < 0) {
2809 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002810 HandleToUint64(commandBuffer), "VUID-vkCmdSetScissor-x-00595",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002811 "vkCmdSetScissor: pScissors[%" PRIu32 "].offset.x (=%" PRIi32 ") is negative.", scissor_i,
2812 scissor.offset.x);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002813 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002814
Petr Kraus6260f0a2018-02-27 21:15:55 +01002815 if (scissor.offset.y < 0) {
2816 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002817 HandleToUint64(commandBuffer), "VUID-vkCmdSetScissor-x-00595",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002818 "vkCmdSetScissor: pScissors[%" PRIu32 "].offset.y (=%" PRIi32 ") is negative.", scissor_i,
2819 scissor.offset.y);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002820 }
2821
2822 const int64_t x_sum = static_cast<int64_t>(scissor.offset.x) + static_cast<int64_t>(scissor.extent.width);
2823 if (x_sum > INT32_MAX) {
2824 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002825 HandleToUint64(commandBuffer), "VUID-vkCmdSetScissor-offset-00596",
Petr Kraus6260f0a2018-02-27 21:15:55 +01002826 "vkCmdSetScissor: offset.x + extent.width (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002827 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
2828 scissor.offset.x, scissor.extent.width, x_sum, scissor_i);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002829 }
2830
2831 const int64_t y_sum = static_cast<int64_t>(scissor.offset.y) + static_cast<int64_t>(scissor.extent.height);
2832 if (y_sum > INT32_MAX) {
2833 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002834 HandleToUint64(commandBuffer), "VUID-vkCmdSetScissor-offset-00597",
Petr Kraus6260f0a2018-02-27 21:15:55 +01002835 "vkCmdSetScissor: offset.y + extent.height (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002836 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
2837 scissor.offset.y, scissor.extent.height, y_sum, scissor_i);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002838 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002839 }
2840 }
Petr Kraus6260f0a2018-02-27 21:15:55 +01002841
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002842 return skip;
2843}
2844
Petr Kraus299ba622017-11-24 03:09:03 +01002845bool pv_vkCmdSetLineWidth(VkCommandBuffer commandBuffer, float lineWidth) {
2846 bool skip = false;
2847 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2848 debug_report_data *report_data = device_data->report_data;
2849
2850 if (!device_data->physical_device_features.wideLines && (lineWidth != 1.0f)) {
2851 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002852 HandleToUint64(commandBuffer), "VUID-vkCmdSetLineWidth-lineWidth-00788",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002853 "VkPhysicalDeviceFeatures::wideLines is disabled, but lineWidth (=%f) is not 1.0.", lineWidth);
Petr Kraus299ba622017-11-24 03:09:03 +01002854 }
2855
2856 return skip;
2857}
2858
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002859bool pv_vkCmdDraw(VkCommandBuffer commandBuffer, uint32_t vertexCount, uint32_t instanceCount, uint32_t firstVertex,
2860 uint32_t firstInstance) {
2861 bool skip = false;
2862 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2863 if (vertexCount == 0) {
2864 // TODO: Verify against Valid Usage section. I don't see a non-zero vertexCount listed, may need to add that and make
2865 // this an error or leave as is.
2866 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002867 kVUID_PVError_RequiredParameter, "vkCmdDraw parameter, uint32_t vertexCount, is 0");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002868 }
2869
2870 if (instanceCount == 0) {
2871 // TODO: Verify against Valid Usage section. I don't see a non-zero instanceCount listed, may need to add that and make
2872 // this an error or leave as is.
2873 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002874 kVUID_PVError_RequiredParameter, "vkCmdDraw parameter, uint32_t instanceCount, is 0");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002875 }
2876 return skip;
2877}
2878
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002879bool pv_vkCmdDrawIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, uint32_t count, uint32_t stride) {
2880 bool skip = false;
2881 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2882
2883 if (!device_data->physical_device_features.multiDrawIndirect && ((count > 1))) {
2884 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002885 kVUID_PVError_DeviceFeature,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002886 "CmdDrawIndirect(): Device feature multiDrawIndirect disabled: count must be 0 or 1 but is %d", count);
2887 }
2888 return skip;
2889}
2890
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002891bool pv_vkCmdDrawIndexedIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, uint32_t count,
2892 uint32_t stride) {
2893 bool skip = false;
2894 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2895 if (!device_data->physical_device_features.multiDrawIndirect && ((count > 1))) {
Dave Houlton413a6782018-05-22 13:01:54 -06002896 skip |=
2897 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
2898 kVUID_PVError_DeviceFeature,
2899 "CmdDrawIndexedIndirect(): Device feature multiDrawIndirect disabled: count must be 0 or 1 but is %d", count);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002900 }
2901 return skip;
2902}
2903
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002904bool pv_vkCmdCopyImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkImage dstImage,
2905 VkImageLayout dstImageLayout, uint32_t regionCount, const VkImageCopy *pRegions) {
2906 bool skip = false;
2907 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2908
Dave Houltonf5217612018-02-02 16:18:52 -07002909 VkImageAspectFlags legal_aspect_flags =
2910 VK_IMAGE_ASPECT_COLOR_BIT | VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT | VK_IMAGE_ASPECT_METADATA_BIT;
2911 if (device_data->extensions.vk_khr_sampler_ycbcr_conversion) {
2912 legal_aspect_flags |= (VK_IMAGE_ASPECT_PLANE_0_BIT_KHR | VK_IMAGE_ASPECT_PLANE_1_BIT_KHR | VK_IMAGE_ASPECT_PLANE_2_BIT_KHR);
2913 }
2914
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002915 if (pRegions != nullptr) {
Dave Houltonf5217612018-02-02 16:18:52 -07002916 if ((pRegions->srcSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002917 skip |= log_msg(
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002918 device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002919 "VUID-VkImageSubresourceLayers-aspectMask-parameter",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002920 "vkCmdCopyImage() parameter, VkImageAspect pRegions->srcSubresource.aspectMask, is an unrecognized enumerator.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002921 }
Dave Houltonf5217612018-02-02 16:18:52 -07002922 if ((pRegions->dstSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002923 skip |= log_msg(
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002924 device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002925 "VUID-VkImageSubresourceLayers-aspectMask-parameter",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002926 "vkCmdCopyImage() parameter, VkImageAspect pRegions->dstSubresource.aspectMask, is an unrecognized enumerator.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002927 }
2928 }
2929 return skip;
2930}
2931
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002932bool pv_vkCmdBlitImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkImage dstImage,
2933 VkImageLayout dstImageLayout, uint32_t regionCount, const VkImageBlit *pRegions, VkFilter filter) {
2934 bool skip = false;
2935 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2936
Dave Houltonf5217612018-02-02 16:18:52 -07002937 VkImageAspectFlags legal_aspect_flags =
2938 VK_IMAGE_ASPECT_COLOR_BIT | VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT | VK_IMAGE_ASPECT_METADATA_BIT;
2939 if (device_data->extensions.vk_khr_sampler_ycbcr_conversion) {
2940 legal_aspect_flags |= (VK_IMAGE_ASPECT_PLANE_0_BIT_KHR | VK_IMAGE_ASPECT_PLANE_1_BIT_KHR | VK_IMAGE_ASPECT_PLANE_2_BIT_KHR);
2941 }
2942
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002943 if (pRegions != nullptr) {
Dave Houltonf5217612018-02-02 16:18:52 -07002944 if ((pRegions->srcSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002945 skip |= log_msg(
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002946 device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002947 kVUID_PVError_UnrecognizedValue,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002948 "vkCmdBlitImage() parameter, VkImageAspect pRegions->srcSubresource.aspectMask, is an unrecognized enumerator");
2949 }
Dave Houltonf5217612018-02-02 16:18:52 -07002950 if ((pRegions->dstSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002951 skip |= log_msg(
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002952 device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002953 kVUID_PVError_UnrecognizedValue,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002954 "vkCmdBlitImage() parameter, VkImageAspect pRegions->dstSubresource.aspectMask, is an unrecognized enumerator");
2955 }
2956 }
2957 return skip;
2958}
2959
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002960bool pv_vkCmdCopyBufferToImage(VkCommandBuffer commandBuffer, VkBuffer srcBuffer, VkImage dstImage, VkImageLayout dstImageLayout,
2961 uint32_t regionCount, const VkBufferImageCopy *pRegions) {
2962 bool skip = false;
2963 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2964
Dave Houltonf5217612018-02-02 16:18:52 -07002965 VkImageAspectFlags legal_aspect_flags =
2966 VK_IMAGE_ASPECT_COLOR_BIT | VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT | VK_IMAGE_ASPECT_METADATA_BIT;
2967 if (device_data->extensions.vk_khr_sampler_ycbcr_conversion) {
2968 legal_aspect_flags |= (VK_IMAGE_ASPECT_PLANE_0_BIT_KHR | VK_IMAGE_ASPECT_PLANE_1_BIT_KHR | VK_IMAGE_ASPECT_PLANE_2_BIT_KHR);
2969 }
2970
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002971 if (pRegions != nullptr) {
Dave Houltonf5217612018-02-02 16:18:52 -07002972 if ((pRegions->imageSubresource.aspectMask & legal_aspect_flags) == 0) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07002973 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002974 kVUID_PVError_UnrecognizedValue,
Dave Houltona9df0ce2018-02-07 10:51:23 -07002975 "vkCmdCopyBufferToImage() parameter, VkImageAspect pRegions->imageSubresource.aspectMask, is an "
2976 "unrecognized enumerator");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002977 }
2978 }
2979 return skip;
2980}
2981
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002982bool pv_vkCmdCopyImageToBuffer(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkBuffer dstBuffer,
2983 uint32_t regionCount, const VkBufferImageCopy *pRegions) {
2984 bool skip = false;
2985 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2986
Dave Houltonf5217612018-02-02 16:18:52 -07002987 VkImageAspectFlags legal_aspect_flags =
2988 VK_IMAGE_ASPECT_COLOR_BIT | VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT | VK_IMAGE_ASPECT_METADATA_BIT;
2989 if (device_data->extensions.vk_khr_sampler_ycbcr_conversion) {
2990 legal_aspect_flags |= (VK_IMAGE_ASPECT_PLANE_0_BIT_KHR | VK_IMAGE_ASPECT_PLANE_1_BIT_KHR | VK_IMAGE_ASPECT_PLANE_2_BIT_KHR);
2991 }
2992
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002993 if (pRegions != nullptr) {
Dave Houltonf5217612018-02-02 16:18:52 -07002994 if ((pRegions->imageSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002995 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002996 kVUID_PVError_UnrecognizedValue,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002997 "vkCmdCopyImageToBuffer parameter, VkImageAspect pRegions->imageSubresource.aspectMask, is an unrecognized "
2998 "enumerator");
2999 }
3000 }
3001 return skip;
3002}
3003
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003004bool pv_vkCmdUpdateBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer, VkDeviceSize dstOffset, VkDeviceSize dataSize,
3005 const void *pData) {
3006 bool skip = false;
3007 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3008
3009 if (dstOffset & 3) {
3010 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003011 "VUID-vkCmdUpdateBuffer-dstOffset-00036",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003012 "vkCmdUpdateBuffer() parameter, VkDeviceSize dstOffset (0x%" PRIxLEAST64 "), is not a multiple of 4.",
3013 dstOffset);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003014 }
3015
3016 if ((dataSize <= 0) || (dataSize > 65536)) {
3017 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003018 "VUID-vkCmdUpdateBuffer-dataSize-00037",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003019 "vkCmdUpdateBuffer() parameter, VkDeviceSize dataSize (0x%" PRIxLEAST64
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003020 "), must be greater than zero and less than or equal to 65536.",
3021 dataSize);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003022 } else if (dataSize & 3) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003023 skip |=
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06003024 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003025 "VUID-vkCmdUpdateBuffer-dataSize-00038",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003026 "vkCmdUpdateBuffer() parameter, VkDeviceSize dataSize (0x%" PRIxLEAST64 "), is not a multiple of 4.", dataSize);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003027 }
3028 return skip;
3029}
3030
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003031bool pv_vkCmdFillBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer, VkDeviceSize dstOffset, VkDeviceSize size,
3032 uint32_t data) {
3033 bool skip = false;
3034 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3035
3036 if (dstOffset & 3) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003037 skip |=
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06003038 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003039 "VUID-vkCmdFillBuffer-dstOffset-00025",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003040 "vkCmdFillBuffer() parameter, VkDeviceSize dstOffset (0x%" PRIxLEAST64 "), is not a multiple of 4.", dstOffset);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003041 }
3042
3043 if (size != VK_WHOLE_SIZE) {
3044 if (size <= 0) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003045 skip |=
3046 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003047 "VUID-vkCmdFillBuffer-size-00026",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003048 "vkCmdFillBuffer() parameter, VkDeviceSize size (0x%" PRIxLEAST64 "), must be greater than zero.", size);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003049 } else if (size & 3) {
3050 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003051 "VUID-vkCmdFillBuffer-size-00028",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003052 "vkCmdFillBuffer() parameter, VkDeviceSize size (0x%" PRIxLEAST64 "), is not a multiple of 4.", size);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003053 }
3054 }
3055 return skip;
3056}
3057
3058VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateInstanceLayerProperties(uint32_t *pCount, VkLayerProperties *pProperties) {
3059 return util_GetLayerProperties(1, &global_layer, pCount, pProperties);
3060}
3061
3062VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateDeviceLayerProperties(VkPhysicalDevice physicalDevice, uint32_t *pCount,
3063 VkLayerProperties *pProperties) {
3064 return util_GetLayerProperties(1, &global_layer, pCount, pProperties);
3065}
3066
3067VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateInstanceExtensionProperties(const char *pLayerName, uint32_t *pCount,
3068 VkExtensionProperties *pProperties) {
3069 if (pLayerName && !strcmp(pLayerName, global_layer.layerName))
3070 return util_GetExtensionProperties(1, instance_extensions, pCount, pProperties);
3071
3072 return VK_ERROR_LAYER_NOT_PRESENT;
3073}
3074
3075VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateDeviceExtensionProperties(VkPhysicalDevice physicalDevice, const char *pLayerName,
3076 uint32_t *pPropertyCount, VkExtensionProperties *pProperties) {
3077 // Parameter_validation does not have any physical device extensions
3078 if (pLayerName && !strcmp(pLayerName, global_layer.layerName))
3079 return util_GetExtensionProperties(0, NULL, pPropertyCount, pProperties);
3080
3081 instance_layer_data *local_data = GetLayerDataPtr(get_dispatch_key(physicalDevice), instance_layer_data_map);
Dave Houlton413a6782018-05-22 13:01:54 -06003082 bool skip = validate_array(local_data->report_data, "vkEnumerateDeviceExtensionProperties", "pPropertyCount", "pProperties",
3083 pPropertyCount, &pProperties, true, false, false, kVUIDUndefined,
3084 "VUID-vkEnumerateDeviceExtensionProperties-pProperties-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003085 if (skip) return VK_ERROR_VALIDATION_FAILED_EXT;
3086
3087 return local_data->dispatch_table.EnumerateDeviceExtensionProperties(physicalDevice, NULL, pPropertyCount, pProperties);
3088}
3089
3090static bool require_device_extension(layer_data *device_data, bool flag, char const *function_name, char const *extension_name) {
3091 if (!flag) {
3092 return log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003093 kVUID_PVError_ExtensionNotEnabled,
3094 "%s() called even though the %s extension was not enabled for this VkDevice.", function_name,
3095 extension_name);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003096 }
3097
3098 return false;
3099}
3100
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003101bool pv_vkCreateSwapchainKHR(VkDevice device, const VkSwapchainCreateInfoKHR *pCreateInfo, const VkAllocationCallbacks *pAllocator,
3102 VkSwapchainKHR *pSwapchain) {
3103 bool skip = false;
3104 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
3105 debug_report_data *report_data = device_data->report_data;
3106
Mark Lobodzinski88529492018-04-01 10:38:15 -06003107 const LogMiscParams log_misc{report_data, VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT, VK_NULL_HANDLE,
Petr Krause5c37652018-01-05 04:05:12 +01003108 "vkCreateSwapchainKHR"};
3109
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003110 if (pCreateInfo != nullptr) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003111 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
3112 if (pCreateInfo->imageSharingMode == VK_SHARING_MODE_CONCURRENT) {
3113 // If imageSharingMode is VK_SHARING_MODE_CONCURRENT, queueFamilyIndexCount must be greater than 1
3114 if (pCreateInfo->queueFamilyIndexCount <= 1) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06003115 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003116 "VUID-VkSwapchainCreateInfoKHR-imageSharingMode-01278",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003117 "vkCreateSwapchainKHR(): if pCreateInfo->imageSharingMode is VK_SHARING_MODE_CONCURRENT, "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003118 "pCreateInfo->queueFamilyIndexCount must be greater than 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003119 }
3120
3121 // If imageSharingMode is VK_SHARING_MODE_CONCURRENT, pQueueFamilyIndices must be a pointer to an array of
3122 // queueFamilyIndexCount uint32_t values
3123 if (pCreateInfo->pQueueFamilyIndices == nullptr) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06003124 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003125 "VUID-VkSwapchainCreateInfoKHR-imageSharingMode-01277",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003126 "vkCreateSwapchainKHR(): if pCreateInfo->imageSharingMode is VK_SHARING_MODE_CONCURRENT, "
3127 "pCreateInfo->pQueueFamilyIndices must be a pointer to an array of "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003128 "pCreateInfo->queueFamilyIndexCount uint32_t values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003129 } else {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003130 skip |= ValidateQueueFamilies(device_data, pCreateInfo->queueFamilyIndexCount, pCreateInfo->pQueueFamilyIndices,
Dave Houlton413a6782018-05-22 13:01:54 -06003131 "vkCreateSwapchainKHR", "pCreateInfo->pQueueFamilyIndices",
3132 kVUID_PVError_InvalidUsage, kVUID_PVError_InvalidUsage, false);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003133 }
3134 }
3135
Dave Houlton413a6782018-05-22 13:01:54 -06003136 skip |= ValidateGreaterThanZero(pCreateInfo->imageArrayLayers, "pCreateInfo->imageArrayLayers",
3137 "VUID-VkSwapchainCreateInfoKHR-imageArrayLayers-01275", log_misc);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003138 }
3139
3140 return skip;
3141}
3142
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003143bool pv_vkQueuePresentKHR(VkQueue queue, const VkPresentInfoKHR *pPresentInfo) {
3144 bool skip = false;
3145 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(queue), layer_data_map);
3146
3147 if (pPresentInfo && pPresentInfo->pNext) {
John Zulaufde972ac2017-10-26 12:07:05 -06003148 const auto *present_regions = lvl_find_in_chain<VkPresentRegionsKHR>(pPresentInfo->pNext);
3149 if (present_regions) {
3150 // TODO: This and all other pNext extension dependencies should be added to code-generation
3151 skip |= require_device_extension(device_data, device_data->extensions.vk_khr_incremental_present, "vkQueuePresentKHR",
3152 VK_KHR_INCREMENTAL_PRESENT_EXTENSION_NAME);
3153 if (present_regions->swapchainCount != pPresentInfo->swapchainCount) {
3154 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003155 kVUID_PVError_InvalidUsage,
Dave Houltona9df0ce2018-02-07 10:51:23 -07003156 "QueuePresentKHR(): pPresentInfo->swapchainCount has a value of %i but VkPresentRegionsKHR "
3157 "extension swapchainCount is %i. These values must be equal.",
John Zulaufde972ac2017-10-26 12:07:05 -06003158 pPresentInfo->swapchainCount, present_regions->swapchainCount);
3159 }
Dave Houlton413a6782018-05-22 13:01:54 -06003160 skip |=
3161 validate_struct_pnext(device_data->report_data, "QueuePresentKHR", "pCreateInfo->pNext->pNext", NULL,
3162 present_regions->pNext, 0, NULL, GeneratedHeaderVersion, "VUID-VkPresentInfoKHR-pNext-pNext");
John Zulaufde972ac2017-10-26 12:07:05 -06003163 skip |= validate_array(device_data->report_data, "QueuePresentKHR", "pCreateInfo->pNext->swapchainCount",
Gabríel Arthúr Pétursson092b29b2018-03-21 22:44:11 +00003164 "pCreateInfo->pNext->pRegions", present_regions->swapchainCount, &present_regions->pRegions,
Dave Houlton413a6782018-05-22 13:01:54 -06003165 true, false, kVUIDUndefined, kVUIDUndefined);
John Zulaufde972ac2017-10-26 12:07:05 -06003166 for (uint32_t i = 0; i < present_regions->swapchainCount; ++i) {
3167 skip |= validate_array(device_data->report_data, "QueuePresentKHR", "pCreateInfo->pNext->pRegions[].rectangleCount",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003168 "pCreateInfo->pNext->pRegions[].pRectangles", present_regions->pRegions[i].rectangleCount,
Dave Houlton413a6782018-05-22 13:01:54 -06003169 &present_regions->pRegions[i].pRectangles, true, false, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003170 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003171 }
3172 }
3173
3174 return skip;
3175}
3176
3177#ifdef VK_USE_PLATFORM_WIN32_KHR
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003178bool pv_vkCreateWin32SurfaceKHR(VkInstance instance, const VkWin32SurfaceCreateInfoKHR *pCreateInfo,
3179 const VkAllocationCallbacks *pAllocator, VkSurfaceKHR *pSurface) {
3180 auto device_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map);
3181 bool skip = false;
3182
3183 if (pCreateInfo->hwnd == nullptr) {
3184 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003185 "VUID-VkWin32SurfaceCreateInfoKHR-hwnd-01308",
3186 "vkCreateWin32SurfaceKHR(): hwnd must be a valid Win32 HWND but hwnd is NULL.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003187 }
3188
3189 return skip;
3190}
3191#endif // VK_USE_PLATFORM_WIN32_KHR
3192
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003193bool pv_vkDebugMarkerSetObjectNameEXT(VkDevice device, const VkDebugMarkerObjectNameInfoEXT *pNameInfo) {
3194 auto device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
3195 if (pNameInfo->pObjectName) {
3196 device_data->report_data->debugObjectNameMap->insert(
3197 std::make_pair<uint64_t, std::string>((uint64_t &&) pNameInfo->object, pNameInfo->pObjectName));
3198 } else {
3199 device_data->report_data->debugObjectNameMap->erase(pNameInfo->object);
3200 }
3201 return false;
3202}
3203
Petr Krausc8655be2017-09-27 18:56:51 +02003204bool pv_vkCreateDescriptorPool(VkDevice device, const VkDescriptorPoolCreateInfo *pCreateInfo,
3205 const VkAllocationCallbacks *pAllocator, VkDescriptorPool *pDescriptorPool) {
3206 auto device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
3207 bool skip = false;
3208
3209 if (pCreateInfo) {
3210 if (pCreateInfo->maxSets <= 0) {
Dave Houlton413a6782018-05-22 13:01:54 -06003211 skip |=
3212 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT,
3213 VK_NULL_HANDLE, "VUID-VkDescriptorPoolCreateInfo-maxSets-00301",
3214 "vkCreateDescriptorPool(): pCreateInfo->maxSets is not greater than 0.");
Petr Krausc8655be2017-09-27 18:56:51 +02003215 }
3216
3217 if (pCreateInfo->pPoolSizes) {
3218 for (uint32_t i = 0; i < pCreateInfo->poolSizeCount; ++i) {
3219 if (pCreateInfo->pPoolSizes[i].descriptorCount <= 0) {
3220 skip |= log_msg(
3221 device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003222 VK_NULL_HANDLE, "VUID-VkDescriptorPoolSize-descriptorCount-00302",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003223 "vkCreateDescriptorPool(): pCreateInfo->pPoolSizes[%" PRIu32 "].descriptorCount is not greater than 0.", i);
Petr Krausc8655be2017-09-27 18:56:51 +02003224 }
Jeff Bolze54ae892018-09-08 12:16:29 -05003225 if (pCreateInfo->pPoolSizes[i].type == VK_DESCRIPTOR_TYPE_INLINE_UNIFORM_BLOCK_EXT &&
3226 (pCreateInfo->pPoolSizes[i].descriptorCount % 4) != 0) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06003227 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT,
3228 VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, VK_NULL_HANDLE,
3229 "VUID-VkDescriptorPoolSize-type-02218",
3230 "vkCreateDescriptorPool(): pCreateInfo->pPoolSizes[%" PRIu32
3231 "].type is VK_DESCRIPTOR_TYPE_INLINE_UNIFORM_BLOCK_EXT "
3232 " and pCreateInfo->pPoolSizes[%" PRIu32 "].descriptorCount is not a multiple of 4.",
3233 i, i);
Jeff Bolze54ae892018-09-08 12:16:29 -05003234 }
Petr Krausc8655be2017-09-27 18:56:51 +02003235 }
3236 }
3237 }
3238
3239 return skip;
3240}
3241
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003242bool pv_vkCmdDispatch(VkCommandBuffer commandBuffer, uint32_t groupCountX, uint32_t groupCountY, uint32_t groupCountZ) {
3243 bool skip = false;
3244 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3245
3246 if (groupCountX > device_data->device_limits.maxComputeWorkGroupCount[0]) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003247 skip |=
3248 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003249 HandleToUint64(commandBuffer), "VUID-vkCmdDispatch-groupCountX-00386",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003250 "vkCmdDispatch(): groupCountX (%" PRIu32 ") exceeds device limit maxComputeWorkGroupCount[0] (%" PRIu32 ").",
3251 groupCountX, device_data->device_limits.maxComputeWorkGroupCount[0]);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003252 }
3253
3254 if (groupCountY > device_data->device_limits.maxComputeWorkGroupCount[1]) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003255 skip |=
3256 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003257 HandleToUint64(commandBuffer), "VUID-vkCmdDispatch-groupCountY-00387",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003258 "vkCmdDispatch(): groupCountY (%" PRIu32 ") exceeds device limit maxComputeWorkGroupCount[1] (%" PRIu32 ").",
3259 groupCountY, device_data->device_limits.maxComputeWorkGroupCount[1]);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003260 }
3261
3262 if (groupCountZ > device_data->device_limits.maxComputeWorkGroupCount[2]) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003263 skip |=
3264 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003265 HandleToUint64(commandBuffer), "VUID-vkCmdDispatch-groupCountZ-00388",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003266 "vkCmdDispatch(): groupCountZ (%" PRIu32 ") exceeds device limit maxComputeWorkGroupCount[2] (%" PRIu32 ").",
3267 groupCountZ, device_data->device_limits.maxComputeWorkGroupCount[2]);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003268 }
3269
3270 return skip;
3271}
3272
Mark Lobodzinskibf973a12018-03-01 08:50:21 -07003273bool pv_vkCmdDispatchBaseKHR(VkCommandBuffer commandBuffer, uint32_t baseGroupX, uint32_t baseGroupY, uint32_t baseGroupZ,
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003274 uint32_t groupCountX, uint32_t groupCountY, uint32_t groupCountZ) {
3275 bool skip = false;
3276 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3277
3278 // Paired if {} else if {} tests used to avoid any possible uint underflow
3279 uint32_t limit = device_data->device_limits.maxComputeWorkGroupCount[0];
3280 if (baseGroupX >= limit) {
3281 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003282 HandleToUint64(commandBuffer), "VUID-vkCmdDispatchBase-baseGroupX-00421",
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003283 "vkCmdDispatch(): baseGroupX (%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003284 ") equals or exceeds device limit maxComputeWorkGroupCount[0] (%" PRIu32 ").",
3285 baseGroupX, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003286 } else if (groupCountX > (limit - baseGroupX)) {
3287 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003288 HandleToUint64(commandBuffer), "VUID-vkCmdDispatchBase-groupCountX-00424",
Mark Lobodzinskibf973a12018-03-01 08:50:21 -07003289 "vkCmdDispatchBaseKHR(): baseGroupX (%" PRIu32 ") + groupCountX (%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003290 ") exceeds device limit maxComputeWorkGroupCount[0] (%" PRIu32 ").",
3291 baseGroupX, groupCountX, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003292 }
3293
3294 limit = device_data->device_limits.maxComputeWorkGroupCount[1];
3295 if (baseGroupY >= limit) {
3296 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003297 HandleToUint64(commandBuffer), "VUID-vkCmdDispatchBase-baseGroupX-00422",
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003298 "vkCmdDispatch(): baseGroupY (%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003299 ") equals or exceeds device limit maxComputeWorkGroupCount[1] (%" PRIu32 ").",
3300 baseGroupY, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003301 } else if (groupCountY > (limit - baseGroupY)) {
3302 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003303 HandleToUint64(commandBuffer), "VUID-vkCmdDispatchBase-groupCountY-00425",
Mark Lobodzinskibf973a12018-03-01 08:50:21 -07003304 "vkCmdDispatchBaseKHR(): baseGroupY (%" PRIu32 ") + groupCountY (%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003305 ") exceeds device limit maxComputeWorkGroupCount[1] (%" PRIu32 ").",
3306 baseGroupY, groupCountY, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003307 }
3308
3309 limit = device_data->device_limits.maxComputeWorkGroupCount[2];
3310 if (baseGroupZ >= limit) {
3311 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003312 HandleToUint64(commandBuffer), "VUID-vkCmdDispatchBase-baseGroupZ-00423",
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003313 "vkCmdDispatch(): baseGroupZ (%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003314 ") equals or exceeds device limit maxComputeWorkGroupCount[2] (%" PRIu32 ").",
3315 baseGroupZ, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003316 } else if (groupCountZ > (limit - baseGroupZ)) {
3317 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003318 HandleToUint64(commandBuffer), "VUID-vkCmdDispatchBase-groupCountZ-00426",
Mark Lobodzinskibf973a12018-03-01 08:50:21 -07003319 "vkCmdDispatchBaseKHR(): baseGroupZ (%" PRIu32 ") + groupCountZ (%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003320 ") exceeds device limit maxComputeWorkGroupCount[2] (%" PRIu32 ").",
3321 baseGroupZ, groupCountZ, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003322 }
3323
3324 return skip;
3325}
3326
Dave Houlton142c4cb2018-10-17 15:04:41 -06003327bool pv_vkCmdSetExclusiveScissorNV(VkCommandBuffer commandBuffer, uint32_t firstExclusiveScissor, uint32_t exclusiveScissorCount,
3328 const VkRect2D *pExclusiveScissors) {
Jeff Bolz3e71f782018-08-29 23:15:45 -05003329 bool skip = false;
3330
3331 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3332 debug_report_data *report_data = device_data->report_data;
3333
3334 if (!device_data->physical_device_features.multiViewport) {
3335 if (firstExclusiveScissor != 0) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06003336 skip |=
3337 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3338 HandleToUint64(commandBuffer), "VUID-vkCmdSetExclusiveScissorNV-firstExclusiveScissor-02035",
3339 "vkCmdSetExclusiveScissorNV: The multiViewport feature is disabled, but firstExclusiveScissor (=%" PRIu32
3340 ") is not 0.",
3341 firstExclusiveScissor);
Jeff Bolz3e71f782018-08-29 23:15:45 -05003342 }
3343 if (exclusiveScissorCount > 1) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06003344 skip |=
3345 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3346 HandleToUint64(commandBuffer), "VUID-vkCmdSetExclusiveScissorNV-exclusiveScissorCount-02036",
3347 "vkCmdSetExclusiveScissorNV: The multiViewport feature is disabled, but exclusiveScissorCount (=%" PRIu32
3348 ") is not 1.",
3349 exclusiveScissorCount);
Jeff Bolz3e71f782018-08-29 23:15:45 -05003350 }
3351 } else { // multiViewport enabled
3352 const uint64_t sum = static_cast<uint64_t>(firstExclusiveScissor) + static_cast<uint64_t>(exclusiveScissorCount);
3353 if (sum > device_data->device_limits.maxViewports) {
3354 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3355 HandleToUint64(commandBuffer), "VUID-vkCmdSetExclusiveScissorNV-firstExclusiveScissor-02034",
Dave Houlton142c4cb2018-10-17 15:04:41 -06003356 "vkCmdSetExclusiveScissorNV: firstExclusiveScissor + exclusiveScissorCount (=%" PRIu32 " + %" PRIu32
3357 " = %" PRIu64 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
Jeff Bolz3e71f782018-08-29 23:15:45 -05003358 firstExclusiveScissor, exclusiveScissorCount, sum, device_data->device_limits.maxViewports);
3359 }
3360 }
3361
3362 if (firstExclusiveScissor >= device_data->device_limits.maxViewports) {
3363 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3364 HandleToUint64(commandBuffer), "VUID-vkCmdSetExclusiveScissorNV-firstExclusiveScissor-02033",
Dave Houlton142c4cb2018-10-17 15:04:41 -06003365 "vkCmdSetExclusiveScissorNV: firstExclusiveScissor (=%" PRIu32 ") must be less than maxViewports (=%" PRIu32
3366 ").",
Jeff Bolz3e71f782018-08-29 23:15:45 -05003367 firstExclusiveScissor, device_data->device_limits.maxViewports);
3368 }
3369
3370 if (pExclusiveScissors) {
3371 for (uint32_t scissor_i = 0; scissor_i < exclusiveScissorCount; ++scissor_i) {
3372 const auto &scissor = pExclusiveScissors[scissor_i]; // will crash on invalid ptr
3373
3374 if (scissor.offset.x < 0) {
3375 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3376 HandleToUint64(commandBuffer), "VUID-vkCmdSetExclusiveScissorNV-x-02037",
Dave Houlton142c4cb2018-10-17 15:04:41 -06003377 "vkCmdSetExclusiveScissorNV: pScissors[%" PRIu32 "].offset.x (=%" PRIi32 ") is negative.",
3378 scissor_i, scissor.offset.x);
Jeff Bolz3e71f782018-08-29 23:15:45 -05003379 }
3380
3381 if (scissor.offset.y < 0) {
3382 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3383 HandleToUint64(commandBuffer), "VUID-vkCmdSetExclusiveScissorNV-x-02037",
Dave Houlton142c4cb2018-10-17 15:04:41 -06003384 "vkCmdSetExclusiveScissorNV: pScissors[%" PRIu32 "].offset.y (=%" PRIi32 ") is negative.",
3385 scissor_i, scissor.offset.y);
Jeff Bolz3e71f782018-08-29 23:15:45 -05003386 }
3387
3388 const int64_t x_sum = static_cast<int64_t>(scissor.offset.x) + static_cast<int64_t>(scissor.extent.width);
3389 if (x_sum > INT32_MAX) {
3390 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3391 HandleToUint64(commandBuffer), "VUID-vkCmdSetExclusiveScissorNV-offset-02038",
3392 "vkCmdSetExclusiveScissorNV: offset.x + extent.width (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
3393 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
3394 scissor.offset.x, scissor.extent.width, x_sum, scissor_i);
3395 }
3396
3397 const int64_t y_sum = static_cast<int64_t>(scissor.offset.y) + static_cast<int64_t>(scissor.extent.height);
3398 if (y_sum > INT32_MAX) {
3399 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3400 HandleToUint64(commandBuffer), "VUID-vkCmdSetExclusiveScissorNV-offset-02039",
3401 "vkCmdSetExclusiveScissorNV: offset.y + extent.height (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
3402 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
3403 scissor.offset.y, scissor.extent.height, y_sum, scissor_i);
3404 }
3405 }
3406 }
3407
3408 return skip;
3409}
3410
Dave Houlton142c4cb2018-10-17 15:04:41 -06003411bool pv_vkCmdSetViewportShadingRatePaletteNV(VkCommandBuffer commandBuffer, uint32_t firstViewport, uint32_t viewportCount,
3412 const VkShadingRatePaletteNV *pShadingRatePalettes) {
Jeff Bolz9af91c52018-09-01 21:53:57 -05003413 bool skip = false;
3414
3415 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3416 debug_report_data *report_data = device_data->report_data;
3417
3418 if (!device_data->physical_device_features.multiViewport) {
3419 if (firstViewport != 0) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06003420 skip |=
3421 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3422 HandleToUint64(commandBuffer), "VUID-vkCmdSetViewportShadingRatePaletteNV-firstViewport-02068",
3423 "vkCmdSetViewportShadingRatePaletteNV: The multiViewport feature is disabled, but firstViewport (=%" PRIu32
3424 ") is not 0.",
3425 firstViewport);
Jeff Bolz9af91c52018-09-01 21:53:57 -05003426 }
3427 if (viewportCount > 1) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06003428 skip |=
3429 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3430 HandleToUint64(commandBuffer), "VUID-vkCmdSetViewportShadingRatePaletteNV-viewportCount-02069",
3431 "vkCmdSetViewportShadingRatePaletteNV: The multiViewport feature is disabled, but viewportCount (=%" PRIu32
3432 ") is not 1.",
3433 viewportCount);
Jeff Bolz9af91c52018-09-01 21:53:57 -05003434 }
3435 }
3436
3437 if (firstViewport >= device_data->device_limits.maxViewports) {
3438 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3439 HandleToUint64(commandBuffer), "VUID-vkCmdSetViewportShadingRatePaletteNV-firstViewport-02066",
Dave Houlton142c4cb2018-10-17 15:04:41 -06003440 "vkCmdSetViewportShadingRatePaletteNV: firstViewport (=%" PRIu32
3441 ") must be less than maxViewports (=%" PRIu32 ").",
Jeff Bolz9af91c52018-09-01 21:53:57 -05003442 firstViewport, device_data->device_limits.maxViewports);
3443 }
3444
3445 const uint64_t sum = static_cast<uint64_t>(firstViewport) + static_cast<uint64_t>(viewportCount);
3446 if (sum > device_data->device_limits.maxViewports) {
3447 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3448 HandleToUint64(commandBuffer), "VUID-vkCmdSetViewportShadingRatePaletteNV-firstViewport-02067",
3449 "vkCmdSetViewportShadingRatePaletteNV: firstViewport + viewportCount (=%" PRIu32 " + %" PRIu32 " = %" PRIu64
3450 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
3451 firstViewport, viewportCount, sum, device_data->device_limits.maxViewports);
3452 }
3453
3454 return skip;
3455}
3456
Dave Houlton142c4cb2018-10-17 15:04:41 -06003457bool pv_vkCmdSetCoarseSampleOrderNV(VkCommandBuffer commandBuffer, VkCoarseSampleOrderTypeNV sampleOrderType,
3458 uint32_t customSampleOrderCount, const VkCoarseSampleOrderCustomNV *pCustomSampleOrders) {
Jeff Bolz9af91c52018-09-01 21:53:57 -05003459 bool skip = false;
3460
3461 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3462 debug_report_data *report_data = device_data->report_data;
3463
Dave Houlton142c4cb2018-10-17 15:04:41 -06003464 if (sampleOrderType != VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV && customSampleOrderCount != 0) {
Jeff Bolz9af91c52018-09-01 21:53:57 -05003465 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3466 HandleToUint64(commandBuffer), "VUID-vkCmdSetCoarseSampleOrderNV-sampleOrderType-02081",
3467 "vkCmdSetCoarseSampleOrderNV: If sampleOrderType is not VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV, "
3468 "customSampleOrderCount must be 0.");
3469 }
3470
3471 for (uint32_t order_i = 0; order_i < customSampleOrderCount; ++order_i) {
3472 skip |= ValidateCoarseSampleOrderCustomNV(device_data, &pCustomSampleOrders[order_i]);
3473 }
3474
3475 return skip;
3476}
3477
Dave Houlton142c4cb2018-10-17 15:04:41 -06003478bool pv_vkCmdDrawMeshTasksNV(VkCommandBuffer commandBuffer, uint32_t taskCount, uint32_t firstTask) {
Jeff Bolz45bf7d62018-09-18 15:39:58 -05003479 bool skip = false;
3480
3481 layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3482
3483 if (taskCount > dev_data->phys_dev_ext_props.mesh_shader_props.maxDrawMeshTasksCount) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06003484 skip |= log_msg(
3485 dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3486 HandleToUint64(commandBuffer), "VUID-vkCmdDrawMeshTasksNV-taskCount-02119",
3487 "vkCmdDrawMeshTasksNV() parameter, uint32_t taskCount (0x%" PRIxLEAST32
3488 "), must be less than or equal to VkPhysicalDeviceMeshShaderPropertiesNV::maxDrawMeshTasksCount (0x%" PRIxLEAST32 ").",
3489 taskCount, dev_data->phys_dev_ext_props.mesh_shader_props.maxDrawMeshTasksCount);
Jeff Bolz45bf7d62018-09-18 15:39:58 -05003490 }
3491
3492 return skip;
3493}
3494
Dave Houlton142c4cb2018-10-17 15:04:41 -06003495bool pv_vkCmdDrawMeshTasksIndirectNV(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, uint32_t drawCount,
3496 uint32_t stride) {
Jeff Bolz45bf7d62018-09-18 15:39:58 -05003497 bool skip = false;
3498
3499 layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3500 debug_report_data *report_data = dev_data->report_data;
3501
3502 if (offset & 3) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06003503 skip |= log_msg(
3504 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3505 HandleToUint64(commandBuffer), "VUID-vkCmdDrawMeshTasksIndirectNV-offset-02145",
3506 "vkCmdDrawMeshTasksIndirectNV() parameter, VkDeviceSize offset (0x%" PRIxLEAST64 "), is not a multiple of 4.", offset);
Jeff Bolz45bf7d62018-09-18 15:39:58 -05003507 }
3508
3509 if (drawCount > 1 && ((stride & 3) || stride < sizeof(VkDrawMeshTasksIndirectCommandNV))) {
3510 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3511 HandleToUint64(commandBuffer), "VUID-vkCmdDrawMeshTasksIndirectNV-drawCount-02146",
3512 "vkCmdDrawMeshTasksIndirectNV() parameter, uint32_t stride (0x%" PRIxLEAST32
3513 "), is not a multiple of 4 or smaller than sizeof (VkDrawMeshTasksIndirectCommandNV).",
3514 stride);
3515 }
3516
3517 return skip;
3518}
3519
Dave Houlton142c4cb2018-10-17 15:04:41 -06003520bool pv_vkCmdDrawMeshTasksIndirectCountNV(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, VkBuffer countBuffer,
3521 VkDeviceSize countBufferOffset, uint32_t maxDrawCount, uint32_t stride) {
Jeff Bolz45bf7d62018-09-18 15:39:58 -05003522 bool skip = false;
3523
3524 layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3525
3526 if (offset & 3) {
3527 skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3528 HandleToUint64(commandBuffer), "VUID-vkCmdDrawMeshTasksIndirectCountNV-offset-02180",
3529 "vkCmdDrawMeshTasksIndirectCountNV() parameter, VkDeviceSize offset (0x%" PRIxLEAST64
3530 "), is not a multiple of 4.",
3531 offset);
3532 }
3533
3534 if (countBufferOffset & 3) {
3535 skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3536 HandleToUint64(commandBuffer), "VUID-vkCmdDrawMeshTasksIndirectCountNV-countBufferOffset-02181",
3537 "vkCmdDrawMeshTasksIndirectCountNV() parameter, VkDeviceSize countBufferOffset (0x%" PRIxLEAST64
3538 "), is not a multiple of 4.",
3539 countBufferOffset);
3540 }
3541
3542 if ((stride & 3) || stride < sizeof(VkDrawMeshTasksIndirectCommandNV)) {
3543 skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3544 HandleToUint64(commandBuffer), "VUID-vkCmdDrawMeshTasksIndirectCountNV-stride-02182",
3545 "vkCmdDrawMeshTasksIndirectCountNV() parameter, uint32_t stride (0x%" PRIxLEAST32
3546 "), is not a multiple of 4 or smaller than sizeof (VkDrawMeshTasksIndirectCommandNV).",
3547 stride);
3548 }
3549
3550 return skip;
3551}
3552
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003553VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetDeviceProcAddr(VkDevice device, const char *funcName) {
Mark Lobodzinskib7a26382018-07-02 13:14:26 -06003554 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
3555 if (!ApiParentExtensionEnabled(funcName, device_data->extensions.device_extension_set)) {
3556 return nullptr;
3557 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003558 const auto item = name_to_funcptr_map.find(funcName);
3559 if (item != name_to_funcptr_map.end()) {
3560 return reinterpret_cast<PFN_vkVoidFunction>(item->second);
3561 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003562 const auto &table = device_data->dispatch_table;
3563 if (!table.GetDeviceProcAddr) return nullptr;
3564 return table.GetDeviceProcAddr(device, funcName);
3565}
3566
3567VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetInstanceProcAddr(VkInstance instance, const char *funcName) {
3568 const auto item = name_to_funcptr_map.find(funcName);
3569 if (item != name_to_funcptr_map.end()) {
3570 return reinterpret_cast<PFN_vkVoidFunction>(item->second);
3571 }
3572
3573 auto instance_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map);
3574 auto &table = instance_data->dispatch_table;
3575 if (!table.GetInstanceProcAddr) return nullptr;
3576 return table.GetInstanceProcAddr(instance, funcName);
3577}
3578
3579VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetPhysicalDeviceProcAddr(VkInstance instance, const char *funcName) {
3580 assert(instance);
3581 auto instance_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map);
3582
3583 if (!instance_data->dispatch_table.GetPhysicalDeviceProcAddr) return nullptr;
3584 return instance_data->dispatch_table.GetPhysicalDeviceProcAddr(instance, funcName);
3585}
3586
3587// If additional validation is needed outside of the generated checks, a manual routine can be added to this file
3588// and the address filled in here. The autogenerated source will call these routines if the pointers are not NULL.
Petr Krausc8655be2017-09-27 18:56:51 +02003589void InitializeManualParameterValidationFunctionPointers() {
Dave Houltonb3bbec72018-01-17 10:13:33 -07003590 custom_functions["vkGetDeviceQueue"] = (void *)pv_vkGetDeviceQueue;
3591 custom_functions["vkCreateBuffer"] = (void *)pv_vkCreateBuffer;
3592 custom_functions["vkCreateImage"] = (void *)pv_vkCreateImage;
3593 custom_functions["vkCreateImageView"] = (void *)pv_vkCreateImageView;
3594 custom_functions["vkCreateGraphicsPipelines"] = (void *)pv_vkCreateGraphicsPipelines;
3595 custom_functions["vkCreateComputePipelines"] = (void *)pv_vkCreateComputePipelines;
3596 custom_functions["vkCreateSampler"] = (void *)pv_vkCreateSampler;
3597 custom_functions["vkCreateDescriptorSetLayout"] = (void *)pv_vkCreateDescriptorSetLayout;
3598 custom_functions["vkFreeDescriptorSets"] = (void *)pv_vkFreeDescriptorSets;
3599 custom_functions["vkUpdateDescriptorSets"] = (void *)pv_vkUpdateDescriptorSets;
3600 custom_functions["vkCreateRenderPass"] = (void *)pv_vkCreateRenderPass;
3601 custom_functions["vkBeginCommandBuffer"] = (void *)pv_vkBeginCommandBuffer;
3602 custom_functions["vkCmdSetViewport"] = (void *)pv_vkCmdSetViewport;
3603 custom_functions["vkCmdSetScissor"] = (void *)pv_vkCmdSetScissor;
Petr Kraus299ba622017-11-24 03:09:03 +01003604 custom_functions["vkCmdSetLineWidth"] = (void *)pv_vkCmdSetLineWidth;
Dave Houltonb3bbec72018-01-17 10:13:33 -07003605 custom_functions["vkCmdDraw"] = (void *)pv_vkCmdDraw;
3606 custom_functions["vkCmdDrawIndirect"] = (void *)pv_vkCmdDrawIndirect;
3607 custom_functions["vkCmdDrawIndexedIndirect"] = (void *)pv_vkCmdDrawIndexedIndirect;
3608 custom_functions["vkCmdCopyImage"] = (void *)pv_vkCmdCopyImage;
3609 custom_functions["vkCmdBlitImage"] = (void *)pv_vkCmdBlitImage;
3610 custom_functions["vkCmdCopyBufferToImage"] = (void *)pv_vkCmdCopyBufferToImage;
3611 custom_functions["vkCmdCopyImageToBuffer"] = (void *)pv_vkCmdCopyImageToBuffer;
3612 custom_functions["vkCmdUpdateBuffer"] = (void *)pv_vkCmdUpdateBuffer;
3613 custom_functions["vkCmdFillBuffer"] = (void *)pv_vkCmdFillBuffer;
3614 custom_functions["vkCreateSwapchainKHR"] = (void *)pv_vkCreateSwapchainKHR;
3615 custom_functions["vkQueuePresentKHR"] = (void *)pv_vkQueuePresentKHR;
3616 custom_functions["vkCreateDescriptorPool"] = (void *)pv_vkCreateDescriptorPool;
3617 custom_functions["vkCmdDispatch"] = (void *)pv_vkCmdDispatch;
Mark Lobodzinskibf973a12018-03-01 08:50:21 -07003618 custom_functions["vkCmdDispatchBaseKHR"] = (void *)pv_vkCmdDispatchBaseKHR;
Jeff Bolz3e71f782018-08-29 23:15:45 -05003619 custom_functions["vkCmdSetExclusiveScissorNV"] = (void *)pv_vkCmdSetExclusiveScissorNV;
Jeff Bolz9af91c52018-09-01 21:53:57 -05003620 custom_functions["vkCmdSetViewportShadingRatePaletteNV"] = (void *)pv_vkCmdSetViewportShadingRatePaletteNV;
3621 custom_functions["vkCmdSetCoarseSampleOrderNV"] = (void *)pv_vkCmdSetCoarseSampleOrderNV;
Jeff Bolz45bf7d62018-09-18 15:39:58 -05003622 custom_functions["vkCmdDrawMeshTasksNV"] = (void *)pv_vkCmdDrawMeshTasksNV;
3623 custom_functions["vkCmdDrawMeshTasksIndirectNV"] = (void *)pv_vkCmdDrawMeshTasksIndirectNV;
3624 custom_functions["vkCmdDrawMeshTasksIndirectCountNV"] = (void *)pv_vkCmdDrawMeshTasksIndirectCountNV;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003625}
3626
3627} // namespace parameter_validation
3628
3629VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateInstanceExtensionProperties(const char *pLayerName, uint32_t *pCount,
3630 VkExtensionProperties *pProperties) {
3631 return parameter_validation::vkEnumerateInstanceExtensionProperties(pLayerName, pCount, pProperties);
3632}
3633
3634VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateInstanceLayerProperties(uint32_t *pCount,
3635 VkLayerProperties *pProperties) {
3636 return parameter_validation::vkEnumerateInstanceLayerProperties(pCount, pProperties);
3637}
3638
3639VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateDeviceLayerProperties(VkPhysicalDevice physicalDevice, uint32_t *pCount,
3640 VkLayerProperties *pProperties) {
3641 // the layer command handles VK_NULL_HANDLE just fine internally
3642 assert(physicalDevice == VK_NULL_HANDLE);
3643 return parameter_validation::vkEnumerateDeviceLayerProperties(VK_NULL_HANDLE, pCount, pProperties);
3644}
3645
3646VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateDeviceExtensionProperties(VkPhysicalDevice physicalDevice,
3647 const char *pLayerName, uint32_t *pCount,
3648 VkExtensionProperties *pProperties) {
3649 // the layer command handles VK_NULL_HANDLE just fine internally
3650 assert(physicalDevice == VK_NULL_HANDLE);
3651 return parameter_validation::vkEnumerateDeviceExtensionProperties(VK_NULL_HANDLE, pLayerName, pCount, pProperties);
3652}
3653
3654VK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetDeviceProcAddr(VkDevice dev, const char *funcName) {
3655 return parameter_validation::vkGetDeviceProcAddr(dev, funcName);
3656}
3657
3658VK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetInstanceProcAddr(VkInstance instance, const char *funcName) {
3659 return parameter_validation::vkGetInstanceProcAddr(instance, funcName);
3660}
3661
3662VK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vk_layerGetPhysicalDeviceProcAddr(VkInstance instance,
3663 const char *funcName) {
3664 return parameter_validation::vkGetPhysicalDeviceProcAddr(instance, funcName);
3665}
3666
Lenny Komow2d0cbbe2018-05-24 13:38:05 -06003667VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL VKAPI_CALL
3668vkNegotiateLoaderLayerInterfaceVersion(VkNegotiateLayerInterface *pVersionStruct) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003669 assert(pVersionStruct != NULL);
3670 assert(pVersionStruct->sType == LAYER_NEGOTIATE_INTERFACE_STRUCT);
3671
3672 // Fill in the function pointers if our version is at least capable of having the structure contain them.
3673 if (pVersionStruct->loaderLayerInterfaceVersion >= 2) {
3674 pVersionStruct->pfnGetInstanceProcAddr = vkGetInstanceProcAddr;
3675 pVersionStruct->pfnGetDeviceProcAddr = vkGetDeviceProcAddr;
3676 pVersionStruct->pfnGetPhysicalDeviceProcAddr = vk_layerGetPhysicalDeviceProcAddr;
3677 }
3678
3679 if (pVersionStruct->loaderLayerInterfaceVersion < CURRENT_LOADER_LAYER_INTERFACE_VERSION) {
3680 parameter_validation::loader_layer_if_version = pVersionStruct->loaderLayerInterfaceVersion;
3681 } else if (pVersionStruct->loaderLayerInterfaceVersion > CURRENT_LOADER_LAYER_INTERFACE_VERSION) {
3682 pVersionStruct->loaderLayerInterfaceVersion = CURRENT_LOADER_LAYER_INTERFACE_VERSION;
3683 }
3684
3685 return VK_SUCCESS;
3686}