blob: 064f72cd4c8bd47fb138c3c1284d2b1561a4772d [file] [log] [blame]
sfricke-samsung11ea8ed2020-01-07 22:24:56 -08001/* Copyright (c) 2015-2020 The Khronos Group Inc.
2 * Copyright (c) 2015-2020 Valve Corporation
3 * Copyright (c) 2015-2020 LunarG, Inc.
4 * Copyright (C) 2015-2020 Google Inc.
Mark Lobodzinskid4950072017-08-01 13:02:20 -06005 *
6 * Licensed under the Apache License, Version 2.0 (the "License");
7 * you may not use this file except in compliance with the License.
8 * You may obtain a copy of the License at
9 *
10 * http://www.apache.org/licenses/LICENSE-2.0
11 *
12 * Unless required by applicable law or agreed to in writing, software
13 * distributed under the License is distributed on an "AS IS" BASIS,
14 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15 * See the License for the specific language governing permissions and
16 * limitations under the License.
17 *
18 * Author: Mark Lobodzinski <mark@LunarG.com>
John Zulaufa999d1b2018-11-29 13:38:40 -070019 * Author: John Zulauf <jzulauf@lunarg.com>
Mark Lobodzinskid4950072017-08-01 13:02:20 -060020 */
21
orbea80ddc062019-09-10 10:33:19 -070022#include <cmath>
Shahbaz Youssefi6be11412019-01-10 15:29:30 -050023
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -070024#include "chassis.h"
25#include "stateless_validation.h"
Mark Lobodzinskie514d1a2019-03-12 08:47:45 -060026#include "layer_chassis_dispatch.h"
Tobias Hectord942eb92018-10-22 15:18:56 +010027
Mark Lobodzinskid4950072017-08-01 13:02:20 -060028static const int MaxParamCheckerStringLength = 256;
29
John Zulauf71968502017-10-26 13:51:15 -060030template <typename T>
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -070031inline bool in_inclusive_range(const T &value, const T &min, const T &max) {
John Zulauf71968502017-10-26 13:51:15 -060032 // Using only < for generality and || for early abort
33 return !((value < min) || (max < value));
34}
35
Mark Lobodzinskibf599b92018-12-31 12:15:55 -070036bool StatelessValidation::validate_string(const char *apiName, const ParameterName &stringName, const std::string &vuid,
Jeff Bolz46c0ea02019-10-09 13:06:29 -050037 const char *validateString) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -060038 bool skip = false;
39
40 VkStringErrorFlags result = vk_string_validate(MaxParamCheckerStringLength, validateString);
41
42 if (result == VK_STRING_ERROR_NONE) {
43 return skip;
44 } else if (result & VK_STRING_ERROR_LENGTH) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -070045 skip = LogError(device, vuid, "%s: string %s exceeds max length %d", apiName, stringName.get_name().c_str(),
46 MaxParamCheckerStringLength);
Mark Lobodzinskid4950072017-08-01 13:02:20 -060047 } else if (result & VK_STRING_ERROR_BAD_DATA) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -070048 skip = LogError(device, vuid, "%s: string %s contains invalid characters or is badly formed", apiName,
49 stringName.get_name().c_str());
Mark Lobodzinskid4950072017-08-01 13:02:20 -060050 }
51 return skip;
52}
53
Jeff Bolz46c0ea02019-10-09 13:06:29 -050054bool StatelessValidation::validate_api_version(uint32_t api_version, uint32_t effective_api_version) const {
John Zulauf620755c2018-04-16 11:00:43 -060055 bool skip = false;
56 uint32_t api_version_nopatch = VK_MAKE_VERSION(VK_VERSION_MAJOR(api_version), VK_VERSION_MINOR(api_version), 0);
57 if (api_version_nopatch != effective_api_version) {
58 if (api_version_nopatch < VK_API_VERSION_1_0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -070059 skip |= LogError(instance, kVUIDUndefined,
60 "Invalid CreateInstance->pCreateInfo->pApplicationInfo.apiVersion number (0x%08x). "
61 "Using VK_API_VERSION_%" PRIu32 "_%" PRIu32 ".",
62 api_version, VK_VERSION_MAJOR(effective_api_version), VK_VERSION_MINOR(effective_api_version));
John Zulauf620755c2018-04-16 11:00:43 -060063 } else {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -070064 skip |= LogWarning(instance, kVUIDUndefined,
65 "Unrecognized CreateInstance->pCreateInfo->pApplicationInfo.apiVersion number (0x%08x). "
66 "Assuming VK_API_VERSION_%" PRIu32 "_%" PRIu32 ".",
67 api_version, VK_VERSION_MAJOR(effective_api_version), VK_VERSION_MINOR(effective_api_version));
John Zulauf620755c2018-04-16 11:00:43 -060068 }
69 }
70 return skip;
71}
72
Jeff Bolz46c0ea02019-10-09 13:06:29 -050073bool StatelessValidation::validate_instance_extensions(const VkInstanceCreateInfo *pCreateInfo) const {
John Zulauf620755c2018-04-16 11:00:43 -060074 bool skip = false;
Mark Lobodzinski05cce202019-08-27 10:28:37 -060075 // Create and use a local instance extension object, as an actual instance has not been created yet
76 uint32_t specified_version = (pCreateInfo->pApplicationInfo ? pCreateInfo->pApplicationInfo->apiVersion : VK_API_VERSION_1_0);
77 InstanceExtensions local_instance_extensions;
78 local_instance_extensions.InitFromInstanceCreateInfo(specified_version, pCreateInfo);
79
John Zulauf620755c2018-04-16 11:00:43 -060080 for (uint32_t i = 0; i < pCreateInfo->enabledExtensionCount; i++) {
Mark Lobodzinski05cce202019-08-27 10:28:37 -060081 skip |= validate_extension_reqs(local_instance_extensions, "VUID-vkCreateInstance-ppEnabledExtensionNames-01388",
82 "instance", pCreateInfo->ppEnabledExtensionNames[i]);
John Zulauf620755c2018-04-16 11:00:43 -060083 }
84
85 return skip;
86}
87
Mark Lobodzinskibece6c12020-08-27 15:34:02 -060088bool StatelessValidation::SupportedByPdev(const VkPhysicalDevice physical_device, const std::string ext_name) const {
89 if (instance_extensions.vk_khr_get_physical_device_properties_2) {
90 // Struct is legal IF it's supported
91 const auto &dev_exts_enumerated = device_extensions_enumerated.find(physical_device);
92 if (dev_exts_enumerated == device_extensions_enumerated.end()) return true;
93 auto enum_iter = dev_exts_enumerated->second.find(ext_name);
94 if (enum_iter != dev_exts_enumerated->second.cend()) {
95 return true;
96 }
97 }
98 return false;
99}
100
Tony-LunarG866843d2020-05-13 11:22:42 -0600101bool StatelessValidation::validate_validation_features(const VkInstanceCreateInfo *pCreateInfo,
102 const VkValidationFeaturesEXT *validation_features) const {
103 bool skip = false;
104 bool debug_printf = false;
105 bool gpu_assisted = false;
106 bool reserve_slot = false;
107 for (uint32_t i = 0; i < validation_features->enabledValidationFeatureCount; i++) {
108 switch (validation_features->pEnabledValidationFeatures[i]) {
109 case VK_VALIDATION_FEATURE_ENABLE_GPU_ASSISTED_EXT:
110 gpu_assisted = true;
111 break;
112
113 case VK_VALIDATION_FEATURE_ENABLE_DEBUG_PRINTF_EXT:
114 debug_printf = true;
115 break;
116
117 case VK_VALIDATION_FEATURE_ENABLE_GPU_ASSISTED_RESERVE_BINDING_SLOT_EXT:
118 reserve_slot = true;
119 break;
120
121 default:
122 break;
123 }
124 }
125 if (reserve_slot && !gpu_assisted) {
126 skip |= LogError(instance, "VUID-VkValidationFeaturesEXT-pEnabledValidationFeatures-02967",
127 "If VK_VALIDATION_FEATURE_ENABLE_GPU_ASSISTED_RESERVE_BINDING_SLOT_EXT is in pEnabledValidationFeatures, "
128 "VK_VALIDATION_FEATURE_ENABLE_GPU_ASSISTED_EXT must also be in pEnabledValidationFeatures.");
129 }
130 if (gpu_assisted && debug_printf) {
131 skip |= LogError(instance, "VUID-VkValidationFeaturesEXT-pEnabledValidationFeatures-02968",
132 "If VK_VALIDATION_FEATURE_ENABLE_GPU_ASSISTED_EXT is in pEnabledValidationFeatures, "
133 "VK_VALIDATION_FEATURE_ENABLE_DEBUG_PRINTF_EXT must not also be in pEnabledValidationFeatures.");
134 }
135
136 return skip;
137}
138
John Zulauf620755c2018-04-16 11:00:43 -0600139template <typename ExtensionState>
Tony-LunarG2ec96bb2019-11-26 13:43:02 -0700140ExtEnabled extension_state_by_name(const ExtensionState &extensions, const char *extension_name) {
141 if (!extension_name) return kNotEnabled; // null strings specify nothing
John Zulauf620755c2018-04-16 11:00:43 -0600142 auto info = ExtensionState::get_info(extension_name);
Tony-LunarG2ec96bb2019-11-26 13:43:02 -0700143 ExtEnabled state =
144 info.state ? extensions.*(info.state) : kNotEnabled; // unknown extensions can't be enabled in extension struct
John Zulauf620755c2018-04-16 11:00:43 -0600145 return state;
146}
147
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700148bool StatelessValidation::manual_PreCallValidateCreateInstance(const VkInstanceCreateInfo *pCreateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -0500149 const VkAllocationCallbacks *pAllocator,
150 VkInstance *pInstance) const {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700151 bool skip = false;
152 // Note: From the spec--
153 // Providing a NULL VkInstanceCreateInfo::pApplicationInfo or providing an apiVersion of 0 is equivalent to providing
154 // an apiVersion of VK_MAKE_VERSION(1, 0, 0). (a.k.a. VK_API_VERSION_1_0)
155 uint32_t local_api_version = (pCreateInfo->pApplicationInfo && pCreateInfo->pApplicationInfo->apiVersion)
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700156 ? pCreateInfo->pApplicationInfo->apiVersion
157 : VK_API_VERSION_1_0;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700158 skip |= validate_api_version(local_api_version, api_version);
159 skip |= validate_instance_extensions(pCreateInfo);
Tony-LunarG866843d2020-05-13 11:22:42 -0600160 const auto *validation_features = lvl_find_in_chain<VkValidationFeaturesEXT>(pCreateInfo->pNext);
161 if (validation_features) skip |= validate_validation_features(pCreateInfo, validation_features);
162
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700163 return skip;
164}
165
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700166void StatelessValidation::PostCallRecordCreateInstance(const VkInstanceCreateInfo *pCreateInfo,
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -0700167 const VkAllocationCallbacks *pAllocator, VkInstance *pInstance,
168 VkResult result) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700169 auto instance_data = GetLayerDataPtr(get_dispatch_key(*pInstance), layer_data_map);
170 // Copy extension data into local object
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -0700171 if (result != VK_SUCCESS) return;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700172 this->instance_extensions = instance_data->instance_extensions;
Mark Lobodzinski2e40a132020-08-10 14:51:41 -0600173
174 uint32_t pdev_count = 0;
175 DispatchEnumeratePhysicalDevices(*pInstance, &pdev_count, nullptr);
176 std::vector<VkPhysicalDevice> physical_devices;
177 physical_devices.resize(pdev_count);
178 DispatchEnumeratePhysicalDevices(*pInstance, &pdev_count, physical_devices.data());
179
Mark Lobodzinski2e40a132020-08-10 14:51:41 -0600180 for (uint32_t i = 0; i < physical_devices.size(); i++) {
181 auto phys_dev_props = new VkPhysicalDeviceProperties;
182 DispatchGetPhysicalDeviceProperties(physical_devices[i], phys_dev_props);
183 physical_device_properties_map[physical_devices[i]] = phys_dev_props;
Mark Lobodzinskibece6c12020-08-27 15:34:02 -0600184
185 // Enumerate the Device Ext Properties to save the PhysicalDevice supported extension state
186 uint32_t ext_count = 0;
187 std::unordered_set<std::string> dev_exts_enumerated{};
188 std::vector<VkExtensionProperties> ext_props{};
189 instance_dispatch_table.EnumerateDeviceExtensionProperties(physical_devices[i], nullptr, &ext_count, nullptr);
190 ext_props.resize(ext_count);
191 instance_dispatch_table.EnumerateDeviceExtensionProperties(physical_devices[i], nullptr, &ext_count, ext_props.data());
192 for (uint32_t j = 0; j < ext_count; j++) {
193 dev_exts_enumerated.insert(ext_props[j].extensionName);
194 }
195 device_extensions_enumerated[physical_devices[i]] = std::move(dev_exts_enumerated);
Mark Lobodzinski2e40a132020-08-10 14:51:41 -0600196 }
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700197}
198
Mark Lobodzinski2e40a132020-08-10 14:51:41 -0600199void StatelessValidation::PreCallRecordDestroyInstance(VkInstance instance, const VkAllocationCallbacks *pAllocator) {
200 for (auto it = physical_device_properties_map.begin(); it != physical_device_properties_map.end();) {
201 delete (it->second);
202 it = physical_device_properties_map.erase(it);
203 }
204};
205
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700206void StatelessValidation::PostCallRecordCreateDevice(VkPhysicalDevice physicalDevice, const VkDeviceCreateInfo *pCreateInfo,
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -0700207 const VkAllocationCallbacks *pAllocator, VkDevice *pDevice, VkResult result) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700208 auto device_data = GetLayerDataPtr(get_dispatch_key(*pDevice), layer_data_map);
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -0700209 if (result != VK_SUCCESS) return;
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700210 ValidationObject *validation_data = GetValidationObject(device_data->object_dispatch, LayerObjectTypeParameterValidation);
211 StatelessValidation *stateless_validation = static_cast<StatelessValidation *>(validation_data);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700212
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700213 // Parmeter validation also uses extension data
214 stateless_validation->device_extensions = this->device_extensions;
215
216 VkPhysicalDeviceProperties device_properties = {};
217 // Need to get instance and do a getlayerdata call...
Tony-LunarG152a88b2019-03-20 15:42:24 -0600218 DispatchGetPhysicalDeviceProperties(physicalDevice, &device_properties);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700219 memcpy(&stateless_validation->device_limits, &device_properties.limits, sizeof(VkPhysicalDeviceLimits));
220
221 if (device_extensions.vk_nv_shading_rate_image) {
222 // Get the needed shading rate image limits
223 auto shading_rate_image_props = lvl_init_struct<VkPhysicalDeviceShadingRateImagePropertiesNV>();
224 auto prop2 = lvl_init_struct<VkPhysicalDeviceProperties2KHR>(&shading_rate_image_props);
Tony-LunarG152a88b2019-03-20 15:42:24 -0600225 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700226 phys_dev_ext_props.shading_rate_image_props = shading_rate_image_props;
227 }
228
229 if (device_extensions.vk_nv_mesh_shader) {
230 // Get the needed mesh shader limits
231 auto mesh_shader_props = lvl_init_struct<VkPhysicalDeviceMeshShaderPropertiesNV>();
232 auto prop2 = lvl_init_struct<VkPhysicalDeviceProperties2KHR>(&mesh_shader_props);
Tony-LunarG152a88b2019-03-20 15:42:24 -0600233 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700234 phys_dev_ext_props.mesh_shader_props = mesh_shader_props;
235 }
236
Jason Macnak5c954952019-07-09 15:46:12 -0700237 if (device_extensions.vk_nv_ray_tracing) {
238 // Get the needed ray tracing limits
239 auto ray_tracing_props = lvl_init_struct<VkPhysicalDeviceRayTracingPropertiesNV>();
240 auto prop2 = lvl_init_struct<VkPhysicalDeviceProperties2KHR>(&ray_tracing_props);
241 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
Jeff Bolz443c2ca2020-03-19 12:11:51 -0500242 phys_dev_ext_props.ray_tracing_propsNV = ray_tracing_props;
243 }
244
245 if (device_extensions.vk_khr_ray_tracing) {
246 // Get the needed ray tracing limits
247 auto ray_tracing_props = lvl_init_struct<VkPhysicalDeviceRayTracingPropertiesKHR>();
248 auto prop2 = lvl_init_struct<VkPhysicalDeviceProperties2KHR>(&ray_tracing_props);
249 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
250 phys_dev_ext_props.ray_tracing_propsKHR = ray_tracing_props;
Jason Macnak5c954952019-07-09 15:46:12 -0700251 }
252
Mark Lobodzinski953b7bc2019-12-19 13:50:10 -0700253 if (device_extensions.vk_ext_transform_feedback) {
254 // Get the needed transform feedback limits
255 auto transform_feedback_props = lvl_init_struct<VkPhysicalDeviceTransformFeedbackPropertiesEXT>();
256 auto prop2 = lvl_init_struct<VkPhysicalDeviceProperties2KHR>(&transform_feedback_props);
257 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
258 phys_dev_ext_props.transform_feedback_props = transform_feedback_props;
259 }
260
Jasper St. Pierrea49b4be2019-02-05 17:48:57 -0800261 stateless_validation->phys_dev_ext_props = this->phys_dev_ext_props;
262
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700263 // Save app-enabled features in this device's validation object
264 // The enabled features can come from either pEnabledFeatures, or from the pNext chain
Petr Kraus715bcc72019-08-15 17:17:33 +0200265 const auto *features2 = lvl_find_in_chain<VkPhysicalDeviceFeatures2>(pCreateInfo->pNext);
266 safe_VkPhysicalDeviceFeatures2 tmp_features2_state;
267 tmp_features2_state.sType = VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_FEATURES_2;
268 if (features2) {
269 tmp_features2_state.features = features2->features;
270 } else if (pCreateInfo->pEnabledFeatures) {
271 tmp_features2_state.features = *pCreateInfo->pEnabledFeatures;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700272 } else {
Petr Kraus715bcc72019-08-15 17:17:33 +0200273 tmp_features2_state.features = {};
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700274 }
Petr Kraus715bcc72019-08-15 17:17:33 +0200275 // Use pCreateInfo->pNext to get full chain
Tony-LunarG6c3c5452019-12-13 10:37:38 -0700276 stateless_validation->device_createinfo_pnext = SafePnextCopy(pCreateInfo->pNext);
Petr Kraus715bcc72019-08-15 17:17:33 +0200277 stateless_validation->physical_device_features2 = tmp_features2_state;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700278}
279
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700280bool StatelessValidation::manual_PreCallValidateCreateDevice(VkPhysicalDevice physicalDevice, const VkDeviceCreateInfo *pCreateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -0500281 const VkAllocationCallbacks *pAllocator, VkDevice *pDevice) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600282 bool skip = false;
283
Petr Kraus6c4bdce2019-08-27 17:35:01 +0200284 for (size_t i = 0; i < pCreateInfo->enabledLayerCount; i++) {
285 skip |= validate_string("vkCreateDevice", "pCreateInfo->ppEnabledLayerNames",
286 "VUID-VkDeviceCreateInfo-ppEnabledLayerNames-parameter", pCreateInfo->ppEnabledLayerNames[i]);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600287 }
288
Petr Kraus6c4bdce2019-08-27 17:35:01 +0200289 for (size_t i = 0; i < pCreateInfo->enabledExtensionCount; i++) {
290 skip |=
291 validate_string("vkCreateDevice", "pCreateInfo->ppEnabledExtensionNames",
292 "VUID-VkDeviceCreateInfo-ppEnabledExtensionNames-parameter", pCreateInfo->ppEnabledExtensionNames[i]);
293 skip |= validate_extension_reqs(device_extensions, "VUID-vkCreateDevice-ppEnabledExtensionNames-01387", "device",
294 pCreateInfo->ppEnabledExtensionNames[i]);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600295 }
296
Petr Kraus6c4bdce2019-08-27 17:35:01 +0200297 {
Tony-LunarG2ec96bb2019-11-26 13:43:02 -0700298 bool maint1 = IsExtEnabled(extension_state_by_name(device_extensions, VK_KHR_MAINTENANCE1_EXTENSION_NAME));
299 bool negative_viewport =
300 IsExtEnabled(extension_state_by_name(device_extensions, VK_AMD_NEGATIVE_VIEWPORT_HEIGHT_EXTENSION_NAME));
Petr Kraus6c4bdce2019-08-27 17:35:01 +0200301 if (maint1 && negative_viewport) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700302 skip |= LogError(device, "VUID-VkDeviceCreateInfo-ppEnabledExtensionNames-00374",
303 "VkDeviceCreateInfo->ppEnabledExtensionNames must not simultaneously include VK_KHR_maintenance1 and "
304 "VK_AMD_negative_viewport_height.");
Petr Kraus6c4bdce2019-08-27 17:35:01 +0200305 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600306 }
307
Jeff Bolz4563f2a2019-12-10 13:30:30 -0600308 {
309 bool khr_bda = IsExtEnabled(extension_state_by_name(device_extensions, VK_KHR_BUFFER_DEVICE_ADDRESS_EXTENSION_NAME));
310 bool ext_bda = IsExtEnabled(extension_state_by_name(device_extensions, VK_EXT_BUFFER_DEVICE_ADDRESS_EXTENSION_NAME));
311 if (khr_bda && ext_bda) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700312 skip |= LogError(device, "VUID-VkDeviceCreateInfo-ppEnabledExtensionNames-03328",
313 "VkDeviceCreateInfo->ppEnabledExtensionNames must not contain both VK_KHR_buffer_device_address and "
314 "VK_EXT_buffer_device_address.");
Jeff Bolz4563f2a2019-12-10 13:30:30 -0600315 }
316 }
317
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600318 if (pCreateInfo->pNext != NULL && pCreateInfo->pEnabledFeatures) {
319 // Check for get_physical_device_properties2 struct
John Zulaufde972ac2017-10-26 12:07:05 -0600320 const auto *features2 = lvl_find_in_chain<VkPhysicalDeviceFeatures2KHR>(pCreateInfo->pNext);
321 if (features2) {
322 // Cannot include VkPhysicalDeviceFeatures2KHR and have non-null pEnabledFeatures
sfricke-samsung590ae1e2020-04-25 01:18:05 -0700323 skip |= LogError(device, "VUID-VkDeviceCreateInfo-pNext-00373",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700324 "VkDeviceCreateInfo->pNext includes a VkPhysicalDeviceFeatures2KHR struct when "
325 "pCreateInfo->pEnabledFeatures is non-NULL.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600326 }
327 }
328
Locke77fad1c2019-04-16 13:09:03 -0600329 auto features2 = lvl_find_in_chain<VkPhysicalDeviceFeatures2>(pCreateInfo->pNext);
Jeff Bolz165818a2020-05-08 11:19:03 -0500330 const VkPhysicalDeviceFeatures *features = features2 ? &features2->features : pCreateInfo->pEnabledFeatures;
331 const auto *robustness2_features = lvl_find_in_chain<VkPhysicalDeviceRobustness2FeaturesEXT>(pCreateInfo->pNext);
332 if (features && robustness2_features && robustness2_features->robustBufferAccess2 && !features->robustBufferAccess) {
333 skip |= LogError(device, "VUID-VkPhysicalDeviceRobustness2FeaturesEXT-robustBufferAccess2-04000",
334 "If robustBufferAccess2 is enabled then robustBufferAccess must be enabled.");
335 }
sourav parmara24fb7b2020-05-26 10:50:04 -0700336 const auto *raytracing_features = lvl_find_in_chain<VkPhysicalDeviceRayTracingFeaturesKHR>(pCreateInfo->pNext);
337 if (raytracing_features && raytracing_features->rayTracingShaderGroupHandleCaptureReplayMixed &&
338 !raytracing_features->rayTracingShaderGroupHandleCaptureReplay) {
339 skip |= LogError(device, "VUID-VkPhysicalDeviceRayTracingFeaturesKHR-rayTracingShaderGroupHandleCaptureReplayMixed-03348",
340 "If rayTracingShaderGroupHandleCaptureReplayMixed is VK_TRUE, rayTracingShaderGroupHandleCaptureReplay "
341 "must also be VK_TRUE.");
342 }
Locke77fad1c2019-04-16 13:09:03 -0600343 auto vertex_attribute_divisor_features =
344 lvl_find_in_chain<VkPhysicalDeviceVertexAttributeDivisorFeaturesEXT>(pCreateInfo->pNext);
Mark Lobodzinski3e66ae82020-08-12 16:27:29 -0600345 if (vertex_attribute_divisor_features && (!device_extensions.vk_ext_vertex_attribute_divisor)) {
346 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
347 "VkDeviceCreateInfo->pNext includes a VkPhysicalDeviceVertexAttributeDivisorFeaturesEXT "
348 "struct, VK_EXT_vertex_attribute_divisor must be enabled when it creates a device.");
Locke77fad1c2019-04-16 13:09:03 -0600349 }
350
Tony-LunarG28017bc2020-01-23 14:40:25 -0700351 const auto *vulkan_11_features = lvl_find_in_chain<VkPhysicalDeviceVulkan11Features>(pCreateInfo->pNext);
352 if (vulkan_11_features) {
353 const VkBaseOutStructure *current = reinterpret_cast<const VkBaseOutStructure *>(pCreateInfo->pNext);
354 while (current) {
355 if (current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_16BIT_STORAGE_FEATURES ||
356 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_MULTIVIEW_FEATURES ||
357 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_VARIABLE_POINTERS_FEATURES ||
358 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_PROTECTED_MEMORY_FEATURES ||
359 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SAMPLER_YCBCR_CONVERSION_FEATURES ||
360 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SHADER_DRAW_PARAMETERS_FEATURES) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700361 skip |= LogError(
362 instance, "VUID-VkDeviceCreateInfo-pNext-02829",
Tony-LunarG28017bc2020-01-23 14:40:25 -0700363 "If the pNext chain includes a VkPhysicalDeviceVulkan11Features structure, then it must not include a "
364 "VkPhysicalDevice16BitStorageFeatures, VkPhysicalDeviceMultiviewFeatures, "
365 "VkPhysicalDeviceVariablePointersFeatures, VkPhysicalDeviceProtectedMemoryFeatures, "
366 "VkPhysicalDeviceSamplerYcbcrConversionFeatures, or VkPhysicalDeviceShaderDrawParametersFeatures structure");
367 break;
368 }
369 current = reinterpret_cast<const VkBaseOutStructure *>(current->pNext);
370 }
371 }
372
373 const auto *vulkan_12_features = lvl_find_in_chain<VkPhysicalDeviceVulkan12Features>(pCreateInfo->pNext);
374 if (vulkan_12_features) {
375 const VkBaseOutStructure *current = reinterpret_cast<const VkBaseOutStructure *>(pCreateInfo->pNext);
376 while (current) {
377 if (current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_8BIT_STORAGE_FEATURES ||
378 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SHADER_ATOMIC_INT64_FEATURES ||
379 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SHADER_FLOAT16_INT8_FEATURES ||
380 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_DESCRIPTOR_INDEXING_FEATURES ||
381 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SCALAR_BLOCK_LAYOUT_FEATURES ||
382 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_IMAGELESS_FRAMEBUFFER_FEATURES ||
383 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_UNIFORM_BUFFER_STANDARD_LAYOUT_FEATURES ||
384 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SHADER_SUBGROUP_EXTENDED_TYPES_FEATURES ||
385 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SEPARATE_DEPTH_STENCIL_LAYOUTS_FEATURES ||
386 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_HOST_QUERY_RESET_FEATURES ||
387 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_TIMELINE_SEMAPHORE_FEATURES ||
388 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_BUFFER_DEVICE_ADDRESS_FEATURES ||
389 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_VULKAN_MEMORY_MODEL_FEATURES) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700390 skip |= LogError(
391 instance, "VUID-VkDeviceCreateInfo-pNext-02830",
Tony-LunarG28017bc2020-01-23 14:40:25 -0700392 "If the pNext chain includes a VkPhysicalDeviceVulkan12Features structure, then it must not include a "
393 "VkPhysicalDevice8BitStorageFeatures, VkPhysicalDeviceShaderAtomicInt64Features, "
394 "VkPhysicalDeviceShaderFloat16Int8Features, VkPhysicalDeviceDescriptorIndexingFeatures, "
395 "VkPhysicalDeviceScalarBlockLayoutFeatures, VkPhysicalDeviceImagelessFramebufferFeatures, "
396 "VkPhysicalDeviceUniformBufferStandardLayoutFeatures, VkPhysicalDeviceShaderSubgroupExtendedTypesFeatures, "
397 "VkPhysicalDeviceSeparateDepthStencilLayoutsFeatures, VkPhysicalDeviceHostQueryResetFeatures, "
398 "VkPhysicalDeviceTimelineSemaphoreFeatures, VkPhysicalDeviceBufferDeviceAddressFeatures, or "
399 "VkPhysicalDeviceVulkanMemoryModelFeatures structure");
400 break;
401 }
402 current = reinterpret_cast<const VkBaseOutStructure *>(current->pNext);
403 }
sfricke-samsungabab4632020-05-04 06:51:46 -0700404 // Check features are enabled if matching extension is passed in as well
405 for (uint32_t i = 0; i < pCreateInfo->enabledExtensionCount; i++) {
406 const char *extension = pCreateInfo->ppEnabledExtensionNames[i];
407 if ((0 == strncmp(extension, VK_KHR_DRAW_INDIRECT_COUNT_EXTENSION_NAME, VK_MAX_EXTENSION_NAME_SIZE)) &&
408 (vulkan_12_features->drawIndirectCount == VK_FALSE)) {
409 skip |= LogError(
410 instance, "VUID-VkDeviceCreateInfo-ppEnabledExtensions-02831",
411 "vkCreateDevice(): %s is enabled but VkPhysicalDeviceVulkan12Features::drawIndirectCount is not VK_TRUE.",
412 VK_KHR_DRAW_INDIRECT_COUNT_EXTENSION_NAME);
413 }
414 if ((0 == strncmp(extension, VK_KHR_SAMPLER_MIRROR_CLAMP_TO_EDGE_EXTENSION_NAME, VK_MAX_EXTENSION_NAME_SIZE)) &&
415 (vulkan_12_features->samplerMirrorClampToEdge == VK_FALSE)) {
416 skip |= LogError(instance, "VUID-VkDeviceCreateInfo-ppEnabledExtensions-02832",
417 "vkCreateDevice(): %s is enabled but VkPhysicalDeviceVulkan12Features::samplerMirrorClampToEdge "
418 "is not VK_TRUE.",
419 VK_KHR_SAMPLER_MIRROR_CLAMP_TO_EDGE_EXTENSION_NAME);
420 }
421 if ((0 == strncmp(extension, VK_EXT_DESCRIPTOR_INDEXING_EXTENSION_NAME, VK_MAX_EXTENSION_NAME_SIZE)) &&
422 (vulkan_12_features->descriptorIndexing == VK_FALSE)) {
423 skip |= LogError(
424 instance, "VUID-VkDeviceCreateInfo-ppEnabledExtensions-02833",
425 "vkCreateDevice(): %s is enabled but VkPhysicalDeviceVulkan12Features::descriptorIndexing is not VK_TRUE.",
426 VK_EXT_DESCRIPTOR_INDEXING_EXTENSION_NAME);
427 }
428 if ((0 == strncmp(extension, VK_EXT_SAMPLER_FILTER_MINMAX_EXTENSION_NAME, VK_MAX_EXTENSION_NAME_SIZE)) &&
429 (vulkan_12_features->samplerFilterMinmax == VK_FALSE)) {
430 skip |= LogError(
431 instance, "VUID-VkDeviceCreateInfo-ppEnabledExtensions-02834",
432 "vkCreateDevice(): %s is enabled but VkPhysicalDeviceVulkan12Features::samplerFilterMinmax is not VK_TRUE.",
433 VK_EXT_SAMPLER_FILTER_MINMAX_EXTENSION_NAME);
434 }
435 if ((0 == strncmp(extension, VK_EXT_SHADER_VIEWPORT_INDEX_LAYER_EXTENSION_NAME, VK_MAX_EXTENSION_NAME_SIZE)) &&
436 ((vulkan_12_features->shaderOutputViewportIndex == VK_FALSE) ||
437 (vulkan_12_features->shaderOutputLayer == VK_FALSE))) {
438 skip |=
439 LogError(instance, "VUID-VkDeviceCreateInfo-ppEnabledExtensions-02835",
440 "vkCreateDevice(): %s is enabled but both VkPhysicalDeviceVulkan12Features::shaderOutputViewportIndex "
441 "and VkPhysicalDeviceVulkan12Features::shaderOutputLayer are not VK_TRUE.",
442 VK_EXT_SHADER_VIEWPORT_INDEX_LAYER_EXTENSION_NAME);
443 }
444 }
Tony-LunarG28017bc2020-01-23 14:40:25 -0700445 }
446
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600447 // Validate pCreateInfo->pQueueCreateInfos
448 if (pCreateInfo->pQueueCreateInfos) {
449 std::unordered_set<uint32_t> set;
450
451 for (uint32_t i = 0; i < pCreateInfo->queueCreateInfoCount; ++i) {
sfricke-samsung590ae1e2020-04-25 01:18:05 -0700452 const VkDeviceQueueCreateInfo &queue_create_info = pCreateInfo->pQueueCreateInfos[i];
453 const uint32_t requested_queue_family = queue_create_info.queueFamilyIndex;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600454 if (requested_queue_family == VK_QUEUE_FAMILY_IGNORED) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700455 skip |=
456 LogError(physicalDevice, "VUID-VkDeviceQueueCreateInfo-queueFamilyIndex-00381",
457 "vkCreateDevice: pCreateInfo->pQueueCreateInfos[%" PRIu32
458 "].queueFamilyIndex is VK_QUEUE_FAMILY_IGNORED, but it is required to provide a valid queue family "
459 "index value.",
460 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600461 } else if (set.count(requested_queue_family)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700462 skip |= LogError(physicalDevice, "VUID-VkDeviceCreateInfo-queueFamilyIndex-00372",
463 "vkCreateDevice: pCreateInfo->pQueueCreateInfos[%" PRIu32 "].queueFamilyIndex (=%" PRIu32
464 ") is not unique within pCreateInfo->pQueueCreateInfos array.",
465 i, requested_queue_family);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600466 } else {
467 set.insert(requested_queue_family);
468 }
469
sfricke-samsung590ae1e2020-04-25 01:18:05 -0700470 if (queue_create_info.pQueuePriorities != nullptr) {
471 for (uint32_t j = 0; j < queue_create_info.queueCount; ++j) {
472 const float queue_priority = queue_create_info.pQueuePriorities[j];
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600473 if (!(queue_priority >= 0.f) || !(queue_priority <= 1.f)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700474 skip |= LogError(physicalDevice, "VUID-VkDeviceQueueCreateInfo-pQueuePriorities-00383",
475 "vkCreateDevice: pCreateInfo->pQueueCreateInfos[%" PRIu32 "].pQueuePriorities[%" PRIu32
476 "] (=%f) is not between 0 and 1 (inclusive).",
477 i, j, queue_priority);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600478 }
479 }
480 }
sfricke-samsung590ae1e2020-04-25 01:18:05 -0700481
482 // Need to know if protectedMemory feature is passed in preCall to creating the device
483 VkBool32 protectedMemory = VK_FALSE;
484 const VkPhysicalDeviceProtectedMemoryFeatures *protected_features =
485 lvl_find_in_chain<VkPhysicalDeviceProtectedMemoryFeatures>(pCreateInfo->pNext);
486 if (protected_features) {
487 protectedMemory = protected_features->protectedMemory;
488 } else if (vulkan_11_features) {
489 protectedMemory = vulkan_11_features->protectedMemory;
490 }
491 if ((queue_create_info.flags == VK_DEVICE_QUEUE_CREATE_PROTECTED_BIT) && (protectedMemory == VK_FALSE)) {
492 skip |= LogError(physicalDevice, "VUID-VkDeviceQueueCreateInfo-flags-02861",
493 "vkCreateDevice: pCreateInfo->flags set to VK_DEVICE_QUEUE_CREATE_PROTECTED_BIT without the "
494 "protectedMemory feature being set as well.");
495 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600496 }
497 }
498
sfricke-samsung30a57412020-05-15 21:14:54 -0700499 // feature dependencies for VK_KHR_variable_pointers
500 const auto *variable_pointers_features = lvl_find_in_chain<VkPhysicalDeviceVariablePointersFeatures>(pCreateInfo->pNext);
501 VkBool32 variablePointers = VK_FALSE;
502 VkBool32 variablePointersStorageBuffer = VK_FALSE;
503 if (vulkan_11_features) {
504 variablePointers = vulkan_11_features->variablePointers;
505 variablePointersStorageBuffer = vulkan_11_features->variablePointersStorageBuffer;
506 } else if (variable_pointers_features) {
507 variablePointers = variable_pointers_features->variablePointers;
508 variablePointersStorageBuffer = variable_pointers_features->variablePointersStorageBuffer;
509 }
510 if ((variablePointers == VK_TRUE) && (variablePointersStorageBuffer == VK_FALSE)) {
511 skip |= LogError(instance, "VUID-VkPhysicalDeviceVariablePointersFeatures-variablePointers-01431",
512 "If variablePointers is VK_TRUE then variablePointersStorageBuffer also needs to be VK_TRUE");
513 }
514
sfricke-samsungfd76c342020-05-29 23:13:43 -0700515 // feature dependencies for VK_KHR_multiview
516 const auto *multiview_features = lvl_find_in_chain<VkPhysicalDeviceMultiviewFeatures>(pCreateInfo->pNext);
517 VkBool32 multiview = VK_FALSE;
518 VkBool32 multiviewGeometryShader = VK_FALSE;
519 VkBool32 multiviewTessellationShader = VK_FALSE;
520 if (vulkan_11_features) {
521 multiview = vulkan_11_features->multiview;
522 multiviewGeometryShader = vulkan_11_features->multiviewGeometryShader;
523 multiviewTessellationShader = vulkan_11_features->multiviewTessellationShader;
524 } else if (multiview_features) {
525 multiview = multiview_features->multiview;
526 multiviewGeometryShader = multiview_features->multiviewGeometryShader;
527 multiviewTessellationShader = multiview_features->multiviewTessellationShader;
528 }
529 if ((multiview == VK_FALSE) && (multiviewGeometryShader == VK_TRUE)) {
530 skip |= LogError(instance, "VUID-VkPhysicalDeviceMultiviewFeatures-multiviewGeometryShader-00580",
531 "If multiviewGeometryShader is VK_TRUE then multiview also needs to be VK_TRUE");
532 }
533 if ((multiview == VK_FALSE) && (multiviewTessellationShader == VK_TRUE)) {
534 skip |= LogError(instance, "VUID-VkPhysicalDeviceMultiviewFeatures-multiviewTessellationShader-00581",
535 "If multiviewTessellationShader is VK_TRUE then multiview also needs to be VK_TRUE");
536 }
537
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600538 return skip;
539}
540
Jeff Bolz46c0ea02019-10-09 13:06:29 -0500541bool StatelessValidation::require_device_extension(bool flag, char const *function_name, char const *extension_name) const {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700542 if (!flag) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700543 return LogError(device, kVUID_PVError_ExtensionNotEnabled,
544 "%s() called even though the %s extension was not enabled for this VkDevice.", function_name,
545 extension_name);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600546 }
547
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700548 return false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600549}
550
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700551bool StatelessValidation::manual_PreCallValidateCreateBuffer(VkDevice device, const VkBufferCreateInfo *pCreateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -0500552 const VkAllocationCallbacks *pAllocator, VkBuffer *pBuffer) const {
Petr Krause91f7a12017-12-14 20:57:36 +0100553 bool skip = false;
554
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600555 if (pCreateInfo != nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700556 skip |=
557 ValidateGreaterThanZero(pCreateInfo->size, "pCreateInfo->size", "VUID-VkBufferCreateInfo-size-00912", "vkCreateBuffer");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600558
559 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
560 if (pCreateInfo->sharingMode == VK_SHARING_MODE_CONCURRENT) {
561 // If sharingMode is VK_SHARING_MODE_CONCURRENT, queueFamilyIndexCount must be greater than 1
562 if (pCreateInfo->queueFamilyIndexCount <= 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700563 skip |= LogError(device, "VUID-VkBufferCreateInfo-sharingMode-00914",
564 "vkCreateBuffer: if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
565 "pCreateInfo->queueFamilyIndexCount must be greater than 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600566 }
567
568 // If sharingMode is VK_SHARING_MODE_CONCURRENT, pQueueFamilyIndices must be a pointer to an array of
569 // queueFamilyIndexCount uint32_t values
570 if (pCreateInfo->pQueueFamilyIndices == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700571 skip |= LogError(device, "VUID-VkBufferCreateInfo-sharingMode-00913",
572 "vkCreateBuffer: if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
573 "pCreateInfo->pQueueFamilyIndices must be a pointer to an array of "
574 "pCreateInfo->queueFamilyIndexCount uint32_t values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600575 }
576 }
577
sfricke-samsung8f8cf052020-07-03 22:44:29 -0700578 if ((pCreateInfo->flags & VK_BUFFER_CREATE_SPARSE_BINDING_BIT) && (!physical_device_features.sparseBinding)) {
579 skip |= LogError(device, "VUID-VkBufferCreateInfo-flags-00915",
580 "vkCreateBuffer(): the sparseBinding device feature is disabled: Buffers cannot be created with the "
581 "VK_BUFFER_CREATE_SPARSE_BINDING_BIT set.");
582 }
583
584 if ((pCreateInfo->flags & VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT) && (!physical_device_features.sparseResidencyBuffer)) {
585 skip |=
586 LogError(device, "VUID-VkBufferCreateInfo-flags-00916",
587 "vkCreateBuffer(): the sparseResidencyBuffer device feature is disabled: Buffers cannot be created with "
588 "the VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT set.");
589 }
590
591 if ((pCreateInfo->flags & VK_BUFFER_CREATE_SPARSE_ALIASED_BIT) && (!physical_device_features.sparseResidencyAliased)) {
592 skip |=
593 LogError(device, "VUID-VkBufferCreateInfo-flags-00917",
594 "vkCreateBuffer(): the sparseResidencyAliased device feature is disabled: Buffers cannot be created with "
595 "the VK_BUFFER_CREATE_SPARSE_ALIASED_BIT set.");
596 }
597
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600598 // If flags contains VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT or VK_BUFFER_CREATE_SPARSE_ALIASED_BIT, it must also contain
599 // VK_BUFFER_CREATE_SPARSE_BINDING_BIT
600 if (((pCreateInfo->flags & (VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT | VK_BUFFER_CREATE_SPARSE_ALIASED_BIT)) != 0) &&
601 ((pCreateInfo->flags & VK_BUFFER_CREATE_SPARSE_BINDING_BIT) != VK_BUFFER_CREATE_SPARSE_BINDING_BIT)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700602 skip |= LogError(device, "VUID-VkBufferCreateInfo-flags-00918",
603 "vkCreateBuffer: if pCreateInfo->flags contains VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT or "
604 "VK_BUFFER_CREATE_SPARSE_ALIASED_BIT, it must also contain VK_BUFFER_CREATE_SPARSE_BINDING_BIT.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600605 }
606 }
607
608 return skip;
609}
610
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700611bool StatelessValidation::manual_PreCallValidateCreateImage(VkDevice device, const VkImageCreateInfo *pCreateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -0500612 const VkAllocationCallbacks *pAllocator, VkImage *pImage) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600613 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600614
615 if (pCreateInfo != nullptr) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600616 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
617 if (pCreateInfo->sharingMode == VK_SHARING_MODE_CONCURRENT) {
618 // If sharingMode is VK_SHARING_MODE_CONCURRENT, queueFamilyIndexCount must be greater than 1
619 if (pCreateInfo->queueFamilyIndexCount <= 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700620 skip |= LogError(device, "VUID-VkImageCreateInfo-sharingMode-00942",
621 "vkCreateImage(): if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
622 "pCreateInfo->queueFamilyIndexCount must be greater than 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600623 }
624
625 // If sharingMode is VK_SHARING_MODE_CONCURRENT, pQueueFamilyIndices must be a pointer to an array of
626 // queueFamilyIndexCount uint32_t values
627 if (pCreateInfo->pQueueFamilyIndices == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700628 skip |= LogError(device, "VUID-VkImageCreateInfo-sharingMode-00941",
629 "vkCreateImage(): if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
630 "pCreateInfo->pQueueFamilyIndices must be a pointer to an array of "
631 "pCreateInfo->queueFamilyIndexCount uint32_t values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600632 }
633 }
634
Dave Houlton413a6782018-05-22 13:01:54 -0600635 skip |= ValidateGreaterThanZero(pCreateInfo->extent.width, "pCreateInfo->extent.width",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700636 "VUID-VkImageCreateInfo-extent-00944", "vkCreateImage");
Dave Houlton413a6782018-05-22 13:01:54 -0600637 skip |= ValidateGreaterThanZero(pCreateInfo->extent.height, "pCreateInfo->extent.height",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700638 "VUID-VkImageCreateInfo-extent-00945", "vkCreateImage");
Dave Houlton413a6782018-05-22 13:01:54 -0600639 skip |= ValidateGreaterThanZero(pCreateInfo->extent.depth, "pCreateInfo->extent.depth",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700640 "VUID-VkImageCreateInfo-extent-00946", "vkCreateImage");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600641
Dave Houlton413a6782018-05-22 13:01:54 -0600642 skip |= ValidateGreaterThanZero(pCreateInfo->mipLevels, "pCreateInfo->mipLevels", "VUID-VkImageCreateInfo-mipLevels-00947",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700643 "vkCreateImage");
Dave Houlton413a6782018-05-22 13:01:54 -0600644 skip |= ValidateGreaterThanZero(pCreateInfo->arrayLayers, "pCreateInfo->arrayLayers",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700645 "VUID-VkImageCreateInfo-arrayLayers-00948", "vkCreateImage");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600646
Dave Houlton130c0212018-01-29 13:39:56 -0700647 // InitialLayout must be PREINITIALIZED or UNDEFINED
Dave Houltone19e20d2018-02-02 16:32:41 -0700648 if ((pCreateInfo->initialLayout != VK_IMAGE_LAYOUT_UNDEFINED) &&
649 (pCreateInfo->initialLayout != VK_IMAGE_LAYOUT_PREINITIALIZED)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700650 skip |= LogError(
651 device, "VUID-VkImageCreateInfo-initialLayout-00993",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600652 "vkCreateImage(): initialLayout is %s, must be VK_IMAGE_LAYOUT_UNDEFINED or VK_IMAGE_LAYOUT_PREINITIALIZED.",
653 string_VkImageLayout(pCreateInfo->initialLayout));
Dave Houlton130c0212018-01-29 13:39:56 -0700654 }
655
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600656 // If imageType is VK_IMAGE_TYPE_1D, both extent.height and extent.depth must be 1
Petr Kraus3ac9e812018-03-13 12:31:08 +0100657 if ((pCreateInfo->imageType == VK_IMAGE_TYPE_1D) &&
658 ((pCreateInfo->extent.height != 1) || (pCreateInfo->extent.depth != 1))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700659 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00956",
660 "vkCreateImage(): if pCreateInfo->imageType is VK_IMAGE_TYPE_1D, both pCreateInfo->extent.height and "
661 "pCreateInfo->extent.depth must be 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600662 }
663
664 if (pCreateInfo->imageType == VK_IMAGE_TYPE_2D) {
Petr Kraus3f433212018-03-13 12:31:27 +0100665 if (pCreateInfo->flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) {
666 if (pCreateInfo->extent.width != pCreateInfo->extent.height) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700667 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00954",
668 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT, but "
669 "pCreateInfo->extent.width (=%" PRIu32 ") and pCreateInfo->extent.height (=%" PRIu32
670 ") are not equal.",
671 pCreateInfo->extent.width, pCreateInfo->extent.height);
Petr Kraus3f433212018-03-13 12:31:27 +0100672 }
673
674 if (pCreateInfo->arrayLayers < 6) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700675 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00954",
676 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT, but "
677 "pCreateInfo->arrayLayers (=%" PRIu32 ") is not greater than or equal to 6.",
678 pCreateInfo->arrayLayers);
Petr Kraus3f433212018-03-13 12:31:27 +0100679 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600680 }
681
682 if (pCreateInfo->extent.depth != 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700683 skip |= LogError(
684 device, "VUID-VkImageCreateInfo-imageType-00957",
685 "vkCreateImage(): if pCreateInfo->imageType is VK_IMAGE_TYPE_2D, pCreateInfo->extent.depth must be 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600686 }
687 }
688
Dave Houlton130c0212018-01-29 13:39:56 -0700689 // 3D image may have only 1 layer
690 if ((pCreateInfo->imageType == VK_IMAGE_TYPE_3D) && (pCreateInfo->arrayLayers != 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700691 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00961",
692 "vkCreateImage(): if pCreateInfo->imageType is VK_IMAGE_TYPE_3D, pCreateInfo->arrayLayers must be 1.");
Dave Houlton130c0212018-01-29 13:39:56 -0700693 }
694
695 // If multi-sample, validate type, usage, tiling and mip levels.
696 if ((pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT) &&
697 ((pCreateInfo->imageType != VK_IMAGE_TYPE_2D) || (pCreateInfo->flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) ||
Shannon McPhersona886c2a2018-10-12 14:38:20 -0600698 (pCreateInfo->mipLevels != 1) || (pCreateInfo->tiling != VK_IMAGE_TILING_OPTIMAL))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700699 skip |= LogError(device, "VUID-VkImageCreateInfo-samples-02257",
700 "vkCreateImage(): Multi-sample image with incompatible type, usage, tiling, or mips.");
Dave Houlton130c0212018-01-29 13:39:56 -0700701 }
702
703 if (0 != (pCreateInfo->usage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT)) {
704 VkImageUsageFlags legal_flags = (VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT | VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT |
705 VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT);
706 // At least one of the legal attachment bits must be set
707 if (0 == (pCreateInfo->usage & legal_flags)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700708 skip |= LogError(device, "VUID-VkImageCreateInfo-usage-00966",
709 "vkCreateImage(): Transient attachment image without a compatible attachment flag set.");
Dave Houlton130c0212018-01-29 13:39:56 -0700710 }
711 // No flags other than the legal attachment bits may be set
712 legal_flags |= VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT;
713 if (0 != (pCreateInfo->usage & ~legal_flags)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700714 skip |= LogError(device, "VUID-VkImageCreateInfo-usage-00963",
715 "vkCreateImage(): Transient attachment image with incompatible usage flags set.");
Dave Houlton130c0212018-01-29 13:39:56 -0700716 }
717 }
718
Jeff Bolzef40fec2018-09-01 22:04:34 -0500719 // mipLevels must be less than or equal to the number of levels in the complete mipmap chain
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600720 uint32_t maxDim = std::max(std::max(pCreateInfo->extent.width, pCreateInfo->extent.height), pCreateInfo->extent.depth);
Jeff Bolzef40fec2018-09-01 22:04:34 -0500721 // Max mip levels is different for corner-sampled images vs normal images.
Dave Houlton142c4cb2018-10-17 15:04:41 -0600722 uint32_t maxMipLevels = (pCreateInfo->flags & VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV) ? (uint32_t)(ceil(log2(maxDim)))
723 : (uint32_t)(floor(log2(maxDim)) + 1);
Jeff Bolzef40fec2018-09-01 22:04:34 -0500724 if (maxDim > 0 && pCreateInfo->mipLevels > maxMipLevels) {
Dave Houlton413a6782018-05-22 13:01:54 -0600725 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700726 LogError(device, "VUID-VkImageCreateInfo-mipLevels-00958",
727 "vkCreateImage(): pCreateInfo->mipLevels must be less than or equal to "
728 "floor(log2(max(pCreateInfo->extent.width, pCreateInfo->extent.height, pCreateInfo->extent.depth)))+1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600729 }
730
Mark Lobodzinski69259c52018-09-18 15:14:58 -0600731 if ((pCreateInfo->flags & VK_IMAGE_CREATE_2D_ARRAY_COMPATIBLE_BIT) && (pCreateInfo->imageType != VK_IMAGE_TYPE_3D)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700732 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-00950",
733 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_2D_ARRAY_COMPATIBLE_BIT but "
734 "pCreateInfo->imageType is not VK_IMAGE_TYPE_3D.");
Mark Lobodzinski69259c52018-09-18 15:14:58 -0600735 }
736
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700737 if ((pCreateInfo->flags & VK_IMAGE_CREATE_SPARSE_BINDING_BIT) && (!physical_device_features.sparseBinding)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700738 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-00969",
739 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_SPARSE_BINDING_BIT, but the "
740 "VkPhysicalDeviceFeatures::sparseBinding feature is disabled.");
Petr Krausb6f97802018-03-13 12:31:39 +0100741 }
742
sfricke-samsung8f8cf052020-07-03 22:44:29 -0700743 if ((pCreateInfo->flags & VK_IMAGE_CREATE_SPARSE_ALIASED_BIT) && (!physical_device_features.sparseResidencyAliased)) {
744 skip |= LogError(
745 device, "VUID-VkImageCreateInfo-flags-01924",
746 "vkCreateImage(): the sparseResidencyAliased device feature is disabled: Images cannot be created with the "
747 "VK_IMAGE_CREATE_SPARSE_ALIASED_BIT set.");
748 }
749
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600750 // If flags contains VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT or VK_IMAGE_CREATE_SPARSE_ALIASED_BIT, it must also contain
751 // VK_IMAGE_CREATE_SPARSE_BINDING_BIT
752 if (((pCreateInfo->flags & (VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT | VK_IMAGE_CREATE_SPARSE_ALIASED_BIT)) != 0) &&
753 ((pCreateInfo->flags & VK_IMAGE_CREATE_SPARSE_BINDING_BIT) != VK_IMAGE_CREATE_SPARSE_BINDING_BIT)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700754 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-00987",
755 "vkCreateImage: if pCreateInfo->flags contains VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT or "
756 "VK_IMAGE_CREATE_SPARSE_ALIASED_BIT, it must also contain VK_IMAGE_CREATE_SPARSE_BINDING_BIT.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600757 }
758
759 // Check for combinations of attributes that are incompatible with having VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT set
760 if ((pCreateInfo->flags & VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT) != 0) {
761 // Linear tiling is unsupported
762 if (VK_IMAGE_TILING_LINEAR == pCreateInfo->tiling) {
sfricke-samsung9801d752020-08-23 22:00:16 -0700763 skip |= LogError(device, "VUID-VkImageCreateInfo-tiling-04121",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700764 "vkCreateImage: if pCreateInfo->flags contains VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT then image "
765 "tiling of VK_IMAGE_TILING_LINEAR is not supported");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600766 }
767
768 // Sparse 1D image isn't valid
769 if (VK_IMAGE_TYPE_1D == pCreateInfo->imageType) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700770 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00970",
771 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 1D image.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600772 }
773
774 // Sparse 2D image when device doesn't support it
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700775 if ((VK_FALSE == physical_device_features.sparseResidencyImage2D) && (VK_IMAGE_TYPE_2D == pCreateInfo->imageType)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700776 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00971",
777 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 2D image if corresponding "
778 "feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600779 }
780
781 // Sparse 3D image when device doesn't support it
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700782 if ((VK_FALSE == physical_device_features.sparseResidencyImage3D) && (VK_IMAGE_TYPE_3D == pCreateInfo->imageType)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700783 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00972",
784 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 3D image if corresponding "
785 "feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600786 }
787
788 // Multi-sample 2D image when device doesn't support it
789 if (VK_IMAGE_TYPE_2D == pCreateInfo->imageType) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700790 if ((VK_FALSE == physical_device_features.sparseResidency2Samples) &&
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600791 (VK_SAMPLE_COUNT_2_BIT == pCreateInfo->samples)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700792 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00973",
793 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 2-sample image if "
794 "corresponding feature is not enabled on the device.");
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700795 } else if ((VK_FALSE == physical_device_features.sparseResidency4Samples) &&
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600796 (VK_SAMPLE_COUNT_4_BIT == pCreateInfo->samples)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700797 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00974",
798 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 4-sample image if "
799 "corresponding feature is not enabled on the device.");
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700800 } else if ((VK_FALSE == physical_device_features.sparseResidency8Samples) &&
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600801 (VK_SAMPLE_COUNT_8_BIT == pCreateInfo->samples)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700802 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00975",
803 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 8-sample image if "
804 "corresponding feature is not enabled on the device.");
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700805 } else if ((VK_FALSE == physical_device_features.sparseResidency16Samples) &&
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600806 (VK_SAMPLE_COUNT_16_BIT == pCreateInfo->samples)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700807 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00976",
808 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 16-sample image if "
809 "corresponding feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600810 }
811 }
812 }
Jeff Bolzef40fec2018-09-01 22:04:34 -0500813
Jeff Bolz9af91c52018-09-01 21:53:57 -0500814 if (pCreateInfo->usage & VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV) {
815 if (pCreateInfo->imageType != VK_IMAGE_TYPE_2D) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700816 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-02082",
817 "vkCreateImage: if usage includes VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV, "
818 "imageType must be VK_IMAGE_TYPE_2D.");
Jeff Bolz9af91c52018-09-01 21:53:57 -0500819 }
820 if (pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700821 skip |= LogError(device, "VUID-VkImageCreateInfo-samples-02083",
822 "vkCreateImage: if usage includes VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV, "
823 "samples must be VK_SAMPLE_COUNT_1_BIT.");
Jeff Bolz9af91c52018-09-01 21:53:57 -0500824 }
825 if (pCreateInfo->tiling != VK_IMAGE_TILING_OPTIMAL) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700826 skip |= LogError(device, "VUID-VkImageCreateInfo-tiling-02084",
827 "vkCreateImage: if usage includes VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV, "
828 "tiling must be VK_IMAGE_TILING_OPTIMAL.");
Jeff Bolz9af91c52018-09-01 21:53:57 -0500829 }
830 }
Jeff Bolzef40fec2018-09-01 22:04:34 -0500831
832 if (pCreateInfo->flags & VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV) {
Dave Houlton142c4cb2018-10-17 15:04:41 -0600833 if (pCreateInfo->imageType != VK_IMAGE_TYPE_2D && pCreateInfo->imageType != VK_IMAGE_TYPE_3D) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700834 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02050",
835 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV, "
836 "imageType must be VK_IMAGE_TYPE_2D or VK_IMAGE_TYPE_3D.");
Jeff Bolzef40fec2018-09-01 22:04:34 -0500837 }
838
Dave Houlton142c4cb2018-10-17 15:04:41 -0600839 if ((pCreateInfo->flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) || FormatIsDepthOrStencil(pCreateInfo->format)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700840 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02051",
841 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV, "
842 "it must not also contain VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT and format must "
843 "not be a depth/stencil format.");
Jeff Bolzef40fec2018-09-01 22:04:34 -0500844 }
845
Dave Houlton142c4cb2018-10-17 15:04:41 -0600846 if (pCreateInfo->imageType == VK_IMAGE_TYPE_2D && (pCreateInfo->extent.width == 1 || pCreateInfo->extent.height == 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700847 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02052",
848 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV and "
849 "imageType is VK_IMAGE_TYPE_2D, extent.width and extent.height must be "
850 "greater than 1.");
Jeff Bolzb8a8dd02018-09-18 02:39:24 -0500851 } else if (pCreateInfo->imageType == VK_IMAGE_TYPE_3D &&
Dave Houlton142c4cb2018-10-17 15:04:41 -0600852 (pCreateInfo->extent.width == 1 || pCreateInfo->extent.height == 1 || pCreateInfo->extent.depth == 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700853 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02053",
854 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV and "
855 "imageType is VK_IMAGE_TYPE_3D, extent.width, extent.height, and extent.depth "
856 "must be greater than 1.");
Jeff Bolzef40fec2018-09-01 22:04:34 -0500857 }
858 }
Andrew Fobel3abeb992020-01-20 16:33:22 -0500859
sfricke-samsung8f658d42020-05-03 20:12:24 -0700860 if (((pCreateInfo->flags & VK_IMAGE_CREATE_SAMPLE_LOCATIONS_COMPATIBLE_DEPTH_BIT_EXT) != 0) &&
861 (FormatHasDepth(pCreateInfo->format) == false)) {
862 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-01533",
863 "vkCreateImage(): if flags contain VK_IMAGE_CREATE_SAMPLE_LOCATIONS_COMPATIBLE_DEPTH_BIT_EXT the "
864 "format must be a depth or depth/stencil format.");
865 }
866
Andrew Fobel3abeb992020-01-20 16:33:22 -0500867 const auto image_stencil_struct = lvl_find_in_chain<VkImageStencilUsageCreateInfoEXT>(pCreateInfo->pNext);
868 if (image_stencil_struct != nullptr) {
869 if ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT) != 0) {
870 VkImageUsageFlags legal_flags = (VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT | VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT);
871 // No flags other than the legal attachment bits may be set
872 legal_flags |= VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT;
873 if ((image_stencil_struct->stencilUsage & ~legal_flags) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700874 skip |= LogError(device, "VUID-VkImageStencilUsageCreateInfo-stencilUsage-02539",
875 "vkCreateImage(): in pNext chain, VkImageStencilUsageCreateInfo::stencilUsage includes "
876 "VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT, it must not include bits other than "
877 "VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT or VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT");
Andrew Fobel3abeb992020-01-20 16:33:22 -0500878 }
879 }
880
881 if (FormatIsDepthOrStencil(pCreateInfo->format)) {
882 if ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT) != 0) {
883 if (pCreateInfo->extent.width > device_limits.maxFramebufferWidth) {
884 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700885 LogError(device, "VUID-VkImageCreateInfo-Format-02536",
886 "vkCreateImage(): Depth-stencil image contains VkImageStencilUsageCreateInfo structure with "
887 "stencilUsage including VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT and image width exceeds device "
888 "maxFramebufferWidth");
Andrew Fobel3abeb992020-01-20 16:33:22 -0500889 }
890
891 if (pCreateInfo->extent.height > device_limits.maxFramebufferHeight) {
892 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700893 LogError(device, "VUID-VkImageCreateInfo-format-02537",
894 "vkCreateImage(): Depth-stencil image contains VkImageStencilUsageCreateInfo structure with "
895 "stencilUsage including VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT and image height exceeds device "
896 "maxFramebufferHeight");
Andrew Fobel3abeb992020-01-20 16:33:22 -0500897 }
898 }
899
900 if (!physical_device_features.shaderStorageImageMultisample &&
901 ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_STORAGE_BIT) != 0) &&
902 (pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT)) {
903 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700904 LogError(device, "VUID-VkImageCreateInfo-format-02538",
905 "vkCreateImage(): Depth-stencil image contains VkImageStencilUsageCreateInfo structure with "
906 "stencilUsage including VK_IMAGE_USAGE_STORAGE_BIT and the multisampled storage images feature is "
907 "not enabled, image samples must be VK_SAMPLE_COUNT_1_BIT");
Andrew Fobel3abeb992020-01-20 16:33:22 -0500908 }
909
910 if (((pCreateInfo->usage & VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT) != 0) &&
911 ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT) == 0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700912 skip |= LogError(
913 device, "VUID-VkImageCreateInfo-format-02795",
Andrew Fobel3abeb992020-01-20 16:33:22 -0500914 "vkCreateImage(): Depth-stencil image in which usage includes VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT "
915 "contains VkImageStencilUsageCreateInfo structure, VkImageStencilUsageCreateInfo::stencilUsage must "
916 "also include VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT");
917 } else if (((pCreateInfo->usage & VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT) == 0) &&
918 ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT) != 0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700919 skip |= LogError(
920 device, "VUID-VkImageCreateInfo-format-02796",
Andrew Fobel3abeb992020-01-20 16:33:22 -0500921 "vkCreateImage(): Depth-stencil image in which usage does not include "
922 "VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT "
923 "contains VkImageStencilUsageCreateInfo structure, VkImageStencilUsageCreateInfo::stencilUsage must "
924 "also not include VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT");
925 }
926
927 if (((pCreateInfo->usage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT) != 0) &&
928 ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT) == 0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700929 skip |= LogError(
930 device, "VUID-VkImageCreateInfo-format-02797",
Andrew Fobel3abeb992020-01-20 16:33:22 -0500931 "vkCreateImage(): Depth-stencil image in which usage includes VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT "
932 "contains VkImageStencilUsageCreateInfo structure, VkImageStencilUsageCreateInfo::stencilUsage must "
933 "also include VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT");
934 } else if (((pCreateInfo->usage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT) == 0) &&
935 ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT) != 0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700936 skip |= LogError(
937 device, "VUID-VkImageCreateInfo-format-02798",
Andrew Fobel3abeb992020-01-20 16:33:22 -0500938 "vkCreateImage(): Depth-stencil image in which usage does not include "
939 "VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT "
940 "contains VkImageStencilUsageCreateInfo structure, VkImageStencilUsageCreateInfo::stencilUsage must "
941 "also not include VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT");
942 }
943 }
944 }
Spencer Frickeca52b5c2020-03-16 17:34:00 -0700945
946 if ((!physical_device_features.shaderStorageImageMultisample) && ((pCreateInfo->usage & VK_IMAGE_USAGE_STORAGE_BIT) != 0) &&
947 (pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT)) {
948 skip |= LogError(device, "VUID-VkImageCreateInfo-usage-00968",
949 "vkCreateImage(): usage contains VK_IMAGE_USAGE_STORAGE_BIT and the multisampled storage images "
950 "feature is not enabled, image samples must be VK_SAMPLE_COUNT_1_BIT");
951 }
Spencer Fricke6f8b8ac2020-04-06 07:36:50 -0700952
953 if (device_extensions.vk_ext_image_drm_format_modifier) {
954 const auto drm_format_mod_list = lvl_find_in_chain<VkImageDrmFormatModifierListCreateInfoEXT>(pCreateInfo->pNext);
955 const auto drm_format_mod_explict =
956 lvl_find_in_chain<VkImageDrmFormatModifierExplicitCreateInfoEXT>(pCreateInfo->pNext);
957 if (pCreateInfo->tiling == VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT) {
958 if (((drm_format_mod_list != nullptr) && (drm_format_mod_explict != nullptr)) ||
959 ((drm_format_mod_list == nullptr) && (drm_format_mod_explict == nullptr))) {
960 skip |= LogError(device, "VUID-VkImageCreateInfo-tiling-02261",
961 "vkCreateImage(): Tiling is VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT but pNext must have "
962 "either VkImageDrmFormatModifierListCreateInfoEXT or "
963 "VkImageDrmFormatModifierExplicitCreateInfoEXT in the pNext chain");
964 }
965 } else if ((drm_format_mod_list != nullptr) || (drm_format_mod_explict != nullptr)) {
966 skip |= LogError(device, "VUID-VkImageCreateInfo-pNext-02262",
967 "vkCreateImage(): Tiling is not VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT but there is a "
968 "VkImageDrmFormatModifierListCreateInfoEXT or VkImageDrmFormatModifierExplicitCreateInfoEXT "
969 "in the pNext chain");
970 }
971 }
janharaldfredriksen-arm3b793772020-05-12 18:55:53 +0200972
973 if (pCreateInfo->usage & VK_IMAGE_USAGE_FRAGMENT_DENSITY_MAP_BIT_EXT) {
974 if (pCreateInfo->imageType != VK_IMAGE_TYPE_2D) {
975 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02557",
976 "vkCreateImage: if usage includes VK_IMAGE_USAGE_FRAGMENT_DENSITY_MAP_BIT_EXT, "
977 "imageType must be VK_IMAGE_TYPE_2D.");
978 }
979 if (pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT) {
980 skip |= LogError(device, "VUID-VkImageCreateInfo-samples-02558",
981 "vkCreateImage: if usage includes VK_IMAGE_USAGE_FRAGMENT_DENSITY_MAP_BIT_EXT, "
982 "samples must be VK_SAMPLE_COUNT_1_BIT.");
983 }
984 if (pCreateInfo->tiling != VK_IMAGE_TILING_OPTIMAL) {
985 skip |= LogError(device, "VUID-VkImageCreateInfo-tiling-02084",
986 "vkCreateImage: if usage includes VK_IMAGE_USAGE_FRAGMENT_DENSITY_MAP_BIT_EXT, "
987 "tiling must be VK_IMAGE_TILING_OPTIMAL.");
988 }
989 }
990 if (pCreateInfo->flags & VK_IMAGE_CREATE_SUBSAMPLED_BIT_EXT) {
991 if (pCreateInfo->tiling != VK_IMAGE_TILING_OPTIMAL) {
992 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02565",
993 "vkCreateImage: if usage includes VK_IMAGE_CREATE_SUBSAMPLED_BIT_EXT, "
994 "tiling must be VK_IMAGE_TILING_OPTIMAL.");
995 }
996 if (pCreateInfo->imageType != VK_IMAGE_TYPE_2D) {
997 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02566",
998 "vkCreateImage: if flags includes VK_IMAGE_CREATE_SUBSAMPLED_BIT_EXT, "
999 "imageType must be VK_IMAGE_TYPE_2D.");
1000 }
1001 if (pCreateInfo->flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) {
1002 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02567",
1003 "vkCreateImage: if flags includes VK_IMAGE_CREATE_SUBSAMPLED_BIT_EXT, "
1004 "flags must not include VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT.");
1005 }
1006 if (pCreateInfo->mipLevels != 1) {
1007 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02568",
1008 "vkCreateImage: if flags includes VK_IMAGE_CREATE_SUBSAMPLED_BIT_EXT, mipLevels (%d) must be 1.",
1009 pCreateInfo->mipLevels);
1010 }
1011 }
sfricke-samsungddaf72b2020-06-23 21:39:28 -07001012
1013 const auto swapchain_create_info = lvl_find_in_chain<VkImageSwapchainCreateInfoKHR>(pCreateInfo->pNext);
1014 if (swapchain_create_info != nullptr) {
1015 if (swapchain_create_info->swapchain != VK_NULL_HANDLE) {
1016 // All the following fall under the same VU that checks that the swapchain image uses parameters limited by the
1017 // table in #swapchain-wsi-image-create-info. Breaking up into multiple checks allows for more useful information
1018 // returned why this error occured. Check for matching Swapchain flags is done later in state tracking validation
1019 const char *vuid = "VUID-VkImageSwapchainCreateInfoKHR-swapchain-00995";
1020 const char *base_message = "vkCreateImage(): The image used for creating a presentable swapchain image";
1021
1022 if (pCreateInfo->imageType != VK_IMAGE_TYPE_2D) {
1023 // also implicitly forces the check above that extent.depth is 1
1024 skip |= LogError(device, vuid, "%s must have a imageType value VK_IMAGE_TYPE_2D instead of %s.", base_message,
1025 string_VkImageType(pCreateInfo->imageType));
1026 }
1027 if (pCreateInfo->mipLevels != 1) {
1028 skip |= LogError(device, vuid, "%s must have a mipLevels value of 1 instead of %u.", base_message,
1029 pCreateInfo->mipLevels);
1030 }
1031 if (pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT) {
1032 skip |= LogError(device, vuid, "%s must have a samples value of VK_SAMPLE_COUNT_1_BIT instead of %s.",
1033 base_message, string_VkSampleCountFlagBits(pCreateInfo->samples));
1034 }
1035 if (pCreateInfo->tiling != VK_IMAGE_TILING_OPTIMAL) {
1036 skip |= LogError(device, vuid, "%s must have a tiling value of VK_IMAGE_TILING_OPTIMAL instead of %s.",
1037 base_message, string_VkImageTiling(pCreateInfo->tiling));
1038 }
1039 if (pCreateInfo->initialLayout != VK_IMAGE_LAYOUT_UNDEFINED) {
1040 skip |= LogError(device, vuid, "%s must have a initialLayout value of VK_IMAGE_LAYOUT_UNDEFINED instead of %s.",
1041 base_message, string_VkImageLayout(pCreateInfo->initialLayout));
1042 }
1043 const VkImageCreateFlags valid_flags =
1044 (VK_IMAGE_CREATE_SPLIT_INSTANCE_BIND_REGIONS_BIT | VK_IMAGE_CREATE_PROTECTED_BIT |
1045 VK_IMAGE_CREATE_MUTABLE_FORMAT_BIT | VK_IMAGE_CREATE_EXTENDED_USAGE_BIT_KHR);
1046 if ((pCreateInfo->flags & ~valid_flags) != 0) {
1047 skip |= LogError(device, vuid, "%s flags are %" PRIu32 "and must only have valid flags set.", base_message,
1048 pCreateInfo->flags);
1049 }
1050 }
1051 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001052 }
Jeff Bolzef40fec2018-09-01 22:04:34 -05001053
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001054 return skip;
1055}
1056
Jeff Bolz99e3f632020-03-24 22:59:22 -05001057bool StatelessValidation::manual_PreCallValidateCreateImageView(VkDevice device, const VkImageViewCreateInfo *pCreateInfo,
1058 const VkAllocationCallbacks *pAllocator, VkImageView *pView) const {
1059 bool skip = false;
1060
1061 if (pCreateInfo != nullptr) {
Spencer Fricke528e0982020-04-19 18:46:01 -07001062 // Validate feature set if using CUBE_ARRAY
1063 if ((pCreateInfo->viewType == VK_IMAGE_VIEW_TYPE_CUBE_ARRAY) && (physical_device_features.imageCubeArray == false)) {
1064 skip |= LogError(pCreateInfo->image, "VUID-VkImageViewCreateInfo-viewType-01004",
1065 "vkCreateImageView(): pCreateInfo->viewType can't be VK_IMAGE_VIEW_TYPE_CUBE_ARRAY without "
1066 "enabling the imageCubeArray feature.");
1067 }
1068
Jeff Bolz99e3f632020-03-24 22:59:22 -05001069 if (pCreateInfo->subresourceRange.layerCount != VK_REMAINING_ARRAY_LAYERS) {
1070 if (pCreateInfo->viewType == VK_IMAGE_VIEW_TYPE_CUBE && pCreateInfo->subresourceRange.layerCount != 6) {
1071 skip |= LogError(device, "VUID-VkImageViewCreateInfo-viewType-02960",
Spencer Fricke528e0982020-04-19 18:46:01 -07001072 "vkCreateImageView(): subresourceRange.layerCount (%d) must be 6 or VK_REMAINING_ARRAY_LAYERS.",
Jeff Bolz99e3f632020-03-24 22:59:22 -05001073 pCreateInfo->subresourceRange.layerCount);
1074 }
1075 if (pCreateInfo->viewType == VK_IMAGE_VIEW_TYPE_CUBE_ARRAY && (pCreateInfo->subresourceRange.layerCount % 6) != 0) {
Spencer Fricke528e0982020-04-19 18:46:01 -07001076 skip |= LogError(
1077 device, "VUID-VkImageViewCreateInfo-viewType-02961",
1078 "vkCreateImageView(): subresourceRange.layerCount (%d) must be a multiple of 6 or VK_REMAINING_ARRAY_LAYERS.",
1079 pCreateInfo->subresourceRange.layerCount);
Jeff Bolz99e3f632020-03-24 22:59:22 -05001080 }
1081 }
sfricke-samsung0c4a06f2020-06-27 01:24:32 -07001082
1083 auto astc_decode_mode = lvl_find_in_chain<VkImageViewASTCDecodeModeEXT>(pCreateInfo->pNext);
1084 if ((device_extensions.vk_ext_astc_decode_mode) && (astc_decode_mode != nullptr)) {
1085 if ((astc_decode_mode->decodeMode != VK_FORMAT_R16G16B16A16_SFLOAT) &&
1086 (astc_decode_mode->decodeMode != VK_FORMAT_R8G8B8A8_UNORM) &&
1087 (astc_decode_mode->decodeMode != VK_FORMAT_E5B9G9R9_UFLOAT_PACK32)) {
1088 skip |= LogError(device, "VUID-VkImageViewASTCDecodeModeEXT-decodeMode-02230",
1089 "vkCreateImageView(): VkImageViewASTCDecodeModeEXT::decodeMode must be "
1090 "VK_FORMAT_R16G16B16A16_SFLOAT, VK_FORMAT_R8G8B8A8_UNORM, or VK_FORMAT_E5B9G9R9_UFLOAT_PACK32.");
1091 }
1092 if (FormatIsCompressed_ASTC(pCreateInfo->format) == false) {
1093 skip |= LogError(device, "VUID-VkImageViewASTCDecodeModeEXT-format-04084",
1094 "vkCreateImageView(): is using a VkImageViewASTCDecodeModeEXT but the image view format is %s and "
1095 "not an ASTC format.",
1096 string_VkFormat(pCreateInfo->format));
1097 }
1098 }
sfricke-samsung83d98122020-07-04 06:21:15 -07001099
1100 auto ycbcr_conversion = lvl_find_in_chain<VkSamplerYcbcrConversionInfo>(pCreateInfo->pNext);
1101 if (ycbcr_conversion != nullptr) {
1102 if (ycbcr_conversion->conversion != VK_NULL_HANDLE) {
1103 if (IsIdentitySwizzle(pCreateInfo->components) == false) {
1104 skip |= LogError(
1105 device, "VUID-VkImageViewCreateInfo-pNext-01970",
1106 "vkCreateImageView(): If there is a VkSamplerYcbcrConversion, the imageView must "
1107 "be created with the identity swizzle. Here are the actual swizzle values:\n"
1108 "r swizzle = %s\n"
1109 "g swizzle = %s\n"
1110 "b swizzle = %s\n"
1111 "a swizzle = %s\n",
1112 string_VkComponentSwizzle(pCreateInfo->components.r), string_VkComponentSwizzle(pCreateInfo->components.g),
1113 string_VkComponentSwizzle(pCreateInfo->components.b), string_VkComponentSwizzle(pCreateInfo->components.a));
1114 }
1115 }
1116 }
Jeff Bolz99e3f632020-03-24 22:59:22 -05001117 }
1118 return skip;
1119}
1120
Jeff Bolz6d3beaa2019-02-09 21:00:05 -06001121bool StatelessValidation::manual_PreCallValidateViewport(const VkViewport &viewport, const char *fn_name,
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001122 const ParameterName &parameter_name, VkCommandBuffer object) const {
Petr Krausb3fcdb42018-01-09 22:09:09 +01001123 bool skip = false;
Petr Krausb3fcdb42018-01-09 22:09:09 +01001124
1125 // Note: for numerical correctness
1126 // - float comparisons should expect NaN (comparison always false).
1127 // - VkPhysicalDeviceLimits::maxViewportDimensions is uint32_t, not float -> careful.
1128
1129 const auto f_lte_u32_exact = [](const float v1_f, const uint32_t v2_u32) {
John Zulaufac0876c2018-02-19 10:09:35 -07001130 if (std::isnan(v1_f)) return false;
Petr Krausb3fcdb42018-01-09 22:09:09 +01001131 if (v1_f <= 0.0f) return true;
1132
1133 float intpart;
1134 const float fract = modff(v1_f, &intpart);
1135
1136 assert(std::numeric_limits<float>::radix == 2);
1137 const float u32_max_plus1 = ldexpf(1.0f, 32); // hopefully exact
1138 if (intpart >= u32_max_plus1) return false;
1139
1140 uint32_t v1_u32 = static_cast<uint32_t>(intpart);
1141 if (v1_u32 < v2_u32)
1142 return true;
1143 else if (v1_u32 == v2_u32 && fract == 0.0f)
1144 return true;
1145 else
1146 return false;
1147 };
1148
1149 const auto f_lte_u32_direct = [](const float v1_f, const uint32_t v2_u32) {
1150 const float v2_f = static_cast<float>(v2_u32); // not accurate for > radix^digits; and undefined rounding mode
1151 return (v1_f <= v2_f);
1152 };
1153
1154 // width
1155 bool width_healthy = true;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001156 const auto max_w = device_limits.maxViewportDimensions[0];
Petr Krausb3fcdb42018-01-09 22:09:09 +01001157
1158 if (!(viewport.width > 0.0f)) {
1159 width_healthy = false;
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001160 skip |= LogError(object, "VUID-VkViewport-width-01770", "%s: %s.width (=%f) is not greater than 0.0.", fn_name,
1161 parameter_name.get_name().c_str(), viewport.width);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001162 } else if (!(f_lte_u32_exact(viewport.width, max_w) || f_lte_u32_direct(viewport.width, max_w))) {
1163 width_healthy = false;
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001164 skip |= LogError(object, "VUID-VkViewport-width-01771",
1165 "%s: %s.width (=%f) exceeds VkPhysicalDeviceLimits::maxViewportDimensions[0] (=%" PRIu32 ").", fn_name,
1166 parameter_name.get_name().c_str(), viewport.width, max_w);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001167 } else if (!f_lte_u32_exact(viewport.width, max_w) && f_lte_u32_direct(viewport.width, max_w)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001168 skip |= LogWarning(object, kVUID_PVError_NONE,
1169 "%s: %s.width (=%f) technically exceeds VkPhysicalDeviceLimits::maxViewportDimensions[0] (=%" PRIu32
1170 "), but it is within the static_cast<float>(maxViewportDimensions[0]) limit.",
1171 fn_name, parameter_name.get_name().c_str(), viewport.width, max_w);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001172 }
1173
1174 // height
1175 bool height_healthy = true;
Mark Lobodzinskia09ab942020-02-20 11:01:59 -07001176 const bool negative_height_enabled = device_extensions.vk_khr_maintenance1 || device_extensions.vk_amd_negative_viewport_height;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001177 const auto max_h = device_limits.maxViewportDimensions[1];
Petr Krausb3fcdb42018-01-09 22:09:09 +01001178
1179 if (!negative_height_enabled && !(viewport.height > 0.0f)) {
1180 height_healthy = false;
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001181 skip |= LogError(object, "VUID-VkViewport-height-01772", "%s: %s.height (=%f) is not greater 0.0.", fn_name,
1182 parameter_name.get_name().c_str(), viewport.height);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001183 } else if (!(f_lte_u32_exact(fabsf(viewport.height), max_h) || f_lte_u32_direct(fabsf(viewport.height), max_h))) {
1184 height_healthy = false;
1185
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001186 skip |= LogError(object, "VUID-VkViewport-height-01773",
1187 "%s: Absolute value of %s.height (=%f) exceeds VkPhysicalDeviceLimits::maxViewportDimensions[1] (=%" PRIu32
1188 ").",
1189 fn_name, parameter_name.get_name().c_str(), viewport.height, max_h);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001190 } else if (!f_lte_u32_exact(fabsf(viewport.height), max_h) && f_lte_u32_direct(fabsf(viewport.height), max_h)) {
1191 height_healthy = false;
1192
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001193 skip |= LogWarning(
1194 object, kVUID_PVError_NONE,
Petr Krausb3fcdb42018-01-09 22:09:09 +01001195 "%s: Absolute value of %s.height (=%f) technically exceeds VkPhysicalDeviceLimits::maxViewportDimensions[1] (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001196 "), but it is within the static_cast<float>(maxViewportDimensions[1]) limit.",
Jeff Bolz6d3beaa2019-02-09 21:00:05 -06001197 fn_name, parameter_name.get_name().c_str(), viewport.height, max_h);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001198 }
1199
1200 // x
1201 bool x_healthy = true;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001202 if (!(viewport.x >= device_limits.viewportBoundsRange[0])) {
Petr Krausb3fcdb42018-01-09 22:09:09 +01001203 x_healthy = false;
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001204 skip |= LogError(object, "VUID-VkViewport-x-01774",
1205 "%s: %s.x (=%f) is less than VkPhysicalDeviceLimits::viewportBoundsRange[0] (=%f).", fn_name,
1206 parameter_name.get_name().c_str(), viewport.x, device_limits.viewportBoundsRange[0]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001207 }
1208
1209 // x + width
1210 if (x_healthy && width_healthy) {
1211 const float right_bound = viewport.x + viewport.width;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001212 if (!(right_bound <= device_limits.viewportBoundsRange[1])) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001213 skip |= LogError(
1214 object, "VUID-VkViewport-x-01232",
1215 "%s: %s.x + %s.width (=%f + %f = %f) is greater than VkPhysicalDeviceLimits::viewportBoundsRange[1] (=%f).",
1216 fn_name, parameter_name.get_name().c_str(), parameter_name.get_name().c_str(), viewport.x, viewport.width,
1217 right_bound, device_limits.viewportBoundsRange[1]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001218 }
1219 }
1220
1221 // y
1222 bool y_healthy = true;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001223 if (!(viewport.y >= device_limits.viewportBoundsRange[0])) {
Petr Krausb3fcdb42018-01-09 22:09:09 +01001224 y_healthy = false;
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001225 skip |= LogError(object, "VUID-VkViewport-y-01775",
1226 "%s: %s.y (=%f) is less than VkPhysicalDeviceLimits::viewportBoundsRange[0] (=%f).", fn_name,
1227 parameter_name.get_name().c_str(), viewport.y, device_limits.viewportBoundsRange[0]);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001228 } else if (negative_height_enabled && !(viewport.y <= device_limits.viewportBoundsRange[1])) {
Petr Krausb3fcdb42018-01-09 22:09:09 +01001229 y_healthy = false;
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001230 skip |= LogError(object, "VUID-VkViewport-y-01776",
1231 "%s: %s.y (=%f) exceeds VkPhysicalDeviceLimits::viewportBoundsRange[1] (=%f).", fn_name,
1232 parameter_name.get_name().c_str(), viewport.y, device_limits.viewportBoundsRange[1]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001233 }
1234
1235 // y + height
1236 if (y_healthy && height_healthy) {
1237 const float boundary = viewport.y + viewport.height;
1238
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001239 if (!(boundary <= device_limits.viewportBoundsRange[1])) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001240 skip |= LogError(object, "VUID-VkViewport-y-01233",
1241 "%s: %s.y + %s.height (=%f + %f = %f) exceeds VkPhysicalDeviceLimits::viewportBoundsRange[1] (=%f).",
1242 fn_name, parameter_name.get_name().c_str(), parameter_name.get_name().c_str(), viewport.y,
1243 viewport.height, boundary, device_limits.viewportBoundsRange[1]);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001244 } else if (negative_height_enabled && !(boundary >= device_limits.viewportBoundsRange[0])) {
Jeff Bolz6d3beaa2019-02-09 21:00:05 -06001245 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001246 LogError(object, "VUID-VkViewport-y-01777",
1247 "%s: %s.y + %s.height (=%f + %f = %f) is less than VkPhysicalDeviceLimits::viewportBoundsRange[0] (=%f).",
1248 fn_name, parameter_name.get_name().c_str(), parameter_name.get_name().c_str(), viewport.y, viewport.height,
1249 boundary, device_limits.viewportBoundsRange[0]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001250 }
1251 }
1252
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001253 if (!device_extensions.vk_ext_depth_range_unrestricted) {
Petr Krausb3fcdb42018-01-09 22:09:09 +01001254 // minDepth
1255 if (!(viewport.minDepth >= 0.0) || !(viewport.minDepth <= 1.0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001256 skip |= LogError(object, "VUID-VkViewport-minDepth-01234",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001257
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001258 "%s: VK_EXT_depth_range_unrestricted extension is not enabled and %s.minDepth (=%f) is not within the "
1259 "[0.0, 1.0] range.",
1260 fn_name, parameter_name.get_name().c_str(), viewport.minDepth);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001261 }
1262
1263 // maxDepth
1264 if (!(viewport.maxDepth >= 0.0) || !(viewport.maxDepth <= 1.0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001265 skip |= LogError(object, "VUID-VkViewport-maxDepth-01235",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001266
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001267 "%s: VK_EXT_depth_range_unrestricted extension is not enabled and %s.maxDepth (=%f) is not within the "
1268 "[0.0, 1.0] range.",
1269 fn_name, parameter_name.get_name().c_str(), viewport.maxDepth);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001270 }
1271 }
1272
1273 return skip;
1274}
1275
Dave Houlton142c4cb2018-10-17 15:04:41 -06001276struct SampleOrderInfo {
Jeff Bolz9af91c52018-09-01 21:53:57 -05001277 VkShadingRatePaletteEntryNV shadingRate;
1278 uint32_t width;
1279 uint32_t height;
1280};
1281
1282// All palette entries with more than one pixel per fragment
Dave Houlton142c4cb2018-10-17 15:04:41 -06001283static SampleOrderInfo sampleOrderInfos[] = {
1284 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_1X2_PIXELS_NV, 1, 2},
1285 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_2X1_PIXELS_NV, 2, 1},
1286 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_2X2_PIXELS_NV, 2, 2},
1287 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_4X2_PIXELS_NV, 4, 2},
1288 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_2X4_PIXELS_NV, 2, 4},
1289 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_4X4_PIXELS_NV, 4, 4},
Jeff Bolz9af91c52018-09-01 21:53:57 -05001290};
1291
Jeff Bolz46c0ea02019-10-09 13:06:29 -05001292bool StatelessValidation::ValidateCoarseSampleOrderCustomNV(const VkCoarseSampleOrderCustomNV *order) const {
Jeff Bolz9af91c52018-09-01 21:53:57 -05001293 bool skip = false;
Jeff Bolz9af91c52018-09-01 21:53:57 -05001294
Jeff Bolz45bf7d62018-09-18 15:39:58 -05001295 SampleOrderInfo *sampleOrderInfo;
Jeff Bolz9af91c52018-09-01 21:53:57 -05001296 uint32_t infoIdx = 0;
Jeff Bolz45bf7d62018-09-18 15:39:58 -05001297 for (sampleOrderInfo = nullptr; infoIdx < ARRAY_SIZE(sampleOrderInfos); ++infoIdx) {
Jeff Bolz9af91c52018-09-01 21:53:57 -05001298 if (sampleOrderInfos[infoIdx].shadingRate == order->shadingRate) {
Jeff Bolzb8a8dd02018-09-18 02:39:24 -05001299 sampleOrderInfo = &sampleOrderInfos[infoIdx];
Jeff Bolz9af91c52018-09-01 21:53:57 -05001300 break;
1301 }
1302 }
1303
Jeff Bolzb8a8dd02018-09-18 02:39:24 -05001304 if (sampleOrderInfo == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001305 skip |= LogError(device, "VUID-VkCoarseSampleOrderCustomNV-shadingRate-02073",
1306 "VkCoarseSampleOrderCustomNV shadingRate must be a shading rate "
1307 "that generates fragments with more than one pixel.");
Jeff Bolz9af91c52018-09-01 21:53:57 -05001308 return skip;
1309 }
1310
Dave Houlton142c4cb2018-10-17 15:04:41 -06001311 if (order->sampleCount == 0 || (order->sampleCount & (order->sampleCount - 1)) ||
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001312 !(order->sampleCount & device_limits.framebufferNoAttachmentsSampleCounts)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001313 skip |= LogError(device, "VUID-VkCoarseSampleOrderCustomNV-sampleCount-02074",
1314 "VkCoarseSampleOrderCustomNV sampleCount (=%" PRIu32
1315 ") must "
1316 "correspond to a sample count enumerated in VkSampleCountFlags whose corresponding bit "
1317 "is set in framebufferNoAttachmentsSampleCounts.",
1318 order->sampleCount);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001319 }
1320
Jeff Bolz9af91c52018-09-01 21:53:57 -05001321 if (order->sampleLocationCount != order->sampleCount * sampleOrderInfo->width * sampleOrderInfo->height) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001322 skip |= LogError(device, "VUID-VkCoarseSampleOrderCustomNV-sampleLocationCount-02075",
1323 "VkCoarseSampleOrderCustomNV sampleLocationCount (=%" PRIu32
1324 ") must "
1325 "be equal to the product of sampleCount (=%" PRIu32
1326 "), the fragment width for shadingRate "
1327 "(=%" PRIu32 "), and the fragment height for shadingRate (=%" PRIu32 ").",
1328 order->sampleLocationCount, order->sampleCount, sampleOrderInfo->width, sampleOrderInfo->height);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001329 }
1330
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001331 if (order->sampleLocationCount > phys_dev_ext_props.shading_rate_image_props.shadingRateMaxCoarseSamples) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001332 skip |= LogError(
1333 device, "VUID-VkCoarseSampleOrderCustomNV-sampleLocationCount-02076",
Dave Houlton142c4cb2018-10-17 15:04:41 -06001334 "VkCoarseSampleOrderCustomNV sampleLocationCount (=%" PRIu32
1335 ") must "
1336 "be less than or equal to VkPhysicalDeviceShadingRateImagePropertiesNV shadingRateMaxCoarseSamples (=%" PRIu32 ").",
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001337 order->sampleLocationCount, phys_dev_ext_props.shading_rate_image_props.shadingRateMaxCoarseSamples);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001338 }
Jeff Bolz9af91c52018-09-01 21:53:57 -05001339
1340 // Accumulate a bitmask tracking which (x,y,sample) tuples are seen. Expect
Jeff Bolzb8a8dd02018-09-18 02:39:24 -05001341 // the first width*height*sampleCount bits to all be set. Note: There is no
1342 // guarantee that 64 bits is enough, but practically it's unlikely for an
1343 // implementation to support more than 32 bits for samplemask.
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001344 assert(phys_dev_ext_props.shading_rate_image_props.shadingRateMaxCoarseSamples <= 64);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001345 uint64_t sampleLocationsMask = 0;
1346 for (uint32_t i = 0; i < order->sampleLocationCount; ++i) {
1347 const VkCoarseSampleLocationNV *sampleLoc = &order->pSampleLocations[i];
1348 if (sampleLoc->pixelX >= sampleOrderInfo->width) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001349 skip |= LogError(device, "VUID-VkCoarseSampleLocationNV-pixelX-02078",
1350 "pixelX must be less than the width (in pixels) of the fragment.");
Jeff Bolz9af91c52018-09-01 21:53:57 -05001351 }
1352 if (sampleLoc->pixelY >= sampleOrderInfo->height) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001353 skip |= LogError(device, "VUID-VkCoarseSampleLocationNV-pixelY-02079",
1354 "pixelY must be less than the height (in pixels) of the fragment.");
Jeff Bolz9af91c52018-09-01 21:53:57 -05001355 }
1356 if (sampleLoc->sample >= order->sampleCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001357 skip |= LogError(device, "VUID-VkCoarseSampleLocationNV-sample-02080",
1358 "sample must be less than the number of coverage samples in each pixel belonging to the fragment.");
Jeff Bolz9af91c52018-09-01 21:53:57 -05001359 }
1360 uint32_t idx = sampleLoc->sample + order->sampleCount * (sampleLoc->pixelX + sampleOrderInfo->width * sampleLoc->pixelY);
1361 sampleLocationsMask |= 1ULL << idx;
1362 }
1363
1364 uint64_t expectedMask = (order->sampleLocationCount == 64) ? ~0ULL : ((1ULL << order->sampleLocationCount) - 1);
1365 if (sampleLocationsMask != expectedMask) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001366 skip |= LogError(
1367 device, "VUID-VkCoarseSampleOrderCustomNV-pSampleLocations-02077",
Dave Houlton142c4cb2018-10-17 15:04:41 -06001368 "The array pSampleLocations must contain exactly one entry for "
1369 "every combination of valid values for pixelX, pixelY, and sample in the structure VkCoarseSampleOrderCustomNV.");
Jeff Bolz9af91c52018-09-01 21:53:57 -05001370 }
1371
1372 return skip;
1373}
1374
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07001375bool StatelessValidation::manual_PreCallValidateCreateGraphicsPipelines(VkDevice device, VkPipelineCache pipelineCache,
1376 uint32_t createInfoCount,
1377 const VkGraphicsPipelineCreateInfo *pCreateInfos,
1378 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05001379 VkPipeline *pPipelines) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001380 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001381
1382 if (pCreateInfos != nullptr) {
1383 for (uint32_t i = 0; i < createInfoCount; ++i) {
Petr Kraus299ba622017-11-24 03:09:03 +01001384 bool has_dynamic_viewport = false;
1385 bool has_dynamic_scissor = false;
1386 bool has_dynamic_line_width = false;
Spencer Fricke8d428882020-03-16 17:23:33 -07001387 bool has_dynamic_depth_bias = false;
1388 bool has_dynamic_blend_constant = false;
1389 bool has_dynamic_depth_bounds = false;
1390 bool has_dynamic_stencil_compare = false;
1391 bool has_dynamic_stencil_write = false;
1392 bool has_dynamic_stencil_reference = false;
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001393 bool has_dynamic_viewport_w_scaling_nv = false;
1394 bool has_dynamic_discard_rectangle_ext = false;
1395 bool has_dynamic_sample_locations_ext = false;
Jeff Bolz3e71f782018-08-29 23:15:45 -05001396 bool has_dynamic_exclusive_scissor_nv = false;
Jeff Bolz9af91c52018-09-01 21:53:57 -05001397 bool has_dynamic_shading_rate_palette_nv = false;
Spencer Fricke8d428882020-03-16 17:23:33 -07001398 bool has_dynamic_viewport_course_sample_order_nv = false;
Jeff Bolz8125a8b2019-08-16 16:29:45 -05001399 bool has_dynamic_line_stipple = false;
Piers Daniell39842ee2020-07-10 16:42:33 -06001400 bool has_dynamic_cull_mode = false;
1401 bool has_dynamic_front_face = false;
1402 bool has_dynamic_primitive_topology = false;
1403 bool has_dynamic_viewport_with_count = false;
1404 bool has_dynamic_scissor_with_count = false;
1405 bool has_dynamic_vertex_input_binding_stride = false;
1406 bool has_dynamic_depth_test_enable = false;
1407 bool has_dynamic_depth_write_enable = false;
1408 bool has_dynamic_depth_compare_op = false;
1409 bool has_dynamic_depth_bounds_test_enable = false;
1410 bool has_dynamic_stencil_test_enable = false;
1411 bool has_dynamic_stencil_op = false;
Petr Kraus299ba622017-11-24 03:09:03 +01001412 if (pCreateInfos[i].pDynamicState != nullptr) {
1413 const auto &dynamic_state_info = *pCreateInfos[i].pDynamicState;
1414 for (uint32_t state_index = 0; state_index < dynamic_state_info.dynamicStateCount; ++state_index) {
1415 const auto &dynamic_state = dynamic_state_info.pDynamicStates[state_index];
Spencer Fricke8d428882020-03-16 17:23:33 -07001416 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT) {
1417 if (has_dynamic_viewport == true) {
1418 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1419 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_VIEWPORT was listed twice in the "
1420 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1421 i);
1422 }
1423 has_dynamic_viewport = true;
1424 }
1425 if (dynamic_state == VK_DYNAMIC_STATE_SCISSOR) {
1426 if (has_dynamic_scissor == true) {
1427 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1428 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_SCISSOR was listed twice in the "
1429 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1430 i);
1431 }
1432 has_dynamic_scissor = true;
1433 }
1434 if (dynamic_state == VK_DYNAMIC_STATE_LINE_WIDTH) {
1435 if (has_dynamic_line_width == true) {
1436 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1437 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_LINE_WIDTH was listed twice in the "
1438 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1439 i);
1440 }
1441 has_dynamic_line_width = true;
1442 }
1443 if (dynamic_state == VK_DYNAMIC_STATE_DEPTH_BIAS) {
1444 if (has_dynamic_depth_bias == true) {
1445 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1446 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DEPTH_BIAS was listed twice in the "
1447 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1448 i);
1449 }
1450 has_dynamic_depth_bias = true;
1451 }
1452 if (dynamic_state == VK_DYNAMIC_STATE_BLEND_CONSTANTS) {
1453 if (has_dynamic_blend_constant == true) {
1454 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1455 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_BLEND_CONSTANTS was listed twice in the "
1456 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1457 i);
1458 }
1459 has_dynamic_blend_constant = true;
1460 }
1461 if (dynamic_state == VK_DYNAMIC_STATE_DEPTH_BOUNDS) {
1462 if (has_dynamic_depth_bounds == true) {
1463 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1464 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DEPTH_BOUNDS was listed twice in the "
1465 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1466 i);
1467 }
1468 has_dynamic_depth_bounds = true;
1469 }
1470 if (dynamic_state == VK_DYNAMIC_STATE_STENCIL_COMPARE_MASK) {
1471 if (has_dynamic_stencil_compare == true) {
1472 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1473 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_STENCIL_COMPARE_MASK was listed twice in "
1474 "the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1475 i);
1476 }
1477 has_dynamic_stencil_compare = true;
1478 }
1479 if (dynamic_state == VK_DYNAMIC_STATE_STENCIL_WRITE_MASK) {
1480 if (has_dynamic_stencil_write == true) {
1481 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1482 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_STENCIL_WRITE_MASK was listed twice in "
1483 "the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1484 i);
1485 }
1486 has_dynamic_stencil_write = true;
1487 }
1488 if (dynamic_state == VK_DYNAMIC_STATE_STENCIL_REFERENCE) {
1489 if (has_dynamic_stencil_reference == true) {
1490 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1491 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_STENCIL_REFERENCE was listed twice in "
1492 "the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1493 i);
1494 }
1495 has_dynamic_stencil_reference = true;
1496 }
1497 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT_W_SCALING_NV) {
1498 if (has_dynamic_viewport_w_scaling_nv == true) {
1499 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1500 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_VIEWPORT_W_SCALING_NV was listed twice "
1501 "in the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1502 i);
1503 }
1504 has_dynamic_viewport_w_scaling_nv = true;
1505 }
1506 if (dynamic_state == VK_DYNAMIC_STATE_DISCARD_RECTANGLE_EXT) {
1507 if (has_dynamic_discard_rectangle_ext == true) {
1508 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1509 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DISCARD_RECTANGLE_EXT was listed twice "
1510 "in the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1511 i);
1512 }
1513 has_dynamic_discard_rectangle_ext = true;
1514 }
1515 if (dynamic_state == VK_DYNAMIC_STATE_SAMPLE_LOCATIONS_EXT) {
1516 if (has_dynamic_sample_locations_ext == true) {
1517 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1518 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_SAMPLE_LOCATIONS_EXT was listed twice in "
1519 "the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1520 i);
1521 }
1522 has_dynamic_sample_locations_ext = true;
1523 }
1524 if (dynamic_state == VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV) {
1525 if (has_dynamic_exclusive_scissor_nv == true) {
1526 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1527 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV was listed twice in "
1528 "the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1529 i);
1530 }
1531 has_dynamic_exclusive_scissor_nv = true;
1532 }
1533 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT_SHADING_RATE_PALETTE_NV) {
1534 if (has_dynamic_shading_rate_palette_nv == true) {
1535 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1536 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_VIEWPORT_SHADING_RATE_PALETTE_NV was "
1537 "listed twice in the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1538 i);
1539 }
Dave Houlton142c4cb2018-10-17 15:04:41 -06001540 has_dynamic_shading_rate_palette_nv = true;
Spencer Fricke8d428882020-03-16 17:23:33 -07001541 }
1542 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT_COARSE_SAMPLE_ORDER_NV) {
1543 if (has_dynamic_viewport_course_sample_order_nv == true) {
1544 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1545 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_VIEWPORT_COARSE_SAMPLE_ORDER_NV was "
1546 "listed twice in the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1547 i);
1548 }
1549 has_dynamic_viewport_course_sample_order_nv = true;
1550 }
1551 if (dynamic_state == VK_DYNAMIC_STATE_LINE_STIPPLE_EXT) {
1552 if (has_dynamic_line_stipple == true) {
1553 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1554 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_LINE_STIPPLE_EXT was listed twice in the "
1555 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1556 i);
1557 }
1558 has_dynamic_line_stipple = true;
1559 }
Piers Daniell39842ee2020-07-10 16:42:33 -06001560 if (dynamic_state == VK_DYNAMIC_STATE_CULL_MODE_EXT) {
1561 if (has_dynamic_cull_mode) {
1562 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1563 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_CULL_MODE_EXT was listed twice in the "
1564 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1565 i);
1566 }
1567 has_dynamic_cull_mode = true;
1568 }
1569 if (dynamic_state == VK_DYNAMIC_STATE_FRONT_FACE_EXT) {
1570 if (has_dynamic_front_face) {
1571 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1572 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_FRONT_FACE_EXT was listed twice in the "
1573 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1574 i);
1575 }
1576 has_dynamic_front_face = true;
1577 }
1578 if (dynamic_state == VK_DYNAMIC_STATE_PRIMITIVE_TOPOLOGY_EXT) {
1579 if (has_dynamic_primitive_topology) {
1580 skip |= LogError(
1581 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1582 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_PRIMITIVE_TOPOLOGY_EXT was listed twice in the "
1583 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1584 i);
1585 }
1586 has_dynamic_primitive_topology = true;
1587 }
1588 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT_WITH_COUNT_EXT) {
1589 if (has_dynamic_viewport_with_count) {
1590 skip |= LogError(
1591 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1592 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_VIEWPORT_WITH_COUNT_EXT was listed twice in the "
1593 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1594 i);
1595 }
1596 has_dynamic_viewport_with_count = true;
1597 }
1598 if (dynamic_state == VK_DYNAMIC_STATE_SCISSOR_WITH_COUNT_EXT) {
1599 if (has_dynamic_scissor_with_count) {
1600 skip |= LogError(
1601 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1602 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_SCISSOR_WITH_COUNT_EXT was listed twice in the "
1603 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1604 i);
1605 }
1606 has_dynamic_scissor_with_count = true;
1607 }
1608 if (dynamic_state == VK_DYNAMIC_STATE_VERTEX_INPUT_BINDING_STRIDE_EXT) {
1609 if (has_dynamic_vertex_input_binding_stride) {
1610 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1611 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_VERTEX_INPUT_BINDING_STRIDE_EXT was "
1612 "listed twice in the "
1613 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1614 i);
1615 }
1616 has_dynamic_vertex_input_binding_stride = true;
1617 }
1618 if (dynamic_state == VK_DYNAMIC_STATE_DEPTH_TEST_ENABLE_EXT) {
1619 if (has_dynamic_depth_test_enable) {
1620 skip |= LogError(
1621 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1622 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DEPTH_TEST_ENABLE_EXT was listed twice in the "
1623 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1624 i);
1625 }
1626 has_dynamic_depth_test_enable = true;
1627 }
1628 if (dynamic_state == VK_DYNAMIC_STATE_DEPTH_WRITE_ENABLE_EXT) {
1629 if (has_dynamic_depth_write_enable) {
1630 skip |= LogError(
1631 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1632 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DEPTH_WRITE_ENABLE_EXT was listed twice in the "
1633 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1634 i);
1635 }
1636 has_dynamic_depth_write_enable = true;
1637 }
1638 if (dynamic_state == VK_DYNAMIC_STATE_DEPTH_COMPARE_OP_EXT) {
1639 if (has_dynamic_depth_compare_op) {
1640 skip |=
1641 LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1642 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DEPTH_COMPARE_OP_EXT was listed twice in the "
1643 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1644 i);
1645 }
1646 has_dynamic_depth_compare_op = true;
1647 }
1648 if (dynamic_state == VK_DYNAMIC_STATE_DEPTH_BOUNDS_TEST_ENABLE_EXT) {
1649 if (has_dynamic_depth_bounds_test_enable) {
1650 skip |= LogError(
1651 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1652 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DEPTH_BOUNDS_TEST_ENABLE_EXT was listed twice in the "
1653 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1654 i);
1655 }
1656 has_dynamic_depth_bounds_test_enable = true;
1657 }
1658 if (dynamic_state == VK_DYNAMIC_STATE_STENCIL_TEST_ENABLE_EXT) {
1659 if (has_dynamic_stencil_test_enable) {
1660 skip |= LogError(
1661 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1662 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_STENCIL_TEST_ENABLE_EXT was listed twice in the "
1663 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1664 i);
1665 }
1666 has_dynamic_stencil_test_enable = true;
1667 }
1668 if (dynamic_state == VK_DYNAMIC_STATE_STENCIL_OP_EXT) {
1669 if (has_dynamic_stencil_op) {
1670 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1671 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_STENCIL_OP_EXT was listed twice in the "
1672 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1673 i);
1674 }
1675 has_dynamic_stencil_op = true;
1676 }
Petr Kraus299ba622017-11-24 03:09:03 +01001677 }
1678 }
1679
Peter Chen85366392019-05-14 15:20:11 -04001680 auto feedback_struct = lvl_find_in_chain<VkPipelineCreationFeedbackCreateInfoEXT>(pCreateInfos[i].pNext);
1681 if ((feedback_struct != nullptr) &&
1682 (feedback_struct->pipelineStageCreationFeedbackCount != pCreateInfos[i].stageCount)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001683 skip |= LogError(device, "VUID-VkPipelineCreationFeedbackCreateInfoEXT-pipelineStageCreationFeedbackCount-02668",
1684 "vkCreateGraphicsPipelines(): in pCreateInfo[%" PRIu32
1685 "], VkPipelineCreationFeedbackEXT::pipelineStageCreationFeedbackCount"
1686 "(=%" PRIu32 ") must equal VkGraphicsPipelineCreateInfo::stageCount(=%" PRIu32 ").",
1687 i, feedback_struct->pipelineStageCreationFeedbackCount, pCreateInfos[i].stageCount);
Peter Chen85366392019-05-14 15:20:11 -04001688 }
1689
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001690 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001691
Spencer Frickef1b0a7d2020-03-16 17:38:55 -07001692 // Collect active stages and other information
1693 // Only want to loop through pStages once
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001694 uint32_t active_shaders = 0;
Spencer Frickef1b0a7d2020-03-16 17:38:55 -07001695 bool has_eval = false;
1696 bool has_control = false;
1697 if (pCreateInfos[i].pStages != nullptr) {
1698 for (uint32_t stage_index = 0; stage_index < pCreateInfos[i].stageCount; ++stage_index) {
1699 active_shaders |= pCreateInfos[i].pStages[stage_index].stage;
1700
1701 if (pCreateInfos[i].pStages[stage_index].stage == VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) {
1702 has_control = true;
1703 } else if (pCreateInfos[i].pStages[stage_index].stage == VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT) {
1704 has_eval = true;
1705 }
1706
1707 skip |= validate_string(
1708 "vkCreateGraphicsPipelines",
1709 ParameterName("pCreateInfos[%i].pStages[%i].pName", ParameterName::IndexVector{i, stage_index}),
1710 "VUID-VkGraphicsPipelineCreateInfo-pStages-parameter", pCreateInfos[i].pStages[stage_index].pName);
1711 }
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001712 }
1713
1714 if ((active_shaders & VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) &&
1715 (active_shaders & VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT) && (pCreateInfos[i].pTessellationState != nullptr)) {
1716 skip |= validate_struct_type("vkCreateGraphicsPipelines", "pCreateInfos[i].pTessellationState",
1717 "VK_STRUCTURE_TYPE_PIPELINE_TESSELLATION_STATE_CREATE_INFO",
1718 pCreateInfos[i].pTessellationState,
1719 VK_STRUCTURE_TYPE_PIPELINE_TESSELLATION_STATE_CREATE_INFO, false, kVUIDUndefined,
1720 "VUID-VkPipelineTessellationStateCreateInfo-sType-sType");
1721
1722 const VkStructureType allowed_structs_VkPipelineTessellationStateCreateInfo[] = {
1723 VK_STRUCTURE_TYPE_PIPELINE_TESSELLATION_DOMAIN_ORIGIN_STATE_CREATE_INFO};
1724
1725 skip |= validate_struct_pnext("vkCreateGraphicsPipelines", "pCreateInfos[i].pTessellationState->pNext",
1726 "VkPipelineTessellationDomainOriginStateCreateInfo",
1727 pCreateInfos[i].pTessellationState->pNext,
1728 ARRAY_SIZE(allowed_structs_VkPipelineTessellationStateCreateInfo),
1729 allowed_structs_VkPipelineTessellationStateCreateInfo, GeneratedVulkanHeaderVersion,
sfricke-samsung32a27362020-02-28 09:06:42 -08001730 "VUID-VkPipelineTessellationStateCreateInfo-pNext-pNext",
1731 "VUID-VkPipelineTessellationStateCreateInfo-sType-unique");
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001732
1733 skip |= validate_reserved_flags("vkCreateGraphicsPipelines", "pCreateInfos[i].pTessellationState->flags",
1734 pCreateInfos[i].pTessellationState->flags,
1735 "VUID-VkPipelineTessellationStateCreateInfo-flags-zerobitmask");
1736 }
1737
1738 if (!(active_shaders & VK_SHADER_STAGE_MESH_BIT_NV) && (pCreateInfos[i].pInputAssemblyState != nullptr)) {
1739 skip |= validate_struct_type("vkCreateGraphicsPipelines", "pCreateInfos[i].pInputAssemblyState",
1740 "VK_STRUCTURE_TYPE_PIPELINE_INPUT_ASSEMBLY_STATE_CREATE_INFO",
1741 pCreateInfos[i].pInputAssemblyState,
1742 VK_STRUCTURE_TYPE_PIPELINE_INPUT_ASSEMBLY_STATE_CREATE_INFO, false, kVUIDUndefined,
1743 "VUID-VkPipelineInputAssemblyStateCreateInfo-sType-sType");
1744
1745 skip |= validate_struct_pnext("vkCreateGraphicsPipelines", "pCreateInfos[i].pInputAssemblyState->pNext", NULL,
1746 pCreateInfos[i].pInputAssemblyState->pNext, 0, NULL, GeneratedVulkanHeaderVersion,
sfricke-samsung32a27362020-02-28 09:06:42 -08001747 "VUID-VkPipelineInputAssemblyStateCreateInfo-pNext-pNext", nullptr);
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001748
1749 skip |= validate_reserved_flags("vkCreateGraphicsPipelines", "pCreateInfos[i].pInputAssemblyState->flags",
1750 pCreateInfos[i].pInputAssemblyState->flags,
1751 "VUID-VkPipelineInputAssemblyStateCreateInfo-flags-zerobitmask");
1752
1753 skip |= validate_ranged_enum("vkCreateGraphicsPipelines", "pCreateInfos[i].pInputAssemblyState->topology",
1754 "VkPrimitiveTopology", AllVkPrimitiveTopologyEnums,
1755 pCreateInfos[i].pInputAssemblyState->topology,
1756 "VUID-VkPipelineInputAssemblyStateCreateInfo-topology-parameter");
1757
1758 skip |= validate_bool32("vkCreateGraphicsPipelines", "pCreateInfos[i].pInputAssemblyState->primitiveRestartEnable",
1759 pCreateInfos[i].pInputAssemblyState->primitiveRestartEnable);
1760 }
1761
1762 if (!(active_shaders & VK_SHADER_STAGE_MESH_BIT_NV) && (pCreateInfos[i].pVertexInputState != nullptr)) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001763 auto const &vertex_input_state = pCreateInfos[i].pVertexInputState;
Peter Kohautc7d9d392018-07-15 00:34:07 +02001764
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001765 if (pCreateInfos[i].pVertexInputState->flags != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001766 skip |= LogError(device, "VUID-VkPipelineVertexInputStateCreateInfo-flags-zerobitmask",
1767 "vkCreateGraphicsPipelines: pararameter "
1768 "pCreateInfos[%d].pVertexInputState->flags (%u) is reserved and must be zero.",
1769 i, vertex_input_state->flags);
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001770 }
1771
1772 const VkStructureType allowed_structs_VkPipelineVertexInputStateCreateInfo[] = {
1773 VK_STRUCTURE_TYPE_PIPELINE_VERTEX_INPUT_DIVISOR_STATE_CREATE_INFO_EXT};
1774 skip |= validate_struct_pnext("vkCreateGraphicsPipelines", "pCreateInfos[i].pVertexInputState->pNext",
1775 "VkPipelineVertexInputDivisorStateCreateInfoEXT",
1776 pCreateInfos[i].pVertexInputState->pNext, 1,
1777 allowed_structs_VkPipelineVertexInputStateCreateInfo, GeneratedVulkanHeaderVersion,
sfricke-samsung32a27362020-02-28 09:06:42 -08001778 "VUID-VkPipelineVertexInputStateCreateInfo-pNext-pNext",
1779 "VUID-VkPipelineVertexInputStateCreateInfo-sType-unique");
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001780 skip |= validate_struct_type("vkCreateGraphicsPipelines", "pCreateInfos[i].pVertexInputState",
1781 "VK_STRUCTURE_TYPE_PIPELINE_VERTEX_INPUT_STATE_CREATE_INFO", vertex_input_state,
Shannon McPherson3cc90bc2019-08-13 11:28:22 -06001782 VK_STRUCTURE_TYPE_PIPELINE_VERTEX_INPUT_STATE_CREATE_INFO, false, kVUIDUndefined,
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001783 "VUID-VkPipelineVertexInputStateCreateInfo-sType-sType");
1784 skip |=
1785 validate_array("vkCreateGraphicsPipelines", "pCreateInfos[i].pVertexInputState->vertexBindingDescriptionCount",
1786 "pCreateInfos[i].pVertexInputState->pVertexBindingDescriptions",
1787 pCreateInfos[i].pVertexInputState->vertexBindingDescriptionCount,
1788 &pCreateInfos[i].pVertexInputState->pVertexBindingDescriptions, false, true, kVUIDUndefined,
1789 "VUID-VkPipelineVertexInputStateCreateInfo-pVertexBindingDescriptions-parameter");
1790
1791 skip |= validate_array(
1792 "vkCreateGraphicsPipelines", "pCreateInfos[i].pVertexInputState->vertexAttributeDescriptionCount",
1793 "pCreateInfos[i]->pVertexAttributeDescriptions", vertex_input_state->vertexAttributeDescriptionCount,
1794 &vertex_input_state->pVertexAttributeDescriptions, false, true, kVUIDUndefined,
1795 "VUID-VkPipelineVertexInputStateCreateInfo-pVertexAttributeDescriptions-parameter");
1796
1797 if (pCreateInfos[i].pVertexInputState->pVertexBindingDescriptions != NULL) {
1798 for (uint32_t vertexBindingDescriptionIndex = 0;
1799 vertexBindingDescriptionIndex < pCreateInfos[i].pVertexInputState->vertexBindingDescriptionCount;
1800 ++vertexBindingDescriptionIndex) {
1801 skip |= validate_ranged_enum(
1802 "vkCreateGraphicsPipelines",
1803 "pCreateInfos[i].pVertexInputState->pVertexBindingDescriptions[j].inputRate", "VkVertexInputRate",
1804 AllVkVertexInputRateEnums,
1805 pCreateInfos[i].pVertexInputState->pVertexBindingDescriptions[vertexBindingDescriptionIndex].inputRate,
1806 "VUID-VkVertexInputBindingDescription-inputRate-parameter");
1807 }
1808 }
1809
1810 if (pCreateInfos[i].pVertexInputState->pVertexAttributeDescriptions != NULL) {
1811 for (uint32_t vertexAttributeDescriptionIndex = 0;
1812 vertexAttributeDescriptionIndex < pCreateInfos[i].pVertexInputState->vertexAttributeDescriptionCount;
1813 ++vertexAttributeDescriptionIndex) {
1814 skip |= validate_ranged_enum(
1815 "vkCreateGraphicsPipelines",
1816 "pCreateInfos[i].pVertexInputState->pVertexAttributeDescriptions[i].format", "VkFormat",
1817 AllVkFormatEnums,
1818 pCreateInfos[i].pVertexInputState->pVertexAttributeDescriptions[vertexAttributeDescriptionIndex].format,
1819 "VUID-VkVertexInputAttributeDescription-format-parameter");
1820 }
1821 }
1822
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001823 if (vertex_input_state->vertexBindingDescriptionCount > device_limits.maxVertexInputBindings) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001824 skip |= LogError(device, "VUID-VkPipelineVertexInputStateCreateInfo-vertexBindingDescriptionCount-00613",
1825 "vkCreateGraphicsPipelines: pararameter "
1826 "pCreateInfo[%d].pVertexInputState->vertexBindingDescriptionCount (%u) is "
1827 "greater than VkPhysicalDeviceLimits::maxVertexInputBindings (%u).",
1828 i, vertex_input_state->vertexBindingDescriptionCount, device_limits.maxVertexInputBindings);
Peter Kohautc7d9d392018-07-15 00:34:07 +02001829 }
1830
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001831 if (vertex_input_state->vertexAttributeDescriptionCount > device_limits.maxVertexInputAttributes) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001832 skip |=
1833 LogError(device, "VUID-VkPipelineVertexInputStateCreateInfo-vertexAttributeDescriptionCount-00614",
1834 "vkCreateGraphicsPipelines: pararameter "
1835 "pCreateInfo[%d].pVertexInputState->vertexAttributeDescriptionCount (%u) is "
1836 "greater than VkPhysicalDeviceLimits::maxVertexInputAttributes (%u).",
1837 i, vertex_input_state->vertexAttributeDescriptionCount, device_limits.maxVertexInputAttributes);
Peter Kohautc7d9d392018-07-15 00:34:07 +02001838 }
1839
1840 std::unordered_set<uint32_t> vertex_bindings(vertex_input_state->vertexBindingDescriptionCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001841 for (uint32_t d = 0; d < vertex_input_state->vertexBindingDescriptionCount; ++d) {
1842 auto const &vertex_bind_desc = vertex_input_state->pVertexBindingDescriptions[d];
Peter Kohautc7d9d392018-07-15 00:34:07 +02001843 auto const &binding_it = vertex_bindings.find(vertex_bind_desc.binding);
1844 if (binding_it != vertex_bindings.cend()) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001845 skip |= LogError(device, "VUID-VkPipelineVertexInputStateCreateInfo-pVertexBindingDescriptions-00616",
1846 "vkCreateGraphicsPipelines: parameter "
1847 "pCreateInfo[%d].pVertexInputState->pVertexBindingDescription[%d].binding "
1848 "(%" PRIu32 ") is not distinct.",
1849 i, d, vertex_bind_desc.binding);
Peter Kohautc7d9d392018-07-15 00:34:07 +02001850 }
1851 vertex_bindings.insert(vertex_bind_desc.binding);
1852
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001853 if (vertex_bind_desc.binding >= device_limits.maxVertexInputBindings) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001854 skip |= LogError(device, "VUID-VkVertexInputBindingDescription-binding-00618",
1855 "vkCreateGraphicsPipelines: parameter "
1856 "pCreateInfos[%u].pVertexInputState->pVertexBindingDescriptions[%u].binding (%u) is "
1857 "greater than or equal to VkPhysicalDeviceLimits::maxVertexInputBindings (%u).",
1858 i, d, vertex_bind_desc.binding, device_limits.maxVertexInputBindings);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001859 }
1860
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001861 if (vertex_bind_desc.stride > device_limits.maxVertexInputBindingStride) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001862 skip |=
1863 LogError(device, "VUID-VkVertexInputBindingDescription-stride-00619",
1864 "vkCreateGraphicsPipelines: parameter "
1865 "pCreateInfos[%u].pVertexInputState->pVertexBindingDescriptions[%u].stride (%u) is greater "
1866 "than VkPhysicalDeviceLimits::maxVertexInputBindingStride (%u).",
1867 i, d, vertex_bind_desc.stride, device_limits.maxVertexInputBindingStride);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001868 }
1869 }
1870
Peter Kohautc7d9d392018-07-15 00:34:07 +02001871 std::unordered_set<uint32_t> attribute_locations(vertex_input_state->vertexAttributeDescriptionCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001872 for (uint32_t d = 0; d < vertex_input_state->vertexAttributeDescriptionCount; ++d) {
1873 auto const &vertex_attrib_desc = vertex_input_state->pVertexAttributeDescriptions[d];
Peter Kohautc7d9d392018-07-15 00:34:07 +02001874 auto const &location_it = attribute_locations.find(vertex_attrib_desc.location);
1875 if (location_it != attribute_locations.cend()) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001876 skip |= LogError(
1877 device, "VUID-VkPipelineVertexInputStateCreateInfo-pVertexAttributeDescriptions-00617",
Peter Kohautc7d9d392018-07-15 00:34:07 +02001878 "vkCreateGraphicsPipelines: parameter "
1879 "pCreateInfo[%d].pVertexInputState->vertexAttributeDescriptions[%d].location (%u) is not distinct.",
1880 i, d, vertex_attrib_desc.location);
1881 }
1882 attribute_locations.insert(vertex_attrib_desc.location);
1883
1884 auto const &binding_it = vertex_bindings.find(vertex_attrib_desc.binding);
1885 if (binding_it == vertex_bindings.cend()) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001886 skip |= LogError(
1887 device, "VUID-VkPipelineVertexInputStateCreateInfo-binding-00615",
Peter Kohautc7d9d392018-07-15 00:34:07 +02001888 "vkCreateGraphicsPipelines: parameter "
1889 " pCreateInfo[%d].pVertexInputState->vertexAttributeDescriptions[%d].binding (%u) does not exist "
1890 "in any pCreateInfo[%d].pVertexInputState->pVertexBindingDescription.",
1891 i, d, vertex_attrib_desc.binding, i);
1892 }
1893
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001894 if (vertex_attrib_desc.location >= device_limits.maxVertexInputAttributes) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001895 skip |= LogError(device, "VUID-VkVertexInputAttributeDescription-location-00620",
1896 "vkCreateGraphicsPipelines: parameter "
1897 "pCreateInfos[%u].pVertexInputState->pVertexAttributeDescriptions[%u].location (%u) is "
1898 "greater than or equal to VkPhysicalDeviceLimits::maxVertexInputAttributes (%u).",
1899 i, d, vertex_attrib_desc.location, device_limits.maxVertexInputAttributes);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001900 }
1901
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001902 if (vertex_attrib_desc.binding >= device_limits.maxVertexInputBindings) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001903 skip |= LogError(device, "VUID-VkVertexInputAttributeDescription-binding-00621",
1904 "vkCreateGraphicsPipelines: parameter "
1905 "pCreateInfos[%u].pVertexInputState->pVertexAttributeDescriptions[%u].binding (%u) is "
1906 "greater than or equal to VkPhysicalDeviceLimits::maxVertexInputBindings (%u).",
1907 i, d, vertex_attrib_desc.binding, device_limits.maxVertexInputBindings);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001908 }
1909
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001910 if (vertex_attrib_desc.offset > device_limits.maxVertexInputAttributeOffset) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001911 skip |= LogError(device, "VUID-VkVertexInputAttributeDescription-offset-00622",
1912 "vkCreateGraphicsPipelines: parameter "
1913 "pCreateInfos[%u].pVertexInputState->pVertexAttributeDescriptions[%u].offset (%u) is "
1914 "greater than VkPhysicalDeviceLimits::maxVertexInputAttributeOffset (%u).",
1915 i, d, vertex_attrib_desc.offset, device_limits.maxVertexInputAttributeOffset);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001916 }
1917 }
1918 }
1919
Spencer Frickef1b0a7d2020-03-16 17:38:55 -07001920 // pTessellationState is ignored without both tessellation control and tessellation evaluation shaders stages
1921 if (has_control && has_eval) {
1922 if (pCreateInfos[i].pTessellationState == nullptr) {
1923 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-pStages-00731",
1924 "vkCreateGraphicsPipelines: if pCreateInfos[%d].pStages includes a tessellation control "
1925 "shader stage and a tessellation evaluation shader stage, "
1926 "pCreateInfos[%d].pTessellationState must not be NULL.",
1927 i, i);
1928 } else {
1929 const VkStructureType allowed_type = VK_STRUCTURE_TYPE_PIPELINE_TESSELLATION_DOMAIN_ORIGIN_STATE_CREATE_INFO;
1930 skip |= validate_struct_pnext(
1931 "vkCreateGraphicsPipelines",
1932 ParameterName("pCreateInfos[%i].pTessellationState->pNext", ParameterName::IndexVector{i}),
1933 "VkPipelineTessellationDomainOriginStateCreateInfo", pCreateInfos[i].pTessellationState->pNext, 1,
1934 &allowed_type, GeneratedVulkanHeaderVersion, "VUID-VkGraphicsPipelineCreateInfo-pNext-pNext",
1935 "VUID-VkGraphicsPipelineCreateInfo-sType-unique");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001936
Spencer Frickef1b0a7d2020-03-16 17:38:55 -07001937 skip |= validate_reserved_flags(
1938 "vkCreateGraphicsPipelines",
1939 ParameterName("pCreateInfos[%i].pTessellationState->flags", ParameterName::IndexVector{i}),
1940 pCreateInfos[i].pTessellationState->flags, "VUID-VkPipelineTessellationStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001941
Spencer Frickef1b0a7d2020-03-16 17:38:55 -07001942 if (pCreateInfos[i].pTessellationState->patchControlPoints == 0 ||
1943 pCreateInfos[i].pTessellationState->patchControlPoints > device_limits.maxTessellationPatchSize) {
1944 skip |= LogError(device, "VUID-VkPipelineTessellationStateCreateInfo-patchControlPoints-01214",
1945 "vkCreateGraphicsPipelines: invalid parameter "
1946 "pCreateInfos[%d].pTessellationState->patchControlPoints value %u. patchControlPoints "
1947 "should be >0 and <=%u.",
1948 i, pCreateInfos[i].pTessellationState->patchControlPoints,
1949 device_limits.maxTessellationPatchSize);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001950 }
1951 }
1952 }
1953
1954 // pViewportState, pMultisampleState, pDepthStencilState, and pColorBlendState ignored when rasterization is disabled
1955 if ((pCreateInfos[i].pRasterizationState != nullptr) &&
1956 (pCreateInfos[i].pRasterizationState->rasterizerDiscardEnable == VK_FALSE)) {
1957 if (pCreateInfos[i].pViewportState == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001958 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-rasterizerDiscardEnable-00750",
1959 "vkCreateGraphicsPipelines: Rasterization is enabled (pCreateInfos[%" PRIu32
1960 "].pRasterizationState->rasterizerDiscardEnable is VK_FALSE), but pCreateInfos[%" PRIu32
1961 "].pViewportState (=NULL) is not a valid pointer.",
1962 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001963 } else {
Petr Krausa6103552017-11-16 21:21:58 +01001964 const auto &viewport_state = *pCreateInfos[i].pViewportState;
1965
1966 if (viewport_state.sType != VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_STATE_CREATE_INFO) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001967 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-sType-sType",
1968 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1969 "].pViewportState->sType is not VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_STATE_CREATE_INFO.",
1970 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001971 }
1972
Petr Krausa6103552017-11-16 21:21:58 +01001973 const VkStructureType allowed_structs_VkPipelineViewportStateCreateInfo[] = {
1974 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_SWIZZLE_STATE_CREATE_INFO_NV,
Jeff Bolz3e71f782018-08-29 23:15:45 -05001975 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_W_SCALING_STATE_CREATE_INFO_NV,
1976 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_EXCLUSIVE_SCISSOR_STATE_CREATE_INFO_NV,
Jeff Bolz9af91c52018-09-01 21:53:57 -05001977 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_SHADING_RATE_IMAGE_STATE_CREATE_INFO_NV,
1978 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_COARSE_SAMPLE_ORDER_STATE_CREATE_INFO_NV,
Jeff Bolz3e71f782018-08-29 23:15:45 -05001979 };
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001980 skip |= validate_struct_pnext(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001981 "vkCreateGraphicsPipelines",
Petr Krausa6103552017-11-16 21:21:58 +01001982 ParameterName("pCreateInfos[%i].pViewportState->pNext", ParameterName::IndexVector{i}),
Jeff Bolz9af91c52018-09-01 21:53:57 -05001983 "VkPipelineViewportSwizzleStateCreateInfoNV, VkPipelineViewportWScalingStateCreateInfoNV, "
Jeff Bolzb8a8dd02018-09-18 02:39:24 -05001984 "VkPipelineViewportExclusiveScissorStateCreateInfoNV, VkPipelineViewportShadingRateImageStateCreateInfoNV, "
1985 "VkPipelineViewportCoarseSampleOrderStateCreateInfoNV",
Petr Krausa6103552017-11-16 21:21:58 +01001986 viewport_state.pNext, ARRAY_SIZE(allowed_structs_VkPipelineViewportStateCreateInfo),
sfricke-samsung32a27362020-02-28 09:06:42 -08001987 allowed_structs_VkPipelineViewportStateCreateInfo, 65, "VUID-VkPipelineViewportStateCreateInfo-pNext-pNext",
1988 "VUID-VkPipelineViewportStateCreateInfo-sType-unique");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001989
1990 skip |= validate_reserved_flags(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001991 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001992 ParameterName("pCreateInfos[%i].pViewportState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06001993 viewport_state.flags, "VUID-VkPipelineViewportStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001994
Dave Houlton142c4cb2018-10-17 15:04:41 -06001995 auto exclusive_scissor_struct = lvl_find_in_chain<VkPipelineViewportExclusiveScissorStateCreateInfoNV>(
1996 pCreateInfos[i].pViewportState->pNext);
1997 auto shading_rate_image_struct = lvl_find_in_chain<VkPipelineViewportShadingRateImageStateCreateInfoNV>(
1998 pCreateInfos[i].pViewportState->pNext);
1999 auto coarse_sample_order_struct = lvl_find_in_chain<VkPipelineViewportCoarseSampleOrderStateCreateInfoNV>(
2000 pCreateInfos[i].pViewportState->pNext);
Chris Mayer328d8212018-12-11 14:16:18 +01002001 const auto vp_swizzle_struct =
2002 lvl_find_in_chain<VkPipelineViewportSwizzleStateCreateInfoNV>(pCreateInfos[i].pViewportState->pNext);
Chris Mayer9ded5eb2019-09-19 16:33:26 +02002003 const auto vp_w_scaling_struct =
2004 lvl_find_in_chain<VkPipelineViewportWScalingStateCreateInfoNV>(pCreateInfos[i].pViewportState->pNext);
Jeff Bolz3e71f782018-08-29 23:15:45 -05002005
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002006 if (!physical_device_features.multiViewport) {
Petr Krausa6103552017-11-16 21:21:58 +01002007 if (viewport_state.viewportCount != 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002008 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-viewportCount-01216",
2009 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
2010 "disabled, but pCreateInfos[%" PRIu32 "].pViewportState->viewportCount (=%" PRIu32
2011 ") is not 1.",
2012 i, viewport_state.viewportCount);
Petr Krausa6103552017-11-16 21:21:58 +01002013 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002014
Petr Krausa6103552017-11-16 21:21:58 +01002015 if (viewport_state.scissorCount != 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002016 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-01217",
2017 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
2018 "disabled, but pCreateInfos[%" PRIu32 "].pViewportState->scissorCount (=%" PRIu32
2019 ") is not 1.",
2020 i, viewport_state.scissorCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002021 }
Jeff Bolz3e71f782018-08-29 23:15:45 -05002022
Dave Houlton142c4cb2018-10-17 15:04:41 -06002023 if (exclusive_scissor_struct && (exclusive_scissor_struct->exclusiveScissorCount != 0 &&
2024 exclusive_scissor_struct->exclusiveScissorCount != 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002025 skip |= LogError(
2026 device, "VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-exclusiveScissorCount-02027",
2027 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
2028 "disabled, but pCreateInfos[%" PRIu32
2029 "] VkPipelineViewportExclusiveScissorStateCreateInfoNV::exclusiveScissorCount (=%" PRIu32
2030 ") is not 1.",
2031 i, exclusive_scissor_struct->exclusiveScissorCount);
Jeff Bolz3e71f782018-08-29 23:15:45 -05002032 }
2033
Jeff Bolz9af91c52018-09-01 21:53:57 -05002034 if (shading_rate_image_struct &&
2035 (shading_rate_image_struct->viewportCount != 0 && shading_rate_image_struct->viewportCount != 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002036 skip |= LogError(device, "VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-viewportCount-02054",
2037 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
2038 "disabled, but pCreateInfos[%" PRIu32
2039 "] VkPipelineViewportShadingRateImageStateCreateInfoNV::viewportCount (=%" PRIu32
2040 ") is neither 0 nor 1.",
2041 i, shading_rate_image_struct->viewportCount);
Jeff Bolz9af91c52018-09-01 21:53:57 -05002042 }
2043
Petr Krausa6103552017-11-16 21:21:58 +01002044 } else { // multiViewport enabled
2045 if (viewport_state.viewportCount == 0) {
Piers Daniell39842ee2020-07-10 16:42:33 -06002046 if (!has_dynamic_viewport_with_count) {
2047 skip |= LogError(
2048 device, "VUID-VkPipelineViewportStateCreateInfo-viewportCount-arraylength",
2049 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "].pViewportState->viewportCount is 0.", i);
2050 }
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002051 } else if (viewport_state.viewportCount > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002052 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-viewportCount-01218",
2053 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2054 "].pViewportState->viewportCount (=%" PRIu32
2055 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
2056 i, viewport_state.viewportCount, device_limits.maxViewports);
Piers Daniell39842ee2020-07-10 16:42:33 -06002057 } else if (has_dynamic_viewport_with_count) {
2058 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-03379",
2059 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2060 "].pViewportState->viewportCount (=%" PRIu32
2061 ") must be zero when VK_DYNAMIC_STATE_VIEWPORT_WITH_COUNT_EXT is used.",
2062 i, viewport_state.viewportCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002063 }
Petr Krausa6103552017-11-16 21:21:58 +01002064
2065 if (viewport_state.scissorCount == 0) {
Piers Daniell39842ee2020-07-10 16:42:33 -06002066 if (!has_dynamic_scissor_with_count) {
2067 skip |= LogError(
2068 device, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-arraylength",
2069 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "].pViewportState->scissorCount is 0.", i);
2070 }
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002071 } else if (viewport_state.scissorCount > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002072 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-01219",
2073 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2074 "].pViewportState->scissorCount (=%" PRIu32
2075 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
2076 i, viewport_state.scissorCount, device_limits.maxViewports);
Piers Daniell39842ee2020-07-10 16:42:33 -06002077 } else if (has_dynamic_scissor_with_count) {
2078 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-03380",
2079 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2080 "].pViewportState->scissorCount (=%" PRIu32
2081 ") must be zero when VK_DYNAMIC_STATE_SCISSOR_WITH_COUNT_EXT is used.",
2082 i, viewport_state.viewportCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002083 }
2084 }
2085
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002086 if (exclusive_scissor_struct && exclusive_scissor_struct->exclusiveScissorCount > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002087 skip |=
2088 LogError(device, "VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-exclusiveScissorCount-02028",
2089 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "] exclusiveScissorCount (=%" PRIu32
2090 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
2091 i, exclusive_scissor_struct->exclusiveScissorCount, device_limits.maxViewports);
Jeff Bolz3e71f782018-08-29 23:15:45 -05002092 }
2093
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002094 if (shading_rate_image_struct && shading_rate_image_struct->viewportCount > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002095 skip |= LogError(device, "VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-viewportCount-02055",
2096 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2097 "] VkPipelineViewportShadingRateImageStateCreateInfoNV viewportCount (=%" PRIu32
2098 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
2099 i, shading_rate_image_struct->viewportCount, device_limits.maxViewports);
Jeff Bolz9af91c52018-09-01 21:53:57 -05002100 }
2101
Piers Daniell39842ee2020-07-10 16:42:33 -06002102 if (viewport_state.scissorCount != viewport_state.viewportCount &&
2103 !(has_dynamic_viewport_with_count || has_dynamic_scissor_with_count)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002104 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-01220",
2105 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2106 "].pViewportState->scissorCount (=%" PRIu32 ") is not identical to pCreateInfos[%" PRIu32
2107 "].pViewportState->viewportCount (=%" PRIu32 ").",
2108 i, viewport_state.scissorCount, i, viewport_state.viewportCount);
Petr Krausa6103552017-11-16 21:21:58 +01002109 }
2110
Dave Houlton142c4cb2018-10-17 15:04:41 -06002111 if (exclusive_scissor_struct && exclusive_scissor_struct->exclusiveScissorCount != 0 &&
Jeff Bolz3e71f782018-08-29 23:15:45 -05002112 exclusive_scissor_struct->exclusiveScissorCount != viewport_state.viewportCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002113 skip |=
2114 LogError(device, "VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-exclusiveScissorCount-02029",
2115 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "] exclusiveScissorCount (=%" PRIu32
2116 ") must be zero or identical to pCreateInfos[%" PRIu32
2117 "].pViewportState->viewportCount (=%" PRIu32 ").",
2118 i, exclusive_scissor_struct->exclusiveScissorCount, i, viewport_state.viewportCount);
Jeff Bolz3e71f782018-08-29 23:15:45 -05002119 }
2120
Dave Houlton142c4cb2018-10-17 15:04:41 -06002121 if (shading_rate_image_struct && shading_rate_image_struct->shadingRateImageEnable &&
Jeff Bolz9af91c52018-09-01 21:53:57 -05002122 shading_rate_image_struct->viewportCount != viewport_state.viewportCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002123 skip |= LogError(
2124 device, "VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-shadingRateImageEnable-02056",
Dave Houlton142c4cb2018-10-17 15:04:41 -06002125 "vkCreateGraphicsPipelines: If shadingRateImageEnable is enabled, pCreateInfos[%" PRIu32
2126 "] "
2127 "VkPipelineViewportShadingRateImageStateCreateInfoNV viewportCount (=%" PRIu32
2128 ") must identical to pCreateInfos[%" PRIu32 "].pViewportState->viewportCount (=%" PRIu32 ").",
2129 i, shading_rate_image_struct->viewportCount, i, viewport_state.viewportCount);
Jeff Bolz9af91c52018-09-01 21:53:57 -05002130 }
2131
Petr Krausa6103552017-11-16 21:21:58 +01002132 if (!has_dynamic_viewport && viewport_state.viewportCount > 0 && viewport_state.pViewports == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002133 skip |= LogError(
2134 device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-00747",
Petr Krausa6103552017-11-16 21:21:58 +01002135 "vkCreateGraphicsPipelines: The viewport state is static (pCreateInfos[%" PRIu32
2136 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_VIEWPORT), but pCreateInfos[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002137 "].pViewportState->pViewports (=NULL) is an invalid pointer.",
2138 i, i);
Petr Krausa6103552017-11-16 21:21:58 +01002139 }
2140
2141 if (!has_dynamic_scissor && viewport_state.scissorCount > 0 && viewport_state.pScissors == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002142 skip |= LogError(
2143 device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-00748",
Petr Krausa6103552017-11-16 21:21:58 +01002144 "vkCreateGraphicsPipelines: The scissor state is static (pCreateInfos[%" PRIu32
2145 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_SCISSOR), but pCreateInfos[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002146 "].pViewportState->pScissors (=NULL) is an invalid pointer.",
2147 i, i);
Petr Krausa6103552017-11-16 21:21:58 +01002148 }
2149
Jeff Bolz3e71f782018-08-29 23:15:45 -05002150 if (!has_dynamic_exclusive_scissor_nv && exclusive_scissor_struct &&
Dave Houlton142c4cb2018-10-17 15:04:41 -06002151 exclusive_scissor_struct->exclusiveScissorCount > 0 &&
2152 exclusive_scissor_struct->pExclusiveScissors == nullptr) {
2153 skip |=
Shannon McPherson24c13d12020-06-18 15:51:41 -06002154 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-04056",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002155 "vkCreateGraphicsPipelines: The exclusive scissor state is static (pCreateInfos[%" PRIu32
2156 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV), but "
2157 "pCreateInfos[%" PRIu32 "] pExclusiveScissors (=NULL) is an invalid pointer.",
2158 i, i);
Jeff Bolz3e71f782018-08-29 23:15:45 -05002159 }
2160
Jeff Bolz9af91c52018-09-01 21:53:57 -05002161 if (!has_dynamic_shading_rate_palette_nv && shading_rate_image_struct &&
Dave Houlton142c4cb2018-10-17 15:04:41 -06002162 shading_rate_image_struct->viewportCount > 0 &&
2163 shading_rate_image_struct->pShadingRatePalettes == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002164 skip |= LogError(
Shannon McPherson24c13d12020-06-18 15:51:41 -06002165 device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-04057",
Jeff Bolz9af91c52018-09-01 21:53:57 -05002166 "vkCreateGraphicsPipelines: The shading rate palette state is static (pCreateInfos[%" PRIu32
Dave Houlton142c4cb2018-10-17 15:04:41 -06002167 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_VIEWPORT_SHADING_RATE_PALETTE_NV), "
2168 "but pCreateInfos[%" PRIu32 "] pShadingRatePalettes (=NULL) is an invalid pointer.",
Jeff Bolz9af91c52018-09-01 21:53:57 -05002169 i, i);
2170 }
2171
Chris Mayer328d8212018-12-11 14:16:18 +01002172 if (vp_swizzle_struct) {
2173 if (vp_swizzle_struct->viewportCount != viewport_state.viewportCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002174 skip |= LogError(device, "VUID-VkPipelineViewportSwizzleStateCreateInfoNV-viewportCount-01215",
2175 "vkCreateGraphicsPipelines: The viewport swizzle state vieport count of %" PRIu32
2176 " does "
2177 "not match the viewport count of %" PRIu32 " in VkPipelineViewportStateCreateInfo.",
2178 vp_swizzle_struct->viewportCount, viewport_state.viewportCount);
Chris Mayer328d8212018-12-11 14:16:18 +01002179 }
2180 }
2181
Petr Krausb3fcdb42018-01-09 22:09:09 +01002182 // validate the VkViewports
2183 if (!has_dynamic_viewport && viewport_state.pViewports) {
2184 for (uint32_t viewport_i = 0; viewport_i < viewport_state.viewportCount; ++viewport_i) {
2185 const auto &viewport = viewport_state.pViewports[viewport_i]; // will crash on invalid ptr
Jeff Bolz6d3beaa2019-02-09 21:00:05 -06002186 const char *fn_name = "vkCreateGraphicsPipelines";
2187 skip |= manual_PreCallValidateViewport(viewport, fn_name,
2188 ParameterName("pCreateInfos[%i].pViewportState->pViewports[%i]",
2189 ParameterName::IndexVector{i, viewport_i}),
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002190 VkCommandBuffer(0));
Petr Krausb3fcdb42018-01-09 22:09:09 +01002191 }
2192 }
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07002193
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002194 if (has_dynamic_viewport_w_scaling_nv && !device_extensions.vk_nv_clip_space_w_scaling) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002195 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
2196 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2197 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_VIEWPORT_W_SCALING_NV, but "
2198 "VK_NV_clip_space_w_scaling extension is not enabled.",
2199 i);
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07002200 }
2201
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002202 if (has_dynamic_discard_rectangle_ext && !device_extensions.vk_ext_discard_rectangles) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002203 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
2204 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2205 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_DISCARD_RECTANGLE_EXT, but "
2206 "VK_EXT_discard_rectangles extension is not enabled.",
2207 i);
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07002208 }
2209
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002210 if (has_dynamic_sample_locations_ext && !device_extensions.vk_ext_sample_locations) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002211 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
2212 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2213 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_SAMPLE_LOCATIONS_EXT, but "
2214 "VK_EXT_sample_locations extension is not enabled.",
2215 i);
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07002216 }
Jeff Bolz3e71f782018-08-29 23:15:45 -05002217
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002218 if (has_dynamic_exclusive_scissor_nv && !device_extensions.vk_nv_scissor_exclusive) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002219 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
2220 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2221 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV, but "
2222 "VK_NV_scissor_exclusive extension is not enabled.",
2223 i);
Jeff Bolz3e71f782018-08-29 23:15:45 -05002224 }
Jeff Bolz9af91c52018-09-01 21:53:57 -05002225
2226 if (coarse_sample_order_struct &&
2227 coarse_sample_order_struct->sampleOrderType != VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV &&
2228 coarse_sample_order_struct->customSampleOrderCount != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002229 skip |= LogError(device, "VUID-VkPipelineViewportCoarseSampleOrderStateCreateInfoNV-sampleOrderType-02072",
2230 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2231 "] "
2232 "VkPipelineViewportCoarseSampleOrderStateCreateInfoNV sampleOrderType is not "
2233 "VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV and customSampleOrderCount is not 0.",
2234 i);
Jeff Bolz9af91c52018-09-01 21:53:57 -05002235 }
2236
2237 if (coarse_sample_order_struct) {
2238 for (uint32_t order_i = 0; order_i < coarse_sample_order_struct->customSampleOrderCount; ++order_i) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002239 skip |= ValidateCoarseSampleOrderCustomNV(&coarse_sample_order_struct->pCustomSampleOrders[order_i]);
Jeff Bolz9af91c52018-09-01 21:53:57 -05002240 }
2241 }
Chris Mayer9ded5eb2019-09-19 16:33:26 +02002242
2243 if (vp_w_scaling_struct && (vp_w_scaling_struct->viewportWScalingEnable == VK_TRUE)) {
2244 if (vp_w_scaling_struct->viewportCount != viewport_state.viewportCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002245 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-viewportWScalingEnable-01726",
2246 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2247 "] "
2248 "VkPipelineViewportWScalingStateCreateInfoNV.viewportCount (=%" PRIu32
2249 ") "
2250 "is not equal to VkPipelineViewportStateCreateInfo.viewportCount (=%" PRIu32 ").",
2251 i, vp_w_scaling_struct->viewportCount, viewport_state.viewportCount);
Chris Mayer9ded5eb2019-09-19 16:33:26 +02002252 }
2253 if (!has_dynamic_viewport_w_scaling_nv && !vp_w_scaling_struct->pViewportWScalings) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002254 skip |= LogError(
2255 device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-01715",
Chris Mayer9ded5eb2019-09-19 16:33:26 +02002256 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2257 "] "
2258 "VkPipelineViewportWScalingStateCreateInfoNV.pViewportWScalings (=NULL) is not a valid array.",
2259 i);
2260 }
2261 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002262 }
2263
2264 if (pCreateInfos[i].pMultisampleState == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002265 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-rasterizerDiscardEnable-00751",
2266 "vkCreateGraphicsPipelines: if pCreateInfos[%d].pRasterizationState->rasterizerDiscardEnable "
2267 "is VK_FALSE, pCreateInfos[%d].pMultisampleState must not be NULL.",
2268 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002269 } else {
Dave Houltonb3bbec72018-01-17 10:13:33 -07002270 const VkStructureType valid_next_stypes[] = {LvlTypeMap<VkPipelineCoverageModulationStateCreateInfoNV>::kSType,
Mark Lobodzinski1ddf16f2020-08-13 08:58:13 -06002271 LvlTypeMap<VkPipelineCoverageReductionStateCreateInfoNV>::kSType,
Dave Houltonb3bbec72018-01-17 10:13:33 -07002272 LvlTypeMap<VkPipelineCoverageToColorStateCreateInfoNV>::kSType,
2273 LvlTypeMap<VkPipelineSampleLocationsStateCreateInfoEXT>::kSType};
Mike Schuchardt97662b02017-12-06 13:31:29 -07002274 const char *valid_struct_names =
Dave Houltona9df0ce2018-02-07 10:51:23 -07002275 "VkPipelineCoverageModulationStateCreateInfoNV, VkPipelineCoverageToColorStateCreateInfoNV, "
John Zulauf96b0e422017-11-14 11:43:19 -07002276 "VkPipelineSampleLocationsStateCreateInfoEXT";
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002277 skip |= validate_struct_pnext(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002278 "vkCreateGraphicsPipelines",
John Zulauf96b0e422017-11-14 11:43:19 -07002279 ParameterName("pCreateInfos[%i].pMultisampleState->pNext", ParameterName::IndexVector{i}),
Mark Lobodzinski1ddf16f2020-08-13 08:58:13 -06002280 valid_struct_names, pCreateInfos[i].pMultisampleState->pNext, 4, valid_next_stypes,
sfricke-samsung32a27362020-02-28 09:06:42 -08002281 GeneratedVulkanHeaderVersion, "VUID-VkPipelineMultisampleStateCreateInfo-pNext-pNext",
2282 "VUID-VkPipelineMultisampleStateCreateInfo-sType-unique");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002283
2284 skip |= validate_reserved_flags(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002285 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002286 ParameterName("pCreateInfos[%i].pMultisampleState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06002287 pCreateInfos[i].pMultisampleState->flags, "VUID-VkPipelineMultisampleStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002288
2289 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002290 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002291 ParameterName("pCreateInfos[%i].pMultisampleState->sampleShadingEnable", ParameterName::IndexVector{i}),
2292 pCreateInfos[i].pMultisampleState->sampleShadingEnable);
2293
2294 skip |= validate_array(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002295 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002296 ParameterName("pCreateInfos[%i].pMultisampleState->rasterizationSamples", ParameterName::IndexVector{i}),
2297 ParameterName("pCreateInfos[%i].pMultisampleState->pSampleMask", ParameterName::IndexVector{i}),
Gabríel Arthúr Pétursson092b29b2018-03-21 22:44:11 +00002298 pCreateInfos[i].pMultisampleState->rasterizationSamples, &pCreateInfos[i].pMultisampleState->pSampleMask,
Dave Houlton413a6782018-05-22 13:01:54 -06002299 true, false, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002300
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002301 skip |= validate_flags(
2302 "vkCreateGraphicsPipelines",
2303 ParameterName("pCreateInfos[%i].pMultisampleState->rasterizationSamples", ParameterName::IndexVector{i}),
2304 "VkSampleCountFlagBits", AllVkSampleCountFlagBits, pCreateInfos[i].pMultisampleState->rasterizationSamples,
Petr Kraus52758be2019-08-12 00:53:58 +02002305 kRequiredSingleBit, "VUID-VkPipelineMultisampleStateCreateInfo-rasterizationSamples-parameter");
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002306
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002307 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002308 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002309 ParameterName("pCreateInfos[%i].pMultisampleState->alphaToCoverageEnable", ParameterName::IndexVector{i}),
2310 pCreateInfos[i].pMultisampleState->alphaToCoverageEnable);
2311
2312 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002313 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002314 ParameterName("pCreateInfos[%i].pMultisampleState->alphaToOneEnable", ParameterName::IndexVector{i}),
2315 pCreateInfos[i].pMultisampleState->alphaToOneEnable);
2316
2317 if (pCreateInfos[i].pMultisampleState->sType != VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO) {
sfricke-samsung81c56f72020-08-23 22:14:41 -07002318 skip |= LogError(device, "VUID-VkPipelineMultisampleStateCreateInfo-sType-sType",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002319 "vkCreateGraphicsPipelines: parameter pCreateInfos[%d].pMultisampleState->sType must be "
2320 "VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO",
2321 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002322 }
John Zulauf7acac592017-11-06 11:15:53 -07002323 if (pCreateInfos[i].pMultisampleState->sampleShadingEnable == VK_TRUE) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002324 if (!physical_device_features.sampleRateShading) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002325 skip |= LogError(device, "VUID-VkPipelineMultisampleStateCreateInfo-sampleShadingEnable-00784",
2326 "vkCreateGraphicsPipelines(): parameter "
2327 "pCreateInfos[%d].pMultisampleState->sampleShadingEnable.",
2328 i);
John Zulauf7acac592017-11-06 11:15:53 -07002329 }
2330 // TODO Add documentation issue about when minSampleShading must be in range and when it is ignored
2331 // For now a "least noise" test *only* when sampleShadingEnable is VK_TRUE.
2332 if (!in_inclusive_range(pCreateInfos[i].pMultisampleState->minSampleShading, 0.F, 1.0F)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002333 skip |= LogError(
2334 device,
2335
Dave Houlton413a6782018-05-22 13:01:54 -06002336 "VUID-VkPipelineMultisampleStateCreateInfo-minSampleShading-00786",
Mark Lobodzinski88529492018-04-01 10:38:15 -06002337 "vkCreateGraphicsPipelines(): parameter pCreateInfos[%d].pMultisampleState->minSampleShading.", i);
John Zulauf7acac592017-11-06 11:15:53 -07002338 }
2339 }
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002340
2341 const auto *line_state = lvl_find_in_chain<VkPipelineRasterizationLineStateCreateInfoEXT>(
2342 pCreateInfos[i].pRasterizationState->pNext);
2343
2344 if (line_state) {
2345 if ((line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_BRESENHAM_EXT ||
2346 line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_RECTANGULAR_SMOOTH_EXT)) {
2347 if (pCreateInfos[i].pMultisampleState->alphaToCoverageEnable) {
2348 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002349 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-lineRasterizationMode-02766",
2350 "vkCreateGraphicsPipelines(): Bresenham/Smooth line rasterization not supported with "
2351 "pCreateInfos[%d].pMultisampleState->alphaToCoverageEnable == VK_TRUE.",
2352 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002353 }
2354 if (pCreateInfos[i].pMultisampleState->alphaToOneEnable) {
2355 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002356 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-lineRasterizationMode-02766",
2357 "vkCreateGraphicsPipelines(): Bresenham/Smooth line rasterization not supported with "
2358 "pCreateInfos[%d].pMultisampleState->alphaToOneEnable == VK_TRUE.",
2359 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002360 }
2361 if (pCreateInfos[i].pMultisampleState->sampleShadingEnable) {
2362 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002363 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-lineRasterizationMode-02766",
2364 "vkCreateGraphicsPipelines(): Bresenham/Smooth line rasterization not supported with "
2365 "pCreateInfos[%d].pMultisampleState->sampleShadingEnable == VK_TRUE.",
2366 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002367 }
2368 }
2369 if (line_state->stippledLineEnable && !has_dynamic_line_stipple) {
2370 if (line_state->lineStippleFactor < 1 || line_state->lineStippleFactor > 256) {
2371 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002372 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-stippledLineEnable-02767",
2373 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineStippleFactor = %d must be in the "
2374 "range [1,256].",
2375 i, line_state->lineStippleFactor);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002376 }
2377 }
2378 const auto *line_features =
Tony-LunarG6c3c5452019-12-13 10:37:38 -07002379 lvl_find_in_chain<VkPhysicalDeviceLineRasterizationFeaturesEXT>(device_createinfo_pnext);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002380 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_RECTANGULAR_EXT &&
2381 (!line_features || !line_features->rectangularLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002382 skip |=
2383 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-lineRasterizationMode-02768",
2384 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineRasterizationMode = "
2385 "VK_LINE_RASTERIZATION_MODE_RECTANGULAR_EXT requires the rectangularLines feature.",
2386 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002387 }
2388 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_BRESENHAM_EXT &&
2389 (!line_features || !line_features->bresenhamLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002390 skip |=
2391 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-lineRasterizationMode-02769",
2392 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineRasterizationMode = "
2393 "VK_LINE_RASTERIZATION_MODE_BRESENHAM_EXT requires the bresenhamLines feature.",
2394 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002395 }
2396 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_RECTANGULAR_SMOOTH_EXT &&
2397 (!line_features || !line_features->smoothLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002398 skip |=
2399 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-lineRasterizationMode-02770",
2400 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineRasterizationMode = "
2401 "VK_LINE_RASTERIZATION_MODE_RECTANGULAR_SMOOTH_EXT requires the smoothLines feature.",
2402 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002403 }
2404 if (line_state->stippledLineEnable) {
2405 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_RECTANGULAR_EXT &&
2406 (!line_features || !line_features->stippledRectangularLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002407 skip |=
2408 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-stippledLineEnable-02771",
2409 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineRasterizationMode = "
2410 "VK_LINE_RASTERIZATION_MODE_RECTANGULAR_EXT with stipple requires the "
2411 "stippledRectangularLines feature.",
2412 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002413 }
2414 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_BRESENHAM_EXT &&
2415 (!line_features || !line_features->stippledBresenhamLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002416 skip |=
2417 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-stippledLineEnable-02772",
2418 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineRasterizationMode = "
2419 "VK_LINE_RASTERIZATION_MODE_BRESENHAM_EXT with stipple requires the "
2420 "stippledBresenhamLines feature.",
2421 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002422 }
2423 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_RECTANGULAR_SMOOTH_EXT &&
2424 (!line_features || !line_features->stippledSmoothLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002425 skip |=
2426 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-stippledLineEnable-02773",
2427 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineRasterizationMode = "
2428 "VK_LINE_RASTERIZATION_MODE_RECTANGULAR_SMOOTH_EXT with stipple requires the "
2429 "stippledSmoothLines feature.",
2430 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002431 }
2432 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_DEFAULT_EXT &&
2433 (!line_features || !line_features->stippledSmoothLines || !device_limits.strictLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002434 skip |=
2435 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-stippledLineEnable-02774",
2436 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineRasterizationMode = "
2437 "VK_LINE_RASTERIZATION_MODE_DEFAULT_EXT with stipple requires the "
2438 "stippledRectangularLines and strictLines features.",
2439 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002440 }
2441 }
2442 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002443 }
2444
Petr Krause91f7a12017-12-14 20:57:36 +01002445 bool uses_color_attachment = false;
2446 bool uses_depthstencil_attachment = false;
2447 {
Mark Lobodzinskif27a6bc2019-02-04 13:00:49 -07002448 std::unique_lock<std::mutex> lock(renderpass_map_mutex);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002449 const auto subpasses_uses_it = renderpasses_states.find(pCreateInfos[i].renderPass);
2450 if (subpasses_uses_it != renderpasses_states.end()) {
Petr Krause91f7a12017-12-14 20:57:36 +01002451 const auto &subpasses_uses = subpasses_uses_it->second;
2452 if (subpasses_uses.subpasses_using_color_attachment.count(pCreateInfos[i].subpass))
2453 uses_color_attachment = true;
2454 if (subpasses_uses.subpasses_using_depthstencil_attachment.count(pCreateInfos[i].subpass))
2455 uses_depthstencil_attachment = true;
2456 }
Mark Lobodzinskif27a6bc2019-02-04 13:00:49 -07002457 lock.unlock();
Petr Krause91f7a12017-12-14 20:57:36 +01002458 }
2459
2460 if (pCreateInfos[i].pDepthStencilState != nullptr && uses_depthstencil_attachment) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002461 skip |= validate_struct_pnext(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002462 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002463 ParameterName("pCreateInfos[%i].pDepthStencilState->pNext", ParameterName::IndexVector{i}), NULL,
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002464 pCreateInfos[i].pDepthStencilState->pNext, 0, NULL, GeneratedVulkanHeaderVersion,
sfricke-samsung32a27362020-02-28 09:06:42 -08002465 "VUID-VkPipelineDepthStencilStateCreateInfo-pNext-pNext", nullptr);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002466
2467 skip |= validate_reserved_flags(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002468 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002469 ParameterName("pCreateInfos[%i].pDepthStencilState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06002470 pCreateInfos[i].pDepthStencilState->flags, "VUID-VkPipelineDepthStencilStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002471
2472 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002473 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002474 ParameterName("pCreateInfos[%i].pDepthStencilState->depthTestEnable", ParameterName::IndexVector{i}),
2475 pCreateInfos[i].pDepthStencilState->depthTestEnable);
2476
2477 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002478 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002479 ParameterName("pCreateInfos[%i].pDepthStencilState->depthWriteEnable", ParameterName::IndexVector{i}),
2480 pCreateInfos[i].pDepthStencilState->depthWriteEnable);
2481
2482 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002483 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002484 ParameterName("pCreateInfos[%i].pDepthStencilState->depthCompareOp", ParameterName::IndexVector{i}),
2485 "VkCompareOp", AllVkCompareOpEnums, pCreateInfos[i].pDepthStencilState->depthCompareOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002486 "VUID-VkPipelineDepthStencilStateCreateInfo-depthCompareOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002487
2488 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002489 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002490 ParameterName("pCreateInfos[%i].pDepthStencilState->depthBoundsTestEnable", ParameterName::IndexVector{i}),
2491 pCreateInfos[i].pDepthStencilState->depthBoundsTestEnable);
2492
2493 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002494 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002495 ParameterName("pCreateInfos[%i].pDepthStencilState->stencilTestEnable", ParameterName::IndexVector{i}),
2496 pCreateInfos[i].pDepthStencilState->stencilTestEnable);
2497
2498 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002499 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002500 ParameterName("pCreateInfos[%i].pDepthStencilState->front.failOp", ParameterName::IndexVector{i}),
2501 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->front.failOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002502 "VUID-VkStencilOpState-failOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002503
2504 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002505 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002506 ParameterName("pCreateInfos[%i].pDepthStencilState->front.passOp", ParameterName::IndexVector{i}),
2507 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->front.passOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002508 "VUID-VkStencilOpState-passOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002509
2510 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002511 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002512 ParameterName("pCreateInfos[%i].pDepthStencilState->front.depthFailOp", ParameterName::IndexVector{i}),
2513 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->front.depthFailOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002514 "VUID-VkStencilOpState-depthFailOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002515
2516 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002517 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002518 ParameterName("pCreateInfos[%i].pDepthStencilState->front.compareOp", ParameterName::IndexVector{i}),
2519 "VkCompareOp", AllVkCompareOpEnums, pCreateInfos[i].pDepthStencilState->front.compareOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002520 "VUID-VkPipelineDepthStencilStateCreateInfo-depthCompareOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002521
2522 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002523 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002524 ParameterName("pCreateInfos[%i].pDepthStencilState->back.failOp", ParameterName::IndexVector{i}),
2525 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->back.failOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002526 "VUID-VkStencilOpState-failOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002527
2528 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002529 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002530 ParameterName("pCreateInfos[%i].pDepthStencilState->back.passOp", ParameterName::IndexVector{i}),
2531 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->back.passOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002532 "VUID-VkStencilOpState-passOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002533
2534 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002535 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002536 ParameterName("pCreateInfos[%i].pDepthStencilState->back.depthFailOp", ParameterName::IndexVector{i}),
2537 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->back.depthFailOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002538 "VUID-VkStencilOpState-depthFailOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002539
2540 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002541 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002542 ParameterName("pCreateInfos[%i].pDepthStencilState->back.compareOp", ParameterName::IndexVector{i}),
2543 "VkCompareOp", AllVkCompareOpEnums, pCreateInfos[i].pDepthStencilState->back.compareOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002544 "VUID-VkPipelineDepthStencilStateCreateInfo-depthCompareOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002545
2546 if (pCreateInfos[i].pDepthStencilState->sType != VK_STRUCTURE_TYPE_PIPELINE_DEPTH_STENCIL_STATE_CREATE_INFO) {
sfricke-samsung81c56f72020-08-23 22:14:41 -07002547 skip |= LogError(device, "VUID-VkPipelineDepthStencilStateCreateInfo-sType-sType",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002548 "vkCreateGraphicsPipelines: parameter pCreateInfos[%d].pDepthStencilState->sType must be "
2549 "VK_STRUCTURE_TYPE_PIPELINE_DEPTH_STENCIL_STATE_CREATE_INFO",
2550 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002551 }
2552 }
2553
Shannon McPherson9b9532b2018-10-24 12:00:09 -06002554 const VkStructureType allowed_structs_VkPipelineColorBlendStateCreateInfo[] = {
2555 VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_ADVANCED_STATE_CREATE_INFO_EXT};
2556
Petr Krause91f7a12017-12-14 20:57:36 +01002557 if (pCreateInfos[i].pColorBlendState != nullptr && uses_color_attachment) {
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002558 skip |= validate_struct_type("vkCreateGraphicsPipelines",
2559 ParameterName("pCreateInfos[%i].pColorBlendState", ParameterName::IndexVector{i}),
2560 "VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO",
2561 pCreateInfos[i].pColorBlendState,
2562 VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO, false, kVUIDUndefined,
2563 "VUID-VkPipelineColorBlendStateCreateInfo-sType-sType");
2564
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002565 skip |= validate_struct_pnext(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002566 "vkCreateGraphicsPipelines",
Shannon McPherson9b9532b2018-10-24 12:00:09 -06002567 ParameterName("pCreateInfos[%i].pColorBlendState->pNext", ParameterName::IndexVector{i}),
2568 "VkPipelineColorBlendAdvancedStateCreateInfoEXT", pCreateInfos[i].pColorBlendState->pNext,
2569 ARRAY_SIZE(allowed_structs_VkPipelineColorBlendStateCreateInfo),
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002570 allowed_structs_VkPipelineColorBlendStateCreateInfo, GeneratedVulkanHeaderVersion,
sfricke-samsung32a27362020-02-28 09:06:42 -08002571 "VUID-VkPipelineColorBlendStateCreateInfo-pNext-pNext",
2572 "VUID-VkPipelineColorBlendStateCreateInfo-sType-unique");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002573
2574 skip |= validate_reserved_flags(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002575 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002576 ParameterName("pCreateInfos[%i].pColorBlendState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06002577 pCreateInfos[i].pColorBlendState->flags, "VUID-VkPipelineColorBlendStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002578
2579 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002580 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002581 ParameterName("pCreateInfos[%i].pColorBlendState->logicOpEnable", ParameterName::IndexVector{i}),
2582 pCreateInfos[i].pColorBlendState->logicOpEnable);
2583
2584 skip |= validate_array(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002585 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002586 ParameterName("pCreateInfos[%i].pColorBlendState->attachmentCount", ParameterName::IndexVector{i}),
2587 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments", ParameterName::IndexVector{i}),
Gabríel Arthúr Pétursson092b29b2018-03-21 22:44:11 +00002588 pCreateInfos[i].pColorBlendState->attachmentCount, &pCreateInfos[i].pColorBlendState->pAttachments, false,
Dave Houlton413a6782018-05-22 13:01:54 -06002589 true, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002590
2591 if (pCreateInfos[i].pColorBlendState->pAttachments != NULL) {
2592 for (uint32_t attachmentIndex = 0; attachmentIndex < pCreateInfos[i].pColorBlendState->attachmentCount;
2593 ++attachmentIndex) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002594 skip |= validate_bool32("vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002595 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].blendEnable",
2596 ParameterName::IndexVector{i, attachmentIndex}),
2597 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].blendEnable);
2598
2599 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002600 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002601 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].srcColorBlendFactor",
2602 ParameterName::IndexVector{i, attachmentIndex}),
2603 "VkBlendFactor", AllVkBlendFactorEnums,
2604 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].srcColorBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06002605 "VUID-VkPipelineColorBlendAttachmentState-srcColorBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002606
2607 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002608 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002609 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].dstColorBlendFactor",
2610 ParameterName::IndexVector{i, attachmentIndex}),
2611 "VkBlendFactor", AllVkBlendFactorEnums,
2612 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].dstColorBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06002613 "VUID-VkPipelineColorBlendAttachmentState-dstColorBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002614
2615 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002616 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002617 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].colorBlendOp",
2618 ParameterName::IndexVector{i, attachmentIndex}),
2619 "VkBlendOp", AllVkBlendOpEnums,
2620 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].colorBlendOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002621 "VUID-VkPipelineColorBlendAttachmentState-colorBlendOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002622
2623 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002624 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002625 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].srcAlphaBlendFactor",
2626 ParameterName::IndexVector{i, attachmentIndex}),
2627 "VkBlendFactor", AllVkBlendFactorEnums,
2628 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].srcAlphaBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06002629 "VUID-VkPipelineColorBlendAttachmentState-srcAlphaBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002630
2631 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002632 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002633 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].dstAlphaBlendFactor",
2634 ParameterName::IndexVector{i, attachmentIndex}),
2635 "VkBlendFactor", AllVkBlendFactorEnums,
2636 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].dstAlphaBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06002637 "VUID-VkPipelineColorBlendAttachmentState-dstAlphaBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002638
2639 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002640 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002641 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].alphaBlendOp",
2642 ParameterName::IndexVector{i, attachmentIndex}),
2643 "VkBlendOp", AllVkBlendOpEnums,
2644 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].alphaBlendOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002645 "VUID-VkPipelineColorBlendAttachmentState-alphaBlendOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002646
2647 skip |=
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002648 validate_flags("vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002649 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].colorWriteMask",
2650 ParameterName::IndexVector{i, attachmentIndex}),
2651 "VkColorComponentFlagBits", AllVkColorComponentFlagBits,
2652 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].colorWriteMask,
Petr Kraus52758be2019-08-12 00:53:58 +02002653 kOptionalFlags, "VUID-VkPipelineColorBlendAttachmentState-colorWriteMask-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002654 }
2655 }
2656
2657 if (pCreateInfos[i].pColorBlendState->sType != VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO) {
sfricke-samsung81c56f72020-08-23 22:14:41 -07002658 skip |= LogError(device, "VUID-VkPipelineColorBlendStateCreateInfo-sType-sType",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002659 "vkCreateGraphicsPipelines: parameter pCreateInfos[%d].pColorBlendState->sType must be "
2660 "VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO",
2661 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002662 }
2663
2664 // If logicOpEnable is VK_TRUE, logicOp must be a valid VkLogicOp value
2665 if (pCreateInfos[i].pColorBlendState->logicOpEnable == VK_TRUE) {
2666 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002667 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002668 ParameterName("pCreateInfos[%i].pColorBlendState->logicOp", ParameterName::IndexVector{i}), "VkLogicOp",
Dave Houlton413a6782018-05-22 13:01:54 -06002669 AllVkLogicOpEnums, pCreateInfos[i].pColorBlendState->logicOp,
2670 "VUID-VkPipelineColorBlendStateCreateInfo-logicOpEnable-00607");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002671 }
2672 }
2673 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002674
Petr Kraus9752aae2017-11-24 03:05:50 +01002675 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_DERIVATIVE_BIT) {
2676 if (pCreateInfos[i].basePipelineIndex != -1) {
2677 if (pCreateInfos[i].basePipelineHandle != VK_NULL_HANDLE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002678 skip |=
2679 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-00724",
sfricke-samsunga470e0e2020-05-16 00:47:36 -07002680 "vkCreateGraphicsPipelines parameter, pCreateInfos[%u]->basePipelineHandle, must be "
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002681 "VK_NULL_HANDLE if pCreateInfos->flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT flag "
sfricke-samsunga470e0e2020-05-16 00:47:36 -07002682 "and pCreateInfos->basePipelineIndex is not -1.",
2683 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002684 }
2685 }
2686
Petr Kraus9752aae2017-11-24 03:05:50 +01002687 if (pCreateInfos[i].basePipelineHandle != VK_NULL_HANDLE) {
2688 if (pCreateInfos[i].basePipelineIndex != -1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002689 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-00725",
sfricke-samsunga470e0e2020-05-16 00:47:36 -07002690 "vkCreateGraphicsPipelines parameter, pCreateInfos[%u]->basePipelineIndex, must be -1 if "
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002691 "pCreateInfos->flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT flag and "
sfricke-samsunga470e0e2020-05-16 00:47:36 -07002692 "pCreateInfos->basePipelineHandle is not VK_NULL_HANDLE.",
2693 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002694 }
Mark Lobodzinski4dfeb942019-09-13 12:11:13 -06002695 } else {
Mike Schuchardte5c15cf2020-04-06 22:57:13 -07002696 if (static_cast<uint32_t>(pCreateInfos[i].basePipelineIndex) >= createInfoCount) {
sfricke-samsunga470e0e2020-05-16 00:47:36 -07002697 skip |=
2698 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-00723",
2699 "vkCreateGraphicsPipelines parameter pCreateInfos[%u]->basePipelineIndex (%d) must be a valid"
2700 "index into the pCreateInfos array, of size %d.",
2701 i, pCreateInfos[i].basePipelineIndex, createInfoCount);
Mark Lobodzinski4dfeb942019-09-13 12:11:13 -06002702 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002703 }
2704 }
2705
sfricke-samsung898cf222020-05-15 23:10:19 -07002706 if ((pCreateInfos[i].flags & VK_PIPELINE_CREATE_DISPATCH_BASE) != 0) {
2707 skip |= LogError(
2708 device, "VUID-VkGraphicsPipelineCreateInfo-flags-00764",
2709 "vkCreateGraphicsPipelines parameter pCreateInfos[%u]->flags must not contain VK_PIPELINE_CREATE_DISPATCH_BASE",
2710 i);
2711 }
2712
Petr Kraus9752aae2017-11-24 03:05:50 +01002713 if (pCreateInfos[i].pRasterizationState) {
Chris Mayer840b2c42019-08-22 18:12:22 +02002714 if (!device_extensions.vk_nv_fill_rectangle) {
2715 if (pCreateInfos[i].pRasterizationState->polygonMode == VK_POLYGON_MODE_FILL_RECTANGLE_NV) {
2716 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002717 LogError(device, "VUID-VkPipelineRasterizationStateCreateInfo-polygonMode-01414",
2718 "vkCreateGraphicsPipelines parameter, VkPolygonMode "
2719 "pCreateInfos->pRasterizationState->polygonMode cannot be VK_POLYGON_MODE_FILL_RECTANGLE_NV "
2720 "if the extension VK_NV_fill_rectangle is not enabled.");
Chris Mayer840b2c42019-08-22 18:12:22 +02002721 } else if ((pCreateInfos[i].pRasterizationState->polygonMode != VK_POLYGON_MODE_FILL) &&
2722 (physical_device_features.fillModeNonSolid == false)) {
sfricke-samsunga44586f2020-08-23 22:19:44 -07002723 skip |= LogError(device, "VUID-VkPipelineRasterizationStateCreateInfo-polygonMode-01413",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002724 "vkCreateGraphicsPipelines parameter, VkPolygonMode "
sfricke-samsunga470e0e2020-05-16 00:47:36 -07002725 "pCreateInfos[%u]->pRasterizationState->polygonMode cannot be VK_POLYGON_MODE_POINT or "
2726 "VK_POLYGON_MODE_LINE if VkPhysicalDeviceFeatures->fillModeNonSolid is false.",
2727 i);
Chris Mayer840b2c42019-08-22 18:12:22 +02002728 }
2729 } else {
2730 if ((pCreateInfos[i].pRasterizationState->polygonMode != VK_POLYGON_MODE_FILL) &&
2731 (pCreateInfos[i].pRasterizationState->polygonMode != VK_POLYGON_MODE_FILL_RECTANGLE_NV) &&
2732 (physical_device_features.fillModeNonSolid == false)) {
2733 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002734 LogError(device, "VUID-VkPipelineRasterizationStateCreateInfo-polygonMode-01507",
2735 "vkCreateGraphicsPipelines parameter, VkPolygonMode "
sfricke-samsunga470e0e2020-05-16 00:47:36 -07002736 "pCreateInfos[%u]->pRasterizationState->polygonMode must be VK_POLYGON_MODE_FILL or "
2737 "VK_POLYGON_MODE_FILL_RECTANGLE_NV if VkPhysicalDeviceFeatures->fillModeNonSolid is false.",
2738 i);
Chris Mayer840b2c42019-08-22 18:12:22 +02002739 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002740 }
Petr Kraus299ba622017-11-24 03:09:03 +01002741
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002742 if (!has_dynamic_line_width && !physical_device_features.wideLines &&
Petr Kraus299ba622017-11-24 03:09:03 +01002743 (pCreateInfos[i].pRasterizationState->lineWidth != 1.0f)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002744 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-00749",
2745 "The line width state is static (pCreateInfos[%" PRIu32
2746 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_LINE_WIDTH) and "
2747 "VkPhysicalDeviceFeatures::wideLines is disabled, but pCreateInfos[%" PRIu32
2748 "].pRasterizationState->lineWidth (=%f) is not 1.0.",
2749 i, i, pCreateInfos[i].pRasterizationState->lineWidth);
Petr Kraus299ba622017-11-24 03:09:03 +01002750 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002751 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002752 }
2753 }
2754
2755 return skip;
2756}
2757
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002758bool StatelessValidation::manual_PreCallValidateCreateComputePipelines(VkDevice device, VkPipelineCache pipelineCache,
2759 uint32_t createInfoCount,
2760 const VkComputePipelineCreateInfo *pCreateInfos,
2761 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05002762 VkPipeline *pPipelines) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002763 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002764 for (uint32_t i = 0; i < createInfoCount; i++) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002765 skip |= validate_string("vkCreateComputePipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002766 ParameterName("pCreateInfos[%i].stage.pName", ParameterName::IndexVector{i}),
Mark Lobodzinskiebee3552018-05-29 09:55:54 -06002767 "VUID-VkPipelineShaderStageCreateInfo-pName-parameter", pCreateInfos[i].stage.pName);
Peter Chen85366392019-05-14 15:20:11 -04002768 auto feedback_struct = lvl_find_in_chain<VkPipelineCreationFeedbackCreateInfoEXT>(pCreateInfos[i].pNext);
2769 if ((feedback_struct != nullptr) && (feedback_struct->pipelineStageCreationFeedbackCount != 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002770 skip |=
2771 LogError(device, "VUID-VkPipelineCreationFeedbackCreateInfoEXT-pipelineStageCreationFeedbackCount-02669",
2772 "vkCreateComputePipelines(): in pCreateInfo[%" PRIu32
2773 "], VkPipelineCreationFeedbackEXT::pipelineStageCreationFeedbackCount must equal 1, found %" PRIu32 ".",
2774 i, feedback_struct->pipelineStageCreationFeedbackCount);
Peter Chen85366392019-05-14 15:20:11 -04002775 }
sfricke-samsungc5227152020-02-09 17:36:31 -08002776
2777 // Make sure compute stage is selected
2778 if (pCreateInfos[i].stage.stage != VK_SHADER_STAGE_COMPUTE_BIT) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002779 skip |= LogError(device, "VUID-VkComputePipelineCreateInfo-stage-00701",
2780 "vkCreateComputePipelines(): the pCreateInfo[%u].stage.stage (%s) is not VK_SHADER_STAGE_COMPUTE_BIT",
2781 i, string_VkShaderStageFlagBits(pCreateInfos[i].stage.stage));
sfricke-samsungc5227152020-02-09 17:36:31 -08002782 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002783 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002784 return skip;
2785}
2786
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002787bool StatelessValidation::manual_PreCallValidateCreateSampler(VkDevice device, const VkSamplerCreateInfo *pCreateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -05002788 const VkAllocationCallbacks *pAllocator, VkSampler *pSampler) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002789 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002790
2791 if (pCreateInfo != nullptr) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002792 const auto &features = physical_device_features;
2793 const auto &limits = device_limits;
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002794
John Zulauf71968502017-10-26 13:51:15 -06002795 if (pCreateInfo->anisotropyEnable == VK_TRUE) {
2796 if (!in_inclusive_range(pCreateInfo->maxAnisotropy, 1.0F, limits.maxSamplerAnisotropy)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002797 skip |= LogError(device, "VUID-VkSamplerCreateInfo-anisotropyEnable-01071",
2798 "vkCreateSampler(): value of %s must be in range [1.0, %f] %s, but %f found.",
2799 "pCreateInfo->maxAnisotropy", limits.maxSamplerAnisotropy,
2800 "VkPhysicalDeviceLimits::maxSamplerAnistropy", pCreateInfo->maxAnisotropy);
John Zulauf71968502017-10-26 13:51:15 -06002801 }
2802
2803 // Anistropy cannot be enabled in sampler unless enabled as a feature
2804 if (features.samplerAnisotropy == VK_FALSE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002805 skip |= LogError(device, "VUID-VkSamplerCreateInfo-anisotropyEnable-01070",
2806 "vkCreateSampler(): Anisotropic sampling feature is not enabled, %s must be VK_FALSE.",
2807 "pCreateInfo->anisotropyEnable");
John Zulauf71968502017-10-26 13:51:15 -06002808 }
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002809 }
John Zulauf71968502017-10-26 13:51:15 -06002810
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002811 if (pCreateInfo->unnormalizedCoordinates == VK_TRUE) {
2812 if (pCreateInfo->minFilter != pCreateInfo->magFilter) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002813 skip |= LogError(device, "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01072",
2814 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
2815 "pCreateInfo->minFilter (%s) and pCreateInfo->magFilter (%s) must be equal.",
2816 string_VkFilter(pCreateInfo->minFilter), string_VkFilter(pCreateInfo->magFilter));
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002817 }
2818 if (pCreateInfo->mipmapMode != VK_SAMPLER_MIPMAP_MODE_NEAREST) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002819 skip |= LogError(device, "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01073",
2820 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
2821 "pCreateInfo->mipmapMode (%s) must be VK_SAMPLER_MIPMAP_MODE_NEAREST.",
2822 string_VkSamplerMipmapMode(pCreateInfo->mipmapMode));
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002823 }
2824 if (pCreateInfo->minLod != 0.0f || pCreateInfo->maxLod != 0.0f) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002825 skip |= LogError(device, "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01074",
2826 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
2827 "pCreateInfo->minLod (%f) and pCreateInfo->maxLod (%f) must both be zero.",
2828 pCreateInfo->minLod, pCreateInfo->maxLod);
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002829 }
2830 if ((pCreateInfo->addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE &&
2831 pCreateInfo->addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER) ||
2832 (pCreateInfo->addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE &&
2833 pCreateInfo->addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002834 skip |= LogError(device, "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01075",
2835 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
2836 "pCreateInfo->addressModeU (%s) and pCreateInfo->addressModeV (%s) must both be "
2837 "VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE or VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER.",
2838 string_VkSamplerAddressMode(pCreateInfo->addressModeU),
2839 string_VkSamplerAddressMode(pCreateInfo->addressModeV));
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002840 }
2841 if (pCreateInfo->anisotropyEnable == VK_TRUE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002842 skip |= LogError(device, "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01076",
2843 "vkCreateSampler(): pCreateInfo->anisotropyEnable and pCreateInfo->unnormalizedCoordinates must "
2844 "not both be VK_TRUE.");
John Zulauf71968502017-10-26 13:51:15 -06002845 }
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002846 if (pCreateInfo->compareEnable == VK_TRUE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002847 skip |= LogError(device, "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01077",
2848 "vkCreateSampler(): pCreateInfo->compareEnable and pCreateInfo->unnormalizedCoordinates must "
2849 "not both be VK_TRUE.");
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002850 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002851 }
2852
2853 // If compareEnable is VK_TRUE, compareOp must be a valid VkCompareOp value
2854 if (pCreateInfo->compareEnable == VK_TRUE) {
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002855 skip |= validate_ranged_enum("vkCreateSampler", "pCreateInfo->compareOp", "VkCompareOp", AllVkCompareOpEnums,
2856 pCreateInfo->compareOp, "VUID-VkSamplerCreateInfo-compareEnable-01080");
sfricke-samsung85252fb2020-05-08 20:44:06 -07002857 const auto *sampler_reduction = lvl_find_in_chain<VkSamplerReductionModeCreateInfo>(pCreateInfo->pNext);
2858 if (sampler_reduction != nullptr) {
2859 if (sampler_reduction->reductionMode != VK_SAMPLER_REDUCTION_MODE_WEIGHTED_AVERAGE) {
2860 skip |= LogError(
2861 device, "VUID-VkSamplerCreateInfo-compareEnable-01423",
2862 "copmareEnable is true so the sampler reduction mode must be VK_SAMPLER_REDUCTION_MODE_WEIGHTED_AVERAGE.");
2863 }
2864 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002865 }
2866
2867 // If any of addressModeU, addressModeV or addressModeW are VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER, borderColor must be a
2868 // valid VkBorderColor value
2869 if ((pCreateInfo->addressModeU == VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER) ||
2870 (pCreateInfo->addressModeV == VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER) ||
2871 (pCreateInfo->addressModeW == VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER)) {
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002872 skip |= validate_ranged_enum("vkCreateSampler", "pCreateInfo->borderColor", "VkBorderColor", AllVkBorderColorEnums,
2873 pCreateInfo->borderColor, "VUID-VkSamplerCreateInfo-addressModeU-01078");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002874 }
2875
2876 // If any of addressModeU, addressModeV or addressModeW are VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE, the
2877 // VK_KHR_sampler_mirror_clamp_to_edge extension must be enabled
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002878 if (!device_extensions.vk_khr_sampler_mirror_clamp_to_edge &&
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002879 ((pCreateInfo->addressModeU == VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE) ||
2880 (pCreateInfo->addressModeV == VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE) ||
2881 (pCreateInfo->addressModeW == VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE))) {
Dave Houlton413a6782018-05-22 13:01:54 -06002882 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002883 LogError(device, "VUID-VkSamplerCreateInfo-addressModeU-01079",
2884 "vkCreateSampler(): A VkSamplerAddressMode value is set to VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE "
2885 "but the VK_KHR_sampler_mirror_clamp_to_edge extension has not been enabled.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002886 }
John Zulauf275805c2017-10-26 15:34:49 -06002887
2888 // Checks for the IMG cubic filtering extension
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002889 if (device_extensions.vk_img_filter_cubic) {
John Zulauf275805c2017-10-26 15:34:49 -06002890 if ((pCreateInfo->anisotropyEnable == VK_TRUE) &&
2891 ((pCreateInfo->minFilter == VK_FILTER_CUBIC_IMG) || (pCreateInfo->magFilter == VK_FILTER_CUBIC_IMG))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002892 skip |= LogError(device, "VUID-VkSamplerCreateInfo-magFilter-01081",
2893 "vkCreateSampler(): Anisotropic sampling must not be VK_TRUE when either minFilter or magFilter "
2894 "are VK_FILTER_CUBIC_IMG.");
John Zulauf275805c2017-10-26 15:34:49 -06002895 }
2896 }
Mark Lobodzinski61992fc2020-01-14 14:00:08 -07002897
sfricke-samsungd91da4a2020-02-09 17:19:04 -08002898 // Check for valid Lod range
2899 if (pCreateInfo->minLod > pCreateInfo->maxLod) {
Mark Lobodzinski728ab482020-02-12 13:46:47 -07002900 skip |=
2901 LogError(device, "VUID-VkSamplerCreateInfo-maxLod-01973",
2902 "vkCreateSampler(): minLod (%f) is greater than maxLod (%f)", pCreateInfo->minLod, pCreateInfo->maxLod);
sfricke-samsungd91da4a2020-02-09 17:19:04 -08002903 }
2904
2905 // Check mipLodBias to device limit
2906 if (pCreateInfo->mipLodBias > limits.maxSamplerLodBias) {
Mark Lobodzinski728ab482020-02-12 13:46:47 -07002907 skip |= LogError(device, "VUID-VkSamplerCreateInfo-mipLodBias-01069",
2908 "vkCreateSampler(): mipLodBias (%f) is greater than VkPhysicalDeviceLimits::maxSamplerLodBias (%f)",
2909 pCreateInfo->mipLodBias, limits.maxSamplerLodBias);
sfricke-samsungd91da4a2020-02-09 17:19:04 -08002910 }
2911
Mark Lobodzinski61992fc2020-01-14 14:00:08 -07002912 const auto *sampler_conversion = lvl_find_in_chain<VkSamplerYcbcrConversionInfo>(pCreateInfo->pNext);
2913 if (sampler_conversion != nullptr) {
2914 if ((pCreateInfo->addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE) ||
2915 (pCreateInfo->addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE) ||
2916 (pCreateInfo->addressModeW != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE) ||
2917 (pCreateInfo->anisotropyEnable != VK_FALSE) || (pCreateInfo->unnormalizedCoordinates != VK_FALSE)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002918 skip |= LogError(
Mark Lobodzinski728ab482020-02-12 13:46:47 -07002919 device, "VUID-VkSamplerCreateInfo-addressModeU-01646",
Mark Lobodzinski61992fc2020-01-14 14:00:08 -07002920 "vkCreateSampler(): SamplerYCbCrConversion is enabled: "
2921 "addressModeU (%s), addressModeV (%s), addressModeW (%s) must be CLAMP_TO_EDGE, and anisotropyEnable (%s) "
2922 "and unnormalizedCoordinates (%s) must be VK_FALSE.",
2923 string_VkSamplerAddressMode(pCreateInfo->addressModeU), string_VkSamplerAddressMode(pCreateInfo->addressModeV),
2924 string_VkSamplerAddressMode(pCreateInfo->addressModeW), pCreateInfo->anisotropyEnable ? "VK_TRUE" : "VK_FALSE",
2925 pCreateInfo->unnormalizedCoordinates ? "VK_TRUE" : "VK_FALSE");
2926 }
2927 }
janharaldfredriksen-arm3b793772020-05-12 18:55:53 +02002928
2929 if (pCreateInfo->flags & VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT) {
2930 if (pCreateInfo->minFilter != pCreateInfo->magFilter) {
2931 skip |= LogError(device, "VUID-VkSamplerCreateInfo-flags-02574",
2932 "vkCreateSampler(): when flags includes VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT, "
2933 "pCreateInfo->minFilter (%s) and pCreateInfo->magFilter (%s) must be equal.",
2934 string_VkFilter(pCreateInfo->minFilter), string_VkFilter(pCreateInfo->magFilter));
2935 }
2936 if (pCreateInfo->mipmapMode != VK_SAMPLER_MIPMAP_MODE_NEAREST) {
2937 skip |= LogError(device, "VUID-VkSamplerCreateInfo-flags-02575",
2938 "vkCreateSampler(): when flags includes VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT, "
2939 "pCreateInfo->mipmapMode (%s) must be VK_SAMPLER_MIPMAP_MODE_NEAREST.",
2940 string_VkSamplerMipmapMode(pCreateInfo->mipmapMode));
2941 }
2942 if (pCreateInfo->minLod != 0.0 || pCreateInfo->maxLod != 0.0) {
2943 skip |= LogError(device, "VUID-VkSamplerCreateInfo-flags-02576",
2944 "vkCreateSampler(): when flags includes VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT, "
2945 "pCreateInfo->minLod (%f) and pCreateInfo->maxLod (%f) must be zero.",
2946 pCreateInfo->minLod, pCreateInfo->maxLod);
2947 }
2948 if (((pCreateInfo->addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE) &&
2949 (pCreateInfo->addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER)) ||
2950 ((pCreateInfo->addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE) &&
2951 (pCreateInfo->addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER))) {
2952 skip |= LogError(device, "VUID-VkSamplerCreateInfo-flags-02577",
2953 "vkCreateSampler(): when flags includes VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT, "
2954 "pCreateInfo->addressModeU (%s) and pCreateInfo->addressModeV (%s) must be "
2955 "VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE or VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER",
2956 string_VkSamplerAddressMode(pCreateInfo->addressModeU),
2957 string_VkSamplerAddressMode(pCreateInfo->addressModeV));
2958 }
2959 if (pCreateInfo->anisotropyEnable) {
2960 skip |= LogError(device, "VUID-VkSamplerCreateInfo-flags-02578",
2961 "vkCreateSampler(): when flags includes VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT, "
2962 "pCreateInfo->anisotropyEnable must be VK_FALSE");
2963 }
2964 if (pCreateInfo->compareEnable) {
2965 skip |= LogError(device, "VUID-VkSamplerCreateInfo-flags-02579",
2966 "vkCreateSampler(): when flags includes VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT, "
2967 "pCreateInfo->compareEnable must be VK_FALSE");
2968 }
2969 if (pCreateInfo->unnormalizedCoordinates) {
2970 skip |= LogError(device, "VUID-VkSamplerCreateInfo-flags-02580",
2971 "vkCreateSampler(): when flags includes VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT, "
2972 "pCreateInfo->unnormalizedCoordinates must be VK_FALSE");
2973 }
2974 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002975 }
2976
Tony-LunarG7337b312020-04-15 16:40:25 -06002977 if (pCreateInfo->borderColor == VK_BORDER_COLOR_INT_CUSTOM_EXT ||
2978 pCreateInfo->borderColor == VK_BORDER_COLOR_FLOAT_CUSTOM_EXT) {
2979 if (!device_extensions.vk_ext_custom_border_color) {
2980 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
2981 "VkSamplerCreateInfo->borderColor is %s but %s is not enabled.\n",
2982 string_VkBorderColor(pCreateInfo->borderColor), VK_EXT_CUSTOM_BORDER_COLOR_EXTENSION_NAME);
2983 }
2984 auto custom_create_info = lvl_find_in_chain<VkSamplerCustomBorderColorCreateInfoEXT>(pCreateInfo->pNext);
2985 if (!custom_create_info) {
2986 skip |=
2987 LogError(device, "VUID-VkSamplerCreateInfo-borderColor-04011",
2988 "VkSamplerCreateInfo->borderColor is set to %s but there is no VkSamplerCustomBorderColorCreateInfoEXT "
2989 "struct in pNext chain.\n",
2990 string_VkBorderColor(pCreateInfo->borderColor));
2991 } else {
2992 if ((custom_create_info->format != VK_FORMAT_UNDEFINED) &&
2993 ((pCreateInfo->borderColor == VK_BORDER_COLOR_INT_CUSTOM_EXT && !FormatIsSampledInt(custom_create_info->format)) ||
2994 (pCreateInfo->borderColor == VK_BORDER_COLOR_FLOAT_CUSTOM_EXT &&
2995 !FormatIsSampledFloat(custom_create_info->format)))) {
2996 skip |= LogError(device, "VUID-VkSamplerCustomBorderColorCreateInfoEXT-format-04013",
2997 "VkSamplerCreateInfo->borderColor is %s but VkSamplerCustomBorderColorCreateInfoEXT.format = %s "
2998 "whose type does not match\n",
2999 string_VkBorderColor(pCreateInfo->borderColor), string_VkFormat(custom_create_info->format));
3000 ;
3001 }
3002 }
3003 }
3004
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003005 return skip;
3006}
3007
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003008bool StatelessValidation::manual_PreCallValidateCreateDescriptorSetLayout(VkDevice device,
3009 const VkDescriptorSetLayoutCreateInfo *pCreateInfo,
3010 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003011 VkDescriptorSetLayout *pSetLayout) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003012 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003013
3014 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
3015 if ((pCreateInfo != nullptr) && (pCreateInfo->pBindings != nullptr)) {
3016 for (uint32_t i = 0; i < pCreateInfo->bindingCount; ++i) {
3017 if (pCreateInfo->pBindings[i].descriptorCount != 0) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003018 if (((pCreateInfo->pBindings[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLER) ||
3019 (pCreateInfo->pBindings[i].descriptorType == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER)) &&
3020 (pCreateInfo->pBindings[i].pImmutableSamplers != nullptr)) {
3021 for (uint32_t descriptor_index = 0; descriptor_index < pCreateInfo->pBindings[i].descriptorCount;
3022 ++descriptor_index) {
3023 if (pCreateInfo->pBindings[i].pImmutableSamplers[descriptor_index] == VK_NULL_HANDLE) {
Spencer Frickeb0e30822020-03-23 10:32:30 -07003024 skip |= LogError(device, "VUID-VkDescriptorSetLayoutBinding-descriptorType-00282",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003025 "vkCreateDescriptorSetLayout: required parameter "
3026 "pCreateInfo->pBindings[%d].pImmutableSamplers[%d] specified as VK_NULL_HANDLE",
3027 i, descriptor_index);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003028 }
3029 }
3030 }
3031
3032 // If descriptorCount is not 0, stageFlags must be a valid combination of VkShaderStageFlagBits values
3033 if ((pCreateInfo->pBindings[i].stageFlags != 0) &&
3034 ((pCreateInfo->pBindings[i].stageFlags & (~AllVkShaderStageFlagBits)) != 0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003035 skip |= LogError(device, "VUID-VkDescriptorSetLayoutBinding-descriptorCount-00283",
3036 "vkCreateDescriptorSetLayout(): if pCreateInfo->pBindings[%d].descriptorCount is not 0, "
3037 "pCreateInfo->pBindings[%d].stageFlags must be a valid combination of VkShaderStageFlagBits "
3038 "values.",
3039 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003040 }
Spencer Fricke84d0cc02020-03-16 17:21:59 -07003041
3042 if ((pCreateInfo->pBindings[i].descriptorType == VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT) &&
3043 (pCreateInfo->pBindings[i].stageFlags != 0) &&
3044 (pCreateInfo->pBindings[i].stageFlags != VK_SHADER_STAGE_FRAGMENT_BIT)) {
3045 skip |=
3046 LogError(device, "VUID-VkDescriptorSetLayoutBinding-descriptorType-01510",
3047 "vkCreateDescriptorSetLayout(): if pCreateInfo->pBindings[%d].descriptorCount is not 0 and "
3048 "descriptorType is VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT then pCreateInfo->pBindings[%d].stageFlags "
3049 "must be 0 or VK_SHADER_STAGE_FRAGMENT_BIT but is currently %s",
3050 i, i, string_VkShaderStageFlags(pCreateInfo->pBindings[i].stageFlags).c_str());
3051 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003052 }
3053 }
3054 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003055 return skip;
3056}
3057
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003058bool StatelessValidation::manual_PreCallValidateFreeDescriptorSets(VkDevice device, VkDescriptorPool descriptorPool,
3059 uint32_t descriptorSetCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003060 const VkDescriptorSet *pDescriptorSets) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003061 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
3062 // This is an array of handles, where the elements are allowed to be VK_NULL_HANDLE, and does not require any validation beyond
3063 // validate_array()
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003064 return validate_array("vkFreeDescriptorSets", "descriptorSetCount", "pDescriptorSets", descriptorSetCount, &pDescriptorSets,
3065 true, true, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003066}
3067
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07003068bool StatelessValidation::validate_WriteDescriptorSet(const char *vkCallingFunction, const uint32_t descriptorWriteCount,
3069 const VkWriteDescriptorSet *pDescriptorWrites,
3070 const bool validateDstSet) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003071 bool skip = false;
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07003072
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003073 if (pDescriptorWrites != NULL) {
3074 for (uint32_t i = 0; i < descriptorWriteCount; ++i) {
3075 // descriptorCount must be greater than 0
3076 if (pDescriptorWrites[i].descriptorCount == 0) {
3077 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003078 LogError(device, "VUID-VkWriteDescriptorSet-descriptorCount-arraylength",
3079 "%s(): parameter pDescriptorWrites[%d].descriptorCount must be greater than 0.", vkCallingFunction, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003080 }
3081
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07003082 // If called from vkCmdPushDescriptorSetKHR, the dstSet member is ignored.
3083 if (validateDstSet) {
3084 // dstSet must be a valid VkDescriptorSet handle
3085 skip |= validate_required_handle(vkCallingFunction,
3086 ParameterName("pDescriptorWrites[%i].dstSet", ParameterName::IndexVector{i}),
3087 pDescriptorWrites[i].dstSet);
3088 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003089
3090 if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLER) ||
3091 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER) ||
3092 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE) ||
3093 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_IMAGE) ||
3094 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT)) {
3095 // If descriptorType is VK_DESCRIPTOR_TYPE_SAMPLER, VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER,
3096 // VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE, VK_DESCRIPTOR_TYPE_STORAGE_IMAGE or VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT,
Jeff Bolz165818a2020-05-08 11:19:03 -05003097 // pImageInfo must be a pointer to an array of descriptorCount valid VkDescriptorImageInfo structures.
3098 // Valid imageView handles are checked in ObjectLifetimes::ValidateDescriptorWrite.
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003099 if (pDescriptorWrites[i].pImageInfo == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003100 skip |= LogError(device, "VUID-VkWriteDescriptorSet-descriptorType-00322",
3101 "%s(): if pDescriptorWrites[%d].descriptorType is "
3102 "VK_DESCRIPTOR_TYPE_SAMPLER, VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER, "
3103 "VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE, VK_DESCRIPTOR_TYPE_STORAGE_IMAGE or "
3104 "VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT, pDescriptorWrites[%d].pImageInfo must not be NULL.",
3105 vkCallingFunction, i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003106 } else if (pDescriptorWrites[i].descriptorType != VK_DESCRIPTOR_TYPE_SAMPLER) {
3107 // If descriptorType is VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER, VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE,
Jeff Bolz165818a2020-05-08 11:19:03 -05003108 // VK_DESCRIPTOR_TYPE_STORAGE_IMAGE or VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT, the imageLayout
3109 // member of any given element of pImageInfo must be a valid VkImageLayout
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003110 for (uint32_t descriptor_index = 0; descriptor_index < pDescriptorWrites[i].descriptorCount;
3111 ++descriptor_index) {
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07003112 skip |= validate_ranged_enum(vkCallingFunction,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003113 ParameterName("pDescriptorWrites[%i].pImageInfo[%i].imageLayout",
3114 ParameterName::IndexVector{i, descriptor_index}),
3115 "VkImageLayout", AllVkImageLayoutEnums,
Dave Houlton413a6782018-05-22 13:01:54 -06003116 pDescriptorWrites[i].pImageInfo[descriptor_index].imageLayout, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003117 }
3118 }
3119 } else if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER) ||
3120 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER) ||
3121 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC) ||
3122 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC)) {
3123 // If descriptorType is VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER, VK_DESCRIPTOR_TYPE_STORAGE_BUFFER,
3124 // VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC or VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC, pBufferInfo must be a
3125 // pointer to an array of descriptorCount valid VkDescriptorBufferInfo structures
Jeff Bolz165818a2020-05-08 11:19:03 -05003126 // Valid buffer handles are checked in ObjectLifetimes::ValidateDescriptorWrite.
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003127 if (pDescriptorWrites[i].pBufferInfo == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003128 skip |= LogError(device, "VUID-VkWriteDescriptorSet-descriptorType-00324",
3129 "%s(): if pDescriptorWrites[%d].descriptorType is "
3130 "VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER, VK_DESCRIPTOR_TYPE_STORAGE_BUFFER, "
3131 "VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC or VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC, "
3132 "pDescriptorWrites[%d].pBufferInfo must not be NULL.",
3133 vkCallingFunction, i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003134 } else {
Jeff Bolz165818a2020-05-08 11:19:03 -05003135 const auto *robustness2_features =
3136 lvl_find_in_chain<VkPhysicalDeviceRobustness2FeaturesEXT>(device_createinfo_pnext);
3137 if (robustness2_features && robustness2_features->nullDescriptor) {
3138 for (uint32_t descriptorIndex = 0; descriptorIndex < pDescriptorWrites[i].descriptorCount;
3139 ++descriptorIndex) {
3140 if (pDescriptorWrites[i].pBufferInfo[descriptorIndex].buffer == VK_NULL_HANDLE &&
3141 (pDescriptorWrites[i].pBufferInfo[descriptorIndex].offset != 0 ||
3142 pDescriptorWrites[i].pBufferInfo[descriptorIndex].range != VK_WHOLE_SIZE)) {
3143 skip |= LogError(device, "VUID-VkDescriptorBufferInfo-buffer-02999",
3144 "%s(): if pDescriptorWrites[%d].buffer is VK_NULL_HANDLE, "
baldurk751594b2020-09-09 09:41:02 +01003145 "offset (%" PRIu64 ") must be zero and range (%" PRIu64 ") must be VK_WHOLE_SIZE.",
Jeff Bolz165818a2020-05-08 11:19:03 -05003146 vkCallingFunction, i, pDescriptorWrites[i].pBufferInfo[descriptorIndex].offset,
3147 pDescriptorWrites[i].pBufferInfo[descriptorIndex].range);
3148 }
3149 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003150 }
3151 }
3152 } else if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER) ||
3153 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER)) {
Jeff Bolz165818a2020-05-08 11:19:03 -05003154 // Valid bufferView handles are checked in ObjectLifetimes::ValidateDescriptorWrite.
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003155 }
3156
3157 if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER) ||
3158 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC)) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003159 VkDeviceSize uniformAlignment = device_limits.minUniformBufferOffsetAlignment;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003160 for (uint32_t j = 0; j < pDescriptorWrites[i].descriptorCount; j++) {
3161 if (pDescriptorWrites[i].pBufferInfo != NULL) {
3162 if (SafeModulo(pDescriptorWrites[i].pBufferInfo[j].offset, uniformAlignment) != 0) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06003163 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003164 LogError(device, "VUID-VkWriteDescriptorSet-descriptorType-00327",
3165 "%s(): pDescriptorWrites[%d].pBufferInfo[%d].offset (0x%" PRIxLEAST64
3166 ") must be a multiple of device limit minUniformBufferOffsetAlignment 0x%" PRIxLEAST64 ".",
3167 vkCallingFunction, i, j, pDescriptorWrites[i].pBufferInfo[j].offset, uniformAlignment);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003168 }
3169 }
3170 }
3171 } else if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER) ||
3172 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC)) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003173 VkDeviceSize storageAlignment = device_limits.minStorageBufferOffsetAlignment;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003174 for (uint32_t j = 0; j < pDescriptorWrites[i].descriptorCount; j++) {
3175 if (pDescriptorWrites[i].pBufferInfo != NULL) {
3176 if (SafeModulo(pDescriptorWrites[i].pBufferInfo[j].offset, storageAlignment) != 0) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06003177 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003178 LogError(device, "VUID-VkWriteDescriptorSet-descriptorType-00328",
3179 "%s(): pDescriptorWrites[%d].pBufferInfo[%d].offset (0x%" PRIxLEAST64
3180 ") must be a multiple of device limit minStorageBufferOffsetAlignment 0x%" PRIxLEAST64 ".",
3181 vkCallingFunction, i, j, pDescriptorWrites[i].pBufferInfo[j].offset, storageAlignment);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003182 }
3183 }
3184 }
3185 }
sourav parmara96ab1a2020-04-25 16:28:23 -07003186 // pNext chain must be either NULL or a pointer to a valid instance of VkWriteDescriptorSetAccelerationStructureKHR
3187 // or VkWriteDescriptorSetInlineUniformBlockEX
3188 if (pDescriptorWrites[i].pNext) {
3189 if (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_ACCELERATION_STRUCTURE_KHR) {
Mark Lobodzinski17dc4602020-05-29 07:48:40 -06003190 const auto *pnext_struct =
sourav parmara96ab1a2020-04-25 16:28:23 -07003191 lvl_find_in_chain<VkWriteDescriptorSetAccelerationStructureKHR>(pDescriptorWrites[i].pNext);
Mark Lobodzinski17dc4602020-05-29 07:48:40 -06003192 if (!pnext_struct || (pnext_struct->accelerationStructureCount != pDescriptorWrites[i].descriptorCount)) {
sourav parmara96ab1a2020-04-25 16:28:23 -07003193 skip |= LogError(device, "VUID-VkWriteDescriptorSet-descriptorType-02382",
3194 "%s(): If descriptorType is VK_DESCRIPTOR_TYPE_ACCELERATION_STRUCTURE_KHR, the pNext"
3195 "chain must include a VkWriteDescriptorSetAccelerationStructureKHR structure whose "
3196 "accelerationStructureCount %d member equals descriptorCount %d.",
Mark Lobodzinski17dc4602020-05-29 07:48:40 -06003197 vkCallingFunction, pnext_struct ? pnext_struct->accelerationStructureCount : -1,
sourav parmara96ab1a2020-04-25 16:28:23 -07003198 pDescriptorWrites[i].descriptorCount);
3199 }
3200 // further checks only if we have right structtype
Mark Lobodzinski17dc4602020-05-29 07:48:40 -06003201 if (pnext_struct) {
3202 if (pnext_struct->accelerationStructureCount != pDescriptorWrites[i].descriptorCount) {
sourav parmara96ab1a2020-04-25 16:28:23 -07003203 skip |= LogError(
3204 device, "VUID-VkWriteDescriptorSetAccelerationStructureKHR-accelerationStructureCount-02236",
3205 "%s(): accelerationStructureCount %d must be equal to descriptorCount %d in the extended structure "
3206 ".",
Mark Lobodzinski17dc4602020-05-29 07:48:40 -06003207 vkCallingFunction, pnext_struct->accelerationStructureCount, pDescriptorWrites[i].descriptorCount);
sourav parmara96ab1a2020-04-25 16:28:23 -07003208 }
Mark Lobodzinski17dc4602020-05-29 07:48:40 -06003209 if (pnext_struct->accelerationStructureCount == 0) {
sourav parmara96ab1a2020-04-25 16:28:23 -07003210 skip |= LogError(
3211 device, "VUID-VkWriteDescriptorSetAccelerationStructureKHR-accelerationStructureCount-arraylength",
3212 "%s(): accelerationStructureCount must be greater than 0 .");
3213 }
3214 }
3215 }
3216 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003217 }
3218 }
3219 return skip;
3220}
3221
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07003222bool StatelessValidation::manual_PreCallValidateUpdateDescriptorSets(VkDevice device, uint32_t descriptorWriteCount,
3223 const VkWriteDescriptorSet *pDescriptorWrites,
3224 uint32_t descriptorCopyCount,
3225 const VkCopyDescriptorSet *pDescriptorCopies) const {
3226 return validate_WriteDescriptorSet("vkUpdateDescriptorSets", descriptorWriteCount, pDescriptorWrites);
3227}
3228
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003229bool StatelessValidation::manual_PreCallValidateCreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo,
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003230 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003231 VkRenderPass *pRenderPass) const {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003232 return CreateRenderPassGeneric(device, pCreateInfo, pAllocator, pRenderPass, RENDER_PASS_VERSION_1);
3233}
3234
3235bool StatelessValidation::manual_PreCallValidateCreateRenderPass2KHR(VkDevice device, const VkRenderPassCreateInfo2KHR *pCreateInfo,
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003236 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003237 VkRenderPass *pRenderPass) const {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003238 return CreateRenderPassGeneric(device, pCreateInfo, pAllocator, pRenderPass, RENDER_PASS_VERSION_2);
3239}
3240
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003241bool StatelessValidation::manual_PreCallValidateFreeCommandBuffers(VkDevice device, VkCommandPool commandPool,
3242 uint32_t commandBufferCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003243 const VkCommandBuffer *pCommandBuffers) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003244 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003245
3246 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
3247 // This is an array of handles, where the elements are allowed to be VK_NULL_HANDLE, and does not require any validation beyond
3248 // validate_array()
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003249 skip |= validate_array("vkFreeCommandBuffers", "commandBufferCount", "pCommandBuffers", commandBufferCount, &pCommandBuffers,
3250 true, true, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003251 return skip;
3252}
3253
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003254bool StatelessValidation::manual_PreCallValidateBeginCommandBuffer(VkCommandBuffer commandBuffer,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003255 const VkCommandBufferBeginInfo *pBeginInfo) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003256 bool skip = false;
Petr Krause7bb9e82019-08-11 21:34:43 +02003257
3258 // VkCommandBufferInheritanceInfo validation, due to a 'noautovalidity' of pBeginInfo->pInheritanceInfo in vkBeginCommandBuffer
3259 const char *cmd_name = "vkBeginCommandBuffer";
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003260 const VkCommandBufferInheritanceInfo *pInfo = pBeginInfo->pInheritanceInfo;
3261
Petr Krause7bb9e82019-08-11 21:34:43 +02003262 // Implicit VUs
3263 // validate only sType here; pointer has to be validated in core_validation
3264 const bool kNotRequired = false;
3265 const char *kNoVUID = nullptr;
3266 skip |= validate_struct_type(cmd_name, "pBeginInfo->pInheritanceInfo", "VK_STRUCTURE_TYPE_COMMAND_BUFFER_INHERITANCE_INFO",
3267 pInfo, VK_STRUCTURE_TYPE_COMMAND_BUFFER_INHERITANCE_INFO, kNotRequired, kNoVUID,
3268 "VUID-VkCommandBufferInheritanceInfo-sType-sType");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003269
Petr Krause7bb9e82019-08-11 21:34:43 +02003270 if (pInfo) {
3271 const VkStructureType allowed_structs_VkCommandBufferInheritanceInfo[] = {
3272 VK_STRUCTURE_TYPE_COMMAND_BUFFER_INHERITANCE_CONDITIONAL_RENDERING_INFO_EXT};
3273 skip |= validate_struct_pnext(
3274 cmd_name, "pBeginInfo->pInheritanceInfo->pNext", "VkCommandBufferInheritanceConditionalRenderingInfoEXT", pInfo->pNext,
3275 ARRAY_SIZE(allowed_structs_VkCommandBufferInheritanceInfo), allowed_structs_VkCommandBufferInheritanceInfo,
sfricke-samsung32a27362020-02-28 09:06:42 -08003276 GeneratedVulkanHeaderVersion, "VUID-VkCommandBufferInheritanceInfo-pNext-pNext",
3277 "VUID-VkCommandBufferInheritanceInfo-sType-unique");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003278
Petr Krause7bb9e82019-08-11 21:34:43 +02003279 skip |= validate_bool32(cmd_name, "pBeginInfo->pInheritanceInfo->occlusionQueryEnable", pInfo->occlusionQueryEnable);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003280
Petr Krause7bb9e82019-08-11 21:34:43 +02003281 // Explicit VUs
3282 if (!physical_device_features.inheritedQueries && pInfo->occlusionQueryEnable == VK_TRUE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003283 skip |= LogError(
3284 commandBuffer, "VUID-VkCommandBufferInheritanceInfo-occlusionQueryEnable-00056",
Petr Krause7bb9e82019-08-11 21:34:43 +02003285 "%s: Inherited queries feature is disabled, but pBeginInfo->pInheritanceInfo->occlusionQueryEnable is VK_TRUE.",
3286 cmd_name);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003287 }
Petr Krause7bb9e82019-08-11 21:34:43 +02003288
3289 if (physical_device_features.inheritedQueries) {
3290 skip |= validate_flags(cmd_name, "pBeginInfo->pInheritanceInfo->queryFlags", "VkQueryControlFlagBits",
Petr Kraus52758be2019-08-12 00:53:58 +02003291 AllVkQueryControlFlagBits, pInfo->queryFlags, kOptionalFlags,
Dave Houlton413a6782018-05-22 13:01:54 -06003292 "VUID-VkCommandBufferInheritanceInfo-queryFlags-00057");
Petr Krause7bb9e82019-08-11 21:34:43 +02003293 } else { // !inheritedQueries
Petr Krause7bb9e82019-08-11 21:34:43 +02003294 skip |= validate_reserved_flags(cmd_name, "pBeginInfo->pInheritanceInfo->queryFlags", pInfo->queryFlags,
Petr Kraus43aed2c2019-08-18 13:59:16 +02003295 "VUID-VkCommandBufferInheritanceInfo-queryFlags-02788");
Petr Krause7bb9e82019-08-11 21:34:43 +02003296 }
3297
3298 if (physical_device_features.pipelineStatisticsQuery) {
Petr Krause7bb9e82019-08-11 21:34:43 +02003299 skip |= validate_flags(cmd_name, "pBeginInfo->pInheritanceInfo->pipelineStatistics", "VkQueryPipelineStatisticFlagBits",
Petr Kraus52758be2019-08-12 00:53:58 +02003300 AllVkQueryPipelineStatisticFlagBits, pInfo->pipelineStatistics, kOptionalFlags,
Petr Kraus43aed2c2019-08-18 13:59:16 +02003301 "VUID-VkCommandBufferInheritanceInfo-pipelineStatistics-02789");
Petr Krause7bb9e82019-08-11 21:34:43 +02003302 } else { // !pipelineStatisticsQuery
3303 skip |= validate_reserved_flags(cmd_name, "pBeginInfo->pInheritanceInfo->pipelineStatistics", pInfo->pipelineStatistics,
3304 "VUID-VkCommandBufferInheritanceInfo-pipelineStatistics-00058");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003305 }
Petr Kraus139757b2019-08-15 17:19:33 +02003306
3307 const auto *conditional_rendering = lvl_find_in_chain<VkCommandBufferInheritanceConditionalRenderingInfoEXT>(pInfo->pNext);
3308 if (conditional_rendering) {
Tony-LunarG6c3c5452019-12-13 10:37:38 -07003309 const auto *cr_features = lvl_find_in_chain<VkPhysicalDeviceConditionalRenderingFeaturesEXT>(device_createinfo_pnext);
Petr Kraus139757b2019-08-15 17:19:33 +02003310 const auto inherited_conditional_rendering = cr_features && cr_features->inheritedConditionalRendering;
3311 if (!inherited_conditional_rendering && conditional_rendering->conditionalRenderingEnable == VK_TRUE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003312 skip |= LogError(
3313 commandBuffer, "VUID-VkCommandBufferInheritanceConditionalRenderingInfoEXT-conditionalRenderingEnable-01977",
Petr Kraus139757b2019-08-15 17:19:33 +02003314 "vkBeginCommandBuffer: Inherited conditional rendering is disabled, but "
3315 "pBeginInfo->pInheritanceInfo->pNext<VkCommandBufferInheritanceConditionalRenderingInfoEXT> is VK_TRUE.");
3316 }
3317 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003318 }
3319
3320 return skip;
3321}
3322
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003323bool StatelessValidation::manual_PreCallValidateCmdSetViewport(VkCommandBuffer commandBuffer, uint32_t firstViewport,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003324 uint32_t viewportCount, const VkViewport *pViewports) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003325 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003326
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003327 if (!physical_device_features.multiViewport) {
Petr Krausd55e77c2018-01-09 22:09:25 +01003328 if (firstViewport != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003329 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewport-firstViewport-01224",
3330 "vkCmdSetViewport: The multiViewport feature is disabled, but firstViewport (=%" PRIu32 ") is not 0.",
3331 firstViewport);
Petr Krausd55e77c2018-01-09 22:09:25 +01003332 }
3333 if (viewportCount > 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003334 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewport-viewportCount-01225",
3335 "vkCmdSetViewport: The multiViewport feature is disabled, but viewportCount (=%" PRIu32 ") is not 1.",
3336 viewportCount);
Petr Krausd55e77c2018-01-09 22:09:25 +01003337 }
3338 } else { // multiViewport enabled
Petr Kraus7dfeed12018-02-27 20:51:20 +01003339 const uint64_t sum = static_cast<uint64_t>(firstViewport) + static_cast<uint64_t>(viewportCount);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003340 if (sum > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003341 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewport-firstViewport-01223",
3342 "vkCmdSetViewport: firstViewport + viewportCount (=%" PRIu32 " + %" PRIu32 " = %" PRIu64
3343 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
3344 firstViewport, viewportCount, sum, device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003345 }
3346 }
Petr Krausb3fcdb42018-01-09 22:09:09 +01003347
3348 if (pViewports) {
3349 for (uint32_t viewport_i = 0; viewport_i < viewportCount; ++viewport_i) {
3350 const auto &viewport = pViewports[viewport_i]; // will crash on invalid ptr
Jeff Bolz6d3beaa2019-02-09 21:00:05 -06003351 const char *fn_name = "vkCmdSetViewport";
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003352 skip |= manual_PreCallValidateViewport(
3353 viewport, fn_name, ParameterName("pViewports[%i]", ParameterName::IndexVector{viewport_i}), commandBuffer);
Petr Krausb3fcdb42018-01-09 22:09:09 +01003354 }
3355 }
3356
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003357 return skip;
3358}
3359
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003360bool StatelessValidation::manual_PreCallValidateCmdSetScissor(VkCommandBuffer commandBuffer, uint32_t firstScissor,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003361 uint32_t scissorCount, const VkRect2D *pScissors) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003362 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003363
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003364 if (!physical_device_features.multiViewport) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003365 if (firstScissor != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003366 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-firstScissor-00593",
3367 "vkCmdSetScissor: The multiViewport feature is disabled, but firstScissor (=%" PRIu32 ") is not 0.",
3368 firstScissor);
Petr Kraus6260f0a2018-02-27 21:15:55 +01003369 }
3370 if (scissorCount > 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003371 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-scissorCount-00594",
3372 "vkCmdSetScissor: The multiViewport feature is disabled, but scissorCount (=%" PRIu32 ") is not 1.",
3373 scissorCount);
Petr Kraus6260f0a2018-02-27 21:15:55 +01003374 }
3375 } else { // multiViewport enabled
3376 const uint64_t sum = static_cast<uint64_t>(firstScissor) + static_cast<uint64_t>(scissorCount);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003377 if (sum > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003378 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-firstScissor-00592",
3379 "vkCmdSetScissor: firstScissor + scissorCount (=%" PRIu32 " + %" PRIu32 " = %" PRIu64
3380 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
3381 firstScissor, scissorCount, sum, device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003382 }
3383 }
3384
Petr Kraus6260f0a2018-02-27 21:15:55 +01003385 if (pScissors) {
3386 for (uint32_t scissor_i = 0; scissor_i < scissorCount; ++scissor_i) {
3387 const auto &scissor = pScissors[scissor_i]; // will crash on invalid ptr
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003388
Petr Kraus6260f0a2018-02-27 21:15:55 +01003389 if (scissor.offset.x < 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003390 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-x-00595",
3391 "vkCmdSetScissor: pScissors[%" PRIu32 "].offset.x (=%" PRIi32 ") is negative.", scissor_i,
3392 scissor.offset.x);
Petr Kraus6260f0a2018-02-27 21:15:55 +01003393 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003394
Petr Kraus6260f0a2018-02-27 21:15:55 +01003395 if (scissor.offset.y < 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003396 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-x-00595",
3397 "vkCmdSetScissor: pScissors[%" PRIu32 "].offset.y (=%" PRIi32 ") is negative.", scissor_i,
3398 scissor.offset.y);
Petr Kraus6260f0a2018-02-27 21:15:55 +01003399 }
3400
3401 const int64_t x_sum = static_cast<int64_t>(scissor.offset.x) + static_cast<int64_t>(scissor.extent.width);
3402 if (x_sum > INT32_MAX) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003403 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-offset-00596",
3404 "vkCmdSetScissor: offset.x + extent.width (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
3405 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
3406 scissor.offset.x, scissor.extent.width, x_sum, scissor_i);
Petr Kraus6260f0a2018-02-27 21:15:55 +01003407 }
3408
3409 const int64_t y_sum = static_cast<int64_t>(scissor.offset.y) + static_cast<int64_t>(scissor.extent.height);
3410 if (y_sum > INT32_MAX) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003411 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-offset-00597",
3412 "vkCmdSetScissor: offset.y + extent.height (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
3413 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
3414 scissor.offset.y, scissor.extent.height, y_sum, scissor_i);
Petr Kraus6260f0a2018-02-27 21:15:55 +01003415 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003416 }
3417 }
Petr Kraus6260f0a2018-02-27 21:15:55 +01003418
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003419 return skip;
3420}
3421
Jeff Bolz5c801d12019-10-09 10:38:45 -05003422bool StatelessValidation::manual_PreCallValidateCmdSetLineWidth(VkCommandBuffer commandBuffer, float lineWidth) const {
Petr Kraus299ba622017-11-24 03:09:03 +01003423 bool skip = false;
Petr Kraus299ba622017-11-24 03:09:03 +01003424
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003425 if (!physical_device_features.wideLines && (lineWidth != 1.0f)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003426 skip |= LogError(commandBuffer, "VUID-vkCmdSetLineWidth-lineWidth-00788",
3427 "VkPhysicalDeviceFeatures::wideLines is disabled, but lineWidth (=%f) is not 1.0.", lineWidth);
Petr Kraus299ba622017-11-24 03:09:03 +01003428 }
3429
3430 return skip;
3431}
3432
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003433bool StatelessValidation::manual_PreCallValidateCmdDraw(VkCommandBuffer commandBuffer, uint32_t vertexCount, uint32_t instanceCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003434 uint32_t firstVertex, uint32_t firstInstance) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003435 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003436 if (vertexCount == 0) {
3437 // TODO: Verify against Valid Usage section. I don't see a non-zero vertexCount listed, may need to add that and make
3438 // this an error or leave as is.
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003439 skip |= LogWarning(device, kVUID_PVError_RequiredParameter, "vkCmdDraw parameter, uint32_t vertexCount, is 0");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003440 }
3441
3442 if (instanceCount == 0) {
3443 // TODO: Verify against Valid Usage section. I don't see a non-zero instanceCount listed, may need to add that and make
3444 // this an error or leave as is.
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003445 skip |= LogWarning(device, kVUID_PVError_RequiredParameter, "vkCmdDraw parameter, uint32_t instanceCount, is 0");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003446 }
3447 return skip;
3448}
3449
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003450bool StatelessValidation::manual_PreCallValidateCmdDrawIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003451 uint32_t count, uint32_t stride) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003452 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003453
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003454 if (!physical_device_features.multiDrawIndirect && ((count > 1))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003455 skip |= LogError(device, kVUID_PVError_DeviceFeature,
3456 "CmdDrawIndirect(): Device feature multiDrawIndirect disabled: count must be 0 or 1 but is %d", count);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003457 }
3458 return skip;
3459}
3460
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003461bool StatelessValidation::manual_PreCallValidateCmdDrawIndexedIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003462 VkDeviceSize offset, uint32_t count, uint32_t stride) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003463 bool skip = false;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003464 if (!physical_device_features.multiDrawIndirect && ((count > 1))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003465 skip |=
3466 LogError(device, kVUID_PVError_DeviceFeature,
3467 "CmdDrawIndexedIndirect(): Device feature multiDrawIndirect disabled: count must be 0 or 1 but is %d", count);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003468 }
3469 return skip;
3470}
3471
sfricke-samsungf692b972020-05-02 08:00:45 -07003472bool StatelessValidation::ValidateCmdDrawIndirectCount(VkCommandBuffer commandBuffer, VkDeviceSize offset,
3473 VkDeviceSize countBufferOffset, bool khr) const {
3474 bool skip = false;
3475 const char *apiName = khr ? "vkCmdDrawIndirectCountKHR()" : "vkCmdDrawIndirectCount()";
3476 if (offset & 3) {
3477 skip |= LogError(commandBuffer, "VUID-vkCmdDrawIndirectCount-offset-02710",
3478 "%s: parameter, VkDeviceSize offset (0x%" PRIxLEAST64 "), is not a multiple of 4.", apiName, offset);
3479 }
3480
3481 if (countBufferOffset & 3) {
3482 skip |= LogError(commandBuffer, "VUID-vkCmdDrawIndirectCount-countBufferOffset-02716",
3483 "%s: parameter, VkDeviceSize countBufferOffset (0x%" PRIxLEAST64 "), is not a multiple of 4.", apiName,
3484 countBufferOffset);
3485 }
3486 return skip;
3487}
3488
3489bool StatelessValidation::manual_PreCallValidateCmdDrawIndirectCount(VkCommandBuffer commandBuffer, VkBuffer buffer,
3490 VkDeviceSize offset, VkBuffer countBuffer,
3491 VkDeviceSize countBufferOffset, uint32_t maxDrawCount,
3492 uint32_t stride) const {
3493 return ValidateCmdDrawIndirectCount(commandBuffer, offset, countBufferOffset, false);
3494}
3495
3496bool StatelessValidation::manual_PreCallValidateCmdDrawIndirectCountKHR(VkCommandBuffer commandBuffer, VkBuffer buffer,
3497 VkDeviceSize offset, VkBuffer countBuffer,
3498 VkDeviceSize countBufferOffset, uint32_t maxDrawCount,
3499 uint32_t stride) const {
3500 return ValidateCmdDrawIndirectCount(commandBuffer, offset, countBufferOffset, true);
3501}
3502
3503bool StatelessValidation::ValidateCmdDrawIndexedIndirectCount(VkCommandBuffer commandBuffer, VkDeviceSize offset,
3504 VkDeviceSize countBufferOffset, bool khr) const {
3505 bool skip = false;
3506 const char *apiName = khr ? "vkCmdDrawIndexedIndirectCountKHR()" : "vkCmdDrawIndexedIndirectCount()";
3507 if (offset & 3) {
3508 skip |= LogError(commandBuffer, "VUID-vkCmdDrawIndexedIndirectCount-offset-02710",
3509 "%s: parameter, VkDeviceSize offset (0x%" PRIxLEAST64 "), is not a multiple of 4.", apiName, offset);
3510 }
3511
3512 if (countBufferOffset & 3) {
3513 skip |= LogError(commandBuffer, "VUID-vkCmdDrawIndexedIndirectCount-countBufferOffset-02716",
3514 "%s: parameter, VkDeviceSize countBufferOffset (0x%" PRIxLEAST64 "), is not a multiple of 4.", apiName,
3515 countBufferOffset);
3516 }
3517 return skip;
3518}
3519
3520bool StatelessValidation::manual_PreCallValidateCmdDrawIndexedIndirectCount(VkCommandBuffer commandBuffer, VkBuffer buffer,
3521 VkDeviceSize offset, VkBuffer countBuffer,
3522 VkDeviceSize countBufferOffset, uint32_t maxDrawCount,
3523 uint32_t stride) const {
3524 return ValidateCmdDrawIndexedIndirectCount(commandBuffer, offset, countBufferOffset, false);
3525}
3526
3527bool StatelessValidation::manual_PreCallValidateCmdDrawIndexedIndirectCountKHR(VkCommandBuffer commandBuffer, VkBuffer buffer,
3528 VkDeviceSize offset, VkBuffer countBuffer,
3529 VkDeviceSize countBufferOffset,
3530 uint32_t maxDrawCount, uint32_t stride) const {
3531 return ValidateCmdDrawIndexedIndirectCount(commandBuffer, offset, countBufferOffset, true);
3532}
3533
Mark Lobodzinskif77a4ac2019-06-27 15:30:51 -06003534bool StatelessValidation::manual_PreCallValidateCmdClearAttachments(VkCommandBuffer commandBuffer, uint32_t attachmentCount,
3535 const VkClearAttachment *pAttachments, uint32_t rectCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003536 const VkClearRect *pRects) const {
Mark Lobodzinskif77a4ac2019-06-27 15:30:51 -06003537 bool skip = false;
3538 for (uint32_t rect = 0; rect < rectCount; rect++) {
3539 if (pRects[rect].layerCount == 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003540 skip |= LogError(commandBuffer, "VUID-vkCmdClearAttachments-layerCount-01934",
3541 "CmdClearAttachments(): pRects[%d].layerCount is zero.", rect);
Mark Lobodzinskif77a4ac2019-06-27 15:30:51 -06003542 }
sfricke-samsung10867682020-04-25 02:20:39 -07003543 if (pRects[rect].rect.extent.width == 0) {
3544 skip |= LogError(commandBuffer, "VUID-vkCmdClearAttachments-rect-02682",
3545 "CmdClearAttachments(): pRects[%d].rect.extent.width is zero.", rect);
3546 }
3547 if (pRects[rect].rect.extent.height == 0) {
3548 skip |= LogError(commandBuffer, "VUID-vkCmdClearAttachments-rect-02683",
3549 "CmdClearAttachments(): pRects[%d].rect.extent.height is zero.", rect);
3550 }
Mark Lobodzinskif77a4ac2019-06-27 15:30:51 -06003551 }
3552 return skip;
3553}
3554
Andrew Fobel3abeb992020-01-20 16:33:22 -05003555bool StatelessValidation::ValidateGetPhysicalDeviceImageFormatProperties2(VkPhysicalDevice physicalDevice,
3556 const VkPhysicalDeviceImageFormatInfo2 *pImageFormatInfo,
3557 VkImageFormatProperties2 *pImageFormatProperties,
3558 const char *apiName) const {
3559 bool skip = false;
3560
3561 if (pImageFormatInfo != nullptr) {
3562 const auto image_stencil_struct = lvl_find_in_chain<VkImageStencilUsageCreateInfoEXT>(pImageFormatInfo->pNext);
3563 if (image_stencil_struct != nullptr) {
3564 if ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT) != 0) {
3565 VkImageUsageFlags legal_flags = (VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT | VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT);
3566 // No flags other than the legal attachment bits may be set
3567 legal_flags |= VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT;
3568 if ((image_stencil_struct->stencilUsage & ~legal_flags) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003569 skip |= LogError(physicalDevice, "VUID-VkImageStencilUsageCreateInfo-stencilUsage-02539",
3570 "%s(): in pNext chain, VkImageStencilUsageCreateInfo::stencilUsage "
3571 "includes VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT, it must not include bits other than "
3572 "VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT or VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT",
3573 apiName);
Andrew Fobel3abeb992020-01-20 16:33:22 -05003574 }
3575 }
3576 }
3577 }
3578
3579 return skip;
3580}
3581
3582bool StatelessValidation::manual_PreCallValidateGetPhysicalDeviceImageFormatProperties2(
3583 VkPhysicalDevice physicalDevice, const VkPhysicalDeviceImageFormatInfo2 *pImageFormatInfo,
3584 VkImageFormatProperties2 *pImageFormatProperties) const {
3585 return ValidateGetPhysicalDeviceImageFormatProperties2(physicalDevice, pImageFormatInfo, pImageFormatProperties,
3586 "vkGetPhysicalDeviceImageFormatProperties2");
3587}
3588
3589bool StatelessValidation::manual_PreCallValidateGetPhysicalDeviceImageFormatProperties2KHR(
3590 VkPhysicalDevice physicalDevice, const VkPhysicalDeviceImageFormatInfo2 *pImageFormatInfo,
3591 VkImageFormatProperties2 *pImageFormatProperties) const {
3592 return ValidateGetPhysicalDeviceImageFormatProperties2(physicalDevice, pImageFormatInfo, pImageFormatProperties,
3593 "vkGetPhysicalDeviceImageFormatProperties2KHR");
3594}
3595
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003596bool StatelessValidation::manual_PreCallValidateCmdCopyImage(VkCommandBuffer commandBuffer, VkImage srcImage,
3597 VkImageLayout srcImageLayout, VkImage dstImage,
3598 VkImageLayout dstImageLayout, uint32_t regionCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003599 const VkImageCopy *pRegions) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003600 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003601
Dave Houltonf5217612018-02-02 16:18:52 -07003602 VkImageAspectFlags legal_aspect_flags =
3603 VK_IMAGE_ASPECT_COLOR_BIT | VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT | VK_IMAGE_ASPECT_METADATA_BIT;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003604 if (device_extensions.vk_khr_sampler_ycbcr_conversion) {
Dave Houltonf5217612018-02-02 16:18:52 -07003605 legal_aspect_flags |= (VK_IMAGE_ASPECT_PLANE_0_BIT_KHR | VK_IMAGE_ASPECT_PLANE_1_BIT_KHR | VK_IMAGE_ASPECT_PLANE_2_BIT_KHR);
3606 }
3607
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003608 if (pRegions != nullptr) {
Dave Houltonf5217612018-02-02 16:18:52 -07003609 if ((pRegions->srcSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003610 skip |= LogError(
3611 device, "VUID-VkImageSubresourceLayers-aspectMask-parameter",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003612 "vkCmdCopyImage() parameter, VkImageAspect pRegions->srcSubresource.aspectMask, is an unrecognized enumerator.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003613 }
Dave Houltonf5217612018-02-02 16:18:52 -07003614 if ((pRegions->dstSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003615 skip |= LogError(
3616 device, "VUID-VkImageSubresourceLayers-aspectMask-parameter",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003617 "vkCmdCopyImage() parameter, VkImageAspect pRegions->dstSubresource.aspectMask, is an unrecognized enumerator.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003618 }
3619 }
3620 return skip;
3621}
3622
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003623bool StatelessValidation::manual_PreCallValidateCmdBlitImage(VkCommandBuffer commandBuffer, VkImage srcImage,
3624 VkImageLayout srcImageLayout, VkImage dstImage,
3625 VkImageLayout dstImageLayout, uint32_t regionCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003626 const VkImageBlit *pRegions, VkFilter filter) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003627 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003628
Dave Houltonf5217612018-02-02 16:18:52 -07003629 VkImageAspectFlags legal_aspect_flags =
3630 VK_IMAGE_ASPECT_COLOR_BIT | VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT | VK_IMAGE_ASPECT_METADATA_BIT;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003631 if (device_extensions.vk_khr_sampler_ycbcr_conversion) {
Dave Houltonf5217612018-02-02 16:18:52 -07003632 legal_aspect_flags |= (VK_IMAGE_ASPECT_PLANE_0_BIT_KHR | VK_IMAGE_ASPECT_PLANE_1_BIT_KHR | VK_IMAGE_ASPECT_PLANE_2_BIT_KHR);
3633 }
3634
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003635 if (pRegions != nullptr) {
Dave Houltonf5217612018-02-02 16:18:52 -07003636 if ((pRegions->srcSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003637 skip |= LogError(
3638 device, kVUID_PVError_UnrecognizedValue,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003639 "vkCmdBlitImage() parameter, VkImageAspect pRegions->srcSubresource.aspectMask, is an unrecognized enumerator");
3640 }
Dave Houltonf5217612018-02-02 16:18:52 -07003641 if ((pRegions->dstSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003642 skip |= LogError(
3643 device, kVUID_PVError_UnrecognizedValue,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003644 "vkCmdBlitImage() parameter, VkImageAspect pRegions->dstSubresource.aspectMask, is an unrecognized enumerator");
3645 }
3646 }
3647 return skip;
3648}
3649
sfricke-samsung3999ef62020-02-09 17:05:59 -08003650bool StatelessValidation::manual_PreCallValidateCmdCopyBuffer(VkCommandBuffer commandBuffer, VkBuffer srcBuffer, VkBuffer dstBuffer,
3651 uint32_t regionCount, const VkBufferCopy *pRegions) const {
3652 bool skip = false;
3653
3654 if (pRegions != nullptr) {
3655 for (uint32_t i = 0; i < regionCount; i++) {
3656 if (pRegions[i].size == 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003657 skip |= LogError(device, "VUID-VkBufferCopy-size-01988",
3658 "vkCmdCopyBuffer() pRegions[%u].size must be greater than zero", i);
sfricke-samsung3999ef62020-02-09 17:05:59 -08003659 }
3660 }
3661 }
3662 return skip;
3663}
3664
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003665bool StatelessValidation::manual_PreCallValidateCmdCopyBufferToImage(VkCommandBuffer commandBuffer, VkBuffer srcBuffer,
3666 VkImage dstImage, VkImageLayout dstImageLayout,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003667 uint32_t regionCount,
3668 const VkBufferImageCopy *pRegions) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003669 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003670
Dave Houltonf5217612018-02-02 16:18:52 -07003671 VkImageAspectFlags legal_aspect_flags =
3672 VK_IMAGE_ASPECT_COLOR_BIT | VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT | VK_IMAGE_ASPECT_METADATA_BIT;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003673 if (device_extensions.vk_khr_sampler_ycbcr_conversion) {
Dave Houltonf5217612018-02-02 16:18:52 -07003674 legal_aspect_flags |= (VK_IMAGE_ASPECT_PLANE_0_BIT_KHR | VK_IMAGE_ASPECT_PLANE_1_BIT_KHR | VK_IMAGE_ASPECT_PLANE_2_BIT_KHR);
3675 }
3676
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003677 if (pRegions != nullptr) {
Dave Houltonf5217612018-02-02 16:18:52 -07003678 if ((pRegions->imageSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003679 skip |= LogError(device, kVUID_PVError_UnrecognizedValue,
3680 "vkCmdCopyBufferToImage() parameter, VkImageAspect pRegions->imageSubresource.aspectMask, is an "
3681 "unrecognized enumerator");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003682 }
3683 }
3684 return skip;
3685}
3686
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003687bool StatelessValidation::manual_PreCallValidateCmdCopyImageToBuffer(VkCommandBuffer commandBuffer, VkImage srcImage,
3688 VkImageLayout srcImageLayout, VkBuffer dstBuffer,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003689 uint32_t regionCount,
3690 const VkBufferImageCopy *pRegions) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003691 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003692
Dave Houltonf5217612018-02-02 16:18:52 -07003693 VkImageAspectFlags legal_aspect_flags =
3694 VK_IMAGE_ASPECT_COLOR_BIT | VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT | VK_IMAGE_ASPECT_METADATA_BIT;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003695 if (device_extensions.vk_khr_sampler_ycbcr_conversion) {
Dave Houltonf5217612018-02-02 16:18:52 -07003696 legal_aspect_flags |= (VK_IMAGE_ASPECT_PLANE_0_BIT_KHR | VK_IMAGE_ASPECT_PLANE_1_BIT_KHR | VK_IMAGE_ASPECT_PLANE_2_BIT_KHR);
3697 }
3698
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003699 if (pRegions != nullptr) {
Dave Houltonf5217612018-02-02 16:18:52 -07003700 if ((pRegions->imageSubresource.aspectMask & legal_aspect_flags) == 0) {
Petr Kraus3e6cd032020-04-14 20:41:16 +02003701 skip |= LogError(
3702 device, kVUID_PVError_UnrecognizedValue,
3703 "vkCmdCopyImageToBuffer parameter, VkImageAspect pRegions->imageSubresource.aspectMask, is an unrecognized "
3704 "enumerator");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003705 }
3706 }
3707 return skip;
3708}
3709
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003710bool StatelessValidation::manual_PreCallValidateCmdUpdateBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003711 VkDeviceSize dstOffset, VkDeviceSize dataSize,
3712 const void *pData) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003713 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003714
3715 if (dstOffset & 3) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003716 skip |= LogError(device, "VUID-vkCmdUpdateBuffer-dstOffset-00036",
3717 "vkCmdUpdateBuffer() parameter, VkDeviceSize dstOffset (0x%" PRIxLEAST64 "), is not a multiple of 4.",
3718 dstOffset);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003719 }
3720
3721 if ((dataSize <= 0) || (dataSize > 65536)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003722 skip |= LogError(device, "VUID-vkCmdUpdateBuffer-dataSize-00037",
3723 "vkCmdUpdateBuffer() parameter, VkDeviceSize dataSize (0x%" PRIxLEAST64
3724 "), must be greater than zero and less than or equal to 65536.",
3725 dataSize);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003726 } else if (dataSize & 3) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003727 skip |= LogError(device, "VUID-vkCmdUpdateBuffer-dataSize-00038",
3728 "vkCmdUpdateBuffer() parameter, VkDeviceSize dataSize (0x%" PRIxLEAST64 "), is not a multiple of 4.",
3729 dataSize);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003730 }
3731 return skip;
3732}
3733
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003734bool StatelessValidation::manual_PreCallValidateCmdFillBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003735 VkDeviceSize dstOffset, VkDeviceSize size, uint32_t data) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003736 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003737
3738 if (dstOffset & 3) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003739 skip |= LogError(device, "VUID-vkCmdFillBuffer-dstOffset-00025",
3740 "vkCmdFillBuffer() parameter, VkDeviceSize dstOffset (0x%" PRIxLEAST64 "), is not a multiple of 4.",
3741 dstOffset);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003742 }
3743
3744 if (size != VK_WHOLE_SIZE) {
3745 if (size <= 0) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003746 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003747 LogError(device, "VUID-vkCmdFillBuffer-size-00026",
3748 "vkCmdFillBuffer() parameter, VkDeviceSize size (0x%" PRIxLEAST64 "), must be greater than zero.", size);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003749 } else if (size & 3) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003750 skip |= LogError(device, "VUID-vkCmdFillBuffer-size-00028",
3751 "vkCmdFillBuffer() parameter, VkDeviceSize size (0x%" PRIxLEAST64 "), is not a multiple of 4.", size);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003752 }
3753 }
3754 return skip;
3755}
3756
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003757bool StatelessValidation::manual_PreCallValidateCreateSwapchainKHR(VkDevice device, const VkSwapchainCreateInfoKHR *pCreateInfo,
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003758 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003759 VkSwapchainKHR *pSwapchain) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003760 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003761
3762 if (pCreateInfo != nullptr) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003763 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
3764 if (pCreateInfo->imageSharingMode == VK_SHARING_MODE_CONCURRENT) {
3765 // If imageSharingMode is VK_SHARING_MODE_CONCURRENT, queueFamilyIndexCount must be greater than 1
3766 if (pCreateInfo->queueFamilyIndexCount <= 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003767 skip |= LogError(device, "VUID-VkSwapchainCreateInfoKHR-imageSharingMode-01278",
3768 "vkCreateSwapchainKHR(): if pCreateInfo->imageSharingMode is VK_SHARING_MODE_CONCURRENT, "
3769 "pCreateInfo->queueFamilyIndexCount must be greater than 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003770 }
3771
3772 // If imageSharingMode is VK_SHARING_MODE_CONCURRENT, pQueueFamilyIndices must be a pointer to an array of
3773 // queueFamilyIndexCount uint32_t values
3774 if (pCreateInfo->pQueueFamilyIndices == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003775 skip |= LogError(device, "VUID-VkSwapchainCreateInfoKHR-imageSharingMode-01277",
3776 "vkCreateSwapchainKHR(): if pCreateInfo->imageSharingMode is VK_SHARING_MODE_CONCURRENT, "
3777 "pCreateInfo->pQueueFamilyIndices must be a pointer to an array of "
3778 "pCreateInfo->queueFamilyIndexCount uint32_t values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003779 }
3780 }
3781
Dave Houlton413a6782018-05-22 13:01:54 -06003782 skip |= ValidateGreaterThanZero(pCreateInfo->imageArrayLayers, "pCreateInfo->imageArrayLayers",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003783 "VUID-VkSwapchainCreateInfoKHR-imageArrayLayers-01275", "vkCreateSwapchainKHR");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003784 }
3785
3786 return skip;
3787}
3788
Jeff Bolz5c801d12019-10-09 10:38:45 -05003789bool StatelessValidation::manual_PreCallValidateQueuePresentKHR(VkQueue queue, const VkPresentInfoKHR *pPresentInfo) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003790 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003791
3792 if (pPresentInfo && pPresentInfo->pNext) {
John Zulaufde972ac2017-10-26 12:07:05 -06003793 const auto *present_regions = lvl_find_in_chain<VkPresentRegionsKHR>(pPresentInfo->pNext);
3794 if (present_regions) {
3795 // TODO: This and all other pNext extension dependencies should be added to code-generation
Tony-LunarG2ec96bb2019-11-26 13:43:02 -07003796 skip |= require_device_extension(IsExtEnabled(device_extensions.vk_khr_incremental_present), "vkQueuePresentKHR",
John Zulaufde972ac2017-10-26 12:07:05 -06003797 VK_KHR_INCREMENTAL_PRESENT_EXTENSION_NAME);
3798 if (present_regions->swapchainCount != pPresentInfo->swapchainCount) {
sfricke-samsunga4cc4ff2020-08-23 22:05:49 -07003799 skip |= LogError(device, "VUID-VkPresentRegionsKHR-swapchainCount-01260",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003800 "QueuePresentKHR(): pPresentInfo->swapchainCount has a value of %i but VkPresentRegionsKHR "
3801 "extension swapchainCount is %i. These values must be equal.",
3802 pPresentInfo->swapchainCount, present_regions->swapchainCount);
John Zulaufde972ac2017-10-26 12:07:05 -06003803 }
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003804 skip |= validate_struct_pnext("QueuePresentKHR", "pCreateInfo->pNext->pNext", NULL, present_regions->pNext, 0, NULL,
sfricke-samsung32a27362020-02-28 09:06:42 -08003805 GeneratedVulkanHeaderVersion, "VUID-VkPresentInfoKHR-pNext-pNext",
3806 "VUID-VkPresentInfoKHR-sType-unique");
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003807 skip |= validate_array("QueuePresentKHR", "pCreateInfo->pNext->swapchainCount", "pCreateInfo->pNext->pRegions",
3808 present_regions->swapchainCount, &present_regions->pRegions, true, false, kVUIDUndefined,
3809 kVUIDUndefined);
John Zulaufde972ac2017-10-26 12:07:05 -06003810 for (uint32_t i = 0; i < present_regions->swapchainCount; ++i) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003811 skip |= validate_array("QueuePresentKHR", "pCreateInfo->pNext->pRegions[].rectangleCount",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003812 "pCreateInfo->pNext->pRegions[].pRectangles", present_regions->pRegions[i].rectangleCount,
Dave Houlton413a6782018-05-22 13:01:54 -06003813 &present_regions->pRegions[i].pRectangles, true, false, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003814 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003815 }
3816 }
3817
3818 return skip;
3819}
3820
3821#ifdef VK_USE_PLATFORM_WIN32_KHR
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003822bool StatelessValidation::manual_PreCallValidateCreateWin32SurfaceKHR(VkInstance instance,
3823 const VkWin32SurfaceCreateInfoKHR *pCreateInfo,
3824 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003825 VkSurfaceKHR *pSurface) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003826 bool skip = false;
3827
3828 if (pCreateInfo->hwnd == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003829 skip |= LogError(device, "VUID-VkWin32SurfaceCreateInfoKHR-hwnd-01308",
3830 "vkCreateWin32SurfaceKHR(): hwnd must be a valid Win32 HWND but hwnd is NULL.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003831 }
3832
3833 return skip;
3834}
3835#endif // VK_USE_PLATFORM_WIN32_KHR
3836
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003837bool StatelessValidation::manual_PreCallValidateCreateDescriptorPool(VkDevice device, const VkDescriptorPoolCreateInfo *pCreateInfo,
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003838 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003839 VkDescriptorPool *pDescriptorPool) const {
Petr Krausc8655be2017-09-27 18:56:51 +02003840 bool skip = false;
3841
3842 if (pCreateInfo) {
3843 if (pCreateInfo->maxSets <= 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003844 skip |= LogError(device, "VUID-VkDescriptorPoolCreateInfo-maxSets-00301",
3845 "vkCreateDescriptorPool(): pCreateInfo->maxSets is not greater than 0.");
Petr Krausc8655be2017-09-27 18:56:51 +02003846 }
3847
3848 if (pCreateInfo->pPoolSizes) {
3849 for (uint32_t i = 0; i < pCreateInfo->poolSizeCount; ++i) {
3850 if (pCreateInfo->pPoolSizes[i].descriptorCount <= 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003851 skip |= LogError(
3852 device, "VUID-VkDescriptorPoolSize-descriptorCount-00302",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003853 "vkCreateDescriptorPool(): pCreateInfo->pPoolSizes[%" PRIu32 "].descriptorCount is not greater than 0.", i);
Petr Krausc8655be2017-09-27 18:56:51 +02003854 }
Jeff Bolze54ae892018-09-08 12:16:29 -05003855 if (pCreateInfo->pPoolSizes[i].type == VK_DESCRIPTOR_TYPE_INLINE_UNIFORM_BLOCK_EXT &&
3856 (pCreateInfo->pPoolSizes[i].descriptorCount % 4) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003857 skip |= LogError(device, "VUID-VkDescriptorPoolSize-type-02218",
3858 "vkCreateDescriptorPool(): pCreateInfo->pPoolSizes[%" PRIu32
3859 "].type is VK_DESCRIPTOR_TYPE_INLINE_UNIFORM_BLOCK_EXT "
3860 " and pCreateInfo->pPoolSizes[%" PRIu32 "].descriptorCount is not a multiple of 4.",
3861 i, i);
Jeff Bolze54ae892018-09-08 12:16:29 -05003862 }
Petr Krausc8655be2017-09-27 18:56:51 +02003863 }
3864 }
3865 }
3866
3867 return skip;
3868}
3869
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003870bool StatelessValidation::manual_PreCallValidateCmdDispatch(VkCommandBuffer commandBuffer, uint32_t groupCountX,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003871 uint32_t groupCountY, uint32_t groupCountZ) const {
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003872 bool skip = false;
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003873
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003874 if (groupCountX > device_limits.maxComputeWorkGroupCount[0]) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003875 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003876 LogError(commandBuffer, "VUID-vkCmdDispatch-groupCountX-00386",
3877 "vkCmdDispatch(): groupCountX (%" PRIu32 ") exceeds device limit maxComputeWorkGroupCount[0] (%" PRIu32 ").",
3878 groupCountX, device_limits.maxComputeWorkGroupCount[0]);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003879 }
3880
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003881 if (groupCountY > device_limits.maxComputeWorkGroupCount[1]) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003882 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003883 LogError(commandBuffer, "VUID-vkCmdDispatch-groupCountY-00387",
3884 "vkCmdDispatch(): groupCountY (%" PRIu32 ") exceeds device limit maxComputeWorkGroupCount[1] (%" PRIu32 ").",
3885 groupCountY, device_limits.maxComputeWorkGroupCount[1]);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003886 }
3887
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003888 if (groupCountZ > device_limits.maxComputeWorkGroupCount[2]) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003889 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003890 LogError(commandBuffer, "VUID-vkCmdDispatch-groupCountZ-00388",
3891 "vkCmdDispatch(): groupCountZ (%" PRIu32 ") exceeds device limit maxComputeWorkGroupCount[2] (%" PRIu32 ").",
3892 groupCountZ, device_limits.maxComputeWorkGroupCount[2]);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003893 }
3894
3895 return skip;
3896}
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003897
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003898bool StatelessValidation::manual_PreCallValidateCmdDispatchIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003899 VkDeviceSize offset) const {
John Zulaufa999d1b2018-11-29 13:38:40 -07003900 bool skip = false;
John Zulaufa999d1b2018-11-29 13:38:40 -07003901
3902 if ((offset % 4) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003903 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchIndirect-offset-02710",
3904 "vkCmdDispatchIndirect(): offset (%" PRIu64 ") must be a multiple of 4.", offset);
John Zulaufa999d1b2018-11-29 13:38:40 -07003905 }
3906 return skip;
3907}
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003908
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003909bool StatelessValidation::manual_PreCallValidateCmdDispatchBaseKHR(VkCommandBuffer commandBuffer, uint32_t baseGroupX,
3910 uint32_t baseGroupY, uint32_t baseGroupZ, uint32_t groupCountX,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003911 uint32_t groupCountY, uint32_t groupCountZ) const {
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003912 bool skip = false;
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003913
3914 // Paired if {} else if {} tests used to avoid any possible uint underflow
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003915 uint32_t limit = device_limits.maxComputeWorkGroupCount[0];
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003916 if (baseGroupX >= limit) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003917 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchBase-baseGroupX-00421",
3918 "vkCmdDispatch(): baseGroupX (%" PRIu32
3919 ") equals or exceeds device limit maxComputeWorkGroupCount[0] (%" PRIu32 ").",
3920 baseGroupX, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003921 } else if (groupCountX > (limit - baseGroupX)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003922 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchBase-groupCountX-00424",
3923 "vkCmdDispatchBaseKHR(): baseGroupX (%" PRIu32 ") + groupCountX (%" PRIu32
3924 ") exceeds device limit maxComputeWorkGroupCount[0] (%" PRIu32 ").",
3925 baseGroupX, groupCountX, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003926 }
3927
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003928 limit = device_limits.maxComputeWorkGroupCount[1];
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003929 if (baseGroupY >= limit) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003930 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchBase-baseGroupX-00422",
3931 "vkCmdDispatch(): baseGroupY (%" PRIu32
3932 ") equals or exceeds device limit maxComputeWorkGroupCount[1] (%" PRIu32 ").",
3933 baseGroupY, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003934 } else if (groupCountY > (limit - baseGroupY)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003935 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchBase-groupCountY-00425",
3936 "vkCmdDispatchBaseKHR(): baseGroupY (%" PRIu32 ") + groupCountY (%" PRIu32
3937 ") exceeds device limit maxComputeWorkGroupCount[1] (%" PRIu32 ").",
3938 baseGroupY, groupCountY, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003939 }
3940
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003941 limit = device_limits.maxComputeWorkGroupCount[2];
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003942 if (baseGroupZ >= limit) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003943 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchBase-baseGroupZ-00423",
3944 "vkCmdDispatch(): baseGroupZ (%" PRIu32
3945 ") equals or exceeds device limit maxComputeWorkGroupCount[2] (%" PRIu32 ").",
3946 baseGroupZ, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003947 } else if (groupCountZ > (limit - baseGroupZ)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003948 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchBase-groupCountZ-00426",
3949 "vkCmdDispatchBaseKHR(): baseGroupZ (%" PRIu32 ") + groupCountZ (%" PRIu32
3950 ") exceeds device limit maxComputeWorkGroupCount[2] (%" PRIu32 ").",
3951 baseGroupZ, groupCountZ, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003952 }
3953
3954 return skip;
3955}
3956
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07003957bool StatelessValidation::manual_PreCallValidateCmdPushDescriptorSetKHR(VkCommandBuffer commandBuffer,
3958 VkPipelineBindPoint pipelineBindPoint,
3959 VkPipelineLayout layout, uint32_t set,
3960 uint32_t descriptorWriteCount,
3961 const VkWriteDescriptorSet *pDescriptorWrites) const {
3962 return validate_WriteDescriptorSet("vkCmdPushDescriptorSetKHR", descriptorWriteCount, pDescriptorWrites, false);
3963}
3964
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003965bool StatelessValidation::manual_PreCallValidateCmdSetExclusiveScissorNV(VkCommandBuffer commandBuffer,
3966 uint32_t firstExclusiveScissor,
3967 uint32_t exclusiveScissorCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003968 const VkRect2D *pExclusiveScissors) const {
Jeff Bolz3e71f782018-08-29 23:15:45 -05003969 bool skip = false;
3970
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003971 if (!physical_device_features.multiViewport) {
Jeff Bolz3e71f782018-08-29 23:15:45 -05003972 if (firstExclusiveScissor != 0) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06003973 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003974 LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-firstExclusiveScissor-02035",
3975 "vkCmdSetExclusiveScissorNV: The multiViewport feature is disabled, but firstExclusiveScissor (=%" PRIu32
3976 ") is not 0.",
3977 firstExclusiveScissor);
Jeff Bolz3e71f782018-08-29 23:15:45 -05003978 }
3979 if (exclusiveScissorCount > 1) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06003980 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003981 LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-exclusiveScissorCount-02036",
3982 "vkCmdSetExclusiveScissorNV: The multiViewport feature is disabled, but exclusiveScissorCount (=%" PRIu32
3983 ") is not 1.",
3984 exclusiveScissorCount);
Jeff Bolz3e71f782018-08-29 23:15:45 -05003985 }
3986 } else { // multiViewport enabled
3987 const uint64_t sum = static_cast<uint64_t>(firstExclusiveScissor) + static_cast<uint64_t>(exclusiveScissorCount);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003988 if (sum > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003989 skip |= LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-firstExclusiveScissor-02034",
3990 "vkCmdSetExclusiveScissorNV: firstExclusiveScissor + exclusiveScissorCount (=%" PRIu32 " + %" PRIu32
3991 " = %" PRIu64 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
3992 firstExclusiveScissor, exclusiveScissorCount, sum, device_limits.maxViewports);
Jeff Bolz3e71f782018-08-29 23:15:45 -05003993 }
3994 }
3995
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003996 if (firstExclusiveScissor >= device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003997 skip |= LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-firstExclusiveScissor-02033",
3998 "vkCmdSetExclusiveScissorNV: firstExclusiveScissor (=%" PRIu32
3999 ") must be less than maxViewports (=%" PRIu32 ").",
4000 firstExclusiveScissor, device_limits.maxViewports);
Jeff Bolz3e71f782018-08-29 23:15:45 -05004001 }
4002
4003 if (pExclusiveScissors) {
4004 for (uint32_t scissor_i = 0; scissor_i < exclusiveScissorCount; ++scissor_i) {
4005 const auto &scissor = pExclusiveScissors[scissor_i]; // will crash on invalid ptr
4006
4007 if (scissor.offset.x < 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004008 skip |= LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-x-02037",
4009 "vkCmdSetExclusiveScissorNV: pScissors[%" PRIu32 "].offset.x (=%" PRIi32 ") is negative.",
4010 scissor_i, scissor.offset.x);
Jeff Bolz3e71f782018-08-29 23:15:45 -05004011 }
4012
4013 if (scissor.offset.y < 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004014 skip |= LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-x-02037",
4015 "vkCmdSetExclusiveScissorNV: pScissors[%" PRIu32 "].offset.y (=%" PRIi32 ") is negative.",
4016 scissor_i, scissor.offset.y);
Jeff Bolz3e71f782018-08-29 23:15:45 -05004017 }
4018
4019 const int64_t x_sum = static_cast<int64_t>(scissor.offset.x) + static_cast<int64_t>(scissor.extent.width);
4020 if (x_sum > INT32_MAX) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004021 skip |= LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-offset-02038",
4022 "vkCmdSetExclusiveScissorNV: offset.x + extent.width (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
4023 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
4024 scissor.offset.x, scissor.extent.width, x_sum, scissor_i);
Jeff Bolz3e71f782018-08-29 23:15:45 -05004025 }
4026
4027 const int64_t y_sum = static_cast<int64_t>(scissor.offset.y) + static_cast<int64_t>(scissor.extent.height);
4028 if (y_sum > INT32_MAX) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004029 skip |= LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-offset-02039",
4030 "vkCmdSetExclusiveScissorNV: offset.y + extent.height (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
4031 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
4032 scissor.offset.y, scissor.extent.height, y_sum, scissor_i);
Jeff Bolz3e71f782018-08-29 23:15:45 -05004033 }
4034 }
4035 }
4036
4037 return skip;
4038}
4039
Chris Mayer9ded5eb2019-09-19 16:33:26 +02004040bool StatelessValidation::manual_PreCallValidateCmdSetViewportWScalingNV(VkCommandBuffer commandBuffer, uint32_t firstViewport,
4041 uint32_t viewportCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004042 const VkViewportWScalingNV *pViewportWScalings) const {
Chris Mayer9ded5eb2019-09-19 16:33:26 +02004043 bool skip = false;
4044 if (firstViewport >= device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004045 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewportWScalingNV-firstViewport-01323",
4046 "vkCmdSetViewportWScalingNV: firstViewport (=%" PRIu32 ") must be less than maxViewports (=%" PRIu32 ").",
4047 firstViewport, device_limits.maxViewports);
Chris Mayer9ded5eb2019-09-19 16:33:26 +02004048 } else {
4049 const uint64_t sum = static_cast<uint64_t>(firstViewport) + static_cast<uint64_t>(viewportCount);
4050 if ((sum < 1) || (sum > device_limits.maxViewports)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004051 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewportWScalingNV-firstViewport-01324",
4052 "vkCmdSetViewportWScalingNV: firstViewport + viewportCount (=%" PRIu32 " + %" PRIu32 " = %" PRIu64
4053 ") must be between 1 and VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 "), inculsive.",
4054 firstViewport, viewportCount, sum, device_limits.maxViewports);
Chris Mayer9ded5eb2019-09-19 16:33:26 +02004055 }
4056 }
4057
4058 return skip;
4059}
4060
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004061bool StatelessValidation::manual_PreCallValidateCmdSetViewportShadingRatePaletteNV(
4062 VkCommandBuffer commandBuffer, uint32_t firstViewport, uint32_t viewportCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004063 const VkShadingRatePaletteNV *pShadingRatePalettes) const {
Jeff Bolz9af91c52018-09-01 21:53:57 -05004064 bool skip = false;
4065
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004066 if (!physical_device_features.multiViewport) {
Jeff Bolz9af91c52018-09-01 21:53:57 -05004067 if (firstViewport != 0) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06004068 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004069 LogError(commandBuffer, "VUID-vkCmdSetViewportShadingRatePaletteNV-firstViewport-02068",
4070 "vkCmdSetViewportShadingRatePaletteNV: The multiViewport feature is disabled, but firstViewport (=%" PRIu32
4071 ") is not 0.",
4072 firstViewport);
Jeff Bolz9af91c52018-09-01 21:53:57 -05004073 }
4074 if (viewportCount > 1) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06004075 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004076 LogError(commandBuffer, "VUID-vkCmdSetViewportShadingRatePaletteNV-viewportCount-02069",
4077 "vkCmdSetViewportShadingRatePaletteNV: The multiViewport feature is disabled, but viewportCount (=%" PRIu32
4078 ") is not 1.",
4079 viewportCount);
Jeff Bolz9af91c52018-09-01 21:53:57 -05004080 }
4081 }
4082
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004083 if (firstViewport >= device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004084 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewportShadingRatePaletteNV-firstViewport-02066",
4085 "vkCmdSetViewportShadingRatePaletteNV: firstViewport (=%" PRIu32
4086 ") must be less than maxViewports (=%" PRIu32 ").",
4087 firstViewport, device_limits.maxViewports);
Jeff Bolz9af91c52018-09-01 21:53:57 -05004088 }
4089
4090 const uint64_t sum = static_cast<uint64_t>(firstViewport) + static_cast<uint64_t>(viewportCount);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004091 if (sum > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004092 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewportShadingRatePaletteNV-firstViewport-02067",
4093 "vkCmdSetViewportShadingRatePaletteNV: firstViewport + viewportCount (=%" PRIu32 " + %" PRIu32
4094 " = %" PRIu64 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
4095 firstViewport, viewportCount, sum, device_limits.maxViewports);
Jeff Bolz9af91c52018-09-01 21:53:57 -05004096 }
4097
4098 return skip;
4099}
4100
Jeff Bolz5c801d12019-10-09 10:38:45 -05004101bool StatelessValidation::manual_PreCallValidateCmdSetCoarseSampleOrderNV(
4102 VkCommandBuffer commandBuffer, VkCoarseSampleOrderTypeNV sampleOrderType, uint32_t customSampleOrderCount,
4103 const VkCoarseSampleOrderCustomNV *pCustomSampleOrders) const {
Jeff Bolz9af91c52018-09-01 21:53:57 -05004104 bool skip = false;
4105
Dave Houlton142c4cb2018-10-17 15:04:41 -06004106 if (sampleOrderType != VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV && customSampleOrderCount != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004107 skip |= LogError(commandBuffer, "VUID-vkCmdSetCoarseSampleOrderNV-sampleOrderType-02081",
4108 "vkCmdSetCoarseSampleOrderNV: If sampleOrderType is not VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV, "
4109 "customSampleOrderCount must be 0.");
Jeff Bolz9af91c52018-09-01 21:53:57 -05004110 }
4111
4112 for (uint32_t order_i = 0; order_i < customSampleOrderCount; ++order_i) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004113 skip |= ValidateCoarseSampleOrderCustomNV(&pCustomSampleOrders[order_i]);
Jeff Bolz9af91c52018-09-01 21:53:57 -05004114 }
4115
4116 return skip;
4117}
4118
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004119bool StatelessValidation::manual_PreCallValidateCmdDrawMeshTasksNV(VkCommandBuffer commandBuffer, uint32_t taskCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004120 uint32_t firstTask) const {
Jeff Bolz45bf7d62018-09-18 15:39:58 -05004121 bool skip = false;
4122
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004123 if (taskCount > phys_dev_ext_props.mesh_shader_props.maxDrawMeshTasksCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004124 skip |= LogError(
4125 commandBuffer, "VUID-vkCmdDrawMeshTasksNV-taskCount-02119",
Dave Houlton142c4cb2018-10-17 15:04:41 -06004126 "vkCmdDrawMeshTasksNV() parameter, uint32_t taskCount (0x%" PRIxLEAST32
4127 "), must be less than or equal to VkPhysicalDeviceMeshShaderPropertiesNV::maxDrawMeshTasksCount (0x%" PRIxLEAST32 ").",
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004128 taskCount, phys_dev_ext_props.mesh_shader_props.maxDrawMeshTasksCount);
Jeff Bolz45bf7d62018-09-18 15:39:58 -05004129 }
4130
4131 return skip;
4132}
4133
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004134bool StatelessValidation::manual_PreCallValidateCmdDrawMeshTasksIndirectNV(VkCommandBuffer commandBuffer, VkBuffer buffer,
4135 VkDeviceSize offset, uint32_t drawCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004136 uint32_t stride) const {
Jeff Bolz45bf7d62018-09-18 15:39:58 -05004137 bool skip = false;
Lockee1c22882019-06-10 16:02:54 -06004138 static const int condition_multiples = 0b0011;
4139 if (offset & condition_multiples) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004140 skip |= LogError(
4141 commandBuffer, "VUID-vkCmdDrawMeshTasksIndirectNV-offset-02710",
Dave Houlton142c4cb2018-10-17 15:04:41 -06004142 "vkCmdDrawMeshTasksIndirectNV() parameter, VkDeviceSize offset (0x%" PRIxLEAST64 "), is not a multiple of 4.", offset);
Jeff Bolz45bf7d62018-09-18 15:39:58 -05004143 }
Lockee1c22882019-06-10 16:02:54 -06004144 if (drawCount > 1 && ((stride & condition_multiples) || stride < sizeof(VkDrawMeshTasksIndirectCommandNV))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004145 skip |= LogError(commandBuffer, "VUID-vkCmdDrawMeshTasksIndirectNV-drawCount-02146",
4146 "vkCmdDrawMeshTasksIndirectNV() parameter, uint32_t stride (0x%" PRIxLEAST32
4147 "), is not a multiple of 4 or smaller than sizeof (VkDrawMeshTasksIndirectCommandNV).",
4148 stride);
Lockee1c22882019-06-10 16:02:54 -06004149 }
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004150 if (!physical_device_features.multiDrawIndirect && ((drawCount > 1))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004151 skip |= LogError(
4152 commandBuffer, "VUID-vkCmdDrawMeshTasksIndirectNV-drawCount-02718",
4153 "vkCmdDrawMeshTasksIndirectNV(): Device feature multiDrawIndirect disabled: count must be 0 or 1 but is %d", drawCount);
Jeff Bolzb574c342018-11-08 15:36:57 -06004154 }
4155
Jeff Bolz45bf7d62018-09-18 15:39:58 -05004156 return skip;
4157}
4158
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004159bool StatelessValidation::manual_PreCallValidateCmdDrawMeshTasksIndirectCountNV(VkCommandBuffer commandBuffer, VkBuffer buffer,
4160 VkDeviceSize offset, VkBuffer countBuffer,
4161 VkDeviceSize countBufferOffset,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004162 uint32_t maxDrawCount, uint32_t stride) const {
Jeff Bolz45bf7d62018-09-18 15:39:58 -05004163 bool skip = false;
4164
Jeff Bolz45bf7d62018-09-18 15:39:58 -05004165 if (offset & 3) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004166 skip |= LogError(commandBuffer, "VUID-vkCmdDrawMeshTasksIndirectCountNV-offset-02710",
4167 "vkCmdDrawMeshTasksIndirectCountNV() parameter, VkDeviceSize offset (0x%" PRIxLEAST64
4168 "), is not a multiple of 4.",
4169 offset);
Jeff Bolz45bf7d62018-09-18 15:39:58 -05004170 }
4171
4172 if (countBufferOffset & 3) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004173 skip |= LogError(commandBuffer, "VUID-vkCmdDrawMeshTasksIndirectCountNV-countBufferOffset-02716",
4174 "vkCmdDrawMeshTasksIndirectCountNV() parameter, VkDeviceSize countBufferOffset (0x%" PRIxLEAST64
4175 "), is not a multiple of 4.",
4176 countBufferOffset);
Jeff Bolz45bf7d62018-09-18 15:39:58 -05004177 }
4178
Jeff Bolz45bf7d62018-09-18 15:39:58 -05004179 return skip;
4180}
4181
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004182bool StatelessValidation::manual_PreCallValidateCreateQueryPool(VkDevice device, const VkQueryPoolCreateInfo *pCreateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004183 const VkAllocationCallbacks *pAllocator,
4184 VkQueryPool *pQueryPool) const {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004185 bool skip = false;
4186
4187 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
4188 if (pCreateInfo != nullptr) {
4189 // If queryType is VK_QUERY_TYPE_PIPELINE_STATISTICS, pipelineStatistics must be a valid combination of
4190 // VkQueryPipelineStatisticFlagBits values
4191 if ((pCreateInfo->queryType == VK_QUERY_TYPE_PIPELINE_STATISTICS) && (pCreateInfo->pipelineStatistics != 0) &&
4192 ((pCreateInfo->pipelineStatistics & (~AllVkQueryPipelineStatisticFlagBits)) != 0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004193 skip |= LogError(device, "VUID-VkQueryPoolCreateInfo-queryType-00792",
4194 "vkCreateQueryPool(): if pCreateInfo->queryType is VK_QUERY_TYPE_PIPELINE_STATISTICS, "
4195 "pCreateInfo->pipelineStatistics must be a valid combination of VkQueryPipelineStatisticFlagBits "
4196 "values.");
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004197 }
sfricke-samsung7d69d0d2020-04-25 10:27:27 -07004198 if (pCreateInfo->queryCount == 0) {
4199 skip |= LogError(device, "VUID-VkQueryPoolCreateInfo-queryCount-02763",
4200 "vkCreateQueryPool(): queryCount must be greater than zero.");
4201 }
Mark Lobodzinskib7a26382018-07-02 13:14:26 -06004202 }
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004203 return skip;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004204}
4205
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004206bool StatelessValidation::manual_PreCallValidateEnumerateDeviceExtensionProperties(VkPhysicalDevice physicalDevice,
4207 const char *pLayerName, uint32_t *pPropertyCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004208 VkExtensionProperties *pProperties) const {
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004209 return validate_array("vkEnumerateDeviceExtensionProperties", "pPropertyCount", "pProperties", pPropertyCount, &pProperties,
4210 true, false, false, kVUIDUndefined, "VUID-vkEnumerateDeviceExtensionProperties-pProperties-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004211}
4212
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004213void StatelessValidation::PostCallRecordCreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo,
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -07004214 const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass,
4215 VkResult result) {
4216 if (result != VK_SUCCESS) return;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004217 RecordRenderPass(*pRenderPass, pCreateInfo);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004218}
4219
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004220void StatelessValidation::PostCallRecordCreateRenderPass2KHR(VkDevice device, const VkRenderPassCreateInfo2KHR *pCreateInfo,
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -07004221 const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass,
4222 VkResult result) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004223 // Track the state necessary for checking vkCreateGraphicsPipeline (subpass usage of depth and color attachments)
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -07004224 if (result != VK_SUCCESS) return;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004225 RecordRenderPass(*pRenderPass, pCreateInfo);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004226}
4227
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004228void StatelessValidation::PostCallRecordDestroyRenderPass(VkDevice device, VkRenderPass renderPass,
4229 const VkAllocationCallbacks *pAllocator) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004230 // Track the state necessary for checking vkCreateGraphicsPipeline (subpass usage of depth and color attachments)
Mark Lobodzinskif27a6bc2019-02-04 13:00:49 -07004231 std::unique_lock<std::mutex> lock(renderpass_map_mutex);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004232 renderpasses_states.erase(renderPass);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004233}
Jeff Bolz7e7e6e02019-01-11 22:53:41 -06004234
4235bool StatelessValidation::manual_PreCallValidateAllocateMemory(VkDevice device, const VkMemoryAllocateInfo *pAllocateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004236 const VkAllocationCallbacks *pAllocator,
4237 VkDeviceMemory *pMemory) const {
Jeff Bolz7e7e6e02019-01-11 22:53:41 -06004238 bool skip = false;
4239
4240 if (pAllocateInfo) {
4241 auto chained_prio_struct = lvl_find_in_chain<VkMemoryPriorityAllocateInfoEXT>(pAllocateInfo->pNext);
4242 if (chained_prio_struct && (chained_prio_struct->priority < 0.0f || chained_prio_struct->priority > 1.0f)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004243 skip |= LogError(device, "VUID-VkMemoryPriorityAllocateInfoEXT-priority-02602",
4244 "priority (=%f) must be between `0` and `1`, inclusive.", chained_prio_struct->priority);
Jeff Bolz7e7e6e02019-01-11 22:53:41 -06004245 }
Jeff Bolz4563f2a2019-12-10 13:30:30 -06004246
4247 VkMemoryAllocateFlags flags = 0;
4248 auto flags_info = lvl_find_in_chain<VkMemoryAllocateFlagsInfo>(pAllocateInfo->pNext);
4249 if (flags_info) {
4250 flags = flags_info->flags;
4251 }
4252
4253 auto opaque_alloc_info = lvl_find_in_chain<VkMemoryOpaqueCaptureAddressAllocateInfoKHR>(pAllocateInfo->pNext);
4254 if (opaque_alloc_info && opaque_alloc_info->opaqueCaptureAddress != 0) {
4255 if (!(flags & VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT_KHR)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004256 skip |= LogError(device, "VUID-VkMemoryAllocateInfo-opaqueCaptureAddress-03329",
4257 "If opaqueCaptureAddress is non-zero, VkMemoryAllocateFlagsInfo::flags must include "
4258 "VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT_KHR.");
Jeff Bolz4563f2a2019-12-10 13:30:30 -06004259 }
4260
4261#ifdef VK_USE_PLATFORM_WIN32_KHR
4262 auto import_memory_win32_handle = lvl_find_in_chain<VkImportMemoryWin32HandleInfoKHR>(pAllocateInfo->pNext);
4263#endif
4264 auto import_memory_fd = lvl_find_in_chain<VkImportMemoryFdInfoKHR>(pAllocateInfo->pNext);
4265 auto import_memory_host_pointer = lvl_find_in_chain<VkImportMemoryHostPointerInfoEXT>(pAllocateInfo->pNext);
4266#ifdef VK_USE_PLATFORM_ANDROID_KHR
4267 auto import_memory_ahb = lvl_find_in_chain<VkImportAndroidHardwareBufferInfoANDROID>(pAllocateInfo->pNext);
4268#endif
4269
4270 if (import_memory_host_pointer) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004271 skip |= LogError(
4272 device, "VUID-VkMemoryAllocateInfo-pNext-03332",
Jeff Bolz4563f2a2019-12-10 13:30:30 -06004273 "If the pNext chain includes a VkImportMemoryHostPointerInfoEXT structure, opaqueCaptureAddress must be zero.");
4274 }
4275 if (
4276#ifdef VK_USE_PLATFORM_WIN32_KHR
4277 (import_memory_win32_handle && import_memory_win32_handle->handleType) ||
4278#endif
4279 (import_memory_fd && import_memory_fd->handleType) ||
4280#ifdef VK_USE_PLATFORM_ANDROID_KHR
4281 (import_memory_ahb && import_memory_ahb->buffer) ||
4282#endif
4283 (import_memory_host_pointer && import_memory_host_pointer->handleType)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004284 skip |= LogError(device, "VUID-VkMemoryAllocateInfo-opaqueCaptureAddress-03333",
4285 "If the parameters define an import operation, opaqueCaptureAddress must be zero.");
Jeff Bolz4563f2a2019-12-10 13:30:30 -06004286 }
4287 }
4288
4289 if (flags) {
Tony-LunarGa74d3fe2019-11-22 15:43:20 -07004290 VkBool32 capture_replay = false;
4291 VkBool32 buffer_device_address = false;
4292 const auto *vulkan_12_features = lvl_find_in_chain<VkPhysicalDeviceVulkan12Features>(device_createinfo_pnext);
4293 if (vulkan_12_features) {
4294 capture_replay = vulkan_12_features->bufferDeviceAddressCaptureReplay;
4295 buffer_device_address = vulkan_12_features->bufferDeviceAddress;
4296 } else {
4297 const auto *bda_features =
4298 lvl_find_in_chain<VkPhysicalDeviceBufferDeviceAddressFeaturesKHR>(device_createinfo_pnext);
4299 if (bda_features) {
4300 capture_replay = bda_features->bufferDeviceAddressCaptureReplay;
4301 buffer_device_address = bda_features->bufferDeviceAddress;
4302 }
4303 }
4304 if ((flags & VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT_KHR) && !capture_replay) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004305 skip |= LogError(device, "VUID-VkMemoryAllocateInfo-flags-03330",
4306 "If VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT_KHR is set, "
4307 "bufferDeviceAddressCaptureReplay must be enabled.");
Jeff Bolz4563f2a2019-12-10 13:30:30 -06004308 }
Tony-LunarGa74d3fe2019-11-22 15:43:20 -07004309 if ((flags & VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_BIT_KHR) && !buffer_device_address) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004310 skip |= LogError(device, "VUID-VkMemoryAllocateInfo-flags-03331",
4311 "If VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_BIT_KHR is set, bufferDeviceAddress must be enabled.");
Jeff Bolz4563f2a2019-12-10 13:30:30 -06004312 }
4313 }
Jeff Bolz7e7e6e02019-01-11 22:53:41 -06004314 }
4315 return skip;
4316}
Ricardo Garciaa4935972019-02-21 17:43:18 +01004317
Jason Macnak192fa0e2019-07-26 15:07:16 -07004318bool StatelessValidation::ValidateGeometryTrianglesNV(const VkGeometryTrianglesNV &triangles,
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004319 VkAccelerationStructureNV object_handle, const char *func_name) const {
Jason Macnak192fa0e2019-07-26 15:07:16 -07004320 bool skip = false;
4321
4322 if (triangles.vertexFormat != VK_FORMAT_R32G32B32_SFLOAT && triangles.vertexFormat != VK_FORMAT_R16G16B16_SFLOAT &&
4323 triangles.vertexFormat != VK_FORMAT_R16G16B16_SNORM && triangles.vertexFormat != VK_FORMAT_R32G32_SFLOAT &&
4324 triangles.vertexFormat != VK_FORMAT_R16G16_SFLOAT && triangles.vertexFormat != VK_FORMAT_R16G16_SNORM) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004325 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-vertexFormat-02430", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004326 } else {
4327 uint32_t vertex_component_size = 0;
4328 if (triangles.vertexFormat == VK_FORMAT_R32G32B32_SFLOAT || triangles.vertexFormat == VK_FORMAT_R32G32_SFLOAT) {
4329 vertex_component_size = 4;
4330 } else if (triangles.vertexFormat == VK_FORMAT_R16G16B16_SFLOAT || triangles.vertexFormat == VK_FORMAT_R16G16B16_SNORM ||
4331 triangles.vertexFormat == VK_FORMAT_R16G16_SFLOAT || triangles.vertexFormat == VK_FORMAT_R16G16_SNORM) {
4332 vertex_component_size = 2;
4333 }
4334 if (vertex_component_size > 0 && SafeModulo(triangles.vertexOffset, vertex_component_size) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004335 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-vertexOffset-02429", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004336 }
4337 }
4338
4339 if (triangles.indexType != VK_INDEX_TYPE_UINT32 && triangles.indexType != VK_INDEX_TYPE_UINT16 &&
4340 triangles.indexType != VK_INDEX_TYPE_NONE_NV) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004341 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-indexType-02433", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004342 } else {
4343 uint32_t index_element_size = 0;
4344 if (triangles.indexType == VK_INDEX_TYPE_UINT32) {
4345 index_element_size = 4;
4346 } else if (triangles.indexType == VK_INDEX_TYPE_UINT16) {
4347 index_element_size = 2;
4348 }
4349 if (index_element_size > 0 && SafeModulo(triangles.indexOffset, index_element_size) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004350 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-indexOffset-02432", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004351 }
4352 }
4353 if (triangles.indexType == VK_INDEX_TYPE_NONE_NV) {
4354 if (triangles.indexCount != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004355 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-indexCount-02436", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004356 }
4357 if (triangles.indexData != VK_NULL_HANDLE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004358 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-indexData-02434", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004359 }
4360 }
4361
4362 if (SafeModulo(triangles.transformOffset, 16) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004363 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-transformOffset-02438", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004364 }
4365
4366 return skip;
4367}
4368
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004369bool StatelessValidation::ValidateGeometryAABBNV(const VkGeometryAABBNV &aabbs, VkAccelerationStructureNV object_handle,
4370 const char *func_name) const {
Jason Macnak192fa0e2019-07-26 15:07:16 -07004371 bool skip = false;
4372
4373 if (SafeModulo(aabbs.offset, 8) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004374 skip |= LogError(object_handle, "VUID-VkGeometryAABBNV-offset-02440", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004375 }
4376 if (SafeModulo(aabbs.stride, 8) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004377 skip |= LogError(object_handle, "VUID-VkGeometryAABBNV-stride-02441", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004378 }
4379
4380 return skip;
4381}
4382
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004383bool StatelessValidation::ValidateGeometryNV(const VkGeometryNV &geometry, VkAccelerationStructureNV object_handle,
4384 const char *func_name) const {
Jason Macnak192fa0e2019-07-26 15:07:16 -07004385 bool skip = false;
4386 if (geometry.geometryType == VK_GEOMETRY_TYPE_TRIANGLES_NV) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004387 skip = ValidateGeometryTrianglesNV(geometry.geometry.triangles, object_handle, func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004388 } else if (geometry.geometryType == VK_GEOMETRY_TYPE_AABBS_NV) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004389 skip = ValidateGeometryAABBNV(geometry.geometry.aabbs, object_handle, func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004390 }
4391 return skip;
4392}
4393
4394bool StatelessValidation::ValidateAccelerationStructureInfoNV(const VkAccelerationStructureInfoNV &info,
sourav parmara24fb7b2020-05-26 10:50:04 -07004395 VkAccelerationStructureNV object_handle, const char *func_name,
Mark Lobodzinski17dc4602020-05-29 07:48:40 -06004396 bool is_cmd) const {
Jason Macnak5c954952019-07-09 15:46:12 -07004397 bool skip = false;
4398 if (info.type == VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_NV && info.geometryCount != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004399 skip |= LogError(object_handle, "VUID-VkAccelerationStructureInfoNV-type-02425",
4400 "VkAccelerationStructureInfoNV: If type is VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_NV then "
4401 "geometryCount must be 0.");
Jason Macnak5c954952019-07-09 15:46:12 -07004402 }
4403 if (info.type == VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_NV && info.instanceCount != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004404 skip |= LogError(object_handle, "VUID-VkAccelerationStructureInfoNV-type-02426",
4405 "VkAccelerationStructureInfoNV: If type is VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_NV then "
4406 "instanceCount must be 0.");
Jason Macnak5c954952019-07-09 15:46:12 -07004407 }
4408 if (info.flags & VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_TRACE_BIT_NV &&
4409 info.flags & VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_BUILD_BIT_NV) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004410 skip |= LogError(object_handle, "VUID-VkAccelerationStructureInfoNV-flags-02592",
4411 "VkAccelerationStructureInfoNV: If flags has the VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_TRACE_BIT_NV"
4412 "bit set, then it must not have the VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_BUILD_BIT_NV bit set.");
Jason Macnak5c954952019-07-09 15:46:12 -07004413 }
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004414 if (info.geometryCount > phys_dev_ext_props.ray_tracing_propsNV.maxGeometryCount) {
sourav parmara24fb7b2020-05-26 10:50:04 -07004415 skip |= LogError(object_handle,
Mark Lobodzinski17dc4602020-05-29 07:48:40 -06004416 is_cmd ? "VUID-vkCmdBuildAccelerationStructureNV-geometryCount-02241"
4417 : "VUID-VkAccelerationStructureInfoNV-geometryCount-02422",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004418 "VkAccelerationStructureInfoNV: geometryCount must be less than or equal to "
4419 "VkPhysicalDeviceRayTracingPropertiesNV::maxGeometryCount.");
Jason Macnak5c954952019-07-09 15:46:12 -07004420 }
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004421 if (info.instanceCount > phys_dev_ext_props.ray_tracing_propsNV.maxInstanceCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004422 skip |= LogError(object_handle, "VUID-VkAccelerationStructureInfoNV-instanceCount-02423",
4423 "VkAccelerationStructureInfoNV: instanceCount must be less than or equal to "
4424 "VkPhysicalDeviceRayTracingPropertiesNV::maxInstanceCount.");
Jason Macnak5c954952019-07-09 15:46:12 -07004425 }
Jason Macnak21ba97e2019-08-09 12:57:44 -07004426 if (info.type == VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_NV && info.geometryCount > 0) {
Jason Macnak5c954952019-07-09 15:46:12 -07004427 uint64_t total_triangle_count = 0;
4428 for (uint32_t i = 0; i < info.geometryCount; i++) {
4429 const VkGeometryNV &geometry = info.pGeometries[i];
Jason Macnak192fa0e2019-07-26 15:07:16 -07004430
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004431 skip |= ValidateGeometryNV(geometry, object_handle, func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004432
Jason Macnak5c954952019-07-09 15:46:12 -07004433 if (geometry.geometryType != VK_GEOMETRY_TYPE_TRIANGLES_NV) {
4434 continue;
4435 }
4436 total_triangle_count += geometry.geometry.triangles.indexCount / 3;
4437 }
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004438 if (total_triangle_count > phys_dev_ext_props.ray_tracing_propsNV.maxTriangleCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004439 skip |= LogError(object_handle, "VUID-VkAccelerationStructureInfoNV-maxTriangleCount-02424",
4440 "VkAccelerationStructureInfoNV: The total number of triangles in all geometries must be less than "
4441 "or equal to VkPhysicalDeviceRayTracingPropertiesNV::maxTriangleCount.");
Jason Macnak5c954952019-07-09 15:46:12 -07004442 }
4443 }
Jason Macnak21ba97e2019-08-09 12:57:44 -07004444 if (info.type == VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_NV && info.geometryCount > 1) {
4445 const VkGeometryTypeNV first_geometry_type = info.pGeometries[0].geometryType;
4446 for (uint32_t i = 1; i < info.geometryCount; i++) {
4447 const VkGeometryNV &geometry = info.pGeometries[i];
4448 if (geometry.geometryType != first_geometry_type) {
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004449 skip |= LogError(device, "VUID-VkAccelerationStructureInfoNV-type-02786",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004450 "VkAccelerationStructureInfoNV: info.pGeometries[%d].geometryType does not match "
4451 "info.pGeometries[0].geometryType.",
4452 i);
Jason Macnak21ba97e2019-08-09 12:57:44 -07004453 }
4454 }
4455 }
sourav parmara96ab1a2020-04-25 16:28:23 -07004456 for (uint32_t geometry_index = 0; geometry_index < info.geometryCount; ++geometry_index) {
4457 if (!(info.pGeometries[geometry_index].geometryType == VK_GEOMETRY_TYPE_TRIANGLES_NV ||
4458 info.pGeometries[geometry_index].geometryType == VK_GEOMETRY_TYPE_AABBS_NV)) {
4459 skip |= LogError(device, "VUID-VkGeometryNV-geometryType-03503",
4460 "VkGeometryNV: geometryType must be VK_GEOMETRY_TYPE_TRIANGLES_NV"
4461 "or VK_GEOMETRY_TYPE_AABBS_NV.");
4462 }
4463 }
4464 skip |=
4465 validate_flags(func_name, "info.flags", "VkBuildAccelerationStructureFlagBitsNV", AllVkBuildAccelerationStructureFlagBitsNV,
Shannon McPherson93970b12020-06-12 14:34:35 -06004466 info.flags, kOptionalFlags, "VUID-VkAccelerationStructureInfoNV-flags-parameter");
Jason Macnak5c954952019-07-09 15:46:12 -07004467 return skip;
4468}
4469
Ricardo Garciaa4935972019-02-21 17:43:18 +01004470bool StatelessValidation::manual_PreCallValidateCreateAccelerationStructureNV(
4471 VkDevice device, const VkAccelerationStructureCreateInfoNV *pCreateInfo, const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004472 VkAccelerationStructureNV *pAccelerationStructure) const {
Ricardo Garciaa4935972019-02-21 17:43:18 +01004473 bool skip = false;
Ricardo Garciaa4935972019-02-21 17:43:18 +01004474 if (pCreateInfo) {
4475 if ((pCreateInfo->compactedSize != 0) &&
4476 ((pCreateInfo->info.geometryCount != 0) || (pCreateInfo->info.instanceCount != 0))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004477 skip |= LogError(device, "VUID-VkAccelerationStructureCreateInfoNV-compactedSize-02421",
4478 "vkCreateAccelerationStructureNV(): pCreateInfo->compactedSize nonzero (%" PRIu64
4479 ") with info.geometryCount (%" PRIu32 ") or info.instanceCount (%" PRIu32 ") nonzero.",
4480 pCreateInfo->compactedSize, pCreateInfo->info.geometryCount, pCreateInfo->info.instanceCount);
Ricardo Garciaa4935972019-02-21 17:43:18 +01004481 }
Jason Macnak5c954952019-07-09 15:46:12 -07004482
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004483 skip |= ValidateAccelerationStructureInfoNV(pCreateInfo->info, VkAccelerationStructureNV(0),
sourav parmara24fb7b2020-05-26 10:50:04 -07004484 "vkCreateAccelerationStructureNV()", false);
Ricardo Garciaa4935972019-02-21 17:43:18 +01004485 }
Ricardo Garciaa4935972019-02-21 17:43:18 +01004486 return skip;
4487}
Mike Schuchardt21638df2019-03-16 10:52:02 -07004488
Jeff Bolz5c801d12019-10-09 10:38:45 -05004489bool StatelessValidation::manual_PreCallValidateCmdBuildAccelerationStructureNV(VkCommandBuffer commandBuffer,
4490 const VkAccelerationStructureInfoNV *pInfo,
4491 VkBuffer instanceData, VkDeviceSize instanceOffset,
4492 VkBool32 update, VkAccelerationStructureNV dst,
4493 VkAccelerationStructureNV src, VkBuffer scratch,
4494 VkDeviceSize scratchOffset) const {
Jason Macnak5c954952019-07-09 15:46:12 -07004495 bool skip = false;
4496
4497 if (pInfo != nullptr) {
sourav parmara24fb7b2020-05-26 10:50:04 -07004498 skip |= ValidateAccelerationStructureInfoNV(*pInfo, dst, "vkCmdBuildAccelerationStructureNV()", true);
Jason Macnak5c954952019-07-09 15:46:12 -07004499 }
4500
4501 return skip;
4502}
4503
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004504bool StatelessValidation::manual_PreCallValidateCreateAccelerationStructureKHR(
4505 VkDevice device, const VkAccelerationStructureCreateInfoKHR *pCreateInfo, const VkAllocationCallbacks *pAllocator,
4506 VkAccelerationStructureKHR *pAccelerationStructure) const {
4507 bool skip = false;
4508
4509 if (pCreateInfo) {
4510 for (uint32_t i = 0; i < pCreateInfo->maxGeometryCount; ++i) {
4511 if (pCreateInfo->type == VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_KHR && pCreateInfo->compactedSize == 0) {
4512 if (pCreateInfo->pGeometryInfos[i].geometryType != VK_GEOMETRY_TYPE_INSTANCES_KHR) {
4513 skip |= LogError(device, "VUID-VkAccelerationStructureCreateInfoKHR-type-03496",
4514 "VkAccelerationStructureCreateInfoKHR: Top-level acceleration structure "
4515 "pGeometryInfos[%d].geometryType must be VK_GEOMETRY_TYPE_INSTANCES_KHR",
4516 i);
4517 }
4518 }
4519
4520 if (pCreateInfo->type == VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_KHR && pCreateInfo->compactedSize == 0) {
4521 if (pCreateInfo->pGeometryInfos[i].geometryType == VK_GEOMETRY_TYPE_INSTANCES_KHR) {
4522 skip |= LogError(device, "VUID-VkAccelerationStructureCreateInfoKHR-type-03497",
4523 "VkAccelerationStructureCreateInfoKHR: Bottom-level acceleration structure "
4524 "pGeometryInfos[%d].geometryType must not be VK_GEOMETRY_TYPE_INSTANCES_KHR",
4525 i);
4526 }
4527 }
sourav parmara96ab1a2020-04-25 16:28:23 -07004528 if (pCreateInfo->pGeometryInfos[i].geometryType == VK_GEOMETRY_TYPE_TRIANGLES_KHR) {
4529 if (!(pCreateInfo->pGeometryInfos[i].indexType == VK_INDEX_TYPE_UINT16 ||
4530 pCreateInfo->pGeometryInfos[i].indexType == VK_INDEX_TYPE_UINT32 ||
4531 pCreateInfo->pGeometryInfos[i].indexType == VK_INDEX_TYPE_NONE_KHR)) {
4532 skip |= LogError(
4533 device, "VUID-VkAccelerationStructureCreateGeometryTypeInfoKHR-geometryType-03502",
4534 "VkAccelerationStructureCreateInfoKHR: If geometryType is VK_GEOMETRY_TYPE_TRIANGLES_KHR, indexType"
4535 "must be VK_INDEX_TYPE_UINT16, VK_INDEX_TYPE_UINT32, or VK_INDEX_TYPE_NONE_KHR.");
4536 }
4537 }
4538 if (pCreateInfo->type == VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_KHR) {
4539 if (pCreateInfo->pGeometryInfos[i].maxPrimitiveCount > phys_dev_ext_props.ray_tracing_propsKHR.maxInstanceCount) {
4540 skip |= LogError(device, "VUID-VkAccelerationStructureCreateInfoKHR-type-03492",
4541 "VkAccelerationStructureCreateInfoKHR: If type is VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_KHR"
4542 "then pGeometryInfos->maxPrimitiveCount %d must be less than or equal to "
4543 "VkPhysicalDeviceRayTracingPropertiesKHR::maxInstanceCount %d.",
4544 pCreateInfo->pGeometryInfos[i].maxPrimitiveCount,
4545 phys_dev_ext_props.ray_tracing_propsKHR.maxInstanceCount);
4546 }
4547 }
4548 }
4549
4550 if (pCreateInfo->type == VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_KHR && pCreateInfo->compactedSize == 0 &&
4551 pCreateInfo->maxGeometryCount != 1) {
4552 skip |= LogError(device, "VUID-VkAccelerationStructureCreateInfoKHR-type-03495",
4553 "VkAccelerationStructureCreateInfoKHR: If type is VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_KHR"
4554 "and compactedSize is 0, maxGeometryCount must be 1.");
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004555 }
sourav parmard1521802020-06-07 21:49:02 -07004556 // or VUID-VkAccelerationStructureCreateInfoKHR-compactedSize-03490
4557 if (pCreateInfo->compactedSize == 0 && pCreateInfo->maxGeometryCount == 0) {
4558 skip |= LogError(device, "VUID-VkAccelerationStructureCreateInfoKHR-compactedSize-02993",
4559 "VkAccelerationStructureCreateInfoKHR: If compactedSize is 0 then maxGeometryCount must not be 0.");
4560 }
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004561
4562 if (pCreateInfo->flags & VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_TRACE_BIT_KHR &&
4563 pCreateInfo->flags & VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_BUILD_BIT_KHR) {
4564 skip |= LogError(
4565 device, "VUID-VkAccelerationStructureCreateInfoKHR-flags-03499",
4566 "VkAccelerationStructureCreateInfoKHR: If flags has the VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_TRACE_BIT_KHR"
4567 "bit set, then it must not have the VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_BUILD_BIT_KHR bit set.");
4568 }
4569
4570 if (pCreateInfo->compactedSize != 0 && pCreateInfo->maxGeometryCount != 0) {
4571 skip |= LogError(device, "VUID-VkAccelerationStructureCreateInfoKHR-compactedSize-03490",
4572 "VkAccelerationStructureCreateInfoKHR: pCreateInfo->compactedSize nonzero (%" PRIu64
4573 ") with maxGeometryCount (%" PRIu32 ") nonzero.",
4574 pCreateInfo->compactedSize, pCreateInfo->maxGeometryCount);
4575 }
4576
4577 if (pCreateInfo->type == VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_NV && pCreateInfo->maxGeometryCount > 1) {
4578 const VkGeometryTypeKHR first_geometry_type = pCreateInfo->pGeometryInfos[0].geometryType;
4579 for (uint32_t i = 1; i < pCreateInfo->maxGeometryCount; i++) {
4580 const VkGeometryTypeKHR geometry_type = pCreateInfo->pGeometryInfos[i].geometryType;
4581 if (geometry_type != first_geometry_type) {
4582 skip |= LogError(device, "VUID-VkAccelerationStructureCreateInfoKHR-type-03498",
4583 "VkAccelerationStructureCreateInfoKHR: pGeometryInfos[%d].geometryType does not match "
4584 "pGeometryInfos[0].geometryType.",
4585 i);
4586 }
4587 }
4588 }
sourav parmara96ab1a2020-04-25 16:28:23 -07004589 if (pCreateInfo->type == VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_KHR &&
4590 (pCreateInfo->maxGeometryCount > phys_dev_ext_props.ray_tracing_propsKHR.maxGeometryCount)) {
4591 skip |= LogError(device, "VUID-VkAccelerationStructureCreateInfoKHR-type-03491",
4592 "VkAccelerationStructureCreateInfoKHR: If type is VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_KHR"
4593 "then maxGeometryCount %d must be less than or equal to VkPhysicalDeviceRayTracingPropertiesKHR "
4594 "maxGeometryCount %d.",
4595 pCreateInfo->maxGeometryCount, phys_dev_ext_props.ray_tracing_propsKHR.maxGeometryCount);
4596 }
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004597 }
sourav parmara96ab1a2020-04-25 16:28:23 -07004598 const auto *raytracing_features = lvl_find_in_chain<VkPhysicalDeviceRayTracingFeaturesKHR>(device_createinfo_pnext);
4599 if (!raytracing_features || raytracing_features->rayTracingAccelerationStructureCaptureReplay == VK_FALSE) {
4600 if (pCreateInfo->deviceAddress != 0) {
4601 skip |=
4602 LogError(device, "VUID-VkAccelerationStructureCreateInfoKHR-deviceAddress-03500",
4603 "VkAccelerationStructureCreateInfoKHR: If deviceAddress is not 0, "
4604 "VkPhysicalDeviceRayTracingFeaturesKHR::rayTracingAccelerationStructureCaptureReplay must be VK_TRUE.");
4605 }
4606 }
sourav parmar83c31b12020-05-06 12:30:54 -07004607 if (!raytracing_features || !(raytracing_features->rayQuery == VK_TRUE || raytracing_features->rayTracing == VK_TRUE)) {
4608 skip |= LogError(device, "VUID-vkCreateAccelerationStructureKHR-rayTracing-03487",
4609 "vkCreateAccelerationStructureKHR: The rayTracing or rayQuery feature must be enabled.");
4610 }
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004611 return skip;
4612}
4613
Jason Macnak5c954952019-07-09 15:46:12 -07004614bool StatelessValidation::manual_PreCallValidateGetAccelerationStructureHandleNV(VkDevice device,
4615 VkAccelerationStructureNV accelerationStructure,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004616 size_t dataSize, void *pData) const {
Jason Macnak5c954952019-07-09 15:46:12 -07004617 bool skip = false;
4618 if (dataSize < 8) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004619 skip = LogError(accelerationStructure, "VUID-vkGetAccelerationStructureHandleNV-dataSize-02240",
4620 "vkGetAccelerationStructureHandleNV(): dataSize must be greater than or equal to 8.");
Jason Macnak5c954952019-07-09 15:46:12 -07004621 }
4622 return skip;
4623}
4624
Peter Chen85366392019-05-14 15:20:11 -04004625bool StatelessValidation::manual_PreCallValidateCreateRayTracingPipelinesNV(VkDevice device, VkPipelineCache pipelineCache,
4626 uint32_t createInfoCount,
4627 const VkRayTracingPipelineCreateInfoNV *pCreateInfos,
4628 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004629 VkPipeline *pPipelines) const {
Peter Chen85366392019-05-14 15:20:11 -04004630 bool skip = false;
4631
4632 for (uint32_t i = 0; i < createInfoCount; i++) {
4633 auto feedback_struct = lvl_find_in_chain<VkPipelineCreationFeedbackCreateInfoEXT>(pCreateInfos[i].pNext);
4634 if ((feedback_struct != nullptr) && (feedback_struct->pipelineStageCreationFeedbackCount != pCreateInfos[i].stageCount)) {
sourav parmar83c31b12020-05-06 12:30:54 -07004635 skip |= LogError(device, "VUID-VkPipelineCreationFeedbackCreateInfoEXT-pipelineStageCreationFeedbackCount-02969",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004636 "vkCreateRayTracingPipelinesNV(): in pCreateInfo[%" PRIu32
4637 "], VkPipelineCreationFeedbackEXT::pipelineStageCreationFeedbackCount"
4638 "(=%" PRIu32 ") must equal VkRayTracingPipelineCreateInfoNV::stageCount(=%" PRIu32 ").",
4639 i, feedback_struct->pipelineStageCreationFeedbackCount, pCreateInfos[i].stageCount);
Peter Chen85366392019-05-14 15:20:11 -04004640 }
sourav parmara96ab1a2020-04-25 16:28:23 -07004641
4642 const auto *pipeline_cache_contol_features =
4643 lvl_find_in_chain<VkPhysicalDevicePipelineCreationCacheControlFeaturesEXT>(device_createinfo_pnext);
4644 if (!pipeline_cache_contol_features || pipeline_cache_contol_features->pipelineCreationCacheControl == VK_FALSE) {
4645 if (pCreateInfos[i].flags & (VK_PIPELINE_CREATE_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT_EXT |
4646 VK_PIPELINE_CREATE_EARLY_RETURN_ON_FAILURE_BIT_EXT)) {
4647 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-pipelineCreationCacheControl-02905",
4648 "vkCreateRayTracingPipelinesNV(): If the pipelineCreationCacheControl feature is not enabled,"
4649 "flags must not include VK_PIPELINE_CREATE_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT_EXT or"
4650 "VK_PIPELINE_CREATE_EARLY_RETURN_ON_FAILURE_BIT_EXT.");
4651 }
4652 }
4653
sourav parmarf4a78252020-04-10 13:04:21 -07004654 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_INDIRECT_BINDABLE_BIT_NV) {
4655 skip |=
4656 LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-02904",
4657 "vkCreateRayTracingPipelinesNV(): flags must not include VK_PIPELINE_CREATE_INDIRECT_BINDABLE_BIT_NV.");
4658 }
4659 if ((pCreateInfos[i].flags & VK_PIPELINE_CREATE_DEFER_COMPILE_BIT_NV) &&
4660 (pCreateInfos[i].flags & VK_PIPELINE_CREATE_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT_EXT)) {
4661 skip |=
4662 LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-02957",
4663 "vkCreateRayTracingPipelinesNV(): flags must not include both VK_PIPELINE_CREATE_DEFER_COMPILE_BIT_NV and"
4664 "VK_PIPELINE_CREATE_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT_EXT at the same time.");
4665 }
4666 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_DERIVATIVE_BIT) {
4667 if (pCreateInfos[i].basePipelineIndex != -1) {
4668 if (pCreateInfos[i].basePipelineHandle != VK_NULL_HANDLE) {
4669 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03423",
4670 "vkCreateRayTracingPipelinesNV parameter, pCreateInfos->basePipelineHandle, must be "
4671 "VK_NULL_HANDLE if pCreateInfos->flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT flag "
4672 "and pCreateInfos->basePipelineIndex is not -1.");
4673 }
sourav parmara24fb7b2020-05-26 10:50:04 -07004674 if (pCreateInfos[i].basePipelineIndex > (int32_t)(i)) {
4675 skip |=
4676 LogError(device, "VUID-vkCreateRayTracingPipelinesNV-flags-03415",
4677 "vkCreateRayTracingPipelinesNV: If the flags member of any element of pCreateInfos contains the"
4678 "VK_PIPELINE_CREATE_DERIVATIVE_BIT flag, and the basePipelineIndex member of that same element"
4679 "is not -1, basePipelineIndex must be less than the index into pCreateInfos that corresponds to "
4680 "that element.");
4681 }
sourav parmarf4a78252020-04-10 13:04:21 -07004682 }
4683 if (pCreateInfos[i].basePipelineHandle == VK_NULL_HANDLE) {
David Netod9d7b762020-07-27 15:37:58 -04004684 if (static_cast<uint32_t>(pCreateInfos[i].basePipelineIndex) >= createInfoCount) {
sourav parmarf4a78252020-04-10 13:04:21 -07004685 skip |=
4686 LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03422",
4687 "vkCreateRayTracingPipelinesNV if flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT and"
4688 "basePipelineHandle is VK_NULL_HANDLE, basePipelineIndex must be a valid index into the calling"
4689 "commands pCreateInfos parameter.");
4690 }
4691 } else {
4692 if (pCreateInfos[i].basePipelineIndex != -1) {
4693 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03424",
4694 "vkCreateRayTracingPipelinesNV if flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT and"
4695 "basePipelineHandle is not VK_NULL_HANDLE, basePipelineIndex must be -1.");
4696 }
4697 }
4698 }
4699 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_LIBRARY_BIT_KHR) {
4700 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03456",
4701 "vkCreateRayTracingPipelinesNV: flags must not include VK_PIPELINE_CREATE_LIBRARY_BIT_KHR.");
4702 }
4703 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_ANY_HIT_SHADERS_BIT_KHR) {
4704 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03458",
4705 "vkCreateRayTracingPipelinesNV: flags must not include "
4706 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_ANY_HIT_SHADERS_BIT_KHR.");
4707 }
4708 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_CLOSEST_HIT_SHADERS_BIT_KHR) {
4709 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03459",
4710 "vkCreateRayTracingPipelinesNV: flags must not include "
4711 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_CLOSEST_HIT_SHADERS_BIT_KHR.");
4712 }
4713 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_MISS_SHADERS_BIT_KHR) {
4714 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03460",
4715 "vkCreateRayTracingPipelinesNV: flags must not include "
4716 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_MISS_SHADERS_BIT_KHR.");
4717 }
4718 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_INTERSECTION_SHADERS_BIT_KHR) {
4719 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03461",
4720 "vkCreateRayTracingPipelinesNV: flags must not include "
4721 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_INTERSECTION_SHADERS_BIT_KHR.");
4722 }
4723 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_SKIP_AABBS_BIT_KHR) {
4724 skip |= LogError(
4725 device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03462",
4726 "vkCreateRayTracingPipelinesNV: flags must not include VK_PIPELINE_CREATE_RAY_TRACING_SKIP_AABBS_BIT_KHR.");
4727 }
4728 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_SKIP_TRIANGLES_BIT_KHR) {
4729 skip |= LogError(
4730 device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03463",
4731 "vkCreateRayTracingPipelinesNV: flags must not include VK_PIPELINE_CREATE_RAY_TRACING_SKIP_TRIANGLES_BIT_KHR .");
4732 }
Peter Chen85366392019-05-14 15:20:11 -04004733 }
4734
4735 return skip;
4736}
4737
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004738bool StatelessValidation::manual_PreCallValidateCreateRayTracingPipelinesKHR(VkDevice device, VkPipelineCache pipelineCache,
4739 uint32_t createInfoCount,
4740 const VkRayTracingPipelineCreateInfoKHR *pCreateInfos,
4741 const VkAllocationCallbacks *pAllocator,
4742 VkPipeline *pPipelines) const {
4743 bool skip = false;
sourav parmar83c31b12020-05-06 12:30:54 -07004744 const auto *raytracing_features = lvl_find_in_chain<VkPhysicalDeviceRayTracingFeaturesKHR>(device_createinfo_pnext);
4745 if (!raytracing_features || raytracing_features->rayTracing == VK_FALSE) {
4746 skip |= LogError(device, "VUID-vkCreateRayTracingPipelinesKHR-rayTracing-03455",
4747 "vkCreateRayTracingPipelinesKHR(): The rayTracing feature must be enabled.");
4748 }
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004749 for (uint32_t i = 0; i < createInfoCount; i++) {
4750 auto feedback_struct = lvl_find_in_chain<VkPipelineCreationFeedbackCreateInfoEXT>(pCreateInfos[i].pNext);
4751 if ((feedback_struct != nullptr) && (feedback_struct->pipelineStageCreationFeedbackCount != pCreateInfos[i].stageCount)) {
4752 skip |= LogError(device, "VUID-VkPipelineCreationFeedbackCreateInfoEXT-pipelineStageCreationFeedbackCount-02670",
4753 "vkCreateRayTracingPipelinesKHR(): in pCreateInfo[%" PRIu32
4754 "], VkPipelineCreationFeedbackEXT::pipelineStageCreationFeedbackCount"
4755 "(=%" PRIu32 ") must equal VkRayTracingPipelineCreateInfoKHR::stageCount(=%" PRIu32 ").",
4756 i, feedback_struct->pipelineStageCreationFeedbackCount, pCreateInfos[i].stageCount);
4757 }
sourav parmara96ab1a2020-04-25 16:28:23 -07004758 const auto *pipeline_cache_contol_features =
4759 lvl_find_in_chain<VkPhysicalDevicePipelineCreationCacheControlFeaturesEXT>(device_createinfo_pnext);
4760 if (!pipeline_cache_contol_features || pipeline_cache_contol_features->pipelineCreationCacheControl == VK_FALSE) {
4761 if (pCreateInfos[i].flags & (VK_PIPELINE_CREATE_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT_EXT |
4762 VK_PIPELINE_CREATE_EARLY_RETURN_ON_FAILURE_BIT_EXT)) {
4763 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-pipelineCreationCacheControl-02905",
4764 "vkCreateRayTracingPipelinesKHR(): If the pipelineCreationCacheControl feature is not enabled,"
4765 "flags must not include VK_PIPELINE_CREATE_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT_EXT or"
4766 "VK_PIPELINE_CREATE_EARLY_RETURN_ON_FAILURE_BIT_EXT.");
4767 }
4768 }
sourav parmara96ab1a2020-04-25 16:28:23 -07004769 if (!raytracing_features || raytracing_features->rayTracingPrimitiveCulling == VK_FALSE) {
4770 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_SKIP_AABBS_BIT_KHR) {
4771 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-rayTracingPrimitiveCulling-03472",
4772 "vkCreateRayTracingPipelinesKHR(): If the rayTracingPrimitiveCulling feature is not enabled,"
4773 "flags must not include VK_PIPELINE_CREATE_RAY_TRACING_SKIP_AABBS_BIT_KHR.");
4774 }
4775 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_SKIP_TRIANGLES_BIT_KHR) {
4776 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-rayTracingPrimitiveCulling-03473",
4777 "vkCreateRayTracingPipelinesKHR(): If the rayTracingPrimitiveCulling feature is not enabled,"
4778 "flags must not include VK_PIPELINE_CREATE_RAY_TRACING_SKIP_TRIANGLES_BIT_KHR .");
4779 }
4780 }
4781
sourav parmarf4a78252020-04-10 13:04:21 -07004782 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_INDIRECT_BINDABLE_BIT_NV) {
4783 skip |=
4784 LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-02904",
4785 "vkCreateRayTracingPipelinesKHR(): flags must not include VK_PIPELINE_CREATE_INDIRECT_BINDABLE_BIT_NV.");
4786 }
4787 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_LIBRARY_BIT_KHR) {
4788 if (pCreateInfos[i].pLibraryInterface == NULL)
4789 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-03465",
4790 "If flags includes VK_PIPELINE_CREATE_LIBRARY_BIT_KHR, pLibraryInterface must not be NULL.");
4791 }
4792 for (uint32_t group_index = 0; group_index < pCreateInfos[i].groupCount; ++group_index) {
4793 if ((pCreateInfos[i].pGroups[group_index].type == VK_RAY_TRACING_SHADER_GROUP_TYPE_TRIANGLES_HIT_GROUP_KHR) ||
4794 (pCreateInfos[i].pGroups[group_index].type == VK_RAY_TRACING_SHADER_GROUP_TYPE_PROCEDURAL_HIT_GROUP_KHR)) {
4795 if ((pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_ANY_HIT_SHADERS_BIT_KHR) &&
4796 (pCreateInfos[i].pGroups[group_index].anyHitShader == VK_SHADER_UNUSED_KHR)) {
4797 skip |= LogError(
4798 device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-03470",
4799 "If flags includes VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_ANY_HIT_SHADERS_BIT_KHR,"
4800 "for any element of pGroups with a type of VK_RAY_TRACING_SHADER_GROUP_TYPE_TRIANGLES_HIT_GROUP_KHR"
4801 "or VK_RAY_TRACING_SHADER_GROUP_TYPE_PROCEDURAL_HIT_GROUP_KHR, the anyHitShader of that element "
4802 "must not be VK_SHADER_UNUSED_KHR");
4803 }
4804 if ((pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_CLOSEST_HIT_SHADERS_BIT_KHR) &&
4805 (pCreateInfos[i].pGroups[group_index].closestHitShader == VK_SHADER_UNUSED_KHR)) {
4806 skip |= LogError(
4807 device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-03471",
4808 "If flags includes VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_CLOSEST_HIT_SHADERS_BIT_KHR,"
4809 "for any element of pGroups with a type of VK_RAY_TRACING_SHADER_GROUP_TYPE_TRIANGLES_HIT_GROUP_KHR"
4810 "or VK_RAY_TRACING_SHADER_GROUP_TYPE_PROCEDURAL_HIT_GROUP_KHR, the closestHitShader of that "
4811 "element must not be VK_SHADER_UNUSED_KHR");
4812 }
4813 }
4814 }
4815 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_DERIVATIVE_BIT) {
4816 if (pCreateInfos[i].basePipelineIndex != -1) {
4817 if (pCreateInfos[i].basePipelineHandle != VK_NULL_HANDLE) {
4818 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-03423",
4819 "vkCreateRayTracingPipelinesKHR parameter, pCreateInfos->basePipelineHandle, must be "
4820 "VK_NULL_HANDLE if pCreateInfos->flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT flag "
4821 "and pCreateInfos->basePipelineIndex is not -1.");
4822 }
sourav parmara24fb7b2020-05-26 10:50:04 -07004823 if (pCreateInfos[i].basePipelineIndex > (int32_t)i) {
4824 skip |=
4825 LogError(device, "VUID-vkCreateRayTracingPipelinesKHR-flags-03415",
4826 "vkCreateRayTracingPipelinesKHR: If the flags member of any element of pCreateInfos contains the"
4827 "VK_PIPELINE_CREATE_DERIVATIVE_BIT flag, and the basePipelineIndex member of that same element is"
4828 "not -1, basePipelineIndex must be less than the index into pCreateInfos that corresponds to that "
4829 "element.");
4830 }
sourav parmarf4a78252020-04-10 13:04:21 -07004831 }
4832 if (pCreateInfos[i].basePipelineHandle == VK_NULL_HANDLE) {
David Netod9d7b762020-07-27 15:37:58 -04004833 if (static_cast<uint32_t>(pCreateInfos[i].basePipelineIndex) >= createInfoCount) {
sourav parmarf4a78252020-04-10 13:04:21 -07004834 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-03422",
4835 "vkCreateRayTracingPipelinesKHR if flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT and"
4836 "basePipelineHandle is VK_NULL_HANDLE, basePipelineIndex (%d) must be a valid into the calling"
4837 "commands pCreateInfos parameter %d.",
4838 pCreateInfos[i].basePipelineIndex, createInfoCount);
4839 }
4840 } else {
4841 if (pCreateInfos[i].basePipelineIndex != -1) {
4842 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-03424",
4843 "vkCreateRayTracingPipelinesKHR if flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT and"
4844 "basePipelineHandle is not VK_NULL_HANDLE, basePipelineIndex must be -1.");
4845 }
4846 }
4847 }
4848 if (pCreateInfos[i].libraries.libraryCount == 0) {
4849 if (pCreateInfos[i].stageCount == 0) {
4850 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-libraries-02958",
4851 "If libraries.libraryCount is zero, then stageCount must not be zero .");
4852 }
4853 if (pCreateInfos[i].groupCount == 0) {
4854 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-libraries-02959",
4855 "If libraries.libraryCount is zero, then groupCount must not be zero .");
4856 }
4857 } else {
4858 if (pCreateInfos[i].pLibraryInterface == NULL) {
4859 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-libraryCount-03466",
4860 "If the libraryCount member of libraries is greater than 0, pLibraryInterface must not be NULL.");
4861 }
4862 }
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004863 }
4864
4865 return skip;
4866}
4867
Mike Schuchardt21638df2019-03-16 10:52:02 -07004868#ifdef VK_USE_PLATFORM_WIN32_KHR
4869bool StatelessValidation::PreCallValidateGetDeviceGroupSurfacePresentModes2EXT(VkDevice device,
4870 const VkPhysicalDeviceSurfaceInfo2KHR *pSurfaceInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004871 VkDeviceGroupPresentModeFlagsKHR *pModes) const {
Mike Schuchardt21638df2019-03-16 10:52:02 -07004872 bool skip = false;
4873 if (!device_extensions.vk_khr_swapchain)
4874 skip |= OutputExtensionError("vkGetDeviceGroupSurfacePresentModes2EXT", VK_KHR_SWAPCHAIN_EXTENSION_NAME);
4875 if (!device_extensions.vk_khr_get_surface_capabilities_2)
4876 skip |= OutputExtensionError("vkGetDeviceGroupSurfacePresentModes2EXT", VK_KHR_GET_SURFACE_CAPABILITIES_2_EXTENSION_NAME);
4877 if (!device_extensions.vk_khr_surface)
4878 skip |= OutputExtensionError("vkGetDeviceGroupSurfacePresentModes2EXT", VK_KHR_SURFACE_EXTENSION_NAME);
4879 if (!device_extensions.vk_khr_get_physical_device_properties_2)
4880 skip |=
4881 OutputExtensionError("vkGetDeviceGroupSurfacePresentModes2EXT", VK_KHR_GET_PHYSICAL_DEVICE_PROPERTIES_2_EXTENSION_NAME);
4882 if (!device_extensions.vk_ext_full_screen_exclusive)
4883 skip |= OutputExtensionError("vkGetDeviceGroupSurfacePresentModes2EXT", VK_EXT_FULL_SCREEN_EXCLUSIVE_EXTENSION_NAME);
4884 skip |= validate_struct_type(
4885 "vkGetDeviceGroupSurfacePresentModes2EXT", "pSurfaceInfo", "VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SURFACE_INFO_2_KHR",
4886 pSurfaceInfo, VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SURFACE_INFO_2_KHR, true,
4887 "VUID-vkGetDeviceGroupSurfacePresentModes2EXT-pSurfaceInfo-parameter", "VUID-VkPhysicalDeviceSurfaceInfo2KHR-sType-sType");
4888 if (pSurfaceInfo != NULL) {
4889 const VkStructureType allowed_structs_VkPhysicalDeviceSurfaceInfo2KHR[] = {
4890 VK_STRUCTURE_TYPE_SURFACE_FULL_SCREEN_EXCLUSIVE_INFO_EXT,
4891 VK_STRUCTURE_TYPE_SURFACE_FULL_SCREEN_EXCLUSIVE_WIN32_INFO_EXT};
4892
4893 skip |= validate_struct_pnext("vkGetDeviceGroupSurfacePresentModes2EXT", "pSurfaceInfo->pNext",
4894 "VkSurfaceFullScreenExclusiveInfoEXT, VkSurfaceFullScreenExclusiveWin32InfoEXT",
4895 pSurfaceInfo->pNext, ARRAY_SIZE(allowed_structs_VkPhysicalDeviceSurfaceInfo2KHR),
4896 allowed_structs_VkPhysicalDeviceSurfaceInfo2KHR, GeneratedVulkanHeaderVersion,
sfricke-samsung32a27362020-02-28 09:06:42 -08004897 "VUID-VkPhysicalDeviceSurfaceInfo2KHR-pNext-pNext",
4898 "VUID-VkPhysicalDeviceSurfaceInfo2KHR-sType-unique");
Mike Schuchardt21638df2019-03-16 10:52:02 -07004899
4900 skip |= validate_required_handle("vkGetDeviceGroupSurfacePresentModes2EXT", "pSurfaceInfo->surface", pSurfaceInfo->surface);
4901 }
4902 return skip;
4903}
4904#endif
Tobias Hectorebb855f2019-07-23 12:17:33 +01004905
4906bool StatelessValidation::manual_PreCallValidateCreateFramebuffer(VkDevice device, const VkFramebufferCreateInfo *pCreateInfo,
4907 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004908 VkFramebuffer *pFramebuffer) const {
Tobias Hectorebb855f2019-07-23 12:17:33 +01004909 // Validation for pAttachments which is excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
4910 bool skip = false;
4911 if ((pCreateInfo->flags & VK_FRAMEBUFFER_CREATE_IMAGELESS_BIT_KHR) == 0) {
4912 skip |= validate_array("vkCreateFramebuffer", "attachmentCount", "pAttachments", pCreateInfo->attachmentCount,
4913 &pCreateInfo->pAttachments, false, true, kVUIDUndefined, kVUIDUndefined);
4914 }
4915 return skip;
4916}
Jeff Bolz8125a8b2019-08-16 16:29:45 -05004917
4918bool StatelessValidation::manual_PreCallValidateCmdSetLineStippleEXT(VkCommandBuffer commandBuffer, uint32_t lineStippleFactor,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004919 uint16_t lineStipplePattern) const {
Jeff Bolz8125a8b2019-08-16 16:29:45 -05004920 bool skip = false;
4921
4922 if (lineStippleFactor < 1 || lineStippleFactor > 256) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004923 skip |= LogError(commandBuffer, "VUID-vkCmdSetLineStippleEXT-lineStippleFactor-02776",
4924 "vkCmdSetLineStippleEXT::lineStippleFactor=%d is not in [1,256].", lineStippleFactor);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05004925 }
4926
4927 return skip;
4928}
Piers Daniell8fd03f52019-08-21 12:07:53 -06004929
4930bool StatelessValidation::manual_PreCallValidateCmdBindIndexBuffer(VkCommandBuffer commandBuffer, VkBuffer buffer,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004931 VkDeviceSize offset, VkIndexType indexType) const {
Piers Daniell8fd03f52019-08-21 12:07:53 -06004932 bool skip = false;
4933
4934 if (indexType == VK_INDEX_TYPE_NONE_NV) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004935 skip |= LogError(commandBuffer, "VUID-vkCmdBindIndexBuffer-indexType-02507",
4936 "vkCmdBindIndexBuffer() indexType must not be VK_INDEX_TYPE_NONE_NV.");
Piers Daniell8fd03f52019-08-21 12:07:53 -06004937 }
4938
Tony-LunarG6c3c5452019-12-13 10:37:38 -07004939 const auto *index_type_uint8_features = lvl_find_in_chain<VkPhysicalDeviceIndexTypeUint8FeaturesEXT>(device_createinfo_pnext);
Mark Lobodzinski804fde82020-05-08 07:49:25 -06004940 if (indexType == VK_INDEX_TYPE_UINT8_EXT && (!index_type_uint8_features || !index_type_uint8_features->indexTypeUint8)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004941 skip |= LogError(commandBuffer, "VUID-vkCmdBindIndexBuffer-indexType-02765",
4942 "vkCmdBindIndexBuffer() indexType is VK_INDEX_TYPE_UINT8_EXT but indexTypeUint8 feature is not enabled.");
Piers Daniell8fd03f52019-08-21 12:07:53 -06004943 }
4944
4945 return skip;
4946}
Mark Lobodzinski84988402019-09-11 15:27:30 -06004947
sfricke-samsung4ada8d42020-02-09 17:43:11 -08004948bool StatelessValidation::manual_PreCallValidateCmdBindVertexBuffers(VkCommandBuffer commandBuffer, uint32_t firstBinding,
4949 uint32_t bindingCount, const VkBuffer *pBuffers,
4950 const VkDeviceSize *pOffsets) const {
4951 bool skip = false;
4952 if (firstBinding > device_limits.maxVertexInputBindings) {
4953 skip |= LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers-firstBinding-00624",
4954 "vkCmdBindVertexBuffers() firstBinding (%u) must be less than maxVertexInputBindings (%u)", firstBinding,
4955 device_limits.maxVertexInputBindings);
4956 } else if ((firstBinding + bindingCount) > device_limits.maxVertexInputBindings) {
4957 skip |= LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers-firstBinding-00625",
4958 "vkCmdBindVertexBuffers() sum of firstBinding (%u) and bindingCount (%u) must be less than "
4959 "maxVertexInputBindings (%u)",
4960 firstBinding, bindingCount, device_limits.maxVertexInputBindings);
4961 }
4962
Jeff Bolz165818a2020-05-08 11:19:03 -05004963 for (uint32_t i = 0; i < bindingCount; ++i) {
4964 if (pBuffers[i] == VK_NULL_HANDLE) {
4965 const auto *robustness2_features = lvl_find_in_chain<VkPhysicalDeviceRobustness2FeaturesEXT>(device_createinfo_pnext);
4966 if (!(robustness2_features && robustness2_features->nullDescriptor)) {
4967 skip |= LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers-pBuffers-04001",
4968 "vkCmdBindVertexBuffers() required parameter pBuffers[%d] specified as VK_NULL_HANDLE", i);
4969 } else {
4970 if (pOffsets[i] != 0) {
4971 skip |= LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers-pBuffers-04002",
4972 "vkCmdBindVertexBuffers() pBuffers[%d] is VK_NULL_HANDLE, but pOffsets[%d] is not 0", i, i);
4973 }
4974 }
4975 }
4976 }
4977
sfricke-samsung4ada8d42020-02-09 17:43:11 -08004978 return skip;
4979}
4980
Mark Lobodzinski84988402019-09-11 15:27:30 -06004981bool StatelessValidation::manual_PreCallValidateSetDebugUtilsObjectNameEXT(VkDevice device,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004982 const VkDebugUtilsObjectNameInfoEXT *pNameInfo) const {
Mark Lobodzinski84988402019-09-11 15:27:30 -06004983 bool skip = false;
4984 if (pNameInfo->objectType == VK_OBJECT_TYPE_UNKNOWN) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004985 skip |= LogError(device, "VUID-VkDebugUtilsObjectNameInfoEXT-objectType-02589",
4986 "vkSetDebugUtilsObjectNameEXT() pNameInfo->objectType cannot be VK_OBJECT_TYPE_UNKNOWN.");
Mark Lobodzinski84988402019-09-11 15:27:30 -06004987 }
4988 return skip;
4989}
4990
4991bool StatelessValidation::manual_PreCallValidateSetDebugUtilsObjectTagEXT(VkDevice device,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004992 const VkDebugUtilsObjectTagInfoEXT *pTagInfo) const {
Mark Lobodzinski84988402019-09-11 15:27:30 -06004993 bool skip = false;
4994 if (pTagInfo->objectType == VK_OBJECT_TYPE_UNKNOWN) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004995 skip |= LogError(device, "VUID-VkDebugUtilsObjectTagInfoEXT-objectType-01908",
4996 "vkSetDebugUtilsObjectTagEXT() pTagInfo->objectType cannot be VK_OBJECT_TYPE_UNKNOWN.");
Mark Lobodzinski84988402019-09-11 15:27:30 -06004997 }
4998 return skip;
4999}
Petr Kraus3d720392019-11-13 02:52:39 +01005000
5001bool StatelessValidation::manual_PreCallValidateAcquireNextImageKHR(VkDevice device, VkSwapchainKHR swapchain, uint64_t timeout,
5002 VkSemaphore semaphore, VkFence fence,
5003 uint32_t *pImageIndex) const {
5004 bool skip = false;
5005
5006 if (semaphore == VK_NULL_HANDLE && fence == VK_NULL_HANDLE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005007 skip |= LogError(swapchain, "VUID-vkAcquireNextImageKHR-semaphore-01780",
5008 "vkAcquireNextImageKHR: semaphore and fence are both VK_NULL_HANDLE.");
Petr Kraus3d720392019-11-13 02:52:39 +01005009 }
5010
5011 return skip;
5012}
5013
5014bool StatelessValidation::manual_PreCallValidateAcquireNextImage2KHR(VkDevice device, const VkAcquireNextImageInfoKHR *pAcquireInfo,
5015 uint32_t *pImageIndex) const {
5016 bool skip = false;
5017
5018 if (pAcquireInfo->semaphore == VK_NULL_HANDLE && pAcquireInfo->fence == VK_NULL_HANDLE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005019 skip |= LogError(pAcquireInfo->swapchain, "VUID-VkAcquireNextImageInfoKHR-semaphore-01782",
5020 "vkAcquireNextImage2KHR: pAcquireInfo->semaphore and pAcquireInfo->fence are both VK_NULL_HANDLE.");
Petr Kraus3d720392019-11-13 02:52:39 +01005021 }
5022
5023 return skip;
5024}
Mark Lobodzinski953b7bc2019-12-19 13:50:10 -07005025
Jeremy Hayes9bda85a2020-05-21 16:36:17 -06005026bool StatelessValidation::manual_PreCallValidateCmdBindTransformFeedbackBuffersEXT(VkCommandBuffer commandBuffer,
5027 uint32_t firstBinding, uint32_t bindingCount,
5028 const VkBuffer *pBuffers,
5029 const VkDeviceSize *pOffsets,
5030 const VkDeviceSize *pSizes) const {
5031 bool skip = false;
5032
5033 char const *const cmd_name = "CmdBindTransformFeedbackBuffersEXT";
5034 for (uint32_t i = 0; i < bindingCount; ++i) {
5035 if (pOffsets[i] & 3) {
5036 skip |= LogError(commandBuffer, "VUID-vkCmdBindTransformFeedbackBuffersEXT-pOffsets-02359",
5037 "%s: pOffsets[%" PRIu32 "](0x%" PRIxLEAST64 ") is not a multiple of 4.", cmd_name, i, pOffsets[i]);
5038 }
5039 }
5040
5041 if (firstBinding >= phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers) {
5042 skip |= LogError(commandBuffer, "VUID-vkCmdBindTransformFeedbackBuffersEXT-firstBinding-02356",
5043 "%s: The firstBinding(%" PRIu32
5044 ") index is greater than or equal to "
5045 "VkPhysicalDeviceTransformFeedbackPropertiesEXT::maxTransformFeedbackBuffers(%" PRIu32 ").",
5046 cmd_name, firstBinding, phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers);
5047 }
5048
5049 if (firstBinding + bindingCount > phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers) {
5050 skip |=
5051 LogError(commandBuffer, "VUID-vkCmdBindTransformFeedbackBuffersEXT-firstBinding-02357",
5052 "%s: The sum of firstBinding(%" PRIu32 ") and bindCount(%" PRIu32
5053 ") is greater than VkPhysicalDeviceTransformFeedbackPropertiesEXT::maxTransformFeedbackBuffers(%" PRIu32 ").",
5054 cmd_name, firstBinding, bindingCount, phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers);
5055 }
5056
5057 for (uint32_t i = 0; i < bindingCount; ++i) {
5058 // pSizes is optional and may be nullptr.
5059 if (pSizes != nullptr) {
5060 if (pSizes[i] != VK_WHOLE_SIZE &&
5061 pSizes[i] > phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBufferSize) {
5062 skip |= LogError(commandBuffer, "VUID-vkCmdBindTransformFeedbackBuffersEXT-pSize-02361",
5063 "%s: pSizes[%" PRIu32 "] (0x%" PRIxLEAST64
5064 ") is not VK_WHOLE_SIZE and is greater than "
5065 "VkPhysicalDeviceTransformFeedbackPropertiesEXT::maxTransformFeedbackBufferSize.",
5066 cmd_name, i, pSizes[i]);
5067 }
5068 }
5069 }
5070
5071 return skip;
5072}
5073
5074bool StatelessValidation::manual_PreCallValidateCmdBeginTransformFeedbackEXT(VkCommandBuffer commandBuffer,
5075 uint32_t firstCounterBuffer,
5076 uint32_t counterBufferCount,
5077 const VkBuffer *pCounterBuffers,
5078 const VkDeviceSize *pCounterBufferOffsets) const {
5079 bool skip = false;
5080
5081 char const *const cmd_name = "CmdBeginTransformFeedbackEXT";
5082 if (firstCounterBuffer >= phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers) {
5083 skip |= LogError(commandBuffer, "VUID-vkCmdBeginTransformFeedbackEXT-firstCounterBuffer-02368",
5084 "%s: The firstCounterBuffer(%" PRIu32
5085 ") index is greater than or equal to "
5086 "VkPhysicalDeviceTransformFeedbackPropertiesEXT::maxTransformFeedbackBuffers(%" PRIu32 ").",
5087 cmd_name, firstCounterBuffer, phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers);
5088 }
5089
5090 if (firstCounterBuffer + counterBufferCount > phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers) {
5091 skip |=
5092 LogError(commandBuffer, "VUID-vkCmdBeginTransformFeedbackEXT-firstCounterBuffer-02369",
5093 "%s: The sum of firstCounterBuffer(%" PRIu32 ") and counterBufferCount(%" PRIu32
5094 ") is greater than VkPhysicalDeviceTransformFeedbackPropertiesEXT::maxTransformFeedbackBuffers(%" PRIu32 ").",
5095 cmd_name, firstCounterBuffer, counterBufferCount,
5096 phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers);
5097 }
5098
5099 return skip;
5100}
5101
5102bool StatelessValidation::manual_PreCallValidateCmdEndTransformFeedbackEXT(VkCommandBuffer commandBuffer,
5103 uint32_t firstCounterBuffer, uint32_t counterBufferCount,
5104 const VkBuffer *pCounterBuffers,
5105 const VkDeviceSize *pCounterBufferOffsets) const {
5106 bool skip = false;
5107
5108 char const *const cmd_name = "CmdEndTransformFeedbackEXT";
5109 if (firstCounterBuffer >= phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers) {
5110 skip |= LogError(commandBuffer, "VUID-vkCmdEndTransformFeedbackEXT-firstCounterBuffer-02376",
5111 "%s: The firstCounterBuffer(%" PRIu32
5112 ") index is greater than or equal to "
5113 "VkPhysicalDeviceTransformFeedbackPropertiesEXT::maxTransformFeedbackBuffers(%" PRIu32 ").",
5114 cmd_name, firstCounterBuffer, phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers);
5115 }
5116
5117 if (firstCounterBuffer + counterBufferCount > phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers) {
5118 skip |=
5119 LogError(commandBuffer, "VUID-vkCmdEndTransformFeedbackEXT-firstCounterBuffer-02377",
5120 "%s: The sum of firstCounterBuffer(%" PRIu32 ") and counterBufferCount(%" PRIu32
5121 ") is greater than VkPhysicalDeviceTransformFeedbackPropertiesEXT::maxTransformFeedbackBuffers(%" PRIu32 ").",
5122 cmd_name, firstCounterBuffer, counterBufferCount,
5123 phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers);
5124 }
5125
5126 return skip;
5127}
5128
Mark Lobodzinski953b7bc2019-12-19 13:50:10 -07005129bool StatelessValidation::manual_PreCallValidateCmdDrawIndirectByteCountEXT(VkCommandBuffer commandBuffer, uint32_t instanceCount,
5130 uint32_t firstInstance, VkBuffer counterBuffer,
5131 VkDeviceSize counterBufferOffset,
5132 uint32_t counterOffset, uint32_t vertexStride) const {
5133 bool skip = false;
5134
5135 if ((vertexStride <= 0) || (vertexStride > phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBufferDataStride)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005136 skip |= LogError(
5137 counterBuffer, "VUID-vkCmdDrawIndirectByteCountEXT-vertexStride-02289",
Mark Lobodzinski953b7bc2019-12-19 13:50:10 -07005138 "vkCmdDrawIndirectByteCountEXT: vertexStride (%d) must be between 0 and maxTransformFeedbackBufferDataStride (%d).",
5139 vertexStride, phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBufferDataStride);
5140 }
5141
5142 return skip;
5143}
sfricke-samsung11ea8ed2020-01-07 22:24:56 -08005144
5145bool StatelessValidation::ValidateCreateSamplerYcbcrConversion(VkDevice device,
5146 const VkSamplerYcbcrConversionCreateInfo *pCreateInfo,
5147 const VkAllocationCallbacks *pAllocator,
5148 VkSamplerYcbcrConversion *pYcbcrConversion,
5149 const char *apiName) const {
5150 bool skip = false;
5151
5152 // Check samplerYcbcrConversion feature is set
Tony-LunarG6c3c5452019-12-13 10:37:38 -07005153 const auto *ycbcr_features = lvl_find_in_chain<VkPhysicalDeviceSamplerYcbcrConversionFeatures>(device_createinfo_pnext);
sfricke-samsung11ea8ed2020-01-07 22:24:56 -08005154 if ((ycbcr_features == nullptr) || (ycbcr_features->samplerYcbcrConversion == VK_FALSE)) {
Ricardo Garcia3a34ffb2020-06-24 09:36:18 +02005155 const auto *vulkan_11_features = lvl_find_in_chain<VkPhysicalDeviceVulkan11Features>(device_createinfo_pnext);
5156 if ((vulkan_11_features == nullptr) || (vulkan_11_features->samplerYcbcrConversion == VK_FALSE)) {
5157 skip |= LogError(device, "VUID-vkCreateSamplerYcbcrConversion-None-01648",
sfricke-samsung83d98122020-07-04 06:21:15 -07005158 "%s: samplerYcbcrConversion must be enabled.", apiName);
Ricardo Garcia3a34ffb2020-06-24 09:36:18 +02005159 }
sfricke-samsung11ea8ed2020-01-07 22:24:56 -08005160 }
sfricke-samsung83d98122020-07-04 06:21:15 -07005161
sfricke-samsung1a72f942020-07-25 12:09:18 -07005162 const VkFormat format = pCreateInfo->format;
sfricke-samsung83d98122020-07-04 06:21:15 -07005163 const VkComponentMapping components = pCreateInfo->components;
5164 // XChroma Subsampled is same as "the format has a _422 or _420 suffix" from spec
sfricke-samsung1a72f942020-07-25 12:09:18 -07005165 if (FormatIsXChromaSubsampled(format) == true) {
sfricke-samsung83d98122020-07-04 06:21:15 -07005166 if ((components.g != VK_COMPONENT_SWIZZLE_G) && (components.g != VK_COMPONENT_SWIZZLE_IDENTITY)) {
5167 skip |= LogError(device, "VUID-VkSamplerYcbcrConversionCreateInfo-components-02581",
5168 "%s: When using a XChroma subsampled format (%s) the components.g needs to be VK_COMPONENT_SWIZZLE_G "
5169 "or VK_COMPONENT_SWIZZLE_IDENTITY, but is %s.",
sfricke-samsung1a72f942020-07-25 12:09:18 -07005170 apiName, string_VkFormat(format), string_VkComponentSwizzle(components.g));
sfricke-samsung83d98122020-07-04 06:21:15 -07005171 }
5172
5173 if ((components.a != VK_COMPONENT_SWIZZLE_A) && (components.a != VK_COMPONENT_SWIZZLE_IDENTITY) &&
5174 (components.a != VK_COMPONENT_SWIZZLE_ONE) && (components.a != VK_COMPONENT_SWIZZLE_ZERO)) {
5175 skip |=
5176 LogError(device, "VUID-VkSamplerYcbcrConversionCreateInfo-components-02582",
5177 "%s: When using a XChroma subsampled format (%s) the components.a needs to be VK_COMPONENT_SWIZZLE_A or "
5178 "VK_COMPONENT_SWIZZLE_IDENTITY or VK_COMPONENT_SWIZZLE_ONE or VK_COMPONENT_SWIZZLE_ZERO, but is %s.",
sfricke-samsung1a72f942020-07-25 12:09:18 -07005179 apiName, string_VkFormat(format), string_VkComponentSwizzle(components.a));
sfricke-samsung83d98122020-07-04 06:21:15 -07005180 }
5181
5182 if ((components.r != VK_COMPONENT_SWIZZLE_R) && (components.r != VK_COMPONENT_SWIZZLE_IDENTITY) &&
5183 (components.r != VK_COMPONENT_SWIZZLE_B)) {
5184 skip |= LogError(device, "VUID-VkSamplerYcbcrConversionCreateInfo-components-02583",
5185 "%s: When using a XChroma subsampled format (%s) the components.r needs to be VK_COMPONENT_SWIZZLE_R "
5186 "or VK_COMPONENT_SWIZZLE_IDENTITY or VK_COMPONENT_SWIZZLE_B, but is %s.",
sfricke-samsung1a72f942020-07-25 12:09:18 -07005187 apiName, string_VkFormat(format), string_VkComponentSwizzle(components.r));
sfricke-samsung83d98122020-07-04 06:21:15 -07005188 }
5189
5190 if ((components.b != VK_COMPONENT_SWIZZLE_B) && (components.b != VK_COMPONENT_SWIZZLE_IDENTITY) &&
5191 (components.b != VK_COMPONENT_SWIZZLE_R)) {
5192 skip |= LogError(device, "VUID-VkSamplerYcbcrConversionCreateInfo-components-02584",
5193 "%s: When using a XChroma subsampled format (%s) the components.b needs to be VK_COMPONENT_SWIZZLE_B "
5194 "or VK_COMPONENT_SWIZZLE_IDENTITY or VK_COMPONENT_SWIZZLE_R, but is %s.",
sfricke-samsung1a72f942020-07-25 12:09:18 -07005195 apiName, string_VkFormat(format), string_VkComponentSwizzle(components.b));
sfricke-samsung83d98122020-07-04 06:21:15 -07005196 }
5197
5198 // If one is identity, both need to be
5199 const bool rIdentity = ((components.r == VK_COMPONENT_SWIZZLE_R) || (components.r == VK_COMPONENT_SWIZZLE_IDENTITY));
5200 const bool bIdentity = ((components.b == VK_COMPONENT_SWIZZLE_B) || (components.b == VK_COMPONENT_SWIZZLE_IDENTITY));
5201 if ((rIdentity != bIdentity) && ((rIdentity == true) || (bIdentity == true))) {
5202 skip |= LogError(device, "VUID-VkSamplerYcbcrConversionCreateInfo-components-02585",
5203 "%s: When using a XChroma subsampled format (%s) if either the components.r (%s) or components.b (%s) "
5204 "are an identity swizzle, then both need to be an identity swizzle.",
sfricke-samsung1a72f942020-07-25 12:09:18 -07005205 apiName, string_VkFormat(format), string_VkComponentSwizzle(components.r),
5206 string_VkComponentSwizzle(components.b));
5207 }
5208 }
5209
5210 if (pCreateInfo->ycbcrModel != VK_SAMPLER_YCBCR_MODEL_CONVERSION_RGB_IDENTITY) {
5211 // Checks same VU multiple ways in order to give a more useful error message
5212 const char *vuid = "VUID-VkSamplerYcbcrConversionCreateInfo-ycbcrModel-01655";
5213 if ((components.r == VK_COMPONENT_SWIZZLE_ONE) || (components.r == VK_COMPONENT_SWIZZLE_ZERO) ||
5214 (components.g == VK_COMPONENT_SWIZZLE_ONE) || (components.g == VK_COMPONENT_SWIZZLE_ZERO) ||
5215 (components.b == VK_COMPONENT_SWIZZLE_ONE) || (components.b == VK_COMPONENT_SWIZZLE_ZERO)) {
5216 skip |=
5217 LogError(device, vuid,
5218 "%s: The ycbcrModel is not VK_SAMPLER_YCBCR_MODEL_CONVERSION_RGB_IDENTITY so components.r (%s), "
5219 "components.g (%s), nor components.b (%s) can't be VK_COMPONENT_SWIZZLE_ZERO or VK_COMPONENT_SWIZZLE_ONE.",
5220 apiName, string_VkComponentSwizzle(components.r), string_VkComponentSwizzle(components.g),
5221 string_VkComponentSwizzle(components.b));
5222 }
5223
5224 // "must not correspond to a channel which contains zero or one as a consequence of conversion to RGBA"
5225 // 4 channel format = no issue
5226 // 3 = no [a]
5227 // 2 = no [b,a]
5228 // 1 = no [g,b,a]
5229 // depth/stencil = no [g,b,a] (shouldn't ever occur, but no VU preventing it)
5230 const uint32_t channels = (FormatIsDepthOrStencil(format) == true) ? 1 : FormatChannelCount(format);
5231
5232 if ((channels < 4) && ((components.r == VK_COMPONENT_SWIZZLE_A) || (components.g == VK_COMPONENT_SWIZZLE_A) ||
5233 (components.b == VK_COMPONENT_SWIZZLE_A))) {
5234 skip |= LogError(device, vuid,
5235 "%s: The ycbcrModel is not VK_SAMPLER_YCBCR_MODEL_CONVERSION_RGB_IDENTITY so components.r (%s), "
5236 "components.g (%s), or components.b (%s) can't be VK_COMPONENT_SWIZZLE_A.",
5237 apiName, string_VkComponentSwizzle(components.r), string_VkComponentSwizzle(components.g),
5238 string_VkComponentSwizzle(components.b));
5239 } else if ((channels < 3) &&
5240 ((components.r == VK_COMPONENT_SWIZZLE_B) || (components.g == VK_COMPONENT_SWIZZLE_B) ||
5241 (components.b == VK_COMPONENT_SWIZZLE_B) || (components.b == VK_COMPONENT_SWIZZLE_IDENTITY))) {
5242 skip |= LogError(device, vuid,
5243 "%s: The ycbcrModel is not VK_SAMPLER_YCBCR_MODEL_CONVERSION_RGB_IDENTITY so components.r (%s), "
5244 "components.g (%s), or components.b (%s) can't be VK_COMPONENT_SWIZZLE_B "
5245 "(components.b also can't be VK_COMPONENT_SWIZZLE_IDENTITY).",
5246 apiName, string_VkComponentSwizzle(components.r), string_VkComponentSwizzle(components.g),
5247 string_VkComponentSwizzle(components.b));
5248 } else if ((channels < 2) &&
5249 ((components.r == VK_COMPONENT_SWIZZLE_G) || (components.g == VK_COMPONENT_SWIZZLE_G) ||
5250 (components.g == VK_COMPONENT_SWIZZLE_IDENTITY) || (components.b == VK_COMPONENT_SWIZZLE_G))) {
5251 skip |= LogError(device, vuid,
5252 "%s: The ycbcrModel is not VK_SAMPLER_YCBCR_MODEL_CONVERSION_RGB_IDENTITY so components.r (%s), "
5253 "components.g (%s), or components.b (%s) can't be VK_COMPONENT_SWIZZLE_G "
5254 "(components.g also can't be VK_COMPONENT_SWIZZLE_IDENTITY).",
5255 apiName, string_VkComponentSwizzle(components.r), string_VkComponentSwizzle(components.g),
sfricke-samsung83d98122020-07-04 06:21:15 -07005256 string_VkComponentSwizzle(components.b));
5257 }
5258 }
5259
sfricke-samsung11ea8ed2020-01-07 22:24:56 -08005260 return skip;
5261}
5262
5263bool StatelessValidation::manual_PreCallValidateCreateSamplerYcbcrConversion(VkDevice device,
5264 const VkSamplerYcbcrConversionCreateInfo *pCreateInfo,
5265 const VkAllocationCallbacks *pAllocator,
5266 VkSamplerYcbcrConversion *pYcbcrConversion) const {
5267 return ValidateCreateSamplerYcbcrConversion(device, pCreateInfo, pAllocator, pYcbcrConversion,
5268 "vkCreateSamplerYcbcrConversion");
5269}
5270
5271bool StatelessValidation::manual_PreCallValidateCreateSamplerYcbcrConversionKHR(
5272 VkDevice device, const VkSamplerYcbcrConversionCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
5273 VkSamplerYcbcrConversion *pYcbcrConversion) const {
5274 return ValidateCreateSamplerYcbcrConversion(device, pCreateInfo, pAllocator, pYcbcrConversion,
5275 "vkCreateSamplerYcbcrConversionKHR");
5276}
sfricke-samsung1708a8c2020-02-10 00:35:06 -08005277
5278bool StatelessValidation::manual_PreCallValidateImportSemaphoreFdKHR(
5279 VkDevice device, const VkImportSemaphoreFdInfoKHR *pImportSemaphoreFdInfo) const {
5280 bool skip = false;
5281 VkExternalSemaphoreHandleTypeFlags supported_handle_types =
5282 VK_EXTERNAL_SEMAPHORE_HANDLE_TYPE_OPAQUE_FD_BIT | VK_EXTERNAL_SEMAPHORE_HANDLE_TYPE_SYNC_FD_BIT;
5283
5284 if (0 == (pImportSemaphoreFdInfo->handleType & supported_handle_types)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005285 skip |= LogError(device, "VUID-VkImportSemaphoreFdInfoKHR-handleType-01143",
5286 "vkImportSemaphoreFdKHR() to semaphore %s handleType %s is not one of the supported handleTypes (%s).",
5287 report_data->FormatHandle(pImportSemaphoreFdInfo->semaphore).c_str(),
5288 string_VkExternalSemaphoreHandleTypeFlagBits(pImportSemaphoreFdInfo->handleType),
5289 string_VkExternalSemaphoreHandleTypeFlags(supported_handle_types).c_str());
sfricke-samsung1708a8c2020-02-10 00:35:06 -08005290 }
5291 return skip;
5292}
sourav parmara96ab1a2020-04-25 16:28:23 -07005293
5294bool StatelessValidation::manual_PreCallValidateCopyAccelerationStructureToMemoryKHR(
5295 VkDevice device, const VkCopyAccelerationStructureToMemoryInfoKHR *pInfo) const {
5296 bool skip = false;
sourav parmar83c31b12020-05-06 12:30:54 -07005297 const auto *raytracing_features = lvl_find_in_chain<VkPhysicalDeviceRayTracingFeaturesKHR>(device_createinfo_pnext);
5298 if (!raytracing_features || raytracing_features->rayTracingHostAccelerationStructureCommands == VK_FALSE) {
5299 skip |=
5300 LogError(device, "", "VUID-vkCopyAccelerationStructureToMemoryKHR-rayTracingHostAccelerationStructureCommands-03447",
5301 "vkCopyAccelerationStructureToMemoryKHR: the "
5302 "VkPhysicalDeviceRayTracingFeaturesKHR::rayTracingHostAccelerationStructureCommands feature must be enabled.");
5303 }
sourav parmara96ab1a2020-04-25 16:28:23 -07005304 if (pInfo->mode != VK_COPY_ACCELERATION_STRUCTURE_MODE_SERIALIZE_KHR) {
5305 skip |= LogError(device, "VUID-VkCopyAccelerationStructureToMemoryInfoKHR-mode-03412",
5306 "vkCopyAccelerationStructureToMemoryKHR: mode must be VK_COPY_ACCELERATION_STRUCTURE_MODE_SERIALIZE_KHR.");
5307 }
5308 return skip;
5309}
5310
5311bool StatelessValidation::manual_PreCallValidateCmdCopyAccelerationStructureToMemoryKHR(
5312 VkCommandBuffer commandBuffer, const VkCopyAccelerationStructureToMemoryInfoKHR *pInfo) const {
5313 bool skip = false;
5314 if (pInfo->mode != VK_COPY_ACCELERATION_STRUCTURE_MODE_SERIALIZE_KHR) {
5315 skip |= // to update VUID to VkCmdCopyAccelerationStructureToMemoryInfoKHR after spec update
5316 LogError(commandBuffer, "VUID-VkCopyAccelerationStructureToMemoryInfoKHR-mode-03412",
5317 "vkCmdCopyAccelerationStructureToMemoryKHR: mode must be VK_COPY_ACCELERATION_STRUCTURE_MODE_SERIALIZE_KHR.");
5318 }
Mark Lobodzinski17dc4602020-05-29 07:48:40 -06005319 const auto *pnext_struct = lvl_find_in_chain<VkDeferredOperationInfoKHR>(pInfo->pNext);
5320 if (pnext_struct) {
sourav parmar83c31b12020-05-06 12:30:54 -07005321 skip |= LogError(
5322 commandBuffer, "VUID-vkCmdCopyAccelerationStructureToMemoryKHR-pNext-03560",
5323 "vkCmdCopyAccelerationStructureToMemoryKHR: The VkDeferredOperationInfoKHR structure must not be included in the"
5324 "pNext chain of the VkCopyAccelerationStructureToMemoryInfoKHR structure.");
5325 }
sourav parmara96ab1a2020-04-25 16:28:23 -07005326 return skip;
5327}
5328
5329bool StatelessValidation::ValidateCopyAccelerationStructureInfoKHR(const VkCopyAccelerationStructureInfoKHR *pInfo,
5330 const char *api_name) const {
5331 bool skip = false;
5332 if (!(pInfo->mode == VK_COPY_ACCELERATION_STRUCTURE_MODE_COMPACT_KHR ||
5333 pInfo->mode == VK_COPY_ACCELERATION_STRUCTURE_MODE_CLONE_KHR)) {
5334 skip |= LogError(device, "VUID-VkCopyAccelerationStructureInfoKHR-mode-03410",
5335 "(%s): mode must be VK_COPY_ACCELERATION_STRUCTURE_MODE_COMPACT_KHR"
5336 "or VK_COPY_ACCELERATION_STRUCTURE_MODE_CLONE_KHR.",
5337 api_name);
5338 }
5339 return skip;
5340}
5341
5342bool StatelessValidation::manual_PreCallValidateCopyAccelerationStructureKHR(
5343 VkDevice device, const VkCopyAccelerationStructureInfoKHR *pInfo) const {
5344 bool skip = false;
5345 skip |= ValidateCopyAccelerationStructureInfoKHR(pInfo, "vkCopyAccelerationStructureKHR()");
sourav parmar83c31b12020-05-06 12:30:54 -07005346 const auto *raytracing_features = lvl_find_in_chain<VkPhysicalDeviceRayTracingFeaturesKHR>(device_createinfo_pnext);
5347 if (!raytracing_features || raytracing_features->rayTracingHostAccelerationStructureCommands == VK_FALSE) {
5348 skip |= LogError(
5349 device, "VUID-vkCopyAccelerationStructureKHR-rayTracingHostAccelerationStructureCommands-03441",
5350 "vkCopyAccelerationStructureKHR(): the "
5351 "VkPhysicalDeviceRayTracingFeaturesKHR::rayTracingHostAccelerationStructureCommands feature must be enabled .");
5352 }
sourav parmara96ab1a2020-04-25 16:28:23 -07005353 return skip;
5354}
5355
5356bool StatelessValidation::manual_PreCallValidateCmdCopyAccelerationStructureKHR(
5357 VkCommandBuffer commandBuffer, const VkCopyAccelerationStructureInfoKHR *pInfo) const {
5358 bool skip = false;
Mark Lobodzinski17dc4602020-05-29 07:48:40 -06005359 const auto *pnext_struct = lvl_find_in_chain<VkDeferredOperationInfoKHR>(pInfo->pNext);
5360 if (pnext_struct) {
sourav parmar83c31b12020-05-06 12:30:54 -07005361 skip |= LogError(device, "VUID-vkCmdCopyAccelerationStructureKHR-pNext-03557",
5362 "vkCmdCopyAccelerationStructureKHR(): The VkDeferredOperationInfoKHR structure must not be included in "
5363 "the pNext chain of the VkCopyAccelerationStructureInfoKHR structure.");
5364 }
sourav parmara96ab1a2020-04-25 16:28:23 -07005365 skip |= ValidateCopyAccelerationStructureInfoKHR(pInfo, "vkCmdCopyAccelerationStructureKHR()");
5366 return skip;
5367}
5368
5369bool StatelessValidation::ValidateCopyMemoryToAccelerationStructureInfoKHR(const VkCopyMemoryToAccelerationStructureInfoKHR *pInfo,
Mark Lobodzinskiaad69e42020-05-12 08:44:21 -06005370 const char *api_name, bool is_cmd) const {
sourav parmara96ab1a2020-04-25 16:28:23 -07005371 bool skip = false;
5372 if (pInfo->mode != VK_COPY_ACCELERATION_STRUCTURE_MODE_DESERIALIZE_KHR) {
sourav parmar83c31b12020-05-06 12:30:54 -07005373 skip |= LogError(device,
Mark Lobodzinskiaad69e42020-05-12 08:44:21 -06005374 is_cmd ? "VUID-vkCmdCopyMemoryToAccelerationStructureKHR-mode-03413"
Shannon McPhersonafe55122020-05-25 16:20:19 -06005375 : "VUID-VkCopyMemoryToAccelerationStructureInfoKHR-mode-03413",
sourav parmara96ab1a2020-04-25 16:28:23 -07005376 "(%s): mode must be VK_COPY_ACCELERATION_STRUCTURE_MODE_DESERIALIZE_KHR.", api_name);
5377 }
5378 return skip;
5379}
5380
5381bool StatelessValidation::manual_PreCallValidateCopyMemoryToAccelerationStructureKHR(
5382 VkDevice device, const VkCopyMemoryToAccelerationStructureInfoKHR *pInfo) const {
5383 bool skip = false;
sourav parmar83c31b12020-05-06 12:30:54 -07005384 skip |= ValidateCopyMemoryToAccelerationStructureInfoKHR(pInfo, "vkCopyMemoryToAccelerationStructureKHR()", true);
5385 const auto *raytracing_features = lvl_find_in_chain<VkPhysicalDeviceRayTracingFeaturesKHR>(device_createinfo_pnext);
5386 if (!raytracing_features || raytracing_features->rayTracingHostAccelerationStructureCommands == VK_FALSE) {
5387 skip |=
5388 LogError(device, "VUID-vkCopyMemoryToAccelerationStructureKHR-rayTracingHostAccelerationStructureCommands-03444",
5389 "vkCopyMemoryToAccelerationStructureKHR() :the "
5390 "VkPhysicalDeviceRayTracingFeaturesKHR::rayTracingHostAccelerationStructureCommands feature must be enabled.");
5391 }
sourav parmara96ab1a2020-04-25 16:28:23 -07005392 return skip;
5393}
Jeremy Hayes9bda85a2020-05-21 16:36:17 -06005394
sourav parmara96ab1a2020-04-25 16:28:23 -07005395bool StatelessValidation::manual_PreCallValidateCmdCopyMemoryToAccelerationStructureKHR(
5396 VkCommandBuffer commandBuffer, const VkCopyMemoryToAccelerationStructureInfoKHR *pInfo) const {
5397 bool skip = false;
Mark Lobodzinski17dc4602020-05-29 07:48:40 -06005398 const auto *pnext_struct = lvl_find_in_chain<VkDeferredOperationInfoKHR>(pInfo->pNext);
5399 if (pnext_struct) {
sourav parmara24fb7b2020-05-26 10:50:04 -07005400 skip |= LogError(device, "VUID-vkCmdCopyMemoryToAccelerationStructureKHR-pNext-03564",
5401 "vkCmdCopyMemoryToAccelerationStructureKHR: The VkDeferredOperationInfoKHR structure must"
5402 "not be included in the pNext chain of the VkCopyMemoryToAccelerationStructureInfoKHR structure.");
5403 }
sourav parmar83c31b12020-05-06 12:30:54 -07005404 skip |= ValidateCopyMemoryToAccelerationStructureInfoKHR(pInfo, "vkCmdCopyMemoryToAccelerationStructureKHR()", false);
5405 return skip;
5406}
5407bool StatelessValidation::manual_PreCallValidateCmdWriteAccelerationStructuresPropertiesKHR(
5408 VkCommandBuffer commandBuffer, uint32_t accelerationStructureCount, const VkAccelerationStructureKHR *pAccelerationStructures,
5409 VkQueryType queryType, VkQueryPool queryPool, uint32_t firstQuery) const {
5410 bool skip = false;
5411 if (!(queryType == VK_QUERY_TYPE_ACCELERATION_STRUCTURE_COMPACTED_SIZE_KHR ||
5412 queryType == VK_QUERY_TYPE_ACCELERATION_STRUCTURE_SERIALIZATION_SIZE_KHR)) {
5413 skip |= LogError(device, "VUID-vkCmdWriteAccelerationStructuresPropertiesKHR-queryType-03432",
5414 "vkCmdWriteAccelerationStructuresPropertiesKHR: queryType must be "
5415 "VK_QUERY_TYPE_ACCELERATION_STRUCTURE_COMPACTED_SIZE_KHR or "
5416 "VK_QUERY_TYPE_ACCELERATION_STRUCTURE_SERIALIZATION_SIZE_KHR.");
5417 }
5418 return skip;
5419}
5420bool StatelessValidation::manual_PreCallValidateWriteAccelerationStructuresPropertiesKHR(
5421 VkDevice device, uint32_t accelerationStructureCount, const VkAccelerationStructureKHR *pAccelerationStructures,
5422 VkQueryType queryType, size_t dataSize, void *pData, size_t stride) const {
5423 bool skip = false;
5424 if (dataSize < accelerationStructureCount * stride) {
5425 skip |= LogError(device, "VUID-vkWriteAccelerationStructuresPropertiesKHR-dataSize-03452",
5426 "vkWriteAccelerationStructuresPropertiesKHR: dataSize (%zu) must be greater than or equal to "
5427 "accelerationStructureCount (%d) *stride(%zu).",
5428 dataSize, accelerationStructureCount, stride);
5429 }
5430 if (!(queryType == VK_QUERY_TYPE_ACCELERATION_STRUCTURE_COMPACTED_SIZE_KHR ||
5431 queryType == VK_QUERY_TYPE_ACCELERATION_STRUCTURE_SERIALIZATION_SIZE_KHR)) {
5432 skip |= LogError(device, "VUID-vkWriteAccelerationStructuresPropertiesKHR-queryType-03432",
5433 "vkWriteAccelerationStructuresPropertiesKHR: queryType must be "
5434 "VK_QUERY_TYPE_ACCELERATION_STRUCTURE_COMPACTED_SIZE_KHR or "
5435 "VK_QUERY_TYPE_ACCELERATION_STRUCTURE_SERIALIZATION_SIZE_KHR.");
5436 }
5437 if (queryType == VK_QUERY_TYPE_ACCELERATION_STRUCTURE_COMPACTED_SIZE_KHR) {
5438 if (SafeModulo(stride, sizeof(VkDeviceSize)) != 0) {
5439 skip |= LogError(device, "VUID-vkWriteAccelerationStructuresPropertiesKHR-queryType-03448",
5440 "vkWriteAccelerationStructuresPropertiesKHR: If queryType is "
5441 "VK_QUERY_TYPE_ACCELERATION_STRUCTURE_COMPACTED_SIZE_KHR,"
5442 "then stride (%zu) must be a multiple of the size of VkDeviceSize",
5443 stride);
5444 }
5445 }
5446 if (queryType == VK_QUERY_TYPE_ACCELERATION_STRUCTURE_SERIALIZATION_SIZE_KHR) {
5447 if (SafeModulo(stride, sizeof(VkDeviceSize)) != 0) {
5448 skip |= LogError(device, "VUID-vkWriteAccelerationStructuresPropertiesKHR-queryType-03450",
5449 "vkWriteAccelerationStructuresPropertiesKHR: If queryType is "
5450 "VK_QUERY_TYPE_ACCELERATION_STRUCTURE_SERIALIZATION_SIZE_KHR,"
5451 "then stride (%zu) must be a multiple of the size of VkDeviceSize",
5452 stride);
5453 }
5454 }
5455 const auto *raytracing_features = lvl_find_in_chain<VkPhysicalDeviceRayTracingFeaturesKHR>(device_createinfo_pnext);
5456 if (!raytracing_features || raytracing_features->rayTracingHostAccelerationStructureCommands == VK_FALSE) {
5457 skip |=
5458 LogError(device, "VUID-vkWriteAccelerationStructuresPropertiesKHR-rayTracingHostAccelerationStructureCommands-03454",
5459 "vkWriteAccelerationStructuresPropertiesKHR: the "
5460 "vkPhysicalDeviceRayTracingFeaturesKHR::rayTracingHostAccelerationStructureCommands"
5461 "feature must be enabled ");
5462 }
5463 return skip;
5464}
5465bool StatelessValidation::manual_PreCallValidateGetRayTracingCaptureReplayShaderGroupHandlesKHR(
5466 VkDevice device, VkPipeline pipeline, uint32_t firstGroup, uint32_t groupCount, size_t dataSize, void *pData) const {
5467 bool skip = false;
5468 const auto *raytracing_features = lvl_find_in_chain<VkPhysicalDeviceRayTracingFeaturesKHR>(device_createinfo_pnext);
5469 if (!raytracing_features || raytracing_features->rayTracingShaderGroupHandleCaptureReplay == VK_FALSE) {
5470 skip |= LogError(device,
5471 "VUID-vkGetRayTracingCaptureReplayShaderGroupHandlesKHR-rayTracingShaderGroupHandleCaptureReplay-03485",
5472 "vkGetRayTracingCaptureReplayShaderGroupHandlesKHR: "
5473 "VkPhysicalDeviceRayTracingFeaturesKHR::rayTracingShaderGroupHandleCaptureReplay"
5474 "must be enabled to call this function.");
5475 }
5476 return skip;
5477}
5478
5479bool StatelessValidation::manual_PreCallValidateCmdTraceRaysKHR(VkCommandBuffer commandBuffer,
5480 const VkStridedBufferRegionKHR *pRaygenShaderBindingTable,
5481 const VkStridedBufferRegionKHR *pMissShaderBindingTable,
5482 const VkStridedBufferRegionKHR *pHitShaderBindingTable,
5483 const VkStridedBufferRegionKHR *pCallableShaderBindingTable,
5484 uint32_t width, uint32_t height, uint32_t depth) const {
5485 bool skip = false;
5486 if (SafeModulo(pCallableShaderBindingTable->offset, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) != 0) {
5487 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-offset-04038",
5488 "vkCmdTraceRaysKHR: The offset member of pCallableShaderBindingTable"
5489 "must be a multiple of VkPhysicalDeviceRayTracingPropertiesKHR::shaderGroupBaseAlignment.");
5490 }
5491 if (SafeModulo(pCallableShaderBindingTable->stride, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupHandleSize) != 0) {
5492 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-stride-04040",
5493 "vkCmdTraceRaysKHR: The stride member of pCallableShaderBindingTable must be a multiple"
5494 "of VkPhysicalDeviceRayTracingPropertiesKHR::shaderGroupHandleSize.");
5495 }
5496 if (pCallableShaderBindingTable->stride > phys_dev_ext_props.ray_tracing_propsKHR.maxShaderGroupStride) {
5497 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-stride-04041",
5498 "vkCmdTraceRaysKHR: The stride member of pCallableShaderBindingTable must be"
5499 "less than or equal to VkPhysicalDeviceRayTracingPropertiesKHR::maxShaderGroupStride.");
5500 }
5501 // hitShader
5502 if (SafeModulo(pHitShaderBindingTable->offset, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) != 0) {
5503 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-offset-04032",
5504 "vkCmdTraceRaysKHR: The offset member of pHitShaderBindingTable must be a multiple"
5505 "of VkPhysicalDeviceRayTracingPropertiesKHR::shaderGroupBaseAlignment.");
5506 }
5507 if (SafeModulo(pHitShaderBindingTable->stride, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupHandleSize) != 0) {
5508 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-stride-04034",
5509 "vkCmdTraceRaysKHR: The stride member of pHitShaderBindingTable must be a multiple"
5510 "of VkPhysicalDeviceRayTracingPropertiesKHR::shaderGroupHandleSize.");
5511 }
5512 if (pHitShaderBindingTable->stride > phys_dev_ext_props.ray_tracing_propsKHR.maxShaderGroupStride) {
5513 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-stride-04035",
5514 "vkCmdTraceRaysKHR: The stride member of pHitShaderBindingTable must be"
5515 "less than or equal to VkPhysicalDeviceRayTracingPropertiesKHR::maxShaderGroupStride.");
5516 }
5517
5518 // missShader
5519 if (SafeModulo(pMissShaderBindingTable->offset, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) != 0) {
5520 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-offset-04026",
5521 "vkCmdTraceRaysKHR: The offset member of pMissShaderBindingTable must be a multiple"
5522 "of VkPhysicalDeviceRayTracingPropertiesKHR::shaderGroupBaseAlignment.");
5523 }
5524 if (SafeModulo(pMissShaderBindingTable->stride, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupHandleSize) != 0) {
5525 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-stride-04028",
5526 "vkCmdTraceRaysKHR: The stride member of pMissShaderBindingTable must be a multiple"
5527 "of VkPhysicalDeviceRayTracingPropertiesKHR::shaderGroupHandleSize.");
5528 }
5529 if (pMissShaderBindingTable->stride > phys_dev_ext_props.ray_tracing_propsKHR.maxShaderGroupStride) {
5530 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-stride-04029",
5531 "vkCmdTraceRaysKHR: The stride member of pMissShaderBindingTable must be"
5532 "less than or equal to VkPhysicalDeviceRayTracingPropertiesKHR::maxShaderGroupStride.");
5533 }
5534
5535 // raygenShader
5536 if (SafeModulo(pRaygenShaderBindingTable->offset, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) != 0) {
5537 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-pRayGenShaderBindingTable-04021",
5538 "vkCmdTraceRaysKHR: pRayGenShaderBindingTable->offset must be a multiple"
5539 "of VkPhysicalDeviceRayTracingPropertiesKHR::shaderGroupBaseAlignment.");
5540 }
5541 return skip;
5542}
5543
5544bool StatelessValidation::manual_PreCallValidateCmdTraceRaysIndirectKHR(VkCommandBuffer commandBuffer,
5545 const VkStridedBufferRegionKHR *pRaygenShaderBindingTable,
5546 const VkStridedBufferRegionKHR *pMissShaderBindingTable,
5547 const VkStridedBufferRegionKHR *pHitShaderBindingTable,
5548 const VkStridedBufferRegionKHR *pCallableShaderBindingTable,
5549 VkBuffer buffer, VkDeviceSize offset) const {
5550 bool skip = false;
5551 const auto *raytracing_features = lvl_find_in_chain<VkPhysicalDeviceRayTracingFeaturesKHR>(device_createinfo_pnext);
5552 if (!raytracing_features || raytracing_features->rayTracingIndirectTraceRays == VK_FALSE) {
5553 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-rayTracingIndirectTraceRays-03518",
5554 "vkCmdTraceRaysIndirectKHR: the VkPhysicalDeviceRayTracingFeaturesKHR::rayTracingIndirectTraceRays "
5555 "feature must be enabled.");
5556 }
5557 if (SafeModulo(pCallableShaderBindingTable->offset, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) != 0) {
5558 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-offset-04038",
5559 "vkCmdTraceRaysIndirectKHR: The offset member of pCallableShaderBindingTable"
5560 "must be a multiple of VkPhysicalDeviceRayTracingPropertiesKHR::shaderGroupBaseAlignment.");
5561 }
5562 if (SafeModulo(pCallableShaderBindingTable->stride, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupHandleSize) != 0) {
5563 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-stride-04040",
5564 "vkCmdTraceRaysIndirectKHR: The stride member of pCallableShaderBindingTable must be a multiple"
5565 "of VkPhysicalDeviceRayTracingPropertiesKHR::shaderGroupHandleSize.");
5566 }
5567 if (pCallableShaderBindingTable->stride > phys_dev_ext_props.ray_tracing_propsKHR.maxShaderGroupStride) {
5568 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-stride-04041",
5569 "vkCmdTraceRaysIndirectKHR: The stride member of pCallableShaderBindingTable must be"
5570 "less than or equal to VkPhysicalDeviceRayTracingPropertiesKHR::maxShaderGroupStride.");
5571 }
5572 // hitShader
5573 if (SafeModulo(pHitShaderBindingTable->offset, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) != 0) {
5574 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-offset-04032",
5575 "vkCmdTraceRaysIndirectKHR: The offset member of pHitShaderBindingTable must be a multiple"
5576 "of VkPhysicalDeviceRayTracingPropertiesKHR::shaderGroupBaseAlignment.");
5577 }
5578 if (SafeModulo(pHitShaderBindingTable->stride, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupHandleSize) != 0) {
5579 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-stride-04034",
5580 "vkCmdTraceRaysIndirectKHR: The stride member of pHitShaderBindingTable must be a multiple"
5581 "of VkPhysicalDeviceRayTracingPropertiesKHR::shaderGroupHandleSize.");
5582 }
5583 if (pHitShaderBindingTable->stride > phys_dev_ext_props.ray_tracing_propsKHR.maxShaderGroupStride) {
5584 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-stride-04035",
5585 "vkCmdTraceRaysIndirectKHR: The stride member of pHitShaderBindingTable must be"
5586 "less than or equal to VkPhysicalDeviceRayTracingPropertiesKHR::maxShaderGroupStride.");
5587 }
5588
5589 // missShader
5590 if (SafeModulo(pMissShaderBindingTable->offset, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) != 0) {
5591 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-offset-04026",
5592 "vkCmdTraceRaysIndirectKHR: The offset member of pMissShaderBindingTable must be a multiple"
5593 "of VkPhysicalDeviceRayTracingPropertiesKHR::shaderGroupBaseAlignment.");
5594 }
5595 if (SafeModulo(pMissShaderBindingTable->stride, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupHandleSize) != 0) {
5596 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-stride-04028",
5597 "vkCmdTraceRaysIndirectKHR: The stride member of pMissShaderBindingTable must be a multiple"
5598 "of VkPhysicalDeviceRayTracingPropertiesKHR::shaderGroupHandleSize.");
5599 }
5600 if (pMissShaderBindingTable->stride > phys_dev_ext_props.ray_tracing_propsKHR.maxShaderGroupStride) {
5601 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-stride-04029",
5602 "vkCmdTraceRaysIndirectKHR: The stride member of pMissShaderBindingTable must be"
5603 "less than or equal to VkPhysicalDeviceRayTracingPropertiesKHR::maxShaderGroupStride.");
5604 }
5605
5606 // raygenShader
5607 if (SafeModulo(pRaygenShaderBindingTable->offset, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) != 0) {
5608 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-pRayGenShaderBindingTable-04021",
5609 "vkCmdTraceRaysIndirectKHR: pRayGenShaderBindingTable->offset must be a multiple"
5610 "of VkPhysicalDeviceRayTracingPropertiesKHR::shaderGroupBaseAlignment.");
5611 }
5612 return skip;
5613}
5614bool StatelessValidation::manual_PreCallValidateCmdTraceRaysNV(
5615 VkCommandBuffer commandBuffer, VkBuffer raygenShaderBindingTableBuffer, VkDeviceSize raygenShaderBindingOffset,
5616 VkBuffer missShaderBindingTableBuffer, VkDeviceSize missShaderBindingOffset, VkDeviceSize missShaderBindingStride,
5617 VkBuffer hitShaderBindingTableBuffer, VkDeviceSize hitShaderBindingOffset, VkDeviceSize hitShaderBindingStride,
5618 VkBuffer callableShaderBindingTableBuffer, VkDeviceSize callableShaderBindingOffset, VkDeviceSize callableShaderBindingStride,
5619 uint32_t width, uint32_t height, uint32_t depth) const {
5620 bool skip = false;
5621 if (SafeModulo(callableShaderBindingOffset, phys_dev_ext_props.ray_tracing_propsNV.shaderGroupBaseAlignment) != 0) {
5622 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-callableShaderBindingOffset-02462",
5623 "vkCmdTraceRaysNV: callableShaderBindingOffset must be a multiple of "
5624 "VkPhysicalDeviceRayTracingPropertiesNV::shaderGroupBaseAlignment.");
5625 }
5626 if (SafeModulo(callableShaderBindingStride, phys_dev_ext_props.ray_tracing_propsNV.shaderGroupHandleSize) != 0) {
5627 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-callableShaderBindingStride-02465",
5628 "vkCmdTraceRaysNV: callableShaderBindingStride must be a multiple of "
5629 "VkPhysicalDeviceRayTracingPropertiesNV::shaderGroupHandleSize.");
5630 }
5631 if (callableShaderBindingStride > phys_dev_ext_props.ray_tracing_propsNV.maxShaderGroupStride) {
5632 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-callableShaderBindingStride-02468",
5633 "vkCmdTraceRaysNV: callableShaderBindingStride must be less than or equal to "
5634 "VkPhysicalDeviceRayTracingPropertiesNV::maxShaderGroupStride. ");
5635 }
5636
5637 // hitShader
5638 if (SafeModulo(hitShaderBindingOffset, phys_dev_ext_props.ray_tracing_propsNV.shaderGroupBaseAlignment) != 0) {
5639 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-hitShaderBindingOffset-02460",
5640 "vkCmdTraceRaysNV: hitShaderBindingOffset must be a multiple of "
5641 "VkPhysicalDeviceRayTracingPropertiesNV::shaderGroupBaseAlignment.");
5642 }
5643 if (SafeModulo(hitShaderBindingStride, phys_dev_ext_props.ray_tracing_propsNV.shaderGroupHandleSize) != 0) {
5644 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-hitShaderBindingStride-02464",
5645 "vkCmdTraceRaysNV: hitShaderBindingStride must be a multiple of "
5646 "VkPhysicalDeviceRayTracingPropertiesNV::shaderGroupHandleSize.");
5647 }
5648 if (hitShaderBindingStride > phys_dev_ext_props.ray_tracing_propsNV.maxShaderGroupStride) {
5649 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-hitShaderBindingStride-02467",
5650 "vkCmdTraceRaysNV: hitShaderBindingStride must be less than or equal to "
5651 "VkPhysicalDeviceRayTracingPropertiesNV::maxShaderGroupStride.");
5652 }
5653
5654 // missShader
5655 if (SafeModulo(missShaderBindingOffset, phys_dev_ext_props.ray_tracing_propsNV.shaderGroupBaseAlignment) != 0) {
5656 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-missShaderBindingOffset-02458",
5657 "vkCmdTraceRaysNV: missShaderBindingOffset must be a multiple of "
5658 "VkPhysicalDeviceRayTracingPropertiesNV::shaderGroupBaseAlignment.");
5659 }
5660 if (SafeModulo(missShaderBindingStride, phys_dev_ext_props.ray_tracing_propsNV.shaderGroupHandleSize) != 0) {
5661 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-missShaderBindingStride-02463",
5662 "vkCmdTraceRaysNV: missShaderBindingStride must be a multiple of "
5663 "VkPhysicalDeviceRayTracingPropertiesNV::shaderGroupHandleSize.");
5664 }
5665 if (missShaderBindingStride > phys_dev_ext_props.ray_tracing_propsNV.maxShaderGroupStride) {
5666 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-missShaderBindingStride-02466",
5667 "vkCmdTraceRaysNV: missShaderBindingStride must be less than or equal to "
5668 "VkPhysicalDeviceRayTracingPropertiesNV::maxShaderGroupStride.");
5669 }
5670
5671 // raygenShader
5672 if (SafeModulo(raygenShaderBindingOffset, phys_dev_ext_props.ray_tracing_propsNV.shaderGroupBaseAlignment) != 0) {
5673 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-raygenShaderBindingOffset-02456",
5674 "vkCmdTraceRaysNV: raygenShaderBindingOffset must be a multiple of "
sourav parmard1521802020-06-07 21:49:02 -07005675 "VkPhysicalDeviceRayTracingPropertiesNV::shaderGroupBaseAlignment.");
5676 }
5677 if (width > device_limits.maxComputeWorkGroupCount[0]) {
5678 skip |=
5679 LogError(device, "VUID-vkCmdTraceRaysNV-width-02469",
5680 "vkCmdTraceRaysNV: width must be less than or equal to VkPhysicalDeviceLimits::maxComputeWorkGroupCount[o].");
5681 }
5682 if (height > device_limits.maxComputeWorkGroupCount[1]) {
5683 skip |=
5684 LogError(device, "VUID-vkCmdTraceRaysNV-height-02470",
5685 "vkCmdTraceRaysNV: height must be less than or equal to VkPhysicalDeviceLimits::maxComputeWorkGroupCount[1].");
5686 }
5687 if (depth > device_limits.maxComputeWorkGroupCount[2]) {
5688 skip |=
5689 LogError(device, "VUID-vkCmdTraceRaysNV-depth-02471",
5690 "vkCmdTraceRaysNV: depth must be less than or equal to VkPhysicalDeviceLimits::maxComputeWorkGroupCount[2].");
sourav parmar83c31b12020-05-06 12:30:54 -07005691 }
5692 return skip;
5693}
5694
5695bool StatelessValidation::manual_PreCallValidateCmdBuildAccelerationStructureIndirectKHR(
5696 VkCommandBuffer commandBuffer, const VkAccelerationStructureBuildGeometryInfoKHR *pInfo, VkBuffer indirectBuffer,
5697 VkDeviceSize indirectOffset, uint32_t indirectStride) const {
5698 bool skip = false;
5699 const auto *raytracing_features = lvl_find_in_chain<VkPhysicalDeviceRayTracingFeaturesKHR>(device_createinfo_pnext);
5700 if (!raytracing_features || raytracing_features->rayTracingIndirectAccelerationStructureBuild == VK_FALSE) {
5701 skip |= LogError(
5702 device, "VUID-vkCmdBuildAccelerationStructureIndirectKHR-rayTracingIndirectAccelerationStructureBuild-03535",
5703 "vkCmdBuildAccelerationStructureIndirectKHR: The "
5704 "VkPhysicalDeviceRayTracingFeaturesKHR::rayTracingIndirectAccelerationStructureBuild feature must be enabled.");
5705 }
Mark Lobodzinski17dc4602020-05-29 07:48:40 -06005706 const auto *pnext_struct = lvl_find_in_chain<VkDeferredOperationInfoKHR>(pInfo->pNext);
5707 if (pnext_struct) {
sourav parmar83c31b12020-05-06 12:30:54 -07005708 skip |=
5709 LogError(device, "VUID-vkCmdBuildAccelerationStructureIndirectKHR-pNext-03536",
5710 "vkCmdBuildAccelerationStructureIndirectKHR: The VkDeferredOperationInfoKHR structure must not be included in "
5711 "the pNext chain of any of the provided VkAccelerationStructureBuildGeometryInfoKHR structures.");
5712 }
5713 return false;
5714}
5715
5716bool StatelessValidation::manual_PreCallValidateGetDeviceAccelerationStructureCompatibilityKHR(
5717 VkDevice device, const VkAccelerationStructureVersionKHR *version) const {
5718 bool skip = false;
5719 const auto *raytracing_features = lvl_find_in_chain<VkPhysicalDeviceRayTracingFeaturesKHR>(device_createinfo_pnext);
5720 if (!raytracing_features || !(raytracing_features->rayQuery || raytracing_features->rayTracing)) {
5721 skip |= LogError(device, "VUID-vkGetDeviceAccelerationStructureCompatibilityKHR-rayTracing-03565",
5722 "vkGetDeviceAccelerationStructureCompatibilityKHR: The rayTracing or rayQuery feature must be enabled.");
5723 }
5724 return skip;
5725}
5726
5727bool StatelessValidation::manual_PreCallValidateBuildAccelerationStructureKHR(
5728 VkDevice device, uint32_t infoCount, const VkAccelerationStructureBuildGeometryInfoKHR *pInfos,
5729 const VkAccelerationStructureBuildOffsetInfoKHR *const *ppOffsetInfos) const {
5730 bool skip = false;
5731 const auto *raytracing_features = lvl_find_in_chain<VkPhysicalDeviceRayTracingFeaturesKHR>(device_createinfo_pnext);
5732 if (!raytracing_features || raytracing_features->rayTracingHostAccelerationStructureCommands == VK_FALSE) {
sourav parmara24fb7b2020-05-26 10:50:04 -07005733 skip |= LogError(device, "VUID-vkBuildAccelerationStructureKHR-rayTracingHostAccelerationStructureCommands-03439",
5734 "vkBuildAccelerationStructureKHR: The "
5735 "vkPhysicalDeviceRayTracingFeaturesKHR::rayTracingHostAccelerationStructureCommands"
5736 "feature must be enabled .");
sourav parmar83c31b12020-05-06 12:30:54 -07005737 }
sourav parmara96ab1a2020-04-25 16:28:23 -07005738 return skip;
5739}
sourav parmara24fb7b2020-05-26 10:50:04 -07005740bool StatelessValidation::manual_PreCallValidateCmdBuildAccelerationStructureKHR(
5741 VkCommandBuffer commandBuffer, uint32_t infoCount, const VkAccelerationStructureBuildGeometryInfoKHR *pInfos,
5742 const VkAccelerationStructureBuildOffsetInfoKHR *const *ppOffsetInfos) const {
5743 bool skip = false;
5744 for (uint32_t i = 0; i < infoCount; ++i) {
Mark Lobodzinski17dc4602020-05-29 07:48:40 -06005745 const auto *pnext_struct = lvl_find_in_chain<VkDeferredOperationInfoKHR>(pInfos->pNext);
5746 if (pnext_struct) {
sourav parmara24fb7b2020-05-26 10:50:04 -07005747 skip |=
5748 LogError(commandBuffer, "VUID-vkCmdBuildAccelerationStructureKHR-pNext-03532",
5749 "vkCmdBuildAccelerationStructureKHR: The VkDeferredOperationInfoKHR structure must not be included in the"
5750 "pNext chain of any of the provided VkAccelerationStructureBuildGeometryInfoKHR structures.");
5751 }
5752 }
5753 return skip;
Mark Lobodzinski17dc4602020-05-29 07:48:40 -06005754}
Piers Daniell39842ee2020-07-10 16:42:33 -06005755
5756bool StatelessValidation::manual_PreCallValidateCmdSetViewportWithCountEXT(VkCommandBuffer commandBuffer, uint32_t viewportCount,
5757 const VkViewport *pViewports) const {
5758 bool skip = false;
5759
5760 if (!physical_device_features.multiViewport) {
5761 if (viewportCount != 1) {
5762 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewportWithCountEXT-viewportCount-03395",
5763 "vkCmdSetViewportWithCountEXT: The multiViewport feature is disabled, but viewportCount (=%" PRIu32
5764 ") is not 1.",
5765 viewportCount);
5766 }
5767 } else { // multiViewport enabled
5768 if (viewportCount < 1 || viewportCount > device_limits.maxViewports) {
5769 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewportWithCountEXT-viewportCount-03394",
5770 "vkCmdSetViewportWithCountEXT: viewportCount (=%" PRIu32
5771 ") must "
5772 "not be greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
5773 viewportCount, device_limits.maxViewports);
5774 }
5775 }
5776
5777 if (pViewports) {
5778 for (uint32_t viewport_i = 0; viewport_i < viewportCount; ++viewport_i) {
5779 const auto &viewport = pViewports[viewport_i]; // will crash on invalid ptr
5780 const char *fn_name = "vkCmdSetViewportWithCountEXT";
5781 skip |= manual_PreCallValidateViewport(
5782 viewport, fn_name, ParameterName("pViewports[%i]", ParameterName::IndexVector{viewport_i}), commandBuffer);
5783 }
5784 }
5785
5786 return skip;
5787}
5788
5789bool StatelessValidation::manual_PreCallValidateCmdSetScissorWithCountEXT(VkCommandBuffer commandBuffer, uint32_t scissorCount,
5790 const VkRect2D *pScissors) const {
5791 bool skip = false;
5792
5793 if (!physical_device_features.multiViewport) {
5794 if (scissorCount != 1) {
5795 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissorWithCountEXT-scissorCount-03398",
5796 "vkCmdSetScissorWithCountEXT: scissorCount (=%" PRIu32
5797 ") must "
5798 "be 1 when the multiViewport feature is disabled.",
5799 scissorCount);
5800 }
5801 } else { // multiViewport enabled
5802 if (scissorCount == 0) {
5803 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissorWithCountEXT-scissorCount-03397",
5804 "vkCmdSetScissorWithCountEXT: scissorCount (=%" PRIu32
5805 ") must "
5806 "be great than zero.",
5807 scissorCount);
5808 } else if (scissorCount > device_limits.maxViewports) {
5809 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissorWithCountEXT-scissorCount-03397",
5810 "vkCmdSetScissorWithCountEXT: scissorCount (=%" PRIu32
5811 ") must "
5812 "not be greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
5813 scissorCount, device_limits.maxViewports);
5814 }
5815 }
5816
5817 if (pScissors) {
5818 for (uint32_t scissor_i = 0; scissor_i < scissorCount; ++scissor_i) {
5819 const auto &scissor = pScissors[scissor_i]; // will crash on invalid ptr
5820
5821 if (scissor.offset.x < 0) {
5822 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissorWithCountEXT-x-03399",
5823 "vkCmdSetScissor: pScissors[%" PRIu32 "].offset.x (=%" PRIi32 ") is negative.", scissor_i,
5824 scissor.offset.x);
5825 }
5826
5827 if (scissor.offset.y < 0) {
5828 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissorWithCountEXT-x-03399",
5829 "vkCmdSetScissor: pScissors[%" PRIu32 "].offset.y (=%" PRIi32 ") is negative.", scissor_i,
5830 scissor.offset.y);
5831 }
5832
5833 const int64_t x_sum = static_cast<int64_t>(scissor.offset.x) + static_cast<int64_t>(scissor.extent.width);
5834 if (x_sum > INT32_MAX) {
5835 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissorWithCountEXT-offset-03400",
5836 "vkCmdSetScissor: offset.x + extent.width (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
5837 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
5838 scissor.offset.x, scissor.extent.width, x_sum, scissor_i);
5839 }
5840
5841 const int64_t y_sum = static_cast<int64_t>(scissor.offset.y) + static_cast<int64_t>(scissor.extent.height);
5842 if (y_sum > INT32_MAX) {
5843 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissorWithCountEXT-offset-03401",
5844 "vkCmdSetScissor: offset.y + extent.height (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
5845 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
5846 scissor.offset.y, scissor.extent.height, y_sum, scissor_i);
5847 }
5848 }
5849 }
5850
5851 return skip;
5852}
5853
5854bool StatelessValidation::manual_PreCallValidateCmdBindVertexBuffers2EXT(VkCommandBuffer commandBuffer, uint32_t firstBinding,
5855 uint32_t bindingCount, const VkBuffer *pBuffers,
5856 const VkDeviceSize *pOffsets, const VkDeviceSize *pSizes,
5857 const VkDeviceSize *pStrides) const {
5858 bool skip = false;
5859 if (firstBinding >= device_limits.maxVertexInputBindings) {
5860 skip |= LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers2EXT-firstBinding-03355",
5861 "vkCmdBindVertexBuffers2EXT() firstBinding (%u) must be less than maxVertexInputBindings (%u)",
5862 firstBinding, device_limits.maxVertexInputBindings);
5863 } else if ((firstBinding + bindingCount) > device_limits.maxVertexInputBindings) {
5864 skip |= LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers2EXT-firstBinding-03356",
5865 "vkCmdBindVertexBuffers2EXT() sum of firstBinding (%u) and bindingCount (%u) must be less than "
5866 "maxVertexInputBindings (%u)",
5867 firstBinding, bindingCount, device_limits.maxVertexInputBindings);
5868 }
5869
5870 for (uint32_t i = 0; i < bindingCount; ++i) {
5871 if (pBuffers[i] == VK_NULL_HANDLE) {
5872 const auto *robustness2_features = lvl_find_in_chain<VkPhysicalDeviceRobustness2FeaturesEXT>(device_createinfo_pnext);
5873 if (!(robustness2_features && robustness2_features->nullDescriptor)) {
5874 skip |= LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers2EXT-pBuffers-04111",
5875 "vkCmdBindVertexBuffers2EXT() required parameter pBuffers[%d] specified as VK_NULL_HANDLE", i);
5876 } else {
5877 if (pOffsets[i] != 0) {
5878 skip |=
5879 LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers2EXT-pBuffers-04112",
5880 "vkCmdBindVertexBuffers2EXT() pBuffers[%d] is VK_NULL_HANDLE, but pOffsets[%d] is not 0", i, i);
5881 }
5882 }
5883 }
5884 if (pStrides) {
5885 if (pStrides[i] > device_limits.maxVertexInputBindingStride) {
5886 skip |=
5887 LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers2EXT-pStrides-03362",
5888 "vkCmdBindVertexBuffers2EXT() pStrides[%d] (%u) must be less than maxVertexInputBindingStride (%u)", i,
5889 pStrides[i], device_limits.maxVertexInputBindingStride);
5890 }
5891 }
5892 }
5893
5894 return skip;
5895}