blob: 386ca8ef51b562c32030e897c29f21f5481c87ba [file] [log] [blame]
maruel@chromium.orgddd59412011-11-30 14:20:38 +00001#!/usr/bin/env python
maruel@chromium.orgeb5edbc2012-01-16 17:03:28 +00002# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
6"""Unit tests for git_cl.py."""
7
Andrii Shyshkalovcd6a9362016-12-07 12:04:12 +01008import contextlib
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01009import datetime
tandriide281ae2016-10-12 06:02:30 -070010import json
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +010011import logging
maruel@chromium.orgddd59412011-11-30 14:20:38 +000012import os
maruel@chromium.orga3353652011-11-30 14:26:57 +000013import StringIO
maruel@chromium.orgddd59412011-11-30 14:20:38 +000014import sys
Aaron Gable9a03ae02017-11-03 11:31:07 -070015import tempfile
maruel@chromium.orgddd59412011-11-30 14:20:38 +000016import unittest
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +000017import urlparse
maruel@chromium.orgddd59412011-11-30 14:20:38 +000018
19sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
20
21from testing_support.auto_stub import TestCase
22
Edward Lemur5ba1e9c2018-07-23 18:19:02 +000023import metrics
24# We have to disable monitoring before importing git_cl.
25metrics.DISABLE_METRICS_COLLECTION = True
26
Eric Boren2fb63102018-10-05 13:05:03 +000027import gerrit_util
maruel@chromium.orgddd59412011-11-30 14:20:38 +000028import git_cl
iannucci@chromium.org9e849272014-04-04 00:31:55 +000029import git_common
tandrii@chromium.org57d86542016-03-04 16:11:32 +000030import git_footers
maruel@chromium.orgddd59412011-11-30 14:20:38 +000031import subprocess2
maruel@chromium.orgddd59412011-11-30 14:20:38 +000032
tandrii5d48c322016-08-18 16:19:37 -070033def callError(code=1, cmd='', cwd='', stdout='', stderr=''):
34 return subprocess2.CalledProcessError(code, cmd, cwd, stdout, stderr)
35
36
37CERR1 = callError(1)
38
39
Aaron Gable9a03ae02017-11-03 11:31:07 -070040def MakeNamedTemporaryFileMock(expected_content):
41 class NamedTemporaryFileMock(object):
42 def __init__(self, *args, **kwargs):
43 self.name = '/tmp/named'
44 self.expected_content = expected_content
45
46 def __enter__(self):
47 return self
48
49 def __exit__(self, _type, _value, _tb):
50 pass
51
52 def write(self, content):
53 if self.expected_content:
54 assert content == self.expected_content
55
56 def close(self):
57 pass
58
59 return NamedTemporaryFileMock
60
61
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000062class ChangelistMock(object):
63 # A class variable so we can access it when we don't have access to the
64 # instance that's being set.
65 desc = ""
66 def __init__(self, **kwargs):
67 pass
68 def GetIssue(self):
69 return 1
Kenneth Russell61e2ed42017-02-15 11:47:13 -080070 def GetDescription(self, force=False):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000071 return ChangelistMock.desc
dsansomee2d6fd92016-09-08 00:10:47 -070072 def UpdateDescription(self, desc, force=False):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000073 ChangelistMock.desc = desc
74
tandrii5d48c322016-08-18 16:19:37 -070075
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000076class PresubmitMock(object):
77 def __init__(self, *args, **kwargs):
78 self.reviewers = []
Daniel Cheng7227d212017-11-17 08:12:37 -080079 self.more_cc = ['chromium-reviews+test-more-cc@chromium.org']
80
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000081 @staticmethod
82 def should_continue():
83 return True
84
85
skobes6468b902016-10-24 08:45:10 -070086class GitCheckoutMock(object):
87 def __init__(self, *args, **kwargs):
88 pass
89
90 @staticmethod
91 def reset():
92 GitCheckoutMock.conflict = False
93
94 def apply_patch(self, p):
95 if GitCheckoutMock.conflict:
96 raise Exception('failed')
97
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000098
99class WatchlistsMock(object):
100 def __init__(self, _):
101 pass
102 @staticmethod
103 def GetWatchersForPaths(_):
104 return ['joe@example.com']
105
106
ukai@chromium.org78c4b982012-02-14 02:20:26 +0000107class CodereviewSettingsFileMock(object):
108 def __init__(self):
109 pass
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800110 # pylint: disable=no-self-use
ukai@chromium.org78c4b982012-02-14 02:20:26 +0000111 def read(self):
112 return ("CODE_REVIEW_SERVER: gerrit.chromium.org\n" +
andybons@chromium.org11f46eb2016-02-02 19:26:51 +0000113 "GERRIT_HOST: True\n")
ukai@chromium.org78c4b982012-02-14 02:20:26 +0000114
115
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000116class AuthenticatorMock(object):
117 def __init__(self, *_args):
118 pass
119 def has_cached_credentials(self):
120 return True
tandrii221ab252016-10-06 08:12:04 -0700121 def authorize(self, http):
122 return http
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000123
124
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100125def CookiesAuthenticatorMockFactory(hosts_with_creds=None, same_auth=False):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000126 """Use to mock Gerrit/Git credentials from ~/.netrc or ~/.gitcookies.
127
128 Usage:
129 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100130 CookiesAuthenticatorMockFactory({'host': ('user', _, 'pass')})
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000131
132 OR
133 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100134 CookiesAuthenticatorMockFactory(
135 same_auth=('user', '', 'pass'))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000136 """
137 class CookiesAuthenticatorMock(git_cl.gerrit_util.CookiesAuthenticator):
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800138 def __init__(self): # pylint: disable=super-init-not-called
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000139 # Intentionally not calling super() because it reads actual cookie files.
140 pass
141 @classmethod
142 def get_gitcookies_path(cls):
143 return '~/.gitcookies'
144 @classmethod
145 def get_netrc_path(cls):
146 return '~/.netrc'
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100147 def _get_auth_for_host(self, host):
148 if same_auth:
149 return same_auth
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000150 return (hosts_with_creds or {}).get(host)
151 return CookiesAuthenticatorMock
152
Aaron Gable9a03ae02017-11-03 11:31:07 -0700153
kmarshall9249e012016-08-23 12:02:16 -0700154class MockChangelistWithBranchAndIssue():
155 def __init__(self, branch, issue):
156 self.branch = branch
157 self.issue = issue
158 def GetBranch(self):
159 return self.branch
160 def GetIssue(self):
161 return self.issue
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000162
tandriic2405f52016-10-10 08:13:15 -0700163
164class SystemExitMock(Exception):
165 pass
166
167
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000168class TestGitClBasic(unittest.TestCase):
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100169 def test_get_description(self):
Andrii Shyshkalovf5569d22018-10-15 03:35:23 +0000170 cl = git_cl.Changelist(issue=1, codereview='gerrit',
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100171 codereview_host='host')
172 cl.description = 'x'
173 cl.has_description = True
Kenneth Russell61e2ed42017-02-15 11:47:13 -0800174 cl._codereview_impl.FetchDescription = lambda *a, **kw: 'y'
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100175 self.assertEquals(cl.GetDescription(), 'x')
176 self.assertEquals(cl.GetDescription(force=True), 'y')
177 self.assertEquals(cl.GetDescription(), 'y')
178
Robert Iannucci09f1f3d2017-03-28 16:54:32 -0700179 def test_description_footers(self):
180 cl = git_cl.Changelist(issue=1, codereview='gerrit',
181 codereview_host='host')
182 cl.description = '\n'.join([
183 'This is some message',
184 '',
185 'It has some lines',
186 'and, also',
187 '',
188 'Some: Really',
189 'Awesome: Footers',
190 ])
191 cl.has_description = True
192 cl._codereview_impl.UpdateDescriptionRemote = lambda *a, **kw: 'y'
193 msg, footers = cl.GetDescriptionFooters()
194 self.assertEquals(
195 msg, ['This is some message', '', 'It has some lines', 'and, also'])
196 self.assertEquals(footers, [('Some', 'Really'), ('Awesome', 'Footers')])
197
198 msg.append('wut')
199 footers.append(('gnarly-dude', 'beans'))
200 cl.UpdateDescriptionFooters(msg, footers)
201 self.assertEquals(cl.GetDescription().splitlines(), [
202 'This is some message',
203 '',
204 'It has some lines',
205 'and, also',
206 'wut'
207 '',
208 'Some: Really',
209 'Awesome: Footers',
210 'Gnarly-Dude: beans',
211 ])
212
tandriif9aefb72016-07-01 09:06:51 -0700213 def test_get_bug_line_values(self):
214 f = lambda p, bugs: list(git_cl._get_bug_line_values(p, bugs))
215 self.assertEqual(f('', ''), [])
216 self.assertEqual(f('', '123,v8:456'), ['123', 'v8:456'])
217 self.assertEqual(f('v8', '456'), ['v8:456'])
218 self.assertEqual(f('v8', 'chromium:123,456'), ['v8:456', 'chromium:123'])
219 # Not nice, but not worth carying.
220 self.assertEqual(f('v8', 'chromium:123,456,v8:123'),
221 ['v8:456', 'chromium:123', 'v8:123'])
222
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100223 def _test_git_number(self, parent_msg, dest_ref, child_msg,
224 parent_hash='parenthash'):
225 desc = git_cl.ChangeDescription(child_msg)
226 desc.update_with_git_number_footers(parent_hash, parent_msg, dest_ref)
227 return desc.description
228
229 def assertEqualByLine(self, actual, expected):
230 self.assertEqual(actual.splitlines(), expected.splitlines())
231
232 def test_git_number_bad_parent(self):
233 with self.assertRaises(ValueError):
234 self._test_git_number('Parent', 'refs/heads/master', 'Child')
235
236 def test_git_number_bad_parent_footer(self):
237 with self.assertRaises(AssertionError):
238 self._test_git_number(
239 'Parent\n'
240 '\n'
241 'Cr-Commit-Position: wrong',
242 'refs/heads/master', 'Child')
243
244 def test_git_number_bad_lineage_ignored(self):
245 actual = self._test_git_number(
246 'Parent\n'
247 '\n'
248 'Cr-Commit-Position: refs/heads/master@{#1}\n'
249 'Cr-Branched-From: mustBeReal40CharHash-branch@{#pos}',
250 'refs/heads/master', 'Child')
251 self.assertEqualByLine(
252 actual,
253 'Child\n'
254 '\n'
255 'Cr-Commit-Position: refs/heads/master@{#2}\n'
256 'Cr-Branched-From: mustBeReal40CharHash-branch@{#pos}')
257
258 def test_git_number_same_branch(self):
259 actual = self._test_git_number(
260 'Parent\n'
261 '\n'
262 'Cr-Commit-Position: refs/heads/master@{#12}',
263 dest_ref='refs/heads/master',
264 child_msg='Child')
265 self.assertEqualByLine(
266 actual,
267 'Child\n'
268 '\n'
269 'Cr-Commit-Position: refs/heads/master@{#13}')
270
Andrii Shyshkalovde37c012017-07-06 21:06:50 +0200271 def test_git_number_same_branch_mixed_footers(self):
272 actual = self._test_git_number(
273 'Parent\n'
274 '\n'
275 'Cr-Commit-Position: refs/heads/master@{#12}',
276 dest_ref='refs/heads/master',
277 child_msg='Child\n'
278 '\n'
279 'Broken-by: design\n'
280 'BUG=123')
281 self.assertEqualByLine(
282 actual,
283 'Child\n'
284 '\n'
285 'Broken-by: design\n'
286 'BUG=123\n'
287 'Cr-Commit-Position: refs/heads/master@{#13}')
288
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100289 def test_git_number_same_branch_with_originals(self):
290 actual = self._test_git_number(
291 'Parent\n'
292 '\n'
293 'Cr-Commit-Position: refs/heads/master@{#12}',
294 dest_ref='refs/heads/master',
295 child_msg='Child\n'
296 '\n'
297 'Some users are smart and insert their own footers\n'
298 '\n'
299 'Cr-Whatever: value\n'
300 'Cr-Commit-Position: refs/copy/paste@{#22}')
301 self.assertEqualByLine(
302 actual,
303 'Child\n'
304 '\n'
305 'Some users are smart and insert their own footers\n'
306 '\n'
307 'Cr-Original-Whatever: value\n'
308 'Cr-Original-Commit-Position: refs/copy/paste@{#22}\n'
309 'Cr-Commit-Position: refs/heads/master@{#13}')
310
311 def test_git_number_new_branch(self):
312 actual = self._test_git_number(
313 'Parent\n'
314 '\n'
315 'Cr-Commit-Position: refs/heads/master@{#12}',
316 dest_ref='refs/heads/branch',
317 child_msg='Child')
318 self.assertEqualByLine(
319 actual,
320 'Child\n'
321 '\n'
322 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
323 'Cr-Branched-From: parenthash-refs/heads/master@{#12}')
324
325 def test_git_number_lineage(self):
326 actual = self._test_git_number(
327 'Parent\n'
328 '\n'
329 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
330 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
331 dest_ref='refs/heads/branch',
332 child_msg='Child')
333 self.assertEqualByLine(
334 actual,
335 'Child\n'
336 '\n'
337 'Cr-Commit-Position: refs/heads/branch@{#2}\n'
338 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
339
340 def test_git_number_moooooooore_lineage(self):
341 actual = self._test_git_number(
342 'Parent\n'
343 '\n'
344 'Cr-Commit-Position: refs/heads/branch@{#5}\n'
345 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
346 dest_ref='refs/heads/mooore',
347 child_msg='Child')
348 self.assertEqualByLine(
349 actual,
350 'Child\n'
351 '\n'
352 'Cr-Commit-Position: refs/heads/mooore@{#1}\n'
353 'Cr-Branched-From: parenthash-refs/heads/branch@{#5}\n'
354 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
355
Andrii Shyshkalovb5effa12016-12-14 19:35:12 +0100356 def test_git_number_ever_moooooooore_lineage(self):
Robert Iannucci456b0d62018-03-13 19:15:50 -0700357 self.maxDiff = 10000 # pylint: disable=attribute-defined-outside-init
Andrii Shyshkalovb5effa12016-12-14 19:35:12 +0100358 actual = self._test_git_number(
359 'CQ commit on fresh new branch + numbering.\n'
360 '\n'
361 'NOTRY=True\n'
362 'NOPRESUBMIT=True\n'
363 'BUG=\n'
364 '\n'
365 'Review-Url: https://codereview.chromium.org/2577703003\n'
366 'Cr-Commit-Position: refs/heads/gnumb-test/br@{#1}\n'
367 'Cr-Branched-From: 0749ff9edc-refs/heads/gnumb-test/cq@{#4}\n'
368 'Cr-Branched-From: 5c49df2da6-refs/heads/master@{#41618}',
369 dest_ref='refs/heads/gnumb-test/cl',
370 child_msg='git cl on fresh new branch + numbering.\n'
371 '\n'
372 'Review-Url: https://codereview.chromium.org/2575043003 .\n')
373 self.assertEqualByLine(
374 actual,
375 'git cl on fresh new branch + numbering.\n'
376 '\n'
377 'Review-Url: https://codereview.chromium.org/2575043003 .\n'
378 'Cr-Commit-Position: refs/heads/gnumb-test/cl@{#1}\n'
379 'Cr-Branched-From: parenthash-refs/heads/gnumb-test/br@{#1}\n'
380 'Cr-Branched-From: 0749ff9edc-refs/heads/gnumb-test/cq@{#4}\n'
381 'Cr-Branched-From: 5c49df2da6-refs/heads/master@{#41618}')
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100382
383 def test_git_number_cherry_pick(self):
384 actual = self._test_git_number(
385 'Parent\n'
386 '\n'
387 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
388 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
389 dest_ref='refs/heads/branch',
390 child_msg='Child, which is cherry-pick from master\n'
391 '\n'
392 'Cr-Commit-Position: refs/heads/master@{#100}\n'
393 '(cherry picked from commit deadbeef12345678deadbeef12345678deadbeef)')
394 self.assertEqualByLine(
395 actual,
396 'Child, which is cherry-pick from master\n'
397 '\n'
398 '(cherry picked from commit deadbeef12345678deadbeef12345678deadbeef)\n'
399 '\n'
400 'Cr-Original-Commit-Position: refs/heads/master@{#100}\n'
401 'Cr-Commit-Position: refs/heads/branch@{#2}\n'
402 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
403
Andrii Shyshkalovd4c86732018-09-25 04:29:31 +0000404 def test_gerrit_mirror_hack(self):
405 cr = 'chromium-review.googlesource.com'
406 url0 = 'https://%s/a/changes/x?a=b' % cr
407 origMirrors = git_cl.gerrit_util._GERRIT_MIRROR_PREFIXES
408 try:
409 git_cl.gerrit_util._GERRIT_MIRROR_PREFIXES = ['us1', 'us2']
410 url1 = git_cl.gerrit_util._UseGerritMirror(url0, cr)
411 url2 = git_cl.gerrit_util._UseGerritMirror(url1, cr)
412 url3 = git_cl.gerrit_util._UseGerritMirror(url2, cr)
413
414 self.assertNotEqual(url1, url2)
415 self.assertEqual(sorted((url1, url2)), [
416 'https://us1-mirror-chromium-review.googlesource.com/a/changes/x?a=b',
417 'https://us2-mirror-chromium-review.googlesource.com/a/changes/x?a=b'])
418 self.assertEqual(url1, url3)
419 finally:
420 git_cl.gerrit_util._GERRIT_MIRROR_PREFIXES = origMirrors
421
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000422 def test_valid_accounts(self):
423 mock_per_account = {
424 'u1': None, # 404, doesn't exist.
425 'u2': {
426 '_account_id': 123124,
427 'avatars': [],
428 'email': 'u2@example.com',
429 'name': 'User Number 2',
430 'status': 'OOO',
431 },
432 'u3': git_cl.gerrit_util.GerritError(500, 'retries didn\'t help :('),
433 }
434 def GetAccountDetailsMock(_, account):
435 # Poor-man's mock library's side_effect.
436 v = mock_per_account.pop(account)
437 if isinstance(v, Exception):
438 raise v
439 return v
440
441 original = git_cl.gerrit_util.GetAccountDetails
442 try:
443 git_cl.gerrit_util.GetAccountDetails = GetAccountDetailsMock
444 actual = git_cl.gerrit_util.ValidAccounts(
445 'host', ['u1', 'u2', 'u3'], max_threads=1)
446 finally:
447 git_cl.gerrit_util.GetAccountDetails = original
448 self.assertEqual(actual, {
449 'u2': {
450 '_account_id': 123124,
451 'avatars': [],
452 'email': 'u2@example.com',
453 'name': 'User Number 2',
454 'status': 'OOO',
455 },
456 })
457
458
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000459
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200460class TestParseIssueURL(unittest.TestCase):
461 def _validate(self, parsed, issue=None, patchset=None, hostname=None,
462 codereview=None, fail=False):
463 self.assertIsNotNone(parsed)
464 if fail:
465 self.assertFalse(parsed.valid)
466 return
467 self.assertTrue(parsed.valid)
468 self.assertEqual(parsed.issue, issue)
469 self.assertEqual(parsed.patchset, patchset)
470 self.assertEqual(parsed.hostname, hostname)
471 self.assertEqual(parsed.codereview, codereview)
472
473 def _run_and_validate(self, func, url, *args, **kwargs):
474 result = func(urlparse.urlparse(url))
475 if kwargs.pop('fail', False):
476 self.assertIsNone(result)
477 return None
478 self._validate(result, *args, fail=False, **kwargs)
479
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200480 def test_gerrit(self):
481 def test(url, issue=None, patchset=None, hostname=None, fail=None):
482 self._test_ParseIssueUrl(
483 git_cl._GerritChangelistImpl.ParseIssueURL,
484 url, issue, patchset, hostname, fail)
485 def test(url, *args, **kwargs):
486 self._run_and_validate(git_cl._GerritChangelistImpl.ParseIssueURL, url,
487 *args, codereview='gerrit', **kwargs)
488
489 test('http://chrome-review.source.com/c/123',
490 123, None, 'chrome-review.source.com')
491 test('https://chrome-review.source.com/c/123/',
492 123, None, 'chrome-review.source.com')
493 test('https://chrome-review.source.com/c/123/4',
494 123, 4, 'chrome-review.source.com')
495 test('https://chrome-review.source.com/#/c/123/4',
496 123, 4, 'chrome-review.source.com')
497 test('https://chrome-review.source.com/c/123/4',
498 123, 4, 'chrome-review.source.com')
499 test('https://chrome-review.source.com/123',
500 123, None, 'chrome-review.source.com')
501 test('https://chrome-review.source.com/123/4',
502 123, 4, 'chrome-review.source.com')
503
504 test('https://chrome-review.source.com/c/123/1/whatisthis', fail=True)
505 test('https://chrome-review.source.com/c/abc/', fail=True)
506 test('ssh://chrome-review.source.com/c/123/1/', fail=True)
507
508 def test_ParseIssueNumberArgument(self):
509 def test(arg, *args, **kwargs):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +0200510 codereview_hint = kwargs.pop('hint', None)
511 self._validate(git_cl.ParseIssueNumberArgument(arg, codereview_hint),
512 *args, **kwargs)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200513
514 test('123', 123)
515 test('', fail=True)
516 test('abc', fail=True)
517 test('123/1', fail=True)
518 test('123a', fail=True)
519 test('ssh://chrome-review.source.com/#/c/123/4/', fail=True)
Andrii Shyshkalovf5569d22018-10-15 03:35:23 +0000520
521 # Looks like Rietveld and Gerrit, but we should select Gerrit now
522 # w/ or w/o hint.
Andrii Shyshkalovc9712392017-04-11 13:35:21 +0200523 test('https://codereview.source.com/123',
524 123, None, 'codereview.source.com', 'gerrit',
525 hint='gerrit')
Andrii Shyshkalovf5569d22018-10-15 03:35:23 +0000526 test('https://codereview.source.com/123',
527 123, None, 'codereview.source.com', 'gerrit')
528
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200529 # Gerrrit.
530 test('https://chrome-review.source.com/c/123/4',
531 123, 4, 'chrome-review.source.com', 'gerrit')
532 test('https://chrome-review.source.com/bad/123/4', fail=True)
533
534
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100535class GitCookiesCheckerTest(TestCase):
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100536 def setUp(self):
537 super(GitCookiesCheckerTest, self).setUp()
538 self.c = git_cl._GitCookiesChecker()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100539 self.c._all_hosts = []
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100540
541 def mock_hosts_creds(self, subhost_identity_pairs):
542 def ensure_googlesource(h):
543 if not h.endswith(self.c._GOOGLESOURCE):
544 assert not h.endswith('.')
545 return h + '.' + self.c._GOOGLESOURCE
546 return h
547 self.c._all_hosts = [(ensure_googlesource(h), i, '.gitcookies')
548 for h, i in subhost_identity_pairs]
549
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200550 def test_identity_parsing(self):
551 self.assertEqual(self.c._parse_identity('ldap.google.com'),
552 ('ldap', 'google.com'))
553 self.assertEqual(self.c._parse_identity('git-ldap.example.com'),
554 ('ldap', 'example.com'))
555 # Specical case because we know there are no subdomains in chromium.org.
556 self.assertEqual(self.c._parse_identity('git-note.period.chromium.org'),
557 ('note.period', 'chromium.org'))
Lei Zhangd3f769a2017-12-15 15:16:14 -0800558 # Pathological: ".period." can be either username OR domain, more likely
559 # domain.
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200560 self.assertEqual(self.c._parse_identity('git-note.period.example.com'),
561 ('note', 'period.example.com'))
562
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100563 def test_analysis_nothing(self):
564 self.c._all_hosts = []
565 self.assertFalse(self.c.has_generic_host())
566 self.assertEqual(set(), self.c.get_conflicting_hosts())
567 self.assertEqual(set(), self.c.get_duplicated_hosts())
568 self.assertEqual(set(), self.c.get_partially_configured_hosts())
569 self.assertEqual(set(), self.c.get_hosts_with_wrong_identities())
570
571 def test_analysis(self):
572 self.mock_hosts_creds([
573 ('.googlesource.com', 'git-example.chromium.org'),
574
575 ('chromium', 'git-example.google.com'),
576 ('chromium-review', 'git-example.google.com'),
577 ('chrome-internal', 'git-example.chromium.org'),
578 ('chrome-internal-review', 'git-example.chromium.org'),
579 ('conflict', 'git-example.google.com'),
580 ('conflict-review', 'git-example.chromium.org'),
581 ('dup', 'git-example.google.com'),
582 ('dup', 'git-example.google.com'),
583 ('dup-review', 'git-example.google.com'),
584 ('partial', 'git-example.google.com'),
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200585 ('gpartial-review', 'git-example.google.com'),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100586 ])
587 self.assertTrue(self.c.has_generic_host())
588 self.assertEqual(set(['conflict.googlesource.com']),
589 self.c.get_conflicting_hosts())
590 self.assertEqual(set(['dup.googlesource.com']),
591 self.c.get_duplicated_hosts())
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200592 self.assertEqual(set(['partial.googlesource.com',
593 'gpartial-review.googlesource.com']),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100594 self.c.get_partially_configured_hosts())
595 self.assertEqual(set(['chromium.googlesource.com',
596 'chrome-internal.googlesource.com']),
597 self.c.get_hosts_with_wrong_identities())
598
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100599 def test_report_no_problems(self):
600 self.test_analysis_nothing()
601 self.mock(sys, 'stdout', StringIO.StringIO())
602 self.assertFalse(self.c.find_and_report_problems())
603 self.assertEqual(sys.stdout.getvalue(), '')
604
605 def test_report(self):
606 self.test_analysis()
607 self.mock(sys, 'stdout', StringIO.StringIO())
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200608 self.mock(git_cl.gerrit_util.CookiesAuthenticator, 'get_gitcookies_path',
609 classmethod(lambda _: '~/.gitcookies'))
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100610 self.assertTrue(self.c.find_and_report_problems())
611 with open(os.path.join(os.path.dirname(__file__),
612 'git_cl_creds_check_report.txt')) as f:
613 expected = f.read()
614 def by_line(text):
615 return [l.rstrip() for l in text.rstrip().splitlines()]
Robert Iannucci456b0d62018-03-13 19:15:50 -0700616 self.maxDiff = 10000 # pylint: disable=attribute-defined-outside-init
Andrii Shyshkalov4812e612017-03-27 17:22:57 +0200617 self.assertEqual(by_line(sys.stdout.getvalue().strip()), by_line(expected))
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100618
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -0800619
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000620class TestGitCl(TestCase):
621 def setUp(self):
622 super(TestGitCl, self).setUp()
623 self.calls = []
tandrii9d206752016-06-20 11:32:47 -0700624 self._calls_done = []
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000625 self.mock(git_cl, 'time_time',
626 lambda: self._mocked_call('time.time'))
627 self.mock(git_cl.metrics.collector, 'add_repeated',
628 lambda *a: self._mocked_call('add_repeated', *a))
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000629 self.mock(subprocess2, 'call', self._mocked_call)
630 self.mock(subprocess2, 'check_call', self._mocked_call)
631 self.mock(subprocess2, 'check_output', self._mocked_call)
tandrii5d48c322016-08-18 16:19:37 -0700632 self.mock(subprocess2, 'communicate',
633 lambda *a, **kw: ([self._mocked_call(*a, **kw), ''], 0))
tandrii@chromium.orga342c922016-03-16 07:08:25 +0000634 self.mock(git_cl.gclient_utils, 'CheckCallAndFilter', self._mocked_call)
sbc@chromium.org71437c02015-04-09 19:29:40 +0000635 self.mock(git_common, 'is_dirty_git_tree', lambda x: False)
iannucci@chromium.org9e849272014-04-04 00:31:55 +0000636 self.mock(git_common, 'get_or_create_merge_base',
637 lambda *a: (
638 self._mocked_call(['get_or_create_merge_base']+list(a))))
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +0000639 self.mock(git_cl, 'BranchExists', lambda _: True)
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000640 self.mock(git_cl, 'FindCodereviewSettingsFile', lambda: '')
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000641 self.mock(git_cl, 'SaveDescriptionBackup', lambda _:
642 self._mocked_call('SaveDescriptionBackup'))
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100643 self.mock(git_cl, 'ask_for_data', lambda *a, **k: self._mocked_call(
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000644 *(['ask_for_data'] + list(a)), **k))
phajdan.jre328cf92016-08-22 04:12:17 -0700645 self.mock(git_cl, 'write_json', lambda path, contents:
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000646 self._mocked_call('write_json', path, contents))
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000647 self.mock(git_cl.presubmit_support, 'DoPresubmitChecks', PresubmitMock)
skobes6468b902016-10-24 08:45:10 -0700648 self.mock(git_cl.checkout, 'GitCheckout', GitCheckoutMock)
649 GitCheckoutMock.reset()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000650 self.mock(git_cl.watchlists, 'Watchlists', WatchlistsMock)
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000651 self.mock(git_cl.auth, 'get_authenticator_for_host', AuthenticatorMock)
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +0100652 self.mock(git_cl.gerrit_util, 'GetChangeDetail',
653 lambda *args, **kwargs: self._mocked_call(
654 'GetChangeDetail', *args, **kwargs))
Aaron Gable0ffdf2d2017-06-05 13:01:17 -0700655 self.mock(git_cl.gerrit_util, 'GetChangeComments',
656 lambda *args, **kwargs: self._mocked_call(
657 'GetChangeComments', *args, **kwargs))
Quinten Yearsley0e617c02019-02-20 00:37:03 +0000658 self.mock(git_cl.gerrit_util, 'GetChangeRobotComments',
659 lambda *args, **kwargs: self._mocked_call(
660 'GetChangeRobotComments', *args, **kwargs))
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +0100661 self.mock(git_cl.gerrit_util, 'AddReviewers',
Aaron Gable6dadfbf2017-05-09 14:27:58 -0700662 lambda h, i, reviewers, ccs, notify: self._mocked_call(
663 'AddReviewers', h, i, reviewers, ccs, notify))
Aaron Gablefd238082017-06-07 13:42:34 -0700664 self.mock(git_cl.gerrit_util, 'SetReview',
Aaron Gablefc62f762017-07-17 11:12:07 -0700665 lambda h, i, msg=None, labels=None, notify=None:
666 self._mocked_call('SetReview', h, i, msg, labels, notify))
Andrii Shyshkalov733d4ec2018-04-19 11:48:58 -0700667 self.mock(git_cl.gerrit_util.LuciContextAuthenticator, 'is_luci',
668 staticmethod(lambda: False))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000669 self.mock(git_cl.gerrit_util.GceAuthenticator, 'is_gce',
670 classmethod(lambda _: False))
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000671 self.mock(git_cl.gerrit_util, 'ValidAccounts',
672 lambda host, accounts:
673 self._mocked_call('ValidAccounts', host, accounts))
tandriic2405f52016-10-10 08:13:15 -0700674 self.mock(git_cl, 'DieWithError',
Christopher Lamf732cd52017-01-24 12:40:11 +1100675 lambda msg, change=None: self._mocked_call(['DieWithError', msg]))
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000676 # It's important to reset settings to not have inter-tests interference.
677 git_cl.settings = None
678
679 def tearDown(self):
wychen@chromium.org445c8962015-04-28 23:30:05 +0000680 try:
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100681 self.assertEquals([], self.calls)
682 except AssertionError:
wychen@chromium.org445c8962015-04-28 23:30:05 +0000683 if not self.has_failed():
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100684 raise
685 # Sadly, has_failed() returns True if this OR any other tests before this
686 # one have failed.
Andrii Shyshkalove05d4882017-04-12 14:34:49 +0200687 git_cl.logging.error(
688 '!!!!!! IF YOU SEE THIS, READ BELOW, IT WILL SAVE YOUR TIME !!!!!\n'
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100689 'There are un-consumed self.calls after this test has finished.\n'
690 'If you don\'t know which test this is, run:\n'
Aaron Gable3a16ed12017-03-23 10:51:55 -0700691 ' tests/git_cl_tests.py -v\n'
Andrii Shyshkalove05d4882017-04-12 14:34:49 +0200692 'If you are already running only this test, then **first** fix the '
693 'problem whose exception is emitted below by unittest runner.\n'
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100694 'Else, to be sure what\'s going on, run this test **alone** with \n'
Aaron Gable3a16ed12017-03-23 10:51:55 -0700695 ' tests/git_cl_tests.py TestGitCl.<name>\n'
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100696 'and follow instructions above.\n' +
697 '=' * 80)
wychen@chromium.org445c8962015-04-28 23:30:05 +0000698 finally:
699 super(TestGitCl, self).tearDown()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000700
iannucci@chromium.org9e849272014-04-04 00:31:55 +0000701 def _mocked_call(self, *args, **_kwargs):
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000702 self.assertTrue(
703 self.calls,
tandrii9d206752016-06-20 11:32:47 -0700704 '@%d Expected: <Missing> Actual: %r' % (len(self._calls_done), args))
wychen@chromium.orga872e752015-04-28 23:42:18 +0000705 top = self.calls.pop(0)
wychen@chromium.orga872e752015-04-28 23:42:18 +0000706 expected_args, result = top
707
maruel@chromium.orge52678e2013-04-26 18:34:44 +0000708 # Also logs otherwise it could get caught in a try/finally and be hard to
709 # diagnose.
710 if expected_args != args:
tandrii9d206752016-06-20 11:32:47 -0700711 N = 5
712 prior_calls = '\n '.join(
713 '@%d: %r' % (len(self._calls_done) - N + i, c[0])
714 for i, c in enumerate(self._calls_done[-N:]))
715 following_calls = '\n '.join(
716 '@%d: %r' % (len(self._calls_done) + i + 1, c[0])
717 for i, c in enumerate(self.calls[:N]))
718 extended_msg = (
719 'A few prior calls:\n %s\n\n'
720 'This (expected):\n @%d: %r\n'
721 'This (actual):\n @%d: %r\n\n'
722 'A few following expected calls:\n %s' %
723 (prior_calls, len(self._calls_done), expected_args,
724 len(self._calls_done), args, following_calls))
725 git_cl.logging.error(extended_msg)
726
tandrii99a72f22016-08-17 14:33:24 -0700727 self.fail('@%d\n'
728 ' Expected: %r\n'
729 ' Actual: %r' % (
tandrii9d206752016-06-20 11:32:47 -0700730 len(self._calls_done), expected_args, args))
731
732 self._calls_done.append(top)
tandrii5d48c322016-08-18 16:19:37 -0700733 if isinstance(result, Exception):
734 raise result
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000735 return result
736
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100737 def test_ask_for_explicit_yes_true(self):
738 self.calls = [
739 (('ask_for_data', 'prompt [Yes/No]: '), 'blah'),
740 (('ask_for_data', 'Please, type yes or no: '), 'ye'),
741 ]
742 self.assertTrue(git_cl.ask_for_explicit_yes('prompt'))
743
tandrii48df5812016-10-17 03:55:37 -0700744 def test_LoadCodereviewSettingsFromFile_gerrit(self):
745 codereview_file = StringIO.StringIO('GERRIT_HOST: true')
746 self.calls = [
747 ((['git', 'config', '--unset-all', 'rietveld.cc'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700748 ((['git', 'config', '--unset-all', 'rietveld.tree-status-url'],), CERR1),
749 ((['git', 'config', '--unset-all', 'rietveld.viewvc-url'],), CERR1),
750 ((['git', 'config', '--unset-all', 'rietveld.bug-prefix'],), CERR1),
751 ((['git', 'config', '--unset-all', 'rietveld.cpplint-regex'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700752 ((['git', 'config', '--unset-all', 'rietveld.cpplint-ignore-regex'],),
753 CERR1),
tandrii48df5812016-10-17 03:55:37 -0700754 ((['git', 'config', '--unset-all', 'rietveld.run-post-upload-hook'],),
755 CERR1),
756 ((['git', 'config', 'gerrit.host', 'true'],), ''),
757 ]
758 self.assertIsNone(git_cl.LoadCodereviewSettingsFromFile(codereview_file))
759
maruel@chromium.orga3353652011-11-30 14:26:57 +0000760 @classmethod
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000761 def _is_gerrit_calls(cls, gerrit=False):
762 return [((['git', 'config', 'rietveld.autoupdate'],), ''),
763 ((['git', 'config', 'gerrit.host'],), 'True' if gerrit else '')]
764
765 @classmethod
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +0000766 def _git_post_upload_calls(cls):
767 return [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000768 ((['git', 'rev-parse', 'HEAD'],), 'hash'),
769 ((['git', 'symbolic-ref', 'HEAD'],), 'hash'),
770 ((['git',
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000771 'config', 'branch.hash.last-upload-hash', 'hash'],), ''),
rmistry@google.com5626a922015-02-26 14:03:30 +0000772 ((['git', 'config', 'rietveld.run-post-upload-hook'],), ''),
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000773 ]
774
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000775 @staticmethod
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000776 def _git_sanity_checks(diff_base, working_branch, get_remote_branch=True):
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000777 fake_ancestor = 'fake_ancestor'
778 fake_cl = 'fake_cl_for_patch'
779 return [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000780 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000781 'rev-parse', '--verify', diff_base],), fake_ancestor),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000782 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000783 'merge-base', fake_ancestor, 'HEAD'],), fake_ancestor),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000784 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000785 'rev-list', '^' + fake_ancestor, 'HEAD'],), fake_cl),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000786 # Mock a config miss (error code 1)
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000787 ((['git',
tandrii5d48c322016-08-18 16:19:37 -0700788 'config', 'gitcl.remotebranch'],), CERR1),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000789 ] + ([
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000790 # Call to GetRemoteBranch()
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000791 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000792 'config', 'branch.%s.merge' % working_branch],),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000793 'refs/heads/master'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000794 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000795 'config', 'branch.%s.remote' % working_branch],), 'origin'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000796 ] if get_remote_branch else []) + [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000797 ((['git', 'rev-list', '^' + fake_ancestor,
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000798 'refs/remotes/origin/master'],), ''),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000799 ]
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000800
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000801 @classmethod
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000802 def _gerrit_ensure_auth_calls(
803 cls, issue=None, skip_auth_check=False, short_hostname='chromium'):
shinyak@chromium.org00dbccd2016-04-15 07:24:43 +0000804 cmd = ['git', 'config', '--bool', 'gerrit.skip-ensure-authenticated']
tandrii@chromium.org28253532016-04-14 13:46:56 +0000805 if skip_auth_check:
806 return [((cmd, ), 'true')]
807
tandrii5d48c322016-08-18 16:19:37 -0700808 calls = [((cmd, ), CERR1)]
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000809 if issue:
810 calls.extend([
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +0100811 ((['git', 'config', 'branch.master.gerritserver'],), CERR1),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000812 ])
813 calls.extend([
814 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
815 ((['git', 'config', 'branch.master.remote'],), 'origin'),
816 ((['git', 'config', 'remote.origin.url'],),
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000817 'https://%s.googlesource.com/my/repo' % short_hostname),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000818 ])
819 return calls
820
821 @classmethod
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100822 def _gerrit_base_calls(cls, issue=None, fetched_description=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200823 fetched_status=None, other_cl_owner=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000824 custom_cl_base=None, short_hostname='chromium'):
Aaron Gable13101a62018-02-09 13:20:41 -0800825 calls = cls._is_gerrit_calls(True)
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100826 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200827 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200828 ((['git', 'config', 'branch.master.gerritissue'],),
829 CERR1 if issue is None else str(issue)),
830 ]
831
832 if custom_cl_base:
833 ancestor_revision = custom_cl_base
834 else:
835 # Determine ancestor_revision to be merge base.
836 ancestor_revision = 'fake_ancestor_sha'
837 calls += [
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000838 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000839 ((['git', 'config', 'branch.master.remote'],), 'origin'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000840 ((['get_or_create_merge_base', 'master',
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200841 'refs/remotes/origin/master'],), ancestor_revision),
842 ]
843
844 # Calls to verify branch point is ancestor
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000845 calls += cls._gerrit_ensure_auth_calls(
846 issue=issue, short_hostname=short_hostname)
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100847
848 if issue:
849 calls += [
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000850 (('GetChangeDetail', '%s-review.googlesource.com' % short_hostname,
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +0000851 'my%2Frepo~123456',
Andrii Shyshkalovc4a73562018-09-25 18:40:17 +0000852 ['DETAILED_ACCOUNTS', 'CURRENT_REVISION', 'CURRENT_COMMIT', 'LABELS']
853 ),
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100854 {
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100855 'owner': {'email': (other_cl_owner or 'owner@example.com')},
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100856 'change_id': '123456789',
857 'current_revision': 'sha1_of_current_revision',
858 'revisions': { 'sha1_of_current_revision': {
859 'commit': {'message': fetched_description},
860 }},
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100861 'status': fetched_status or 'NEW',
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100862 }),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100863 ]
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100864 if fetched_status == 'ABANDONED':
865 calls += [
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000866 (('DieWithError', 'Change https://%s-review.googlesource.com/'
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100867 '123456 has been abandoned, new uploads are not '
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000868 'allowed' % short_hostname), SystemExitMock()),
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100869 ]
870 return calls
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100871 if other_cl_owner:
872 calls += [
873 (('ask_for_data', 'Press Enter to upload, or Ctrl+C to abort'), ''),
874 ]
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100875
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200876 calls += cls._git_sanity_checks(ancestor_revision, 'master',
877 get_remote_branch=False)
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100878 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200879 ((['git', 'rev-parse', '--show-cdup'],), ''),
880 ((['git', 'rev-parse', 'HEAD'],), '12345'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000881
Aaron Gable7817f022017-12-12 09:43:17 -0800882 ((['git', '-c', 'core.quotePath=false', 'diff', '--name-status',
883 '--no-renames', '-r', ancestor_revision + '...', '.'],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200884 'M\t.gitignore\n'),
885 ((['git', 'config', 'branch.master.gerritpatchset'],), CERR1),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100886 ]
887
888 if not issue:
889 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200890 ((['git', 'log', '--pretty=format:%s%n%n%b',
891 ancestor_revision + '...'],),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000892 'foo'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100893 ]
894
895 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200896 ((['git', 'config', 'user.email'],), 'me@example.com'),
897 ((['git', 'diff', '--no-ext-diff', '--stat', '-l100000', '-C50'] +
898 ([custom_cl_base] if custom_cl_base else
899 [ancestor_revision, 'HEAD']),),
900 '+dat'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100901 ]
902 return calls
ukai@chromium.orge8077812012-02-03 03:41:46 +0000903
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +0000904 @classmethod
905 def _gerrit_upload_calls(cls, description, reviewers, squash,
tandriia60502f2016-06-20 02:01:53 -0700906 squash_mode='default',
tandrii@chromium.org10625002016-03-04 20:03:47 +0000907 expected_upstream_ref='origin/refs/heads/master',
Aaron Gablefd238082017-06-07 13:42:34 -0700908 title=None, notify=False,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +0100909 post_amend_description=None, issue=None, cc=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000910 custom_cl_base=None, tbr=None,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +0000911 short_hostname='chromium',
Edward Lemurdc8e23d2019-05-07 00:45:48 +0000912 labels=None, change_id=None, original_title=None,
913 final_description=None):
tandrii@chromium.org10625002016-03-04 20:03:47 +0000914 if post_amend_description is None:
915 post_amend_description = description
bradnelsond975b302016-10-23 12:20:23 -0700916 cc = cc or []
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200917 # Determined in `_gerrit_base_calls`.
918 determined_ancestor_revision = custom_cl_base or 'fake_ancestor_sha'
919
920 calls = []
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000921
tandriia60502f2016-06-20 02:01:53 -0700922 if squash_mode == 'default':
923 calls.extend([
924 ((['git', 'config', '--bool', 'gerrit.override-squash-uploads'],), ''),
925 ((['git', 'config', '--bool', 'gerrit.squash-uploads'],), ''),
926 ])
927 elif squash_mode in ('override_squash', 'override_nosquash'):
928 calls.extend([
929 ((['git', 'config', '--bool', 'gerrit.override-squash-uploads'],),
930 'true' if squash_mode == 'override_squash' else 'false'),
931 ])
932 else:
933 assert squash_mode in ('squash', 'nosquash')
934
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000935 # If issue is given, then description is fetched from Gerrit instead.
936 if issue is None:
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000937 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200938 ((['git', 'log', '--pretty=format:%s\n\n%b',
939 ((custom_cl_base + '..') if custom_cl_base else
940 'fake_ancestor_sha..HEAD')],),
941 description),
942 ]
Aaron Gableb56ad332017-01-06 15:24:31 -0800943 if squash:
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +0000944 title = 'Initial_upload'
Aaron Gableb56ad332017-01-06 15:24:31 -0800945 else:
946 if not title:
947 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200948 ((['git', 'show', '-s', '--format=%s', 'HEAD'],), ''),
949 (('ask_for_data', 'Title for patchset []: '), 'User input'),
Aaron Gableb56ad332017-01-06 15:24:31 -0800950 ]
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +0000951 title = 'User_input'
tandrii@chromium.org57d86542016-03-04 16:11:32 +0000952 if not git_footers.get_footer_change_id(description) and not squash:
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000953 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200954 (('DownloadGerritHook', False), ''),
955 # Amending of commit message to get the Change-Id.
956 ((['git', 'log', '--pretty=format:%s\n\n%b',
957 determined_ancestor_revision + '..HEAD'],),
958 description),
959 ((['git', 'commit', '--amend', '-m', description],), ''),
960 ((['git', 'log', '--pretty=format:%s\n\n%b',
961 determined_ancestor_revision + '..HEAD'],),
962 post_amend_description)
963 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000964 if squash:
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000965 if not issue:
966 # Prompting to edit description on first upload.
967 calls += [
Jonas Termansend0f79112019-03-22 15:28:26 +0000968 ((['git', 'config', 'rietveld.bug-prefix'],), ''),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200969 ((['git', 'config', 'core.editor'],), ''),
970 ((['RunEditor'],), description),
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000971 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000972 ref_to_push = 'abcdef0123456789'
973 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200974 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
975 ((['git', 'config', 'branch.master.remote'],), 'origin'),
976 ]
977
978 if custom_cl_base is None:
979 calls += [
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000980 ((['get_or_create_merge_base', 'master',
981 'refs/remotes/origin/master'],),
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000982 'origin/master'),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200983 ]
984 parent = 'origin/master'
985 else:
986 calls += [
987 ((['git', 'merge-base', '--is-ancestor', custom_cl_base,
988 'refs/remotes/origin/master'],),
989 callError(1)), # Means not ancenstor.
990 (('ask_for_data',
991 'Do you take responsibility for cleaning up potential mess '
992 'resulting from proceeding with upload? Press Enter to upload, '
993 'or Ctrl+C to abort'), ''),
994 ]
995 parent = custom_cl_base
996
997 calls += [
998 ((['git', 'rev-parse', 'HEAD:'],), # `HEAD:` means HEAD's tree hash.
999 '0123456789abcdef'),
1000 ((['git', 'commit-tree', '0123456789abcdef', '-p', parent,
Aaron Gable9a03ae02017-11-03 11:31:07 -07001001 '-F', '/tmp/named'],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001002 ref_to_push),
1003 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001004 else:
1005 ref_to_push = 'HEAD'
1006
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001007 calls += [
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +00001008 (('SaveDescriptionBackup',), None),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001009 ((['git', 'rev-list',
1010 (custom_cl_base if custom_cl_base else expected_upstream_ref) + '..' +
1011 ref_to_push],),
1012 '1hashPerLine\n'),
1013 ]
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001014
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001015 metrics_arguments = []
1016
Aaron Gableafd52772017-06-27 16:40:10 -07001017 if notify:
Aaron Gable844cf292017-06-28 11:32:59 -07001018 ref_suffix = '%ready,notify=ALL'
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001019 metrics_arguments += ['ready', 'notify=ALL']
Aaron Gable844cf292017-06-28 11:32:59 -07001020 else:
Jamie Madill276da0b2018-04-27 14:41:20 -04001021 if not issue and squash:
Aaron Gable844cf292017-06-28 11:32:59 -07001022 ref_suffix = '%wip'
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001023 metrics_arguments.append('wip')
Aaron Gable844cf292017-06-28 11:32:59 -07001024 else:
1025 ref_suffix = '%notify=NONE'
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001026 metrics_arguments.append('notify=NONE')
Aaron Gable9b713dd2016-12-14 16:04:21 -08001027
Aaron Gable70f4e242017-06-26 10:45:59 -07001028 if title:
Aaron Gableafd52772017-06-27 16:40:10 -07001029 ref_suffix += ',m=' + title
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001030 metrics_arguments.append('m')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001031
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00001032 calls += [
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +00001033 ((['git', 'config', 'rietveld.cc'],), ''),
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00001034 ]
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001035 if short_hostname == 'chromium':
1036 # All reviwers and ccs get into ref_suffix.
1037 for r in sorted(reviewers):
1038 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001039 metrics_arguments.append('r')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001040 for c in sorted(['chromium-reviews+test-more-cc@chromium.org',
1041 'joe@example.com'] + cc):
1042 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001043 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001044 reviewers, cc = [], []
1045 else:
1046 # TODO(crbug/877717): remove this case.
1047 calls += [
1048 (('ValidAccounts', '%s-review.googlesource.com' % short_hostname,
1049 sorted(reviewers) + ['joe@example.com',
1050 'chromium-reviews+test-more-cc@chromium.org'] + cc),
1051 {
1052 e: {'email': e}
1053 for e in (reviewers + ['joe@example.com'] + cc)
1054 })
1055 ]
1056 for r in sorted(reviewers):
1057 if r != 'bad-account-or-email':
1058 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001059 metrics_arguments.append('r')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001060 reviewers.remove(r)
1061 for c in sorted(['joe@example.com'] + cc):
1062 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001063 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001064 if c in cc:
1065 cc.remove(c)
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00001066
Edward Lemur687ca902018-12-05 02:30:30 +00001067 for k, v in sorted((labels or {}).items()):
1068 ref_suffix += ',l=%s+%d' % (k, v)
1069 metrics_arguments.append('l=%s+%d' % (k, v))
1070
1071 if tbr:
1072 calls += [
1073 (('GetCodeReviewTbrScore',
1074 '%s-review.googlesource.com' % short_hostname,
1075 'my/repo'),
1076 2,),
1077 ]
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001078
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001079 calls += [
1080 (('time.time',), 1000,),
1081 ((['git', 'push',
1082 'https://%s.googlesource.com/my/repo' % short_hostname,
1083 ref_to_push + ':refs/for/refs/heads/master' + ref_suffix],),
1084 (('remote:\n'
1085 'remote: Processing changes: (\)\n'
1086 'remote: Processing changes: (|)\n'
1087 'remote: Processing changes: (/)\n'
1088 'remote: Processing changes: (-)\n'
1089 'remote: Processing changes: new: 1 (/)\n'
1090 'remote: Processing changes: new: 1, done\n'
1091 'remote:\n'
1092 'remote: New Changes:\n'
1093 'remote: https://%s-review.googlesource.com/#/c/my/repo/+/123456'
1094 ' XXX\n'
1095 'remote:\n'
1096 'To https://%s.googlesource.com/my/repo\n'
1097 ' * [new branch] hhhh -> refs/for/refs/heads/master\n'
1098 ) % (short_hostname, short_hostname)),),
1099 (('time.time',), 2000,),
1100 (('add_repeated',
1101 'sub_commands',
1102 {
1103 'execution_time': 1000,
1104 'command': 'git push',
1105 'exit_code': 0,
1106 'arguments': sorted(metrics_arguments),
1107 }),
1108 None,),
1109 ]
1110
Edward Lemurdc8e23d2019-05-07 00:45:48 +00001111 final_description = final_description or post_amend_description.strip()
1112 original_title = original_title or title or '<untitled>'
1113 # Trace-related calls
1114 calls += [
1115 # Write a description with context for the current trace.
1116 ((['FileWrite', 'TRACES_DIR/20170316T200041.000000-README',
1117 'Date: Thu Mar 16 20:00:41 2017\n\n'
1118 'Change: https://%(short_hostname)s-review.googlesource.com/'
1119 'q/%(change_id)s\n'
1120 'Title: %(title)s\n\n'
1121 '%(description)s\n\n'
1122 'Execution time: 1000\n'
1123 'Exit code: 0\n\n'
1124 'When filing a bug for this push, be sure to include the traces '
1125 'found at:\n'
1126 ' TRACES_DIR/20170316T200041.000000-traces.zip\n'
1127 'Consider including the git config and gitcookies, which we have '
1128 'packed for \nyou at:\n'
1129 ' TRACES_DIR/20170316T200041.000000-git-info.zip\n' % {
1130 'short_hostname': short_hostname,
1131 'change_id': change_id,
1132 'description': final_description,
1133 'title': original_title,
1134 }],),
1135 None,
1136 ),
1137 # Read traces and shorten git hashes.
1138 ((['FileRead', 'TEMP_DIR/trace-packet'],),
1139 ('git-hash: 0123456789012345678901234567890123456789\n'
1140 'git-hash: abcdeabcdeabcdeabcdeabcdeabcdeabcdeabcde\n'),
1141 ),
1142 ((['FileWrite', 'TEMP_DIR/trace-packet',
1143 'git-hash: 012345\n'
1144 'git-hash: abcdea\n'],),
1145 None,
1146 ),
1147 # Make zip file for the git traces.
1148 ((['make_archive', 'TRACES_DIR/20170316T200041.000000-traces', 'zip',
1149 'TEMP_DIR'],),
1150 None,
1151 ),
1152 # Collect git config and gitcookies.
1153 ((['git', 'config', '-l'],),
1154 'git-config-output',
1155 ),
1156 ((['FileWrite', 'TEMP_DIR/git-config', 'git-config-output'],),
1157 None,
1158 ),
1159 ((['FileRead', '~/.gitcookies'],),
1160 'gitcookies 1/SECRET',
1161 ),
1162 ((['FileWrite', 'TEMP_DIR/gitcookies', 'gitcookies REDACTED'],),
1163 None,
1164 ),
1165 # Make zip file for the git config and gitcookies.
1166 ((['make_archive', 'TRACES_DIR/20170316T200041.000000-git-info', 'zip',
1167 'TEMP_DIR'],),
1168 None,
1169 ),
1170 ]
1171
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001172 if squash:
1173 calls += [
tandrii33a46ff2016-08-23 05:53:40 -07001174 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001175 ''),
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001176 ((['git', 'config', 'branch.master.gerritserver',
tandrii5d48c322016-08-18 16:19:37 -07001177 'https://chromium-review.googlesource.com'],), ''),
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001178 ((['git', 'config', 'branch.master.gerritsquashhash',
1179 'abcdef0123456789'],), ''),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001180 ]
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001181 # TODO(crbug/877717): this should never be used.
1182 if squash and short_hostname != 'chromium':
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001183 calls += [
1184 (('AddReviewers',
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00001185 'chromium-review.googlesource.com', 'my%2Frepo~123456',
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001186 sorted(reviewers),
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00001187 cc + ['chromium-reviews+test-more-cc@chromium.org'],
1188 notify),
1189 ''),
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001190 ]
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +00001191 calls += cls._git_post_upload_calls()
ukai@chromium.orge8077812012-02-03 03:41:46 +00001192 return calls
1193
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001194 def _run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001195 self,
1196 upload_args,
1197 description,
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001198 reviewers=None,
tandriia60502f2016-06-20 02:01:53 -07001199 squash=True,
1200 squash_mode=None,
tandrii@chromium.org10625002016-03-04 20:03:47 +00001201 expected_upstream_ref='origin/refs/heads/master',
Aaron Gable9b713dd2016-12-14 16:04:21 -08001202 title=None,
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001203 notify=False,
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001204 post_amend_description=None,
bradnelsond975b302016-10-23 12:20:23 -07001205 issue=None,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +01001206 cc=None,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001207 fetched_status=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001208 other_cl_owner=None,
Aaron Gablefd238082017-06-07 13:42:34 -07001209 custom_cl_base=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001210 tbr=None,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001211 short_hostname='chromium',
Edward Lemurdc8e23d2019-05-07 00:45:48 +00001212 labels=None,
1213 change_id=None,
1214 original_title=None,
1215 final_description=None):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001216 """Generic gerrit upload test framework."""
tandriia60502f2016-06-20 02:01:53 -07001217 if squash_mode is None:
1218 if '--no-squash' in upload_args:
1219 squash_mode = 'nosquash'
1220 elif '--squash' in upload_args:
1221 squash_mode = 'squash'
1222 else:
1223 squash_mode = 'default'
1224
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001225 reviewers = reviewers or []
bradnelsond975b302016-10-23 12:20:23 -07001226 cc = cc or []
tandrii@chromium.org28253532016-04-14 13:46:56 +00001227 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii16e0b4e2016-06-07 10:34:28 -07001228 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001229 CookiesAuthenticatorMockFactory(
1230 same_auth=('git-owner.example.com', '', 'pass')))
tandrii16e0b4e2016-06-07 10:34:28 -07001231 self.mock(git_cl._GerritChangelistImpl, '_GerritCommitMsgHookCheck',
1232 lambda _, offer_removal: None)
tandriia60502f2016-06-20 02:01:53 -07001233 self.mock(git_cl.gclient_utils, 'RunEditor',
1234 lambda *_, **__: self._mocked_call(['RunEditor']))
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001235 self.mock(git_cl, 'DownloadGerritHook', lambda force: self._mocked_call(
1236 'DownloadGerritHook', force))
Edward Lemurdc8e23d2019-05-07 00:45:48 +00001237 self.mock(git_cl.gclient_utils, 'FileRead',
1238 lambda path: self._mocked_call(['FileRead', path]))
1239 self.mock(git_cl.gclient_utils, 'FileWrite',
1240 lambda path, contents: self._mocked_call(
1241 ['FileWrite', path, contents]))
1242 self.mock(git_cl, 'datetime_now',
1243 lambda: datetime.datetime(2017, 3, 16, 20, 0, 41, 0))
1244 self.mock(git_cl.tempfile, 'mkdtemp', lambda: 'TEMP_DIR')
1245 self.mock(git_cl, 'TRACES_DIR', 'TRACES_DIR')
1246 self.mock(git_cl.shutil, 'make_archive',
1247 lambda *args: self._mocked_call(['make_archive'] + list(args)))
tandriia60502f2016-06-20 02:01:53 -07001248
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001249 self.calls = self._gerrit_base_calls(
1250 issue=issue,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001251 fetched_description=description,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001252 fetched_status=fetched_status,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001253 other_cl_owner=other_cl_owner,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001254 custom_cl_base=custom_cl_base,
1255 short_hostname=short_hostname)
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001256 if fetched_status != 'ABANDONED':
Aaron Gable9a03ae02017-11-03 11:31:07 -07001257 self.mock(tempfile, 'NamedTemporaryFile', MakeNamedTemporaryFileMock(
1258 expected_content=description))
1259 self.mock(os, 'remove', lambda _: True)
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001260 self.calls += self._gerrit_upload_calls(
1261 description, reviewers, squash,
1262 squash_mode=squash_mode,
1263 expected_upstream_ref=expected_upstream_ref,
Aaron Gablefd238082017-06-07 13:42:34 -07001264 title=title, notify=notify,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001265 post_amend_description=post_amend_description,
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001266 issue=issue, cc=cc,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001267 custom_cl_base=custom_cl_base, tbr=tbr,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001268 short_hostname=short_hostname,
Edward Lemurdc8e23d2019-05-07 00:45:48 +00001269 labels=labels,
1270 change_id=change_id,
1271 original_title=original_title,
1272 final_description=final_description)
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001273 # Uncomment when debugging.
Raul Tambre80ee78e2019-05-06 22:41:05 +00001274 # print('\n'.join(map(lambda x: '%2i: %s' % x, enumerate(self.calls))))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001275 git_cl.main(['upload'] + upload_args)
1276
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001277 def test_gerrit_upload_without_change_id(self):
tandriia60502f2016-06-20 02:01:53 -07001278 self._run_gerrit_upload_test(
1279 ['--no-squash'],
1280 'desc\n\nBUG=\n',
1281 [],
1282 squash=False,
Edward Lemurdc8e23d2019-05-07 00:45:48 +00001283 post_amend_description='desc\n\nBUG=\n\nChange-Id: Ixxx',
1284 change_id='Ixxx')
tandriia60502f2016-06-20 02:01:53 -07001285
1286 def test_gerrit_upload_without_change_id_override_nosquash(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001287 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001288 [],
jamesr@chromium.org35d1a842012-07-27 00:20:43 +00001289 'desc\n\nBUG=\n',
tandrii@chromium.org10625002016-03-04 20:03:47 +00001290 [],
tandriia60502f2016-06-20 02:01:53 -07001291 squash=False,
1292 squash_mode='override_nosquash',
Edward Lemurdc8e23d2019-05-07 00:45:48 +00001293 post_amend_description='desc\n\nBUG=\n\nChange-Id: Ixxx',
1294 change_id='Ixxx')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001295
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001296 def test_gerrit_no_reviewer(self):
1297 self._run_gerrit_upload_test(
1298 [],
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001299 'desc\n\nBUG=\n\nChange-Id: I123456789\n',
tandriia60502f2016-06-20 02:01:53 -07001300 [],
1301 squash=False,
Edward Lemurdc8e23d2019-05-07 00:45:48 +00001302 squash_mode='override_nosquash',
1303 change_id='I123456789')
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001304
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001305 def test_gerrit_no_reviewer_non_chromium_host(self):
1306 # TODO(crbug/877717): remove this test case.
1307 self._run_gerrit_upload_test(
1308 [],
1309 'desc\n\nBUG=\n\nChange-Id: I123456789\n',
1310 [],
1311 squash=False,
1312 squash_mode='override_nosquash',
Edward Lemurdc8e23d2019-05-07 00:45:48 +00001313 short_hostname='other',
1314 change_id='I123456789')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001315
Nick Carter8692b182017-11-06 16:30:38 -08001316 def test_gerrit_patchset_title_special_chars(self):
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001317 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
1318 self._run_gerrit_upload_test(
Nick Carter8692b182017-11-06 16:30:38 -08001319 ['-f', '-t', 'We\'ll escape ^_ ^ special chars...@{u}'],
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001320 'desc\n\nBUG=\n\nChange-Id: I123456789',
1321 squash=False,
1322 squash_mode='override_nosquash',
Edward Lemurdc8e23d2019-05-07 00:45:48 +00001323 title='We%27ll_escape_%5E%5F_%5E_special_chars%2E%2E%2E%40%7Bu%7D',
1324 change_id='I123456789',
1325 original_title='We\'ll escape ^_ ^ special chars...@{u}')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001326
ukai@chromium.orge8077812012-02-03 03:41:46 +00001327 def test_gerrit_reviewers_cmd_line(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001328 self._run_gerrit_upload_test(
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001329 ['-r', 'foo@example.com', '--send-mail'],
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001330 'desc\n\nBUG=\n\nChange-Id: I123456789',
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001331 ['foo@example.com'],
tandriia60502f2016-06-20 02:01:53 -07001332 squash=False,
1333 squash_mode='override_nosquash',
Edward Lemurdc8e23d2019-05-07 00:45:48 +00001334 notify=True,
1335 change_id='I123456789',
1336 final_description=
1337 'desc\n\nBUG=\nR=foo@example.com\n\nChange-Id: I123456789')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001338
1339 def test_gerrit_reviewer_multiple(self):
Edward Lemur687ca902018-12-05 02:30:30 +00001340 self.mock(git_cl.gerrit_util, 'GetCodeReviewTbrScore',
1341 lambda *a: self._mocked_call('GetCodeReviewTbrScore', *a))
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001342 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001343 [],
bradnelsond975b302016-10-23 12:20:23 -07001344 'desc\nTBR=reviewer@example.com\nBUG=\nR=another@example.com\n'
1345 'CC=more@example.com,people@example.com\n\n'
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001346 'Change-Id: 123456789',
tandriia60502f2016-06-20 02:01:53 -07001347 ['reviewer@example.com', 'another@example.com'],
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001348 expected_upstream_ref='origin/master',
Aaron Gablefd238082017-06-07 13:42:34 -07001349 cc=['more@example.com', 'people@example.com'],
Edward Lemur687ca902018-12-05 02:30:30 +00001350 tbr='reviewer@example.com',
Edward Lemurdc8e23d2019-05-07 00:45:48 +00001351 labels={'Code-Review': 2},
1352 change_id='123456789',
1353 original_title='Initial upload')
tandriia60502f2016-06-20 02:01:53 -07001354
1355 def test_gerrit_upload_squash_first_is_default(self):
tandriia60502f2016-06-20 02:01:53 -07001356 self._run_gerrit_upload_test(
1357 [],
1358 'desc\nBUG=\n\nChange-Id: 123456789',
1359 [],
Edward Lemurdc8e23d2019-05-07 00:45:48 +00001360 expected_upstream_ref='origin/master',
1361 change_id='123456789',
1362 original_title='Initial upload')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001363
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001364 def test_gerrit_upload_squash_first(self):
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001365 self._run_gerrit_upload_test(
1366 ['--squash'],
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001367 'desc\nBUG=\n\nChange-Id: 123456789',
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001368 [],
luqui@chromium.org609f3952015-05-04 22:47:04 +00001369 squash=True,
Edward Lemurdc8e23d2019-05-07 00:45:48 +00001370 expected_upstream_ref='origin/master',
1371 change_id='123456789',
1372 original_title='Initial upload')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001373
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001374 def test_gerrit_upload_squash_first_with_labels(self):
1375 self._run_gerrit_upload_test(
1376 ['--squash', '--cq-dry-run', '--enable-auto-submit'],
1377 'desc\nBUG=\n\nChange-Id: 123456789',
1378 [],
1379 squash=True,
1380 expected_upstream_ref='origin/master',
Edward Lemurdc8e23d2019-05-07 00:45:48 +00001381 labels={'Commit-Queue': 1, 'Auto-Submit': 1},
1382 change_id='123456789',
1383 original_title='Initial upload')
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001384
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001385 def test_gerrit_upload_squash_first_against_rev(self):
1386 custom_cl_base = 'custom_cl_base_rev_or_branch'
1387 self._run_gerrit_upload_test(
1388 ['--squash', custom_cl_base],
1389 'desc\nBUG=\n\nChange-Id: 123456789',
1390 [],
1391 squash=True,
1392 expected_upstream_ref='origin/master',
Edward Lemurdc8e23d2019-05-07 00:45:48 +00001393 custom_cl_base=custom_cl_base,
1394 change_id='123456789',
1395 original_title='Initial upload')
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001396 self.assertIn(
1397 'If you proceed with upload, more than 1 CL may be created by Gerrit',
1398 sys.stdout.getvalue())
1399
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001400 def test_gerrit_upload_squash_reupload(self):
1401 description = 'desc\nBUG=\n\nChange-Id: 123456789'
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001402 self._run_gerrit_upload_test(
1403 ['--squash'],
1404 description,
1405 [],
1406 squash=True,
1407 expected_upstream_ref='origin/master',
Edward Lemurdc8e23d2019-05-07 00:45:48 +00001408 issue=123456,
1409 change_id='123456789',
1410 original_title='User input')
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001411
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001412 def test_gerrit_upload_squash_reupload_to_abandoned(self):
1413 self.mock(git_cl, 'DieWithError',
1414 lambda msg, change=None: self._mocked_call('DieWithError', msg))
1415 description = 'desc\nBUG=\n\nChange-Id: 123456789'
1416 with self.assertRaises(SystemExitMock):
1417 self._run_gerrit_upload_test(
1418 ['--squash'],
1419 description,
1420 [],
1421 squash=True,
1422 expected_upstream_ref='origin/master',
1423 issue=123456,
Edward Lemurdc8e23d2019-05-07 00:45:48 +00001424 fetched_status='ABANDONED',
1425 change_id='123456789')
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001426
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001427 def test_gerrit_upload_squash_reupload_to_not_owned(self):
1428 self.mock(git_cl.gerrit_util, 'GetAccountDetails',
1429 lambda *_, **__: {'email': 'yet-another@example.com'})
1430 description = 'desc\nBUG=\n\nChange-Id: 123456789'
1431 self._run_gerrit_upload_test(
1432 ['--squash'],
1433 description,
1434 [],
1435 squash=True,
1436 expected_upstream_ref='origin/master',
1437 issue=123456,
Edward Lemurdc8e23d2019-05-07 00:45:48 +00001438 other_cl_owner='other@example.com',
1439 change_id='123456789',
1440 original_title='User input')
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001441 self.assertIn(
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001442 'WARNING: Change 123456 is owned by other@example.com, but you '
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001443 'authenticate to Gerrit as yet-another@example.com.\n'
1444 'Uploading may fail due to lack of permissions',
1445 git_cl.sys.stdout.getvalue())
1446
rmistry@google.com2dd99862015-06-22 12:22:18 +00001447 def test_upload_branch_deps(self):
tandrii@chromium.org28253532016-04-14 13:46:56 +00001448 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
rmistry@google.com2dd99862015-06-22 12:22:18 +00001449 def mock_run_git(*args, **_kwargs):
1450 if args[0] == ['for-each-ref',
1451 '--format=%(refname:short) %(upstream:short)',
1452 'refs/heads']:
1453 # Create a local branch dependency tree that looks like this:
1454 # test1 -> test2 -> test3 -> test4 -> test5
1455 # -> test3.1
1456 # test6 -> test0
1457 branch_deps = [
1458 'test2 test1', # test1 -> test2
1459 'test3 test2', # test2 -> test3
1460 'test3.1 test2', # test2 -> test3.1
1461 'test4 test3', # test3 -> test4
1462 'test5 test4', # test4 -> test5
1463 'test6 test0', # test0 -> test6
1464 'test7', # test7
1465 ]
1466 return '\n'.join(branch_deps)
1467 self.mock(git_cl, 'RunGit', mock_run_git)
1468
1469 class RecordCalls:
1470 times_called = 0
1471 record_calls = RecordCalls()
1472 def mock_CMDupload(*args, **_kwargs):
1473 record_calls.times_called += 1
1474 return 0
1475 self.mock(git_cl, 'CMDupload', mock_CMDupload)
1476
1477 self.calls = [
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001478 (('ask_for_data', 'This command will checkout all dependent branches '
1479 'and run "git cl upload". Press Enter to continue, '
1480 'or Ctrl+C to abort'), ''),
1481 ]
rmistry@google.com2dd99862015-06-22 12:22:18 +00001482
1483 class MockChangelist():
1484 def __init__(self):
1485 pass
1486 def GetBranch(self):
1487 return 'test1'
1488 def GetIssue(self):
1489 return '123'
1490 def GetPatchset(self):
1491 return '1001'
tandrii@chromium.org4c72b082016-03-31 22:26:35 +00001492 def IsGerrit(self):
1493 return False
rmistry@google.com2dd99862015-06-22 12:22:18 +00001494
1495 ret = git_cl.upload_branch_deps(MockChangelist(), [])
1496 # CMDupload should have been called 5 times because of 5 dependent branches.
1497 self.assertEquals(5, record_calls.times_called)
1498 self.assertEquals(0, ret)
1499
tandrii@chromium.org65874e12016-03-04 12:03:02 +00001500 def test_gerrit_change_id(self):
1501 self.calls = [
1502 ((['git', 'write-tree'], ),
1503 'hashtree'),
1504 ((['git', 'rev-parse', 'HEAD~0'], ),
1505 'branch-parent'),
1506 ((['git', 'var', 'GIT_AUTHOR_IDENT'], ),
1507 'A B <a@b.org> 1456848326 +0100'),
1508 ((['git', 'var', 'GIT_COMMITTER_IDENT'], ),
1509 'C D <c@d.org> 1456858326 +0100'),
1510 ((['git', 'hash-object', '-t', 'commit', '--stdin'], ),
1511 'hashchange'),
1512 ]
1513 change_id = git_cl.GenerateGerritChangeId('line1\nline2\n')
1514 self.assertEqual(change_id, 'Ihashchange')
1515
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00001516 def test_desecription_append_footer(self):
1517 for init_desc, footer_line, expected_desc in [
1518 # Use unique desc first lines for easy test failure identification.
1519 ('foo', 'R=one', 'foo\n\nR=one'),
1520 ('foo\n\nR=one', 'BUG=', 'foo\n\nR=one\nBUG='),
1521 ('foo\n\nR=one', 'Change-Id: Ixx', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1522 ('foo\n\nChange-Id: Ixx', 'R=one', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1523 ('foo\n\nR=one\n\nChange-Id: Ixx', 'TBR=two',
1524 'foo\n\nR=one\nTBR=two\n\nChange-Id: Ixx'),
1525 ('foo\n\nR=one\n\nChange-Id: Ixx', 'Foo-Bar: baz',
1526 'foo\n\nR=one\n\nChange-Id: Ixx\nFoo-Bar: baz'),
1527 ('foo\n\nChange-Id: Ixx', 'Foo-Bak: baz',
1528 'foo\n\nChange-Id: Ixx\nFoo-Bak: baz'),
1529 ('foo', 'Change-Id: Ixx', 'foo\n\nChange-Id: Ixx'),
1530 ]:
1531 desc = git_cl.ChangeDescription(init_desc)
1532 desc.append_footer(footer_line)
1533 self.assertEqual(desc.description, expected_desc)
1534
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001535 def test_update_reviewers(self):
1536 data = [
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001537 ('foo', [], [],
1538 'foo'),
1539 ('foo\nR=xx', [], [],
1540 'foo\nR=xx'),
1541 ('foo\nTBR=xx', [], [],
1542 'foo\nTBR=xx'),
1543 ('foo', ['a@c'], [],
1544 'foo\n\nR=a@c'),
1545 ('foo\nR=xx', ['a@c'], [],
1546 'foo\n\nR=a@c, xx'),
1547 ('foo\nTBR=xx', ['a@c'], [],
1548 'foo\n\nR=a@c\nTBR=xx'),
1549 ('foo\nTBR=xx\nR=yy', ['a@c'], [],
1550 'foo\n\nR=a@c, yy\nTBR=xx'),
1551 ('foo\nBUG=', ['a@c'], [],
1552 'foo\nBUG=\nR=a@c'),
1553 ('foo\nR=xx\nTBR=yy\nR=bar', ['a@c'], [],
1554 'foo\n\nR=a@c, bar, xx\nTBR=yy'),
1555 ('foo', ['a@c', 'b@c'], [],
1556 'foo\n\nR=a@c, b@c'),
1557 ('foo\nBar\n\nR=\nBUG=', ['c@c'], [],
1558 'foo\nBar\n\nR=c@c\nBUG='),
1559 ('foo\nBar\n\nR=\nBUG=\nR=', ['c@c'], [],
1560 'foo\nBar\n\nR=c@c\nBUG='),
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001561 # Same as the line before, but full of whitespaces.
1562 (
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001563 'foo\nBar\n\n R = \n BUG = \n R = ', ['c@c'], [],
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001564 'foo\nBar\n\nR=c@c\n BUG =',
1565 ),
1566 # Whitespaces aren't interpreted as new lines.
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001567 ('foo BUG=allo R=joe ', ['c@c'], [],
1568 'foo BUG=allo R=joe\n\nR=c@c'),
1569 # Redundant TBRs get promoted to Rs
1570 ('foo\n\nR=a@c\nTBR=t@c', ['b@c', 'a@c'], ['a@c', 't@c'],
1571 'foo\n\nR=a@c, b@c\nTBR=t@c'),
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001572 ]
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001573 expected = [i[-1] for i in data]
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001574 actual = []
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001575 for orig, reviewers, tbrs, _expected in data:
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001576 obj = git_cl.ChangeDescription(orig)
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001577 obj.update_reviewers(reviewers, tbrs)
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001578 actual.append(obj.description)
1579 self.assertEqual(expected, actual)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001580
Nodir Turakulov23b82142017-11-16 11:04:25 -08001581 def test_get_hash_tags(self):
1582 cases = [
1583 ('', []),
1584 ('a', []),
1585 ('[a]', ['a']),
1586 ('[aa]', ['aa']),
1587 ('[a ]', ['a']),
1588 ('[a- ]', ['a']),
1589 ('[a- b]', ['a-b']),
1590 ('[a--b]', ['a-b']),
1591 ('[a', []),
1592 ('[a]x', ['a']),
1593 ('[aa]x', ['aa']),
1594 ('[a b]', ['a-b']),
1595 ('[a b]', ['a-b']),
1596 ('[a__b]', ['a-b']),
1597 ('[a] x', ['a']),
1598 ('[a][b]', ['a', 'b']),
1599 ('[a] [b]', ['a', 'b']),
1600 ('[a][b]x', ['a', 'b']),
1601 ('[a][b] x', ['a', 'b']),
1602 ('[a]\n[b]', ['a']),
1603 ('[a\nb]', []),
1604 ('[a][', ['a']),
1605 ('Revert "[a] feature"', ['a']),
1606 ('Reland "[a] feature"', ['a']),
1607 ('Revert: [a] feature', ['a']),
1608 ('Reland: [a] feature', ['a']),
1609 ('Revert "Reland: [a] feature"', ['a']),
1610 ('Foo: feature', ['foo']),
1611 ('Foo Bar: feature', ['foo-bar']),
1612 ('Revert "Foo bar: feature"', ['foo-bar']),
1613 ('Reland "Foo bar: feature"', ['foo-bar']),
1614 ]
1615 for desc, expected in cases:
1616 change_desc = git_cl.ChangeDescription(desc)
1617 actual = change_desc.get_hash_tags()
1618 self.assertEqual(
1619 actual,
1620 expected,
1621 'GetHashTags(%r) == %r, expected %r' % (desc, actual, expected))
1622
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001623
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001624 self.assertEqual(None, git_cl.GetTargetRef('origin', None, 'master'))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001625 self.assertEqual(None, git_cl.GetTargetRef(None,
1626 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001627 'master'))
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001628
wittman@chromium.org455dc922015-01-26 20:15:50 +00001629 # Check default target refs for branches.
1630 self.assertEqual('refs/heads/master',
1631 git_cl.GetTargetRef('origin', 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001632 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001633 self.assertEqual('refs/heads/master',
1634 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkgr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001635 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001636 self.assertEqual('refs/heads/master',
1637 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkcr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001638 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001639 self.assertEqual('refs/branch-heads/123',
1640 git_cl.GetTargetRef('origin',
1641 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001642 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001643 self.assertEqual('refs/diff/test',
1644 git_cl.GetTargetRef('origin',
1645 'refs/remotes/origin/refs/diff/test',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001646 None))
rmistry@google.comc68112d2015-03-03 12:48:06 +00001647 self.assertEqual('refs/heads/chrome/m42',
1648 git_cl.GetTargetRef('origin',
1649 'refs/remotes/origin/chrome/m42',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001650 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001651
1652 # Check target refs for user-specified target branch.
1653 for branch in ('branch-heads/123', 'remotes/branch-heads/123',
1654 'refs/remotes/branch-heads/123'):
1655 self.assertEqual('refs/branch-heads/123',
1656 git_cl.GetTargetRef('origin',
1657 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001658 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001659 for branch in ('origin/master', 'remotes/origin/master',
1660 'refs/remotes/origin/master'):
1661 self.assertEqual('refs/heads/master',
1662 git_cl.GetTargetRef('origin',
1663 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001664 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001665 for branch in ('master', 'heads/master', 'refs/heads/master'):
1666 self.assertEqual('refs/heads/master',
1667 git_cl.GetTargetRef('origin',
1668 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001669 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001670
wychen@chromium.orga872e752015-04-28 23:42:18 +00001671 def test_patch_when_dirty(self):
1672 # Patch when local tree is dirty
1673 self.mock(git_common, 'is_dirty_git_tree', lambda x: True)
1674 self.assertNotEqual(git_cl.main(['patch', '123456']), 0)
1675
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001676 @staticmethod
1677 def _get_gerrit_codereview_server_calls(branch, value=None,
1678 git_short_host='host',
Aaron Gable697a91b2018-01-19 15:20:15 -08001679 detect_branch=True,
1680 detect_server=True):
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001681 """Returns calls executed by _GerritChangelistImpl.GetCodereviewServer.
1682
1683 If value is given, branch.<BRANCH>.gerritcodereview is already set.
1684 """
1685 calls = []
1686 if detect_branch:
1687 calls.append(((['git', 'symbolic-ref', 'HEAD'],), branch))
Aaron Gable697a91b2018-01-19 15:20:15 -08001688 if detect_server:
1689 calls.append(((['git', 'config', 'branch.' + branch + '.gerritserver'],),
1690 CERR1 if value is None else value))
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001691 if value is None:
1692 calls += [
1693 ((['git', 'config', 'branch.' + branch + '.merge'],),
1694 'refs/heads' + branch),
1695 ((['git', 'config', 'branch.' + branch + '.remote'],),
1696 'origin'),
1697 ((['git', 'config', 'remote.origin.url'],),
1698 'https://%s.googlesource.com/my/repo' % git_short_host),
1699 ]
1700 return calls
1701
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001702 def _patch_common(self, force_codereview=False,
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001703 new_branch=False, git_short_host='host',
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001704 detect_gerrit_server=False,
1705 actual_codereview=None,
1706 codereview_in_url=False):
tandrii@chromium.org28253532016-04-14 13:46:56 +00001707 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
wychen@chromium.orga872e752015-04-28 23:42:18 +00001708 self.mock(git_cl, 'IsGitVersionAtLeast', lambda *args: True)
1709
tandriidf09a462016-08-18 16:23:55 -07001710 if new_branch:
1711 self.calls = [((['git', 'new-branch', 'master'],), ''),]
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001712
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001713 if codereview_in_url and actual_codereview == 'rietveld':
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001714 self.calls += [
1715 ((['git', 'rev-parse', '--show-cdup'],), ''),
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001716 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001717 ]
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001718
1719 if not force_codereview and not codereview_in_url:
1720 # These calls detect codereview to use.
1721 self.calls += [
1722 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001723 ((['git', 'config', 'branch.master.gerritissue'],), CERR1),
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001724 ]
1725 if detect_gerrit_server:
1726 self.calls += self._get_gerrit_codereview_server_calls(
1727 'master', git_short_host=git_short_host,
1728 detect_branch=not new_branch and force_codereview)
1729 actual_codereview = 'gerrit'
1730
1731 if actual_codereview == 'gerrit':
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001732 self.calls += [
1733 (('GetChangeDetail', git_short_host + '-review.googlesource.com',
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001734 'my%2Frepo~123456', ['ALL_REVISIONS', 'CURRENT_COMMIT']),
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001735 {
1736 'current_revision': '7777777777',
1737 'revisions': {
1738 '1111111111': {
1739 '_number': 1,
1740 'fetch': {'http': {
1741 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1742 'ref': 'refs/changes/56/123456/1',
1743 }},
1744 },
1745 '7777777777': {
1746 '_number': 7,
1747 'fetch': {'http': {
1748 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1749 'ref': 'refs/changes/56/123456/7',
1750 }},
1751 },
1752 },
1753 }),
1754 ]
wychen@chromium.orga872e752015-04-28 23:42:18 +00001755
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001756 def test_patch_gerrit_default(self):
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001757 self._patch_common(git_short_host='chromium', detect_gerrit_server=True)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001758 self.calls += [
1759 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1760 'refs/changes/56/123456/7'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001761 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001762 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
Aaron Gable697a91b2018-01-19 15:20:15 -08001763 ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001764 ((['git', 'config', 'branch.master.gerritserver',
1765 'https://chromium-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001766 ((['git', 'config', 'branch.master.gerritpatchset', '7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001767 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1768 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1769 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001770 ]
1771 self.assertEqual(git_cl.main(['patch', '123456']), 0)
1772
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001773 def test_patch_gerrit_new_branch(self):
1774 self._patch_common(
1775 git_short_host='chromium', detect_gerrit_server=True, new_branch=True)
1776 self.calls += [
1777 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1778 'refs/changes/56/123456/7'],), ''),
1779 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
1780 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
1781 ''),
1782 ((['git', 'config', 'branch.master.gerritserver',
1783 'https://chromium-review.googlesource.com'],), ''),
1784 ((['git', 'config', 'branch.master.gerritpatchset', '7'],), ''),
1785 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1786 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1787 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
1788 ]
1789 self.assertEqual(git_cl.main(['patch', '-b', 'master', '123456']), 0)
1790
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001791 def test_patch_gerrit_force(self):
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001792 self._patch_common(
1793 force_codereview=True, git_short_host='host', detect_gerrit_server=True)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001794 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001795 ((['git', 'fetch', 'https://host.googlesource.com/my/repo',
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001796 'refs/changes/56/123456/7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001797 ((['git', 'reset', '--hard', 'FETCH_HEAD'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001798 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001799 ''),
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001800 ((['git', 'config', 'branch.master.gerritserver',
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001801 'https://host-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001802 ((['git', 'config', 'branch.master.gerritpatchset', '7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001803 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1804 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1805 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001806 ]
Aaron Gable62619a32017-06-16 08:22:09 -07001807 self.assertEqual(git_cl.main(['patch', '--gerrit', '123456', '--force']), 0)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001808
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001809 def test_patch_gerrit_guess_by_url(self):
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001810 self.calls += self._get_gerrit_codereview_server_calls(
1811 'master', git_short_host='else', detect_server=False)
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001812 self._patch_common(
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001813 actual_codereview='gerrit', git_short_host='else',
1814 codereview_in_url=True, detect_gerrit_server=False)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001815 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001816 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001817 'refs/changes/56/123456/1'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001818 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001819 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001820 ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001821 ((['git', 'config', 'branch.master.gerritserver',
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001822 'https://else-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001823 ((['git', 'config', 'branch.master.gerritpatchset', '1'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001824 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1825 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1826 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001827 ]
1828 self.assertEqual(git_cl.main(
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001829 ['patch', 'https://else-review.googlesource.com/#/c/123456/1']), 0)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001830
Aaron Gable697a91b2018-01-19 15:20:15 -08001831 def test_patch_gerrit_guess_by_url_with_repo(self):
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001832 self.calls += self._get_gerrit_codereview_server_calls(
1833 'master', git_short_host='else', detect_server=False)
Aaron Gable697a91b2018-01-19 15:20:15 -08001834 self._patch_common(
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001835 actual_codereview='gerrit', git_short_host='else',
1836 codereview_in_url=True, detect_gerrit_server=False)
Aaron Gable697a91b2018-01-19 15:20:15 -08001837 self.calls += [
1838 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
1839 'refs/changes/56/123456/1'],), ''),
1840 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
1841 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
1842 ''),
1843 ((['git', 'config', 'branch.master.gerritserver',
1844 'https://else-review.googlesource.com'],), ''),
1845 ((['git', 'config', 'branch.master.gerritpatchset', '1'],), ''),
1846 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1847 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1848 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
1849 ]
1850 self.assertEqual(git_cl.main(
1851 ['patch', 'https://else-review.googlesource.com/c/my/repo/+/123456/1']),
1852 0)
1853
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001854 def test_patch_gerrit_conflict(self):
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001855 self._patch_common(detect_gerrit_server=True, git_short_host='chromium')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001856 self.calls += [
1857 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001858 'refs/changes/56/123456/7'],), ''),
tandrii5d48c322016-08-18 16:19:37 -07001859 ((['git', 'cherry-pick', 'FETCH_HEAD'],), CERR1),
1860 ((['DieWithError', 'Command "git cherry-pick FETCH_HEAD" failed.\n'],),
1861 SystemExitMock()),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001862 ]
1863 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001864 git_cl.main(['patch', '123456'])
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001865
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001866 def test_patch_gerrit_not_exists(self):
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01001867 def notExists(_issue, *_, **kwargs):
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01001868 raise git_cl.gerrit_util.GerritError(404, '')
1869 self.mock(git_cl.gerrit_util, 'GetChangeDetail', notExists)
1870
tandriic2405f52016-10-10 08:13:15 -07001871 self.calls = [
1872 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
tandriic2405f52016-10-10 08:13:15 -07001873 ((['git', 'config', 'branch.master.gerritissue'],), CERR1),
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001874 ((['git', 'config', 'branch.master.gerritserver'],), CERR1),
1875 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
1876 ((['git', 'config', 'branch.master.remote'],), 'origin'),
1877 ((['git', 'config', 'remote.origin.url'],),
1878 'https://chromium.googlesource.com/my/repo'),
1879 ((['DieWithError',
1880 'change 123456 at https://chromium-review.googlesource.com does not '
1881 'exist or you have no access to it'],), SystemExitMock()),
tandriic2405f52016-10-10 08:13:15 -07001882 ]
1883 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001884 self.assertEqual(1, git_cl.main(['patch', '123456']))
tandriic2405f52016-10-10 08:13:15 -07001885
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001886 def _checkout_calls(self):
1887 return [
1888 ((['git', 'config', '--local', '--get-regexp',
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001889 'branch\\..*\\.gerritissue'], ),
1890 ('branch.ger-branch.gerritissue 123456\n'
1891 'branch.gbranch654.gerritissue 654321\n')),
1892 ]
1893
1894 def test_checkout_gerrit(self):
1895 """Tests git cl checkout <issue>."""
1896 self.calls = self._checkout_calls()
1897 self.calls += [((['git', 'checkout', 'ger-branch'], ), '')]
1898 self.assertEqual(0, git_cl.main(['checkout', '123456']))
1899
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001900 def test_checkout_not_found(self):
1901 """Tests git cl checkout <issue>."""
tandrii@chromium.org28253532016-04-14 13:46:56 +00001902 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001903 self.calls = self._checkout_calls()
1904 self.assertEqual(1, git_cl.main(['checkout', '99999']))
1905
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001906 def test_checkout_no_branch_issues(self):
1907 """Tests git cl checkout <issue>."""
tandrii@chromium.org28253532016-04-14 13:46:56 +00001908 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001909 self.calls = [
1910 ((['git', 'config', '--local', '--get-regexp',
tandrii5d48c322016-08-18 16:19:37 -07001911 'branch\\..*\\.gerritissue'], ), CERR1),
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001912 ]
1913 self.assertEqual(1, git_cl.main(['checkout', '99999']))
1914
tandrii@chromium.org28253532016-04-14 13:46:56 +00001915 def _test_gerrit_ensure_authenticated_common(self, auth,
1916 skip_auth_check=False):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001917 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
1918 CookiesAuthenticatorMockFactory(hosts_with_creds=auth))
1919 self.mock(git_cl, 'DieWithError',
Christopher Lamf732cd52017-01-24 12:40:11 +11001920 lambda msg, change=None: self._mocked_call(['DieWithError', msg]))
tandrii@chromium.org28253532016-04-14 13:46:56 +00001921 self.calls = self._gerrit_ensure_auth_calls(skip_auth_check=skip_auth_check)
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001922 cl = git_cl.Changelist(codereview='gerrit')
tandrii@chromium.org28253532016-04-14 13:46:56 +00001923 cl.branch = 'master'
1924 cl.branchref = 'refs/heads/master'
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001925 cl.lookedup_issue = True
1926 return cl
1927
1928 def test_gerrit_ensure_authenticated_missing(self):
1929 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001930 'chromium.googlesource.com': ('git-is.ok', '', 'but gerrit is missing'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001931 })
1932 self.calls.append(
1933 ((['DieWithError',
1934 'Credentials for the following hosts are required:\n'
1935 ' chromium-review.googlesource.com\n'
1936 'These are read from ~/.gitcookies (or legacy ~/.netrc)\n'
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01001937 'You can (re)generate your credentials by visiting '
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001938 'https://chromium-review.googlesource.com/new-password'],), ''),)
1939 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1940
1941 def test_gerrit_ensure_authenticated_conflict(self):
tandrii@chromium.org28253532016-04-14 13:46:56 +00001942 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001943 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001944 'chromium.googlesource.com':
1945 ('git-one.example.com', None, 'secret1'),
1946 'chromium-review.googlesource.com':
1947 ('git-other.example.com', None, 'secret2'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001948 })
1949 self.calls.append(
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001950 (('ask_for_data', 'If you know what you are doing '
1951 'press Enter to continue, or Ctrl+C to abort'), ''))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001952 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1953
1954 def test_gerrit_ensure_authenticated_ok(self):
1955 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001956 'chromium.googlesource.com':
1957 ('git-same.example.com', None, 'secret'),
1958 'chromium-review.googlesource.com':
1959 ('git-same.example.com', None, 'secret'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001960 })
1961 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1962
tandrii@chromium.org28253532016-04-14 13:46:56 +00001963 def test_gerrit_ensure_authenticated_skipped(self):
1964 cl = self._test_gerrit_ensure_authenticated_common(
1965 auth={}, skip_auth_check=True)
1966 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1967
Eric Boren2fb63102018-10-05 13:05:03 +00001968 def test_gerrit_ensure_authenticated_bearer_token(self):
1969 cl = self._test_gerrit_ensure_authenticated_common(auth={
1970 'chromium.googlesource.com':
1971 ('', None, 'secret'),
1972 'chromium-review.googlesource.com':
1973 ('', None, 'secret'),
1974 })
1975 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1976 header = gerrit_util.CookiesAuthenticator().get_auth_header(
1977 'chromium.googlesource.com')
1978 self.assertTrue('Bearer' in header)
1979
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01001980 def _cmd_set_commit_gerrit_common(self, vote, notify=None):
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001981 self.mock(git_cl.gerrit_util, 'SetReview',
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01001982 lambda h, i, labels, notify=None:
1983 self._mocked_call(['SetReview', h, i, labels, notify]))
1984
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001985 self.calls = [
1986 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07001987 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001988 ((['git', 'config', 'branch.feature.gerritserver'],),
1989 'https://chromium-review.googlesource.com'),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00001990 ((['git', 'config', 'branch.feature.merge'],), 'refs/heads/master'),
1991 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
1992 ((['git', 'config', 'remote.origin.url'],),
1993 'https://chromium.googlesource.com/infra/infra.git'),
1994 ((['SetReview', 'chromium-review.googlesource.com',
1995 'infra%2Finfra~123',
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01001996 {'Commit-Queue': vote}, notify],), ''),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001997 ]
tandriid9e5ce52016-07-13 02:32:59 -07001998
1999 def test_cmd_set_commit_gerrit_clear(self):
2000 self._cmd_set_commit_gerrit_common(0)
2001 self.assertEqual(0, git_cl.main(['set-commit', '-c']))
2002
2003 def test_cmd_set_commit_gerrit_dry(self):
Aaron Gable75e78722017-06-09 10:40:16 -07002004 self._cmd_set_commit_gerrit_common(1, notify=False)
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002005 self.assertEqual(0, git_cl.main(['set-commit', '-d']))
2006
tandriid9e5ce52016-07-13 02:32:59 -07002007 def test_cmd_set_commit_gerrit(self):
2008 self._cmd_set_commit_gerrit_common(2)
2009 self.assertEqual(0, git_cl.main(['set-commit']))
2010
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002011 def test_description_display(self):
2012 out = StringIO.StringIO()
2013 self.mock(git_cl.sys, 'stdout', out)
2014
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002015 self.mock(git_cl, 'Changelist', ChangelistMock)
2016 ChangelistMock.desc = 'foo\n'
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002017
2018 self.assertEqual(0, git_cl.main(['description', '-d']))
2019 self.assertEqual('foo\n', out.getvalue())
2020
iannucci3c972b92016-08-17 13:24:10 -07002021 def test_StatusFieldOverrideIssueMissingArgs(self):
2022 out = StringIO.StringIO()
2023 self.mock(git_cl.sys, 'stderr', out)
2024
2025 try:
2026 self.assertEqual(git_cl.main(['status', '--issue', '1']), 0)
2027 except SystemExit as ex:
2028 self.assertEqual(ex.code, 2)
iannuccie53c9352016-08-17 14:40:40 -07002029 self.assertRegexpMatches(out.getvalue(), r'--issue must be specified')
iannucci3c972b92016-08-17 13:24:10 -07002030
2031 out = StringIO.StringIO()
2032 self.mock(git_cl.sys, 'stderr', out)
2033
2034 try:
Andrii Shyshkalovfeec80e2018-10-16 01:00:47 +00002035 self.assertEqual(git_cl.main(['status', '--issue', '1', '--gerrit']), 0)
iannucci3c972b92016-08-17 13:24:10 -07002036 except SystemExit as ex:
2037 self.assertEqual(ex.code, 2)
iannuccie53c9352016-08-17 14:40:40 -07002038 self.assertRegexpMatches(out.getvalue(), r'--field must be specified')
iannucci3c972b92016-08-17 13:24:10 -07002039
2040 def test_StatusFieldOverrideIssue(self):
2041 out = StringIO.StringIO()
2042 self.mock(git_cl.sys, 'stdout', out)
2043
2044 def assertIssue(cl_self, *_args):
2045 self.assertEquals(cl_self.issue, 1)
2046 return 'foobar'
2047
2048 self.mock(git_cl.Changelist, 'GetDescription', assertIssue)
iannuccie53c9352016-08-17 14:40:40 -07002049 self.assertEqual(
Andrii Shyshkalovfeec80e2018-10-16 01:00:47 +00002050 git_cl.main(['status', '--issue', '1', '--gerrit', '--field', 'desc']),
iannuccie53c9352016-08-17 14:40:40 -07002051 0)
iannucci3c972b92016-08-17 13:24:10 -07002052 self.assertEqual(out.getvalue(), 'foobar\n')
2053
iannuccie53c9352016-08-17 14:40:40 -07002054 def test_SetCloseOverrideIssue(self):
2055 def assertIssue(cl_self, *_args):
2056 self.assertEquals(cl_self.issue, 1)
2057 return 'foobar'
2058
2059 self.mock(git_cl.Changelist, 'GetDescription', assertIssue)
2060 self.mock(git_cl.Changelist, 'CloseIssue', lambda *_: None)
iannuccie53c9352016-08-17 14:40:40 -07002061 self.assertEqual(
Andrii Shyshkalovfeec80e2018-10-16 01:00:47 +00002062 git_cl.main(['set-close', '--issue', '1', '--gerrit']), 0)
iannuccie53c9352016-08-17 14:40:40 -07002063
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00002064 def test_description(self):
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002065 out = StringIO.StringIO()
2066 self.mock(git_cl.sys, 'stdout', out)
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01002067 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002068 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2069 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2070 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2071 ((['git', 'config', 'remote.origin.url'],),
2072 'https://chromium.googlesource.com/my/repo'),
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00002073 (('GetChangeDetail', 'chromium-review.googlesource.com',
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002074 'my%2Frepo~123123', ['CURRENT_REVISION', 'CURRENT_COMMIT']),
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01002075 {
2076 'current_revision': 'sha1',
2077 'revisions': {'sha1': {
2078 'commit': {'message': 'foobar'},
2079 }},
2080 }),
2081 ]
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002082 self.assertEqual(0, git_cl.main([
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00002083 'description',
2084 'https://chromium-review.googlesource.com/c/my/repo/+/123123',
2085 '-d']))
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002086 self.assertEqual('foobar\n', out.getvalue())
2087
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002088 def test_description_set_raw(self):
2089 out = StringIO.StringIO()
2090 self.mock(git_cl.sys, 'stdout', out)
2091
2092 self.mock(git_cl, 'Changelist', ChangelistMock)
2093 self.mock(git_cl.sys, 'stdin', StringIO.StringIO('hihi'))
2094
2095 self.assertEqual(0, git_cl.main(['description', '-n', 'hihi']))
2096 self.assertEqual('hihi', ChangelistMock.desc)
2097
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002098 def test_description_appends_bug_line(self):
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002099 current_desc = 'Some.\n\nChange-Id: xxx'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002100
2101 def RunEditor(desc, _, **kwargs):
2102 self.assertEquals(
2103 '# Enter a description of the change.\n'
2104 '# This will be displayed on the codereview site.\n'
2105 '# The first line will also be used as the subject of the review.\n'
2106 '#--------------------This line is 72 characters long'
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002107 '--------------------\n'
Aaron Gable3a16ed12017-03-23 10:51:55 -07002108 'Some.\n\nChange-Id: xxx\nBug: ',
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002109 desc)
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002110 # Simulate user changing something.
Aaron Gable3a16ed12017-03-23 10:51:55 -07002111 return 'Some.\n\nChange-Id: xxx\nBug: 123'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002112
dsansomee2d6fd92016-09-08 00:10:47 -07002113 def UpdateDescriptionRemote(_, desc, force=False):
Aaron Gable3a16ed12017-03-23 10:51:55 -07002114 self.assertEquals(desc, 'Some.\n\nChange-Id: xxx\nBug: 123')
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002115
2116 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2117 self.mock(git_cl.Changelist, 'GetDescription',
2118 lambda *args: current_desc)
2119 self.mock(git_cl._GerritChangelistImpl, 'UpdateDescriptionRemote',
2120 UpdateDescriptionRemote)
2121 self.mock(git_cl.gclient_utils, 'RunEditor', RunEditor)
2122
2123 self.calls = [
2124 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07002125 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
tandrii5d48c322016-08-18 16:19:37 -07002126 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
2127 ((['git', 'config', 'rietveld.bug-prefix'],), CERR1),
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002128 ((['git', 'config', 'core.editor'],), 'vi'),
2129 ]
2130 self.assertEqual(0, git_cl.main(['description', '--gerrit']))
2131
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002132 def test_description_set_stdin(self):
2133 out = StringIO.StringIO()
2134 self.mock(git_cl.sys, 'stdout', out)
2135
2136 self.mock(git_cl, 'Changelist', ChangelistMock)
2137 self.mock(git_cl.sys, 'stdin', StringIO.StringIO('hi \r\n\t there\n\nman'))
2138
2139 self.assertEqual(0, git_cl.main(['description', '-n', '-']))
2140 self.assertEqual('hi\n\t there\n\nman', ChangelistMock.desc)
2141
kmarshall3bff56b2016-06-06 18:31:47 -07002142 def test_archive(self):
tandrii1c67da62016-06-10 07:35:53 -07002143 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2144
kmarshall3bff56b2016-06-06 18:31:47 -07002145 self.calls = \
2146 [((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2147 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002148 ((['git', 'config', 'branch.master.gerritissue'],), '456'),
2149 ((['git', 'config', 'branch.foo.gerritissue'],), CERR1),
tandrii33a46ff2016-08-23 05:53:40 -07002150 ((['git', 'config', 'branch.bar.gerritissue'],), '789'),
kmarshall3bff56b2016-06-06 18:31:47 -07002151 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2152 ((['git', 'tag', 'git-cl-archived-456-foo', 'foo'],), ''),
2153 ((['git', 'branch', '-D', 'foo'],), '')]
2154
kmarshall3bff56b2016-06-06 18:31:47 -07002155 self.mock(git_cl, 'get_cl_statuses',
2156 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002157 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2158 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2159 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
kmarshall3bff56b2016-06-06 18:31:47 -07002160
2161 self.assertEqual(0, git_cl.main(['archive', '-f']))
2162
2163 def test_archive_current_branch_fails(self):
tandrii1c67da62016-06-10 07:35:53 -07002164 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
kmarshall3bff56b2016-06-06 18:31:47 -07002165 self.calls = \
2166 [((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2167 'refs/heads/master'),
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002168 ((['git', 'config', 'branch.master.gerritissue'],), '1'),
kmarshall3bff56b2016-06-06 18:31:47 -07002169 ((['git', 'symbolic-ref', 'HEAD'],), 'master')]
2170
kmarshall9249e012016-08-23 12:02:16 -07002171 self.mock(git_cl, 'get_cl_statuses',
2172 lambda branches, fine_grained, max_processes:
2173 [(MockChangelistWithBranchAndIssue('master', 1), 'closed')])
2174
2175 self.assertEqual(1, git_cl.main(['archive', '-f']))
2176
2177 def test_archive_dry_run(self):
2178 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2179
2180 self.calls = \
2181 [((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2182 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002183 ((['git', 'config', 'branch.master.gerritissue'],), '456'),
2184 ((['git', 'config', 'branch.foo.gerritissue'],), CERR1),
kmarshall9249e012016-08-23 12:02:16 -07002185 ((['git', 'config', 'branch.bar.gerritissue'],), '789'),
2186 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),]
kmarshall3bff56b2016-06-06 18:31:47 -07002187
2188 self.mock(git_cl, 'get_cl_statuses',
2189 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002190 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2191 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2192 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
kmarshall3bff56b2016-06-06 18:31:47 -07002193
kmarshall9249e012016-08-23 12:02:16 -07002194 self.assertEqual(0, git_cl.main(['archive', '-f', '--dry-run']))
2195
2196 def test_archive_no_tags(self):
2197 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2198
2199 self.calls = \
2200 [((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2201 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002202 ((['git', 'config', 'branch.master.gerritissue'],), '1'),
2203 ((['git', 'config', 'branch.foo.gerritissue'],), '456'),
2204 ((['git', 'config', 'branch.bar.gerritissue'],), CERR1),
kmarshall9249e012016-08-23 12:02:16 -07002205 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2206 ((['git', 'branch', '-D', 'foo'],), '')]
2207
2208 self.mock(git_cl, 'get_cl_statuses',
2209 lambda branches, fine_grained, max_processes:
2210 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2211 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2212 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
2213
2214 self.assertEqual(0, git_cl.main(['archive', '-f', '--notags']))
kmarshall3bff56b2016-06-06 18:31:47 -07002215
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002216 def test_cmd_issue_erase_existing(self):
2217 out = StringIO.StringIO()
2218 self.mock(git_cl.sys, 'stdout', out)
2219 self.calls = [
2220 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07002221 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002222 # Let this command raise exception (retcode=1) - it should be ignored.
2223 ((['git', 'config', '--unset', 'branch.feature.last-upload-hash'],),
tandrii5d48c322016-08-18 16:19:37 -07002224 CERR1),
2225 ((['git', 'config', '--unset', 'branch.feature.gerritissue'],), ''),
2226 ((['git', 'config', '--unset', 'branch.feature.gerritpatchset'],), ''),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002227 ((['git', 'config', '--unset', 'branch.feature.gerritserver'],), ''),
2228 ((['git', 'config', '--unset', 'branch.feature.gerritsquashhash'],),
2229 ''),
Aaron Gableca01e2c2017-07-19 11:16:02 -07002230 ((['git', 'log', '-1', '--format=%B'],), 'This is a description'),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002231 ]
2232 self.assertEqual(0, git_cl.main(['issue', '0']))
2233
Aaron Gable400e9892017-07-12 15:31:21 -07002234 def test_cmd_issue_erase_existing_with_change_id(self):
2235 out = StringIO.StringIO()
2236 self.mock(git_cl.sys, 'stdout', out)
2237 self.mock(git_cl.Changelist, 'GetDescription',
2238 lambda _: 'This is a description\n\nChange-Id: Ideadbeef')
2239 self.calls = [
2240 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
Aaron Gable400e9892017-07-12 15:31:21 -07002241 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
Aaron Gable400e9892017-07-12 15:31:21 -07002242 # Let this command raise exception (retcode=1) - it should be ignored.
2243 ((['git', 'config', '--unset', 'branch.feature.last-upload-hash'],),
2244 CERR1),
2245 ((['git', 'config', '--unset', 'branch.feature.gerritissue'],), ''),
2246 ((['git', 'config', '--unset', 'branch.feature.gerritpatchset'],), ''),
2247 ((['git', 'config', '--unset', 'branch.feature.gerritserver'],), ''),
2248 ((['git', 'config', '--unset', 'branch.feature.gerritsquashhash'],),
2249 ''),
Aaron Gableca01e2c2017-07-19 11:16:02 -07002250 ((['git', 'log', '-1', '--format=%B'],),
2251 'This is a description\n\nChange-Id: Ideadbeef'),
2252 ((['git', 'commit', '--amend', '-m', 'This is a description\n'],), ''),
Aaron Gable400e9892017-07-12 15:31:21 -07002253 ]
2254 self.assertEqual(0, git_cl.main(['issue', '0']))
2255
phajdan.jre328cf92016-08-22 04:12:17 -07002256 def test_cmd_issue_json(self):
2257 out = StringIO.StringIO()
2258 self.mock(git_cl.sys, 'stdout', out)
2259 self.calls = [
2260 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002261 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
2262 ((['git', 'config', 'branch.feature.gerritserver'],),
2263 'https://chromium-review.googlesource.com'),
phajdan.jre328cf92016-08-22 04:12:17 -07002264 (('write_json', 'output.json',
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002265 {'issue': 123,
2266 'issue_url': 'https://chromium-review.googlesource.com/123'}),
phajdan.jre328cf92016-08-22 04:12:17 -07002267 ''),
2268 ]
2269 self.assertEqual(0, git_cl.main(['issue', '--json', 'output.json']))
2270
tandrii8c5a3532016-11-04 07:52:02 -07002271 def test_git_cl_try_default_cq_dry_run_gerrit(self):
2272 self.mock(git_cl.Changelist, 'GetChange',
2273 lambda _, *a: (
2274 self._mocked_call(['GetChange']+list(a))))
2275 self.mock(git_cl.presubmit_support, 'DoGetTryMasters',
2276 lambda *_, **__: (
2277 self._mocked_call(['DoGetTryMasters'])))
2278 self.mock(git_cl._GerritChangelistImpl, 'SetCQState',
2279 lambda _, s: self._mocked_call(['SetCQState', s]))
2280
tandrii8c5a3532016-11-04 07:52:02 -07002281 self.calls = [
2282 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii8c5a3532016-11-04 07:52:02 -07002283 ((['git', 'config', 'branch.feature.gerritissue'],), '123456'),
2284 ((['git', 'config', 'branch.feature.gerritserver'],),
2285 'https://chromium-review.googlesource.com'),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002286 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2287 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2288 ((['git', 'config', 'remote.origin.url'],),
2289 'https://chromium.googlesource.com/depot_tools'),
2290 (('GetChangeDetail', 'chromium-review.googlesource.com',
2291 'depot_tools~123456',
Andrii Shyshkaloveadad922017-01-26 09:38:30 +01002292 ['DETAILED_ACCOUNTS', 'ALL_REVISIONS', 'CURRENT_COMMIT']), {
2293 'project': 'depot_tools',
2294 'status': 'OPEN',
2295 'owner': {'email': 'owner@e.mail'},
2296 'revisions': {
2297 'deadbeaf': {
2298 '_number': 6,
2299 },
2300 'beeeeeef': {
2301 '_number': 7,
2302 'fetch': {'http': {
2303 'url': 'https://chromium.googlesource.com/depot_tools',
2304 'ref': 'refs/changes/56/123456/7'
2305 }},
2306 },
2307 },
2308 }),
tandrii8c5a3532016-11-04 07:52:02 -07002309 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2310 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2311 ((['get_or_create_merge_base', 'feature', 'feature'],),
2312 'fake_ancestor_sha'),
2313 ((['GetChange', 'fake_ancestor_sha', None], ),
2314 git_cl.presubmit_support.GitChange(
2315 '', '', '', '', '', '', '', '')),
2316 ((['git', 'rev-parse', '--show-cdup'],), '../'),
2317 ((['DoGetTryMasters'], ), None),
2318 ((['SetCQState', git_cl._CQState.DRY_RUN], ), None),
2319 ]
2320 out = StringIO.StringIO()
2321 self.mock(git_cl.sys, 'stdout', out)
2322 self.assertEqual(0, git_cl.main(['try']))
2323 self.assertEqual(
2324 out.getvalue(),
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07002325 'Scheduling CQ dry run on: '
tandrii8c5a3532016-11-04 07:52:02 -07002326 'https://chromium-review.googlesource.com/123456\n')
2327
tandrii8c5a3532016-11-04 07:52:02 -07002328 def test_git_cl_try_buildbucket_with_properties_gerrit(self):
2329 self.mock(git_cl.Changelist, 'GetMostRecentPatchset', lambda _: 7)
2330 self.mock(git_cl.uuid, 'uuid4', lambda: 'uuid4')
2331
tandrii8c5a3532016-11-04 07:52:02 -07002332 self.calls = [
2333 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii8c5a3532016-11-04 07:52:02 -07002334 ((['git', 'config', 'branch.feature.gerritissue'],), '123456'),
2335 ((['git', 'config', 'branch.feature.gerritserver'],),
2336 'https://chromium-review.googlesource.com'),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002337 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2338 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2339 ((['git', 'config', 'remote.origin.url'],),
2340 'https://chromium.googlesource.com/depot_tools'),
2341 (('GetChangeDetail', 'chromium-review.googlesource.com',
2342 'depot_tools~123456',
Andrii Shyshkaloveadad922017-01-26 09:38:30 +01002343 ['DETAILED_ACCOUNTS', 'ALL_REVISIONS', 'CURRENT_COMMIT']), {
tandrii8c5a3532016-11-04 07:52:02 -07002344 'project': 'depot_tools',
Andrii Shyshkaloveadad922017-01-26 09:38:30 +01002345 'status': 'OPEN',
2346 'owner': {'email': 'owner@e.mail'},
tandrii8c5a3532016-11-04 07:52:02 -07002347 'revisions': {
2348 'deadbeaf': {
2349 '_number': 6,
2350 },
2351 'beeeeeef': {
2352 '_number': 7,
2353 'fetch': {'http': {
2354 'url': 'https://chromium.googlesource.com/depot_tools',
2355 'ref': 'refs/changes/56/123456/7'
2356 }},
2357 },
2358 },
2359 }),
2360 ]
2361
2362 def _buildbucket_retry(*_, **kw):
2363 # self.maxDiff = 10000
2364 body = json.loads(kw['body'])
2365 self.assertEqual(len(body['builds']), 1)
2366 build = body['builds'][0]
2367 params = json.loads(build.pop('parameters_json'))
2368 self.assertEqual(params, {
2369 u'builder_name': u'win',
2370 u'changes': [{u'author': {u'email': u'owner@e.mail'},
2371 u'revision': None}],
2372 u'properties': {
2373 u'category': u'git_cl_try',
2374 u'key': u'val',
2375 u'json': [{u'a': 1}, None],
tandrii8c5a3532016-11-04 07:52:02 -07002376
2377 u'patch_gerrit_url':
2378 u'https://chromium-review.googlesource.com',
2379 u'patch_issue': 123456,
2380 u'patch_project': u'depot_tools',
2381 u'patch_ref': u'refs/changes/56/123456/7',
2382 u'patch_repository_url':
2383 u'https://chromium.googlesource.com/depot_tools',
2384 u'patch_set': 7,
2385 u'patch_storage': u'gerrit',
2386 }
2387 })
2388 self.assertEqual(build, {
Andrii Shyshkalov03da1502018-10-15 03:42:34 +00002389 u'bucket': u'luci.chromium.try',
tandrii8c5a3532016-11-04 07:52:02 -07002390 u'client_operation_id': u'uuid4',
2391 u'tags': [
2392 u'builder:win',
2393 u'buildset:patch/gerrit/chromium-review.googlesource.com/123456/7',
2394 u'user_agent:git_cl_try',
Andrii Shyshkalov03da1502018-10-15 03:42:34 +00002395 ],
tandrii8c5a3532016-11-04 07:52:02 -07002396 })
2397
2398 self.mock(git_cl, '_buildbucket_retry', _buildbucket_retry)
2399
2400 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2401 self.assertEqual(0, git_cl.main([
Andrii Shyshkalov03da1502018-10-15 03:42:34 +00002402 'try', '-B', 'luci.chromium.try', '-b', 'win',
tandrii8c5a3532016-11-04 07:52:02 -07002403 '-p', 'key=val', '-p', 'json=[{"a":1}, null]']))
2404 self.assertRegexpMatches(
2405 git_cl.sys.stdout.getvalue(),
Andrii Shyshkalov03da1502018-10-15 03:42:34 +00002406 'Tried jobs on:\nBucket: luci.chromium.try')
tandriide281ae2016-10-12 06:02:30 -07002407
qyearsley123a4682016-10-26 09:12:17 -07002408 def test_git_cl_try_bots_on_multiple_masters(self):
Andrii Shyshkalovf5569d22018-10-15 03:35:23 +00002409 self.mock(git_cl.Changelist, 'GetMostRecentPatchset', lambda _: 7)
2410 self.mock(git_cl.Changelist, 'GetChange',
2411 lambda _, *a: (
2412 self._mocked_call(['GetChange']+list(a))))
2413 self.mock(git_cl.presubmit_support, 'DoGetTryMasters',
2414 lambda *_, **__: (
2415 self._mocked_call(['DoGetTryMasters'])))
2416 self.mock(git_cl._GerritChangelistImpl, 'SetCQState',
2417 lambda _, s: self._mocked_call(['SetCQState', s]))
2418
qyearsley123a4682016-10-26 09:12:17 -07002419 self.calls = [
2420 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
Andrii Shyshkalovf5569d22018-10-15 03:35:23 +00002421 ((['git', 'config', 'branch.feature.gerritissue'],), '123456'),
2422 ((['git', 'config', 'branch.feature.gerritserver'],),
2423 'https://chromium-review.googlesource.com'),
2424 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2425 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2426 ((['git', 'config', 'remote.origin.url'],),
2427 'https://chromium.googlesource.com/depot_tools'),
2428 (('GetChangeDetail', 'chromium-review.googlesource.com',
2429 'depot_tools~123456',
2430 ['DETAILED_ACCOUNTS', 'ALL_REVISIONS', 'CURRENT_COMMIT']), {
2431 'project': 'depot_tools',
2432 'status': 'OPEN',
2433 'owner': {'email': 'owner@e.mail'},
2434 'revisions': {
2435 'deadbeaf': {
2436 '_number': 6,
2437 },
2438 'beeeeeef': {
2439 '_number': 7,
2440 'fetch': {'http': {
2441 'url': 'https://chromium.googlesource.com/depot_tools',
2442 'ref': 'refs/changes/56/123456/7'
2443 }},
2444 },
2445 },
2446 }),
qyearsley123a4682016-10-26 09:12:17 -07002447 ]
2448
2449 def _buildbucket_retry(*_, **kw):
2450 body = json.loads(kw['body'])
2451 self.assertEqual(len(body['builds']), 2)
2452
Nodir Turakulovb422e682018-02-20 22:51:30 -08002453 self.assertEqual(body['builds'][0]['bucket'], 'bucket1')
2454 params = json.loads(body['builds'][0]['parameters_json'])
2455 self.assertEqual(params['builder_name'], 'builder1')
qyearsley123a4682016-10-26 09:12:17 -07002456
Nodir Turakulovb422e682018-02-20 22:51:30 -08002457 self.assertEqual(body['builds'][1]['bucket'], 'bucket2')
2458 params = json.loads(body['builds'][1]['parameters_json'])
2459 self.assertEqual(params['builder_name'], 'builder2')
qyearsley123a4682016-10-26 09:12:17 -07002460
2461 self.mock(git_cl, '_buildbucket_retry', _buildbucket_retry)
2462
2463 self.mock(git_cl.urllib2, 'urlopen', lambda _: StringIO.StringIO(
Nodir Turakulovb422e682018-02-20 22:51:30 -08002464 json.dumps({
2465 'builder1': {'bucket': 'bucket1'},
2466 'builder2': {'bucket': 'bucket2'},
2467 })))
qyearsley123a4682016-10-26 09:12:17 -07002468
2469 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2470 self.assertEqual(
2471 0, git_cl.main(['try', '-b', 'builder1', '-b', 'builder2']))
2472 self.assertEqual(
2473 git_cl.sys.stdout.getvalue(),
2474 'Tried jobs on:\n'
Nodir Turakulovb422e682018-02-20 22:51:30 -08002475 'Bucket: bucket1\n'
qyearsley123a4682016-10-26 09:12:17 -07002476 ' builder1: []\n'
Nodir Turakulovb422e682018-02-20 22:51:30 -08002477 'Bucket: bucket2\n'
qyearsley123a4682016-10-26 09:12:17 -07002478 ' builder2: []\n'
2479 'To see results here, run: git cl try-results\n'
2480 'To see results in browser, run: git cl web\n')
2481
tandrii16e0b4e2016-06-07 10:34:28 -07002482 def _common_GerritCommitMsgHookCheck(self):
2483 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2484 self.mock(git_cl.os.path, 'abspath',
2485 lambda path: self._mocked_call(['abspath', path]))
2486 self.mock(git_cl.os.path, 'exists',
2487 lambda path: self._mocked_call(['exists', path]))
2488 self.mock(git_cl.gclient_utils, 'FileRead',
2489 lambda path: self._mocked_call(['FileRead', path]))
2490 self.mock(git_cl.gclient_utils, 'rm_file_or_tree',
2491 lambda path: self._mocked_call(['rm_file_or_tree', path]))
2492 self.calls = [
2493 ((['git', 'rev-parse', '--show-cdup'],), '../'),
2494 ((['abspath', '../'],), '/abs/git_repo_root'),
2495 ]
2496 return git_cl.Changelist(codereview='gerrit', issue=123)
2497
2498 def test_GerritCommitMsgHookCheck_custom_hook(self):
2499 cl = self._common_GerritCommitMsgHookCheck()
2500 self.calls += [
2501 ((['exists', '/abs/git_repo_root/.git/hooks/commit-msg'],), True),
2502 ((['FileRead', '/abs/git_repo_root/.git/hooks/commit-msg'],),
2503 '#!/bin/sh\necho "custom hook"')
2504 ]
2505 cl._codereview_impl._GerritCommitMsgHookCheck(offer_removal=True)
2506
2507 def test_GerritCommitMsgHookCheck_not_exists(self):
2508 cl = self._common_GerritCommitMsgHookCheck()
2509 self.calls += [
2510 ((['exists', '/abs/git_repo_root/.git/hooks/commit-msg'],), False),
2511 ]
2512 cl._codereview_impl._GerritCommitMsgHookCheck(offer_removal=True)
2513
2514 def test_GerritCommitMsgHookCheck(self):
2515 cl = self._common_GerritCommitMsgHookCheck()
2516 self.calls += [
2517 ((['exists', '/abs/git_repo_root/.git/hooks/commit-msg'],), True),
2518 ((['FileRead', '/abs/git_repo_root/.git/hooks/commit-msg'],),
2519 '...\n# From Gerrit Code Review\n...\nadd_ChangeId()\n'),
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002520 (('ask_for_data', 'Do you want to remove it now? [Yes/No]: '), 'Yes'),
tandrii16e0b4e2016-06-07 10:34:28 -07002521 ((['rm_file_or_tree', '/abs/git_repo_root/.git/hooks/commit-msg'],),
2522 ''),
2523 ]
2524 cl._codereview_impl._GerritCommitMsgHookCheck(offer_removal=True)
2525
tandriic4344b52016-08-29 06:04:54 -07002526 def test_GerritCmdLand(self):
2527 self.calls += [
2528 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2529 ((['git', 'config', 'branch.feature.gerritsquashhash'],),
2530 'deadbeaf'),
2531 ((['git', 'diff', 'deadbeaf'],), ''), # No diff.
2532 ((['git', 'config', 'branch.feature.gerritserver'],),
2533 'chromium-review.googlesource.com'),
2534 ]
2535 cl = git_cl.Changelist(issue=123, codereview='gerrit')
2536 cl._codereview_impl._GetChangeDetail = lambda _: {
2537 'labels': {},
2538 'current_revision': 'deadbeaf',
2539 }
agable32978d92016-11-01 12:55:02 -07002540 cl._codereview_impl._GetChangeCommit = lambda: {
2541 'commit': 'deadbeef',
Aaron Gable02cdbb42016-12-13 16:24:25 -08002542 'web_links': [{'name': 'gitiles',
agable32978d92016-11-01 12:55:02 -07002543 'url': 'https://git.googlesource.com/test/+/deadbeef'}],
2544 }
tandriic4344b52016-08-29 06:04:54 -07002545 cl._codereview_impl.SubmitIssue = lambda wait_for_merge: None
tandrii8da412c2016-09-07 16:01:07 -07002546 out = StringIO.StringIO()
2547 self.mock(sys, 'stdout', out)
Olivier Robin75ee7252018-04-13 10:02:56 +02002548 self.assertEqual(0, cl.CMDLand(force=True,
2549 bypass_hooks=True,
2550 verbose=True,
2551 parallel=False))
tandrii8da412c2016-09-07 16:01:07 -07002552 self.assertRegexpMatches(out.getvalue(), 'Issue.*123 has been submitted')
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002553 self.assertRegexpMatches(out.getvalue(), 'Landed as: .*deadbeef')
tandriic4344b52016-08-29 06:04:54 -07002554
tandrii221ab252016-10-06 08:12:04 -07002555 BUILDBUCKET_BUILDS_MAP = {
Quinten Yearsleya563d722017-12-11 16:36:54 -08002556 '9000': {
2557 'id': '9000',
2558 'bucket': 'master.x.y',
2559 'created_by': 'user:someone@chromium.org',
2560 'created_ts': '147200002222000',
2561 'experimental': False,
2562 'parameters_json': json.dumps({
2563 'builder_name': 'my-bot',
2564 'properties': {'category': 'cq'},
2565 }),
2566 'status': 'STARTED',
2567 'tags': [
2568 'build_address:x.y/my-bot/2',
2569 'builder:my-bot',
2570 'experimental:false',
2571 'user_agent:cq',
2572 ],
2573 'url': 'http://build.cr.org/p/x.y/builders/my-bot/builds/2',
2574 },
2575 '8000': {
2576 'id': '8000',
2577 'bucket': 'master.x.y',
2578 'created_by': 'user:someone@chromium.org',
2579 'created_ts': '147200001111000',
2580 'experimental': False,
2581 'failure_reason': 'BUILD_FAILURE',
2582 'parameters_json': json.dumps({
2583 'builder_name': 'my-bot',
2584 'properties': {'category': 'cq'},
2585 }),
2586 'result_details_json': json.dumps({
2587 'properties': {'buildnumber': 1},
2588 }),
2589 'result': 'FAILURE',
2590 'status': 'COMPLETED',
2591 'tags': [
2592 'build_address:x.y/my-bot/1',
2593 'builder:my-bot',
2594 'experimental:false',
2595 'user_agent:cq',
2596 ],
2597 'url': 'http://build.cr.org/p/x.y/builders/my-bot/builds/1',
2598 },
2599 }
tandrii221ab252016-10-06 08:12:04 -07002600
2601 def test_write_try_results_json(self):
2602 expected_output = [
Quinten Yearsleya563d722017-12-11 16:36:54 -08002603 {
2604 'bucket': 'master.x.y',
2605 'buildbucket_id': '8000',
2606 'builder_name': 'my-bot',
2607 'created_ts': '147200001111000',
2608 'experimental': False,
2609 'failure_reason': 'BUILD_FAILURE',
2610 'result': 'FAILURE',
2611 'status': 'COMPLETED',
2612 'tags': [
2613 'build_address:x.y/my-bot/1',
2614 'builder:my-bot',
2615 'experimental:false',
2616 'user_agent:cq',
2617 ],
2618 'url': 'http://build.cr.org/p/x.y/builders/my-bot/builds/1',
2619 },
2620 {
2621 'bucket': 'master.x.y',
2622 'buildbucket_id': '9000',
2623 'builder_name': 'my-bot',
2624 'created_ts': '147200002222000',
2625 'experimental': False,
2626 'failure_reason': None,
2627 'result': None,
2628 'status': 'STARTED',
2629 'tags': [
2630 'build_address:x.y/my-bot/2',
2631 'builder:my-bot',
2632 'experimental:false',
2633 'user_agent:cq',
2634 ],
2635 'url': 'http://build.cr.org/p/x.y/builders/my-bot/builds/2',
2636 },
tandrii221ab252016-10-06 08:12:04 -07002637 ]
2638 self.calls = [(('write_json', 'output.json', expected_output), '')]
2639 git_cl.write_try_results_json('output.json', self.BUILDBUCKET_BUILDS_MAP)
2640
tandrii45b2a582016-10-11 03:14:16 -07002641 def _setup_fetch_try_jobs(self, most_recent_patchset=20001):
tandrii221ab252016-10-06 08:12:04 -07002642 out = StringIO.StringIO()
2643 self.mock(sys, 'stdout', out)
tandrii45b2a582016-10-11 03:14:16 -07002644 self.mock(git_cl.Changelist, 'GetMostRecentPatchset',
2645 lambda *args: most_recent_patchset)
tandrii221ab252016-10-06 08:12:04 -07002646 self.mock(git_cl.auth, 'get_authenticator_for_host', lambda host, _cfg:
2647 self._mocked_call(['get_authenticator_for_host', host]))
2648 self.mock(git_cl, '_buildbucket_retry', lambda *_, **__:
2649 self._mocked_call(['_buildbucket_retry']))
tandrii45b2a582016-10-11 03:14:16 -07002650
tandrii45b2a582016-10-11 03:14:16 -07002651 def _setup_fetch_try_jobs_gerrit(self, *request_results):
2652 self._setup_fetch_try_jobs(most_recent_patchset=13)
2653 self.calls += [
2654 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii45b2a582016-10-11 03:14:16 -07002655 ((['git', 'config', 'branch.feature.gerritissue'],), '1'),
Ravi Mistryfda50ca2016-11-14 10:19:18 -05002656 # TODO(tandrii): Uncomment the below if we decide to support checking
2657 # patchsets for Gerrit.
tandrii45b2a582016-10-11 03:14:16 -07002658 # Simulate that Gerrit has more patchsets than local.
Ravi Mistryfda50ca2016-11-14 10:19:18 -05002659 # ((['git', 'config', 'branch.feature.gerritpatchset'],), '12'),
tandrii45b2a582016-10-11 03:14:16 -07002660 ((['git', 'config', 'branch.feature.gerritserver'],),
2661 'https://x-review.googlesource.com'),
2662 ((['get_authenticator_for_host', 'x-review.googlesource.com'],),
2663 AuthenticatorMock()),
2664 ] + [((['_buildbucket_retry'],), r) for r in request_results]
2665
2666 def test_fetch_try_jobs_none_gerrit(self):
2667 self._setup_fetch_try_jobs_gerrit({})
2668 self.assertEqual(0, git_cl.main(['try-results']))
Ravi Mistryfda50ca2016-11-14 10:19:18 -05002669 # TODO(tandrii): Uncomment the below if we decide to support checking
2670 # patchsets for Gerrit.
2671 # self.assertRegexpMatches(
2672 # sys.stdout.getvalue(),
2673 # r'Warning: Codereview server has newer patchsets \(13\)')
tandrii45b2a582016-10-11 03:14:16 -07002674 self.assertRegexpMatches(sys.stdout.getvalue(), 'No try jobs')
2675
2676 def test_fetch_try_jobs_some_gerrit(self):
2677 self._setup_fetch_try_jobs_gerrit({
2678 'builds': self.BUILDBUCKET_BUILDS_MAP.values(),
2679 })
Ravi Mistryfda50ca2016-11-14 10:19:18 -05002680 # TODO(tandrii): Uncomment the below if we decide to support checking
2681 # patchsets for Gerrit.
2682 # self.calls.remove(
2683 # ((['git', 'config', 'branch.feature.gerritpatchset'],), '12'))
tandrii45b2a582016-10-11 03:14:16 -07002684 self.assertEqual(0, git_cl.main(['try-results', '--patchset', '5']))
2685
2686 # ... and doesn't result in warning.
2687 self.assertNotRegexpMatches(sys.stdout.getvalue(), 'Warning')
2688 self.assertRegexpMatches(sys.stdout.getvalue(), '^Failures:')
tandrii221ab252016-10-06 08:12:04 -07002689 self.assertRegexpMatches(sys.stdout.getvalue(), 'Started:')
2690 self.assertRegexpMatches(sys.stdout.getvalue(), '2 try jobs')
2691
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002692 def _mock_gerrit_changes_for_detail_cache(self):
2693 self.mock(git_cl._GerritChangelistImpl, '_GetGerritHost', lambda _: 'host')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002694
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002695 def test_gerrit_change_detail_cache_simple(self):
2696 self._mock_gerrit_changes_for_detail_cache()
2697 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002698 (('GetChangeDetail', 'host', 'my%2Frepo~1', []), 'a'),
2699 (('GetChangeDetail', 'host', 'ab%2Frepo~2', []), 'b'),
2700 (('GetChangeDetail', 'host', 'ab%2Frepo~2', []), 'b2'),
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002701 ]
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00002702 cl1 = git_cl.Changelist(issue=1, codereview='gerrit')
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002703 cl1._cached_remote_url = (
2704 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00002705 cl2 = git_cl.Changelist(issue=2, codereview='gerrit')
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002706 cl2._cached_remote_url = (
2707 True, 'https://chromium.googlesource.com/ab/repo')
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00002708 self.assertEqual(cl1._GetChangeDetail(), 'a') # Miss.
2709 self.assertEqual(cl1._GetChangeDetail(), 'a')
2710 self.assertEqual(cl2._GetChangeDetail(), 'b') # Miss.
2711 self.assertEqual(cl2._GetChangeDetail(no_cache=True), 'b2') # Miss.
2712 self.assertEqual(cl1._GetChangeDetail(), 'a')
2713 self.assertEqual(cl2._GetChangeDetail(), 'b2')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002714
2715 def test_gerrit_change_detail_cache_options(self):
2716 self._mock_gerrit_changes_for_detail_cache()
2717 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002718 (('GetChangeDetail', 'host', 'repo~1', ['C', 'A', 'B']), 'cab'),
2719 (('GetChangeDetail', 'host', 'repo~1', ['A', 'D']), 'ad'),
2720 (('GetChangeDetail', 'host', 'repo~1', ['A']), 'a'), # no_cache=True
2721 # no longer in cache.
2722 (('GetChangeDetail', 'host', 'repo~1', ['B']), 'b'),
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002723 ]
2724 cl = git_cl.Changelist(issue=1, codereview='gerrit')
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002725 cl._cached_remote_url = (True, 'https://chromium.googlesource.com/repo/')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002726 self.assertEqual(cl._GetChangeDetail(options=['C', 'A', 'B']), 'cab')
2727 self.assertEqual(cl._GetChangeDetail(options=['A', 'B', 'C']), 'cab')
2728 self.assertEqual(cl._GetChangeDetail(options=['B', 'A']), 'cab')
2729 self.assertEqual(cl._GetChangeDetail(options=['C']), 'cab')
2730 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2731 self.assertEqual(cl._GetChangeDetail(), 'cab')
2732
2733 self.assertEqual(cl._GetChangeDetail(options=['A', 'D']), 'ad')
2734 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2735 self.assertEqual(cl._GetChangeDetail(options=['D']), 'ad')
2736 self.assertEqual(cl._GetChangeDetail(), 'cab')
2737
2738 # Finally, no_cache should invalidate all caches for given change.
2739 self.assertEqual(cl._GetChangeDetail(options=['A'], no_cache=True), 'a')
2740 self.assertEqual(cl._GetChangeDetail(options=['B']), 'b')
2741
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002742 def test_gerrit_description_caching(self):
2743 def gen_detail(rev, desc):
2744 return {
2745 'current_revision': rev,
2746 'revisions': {rev: {'commit': {'message': desc}}}
2747 }
2748 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002749 (('GetChangeDetail', 'host', 'my%2Frepo~1',
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002750 ['CURRENT_REVISION', 'CURRENT_COMMIT']),
2751 gen_detail('rev1', 'desc1')),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002752 (('GetChangeDetail', 'host', 'my%2Frepo~1',
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002753 ['CURRENT_REVISION', 'CURRENT_COMMIT']),
2754 gen_detail('rev2', 'desc2')),
2755 ]
2756
2757 self._mock_gerrit_changes_for_detail_cache()
2758 cl = git_cl.Changelist(issue=1, codereview='gerrit')
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002759 cl._cached_remote_url = (
2760 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002761 self.assertEqual(cl.GetDescription(), 'desc1')
2762 self.assertEqual(cl.GetDescription(), 'desc1') # cache hit.
2763 self.assertEqual(cl.GetDescription(force=True), 'desc2')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002764
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002765 def test_print_current_creds(self):
2766 class CookiesAuthenticatorMock(object):
2767 def __init__(self):
2768 self.gitcookies = {
2769 'host.googlesource.com': ('user', 'pass'),
2770 'host-review.googlesource.com': ('user', 'pass'),
2771 }
2772 self.netrc = self
2773 self.netrc.hosts = {
2774 'github.com': ('user2', None, 'pass2'),
2775 'host2.googlesource.com': ('user3', None, 'pass'),
2776 }
2777 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
2778 CookiesAuthenticatorMock)
2779 self.mock(sys, 'stdout', StringIO.StringIO())
2780 git_cl._GitCookiesChecker().print_current_creds(include_netrc=True)
2781 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2782 ' Host\t User\t Which file',
2783 '============================\t=====\t===========',
2784 'host-review.googlesource.com\t user\t.gitcookies',
2785 ' host.googlesource.com\t user\t.gitcookies',
2786 ' host2.googlesource.com\tuser3\t .netrc',
2787 ])
2788 sys.stdout.buf = ''
2789 git_cl._GitCookiesChecker().print_current_creds(include_netrc=False)
2790 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2791 ' Host\tUser\t Which file',
2792 '============================\t====\t===========',
2793 'host-review.googlesource.com\tuser\t.gitcookies',
2794 ' host.googlesource.com\tuser\t.gitcookies',
2795 ])
2796
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002797 def _common_creds_check_mocks(self):
2798 def exists_mock(path):
2799 dirname = os.path.dirname(path)
2800 if dirname == os.path.expanduser('~'):
2801 dirname = '~'
2802 base = os.path.basename(path)
2803 if base in ('.netrc', '.gitcookies'):
2804 return self._mocked_call('os.path.exists', '%s/%s' % (dirname, base))
2805 # git cl also checks for existence other files not relevant to this test.
2806 return None
2807 self.mock(os.path, 'exists', exists_mock)
2808 self.mock(sys, 'stdout', StringIO.StringIO())
2809
2810 def test_creds_check_gitcookies_not_configured(self):
2811 self._common_creds_check_mocks()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002812 self.mock(git_cl._GitCookiesChecker, 'get_hosts_with_creds',
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01002813 lambda _, include_netrc=False: [])
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002814 self.calls = [
Aaron Gable8797cab2018-03-06 13:55:00 -08002815 ((['git', 'config', '--path', 'http.cookiefile'],), CERR1),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002816 ((['git', 'config', '--global', 'http.cookiefile'],), CERR1),
2817 (('os.path.exists', '~/.netrc'), True),
2818 (('ask_for_data', 'Press Enter to setup .gitcookies, '
2819 'or Ctrl+C to abort'), ''),
2820 ((['git', 'config', '--global', 'http.cookiefile',
2821 os.path.expanduser('~/.gitcookies')], ), ''),
2822 ]
2823 self.assertEqual(0, git_cl.main(['creds-check']))
2824 self.assertRegexpMatches(
2825 sys.stdout.getvalue(),
2826 '^You seem to be using outdated .netrc for git credentials:')
2827 self.assertRegexpMatches(
2828 sys.stdout.getvalue(),
2829 '\nConfigured git to use .gitcookies from')
2830
2831 def test_creds_check_gitcookies_configured_custom_broken(self):
2832 self._common_creds_check_mocks()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002833 self.mock(git_cl._GitCookiesChecker, 'get_hosts_with_creds',
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01002834 lambda _, include_netrc=False: [])
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002835 self.calls = [
Aaron Gable8797cab2018-03-06 13:55:00 -08002836 ((['git', 'config', '--path', 'http.cookiefile'],), CERR1),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002837 ((['git', 'config', '--global', 'http.cookiefile'],),
2838 '/custom/.gitcookies'),
2839 (('os.path.exists', '/custom/.gitcookies'), False),
2840 (('ask_for_data', 'Reconfigure git to use default .gitcookies? '
2841 'Press Enter to reconfigure, or Ctrl+C to abort'), ''),
2842 ((['git', 'config', '--global', 'http.cookiefile',
2843 os.path.expanduser('~/.gitcookies')], ), ''),
2844 ]
2845 self.assertEqual(0, git_cl.main(['creds-check']))
2846 self.assertRegexpMatches(
2847 sys.stdout.getvalue(),
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002848 'WARNING: You have configured custom path to .gitcookies: ')
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002849 self.assertRegexpMatches(
2850 sys.stdout.getvalue(),
2851 'However, your configured .gitcookies file is missing.')
2852
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002853 def test_git_cl_comment_add_gerrit(self):
2854 self.mock(git_cl.gerrit_util, 'SetReview',
Aaron Gable636b13f2017-07-14 10:42:48 -07002855 lambda host, change, msg, ready:
2856 self._mocked_call('SetReview', host, change, msg, ready))
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002857 self.calls = [
2858 ((['git', 'symbolic-ref', 'HEAD'],), CERR1),
2859 ((['git', 'symbolic-ref', 'HEAD'],), CERR1),
2860 ((['git', 'config', 'rietveld.upstream-branch'],), CERR1),
2861 ((['git', 'branch', '-r'],), 'origin/HEAD -> origin/master\n'
2862 'origin/master'),
2863 ((['git', 'config', 'remote.origin.url'],),
2864 'https://chromium.googlesource.com/infra/infra'),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002865 (('SetReview', 'chromium-review.googlesource.com', 'infra%2Finfra~10',
2866 'msg', None),
Aaron Gable636b13f2017-07-14 10:42:48 -07002867 None),
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002868 ]
2869 self.assertEqual(0, git_cl.main(['comment', '--gerrit', '-i', '10',
2870 '-a', 'msg']))
2871
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002872 def test_git_cl_comments_fetch_gerrit(self):
2873 self.mock(sys, 'stdout', StringIO.StringIO())
2874 self.calls = [
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002875 ((['git', 'config', 'branch.foo.gerritserver'],), ''),
2876 ((['git', 'config', 'branch.foo.merge'],), ''),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002877 ((['git', 'config', 'rietveld.upstream-branch'],), CERR1),
2878 ((['git', 'branch', '-r'],), 'origin/HEAD -> origin/master\n'
2879 'origin/master'),
2880 ((['git', 'config', 'remote.origin.url'],),
2881 'https://chromium.googlesource.com/infra/infra'),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002882 (('GetChangeDetail', 'chromium-review.googlesource.com',
2883 'infra%2Finfra~1',
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002884 ['MESSAGES', 'DETAILED_ACCOUNTS', 'CURRENT_REVISION',
2885 'CURRENT_COMMIT']), {
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002886 'owner': {'email': 'owner@example.com'},
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002887 'current_revision': 'ba5eba11',
2888 'revisions': {
2889 'deadbeaf': {
2890 '_number': 1,
2891 },
2892 'ba5eba11': {
2893 '_number': 2,
2894 },
2895 },
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002896 'messages': [
2897 {
2898 u'_revision_number': 1,
2899 u'author': {
2900 u'_account_id': 1111084,
2901 u'email': u'commit-bot@chromium.org',
2902 u'name': u'Commit Bot'
2903 },
2904 u'date': u'2017-03-15 20:08:45.000000000',
2905 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
Dirk Prankef6a58802017-10-17 12:49:42 -07002906 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002907 u'tag': u'autogenerated:cq:dry-run'
2908 },
2909 {
2910 u'_revision_number': 2,
2911 u'author': {
2912 u'_account_id': 11151243,
2913 u'email': u'owner@example.com',
2914 u'name': u'owner'
2915 },
2916 u'date': u'2017-03-16 20:00:41.000000000',
2917 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2918 u'message': u'PTAL',
2919 },
2920 {
2921 u'_revision_number': 2,
2922 u'author': {
2923 u'_account_id': 148512 ,
2924 u'email': u'reviewer@example.com',
2925 u'name': u'reviewer'
2926 },
2927 u'date': u'2017-03-17 05:19:37.500000000',
2928 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
2929 u'message': u'Patch Set 2: Code-Review+1',
2930 },
2931 ]
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002932 }),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002933 (('GetChangeComments', 'chromium-review.googlesource.com',
2934 'infra%2Finfra~1'), {
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002935 '/COMMIT_MSG': [
2936 {
2937 'author': {'email': u'reviewer@example.com'},
2938 'updated': u'2017-03-17 05:19:37.500000000',
2939 'patch_set': 2,
2940 'side': 'REVISION',
2941 'message': 'Please include a bug link',
2942 },
2943 ],
2944 'codereview.settings': [
2945 {
2946 'author': {'email': u'owner@example.com'},
2947 'updated': u'2017-03-16 20:00:41.000000000',
2948 'patch_set': 2,
2949 'side': 'PARENT',
2950 'line': 42,
2951 'message': 'I removed this because it is bad',
2952 },
2953 ]
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002954 }),
2955 (('GetChangeRobotComments', 'chromium-review.googlesource.com',
2956 'infra%2Finfra~1'), {}),
2957 ((['git', 'config', 'branch.foo.gerritpatchset', '2'],), ''),
Leszek Swirski45b20c42018-09-17 17:05:26 +00002958 ] * 2 + [
2959 (('write_json', 'output.json', [
2960 {
2961 u'date': u'2017-03-16 20:00:41.000000',
2962 u'message': (
2963 u'PTAL\n' +
2964 u'\n' +
2965 u'codereview.settings\n' +
2966 u' Base, Line 42: https://chromium-review.googlesource.com/' +
2967 u'c/1/2/codereview.settings#b42\n' +
2968 u' I removed this because it is bad\n'),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002969 u'autogenerated': False,
Leszek Swirski45b20c42018-09-17 17:05:26 +00002970 u'approval': False,
2971 u'disapproval': False,
2972 u'sender': u'owner@example.com'
2973 }, {
2974 u'date': u'2017-03-17 05:19:37.500000',
2975 u'message': (
2976 u'Patch Set 2: Code-Review+1\n' +
2977 u'\n' +
2978 u'/COMMIT_MSG\n' +
2979 u' PS2, File comment: https://chromium-review.googlesource' +
2980 u'.com/c/1/2//COMMIT_MSG#\n' +
2981 u' Please include a bug link\n'),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002982 u'autogenerated': False,
Leszek Swirski45b20c42018-09-17 17:05:26 +00002983 u'approval': False,
2984 u'disapproval': False,
2985 u'sender': u'reviewer@example.com'
2986 }
2987 ]),'')
2988 ]
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002989 expected_comments_summary = [
2990 git_cl._CommentSummary(
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002991 message=(
2992 u'PTAL\n' +
2993 u'\n' +
2994 u'codereview.settings\n' +
2995 u' Base, Line 42: https://chromium-review.googlesource.com/' +
2996 u'c/1/2/codereview.settings#b42\n' +
2997 u' I removed this because it is bad\n'),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002998 date=datetime.datetime(2017, 3, 16, 20, 0, 41, 0),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002999 autogenerated=False,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01003000 disapproval=False, approval=False, sender=u'owner@example.com'),
3001 git_cl._CommentSummary(
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07003002 message=(
3003 u'Patch Set 2: Code-Review+1\n' +
3004 u'\n' +
3005 u'/COMMIT_MSG\n' +
3006 u' PS2, File comment: https://chromium-review.googlesource.com/' +
3007 u'c/1/2//COMMIT_MSG#\n' +
3008 u' Please include a bug link\n'),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01003009 date=datetime.datetime(2017, 3, 17, 5, 19, 37, 500000),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00003010 autogenerated=False,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01003011 disapproval=False, approval=False, sender=u'reviewer@example.com'),
3012 ]
Quinten Yearsley0e617c02019-02-20 00:37:03 +00003013 cl = git_cl.Changelist(
3014 codereview='gerrit', issue=1, branchref='refs/heads/foo')
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01003015 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Quinten Yearsley0e617c02019-02-20 00:37:03 +00003016 self.mock(git_cl.Changelist, 'GetBranch', lambda _: 'foo')
3017 self.assertEqual(
3018 0, git_cl.main(['comments', '-i', '1', '-j', 'output.json']))
3019
3020 def test_git_cl_comments_robot_comments(self):
3021 # git cl comments also fetches robot comments (which are considered a type
3022 # of autogenerated comment), and unlike other types of comments, only robot
3023 # comments from the latest patchset are shown.
3024 self.mock(sys, 'stdout', StringIO.StringIO())
3025 self.calls = [
3026 ((['git', 'config', 'branch.foo.gerritserver'],), ''),
3027 ((['git', 'config', 'branch.foo.merge'],), ''),
3028 ((['git', 'config', 'rietveld.upstream-branch'],), CERR1),
3029 ((['git', 'branch', '-r'],), 'origin/HEAD -> origin/master\n'
3030 'origin/master'),
3031 ((['git', 'config', 'remote.origin.url'],),
3032 'https://chromium.googlesource.com/infra/infra'),
3033 (('GetChangeDetail', 'chromium-review.googlesource.com',
3034 'infra%2Finfra~1',
3035 ['MESSAGES', 'DETAILED_ACCOUNTS', 'CURRENT_REVISION',
3036 'CURRENT_COMMIT']), {
3037 'owner': {'email': 'owner@example.com'},
3038 'current_revision': 'ba5eba11',
3039 'revisions': {
3040 'deadbeaf': {
3041 '_number': 1,
3042 },
3043 'ba5eba11': {
3044 '_number': 2,
3045 },
3046 },
3047 'messages': [
3048 {
3049 u'_revision_number': 1,
3050 u'author': {
3051 u'_account_id': 1111084,
3052 u'email': u'commit-bot@chromium.org',
3053 u'name': u'Commit Bot'
3054 },
3055 u'date': u'2017-03-15 20:08:45.000000000',
3056 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
3057 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
3058 u'tag': u'autogenerated:cq:dry-run'
3059 },
3060 {
3061 u'_revision_number': 1,
3062 u'author': {
3063 u'_account_id': 123,
3064 u'email': u'tricium@serviceaccount.com',
3065 u'name': u'Tricium'
3066 },
3067 u'date': u'2017-03-16 20:00:41.000000000',
3068 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
3069 u'message': u'(1 comment)',
3070 u'tag': u'autogenerated:tricium',
3071 },
3072 {
3073 u'_revision_number': 1,
3074 u'author': {
3075 u'_account_id': 123,
3076 u'email': u'tricium@serviceaccount.com',
3077 u'name': u'Tricium'
3078 },
3079 u'date': u'2017-03-16 20:00:41.000000000',
3080 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
3081 u'message': u'(1 comment)',
3082 u'tag': u'autogenerated:tricium',
3083 },
3084 {
3085 u'_revision_number': 2,
3086 u'author': {
3087 u'_account_id': 123 ,
3088 u'email': u'tricium@serviceaccount.com',
3089 u'name': u'reviewer'
3090 },
3091 u'date': u'2017-03-17 05:30:37.000000000',
3092 u'tag': u'autogenerated:tricium',
3093 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
3094 u'message': u'(1 comment)',
3095 },
3096 ]
3097 }),
3098 (('GetChangeComments', 'chromium-review.googlesource.com',
3099 'infra%2Finfra~1'), {}),
3100 (('GetChangeRobotComments', 'chromium-review.googlesource.com',
3101 'infra%2Finfra~1'), {
3102 'codereview.settings': [
3103 {
3104 u'author': {u'email': u'tricium@serviceaccount.com'},
3105 u'updated': u'2017-03-17 05:30:37.000000000',
3106 u'robot_run_id': u'5565031076855808',
3107 u'robot_id': u'Linter/Category',
3108 u'tag': u'autogenerated:tricium',
3109 u'patch_set': 2,
3110 u'side': u'REVISION',
3111 u'message': u'Linter warning message text',
3112 u'line': 32,
3113 },
3114 ],
3115 }),
3116 ((['git', 'config', 'branch.foo.gerritpatchset', '2'],), ''),
3117 ]
3118 expected_comments_summary = [
3119 git_cl._CommentSummary(date=datetime.datetime(2017, 3, 17, 5, 30, 37),
3120 message=(
3121 u'(1 comment)\n\ncodereview.settings\n'
3122 u' PS2, Line 32: https://chromium-review.googlesource.com/'
3123 u'c/1/2/codereview.settings#32\n'
3124 u' Linter warning message text\n'),
3125 sender=u'tricium@serviceaccount.com',
3126 autogenerated=True, approval=False, disapproval=False)
3127 ]
3128 cl = git_cl.Changelist(
3129 codereview='gerrit', issue=1, branchref='refs/heads/foo')
3130 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003131
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00003132 def test_get_remote_url_with_mirror(self):
3133 original_os_path_isdir = os.path.isdir
3134 def selective_os_path_isdir_mock(path):
3135 if path == '/cache/this-dir-exists':
3136 return self._mocked_call('os.path.isdir', path)
3137 return original_os_path_isdir(path)
3138 self.mock(os.path, 'isdir', selective_os_path_isdir_mock)
3139
3140 url = 'https://chromium.googlesource.com/my/repo'
3141 self.calls = [
3142 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
3143 ((['git', 'config', 'branch.master.merge'],), 'master'),
3144 ((['git', 'config', 'branch.master.remote'],), 'origin'),
3145 ((['git', 'config', 'remote.origin.url'],),
3146 '/cache/this-dir-exists'),
3147 (('os.path.isdir', '/cache/this-dir-exists'),
3148 True),
3149 # Runs in /cache/this-dir-exists.
3150 ((['git', 'config', 'remote.origin.url'],),
3151 url),
3152 ]
3153 cl = git_cl.Changelist(codereview='gerrit', issue=1)
3154 self.assertEqual(cl.GetRemoteUrl(), url)
3155 self.assertEqual(cl.GetRemoteUrl(), url) # Must be cached.
3156
Edward Lemur298f2cf2019-02-22 21:40:39 +00003157 def test_get_remote_url_non_existing_mirror(self):
3158 original_os_path_isdir = os.path.isdir
3159 def selective_os_path_isdir_mock(path):
3160 if path == '/cache/this-dir-doesnt-exist':
3161 return self._mocked_call('os.path.isdir', path)
3162 return original_os_path_isdir(path)
3163 self.mock(os.path, 'isdir', selective_os_path_isdir_mock)
3164 self.mock(logging, 'error',
3165 lambda fmt, *a: self._mocked_call('logging.error', fmt % a))
3166
3167 self.calls = [
3168 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
3169 ((['git', 'config', 'branch.master.merge'],), 'master'),
3170 ((['git', 'config', 'branch.master.remote'],), 'origin'),
3171 ((['git', 'config', 'remote.origin.url'],),
3172 '/cache/this-dir-doesnt-exist'),
3173 (('os.path.isdir', '/cache/this-dir-doesnt-exist'),
3174 False),
3175 (('logging.error',
3176 'Remote "origin" for branch "/cache/this-dir-doesnt-exist" points to'
3177 ' "master", but it doesn\'t exist.'), None),
3178 ]
3179 cl = git_cl.Changelist(codereview='gerrit', issue=1)
3180 self.assertIsNone(cl.GetRemoteUrl())
3181
3182 def test_get_remote_url_misconfigured_mirror(self):
3183 original_os_path_isdir = os.path.isdir
3184 def selective_os_path_isdir_mock(path):
3185 if path == '/cache/this-dir-exists':
3186 return self._mocked_call('os.path.isdir', path)
3187 return original_os_path_isdir(path)
3188 self.mock(os.path, 'isdir', selective_os_path_isdir_mock)
3189 self.mock(logging, 'error',
3190 lambda *a: self._mocked_call('logging.error', *a))
3191
3192 self.calls = [
3193 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
3194 ((['git', 'config', 'branch.master.merge'],), 'master'),
3195 ((['git', 'config', 'branch.master.remote'],), 'origin'),
3196 ((['git', 'config', 'remote.origin.url'],),
3197 '/cache/this-dir-exists'),
3198 (('os.path.isdir', '/cache/this-dir-exists'), True),
3199 # Runs in /cache/this-dir-exists.
3200 ((['git', 'config', 'remote.origin.url'],), ''),
3201 (('logging.error',
3202 'Remote "%(remote)s" for branch "%(branch)s" points to '
3203 '"%(cache_path)s", but it is misconfigured.\n'
3204 '"%(cache_path)s" must be a git repo and must have a remote named '
3205 '"%(remote)s" pointing to the git host.', {
3206 'remote': 'origin',
3207 'cache_path': '/cache/this-dir-exists',
3208 'branch': 'master'}
3209 ), None),
3210 ]
3211 cl = git_cl.Changelist(codereview='gerrit', issue=1)
3212 self.assertIsNone(cl.GetRemoteUrl())
3213
3214
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00003215 def test_gerrit_change_identifier_with_project(self):
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00003216 self.calls = [
3217 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
3218 ((['git', 'config', 'branch.master.merge'],), 'master'),
3219 ((['git', 'config', 'branch.master.remote'],), 'origin'),
3220 ((['git', 'config', 'remote.origin.url'],),
3221 'https://chromium.googlesource.com/a/my/repo.git/'),
3222 ]
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00003223 cl = git_cl.Changelist(codereview='gerrit', issue=123456)
3224 self.assertEqual(cl._GerritChangeIdentifier(), 'my%2Frepo~123456')
3225
3226 def test_gerrit_change_identifier_without_project(self):
3227 self.calls = [
3228 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
3229 ((['git', 'config', 'branch.master.merge'],), 'master'),
3230 ((['git', 'config', 'branch.master.remote'],), 'origin'),
3231 ((['git', 'config', 'remote.origin.url'],), CERR1),
3232 ]
3233 cl = git_cl.Changelist(codereview='gerrit', issue=123456)
3234 self.assertEqual(cl._GerritChangeIdentifier(), '123456')
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00003235
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003236
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003237if __name__ == '__main__':
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +01003238 logging.basicConfig(
3239 level=logging.DEBUG if '-v' in sys.argv else logging.ERROR)
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003240 unittest.main()