maruel@chromium.org | 725f1c3 | 2011-04-01 20:24:54 +0000 | [diff] [blame] | 1 | #!/usr/bin/env python |
maruel@chromium.org | 3bbf294 | 2012-01-10 16:52:06 +0000 | [diff] [blame] | 2 | # Copyright (c) 2012 The Chromium Authors. All rights reserved. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 3 | # Use of this source code is governed by a BSD-style license that can be |
| 4 | # found in the LICENSE file. |
| 5 | |
| 6 | """Enables directory-specific presubmit checks to run at upload and/or commit. |
| 7 | """ |
| 8 | |
Raul Tambre | 80ee78e | 2019-05-06 22:41:05 +0000 | [diff] [blame] | 9 | from __future__ import print_function |
| 10 | |
stip@chromium.org | f7d31f5 | 2014-01-03 20:14:46 +0000 | [diff] [blame] | 11 | __version__ = '1.8.0' |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 12 | |
| 13 | # TODO(joi) Add caching where appropriate/needed. The API is designed to allow |
| 14 | # caching (between all different invocations of presubmit scripts for a given |
| 15 | # change). We should add it as our presubmit scripts start feeling slow. |
| 16 | |
Edward Lemur | a5799e3 | 2020-01-17 19:26:51 +0000 | [diff] [blame] | 17 | import argparse |
Takeshi Yoshino | 07a6bea | 2017-08-02 02:44:06 +0900 | [diff] [blame] | 18 | import ast # Exposed through the API. |
iannucci@chromium.org | 8a4a2bc | 2013-03-08 08:13:20 +0000 | [diff] [blame] | 19 | import contextlib |
Yoshisato Yanagisawa | 406de13 | 2018-06-29 05:43:25 +0000 | [diff] [blame] | 20 | import cpplint |
dcheng | 091b7db | 2016-06-16 01:27:51 -0700 | [diff] [blame] | 21 | import fnmatch # Exposed through the API. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 22 | import glob |
asvitkine@chromium.org | 1516995 | 2011-09-27 14:30:53 +0000 | [diff] [blame] | 23 | import inspect |
machenbach@chromium.org | 58a69cb | 2014-03-01 02:08:29 +0000 | [diff] [blame] | 24 | import itertools |
maruel@chromium.org | 4f6852c | 2012-04-20 20:39:20 +0000 | [diff] [blame] | 25 | import json # Exposed through the API. |
maruel@chromium.org | df1595a | 2009-06-11 02:00:13 +0000 | [diff] [blame] | 26 | import logging |
ilevy@chromium.org | bc11731 | 2013-04-20 03:57:56 +0000 | [diff] [blame] | 27 | import multiprocessing |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 28 | import os # Somewhat exposed through the API. |
maruel@chromium.org | ce8e46b | 2009-06-26 22:31:51 +0000 | [diff] [blame] | 29 | import random |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 30 | import re # Exposed through the API. |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 31 | import signal |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 32 | import sys # Parts exposed through API. |
| 33 | import tempfile # Exposed through the API. |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 34 | import threading |
jam@chromium.org | 2a891dc | 2009-08-20 20:33:37 +0000 | [diff] [blame] | 35 | import time |
Edward Lemur | de9e3ca | 2019-10-24 21:13:31 +0000 | [diff] [blame] | 36 | import traceback |
maruel@chromium.org | 1487d53 | 2009-06-06 00:22:57 +0000 | [diff] [blame] | 37 | import unittest # Exposed through the API. |
maruel@chromium.org | cb2985f | 2010-11-03 14:08:31 +0000 | [diff] [blame] | 38 | from warnings import warn |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 39 | |
| 40 | # Local imports. |
maruel@chromium.org | 35625c7 | 2011-03-23 17:34:02 +0000 | [diff] [blame] | 41 | import fix_encoding |
Yoshisato Yanagisawa | 04600b4 | 2019-03-15 03:03:41 +0000 | [diff] [blame] | 42 | import gclient_paths # Exposed through the API |
| 43 | import gclient_utils |
Aaron Gable | b584c4f | 2017-04-26 16:28:08 -0700 | [diff] [blame] | 44 | import git_footers |
tandrii@chromium.org | 015ebae | 2016-04-25 19:37:22 +0000 | [diff] [blame] | 45 | import gerrit_util |
dpranke@chromium.org | 2a00962 | 2011-03-01 02:43:31 +0000 | [diff] [blame] | 46 | import owners |
Jochen Eisinger | 76f5fc6 | 2017-04-07 16:27:46 +0200 | [diff] [blame] | 47 | import owners_finder |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 48 | import presubmit_canned_checks |
Saagar Sanghavi | 9949ab7 | 2020-07-20 20:56:40 +0000 | [diff] [blame] | 49 | import rdb_wrapper |
maruel@chromium.org | 5aeb7dd | 2009-11-17 18:09:01 +0000 | [diff] [blame] | 50 | import scm |
maruel@chromium.org | 84f4fe3 | 2011-04-06 13:26:45 +0000 | [diff] [blame] | 51 | import subprocess2 as subprocess # Exposed through the API. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 52 | |
Edward Lemur | 16af356 | 2019-10-17 22:11:33 +0000 | [diff] [blame] | 53 | if sys.version_info.major == 2: |
| 54 | # TODO(1009814): Expose urllib2 only through urllib_request and urllib_error |
| 55 | import urllib2 # Exposed through the API. |
| 56 | import urlparse |
| 57 | import urllib2 as urllib_request |
| 58 | import urllib2 as urllib_error |
| 59 | else: |
| 60 | import urllib.parse as urlparse |
| 61 | import urllib.request as urllib_request |
| 62 | import urllib.error as urllib_error |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 63 | |
maruel@chromium.org | ce8e46b | 2009-06-26 22:31:51 +0000 | [diff] [blame] | 64 | # Ask for feedback only once in program lifetime. |
| 65 | _ASKED_FOR_FEEDBACK = False |
| 66 | |
Edward Lemur | ecc2707 | 2020-01-06 16:42:34 +0000 | [diff] [blame] | 67 | def time_time(): |
| 68 | # Use this so that it can be mocked in tests without interfering with python |
| 69 | # system machinery. |
| 70 | return time.time() |
| 71 | |
| 72 | |
maruel@chromium.org | 899e1c1 | 2011-04-07 17:03:18 +0000 | [diff] [blame] | 73 | class PresubmitFailure(Exception): |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 74 | pass |
| 75 | |
| 76 | |
maruel@chromium.org | ffeb2f3 | 2013-12-03 13:55:22 +0000 | [diff] [blame] | 77 | class CommandData(object): |
Edward Lemur | 940c282 | 2019-08-23 00:34:25 +0000 | [diff] [blame] | 78 | def __init__(self, name, cmd, kwargs, message, python3=False): |
maruel@chromium.org | ffeb2f3 | 2013-12-03 13:55:22 +0000 | [diff] [blame] | 79 | self.name = name |
| 80 | self.cmd = cmd |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 81 | self.stdin = kwargs.get('stdin', None) |
Edward Lemur | 2d6b67c | 2019-08-23 22:25:41 +0000 | [diff] [blame] | 82 | self.kwargs = kwargs.copy() |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 83 | self.kwargs['stdout'] = subprocess.PIPE |
| 84 | self.kwargs['stderr'] = subprocess.STDOUT |
| 85 | self.kwargs['stdin'] = subprocess.PIPE |
maruel@chromium.org | ffeb2f3 | 2013-12-03 13:55:22 +0000 | [diff] [blame] | 86 | self.message = message |
| 87 | self.info = None |
Edward Lemur | 940c282 | 2019-08-23 00:34:25 +0000 | [diff] [blame] | 88 | self.python3 = python3 |
maruel@chromium.org | ffeb2f3 | 2013-12-03 13:55:22 +0000 | [diff] [blame] | 89 | |
ilevy@chromium.org | bc11731 | 2013-04-20 03:57:56 +0000 | [diff] [blame] | 90 | |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 91 | # Adapted from |
| 92 | # https://github.com/google/gtest-parallel/blob/master/gtest_parallel.py#L37 |
| 93 | # |
| 94 | # An object that catches SIGINT sent to the Python process and notices |
| 95 | # if processes passed to wait() die by SIGINT (we need to look for |
| 96 | # both of those cases, because pressing Ctrl+C can result in either |
| 97 | # the main process or one of the subprocesses getting the signal). |
| 98 | # |
| 99 | # Before a SIGINT is seen, wait(p) will simply call p.wait() and |
| 100 | # return the result. Once a SIGINT has been seen (in the main process |
| 101 | # or a subprocess, including the one the current call is waiting for), |
Edward Lemur | 9a5bb61 | 2019-09-26 02:01:52 +0000 | [diff] [blame] | 102 | # wait(p) will call p.terminate(). |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 103 | class SigintHandler(object): |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 104 | sigint_returncodes = {-signal.SIGINT, # Unix |
| 105 | -1073741510, # Windows |
| 106 | } |
| 107 | def __init__(self): |
| 108 | self.__lock = threading.Lock() |
| 109 | self.__processes = set() |
| 110 | self.__got_sigint = False |
Edward Lemur | 9a5bb61 | 2019-09-26 02:01:52 +0000 | [diff] [blame] | 111 | self.__previous_signal = signal.signal(signal.SIGINT, self.interrupt) |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 112 | |
| 113 | def __on_sigint(self): |
| 114 | self.__got_sigint = True |
| 115 | while self.__processes: |
| 116 | try: |
| 117 | self.__processes.pop().terminate() |
| 118 | except OSError: |
| 119 | pass |
| 120 | |
Edward Lemur | 9a5bb61 | 2019-09-26 02:01:52 +0000 | [diff] [blame] | 121 | def interrupt(self, signal_num, frame): |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 122 | with self.__lock: |
| 123 | self.__on_sigint() |
Edward Lemur | 9a5bb61 | 2019-09-26 02:01:52 +0000 | [diff] [blame] | 124 | self.__previous_signal(signal_num, frame) |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 125 | |
| 126 | def got_sigint(self): |
| 127 | with self.__lock: |
| 128 | return self.__got_sigint |
| 129 | |
| 130 | def wait(self, p, stdin): |
| 131 | with self.__lock: |
| 132 | if self.__got_sigint: |
| 133 | p.terminate() |
| 134 | self.__processes.add(p) |
| 135 | stdout, stderr = p.communicate(stdin) |
| 136 | code = p.returncode |
| 137 | with self.__lock: |
| 138 | self.__processes.discard(p) |
| 139 | if code in self.sigint_returncodes: |
| 140 | self.__on_sigint() |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 141 | return stdout, stderr |
| 142 | |
| 143 | sigint_handler = SigintHandler() |
| 144 | |
| 145 | |
Edward Lemur | ecc2707 | 2020-01-06 16:42:34 +0000 | [diff] [blame] | 146 | class Timer(object): |
| 147 | def __init__(self, timeout, fn): |
| 148 | self.completed = False |
| 149 | self._fn = fn |
| 150 | self._timer = threading.Timer(timeout, self._onTimer) if timeout else None |
| 151 | |
| 152 | def __enter__(self): |
| 153 | if self._timer: |
| 154 | self._timer.start() |
| 155 | return self |
| 156 | |
| 157 | def __exit__(self, _type, _value, _traceback): |
| 158 | if self._timer: |
| 159 | self._timer.cancel() |
| 160 | |
| 161 | def _onTimer(self): |
| 162 | self._fn() |
| 163 | self.completed = True |
| 164 | |
| 165 | |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 166 | class ThreadPool(object): |
Edward Lemur | ecc2707 | 2020-01-06 16:42:34 +0000 | [diff] [blame] | 167 | def __init__(self, pool_size=None, timeout=None): |
| 168 | self.timeout = timeout |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 169 | self._pool_size = pool_size or multiprocessing.cpu_count() |
| 170 | self._messages = [] |
| 171 | self._messages_lock = threading.Lock() |
| 172 | self._tests = [] |
| 173 | self._tests_lock = threading.Lock() |
| 174 | self._nonparallel_tests = [] |
| 175 | |
Edward Lemur | ecc2707 | 2020-01-06 16:42:34 +0000 | [diff] [blame] | 176 | def _GetCommand(self, test): |
Edward Lemur | 940c282 | 2019-08-23 00:34:25 +0000 | [diff] [blame] | 177 | vpython = 'vpython' |
| 178 | if test.python3: |
| 179 | vpython += '3' |
| 180 | if sys.platform == 'win32': |
| 181 | vpython += '.bat' |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 182 | |
| 183 | cmd = test.cmd |
| 184 | if cmd[0] == 'python': |
| 185 | cmd = list(cmd) |
| 186 | cmd[0] = vpython |
| 187 | elif cmd[0].endswith('.py'): |
| 188 | cmd = [vpython] + cmd |
| 189 | |
Edward Lemur | 336e51f | 2019-11-14 21:42:04 +0000 | [diff] [blame] | 190 | # On Windows, scripts on the current directory take precedence over PATH, so |
| 191 | # that when testing depot_tools on Windows, calling `vpython.bat` will |
| 192 | # execute the copy of vpython of the depot_tools under test instead of the |
| 193 | # one in the bot. |
| 194 | # As a workaround, we run the tests from the parent directory instead. |
| 195 | if (cmd[0] == vpython and |
| 196 | 'cwd' in test.kwargs and |
| 197 | os.path.basename(test.kwargs['cwd']) == 'depot_tools'): |
| 198 | test.kwargs['cwd'] = os.path.dirname(test.kwargs['cwd']) |
| 199 | cmd[1] = os.path.join('depot_tools', cmd[1]) |
| 200 | |
Edward Lemur | ecc2707 | 2020-01-06 16:42:34 +0000 | [diff] [blame] | 201 | return cmd |
| 202 | |
| 203 | def _RunWithTimeout(self, cmd, stdin, kwargs): |
| 204 | p = subprocess.Popen(cmd, **kwargs) |
| 205 | with Timer(self.timeout, p.terminate) as timer: |
| 206 | stdout, _ = sigint_handler.wait(p, stdin) |
| 207 | if timer.completed: |
| 208 | stdout = 'Process timed out after %ss\n%s' % (self.timeout, stdout) |
| 209 | return p.returncode, stdout |
| 210 | |
| 211 | def CallCommand(self, test): |
| 212 | """Runs an external program. |
| 213 | |
Edward Lemur | a5799e3 | 2020-01-17 19:26:51 +0000 | [diff] [blame] | 214 | This function converts invocation of .py files and invocations of 'python' |
Edward Lemur | ecc2707 | 2020-01-06 16:42:34 +0000 | [diff] [blame] | 215 | to vpython invocations. |
| 216 | """ |
| 217 | cmd = self._GetCommand(test) |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 218 | try: |
Edward Lemur | ecc2707 | 2020-01-06 16:42:34 +0000 | [diff] [blame] | 219 | start = time_time() |
| 220 | returncode, stdout = self._RunWithTimeout(cmd, test.stdin, test.kwargs) |
| 221 | duration = time_time() - start |
Edward Lemur | 7cf9438 | 2019-11-15 22:36:41 +0000 | [diff] [blame] | 222 | except Exception: |
Edward Lemur | ecc2707 | 2020-01-06 16:42:34 +0000 | [diff] [blame] | 223 | duration = time_time() - start |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 224 | return test.message( |
Edward Lemur | 7cf9438 | 2019-11-15 22:36:41 +0000 | [diff] [blame] | 225 | '%s\n%s exec failure (%4.2fs)\n%s' % ( |
| 226 | test.name, ' '.join(cmd), duration, traceback.format_exc())) |
Edward Lemur | de9e3ca | 2019-10-24 21:13:31 +0000 | [diff] [blame] | 227 | |
Edward Lemur | ecc2707 | 2020-01-06 16:42:34 +0000 | [diff] [blame] | 228 | if returncode != 0: |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 229 | return test.message( |
Edward Lemur | 7cf9438 | 2019-11-15 22:36:41 +0000 | [diff] [blame] | 230 | '%s\n%s (%4.2fs) failed\n%s' % ( |
| 231 | test.name, ' '.join(cmd), duration, stdout)) |
Edward Lemur | ecc2707 | 2020-01-06 16:42:34 +0000 | [diff] [blame] | 232 | |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 233 | if test.info: |
Edward Lemur | 7cf9438 | 2019-11-15 22:36:41 +0000 | [diff] [blame] | 234 | return test.info('%s\n%s (%4.2fs)' % (test.name, ' '.join(cmd), duration)) |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 235 | |
| 236 | def AddTests(self, tests, parallel=True): |
| 237 | if parallel: |
| 238 | self._tests.extend(tests) |
| 239 | else: |
| 240 | self._nonparallel_tests.extend(tests) |
| 241 | |
| 242 | def RunAsync(self): |
| 243 | self._messages = [] |
| 244 | |
| 245 | def _WorkerFn(): |
| 246 | while True: |
| 247 | test = None |
| 248 | with self._tests_lock: |
| 249 | if not self._tests: |
| 250 | break |
| 251 | test = self._tests.pop() |
| 252 | result = self.CallCommand(test) |
| 253 | if result: |
| 254 | with self._messages_lock: |
| 255 | self._messages.append(result) |
| 256 | |
| 257 | def _StartDaemon(): |
| 258 | t = threading.Thread(target=_WorkerFn) |
| 259 | t.daemon = True |
| 260 | t.start() |
| 261 | return t |
| 262 | |
| 263 | while self._nonparallel_tests: |
| 264 | test = self._nonparallel_tests.pop() |
| 265 | result = self.CallCommand(test) |
| 266 | if result: |
| 267 | self._messages.append(result) |
| 268 | |
| 269 | if self._tests: |
| 270 | threads = [_StartDaemon() for _ in range(self._pool_size)] |
| 271 | for worker in threads: |
| 272 | worker.join() |
| 273 | |
| 274 | return self._messages |
| 275 | |
| 276 | |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 277 | def normpath(path): |
| 278 | '''Version of os.path.normpath that also changes backward slashes to |
| 279 | forward slashes when not running on Windows. |
| 280 | ''' |
| 281 | # This is safe to always do because the Windows version of os.path.normpath |
| 282 | # will replace forward slashes with backward slashes. |
| 283 | path = path.replace(os.sep, '/') |
| 284 | return os.path.normpath(path) |
| 285 | |
maruel@chromium.org | cb2985f | 2010-11-03 14:08:31 +0000 | [diff] [blame] | 286 | |
maruel@chromium.org | cb2985f | 2010-11-03 14:08:31 +0000 | [diff] [blame] | 287 | def _RightHandSideLinesImpl(affected_files): |
| 288 | """Implements RightHandSideLines for InputApi and GclChange.""" |
| 289 | for af in affected_files: |
maruel@chromium.org | ab05d58 | 2011-02-09 23:41:22 +0000 | [diff] [blame] | 290 | lines = af.ChangedContents() |
maruel@chromium.org | cb2985f | 2010-11-03 14:08:31 +0000 | [diff] [blame] | 291 | for line in lines: |
maruel@chromium.org | ab05d58 | 2011-02-09 23:41:22 +0000 | [diff] [blame] | 292 | yield (af, line[0], line[1]) |
maruel@chromium.org | cb2985f | 2010-11-03 14:08:31 +0000 | [diff] [blame] | 293 | |
| 294 | |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 295 | def prompt_should_continue(prompt_string): |
| 296 | sys.stdout.write(prompt_string) |
| 297 | response = sys.stdin.readline().strip().lower() |
| 298 | return response in ('y', 'yes') |
dpranke@chromium.org | 5ac2101 | 2011-03-16 02:58:25 +0000 | [diff] [blame] | 299 | |
| 300 | |
ilevy@chromium.org | bc11731 | 2013-04-20 03:57:56 +0000 | [diff] [blame] | 301 | # Top level object so multiprocessing can pickle |
| 302 | # Public access through OutputApi object. |
| 303 | class _PresubmitResult(object): |
| 304 | """Base class for result objects.""" |
| 305 | fatal = False |
| 306 | should_prompt = False |
| 307 | |
| 308 | def __init__(self, message, items=None, long_text=''): |
| 309 | """ |
| 310 | message: A short one-line message to indicate errors. |
| 311 | items: A list of short strings to indicate where errors occurred. |
| 312 | long_text: multi-line text output, e.g. from another tool |
| 313 | """ |
| 314 | self._message = message |
| 315 | self._items = items or [] |
ilevy@chromium.org | bc11731 | 2013-04-20 03:57:56 +0000 | [diff] [blame] | 316 | self._long_text = long_text.rstrip() |
| 317 | |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 318 | def handle(self): |
| 319 | sys.stdout.write(self._message) |
| 320 | sys.stdout.write('\n') |
ilevy@chromium.org | bc11731 | 2013-04-20 03:57:56 +0000 | [diff] [blame] | 321 | for index, item in enumerate(self._items): |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 322 | sys.stdout.write(' ') |
ilevy@chromium.org | bc11731 | 2013-04-20 03:57:56 +0000 | [diff] [blame] | 323 | # Write separately in case it's unicode. |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 324 | sys.stdout.write(str(item)) |
ilevy@chromium.org | bc11731 | 2013-04-20 03:57:56 +0000 | [diff] [blame] | 325 | if index < len(self._items) - 1: |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 326 | sys.stdout.write(' \\') |
| 327 | sys.stdout.write('\n') |
ilevy@chromium.org | bc11731 | 2013-04-20 03:57:56 +0000 | [diff] [blame] | 328 | if self._long_text: |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 329 | sys.stdout.write('\n***************\n') |
ilevy@chromium.org | bc11731 | 2013-04-20 03:57:56 +0000 | [diff] [blame] | 330 | # Write separately in case it's unicode. |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 331 | sys.stdout.write(self._long_text) |
| 332 | sys.stdout.write('\n***************\n') |
ilevy@chromium.org | bc11731 | 2013-04-20 03:57:56 +0000 | [diff] [blame] | 333 | |
Debrian Figueroa | dd2737e | 2019-06-21 23:50:13 +0000 | [diff] [blame] | 334 | def json_format(self): |
| 335 | return { |
| 336 | 'message': self._message, |
Debrian Figueroa | 6095d40 | 2019-06-28 18:47:18 +0000 | [diff] [blame] | 337 | 'items': [str(item) for item in self._items], |
Debrian Figueroa | dd2737e | 2019-06-21 23:50:13 +0000 | [diff] [blame] | 338 | 'long_text': self._long_text, |
| 339 | 'fatal': self.fatal |
| 340 | } |
| 341 | |
ilevy@chromium.org | bc11731 | 2013-04-20 03:57:56 +0000 | [diff] [blame] | 342 | |
| 343 | # Top level object so multiprocessing can pickle |
| 344 | # Public access through OutputApi object. |
ilevy@chromium.org | bc11731 | 2013-04-20 03:57:56 +0000 | [diff] [blame] | 345 | class _PresubmitError(_PresubmitResult): |
| 346 | """A hard presubmit error.""" |
| 347 | fatal = True |
| 348 | |
| 349 | |
| 350 | # Top level object so multiprocessing can pickle |
| 351 | # Public access through OutputApi object. |
| 352 | class _PresubmitPromptWarning(_PresubmitResult): |
| 353 | """An warning that prompts the user if they want to continue.""" |
| 354 | should_prompt = True |
| 355 | |
| 356 | |
| 357 | # Top level object so multiprocessing can pickle |
| 358 | # Public access through OutputApi object. |
| 359 | class _PresubmitNotifyResult(_PresubmitResult): |
| 360 | """Just print something to the screen -- but it's not even a warning.""" |
| 361 | pass |
| 362 | |
| 363 | |
| 364 | # Top level object so multiprocessing can pickle |
| 365 | # Public access through OutputApi object. |
| 366 | class _MailTextResult(_PresubmitResult): |
| 367 | """A warning that should be included in the review request email.""" |
| 368 | def __init__(self, *args, **kwargs): |
| 369 | super(_MailTextResult, self).__init__() |
| 370 | raise NotImplementedError() |
| 371 | |
tandrii@chromium.org | 37b07a7 | 2016-04-29 16:42:28 +0000 | [diff] [blame] | 372 | class GerritAccessor(object): |
| 373 | """Limited Gerrit functionality for canned presubmit checks to work. |
| 374 | |
| 375 | To avoid excessive Gerrit calls, caches the results. |
| 376 | """ |
| 377 | |
| 378 | def __init__(self, host): |
| 379 | self.host = host |
| 380 | self.cache = {} |
| 381 | |
| 382 | def _FetchChangeDetail(self, issue): |
| 383 | # Separate function to be easily mocked in tests. |
Andrii Shyshkalov | c6c8b4c | 2016-11-09 20:51:20 +0100 | [diff] [blame] | 384 | try: |
| 385 | return gerrit_util.GetChangeDetail( |
| 386 | self.host, str(issue), |
Aaron Gable | 6f5a8d9 | 2017-04-18 14:49:05 -0700 | [diff] [blame] | 387 | ['ALL_REVISIONS', 'DETAILED_LABELS', 'ALL_COMMITS']) |
Andrii Shyshkalov | c6c8b4c | 2016-11-09 20:51:20 +0100 | [diff] [blame] | 388 | except gerrit_util.GerritError as e: |
| 389 | if e.http_status == 404: |
| 390 | raise Exception('Either Gerrit issue %s doesn\'t exist, or ' |
| 391 | 'no credentials to fetch issue details' % issue) |
| 392 | raise |
tandrii@chromium.org | 37b07a7 | 2016-04-29 16:42:28 +0000 | [diff] [blame] | 393 | |
| 394 | def GetChangeInfo(self, issue): |
| 395 | """Returns labels and all revisions (patchsets) for this issue. |
| 396 | |
| 397 | The result is a dictionary according to Gerrit REST Api. |
| 398 | https://gerrit-review.googlesource.com/Documentation/rest-api.html |
| 399 | |
| 400 | However, API isn't very clear what's inside, so see tests for example. |
| 401 | """ |
| 402 | assert issue |
| 403 | cache_key = int(issue) |
| 404 | if cache_key not in self.cache: |
| 405 | self.cache[cache_key] = self._FetchChangeDetail(issue) |
| 406 | return self.cache[cache_key] |
| 407 | |
| 408 | def GetChangeDescription(self, issue, patchset=None): |
| 409 | """If patchset is none, fetches current patchset.""" |
| 410 | info = self.GetChangeInfo(issue) |
| 411 | # info is a reference to cache. We'll modify it here adding description to |
| 412 | # it to the right patchset, if it is not yet there. |
| 413 | |
| 414 | # Find revision info for the patchset we want. |
| 415 | if patchset is not None: |
Marc-Antoine Ruel | 8e57b4b | 2019-10-11 01:01:36 +0000 | [diff] [blame] | 416 | for rev, rev_info in info['revisions'].items(): |
tandrii@chromium.org | 37b07a7 | 2016-04-29 16:42:28 +0000 | [diff] [blame] | 417 | if str(rev_info['_number']) == str(patchset): |
| 418 | break |
| 419 | else: |
| 420 | raise Exception('patchset %s doesn\'t exist in issue %s' % ( |
| 421 | patchset, issue)) |
| 422 | else: |
| 423 | rev = info['current_revision'] |
| 424 | rev_info = info['revisions'][rev] |
| 425 | |
Andrii Shyshkalov | 9c3a464 | 2017-01-24 17:41:22 +0100 | [diff] [blame] | 426 | return rev_info['commit']['message'] |
tandrii@chromium.org | 37b07a7 | 2016-04-29 16:42:28 +0000 | [diff] [blame] | 427 | |
Mun Yong Jang | 603d01e | 2017-12-19 16:38:30 -0800 | [diff] [blame] | 428 | def GetDestRef(self, issue): |
| 429 | ref = self.GetChangeInfo(issue)['branch'] |
| 430 | if not ref.startswith('refs/'): |
| 431 | # NOTE: it is possible to create 'refs/x' branch, |
| 432 | # aka 'refs/heads/refs/x'. However, this is ill-advised. |
| 433 | ref = 'refs/heads/%s' % ref |
| 434 | return ref |
| 435 | |
tandrii@chromium.org | 37b07a7 | 2016-04-29 16:42:28 +0000 | [diff] [blame] | 436 | def GetChangeOwner(self, issue): |
| 437 | return self.GetChangeInfo(issue)['owner']['email'] |
| 438 | |
| 439 | def GetChangeReviewers(self, issue, approving_only=True): |
Aaron Gable | 8b478f0 | 2017-07-31 15:33:19 -0700 | [diff] [blame] | 440 | changeinfo = self.GetChangeInfo(issue) |
| 441 | if approving_only: |
| 442 | labelinfo = changeinfo.get('labels', {}).get('Code-Review', {}) |
| 443 | values = labelinfo.get('values', {}).keys() |
| 444 | try: |
| 445 | max_value = max(int(v) for v in values) |
| 446 | reviewers = [r for r in labelinfo.get('all', []) |
| 447 | if r.get('value', 0) == max_value] |
| 448 | except ValueError: # values is the empty list |
| 449 | reviewers = [] |
| 450 | else: |
| 451 | reviewers = changeinfo.get('reviewers', {}).get('REVIEWER', []) |
| 452 | return [r.get('email') for r in reviewers] |
tandrii@chromium.org | 37b07a7 | 2016-04-29 16:42:28 +0000 | [diff] [blame] | 453 | |
Edward Lemur | e4d329c | 2020-02-03 20:41:18 +0000 | [diff] [blame] | 454 | def UpdateDescription(self, description, issue): |
| 455 | gerrit_util.SetCommitMessage(self.host, issue, description, notify='NONE') |
| 456 | |
ilevy@chromium.org | bc11731 | 2013-04-20 03:57:56 +0000 | [diff] [blame] | 457 | |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 458 | class OutputApi(object): |
wez@chromium.org | a6d011e | 2013-03-26 17:31:49 +0000 | [diff] [blame] | 459 | """An instance of OutputApi gets passed to presubmit scripts so that they |
| 460 | can output various types of results. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 461 | """ |
ilevy@chromium.org | bc11731 | 2013-04-20 03:57:56 +0000 | [diff] [blame] | 462 | PresubmitResult = _PresubmitResult |
ilevy@chromium.org | bc11731 | 2013-04-20 03:57:56 +0000 | [diff] [blame] | 463 | PresubmitError = _PresubmitError |
| 464 | PresubmitPromptWarning = _PresubmitPromptWarning |
| 465 | PresubmitNotifyResult = _PresubmitNotifyResult |
| 466 | MailTextResult = _MailTextResult |
| 467 | |
wez@chromium.org | a6d011e | 2013-03-26 17:31:49 +0000 | [diff] [blame] | 468 | def __init__(self, is_committing): |
| 469 | self.is_committing = is_committing |
Daniel Cheng | 7227d21 | 2017-11-17 08:12:37 -0800 | [diff] [blame] | 470 | self.more_cc = [] |
| 471 | |
| 472 | def AppendCC(self, cc): |
| 473 | """Appends a user to cc for this change.""" |
| 474 | self.more_cc.append(cc) |
wez@chromium.org | a6d011e | 2013-03-26 17:31:49 +0000 | [diff] [blame] | 475 | |
wez@chromium.org | a6d011e | 2013-03-26 17:31:49 +0000 | [diff] [blame] | 476 | def PresubmitPromptOrNotify(self, *args, **kwargs): |
| 477 | """Warn the user when uploading, but only notify if committing.""" |
| 478 | if self.is_committing: |
| 479 | return self.PresubmitNotifyResult(*args, **kwargs) |
| 480 | return self.PresubmitPromptWarning(*args, **kwargs) |
| 481 | |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 482 | |
| 483 | class InputApi(object): |
| 484 | """An instance of this object is passed to presubmit scripts so they can |
| 485 | know stuff about the change they're looking at. |
| 486 | """ |
maruel@chromium.org | b17b55b | 2010-11-03 14:42:37 +0000 | [diff] [blame] | 487 | # Method could be a function |
Quinten Yearsley | b2cc4a9 | 2016-12-15 13:53:26 -0800 | [diff] [blame] | 488 | # pylint: disable=no-self-use |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 489 | |
maruel@chromium.org | 3410d91 | 2009-06-09 20:56:16 +0000 | [diff] [blame] | 490 | # File extensions that are considered source files from a style guide |
| 491 | # perspective. Don't modify this list from a presubmit script! |
maruel@chromium.org | c33455a | 2011-06-24 19:14:18 +0000 | [diff] [blame] | 492 | # |
| 493 | # Files without an extension aren't included in the list. If you want to |
local_bot | 30f774e | 2020-06-25 18:23:34 +0000 | [diff] [blame] | 494 | # filter them as source files, add r'(^|.*?[\\\/])[^.]+$' to the allow list. |
local_bot | 6402141 | 2020-07-08 21:05:39 +0000 | [diff] [blame] | 495 | # Note that ALL CAPS files are skipped in DEFAULT_FILES_TO_SKIP below. |
| 496 | DEFAULT_FILES_TO_CHECK = ( |
maruel@chromium.org | 3410d91 | 2009-06-09 20:56:16 +0000 | [diff] [blame] | 497 | # C++ and friends |
Edward Lemur | a5799e3 | 2020-01-17 19:26:51 +0000 | [diff] [blame] | 498 | r'.+\.c$', r'.+\.cc$', r'.+\.cpp$', r'.+\.h$', r'.+\.m$', r'.+\.mm$', |
| 499 | r'.+\.inl$', r'.+\.asm$', r'.+\.hxx$', r'.+\.hpp$', r'.+\.s$', r'.+\.S$', |
maruel@chromium.org | 3410d91 | 2009-06-09 20:56:16 +0000 | [diff] [blame] | 500 | # Scripts |
Edward Lemur | a5799e3 | 2020-01-17 19:26:51 +0000 | [diff] [blame] | 501 | r'.+\.js$', r'.+\.py$', r'.+\.sh$', r'.+\.rb$', r'.+\.pl$', r'.+\.pm$', |
maruel@chromium.org | 3410d91 | 2009-06-09 20:56:16 +0000 | [diff] [blame] | 502 | # Other |
Edward Lemur | a5799e3 | 2020-01-17 19:26:51 +0000 | [diff] [blame] | 503 | r'.+\.java$', r'.+\.mk$', r'.+\.am$', r'.+\.css$', r'.+\.mojom$', |
| 504 | r'.+\.fidl$' |
maruel@chromium.org | 3410d91 | 2009-06-09 20:56:16 +0000 | [diff] [blame] | 505 | ) |
| 506 | |
| 507 | # Path regexp that should be excluded from being considered containing source |
| 508 | # files. Don't modify this list from a presubmit script! |
local_bot | 6402141 | 2020-07-08 21:05:39 +0000 | [diff] [blame] | 509 | DEFAULT_FILES_TO_SKIP = ( |
Edward Lemur | a5799e3 | 2020-01-17 19:26:51 +0000 | [diff] [blame] | 510 | r'testing_support[\\\/]google_appengine[\\\/].*', |
| 511 | r'.*\bexperimental[\\\/].*', |
Kent Tamura | 179dd1e | 2018-04-26 15:07:41 +0900 | [diff] [blame] | 512 | # Exclude third_party/.* but NOT third_party/{WebKit,blink} |
| 513 | # (crbug.com/539768 and crbug.com/836555). |
Edward Lemur | a5799e3 | 2020-01-17 19:26:51 +0000 | [diff] [blame] | 514 | r'.*\bthird_party[\\\/](?!(WebKit|blink)[\\\/]).*', |
maruel@chromium.org | 3410d91 | 2009-06-09 20:56:16 +0000 | [diff] [blame] | 515 | # Output directories (just in case) |
Edward Lemur | a5799e3 | 2020-01-17 19:26:51 +0000 | [diff] [blame] | 516 | r'.*\bDebug[\\\/].*', |
| 517 | r'.*\bRelease[\\\/].*', |
| 518 | r'.*\bxcodebuild[\\\/].*', |
| 519 | r'.*\bout[\\\/].*', |
maruel@chromium.org | 3410d91 | 2009-06-09 20:56:16 +0000 | [diff] [blame] | 520 | # All caps files like README and LICENCE. |
Edward Lemur | a5799e3 | 2020-01-17 19:26:51 +0000 | [diff] [blame] | 521 | r'.*\b[A-Z0-9_]{2,}$', |
maruel@chromium.org | df1595a | 2009-06-11 02:00:13 +0000 | [diff] [blame] | 522 | # SCM (can happen in dual SCM configuration). (Slightly over aggressive) |
Edward Lemur | a5799e3 | 2020-01-17 19:26:51 +0000 | [diff] [blame] | 523 | r'(|.*[\\\/])\.git[\\\/].*', |
| 524 | r'(|.*[\\\/])\.svn[\\\/].*', |
maruel@chromium.org | 7ccb4bb | 2011-11-07 20:26:20 +0000 | [diff] [blame] | 525 | # There is no point in processing a patch file. |
Edward Lemur | a5799e3 | 2020-01-17 19:26:51 +0000 | [diff] [blame] | 526 | r'.+\.diff$', |
| 527 | r'.+\.patch$', |
maruel@chromium.org | 3410d91 | 2009-06-09 20:56:16 +0000 | [diff] [blame] | 528 | ) |
| 529 | |
local_bot | 30f774e | 2020-06-25 18:23:34 +0000 | [diff] [blame] | 530 | # TODO(https://crbug.com/1098562): Remove once no longer used |
| 531 | @property |
| 532 | def DEFAULT_WHITE_LIST(self): |
local_bot | 6402141 | 2020-07-08 21:05:39 +0000 | [diff] [blame] | 533 | return self.DEFAULT_FILES_TO_CHECK |
local_bot | 30f774e | 2020-06-25 18:23:34 +0000 | [diff] [blame] | 534 | |
| 535 | # TODO(https://crbug.com/1098562): Remove once no longer used |
local_bot | 37ce201 | 2020-06-26 17:39:24 +0000 | [diff] [blame] | 536 | @DEFAULT_WHITE_LIST.setter |
| 537 | def DEFAULT_WHITE_LIST(self, value): |
local_bot | 6402141 | 2020-07-08 21:05:39 +0000 | [diff] [blame] | 538 | self.DEFAULT_FILES_TO_CHECK = value |
| 539 | |
| 540 | # TODO(https://crbug.com/1098562): Remove once no longer used |
| 541 | @property |
| 542 | def DEFAULT_ALLOW_LIST(self): |
| 543 | return self.DEFAULT_FILES_TO_CHECK |
| 544 | |
| 545 | # TODO(https://crbug.com/1098562): Remove once no longer used |
| 546 | @DEFAULT_ALLOW_LIST.setter |
| 547 | def DEFAULT_ALLOW_LIST(self, value): |
| 548 | self.DEFAULT_FILES_TO_CHECK = value |
local_bot | 37ce201 | 2020-06-26 17:39:24 +0000 | [diff] [blame] | 549 | |
| 550 | # TODO(https://crbug.com/1098562): Remove once no longer used |
local_bot | 30f774e | 2020-06-25 18:23:34 +0000 | [diff] [blame] | 551 | @property |
| 552 | def DEFAULT_BLACK_LIST(self): |
local_bot | 6402141 | 2020-07-08 21:05:39 +0000 | [diff] [blame] | 553 | return self.DEFAULT_FILES_TO_SKIP |
local_bot | 30f774e | 2020-06-25 18:23:34 +0000 | [diff] [blame] | 554 | |
local_bot | 37ce201 | 2020-06-26 17:39:24 +0000 | [diff] [blame] | 555 | # TODO(https://crbug.com/1098562): Remove once no longer used |
| 556 | @DEFAULT_BLACK_LIST.setter |
| 557 | def DEFAULT_BLACK_LIST(self, value): |
local_bot | 6402141 | 2020-07-08 21:05:39 +0000 | [diff] [blame] | 558 | self.DEFAULT_FILES_TO_SKIP = value |
| 559 | |
| 560 | # TODO(https://crbug.com/1098562): Remove once no longer used |
| 561 | @property |
| 562 | def DEFAULT_BLOCK_LIST(self): |
| 563 | return self.DEFAULT_FILES_TO_SKIP |
| 564 | |
| 565 | # TODO(https://crbug.com/1098562): Remove once no longer used |
| 566 | @DEFAULT_BLOCK_LIST.setter |
| 567 | def DEFAULT_BLOCK_LIST(self, value): |
| 568 | self.DEFAULT_FILES_TO_SKIP = value |
local_bot | 37ce201 | 2020-06-26 17:39:24 +0000 | [diff] [blame] | 569 | |
maruel@chromium.org | cc73ad6 | 2011-07-06 17:39:26 +0000 | [diff] [blame] | 570 | def __init__(self, change, presubmit_path, is_committing, |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 571 | verbose, gerrit_obj, dry_run=None, thread_pool=None, parallel=False): |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 572 | """Builds an InputApi object. |
| 573 | |
| 574 | Args: |
maruel@chromium.org | 4ff922a | 2009-06-12 20:20:19 +0000 | [diff] [blame] | 575 | change: A presubmit.Change object. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 576 | presubmit_path: The path to the presubmit script being processed. |
maruel@chromium.org | d7dccf5 | 2009-06-06 18:51:58 +0000 | [diff] [blame] | 577 | is_committing: True if the change is about to be committed. |
tandrii@chromium.org | 37b07a7 | 2016-04-29 16:42:28 +0000 | [diff] [blame] | 578 | gerrit_obj: provides basic Gerrit codereview functionality. |
| 579 | dry_run: if true, some Checks will be skipped. |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 580 | parallel: if true, all tests reported via input_api.RunTests for all |
| 581 | PRESUBMIT files will be run in parallel. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 582 | """ |
maruel@chromium.org | 9711bba | 2009-05-22 23:51:39 +0000 | [diff] [blame] | 583 | # Version number of the presubmit_support script. |
| 584 | self.version = [int(x) for x in __version__.split('.')] |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 585 | self.change = change |
maruel@chromium.org | d7dccf5 | 2009-06-06 18:51:58 +0000 | [diff] [blame] | 586 | self.is_committing = is_committing |
tandrii@chromium.org | 37b07a7 | 2016-04-29 16:42:28 +0000 | [diff] [blame] | 587 | self.gerrit = gerrit_obj |
tandrii@chromium.org | 57bafac | 2016-04-28 05:09:03 +0000 | [diff] [blame] | 588 | self.dry_run = dry_run |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 589 | |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 590 | self.parallel = parallel |
| 591 | self.thread_pool = thread_pool or ThreadPool() |
| 592 | |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 593 | # We expose various modules and functions as attributes of the input_api |
| 594 | # so that presubmit scripts don't have to import them. |
Takeshi Yoshino | 07a6bea | 2017-08-02 02:44:06 +0900 | [diff] [blame] | 595 | self.ast = ast |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 596 | self.basename = os.path.basename |
enne@chromium.org | e72c5f5 | 2013-04-16 00:36:40 +0000 | [diff] [blame] | 597 | self.cpplint = cpplint |
dcheng | 091b7db | 2016-06-16 01:27:51 -0700 | [diff] [blame] | 598 | self.fnmatch = fnmatch |
Yoshisato Yanagisawa | 04600b4 | 2019-03-15 03:03:41 +0000 | [diff] [blame] | 599 | self.gclient_paths = gclient_paths |
Yoshisato Yanagisawa | 57dd17b | 2019-03-22 09:10:29 +0000 | [diff] [blame] | 600 | # TODO(yyanagisawa): stop exposing this when python3 become default. |
| 601 | # Since python3's tempfile has TemporaryDirectory, we do not need this. |
| 602 | self.temporary_directory = gclient_utils.temporary_directory |
dpranke@chromium.org | 17cc244 | 2012-10-17 21:12:09 +0000 | [diff] [blame] | 603 | self.glob = glob.glob |
maruel@chromium.org | fb11c7b | 2010-03-18 18:22:14 +0000 | [diff] [blame] | 604 | self.json = json |
maruel@chromium.org | 6fba34d | 2011-06-02 13:45:12 +0000 | [diff] [blame] | 605 | self.logging = logging.getLogger('PRESUBMIT') |
maruel@chromium.org | 2b5ce56 | 2011-03-31 16:15:44 +0000 | [diff] [blame] | 606 | self.os_listdir = os.listdir |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 607 | self.os_path = os.path |
pgervais@chromium.org | bd0cace | 2014-10-02 23:23:46 +0000 | [diff] [blame] | 608 | self.os_stat = os.stat |
Yoshisato Yanagisawa | 406de13 | 2018-06-29 05:43:25 +0000 | [diff] [blame] | 609 | self.os_walk = os.walk |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 610 | self.re = re |
| 611 | self.subprocess = subprocess |
Edward Lemur | b983024 | 2019-10-30 22:19:20 +0000 | [diff] [blame] | 612 | self.sys = sys |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 613 | self.tempfile = tempfile |
dpranke@chromium.org | 0d1bdea | 2011-03-24 22:54:38 +0000 | [diff] [blame] | 614 | self.time = time |
maruel@chromium.org | 1487d53 | 2009-06-06 00:22:57 +0000 | [diff] [blame] | 615 | self.unittest = unittest |
Edward Lemur | b983024 | 2019-10-30 22:19:20 +0000 | [diff] [blame] | 616 | if sys.version_info.major == 2: |
| 617 | self.urllib2 = urllib2 |
Edward Lemur | 16af356 | 2019-10-17 22:11:33 +0000 | [diff] [blame] | 618 | self.urllib_request = urllib_request |
| 619 | self.urllib_error = urllib_error |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 620 | |
Robert Iannucci | 5025893 | 2018-03-19 10:30:59 -0700 | [diff] [blame] | 621 | self.is_windows = sys.platform == 'win32' |
| 622 | |
Edward Lemur | b964662 | 2019-10-25 20:57:35 +0000 | [diff] [blame] | 623 | # Set python_executable to 'vpython' in order to allow scripts in other |
| 624 | # repos (e.g. src.git) to automatically pick up that repo's .vpython file, |
| 625 | # instead of inheriting the one in depot_tools. |
| 626 | self.python_executable = 'vpython' |
maruel@chromium.org | c0b2297 | 2009-06-25 16:19:14 +0000 | [diff] [blame] | 627 | self.environ = os.environ |
| 628 | |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 629 | # InputApi.platform is the platform you're currently running on. |
| 630 | self.platform = sys.platform |
| 631 | |
iannucci@chromium.org | 0af3bb3 | 2015-06-12 20:44:35 +0000 | [diff] [blame] | 632 | self.cpu_count = multiprocessing.cpu_count() |
| 633 | |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 634 | # The local path of the currently-being-processed presubmit script. |
maruel@chromium.org | 3d23524 | 2009-05-15 12:40:48 +0000 | [diff] [blame] | 635 | self._current_presubmit_path = os.path.dirname(presubmit_path) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 636 | |
| 637 | # We carry the canned checks so presubmit scripts can easily use them. |
| 638 | self.canned_checks = presubmit_canned_checks |
| 639 | |
Raphael Kubo da Costa | f2d1615 | 2017-11-10 18:07:58 +0100 | [diff] [blame] | 640 | # Temporary files we must manually remove at the end of a run. |
| 641 | self._named_temporary_files = [] |
Jochen Eisinger | 72606f8 | 2017-04-04 10:44:18 +0200 | [diff] [blame] | 642 | |
dpranke@chromium.org | 2a00962 | 2011-03-01 02:43:31 +0000 | [diff] [blame] | 643 | # TODO(dpranke): figure out a list of all approved owners for a repo |
| 644 | # in order to be able to handle wildcard OWNERS files? |
| 645 | self.owners_db = owners.Database(change.RepositoryRoot(), |
Edward Lemur | b983024 | 2019-10-30 22:19:20 +0000 | [diff] [blame] | 646 | fopen=open, os_path=self.os_path) |
Jochen Eisinger | 76f5fc6 | 2017-04-07 16:27:46 +0200 | [diff] [blame] | 647 | self.owners_finder = owners_finder.OwnersFinder |
maruel@chromium.org | 899e1c1 | 2011-04-07 17:03:18 +0000 | [diff] [blame] | 648 | self.verbose = verbose |
ilevy@chromium.org | bc11731 | 2013-04-20 03:57:56 +0000 | [diff] [blame] | 649 | self.Command = CommandData |
dpranke@chromium.org | 2a00962 | 2011-03-01 02:43:31 +0000 | [diff] [blame] | 650 | |
enne@chromium.org | e72c5f5 | 2013-04-16 00:36:40 +0000 | [diff] [blame] | 651 | # Replace <hash_map> and <hash_set> as headers that need to be included |
Edward Lemur | a5799e3 | 2020-01-17 19:26:51 +0000 | [diff] [blame] | 652 | # with 'base/containers/hash_tables.h' instead. |
enne@chromium.org | e72c5f5 | 2013-04-16 00:36:40 +0000 | [diff] [blame] | 653 | # Access to a protected member _XX of a client class |
Quinten Yearsley | b2cc4a9 | 2016-12-15 13:53:26 -0800 | [diff] [blame] | 654 | # pylint: disable=protected-access |
enne@chromium.org | e72c5f5 | 2013-04-16 00:36:40 +0000 | [diff] [blame] | 655 | self.cpplint._re_pattern_templates = [ |
danakj@chromium.org | 1827852 | 2013-06-11 22:42:32 +0000 | [diff] [blame] | 656 | (a, b, 'base/containers/hash_tables.h') |
enne@chromium.org | e72c5f5 | 2013-04-16 00:36:40 +0000 | [diff] [blame] | 657 | if header in ('<hash_map>', '<hash_set>') else (a, b, header) |
| 658 | for (a, b, header) in cpplint._re_pattern_templates |
| 659 | ] |
| 660 | |
Edward Lemur | ecc2707 | 2020-01-06 16:42:34 +0000 | [diff] [blame] | 661 | def SetTimeout(self, timeout): |
| 662 | self.thread_pool.timeout = timeout |
| 663 | |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 664 | def PresubmitLocalPath(self): |
| 665 | """Returns the local path of the presubmit script currently being run. |
| 666 | |
| 667 | This is useful if you don't want to hard-code absolute paths in the |
| 668 | presubmit script. For example, It can be used to find another file |
| 669 | relative to the PRESUBMIT.py script, so the whole tree can be branched and |
| 670 | the presubmit script still works, without editing its content. |
| 671 | """ |
maruel@chromium.org | 3d23524 | 2009-05-15 12:40:48 +0000 | [diff] [blame] | 672 | return self._current_presubmit_path |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 673 | |
agable | 0b65e73 | 2016-11-22 09:25:46 -0800 | [diff] [blame] | 674 | def AffectedFiles(self, include_deletes=True, file_filter=None): |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 675 | """Same as input_api.change.AffectedFiles() except only lists files |
| 676 | (and optionally directories) in the same directory as the current presubmit |
Bruce Dawson | 7a0b07a | 2020-04-23 17:14:40 +0000 | [diff] [blame] | 677 | script, or subdirectories thereof. Note that files are listed using the OS |
| 678 | path separator, so backslashes are used as separators on Windows. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 679 | """ |
Edward Lemur | a5799e3 | 2020-01-17 19:26:51 +0000 | [diff] [blame] | 680 | dir_with_slash = normpath('%s/' % self.PresubmitLocalPath()) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 681 | if len(dir_with_slash) == 1: |
| 682 | dir_with_slash = '' |
sail@chromium.org | 5538e02 | 2011-05-12 17:53:16 +0000 | [diff] [blame] | 683 | |
Edward Lemur | b983024 | 2019-10-30 22:19:20 +0000 | [diff] [blame] | 684 | return list(filter( |
maruel@chromium.org | 4661e0c | 2009-06-04 00:45:26 +0000 | [diff] [blame] | 685 | lambda x: normpath(x.AbsoluteLocalPath()).startswith(dir_with_slash), |
Edward Lemur | b983024 | 2019-10-30 22:19:20 +0000 | [diff] [blame] | 686 | self.change.AffectedFiles(include_deletes, file_filter))) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 687 | |
agable | 0b65e73 | 2016-11-22 09:25:46 -0800 | [diff] [blame] | 688 | def LocalPaths(self): |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 689 | """Returns local paths of input_api.AffectedFiles().""" |
agable | 0b65e73 | 2016-11-22 09:25:46 -0800 | [diff] [blame] | 690 | paths = [af.LocalPath() for af in self.AffectedFiles()] |
Edward Lemur | a5799e3 | 2020-01-17 19:26:51 +0000 | [diff] [blame] | 691 | logging.debug('LocalPaths: %s', paths) |
pgervais@chromium.org | 2f64f78 | 2014-04-25 00:12:33 +0000 | [diff] [blame] | 692 | return paths |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 693 | |
agable | 0b65e73 | 2016-11-22 09:25:46 -0800 | [diff] [blame] | 694 | def AbsoluteLocalPaths(self): |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 695 | """Returns absolute local paths of input_api.AffectedFiles().""" |
agable | 0b65e73 | 2016-11-22 09:25:46 -0800 | [diff] [blame] | 696 | return [af.AbsoluteLocalPath() for af in self.AffectedFiles()] |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 697 | |
John Budorick | 1616237 | 2018-04-18 10:39:53 -0700 | [diff] [blame] | 698 | def AffectedTestableFiles(self, include_deletes=None, **kwargs): |
agable | 0b65e73 | 2016-11-22 09:25:46 -0800 | [diff] [blame] | 699 | """Same as input_api.change.AffectedTestableFiles() except only lists files |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 700 | in the same directory as the current presubmit script, or subdirectories |
| 701 | thereof. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 702 | """ |
maruel@chromium.org | 77c4f0f | 2009-05-29 18:53:04 +0000 | [diff] [blame] | 703 | if include_deletes is not None: |
Edward Lemur | a5799e3 | 2020-01-17 19:26:51 +0000 | [diff] [blame] | 704 | warn('AffectedTestableFiles(include_deletes=%s)' |
| 705 | ' is deprecated and ignored' % str(include_deletes), |
maruel@chromium.org | cb2985f | 2010-11-03 14:08:31 +0000 | [diff] [blame] | 706 | category=DeprecationWarning, |
| 707 | stacklevel=2) |
Edward Lemur | b983024 | 2019-10-30 22:19:20 +0000 | [diff] [blame] | 708 | return list(filter( |
| 709 | lambda x: x.IsTestableFile(), |
| 710 | self.AffectedFiles(include_deletes=False, **kwargs))) |
agable | 0b65e73 | 2016-11-22 09:25:46 -0800 | [diff] [blame] | 711 | |
| 712 | def AffectedTextFiles(self, include_deletes=None): |
| 713 | """An alias to AffectedTestableFiles for backwards compatibility.""" |
| 714 | return self.AffectedTestableFiles(include_deletes=include_deletes) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 715 | |
local_bot | 6402141 | 2020-07-08 21:05:39 +0000 | [diff] [blame] | 716 | def FilterSourceFile(self, affected_file, files_to_check=None, |
| 717 | files_to_skip=None, allow_list=None, block_list=None, |
local_bot | 30f774e | 2020-06-25 18:23:34 +0000 | [diff] [blame] | 718 | white_list=None, black_list=None): |
Edward Lemur | a5799e3 | 2020-01-17 19:26:51 +0000 | [diff] [blame] | 719 | """Filters out files that aren't considered 'source file'. |
maruel@chromium.org | 3410d91 | 2009-06-09 20:56:16 +0000 | [diff] [blame] | 720 | |
local_bot | 6402141 | 2020-07-08 21:05:39 +0000 | [diff] [blame] | 721 | If files_to_check or files_to_skip is None, InputApi.DEFAULT_FILES_TO_CHECK |
| 722 | and InputApi.DEFAULT_FILES_TO_SKIP is used respectively. |
maruel@chromium.org | 3410d91 | 2009-06-09 20:56:16 +0000 | [diff] [blame] | 723 | |
| 724 | The lists will be compiled as regular expression and |
| 725 | AffectedFile.LocalPath() needs to pass both list. |
| 726 | |
local_bot | 6402141 | 2020-07-08 21:05:39 +0000 | [diff] [blame] | 727 | Note: if files_to_check or files_to_skip is not set, and |
| 728 | white_list/allow_list or black_list/block_list is, then those values are |
| 729 | used. This is used for backward compatibility reasons. |
local_bot | 30f774e | 2020-06-25 18:23:34 +0000 | [diff] [blame] | 730 | |
maruel@chromium.org | 3410d91 | 2009-06-09 20:56:16 +0000 | [diff] [blame] | 731 | Note: Copy-paste this function to suit your needs or use a lambda function. |
| 732 | """ |
local_bot | 6402141 | 2020-07-08 21:05:39 +0000 | [diff] [blame] | 733 | # TODO(https://crbug.com/1098560): Add warnings before removing bc. |
| 734 | if files_to_check is None: |
| 735 | files_to_check = allow_list or white_list |
| 736 | if files_to_skip is None: |
| 737 | files_to_skip = block_list or black_list |
| 738 | |
| 739 | if files_to_check is None: |
| 740 | files_to_check = self.DEFAULT_FILES_TO_CHECK |
| 741 | if files_to_skip is None: |
| 742 | files_to_skip = self.DEFAULT_FILES_TO_SKIP |
local_bot | 30f774e | 2020-06-25 18:23:34 +0000 | [diff] [blame] | 743 | |
maruel@chromium.org | cb2985f | 2010-11-03 14:08:31 +0000 | [diff] [blame] | 744 | def Find(affected_file, items): |
maruel@chromium.org | ab05d58 | 2011-02-09 23:41:22 +0000 | [diff] [blame] | 745 | local_path = affected_file.LocalPath() |
maruel@chromium.org | cb2985f | 2010-11-03 14:08:31 +0000 | [diff] [blame] | 746 | for item in items: |
maruel@chromium.org | df1595a | 2009-06-11 02:00:13 +0000 | [diff] [blame] | 747 | if self.re.match(item, local_path): |
maruel@chromium.org | 3410d91 | 2009-06-09 20:56:16 +0000 | [diff] [blame] | 748 | return True |
| 749 | return False |
local_bot | 6402141 | 2020-07-08 21:05:39 +0000 | [diff] [blame] | 750 | return (Find(affected_file, files_to_check) and |
| 751 | not Find(affected_file, files_to_skip)) |
maruel@chromium.org | 3410d91 | 2009-06-09 20:56:16 +0000 | [diff] [blame] | 752 | |
| 753 | def AffectedSourceFiles(self, source_file): |
agable | 0b65e73 | 2016-11-22 09:25:46 -0800 | [diff] [blame] | 754 | """Filter the list of AffectedTestableFiles by the function source_file. |
maruel@chromium.org | 3410d91 | 2009-06-09 20:56:16 +0000 | [diff] [blame] | 755 | |
| 756 | If source_file is None, InputApi.FilterSourceFile() is used. |
| 757 | """ |
| 758 | if not source_file: |
| 759 | source_file = self.FilterSourceFile |
Edward Lemur | b983024 | 2019-10-30 22:19:20 +0000 | [diff] [blame] | 760 | return list(filter(source_file, self.AffectedTestableFiles())) |
maruel@chromium.org | 3410d91 | 2009-06-09 20:56:16 +0000 | [diff] [blame] | 761 | |
| 762 | def RightHandSideLines(self, source_file_filter=None): |
Edward Lemur | a5799e3 | 2020-01-17 19:26:51 +0000 | [diff] [blame] | 763 | """An iterator over all text lines in 'new' version of changed files. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 764 | |
| 765 | Only lists lines from new or modified text files in the change that are |
| 766 | contained by the directory of the currently executing presubmit script. |
| 767 | |
| 768 | This is useful for doing line-by-line regex checks, like checking for |
| 769 | trailing whitespace. |
| 770 | |
| 771 | Yields: |
| 772 | a 3 tuple: |
| 773 | the AffectedFile instance of the current file; |
| 774 | integer line number (1-based); and |
| 775 | the contents of the line as a string. |
maruel@chromium.org | 1487d53 | 2009-06-06 00:22:57 +0000 | [diff] [blame] | 776 | |
nick@chromium.org | 2a3ab7e | 2011-04-27 22:06:27 +0000 | [diff] [blame] | 777 | Note: The carriage return (LF or CR) is stripped off. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 778 | """ |
maruel@chromium.org | 3410d91 | 2009-06-09 20:56:16 +0000 | [diff] [blame] | 779 | files = self.AffectedSourceFiles(source_file_filter) |
maruel@chromium.org | cb2985f | 2010-11-03 14:08:31 +0000 | [diff] [blame] | 780 | return _RightHandSideLinesImpl(files) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 781 | |
maruel@chromium.org | e3608df | 2009-11-10 20:22:57 +0000 | [diff] [blame] | 782 | def ReadFile(self, file_item, mode='r'): |
maruel@chromium.org | 44a17ad | 2009-06-08 14:14:35 +0000 | [diff] [blame] | 783 | """Reads an arbitrary file. |
thestig@chromium.org | da8cddd | 2009-08-13 00:25:55 +0000 | [diff] [blame] | 784 | |
maruel@chromium.org | 44a17ad | 2009-06-08 14:14:35 +0000 | [diff] [blame] | 785 | Deny reading anything outside the repository. |
| 786 | """ |
maruel@chromium.org | e3608df | 2009-11-10 20:22:57 +0000 | [diff] [blame] | 787 | if isinstance(file_item, AffectedFile): |
| 788 | file_item = file_item.AbsoluteLocalPath() |
| 789 | if not file_item.startswith(self.change.RepositoryRoot()): |
maruel@chromium.org | 44a17ad | 2009-06-08 14:14:35 +0000 | [diff] [blame] | 790 | raise IOError('Access outside the repository root is denied.') |
maruel@chromium.org | 5aeb7dd | 2009-11-17 18:09:01 +0000 | [diff] [blame] | 791 | return gclient_utils.FileRead(file_item, mode) |
maruel@chromium.org | 44a17ad | 2009-06-08 14:14:35 +0000 | [diff] [blame] | 792 | |
Raphael Kubo da Costa | f2d1615 | 2017-11-10 18:07:58 +0100 | [diff] [blame] | 793 | def CreateTemporaryFile(self, **kwargs): |
| 794 | """Returns a named temporary file that must be removed with a call to |
| 795 | RemoveTemporaryFiles(). |
| 796 | |
| 797 | All keyword arguments are forwarded to tempfile.NamedTemporaryFile(), |
| 798 | except for |delete|, which is always set to False. |
| 799 | |
| 800 | Presubmit checks that need to create a temporary file and pass it for |
| 801 | reading should use this function instead of NamedTemporaryFile(), as |
| 802 | Windows fails to open a file that is already open for writing. |
| 803 | |
| 804 | with input_api.CreateTemporaryFile() as f: |
| 805 | f.write('xyz') |
| 806 | f.close() |
| 807 | input_api.subprocess.check_output(['script-that', '--reads-from', |
| 808 | f.name]) |
| 809 | |
| 810 | |
| 811 | Note that callers of CreateTemporaryFile() should not worry about removing |
| 812 | any temporary file; this is done transparently by the presubmit handling |
| 813 | code. |
| 814 | """ |
| 815 | if 'delete' in kwargs: |
| 816 | # Prevent users from passing |delete|; we take care of file deletion |
| 817 | # ourselves and this prevents unintuitive error messages when we pass |
| 818 | # delete=False and 'delete' is also in kwargs. |
| 819 | raise TypeError('CreateTemporaryFile() does not take a "delete" ' |
| 820 | 'argument, file deletion is handled automatically by ' |
| 821 | 'the same presubmit_support code that creates InputApi ' |
| 822 | 'objects.') |
| 823 | temp_file = self.tempfile.NamedTemporaryFile(delete=False, **kwargs) |
| 824 | self._named_temporary_files.append(temp_file.name) |
| 825 | return temp_file |
| 826 | |
maruel@chromium.org | cc73ad6 | 2011-07-06 17:39:26 +0000 | [diff] [blame] | 827 | @property |
| 828 | def tbr(self): |
| 829 | """Returns if a change is TBR'ed.""" |
Jeremy Roman | dce2250 | 2017-06-20 15:37:29 -0400 | [diff] [blame] | 830 | return 'TBR' in self.change.tags or self.change.TBRsFromDescription() |
maruel@chromium.org | cc73ad6 | 2011-07-06 17:39:26 +0000 | [diff] [blame] | 831 | |
maruel@chromium.org | ffeb2f3 | 2013-12-03 13:55:22 +0000 | [diff] [blame] | 832 | def RunTests(self, tests_mix, parallel=True): |
ilevy@chromium.org | bc11731 | 2013-04-20 03:57:56 +0000 | [diff] [blame] | 833 | tests = [] |
| 834 | msgs = [] |
| 835 | for t in tests_mix: |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 836 | if isinstance(t, OutputApi.PresubmitResult) and t: |
ilevy@chromium.org | bc11731 | 2013-04-20 03:57:56 +0000 | [diff] [blame] | 837 | msgs.append(t) |
| 838 | else: |
| 839 | assert issubclass(t.message, _PresubmitResult) |
| 840 | tests.append(t) |
maruel@chromium.org | ffeb2f3 | 2013-12-03 13:55:22 +0000 | [diff] [blame] | 841 | if self.verbose: |
| 842 | t.info = _PresubmitNotifyResult |
Edward Lemur | 1037c74 | 2018-05-01 18:56:04 -0400 | [diff] [blame] | 843 | if not t.kwargs.get('cwd'): |
| 844 | t.kwargs['cwd'] = self.PresubmitLocalPath() |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 845 | self.thread_pool.AddTests(tests, parallel) |
Edward Lemur | 21000eb | 2019-05-24 23:25:58 +0000 | [diff] [blame] | 846 | # When self.parallel is True (i.e. --parallel is passed as an option) |
| 847 | # RunTests doesn't actually run tests. It adds them to a ThreadPool that |
| 848 | # will run all tests once all PRESUBMIT files are processed. |
| 849 | # Otherwise, it will run them and return the results. |
| 850 | if not self.parallel: |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 851 | msgs.extend(self.thread_pool.RunAsync()) |
| 852 | return msgs |
scottmg | 86099d7 | 2016-09-01 09:16:51 -0700 | [diff] [blame] | 853 | |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 854 | |
nick@chromium.org | ff52619 | 2013-06-10 19:30:26 +0000 | [diff] [blame] | 855 | class _DiffCache(object): |
| 856 | """Caches diffs retrieved from a particular SCM.""" |
agable@chromium.org | ea84ef1 | 2014-04-30 19:55:12 +0000 | [diff] [blame] | 857 | def __init__(self, upstream=None): |
| 858 | """Stores the upstream revision against which all diffs will be computed.""" |
| 859 | self._upstream = upstream |
nick@chromium.org | ff52619 | 2013-06-10 19:30:26 +0000 | [diff] [blame] | 860 | |
| 861 | def GetDiff(self, path, local_root): |
| 862 | """Get the diff for a particular path.""" |
| 863 | raise NotImplementedError() |
| 864 | |
Daniel Cheng | 7a1f04d | 2017-03-21 19:12:31 -0700 | [diff] [blame] | 865 | def GetOldContents(self, path, local_root): |
| 866 | """Get the old version for a particular path.""" |
| 867 | raise NotImplementedError() |
| 868 | |
nick@chromium.org | ff52619 | 2013-06-10 19:30:26 +0000 | [diff] [blame] | 869 | |
nick@chromium.org | ff52619 | 2013-06-10 19:30:26 +0000 | [diff] [blame] | 870 | class _GitDiffCache(_DiffCache): |
| 871 | """DiffCache implementation for git; gets all file diffs at once.""" |
agable@chromium.org | ea84ef1 | 2014-04-30 19:55:12 +0000 | [diff] [blame] | 872 | def __init__(self, upstream): |
| 873 | super(_GitDiffCache, self).__init__(upstream=upstream) |
nick@chromium.org | ff52619 | 2013-06-10 19:30:26 +0000 | [diff] [blame] | 874 | self._diffs_by_file = None |
| 875 | |
| 876 | def GetDiff(self, path, local_root): |
| 877 | if not self._diffs_by_file: |
| 878 | # Compute a single diff for all files and parse the output; should |
| 879 | # with git this is much faster than computing one diff for each file. |
| 880 | diffs = {} |
| 881 | |
| 882 | # Don't specify any filenames below, because there are command line length |
| 883 | # limits on some platforms and GenerateDiff would fail. |
agable@chromium.org | ea84ef1 | 2014-04-30 19:55:12 +0000 | [diff] [blame] | 884 | unified_diff = scm.GIT.GenerateDiff(local_root, files=[], full_move=True, |
| 885 | branch=self._upstream) |
nick@chromium.org | ff52619 | 2013-06-10 19:30:26 +0000 | [diff] [blame] | 886 | |
| 887 | # This regex matches the path twice, separated by a space. Note that |
| 888 | # filename itself may contain spaces. |
| 889 | file_marker = re.compile('^diff --git (?P<filename>.*) (?P=filename)$') |
| 890 | current_diff = [] |
| 891 | keep_line_endings = True |
| 892 | for x in unified_diff.splitlines(keep_line_endings): |
| 893 | match = file_marker.match(x) |
| 894 | if match: |
| 895 | # Marks the start of a new per-file section. |
| 896 | diffs[match.group('filename')] = current_diff = [x] |
| 897 | elif x.startswith('diff --git'): |
| 898 | raise PresubmitFailure('Unexpected diff line: %s' % x) |
| 899 | else: |
| 900 | current_diff.append(x) |
| 901 | |
| 902 | self._diffs_by_file = dict( |
| 903 | (normpath(path), ''.join(diff)) for path, diff in diffs.items()) |
| 904 | |
| 905 | if path not in self._diffs_by_file: |
| 906 | raise PresubmitFailure( |
| 907 | 'Unified diff did not contain entry for file %s' % path) |
| 908 | |
| 909 | return self._diffs_by_file[path] |
| 910 | |
Daniel Cheng | 7a1f04d | 2017-03-21 19:12:31 -0700 | [diff] [blame] | 911 | def GetOldContents(self, path, local_root): |
| 912 | return scm.GIT.GetOldContents(local_root, path, branch=self._upstream) |
| 913 | |
nick@chromium.org | ff52619 | 2013-06-10 19:30:26 +0000 | [diff] [blame] | 914 | |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 915 | class AffectedFile(object): |
| 916 | """Representation of a file in a change.""" |
nick@chromium.org | ff52619 | 2013-06-10 19:30:26 +0000 | [diff] [blame] | 917 | |
| 918 | DIFF_CACHE = _DiffCache |
| 919 | |
maruel@chromium.org | b17b55b | 2010-11-03 14:42:37 +0000 | [diff] [blame] | 920 | # Method could be a function |
Quinten Yearsley | b2cc4a9 | 2016-12-15 13:53:26 -0800 | [diff] [blame] | 921 | # pylint: disable=no-self-use |
agable@chromium.org | ea84ef1 | 2014-04-30 19:55:12 +0000 | [diff] [blame] | 922 | def __init__(self, path, action, repository_root, diff_cache): |
maruel@chromium.org | 15bdffa | 2009-05-29 11:16:29 +0000 | [diff] [blame] | 923 | self._path = path |
| 924 | self._action = action |
maruel@chromium.org | 4ff922a | 2009-06-12 20:20:19 +0000 | [diff] [blame] | 925 | self._local_root = repository_root |
maruel@chromium.org | 15bdffa | 2009-05-29 11:16:29 +0000 | [diff] [blame] | 926 | self._is_directory = None |
nick@chromium.org | 2a3ab7e | 2011-04-27 22:06:27 +0000 | [diff] [blame] | 927 | self._cached_changed_contents = None |
| 928 | self._cached_new_contents = None |
agable@chromium.org | ea84ef1 | 2014-04-30 19:55:12 +0000 | [diff] [blame] | 929 | self._diff_cache = diff_cache |
tobiasjs | 2836bcf | 2016-08-16 04:08:16 -0700 | [diff] [blame] | 930 | logging.debug('%s(%s)', self.__class__.__name__, self._path) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 931 | |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 932 | def LocalPath(self): |
| 933 | """Returns the path of this file on the local disk relative to client root. |
Andrew Grieve | 92b8b99 | 2017-11-02 09:42:24 -0400 | [diff] [blame] | 934 | |
| 935 | This should be used for error messages but not for accessing files, |
| 936 | because presubmit checks are run with CWD=PresubmitLocalPath() (which is |
| 937 | often != client root). |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 938 | """ |
maruel@chromium.org | 15bdffa | 2009-05-29 11:16:29 +0000 | [diff] [blame] | 939 | return normpath(self._path) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 940 | |
| 941 | def AbsoluteLocalPath(self): |
| 942 | """Returns the absolute path of this file on the local disk. |
| 943 | """ |
chase@chromium.org | 8e416c8 | 2009-10-06 04:30:44 +0000 | [diff] [blame] | 944 | return os.path.abspath(os.path.join(self._local_root, self.LocalPath())) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 945 | |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 946 | def Action(self): |
| 947 | """Returns the action on this opened file, e.g. A, M, D, etc.""" |
maruel@chromium.org | 15bdffa | 2009-05-29 11:16:29 +0000 | [diff] [blame] | 948 | return self._action |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 949 | |
agable | 0b65e73 | 2016-11-22 09:25:46 -0800 | [diff] [blame] | 950 | def IsTestableFile(self): |
maruel@chromium.org | 77c4f0f | 2009-05-29 18:53:04 +0000 | [diff] [blame] | 951 | """Returns True if the file is a text file and not a binary file. |
thestig@chromium.org | da8cddd | 2009-08-13 00:25:55 +0000 | [diff] [blame] | 952 | |
maruel@chromium.org | 77c4f0f | 2009-05-29 18:53:04 +0000 | [diff] [blame] | 953 | Deleted files are not text file.""" |
maruel@chromium.org | 1e08c00 | 2009-05-28 19:09:33 +0000 | [diff] [blame] | 954 | raise NotImplementedError() # Implement when needed |
| 955 | |
agable | 0b65e73 | 2016-11-22 09:25:46 -0800 | [diff] [blame] | 956 | def IsTextFile(self): |
| 957 | """An alias to IsTestableFile for backwards compatibility.""" |
| 958 | return self.IsTestableFile() |
| 959 | |
Daniel Cheng | 7a1f04d | 2017-03-21 19:12:31 -0700 | [diff] [blame] | 960 | def OldContents(self): |
| 961 | """Returns an iterator over the lines in the old version of file. |
| 962 | |
Daniel Cheng | 2da34fe | 2017-03-21 20:42:12 -0700 | [diff] [blame] | 963 | The old version is the file before any modifications in the user's |
Edward Lemur | a5799e3 | 2020-01-17 19:26:51 +0000 | [diff] [blame] | 964 | workspace, i.e. the 'left hand side'. |
Daniel Cheng | 7a1f04d | 2017-03-21 19:12:31 -0700 | [diff] [blame] | 965 | |
| 966 | Contents will be empty if the file is a directory or does not exist. |
| 967 | Note: The carriage returns (LF or CR) are stripped off. |
| 968 | """ |
| 969 | return self._diff_cache.GetOldContents(self.LocalPath(), |
| 970 | self._local_root).splitlines() |
| 971 | |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 972 | def NewContents(self): |
| 973 | """Returns an iterator over the lines in the new version of file. |
| 974 | |
Edward Lemur | a5799e3 | 2020-01-17 19:26:51 +0000 | [diff] [blame] | 975 | The new version is the file in the user's workspace, i.e. the 'right hand |
| 976 | side'. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 977 | |
| 978 | Contents will be empty if the file is a directory or does not exist. |
nick@chromium.org | 2a3ab7e | 2011-04-27 22:06:27 +0000 | [diff] [blame] | 979 | Note: The carriage returns (LF or CR) are stripped off. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 980 | """ |
nick@chromium.org | 2a3ab7e | 2011-04-27 22:06:27 +0000 | [diff] [blame] | 981 | if self._cached_new_contents is None: |
| 982 | self._cached_new_contents = [] |
agable | 0b65e73 | 2016-11-22 09:25:46 -0800 | [diff] [blame] | 983 | try: |
| 984 | self._cached_new_contents = gclient_utils.FileRead( |
| 985 | self.AbsoluteLocalPath(), 'rU').splitlines() |
| 986 | except IOError: |
| 987 | pass # File not found? That's fine; maybe it was deleted. |
nick@chromium.org | 2a3ab7e | 2011-04-27 22:06:27 +0000 | [diff] [blame] | 988 | return self._cached_new_contents[:] |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 989 | |
maruel@chromium.org | ab05d58 | 2011-02-09 23:41:22 +0000 | [diff] [blame] | 990 | def ChangedContents(self): |
| 991 | """Returns a list of tuples (line number, line text) of all new lines. |
| 992 | |
| 993 | This relies on the scm diff output describing each changed code section |
| 994 | with a line of the form |
| 995 | |
| 996 | ^@@ <old line num>,<old size> <new line num>,<new size> @@$ |
| 997 | """ |
nick@chromium.org | 2a3ab7e | 2011-04-27 22:06:27 +0000 | [diff] [blame] | 998 | if self._cached_changed_contents is not None: |
| 999 | return self._cached_changed_contents[:] |
| 1000 | self._cached_changed_contents = [] |
maruel@chromium.org | ab05d58 | 2011-02-09 23:41:22 +0000 | [diff] [blame] | 1001 | line_num = 0 |
| 1002 | |
maruel@chromium.org | ab05d58 | 2011-02-09 23:41:22 +0000 | [diff] [blame] | 1003 | for line in self.GenerateScmDiff().splitlines(): |
Edward Lemur | ac5c55f | 2020-02-29 00:17:16 +0000 | [diff] [blame] | 1004 | m = re.match(r'^@@ [0-9\,\+\-]+ \+([0-9]+)\,[0-9]+ @@', line) |
| 1005 | if m: |
| 1006 | line_num = int(m.groups(1)[0]) |
maruel@chromium.org | ab05d58 | 2011-02-09 23:41:22 +0000 | [diff] [blame] | 1007 | continue |
| 1008 | if line.startswith('+') and not line.startswith('++'): |
nick@chromium.org | 2a3ab7e | 2011-04-27 22:06:27 +0000 | [diff] [blame] | 1009 | self._cached_changed_contents.append((line_num, line[1:])) |
maruel@chromium.org | ab05d58 | 2011-02-09 23:41:22 +0000 | [diff] [blame] | 1010 | if not line.startswith('-'): |
| 1011 | line_num += 1 |
nick@chromium.org | 2a3ab7e | 2011-04-27 22:06:27 +0000 | [diff] [blame] | 1012 | return self._cached_changed_contents[:] |
maruel@chromium.org | ab05d58 | 2011-02-09 23:41:22 +0000 | [diff] [blame] | 1013 | |
maruel@chromium.org | 5de1397 | 2009-06-10 18:16:06 +0000 | [diff] [blame] | 1014 | def __str__(self): |
| 1015 | return self.LocalPath() |
| 1016 | |
maruel@chromium.org | ab05d58 | 2011-02-09 23:41:22 +0000 | [diff] [blame] | 1017 | def GenerateScmDiff(self): |
nick@chromium.org | ff52619 | 2013-06-10 19:30:26 +0000 | [diff] [blame] | 1018 | return self._diff_cache.GetDiff(self.LocalPath(), self._local_root) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1019 | |
maruel@chromium.org | 58407af | 2011-04-12 23:15:57 +0000 | [diff] [blame] | 1020 | |
maruel@chromium.org | c70a220 | 2009-06-17 12:55:10 +0000 | [diff] [blame] | 1021 | class GitAffectedFile(AffectedFile): |
| 1022 | """Representation of a file in a change out of a git checkout.""" |
maruel@chromium.org | b17b55b | 2010-11-03 14:42:37 +0000 | [diff] [blame] | 1023 | # Method 'NNN' is abstract in class 'NNN' but is not overridden |
Quinten Yearsley | b2cc4a9 | 2016-12-15 13:53:26 -0800 | [diff] [blame] | 1024 | # pylint: disable=abstract-method |
maruel@chromium.org | c70a220 | 2009-06-17 12:55:10 +0000 | [diff] [blame] | 1025 | |
nick@chromium.org | ff52619 | 2013-06-10 19:30:26 +0000 | [diff] [blame] | 1026 | DIFF_CACHE = _GitDiffCache |
| 1027 | |
maruel@chromium.org | c70a220 | 2009-06-17 12:55:10 +0000 | [diff] [blame] | 1028 | def __init__(self, *args, **kwargs): |
| 1029 | AffectedFile.__init__(self, *args, **kwargs) |
| 1030 | self._server_path = None |
agable | 0b65e73 | 2016-11-22 09:25:46 -0800 | [diff] [blame] | 1031 | self._is_testable_file = None |
maruel@chromium.org | c70a220 | 2009-06-17 12:55:10 +0000 | [diff] [blame] | 1032 | |
agable | 0b65e73 | 2016-11-22 09:25:46 -0800 | [diff] [blame] | 1033 | def IsTestableFile(self): |
| 1034 | if self._is_testable_file is None: |
maruel@chromium.org | c70a220 | 2009-06-17 12:55:10 +0000 | [diff] [blame] | 1035 | if self.Action() == 'D': |
agable | 0b65e73 | 2016-11-22 09:25:46 -0800 | [diff] [blame] | 1036 | # A deleted file is not testable. |
| 1037 | self._is_testable_file = False |
maruel@chromium.org | c70a220 | 2009-06-17 12:55:10 +0000 | [diff] [blame] | 1038 | else: |
agable | 0b65e73 | 2016-11-22 09:25:46 -0800 | [diff] [blame] | 1039 | self._is_testable_file = os.path.isfile(self.AbsoluteLocalPath()) |
| 1040 | return self._is_testable_file |
maruel@chromium.org | c70a220 | 2009-06-17 12:55:10 +0000 | [diff] [blame] | 1041 | |
maruel@chromium.org | c193875 | 2011-04-12 23:11:13 +0000 | [diff] [blame] | 1042 | |
maruel@chromium.org | 4ff922a | 2009-06-12 20:20:19 +0000 | [diff] [blame] | 1043 | class Change(object): |
maruel@chromium.org | 6ebe68a | 2009-05-27 23:43:40 +0000 | [diff] [blame] | 1044 | """Describe a change. |
| 1045 | |
| 1046 | Used directly by the presubmit scripts to query the current change being |
| 1047 | tested. |
thestig@chromium.org | da8cddd | 2009-08-13 00:25:55 +0000 | [diff] [blame] | 1048 | |
maruel@chromium.org | 6ebe68a | 2009-05-27 23:43:40 +0000 | [diff] [blame] | 1049 | Instance members: |
nick@chromium.org | ff52619 | 2013-06-10 19:30:26 +0000 | [diff] [blame] | 1050 | tags: Dictionary of KEY=VALUE pairs found in the change description. |
maruel@chromium.org | 6ebe68a | 2009-05-27 23:43:40 +0000 | [diff] [blame] | 1051 | self.KEY: equivalent to tags['KEY'] |
| 1052 | """ |
| 1053 | |
maruel@chromium.org | 4ff922a | 2009-06-12 20:20:19 +0000 | [diff] [blame] | 1054 | _AFFECTED_FILES = AffectedFile |
| 1055 | |
Edward Lemur | a5799e3 | 2020-01-17 19:26:51 +0000 | [diff] [blame] | 1056 | # Matches key/value (or 'tag') lines in changelist descriptions. |
maruel@chromium.org | 428342a | 2011-11-10 15:46:33 +0000 | [diff] [blame] | 1057 | TAG_LINE_RE = re.compile( |
maruel@chromium.org | c6f60e8 | 2013-04-19 17:01:57 +0000 | [diff] [blame] | 1058 | '^[ \t]*(?P<key>[A-Z][A-Z_0-9]*)[ \t]*=[ \t]*(?P<value>.*?)[ \t]*$') |
maruel@chromium.org | c193875 | 2011-04-12 23:11:13 +0000 | [diff] [blame] | 1059 | scm = '' |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1060 | |
maruel@chromium.org | 58407af | 2011-04-12 23:15:57 +0000 | [diff] [blame] | 1061 | def __init__( |
agable@chromium.org | ea84ef1 | 2014-04-30 19:55:12 +0000 | [diff] [blame] | 1062 | self, name, description, local_root, files, issue, patchset, author, |
| 1063 | upstream=None): |
maruel@chromium.org | 4ff922a | 2009-06-12 20:20:19 +0000 | [diff] [blame] | 1064 | if files is None: |
| 1065 | files = [] |
| 1066 | self._name = name |
chase@chromium.org | 8e416c8 | 2009-10-06 04:30:44 +0000 | [diff] [blame] | 1067 | # Convert root into an absolute path. |
| 1068 | self._local_root = os.path.abspath(local_root) |
agable@chromium.org | ea84ef1 | 2014-04-30 19:55:12 +0000 | [diff] [blame] | 1069 | self._upstream = upstream |
maruel@chromium.org | 4ff922a | 2009-06-12 20:20:19 +0000 | [diff] [blame] | 1070 | self.issue = issue |
| 1071 | self.patchset = patchset |
maruel@chromium.org | 58407af | 2011-04-12 23:15:57 +0000 | [diff] [blame] | 1072 | self.author_email = author |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1073 | |
isherman@chromium.org | b5cded6 | 2014-03-25 17:47:57 +0000 | [diff] [blame] | 1074 | self._full_description = '' |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1075 | self.tags = {} |
isherman@chromium.org | b5cded6 | 2014-03-25 17:47:57 +0000 | [diff] [blame] | 1076 | self._description_without_tags = '' |
| 1077 | self.SetDescriptionText(description) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1078 | |
maruel@chromium.org | e085d81 | 2011-10-10 19:49:15 +0000 | [diff] [blame] | 1079 | assert all( |
| 1080 | (isinstance(f, (list, tuple)) and len(f) == 2) for f in files), files |
| 1081 | |
agable@chromium.org | ea84ef1 | 2014-04-30 19:55:12 +0000 | [diff] [blame] | 1082 | diff_cache = self._AFFECTED_FILES.DIFF_CACHE(self._upstream) |
maruel@chromium.org | 6ebe68a | 2009-05-27 23:43:40 +0000 | [diff] [blame] | 1083 | self._affected_files = [ |
nick@chromium.org | ff52619 | 2013-06-10 19:30:26 +0000 | [diff] [blame] | 1084 | self._AFFECTED_FILES(path, action.strip(), self._local_root, diff_cache) |
| 1085 | for action, path in files |
maruel@chromium.org | dbbeedc | 2009-05-22 20:26:17 +0000 | [diff] [blame] | 1086 | ] |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1087 | |
maruel@chromium.org | 92022ec | 2009-06-11 01:59:28 +0000 | [diff] [blame] | 1088 | def Name(self): |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1089 | """Returns the change name.""" |
maruel@chromium.org | 6ebe68a | 2009-05-27 23:43:40 +0000 | [diff] [blame] | 1090 | return self._name |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1091 | |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1092 | def DescriptionText(self): |
| 1093 | """Returns the user-entered changelist description, minus tags. |
| 1094 | |
Edward Lemur | a5799e3 | 2020-01-17 19:26:51 +0000 | [diff] [blame] | 1095 | Any line in the user-provided description starting with e.g. 'FOO=' |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1096 | (whitespace permitted before and around) is considered a tag line. Such |
| 1097 | lines are stripped out of the description this function returns. |
| 1098 | """ |
maruel@chromium.org | 6ebe68a | 2009-05-27 23:43:40 +0000 | [diff] [blame] | 1099 | return self._description_without_tags |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1100 | |
| 1101 | def FullDescriptionText(self): |
| 1102 | """Returns the complete changelist description including tags.""" |
maruel@chromium.org | 6ebe68a | 2009-05-27 23:43:40 +0000 | [diff] [blame] | 1103 | return self._full_description |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1104 | |
isherman@chromium.org | b5cded6 | 2014-03-25 17:47:57 +0000 | [diff] [blame] | 1105 | def SetDescriptionText(self, description): |
| 1106 | """Sets the full description text (including tags) to |description|. |
pgervais@chromium.org | 92c3009 | 2014-04-15 00:30:37 +0000 | [diff] [blame] | 1107 | |
isherman@chromium.org | b5cded6 | 2014-03-25 17:47:57 +0000 | [diff] [blame] | 1108 | Also updates the list of tags.""" |
| 1109 | self._full_description = description |
| 1110 | |
| 1111 | # From the description text, build up a dictionary of key/value pairs |
Edward Lemur | a5799e3 | 2020-01-17 19:26:51 +0000 | [diff] [blame] | 1112 | # plus the description minus all key/value or 'tag' lines. |
isherman@chromium.org | b5cded6 | 2014-03-25 17:47:57 +0000 | [diff] [blame] | 1113 | description_without_tags = [] |
| 1114 | self.tags = {} |
| 1115 | for line in self._full_description.splitlines(): |
| 1116 | m = self.TAG_LINE_RE.match(line) |
| 1117 | if m: |
| 1118 | self.tags[m.group('key')] = m.group('value') |
| 1119 | else: |
| 1120 | description_without_tags.append(line) |
| 1121 | |
| 1122 | # Change back to text and remove whitespace at end. |
| 1123 | self._description_without_tags = ( |
| 1124 | '\n'.join(description_without_tags).rstrip()) |
| 1125 | |
Edward Lemur | 69bb8be | 2020-02-03 20:37:38 +0000 | [diff] [blame] | 1126 | def AddDescriptionFooter(self, key, value): |
| 1127 | """Adds the given footer to the change description. |
| 1128 | |
| 1129 | Args: |
| 1130 | key: A string with the key for the git footer. It must conform to |
| 1131 | the git footers format (i.e. 'List-Of-Tokens') and will be case |
| 1132 | normalized so that each token is title-cased. |
| 1133 | value: A string with the value for the git footer. |
| 1134 | """ |
| 1135 | description = git_footers.add_footer( |
| 1136 | self.FullDescriptionText(), git_footers.normalize_name(key), value) |
| 1137 | self.SetDescriptionText(description) |
| 1138 | |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1139 | def RepositoryRoot(self): |
maruel@chromium.org | 92022ec | 2009-06-11 01:59:28 +0000 | [diff] [blame] | 1140 | """Returns the repository (checkout) root directory for this change, |
| 1141 | as an absolute path. |
| 1142 | """ |
maruel@chromium.org | 4ff922a | 2009-06-12 20:20:19 +0000 | [diff] [blame] | 1143 | return self._local_root |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1144 | |
| 1145 | def __getattr__(self, attr): |
maruel@chromium.org | 92022ec | 2009-06-11 01:59:28 +0000 | [diff] [blame] | 1146 | """Return tags directly as attributes on the object.""" |
Edward Lemur | a5799e3 | 2020-01-17 19:26:51 +0000 | [diff] [blame] | 1147 | if not re.match(r'^[A-Z_]*$', attr): |
maruel@chromium.org | 92022ec | 2009-06-11 01:59:28 +0000 | [diff] [blame] | 1148 | raise AttributeError(self, attr) |
maruel@chromium.org | e1a524f | 2009-05-27 14:43:46 +0000 | [diff] [blame] | 1149 | return self.tags.get(attr) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1150 | |
Edward Lemur | 69bb8be | 2020-02-03 20:37:38 +0000 | [diff] [blame] | 1151 | def GitFootersFromDescription(self): |
| 1152 | """Return the git footers present in the description. |
| 1153 | |
| 1154 | Returns: |
| 1155 | footers: A dict of {footer: [values]} containing a multimap of the footers |
| 1156 | in the change description. |
| 1157 | """ |
| 1158 | return git_footers.parse_footers(self.FullDescriptionText()) |
| 1159 | |
Aaron Gable | fc03e67 | 2017-05-15 14:09:42 -0700 | [diff] [blame] | 1160 | def BugsFromDescription(self): |
| 1161 | """Returns all bugs referenced in the commit description.""" |
Aaron Gable | 12ef501 | 2017-05-15 14:29:00 -0700 | [diff] [blame] | 1162 | tags = [b.strip() for b in self.tags.get('BUG', '').split(',') if b.strip()] |
Caleb Rouleau | c0546b9 | 2019-02-22 06:12:57 +0000 | [diff] [blame] | 1163 | footers = [] |
Edward Lemur | 69bb8be | 2020-02-03 20:37:38 +0000 | [diff] [blame] | 1164 | parsed = self.GitFootersFromDescription() |
Dan Beam | 6295404 | 2019-10-03 21:20:33 +0000 | [diff] [blame] | 1165 | unsplit_footers = parsed.get('Bug', []) + parsed.get('Fixed', []) |
Caleb Rouleau | c0546b9 | 2019-02-22 06:12:57 +0000 | [diff] [blame] | 1166 | for unsplit_footer in unsplit_footers: |
| 1167 | footers += [b.strip() for b in unsplit_footer.split(',')] |
Aaron Gable | 12ef501 | 2017-05-15 14:29:00 -0700 | [diff] [blame] | 1168 | return sorted(set(tags + footers)) |
Aaron Gable | fc03e67 | 2017-05-15 14:09:42 -0700 | [diff] [blame] | 1169 | |
| 1170 | def ReviewersFromDescription(self): |
| 1171 | """Returns all reviewers listed in the commit description.""" |
Edward Lemur | a5799e3 | 2020-01-17 19:26:51 +0000 | [diff] [blame] | 1172 | # We don't support a 'R:' git-footer for reviewers; that is in metadata. |
Aaron Gable | 12ef501 | 2017-05-15 14:29:00 -0700 | [diff] [blame] | 1173 | tags = [r.strip() for r in self.tags.get('R', '').split(',') if r.strip()] |
| 1174 | return sorted(set(tags)) |
Aaron Gable | fc03e67 | 2017-05-15 14:09:42 -0700 | [diff] [blame] | 1175 | |
| 1176 | def TBRsFromDescription(self): |
| 1177 | """Returns all TBR reviewers listed in the commit description.""" |
Aaron Gable | 12ef501 | 2017-05-15 14:29:00 -0700 | [diff] [blame] | 1178 | tags = [r.strip() for r in self.tags.get('TBR', '').split(',') if r.strip()] |
Aaron Gable | 6e7ddb6 | 2020-05-27 22:23:29 +0000 | [diff] [blame] | 1179 | # TODO(crbug.com/839208): Remove support for 'Tbr:' when TBRs are |
| 1180 | # programmatically determined by self-CR+1s. |
Edward Lemur | 69bb8be | 2020-02-03 20:37:38 +0000 | [diff] [blame] | 1181 | footers = self.GitFootersFromDescription().get('Tbr', []) |
Aaron Gable | 12ef501 | 2017-05-15 14:29:00 -0700 | [diff] [blame] | 1182 | return sorted(set(tags + footers)) |
Aaron Gable | fc03e67 | 2017-05-15 14:09:42 -0700 | [diff] [blame] | 1183 | |
Aaron Gable | 6e7ddb6 | 2020-05-27 22:23:29 +0000 | [diff] [blame] | 1184 | # TODO(crbug.com/753425): Delete these once we're sure they're unused. |
Aaron Gable | fc03e67 | 2017-05-15 14:09:42 -0700 | [diff] [blame] | 1185 | @property |
| 1186 | def BUG(self): |
| 1187 | return ','.join(self.BugsFromDescription()) |
| 1188 | @property |
| 1189 | def R(self): |
| 1190 | return ','.join(self.ReviewersFromDescription()) |
| 1191 | @property |
| 1192 | def TBR(self): |
| 1193 | return ','.join(self.TBRsFromDescription()) |
| 1194 | |
agable@chromium.org | 40a3d0b | 2014-05-15 01:59:16 +0000 | [diff] [blame] | 1195 | def AllFiles(self, root=None): |
| 1196 | """List all files under source control in the repo.""" |
| 1197 | raise NotImplementedError() |
| 1198 | |
agable | 0b65e73 | 2016-11-22 09:25:46 -0800 | [diff] [blame] | 1199 | def AffectedFiles(self, include_deletes=True, file_filter=None): |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1200 | """Returns a list of AffectedFile instances for all files in the change. |
| 1201 | |
| 1202 | Args: |
| 1203 | include_deletes: If false, deleted files will be filtered out. |
sail@chromium.org | 5538e02 | 2011-05-12 17:53:16 +0000 | [diff] [blame] | 1204 | file_filter: An additional filter to apply. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1205 | |
| 1206 | Returns: |
| 1207 | [AffectedFile(path, action), AffectedFile(path, action)] |
| 1208 | """ |
Edward Lemur | b983024 | 2019-10-30 22:19:20 +0000 | [diff] [blame] | 1209 | affected = list(filter(file_filter, self._affected_files)) |
sail@chromium.org | 5538e02 | 2011-05-12 17:53:16 +0000 | [diff] [blame] | 1210 | |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1211 | if include_deletes: |
| 1212 | return affected |
Edward Lemur | b983024 | 2019-10-30 22:19:20 +0000 | [diff] [blame] | 1213 | return list(filter(lambda x: x.Action() != 'D', affected)) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1214 | |
John Budorick | 1616237 | 2018-04-18 10:39:53 -0700 | [diff] [blame] | 1215 | def AffectedTestableFiles(self, include_deletes=None, **kwargs): |
maruel@chromium.org | 77c4f0f | 2009-05-29 18:53:04 +0000 | [diff] [blame] | 1216 | """Return a list of the existing text files in a change.""" |
| 1217 | if include_deletes is not None: |
Edward Lemur | a5799e3 | 2020-01-17 19:26:51 +0000 | [diff] [blame] | 1218 | warn('AffectedTeestableFiles(include_deletes=%s)' |
| 1219 | ' is deprecated and ignored' % str(include_deletes), |
maruel@chromium.org | cb2985f | 2010-11-03 14:08:31 +0000 | [diff] [blame] | 1220 | category=DeprecationWarning, |
| 1221 | stacklevel=2) |
Edward Lemur | b983024 | 2019-10-30 22:19:20 +0000 | [diff] [blame] | 1222 | return list(filter( |
| 1223 | lambda x: x.IsTestableFile(), |
| 1224 | self.AffectedFiles(include_deletes=False, **kwargs))) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1225 | |
agable | 0b65e73 | 2016-11-22 09:25:46 -0800 | [diff] [blame] | 1226 | def AffectedTextFiles(self, include_deletes=None): |
| 1227 | """An alias to AffectedTestableFiles for backwards compatibility.""" |
| 1228 | return self.AffectedTestableFiles(include_deletes=include_deletes) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1229 | |
agable | 0b65e73 | 2016-11-22 09:25:46 -0800 | [diff] [blame] | 1230 | def LocalPaths(self): |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1231 | """Convenience function.""" |
agable | 0b65e73 | 2016-11-22 09:25:46 -0800 | [diff] [blame] | 1232 | return [af.LocalPath() for af in self.AffectedFiles()] |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1233 | |
agable | 0b65e73 | 2016-11-22 09:25:46 -0800 | [diff] [blame] | 1234 | def AbsoluteLocalPaths(self): |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1235 | """Convenience function.""" |
agable | 0b65e73 | 2016-11-22 09:25:46 -0800 | [diff] [blame] | 1236 | return [af.AbsoluteLocalPath() for af in self.AffectedFiles()] |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1237 | |
| 1238 | def RightHandSideLines(self): |
Edward Lemur | a5799e3 | 2020-01-17 19:26:51 +0000 | [diff] [blame] | 1239 | """An iterator over all text lines in 'new' version of changed files. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1240 | |
| 1241 | Lists lines from new or modified text files in the change. |
| 1242 | |
| 1243 | This is useful for doing line-by-line regex checks, like checking for |
| 1244 | trailing whitespace. |
| 1245 | |
| 1246 | Yields: |
| 1247 | a 3 tuple: |
| 1248 | the AffectedFile instance of the current file; |
| 1249 | integer line number (1-based); and |
| 1250 | the contents of the line as a string. |
| 1251 | """ |
maruel@chromium.org | cb2985f | 2010-11-03 14:08:31 +0000 | [diff] [blame] | 1252 | return _RightHandSideLinesImpl( |
| 1253 | x for x in self.AffectedFiles(include_deletes=False) |
agable | 0b65e73 | 2016-11-22 09:25:46 -0800 | [diff] [blame] | 1254 | if x.IsTestableFile()) |
agable@chromium.org | 40a3d0b | 2014-05-15 01:59:16 +0000 | [diff] [blame] | 1255 | |
Jochen Eisinger | d0573ec | 2017-04-13 10:55:06 +0200 | [diff] [blame] | 1256 | def OriginalOwnersFiles(self): |
| 1257 | """A map from path names of affected OWNERS files to their old content.""" |
| 1258 | def owners_file_filter(f): |
| 1259 | return 'OWNERS' in os.path.split(f.LocalPath())[1] |
| 1260 | files = self.AffectedFiles(file_filter=owners_file_filter) |
| 1261 | return dict([(f.LocalPath(), f.OldContents()) for f in files]) |
| 1262 | |
maruel@chromium.org | 4ff922a | 2009-06-12 20:20:19 +0000 | [diff] [blame] | 1263 | |
maruel@chromium.org | c70a220 | 2009-06-17 12:55:10 +0000 | [diff] [blame] | 1264 | class GitChange(Change): |
| 1265 | _AFFECTED_FILES = GitAffectedFile |
maruel@chromium.org | c193875 | 2011-04-12 23:11:13 +0000 | [diff] [blame] | 1266 | scm = 'git' |
thestig@chromium.org | da8cddd | 2009-08-13 00:25:55 +0000 | [diff] [blame] | 1267 | |
agable@chromium.org | 40a3d0b | 2014-05-15 01:59:16 +0000 | [diff] [blame] | 1268 | def AllFiles(self, root=None): |
| 1269 | """List all files under source control in the repo.""" |
| 1270 | root = root or self.RepositoryRoot() |
| 1271 | return subprocess.check_output( |
Aaron Gable | 7817f02 | 2017-12-12 09:43:17 -0800 | [diff] [blame] | 1272 | ['git', '-c', 'core.quotePath=false', 'ls-files', '--', '.'], |
| 1273 | cwd=root).splitlines() |
agable@chromium.org | 40a3d0b | 2014-05-15 01:59:16 +0000 | [diff] [blame] | 1274 | |
maruel@chromium.org | c70a220 | 2009-06-17 12:55:10 +0000 | [diff] [blame] | 1275 | |
maruel@chromium.org | 4661e0c | 2009-06-04 00:45:26 +0000 | [diff] [blame] | 1276 | def ListRelevantPresubmitFiles(files, root): |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1277 | """Finds all presubmit files that apply to a given set of source files. |
| 1278 | |
maruel@chromium.org | b1901a6 | 2010-06-16 00:18:47 +0000 | [diff] [blame] | 1279 | If inherit-review-settings-ok is present right under root, looks for |
| 1280 | PRESUBMIT.py in directories enclosing root. |
| 1281 | |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1282 | Args: |
| 1283 | files: An iterable container containing file paths. |
maruel@chromium.org | 4661e0c | 2009-06-04 00:45:26 +0000 | [diff] [blame] | 1284 | root: Path where to stop searching. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1285 | |
| 1286 | Return: |
maruel@chromium.org | 4661e0c | 2009-06-04 00:45:26 +0000 | [diff] [blame] | 1287 | List of absolute paths of the existing PRESUBMIT.py scripts. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1288 | """ |
maruel@chromium.org | b1901a6 | 2010-06-16 00:18:47 +0000 | [diff] [blame] | 1289 | files = [normpath(os.path.join(root, f)) for f in files] |
| 1290 | |
| 1291 | # List all the individual directories containing files. |
| 1292 | directories = set([os.path.dirname(f) for f in files]) |
| 1293 | |
| 1294 | # Ignore root if inherit-review-settings-ok is present. |
| 1295 | if os.path.isfile(os.path.join(root, 'inherit-review-settings-ok')): |
| 1296 | root = None |
| 1297 | |
| 1298 | # Collect all unique directories that may contain PRESUBMIT.py. |
| 1299 | candidates = set() |
| 1300 | for directory in directories: |
| 1301 | while True: |
| 1302 | if directory in candidates: |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1303 | break |
maruel@chromium.org | b1901a6 | 2010-06-16 00:18:47 +0000 | [diff] [blame] | 1304 | candidates.add(directory) |
| 1305 | if directory == root: |
maruel@chromium.org | 4661e0c | 2009-06-04 00:45:26 +0000 | [diff] [blame] | 1306 | break |
maruel@chromium.org | b1901a6 | 2010-06-16 00:18:47 +0000 | [diff] [blame] | 1307 | parent_dir = os.path.dirname(directory) |
| 1308 | if parent_dir == directory: |
| 1309 | # We hit the system root directory. |
| 1310 | break |
| 1311 | directory = parent_dir |
| 1312 | |
| 1313 | # Look for PRESUBMIT.py in all candidate directories. |
| 1314 | results = [] |
| 1315 | for directory in sorted(list(candidates)): |
tobiasjs | ff061c0 | 2016-08-17 03:23:57 -0700 | [diff] [blame] | 1316 | try: |
| 1317 | for f in os.listdir(directory): |
| 1318 | p = os.path.join(directory, f) |
| 1319 | if os.path.isfile(p) and re.match( |
| 1320 | r'PRESUBMIT.*\.py$', f) and not f.startswith('PRESUBMIT_test'): |
| 1321 | results.append(p) |
| 1322 | except OSError: |
| 1323 | pass |
maruel@chromium.org | b1901a6 | 2010-06-16 00:18:47 +0000 | [diff] [blame] | 1324 | |
tobiasjs | 2836bcf | 2016-08-16 04:08:16 -0700 | [diff] [blame] | 1325 | logging.debug('Presubmit files: %s', ','.join(results)) |
maruel@chromium.org | b1901a6 | 2010-06-16 00:18:47 +0000 | [diff] [blame] | 1326 | return results |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1327 | |
| 1328 | |
machenbach@chromium.org | 58a69cb | 2014-03-01 02:08:29 +0000 | [diff] [blame] | 1329 | class GetTryMastersExecuter(object): |
| 1330 | @staticmethod |
| 1331 | def ExecPresubmitScript(script_text, presubmit_path, project, change): |
| 1332 | """Executes GetPreferredTryMasters() from a single presubmit script. |
| 1333 | |
| 1334 | Args: |
| 1335 | script_text: The text of the presubmit script. |
| 1336 | presubmit_path: Project script to run. |
| 1337 | project: Project name to pass to presubmit script for bot selection. |
| 1338 | |
| 1339 | Return: |
| 1340 | A map of try masters to map of builders to set of tests. |
| 1341 | """ |
| 1342 | context = {} |
| 1343 | try: |
Raul Tambre | 09e64b4 | 2019-05-14 01:57:22 +0000 | [diff] [blame] | 1344 | exec(compile(script_text, 'PRESUBMIT.py', 'exec', dont_inherit=True), |
| 1345 | context) |
Raul Tambre | 7c93846 | 2019-05-24 16:35:35 +0000 | [diff] [blame] | 1346 | except Exception as e: |
machenbach@chromium.org | 58a69cb | 2014-03-01 02:08:29 +0000 | [diff] [blame] | 1347 | raise PresubmitFailure('"%s" had an exception.\n%s' |
| 1348 | % (presubmit_path, e)) |
| 1349 | |
| 1350 | function_name = 'GetPreferredTryMasters' |
| 1351 | if function_name not in context: |
| 1352 | return {} |
| 1353 | get_preferred_try_masters = context[function_name] |
| 1354 | if not len(inspect.getargspec(get_preferred_try_masters)[0]) == 2: |
| 1355 | raise PresubmitFailure( |
| 1356 | 'Expected function "GetPreferredTryMasters" to take two arguments.') |
| 1357 | return get_preferred_try_masters(project, change) |
| 1358 | |
| 1359 | |
rmistry@google.com | 5626a92 | 2015-02-26 14:03:30 +0000 | [diff] [blame] | 1360 | class GetPostUploadExecuter(object): |
| 1361 | @staticmethod |
Edward Lemur | 016a087 | 2020-02-04 22:13:28 +0000 | [diff] [blame] | 1362 | def ExecPresubmitScript(script_text, presubmit_path, gerrit_obj, change): |
rmistry@google.com | 5626a92 | 2015-02-26 14:03:30 +0000 | [diff] [blame] | 1363 | """Executes PostUploadHook() from a single presubmit script. |
| 1364 | |
| 1365 | Args: |
| 1366 | script_text: The text of the presubmit script. |
| 1367 | presubmit_path: Project script to run. |
Edward Lemur | 016a087 | 2020-02-04 22:13:28 +0000 | [diff] [blame] | 1368 | gerrit_obj: The GerritAccessor object. |
rmistry@google.com | 5626a92 | 2015-02-26 14:03:30 +0000 | [diff] [blame] | 1369 | change: The Change object. |
| 1370 | |
| 1371 | Return: |
| 1372 | A list of results objects. |
| 1373 | """ |
| 1374 | context = {} |
| 1375 | try: |
Raul Tambre | 09e64b4 | 2019-05-14 01:57:22 +0000 | [diff] [blame] | 1376 | exec(compile(script_text, 'PRESUBMIT.py', 'exec', dont_inherit=True), |
| 1377 | context) |
Raul Tambre | 7c93846 | 2019-05-24 16:35:35 +0000 | [diff] [blame] | 1378 | except Exception as e: |
rmistry@google.com | 5626a92 | 2015-02-26 14:03:30 +0000 | [diff] [blame] | 1379 | raise PresubmitFailure('"%s" had an exception.\n%s' |
| 1380 | % (presubmit_path, e)) |
| 1381 | |
| 1382 | function_name = 'PostUploadHook' |
| 1383 | if function_name not in context: |
| 1384 | return {} |
| 1385 | post_upload_hook = context[function_name] |
| 1386 | if not len(inspect.getargspec(post_upload_hook)[0]) == 3: |
| 1387 | raise PresubmitFailure( |
| 1388 | 'Expected function "PostUploadHook" to take three arguments.') |
Edward Lemur | 016a087 | 2020-02-04 22:13:28 +0000 | [diff] [blame] | 1389 | return post_upload_hook(gerrit_obj, change, OutputApi(False)) |
rmistry@google.com | 5626a92 | 2015-02-26 14:03:30 +0000 | [diff] [blame] | 1390 | |
| 1391 | |
machenbach@chromium.org | 58a69cb | 2014-03-01 02:08:29 +0000 | [diff] [blame] | 1392 | def _MergeMasters(masters1, masters2): |
| 1393 | """Merges two master maps. Merges also the tests of each builder.""" |
| 1394 | result = {} |
Marc-Antoine Ruel | 8e57b4b | 2019-10-11 01:01:36 +0000 | [diff] [blame] | 1395 | for (master, builders) in itertools.chain(masters1.items(), |
| 1396 | masters2.items()): |
machenbach@chromium.org | 58a69cb | 2014-03-01 02:08:29 +0000 | [diff] [blame] | 1397 | new_builders = result.setdefault(master, {}) |
Marc-Antoine Ruel | 8e57b4b | 2019-10-11 01:01:36 +0000 | [diff] [blame] | 1398 | for (builder, tests) in builders.items(): |
machenbach@chromium.org | 58a69cb | 2014-03-01 02:08:29 +0000 | [diff] [blame] | 1399 | new_builders.setdefault(builder, set([])).update(tests) |
| 1400 | return result |
| 1401 | |
| 1402 | |
| 1403 | def DoGetTryMasters(change, |
| 1404 | changed_files, |
| 1405 | repository_root, |
| 1406 | default_presubmit, |
| 1407 | project, |
| 1408 | verbose, |
| 1409 | output_stream): |
| 1410 | """Get the list of try masters from the presubmit scripts. |
| 1411 | |
| 1412 | Args: |
| 1413 | changed_files: List of modified files. |
| 1414 | repository_root: The repository root. |
| 1415 | default_presubmit: A default presubmit script to execute in any case. |
| 1416 | project: Optional name of a project used in selecting trybots. |
| 1417 | verbose: Prints debug info. |
| 1418 | output_stream: A stream to write debug output to. |
| 1419 | |
| 1420 | Return: |
| 1421 | Map of try masters to map of builders to set of tests. |
| 1422 | """ |
| 1423 | presubmit_files = ListRelevantPresubmitFiles(changed_files, repository_root) |
| 1424 | if not presubmit_files and verbose: |
Edward Lemur | a5799e3 | 2020-01-17 19:26:51 +0000 | [diff] [blame] | 1425 | output_stream.write('Warning, no PRESUBMIT.py found.\n') |
machenbach@chromium.org | 58a69cb | 2014-03-01 02:08:29 +0000 | [diff] [blame] | 1426 | results = {} |
| 1427 | executer = GetTryMastersExecuter() |
| 1428 | |
| 1429 | if default_presubmit: |
| 1430 | if verbose: |
Edward Lemur | a5799e3 | 2020-01-17 19:26:51 +0000 | [diff] [blame] | 1431 | output_stream.write('Running default presubmit script.\n') |
machenbach@chromium.org | 58a69cb | 2014-03-01 02:08:29 +0000 | [diff] [blame] | 1432 | fake_path = os.path.join(repository_root, 'PRESUBMIT.py') |
| 1433 | results = _MergeMasters(results, executer.ExecPresubmitScript( |
| 1434 | default_presubmit, fake_path, project, change)) |
| 1435 | for filename in presubmit_files: |
| 1436 | filename = os.path.abspath(filename) |
| 1437 | if verbose: |
Edward Lemur | a5799e3 | 2020-01-17 19:26:51 +0000 | [diff] [blame] | 1438 | output_stream.write('Running %s\n' % filename) |
machenbach@chromium.org | 58a69cb | 2014-03-01 02:08:29 +0000 | [diff] [blame] | 1439 | # Accept CRLF presubmit script. |
| 1440 | presubmit_script = gclient_utils.FileRead(filename, 'rU') |
| 1441 | results = _MergeMasters(results, executer.ExecPresubmitScript( |
| 1442 | presubmit_script, filename, project, change)) |
| 1443 | |
| 1444 | # Make sets to lists again for later JSON serialization. |
Marc-Antoine Ruel | 8e57b4b | 2019-10-11 01:01:36 +0000 | [diff] [blame] | 1445 | for builders in results.values(): |
machenbach@chromium.org | 58a69cb | 2014-03-01 02:08:29 +0000 | [diff] [blame] | 1446 | for builder in builders: |
| 1447 | builders[builder] = list(builders[builder]) |
| 1448 | |
| 1449 | if results and verbose: |
| 1450 | output_stream.write('%s\n' % str(results)) |
| 1451 | return results |
| 1452 | |
| 1453 | |
rmistry@google.com | 5626a92 | 2015-02-26 14:03:30 +0000 | [diff] [blame] | 1454 | def DoPostUploadExecuter(change, |
Edward Lemur | 016a087 | 2020-02-04 22:13:28 +0000 | [diff] [blame] | 1455 | gerrit_obj, |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 1456 | verbose): |
rmistry@google.com | 5626a92 | 2015-02-26 14:03:30 +0000 | [diff] [blame] | 1457 | """Execute the post upload hook. |
| 1458 | |
| 1459 | Args: |
| 1460 | change: The Change object. |
Edward Lemur | 016a087 | 2020-02-04 22:13:28 +0000 | [diff] [blame] | 1461 | gerrit_obj: The GerritAccessor object. |
rmistry@google.com | 5626a92 | 2015-02-26 14:03:30 +0000 | [diff] [blame] | 1462 | verbose: Prints debug info. |
rmistry@google.com | 5626a92 | 2015-02-26 14:03:30 +0000 | [diff] [blame] | 1463 | """ |
| 1464 | presubmit_files = ListRelevantPresubmitFiles( |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 1465 | change.LocalPaths(), change.RepositoryRoot()) |
rmistry@google.com | 5626a92 | 2015-02-26 14:03:30 +0000 | [diff] [blame] | 1466 | if not presubmit_files and verbose: |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 1467 | sys.stdout.write('Warning, no PRESUBMIT.py found.\n') |
rmistry@google.com | 5626a92 | 2015-02-26 14:03:30 +0000 | [diff] [blame] | 1468 | results = [] |
| 1469 | executer = GetPostUploadExecuter() |
| 1470 | # The root presubmit file should be executed after the ones in subdirectories. |
| 1471 | # i.e. the specific post upload hooks should run before the general ones. |
| 1472 | # Thus, reverse the order provided by ListRelevantPresubmitFiles. |
| 1473 | presubmit_files.reverse() |
| 1474 | |
| 1475 | for filename in presubmit_files: |
| 1476 | filename = os.path.abspath(filename) |
| 1477 | if verbose: |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 1478 | sys.stdout.write('Running %s\n' % filename) |
rmistry@google.com | 5626a92 | 2015-02-26 14:03:30 +0000 | [diff] [blame] | 1479 | # Accept CRLF presubmit script. |
| 1480 | presubmit_script = gclient_utils.FileRead(filename, 'rU') |
| 1481 | results.extend(executer.ExecPresubmitScript( |
Edward Lemur | 016a087 | 2020-02-04 22:13:28 +0000 | [diff] [blame] | 1482 | presubmit_script, filename, gerrit_obj, change)) |
rmistry@google.com | 5626a92 | 2015-02-26 14:03:30 +0000 | [diff] [blame] | 1483 | |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 1484 | if not results: |
| 1485 | return 0 |
| 1486 | |
| 1487 | sys.stdout.write('\n') |
| 1488 | sys.stdout.write('** Post Upload Hook Messages **\n') |
| 1489 | |
| 1490 | exit_code = 0 |
| 1491 | for result in results: |
| 1492 | if result.fatal: |
| 1493 | exit_code = 1 |
| 1494 | result.handle() |
| 1495 | sys.stdout.write('\n') |
| 1496 | |
| 1497 | return exit_code |
rmistry@google.com | 5626a92 | 2015-02-26 14:03:30 +0000 | [diff] [blame] | 1498 | |
| 1499 | |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1500 | class PresubmitExecuter(object): |
Aaron Gable | 668c1d8 | 2018-04-03 10:19:16 -0700 | [diff] [blame] | 1501 | def __init__(self, change, committing, verbose, |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 1502 | gerrit_obj, dry_run=None, thread_pool=None, parallel=False): |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1503 | """ |
| 1504 | Args: |
maruel@chromium.org | 4ff922a | 2009-06-12 20:20:19 +0000 | [diff] [blame] | 1505 | change: The Change object. |
agable | 92bec4f | 2016-08-24 09:27:27 -0700 | [diff] [blame] | 1506 | committing: True if 'git cl land' is running, False if 'git cl upload' is. |
tandrii@chromium.org | 37b07a7 | 2016-04-29 16:42:28 +0000 | [diff] [blame] | 1507 | gerrit_obj: provides basic Gerrit codereview functionality. |
| 1508 | dry_run: if true, some Checks will be skipped. |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 1509 | parallel: if true, all tests reported via input_api.RunTests for all |
| 1510 | PRESUBMIT files will be run in parallel. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1511 | """ |
maruel@chromium.org | 4ff922a | 2009-06-12 20:20:19 +0000 | [diff] [blame] | 1512 | self.change = change |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1513 | self.committing = committing |
tandrii@chromium.org | 37b07a7 | 2016-04-29 16:42:28 +0000 | [diff] [blame] | 1514 | self.gerrit = gerrit_obj |
maruel@chromium.org | 899e1c1 | 2011-04-07 17:03:18 +0000 | [diff] [blame] | 1515 | self.verbose = verbose |
tandrii@chromium.org | 57bafac | 2016-04-28 05:09:03 +0000 | [diff] [blame] | 1516 | self.dry_run = dry_run |
Daniel Cheng | 7227d21 | 2017-11-17 08:12:37 -0800 | [diff] [blame] | 1517 | self.more_cc = [] |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 1518 | self.thread_pool = thread_pool |
| 1519 | self.parallel = parallel |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1520 | |
| 1521 | def ExecPresubmitScript(self, script_text, presubmit_path): |
| 1522 | """Executes a single presubmit script. |
| 1523 | |
| 1524 | Args: |
| 1525 | script_text: The text of the presubmit script. |
| 1526 | presubmit_path: The path to the presubmit file (this will be reported via |
| 1527 | input_api.PresubmitLocalPath()). |
| 1528 | |
| 1529 | Return: |
| 1530 | A list of result objects, empty if no problems. |
| 1531 | """ |
chase@chromium.org | 8e416c8 | 2009-10-06 04:30:44 +0000 | [diff] [blame] | 1532 | # Change to the presubmit file's directory to support local imports. |
| 1533 | main_path = os.getcwd() |
Saagar Sanghavi | 98b332f | 2020-07-31 17:19:15 +0000 | [diff] [blame] | 1534 | presubmit_dir = os.path.dirname(presubmit_path) |
| 1535 | os.chdir(presubmit_dir) |
chase@chromium.org | 8e416c8 | 2009-10-06 04:30:44 +0000 | [diff] [blame] | 1536 | |
| 1537 | # Load the presubmit script into context. |
dpranke@chromium.org | 970c522 | 2011-03-12 00:32:24 +0000 | [diff] [blame] | 1538 | input_api = InputApi(self.change, presubmit_path, self.committing, |
Aaron Gable | 668c1d8 | 2018-04-03 10:19:16 -0700 | [diff] [blame] | 1539 | self.verbose, gerrit_obj=self.gerrit, |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 1540 | dry_run=self.dry_run, thread_pool=self.thread_pool, |
| 1541 | parallel=self.parallel) |
Daniel Cheng | 7227d21 | 2017-11-17 08:12:37 -0800 | [diff] [blame] | 1542 | output_api = OutputApi(self.committing) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1543 | context = {} |
maruel@chromium.org | 899e1c1 | 2011-04-07 17:03:18 +0000 | [diff] [blame] | 1544 | try: |
Raul Tambre | 09e64b4 | 2019-05-14 01:57:22 +0000 | [diff] [blame] | 1545 | exec(compile(script_text, 'PRESUBMIT.py', 'exec', dont_inherit=True), |
| 1546 | context) |
Raul Tambre | 7c93846 | 2019-05-24 16:35:35 +0000 | [diff] [blame] | 1547 | except Exception as e: |
maruel@chromium.org | 899e1c1 | 2011-04-07 17:03:18 +0000 | [diff] [blame] | 1548 | raise PresubmitFailure('"%s" had an exception.\n%s' % (presubmit_path, e)) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1549 | |
| 1550 | # These function names must change if we make substantial changes to |
| 1551 | # the presubmit API that are not backwards compatible. |
| 1552 | if self.committing: |
| 1553 | function_name = 'CheckChangeOnCommit' |
| 1554 | else: |
| 1555 | function_name = 'CheckChangeOnUpload' |
| 1556 | if function_name in context: |
Raphael Kubo da Costa | f2d1615 | 2017-11-10 18:07:58 +0100 | [diff] [blame] | 1557 | try: |
Daniel Cheng | 7227d21 | 2017-11-17 08:12:37 -0800 | [diff] [blame] | 1558 | context['__args'] = (input_api, output_api) |
Raphael Kubo da Costa | f2d1615 | 2017-11-10 18:07:58 +0100 | [diff] [blame] | 1559 | logging.debug('Running %s in %s', function_name, presubmit_path) |
Saagar Sanghavi | 9949ab7 | 2020-07-20 20:56:40 +0000 | [diff] [blame] | 1560 | |
| 1561 | # TODO (crbug.com/1106943): Dive into each of the individual checks |
| 1562 | |
Saagar Sanghavi | 98b332f | 2020-07-31 17:19:15 +0000 | [diff] [blame] | 1563 | # Get path of presubmit directory relative to repository root. |
Saagar Sanghavi | 9949ab7 | 2020-07-20 20:56:40 +0000 | [diff] [blame] | 1564 | # Always use forward slashes, so that path is same in *nix and Windows |
Saagar Sanghavi | 98b332f | 2020-07-31 17:19:15 +0000 | [diff] [blame] | 1565 | root = input_api.change.RepositoryRoot() |
| 1566 | rel_path = os.path.relpath(presubmit_dir, root) |
Saagar Sanghavi | 9949ab7 | 2020-07-20 20:56:40 +0000 | [diff] [blame] | 1567 | rel_path = rel_path.replace(os.path.sep, '/') |
| 1568 | |
| 1569 | with rdb_wrapper.setup_rdb(function_name, rel_path) as my_status: |
| 1570 | result = eval(function_name + '(*__args)', context) |
| 1571 | self._check_result_type(result) |
| 1572 | if any(res.fatal for res in result): |
| 1573 | my_status.status = rdb_wrapper.STATUS_FAIL |
Raphael Kubo da Costa | f2d1615 | 2017-11-10 18:07:58 +0100 | [diff] [blame] | 1574 | logging.debug('Running %s done.', function_name) |
Daniel Cheng | d36fce4 | 2017-11-21 21:52:52 -0800 | [diff] [blame] | 1575 | self.more_cc.extend(output_api.more_cc) |
Raphael Kubo da Costa | f2d1615 | 2017-11-10 18:07:58 +0100 | [diff] [blame] | 1576 | finally: |
Edward Lemur | b983024 | 2019-10-30 22:19:20 +0000 | [diff] [blame] | 1577 | for f in input_api._named_temporary_files: |
| 1578 | os.remove(f) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1579 | else: |
| 1580 | result = () # no error since the script doesn't care about current event. |
| 1581 | |
chase@chromium.org | 8e416c8 | 2009-10-06 04:30:44 +0000 | [diff] [blame] | 1582 | # Return the process to the original working directory. |
| 1583 | os.chdir(main_path) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1584 | return result |
| 1585 | |
Saagar Sanghavi | 9949ab7 | 2020-07-20 20:56:40 +0000 | [diff] [blame] | 1586 | def _check_result_type(self, result): |
| 1587 | """Helper function which ensures result is a list, and all elements are |
| 1588 | instances of OutputApi.PresubmitResult""" |
| 1589 | if not isinstance(result, (tuple, list)): |
| 1590 | raise PresubmitFailure('Presubmit functions must return a tuple or list') |
| 1591 | if not all(isinstance(res, OutputApi.PresubmitResult) for res in result): |
| 1592 | raise PresubmitFailure( |
| 1593 | 'All presubmit results must be of types derived from ' |
| 1594 | 'output_api.PresubmitResult') |
| 1595 | |
| 1596 | |
maruel@chromium.org | 4ff922a | 2009-06-12 20:20:19 +0000 | [diff] [blame] | 1597 | def DoPresubmitChecks(change, |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1598 | committing, |
| 1599 | verbose, |
maruel@chromium.org | b0dfd35 | 2009-06-10 14:12:54 +0000 | [diff] [blame] | 1600 | default_presubmit, |
dpranke@chromium.org | 970c522 | 2011-03-12 00:32:24 +0000 | [diff] [blame] | 1601 | may_prompt, |
Aaron Gable | 668c1d8 | 2018-04-03 10:19:16 -0700 | [diff] [blame] | 1602 | gerrit_obj, |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 1603 | dry_run=None, |
Debrian Figueroa | dd2737e | 2019-06-21 23:50:13 +0000 | [diff] [blame] | 1604 | parallel=False, |
| 1605 | json_output=None): |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1606 | """Runs all presubmit checks that apply to the files in the change. |
| 1607 | |
| 1608 | This finds all PRESUBMIT.py files in directories enclosing the files in the |
| 1609 | change (up to the repository root) and calls the relevant entrypoint function |
| 1610 | depending on whether the change is being committed or uploaded. |
| 1611 | |
| 1612 | Prints errors, warnings and notifications. Prompts the user for warnings |
| 1613 | when needed. |
| 1614 | |
| 1615 | Args: |
maruel@chromium.org | 4ff922a | 2009-06-12 20:20:19 +0000 | [diff] [blame] | 1616 | change: The Change object. |
agable | 92bec4f | 2016-08-24 09:27:27 -0700 | [diff] [blame] | 1617 | committing: True if 'git cl land' is running, False if 'git cl upload' is. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1618 | verbose: Prints debug info. |
maruel@chromium.org | 0ff1fab | 2009-05-22 13:08:15 +0000 | [diff] [blame] | 1619 | default_presubmit: A default presubmit script to execute in any case. |
Quinten Yearsley | 516fe7f | 2016-12-14 11:50:18 -0800 | [diff] [blame] | 1620 | may_prompt: Enable (y/n) questions on warning or error. If False, |
| 1621 | any questions are answered with yes by default. |
tandrii@chromium.org | 37b07a7 | 2016-04-29 16:42:28 +0000 | [diff] [blame] | 1622 | gerrit_obj: provides basic Gerrit codereview functionality. |
tandrii@chromium.org | 57bafac | 2016-04-28 05:09:03 +0000 | [diff] [blame] | 1623 | dry_run: if true, some Checks will be skipped. |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 1624 | parallel: if true, all tests specified by input_api.RunTests in all |
| 1625 | PRESUBMIT files will be run in parallel. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1626 | |
| 1627 | Return: |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 1628 | 1 if presubmit checks failed or 0 otherwise. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1629 | """ |
maruel@chromium.org | ea7c855 | 2011-04-18 14:12:07 +0000 | [diff] [blame] | 1630 | old_environ = os.environ |
| 1631 | try: |
| 1632 | # Make sure python subprocesses won't generate .pyc files. |
| 1633 | os.environ = os.environ.copy() |
Edward Lemur | b983024 | 2019-10-30 22:19:20 +0000 | [diff] [blame] | 1634 | os.environ['PYTHONDONTWRITEBYTECODE'] = '1' |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1635 | |
maruel@chromium.org | ea7c855 | 2011-04-18 14:12:07 +0000 | [diff] [blame] | 1636 | if committing: |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 1637 | sys.stdout.write('Running presubmit commit checks ...\n') |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1638 | else: |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 1639 | sys.stdout.write('Running presubmit upload checks ...\n') |
Edward Lemur | ecc2707 | 2020-01-06 16:42:34 +0000 | [diff] [blame] | 1640 | start_time = time_time() |
maruel@chromium.org | ea7c855 | 2011-04-18 14:12:07 +0000 | [diff] [blame] | 1641 | presubmit_files = ListRelevantPresubmitFiles( |
agable | 0b65e73 | 2016-11-22 09:25:46 -0800 | [diff] [blame] | 1642 | change.AbsoluteLocalPaths(), change.RepositoryRoot()) |
maruel@chromium.org | ea7c855 | 2011-04-18 14:12:07 +0000 | [diff] [blame] | 1643 | if not presubmit_files and verbose: |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 1644 | sys.stdout.write('Warning, no PRESUBMIT.py found.\n') |
maruel@chromium.org | ea7c855 | 2011-04-18 14:12:07 +0000 | [diff] [blame] | 1645 | results = [] |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 1646 | thread_pool = ThreadPool() |
Edward Lemur | 7e3c67f | 2018-07-20 20:52:49 +0000 | [diff] [blame] | 1647 | executer = PresubmitExecuter(change, committing, verbose, gerrit_obj, |
| 1648 | dry_run, thread_pool, parallel) |
maruel@chromium.org | ea7c855 | 2011-04-18 14:12:07 +0000 | [diff] [blame] | 1649 | if default_presubmit: |
| 1650 | if verbose: |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 1651 | sys.stdout.write('Running default presubmit script.\n') |
maruel@chromium.org | ea7c855 | 2011-04-18 14:12:07 +0000 | [diff] [blame] | 1652 | fake_path = os.path.join(change.RepositoryRoot(), 'PRESUBMIT.py') |
| 1653 | results += executer.ExecPresubmitScript(default_presubmit, fake_path) |
| 1654 | for filename in presubmit_files: |
| 1655 | filename = os.path.abspath(filename) |
| 1656 | if verbose: |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 1657 | sys.stdout.write('Running %s\n' % filename) |
maruel@chromium.org | ea7c855 | 2011-04-18 14:12:07 +0000 | [diff] [blame] | 1658 | # Accept CRLF presubmit script. |
| 1659 | presubmit_script = gclient_utils.FileRead(filename, 'rU') |
| 1660 | results += executer.ExecPresubmitScript(presubmit_script, filename) |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 1661 | results += thread_pool.RunAsync() |
| 1662 | |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 1663 | messages = {} |
| 1664 | should_prompt = False |
| 1665 | presubmits_failed = False |
maruel@chromium.org | ea7c855 | 2011-04-18 14:12:07 +0000 | [diff] [blame] | 1666 | for result in results: |
| 1667 | if result.fatal: |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 1668 | presubmits_failed = True |
| 1669 | messages.setdefault('ERRORS', []).append(result) |
maruel@chromium.org | ea7c855 | 2011-04-18 14:12:07 +0000 | [diff] [blame] | 1670 | elif result.should_prompt: |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 1671 | should_prompt = True |
| 1672 | messages.setdefault('Warnings', []).append(result) |
maruel@chromium.org | ea7c855 | 2011-04-18 14:12:07 +0000 | [diff] [blame] | 1673 | else: |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 1674 | messages.setdefault('Messages', []).append(result) |
pam@chromium.org | ed9a083 | 2009-09-09 22:48:55 +0000 | [diff] [blame] | 1675 | |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 1676 | sys.stdout.write('\n') |
| 1677 | for name, items in messages.items(): |
| 1678 | sys.stdout.write('** Presubmit %s **\n' % name) |
| 1679 | for item in items: |
| 1680 | item.handle() |
| 1681 | sys.stdout.write('\n') |
pam@chromium.org | ed9a083 | 2009-09-09 22:48:55 +0000 | [diff] [blame] | 1682 | |
Edward Lemur | ecc2707 | 2020-01-06 16:42:34 +0000 | [diff] [blame] | 1683 | total_time = time_time() - start_time |
maruel@chromium.org | ea7c855 | 2011-04-18 14:12:07 +0000 | [diff] [blame] | 1684 | if total_time > 1.0: |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 1685 | sys.stdout.write( |
| 1686 | 'Presubmit checks took %.1fs to calculate.\n\n' % total_time) |
maruel@chromium.org | ce8e46b | 2009-06-26 22:31:51 +0000 | [diff] [blame] | 1687 | |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 1688 | if not should_prompt and not presubmits_failed: |
| 1689 | sys.stdout.write('Presubmit checks passed.\n') |
| 1690 | elif should_prompt: |
| 1691 | sys.stdout.write('There were presubmit warnings. ') |
Quinten Yearsley | 516fe7f | 2016-12-14 11:50:18 -0800 | [diff] [blame] | 1692 | if may_prompt: |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 1693 | presubmits_failed = not prompt_should_continue( |
| 1694 | 'Are you sure you wish to continue? (y/N): ') |
maruel@chromium.org | ea7c855 | 2011-04-18 14:12:07 +0000 | [diff] [blame] | 1695 | |
Edward Lemur | 1dc66e1 | 2020-02-21 21:36:34 +0000 | [diff] [blame] | 1696 | if json_output: |
| 1697 | # Write the presubmit results to json output |
| 1698 | presubmit_results = { |
| 1699 | 'errors': [ |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 1700 | error.json_format() |
| 1701 | for error in messages.get('ERRORS', []) |
Edward Lemur | 1dc66e1 | 2020-02-21 21:36:34 +0000 | [diff] [blame] | 1702 | ], |
| 1703 | 'notifications': [ |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 1704 | notification.json_format() |
| 1705 | for notification in messages.get('Messages', []) |
Edward Lemur | 1dc66e1 | 2020-02-21 21:36:34 +0000 | [diff] [blame] | 1706 | ], |
| 1707 | 'warnings': [ |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 1708 | warning.json_format() |
| 1709 | for warning in messages.get('Warnings', []) |
Edward Lemur | 1dc66e1 | 2020-02-21 21:36:34 +0000 | [diff] [blame] | 1710 | ], |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 1711 | 'more_cc': executer.more_cc, |
Edward Lemur | 1dc66e1 | 2020-02-21 21:36:34 +0000 | [diff] [blame] | 1712 | } |
| 1713 | |
| 1714 | gclient_utils.FileWrite( |
| 1715 | json_output, json.dumps(presubmit_results, sort_keys=True)) |
| 1716 | |
maruel@chromium.org | ea7c855 | 2011-04-18 14:12:07 +0000 | [diff] [blame] | 1717 | global _ASKED_FOR_FEEDBACK |
| 1718 | # Ask for feedback one time out of 5. |
| 1719 | if (len(results) and random.randint(0, 4) == 0 and not _ASKED_FOR_FEEDBACK): |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 1720 | sys.stdout.write( |
maruel@chromium.org | 1ce8e66 | 2014-01-14 15:23:00 +0000 | [diff] [blame] | 1721 | 'Was the presubmit check useful? If not, run "git cl presubmit -v"\n' |
| 1722 | 'to figure out which PRESUBMIT.py was run, then run git blame\n' |
| 1723 | 'on the file to figure out who to ask for help.\n') |
maruel@chromium.org | ea7c855 | 2011-04-18 14:12:07 +0000 | [diff] [blame] | 1724 | _ASKED_FOR_FEEDBACK = True |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 1725 | |
| 1726 | return 1 if presubmits_failed else 0 |
maruel@chromium.org | ea7c855 | 2011-04-18 14:12:07 +0000 | [diff] [blame] | 1727 | finally: |
| 1728 | os.environ = old_environ |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1729 | |
| 1730 | |
Edward Lemur | 50984a6 | 2020-02-06 18:10:18 +0000 | [diff] [blame] | 1731 | def _scan_sub_dirs(mask, recursive): |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1732 | if not recursive: |
pgervais@chromium.org | e57b09d | 2014-05-07 00:58:13 +0000 | [diff] [blame] | 1733 | return [x for x in glob.glob(mask) if x not in ('.svn', '.git')] |
Lei Zhang | 9611c4c | 2017-04-04 01:41:56 -0700 | [diff] [blame] | 1734 | |
| 1735 | results = [] |
| 1736 | for root, dirs, files in os.walk('.'): |
| 1737 | if '.svn' in dirs: |
| 1738 | dirs.remove('.svn') |
| 1739 | if '.git' in dirs: |
| 1740 | dirs.remove('.git') |
| 1741 | for name in files: |
| 1742 | if fnmatch.fnmatch(name, mask): |
| 1743 | results.append(os.path.join(root, name)) |
| 1744 | return results |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1745 | |
| 1746 | |
Edward Lemur | 50984a6 | 2020-02-06 18:10:18 +0000 | [diff] [blame] | 1747 | def _parse_files(args, recursive): |
tobiasjs | 2836bcf | 2016-08-16 04:08:16 -0700 | [diff] [blame] | 1748 | logging.debug('Searching for %s', args) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1749 | files = [] |
| 1750 | for arg in args: |
Edward Lemur | 50984a6 | 2020-02-06 18:10:18 +0000 | [diff] [blame] | 1751 | files.extend([('M', f) for f in _scan_sub_dirs(arg, recursive)]) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1752 | return files |
| 1753 | |
| 1754 | |
Edward Lemur | 50984a6 | 2020-02-06 18:10:18 +0000 | [diff] [blame] | 1755 | def _parse_change(parser, options): |
| 1756 | """Process change options. |
| 1757 | |
| 1758 | Args: |
| 1759 | parser: The parser used to parse the arguments from command line. |
| 1760 | options: The arguments parsed from command line. |
| 1761 | Returns: |
| 1762 | A GitChange if the change root is a git repository, or a Change otherwise. |
| 1763 | """ |
| 1764 | if options.files and options.all_files: |
| 1765 | parser.error('<files> cannot be specified when --all-files is set.') |
| 1766 | |
Edward Lesmes | 44ea3ff | 2020-02-05 00:14:30 +0000 | [diff] [blame] | 1767 | change_scm = scm.determine_scm(options.root) |
Edward Lemur | 50984a6 | 2020-02-06 18:10:18 +0000 | [diff] [blame] | 1768 | if change_scm != 'git' and not options.files: |
| 1769 | parser.error('<files> is not optional for unversioned directories.') |
| 1770 | |
| 1771 | if options.files: |
| 1772 | change_files = _parse_files(options.files, options.recursive) |
| 1773 | elif options.all_files: |
| 1774 | change_files = [('M', f) for f in scm.GIT.GetAllFiles(options.root)] |
maruel@chromium.org | 5c8c6de | 2011-03-18 16:20:18 +0000 | [diff] [blame] | 1775 | else: |
Edward Lemur | 50984a6 | 2020-02-06 18:10:18 +0000 | [diff] [blame] | 1776 | change_files = scm.GIT.CaptureStatus( |
Edward Lemur | 7f6dec0 | 2020-02-06 20:23:58 +0000 | [diff] [blame] | 1777 | options.root, options.upstream or None) |
Edward Lemur | 50984a6 | 2020-02-06 18:10:18 +0000 | [diff] [blame] | 1778 | |
| 1779 | logging.info('Found %d file(s).', len(change_files)) |
| 1780 | |
| 1781 | change_class = GitChange if change_scm == 'git' else Change |
| 1782 | return change_class( |
| 1783 | options.name, |
| 1784 | options.description, |
| 1785 | options.root, |
| 1786 | change_files, |
| 1787 | options.issue, |
| 1788 | options.patchset, |
| 1789 | options.author, |
| 1790 | upstream=options.upstream) |
| 1791 | |
| 1792 | |
| 1793 | def _parse_gerrit_options(parser, options): |
| 1794 | """Process gerrit options. |
| 1795 | |
| 1796 | SIDE EFFECTS: Modifies options.author and options.description from Gerrit if |
| 1797 | options.gerrit_fetch is set. |
| 1798 | |
| 1799 | Args: |
| 1800 | parser: The parser used to parse the arguments from command line. |
| 1801 | options: The arguments parsed from command line. |
| 1802 | Returns: |
| 1803 | A GerritAccessor object if options.gerrit_url is set, or None otherwise. |
| 1804 | """ |
| 1805 | gerrit_obj = None |
| 1806 | if options.gerrit_url: |
| 1807 | gerrit_obj = GerritAccessor(urlparse.urlparse(options.gerrit_url).netloc) |
| 1808 | |
| 1809 | if not options.gerrit_fetch: |
| 1810 | return gerrit_obj |
| 1811 | |
| 1812 | if not options.gerrit_url or not options.issue or not options.patchset: |
| 1813 | parser.error( |
| 1814 | '--gerrit_fetch requires --gerrit_url, --issue and --patchset.') |
| 1815 | |
| 1816 | options.author = gerrit_obj.GetChangeOwner(options.issue) |
| 1817 | options.description = gerrit_obj.GetChangeDescription( |
| 1818 | options.issue, options.patchset) |
| 1819 | |
| 1820 | logging.info('Got author: "%s"', options.author) |
| 1821 | logging.info('Got description: """\n%s\n"""', options.description) |
| 1822 | |
| 1823 | return gerrit_obj |
maruel@chromium.org | 5c8c6de | 2011-03-18 16:20:18 +0000 | [diff] [blame] | 1824 | |
| 1825 | |
iannucci@chromium.org | 8a4a2bc | 2013-03-08 08:13:20 +0000 | [diff] [blame] | 1826 | @contextlib.contextmanager |
| 1827 | def canned_check_filter(method_names): |
| 1828 | filtered = {} |
| 1829 | try: |
| 1830 | for method_name in method_names: |
| 1831 | if not hasattr(presubmit_canned_checks, method_name): |
Aaron Gable | ecee74c | 2018-04-02 15:13:08 -0700 | [diff] [blame] | 1832 | logging.warn('Skipping unknown "canned" check %s' % method_name) |
| 1833 | continue |
iannucci@chromium.org | 8a4a2bc | 2013-03-08 08:13:20 +0000 | [diff] [blame] | 1834 | filtered[method_name] = getattr(presubmit_canned_checks, method_name) |
| 1835 | setattr(presubmit_canned_checks, method_name, lambda *_a, **_kw: []) |
| 1836 | yield |
| 1837 | finally: |
Marc-Antoine Ruel | 8e57b4b | 2019-10-11 01:01:36 +0000 | [diff] [blame] | 1838 | for name, method in filtered.items(): |
iannucci@chromium.org | 8a4a2bc | 2013-03-08 08:13:20 +0000 | [diff] [blame] | 1839 | setattr(presubmit_canned_checks, name, method) |
| 1840 | |
maruel@chromium.org | ffeb2f3 | 2013-12-03 13:55:22 +0000 | [diff] [blame] | 1841 | |
sbc@chromium.org | 013731e | 2015-02-26 18:28:43 +0000 | [diff] [blame] | 1842 | def main(argv=None): |
Edward Lemur | a5799e3 | 2020-01-17 19:26:51 +0000 | [diff] [blame] | 1843 | parser = argparse.ArgumentParser(usage='%(prog)s [options] <files...>') |
| 1844 | hooks = parser.add_mutually_exclusive_group() |
| 1845 | hooks.add_argument('-c', '--commit', action='store_true', |
| 1846 | help='Use commit instead of upload checks.') |
| 1847 | hooks.add_argument('-u', '--upload', action='store_false', dest='commit', |
| 1848 | help='Use upload instead of commit checks.') |
Edward Lemur | 7552630 | 2020-02-27 22:31:05 +0000 | [diff] [blame] | 1849 | hooks.add_argument('--post_upload', action='store_true', |
| 1850 | help='Run post-upload commit hooks.') |
Edward Lemur | a5799e3 | 2020-01-17 19:26:51 +0000 | [diff] [blame] | 1851 | parser.add_argument('-r', '--recursive', action='store_true', |
| 1852 | help='Act recursively.') |
| 1853 | parser.add_argument('-v', '--verbose', action='count', default=0, |
| 1854 | help='Use 2 times for more debug info.') |
| 1855 | parser.add_argument('--name', default='no name') |
| 1856 | parser.add_argument('--author') |
Edward Lemur | 227d510 | 2020-02-25 23:45:35 +0000 | [diff] [blame] | 1857 | desc = parser.add_mutually_exclusive_group() |
| 1858 | desc.add_argument('--description', default='', help='The change description.') |
| 1859 | desc.add_argument('--description_file', |
| 1860 | help='File to read change description from.') |
Edward Lemur | a5799e3 | 2020-01-17 19:26:51 +0000 | [diff] [blame] | 1861 | parser.add_argument('--issue', type=int, default=0) |
| 1862 | parser.add_argument('--patchset', type=int, default=0) |
| 1863 | parser.add_argument('--root', default=os.getcwd(), |
| 1864 | help='Search for PRESUBMIT.py up to this directory. ' |
| 1865 | 'If inherit-review-settings-ok is present in this ' |
| 1866 | 'directory, parent directories up to the root file ' |
| 1867 | 'system directories will also be searched.') |
| 1868 | parser.add_argument('--upstream', |
| 1869 | help='Git only: the base ref or upstream branch against ' |
| 1870 | 'which the diff should be computed.') |
| 1871 | parser.add_argument('--default_presubmit') |
| 1872 | parser.add_argument('--may_prompt', action='store_true', default=False) |
| 1873 | parser.add_argument('--skip_canned', action='append', default=[], |
| 1874 | help='A list of checks to skip which appear in ' |
| 1875 | 'presubmit_canned_checks. Can be provided multiple times ' |
| 1876 | 'to skip multiple canned checks.') |
| 1877 | parser.add_argument('--dry_run', action='store_true', help=argparse.SUPPRESS) |
| 1878 | parser.add_argument('--gerrit_url', help=argparse.SUPPRESS) |
| 1879 | parser.add_argument('--gerrit_fetch', action='store_true', |
| 1880 | help=argparse.SUPPRESS) |
| 1881 | parser.add_argument('--parallel', action='store_true', |
| 1882 | help='Run all tests specified by input_api.RunTests in ' |
| 1883 | 'all PRESUBMIT files in parallel.') |
| 1884 | parser.add_argument('--json_output', |
| 1885 | help='Write presubmit errors to json output.') |
Edward Lemur | 1dc66e1 | 2020-02-21 21:36:34 +0000 | [diff] [blame] | 1886 | parser.add_argument('--all_files', action='store_true', |
Edward Lemur | 50984a6 | 2020-02-06 18:10:18 +0000 | [diff] [blame] | 1887 | help='Mark all files under source control as modified.') |
Edward Lemur | a5799e3 | 2020-01-17 19:26:51 +0000 | [diff] [blame] | 1888 | parser.add_argument('files', nargs='*', |
| 1889 | help='List of files to be marked as modified when ' |
| 1890 | 'executing presubmit or post-upload hooks. fnmatch ' |
| 1891 | 'wildcards can also be used.') |
pgervais@chromium.org | 92c3009 | 2014-04-15 00:30:37 +0000 | [diff] [blame] | 1892 | |
Edward Lemur | a5799e3 | 2020-01-17 19:26:51 +0000 | [diff] [blame] | 1893 | options = parser.parse_args(argv) |
pgervais@chromium.org | 92c3009 | 2014-04-15 00:30:37 +0000 | [diff] [blame] | 1894 | |
Erik Staab | cca5c49 | 2020-04-16 17:40:07 +0000 | [diff] [blame] | 1895 | log_level = logging.ERROR |
maruel@chromium.org | 899e1c1 | 2011-04-07 17:03:18 +0000 | [diff] [blame] | 1896 | if options.verbose >= 2: |
Erik Staab | cca5c49 | 2020-04-16 17:40:07 +0000 | [diff] [blame] | 1897 | log_level = logging.DEBUG |
maruel@chromium.org | 899e1c1 | 2011-04-07 17:03:18 +0000 | [diff] [blame] | 1898 | elif options.verbose: |
Erik Staab | cca5c49 | 2020-04-16 17:40:07 +0000 | [diff] [blame] | 1899 | log_level = logging.INFO |
| 1900 | log_format = ('[%(levelname).1s%(asctime)s %(process)d %(thread)d ' |
| 1901 | '%(filename)s] %(message)s') |
| 1902 | logging.basicConfig(format=log_format, level=log_level) |
pgervais@chromium.org | 92c3009 | 2014-04-15 00:30:37 +0000 | [diff] [blame] | 1903 | |
Edward Lemur | 227d510 | 2020-02-25 23:45:35 +0000 | [diff] [blame] | 1904 | if options.description_file: |
| 1905 | options.description = gclient_utils.FileRead(options.description_file) |
Edward Lemur | 50984a6 | 2020-02-06 18:10:18 +0000 | [diff] [blame] | 1906 | gerrit_obj = _parse_gerrit_options(parser, options) |
| 1907 | change = _parse_change(parser, options) |
pgervais@chromium.org | 92c3009 | 2014-04-15 00:30:37 +0000 | [diff] [blame] | 1908 | |
maruel@chromium.org | 899e1c1 | 2011-04-07 17:03:18 +0000 | [diff] [blame] | 1909 | try: |
Edward Lemur | 7552630 | 2020-02-27 22:31:05 +0000 | [diff] [blame] | 1910 | if options.post_upload: |
| 1911 | return DoPostUploadExecuter( |
| 1912 | change, |
| 1913 | gerrit_obj, |
| 1914 | options.verbose) |
iannucci@chromium.org | 8a4a2bc | 2013-03-08 08:13:20 +0000 | [diff] [blame] | 1915 | with canned_check_filter(options.skip_canned): |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 1916 | return DoPresubmitChecks( |
Edward Lemur | 50984a6 | 2020-02-06 18:10:18 +0000 | [diff] [blame] | 1917 | change, |
iannucci@chromium.org | 8a4a2bc | 2013-03-08 08:13:20 +0000 | [diff] [blame] | 1918 | options.commit, |
| 1919 | options.verbose, |
iannucci@chromium.org | 8a4a2bc | 2013-03-08 08:13:20 +0000 | [diff] [blame] | 1920 | options.default_presubmit, |
| 1921 | options.may_prompt, |
tandrii@chromium.org | 37b07a7 | 2016-04-29 16:42:28 +0000 | [diff] [blame] | 1922 | gerrit_obj, |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 1923 | options.dry_run, |
Debrian Figueroa | dd2737e | 2019-06-21 23:50:13 +0000 | [diff] [blame] | 1924 | options.parallel, |
| 1925 | options.json_output) |
Raul Tambre | 7c93846 | 2019-05-24 16:35:35 +0000 | [diff] [blame] | 1926 | except PresubmitFailure as e: |
Raul Tambre | 80ee78e | 2019-05-06 22:41:05 +0000 | [diff] [blame] | 1927 | print(e, file=sys.stderr) |
| 1928 | print('Maybe your depot_tools is out of date?', file=sys.stderr) |
maruel@chromium.org | 899e1c1 | 2011-04-07 17:03:18 +0000 | [diff] [blame] | 1929 | return 2 |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1930 | |
| 1931 | |
| 1932 | if __name__ == '__main__': |
maruel@chromium.org | 35625c7 | 2011-03-23 17:34:02 +0000 | [diff] [blame] | 1933 | fix_encoding.fix_encoding() |
sbc@chromium.org | 013731e | 2015-02-26 18:28:43 +0000 | [diff] [blame] | 1934 | try: |
| 1935 | sys.exit(main()) |
| 1936 | except KeyboardInterrupt: |
| 1937 | sys.stderr.write('interrupted\n') |
sergiyb | f8a3b38 | 2016-07-05 11:21:30 -0700 | [diff] [blame] | 1938 | sys.exit(2) |