blob: fc77ef8c2bf93cc7ff3305748f4a15d991e2c492 [file] [log] [blame]
Edward Lemur1f3bafb2019-10-08 17:56:33 +00001#!/usr/bin/env vpython
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +02002# Copyright (c) 2013 The Chromium Authors. All rights reserved.
maruel@chromium.org725f1c32011-04-01 20:24:54 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00006# Copyright (C) 2008 Evan Martin <martine@danga.com>
7
Andrii Shyshkalov03da1502018-10-15 03:42:34 +00008"""A git-command for integrating reviews on Gerrit."""
maruel@chromium.org725f1c32011-04-01 20:24:54 +00009
vapiera7fbd5a2016-06-16 09:17:49 -070010from __future__ import print_function
11
thakis@chromium.org3421c992014-11-02 02:20:32 +000012import base64
rmistry@google.com2dd99862015-06-22 12:22:18 +000013import collections
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +010014import datetime
Brian Sheedyb4307d52019-12-02 19:18:17 +000015import fnmatch
Edward Lemur202c5592019-10-21 22:44:52 +000016import httplib2
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +010017import itertools
maruel@chromium.org4f6852c2012-04-20 20:39:20 +000018import json
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000019import logging
calamity@chromium.orgcf197482016-04-29 20:15:53 +000020import multiprocessing
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000021import optparse
22import os
23import re
Andrii Shyshkalov353637c2017-03-14 16:52:18 +010024import shutil
ukai@chromium.org78c4b982012-02-14 02:20:26 +000025import stat
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000026import sys
Aaron Gable9a03ae02017-11-03 11:31:07 -070027import tempfile
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000028import textwrap
Edward Lemurfec80c42018-11-01 23:14:14 +000029import time
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +000030import uuid
thestig@chromium.org00858c82013-12-02 23:08:03 +000031import webbrowser
thakis@chromium.org3421c992014-11-02 02:20:32 +000032import zlib
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000033
maruel@chromium.org2e23ce32013-05-07 12:42:28 +000034from third_party import colorama
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +000035import auth
nick@chromium.org3ac1c4e2014-01-16 02:44:42 +000036import clang_format
maruel@chromium.org6f09cd92011-04-01 16:38:12 +000037import fix_encoding
maruel@chromium.org0e0436a2011-10-25 13:32:41 +000038import gclient_utils
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +000039import gerrit_util
iannucci@chromium.org9e849272014-04-04 00:31:55 +000040import git_common
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +000041import git_footers
Edward Lemur85153282020-02-14 22:06:29 +000042import git_new_branch
Edward Lemur5ba1e9c2018-07-23 18:19:02 +000043import metrics
Edward Lesmes93277a72018-10-18 22:04:26 +000044import metrics_utils
Edward Lesmeseeca9c62020-11-20 00:00:17 +000045import owners_client
iannucci@chromium.org9e849272014-04-04 00:31:55 +000046import owners_finder
Lei Zhangb8c62cf2020-07-15 20:09:37 +000047import presubmit_canned_checks
maruel@chromium.org2a74d372011-03-29 19:05:50 +000048import presubmit_support
49import scm
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000050import setup_color
Francois Dorayd42c6812017-05-30 15:10:20 -040051import split_cl
maruel@chromium.org0633fb42013-08-16 20:06:14 +000052import subcommand
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +000053import subprocess2
maruel@chromium.org2a74d372011-03-29 19:05:50 +000054import watchlists
55
Edward Lemur79d4f992019-11-11 23:49:02 +000056from third_party import six
57from six.moves import urllib
58
59
60if sys.version_info.major == 3:
61 basestring = (str,) # pylint: disable=redefined-builtin
62
Edward Lemurb9830242019-10-30 22:19:20 +000063
tandrii7400cf02016-06-21 08:48:07 -070064__version__ = '2.0'
maruel@chromium.org2a74d372011-03-29 19:05:50 +000065
Edward Lemur0f58ae42019-04-30 17:24:12 +000066# Traces for git push will be stored in a traces directory inside the
67# depot_tools checkout.
68DEPOT_TOOLS = os.path.dirname(os.path.abspath(__file__))
69TRACES_DIR = os.path.join(DEPOT_TOOLS, 'traces')
Edward Lemur227d5102020-02-25 23:45:35 +000070PRESUBMIT_SUPPORT = os.path.join(DEPOT_TOOLS, 'presubmit_support.py')
Edward Lemur0f58ae42019-04-30 17:24:12 +000071
72# When collecting traces, Git hashes will be reduced to 6 characters to reduce
73# the size after compression.
74GIT_HASH_RE = re.compile(r'\b([a-f0-9]{6})[a-f0-9]{34}\b', flags=re.I)
75# Used to redact the cookies from the gitcookies file.
76GITCOOKIES_REDACT_RE = re.compile(r'1/.*')
77
Edward Lemurd4d1ba42019-09-20 21:46:37 +000078MAX_ATTEMPTS = 3
79
Edward Lemur1b52d872019-05-09 21:12:12 +000080# The maximum number of traces we will keep. Multiplied by 3 since we store
81# 3 files per trace.
82MAX_TRACES = 3 * 10
Edward Lemur5737f022019-05-17 01:24:00 +000083# Message to be displayed to the user to inform where to find the traces for a
84# git-cl upload execution.
Edward Lemur0f58ae42019-04-30 17:24:12 +000085TRACES_MESSAGE = (
Edward Lemur1b52d872019-05-09 21:12:12 +000086'\n'
Edward Lemur5737f022019-05-17 01:24:00 +000087'The traces of this git-cl execution have been recorded at:\n'
Edward Lemur1b52d872019-05-09 21:12:12 +000088' %(trace_name)s-traces.zip\n'
Edward Lemur5737f022019-05-17 01:24:00 +000089'Copies of your gitcookies file and git config have been recorded at:\n'
90' %(trace_name)s-git-info.zip\n')
Edward Lemur1b52d872019-05-09 21:12:12 +000091# Format of the message to be stored as part of the traces to give developers a
92# better context when they go through traces.
93TRACES_README_FORMAT = (
94'Date: %(now)s\n'
95'\n'
96'Change: https://%(gerrit_host)s/q/%(change_id)s\n'
97'Title: %(title)s\n'
98'\n'
99'%(description)s\n'
100'\n'
101'Execution time: %(execution_time)s\n'
102'Exit code: %(exit_code)s\n') + TRACES_MESSAGE
Edward Lemur0f58ae42019-04-30 17:24:12 +0000103
Aaron Gable1bc7bfe2016-12-19 10:08:14 -0800104POSTUPSTREAM_HOOK = '.git/hooks/post-cl-land'
Henrique Ferreiroff249622019-11-28 23:19:29 +0000105DESCRIPTION_BACKUP_FILE = '.git_cl_description_backup'
rmistry@google.comc68112d2015-03-03 12:48:06 +0000106REFS_THAT_ALIAS_TO_OTHER_REFS = {
107 'refs/remotes/origin/lkgr': 'refs/remotes/origin/master',
108 'refs/remotes/origin/lkcr': 'refs/remotes/origin/master',
109}
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000110
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000111DEFAULT_OLD_BRANCH = 'refs/remotes/origin/master'
112DEFAULT_NEW_BRANCH = 'refs/remotes/origin/main'
113
thestig@chromium.org44202a22014-03-11 19:22:18 +0000114# Valid extensions for files we want to lint.
115DEFAULT_LINT_REGEX = r"(.*\.cpp|.*\.cc|.*\.h)"
116DEFAULT_LINT_IGNORE_REGEX = r"$^"
117
Aiden Bennerc08566e2018-10-03 17:52:42 +0000118# File name for yapf style config files.
119YAPF_CONFIG_FILENAME = '.style.yapf'
120
Edward Lesmes50da7702020-03-30 19:23:43 +0000121# The issue, patchset and codereview server are stored on git config for each
122# branch under branch.<branch-name>.<config-key>.
123ISSUE_CONFIG_KEY = 'gerritissue'
124PATCHSET_CONFIG_KEY = 'gerritpatchset'
125CODEREVIEW_SERVER_CONFIG_KEY = 'gerritserver'
126
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000127# Shortcut since it quickly becomes repetitive.
maruel@chromium.org2e23ce32013-05-07 12:42:28 +0000128Fore = colorama.Fore
maruel@chromium.org90541732011-04-01 17:54:18 +0000129
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000130# Initialized in main()
131settings = None
132
Andrii Shyshkalov768f1d82016-12-08 15:10:13 +0100133# Used by tests/git_cl_test.py to add extra logging.
134# Inside the weirdly failing test, add this:
135# >>> self.mock(git_cl, '_IS_BEING_TESTED', True)
Quinten Yearsley0c62da92017-05-31 13:39:42 -0700136# And scroll up to see the stack trace printed.
Andrii Shyshkalov768f1d82016-12-08 15:10:13 +0100137_IS_BEING_TESTED = False
138
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000139
Andrii Shyshkalov1ee78cd2020-03-12 01:31:53 +0000140_KNOWN_GERRIT_TO_SHORT_URLS = {
141 'https://chrome-internal-review.googlesource.com': 'https://crrev.com/i',
142 'https://chromium-review.googlesource.com': 'https://crrev.com/c',
143}
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000144assert len(_KNOWN_GERRIT_TO_SHORT_URLS) == len(
145 set(_KNOWN_GERRIT_TO_SHORT_URLS.values())), 'must have unique values'
Andrii Shyshkalov1ee78cd2020-03-12 01:31:53 +0000146
147
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000148class GitPushError(Exception):
149 pass
150
151
Christopher Lamf732cd52017-01-24 12:40:11 +1100152def DieWithError(message, change_desc=None):
153 if change_desc:
154 SaveDescriptionBackup(change_desc)
Josip Sokcevic953278a2020-02-28 19:46:36 +0000155 print('\n ** Content of CL description **\n' +
156 '='*72 + '\n' +
157 change_desc.description + '\n' +
158 '='*72 + '\n')
Christopher Lamf732cd52017-01-24 12:40:11 +1100159
vapiera7fbd5a2016-06-16 09:17:49 -0700160 print(message, file=sys.stderr)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000161 sys.exit(1)
162
163
Christopher Lamf732cd52017-01-24 12:40:11 +1100164def SaveDescriptionBackup(change_desc):
Henrique Ferreiro5ae48172019-11-29 16:14:42 +0000165 backup_path = os.path.join(DEPOT_TOOLS, DESCRIPTION_BACKUP_FILE)
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000166 print('\nsaving CL description to %s\n' % backup_path)
Josip906bfde2020-01-31 22:38:49 +0000167 with open(backup_path, 'w') as backup_file:
168 backup_file.write(change_desc.description)
Christopher Lamf732cd52017-01-24 12:40:11 +1100169
170
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000171def GetNoGitPagerEnv():
172 env = os.environ.copy()
173 # 'cat' is a magical git string that disables pagers on all platforms.
174 env['GIT_PAGER'] = 'cat'
175 return env
176
vadimsh@chromium.org566a02a2014-08-22 01:34:13 +0000177
bsep@chromium.org627d9002016-04-29 00:00:52 +0000178def RunCommand(args, error_ok=False, error_message=None, shell=False, **kwargs):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000179 try:
Edward Lemur79d4f992019-11-11 23:49:02 +0000180 stdout = subprocess2.check_output(args, shell=shell, **kwargs)
181 return stdout.decode('utf-8', 'replace')
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000182 except subprocess2.CalledProcessError as e:
183 logging.debug('Failed running %s', args)
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +0000184 if not error_ok:
Alan Cutter594fd332020-07-21 23:55:27 +0000185 message = error_message or e.stdout.decode('utf-8', 'replace') or ''
186 DieWithError('Command "%s" failed.\n%s' % (' '.join(args), message))
Edward Lemur79d4f992019-11-11 23:49:02 +0000187 return e.stdout.decode('utf-8', 'replace')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000188
189
190def RunGit(args, **kwargs):
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +0000191 """Returns stdout."""
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000192 return RunCommand(['git'] + args, **kwargs)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000193
194
enne@chromium.org3b7e15c2014-01-21 17:44:47 +0000195def RunGitWithCode(args, suppress_stderr=False):
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +0000196 """Returns return code and stdout."""
tandrii5d48c322016-08-18 16:19:37 -0700197 if suppress_stderr:
Edward Lesmescf06cad2020-12-14 22:03:23 +0000198 stderr = subprocess2.DEVNULL
tandrii5d48c322016-08-18 16:19:37 -0700199 else:
200 stderr = sys.stderr
szager@chromium.org9bb85e22012-06-13 20:28:23 +0000201 try:
tandrii5d48c322016-08-18 16:19:37 -0700202 (out, _), code = subprocess2.communicate(['git'] + args,
203 env=GetNoGitPagerEnv(),
204 stdout=subprocess2.PIPE,
205 stderr=stderr)
Edward Lemur79d4f992019-11-11 23:49:02 +0000206 return code, out.decode('utf-8', 'replace')
tandrii5d48c322016-08-18 16:19:37 -0700207 except subprocess2.CalledProcessError as e:
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +0900208 logging.debug('Failed running %s', ['git'] + args)
Edward Lemur79d4f992019-11-11 23:49:02 +0000209 return e.returncode, e.stdout.decode('utf-8', 'replace')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000210
211
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000212def RunGitSilent(args):
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +0000213 """Returns stdout, suppresses stderr and ignores the return code."""
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000214 return RunGitWithCode(args, suppress_stderr=True)[1]
215
216
tandrii2a16b952016-10-19 07:09:44 -0700217def time_sleep(seconds):
218 # Use this so that it can be mocked in tests without interfering with python
219 # system machinery.
tandrii2a16b952016-10-19 07:09:44 -0700220 return time.sleep(seconds)
221
222
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000223def time_time():
224 # Use this so that it can be mocked in tests without interfering with python
225 # system machinery.
226 return time.time()
227
228
Edward Lemur1b52d872019-05-09 21:12:12 +0000229def datetime_now():
230 # Use this so that it can be mocked in tests without interfering with python
231 # system machinery.
232 return datetime.datetime.now()
233
234
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100235def confirm_or_exit(prefix='', action='confirm'):
236 """Asks user to press enter to continue or press Ctrl+C to abort."""
237 if not prefix or prefix.endswith('\n'):
238 mid = 'Press'
Andrii Shyshkalov353637c2017-03-14 16:52:18 +0100239 elif prefix.endswith('.') or prefix.endswith('?'):
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100240 mid = ' Press'
241 elif prefix.endswith(' '):
242 mid = 'press'
243 else:
244 mid = ' press'
Edward Lesmesae3586b2020-03-23 21:21:14 +0000245 gclient_utils.AskForData(
246 '%s%s Enter to %s, or Ctrl+C to abort' % (prefix, mid, action))
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100247
248
249def ask_for_explicit_yes(prompt):
Quinten Yearsleyd242ed72019-07-25 17:17:55 +0000250 """Returns whether user typed 'y' or 'yes' to confirm the given prompt."""
Edward Lesmesae3586b2020-03-23 21:21:14 +0000251 result = gclient_utils.AskForData(prompt + ' [Yes/No]: ').lower()
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100252 while True:
253 if 'yes'.startswith(result):
254 return True
255 if 'no'.startswith(result):
256 return False
Edward Lesmesae3586b2020-03-23 21:21:14 +0000257 result = gclient_utils.AskForData('Please, type yes or no: ').lower()
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100258
259
machenbach@chromium.org45453142015-09-15 08:45:22 +0000260def _get_properties_from_options(options):
Quinten Yearsleya19d3532019-09-30 21:54:39 +0000261 prop_list = getattr(options, 'properties', [])
262 properties = dict(x.split('=', 1) for x in prop_list)
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +0000263 for key, val in properties.items():
machenbach@chromium.org45453142015-09-15 08:45:22 +0000264 try:
265 properties[key] = json.loads(val)
266 except ValueError:
267 pass # If a value couldn't be evaluated, treat it as a string.
268 return properties
269
270
Edward Lemur4c707a22019-09-24 21:13:43 +0000271def _call_buildbucket(http, buildbucket_host, method, request):
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000272 """Calls a buildbucket v2 method and returns the parsed json response."""
273 headers = {
274 'Accept': 'application/json',
275 'Content-Type': 'application/json',
276 }
277 request = json.dumps(request)
278 url = 'https://%s/prpc/buildbucket.v2.Builds/%s' % (buildbucket_host, method)
279
280 logging.info('POST %s with %s' % (url, request))
281
282 attempts = 1
283 time_to_sleep = 1
284 while True:
285 response, content = http.request(url, 'POST', body=request, headers=headers)
286 if response.status == 200:
287 return json.loads(content[4:])
288 if attempts >= MAX_ATTEMPTS or 400 <= response.status < 500:
289 msg = '%s error when calling POST %s with %s: %s' % (
290 response.status, url, request, content)
291 raise BuildbucketResponseException(msg)
292 logging.debug(
293 '%s error when calling POST %s with %s. '
294 'Sleeping for %d seconds and retrying...' % (
295 response.status, url, request, time_to_sleep))
296 time.sleep(time_to_sleep)
297 time_to_sleep *= 2
298 attempts += 1
299
300 assert False, 'unreachable'
301
302
Edward Lemur6215c792019-10-03 21:59:05 +0000303def _parse_bucket(raw_bucket):
304 legacy = True
305 project = bucket = None
306 if '/' in raw_bucket:
307 legacy = False
308 project, bucket = raw_bucket.split('/', 1)
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000309 # Assume luci.<project>.<bucket>.
Edward Lemur6215c792019-10-03 21:59:05 +0000310 elif raw_bucket.startswith('luci.'):
311 project, bucket = raw_bucket[len('luci.'):].split('.', 1)
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000312 # Otherwise, assume prefix is also the project name.
Edward Lemur6215c792019-10-03 21:59:05 +0000313 elif '.' in raw_bucket:
314 project = raw_bucket.split('.')[0]
315 bucket = raw_bucket
316 # Legacy buckets.
Edward Lemur45768512020-03-02 19:03:14 +0000317 if legacy and project and bucket:
Edward Lemur6215c792019-10-03 21:59:05 +0000318 print('WARNING Please use %s/%s to specify the bucket.' % (project, bucket))
319 return project, bucket
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000320
321
Quinten Yearsley777660f2020-03-04 23:37:06 +0000322def _trigger_tryjobs(changelist, jobs, options, patchset):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000323 """Sends a request to Buildbucket to trigger tryjobs for a changelist.
qyearsley1fdfcb62016-10-24 13:22:03 -0700324
325 Args:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000326 changelist: Changelist that the tryjobs are associated with.
Edward Lemur45768512020-03-02 19:03:14 +0000327 jobs: A list of (project, bucket, builder).
qyearsley1fdfcb62016-10-24 13:22:03 -0700328 options: Command-line options.
329 """
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000330 print('Scheduling jobs on:')
Edward Lemur45768512020-03-02 19:03:14 +0000331 for project, bucket, builder in jobs:
332 print(' %s/%s: %s' % (project, bucket, builder))
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000333 print('To see results here, run: git cl try-results')
334 print('To see results in browser, run: git cl web')
tandriide281ae2016-10-12 06:02:30 -0700335
Quinten Yearsley777660f2020-03-04 23:37:06 +0000336 requests = _make_tryjob_schedule_requests(changelist, jobs, options, patchset)
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +0000337 if not requests:
338 return
339
Edward Lemur5b929a42019-10-21 17:57:39 +0000340 http = auth.Authenticator().authorize(httplib2.Http())
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +0000341 http.force_exception_to_status_code = True
342
343 batch_request = {'requests': requests}
344 batch_response = _call_buildbucket(
345 http, options.buildbucket_host, 'Batch', batch_request)
346
347 errors = [
348 ' ' + response['error']['message']
349 for response in batch_response.get('responses', [])
350 if 'error' in response
351 ]
352 if errors:
353 raise BuildbucketResponseException(
354 'Failed to schedule builds for some bots:\n%s' % '\n'.join(errors))
355
356
Quinten Yearsley777660f2020-03-04 23:37:06 +0000357def _make_tryjob_schedule_requests(changelist, jobs, options, patchset):
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +0000358 """Constructs requests for Buildbucket to trigger tryjobs."""
Edward Lemurf0faf482019-09-25 20:40:17 +0000359 gerrit_changes = [changelist.GetGerritChange(patchset)]
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +0000360 shared_properties = {
361 'category': options.ensure_value('category', 'git_cl_try')
362 }
363 if options.ensure_value('clobber', False):
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000364 shared_properties['clobber'] = True
365 shared_properties.update(_get_properties_from_options(options) or {})
366
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +0000367 shared_tags = [{'key': 'user_agent', 'value': 'git_cl_try'}]
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +0000368 if options.ensure_value('retry_failed', False):
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +0000369 shared_tags.append({'key': 'retry_failed',
370 'value': '1'})
371
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000372 requests = []
Edward Lemur45768512020-03-02 19:03:14 +0000373 for (project, bucket, builder) in jobs:
374 properties = shared_properties.copy()
375 if 'presubmit' in builder.lower():
376 properties['dry_run'] = 'true'
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000377
Edward Lemur45768512020-03-02 19:03:14 +0000378 requests.append({
379 'scheduleBuild': {
380 'requestId': str(uuid.uuid4()),
381 'builder': {
382 'project': getattr(options, 'project', None) or project,
383 'bucket': bucket,
384 'builder': builder,
385 },
386 'gerritChanges': gerrit_changes,
387 'properties': properties,
388 'tags': [
389 {'key': 'builder', 'value': builder},
390 ] + shared_tags,
391 }
392 })
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000393
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +0000394 if options.ensure_value('revision', None):
Josip Sokcevic9011a5b2021-02-12 18:59:44 +0000395 remote, remote_branch = changelist.GetRemoteBranch()
Edward Lemur45768512020-03-02 19:03:14 +0000396 requests[-1]['scheduleBuild']['gitilesCommit'] = {
397 'host': gerrit_changes[0]['host'],
398 'project': gerrit_changes[0]['project'],
Josip Sokcevic9011a5b2021-02-12 18:59:44 +0000399 'id': options.revision,
400 'ref': GetTargetRef(remote, remote_branch, None)
Edward Lemur45768512020-03-02 19:03:14 +0000401 }
Anthony Polito1a5fe232020-01-24 23:17:52 +0000402
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +0000403 return requests
kjellander@chromium.org44424542015-06-02 18:35:29 +0000404
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000405
Quinten Yearsley777660f2020-03-04 23:37:06 +0000406def _fetch_tryjobs(changelist, buildbucket_host, patchset=None):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000407 """Fetches tryjobs from buildbucket.
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000408
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000409 Returns list of buildbucket.v2.Build with the try jobs for the changelist.
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000410 """
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +0000411 fields = ['id', 'builder', 'status', 'createTime', 'tags']
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000412 request = {
413 'predicate': {
414 'gerritChanges': [changelist.GetGerritChange(patchset)],
415 },
416 'fields': ','.join('builds.*.' + field for field in fields),
417 }
tandrii221ab252016-10-06 08:12:04 -0700418
Edward Lemur5b929a42019-10-21 17:57:39 +0000419 authenticator = auth.Authenticator()
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000420 if authenticator.has_cached_credentials():
421 http = authenticator.authorize(httplib2.Http())
422 else:
vapiera7fbd5a2016-06-16 09:17:49 -0700423 print('Warning: Some results might be missing because %s' %
424 # Get the message on how to login.
Andrii Shyshkalov2517afd2021-01-19 17:07:43 +0000425 (str(auth.LoginRequiredError()),))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000426 http = httplib2.Http()
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000427 http.force_exception_to_status_code = True
428
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000429 response = _call_buildbucket(http, buildbucket_host, 'SearchBuilds', request)
430 return response.get('builds', [])
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000431
Edward Lemur45768512020-03-02 19:03:14 +0000432
Edward Lemur5b929a42019-10-21 17:57:39 +0000433def _fetch_latest_builds(changelist, buildbucket_host, latest_patchset=None):
Quinten Yearsley983111f2019-09-26 17:18:48 +0000434 """Fetches builds from the latest patchset that has builds (within
435 the last few patchsets).
436
437 Args:
Quinten Yearsley983111f2019-09-26 17:18:48 +0000438 changelist (Changelist): The CL to fetch builds for
439 buildbucket_host (str): Buildbucket host, e.g. "cr-buildbucket.appspot.com"
Andrii Shyshkalov1ad58112019-10-08 01:46:14 +0000440 lastest_patchset(int|NoneType): the patchset to start fetching builds from.
441 If None (default), starts with the latest available patchset.
Quinten Yearsley983111f2019-09-26 17:18:48 +0000442 Returns:
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000443 A tuple (builds, patchset) where builds is a list of buildbucket.v2.Build,
444 and patchset is the patchset number where those builds came from.
Quinten Yearsley983111f2019-09-26 17:18:48 +0000445 """
446 assert buildbucket_host
447 assert changelist.GetIssue(), 'CL must be uploaded first'
448 assert changelist.GetCodereviewServer(), 'CL must be uploaded first'
Andrii Shyshkalov1ad58112019-10-08 01:46:14 +0000449 if latest_patchset is None:
450 assert changelist.GetMostRecentPatchset()
451 ps = changelist.GetMostRecentPatchset()
452 else:
453 assert latest_patchset > 0, latest_patchset
454 ps = latest_patchset
455
Quinten Yearsley983111f2019-09-26 17:18:48 +0000456 min_ps = max(1, ps - 5)
457 while ps >= min_ps:
Quinten Yearsley777660f2020-03-04 23:37:06 +0000458 builds = _fetch_tryjobs(changelist, buildbucket_host, patchset=ps)
Quinten Yearsley983111f2019-09-26 17:18:48 +0000459 if len(builds):
460 return builds, ps
461 ps -= 1
462 return [], 0
463
464
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +0000465def _filter_failed_for_retry(all_builds):
466 """Returns a list of buckets/builders that are worth retrying.
Quinten Yearsley983111f2019-09-26 17:18:48 +0000467
468 Args:
Quinten Yearsley777660f2020-03-04 23:37:06 +0000469 all_builds (list): Builds, in the format returned by _fetch_tryjobs,
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000470 i.e. a list of buildbucket.v2.Builds which includes status and builder
471 info.
Quinten Yearsley983111f2019-09-26 17:18:48 +0000472
473 Returns:
Edward Lemur45768512020-03-02 19:03:14 +0000474 A dict {(proj, bucket): [builders]}. This is the same format accepted by
Quinten Yearsley777660f2020-03-04 23:37:06 +0000475 _trigger_tryjobs.
Quinten Yearsley983111f2019-09-26 17:18:48 +0000476 """
Edward Lemur45768512020-03-02 19:03:14 +0000477 grouped = {}
478 for build in all_builds:
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +0000479 builder = build['builder']
Edward Lemur45768512020-03-02 19:03:14 +0000480 key = (builder['project'], builder['bucket'], builder['builder'])
481 grouped.setdefault(key, []).append(build)
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +0000482
Edward Lemur45768512020-03-02 19:03:14 +0000483 jobs = []
484 for (project, bucket, builder), builds in grouped.items():
485 if 'triggered' in builder:
486 print('WARNING: Not scheduling %s. Triggered bots require an initial job '
487 'from a parent. Please schedule a manual job for the parent '
488 'instead.')
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +0000489 continue
490 if any(b['status'] in ('STARTED', 'SCHEDULED') for b in builds):
491 # Don't retry if any are running.
492 continue
Edward Lemur45768512020-03-02 19:03:14 +0000493 # If builder had several builds, retry only if the last one failed.
494 # This is a bit different from CQ, which would re-use *any* SUCCESS-full
495 # build, but in case of retrying failed jobs retrying a flaky one makes
496 # sense.
497 builds = sorted(builds, key=lambda b: b['createTime'])
498 if builds[-1]['status'] not in ('FAILURE', 'INFRA_FAILURE'):
499 continue
500 # Don't retry experimental build previously triggered by CQ.
501 if any(t['key'] == 'cq_experimental' and t['value'] == 'true'
502 for t in builds[-1]['tags']):
503 continue
504 jobs.append((project, bucket, builder))
505
506 # Sort the jobs to make testing easier.
507 return sorted(jobs)
Quinten Yearsley983111f2019-09-26 17:18:48 +0000508
509
Quinten Yearsley777660f2020-03-04 23:37:06 +0000510def _print_tryjobs(options, builds):
511 """Prints nicely result of _fetch_tryjobs."""
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000512 if not builds:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000513 print('No tryjobs scheduled.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000514 return
515
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000516 longest_builder = max(len(b['builder']['builder']) for b in builds)
517 name_fmt = '{builder:<%d}' % longest_builder
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000518 if options.print_master:
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000519 longest_bucket = max(len(b['builder']['bucket']) for b in builds)
520 name_fmt = ('{bucket:>%d} ' % longest_bucket) + name_fmt
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000521
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000522 builds_by_status = {}
523 for b in builds:
524 builds_by_status.setdefault(b['status'], []).append({
525 'id': b['id'],
526 'name': name_fmt.format(
527 builder=b['builder']['builder'], bucket=b['builder']['bucket']),
528 })
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000529
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000530 sort_key = lambda b: (b['name'], b['id'])
531
532 def print_builds(title, builds, fmt=None, color=None):
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000533 """Pop matching builds from `builds` dict and print them."""
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000534 if not builds:
535 return
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000536
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000537 fmt = fmt or '{name} https://ci.chromium.org/b/{id}'
tandrii@chromium.org6cf98c82016-03-15 11:56:00 +0000538 if not options.color or color is None:
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000539 colorize = lambda x: x
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000540 else:
541 colorize = lambda x: '%s%s%s' % (color, x, Fore.RESET)
542
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000543 print(colorize(title))
544 for b in sorted(builds, key=sort_key):
545 print(' ', colorize(fmt.format(**b)))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000546
547 total = len(builds)
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000548 print_builds(
549 'Successes:', builds_by_status.pop('SUCCESS', []), color=Fore.GREEN)
550 print_builds(
551 'Infra Failures:', builds_by_status.pop('INFRA_FAILURE', []),
552 color=Fore.MAGENTA)
553 print_builds('Failures:', builds_by_status.pop('FAILURE', []), color=Fore.RED)
554 print_builds('Canceled:', builds_by_status.pop('CANCELED', []), fmt='{name}',
555 color=Fore.MAGENTA)
Andrii Shyshkalov792630c2020-10-19 16:47:44 +0000556 print_builds('Started:', builds_by_status.pop('STARTED', []),
557 color=Fore.YELLOW)
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000558 print_builds(
559 'Scheduled:', builds_by_status.pop('SCHEDULED', []), fmt='{name} id={id}')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000560 # The last section is just in case buildbucket API changes OR there is a bug.
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000561 print_builds(
562 'Other:', sum(builds_by_status.values(), []), fmt='{name} id={id}')
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000563 print('Total: %d tryjobs' % total)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000564
565
Aiden Bennerc08566e2018-10-03 17:52:42 +0000566def _ComputeDiffLineRanges(files, upstream_commit):
567 """Gets the changed line ranges for each file since upstream_commit.
568
569 Parses a git diff on provided files and returns a dict that maps a file name
570 to an ordered list of range tuples in the form (start_line, count).
571 Ranges are in the same format as a git diff.
572 """
573 # If files is empty then diff_output will be a full diff.
574 if len(files) == 0:
575 return {}
576
Aiden Benner6c18a1a2018-11-23 20:18:23 +0000577 # Take the git diff and find the line ranges where there are changes.
Jamie Madill3671a6a2019-10-24 15:13:21 +0000578 diff_cmd = BuildGitDiffCmd('-U0', upstream_commit, files, allow_prefix=True)
Aiden Bennerc08566e2018-10-03 17:52:42 +0000579 diff_output = RunGit(diff_cmd)
580
581 pattern = r'(?:^diff --git a/(?:.*) b/(.*))|(?:^@@.*\+(.*) @@)'
582 # 2 capture groups
583 # 0 == fname of diff file
584 # 1 == 'diff_start,diff_count' or 'diff_start'
585 # will match each of
586 # diff --git a/foo.foo b/foo.py
587 # @@ -12,2 +14,3 @@
588 # @@ -12,2 +17 @@
589 # running re.findall on the above string with pattern will give
590 # [('foo.py', ''), ('', '14,3'), ('', '17')]
591
592 curr_file = None
593 line_diffs = {}
594 for match in re.findall(pattern, diff_output, flags=re.MULTILINE):
595 if match[0] != '':
596 # Will match the second filename in diff --git a/a.py b/b.py.
597 curr_file = match[0]
598 line_diffs[curr_file] = []
599 else:
600 # Matches +14,3
601 if ',' in match[1]:
602 diff_start, diff_count = match[1].split(',')
603 else:
604 # Single line changes are of the form +12 instead of +12,1.
605 diff_start = match[1]
606 diff_count = 1
607
608 diff_start = int(diff_start)
609 diff_count = int(diff_count)
610
611 # If diff_count == 0 this is a removal we can ignore.
612 line_diffs[curr_file].append((diff_start, diff_count))
613
614 return line_diffs
615
616
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000617def _FindYapfConfigFile(fpath, yapf_config_cache, top_dir=None):
Aiden Bennerc08566e2018-10-03 17:52:42 +0000618 """Checks if a yapf file is in any parent directory of fpath until top_dir.
619
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000620 Recursively checks parent directories to find yapf file and if no yapf file
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000621 is found returns None. Uses yapf_config_cache as a cache for previously found
622 configs.
Aiden Bennerc08566e2018-10-03 17:52:42 +0000623 """
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000624 fpath = os.path.abspath(fpath)
Aiden Bennerc08566e2018-10-03 17:52:42 +0000625 # Return result if we've already computed it.
626 if fpath in yapf_config_cache:
627 return yapf_config_cache[fpath]
628
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000629 parent_dir = os.path.dirname(fpath)
630 if os.path.isfile(fpath):
631 ret = _FindYapfConfigFile(parent_dir, yapf_config_cache, top_dir)
Aiden Bennerc08566e2018-10-03 17:52:42 +0000632 else:
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000633 # Otherwise fpath is a directory
634 yapf_file = os.path.join(fpath, YAPF_CONFIG_FILENAME)
635 if os.path.isfile(yapf_file):
636 ret = yapf_file
637 elif fpath == top_dir or parent_dir == fpath:
638 # If we're at the top level directory, or if we're at root
639 # there is no provided style.
640 ret = None
641 else:
642 # Otherwise recurse on the current directory.
643 ret = _FindYapfConfigFile(parent_dir, yapf_config_cache, top_dir)
Aiden Bennerc08566e2018-10-03 17:52:42 +0000644 yapf_config_cache[fpath] = ret
645 return ret
646
647
Brian Sheedyb4307d52019-12-02 19:18:17 +0000648def _GetYapfIgnorePatterns(top_dir):
649 """Returns all patterns in the .yapfignore file.
Brian Sheedy59b06a82019-10-14 17:03:29 +0000650
651 yapf is supposed to handle the ignoring of files listed in .yapfignore itself,
652 but this functionality appears to break when explicitly passing files to
653 yapf for formatting. According to
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000654 https://github.com/google/yapf/blob/HEAD/README.rst#excluding-files-from-formatting-yapfignore,
Brian Sheedy59b06a82019-10-14 17:03:29 +0000655 the .yapfignore file should be in the directory that yapf is invoked from,
656 which we assume to be the top level directory in this case.
657
658 Args:
659 top_dir: The top level directory for the repository being formatted.
660
661 Returns:
Brian Sheedyb4307d52019-12-02 19:18:17 +0000662 A set of all fnmatch patterns to be ignored.
Brian Sheedy59b06a82019-10-14 17:03:29 +0000663 """
664 yapfignore_file = os.path.join(top_dir, '.yapfignore')
Brian Sheedyb4307d52019-12-02 19:18:17 +0000665 ignore_patterns = set()
Brian Sheedy59b06a82019-10-14 17:03:29 +0000666 if not os.path.exists(yapfignore_file):
Brian Sheedyb4307d52019-12-02 19:18:17 +0000667 return ignore_patterns
Brian Sheedy59b06a82019-10-14 17:03:29 +0000668
Anthony Politoc64e3902021-04-30 21:55:25 +0000669 for line in gclient_utils.FileRead(yapfignore_file).split('\n'):
670 stripped_line = line.strip()
671 # Comments and blank lines should be ignored.
672 if stripped_line.startswith('#') or stripped_line == '':
673 continue
674 ignore_patterns.add(stripped_line)
Brian Sheedyb4307d52019-12-02 19:18:17 +0000675 return ignore_patterns
676
677
678def _FilterYapfIgnoredFiles(filepaths, patterns):
679 """Filters out any filepaths that match any of the given patterns.
680
681 Args:
682 filepaths: An iterable of strings containing filepaths to filter.
683 patterns: An iterable of strings containing fnmatch patterns to filter on.
684
685 Returns:
686 A list of strings containing all the elements of |filepaths| that did not
687 match any of the patterns in |patterns|.
688 """
689 # Not inlined so that tests can use the same implementation.
690 return [f for f in filepaths
691 if not any(fnmatch.fnmatch(f, p) for p in patterns)]
Brian Sheedy59b06a82019-10-14 17:03:29 +0000692
693
Aaron Gable13101a62018-02-09 13:20:41 -0800694def print_stats(args):
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000695 """Prints statistics about the change to the user."""
696 # --no-ext-diff is broken in some versions of Git, so try to work around
697 # this by overriding the environment (but there is still a problem if the
698 # git config key "diff.external" is used).
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000699 env = GetNoGitPagerEnv()
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000700 if 'GIT_EXTERNAL_DIFF' in env:
701 del env['GIT_EXTERNAL_DIFF']
iannucci@chromium.org79540052012-10-19 23:15:26 +0000702
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000703 return subprocess2.call(
Aaron Gable13101a62018-02-09 13:20:41 -0800704 ['git', 'diff', '--no-ext-diff', '--stat', '-l100000', '-C50'] + args,
Edward Lemur0db01f02019-11-12 22:01:51 +0000705 env=env)
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000706
707
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000708class BuildbucketResponseException(Exception):
709 pass
710
711
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000712class Settings(object):
713 def __init__(self):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000714 self.cc = None
thestig@chromium.org7a54e812014-02-11 19:57:22 +0000715 self.root = None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000716 self.tree_status_url = None
717 self.viewvc_url = None
718 self.updated = False
ukai@chromium.orge8077812012-02-03 03:41:46 +0000719 self.is_gerrit = None
bauerb@chromium.org54b400c2016-01-14 10:08:25 +0000720 self.squash_gerrit_uploads = None
tandrii@chromium.org28253532016-04-14 13:46:56 +0000721 self.gerrit_skip_ensure_authenticated = None
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000722 self.git_editor = None
Jamie Madilldc4d19e2019-10-24 21:50:02 +0000723 self.format_full_by_default = None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000724
Edward Lemur26964072020-02-19 19:18:51 +0000725 def _LazyUpdateIfNeeded(self):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000726 """Updates the settings from a codereview.settings file, if available."""
Edward Lemur26964072020-02-19 19:18:51 +0000727 if self.updated:
728 return
pgervais@chromium.org87884cc2014-01-03 22:23:41 +0000729
Edward Lemur26964072020-02-19 19:18:51 +0000730 # The only value that actually changes the behavior is
731 # autoupdate = "false". Everything else means "true".
732 autoupdate = (
733 scm.GIT.GetConfig(self.GetRoot(), 'rietveld.autoupdate', '').lower())
734
735 cr_settings_file = FindCodereviewSettingsFile()
736 if autoupdate != 'false' and cr_settings_file:
737 LoadCodereviewSettingsFromFile(cr_settings_file)
738 cr_settings_file.close()
739
740 self.updated = True
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000741
thestig@chromium.org7a54e812014-02-11 19:57:22 +0000742 @staticmethod
743 def GetRelativeRoot():
Edward Lesmes50da7702020-03-30 19:23:43 +0000744 return scm.GIT.GetCheckoutRoot('.')
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000745
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000746 def GetRoot(self):
thestig@chromium.org7a54e812014-02-11 19:57:22 +0000747 if self.root is None:
748 self.root = os.path.abspath(self.GetRelativeRoot())
749 return self.root
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000750
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000751 def GetTreeStatusUrl(self, error_ok=False):
752 if not self.tree_status_url:
Edward Lemur26964072020-02-19 19:18:51 +0000753 self.tree_status_url = self._GetConfig('rietveld.tree-status-url')
754 if self.tree_status_url is None and not error_ok:
755 DieWithError(
756 'You must configure your tree status URL by running '
757 '"git cl config".')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000758 return self.tree_status_url
759
760 def GetViewVCUrl(self):
761 if not self.viewvc_url:
Edward Lemur26964072020-02-19 19:18:51 +0000762 self.viewvc_url = self._GetConfig('rietveld.viewvc-url')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000763 return self.viewvc_url
764
rmistry@google.com90752582014-01-14 21:04:50 +0000765 def GetBugPrefix(self):
Edward Lemur26964072020-02-19 19:18:51 +0000766 return self._GetConfig('rietveld.bug-prefix')
rmistry@google.com78948ed2015-07-08 23:09:57 +0000767
rmistry@google.com5626a922015-02-26 14:03:30 +0000768 def GetRunPostUploadHook(self):
Edward Lemur61ea3072018-12-01 00:34:36 +0000769 run_post_upload_hook = self._GetConfig(
Edward Lemur26964072020-02-19 19:18:51 +0000770 'rietveld.run-post-upload-hook')
rmistry@google.com5626a922015-02-26 14:03:30 +0000771 return run_post_upload_hook == "True"
772
bauerb@chromium.orgae6df352011-04-06 17:40:39 +0000773 def GetDefaultCCList(self):
Edward Lemur26964072020-02-19 19:18:51 +0000774 return self._GetConfig('rietveld.cc')
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000775
bauerb@chromium.org54b400c2016-01-14 10:08:25 +0000776 def GetSquashGerritUploads(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000777 """Returns True if uploads to Gerrit should be squashed by default."""
bauerb@chromium.org54b400c2016-01-14 10:08:25 +0000778 if self.squash_gerrit_uploads is None:
Edward Lesmes4de54132020-05-05 19:41:33 +0000779 self.squash_gerrit_uploads = self.GetSquashGerritUploadsOverride()
780 if self.squash_gerrit_uploads is None:
Edward Lemur26964072020-02-19 19:18:51 +0000781 # Default is squash now (http://crbug.com/611892#c23).
782 self.squash_gerrit_uploads = self._GetConfig(
783 'gerrit.squash-uploads').lower() != 'false'
bauerb@chromium.org54b400c2016-01-14 10:08:25 +0000784 return self.squash_gerrit_uploads
785
Edward Lesmes4de54132020-05-05 19:41:33 +0000786 def GetSquashGerritUploadsOverride(self):
787 """Return True or False if codereview.settings should be overridden.
788
789 Returns None if no override has been defined.
790 """
791 # See also http://crbug.com/611892#c23
792 result = self._GetConfig('gerrit.override-squash-uploads').lower()
793 if result == 'true':
794 return True
795 if result == 'false':
796 return False
797 return None
798
tandrii@chromium.org28253532016-04-14 13:46:56 +0000799 def GetGerritSkipEnsureAuthenticated(self):
800 """Return True if EnsureAuthenticated should not be done for Gerrit
801 uploads."""
802 if self.gerrit_skip_ensure_authenticated is None:
Edward Lemur26964072020-02-19 19:18:51 +0000803 self.gerrit_skip_ensure_authenticated = self._GetConfig(
804 'gerrit.skip-ensure-authenticated').lower() == 'true'
tandrii@chromium.org28253532016-04-14 13:46:56 +0000805 return self.gerrit_skip_ensure_authenticated
806
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000807 def GetGitEditor(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000808 """Returns the editor specified in the git config, or None if none is."""
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000809 if self.git_editor is None:
Raul Tambre5a525872019-02-12 19:08:08 +0000810 # Git requires single quotes for paths with spaces. We need to replace
811 # them with double quotes for Windows to treat such paths as a single
812 # path.
Edward Lemur26964072020-02-19 19:18:51 +0000813 self.git_editor = self._GetConfig('core.editor').replace('\'', '"')
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000814 return self.git_editor or None
815
thestig@chromium.org44202a22014-03-11 19:22:18 +0000816 def GetLintRegex(self):
Edward Lemur26964072020-02-19 19:18:51 +0000817 return self._GetConfig('rietveld.cpplint-regex', DEFAULT_LINT_REGEX)
thestig@chromium.org44202a22014-03-11 19:22:18 +0000818
819 def GetLintIgnoreRegex(self):
Edward Lemur26964072020-02-19 19:18:51 +0000820 return self._GetConfig(
821 'rietveld.cpplint-ignore-regex', DEFAULT_LINT_IGNORE_REGEX)
thestig@chromium.org44202a22014-03-11 19:22:18 +0000822
Jamie Madilldc4d19e2019-10-24 21:50:02 +0000823 def GetFormatFullByDefault(self):
824 if self.format_full_by_default is None:
825 result = (
826 RunGit(['config', '--bool', 'rietveld.format-full-by-default'],
827 error_ok=True).strip())
828 self.format_full_by_default = (result == 'true')
829 return self.format_full_by_default
830
Edward Lemur26964072020-02-19 19:18:51 +0000831 def _GetConfig(self, key, default=''):
832 self._LazyUpdateIfNeeded()
833 return scm.GIT.GetConfig(self.GetRoot(), key, default)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000834
835
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +0000836class _CQState(object):
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +0000837 """Enum for states of CL with respect to CQ."""
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +0000838 NONE = 'none'
839 DRY_RUN = 'dry_run'
840 COMMIT = 'commit'
841
842 ALL_STATES = [NONE, DRY_RUN, COMMIT]
843
844
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000845class _ParsedIssueNumberArgument(object):
Edward Lemurf38bc172019-09-03 21:02:13 +0000846 def __init__(self, issue=None, patchset=None, hostname=None):
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000847 self.issue = issue
848 self.patchset = patchset
849 self.hostname = hostname
850
851 @property
852 def valid(self):
853 return self.issue is not None
854
855
Edward Lemurf38bc172019-09-03 21:02:13 +0000856def ParseIssueNumberArgument(arg):
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000857 """Parses the issue argument and returns _ParsedIssueNumberArgument."""
858 fail_result = _ParsedIssueNumberArgument()
859
Edward Lemur678a6842019-10-03 22:25:05 +0000860 if isinstance(arg, int):
861 return _ParsedIssueNumberArgument(issue=arg)
862 if not isinstance(arg, basestring):
863 return fail_result
864
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000865 if arg.isdigit():
Edward Lemurf38bc172019-09-03 21:02:13 +0000866 return _ParsedIssueNumberArgument(issue=int(arg))
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000867 if not arg.startswith('http'):
868 return fail_result
Aaron Gableaee6c852017-06-26 12:49:01 -0700869
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000870 url = gclient_utils.UpgradeToHttps(arg)
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000871 for gerrit_url, short_url in _KNOWN_GERRIT_TO_SHORT_URLS.items():
872 if url.startswith(short_url):
873 url = gerrit_url + url[len(short_url):]
874 break
875
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000876 try:
Edward Lemur79d4f992019-11-11 23:49:02 +0000877 parsed_url = urllib.parse.urlparse(url)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000878 except ValueError:
879 return fail_result
Andrii Shyshkalov28d840e2017-04-10 15:45:09 +0200880
Edward Lemur678a6842019-10-03 22:25:05 +0000881 # Gerrit's new UI is https://domain/c/project/+/<issue_number>[/[patchset]]
882 # But old GWT UI is https://domain/#/c/project/+/<issue_number>[/[patchset]]
883 # Short urls like https://domain/<issue_number> can be used, but don't allow
884 # specifying the patchset (you'd 404), but we allow that here.
885 if parsed_url.path == '/':
886 part = parsed_url.fragment
887 else:
888 part = parsed_url.path
889
890 match = re.match(
891 r'(/c(/.*/\+)?)?/(?P<issue>\d+)(/(?P<patchset>\d+)?/?)?$', part)
892 if not match:
893 return fail_result
894
895 issue = int(match.group('issue'))
896 patchset = match.group('patchset')
897 return _ParsedIssueNumberArgument(
898 issue=issue,
899 patchset=int(patchset) if patchset else None,
900 hostname=parsed_url.netloc)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000901
902
Andrii Shyshkalovb07575f2018-10-16 06:16:21 +0000903def _create_description_from_log(args):
904 """Pulls out the commit log to use as a base for the CL description."""
905 log_args = []
906 if len(args) == 1 and not args[0].endswith('.'):
907 log_args = [args[0] + '..']
908 elif len(args) == 1 and args[0].endswith('...'):
909 log_args = [args[0][:-1]]
910 elif len(args) == 2:
911 log_args = [args[0] + '..' + args[1]]
912 else:
913 log_args = args[:] # Hope for the best!
Manh Nguyene3644862020-08-05 18:25:46 +0000914 return RunGit(['log', '--pretty=format:%B%n'] + log_args)
Andrii Shyshkalovb07575f2018-10-16 06:16:21 +0000915
916
Aaron Gablea45ee112016-11-22 15:14:38 -0800917class GerritChangeNotExists(Exception):
tandriic2405f52016-10-10 08:13:15 -0700918 def __init__(self, issue, url):
919 self.issue = issue
920 self.url = url
Aaron Gablea45ee112016-11-22 15:14:38 -0800921 super(GerritChangeNotExists, self).__init__()
tandriic2405f52016-10-10 08:13:15 -0700922
923 def __str__(self):
Aaron Gablea45ee112016-11-22 15:14:38 -0800924 return 'change %s at %s does not exist or you have no access to it' % (
tandriic2405f52016-10-10 08:13:15 -0700925 self.issue, self.url)
926
927
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +0100928_CommentSummary = collections.namedtuple(
Quinten Yearsley0e617c02019-02-20 00:37:03 +0000929 '_CommentSummary', ['date', 'message', 'sender', 'autogenerated',
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +0100930 # TODO(tandrii): these two aren't known in Gerrit.
931 'approval', 'disapproval'])
932
933
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000934class Changelist(object):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +0000935 """Changelist works with one changelist in local branch.
936
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +0000937 Notes:
938 * Not safe for concurrent multi-{thread,process} use.
939 * Caches values from current branch. Therefore, re-use after branch change
tandrii5d48c322016-08-18 16:19:37 -0700940 with great care.
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +0000941 """
942
Sigurd Schneider9abde8c2020-11-17 08:44:52 +0000943 def __init__(self,
944 branchref=None,
945 issue=None,
946 codereview_host=None,
947 commit_date=None):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +0000948 """Create a new ChangeList instance.
949
Edward Lemurf38bc172019-09-03 21:02:13 +0000950 **kwargs will be passed directly to Gerrit implementation.
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +0000951 """
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000952 # Poke settings so we get the "configure your server" message if necessary.
maruel@chromium.org379d07a2011-11-30 14:58:10 +0000953 global settings
954 if not settings:
955 # Happens when git_cl.py is used as a utility library.
956 settings = Settings()
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +0000957
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000958 self.branchref = branchref
959 if self.branchref:
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +0000960 assert branchref.startswith('refs/heads/')
Edward Lemur85153282020-02-14 22:06:29 +0000961 self.branch = scm.GIT.ShortBranchName(self.branchref)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000962 else:
963 self.branch = None
Sigurd Schneider9abde8c2020-11-17 08:44:52 +0000964 self.commit_date = commit_date
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000965 self.upstream_branch = None
maruel@chromium.org1033efd2013-07-23 23:25:09 +0000966 self.lookedup_issue = False
967 self.issue = issue or None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000968 self.description = None
maruel@chromium.org1033efd2013-07-23 23:25:09 +0000969 self.lookedup_patchset = False
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000970 self.patchset = None
bauerb@chromium.orgae6df352011-04-06 17:40:39 +0000971 self.cc = None
Daniel Cheng7227d212017-11-17 08:12:37 -0800972 self.more_cc = []
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +0000973 self._remote = None
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +0000974 self._cached_remote_url = (False, None) # (is_cached, value)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +0000975
Edward Lemur125d60a2019-09-13 18:25:41 +0000976 # Lazily cached values.
977 self._gerrit_host = None # e.g. chromium-review.googlesource.com
978 self._gerrit_server = None # e.g. https://chromium-review.googlesource.com
Edward Lesmese1576912021-02-16 21:53:34 +0000979 self._owners_client = None
Edward Lemur125d60a2019-09-13 18:25:41 +0000980 # Map from change number (issue) to its detail cache.
981 self._detail_cache = {}
982
983 if codereview_host is not None:
984 assert not codereview_host.startswith('https://'), codereview_host
985 self._gerrit_host = codereview_host
986 self._gerrit_server = 'https://%s' % codereview_host
bauerb@chromium.orgae6df352011-04-06 17:40:39 +0000987
Edward Lesmese1576912021-02-16 21:53:34 +0000988 @property
989 def owners_client(self):
990 if self._owners_client is None:
991 remote, remote_branch = self.GetRemoteBranch()
992 branch = GetTargetRef(remote, remote_branch, None)
993 self._owners_client = owners_client.GetCodeOwnersClient(
994 root=settings.GetRoot(),
Edward Lesmes1eaaab52021-03-02 23:52:54 +0000995 upstream=self.GetCommonAncestorWithUpstream(),
Edward Lesmese1576912021-02-16 21:53:34 +0000996 host=self.GetGerritHost(),
997 project=self.GetGerritProject(),
998 branch=branch)
999 return self._owners_client
1000
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001001 def GetCCList(self):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001002 """Returns the users cc'd on this CL.
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001003
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001004 The return value is a string suitable for passing to git cl with the --cc
1005 flag.
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001006 """
1007 if self.cc is None:
tyoshino@chromium.org99918ab2013-09-30 06:17:28 +00001008 base_cc = settings.GetDefaultCCList()
Daniel Cheng7227d212017-11-17 08:12:37 -08001009 more_cc = ','.join(self.more_cc)
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001010 self.cc = ','.join(filter(None, (base_cc, more_cc))) or ''
1011 return self.cc
1012
Daniel Cheng7227d212017-11-17 08:12:37 -08001013 def ExtendCC(self, more_cc):
1014 """Extends the list of users to cc on this CL based on the changed files."""
1015 self.more_cc.extend(more_cc)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001016
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00001017 def GetCommitDate(self):
1018 """Returns the commit date as provided in the constructor"""
1019 return self.commit_date
1020
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001021 def GetBranch(self):
Josip Sokcevicc39ab992020-09-24 20:09:15 +00001022 """Returns the short branch name, e.g. 'main'."""
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001023 if not self.branch:
Edward Lemur85153282020-02-14 22:06:29 +00001024 branchref = scm.GIT.GetBranchRef(settings.GetRoot())
szager@chromium.orgd62c61f2014-10-20 22:33:21 +00001025 if not branchref:
1026 return None
1027 self.branchref = branchref
Edward Lemur85153282020-02-14 22:06:29 +00001028 self.branch = scm.GIT.ShortBranchName(self.branchref)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001029 return self.branch
1030
1031 def GetBranchRef(self):
Josip Sokcevicc39ab992020-09-24 20:09:15 +00001032 """Returns the full branch name, e.g. 'refs/heads/main'."""
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001033 self.GetBranch() # Poke the lazy loader.
1034 return self.branchref
1035
Edward Lemur85153282020-02-14 22:06:29 +00001036 def _GitGetBranchConfigValue(self, key, default=None):
1037 return scm.GIT.GetBranchConfig(
1038 settings.GetRoot(), self.GetBranch(), key, default)
tandrii5d48c322016-08-18 16:19:37 -07001039
Edward Lemur85153282020-02-14 22:06:29 +00001040 def _GitSetBranchConfigValue(self, key, value):
1041 action = 'set %s to %r' % (key, value)
1042 if not value:
1043 action = 'unset %s' % key
1044 assert self.GetBranch(), 'a branch is needed to ' + action
1045 return scm.GIT.SetBranchConfig(
1046 settings.GetRoot(), self.GetBranch(), key, value)
tandrii5d48c322016-08-18 16:19:37 -07001047
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001048 @staticmethod
1049 def FetchUpstreamTuple(branch):
pgervais@chromium.orgd6617f32013-11-19 00:34:54 +00001050 """Returns a tuple containing remote and remote ref,
Josip Sokcevicc39ab992020-09-24 20:09:15 +00001051 e.g. 'origin', 'refs/heads/main'
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001052 """
Edward Lemur15a9b8c2020-02-13 00:52:30 +00001053 remote, upstream_branch = scm.GIT.FetchUpstreamTuple(
1054 settings.GetRoot(), branch)
1055 if not remote or not upstream_branch:
1056 DieWithError(
1057 'Unable to determine default branch to diff against.\n'
Josip Sokcevicb038f722021-01-06 18:28:11 +00001058 'Verify this branch is set up to track another \n'
1059 '(via the --track argument to "git checkout -b ..."). \n'
1060 'or pass complete "git diff"-style arguments if supported, like\n'
1061 ' git cl upload origin/main\n')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001062
1063 return remote, upstream_branch
1064
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00001065 def GetCommonAncestorWithUpstream(self):
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +00001066 upstream_branch = self.GetUpstreamBranch()
Edward Lesmes50da7702020-03-30 19:23:43 +00001067 if not scm.GIT.IsValidRevision(settings.GetRoot(), upstream_branch):
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +00001068 DieWithError('The upstream for the current branch (%s) does not exist '
1069 'anymore.\nPlease fix it and try again.' % self.GetBranch())
iannucci@chromium.org9e849272014-04-04 00:31:55 +00001070 return git_common.get_or_create_merge_base(self.GetBranch(),
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +00001071 upstream_branch)
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00001072
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001073 def GetUpstreamBranch(self):
1074 if self.upstream_branch is None:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001075 remote, upstream_branch = self.FetchUpstreamTuple(self.GetBranch())
Raul Tambrefe1dbe12019-05-02 04:43:57 +00001076 if remote != '.':
mmoss@chromium.orge7585452014-08-24 01:41:11 +00001077 upstream_branch = upstream_branch.replace('refs/heads/',
1078 'refs/remotes/%s/' % remote)
1079 upstream_branch = upstream_branch.replace('refs/branch-heads/',
1080 'refs/remotes/branch-heads/')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001081 self.upstream_branch = upstream_branch
1082 return self.upstream_branch
1083
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001084 def GetRemoteBranch(self):
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001085 if not self._remote:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001086 remote, branch = None, self.GetBranch()
1087 seen_branches = set()
1088 while branch not in seen_branches:
1089 seen_branches.add(branch)
1090 remote, branch = self.FetchUpstreamTuple(branch)
Edward Lemur85153282020-02-14 22:06:29 +00001091 branch = scm.GIT.ShortBranchName(branch)
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001092 if remote != '.' or branch.startswith('refs/remotes'):
1093 break
1094 else:
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001095 remotes = RunGit(['remote'], error_ok=True).split()
1096 if len(remotes) == 1:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001097 remote, = remotes
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001098 elif 'origin' in remotes:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001099 remote = 'origin'
Gavin Make6a62332020-12-04 21:57:10 +00001100 logging.warning('Could not determine which remote this change is '
1101 'associated with, so defaulting to "%s".' %
1102 self._remote)
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001103 else:
Gavin Make6a62332020-12-04 21:57:10 +00001104 logging.warning('Could not determine which remote this change is '
1105 'associated with.')
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001106 branch = 'HEAD'
1107 if branch.startswith('refs/remotes'):
1108 self._remote = (remote, branch)
mmoss@chromium.orge7585452014-08-24 01:41:11 +00001109 elif branch.startswith('refs/branch-heads/'):
1110 self._remote = (remote, branch.replace('refs/', 'refs/remotes/'))
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001111 else:
1112 self._remote = (remote, 'refs/remotes/%s/%s' % (remote, branch))
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001113 return self._remote
1114
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001115 def GetRemoteUrl(self):
1116 """Return the configured remote URL, e.g. 'git://example.org/foo.git/'.
1117
1118 Returns None if there is no remote.
1119 """
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001120 is_cached, value = self._cached_remote_url
1121 if is_cached:
1122 return value
1123
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001124 remote, _ = self.GetRemoteBranch()
Edward Lemur26964072020-02-19 19:18:51 +00001125 url = scm.GIT.GetConfig(settings.GetRoot(), 'remote.%s.url' % remote, '')
dyen@chromium.org2a13d4f2014-06-13 00:06:37 +00001126
Edward Lemur298f2cf2019-02-22 21:40:39 +00001127 # Check if the remote url can be parsed as an URL.
Edward Lemur79d4f992019-11-11 23:49:02 +00001128 host = urllib.parse.urlparse(url).netloc
Edward Lemur298f2cf2019-02-22 21:40:39 +00001129 if host:
1130 self._cached_remote_url = (True, url)
1131 return url
1132
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001133 # If it cannot be parsed as an url, assume it is a local directory,
1134 # probably a git cache.
Edward Lemur298f2cf2019-02-22 21:40:39 +00001135 logging.warning('"%s" doesn\'t appear to point to a git host. '
1136 'Interpreting it as a local directory.', url)
1137 if not os.path.isdir(url):
1138 logging.error(
Josip906bfde2020-01-31 22:38:49 +00001139 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
1140 'but it doesn\'t exist.',
1141 {'remote': remote, 'branch': self.GetBranch(), 'url': url})
Edward Lemur298f2cf2019-02-22 21:40:39 +00001142 return None
1143
1144 cache_path = url
Edward Lemur26964072020-02-19 19:18:51 +00001145 url = scm.GIT.GetConfig(url, 'remote.%s.url' % remote, '')
Edward Lemur298f2cf2019-02-22 21:40:39 +00001146
Edward Lemur79d4f992019-11-11 23:49:02 +00001147 host = urllib.parse.urlparse(url).netloc
Edward Lemur298f2cf2019-02-22 21:40:39 +00001148 if not host:
1149 logging.error(
1150 'Remote "%(remote)s" for branch "%(branch)s" points to '
1151 '"%(cache_path)s", but it is misconfigured.\n'
1152 '"%(cache_path)s" must be a git repo and must have a remote named '
1153 '"%(remote)s" pointing to the git host.', {
1154 'remote': remote,
1155 'cache_path': cache_path,
1156 'branch': self.GetBranch()})
1157 return None
1158
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001159 self._cached_remote_url = (True, url)
dyen@chromium.org2a13d4f2014-06-13 00:06:37 +00001160 return url
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001161
tandrii@chromium.org87985d22016-03-24 17:33:33 +00001162 def GetIssue(self):
maruel@chromium.org52424302012-08-29 15:14:30 +00001163 """Returns the issue number as a int or None if not set."""
tandrii@chromium.org87985d22016-03-24 17:33:33 +00001164 if self.issue is None and not self.lookedup_issue:
Edward Lesmes50da7702020-03-30 19:23:43 +00001165 self.issue = self._GitGetBranchConfigValue(ISSUE_CONFIG_KEY)
Edward Lemur85153282020-02-14 22:06:29 +00001166 if self.issue is not None:
1167 self.issue = int(self.issue)
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001168 self.lookedup_issue = True
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001169 return self.issue
1170
Andrii Shyshkalov1ee78cd2020-03-12 01:31:53 +00001171 def GetIssueURL(self, short=False):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001172 """Get the URL for a particular issue."""
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001173 issue = self.GetIssue()
1174 if not issue:
dbeam@chromium.org015fd3d2013-06-18 19:02:50 +00001175 return None
Andrii Shyshkalov1ee78cd2020-03-12 01:31:53 +00001176 server = self.GetCodereviewServer()
1177 if short:
1178 server = _KNOWN_GERRIT_TO_SHORT_URLS.get(server, server)
1179 return '%s/%s' % (server, issue)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001180
Edward Lemur6c6827c2020-02-06 21:15:18 +00001181 def FetchDescription(self, pretty=False):
1182 assert self.GetIssue(), 'issue is required to query Gerrit'
1183
Edward Lemur9aa1a962020-02-25 00:58:38 +00001184 if self.description is None:
Edward Lemur6c6827c2020-02-06 21:15:18 +00001185 data = self._GetChangeDetail(['CURRENT_REVISION', 'CURRENT_COMMIT'])
1186 current_rev = data['current_revision']
1187 self.description = data['revisions'][current_rev]['commit']['message']
Edward Lemur6c6827c2020-02-06 21:15:18 +00001188
1189 if not pretty:
1190 return self.description
1191
1192 # Set width to 72 columns + 2 space indent.
1193 wrapper = textwrap.TextWrapper(width=74, replace_whitespace=True)
1194 wrapper.initial_indent = wrapper.subsequent_indent = ' '
1195 lines = self.description.splitlines()
1196 return '\n'.join([wrapper.fill(line) for line in lines])
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001197
1198 def GetPatchset(self):
maruel@chromium.org52424302012-08-29 15:14:30 +00001199 """Returns the patchset number as a int or None if not set."""
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001200 if self.patchset is None and not self.lookedup_patchset:
Edward Lesmes50da7702020-03-30 19:23:43 +00001201 self.patchset = self._GitGetBranchConfigValue(PATCHSET_CONFIG_KEY)
Edward Lemur85153282020-02-14 22:06:29 +00001202 if self.patchset is not None:
1203 self.patchset = int(self.patchset)
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001204 self.lookedup_patchset = True
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001205 return self.patchset
1206
Edward Lemur9aa1a962020-02-25 00:58:38 +00001207 def GetAuthor(self):
1208 return scm.GIT.GetConfig(settings.GetRoot(), 'user.email')
1209
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001210 def SetPatchset(self, patchset):
tandrii5d48c322016-08-18 16:19:37 -07001211 """Set this branch's patchset. If patchset=0, clears the patchset."""
1212 assert self.GetBranch()
1213 if not patchset:
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001214 self.patchset = None
tandrii5d48c322016-08-18 16:19:37 -07001215 else:
1216 self.patchset = int(patchset)
Edward Lesmes50da7702020-03-30 19:23:43 +00001217 self._GitSetBranchConfigValue(PATCHSET_CONFIG_KEY, str(self.patchset))
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001218
tandrii@chromium.orga342c922016-03-16 07:08:25 +00001219 def SetIssue(self, issue=None):
tandrii5d48c322016-08-18 16:19:37 -07001220 """Set this branch's issue. If issue isn't given, clears the issue."""
1221 assert self.GetBranch()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001222 if issue:
tandrii5d48c322016-08-18 16:19:37 -07001223 issue = int(issue)
Edward Lesmes50da7702020-03-30 19:23:43 +00001224 self._GitSetBranchConfigValue(ISSUE_CONFIG_KEY, str(issue))
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001225 self.issue = issue
Edward Lemur125d60a2019-09-13 18:25:41 +00001226 codereview_server = self.GetCodereviewServer()
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001227 if codereview_server:
tandrii5d48c322016-08-18 16:19:37 -07001228 self._GitSetBranchConfigValue(
Edward Lesmes50da7702020-03-30 19:23:43 +00001229 CODEREVIEW_SERVER_CONFIG_KEY, codereview_server)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001230 else:
tandrii5d48c322016-08-18 16:19:37 -07001231 # Reset all of these just to be clean.
1232 reset_suffixes = [
1233 'last-upload-hash',
Edward Lesmes50da7702020-03-30 19:23:43 +00001234 ISSUE_CONFIG_KEY,
1235 PATCHSET_CONFIG_KEY,
1236 CODEREVIEW_SERVER_CONFIG_KEY,
1237 'gerritsquashhash',
1238 ]
tandrii5d48c322016-08-18 16:19:37 -07001239 for prop in reset_suffixes:
Edward Lemur85153282020-02-14 22:06:29 +00001240 try:
1241 self._GitSetBranchConfigValue(prop, None)
1242 except subprocess2.CalledProcessError:
1243 pass
Aaron Gableca01e2c2017-07-19 11:16:02 -07001244 msg = RunGit(['log', '-1', '--format=%B']).strip()
1245 if msg and git_footers.get_footer_change_id(msg):
1246 print('WARNING: The change patched into this branch has a Change-Id. '
1247 'Removing it.')
1248 RunGit(['commit', '--amend', '-m',
1249 git_footers.remove_footer(msg, 'Change-Id')])
Edward Lemurf38bc172019-09-03 21:02:13 +00001250 self.lookedup_issue = True
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001251 self.issue = None
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00001252 self.patchset = None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001253
Edward Lemur2c62b332020-03-12 22:12:33 +00001254 def GetAffectedFiles(self, upstream):
maruel@chromium.org2b38e9c2011-10-19 00:04:35 +00001255 try:
Edward Lemur2c62b332020-03-12 22:12:33 +00001256 return [f for _, f in scm.GIT.CaptureStatus(settings.GetRoot(), upstream)]
maruel@chromium.org2b38e9c2011-10-19 00:04:35 +00001257 except subprocess2.CalledProcessError:
1258 DieWithError(
pgervais@chromium.orgd6617f32013-11-19 00:34:54 +00001259 ('\nFailed to diff against upstream branch %s\n\n'
maruel@chromium.org2b38e9c2011-10-19 00:04:35 +00001260 'This branch probably doesn\'t exist anymore. To reset the\n'
1261 'tracking branch, please run\n'
Josip Sokcevicc39ab992020-09-24 20:09:15 +00001262 ' git branch --set-upstream-to origin/main %s\n'
1263 'or replace origin/main with the relevant branch') %
Edward Lemur2c62b332020-03-12 22:12:33 +00001264 (upstream, self.GetBranch()))
bauerb@chromium.org6fb99c62011-04-18 15:57:28 +00001265
dsansomee2d6fd92016-09-08 00:10:47 -07001266 def UpdateDescription(self, description, force=False):
Edward Lemur6c6827c2020-02-06 21:15:18 +00001267 assert self.GetIssue(), 'issue is required to update description'
1268
1269 if gerrit_util.HasPendingChangeEdit(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001270 self.GetGerritHost(), self._GerritChangeIdentifier()):
Edward Lemur6c6827c2020-02-06 21:15:18 +00001271 if not force:
1272 confirm_or_exit(
1273 'The description cannot be modified while the issue has a pending '
1274 'unpublished edit. Either publish the edit in the Gerrit web UI '
1275 'or delete it.\n\n', action='delete the unpublished edit')
1276
1277 gerrit_util.DeletePendingChangeEdit(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001278 self.GetGerritHost(), self._GerritChangeIdentifier())
Edward Lemur6c6827c2020-02-06 21:15:18 +00001279 gerrit_util.SetCommitMessage(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001280 self.GetGerritHost(), self._GerritChangeIdentifier(),
Edward Lemur6c6827c2020-02-06 21:15:18 +00001281 description, notify='NONE')
1282
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001283 self.description = description
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001284
Edward Lemur75526302020-02-27 22:31:05 +00001285 def _GetCommonPresubmitArgs(self, verbose, upstream):
Edward Lemur227d5102020-02-25 23:45:35 +00001286 args = [
Edward Lemur227d5102020-02-25 23:45:35 +00001287 '--root', settings.GetRoot(),
1288 '--upstream', upstream,
1289 ]
1290
1291 args.extend(['--verbose'] * verbose)
1292
Edward Lesmeseb1bd622021-03-01 19:54:07 +00001293 remote, remote_branch = self.GetRemoteBranch()
1294 target_ref = GetTargetRef(remote, remote_branch, None)
1295 args.extend(['--gerrit_url', self.GetCodereviewServer()])
1296 args.extend(['--gerrit_project', self.GetGerritProject()])
1297 args.extend(['--gerrit_branch', target_ref])
1298
Edward Lemur99df04e2020-03-05 19:39:43 +00001299 author = self.GetAuthor()
Edward Lemur227d5102020-02-25 23:45:35 +00001300 issue = self.GetIssue()
1301 patchset = self.GetPatchset()
Edward Lemur99df04e2020-03-05 19:39:43 +00001302 if author:
1303 args.extend(['--author', author])
Edward Lemur227d5102020-02-25 23:45:35 +00001304 if issue:
1305 args.extend(['--issue', str(issue)])
1306 if patchset:
1307 args.extend(['--patchset', str(patchset)])
Edward Lemur227d5102020-02-25 23:45:35 +00001308
Edward Lemur75526302020-02-27 22:31:05 +00001309 return args
1310
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00001311 def RunHook(self, committing, may_prompt, verbose, parallel, upstream,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001312 description, all_files, resultdb=False, realm=None):
Edward Lemur75526302020-02-27 22:31:05 +00001313 """Calls sys.exit() if the hook fails; returns a HookResults otherwise."""
1314 args = self._GetCommonPresubmitArgs(verbose, upstream)
1315 args.append('--commit' if committing else '--upload')
Edward Lemur227d5102020-02-25 23:45:35 +00001316 if may_prompt:
1317 args.append('--may_prompt')
1318 if parallel:
1319 args.append('--parallel')
1320 if all_files:
1321 args.append('--all_files')
1322
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001323 if resultdb and not realm:
1324 # TODO (crbug.com/1113463): store realm somewhere and look it up so
1325 # it is not required to pass the realm flag
1326 print('Note: ResultDB reporting will NOT be performed because --realm'
1327 ' was not specified. To enable ResultDB, please run the command'
1328 ' again with the --realm argument to specify the LUCI realm.')
1329
1330 py2_results = self._RunPresubmit(args, resultdb, realm, description,
1331 use_python3=False)
1332 py3_results = self._RunPresubmit(args, resultdb, realm, description,
1333 use_python3=True)
1334 return self._MergePresubmitResults(py2_results, py3_results)
1335
1336 def _RunPresubmit(self, args, resultdb, realm, description, use_python3):
1337 args = args[:]
1338 vpython = 'vpython3' if use_python3 else 'vpython'
1339
Edward Lemur227d5102020-02-25 23:45:35 +00001340 with gclient_utils.temporary_file() as description_file:
1341 with gclient_utils.temporary_file() as json_output:
Edward Lemur1a83da12020-03-04 21:18:36 +00001342 gclient_utils.FileWrite(description_file, description)
Edward Lemur227d5102020-02-25 23:45:35 +00001343 args.extend(['--json_output', json_output])
1344 args.extend(['--description_file', description_file])
1345
1346 start = time_time()
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001347 cmd = [vpython, PRESUBMIT_SUPPORT] + args
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001348 if resultdb and realm:
1349 cmd = ['rdb', 'stream', '-new', '-realm', realm, '--'] + cmd
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00001350
1351 p = subprocess2.Popen(cmd)
Edward Lemur227d5102020-02-25 23:45:35 +00001352 exit_code = p.wait()
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00001353
Edward Lemur227d5102020-02-25 23:45:35 +00001354 metrics.collector.add_repeated('sub_commands', {
1355 'command': 'presubmit',
1356 'execution_time': time_time() - start,
1357 'exit_code': exit_code,
1358 })
1359
1360 if exit_code:
1361 sys.exit(exit_code)
1362
1363 json_results = gclient_utils.FileRead(json_output)
1364 return json.loads(json_results)
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001365
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001366 def _MergePresubmitResults(self, py2_results, py3_results):
1367 return {
1368 'more_cc': sorted(set(py2_results.get('more_cc', []) +
1369 py3_results.get('more_cc', []))),
1370 'errors': (
1371 py2_results.get('errors', []) + py3_results.get('errors', [])),
1372 'notifications': (
1373 py2_results.get('notifications', []) +
1374 py3_results.get('notifications', [])),
1375 'warnings': (
1376 py2_results.get('warnings', []) + py3_results.get('warnings', []))
1377 }
1378
Edward Lemur75526302020-02-27 22:31:05 +00001379 def RunPostUploadHook(self, verbose, upstream, description):
1380 args = self._GetCommonPresubmitArgs(verbose, upstream)
1381 args.append('--post_upload')
1382
1383 with gclient_utils.temporary_file() as description_file:
Edward Lemur1a83da12020-03-04 21:18:36 +00001384 gclient_utils.FileWrite(description_file, description)
Edward Lemur75526302020-02-27 22:31:05 +00001385 args.extend(['--description_file', description_file])
1386 p = subprocess2.Popen(['vpython', PRESUBMIT_SUPPORT] + args)
1387 p.wait()
1388
Edward Lemur5a644f82020-03-18 16:44:57 +00001389 def _GetDescriptionForUpload(self, options, git_diff_args, files):
1390 # Get description message for upload.
1391 if self.GetIssue():
1392 description = self.FetchDescription()
1393 elif options.message:
1394 description = options.message
1395 else:
1396 description = _create_description_from_log(git_diff_args)
1397 if options.title and options.squash:
Edward Lesmes0dd54822020-03-26 18:24:25 +00001398 description = options.title + '\n\n' + description
Edward Lemur5a644f82020-03-18 16:44:57 +00001399
1400 # Extract bug number from branch name.
1401 bug = options.bug
1402 fixed = options.fixed
1403 match = re.match(r'(?P<type>bug|fix(?:e[sd])?)[_-]?(?P<bugnum>\d+)',
1404 self.GetBranch())
1405 if not bug and not fixed and match:
1406 if match.group('type') == 'bug':
1407 bug = match.group('bugnum')
1408 else:
1409 fixed = match.group('bugnum')
1410
1411 change_description = ChangeDescription(description, bug, fixed)
1412
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001413 # Fill gaps in OWNERS coverage to tbrs/reviewers if requested.
1414 if options.add_owners_to:
1415 assert options.add_owners_to in ('TBR', 'R'), options.add_owners_to
Edward Lesmese1576912021-02-16 21:53:34 +00001416 status = self.owners_client.GetFilesApprovalStatus(
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001417 files, [], options.tbrs + options.reviewers)
1418 missing_files = [
1419 f for f in files
Edward Lesmese1576912021-02-16 21:53:34 +00001420 if status[f] == self._owners_client.INSUFFICIENT_REVIEWERS
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001421 ]
Edward Lesmese1576912021-02-16 21:53:34 +00001422 owners = self.owners_client.SuggestOwners(
1423 missing_files, exclude=[self.GetAuthor()])
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001424 if options.add_owners_to == 'TBR':
1425 assert isinstance(options.tbrs, list), options.tbrs
1426 options.tbrs.extend(owners)
1427 else:
1428 assert isinstance(options.reviewers, list), options.reviewers
1429 options.reviewers.extend(owners)
1430
Edward Lemur5a644f82020-03-18 16:44:57 +00001431 # Set the reviewer list now so that presubmit checks can access it.
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001432 if options.reviewers or options.tbrs:
1433 change_description.update_reviewers(options.reviewers, options.tbrs)
Edward Lemur5a644f82020-03-18 16:44:57 +00001434
1435 return change_description
1436
1437 def _GetTitleForUpload(self, options):
1438 # When not squashing, just return options.title.
1439 if not options.squash:
1440 return options.title
1441
1442 # On first upload, patchset title is always this string, while options.title
1443 # gets converted to first line of message.
1444 if not self.GetIssue():
1445 return 'Initial upload'
1446
1447 # When uploading subsequent patchsets, options.message is taken as the title
1448 # if options.title is not provided.
1449 if options.title:
1450 return options.title
1451 if options.message:
1452 return options.message.strip()
1453
1454 # Use the subject of the last commit as title by default.
Edward Lesmes50da7702020-03-30 19:23:43 +00001455 title = RunGit(['show', '-s', '--format=%s', 'HEAD']).strip()
Mario Bianuccicebfb4e2020-07-22 23:08:16 +00001456 if options.force or options.skip_title:
Edward Lemur5a644f82020-03-18 16:44:57 +00001457 return title
Edward Lesmesae3586b2020-03-23 21:21:14 +00001458 user_title = gclient_utils.AskForData('Title for patchset [%s]: ' % title)
1459 return user_title or title
Edward Lemur5a644f82020-03-18 16:44:57 +00001460
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001461 def CMDUpload(self, options, git_diff_args, orig_args):
1462 """Uploads a change to codereview."""
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001463 custom_cl_base = None
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001464 if git_diff_args:
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001465 custom_cl_base = base_branch = git_diff_args[0]
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001466 else:
1467 if self.GetBranch() is None:
1468 DieWithError('Can\'t upload from detached HEAD state. Get on a branch!')
1469
1470 # Default to diffing against common ancestor of upstream branch
1471 base_branch = self.GetCommonAncestorWithUpstream()
1472 git_diff_args = [base_branch, 'HEAD']
1473
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001474 # Fast best-effort checks to abort before running potentially expensive
1475 # hooks if uploading is likely to fail anyway. Passing these checks does
1476 # not guarantee that uploading will not fail.
Edward Lemur125d60a2019-09-13 18:25:41 +00001477 self.EnsureAuthenticated(force=options.force)
1478 self.EnsureCanUploadPatchset(force=options.force)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001479
1480 # Apply watchlists on upload.
Edward Lemur2c62b332020-03-12 22:12:33 +00001481 watchlist = watchlists.Watchlists(settings.GetRoot())
1482 files = self.GetAffectedFiles(base_branch)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001483 if not options.bypass_watchlists:
Daniel Cheng7227d212017-11-17 08:12:37 -08001484 self.ExtendCC(watchlist.GetWatchersForPaths(files))
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001485
Edward Lemur5a644f82020-03-18 16:44:57 +00001486 change_desc = self._GetDescriptionForUpload(options, git_diff_args, files)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001487 if not options.bypass_hooks:
Edward Lemur2c62b332020-03-12 22:12:33 +00001488 hook_results = self.RunHook(
1489 committing=False,
1490 may_prompt=not options.force,
1491 verbose=options.verbose,
1492 parallel=options.parallel,
1493 upstream=base_branch,
Edward Lemur5a644f82020-03-18 16:44:57 +00001494 description=change_desc.description,
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00001495 all_files=False,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001496 resultdb=options.resultdb,
1497 realm=options.realm)
Edward Lemur227d5102020-02-25 23:45:35 +00001498 self.ExtendCC(hook_results['more_cc'])
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001499
Aaron Gable13101a62018-02-09 13:20:41 -08001500 print_stats(git_diff_args)
Edward Lemura12175c2020-03-09 16:58:26 +00001501 ret = self.CMDUploadChange(
Edward Lemur5a644f82020-03-18 16:44:57 +00001502 options, git_diff_args, custom_cl_base, change_desc)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001503 if not ret:
Edward Lemur85153282020-02-14 22:06:29 +00001504 self._GitSetBranchConfigValue(
Edward Lesmes50da7702020-03-30 19:23:43 +00001505 'last-upload-hash', scm.GIT.ResolveCommit(settings.GetRoot(), 'HEAD'))
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001506 # Run post upload hooks, if specified.
1507 if settings.GetRunPostUploadHook():
Edward Lemur5a644f82020-03-18 16:44:57 +00001508 self.RunPostUploadHook(
1509 options.verbose, base_branch, change_desc.description)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001510
1511 # Upload all dependencies if specified.
1512 if options.dependencies:
vapiera7fbd5a2016-06-16 09:17:49 -07001513 print()
1514 print('--dependencies has been specified.')
1515 print('All dependent local branches will be re-uploaded.')
1516 print()
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001517 # Remove the dependencies flag from args so that we do not end up in a
1518 # loop.
1519 orig_args.remove('--dependencies')
Jose Lopes3863fc52020-04-07 17:00:25 +00001520 ret = upload_branch_deps(self, orig_args, options.force)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001521 return ret
1522
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001523 def SetCQState(self, new_state):
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07001524 """Updates the CQ state for the latest patchset.
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001525
1526 Issue must have been already uploaded and known.
1527 """
1528 assert new_state in _CQState.ALL_STATES
1529 assert self.GetIssue()
qyearsley1fdfcb62016-10-24 13:22:03 -07001530 try:
Edward Lemur125d60a2019-09-13 18:25:41 +00001531 vote_map = {
1532 _CQState.NONE: 0,
1533 _CQState.DRY_RUN: 1,
1534 _CQState.COMMIT: 2,
1535 }
1536 labels = {'Commit-Queue': vote_map[new_state]}
1537 notify = False if new_state == _CQState.DRY_RUN else None
1538 gerrit_util.SetReview(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001539 self.GetGerritHost(), self._GerritChangeIdentifier(),
Edward Lemur125d60a2019-09-13 18:25:41 +00001540 labels=labels, notify=notify)
qyearsley1fdfcb62016-10-24 13:22:03 -07001541 return 0
1542 except KeyboardInterrupt:
1543 raise
1544 except:
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07001545 print('WARNING: Failed to %s.\n'
qyearsley1fdfcb62016-10-24 13:22:03 -07001546 'Either:\n'
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07001547 ' * Your project has no CQ,\n'
1548 ' * You don\'t have permission to change the CQ state,\n'
1549 ' * There\'s a bug in this code (see stack trace below).\n'
1550 'Consider specifying which bots to trigger manually or asking your '
1551 'project owners for permissions or contacting Chrome Infra at:\n'
1552 'https://www.chromium.org/infra\n\n' %
1553 ('cancel CQ' if new_state == _CQState.NONE else 'trigger CQ'))
qyearsley1fdfcb62016-10-24 13:22:03 -07001554 # Still raise exception so that stack trace is printed.
1555 raise
1556
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001557 def GetGerritHost(self):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001558 # Lazy load of configs.
1559 self.GetCodereviewServer()
tandriie32e3ea2016-06-22 02:52:48 -07001560 if self._gerrit_host and '.' not in self._gerrit_host:
1561 # Abbreviated domain like "chromium" instead of chromium.googlesource.com.
1562 # This happens for internal stuff http://crbug.com/614312.
Edward Lemur79d4f992019-11-11 23:49:02 +00001563 parsed = urllib.parse.urlparse(self.GetRemoteUrl())
tandriie32e3ea2016-06-22 02:52:48 -07001564 if parsed.scheme == 'sso':
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001565 print('WARNING: using non-https URLs for remote is likely broken\n'
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001566 ' Your current remote is: %s' % self.GetRemoteUrl())
tandriie32e3ea2016-06-22 02:52:48 -07001567 self._gerrit_host = '%s.googlesource.com' % self._gerrit_host
1568 self._gerrit_server = 'https://%s' % self._gerrit_host
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001569 return self._gerrit_host
1570
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001571 def _GetGitHost(self):
1572 """Returns git host to be used when uploading change to Gerrit."""
Edward Lemur298f2cf2019-02-22 21:40:39 +00001573 remote_url = self.GetRemoteUrl()
1574 if not remote_url:
1575 return None
Edward Lemur79d4f992019-11-11 23:49:02 +00001576 return urllib.parse.urlparse(remote_url).netloc
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001577
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001578 def GetCodereviewServer(self):
1579 if not self._gerrit_server:
1580 # If we're on a branch then get the server potentially associated
1581 # with that branch.
Edward Lemur85153282020-02-14 22:06:29 +00001582 if self.GetIssue() and self.GetBranch():
tandrii5d48c322016-08-18 16:19:37 -07001583 self._gerrit_server = self._GitGetBranchConfigValue(
Edward Lesmes50da7702020-03-30 19:23:43 +00001584 CODEREVIEW_SERVER_CONFIG_KEY)
tandrii5d48c322016-08-18 16:19:37 -07001585 if self._gerrit_server:
Edward Lemur79d4f992019-11-11 23:49:02 +00001586 self._gerrit_host = urllib.parse.urlparse(self._gerrit_server).netloc
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001587 if not self._gerrit_server:
1588 # We assume repo to be hosted on Gerrit, and hence Gerrit server
1589 # has "-review" suffix for lowest level subdomain.
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001590 parts = self._GetGitHost().split('.')
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001591 parts[0] = parts[0] + '-review'
1592 self._gerrit_host = '.'.join(parts)
1593 self._gerrit_server = 'https://%s' % self._gerrit_host
1594 return self._gerrit_server
1595
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001596 def GetGerritProject(self):
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001597 """Returns Gerrit project name based on remote git URL."""
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00001598 remote_url = self.GetRemoteUrl()
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001599 if remote_url is None:
Josip906bfde2020-01-31 22:38:49 +00001600 logging.warning('can\'t detect Gerrit project.')
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00001601 return None
Edward Lemur79d4f992019-11-11 23:49:02 +00001602 project = urllib.parse.urlparse(remote_url).path.strip('/')
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001603 if project.endswith('.git'):
1604 project = project[:-len('.git')]
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00001605 # *.googlesource.com hosts ensure that Git/Gerrit projects don't start with
1606 # 'a/' prefix, because 'a/' prefix is used to force authentication in
1607 # gitiles/git-over-https protocol. E.g.,
1608 # https://chromium.googlesource.com/a/v8/v8 refers to the same repo/project
1609 # as
1610 # https://chromium.googlesource.com/v8/v8
1611 if project.startswith('a/'):
1612 project = project[len('a/'):]
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001613 return project
1614
Andrii Shyshkalovd06cc782018-08-23 17:24:19 +00001615 def _GerritChangeIdentifier(self):
1616 """Handy method for gerrit_util.ChangeIdentifier for a given CL.
1617
1618 Not to be confused by value of "Change-Id:" footer.
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00001619 If Gerrit project can be determined, this will speed up Gerrit HTTP API RPC.
Andrii Shyshkalovd06cc782018-08-23 17:24:19 +00001620 """
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001621 project = self.GetGerritProject()
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00001622 if project:
1623 return gerrit_util.ChangeIdentifier(project, self.GetIssue())
1624 # Fall back on still unique, but less efficient change number.
1625 return str(self.GetIssue())
Andrii Shyshkalovd06cc782018-08-23 17:24:19 +00001626
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01001627 def EnsureAuthenticated(self, force, refresh=None):
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001628 """Best effort check that user is authenticated with Gerrit server."""
tandrii@chromium.org28253532016-04-14 13:46:56 +00001629 if settings.GetGerritSkipEnsureAuthenticated():
1630 # For projects with unusual authentication schemes.
1631 # See http://crbug.com/603378.
1632 return
Vadim Shtayurab250ec12018-10-04 00:21:08 +00001633
1634 # Check presence of cookies only if using cookies-based auth method.
1635 cookie_auth = gerrit_util.Authenticator.get()
1636 if not isinstance(cookie_auth, gerrit_util.CookiesAuthenticator):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001637 return
Vadim Shtayurab250ec12018-10-04 00:21:08 +00001638
Florian Mayerae510e82020-01-30 21:04:48 +00001639 remote_url = self.GetRemoteUrl()
1640 if remote_url is None:
Josip906bfde2020-01-31 22:38:49 +00001641 logging.warning('invalid remote')
Florian Mayerae510e82020-01-30 21:04:48 +00001642 return
1643 if urllib.parse.urlparse(remote_url).scheme != 'https':
Josip906bfde2020-01-31 22:38:49 +00001644 logging.warning('Ignoring branch %(branch)s with non-https remote '
1645 '%(remote)s', {
1646 'branch': self.branch,
1647 'remote': self.GetRemoteUrl()
1648 })
Daniel Chengcf6269b2019-05-18 01:02:12 +00001649 return
1650
Vadim Shtayurab250ec12018-10-04 00:21:08 +00001651 # Lazy-loader to identify Gerrit and Git hosts.
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001652 self.GetCodereviewServer()
1653 git_host = self._GetGitHost()
Edward Lemur298f2cf2019-02-22 21:40:39 +00001654 assert self._gerrit_server and self._gerrit_host and git_host
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001655
1656 gerrit_auth = cookie_auth.get_auth_header(self._gerrit_host)
1657 git_auth = cookie_auth.get_auth_header(git_host)
1658 if gerrit_auth and git_auth:
1659 if gerrit_auth == git_auth:
1660 return
Andrii Shyshkalov354e1d22017-06-09 19:31:33 +02001661 all_gsrc = cookie_auth.get_auth_header('d0esN0tEx1st.googlesource.com')
Raul Tambre80ee78e2019-05-06 22:41:05 +00001662 print(
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001663 'WARNING: You have different credentials for Gerrit and git hosts:\n'
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001664 ' %s\n'
1665 ' %s\n'
Andrii Shyshkalov51acef92017-04-11 17:19:59 +02001666 ' Consider running the following command:\n'
1667 ' git cl creds-check\n'
Andrii Shyshkalov354e1d22017-06-09 19:31:33 +02001668 ' %s\n'
Raul Tambre80ee78e2019-05-06 22:41:05 +00001669 ' %s' %
Andrii Shyshkalov51acef92017-04-11 17:19:59 +02001670 (git_host, self._gerrit_host,
Andrii Shyshkalov354e1d22017-06-09 19:31:33 +02001671 ('Hint: delete creds for .googlesource.com' if all_gsrc else ''),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001672 cookie_auth.get_new_password_message(git_host)))
1673 if not force:
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001674 confirm_or_exit('If you know what you are doing', action='continue')
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001675 return
1676 else:
1677 missing = (
Anna Henningsen4e891442017-07-06 21:40:58 +02001678 ([] if gerrit_auth else [self._gerrit_host]) +
1679 ([] if git_auth else [git_host]))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001680 DieWithError('Credentials for the following hosts are required:\n'
1681 ' %s\n'
1682 'These are read from %s (or legacy %s)\n'
1683 '%s' % (
1684 '\n '.join(missing),
1685 cookie_auth.get_gitcookies_path(),
1686 cookie_auth.get_netrc_path(),
1687 cookie_auth.get_new_password_message(git_host)))
1688
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001689 def EnsureCanUploadPatchset(self, force):
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01001690 if not self.GetIssue():
1691 return
1692
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01001693 status = self._GetChangeDetail()['status']
1694 if status in ('MERGED', 'ABANDONED'):
1695 DieWithError('Change %s has been %s, new uploads are not allowed' %
1696 (self.GetIssueURL(),
1697 'submitted' if status == 'MERGED' else 'abandoned'))
1698
Vadim Shtayurab250ec12018-10-04 00:21:08 +00001699 # TODO(vadimsh): For some reason the chunk of code below was skipped if
1700 # 'is_gce' is True. I'm just refactoring it to be 'skip if not cookies'.
1701 # Apparently this check is not very important? Otherwise get_auth_email
1702 # could have been added to other implementations of Authenticator.
1703 cookies_auth = gerrit_util.Authenticator.get()
1704 if not isinstance(cookies_auth, gerrit_util.CookiesAuthenticator):
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001705 return
Vadim Shtayurab250ec12018-10-04 00:21:08 +00001706
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001707 cookies_user = cookies_auth.get_auth_email(self.GetGerritHost())
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001708 if self.GetIssueOwner() == cookies_user:
1709 return
1710 logging.debug('change %s owner is %s, cookies user is %s',
1711 self.GetIssue(), self.GetIssueOwner(), cookies_user)
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001712 # Maybe user has linked accounts or something like that,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001713 # so ask what Gerrit thinks of this user.
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001714 details = gerrit_util.GetAccountDetails(self.GetGerritHost(), 'self')
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001715 if details['email'] == self.GetIssueOwner():
1716 return
1717 if not force:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001718 print('WARNING: Change %s is owned by %s, but you authenticate to Gerrit '
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001719 'as %s.\n'
1720 'Uploading may fail due to lack of permissions.' %
1721 (self.GetIssue(), self.GetIssueOwner(), details['email']))
1722 confirm_or_exit(action='upload')
1723
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001724 def GetStatus(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001725 """Applies a rough heuristic to give a simple summary of an issue's review
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001726 or CQ status, assuming adherence to a common workflow.
1727
1728 Returns None if no issue for this branch, or one of the following keywords:
Aaron Gable9ab38c62017-04-06 14:36:33 -07001729 * 'error' - error from review tool (including deleted issues)
1730 * 'unsent' - no reviewers added
1731 * 'waiting' - waiting for review
1732 * 'reply' - waiting for uploader to reply to review
1733 * 'lgtm' - Code-Review label has been set
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00001734 * 'dry-run' - dry-running in the CQ
1735 * 'commit' - in the CQ
Aaron Gable9ab38c62017-04-06 14:36:33 -07001736 * 'closed' - successfully submitted or abandoned
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001737 """
1738 if not self.GetIssue():
1739 return None
1740
1741 try:
Aaron Gable9ab38c62017-04-06 14:36:33 -07001742 data = self._GetChangeDetail([
1743 'DETAILED_LABELS', 'CURRENT_REVISION', 'SUBMITTABLE'])
Edward Lemur79d4f992019-11-11 23:49:02 +00001744 except GerritChangeNotExists:
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001745 return 'error'
1746
tandrii@chromium.org5e1bf382016-05-17 08:43:24 +00001747 if data['status'] in ('ABANDONED', 'MERGED'):
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001748 return 'closed'
1749
Andrii Shyshkalovb8268ca2019-04-03 23:33:44 +00001750 cq_label = data['labels'].get('Commit-Queue', {})
1751 max_cq_vote = 0
1752 for vote in cq_label.get('all', []):
1753 max_cq_vote = max(max_cq_vote, vote.get('value', 0))
1754 if max_cq_vote == 2:
Aaron Gable9ab38c62017-04-06 14:36:33 -07001755 return 'commit'
Andrii Shyshkalovb8268ca2019-04-03 23:33:44 +00001756 if max_cq_vote == 1:
1757 return 'dry-run'
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001758
Aaron Gable9ab38c62017-04-06 14:36:33 -07001759 if data['labels'].get('Code-Review', {}).get('approved'):
1760 return 'lgtm'
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001761
1762 if not data.get('reviewers', {}).get('REVIEWER', []):
1763 return 'unsent'
1764
Andrii Shyshkalov33e88a42017-01-27 14:45:30 +01001765 owner = data['owner'].get('_account_id')
Edward Lemur79d4f992019-11-11 23:49:02 +00001766 messages = sorted(data.get('messages', []), key=lambda m: m.get('date'))
Andrii Shyshkalov8aa9d622020-03-10 19:15:35 +00001767 while messages:
1768 m = messages.pop()
1769 if m.get('tag', '').startswith('autogenerated:cq:'):
Andrii Shyshkalov33e88a42017-01-27 14:45:30 +01001770 # Ignore replies from CQ.
1771 continue
Andrii Shyshkalov8aa9d622020-03-10 19:15:35 +00001772 if m.get('author', {}).get('_account_id') == owner:
Aaron Gable9ab38c62017-04-06 14:36:33 -07001773 # Most recent message was by owner.
1774 return 'waiting'
1775 else:
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001776 # Some reply from non-owner.
1777 return 'reply'
Aaron Gable9ab38c62017-04-06 14:36:33 -07001778
1779 # Somehow there are no messages even though there are reviewers.
1780 return 'unsent'
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001781
1782 def GetMostRecentPatchset(self):
Edward Lemur6c6827c2020-02-06 21:15:18 +00001783 if not self.GetIssue():
1784 return None
1785
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001786 data = self._GetChangeDetail(['CURRENT_REVISION'])
Aaron Gablee8856ee2017-12-07 12:41:46 -08001787 patchset = data['revisions'][data['current_revision']]['_number']
1788 self.SetPatchset(patchset)
1789 return patchset
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001790
Gavin Make61ccc52020-11-13 00:12:57 +00001791 def GetMostRecentDryRunPatchset(self):
1792 """Get patchsets equivalent to the most recent patchset and return
1793 the patchset with the latest dry run. If none have been dry run, return
1794 the latest patchset."""
1795 if not self.GetIssue():
1796 return None
1797
1798 data = self._GetChangeDetail(['ALL_REVISIONS'])
1799 patchset = data['revisions'][data['current_revision']]['_number']
1800 dry_run = set([int(m['_revision_number'])
1801 for m in data.get('messages', [])
1802 if m.get('tag', '').endswith('dry-run')])
1803
1804 for revision_info in sorted(data.get('revisions', {}).values(),
1805 key=lambda c: c['_number'], reverse=True):
1806 if revision_info['_number'] in dry_run:
1807 patchset = revision_info['_number']
1808 break
1809 if revision_info.get('kind', '') not in \
1810 ('NO_CHANGE', 'NO_CODE_CHANGE', 'TRIVIAL_REBASE'):
1811 break
1812 self.SetPatchset(patchset)
1813 return patchset
1814
Aaron Gable636b13f2017-07-14 10:42:48 -07001815 def AddComment(self, message, publish=None):
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00001816 gerrit_util.SetReview(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001817 self.GetGerritHost(), self._GerritChangeIdentifier(),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00001818 msg=message, ready=publish)
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01001819
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001820 def GetCommentsSummary(self, readable=True):
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01001821 # DETAILED_ACCOUNTS is to get emails in accounts.
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001822 # CURRENT_REVISION is included to get the latest patchset so that
1823 # only the robot comments from the latest patchset can be shown.
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001824 messages = self._GetChangeDetail(
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001825 options=['MESSAGES', 'DETAILED_ACCOUNTS',
1826 'CURRENT_REVISION']).get('messages', [])
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001827 file_comments = gerrit_util.GetChangeComments(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001828 self.GetGerritHost(), self._GerritChangeIdentifier())
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001829 robot_file_comments = gerrit_util.GetChangeRobotComments(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001830 self.GetGerritHost(), self._GerritChangeIdentifier())
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001831
1832 # Add the robot comments onto the list of comments, but only
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00001833 # keep those that are from the latest patchset.
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001834 latest_patch_set = self.GetMostRecentPatchset()
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001835 for path, robot_comments in robot_file_comments.items():
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001836 line_comments = file_comments.setdefault(path, [])
1837 line_comments.extend(
1838 [c for c in robot_comments if c['patch_set'] == latest_patch_set])
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001839
1840 # Build dictionary of file comments for easy access and sorting later.
1841 # {author+date: {path: {patchset: {line: url+message}}}}
1842 comments = collections.defaultdict(
1843 lambda: collections.defaultdict(lambda: collections.defaultdict(dict)))
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00001844
1845 server = self.GetCodereviewServer()
1846 if server in _KNOWN_GERRIT_TO_SHORT_URLS:
1847 # /c/ is automatically added by short URL server.
1848 url_prefix = '%s/%s' % (_KNOWN_GERRIT_TO_SHORT_URLS[server],
1849 self.GetIssue())
1850 else:
1851 url_prefix = '%s/c/%s' % (server, self.GetIssue())
1852
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001853 for path, line_comments in file_comments.items():
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001854 for comment in line_comments:
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001855 tag = comment.get('tag', '')
1856 if tag.startswith('autogenerated') and 'robot_id' not in comment:
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001857 continue
1858 key = (comment['author']['email'], comment['updated'])
1859 if comment.get('side', 'REVISION') == 'PARENT':
1860 patchset = 'Base'
1861 else:
1862 patchset = 'PS%d' % comment['patch_set']
1863 line = comment.get('line', 0)
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00001864 url = ('%s/%s/%s#%s%s' %
1865 (url_prefix, comment['patch_set'], path,
1866 'b' if comment.get('side') == 'PARENT' else '',
1867 str(line) if line else ''))
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001868 comments[key][path][patchset][line] = (url, comment['message'])
1869
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001870 summaries = []
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001871 for msg in messages:
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001872 summary = self._BuildCommentSummary(msg, comments, readable)
1873 if summary:
1874 summaries.append(summary)
1875 return summaries
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001876
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001877 @staticmethod
1878 def _BuildCommentSummary(msg, comments, readable):
1879 key = (msg['author']['email'], msg['date'])
1880 # Don't bother showing autogenerated messages that don't have associated
1881 # file or line comments. this will filter out most autogenerated
1882 # messages, but will keep robot comments like those from Tricium.
1883 is_autogenerated = msg.get('tag', '').startswith('autogenerated')
1884 if is_autogenerated and not comments.get(key):
1885 return None
1886 message = msg['message']
1887 # Gerrit spits out nanoseconds.
1888 assert len(msg['date'].split('.')[-1]) == 9
1889 date = datetime.datetime.strptime(msg['date'][:-3],
1890 '%Y-%m-%d %H:%M:%S.%f')
1891 if key in comments:
1892 message += '\n'
1893 for path, patchsets in sorted(comments.get(key, {}).items()):
1894 if readable:
1895 message += '\n%s' % path
1896 for patchset, lines in sorted(patchsets.items()):
1897 for line, (url, content) in sorted(lines.items()):
1898 if line:
1899 line_str = 'Line %d' % line
1900 path_str = '%s:%d:' % (path, line)
1901 else:
1902 line_str = 'File comment'
1903 path_str = '%s:0:' % path
1904 if readable:
1905 message += '\n %s, %s: %s' % (patchset, line_str, url)
1906 message += '\n %s\n' % content
1907 else:
1908 message += '\n%s ' % path_str
1909 message += '\n%s\n' % content
1910
1911 return _CommentSummary(
1912 date=date,
1913 message=message,
1914 sender=msg['author']['email'],
1915 autogenerated=is_autogenerated,
1916 # These could be inferred from the text messages and correlated with
1917 # Code-Review label maximum, however this is not reliable.
1918 # Leaving as is until the need arises.
1919 approval=False,
1920 disapproval=False,
1921 )
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01001922
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001923 def CloseIssue(self):
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00001924 gerrit_util.AbandonChange(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001925 self.GetGerritHost(), self._GerritChangeIdentifier(), msg='')
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001926
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00001927 def SubmitIssue(self, wait_for_merge=True):
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00001928 gerrit_util.SubmitChange(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001929 self.GetGerritHost(), self._GerritChangeIdentifier(),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00001930 wait_for_merge=wait_for_merge)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001931
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001932 def _GetChangeDetail(self, options=None):
1933 """Returns details of associated Gerrit change and caching results."""
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00001934 options = options or []
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001935 assert self.GetIssue(), 'issue is required to query Gerrit'
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01001936
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01001937 # Optimization to avoid multiple RPCs:
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001938 if 'CURRENT_REVISION' in options or 'ALL_REVISIONS' in options:
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01001939 options.append('CURRENT_COMMIT')
1940
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01001941 # Normalize issue and options for consistent keys in cache.
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001942 cache_key = str(self.GetIssue())
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001943 options_set = frozenset(o.upper() for o in options)
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01001944
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001945 for cached_options_set, data in self._detail_cache.get(cache_key, []):
1946 # Assumption: data fetched before with extra options is suitable
1947 # for return for a smaller set of options.
1948 # For example, if we cached data for
1949 # options=[CURRENT_REVISION, DETAILED_FOOTERS]
1950 # and request is for options=[CURRENT_REVISION],
1951 # THEN we can return prior cached data.
1952 if options_set.issubset(cached_options_set):
1953 return data
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01001954
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01001955 try:
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001956 data = gerrit_util.GetChangeDetail(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001957 self.GetGerritHost(), self._GerritChangeIdentifier(), options_set)
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01001958 except gerrit_util.GerritError as e:
1959 if e.http_status == 404:
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001960 raise GerritChangeNotExists(self.GetIssue(), self.GetCodereviewServer())
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01001961 raise
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01001962
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001963 self._detail_cache.setdefault(cache_key, []).append((options_set, data))
tandriic2405f52016-10-10 08:13:15 -07001964 return data
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001965
Andrii Shyshkalovcc5f17e2018-08-22 23:35:59 +00001966 def _GetChangeCommit(self):
Andrii Shyshkalove2633162018-08-27 23:50:31 +00001967 assert self.GetIssue(), 'issue must be set to query Gerrit'
Aaron Gable6f5a8d92017-04-18 14:49:05 -07001968 try:
Andrii Shyshkalove2633162018-08-27 23:50:31 +00001969 data = gerrit_util.GetChangeCommit(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001970 self.GetGerritHost(), self._GerritChangeIdentifier())
Aaron Gable6f5a8d92017-04-18 14:49:05 -07001971 except gerrit_util.GerritError as e:
1972 if e.http_status == 404:
Andrii Shyshkalove2633162018-08-27 23:50:31 +00001973 raise GerritChangeNotExists(self.GetIssue(), self.GetCodereviewServer())
Aaron Gable6f5a8d92017-04-18 14:49:05 -07001974 raise
agable32978d92016-11-01 12:55:02 -07001975 return data
1976
Karen Qian40c19422019-03-13 21:28:29 +00001977 def _IsCqConfigured(self):
1978 detail = self._GetChangeDetail(['LABELS'])
Andrii Shyshkalov8effa4d2020-01-21 13:23:36 +00001979 return u'Commit-Queue' in detail.get('labels', {})
Karen Qian40c19422019-03-13 21:28:29 +00001980
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001981 def CMDLand(self, force, bypass_hooks, verbose, parallel, resultdb, realm):
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00001982 if git_common.is_dirty_git_tree('land'):
1983 return 1
Karen Qian40c19422019-03-13 21:28:29 +00001984
tandriid60367b2016-06-22 05:25:12 -07001985 detail = self._GetChangeDetail(['CURRENT_REVISION', 'LABELS'])
Karen Qian40c19422019-03-13 21:28:29 +00001986 if not force and self._IsCqConfigured():
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00001987 confirm_or_exit('\nIt seems this repository has a CQ, '
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001988 'which can test and land changes for you. '
1989 'Are you sure you wish to bypass it?\n',
1990 action='bypass CQ')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00001991 differs = True
tandriic4344b52016-08-29 06:04:54 -07001992 last_upload = self._GitGetBranchConfigValue('gerritsquashhash')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00001993 # Note: git diff outputs nothing if there is no diff.
1994 if not last_upload or RunGit(['diff', last_upload]).strip():
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001995 print('WARNING: Some changes from local branch haven\'t been uploaded.')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00001996 else:
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00001997 if detail['current_revision'] == last_upload:
1998 differs = False
1999 else:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002000 print('WARNING: Local branch contents differ from latest uploaded '
2001 'patchset.')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002002 if differs:
2003 if not force:
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002004 confirm_or_exit(
2005 'Do you want to submit latest Gerrit patchset and bypass hooks?\n',
2006 action='submit')
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002007 print('WARNING: Bypassing hooks and submitting latest uploaded patchset.')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002008 elif not bypass_hooks:
Edward Lemur227d5102020-02-25 23:45:35 +00002009 upstream = self.GetCommonAncestorWithUpstream()
2010 if self.GetIssue():
2011 description = self.FetchDescription()
2012 else:
Edward Lemura12175c2020-03-09 16:58:26 +00002013 description = _create_description_from_log([upstream])
Edward Lemur227d5102020-02-25 23:45:35 +00002014 self.RunHook(
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002015 committing=True,
2016 may_prompt=not force,
2017 verbose=verbose,
Edward Lemur227d5102020-02-25 23:45:35 +00002018 parallel=parallel,
2019 upstream=upstream,
2020 description=description,
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00002021 all_files=False,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00002022 resultdb=resultdb,
2023 realm=realm)
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002024
2025 self.SubmitIssue(wait_for_merge=True)
2026 print('Issue %s has been submitted.' % self.GetIssueURL())
agable32978d92016-11-01 12:55:02 -07002027 links = self._GetChangeCommit().get('web_links', [])
2028 for link in links:
Aaron Gable02cdbb42016-12-13 16:24:25 -08002029 if link.get('name') == 'gitiles' and link.get('url'):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002030 print('Landed as: %s' % link.get('url'))
agable32978d92016-11-01 12:55:02 -07002031 break
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002032 return 0
2033
Bruce Dawsonf362f6f2021-02-18 23:15:17 +00002034 def CMDPatchWithParsedIssue(self, parsed_issue_arg, nocommit, force,
2035 newbranch):
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002036 assert parsed_issue_arg.valid
2037
Edward Lemur125d60a2019-09-13 18:25:41 +00002038 self.issue = parsed_issue_arg.issue
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002039
2040 if parsed_issue_arg.hostname:
2041 self._gerrit_host = parsed_issue_arg.hostname
2042 self._gerrit_server = 'https://%s' % self._gerrit_host
2043
tandriic2405f52016-10-10 08:13:15 -07002044 try:
2045 detail = self._GetChangeDetail(['ALL_REVISIONS'])
Aaron Gablea45ee112016-11-22 15:14:38 -08002046 except GerritChangeNotExists as e:
tandriic2405f52016-10-10 08:13:15 -07002047 DieWithError(str(e))
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002048
2049 if not parsed_issue_arg.patchset:
2050 # Use current revision by default.
2051 revision_info = detail['revisions'][detail['current_revision']]
2052 patchset = int(revision_info['_number'])
2053 else:
2054 patchset = parsed_issue_arg.patchset
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00002055 for revision_info in detail['revisions'].values():
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002056 if int(revision_info['_number']) == parsed_issue_arg.patchset:
2057 break
2058 else:
Aaron Gablea45ee112016-11-22 15:14:38 -08002059 DieWithError('Couldn\'t find patchset %i in change %i' %
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002060 (parsed_issue_arg.patchset, self.GetIssue()))
2061
Edward Lemur125d60a2019-09-13 18:25:41 +00002062 remote_url = self.GetRemoteUrl()
Aaron Gable697a91b2018-01-19 15:20:15 -08002063 if remote_url.endswith('.git'):
2064 remote_url = remote_url[:-len('.git')]
erikchen0d14d0d2018-08-28 18:57:09 +00002065 remote_url = remote_url.rstrip('/')
2066
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002067 fetch_info = revision_info['fetch']['http']
erikchen0d14d0d2018-08-28 18:57:09 +00002068 fetch_info['url'] = fetch_info['url'].rstrip('/')
Aaron Gable697a91b2018-01-19 15:20:15 -08002069
2070 if remote_url != fetch_info['url']:
2071 DieWithError('Trying to patch a change from %s but this repo appears '
2072 'to be %s.' % (fetch_info['url'], remote_url))
2073
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002074 RunGit(['fetch', fetch_info['url'], fetch_info['ref']])
Aaron Gable9387b4f2017-06-08 10:50:03 -07002075
Bruce Dawsonf362f6f2021-02-18 23:15:17 +00002076 # If we have created a new branch then do the "set issue" immediately in
2077 # case the cherry-pick fails, which happens when resolving conflicts.
2078 if newbranch:
2079 self.SetIssue(parsed_issue_arg.issue)
2080
Aaron Gable62619a32017-06-16 08:22:09 -07002081 if force:
2082 RunGit(['reset', '--hard', 'FETCH_HEAD'])
2083 print('Checked out commit for change %i patchset %i locally' %
2084 (parsed_issue_arg.issue, patchset))
Stefan Zager2d5f0392017-10-10 15:17:53 -07002085 elif nocommit:
2086 RunGit(['cherry-pick', '--no-commit', 'FETCH_HEAD'])
2087 print('Patch applied to index.')
Aaron Gable62619a32017-06-16 08:22:09 -07002088 else:
Aaron Gable9387b4f2017-06-08 10:50:03 -07002089 RunGit(['cherry-pick', 'FETCH_HEAD'])
2090 print('Committed patch for change %i patchset %i locally.' %
Aaron Gable62619a32017-06-16 08:22:09 -07002091 (parsed_issue_arg.issue, patchset))
2092 print('Note: this created a local commit which does not have '
2093 'the same hash as the one uploaded for review. This will make '
2094 'uploading changes based on top of this branch difficult.\n'
2095 'If you want to do that, use "git cl patch --force" instead.')
2096
Stefan Zagerd08043c2017-10-12 12:07:02 -07002097 if self.GetBranch():
2098 self.SetIssue(parsed_issue_arg.issue)
2099 self.SetPatchset(patchset)
Edward Lesmes50da7702020-03-30 19:23:43 +00002100 fetched_hash = scm.GIT.ResolveCommit(settings.GetRoot(), 'FETCH_HEAD')
Stefan Zagerd08043c2017-10-12 12:07:02 -07002101 self._GitSetBranchConfigValue('last-upload-hash', fetched_hash)
2102 self._GitSetBranchConfigValue('gerritsquashhash', fetched_hash)
2103 else:
2104 print('WARNING: You are in detached HEAD state.\n'
2105 'The patch has been applied to your checkout, but you will not be '
2106 'able to upload a new patch set to the gerrit issue.\n'
2107 'Try using the \'-b\' option if you would like to work on a '
2108 'branch and/or upload a new patch set.')
2109
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002110 return 0
2111
tandrii16e0b4e2016-06-07 10:34:28 -07002112 def _GerritCommitMsgHookCheck(self, offer_removal):
2113 hook = os.path.join(settings.GetRoot(), '.git', 'hooks', 'commit-msg')
2114 if not os.path.exists(hook):
2115 return
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002116 # Crude attempt to distinguish Gerrit Codereview hook from a potentially
2117 # custom developer-made one.
tandrii16e0b4e2016-06-07 10:34:28 -07002118 data = gclient_utils.FileRead(hook)
2119 if not('From Gerrit Code Review' in data and 'add_ChangeId()' in data):
2120 return
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002121 print('WARNING: You have Gerrit commit-msg hook installed.\n'
qyearsley12fa6ff2016-08-24 09:18:40 -07002122 'It is not necessary for uploading with git cl in squash mode, '
tandrii16e0b4e2016-06-07 10:34:28 -07002123 'and may interfere with it in subtle ways.\n'
2124 'We recommend you remove the commit-msg hook.')
2125 if offer_removal:
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002126 if ask_for_explicit_yes('Do you want to remove it now?'):
tandrii16e0b4e2016-06-07 10:34:28 -07002127 gclient_utils.rm_file_or_tree(hook)
2128 print('Gerrit commit-msg hook removed.')
2129 else:
2130 print('OK, will keep Gerrit commit-msg hook in place.')
2131
Edward Lemur1b52d872019-05-09 21:12:12 +00002132 def _CleanUpOldTraces(self):
2133 """Keep only the last |MAX_TRACES| traces."""
2134 try:
2135 traces = sorted([
2136 os.path.join(TRACES_DIR, f)
2137 for f in os.listdir(TRACES_DIR)
2138 if (os.path.isfile(os.path.join(TRACES_DIR, f))
2139 and not f.startswith('tmp'))
2140 ])
2141 traces_to_delete = traces[:-MAX_TRACES]
2142 for trace in traces_to_delete:
Daniel Chengcf6269b2019-05-18 01:02:12 +00002143 os.remove(trace)
Edward Lemur1b52d872019-05-09 21:12:12 +00002144 except OSError:
2145 print('WARNING: Failed to remove old git traces from\n'
2146 ' %s'
2147 'Consider removing them manually.' % TRACES_DIR)
Edward Lemurdc8e23d2019-05-07 00:45:48 +00002148
Edward Lemur5737f022019-05-17 01:24:00 +00002149 def _WriteGitPushTraces(self, trace_name, traces_dir, git_push_metadata):
Edward Lemur1b52d872019-05-09 21:12:12 +00002150 """Zip and write the git push traces stored in traces_dir."""
2151 gclient_utils.safe_makedirs(TRACES_DIR)
Edward Lemur1b52d872019-05-09 21:12:12 +00002152 traces_zip = trace_name + '-traces'
2153 traces_readme = trace_name + '-README'
Michael Mosse7f0b4c2019-05-08 04:36:24 +00002154 # Create a temporary dir to store git config and gitcookies in. It will be
2155 # compressed and stored next to the traces.
2156 git_info_dir = tempfile.mkdtemp()
Edward Lemur1b52d872019-05-09 21:12:12 +00002157 git_info_zip = trace_name + '-git-info'
2158
Josip Sokcevic5e18b602020-04-23 21:47:00 +00002159 git_push_metadata['now'] = datetime_now().strftime('%Y-%m-%dT%H:%M:%S.%f')
sangwoo.ko7a614332019-05-22 02:46:19 +00002160
Edward Lemur1b52d872019-05-09 21:12:12 +00002161 git_push_metadata['trace_name'] = trace_name
2162 gclient_utils.FileWrite(
2163 traces_readme, TRACES_README_FORMAT % git_push_metadata)
2164
2165 # Keep only the first 6 characters of the git hashes on the packet
2166 # trace. This greatly decreases size after compression.
2167 packet_traces = os.path.join(traces_dir, 'trace-packet')
2168 if os.path.isfile(packet_traces):
2169 contents = gclient_utils.FileRead(packet_traces)
2170 gclient_utils.FileWrite(
2171 packet_traces, GIT_HASH_RE.sub(r'\1', contents))
2172 shutil.make_archive(traces_zip, 'zip', traces_dir)
2173
2174 # Collect and compress the git config and gitcookies.
2175 git_config = RunGit(['config', '-l'])
2176 gclient_utils.FileWrite(
2177 os.path.join(git_info_dir, 'git-config'),
2178 git_config)
2179
2180 cookie_auth = gerrit_util.Authenticator.get()
2181 if isinstance(cookie_auth, gerrit_util.CookiesAuthenticator):
2182 gitcookies_path = cookie_auth.get_gitcookies_path()
2183 if os.path.isfile(gitcookies_path):
2184 gitcookies = gclient_utils.FileRead(gitcookies_path)
2185 gclient_utils.FileWrite(
2186 os.path.join(git_info_dir, 'gitcookies'),
2187 GITCOOKIES_REDACT_RE.sub('REDACTED', gitcookies))
2188 shutil.make_archive(git_info_zip, 'zip', git_info_dir)
2189
Edward Lemur1b52d872019-05-09 21:12:12 +00002190 gclient_utils.rmtree(git_info_dir)
2191
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +00002192 def _RunGitPushWithTraces(self,
2193 refspec,
2194 refspec_opts,
2195 git_push_metadata,
2196 git_push_options=None):
Edward Lemur1b52d872019-05-09 21:12:12 +00002197 """Run git push and collect the traces resulting from the execution."""
2198 # Create a temporary directory to store traces in. Traces will be compressed
2199 # and stored in a 'traces' dir inside depot_tools.
2200 traces_dir = tempfile.mkdtemp()
Edward Lemur5737f022019-05-17 01:24:00 +00002201 trace_name = os.path.join(
2202 TRACES_DIR, datetime_now().strftime('%Y%m%dT%H%M%S.%f'))
Edward Lemur0f58ae42019-04-30 17:24:12 +00002203
2204 env = os.environ.copy()
2205 env['GIT_REDACT_COOKIES'] = 'o,SSO,GSSO_Uberproxy'
2206 env['GIT_TR2_EVENT'] = os.path.join(traces_dir, 'tr2-event')
Jonathan Nieder9779b142019-05-29 23:19:29 +00002207 env['GIT_TRACE2_EVENT'] = os.path.join(traces_dir, 'tr2-event')
Edward Lemur0f58ae42019-04-30 17:24:12 +00002208 env['GIT_TRACE_CURL'] = os.path.join(traces_dir, 'trace-curl')
2209 env['GIT_TRACE_CURL_NO_DATA'] = '1'
2210 env['GIT_TRACE_PACKET'] = os.path.join(traces_dir, 'trace-packet')
2211
2212 try:
2213 push_returncode = 0
Edward Lemur1b52d872019-05-09 21:12:12 +00002214 remote_url = self.GetRemoteUrl()
Edward Lemur0f58ae42019-04-30 17:24:12 +00002215 before_push = time_time()
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +00002216 push_cmd = ['git', 'push', remote_url, refspec]
2217 if git_push_options:
2218 for opt in git_push_options:
2219 push_cmd.extend(['-o', opt])
2220
Edward Lemur0f58ae42019-04-30 17:24:12 +00002221 push_stdout = gclient_utils.CheckCallAndFilter(
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +00002222 push_cmd,
Edward Lemur0f58ae42019-04-30 17:24:12 +00002223 env=env,
2224 print_stdout=True,
2225 # Flush after every line: useful for seeing progress when running as
2226 # recipe.
2227 filter_fn=lambda _: sys.stdout.flush())
Edward Lemur79d4f992019-11-11 23:49:02 +00002228 push_stdout = push_stdout.decode('utf-8', 'replace')
Edward Lemur0f58ae42019-04-30 17:24:12 +00002229 except subprocess2.CalledProcessError as e:
2230 push_returncode = e.returncode
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002231 raise GitPushError(
2232 'Failed to create a change. Please examine output above for the '
2233 'reason of the failure.\n'
Josip Sokcevic7386a1e2021-02-12 19:00:34 +00002234 'For emergencies, Googlers can escalate to '
2235 'go/gob-support or go/notify#gob\n'
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002236 'Hint: run command below to diagnose common Git/Gerrit '
2237 'credential problems:\n'
2238 ' git cl creds-check\n'
2239 '\n'
2240 'If git-cl is not working correctly, file a bug under the Infra>SDK '
2241 'component including the files below.\n'
2242 'Review the files before upload, since they might contain sensitive '
2243 'information.\n'
2244 'Set the Restrict-View-Google label so that they are not publicly '
2245 'accessible.\n' + TRACES_MESSAGE % {'trace_name': trace_name})
Edward Lemur0f58ae42019-04-30 17:24:12 +00002246 finally:
2247 execution_time = time_time() - before_push
2248 metrics.collector.add_repeated('sub_commands', {
2249 'command': 'git push',
2250 'execution_time': execution_time,
2251 'exit_code': push_returncode,
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002252 'arguments': metrics_utils.extract_known_subcommand_args(refspec_opts),
Edward Lemur0f58ae42019-04-30 17:24:12 +00002253 })
2254
Edward Lemur1b52d872019-05-09 21:12:12 +00002255 git_push_metadata['execution_time'] = execution_time
2256 git_push_metadata['exit_code'] = push_returncode
Edward Lemur5737f022019-05-17 01:24:00 +00002257 self._WriteGitPushTraces(trace_name, traces_dir, git_push_metadata)
Edward Lemur0f58ae42019-04-30 17:24:12 +00002258
Edward Lemur1b52d872019-05-09 21:12:12 +00002259 self._CleanUpOldTraces()
Edward Lemur0f58ae42019-04-30 17:24:12 +00002260 gclient_utils.rmtree(traces_dir)
2261
2262 return push_stdout
2263
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002264 def CMDUploadChange(self, options, git_diff_args, custom_cl_base,
2265 change_desc):
2266 """Upload the current branch to Gerrit, retry if new remote HEAD is
2267 found. options and change_desc may be mutated."""
Josip Sokcevicb631a882021-01-06 18:18:10 +00002268 remote, remote_branch = self.GetRemoteBranch()
2269 branch = GetTargetRef(remote, remote_branch, options.target_branch)
2270
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002271 try:
2272 return self._CMDUploadChange(options, git_diff_args, custom_cl_base,
Josip Sokcevicb631a882021-01-06 18:18:10 +00002273 change_desc, branch)
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002274 except GitPushError as e:
Josip Sokcevicb631a882021-01-06 18:18:10 +00002275 # Repository might be in the middle of transition to main branch as
2276 # default, and uploads to old default might be blocked.
2277 if remote_branch not in [DEFAULT_OLD_BRANCH, DEFAULT_NEW_BRANCH]:
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002278 DieWithError(str(e), change_desc)
2279
Josip Sokcevicb631a882021-01-06 18:18:10 +00002280 project_head = gerrit_util.GetProjectHead(self._gerrit_host,
2281 self.GetGerritProject())
2282 if project_head == branch:
2283 DieWithError(str(e), change_desc)
2284 branch = project_head
2285
2286 print("WARNING: Fetching remote state and retrying upload to default "
2287 "branch...")
2288 RunGit(['fetch', '--prune', remote])
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002289 options.edit_description = False
2290 options.force = True
2291 try:
Josip Sokcevicb631a882021-01-06 18:18:10 +00002292 self._CMDUploadChange(options, git_diff_args, custom_cl_base,
2293 change_desc, branch)
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002294 except GitPushError as e:
2295 DieWithError(str(e), change_desc)
2296
2297 def _CMDUploadChange(self, options, git_diff_args, custom_cl_base,
Josip Sokcevicb631a882021-01-06 18:18:10 +00002298 change_desc, branch):
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002299 """Upload the current branch to Gerrit."""
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002300 if options.squash:
tandrii16e0b4e2016-06-07 10:34:28 -07002301 self._GerritCommitMsgHookCheck(offer_removal=not options.force)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002302 if self.GetIssue():
Josipe827b0f2020-01-30 00:07:20 +00002303 # User requested to change description
2304 if options.edit_description:
Josipe827b0f2020-01-30 00:07:20 +00002305 change_desc.prompt()
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002306 change_id = self._GetChangeDetail()['change_id']
Edward Lemur5a644f82020-03-18 16:44:57 +00002307 change_desc.ensure_change_id(change_id)
Aaron Gableb56ad332017-01-06 15:24:31 -08002308 else: # if not self.GetIssue()
Gavin Mak68e6cf32021-01-25 18:24:08 +00002309 if not options.force and not options.message_file:
Anthony Polito8b955342019-09-24 19:01:36 +00002310 change_desc.prompt()
Andrii Shyshkalov8c90d032017-04-19 21:27:26 +02002311 change_ids = git_footers.get_footer_change_id(change_desc.description)
Edward Lemur5a644f82020-03-18 16:44:57 +00002312 if len(change_ids) == 1:
2313 change_id = change_ids[0]
2314 else:
2315 change_id = GenerateGerritChangeId(change_desc.description)
2316 change_desc.ensure_change_id(change_id)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002317
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +00002318 if options.preserve_tryjobs:
2319 change_desc.set_preserve_tryjobs()
Robert Iannuccidb02dd02017-04-19 12:18:20 -07002320
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002321 remote, upstream_branch = self.FetchUpstreamTuple(self.GetBranch())
Edward Lemur5a644f82020-03-18 16:44:57 +00002322 parent = self._ComputeParent(
2323 remote, upstream_branch, custom_cl_base, options.force, change_desc)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002324 tree = RunGit(['rev-parse', 'HEAD:']).strip()
Edward Lemur1773f372020-02-22 00:27:14 +00002325 with gclient_utils.temporary_file() as desc_tempfile:
2326 gclient_utils.FileWrite(desc_tempfile, change_desc.description)
2327 ref_to_push = RunGit(
2328 ['commit-tree', tree, '-p', parent, '-F', desc_tempfile]).strip()
Anthony Polito8b955342019-09-24 19:01:36 +00002329 else: # if not options.squash
Gregory Nisbet48d9e1e2021-04-15 23:35:54 +00002330 if options.no_add_changeid:
2331 pass
2332 else: # adding Change-Ids is okay.
2333 if not git_footers.get_footer_change_id(change_desc.description):
2334 DownloadGerritHook(False)
2335 change_desc.set_description(
2336 self._AddChangeIdToCommitMessage(change_desc.description,
2337 git_diff_args))
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002338 ref_to_push = 'HEAD'
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002339 # For no-squash mode, we assume the remote called "origin" is the one we
2340 # want. It is not worthwhile to support different workflows for
2341 # no-squash mode.
2342 parent = 'origin/%s' % branch
Gregory Nisbet48d9e1e2021-04-15 23:35:54 +00002343 # attempt to extract the changeid from the current description
2344 # fail informatively if not possible.
2345 change_id_candidates = git_footers.get_footer_change_id(
2346 change_desc.description)
2347 if not change_id_candidates:
2348 DieWithError("Unable to extract change-id from message.")
2349 change_id = change_id_candidates[0]
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002350
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +00002351 SaveDescriptionBackup(change_desc)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002352 commits = RunGitSilent(['rev-list', '%s..%s' % (parent,
2353 ref_to_push)]).splitlines()
2354 if len(commits) > 1:
2355 print('WARNING: This will upload %d commits. Run the following command '
2356 'to see which commits will be uploaded: ' % len(commits))
2357 print('git log %s..%s' % (parent, ref_to_push))
2358 print('You can also use `git squash-branch` to squash these into a '
2359 'single commit.')
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002360 confirm_or_exit(action='upload')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002361
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00002362 reviewers = sorted(change_desc.get_reviewers())
Edward Lemur4508b422019-10-03 21:56:35 +00002363 cc = []
2364 # Add CCs from WATCHLISTS and rietveld.cc git config unless this is
2365 # the initial upload, the CL is private, or auto-CCing has ben disabled.
2366 if not (self.GetIssue() or options.private or options.no_autocc):
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00002367 cc = self.GetCCList().split(',')
Gavin Makb1c08f62021-04-01 18:05:58 +00002368 if len(cc) > 100:
2369 lsc = ('https://chromium.googlesource.com/chromium/src/+/HEAD/docs/'
2370 'process/lsc/lsc_workflow.md')
2371 print('WARNING: This will auto-CC %s users.' % len(cc))
2372 print('LSC may be more appropriate: %s' % lsc)
2373 print('You can also use the --no-autocc flag to disable auto-CC.')
2374 confirm_or_exit(action='continue')
Edward Lemur4508b422019-10-03 21:56:35 +00002375 # Add cc's from the --cc flag.
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00002376 if options.cc:
2377 cc.extend(options.cc)
Edward Lemur79d4f992019-11-11 23:49:02 +00002378 cc = [email.strip() for email in cc if email.strip()]
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00002379 if change_desc.get_cced():
2380 cc.extend(change_desc.get_cced())
Edward Lesmeseeca9c62020-11-20 00:00:17 +00002381 if self.GetGerritHost() == 'chromium-review.googlesource.com':
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00002382 valid_accounts = set(reviewers + cc)
2383 # TODO(crbug/877717): relax this for all hosts.
2384 else:
2385 valid_accounts = gerrit_util.ValidAccounts(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00002386 self.GetGerritHost(), reviewers + cc)
Andrii Shyshkalovf170af42018-10-30 07:00:44 +00002387 logging.info('accounts %s are recognized, %s invalid',
2388 sorted(valid_accounts),
2389 set(reviewers + cc).difference(set(valid_accounts)))
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00002390
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00002391 # Extra options that can be specified at push time. Doc:
2392 # https://gerrit-review.googlesource.com/Documentation/user-upload.html
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002393 refspec_opts = []
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02002394
Aaron Gable844cf292017-06-28 11:32:59 -07002395 # By default, new changes are started in WIP mode, and subsequent patchsets
2396 # don't send email. At any time, passing --send-mail will mark the change
2397 # ready and send email for that particular patch.
Aaron Gableafd52772017-06-27 16:40:10 -07002398 if options.send_mail:
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002399 refspec_opts.append('ready')
2400 refspec_opts.append('notify=ALL')
Jamie Madill276da0b2018-04-27 14:41:20 -04002401 elif not self.GetIssue() and options.squash:
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002402 refspec_opts.append('wip')
Aaron Gableafd52772017-06-27 16:40:10 -07002403 else:
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002404 refspec_opts.append('notify=NONE')
Aaron Gable70f4e242017-06-26 10:45:59 -07002405
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02002406 # TODO(tandrii): options.message should be posted as a comment
Aaron Gablee5adf612017-07-14 10:43:58 -07002407 # if --send-mail is set on non-initial upload as Rietveld used to do it.
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02002408
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002409 # Set options.title in case user was prompted in _GetTitleForUpload and
2410 # _CMDUploadChange needs to be called again.
2411 options.title = self._GetTitleForUpload(options)
2412 if options.title:
Nick Carter8692b182017-11-06 16:30:38 -08002413 # Punctuation and whitespace in |title| must be percent-encoded.
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002414 refspec_opts.append(
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002415 'm=' + gerrit_util.PercentEncodeForGitRef(options.title))
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00002416
agablec6787972016-09-09 16:13:34 -07002417 if options.private:
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002418 refspec_opts.append('private')
agablec6787972016-09-09 16:13:34 -07002419
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00002420 for r in sorted(reviewers):
2421 if r in valid_accounts:
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002422 refspec_opts.append('r=%s' % r)
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00002423 reviewers.remove(r)
2424 else:
2425 # TODO(tandrii): this should probably be a hard failure.
2426 print('WARNING: reviewer %s doesn\'t have a Gerrit account, skipping'
2427 % r)
2428 for c in sorted(cc):
2429 # refspec option will be rejected if cc doesn't correspond to an
2430 # account, even though REST call to add such arbitrary cc may succeed.
2431 if c in valid_accounts:
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002432 refspec_opts.append('cc=%s' % c)
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00002433 cc.remove(c)
2434
rmistry9eadede2016-09-19 11:22:43 -07002435 if options.topic:
2436 # Documentation on Gerrit topics is here:
2437 # https://gerrit-review.googlesource.com/Documentation/user-upload.html#topic
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002438 refspec_opts.append('topic=%s' % options.topic)
rmistry9eadede2016-09-19 11:22:43 -07002439
Edward Lemur687ca902018-12-05 02:30:30 +00002440 if options.enable_auto_submit:
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002441 refspec_opts.append('l=Auto-Submit+1')
Edward Lesmes10c3dd62021-02-08 21:13:57 +00002442 if options.set_bot_commit:
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002443 refspec_opts.append('l=Bot-Commit+1')
Edward Lemur687ca902018-12-05 02:30:30 +00002444 if options.use_commit_queue:
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002445 refspec_opts.append('l=Commit-Queue+2')
Edward Lemur687ca902018-12-05 02:30:30 +00002446 elif options.cq_dry_run:
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002447 refspec_opts.append('l=Commit-Queue+1')
Edward Lemur687ca902018-12-05 02:30:30 +00002448
2449 if change_desc.get_reviewers(tbr_only=True):
2450 score = gerrit_util.GetCodeReviewTbrScore(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00002451 self.GetGerritHost(),
2452 self.GetGerritProject())
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002453 refspec_opts.append('l=Code-Review+%s' % score)
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00002454
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08002455 # Gerrit sorts hashtags, so order is not important.
Nodir Turakulov23b82142017-11-16 11:04:25 -08002456 hashtags = {change_desc.sanitize_hash_tag(t) for t in options.hashtags}
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08002457 if not self.GetIssue():
Nodir Turakulov23b82142017-11-16 11:04:25 -08002458 hashtags.update(change_desc.get_hash_tags())
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002459 refspec_opts += ['hashtag=%s' % t for t in sorted(hashtags)]
2460
2461 refspec_suffix = ''
2462 if refspec_opts:
2463 refspec_suffix = '%' + ','.join(refspec_opts)
2464 assert ' ' not in refspec_suffix, (
2465 'spaces not allowed in refspec: "%s"' % refspec_suffix)
2466 refspec = '%s:refs/for/%s%s' % (ref_to_push, branch, refspec_suffix)
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00002467
Edward Lemur1b52d872019-05-09 21:12:12 +00002468 git_push_metadata = {
Edward Lesmeseeca9c62020-11-20 00:00:17 +00002469 'gerrit_host': self.GetGerritHost(),
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002470 'title': options.title or '<untitled>',
Edward Lemur1b52d872019-05-09 21:12:12 +00002471 'change_id': change_id,
2472 'description': change_desc.description,
2473 }
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +00002474
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002475 push_stdout = self._RunGitPushWithTraces(refspec, refspec_opts,
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +00002476 git_push_metadata,
2477 options.push_options)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002478
2479 if options.squash:
Aaron Gable289b4312017-09-13 14:06:16 -07002480 regex = re.compile(r'remote:\s+https?://[\w\-\.\+\/#]*/(\d+)\s.*')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002481 change_numbers = [m.group(1)
2482 for m in map(regex.match, push_stdout.splitlines())
2483 if m]
2484 if len(change_numbers) != 1:
2485 DieWithError(
2486 ('Created|Updated %d issues on Gerrit, but only 1 expected.\n'
Christopher Lamf732cd52017-01-24 12:40:11 +11002487 'Change-Id: %s') % (len(change_numbers), change_id), change_desc)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002488 self.SetIssue(change_numbers[0])
tandrii5d48c322016-08-18 16:19:37 -07002489 self._GitSetBranchConfigValue('gerritsquashhash', ref_to_push)
tandrii88189772016-09-29 04:29:57 -07002490
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00002491 if self.GetIssue() and (reviewers or cc):
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00002492 # GetIssue() is not set in case of non-squash uploads according to tests.
Aaron Gable6e7ddb62020-05-27 22:23:29 +00002493 # TODO(crbug.com/751901): non-squash uploads in git cl should be removed.
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00002494 gerrit_util.AddReviewers(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00002495 self.GetGerritHost(),
Andrii Shyshkalovd06cc782018-08-23 17:24:19 +00002496 self._GerritChangeIdentifier(),
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00002497 reviewers, cc,
2498 notify=bool(options.send_mail))
Aaron Gable6dadfbf2017-05-09 14:27:58 -07002499
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002500 return 0
2501
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002502 def _ComputeParent(self, remote, upstream_branch, custom_cl_base, force,
2503 change_desc):
2504 """Computes parent of the generated commit to be uploaded to Gerrit.
2505
2506 Returns revision or a ref name.
2507 """
2508 if custom_cl_base:
2509 # Try to avoid creating additional unintended CLs when uploading, unless
2510 # user wants to take this risk.
2511 local_ref_of_target_remote = self.GetRemoteBranch()[1]
2512 code, _ = RunGitWithCode(['merge-base', '--is-ancestor', custom_cl_base,
2513 local_ref_of_target_remote])
2514 if code == 1:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002515 print('\nWARNING: Manually specified base of this CL `%s` '
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002516 'doesn\'t seem to belong to target remote branch `%s`.\n\n'
2517 'If you proceed with upload, more than 1 CL may be created by '
2518 'Gerrit as a result, in turn confusing or crashing git cl.\n\n'
2519 'If you are certain that specified base `%s` has already been '
2520 'uploaded to Gerrit as another CL, you may proceed.\n' %
2521 (custom_cl_base, local_ref_of_target_remote, custom_cl_base))
2522 if not force:
2523 confirm_or_exit(
2524 'Do you take responsibility for cleaning up potential mess '
2525 'resulting from proceeding with upload?',
2526 action='upload')
2527 return custom_cl_base
2528
Aaron Gablef97e33d2017-03-30 15:44:27 -07002529 if remote != '.':
2530 return self.GetCommonAncestorWithUpstream()
2531
2532 # If our upstream branch is local, we base our squashed commit on its
2533 # squashed version.
2534 upstream_branch_name = scm.GIT.ShortBranchName(upstream_branch)
2535
Aaron Gablef97e33d2017-03-30 15:44:27 -07002536 if upstream_branch_name == 'master':
Aaron Gable0bbd1c22017-05-08 14:37:08 -07002537 return self.GetCommonAncestorWithUpstream()
Glen Robertson7d98e222020-08-27 17:53:11 +00002538 if upstream_branch_name == 'main':
2539 return self.GetCommonAncestorWithUpstream()
Aaron Gablef97e33d2017-03-30 15:44:27 -07002540
2541 # Check the squashed hash of the parent.
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002542 # TODO(tandrii): consider checking parent change in Gerrit and using its
2543 # hash if tree hash of latest parent revision (patchset) in Gerrit matches
2544 # the tree hash of the parent branch. The upside is less likely bogus
2545 # requests to reupload parent change just because it's uploadhash is
2546 # missing, yet the downside likely exists, too (albeit unknown to me yet).
Edward Lesmesa680c232020-03-31 18:26:44 +00002547 parent = scm.GIT.GetBranchConfig(
2548 settings.GetRoot(), upstream_branch_name, 'gerritsquashhash')
Aaron Gablef97e33d2017-03-30 15:44:27 -07002549 # Verify that the upstream branch has been uploaded too, otherwise
2550 # Gerrit will create additional CLs when uploading.
2551 if not parent or (RunGitSilent(['rev-parse', upstream_branch + ':']) !=
2552 RunGitSilent(['rev-parse', parent + ':'])):
2553 DieWithError(
2554 '\nUpload upstream branch %s first.\n'
2555 'It is likely that this branch has been rebased since its last '
2556 'upload, so you just need to upload it again.\n'
2557 '(If you uploaded it with --no-squash, then branch dependencies '
2558 'are not supported, and you should reupload with --squash.)'
2559 % upstream_branch_name,
2560 change_desc)
2561 return parent
2562
Edward Lemura12175c2020-03-09 16:58:26 +00002563 def _AddChangeIdToCommitMessage(self, log_desc, args):
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00002564 """Re-commits using the current message, assumes the commit hook is in
2565 place.
2566 """
Edward Lemura12175c2020-03-09 16:58:26 +00002567 RunGit(['commit', '--amend', '-m', log_desc])
Andrii Shyshkalovb07575f2018-10-16 06:16:21 +00002568 new_log_desc = _create_description_from_log(args)
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00002569 if git_footers.get_footer_change_id(new_log_desc):
vapiera7fbd5a2016-06-16 09:17:49 -07002570 print('git-cl: Added Change-Id to commit message.')
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00002571 return new_log_desc
2572 else:
tandrii@chromium.orgb067ec52016-05-31 15:24:44 +00002573 DieWithError('ERROR: Gerrit commit-msg hook not installed.')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002574
tandriie113dfd2016-10-11 10:20:12 -07002575 def CannotTriggerTryJobReason(self):
tandrii8c5a3532016-11-04 07:52:02 -07002576 try:
2577 data = self._GetChangeDetail()
Aaron Gablea45ee112016-11-22 15:14:38 -08002578 except GerritChangeNotExists:
2579 return 'Gerrit doesn\'t know about your change %s' % self.GetIssue()
tandrii8c5a3532016-11-04 07:52:02 -07002580
2581 if data['status'] in ('ABANDONED', 'MERGED'):
2582 return 'CL %s is closed' % self.GetIssue()
2583
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002584 def GetGerritChange(self, patchset=None):
2585 """Returns a buildbucket.v2.GerritChange message for the current issue."""
Edward Lemur79d4f992019-11-11 23:49:02 +00002586 host = urllib.parse.urlparse(self.GetCodereviewServer()).hostname
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002587 issue = self.GetIssue()
Edward Lemur2c210a42019-09-16 23:58:35 +00002588 patchset = int(patchset or self.GetPatchset())
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002589 data = self._GetChangeDetail(['ALL_REVISIONS'])
2590
2591 assert host and issue and patchset, 'CL must be uploaded first'
2592
2593 has_patchset = any(
2594 int(revision_data['_number']) == patchset
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00002595 for revision_data in data['revisions'].values())
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002596 if not has_patchset:
Aaron Gablea45ee112016-11-22 15:14:38 -08002597 raise Exception('Patchset %d is not known in Gerrit change %d' %
tandrii8c5a3532016-11-04 07:52:02 -07002598 (patchset, self.GetIssue()))
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002599
tandrii8c5a3532016-11-04 07:52:02 -07002600 return {
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002601 'host': host,
2602 'change': issue,
2603 'project': data['project'],
2604 'patchset': patchset,
tandrii8c5a3532016-11-04 07:52:02 -07002605 }
tandriie113dfd2016-10-11 10:20:12 -07002606
tandriide281ae2016-10-12 06:02:30 -07002607 def GetIssueOwner(self):
tandrii8c5a3532016-11-04 07:52:02 -07002608 return self._GetChangeDetail(['DETAILED_ACCOUNTS'])['owner']['email']
tandriide281ae2016-10-12 06:02:30 -07002609
Edward Lemur707d70b2018-02-07 00:50:14 +01002610 def GetReviewers(self):
2611 details = self._GetChangeDetail(['DETAILED_ACCOUNTS'])
Mohamed Heikal171c0742018-11-09 20:38:51 +00002612 return [r['email'] for r in details['reviewers'].get('REVIEWER', [])]
Edward Lemur707d70b2018-02-07 00:50:14 +01002613
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002614
Lei Zhang8a0efc12020-08-05 19:58:45 +00002615def _get_bug_line_values(default_project_prefix, bugs):
2616 """Given default_project_prefix and comma separated list of bugs, yields bug
2617 line values.
tandriif9aefb72016-07-01 09:06:51 -07002618
2619 Each bug can be either:
Lei Zhang8a0efc12020-08-05 19:58:45 +00002620 * a number, which is combined with default_project_prefix
tandriif9aefb72016-07-01 09:06:51 -07002621 * string, which is left as is.
2622
2623 This function may produce more than one line, because bugdroid expects one
2624 project per line.
2625
Lei Zhang8a0efc12020-08-05 19:58:45 +00002626 >>> list(_get_bug_line_values('v8:', '123,chromium:789'))
tandriif9aefb72016-07-01 09:06:51 -07002627 ['v8:123', 'chromium:789']
2628 """
2629 default_bugs = []
2630 others = []
2631 for bug in bugs.split(','):
2632 bug = bug.strip()
2633 if bug:
2634 try:
2635 default_bugs.append(int(bug))
2636 except ValueError:
2637 others.append(bug)
2638
2639 if default_bugs:
2640 default_bugs = ','.join(map(str, default_bugs))
Lei Zhang8a0efc12020-08-05 19:58:45 +00002641 if default_project_prefix:
2642 if not default_project_prefix.endswith(':'):
2643 default_project_prefix += ':'
2644 yield '%s%s' % (default_project_prefix, default_bugs)
tandriif9aefb72016-07-01 09:06:51 -07002645 else:
2646 yield default_bugs
2647 for other in sorted(others):
2648 # Don't bother finding common prefixes, CLs with >2 bugs are very very rare.
2649 yield other
2650
2651
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00002652class ChangeDescription(object):
2653 """Contains a parsed form of the change description."""
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00002654 R_LINE = r'^[ \t]*(TBR|R)[ \t]*=[ \t]*(.*?)[ \t]*$'
bradnelsond975b302016-10-23 12:20:23 -07002655 CC_LINE = r'^[ \t]*(CC)[ \t]*=[ \t]*(.*?)[ \t]*$'
Aaron Gable3a16ed12017-03-23 10:51:55 -07002656 BUG_LINE = r'^[ \t]*(?:(BUG)[ \t]*=|Bug:)[ \t]*(.*?)[ \t]*$'
Dan Beamd8b04ca2019-10-10 21:23:26 +00002657 FIXED_LINE = r'^[ \t]*Fixed[ \t]*:[ \t]*(.*?)[ \t]*$'
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01002658 CHERRY_PICK_LINE = r'^\(cherry picked from commit [a-fA-F0-9]{40}\)$'
Nodir Turakulov23b82142017-11-16 11:04:25 -08002659 STRIP_HASH_TAG_PREFIX = r'^(\s*(revert|reland)( "|:)?\s*)*'
2660 BRACKET_HASH_TAG = r'\s*\[([^\[\]]+)\]'
Anthony Polito02b5af32019-12-02 19:49:47 +00002661 COLON_SEPARATED_HASH_TAG = r'^([a-zA-Z0-9_\- ]+):($|[^:])'
Nodir Turakulov23b82142017-11-16 11:04:25 -08002662 BAD_HASH_TAG_CHUNK = r'[^a-zA-Z0-9]+'
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00002663
Dan Beamd8b04ca2019-10-10 21:23:26 +00002664 def __init__(self, description, bug=None, fixed=None):
agable@chromium.org42c20792013-09-12 17:34:49 +00002665 self._description_lines = (description or '').strip().splitlines()
Anthony Polito8b955342019-09-24 19:01:36 +00002666 if bug:
2667 regexp = re.compile(self.BUG_LINE)
2668 prefix = settings.GetBugPrefix()
2669 if not any((regexp.match(line) for line in self._description_lines)):
2670 values = list(_get_bug_line_values(prefix, bug))
2671 self.append_footer('Bug: %s' % ', '.join(values))
Dan Beamd8b04ca2019-10-10 21:23:26 +00002672 if fixed:
2673 regexp = re.compile(self.FIXED_LINE)
2674 prefix = settings.GetBugPrefix()
2675 if not any((regexp.match(line) for line in self._description_lines)):
2676 values = list(_get_bug_line_values(prefix, fixed))
2677 self.append_footer('Fixed: %s' % ', '.join(values))
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002678
agable@chromium.org42c20792013-09-12 17:34:49 +00002679 @property # www.logilab.org/ticket/89786
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08002680 def description(self): # pylint: disable=method-hidden
agable@chromium.org42c20792013-09-12 17:34:49 +00002681 return '\n'.join(self._description_lines)
2682
2683 def set_description(self, desc):
2684 if isinstance(desc, basestring):
2685 lines = desc.splitlines()
2686 else:
2687 lines = [line.rstrip() for line in desc]
2688 while lines and not lines[0]:
2689 lines.pop(0)
2690 while lines and not lines[-1]:
2691 lines.pop(-1)
2692 self._description_lines = lines
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002693
Edward Lemur5a644f82020-03-18 16:44:57 +00002694 def ensure_change_id(self, change_id):
2695 description = self.description
2696 footer_change_ids = git_footers.get_footer_change_id(description)
2697 # Make sure that the Change-Id in the description matches the given one.
2698 if footer_change_ids != [change_id]:
2699 if footer_change_ids:
2700 # Remove any existing Change-Id footers since they don't match the
2701 # expected change_id footer.
2702 description = git_footers.remove_footer(description, 'Change-Id')
2703 print('WARNING: Change-Id has been set to %s. Use `git cl issue 0` '
2704 'if you want to set a new one.')
2705 # Add the expected Change-Id footer.
2706 description = git_footers.add_footer_change_id(description, change_id)
2707 self.set_description(description)
2708
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00002709 def update_reviewers(self, reviewers, tbrs):
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002710 """Rewrites the R=/TBR= line(s) as a single line each.
2711
2712 Args:
2713 reviewers (list(str)) - list of additional emails to use for reviewers.
2714 tbrs (list(str)) - list of additional emails to use for TBRs.
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002715 """
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00002716 if not reviewers and not tbrs:
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002717 return
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002718
2719 reviewers = set(reviewers)
2720 tbrs = set(tbrs)
2721 LOOKUP = {
2722 'TBR': tbrs,
2723 'R': reviewers,
2724 }
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002725
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002726 # Get the set of R= and TBR= lines and remove them from the description.
agable@chromium.org42c20792013-09-12 17:34:49 +00002727 regexp = re.compile(self.R_LINE)
2728 matches = [regexp.match(line) for line in self._description_lines]
2729 new_desc = [l for i, l in enumerate(self._description_lines)
2730 if not matches[i]]
2731 self.set_description(new_desc)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002732
agable@chromium.org42c20792013-09-12 17:34:49 +00002733 # Construct new unified R= and TBR= lines.
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002734
2735 # First, update tbrs/reviewers with names from the R=/TBR= lines (if any).
agable@chromium.org42c20792013-09-12 17:34:49 +00002736 for match in matches:
2737 if not match:
2738 continue
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002739 LOOKUP[match.group(1)].update(cleanup_list([match.group(2).strip()]))
2740
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002741 # If any folks ended up in both groups, remove them from tbrs.
2742 tbrs -= reviewers
Robert Iannuccif2708bd2017-04-17 15:49:02 -07002743
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002744 new_r_line = 'R=' + ', '.join(sorted(reviewers)) if reviewers else None
2745 new_tbr_line = 'TBR=' + ', '.join(sorted(tbrs)) if tbrs else None
agable@chromium.org42c20792013-09-12 17:34:49 +00002746
2747 # Put the new lines in the description where the old first R= line was.
2748 line_loc = next((i for i, match in enumerate(matches) if match), -1)
2749 if 0 <= line_loc < len(self._description_lines):
2750 if new_tbr_line:
2751 self._description_lines.insert(line_loc, new_tbr_line)
2752 if new_r_line:
2753 self._description_lines.insert(line_loc, new_r_line)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002754 else:
agable@chromium.org42c20792013-09-12 17:34:49 +00002755 if new_r_line:
2756 self.append_footer(new_r_line)
2757 if new_tbr_line:
2758 self.append_footer(new_tbr_line)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002759
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +00002760 def set_preserve_tryjobs(self):
2761 """Ensures description footer contains 'Cq-Do-Not-Cancel-Tryjobs: true'."""
2762 footers = git_footers.parse_footers(self.description)
2763 for v in footers.get('Cq-Do-Not-Cancel-Tryjobs', []):
2764 if v.lower() == 'true':
2765 return
2766 self.append_footer('Cq-Do-Not-Cancel-Tryjobs: true')
2767
Anthony Polito8b955342019-09-24 19:01:36 +00002768 def prompt(self):
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002769 """Asks the user to update the description."""
agable@chromium.org42c20792013-09-12 17:34:49 +00002770 self.set_description([
2771 '# Enter a description of the change.',
2772 '# This will be displayed on the codereview site.',
2773 '# The first line will also be used as the subject of the review.',
alancutter@chromium.orgbd1073e2013-06-01 00:34:38 +00002774 '#--------------------This line is 72 characters long'
agable@chromium.org42c20792013-09-12 17:34:49 +00002775 '--------------------',
2776 ] + self._description_lines)
Dan Beamd8b04ca2019-10-10 21:23:26 +00002777 bug_regexp = re.compile(self.BUG_LINE)
2778 fixed_regexp = re.compile(self.FIXED_LINE)
Jonas Termansend0f79112019-03-22 15:28:26 +00002779 prefix = settings.GetBugPrefix()
Sigurd Schneider8630bb12020-11-11 14:02:49 +00002780 has_issue = lambda l: bug_regexp.match(l) or fixed_regexp.match(l)
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00002781
Dan Beamd8b04ca2019-10-10 21:23:26 +00002782 if not any((has_issue(line) for line in self._description_lines)):
Anthony Polito8b955342019-09-24 19:01:36 +00002783 self.append_footer('Bug: %s' % prefix)
tandriif9aefb72016-07-01 09:06:51 -07002784
Bruce Dawsonfc487042020-10-27 19:11:37 +00002785 print('Waiting for editor...')
agable@chromium.org42c20792013-09-12 17:34:49 +00002786 content = gclient_utils.RunEditor(self.description, True,
Edward Lemur79d4f992019-11-11 23:49:02 +00002787 git_editor=settings.GetGitEditor())
maruel@chromium.org0e0436a2011-10-25 13:32:41 +00002788 if not content:
2789 DieWithError('Running editor failed')
agable@chromium.org42c20792013-09-12 17:34:49 +00002790 lines = content.splitlines()
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002791
Bruce Dawson2377b012018-01-11 16:46:49 -08002792 # Strip off comments and default inserted "Bug:" line.
2793 clean_lines = [line.rstrip() for line in lines if not
Jonas Termansend0f79112019-03-22 15:28:26 +00002794 (line.startswith('#') or
2795 line.rstrip() == "Bug:" or
2796 line.rstrip() == "Bug: " + prefix)]
agable@chromium.org42c20792013-09-12 17:34:49 +00002797 if not clean_lines:
maruel@chromium.org0e0436a2011-10-25 13:32:41 +00002798 DieWithError('No CL description, aborting')
agable@chromium.org42c20792013-09-12 17:34:49 +00002799 self.set_description(clean_lines)
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00002800
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002801 def append_footer(self, line):
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002802 """Adds a footer line to the description.
2803
2804 Differentiates legacy "KEY=xxx" footers (used to be called tags) and
2805 Gerrit's footers in the form of "Footer-Key: footer any value" and ensures
2806 that Gerrit footers are always at the end.
2807 """
2808 parsed_footer_line = git_footers.parse_footer(line)
2809 if parsed_footer_line:
2810 # Line is a gerrit footer in the form: Footer-Key: any value.
2811 # Thus, must be appended observing Gerrit footer rules.
2812 self.set_description(
2813 git_footers.add_footer(self.description,
2814 key=parsed_footer_line[0],
2815 value=parsed_footer_line[1]))
2816 return
2817
2818 if not self._description_lines:
2819 self._description_lines.append(line)
2820 return
2821
2822 top_lines, gerrit_footers, _ = git_footers.split_footers(self.description)
2823 if gerrit_footers:
2824 # git_footers.split_footers ensures that there is an empty line before
2825 # actual (gerrit) footers, if any. We have to keep it that way.
2826 assert top_lines and top_lines[-1] == ''
2827 top_lines, separator = top_lines[:-1], top_lines[-1:]
2828 else:
2829 separator = [] # No need for separator if there are no gerrit_footers.
2830
2831 prev_line = top_lines[-1] if top_lines else ''
2832 if (not presubmit_support.Change.TAG_LINE_RE.match(prev_line) or
2833 not presubmit_support.Change.TAG_LINE_RE.match(line)):
2834 top_lines.append('')
2835 top_lines.append(line)
2836 self._description_lines = top_lines + separator + gerrit_footers
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00002837
tandrii99a72f22016-08-17 14:33:24 -07002838 def get_reviewers(self, tbr_only=False):
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002839 """Retrieves the list of reviewers."""
agable@chromium.org42c20792013-09-12 17:34:49 +00002840 matches = [re.match(self.R_LINE, line) for line in self._description_lines]
tandrii99a72f22016-08-17 14:33:24 -07002841 reviewers = [match.group(2).strip()
2842 for match in matches
2843 if match and (not tbr_only or match.group(1).upper() == 'TBR')]
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002844 return cleanup_list(reviewers)
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00002845
bradnelsond975b302016-10-23 12:20:23 -07002846 def get_cced(self):
2847 """Retrieves the list of reviewers."""
2848 matches = [re.match(self.CC_LINE, line) for line in self._description_lines]
2849 cced = [match.group(2).strip() for match in matches if match]
2850 return cleanup_list(cced)
2851
Nodir Turakulov23b82142017-11-16 11:04:25 -08002852 def get_hash_tags(self):
2853 """Extracts and sanitizes a list of Gerrit hashtags."""
2854 subject = (self._description_lines or ('',))[0]
2855 subject = re.sub(
2856 self.STRIP_HASH_TAG_PREFIX, '', subject, flags=re.IGNORECASE)
2857
2858 tags = []
2859 start = 0
2860 bracket_exp = re.compile(self.BRACKET_HASH_TAG)
2861 while True:
2862 m = bracket_exp.match(subject, start)
2863 if not m:
2864 break
2865 tags.append(self.sanitize_hash_tag(m.group(1)))
2866 start = m.end()
2867
2868 if not tags:
2869 # Try "Tag: " prefix.
2870 m = re.match(self.COLON_SEPARATED_HASH_TAG, subject)
2871 if m:
2872 tags.append(self.sanitize_hash_tag(m.group(1)))
2873 return tags
2874
2875 @classmethod
2876 def sanitize_hash_tag(cls, tag):
2877 """Returns a sanitized Gerrit hash tag.
2878
2879 A sanitized hashtag can be used as a git push refspec parameter value.
2880 """
2881 return re.sub(cls.BAD_HASH_TAG_CHUNK, '-', tag).strip('-').lower()
2882
maruel@chromium.orge52678e2013-04-26 18:34:44 +00002883
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002884def FindCodereviewSettingsFile(filename='codereview.settings'):
2885 """Finds the given file starting in the cwd and going up.
2886
2887 Only looks up to the top of the repository unless an
2888 'inherit-review-settings-ok' file exists in the root of the repository.
2889 """
2890 inherit_ok_file = 'inherit-review-settings-ok'
2891 cwd = os.getcwd()
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00002892 root = settings.GetRoot()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002893 if os.path.isfile(os.path.join(root, inherit_ok_file)):
2894 root = '/'
2895 while True:
2896 if filename in os.listdir(cwd):
2897 if os.path.isfile(os.path.join(cwd, filename)):
2898 return open(os.path.join(cwd, filename))
2899 if cwd == root:
2900 break
2901 cwd = os.path.dirname(cwd)
2902
2903
2904def LoadCodereviewSettingsFromFile(fileobj):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002905 """Parses a codereview.settings file and updates hooks."""
maruel@chromium.org99ac1c52012-01-16 14:52:12 +00002906 keyvals = gclient_utils.ParseCodereviewSettingsContent(fileobj.read())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002907
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002908 def SetProperty(name, setting, unset_error_ok=False):
2909 fullname = 'rietveld.' + name
2910 if setting in keyvals:
2911 RunGit(['config', fullname, keyvals[setting]])
2912 else:
2913 RunGit(['config', '--unset-all', fullname], error_ok=unset_error_ok)
2914
tandrii48df5812016-10-17 03:55:37 -07002915 if not keyvals.get('GERRIT_HOST', False):
2916 SetProperty('server', 'CODE_REVIEW_SERVER')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002917 # Only server setting is required. Other settings can be absent.
2918 # In that case, we ignore errors raised during option deletion attempt.
2919 SetProperty('cc', 'CC_LIST', unset_error_ok=True)
2920 SetProperty('tree-status-url', 'STATUS', unset_error_ok=True)
2921 SetProperty('viewvc-url', 'VIEW_VC', unset_error_ok=True)
rmistry@google.com90752582014-01-14 21:04:50 +00002922 SetProperty('bug-prefix', 'BUG_PREFIX', unset_error_ok=True)
thestig@chromium.org44202a22014-03-11 19:22:18 +00002923 SetProperty('cpplint-regex', 'LINT_REGEX', unset_error_ok=True)
2924 SetProperty('cpplint-ignore-regex', 'LINT_IGNORE_REGEX', unset_error_ok=True)
rmistry@google.com5626a922015-02-26 14:03:30 +00002925 SetProperty('run-post-upload-hook', 'RUN_POST_UPLOAD_HOOK',
2926 unset_error_ok=True)
Jamie Madilldc4d19e2019-10-24 21:50:02 +00002927 SetProperty(
2928 'format-full-by-default', 'FORMAT_FULL_BY_DEFAULT', unset_error_ok=True)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002929
ukai@chromium.org7044efc2013-11-28 01:51:21 +00002930 if 'GERRIT_HOST' in keyvals:
ukai@chromium.orge8077812012-02-03 03:41:46 +00002931 RunGit(['config', 'gerrit.host', keyvals['GERRIT_HOST']])
ukai@chromium.orge8077812012-02-03 03:41:46 +00002932
bauerb@chromium.org54b400c2016-01-14 10:08:25 +00002933 if 'GERRIT_SQUASH_UPLOADS' in keyvals:
Edward Lesmes4de54132020-05-05 19:41:33 +00002934 RunGit(['config', 'gerrit.squash-uploads',
2935 keyvals['GERRIT_SQUASH_UPLOADS']])
bauerb@chromium.org54b400c2016-01-14 10:08:25 +00002936
tandrii@chromium.org28253532016-04-14 13:46:56 +00002937 if 'GERRIT_SKIP_ENSURE_AUTHENTICATED' in keyvals:
shinyak@chromium.org00dbccd2016-04-15 07:24:43 +00002938 RunGit(['config', 'gerrit.skip-ensure-authenticated',
tandrii@chromium.org28253532016-04-14 13:46:56 +00002939 keyvals['GERRIT_SKIP_ENSURE_AUTHENTICATED']])
2940
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002941 if 'PUSH_URL_CONFIG' in keyvals and 'ORIGIN_URL_CONFIG' in keyvals:
Andrii Shyshkalov18975322017-01-25 16:44:13 +01002942 # should be of the form
2943 # PUSH_URL_CONFIG: url.ssh://gitrw.chromium.org.pushinsteadof
2944 # ORIGIN_URL_CONFIG: http://src.chromium.org/git
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002945 RunGit(['config', keyvals['PUSH_URL_CONFIG'],
2946 keyvals['ORIGIN_URL_CONFIG']])
2947
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002948
joshua.lock@intel.com426f69b2012-08-02 23:41:49 +00002949def urlretrieve(source, destination):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002950 """Downloads a network object to a local file, like urllib.urlretrieve.
2951
2952 This is necessary because urllib is broken for SSL connections via a proxy.
2953 """
joshua.lock@intel.com426f69b2012-08-02 23:41:49 +00002954 with open(destination, 'w') as f:
Edward Lemur79d4f992019-11-11 23:49:02 +00002955 f.write(urllib.request.urlopen(source).read())
joshua.lock@intel.com426f69b2012-08-02 23:41:49 +00002956
2957
ukai@chromium.org712d6102013-11-27 00:52:58 +00002958def hasSheBang(fname):
2959 """Checks fname is a #! script."""
2960 with open(fname) as f:
2961 return f.read(2).startswith('#!')
2962
2963
tandrii@chromium.org18630d62016-03-04 12:06:02 +00002964def DownloadGerritHook(force):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002965 """Downloads and installs a Gerrit commit-msg hook.
ukai@chromium.org78c4b982012-02-14 02:20:26 +00002966
2967 Args:
2968 force: True to update hooks. False to install hooks if not present.
2969 """
ukai@chromium.org712d6102013-11-27 00:52:58 +00002970 src = 'https://gerrit-review.googlesource.com/tools/hooks/commit-msg'
ukai@chromium.org78c4b982012-02-14 02:20:26 +00002971 dst = os.path.join(settings.GetRoot(), '.git', 'hooks', 'commit-msg')
2972 if not os.access(dst, os.X_OK):
2973 if os.path.exists(dst):
2974 if not force:
2975 return
ukai@chromium.org78c4b982012-02-14 02:20:26 +00002976 try:
joshua.lock@intel.com426f69b2012-08-02 23:41:49 +00002977 urlretrieve(src, dst)
ukai@chromium.org712d6102013-11-27 00:52:58 +00002978 if not hasSheBang(dst):
2979 DieWithError('Not a script: %s\n'
2980 'You need to download from\n%s\n'
2981 'into .git/hooks/commit-msg and '
2982 'chmod +x .git/hooks/commit-msg' % (dst, src))
ukai@chromium.org78c4b982012-02-14 02:20:26 +00002983 os.chmod(dst, stat.S_IRUSR | stat.S_IWUSR | stat.S_IXUSR)
2984 except Exception:
2985 if os.path.exists(dst):
2986 os.remove(dst)
ukai@chromium.org712d6102013-11-27 00:52:58 +00002987 DieWithError('\nFailed to download hooks.\n'
2988 'You need to download from\n%s\n'
2989 'into .git/hooks/commit-msg and '
2990 'chmod +x .git/hooks/commit-msg' % src)
ukai@chromium.org78c4b982012-02-14 02:20:26 +00002991
2992
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01002993class _GitCookiesChecker(object):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002994 """Provides facilities for validating and suggesting fixes to .gitcookies."""
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002995
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002996 _GOOGLESOURCE = 'googlesource.com'
2997
2998 def __init__(self):
2999 # Cached list of [host, identity, source], where source is either
3000 # .gitcookies or .netrc.
3001 self._all_hosts = None
3002
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003003 def ensure_configured_gitcookies(self):
3004 """Runs checks and suggests fixes to make git use .gitcookies from default
3005 path."""
3006 default = gerrit_util.CookiesAuthenticator.get_gitcookies_path()
3007 configured_path = RunGitSilent(
3008 ['config', '--global', 'http.cookiefile']).strip()
Andrii Shyshkalov1e250cd2017-05-10 15:39:31 +02003009 configured_path = os.path.expanduser(configured_path)
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003010 if configured_path:
3011 self._ensure_default_gitcookies_path(configured_path, default)
3012 else:
3013 self._configure_gitcookies_path(default)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003014
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003015 @staticmethod
3016 def _ensure_default_gitcookies_path(configured_path, default_path):
3017 assert configured_path
3018 if configured_path == default_path:
3019 print('git is already configured to use your .gitcookies from %s' %
3020 configured_path)
3021 return
3022
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003023 print('WARNING: You have configured custom path to .gitcookies: %s\n'
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003024 'Gerrit and other depot_tools expect .gitcookies at %s\n' %
3025 (configured_path, default_path))
3026
3027 if not os.path.exists(configured_path):
3028 print('However, your configured .gitcookies file is missing.')
3029 confirm_or_exit('Reconfigure git to use default .gitcookies?',
3030 action='reconfigure')
3031 RunGit(['config', '--global', 'http.cookiefile', default_path])
3032 return
3033
3034 if os.path.exists(default_path):
3035 print('WARNING: default .gitcookies file already exists %s' %
3036 default_path)
3037 DieWithError('Please delete %s manually and re-run git cl creds-check' %
3038 default_path)
3039
3040 confirm_or_exit('Move existing .gitcookies to default location?',
3041 action='move')
3042 shutil.move(configured_path, default_path)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003043 RunGit(['config', '--global', 'http.cookiefile', default_path])
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003044 print('Moved and reconfigured git to use .gitcookies from %s' %
3045 default_path)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003046
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003047 @staticmethod
3048 def _configure_gitcookies_path(default_path):
3049 netrc_path = gerrit_util.CookiesAuthenticator.get_netrc_path()
3050 if os.path.exists(netrc_path):
3051 print('You seem to be using outdated .netrc for git credentials: %s' %
3052 netrc_path)
3053 print('This tool will guide you through setting up recommended '
3054 '.gitcookies store for git credentials.\n'
3055 '\n'
3056 'IMPORTANT: If something goes wrong and you decide to go back, do:\n'
3057 ' git config --global --unset http.cookiefile\n'
3058 ' mv %s %s.backup\n\n' % (default_path, default_path))
3059 confirm_or_exit(action='setup .gitcookies')
3060 RunGit(['config', '--global', 'http.cookiefile', default_path])
3061 print('Configured git to use .gitcookies from %s' % default_path)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003062
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003063 def get_hosts_with_creds(self, include_netrc=False):
3064 if self._all_hosts is None:
3065 a = gerrit_util.CookiesAuthenticator()
3066 self._all_hosts = [
3067 (h, u, s)
3068 for h, u, s in itertools.chain(
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00003069 ((h, u, '.netrc') for h, (u, _, _) in a.netrc.hosts.items()),
3070 ((h, u, '.gitcookies') for h, (u, _) in a.gitcookies.items())
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003071 )
3072 if h.endswith(self._GOOGLESOURCE)
3073 ]
3074
3075 if include_netrc:
3076 return self._all_hosts
3077 return [(h, u, s) for h, u, s in self._all_hosts if s != '.netrc']
3078
3079 def print_current_creds(self, include_netrc=False):
3080 hosts = sorted(self.get_hosts_with_creds(include_netrc=include_netrc))
3081 if not hosts:
3082 print('No Git/Gerrit credentials found')
3083 return
Edward Lemur79d4f992019-11-11 23:49:02 +00003084 lengths = [max(map(len, (row[i] for row in hosts))) for i in range(3)]
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003085 header = [('Host', 'User', 'Which file'),
3086 ['=' * l for l in lengths]]
3087 for row in (header + hosts):
3088 print('\t'.join((('%%+%ds' % l) % s)
3089 for l, s in zip(lengths, row)))
3090
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003091 @staticmethod
3092 def _parse_identity(identity):
Lei Zhangd3f769a2017-12-15 15:16:14 -08003093 """Parses identity "git-<username>.domain" into <username> and domain."""
3094 # Special case: usernames that contain ".", which are generally not
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +02003095 # distinguishable from sub-domains. But we do know typical domains:
3096 if identity.endswith('.chromium.org'):
3097 domain = 'chromium.org'
3098 username = identity[:-len('.chromium.org')]
3099 else:
3100 username, domain = identity.split('.', 1)
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003101 if username.startswith('git-'):
3102 username = username[len('git-'):]
3103 return username, domain
3104
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003105 def _canonical_git_googlesource_host(self, host):
3106 """Normalizes Gerrit hosts (with '-review') to Git host."""
3107 assert host.endswith(self._GOOGLESOURCE)
3108 # Prefix doesn't include '.' at the end.
3109 prefix = host[:-(1 + len(self._GOOGLESOURCE))]
3110 if prefix.endswith('-review'):
3111 prefix = prefix[:-len('-review')]
3112 return prefix + '.' + self._GOOGLESOURCE
3113
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003114 def _canonical_gerrit_googlesource_host(self, host):
3115 git_host = self._canonical_git_googlesource_host(host)
3116 prefix = git_host.split('.', 1)[0]
3117 return prefix + '-review.' + self._GOOGLESOURCE
3118
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003119 def _get_counterpart_host(self, host):
3120 assert host.endswith(self._GOOGLESOURCE)
3121 git = self._canonical_git_googlesource_host(host)
3122 gerrit = self._canonical_gerrit_googlesource_host(git)
3123 return git if gerrit == host else gerrit
3124
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003125 def has_generic_host(self):
3126 """Returns whether generic .googlesource.com has been configured.
3127
3128 Chrome Infra recommends to use explicit ${host}.googlesource.com instead.
3129 """
3130 for host, _, _ in self.get_hosts_with_creds(include_netrc=False):
3131 if host == '.' + self._GOOGLESOURCE:
3132 return True
3133 return False
3134
3135 def _get_git_gerrit_identity_pairs(self):
3136 """Returns map from canonic host to pair of identities (Git, Gerrit).
3137
3138 One of identities might be None, meaning not configured.
3139 """
3140 host_to_identity_pairs = {}
3141 for host, identity, _ in self.get_hosts_with_creds():
3142 canonical = self._canonical_git_googlesource_host(host)
3143 pair = host_to_identity_pairs.setdefault(canonical, [None, None])
3144 idx = 0 if canonical == host else 1
3145 pair[idx] = identity
3146 return host_to_identity_pairs
3147
3148 def get_partially_configured_hosts(self):
3149 return set(
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003150 (host if i1 else self._canonical_gerrit_googlesource_host(host))
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00003151 for host, (i1, i2) in self._get_git_gerrit_identity_pairs().items()
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003152 if None in (i1, i2) and host != '.' + self._GOOGLESOURCE)
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003153
3154 def get_conflicting_hosts(self):
3155 return set(
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003156 host
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00003157 for host, (i1, i2) in self._get_git_gerrit_identity_pairs().items()
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003158 if None not in (i1, i2) and i1 != i2)
3159
3160 def get_duplicated_hosts(self):
3161 counters = collections.Counter(h for h, _, _ in self.get_hosts_with_creds())
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00003162 return set(host for host, count in counters.items() if count > 1)
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003163
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003164
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003165 @staticmethod
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003166 def _format_hosts(hosts, extra_column_func=None):
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003167 hosts = sorted(hosts)
3168 assert hosts
3169 if extra_column_func is None:
3170 extras = [''] * len(hosts)
3171 else:
3172 extras = [extra_column_func(host) for host in hosts]
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003173 tmpl = '%%-%ds %%-%ds' % (max(map(len, hosts)), max(map(len, extras)))
3174 lines = []
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003175 for he in zip(hosts, extras):
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003176 lines.append(tmpl % he)
3177 return lines
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003178
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003179 def _find_problems(self):
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003180 if self.has_generic_host():
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003181 yield ('.googlesource.com wildcard record detected',
3182 ['Chrome Infrastructure team recommends to list full host names '
3183 'explicitly.'],
3184 None)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003185
3186 dups = self.get_duplicated_hosts()
3187 if dups:
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003188 yield ('The following hosts were defined twice',
3189 self._format_hosts(dups),
3190 None)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003191
3192 partial = self.get_partially_configured_hosts()
3193 if partial:
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003194 yield ('Credentials should come in pairs for Git and Gerrit hosts. '
3195 'These hosts are missing',
3196 self._format_hosts(partial, lambda host: 'but %s defined' %
3197 self._get_counterpart_host(host)),
3198 partial)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003199
3200 conflicting = self.get_conflicting_hosts()
3201 if conflicting:
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003202 yield ('The following Git hosts have differing credentials from their '
3203 'Gerrit counterparts',
3204 self._format_hosts(conflicting, lambda host: '%s vs %s' %
3205 tuple(self._get_git_gerrit_identity_pairs()[host])),
3206 conflicting)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003207
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003208 def find_and_report_problems(self):
3209 """Returns True if there was at least one problem, else False."""
3210 found = False
3211 bad_hosts = set()
3212 for title, sublines, hosts in self._find_problems():
3213 if not found:
3214 found = True
3215 print('\n\n.gitcookies problem report:\n')
3216 bad_hosts.update(hosts or [])
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003217 print(' %s%s' % (title, (':' if sublines else '')))
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003218 if sublines:
3219 print()
3220 print(' %s' % '\n '.join(sublines))
3221 print()
3222
3223 if bad_hosts:
3224 assert found
3225 print(' You can manually remove corresponding lines in your %s file and '
3226 'visit the following URLs with correct account to generate '
3227 'correct credential lines:\n' %
3228 gerrit_util.CookiesAuthenticator.get_gitcookies_path())
3229 print(' %s' % '\n '.join(sorted(set(
3230 gerrit_util.CookiesAuthenticator().get_new_password_url(
3231 self._canonical_git_googlesource_host(host))
3232 for host in bad_hosts
3233 ))))
3234 return found
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003235
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003236
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003237@metrics.collector.collect_metrics('git cl creds-check')
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003238def CMDcreds_check(parser, args):
3239 """Checks credentials and suggests changes."""
3240 _, _ = parser.parse_args(args)
3241
Vadim Shtayurab250ec12018-10-04 00:21:08 +00003242 # Code below checks .gitcookies. Abort if using something else.
3243 authn = gerrit_util.Authenticator.get()
3244 if not isinstance(authn, gerrit_util.CookiesAuthenticator):
Edward Lemur57d47422020-03-06 20:43:07 +00003245 message = (
Vadim Shtayurab250ec12018-10-04 00:21:08 +00003246 'This command is not designed for bot environment. It checks '
3247 '~/.gitcookies file not generally used on bots.')
Edward Lemur57d47422020-03-06 20:43:07 +00003248 # TODO(crbug.com/1059384): Automatically detect when running on cloudtop.
3249 if isinstance(authn, gerrit_util.GceAuthenticator):
3250 message += (
3251 '\n'
3252 'If you need to run this on GCE or a cloudtop instance, '
3253 'export SKIP_GCE_AUTH_FOR_GIT=1 in your env.')
3254 DieWithError(message)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003255
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003256 checker = _GitCookiesChecker()
3257 checker.ensure_configured_gitcookies()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003258
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003259 print('Your .netrc and .gitcookies have credentials for these hosts:')
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003260 checker.print_current_creds(include_netrc=True)
3261
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003262 if not checker.find_and_report_problems():
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003263 print('\nNo problems detected in your .gitcookies file.')
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003264 return 0
3265 return 1
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003266
3267
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003268@metrics.collector.collect_metrics('git cl baseurl')
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00003269def CMDbaseurl(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003270 """Gets or sets base-url for this branch."""
Edward Lesmes50da7702020-03-30 19:23:43 +00003271 branchref = scm.GIT.GetBranchRef(settings.GetRoot())
Edward Lemur85153282020-02-14 22:06:29 +00003272 branch = scm.GIT.ShortBranchName(branchref)
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00003273 _, args = parser.parse_args(args)
3274 if not args:
vapiera7fbd5a2016-06-16 09:17:49 -07003275 print('Current base-url:')
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00003276 return RunGit(['config', 'branch.%s.base-url' % branch],
3277 error_ok=False).strip()
3278 else:
vapiera7fbd5a2016-06-16 09:17:49 -07003279 print('Setting base-url to %s' % args[0])
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00003280 return RunGit(['config', 'branch.%s.base-url' % branch, args[0]],
3281 error_ok=False).strip()
3282
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003283
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00003284def color_for_status(status):
3285 """Maps a Changelist status to color, for CMDstatus and other tools."""
Bruce Dawsonb73f8a92020-03-27 22:03:08 +00003286 BOLD = '\033[1m'
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00003287 return {
Bruce Dawsonb73f8a92020-03-27 22:03:08 +00003288 'unsent': BOLD + Fore.YELLOW,
3289 'waiting': BOLD + Fore.RED,
3290 'reply': BOLD + Fore.YELLOW,
3291 'not lgtm': BOLD + Fore.RED,
3292 'lgtm': BOLD + Fore.GREEN,
3293 'commit': BOLD + Fore.MAGENTA,
3294 'closed': BOLD + Fore.CYAN,
3295 'error': BOLD + Fore.WHITE,
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00003296 }.get(status, Fore.WHITE)
3297
tandrii@chromium.org04ea8462016-04-25 19:51:21 +00003298
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003299def get_cl_statuses(changes, fine_grained, max_processes=None):
3300 """Returns a blocking iterable of (cl, status) for given branches.
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003301
3302 If fine_grained is true, this will fetch CL statuses from the server.
3303 Otherwise, simply indicate if there's a matching url for the given branches.
3304
3305 If max_processes is specified, it is used as the maximum number of processes
3306 to spawn to fetch CL status from the server. Otherwise 1 process per branch is
3307 spawned.
calamity@chromium.orgcf197482016-04-29 20:15:53 +00003308
3309 See GetStatus() for a list of possible statuses.
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003310 """
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003311 if not changes:
Edward Lemur61bf4172020-02-24 23:22:37 +00003312 return
calamity@chromium.orgcf197482016-04-29 20:15:53 +00003313
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003314 if not fine_grained:
3315 # Fast path which doesn't involve querying codereview servers.
Aaron Gablea1bab272017-04-11 16:38:18 -07003316 # Do not use get_approving_reviewers(), since it requires an HTTP request.
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003317 for cl in changes:
3318 yield (cl, 'waiting' if cl.GetIssueURL() else 'error')
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003319 return
3320
3321 # First, sort out authentication issues.
3322 logging.debug('ensuring credentials exist')
3323 for cl in changes:
3324 cl.EnsureAuthenticated(force=False, refresh=True)
3325
3326 def fetch(cl):
3327 try:
3328 return (cl, cl.GetStatus())
3329 except:
3330 # See http://crbug.com/629863.
Andrii Shyshkalov98824232018-04-19 11:37:15 -07003331 logging.exception('failed to fetch status for cl %s:', cl.GetIssue())
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003332 raise
3333
3334 threads_count = len(changes)
3335 if max_processes:
3336 threads_count = max(1, min(threads_count, max_processes))
3337 logging.debug('querying %d CLs using %d threads', len(changes), threads_count)
3338
Edward Lemur61bf4172020-02-24 23:22:37 +00003339 pool = multiprocessing.pool.ThreadPool(threads_count)
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003340 fetched_cls = set()
3341 try:
3342 it = pool.imap_unordered(fetch, changes).__iter__()
3343 while True:
3344 try:
3345 cl, status = it.next(timeout=5)
Edward Lemur61bf4172020-02-24 23:22:37 +00003346 except (multiprocessing.TimeoutError, StopIteration):
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003347 break
3348 fetched_cls.add(cl)
3349 yield cl, status
3350 finally:
3351 pool.close()
3352
3353 # Add any branches that failed to fetch.
3354 for cl in set(changes) - fetched_cls:
3355 yield (cl, 'error')
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00003356
rmistry@google.com2dd99862015-06-22 12:22:18 +00003357
Jose Lopes3863fc52020-04-07 17:00:25 +00003358def upload_branch_deps(cl, args, force=False):
rmistry@google.com2dd99862015-06-22 12:22:18 +00003359 """Uploads CLs of local branches that are dependents of the current branch.
3360
3361 If the local branch dependency tree looks like:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003362
3363 test1 -> test2.1 -> test3.1
3364 -> test3.2
3365 -> test2.2 -> test3.3
rmistry@google.com2dd99862015-06-22 12:22:18 +00003366
3367 and you run "git cl upload --dependencies" from test1 then "git cl upload" is
3368 run on the dependent branches in this order:
3369 test2.1, test3.1, test3.2, test2.2, test3.3
3370
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003371 Note: This function does not rebase your local dependent branches. Use it
3372 when you make a change to the parent branch that will not conflict
3373 with its dependent branches, and you would like their dependencies
3374 updated in Rietveld.
rmistry@google.com2dd99862015-06-22 12:22:18 +00003375 """
3376 if git_common.is_dirty_git_tree('upload-branch-deps'):
3377 return 1
3378
3379 root_branch = cl.GetBranch()
3380 if root_branch is None:
3381 DieWithError('Can\'t find dependent branches from detached HEAD state. '
3382 'Get on a branch!')
Andrii Shyshkalov9f274432018-10-15 16:40:23 +00003383 if not cl.GetIssue():
rmistry@google.com2dd99862015-06-22 12:22:18 +00003384 DieWithError('Current branch does not have an uploaded CL. We cannot set '
3385 'patchset dependencies without an uploaded CL.')
3386
3387 branches = RunGit(['for-each-ref',
3388 '--format=%(refname:short) %(upstream:short)',
3389 'refs/heads'])
3390 if not branches:
3391 print('No local branches found.')
3392 return 0
3393
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003394 # Create a dictionary of all local branches to the branches that are
3395 # dependent on it.
rmistry@google.com2dd99862015-06-22 12:22:18 +00003396 tracked_to_dependents = collections.defaultdict(list)
3397 for b in branches.splitlines():
3398 tokens = b.split()
3399 if len(tokens) == 2:
3400 branch_name, tracked = tokens
3401 tracked_to_dependents[tracked].append(branch_name)
3402
vapiera7fbd5a2016-06-16 09:17:49 -07003403 print()
3404 print('The dependent local branches of %s are:' % root_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00003405 dependents = []
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003406
rmistry@google.com2dd99862015-06-22 12:22:18 +00003407 def traverse_dependents_preorder(branch, padding=''):
3408 dependents_to_process = tracked_to_dependents.get(branch, [])
3409 padding += ' '
3410 for dependent in dependents_to_process:
vapiera7fbd5a2016-06-16 09:17:49 -07003411 print('%s%s' % (padding, dependent))
rmistry@google.com2dd99862015-06-22 12:22:18 +00003412 dependents.append(dependent)
3413 traverse_dependents_preorder(dependent, padding)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003414
rmistry@google.com2dd99862015-06-22 12:22:18 +00003415 traverse_dependents_preorder(root_branch)
vapiera7fbd5a2016-06-16 09:17:49 -07003416 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00003417
3418 if not dependents:
vapiera7fbd5a2016-06-16 09:17:49 -07003419 print('There are no dependent local branches for %s' % root_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00003420 return 0
3421
Jose Lopes3863fc52020-04-07 17:00:25 +00003422 if not force:
3423 confirm_or_exit('This command will checkout all dependent branches and run '
3424 '"git cl upload".', action='continue')
rmistry@google.com2dd99862015-06-22 12:22:18 +00003425
rmistry@google.com2dd99862015-06-22 12:22:18 +00003426 # Record all dependents that failed to upload.
3427 failures = {}
3428 # Go through all dependents, checkout the branch and upload.
3429 try:
3430 for dependent_branch in dependents:
vapiera7fbd5a2016-06-16 09:17:49 -07003431 print()
3432 print('--------------------------------------')
3433 print('Running "git cl upload" from %s:' % dependent_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00003434 RunGit(['checkout', '-q', dependent_branch])
vapiera7fbd5a2016-06-16 09:17:49 -07003435 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00003436 try:
3437 if CMDupload(OptionParser(), args) != 0:
vapiera7fbd5a2016-06-16 09:17:49 -07003438 print('Upload failed for %s!' % dependent_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00003439 failures[dependent_branch] = 1
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08003440 except: # pylint: disable=bare-except
rmistry@google.com2dd99862015-06-22 12:22:18 +00003441 failures[dependent_branch] = 1
vapiera7fbd5a2016-06-16 09:17:49 -07003442 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00003443 finally:
3444 # Swap back to the original root branch.
3445 RunGit(['checkout', '-q', root_branch])
3446
vapiera7fbd5a2016-06-16 09:17:49 -07003447 print()
3448 print('Upload complete for dependent branches!')
rmistry@google.com2dd99862015-06-22 12:22:18 +00003449 for dependent_branch in dependents:
3450 upload_status = 'failed' if failures.get(dependent_branch) else 'succeeded'
vapiera7fbd5a2016-06-16 09:17:49 -07003451 print(' %s : %s' % (dependent_branch, upload_status))
3452 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00003453
3454 return 0
3455
3456
Tibor Goldschwendt7c5efb22020-03-25 01:23:54 +00003457def GetArchiveTagForBranch(issue_num, branch_name, existing_tags, pattern):
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00003458 """Given a proposed tag name, returns a tag name that is guaranteed to be
3459 unique. If 'foo' is proposed but already exists, then 'foo-2' is used,
3460 or 'foo-3', and so on."""
3461
Tibor Goldschwendt7c5efb22020-03-25 01:23:54 +00003462 proposed_tag = pattern.format(**{'issue': issue_num, 'branch': branch_name})
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00003463 for suffix_num in itertools.count(1):
3464 if suffix_num == 1:
3465 to_check = proposed_tag
3466 else:
3467 to_check = '%s-%d' % (proposed_tag, suffix_num)
3468
3469 if to_check not in existing_tags:
3470 return to_check
3471
3472
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003473@metrics.collector.collect_metrics('git cl archive')
kmarshall3bff56b2016-06-06 18:31:47 -07003474def CMDarchive(parser, args):
3475 """Archives and deletes branches associated with closed changelists."""
3476 parser.add_option(
3477 '-j', '--maxjobs', action='store', type=int,
kmarshall9249e012016-08-23 12:02:16 -07003478 help='The maximum number of jobs to use when retrieving review status.')
kmarshall3bff56b2016-06-06 18:31:47 -07003479 parser.add_option(
3480 '-f', '--force', action='store_true',
3481 help='Bypasses the confirmation prompt.')
kmarshall9249e012016-08-23 12:02:16 -07003482 parser.add_option(
3483 '-d', '--dry-run', action='store_true',
3484 help='Skip the branch tagging and removal steps.')
3485 parser.add_option(
3486 '-t', '--notags', action='store_true',
3487 help='Do not tag archived branches. '
3488 'Note: local commit history may be lost.')
Tibor Goldschwendt7c5efb22020-03-25 01:23:54 +00003489 parser.add_option(
3490 '-p',
3491 '--pattern',
3492 default='git-cl-archived-{issue}-{branch}',
3493 help='Format string for archive tags. '
3494 'E.g. \'archived-{issue}-{branch}\'.')
kmarshall3bff56b2016-06-06 18:31:47 -07003495
kmarshall3bff56b2016-06-06 18:31:47 -07003496 options, args = parser.parse_args(args)
3497 if args:
3498 parser.error('Unsupported args: %s' % ' '.join(args))
kmarshall3bff56b2016-06-06 18:31:47 -07003499
3500 branches = RunGit(['for-each-ref', '--format=%(refname)', 'refs/heads'])
3501 if not branches:
3502 return 0
3503
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00003504 tags = RunGit(['for-each-ref', '--format=%(refname)',
3505 'refs/tags']).splitlines() or []
3506 tags = [t.split('/')[-1] for t in tags]
3507
vapiera7fbd5a2016-06-16 09:17:49 -07003508 print('Finding all branches associated with closed issues...')
Edward Lemur934836a2019-09-09 20:16:54 +00003509 changes = [Changelist(branchref=b)
3510 for b in branches.splitlines()]
kmarshall3bff56b2016-06-06 18:31:47 -07003511 alignment = max(5, max(len(c.GetBranch()) for c in changes))
3512 statuses = get_cl_statuses(changes,
3513 fine_grained=True,
3514 max_processes=options.maxjobs)
3515 proposal = [(cl.GetBranch(),
Tibor Goldschwendt7c5efb22020-03-25 01:23:54 +00003516 GetArchiveTagForBranch(cl.GetIssue(), cl.GetBranch(), tags,
3517 options.pattern))
kmarshall3bff56b2016-06-06 18:31:47 -07003518 for cl, status in statuses
Andrii Shyshkalov51bdf8c2018-10-18 01:07:58 +00003519 if status in ('closed', 'rietveld-not-supported')]
kmarshall3bff56b2016-06-06 18:31:47 -07003520 proposal.sort()
3521
3522 if not proposal:
vapiera7fbd5a2016-06-16 09:17:49 -07003523 print('No branches with closed codereview issues found.')
kmarshall3bff56b2016-06-06 18:31:47 -07003524 return 0
3525
Edward Lemur85153282020-02-14 22:06:29 +00003526 current_branch = scm.GIT.GetBranch(settings.GetRoot())
kmarshall3bff56b2016-06-06 18:31:47 -07003527
vapiera7fbd5a2016-06-16 09:17:49 -07003528 print('\nBranches with closed issues that will be archived:\n')
kmarshall9249e012016-08-23 12:02:16 -07003529 if options.notags:
3530 for next_item in proposal:
3531 print(' ' + next_item[0])
3532 else:
3533 print('%*s | %s' % (alignment, 'Branch name', 'Archival tag name'))
3534 for next_item in proposal:
3535 print('%*s %s' % (alignment, next_item[0], next_item[1]))
kmarshall3bff56b2016-06-06 18:31:47 -07003536
kmarshall9249e012016-08-23 12:02:16 -07003537 # Quit now on precondition failure or if instructed by the user, either
3538 # via an interactive prompt or by command line flags.
3539 if options.dry_run:
3540 print('\nNo changes were made (dry run).\n')
3541 return 0
3542 elif any(branch == current_branch for branch, _ in proposal):
kmarshall3bff56b2016-06-06 18:31:47 -07003543 print('You are currently on a branch \'%s\' which is associated with a '
3544 'closed codereview issue, so archive cannot proceed. Please '
3545 'checkout another branch and run this command again.' %
3546 current_branch)
3547 return 1
kmarshall9249e012016-08-23 12:02:16 -07003548 elif not options.force:
Edward Lesmesae3586b2020-03-23 21:21:14 +00003549 answer = gclient_utils.AskForData('\nProceed with deletion (Y/n)? ').lower()
sergiyb4a5ecbe2016-06-20 09:46:00 -07003550 if answer not in ('y', ''):
vapiera7fbd5a2016-06-16 09:17:49 -07003551 print('Aborted.')
kmarshall3bff56b2016-06-06 18:31:47 -07003552 return 1
3553
3554 for branch, tagname in proposal:
kmarshall9249e012016-08-23 12:02:16 -07003555 if not options.notags:
3556 RunGit(['tag', tagname, branch])
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00003557
3558 if RunGitWithCode(['branch', '-D', branch])[0] != 0:
3559 # Clean up the tag if we failed to delete the branch.
3560 RunGit(['tag', '-d', tagname])
kmarshall9249e012016-08-23 12:02:16 -07003561
vapiera7fbd5a2016-06-16 09:17:49 -07003562 print('\nJob\'s done!')
kmarshall3bff56b2016-06-06 18:31:47 -07003563
3564 return 0
3565
3566
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003567@metrics.collector.collect_metrics('git cl status')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003568def CMDstatus(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003569 """Show status of changelists.
3570
3571 Colors are used to tell the state of the CL unless --fast is used:
jsbell@chromium.orgaeab41a2013-12-10 20:01:22 +00003572 - Blue waiting for review
Aaron Gable9ab38c62017-04-06 14:36:33 -07003573 - Yellow waiting for you to reply to review, or not yet sent
jsbell@chromium.orgaeab41a2013-12-10 20:01:22 +00003574 - Green LGTM'ed
Aaron Gable9ab38c62017-04-06 14:36:33 -07003575 - Red 'not LGTM'ed
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00003576 - Magenta in the CQ
jsbell@chromium.orgaeab41a2013-12-10 20:01:22 +00003577 - Cyan was committed, branch can be deleted
Aaron Gable9ab38c62017-04-06 14:36:33 -07003578 - White error, or unknown status
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003579
3580 Also see 'git cl comments'.
3581 """
Alan Cuttera3be9a52019-03-04 18:50:33 +00003582 parser.add_option(
3583 '--no-branch-color',
3584 action='store_true',
3585 help='Disable colorized branch names')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003586 parser.add_option('--field',
phajdan.jr289d03e2016-08-16 08:21:06 -07003587 help='print only specific field (desc|id|patch|status|url)')
maruel@chromium.org1033efd2013-07-23 23:25:09 +00003588 parser.add_option('-f', '--fast', action='store_true',
3589 help='Do not retrieve review status')
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003590 parser.add_option(
3591 '-j', '--maxjobs', action='store', type=int,
3592 help='The maximum number of jobs to use when retrieving review status')
Edward Lemur52969c92020-02-06 18:15:28 +00003593 parser.add_option(
3594 '-i', '--issue', type=int,
3595 help='Operate on this issue instead of the current branch\'s implicit '
3596 'issue. Requires --field to be set.')
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00003597 parser.add_option('-d',
3598 '--date-order',
3599 action='store_true',
3600 help='Order branches by committer date.')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00003601 options, args = parser.parse_args(args)
maruel@chromium.org39c0b222013-08-17 16:57:01 +00003602 if args:
3603 parser.error('Unsupported args: %s' % args)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003604
iannuccie53c9352016-08-17 14:40:40 -07003605 if options.issue is not None and not options.field:
Edward Lemur6c6827c2020-02-06 21:15:18 +00003606 parser.error('--field must be given when --issue is set.')
iannucci3c972b92016-08-17 13:24:10 -07003607
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003608 if options.field:
Edward Lemur934836a2019-09-09 20:16:54 +00003609 cl = Changelist(issue=options.issue)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003610 if options.field.startswith('desc'):
Edward Lemur6c6827c2020-02-06 21:15:18 +00003611 if cl.GetIssue():
3612 print(cl.FetchDescription())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003613 elif options.field == 'id':
3614 issueid = cl.GetIssue()
3615 if issueid:
vapiera7fbd5a2016-06-16 09:17:49 -07003616 print(issueid)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003617 elif options.field == 'patch':
Aaron Gablee8856ee2017-12-07 12:41:46 -08003618 patchset = cl.GetMostRecentPatchset()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003619 if patchset:
vapiera7fbd5a2016-06-16 09:17:49 -07003620 print(patchset)
phajdan.jr289d03e2016-08-16 08:21:06 -07003621 elif options.field == 'status':
3622 print(cl.GetStatus())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003623 elif options.field == 'url':
3624 url = cl.GetIssueURL()
3625 if url:
vapiera7fbd5a2016-06-16 09:17:49 -07003626 print(url)
maruel@chromium.orge25c75b2013-07-23 18:30:56 +00003627 return 0
3628
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00003629 branches = RunGit([
3630 'for-each-ref', '--format=%(refname) %(committerdate:unix)', 'refs/heads'
3631 ])
maruel@chromium.orge25c75b2013-07-23 18:30:56 +00003632 if not branches:
3633 print('No local branch found.')
3634 return 0
3635
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003636 changes = [
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00003637 Changelist(branchref=b, commit_date=ct)
3638 for b, ct in map(lambda line: line.split(' '), branches.splitlines())
3639 ]
vapiera7fbd5a2016-06-16 09:17:49 -07003640 print('Branches associated with reviews:')
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003641 output = get_cl_statuses(changes,
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003642 fine_grained=not options.fast,
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003643 max_processes=options.maxjobs)
maruel@chromium.org1033efd2013-07-23 23:25:09 +00003644
Edward Lemur85153282020-02-14 22:06:29 +00003645 current_branch = scm.GIT.GetBranch(settings.GetRoot())
Daniel McArdlea23bf592019-02-12 00:25:12 +00003646
3647 def FormatBranchName(branch, colorize=False):
3648 """Simulates 'git branch' behavior. Colorizes and prefixes branch name with
3649 an asterisk when it is the current branch."""
3650
3651 asterisk = ""
3652 color = Fore.RESET
3653 if branch == current_branch:
3654 asterisk = "* "
3655 color = Fore.GREEN
Edward Lemur85153282020-02-14 22:06:29 +00003656 branch_name = scm.GIT.ShortBranchName(branch)
Daniel McArdlea23bf592019-02-12 00:25:12 +00003657
3658 if colorize:
3659 return asterisk + color + branch_name + Fore.RESET
Daniel McArdle452a49f2019-02-14 17:28:31 +00003660 return asterisk + branch_name
3661
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003662 branch_statuses = {}
Daniel McArdlea23bf592019-02-12 00:25:12 +00003663
3664 alignment = max(5, max(len(FormatBranchName(c.GetBranch())) for c in changes))
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00003665 if options.date_order:
3666 sorted_changes = sorted(changes,
3667 key=lambda c: c.GetCommitDate(),
3668 reverse=True)
3669 else:
3670 sorted_changes = sorted(changes, key=lambda c: c.GetBranch())
3671 for cl in sorted_changes:
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003672 branch = cl.GetBranch()
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003673 while branch not in branch_statuses:
Edward Lemur79d4f992019-11-11 23:49:02 +00003674 c, status = next(output)
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003675 branch_statuses[c.GetBranch()] = status
3676 status = branch_statuses.pop(branch)
Andrii Shyshkalov1ee78cd2020-03-12 01:31:53 +00003677 url = cl.GetIssueURL(short=True)
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003678 if url and (not status or status == 'error'):
3679 # The issue probably doesn't exist anymore.
3680 url += ' (broken)'
3681
nodir@chromium.orga6de1f42015-06-10 04:23:17 +00003682 color = color_for_status(status)
Bruce Dawsonb73f8a92020-03-27 22:03:08 +00003683 # Turn off bold as well as colors.
3684 END = '\033[0m'
3685 reset = Fore.RESET + END
iannucci@chromium.org596cd5c2016-04-04 21:34:39 +00003686 if not setup_color.IS_TTY:
maruel@chromium.org885f6512013-07-27 02:17:26 +00003687 color = ''
3688 reset = ''
nodir@chromium.orga6de1f42015-06-10 04:23:17 +00003689 status_str = '(%s)' % status if status else ''
Daniel McArdle452a49f2019-02-14 17:28:31 +00003690
Alan Cuttera3be9a52019-03-04 18:50:33 +00003691 branch_display = FormatBranchName(branch)
3692 padding = ' ' * (alignment - len(branch_display))
3693 if not options.no_branch_color:
3694 branch_display = FormatBranchName(branch, colorize=True)
Daniel McArdle452a49f2019-02-14 17:28:31 +00003695
Alan Cuttera3be9a52019-03-04 18:50:33 +00003696 print(' %s : %s%s %s%s' % (padding + branch_display, color, url,
3697 status_str, reset))
Andrii Shyshkalovd0e1d9d2017-01-24 17:10:51 +01003698
vapiera7fbd5a2016-06-16 09:17:49 -07003699 print()
Daniel McArdlea23bf592019-02-12 00:25:12 +00003700 print('Current branch: %s' % current_branch)
Andrii Shyshkalovd0e1d9d2017-01-24 17:10:51 +01003701 for cl in changes:
Daniel McArdlea23bf592019-02-12 00:25:12 +00003702 if cl.GetBranch() == current_branch:
Andrii Shyshkalovd0e1d9d2017-01-24 17:10:51 +01003703 break
dpranke@chromium.orgee87f582015-07-31 18:46:25 +00003704 if not cl.GetIssue():
vapiera7fbd5a2016-06-16 09:17:49 -07003705 print('No issue assigned.')
dpranke@chromium.orgee87f582015-07-31 18:46:25 +00003706 return 0
vapiera7fbd5a2016-06-16 09:17:49 -07003707 print('Issue number: %s (%s)' % (cl.GetIssue(), cl.GetIssueURL()))
maruel@chromium.org85616e02014-07-28 15:37:55 +00003708 if not options.fast:
vapiera7fbd5a2016-06-16 09:17:49 -07003709 print('Issue description:')
Edward Lemur6c6827c2020-02-06 21:15:18 +00003710 print(cl.FetchDescription(pretty=True))
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003711 return 0
3712
3713
maruel@chromium.org39c0b222013-08-17 16:57:01 +00003714def colorize_CMDstatus_doc():
3715 """To be called once in main() to add colors to git cl status help."""
3716 colors = [i for i in dir(Fore) if i[0].isupper()]
3717
3718 def colorize_line(line):
3719 for color in colors:
3720 if color in line.upper():
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003721 # Extract whitespace first and the leading '-'.
maruel@chromium.org39c0b222013-08-17 16:57:01 +00003722 indent = len(line) - len(line.lstrip(' ')) + 1
3723 return line[:indent] + getattr(Fore, color) + line[indent:] + Fore.RESET
3724 return line
3725
3726 lines = CMDstatus.__doc__.splitlines()
3727 CMDstatus.__doc__ = '\n'.join(colorize_line(l) for l in lines)
3728
3729
phajdan.jre328cf92016-08-22 04:12:17 -07003730def write_json(path, contents):
Stefan Zager1306bd02017-06-22 19:26:46 -07003731 if path == '-':
3732 json.dump(contents, sys.stdout)
3733 else:
3734 with open(path, 'w') as f:
3735 json.dump(contents, f)
phajdan.jre328cf92016-08-22 04:12:17 -07003736
3737
maruel@chromium.org0633fb42013-08-16 20:06:14 +00003738@subcommand.usage('[issue_number]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003739@metrics.collector.collect_metrics('git cl issue')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003740def CMDissue(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003741 """Sets or displays the current code review issue number.
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003742
3743 Pass issue number 0 to clear the current issue.
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003744 """
dnj@chromium.org406c4402015-03-03 17:22:28 +00003745 parser.add_option('-r', '--reverse', action='store_true',
3746 help='Lookup the branch(es) for the specified issues. If '
3747 'no issues are specified, all branches with mapped '
3748 'issues will be listed.')
Stefan Zager1306bd02017-06-22 19:26:46 -07003749 parser.add_option('--json',
3750 help='Path to JSON output file, or "-" for stdout.')
dnj@chromium.org406c4402015-03-03 17:22:28 +00003751 options, args = parser.parse_args(args)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003752
dnj@chromium.org406c4402015-03-03 17:22:28 +00003753 if options.reverse:
3754 branches = RunGit(['for-each-ref', 'refs/heads',
Aaron Gablead64abd2017-12-04 09:49:13 -08003755 '--format=%(refname)']).splitlines()
dnj@chromium.org406c4402015-03-03 17:22:28 +00003756 # Reverse issue lookup.
3757 issue_branch_map = {}
Daniel Bratellb56a43a2018-09-06 15:49:03 +00003758
3759 git_config = {}
3760 for config in RunGit(['config', '--get-regexp',
3761 r'branch\..*issue']).splitlines():
3762 name, _space, val = config.partition(' ')
3763 git_config[name] = val
3764
dnj@chromium.org406c4402015-03-03 17:22:28 +00003765 for branch in branches:
Edward Lesmes50da7702020-03-30 19:23:43 +00003766 issue = git_config.get(
3767 'branch.%s.%s' % (scm.GIT.ShortBranchName(branch), ISSUE_CONFIG_KEY))
Edward Lemur52969c92020-02-06 18:15:28 +00003768 if issue:
3769 issue_branch_map.setdefault(int(issue), []).append(branch)
dnj@chromium.org406c4402015-03-03 17:22:28 +00003770 if not args:
Carlos Caballero81923d62020-07-06 18:22:27 +00003771 args = sorted(issue_branch_map.keys())
phajdan.jre328cf92016-08-22 04:12:17 -07003772 result = {}
dnj@chromium.org406c4402015-03-03 17:22:28 +00003773 for issue in args:
Lei Zhang5a368d42019-03-25 23:18:19 +00003774 try:
3775 issue_num = int(issue)
3776 except ValueError:
3777 print('ERROR cannot parse issue number: %s' % issue, file=sys.stderr)
dnj@chromium.org406c4402015-03-03 17:22:28 +00003778 continue
Lei Zhang5a368d42019-03-25 23:18:19 +00003779 result[issue_num] = issue_branch_map.get(issue_num)
vapiera7fbd5a2016-06-16 09:17:49 -07003780 print('Branch for issue number %s: %s' % (
Lei Zhang5a368d42019-03-25 23:18:19 +00003781 issue, ', '.join(issue_branch_map.get(issue_num) or ('None',))))
phajdan.jre328cf92016-08-22 04:12:17 -07003782 if options.json:
3783 write_json(options.json, result)
Aaron Gable78753da2017-06-15 10:35:49 -07003784 return 0
3785
3786 if len(args) > 0:
Edward Lemurf38bc172019-09-03 21:02:13 +00003787 issue = ParseIssueNumberArgument(args[0])
Aaron Gable78753da2017-06-15 10:35:49 -07003788 if not issue.valid:
3789 DieWithError('Pass a url or number to set the issue, 0 to unset it, '
3790 'or no argument to list it.\n'
3791 'Maybe you want to run git cl status?')
Edward Lemurf38bc172019-09-03 21:02:13 +00003792 cl = Changelist()
Aaron Gable78753da2017-06-15 10:35:49 -07003793 cl.SetIssue(issue.issue)
dnj@chromium.org406c4402015-03-03 17:22:28 +00003794 else:
Edward Lemurf38bc172019-09-03 21:02:13 +00003795 cl = Changelist()
Aaron Gable78753da2017-06-15 10:35:49 -07003796 print('Issue number: %s (%s)' % (cl.GetIssue(), cl.GetIssueURL()))
3797 if options.json:
3798 write_json(options.json, {
Nodir Turakulov27379632021-03-17 18:53:29 +00003799 'gerrit_host': cl.GetGerritHost(),
3800 'gerrit_project': cl.GetGerritProject(),
Aaron Gable78753da2017-06-15 10:35:49 -07003801 'issue_url': cl.GetIssueURL(),
Nodir Turakulov27379632021-03-17 18:53:29 +00003802 'issue': cl.GetIssue(),
Aaron Gable78753da2017-06-15 10:35:49 -07003803 })
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003804 return 0
3805
3806
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003807@metrics.collector.collect_metrics('git cl comments')
maruel@chromium.org9977a2e2012-06-06 22:30:56 +00003808def CMDcomments(parser, args):
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003809 """Shows or posts review comments for any changelist."""
3810 parser.add_option('-a', '--add-comment', dest='comment',
3811 help='comment to add to an issue')
Sergiy Byelozyorovcb629a42018-10-28 19:20:39 +00003812 parser.add_option('-p', '--publish', action='store_true',
3813 help='marks CL as ready and sends comment to reviewers')
Andrii Shyshkalov0d6b46e2017-03-17 22:23:22 +01003814 parser.add_option('-i', '--issue', dest='issue',
Edward Lemurf38bc172019-09-03 21:02:13 +00003815 help='review issue id (defaults to current issue).')
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07003816 parser.add_option('-m', '--machine-readable', dest='readable',
3817 action='store_false', default=True,
3818 help='output comments in a format compatible with '
3819 'editor parsing')
smut@google.comc85ac942015-09-15 16:34:43 +00003820 parser.add_option('-j', '--json-file',
Stefan Zager1306bd02017-06-22 19:26:46 -07003821 help='File to write JSON summary to, or "-" for stdout')
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003822 options, args = parser.parse_args(args)
maruel@chromium.org9977a2e2012-06-06 22:30:56 +00003823
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003824 issue = None
3825 if options.issue:
3826 try:
3827 issue = int(options.issue)
3828 except ValueError:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00003829 DieWithError('A review issue ID is expected to be a number.')
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003830
Edward Lemur934836a2019-09-09 20:16:54 +00003831 cl = Changelist(issue=issue)
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003832
3833 if options.comment:
Sergiy Byelozyorovcb629a42018-10-28 19:20:39 +00003834 cl.AddComment(options.comment, options.publish)
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003835 return 0
3836
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07003837 summary = sorted(cl.GetCommentsSummary(readable=options.readable),
3838 key=lambda c: c.date)
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01003839 for comment in summary:
3840 if comment.disapproval:
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003841 color = Fore.RED
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01003842 elif comment.approval:
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003843 color = Fore.GREEN
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01003844 elif comment.sender == cl.GetIssueOwner():
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003845 color = Fore.MAGENTA
Quinten Yearsley0e617c02019-02-20 00:37:03 +00003846 elif comment.autogenerated:
3847 color = Fore.CYAN
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003848 else:
3849 color = Fore.BLUE
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01003850 print('\n%s%s %s%s\n%s' % (
3851 color,
3852 comment.date.strftime('%Y-%m-%d %H:%M:%S UTC'),
3853 comment.sender,
3854 Fore.RESET,
3855 '\n'.join(' ' + l for l in comment.message.strip().splitlines())))
3856
smut@google.comc85ac942015-09-15 16:34:43 +00003857 if options.json_file:
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01003858 def pre_serialize(c):
Edward Lemur79d4f992019-11-11 23:49:02 +00003859 dct = c._asdict().copy()
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01003860 dct['date'] = dct['date'].strftime('%Y-%m-%d %H:%M:%S.%f')
3861 return dct
Edward Lemur79d4f992019-11-11 23:49:02 +00003862 write_json(options.json_file, [pre_serialize(x) for x in summary])
maruel@chromium.org9977a2e2012-06-06 22:30:56 +00003863 return 0
3864
3865
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00003866@subcommand.usage('[codereview url or issue id]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003867@metrics.collector.collect_metrics('git cl description')
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00003868def CMDdescription(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003869 """Brings up the editor for the current CL's description."""
smut@google.com34fb6b12015-07-13 20:03:26 +00003870 parser.add_option('-d', '--display', action='store_true',
3871 help='Display the description instead of opening an editor')
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00003872 parser.add_option('-n', '--new-description',
dnjba1b0f32016-09-02 12:37:42 -07003873 help='New description to set for this issue (- for stdin, '
3874 '+ to load from local commit HEAD)')
dsansomee2d6fd92016-09-08 00:10:47 -07003875 parser.add_option('-f', '--force', action='store_true',
3876 help='Delete any unpublished Gerrit edits for this issue '
3877 'without prompting')
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00003878
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00003879 options, args = parser.parse_args(args)
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00003880
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01003881 target_issue_arg = None
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00003882 if len(args) > 0:
Edward Lemurf38bc172019-09-03 21:02:13 +00003883 target_issue_arg = ParseIssueNumberArgument(args[0])
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01003884 if not target_issue_arg.valid:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00003885 parser.error('Invalid issue ID or URL.')
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00003886
Edward Lemur934836a2019-09-09 20:16:54 +00003887 kwargs = {}
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01003888 if target_issue_arg:
3889 kwargs['issue'] = target_issue_arg.issue
3890 kwargs['codereview_host'] = target_issue_arg.hostname
martiniss6eda05f2016-06-30 10:18:35 -07003891
3892 cl = Changelist(**kwargs)
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00003893 if not cl.GetIssue():
3894 DieWithError('This branch has no associated changelist.')
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02003895
Edward Lemur678a6842019-10-03 22:25:05 +00003896 if args and not args[0].isdigit():
Edward Lemurf38bc172019-09-03 21:02:13 +00003897 logging.info('canonical issue/change URL: %s\n', cl.GetIssueURL())
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02003898
Edward Lemur6c6827c2020-02-06 21:15:18 +00003899 description = ChangeDescription(cl.FetchDescription())
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00003900
smut@google.com34fb6b12015-07-13 20:03:26 +00003901 if options.display:
vapiera7fbd5a2016-06-16 09:17:49 -07003902 print(description.description)
smut@google.com34fb6b12015-07-13 20:03:26 +00003903 return 0
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00003904
3905 if options.new_description:
3906 text = options.new_description
3907 if text == '-':
3908 text = '\n'.join(l.rstrip() for l in sys.stdin)
dnjba1b0f32016-09-02 12:37:42 -07003909 elif text == '+':
3910 base_branch = cl.GetCommonAncestorWithUpstream()
Edward Lemura12175c2020-03-09 16:58:26 +00003911 text = _create_description_from_log([base_branch])
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00003912
3913 description.set_description(text)
3914 else:
Edward Lemurf38bc172019-09-03 21:02:13 +00003915 description.prompt()
Edward Lemur6c6827c2020-02-06 21:15:18 +00003916 if cl.FetchDescription().strip() != description.description:
dsansomee2d6fd92016-09-08 00:10:47 -07003917 cl.UpdateDescription(description.description, force=options.force)
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00003918 return 0
3919
3920
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003921@metrics.collector.collect_metrics('git cl lint')
thestig@chromium.org44202a22014-03-11 19:22:18 +00003922def CMDlint(parser, args):
3923 """Runs cpplint on the current changelist."""
tzik@chromium.orgf204d4b2014-03-13 07:40:55 +00003924 parser.add_option('--filter', action='append', metavar='-x,+y',
3925 help='Comma-separated list of cpplint\'s category-filters')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00003926 options, args = parser.parse_args(args)
thestig@chromium.org44202a22014-03-11 19:22:18 +00003927
3928 # Access to a protected member _XX of a client class
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08003929 # pylint: disable=protected-access
thestig@chromium.org44202a22014-03-11 19:22:18 +00003930 try:
3931 import cpplint
3932 import cpplint_chromium
3933 except ImportError:
vapiera7fbd5a2016-06-16 09:17:49 -07003934 print('Your depot_tools is missing cpplint.py and/or cpplint_chromium.py.')
thestig@chromium.org44202a22014-03-11 19:22:18 +00003935 return 1
3936
3937 # Change the current working directory before calling lint so that it
3938 # shows the correct base.
3939 previous_cwd = os.getcwd()
3940 os.chdir(settings.GetRoot())
3941 try:
Edward Lemur934836a2019-09-09 20:16:54 +00003942 cl = Changelist()
Edward Lemur2c62b332020-03-12 22:12:33 +00003943 files = cl.GetAffectedFiles(cl.GetCommonAncestorWithUpstream())
thestig@chromium.org5839eb52014-05-30 16:20:51 +00003944 if not files:
vapiera7fbd5a2016-06-16 09:17:49 -07003945 print('Cannot lint an empty CL')
thestig@chromium.org5839eb52014-05-30 16:20:51 +00003946 return 1
thestig@chromium.org44202a22014-03-11 19:22:18 +00003947
Lei Zhangb8c62cf2020-07-15 20:09:37 +00003948 # Process cpplint arguments, if any.
3949 filters = presubmit_canned_checks.GetCppLintFilters(options.filter)
3950 command = ['--filter=' + ','.join(filters)] + args + files
tzik@chromium.orgf204d4b2014-03-13 07:40:55 +00003951 filenames = cpplint.ParseArguments(command)
thestig@chromium.org44202a22014-03-11 19:22:18 +00003952
Lei Zhang379d1ad2020-07-15 19:40:06 +00003953 include_regex = re.compile(settings.GetLintRegex())
3954 ignore_regex = re.compile(settings.GetLintIgnoreRegex())
thestig@chromium.org44202a22014-03-11 19:22:18 +00003955 extra_check_functions = [cpplint_chromium.CheckPointerDeclarationWhitespace]
3956 for filename in filenames:
Lei Zhang379d1ad2020-07-15 19:40:06 +00003957 if not include_regex.match(filename):
vapiera7fbd5a2016-06-16 09:17:49 -07003958 print('Skipping file %s' % filename)
Lei Zhang379d1ad2020-07-15 19:40:06 +00003959 continue
3960
3961 if ignore_regex.match(filename):
3962 print('Ignoring file %s' % filename)
3963 continue
3964
3965 cpplint.ProcessFile(filename, cpplint._cpplint_state.verbose_level,
3966 extra_check_functions)
thestig@chromium.org44202a22014-03-11 19:22:18 +00003967 finally:
3968 os.chdir(previous_cwd)
vapiera7fbd5a2016-06-16 09:17:49 -07003969 print('Total errors found: %d\n' % cpplint._cpplint_state.error_count)
thestig@chromium.org44202a22014-03-11 19:22:18 +00003970 if cpplint._cpplint_state.error_count != 0:
3971 return 1
3972 return 0
3973
3974
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003975@metrics.collector.collect_metrics('git cl presubmit')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003976def CMDpresubmit(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003977 """Runs presubmit tests on the current changelist."""
ilevy@chromium.org375a9022013-01-07 01:12:05 +00003978 parser.add_option('-u', '--upload', action='store_true',
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08003979 help='Run upload hook instead of the push hook')
ilevy@chromium.org375a9022013-01-07 01:12:05 +00003980 parser.add_option('-f', '--force', action='store_true',
sbc@chromium.org495ad152012-09-04 23:07:42 +00003981 help='Run checks even if tree is dirty')
Aaron Gable8076c282017-11-29 14:39:41 -08003982 parser.add_option('--all', action='store_true',
3983 help='Run checks against all files, not just modified ones')
Edward Lesmes8e282792018-04-03 18:50:29 -04003984 parser.add_option('--parallel', action='store_true',
3985 help='Run all tests specified by input_api.RunTests in all '
3986 'PRESUBMIT files in parallel.')
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003987 parser.add_option('--resultdb', action='store_true',
3988 help='Run presubmit checks in the ResultSink environment '
3989 'and send results to the ResultDB database.')
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003990 parser.add_option('--realm', help='LUCI realm if reporting to ResultDB')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00003991 options, args = parser.parse_args(args)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003992
sbc@chromium.org71437c02015-04-09 19:29:40 +00003993 if not options.force and git_common.is_dirty_git_tree('presubmit'):
vapiera7fbd5a2016-06-16 09:17:49 -07003994 print('use --force to check even if tree is dirty.')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003995 return 1
3996
Edward Lemur934836a2019-09-09 20:16:54 +00003997 cl = Changelist()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003998 if args:
3999 base_branch = args[0]
4000 else:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00004001 # Default to diffing against the common ancestor of the upstream branch.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00004002 base_branch = cl.GetCommonAncestorWithUpstream()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004003
Gregory Nisbet29d5cf82020-02-27 08:16:58 +00004004 if cl.GetIssue():
4005 description = cl.FetchDescription()
Aaron Gable8076c282017-11-29 14:39:41 -08004006 else:
Edward Lemura12175c2020-03-09 16:58:26 +00004007 description = _create_description_from_log([base_branch])
Aaron Gable8076c282017-11-29 14:39:41 -08004008
ilevy@chromium.org051ad0e2013-03-04 21:57:34 +00004009 cl.RunHook(
4010 committing=not options.upload,
4011 may_prompt=False,
4012 verbose=options.verbose,
Edward Lemur227d5102020-02-25 23:45:35 +00004013 parallel=options.parallel,
4014 upstream=base_branch,
4015 description=description,
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00004016 all_files=options.all,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00004017 resultdb=options.resultdb,
4018 realm=options.realm)
dpranke@chromium.org0a2bb372011-03-25 01:16:22 +00004019 return 0
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004020
4021
tandrii@chromium.org65874e12016-03-04 12:03:02 +00004022def GenerateGerritChangeId(message):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004023 """Returns the Change ID footer value (Ixxxxxx...xxx).
tandrii@chromium.org65874e12016-03-04 12:03:02 +00004024
4025 Works the same way as
4026 https://gerrit-review.googlesource.com/tools/hooks/commit-msg
4027 but can be called on demand on all platforms.
4028
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004029 The basic idea is to generate git hash of a state of the tree, original
4030 commit message, author/committer info and timestamps.
tandrii@chromium.org65874e12016-03-04 12:03:02 +00004031 """
4032 lines = []
4033 tree_hash = RunGitSilent(['write-tree'])
4034 lines.append('tree %s' % tree_hash.strip())
4035 code, parent = RunGitWithCode(['rev-parse', 'HEAD~0'], suppress_stderr=False)
4036 if code == 0:
4037 lines.append('parent %s' % parent.strip())
4038 author = RunGitSilent(['var', 'GIT_AUTHOR_IDENT'])
4039 lines.append('author %s' % author.strip())
4040 committer = RunGitSilent(['var', 'GIT_COMMITTER_IDENT'])
4041 lines.append('committer %s' % committer.strip())
4042 lines.append('')
4043 # Note: Gerrit's commit-hook actually cleans message of some lines and
4044 # whitespace. This code is not doing this, but it clearly won't decrease
4045 # entropy.
4046 lines.append(message)
4047 change_hash = RunCommand(['git', 'hash-object', '-t', 'commit', '--stdin'],
Raul Tambreb946b232019-03-26 14:48:46 +00004048 stdin=('\n'.join(lines)).encode())
tandrii@chromium.org65874e12016-03-04 12:03:02 +00004049 return 'I%s' % change_hash.strip()
4050
4051
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01004052def GetTargetRef(remote, remote_branch, target_branch):
wittman@chromium.org455dc922015-01-26 20:15:50 +00004053 """Computes the remote branch ref to use for the CL.
4054
4055 Args:
4056 remote (str): The git remote for the CL.
4057 remote_branch (str): The git remote branch for the CL.
4058 target_branch (str): The target branch specified by the user.
wittman@chromium.org455dc922015-01-26 20:15:50 +00004059 """
4060 if not (remote and remote_branch):
4061 return None
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00004062
wittman@chromium.org455dc922015-01-26 20:15:50 +00004063 if target_branch:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07004064 # Canonicalize branch references to the equivalent local full symbolic
wittman@chromium.org455dc922015-01-26 20:15:50 +00004065 # refs, which are then translated into the remote full symbolic refs
4066 # below.
4067 if '/' not in target_branch:
4068 remote_branch = 'refs/remotes/%s/%s' % (remote, target_branch)
4069 else:
4070 prefix_replacements = (
4071 ('^((refs/)?remotes/)?branch-heads/', 'refs/remotes/branch-heads/'),
4072 ('^((refs/)?remotes/)?%s/' % remote, 'refs/remotes/%s/' % remote),
4073 ('^(refs/)?heads/', 'refs/remotes/%s/' % remote),
4074 )
4075 match = None
4076 for regex, replacement in prefix_replacements:
4077 match = re.search(regex, target_branch)
4078 if match:
4079 remote_branch = target_branch.replace(match.group(0), replacement)
4080 break
4081 if not match:
4082 # This is a branch path but not one we recognize; use as-is.
4083 remote_branch = target_branch
rmistry@google.comc68112d2015-03-03 12:48:06 +00004084 elif remote_branch in REFS_THAT_ALIAS_TO_OTHER_REFS:
4085 # Handle the refs that need to land in different refs.
4086 remote_branch = REFS_THAT_ALIAS_TO_OTHER_REFS[remote_branch]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00004087
Josip Sokcevicc39ab992020-09-24 20:09:15 +00004088 # Migration to new default branch, only if available on remote.
4089 allow_push_on_master = bool(os.environ.get("ALLOW_PUSH_TO_MASTER", None))
4090 if remote_branch == DEFAULT_OLD_BRANCH and not allow_push_on_master:
4091 if RunGit(['show-branch', DEFAULT_NEW_BRANCH], error_ok=True,
4092 stderr=subprocess2.PIPE):
4093 # TODO(crbug.com/ID): Print location to local git migration script.
4094 print("WARNING: Using new branch name %s instead of %s" % (
4095 DEFAULT_NEW_BRANCH, DEFAULT_OLD_BRANCH))
4096 remote_branch = DEFAULT_NEW_BRANCH
4097
wittman@chromium.org455dc922015-01-26 20:15:50 +00004098 # Create the true path to the remote branch.
4099 # Does the following translation:
4100 # * refs/remotes/origin/refs/diff/test -> refs/diff/test
Josip Sokcevicc39ab992020-09-24 20:09:15 +00004101 # * refs/remotes/origin/main -> refs/heads/main
wittman@chromium.org455dc922015-01-26 20:15:50 +00004102 # * refs/remotes/branch-heads/test -> refs/branch-heads/test
4103 if remote_branch.startswith('refs/remotes/%s/refs/' % remote):
4104 remote_branch = remote_branch.replace('refs/remotes/%s/' % remote, '')
4105 elif remote_branch.startswith('refs/remotes/%s/' % remote):
4106 remote_branch = remote_branch.replace('refs/remotes/%s/' % remote,
4107 'refs/heads/')
4108 elif remote_branch.startswith('refs/remotes/branch-heads'):
4109 remote_branch = remote_branch.replace('refs/remotes/', 'refs/')
Andrii Shyshkalov768f1d82016-12-08 15:10:13 +01004110
wittman@chromium.org455dc922015-01-26 20:15:50 +00004111 return remote_branch
4112
4113
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004114def cleanup_list(l):
4115 """Fixes a list so that comma separated items are put as individual items.
4116
4117 So that "--reviewers joe@c,john@c --reviewers joa@c" results in
4118 options.reviewers == sorted(['joe@c', 'john@c', 'joa@c']).
4119 """
4120 items = sum((i.split(',') for i in l), [])
4121 stripped_items = (i.strip() for i in items)
4122 return sorted(filter(None, stripped_items))
4123
4124
Aaron Gable4db38df2017-11-03 14:59:07 -07004125@subcommand.usage('[flags]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004126@metrics.collector.collect_metrics('git cl upload')
ukai@chromium.orge8077812012-02-03 03:41:46 +00004127def CMDupload(parser, args):
rmistry@google.com78948ed2015-07-08 23:09:57 +00004128 """Uploads the current changelist to codereview.
4129
4130 Can skip dependency patchset uploads for a branch by running:
4131 git config branch.branch_name.skip-deps-uploads True
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004132 To unset, run:
rmistry@google.com78948ed2015-07-08 23:09:57 +00004133 git config --unset branch.branch_name.skip-deps-uploads
4134 Can also set the above globally by using the --global flag.
Dominic Battre7d1c4842017-10-27 09:17:28 +02004135
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004136 If the name of the checked out branch starts with "bug-" or "fix-" followed
4137 by a bug number, this bug number is automatically populated in the CL
Dominic Battre7d1c4842017-10-27 09:17:28 +02004138 description.
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004139
4140 If subject contains text in square brackets or has "<text>: " prefix, such
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004141 text(s) is treated as Gerrit hashtags. For example, CLs with subjects:
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004142 [git-cl] add support for hashtags
4143 Foo bar: implement foo
4144 will be hashtagged with "git-cl" and "foo-bar" respectively.
rmistry@google.com78948ed2015-07-08 23:09:57 +00004145 """
ukai@chromium.orge8077812012-02-03 03:41:46 +00004146 parser.add_option('--bypass-hooks', action='store_true', dest='bypass_hooks',
4147 help='bypass upload presubmit hook')
brettw@chromium.orgb65c43c2013-06-10 22:04:49 +00004148 parser.add_option('--bypass-watchlists', action='store_true',
4149 dest='bypass_watchlists',
4150 help='bypass watchlists auto CC-ing reviewers')
Aaron Gablef7543cd2017-07-20 14:26:31 -07004151 parser.add_option('-f', '--force', action='store_true', dest='force',
ukai@chromium.orge8077812012-02-03 03:41:46 +00004152 help="force yes to questions (don't prompt)")
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004153 parser.add_option('--message', '-m', dest='message',
4154 help='message for patchset')
tandriif9aefb72016-07-01 09:06:51 -07004155 parser.add_option('-b', '--bug',
4156 help='pre-populate the bug number(s) for this issue. '
4157 'If several, separate with commas')
tandriib80458a2016-06-23 12:20:07 -07004158 parser.add_option('--message-file', dest='message_file',
4159 help='file which contains message for patchset')
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004160 parser.add_option('--title', '-t', dest='title',
4161 help='title for patchset')
Mario Bianuccicebfb4e2020-07-22 23:08:16 +00004162 parser.add_option('-T', '--skip-title', action='store_true',
4163 dest='skip_title',
4164 help='Use the most recent commit message as the title of '
4165 'the patchset')
ukai@chromium.orge8077812012-02-03 03:41:46 +00004166 parser.add_option('-r', '--reviewers',
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004167 action='append', default=[],
ukai@chromium.orge8077812012-02-03 03:41:46 +00004168 help='reviewer email addresses')
Robert Iannucci6c98dc62017-04-18 11:38:00 -07004169 parser.add_option('--tbrs',
4170 action='append', default=[],
4171 help='TBR email addresses')
ukai@chromium.orge8077812012-02-03 03:41:46 +00004172 parser.add_option('--cc',
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004173 action='append', default=[],
ukai@chromium.orge8077812012-02-03 03:41:46 +00004174 help='cc email addresses')
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004175 parser.add_option('--hashtag', dest='hashtags',
4176 action='append', default=[],
4177 help=('Gerrit hashtag for new CL; '
4178 'can be applied multiple times'))
adamk@chromium.org36f47302013-04-05 01:08:31 +00004179 parser.add_option('-s', '--send-mail', action='store_true',
Aaron Gable59f48512017-01-12 10:54:46 -08004180 help='send email to reviewer(s) and cc(s) immediately')
ukai@chromium.org8ef7ab22012-11-28 04:24:52 +00004181 parser.add_option('--target_branch',
pgervais@chromium.orgb9f27512014-08-08 15:52:33 +00004182 '--target-branch',
wittman@chromium.org455dc922015-01-26 20:15:50 +00004183 metavar='TARGET',
4184 help='Apply CL to remote ref TARGET. ' +
Josip Sokcevicc39ab992020-09-24 20:09:15 +00004185 'Default: remote branch head, or main')
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00004186 parser.add_option('--squash', action='store_true',
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004187 help='Squash multiple commits into one')
Mike Frysingera989d552019-08-14 20:51:23 +00004188 parser.add_option('--no-squash', action='store_false', dest='squash',
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004189 help='Don\'t squash multiple commits into one')
rmistry9eadede2016-09-19 11:22:43 -07004190 parser.add_option('--topic', default=None,
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004191 help='Topic to specify when uploading')
Robert Iannuccif2708bd2017-04-17 15:49:02 -07004192 parser.add_option('--tbr-owners', dest='add_owners_to', action='store_const',
4193 const='TBR', help='add a set of OWNERS to TBR')
4194 parser.add_option('--r-owners', dest='add_owners_to', action='store_const',
4195 const='R', help='add a set of OWNERS to R')
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00004196 parser.add_option('-c', '--use-commit-queue', action='store_true',
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004197 default=False,
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00004198 help='tell the CQ to commit this patchset; '
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004199 'implies --send-mail')
4200 parser.add_option('-d', '--cq-dry-run',
4201 action='store_true', default=False,
rmistry@google.comef966222015-04-07 11:15:01 +00004202 help='Send the patchset to do a CQ dry run right after '
4203 'upload.')
Edward Lesmes10c3dd62021-02-08 21:13:57 +00004204 parser.add_option('--set-bot-commit', action='store_true',
4205 help=optparse.SUPPRESS_HELP)
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +00004206 parser.add_option('--preserve-tryjobs', action='store_true',
4207 help='instruct the CQ to let tryjobs running even after '
4208 'new patchsets are uploaded instead of canceling '
4209 'prior patchset\' tryjobs')
rmistry@google.com2dd99862015-06-22 12:22:18 +00004210 parser.add_option('--dependencies', action='store_true',
4211 help='Uploads CLs of all the local branches that depend on '
4212 'the current branch')
Ravi Mistry31e7d562018-04-02 12:53:57 -04004213 parser.add_option('-a', '--enable-auto-submit', action='store_true',
4214 help='Sends your change to the CQ after an approval. Only '
4215 'works on repos that have the Auto-Submit label '
4216 'enabled')
Edward Lesmes8e282792018-04-03 18:50:29 -04004217 parser.add_option('--parallel', action='store_true',
4218 help='Run all tests specified by input_api.RunTests in all '
4219 'PRESUBMIT files in parallel.')
Sergiy Byelozyorov1aa405f2018-09-18 17:38:43 +00004220 parser.add_option('--no-autocc', action='store_true',
4221 help='Disables automatic addition of CC emails')
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004222 parser.add_option('--private', action='store_true',
Sergiy Byelozyorov1aa405f2018-09-18 17:38:43 +00004223 help='Set the review private. This implies --no-autocc.')
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004224 parser.add_option('-R', '--retry-failed', action='store_true',
4225 help='Retry failed tryjobs from old patchset immediately '
4226 'after uploading new patchset. Cannot be used with '
4227 '--use-commit-queue or --cq-dry-run.')
4228 parser.add_option('--buildbucket-host', default='cr-buildbucket.appspot.com',
4229 help='Host of buildbucket. The default host is %default.')
Dan Beamd8b04ca2019-10-10 21:23:26 +00004230 parser.add_option('--fixed', '-x',
4231 help='List of bugs that will be commented on and marked '
4232 'fixed (pre-populates "Fixed:" tag). Same format as '
4233 '-b option / "Bug:" tag. If fixing several issues, '
4234 'separate with commas.')
Josipe827b0f2020-01-30 00:07:20 +00004235 parser.add_option('--edit-description', action='store_true', default=False,
4236 help='Modify description before upload. Cannot be used '
4237 'with --force. It is a noop when --no-squash is set '
4238 'or a new commit is created.')
Ng Zhi Ancdaf0be2020-05-27 20:57:28 +00004239 parser.add_option('--git-completion-helper', action="store_true",
4240 help=optparse.SUPPRESS_HELP)
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00004241 parser.add_option('--resultdb', action='store_true',
4242 help='Run presubmit checks in the ResultSink environment '
4243 'and send results to the ResultDB database.')
Saagar Sanghavi03b15132020-08-10 16:43:41 +00004244 parser.add_option('--realm', help='LUCI realm if reporting to ResultDB')
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +00004245 parser.add_option('-o',
4246 '--push-options',
4247 action='append',
4248 default=[],
4249 help='Transmit the given string to the server when '
4250 'performing git push (pass-through). See git-push '
4251 'documentation for more details.')
Gregory Nisbet48d9e1e2021-04-15 23:35:54 +00004252 parser.add_option('--no-add-changeid',
4253 action='store_true',
4254 dest='no_add_changeid',
4255 help='Do not add change-ids to messages.')
Sergiy Byelozyorov1aa405f2018-09-18 17:38:43 +00004256
rmistry@google.com2dd99862015-06-22 12:22:18 +00004257 orig_args = args
ukai@chromium.orge8077812012-02-03 03:41:46 +00004258 (options, args) = parser.parse_args(args)
4259
Ng Zhi Ancdaf0be2020-05-27 20:57:28 +00004260 if options.git_completion_helper:
Edward Lesmesb7db1832020-06-22 20:22:27 +00004261 print(' '.join(opt.get_opt_string() for opt in parser.option_list
4262 if opt.help != optparse.SUPPRESS_HELP))
4263 return
Ng Zhi Ancdaf0be2020-05-27 20:57:28 +00004264
sbc@chromium.org71437c02015-04-09 19:29:40 +00004265 if git_common.is_dirty_git_tree('upload'):
ukai@chromium.orge8077812012-02-03 03:41:46 +00004266 return 1
4267
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004268 options.reviewers = cleanup_list(options.reviewers)
Robert Iannucci6c98dc62017-04-18 11:38:00 -07004269 options.tbrs = cleanup_list(options.tbrs)
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004270 options.cc = cleanup_list(options.cc)
4271
Josipe827b0f2020-01-30 00:07:20 +00004272 if options.edit_description and options.force:
4273 parser.error('Only one of --force and --edit-description allowed')
4274
tandriib80458a2016-06-23 12:20:07 -07004275 if options.message_file:
4276 if options.message:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004277 parser.error('Only one of --message and --message-file allowed.')
tandriib80458a2016-06-23 12:20:07 -07004278 options.message = gclient_utils.FileRead(options.message_file)
tandriib80458a2016-06-23 12:20:07 -07004279
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004280 if ([options.cq_dry_run,
4281 options.use_commit_queue,
4282 options.retry_failed].count(True) > 1):
4283 parser.error('Only one of --use-commit-queue, --cq-dry-run, or '
4284 '--retry-failed is allowed.')
tandrii4d0545a2016-07-06 03:56:49 -07004285
Mario Bianuccicebfb4e2020-07-22 23:08:16 +00004286 if options.skip_title and options.title:
4287 parser.error('Only one of --title and --skip-title allowed.')
4288
Aaron Gableedbc4132017-09-11 13:22:28 -07004289 if options.use_commit_queue:
4290 options.send_mail = True
4291
Edward Lesmes0dd54822020-03-26 18:24:25 +00004292 if options.squash is None:
4293 # Load default for user, repo, squash=true, in this order.
4294 options.squash = settings.GetSquashGerritUploads()
4295
Josip Sokcevic1cabb172021-04-08 19:15:35 +00004296 cl = Changelist(branchref=options.target_branch)
Edward Lesmes7677e5c2020-02-19 20:39:03 +00004297 # Warm change details cache now to avoid RPCs later, reducing latency for
4298 # developers.
4299 if cl.GetIssue():
4300 cl._GetChangeDetail(
4301 ['DETAILED_ACCOUNTS', 'CURRENT_REVISION', 'CURRENT_COMMIT', 'LABELS'])
4302
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004303 if options.retry_failed and not cl.GetIssue():
4304 print('No previous patchsets, so --retry-failed has no effect.')
4305 options.retry_failed = False
Edward Lesmes7677e5c2020-02-19 20:39:03 +00004306
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004307 # cl.GetMostRecentPatchset uses cached information, and can return the last
4308 # patchset before upload. Calling it here makes it clear that it's the
4309 # last patchset before upload. Note that GetMostRecentPatchset will fail
4310 # if no CL has been uploaded yet.
4311 if options.retry_failed:
4312 patchset = cl.GetMostRecentPatchset()
Andrii Shyshkalov9f274432018-10-15 16:40:23 +00004313
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004314 ret = cl.CMDUpload(options, args, orig_args)
4315
4316 if options.retry_failed:
4317 if ret != 0:
4318 print('Upload failed, so --retry-failed has no effect.')
4319 return ret
Andrii Shyshkalov1ad58112019-10-08 01:46:14 +00004320 builds, _ = _fetch_latest_builds(
Edward Lemur5b929a42019-10-21 17:57:39 +00004321 cl, options.buildbucket_host, latest_patchset=patchset)
Edward Lemur45768512020-03-02 19:03:14 +00004322 jobs = _filter_failed_for_retry(builds)
4323 if len(jobs) == 0:
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004324 print('No failed tryjobs, so --retry-failed has no effect.')
4325 return ret
Quinten Yearsley777660f2020-03-04 23:37:06 +00004326 _trigger_tryjobs(cl, jobs, options, patchset + 1)
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004327
4328 return ret
ukai@chromium.orge8077812012-02-03 03:41:46 +00004329
4330
Francois Dorayd42c6812017-05-30 15:10:20 -04004331@subcommand.usage('--description=<description file>')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004332@metrics.collector.collect_metrics('git cl split')
Francois Dorayd42c6812017-05-30 15:10:20 -04004333def CMDsplit(parser, args):
4334 """Splits a branch into smaller branches and uploads CLs.
4335
4336 Creates a branch and uploads a CL for each group of files modified in the
4337 current branch that share a common OWNERS file. In the CL description and
Edward Lemurac5c55f2020-02-29 00:17:16 +00004338 comment, the string '$directory', is replaced with the directory containing
4339 the shared OWNERS file.
Francois Dorayd42c6812017-05-30 15:10:20 -04004340 """
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004341 parser.add_option('-d', '--description', dest='description_file',
4342 help='A text file containing a CL description in which '
4343 '$directory will be replaced by each CL\'s directory.')
4344 parser.add_option('-c', '--comment', dest='comment_file',
4345 help='A text file containing a CL comment.')
4346 parser.add_option('-n', '--dry-run', dest='dry_run', action='store_true',
Chris Watkinsba28e462017-12-13 11:22:17 +11004347 default=False,
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004348 help='List the files and reviewers for each CL that would '
4349 'be created, but don\'t create branches or CLs.')
4350 parser.add_option('--cq-dry-run', action='store_true',
4351 help='If set, will do a cq dry run for each uploaded CL. '
4352 'Please be careful when doing this; more than ~10 CLs '
4353 'has the potential to overload our build '
4354 'infrastructure. Try to upload these not during high '
4355 'load times (usually 11-3 Mountain View time). Email '
4356 'infra-dev@chromium.org with any questions.')
Takuto Ikuta51eca592019-02-14 19:40:52 +00004357 parser.add_option('-a', '--enable-auto-submit', action='store_true',
4358 default=True,
4359 help='Sends your change to the CQ after an approval. Only '
4360 'works on repos that have the Auto-Submit label '
4361 'enabled')
Francois Dorayd42c6812017-05-30 15:10:20 -04004362 options, _ = parser.parse_args(args)
4363
4364 if not options.description_file:
4365 parser.error('No --description flag specified.')
4366
4367 def WrappedCMDupload(args):
4368 return CMDupload(OptionParser(), args)
4369
Edward Lemur2c62b332020-03-12 22:12:33 +00004370 return split_cl.SplitCl(
4371 options.description_file, options.comment_file, Changelist,
4372 WrappedCMDupload, options.dry_run, options.cq_dry_run,
4373 options.enable_auto_submit, settings.GetRoot())
Francois Dorayd42c6812017-05-30 15:10:20 -04004374
4375
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004376@subcommand.usage('DEPRECATED')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004377@metrics.collector.collect_metrics('git cl commit')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004378def CMDdcommit(parser, args):
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004379 """DEPRECATED: Used to commit the current changelist via git-svn."""
4380 message = ('git-cl no longer supports committing to SVN repositories via '
4381 'git-svn. You probably want to use `git cl land` instead.')
4382 print(message)
4383 return 1
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004384
4385
maruel@chromium.org0633fb42013-08-16 20:06:14 +00004386@subcommand.usage('[upstream branch to apply against]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004387@metrics.collector.collect_metrics('git cl land')
pgervais@chromium.orgcee6dc42014-05-07 17:04:03 +00004388def CMDland(parser, args):
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004389 """Commits the current changelist via git.
4390
4391 In case of Gerrit, uses Gerrit REST api to "submit" the issue, which pushes
4392 upstream and closes the issue automatically and atomically.
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004393 """
4394 parser.add_option('--bypass-hooks', action='store_true', dest='bypass_hooks',
4395 help='bypass upload presubmit hook')
Aaron Gablef7543cd2017-07-20 14:26:31 -07004396 parser.add_option('-f', '--force', action='store_true', dest='force',
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004397 help="force yes to questions (don't prompt)")
Edward Lesmes67b3faa2018-04-13 17:50:52 -04004398 parser.add_option('--parallel', action='store_true',
4399 help='Run all tests specified by input_api.RunTests in all '
4400 'PRESUBMIT files in parallel.')
Saagar Sanghavi03b15132020-08-10 16:43:41 +00004401 parser.add_option('--resultdb', action='store_true',
4402 help='Run presubmit checks in the ResultSink environment '
4403 'and send results to the ResultDB database.')
4404 parser.add_option('--realm', help='LUCI realm if reporting to ResultDB')
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004405 (options, args) = parser.parse_args(args)
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004406
Edward Lemur934836a2019-09-09 20:16:54 +00004407 cl = Changelist()
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004408
Robert Iannucci2e73d432018-03-14 01:10:47 -07004409 if not cl.GetIssue():
4410 DieWithError('You must upload the change first to Gerrit.\n'
4411 ' If you would rather have `git cl land` upload '
4412 'automatically for you, see http://crbug.com/642759')
Saagar Sanghavi03b15132020-08-10 16:43:41 +00004413 return cl.CMDLand(options.force, options.bypass_hooks, options.verbose,
4414 options.parallel, options.resultdb, options.realm)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004415
4416
dsinclair@chromium.orgfbed6562015-09-25 21:22:36 +00004417@subcommand.usage('<patch url or issue id or issue url>')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004418@metrics.collector.collect_metrics('git cl patch')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004419def CMDpatch(parser, args):
marq@chromium.orge5e59002013-10-02 23:21:25 +00004420 """Patches in a code review."""
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004421 parser.add_option('-b', dest='newbranch',
4422 help='create a new branch off trunk for the patch')
qsr@chromium.org1ef44af2013-10-16 16:24:32 +00004423 parser.add_option('-f', '--force', action='store_true',
Aaron Gable62619a32017-06-16 08:22:09 -07004424 help='overwrite state on the current or chosen branch')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004425 parser.add_option('-n', '--no-commit', action='store_true', dest='nocommit',
Edward Lemurf38bc172019-09-03 21:02:13 +00004426 help='don\'t commit after patch applies.')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004427
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00004428 group = optparse.OptionGroup(
4429 parser,
4430 'Options for continuing work on the current issue uploaded from a '
4431 'different clone (e.g. different machine). Must be used independently '
4432 'from the other options. No issue number should be specified, and the '
4433 'branch must have an issue number associated with it')
4434 group.add_option('--reapply', action='store_true', dest='reapply',
4435 help='Reset the branch and reapply the issue.\n'
4436 'CAUTION: This will undo any local changes in this '
4437 'branch')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004438
4439 group.add_option('--pull', action='store_true', dest='pull',
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00004440 help='Performs a pull before reapplying.')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004441 parser.add_option_group(group)
4442
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004443 (options, args) = parser.parse_args(args)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004444
Andrii Shyshkalov18975322017-01-25 16:44:13 +01004445 if options.reapply:
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004446 if options.newbranch:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004447 parser.error('--reapply works on the current branch only.')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004448 if len(args) > 0:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004449 parser.error('--reapply implies no additional arguments.')
dsinclair@chromium.orgfbed6562015-09-25 21:22:36 +00004450
Edward Lemur934836a2019-09-09 20:16:54 +00004451 cl = Changelist()
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004452 if not cl.GetIssue():
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004453 parser.error('Current branch must have an associated issue.')
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004454
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004455 upstream = cl.GetUpstreamBranch()
Andrii Shyshkalov18975322017-01-25 16:44:13 +01004456 if upstream is None:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004457 parser.error('No upstream branch specified. Cannot reset branch.')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004458
4459 RunGit(['reset', '--hard', upstream])
4460 if options.pull:
4461 RunGit(['pull'])
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004462
Edward Lemur678a6842019-10-03 22:25:05 +00004463 target_issue_arg = ParseIssueNumberArgument(cl.GetIssue())
Bruce Dawsonf362f6f2021-02-18 23:15:17 +00004464 return cl.CMDPatchWithParsedIssue(target_issue_arg, options.nocommit, False,
4465 False)
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004466
4467 if len(args) != 1 or not args[0]:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004468 parser.error('Must specify issue number or URL.')
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004469
Edward Lemurf38bc172019-09-03 21:02:13 +00004470 target_issue_arg = ParseIssueNumberArgument(args[0])
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004471 if not target_issue_arg.valid:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004472 parser.error('Invalid issue ID or URL.')
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004473
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004474 # We don't want uncommitted changes mixed up with the patch.
4475 if git_common.is_dirty_git_tree('patch'):
dsinclair@chromium.orgfbed6562015-09-25 21:22:36 +00004476 return 1
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004477
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004478 if options.newbranch:
4479 if options.force:
4480 RunGit(['branch', '-D', options.newbranch],
4481 stderr=subprocess2.PIPE, error_ok=True)
Edward Lemur84101642020-02-21 21:40:34 +00004482 git_new_branch.create_new_branch(options.newbranch)
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004483
Edward Lemur678a6842019-10-03 22:25:05 +00004484 cl = Changelist(
4485 codereview_host=target_issue_arg.hostname, issue=target_issue_arg.issue)
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004486
Edward Lemur678a6842019-10-03 22:25:05 +00004487 if not args[0].isdigit():
Edward Lemurf38bc172019-09-03 21:02:13 +00004488 print('canonical issue/change URL: %s\n' % cl.GetIssueURL())
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004489
Bruce Dawsonf362f6f2021-02-18 23:15:17 +00004490 return cl.CMDPatchWithParsedIssue(target_issue_arg, options.nocommit,
4491 options.force, options.newbranch)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004492
4493
jochen@chromium.org3ec0d542014-01-14 20:00:03 +00004494def GetTreeStatus(url=None):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004495 """Fetches the tree status and returns either 'open', 'closed',
4496 'unknown' or 'unset'."""
jochen@chromium.org3ec0d542014-01-14 20:00:03 +00004497 url = url or settings.GetTreeStatusUrl(error_ok=True)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004498 if url:
Daniel McArdle8b4eeff2020-07-20 17:02:47 +00004499 status = str(urllib.request.urlopen(url).read().lower())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004500 if status.find('closed') != -1 or status == '0':
4501 return 'closed'
4502 elif status.find('open') != -1 or status == '1':
4503 return 'open'
4504 return 'unknown'
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004505 return 'unset'
4506
dpranke@chromium.org970c5222011-03-12 00:32:24 +00004507
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004508def GetTreeStatusReason():
4509 """Fetches the tree status from a json url and returns the message
4510 with the reason for the tree to be opened or closed."""
msb@chromium.orgbf1a7ba2011-02-01 16:21:46 +00004511 url = settings.GetTreeStatusUrl()
Daniel McArdle8b4eeff2020-07-20 17:02:47 +00004512 json_url = urllib.parse.urljoin(url, '/current?format=json')
Edward Lemur79d4f992019-11-11 23:49:02 +00004513 connection = urllib.request.urlopen(json_url)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004514 status = json.loads(connection.read())
4515 connection.close()
4516 return status['message']
4517
dpranke@chromium.org970c5222011-03-12 00:32:24 +00004518
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004519@metrics.collector.collect_metrics('git cl tree')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004520def CMDtree(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004521 """Shows the status of the tree."""
dpranke@chromium.org97ae58e2011-03-18 00:29:20 +00004522 _, args = parser.parse_args(args)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004523 status = GetTreeStatus()
4524 if 'unset' == status:
vapiera7fbd5a2016-06-16 09:17:49 -07004525 print('You must configure your tree status URL by running "git cl config".')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004526 return 2
4527
vapiera7fbd5a2016-06-16 09:17:49 -07004528 print('The tree is %s' % status)
4529 print()
4530 print(GetTreeStatusReason())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004531 if status != 'open':
4532 return 1
4533 return 0
4534
4535
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004536@metrics.collector.collect_metrics('git cl try')
maruel@chromium.org15192402012-09-06 12:38:29 +00004537def CMDtry(parser, args):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004538 """Triggers tryjobs using either Buildbucket or CQ dry run."""
4539 group = optparse.OptionGroup(parser, 'Tryjob options')
maruel@chromium.org15192402012-09-06 12:38:29 +00004540 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004541 '-b', '--bot', action='append',
4542 help=('IMPORTANT: specify ONE builder per --bot flag. Use it multiple '
4543 'times to specify multiple builders. ex: '
4544 '"-b win_rel -b win_layout". See '
4545 'the try server waterfall for the builders name and the tests '
4546 'available.'))
maruel@chromium.org15192402012-09-06 12:38:29 +00004547 group.add_option(
borenet6c0efe62016-10-19 08:13:29 -07004548 '-B', '--bucket', default='',
4549 help=('Buildbucket bucket to send the try requests.'))
4550 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004551 '-r', '--revision',
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004552 help='Revision to use for the tryjob; default: the revision will '
tandriif7b29d42016-10-07 08:45:41 -07004553 'be determined by the try recipe that builder runs, which usually '
Josip Sokcevicc39ab992020-09-24 20:09:15 +00004554 'defaults to HEAD of origin/master or origin/main')
maruel@chromium.org15192402012-09-06 12:38:29 +00004555 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004556 '-c', '--clobber', action='store_true', default=False,
tandriif7b29d42016-10-07 08:45:41 -07004557 help='Force a clobber before building; that is don\'t do an '
tandrii1838bad2016-10-06 00:10:52 -07004558 'incremental build')
maruel@chromium.org15192402012-09-06 12:38:29 +00004559 group.add_option(
Andrii Shyshkalovf9648b52018-02-21 22:32:42 -08004560 '--category', default='git_cl_try', help='Specify custom build category.')
4561 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004562 '--project',
4563 help='Override which project to use. Projects are defined '
tandriif7b29d42016-10-07 08:45:41 -07004564 'in recipe to determine to which repository or directory to '
4565 'apply the patch')
maruel@chromium.org15192402012-09-06 12:38:29 +00004566 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004567 '-p', '--property', dest='properties', action='append', default=[],
4568 help='Specify generic properties in the form -p key1=value1 -p '
tandriif7b29d42016-10-07 08:45:41 -07004569 'key2=value2 etc. The value will be treated as '
4570 'json if decodable, or as string otherwise. '
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004571 'NOTE: using this may make your tryjob not usable for CQ, '
4572 'which will then schedule another tryjob with default properties')
sheyang@chromium.orgdb375572015-08-17 19:22:23 +00004573 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004574 '--buildbucket-host', default='cr-buildbucket.appspot.com',
4575 help='Host of buildbucket. The default host is %default.')
maruel@chromium.org15192402012-09-06 12:38:29 +00004576 parser.add_option_group(group)
Quinten Yearsley983111f2019-09-26 17:18:48 +00004577 parser.add_option(
4578 '-R', '--retry-failed', action='store_true', default=False,
4579 help='Retry failed jobs from the latest set of tryjobs. '
4580 'Not allowed with --bucket and --bot options.')
Edward Lemur52969c92020-02-06 18:15:28 +00004581 parser.add_option(
4582 '-i', '--issue', type=int,
4583 help='Operate on this issue instead of the current branch\'s implicit '
4584 'issue.')
maruel@chromium.org15192402012-09-06 12:38:29 +00004585 options, args = parser.parse_args(args)
4586
machenbach@chromium.org45453142015-09-15 08:45:22 +00004587 # Make sure that all properties are prop=value pairs.
4588 bad_params = [x for x in options.properties if '=' not in x]
4589 if bad_params:
4590 parser.error('Got properties with missing "=": %s' % bad_params)
4591
maruel@chromium.org15192402012-09-06 12:38:29 +00004592 if args:
4593 parser.error('Unknown arguments: %s' % args)
4594
Edward Lemur934836a2019-09-09 20:16:54 +00004595 cl = Changelist(issue=options.issue)
maruel@chromium.org15192402012-09-06 12:38:29 +00004596 if not cl.GetIssue():
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004597 parser.error('Need to upload first.')
maruel@chromium.org15192402012-09-06 12:38:29 +00004598
Edward Lemurf38bc172019-09-03 21:02:13 +00004599 # HACK: warm up Gerrit change detail cache to save on RPCs.
Edward Lemur125d60a2019-09-13 18:25:41 +00004600 cl._GetChangeDetail(['DETAILED_ACCOUNTS', 'ALL_REVISIONS'])
Andrii Shyshkaloveadad922017-01-26 09:38:30 +01004601
tandriie113dfd2016-10-11 10:20:12 -07004602 error_message = cl.CannotTriggerTryJobReason()
4603 if error_message:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004604 parser.error('Can\'t trigger tryjobs: %s' % error_message)
jrobbins@chromium.org16f10f72014-06-24 22:14:36 +00004605
Edward Lemur45768512020-03-02 19:03:14 +00004606 if options.bot:
4607 if options.retry_failed:
4608 parser.error('--bot is not compatible with --retry-failed.')
4609 if not options.bucket:
4610 parser.error('A bucket (e.g. "chromium/try") is required.')
4611
4612 triggered = [b for b in options.bot if 'triggered' in b]
4613 if triggered:
4614 parser.error(
4615 'Cannot schedule builds on triggered bots: %s.\n'
4616 'This type of bot requires an initial job from a parent (usually a '
4617 'builder). Schedule a job on the parent instead.\n' % triggered)
4618
4619 if options.bucket.startswith('.master'):
4620 parser.error('Buildbot masters are not supported.')
4621
4622 project, bucket = _parse_bucket(options.bucket)
4623 if project is None or bucket is None:
4624 parser.error('Invalid bucket: %s.' % options.bucket)
4625 jobs = sorted((project, bucket, bot) for bot in options.bot)
4626 elif options.retry_failed:
Quinten Yearsley983111f2019-09-26 17:18:48 +00004627 print('Searching for failed tryjobs...')
Edward Lemur5b929a42019-10-21 17:57:39 +00004628 builds, patchset = _fetch_latest_builds(cl, options.buildbucket_host)
Quinten Yearsley983111f2019-09-26 17:18:48 +00004629 if options.verbose:
4630 print('Got %d builds in patchset #%d' % (len(builds), patchset))
Edward Lemur45768512020-03-02 19:03:14 +00004631 jobs = _filter_failed_for_retry(builds)
4632 if not jobs:
Quinten Yearsley983111f2019-09-26 17:18:48 +00004633 print('There are no failed jobs in the latest set of jobs '
4634 '(patchset #%d), doing nothing.' % patchset)
4635 return 0
Edward Lemur45768512020-03-02 19:03:14 +00004636 num_builders = len(jobs)
Quinten Yearsley983111f2019-09-26 17:18:48 +00004637 if num_builders > 10:
4638 confirm_or_exit('There are %d builders with failed builds.'
4639 % num_builders, action='continue')
4640 else:
qyearsley1fdfcb62016-10-24 13:22:03 -07004641 if options.verbose:
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07004642 print('git cl try with no bots now defaults to CQ dry run.')
4643 print('Scheduling CQ dry run on: %s' % cl.GetIssueURL())
4644 return cl.SetCQState(_CQState.DRY_RUN)
stip@chromium.org43064fd2013-12-18 20:07:44 +00004645
ilevy@chromium.org36e420b2013-08-06 23:21:12 +00004646 patchset = cl.GetMostRecentPatchset()
Edward Lemur2c210a42019-09-16 23:58:35 +00004647 try:
Quinten Yearsley777660f2020-03-04 23:37:06 +00004648 _trigger_tryjobs(cl, jobs, options, patchset)
Edward Lemur2c210a42019-09-16 23:58:35 +00004649 except BuildbucketResponseException as ex:
4650 print('ERROR: %s' % ex)
4651 return 1
4652 return 0
maruel@chromium.org15192402012-09-06 12:38:29 +00004653
4654
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004655@metrics.collector.collect_metrics('git cl try-results')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004656def CMDtry_results(parser, args):
Quinten Yearsleyd242ed72019-07-25 17:17:55 +00004657 """Prints info about results for tryjobs associated with the current CL."""
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004658 group = optparse.OptionGroup(parser, 'Tryjob results options')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004659 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004660 '-p', '--patchset', type=int, help='patchset number if not current.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004661 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004662 '--print-master', action='store_true', help='print master name as well.')
tandrii@chromium.org6cf98c82016-03-15 11:56:00 +00004663 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004664 '--color', action='store_true', default=setup_color.IS_TTY,
4665 help='force color output, useful when piping output.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004666 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004667 '--buildbucket-host', default='cr-buildbucket.appspot.com',
4668 help='Host of buildbucket. The default host is %default.')
qyearsley53f48a12016-09-01 10:45:13 -07004669 group.add_option(
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004670 '--json', help=('Path of JSON output file to write tryjob results to,'
Stefan Zager1306bd02017-06-22 19:26:46 -07004671 'or "-" for stdout.'))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004672 parser.add_option_group(group)
Edward Lemur52969c92020-02-06 18:15:28 +00004673 parser.add_option(
4674 '-i', '--issue', type=int,
4675 help='Operate on this issue instead of the current branch\'s implicit '
4676 'issue.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004677 options, args = parser.parse_args(args)
4678 if args:
4679 parser.error('Unrecognized args: %s' % ' '.join(args))
4680
Edward Lemur934836a2019-09-09 20:16:54 +00004681 cl = Changelist(issue=options.issue)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004682 if not cl.GetIssue():
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004683 parser.error('Need to upload first.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004684
tandrii221ab252016-10-06 08:12:04 -07004685 patchset = options.patchset
4686 if not patchset:
Gavin Make61ccc52020-11-13 00:12:57 +00004687 patchset = cl.GetMostRecentDryRunPatchset()
tandrii221ab252016-10-06 08:12:04 -07004688 if not patchset:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004689 parser.error('Code review host doesn\'t know about issue %s. '
tandrii221ab252016-10-06 08:12:04 -07004690 'No access to issue or wrong issue number?\n'
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004691 'Either upload first, or pass --patchset explicitly.' %
tandrii221ab252016-10-06 08:12:04 -07004692 cl.GetIssue())
4693
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004694 try:
Quinten Yearsley777660f2020-03-04 23:37:06 +00004695 jobs = _fetch_tryjobs(cl, options.buildbucket_host, patchset)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004696 except BuildbucketResponseException as ex:
vapiera7fbd5a2016-06-16 09:17:49 -07004697 print('Buildbucket error: %s' % ex)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004698 return 1
qyearsley53f48a12016-09-01 10:45:13 -07004699 if options.json:
Edward Lemurbaaf6be2019-10-09 18:00:44 +00004700 write_json(options.json, jobs)
qyearsley53f48a12016-09-01 10:45:13 -07004701 else:
Quinten Yearsley777660f2020-03-04 23:37:06 +00004702 _print_tryjobs(options, jobs)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004703 return 0
4704
4705
maruel@chromium.org0633fb42013-08-16 20:06:14 +00004706@subcommand.usage('[new upstream branch]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004707@metrics.collector.collect_metrics('git cl upstream')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004708def CMDupstream(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004709 """Prints or sets the name of the upstream branch, if any."""
dpranke@chromium.org97ae58e2011-03-18 00:29:20 +00004710 _, args = parser.parse_args(args)
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00004711 if len(args) > 1:
maruel@chromium.org27bb3872011-05-30 20:33:19 +00004712 parser.error('Unrecognized args: %s' % ' '.join(args))
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00004713
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004714 cl = Changelist()
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00004715 if args:
4716 # One arg means set upstream branch.
bauerb@chromium.orgc9cf90a2014-04-28 20:32:31 +00004717 branch = cl.GetBranch()
stip7a3dd352016-09-22 17:32:28 -07004718 RunGit(['branch', '--set-upstream-to', args[0], branch])
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00004719 cl = Changelist()
vapiera7fbd5a2016-06-16 09:17:49 -07004720 print('Upstream branch set to %s' % (cl.GetUpstreamBranch(),))
bauerb@chromium.orgc9cf90a2014-04-28 20:32:31 +00004721
4722 # Clear configured merge-base, if there is one.
4723 git_common.remove_merge_base(branch)
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00004724 else:
vapiera7fbd5a2016-06-16 09:17:49 -07004725 print(cl.GetUpstreamBranch())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004726 return 0
4727
4728
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004729@metrics.collector.collect_metrics('git cl web')
thestig@chromium.org00858c82013-12-02 23:08:03 +00004730def CMDweb(parser, args):
4731 """Opens the current CL in the web browser."""
4732 _, args = parser.parse_args(args)
4733 if args:
4734 parser.error('Unrecognized args: %s' % ' '.join(args))
4735
4736 issue_url = Changelist().GetIssueURL()
4737 if not issue_url:
vapiera7fbd5a2016-06-16 09:17:49 -07004738 print('ERROR No issue to open', file=sys.stderr)
thestig@chromium.org00858c82013-12-02 23:08:03 +00004739 return 1
4740
Sergiy Byelozyorov2b718322018-10-24 17:43:31 +00004741 # Redirect I/O before invoking browser to hide its output. For example, this
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004742 # allows us to hide the "Created new window in existing browser session."
4743 # message from Chrome. Based on https://stackoverflow.com/a/2323563.
Sergiy Byelozyorov2b718322018-10-24 17:43:31 +00004744 saved_stdout = os.dup(1)
Sergiy Belozorov06684032019-03-06 16:53:08 +00004745 saved_stderr = os.dup(2)
Sergiy Byelozyorov2b718322018-10-24 17:43:31 +00004746 os.close(1)
Sergiy Belozorov06684032019-03-06 16:53:08 +00004747 os.close(2)
Sergiy Byelozyorov2b718322018-10-24 17:43:31 +00004748 os.open(os.devnull, os.O_RDWR)
4749 try:
4750 webbrowser.open(issue_url)
4751 finally:
4752 os.dup2(saved_stdout, 1)
Sergiy Belozorov06684032019-03-06 16:53:08 +00004753 os.dup2(saved_stderr, 2)
thestig@chromium.org00858c82013-12-02 23:08:03 +00004754 return 0
4755
4756
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004757@metrics.collector.collect_metrics('git cl set-commit')
maruel@chromium.org27bb3872011-05-30 20:33:19 +00004758def CMDset_commit(parser, args):
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00004759 """Sets the commit bit to trigger the CQ."""
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00004760 parser.add_option('-d', '--dry-run', action='store_true',
4761 help='trigger in dry run mode')
4762 parser.add_option('-c', '--clear', action='store_true',
4763 help='stop CQ run, if any')
Edward Lemur52969c92020-02-06 18:15:28 +00004764 parser.add_option(
4765 '-i', '--issue', type=int,
4766 help='Operate on this issue instead of the current branch\'s implicit '
4767 'issue.')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004768 options, args = parser.parse_args(args)
maruel@chromium.org27bb3872011-05-30 20:33:19 +00004769 if args:
4770 parser.error('Unrecognized args: %s' % ' '.join(args))
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00004771 if options.dry_run and options.clear:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004772 parser.error('Only one of --dry-run and --clear are allowed.')
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00004773
Edward Lemur934836a2019-09-09 20:16:54 +00004774 cl = Changelist(issue=options.issue)
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00004775 if options.clear:
tandriid9e5ce52016-07-13 02:32:59 -07004776 state = _CQState.NONE
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00004777 elif options.dry_run:
4778 state = _CQState.DRY_RUN
4779 else:
4780 state = _CQState.COMMIT
4781 if not cl.GetIssue():
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004782 parser.error('Must upload the issue first.')
tandrii9de9ec62016-07-13 03:01:59 -07004783 cl.SetCQState(state)
maruel@chromium.org27bb3872011-05-30 20:33:19 +00004784 return 0
4785
4786
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004787@metrics.collector.collect_metrics('git cl set-close')
groby@chromium.org411034a2013-02-26 15:12:01 +00004788def CMDset_close(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004789 """Closes the issue."""
Edward Lemur52969c92020-02-06 18:15:28 +00004790 parser.add_option(
4791 '-i', '--issue', type=int,
4792 help='Operate on this issue instead of the current branch\'s implicit '
4793 'issue.')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004794 options, args = parser.parse_args(args)
groby@chromium.org411034a2013-02-26 15:12:01 +00004795 if args:
4796 parser.error('Unrecognized args: %s' % ' '.join(args))
Edward Lemur934836a2019-09-09 20:16:54 +00004797 cl = Changelist(issue=options.issue)
groby@chromium.org411034a2013-02-26 15:12:01 +00004798 # Ensure there actually is an issue to close.
Aaron Gable7139a4e2017-09-05 17:53:09 -07004799 if not cl.GetIssue():
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004800 DieWithError('ERROR: No issue to close.')
groby@chromium.org411034a2013-02-26 15:12:01 +00004801 cl.CloseIssue()
4802 return 0
4803
4804
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004805@metrics.collector.collect_metrics('git cl diff')
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00004806def CMDdiff(parser, args):
wychen@chromium.org37b2ec02015-04-03 00:49:15 +00004807 """Shows differences between local tree and last upload."""
thomasanderson074beb22016-08-29 14:03:20 -07004808 parser.add_option(
4809 '--stat',
4810 action='store_true',
4811 dest='stat',
4812 help='Generate a diffstat')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004813 options, args = parser.parse_args(args)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004814 if args:
4815 parser.error('Unrecognized args: %s' % ' '.join(args))
wychen@chromium.org46309bf2015-04-03 21:04:49 +00004816
Edward Lemur934836a2019-09-09 20:16:54 +00004817 cl = Changelist()
sbc@chromium.org78dc9842013-11-25 18:43:44 +00004818 issue = cl.GetIssue()
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00004819 branch = cl.GetBranch()
sbc@chromium.org78dc9842013-11-25 18:43:44 +00004820 if not issue:
4821 DieWithError('No issue found for current branch (%s)' % branch)
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00004822
Aaron Gablea718c3e2017-08-28 17:47:28 -07004823 base = cl._GitGetBranchConfigValue('last-upload-hash')
4824 if not base:
4825 base = cl._GitGetBranchConfigValue('gerritsquashhash')
4826 if not base:
4827 detail = cl._GetChangeDetail(['CURRENT_REVISION', 'CURRENT_COMMIT'])
4828 revision_info = detail['revisions'][detail['current_revision']]
4829 fetch_info = revision_info['fetch']['http']
4830 RunGit(['fetch', fetch_info['url'], fetch_info['ref']])
4831 base = 'FETCH_HEAD'
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00004832
Aaron Gablea718c3e2017-08-28 17:47:28 -07004833 cmd = ['git', 'diff']
4834 if options.stat:
4835 cmd.append('--stat')
4836 cmd.append(base)
4837 subprocess2.check_call(cmd)
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00004838
4839 return 0
4840
4841
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004842@metrics.collector.collect_metrics('git cl owners')
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004843def CMDowners(parser, args):
Dirk Prankebf980882017-09-02 15:08:00 -07004844 """Finds potential owners for reviewing."""
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004845 parser.add_option(
Sidney San Martín8e6f58c2018-06-08 01:02:56 +00004846 '--ignore-current',
4847 action='store_true',
4848 help='Ignore the CL\'s current reviewers and start from scratch.')
4849 parser.add_option(
Sylvain Defresneb1f865d2019-02-12 12:38:22 +00004850 '--ignore-self',
4851 action='store_true',
4852 help='Do not consider CL\'s author as an owners.')
4853 parser.add_option(
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004854 '--no-color',
4855 action='store_true',
4856 help='Use this option to disable color output')
Dirk Prankebf980882017-09-02 15:08:00 -07004857 parser.add_option(
4858 '--batch',
4859 action='store_true',
4860 help='Do not run interactively, just suggest some')
Yang Guo6e269a02019-06-26 11:17:02 +00004861 # TODO: Consider moving this to another command, since other
4862 # git-cl owners commands deal with owners for a given CL.
4863 parser.add_option(
4864 '--show-all',
4865 action='store_true',
4866 help='Show all owners for a particular file')
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004867 options, args = parser.parse_args(args)
4868
Edward Lemur934836a2019-09-09 20:16:54 +00004869 cl = Changelist()
Edward Lesmes50da7702020-03-30 19:23:43 +00004870 author = cl.GetAuthor()
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004871
Yang Guo6e269a02019-06-26 11:17:02 +00004872 if options.show_all:
Bruce Dawson97ed44a2020-05-06 17:04:03 +00004873 if len(args) == 0:
4874 print('No files specified for --show-all. Nothing to do.')
4875 return 0
Edward Lesmese1576912021-02-16 21:53:34 +00004876 owners_by_path = cl.owners_client.BatchListOwners(args)
Edward Lesmes0e4e5ae2021-01-08 18:28:46 +00004877 for path in args:
4878 print('Owners for %s:' % path)
4879 print('\n'.join(
4880 ' - %s' % owner
4881 for owner in owners_by_path.get(path, ['No owners found'])))
Yang Guo6e269a02019-06-26 11:17:02 +00004882 return 0
4883
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004884 if args:
4885 if len(args) > 1:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004886 parser.error('Unknown args.')
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004887 base_branch = args[0]
4888 else:
4889 # Default to diffing against the common ancestor of the upstream branch.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00004890 base_branch = cl.GetCommonAncestorWithUpstream()
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004891
Edward Lemur2c62b332020-03-12 22:12:33 +00004892 affected_files = cl.GetAffectedFiles(base_branch)
Dirk Prankebf980882017-09-02 15:08:00 -07004893
4894 if options.batch:
Edward Lesmese1576912021-02-16 21:53:34 +00004895 owners = cl.owners_client.SuggestOwners(affected_files, exclude=[author])
4896 print('\n'.join(owners))
Dirk Prankebf980882017-09-02 15:08:00 -07004897 return 0
4898
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004899 return owners_finder.OwnersFinder(
Dirk Prankebf980882017-09-02 15:08:00 -07004900 affected_files,
Edward Lemur707d70b2018-02-07 00:50:14 +01004901 author,
Sidney San Martín8e6f58c2018-06-08 01:02:56 +00004902 [] if options.ignore_current else cl.GetReviewers(),
Edward Lesmes5cd75472021-02-19 00:34:25 +00004903 cl.owners_client,
Jochen Eisingerd0573ec2017-04-13 10:55:06 +02004904 disable_color=options.no_color,
Sylvain Defresneb1f865d2019-02-12 12:38:22 +00004905 ignore_author=options.ignore_self).run()
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004906
4907
Aiden Bennerc08566e2018-10-03 17:52:42 +00004908def BuildGitDiffCmd(diff_type, upstream_commit, args, allow_prefix=False):
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00004909 """Generates a diff command."""
4910 # Generate diff for the current branch's changes.
Aiden Bennerc08566e2018-10-03 17:52:42 +00004911 diff_cmd = ['-c', 'core.quotePath=false', 'diff', '--no-ext-diff']
4912
Aiden Benner6c18a1a2018-11-23 20:18:23 +00004913 if allow_prefix:
4914 # explicitly setting --src-prefix and --dst-prefix is necessary in the
4915 # case that diff.noprefix is set in the user's git config.
4916 diff_cmd += ['--src-prefix=a/', '--dst-prefix=b/']
4917 else:
Aiden Bennerc08566e2018-10-03 17:52:42 +00004918 diff_cmd += ['--no-prefix']
4919
4920 diff_cmd += [diff_type, upstream_commit, '--']
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00004921
4922 if args:
4923 for arg in args:
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00004924 if os.path.isdir(arg) or os.path.isfile(arg):
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00004925 diff_cmd.append(arg)
4926 else:
4927 DieWithError('Argument "%s" is not a file or a directory' % arg)
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00004928
4929 return diff_cmd
4930
Andrii Shyshkalov18975322017-01-25 16:44:13 +01004931
Jamie Madill5e96ad12020-01-13 16:08:35 +00004932def _RunClangFormatDiff(opts, clang_diff_files, top_dir, upstream_commit):
4933 """Runs clang-format-diff and sets a return value if necessary."""
4934
4935 if not clang_diff_files:
4936 return 0
4937
4938 # Set to 2 to signal to CheckPatchFormatted() that this patch isn't
4939 # formatted. This is used to block during the presubmit.
4940 return_value = 0
4941
4942 # Locate the clang-format binary in the checkout
4943 try:
4944 clang_format_tool = clang_format.FindClangFormatToolInChromiumTree()
4945 except clang_format.NotFoundError as e:
4946 DieWithError(e)
4947
4948 if opts.full or settings.GetFormatFullByDefault():
4949 cmd = [clang_format_tool]
4950 if not opts.dry_run and not opts.diff:
4951 cmd.append('-i')
4952 if opts.dry_run:
4953 for diff_file in clang_diff_files:
4954 with open(diff_file, 'r') as myfile:
4955 code = myfile.read().replace('\r\n', '\n')
4956 stdout = RunCommand(cmd + [diff_file], cwd=top_dir)
4957 stdout = stdout.replace('\r\n', '\n')
4958 if opts.diff:
4959 sys.stdout.write(stdout)
4960 if code != stdout:
4961 return_value = 2
4962 else:
4963 stdout = RunCommand(cmd + clang_diff_files, cwd=top_dir)
4964 if opts.diff:
4965 sys.stdout.write(stdout)
4966 else:
Jamie Madill5e96ad12020-01-13 16:08:35 +00004967 try:
4968 script = clang_format.FindClangFormatScriptInChromiumTree(
4969 'clang-format-diff.py')
4970 except clang_format.NotFoundError as e:
4971 DieWithError(e)
4972
Edward Lesmes89624cd2020-04-06 17:51:56 +00004973 cmd = ['vpython', script, '-p0']
Jamie Madill5e96ad12020-01-13 16:08:35 +00004974 if not opts.dry_run and not opts.diff:
4975 cmd.append('-i')
4976
4977 diff_cmd = BuildGitDiffCmd('-U0', upstream_commit, clang_diff_files)
Edward Lemur1a83da12020-03-04 21:18:36 +00004978 diff_output = RunGit(diff_cmd).encode('utf-8')
Jamie Madill5e96ad12020-01-13 16:08:35 +00004979
Edward Lesmes89624cd2020-04-06 17:51:56 +00004980 env = os.environ.copy()
4981 env['PATH'] = (
4982 str(os.path.dirname(clang_format_tool)) + os.pathsep + env['PATH'])
4983 stdout = RunCommand(
4984 cmd, stdin=diff_output, cwd=top_dir, env=env,
Ilya Sherman7aed4bb2020-05-20 22:34:14 +00004985 shell=sys.platform.startswith('win32'))
Jamie Madill5e96ad12020-01-13 16:08:35 +00004986 if opts.diff:
4987 sys.stdout.write(stdout)
4988 if opts.dry_run and len(stdout) > 0:
4989 return_value = 2
4990
4991 return return_value
4992
4993
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00004994def MatchingFileType(file_name, extensions):
Quinten Yearsleyd242ed72019-07-25 17:17:55 +00004995 """Returns True if the file name ends with one of the given extensions."""
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00004996 return bool([ext for ext in extensions if file_name.lower().endswith(ext)])
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00004997
Andrii Shyshkalov18975322017-01-25 16:44:13 +01004998
enne@chromium.org555cfe42014-01-29 18:21:39 +00004999@subcommand.usage('[files or directories to diff]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005000@metrics.collector.collect_metrics('git cl format')
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005001def CMDformat(parser, args):
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00005002 """Runs auto-formatting tools (clang-format etc.) on the diff."""
Christopher Lamc5ba6922017-01-24 11:19:14 +11005003 CLANG_EXTS = ['.cc', '.cpp', '.h', '.m', '.mm', '.proto', '.java']
kylechar58edce22016-06-17 06:07:51 -07005004 GN_EXTS = ['.gn', '.gni', '.typemap']
enne@chromium.org3b7e15c2014-01-21 17:44:47 +00005005 parser.add_option('--full', action='store_true',
5006 help='Reformat the full content of all touched files')
5007 parser.add_option('--dry-run', action='store_true',
5008 help='Don\'t modify any file on disk.')
Aiden Benner99b0ccb2018-11-20 19:53:31 +00005009 parser.add_option(
Garrett Beatyed0cc5f2020-01-06 17:26:13 +00005010 '--no-clang-format',
5011 dest='clang_format',
5012 action='store_false',
5013 default=True,
5014 help='Disables formatting of various file types using clang-format.')
5015 parser.add_option(
Aiden Benner99b0ccb2018-11-20 19:53:31 +00005016 '--python',
5017 action='store_true',
5018 default=None,
5019 help='Enables python formatting on all python files.')
5020 parser.add_option(
5021 '--no-python',
5022 action='store_true',
Garrett Beaty91a6f332020-01-06 16:57:24 +00005023 default=False,
Aiden Benner99b0ccb2018-11-20 19:53:31 +00005024 help='Disables python formatting on all python files. '
Garrett Beaty91a6f332020-01-06 16:57:24 +00005025 'If neither --python or --no-python are set, python files that have a '
5026 '.style.yapf file in an ancestor directory will be formatted. '
5027 'It is an error to set both.')
Garrett Beatyed0cc5f2020-01-06 17:26:13 +00005028 parser.add_option(
5029 '--js',
5030 action='store_true',
5031 help='Format javascript code with clang-format. '
5032 'Has no effect if --no-clang-format is set.')
wittman@chromium.org04d5a222014-03-07 18:30:42 +00005033 parser.add_option('--diff', action='store_true',
5034 help='Print diff to stdout rather than modifying files.')
Ilya Shermane081cbe2017-08-15 17:51:04 -07005035 parser.add_option('--presubmit', action='store_true',
5036 help='Used when running the script from a presubmit.')
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005037 opts, args = parser.parse_args(args)
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005038
Garrett Beaty91a6f332020-01-06 16:57:24 +00005039 if opts.python is not None and opts.no_python:
5040 raise parser.error('Cannot set both --python and --no-python')
5041 if opts.no_python:
5042 opts.python = False
5043
Daniel Chengc55eecf2016-12-30 03:11:02 -08005044 # Normalize any remaining args against the current path, so paths relative to
5045 # the current directory are still resolved as expected.
5046 args = [os.path.join(os.getcwd(), arg) for arg in args]
5047
enne@chromium.orgff7a1fb2013-12-10 19:21:41 +00005048 # git diff generates paths against the root of the repository. Change
5049 # to that directory so clang-format can find files even within subdirs.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00005050 rel_base_path = settings.GetRelativeRoot()
enne@chromium.orgff7a1fb2013-12-10 19:21:41 +00005051 if rel_base_path:
5052 os.chdir(rel_base_path)
5053
digit@chromium.org29e47272013-05-17 17:01:46 +00005054 # Grab the merge-base commit, i.e. the upstream commit of the current
5055 # branch when it was created or the last time it was rebased. This is
5056 # to cover the case where the user may have called "git fetch origin",
5057 # moving the origin branch to a newer commit, but hasn't rebased yet.
5058 upstream_commit = None
5059 cl = Changelist()
5060 upstream_branch = cl.GetUpstreamBranch()
5061 if upstream_branch:
5062 upstream_commit = RunGit(['merge-base', 'HEAD', upstream_branch])
5063 upstream_commit = upstream_commit.strip()
5064
5065 if not upstream_commit:
5066 DieWithError('Could not find base commit for this branch. '
5067 'Are you in detached state?')
5068
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005069 changed_files_cmd = BuildGitDiffCmd('--name-only', upstream_commit, args)
5070 diff_output = RunGit(changed_files_cmd)
5071 diff_files = diff_output.splitlines()
jkarlin@chromium.orgad21b922016-01-28 17:48:42 +00005072 # Filter out files deleted by this CL
5073 diff_files = [x for x in diff_files if os.path.isfile(x)]
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005074
Andreas Haas417d89c2020-02-06 10:24:27 +00005075 if opts.js:
Deepanjan Roy605dd312018-07-02 17:48:54 +00005076 CLANG_EXTS.extend(['.js', '.ts'])
Christopher Lamc5ba6922017-01-24 11:19:14 +11005077
Garrett Beatyed0cc5f2020-01-06 17:26:13 +00005078 clang_diff_files = []
5079 if opts.clang_format:
5080 clang_diff_files = [
5081 x for x in diff_files if MatchingFileType(x, CLANG_EXTS)
5082 ]
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005083 python_diff_files = [x for x in diff_files if MatchingFileType(x, ['.py'])]
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00005084 gn_diff_files = [x for x in diff_files if MatchingFileType(x, GN_EXTS)]
digit@chromium.org29e47272013-05-17 17:01:46 +00005085
Edward Lesmes50da7702020-03-30 19:23:43 +00005086 top_dir = settings.GetRoot()
nick@chromium.org3ac1c4e2014-01-16 02:44:42 +00005087
Jamie Madill5e96ad12020-01-13 16:08:35 +00005088 return_value = _RunClangFormatDiff(opts, clang_diff_files, top_dir,
5089 upstream_commit)
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005090
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00005091 # Similar code to above, but using yapf on .py files rather than clang-format
5092 # on C/C++ files
Aiden Benner99b0ccb2018-11-20 19:53:31 +00005093 py_explicitly_disabled = opts.python is not None and not opts.python
5094 if python_diff_files and not py_explicitly_disabled:
Aiden Bennere47ac152018-11-20 16:44:03 +00005095 depot_tools_path = os.path.dirname(os.path.abspath(__file__))
5096 yapf_tool = os.path.join(depot_tools_path, 'yapf')
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00005097
Aiden Bennerc08566e2018-10-03 17:52:42 +00005098 # Used for caching.
5099 yapf_configs = {}
5100 for f in python_diff_files:
5101 # Find the yapf style config for the current file, defaults to depot
5102 # tools default.
Aiden Benner99b0ccb2018-11-20 19:53:31 +00005103 _FindYapfConfigFile(f, yapf_configs, top_dir)
5104
5105 # Turn on python formatting by default if a yapf config is specified.
5106 # This breaks in the case of this repo though since the specified
5107 # style file is also the global default.
5108 if opts.python is None:
5109 filtered_py_files = []
5110 for f in python_diff_files:
5111 if _FindYapfConfigFile(f, yapf_configs, top_dir) is not None:
5112 filtered_py_files.append(f)
5113 else:
5114 filtered_py_files = python_diff_files
5115
5116 # Note: yapf still seems to fix indentation of the entire file
5117 # even if line ranges are specified.
5118 # See https://github.com/google/yapf/issues/499
5119 if not opts.full and filtered_py_files:
5120 py_line_diffs = _ComputeDiffLineRanges(filtered_py_files, upstream_commit)
5121
Brian Sheedyb4307d52019-12-02 19:18:17 +00005122 yapfignore_patterns = _GetYapfIgnorePatterns(top_dir)
5123 filtered_py_files = _FilterYapfIgnoredFiles(filtered_py_files,
5124 yapfignore_patterns)
Brian Sheedy59b06a82019-10-14 17:03:29 +00005125
Aiden Benner99b0ccb2018-11-20 19:53:31 +00005126 for f in filtered_py_files:
Andrew Grievefa40bfa2020-01-07 02:32:57 +00005127 yapf_style = _FindYapfConfigFile(f, yapf_configs, top_dir)
5128 # Default to pep8 if not .style.yapf is found.
5129 if not yapf_style:
5130 yapf_style = 'pep8'
Aiden Bennerc08566e2018-10-03 17:52:42 +00005131
Peter Wend9399922020-06-17 17:33:49 +00005132 with open(f, 'r') as py_f:
5133 if 'python3' in py_f.readline():
5134 vpython_script = 'vpython3'
5135 else:
5136 vpython_script = 'vpython'
5137
5138 cmd = [vpython_script, yapf_tool, '--style', yapf_style, f]
Aiden Bennerc08566e2018-10-03 17:52:42 +00005139
5140 has_formattable_lines = False
5141 if not opts.full:
5142 # Only run yapf over changed line ranges.
5143 for diff_start, diff_len in py_line_diffs[f]:
5144 diff_end = diff_start + diff_len - 1
5145 # Yapf errors out if diff_end < diff_start but this
5146 # is a valid line range diff for a removal.
5147 if diff_end >= diff_start:
5148 has_formattable_lines = True
5149 cmd += ['-l', '{}-{}'.format(diff_start, diff_end)]
5150 # If all line diffs were removals we have nothing to format.
5151 if not has_formattable_lines:
5152 continue
5153
5154 if opts.diff or opts.dry_run:
5155 cmd += ['--diff']
5156 # Will return non-zero exit code if non-empty diff.
Edward Lesmesb7db1832020-06-22 20:22:27 +00005157 stdout = RunCommand(cmd,
5158 error_ok=True,
5159 cwd=top_dir,
5160 shell=sys.platform.startswith('win32'))
Aiden Bennerc08566e2018-10-03 17:52:42 +00005161 if opts.diff:
5162 sys.stdout.write(stdout)
5163 elif len(stdout) > 0:
5164 return_value = 2
5165 else:
5166 cmd += ['-i']
Edward Lesmesb7db1832020-06-22 20:22:27 +00005167 RunCommand(cmd, cwd=top_dir, shell=sys.platform.startswith('win32'))
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00005168
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00005169 # Format GN build files. Always run on full build files for canonical form.
5170 if gn_diff_files:
Andrii Shyshkalov18975322017-01-25 16:44:13 +01005171 cmd = ['gn', 'format']
brettw4b8ed592016-08-05 16:19:12 -07005172 if opts.dry_run or opts.diff:
5173 cmd.append('--dry-run')
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00005174 for gn_diff_file in gn_diff_files:
brettw4b8ed592016-08-05 16:19:12 -07005175 gn_ret = subprocess2.call(cmd + [gn_diff_file],
Ilya Sherman7aed4bb2020-05-20 22:34:14 +00005176 shell=sys.platform.startswith('win'),
brettw4b8ed592016-08-05 16:19:12 -07005177 cwd=top_dir)
5178 if opts.dry_run and gn_ret == 2:
5179 return_value = 2 # Not formatted.
5180 elif opts.diff and gn_ret == 2:
5181 # TODO this should compute and print the actual diff.
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005182 print('This change has GN build file diff for ' + gn_diff_file)
brettw4b8ed592016-08-05 16:19:12 -07005183 elif gn_ret != 0:
5184 # For non-dry run cases (and non-2 return values for dry-run), a
5185 # nonzero error code indicates a failure, probably because the file
5186 # doesn't parse.
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005187 DieWithError('gn format failed on ' + gn_diff_file +
5188 '\nTry running `gn format` on this file manually.')
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00005189
Ilya Shermane081cbe2017-08-15 17:51:04 -07005190 # Skip the metrics formatting from the global presubmit hook. These files have
5191 # a separate presubmit hook that issues an error if the files need formatting,
5192 # whereas the top-level presubmit script merely issues a warning. Formatting
5193 # these files is somewhat slow, so it's important not to duplicate the work.
5194 if not opts.presubmit:
Wenhan (Han) Zhang3bd3c992020-08-14 16:27:39 +00005195 for diff_xml in GetDiffXMLs(diff_files):
5196 xml_dir = GetMetricsDir(diff_xml)
5197 if not xml_dir:
5198 continue
5199
Ilya Shermane081cbe2017-08-15 17:51:04 -07005200 tool_dir = os.path.join(top_dir, xml_dir)
Ilya Sherman7aed4bb2020-05-20 22:34:14 +00005201 pretty_print_tool = os.path.join(tool_dir, 'pretty_print.py')
5202 cmd = ['vpython', pretty_print_tool, '--non-interactive']
Wenhan (Han) Zhang3bd3c992020-08-14 16:27:39 +00005203
5204 # If the XML file is histograms.xml or enums.xml, add the xml path to the
5205 # command as histograms/pretty_print.py now needs a relative path argument
5206 # after splitting the histograms into multiple directories.
5207 # For example, in tools/metrics/ukm, pretty-print could be run using:
5208 # $ python pretty_print.py
5209 # But in tools/metrics/histogrmas, pretty-print should be run with an
5210 # additional relative path argument, like:
5211 # $ python pretty_print.py histograms_xml/UMA/histograms.xml
5212 # $ python pretty_print.py enums.xml
5213
5214 # TODO (crbug/1116488): Remove this check after ensuring that the updated
5215 # version of histograms/pretty_print.py is released.
5216 filepath_required = os.path.exists(
5217 os.path.join(tool_dir, 'validate_prefix.py'))
5218
Weilun Shib92c4b72020-08-27 17:45:11 +00005219 if (diff_xml.endswith('histograms.xml') or diff_xml.endswith('enums.xml')
5220 or diff_xml.endswith('histogram_suffixes_list.xml')
5221 ) and filepath_required:
Wenhan (Han) Zhang3bd3c992020-08-14 16:27:39 +00005222 cmd.append(diff_xml)
5223
Ilya Shermane081cbe2017-08-15 17:51:04 -07005224 if opts.dry_run or opts.diff:
5225 cmd.append('--diff')
Wenhan (Han) Zhang3bd3c992020-08-14 16:27:39 +00005226
Ilya Sherman7aed4bb2020-05-20 22:34:14 +00005227 # TODO(isherman): Once this file runs only on Python 3.3+, drop the
5228 # `shell` param and instead replace `'vpython'` with
5229 # `shutil.which('frob')` above: https://stackoverflow.com/a/32799942
Wenhan (Han) Zhang3bd3c992020-08-14 16:27:39 +00005230 stdout = RunCommand(cmd,
5231 cwd=top_dir,
Ilya Sherman7aed4bb2020-05-20 22:34:14 +00005232 shell=sys.platform.startswith('win32'))
Ilya Shermane081cbe2017-08-15 17:51:04 -07005233 if opts.diff:
5234 sys.stdout.write(stdout)
5235 if opts.dry_run and stdout:
5236 return_value = 2 # Not formatted.
Alexei Svitkinef3cac412017-02-06 11:08:50 -05005237
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005238 return return_value
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005239
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005240
Wenhan (Han) Zhang3bd3c992020-08-14 16:27:39 +00005241def GetDiffXMLs(diff_files):
5242 return [
5243 os.path.normpath(x) for x in diff_files if MatchingFileType(x, ['.xml'])
5244 ]
5245
5246
5247def GetMetricsDir(diff_xml):
Steven Holte2e664bf2017-04-21 13:10:47 -07005248 metrics_xml_dirs = [
5249 os.path.join('tools', 'metrics', 'actions'),
5250 os.path.join('tools', 'metrics', 'histograms'),
5251 os.path.join('tools', 'metrics', 'rappor'),
Ilya Shermanb67e60c2020-05-20 22:27:03 +00005252 os.path.join('tools', 'metrics', 'structured'),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005253 os.path.join('tools', 'metrics', 'ukm'),
5254 ]
Steven Holte2e664bf2017-04-21 13:10:47 -07005255 for xml_dir in metrics_xml_dirs:
Wenhan (Han) Zhang3bd3c992020-08-14 16:27:39 +00005256 if diff_xml.startswith(xml_dir):
5257 return xml_dir
5258 return None
Steven Holte2e664bf2017-04-21 13:10:47 -07005259
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005260
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005261@subcommand.usage('<codereview url or issue id>')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005262@metrics.collector.collect_metrics('git cl checkout')
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005263def CMDcheckout(parser, args):
Edward Lemurf38bc172019-09-03 21:02:13 +00005264 """Checks out a branch associated with a given Gerrit issue."""
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005265 _, args = parser.parse_args(args)
5266
5267 if len(args) != 1:
5268 parser.print_help()
5269 return 1
5270
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00005271 issue_arg = ParseIssueNumberArgument(args[0])
tandrii@chromium.orgde6c9a12016-04-11 15:33:53 +00005272 if not issue_arg.valid:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00005273 parser.error('Invalid issue ID or URL.')
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02005274
tandrii@chromium.orgabd27e52016-04-11 15:43:32 +00005275 target_issue = str(issue_arg.issue)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005276
Edward Lemur52969c92020-02-06 18:15:28 +00005277 output = RunGit(['config', '--local', '--get-regexp',
Edward Lesmes50da7702020-03-30 19:23:43 +00005278 r'branch\..*\.' + ISSUE_CONFIG_KEY],
Edward Lemur52969c92020-02-06 18:15:28 +00005279 error_ok=True)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005280
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00005281 branches = []
Edward Lemur52969c92020-02-06 18:15:28 +00005282 for key, issue in [x.split() for x in output.splitlines()]:
5283 if issue == target_issue:
Edward Lesmes50da7702020-03-30 19:23:43 +00005284 branches.append(re.sub(r'branch\.(.*)\.' + ISSUE_CONFIG_KEY, r'\1', key))
Edward Lemur52969c92020-02-06 18:15:28 +00005285
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005286 if len(branches) == 0:
vapiera7fbd5a2016-06-16 09:17:49 -07005287 print('No branch found for issue %s.' % target_issue)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005288 return 1
5289 if len(branches) == 1:
5290 RunGit(['checkout', branches[0]])
5291 else:
vapiera7fbd5a2016-06-16 09:17:49 -07005292 print('Multiple branches match issue %s:' % target_issue)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005293 for i in range(len(branches)):
vapiera7fbd5a2016-06-16 09:17:49 -07005294 print('%d: %s' % (i, branches[i]))
Edward Lesmesae3586b2020-03-23 21:21:14 +00005295 which = gclient_utils.AskForData('Choose by index: ')
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005296 try:
5297 RunGit(['checkout', branches[int(which)]])
5298 except (IndexError, ValueError):
vapiera7fbd5a2016-06-16 09:17:49 -07005299 print('Invalid selection, not checking out any branch.')
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005300 return 1
5301
5302 return 0
5303
5304
maruel@chromium.org29404b52014-09-08 22:58:00 +00005305def CMDlol(parser, args):
5306 # This command is intentionally undocumented.
vapiera7fbd5a2016-06-16 09:17:49 -07005307 print(zlib.decompress(base64.b64decode(
thakis@chromium.org3421c992014-11-02 02:20:32 +00005308 'eNptkLEOwyAMRHe+wupCIqW57v0Vq84WqWtXyrcXnCBsmgMJ+/SSAxMZgRB6NzE'
5309 'E2ObgCKJooYdu4uAQVffUEoE1sRQLxAcqzd7uK2gmStrll1ucV3uZyaY5sXyDd9'
5310 'JAnN+lAXsOMJ90GANAi43mq5/VeeacylKVgi8o6F1SC63FxnagHfJUTfUYdCR/W'
Gavin Mak18f45d22020-12-04 21:45:10 +00005311 'Ofe+0dHL7PicpytKP750Fh1q2qnLVof4w8OZWNY')).decode('utf-8'))
maruel@chromium.org29404b52014-09-08 22:58:00 +00005312 return 0
5313
5314
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005315class OptionParser(optparse.OptionParser):
5316 """Creates the option parse and add --verbose support."""
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00005317
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005318 def __init__(self, *args, **kwargs):
maruel@chromium.org0633fb42013-08-16 20:06:14 +00005319 optparse.OptionParser.__init__(
5320 self, *args, prog='git cl', version=__version__, **kwargs)
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005321 self.add_option(
5322 '-v', '--verbose', action='count', default=0,
5323 help='Use 2 times for more debugging info')
5324
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005325 def parse_args(self, args=None, _values=None):
Andrii Shyshkalov46f20cd2018-10-30 06:42:54 +00005326 try:
5327 return self._parse_args(args)
5328 finally:
5329 # Regardless of success or failure of args parsing, we want to report
5330 # metrics, but only after logging has been initialized (if parsing
5331 # succeeded).
5332 global settings
5333 settings = Settings()
5334
5335 if not metrics.DISABLE_METRICS_COLLECTION:
5336 # GetViewVCUrl ultimately calls logging method.
5337 project_url = settings.GetViewVCUrl().strip('/+')
5338 if project_url in metrics_utils.KNOWN_PROJECT_URLS:
5339 metrics.collector.add('project_urls', [project_url])
5340
5341 def _parse_args(self, args=None):
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005342 # Create an optparse.Values object that will store only the actual passed
5343 # options, without the defaults.
5344 actual_options = optparse.Values()
5345 _, args = optparse.OptionParser.parse_args(self, args, actual_options)
5346 # Create an optparse.Values object with the default options.
5347 options = optparse.Values(self.get_default_values().__dict__)
5348 # Update it with the options passed by the user.
5349 options._update_careful(actual_options.__dict__)
5350 # Store the options passed by the user in an _actual_options attribute.
5351 # We store only the keys, and not the values, since the values can contain
5352 # arbitrary information, which might be PII.
Edward Lemur79d4f992019-11-11 23:49:02 +00005353 metrics.collector.add('arguments', list(actual_options.__dict__.keys()))
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005354
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005355 levels = [logging.WARNING, logging.INFO, logging.DEBUG]
Andrii Shyshkalov5b04a572017-01-23 17:44:41 +01005356 logging.basicConfig(
5357 level=levels[min(options.verbose, len(levels) - 1)],
5358 format='[%(levelname).1s%(asctime)s %(process)d %(thread)d '
5359 '%(filename)s] %(message)s')
Edward Lemur83bd7f42018-10-10 00:14:21 +00005360
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005361 return options, args
5362
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005363
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005364def main(argv):
maruel@chromium.org82798cb2012-02-23 18:16:12 +00005365 if sys.hexversion < 0x02060000:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005366 print('\nYour Python version %s is unsupported, please upgrade.\n' %
vapiera7fbd5a2016-06-16 09:17:49 -07005367 (sys.version.split(' ', 1)[0],), file=sys.stderr)
maruel@chromium.org82798cb2012-02-23 18:16:12 +00005368 return 2
maruel@chromium.org2e23ce32013-05-07 12:42:28 +00005369
maruel@chromium.org39c0b222013-08-17 16:57:01 +00005370 colorize_CMDstatus_doc()
maruel@chromium.org0633fb42013-08-16 20:06:14 +00005371 dispatcher = subcommand.CommandDispatcher(__name__)
5372 try:
5373 return dispatcher.execute(OptionParser(), argv)
Edward Lemur5b929a42019-10-21 17:57:39 +00005374 except auth.LoginRequiredError as e:
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +00005375 DieWithError(str(e))
Edward Lemur79d4f992019-11-11 23:49:02 +00005376 except urllib.error.HTTPError as e:
maruel@chromium.org0633fb42013-08-16 20:06:14 +00005377 if e.code != 500:
5378 raise
5379 DieWithError(
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005380 ('App Engine is misbehaving and returned HTTP %d, again. Keep faith '
Quinten Yearsleyc4202212019-07-22 23:34:40 +00005381 'and retry or visit go/isgaeup.\n%s') % (e.code, str(e)))
sbc@chromium.org013731e2015-02-26 18:28:43 +00005382 return 0
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005383
5384
5385if __name__ == '__main__':
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005386 # These affect sys.stdout, so do it outside of main() to simplify mocks in
5387 # the unit tests.
maruel@chromium.org6f09cd92011-04-01 16:38:12 +00005388 fix_encoding.fix_encoding()
iannucci@chromium.org596cd5c2016-04-04 21:34:39 +00005389 setup_color.init()
Edward Lemur6f812e12018-07-31 22:45:57 +00005390 with metrics.collector.print_notice_and_exit():
sbc@chromium.org013731e2015-02-26 18:28:43 +00005391 sys.exit(main(sys.argv[1:]))