blob: 3aa17a06bbdcac3f79c5ec74c80ebc16d9ab0815 [file] [log] [blame]
maruel@chromium.orgddd59412011-11-30 14:20:38 +00001#!/usr/bin/env python
maruel@chromium.orgeb5edbc2012-01-16 17:03:28 +00002# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
6"""Unit tests for git_cl.py."""
7
Andrii Shyshkalovcd6a9362016-12-07 12:04:12 +01008import contextlib
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01009import datetime
tandriide281ae2016-10-12 06:02:30 -070010import json
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +010011import logging
maruel@chromium.orgddd59412011-11-30 14:20:38 +000012import os
maruel@chromium.orga3353652011-11-30 14:26:57 +000013import StringIO
maruel@chromium.orgddd59412011-11-30 14:20:38 +000014import sys
Aaron Gable9a03ae02017-11-03 11:31:07 -070015import tempfile
maruel@chromium.orgddd59412011-11-30 14:20:38 +000016import unittest
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +000017import urlparse
maruel@chromium.orgddd59412011-11-30 14:20:38 +000018
19sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
20
21from testing_support.auto_stub import TestCase
22
Edward Lemur5ba1e9c2018-07-23 18:19:02 +000023import metrics
24# We have to disable monitoring before importing git_cl.
25metrics.DISABLE_METRICS_COLLECTION = True
26
Eric Boren2fb63102018-10-05 13:05:03 +000027import gerrit_util
maruel@chromium.orgddd59412011-11-30 14:20:38 +000028import git_cl
iannucci@chromium.org9e849272014-04-04 00:31:55 +000029import git_common
tandrii@chromium.org57d86542016-03-04 16:11:32 +000030import git_footers
maruel@chromium.orgddd59412011-11-30 14:20:38 +000031import subprocess2
maruel@chromium.orgddd59412011-11-30 14:20:38 +000032
tandrii5d48c322016-08-18 16:19:37 -070033def callError(code=1, cmd='', cwd='', stdout='', stderr=''):
34 return subprocess2.CalledProcessError(code, cmd, cwd, stdout, stderr)
35
36
37CERR1 = callError(1)
38
39
Aaron Gable9a03ae02017-11-03 11:31:07 -070040def MakeNamedTemporaryFileMock(expected_content):
41 class NamedTemporaryFileMock(object):
42 def __init__(self, *args, **kwargs):
43 self.name = '/tmp/named'
44 self.expected_content = expected_content
45
46 def __enter__(self):
47 return self
48
49 def __exit__(self, _type, _value, _tb):
50 pass
51
52 def write(self, content):
53 if self.expected_content:
54 assert content == self.expected_content
55
56 def close(self):
57 pass
58
59 return NamedTemporaryFileMock
60
61
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000062class ChangelistMock(object):
63 # A class variable so we can access it when we don't have access to the
64 # instance that's being set.
65 desc = ""
66 def __init__(self, **kwargs):
67 pass
68 def GetIssue(self):
69 return 1
Kenneth Russell61e2ed42017-02-15 11:47:13 -080070 def GetDescription(self, force=False):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000071 return ChangelistMock.desc
dsansomee2d6fd92016-09-08 00:10:47 -070072 def UpdateDescription(self, desc, force=False):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000073 ChangelistMock.desc = desc
74
tandrii5d48c322016-08-18 16:19:37 -070075
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000076class PresubmitMock(object):
77 def __init__(self, *args, **kwargs):
78 self.reviewers = []
Daniel Cheng7227d212017-11-17 08:12:37 -080079 self.more_cc = ['chromium-reviews+test-more-cc@chromium.org']
80
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000081 @staticmethod
82 def should_continue():
83 return True
84
85
skobes6468b902016-10-24 08:45:10 -070086class GitCheckoutMock(object):
87 def __init__(self, *args, **kwargs):
88 pass
89
90 @staticmethod
91 def reset():
92 GitCheckoutMock.conflict = False
93
94 def apply_patch(self, p):
95 if GitCheckoutMock.conflict:
96 raise Exception('failed')
97
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000098
99class WatchlistsMock(object):
100 def __init__(self, _):
101 pass
102 @staticmethod
103 def GetWatchersForPaths(_):
104 return ['joe@example.com']
105
106
ukai@chromium.org78c4b982012-02-14 02:20:26 +0000107class CodereviewSettingsFileMock(object):
108 def __init__(self):
109 pass
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800110 # pylint: disable=no-self-use
ukai@chromium.org78c4b982012-02-14 02:20:26 +0000111 def read(self):
112 return ("CODE_REVIEW_SERVER: gerrit.chromium.org\n" +
andybons@chromium.org11f46eb2016-02-02 19:26:51 +0000113 "GERRIT_HOST: True\n")
ukai@chromium.org78c4b982012-02-14 02:20:26 +0000114
115
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000116class AuthenticatorMock(object):
117 def __init__(self, *_args):
118 pass
119 def has_cached_credentials(self):
120 return True
tandrii221ab252016-10-06 08:12:04 -0700121 def authorize(self, http):
122 return http
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000123
124
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100125def CookiesAuthenticatorMockFactory(hosts_with_creds=None, same_auth=False):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000126 """Use to mock Gerrit/Git credentials from ~/.netrc or ~/.gitcookies.
127
128 Usage:
129 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100130 CookiesAuthenticatorMockFactory({'host': ('user', _, 'pass')})
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000131
132 OR
133 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100134 CookiesAuthenticatorMockFactory(
135 same_auth=('user', '', 'pass'))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000136 """
137 class CookiesAuthenticatorMock(git_cl.gerrit_util.CookiesAuthenticator):
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800138 def __init__(self): # pylint: disable=super-init-not-called
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000139 # Intentionally not calling super() because it reads actual cookie files.
140 pass
141 @classmethod
142 def get_gitcookies_path(cls):
143 return '~/.gitcookies'
144 @classmethod
145 def get_netrc_path(cls):
146 return '~/.netrc'
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100147 def _get_auth_for_host(self, host):
148 if same_auth:
149 return same_auth
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000150 return (hosts_with_creds or {}).get(host)
151 return CookiesAuthenticatorMock
152
Aaron Gable9a03ae02017-11-03 11:31:07 -0700153
kmarshall9249e012016-08-23 12:02:16 -0700154class MockChangelistWithBranchAndIssue():
155 def __init__(self, branch, issue):
156 self.branch = branch
157 self.issue = issue
158 def GetBranch(self):
159 return self.branch
160 def GetIssue(self):
161 return self.issue
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000162
tandriic2405f52016-10-10 08:13:15 -0700163
164class SystemExitMock(Exception):
165 pass
166
167
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000168class TestGitClBasic(unittest.TestCase):
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100169 def test_get_description(self):
Andrii Shyshkalovf5569d22018-10-15 03:35:23 +0000170 cl = git_cl.Changelist(issue=1, codereview='gerrit',
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100171 codereview_host='host')
172 cl.description = 'x'
173 cl.has_description = True
Kenneth Russell61e2ed42017-02-15 11:47:13 -0800174 cl._codereview_impl.FetchDescription = lambda *a, **kw: 'y'
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100175 self.assertEquals(cl.GetDescription(), 'x')
176 self.assertEquals(cl.GetDescription(force=True), 'y')
177 self.assertEquals(cl.GetDescription(), 'y')
178
Robert Iannucci09f1f3d2017-03-28 16:54:32 -0700179 def test_description_footers(self):
180 cl = git_cl.Changelist(issue=1, codereview='gerrit',
181 codereview_host='host')
182 cl.description = '\n'.join([
183 'This is some message',
184 '',
185 'It has some lines',
186 'and, also',
187 '',
188 'Some: Really',
189 'Awesome: Footers',
190 ])
191 cl.has_description = True
192 cl._codereview_impl.UpdateDescriptionRemote = lambda *a, **kw: 'y'
193 msg, footers = cl.GetDescriptionFooters()
194 self.assertEquals(
195 msg, ['This is some message', '', 'It has some lines', 'and, also'])
196 self.assertEquals(footers, [('Some', 'Really'), ('Awesome', 'Footers')])
197
198 msg.append('wut')
199 footers.append(('gnarly-dude', 'beans'))
200 cl.UpdateDescriptionFooters(msg, footers)
201 self.assertEquals(cl.GetDescription().splitlines(), [
202 'This is some message',
203 '',
204 'It has some lines',
205 'and, also',
206 'wut'
207 '',
208 'Some: Really',
209 'Awesome: Footers',
210 'Gnarly-Dude: beans',
211 ])
212
tandriif9aefb72016-07-01 09:06:51 -0700213 def test_get_bug_line_values(self):
214 f = lambda p, bugs: list(git_cl._get_bug_line_values(p, bugs))
215 self.assertEqual(f('', ''), [])
216 self.assertEqual(f('', '123,v8:456'), ['123', 'v8:456'])
217 self.assertEqual(f('v8', '456'), ['v8:456'])
218 self.assertEqual(f('v8', 'chromium:123,456'), ['v8:456', 'chromium:123'])
219 # Not nice, but not worth carying.
220 self.assertEqual(f('v8', 'chromium:123,456,v8:123'),
221 ['v8:456', 'chromium:123', 'v8:123'])
222
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100223 def _test_git_number(self, parent_msg, dest_ref, child_msg,
224 parent_hash='parenthash'):
225 desc = git_cl.ChangeDescription(child_msg)
226 desc.update_with_git_number_footers(parent_hash, parent_msg, dest_ref)
227 return desc.description
228
229 def assertEqualByLine(self, actual, expected):
230 self.assertEqual(actual.splitlines(), expected.splitlines())
231
232 def test_git_number_bad_parent(self):
233 with self.assertRaises(ValueError):
234 self._test_git_number('Parent', 'refs/heads/master', 'Child')
235
236 def test_git_number_bad_parent_footer(self):
237 with self.assertRaises(AssertionError):
238 self._test_git_number(
239 'Parent\n'
240 '\n'
241 'Cr-Commit-Position: wrong',
242 'refs/heads/master', 'Child')
243
244 def test_git_number_bad_lineage_ignored(self):
245 actual = self._test_git_number(
246 'Parent\n'
247 '\n'
248 'Cr-Commit-Position: refs/heads/master@{#1}\n'
249 'Cr-Branched-From: mustBeReal40CharHash-branch@{#pos}',
250 'refs/heads/master', 'Child')
251 self.assertEqualByLine(
252 actual,
253 'Child\n'
254 '\n'
255 'Cr-Commit-Position: refs/heads/master@{#2}\n'
256 'Cr-Branched-From: mustBeReal40CharHash-branch@{#pos}')
257
258 def test_git_number_same_branch(self):
259 actual = self._test_git_number(
260 'Parent\n'
261 '\n'
262 'Cr-Commit-Position: refs/heads/master@{#12}',
263 dest_ref='refs/heads/master',
264 child_msg='Child')
265 self.assertEqualByLine(
266 actual,
267 'Child\n'
268 '\n'
269 'Cr-Commit-Position: refs/heads/master@{#13}')
270
Andrii Shyshkalovde37c012017-07-06 21:06:50 +0200271 def test_git_number_same_branch_mixed_footers(self):
272 actual = self._test_git_number(
273 'Parent\n'
274 '\n'
275 'Cr-Commit-Position: refs/heads/master@{#12}',
276 dest_ref='refs/heads/master',
277 child_msg='Child\n'
278 '\n'
279 'Broken-by: design\n'
280 'BUG=123')
281 self.assertEqualByLine(
282 actual,
283 'Child\n'
284 '\n'
285 'Broken-by: design\n'
286 'BUG=123\n'
287 'Cr-Commit-Position: refs/heads/master@{#13}')
288
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100289 def test_git_number_same_branch_with_originals(self):
290 actual = self._test_git_number(
291 'Parent\n'
292 '\n'
293 'Cr-Commit-Position: refs/heads/master@{#12}',
294 dest_ref='refs/heads/master',
295 child_msg='Child\n'
296 '\n'
297 'Some users are smart and insert their own footers\n'
298 '\n'
299 'Cr-Whatever: value\n'
300 'Cr-Commit-Position: refs/copy/paste@{#22}')
301 self.assertEqualByLine(
302 actual,
303 'Child\n'
304 '\n'
305 'Some users are smart and insert their own footers\n'
306 '\n'
307 'Cr-Original-Whatever: value\n'
308 'Cr-Original-Commit-Position: refs/copy/paste@{#22}\n'
309 'Cr-Commit-Position: refs/heads/master@{#13}')
310
311 def test_git_number_new_branch(self):
312 actual = self._test_git_number(
313 'Parent\n'
314 '\n'
315 'Cr-Commit-Position: refs/heads/master@{#12}',
316 dest_ref='refs/heads/branch',
317 child_msg='Child')
318 self.assertEqualByLine(
319 actual,
320 'Child\n'
321 '\n'
322 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
323 'Cr-Branched-From: parenthash-refs/heads/master@{#12}')
324
325 def test_git_number_lineage(self):
326 actual = self._test_git_number(
327 'Parent\n'
328 '\n'
329 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
330 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
331 dest_ref='refs/heads/branch',
332 child_msg='Child')
333 self.assertEqualByLine(
334 actual,
335 'Child\n'
336 '\n'
337 'Cr-Commit-Position: refs/heads/branch@{#2}\n'
338 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
339
340 def test_git_number_moooooooore_lineage(self):
341 actual = self._test_git_number(
342 'Parent\n'
343 '\n'
344 'Cr-Commit-Position: refs/heads/branch@{#5}\n'
345 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
346 dest_ref='refs/heads/mooore',
347 child_msg='Child')
348 self.assertEqualByLine(
349 actual,
350 'Child\n'
351 '\n'
352 'Cr-Commit-Position: refs/heads/mooore@{#1}\n'
353 'Cr-Branched-From: parenthash-refs/heads/branch@{#5}\n'
354 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
355
Andrii Shyshkalovb5effa12016-12-14 19:35:12 +0100356 def test_git_number_ever_moooooooore_lineage(self):
Robert Iannucci456b0d62018-03-13 19:15:50 -0700357 self.maxDiff = 10000 # pylint: disable=attribute-defined-outside-init
Andrii Shyshkalovb5effa12016-12-14 19:35:12 +0100358 actual = self._test_git_number(
359 'CQ commit on fresh new branch + numbering.\n'
360 '\n'
361 'NOTRY=True\n'
362 'NOPRESUBMIT=True\n'
363 'BUG=\n'
364 '\n'
365 'Review-Url: https://codereview.chromium.org/2577703003\n'
366 'Cr-Commit-Position: refs/heads/gnumb-test/br@{#1}\n'
367 'Cr-Branched-From: 0749ff9edc-refs/heads/gnumb-test/cq@{#4}\n'
368 'Cr-Branched-From: 5c49df2da6-refs/heads/master@{#41618}',
369 dest_ref='refs/heads/gnumb-test/cl',
370 child_msg='git cl on fresh new branch + numbering.\n'
371 '\n'
372 'Review-Url: https://codereview.chromium.org/2575043003 .\n')
373 self.assertEqualByLine(
374 actual,
375 'git cl on fresh new branch + numbering.\n'
376 '\n'
377 'Review-Url: https://codereview.chromium.org/2575043003 .\n'
378 'Cr-Commit-Position: refs/heads/gnumb-test/cl@{#1}\n'
379 'Cr-Branched-From: parenthash-refs/heads/gnumb-test/br@{#1}\n'
380 'Cr-Branched-From: 0749ff9edc-refs/heads/gnumb-test/cq@{#4}\n'
381 'Cr-Branched-From: 5c49df2da6-refs/heads/master@{#41618}')
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100382
383 def test_git_number_cherry_pick(self):
384 actual = self._test_git_number(
385 'Parent\n'
386 '\n'
387 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
388 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
389 dest_ref='refs/heads/branch',
390 child_msg='Child, which is cherry-pick from master\n'
391 '\n'
392 'Cr-Commit-Position: refs/heads/master@{#100}\n'
393 '(cherry picked from commit deadbeef12345678deadbeef12345678deadbeef)')
394 self.assertEqualByLine(
395 actual,
396 'Child, which is cherry-pick from master\n'
397 '\n'
398 '(cherry picked from commit deadbeef12345678deadbeef12345678deadbeef)\n'
399 '\n'
400 'Cr-Original-Commit-Position: refs/heads/master@{#100}\n'
401 'Cr-Commit-Position: refs/heads/branch@{#2}\n'
402 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
403
Andrii Shyshkalovd4c86732018-09-25 04:29:31 +0000404 def test_gerrit_mirror_hack(self):
405 cr = 'chromium-review.googlesource.com'
406 url0 = 'https://%s/a/changes/x?a=b' % cr
407 origMirrors = git_cl.gerrit_util._GERRIT_MIRROR_PREFIXES
408 try:
409 git_cl.gerrit_util._GERRIT_MIRROR_PREFIXES = ['us1', 'us2']
410 url1 = git_cl.gerrit_util._UseGerritMirror(url0, cr)
411 url2 = git_cl.gerrit_util._UseGerritMirror(url1, cr)
412 url3 = git_cl.gerrit_util._UseGerritMirror(url2, cr)
413
414 self.assertNotEqual(url1, url2)
415 self.assertEqual(sorted((url1, url2)), [
416 'https://us1-mirror-chromium-review.googlesource.com/a/changes/x?a=b',
417 'https://us2-mirror-chromium-review.googlesource.com/a/changes/x?a=b'])
418 self.assertEqual(url1, url3)
419 finally:
420 git_cl.gerrit_util._GERRIT_MIRROR_PREFIXES = origMirrors
421
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000422 def test_valid_accounts(self):
423 mock_per_account = {
424 'u1': None, # 404, doesn't exist.
425 'u2': {
426 '_account_id': 123124,
427 'avatars': [],
428 'email': 'u2@example.com',
429 'name': 'User Number 2',
430 'status': 'OOO',
431 },
432 'u3': git_cl.gerrit_util.GerritError(500, 'retries didn\'t help :('),
433 }
434 def GetAccountDetailsMock(_, account):
435 # Poor-man's mock library's side_effect.
436 v = mock_per_account.pop(account)
437 if isinstance(v, Exception):
438 raise v
439 return v
440
441 original = git_cl.gerrit_util.GetAccountDetails
442 try:
443 git_cl.gerrit_util.GetAccountDetails = GetAccountDetailsMock
444 actual = git_cl.gerrit_util.ValidAccounts(
445 'host', ['u1', 'u2', 'u3'], max_threads=1)
446 finally:
447 git_cl.gerrit_util.GetAccountDetails = original
448 self.assertEqual(actual, {
449 'u2': {
450 '_account_id': 123124,
451 'avatars': [],
452 'email': 'u2@example.com',
453 'name': 'User Number 2',
454 'status': 'OOO',
455 },
456 })
457
458
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000459
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200460class TestParseIssueURL(unittest.TestCase):
461 def _validate(self, parsed, issue=None, patchset=None, hostname=None,
462 codereview=None, fail=False):
463 self.assertIsNotNone(parsed)
464 if fail:
465 self.assertFalse(parsed.valid)
466 return
467 self.assertTrue(parsed.valid)
468 self.assertEqual(parsed.issue, issue)
469 self.assertEqual(parsed.patchset, patchset)
470 self.assertEqual(parsed.hostname, hostname)
471 self.assertEqual(parsed.codereview, codereview)
472
473 def _run_and_validate(self, func, url, *args, **kwargs):
474 result = func(urlparse.urlparse(url))
475 if kwargs.pop('fail', False):
476 self.assertIsNone(result)
477 return None
478 self._validate(result, *args, fail=False, **kwargs)
479
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200480 def test_gerrit(self):
481 def test(url, issue=None, patchset=None, hostname=None, fail=None):
482 self._test_ParseIssueUrl(
483 git_cl._GerritChangelistImpl.ParseIssueURL,
484 url, issue, patchset, hostname, fail)
485 def test(url, *args, **kwargs):
486 self._run_and_validate(git_cl._GerritChangelistImpl.ParseIssueURL, url,
487 *args, codereview='gerrit', **kwargs)
488
489 test('http://chrome-review.source.com/c/123',
490 123, None, 'chrome-review.source.com')
491 test('https://chrome-review.source.com/c/123/',
492 123, None, 'chrome-review.source.com')
493 test('https://chrome-review.source.com/c/123/4',
494 123, 4, 'chrome-review.source.com')
495 test('https://chrome-review.source.com/#/c/123/4',
496 123, 4, 'chrome-review.source.com')
497 test('https://chrome-review.source.com/c/123/4',
498 123, 4, 'chrome-review.source.com')
499 test('https://chrome-review.source.com/123',
500 123, None, 'chrome-review.source.com')
501 test('https://chrome-review.source.com/123/4',
502 123, 4, 'chrome-review.source.com')
503
504 test('https://chrome-review.source.com/c/123/1/whatisthis', fail=True)
505 test('https://chrome-review.source.com/c/abc/', fail=True)
506 test('ssh://chrome-review.source.com/c/123/1/', fail=True)
507
508 def test_ParseIssueNumberArgument(self):
509 def test(arg, *args, **kwargs):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +0200510 codereview_hint = kwargs.pop('hint', None)
511 self._validate(git_cl.ParseIssueNumberArgument(arg, codereview_hint),
512 *args, **kwargs)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200513
514 test('123', 123)
515 test('', fail=True)
516 test('abc', fail=True)
517 test('123/1', fail=True)
518 test('123a', fail=True)
519 test('ssh://chrome-review.source.com/#/c/123/4/', fail=True)
Andrii Shyshkalovf5569d22018-10-15 03:35:23 +0000520
521 # Looks like Rietveld and Gerrit, but we should select Gerrit now
522 # w/ or w/o hint.
Andrii Shyshkalovc9712392017-04-11 13:35:21 +0200523 test('https://codereview.source.com/123',
524 123, None, 'codereview.source.com', 'gerrit',
525 hint='gerrit')
Andrii Shyshkalovf5569d22018-10-15 03:35:23 +0000526 test('https://codereview.source.com/123',
527 123, None, 'codereview.source.com', 'gerrit')
528
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200529 # Gerrrit.
530 test('https://chrome-review.source.com/c/123/4',
531 123, 4, 'chrome-review.source.com', 'gerrit')
532 test('https://chrome-review.source.com/bad/123/4', fail=True)
533
534
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100535class GitCookiesCheckerTest(TestCase):
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100536 def setUp(self):
537 super(GitCookiesCheckerTest, self).setUp()
538 self.c = git_cl._GitCookiesChecker()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100539 self.c._all_hosts = []
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100540
541 def mock_hosts_creds(self, subhost_identity_pairs):
542 def ensure_googlesource(h):
543 if not h.endswith(self.c._GOOGLESOURCE):
544 assert not h.endswith('.')
545 return h + '.' + self.c._GOOGLESOURCE
546 return h
547 self.c._all_hosts = [(ensure_googlesource(h), i, '.gitcookies')
548 for h, i in subhost_identity_pairs]
549
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200550 def test_identity_parsing(self):
551 self.assertEqual(self.c._parse_identity('ldap.google.com'),
552 ('ldap', 'google.com'))
553 self.assertEqual(self.c._parse_identity('git-ldap.example.com'),
554 ('ldap', 'example.com'))
555 # Specical case because we know there are no subdomains in chromium.org.
556 self.assertEqual(self.c._parse_identity('git-note.period.chromium.org'),
557 ('note.period', 'chromium.org'))
Lei Zhangd3f769a2017-12-15 15:16:14 -0800558 # Pathological: ".period." can be either username OR domain, more likely
559 # domain.
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200560 self.assertEqual(self.c._parse_identity('git-note.period.example.com'),
561 ('note', 'period.example.com'))
562
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100563 def test_analysis_nothing(self):
564 self.c._all_hosts = []
565 self.assertFalse(self.c.has_generic_host())
566 self.assertEqual(set(), self.c.get_conflicting_hosts())
567 self.assertEqual(set(), self.c.get_duplicated_hosts())
568 self.assertEqual(set(), self.c.get_partially_configured_hosts())
569 self.assertEqual(set(), self.c.get_hosts_with_wrong_identities())
570
571 def test_analysis(self):
572 self.mock_hosts_creds([
573 ('.googlesource.com', 'git-example.chromium.org'),
574
575 ('chromium', 'git-example.google.com'),
576 ('chromium-review', 'git-example.google.com'),
577 ('chrome-internal', 'git-example.chromium.org'),
578 ('chrome-internal-review', 'git-example.chromium.org'),
579 ('conflict', 'git-example.google.com'),
580 ('conflict-review', 'git-example.chromium.org'),
581 ('dup', 'git-example.google.com'),
582 ('dup', 'git-example.google.com'),
583 ('dup-review', 'git-example.google.com'),
584 ('partial', 'git-example.google.com'),
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200585 ('gpartial-review', 'git-example.google.com'),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100586 ])
587 self.assertTrue(self.c.has_generic_host())
588 self.assertEqual(set(['conflict.googlesource.com']),
589 self.c.get_conflicting_hosts())
590 self.assertEqual(set(['dup.googlesource.com']),
591 self.c.get_duplicated_hosts())
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200592 self.assertEqual(set(['partial.googlesource.com',
593 'gpartial-review.googlesource.com']),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100594 self.c.get_partially_configured_hosts())
595 self.assertEqual(set(['chromium.googlesource.com',
596 'chrome-internal.googlesource.com']),
597 self.c.get_hosts_with_wrong_identities())
598
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100599 def test_report_no_problems(self):
600 self.test_analysis_nothing()
601 self.mock(sys, 'stdout', StringIO.StringIO())
602 self.assertFalse(self.c.find_and_report_problems())
603 self.assertEqual(sys.stdout.getvalue(), '')
604
605 def test_report(self):
606 self.test_analysis()
607 self.mock(sys, 'stdout', StringIO.StringIO())
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200608 self.mock(git_cl.gerrit_util.CookiesAuthenticator, 'get_gitcookies_path',
609 classmethod(lambda _: '~/.gitcookies'))
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100610 self.assertTrue(self.c.find_and_report_problems())
611 with open(os.path.join(os.path.dirname(__file__),
612 'git_cl_creds_check_report.txt')) as f:
613 expected = f.read()
614 def by_line(text):
615 return [l.rstrip() for l in text.rstrip().splitlines()]
Robert Iannucci456b0d62018-03-13 19:15:50 -0700616 self.maxDiff = 10000 # pylint: disable=attribute-defined-outside-init
Andrii Shyshkalov4812e612017-03-27 17:22:57 +0200617 self.assertEqual(by_line(sys.stdout.getvalue().strip()), by_line(expected))
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100618
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -0800619
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000620class TestGitCl(TestCase):
621 def setUp(self):
622 super(TestGitCl, self).setUp()
623 self.calls = []
tandrii9d206752016-06-20 11:32:47 -0700624 self._calls_done = []
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000625 self.mock(git_cl, 'time_time',
626 lambda: self._mocked_call('time.time'))
627 self.mock(git_cl.metrics.collector, 'add_repeated',
628 lambda *a: self._mocked_call('add_repeated', *a))
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000629 self.mock(subprocess2, 'call', self._mocked_call)
630 self.mock(subprocess2, 'check_call', self._mocked_call)
631 self.mock(subprocess2, 'check_output', self._mocked_call)
tandrii5d48c322016-08-18 16:19:37 -0700632 self.mock(subprocess2, 'communicate',
633 lambda *a, **kw: ([self._mocked_call(*a, **kw), ''], 0))
tandrii@chromium.orga342c922016-03-16 07:08:25 +0000634 self.mock(git_cl.gclient_utils, 'CheckCallAndFilter', self._mocked_call)
sbc@chromium.org71437c02015-04-09 19:29:40 +0000635 self.mock(git_common, 'is_dirty_git_tree', lambda x: False)
iannucci@chromium.org9e849272014-04-04 00:31:55 +0000636 self.mock(git_common, 'get_or_create_merge_base',
637 lambda *a: (
638 self._mocked_call(['get_or_create_merge_base']+list(a))))
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +0000639 self.mock(git_cl, 'BranchExists', lambda _: True)
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000640 self.mock(git_cl, 'FindCodereviewSettingsFile', lambda: '')
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000641 self.mock(git_cl, 'SaveDescriptionBackup', lambda _:
642 self._mocked_call('SaveDescriptionBackup'))
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100643 self.mock(git_cl, 'ask_for_data', lambda *a, **k: self._mocked_call(
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000644 *(['ask_for_data'] + list(a)), **k))
phajdan.jre328cf92016-08-22 04:12:17 -0700645 self.mock(git_cl, 'write_json', lambda path, contents:
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000646 self._mocked_call('write_json', path, contents))
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000647 self.mock(git_cl.presubmit_support, 'DoPresubmitChecks', PresubmitMock)
skobes6468b902016-10-24 08:45:10 -0700648 self.mock(git_cl.checkout, 'GitCheckout', GitCheckoutMock)
649 GitCheckoutMock.reset()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000650 self.mock(git_cl.watchlists, 'Watchlists', WatchlistsMock)
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000651 self.mock(git_cl.auth, 'get_authenticator_for_host', AuthenticatorMock)
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +0100652 self.mock(git_cl.gerrit_util, 'GetChangeDetail',
653 lambda *args, **kwargs: self._mocked_call(
654 'GetChangeDetail', *args, **kwargs))
Aaron Gable0ffdf2d2017-06-05 13:01:17 -0700655 self.mock(git_cl.gerrit_util, 'GetChangeComments',
656 lambda *args, **kwargs: self._mocked_call(
657 'GetChangeComments', *args, **kwargs))
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +0100658 self.mock(git_cl.gerrit_util, 'AddReviewers',
Aaron Gable6dadfbf2017-05-09 14:27:58 -0700659 lambda h, i, reviewers, ccs, notify: self._mocked_call(
660 'AddReviewers', h, i, reviewers, ccs, notify))
Aaron Gablefd238082017-06-07 13:42:34 -0700661 self.mock(git_cl.gerrit_util, 'SetReview',
Aaron Gablefc62f762017-07-17 11:12:07 -0700662 lambda h, i, msg=None, labels=None, notify=None:
663 self._mocked_call('SetReview', h, i, msg, labels, notify))
Andrii Shyshkalov733d4ec2018-04-19 11:48:58 -0700664 self.mock(git_cl.gerrit_util.LuciContextAuthenticator, 'is_luci',
665 staticmethod(lambda: False))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000666 self.mock(git_cl.gerrit_util.GceAuthenticator, 'is_gce',
667 classmethod(lambda _: False))
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000668 self.mock(git_cl.gerrit_util, 'ValidAccounts',
669 lambda host, accounts:
670 self._mocked_call('ValidAccounts', host, accounts))
tandriic2405f52016-10-10 08:13:15 -0700671 self.mock(git_cl, 'DieWithError',
Christopher Lamf732cd52017-01-24 12:40:11 +1100672 lambda msg, change=None: self._mocked_call(['DieWithError', msg]))
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000673 # It's important to reset settings to not have inter-tests interference.
674 git_cl.settings = None
675
676 def tearDown(self):
wychen@chromium.org445c8962015-04-28 23:30:05 +0000677 try:
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100678 self.assertEquals([], self.calls)
679 except AssertionError:
wychen@chromium.org445c8962015-04-28 23:30:05 +0000680 if not self.has_failed():
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100681 raise
682 # Sadly, has_failed() returns True if this OR any other tests before this
683 # one have failed.
Andrii Shyshkalove05d4882017-04-12 14:34:49 +0200684 git_cl.logging.error(
685 '!!!!!! IF YOU SEE THIS, READ BELOW, IT WILL SAVE YOUR TIME !!!!!\n'
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100686 'There are un-consumed self.calls after this test has finished.\n'
687 'If you don\'t know which test this is, run:\n'
Aaron Gable3a16ed12017-03-23 10:51:55 -0700688 ' tests/git_cl_tests.py -v\n'
Andrii Shyshkalove05d4882017-04-12 14:34:49 +0200689 'If you are already running only this test, then **first** fix the '
690 'problem whose exception is emitted below by unittest runner.\n'
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100691 'Else, to be sure what\'s going on, run this test **alone** with \n'
Aaron Gable3a16ed12017-03-23 10:51:55 -0700692 ' tests/git_cl_tests.py TestGitCl.<name>\n'
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100693 'and follow instructions above.\n' +
694 '=' * 80)
wychen@chromium.org445c8962015-04-28 23:30:05 +0000695 finally:
696 super(TestGitCl, self).tearDown()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000697
iannucci@chromium.org9e849272014-04-04 00:31:55 +0000698 def _mocked_call(self, *args, **_kwargs):
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000699 self.assertTrue(
700 self.calls,
tandrii9d206752016-06-20 11:32:47 -0700701 '@%d Expected: <Missing> Actual: %r' % (len(self._calls_done), args))
wychen@chromium.orga872e752015-04-28 23:42:18 +0000702 top = self.calls.pop(0)
wychen@chromium.orga872e752015-04-28 23:42:18 +0000703 expected_args, result = top
704
maruel@chromium.orge52678e2013-04-26 18:34:44 +0000705 # Also logs otherwise it could get caught in a try/finally and be hard to
706 # diagnose.
707 if expected_args != args:
tandrii9d206752016-06-20 11:32:47 -0700708 N = 5
709 prior_calls = '\n '.join(
710 '@%d: %r' % (len(self._calls_done) - N + i, c[0])
711 for i, c in enumerate(self._calls_done[-N:]))
712 following_calls = '\n '.join(
713 '@%d: %r' % (len(self._calls_done) + i + 1, c[0])
714 for i, c in enumerate(self.calls[:N]))
715 extended_msg = (
716 'A few prior calls:\n %s\n\n'
717 'This (expected):\n @%d: %r\n'
718 'This (actual):\n @%d: %r\n\n'
719 'A few following expected calls:\n %s' %
720 (prior_calls, len(self._calls_done), expected_args,
721 len(self._calls_done), args, following_calls))
722 git_cl.logging.error(extended_msg)
723
tandrii99a72f22016-08-17 14:33:24 -0700724 self.fail('@%d\n'
725 ' Expected: %r\n'
726 ' Actual: %r' % (
tandrii9d206752016-06-20 11:32:47 -0700727 len(self._calls_done), expected_args, args))
728
729 self._calls_done.append(top)
tandrii5d48c322016-08-18 16:19:37 -0700730 if isinstance(result, Exception):
731 raise result
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000732 return result
733
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100734 def test_ask_for_explicit_yes_true(self):
735 self.calls = [
736 (('ask_for_data', 'prompt [Yes/No]: '), 'blah'),
737 (('ask_for_data', 'Please, type yes or no: '), 'ye'),
738 ]
739 self.assertTrue(git_cl.ask_for_explicit_yes('prompt'))
740
tandrii48df5812016-10-17 03:55:37 -0700741 def test_LoadCodereviewSettingsFromFile_gerrit(self):
742 codereview_file = StringIO.StringIO('GERRIT_HOST: true')
743 self.calls = [
744 ((['git', 'config', '--unset-all', 'rietveld.cc'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700745 ((['git', 'config', '--unset-all', 'rietveld.tree-status-url'],), CERR1),
746 ((['git', 'config', '--unset-all', 'rietveld.viewvc-url'],), CERR1),
747 ((['git', 'config', '--unset-all', 'rietveld.bug-prefix'],), CERR1),
748 ((['git', 'config', '--unset-all', 'rietveld.cpplint-regex'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700749 ((['git', 'config', '--unset-all', 'rietveld.cpplint-ignore-regex'],),
750 CERR1),
tandrii48df5812016-10-17 03:55:37 -0700751 ((['git', 'config', '--unset-all', 'rietveld.run-post-upload-hook'],),
752 CERR1),
753 ((['git', 'config', 'gerrit.host', 'true'],), ''),
754 ]
755 self.assertIsNone(git_cl.LoadCodereviewSettingsFromFile(codereview_file))
756
maruel@chromium.orga3353652011-11-30 14:26:57 +0000757 @classmethod
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000758 def _is_gerrit_calls(cls, gerrit=False):
759 return [((['git', 'config', 'rietveld.autoupdate'],), ''),
760 ((['git', 'config', 'gerrit.host'],), 'True' if gerrit else '')]
761
762 @classmethod
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +0000763 def _git_post_upload_calls(cls):
764 return [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000765 ((['git', 'rev-parse', 'HEAD'],), 'hash'),
766 ((['git', 'symbolic-ref', 'HEAD'],), 'hash'),
767 ((['git',
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000768 'config', 'branch.hash.last-upload-hash', 'hash'],), ''),
rmistry@google.com5626a922015-02-26 14:03:30 +0000769 ((['git', 'config', 'rietveld.run-post-upload-hook'],), ''),
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000770 ]
771
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000772 @staticmethod
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000773 def _git_sanity_checks(diff_base, working_branch, get_remote_branch=True):
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000774 fake_ancestor = 'fake_ancestor'
775 fake_cl = 'fake_cl_for_patch'
776 return [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000777 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000778 'rev-parse', '--verify', diff_base],), fake_ancestor),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000779 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000780 'merge-base', fake_ancestor, 'HEAD'],), fake_ancestor),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000781 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000782 'rev-list', '^' + fake_ancestor, 'HEAD'],), fake_cl),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000783 # Mock a config miss (error code 1)
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000784 ((['git',
tandrii5d48c322016-08-18 16:19:37 -0700785 'config', 'gitcl.remotebranch'],), CERR1),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000786 ] + ([
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000787 # Call to GetRemoteBranch()
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000788 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000789 'config', 'branch.%s.merge' % working_branch],),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000790 'refs/heads/master'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000791 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000792 'config', 'branch.%s.remote' % working_branch],), 'origin'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000793 ] if get_remote_branch else []) + [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000794 ((['git', 'rev-list', '^' + fake_ancestor,
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000795 'refs/remotes/origin/master'],), ''),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000796 ]
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000797
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000798 @classmethod
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000799 def _gerrit_ensure_auth_calls(
800 cls, issue=None, skip_auth_check=False, short_hostname='chromium'):
shinyak@chromium.org00dbccd2016-04-15 07:24:43 +0000801 cmd = ['git', 'config', '--bool', 'gerrit.skip-ensure-authenticated']
tandrii@chromium.org28253532016-04-14 13:46:56 +0000802 if skip_auth_check:
803 return [((cmd, ), 'true')]
804
tandrii5d48c322016-08-18 16:19:37 -0700805 calls = [((cmd, ), CERR1)]
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000806 if issue:
807 calls.extend([
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +0100808 ((['git', 'config', 'branch.master.gerritserver'],), CERR1),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000809 ])
810 calls.extend([
811 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
812 ((['git', 'config', 'branch.master.remote'],), 'origin'),
813 ((['git', 'config', 'remote.origin.url'],),
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000814 'https://%s.googlesource.com/my/repo' % short_hostname),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000815 ])
816 return calls
817
818 @classmethod
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100819 def _gerrit_base_calls(cls, issue=None, fetched_description=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200820 fetched_status=None, other_cl_owner=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000821 custom_cl_base=None, short_hostname='chromium'):
Aaron Gable13101a62018-02-09 13:20:41 -0800822 calls = cls._is_gerrit_calls(True)
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100823 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200824 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200825 ((['git', 'config', 'branch.master.gerritissue'],),
826 CERR1 if issue is None else str(issue)),
827 ]
828
829 if custom_cl_base:
830 ancestor_revision = custom_cl_base
831 else:
832 # Determine ancestor_revision to be merge base.
833 ancestor_revision = 'fake_ancestor_sha'
834 calls += [
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000835 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000836 ((['git', 'config', 'branch.master.remote'],), 'origin'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000837 ((['get_or_create_merge_base', 'master',
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200838 'refs/remotes/origin/master'],), ancestor_revision),
839 ]
840
841 # Calls to verify branch point is ancestor
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000842 calls += cls._gerrit_ensure_auth_calls(
843 issue=issue, short_hostname=short_hostname)
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100844
845 if issue:
846 calls += [
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000847 (('GetChangeDetail', '%s-review.googlesource.com' % short_hostname,
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +0000848 'my%2Frepo~123456',
Andrii Shyshkalovc4a73562018-09-25 18:40:17 +0000849 ['DETAILED_ACCOUNTS', 'CURRENT_REVISION', 'CURRENT_COMMIT', 'LABELS']
850 ),
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100851 {
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100852 'owner': {'email': (other_cl_owner or 'owner@example.com')},
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100853 'change_id': '123456789',
854 'current_revision': 'sha1_of_current_revision',
855 'revisions': { 'sha1_of_current_revision': {
856 'commit': {'message': fetched_description},
857 }},
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100858 'status': fetched_status or 'NEW',
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100859 }),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100860 ]
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100861 if fetched_status == 'ABANDONED':
862 calls += [
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000863 (('DieWithError', 'Change https://%s-review.googlesource.com/'
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100864 '123456 has been abandoned, new uploads are not '
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000865 'allowed' % short_hostname), SystemExitMock()),
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100866 ]
867 return calls
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100868 if other_cl_owner:
869 calls += [
870 (('ask_for_data', 'Press Enter to upload, or Ctrl+C to abort'), ''),
871 ]
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100872
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200873 calls += cls._git_sanity_checks(ancestor_revision, 'master',
874 get_remote_branch=False)
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100875 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200876 ((['git', 'rev-parse', '--show-cdup'],), ''),
877 ((['git', 'rev-parse', 'HEAD'],), '12345'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000878
Aaron Gable7817f022017-12-12 09:43:17 -0800879 ((['git', '-c', 'core.quotePath=false', 'diff', '--name-status',
880 '--no-renames', '-r', ancestor_revision + '...', '.'],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200881 'M\t.gitignore\n'),
882 ((['git', 'config', 'branch.master.gerritpatchset'],), CERR1),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100883 ]
884
885 if not issue:
886 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200887 ((['git', 'log', '--pretty=format:%s%n%n%b',
888 ancestor_revision + '...'],),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000889 'foo'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100890 ]
891
892 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200893 ((['git', 'config', 'user.email'],), 'me@example.com'),
894 ((['git', 'diff', '--no-ext-diff', '--stat', '-l100000', '-C50'] +
895 ([custom_cl_base] if custom_cl_base else
896 [ancestor_revision, 'HEAD']),),
897 '+dat'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100898 ]
899 return calls
ukai@chromium.orge8077812012-02-03 03:41:46 +0000900
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +0000901 @classmethod
902 def _gerrit_upload_calls(cls, description, reviewers, squash,
tandriia60502f2016-06-20 02:01:53 -0700903 squash_mode='default',
tandrii@chromium.org10625002016-03-04 20:03:47 +0000904 expected_upstream_ref='origin/refs/heads/master',
Aaron Gablefd238082017-06-07 13:42:34 -0700905 title=None, notify=False,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +0100906 post_amend_description=None, issue=None, cc=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000907 custom_cl_base=None, tbr=None,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +0000908 short_hostname='chromium',
909 labels=None):
tandrii@chromium.org10625002016-03-04 20:03:47 +0000910 if post_amend_description is None:
911 post_amend_description = description
bradnelsond975b302016-10-23 12:20:23 -0700912 cc = cc or []
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200913 # Determined in `_gerrit_base_calls`.
914 determined_ancestor_revision = custom_cl_base or 'fake_ancestor_sha'
915
916 calls = []
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000917
tandriia60502f2016-06-20 02:01:53 -0700918 if squash_mode == 'default':
919 calls.extend([
920 ((['git', 'config', '--bool', 'gerrit.override-squash-uploads'],), ''),
921 ((['git', 'config', '--bool', 'gerrit.squash-uploads'],), ''),
922 ])
923 elif squash_mode in ('override_squash', 'override_nosquash'):
924 calls.extend([
925 ((['git', 'config', '--bool', 'gerrit.override-squash-uploads'],),
926 'true' if squash_mode == 'override_squash' else 'false'),
927 ])
928 else:
929 assert squash_mode in ('squash', 'nosquash')
930
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000931 # If issue is given, then description is fetched from Gerrit instead.
932 if issue is None:
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000933 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200934 ((['git', 'log', '--pretty=format:%s\n\n%b',
935 ((custom_cl_base + '..') if custom_cl_base else
936 'fake_ancestor_sha..HEAD')],),
937 description),
938 ]
Aaron Gableb56ad332017-01-06 15:24:31 -0800939 if squash:
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +0000940 title = 'Initial_upload'
Aaron Gableb56ad332017-01-06 15:24:31 -0800941 else:
942 if not title:
943 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200944 ((['git', 'show', '-s', '--format=%s', 'HEAD'],), ''),
945 (('ask_for_data', 'Title for patchset []: '), 'User input'),
Aaron Gableb56ad332017-01-06 15:24:31 -0800946 ]
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +0000947 title = 'User_input'
tandrii@chromium.org57d86542016-03-04 16:11:32 +0000948 if not git_footers.get_footer_change_id(description) and not squash:
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000949 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200950 (('DownloadGerritHook', False), ''),
951 # Amending of commit message to get the Change-Id.
952 ((['git', 'log', '--pretty=format:%s\n\n%b',
953 determined_ancestor_revision + '..HEAD'],),
954 description),
955 ((['git', 'commit', '--amend', '-m', description],), ''),
956 ((['git', 'log', '--pretty=format:%s\n\n%b',
957 determined_ancestor_revision + '..HEAD'],),
958 post_amend_description)
959 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000960 if squash:
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000961 if not issue:
962 # Prompting to edit description on first upload.
963 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200964 ((['git', 'config', 'core.editor'],), ''),
965 ((['RunEditor'],), description),
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000966 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000967 ref_to_push = 'abcdef0123456789'
968 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200969 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
970 ((['git', 'config', 'branch.master.remote'],), 'origin'),
971 ]
972
973 if custom_cl_base is None:
974 calls += [
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000975 ((['get_or_create_merge_base', 'master',
976 'refs/remotes/origin/master'],),
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000977 'origin/master'),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200978 ]
979 parent = 'origin/master'
980 else:
981 calls += [
982 ((['git', 'merge-base', '--is-ancestor', custom_cl_base,
983 'refs/remotes/origin/master'],),
984 callError(1)), # Means not ancenstor.
985 (('ask_for_data',
986 'Do you take responsibility for cleaning up potential mess '
987 'resulting from proceeding with upload? Press Enter to upload, '
988 'or Ctrl+C to abort'), ''),
989 ]
990 parent = custom_cl_base
991
992 calls += [
993 ((['git', 'rev-parse', 'HEAD:'],), # `HEAD:` means HEAD's tree hash.
994 '0123456789abcdef'),
995 ((['git', 'commit-tree', '0123456789abcdef', '-p', parent,
Aaron Gable9a03ae02017-11-03 11:31:07 -0700996 '-F', '/tmp/named'],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200997 ref_to_push),
998 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000999 else:
1000 ref_to_push = 'HEAD'
1001
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001002 calls += [
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +00001003 (('SaveDescriptionBackup',), None),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001004 ((['git', 'rev-list',
1005 (custom_cl_base if custom_cl_base else expected_upstream_ref) + '..' +
1006 ref_to_push],),
1007 '1hashPerLine\n'),
1008 ]
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001009
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001010 metrics_arguments = []
1011
Aaron Gableafd52772017-06-27 16:40:10 -07001012 if notify:
Aaron Gable844cf292017-06-28 11:32:59 -07001013 ref_suffix = '%ready,notify=ALL'
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001014 metrics_arguments += ['ready', 'notify=ALL']
Aaron Gable844cf292017-06-28 11:32:59 -07001015 else:
Jamie Madill276da0b2018-04-27 14:41:20 -04001016 if not issue and squash:
Aaron Gable844cf292017-06-28 11:32:59 -07001017 ref_suffix = '%wip'
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001018 metrics_arguments.append('wip')
Aaron Gable844cf292017-06-28 11:32:59 -07001019 else:
1020 ref_suffix = '%notify=NONE'
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001021 metrics_arguments.append('notify=NONE')
Aaron Gable9b713dd2016-12-14 16:04:21 -08001022
Aaron Gable70f4e242017-06-26 10:45:59 -07001023 if title:
Aaron Gableafd52772017-06-27 16:40:10 -07001024 ref_suffix += ',m=' + title
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001025 metrics_arguments.append('m')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001026
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00001027 calls += [
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +00001028 ((['git', 'config', 'rietveld.cc'],), ''),
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00001029 ]
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001030 if short_hostname == 'chromium':
1031 # All reviwers and ccs get into ref_suffix.
1032 for r in sorted(reviewers):
1033 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001034 metrics_arguments.append('r')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001035 for c in sorted(['chromium-reviews+test-more-cc@chromium.org',
1036 'joe@example.com'] + cc):
1037 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001038 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001039 reviewers, cc = [], []
1040 else:
1041 # TODO(crbug/877717): remove this case.
1042 calls += [
1043 (('ValidAccounts', '%s-review.googlesource.com' % short_hostname,
1044 sorted(reviewers) + ['joe@example.com',
1045 'chromium-reviews+test-more-cc@chromium.org'] + cc),
1046 {
1047 e: {'email': e}
1048 for e in (reviewers + ['joe@example.com'] + cc)
1049 })
1050 ]
1051 for r in sorted(reviewers):
1052 if r != 'bad-account-or-email':
1053 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001054 metrics_arguments.append('r')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001055 reviewers.remove(r)
1056 for c in sorted(['joe@example.com'] + cc):
1057 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001058 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001059 if c in cc:
1060 cc.remove(c)
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00001061
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001062 if not tbr:
1063 for k, v in sorted((labels or {}).items()):
1064 ref_suffix += ',l=%s+%d' % (k, v)
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001065 metrics_arguments.append('l=%s+%d' % (k, v))
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001066
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001067 calls += [
1068 (('time.time',), 1000,),
1069 ((['git', 'push',
1070 'https://%s.googlesource.com/my/repo' % short_hostname,
1071 ref_to_push + ':refs/for/refs/heads/master' + ref_suffix],),
1072 (('remote:\n'
1073 'remote: Processing changes: (\)\n'
1074 'remote: Processing changes: (|)\n'
1075 'remote: Processing changes: (/)\n'
1076 'remote: Processing changes: (-)\n'
1077 'remote: Processing changes: new: 1 (/)\n'
1078 'remote: Processing changes: new: 1, done\n'
1079 'remote:\n'
1080 'remote: New Changes:\n'
1081 'remote: https://%s-review.googlesource.com/#/c/my/repo/+/123456'
1082 ' XXX\n'
1083 'remote:\n'
1084 'To https://%s.googlesource.com/my/repo\n'
1085 ' * [new branch] hhhh -> refs/for/refs/heads/master\n'
1086 ) % (short_hostname, short_hostname)),),
1087 (('time.time',), 2000,),
1088 (('add_repeated',
1089 'sub_commands',
1090 {
1091 'execution_time': 1000,
1092 'command': 'git push',
1093 'exit_code': 0,
1094 'arguments': sorted(metrics_arguments),
1095 }),
1096 None,),
1097 ]
1098
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001099 if squash:
1100 calls += [
tandrii33a46ff2016-08-23 05:53:40 -07001101 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001102 ''),
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001103 ((['git', 'config', 'branch.master.gerritserver',
tandrii5d48c322016-08-18 16:19:37 -07001104 'https://chromium-review.googlesource.com'],), ''),
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001105 ((['git', 'config', 'branch.master.gerritsquashhash',
1106 'abcdef0123456789'],), ''),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001107 ]
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001108 # TODO(crbug/877717): this should never be used.
1109 if squash and short_hostname != 'chromium':
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001110 calls += [
1111 (('AddReviewers',
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00001112 'chromium-review.googlesource.com', 'my%2Frepo~123456',
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001113 sorted(reviewers),
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00001114 cc + ['chromium-reviews+test-more-cc@chromium.org'],
1115 notify),
1116 ''),
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001117 ]
Aaron Gablefd238082017-06-07 13:42:34 -07001118 if tbr:
1119 calls += [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001120 (('GetChangeDetail', 'chromium-review.googlesource.com',
1121 'my%2Frepo~123456', ['LABELS']), {
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001122 'labels': {
1123 'Code-Review': {
1124 'default_value': 0,
1125 'all': [],
1126 'values': {
1127 '+2': 'lgtm, approved',
1128 '+1': 'lgtm, but someone else must approve',
1129 ' 0': 'No score',
1130 '-1': 'Don\'t submit as-is',
1131 }
1132 }
1133 }
1134 }),
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001135 (('SetReview',
1136 'chromium-review.googlesource.com',
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00001137 'my%2Frepo~123456',
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001138 'Self-approving for TBR',
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001139 {'Code-Review': 2}, None), ''),
Aaron Gablefd238082017-06-07 13:42:34 -07001140 ]
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +00001141 calls += cls._git_post_upload_calls()
ukai@chromium.orge8077812012-02-03 03:41:46 +00001142 return calls
1143
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001144 def _run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001145 self,
1146 upload_args,
1147 description,
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001148 reviewers=None,
tandriia60502f2016-06-20 02:01:53 -07001149 squash=True,
1150 squash_mode=None,
tandrii@chromium.org10625002016-03-04 20:03:47 +00001151 expected_upstream_ref='origin/refs/heads/master',
Aaron Gable9b713dd2016-12-14 16:04:21 -08001152 title=None,
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001153 notify=False,
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001154 post_amend_description=None,
bradnelsond975b302016-10-23 12:20:23 -07001155 issue=None,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +01001156 cc=None,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001157 fetched_status=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001158 other_cl_owner=None,
Aaron Gablefd238082017-06-07 13:42:34 -07001159 custom_cl_base=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001160 tbr=None,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001161 short_hostname='chromium',
1162 labels=None):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001163 """Generic gerrit upload test framework."""
tandriia60502f2016-06-20 02:01:53 -07001164 if squash_mode is None:
1165 if '--no-squash' in upload_args:
1166 squash_mode = 'nosquash'
1167 elif '--squash' in upload_args:
1168 squash_mode = 'squash'
1169 else:
1170 squash_mode = 'default'
1171
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001172 reviewers = reviewers or []
bradnelsond975b302016-10-23 12:20:23 -07001173 cc = cc or []
tandrii@chromium.org28253532016-04-14 13:46:56 +00001174 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii16e0b4e2016-06-07 10:34:28 -07001175 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001176 CookiesAuthenticatorMockFactory(
1177 same_auth=('git-owner.example.com', '', 'pass')))
tandrii16e0b4e2016-06-07 10:34:28 -07001178 self.mock(git_cl._GerritChangelistImpl, '_GerritCommitMsgHookCheck',
1179 lambda _, offer_removal: None)
tandriia60502f2016-06-20 02:01:53 -07001180 self.mock(git_cl.gclient_utils, 'RunEditor',
1181 lambda *_, **__: self._mocked_call(['RunEditor']))
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001182 self.mock(git_cl, 'DownloadGerritHook', lambda force: self._mocked_call(
1183 'DownloadGerritHook', force))
tandriia60502f2016-06-20 02:01:53 -07001184
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001185 self.calls = self._gerrit_base_calls(
1186 issue=issue,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001187 fetched_description=description,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001188 fetched_status=fetched_status,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001189 other_cl_owner=other_cl_owner,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001190 custom_cl_base=custom_cl_base,
1191 short_hostname=short_hostname)
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001192 if fetched_status != 'ABANDONED':
Aaron Gable9a03ae02017-11-03 11:31:07 -07001193 self.mock(tempfile, 'NamedTemporaryFile', MakeNamedTemporaryFileMock(
1194 expected_content=description))
1195 self.mock(os, 'remove', lambda _: True)
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001196 self.calls += self._gerrit_upload_calls(
1197 description, reviewers, squash,
1198 squash_mode=squash_mode,
1199 expected_upstream_ref=expected_upstream_ref,
Aaron Gablefd238082017-06-07 13:42:34 -07001200 title=title, notify=notify,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001201 post_amend_description=post_amend_description,
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001202 issue=issue, cc=cc,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001203 custom_cl_base=custom_cl_base, tbr=tbr,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001204 short_hostname=short_hostname,
1205 labels=labels)
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001206 # Uncomment when debugging.
1207 # print '\n'.join(map(lambda x: '%2i: %s' % x, enumerate(self.calls)))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001208 git_cl.main(['upload'] + upload_args)
1209
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001210 def test_gerrit_upload_without_change_id(self):
tandriia60502f2016-06-20 02:01:53 -07001211 self._run_gerrit_upload_test(
1212 ['--no-squash'],
1213 'desc\n\nBUG=\n',
1214 [],
1215 squash=False,
1216 post_amend_description='desc\n\nBUG=\n\nChange-Id: Ixxx')
1217
1218 def test_gerrit_upload_without_change_id_override_nosquash(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001219 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001220 [],
jamesr@chromium.org35d1a842012-07-27 00:20:43 +00001221 'desc\n\nBUG=\n',
tandrii@chromium.org10625002016-03-04 20:03:47 +00001222 [],
tandriia60502f2016-06-20 02:01:53 -07001223 squash=False,
1224 squash_mode='override_nosquash',
tandrii@chromium.org10625002016-03-04 20:03:47 +00001225 post_amend_description='desc\n\nBUG=\n\nChange-Id: Ixxx')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001226
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001227 def test_gerrit_no_reviewer(self):
1228 self._run_gerrit_upload_test(
1229 [],
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001230 'desc\n\nBUG=\n\nChange-Id: I123456789\n',
tandriia60502f2016-06-20 02:01:53 -07001231 [],
1232 squash=False,
1233 squash_mode='override_nosquash')
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001234
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001235 def test_gerrit_no_reviewer_non_chromium_host(self):
1236 # TODO(crbug/877717): remove this test case.
1237 self._run_gerrit_upload_test(
1238 [],
1239 'desc\n\nBUG=\n\nChange-Id: I123456789\n',
1240 [],
1241 squash=False,
1242 squash_mode='override_nosquash',
1243 short_hostname='other')
1244
Nick Carter8692b182017-11-06 16:30:38 -08001245 def test_gerrit_patchset_title_special_chars(self):
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001246 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
1247 self._run_gerrit_upload_test(
Nick Carter8692b182017-11-06 16:30:38 -08001248 ['-f', '-t', 'We\'ll escape ^_ ^ special chars...@{u}'],
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001249 'desc\n\nBUG=\n\nChange-Id: I123456789',
1250 squash=False,
1251 squash_mode='override_nosquash',
Nick Carter8692b182017-11-06 16:30:38 -08001252 title='We%27ll_escape_%5E%5F_%5E_special_chars%2E%2E%2E%40%7Bu%7D')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001253
ukai@chromium.orge8077812012-02-03 03:41:46 +00001254 def test_gerrit_reviewers_cmd_line(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001255 self._run_gerrit_upload_test(
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001256 ['-r', 'foo@example.com', '--send-mail'],
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001257 'desc\n\nBUG=\n\nChange-Id: I123456789',
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001258 ['foo@example.com'],
tandriia60502f2016-06-20 02:01:53 -07001259 squash=False,
1260 squash_mode='override_nosquash',
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001261 notify=True)
ukai@chromium.orge8077812012-02-03 03:41:46 +00001262
1263 def test_gerrit_reviewer_multiple(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001264 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001265 [],
bradnelsond975b302016-10-23 12:20:23 -07001266 'desc\nTBR=reviewer@example.com\nBUG=\nR=another@example.com\n'
1267 'CC=more@example.com,people@example.com\n\n'
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001268 'Change-Id: 123456789',
tandriia60502f2016-06-20 02:01:53 -07001269 ['reviewer@example.com', 'another@example.com'],
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001270 expected_upstream_ref='origin/master',
Aaron Gablefd238082017-06-07 13:42:34 -07001271 cc=['more@example.com', 'people@example.com'],
1272 tbr='reviewer@example.com')
tandriia60502f2016-06-20 02:01:53 -07001273
1274 def test_gerrit_upload_squash_first_is_default(self):
tandriia60502f2016-06-20 02:01:53 -07001275 self._run_gerrit_upload_test(
1276 [],
1277 'desc\nBUG=\n\nChange-Id: 123456789',
1278 [],
1279 expected_upstream_ref='origin/master')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001280
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001281 def test_gerrit_upload_squash_first(self):
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001282 self._run_gerrit_upload_test(
1283 ['--squash'],
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001284 'desc\nBUG=\n\nChange-Id: 123456789',
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001285 [],
luqui@chromium.org609f3952015-05-04 22:47:04 +00001286 squash=True,
1287 expected_upstream_ref='origin/master')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001288
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001289 def test_gerrit_upload_squash_first_with_labels(self):
1290 self._run_gerrit_upload_test(
1291 ['--squash', '--cq-dry-run', '--enable-auto-submit'],
1292 'desc\nBUG=\n\nChange-Id: 123456789',
1293 [],
1294 squash=True,
1295 expected_upstream_ref='origin/master',
1296 labels={'Commit-Queue': 1, 'Auto-Submit': 1})
1297
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001298 def test_gerrit_upload_squash_first_against_rev(self):
1299 custom_cl_base = 'custom_cl_base_rev_or_branch'
1300 self._run_gerrit_upload_test(
1301 ['--squash', custom_cl_base],
1302 'desc\nBUG=\n\nChange-Id: 123456789',
1303 [],
1304 squash=True,
1305 expected_upstream_ref='origin/master',
1306 custom_cl_base=custom_cl_base)
1307 self.assertIn(
1308 'If you proceed with upload, more than 1 CL may be created by Gerrit',
1309 sys.stdout.getvalue())
1310
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001311 def test_gerrit_upload_squash_reupload(self):
1312 description = 'desc\nBUG=\n\nChange-Id: 123456789'
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001313 self._run_gerrit_upload_test(
1314 ['--squash'],
1315 description,
1316 [],
1317 squash=True,
1318 expected_upstream_ref='origin/master',
1319 issue=123456)
1320
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001321 def test_gerrit_upload_squash_reupload_to_abandoned(self):
1322 self.mock(git_cl, 'DieWithError',
1323 lambda msg, change=None: self._mocked_call('DieWithError', msg))
1324 description = 'desc\nBUG=\n\nChange-Id: 123456789'
1325 with self.assertRaises(SystemExitMock):
1326 self._run_gerrit_upload_test(
1327 ['--squash'],
1328 description,
1329 [],
1330 squash=True,
1331 expected_upstream_ref='origin/master',
1332 issue=123456,
1333 fetched_status='ABANDONED')
1334
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001335 def test_gerrit_upload_squash_reupload_to_not_owned(self):
1336 self.mock(git_cl.gerrit_util, 'GetAccountDetails',
1337 lambda *_, **__: {'email': 'yet-another@example.com'})
1338 description = 'desc\nBUG=\n\nChange-Id: 123456789'
1339 self._run_gerrit_upload_test(
1340 ['--squash'],
1341 description,
1342 [],
1343 squash=True,
1344 expected_upstream_ref='origin/master',
1345 issue=123456,
1346 other_cl_owner='other@example.com')
1347 self.assertIn(
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001348 'WARNING: Change 123456 is owned by other@example.com, but you '
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001349 'authenticate to Gerrit as yet-another@example.com.\n'
1350 'Uploading may fail due to lack of permissions',
1351 git_cl.sys.stdout.getvalue())
1352
rmistry@google.com2dd99862015-06-22 12:22:18 +00001353 def test_upload_branch_deps(self):
tandrii@chromium.org28253532016-04-14 13:46:56 +00001354 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
rmistry@google.com2dd99862015-06-22 12:22:18 +00001355 def mock_run_git(*args, **_kwargs):
1356 if args[0] == ['for-each-ref',
1357 '--format=%(refname:short) %(upstream:short)',
1358 'refs/heads']:
1359 # Create a local branch dependency tree that looks like this:
1360 # test1 -> test2 -> test3 -> test4 -> test5
1361 # -> test3.1
1362 # test6 -> test0
1363 branch_deps = [
1364 'test2 test1', # test1 -> test2
1365 'test3 test2', # test2 -> test3
1366 'test3.1 test2', # test2 -> test3.1
1367 'test4 test3', # test3 -> test4
1368 'test5 test4', # test4 -> test5
1369 'test6 test0', # test0 -> test6
1370 'test7', # test7
1371 ]
1372 return '\n'.join(branch_deps)
1373 self.mock(git_cl, 'RunGit', mock_run_git)
1374
1375 class RecordCalls:
1376 times_called = 0
1377 record_calls = RecordCalls()
1378 def mock_CMDupload(*args, **_kwargs):
1379 record_calls.times_called += 1
1380 return 0
1381 self.mock(git_cl, 'CMDupload', mock_CMDupload)
1382
1383 self.calls = [
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001384 (('ask_for_data', 'This command will checkout all dependent branches '
1385 'and run "git cl upload". Press Enter to continue, '
1386 'or Ctrl+C to abort'), ''),
1387 ]
rmistry@google.com2dd99862015-06-22 12:22:18 +00001388
1389 class MockChangelist():
1390 def __init__(self):
1391 pass
1392 def GetBranch(self):
1393 return 'test1'
1394 def GetIssue(self):
1395 return '123'
1396 def GetPatchset(self):
1397 return '1001'
tandrii@chromium.org4c72b082016-03-31 22:26:35 +00001398 def IsGerrit(self):
1399 return False
rmistry@google.com2dd99862015-06-22 12:22:18 +00001400
1401 ret = git_cl.upload_branch_deps(MockChangelist(), [])
1402 # CMDupload should have been called 5 times because of 5 dependent branches.
1403 self.assertEquals(5, record_calls.times_called)
1404 self.assertEquals(0, ret)
1405
tandrii@chromium.org65874e12016-03-04 12:03:02 +00001406 def test_gerrit_change_id(self):
1407 self.calls = [
1408 ((['git', 'write-tree'], ),
1409 'hashtree'),
1410 ((['git', 'rev-parse', 'HEAD~0'], ),
1411 'branch-parent'),
1412 ((['git', 'var', 'GIT_AUTHOR_IDENT'], ),
1413 'A B <a@b.org> 1456848326 +0100'),
1414 ((['git', 'var', 'GIT_COMMITTER_IDENT'], ),
1415 'C D <c@d.org> 1456858326 +0100'),
1416 ((['git', 'hash-object', '-t', 'commit', '--stdin'], ),
1417 'hashchange'),
1418 ]
1419 change_id = git_cl.GenerateGerritChangeId('line1\nline2\n')
1420 self.assertEqual(change_id, 'Ihashchange')
1421
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00001422 def test_desecription_append_footer(self):
1423 for init_desc, footer_line, expected_desc in [
1424 # Use unique desc first lines for easy test failure identification.
1425 ('foo', 'R=one', 'foo\n\nR=one'),
1426 ('foo\n\nR=one', 'BUG=', 'foo\n\nR=one\nBUG='),
1427 ('foo\n\nR=one', 'Change-Id: Ixx', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1428 ('foo\n\nChange-Id: Ixx', 'R=one', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1429 ('foo\n\nR=one\n\nChange-Id: Ixx', 'TBR=two',
1430 'foo\n\nR=one\nTBR=two\n\nChange-Id: Ixx'),
1431 ('foo\n\nR=one\n\nChange-Id: Ixx', 'Foo-Bar: baz',
1432 'foo\n\nR=one\n\nChange-Id: Ixx\nFoo-Bar: baz'),
1433 ('foo\n\nChange-Id: Ixx', 'Foo-Bak: baz',
1434 'foo\n\nChange-Id: Ixx\nFoo-Bak: baz'),
1435 ('foo', 'Change-Id: Ixx', 'foo\n\nChange-Id: Ixx'),
1436 ]:
1437 desc = git_cl.ChangeDescription(init_desc)
1438 desc.append_footer(footer_line)
1439 self.assertEqual(desc.description, expected_desc)
1440
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001441 def test_update_reviewers(self):
1442 data = [
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001443 ('foo', [], [],
1444 'foo'),
1445 ('foo\nR=xx', [], [],
1446 'foo\nR=xx'),
1447 ('foo\nTBR=xx', [], [],
1448 'foo\nTBR=xx'),
1449 ('foo', ['a@c'], [],
1450 'foo\n\nR=a@c'),
1451 ('foo\nR=xx', ['a@c'], [],
1452 'foo\n\nR=a@c, xx'),
1453 ('foo\nTBR=xx', ['a@c'], [],
1454 'foo\n\nR=a@c\nTBR=xx'),
1455 ('foo\nTBR=xx\nR=yy', ['a@c'], [],
1456 'foo\n\nR=a@c, yy\nTBR=xx'),
1457 ('foo\nBUG=', ['a@c'], [],
1458 'foo\nBUG=\nR=a@c'),
1459 ('foo\nR=xx\nTBR=yy\nR=bar', ['a@c'], [],
1460 'foo\n\nR=a@c, bar, xx\nTBR=yy'),
1461 ('foo', ['a@c', 'b@c'], [],
1462 'foo\n\nR=a@c, b@c'),
1463 ('foo\nBar\n\nR=\nBUG=', ['c@c'], [],
1464 'foo\nBar\n\nR=c@c\nBUG='),
1465 ('foo\nBar\n\nR=\nBUG=\nR=', ['c@c'], [],
1466 'foo\nBar\n\nR=c@c\nBUG='),
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001467 # Same as the line before, but full of whitespaces.
1468 (
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001469 'foo\nBar\n\n R = \n BUG = \n R = ', ['c@c'], [],
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001470 'foo\nBar\n\nR=c@c\n BUG =',
1471 ),
1472 # Whitespaces aren't interpreted as new lines.
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001473 ('foo BUG=allo R=joe ', ['c@c'], [],
1474 'foo BUG=allo R=joe\n\nR=c@c'),
1475 # Redundant TBRs get promoted to Rs
1476 ('foo\n\nR=a@c\nTBR=t@c', ['b@c', 'a@c'], ['a@c', 't@c'],
1477 'foo\n\nR=a@c, b@c\nTBR=t@c'),
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001478 ]
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001479 expected = [i[-1] for i in data]
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001480 actual = []
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001481 for orig, reviewers, tbrs, _expected in data:
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001482 obj = git_cl.ChangeDescription(orig)
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001483 obj.update_reviewers(reviewers, tbrs)
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001484 actual.append(obj.description)
1485 self.assertEqual(expected, actual)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001486
Nodir Turakulov23b82142017-11-16 11:04:25 -08001487 def test_get_hash_tags(self):
1488 cases = [
1489 ('', []),
1490 ('a', []),
1491 ('[a]', ['a']),
1492 ('[aa]', ['aa']),
1493 ('[a ]', ['a']),
1494 ('[a- ]', ['a']),
1495 ('[a- b]', ['a-b']),
1496 ('[a--b]', ['a-b']),
1497 ('[a', []),
1498 ('[a]x', ['a']),
1499 ('[aa]x', ['aa']),
1500 ('[a b]', ['a-b']),
1501 ('[a b]', ['a-b']),
1502 ('[a__b]', ['a-b']),
1503 ('[a] x', ['a']),
1504 ('[a][b]', ['a', 'b']),
1505 ('[a] [b]', ['a', 'b']),
1506 ('[a][b]x', ['a', 'b']),
1507 ('[a][b] x', ['a', 'b']),
1508 ('[a]\n[b]', ['a']),
1509 ('[a\nb]', []),
1510 ('[a][', ['a']),
1511 ('Revert "[a] feature"', ['a']),
1512 ('Reland "[a] feature"', ['a']),
1513 ('Revert: [a] feature', ['a']),
1514 ('Reland: [a] feature', ['a']),
1515 ('Revert "Reland: [a] feature"', ['a']),
1516 ('Foo: feature', ['foo']),
1517 ('Foo Bar: feature', ['foo-bar']),
1518 ('Revert "Foo bar: feature"', ['foo-bar']),
1519 ('Reland "Foo bar: feature"', ['foo-bar']),
1520 ]
1521 for desc, expected in cases:
1522 change_desc = git_cl.ChangeDescription(desc)
1523 actual = change_desc.get_hash_tags()
1524 self.assertEqual(
1525 actual,
1526 expected,
1527 'GetHashTags(%r) == %r, expected %r' % (desc, actual, expected))
1528
wittman@chromium.org455dc922015-01-26 20:15:50 +00001529 def test_get_target_ref(self):
1530 # Check remote or remote branch not present.
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001531 self.assertEqual(None, git_cl.GetTargetRef('origin', None, 'master'))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001532 self.assertEqual(None, git_cl.GetTargetRef(None,
1533 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001534 'master'))
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001535
wittman@chromium.org455dc922015-01-26 20:15:50 +00001536 # Check default target refs for branches.
1537 self.assertEqual('refs/heads/master',
1538 git_cl.GetTargetRef('origin', 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001539 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001540 self.assertEqual('refs/heads/master',
1541 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkgr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001542 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001543 self.assertEqual('refs/heads/master',
1544 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkcr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001545 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001546 self.assertEqual('refs/branch-heads/123',
1547 git_cl.GetTargetRef('origin',
1548 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001549 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001550 self.assertEqual('refs/diff/test',
1551 git_cl.GetTargetRef('origin',
1552 'refs/remotes/origin/refs/diff/test',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001553 None))
rmistry@google.comc68112d2015-03-03 12:48:06 +00001554 self.assertEqual('refs/heads/chrome/m42',
1555 git_cl.GetTargetRef('origin',
1556 'refs/remotes/origin/chrome/m42',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001557 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001558
1559 # Check target refs for user-specified target branch.
1560 for branch in ('branch-heads/123', 'remotes/branch-heads/123',
1561 'refs/remotes/branch-heads/123'):
1562 self.assertEqual('refs/branch-heads/123',
1563 git_cl.GetTargetRef('origin',
1564 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001565 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001566 for branch in ('origin/master', 'remotes/origin/master',
1567 'refs/remotes/origin/master'):
1568 self.assertEqual('refs/heads/master',
1569 git_cl.GetTargetRef('origin',
1570 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001571 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001572 for branch in ('master', 'heads/master', 'refs/heads/master'):
1573 self.assertEqual('refs/heads/master',
1574 git_cl.GetTargetRef('origin',
1575 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001576 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001577
wychen@chromium.orga872e752015-04-28 23:42:18 +00001578 def test_patch_when_dirty(self):
1579 # Patch when local tree is dirty
1580 self.mock(git_common, 'is_dirty_git_tree', lambda x: True)
1581 self.assertNotEqual(git_cl.main(['patch', '123456']), 0)
1582
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001583 @staticmethod
1584 def _get_gerrit_codereview_server_calls(branch, value=None,
1585 git_short_host='host',
Aaron Gable697a91b2018-01-19 15:20:15 -08001586 detect_branch=True,
1587 detect_server=True):
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001588 """Returns calls executed by _GerritChangelistImpl.GetCodereviewServer.
1589
1590 If value is given, branch.<BRANCH>.gerritcodereview is already set.
1591 """
1592 calls = []
1593 if detect_branch:
1594 calls.append(((['git', 'symbolic-ref', 'HEAD'],), branch))
Aaron Gable697a91b2018-01-19 15:20:15 -08001595 if detect_server:
1596 calls.append(((['git', 'config', 'branch.' + branch + '.gerritserver'],),
1597 CERR1 if value is None else value))
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001598 if value is None:
1599 calls += [
1600 ((['git', 'config', 'branch.' + branch + '.merge'],),
1601 'refs/heads' + branch),
1602 ((['git', 'config', 'branch.' + branch + '.remote'],),
1603 'origin'),
1604 ((['git', 'config', 'remote.origin.url'],),
1605 'https://%s.googlesource.com/my/repo' % git_short_host),
1606 ]
1607 return calls
1608
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001609 def _patch_common(self, force_codereview=False,
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001610 new_branch=False, git_short_host='host',
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001611 detect_gerrit_server=False,
1612 actual_codereview=None,
1613 codereview_in_url=False):
tandrii@chromium.org28253532016-04-14 13:46:56 +00001614 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
wychen@chromium.orga872e752015-04-28 23:42:18 +00001615 self.mock(git_cl, 'IsGitVersionAtLeast', lambda *args: True)
1616
tandriidf09a462016-08-18 16:23:55 -07001617 if new_branch:
1618 self.calls = [((['git', 'new-branch', 'master'],), ''),]
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001619
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001620 if codereview_in_url and actual_codereview == 'rietveld':
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001621 self.calls += [
1622 ((['git', 'rev-parse', '--show-cdup'],), ''),
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001623 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001624 ]
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001625
1626 if not force_codereview and not codereview_in_url:
1627 # These calls detect codereview to use.
1628 self.calls += [
1629 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001630 ((['git', 'config', 'branch.master.gerritissue'],), CERR1),
1631 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
1632 ((['git', 'config', 'gerrit.host'],), 'true'),
1633 ]
1634 if detect_gerrit_server:
1635 self.calls += self._get_gerrit_codereview_server_calls(
1636 'master', git_short_host=git_short_host,
1637 detect_branch=not new_branch and force_codereview)
1638 actual_codereview = 'gerrit'
1639
1640 if actual_codereview == 'gerrit':
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001641 self.calls += [
1642 (('GetChangeDetail', git_short_host + '-review.googlesource.com',
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001643 'my%2Frepo~123456', ['ALL_REVISIONS', 'CURRENT_COMMIT']),
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001644 {
1645 'current_revision': '7777777777',
1646 'revisions': {
1647 '1111111111': {
1648 '_number': 1,
1649 'fetch': {'http': {
1650 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1651 'ref': 'refs/changes/56/123456/1',
1652 }},
1653 },
1654 '7777777777': {
1655 '_number': 7,
1656 'fetch': {'http': {
1657 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1658 'ref': 'refs/changes/56/123456/7',
1659 }},
1660 },
1661 },
1662 }),
1663 ]
wychen@chromium.orga872e752015-04-28 23:42:18 +00001664
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001665 def test_patch_gerrit_default(self):
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001666 self._patch_common(git_short_host='chromium', detect_gerrit_server=True)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001667 self.calls += [
1668 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1669 'refs/changes/56/123456/7'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001670 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001671 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
Aaron Gable697a91b2018-01-19 15:20:15 -08001672 ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001673 ((['git', 'config', 'branch.master.gerritserver',
1674 'https://chromium-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001675 ((['git', 'config', 'branch.master.gerritpatchset', '7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001676 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1677 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1678 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001679 ]
1680 self.assertEqual(git_cl.main(['patch', '123456']), 0)
1681
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001682 def test_patch_gerrit_new_branch(self):
1683 self._patch_common(
1684 git_short_host='chromium', detect_gerrit_server=True, new_branch=True)
1685 self.calls += [
1686 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1687 'refs/changes/56/123456/7'],), ''),
1688 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
1689 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
1690 ''),
1691 ((['git', 'config', 'branch.master.gerritserver',
1692 'https://chromium-review.googlesource.com'],), ''),
1693 ((['git', 'config', 'branch.master.gerritpatchset', '7'],), ''),
1694 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1695 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1696 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
1697 ]
1698 self.assertEqual(git_cl.main(['patch', '-b', 'master', '123456']), 0)
1699
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001700 def test_patch_gerrit_force(self):
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001701 self._patch_common(
1702 force_codereview=True, git_short_host='host', detect_gerrit_server=True)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001703 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001704 ((['git', 'fetch', 'https://host.googlesource.com/my/repo',
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001705 'refs/changes/56/123456/7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001706 ((['git', 'reset', '--hard', 'FETCH_HEAD'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001707 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001708 ''),
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001709 ((['git', 'config', 'branch.master.gerritserver',
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001710 'https://host-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001711 ((['git', 'config', 'branch.master.gerritpatchset', '7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001712 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1713 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1714 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001715 ]
Aaron Gable62619a32017-06-16 08:22:09 -07001716 self.assertEqual(git_cl.main(['patch', '--gerrit', '123456', '--force']), 0)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001717
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001718 def test_patch_gerrit_guess_by_url(self):
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001719 self.calls += self._get_gerrit_codereview_server_calls(
1720 'master', git_short_host='else', detect_server=False)
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001721 self._patch_common(
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001722 actual_codereview='gerrit', git_short_host='else',
1723 codereview_in_url=True, detect_gerrit_server=False)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001724 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001725 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001726 'refs/changes/56/123456/1'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001727 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001728 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001729 ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001730 ((['git', 'config', 'branch.master.gerritserver',
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001731 'https://else-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001732 ((['git', 'config', 'branch.master.gerritpatchset', '1'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001733 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1734 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1735 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001736 ]
1737 self.assertEqual(git_cl.main(
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001738 ['patch', 'https://else-review.googlesource.com/#/c/123456/1']), 0)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001739
Aaron Gable697a91b2018-01-19 15:20:15 -08001740 def test_patch_gerrit_guess_by_url_with_repo(self):
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001741 self.calls += self._get_gerrit_codereview_server_calls(
1742 'master', git_short_host='else', detect_server=False)
Aaron Gable697a91b2018-01-19 15:20:15 -08001743 self._patch_common(
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001744 actual_codereview='gerrit', git_short_host='else',
1745 codereview_in_url=True, detect_gerrit_server=False)
Aaron Gable697a91b2018-01-19 15:20:15 -08001746 self.calls += [
1747 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
1748 'refs/changes/56/123456/1'],), ''),
1749 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
1750 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
1751 ''),
1752 ((['git', 'config', 'branch.master.gerritserver',
1753 'https://else-review.googlesource.com'],), ''),
1754 ((['git', 'config', 'branch.master.gerritpatchset', '1'],), ''),
1755 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1756 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1757 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
1758 ]
1759 self.assertEqual(git_cl.main(
1760 ['patch', 'https://else-review.googlesource.com/c/my/repo/+/123456/1']),
1761 0)
1762
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001763 def test_patch_gerrit_conflict(self):
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001764 self._patch_common(detect_gerrit_server=True, git_short_host='chromium')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001765 self.calls += [
1766 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001767 'refs/changes/56/123456/7'],), ''),
tandrii5d48c322016-08-18 16:19:37 -07001768 ((['git', 'cherry-pick', 'FETCH_HEAD'],), CERR1),
1769 ((['DieWithError', 'Command "git cherry-pick FETCH_HEAD" failed.\n'],),
1770 SystemExitMock()),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001771 ]
1772 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001773 git_cl.main(['patch', '123456'])
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001774
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001775 def test_patch_gerrit_not_exists(self):
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01001776 def notExists(_issue, *_, **kwargs):
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01001777 raise git_cl.gerrit_util.GerritError(404, '')
1778 self.mock(git_cl.gerrit_util, 'GetChangeDetail', notExists)
1779
tandriic2405f52016-10-10 08:13:15 -07001780 self.calls = [
1781 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
tandriic2405f52016-10-10 08:13:15 -07001782 ((['git', 'config', 'branch.master.gerritissue'],), CERR1),
1783 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
1784 ((['git', 'config', 'gerrit.host'],), 'true'),
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001785 ((['git', 'config', 'branch.master.gerritserver'],), CERR1),
1786 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
1787 ((['git', 'config', 'branch.master.remote'],), 'origin'),
1788 ((['git', 'config', 'remote.origin.url'],),
1789 'https://chromium.googlesource.com/my/repo'),
1790 ((['DieWithError',
1791 'change 123456 at https://chromium-review.googlesource.com does not '
1792 'exist or you have no access to it'],), SystemExitMock()),
tandriic2405f52016-10-10 08:13:15 -07001793 ]
1794 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001795 self.assertEqual(1, git_cl.main(['patch', '123456']))
tandriic2405f52016-10-10 08:13:15 -07001796
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001797 def _checkout_calls(self):
1798 return [
1799 ((['git', 'config', '--local', '--get-regexp',
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001800 'branch\\..*\\.gerritissue'], ),
1801 ('branch.ger-branch.gerritissue 123456\n'
1802 'branch.gbranch654.gerritissue 654321\n')),
1803 ]
1804
1805 def test_checkout_gerrit(self):
1806 """Tests git cl checkout <issue>."""
1807 self.calls = self._checkout_calls()
1808 self.calls += [((['git', 'checkout', 'ger-branch'], ), '')]
1809 self.assertEqual(0, git_cl.main(['checkout', '123456']))
1810
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001811 def test_checkout_not_found(self):
1812 """Tests git cl checkout <issue>."""
tandrii@chromium.org28253532016-04-14 13:46:56 +00001813 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001814 self.calls = self._checkout_calls()
1815 self.assertEqual(1, git_cl.main(['checkout', '99999']))
1816
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001817 def test_checkout_no_branch_issues(self):
1818 """Tests git cl checkout <issue>."""
tandrii@chromium.org28253532016-04-14 13:46:56 +00001819 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001820 self.calls = [
1821 ((['git', 'config', '--local', '--get-regexp',
tandrii5d48c322016-08-18 16:19:37 -07001822 'branch\\..*\\.gerritissue'], ), CERR1),
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001823 ]
1824 self.assertEqual(1, git_cl.main(['checkout', '99999']))
1825
tandrii@chromium.org28253532016-04-14 13:46:56 +00001826 def _test_gerrit_ensure_authenticated_common(self, auth,
1827 skip_auth_check=False):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001828 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
1829 CookiesAuthenticatorMockFactory(hosts_with_creds=auth))
1830 self.mock(git_cl, 'DieWithError',
Christopher Lamf732cd52017-01-24 12:40:11 +11001831 lambda msg, change=None: self._mocked_call(['DieWithError', msg]))
tandrii@chromium.org28253532016-04-14 13:46:56 +00001832 self.calls = self._gerrit_ensure_auth_calls(skip_auth_check=skip_auth_check)
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001833 cl = git_cl.Changelist(codereview='gerrit')
tandrii@chromium.org28253532016-04-14 13:46:56 +00001834 cl.branch = 'master'
1835 cl.branchref = 'refs/heads/master'
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001836 cl.lookedup_issue = True
1837 return cl
1838
1839 def test_gerrit_ensure_authenticated_missing(self):
1840 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001841 'chromium.googlesource.com': ('git-is.ok', '', 'but gerrit is missing'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001842 })
1843 self.calls.append(
1844 ((['DieWithError',
1845 'Credentials for the following hosts are required:\n'
1846 ' chromium-review.googlesource.com\n'
1847 'These are read from ~/.gitcookies (or legacy ~/.netrc)\n'
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01001848 'You can (re)generate your credentials by visiting '
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001849 'https://chromium-review.googlesource.com/new-password'],), ''),)
1850 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1851
1852 def test_gerrit_ensure_authenticated_conflict(self):
tandrii@chromium.org28253532016-04-14 13:46:56 +00001853 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001854 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001855 'chromium.googlesource.com':
1856 ('git-one.example.com', None, 'secret1'),
1857 'chromium-review.googlesource.com':
1858 ('git-other.example.com', None, 'secret2'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001859 })
1860 self.calls.append(
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001861 (('ask_for_data', 'If you know what you are doing '
1862 'press Enter to continue, or Ctrl+C to abort'), ''))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001863 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1864
1865 def test_gerrit_ensure_authenticated_ok(self):
1866 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001867 'chromium.googlesource.com':
1868 ('git-same.example.com', None, 'secret'),
1869 'chromium-review.googlesource.com':
1870 ('git-same.example.com', None, 'secret'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001871 })
1872 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1873
tandrii@chromium.org28253532016-04-14 13:46:56 +00001874 def test_gerrit_ensure_authenticated_skipped(self):
1875 cl = self._test_gerrit_ensure_authenticated_common(
1876 auth={}, skip_auth_check=True)
1877 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1878
Eric Boren2fb63102018-10-05 13:05:03 +00001879 def test_gerrit_ensure_authenticated_bearer_token(self):
1880 cl = self._test_gerrit_ensure_authenticated_common(auth={
1881 'chromium.googlesource.com':
1882 ('', None, 'secret'),
1883 'chromium-review.googlesource.com':
1884 ('', None, 'secret'),
1885 })
1886 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1887 header = gerrit_util.CookiesAuthenticator().get_auth_header(
1888 'chromium.googlesource.com')
1889 self.assertTrue('Bearer' in header)
1890
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01001891 def _cmd_set_commit_gerrit_common(self, vote, notify=None):
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001892 self.mock(git_cl.gerrit_util, 'SetReview',
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01001893 lambda h, i, labels, notify=None:
1894 self._mocked_call(['SetReview', h, i, labels, notify]))
1895
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001896 self.calls = [
1897 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07001898 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001899 ((['git', 'config', 'branch.feature.gerritserver'],),
1900 'https://chromium-review.googlesource.com'),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00001901 ((['git', 'config', 'branch.feature.merge'],), 'refs/heads/master'),
1902 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
1903 ((['git', 'config', 'remote.origin.url'],),
1904 'https://chromium.googlesource.com/infra/infra.git'),
1905 ((['SetReview', 'chromium-review.googlesource.com',
1906 'infra%2Finfra~123',
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01001907 {'Commit-Queue': vote}, notify],), ''),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001908 ]
tandriid9e5ce52016-07-13 02:32:59 -07001909
1910 def test_cmd_set_commit_gerrit_clear(self):
1911 self._cmd_set_commit_gerrit_common(0)
1912 self.assertEqual(0, git_cl.main(['set-commit', '-c']))
1913
1914 def test_cmd_set_commit_gerrit_dry(self):
Aaron Gable75e78722017-06-09 10:40:16 -07001915 self._cmd_set_commit_gerrit_common(1, notify=False)
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001916 self.assertEqual(0, git_cl.main(['set-commit', '-d']))
1917
tandriid9e5ce52016-07-13 02:32:59 -07001918 def test_cmd_set_commit_gerrit(self):
1919 self._cmd_set_commit_gerrit_common(2)
1920 self.assertEqual(0, git_cl.main(['set-commit']))
1921
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001922 def test_description_display(self):
1923 out = StringIO.StringIO()
1924 self.mock(git_cl.sys, 'stdout', out)
1925
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00001926 self.mock(git_cl, 'Changelist', ChangelistMock)
1927 ChangelistMock.desc = 'foo\n'
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001928
1929 self.assertEqual(0, git_cl.main(['description', '-d']))
1930 self.assertEqual('foo\n', out.getvalue())
1931
iannucci3c972b92016-08-17 13:24:10 -07001932 def test_StatusFieldOverrideIssueMissingArgs(self):
1933 out = StringIO.StringIO()
1934 self.mock(git_cl.sys, 'stderr', out)
1935
1936 try:
1937 self.assertEqual(git_cl.main(['status', '--issue', '1']), 0)
1938 except SystemExit as ex:
1939 self.assertEqual(ex.code, 2)
iannuccie53c9352016-08-17 14:40:40 -07001940 self.assertRegexpMatches(out.getvalue(), r'--issue must be specified')
iannucci3c972b92016-08-17 13:24:10 -07001941
1942 out = StringIO.StringIO()
1943 self.mock(git_cl.sys, 'stderr', out)
1944
1945 try:
Andrii Shyshkalovfeec80e2018-10-16 01:00:47 +00001946 self.assertEqual(git_cl.main(['status', '--issue', '1', '--gerrit']), 0)
iannucci3c972b92016-08-17 13:24:10 -07001947 except SystemExit as ex:
1948 self.assertEqual(ex.code, 2)
iannuccie53c9352016-08-17 14:40:40 -07001949 self.assertRegexpMatches(out.getvalue(), r'--field must be specified')
iannucci3c972b92016-08-17 13:24:10 -07001950
1951 def test_StatusFieldOverrideIssue(self):
1952 out = StringIO.StringIO()
1953 self.mock(git_cl.sys, 'stdout', out)
1954
1955 def assertIssue(cl_self, *_args):
1956 self.assertEquals(cl_self.issue, 1)
1957 return 'foobar'
1958
1959 self.mock(git_cl.Changelist, 'GetDescription', assertIssue)
iannuccie53c9352016-08-17 14:40:40 -07001960 self.assertEqual(
Andrii Shyshkalovfeec80e2018-10-16 01:00:47 +00001961 git_cl.main(['status', '--issue', '1', '--gerrit', '--field', 'desc']),
iannuccie53c9352016-08-17 14:40:40 -07001962 0)
iannucci3c972b92016-08-17 13:24:10 -07001963 self.assertEqual(out.getvalue(), 'foobar\n')
1964
iannuccie53c9352016-08-17 14:40:40 -07001965 def test_SetCloseOverrideIssue(self):
1966 def assertIssue(cl_self, *_args):
1967 self.assertEquals(cl_self.issue, 1)
1968 return 'foobar'
1969
1970 self.mock(git_cl.Changelist, 'GetDescription', assertIssue)
1971 self.mock(git_cl.Changelist, 'CloseIssue', lambda *_: None)
iannuccie53c9352016-08-17 14:40:40 -07001972 self.assertEqual(
Andrii Shyshkalovfeec80e2018-10-16 01:00:47 +00001973 git_cl.main(['set-close', '--issue', '1', '--gerrit']), 0)
iannuccie53c9352016-08-17 14:40:40 -07001974
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00001975 def test_description(self):
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001976 out = StringIO.StringIO()
1977 self.mock(git_cl.sys, 'stdout', out)
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001978 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001979 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
1980 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
1981 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
1982 ((['git', 'config', 'remote.origin.url'],),
1983 'https://chromium.googlesource.com/my/repo'),
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00001984 (('GetChangeDetail', 'chromium-review.googlesource.com',
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001985 'my%2Frepo~123123', ['CURRENT_REVISION', 'CURRENT_COMMIT']),
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001986 {
1987 'current_revision': 'sha1',
1988 'revisions': {'sha1': {
1989 'commit': {'message': 'foobar'},
1990 }},
1991 }),
1992 ]
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001993 self.assertEqual(0, git_cl.main([
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00001994 'description',
1995 'https://chromium-review.googlesource.com/c/my/repo/+/123123',
1996 '-d']))
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001997 self.assertEqual('foobar\n', out.getvalue())
1998
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00001999 def test_description_set_raw(self):
2000 out = StringIO.StringIO()
2001 self.mock(git_cl.sys, 'stdout', out)
2002
2003 self.mock(git_cl, 'Changelist', ChangelistMock)
2004 self.mock(git_cl.sys, 'stdin', StringIO.StringIO('hihi'))
2005
2006 self.assertEqual(0, git_cl.main(['description', '-n', 'hihi']))
2007 self.assertEqual('hihi', ChangelistMock.desc)
2008
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002009 def test_description_appends_bug_line(self):
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002010 current_desc = 'Some.\n\nChange-Id: xxx'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002011
2012 def RunEditor(desc, _, **kwargs):
2013 self.assertEquals(
2014 '# Enter a description of the change.\n'
2015 '# This will be displayed on the codereview site.\n'
2016 '# The first line will also be used as the subject of the review.\n'
2017 '#--------------------This line is 72 characters long'
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002018 '--------------------\n'
Aaron Gable3a16ed12017-03-23 10:51:55 -07002019 'Some.\n\nChange-Id: xxx\nBug: ',
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002020 desc)
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002021 # Simulate user changing something.
Aaron Gable3a16ed12017-03-23 10:51:55 -07002022 return 'Some.\n\nChange-Id: xxx\nBug: 123'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002023
dsansomee2d6fd92016-09-08 00:10:47 -07002024 def UpdateDescriptionRemote(_, desc, force=False):
Aaron Gable3a16ed12017-03-23 10:51:55 -07002025 self.assertEquals(desc, 'Some.\n\nChange-Id: xxx\nBug: 123')
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002026
2027 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2028 self.mock(git_cl.Changelist, 'GetDescription',
2029 lambda *args: current_desc)
2030 self.mock(git_cl._GerritChangelistImpl, 'UpdateDescriptionRemote',
2031 UpdateDescriptionRemote)
2032 self.mock(git_cl.gclient_utils, 'RunEditor', RunEditor)
2033
2034 self.calls = [
2035 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07002036 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
tandrii5d48c322016-08-18 16:19:37 -07002037 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
2038 ((['git', 'config', 'rietveld.bug-prefix'],), CERR1),
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002039 ((['git', 'config', 'core.editor'],), 'vi'),
2040 ]
2041 self.assertEqual(0, git_cl.main(['description', '--gerrit']))
2042
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002043 def test_description_set_stdin(self):
2044 out = StringIO.StringIO()
2045 self.mock(git_cl.sys, 'stdout', out)
2046
2047 self.mock(git_cl, 'Changelist', ChangelistMock)
2048 self.mock(git_cl.sys, 'stdin', StringIO.StringIO('hi \r\n\t there\n\nman'))
2049
2050 self.assertEqual(0, git_cl.main(['description', '-n', '-']))
2051 self.assertEqual('hi\n\t there\n\nman', ChangelistMock.desc)
2052
kmarshall3bff56b2016-06-06 18:31:47 -07002053 def test_archive(self):
tandrii1c67da62016-06-10 07:35:53 -07002054 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2055
kmarshall3bff56b2016-06-06 18:31:47 -07002056 self.calls = \
2057 [((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2058 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002059 ((['git', 'config', 'branch.master.gerritissue'],), '456'),
2060 ((['git', 'config', 'branch.foo.gerritissue'],), CERR1),
tandrii5d48c322016-08-18 16:19:37 -07002061 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002062 ((['git', 'config', 'gerrit.host'],), 'true'),
tandrii33a46ff2016-08-23 05:53:40 -07002063 ((['git', 'config', 'branch.bar.gerritissue'],), '789'),
kmarshall3bff56b2016-06-06 18:31:47 -07002064 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2065 ((['git', 'tag', 'git-cl-archived-456-foo', 'foo'],), ''),
2066 ((['git', 'branch', '-D', 'foo'],), '')]
2067
kmarshall3bff56b2016-06-06 18:31:47 -07002068 self.mock(git_cl, 'get_cl_statuses',
2069 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002070 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2071 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2072 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
kmarshall3bff56b2016-06-06 18:31:47 -07002073
2074 self.assertEqual(0, git_cl.main(['archive', '-f']))
2075
2076 def test_archive_current_branch_fails(self):
tandrii1c67da62016-06-10 07:35:53 -07002077 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
kmarshall3bff56b2016-06-06 18:31:47 -07002078 self.calls = \
2079 [((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2080 'refs/heads/master'),
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002081 ((['git', 'config', 'branch.master.gerritissue'],), '1'),
kmarshall3bff56b2016-06-06 18:31:47 -07002082 ((['git', 'symbolic-ref', 'HEAD'],), 'master')]
2083
kmarshall9249e012016-08-23 12:02:16 -07002084 self.mock(git_cl, 'get_cl_statuses',
2085 lambda branches, fine_grained, max_processes:
2086 [(MockChangelistWithBranchAndIssue('master', 1), 'closed')])
2087
2088 self.assertEqual(1, git_cl.main(['archive', '-f']))
2089
2090 def test_archive_dry_run(self):
2091 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2092
2093 self.calls = \
2094 [((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2095 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002096 ((['git', 'config', 'branch.master.gerritissue'],), '456'),
2097 ((['git', 'config', 'branch.foo.gerritissue'],), CERR1),
kmarshall9249e012016-08-23 12:02:16 -07002098 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002099 ((['git', 'config', 'gerrit.host'],), 'true'),
kmarshall9249e012016-08-23 12:02:16 -07002100 ((['git', 'config', 'branch.bar.gerritissue'],), '789'),
2101 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),]
kmarshall3bff56b2016-06-06 18:31:47 -07002102
2103 self.mock(git_cl, 'get_cl_statuses',
2104 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002105 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2106 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2107 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
kmarshall3bff56b2016-06-06 18:31:47 -07002108
kmarshall9249e012016-08-23 12:02:16 -07002109 self.assertEqual(0, git_cl.main(['archive', '-f', '--dry-run']))
2110
2111 def test_archive_no_tags(self):
2112 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2113
2114 self.calls = \
2115 [((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2116 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002117 ((['git', 'config', 'branch.master.gerritissue'],), '1'),
2118 ((['git', 'config', 'branch.foo.gerritissue'],), '456'),
2119 ((['git', 'config', 'branch.bar.gerritissue'],), CERR1),
kmarshall9249e012016-08-23 12:02:16 -07002120 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002121 ((['git', 'config', 'gerrit.host'],), 'true'),
kmarshall9249e012016-08-23 12:02:16 -07002122 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2123 ((['git', 'branch', '-D', 'foo'],), '')]
2124
2125 self.mock(git_cl, 'get_cl_statuses',
2126 lambda branches, fine_grained, max_processes:
2127 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2128 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2129 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
2130
2131 self.assertEqual(0, git_cl.main(['archive', '-f', '--notags']))
kmarshall3bff56b2016-06-06 18:31:47 -07002132
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002133 def test_cmd_issue_erase_existing(self):
2134 out = StringIO.StringIO()
2135 self.mock(git_cl.sys, 'stdout', out)
2136 self.calls = [
2137 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07002138 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002139 # Let this command raise exception (retcode=1) - it should be ignored.
2140 ((['git', 'config', '--unset', 'branch.feature.last-upload-hash'],),
tandrii5d48c322016-08-18 16:19:37 -07002141 CERR1),
2142 ((['git', 'config', '--unset', 'branch.feature.gerritissue'],), ''),
2143 ((['git', 'config', '--unset', 'branch.feature.gerritpatchset'],), ''),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002144 ((['git', 'config', '--unset', 'branch.feature.gerritserver'],), ''),
2145 ((['git', 'config', '--unset', 'branch.feature.gerritsquashhash'],),
2146 ''),
Aaron Gableca01e2c2017-07-19 11:16:02 -07002147 ((['git', 'log', '-1', '--format=%B'],), 'This is a description'),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002148 ]
2149 self.assertEqual(0, git_cl.main(['issue', '0']))
2150
Aaron Gable400e9892017-07-12 15:31:21 -07002151 def test_cmd_issue_erase_existing_with_change_id(self):
2152 out = StringIO.StringIO()
2153 self.mock(git_cl.sys, 'stdout', out)
2154 self.mock(git_cl.Changelist, 'GetDescription',
2155 lambda _: 'This is a description\n\nChange-Id: Ideadbeef')
2156 self.calls = [
2157 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
Aaron Gable400e9892017-07-12 15:31:21 -07002158 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
Aaron Gable400e9892017-07-12 15:31:21 -07002159 # Let this command raise exception (retcode=1) - it should be ignored.
2160 ((['git', 'config', '--unset', 'branch.feature.last-upload-hash'],),
2161 CERR1),
2162 ((['git', 'config', '--unset', 'branch.feature.gerritissue'],), ''),
2163 ((['git', 'config', '--unset', 'branch.feature.gerritpatchset'],), ''),
2164 ((['git', 'config', '--unset', 'branch.feature.gerritserver'],), ''),
2165 ((['git', 'config', '--unset', 'branch.feature.gerritsquashhash'],),
2166 ''),
Aaron Gableca01e2c2017-07-19 11:16:02 -07002167 ((['git', 'log', '-1', '--format=%B'],),
2168 'This is a description\n\nChange-Id: Ideadbeef'),
2169 ((['git', 'commit', '--amend', '-m', 'This is a description\n'],), ''),
Aaron Gable400e9892017-07-12 15:31:21 -07002170 ]
2171 self.assertEqual(0, git_cl.main(['issue', '0']))
2172
phajdan.jre328cf92016-08-22 04:12:17 -07002173 def test_cmd_issue_json(self):
2174 out = StringIO.StringIO()
2175 self.mock(git_cl.sys, 'stdout', out)
2176 self.calls = [
2177 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002178 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
2179 ((['git', 'config', 'branch.feature.gerritserver'],),
2180 'https://chromium-review.googlesource.com'),
phajdan.jre328cf92016-08-22 04:12:17 -07002181 (('write_json', 'output.json',
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002182 {'issue': 123,
2183 'issue_url': 'https://chromium-review.googlesource.com/123'}),
phajdan.jre328cf92016-08-22 04:12:17 -07002184 ''),
2185 ]
2186 self.assertEqual(0, git_cl.main(['issue', '--json', 'output.json']))
2187
tandrii8c5a3532016-11-04 07:52:02 -07002188 def test_git_cl_try_default_cq_dry_run_gerrit(self):
2189 self.mock(git_cl.Changelist, 'GetChange',
2190 lambda _, *a: (
2191 self._mocked_call(['GetChange']+list(a))))
2192 self.mock(git_cl.presubmit_support, 'DoGetTryMasters',
2193 lambda *_, **__: (
2194 self._mocked_call(['DoGetTryMasters'])))
2195 self.mock(git_cl._GerritChangelistImpl, 'SetCQState',
2196 lambda _, s: self._mocked_call(['SetCQState', s]))
2197
tandrii8c5a3532016-11-04 07:52:02 -07002198 self.calls = [
2199 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii8c5a3532016-11-04 07:52:02 -07002200 ((['git', 'config', 'branch.feature.gerritissue'],), '123456'),
2201 ((['git', 'config', 'branch.feature.gerritserver'],),
2202 'https://chromium-review.googlesource.com'),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002203 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2204 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2205 ((['git', 'config', 'remote.origin.url'],),
2206 'https://chromium.googlesource.com/depot_tools'),
2207 (('GetChangeDetail', 'chromium-review.googlesource.com',
2208 'depot_tools~123456',
Andrii Shyshkaloveadad922017-01-26 09:38:30 +01002209 ['DETAILED_ACCOUNTS', 'ALL_REVISIONS', 'CURRENT_COMMIT']), {
2210 'project': 'depot_tools',
2211 'status': 'OPEN',
2212 'owner': {'email': 'owner@e.mail'},
2213 'revisions': {
2214 'deadbeaf': {
2215 '_number': 6,
2216 },
2217 'beeeeeef': {
2218 '_number': 7,
2219 'fetch': {'http': {
2220 'url': 'https://chromium.googlesource.com/depot_tools',
2221 'ref': 'refs/changes/56/123456/7'
2222 }},
2223 },
2224 },
2225 }),
tandrii8c5a3532016-11-04 07:52:02 -07002226 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2227 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2228 ((['get_or_create_merge_base', 'feature', 'feature'],),
2229 'fake_ancestor_sha'),
2230 ((['GetChange', 'fake_ancestor_sha', None], ),
2231 git_cl.presubmit_support.GitChange(
2232 '', '', '', '', '', '', '', '')),
2233 ((['git', 'rev-parse', '--show-cdup'],), '../'),
2234 ((['DoGetTryMasters'], ), None),
2235 ((['SetCQState', git_cl._CQState.DRY_RUN], ), None),
2236 ]
2237 out = StringIO.StringIO()
2238 self.mock(git_cl.sys, 'stdout', out)
2239 self.assertEqual(0, git_cl.main(['try']))
2240 self.assertEqual(
2241 out.getvalue(),
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07002242 'Scheduling CQ dry run on: '
tandrii8c5a3532016-11-04 07:52:02 -07002243 'https://chromium-review.googlesource.com/123456\n')
2244
tandrii8c5a3532016-11-04 07:52:02 -07002245 def test_git_cl_try_buildbucket_with_properties_gerrit(self):
2246 self.mock(git_cl.Changelist, 'GetMostRecentPatchset', lambda _: 7)
2247 self.mock(git_cl.uuid, 'uuid4', lambda: 'uuid4')
2248
tandrii8c5a3532016-11-04 07:52:02 -07002249 self.calls = [
2250 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii8c5a3532016-11-04 07:52:02 -07002251 ((['git', 'config', 'branch.feature.gerritissue'],), '123456'),
2252 ((['git', 'config', 'branch.feature.gerritserver'],),
2253 'https://chromium-review.googlesource.com'),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002254 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2255 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2256 ((['git', 'config', 'remote.origin.url'],),
2257 'https://chromium.googlesource.com/depot_tools'),
2258 (('GetChangeDetail', 'chromium-review.googlesource.com',
2259 'depot_tools~123456',
Andrii Shyshkaloveadad922017-01-26 09:38:30 +01002260 ['DETAILED_ACCOUNTS', 'ALL_REVISIONS', 'CURRENT_COMMIT']), {
tandrii8c5a3532016-11-04 07:52:02 -07002261 'project': 'depot_tools',
Andrii Shyshkaloveadad922017-01-26 09:38:30 +01002262 'status': 'OPEN',
2263 'owner': {'email': 'owner@e.mail'},
tandrii8c5a3532016-11-04 07:52:02 -07002264 'revisions': {
2265 'deadbeaf': {
2266 '_number': 6,
2267 },
2268 'beeeeeef': {
2269 '_number': 7,
2270 'fetch': {'http': {
2271 'url': 'https://chromium.googlesource.com/depot_tools',
2272 'ref': 'refs/changes/56/123456/7'
2273 }},
2274 },
2275 },
2276 }),
2277 ]
2278
2279 def _buildbucket_retry(*_, **kw):
2280 # self.maxDiff = 10000
2281 body = json.loads(kw['body'])
2282 self.assertEqual(len(body['builds']), 1)
2283 build = body['builds'][0]
2284 params = json.loads(build.pop('parameters_json'))
2285 self.assertEqual(params, {
2286 u'builder_name': u'win',
2287 u'changes': [{u'author': {u'email': u'owner@e.mail'},
2288 u'revision': None}],
2289 u'properties': {
2290 u'category': u'git_cl_try',
2291 u'key': u'val',
2292 u'json': [{u'a': 1}, None],
tandrii8c5a3532016-11-04 07:52:02 -07002293
2294 u'patch_gerrit_url':
2295 u'https://chromium-review.googlesource.com',
2296 u'patch_issue': 123456,
2297 u'patch_project': u'depot_tools',
2298 u'patch_ref': u'refs/changes/56/123456/7',
2299 u'patch_repository_url':
2300 u'https://chromium.googlesource.com/depot_tools',
2301 u'patch_set': 7,
2302 u'patch_storage': u'gerrit',
2303 }
2304 })
2305 self.assertEqual(build, {
Andrii Shyshkalov03da1502018-10-15 03:42:34 +00002306 u'bucket': u'luci.chromium.try',
tandrii8c5a3532016-11-04 07:52:02 -07002307 u'client_operation_id': u'uuid4',
2308 u'tags': [
2309 u'builder:win',
2310 u'buildset:patch/gerrit/chromium-review.googlesource.com/123456/7',
2311 u'user_agent:git_cl_try',
Andrii Shyshkalov03da1502018-10-15 03:42:34 +00002312 ],
tandrii8c5a3532016-11-04 07:52:02 -07002313 })
2314
2315 self.mock(git_cl, '_buildbucket_retry', _buildbucket_retry)
2316
2317 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2318 self.assertEqual(0, git_cl.main([
Andrii Shyshkalov03da1502018-10-15 03:42:34 +00002319 'try', '-B', 'luci.chromium.try', '-b', 'win',
tandrii8c5a3532016-11-04 07:52:02 -07002320 '-p', 'key=val', '-p', 'json=[{"a":1}, null]']))
2321 self.assertRegexpMatches(
2322 git_cl.sys.stdout.getvalue(),
Andrii Shyshkalov03da1502018-10-15 03:42:34 +00002323 'Tried jobs on:\nBucket: luci.chromium.try')
tandriide281ae2016-10-12 06:02:30 -07002324
qyearsley123a4682016-10-26 09:12:17 -07002325 def test_git_cl_try_bots_on_multiple_masters(self):
Andrii Shyshkalovf5569d22018-10-15 03:35:23 +00002326 self.mock(git_cl.Changelist, 'GetMostRecentPatchset', lambda _: 7)
2327 self.mock(git_cl.Changelist, 'GetChange',
2328 lambda _, *a: (
2329 self._mocked_call(['GetChange']+list(a))))
2330 self.mock(git_cl.presubmit_support, 'DoGetTryMasters',
2331 lambda *_, **__: (
2332 self._mocked_call(['DoGetTryMasters'])))
2333 self.mock(git_cl._GerritChangelistImpl, 'SetCQState',
2334 lambda _, s: self._mocked_call(['SetCQState', s]))
2335
qyearsley123a4682016-10-26 09:12:17 -07002336 self.calls = [
2337 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
Andrii Shyshkalovf5569d22018-10-15 03:35:23 +00002338 ((['git', 'config', 'branch.feature.gerritissue'],), '123456'),
2339 ((['git', 'config', 'branch.feature.gerritserver'],),
2340 'https://chromium-review.googlesource.com'),
2341 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2342 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2343 ((['git', 'config', 'remote.origin.url'],),
2344 'https://chromium.googlesource.com/depot_tools'),
2345 (('GetChangeDetail', 'chromium-review.googlesource.com',
2346 'depot_tools~123456',
2347 ['DETAILED_ACCOUNTS', 'ALL_REVISIONS', 'CURRENT_COMMIT']), {
2348 'project': 'depot_tools',
2349 'status': 'OPEN',
2350 'owner': {'email': 'owner@e.mail'},
2351 'revisions': {
2352 'deadbeaf': {
2353 '_number': 6,
2354 },
2355 'beeeeeef': {
2356 '_number': 7,
2357 'fetch': {'http': {
2358 'url': 'https://chromium.googlesource.com/depot_tools',
2359 'ref': 'refs/changes/56/123456/7'
2360 }},
2361 },
2362 },
2363 }),
qyearsley123a4682016-10-26 09:12:17 -07002364 ]
2365
2366 def _buildbucket_retry(*_, **kw):
2367 body = json.loads(kw['body'])
2368 self.assertEqual(len(body['builds']), 2)
2369
Nodir Turakulovb422e682018-02-20 22:51:30 -08002370 self.assertEqual(body['builds'][0]['bucket'], 'bucket1')
2371 params = json.loads(body['builds'][0]['parameters_json'])
2372 self.assertEqual(params['builder_name'], 'builder1')
qyearsley123a4682016-10-26 09:12:17 -07002373
Nodir Turakulovb422e682018-02-20 22:51:30 -08002374 self.assertEqual(body['builds'][1]['bucket'], 'bucket2')
2375 params = json.loads(body['builds'][1]['parameters_json'])
2376 self.assertEqual(params['builder_name'], 'builder2')
qyearsley123a4682016-10-26 09:12:17 -07002377
2378 self.mock(git_cl, '_buildbucket_retry', _buildbucket_retry)
2379
2380 self.mock(git_cl.urllib2, 'urlopen', lambda _: StringIO.StringIO(
Nodir Turakulovb422e682018-02-20 22:51:30 -08002381 json.dumps({
2382 'builder1': {'bucket': 'bucket1'},
2383 'builder2': {'bucket': 'bucket2'},
2384 })))
qyearsley123a4682016-10-26 09:12:17 -07002385
2386 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2387 self.assertEqual(
2388 0, git_cl.main(['try', '-b', 'builder1', '-b', 'builder2']))
2389 self.assertEqual(
2390 git_cl.sys.stdout.getvalue(),
2391 'Tried jobs on:\n'
Nodir Turakulovb422e682018-02-20 22:51:30 -08002392 'Bucket: bucket1\n'
qyearsley123a4682016-10-26 09:12:17 -07002393 ' builder1: []\n'
Nodir Turakulovb422e682018-02-20 22:51:30 -08002394 'Bucket: bucket2\n'
qyearsley123a4682016-10-26 09:12:17 -07002395 ' builder2: []\n'
2396 'To see results here, run: git cl try-results\n'
2397 'To see results in browser, run: git cl web\n')
2398
tandrii16e0b4e2016-06-07 10:34:28 -07002399 def _common_GerritCommitMsgHookCheck(self):
2400 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2401 self.mock(git_cl.os.path, 'abspath',
2402 lambda path: self._mocked_call(['abspath', path]))
2403 self.mock(git_cl.os.path, 'exists',
2404 lambda path: self._mocked_call(['exists', path]))
2405 self.mock(git_cl.gclient_utils, 'FileRead',
2406 lambda path: self._mocked_call(['FileRead', path]))
2407 self.mock(git_cl.gclient_utils, 'rm_file_or_tree',
2408 lambda path: self._mocked_call(['rm_file_or_tree', path]))
2409 self.calls = [
2410 ((['git', 'rev-parse', '--show-cdup'],), '../'),
2411 ((['abspath', '../'],), '/abs/git_repo_root'),
2412 ]
2413 return git_cl.Changelist(codereview='gerrit', issue=123)
2414
2415 def test_GerritCommitMsgHookCheck_custom_hook(self):
2416 cl = self._common_GerritCommitMsgHookCheck()
2417 self.calls += [
2418 ((['exists', '/abs/git_repo_root/.git/hooks/commit-msg'],), True),
2419 ((['FileRead', '/abs/git_repo_root/.git/hooks/commit-msg'],),
2420 '#!/bin/sh\necho "custom hook"')
2421 ]
2422 cl._codereview_impl._GerritCommitMsgHookCheck(offer_removal=True)
2423
2424 def test_GerritCommitMsgHookCheck_not_exists(self):
2425 cl = self._common_GerritCommitMsgHookCheck()
2426 self.calls += [
2427 ((['exists', '/abs/git_repo_root/.git/hooks/commit-msg'],), False),
2428 ]
2429 cl._codereview_impl._GerritCommitMsgHookCheck(offer_removal=True)
2430
2431 def test_GerritCommitMsgHookCheck(self):
2432 cl = self._common_GerritCommitMsgHookCheck()
2433 self.calls += [
2434 ((['exists', '/abs/git_repo_root/.git/hooks/commit-msg'],), True),
2435 ((['FileRead', '/abs/git_repo_root/.git/hooks/commit-msg'],),
2436 '...\n# From Gerrit Code Review\n...\nadd_ChangeId()\n'),
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002437 (('ask_for_data', 'Do you want to remove it now? [Yes/No]: '), 'Yes'),
tandrii16e0b4e2016-06-07 10:34:28 -07002438 ((['rm_file_or_tree', '/abs/git_repo_root/.git/hooks/commit-msg'],),
2439 ''),
2440 ]
2441 cl._codereview_impl._GerritCommitMsgHookCheck(offer_removal=True)
2442
tandriic4344b52016-08-29 06:04:54 -07002443 def test_GerritCmdLand(self):
2444 self.calls += [
2445 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2446 ((['git', 'config', 'branch.feature.gerritsquashhash'],),
2447 'deadbeaf'),
2448 ((['git', 'diff', 'deadbeaf'],), ''), # No diff.
2449 ((['git', 'config', 'branch.feature.gerritserver'],),
2450 'chromium-review.googlesource.com'),
2451 ]
2452 cl = git_cl.Changelist(issue=123, codereview='gerrit')
2453 cl._codereview_impl._GetChangeDetail = lambda _: {
2454 'labels': {},
2455 'current_revision': 'deadbeaf',
2456 }
agable32978d92016-11-01 12:55:02 -07002457 cl._codereview_impl._GetChangeCommit = lambda: {
2458 'commit': 'deadbeef',
Aaron Gable02cdbb42016-12-13 16:24:25 -08002459 'web_links': [{'name': 'gitiles',
agable32978d92016-11-01 12:55:02 -07002460 'url': 'https://git.googlesource.com/test/+/deadbeef'}],
2461 }
tandriic4344b52016-08-29 06:04:54 -07002462 cl._codereview_impl.SubmitIssue = lambda wait_for_merge: None
tandrii8da412c2016-09-07 16:01:07 -07002463 out = StringIO.StringIO()
2464 self.mock(sys, 'stdout', out)
Olivier Robin75ee7252018-04-13 10:02:56 +02002465 self.assertEqual(0, cl.CMDLand(force=True,
2466 bypass_hooks=True,
2467 verbose=True,
2468 parallel=False))
tandrii8da412c2016-09-07 16:01:07 -07002469 self.assertRegexpMatches(out.getvalue(), 'Issue.*123 has been submitted')
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002470 self.assertRegexpMatches(out.getvalue(), 'Landed as: .*deadbeef')
tandriic4344b52016-08-29 06:04:54 -07002471
tandrii221ab252016-10-06 08:12:04 -07002472 BUILDBUCKET_BUILDS_MAP = {
Quinten Yearsleya563d722017-12-11 16:36:54 -08002473 '9000': {
2474 'id': '9000',
2475 'bucket': 'master.x.y',
2476 'created_by': 'user:someone@chromium.org',
2477 'created_ts': '147200002222000',
2478 'experimental': False,
2479 'parameters_json': json.dumps({
2480 'builder_name': 'my-bot',
2481 'properties': {'category': 'cq'},
2482 }),
2483 'status': 'STARTED',
2484 'tags': [
2485 'build_address:x.y/my-bot/2',
2486 'builder:my-bot',
2487 'experimental:false',
2488 'user_agent:cq',
2489 ],
2490 'url': 'http://build.cr.org/p/x.y/builders/my-bot/builds/2',
2491 },
2492 '8000': {
2493 'id': '8000',
2494 'bucket': 'master.x.y',
2495 'created_by': 'user:someone@chromium.org',
2496 'created_ts': '147200001111000',
2497 'experimental': False,
2498 'failure_reason': 'BUILD_FAILURE',
2499 'parameters_json': json.dumps({
2500 'builder_name': 'my-bot',
2501 'properties': {'category': 'cq'},
2502 }),
2503 'result_details_json': json.dumps({
2504 'properties': {'buildnumber': 1},
2505 }),
2506 'result': 'FAILURE',
2507 'status': 'COMPLETED',
2508 'tags': [
2509 'build_address:x.y/my-bot/1',
2510 'builder:my-bot',
2511 'experimental:false',
2512 'user_agent:cq',
2513 ],
2514 'url': 'http://build.cr.org/p/x.y/builders/my-bot/builds/1',
2515 },
2516 }
tandrii221ab252016-10-06 08:12:04 -07002517
2518 def test_write_try_results_json(self):
2519 expected_output = [
Quinten Yearsleya563d722017-12-11 16:36:54 -08002520 {
2521 'bucket': 'master.x.y',
2522 'buildbucket_id': '8000',
2523 'builder_name': 'my-bot',
2524 'created_ts': '147200001111000',
2525 'experimental': False,
2526 'failure_reason': 'BUILD_FAILURE',
2527 'result': 'FAILURE',
2528 'status': 'COMPLETED',
2529 'tags': [
2530 'build_address:x.y/my-bot/1',
2531 'builder:my-bot',
2532 'experimental:false',
2533 'user_agent:cq',
2534 ],
2535 'url': 'http://build.cr.org/p/x.y/builders/my-bot/builds/1',
2536 },
2537 {
2538 'bucket': 'master.x.y',
2539 'buildbucket_id': '9000',
2540 'builder_name': 'my-bot',
2541 'created_ts': '147200002222000',
2542 'experimental': False,
2543 'failure_reason': None,
2544 'result': None,
2545 'status': 'STARTED',
2546 'tags': [
2547 'build_address:x.y/my-bot/2',
2548 'builder:my-bot',
2549 'experimental:false',
2550 'user_agent:cq',
2551 ],
2552 'url': 'http://build.cr.org/p/x.y/builders/my-bot/builds/2',
2553 },
tandrii221ab252016-10-06 08:12:04 -07002554 ]
2555 self.calls = [(('write_json', 'output.json', expected_output), '')]
2556 git_cl.write_try_results_json('output.json', self.BUILDBUCKET_BUILDS_MAP)
2557
tandrii45b2a582016-10-11 03:14:16 -07002558 def _setup_fetch_try_jobs(self, most_recent_patchset=20001):
tandrii221ab252016-10-06 08:12:04 -07002559 out = StringIO.StringIO()
2560 self.mock(sys, 'stdout', out)
tandrii45b2a582016-10-11 03:14:16 -07002561 self.mock(git_cl.Changelist, 'GetMostRecentPatchset',
2562 lambda *args: most_recent_patchset)
tandrii221ab252016-10-06 08:12:04 -07002563 self.mock(git_cl.auth, 'get_authenticator_for_host', lambda host, _cfg:
2564 self._mocked_call(['get_authenticator_for_host', host]))
2565 self.mock(git_cl, '_buildbucket_retry', lambda *_, **__:
2566 self._mocked_call(['_buildbucket_retry']))
tandrii45b2a582016-10-11 03:14:16 -07002567
tandrii45b2a582016-10-11 03:14:16 -07002568 def _setup_fetch_try_jobs_gerrit(self, *request_results):
2569 self._setup_fetch_try_jobs(most_recent_patchset=13)
2570 self.calls += [
2571 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii45b2a582016-10-11 03:14:16 -07002572 ((['git', 'config', 'branch.feature.gerritissue'],), '1'),
Ravi Mistryfda50ca2016-11-14 10:19:18 -05002573 # TODO(tandrii): Uncomment the below if we decide to support checking
2574 # patchsets for Gerrit.
tandrii45b2a582016-10-11 03:14:16 -07002575 # Simulate that Gerrit has more patchsets than local.
Ravi Mistryfda50ca2016-11-14 10:19:18 -05002576 # ((['git', 'config', 'branch.feature.gerritpatchset'],), '12'),
tandrii45b2a582016-10-11 03:14:16 -07002577 ((['git', 'config', 'branch.feature.gerritserver'],),
2578 'https://x-review.googlesource.com'),
2579 ((['get_authenticator_for_host', 'x-review.googlesource.com'],),
2580 AuthenticatorMock()),
2581 ] + [((['_buildbucket_retry'],), r) for r in request_results]
2582
2583 def test_fetch_try_jobs_none_gerrit(self):
2584 self._setup_fetch_try_jobs_gerrit({})
2585 self.assertEqual(0, git_cl.main(['try-results']))
Ravi Mistryfda50ca2016-11-14 10:19:18 -05002586 # TODO(tandrii): Uncomment the below if we decide to support checking
2587 # patchsets for Gerrit.
2588 # self.assertRegexpMatches(
2589 # sys.stdout.getvalue(),
2590 # r'Warning: Codereview server has newer patchsets \(13\)')
tandrii45b2a582016-10-11 03:14:16 -07002591 self.assertRegexpMatches(sys.stdout.getvalue(), 'No try jobs')
2592
2593 def test_fetch_try_jobs_some_gerrit(self):
2594 self._setup_fetch_try_jobs_gerrit({
2595 'builds': self.BUILDBUCKET_BUILDS_MAP.values(),
2596 })
Ravi Mistryfda50ca2016-11-14 10:19:18 -05002597 # TODO(tandrii): Uncomment the below if we decide to support checking
2598 # patchsets for Gerrit.
2599 # self.calls.remove(
2600 # ((['git', 'config', 'branch.feature.gerritpatchset'],), '12'))
tandrii45b2a582016-10-11 03:14:16 -07002601 self.assertEqual(0, git_cl.main(['try-results', '--patchset', '5']))
2602
2603 # ... and doesn't result in warning.
2604 self.assertNotRegexpMatches(sys.stdout.getvalue(), 'Warning')
2605 self.assertRegexpMatches(sys.stdout.getvalue(), '^Failures:')
tandrii221ab252016-10-06 08:12:04 -07002606 self.assertRegexpMatches(sys.stdout.getvalue(), 'Started:')
2607 self.assertRegexpMatches(sys.stdout.getvalue(), '2 try jobs')
2608
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002609 def _mock_gerrit_changes_for_detail_cache(self):
2610 self.mock(git_cl._GerritChangelistImpl, '_GetGerritHost', lambda _: 'host')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002611
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002612 def test_gerrit_change_detail_cache_simple(self):
2613 self._mock_gerrit_changes_for_detail_cache()
2614 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002615 (('GetChangeDetail', 'host', 'my%2Frepo~1', []), 'a'),
2616 (('GetChangeDetail', 'host', 'ab%2Frepo~2', []), 'b'),
2617 (('GetChangeDetail', 'host', 'ab%2Frepo~2', []), 'b2'),
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002618 ]
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00002619 cl1 = git_cl.Changelist(issue=1, codereview='gerrit')
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002620 cl1._cached_remote_url = (
2621 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00002622 cl2 = git_cl.Changelist(issue=2, codereview='gerrit')
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002623 cl2._cached_remote_url = (
2624 True, 'https://chromium.googlesource.com/ab/repo')
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00002625 self.assertEqual(cl1._GetChangeDetail(), 'a') # Miss.
2626 self.assertEqual(cl1._GetChangeDetail(), 'a')
2627 self.assertEqual(cl2._GetChangeDetail(), 'b') # Miss.
2628 self.assertEqual(cl2._GetChangeDetail(no_cache=True), 'b2') # Miss.
2629 self.assertEqual(cl1._GetChangeDetail(), 'a')
2630 self.assertEqual(cl2._GetChangeDetail(), 'b2')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002631
2632 def test_gerrit_change_detail_cache_options(self):
2633 self._mock_gerrit_changes_for_detail_cache()
2634 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002635 (('GetChangeDetail', 'host', 'repo~1', ['C', 'A', 'B']), 'cab'),
2636 (('GetChangeDetail', 'host', 'repo~1', ['A', 'D']), 'ad'),
2637 (('GetChangeDetail', 'host', 'repo~1', ['A']), 'a'), # no_cache=True
2638 # no longer in cache.
2639 (('GetChangeDetail', 'host', 'repo~1', ['B']), 'b'),
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002640 ]
2641 cl = git_cl.Changelist(issue=1, codereview='gerrit')
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002642 cl._cached_remote_url = (True, 'https://chromium.googlesource.com/repo/')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002643 self.assertEqual(cl._GetChangeDetail(options=['C', 'A', 'B']), 'cab')
2644 self.assertEqual(cl._GetChangeDetail(options=['A', 'B', 'C']), 'cab')
2645 self.assertEqual(cl._GetChangeDetail(options=['B', 'A']), 'cab')
2646 self.assertEqual(cl._GetChangeDetail(options=['C']), 'cab')
2647 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2648 self.assertEqual(cl._GetChangeDetail(), 'cab')
2649
2650 self.assertEqual(cl._GetChangeDetail(options=['A', 'D']), 'ad')
2651 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2652 self.assertEqual(cl._GetChangeDetail(options=['D']), 'ad')
2653 self.assertEqual(cl._GetChangeDetail(), 'cab')
2654
2655 # Finally, no_cache should invalidate all caches for given change.
2656 self.assertEqual(cl._GetChangeDetail(options=['A'], no_cache=True), 'a')
2657 self.assertEqual(cl._GetChangeDetail(options=['B']), 'b')
2658
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002659 def test_gerrit_description_caching(self):
2660 def gen_detail(rev, desc):
2661 return {
2662 'current_revision': rev,
2663 'revisions': {rev: {'commit': {'message': desc}}}
2664 }
2665 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002666 (('GetChangeDetail', 'host', 'my%2Frepo~1',
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002667 ['CURRENT_REVISION', 'CURRENT_COMMIT']),
2668 gen_detail('rev1', 'desc1')),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002669 (('GetChangeDetail', 'host', 'my%2Frepo~1',
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002670 ['CURRENT_REVISION', 'CURRENT_COMMIT']),
2671 gen_detail('rev2', 'desc2')),
2672 ]
2673
2674 self._mock_gerrit_changes_for_detail_cache()
2675 cl = git_cl.Changelist(issue=1, codereview='gerrit')
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002676 cl._cached_remote_url = (
2677 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002678 self.assertEqual(cl.GetDescription(), 'desc1')
2679 self.assertEqual(cl.GetDescription(), 'desc1') # cache hit.
2680 self.assertEqual(cl.GetDescription(force=True), 'desc2')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002681
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002682 def test_print_current_creds(self):
2683 class CookiesAuthenticatorMock(object):
2684 def __init__(self):
2685 self.gitcookies = {
2686 'host.googlesource.com': ('user', 'pass'),
2687 'host-review.googlesource.com': ('user', 'pass'),
2688 }
2689 self.netrc = self
2690 self.netrc.hosts = {
2691 'github.com': ('user2', None, 'pass2'),
2692 'host2.googlesource.com': ('user3', None, 'pass'),
2693 }
2694 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
2695 CookiesAuthenticatorMock)
2696 self.mock(sys, 'stdout', StringIO.StringIO())
2697 git_cl._GitCookiesChecker().print_current_creds(include_netrc=True)
2698 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2699 ' Host\t User\t Which file',
2700 '============================\t=====\t===========',
2701 'host-review.googlesource.com\t user\t.gitcookies',
2702 ' host.googlesource.com\t user\t.gitcookies',
2703 ' host2.googlesource.com\tuser3\t .netrc',
2704 ])
2705 sys.stdout.buf = ''
2706 git_cl._GitCookiesChecker().print_current_creds(include_netrc=False)
2707 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2708 ' Host\tUser\t Which file',
2709 '============================\t====\t===========',
2710 'host-review.googlesource.com\tuser\t.gitcookies',
2711 ' host.googlesource.com\tuser\t.gitcookies',
2712 ])
2713
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002714 def _common_creds_check_mocks(self):
2715 def exists_mock(path):
2716 dirname = os.path.dirname(path)
2717 if dirname == os.path.expanduser('~'):
2718 dirname = '~'
2719 base = os.path.basename(path)
2720 if base in ('.netrc', '.gitcookies'):
2721 return self._mocked_call('os.path.exists', '%s/%s' % (dirname, base))
2722 # git cl also checks for existence other files not relevant to this test.
2723 return None
2724 self.mock(os.path, 'exists', exists_mock)
2725 self.mock(sys, 'stdout', StringIO.StringIO())
2726
2727 def test_creds_check_gitcookies_not_configured(self):
2728 self._common_creds_check_mocks()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002729 self.mock(git_cl._GitCookiesChecker, 'get_hosts_with_creds',
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01002730 lambda _, include_netrc=False: [])
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002731 self.calls = [
Aaron Gable8797cab2018-03-06 13:55:00 -08002732 ((['git', 'config', '--path', 'http.cookiefile'],), CERR1),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002733 ((['git', 'config', '--global', 'http.cookiefile'],), CERR1),
2734 (('os.path.exists', '~/.netrc'), True),
2735 (('ask_for_data', 'Press Enter to setup .gitcookies, '
2736 'or Ctrl+C to abort'), ''),
2737 ((['git', 'config', '--global', 'http.cookiefile',
2738 os.path.expanduser('~/.gitcookies')], ), ''),
2739 ]
2740 self.assertEqual(0, git_cl.main(['creds-check']))
2741 self.assertRegexpMatches(
2742 sys.stdout.getvalue(),
2743 '^You seem to be using outdated .netrc for git credentials:')
2744 self.assertRegexpMatches(
2745 sys.stdout.getvalue(),
2746 '\nConfigured git to use .gitcookies from')
2747
2748 def test_creds_check_gitcookies_configured_custom_broken(self):
2749 self._common_creds_check_mocks()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002750 self.mock(git_cl._GitCookiesChecker, 'get_hosts_with_creds',
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01002751 lambda _, include_netrc=False: [])
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002752 self.calls = [
Aaron Gable8797cab2018-03-06 13:55:00 -08002753 ((['git', 'config', '--path', 'http.cookiefile'],), CERR1),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002754 ((['git', 'config', '--global', 'http.cookiefile'],),
2755 '/custom/.gitcookies'),
2756 (('os.path.exists', '/custom/.gitcookies'), False),
2757 (('ask_for_data', 'Reconfigure git to use default .gitcookies? '
2758 'Press Enter to reconfigure, or Ctrl+C to abort'), ''),
2759 ((['git', 'config', '--global', 'http.cookiefile',
2760 os.path.expanduser('~/.gitcookies')], ), ''),
2761 ]
2762 self.assertEqual(0, git_cl.main(['creds-check']))
2763 self.assertRegexpMatches(
2764 sys.stdout.getvalue(),
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002765 'WARNING: You have configured custom path to .gitcookies: ')
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002766 self.assertRegexpMatches(
2767 sys.stdout.getvalue(),
2768 'However, your configured .gitcookies file is missing.')
2769
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002770 def test_git_cl_comment_add_gerrit(self):
2771 self.mock(git_cl.gerrit_util, 'SetReview',
Aaron Gable636b13f2017-07-14 10:42:48 -07002772 lambda host, change, msg, ready:
2773 self._mocked_call('SetReview', host, change, msg, ready))
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002774 self.calls = [
2775 ((['git', 'symbolic-ref', 'HEAD'],), CERR1),
2776 ((['git', 'symbolic-ref', 'HEAD'],), CERR1),
2777 ((['git', 'config', 'rietveld.upstream-branch'],), CERR1),
2778 ((['git', 'branch', '-r'],), 'origin/HEAD -> origin/master\n'
2779 'origin/master'),
2780 ((['git', 'config', 'remote.origin.url'],),
2781 'https://chromium.googlesource.com/infra/infra'),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002782 (('SetReview', 'chromium-review.googlesource.com', 'infra%2Finfra~10',
2783 'msg', None),
Aaron Gable636b13f2017-07-14 10:42:48 -07002784 None),
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002785 ]
2786 self.assertEqual(0, git_cl.main(['comment', '--gerrit', '-i', '10',
2787 '-a', 'msg']))
2788
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002789 def test_git_cl_comments_fetch_gerrit(self):
2790 self.mock(sys, 'stdout', StringIO.StringIO())
2791 self.calls = [
2792 ((['git', 'symbolic-ref', 'HEAD'],), CERR1),
2793 ((['git', 'symbolic-ref', 'HEAD'],), CERR1),
2794 ((['git', 'config', 'rietveld.upstream-branch'],), CERR1),
2795 ((['git', 'branch', '-r'],), 'origin/HEAD -> origin/master\n'
2796 'origin/master'),
2797 ((['git', 'config', 'remote.origin.url'],),
2798 'https://chromium.googlesource.com/infra/infra'),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002799 (('GetChangeDetail', 'chromium-review.googlesource.com',
2800 'infra%2Finfra~1',
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002801 ['MESSAGES', 'DETAILED_ACCOUNTS']), {
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002802 'owner': {'email': 'owner@example.com'},
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002803 'messages': [
2804 {
2805 u'_revision_number': 1,
2806 u'author': {
2807 u'_account_id': 1111084,
2808 u'email': u'commit-bot@chromium.org',
2809 u'name': u'Commit Bot'
2810 },
2811 u'date': u'2017-03-15 20:08:45.000000000',
2812 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
Dirk Prankef6a58802017-10-17 12:49:42 -07002813 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002814 u'tag': u'autogenerated:cq:dry-run'
2815 },
2816 {
2817 u'_revision_number': 2,
2818 u'author': {
2819 u'_account_id': 11151243,
2820 u'email': u'owner@example.com',
2821 u'name': u'owner'
2822 },
2823 u'date': u'2017-03-16 20:00:41.000000000',
2824 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2825 u'message': u'PTAL',
2826 },
2827 {
2828 u'_revision_number': 2,
2829 u'author': {
2830 u'_account_id': 148512 ,
2831 u'email': u'reviewer@example.com',
2832 u'name': u'reviewer'
2833 },
2834 u'date': u'2017-03-17 05:19:37.500000000',
2835 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
2836 u'message': u'Patch Set 2: Code-Review+1',
2837 },
2838 ]
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002839 }),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002840 (('GetChangeComments', 'chromium-review.googlesource.com',
2841 'infra%2Finfra~1'), {
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002842 '/COMMIT_MSG': [
2843 {
2844 'author': {'email': u'reviewer@example.com'},
2845 'updated': u'2017-03-17 05:19:37.500000000',
2846 'patch_set': 2,
2847 'side': 'REVISION',
2848 'message': 'Please include a bug link',
2849 },
2850 ],
2851 'codereview.settings': [
2852 {
2853 'author': {'email': u'owner@example.com'},
2854 'updated': u'2017-03-16 20:00:41.000000000',
2855 'patch_set': 2,
2856 'side': 'PARENT',
2857 'line': 42,
2858 'message': 'I removed this because it is bad',
2859 },
2860 ]
Leszek Swirski45b20c42018-09-17 17:05:26 +00002861 })
2862 ] * 2 + [
2863 (('write_json', 'output.json', [
2864 {
2865 u'date': u'2017-03-16 20:00:41.000000',
2866 u'message': (
2867 u'PTAL\n' +
2868 u'\n' +
2869 u'codereview.settings\n' +
2870 u' Base, Line 42: https://chromium-review.googlesource.com/' +
2871 u'c/1/2/codereview.settings#b42\n' +
2872 u' I removed this because it is bad\n'),
2873 u'approval': False,
2874 u'disapproval': False,
2875 u'sender': u'owner@example.com'
2876 }, {
2877 u'date': u'2017-03-17 05:19:37.500000',
2878 u'message': (
2879 u'Patch Set 2: Code-Review+1\n' +
2880 u'\n' +
2881 u'/COMMIT_MSG\n' +
2882 u' PS2, File comment: https://chromium-review.googlesource' +
2883 u'.com/c/1/2//COMMIT_MSG#\n' +
2884 u' Please include a bug link\n'),
2885 u'approval': False,
2886 u'disapproval': False,
2887 u'sender': u'reviewer@example.com'
2888 }
2889 ]),'')
2890 ]
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002891 expected_comments_summary = [
2892 git_cl._CommentSummary(
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002893 message=(
2894 u'PTAL\n' +
2895 u'\n' +
2896 u'codereview.settings\n' +
2897 u' Base, Line 42: https://chromium-review.googlesource.com/' +
2898 u'c/1/2/codereview.settings#b42\n' +
2899 u' I removed this because it is bad\n'),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002900 date=datetime.datetime(2017, 3, 16, 20, 0, 41, 0),
2901 disapproval=False, approval=False, sender=u'owner@example.com'),
2902 git_cl._CommentSummary(
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002903 message=(
2904 u'Patch Set 2: Code-Review+1\n' +
2905 u'\n' +
2906 u'/COMMIT_MSG\n' +
2907 u' PS2, File comment: https://chromium-review.googlesource.com/' +
2908 u'c/1/2//COMMIT_MSG#\n' +
2909 u' Please include a bug link\n'),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002910 date=datetime.datetime(2017, 3, 17, 5, 19, 37, 500000),
2911 disapproval=False, approval=False, sender=u'reviewer@example.com'),
2912 ]
2913 cl = git_cl.Changelist(codereview='gerrit', issue=1)
2914 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Andrii Shyshkalov642641d2018-10-16 05:54:41 +00002915 self.assertEqual(0, git_cl.main(['comment', '-i', '1',
Leszek Swirski45b20c42018-09-17 17:05:26 +00002916 '-j', 'output.json']))
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002917
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002918 def test_get_remote_url_with_mirror(self):
2919 original_os_path_isdir = os.path.isdir
2920 def selective_os_path_isdir_mock(path):
2921 if path == '/cache/this-dir-exists':
2922 return self._mocked_call('os.path.isdir', path)
2923 return original_os_path_isdir(path)
2924 self.mock(os.path, 'isdir', selective_os_path_isdir_mock)
2925
2926 url = 'https://chromium.googlesource.com/my/repo'
2927 self.calls = [
2928 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2929 ((['git', 'config', 'branch.master.merge'],), 'master'),
2930 ((['git', 'config', 'branch.master.remote'],), 'origin'),
2931 ((['git', 'config', 'remote.origin.url'],),
2932 '/cache/this-dir-exists'),
2933 (('os.path.isdir', '/cache/this-dir-exists'),
2934 True),
2935 # Runs in /cache/this-dir-exists.
2936 ((['git', 'config', 'remote.origin.url'],),
2937 url),
2938 ]
2939 cl = git_cl.Changelist(codereview='gerrit', issue=1)
2940 self.assertEqual(cl.GetRemoteUrl(), url)
2941 self.assertEqual(cl.GetRemoteUrl(), url) # Must be cached.
2942
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002943 def test_gerrit_change_identifier_with_project(self):
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00002944 self.calls = [
2945 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2946 ((['git', 'config', 'branch.master.merge'],), 'master'),
2947 ((['git', 'config', 'branch.master.remote'],), 'origin'),
2948 ((['git', 'config', 'remote.origin.url'],),
2949 'https://chromium.googlesource.com/a/my/repo.git/'),
2950 ]
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002951 cl = git_cl.Changelist(codereview='gerrit', issue=123456)
2952 self.assertEqual(cl._GerritChangeIdentifier(), 'my%2Frepo~123456')
2953
2954 def test_gerrit_change_identifier_without_project(self):
2955 self.calls = [
2956 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2957 ((['git', 'config', 'branch.master.merge'],), 'master'),
2958 ((['git', 'config', 'branch.master.remote'],), 'origin'),
2959 ((['git', 'config', 'remote.origin.url'],), CERR1),
2960 ]
2961 cl = git_cl.Changelist(codereview='gerrit', issue=123456)
2962 self.assertEqual(cl._GerritChangeIdentifier(), '123456')
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00002963
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002964
maruel@chromium.orgddd59412011-11-30 14:20:38 +00002965if __name__ == '__main__':
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +01002966 logging.basicConfig(
2967 level=logging.DEBUG if '-v' in sys.argv else logging.ERROR)
maruel@chromium.orgddd59412011-11-30 14:20:38 +00002968 unittest.main()