blob: 13e279c2dc08b8ebb749dcacd0ed95142d621dd8 [file] [log] [blame]
maruel@chromium.orgddd59412011-11-30 14:20:38 +00001#!/usr/bin/env python
maruel@chromium.orgeb5edbc2012-01-16 17:03:28 +00002# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
6"""Unit tests for git_cl.py."""
7
Andrii Shyshkalovcd6a9362016-12-07 12:04:12 +01008import contextlib
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01009import datetime
tandriide281ae2016-10-12 06:02:30 -070010import json
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +010011import logging
maruel@chromium.orgddd59412011-11-30 14:20:38 +000012import os
maruel@chromium.orga3353652011-11-30 14:26:57 +000013import StringIO
maruel@chromium.orgddd59412011-11-30 14:20:38 +000014import sys
Aaron Gable9a03ae02017-11-03 11:31:07 -070015import tempfile
maruel@chromium.orgddd59412011-11-30 14:20:38 +000016import unittest
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +000017import urlparse
maruel@chromium.orgddd59412011-11-30 14:20:38 +000018
19sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
20
21from testing_support.auto_stub import TestCase
22
Edward Lemur5ba1e9c2018-07-23 18:19:02 +000023import metrics
24# We have to disable monitoring before importing git_cl.
25metrics.DISABLE_METRICS_COLLECTION = True
26
Eric Boren2fb63102018-10-05 13:05:03 +000027import gerrit_util
maruel@chromium.orgddd59412011-11-30 14:20:38 +000028import git_cl
iannucci@chromium.org9e849272014-04-04 00:31:55 +000029import git_common
tandrii@chromium.org57d86542016-03-04 16:11:32 +000030import git_footers
maruel@chromium.orgddd59412011-11-30 14:20:38 +000031import subprocess2
maruel@chromium.orgddd59412011-11-30 14:20:38 +000032
tandrii5d48c322016-08-18 16:19:37 -070033def callError(code=1, cmd='', cwd='', stdout='', stderr=''):
34 return subprocess2.CalledProcessError(code, cmd, cwd, stdout, stderr)
35
36
37CERR1 = callError(1)
38
39
Aaron Gable9a03ae02017-11-03 11:31:07 -070040def MakeNamedTemporaryFileMock(expected_content):
41 class NamedTemporaryFileMock(object):
42 def __init__(self, *args, **kwargs):
43 self.name = '/tmp/named'
44 self.expected_content = expected_content
45
46 def __enter__(self):
47 return self
48
49 def __exit__(self, _type, _value, _tb):
50 pass
51
52 def write(self, content):
53 if self.expected_content:
54 assert content == self.expected_content
55
56 def close(self):
57 pass
58
59 return NamedTemporaryFileMock
60
61
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000062class ChangelistMock(object):
63 # A class variable so we can access it when we don't have access to the
64 # instance that's being set.
65 desc = ""
66 def __init__(self, **kwargs):
67 pass
68 def GetIssue(self):
69 return 1
Kenneth Russell61e2ed42017-02-15 11:47:13 -080070 def GetDescription(self, force=False):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000071 return ChangelistMock.desc
dsansomee2d6fd92016-09-08 00:10:47 -070072 def UpdateDescription(self, desc, force=False):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000073 ChangelistMock.desc = desc
74
tandrii5d48c322016-08-18 16:19:37 -070075
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000076class PresubmitMock(object):
77 def __init__(self, *args, **kwargs):
78 self.reviewers = []
Daniel Cheng7227d212017-11-17 08:12:37 -080079 self.more_cc = ['chromium-reviews+test-more-cc@chromium.org']
80
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000081 @staticmethod
82 def should_continue():
83 return True
84
85
skobes6468b902016-10-24 08:45:10 -070086class GitCheckoutMock(object):
87 def __init__(self, *args, **kwargs):
88 pass
89
90 @staticmethod
91 def reset():
92 GitCheckoutMock.conflict = False
93
94 def apply_patch(self, p):
95 if GitCheckoutMock.conflict:
96 raise Exception('failed')
97
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000098
99class WatchlistsMock(object):
100 def __init__(self, _):
101 pass
102 @staticmethod
103 def GetWatchersForPaths(_):
104 return ['joe@example.com']
105
106
ukai@chromium.org78c4b982012-02-14 02:20:26 +0000107class CodereviewSettingsFileMock(object):
108 def __init__(self):
109 pass
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800110 # pylint: disable=no-self-use
ukai@chromium.org78c4b982012-02-14 02:20:26 +0000111 def read(self):
112 return ("CODE_REVIEW_SERVER: gerrit.chromium.org\n" +
andybons@chromium.org11f46eb2016-02-02 19:26:51 +0000113 "GERRIT_HOST: True\n")
ukai@chromium.org78c4b982012-02-14 02:20:26 +0000114
115
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000116class AuthenticatorMock(object):
117 def __init__(self, *_args):
118 pass
119 def has_cached_credentials(self):
120 return True
tandrii221ab252016-10-06 08:12:04 -0700121 def authorize(self, http):
122 return http
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000123
124
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100125def CookiesAuthenticatorMockFactory(hosts_with_creds=None, same_auth=False):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000126 """Use to mock Gerrit/Git credentials from ~/.netrc or ~/.gitcookies.
127
128 Usage:
129 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100130 CookiesAuthenticatorMockFactory({'host': ('user', _, 'pass')})
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000131
132 OR
133 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100134 CookiesAuthenticatorMockFactory(
135 same_auth=('user', '', 'pass'))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000136 """
137 class CookiesAuthenticatorMock(git_cl.gerrit_util.CookiesAuthenticator):
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800138 def __init__(self): # pylint: disable=super-init-not-called
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000139 # Intentionally not calling super() because it reads actual cookie files.
140 pass
141 @classmethod
142 def get_gitcookies_path(cls):
143 return '~/.gitcookies'
144 @classmethod
145 def get_netrc_path(cls):
146 return '~/.netrc'
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100147 def _get_auth_for_host(self, host):
148 if same_auth:
149 return same_auth
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000150 return (hosts_with_creds or {}).get(host)
151 return CookiesAuthenticatorMock
152
Aaron Gable9a03ae02017-11-03 11:31:07 -0700153
kmarshall9249e012016-08-23 12:02:16 -0700154class MockChangelistWithBranchAndIssue():
155 def __init__(self, branch, issue):
156 self.branch = branch
157 self.issue = issue
158 def GetBranch(self):
159 return self.branch
160 def GetIssue(self):
161 return self.issue
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000162
tandriic2405f52016-10-10 08:13:15 -0700163
164class SystemExitMock(Exception):
165 pass
166
167
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000168class TestGitClBasic(unittest.TestCase):
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100169 def test_get_description(self):
Andrii Shyshkalovf5569d22018-10-15 03:35:23 +0000170 cl = git_cl.Changelist(issue=1, codereview='gerrit',
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100171 codereview_host='host')
172 cl.description = 'x'
173 cl.has_description = True
Kenneth Russell61e2ed42017-02-15 11:47:13 -0800174 cl._codereview_impl.FetchDescription = lambda *a, **kw: 'y'
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100175 self.assertEquals(cl.GetDescription(), 'x')
176 self.assertEquals(cl.GetDescription(force=True), 'y')
177 self.assertEquals(cl.GetDescription(), 'y')
178
Robert Iannucci09f1f3d2017-03-28 16:54:32 -0700179 def test_description_footers(self):
180 cl = git_cl.Changelist(issue=1, codereview='gerrit',
181 codereview_host='host')
182 cl.description = '\n'.join([
183 'This is some message',
184 '',
185 'It has some lines',
186 'and, also',
187 '',
188 'Some: Really',
189 'Awesome: Footers',
190 ])
191 cl.has_description = True
192 cl._codereview_impl.UpdateDescriptionRemote = lambda *a, **kw: 'y'
193 msg, footers = cl.GetDescriptionFooters()
194 self.assertEquals(
195 msg, ['This is some message', '', 'It has some lines', 'and, also'])
196 self.assertEquals(footers, [('Some', 'Really'), ('Awesome', 'Footers')])
197
198 msg.append('wut')
199 footers.append(('gnarly-dude', 'beans'))
200 cl.UpdateDescriptionFooters(msg, footers)
201 self.assertEquals(cl.GetDescription().splitlines(), [
202 'This is some message',
203 '',
204 'It has some lines',
205 'and, also',
206 'wut'
207 '',
208 'Some: Really',
209 'Awesome: Footers',
210 'Gnarly-Dude: beans',
211 ])
212
tandriif9aefb72016-07-01 09:06:51 -0700213 def test_get_bug_line_values(self):
214 f = lambda p, bugs: list(git_cl._get_bug_line_values(p, bugs))
215 self.assertEqual(f('', ''), [])
216 self.assertEqual(f('', '123,v8:456'), ['123', 'v8:456'])
217 self.assertEqual(f('v8', '456'), ['v8:456'])
218 self.assertEqual(f('v8', 'chromium:123,456'), ['v8:456', 'chromium:123'])
219 # Not nice, but not worth carying.
220 self.assertEqual(f('v8', 'chromium:123,456,v8:123'),
221 ['v8:456', 'chromium:123', 'v8:123'])
222
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100223 def _test_git_number(self, parent_msg, dest_ref, child_msg,
224 parent_hash='parenthash'):
225 desc = git_cl.ChangeDescription(child_msg)
226 desc.update_with_git_number_footers(parent_hash, parent_msg, dest_ref)
227 return desc.description
228
229 def assertEqualByLine(self, actual, expected):
230 self.assertEqual(actual.splitlines(), expected.splitlines())
231
232 def test_git_number_bad_parent(self):
233 with self.assertRaises(ValueError):
234 self._test_git_number('Parent', 'refs/heads/master', 'Child')
235
236 def test_git_number_bad_parent_footer(self):
237 with self.assertRaises(AssertionError):
238 self._test_git_number(
239 'Parent\n'
240 '\n'
241 'Cr-Commit-Position: wrong',
242 'refs/heads/master', 'Child')
243
244 def test_git_number_bad_lineage_ignored(self):
245 actual = self._test_git_number(
246 'Parent\n'
247 '\n'
248 'Cr-Commit-Position: refs/heads/master@{#1}\n'
249 'Cr-Branched-From: mustBeReal40CharHash-branch@{#pos}',
250 'refs/heads/master', 'Child')
251 self.assertEqualByLine(
252 actual,
253 'Child\n'
254 '\n'
255 'Cr-Commit-Position: refs/heads/master@{#2}\n'
256 'Cr-Branched-From: mustBeReal40CharHash-branch@{#pos}')
257
258 def test_git_number_same_branch(self):
259 actual = self._test_git_number(
260 'Parent\n'
261 '\n'
262 'Cr-Commit-Position: refs/heads/master@{#12}',
263 dest_ref='refs/heads/master',
264 child_msg='Child')
265 self.assertEqualByLine(
266 actual,
267 'Child\n'
268 '\n'
269 'Cr-Commit-Position: refs/heads/master@{#13}')
270
Andrii Shyshkalovde37c012017-07-06 21:06:50 +0200271 def test_git_number_same_branch_mixed_footers(self):
272 actual = self._test_git_number(
273 'Parent\n'
274 '\n'
275 'Cr-Commit-Position: refs/heads/master@{#12}',
276 dest_ref='refs/heads/master',
277 child_msg='Child\n'
278 '\n'
279 'Broken-by: design\n'
280 'BUG=123')
281 self.assertEqualByLine(
282 actual,
283 'Child\n'
284 '\n'
285 'Broken-by: design\n'
286 'BUG=123\n'
287 'Cr-Commit-Position: refs/heads/master@{#13}')
288
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100289 def test_git_number_same_branch_with_originals(self):
290 actual = self._test_git_number(
291 'Parent\n'
292 '\n'
293 'Cr-Commit-Position: refs/heads/master@{#12}',
294 dest_ref='refs/heads/master',
295 child_msg='Child\n'
296 '\n'
297 'Some users are smart and insert their own footers\n'
298 '\n'
299 'Cr-Whatever: value\n'
300 'Cr-Commit-Position: refs/copy/paste@{#22}')
301 self.assertEqualByLine(
302 actual,
303 'Child\n'
304 '\n'
305 'Some users are smart and insert their own footers\n'
306 '\n'
307 'Cr-Original-Whatever: value\n'
308 'Cr-Original-Commit-Position: refs/copy/paste@{#22}\n'
309 'Cr-Commit-Position: refs/heads/master@{#13}')
310
311 def test_git_number_new_branch(self):
312 actual = self._test_git_number(
313 'Parent\n'
314 '\n'
315 'Cr-Commit-Position: refs/heads/master@{#12}',
316 dest_ref='refs/heads/branch',
317 child_msg='Child')
318 self.assertEqualByLine(
319 actual,
320 'Child\n'
321 '\n'
322 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
323 'Cr-Branched-From: parenthash-refs/heads/master@{#12}')
324
325 def test_git_number_lineage(self):
326 actual = self._test_git_number(
327 'Parent\n'
328 '\n'
329 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
330 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
331 dest_ref='refs/heads/branch',
332 child_msg='Child')
333 self.assertEqualByLine(
334 actual,
335 'Child\n'
336 '\n'
337 'Cr-Commit-Position: refs/heads/branch@{#2}\n'
338 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
339
340 def test_git_number_moooooooore_lineage(self):
341 actual = self._test_git_number(
342 'Parent\n'
343 '\n'
344 'Cr-Commit-Position: refs/heads/branch@{#5}\n'
345 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
346 dest_ref='refs/heads/mooore',
347 child_msg='Child')
348 self.assertEqualByLine(
349 actual,
350 'Child\n'
351 '\n'
352 'Cr-Commit-Position: refs/heads/mooore@{#1}\n'
353 'Cr-Branched-From: parenthash-refs/heads/branch@{#5}\n'
354 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
355
Andrii Shyshkalovb5effa12016-12-14 19:35:12 +0100356 def test_git_number_ever_moooooooore_lineage(self):
Robert Iannucci456b0d62018-03-13 19:15:50 -0700357 self.maxDiff = 10000 # pylint: disable=attribute-defined-outside-init
Andrii Shyshkalovb5effa12016-12-14 19:35:12 +0100358 actual = self._test_git_number(
359 'CQ commit on fresh new branch + numbering.\n'
360 '\n'
361 'NOTRY=True\n'
362 'NOPRESUBMIT=True\n'
363 'BUG=\n'
364 '\n'
365 'Review-Url: https://codereview.chromium.org/2577703003\n'
366 'Cr-Commit-Position: refs/heads/gnumb-test/br@{#1}\n'
367 'Cr-Branched-From: 0749ff9edc-refs/heads/gnumb-test/cq@{#4}\n'
368 'Cr-Branched-From: 5c49df2da6-refs/heads/master@{#41618}',
369 dest_ref='refs/heads/gnumb-test/cl',
370 child_msg='git cl on fresh new branch + numbering.\n'
371 '\n'
372 'Review-Url: https://codereview.chromium.org/2575043003 .\n')
373 self.assertEqualByLine(
374 actual,
375 'git cl on fresh new branch + numbering.\n'
376 '\n'
377 'Review-Url: https://codereview.chromium.org/2575043003 .\n'
378 'Cr-Commit-Position: refs/heads/gnumb-test/cl@{#1}\n'
379 'Cr-Branched-From: parenthash-refs/heads/gnumb-test/br@{#1}\n'
380 'Cr-Branched-From: 0749ff9edc-refs/heads/gnumb-test/cq@{#4}\n'
381 'Cr-Branched-From: 5c49df2da6-refs/heads/master@{#41618}')
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100382
383 def test_git_number_cherry_pick(self):
384 actual = self._test_git_number(
385 'Parent\n'
386 '\n'
387 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
388 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
389 dest_ref='refs/heads/branch',
390 child_msg='Child, which is cherry-pick from master\n'
391 '\n'
392 'Cr-Commit-Position: refs/heads/master@{#100}\n'
393 '(cherry picked from commit deadbeef12345678deadbeef12345678deadbeef)')
394 self.assertEqualByLine(
395 actual,
396 'Child, which is cherry-pick from master\n'
397 '\n'
398 '(cherry picked from commit deadbeef12345678deadbeef12345678deadbeef)\n'
399 '\n'
400 'Cr-Original-Commit-Position: refs/heads/master@{#100}\n'
401 'Cr-Commit-Position: refs/heads/branch@{#2}\n'
402 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
403
Andrii Shyshkalovd4c86732018-09-25 04:29:31 +0000404 def test_gerrit_mirror_hack(self):
405 cr = 'chromium-review.googlesource.com'
406 url0 = 'https://%s/a/changes/x?a=b' % cr
407 origMirrors = git_cl.gerrit_util._GERRIT_MIRROR_PREFIXES
408 try:
409 git_cl.gerrit_util._GERRIT_MIRROR_PREFIXES = ['us1', 'us2']
410 url1 = git_cl.gerrit_util._UseGerritMirror(url0, cr)
411 url2 = git_cl.gerrit_util._UseGerritMirror(url1, cr)
412 url3 = git_cl.gerrit_util._UseGerritMirror(url2, cr)
413
414 self.assertNotEqual(url1, url2)
415 self.assertEqual(sorted((url1, url2)), [
416 'https://us1-mirror-chromium-review.googlesource.com/a/changes/x?a=b',
417 'https://us2-mirror-chromium-review.googlesource.com/a/changes/x?a=b'])
418 self.assertEqual(url1, url3)
419 finally:
420 git_cl.gerrit_util._GERRIT_MIRROR_PREFIXES = origMirrors
421
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000422 def test_valid_accounts(self):
423 mock_per_account = {
424 'u1': None, # 404, doesn't exist.
425 'u2': {
426 '_account_id': 123124,
427 'avatars': [],
428 'email': 'u2@example.com',
429 'name': 'User Number 2',
430 'status': 'OOO',
431 },
432 'u3': git_cl.gerrit_util.GerritError(500, 'retries didn\'t help :('),
433 }
434 def GetAccountDetailsMock(_, account):
435 # Poor-man's mock library's side_effect.
436 v = mock_per_account.pop(account)
437 if isinstance(v, Exception):
438 raise v
439 return v
440
441 original = git_cl.gerrit_util.GetAccountDetails
442 try:
443 git_cl.gerrit_util.GetAccountDetails = GetAccountDetailsMock
444 actual = git_cl.gerrit_util.ValidAccounts(
445 'host', ['u1', 'u2', 'u3'], max_threads=1)
446 finally:
447 git_cl.gerrit_util.GetAccountDetails = original
448 self.assertEqual(actual, {
449 'u2': {
450 '_account_id': 123124,
451 'avatars': [],
452 'email': 'u2@example.com',
453 'name': 'User Number 2',
454 'status': 'OOO',
455 },
456 })
457
458
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000459
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200460class TestParseIssueURL(unittest.TestCase):
461 def _validate(self, parsed, issue=None, patchset=None, hostname=None,
462 codereview=None, fail=False):
463 self.assertIsNotNone(parsed)
464 if fail:
465 self.assertFalse(parsed.valid)
466 return
467 self.assertTrue(parsed.valid)
468 self.assertEqual(parsed.issue, issue)
469 self.assertEqual(parsed.patchset, patchset)
470 self.assertEqual(parsed.hostname, hostname)
471 self.assertEqual(parsed.codereview, codereview)
472
473 def _run_and_validate(self, func, url, *args, **kwargs):
474 result = func(urlparse.urlparse(url))
475 if kwargs.pop('fail', False):
476 self.assertIsNone(result)
477 return None
478 self._validate(result, *args, fail=False, **kwargs)
479
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200480 def test_gerrit(self):
481 def test(url, issue=None, patchset=None, hostname=None, fail=None):
482 self._test_ParseIssueUrl(
483 git_cl._GerritChangelistImpl.ParseIssueURL,
484 url, issue, patchset, hostname, fail)
485 def test(url, *args, **kwargs):
486 self._run_and_validate(git_cl._GerritChangelistImpl.ParseIssueURL, url,
487 *args, codereview='gerrit', **kwargs)
488
489 test('http://chrome-review.source.com/c/123',
490 123, None, 'chrome-review.source.com')
491 test('https://chrome-review.source.com/c/123/',
492 123, None, 'chrome-review.source.com')
493 test('https://chrome-review.source.com/c/123/4',
494 123, 4, 'chrome-review.source.com')
495 test('https://chrome-review.source.com/#/c/123/4',
496 123, 4, 'chrome-review.source.com')
497 test('https://chrome-review.source.com/c/123/4',
498 123, 4, 'chrome-review.source.com')
499 test('https://chrome-review.source.com/123',
500 123, None, 'chrome-review.source.com')
501 test('https://chrome-review.source.com/123/4',
502 123, 4, 'chrome-review.source.com')
503
504 test('https://chrome-review.source.com/c/123/1/whatisthis', fail=True)
505 test('https://chrome-review.source.com/c/abc/', fail=True)
506 test('ssh://chrome-review.source.com/c/123/1/', fail=True)
507
508 def test_ParseIssueNumberArgument(self):
509 def test(arg, *args, **kwargs):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +0200510 codereview_hint = kwargs.pop('hint', None)
511 self._validate(git_cl.ParseIssueNumberArgument(arg, codereview_hint),
512 *args, **kwargs)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200513
514 test('123', 123)
515 test('', fail=True)
516 test('abc', fail=True)
517 test('123/1', fail=True)
518 test('123a', fail=True)
519 test('ssh://chrome-review.source.com/#/c/123/4/', fail=True)
Andrii Shyshkalovf5569d22018-10-15 03:35:23 +0000520
521 # Looks like Rietveld and Gerrit, but we should select Gerrit now
522 # w/ or w/o hint.
Andrii Shyshkalovc9712392017-04-11 13:35:21 +0200523 test('https://codereview.source.com/123',
524 123, None, 'codereview.source.com', 'gerrit',
525 hint='gerrit')
Andrii Shyshkalovf5569d22018-10-15 03:35:23 +0000526 test('https://codereview.source.com/123',
527 123, None, 'codereview.source.com', 'gerrit')
528
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200529 # Gerrrit.
530 test('https://chrome-review.source.com/c/123/4',
531 123, 4, 'chrome-review.source.com', 'gerrit')
532 test('https://chrome-review.source.com/bad/123/4', fail=True)
533
534
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100535class GitCookiesCheckerTest(TestCase):
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100536 def setUp(self):
537 super(GitCookiesCheckerTest, self).setUp()
538 self.c = git_cl._GitCookiesChecker()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100539 self.c._all_hosts = []
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100540
541 def mock_hosts_creds(self, subhost_identity_pairs):
542 def ensure_googlesource(h):
543 if not h.endswith(self.c._GOOGLESOURCE):
544 assert not h.endswith('.')
545 return h + '.' + self.c._GOOGLESOURCE
546 return h
547 self.c._all_hosts = [(ensure_googlesource(h), i, '.gitcookies')
548 for h, i in subhost_identity_pairs]
549
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200550 def test_identity_parsing(self):
551 self.assertEqual(self.c._parse_identity('ldap.google.com'),
552 ('ldap', 'google.com'))
553 self.assertEqual(self.c._parse_identity('git-ldap.example.com'),
554 ('ldap', 'example.com'))
555 # Specical case because we know there are no subdomains in chromium.org.
556 self.assertEqual(self.c._parse_identity('git-note.period.chromium.org'),
557 ('note.period', 'chromium.org'))
Lei Zhangd3f769a2017-12-15 15:16:14 -0800558 # Pathological: ".period." can be either username OR domain, more likely
559 # domain.
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200560 self.assertEqual(self.c._parse_identity('git-note.period.example.com'),
561 ('note', 'period.example.com'))
562
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100563 def test_analysis_nothing(self):
564 self.c._all_hosts = []
565 self.assertFalse(self.c.has_generic_host())
566 self.assertEqual(set(), self.c.get_conflicting_hosts())
567 self.assertEqual(set(), self.c.get_duplicated_hosts())
568 self.assertEqual(set(), self.c.get_partially_configured_hosts())
569 self.assertEqual(set(), self.c.get_hosts_with_wrong_identities())
570
571 def test_analysis(self):
572 self.mock_hosts_creds([
573 ('.googlesource.com', 'git-example.chromium.org'),
574
575 ('chromium', 'git-example.google.com'),
576 ('chromium-review', 'git-example.google.com'),
577 ('chrome-internal', 'git-example.chromium.org'),
578 ('chrome-internal-review', 'git-example.chromium.org'),
579 ('conflict', 'git-example.google.com'),
580 ('conflict-review', 'git-example.chromium.org'),
581 ('dup', 'git-example.google.com'),
582 ('dup', 'git-example.google.com'),
583 ('dup-review', 'git-example.google.com'),
584 ('partial', 'git-example.google.com'),
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200585 ('gpartial-review', 'git-example.google.com'),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100586 ])
587 self.assertTrue(self.c.has_generic_host())
588 self.assertEqual(set(['conflict.googlesource.com']),
589 self.c.get_conflicting_hosts())
590 self.assertEqual(set(['dup.googlesource.com']),
591 self.c.get_duplicated_hosts())
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200592 self.assertEqual(set(['partial.googlesource.com',
593 'gpartial-review.googlesource.com']),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100594 self.c.get_partially_configured_hosts())
595 self.assertEqual(set(['chromium.googlesource.com',
596 'chrome-internal.googlesource.com']),
597 self.c.get_hosts_with_wrong_identities())
598
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100599 def test_report_no_problems(self):
600 self.test_analysis_nothing()
601 self.mock(sys, 'stdout', StringIO.StringIO())
602 self.assertFalse(self.c.find_and_report_problems())
603 self.assertEqual(sys.stdout.getvalue(), '')
604
605 def test_report(self):
606 self.test_analysis()
607 self.mock(sys, 'stdout', StringIO.StringIO())
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200608 self.mock(git_cl.gerrit_util.CookiesAuthenticator, 'get_gitcookies_path',
609 classmethod(lambda _: '~/.gitcookies'))
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100610 self.assertTrue(self.c.find_and_report_problems())
611 with open(os.path.join(os.path.dirname(__file__),
612 'git_cl_creds_check_report.txt')) as f:
613 expected = f.read()
614 def by_line(text):
615 return [l.rstrip() for l in text.rstrip().splitlines()]
Robert Iannucci456b0d62018-03-13 19:15:50 -0700616 self.maxDiff = 10000 # pylint: disable=attribute-defined-outside-init
Andrii Shyshkalov4812e612017-03-27 17:22:57 +0200617 self.assertEqual(by_line(sys.stdout.getvalue().strip()), by_line(expected))
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100618
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -0800619
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000620class TestGitCl(TestCase):
621 def setUp(self):
622 super(TestGitCl, self).setUp()
623 self.calls = []
tandrii9d206752016-06-20 11:32:47 -0700624 self._calls_done = []
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000625 self.mock(git_cl, 'time_time',
626 lambda: self._mocked_call('time.time'))
627 self.mock(git_cl.metrics.collector, 'add_repeated',
628 lambda *a: self._mocked_call('add_repeated', *a))
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000629 self.mock(subprocess2, 'call', self._mocked_call)
630 self.mock(subprocess2, 'check_call', self._mocked_call)
631 self.mock(subprocess2, 'check_output', self._mocked_call)
tandrii5d48c322016-08-18 16:19:37 -0700632 self.mock(subprocess2, 'communicate',
633 lambda *a, **kw: ([self._mocked_call(*a, **kw), ''], 0))
tandrii@chromium.orga342c922016-03-16 07:08:25 +0000634 self.mock(git_cl.gclient_utils, 'CheckCallAndFilter', self._mocked_call)
sbc@chromium.org71437c02015-04-09 19:29:40 +0000635 self.mock(git_common, 'is_dirty_git_tree', lambda x: False)
iannucci@chromium.org9e849272014-04-04 00:31:55 +0000636 self.mock(git_common, 'get_or_create_merge_base',
637 lambda *a: (
638 self._mocked_call(['get_or_create_merge_base']+list(a))))
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +0000639 self.mock(git_cl, 'BranchExists', lambda _: True)
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000640 self.mock(git_cl, 'FindCodereviewSettingsFile', lambda: '')
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000641 self.mock(git_cl, 'SaveDescriptionBackup', lambda _:
642 self._mocked_call('SaveDescriptionBackup'))
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100643 self.mock(git_cl, 'ask_for_data', lambda *a, **k: self._mocked_call(
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000644 *(['ask_for_data'] + list(a)), **k))
phajdan.jre328cf92016-08-22 04:12:17 -0700645 self.mock(git_cl, 'write_json', lambda path, contents:
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000646 self._mocked_call('write_json', path, contents))
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000647 self.mock(git_cl.presubmit_support, 'DoPresubmitChecks', PresubmitMock)
skobes6468b902016-10-24 08:45:10 -0700648 self.mock(git_cl.checkout, 'GitCheckout', GitCheckoutMock)
649 GitCheckoutMock.reset()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000650 self.mock(git_cl.watchlists, 'Watchlists', WatchlistsMock)
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000651 self.mock(git_cl.auth, 'get_authenticator_for_host', AuthenticatorMock)
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +0100652 self.mock(git_cl.gerrit_util, 'GetChangeDetail',
653 lambda *args, **kwargs: self._mocked_call(
654 'GetChangeDetail', *args, **kwargs))
Aaron Gable0ffdf2d2017-06-05 13:01:17 -0700655 self.mock(git_cl.gerrit_util, 'GetChangeComments',
656 lambda *args, **kwargs: self._mocked_call(
657 'GetChangeComments', *args, **kwargs))
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +0100658 self.mock(git_cl.gerrit_util, 'AddReviewers',
Aaron Gable6dadfbf2017-05-09 14:27:58 -0700659 lambda h, i, reviewers, ccs, notify: self._mocked_call(
660 'AddReviewers', h, i, reviewers, ccs, notify))
Aaron Gablefd238082017-06-07 13:42:34 -0700661 self.mock(git_cl.gerrit_util, 'SetReview',
Aaron Gablefc62f762017-07-17 11:12:07 -0700662 lambda h, i, msg=None, labels=None, notify=None:
663 self._mocked_call('SetReview', h, i, msg, labels, notify))
Andrii Shyshkalov733d4ec2018-04-19 11:48:58 -0700664 self.mock(git_cl.gerrit_util.LuciContextAuthenticator, 'is_luci',
665 staticmethod(lambda: False))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000666 self.mock(git_cl.gerrit_util.GceAuthenticator, 'is_gce',
667 classmethod(lambda _: False))
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000668 self.mock(git_cl.gerrit_util, 'ValidAccounts',
669 lambda host, accounts:
670 self._mocked_call('ValidAccounts', host, accounts))
tandriic2405f52016-10-10 08:13:15 -0700671 self.mock(git_cl, 'DieWithError',
Christopher Lamf732cd52017-01-24 12:40:11 +1100672 lambda msg, change=None: self._mocked_call(['DieWithError', msg]))
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000673 # It's important to reset settings to not have inter-tests interference.
674 git_cl.settings = None
675
676 def tearDown(self):
wychen@chromium.org445c8962015-04-28 23:30:05 +0000677 try:
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100678 self.assertEquals([], self.calls)
679 except AssertionError:
wychen@chromium.org445c8962015-04-28 23:30:05 +0000680 if not self.has_failed():
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100681 raise
682 # Sadly, has_failed() returns True if this OR any other tests before this
683 # one have failed.
Andrii Shyshkalove05d4882017-04-12 14:34:49 +0200684 git_cl.logging.error(
685 '!!!!!! IF YOU SEE THIS, READ BELOW, IT WILL SAVE YOUR TIME !!!!!\n'
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100686 'There are un-consumed self.calls after this test has finished.\n'
687 'If you don\'t know which test this is, run:\n'
Aaron Gable3a16ed12017-03-23 10:51:55 -0700688 ' tests/git_cl_tests.py -v\n'
Andrii Shyshkalove05d4882017-04-12 14:34:49 +0200689 'If you are already running only this test, then **first** fix the '
690 'problem whose exception is emitted below by unittest runner.\n'
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100691 'Else, to be sure what\'s going on, run this test **alone** with \n'
Aaron Gable3a16ed12017-03-23 10:51:55 -0700692 ' tests/git_cl_tests.py TestGitCl.<name>\n'
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100693 'and follow instructions above.\n' +
694 '=' * 80)
wychen@chromium.org445c8962015-04-28 23:30:05 +0000695 finally:
696 super(TestGitCl, self).tearDown()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000697
iannucci@chromium.org9e849272014-04-04 00:31:55 +0000698 def _mocked_call(self, *args, **_kwargs):
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000699 self.assertTrue(
700 self.calls,
tandrii9d206752016-06-20 11:32:47 -0700701 '@%d Expected: <Missing> Actual: %r' % (len(self._calls_done), args))
wychen@chromium.orga872e752015-04-28 23:42:18 +0000702 top = self.calls.pop(0)
wychen@chromium.orga872e752015-04-28 23:42:18 +0000703 expected_args, result = top
704
maruel@chromium.orge52678e2013-04-26 18:34:44 +0000705 # Also logs otherwise it could get caught in a try/finally and be hard to
706 # diagnose.
707 if expected_args != args:
tandrii9d206752016-06-20 11:32:47 -0700708 N = 5
709 prior_calls = '\n '.join(
710 '@%d: %r' % (len(self._calls_done) - N + i, c[0])
711 for i, c in enumerate(self._calls_done[-N:]))
712 following_calls = '\n '.join(
713 '@%d: %r' % (len(self._calls_done) + i + 1, c[0])
714 for i, c in enumerate(self.calls[:N]))
715 extended_msg = (
716 'A few prior calls:\n %s\n\n'
717 'This (expected):\n @%d: %r\n'
718 'This (actual):\n @%d: %r\n\n'
719 'A few following expected calls:\n %s' %
720 (prior_calls, len(self._calls_done), expected_args,
721 len(self._calls_done), args, following_calls))
722 git_cl.logging.error(extended_msg)
723
tandrii99a72f22016-08-17 14:33:24 -0700724 self.fail('@%d\n'
725 ' Expected: %r\n'
726 ' Actual: %r' % (
tandrii9d206752016-06-20 11:32:47 -0700727 len(self._calls_done), expected_args, args))
728
729 self._calls_done.append(top)
tandrii5d48c322016-08-18 16:19:37 -0700730 if isinstance(result, Exception):
731 raise result
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000732 return result
733
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100734 def test_ask_for_explicit_yes_true(self):
735 self.calls = [
736 (('ask_for_data', 'prompt [Yes/No]: '), 'blah'),
737 (('ask_for_data', 'Please, type yes or no: '), 'ye'),
738 ]
739 self.assertTrue(git_cl.ask_for_explicit_yes('prompt'))
740
tandrii48df5812016-10-17 03:55:37 -0700741 def test_LoadCodereviewSettingsFromFile_gerrit(self):
742 codereview_file = StringIO.StringIO('GERRIT_HOST: true')
743 self.calls = [
744 ((['git', 'config', '--unset-all', 'rietveld.cc'],), CERR1),
745 ((['git', 'config', '--unset-all', 'rietveld.private'],), CERR1),
746 ((['git', 'config', '--unset-all', 'rietveld.tree-status-url'],), CERR1),
747 ((['git', 'config', '--unset-all', 'rietveld.viewvc-url'],), CERR1),
748 ((['git', 'config', '--unset-all', 'rietveld.bug-prefix'],), CERR1),
749 ((['git', 'config', '--unset-all', 'rietveld.cpplint-regex'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700750 ((['git', 'config', '--unset-all', 'rietveld.cpplint-ignore-regex'],),
751 CERR1),
752 ((['git', 'config', '--unset-all', 'rietveld.project'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700753 ((['git', 'config', '--unset-all', 'rietveld.run-post-upload-hook'],),
754 CERR1),
755 ((['git', 'config', 'gerrit.host', 'true'],), ''),
756 ]
757 self.assertIsNone(git_cl.LoadCodereviewSettingsFromFile(codereview_file))
758
maruel@chromium.orga3353652011-11-30 14:26:57 +0000759 @classmethod
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000760 def _is_gerrit_calls(cls, gerrit=False):
761 return [((['git', 'config', 'rietveld.autoupdate'],), ''),
762 ((['git', 'config', 'gerrit.host'],), 'True' if gerrit else '')]
763
764 @classmethod
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +0000765 def _git_post_upload_calls(cls):
766 return [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000767 ((['git', 'rev-parse', 'HEAD'],), 'hash'),
768 ((['git', 'symbolic-ref', 'HEAD'],), 'hash'),
769 ((['git',
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000770 'config', 'branch.hash.last-upload-hash', 'hash'],), ''),
rmistry@google.com5626a922015-02-26 14:03:30 +0000771 ((['git', 'config', 'rietveld.run-post-upload-hook'],), ''),
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000772 ]
773
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000774 @staticmethod
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000775 def _git_sanity_checks(diff_base, working_branch, get_remote_branch=True):
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000776 fake_ancestor = 'fake_ancestor'
777 fake_cl = 'fake_cl_for_patch'
778 return [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000779 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000780 'rev-parse', '--verify', diff_base],), fake_ancestor),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000781 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000782 'merge-base', fake_ancestor, 'HEAD'],), fake_ancestor),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000783 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000784 'rev-list', '^' + fake_ancestor, 'HEAD'],), fake_cl),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000785 # Mock a config miss (error code 1)
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000786 ((['git',
tandrii5d48c322016-08-18 16:19:37 -0700787 'config', 'gitcl.remotebranch'],), CERR1),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000788 ] + ([
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000789 # Call to GetRemoteBranch()
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000790 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000791 'config', 'branch.%s.merge' % working_branch],),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000792 'refs/heads/master'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000793 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000794 'config', 'branch.%s.remote' % working_branch],), 'origin'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000795 ] if get_remote_branch else []) + [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000796 ((['git', 'rev-list', '^' + fake_ancestor,
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000797 'refs/remotes/origin/master'],), ''),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000798 ]
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000799
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000800 @classmethod
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000801 def _gerrit_ensure_auth_calls(
802 cls, issue=None, skip_auth_check=False, short_hostname='chromium'):
shinyak@chromium.org00dbccd2016-04-15 07:24:43 +0000803 cmd = ['git', 'config', '--bool', 'gerrit.skip-ensure-authenticated']
tandrii@chromium.org28253532016-04-14 13:46:56 +0000804 if skip_auth_check:
805 return [((cmd, ), 'true')]
806
tandrii5d48c322016-08-18 16:19:37 -0700807 calls = [((cmd, ), CERR1)]
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000808 if issue:
809 calls.extend([
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +0100810 ((['git', 'config', 'branch.master.gerritserver'],), CERR1),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000811 ])
812 calls.extend([
813 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
814 ((['git', 'config', 'branch.master.remote'],), 'origin'),
815 ((['git', 'config', 'remote.origin.url'],),
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000816 'https://%s.googlesource.com/my/repo' % short_hostname),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000817 ])
818 return calls
819
820 @classmethod
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100821 def _gerrit_base_calls(cls, issue=None, fetched_description=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200822 fetched_status=None, other_cl_owner=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000823 custom_cl_base=None, short_hostname='chromium'):
Aaron Gable13101a62018-02-09 13:20:41 -0800824 calls = cls._is_gerrit_calls(True)
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100825 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200826 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
827 ((['git', 'config', 'branch.master.rietveldissue'],), CERR1),
828 ((['git', 'config', 'branch.master.gerritissue'],),
829 CERR1 if issue is None else str(issue)),
830 ]
831
832 if custom_cl_base:
833 ancestor_revision = custom_cl_base
834 else:
835 # Determine ancestor_revision to be merge base.
836 ancestor_revision = 'fake_ancestor_sha'
837 calls += [
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000838 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000839 ((['git', 'config', 'branch.master.remote'],), 'origin'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000840 ((['get_or_create_merge_base', 'master',
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200841 'refs/remotes/origin/master'],), ancestor_revision),
842 ]
843
844 # Calls to verify branch point is ancestor
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000845 calls += cls._gerrit_ensure_auth_calls(
846 issue=issue, short_hostname=short_hostname)
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100847
848 if issue:
849 calls += [
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000850 (('GetChangeDetail', '%s-review.googlesource.com' % short_hostname,
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +0000851 'my%2Frepo~123456',
Andrii Shyshkalovc4a73562018-09-25 18:40:17 +0000852 ['DETAILED_ACCOUNTS', 'CURRENT_REVISION', 'CURRENT_COMMIT', 'LABELS']
853 ),
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100854 {
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100855 'owner': {'email': (other_cl_owner or 'owner@example.com')},
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100856 'change_id': '123456789',
857 'current_revision': 'sha1_of_current_revision',
858 'revisions': { 'sha1_of_current_revision': {
859 'commit': {'message': fetched_description},
860 }},
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100861 'status': fetched_status or 'NEW',
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100862 }),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100863 ]
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100864 if fetched_status == 'ABANDONED':
865 calls += [
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000866 (('DieWithError', 'Change https://%s-review.googlesource.com/'
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100867 '123456 has been abandoned, new uploads are not '
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000868 'allowed' % short_hostname), SystemExitMock()),
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100869 ]
870 return calls
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100871 if other_cl_owner:
872 calls += [
873 (('ask_for_data', 'Press Enter to upload, or Ctrl+C to abort'), ''),
874 ]
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100875
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200876 calls += cls._git_sanity_checks(ancestor_revision, 'master',
877 get_remote_branch=False)
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100878 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200879 ((['git', 'rev-parse', '--show-cdup'],), ''),
880 ((['git', 'rev-parse', 'HEAD'],), '12345'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000881
Aaron Gable7817f022017-12-12 09:43:17 -0800882 ((['git', '-c', 'core.quotePath=false', 'diff', '--name-status',
883 '--no-renames', '-r', ancestor_revision + '...', '.'],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200884 'M\t.gitignore\n'),
885 ((['git', 'config', 'branch.master.gerritpatchset'],), CERR1),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100886 ]
887
888 if not issue:
889 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200890 ((['git', 'log', '--pretty=format:%s%n%n%b',
891 ancestor_revision + '...'],),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000892 'foo'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100893 ]
894
895 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200896 ((['git', 'config', 'user.email'],), 'me@example.com'),
897 ((['git', 'diff', '--no-ext-diff', '--stat', '-l100000', '-C50'] +
898 ([custom_cl_base] if custom_cl_base else
899 [ancestor_revision, 'HEAD']),),
900 '+dat'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100901 ]
902 return calls
ukai@chromium.orge8077812012-02-03 03:41:46 +0000903
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +0000904 @classmethod
905 def _gerrit_upload_calls(cls, description, reviewers, squash,
tandriia60502f2016-06-20 02:01:53 -0700906 squash_mode='default',
tandrii@chromium.org10625002016-03-04 20:03:47 +0000907 expected_upstream_ref='origin/refs/heads/master',
Aaron Gablefd238082017-06-07 13:42:34 -0700908 title=None, notify=False,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +0100909 post_amend_description=None, issue=None, cc=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000910 custom_cl_base=None, tbr=None,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +0000911 short_hostname='chromium',
912 labels=None):
tandrii@chromium.org10625002016-03-04 20:03:47 +0000913 if post_amend_description is None:
914 post_amend_description = description
bradnelsond975b302016-10-23 12:20:23 -0700915 cc = cc or []
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200916 # Determined in `_gerrit_base_calls`.
917 determined_ancestor_revision = custom_cl_base or 'fake_ancestor_sha'
918
919 calls = []
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000920
tandriia60502f2016-06-20 02:01:53 -0700921 if squash_mode == 'default':
922 calls.extend([
923 ((['git', 'config', '--bool', 'gerrit.override-squash-uploads'],), ''),
924 ((['git', 'config', '--bool', 'gerrit.squash-uploads'],), ''),
925 ])
926 elif squash_mode in ('override_squash', 'override_nosquash'):
927 calls.extend([
928 ((['git', 'config', '--bool', 'gerrit.override-squash-uploads'],),
929 'true' if squash_mode == 'override_squash' else 'false'),
930 ])
931 else:
932 assert squash_mode in ('squash', 'nosquash')
933
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000934 # If issue is given, then description is fetched from Gerrit instead.
935 if issue is None:
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000936 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200937 ((['git', 'log', '--pretty=format:%s\n\n%b',
938 ((custom_cl_base + '..') if custom_cl_base else
939 'fake_ancestor_sha..HEAD')],),
940 description),
941 ]
Aaron Gableb56ad332017-01-06 15:24:31 -0800942 if squash:
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +0000943 title = 'Initial_upload'
Aaron Gableb56ad332017-01-06 15:24:31 -0800944 else:
945 if not title:
946 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200947 ((['git', 'show', '-s', '--format=%s', 'HEAD'],), ''),
948 (('ask_for_data', 'Title for patchset []: '), 'User input'),
Aaron Gableb56ad332017-01-06 15:24:31 -0800949 ]
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +0000950 title = 'User_input'
tandrii@chromium.org57d86542016-03-04 16:11:32 +0000951 if not git_footers.get_footer_change_id(description) and not squash:
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000952 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200953 (('DownloadGerritHook', False), ''),
954 # Amending of commit message to get the Change-Id.
955 ((['git', 'log', '--pretty=format:%s\n\n%b',
956 determined_ancestor_revision + '..HEAD'],),
957 description),
958 ((['git', 'commit', '--amend', '-m', description],), ''),
959 ((['git', 'log', '--pretty=format:%s\n\n%b',
960 determined_ancestor_revision + '..HEAD'],),
961 post_amend_description)
962 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000963 if squash:
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000964 if not issue:
965 # Prompting to edit description on first upload.
966 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200967 ((['git', 'config', 'core.editor'],), ''),
968 ((['RunEditor'],), description),
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000969 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000970 ref_to_push = 'abcdef0123456789'
971 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200972 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
973 ((['git', 'config', 'branch.master.remote'],), 'origin'),
974 ]
975
976 if custom_cl_base is None:
977 calls += [
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000978 ((['get_or_create_merge_base', 'master',
979 'refs/remotes/origin/master'],),
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000980 'origin/master'),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200981 ]
982 parent = 'origin/master'
983 else:
984 calls += [
985 ((['git', 'merge-base', '--is-ancestor', custom_cl_base,
986 'refs/remotes/origin/master'],),
987 callError(1)), # Means not ancenstor.
988 (('ask_for_data',
989 'Do you take responsibility for cleaning up potential mess '
990 'resulting from proceeding with upload? Press Enter to upload, '
991 'or Ctrl+C to abort'), ''),
992 ]
993 parent = custom_cl_base
994
995 calls += [
996 ((['git', 'rev-parse', 'HEAD:'],), # `HEAD:` means HEAD's tree hash.
997 '0123456789abcdef'),
998 ((['git', 'commit-tree', '0123456789abcdef', '-p', parent,
Aaron Gable9a03ae02017-11-03 11:31:07 -0700999 '-F', '/tmp/named'],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001000 ref_to_push),
1001 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001002 else:
1003 ref_to_push = 'HEAD'
1004
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001005 calls += [
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +00001006 (('SaveDescriptionBackup',), None),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001007 ((['git', 'rev-list',
1008 (custom_cl_base if custom_cl_base else expected_upstream_ref) + '..' +
1009 ref_to_push],),
1010 '1hashPerLine\n'),
1011 ]
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001012
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001013 metrics_arguments = []
1014
Aaron Gableafd52772017-06-27 16:40:10 -07001015 if notify:
Aaron Gable844cf292017-06-28 11:32:59 -07001016 ref_suffix = '%ready,notify=ALL'
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001017 metrics_arguments += ['ready', 'notify=ALL']
Aaron Gable844cf292017-06-28 11:32:59 -07001018 else:
Jamie Madill276da0b2018-04-27 14:41:20 -04001019 if not issue and squash:
Aaron Gable844cf292017-06-28 11:32:59 -07001020 ref_suffix = '%wip'
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001021 metrics_arguments.append('wip')
Aaron Gable844cf292017-06-28 11:32:59 -07001022 else:
1023 ref_suffix = '%notify=NONE'
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001024 metrics_arguments.append('notify=NONE')
Aaron Gable9b713dd2016-12-14 16:04:21 -08001025
Aaron Gable70f4e242017-06-26 10:45:59 -07001026 if title:
Aaron Gableafd52772017-06-27 16:40:10 -07001027 ref_suffix += ',m=' + title
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001028 metrics_arguments.append('m')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001029
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00001030 calls += [
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +00001031 ((['git', 'config', 'rietveld.cc'],), ''),
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00001032 ]
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001033 if short_hostname == 'chromium':
1034 # All reviwers and ccs get into ref_suffix.
1035 for r in sorted(reviewers):
1036 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001037 metrics_arguments.append('r')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001038 for c in sorted(['chromium-reviews+test-more-cc@chromium.org',
1039 'joe@example.com'] + cc):
1040 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001041 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001042 reviewers, cc = [], []
1043 else:
1044 # TODO(crbug/877717): remove this case.
1045 calls += [
1046 (('ValidAccounts', '%s-review.googlesource.com' % short_hostname,
1047 sorted(reviewers) + ['joe@example.com',
1048 'chromium-reviews+test-more-cc@chromium.org'] + cc),
1049 {
1050 e: {'email': e}
1051 for e in (reviewers + ['joe@example.com'] + cc)
1052 })
1053 ]
1054 for r in sorted(reviewers):
1055 if r != 'bad-account-or-email':
1056 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001057 metrics_arguments.append('r')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001058 reviewers.remove(r)
1059 for c in sorted(['joe@example.com'] + cc):
1060 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001061 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001062 if c in cc:
1063 cc.remove(c)
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00001064
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001065 if not tbr:
1066 for k, v in sorted((labels or {}).items()):
1067 ref_suffix += ',l=%s+%d' % (k, v)
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001068 metrics_arguments.append('l=%s+%d' % (k, v))
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001069
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001070 calls += [
1071 (('time.time',), 1000,),
1072 ((['git', 'push',
1073 'https://%s.googlesource.com/my/repo' % short_hostname,
1074 ref_to_push + ':refs/for/refs/heads/master' + ref_suffix],),
1075 (('remote:\n'
1076 'remote: Processing changes: (\)\n'
1077 'remote: Processing changes: (|)\n'
1078 'remote: Processing changes: (/)\n'
1079 'remote: Processing changes: (-)\n'
1080 'remote: Processing changes: new: 1 (/)\n'
1081 'remote: Processing changes: new: 1, done\n'
1082 'remote:\n'
1083 'remote: New Changes:\n'
1084 'remote: https://%s-review.googlesource.com/#/c/my/repo/+/123456'
1085 ' XXX\n'
1086 'remote:\n'
1087 'To https://%s.googlesource.com/my/repo\n'
1088 ' * [new branch] hhhh -> refs/for/refs/heads/master\n'
1089 ) % (short_hostname, short_hostname)),),
1090 (('time.time',), 2000,),
1091 (('add_repeated',
1092 'sub_commands',
1093 {
1094 'execution_time': 1000,
1095 'command': 'git push',
1096 'exit_code': 0,
1097 'arguments': sorted(metrics_arguments),
1098 }),
1099 None,),
1100 ]
1101
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001102 if squash:
1103 calls += [
tandrii33a46ff2016-08-23 05:53:40 -07001104 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001105 ''),
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001106 ((['git', 'config', 'branch.master.gerritserver',
tandrii5d48c322016-08-18 16:19:37 -07001107 'https://chromium-review.googlesource.com'],), ''),
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001108 ((['git', 'config', 'branch.master.gerritsquashhash',
1109 'abcdef0123456789'],), ''),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001110 ]
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001111 # TODO(crbug/877717): this should never be used.
1112 if squash and short_hostname != 'chromium':
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001113 calls += [
1114 (('AddReviewers',
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00001115 'chromium-review.googlesource.com', 'my%2Frepo~123456',
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001116 sorted(reviewers),
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00001117 cc + ['chromium-reviews+test-more-cc@chromium.org'],
1118 notify),
1119 ''),
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001120 ]
Aaron Gablefd238082017-06-07 13:42:34 -07001121 if tbr:
1122 calls += [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001123 (('GetChangeDetail', 'chromium-review.googlesource.com',
1124 'my%2Frepo~123456', ['LABELS']), {
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001125 'labels': {
1126 'Code-Review': {
1127 'default_value': 0,
1128 'all': [],
1129 'values': {
1130 '+2': 'lgtm, approved',
1131 '+1': 'lgtm, but someone else must approve',
1132 ' 0': 'No score',
1133 '-1': 'Don\'t submit as-is',
1134 }
1135 }
1136 }
1137 }),
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001138 (('SetReview',
1139 'chromium-review.googlesource.com',
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00001140 'my%2Frepo~123456',
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001141 'Self-approving for TBR',
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001142 {'Code-Review': 2}, None), ''),
Aaron Gablefd238082017-06-07 13:42:34 -07001143 ]
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +00001144 calls += cls._git_post_upload_calls()
ukai@chromium.orge8077812012-02-03 03:41:46 +00001145 return calls
1146
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001147 def _run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001148 self,
1149 upload_args,
1150 description,
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001151 reviewers=None,
tandriia60502f2016-06-20 02:01:53 -07001152 squash=True,
1153 squash_mode=None,
tandrii@chromium.org10625002016-03-04 20:03:47 +00001154 expected_upstream_ref='origin/refs/heads/master',
Aaron Gable9b713dd2016-12-14 16:04:21 -08001155 title=None,
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001156 notify=False,
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001157 post_amend_description=None,
bradnelsond975b302016-10-23 12:20:23 -07001158 issue=None,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +01001159 cc=None,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001160 fetched_status=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001161 other_cl_owner=None,
Aaron Gablefd238082017-06-07 13:42:34 -07001162 custom_cl_base=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001163 tbr=None,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001164 short_hostname='chromium',
1165 labels=None):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001166 """Generic gerrit upload test framework."""
tandriia60502f2016-06-20 02:01:53 -07001167 if squash_mode is None:
1168 if '--no-squash' in upload_args:
1169 squash_mode = 'nosquash'
1170 elif '--squash' in upload_args:
1171 squash_mode = 'squash'
1172 else:
1173 squash_mode = 'default'
1174
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001175 reviewers = reviewers or []
bradnelsond975b302016-10-23 12:20:23 -07001176 cc = cc or []
tandrii@chromium.org28253532016-04-14 13:46:56 +00001177 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii16e0b4e2016-06-07 10:34:28 -07001178 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001179 CookiesAuthenticatorMockFactory(
1180 same_auth=('git-owner.example.com', '', 'pass')))
tandrii16e0b4e2016-06-07 10:34:28 -07001181 self.mock(git_cl._GerritChangelistImpl, '_GerritCommitMsgHookCheck',
1182 lambda _, offer_removal: None)
tandriia60502f2016-06-20 02:01:53 -07001183 self.mock(git_cl.gclient_utils, 'RunEditor',
1184 lambda *_, **__: self._mocked_call(['RunEditor']))
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001185 self.mock(git_cl, 'DownloadGerritHook', lambda force: self._mocked_call(
1186 'DownloadGerritHook', force))
tandriia60502f2016-06-20 02:01:53 -07001187
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001188 self.calls = self._gerrit_base_calls(
1189 issue=issue,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001190 fetched_description=description,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001191 fetched_status=fetched_status,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001192 other_cl_owner=other_cl_owner,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001193 custom_cl_base=custom_cl_base,
1194 short_hostname=short_hostname)
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001195 if fetched_status != 'ABANDONED':
Aaron Gable9a03ae02017-11-03 11:31:07 -07001196 self.mock(tempfile, 'NamedTemporaryFile', MakeNamedTemporaryFileMock(
1197 expected_content=description))
1198 self.mock(os, 'remove', lambda _: True)
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001199 self.calls += self._gerrit_upload_calls(
1200 description, reviewers, squash,
1201 squash_mode=squash_mode,
1202 expected_upstream_ref=expected_upstream_ref,
Aaron Gablefd238082017-06-07 13:42:34 -07001203 title=title, notify=notify,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001204 post_amend_description=post_amend_description,
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001205 issue=issue, cc=cc,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001206 custom_cl_base=custom_cl_base, tbr=tbr,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001207 short_hostname=short_hostname,
1208 labels=labels)
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001209 # Uncomment when debugging.
1210 # print '\n'.join(map(lambda x: '%2i: %s' % x, enumerate(self.calls)))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001211 git_cl.main(['upload'] + upload_args)
1212
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001213 def test_gerrit_upload_without_change_id(self):
tandriia60502f2016-06-20 02:01:53 -07001214 self._run_gerrit_upload_test(
1215 ['--no-squash'],
1216 'desc\n\nBUG=\n',
1217 [],
1218 squash=False,
1219 post_amend_description='desc\n\nBUG=\n\nChange-Id: Ixxx')
1220
1221 def test_gerrit_upload_without_change_id_override_nosquash(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001222 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001223 [],
jamesr@chromium.org35d1a842012-07-27 00:20:43 +00001224 'desc\n\nBUG=\n',
tandrii@chromium.org10625002016-03-04 20:03:47 +00001225 [],
tandriia60502f2016-06-20 02:01:53 -07001226 squash=False,
1227 squash_mode='override_nosquash',
tandrii@chromium.org10625002016-03-04 20:03:47 +00001228 post_amend_description='desc\n\nBUG=\n\nChange-Id: Ixxx')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001229
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001230 def test_gerrit_no_reviewer(self):
1231 self._run_gerrit_upload_test(
1232 [],
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001233 'desc\n\nBUG=\n\nChange-Id: I123456789\n',
tandriia60502f2016-06-20 02:01:53 -07001234 [],
1235 squash=False,
1236 squash_mode='override_nosquash')
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001237
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001238 def test_gerrit_no_reviewer_non_chromium_host(self):
1239 # TODO(crbug/877717): remove this test case.
1240 self._run_gerrit_upload_test(
1241 [],
1242 'desc\n\nBUG=\n\nChange-Id: I123456789\n',
1243 [],
1244 squash=False,
1245 squash_mode='override_nosquash',
1246 short_hostname='other')
1247
Nick Carter8692b182017-11-06 16:30:38 -08001248 def test_gerrit_patchset_title_special_chars(self):
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001249 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
1250 self._run_gerrit_upload_test(
Nick Carter8692b182017-11-06 16:30:38 -08001251 ['-f', '-t', 'We\'ll escape ^_ ^ special chars...@{u}'],
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001252 'desc\n\nBUG=\n\nChange-Id: I123456789',
1253 squash=False,
1254 squash_mode='override_nosquash',
Nick Carter8692b182017-11-06 16:30:38 -08001255 title='We%27ll_escape_%5E%5F_%5E_special_chars%2E%2E%2E%40%7Bu%7D')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001256
ukai@chromium.orge8077812012-02-03 03:41:46 +00001257 def test_gerrit_reviewers_cmd_line(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001258 self._run_gerrit_upload_test(
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001259 ['-r', 'foo@example.com', '--send-mail'],
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001260 'desc\n\nBUG=\n\nChange-Id: I123456789',
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001261 ['foo@example.com'],
tandriia60502f2016-06-20 02:01:53 -07001262 squash=False,
1263 squash_mode='override_nosquash',
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001264 notify=True)
ukai@chromium.orge8077812012-02-03 03:41:46 +00001265
1266 def test_gerrit_reviewer_multiple(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001267 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001268 [],
bradnelsond975b302016-10-23 12:20:23 -07001269 'desc\nTBR=reviewer@example.com\nBUG=\nR=another@example.com\n'
1270 'CC=more@example.com,people@example.com\n\n'
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001271 'Change-Id: 123456789',
tandriia60502f2016-06-20 02:01:53 -07001272 ['reviewer@example.com', 'another@example.com'],
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001273 expected_upstream_ref='origin/master',
Aaron Gablefd238082017-06-07 13:42:34 -07001274 cc=['more@example.com', 'people@example.com'],
1275 tbr='reviewer@example.com')
tandriia60502f2016-06-20 02:01:53 -07001276
1277 def test_gerrit_upload_squash_first_is_default(self):
tandriia60502f2016-06-20 02:01:53 -07001278 self._run_gerrit_upload_test(
1279 [],
1280 'desc\nBUG=\n\nChange-Id: 123456789',
1281 [],
1282 expected_upstream_ref='origin/master')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001283
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001284 def test_gerrit_upload_squash_first(self):
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001285 self._run_gerrit_upload_test(
1286 ['--squash'],
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001287 'desc\nBUG=\n\nChange-Id: 123456789',
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001288 [],
luqui@chromium.org609f3952015-05-04 22:47:04 +00001289 squash=True,
1290 expected_upstream_ref='origin/master')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001291
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001292 def test_gerrit_upload_squash_first_with_labels(self):
1293 self._run_gerrit_upload_test(
1294 ['--squash', '--cq-dry-run', '--enable-auto-submit'],
1295 'desc\nBUG=\n\nChange-Id: 123456789',
1296 [],
1297 squash=True,
1298 expected_upstream_ref='origin/master',
1299 labels={'Commit-Queue': 1, 'Auto-Submit': 1})
1300
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001301 def test_gerrit_upload_squash_first_against_rev(self):
1302 custom_cl_base = 'custom_cl_base_rev_or_branch'
1303 self._run_gerrit_upload_test(
1304 ['--squash', custom_cl_base],
1305 'desc\nBUG=\n\nChange-Id: 123456789',
1306 [],
1307 squash=True,
1308 expected_upstream_ref='origin/master',
1309 custom_cl_base=custom_cl_base)
1310 self.assertIn(
1311 'If you proceed with upload, more than 1 CL may be created by Gerrit',
1312 sys.stdout.getvalue())
1313
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001314 def test_gerrit_upload_squash_reupload(self):
1315 description = 'desc\nBUG=\n\nChange-Id: 123456789'
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001316 self._run_gerrit_upload_test(
1317 ['--squash'],
1318 description,
1319 [],
1320 squash=True,
1321 expected_upstream_ref='origin/master',
1322 issue=123456)
1323
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001324 def test_gerrit_upload_squash_reupload_to_abandoned(self):
1325 self.mock(git_cl, 'DieWithError',
1326 lambda msg, change=None: self._mocked_call('DieWithError', msg))
1327 description = 'desc\nBUG=\n\nChange-Id: 123456789'
1328 with self.assertRaises(SystemExitMock):
1329 self._run_gerrit_upload_test(
1330 ['--squash'],
1331 description,
1332 [],
1333 squash=True,
1334 expected_upstream_ref='origin/master',
1335 issue=123456,
1336 fetched_status='ABANDONED')
1337
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001338 def test_gerrit_upload_squash_reupload_to_not_owned(self):
1339 self.mock(git_cl.gerrit_util, 'GetAccountDetails',
1340 lambda *_, **__: {'email': 'yet-another@example.com'})
1341 description = 'desc\nBUG=\n\nChange-Id: 123456789'
1342 self._run_gerrit_upload_test(
1343 ['--squash'],
1344 description,
1345 [],
1346 squash=True,
1347 expected_upstream_ref='origin/master',
1348 issue=123456,
1349 other_cl_owner='other@example.com')
1350 self.assertIn(
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001351 'WARNING: Change 123456 is owned by other@example.com, but you '
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001352 'authenticate to Gerrit as yet-another@example.com.\n'
1353 'Uploading may fail due to lack of permissions',
1354 git_cl.sys.stdout.getvalue())
1355
rmistry@google.com2dd99862015-06-22 12:22:18 +00001356 def test_upload_branch_deps(self):
tandrii@chromium.org28253532016-04-14 13:46:56 +00001357 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
rmistry@google.com2dd99862015-06-22 12:22:18 +00001358 def mock_run_git(*args, **_kwargs):
1359 if args[0] == ['for-each-ref',
1360 '--format=%(refname:short) %(upstream:short)',
1361 'refs/heads']:
1362 # Create a local branch dependency tree that looks like this:
1363 # test1 -> test2 -> test3 -> test4 -> test5
1364 # -> test3.1
1365 # test6 -> test0
1366 branch_deps = [
1367 'test2 test1', # test1 -> test2
1368 'test3 test2', # test2 -> test3
1369 'test3.1 test2', # test2 -> test3.1
1370 'test4 test3', # test3 -> test4
1371 'test5 test4', # test4 -> test5
1372 'test6 test0', # test0 -> test6
1373 'test7', # test7
1374 ]
1375 return '\n'.join(branch_deps)
1376 self.mock(git_cl, 'RunGit', mock_run_git)
1377
1378 class RecordCalls:
1379 times_called = 0
1380 record_calls = RecordCalls()
1381 def mock_CMDupload(*args, **_kwargs):
1382 record_calls.times_called += 1
1383 return 0
1384 self.mock(git_cl, 'CMDupload', mock_CMDupload)
1385
1386 self.calls = [
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001387 (('ask_for_data', 'This command will checkout all dependent branches '
1388 'and run "git cl upload". Press Enter to continue, '
1389 'or Ctrl+C to abort'), ''),
1390 ]
rmistry@google.com2dd99862015-06-22 12:22:18 +00001391
1392 class MockChangelist():
1393 def __init__(self):
1394 pass
1395 def GetBranch(self):
1396 return 'test1'
1397 def GetIssue(self):
1398 return '123'
1399 def GetPatchset(self):
1400 return '1001'
tandrii@chromium.org4c72b082016-03-31 22:26:35 +00001401 def IsGerrit(self):
1402 return False
rmistry@google.com2dd99862015-06-22 12:22:18 +00001403
1404 ret = git_cl.upload_branch_deps(MockChangelist(), [])
1405 # CMDupload should have been called 5 times because of 5 dependent branches.
1406 self.assertEquals(5, record_calls.times_called)
1407 self.assertEquals(0, ret)
1408
tandrii@chromium.org65874e12016-03-04 12:03:02 +00001409 def test_gerrit_change_id(self):
1410 self.calls = [
1411 ((['git', 'write-tree'], ),
1412 'hashtree'),
1413 ((['git', 'rev-parse', 'HEAD~0'], ),
1414 'branch-parent'),
1415 ((['git', 'var', 'GIT_AUTHOR_IDENT'], ),
1416 'A B <a@b.org> 1456848326 +0100'),
1417 ((['git', 'var', 'GIT_COMMITTER_IDENT'], ),
1418 'C D <c@d.org> 1456858326 +0100'),
1419 ((['git', 'hash-object', '-t', 'commit', '--stdin'], ),
1420 'hashchange'),
1421 ]
1422 change_id = git_cl.GenerateGerritChangeId('line1\nline2\n')
1423 self.assertEqual(change_id, 'Ihashchange')
1424
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00001425 def test_desecription_append_footer(self):
1426 for init_desc, footer_line, expected_desc in [
1427 # Use unique desc first lines for easy test failure identification.
1428 ('foo', 'R=one', 'foo\n\nR=one'),
1429 ('foo\n\nR=one', 'BUG=', 'foo\n\nR=one\nBUG='),
1430 ('foo\n\nR=one', 'Change-Id: Ixx', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1431 ('foo\n\nChange-Id: Ixx', 'R=one', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1432 ('foo\n\nR=one\n\nChange-Id: Ixx', 'TBR=two',
1433 'foo\n\nR=one\nTBR=two\n\nChange-Id: Ixx'),
1434 ('foo\n\nR=one\n\nChange-Id: Ixx', 'Foo-Bar: baz',
1435 'foo\n\nR=one\n\nChange-Id: Ixx\nFoo-Bar: baz'),
1436 ('foo\n\nChange-Id: Ixx', 'Foo-Bak: baz',
1437 'foo\n\nChange-Id: Ixx\nFoo-Bak: baz'),
1438 ('foo', 'Change-Id: Ixx', 'foo\n\nChange-Id: Ixx'),
1439 ]:
1440 desc = git_cl.ChangeDescription(init_desc)
1441 desc.append_footer(footer_line)
1442 self.assertEqual(desc.description, expected_desc)
1443
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001444 def test_update_reviewers(self):
1445 data = [
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001446 ('foo', [], [],
1447 'foo'),
1448 ('foo\nR=xx', [], [],
1449 'foo\nR=xx'),
1450 ('foo\nTBR=xx', [], [],
1451 'foo\nTBR=xx'),
1452 ('foo', ['a@c'], [],
1453 'foo\n\nR=a@c'),
1454 ('foo\nR=xx', ['a@c'], [],
1455 'foo\n\nR=a@c, xx'),
1456 ('foo\nTBR=xx', ['a@c'], [],
1457 'foo\n\nR=a@c\nTBR=xx'),
1458 ('foo\nTBR=xx\nR=yy', ['a@c'], [],
1459 'foo\n\nR=a@c, yy\nTBR=xx'),
1460 ('foo\nBUG=', ['a@c'], [],
1461 'foo\nBUG=\nR=a@c'),
1462 ('foo\nR=xx\nTBR=yy\nR=bar', ['a@c'], [],
1463 'foo\n\nR=a@c, bar, xx\nTBR=yy'),
1464 ('foo', ['a@c', 'b@c'], [],
1465 'foo\n\nR=a@c, b@c'),
1466 ('foo\nBar\n\nR=\nBUG=', ['c@c'], [],
1467 'foo\nBar\n\nR=c@c\nBUG='),
1468 ('foo\nBar\n\nR=\nBUG=\nR=', ['c@c'], [],
1469 'foo\nBar\n\nR=c@c\nBUG='),
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001470 # Same as the line before, but full of whitespaces.
1471 (
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001472 'foo\nBar\n\n R = \n BUG = \n R = ', ['c@c'], [],
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001473 'foo\nBar\n\nR=c@c\n BUG =',
1474 ),
1475 # Whitespaces aren't interpreted as new lines.
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001476 ('foo BUG=allo R=joe ', ['c@c'], [],
1477 'foo BUG=allo R=joe\n\nR=c@c'),
1478 # Redundant TBRs get promoted to Rs
1479 ('foo\n\nR=a@c\nTBR=t@c', ['b@c', 'a@c'], ['a@c', 't@c'],
1480 'foo\n\nR=a@c, b@c\nTBR=t@c'),
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001481 ]
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001482 expected = [i[-1] for i in data]
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001483 actual = []
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001484 for orig, reviewers, tbrs, _expected in data:
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001485 obj = git_cl.ChangeDescription(orig)
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001486 obj.update_reviewers(reviewers, tbrs)
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001487 actual.append(obj.description)
1488 self.assertEqual(expected, actual)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001489
Nodir Turakulov23b82142017-11-16 11:04:25 -08001490 def test_get_hash_tags(self):
1491 cases = [
1492 ('', []),
1493 ('a', []),
1494 ('[a]', ['a']),
1495 ('[aa]', ['aa']),
1496 ('[a ]', ['a']),
1497 ('[a- ]', ['a']),
1498 ('[a- b]', ['a-b']),
1499 ('[a--b]', ['a-b']),
1500 ('[a', []),
1501 ('[a]x', ['a']),
1502 ('[aa]x', ['aa']),
1503 ('[a b]', ['a-b']),
1504 ('[a b]', ['a-b']),
1505 ('[a__b]', ['a-b']),
1506 ('[a] x', ['a']),
1507 ('[a][b]', ['a', 'b']),
1508 ('[a] [b]', ['a', 'b']),
1509 ('[a][b]x', ['a', 'b']),
1510 ('[a][b] x', ['a', 'b']),
1511 ('[a]\n[b]', ['a']),
1512 ('[a\nb]', []),
1513 ('[a][', ['a']),
1514 ('Revert "[a] feature"', ['a']),
1515 ('Reland "[a] feature"', ['a']),
1516 ('Revert: [a] feature', ['a']),
1517 ('Reland: [a] feature', ['a']),
1518 ('Revert "Reland: [a] feature"', ['a']),
1519 ('Foo: feature', ['foo']),
1520 ('Foo Bar: feature', ['foo-bar']),
1521 ('Revert "Foo bar: feature"', ['foo-bar']),
1522 ('Reland "Foo bar: feature"', ['foo-bar']),
1523 ]
1524 for desc, expected in cases:
1525 change_desc = git_cl.ChangeDescription(desc)
1526 actual = change_desc.get_hash_tags()
1527 self.assertEqual(
1528 actual,
1529 expected,
1530 'GetHashTags(%r) == %r, expected %r' % (desc, actual, expected))
1531
wittman@chromium.org455dc922015-01-26 20:15:50 +00001532 def test_get_target_ref(self):
1533 # Check remote or remote branch not present.
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001534 self.assertEqual(None, git_cl.GetTargetRef('origin', None, 'master'))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001535 self.assertEqual(None, git_cl.GetTargetRef(None,
1536 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001537 'master'))
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001538
wittman@chromium.org455dc922015-01-26 20:15:50 +00001539 # Check default target refs for branches.
1540 self.assertEqual('refs/heads/master',
1541 git_cl.GetTargetRef('origin', 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001542 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001543 self.assertEqual('refs/heads/master',
1544 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkgr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001545 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001546 self.assertEqual('refs/heads/master',
1547 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkcr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001548 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001549 self.assertEqual('refs/branch-heads/123',
1550 git_cl.GetTargetRef('origin',
1551 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001552 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001553 self.assertEqual('refs/diff/test',
1554 git_cl.GetTargetRef('origin',
1555 'refs/remotes/origin/refs/diff/test',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001556 None))
rmistry@google.comc68112d2015-03-03 12:48:06 +00001557 self.assertEqual('refs/heads/chrome/m42',
1558 git_cl.GetTargetRef('origin',
1559 'refs/remotes/origin/chrome/m42',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001560 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001561
1562 # Check target refs for user-specified target branch.
1563 for branch in ('branch-heads/123', 'remotes/branch-heads/123',
1564 'refs/remotes/branch-heads/123'):
1565 self.assertEqual('refs/branch-heads/123',
1566 git_cl.GetTargetRef('origin',
1567 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001568 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001569 for branch in ('origin/master', 'remotes/origin/master',
1570 'refs/remotes/origin/master'):
1571 self.assertEqual('refs/heads/master',
1572 git_cl.GetTargetRef('origin',
1573 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001574 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001575 for branch in ('master', 'heads/master', 'refs/heads/master'):
1576 self.assertEqual('refs/heads/master',
1577 git_cl.GetTargetRef('origin',
1578 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001579 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001580
wychen@chromium.orga872e752015-04-28 23:42:18 +00001581 def test_patch_when_dirty(self):
1582 # Patch when local tree is dirty
1583 self.mock(git_common, 'is_dirty_git_tree', lambda x: True)
1584 self.assertNotEqual(git_cl.main(['patch', '123456']), 0)
1585
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001586 @staticmethod
1587 def _get_gerrit_codereview_server_calls(branch, value=None,
1588 git_short_host='host',
Aaron Gable697a91b2018-01-19 15:20:15 -08001589 detect_branch=True,
1590 detect_server=True):
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001591 """Returns calls executed by _GerritChangelistImpl.GetCodereviewServer.
1592
1593 If value is given, branch.<BRANCH>.gerritcodereview is already set.
1594 """
1595 calls = []
1596 if detect_branch:
1597 calls.append(((['git', 'symbolic-ref', 'HEAD'],), branch))
Aaron Gable697a91b2018-01-19 15:20:15 -08001598 if detect_server:
1599 calls.append(((['git', 'config', 'branch.' + branch + '.gerritserver'],),
1600 CERR1 if value is None else value))
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001601 if value is None:
1602 calls += [
1603 ((['git', 'config', 'branch.' + branch + '.merge'],),
1604 'refs/heads' + branch),
1605 ((['git', 'config', 'branch.' + branch + '.remote'],),
1606 'origin'),
1607 ((['git', 'config', 'remote.origin.url'],),
1608 'https://%s.googlesource.com/my/repo' % git_short_host),
1609 ]
1610 return calls
1611
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001612 def _patch_common(self, force_codereview=False,
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001613 new_branch=False, git_short_host='host',
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001614 detect_gerrit_server=False,
1615 actual_codereview=None,
1616 codereview_in_url=False):
tandrii@chromium.org28253532016-04-14 13:46:56 +00001617 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001618 self.mock(git_cl._RietveldChangelistImpl, 'GetMostRecentPatchset',
1619 lambda x: '60001')
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001620 self.mock(git_cl._RietveldChangelistImpl, 'FetchDescription',
Kenneth Russell61e2ed42017-02-15 11:47:13 -08001621 lambda *a, **kw: 'Description')
wychen@chromium.orga872e752015-04-28 23:42:18 +00001622 self.mock(git_cl, 'IsGitVersionAtLeast', lambda *args: True)
1623
tandriidf09a462016-08-18 16:23:55 -07001624 if new_branch:
1625 self.calls = [((['git', 'new-branch', 'master'],), ''),]
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001626
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001627 if codereview_in_url and actual_codereview == 'rietveld':
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001628 self.calls += [
1629 ((['git', 'rev-parse', '--show-cdup'],), ''),
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001630 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001631 ]
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001632
1633 if not force_codereview and not codereview_in_url:
1634 # These calls detect codereview to use.
1635 self.calls += [
1636 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
1637 ((['git', 'config', 'branch.master.rietveldissue'],), CERR1),
1638 ((['git', 'config', 'branch.master.gerritissue'],), CERR1),
1639 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
1640 ((['git', 'config', 'gerrit.host'],), 'true'),
1641 ]
1642 if detect_gerrit_server:
1643 self.calls += self._get_gerrit_codereview_server_calls(
1644 'master', git_short_host=git_short_host,
1645 detect_branch=not new_branch and force_codereview)
1646 actual_codereview = 'gerrit'
1647
1648 if actual_codereview == 'gerrit':
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001649 self.calls += [
1650 (('GetChangeDetail', git_short_host + '-review.googlesource.com',
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001651 'my%2Frepo~123456', ['ALL_REVISIONS', 'CURRENT_COMMIT']),
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001652 {
1653 'current_revision': '7777777777',
1654 'revisions': {
1655 '1111111111': {
1656 '_number': 1,
1657 'fetch': {'http': {
1658 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1659 'ref': 'refs/changes/56/123456/1',
1660 }},
1661 },
1662 '7777777777': {
1663 '_number': 7,
1664 'fetch': {'http': {
1665 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1666 'ref': 'refs/changes/56/123456/7',
1667 }},
1668 },
1669 },
1670 }),
1671 ]
wychen@chromium.orga872e752015-04-28 23:42:18 +00001672
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001673 def test_patch_gerrit_default(self):
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001674 self._patch_common(git_short_host='chromium', detect_gerrit_server=True)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001675 self.calls += [
1676 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1677 'refs/changes/56/123456/7'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001678 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001679 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
Aaron Gable697a91b2018-01-19 15:20:15 -08001680 ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001681 ((['git', 'config', 'branch.master.gerritserver',
1682 'https://chromium-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001683 ((['git', 'config', 'branch.master.gerritpatchset', '7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001684 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1685 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1686 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001687 ]
1688 self.assertEqual(git_cl.main(['patch', '123456']), 0)
1689
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001690 def test_patch_gerrit_new_branch(self):
1691 self._patch_common(
1692 git_short_host='chromium', detect_gerrit_server=True, new_branch=True)
1693 self.calls += [
1694 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1695 'refs/changes/56/123456/7'],), ''),
1696 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
1697 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
1698 ''),
1699 ((['git', 'config', 'branch.master.gerritserver',
1700 'https://chromium-review.googlesource.com'],), ''),
1701 ((['git', 'config', 'branch.master.gerritpatchset', '7'],), ''),
1702 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1703 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1704 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
1705 ]
1706 self.assertEqual(git_cl.main(['patch', '-b', 'master', '123456']), 0)
1707
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001708 def test_patch_gerrit_force(self):
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001709 self._patch_common(
1710 force_codereview=True, git_short_host='host', detect_gerrit_server=True)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001711 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001712 ((['git', 'fetch', 'https://host.googlesource.com/my/repo',
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001713 'refs/changes/56/123456/7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001714 ((['git', 'reset', '--hard', 'FETCH_HEAD'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001715 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001716 ''),
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001717 ((['git', 'config', 'branch.master.gerritserver',
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001718 'https://host-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001719 ((['git', 'config', 'branch.master.gerritpatchset', '7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001720 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1721 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1722 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001723 ]
Aaron Gable62619a32017-06-16 08:22:09 -07001724 self.assertEqual(git_cl.main(['patch', '--gerrit', '123456', '--force']), 0)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001725
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001726 def test_patch_gerrit_guess_by_url(self):
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001727 self.calls += self._get_gerrit_codereview_server_calls(
1728 'master', git_short_host='else', detect_server=False)
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001729 self._patch_common(
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001730 actual_codereview='gerrit', git_short_host='else',
1731 codereview_in_url=True, detect_gerrit_server=False)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001732 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001733 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001734 'refs/changes/56/123456/1'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001735 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001736 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001737 ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001738 ((['git', 'config', 'branch.master.gerritserver',
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001739 'https://else-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001740 ((['git', 'config', 'branch.master.gerritpatchset', '1'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001741 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1742 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1743 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001744 ]
1745 self.assertEqual(git_cl.main(
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001746 ['patch', 'https://else-review.googlesource.com/#/c/123456/1']), 0)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001747
Aaron Gable697a91b2018-01-19 15:20:15 -08001748 def test_patch_gerrit_guess_by_url_with_repo(self):
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001749 self.calls += self._get_gerrit_codereview_server_calls(
1750 'master', git_short_host='else', detect_server=False)
Aaron Gable697a91b2018-01-19 15:20:15 -08001751 self._patch_common(
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001752 actual_codereview='gerrit', git_short_host='else',
1753 codereview_in_url=True, detect_gerrit_server=False)
Aaron Gable697a91b2018-01-19 15:20:15 -08001754 self.calls += [
1755 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
1756 'refs/changes/56/123456/1'],), ''),
1757 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
1758 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
1759 ''),
1760 ((['git', 'config', 'branch.master.gerritserver',
1761 'https://else-review.googlesource.com'],), ''),
1762 ((['git', 'config', 'branch.master.gerritpatchset', '1'],), ''),
1763 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1764 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1765 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
1766 ]
1767 self.assertEqual(git_cl.main(
1768 ['patch', 'https://else-review.googlesource.com/c/my/repo/+/123456/1']),
1769 0)
1770
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001771 def test_patch_gerrit_conflict(self):
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001772 self._patch_common(detect_gerrit_server=True, git_short_host='chromium')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001773 self.calls += [
1774 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001775 'refs/changes/56/123456/7'],), ''),
tandrii5d48c322016-08-18 16:19:37 -07001776 ((['git', 'cherry-pick', 'FETCH_HEAD'],), CERR1),
1777 ((['DieWithError', 'Command "git cherry-pick FETCH_HEAD" failed.\n'],),
1778 SystemExitMock()),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001779 ]
1780 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001781 git_cl.main(['patch', '123456'])
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001782
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001783 def test_patch_gerrit_not_exists(self):
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01001784 def notExists(_issue, *_, **kwargs):
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01001785 raise git_cl.gerrit_util.GerritError(404, '')
1786 self.mock(git_cl.gerrit_util, 'GetChangeDetail', notExists)
1787
tandriic2405f52016-10-10 08:13:15 -07001788 self.calls = [
1789 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
tandriic2405f52016-10-10 08:13:15 -07001790 ((['git', 'config', 'branch.master.rietveldissue'],), CERR1),
1791 ((['git', 'config', 'branch.master.gerritissue'],), CERR1),
1792 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
1793 ((['git', 'config', 'gerrit.host'],), 'true'),
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001794 ((['git', 'config', 'branch.master.gerritserver'],), CERR1),
1795 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
1796 ((['git', 'config', 'branch.master.remote'],), 'origin'),
1797 ((['git', 'config', 'remote.origin.url'],),
1798 'https://chromium.googlesource.com/my/repo'),
1799 ((['DieWithError',
1800 'change 123456 at https://chromium-review.googlesource.com does not '
1801 'exist or you have no access to it'],), SystemExitMock()),
tandriic2405f52016-10-10 08:13:15 -07001802 ]
1803 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001804 self.assertEqual(1, git_cl.main(['patch', '123456']))
tandriic2405f52016-10-10 08:13:15 -07001805
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001806 def _checkout_calls(self):
1807 return [
1808 ((['git', 'config', '--local', '--get-regexp',
1809 'branch\\..*\\.rietveldissue'], ),
1810 ('branch.retrying.rietveldissue 1111111111\n'
1811 'branch.some-fix.rietveldissue 2222222222\n')),
1812 ((['git', 'config', '--local', '--get-regexp',
1813 'branch\\..*\\.gerritissue'], ),
1814 ('branch.ger-branch.gerritissue 123456\n'
1815 'branch.gbranch654.gerritissue 654321\n')),
1816 ]
1817
1818 def test_checkout_gerrit(self):
1819 """Tests git cl checkout <issue>."""
1820 self.calls = self._checkout_calls()
1821 self.calls += [((['git', 'checkout', 'ger-branch'], ), '')]
1822 self.assertEqual(0, git_cl.main(['checkout', '123456']))
1823
1824 def test_checkout_rietveld(self):
1825 """Tests git cl checkout <issue>."""
1826 self.calls = self._checkout_calls()
1827 self.calls += [((['git', 'checkout', 'some-fix'], ), '')]
1828 self.assertEqual(0, git_cl.main(['checkout', '2222222222']))
1829
1830 def test_checkout_not_found(self):
1831 """Tests git cl checkout <issue>."""
tandrii@chromium.org28253532016-04-14 13:46:56 +00001832 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001833 self.calls = self._checkout_calls()
1834 self.assertEqual(1, git_cl.main(['checkout', '99999']))
1835
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001836 def test_checkout_no_branch_issues(self):
1837 """Tests git cl checkout <issue>."""
tandrii@chromium.org28253532016-04-14 13:46:56 +00001838 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001839 self.calls = [
1840 ((['git', 'config', '--local', '--get-regexp',
tandrii5d48c322016-08-18 16:19:37 -07001841 'branch\\..*\\.rietveldissue'], ), CERR1),
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001842 ((['git', 'config', '--local', '--get-regexp',
tandrii5d48c322016-08-18 16:19:37 -07001843 'branch\\..*\\.gerritissue'], ), CERR1),
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001844 ]
1845 self.assertEqual(1, git_cl.main(['checkout', '99999']))
1846
tandrii@chromium.org28253532016-04-14 13:46:56 +00001847 def _test_gerrit_ensure_authenticated_common(self, auth,
1848 skip_auth_check=False):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001849 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
1850 CookiesAuthenticatorMockFactory(hosts_with_creds=auth))
1851 self.mock(git_cl, 'DieWithError',
Christopher Lamf732cd52017-01-24 12:40:11 +11001852 lambda msg, change=None: self._mocked_call(['DieWithError', msg]))
tandrii@chromium.org28253532016-04-14 13:46:56 +00001853 self.calls = self._gerrit_ensure_auth_calls(skip_auth_check=skip_auth_check)
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001854 cl = git_cl.Changelist(codereview='gerrit')
tandrii@chromium.org28253532016-04-14 13:46:56 +00001855 cl.branch = 'master'
1856 cl.branchref = 'refs/heads/master'
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001857 cl.lookedup_issue = True
1858 return cl
1859
1860 def test_gerrit_ensure_authenticated_missing(self):
1861 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001862 'chromium.googlesource.com': ('git-is.ok', '', 'but gerrit is missing'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001863 })
1864 self.calls.append(
1865 ((['DieWithError',
1866 'Credentials for the following hosts are required:\n'
1867 ' chromium-review.googlesource.com\n'
1868 'These are read from ~/.gitcookies (or legacy ~/.netrc)\n'
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01001869 'You can (re)generate your credentials by visiting '
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001870 'https://chromium-review.googlesource.com/new-password'],), ''),)
1871 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1872
1873 def test_gerrit_ensure_authenticated_conflict(self):
tandrii@chromium.org28253532016-04-14 13:46:56 +00001874 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001875 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001876 'chromium.googlesource.com':
1877 ('git-one.example.com', None, 'secret1'),
1878 'chromium-review.googlesource.com':
1879 ('git-other.example.com', None, 'secret2'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001880 })
1881 self.calls.append(
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001882 (('ask_for_data', 'If you know what you are doing '
1883 'press Enter to continue, or Ctrl+C to abort'), ''))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001884 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1885
1886 def test_gerrit_ensure_authenticated_ok(self):
1887 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001888 'chromium.googlesource.com':
1889 ('git-same.example.com', None, 'secret'),
1890 'chromium-review.googlesource.com':
1891 ('git-same.example.com', None, 'secret'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001892 })
1893 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1894
tandrii@chromium.org28253532016-04-14 13:46:56 +00001895 def test_gerrit_ensure_authenticated_skipped(self):
1896 cl = self._test_gerrit_ensure_authenticated_common(
1897 auth={}, skip_auth_check=True)
1898 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1899
Eric Boren2fb63102018-10-05 13:05:03 +00001900 def test_gerrit_ensure_authenticated_bearer_token(self):
1901 cl = self._test_gerrit_ensure_authenticated_common(auth={
1902 'chromium.googlesource.com':
1903 ('', None, 'secret'),
1904 'chromium-review.googlesource.com':
1905 ('', None, 'secret'),
1906 })
1907 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1908 header = gerrit_util.CookiesAuthenticator().get_auth_header(
1909 'chromium.googlesource.com')
1910 self.assertTrue('Bearer' in header)
1911
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01001912 def _cmd_set_commit_gerrit_common(self, vote, notify=None):
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001913 self.mock(git_cl.gerrit_util, 'SetReview',
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01001914 lambda h, i, labels, notify=None:
1915 self._mocked_call(['SetReview', h, i, labels, notify]))
1916
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001917 self.calls = [
1918 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07001919 ((['git', 'config', 'branch.feature.rietveldissue'],), CERR1),
1920 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001921 ((['git', 'config', 'branch.feature.gerritserver'],),
1922 'https://chromium-review.googlesource.com'),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00001923 ((['git', 'config', 'branch.feature.merge'],), 'refs/heads/master'),
1924 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
1925 ((['git', 'config', 'remote.origin.url'],),
1926 'https://chromium.googlesource.com/infra/infra.git'),
1927 ((['SetReview', 'chromium-review.googlesource.com',
1928 'infra%2Finfra~123',
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01001929 {'Commit-Queue': vote}, notify],), ''),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001930 ]
tandriid9e5ce52016-07-13 02:32:59 -07001931
1932 def test_cmd_set_commit_gerrit_clear(self):
1933 self._cmd_set_commit_gerrit_common(0)
1934 self.assertEqual(0, git_cl.main(['set-commit', '-c']))
1935
1936 def test_cmd_set_commit_gerrit_dry(self):
Aaron Gable75e78722017-06-09 10:40:16 -07001937 self._cmd_set_commit_gerrit_common(1, notify=False)
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001938 self.assertEqual(0, git_cl.main(['set-commit', '-d']))
1939
tandriid9e5ce52016-07-13 02:32:59 -07001940 def test_cmd_set_commit_gerrit(self):
1941 self._cmd_set_commit_gerrit_common(2)
1942 self.assertEqual(0, git_cl.main(['set-commit']))
1943
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001944 def test_description_display(self):
1945 out = StringIO.StringIO()
1946 self.mock(git_cl.sys, 'stdout', out)
1947
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00001948 self.mock(git_cl, 'Changelist', ChangelistMock)
1949 ChangelistMock.desc = 'foo\n'
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001950
1951 self.assertEqual(0, git_cl.main(['description', '-d']))
1952 self.assertEqual('foo\n', out.getvalue())
1953
iannucci3c972b92016-08-17 13:24:10 -07001954 def test_StatusFieldOverrideIssueMissingArgs(self):
1955 out = StringIO.StringIO()
1956 self.mock(git_cl.sys, 'stderr', out)
1957
1958 try:
1959 self.assertEqual(git_cl.main(['status', '--issue', '1']), 0)
1960 except SystemExit as ex:
1961 self.assertEqual(ex.code, 2)
iannuccie53c9352016-08-17 14:40:40 -07001962 self.assertRegexpMatches(out.getvalue(), r'--issue must be specified')
iannucci3c972b92016-08-17 13:24:10 -07001963
1964 out = StringIO.StringIO()
1965 self.mock(git_cl.sys, 'stderr', out)
1966
1967 try:
Andrii Shyshkalovfeec80e2018-10-16 01:00:47 +00001968 self.assertEqual(git_cl.main(['status', '--issue', '1', '--gerrit']), 0)
iannucci3c972b92016-08-17 13:24:10 -07001969 except SystemExit as ex:
1970 self.assertEqual(ex.code, 2)
iannuccie53c9352016-08-17 14:40:40 -07001971 self.assertRegexpMatches(out.getvalue(), r'--field must be specified')
iannucci3c972b92016-08-17 13:24:10 -07001972
1973 def test_StatusFieldOverrideIssue(self):
1974 out = StringIO.StringIO()
1975 self.mock(git_cl.sys, 'stdout', out)
1976
1977 def assertIssue(cl_self, *_args):
1978 self.assertEquals(cl_self.issue, 1)
1979 return 'foobar'
1980
1981 self.mock(git_cl.Changelist, 'GetDescription', assertIssue)
iannuccie53c9352016-08-17 14:40:40 -07001982 self.assertEqual(
Andrii Shyshkalovfeec80e2018-10-16 01:00:47 +00001983 git_cl.main(['status', '--issue', '1', '--gerrit', '--field', 'desc']),
iannuccie53c9352016-08-17 14:40:40 -07001984 0)
iannucci3c972b92016-08-17 13:24:10 -07001985 self.assertEqual(out.getvalue(), 'foobar\n')
1986
iannuccie53c9352016-08-17 14:40:40 -07001987 def test_SetCloseOverrideIssue(self):
1988 def assertIssue(cl_self, *_args):
1989 self.assertEquals(cl_self.issue, 1)
1990 return 'foobar'
1991
1992 self.mock(git_cl.Changelist, 'GetDescription', assertIssue)
1993 self.mock(git_cl.Changelist, 'CloseIssue', lambda *_: None)
iannuccie53c9352016-08-17 14:40:40 -07001994 self.assertEqual(
Andrii Shyshkalovfeec80e2018-10-16 01:00:47 +00001995 git_cl.main(['set-close', '--issue', '1', '--gerrit']), 0)
iannuccie53c9352016-08-17 14:40:40 -07001996
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00001997 def test_description(self):
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001998 out = StringIO.StringIO()
1999 self.mock(git_cl.sys, 'stdout', out)
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01002000 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002001 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2002 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2003 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2004 ((['git', 'config', 'remote.origin.url'],),
2005 'https://chromium.googlesource.com/my/repo'),
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00002006 (('GetChangeDetail', 'chromium-review.googlesource.com',
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002007 'my%2Frepo~123123', ['CURRENT_REVISION', 'CURRENT_COMMIT']),
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01002008 {
2009 'current_revision': 'sha1',
2010 'revisions': {'sha1': {
2011 'commit': {'message': 'foobar'},
2012 }},
2013 }),
2014 ]
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002015 self.assertEqual(0, git_cl.main([
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00002016 'description',
2017 'https://chromium-review.googlesource.com/c/my/repo/+/123123',
2018 '-d']))
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002019 self.assertEqual('foobar\n', out.getvalue())
2020
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002021 def test_description_set_raw(self):
2022 out = StringIO.StringIO()
2023 self.mock(git_cl.sys, 'stdout', out)
2024
2025 self.mock(git_cl, 'Changelist', ChangelistMock)
2026 self.mock(git_cl.sys, 'stdin', StringIO.StringIO('hihi'))
2027
2028 self.assertEqual(0, git_cl.main(['description', '-n', 'hihi']))
2029 self.assertEqual('hihi', ChangelistMock.desc)
2030
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002031 def test_description_appends_bug_line(self):
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002032 current_desc = 'Some.\n\nChange-Id: xxx'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002033
2034 def RunEditor(desc, _, **kwargs):
2035 self.assertEquals(
2036 '# Enter a description of the change.\n'
2037 '# This will be displayed on the codereview site.\n'
2038 '# The first line will also be used as the subject of the review.\n'
2039 '#--------------------This line is 72 characters long'
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002040 '--------------------\n'
Aaron Gable3a16ed12017-03-23 10:51:55 -07002041 'Some.\n\nChange-Id: xxx\nBug: ',
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002042 desc)
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002043 # Simulate user changing something.
Aaron Gable3a16ed12017-03-23 10:51:55 -07002044 return 'Some.\n\nChange-Id: xxx\nBug: 123'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002045
dsansomee2d6fd92016-09-08 00:10:47 -07002046 def UpdateDescriptionRemote(_, desc, force=False):
Aaron Gable3a16ed12017-03-23 10:51:55 -07002047 self.assertEquals(desc, 'Some.\n\nChange-Id: xxx\nBug: 123')
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002048
2049 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2050 self.mock(git_cl.Changelist, 'GetDescription',
2051 lambda *args: current_desc)
2052 self.mock(git_cl._GerritChangelistImpl, 'UpdateDescriptionRemote',
2053 UpdateDescriptionRemote)
2054 self.mock(git_cl.gclient_utils, 'RunEditor', RunEditor)
2055
2056 self.calls = [
2057 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07002058 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
tandrii5d48c322016-08-18 16:19:37 -07002059 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
2060 ((['git', 'config', 'rietveld.bug-prefix'],), CERR1),
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002061 ((['git', 'config', 'core.editor'],), 'vi'),
2062 ]
2063 self.assertEqual(0, git_cl.main(['description', '--gerrit']))
2064
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002065 def test_description_set_stdin(self):
2066 out = StringIO.StringIO()
2067 self.mock(git_cl.sys, 'stdout', out)
2068
2069 self.mock(git_cl, 'Changelist', ChangelistMock)
2070 self.mock(git_cl.sys, 'stdin', StringIO.StringIO('hi \r\n\t there\n\nman'))
2071
2072 self.assertEqual(0, git_cl.main(['description', '-n', '-']))
2073 self.assertEqual('hi\n\t there\n\nman', ChangelistMock.desc)
2074
kmarshall3bff56b2016-06-06 18:31:47 -07002075 def test_archive(self):
tandrii1c67da62016-06-10 07:35:53 -07002076 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2077
kmarshall3bff56b2016-06-06 18:31:47 -07002078 self.calls = \
2079 [((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2080 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
tandrii33a46ff2016-08-23 05:53:40 -07002081 ((['git', 'config', 'branch.master.rietveldissue'],), '1'),
tandrii5d48c322016-08-18 16:19:37 -07002082 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
2083 ((['git', 'config', 'rietveld.server'],), 'codereview.example.com'),
tandrii33a46ff2016-08-23 05:53:40 -07002084 ((['git', 'config', 'branch.foo.rietveldissue'],), '456'),
2085 ((['git', 'config', 'branch.bar.rietveldissue'],), CERR1),
2086 ((['git', 'config', 'branch.bar.gerritissue'],), '789'),
kmarshall3bff56b2016-06-06 18:31:47 -07002087 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2088 ((['git', 'tag', 'git-cl-archived-456-foo', 'foo'],), ''),
2089 ((['git', 'branch', '-D', 'foo'],), '')]
2090
kmarshall3bff56b2016-06-06 18:31:47 -07002091 self.mock(git_cl, 'get_cl_statuses',
2092 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002093 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2094 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2095 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
kmarshall3bff56b2016-06-06 18:31:47 -07002096
2097 self.assertEqual(0, git_cl.main(['archive', '-f']))
2098
2099 def test_archive_current_branch_fails(self):
tandrii1c67da62016-06-10 07:35:53 -07002100 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
kmarshall3bff56b2016-06-06 18:31:47 -07002101 self.calls = \
2102 [((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2103 'refs/heads/master'),
tandrii33a46ff2016-08-23 05:53:40 -07002104 ((['git', 'config', 'branch.master.rietveldissue'],), '1'),
tandrii5d48c322016-08-18 16:19:37 -07002105 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
2106 ((['git', 'config', 'rietveld.server'],), 'codereview.example.com'),
kmarshall3bff56b2016-06-06 18:31:47 -07002107 ((['git', 'symbolic-ref', 'HEAD'],), 'master')]
2108
kmarshall9249e012016-08-23 12:02:16 -07002109 self.mock(git_cl, 'get_cl_statuses',
2110 lambda branches, fine_grained, max_processes:
2111 [(MockChangelistWithBranchAndIssue('master', 1), 'closed')])
2112
2113 self.assertEqual(1, git_cl.main(['archive', '-f']))
2114
2115 def test_archive_dry_run(self):
2116 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2117
2118 self.calls = \
2119 [((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2120 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
2121 ((['git', 'config', 'branch.master.rietveldissue'],), '1'),
2122 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
2123 ((['git', 'config', 'rietveld.server'],), 'codereview.example.com'),
2124 ((['git', 'config', 'branch.foo.rietveldissue'],), '456'),
2125 ((['git', 'config', 'branch.bar.rietveldissue'],), CERR1),
2126 ((['git', 'config', 'branch.bar.gerritissue'],), '789'),
2127 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),]
kmarshall3bff56b2016-06-06 18:31:47 -07002128
2129 self.mock(git_cl, 'get_cl_statuses',
2130 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002131 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2132 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2133 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
kmarshall3bff56b2016-06-06 18:31:47 -07002134
kmarshall9249e012016-08-23 12:02:16 -07002135 self.assertEqual(0, git_cl.main(['archive', '-f', '--dry-run']))
2136
2137 def test_archive_no_tags(self):
2138 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2139
2140 self.calls = \
2141 [((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2142 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
2143 ((['git', 'config', 'branch.master.rietveldissue'],), '1'),
2144 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
2145 ((['git', 'config', 'rietveld.server'],), 'codereview.example.com'),
2146 ((['git', 'config', 'branch.foo.rietveldissue'],), '456'),
2147 ((['git', 'config', 'branch.bar.rietveldissue'],), CERR1),
2148 ((['git', 'config', 'branch.bar.gerritissue'],), '789'),
2149 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2150 ((['git', 'branch', '-D', 'foo'],), '')]
2151
2152 self.mock(git_cl, 'get_cl_statuses',
2153 lambda branches, fine_grained, max_processes:
2154 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2155 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2156 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
2157
2158 self.assertEqual(0, git_cl.main(['archive', '-f', '--notags']))
kmarshall3bff56b2016-06-06 18:31:47 -07002159
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002160 def test_cmd_issue_erase_existing(self):
2161 out = StringIO.StringIO()
2162 self.mock(git_cl.sys, 'stdout', out)
2163 self.calls = [
2164 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07002165 ((['git', 'config', 'branch.feature.rietveldissue'],), CERR1),
2166 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002167 # Let this command raise exception (retcode=1) - it should be ignored.
2168 ((['git', 'config', '--unset', 'branch.feature.last-upload-hash'],),
tandrii5d48c322016-08-18 16:19:37 -07002169 CERR1),
2170 ((['git', 'config', '--unset', 'branch.feature.gerritissue'],), ''),
2171 ((['git', 'config', '--unset', 'branch.feature.gerritpatchset'],), ''),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002172 ((['git', 'config', '--unset', 'branch.feature.gerritserver'],), ''),
2173 ((['git', 'config', '--unset', 'branch.feature.gerritsquashhash'],),
2174 ''),
Aaron Gableca01e2c2017-07-19 11:16:02 -07002175 ((['git', 'log', '-1', '--format=%B'],), 'This is a description'),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002176 ]
2177 self.assertEqual(0, git_cl.main(['issue', '0']))
2178
Aaron Gable400e9892017-07-12 15:31:21 -07002179 def test_cmd_issue_erase_existing_with_change_id(self):
2180 out = StringIO.StringIO()
2181 self.mock(git_cl.sys, 'stdout', out)
2182 self.mock(git_cl.Changelist, 'GetDescription',
2183 lambda _: 'This is a description\n\nChange-Id: Ideadbeef')
2184 self.calls = [
2185 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2186 ((['git', 'config', 'branch.feature.rietveldissue'],), CERR1),
2187 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
Aaron Gable400e9892017-07-12 15:31:21 -07002188 # Let this command raise exception (retcode=1) - it should be ignored.
2189 ((['git', 'config', '--unset', 'branch.feature.last-upload-hash'],),
2190 CERR1),
2191 ((['git', 'config', '--unset', 'branch.feature.gerritissue'],), ''),
2192 ((['git', 'config', '--unset', 'branch.feature.gerritpatchset'],), ''),
2193 ((['git', 'config', '--unset', 'branch.feature.gerritserver'],), ''),
2194 ((['git', 'config', '--unset', 'branch.feature.gerritsquashhash'],),
2195 ''),
Aaron Gableca01e2c2017-07-19 11:16:02 -07002196 ((['git', 'log', '-1', '--format=%B'],),
2197 'This is a description\n\nChange-Id: Ideadbeef'),
2198 ((['git', 'commit', '--amend', '-m', 'This is a description\n'],), ''),
Aaron Gable400e9892017-07-12 15:31:21 -07002199 ]
2200 self.assertEqual(0, git_cl.main(['issue', '0']))
2201
phajdan.jre328cf92016-08-22 04:12:17 -07002202 def test_cmd_issue_json(self):
2203 out = StringIO.StringIO()
2204 self.mock(git_cl.sys, 'stdout', out)
2205 self.calls = [
2206 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07002207 ((['git', 'config', 'branch.feature.rietveldissue'],), '123'),
phajdan.jre328cf92016-08-22 04:12:17 -07002208 ((['git', 'config', 'rietveld.autoupdate'],), ''),
2209 ((['git', 'config', 'rietveld.server'],),
2210 'https://codereview.chromium.org'),
2211 ((['git', 'config', 'branch.feature.rietveldserver'],), ''),
2212 (('write_json', 'output.json',
2213 {'issue': 123, 'issue_url': 'https://codereview.chromium.org/123'}),
2214 ''),
2215 ]
2216 self.assertEqual(0, git_cl.main(['issue', '--json', 'output.json']))
2217
tandrii8c5a3532016-11-04 07:52:02 -07002218 def test_git_cl_try_default_cq_dry_run_gerrit(self):
2219 self.mock(git_cl.Changelist, 'GetChange',
2220 lambda _, *a: (
2221 self._mocked_call(['GetChange']+list(a))))
2222 self.mock(git_cl.presubmit_support, 'DoGetTryMasters',
2223 lambda *_, **__: (
2224 self._mocked_call(['DoGetTryMasters'])))
2225 self.mock(git_cl._GerritChangelistImpl, 'SetCQState',
2226 lambda _, s: self._mocked_call(['SetCQState', s]))
2227
tandrii8c5a3532016-11-04 07:52:02 -07002228 self.calls = [
2229 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2230 ((['git', 'config', 'branch.feature.rietveldissue'],), CERR1),
2231 ((['git', 'config', 'branch.feature.gerritissue'],), '123456'),
2232 ((['git', 'config', 'branch.feature.gerritserver'],),
2233 'https://chromium-review.googlesource.com'),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002234 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2235 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2236 ((['git', 'config', 'remote.origin.url'],),
2237 'https://chromium.googlesource.com/depot_tools'),
2238 (('GetChangeDetail', 'chromium-review.googlesource.com',
2239 'depot_tools~123456',
Andrii Shyshkaloveadad922017-01-26 09:38:30 +01002240 ['DETAILED_ACCOUNTS', 'ALL_REVISIONS', 'CURRENT_COMMIT']), {
2241 'project': 'depot_tools',
2242 'status': 'OPEN',
2243 'owner': {'email': 'owner@e.mail'},
2244 'revisions': {
2245 'deadbeaf': {
2246 '_number': 6,
2247 },
2248 'beeeeeef': {
2249 '_number': 7,
2250 'fetch': {'http': {
2251 'url': 'https://chromium.googlesource.com/depot_tools',
2252 'ref': 'refs/changes/56/123456/7'
2253 }},
2254 },
2255 },
2256 }),
tandrii8c5a3532016-11-04 07:52:02 -07002257 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2258 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2259 ((['get_or_create_merge_base', 'feature', 'feature'],),
2260 'fake_ancestor_sha'),
2261 ((['GetChange', 'fake_ancestor_sha', None], ),
2262 git_cl.presubmit_support.GitChange(
2263 '', '', '', '', '', '', '', '')),
2264 ((['git', 'rev-parse', '--show-cdup'],), '../'),
2265 ((['DoGetTryMasters'], ), None),
2266 ((['SetCQState', git_cl._CQState.DRY_RUN], ), None),
2267 ]
2268 out = StringIO.StringIO()
2269 self.mock(git_cl.sys, 'stdout', out)
2270 self.assertEqual(0, git_cl.main(['try']))
2271 self.assertEqual(
2272 out.getvalue(),
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07002273 'Scheduling CQ dry run on: '
tandrii8c5a3532016-11-04 07:52:02 -07002274 'https://chromium-review.googlesource.com/123456\n')
2275
tandrii8c5a3532016-11-04 07:52:02 -07002276 def test_git_cl_try_buildbucket_with_properties_gerrit(self):
2277 self.mock(git_cl.Changelist, 'GetMostRecentPatchset', lambda _: 7)
2278 self.mock(git_cl.uuid, 'uuid4', lambda: 'uuid4')
2279
tandrii8c5a3532016-11-04 07:52:02 -07002280 self.calls = [
2281 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2282 ((['git', 'config', 'branch.feature.rietveldissue'],), CERR1),
2283 ((['git', 'config', 'branch.feature.gerritissue'],), '123456'),
2284 ((['git', 'config', 'branch.feature.gerritserver'],),
2285 'https://chromium-review.googlesource.com'),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002286 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2287 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2288 ((['git', 'config', 'remote.origin.url'],),
2289 'https://chromium.googlesource.com/depot_tools'),
2290 (('GetChangeDetail', 'chromium-review.googlesource.com',
2291 'depot_tools~123456',
Andrii Shyshkaloveadad922017-01-26 09:38:30 +01002292 ['DETAILED_ACCOUNTS', 'ALL_REVISIONS', 'CURRENT_COMMIT']), {
tandrii8c5a3532016-11-04 07:52:02 -07002293 'project': 'depot_tools',
Andrii Shyshkaloveadad922017-01-26 09:38:30 +01002294 'status': 'OPEN',
2295 'owner': {'email': 'owner@e.mail'},
tandrii8c5a3532016-11-04 07:52:02 -07002296 'revisions': {
2297 'deadbeaf': {
2298 '_number': 6,
2299 },
2300 'beeeeeef': {
2301 '_number': 7,
2302 'fetch': {'http': {
2303 'url': 'https://chromium.googlesource.com/depot_tools',
2304 'ref': 'refs/changes/56/123456/7'
2305 }},
2306 },
2307 },
2308 }),
2309 ]
2310
2311 def _buildbucket_retry(*_, **kw):
2312 # self.maxDiff = 10000
2313 body = json.loads(kw['body'])
2314 self.assertEqual(len(body['builds']), 1)
2315 build = body['builds'][0]
2316 params = json.loads(build.pop('parameters_json'))
2317 self.assertEqual(params, {
2318 u'builder_name': u'win',
2319 u'changes': [{u'author': {u'email': u'owner@e.mail'},
2320 u'revision': None}],
2321 u'properties': {
2322 u'category': u'git_cl_try',
2323 u'key': u'val',
2324 u'json': [{u'a': 1}, None],
tandrii8c5a3532016-11-04 07:52:02 -07002325
2326 u'patch_gerrit_url':
2327 u'https://chromium-review.googlesource.com',
2328 u'patch_issue': 123456,
2329 u'patch_project': u'depot_tools',
2330 u'patch_ref': u'refs/changes/56/123456/7',
2331 u'patch_repository_url':
2332 u'https://chromium.googlesource.com/depot_tools',
2333 u'patch_set': 7,
2334 u'patch_storage': u'gerrit',
2335 }
2336 })
2337 self.assertEqual(build, {
Andrii Shyshkalov03da1502018-10-15 03:42:34 +00002338 u'bucket': u'luci.chromium.try',
tandrii8c5a3532016-11-04 07:52:02 -07002339 u'client_operation_id': u'uuid4',
2340 u'tags': [
2341 u'builder:win',
2342 u'buildset:patch/gerrit/chromium-review.googlesource.com/123456/7',
2343 u'user_agent:git_cl_try',
Andrii Shyshkalov03da1502018-10-15 03:42:34 +00002344 ],
tandrii8c5a3532016-11-04 07:52:02 -07002345 })
2346
2347 self.mock(git_cl, '_buildbucket_retry', _buildbucket_retry)
2348
2349 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2350 self.assertEqual(0, git_cl.main([
Andrii Shyshkalov03da1502018-10-15 03:42:34 +00002351 'try', '-B', 'luci.chromium.try', '-b', 'win',
tandrii8c5a3532016-11-04 07:52:02 -07002352 '-p', 'key=val', '-p', 'json=[{"a":1}, null]']))
2353 self.assertRegexpMatches(
2354 git_cl.sys.stdout.getvalue(),
Andrii Shyshkalov03da1502018-10-15 03:42:34 +00002355 'Tried jobs on:\nBucket: luci.chromium.try')
tandriide281ae2016-10-12 06:02:30 -07002356
qyearsley123a4682016-10-26 09:12:17 -07002357 def test_git_cl_try_bots_on_multiple_masters(self):
Andrii Shyshkalovf5569d22018-10-15 03:35:23 +00002358 self.mock(git_cl.Changelist, 'GetMostRecentPatchset', lambda _: 7)
2359 self.mock(git_cl.Changelist, 'GetChange',
2360 lambda _, *a: (
2361 self._mocked_call(['GetChange']+list(a))))
2362 self.mock(git_cl.presubmit_support, 'DoGetTryMasters',
2363 lambda *_, **__: (
2364 self._mocked_call(['DoGetTryMasters'])))
2365 self.mock(git_cl._GerritChangelistImpl, 'SetCQState',
2366 lambda _, s: self._mocked_call(['SetCQState', s]))
2367
qyearsley123a4682016-10-26 09:12:17 -07002368 self.calls = [
2369 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
Andrii Shyshkalovf5569d22018-10-15 03:35:23 +00002370 ((['git', 'config', 'branch.feature.rietveldissue'],), CERR1),
2371 ((['git', 'config', 'branch.feature.gerritissue'],), '123456'),
2372 ((['git', 'config', 'branch.feature.gerritserver'],),
2373 'https://chromium-review.googlesource.com'),
2374 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2375 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2376 ((['git', 'config', 'remote.origin.url'],),
2377 'https://chromium.googlesource.com/depot_tools'),
2378 (('GetChangeDetail', 'chromium-review.googlesource.com',
2379 'depot_tools~123456',
2380 ['DETAILED_ACCOUNTS', 'ALL_REVISIONS', 'CURRENT_COMMIT']), {
2381 'project': 'depot_tools',
2382 'status': 'OPEN',
2383 'owner': {'email': 'owner@e.mail'},
2384 'revisions': {
2385 'deadbeaf': {
2386 '_number': 6,
2387 },
2388 'beeeeeef': {
2389 '_number': 7,
2390 'fetch': {'http': {
2391 'url': 'https://chromium.googlesource.com/depot_tools',
2392 'ref': 'refs/changes/56/123456/7'
2393 }},
2394 },
2395 },
2396 }),
qyearsley123a4682016-10-26 09:12:17 -07002397 ]
2398
2399 def _buildbucket_retry(*_, **kw):
2400 body = json.loads(kw['body'])
2401 self.assertEqual(len(body['builds']), 2)
2402
Nodir Turakulovb422e682018-02-20 22:51:30 -08002403 self.assertEqual(body['builds'][0]['bucket'], 'bucket1')
2404 params = json.loads(body['builds'][0]['parameters_json'])
2405 self.assertEqual(params['builder_name'], 'builder1')
qyearsley123a4682016-10-26 09:12:17 -07002406
Nodir Turakulovb422e682018-02-20 22:51:30 -08002407 self.assertEqual(body['builds'][1]['bucket'], 'bucket2')
2408 params = json.loads(body['builds'][1]['parameters_json'])
2409 self.assertEqual(params['builder_name'], 'builder2')
qyearsley123a4682016-10-26 09:12:17 -07002410
2411 self.mock(git_cl, '_buildbucket_retry', _buildbucket_retry)
2412
2413 self.mock(git_cl.urllib2, 'urlopen', lambda _: StringIO.StringIO(
Nodir Turakulovb422e682018-02-20 22:51:30 -08002414 json.dumps({
2415 'builder1': {'bucket': 'bucket1'},
2416 'builder2': {'bucket': 'bucket2'},
2417 })))
qyearsley123a4682016-10-26 09:12:17 -07002418
2419 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2420 self.assertEqual(
2421 0, git_cl.main(['try', '-b', 'builder1', '-b', 'builder2']))
2422 self.assertEqual(
2423 git_cl.sys.stdout.getvalue(),
2424 'Tried jobs on:\n'
Nodir Turakulovb422e682018-02-20 22:51:30 -08002425 'Bucket: bucket1\n'
qyearsley123a4682016-10-26 09:12:17 -07002426 ' builder1: []\n'
Nodir Turakulovb422e682018-02-20 22:51:30 -08002427 'Bucket: bucket2\n'
qyearsley123a4682016-10-26 09:12:17 -07002428 ' builder2: []\n'
2429 'To see results here, run: git cl try-results\n'
2430 'To see results in browser, run: git cl web\n')
2431
tandrii16e0b4e2016-06-07 10:34:28 -07002432 def _common_GerritCommitMsgHookCheck(self):
2433 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2434 self.mock(git_cl.os.path, 'abspath',
2435 lambda path: self._mocked_call(['abspath', path]))
2436 self.mock(git_cl.os.path, 'exists',
2437 lambda path: self._mocked_call(['exists', path]))
2438 self.mock(git_cl.gclient_utils, 'FileRead',
2439 lambda path: self._mocked_call(['FileRead', path]))
2440 self.mock(git_cl.gclient_utils, 'rm_file_or_tree',
2441 lambda path: self._mocked_call(['rm_file_or_tree', path]))
2442 self.calls = [
2443 ((['git', 'rev-parse', '--show-cdup'],), '../'),
2444 ((['abspath', '../'],), '/abs/git_repo_root'),
2445 ]
2446 return git_cl.Changelist(codereview='gerrit', issue=123)
2447
2448 def test_GerritCommitMsgHookCheck_custom_hook(self):
2449 cl = self._common_GerritCommitMsgHookCheck()
2450 self.calls += [
2451 ((['exists', '/abs/git_repo_root/.git/hooks/commit-msg'],), True),
2452 ((['FileRead', '/abs/git_repo_root/.git/hooks/commit-msg'],),
2453 '#!/bin/sh\necho "custom hook"')
2454 ]
2455 cl._codereview_impl._GerritCommitMsgHookCheck(offer_removal=True)
2456
2457 def test_GerritCommitMsgHookCheck_not_exists(self):
2458 cl = self._common_GerritCommitMsgHookCheck()
2459 self.calls += [
2460 ((['exists', '/abs/git_repo_root/.git/hooks/commit-msg'],), False),
2461 ]
2462 cl._codereview_impl._GerritCommitMsgHookCheck(offer_removal=True)
2463
2464 def test_GerritCommitMsgHookCheck(self):
2465 cl = self._common_GerritCommitMsgHookCheck()
2466 self.calls += [
2467 ((['exists', '/abs/git_repo_root/.git/hooks/commit-msg'],), True),
2468 ((['FileRead', '/abs/git_repo_root/.git/hooks/commit-msg'],),
2469 '...\n# From Gerrit Code Review\n...\nadd_ChangeId()\n'),
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002470 (('ask_for_data', 'Do you want to remove it now? [Yes/No]: '), 'Yes'),
tandrii16e0b4e2016-06-07 10:34:28 -07002471 ((['rm_file_or_tree', '/abs/git_repo_root/.git/hooks/commit-msg'],),
2472 ''),
2473 ]
2474 cl._codereview_impl._GerritCommitMsgHookCheck(offer_removal=True)
2475
tandriic4344b52016-08-29 06:04:54 -07002476 def test_GerritCmdLand(self):
2477 self.calls += [
2478 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2479 ((['git', 'config', 'branch.feature.gerritsquashhash'],),
2480 'deadbeaf'),
2481 ((['git', 'diff', 'deadbeaf'],), ''), # No diff.
2482 ((['git', 'config', 'branch.feature.gerritserver'],),
2483 'chromium-review.googlesource.com'),
2484 ]
2485 cl = git_cl.Changelist(issue=123, codereview='gerrit')
2486 cl._codereview_impl._GetChangeDetail = lambda _: {
2487 'labels': {},
2488 'current_revision': 'deadbeaf',
2489 }
agable32978d92016-11-01 12:55:02 -07002490 cl._codereview_impl._GetChangeCommit = lambda: {
2491 'commit': 'deadbeef',
Aaron Gable02cdbb42016-12-13 16:24:25 -08002492 'web_links': [{'name': 'gitiles',
agable32978d92016-11-01 12:55:02 -07002493 'url': 'https://git.googlesource.com/test/+/deadbeef'}],
2494 }
tandriic4344b52016-08-29 06:04:54 -07002495 cl._codereview_impl.SubmitIssue = lambda wait_for_merge: None
tandrii8da412c2016-09-07 16:01:07 -07002496 out = StringIO.StringIO()
2497 self.mock(sys, 'stdout', out)
Olivier Robin75ee7252018-04-13 10:02:56 +02002498 self.assertEqual(0, cl.CMDLand(force=True,
2499 bypass_hooks=True,
2500 verbose=True,
2501 parallel=False))
tandrii8da412c2016-09-07 16:01:07 -07002502 self.assertRegexpMatches(out.getvalue(), 'Issue.*123 has been submitted')
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002503 self.assertRegexpMatches(out.getvalue(), 'Landed as: .*deadbeef')
tandriic4344b52016-08-29 06:04:54 -07002504
tandrii221ab252016-10-06 08:12:04 -07002505 BUILDBUCKET_BUILDS_MAP = {
Quinten Yearsleya563d722017-12-11 16:36:54 -08002506 '9000': {
2507 'id': '9000',
2508 'bucket': 'master.x.y',
2509 'created_by': 'user:someone@chromium.org',
2510 'created_ts': '147200002222000',
2511 'experimental': False,
2512 'parameters_json': json.dumps({
2513 'builder_name': 'my-bot',
2514 'properties': {'category': 'cq'},
2515 }),
2516 'status': 'STARTED',
2517 'tags': [
2518 'build_address:x.y/my-bot/2',
2519 'builder:my-bot',
2520 'experimental:false',
2521 'user_agent:cq',
2522 ],
2523 'url': 'http://build.cr.org/p/x.y/builders/my-bot/builds/2',
2524 },
2525 '8000': {
2526 'id': '8000',
2527 'bucket': 'master.x.y',
2528 'created_by': 'user:someone@chromium.org',
2529 'created_ts': '147200001111000',
2530 'experimental': False,
2531 'failure_reason': 'BUILD_FAILURE',
2532 'parameters_json': json.dumps({
2533 'builder_name': 'my-bot',
2534 'properties': {'category': 'cq'},
2535 }),
2536 'result_details_json': json.dumps({
2537 'properties': {'buildnumber': 1},
2538 }),
2539 'result': 'FAILURE',
2540 'status': 'COMPLETED',
2541 'tags': [
2542 'build_address:x.y/my-bot/1',
2543 'builder:my-bot',
2544 'experimental:false',
2545 'user_agent:cq',
2546 ],
2547 'url': 'http://build.cr.org/p/x.y/builders/my-bot/builds/1',
2548 },
2549 }
tandrii221ab252016-10-06 08:12:04 -07002550
2551 def test_write_try_results_json(self):
2552 expected_output = [
Quinten Yearsleya563d722017-12-11 16:36:54 -08002553 {
2554 'bucket': 'master.x.y',
2555 'buildbucket_id': '8000',
2556 'builder_name': 'my-bot',
2557 'created_ts': '147200001111000',
2558 'experimental': False,
2559 'failure_reason': 'BUILD_FAILURE',
2560 'result': 'FAILURE',
2561 'status': 'COMPLETED',
2562 'tags': [
2563 'build_address:x.y/my-bot/1',
2564 'builder:my-bot',
2565 'experimental:false',
2566 'user_agent:cq',
2567 ],
2568 'url': 'http://build.cr.org/p/x.y/builders/my-bot/builds/1',
2569 },
2570 {
2571 'bucket': 'master.x.y',
2572 'buildbucket_id': '9000',
2573 'builder_name': 'my-bot',
2574 'created_ts': '147200002222000',
2575 'experimental': False,
2576 'failure_reason': None,
2577 'result': None,
2578 'status': 'STARTED',
2579 'tags': [
2580 'build_address:x.y/my-bot/2',
2581 'builder:my-bot',
2582 'experimental:false',
2583 'user_agent:cq',
2584 ],
2585 'url': 'http://build.cr.org/p/x.y/builders/my-bot/builds/2',
2586 },
tandrii221ab252016-10-06 08:12:04 -07002587 ]
2588 self.calls = [(('write_json', 'output.json', expected_output), '')]
2589 git_cl.write_try_results_json('output.json', self.BUILDBUCKET_BUILDS_MAP)
2590
tandrii45b2a582016-10-11 03:14:16 -07002591 def _setup_fetch_try_jobs(self, most_recent_patchset=20001):
tandrii221ab252016-10-06 08:12:04 -07002592 out = StringIO.StringIO()
2593 self.mock(sys, 'stdout', out)
tandrii45b2a582016-10-11 03:14:16 -07002594 self.mock(git_cl.Changelist, 'GetMostRecentPatchset',
2595 lambda *args: most_recent_patchset)
tandrii221ab252016-10-06 08:12:04 -07002596 self.mock(git_cl.auth, 'get_authenticator_for_host', lambda host, _cfg:
2597 self._mocked_call(['get_authenticator_for_host', host]))
2598 self.mock(git_cl, '_buildbucket_retry', lambda *_, **__:
2599 self._mocked_call(['_buildbucket_retry']))
tandrii45b2a582016-10-11 03:14:16 -07002600
tandrii45b2a582016-10-11 03:14:16 -07002601 def _setup_fetch_try_jobs_gerrit(self, *request_results):
2602 self._setup_fetch_try_jobs(most_recent_patchset=13)
2603 self.calls += [
2604 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2605 ((['git', 'config', 'branch.feature.rietveldissue'],), CERR1),
2606 ((['git', 'config', 'branch.feature.gerritissue'],), '1'),
Ravi Mistryfda50ca2016-11-14 10:19:18 -05002607 # TODO(tandrii): Uncomment the below if we decide to support checking
2608 # patchsets for Gerrit.
tandrii45b2a582016-10-11 03:14:16 -07002609 # Simulate that Gerrit has more patchsets than local.
Ravi Mistryfda50ca2016-11-14 10:19:18 -05002610 # ((['git', 'config', 'branch.feature.gerritpatchset'],), '12'),
tandrii45b2a582016-10-11 03:14:16 -07002611 ((['git', 'config', 'branch.feature.gerritserver'],),
2612 'https://x-review.googlesource.com'),
2613 ((['get_authenticator_for_host', 'x-review.googlesource.com'],),
2614 AuthenticatorMock()),
2615 ] + [((['_buildbucket_retry'],), r) for r in request_results]
2616
2617 def test_fetch_try_jobs_none_gerrit(self):
2618 self._setup_fetch_try_jobs_gerrit({})
2619 self.assertEqual(0, git_cl.main(['try-results']))
Ravi Mistryfda50ca2016-11-14 10:19:18 -05002620 # TODO(tandrii): Uncomment the below if we decide to support checking
2621 # patchsets for Gerrit.
2622 # self.assertRegexpMatches(
2623 # sys.stdout.getvalue(),
2624 # r'Warning: Codereview server has newer patchsets \(13\)')
tandrii45b2a582016-10-11 03:14:16 -07002625 self.assertRegexpMatches(sys.stdout.getvalue(), 'No try jobs')
2626
2627 def test_fetch_try_jobs_some_gerrit(self):
2628 self._setup_fetch_try_jobs_gerrit({
2629 'builds': self.BUILDBUCKET_BUILDS_MAP.values(),
2630 })
Ravi Mistryfda50ca2016-11-14 10:19:18 -05002631 # TODO(tandrii): Uncomment the below if we decide to support checking
2632 # patchsets for Gerrit.
2633 # self.calls.remove(
2634 # ((['git', 'config', 'branch.feature.gerritpatchset'],), '12'))
tandrii45b2a582016-10-11 03:14:16 -07002635 self.assertEqual(0, git_cl.main(['try-results', '--patchset', '5']))
2636
2637 # ... and doesn't result in warning.
2638 self.assertNotRegexpMatches(sys.stdout.getvalue(), 'Warning')
2639 self.assertRegexpMatches(sys.stdout.getvalue(), '^Failures:')
tandrii221ab252016-10-06 08:12:04 -07002640 self.assertRegexpMatches(sys.stdout.getvalue(), 'Started:')
2641 self.assertRegexpMatches(sys.stdout.getvalue(), '2 try jobs')
2642
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002643 def _mock_gerrit_changes_for_detail_cache(self):
2644 self.mock(git_cl._GerritChangelistImpl, '_GetGerritHost', lambda _: 'host')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002645
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002646 def test_gerrit_change_detail_cache_simple(self):
2647 self._mock_gerrit_changes_for_detail_cache()
2648 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002649 (('GetChangeDetail', 'host', 'my%2Frepo~1', []), 'a'),
2650 (('GetChangeDetail', 'host', 'ab%2Frepo~2', []), 'b'),
2651 (('GetChangeDetail', 'host', 'ab%2Frepo~2', []), 'b2'),
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002652 ]
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00002653 cl1 = git_cl.Changelist(issue=1, codereview='gerrit')
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002654 cl1._cached_remote_url = (
2655 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00002656 cl2 = git_cl.Changelist(issue=2, codereview='gerrit')
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002657 cl2._cached_remote_url = (
2658 True, 'https://chromium.googlesource.com/ab/repo')
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00002659 self.assertEqual(cl1._GetChangeDetail(), 'a') # Miss.
2660 self.assertEqual(cl1._GetChangeDetail(), 'a')
2661 self.assertEqual(cl2._GetChangeDetail(), 'b') # Miss.
2662 self.assertEqual(cl2._GetChangeDetail(no_cache=True), 'b2') # Miss.
2663 self.assertEqual(cl1._GetChangeDetail(), 'a')
2664 self.assertEqual(cl2._GetChangeDetail(), 'b2')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002665
2666 def test_gerrit_change_detail_cache_options(self):
2667 self._mock_gerrit_changes_for_detail_cache()
2668 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002669 (('GetChangeDetail', 'host', 'repo~1', ['C', 'A', 'B']), 'cab'),
2670 (('GetChangeDetail', 'host', 'repo~1', ['A', 'D']), 'ad'),
2671 (('GetChangeDetail', 'host', 'repo~1', ['A']), 'a'), # no_cache=True
2672 # no longer in cache.
2673 (('GetChangeDetail', 'host', 'repo~1', ['B']), 'b'),
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002674 ]
2675 cl = git_cl.Changelist(issue=1, codereview='gerrit')
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002676 cl._cached_remote_url = (True, 'https://chromium.googlesource.com/repo/')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002677 self.assertEqual(cl._GetChangeDetail(options=['C', 'A', 'B']), 'cab')
2678 self.assertEqual(cl._GetChangeDetail(options=['A', 'B', 'C']), 'cab')
2679 self.assertEqual(cl._GetChangeDetail(options=['B', 'A']), 'cab')
2680 self.assertEqual(cl._GetChangeDetail(options=['C']), 'cab')
2681 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2682 self.assertEqual(cl._GetChangeDetail(), 'cab')
2683
2684 self.assertEqual(cl._GetChangeDetail(options=['A', 'D']), 'ad')
2685 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2686 self.assertEqual(cl._GetChangeDetail(options=['D']), 'ad')
2687 self.assertEqual(cl._GetChangeDetail(), 'cab')
2688
2689 # Finally, no_cache should invalidate all caches for given change.
2690 self.assertEqual(cl._GetChangeDetail(options=['A'], no_cache=True), 'a')
2691 self.assertEqual(cl._GetChangeDetail(options=['B']), 'b')
2692
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002693 def test_gerrit_description_caching(self):
2694 def gen_detail(rev, desc):
2695 return {
2696 'current_revision': rev,
2697 'revisions': {rev: {'commit': {'message': desc}}}
2698 }
2699 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002700 (('GetChangeDetail', 'host', 'my%2Frepo~1',
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002701 ['CURRENT_REVISION', 'CURRENT_COMMIT']),
2702 gen_detail('rev1', 'desc1')),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002703 (('GetChangeDetail', 'host', 'my%2Frepo~1',
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002704 ['CURRENT_REVISION', 'CURRENT_COMMIT']),
2705 gen_detail('rev2', 'desc2')),
2706 ]
2707
2708 self._mock_gerrit_changes_for_detail_cache()
2709 cl = git_cl.Changelist(issue=1, codereview='gerrit')
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002710 cl._cached_remote_url = (
2711 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002712 self.assertEqual(cl.GetDescription(), 'desc1')
2713 self.assertEqual(cl.GetDescription(), 'desc1') # cache hit.
2714 self.assertEqual(cl.GetDescription(force=True), 'desc2')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002715
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002716 def test_print_current_creds(self):
2717 class CookiesAuthenticatorMock(object):
2718 def __init__(self):
2719 self.gitcookies = {
2720 'host.googlesource.com': ('user', 'pass'),
2721 'host-review.googlesource.com': ('user', 'pass'),
2722 }
2723 self.netrc = self
2724 self.netrc.hosts = {
2725 'github.com': ('user2', None, 'pass2'),
2726 'host2.googlesource.com': ('user3', None, 'pass'),
2727 }
2728 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
2729 CookiesAuthenticatorMock)
2730 self.mock(sys, 'stdout', StringIO.StringIO())
2731 git_cl._GitCookiesChecker().print_current_creds(include_netrc=True)
2732 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2733 ' Host\t User\t Which file',
2734 '============================\t=====\t===========',
2735 'host-review.googlesource.com\t user\t.gitcookies',
2736 ' host.googlesource.com\t user\t.gitcookies',
2737 ' host2.googlesource.com\tuser3\t .netrc',
2738 ])
2739 sys.stdout.buf = ''
2740 git_cl._GitCookiesChecker().print_current_creds(include_netrc=False)
2741 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2742 ' Host\tUser\t Which file',
2743 '============================\t====\t===========',
2744 'host-review.googlesource.com\tuser\t.gitcookies',
2745 ' host.googlesource.com\tuser\t.gitcookies',
2746 ])
2747
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002748 def _common_creds_check_mocks(self):
2749 def exists_mock(path):
2750 dirname = os.path.dirname(path)
2751 if dirname == os.path.expanduser('~'):
2752 dirname = '~'
2753 base = os.path.basename(path)
2754 if base in ('.netrc', '.gitcookies'):
2755 return self._mocked_call('os.path.exists', '%s/%s' % (dirname, base))
2756 # git cl also checks for existence other files not relevant to this test.
2757 return None
2758 self.mock(os.path, 'exists', exists_mock)
2759 self.mock(sys, 'stdout', StringIO.StringIO())
2760
2761 def test_creds_check_gitcookies_not_configured(self):
2762 self._common_creds_check_mocks()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002763 self.mock(git_cl._GitCookiesChecker, 'get_hosts_with_creds',
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01002764 lambda _, include_netrc=False: [])
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002765 self.calls = [
Aaron Gable8797cab2018-03-06 13:55:00 -08002766 ((['git', 'config', '--path', 'http.cookiefile'],), CERR1),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002767 ((['git', 'config', '--global', 'http.cookiefile'],), CERR1),
2768 (('os.path.exists', '~/.netrc'), True),
2769 (('ask_for_data', 'Press Enter to setup .gitcookies, '
2770 'or Ctrl+C to abort'), ''),
2771 ((['git', 'config', '--global', 'http.cookiefile',
2772 os.path.expanduser('~/.gitcookies')], ), ''),
2773 ]
2774 self.assertEqual(0, git_cl.main(['creds-check']))
2775 self.assertRegexpMatches(
2776 sys.stdout.getvalue(),
2777 '^You seem to be using outdated .netrc for git credentials:')
2778 self.assertRegexpMatches(
2779 sys.stdout.getvalue(),
2780 '\nConfigured git to use .gitcookies from')
2781
2782 def test_creds_check_gitcookies_configured_custom_broken(self):
2783 self._common_creds_check_mocks()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002784 self.mock(git_cl._GitCookiesChecker, 'get_hosts_with_creds',
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01002785 lambda _, include_netrc=False: [])
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002786 self.calls = [
Aaron Gable8797cab2018-03-06 13:55:00 -08002787 ((['git', 'config', '--path', 'http.cookiefile'],), CERR1),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002788 ((['git', 'config', '--global', 'http.cookiefile'],),
2789 '/custom/.gitcookies'),
2790 (('os.path.exists', '/custom/.gitcookies'), False),
2791 (('ask_for_data', 'Reconfigure git to use default .gitcookies? '
2792 'Press Enter to reconfigure, or Ctrl+C to abort'), ''),
2793 ((['git', 'config', '--global', 'http.cookiefile',
2794 os.path.expanduser('~/.gitcookies')], ), ''),
2795 ]
2796 self.assertEqual(0, git_cl.main(['creds-check']))
2797 self.assertRegexpMatches(
2798 sys.stdout.getvalue(),
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002799 'WARNING: You have configured custom path to .gitcookies: ')
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002800 self.assertRegexpMatches(
2801 sys.stdout.getvalue(),
2802 'However, your configured .gitcookies file is missing.')
2803
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002804 def test_git_cl_comment_add_gerrit(self):
2805 self.mock(git_cl.gerrit_util, 'SetReview',
Aaron Gable636b13f2017-07-14 10:42:48 -07002806 lambda host, change, msg, ready:
2807 self._mocked_call('SetReview', host, change, msg, ready))
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002808 self.calls = [
2809 ((['git', 'symbolic-ref', 'HEAD'],), CERR1),
2810 ((['git', 'symbolic-ref', 'HEAD'],), CERR1),
2811 ((['git', 'config', 'rietveld.upstream-branch'],), CERR1),
2812 ((['git', 'branch', '-r'],), 'origin/HEAD -> origin/master\n'
2813 'origin/master'),
2814 ((['git', 'config', 'remote.origin.url'],),
2815 'https://chromium.googlesource.com/infra/infra'),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002816 (('SetReview', 'chromium-review.googlesource.com', 'infra%2Finfra~10',
2817 'msg', None),
Aaron Gable636b13f2017-07-14 10:42:48 -07002818 None),
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002819 ]
2820 self.assertEqual(0, git_cl.main(['comment', '--gerrit', '-i', '10',
2821 '-a', 'msg']))
2822
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002823 def test_git_cl_comments_fetch_gerrit(self):
2824 self.mock(sys, 'stdout', StringIO.StringIO())
2825 self.calls = [
2826 ((['git', 'symbolic-ref', 'HEAD'],), CERR1),
2827 ((['git', 'symbolic-ref', 'HEAD'],), CERR1),
2828 ((['git', 'config', 'rietveld.upstream-branch'],), CERR1),
2829 ((['git', 'branch', '-r'],), 'origin/HEAD -> origin/master\n'
2830 'origin/master'),
2831 ((['git', 'config', 'remote.origin.url'],),
2832 'https://chromium.googlesource.com/infra/infra'),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002833 (('GetChangeDetail', 'chromium-review.googlesource.com',
2834 'infra%2Finfra~1',
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002835 ['MESSAGES', 'DETAILED_ACCOUNTS']), {
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002836 'owner': {'email': 'owner@example.com'},
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002837 'messages': [
2838 {
2839 u'_revision_number': 1,
2840 u'author': {
2841 u'_account_id': 1111084,
2842 u'email': u'commit-bot@chromium.org',
2843 u'name': u'Commit Bot'
2844 },
2845 u'date': u'2017-03-15 20:08:45.000000000',
2846 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
Dirk Prankef6a58802017-10-17 12:49:42 -07002847 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002848 u'tag': u'autogenerated:cq:dry-run'
2849 },
2850 {
2851 u'_revision_number': 2,
2852 u'author': {
2853 u'_account_id': 11151243,
2854 u'email': u'owner@example.com',
2855 u'name': u'owner'
2856 },
2857 u'date': u'2017-03-16 20:00:41.000000000',
2858 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2859 u'message': u'PTAL',
2860 },
2861 {
2862 u'_revision_number': 2,
2863 u'author': {
2864 u'_account_id': 148512 ,
2865 u'email': u'reviewer@example.com',
2866 u'name': u'reviewer'
2867 },
2868 u'date': u'2017-03-17 05:19:37.500000000',
2869 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
2870 u'message': u'Patch Set 2: Code-Review+1',
2871 },
2872 ]
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002873 }),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002874 (('GetChangeComments', 'chromium-review.googlesource.com',
2875 'infra%2Finfra~1'), {
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002876 '/COMMIT_MSG': [
2877 {
2878 'author': {'email': u'reviewer@example.com'},
2879 'updated': u'2017-03-17 05:19:37.500000000',
2880 'patch_set': 2,
2881 'side': 'REVISION',
2882 'message': 'Please include a bug link',
2883 },
2884 ],
2885 'codereview.settings': [
2886 {
2887 'author': {'email': u'owner@example.com'},
2888 'updated': u'2017-03-16 20:00:41.000000000',
2889 'patch_set': 2,
2890 'side': 'PARENT',
2891 'line': 42,
2892 'message': 'I removed this because it is bad',
2893 },
2894 ]
Leszek Swirski45b20c42018-09-17 17:05:26 +00002895 })
2896 ] * 2 + [
2897 (('write_json', 'output.json', [
2898 {
2899 u'date': u'2017-03-16 20:00:41.000000',
2900 u'message': (
2901 u'PTAL\n' +
2902 u'\n' +
2903 u'codereview.settings\n' +
2904 u' Base, Line 42: https://chromium-review.googlesource.com/' +
2905 u'c/1/2/codereview.settings#b42\n' +
2906 u' I removed this because it is bad\n'),
2907 u'approval': False,
2908 u'disapproval': False,
2909 u'sender': u'owner@example.com'
2910 }, {
2911 u'date': u'2017-03-17 05:19:37.500000',
2912 u'message': (
2913 u'Patch Set 2: Code-Review+1\n' +
2914 u'\n' +
2915 u'/COMMIT_MSG\n' +
2916 u' PS2, File comment: https://chromium-review.googlesource' +
2917 u'.com/c/1/2//COMMIT_MSG#\n' +
2918 u' Please include a bug link\n'),
2919 u'approval': False,
2920 u'disapproval': False,
2921 u'sender': u'reviewer@example.com'
2922 }
2923 ]),'')
2924 ]
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002925 expected_comments_summary = [
2926 git_cl._CommentSummary(
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002927 message=(
2928 u'PTAL\n' +
2929 u'\n' +
2930 u'codereview.settings\n' +
2931 u' Base, Line 42: https://chromium-review.googlesource.com/' +
2932 u'c/1/2/codereview.settings#b42\n' +
2933 u' I removed this because it is bad\n'),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002934 date=datetime.datetime(2017, 3, 16, 20, 0, 41, 0),
2935 disapproval=False, approval=False, sender=u'owner@example.com'),
2936 git_cl._CommentSummary(
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002937 message=(
2938 u'Patch Set 2: Code-Review+1\n' +
2939 u'\n' +
2940 u'/COMMIT_MSG\n' +
2941 u' PS2, File comment: https://chromium-review.googlesource.com/' +
2942 u'c/1/2//COMMIT_MSG#\n' +
2943 u' Please include a bug link\n'),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002944 date=datetime.datetime(2017, 3, 17, 5, 19, 37, 500000),
2945 disapproval=False, approval=False, sender=u'reviewer@example.com'),
2946 ]
2947 cl = git_cl.Changelist(codereview='gerrit', issue=1)
2948 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Andrii Shyshkalov642641d2018-10-16 05:54:41 +00002949 self.assertEqual(0, git_cl.main(['comment', '-i', '1',
Leszek Swirski45b20c42018-09-17 17:05:26 +00002950 '-j', 'output.json']))
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002951
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002952 def test_get_remote_url_with_mirror(self):
2953 original_os_path_isdir = os.path.isdir
2954 def selective_os_path_isdir_mock(path):
2955 if path == '/cache/this-dir-exists':
2956 return self._mocked_call('os.path.isdir', path)
2957 return original_os_path_isdir(path)
2958 self.mock(os.path, 'isdir', selective_os_path_isdir_mock)
2959
2960 url = 'https://chromium.googlesource.com/my/repo'
2961 self.calls = [
2962 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2963 ((['git', 'config', 'branch.master.merge'],), 'master'),
2964 ((['git', 'config', 'branch.master.remote'],), 'origin'),
2965 ((['git', 'config', 'remote.origin.url'],),
2966 '/cache/this-dir-exists'),
2967 (('os.path.isdir', '/cache/this-dir-exists'),
2968 True),
2969 # Runs in /cache/this-dir-exists.
2970 ((['git', 'config', 'remote.origin.url'],),
2971 url),
2972 ]
2973 cl = git_cl.Changelist(codereview='gerrit', issue=1)
2974 self.assertEqual(cl.GetRemoteUrl(), url)
2975 self.assertEqual(cl.GetRemoteUrl(), url) # Must be cached.
2976
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002977 def test_gerrit_change_identifier_with_project(self):
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00002978 self.calls = [
2979 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2980 ((['git', 'config', 'branch.master.merge'],), 'master'),
2981 ((['git', 'config', 'branch.master.remote'],), 'origin'),
2982 ((['git', 'config', 'remote.origin.url'],),
2983 'https://chromium.googlesource.com/a/my/repo.git/'),
2984 ]
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002985 cl = git_cl.Changelist(codereview='gerrit', issue=123456)
2986 self.assertEqual(cl._GerritChangeIdentifier(), 'my%2Frepo~123456')
2987
2988 def test_gerrit_change_identifier_without_project(self):
2989 self.calls = [
2990 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2991 ((['git', 'config', 'branch.master.merge'],), 'master'),
2992 ((['git', 'config', 'branch.master.remote'],), 'origin'),
2993 ((['git', 'config', 'remote.origin.url'],), CERR1),
2994 ]
2995 cl = git_cl.Changelist(codereview='gerrit', issue=123456)
2996 self.assertEqual(cl._GerritChangeIdentifier(), '123456')
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00002997
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002998
maruel@chromium.orgddd59412011-11-30 14:20:38 +00002999if __name__ == '__main__':
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +01003000 logging.basicConfig(
3001 level=logging.DEBUG if '-v' in sys.argv else logging.ERROR)
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003002 unittest.main()