blob: 5ebe6470a10caa0bc164474fac9f369978d11594 [file] [log] [blame]
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001/*
kjellander1afca732016-02-07 20:46:45 -08002 * Copyright (c) 2004 The WebRTC project authors. All Rights Reserved.
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003 *
kjellander1afca732016-02-07 20:46:45 -08004 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00009 */
10
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +000011#include <algorithm>
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000012#include <map>
kwiberg686a8ef2016-02-26 03:00:35 -080013#include <memory>
Steve Antone78bcb92017-10-31 09:53:08 -070014#include <utility>
pbos@webrtc.org86f613d2014-06-10 08:53:05 +000015#include <vector>
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000016
Niels Möller039743e2018-10-23 10:07:25 +020017#include "absl/strings/match.h"
Steve Anton10542f22019-01-11 09:11:00 -080018#include "api/rtp_parameters.h"
Jiawei Ouc2ebe212018-11-08 10:02:56 -080019#include "api/test/mock_video_bitrate_allocator.h"
20#include "api/test/mock_video_bitrate_allocator_factory.h"
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -070021#include "api/test/mock_video_decoder_factory.h"
22#include "api/test/mock_video_encoder_factory.h"
Jonas Oreland49ac5952018-09-26 16:04:32 +020023#include "api/units/time_delta.h"
Jiawei Ouc2ebe212018-11-08 10:02:56 -080024#include "api/video/builtin_video_bitrate_allocator_factory.h"
Åsa Persson23eba222018-10-02 14:47:06 +020025#include "api/video/video_bitrate_allocation.h"
Anders Carlsson5f2bb622018-05-14 09:48:06 +020026#include "api/video_codecs/builtin_video_decoder_factory.h"
27#include "api/video_codecs/builtin_video_encoder_factory.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020028#include "api/video_codecs/sdp_video_format.h"
29#include "api/video_codecs/video_decoder_factory.h"
30#include "api/video_codecs/video_encoder.h"
31#include "api/video_codecs/video_encoder_factory.h"
32#include "call/flexfec_receive_stream.h"
33#include "common_video/h264/profile_level_id.h"
34#include "logging/rtc_event_log/rtc_event_log.h"
Steve Anton10542f22019-01-11 09:11:00 -080035#include "media/base/fake_network_interface.h"
Niels Mollera882fb32019-01-21 08:44:37 +000036#include "media/base/fake_video_capturer.h"
Steve Anton10542f22019-01-11 09:11:00 -080037#include "media/base/fake_video_renderer.h"
38#include "media/base/media_constants.h"
39#include "media/base/rtp_utils.h"
40#include "media/base/test_utils.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020041#include "media/engine/constants.h"
Steve Anton10542f22019-01-11 09:11:00 -080042#include "media/engine/fake_webrtc_call.h"
43#include "media/engine/fake_webrtc_video_engine.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020044#include "media/engine/simulcast.h"
Steve Anton10542f22019-01-11 09:11:00 -080045#include "media/engine/webrtc_video_engine.h"
46#include "media/engine/webrtc_voice_engine.h"
Åsa Persson23cd45a2018-07-03 10:40:40 +020047#include "modules/rtp_rtcp/include/rtp_header_parser.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020048#include "rtc_base/arraysize.h"
Steve Anton10542f22019-01-11 09:11:00 -080049#include "rtc_base/fake_clock.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020050#include "rtc_base/gunit.h"
Yves Gerey665174f2018-06-19 15:03:05 +020051#include "rtc_base/numerics/safe_conversions.h"
Niels Möllerd0f0f682019-01-14 09:09:53 +010052#include "rtc_base/timeutils.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020053#include "test/field_trial.h"
Niels Möllerd0f0f682019-01-14 09:09:53 +010054#include "test/frame_generator.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020055#include "test/gmock.h"
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000056
Niels Mollera882fb32019-01-21 08:44:37 +000057using cricket::FakeVideoCapturerWithTaskQueue;
Sebastian Jansson8f83b422018-02-21 13:07:13 +010058using webrtc::BitrateConstraints;
isheriff6f8d6862016-05-26 11:24:55 -070059using webrtc::RtpExtension;
Niels Mollera882fb32019-01-21 08:44:37 +000060using testing::Field;
isheriff6f8d6862016-05-26 11:24:55 -070061
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000062namespace {
buildbot@webrtc.orga8530772014-12-10 09:01:18 +000063static const int kDefaultQpMax = 56;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +000064
noahricd10a68e2015-07-10 11:27:55 -070065static const uint8_t kRedRtxPayloadType = 125;
66
Niels Möller6557d0c2018-04-11 15:18:34 +020067static const uint32_t kTimeout = 5000U;
68static const uint32_t kDefaultReceiveSsrc = 0;
69static const uint32_t kSsrc = 1234u;
70static const uint32_t kSsrcs4[] = {1, 2, 3, 4};
71static const int kVideoWidth = 640;
72static const int kVideoHeight = 360;
73static const int kFramerate = 30;
74
Peter Boström0c4e06b2015-10-07 12:23:21 +020075static const uint32_t kSsrcs1[] = {1};
76static const uint32_t kSsrcs3[] = {1, 2, 3};
77static const uint32_t kRtxSsrcs1[] = {4};
brandtr468da7c2016-11-22 02:16:47 -080078static const uint32_t kFlexfecSsrc = 5;
Peter Boström0c4e06b2015-10-07 12:23:21 +020079static const uint32_t kIncomingUnsignalledSsrc = 0xC0FFEE;
mzanaty8a855d62017-02-17 15:46:43 -080080static const uint32_t kDefaultRecvSsrc = 0;
81
pbos@webrtc.org3c107582014-07-20 15:27:35 +000082static const char kUnsupportedExtensionName[] =
83 "urn:ietf:params:rtp-hdrext:unsupported";
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000084
magjed509e4fe2016-11-18 01:34:11 -080085cricket::VideoCodec RemoveFeedbackParams(cricket::VideoCodec&& codec) {
86 codec.feedback_params = cricket::FeedbackParams();
Mirko Bonadei29a8d102018-04-25 23:58:26 +020087 return std::move(codec);
magjed509e4fe2016-11-18 01:34:11 -080088}
89
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000090void VerifyCodecHasDefaultFeedbackParams(const cricket::VideoCodec& codec) {
91 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
92 cricket::kRtcpFbParamNack, cricket::kParamValueEmpty)));
93 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
94 cricket::kRtcpFbParamNack, cricket::kRtcpFbNackParamPli)));
95 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
96 cricket::kRtcpFbParamRemb, cricket::kParamValueEmpty)));
97 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
stefan43edf0f2015-11-20 18:05:48 -080098 cricket::kRtcpFbParamTransportCc, cricket::kParamValueEmpty)));
99 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +0000100 cricket::kRtcpFbParamCcm, cricket::kRtcpFbCcmParamFir)));
101}
102
magjed725e4842016-11-16 00:48:13 -0800103// Return true if any codec in |codecs| is an RTX codec with associated payload
104// type |payload_type|.
105bool HasRtxCodec(const std::vector<cricket::VideoCodec>& codecs,
106 int payload_type) {
107 for (const cricket::VideoCodec& codec : codecs) {
108 int associated_payload_type;
Niels Möller039743e2018-10-23 10:07:25 +0200109 if (absl::EqualsIgnoreCase(codec.name.c_str(), "rtx") &&
magjed725e4842016-11-16 00:48:13 -0800110 codec.GetParam(cricket::kCodecParamAssociatedPayloadType,
111 &associated_payload_type) &&
112 associated_payload_type == payload_type) {
113 return true;
114 }
115 }
116 return false;
117}
118
nisseca5706d2017-09-11 02:32:16 -0700119// TODO(nisse): Duplicated in call.cc.
120const int* FindKeyByValue(const std::map<int, int>& m, int v) {
121 for (const auto& kv : m) {
122 if (kv.second == v)
123 return &kv.first;
124 }
125 return nullptr;
126}
127
Yves Gerey665174f2018-06-19 15:03:05 +0200128bool HasRtxReceiveAssociation(const webrtc::VideoReceiveStream::Config& config,
129 int payload_type) {
nisseca5706d2017-09-11 02:32:16 -0700130 return FindKeyByValue(config.rtp.rtx_associated_payload_types,
131 payload_type) != nullptr;
132}
133
134// Check that there's an Rtx payload type for each decoder.
135bool VerifyRtxReceiveAssociations(
136 const webrtc::VideoReceiveStream::Config& config) {
137 for (const auto& decoder : config.decoders) {
138 if (!HasRtxReceiveAssociation(config, decoder.payload_type))
139 return false;
140 }
141 return true;
142}
143
brandtrffc61182016-11-28 06:02:22 -0800144rtc::scoped_refptr<webrtc::VideoFrameBuffer> CreateBlackFrameBuffer(
nisse64ec8f82016-09-27 00:17:25 -0700145 int width,
146 int height) {
147 rtc::scoped_refptr<webrtc::I420Buffer> buffer =
148 webrtc::I420Buffer::Create(width, height);
nisseaf916892017-01-10 07:44:26 -0800149 webrtc::I420Buffer::SetBlack(buffer);
nisse64ec8f82016-09-27 00:17:25 -0700150 return buffer;
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +0000151}
152
Shao Changbine62202f2015-04-21 20:24:50 +0800153void VerifySendStreamHasRtxTypes(const webrtc::VideoSendStream::Config& config,
154 const std::map<int, int>& rtx_types) {
155 std::map<int, int>::const_iterator it;
Niels Möller259a4972018-04-05 15:36:51 +0200156 it = rtx_types.find(config.rtp.payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800157 EXPECT_TRUE(it != rtx_types.end() &&
158 it->second == config.rtp.rtx.payload_type);
159
brandtrb5f2c3f2016-10-04 23:28:39 -0700160 if (config.rtp.ulpfec.red_rtx_payload_type != -1) {
161 it = rtx_types.find(config.rtp.ulpfec.red_payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800162 EXPECT_TRUE(it != rtx_types.end() &&
brandtrb5f2c3f2016-10-04 23:28:39 -0700163 it->second == config.rtp.ulpfec.red_rtx_payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800164 }
165}
kthelgason2bc68642017-02-07 07:02:22 -0800166
167cricket::MediaConfig GetMediaConfig() {
168 cricket::MediaConfig media_config;
Niels Möller1d7ecd22018-01-18 15:25:12 +0100169 media_config.video.enable_cpu_adaptation = false;
kthelgason2bc68642017-02-07 07:02:22 -0800170 return media_config;
171}
nisse26e3abb2017-08-25 04:44:25 -0700172
Åsa Perssonbdee46d2018-06-25 11:28:06 +0200173// Values from GetMaxDefaultVideoBitrateKbps in webrtcvideoengine.cc.
174int GetMaxDefaultBitrateBps(size_t width, size_t height) {
175 if (width * height <= 320 * 240) {
176 return 600000;
177 } else if (width * height <= 640 * 480) {
178 return 1700000;
179 } else if (width * height <= 960 * 540) {
180 return 2000000;
181 } else {
182 return 2500000;
183 }
184}
185
Niels Möller731a2c22018-07-30 15:08:07 +0200186class MockVideoSource : public rtc::VideoSourceInterface<webrtc::VideoFrame> {
187 public:
188 MOCK_METHOD2(AddOrUpdateSink,
189 void(rtc::VideoSinkInterface<webrtc::VideoFrame>* sink,
190 const rtc::VideoSinkWants& wants));
191 MOCK_METHOD1(RemoveSink,
192 void(rtc::VideoSinkInterface<webrtc::VideoFrame>* sink));
193};
194
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000195} // namespace
196
Yves Gerey665174f2018-06-19 15:03:05 +0200197#define EXPECT_FRAME_WAIT(c, w, h, t) \
Niels Möller6557d0c2018-04-11 15:18:34 +0200198 EXPECT_EQ_WAIT((c), renderer_.num_rendered_frames(), (t)); \
Yves Gerey665174f2018-06-19 15:03:05 +0200199 EXPECT_EQ((w), renderer_.width()); \
200 EXPECT_EQ((h), renderer_.height()); \
Niels Möller6557d0c2018-04-11 15:18:34 +0200201 EXPECT_EQ(0, renderer_.errors());
202
Yves Gerey665174f2018-06-19 15:03:05 +0200203#define EXPECT_FRAME_ON_RENDERER_WAIT(r, c, w, h, t) \
Niels Möller6557d0c2018-04-11 15:18:34 +0200204 EXPECT_EQ_WAIT((c), (r).num_rendered_frames(), (t)); \
Yves Gerey665174f2018-06-19 15:03:05 +0200205 EXPECT_EQ((w), (r).width()); \
206 EXPECT_EQ((h), (r).height()); \
Niels Möller6557d0c2018-04-11 15:18:34 +0200207 EXPECT_EQ(0, (r).errors());
208
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000209namespace cricket {
eladalonf1841382017-06-12 01:16:46 -0700210class WebRtcVideoEngineTest : public ::testing::Test {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000211 public:
eladalonf1841382017-06-12 01:16:46 -0700212 WebRtcVideoEngineTest() : WebRtcVideoEngineTest("") {}
213 explicit WebRtcVideoEngineTest(const char* field_trials)
stefanc1aeaf02015-10-15 07:26:07 -0700214 : override_field_trials_(field_trials),
skvlad11a9cbf2016-10-07 11:53:05 -0700215 call_(webrtc::Call::Create(webrtc::Call::Config(&event_log_))),
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200216 encoder_factory_(new cricket::FakeWebRtcVideoEncoderFactory),
217 decoder_factory_(new cricket::FakeWebRtcVideoDecoderFactory),
Anders Carlsson67537952018-05-03 11:28:29 +0200218 engine_(std::unique_ptr<cricket::FakeWebRtcVideoEncoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200219 encoder_factory_),
Anders Carlsson67537952018-05-03 11:28:29 +0200220 std::unique_ptr<cricket::FakeWebRtcVideoDecoderFactory>(
Jiawei Ouc2ebe212018-11-08 10:02:56 -0800221 decoder_factory_),
222 webrtc::CreateBuiltinVideoBitrateAllocatorFactory()) {
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +0200223 // Ensure fake clock doesn't return 0, which will cause some initializations
224 // fail inside RTP senders.
225 fake_clock_.AdvanceTimeMicros(1);
226 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000227
228 protected:
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200229 void AssignDefaultAptRtxTypes();
230 void AssignDefaultCodec();
231
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100232 // Find the index of the codec in the engine with the given name. The codec
233 // must be present.
Oleh Prypina40f8242017-12-21 13:32:23 +0100234 size_t GetEngineCodecIndex(const std::string& name) const;
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100235
magjed509e4fe2016-11-18 01:34:11 -0800236 // Find the codec in the engine with the given name. The codec must be
237 // present.
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100238 cricket::VideoCodec GetEngineCodec(const std::string& name) const;
magjed509e4fe2016-11-18 01:34:11 -0800239
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200240 VideoMediaChannel* SetSendParamsWithAllSupportedCodecs();
pbos@webrtc.orgfa553ef2014-10-20 11:07:07 +0000241
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200242 VideoMediaChannel* SetRecvParamsWithSupportedCodecs(
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000243 const std::vector<VideoCodec>& codecs);
244
Peter Boströme4499152016-02-05 11:13:28 +0100245 void TestExtendedEncoderOveruse(bool use_external_encoder);
246
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +0200247 // Has to be the first one, so it is initialized before the call or there is a
248 // race condition in the clock access.
249 rtc::ScopedFakeClock fake_clock_;
stefanc1aeaf02015-10-15 07:26:07 -0700250 webrtc::test::ScopedFieldTrials override_field_trials_;
skvlad11a9cbf2016-10-07 11:53:05 -0700251 webrtc::RtcEventLogNullImpl event_log_;
eladalonf1841382017-06-12 01:16:46 -0700252 // Used in WebRtcVideoEngineVoiceTest, but defined here so it's properly
pbos@webrtc.orgf1f0d9a2015-03-02 13:30:15 +0000253 // initialized when the constructor is called.
kwiberg686a8ef2016-02-26 03:00:35 -0800254 std::unique_ptr<webrtc::Call> call_;
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200255 cricket::FakeWebRtcVideoEncoderFactory* encoder_factory_;
256 cricket::FakeWebRtcVideoDecoderFactory* decoder_factory_;
eladalonf1841382017-06-12 01:16:46 -0700257 WebRtcVideoEngine engine_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000258 VideoCodec default_codec_;
Shao Changbine62202f2015-04-21 20:24:50 +0800259 std::map<int, int> default_apt_rtx_types_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000260};
261
eladalonf1841382017-06-12 01:16:46 -0700262TEST_F(WebRtcVideoEngineTest, DefaultRtxCodecHasAssociatedPayloadTypeSet) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200263 encoder_factory_->AddSupportedVideoCodecType("VP8");
264 AssignDefaultCodec();
265
pbos@webrtc.orge322a172014-06-13 11:47:28 +0000266 std::vector<VideoCodec> engine_codecs = engine_.codecs();
267 for (size_t i = 0; i < engine_codecs.size(); ++i) {
268 if (engine_codecs[i].name != kRtxCodecName)
269 continue;
270 int associated_payload_type;
271 EXPECT_TRUE(engine_codecs[i].GetParam(kCodecParamAssociatedPayloadType,
pbos@webrtc.org42684be2014-10-03 11:25:45 +0000272 &associated_payload_type));
pbos@webrtc.orge322a172014-06-13 11:47:28 +0000273 EXPECT_EQ(default_codec_.id, associated_payload_type);
274 return;
275 }
276 FAIL() << "No RTX codec found among default codecs.";
277}
278
eladalonf1841382017-06-12 01:16:46 -0700279TEST_F(WebRtcVideoEngineTest, SupportsTimestampOffsetHeaderExtension) {
Stefan Holmer9d69c3f2015-12-07 10:45:43 +0100280 RtpCapabilities capabilities = engine_.GetCapabilities();
Johannes Krond0b69a82018-12-03 14:18:53 +0100281 EXPECT_THAT(
282 capabilities.header_extensions,
283 testing::Contains(RtpExtension(RtpExtension::kTimestampOffsetUri,
284 RtpExtension::kTimestampOffsetDefaultId)));
pbos@webrtc.org587ef602014-06-16 17:32:02 +0000285}
286
eladalonf1841382017-06-12 01:16:46 -0700287TEST_F(WebRtcVideoEngineTest, SupportsAbsoluteSenderTimeHeaderExtension) {
Stefan Holmer9d69c3f2015-12-07 10:45:43 +0100288 RtpCapabilities capabilities = engine_.GetCapabilities();
Johannes Krond0b69a82018-12-03 14:18:53 +0100289 EXPECT_THAT(
290 capabilities.header_extensions,
291 testing::Contains(RtpExtension(RtpExtension::kAbsSendTimeUri,
292 RtpExtension::kAbsSendTimeDefaultId)));
pbos@webrtc.org587ef602014-06-16 17:32:02 +0000293}
294
eladalonf1841382017-06-12 01:16:46 -0700295TEST_F(WebRtcVideoEngineTest, SupportsTransportSequenceNumberHeaderExtension) {
Stefan Holmer9d69c3f2015-12-07 10:45:43 +0100296 RtpCapabilities capabilities = engine_.GetCapabilities();
Johannes Krond0b69a82018-12-03 14:18:53 +0100297 EXPECT_THAT(capabilities.header_extensions,
298 testing::Contains(RtpExtension(
299 RtpExtension::kTransportSequenceNumberUri,
300 RtpExtension::kTransportSequenceNumberDefaultId)));
stefanc1aeaf02015-10-15 07:26:07 -0700301}
302
eladalonf1841382017-06-12 01:16:46 -0700303TEST_F(WebRtcVideoEngineTest, SupportsVideoRotationHeaderExtension) {
Stefan Holmer9d69c3f2015-12-07 10:45:43 +0100304 RtpCapabilities capabilities = engine_.GetCapabilities();
Johannes Krond0b69a82018-12-03 14:18:53 +0100305 EXPECT_THAT(
306 capabilities.header_extensions,
307 testing::Contains(RtpExtension(RtpExtension::kVideoRotationUri,
308 RtpExtension::kVideoRotationDefaultId)));
309}
310
311TEST_F(WebRtcVideoEngineTest, SupportsColorSpaceHeaderExtension) {
312 RtpCapabilities capabilities = engine_.GetCapabilities();
313 EXPECT_THAT(
314 capabilities.header_extensions,
315 testing::Contains(RtpExtension(RtpExtension::kColorSpaceUri,
316 RtpExtension::kColorSpaceDefaultId)));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700317}
318
philipel1e054862018-10-08 16:13:53 +0200319class WebRtcVideoEngineTestWithGenericDescriptor
320 : public WebRtcVideoEngineTest {
321 public:
322 WebRtcVideoEngineTestWithGenericDescriptor()
323 : WebRtcVideoEngineTest("WebRTC-GenericDescriptorAdvertised/Enabled/") {}
324};
325
326TEST_F(WebRtcVideoEngineTestWithGenericDescriptor, AdvertiseGenericDescriptor) {
327 RtpCapabilities capabilities = engine_.GetCapabilities();
328 ASSERT_FALSE(capabilities.header_extensions.empty());
329 for (const RtpExtension& extension : capabilities.header_extensions) {
330 if (extension.uri == RtpExtension::kGenericFrameDescriptorUri) {
331 EXPECT_EQ(RtpExtension::kGenericFrameDescriptorDefaultId, extension.id);
332 return;
333 }
334 }
335 FAIL() << "Generic descriptor extension not in header-extension list.";
336}
337
eladalonf1841382017-06-12 01:16:46 -0700338TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionBeforeCapturer) {
Niels Möller731a2c22018-07-30 15:08:07 +0200339 // Allocate the source first to prevent early destruction before channel's
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700340 // dtor is called.
Niels Möller731a2c22018-07-30 15:08:07 +0200341 testing::NiceMock<MockVideoSource> video_source;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700342
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200343 encoder_factory_->AddSupportedVideoCodecType("VP8");
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700344
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200345 std::unique_ptr<VideoMediaChannel> channel(
346 SetSendParamsWithAllSupportedCodecs());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700347 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
348
349 // Add CVO extension.
350 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800351 cricket::VideoSendParameters parameters;
352 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200353 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700354 RtpExtension(RtpExtension::kVideoRotationUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200355 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700356
Niels Möller731a2c22018-07-30 15:08:07 +0200357 EXPECT_CALL(
358 video_source,
359 AddOrUpdateSink(testing::_,
360 Field(&rtc::VideoSinkWants::rotation_applied, false)));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700361 // Set capturer.
Niels Möller731a2c22018-07-30 15:08:07 +0200362 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700363
364 // Verify capturer has turned off applying rotation.
Niels Möller731a2c22018-07-30 15:08:07 +0200365 testing::Mock::VerifyAndClear(&video_source);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700366
367 // Verify removing header extension turns on applying rotation.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200368 parameters.extensions.clear();
Niels Möller731a2c22018-07-30 15:08:07 +0200369 EXPECT_CALL(
370 video_source,
371 AddOrUpdateSink(testing::_,
372 Field(&rtc::VideoSinkWants::rotation_applied, true)));
373
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200374 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700375}
376
eladalonf1841382017-06-12 01:16:46 -0700377TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionBeforeAddSendStream) {
Niels Möller731a2c22018-07-30 15:08:07 +0200378 // Allocate the source first to prevent early destruction before channel's
perkj91e1c152016-03-02 05:34:00 -0800379 // dtor is called.
Niels Möller731a2c22018-07-30 15:08:07 +0200380 testing::NiceMock<MockVideoSource> video_source;
perkj91e1c152016-03-02 05:34:00 -0800381
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200382 encoder_factory_->AddSupportedVideoCodecType("VP8");
perkj91e1c152016-03-02 05:34:00 -0800383
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200384 std::unique_ptr<VideoMediaChannel> channel(
385 SetSendParamsWithAllSupportedCodecs());
perkj91e1c152016-03-02 05:34:00 -0800386 // Add CVO extension.
387 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800388 cricket::VideoSendParameters parameters;
389 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkj91e1c152016-03-02 05:34:00 -0800390 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700391 RtpExtension(RtpExtension::kVideoRotationUri, id));
perkj91e1c152016-03-02 05:34:00 -0800392 EXPECT_TRUE(channel->SetSendParameters(parameters));
393 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
394
Niels Möller731a2c22018-07-30 15:08:07 +0200395 // Set source.
396 EXPECT_CALL(
397 video_source,
398 AddOrUpdateSink(testing::_,
399 Field(&rtc::VideoSinkWants::rotation_applied, false)));
400 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
perkj91e1c152016-03-02 05:34:00 -0800401}
402
eladalonf1841382017-06-12 01:16:46 -0700403TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionAfterCapturer) {
Niels Möller731a2c22018-07-30 15:08:07 +0200404 testing::NiceMock<MockVideoSource> video_source;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700405
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200406 encoder_factory_->AddSupportedVideoCodecType("VP8");
407 encoder_factory_->AddSupportedVideoCodecType("VP9");
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700408
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200409 std::unique_ptr<VideoMediaChannel> channel(
410 SetSendParamsWithAllSupportedCodecs());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700411 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
412
413 // Set capturer.
Niels Möller731a2c22018-07-30 15:08:07 +0200414 EXPECT_CALL(
415 video_source,
416 AddOrUpdateSink(testing::_,
417 Field(&rtc::VideoSinkWants::rotation_applied, true)));
418 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700419
perkjcaafdba2016-03-20 07:34:29 -0700420 // Verify capturer has turned on applying rotation.
Niels Möller731a2c22018-07-30 15:08:07 +0200421 testing::Mock::VerifyAndClear(&video_source);
perkjcaafdba2016-03-20 07:34:29 -0700422
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700423 // Add CVO extension.
424 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800425 cricket::VideoSendParameters parameters;
426 parameters.codecs.push_back(GetEngineCodec("VP8"));
427 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200428 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700429 RtpExtension(RtpExtension::kVideoRotationUri, id));
perkjcaafdba2016-03-20 07:34:29 -0700430 // Also remove the first codec to trigger a codec change as well.
431 parameters.codecs.erase(parameters.codecs.begin());
Niels Möller731a2c22018-07-30 15:08:07 +0200432 EXPECT_CALL(
433 video_source,
434 AddOrUpdateSink(testing::_,
435 Field(&rtc::VideoSinkWants::rotation_applied, false)));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200436 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700437
438 // Verify capturer has turned off applying rotation.
Niels Möller731a2c22018-07-30 15:08:07 +0200439 testing::Mock::VerifyAndClear(&video_source);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700440
441 // Verify removing header extension turns on applying rotation.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200442 parameters.extensions.clear();
Niels Möller731a2c22018-07-30 15:08:07 +0200443 EXPECT_CALL(
444 video_source,
445 AddOrUpdateSink(testing::_,
446 Field(&rtc::VideoSinkWants::rotation_applied, true)));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200447 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700448}
449
eladalonf1841382017-06-12 01:16:46 -0700450TEST_F(WebRtcVideoEngineTest, SetSendFailsBeforeSettingCodecs) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200451 encoder_factory_->AddSupportedVideoCodecType("VP8");
452
Sebastian Jansson84848f22018-11-16 10:40:36 +0100453 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700454 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
pbos@webrtc.org5301b0f2014-07-17 08:51:46 +0000455
456 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(123)));
457
458 EXPECT_FALSE(channel->SetSend(true))
459 << "Channel should not start without codecs.";
460 EXPECT_TRUE(channel->SetSend(false))
461 << "Channel should be stoppable even without set codecs.";
462}
463
eladalonf1841382017-06-12 01:16:46 -0700464TEST_F(WebRtcVideoEngineTest, GetStatsWithoutSendCodecsSetDoesNotCrash) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200465 encoder_factory_->AddSupportedVideoCodecType("VP8");
466
Sebastian Jansson84848f22018-11-16 10:40:36 +0100467 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700468 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
pbos@webrtc.orgc3d2bd22014-08-12 20:55:10 +0000469 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(123)));
470 VideoMediaInfo info;
471 channel->GetStats(&info);
472}
473
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200474TEST_F(WebRtcVideoEngineTest, UseFactoryForVp8WhenSupported) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200475 encoder_factory_->AddSupportedVideoCodecType("VP8");
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000476
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200477 std::unique_ptr<VideoMediaChannel> channel(
478 SetSendParamsWithAllSupportedCodecs());
Sergey Ulanove2b15012016-11-22 16:08:30 -0800479 channel->OnReadyToSend(true);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000480
481 EXPECT_TRUE(
482 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200483 EXPECT_EQ(0, encoder_factory_->GetNumCreatedEncoders());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000484 EXPECT_TRUE(channel->SetSend(true));
Niels Möllerd0f0f682019-01-14 09:09:53 +0100485 webrtc::test::FrameForwarder frame_forwarder;
486 cricket::FakeFrameSource frame_source(1280, 720,
487 rtc::kNumMicrosecsPerSec / 30);
488 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
489 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Per21d45d22016-10-30 21:37:57 +0100490 // Sending one frame will have allocate the encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200491 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
492 EXPECT_TRUE_WAIT(encoder_factory_->encoders()[0]->GetNumEncodedFrames() > 0,
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000493 kTimeout);
494
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200495 int num_created_encoders = encoder_factory_->GetNumCreatedEncoders();
Per21d45d22016-10-30 21:37:57 +0100496 EXPECT_EQ(num_created_encoders, 1);
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000497
498 // Setting codecs of the same type should not reallocate any encoders
499 // (expecting a no-op).
magjed509e4fe2016-11-18 01:34:11 -0800500 cricket::VideoSendParameters parameters;
501 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200502 EXPECT_TRUE(channel->SetSendParameters(parameters));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200503 EXPECT_EQ(num_created_encoders, encoder_factory_->GetNumCreatedEncoders());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000504
505 // Remove stream previously added to free the external encoder instance.
506 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200507 EXPECT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000508}
509
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200510// Test that when an encoder factory supports H264, we add an RTX
511// codec for it.
512// TODO(deadbeef): This test should be updated if/when we start
513// adding RTX codecs for unrecognized codec names.
514TEST_F(WebRtcVideoEngineTest, RtxCodecAddedForH264Codec) {
magjed725e4842016-11-16 00:48:13 -0800515 using webrtc::H264::ProfileLevelIdToString;
516 using webrtc::H264::ProfileLevelId;
517 using webrtc::H264::kLevel1;
Anders Carlsson67537952018-05-03 11:28:29 +0200518 webrtc::SdpVideoFormat h264_constrained_baseline("H264");
519 h264_constrained_baseline.parameters[kH264FmtpProfileLevelId] =
magjed725e4842016-11-16 00:48:13 -0800520 *ProfileLevelIdToString(
521 ProfileLevelId(webrtc::H264::kProfileConstrainedBaseline, kLevel1));
Anders Carlsson67537952018-05-03 11:28:29 +0200522 webrtc::SdpVideoFormat h264_constrained_high("H264");
523 h264_constrained_high.parameters[kH264FmtpProfileLevelId] =
magjed725e4842016-11-16 00:48:13 -0800524 *ProfileLevelIdToString(
525 ProfileLevelId(webrtc::H264::kProfileConstrainedHigh, kLevel1));
Anders Carlsson67537952018-05-03 11:28:29 +0200526 webrtc::SdpVideoFormat h264_high("H264");
527 h264_high.parameters[kH264FmtpProfileLevelId] = *ProfileLevelIdToString(
magjed725e4842016-11-16 00:48:13 -0800528 ProfileLevelId(webrtc::H264::kProfileHigh, kLevel1));
529
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200530 encoder_factory_->AddSupportedVideoCodec(h264_constrained_baseline);
531 encoder_factory_->AddSupportedVideoCodec(h264_constrained_high);
532 encoder_factory_->AddSupportedVideoCodec(h264_high);
Taylor Brandstetter6c3e7882016-06-29 11:14:19 -0700533
magjed725e4842016-11-16 00:48:13 -0800534 // First figure out what payload types the test codecs got assigned.
535 const std::vector<cricket::VideoCodec> codecs = engine_.codecs();
magjed509e4fe2016-11-18 01:34:11 -0800536 // Now search for RTX codecs for them. Expect that they all have associated
537 // RTX codecs.
magjed725e4842016-11-16 00:48:13 -0800538 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200539 codecs,
540 FindMatchingCodec(codecs, cricket::VideoCodec(h264_constrained_baseline))
541 ->id));
magjed725e4842016-11-16 00:48:13 -0800542 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200543 codecs,
544 FindMatchingCodec(codecs, cricket::VideoCodec(h264_constrained_high))
545 ->id));
magjed509e4fe2016-11-18 01:34:11 -0800546 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200547 codecs, FindMatchingCodec(codecs, cricket::VideoCodec(h264_high))->id));
Taylor Brandstetter6c3e7882016-06-29 11:14:19 -0700548}
549
Mirko Bonadei8ef57932018-11-16 14:38:03 +0100550#if defined(RTC_ENABLE_VP9)
eladalonf1841382017-06-12 01:16:46 -0700551TEST_F(WebRtcVideoEngineTest, CanConstructDecoderForVp9EncoderFactory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200552 encoder_factory_->AddSupportedVideoCodecType("VP9");
Peter Boström53eda3d2015-03-27 15:53:18 +0100553
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200554 std::unique_ptr<VideoMediaChannel> channel(
555 SetSendParamsWithAllSupportedCodecs());
Peter Boström53eda3d2015-03-27 15:53:18 +0100556
557 EXPECT_TRUE(
558 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
559}
Mirko Bonadei8ef57932018-11-16 14:38:03 +0100560#endif // defined(RTC_ENABLE_VP9)
Peter Boström53eda3d2015-03-27 15:53:18 +0100561
eladalonf1841382017-06-12 01:16:46 -0700562TEST_F(WebRtcVideoEngineTest, PropagatesInputFrameTimestamp) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200563 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson8f83b422018-02-21 13:07:13 +0100564 FakeCall* fake_call = new FakeCall();
Fredrik Solenberg709ed672015-09-15 12:26:33 +0200565 call_.reset(fake_call);
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200566 std::unique_ptr<VideoMediaChannel> channel(
567 SetSendParamsWithAllSupportedCodecs());
qiangchenc27d89f2015-07-16 10:27:16 -0700568
569 EXPECT_TRUE(
570 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
571
Niels Möllerd0f0f682019-01-14 09:09:53 +0100572 webrtc::test::FrameForwarder frame_forwarder;
573 cricket::FakeFrameSource frame_source(1280, 720,
574 rtc::kNumMicrosecsPerSec / 60);
575 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
qiangchenc27d89f2015-07-16 10:27:16 -0700576 channel->SetSend(true);
577
Fredrik Solenberg709ed672015-09-15 12:26:33 +0200578 FakeVideoSendStream* stream = fake_call->GetVideoSendStreams()[0];
qiangchenc27d89f2015-07-16 10:27:16 -0700579
Niels Möllerd0f0f682019-01-14 09:09:53 +0100580 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos1cb121d2015-09-14 11:38:38 -0700581 int64_t last_timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700582 for (int i = 0; i < 10; i++) {
Niels Möllerd0f0f682019-01-14 09:09:53 +0100583 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos1cb121d2015-09-14 11:38:38 -0700584 int64_t timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700585 int64_t interval = timestamp - last_timestamp;
586
587 // Precision changes from nanosecond to millisecond.
588 // Allow error to be no more than 1.
589 EXPECT_NEAR(cricket::VideoFormat::FpsToInterval(60) / 1E6, interval, 1);
590
591 last_timestamp = timestamp;
592 }
593
Niels Möllerd0f0f682019-01-14 09:09:53 +0100594 frame_forwarder.IncomingCapturedFrame(
595 frame_source.GetFrame(1280, 720, webrtc::VideoRotation::kVideoRotation_0,
596 rtc::kNumMicrosecsPerSec / 30));
qiangchenc27d89f2015-07-16 10:27:16 -0700597 last_timestamp = stream->GetLastTimestamp();
598 for (int i = 0; i < 10; i++) {
Niels Möllerd0f0f682019-01-14 09:09:53 +0100599 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame(
600 1280, 720, webrtc::VideoRotation::kVideoRotation_0,
601 rtc::kNumMicrosecsPerSec / 30));
pbos1cb121d2015-09-14 11:38:38 -0700602 int64_t timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700603 int64_t interval = timestamp - last_timestamp;
604
605 // Precision changes from nanosecond to millisecond.
606 // Allow error to be no more than 1.
607 EXPECT_NEAR(cricket::VideoFormat::FpsToInterval(30) / 1E6, interval, 1);
608
609 last_timestamp = timestamp;
610 }
611
612 // Remove stream previously added to free the external encoder instance.
613 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
614}
615
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200616void WebRtcVideoEngineTest::AssignDefaultAptRtxTypes() {
617 std::vector<VideoCodec> engine_codecs = engine_.codecs();
618 RTC_DCHECK(!engine_codecs.empty());
619 for (const cricket::VideoCodec& codec : engine_codecs) {
620 if (codec.name == "rtx") {
621 int associated_payload_type;
622 if (codec.GetParam(kCodecParamAssociatedPayloadType,
623 &associated_payload_type)) {
624 default_apt_rtx_types_[associated_payload_type] = codec.id;
625 }
626 }
627 }
628}
629
630void WebRtcVideoEngineTest::AssignDefaultCodec() {
631 std::vector<VideoCodec> engine_codecs = engine_.codecs();
632 RTC_DCHECK(!engine_codecs.empty());
633 bool codec_set = false;
634 for (const cricket::VideoCodec& codec : engine_codecs) {
635 if (!codec_set && codec.name != "rtx" && codec.name != "red" &&
636 codec.name != "ulpfec") {
637 default_codec_ = codec;
638 codec_set = true;
639 }
640 }
641
642 RTC_DCHECK(codec_set);
643}
644
Oleh Prypina40f8242017-12-21 13:32:23 +0100645size_t WebRtcVideoEngineTest::GetEngineCodecIndex(
646 const std::string& name) const {
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100647 const std::vector<cricket::VideoCodec> codecs = engine_.codecs();
648 for (size_t i = 0; i < codecs.size(); ++i) {
649 const cricket::VideoCodec engine_codec = codecs[i];
Niels Möller039743e2018-10-23 10:07:25 +0200650 if (!absl::EqualsIgnoreCase(name, engine_codec.name))
Magnus Jedvert8deb8182017-10-05 13:13:32 +0200651 continue;
652 // The tests only use H264 Constrained Baseline. Make sure we don't return
653 // an internal H264 codec from the engine with a different H264 profile.
Niels Möller039743e2018-10-23 10:07:25 +0200654 if (absl::EqualsIgnoreCase(name.c_str(), kH264CodecName)) {
Danil Chapovalov00c71832018-06-15 15:58:38 +0200655 const absl::optional<webrtc::H264::ProfileLevelId> profile_level_id =
Magnus Jedvert8deb8182017-10-05 13:13:32 +0200656 webrtc::H264::ParseSdpProfileLevelId(engine_codec.params);
657 if (profile_level_id->profile !=
658 webrtc::H264::kProfileConstrainedBaseline) {
659 continue;
660 }
661 }
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100662 return i;
magjed509e4fe2016-11-18 01:34:11 -0800663 }
664 // This point should never be reached.
665 ADD_FAILURE() << "Unrecognized codec name: " << name;
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100666 return -1;
667}
668
669cricket::VideoCodec WebRtcVideoEngineTest::GetEngineCodec(
670 const std::string& name) const {
671 return engine_.codecs()[GetEngineCodecIndex(name)];
magjed509e4fe2016-11-18 01:34:11 -0800672}
673
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200674VideoMediaChannel*
675WebRtcVideoEngineTest::SetSendParamsWithAllSupportedCodecs() {
Sebastian Jansson84848f22018-11-16 10:40:36 +0100676 VideoMediaChannel* channel = engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700677 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions());
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200678 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -0800679 // We need to look up the codec in the engine to get the correct payload type.
Anders Carlsson67537952018-05-03 11:28:29 +0200680 for (const webrtc::SdpVideoFormat& format :
681 encoder_factory_->GetSupportedFormats()) {
682 cricket::VideoCodec engine_codec = GetEngineCodec(format.name);
683 if (std::find(parameters.codecs.begin(), parameters.codecs.end(),
684 engine_codec) == parameters.codecs.end()) {
685 parameters.codecs.push_back(engine_codec);
686 }
687 }
magjed509e4fe2016-11-18 01:34:11 -0800688
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200689 EXPECT_TRUE(channel->SetSendParameters(parameters));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000690
691 return channel;
692}
693
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200694VideoMediaChannel* WebRtcVideoEngineTest::SetRecvParamsWithSupportedCodecs(
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000695 const std::vector<VideoCodec>& codecs) {
Sebastian Jansson84848f22018-11-16 10:40:36 +0100696 VideoMediaChannel* channel = engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700697 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions());
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200698 cricket::VideoRecvParameters parameters;
699 parameters.codecs = codecs;
700 EXPECT_TRUE(channel->SetRecvParameters(parameters));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000701
702 return channel;
703}
704
eladalonf1841382017-06-12 01:16:46 -0700705TEST_F(WebRtcVideoEngineTest, UsesSimulcastAdapterForVp8Factories) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200706 encoder_factory_->AddSupportedVideoCodecType("VP8");
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000707
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200708 std::unique_ptr<VideoMediaChannel> channel(
709 SetSendParamsWithAllSupportedCodecs());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000710
Peter Boström0c4e06b2015-10-07 12:23:21 +0200711 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000712
Yves Gerey665174f2018-06-19 15:03:05 +0200713 EXPECT_TRUE(channel->AddSendStream(CreateSimStreamParams("cname", ssrcs)));
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000714 EXPECT_TRUE(channel->SetSend(true));
715
Niels Mollera882fb32019-01-21 08:44:37 +0000716 FakeVideoCapturerWithTaskQueue capturer;
717 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, &capturer));
718 EXPECT_EQ(cricket::CS_RUNNING,
719 capturer.Start(capturer.GetSupportedFormats()->front()));
720 EXPECT_TRUE(capturer.CaptureFrame());
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000721
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200722 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000723
724 // Verify that encoders are configured for simulcast through adapter
725 // (increasing resolution and only configured to send one stream each).
726 int prev_width = -1;
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200727 for (size_t i = 0; i < encoder_factory_->encoders().size(); ++i) {
728 ASSERT_TRUE(encoder_factory_->encoders()[i]->WaitForInitEncode());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000729 webrtc::VideoCodec codec_settings =
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200730 encoder_factory_->encoders()[i]->GetCodecSettings();
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000731 EXPECT_EQ(0, codec_settings.numberOfSimulcastStreams);
732 EXPECT_GT(codec_settings.width, prev_width);
733 prev_width = codec_settings.width;
734 }
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000735
Niels Möllerff40b142018-04-09 08:49:14 +0200736 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, nullptr));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000737
738 channel.reset();
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200739 ASSERT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000740}
741
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200742TEST_F(WebRtcVideoEngineTest, ChannelWithH264CanChangeToVp8) {
743 encoder_factory_->AddSupportedVideoCodecType("VP8");
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200744 encoder_factory_->AddSupportedVideoCodecType("H264");
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000745
Niels Möllerd0f0f682019-01-14 09:09:53 +0100746 // Frame source.
747 webrtc::test::FrameForwarder frame_forwarder;
748 cricket::FakeFrameSource frame_source(1280, 720,
749 rtc::kNumMicrosecsPerSec / 30);
Niels Möller4db138e2018-04-19 09:04:13 +0200750
Sebastian Jansson84848f22018-11-16 10:40:36 +0100751 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700752 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
Anders Carlsson67537952018-05-03 11:28:29 +0200753 cricket::VideoSendParameters parameters;
754 parameters.codecs.push_back(GetEngineCodec("H264"));
755 EXPECT_TRUE(channel->SetSendParameters(parameters));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000756
757 EXPECT_TRUE(
758 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möllerd0f0f682019-01-14 09:09:53 +0100759 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
Niels Möller4db138e2018-04-19 09:04:13 +0200760 // Sending one frame will have allocate the encoder.
Niels Möllerd0f0f682019-01-14 09:09:53 +0100761 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller4db138e2018-04-19 09:04:13 +0200762
763 ASSERT_EQ_WAIT(1u, encoder_factory_->encoders().size(), kTimeout);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000764
Anders Carlsson67537952018-05-03 11:28:29 +0200765 cricket::VideoSendParameters new_parameters;
766 new_parameters.codecs.push_back(GetEngineCodec("VP8"));
767 EXPECT_TRUE(channel->SetSendParameters(new_parameters));
Niels Möller4db138e2018-04-19 09:04:13 +0200768
769 // Sending one frame will switch encoder.
Niels Möllerd0f0f682019-01-14 09:09:53 +0100770 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller4db138e2018-04-19 09:04:13 +0200771
Anders Carlsson8a150d92018-05-14 12:40:04 +0200772 EXPECT_EQ_WAIT(1u, encoder_factory_->encoders().size(), kTimeout);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000773}
774
eladalonf1841382017-06-12 01:16:46 -0700775TEST_F(WebRtcVideoEngineTest,
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000776 UsesSimulcastAdapterForVp8WithCombinedVP8AndH264Factory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200777 encoder_factory_->AddSupportedVideoCodecType("VP8");
778 encoder_factory_->AddSupportedVideoCodecType("H264");
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000779
Sebastian Jansson84848f22018-11-16 10:40:36 +0100780 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700781 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
magjed509e4fe2016-11-18 01:34:11 -0800782 cricket::VideoSendParameters parameters;
783 parameters.codecs.push_back(GetEngineCodec("VP8"));
784 EXPECT_TRUE(channel->SetSendParameters(parameters));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000785
Peter Boström0c4e06b2015-10-07 12:23:21 +0200786 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000787
Yves Gerey665174f2018-06-19 15:03:05 +0200788 EXPECT_TRUE(channel->AddSendStream(CreateSimStreamParams("cname", ssrcs)));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000789 EXPECT_TRUE(channel->SetSend(true));
790
791 // Send a fake frame, or else the media engine will configure the simulcast
792 // encoder adapter at a low-enough size that it'll only create a single
793 // encoder layer.
Niels Mollera882fb32019-01-21 08:44:37 +0000794 FakeVideoCapturerWithTaskQueue capturer;
795 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, &capturer));
796 EXPECT_EQ(cricket::CS_RUNNING,
797 capturer.Start(capturer.GetSupportedFormats()->front()));
798 EXPECT_TRUE(capturer.CaptureFrame());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000799
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200800 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
801 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000802 EXPECT_EQ(webrtc::kVideoCodecVP8,
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200803 encoder_factory_->encoders()[0]->GetCodecSettings().codecType);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000804
805 channel.reset();
806 // Make sure DestroyVideoEncoder was called on the factory.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200807 EXPECT_EQ(0u, encoder_factory_->encoders().size());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000808}
809
eladalonf1841382017-06-12 01:16:46 -0700810TEST_F(WebRtcVideoEngineTest,
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000811 DestroysNonSimulcastEncoderFromCombinedVP8AndH264Factory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200812 encoder_factory_->AddSupportedVideoCodecType("VP8");
813 encoder_factory_->AddSupportedVideoCodecType("H264");
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000814
Sebastian Jansson84848f22018-11-16 10:40:36 +0100815 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700816 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
magjed509e4fe2016-11-18 01:34:11 -0800817 cricket::VideoSendParameters parameters;
818 parameters.codecs.push_back(GetEngineCodec("H264"));
819 EXPECT_TRUE(channel->SetSendParameters(parameters));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000820
821 EXPECT_TRUE(
822 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Per21d45d22016-10-30 21:37:57 +0100823
824 // Send a frame of 720p. This should trigger a "real" encoder initialization.
Niels Mollera882fb32019-01-21 08:44:37 +0000825 cricket::VideoFormat format(
826 1280, 720, cricket::VideoFormat::FpsToInterval(30), cricket::FOURCC_I420);
827 FakeVideoCapturerWithTaskQueue capturer;
828 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
829 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(format));
830 EXPECT_TRUE(capturer.CaptureFrame());
Niels Möller4db138e2018-04-19 09:04:13 +0200831 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
832 ASSERT_EQ(1u, encoder_factory_->encoders().size());
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200833 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000834 EXPECT_EQ(webrtc::kVideoCodecH264,
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200835 encoder_factory_->encoders()[0]->GetCodecSettings().codecType);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000836
837 channel.reset();
838 // Make sure DestroyVideoEncoder was called on the factory.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200839 ASSERT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000840}
841
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200842TEST_F(WebRtcVideoEngineTest, SimulcastEnabledForH264BehindFieldTrial) {
843 webrtc::test::ScopedFieldTrials override_field_trials_(
844 "WebRTC-H264Simulcast/Enabled/");
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200845 encoder_factory_->AddSupportedVideoCodecType("H264");
noahricfdac5162015-08-27 01:59:29 -0700846
Sebastian Jansson84848f22018-11-16 10:40:36 +0100847 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700848 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
Anders Carlsson67537952018-05-03 11:28:29 +0200849 cricket::VideoSendParameters parameters;
850 parameters.codecs.push_back(GetEngineCodec("H264"));
851 EXPECT_TRUE(channel->SetSendParameters(parameters));
noahricfdac5162015-08-27 01:59:29 -0700852
Peter Boström0c4e06b2015-10-07 12:23:21 +0200853 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
noahricfdac5162015-08-27 01:59:29 -0700854 EXPECT_TRUE(
855 channel->AddSendStream(cricket::CreateSimStreamParams("cname", ssrcs)));
Peter Boströmce23bee2016-02-02 14:14:30 +0100856
857 // Send a frame of 720p. This should trigger a "real" encoder initialization.
Niels Mollera882fb32019-01-21 08:44:37 +0000858 cricket::VideoFormat format(
859 1280, 720, cricket::VideoFormat::FpsToInterval(30), cricket::FOURCC_I420);
860 FakeVideoCapturerWithTaskQueue capturer;
861 EXPECT_TRUE(channel->SetVideoSend(ssrcs[0], nullptr, &capturer));
862 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(format));
863 EXPECT_TRUE(capturer.CaptureFrame());
Peter Boströmce23bee2016-02-02 14:14:30 +0100864
Niels Möller4db138e2018-04-19 09:04:13 +0200865 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200866 ASSERT_EQ(1u, encoder_factory_->encoders().size());
867 FakeWebRtcVideoEncoder* encoder = encoder_factory_->encoders()[0];
868 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
noahricfdac5162015-08-27 01:59:29 -0700869 EXPECT_EQ(webrtc::kVideoCodecH264, encoder->GetCodecSettings().codecType);
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200870 EXPECT_LT(1u, encoder->GetCodecSettings().numberOfSimulcastStreams);
Niels Möllerff40b142018-04-09 08:49:14 +0200871 EXPECT_TRUE(channel->SetVideoSend(ssrcs[0], nullptr, nullptr));
noahricfdac5162015-08-27 01:59:29 -0700872}
873
brandtrffc61182016-11-28 06:02:22 -0800874// Test that the FlexFEC field trial properly alters the output of
eladalonf1841382017-06-12 01:16:46 -0700875// WebRtcVideoEngine::codecs(), for an existing |engine_| object.
brandtrffc61182016-11-28 06:02:22 -0800876//
877// TODO(brandtr): Remove this test, when the FlexFEC field trial is gone.
eladalonf1841382017-06-12 01:16:46 -0700878TEST_F(WebRtcVideoEngineTest,
brandtrffc61182016-11-28 06:02:22 -0800879 Flexfec03SupportedAsInternalCodecBehindFieldTrial) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200880 encoder_factory_->AddSupportedVideoCodecType("VP8");
881
brandtrffc61182016-11-28 06:02:22 -0800882 auto is_flexfec = [](const VideoCodec& codec) {
883 if (codec.name == "flexfec-03")
884 return true;
885 return false;
886 };
887
888 // FlexFEC is not active without field trial.
brandtrffc61182016-11-28 06:02:22 -0800889 const std::vector<VideoCodec> codecs_before = engine_.codecs();
890 EXPECT_EQ(codecs_before.end(), std::find_if(codecs_before.begin(),
891 codecs_before.end(), is_flexfec));
892
893 // FlexFEC is active with field trial.
894 webrtc::test::ScopedFieldTrials override_field_trials_(
brandtr340e3fd2017-02-28 15:43:10 -0800895 "WebRTC-FlexFEC-03-Advertised/Enabled/");
brandtrffc61182016-11-28 06:02:22 -0800896 const std::vector<VideoCodec> codecs_after = engine_.codecs();
897 EXPECT_NE(codecs_after.end(),
898 std::find_if(codecs_after.begin(), codecs_after.end(), is_flexfec));
899}
900
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200901// Test that codecs are added in the order they are reported from the factory.
902TEST_F(WebRtcVideoEngineTest, ReportSupportedCodecs) {
903 encoder_factory_->AddSupportedVideoCodecType("VP8");
904 const char* kFakeCodecName = "FakeCodec";
905 encoder_factory_->AddSupportedVideoCodecType(kFakeCodecName);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000906
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200907 // The last reported codec should appear after the first codec in the vector.
Oleh Prypina40f8242017-12-21 13:32:23 +0100908 const size_t vp8_index = GetEngineCodecIndex("VP8");
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200909 const size_t fake_codec_index = GetEngineCodecIndex(kFakeCodecName);
910 EXPECT_LT(vp8_index, fake_codec_index);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000911}
912
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200913// Test that a codec that was added after the engine was initialized
brandtrffc61182016-11-28 06:02:22 -0800914// does show up in the codec list after it was added.
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200915TEST_F(WebRtcVideoEngineTest, ReportSupportedAddedCodec) {
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100916 const char* kFakeExternalCodecName1 = "FakeExternalCodec1";
917 const char* kFakeExternalCodecName2 = "FakeExternalCodec2";
Magnus Jedvert154ee1f2017-11-15 19:27:11 +0100918
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100919 // Set up external encoder factory with first codec, and initialize engine.
920 encoder_factory_->AddSupportedVideoCodecType(kFakeExternalCodecName1);
921
brandtrffc61182016-11-28 06:02:22 -0800922 std::vector<cricket::VideoCodec> codecs_before(engine_.codecs());
brandtrffc61182016-11-28 06:02:22 -0800923
924 // Add second codec.
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100925 encoder_factory_->AddSupportedVideoCodecType(kFakeExternalCodecName2);
brandtrffc61182016-11-28 06:02:22 -0800926 std::vector<cricket::VideoCodec> codecs_after(engine_.codecs());
Sami Kalliomäkie9a18b22018-07-13 10:28:21 +0200927 // The codec itself and RTX should have been added.
928 EXPECT_EQ(codecs_before.size() + 2, codecs_after.size());
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100929
930 // Check that both fake codecs are present and that the second fake codec
931 // appears after the first fake codec.
Oleh Prypina40f8242017-12-21 13:32:23 +0100932 const size_t fake_codec_index1 = GetEngineCodecIndex(kFakeExternalCodecName1);
933 const size_t fake_codec_index2 = GetEngineCodecIndex(kFakeExternalCodecName2);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100934 EXPECT_LT(fake_codec_index1, fake_codec_index2);
brandtrffc61182016-11-28 06:02:22 -0800935}
936
Sami Kalliomäkie9a18b22018-07-13 10:28:21 +0200937TEST_F(WebRtcVideoEngineTest, ReportRtxForExternalCodec) {
938 const char* kFakeCodecName = "FakeCodec";
939 encoder_factory_->AddSupportedVideoCodecType(kFakeCodecName);
940
941 const size_t fake_codec_index = GetEngineCodecIndex(kFakeCodecName);
942 EXPECT_EQ("rtx", engine_.codecs().at(fake_codec_index + 1).name);
943}
944
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200945TEST_F(WebRtcVideoEngineTest, RegisterDecodersIfSupported) {
946 encoder_factory_->AddSupportedVideoCodecType("VP8");
Anders Carlsson67537952018-05-03 11:28:29 +0200947 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200948 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -0800949 parameters.codecs.push_back(GetEngineCodec("VP8"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000950
kwiberg686a8ef2016-02-26 03:00:35 -0800951 std::unique_ptr<VideoMediaChannel> channel(
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200952 SetRecvParamsWithSupportedCodecs(parameters.codecs));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000953
954 EXPECT_TRUE(
955 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200956 ASSERT_EQ(1u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000957
958 // Setting codecs of the same type should not reallocate the decoder.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200959 EXPECT_TRUE(channel->SetRecvParameters(parameters));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200960 EXPECT_EQ(1, decoder_factory_->GetNumCreatedDecoders());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000961
962 // Remove stream previously added to free the external decoder instance.
963 EXPECT_TRUE(channel->RemoveRecvStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200964 EXPECT_EQ(0u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000965}
966
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200967// Verifies that we can set up decoders.
968TEST_F(WebRtcVideoEngineTest, RegisterH264DecoderIfSupported) {
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000969 // TODO(pbos): Do not assume that encoder/decoder support is symmetric. We
970 // can't even query the WebRtcVideoDecoderFactory for supported codecs.
971 // For now we add a FakeWebRtcVideoEncoderFactory to add H264 to supported
972 // codecs.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200973 encoder_factory_->AddSupportedVideoCodecType("H264");
Anders Carlsson67537952018-05-03 11:28:29 +0200974 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("H264"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000975 std::vector<cricket::VideoCodec> codecs;
magjed509e4fe2016-11-18 01:34:11 -0800976 codecs.push_back(GetEngineCodec("H264"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000977
kwiberg686a8ef2016-02-26 03:00:35 -0800978 std::unique_ptr<VideoMediaChannel> channel(
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200979 SetRecvParamsWithSupportedCodecs(codecs));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000980
981 EXPECT_TRUE(
982 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200983 ASSERT_EQ(1u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000984}
985
Jonas Oreland49ac5952018-09-26 16:04:32 +0200986// Tests when GetSources is called with non-existing ssrc, it will return an
987// empty list of RtpSource without crashing.
988TEST_F(WebRtcVideoEngineTest, GetSourcesWithNonExistingSsrc) {
989 // Setup an recv stream with |kSsrc|.
990 encoder_factory_->AddSupportedVideoCodecType("VP8");
991 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("VP8"));
992 cricket::VideoRecvParameters parameters;
993 parameters.codecs.push_back(GetEngineCodec("VP8"));
994 std::unique_ptr<VideoMediaChannel> channel(
995 SetRecvParamsWithSupportedCodecs(parameters.codecs));
996
997 EXPECT_TRUE(
998 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
999
1000 // Call GetSources with |kSsrc + 1| which doesn't exist.
1001 std::vector<webrtc::RtpSource> sources = channel->GetSources(kSsrc + 1);
1002 EXPECT_EQ(0u, sources.size());
1003}
1004
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001005TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, NullFactories) {
1006 std::unique_ptr<webrtc::VideoEncoderFactory> encoder_factory;
1007 std::unique_ptr<webrtc::VideoDecoderFactory> decoder_factory;
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001008 std::unique_ptr<webrtc::VideoBitrateAllocatorFactory> rate_allocator_factory;
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001009 WebRtcVideoEngine engine(std::move(encoder_factory),
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001010 std::move(decoder_factory),
1011 std::move(rate_allocator_factory));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001012 EXPECT_EQ(0u, engine.codecs().size());
1013}
1014
1015TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, EmptyFactories) {
1016 // |engine| take ownership of the factories.
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -07001017 webrtc::MockVideoEncoderFactory* encoder_factory =
1018 new webrtc::MockVideoEncoderFactory();
1019 webrtc::MockVideoDecoderFactory* decoder_factory =
1020 new webrtc::MockVideoDecoderFactory();
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001021 webrtc::MockVideoBitrateAllocatorFactory* rate_allocator_factory =
1022 new webrtc::MockVideoBitrateAllocatorFactory();
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001023 WebRtcVideoEngine engine(
1024 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001025 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)),
1026 (std::unique_ptr<webrtc::VideoBitrateAllocatorFactory>(
1027 rate_allocator_factory)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001028 EXPECT_CALL(*encoder_factory, GetSupportedFormats());
1029 EXPECT_EQ(0u, engine.codecs().size());
1030 EXPECT_CALL(*encoder_factory, Die());
1031 EXPECT_CALL(*decoder_factory, Die());
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001032 EXPECT_CALL(*rate_allocator_factory, Die());
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001033}
1034
1035// Test full behavior in the video engine when video codec factories of the new
1036// type are injected supporting the single codec Vp8. Check the returned codecs
1037// from the engine and that we will create a Vp8 encoder and decoder using the
1038// new factories.
1039TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, Vp8) {
1040 // |engine| take ownership of the factories.
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -07001041 webrtc::MockVideoEncoderFactory* encoder_factory =
1042 new webrtc::MockVideoEncoderFactory();
1043 webrtc::MockVideoDecoderFactory* decoder_factory =
1044 new webrtc::MockVideoDecoderFactory();
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001045 webrtc::MockVideoBitrateAllocatorFactory* rate_allocator_factory =
1046 new webrtc::MockVideoBitrateAllocatorFactory();
1047 EXPECT_CALL(*rate_allocator_factory,
1048 CreateVideoBitrateAllocatorProxy(Field(
1049 &webrtc::VideoCodec::codecType, webrtc::kVideoCodecVP8)))
1050 .WillOnce(testing::Return(new webrtc::MockVideoBitrateAllocator()));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001051 WebRtcVideoEngine engine(
1052 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001053 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)),
1054 (std::unique_ptr<webrtc::VideoBitrateAllocatorFactory>(
1055 rate_allocator_factory)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001056 const webrtc::SdpVideoFormat vp8_format("VP8");
1057 const std::vector<webrtc::SdpVideoFormat> supported_formats = {vp8_format};
1058 EXPECT_CALL(*encoder_factory, GetSupportedFormats())
1059 .WillRepeatedly(testing::Return(supported_formats));
1060
1061 // Verify the codecs from the engine.
1062 const std::vector<VideoCodec> engine_codecs = engine.codecs();
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001063 // Verify default codecs has been added correctly.
1064 EXPECT_EQ(5u, engine_codecs.size());
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001065 EXPECT_EQ("VP8", engine_codecs.at(0).name);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001066
1067 // RTX codec for VP8.
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001068 EXPECT_EQ("rtx", engine_codecs.at(1).name);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001069 int vp8_associated_payload;
1070 EXPECT_TRUE(engine_codecs.at(1).GetParam(kCodecParamAssociatedPayloadType,
1071 &vp8_associated_payload));
1072 EXPECT_EQ(vp8_associated_payload, engine_codecs.at(0).id);
1073
1074 EXPECT_EQ(kRedCodecName, engine_codecs.at(2).name);
1075
1076 // RTX codec for RED.
1077 EXPECT_EQ("rtx", engine_codecs.at(3).name);
1078 int red_associated_payload;
1079 EXPECT_TRUE(engine_codecs.at(3).GetParam(kCodecParamAssociatedPayloadType,
1080 &red_associated_payload));
1081 EXPECT_EQ(red_associated_payload, engine_codecs.at(2).id);
1082
1083 EXPECT_EQ(kUlpfecCodecName, engine_codecs.at(4).name);
1084
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001085 int associated_payload_type;
1086 EXPECT_TRUE(engine_codecs.at(1).GetParam(
1087 cricket::kCodecParamAssociatedPayloadType, &associated_payload_type));
1088 EXPECT_EQ(engine_codecs.at(0).id, associated_payload_type);
1089 // Verify default parameters has been added to the VP8 codec.
1090 VerifyCodecHasDefaultFeedbackParams(engine_codecs.at(0));
1091
1092 // Mock encoder creation. |engine| take ownership of the encoder.
Mirta Dvornicic1ec2a162018-12-10 09:47:34 +00001093 webrtc::VideoEncoderFactory::CodecInfo codec_info;
1094 codec_info.is_hardware_accelerated = false;
1095 codec_info.has_internal_source = false;
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001096 const webrtc::SdpVideoFormat format("VP8");
Mirta Dvornicic1ec2a162018-12-10 09:47:34 +00001097 EXPECT_CALL(*encoder_factory, QueryVideoEncoder(format))
1098 .WillRepeatedly(testing::Return(codec_info));
Anders Carlsson67537952018-05-03 11:28:29 +02001099 FakeWebRtcVideoEncoder* const encoder = new FakeWebRtcVideoEncoder(nullptr);
Niels Möllerc572ff32018-11-07 08:43:50 +01001100 rtc::Event encoder_created;
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001101 EXPECT_CALL(*encoder_factory, CreateVideoEncoderProxy(format))
Niels Möller4db138e2018-04-19 09:04:13 +02001102 .WillOnce(
1103 ::testing::DoAll(::testing::InvokeWithoutArgs(
1104 [&encoder_created]() { encoder_created.Set(); }),
1105 ::testing::Return(encoder)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001106
1107 // Mock decoder creation. |engine| take ownership of the decoder.
Anders Carlsson67537952018-05-03 11:28:29 +02001108 FakeWebRtcVideoDecoder* const decoder = new FakeWebRtcVideoDecoder(nullptr);
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001109 EXPECT_CALL(*decoder_factory, CreateVideoDecoderProxy(format))
1110 .WillOnce(testing::Return(decoder));
1111
1112 // Create a call.
1113 webrtc::RtcEventLogNullImpl event_log;
1114 std::unique_ptr<webrtc::Call> call(
1115 webrtc::Call::Create(webrtc::Call::Config(&event_log)));
1116
1117 // Create send channel.
1118 const int send_ssrc = 123;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001119 std::unique_ptr<VideoMediaChannel> send_channel(engine.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07001120 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001121 cricket::VideoSendParameters send_parameters;
1122 send_parameters.codecs.push_back(engine_codecs.at(0));
1123 EXPECT_TRUE(send_channel->SetSendParameters(send_parameters));
1124 send_channel->OnReadyToSend(true);
1125 EXPECT_TRUE(
1126 send_channel->AddSendStream(StreamParams::CreateLegacy(send_ssrc)));
1127 EXPECT_TRUE(send_channel->SetSend(true));
1128
Niels Möller4db138e2018-04-19 09:04:13 +02001129 // Set capturer.
Niels Mollera882fb32019-01-21 08:44:37 +00001130 FakeVideoCapturerWithTaskQueue capturer;
1131 EXPECT_EQ(cricket::CS_RUNNING,
1132 capturer.Start(capturer.GetSupportedFormats()->front()));
1133 EXPECT_TRUE(send_channel->SetVideoSend(send_ssrc, nullptr, &capturer));
Niels Möller4db138e2018-04-19 09:04:13 +02001134 // Sending one frame will allocate the encoder.
Niels Mollera882fb32019-01-21 08:44:37 +00001135 EXPECT_TRUE(capturer.CaptureFrame());
Niels Möller4db138e2018-04-19 09:04:13 +02001136 encoder_created.Wait(kTimeout);
1137
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001138 // Create recv channel.
1139 const int recv_ssrc = 321;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001140 std::unique_ptr<VideoMediaChannel> recv_channel(engine.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07001141 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001142 cricket::VideoRecvParameters recv_parameters;
1143 recv_parameters.codecs.push_back(engine_codecs.at(0));
1144 EXPECT_TRUE(recv_channel->SetRecvParameters(recv_parameters));
1145 EXPECT_TRUE(recv_channel->AddRecvStream(
1146 cricket::StreamParams::CreateLegacy(recv_ssrc)));
1147
1148 // Remove streams previously added to free the encoder and decoder instance.
1149 EXPECT_CALL(*encoder_factory, Die());
1150 EXPECT_CALL(*decoder_factory, Die());
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001151 EXPECT_CALL(*rate_allocator_factory, Die());
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001152 EXPECT_TRUE(send_channel->RemoveSendStream(send_ssrc));
1153 EXPECT_TRUE(recv_channel->RemoveRecvStream(recv_ssrc));
1154}
1155
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001156// Test behavior when decoder factory fails to create a decoder (returns null).
1157TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, NullDecoder) {
1158 // |engine| take ownership of the factories.
1159 webrtc::MockVideoEncoderFactory* encoder_factory =
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001160 new webrtc::MockVideoEncoderFactory();
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001161 webrtc::MockVideoDecoderFactory* decoder_factory =
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001162 new webrtc::MockVideoDecoderFactory();
1163 webrtc::MockVideoBitrateAllocatorFactory* rate_allocator_factory =
1164 new webrtc::MockVideoBitrateAllocatorFactory();
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001165 WebRtcVideoEngine engine(
1166 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001167 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)),
1168 (std::unique_ptr<webrtc::VideoBitrateAllocatorFactory>(
1169 rate_allocator_factory)));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001170 const webrtc::SdpVideoFormat vp8_format("VP8");
1171 const std::vector<webrtc::SdpVideoFormat> supported_formats = {vp8_format};
1172 EXPECT_CALL(*encoder_factory, GetSupportedFormats())
1173 .WillRepeatedly(testing::Return(supported_formats));
1174
1175 // Decoder creation fails.
1176 EXPECT_CALL(*decoder_factory, CreateVideoDecoderProxy(testing::_))
1177 .WillOnce(testing::Return(nullptr));
1178
1179 // Create a call.
1180 webrtc::RtcEventLogNullImpl event_log;
1181 std::unique_ptr<webrtc::Call> call(
1182 webrtc::Call::Create(webrtc::Call::Config(&event_log)));
1183
1184 // Create recv channel.
1185 const int recv_ssrc = 321;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001186 std::unique_ptr<VideoMediaChannel> recv_channel(engine.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07001187 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001188 cricket::VideoRecvParameters recv_parameters;
1189 recv_parameters.codecs.push_back(engine.codecs().front());
1190 EXPECT_TRUE(recv_channel->SetRecvParameters(recv_parameters));
1191 EXPECT_TRUE(recv_channel->AddRecvStream(
1192 cricket::StreamParams::CreateLegacy(recv_ssrc)));
1193
1194 // Remove streams previously added to free the encoder and decoder instance.
1195 EXPECT_TRUE(recv_channel->RemoveRecvStream(recv_ssrc));
1196}
1197
eladalonf1841382017-06-12 01:16:46 -07001198TEST_F(WebRtcVideoEngineTest, DISABLED_RecreatesEncoderOnContentTypeChange) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001199 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson8f83b422018-02-21 13:07:13 +01001200 std::unique_ptr<FakeCall> fake_call(new FakeCall());
Anders Carlsson5f2bb622018-05-14 09:48:06 +02001201 std::unique_ptr<VideoMediaChannel> channel(
1202 SetSendParamsWithAllSupportedCodecs());
sprangf24a0642017-02-28 13:23:26 -08001203 ASSERT_TRUE(
1204 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
1205 cricket::VideoCodec codec = GetEngineCodec("VP8");
1206 cricket::VideoSendParameters parameters;
1207 parameters.codecs.push_back(codec);
1208 channel->OnReadyToSend(true);
1209 channel->SetSend(true);
1210 ASSERT_TRUE(channel->SetSendParameters(parameters));
1211
Niels Mollera882fb32019-01-21 08:44:37 +00001212 FakeVideoCapturerWithTaskQueue capturer;
sprangf24a0642017-02-28 13:23:26 -08001213 VideoOptions options;
Niels Mollera882fb32019-01-21 08:44:37 +00001214 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001215
Niels Mollera882fb32019-01-21 08:44:37 +00001216 EXPECT_EQ(cricket::CS_RUNNING,
1217 capturer.Start(capturer.GetSupportedFormats()->front()));
1218 EXPECT_TRUE(capturer.CaptureFrame());
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001219 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001220 EXPECT_EQ(webrtc::VideoCodecMode::kRealtimeVideo,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001221 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001222
Niels Mollera882fb32019-01-21 08:44:37 +00001223 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
1224 EXPECT_TRUE(capturer.CaptureFrame());
sprangf24a0642017-02-28 13:23:26 -08001225 // No change in content type, keep current encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001226 EXPECT_EQ(1, encoder_factory_->GetNumCreatedEncoders());
sprangf24a0642017-02-28 13:23:26 -08001227
1228 options.is_screencast.emplace(true);
Niels Mollera882fb32019-01-21 08:44:37 +00001229 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
1230 EXPECT_TRUE(capturer.CaptureFrame());
sprangf24a0642017-02-28 13:23:26 -08001231 // Change to screen content, recreate encoder. For the simulcast encoder
1232 // adapter case, this will result in two calls since InitEncode triggers a
1233 // a new instance.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001234 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001235 EXPECT_EQ(webrtc::VideoCodecMode::kScreensharing,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001236 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001237
Niels Mollera882fb32019-01-21 08:44:37 +00001238 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
1239 EXPECT_TRUE(capturer.CaptureFrame());
sprangf24a0642017-02-28 13:23:26 -08001240 // Still screen content, no need to update encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001241 EXPECT_EQ(2, encoder_factory_->GetNumCreatedEncoders());
sprangf24a0642017-02-28 13:23:26 -08001242
1243 options.is_screencast.emplace(false);
1244 options.video_noise_reduction.emplace(false);
Niels Mollera882fb32019-01-21 08:44:37 +00001245 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001246 // Change back to regular video content, update encoder. Also change
1247 // a non |is_screencast| option just to verify it doesn't affect recreation.
Niels Mollera882fb32019-01-21 08:44:37 +00001248 EXPECT_TRUE(capturer.CaptureFrame());
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001249 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(3));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001250 EXPECT_EQ(webrtc::VideoCodecMode::kRealtimeVideo,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001251 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001252
1253 // Remove stream previously added to free the external encoder instance.
1254 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001255 EXPECT_EQ(0u, encoder_factory_->encoders().size());
sprangf24a0642017-02-28 13:23:26 -08001256}
1257
Niels Möller6557d0c2018-04-11 15:18:34 +02001258class WebRtcVideoChannelBaseTest : public testing::Test {
1259 protected:
1260 WebRtcVideoChannelBaseTest()
Jonas Oreland49ac5952018-09-26 16:04:32 +02001261 : engine_(webrtc::CreateBuiltinVideoEncoderFactory(),
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001262 webrtc::CreateBuiltinVideoDecoderFactory(),
1263 webrtc::CreateBuiltinVideoBitrateAllocatorFactory()) {}
Niels Möller6557d0c2018-04-11 15:18:34 +02001264
1265 virtual void SetUp() {
Jonas Oreland49ac5952018-09-26 16:04:32 +02001266 // One testcase calls SetUp in a loop, only create call_ once.
1267 if (!call_) {
1268 call_.reset(webrtc::Call::Create(webrtc::Call::Config(&event_log_)));
1269 }
Niels Möller6557d0c2018-04-11 15:18:34 +02001270 cricket::MediaConfig media_config;
1271 // Disabling cpu overuse detection actually disables quality scaling too; it
1272 // implies DegradationPreference kMaintainResolution. Automatic scaling
1273 // needs to be disabled, otherwise, tests which check the size of received
1274 // frames become flaky.
1275 media_config.video.enable_cpu_adaptation = false;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001276 channel_.reset(
1277 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
1278 call_.get(), media_config, cricket::VideoOptions(),
1279 webrtc::CryptoOptions())));
Niels Möller6557d0c2018-04-11 15:18:34 +02001280 channel_->OnReadyToSend(true);
1281 EXPECT_TRUE(channel_.get() != NULL);
1282 network_interface_.SetDestination(channel_.get());
Anton Sukhanov98a462c2018-10-17 13:15:42 -07001283 channel_->SetInterface(&network_interface_, /*media_transport=*/nullptr);
Niels Möller6557d0c2018-04-11 15:18:34 +02001284 cricket::VideoRecvParameters parameters;
1285 parameters.codecs = engine_.codecs();
1286 channel_->SetRecvParameters(parameters);
1287 EXPECT_TRUE(channel_->AddSendStream(DefaultSendStreamParams()));
Niels Mollera882fb32019-01-21 08:44:37 +00001288 video_capturer_.reset(CreateFakeVideoCapturer());
1289 cricket::VideoFormat format(640, 480,
1290 cricket::VideoFormat::FpsToInterval(kFramerate),
1291 cricket::FOURCC_I420);
1292 EXPECT_EQ(cricket::CS_RUNNING, video_capturer_->Start(format));
1293 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, video_capturer_.get()));
1294 }
1295
1296 virtual cricket::FakeVideoCapturerWithTaskQueue* CreateFakeVideoCapturer() {
1297 return new cricket::FakeVideoCapturerWithTaskQueue();
Niels Möller6557d0c2018-04-11 15:18:34 +02001298 }
1299
1300 // Utility method to setup an additional stream to send and receive video.
1301 // Used to test send and recv between two streams.
1302 void SetUpSecondStream() {
1303 SetUpSecondStreamWithNoRecv();
1304 // Setup recv for second stream.
1305 EXPECT_TRUE(channel_->AddRecvStream(
1306 cricket::StreamParams::CreateLegacy(kSsrc + 2)));
1307 // Make the second renderer available for use by a new stream.
1308 EXPECT_TRUE(channel_->SetSink(kSsrc + 2, &renderer2_));
1309 }
1310 // Setup an additional stream just to send video. Defer add recv stream.
1311 // This is required if you want to test unsignalled recv of video rtp packets.
1312 void SetUpSecondStreamWithNoRecv() {
1313 // SetUp() already added kSsrc make sure duplicate SSRCs cant be added.
Yves Gerey665174f2018-06-19 15:03:05 +02001314 EXPECT_TRUE(
1315 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001316 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
Yves Gerey665174f2018-06-19 15:03:05 +02001317 EXPECT_FALSE(
1318 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001319 EXPECT_TRUE(channel_->AddSendStream(
1320 cricket::StreamParams::CreateLegacy(kSsrc + 2)));
1321 // We dont add recv for the second stream.
1322
1323 // Setup the receive and renderer for second stream after send.
Niels Mollera882fb32019-01-21 08:44:37 +00001324 video_capturer_2_.reset(CreateFakeVideoCapturer());
1325 cricket::VideoFormat format(640, 480,
1326 cricket::VideoFormat::FpsToInterval(kFramerate),
1327 cricket::FOURCC_I420);
1328 EXPECT_EQ(cricket::CS_RUNNING, video_capturer_2_->Start(format));
1329
Yves Gerey665174f2018-06-19 15:03:05 +02001330 EXPECT_TRUE(
Niels Mollera882fb32019-01-21 08:44:37 +00001331 channel_->SetVideoSend(kSsrc + 2, nullptr, video_capturer_2_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001332 }
Yves Gerey665174f2018-06-19 15:03:05 +02001333 virtual void TearDown() { channel_.reset(); }
1334 bool SetDefaultCodec() { return SetOneCodec(DefaultCodec()); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001335
1336 bool SetOneCodec(const cricket::VideoCodec& codec) {
Niels Mollera882fb32019-01-21 08:44:37 +00001337 cricket::VideoFormat capture_format(
1338 kVideoWidth, kVideoHeight,
1339 cricket::VideoFormat::FpsToInterval(kFramerate), cricket::FOURCC_I420);
1340
1341 if (video_capturer_) {
1342 EXPECT_EQ(cricket::CS_RUNNING, video_capturer_->Start(capture_format));
1343 }
1344 if (video_capturer_2_) {
1345 EXPECT_EQ(cricket::CS_RUNNING, video_capturer_2_->Start(capture_format));
1346 }
Niels Möller6557d0c2018-04-11 15:18:34 +02001347
1348 bool sending = channel_->sending();
1349 bool success = SetSend(false);
1350 if (success) {
1351 cricket::VideoSendParameters parameters;
1352 parameters.codecs.push_back(codec);
1353 success = channel_->SetSendParameters(parameters);
1354 }
1355 if (success) {
1356 success = SetSend(sending);
1357 }
1358 return success;
1359 }
Yves Gerey665174f2018-06-19 15:03:05 +02001360 bool SetSend(bool send) { return channel_->SetSend(send); }
Niels Mollera882fb32019-01-21 08:44:37 +00001361 bool SendFrame() {
1362 if (video_capturer_2_) {
1363 video_capturer_2_->CaptureFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001364 }
Niels Mollera882fb32019-01-21 08:44:37 +00001365 return video_capturer_.get() && video_capturer_->CaptureFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001366 }
1367 bool WaitAndSendFrame(int wait_ms) {
1368 bool ret = rtc::Thread::Current()->ProcessMessages(wait_ms);
Niels Mollera882fb32019-01-21 08:44:37 +00001369 ret &= SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001370 return ret;
1371 }
Yves Gerey665174f2018-06-19 15:03:05 +02001372 int NumRtpBytes() { return network_interface_.NumRtpBytes(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001373 int NumRtpBytes(uint32_t ssrc) {
1374 return network_interface_.NumRtpBytes(ssrc);
1375 }
Yves Gerey665174f2018-06-19 15:03:05 +02001376 int NumRtpPackets() { return network_interface_.NumRtpPackets(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001377 int NumRtpPackets(uint32_t ssrc) {
1378 return network_interface_.NumRtpPackets(ssrc);
1379 }
Yves Gerey665174f2018-06-19 15:03:05 +02001380 int NumSentSsrcs() { return network_interface_.NumSentSsrcs(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001381 const rtc::CopyOnWriteBuffer* GetRtpPacket(int index) {
1382 return network_interface_.GetRtpPacket(index);
1383 }
1384 static int GetPayloadType(const rtc::CopyOnWriteBuffer* p) {
Åsa Persson23cd45a2018-07-03 10:40:40 +02001385 webrtc::RTPHeader header;
1386 EXPECT_TRUE(ParseRtpPacket(p, &header));
1387 return header.payloadType;
Niels Möller6557d0c2018-04-11 15:18:34 +02001388 }
Åsa Persson23cd45a2018-07-03 10:40:40 +02001389
Niels Möller6557d0c2018-04-11 15:18:34 +02001390 static bool ParseRtpPacket(const rtc::CopyOnWriteBuffer* p,
Åsa Persson23cd45a2018-07-03 10:40:40 +02001391 webrtc::RTPHeader* header) {
1392 std::unique_ptr<webrtc::RtpHeaderParser> parser(
1393 webrtc::RtpHeaderParser::Create());
1394 return parser->Parse(p->cdata(), p->size(), header);
Niels Möller6557d0c2018-04-11 15:18:34 +02001395 }
1396
1397 // Tests that we can send and receive frames.
1398 void SendAndReceive(const cricket::VideoCodec& codec) {
1399 EXPECT_TRUE(SetOneCodec(codec));
1400 EXPECT_TRUE(SetSend(true));
1401 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1402 EXPECT_EQ(0, renderer_.num_rendered_frames());
Niels Mollera882fb32019-01-21 08:44:37 +00001403 EXPECT_TRUE(SendFrame());
Niels Möller6557d0c2018-04-11 15:18:34 +02001404 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1405 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1406 EXPECT_EQ(codec.id, GetPayloadType(p.get()));
1407 }
1408
1409 void SendReceiveManyAndGetStats(const cricket::VideoCodec& codec,
Yves Gerey665174f2018-06-19 15:03:05 +02001410 int duration_sec,
1411 int fps) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001412 EXPECT_TRUE(SetOneCodec(codec));
1413 EXPECT_TRUE(SetSend(true));
1414 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1415 EXPECT_EQ(0, renderer_.num_rendered_frames());
1416 for (int i = 0; i < duration_sec; ++i) {
1417 for (int frame = 1; frame <= fps; ++frame) {
1418 EXPECT_TRUE(WaitAndSendFrame(1000 / fps));
1419 EXPECT_FRAME_WAIT(frame + i * fps, kVideoWidth, kVideoHeight, kTimeout);
1420 }
1421 }
1422 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1423 EXPECT_EQ(codec.id, GetPayloadType(p.get()));
1424 }
1425
Niels Möller6557d0c2018-04-11 15:18:34 +02001426 cricket::VideoSenderInfo GetSenderStats(size_t i) {
1427 cricket::VideoMediaInfo info;
1428 EXPECT_TRUE(channel_->GetStats(&info));
1429 return info.senders[i];
1430 }
1431
1432 cricket::VideoReceiverInfo GetReceiverStats(size_t i) {
1433 cricket::VideoMediaInfo info;
1434 EXPECT_TRUE(channel_->GetStats(&info));
1435 return info.receivers[i];
1436 }
1437
1438 // Two streams one channel tests.
1439
1440 // Tests that we can send and receive frames.
1441 void TwoStreamsSendAndReceive(const cricket::VideoCodec& codec) {
1442 SetUpSecondStream();
1443 // Test sending and receiving on first stream.
1444 SendAndReceive(codec);
1445 // Test sending and receiving on second stream.
1446 EXPECT_EQ_WAIT(1, renderer2_.num_rendered_frames(), kTimeout);
1447 EXPECT_GT(NumRtpPackets(), 0);
1448 EXPECT_EQ(1, renderer2_.num_rendered_frames());
1449 }
1450
1451 cricket::VideoCodec GetEngineCodec(const std::string& name) {
1452 for (const cricket::VideoCodec& engine_codec : engine_.codecs()) {
Niels Möller039743e2018-10-23 10:07:25 +02001453 if (absl::EqualsIgnoreCase(name, engine_codec.name))
Niels Möller6557d0c2018-04-11 15:18:34 +02001454 return engine_codec;
1455 }
1456 // This point should never be reached.
1457 ADD_FAILURE() << "Unrecognized codec name: " << name;
1458 return cricket::VideoCodec();
1459 }
1460
1461 cricket::VideoCodec DefaultCodec() { return GetEngineCodec("VP8"); }
1462
1463 cricket::StreamParams DefaultSendStreamParams() {
1464 return cricket::StreamParams::CreateLegacy(kSsrc);
1465 }
1466
1467 webrtc::RtcEventLogNullImpl event_log_;
Jonas Oreland49ac5952018-09-26 16:04:32 +02001468 std::unique_ptr<webrtc::Call> call_;
Niels Möller6557d0c2018-04-11 15:18:34 +02001469 WebRtcVideoEngine engine_;
Niels Mollera882fb32019-01-21 08:44:37 +00001470 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> video_capturer_;
1471 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> video_capturer_2_;
Niels Möller6557d0c2018-04-11 15:18:34 +02001472 std::unique_ptr<WebRtcVideoChannel> channel_;
1473 cricket::FakeNetworkInterface network_interface_;
1474 cricket::FakeVideoRenderer renderer_;
1475
1476 // Used by test cases where 2 streams are run on the same channel.
1477 cricket::FakeVideoRenderer renderer2_;
1478};
1479
1480// Test that SetSend works.
srtee0c2eea2017-12-15 17:44:33 +01001481TEST_F(WebRtcVideoChannelBaseTest, SetSend) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001482 EXPECT_FALSE(channel_->sending());
Niels Mollera882fb32019-01-21 08:44:37 +00001483 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, video_capturer_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001484 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1485 EXPECT_FALSE(channel_->sending());
1486 EXPECT_TRUE(SetSend(true));
1487 EXPECT_TRUE(channel_->sending());
Niels Mollera882fb32019-01-21 08:44:37 +00001488 EXPECT_TRUE(SendFrame());
Niels Möller6557d0c2018-04-11 15:18:34 +02001489 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
1490 EXPECT_TRUE(SetSend(false));
1491 EXPECT_FALSE(channel_->sending());
srtee0c2eea2017-12-15 17:44:33 +01001492}
Niels Möller6557d0c2018-04-11 15:18:34 +02001493
1494// Test that SetSend fails without codecs being set.
srtee0c2eea2017-12-15 17:44:33 +01001495TEST_F(WebRtcVideoChannelBaseTest, SetSendWithoutCodecs) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001496 EXPECT_FALSE(channel_->sending());
1497 EXPECT_FALSE(SetSend(true));
1498 EXPECT_FALSE(channel_->sending());
srtee0c2eea2017-12-15 17:44:33 +01001499}
Niels Möller6557d0c2018-04-11 15:18:34 +02001500
1501// Test that we properly set the send and recv buffer sizes by the time
1502// SetSend is called.
srtee0c2eea2017-12-15 17:44:33 +01001503TEST_F(WebRtcVideoChannelBaseTest, SetSendSetsTransportBufferSizes) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001504 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1505 EXPECT_TRUE(SetSend(true));
1506 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
Johannes Krond38a2b82018-10-23 11:31:19 +02001507 EXPECT_EQ(256 * 1024, network_interface_.recvbuf_size());
Erik Språng820ebd02018-08-20 17:14:25 +02001508}
1509
Niels Möller6557d0c2018-04-11 15:18:34 +02001510// Test that stats work properly for a 1-1 call.
srtee0c2eea2017-12-15 17:44:33 +01001511TEST_F(WebRtcVideoChannelBaseTest, GetStats) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001512 const int kDurationSec = 3;
1513 const int kFps = 10;
1514 SendReceiveManyAndGetStats(DefaultCodec(), kDurationSec, kFps);
1515
1516 cricket::VideoMediaInfo info;
1517 EXPECT_TRUE(channel_->GetStats(&info));
1518
1519 ASSERT_EQ(1U, info.senders.size());
1520 // TODO(whyuan): bytes_sent and bytes_rcvd are different. Are both payload?
1521 // For webrtc, bytes_sent does not include the RTP header length.
1522 EXPECT_GT(info.senders[0].bytes_sent, 0);
1523 EXPECT_EQ(NumRtpPackets(), info.senders[0].packets_sent);
1524 EXPECT_EQ(0.0, info.senders[0].fraction_lost);
1525 ASSERT_TRUE(info.senders[0].codec_payload_type);
1526 EXPECT_EQ(DefaultCodec().id, *info.senders[0].codec_payload_type);
1527 EXPECT_EQ(0, info.senders[0].firs_rcvd);
1528 EXPECT_EQ(0, info.senders[0].plis_rcvd);
1529 EXPECT_EQ(0, info.senders[0].nacks_rcvd);
1530 EXPECT_EQ(kVideoWidth, info.senders[0].send_frame_width);
1531 EXPECT_EQ(kVideoHeight, info.senders[0].send_frame_height);
1532 EXPECT_GT(info.senders[0].framerate_input, 0);
1533 EXPECT_GT(info.senders[0].framerate_sent, 0);
1534
1535 EXPECT_EQ(1U, info.send_codecs.count(DefaultCodec().id));
1536 EXPECT_EQ(DefaultCodec().ToCodecParameters(),
1537 info.send_codecs[DefaultCodec().id]);
1538
1539 ASSERT_EQ(1U, info.receivers.size());
1540 EXPECT_EQ(1U, info.senders[0].ssrcs().size());
1541 EXPECT_EQ(1U, info.receivers[0].ssrcs().size());
1542 EXPECT_EQ(info.senders[0].ssrcs()[0], info.receivers[0].ssrcs()[0]);
1543 ASSERT_TRUE(info.receivers[0].codec_payload_type);
1544 EXPECT_EQ(DefaultCodec().id, *info.receivers[0].codec_payload_type);
1545 EXPECT_EQ(NumRtpBytes(), info.receivers[0].bytes_rcvd);
1546 EXPECT_EQ(NumRtpPackets(), info.receivers[0].packets_rcvd);
1547 EXPECT_EQ(0.0, info.receivers[0].fraction_lost);
1548 EXPECT_EQ(0, info.receivers[0].packets_lost);
1549 // TODO(asapersson): Not set for webrtc. Handle missing stats.
1550 // EXPECT_EQ(0, info.receivers[0].packets_concealed);
1551 EXPECT_EQ(0, info.receivers[0].firs_sent);
1552 EXPECT_EQ(0, info.receivers[0].plis_sent);
1553 EXPECT_EQ(0, info.receivers[0].nacks_sent);
1554 EXPECT_EQ(kVideoWidth, info.receivers[0].frame_width);
1555 EXPECT_EQ(kVideoHeight, info.receivers[0].frame_height);
1556 EXPECT_GT(info.receivers[0].framerate_rcvd, 0);
1557 EXPECT_GT(info.receivers[0].framerate_decoded, 0);
1558 EXPECT_GT(info.receivers[0].framerate_output, 0);
1559
1560 EXPECT_EQ(1U, info.receive_codecs.count(DefaultCodec().id));
1561 EXPECT_EQ(DefaultCodec().ToCodecParameters(),
1562 info.receive_codecs[DefaultCodec().id]);
srtee0c2eea2017-12-15 17:44:33 +01001563}
Niels Möller6557d0c2018-04-11 15:18:34 +02001564
1565// Test that stats work properly for a conf call with multiple recv streams.
srtee0c2eea2017-12-15 17:44:33 +01001566TEST_F(WebRtcVideoChannelBaseTest, GetStatsMultipleRecvStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001567 cricket::FakeVideoRenderer renderer1, renderer2;
1568 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1569 cricket::VideoSendParameters parameters;
1570 parameters.codecs.push_back(DefaultCodec());
1571 parameters.conference_mode = true;
1572 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1573 EXPECT_TRUE(SetSend(true));
Yves Gerey665174f2018-06-19 15:03:05 +02001574 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
1575 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001576 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
1577 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
1578 EXPECT_EQ(0, renderer1.num_rendered_frames());
1579 EXPECT_EQ(0, renderer2.num_rendered_frames());
1580 std::vector<uint32_t> ssrcs;
1581 ssrcs.push_back(1);
1582 ssrcs.push_back(2);
1583 network_interface_.SetConferenceMode(true, ssrcs);
Niels Mollera882fb32019-01-21 08:44:37 +00001584 EXPECT_TRUE(SendFrame());
Niels Möller6557d0c2018-04-11 15:18:34 +02001585 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kVideoWidth, kVideoHeight,
1586 kTimeout);
1587 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kVideoWidth, kVideoHeight,
1588 kTimeout);
1589
1590 EXPECT_TRUE(channel_->SetSend(false));
1591
1592 cricket::VideoMediaInfo info;
1593 EXPECT_TRUE(channel_->GetStats(&info));
1594 ASSERT_EQ(1U, info.senders.size());
1595 // TODO(whyuan): bytes_sent and bytes_rcvd are different. Are both payload?
1596 // For webrtc, bytes_sent does not include the RTP header length.
1597 EXPECT_GT(GetSenderStats(0).bytes_sent, 0);
1598 EXPECT_EQ_WAIT(NumRtpPackets(), GetSenderStats(0).packets_sent, kTimeout);
1599 EXPECT_EQ(kVideoWidth, GetSenderStats(0).send_frame_width);
1600 EXPECT_EQ(kVideoHeight, GetSenderStats(0).send_frame_height);
1601
1602 ASSERT_EQ(2U, info.receivers.size());
1603 for (size_t i = 0; i < info.receivers.size(); ++i) {
1604 EXPECT_EQ(1U, GetReceiverStats(i).ssrcs().size());
1605 EXPECT_EQ(i + 1, GetReceiverStats(i).ssrcs()[0]);
1606 EXPECT_EQ_WAIT(NumRtpBytes(), GetReceiverStats(i).bytes_rcvd, kTimeout);
Yves Gerey665174f2018-06-19 15:03:05 +02001607 EXPECT_EQ_WAIT(NumRtpPackets(), GetReceiverStats(i).packets_rcvd, kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001608 EXPECT_EQ_WAIT(kVideoWidth, GetReceiverStats(i).frame_width, kTimeout);
1609 EXPECT_EQ_WAIT(kVideoHeight, GetReceiverStats(i).frame_height, kTimeout);
1610 }
srtee0c2eea2017-12-15 17:44:33 +01001611}
Niels Möller6557d0c2018-04-11 15:18:34 +02001612
1613// Test that stats work properly for a conf call with multiple send streams.
srtee0c2eea2017-12-15 17:44:33 +01001614TEST_F(WebRtcVideoChannelBaseTest, GetStatsMultipleSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001615 // Normal setup; note that we set the SSRC explicitly to ensure that
1616 // it will come first in the senders map.
1617 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1618 cricket::VideoSendParameters parameters;
1619 parameters.codecs.push_back(DefaultCodec());
1620 parameters.conference_mode = true;
1621 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Yves Gerey665174f2018-06-19 15:03:05 +02001622 EXPECT_TRUE(
1623 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001624 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
1625 EXPECT_TRUE(SetSend(true));
Niels Mollera882fb32019-01-21 08:44:37 +00001626 EXPECT_TRUE(SendFrame());
Niels Möller6557d0c2018-04-11 15:18:34 +02001627 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
1628 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1629
1630 // Add an additional capturer, and hook up a renderer to receive it.
1631 cricket::FakeVideoRenderer renderer2;
Niels Mollera882fb32019-01-21 08:44:37 +00001632 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> capturer(
1633 CreateFakeVideoCapturer());
Niels Möller6557d0c2018-04-11 15:18:34 +02001634 const int kTestWidth = 160;
1635 const int kTestHeight = 120;
Niels Mollera882fb32019-01-21 08:44:37 +00001636 cricket::VideoFormat format(kTestWidth, kTestHeight,
1637 cricket::VideoFormat::FpsToInterval(5),
1638 cricket::FOURCC_I420);
1639 EXPECT_EQ(cricket::CS_RUNNING, capturer->Start(format));
Yves Gerey665174f2018-06-19 15:03:05 +02001640 EXPECT_TRUE(
1641 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(5678)));
Niels Mollera882fb32019-01-21 08:44:37 +00001642 EXPECT_TRUE(channel_->SetVideoSend(5678, nullptr, capturer.get()));
Yves Gerey665174f2018-06-19 15:03:05 +02001643 EXPECT_TRUE(
1644 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(5678)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001645 EXPECT_TRUE(channel_->SetSink(5678, &renderer2));
Niels Mollera882fb32019-01-21 08:44:37 +00001646 EXPECT_TRUE(capturer->CaptureCustomFrame(kTestWidth, kTestHeight));
Yves Gerey665174f2018-06-19 15:03:05 +02001647 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kTestWidth, kTestHeight,
1648 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001649
1650 // Get stats, and make sure they are correct for two senders. We wait until
1651 // the number of expected packets have been sent to avoid races where we
1652 // check stats before it has been updated.
1653 cricket::VideoMediaInfo info;
1654 for (uint32_t i = 0; i < kTimeout; ++i) {
1655 rtc::Thread::Current()->ProcessMessages(1);
1656 EXPECT_TRUE(channel_->GetStats(&info));
1657 ASSERT_EQ(2U, info.senders.size());
1658 if (info.senders[0].packets_sent + info.senders[1].packets_sent ==
1659 NumRtpPackets()) {
1660 // Stats have been updated for both sent frames, expectations can be
1661 // checked now.
1662 break;
1663 }
1664 }
1665 EXPECT_EQ(NumRtpPackets(),
1666 info.senders[0].packets_sent + info.senders[1].packets_sent)
1667 << "Timed out while waiting for packet counts for all sent packets.";
1668 EXPECT_EQ(1U, info.senders[0].ssrcs().size());
1669 EXPECT_EQ(1234U, info.senders[0].ssrcs()[0]);
1670 EXPECT_EQ(kVideoWidth, info.senders[0].send_frame_width);
1671 EXPECT_EQ(kVideoHeight, info.senders[0].send_frame_height);
1672 EXPECT_EQ(1U, info.senders[1].ssrcs().size());
1673 EXPECT_EQ(5678U, info.senders[1].ssrcs()[0]);
1674 EXPECT_EQ(kTestWidth, info.senders[1].send_frame_width);
1675 EXPECT_EQ(kTestHeight, info.senders[1].send_frame_height);
1676 // The capturer must be unregistered here as it runs out of it's scope next.
1677 channel_->SetVideoSend(5678, nullptr, nullptr);
srtee0c2eea2017-12-15 17:44:33 +01001678}
pbos@webrtc.org8fdeee62014-07-20 14:40:23 +00001679
Niels Möller6557d0c2018-04-11 15:18:34 +02001680// Test that we can set the bandwidth.
srtee0c2eea2017-12-15 17:44:33 +01001681TEST_F(WebRtcVideoChannelBaseTest, SetSendBandwidth) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001682 cricket::VideoSendParameters parameters;
1683 parameters.codecs.push_back(DefaultCodec());
1684 parameters.max_bandwidth_bps = -1; // <= 0 means unlimited.
1685 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1686 parameters.max_bandwidth_bps = 128 * 1024;
1687 EXPECT_TRUE(channel_->SetSendParameters(parameters));
srtee0c2eea2017-12-15 17:44:33 +01001688}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001689
Niels Möller6557d0c2018-04-11 15:18:34 +02001690// Test that we can set the SSRC for the default send source.
srtee0c2eea2017-12-15 17:44:33 +01001691TEST_F(WebRtcVideoChannelBaseTest, SetSendSsrc) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001692 EXPECT_TRUE(SetDefaultCodec());
1693 EXPECT_TRUE(SetSend(true));
Niels Mollera882fb32019-01-21 08:44:37 +00001694 EXPECT_TRUE(SendFrame());
Niels Möller6557d0c2018-04-11 15:18:34 +02001695 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001696 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001697 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001698 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1699 EXPECT_EQ(kSsrc, header.ssrc);
1700
Niels Möller6557d0c2018-04-11 15:18:34 +02001701 // Packets are being paced out, so these can mismatch between the first and
1702 // second call to NumRtpPackets until pending packets are paced out.
Åsa Persson23cd45a2018-07-03 10:40:40 +02001703 EXPECT_EQ_WAIT(NumRtpPackets(), NumRtpPackets(header.ssrc), kTimeout);
1704 EXPECT_EQ_WAIT(NumRtpBytes(), NumRtpBytes(header.ssrc), kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001705 EXPECT_EQ(1, NumSentSsrcs());
1706 EXPECT_EQ(0, NumRtpPackets(kSsrc - 1));
1707 EXPECT_EQ(0, NumRtpBytes(kSsrc - 1));
srtee0c2eea2017-12-15 17:44:33 +01001708}
Niels Möller6557d0c2018-04-11 15:18:34 +02001709
1710// Test that we can set the SSRC even after codecs are set.
srtee0c2eea2017-12-15 17:44:33 +01001711TEST_F(WebRtcVideoChannelBaseTest, SetSendSsrcAfterSetCodecs) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001712 // Remove stream added in Setup.
1713 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1714 EXPECT_TRUE(SetDefaultCodec());
Niels Möller6557d0c2018-04-11 15:18:34 +02001715 EXPECT_TRUE(
Yves Gerey665174f2018-06-19 15:03:05 +02001716 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(999)));
Niels Mollera882fb32019-01-21 08:44:37 +00001717 EXPECT_TRUE(channel_->SetVideoSend(999u, nullptr, video_capturer_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001718 EXPECT_TRUE(SetSend(true));
1719 EXPECT_TRUE(WaitAndSendFrame(0));
1720 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001721 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001722 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001723 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1724 EXPECT_EQ(999u, header.ssrc);
Niels Möller6557d0c2018-04-11 15:18:34 +02001725 // Packets are being paced out, so these can mismatch between the first and
1726 // second call to NumRtpPackets until pending packets are paced out.
Åsa Persson23cd45a2018-07-03 10:40:40 +02001727 EXPECT_EQ_WAIT(NumRtpPackets(), NumRtpPackets(header.ssrc), kTimeout);
1728 EXPECT_EQ_WAIT(NumRtpBytes(), NumRtpBytes(header.ssrc), kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001729 EXPECT_EQ(1, NumSentSsrcs());
1730 EXPECT_EQ(0, NumRtpPackets(kSsrc));
1731 EXPECT_EQ(0, NumRtpBytes(kSsrc));
srtee0c2eea2017-12-15 17:44:33 +01001732}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001733
Niels Möller6557d0c2018-04-11 15:18:34 +02001734// Test that we can set the default video renderer before and after
1735// media is received.
srtee0c2eea2017-12-15 17:44:33 +01001736TEST_F(WebRtcVideoChannelBaseTest, SetSink) {
Yves Gerey665174f2018-06-19 15:03:05 +02001737 uint8_t data1[] = {0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
1738 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
Niels Möller6557d0c2018-04-11 15:18:34 +02001739
1740 rtc::CopyOnWriteBuffer packet1(data1, sizeof(data1));
1741 rtc::SetBE32(packet1.data() + 8, kSsrc);
1742 channel_->SetSink(kDefaultReceiveSsrc, NULL);
1743 EXPECT_TRUE(SetDefaultCodec());
1744 EXPECT_TRUE(SetSend(true));
1745 EXPECT_EQ(0, renderer_.num_rendered_frames());
Niels Möllere6933812018-11-05 13:01:41 +01001746 channel_->OnPacketReceived(&packet1, /* packet_time_us */ -1);
Niels Möller6557d0c2018-04-11 15:18:34 +02001747 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
Niels Mollera882fb32019-01-21 08:44:37 +00001748 EXPECT_TRUE(SendFrame());
Niels Möller6557d0c2018-04-11 15:18:34 +02001749 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
srtee0c2eea2017-12-15 17:44:33 +01001750}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001751
Niels Möller6557d0c2018-04-11 15:18:34 +02001752// Tests setting up and configuring a send stream.
srtee0c2eea2017-12-15 17:44:33 +01001753TEST_F(WebRtcVideoChannelBaseTest, AddRemoveSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001754 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1755 EXPECT_TRUE(SetSend(true));
1756 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
Niels Mollera882fb32019-01-21 08:44:37 +00001757 EXPECT_TRUE(SendFrame());
Niels Möller6557d0c2018-04-11 15:18:34 +02001758 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1759 EXPECT_GT(NumRtpPackets(), 0);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001760 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001761 size_t last_packet = NumRtpPackets() - 1;
Yves Gerey665174f2018-06-19 15:03:05 +02001762 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(
1763 GetRtpPacket(static_cast<int>(last_packet)));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001764 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1765 EXPECT_EQ(kSsrc, header.ssrc);
Niels Möller6557d0c2018-04-11 15:18:34 +02001766
1767 // Remove the send stream that was added during Setup.
1768 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1769 int rtp_packets = NumRtpPackets();
1770
Niels Möller6557d0c2018-04-11 15:18:34 +02001771 EXPECT_TRUE(
Yves Gerey665174f2018-06-19 15:03:05 +02001772 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(789u)));
Niels Mollera882fb32019-01-21 08:44:37 +00001773 EXPECT_TRUE(channel_->SetVideoSend(789u, nullptr, video_capturer_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001774 EXPECT_EQ(rtp_packets, NumRtpPackets());
1775 // Wait 30ms to guarantee the engine does not drop the frame.
1776 EXPECT_TRUE(WaitAndSendFrame(30));
1777 EXPECT_TRUE_WAIT(NumRtpPackets() > rtp_packets, kTimeout);
1778
1779 last_packet = NumRtpPackets() - 1;
1780 p.reset(GetRtpPacket(static_cast<int>(last_packet)));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001781 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1782 EXPECT_EQ(789u, header.ssrc);
srtee0c2eea2017-12-15 17:44:33 +01001783}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001784
Niels Möller6557d0c2018-04-11 15:18:34 +02001785// Tests the behavior of incoming streams in a conference scenario.
srtee0c2eea2017-12-15 17:44:33 +01001786TEST_F(WebRtcVideoChannelBaseTest, SimulateConference) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001787 cricket::FakeVideoRenderer renderer1, renderer2;
1788 EXPECT_TRUE(SetDefaultCodec());
1789 cricket::VideoSendParameters parameters;
1790 parameters.codecs.push_back(DefaultCodec());
1791 parameters.conference_mode = true;
1792 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1793 EXPECT_TRUE(SetSend(true));
Yves Gerey665174f2018-06-19 15:03:05 +02001794 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
1795 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001796 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
1797 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
1798 EXPECT_EQ(0, renderer1.num_rendered_frames());
1799 EXPECT_EQ(0, renderer2.num_rendered_frames());
1800 std::vector<uint32_t> ssrcs;
1801 ssrcs.push_back(1);
1802 ssrcs.push_back(2);
1803 network_interface_.SetConferenceMode(true, ssrcs);
Niels Mollera882fb32019-01-21 08:44:37 +00001804 EXPECT_TRUE(SendFrame());
Niels Möller6557d0c2018-04-11 15:18:34 +02001805 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kVideoWidth, kVideoHeight,
1806 kTimeout);
1807 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kVideoWidth, kVideoHeight,
1808 kTimeout);
1809
1810 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1811 EXPECT_EQ(DefaultCodec().id, GetPayloadType(p.get()));
1812 EXPECT_EQ(kVideoWidth, renderer1.width());
1813 EXPECT_EQ(kVideoHeight, renderer1.height());
1814 EXPECT_EQ(kVideoWidth, renderer2.width());
1815 EXPECT_EQ(kVideoHeight, renderer2.height());
1816 EXPECT_TRUE(channel_->RemoveRecvStream(2));
1817 EXPECT_TRUE(channel_->RemoveRecvStream(1));
srtee0c2eea2017-12-15 17:44:33 +01001818}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001819
Niels Möller6557d0c2018-04-11 15:18:34 +02001820// Tests that we can add and remove capturers and frames are sent out properly
srtee0c2eea2017-12-15 17:44:33 +01001821TEST_F(WebRtcVideoChannelBaseTest, DISABLED_AddRemoveCapturer) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001822 using cricket::VideoCodec;
1823 using cricket::VideoOptions;
1824 using cricket::VideoFormat;
1825 using cricket::FOURCC_I420;
1826
1827 VideoCodec codec = DefaultCodec();
1828 const int time_between_send_ms = VideoFormat::FpsToInterval(kFramerate);
1829 EXPECT_TRUE(SetOneCodec(codec));
1830 EXPECT_TRUE(SetSend(true));
1831 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1832 EXPECT_EQ(0, renderer_.num_rendered_frames());
Niels Mollera882fb32019-01-21 08:44:37 +00001833 EXPECT_TRUE(SendFrame());
Niels Möller6557d0c2018-04-11 15:18:34 +02001834 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
Niels Mollera882fb32019-01-21 08:44:37 +00001835 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> capturer(
1836 CreateFakeVideoCapturer());
Niels Möller6557d0c2018-04-11 15:18:34 +02001837
1838 // TODO(nisse): This testcase fails if we don't configure
1839 // screencast. It's unclear why, I see nothing obvious in this
1840 // test which is related to screencast logic.
1841 VideoOptions video_options;
1842 video_options.is_screencast = true;
1843 channel_->SetVideoSend(kSsrc, &video_options, nullptr);
1844
Niels Mollera882fb32019-01-21 08:44:37 +00001845 VideoFormat format(480, 360, VideoFormat::FpsToInterval(30), FOURCC_I420);
1846 EXPECT_EQ(cricket::CS_RUNNING, capturer->Start(format));
1847 // All capturers start generating frames with the same timestamp. ViE does
1848 // not allow the same timestamp to be used. Capture one frame before
1849 // associating the capturer with the channel.
1850 EXPECT_TRUE(capturer->CaptureCustomFrame(format.width, format.height));
1851
Niels Möller6557d0c2018-04-11 15:18:34 +02001852 int captured_frames = 1;
1853 for (int iterations = 0; iterations < 2; ++iterations) {
Niels Mollera882fb32019-01-21 08:44:37 +00001854 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, capturer.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001855 rtc::Thread::Current()->ProcessMessages(time_between_send_ms);
Niels Mollera882fb32019-01-21 08:44:37 +00001856 EXPECT_TRUE(capturer->CaptureCustomFrame(format.width, format.height));
Niels Möller6557d0c2018-04-11 15:18:34 +02001857 ++captured_frames;
1858 // Wait until frame of right size is captured.
1859 EXPECT_TRUE_WAIT(renderer_.num_rendered_frames() >= captured_frames &&
Niels Mollera882fb32019-01-21 08:44:37 +00001860 format.width == renderer_.width() &&
1861 format.height == renderer_.height() &&
1862 !renderer_.black_frame(),
Yves Gerey665174f2018-06-19 15:03:05 +02001863 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001864 EXPECT_GE(renderer_.num_rendered_frames(), captured_frames);
Niels Mollera882fb32019-01-21 08:44:37 +00001865 EXPECT_EQ(format.width, renderer_.width());
1866 EXPECT_EQ(format.height, renderer_.height());
Niels Möller6557d0c2018-04-11 15:18:34 +02001867 captured_frames = renderer_.num_rendered_frames() + 1;
1868 EXPECT_FALSE(renderer_.black_frame());
1869 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1870 // Make sure a black frame is generated within the specified timeout.
1871 // The black frame should be the resolution of the previous frame to
1872 // prevent expensive encoder reconfigurations.
1873 EXPECT_TRUE_WAIT(renderer_.num_rendered_frames() >= captured_frames &&
Niels Mollera882fb32019-01-21 08:44:37 +00001874 format.width == renderer_.width() &&
1875 format.height == renderer_.height() &&
1876 renderer_.black_frame(),
Yves Gerey665174f2018-06-19 15:03:05 +02001877 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001878 EXPECT_GE(renderer_.num_rendered_frames(), captured_frames);
Niels Mollera882fb32019-01-21 08:44:37 +00001879 EXPECT_EQ(format.width, renderer_.width());
1880 EXPECT_EQ(format.height, renderer_.height());
Niels Möller6557d0c2018-04-11 15:18:34 +02001881 EXPECT_TRUE(renderer_.black_frame());
1882
1883 // The black frame has the same timestamp as the next frame since it's
1884 // timestamp is set to the last frame's timestamp + interval. WebRTC will
1885 // not render a frame with the same timestamp so capture another frame
1886 // with the frame capturer to increment the next frame's timestamp.
Niels Mollera882fb32019-01-21 08:44:37 +00001887 EXPECT_TRUE(capturer->CaptureCustomFrame(format.width, format.height));
Niels Möller6557d0c2018-04-11 15:18:34 +02001888 }
srtee0c2eea2017-12-15 17:44:33 +01001889}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001890
Niels Möller6557d0c2018-04-11 15:18:34 +02001891// Tests that if SetVideoSend is called with a NULL capturer after the
1892// capturer was already removed, the application doesn't crash (and no black
1893// frame is sent).
srtee0c2eea2017-12-15 17:44:33 +01001894TEST_F(WebRtcVideoChannelBaseTest, RemoveCapturerWithoutAdd) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001895 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1896 EXPECT_TRUE(SetSend(true));
1897 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1898 EXPECT_EQ(0, renderer_.num_rendered_frames());
Niels Mollera882fb32019-01-21 08:44:37 +00001899 EXPECT_TRUE(SendFrame());
Niels Möller6557d0c2018-04-11 15:18:34 +02001900 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1901 // Wait for one frame so they don't get dropped because we send frames too
1902 // tightly.
1903 rtc::Thread::Current()->ProcessMessages(30);
1904 // Remove the capturer.
1905 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1906
1907 // No capturer was added, so this SetVideoSend shouldn't do anything.
1908 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1909 rtc::Thread::Current()->ProcessMessages(300);
1910 // Verify no more frames were sent.
1911 EXPECT_EQ(1, renderer_.num_rendered_frames());
srtee0c2eea2017-12-15 17:44:33 +01001912}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001913
Niels Möller6557d0c2018-04-11 15:18:34 +02001914// Tests that we can add and remove capturer as unique sources.
srtee0c2eea2017-12-15 17:44:33 +01001915TEST_F(WebRtcVideoChannelBaseTest, AddRemoveCapturerMultipleSources) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001916 // WebRTC implementation will drop frames if pushed to quickly. Wait the
1917 // interval time to avoid that.
1918 // WebRTC implementation will drop frames if pushed to quickly. Wait the
1919 // interval time to avoid that.
1920 // Set up the stream associated with the engine.
Yves Gerey665174f2018-06-19 15:03:05 +02001921 EXPECT_TRUE(
1922 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001923 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
1924 cricket::VideoFormat capture_format(
1925 kVideoWidth, kVideoHeight,
1926 cricket::VideoFormat::FpsToInterval(kFramerate), cricket::FOURCC_I420);
1927 // Set up additional stream 1.
1928 cricket::FakeVideoRenderer renderer1;
1929 EXPECT_FALSE(channel_->SetSink(1, &renderer1));
Yves Gerey665174f2018-06-19 15:03:05 +02001930 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001931 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
Yves Gerey665174f2018-06-19 15:03:05 +02001932 EXPECT_TRUE(channel_->AddSendStream(cricket::StreamParams::CreateLegacy(1)));
Niels Mollera882fb32019-01-21 08:44:37 +00001933 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> capturer1(
1934 CreateFakeVideoCapturer());
1935 EXPECT_EQ(cricket::CS_RUNNING, capturer1->Start(capture_format));
Niels Möller6557d0c2018-04-11 15:18:34 +02001936 // Set up additional stream 2.
1937 cricket::FakeVideoRenderer renderer2;
1938 EXPECT_FALSE(channel_->SetSink(2, &renderer2));
Yves Gerey665174f2018-06-19 15:03:05 +02001939 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001940 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
Yves Gerey665174f2018-06-19 15:03:05 +02001941 EXPECT_TRUE(channel_->AddSendStream(cricket::StreamParams::CreateLegacy(2)));
Niels Mollera882fb32019-01-21 08:44:37 +00001942 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> capturer2(
1943 CreateFakeVideoCapturer());
1944 EXPECT_EQ(cricket::CS_RUNNING, capturer2->Start(capture_format));
Niels Möller6557d0c2018-04-11 15:18:34 +02001945 // State for all the streams.
1946 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1947 // A limitation in the lmi implementation requires that SetVideoSend() is
1948 // called after SetOneCodec().
1949 // TODO(hellner): this seems like an unnecessary constraint, fix it.
Niels Mollera882fb32019-01-21 08:44:37 +00001950 EXPECT_TRUE(channel_->SetVideoSend(1, nullptr, capturer1.get()));
1951 EXPECT_TRUE(channel_->SetVideoSend(2, nullptr, capturer2.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001952 EXPECT_TRUE(SetSend(true));
1953 // Test capturer associated with engine.
1954 const int kTestWidth = 160;
1955 const int kTestHeight = 120;
Niels Mollera882fb32019-01-21 08:44:37 +00001956 EXPECT_TRUE(capturer1->CaptureCustomFrame(kTestWidth, kTestHeight));
Yves Gerey665174f2018-06-19 15:03:05 +02001957 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kTestWidth, kTestHeight,
1958 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001959 // Capture a frame with additional capturer2, frames should be received
Niels Mollera882fb32019-01-21 08:44:37 +00001960 EXPECT_TRUE(capturer2->CaptureCustomFrame(kTestWidth, kTestHeight));
Yves Gerey665174f2018-06-19 15:03:05 +02001961 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kTestWidth, kTestHeight,
1962 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001963 // Successfully remove the capturer.
1964 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1965 // The capturers must be unregistered here as it runs out of it's scope
1966 // next.
1967 EXPECT_TRUE(channel_->SetVideoSend(1, nullptr, nullptr));
1968 EXPECT_TRUE(channel_->SetVideoSend(2, nullptr, nullptr));
srtee0c2eea2017-12-15 17:44:33 +01001969}
Niels Möller6557d0c2018-04-11 15:18:34 +02001970
1971// Tests empty StreamParams is rejected.
srtee0c2eea2017-12-15 17:44:33 +01001972TEST_F(WebRtcVideoChannelBaseTest, RejectEmptyStreamParams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001973 // Remove the send stream that was added during Setup.
1974 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1975
1976 cricket::StreamParams empty;
1977 EXPECT_FALSE(channel_->AddSendStream(empty));
Yves Gerey665174f2018-06-19 15:03:05 +02001978 EXPECT_TRUE(
1979 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(789u)));
srtee0c2eea2017-12-15 17:44:33 +01001980}
Niels Möller6557d0c2018-04-11 15:18:34 +02001981
1982// Test that multiple send streams can be created and deleted properly.
srtee0c2eea2017-12-15 17:44:33 +01001983TEST_F(WebRtcVideoChannelBaseTest, MultipleSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001984 // Remove stream added in Setup. I.e. remove stream corresponding to default
1985 // channel.
1986 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02001987 const unsigned int kSsrcsSize = sizeof(kSsrcs4) / sizeof(kSsrcs4[0]);
Niels Möller6557d0c2018-04-11 15:18:34 +02001988 for (unsigned int i = 0; i < kSsrcsSize; ++i) {
1989 EXPECT_TRUE(channel_->AddSendStream(
1990 cricket::StreamParams::CreateLegacy(kSsrcs4[i])));
1991 }
1992 // Delete one of the non default channel streams, let the destructor delete
1993 // the remaining ones.
1994 EXPECT_TRUE(channel_->RemoveSendStream(kSsrcs4[kSsrcsSize - 1]));
1995 // Stream should already be deleted.
1996 EXPECT_FALSE(channel_->RemoveSendStream(kSsrcs4[kSsrcsSize - 1]));
srtee0c2eea2017-12-15 17:44:33 +01001997}
pbos@webrtc.orgc4175b92014-09-03 15:25:49 +00001998
eladalonf1841382017-06-12 01:16:46 -07001999TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8Vga) {
magjed509e4fe2016-11-18 01:34:11 -08002000 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00002001}
2002
eladalonf1841382017-06-12 01:16:46 -07002003TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8Qvga) {
magjed509e4fe2016-11-18 01:34:11 -08002004 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00002005}
2006
eladalonf1841382017-06-12 01:16:46 -07002007TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8SvcQqvga) {
magjed509e4fe2016-11-18 01:34:11 -08002008 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00002009}
2010
eladalonf1841382017-06-12 01:16:46 -07002011TEST_F(WebRtcVideoChannelBaseTest, TwoStreamsSendAndReceive) {
Peter Boströmd1f584b2016-04-20 16:31:53 +02002012 // Set a high bitrate to not be downscaled by VP8 due to low initial start
2013 // bitrates. This currently happens at <250k, and two streams sharing 300k
2014 // initially will use QVGA instead of VGA.
2015 // TODO(pbos): Set up the quality scaler so that both senders reliably start
2016 // at QVGA, then verify that instead.
magjed509e4fe2016-11-18 01:34:11 -08002017 cricket::VideoCodec codec = GetEngineCodec("VP8");
Peter Boströmd1f584b2016-04-20 16:31:53 +02002018 codec.params[kCodecParamStartBitrate] = "1000000";
Niels Möller6557d0c2018-04-11 15:18:34 +02002019 TwoStreamsSendAndReceive(codec);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002020}
2021
eladalonf1841382017-06-12 01:16:46 -07002022class WebRtcVideoChannelTest : public WebRtcVideoEngineTest {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002023 public:
eladalonf1841382017-06-12 01:16:46 -07002024 WebRtcVideoChannelTest() : WebRtcVideoChannelTest("") {}
2025 explicit WebRtcVideoChannelTest(const char* field_trials)
Niels Mollera882fb32019-01-21 08:44:37 +00002026 : WebRtcVideoEngineTest(field_trials), last_ssrc_(0) {}
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00002027 void SetUp() override {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02002028 encoder_factory_->AddSupportedVideoCodecType("VP8");
2029 encoder_factory_->AddSupportedVideoCodecType("VP9");
2030#if defined(WEBRTC_USE_H264)
2031 encoder_factory_->AddSupportedVideoCodecType("H264");
2032#endif
2033
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002034 fake_call_.reset(new FakeCall());
Sebastian Jansson84848f22018-11-16 10:40:36 +01002035 channel_.reset(engine_.CreateMediaChannel(fake_call_.get(),
2036 GetMediaConfig(), VideoOptions(),
2037 webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002038 channel_->OnReadyToSend(true);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002039 last_ssrc_ = 123;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002040 send_parameters_.codecs = engine_.codecs();
2041 recv_parameters_.codecs = engine_.codecs();
2042 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002043 }
2044
2045 protected:
2046 FakeVideoSendStream* AddSendStream() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002047 return AddSendStream(StreamParams::CreateLegacy(++last_ssrc_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002048 }
2049
2050 FakeVideoSendStream* AddSendStream(const StreamParams& sp) {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002051 size_t num_streams = fake_call_->GetVideoSendStreams().size();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002052 EXPECT_TRUE(channel_->AddSendStream(sp));
2053 std::vector<FakeVideoSendStream*> streams =
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002054 fake_call_->GetVideoSendStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002055 EXPECT_EQ(num_streams + 1, streams.size());
2056 return streams[streams.size() - 1];
2057 }
2058
2059 std::vector<FakeVideoSendStream*> GetFakeSendStreams() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002060 return fake_call_->GetVideoSendStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002061 }
2062
2063 FakeVideoReceiveStream* AddRecvStream() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002064 return AddRecvStream(StreamParams::CreateLegacy(++last_ssrc_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002065 }
2066
2067 FakeVideoReceiveStream* AddRecvStream(const StreamParams& sp) {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002068 size_t num_streams = fake_call_->GetVideoReceiveStreams().size();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002069 EXPECT_TRUE(channel_->AddRecvStream(sp));
2070 std::vector<FakeVideoReceiveStream*> streams =
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002071 fake_call_->GetVideoReceiveStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002072 EXPECT_EQ(num_streams + 1, streams.size());
2073 return streams[streams.size() - 1];
2074 }
2075
pbos@webrtc.org00873182014-11-25 14:03:34 +00002076 void SetSendCodecsShouldWorkForBitrates(const char* min_bitrate_kbps,
2077 int expected_min_bitrate_bps,
2078 const char* start_bitrate_kbps,
2079 int expected_start_bitrate_bps,
2080 const char* max_bitrate_kbps,
2081 int expected_max_bitrate_bps) {
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002082 ExpectSetBitrateParameters(expected_min_bitrate_bps,
2083 expected_start_bitrate_bps,
2084 expected_max_bitrate_bps);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002085 auto& codecs = send_parameters_.codecs;
2086 codecs.clear();
magjed509e4fe2016-11-18 01:34:11 -08002087 codecs.push_back(GetEngineCodec("VP8"));
pbos@webrtc.org00873182014-11-25 14:03:34 +00002088 codecs[0].params[kCodecParamMinBitrate] = min_bitrate_kbps;
2089 codecs[0].params[kCodecParamStartBitrate] = start_bitrate_kbps;
2090 codecs[0].params[kCodecParamMaxBitrate] = max_bitrate_kbps;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002091 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002092 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002093
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002094 void ExpectSetBitrateParameters(int min_bitrate_bps,
2095 int start_bitrate_bps,
2096 int max_bitrate_bps) {
2097 EXPECT_CALL(
2098 *fake_call_->GetMockTransportControllerSend(),
2099 SetSdpBitrateParameters(AllOf(
2100 Field(&BitrateConstraints::min_bitrate_bps, min_bitrate_bps),
2101 Field(&BitrateConstraints::start_bitrate_bps, start_bitrate_bps),
2102 Field(&BitrateConstraints::max_bitrate_bps, max_bitrate_bps))));
2103 }
2104
2105 void ExpectSetMaxBitrate(int max_bitrate_bps) {
2106 EXPECT_CALL(*fake_call_->GetMockTransportControllerSend(),
2107 SetSdpBitrateParameters(Field(
2108 &BitrateConstraints::max_bitrate_bps, max_bitrate_bps)));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002109 }
2110
Johannes Kron9190b822018-10-29 11:22:05 +01002111 void TestExtmapAllowMixedCaller(bool extmap_allow_mixed) {
2112 // For a caller, the answer will be applied in set remote description
2113 // where SetSendParameters() is called.
2114 EXPECT_TRUE(
2115 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
2116 send_parameters_.extmap_allow_mixed = extmap_allow_mixed;
2117 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
2118 const webrtc::VideoSendStream::Config& config =
2119 fake_call_->GetVideoSendStreams()[0]->GetConfig();
2120 EXPECT_EQ(extmap_allow_mixed, config.rtp.extmap_allow_mixed);
2121 }
2122
2123 void TestExtmapAllowMixedCallee(bool extmap_allow_mixed) {
2124 // For a callee, the answer will be applied in set local description
2125 // where SetExtmapAllowMixed() and AddSendStream() are called.
2126 channel_->SetExtmapAllowMixed(extmap_allow_mixed);
2127 EXPECT_TRUE(
2128 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
2129 const webrtc::VideoSendStream::Config& config =
2130 fake_call_->GetVideoSendStreams()[0]->GetConfig();
2131 EXPECT_EQ(extmap_allow_mixed, config.rtp.extmap_allow_mixed);
2132 }
2133
isheriff6f8d6862016-05-26 11:24:55 -07002134 void TestSetSendRtpHeaderExtensions(const std::string& ext_uri) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002135 // Enable extension.
2136 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002137 cricket::VideoSendParameters parameters = send_parameters_;
isheriff6f8d6862016-05-26 11:24:55 -07002138 parameters.extensions.push_back(RtpExtension(ext_uri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002139 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002140 FakeVideoSendStream* send_stream =
2141 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2142
2143 // Verify the send extension id.
2144 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2145 EXPECT_EQ(id, send_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002146 EXPECT_EQ(ext_uri, send_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002147 // Verify call with same set of extensions returns true.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002148 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002149 // Verify that SetSendRtpHeaderExtensions doesn't implicitly add them for
2150 // receivers.
2151 EXPECT_TRUE(AddRecvStream(cricket::StreamParams::CreateLegacy(123))
2152 ->GetConfig()
2153 .rtp.extensions.empty());
2154
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002155 // Verify that existing RTP header extensions can be removed.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002156 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002157 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2158 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002159 EXPECT_TRUE(send_stream->GetConfig().rtp.extensions.empty());
2160
2161 // Verify that adding receive RTP header extensions adds them for existing
2162 // streams.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002163 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002164 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002165 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2166 EXPECT_EQ(id, send_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002167 EXPECT_EQ(ext_uri, send_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002168 }
2169
isheriff6f8d6862016-05-26 11:24:55 -07002170 void TestSetRecvRtpHeaderExtensions(const std::string& ext_uri) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002171 // Enable extension.
2172 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002173 cricket::VideoRecvParameters parameters = recv_parameters_;
isheriff6f8d6862016-05-26 11:24:55 -07002174 parameters.extensions.push_back(RtpExtension(ext_uri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002175 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002176
2177 FakeVideoReceiveStream* recv_stream =
2178 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2179
2180 // Verify the recv extension id.
2181 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
2182 EXPECT_EQ(id, recv_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002183 EXPECT_EQ(ext_uri, recv_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002184 // Verify call with same set of extensions returns true.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002185 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002186
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002187 // Verify that SetRecvRtpHeaderExtensions doesn't implicitly add them for
2188 // senders.
2189 EXPECT_TRUE(AddSendStream(cricket::StreamParams::CreateLegacy(123))
2190 ->GetConfig()
2191 .rtp.extensions.empty());
2192
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002193 // Verify that existing RTP header extensions can be removed.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002194 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002195 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
2196 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002197 EXPECT_TRUE(recv_stream->GetConfig().rtp.extensions.empty());
2198
2199 // Verify that adding receive RTP header extensions adds them for existing
2200 // streams.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002201 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002202 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002203 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
2204 EXPECT_EQ(id, recv_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002205 EXPECT_EQ(ext_uri, recv_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002206 }
2207
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002208 void TestExtensionFilter(const std::vector<std::string>& extensions,
2209 const std::string& expected_extension) {
2210 cricket::VideoSendParameters parameters = send_parameters_;
2211 int expected_id = -1;
2212 int id = 1;
2213 for (const std::string& extension : extensions) {
2214 if (extension == expected_extension)
2215 expected_id = id;
isheriff6f8d6862016-05-26 11:24:55 -07002216 parameters.extensions.push_back(RtpExtension(extension, id++));
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002217 }
2218 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2219 FakeVideoSendStream* send_stream =
2220 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2221
2222 // Verify that only one of them has been set, and that it is the one with
2223 // highest priority (transport sequence number).
2224 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2225 EXPECT_EQ(expected_id, send_stream->GetConfig().rtp.extensions[0].id);
2226 EXPECT_EQ(expected_extension,
isheriff6f8d6862016-05-26 11:24:55 -07002227 send_stream->GetConfig().rtp.extensions[0].uri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002228 }
2229
asapersson3c81a1a2017-06-14 05:52:21 -07002230 void TestDegradationPreference(bool resolution_scaling_enabled,
2231 bool fps_scaling_enabled);
2232
Erik Språngefbde372015-04-29 16:21:28 +02002233 void TestCpuAdaptation(bool enable_overuse, bool is_screenshare);
Peter Boström3548dd22015-05-22 18:48:36 +02002234 void TestReceiverLocalSsrcConfiguration(bool receiver_first);
magjed509e4fe2016-11-18 01:34:11 -08002235 void TestReceiveUnsignaledSsrcPacket(uint8_t payload_type,
2236 bool expect_created_receive_stream);
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002237
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002238 FakeVideoSendStream* SetDenoisingOption(
nisse05103312016-03-16 02:22:50 -07002239 uint32_t ssrc,
Niels Mollera882fb32019-01-21 08:44:37 +00002240 FakeVideoCapturerWithTaskQueue* capturer,
nisse0db023a2016-03-01 04:29:59 -08002241 bool enabled) {
nisse05103312016-03-16 02:22:50 -07002242 cricket::VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002243 options.video_noise_reduction = enabled;
Niels Mollera882fb32019-01-21 08:44:37 +00002244 EXPECT_TRUE(channel_->SetVideoSend(ssrc, &options, capturer));
nisse0db023a2016-03-01 04:29:59 -08002245 // Options only take effect on the next frame.
Niels Mollera882fb32019-01-21 08:44:37 +00002246 EXPECT_TRUE(capturer->CaptureFrame());
nisse0db023a2016-03-01 04:29:59 -08002247
Erik Språng143cec12015-04-28 10:01:41 +02002248 return fake_call_->GetVideoSendStreams().back();
2249 }
2250
Peter Boström2feafdb2015-09-09 14:32:14 +02002251 FakeVideoSendStream* SetUpSimulcast(bool enabled, bool with_rtx) {
2252 const int kRtxSsrcOffset = 0xDEADBEEF;
Erik Språng143cec12015-04-28 10:01:41 +02002253 last_ssrc_ += 3;
Peter Boström2feafdb2015-09-09 14:32:14 +02002254 std::vector<uint32_t> ssrcs;
2255 std::vector<uint32_t> rtx_ssrcs;
2256 uint32_t num_streams = enabled ? 3 : 1;
2257 for (uint32_t i = 0; i < num_streams; ++i) {
2258 uint32_t ssrc = last_ssrc_ + i;
2259 ssrcs.push_back(ssrc);
2260 if (with_rtx) {
2261 rtx_ssrcs.push_back(ssrc + kRtxSsrcOffset);
2262 }
Erik Språng143cec12015-04-28 10:01:41 +02002263 }
Peter Boström2feafdb2015-09-09 14:32:14 +02002264 if (with_rtx) {
2265 return AddSendStream(
2266 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
2267 }
2268 return AddSendStream(CreateSimStreamParams("cname", ssrcs));
Erik Språng143cec12015-04-28 10:01:41 +02002269 }
2270
perkjfa10b552016-10-02 23:45:26 -07002271 int GetMaxEncoderBitrate() {
skvladdc1c62c2016-03-16 19:07:43 -07002272 std::vector<FakeVideoSendStream*> streams =
2273 fake_call_->GetVideoSendStreams();
perkjfa10b552016-10-02 23:45:26 -07002274 EXPECT_EQ(1u, streams.size());
skvladdc1c62c2016-03-16 19:07:43 -07002275 FakeVideoSendStream* stream = streams[streams.size() - 1];
Mirko Bonadeif859e552018-05-30 15:31:29 +02002276 EXPECT_EQ(1u, stream->GetEncoderConfig().number_of_streams);
perkjfa10b552016-10-02 23:45:26 -07002277 return stream->GetVideoStreams()[0].max_bitrate_bps;
skvladdc1c62c2016-03-16 19:07:43 -07002278 }
2279
perkjfa10b552016-10-02 23:45:26 -07002280 void SetAndExpectMaxBitrate(int global_max,
skvladdc1c62c2016-03-16 19:07:43 -07002281 int stream_max,
2282 int expected_encoder_bitrate) {
2283 VideoSendParameters limited_send_params = send_parameters_;
2284 limited_send_params.max_bandwidth_bps = global_max;
2285 EXPECT_TRUE(channel_->SetSendParameters(limited_send_params));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07002286 webrtc::RtpParameters parameters =
2287 channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07002288 EXPECT_EQ(1UL, parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01002289 parameters.encodings[0].max_bitrate_bps = stream_max;
Zach Steinba37b4b2018-01-23 15:02:36 -08002290 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07002291 // Read back the parameteres and verify they have the correct value
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07002292 parameters = channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07002293 EXPECT_EQ(1UL, parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01002294 EXPECT_EQ(stream_max, parameters.encodings[0].max_bitrate_bps);
skvladdc1c62c2016-03-16 19:07:43 -07002295 // Verify that the new value propagated down to the encoder
perkjfa10b552016-10-02 23:45:26 -07002296 EXPECT_EQ(expected_encoder_bitrate, GetMaxEncoderBitrate());
skvladdc1c62c2016-03-16 19:07:43 -07002297 }
2298
Åsa Persson55659812018-06-18 17:51:32 +02002299 // Values from kSimulcastConfigs in simulcast.cc.
2300 const std::vector<webrtc::VideoStream> GetSimulcastBitrates720p() const {
2301 std::vector<webrtc::VideoStream> layers(3);
2302 layers[0].min_bitrate_bps = 30000;
2303 layers[0].target_bitrate_bps = 150000;
2304 layers[0].max_bitrate_bps = 200000;
2305 layers[1].min_bitrate_bps = 150000;
2306 layers[1].target_bitrate_bps = 500000;
2307 layers[1].max_bitrate_bps = 700000;
2308 layers[2].min_bitrate_bps = 600000;
2309 layers[2].target_bitrate_bps = 2500000;
2310 layers[2].max_bitrate_bps = 2500000;
2311 return layers;
2312 }
2313
kwiberg686a8ef2016-02-26 03:00:35 -08002314 std::unique_ptr<FakeCall> fake_call_;
2315 std::unique_ptr<VideoMediaChannel> channel_;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002316 cricket::VideoSendParameters send_parameters_;
2317 cricket::VideoRecvParameters recv_parameters_;
Peter Boström0c4e06b2015-10-07 12:23:21 +02002318 uint32_t last_ssrc_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002319};
2320
eladalonf1841382017-06-12 01:16:46 -07002321TEST_F(WebRtcVideoChannelTest, SetsSyncGroupFromSyncLabel) {
Peter Boström0c4e06b2015-10-07 12:23:21 +02002322 const uint32_t kVideoSsrc = 123;
pbos8fc7fa72015-07-15 08:02:58 -07002323 const std::string kSyncLabel = "AvSyncLabel";
2324
2325 cricket::StreamParams sp = cricket::StreamParams::CreateLegacy(kVideoSsrc);
Seth Hampson845e8782018-03-02 11:34:10 -08002326 sp.set_stream_ids({kSyncLabel});
pbos8fc7fa72015-07-15 08:02:58 -07002327 EXPECT_TRUE(channel_->AddRecvStream(sp));
2328
Mirko Bonadeif859e552018-05-30 15:31:29 +02002329 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
pbos8fc7fa72015-07-15 08:02:58 -07002330 EXPECT_EQ(kSyncLabel,
2331 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group)
2332 << "SyncGroup should be set based on sync_label";
2333}
2334
eladalonf1841382017-06-12 01:16:46 -07002335TEST_F(WebRtcVideoChannelTest, RecvStreamWithSimAndRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002336 cricket::VideoSendParameters parameters;
2337 parameters.codecs = engine_.codecs();
2338 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002339 EXPECT_TRUE(channel_->SetSend(true));
nisse4b4dc862016-02-17 05:25:36 -08002340 parameters.conference_mode = true;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002341 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002342
2343 // Send side.
Peter Boström0c4e06b2015-10-07 12:23:21 +02002344 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
2345 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002346 FakeVideoSendStream* send_stream = AddSendStream(
2347 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
2348
2349 ASSERT_EQ(rtx_ssrcs.size(), send_stream->GetConfig().rtp.rtx.ssrcs.size());
2350 for (size_t i = 0; i < rtx_ssrcs.size(); ++i)
2351 EXPECT_EQ(rtx_ssrcs[i], send_stream->GetConfig().rtp.rtx.ssrcs[i]);
2352
2353 // Receiver side.
2354 FakeVideoReceiveStream* recv_stream = AddRecvStream(
2355 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
nisse26e3abb2017-08-25 04:44:25 -07002356 EXPECT_FALSE(
2357 recv_stream->GetConfig().rtp.rtx_associated_payload_types.empty());
nisseca5706d2017-09-11 02:32:16 -07002358 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
Peter Boströmd8b01092016-05-12 16:44:36 +02002359 << "RTX should be mapped for all decoders/payload types.";
nisseca5706d2017-09-11 02:32:16 -07002360 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02002361 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07002362 << "RTX should be mapped for the RED payload type";
2363
brandtr14742122017-01-27 04:53:07 -08002364 EXPECT_EQ(rtx_ssrcs[0], recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002365}
2366
eladalonf1841382017-06-12 01:16:46 -07002367TEST_F(WebRtcVideoChannelTest, RecvStreamWithRtx) {
pbos@webrtc.orge322a172014-06-13 11:47:28 +00002368 // Setup one channel with an associated RTX stream.
2369 cricket::StreamParams params =
2370 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
2371 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
2372 FakeVideoReceiveStream* recv_stream = AddRecvStream(params);
brandtr14742122017-01-27 04:53:07 -08002373 EXPECT_EQ(kRtxSsrcs1[0], recv_stream->GetConfig().rtp.rtx_ssrc);
nisseca5706d2017-09-11 02:32:16 -07002374
2375 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
2376 << "RTX should be mapped for all decoders/payload types.";
2377 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02002378 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07002379 << "RTX should be mapped for the RED payload type";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002380}
2381
eladalonf1841382017-06-12 01:16:46 -07002382TEST_F(WebRtcVideoChannelTest, RecvStreamNoRtx) {
pbos@webrtc.orge322a172014-06-13 11:47:28 +00002383 // Setup one channel without an associated RTX stream.
2384 cricket::StreamParams params =
2385 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
2386 FakeVideoReceiveStream* recv_stream = AddRecvStream(params);
brandtr14742122017-01-27 04:53:07 -08002387 ASSERT_EQ(0U, recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002388}
2389
Johannes Kron9190b822018-10-29 11:22:05 +01002390// Test propagation of extmap allow mixed setting.
2391TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedAsCaller) {
2392 TestExtmapAllowMixedCaller(/*extmap_allow_mixed=*/true);
2393}
2394TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedDisabledAsCaller) {
2395 TestExtmapAllowMixedCaller(/*extmap_allow_mixed=*/false);
2396}
2397TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedAsCallee) {
2398 TestExtmapAllowMixedCallee(/*extmap_allow_mixed=*/true);
2399}
2400TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedDisabledAsCallee) {
2401 TestExtmapAllowMixedCallee(/*extmap_allow_mixed=*/false);
2402}
2403
eladalonf1841382017-06-12 01:16:46 -07002404TEST_F(WebRtcVideoChannelTest, NoHeaderExtesionsByDefault) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002405 FakeVideoSendStream* send_stream =
2406 AddSendStream(cricket::StreamParams::CreateLegacy(kSsrcs1[0]));
2407 ASSERT_TRUE(send_stream->GetConfig().rtp.extensions.empty());
2408
2409 FakeVideoReceiveStream* recv_stream =
2410 AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrcs1[0]));
2411 ASSERT_TRUE(recv_stream->GetConfig().rtp.extensions.empty());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002412}
2413
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002414// Test support for RTP timestamp offset header extension.
eladalonf1841382017-06-12 01:16:46 -07002415TEST_F(WebRtcVideoChannelTest, SendRtpTimestampOffsetHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002416 TestSetSendRtpHeaderExtensions(RtpExtension::kTimestampOffsetUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002417}
isheriff6f8d6862016-05-26 11:24:55 -07002418
eladalonf1841382017-06-12 01:16:46 -07002419TEST_F(WebRtcVideoChannelTest, RecvRtpTimestampOffsetHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002420 TestSetRecvRtpHeaderExtensions(RtpExtension::kTimestampOffsetUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002421}
2422
2423// Test support for absolute send time header extension.
eladalonf1841382017-06-12 01:16:46 -07002424TEST_F(WebRtcVideoChannelTest, SendAbsoluteSendTimeHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002425 TestSetSendRtpHeaderExtensions(RtpExtension::kAbsSendTimeUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002426}
isheriff6f8d6862016-05-26 11:24:55 -07002427
eladalonf1841382017-06-12 01:16:46 -07002428TEST_F(WebRtcVideoChannelTest, RecvAbsoluteSendTimeHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002429 TestSetRecvRtpHeaderExtensions(RtpExtension::kAbsSendTimeUri);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002430}
2431
eladalonf1841382017-06-12 01:16:46 -07002432TEST_F(WebRtcVideoChannelTest, FiltersExtensionsPicksTransportSeqNum) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002433 // Enable three redundant extensions.
2434 std::vector<std::string> extensions;
isheriff6f8d6862016-05-26 11:24:55 -07002435 extensions.push_back(RtpExtension::kAbsSendTimeUri);
2436 extensions.push_back(RtpExtension::kTimestampOffsetUri);
2437 extensions.push_back(RtpExtension::kTransportSequenceNumberUri);
2438 TestExtensionFilter(extensions, RtpExtension::kTransportSequenceNumberUri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002439}
2440
eladalonf1841382017-06-12 01:16:46 -07002441TEST_F(WebRtcVideoChannelTest, FiltersExtensionsPicksAbsSendTime) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002442 // Enable two redundant extensions.
2443 std::vector<std::string> extensions;
isheriff6f8d6862016-05-26 11:24:55 -07002444 extensions.push_back(RtpExtension::kAbsSendTimeUri);
2445 extensions.push_back(RtpExtension::kTimestampOffsetUri);
2446 TestExtensionFilter(extensions, RtpExtension::kAbsSendTimeUri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002447}
2448
stefanc1aeaf02015-10-15 07:26:07 -07002449// Test support for transport sequence number header extension.
eladalonf1841382017-06-12 01:16:46 -07002450TEST_F(WebRtcVideoChannelTest, SendTransportSequenceNumberHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002451 TestSetSendRtpHeaderExtensions(RtpExtension::kTransportSequenceNumberUri);
stefanc1aeaf02015-10-15 07:26:07 -07002452}
eladalonf1841382017-06-12 01:16:46 -07002453TEST_F(WebRtcVideoChannelTest, RecvTransportSequenceNumberHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002454 TestSetRecvRtpHeaderExtensions(RtpExtension::kTransportSequenceNumberUri);
stefanc1aeaf02015-10-15 07:26:07 -07002455}
2456
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002457// Test support for video rotation header extension.
eladalonf1841382017-06-12 01:16:46 -07002458TEST_F(WebRtcVideoChannelTest, SendVideoRotationHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002459 TestSetSendRtpHeaderExtensions(RtpExtension::kVideoRotationUri);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002460}
eladalonf1841382017-06-12 01:16:46 -07002461TEST_F(WebRtcVideoChannelTest, RecvVideoRotationHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002462 TestSetRecvRtpHeaderExtensions(RtpExtension::kVideoRotationUri);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002463}
2464
eladalonf1841382017-06-12 01:16:46 -07002465TEST_F(WebRtcVideoChannelTest, IdenticalSendExtensionsDoesntRecreateStream) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002466 const int kAbsSendTimeId = 1;
2467 const int kVideoRotationId = 2;
isheriff6f8d6862016-05-26 11:24:55 -07002468 send_parameters_.extensions.push_back(
2469 RtpExtension(RtpExtension::kAbsSendTimeUri, kAbsSendTimeId));
2470 send_parameters_.extensions.push_back(
2471 RtpExtension(RtpExtension::kVideoRotationUri, kVideoRotationId));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002472
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002473 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002474 FakeVideoSendStream* send_stream =
2475 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2476
2477 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002478 ASSERT_EQ(2u, send_stream->GetConfig().rtp.extensions.size());
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002479
2480 // Setting the same extensions (even if in different order) shouldn't
2481 // reallocate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002482 std::reverse(send_parameters_.extensions.begin(),
2483 send_parameters_.extensions.end());
2484 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002485
2486 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
2487
2488 // Setting different extensions should recreate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002489 send_parameters_.extensions.resize(1);
2490 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002491
2492 EXPECT_EQ(2, fake_call_->GetNumCreatedSendStreams());
2493}
2494
eladalonf1841382017-06-12 01:16:46 -07002495TEST_F(WebRtcVideoChannelTest, IdenticalRecvExtensionsDoesntRecreateStream) {
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002496 const int kTOffsetId = 1;
2497 const int kAbsSendTimeId = 2;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002498 const int kVideoRotationId = 3;
isheriff6f8d6862016-05-26 11:24:55 -07002499 recv_parameters_.extensions.push_back(
2500 RtpExtension(RtpExtension::kAbsSendTimeUri, kAbsSendTimeId));
2501 recv_parameters_.extensions.push_back(
2502 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
2503 recv_parameters_.extensions.push_back(
2504 RtpExtension(RtpExtension::kVideoRotationUri, kVideoRotationId));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002505
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002506 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
Peter Boström54be3e02015-05-25 15:04:24 +02002507 FakeVideoReceiveStream* recv_stream =
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002508 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2509
2510 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
Peter Boström54be3e02015-05-25 15:04:24 +02002511 ASSERT_EQ(3u, recv_stream->GetConfig().rtp.extensions.size());
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002512
2513 // Setting the same extensions (even if in different order) shouldn't
2514 // reallocate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002515 std::reverse(recv_parameters_.extensions.begin(),
2516 recv_parameters_.extensions.end());
2517 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002518
2519 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
2520
2521 // Setting different extensions should recreate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002522 recv_parameters_.extensions.resize(1);
2523 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002524
2525 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams());
2526}
2527
eladalonf1841382017-06-12 01:16:46 -07002528TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002529 SetSendRtpHeaderExtensionsExcludeUnsupportedExtensions) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002530 const int kUnsupportedId = 1;
2531 const int kTOffsetId = 2;
2532
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002533 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002534 RtpExtension(kUnsupportedExtensionName, kUnsupportedId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002535 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002536 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002537 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002538 FakeVideoSendStream* send_stream =
2539 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2540
2541 // Only timestamp offset extension is set to send stream,
2542 // unsupported rtp extension is ignored.
2543 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
isheriff6f8d6862016-05-26 11:24:55 -07002544 EXPECT_STREQ(RtpExtension::kTimestampOffsetUri,
2545 send_stream->GetConfig().rtp.extensions[0].uri.c_str());
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002546}
2547
eladalonf1841382017-06-12 01:16:46 -07002548TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002549 SetRecvRtpHeaderExtensionsExcludeUnsupportedExtensions) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002550 const int kUnsupportedId = 1;
2551 const int kTOffsetId = 2;
2552
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002553 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002554 RtpExtension(kUnsupportedExtensionName, kUnsupportedId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002555 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002556 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002557 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002558 FakeVideoReceiveStream* recv_stream =
2559 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2560
2561 // Only timestamp offset extension is set to receive stream,
2562 // unsupported rtp extension is ignored.
2563 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
isheriff6f8d6862016-05-26 11:24:55 -07002564 EXPECT_STREQ(RtpExtension::kTimestampOffsetUri,
2565 recv_stream->GetConfig().rtp.extensions[0].uri.c_str());
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002566}
2567
eladalonf1841382017-06-12 01:16:46 -07002568TEST_F(WebRtcVideoChannelTest, SetSendRtpHeaderExtensionsRejectsIncorrectIds) {
Peter Boström23914fe2015-03-31 15:08:04 +02002569 const int kIncorrectIds[] = {-2, -1, 0, 15, 16};
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00002570 for (size_t i = 0; i < arraysize(kIncorrectIds); ++i) {
isheriff6f8d6862016-05-26 11:24:55 -07002571 send_parameters_.extensions.push_back(
2572 RtpExtension(RtpExtension::kTimestampOffsetUri, kIncorrectIds[i]));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002573 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_))
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002574 << "Bad extension id '" << kIncorrectIds[i] << "' accepted.";
2575 }
2576}
2577
eladalonf1841382017-06-12 01:16:46 -07002578TEST_F(WebRtcVideoChannelTest, SetRecvRtpHeaderExtensionsRejectsIncorrectIds) {
Peter Boström23914fe2015-03-31 15:08:04 +02002579 const int kIncorrectIds[] = {-2, -1, 0, 15, 16};
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00002580 for (size_t i = 0; i < arraysize(kIncorrectIds); ++i) {
isheriff6f8d6862016-05-26 11:24:55 -07002581 recv_parameters_.extensions.push_back(
2582 RtpExtension(RtpExtension::kTimestampOffsetUri, kIncorrectIds[i]));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002583 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_))
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002584 << "Bad extension id '" << kIncorrectIds[i] << "' accepted.";
2585 }
2586}
2587
eladalonf1841382017-06-12 01:16:46 -07002588TEST_F(WebRtcVideoChannelTest, SetSendRtpHeaderExtensionsRejectsDuplicateIds) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002589 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002590 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002591 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002592 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002593 RtpExtension(RtpExtension::kAbsSendTimeUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002594 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002595
2596 // Duplicate entries are also not supported.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002597 send_parameters_.extensions.clear();
2598 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002599 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002600 send_parameters_.extensions.push_back(send_parameters_.extensions.back());
2601 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002602}
2603
eladalonf1841382017-06-12 01:16:46 -07002604TEST_F(WebRtcVideoChannelTest, SetRecvRtpHeaderExtensionsRejectsDuplicateIds) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002605 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002606 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002607 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002608 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002609 RtpExtension(RtpExtension::kAbsSendTimeUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002610 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002611
2612 // Duplicate entries are also not supported.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002613 recv_parameters_.extensions.clear();
2614 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002615 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002616 recv_parameters_.extensions.push_back(recv_parameters_.extensions.back());
2617 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002618}
2619
eladalonf1841382017-06-12 01:16:46 -07002620TEST_F(WebRtcVideoChannelTest, AddRecvStreamOnlyUsesOneReceiveStream) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002621 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002622 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002623}
2624
eladalonf1841382017-06-12 01:16:46 -07002625TEST_F(WebRtcVideoChannelTest, RtcpIsCompoundByDefault) {
Peter Boströmd7da1202015-06-05 14:09:38 +02002626 FakeVideoReceiveStream* stream = AddRecvStream();
pbosda903ea2015-10-02 02:36:56 -07002627 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream->GetConfig().rtp.rtcp_mode);
Peter Boströmd7da1202015-06-05 14:09:38 +02002628}
2629
eladalonf1841382017-06-12 01:16:46 -07002630TEST_F(WebRtcVideoChannelTest, RembIsEnabledByDefault) {
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002631 FakeVideoReceiveStream* stream = AddRecvStream();
2632 EXPECT_TRUE(stream->GetConfig().rtp.remb);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002633}
2634
eladalonf1841382017-06-12 01:16:46 -07002635TEST_F(WebRtcVideoChannelTest, TransportCcIsEnabledByDefault) {
stefan43edf0f2015-11-20 18:05:48 -08002636 FakeVideoReceiveStream* stream = AddRecvStream();
2637 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2638}
2639
eladalonf1841382017-06-12 01:16:46 -07002640TEST_F(WebRtcVideoChannelTest, RembCanBeEnabledAndDisabled) {
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002641 FakeVideoReceiveStream* stream = AddRecvStream();
2642 EXPECT_TRUE(stream->GetConfig().rtp.remb);
2643
Peter Boström126c03e2015-05-11 12:48:12 +02002644 // Verify that REMB is turned off when send(!) codecs without REMB are set.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002645 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002646 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002647 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2648 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002649 stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002650 EXPECT_FALSE(stream->GetConfig().rtp.remb);
2651
2652 // Verify that REMB is turned on when setting default codecs since the
2653 // default codecs have REMB enabled.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002654 parameters.codecs = engine_.codecs();
2655 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002656 stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002657 EXPECT_TRUE(stream->GetConfig().rtp.remb);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002658}
2659
eladalonf1841382017-06-12 01:16:46 -07002660TEST_F(WebRtcVideoChannelTest, TransportCcCanBeEnabledAndDisabled) {
stefan43edf0f2015-11-20 18:05:48 -08002661 FakeVideoReceiveStream* stream = AddRecvStream();
2662 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2663
2664 // Verify that transport cc feedback is turned off when send(!) codecs without
2665 // transport cc feedback are set.
2666 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002667 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
stefan43edf0f2015-11-20 18:05:48 -08002668 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2669 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2670 stream = fake_call_->GetVideoReceiveStreams()[0];
2671 EXPECT_FALSE(stream->GetConfig().rtp.transport_cc);
2672
2673 // Verify that transport cc feedback is turned on when setting default codecs
2674 // since the default codecs have transport cc feedback enabled.
2675 parameters.codecs = engine_.codecs();
2676 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2677 stream = fake_call_->GetVideoReceiveStreams()[0];
2678 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2679}
2680
eladalonf1841382017-06-12 01:16:46 -07002681TEST_F(WebRtcVideoChannelTest, NackIsEnabledByDefault) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02002682 AssignDefaultCodec();
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002683 VerifyCodecHasDefaultFeedbackParams(default_codec_);
2684
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002685 cricket::VideoSendParameters parameters;
2686 parameters.codecs = engine_.codecs();
2687 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org19864742014-05-30 07:35:47 +00002688 EXPECT_TRUE(channel_->SetSend(true));
2689
2690 // Send side.
2691 FakeVideoSendStream* send_stream =
2692 AddSendStream(cricket::StreamParams::CreateLegacy(1));
2693 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2694
2695 // Receiver side.
2696 FakeVideoReceiveStream* recv_stream =
2697 AddRecvStream(cricket::StreamParams::CreateLegacy(1));
2698 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2699
2700 // Nack history size should match between sender and receiver.
2701 EXPECT_EQ(send_stream->GetConfig().rtp.nack.rtp_history_ms,
2702 recv_stream->GetConfig().rtp.nack.rtp_history_ms);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002703}
2704
eladalonf1841382017-06-12 01:16:46 -07002705TEST_F(WebRtcVideoChannelTest, NackCanBeEnabledAndDisabled) {
Peter Boström67c9df72015-05-11 14:34:58 +02002706 FakeVideoSendStream* send_stream = AddSendStream();
Peter Boström3548dd22015-05-22 18:48:36 +02002707 FakeVideoReceiveStream* recv_stream = AddRecvStream();
Peter Boström67c9df72015-05-11 14:34:58 +02002708
2709 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2710 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2711
2712 // Verify that NACK is turned off when send(!) codecs without NACK are set.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002713 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002714 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002715 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2716 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström67c9df72015-05-11 14:34:58 +02002717 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2718 EXPECT_EQ(0, recv_stream->GetConfig().rtp.nack.rtp_history_ms);
2719 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002720 EXPECT_EQ(0, send_stream->GetConfig().rtp.nack.rtp_history_ms);
2721
Peter Boström67c9df72015-05-11 14:34:58 +02002722 // Verify that NACK is turned on when setting default codecs since the
2723 // default codecs have NACK enabled.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002724 parameters.codecs = engine_.codecs();
2725 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström67c9df72015-05-11 14:34:58 +02002726 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2727 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2728 send_stream = fake_call_->GetVideoSendStreams()[0];
2729 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002730}
2731
Peter Boströme7ba0862016-03-12 00:02:28 +01002732// This test verifies that new frame sizes reconfigures encoders even though not
2733// (yet) sending. The purpose of this is to permit encoding as quickly as
2734// possible once we start sending. Likely the frames being input are from the
2735// same source that will be sent later, which just means that we're ready
2736// earlier.
eladalonf1841382017-06-12 01:16:46 -07002737TEST_F(WebRtcVideoChannelTest, ReconfiguresEncodersWhenNotSending) {
Peter Boströme7ba0862016-03-12 00:02:28 +01002738 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002739 parameters.codecs.push_back(GetEngineCodec("VP8"));
Peter Boströme7ba0862016-03-12 00:02:28 +01002740 ASSERT_TRUE(channel_->SetSendParameters(parameters));
2741 channel_->SetSend(false);
2742
2743 FakeVideoSendStream* stream = AddSendStream();
2744
perkjfa10b552016-10-02 23:45:26 -07002745 // No frames entered.
Peter Boströme7ba0862016-03-12 00:02:28 +01002746 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002747 EXPECT_EQ(0u, streams[0].width);
2748 EXPECT_EQ(0u, streams[0].height);
Peter Boströme7ba0862016-03-12 00:02:28 +01002749
Niels Mollera882fb32019-01-21 08:44:37 +00002750 FakeVideoCapturerWithTaskQueue capturer;
2751 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
2752 VideoFormat capture_format = capturer.GetSupportedFormats()->front();
2753 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format));
2754 EXPECT_TRUE(capturer.CaptureFrame());
Peter Boströme7ba0862016-03-12 00:02:28 +01002755
2756 // Frame entered, should be reconfigured to new dimensions.
2757 streams = stream->GetVideoStreams();
Niels Mollera882fb32019-01-21 08:44:37 +00002758 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format.width), streams[0].width);
2759 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format.height),
2760 streams[0].height);
Peter Boströme7ba0862016-03-12 00:02:28 +01002761
Niels Möllerff40b142018-04-09 08:49:14 +02002762 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boströme7ba0862016-03-12 00:02:28 +01002763}
2764
eladalonf1841382017-06-12 01:16:46 -07002765TEST_F(WebRtcVideoChannelTest, UsesCorrectSettingsForScreencast) {
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002766 static const int kScreenshareMinBitrateKbps = 800;
magjed509e4fe2016-11-18 01:34:11 -08002767 cricket::VideoCodec codec = GetEngineCodec("VP8");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002768 cricket::VideoSendParameters parameters;
2769 parameters.codecs.push_back(codec);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002770 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002771 AddSendStream();
2772
Niels Mollera882fb32019-01-21 08:44:37 +00002773 FakeVideoCapturerWithTaskQueue capturer;
nisse05103312016-03-16 02:22:50 -07002774 VideoOptions min_bitrate_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002775 min_bitrate_options.screencast_min_bitrate_kbps = kScreenshareMinBitrateKbps;
Niels Mollera882fb32019-01-21 08:44:37 +00002776 EXPECT_TRUE(
2777 channel_->SetVideoSend(last_ssrc_, &min_bitrate_options, &capturer));
2778 cricket::VideoFormat capture_format_hd =
2779 capturer.GetSupportedFormats()->front();
2780 EXPECT_EQ(1280, capture_format_hd.width);
2781 EXPECT_EQ(720, capture_format_hd.height);
2782 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format_hd));
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002783
2784 EXPECT_TRUE(channel_->SetSend(true));
2785
Niels Mollera882fb32019-01-21 08:44:37 +00002786 EXPECT_TRUE(capturer.CaptureFrame());
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002787 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2788 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
2789
2790 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
2791
2792 // Verify non-screencast settings.
perkj26091b12016-09-01 01:17:40 -07002793 webrtc::VideoEncoderConfig encoder_config =
2794 send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002795 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kRealtimeVideo,
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002796 encoder_config.content_type);
perkjfa10b552016-10-02 23:45:26 -07002797 std::vector<webrtc::VideoStream> streams = send_stream->GetVideoStreams();
Niels Mollera882fb32019-01-21 08:44:37 +00002798 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format_hd.width),
2799 streams.front().width);
2800 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format_hd.height),
2801 streams.front().height);
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002802 EXPECT_EQ(0, encoder_config.min_transmit_bitrate_bps)
2803 << "Non-screenshare shouldn't use min-transmit bitrate.";
2804
Niels Möllerff40b142018-04-09 08:49:14 +02002805 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
perkjd533aec2017-01-13 05:57:25 -08002806 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
nisse05103312016-03-16 02:22:50 -07002807 VideoOptions screencast_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002808 screencast_options.is_screencast = true;
Niels Mollera882fb32019-01-21 08:44:37 +00002809 EXPECT_TRUE(
2810 channel_->SetVideoSend(last_ssrc_, &screencast_options, &capturer));
2811 EXPECT_TRUE(capturer.CaptureFrame());
sprangf24a0642017-02-28 13:23:26 -08002812 // Send stream recreated after option change.
2813 ASSERT_EQ(2, fake_call_->GetNumCreatedSendStreams());
2814 send_stream = fake_call_->GetVideoSendStreams().front();
2815 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002816
2817 // Verify screencast settings.
perkj26091b12016-09-01 01:17:40 -07002818 encoder_config = send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002819 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kScreen,
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002820 encoder_config.content_type);
2821 EXPECT_EQ(kScreenshareMinBitrateKbps * 1000,
2822 encoder_config.min_transmit_bitrate_bps);
2823
perkjfa10b552016-10-02 23:45:26 -07002824 streams = send_stream->GetVideoStreams();
Niels Mollera882fb32019-01-21 08:44:37 +00002825 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format_hd.width),
2826 streams.front().width);
2827 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format_hd.height),
2828 streams.front().height);
Sergey Silkina796a7e2018-03-01 15:11:29 +01002829 EXPECT_FALSE(streams[0].num_temporal_layers.has_value());
Niels Möllerff40b142018-04-09 08:49:14 +02002830 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002831}
2832
eladalonf1841382017-06-12 01:16:46 -07002833TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002834 ConferenceModeScreencastConfiguresTemporalLayer) {
Rasmus Brandt195d1d72018-05-09 11:28:01 +02002835 static const int kConferenceScreencastTemporalBitrateBps = 200 * 1000;
nisse4b4dc862016-02-17 05:25:36 -08002836 send_parameters_.conference_mode = true;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002837 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002838
2839 AddSendStream();
nisse05103312016-03-16 02:22:50 -07002840 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002841 options.is_screencast = true;
Niels Mollera882fb32019-01-21 08:44:37 +00002842 FakeVideoCapturerWithTaskQueue capturer;
2843 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
2844 cricket::VideoFormat capture_format_hd =
2845 capturer.GetSupportedFormats()->front();
2846 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format_hd));
2847
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002848 EXPECT_TRUE(channel_->SetSend(true));
2849
Niels Mollera882fb32019-01-21 08:44:37 +00002850 EXPECT_TRUE(capturer.CaptureFrame());
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002851 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2852 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
2853
perkj26091b12016-09-01 01:17:40 -07002854 webrtc::VideoEncoderConfig encoder_config =
2855 send_stream->GetEncoderConfig().Copy();
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002856
2857 // Verify screencast settings.
perkj26091b12016-09-01 01:17:40 -07002858 encoder_config = send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002859 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kScreen,
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002860 encoder_config.content_type);
perkjfa10b552016-10-02 23:45:26 -07002861
2862 std::vector<webrtc::VideoStream> streams = send_stream->GetVideoStreams();
2863 ASSERT_EQ(1u, streams.size());
Sergey Silkina796a7e2018-03-01 15:11:29 +01002864 ASSERT_EQ(2u, streams[0].num_temporal_layers);
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002865 EXPECT_EQ(kConferenceScreencastTemporalBitrateBps,
Sergey Silkina796a7e2018-03-01 15:11:29 +01002866 streams[0].target_bitrate_bps);
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002867
Niels Möllerff40b142018-04-09 08:49:14 +02002868 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002869}
2870
eladalonf1841382017-06-12 01:16:46 -07002871TEST_F(WebRtcVideoChannelTest, SuspendBelowMinBitrateDisabledByDefault) {
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002872 FakeVideoSendStream* stream = AddSendStream();
2873 EXPECT_FALSE(stream->GetConfig().suspend_below_min_bitrate);
2874}
2875
eladalonf1841382017-06-12 01:16:46 -07002876TEST_F(WebRtcVideoChannelTest, SetMediaConfigSuspendBelowMinBitrate) {
kthelgason2bc68642017-02-07 07:02:22 -08002877 MediaConfig media_config = GetMediaConfig();
nisse0db023a2016-03-01 04:29:59 -08002878 media_config.video.suspend_below_min_bitrate = true;
2879
Sebastian Jansson84848f22018-11-16 10:40:36 +01002880 channel_.reset(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07002881 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002882 channel_->OnReadyToSend(true);
nisse0db023a2016-03-01 04:29:59 -08002883
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002884 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002885
2886 FakeVideoSendStream* stream = AddSendStream();
2887 EXPECT_TRUE(stream->GetConfig().suspend_below_min_bitrate);
2888
nisse0db023a2016-03-01 04:29:59 -08002889 media_config.video.suspend_below_min_bitrate = false;
Sebastian Jansson84848f22018-11-16 10:40:36 +01002890 channel_.reset(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07002891 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002892 channel_->OnReadyToSend(true);
nisse0db023a2016-03-01 04:29:59 -08002893
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002894 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002895
nisse0db023a2016-03-01 04:29:59 -08002896 stream = AddSendStream();
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002897 EXPECT_FALSE(stream->GetConfig().suspend_below_min_bitrate);
2898}
2899
eladalonf1841382017-06-12 01:16:46 -07002900TEST_F(WebRtcVideoChannelTest, Vp8DenoisingEnabledByDefault) {
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002901 FakeVideoSendStream* stream = AddSendStream();
2902 webrtc::VideoCodecVP8 vp8_settings;
2903 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2904 EXPECT_TRUE(vp8_settings.denoisingOn);
2905}
2906
eladalonf1841382017-06-12 01:16:46 -07002907TEST_F(WebRtcVideoChannelTest, VerifyVp8SpecificSettings) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002908 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002909 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002910 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002911
Peter Boström2feafdb2015-09-09 14:32:14 +02002912 // Single-stream settings should apply with RTX as well (verifies that we
2913 // check number of regular SSRCs and not StreamParams::ssrcs which contains
2914 // both RTX and regular SSRCs).
2915 FakeVideoSendStream* stream = SetUpSimulcast(false, true);
Erik Språng143cec12015-04-28 10:01:41 +02002916
Niels Mollera882fb32019-01-21 08:44:37 +00002917 FakeVideoCapturerWithTaskQueue capturer;
2918 EXPECT_EQ(cricket::CS_RUNNING,
2919 capturer.Start(capturer.GetSupportedFormats()->front()));
2920 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
Erik Språng143cec12015-04-28 10:01:41 +02002921 channel_->SetSend(true);
2922
Niels Mollera882fb32019-01-21 08:44:37 +00002923 EXPECT_TRUE(capturer.CaptureFrame());
Erik Språng143cec12015-04-28 10:01:41 +02002924
pbos4cba4eb2015-10-26 11:18:18 -07002925 webrtc::VideoCodecVP8 vp8_settings;
2926 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2927 EXPECT_TRUE(vp8_settings.denoisingOn)
2928 << "VP8 denoising should be on by default.";
2929
Niels Mollera882fb32019-01-21 08:44:37 +00002930 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02002931
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002932 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2933 EXPECT_FALSE(vp8_settings.denoisingOn);
Erik Språng143cec12015-04-28 10:01:41 +02002934 EXPECT_TRUE(vp8_settings.automaticResizeOn);
2935 EXPECT_TRUE(vp8_settings.frameDroppingOn);
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002936
Niels Mollera882fb32019-01-21 08:44:37 +00002937 stream = SetDenoisingOption(last_ssrc_, &capturer, true);
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002938
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002939 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2940 EXPECT_TRUE(vp8_settings.denoisingOn);
Erik Språng143cec12015-04-28 10:01:41 +02002941 EXPECT_TRUE(vp8_settings.automaticResizeOn);
2942 EXPECT_TRUE(vp8_settings.frameDroppingOn);
2943
Niels Möllerff40b142018-04-09 08:49:14 +02002944 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boström2feafdb2015-09-09 14:32:14 +02002945 stream = SetUpSimulcast(true, false);
Niels Mollera882fb32019-01-21 08:44:37 +00002946 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
Erik Språng143cec12015-04-28 10:01:41 +02002947 channel_->SetSend(true);
Niels Mollera882fb32019-01-21 08:44:37 +00002948 EXPECT_TRUE(capturer.CaptureFrame());
Erik Språng143cec12015-04-28 10:01:41 +02002949
Mirko Bonadeif859e552018-05-30 15:31:29 +02002950 EXPECT_EQ(3u, stream->GetVideoStreams().size());
Erik Språng143cec12015-04-28 10:01:41 +02002951 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2952 // Autmatic resize off when using simulcast.
2953 EXPECT_FALSE(vp8_settings.automaticResizeOn);
2954 EXPECT_TRUE(vp8_settings.frameDroppingOn);
2955
2956 // In screen-share mode, denoising is forced off and simulcast disabled.
nisse05103312016-03-16 02:22:50 -07002957 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002958 options.is_screencast = true;
Niels Mollera882fb32019-01-21 08:44:37 +00002959 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
Niels Möller60653ba2016-03-02 11:41:36 +01002960
Niels Mollera882fb32019-01-21 08:44:37 +00002961 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02002962
Mirko Bonadeif859e552018-05-30 15:31:29 +02002963 EXPECT_EQ(1u, stream->GetVideoStreams().size());
Erik Språng143cec12015-04-28 10:01:41 +02002964 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2965 EXPECT_FALSE(vp8_settings.denoisingOn);
2966 // Resizing and frame dropping always off for screen sharing.
2967 EXPECT_FALSE(vp8_settings.automaticResizeOn);
2968 EXPECT_FALSE(vp8_settings.frameDroppingOn);
2969
Niels Mollera882fb32019-01-21 08:44:37 +00002970 stream = SetDenoisingOption(last_ssrc_, &capturer, true);
Erik Språng143cec12015-04-28 10:01:41 +02002971
2972 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2973 EXPECT_FALSE(vp8_settings.denoisingOn);
2974 EXPECT_FALSE(vp8_settings.automaticResizeOn);
2975 EXPECT_FALSE(vp8_settings.frameDroppingOn);
2976
Niels Möllerff40b142018-04-09 08:49:14 +02002977 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Erik Språng143cec12015-04-28 10:01:41 +02002978}
2979
deadbeef119760a2016-04-04 11:43:27 -07002980// Test that setting the same options doesn't result in the encoder being
2981// reconfigured.
eladalonf1841382017-06-12 01:16:46 -07002982TEST_F(WebRtcVideoChannelTest, SetIdenticalOptionsDoesntReconfigureEncoder) {
deadbeef119760a2016-04-04 11:43:27 -07002983 VideoOptions options;
Niels Mollera882fb32019-01-21 08:44:37 +00002984 FakeVideoCapturerWithTaskQueue capturer;
deadbeef119760a2016-04-04 11:43:27 -07002985
perkjfa10b552016-10-02 23:45:26 -07002986 AddSendStream();
Niels Mollera882fb32019-01-21 08:44:37 +00002987 EXPECT_EQ(cricket::CS_RUNNING,
2988 capturer.Start(capturer.GetSupportedFormats()->front()));
perkjfa10b552016-10-02 23:45:26 -07002989 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002990 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkjfa10b552016-10-02 23:45:26 -07002991 ASSERT_TRUE(channel_->SetSendParameters(parameters));
2992 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
2993
Niels Mollera882fb32019-01-21 08:44:37 +00002994 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
2995 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
2996 EXPECT_TRUE(capturer.CaptureFrame());
perkjfa10b552016-10-02 23:45:26 -07002997 // Expect 1 reconfigurations at this point from the initial configuration.
2998 EXPECT_EQ(1, send_stream->num_encoder_reconfigurations());
deadbeef119760a2016-04-04 11:43:27 -07002999
3000 // Set the options one more time and expect no additional reconfigurations.
Niels Mollera882fb32019-01-21 08:44:37 +00003001 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
perkjfa10b552016-10-02 23:45:26 -07003002 EXPECT_EQ(1, send_stream->num_encoder_reconfigurations());
3003
3004 // Change |options| and expect 2 reconfigurations.
Oskar Sundbom78807582017-11-16 11:09:55 +01003005 options.video_noise_reduction = true;
Niels Mollera882fb32019-01-21 08:44:37 +00003006 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
deadbeef119760a2016-04-04 11:43:27 -07003007 EXPECT_EQ(2, send_stream->num_encoder_reconfigurations());
3008
Niels Möllerff40b142018-04-09 08:49:14 +02003009 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
deadbeef119760a2016-04-04 11:43:27 -07003010}
3011
eladalonf1841382017-06-12 01:16:46 -07003012class Vp9SettingsTest : public WebRtcVideoChannelTest {
Erik Språng143cec12015-04-28 10:01:41 +02003013 public:
asaperssonc5dabdd2016-03-21 04:15:50 -07003014 Vp9SettingsTest() : Vp9SettingsTest("") {}
3015 explicit Vp9SettingsTest(const char* field_trials)
eladalonf1841382017-06-12 01:16:46 -07003016 : WebRtcVideoChannelTest(field_trials) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +02003017 encoder_factory_->AddSupportedVideoCodecType("VP9");
Erik Språng143cec12015-04-28 10:01:41 +02003018 }
3019 virtual ~Vp9SettingsTest() {}
3020
3021 protected:
Erik Språng143cec12015-04-28 10:01:41 +02003022 void TearDown() override {
3023 // Remove references to encoder_factory_ since this will be destroyed
3024 // before channel_ and engine_.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003025 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
Erik Språng143cec12015-04-28 10:01:41 +02003026 }
Erik Språng143cec12015-04-28 10:01:41 +02003027};
3028
3029TEST_F(Vp9SettingsTest, VerifyVp9SpecificSettings) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003030 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003031 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003032 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Erik Språng143cec12015-04-28 10:01:41 +02003033
Peter Boström2feafdb2015-09-09 14:32:14 +02003034 FakeVideoSendStream* stream = SetUpSimulcast(false, false);
Erik Språng143cec12015-04-28 10:01:41 +02003035
Niels Mollera882fb32019-01-21 08:44:37 +00003036 FakeVideoCapturerWithTaskQueue capturer;
3037 EXPECT_EQ(cricket::CS_RUNNING,
3038 capturer.Start(capturer.GetSupportedFormats()->front()));
3039 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
Erik Språng143cec12015-04-28 10:01:41 +02003040 channel_->SetSend(true);
3041
Niels Mollera882fb32019-01-21 08:44:37 +00003042 EXPECT_TRUE(capturer.CaptureFrame());
Erik Språng143cec12015-04-28 10:01:41 +02003043
pbos4cba4eb2015-10-26 11:18:18 -07003044 webrtc::VideoCodecVP9 vp9_settings;
3045 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
jianja5e8aa62017-03-27 10:09:00 -07003046 EXPECT_TRUE(vp9_settings.denoisingOn)
3047 << "VP9 denoising should be on by default.";
pbos4cba4eb2015-10-26 11:18:18 -07003048
Niels Mollera882fb32019-01-21 08:44:37 +00003049 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02003050
Erik Språng143cec12015-04-28 10:01:41 +02003051 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3052 EXPECT_FALSE(vp9_settings.denoisingOn);
3053 // Frame dropping always on for real time video.
3054 EXPECT_TRUE(vp9_settings.frameDroppingOn);
3055
Niels Mollera882fb32019-01-21 08:44:37 +00003056 stream = SetDenoisingOption(last_ssrc_, &capturer, true);
Erik Språng143cec12015-04-28 10:01:41 +02003057
3058 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3059 EXPECT_TRUE(vp9_settings.denoisingOn);
3060 EXPECT_TRUE(vp9_settings.frameDroppingOn);
3061
3062 // In screen-share mode, denoising is forced off.
nisse05103312016-03-16 02:22:50 -07003063 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003064 options.is_screencast = true;
Niels Mollera882fb32019-01-21 08:44:37 +00003065 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
perkj2d5f0912016-02-29 00:04:41 -08003066
Niels Mollera882fb32019-01-21 08:44:37 +00003067 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02003068
3069 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3070 EXPECT_FALSE(vp9_settings.denoisingOn);
Sergey Silkinbe71a1e2018-05-17 16:46:43 +02003071 // Frame dropping always on for screen sharing.
3072 EXPECT_TRUE(vp9_settings.frameDroppingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003073
Niels Mollera882fb32019-01-21 08:44:37 +00003074 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02003075
3076 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3077 EXPECT_FALSE(vp9_settings.denoisingOn);
Sergey Silkinbe71a1e2018-05-17 16:46:43 +02003078 EXPECT_TRUE(vp9_settings.frameDroppingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003079
Niels Möllerff40b142018-04-09 08:49:14 +02003080 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003081}
3082
Sergey Silkinf18072e2018-03-14 10:35:35 +01003083TEST_F(Vp9SettingsTest, MultipleSsrcsEnablesSvc) {
3084 cricket::VideoSendParameters parameters;
3085 parameters.codecs.push_back(GetEngineCodec("VP9"));
3086 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3087
3088 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
3089
3090 FakeVideoSendStream* stream =
3091 AddSendStream(CreateSimStreamParams("cname", ssrcs));
3092
3093 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3094 EXPECT_EQ(ssrcs.size(), config.rtp.ssrcs.size());
3095
Niels Mollera882fb32019-01-21 08:44:37 +00003096 FakeVideoCapturerWithTaskQueue capturer;
3097 EXPECT_EQ(cricket::CS_RUNNING,
3098 capturer.Start(capturer.GetSupportedFormats()->front()));
3099 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, &capturer));
Sergey Silkinf18072e2018-03-14 10:35:35 +01003100 channel_->SetSend(true);
3101
Niels Mollera882fb32019-01-21 08:44:37 +00003102 EXPECT_TRUE(capturer.CaptureFrame());
Sergey Silkinf18072e2018-03-14 10:35:35 +01003103
3104 webrtc::VideoCodecVP9 vp9_settings;
3105 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3106
3107 const size_t kNumSpatialLayers = ssrcs.size();
3108 const size_t kNumTemporalLayers = 3;
3109 EXPECT_EQ(vp9_settings.numberOfSpatialLayers, kNumSpatialLayers);
3110 EXPECT_EQ(vp9_settings.numberOfTemporalLayers, kNumTemporalLayers);
3111
Niels Möllerff40b142018-04-09 08:49:14 +02003112 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, nullptr));
Sergey Silkinf18072e2018-03-14 10:35:35 +01003113}
3114
Sergey Silkin8b9b5f92018-12-10 09:28:53 +01003115TEST_F(Vp9SettingsTest, AllEncodingParametersCopied) {
3116 cricket::VideoSendParameters send_parameters;
3117 send_parameters.codecs.push_back(GetEngineCodec("VP9"));
3118 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
3119
3120 const size_t kNumSpatialLayers = 3;
3121 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
3122
3123 FakeVideoSendStream* stream =
3124 AddSendStream(CreateSimStreamParams("cname", ssrcs));
3125
3126 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(ssrcs[0]);
3127 ASSERT_EQ(kNumSpatialLayers, parameters.encodings.size());
3128 ASSERT_TRUE(parameters.encodings[0].active);
3129 ASSERT_TRUE(parameters.encodings[1].active);
3130 ASSERT_TRUE(parameters.encodings[2].active);
3131 // Invert value to verify copying.
3132 parameters.encodings[1].active = false;
3133 EXPECT_TRUE(channel_->SetRtpSendParameters(ssrcs[0], parameters).ok());
3134
3135 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
3136
3137 // number_of_streams should be 1 since all spatial layers are sent on the
3138 // same SSRC. But encoding parameters of all layers is supposed to be copied
3139 // and stored in simulcast_layers[].
3140 EXPECT_EQ(1u, encoder_config.number_of_streams);
3141 EXPECT_EQ(encoder_config.simulcast_layers.size(), kNumSpatialLayers);
3142 EXPECT_TRUE(encoder_config.simulcast_layers[0].active);
3143 EXPECT_FALSE(encoder_config.simulcast_layers[1].active);
3144 EXPECT_TRUE(encoder_config.simulcast_layers[2].active);
3145}
3146
asaperssonc5dabdd2016-03-21 04:15:50 -07003147class Vp9SettingsTestWithFieldTrial : public Vp9SettingsTest {
3148 public:
brandtr468da7c2016-11-22 02:16:47 -08003149 explicit Vp9SettingsTestWithFieldTrial(const char* field_trials)
asaperssonc5dabdd2016-03-21 04:15:50 -07003150 : Vp9SettingsTest(field_trials) {}
3151
3152 protected:
3153 void VerifySettings(int num_spatial_layers, int num_temporal_layers) {
3154 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003155 parameters.codecs.push_back(GetEngineCodec("VP9"));
asaperssonc5dabdd2016-03-21 04:15:50 -07003156 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3157
3158 FakeVideoSendStream* stream = SetUpSimulcast(false, false);
3159
Niels Mollera882fb32019-01-21 08:44:37 +00003160 FakeVideoCapturerWithTaskQueue capturer;
3161 EXPECT_EQ(cricket::CS_RUNNING,
3162 capturer.Start(capturer.GetSupportedFormats()->front()));
3163 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
asaperssonc5dabdd2016-03-21 04:15:50 -07003164 channel_->SetSend(true);
3165
Niels Mollera882fb32019-01-21 08:44:37 +00003166 EXPECT_TRUE(capturer.CaptureFrame());
asaperssonc5dabdd2016-03-21 04:15:50 -07003167
3168 webrtc::VideoCodecVP9 vp9_settings;
3169 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3170 EXPECT_EQ(num_spatial_layers, vp9_settings.numberOfSpatialLayers);
3171 EXPECT_EQ(num_temporal_layers, vp9_settings.numberOfTemporalLayers);
3172
Niels Möllerff40b142018-04-09 08:49:14 +02003173 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
asaperssonc5dabdd2016-03-21 04:15:50 -07003174 }
3175};
3176
3177class Vp9SettingsTestWithNoFlag : public Vp9SettingsTestWithFieldTrial {
3178 public:
3179 Vp9SettingsTestWithNoFlag() : Vp9SettingsTestWithFieldTrial("") {}
3180};
3181
3182TEST_F(Vp9SettingsTestWithNoFlag, VerifySettings) {
3183 const int kNumSpatialLayers = 1;
3184 const int kNumTemporalLayers = 1;
3185 VerifySettings(kNumSpatialLayers, kNumTemporalLayers);
3186}
3187
3188class Vp9SettingsTestWithInvalidFlag : public Vp9SettingsTestWithFieldTrial {
3189 public:
3190 Vp9SettingsTestWithInvalidFlag()
3191 : Vp9SettingsTestWithFieldTrial("WebRTC-SupportVP9SVC/Default/") {}
3192};
3193
3194TEST_F(Vp9SettingsTestWithInvalidFlag, VerifySettings) {
3195 const int kNumSpatialLayers = 1;
3196 const int kNumTemporalLayers = 1;
3197 VerifySettings(kNumSpatialLayers, kNumTemporalLayers);
3198}
3199
3200class Vp9SettingsTestWith2SL3TLFlag : public Vp9SettingsTestWithFieldTrial {
3201 public:
3202 Vp9SettingsTestWith2SL3TLFlag()
3203 : Vp9SettingsTestWithFieldTrial(
3204 "WebRTC-SupportVP9SVC/EnabledByFlag_2SL3TL/") {}
3205};
3206
3207TEST_F(Vp9SettingsTestWith2SL3TLFlag, VerifySettings) {
3208 const int kNumSpatialLayers = 2;
3209 const int kNumTemporalLayers = 3;
3210 VerifySettings(kNumSpatialLayers, kNumTemporalLayers);
3211}
3212
Åsa Persson45bbc8a2017-11-13 10:16:47 +01003213TEST_F(WebRtcVideoChannelTest, VerifyMinBitrate) {
3214 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3215 ASSERT_EQ(1u, streams.size());
3216 EXPECT_EQ(cricket::kMinVideoBitrateBps, streams[0].min_bitrate_bps);
3217}
3218
3219TEST_F(WebRtcVideoChannelTest, VerifyMinBitrateWithForcedFallbackFieldTrial) {
3220 webrtc::test::ScopedFieldTrials override_field_trials_(
3221 "WebRTC-VP8-Forced-Fallback-Encoder-v2/Enabled-1,2,34567/");
3222 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3223 ASSERT_EQ(1u, streams.size());
3224 EXPECT_EQ(34567, streams[0].min_bitrate_bps);
3225}
3226
asapersson3c81a1a2017-06-14 05:52:21 -07003227TEST_F(WebRtcVideoChannelTest,
3228 BalancedDegradationPreferenceNotSupportedWithoutFieldtrial) {
3229 webrtc::test::ScopedFieldTrials override_field_trials_(
3230 "WebRTC-Video-BalancedDegradation/Disabled/");
3231 const bool kResolutionScalingEnabled = true;
3232 const bool kFpsScalingEnabled = false;
3233 TestDegradationPreference(kResolutionScalingEnabled, kFpsScalingEnabled);
3234}
3235
3236TEST_F(WebRtcVideoChannelTest,
3237 BalancedDegradationPreferenceSupportedBehindFieldtrial) {
3238 webrtc::test::ScopedFieldTrials override_field_trials_(
3239 "WebRTC-Video-BalancedDegradation/Enabled/");
3240 const bool kResolutionScalingEnabled = true;
3241 const bool kFpsScalingEnabled = true;
3242 TestDegradationPreference(kResolutionScalingEnabled, kFpsScalingEnabled);
3243}
3244
eladalonf1841382017-06-12 01:16:46 -07003245TEST_F(WebRtcVideoChannelTest, AdaptsOnOveruse) {
Erik Språngefbde372015-04-29 16:21:28 +02003246 TestCpuAdaptation(true, false);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003247}
3248
eladalonf1841382017-06-12 01:16:46 -07003249TEST_F(WebRtcVideoChannelTest, DoesNotAdaptOnOveruseWhenDisabled) {
Erik Språngefbde372015-04-29 16:21:28 +02003250 TestCpuAdaptation(false, false);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003251}
3252
Niels Möller3de32e62019-01-18 08:42:18 +01003253TEST_F(WebRtcVideoChannelTest, DoesNotAdaptWhenScreeensharing) {
3254 TestCpuAdaptation(false, true);
3255}
3256
eladalonf1841382017-06-12 01:16:46 -07003257TEST_F(WebRtcVideoChannelTest, DoesNotAdaptOnOveruseWhenScreensharing) {
Erik Språngefbde372015-04-29 16:21:28 +02003258 TestCpuAdaptation(true, true);
3259}
3260
eladalonf1841382017-06-12 01:16:46 -07003261TEST_F(WebRtcVideoChannelTest, PreviousAdaptationDoesNotApplyToScreenshare) {
magjed509e4fe2016-11-18 01:34:11 -08003262 cricket::VideoCodec codec = GetEngineCodec("VP8");
Per766ad3b2016-04-05 15:23:49 +02003263 cricket::VideoSendParameters parameters;
3264 parameters.codecs.push_back(codec);
3265
kthelgason2bc68642017-02-07 07:02:22 -08003266 MediaConfig media_config = GetMediaConfig();
Niels Möller1d7ecd22018-01-18 15:25:12 +01003267 media_config.video.enable_cpu_adaptation = true;
Sebastian Jansson84848f22018-11-16 10:40:36 +01003268 channel_.reset(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07003269 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003270 channel_->OnReadyToSend(true);
Per766ad3b2016-04-05 15:23:49 +02003271 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3272
3273 AddSendStream();
3274
Niels Mollera882fb32019-01-21 08:44:37 +00003275 FakeVideoCapturerWithTaskQueue capturer;
3276 ASSERT_EQ(cricket::CS_RUNNING,
3277 capturer.Start(capturer.GetSupportedFormats()->front()));
Per766ad3b2016-04-05 15:23:49 +02003278 ASSERT_TRUE(channel_->SetSend(true));
3279 cricket::VideoOptions camera_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003280 camera_options.is_screencast = false;
Niels Mollera882fb32019-01-21 08:44:37 +00003281 channel_->SetVideoSend(last_ssrc_, &camera_options, &capturer);
Per766ad3b2016-04-05 15:23:49 +02003282
3283 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3284 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
Per766ad3b2016-04-05 15:23:49 +02003285
Niels Möllerdcc70292019-01-15 16:32:38 +01003286 EXPECT_TRUE(send_stream->resolution_scaling_enabled());
3287 // Dont' expect anything on framerate_scaling_enabled, since the default is
3288 // transitioning from MAINTAIN_FRAMERATE to BALANCED.
Per766ad3b2016-04-05 15:23:49 +02003289
Niels Möllerdcc70292019-01-15 16:32:38 +01003290 // Switch to screen share. Expect no resolution scaling.
Per766ad3b2016-04-05 15:23:49 +02003291 cricket::VideoOptions screenshare_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003292 screenshare_options.is_screencast = true;
Niels Mollera882fb32019-01-21 08:44:37 +00003293 channel_->SetVideoSend(last_ssrc_, &screenshare_options, &capturer);
sprangf24a0642017-02-28 13:23:26 -08003294 ASSERT_EQ(2, fake_call_->GetNumCreatedSendStreams());
3295 send_stream = fake_call_->GetVideoSendStreams().front();
Niels Möllerdcc70292019-01-15 16:32:38 +01003296 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
Per766ad3b2016-04-05 15:23:49 +02003297
Niels Möllerdcc70292019-01-15 16:32:38 +01003298 // Switch back to the normal capturer. Expect resolution scaling to be
3299 // reenabled.
Niels Mollera882fb32019-01-21 08:44:37 +00003300 channel_->SetVideoSend(last_ssrc_, &camera_options, &capturer);
sprangf24a0642017-02-28 13:23:26 -08003301 ASSERT_EQ(3, fake_call_->GetNumCreatedSendStreams());
3302 send_stream = fake_call_->GetVideoSendStreams().front();
Niels Möllerdcc70292019-01-15 16:32:38 +01003303 EXPECT_TRUE(send_stream->resolution_scaling_enabled());
Per766ad3b2016-04-05 15:23:49 +02003304
Niels Möllerff40b142018-04-09 08:49:14 +02003305 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Per766ad3b2016-04-05 15:23:49 +02003306}
3307
asapersson3c81a1a2017-06-14 05:52:21 -07003308// TODO(asapersson): Remove this test when the balanced field trial is removed.
3309void WebRtcVideoChannelTest::TestDegradationPreference(
3310 bool resolution_scaling_enabled,
3311 bool fps_scaling_enabled) {
3312 cricket::VideoCodec codec = GetEngineCodec("VP8");
3313 cricket::VideoSendParameters parameters;
3314 parameters.codecs.push_back(codec);
3315
3316 MediaConfig media_config = GetMediaConfig();
Niels Möller1d7ecd22018-01-18 15:25:12 +01003317 media_config.video.enable_cpu_adaptation = true;
Sebastian Jansson84848f22018-11-16 10:40:36 +01003318 channel_.reset(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07003319 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
asapersson3c81a1a2017-06-14 05:52:21 -07003320 channel_->OnReadyToSend(true);
3321
3322 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3323
3324 AddSendStream();
3325
Niels Mollera882fb32019-01-21 08:44:37 +00003326 FakeVideoCapturerWithTaskQueue capturer;
asapersson3c81a1a2017-06-14 05:52:21 -07003327 VideoOptions options;
Niels Mollera882fb32019-01-21 08:44:37 +00003328 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
3329 cricket::VideoFormat capture_format = capturer.GetSupportedFormats()->front();
3330 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format));
asapersson3c81a1a2017-06-14 05:52:21 -07003331
3332 EXPECT_TRUE(channel_->SetSend(true));
3333
3334 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
3335 EXPECT_EQ(resolution_scaling_enabled,
3336 send_stream->resolution_scaling_enabled());
3337 EXPECT_EQ(fps_scaling_enabled, send_stream->framerate_scaling_enabled());
3338
Niels Möllerff40b142018-04-09 08:49:14 +02003339 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
asapersson3c81a1a2017-06-14 05:52:21 -07003340}
3341
eladalonf1841382017-06-12 01:16:46 -07003342void WebRtcVideoChannelTest::TestCpuAdaptation(bool enable_overuse,
3343 bool is_screenshare) {
Niels Mollera882fb32019-01-21 08:44:37 +00003344 const int kDefaultFps = 30;
magjed509e4fe2016-11-18 01:34:11 -08003345 cricket::VideoCodec codec = GetEngineCodec("VP8");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003346 cricket::VideoSendParameters parameters;
3347 parameters.codecs.push_back(codec);
nisse51542be2016-02-12 02:27:06 -08003348
kthelgason2bc68642017-02-07 07:02:22 -08003349 MediaConfig media_config = GetMediaConfig();
3350 if (enable_overuse) {
Niels Möller1d7ecd22018-01-18 15:25:12 +01003351 media_config.video.enable_cpu_adaptation = true;
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003352 }
Sebastian Jansson84848f22018-11-16 10:40:36 +01003353 channel_.reset(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07003354 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003355 channel_->OnReadyToSend(true);
nisse51542be2016-02-12 02:27:06 -08003356
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003357 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003358
3359 AddSendStream();
3360
Niels Mollera882fb32019-01-21 08:44:37 +00003361 FakeVideoCapturerWithTaskQueue capturer;
nisse05103312016-03-16 02:22:50 -07003362 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003363 options.is_screencast = is_screenshare;
Niels Mollera882fb32019-01-21 08:44:37 +00003364 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
3365 cricket::VideoFormat capture_format = capturer.GetSupportedFormats()->front();
3366 capture_format.interval = rtc::kNumNanosecsPerSec / kDefaultFps;
3367 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003368
3369 EXPECT_TRUE(channel_->SetSend(true));
3370
solenberge5269742015-09-08 05:13:22 -07003371 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
perkj2d5f0912016-02-29 00:04:41 -08003372
sprangc5d62e22017-04-02 23:53:04 -07003373 if (!enable_overuse) {
perkj803d97f2016-11-01 11:45:46 -07003374 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
sprangc5d62e22017-04-02 23:53:04 -07003375 EXPECT_FALSE(send_stream->framerate_scaling_enabled());
Niels Mollera882fb32019-01-21 08:44:37 +00003376
3377 EXPECT_TRUE(capturer.CaptureFrame());
3378 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
3379
3380 EXPECT_EQ(capture_format.width, send_stream->GetLastWidth());
3381 EXPECT_EQ(capture_format.height, send_stream->GetLastHeight());
3382
3383 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
3384 return;
3385 }
3386
3387 if (is_screenshare) {
sprangc5d62e22017-04-02 23:53:04 -07003388 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
3389 EXPECT_TRUE(send_stream->framerate_scaling_enabled());
3390 } else {
3391 EXPECT_TRUE(send_stream->resolution_scaling_enabled());
3392 EXPECT_FALSE(send_stream->framerate_scaling_enabled());
3393 }
Niels Mollera882fb32019-01-21 08:44:37 +00003394
3395 // Trigger overuse.
3396 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3397
3398 rtc::VideoSinkWants wants;
3399 if (is_screenshare) {
3400 wants.max_framerate_fps = (kDefaultFps * 2) / 3;
3401 } else {
3402 wants.max_pixel_count = capture_format.width * capture_format.height - 1;
3403 }
3404 send_stream->InjectVideoSinkWants(wants);
3405
3406 for (int i = 0; i < kDefaultFps; ++i)
3407 EXPECT_TRUE(capturer.CaptureFrame());
3408
3409 if (is_screenshare) {
3410 // Drops every third frame.
3411 EXPECT_EQ(kDefaultFps * 2 / 3, send_stream->GetNumberOfSwappedFrames());
3412 EXPECT_EQ(send_stream->GetLastWidth(), capture_format.width);
3413 EXPECT_EQ(send_stream->GetLastHeight(), capture_format.height);
3414 } else {
3415 EXPECT_EQ(kDefaultFps, send_stream->GetNumberOfSwappedFrames());
3416 EXPECT_LT(send_stream->GetLastWidth(), capture_format.width);
3417 EXPECT_LT(send_stream->GetLastHeight(), capture_format.height);
3418 }
3419
3420 // Trigger underuse which should go back to normal resolution.
3421 int last_pixel_count =
3422 send_stream->GetLastWidth() * send_stream->GetLastHeight();
3423 if (is_screenshare) {
3424 wants.max_framerate_fps = kDefaultFps;
3425 } else {
3426 wants.max_pixel_count = last_pixel_count * 4;
3427 wants.target_pixel_count.emplace((last_pixel_count * 5) / 3);
3428 }
3429 send_stream->InjectVideoSinkWants(wants);
3430
3431 for (int i = 0; i < kDefaultFps; ++i)
3432 EXPECT_TRUE(capturer.CaptureFrame());
3433
3434 if (is_screenshare) {
3435 EXPECT_EQ(kDefaultFps + (kDefaultFps * 2 / 3),
3436 send_stream->GetNumberOfSwappedFrames());
3437 } else {
3438 EXPECT_EQ(kDefaultFps * 2, send_stream->GetNumberOfSwappedFrames());
3439 }
3440
3441 EXPECT_EQ(capture_format.width, send_stream->GetLastWidth());
3442 EXPECT_EQ(capture_format.height, send_stream->GetLastHeight());
3443
Niels Möllerff40b142018-04-09 08:49:14 +02003444 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003445}
3446
eladalonf1841382017-06-12 01:16:46 -07003447TEST_F(WebRtcVideoChannelTest, EstimatesNtpStartTimeCorrectly) {
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003448 // Start at last timestamp to verify that wraparounds are estimated correctly.
3449 static const uint32_t kInitialTimestamp = 0xFFFFFFFFu;
3450 static const int64_t kInitialNtpTimeMs = 1247891230;
3451 static const int kFrameOffsetMs = 20;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003452 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003453
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003454 FakeVideoReceiveStream* stream = AddRecvStream();
3455 cricket::FakeVideoRenderer renderer;
nisse08582ff2016-02-04 01:24:52 -08003456 EXPECT_TRUE(channel_->SetSink(last_ssrc_, &renderer));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003457
Artem Titov1ebfb6a2019-01-03 23:49:37 +01003458 webrtc::VideoFrame video_frame =
3459 webrtc::VideoFrame::Builder()
3460 .set_video_frame_buffer(CreateBlackFrameBuffer(4, 4))
3461 .set_timestamp_rtp(kInitialTimestamp)
3462 .set_timestamp_us(0)
3463 .set_rotation(webrtc::kVideoRotation_0)
3464 .build();
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003465 // Initial NTP time is not available on the first frame, but should still be
3466 // able to be estimated.
nisseeb83a1a2016-03-21 01:27:56 -07003467 stream->InjectFrame(video_frame);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003468
3469 EXPECT_EQ(1, renderer.num_rendered_frames());
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003470
3471 // This timestamp is kInitialTimestamp (-1) + kFrameOffsetMs * 90, which
3472 // triggers a constant-overflow warning, hence we're calculating it explicitly
3473 // here.
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +02003474 fake_clock_.AdvanceTimeMicros(kFrameOffsetMs * rtc::kNumMicrosecsPerMillisec);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003475 video_frame.set_timestamp(kFrameOffsetMs * 90 - 1);
3476 video_frame.set_ntp_time_ms(kInitialNtpTimeMs + kFrameOffsetMs);
nisseeb83a1a2016-03-21 01:27:56 -07003477 stream->InjectFrame(video_frame);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003478
3479 EXPECT_EQ(2, renderer.num_rendered_frames());
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003480
3481 // Verify that NTP time has been correctly deduced.
3482 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00003483 ASSERT_TRUE(channel_->GetStats(&info));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003484 ASSERT_EQ(1u, info.receivers.size());
3485 EXPECT_EQ(kInitialNtpTimeMs, info.receivers[0].capture_start_ntp_time_ms);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003486}
3487
eladalonf1841382017-06-12 01:16:46 -07003488TEST_F(WebRtcVideoChannelTest, SetDefaultSendCodecs) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02003489 AssignDefaultAptRtxTypes();
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003490 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003491
3492 VideoCodec codec;
3493 EXPECT_TRUE(channel_->GetSendCodec(&codec));
pbos@webrtc.org9fbb7172014-06-13 09:34:13 +00003494 EXPECT_TRUE(codec.Matches(engine_.codecs()[0]));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003495
3496 // Using a RTX setup to verify that the default RTX payload type is good.
Peter Boström0c4e06b2015-10-07 12:23:21 +02003497 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
3498 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003499 FakeVideoSendStream* stream = AddSendStream(
3500 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
perkj26091b12016-09-01 01:17:40 -07003501 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003502
3503 // Make sure NACK and FEC are enabled on the correct payload types.
3504 EXPECT_EQ(1000, config.rtp.nack.rtp_history_ms);
magjed509e4fe2016-11-18 01:34:11 -08003505 EXPECT_EQ(GetEngineCodec("ulpfec").id, config.rtp.ulpfec.ulpfec_payload_type);
3506 EXPECT_EQ(GetEngineCodec("red").id, config.rtp.ulpfec.red_payload_type);
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003507
3508 EXPECT_EQ(1u, config.rtp.rtx.ssrcs.size());
3509 EXPECT_EQ(kRtxSsrcs1[0], config.rtp.rtx.ssrcs[0]);
Shao Changbine62202f2015-04-21 20:24:50 +08003510 VerifySendStreamHasRtxTypes(config, default_apt_rtx_types_);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003511 // TODO(juberti): Check RTCP, PLI, TMMBR.
3512}
3513
brandtr31bd2242017-05-19 05:47:46 -07003514// The following four tests ensures that FlexFEC is not activated by default
3515// when the field trials are not enabled.
3516// TODO(brandtr): Remove or update these tests when FlexFEC _is_ enabled by
3517// default.
Yves Gerey665174f2018-06-19 15:03:05 +02003518TEST_F(WebRtcVideoChannelTest, FlexfecSendCodecWithoutSsrcNotExposedByDefault) {
brandtr468da7c2016-11-22 02:16:47 -08003519 FakeVideoSendStream* stream = AddSendStream();
3520 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3521
brandtr3d200bd2017-01-16 06:59:19 -08003522 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr31bd2242017-05-19 05:47:46 -07003523 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3524 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
brandtr468da7c2016-11-22 02:16:47 -08003525}
3526
eladalonf1841382017-06-12 01:16:46 -07003527TEST_F(WebRtcVideoChannelTest, FlexfecSendCodecWithSsrcNotExposedByDefault) {
brandtr468da7c2016-11-22 02:16:47 -08003528 FakeVideoSendStream* stream = AddSendStream(
3529 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3530 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3531
brandtr3d200bd2017-01-16 06:59:19 -08003532 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr31bd2242017-05-19 05:47:46 -07003533 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3534 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3535}
3536
Yves Gerey665174f2018-06-19 15:03:05 +02003537TEST_F(WebRtcVideoChannelTest, FlexfecRecvCodecWithoutSsrcNotExposedByDefault) {
brandtr31bd2242017-05-19 05:47:46 -07003538 AddRecvStream();
3539
3540 const std::vector<FakeFlexfecReceiveStream*>& streams =
3541 fake_call_->GetFlexfecReceiveStreams();
3542 EXPECT_TRUE(streams.empty());
3543}
3544
eladalonf1841382017-06-12 01:16:46 -07003545TEST_F(WebRtcVideoChannelTest, FlexfecRecvCodecWithSsrcNotExposedByDefault) {
brandtr31bd2242017-05-19 05:47:46 -07003546 AddRecvStream(
3547 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3548
3549 const std::vector<FakeFlexfecReceiveStream*>& streams =
3550 fake_call_->GetFlexfecReceiveStreams();
3551 EXPECT_TRUE(streams.empty());
brandtr468da7c2016-11-22 02:16:47 -08003552}
3553
3554// TODO(brandtr): When FlexFEC is no longer behind a field trial, merge all
3555// tests that use this test fixture into the corresponding "non-field trial"
3556// tests.
eladalonf1841382017-06-12 01:16:46 -07003557class WebRtcVideoChannelFlexfecRecvTest : public WebRtcVideoChannelTest {
brandtr468da7c2016-11-22 02:16:47 -08003558 public:
eladalonf1841382017-06-12 01:16:46 -07003559 WebRtcVideoChannelFlexfecRecvTest()
3560 : WebRtcVideoChannelTest("WebRTC-FlexFEC-03-Advertised/Enabled/") {}
brandtr468da7c2016-11-22 02:16:47 -08003561};
3562
eladalonf1841382017-06-12 01:16:46 -07003563TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr36e7d702017-01-13 07:15:54 -08003564 DefaultFlexfecCodecHasTransportCcAndRembFeedbackParam) {
3565 EXPECT_TRUE(cricket::HasTransportCc(GetEngineCodec("flexfec-03")));
3566 EXPECT_TRUE(cricket::HasRemb(GetEngineCodec("flexfec-03")));
3567}
3568
eladalonf1841382017-06-12 01:16:46 -07003569TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetDefaultRecvCodecsWithoutSsrc) {
brandtr31bd2242017-05-19 05:47:46 -07003570 AddRecvStream();
3571
3572 const std::vector<FakeFlexfecReceiveStream*>& streams =
3573 fake_call_->GetFlexfecReceiveStreams();
3574 EXPECT_TRUE(streams.empty());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003575
3576 const std::vector<FakeVideoReceiveStream*>& video_streams =
3577 fake_call_->GetVideoReceiveStreams();
3578 ASSERT_EQ(1U, video_streams.size());
3579 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3580 EXPECT_EQ(0, video_stream.GetNumAddedSecondarySinks());
3581 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr31bd2242017-05-19 05:47:46 -07003582}
3583
eladalonf1841382017-06-12 01:16:46 -07003584TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetDefaultRecvCodecsWithSsrc) {
brandtr31bd2242017-05-19 05:47:46 -07003585 AddRecvStream(
3586 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3587
3588 const std::vector<FakeFlexfecReceiveStream*>& streams =
3589 fake_call_->GetFlexfecReceiveStreams();
3590 ASSERT_EQ(1U, streams.size());
3591 const FakeFlexfecReceiveStream* stream = streams.front();
3592 const webrtc::FlexfecReceiveStream::Config& config = stream->GetConfig();
3593 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.payload_type);
3594 EXPECT_EQ(kFlexfecSsrc, config.remote_ssrc);
3595 ASSERT_EQ(1U, config.protected_media_ssrcs.size());
3596 EXPECT_EQ(kSsrcs1[0], config.protected_media_ssrcs[0]);
brandtr7cd28b92017-09-22 00:26:25 -07003597
3598 const std::vector<FakeVideoReceiveStream*>& video_streams =
3599 fake_call_->GetVideoReceiveStreams();
3600 ASSERT_EQ(1U, video_streams.size());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003601 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3602 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
brandtr7cd28b92017-09-22 00:26:25 -07003603 const webrtc::VideoReceiveStream::Config& video_config =
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003604 video_stream.GetConfig();
brandtr7cd28b92017-09-22 00:26:25 -07003605 EXPECT_TRUE(video_config.rtp.protected_by_flexfec);
brandtr31bd2242017-05-19 05:47:46 -07003606}
3607
eladalonf1841382017-06-12 01:16:46 -07003608TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr11fb4722017-05-30 01:31:37 -07003609 EnablingFlexfecDoesNotRecreateVideoReceiveStream) {
3610 cricket::VideoRecvParameters recv_parameters;
3611 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3612 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3613
3614 AddRecvStream(
3615 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3616 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003617 const std::vector<FakeVideoReceiveStream*>& video_streams =
3618 fake_call_->GetVideoReceiveStreams();
3619 ASSERT_EQ(1U, video_streams.size());
3620 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3621 EXPECT_EQ(0, video_stream.GetNumAddedSecondarySinks());
3622 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003623
3624 // Enable FlexFEC.
3625 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3626 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3627 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams())
3628 << "Enabling FlexFEC should create FlexfecReceiveStream.";
3629 EXPECT_EQ(1U, fake_call_->GetVideoReceiveStreams().size())
3630 << "Enabling FlexFEC should not create VideoReceiveStream.";
3631 EXPECT_EQ(1U, fake_call_->GetFlexfecReceiveStreams().size())
3632 << "Enabling FlexFEC should create a single FlexfecReceiveStream.";
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003633 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3634 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003635}
3636
eladalonf1841382017-06-12 01:16:46 -07003637TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr11fb4722017-05-30 01:31:37 -07003638 DisablingFlexfecDoesNotRecreateVideoReceiveStream) {
3639 cricket::VideoRecvParameters recv_parameters;
3640 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3641 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3642 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3643
3644 AddRecvStream(
3645 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3646 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams());
brandtr11fb4722017-05-30 01:31:37 -07003647 EXPECT_EQ(1U, fake_call_->GetFlexfecReceiveStreams().size());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003648 const std::vector<FakeVideoReceiveStream*>& video_streams =
3649 fake_call_->GetVideoReceiveStreams();
3650 ASSERT_EQ(1U, video_streams.size());
3651 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3652 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3653 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003654
3655 // Disable FlexFEC.
3656 recv_parameters.codecs.clear();
3657 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3658 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3659 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams())
3660 << "Disabling FlexFEC should not recreate VideoReceiveStream.";
3661 EXPECT_EQ(1U, fake_call_->GetVideoReceiveStreams().size())
3662 << "Disabling FlexFEC should not destroy VideoReceiveStream.";
3663 EXPECT_TRUE(fake_call_->GetFlexfecReceiveStreams().empty())
3664 << "Disabling FlexFEC should destroy FlexfecReceiveStream.";
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003665 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3666 EXPECT_EQ(1, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003667}
3668
brandtr31bd2242017-05-19 05:47:46 -07003669// TODO(brandtr): When FlexFEC is no longer behind a field trial, merge all
3670// tests that use this test fixture into the corresponding "non-field trial"
3671// tests.
eladalonf1841382017-06-12 01:16:46 -07003672class WebRtcVideoChannelFlexfecSendRecvTest : public WebRtcVideoChannelTest {
brandtr31bd2242017-05-19 05:47:46 -07003673 public:
eladalonf1841382017-06-12 01:16:46 -07003674 WebRtcVideoChannelFlexfecSendRecvTest()
3675 : WebRtcVideoChannelTest(
brandtr31bd2242017-05-19 05:47:46 -07003676 "WebRTC-FlexFEC-03-Advertised/Enabled/WebRTC-FlexFEC-03/Enabled/") {
3677 }
3678};
3679
Yves Gerey665174f2018-06-19 15:03:05 +02003680TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetDefaultSendCodecsWithoutSsrc) {
brandtr468da7c2016-11-22 02:16:47 -08003681 FakeVideoSendStream* stream = AddSendStream();
3682 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3683
brandtr3d200bd2017-01-16 06:59:19 -08003684 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3685 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3686 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
brandtr468da7c2016-11-22 02:16:47 -08003687}
3688
eladalonf1841382017-06-12 01:16:46 -07003689TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetDefaultSendCodecsWithSsrc) {
brandtr468da7c2016-11-22 02:16:47 -08003690 FakeVideoSendStream* stream = AddSendStream(
3691 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3692 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3693
brandtr3d200bd2017-01-16 06:59:19 -08003694 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3695 EXPECT_EQ(kFlexfecSsrc, config.rtp.flexfec.ssrc);
3696 ASSERT_EQ(1U, config.rtp.flexfec.protected_media_ssrcs.size());
3697 EXPECT_EQ(kSsrcs1[0], config.rtp.flexfec.protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08003698}
3699
eladalonf1841382017-06-12 01:16:46 -07003700TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003701 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003702 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003703 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003704
3705 FakeVideoSendStream* stream = AddSendStream();
perkj26091b12016-09-01 01:17:40 -07003706 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003707
brandtrb5f2c3f2016-10-04 23:28:39 -07003708 EXPECT_EQ(-1, config.rtp.ulpfec.ulpfec_payload_type);
3709 EXPECT_EQ(-1, config.rtp.ulpfec.red_payload_type);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003710}
3711
eladalonf1841382017-06-12 01:16:46 -07003712TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetSendCodecsWithoutFec) {
brandtr468da7c2016-11-22 02:16:47 -08003713 cricket::VideoSendParameters parameters;
3714 parameters.codecs.push_back(GetEngineCodec("VP8"));
3715 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3716
3717 FakeVideoSendStream* stream = AddSendStream();
3718 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3719
brandtr3d200bd2017-01-16 06:59:19 -08003720 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr468da7c2016-11-22 02:16:47 -08003721}
3722
eladalonf1841382017-06-12 01:16:46 -07003723TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetRecvCodecsWithFec) {
brandtr9c3d4c42017-01-23 06:59:13 -08003724 AddRecvStream(
3725 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08003726
3727 cricket::VideoRecvParameters recv_parameters;
3728 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3729 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3730 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
brandtr9d58d942017-02-03 04:43:41 -08003731
3732 const std::vector<FakeFlexfecReceiveStream*>& flexfec_streams =
3733 fake_call_->GetFlexfecReceiveStreams();
3734 ASSERT_EQ(1U, flexfec_streams.size());
3735 const FakeFlexfecReceiveStream* flexfec_stream = flexfec_streams.front();
3736 const webrtc::FlexfecReceiveStream::Config& flexfec_stream_config =
3737 flexfec_stream->GetConfig();
brandtr9c3d4c42017-01-23 06:59:13 -08003738 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9d58d942017-02-03 04:43:41 -08003739 flexfec_stream_config.payload_type);
3740 EXPECT_EQ(kFlexfecSsrc, flexfec_stream_config.remote_ssrc);
3741 ASSERT_EQ(1U, flexfec_stream_config.protected_media_ssrcs.size());
3742 EXPECT_EQ(kSsrcs1[0], flexfec_stream_config.protected_media_ssrcs[0]);
3743 const std::vector<FakeVideoReceiveStream*>& video_streams =
3744 fake_call_->GetVideoReceiveStreams();
3745 const FakeVideoReceiveStream* video_stream = video_streams.front();
3746 const webrtc::VideoReceiveStream::Config& video_stream_config =
3747 video_stream->GetConfig();
3748 EXPECT_EQ(video_stream_config.rtp.local_ssrc,
3749 flexfec_stream_config.local_ssrc);
3750 EXPECT_EQ(video_stream_config.rtp.rtcp_mode, flexfec_stream_config.rtcp_mode);
3751 EXPECT_EQ(video_stream_config.rtcp_send_transport,
3752 flexfec_stream_config.rtcp_send_transport);
3753 // TODO(brandtr): Update this EXPECT when we set |transport_cc| in a
3754 // spec-compliant way.
3755 EXPECT_EQ(video_stream_config.rtp.transport_cc,
3756 flexfec_stream_config.transport_cc);
3757 EXPECT_EQ(video_stream_config.rtp.rtcp_mode, flexfec_stream_config.rtcp_mode);
3758 EXPECT_EQ(video_stream_config.rtp.extensions,
3759 flexfec_stream_config.rtp_header_extensions);
brandtr9c3d4c42017-01-23 06:59:13 -08003760}
3761
brandtr31bd2242017-05-19 05:47:46 -07003762// We should not send FlexFEC, even if we advertise it, unless the right
3763// field trial is set.
3764// TODO(brandtr): Remove when FlexFEC is enabled by default.
eladalonf1841382017-06-12 01:16:46 -07003765TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003766 SetSendCodecsWithoutSsrcWithFecDoesNotEnableFec) {
3767 cricket::VideoSendParameters parameters;
3768 parameters.codecs.push_back(GetEngineCodec("VP8"));
3769 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3770 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3771
3772 FakeVideoSendStream* stream = AddSendStream();
3773 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3774
3775 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
Mirko Bonadeif859e552018-05-30 15:31:29 +02003776 EXPECT_EQ(0u, config.rtp.flexfec.ssrc);
brandtr31bd2242017-05-19 05:47:46 -07003777 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3778}
3779
eladalonf1841382017-06-12 01:16:46 -07003780TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003781 SetSendCodecsWithSsrcWithFecDoesNotEnableFec) {
3782 cricket::VideoSendParameters parameters;
3783 parameters.codecs.push_back(GetEngineCodec("VP8"));
3784 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3785 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3786
3787 FakeVideoSendStream* stream = AddSendStream(
3788 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3789 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3790
3791 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
Mirko Bonadeif859e552018-05-30 15:31:29 +02003792 EXPECT_EQ(0u, config.rtp.flexfec.ssrc);
brandtr31bd2242017-05-19 05:47:46 -07003793 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3794}
3795
eladalonf1841382017-06-12 01:16:46 -07003796TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003797 SetSendCodecRejectsRtxWithoutAssociatedPayloadType) {
magjed509e4fe2016-11-18 01:34:11 -08003798 const int kUnusedPayloadType = 127;
3799 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType));
3800
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003801 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003802 cricket::VideoCodec rtx_codec(kUnusedPayloadType, "rtx");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003803 parameters.codecs.push_back(rtx_codec);
3804 EXPECT_FALSE(channel_->SetSendParameters(parameters))
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003805 << "RTX codec without associated payload type should be rejected.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003806}
3807
eladalonf1841382017-06-12 01:16:46 -07003808TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003809 SetSendCodecRejectsRtxWithoutMatchingVideoCodec) {
magjed509e4fe2016-11-18 01:34:11 -08003810 const int kUnusedPayloadType1 = 126;
3811 const int kUnusedPayloadType2 = 127;
3812 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
3813 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
3814 {
3815 cricket::VideoCodec rtx_codec = cricket::VideoCodec::CreateRtxCodec(
3816 kUnusedPayloadType1, GetEngineCodec("VP8").id);
3817 cricket::VideoSendParameters parameters;
3818 parameters.codecs.push_back(GetEngineCodec("VP8"));
3819 parameters.codecs.push_back(rtx_codec);
3820 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3821 }
3822 {
3823 cricket::VideoCodec rtx_codec = cricket::VideoCodec::CreateRtxCodec(
3824 kUnusedPayloadType1, kUnusedPayloadType2);
3825 cricket::VideoSendParameters parameters;
3826 parameters.codecs.push_back(GetEngineCodec("VP8"));
3827 parameters.codecs.push_back(rtx_codec);
3828 EXPECT_FALSE(channel_->SetSendParameters(parameters))
3829 << "RTX without matching video codec should be rejected.";
3830 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003831}
3832
eladalonf1841382017-06-12 01:16:46 -07003833TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithChangedRtxPayloadType) {
brandtr14742122017-01-27 04:53:07 -08003834 const int kUnusedPayloadType1 = 126;
3835 const int kUnusedPayloadType2 = 127;
3836 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
3837 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
3838
3839 // SSRCs for RTX.
3840 cricket::StreamParams params =
3841 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
3842 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
3843 AddSendStream(params);
3844
3845 // Original payload type for RTX.
3846 cricket::VideoSendParameters parameters;
3847 parameters.codecs.push_back(GetEngineCodec("VP8"));
3848 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
3849 rtx_codec.SetParam("apt", GetEngineCodec("VP8").id);
3850 parameters.codecs.push_back(rtx_codec);
3851 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3852 ASSERT_EQ(1U, fake_call_->GetVideoSendStreams().size());
3853 const webrtc::VideoSendStream::Config& config_before =
3854 fake_call_->GetVideoSendStreams()[0]->GetConfig();
3855 EXPECT_EQ(kUnusedPayloadType1, config_before.rtp.rtx.payload_type);
3856 ASSERT_EQ(1U, config_before.rtp.rtx.ssrcs.size());
3857 EXPECT_EQ(kRtxSsrcs1[0], config_before.rtp.rtx.ssrcs[0]);
3858
3859 // Change payload type for RTX.
3860 parameters.codecs[1].id = kUnusedPayloadType2;
3861 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3862 ASSERT_EQ(1U, fake_call_->GetVideoSendStreams().size());
3863 const webrtc::VideoSendStream::Config& config_after =
3864 fake_call_->GetVideoSendStreams()[0]->GetConfig();
3865 EXPECT_EQ(kUnusedPayloadType2, config_after.rtp.rtx.payload_type);
3866 ASSERT_EQ(1U, config_after.rtp.rtx.ssrcs.size());
3867 EXPECT_EQ(kRtxSsrcs1[0], config_after.rtp.rtx.ssrcs[0]);
3868}
3869
eladalonf1841382017-06-12 01:16:46 -07003870TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutFecDisablesFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003871 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003872 parameters.codecs.push_back(GetEngineCodec("VP8"));
3873 parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003874 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003875
3876 FakeVideoSendStream* stream = AddSendStream();
perkj26091b12016-09-01 01:17:40 -07003877 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003878
magjed509e4fe2016-11-18 01:34:11 -08003879 EXPECT_EQ(GetEngineCodec("ulpfec").id, config.rtp.ulpfec.ulpfec_payload_type);
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003880
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003881 parameters.codecs.pop_back();
3882 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003883 stream = fake_call_->GetVideoSendStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08003884 ASSERT_TRUE(stream != nullptr);
perkj26091b12016-09-01 01:17:40 -07003885 config = stream->GetConfig().Copy();
brandtrb5f2c3f2016-10-04 23:28:39 -07003886 EXPECT_EQ(-1, config.rtp.ulpfec.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08003887 << "SetSendCodec without ULPFEC should disable current ULPFEC.";
3888}
3889
eladalonf1841382017-06-12 01:16:46 -07003890TEST_F(WebRtcVideoChannelFlexfecSendRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003891 SetSendCodecsWithoutFecDisablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08003892 cricket::VideoSendParameters parameters;
3893 parameters.codecs.push_back(GetEngineCodec("VP8"));
3894 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3895 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3896
3897 FakeVideoSendStream* stream = AddSendStream(
3898 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3899 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3900
brandtr3d200bd2017-01-16 06:59:19 -08003901 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3902 EXPECT_EQ(kFlexfecSsrc, config.rtp.flexfec.ssrc);
brandtr468da7c2016-11-22 02:16:47 -08003903 ASSERT_EQ(1U, config.rtp.flexfec.protected_media_ssrcs.size());
3904 EXPECT_EQ(kSsrcs1[0], config.rtp.flexfec.protected_media_ssrcs[0]);
3905
3906 parameters.codecs.pop_back();
3907 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3908 stream = fake_call_->GetVideoSendStreams()[0];
3909 ASSERT_TRUE(stream != nullptr);
3910 config = stream->GetConfig().Copy();
brandtr3d200bd2017-01-16 06:59:19 -08003911 EXPECT_EQ(-1, config.rtp.flexfec.payload_type)
brandtr468da7c2016-11-22 02:16:47 -08003912 << "SetSendCodec without FlexFEC should disable current FlexFEC.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003913}
3914
eladalonf1841382017-06-12 01:16:46 -07003915TEST_F(WebRtcVideoChannelTest, SetSendCodecsChangesExistingStreams) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003916 cricket::VideoSendParameters parameters;
perkj26752742016-10-24 01:21:16 -07003917 cricket::VideoCodec codec(100, "VP8");
3918 codec.SetParam(kCodecParamMaxQuantization, kDefaultQpMax);
3919 parameters.codecs.push_back(codec);
perkjfa10b552016-10-02 23:45:26 -07003920
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003921 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00003922 channel_->SetSend(true);
pbos@webrtc.org38ce7d02014-07-16 08:01:38 +00003923
pbos@webrtc.org86196c42015-02-16 21:02:00 +00003924 FakeVideoSendStream* stream = AddSendStream();
Niels Mollera882fb32019-01-21 08:44:37 +00003925 FakeVideoCapturerWithTaskQueue capturer;
3926 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00003927
3928 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
perkjfa10b552016-10-02 23:45:26 -07003929 EXPECT_EQ(kDefaultQpMax, streams[0].max_qp);
pbos@webrtc.org38ce7d02014-07-16 08:01:38 +00003930
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003931 parameters.codecs.clear();
perkj26752742016-10-24 01:21:16 -07003932 codec.SetParam(kCodecParamMaxQuantization, kDefaultQpMax + 1);
3933 parameters.codecs.push_back(codec);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003934 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003935 streams = fake_call_->GetVideoSendStreams()[0]->GetVideoStreams();
perkjfa10b552016-10-02 23:45:26 -07003936 EXPECT_EQ(kDefaultQpMax + 1, streams[0].max_qp);
Niels Möllerff40b142018-04-09 08:49:14 +02003937 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003938}
3939
eladalonf1841382017-06-12 01:16:46 -07003940TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithBitrates) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00003941 SetSendCodecsShouldWorkForBitrates("100", 100000, "150", 150000, "200",
3942 200000);
3943}
3944
eladalonf1841382017-06-12 01:16:46 -07003945TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithHighMaxBitrate) {
pbos@webrtc.orga5f6fb52015-03-23 22:29:39 +00003946 SetSendCodecsShouldWorkForBitrates("", 0, "", -1, "10000", 10000000);
3947 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3948 ASSERT_EQ(1u, streams.size());
3949 EXPECT_EQ(10000000, streams[0].max_bitrate_bps);
3950}
3951
eladalonf1841382017-06-12 01:16:46 -07003952TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org00873182014-11-25 14:03:34 +00003953 SetSendCodecsWithoutBitratesUsesCorrectDefaults) {
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003954 SetSendCodecsShouldWorkForBitrates("", 0, "", -1, "", -1);
pbos@webrtc.org00873182014-11-25 14:03:34 +00003955}
3956
eladalonf1841382017-06-12 01:16:46 -07003957TEST_F(WebRtcVideoChannelTest, SetSendCodecsCapsMinAndStartBitrate) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00003958 SetSendCodecsShouldWorkForBitrates("-1", 0, "-100", -1, "", -1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003959}
3960
eladalonf1841382017-06-12 01:16:46 -07003961TEST_F(WebRtcVideoChannelTest, SetSendCodecsRejectsMaxLessThanMinBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003962 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "300";
3963 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "200";
3964 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003965}
3966
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003967// Test that when both the codec-specific bitrate params and max_bandwidth_bps
3968// are present in the same send parameters, the settings are combined correctly.
eladalonf1841382017-06-12 01:16:46 -07003969TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithBitratesAndMaxSendBandwidth) {
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003970 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
3971 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
3972 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
3973 send_parameters_.max_bandwidth_bps = 400000;
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003974 // We expect max_bandwidth_bps to take priority, if set.
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003975 ExpectSetBitrateParameters(100000, 200000, 400000);
3976 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
3977 // Since the codec isn't changing, start_bitrate_bps should be -1.
3978 ExpectSetBitrateParameters(100000, -1, 350000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003979
3980 // Decrease max_bandwidth_bps.
3981 send_parameters_.max_bandwidth_bps = 350000;
3982 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003983
3984 // Now try again with the values flipped around.
3985 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "400";
3986 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003987 ExpectSetBitrateParameters(100000, 200000, 300000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003988 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003989
3990 // If we change the codec max, max_bandwidth_bps should still apply.
3991 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "350";
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003992 ExpectSetBitrateParameters(100000, 200000, 300000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003993 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003994}
3995
Yves Gerey665174f2018-06-19 15:03:05 +02003996TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthShouldPreserveOtherBitrates) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00003997 SetSendCodecsShouldWorkForBitrates("100", 100000, "150", 150000, "200",
3998 200000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003999 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004000 // Setting max bitrate should keep previous min bitrate.
4001 // Setting max bitrate should not reset start bitrate.
4002 ExpectSetBitrateParameters(100000, -1, 300000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004003 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org00873182014-11-25 14:03:34 +00004004}
4005
eladalonf1841382017-06-12 01:16:46 -07004006TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthShouldBeRemovable) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004007 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004008 ExpectSetMaxBitrate(300000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004009 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos5c7760a2017-03-10 11:23:12 -08004010 // -1 means to disable max bitrate (set infinite).
4011 send_parameters_.max_bandwidth_bps = -1;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004012 ExpectSetMaxBitrate(-1);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004013 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004014}
4015
eladalonf1841382017-06-12 01:16:46 -07004016TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthAndAddSendStream) {
perkjfa10b552016-10-02 23:45:26 -07004017 send_parameters_.max_bandwidth_bps = 99999;
4018 FakeVideoSendStream* stream = AddSendStream();
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004019 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
perkjfa10b552016-10-02 23:45:26 -07004020 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
perkjfa10b552016-10-02 23:45:26 -07004021 ASSERT_EQ(1u, stream->GetVideoStreams().size());
4022 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4023 stream->GetVideoStreams()[0].max_bitrate_bps);
4024
4025 send_parameters_.max_bandwidth_bps = 77777;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004026 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
perkjfa10b552016-10-02 23:45:26 -07004027 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4028 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
perkjfa10b552016-10-02 23:45:26 -07004029 stream->GetVideoStreams()[0].max_bitrate_bps);
4030}
4031
Seth Hampsonfeec91e2018-07-13 10:41:10 -07004032// Tests that when the codec specific max bitrate and VideoSendParameters
4033// max_bandwidth_bps are used, that it sets the VideoStream's max bitrate
4034// appropriately.
4035TEST_F(WebRtcVideoChannelTest,
4036 MaxBitratePrioritizesVideoSendParametersOverCodecMaxBitrate) {
4037 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4038 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4039 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4040 send_parameters_.max_bandwidth_bps = -1;
4041 AddSendStream();
4042 ExpectSetMaxBitrate(300000);
4043 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4044
4045 std::vector<FakeVideoSendStream*> video_send_streams = GetFakeSendStreams();
4046 ASSERT_EQ(1u, video_send_streams.size());
4047 FakeVideoSendStream* video_send_stream = video_send_streams[0];
4048 ASSERT_EQ(1u, video_send_streams[0]->GetVideoStreams().size());
4049 // First the max bitrate is set based upon the codec param.
4050 EXPECT_EQ(300000,
4051 video_send_streams[0]->GetVideoStreams()[0].max_bitrate_bps);
4052
4053 // The VideoSendParameters max bitrate overrides the codec's.
4054 send_parameters_.max_bandwidth_bps = 500000;
4055 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
4056 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4057 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4058 EXPECT_EQ(500000, video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4059}
4060
4061// Tests that when the codec specific max bitrate and RtpParameters
4062// max_bitrate_bps are used, that it sets the VideoStream's max bitrate
4063// appropriately.
4064TEST_F(WebRtcVideoChannelTest,
4065 MaxBitratePrioritizesRtpParametersOverCodecMaxBitrate) {
4066 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4067 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4068 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4069 send_parameters_.max_bandwidth_bps = -1;
4070 AddSendStream();
4071 ExpectSetMaxBitrate(300000);
4072 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4073
4074 std::vector<FakeVideoSendStream*> video_send_streams = GetFakeSendStreams();
4075 ASSERT_EQ(1u, video_send_streams.size());
4076 FakeVideoSendStream* video_send_stream = video_send_streams[0];
4077 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4078 // First the max bitrate is set based upon the codec param.
4079 EXPECT_EQ(300000, video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4080
4081 // The RtpParameter max bitrate overrides the codec's.
4082 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
4083 ASSERT_EQ(1u, parameters.encodings.size());
4084 parameters.encodings[0].max_bitrate_bps = 500000;
4085 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4086 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4087 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps,
4088 video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4089}
4090
Åsa Persson55659812018-06-18 17:51:32 +02004091TEST_F(WebRtcVideoChannelTest,
4092 MaxBitrateIsMinimumOfMaxSendBandwidthAndMaxEncodingBitrate) {
4093 send_parameters_.max_bandwidth_bps = 99999;
4094 FakeVideoSendStream* stream = AddSendStream();
4095 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
4096 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4097 ASSERT_EQ(1u, stream->GetVideoStreams().size());
4098 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4099 stream->GetVideoStreams()[0].max_bitrate_bps);
4100
4101 // Get and set the rtp encoding parameters.
4102 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
4103 EXPECT_EQ(1u, parameters.encodings.size());
4104
4105 parameters.encodings[0].max_bitrate_bps = 99999 - 1;
4106 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4107 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps,
4108 stream->GetVideoStreams()[0].max_bitrate_bps);
4109
4110 parameters.encodings[0].max_bitrate_bps = 99999 + 1;
4111 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4112 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4113 stream->GetVideoStreams()[0].max_bitrate_bps);
4114}
4115
eladalonf1841382017-06-12 01:16:46 -07004116TEST_F(WebRtcVideoChannelTest, SetMaxSendBitrateCanIncreaseSenderBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004117 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004118 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004119 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004120 channel_->SetSend(true);
4121
4122 FakeVideoSendStream* stream = AddSendStream();
4123
Niels Mollera882fb32019-01-21 08:44:37 +00004124 FakeVideoCapturerWithTaskQueue capturer;
4125 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
4126 EXPECT_EQ(cricket::CS_RUNNING,
4127 capturer.Start(capturer.GetSupportedFormats()->front()));
Peter Boström3afc8c42016-01-27 16:45:21 +01004128
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004129 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
4130 int initial_max_bitrate_bps = streams[0].max_bitrate_bps;
4131 EXPECT_GT(initial_max_bitrate_bps, 0);
4132
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004133 parameters.max_bandwidth_bps = initial_max_bitrate_bps * 2;
4134 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström3afc8c42016-01-27 16:45:21 +01004135 // Insert a frame to update the encoder config.
Niels Mollera882fb32019-01-21 08:44:37 +00004136 EXPECT_TRUE(capturer.CaptureFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004137 streams = stream->GetVideoStreams();
4138 EXPECT_EQ(initial_max_bitrate_bps * 2, streams[0].max_bitrate_bps);
Niels Möllerff40b142018-04-09 08:49:14 +02004139 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004140}
4141
eladalonf1841382017-06-12 01:16:46 -07004142TEST_F(WebRtcVideoChannelTest,
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004143 SetMaxSendBitrateCanIncreaseSimulcastSenderBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004144 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004145 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004146 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004147 channel_->SetSend(true);
4148
4149 FakeVideoSendStream* stream = AddSendStream(
4150 cricket::CreateSimStreamParams("cname", MAKE_VECTOR(kSsrcs3)));
4151
4152 // Send a frame to make sure this scales up to >1 stream (simulcast).
Niels Mollera882fb32019-01-21 08:44:37 +00004153 FakeVideoCapturerWithTaskQueue capturer;
4154 EXPECT_TRUE(channel_->SetVideoSend(kSsrcs3[0], nullptr, &capturer));
4155 EXPECT_EQ(cricket::CS_RUNNING,
4156 capturer.Start(capturer.GetSupportedFormats()->front()));
4157 EXPECT_TRUE(capturer.CaptureFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004158
4159 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
4160 ASSERT_GT(streams.size(), 1u)
4161 << "Without simulcast this test doesn't make sense.";
pbosbe16f792015-10-16 12:49:39 -07004162 int initial_max_bitrate_bps = GetTotalMaxBitrateBps(streams);
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004163 EXPECT_GT(initial_max_bitrate_bps, 0);
4164
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004165 parameters.max_bandwidth_bps = initial_max_bitrate_bps * 2;
4166 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström3afc8c42016-01-27 16:45:21 +01004167 // Insert a frame to update the encoder config.
Niels Mollera882fb32019-01-21 08:44:37 +00004168 EXPECT_TRUE(capturer.CaptureFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004169 streams = stream->GetVideoStreams();
pbosbe16f792015-10-16 12:49:39 -07004170 int increased_max_bitrate_bps = GetTotalMaxBitrateBps(streams);
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004171 EXPECT_EQ(initial_max_bitrate_bps * 2, increased_max_bitrate_bps);
4172
Niels Möllerff40b142018-04-09 08:49:14 +02004173 EXPECT_TRUE(channel_->SetVideoSend(kSsrcs3[0], nullptr, nullptr));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004174}
4175
eladalonf1841382017-06-12 01:16:46 -07004176TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithMaxQuantization) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004177 static const char* kMaxQuantization = "21";
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004178 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004179 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004180 parameters.codecs[0].params[kCodecParamMaxQuantization] = kMaxQuantization;
4181 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Mirko Bonadeif859e552018-05-30 15:31:29 +02004182 EXPECT_EQ(atoi(kMaxQuantization),
pbos@webrtc.org6ae48c62014-06-06 10:49:19 +00004183 AddSendStream()->GetVideoStreams().back().max_qp);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004184
4185 VideoCodec codec;
4186 EXPECT_TRUE(channel_->GetSendCodec(&codec));
4187 EXPECT_EQ(kMaxQuantization, codec.params[kCodecParamMaxQuantization]);
4188}
4189
eladalonf1841382017-06-12 01:16:46 -07004190TEST_F(WebRtcVideoChannelTest, SetSendCodecsRejectBadPayloadTypes) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004191 // TODO(pbos): Should we only allow the dynamic range?
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00004192 static const int kIncorrectPayloads[] = {-2, -1, 128, 129};
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004193 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004194 parameters.codecs.push_back(GetEngineCodec("VP8"));
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00004195 for (size_t i = 0; i < arraysize(kIncorrectPayloads); ++i) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004196 parameters.codecs[0].id = kIncorrectPayloads[i];
4197 EXPECT_FALSE(channel_->SetSendParameters(parameters))
pkasting@chromium.orgd3245462015-02-23 21:28:22 +00004198 << "Bad payload type '" << kIncorrectPayloads[i] << "' accepted.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004199 }
4200}
4201
eladalonf1841382017-06-12 01:16:46 -07004202TEST_F(WebRtcVideoChannelTest, SetSendCodecsAcceptAllValidPayloadTypes) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004203 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004204 parameters.codecs.push_back(GetEngineCodec("VP8"));
magjedf823ede2016-11-12 09:53:04 -08004205 for (int payload_type = 96; payload_type <= 127; ++payload_type) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004206 parameters.codecs[0].id = payload_type;
4207 EXPECT_TRUE(channel_->SetSendParameters(parameters))
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004208 << "Payload type '" << payload_type << "' rejected.";
4209 }
4210}
4211
deadbeef67cf2c12016-04-13 10:07:16 -07004212// Test that setting the a different set of codecs but with an identical front
4213// codec doesn't result in the stream being recreated.
4214// This may happen when a subsequent negotiation includes fewer codecs, as a
4215// result of one of the codecs being rejected.
eladalonf1841382017-06-12 01:16:46 -07004216TEST_F(WebRtcVideoChannelTest,
deadbeef67cf2c12016-04-13 10:07:16 -07004217 SetSendCodecsIdenticalFirstCodecDoesntRecreateStream) {
4218 cricket::VideoSendParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08004219 parameters1.codecs.push_back(GetEngineCodec("VP8"));
4220 parameters1.codecs.push_back(GetEngineCodec("VP9"));
deadbeef67cf2c12016-04-13 10:07:16 -07004221 EXPECT_TRUE(channel_->SetSendParameters(parameters1));
4222
4223 AddSendStream();
4224 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
4225
4226 cricket::VideoSendParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08004227 parameters2.codecs.push_back(GetEngineCodec("VP8"));
deadbeef67cf2c12016-04-13 10:07:16 -07004228 EXPECT_TRUE(channel_->SetSendParameters(parameters2));
4229 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
4230}
4231
eladalonf1841382017-06-12 01:16:46 -07004232TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithOnlyVp8) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004233 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004234 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004235 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004236}
4237
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004238// Test that we set our inbound RTX codecs properly.
eladalonf1841382017-06-12 01:16:46 -07004239TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithRtx) {
magjed509e4fe2016-11-18 01:34:11 -08004240 const int kUnusedPayloadType1 = 126;
4241 const int kUnusedPayloadType2 = 127;
4242 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4243 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4244
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004245 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004246 parameters.codecs.push_back(GetEngineCodec("VP8"));
4247 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004248 parameters.codecs.push_back(rtx_codec);
4249 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004250 << "RTX codec without associated payload should be rejected.";
4251
magjed509e4fe2016-11-18 01:34:11 -08004252 parameters.codecs[1].SetParam("apt", kUnusedPayloadType2);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004253 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004254 << "RTX codec with invalid associated payload type should be rejected.";
4255
magjed509e4fe2016-11-18 01:34:11 -08004256 parameters.codecs[1].SetParam("apt", GetEngineCodec("VP8").id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004257 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004258
magjed509e4fe2016-11-18 01:34:11 -08004259 cricket::VideoCodec rtx_codec2(kUnusedPayloadType2, "rtx");
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004260 rtx_codec2.SetParam("apt", rtx_codec.id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004261 parameters.codecs.push_back(rtx_codec2);
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004262
Yves Gerey665174f2018-06-19 15:03:05 +02004263 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
4264 << "RTX codec with another RTX as associated payload type should be "
4265 "rejected.";
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004266}
4267
eladalonf1841382017-06-12 01:16:46 -07004268TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithChangedRtxPayloadType) {
brandtr14742122017-01-27 04:53:07 -08004269 const int kUnusedPayloadType1 = 126;
4270 const int kUnusedPayloadType2 = 127;
4271 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4272 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4273
4274 // SSRCs for RTX.
4275 cricket::StreamParams params =
4276 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
4277 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
4278 AddRecvStream(params);
4279
4280 // Original payload type for RTX.
4281 cricket::VideoRecvParameters parameters;
4282 parameters.codecs.push_back(GetEngineCodec("VP8"));
4283 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
4284 rtx_codec.SetParam("apt", GetEngineCodec("VP8").id);
4285 parameters.codecs.push_back(rtx_codec);
4286 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4287 ASSERT_EQ(1U, fake_call_->GetVideoReceiveStreams().size());
4288 const webrtc::VideoReceiveStream::Config& config_before =
4289 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
nisse26e3abb2017-08-25 04:44:25 -07004290 EXPECT_EQ(1U, config_before.rtp.rtx_associated_payload_types.size());
4291 const int* payload_type_before = FindKeyByValue(
4292 config_before.rtp.rtx_associated_payload_types, GetEngineCodec("VP8").id);
4293 ASSERT_NE(payload_type_before, nullptr);
4294 EXPECT_EQ(kUnusedPayloadType1, *payload_type_before);
brandtr14742122017-01-27 04:53:07 -08004295 EXPECT_EQ(kRtxSsrcs1[0], config_before.rtp.rtx_ssrc);
4296
4297 // Change payload type for RTX.
4298 parameters.codecs[1].id = kUnusedPayloadType2;
4299 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4300 ASSERT_EQ(1U, fake_call_->GetVideoReceiveStreams().size());
4301 const webrtc::VideoReceiveStream::Config& config_after =
4302 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
nisse26e3abb2017-08-25 04:44:25 -07004303 EXPECT_EQ(1U, config_after.rtp.rtx_associated_payload_types.size());
4304 const int* payload_type_after = FindKeyByValue(
4305 config_after.rtp.rtx_associated_payload_types, GetEngineCodec("VP8").id);
4306 ASSERT_NE(payload_type_after, nullptr);
4307 EXPECT_EQ(kUnusedPayloadType2, *payload_type_after);
brandtr14742122017-01-27 04:53:07 -08004308 EXPECT_EQ(kRtxSsrcs1[0], config_after.rtp.rtx_ssrc);
4309}
4310
eladalonf1841382017-06-12 01:16:46 -07004311TEST_F(WebRtcVideoChannelTest, SetRecvCodecsDifferentPayloadType) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004312 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004313 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004314 parameters.codecs[0].id = 99;
4315 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004316}
4317
eladalonf1841382017-06-12 01:16:46 -07004318TEST_F(WebRtcVideoChannelTest, SetRecvCodecsAcceptDefaultCodecs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004319 cricket::VideoRecvParameters parameters;
4320 parameters.codecs = engine_.codecs();
4321 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgccbed3b2014-07-11 13:02:54 +00004322
4323 FakeVideoReceiveStream* stream = AddRecvStream();
Tommi733b5472016-06-10 17:58:01 +02004324 const webrtc::VideoReceiveStream::Config& config = stream->GetConfig();
Niels Möllercb7e1d22018-09-11 15:56:04 +02004325 EXPECT_EQ(engine_.codecs()[0].name, config.decoders[0].video_format.name);
pbos@webrtc.org776e6f22014-10-29 15:28:39 +00004326 EXPECT_EQ(engine_.codecs()[0].id, config.decoders[0].payload_type);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004327}
4328
eladalonf1841382017-06-12 01:16:46 -07004329TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectUnsupportedCodec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004330 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004331 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkj26752742016-10-24 01:21:16 -07004332 parameters.codecs.push_back(VideoCodec(101, "WTF3"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004333 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004334}
4335
eladalonf1841382017-06-12 01:16:46 -07004336TEST_F(WebRtcVideoChannelTest, SetRecvCodecsAcceptsMultipleVideoCodecs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004337 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004338 parameters.codecs.push_back(GetEngineCodec("VP8"));
4339 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004340 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004341}
4342
eladalonf1841382017-06-12 01:16:46 -07004343TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithoutFecDisablesFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004344 cricket::VideoSendParameters send_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004345 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4346 send_parameters.codecs.push_back(GetEngineCodec("red"));
4347 send_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004348 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004349
4350 FakeVideoReceiveStream* stream = AddRecvStream();
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004351
magjed509e4fe2016-11-18 01:34:11 -08004352 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004353 stream->GetConfig().rtp.ulpfec_payload_type);
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004354
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004355 cricket::VideoRecvParameters recv_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004356 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004357 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00004358 stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004359 ASSERT_TRUE(stream != nullptr);
nisse3b3622f2017-09-26 02:49:21 -07004360 EXPECT_EQ(-1, stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004361 << "SetSendCodec without ULPFEC should disable current ULPFEC.";
4362}
4363
eladalonf1841382017-06-12 01:16:46 -07004364TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetRecvParamsWithoutFecDisablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004365 AddRecvStream(
4366 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08004367 const std::vector<FakeFlexfecReceiveStream*>& streams =
brandtr468da7c2016-11-22 02:16:47 -08004368 fake_call_->GetFlexfecReceiveStreams();
4369
4370 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004371 const FakeFlexfecReceiveStream* stream = streams.front();
4372 EXPECT_EQ(GetEngineCodec("flexfec-03").id, stream->GetConfig().payload_type);
4373 EXPECT_EQ(kFlexfecSsrc, stream->GetConfig().remote_ssrc);
4374 ASSERT_EQ(1U, stream->GetConfig().protected_media_ssrcs.size());
4375 EXPECT_EQ(kSsrcs1[0], stream->GetConfig().protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08004376
4377 cricket::VideoRecvParameters recv_parameters;
4378 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4379 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4380 EXPECT_TRUE(streams.empty())
4381 << "SetSendCodec without FlexFEC should disable current FlexFEC.";
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004382}
4383
eladalonf1841382017-06-12 01:16:46 -07004384TEST_F(WebRtcVideoChannelTest, SetSendParamsWithFecEnablesFec) {
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004385 FakeVideoReceiveStream* stream = AddRecvStream();
magjed509e4fe2016-11-18 01:34:11 -08004386 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004387 stream->GetConfig().rtp.ulpfec_payload_type);
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004388
4389 cricket::VideoRecvParameters recv_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004390 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4391 recv_parameters.codecs.push_back(GetEngineCodec("red"));
4392 recv_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004393 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4394 stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004395 ASSERT_TRUE(stream != nullptr);
magjed509e4fe2016-11-18 01:34:11 -08004396 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004397 stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004398 << "ULPFEC should be enabled on the receive stream.";
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004399
4400 cricket::VideoSendParameters send_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004401 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4402 send_parameters.codecs.push_back(GetEngineCodec("red"));
4403 send_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004404 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
4405 stream = fake_call_->GetVideoReceiveStreams()[0];
magjed509e4fe2016-11-18 01:34:11 -08004406 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004407 stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004408 << "ULPFEC should be enabled on the receive stream.";
4409}
4410
eladalonf1841382017-06-12 01:16:46 -07004411TEST_F(WebRtcVideoChannelFlexfecSendRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004412 SetSendRecvParamsWithFecEnablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004413 AddRecvStream(
4414 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08004415 const std::vector<FakeFlexfecReceiveStream*>& streams =
brandtr468da7c2016-11-22 02:16:47 -08004416 fake_call_->GetFlexfecReceiveStreams();
4417
4418 cricket::VideoRecvParameters recv_parameters;
4419 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4420 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4421 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4422 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004423 const FakeFlexfecReceiveStream* stream_with_recv_params = streams.front();
brandtr468da7c2016-11-22 02:16:47 -08004424 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9c3d4c42017-01-23 06:59:13 -08004425 stream_with_recv_params->GetConfig().payload_type);
4426 EXPECT_EQ(kFlexfecSsrc, stream_with_recv_params->GetConfig().remote_ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004427 EXPECT_EQ(1U,
brandtr9c3d4c42017-01-23 06:59:13 -08004428 stream_with_recv_params->GetConfig().protected_media_ssrcs.size());
brandtr468da7c2016-11-22 02:16:47 -08004429 EXPECT_EQ(kSsrcs1[0],
brandtr9c3d4c42017-01-23 06:59:13 -08004430 stream_with_recv_params->GetConfig().protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08004431
4432 cricket::VideoSendParameters send_parameters;
4433 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4434 send_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4435 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
4436 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004437 const FakeFlexfecReceiveStream* stream_with_send_params = streams.front();
brandtr468da7c2016-11-22 02:16:47 -08004438 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9c3d4c42017-01-23 06:59:13 -08004439 stream_with_send_params->GetConfig().payload_type);
4440 EXPECT_EQ(kFlexfecSsrc, stream_with_send_params->GetConfig().remote_ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004441 EXPECT_EQ(1U,
brandtr9c3d4c42017-01-23 06:59:13 -08004442 stream_with_send_params->GetConfig().protected_media_ssrcs.size());
brandtr468da7c2016-11-22 02:16:47 -08004443 EXPECT_EQ(kSsrcs1[0],
brandtr9c3d4c42017-01-23 06:59:13 -08004444 stream_with_send_params->GetConfig().protected_media_ssrcs[0]);
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004445}
4446
eladalonf1841382017-06-12 01:16:46 -07004447TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectDuplicateFecPayloads) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004448 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004449 parameters.codecs.push_back(GetEngineCodec("VP8"));
4450 parameters.codecs.push_back(GetEngineCodec("red"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004451 parameters.codecs[1].id = parameters.codecs[0].id;
4452 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004453}
4454
eladalonf1841382017-06-12 01:16:46 -07004455TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004456 SetRecvCodecsRejectDuplicateFecPayloads) {
brandtr468da7c2016-11-22 02:16:47 -08004457 cricket::VideoRecvParameters parameters;
4458 parameters.codecs.push_back(GetEngineCodec("VP8"));
4459 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4460 parameters.codecs[1].id = parameters.codecs[0].id;
4461 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
4462}
4463
eladalonf1841382017-06-12 01:16:46 -07004464TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectDuplicateCodecPayloads) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004465 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004466 parameters.codecs.push_back(GetEngineCodec("VP8"));
4467 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004468 parameters.codecs[1].id = parameters.codecs[0].id;
4469 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004470}
4471
eladalonf1841382017-06-12 01:16:46 -07004472TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004473 SetRecvCodecsAcceptSameCodecOnMultiplePayloadTypes) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004474 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004475 parameters.codecs.push_back(GetEngineCodec("VP8"));
4476 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004477 parameters.codecs[1].id += 1;
4478 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004479}
4480
deadbeef67cf2c12016-04-13 10:07:16 -07004481// Test that setting the same codecs but with a different order
deadbeef874ca3a2015-08-20 17:19:20 -07004482// doesn't result in the stream being recreated.
eladalonf1841382017-06-12 01:16:46 -07004483TEST_F(WebRtcVideoChannelTest,
deadbeef67cf2c12016-04-13 10:07:16 -07004484 SetRecvCodecsDifferentOrderDoesntRecreateStream) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004485 cricket::VideoRecvParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08004486 parameters1.codecs.push_back(GetEngineCodec("VP8"));
4487 parameters1.codecs.push_back(GetEngineCodec("red"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004488 EXPECT_TRUE(channel_->SetRecvParameters(parameters1));
deadbeef874ca3a2015-08-20 17:19:20 -07004489
4490 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
4491 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
4492
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004493 cricket::VideoRecvParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08004494 parameters2.codecs.push_back(GetEngineCodec("red"));
4495 parameters2.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004496 EXPECT_TRUE(channel_->SetRecvParameters(parameters2));
deadbeef874ca3a2015-08-20 17:19:20 -07004497 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
4498}
4499
eladalonf1841382017-06-12 01:16:46 -07004500TEST_F(WebRtcVideoChannelTest, SendStreamNotSendingByDefault) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004501 EXPECT_FALSE(AddSendStream()->IsSending());
4502}
4503
eladalonf1841382017-06-12 01:16:46 -07004504TEST_F(WebRtcVideoChannelTest, ReceiveStreamReceivingByDefault) {
pbos@webrtc.org85f42942014-07-22 09:14:58 +00004505 EXPECT_TRUE(AddRecvStream()->IsReceiving());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004506}
4507
eladalonf1841382017-06-12 01:16:46 -07004508TEST_F(WebRtcVideoChannelTest, SetSend) {
pbos@webrtc.org5301b0f2014-07-17 08:51:46 +00004509 FakeVideoSendStream* stream = AddSendStream();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004510 EXPECT_FALSE(stream->IsSending());
4511
4512 // false->true
4513 EXPECT_TRUE(channel_->SetSend(true));
4514 EXPECT_TRUE(stream->IsSending());
4515 // true->true
4516 EXPECT_TRUE(channel_->SetSend(true));
4517 EXPECT_TRUE(stream->IsSending());
4518 // true->false
4519 EXPECT_TRUE(channel_->SetSend(false));
4520 EXPECT_FALSE(stream->IsSending());
4521 // false->false
4522 EXPECT_TRUE(channel_->SetSend(false));
4523 EXPECT_FALSE(stream->IsSending());
4524
4525 EXPECT_TRUE(channel_->SetSend(true));
4526 FakeVideoSendStream* new_stream = AddSendStream();
4527 EXPECT_TRUE(new_stream->IsSending())
4528 << "Send stream created after SetSend(true) not sending initially.";
4529}
4530
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004531// This test verifies DSCP settings are properly applied on video media channel.
eladalonf1841382017-06-12 01:16:46 -07004532TEST_F(WebRtcVideoChannelTest, TestSetDscpOptions) {
kwiberg686a8ef2016-02-26 03:00:35 -08004533 std::unique_ptr<cricket::FakeNetworkInterface> network_interface(
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004534 new cricket::FakeNetworkInterface);
nisse51542be2016-02-12 02:27:06 -08004535 MediaConfig config;
Tim Haloun6ca98362018-09-17 17:06:08 -07004536 std::unique_ptr<cricket::WebRtcVideoChannel> channel;
Tim Haloun648d28a2018-10-18 16:52:22 -07004537 webrtc::RtpParameters parameters;
nisse51542be2016-02-12 02:27:06 -08004538
Sebastian Jansson84848f22018-11-16 10:40:36 +01004539 channel.reset(
4540 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
4541 call_.get(), config, VideoOptions(), webrtc::CryptoOptions())));
Anton Sukhanov98a462c2018-10-17 13:15:42 -07004542 channel->SetInterface(network_interface.get(), /*media_transport=*/nullptr);
nisse51542be2016-02-12 02:27:06 -08004543 // Default value when DSCP is disabled should be DSCP_DEFAULT.
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004544 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
nisse51542be2016-02-12 02:27:06 -08004545
Tim Haloun648d28a2018-10-18 16:52:22 -07004546 // Default value when DSCP is enabled is also DSCP_DEFAULT, until it is set
4547 // through rtp parameters.
nisse51542be2016-02-12 02:27:06 -08004548 config.enable_dscp = true;
Sebastian Jansson84848f22018-11-16 10:40:36 +01004549 channel.reset(
4550 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
4551 call_.get(), config, VideoOptions(), webrtc::CryptoOptions())));
Anton Sukhanov98a462c2018-10-17 13:15:42 -07004552 channel->SetInterface(network_interface.get(), /*media_transport=*/nullptr);
Tim Haloun648d28a2018-10-18 16:52:22 -07004553 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
4554
4555 // Create a send stream to configure
4556 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
4557 parameters = channel->GetRtpSendParameters(kSsrc);
4558 ASSERT_FALSE(parameters.encodings.empty());
4559
4560 // Various priorities map to various dscp values.
4561 parameters.encodings[0].network_priority = 4.0;
4562 ASSERT_TRUE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
nisse51542be2016-02-12 02:27:06 -08004563 EXPECT_EQ(rtc::DSCP_AF41, network_interface->dscp());
Tim Haloun648d28a2018-10-18 16:52:22 -07004564 parameters.encodings[0].network_priority = 0.5;
4565 ASSERT_TRUE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
4566 EXPECT_EQ(rtc::DSCP_CS1, network_interface->dscp());
4567
4568 // A bad priority does not change the dscp value.
4569 parameters.encodings[0].network_priority = 0.0;
4570 ASSERT_FALSE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
4571 EXPECT_EQ(rtc::DSCP_CS1, network_interface->dscp());
nisse51542be2016-02-12 02:27:06 -08004572
Tim Haloun6ca98362018-09-17 17:06:08 -07004573 // Packets should also self-identify their dscp in PacketOptions.
4574 const uint8_t kData[10] = {0};
4575 EXPECT_TRUE(static_cast<webrtc::Transport*>(channel.get())
4576 ->SendRtcp(kData, sizeof(kData)));
Tim Haloun648d28a2018-10-18 16:52:22 -07004577 EXPECT_EQ(rtc::DSCP_CS1, network_interface->options().dscp);
Tim Haloun6ca98362018-09-17 17:06:08 -07004578
nisse51542be2016-02-12 02:27:06 -08004579 // Verify that setting the option to false resets the
4580 // DiffServCodePoint.
4581 config.enable_dscp = false;
Sebastian Jansson84848f22018-11-16 10:40:36 +01004582 channel.reset(
4583 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
4584 call_.get(), config, VideoOptions(), webrtc::CryptoOptions())));
Anton Sukhanov98a462c2018-10-17 13:15:42 -07004585 channel->SetInterface(network_interface.get(), /*media_transport=*/nullptr);
nisse51542be2016-02-12 02:27:06 -08004586 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004587}
4588
deadbeef13871492015-12-09 12:37:51 -08004589// This test verifies that the RTCP reduced size mode is properly applied to
4590// send video streams.
eladalonf1841382017-06-12 01:16:46 -07004591TEST_F(WebRtcVideoChannelTest, TestSetSendRtcpReducedSize) {
deadbeef13871492015-12-09 12:37:51 -08004592 // Create stream, expecting that default mode is "compound".
4593 FakeVideoSendStream* stream1 = AddSendStream();
4594 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream1->GetConfig().rtp.rtcp_mode);
Florent Castellidacec712018-05-24 16:24:21 +02004595 webrtc::RtpParameters rtp_parameters =
4596 channel_->GetRtpSendParameters(last_ssrc_);
4597 EXPECT_FALSE(rtp_parameters.rtcp.reduced_size);
deadbeef13871492015-12-09 12:37:51 -08004598
4599 // Now enable reduced size mode.
4600 send_parameters_.rtcp.reduced_size = true;
4601 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
4602 stream1 = fake_call_->GetVideoSendStreams()[0];
4603 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream1->GetConfig().rtp.rtcp_mode);
Florent Castellidacec712018-05-24 16:24:21 +02004604 rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
4605 EXPECT_TRUE(rtp_parameters.rtcp.reduced_size);
deadbeef13871492015-12-09 12:37:51 -08004606
4607 // Create a new stream and ensure it picks up the reduced size mode.
4608 FakeVideoSendStream* stream2 = AddSendStream();
4609 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream2->GetConfig().rtp.rtcp_mode);
4610}
4611
4612// This test verifies that the RTCP reduced size mode is properly applied to
4613// receive video streams.
eladalonf1841382017-06-12 01:16:46 -07004614TEST_F(WebRtcVideoChannelTest, TestSetRecvRtcpReducedSize) {
deadbeef13871492015-12-09 12:37:51 -08004615 // Create stream, expecting that default mode is "compound".
4616 FakeVideoReceiveStream* stream1 = AddRecvStream();
4617 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream1->GetConfig().rtp.rtcp_mode);
4618
4619 // Now enable reduced size mode.
Taylor Brandstetter5f0b83b2016-03-18 15:02:07 -07004620 // TODO(deadbeef): Once "recv_parameters" becomes "receiver_parameters",
4621 // the reduced_size flag should come from that.
4622 send_parameters_.rtcp.reduced_size = true;
4623 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
deadbeef13871492015-12-09 12:37:51 -08004624 stream1 = fake_call_->GetVideoReceiveStreams()[0];
4625 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream1->GetConfig().rtp.rtcp_mode);
4626
4627 // Create a new stream and ensure it picks up the reduced size mode.
4628 FakeVideoReceiveStream* stream2 = AddRecvStream();
4629 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream2->GetConfig().rtp.rtcp_mode);
4630}
4631
eladalonf1841382017-06-12 01:16:46 -07004632TEST_F(WebRtcVideoChannelTest, OnReadyToSendSignalsNetworkState) {
skvlad7a43d252016-03-22 15:32:27 -07004633 EXPECT_EQ(webrtc::kNetworkUp,
4634 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4635 EXPECT_EQ(webrtc::kNetworkUp,
4636 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.org26c0c412014-09-03 16:17:12 +00004637
4638 channel_->OnReadyToSend(false);
skvlad7a43d252016-03-22 15:32:27 -07004639 EXPECT_EQ(webrtc::kNetworkDown,
4640 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4641 EXPECT_EQ(webrtc::kNetworkUp,
4642 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.org26c0c412014-09-03 16:17:12 +00004643
4644 channel_->OnReadyToSend(true);
skvlad7a43d252016-03-22 15:32:27 -07004645 EXPECT_EQ(webrtc::kNetworkUp,
4646 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4647 EXPECT_EQ(webrtc::kNetworkUp,
4648 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004649}
4650
eladalonf1841382017-06-12 01:16:46 -07004651TEST_F(WebRtcVideoChannelTest, GetStatsReportsSentCodecName) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004652 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004653 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004654 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström74d9ed72015-03-26 16:28:31 +01004655
4656 AddSendStream();
4657
4658 cricket::VideoMediaInfo info;
4659 ASSERT_TRUE(channel_->GetStats(&info));
magjed509e4fe2016-11-18 01:34:11 -08004660 EXPECT_EQ("VP8", info.senders[0].codec_name);
Peter Boström74d9ed72015-03-26 16:28:31 +01004661}
4662
eladalonf1841382017-06-12 01:16:46 -07004663TEST_F(WebRtcVideoChannelTest, GetStatsReportsEncoderImplementationName) {
Peter Boströmb7d9a972015-12-18 16:01:11 +01004664 FakeVideoSendStream* stream = AddSendStream();
4665 webrtc::VideoSendStream::Stats stats;
4666 stats.encoder_implementation_name = "encoder_implementation_name";
4667 stream->SetStats(stats);
4668
4669 cricket::VideoMediaInfo info;
4670 ASSERT_TRUE(channel_->GetStats(&info));
4671 EXPECT_EQ(stats.encoder_implementation_name,
4672 info.senders[0].encoder_implementation_name);
4673}
4674
eladalonf1841382017-06-12 01:16:46 -07004675TEST_F(WebRtcVideoChannelTest, GetStatsReportsCpuOveruseMetrics) {
pbos@webrtc.org3e6e2712015-02-26 12:19:31 +00004676 FakeVideoSendStream* stream = AddSendStream();
4677 webrtc::VideoSendStream::Stats stats;
4678 stats.avg_encode_time_ms = 13;
4679 stats.encode_usage_percent = 42;
4680 stream->SetStats(stats);
4681
4682 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004683 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org3e6e2712015-02-26 12:19:31 +00004684 EXPECT_EQ(stats.avg_encode_time_ms, info.senders[0].avg_encode_ms);
4685 EXPECT_EQ(stats.encode_usage_percent, info.senders[0].encode_usage_percent);
4686}
4687
eladalonf1841382017-06-12 01:16:46 -07004688TEST_F(WebRtcVideoChannelTest, GetStatsReportsFramesEncoded) {
sakal43536c32016-10-24 01:46:43 -07004689 FakeVideoSendStream* stream = AddSendStream();
4690 webrtc::VideoSendStream::Stats stats;
4691 stats.frames_encoded = 13;
4692 stream->SetStats(stats);
4693
4694 cricket::VideoMediaInfo info;
4695 ASSERT_TRUE(channel_->GetStats(&info));
4696 EXPECT_EQ(stats.frames_encoded, info.senders[0].frames_encoded);
4697}
4698
eladalonf1841382017-06-12 01:16:46 -07004699TEST_F(WebRtcVideoChannelTest, GetStatsReportsQpSum) {
sakal87da4042016-10-31 06:53:47 -07004700 FakeVideoSendStream* stream = AddSendStream();
4701 webrtc::VideoSendStream::Stats stats;
Oskar Sundbom78807582017-11-16 11:09:55 +01004702 stats.qp_sum = 13;
sakal87da4042016-10-31 06:53:47 -07004703 stream->SetStats(stats);
4704
4705 cricket::VideoMediaInfo info;
4706 ASSERT_TRUE(channel_->GetStats(&info));
4707 EXPECT_EQ(stats.qp_sum, info.senders[0].qp_sum);
4708}
4709
eladalonf1841382017-06-12 01:16:46 -07004710TEST_F(WebRtcVideoChannelTest, GetStatsReportsUpperResolution) {
pbos@webrtc.org273a4142014-12-01 15:23:21 +00004711 FakeVideoSendStream* stream = AddSendStream();
4712 webrtc::VideoSendStream::Stats stats;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004713 stats.substreams[17].width = 123;
4714 stats.substreams[17].height = 40;
4715 stats.substreams[42].width = 80;
4716 stats.substreams[42].height = 31;
4717 stats.substreams[11].width = 20;
4718 stats.substreams[11].height = 90;
pbos@webrtc.org273a4142014-12-01 15:23:21 +00004719 stream->SetStats(stats);
4720
4721 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004722 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org273a4142014-12-01 15:23:21 +00004723 ASSERT_EQ(1u, info.senders.size());
4724 EXPECT_EQ(123, info.senders[0].send_frame_width);
4725 EXPECT_EQ(90, info.senders[0].send_frame_height);
4726}
4727
eladalonf1841382017-06-12 01:16:46 -07004728TEST_F(WebRtcVideoChannelTest, GetStatsReportsCpuAdaptationStats) {
perkj803d97f2016-11-01 11:45:46 -07004729 FakeVideoSendStream* stream = AddSendStream();
4730 webrtc::VideoSendStream::Stats stats;
4731 stats.number_of_cpu_adapt_changes = 2;
4732 stats.cpu_limited_resolution = true;
4733 stream->SetStats(stats);
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004734
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004735 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004736 EXPECT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004737 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07004738 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_CPU, info.senders[0].adapt_reason);
perkj803d97f2016-11-01 11:45:46 -07004739 EXPECT_EQ(stats.number_of_cpu_adapt_changes, info.senders[0].adapt_changes);
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004740}
4741
eladalonf1841382017-06-12 01:16:46 -07004742TEST_F(WebRtcVideoChannelTest, GetStatsReportsAdaptationAndBandwidthStats) {
perkj803d97f2016-11-01 11:45:46 -07004743 FakeVideoSendStream* stream = AddSendStream();
asapersson17821db2015-12-14 02:08:12 -08004744 webrtc::VideoSendStream::Stats stats;
perkj803d97f2016-11-01 11:45:46 -07004745 stats.number_of_cpu_adapt_changes = 2;
4746 stats.cpu_limited_resolution = true;
asapersson17821db2015-12-14 02:08:12 -08004747 stats.bw_limited_resolution = true;
perkj803d97f2016-11-01 11:45:46 -07004748 stream->SetStats(stats);
4749
4750 cricket::VideoMediaInfo info;
asapersson17821db2015-12-14 02:08:12 -08004751 EXPECT_TRUE(channel_->GetStats(&info));
4752 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07004753 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_CPU |
4754 WebRtcVideoChannel::ADAPTREASON_BANDWIDTH,
asapersson17821db2015-12-14 02:08:12 -08004755 info.senders[0].adapt_reason);
perkj803d97f2016-11-01 11:45:46 -07004756 EXPECT_EQ(stats.number_of_cpu_adapt_changes, info.senders[0].adapt_changes);
asapersson17821db2015-12-14 02:08:12 -08004757}
4758
eladalonf1841382017-06-12 01:16:46 -07004759TEST_F(WebRtcVideoChannelTest,
asapersson17821db2015-12-14 02:08:12 -08004760 GetStatsTranslatesBandwidthLimitedResolutionCorrectly) {
4761 FakeVideoSendStream* stream = AddSendStream();
4762 webrtc::VideoSendStream::Stats stats;
4763 stats.bw_limited_resolution = true;
4764 stream->SetStats(stats);
4765
4766 cricket::VideoMediaInfo info;
4767 EXPECT_TRUE(channel_->GetStats(&info));
4768 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07004769 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_BANDWIDTH,
asapersson17821db2015-12-14 02:08:12 -08004770 info.senders[0].adapt_reason);
4771}
4772
Yves Gerey665174f2018-06-19 15:03:05 +02004773TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesSendRtcpPacketTypesCorrectly) {
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004774 FakeVideoSendStream* stream = AddSendStream();
4775 webrtc::VideoSendStream::Stats stats;
4776 stats.substreams[17].rtcp_packet_type_counts.fir_packets = 2;
4777 stats.substreams[17].rtcp_packet_type_counts.nack_packets = 3;
4778 stats.substreams[17].rtcp_packet_type_counts.pli_packets = 4;
4779
4780 stats.substreams[42].rtcp_packet_type_counts.fir_packets = 5;
4781 stats.substreams[42].rtcp_packet_type_counts.nack_packets = 7;
4782 stats.substreams[42].rtcp_packet_type_counts.pli_packets = 9;
4783
4784 stream->SetStats(stats);
4785
4786 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004787 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004788 EXPECT_EQ(7, info.senders[0].firs_rcvd);
4789 EXPECT_EQ(10, info.senders[0].nacks_rcvd);
4790 EXPECT_EQ(13, info.senders[0].plis_rcvd);
4791}
4792
eladalonf1841382017-06-12 01:16:46 -07004793TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004794 GetStatsTranslatesReceiveRtcpPacketTypesCorrectly) {
4795 FakeVideoReceiveStream* stream = AddRecvStream();
4796 webrtc::VideoReceiveStream::Stats stats;
4797 stats.rtcp_packet_type_counts.fir_packets = 2;
4798 stats.rtcp_packet_type_counts.nack_packets = 3;
4799 stats.rtcp_packet_type_counts.pli_packets = 4;
4800 stream->SetStats(stats);
4801
4802 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004803 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004804 EXPECT_EQ(stats.rtcp_packet_type_counts.fir_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004805 rtc::checked_cast<unsigned int>(info.receivers[0].firs_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004806 EXPECT_EQ(stats.rtcp_packet_type_counts.nack_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004807 rtc::checked_cast<unsigned int>(info.receivers[0].nacks_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004808 EXPECT_EQ(stats.rtcp_packet_type_counts.pli_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004809 rtc::checked_cast<unsigned int>(info.receivers[0].plis_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004810}
4811
eladalonf1841382017-06-12 01:16:46 -07004812TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesDecodeStatsCorrectly) {
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004813 FakeVideoReceiveStream* stream = AddRecvStream();
4814 webrtc::VideoReceiveStream::Stats stats;
Peter Boströmb7d9a972015-12-18 16:01:11 +01004815 stats.decoder_implementation_name = "decoder_implementation_name";
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004816 stats.decode_ms = 2;
4817 stats.max_decode_ms = 3;
4818 stats.current_delay_ms = 4;
4819 stats.target_delay_ms = 5;
4820 stats.jitter_buffer_ms = 6;
4821 stats.min_playout_delay_ms = 7;
4822 stats.render_delay_ms = 8;
asapersson26dd92b2016-08-30 00:45:45 -07004823 stats.width = 9;
4824 stats.height = 10;
hbos42f6d2f2017-01-20 03:56:50 -08004825 stats.frame_counts.key_frames = 11;
4826 stats.frame_counts.delta_frames = 12;
hbos50cfe1f2017-01-23 07:21:55 -08004827 stats.frames_rendered = 13;
4828 stats.frames_decoded = 14;
Oskar Sundbom78807582017-11-16 11:09:55 +01004829 stats.qp_sum = 15;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004830 stream->SetStats(stats);
4831
4832 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004833 ASSERT_TRUE(channel_->GetStats(&info));
Peter Boströmb7d9a972015-12-18 16:01:11 +01004834 EXPECT_EQ(stats.decoder_implementation_name,
4835 info.receivers[0].decoder_implementation_name);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004836 EXPECT_EQ(stats.decode_ms, info.receivers[0].decode_ms);
4837 EXPECT_EQ(stats.max_decode_ms, info.receivers[0].max_decode_ms);
4838 EXPECT_EQ(stats.current_delay_ms, info.receivers[0].current_delay_ms);
4839 EXPECT_EQ(stats.target_delay_ms, info.receivers[0].target_delay_ms);
4840 EXPECT_EQ(stats.jitter_buffer_ms, info.receivers[0].jitter_buffer_ms);
4841 EXPECT_EQ(stats.min_playout_delay_ms, info.receivers[0].min_playout_delay_ms);
4842 EXPECT_EQ(stats.render_delay_ms, info.receivers[0].render_delay_ms);
asapersson26dd92b2016-08-30 00:45:45 -07004843 EXPECT_EQ(stats.width, info.receivers[0].frame_width);
4844 EXPECT_EQ(stats.height, info.receivers[0].frame_height);
Mirko Bonadeif859e552018-05-30 15:31:29 +02004845 EXPECT_EQ(rtc::checked_cast<unsigned int>(stats.frame_counts.key_frames +
4846 stats.frame_counts.delta_frames),
hbos42f6d2f2017-01-20 03:56:50 -08004847 info.receivers[0].frames_received);
hbos50cfe1f2017-01-23 07:21:55 -08004848 EXPECT_EQ(stats.frames_rendered, info.receivers[0].frames_rendered);
sakale5ba44e2016-10-26 07:09:24 -07004849 EXPECT_EQ(stats.frames_decoded, info.receivers[0].frames_decoded);
sakalcc452e12017-02-09 04:53:45 -08004850 EXPECT_EQ(stats.qp_sum, info.receivers[0].qp_sum);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004851}
4852
eladalonf1841382017-06-12 01:16:46 -07004853TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesReceivePacketStatsCorrectly) {
Peter Boström393347f2015-04-22 14:52:45 +02004854 FakeVideoReceiveStream* stream = AddRecvStream();
4855 webrtc::VideoReceiveStream::Stats stats;
4856 stats.rtp_stats.transmitted.payload_bytes = 2;
4857 stats.rtp_stats.transmitted.header_bytes = 3;
4858 stats.rtp_stats.transmitted.padding_bytes = 4;
4859 stats.rtp_stats.transmitted.packets = 5;
srte186d9c32017-08-04 05:03:53 -07004860 stats.rtcp_stats.packets_lost = 6;
Peter Boström393347f2015-04-22 14:52:45 +02004861 stats.rtcp_stats.fraction_lost = 7;
4862 stream->SetStats(stats);
4863
4864 cricket::VideoMediaInfo info;
4865 ASSERT_TRUE(channel_->GetStats(&info));
4866 EXPECT_EQ(stats.rtp_stats.transmitted.payload_bytes +
4867 stats.rtp_stats.transmitted.header_bytes +
4868 stats.rtp_stats.transmitted.padding_bytes,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004869 rtc::checked_cast<size_t>(info.receivers[0].bytes_rcvd));
Peter Boström393347f2015-04-22 14:52:45 +02004870 EXPECT_EQ(stats.rtp_stats.transmitted.packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004871 rtc::checked_cast<unsigned int>(info.receivers[0].packets_rcvd));
srte186d9c32017-08-04 05:03:53 -07004872 EXPECT_EQ(stats.rtcp_stats.packets_lost, info.receivers[0].packets_lost);
Mirko Bonadeif859e552018-05-30 15:31:29 +02004873 EXPECT_EQ(rtc::checked_cast<float>(stats.rtcp_stats.fraction_lost) / (1 << 8),
Peter Boström393347f2015-04-22 14:52:45 +02004874 info.receivers[0].fraction_lost);
4875}
4876
eladalonf1841382017-06-12 01:16:46 -07004877TEST_F(WebRtcVideoChannelTest, TranslatesCallStatsCorrectly) {
pbos@webrtc.org2b19f062014-12-11 13:26:09 +00004878 AddSendStream();
4879 AddSendStream();
4880 webrtc::Call::Stats stats;
4881 stats.rtt_ms = 123;
4882 fake_call_->SetStats(stats);
4883
4884 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004885 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org2b19f062014-12-11 13:26:09 +00004886 ASSERT_EQ(2u, info.senders.size());
4887 EXPECT_EQ(stats.rtt_ms, info.senders[0].rtt_ms);
4888 EXPECT_EQ(stats.rtt_ms, info.senders[1].rtt_ms);
4889}
4890
eladalonf1841382017-06-12 01:16:46 -07004891TEST_F(WebRtcVideoChannelTest, TranslatesSenderBitrateStatsCorrectly) {
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004892 FakeVideoSendStream* stream = AddSendStream();
4893 webrtc::VideoSendStream::Stats stats;
pbos@webrtc.org891d4832015-02-26 13:15:22 +00004894 stats.target_media_bitrate_bps = 156;
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004895 stats.media_bitrate_bps = 123;
4896 stats.substreams[17].total_bitrate_bps = 1;
4897 stats.substreams[17].retransmit_bitrate_bps = 2;
4898 stats.substreams[42].total_bitrate_bps = 3;
4899 stats.substreams[42].retransmit_bitrate_bps = 4;
4900 stream->SetStats(stats);
4901
4902 FakeVideoSendStream* stream2 = AddSendStream();
4903 webrtc::VideoSendStream::Stats stats2;
pbos@webrtc.org891d4832015-02-26 13:15:22 +00004904 stats2.target_media_bitrate_bps = 200;
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004905 stats2.media_bitrate_bps = 321;
4906 stats2.substreams[13].total_bitrate_bps = 5;
4907 stats2.substreams[13].retransmit_bitrate_bps = 6;
4908 stats2.substreams[21].total_bitrate_bps = 7;
4909 stats2.substreams[21].retransmit_bitrate_bps = 8;
4910 stream2->SetStats(stats2);
4911
4912 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004913 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004914 ASSERT_EQ(2u, info.senders.size());
stefanf79ade12017-06-02 06:44:03 -07004915 BandwidthEstimationInfo bwe_info;
4916 channel_->FillBitrateInfo(&bwe_info);
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004917 // Assuming stream and stream2 corresponds to senders[0] and [1] respectively
4918 // is OK as std::maps are sorted and AddSendStream() gives increasing SSRCs.
4919 EXPECT_EQ(stats.media_bitrate_bps, info.senders[0].nominal_bitrate);
4920 EXPECT_EQ(stats2.media_bitrate_bps, info.senders[1].nominal_bitrate);
pbos@webrtc.org891d4832015-02-26 13:15:22 +00004921 EXPECT_EQ(stats.target_media_bitrate_bps + stats2.target_media_bitrate_bps,
stefanf79ade12017-06-02 06:44:03 -07004922 bwe_info.target_enc_bitrate);
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004923 EXPECT_EQ(stats.media_bitrate_bps + stats2.media_bitrate_bps,
stefanf79ade12017-06-02 06:44:03 -07004924 bwe_info.actual_enc_bitrate);
4925 EXPECT_EQ(1 + 3 + 5 + 7, bwe_info.transmit_bitrate)
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004926 << "Bandwidth stats should take all streams into account.";
stefanf79ade12017-06-02 06:44:03 -07004927 EXPECT_EQ(2 + 4 + 6 + 8, bwe_info.retransmit_bitrate)
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004928 << "Bandwidth stats should take all streams into account.";
4929}
4930
eladalonf1841382017-06-12 01:16:46 -07004931TEST_F(WebRtcVideoChannelTest, DefaultReceiveStreamReconfiguresToUseRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004932 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004933
Peter Boström0c4e06b2015-10-07 12:23:21 +02004934 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
4935 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004936
4937 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
4938 const size_t kDataLength = 12;
4939 uint8_t data[kDataLength];
4940 memset(data, 0, sizeof(data));
4941 rtc::SetBE32(&data[8], ssrcs[0]);
jbaucheec21bd2016-03-20 06:15:43 -07004942 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Niels Möllere6933812018-11-05 13:01:41 +01004943 channel_->OnPacketReceived(&packet, /* packet_time_us */ -1);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004944
4945 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
4946 << "No default receive stream created.";
4947 FakeVideoReceiveStream* recv_stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr14742122017-01-27 04:53:07 -08004948 EXPECT_EQ(0u, recv_stream->GetConfig().rtp.rtx_ssrc)
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004949 << "Default receive stream should not have configured RTX";
4950
4951 EXPECT_TRUE(channel_->AddRecvStream(
4952 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs)));
4953 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
brandtr14742122017-01-27 04:53:07 -08004954 << "AddRecvStream should have reconfigured, not added a new receiver.";
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004955 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
nisse26e3abb2017-08-25 04:44:25 -07004956 EXPECT_FALSE(
4957 recv_stream->GetConfig().rtp.rtx_associated_payload_types.empty());
nisseca5706d2017-09-11 02:32:16 -07004958 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
Peter Boströmd8b01092016-05-12 16:44:36 +02004959 << "RTX should be mapped for all decoders/payload types.";
nisseca5706d2017-09-11 02:32:16 -07004960 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02004961 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07004962 << "RTX should be mapped also for the RED payload type";
brandtr14742122017-01-27 04:53:07 -08004963 EXPECT_EQ(rtx_ssrcs[0], recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004964}
4965
eladalonf1841382017-06-12 01:16:46 -07004966TEST_F(WebRtcVideoChannelTest, RejectsAddingStreamsWithMissingSsrcsForRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004967 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd4362cd2015-03-25 14:17:23 +01004968
Peter Boström0c4e06b2015-10-07 12:23:21 +02004969 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
4970 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
Peter Boströmd4362cd2015-03-25 14:17:23 +01004971
4972 StreamParams sp =
4973 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs);
4974 sp.ssrcs = ssrcs; // Without RTXs, this is the important part.
4975
4976 EXPECT_FALSE(channel_->AddSendStream(sp));
4977 EXPECT_FALSE(channel_->AddRecvStream(sp));
4978}
4979
eladalonf1841382017-06-12 01:16:46 -07004980TEST_F(WebRtcVideoChannelTest, RejectsAddingStreamsWithOverlappingRtxSsrcs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004981 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd6f4c252015-03-26 16:23:04 +01004982
Peter Boström0c4e06b2015-10-07 12:23:21 +02004983 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
4984 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
Peter Boströmd6f4c252015-03-26 16:23:04 +01004985
4986 StreamParams sp =
4987 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs);
4988
4989 EXPECT_TRUE(channel_->AddSendStream(sp));
4990 EXPECT_TRUE(channel_->AddRecvStream(sp));
4991
4992 // The RTX SSRC is already used in previous streams, using it should fail.
4993 sp = cricket::StreamParams::CreateLegacy(rtx_ssrcs[0]);
4994 EXPECT_FALSE(channel_->AddSendStream(sp));
4995 EXPECT_FALSE(channel_->AddRecvStream(sp));
4996
4997 // After removing the original stream this should be fine to add (makes sure
4998 // that RTX ssrcs are not forever taken).
4999 EXPECT_TRUE(channel_->RemoveSendStream(ssrcs[0]));
5000 EXPECT_TRUE(channel_->RemoveRecvStream(ssrcs[0]));
5001 EXPECT_TRUE(channel_->AddSendStream(sp));
5002 EXPECT_TRUE(channel_->AddRecvStream(sp));
5003}
5004
eladalonf1841382017-06-12 01:16:46 -07005005TEST_F(WebRtcVideoChannelTest,
Peter Boströmd6f4c252015-03-26 16:23:04 +01005006 RejectsAddingStreamsWithOverlappingSimulcastSsrcs) {
Peter Boström0c4e06b2015-10-07 12:23:21 +02005007 static const uint32_t kFirstStreamSsrcs[] = {1, 2, 3};
5008 static const uint32_t kOverlappingStreamSsrcs[] = {4, 3, 5};
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005009 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005010
Peter Boströmd6f4c252015-03-26 16:23:04 +01005011 StreamParams sp =
5012 cricket::CreateSimStreamParams("cname", MAKE_VECTOR(kFirstStreamSsrcs));
5013
5014 EXPECT_TRUE(channel_->AddSendStream(sp));
5015 EXPECT_TRUE(channel_->AddRecvStream(sp));
5016
5017 // One of the SSRCs is already used in previous streams, using it should fail.
5018 sp = cricket::CreateSimStreamParams("cname",
5019 MAKE_VECTOR(kOverlappingStreamSsrcs));
5020 EXPECT_FALSE(channel_->AddSendStream(sp));
5021 EXPECT_FALSE(channel_->AddRecvStream(sp));
5022
5023 // After removing the original stream this should be fine to add (makes sure
5024 // that RTX ssrcs are not forever taken).
Peter Boström3548dd22015-05-22 18:48:36 +02005025 EXPECT_TRUE(channel_->RemoveSendStream(kFirstStreamSsrcs[0]));
5026 EXPECT_TRUE(channel_->RemoveRecvStream(kFirstStreamSsrcs[0]));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005027 EXPECT_TRUE(channel_->AddSendStream(sp));
5028 EXPECT_TRUE(channel_->AddRecvStream(sp));
5029}
5030
eladalonf1841382017-06-12 01:16:46 -07005031TEST_F(WebRtcVideoChannelTest, ReportsSsrcGroupsInStats) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005032 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boström259bd202015-05-28 13:39:50 +02005033
5034 static const uint32_t kSenderSsrcs[] = {4, 7, 10};
5035 static const uint32_t kSenderRtxSsrcs[] = {5, 8, 11};
5036
5037 StreamParams sender_sp = cricket::CreateSimWithRtxStreamParams(
5038 "cname", MAKE_VECTOR(kSenderSsrcs), MAKE_VECTOR(kSenderRtxSsrcs));
5039
5040 EXPECT_TRUE(channel_->AddSendStream(sender_sp));
5041
5042 static const uint32_t kReceiverSsrcs[] = {3};
5043 static const uint32_t kReceiverRtxSsrcs[] = {2};
5044
5045 StreamParams receiver_sp = cricket::CreateSimWithRtxStreamParams(
5046 "cname", MAKE_VECTOR(kReceiverSsrcs), MAKE_VECTOR(kReceiverRtxSsrcs));
5047 EXPECT_TRUE(channel_->AddRecvStream(receiver_sp));
5048
5049 cricket::VideoMediaInfo info;
5050 ASSERT_TRUE(channel_->GetStats(&info));
5051
5052 ASSERT_EQ(1u, info.senders.size());
5053 ASSERT_EQ(1u, info.receivers.size());
5054
5055 EXPECT_NE(sender_sp.ssrc_groups, receiver_sp.ssrc_groups);
5056 EXPECT_EQ(sender_sp.ssrc_groups, info.senders[0].ssrc_groups);
5057 EXPECT_EQ(receiver_sp.ssrc_groups, info.receivers[0].ssrc_groups);
5058}
5059
eladalonf1841382017-06-12 01:16:46 -07005060TEST_F(WebRtcVideoChannelTest, MapsReceivedPayloadTypeToCodecName) {
pbosf42376c2015-08-28 07:35:32 -07005061 FakeVideoReceiveStream* stream = AddRecvStream();
5062 webrtc::VideoReceiveStream::Stats stats;
5063 cricket::VideoMediaInfo info;
5064
5065 // Report no codec name before receiving.
5066 stream->SetStats(stats);
5067 ASSERT_TRUE(channel_->GetStats(&info));
5068 EXPECT_STREQ("", info.receivers[0].codec_name.c_str());
5069
5070 // Report VP8 if we're receiving it.
magjed509e4fe2016-11-18 01:34:11 -08005071 stats.current_payload_type = GetEngineCodec("VP8").id;
pbosf42376c2015-08-28 07:35:32 -07005072 stream->SetStats(stats);
5073 ASSERT_TRUE(channel_->GetStats(&info));
5074 EXPECT_STREQ(kVp8CodecName, info.receivers[0].codec_name.c_str());
5075
5076 // Report no codec name for unknown playload types.
5077 stats.current_payload_type = 3;
5078 stream->SetStats(stats);
5079 ASSERT_TRUE(channel_->GetStats(&info));
5080 EXPECT_STREQ("", info.receivers[0].codec_name.c_str());
5081}
5082
Seth Hampson5897a6e2018-04-03 11:16:33 -07005083// Tests that when we add a stream without SSRCs, but contains a stream_id
5084// that it is stored and its stream id is later used when the first packet
5085// arrives to properly create a receive stream with a sync label.
5086TEST_F(WebRtcVideoChannelTest, RecvUnsignaledSsrcWithSignaledStreamId) {
5087 const char kSyncLabel[] = "sync_label";
5088 cricket::StreamParams unsignaled_stream;
5089 unsignaled_stream.set_stream_ids({kSyncLabel});
5090 ASSERT_TRUE(channel_->AddRecvStream(unsignaled_stream));
5091 // The stream shouldn't have been created at this point because it doesn't
5092 // have any SSRCs.
Mirko Bonadeif859e552018-05-30 15:31:29 +02005093 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
Seth Hampson5897a6e2018-04-03 11:16:33 -07005094
5095 // Create and deliver packet.
5096 const size_t kDataLength = 12;
5097 uint8_t data[kDataLength];
5098 memset(data, 0, sizeof(data));
5099 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
5100 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Niels Möllere6933812018-11-05 13:01:41 +01005101 channel_->OnPacketReceived(&packet, /* packet_time_us */ -1);
Seth Hampson5897a6e2018-04-03 11:16:33 -07005102
5103 // The stream should now be created with the appropriate sync label.
5104 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5105 EXPECT_EQ(kSyncLabel,
5106 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group);
5107
5108 // Removing the unsignaled stream should clear the cache. This time when
5109 // a default video receive stream is created it won't have a sync_group.
5110 ASSERT_TRUE(channel_->RemoveRecvStream(0));
5111 ASSERT_TRUE(channel_->RemoveRecvStream(kIncomingUnsignalledSsrc));
5112 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5113
Niels Möllere6933812018-11-05 13:01:41 +01005114 channel_->OnPacketReceived(&packet, /* packet_time_us */ -1);
Seth Hampson5897a6e2018-04-03 11:16:33 -07005115 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5116 EXPECT_TRUE(
5117 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group.empty());
5118}
5119
eladalonf1841382017-06-12 01:16:46 -07005120void WebRtcVideoChannelTest::TestReceiveUnsignaledSsrcPacket(
noahricd10a68e2015-07-10 11:27:55 -07005121 uint8_t payload_type,
5122 bool expect_created_receive_stream) {
magjed509e4fe2016-11-18 01:34:11 -08005123 // kRedRtxPayloadType must currently be unused.
5124 EXPECT_FALSE(FindCodecById(engine_.codecs(), kRedRtxPayloadType));
5125
noahricd10a68e2015-07-10 11:27:55 -07005126 // Add a RED RTX codec.
5127 VideoCodec red_rtx_codec =
magjed509e4fe2016-11-18 01:34:11 -08005128 VideoCodec::CreateRtxCodec(kRedRtxPayloadType, GetEngineCodec("red").id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005129 recv_parameters_.codecs.push_back(red_rtx_codec);
5130 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
noahricd10a68e2015-07-10 11:27:55 -07005131
5132 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5133 const size_t kDataLength = 12;
5134 uint8_t data[kDataLength];
5135 memset(data, 0, sizeof(data));
5136
5137 rtc::Set8(data, 1, payload_type);
5138 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
jbaucheec21bd2016-03-20 06:15:43 -07005139 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Niels Möllere6933812018-11-05 13:01:41 +01005140 channel_->OnPacketReceived(&packet, /* packet_time_us */ -1);
noahricd10a68e2015-07-10 11:27:55 -07005141
5142 if (expect_created_receive_stream) {
5143 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
5144 << "Should have created a receive stream for payload type: "
5145 << payload_type;
5146 } else {
5147 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size())
5148 << "Shouldn't have created a receive stream for payload type: "
5149 << payload_type;
5150 }
5151}
5152
Åsa Persson2c7149b2018-10-15 09:36:10 +02005153class WebRtcVideoChannelDiscardUnknownSsrcTest : public WebRtcVideoChannelTest {
5154 public:
5155 WebRtcVideoChannelDiscardUnknownSsrcTest()
5156 : WebRtcVideoChannelTest(
5157 "WebRTC-Video-DiscardPacketsWithUnknownSsrc/Enabled/") {}
5158};
5159
5160TEST_F(WebRtcVideoChannelDiscardUnknownSsrcTest, NoUnsignalledStreamCreated) {
5161 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP8").id,
5162 false /* expect_created_receive_stream */);
5163}
5164
eladalonf1841382017-06-12 01:16:46 -07005165TEST_F(WebRtcVideoChannelTest, Vp8PacketCreatesUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005166 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP8").id,
5167 true /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005168}
5169
eladalonf1841382017-06-12 01:16:46 -07005170TEST_F(WebRtcVideoChannelTest, Vp9PacketCreatesUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005171 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP9").id,
5172 true /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005173}
5174
eladalonf1841382017-06-12 01:16:46 -07005175TEST_F(WebRtcVideoChannelTest, RtxPacketDoesntCreateUnsignalledStream) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02005176 AssignDefaultAptRtxTypes();
magjed509e4fe2016-11-18 01:34:11 -08005177 const cricket::VideoCodec vp8 = GetEngineCodec("VP8");
5178 const int rtx_vp8_payload_type = default_apt_rtx_types_[vp8.id];
5179 TestReceiveUnsignaledSsrcPacket(rtx_vp8_payload_type,
5180 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005181}
5182
eladalonf1841382017-06-12 01:16:46 -07005183TEST_F(WebRtcVideoChannelTest, UlpfecPacketDoesntCreateUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005184 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("ulpfec").id,
5185 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005186}
5187
eladalonf1841382017-06-12 01:16:46 -07005188TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr468da7c2016-11-22 02:16:47 -08005189 FlexfecPacketDoesntCreateUnsignalledStream) {
5190 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("flexfec-03").id,
5191 false /* expect_created_receive_stream */);
5192}
5193
eladalonf1841382017-06-12 01:16:46 -07005194TEST_F(WebRtcVideoChannelTest, RedRtxPacketDoesntCreateUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005195 TestReceiveUnsignaledSsrcPacket(kRedRtxPayloadType,
5196 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005197}
5198
mzanaty8a855d62017-02-17 15:46:43 -08005199// Test that receiving any unsignalled SSRC works even if it changes.
5200// The first unsignalled SSRC received will create a default receive stream.
5201// Any different unsignalled SSRC received will replace the default.
eladalonf1841382017-06-12 01:16:46 -07005202TEST_F(WebRtcVideoChannelTest, ReceiveDifferentUnsignaledSsrc) {
mzanaty8a855d62017-02-17 15:46:43 -08005203 // Allow receiving VP8, VP9, H264 (if enabled).
5204 cricket::VideoRecvParameters parameters;
5205 parameters.codecs.push_back(GetEngineCodec("VP8"));
5206 parameters.codecs.push_back(GetEngineCodec("VP9"));
5207
5208#if defined(WEBRTC_USE_H264)
5209 cricket::VideoCodec H264codec(126, "H264");
5210 parameters.codecs.push_back(H264codec);
5211#endif
5212
5213 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
5214 // No receive streams yet.
5215 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5216 cricket::FakeVideoRenderer renderer;
5217 EXPECT_TRUE(channel_->SetSink(kDefaultRecvSsrc, &renderer));
5218
5219 // Receive VP8 packet on first SSRC.
5220 uint8_t data[kMinRtpPacketLen];
5221 cricket::RtpHeader rtpHeader;
5222 rtpHeader.payload_type = GetEngineCodec("VP8").id;
5223 rtpHeader.seq_num = rtpHeader.timestamp = 0;
Yves Gerey665174f2018-06-19 15:03:05 +02005224 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 1;
mzanaty8a855d62017-02-17 15:46:43 -08005225 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5226 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
Niels Möllere6933812018-11-05 13:01:41 +01005227 channel_->OnPacketReceived(&packet, /* packet_time_us */ -1);
mzanaty8a855d62017-02-17 15:46:43 -08005228 // VP8 packet should create default receive stream.
5229 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
Yves Gerey665174f2018-06-19 15:03:05 +02005230 FakeVideoReceiveStream* recv_stream = fake_call_->GetVideoReceiveStreams()[0];
mzanaty8a855d62017-02-17 15:46:43 -08005231 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5232 // Verify that the receive stream sinks to a renderer.
Artem Titov1ebfb6a2019-01-03 23:49:37 +01005233 webrtc::VideoFrame video_frame =
5234 webrtc::VideoFrame::Builder()
5235 .set_video_frame_buffer(CreateBlackFrameBuffer(4, 4))
5236 .set_timestamp_rtp(100)
5237 .set_timestamp_us(0)
5238 .set_rotation(webrtc::kVideoRotation_0)
5239 .build();
mzanaty8a855d62017-02-17 15:46:43 -08005240 recv_stream->InjectFrame(video_frame);
5241 EXPECT_EQ(1, renderer.num_rendered_frames());
5242
5243 // Receive VP9 packet on second SSRC.
5244 rtpHeader.payload_type = GetEngineCodec("VP9").id;
Yves Gerey665174f2018-06-19 15:03:05 +02005245 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 2;
mzanaty8a855d62017-02-17 15:46:43 -08005246 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5247 rtc::CopyOnWriteBuffer packet2(data, sizeof(data));
Niels Möllere6933812018-11-05 13:01:41 +01005248 channel_->OnPacketReceived(&packet2, /* packet_time_us */ -1);
mzanaty8a855d62017-02-17 15:46:43 -08005249 // VP9 packet should replace the default receive SSRC.
5250 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5251 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
5252 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5253 // Verify that the receive stream sinks to a renderer.
Artem Titov1ebfb6a2019-01-03 23:49:37 +01005254 webrtc::VideoFrame video_frame2 =
5255 webrtc::VideoFrame::Builder()
5256 .set_video_frame_buffer(CreateBlackFrameBuffer(4, 4))
5257 .set_timestamp_rtp(200)
5258 .set_timestamp_us(0)
5259 .set_rotation(webrtc::kVideoRotation_0)
5260 .build();
mzanaty8a855d62017-02-17 15:46:43 -08005261 recv_stream->InjectFrame(video_frame2);
5262 EXPECT_EQ(2, renderer.num_rendered_frames());
5263
5264#if defined(WEBRTC_USE_H264)
5265 // Receive H264 packet on third SSRC.
5266 rtpHeader.payload_type = 126;
Yves Gerey665174f2018-06-19 15:03:05 +02005267 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 3;
mzanaty8a855d62017-02-17 15:46:43 -08005268 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5269 rtc::CopyOnWriteBuffer packet3(data, sizeof(data));
Niels Möllere6933812018-11-05 13:01:41 +01005270 channel_->OnPacketReceived(&packet3, /* packet_time_us */ -1);
mzanaty8a855d62017-02-17 15:46:43 -08005271 // H264 packet should replace the default receive SSRC.
5272 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5273 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
5274 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5275 // Verify that the receive stream sinks to a renderer.
Artem Titov1ebfb6a2019-01-03 23:49:37 +01005276 webrtc::VideoFrame video_frame3 =
5277 webrtc::VideoFrame::Builder()
5278 .set_video_frame_buffer(CreateBlackFrameBuffer(4, 4))
5279 .set_timestamp_rtp(300)
5280 .set_timestamp_us(0)
5281 .set_rotation(webrtc::kVideoRotation_0)
5282 .build();
mzanaty8a855d62017-02-17 15:46:43 -08005283 recv_stream->InjectFrame(video_frame3);
5284 EXPECT_EQ(3, renderer.num_rendered_frames());
5285#endif
5286}
5287
brandtr0dc57ea2017-05-29 23:33:31 -07005288// This test verifies that when a new default stream is created for a new
5289// unsignaled SSRC, the new stream does not overwrite any old stream that had
5290// been the default receive stream before being properly signaled.
eladalonf1841382017-06-12 01:16:46 -07005291TEST_F(WebRtcVideoChannelTest,
brandtr0dc57ea2017-05-29 23:33:31 -07005292 NewUnsignaledStreamDoesNotDestroyPreviouslyUnsignaledStream) {
5293 cricket::VideoRecvParameters parameters;
5294 parameters.codecs.push_back(GetEngineCodec("VP8"));
5295 ASSERT_TRUE(channel_->SetRecvParameters(parameters));
5296
5297 // No streams signaled and no packets received, so we should not have any
5298 // stream objects created yet.
5299 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5300
5301 // Receive packet on an unsignaled SSRC.
5302 uint8_t data[kMinRtpPacketLen];
5303 cricket::RtpHeader rtp_header;
5304 rtp_header.payload_type = GetEngineCodec("VP8").id;
5305 rtp_header.seq_num = rtp_header.timestamp = 0;
5306 rtp_header.ssrc = kSsrcs3[0];
5307 cricket::SetRtpHeader(data, sizeof(data), rtp_header);
5308 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
Niels Möllere6933812018-11-05 13:01:41 +01005309 channel_->OnPacketReceived(&packet, /* packet_time_us */ -1);
brandtr0dc57ea2017-05-29 23:33:31 -07005310 // Default receive stream should be created.
5311 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5312 FakeVideoReceiveStream* recv_stream0 =
5313 fake_call_->GetVideoReceiveStreams()[0];
5314 EXPECT_EQ(kSsrcs3[0], recv_stream0->GetConfig().rtp.remote_ssrc);
5315
5316 // Signal the SSRC.
5317 EXPECT_TRUE(
5318 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrcs3[0])));
5319 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5320 recv_stream0 = fake_call_->GetVideoReceiveStreams()[0];
5321 EXPECT_EQ(kSsrcs3[0], recv_stream0->GetConfig().rtp.remote_ssrc);
5322
5323 // Receive packet on a different unsignaled SSRC.
5324 rtp_header.ssrc = kSsrcs3[1];
5325 cricket::SetRtpHeader(data, sizeof(data), rtp_header);
5326 packet.SetData(data, sizeof(data));
Niels Möllere6933812018-11-05 13:01:41 +01005327 channel_->OnPacketReceived(&packet, /* packet_time_us */ -1);
brandtr0dc57ea2017-05-29 23:33:31 -07005328 // New default receive stream should be created, but old stream should remain.
5329 ASSERT_EQ(2u, fake_call_->GetVideoReceiveStreams().size());
5330 EXPECT_EQ(recv_stream0, fake_call_->GetVideoReceiveStreams()[0]);
5331 FakeVideoReceiveStream* recv_stream1 =
5332 fake_call_->GetVideoReceiveStreams()[1];
5333 EXPECT_EQ(kSsrcs3[1], recv_stream1->GetConfig().rtp.remote_ssrc);
5334}
5335
Seth Hampson7c682e02018-05-04 16:28:15 -07005336TEST_F(WebRtcVideoChannelTest, CanSetMaxBitrateForExistingStream) {
skvladdc1c62c2016-03-16 19:07:43 -07005337 AddSendStream();
5338
Niels Mollera882fb32019-01-21 08:44:37 +00005339 FakeVideoCapturerWithTaskQueue capturer;
5340 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
5341 cricket::VideoFormat capture_format_hd =
5342 capturer.GetSupportedFormats()->front();
5343 EXPECT_EQ(1280, capture_format_hd.width);
5344 EXPECT_EQ(720, capture_format_hd.height);
5345 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format_hd));
skvladdc1c62c2016-03-16 19:07:43 -07005346 EXPECT_TRUE(channel_->SetSend(true));
Niels Mollera882fb32019-01-21 08:44:37 +00005347 capturer.CaptureFrame();
skvladdc1c62c2016-03-16 19:07:43 -07005348
perkjfa10b552016-10-02 23:45:26 -07005349 int default_encoder_bitrate = GetMaxEncoderBitrate();
brandtr468da7c2016-11-22 02:16:47 -08005350 EXPECT_GT(default_encoder_bitrate, 1000);
skvladdc1c62c2016-03-16 19:07:43 -07005351
5352 // TODO(skvlad): Resolve the inconsistency between the interpretation
5353 // of the global bitrate limit for audio and video:
5354 // - Audio: max_bandwidth_bps = 0 - fail the operation,
5355 // max_bandwidth_bps = -1 - remove the bandwidth limit
5356 // - Video: max_bandwidth_bps = 0 - remove the bandwidth limit,
pbos5c7760a2017-03-10 11:23:12 -08005357 // max_bandwidth_bps = -1 - remove the bandwidth limit
skvladdc1c62c2016-03-16 19:07:43 -07005358
perkjfa10b552016-10-02 23:45:26 -07005359 SetAndExpectMaxBitrate(1000, 0, 1000);
5360 SetAndExpectMaxBitrate(1000, 800, 800);
5361 SetAndExpectMaxBitrate(600, 800, 600);
5362 SetAndExpectMaxBitrate(0, 800, 800);
5363 SetAndExpectMaxBitrate(0, 0, default_encoder_bitrate);
skvladdc1c62c2016-03-16 19:07:43 -07005364
Niels Möllerff40b142018-04-09 08:49:14 +02005365 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
skvladdc1c62c2016-03-16 19:07:43 -07005366}
5367
eladalonf1841382017-06-12 01:16:46 -07005368TEST_F(WebRtcVideoChannelTest, CannotSetMaxBitrateForNonexistentStream) {
skvladdc1c62c2016-03-16 19:07:43 -07005369 webrtc::RtpParameters nonexistent_parameters =
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005370 channel_->GetRtpSendParameters(last_ssrc_);
Mirko Bonadeif859e552018-05-30 15:31:29 +02005371 EXPECT_EQ(0u, nonexistent_parameters.encodings.size());
skvladdc1c62c2016-03-16 19:07:43 -07005372
5373 nonexistent_parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005374 EXPECT_FALSE(
Zach Steinba37b4b2018-01-23 15:02:36 -08005375 channel_->SetRtpSendParameters(last_ssrc_, nonexistent_parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07005376}
5377
eladalonf1841382017-06-12 01:16:46 -07005378TEST_F(WebRtcVideoChannelTest,
Seth Hampson7c682e02018-05-04 16:28:15 -07005379 SetLowMaxBitrateOverwritesVideoStreamMinBitrate) {
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005380 FakeVideoSendStream* stream = AddSendStream();
5381
Seth Hampson7c682e02018-05-04 16:28:15 -07005382 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5383 EXPECT_EQ(1UL, parameters.encodings.size());
5384 EXPECT_FALSE(parameters.encodings[0].max_bitrate_bps.has_value());
5385 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5386
5387 // Note that this is testing the behavior of the FakeVideoSendStream, which
5388 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5389 // we are just testing the behavior of
5390 // EncoderStreamFactory::CreateEncoderStreams.
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005391 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5392 EXPECT_EQ(kMinVideoBitrateBps, stream->GetVideoStreams()[0].min_bitrate_bps);
Seth Hampson7c682e02018-05-04 16:28:15 -07005393
5394 // Set a low max bitrate & check that VideoStream.min_bitrate_bps is limited
5395 // by this amount.
5396 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5397 int low_max_bitrate_bps = kMinVideoBitrateBps - 1000;
5398 parameters.encodings[0].max_bitrate_bps = low_max_bitrate_bps;
5399 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5400
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005401 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5402 EXPECT_EQ(low_max_bitrate_bps, stream->GetVideoStreams()[0].min_bitrate_bps);
5403 EXPECT_EQ(low_max_bitrate_bps, stream->GetVideoStreams()[0].max_bitrate_bps);
5404}
5405
5406TEST_F(WebRtcVideoChannelTest,
5407 SetHighMinBitrateOverwritesVideoStreamMaxBitrate) {
5408 FakeVideoSendStream* stream = AddSendStream();
5409
5410 // Note that this is testing the behavior of the FakeVideoSendStream, which
5411 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5412 // we are just testing the behavior of
5413 // EncoderStreamFactory::CreateEncoderStreams.
5414 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5415 int high_min_bitrate_bps = stream->GetVideoStreams()[0].max_bitrate_bps + 1;
5416
5417 // Set a high min bitrate and check that max_bitrate_bps is adjusted up.
5418 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5419 EXPECT_EQ(1UL, parameters.encodings.size());
5420 parameters.encodings[0].min_bitrate_bps = high_min_bitrate_bps;
5421 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5422
5423 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5424 EXPECT_EQ(high_min_bitrate_bps, stream->GetVideoStreams()[0].min_bitrate_bps);
5425 EXPECT_EQ(high_min_bitrate_bps, stream->GetVideoStreams()[0].max_bitrate_bps);
5426}
5427
5428TEST_F(WebRtcVideoChannelTest,
5429 SetMinBitrateAboveMaxBitrateLimitAdjustsMinBitrateDown) {
5430 send_parameters_.max_bandwidth_bps = 99999;
5431 FakeVideoSendStream* stream = AddSendStream();
5432 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
5433 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
5434 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5435 EXPECT_EQ(kMinVideoBitrateBps, stream->GetVideoStreams()[0].min_bitrate_bps);
5436 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5437 stream->GetVideoStreams()[0].max_bitrate_bps);
5438
5439 // Set min bitrate above global max bitrate and check that min_bitrate_bps is
5440 // adjusted down.
5441 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5442 EXPECT_EQ(1UL, parameters.encodings.size());
5443 parameters.encodings[0].min_bitrate_bps = 99999 + 1;
5444 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5445 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5446 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5447 stream->GetVideoStreams()[0].min_bitrate_bps);
5448 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5449 stream->GetVideoStreams()[0].max_bitrate_bps);
Seth Hampson7c682e02018-05-04 16:28:15 -07005450}
5451
Åsa Persson8c1bf952018-09-13 10:42:19 +02005452TEST_F(WebRtcVideoChannelTest, SetMaxFramerateOneStream) {
5453 FakeVideoSendStream* stream = AddSendStream();
5454
5455 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5456 EXPECT_EQ(1UL, parameters.encodings.size());
5457 EXPECT_FALSE(parameters.encodings[0].max_framerate.has_value());
5458 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5459
5460 // Note that this is testing the behavior of the FakeVideoSendStream, which
5461 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5462 // we are just testing the behavior of
5463 // EncoderStreamFactory::CreateEncoderStreams.
5464 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5465 EXPECT_EQ(kDefaultVideoMaxFramerate,
5466 stream->GetVideoStreams()[0].max_framerate);
5467
5468 // Set max framerate and check that VideoStream.max_framerate is set.
5469 const int kNewMaxFramerate = kDefaultVideoMaxFramerate - 1;
5470 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5471 parameters.encodings[0].max_framerate = kNewMaxFramerate;
5472 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5473
5474 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5475 EXPECT_EQ(kNewMaxFramerate, stream->GetVideoStreams()[0].max_framerate);
5476}
5477
Åsa Persson23eba222018-10-02 14:47:06 +02005478TEST_F(WebRtcVideoChannelTest, SetNumTemporalLayersForSingleStream) {
5479 FakeVideoSendStream* stream = AddSendStream();
5480
5481 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5482 EXPECT_EQ(1UL, parameters.encodings.size());
5483 EXPECT_FALSE(parameters.encodings[0].num_temporal_layers.has_value());
5484 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5485
5486 // Note that this is testing the behavior of the FakeVideoSendStream, which
5487 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5488 // we are just testing the behavior of
5489 // EncoderStreamFactory::CreateEncoderStreams.
5490 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5491 EXPECT_FALSE(stream->GetVideoStreams()[0].num_temporal_layers.has_value());
5492
5493 // Set temporal layers and check that VideoStream.num_temporal_layers is set.
5494 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5495 parameters.encodings[0].num_temporal_layers = 2;
5496 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5497
5498 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5499 EXPECT_EQ(2UL, stream->GetVideoStreams()[0].num_temporal_layers);
5500}
5501
Seth Hampson7c682e02018-05-04 16:28:15 -07005502TEST_F(WebRtcVideoChannelTest,
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005503 CannotSetRtpSendParametersWithIncorrectNumberOfEncodings) {
skvladdc1c62c2016-03-16 19:07:43 -07005504 AddSendStream();
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005505 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07005506 // Two or more encodings should result in failure.
5507 parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Zach Steinba37b4b2018-01-23 15:02:36 -08005508 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeeffb2aced2017-01-06 23:05:37 -08005509 // Zero encodings should also fail.
5510 parameters.encodings.clear();
Zach Steinba37b4b2018-01-23 15:02:36 -08005511 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeeffb2aced2017-01-06 23:05:37 -08005512}
5513
Zach Stein3ca452b2018-01-18 10:01:24 -08005514TEST_F(WebRtcVideoChannelTest,
5515 CannotSetSimulcastRtpSendParametersWithIncorrectNumberOfEncodings) {
5516 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
5517 StreamParams sp = CreateSimStreamParams("cname", ssrcs);
5518 AddSendStream(sp);
5519
5520 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5521
5522 // Additional encodings should result in failure.
5523 parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Zach Steinba37b4b2018-01-23 15:02:36 -08005524 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Zach Stein3ca452b2018-01-18 10:01:24 -08005525 // Zero encodings should also fail.
5526 parameters.encodings.clear();
Zach Steinba37b4b2018-01-23 15:02:36 -08005527 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Zach Stein3ca452b2018-01-18 10:01:24 -08005528}
5529
deadbeeffb2aced2017-01-06 23:05:37 -08005530// Changing the SSRC through RtpParameters is not allowed.
eladalonf1841382017-06-12 01:16:46 -07005531TEST_F(WebRtcVideoChannelTest, CannotSetSsrcInRtpSendParameters) {
deadbeeffb2aced2017-01-06 23:05:37 -08005532 AddSendStream();
5533 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
Oskar Sundbom78807582017-11-16 11:09:55 +01005534 parameters.encodings[0].ssrc = 0xdeadbeef;
Zach Steinba37b4b2018-01-23 15:02:36 -08005535 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07005536}
5537
Seth Hampson24722b32017-12-22 09:36:42 -08005538// Tests that when RTCRtpEncodingParameters.bitrate_priority gets set to
5539// a value <= 0, setting the parameters returns false.
5540TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersInvalidBitratePriority) {
5541 AddSendStream();
5542 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5543 EXPECT_EQ(1UL, parameters.encodings.size());
5544 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5545 parameters.encodings[0].bitrate_priority);
5546
5547 parameters.encodings[0].bitrate_priority = 0;
Zach Steinba37b4b2018-01-23 15:02:36 -08005548 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005549 parameters.encodings[0].bitrate_priority = -2;
Zach Steinba37b4b2018-01-23 15:02:36 -08005550 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005551}
5552
5553// Tests when the the RTCRtpEncodingParameters.bitrate_priority gets set
5554// properly on the VideoChannel and propogates down to the video encoder.
5555TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersPriorityOneStream) {
5556 AddSendStream();
5557 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5558 EXPECT_EQ(1UL, parameters.encodings.size());
5559 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5560 parameters.encodings[0].bitrate_priority);
5561
5562 // Change the value and set it on the VideoChannel.
5563 double new_bitrate_priority = 2.0;
5564 parameters.encodings[0].bitrate_priority = new_bitrate_priority;
Zach Steinba37b4b2018-01-23 15:02:36 -08005565 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005566
5567 // Verify that the encoding parameters bitrate_priority is set for the
5568 // VideoChannel.
5569 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5570 EXPECT_EQ(1UL, parameters.encodings.size());
5571 EXPECT_EQ(new_bitrate_priority, parameters.encodings[0].bitrate_priority);
5572
5573 // Verify that the new value propagated down to the encoder.
5574 std::vector<FakeVideoSendStream*> video_send_streams =
5575 fake_call_->GetVideoSendStreams();
5576 EXPECT_EQ(1UL, video_send_streams.size());
5577 FakeVideoSendStream* video_send_stream = video_send_streams.front();
5578 // Check that the WebRtcVideoSendStream updated the VideoEncoderConfig
5579 // appropriately.
5580 EXPECT_EQ(new_bitrate_priority,
5581 video_send_stream->GetEncoderConfig().bitrate_priority);
5582 // Check that the vector of VideoStreams also was propagated correctly. Note
5583 // that this is testing the behavior of the FakeVideoSendStream, which mimics
5584 // the calls to CreateEncoderStreams to get the VideoStreams.
Danil Chapovalov00c71832018-06-15 15:58:38 +02005585 EXPECT_EQ(absl::optional<double>(new_bitrate_priority),
Seth Hampson24722b32017-12-22 09:36:42 -08005586 video_send_stream->GetVideoStreams()[0].bitrate_priority);
5587}
5588
5589// Tests that the RTCRtpEncodingParameters.bitrate_priority is set for the
5590// VideoChannel and the value propogates to the video encoder with all simulcast
5591// streams.
5592TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersPrioritySimulcastStreams) {
5593 // Create the stream params with multiple ssrcs for simulcast.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005594 const size_t kNumSimulcastStreams = 3;
Seth Hampson24722b32017-12-22 09:36:42 -08005595 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
5596 StreamParams stream_params = CreateSimStreamParams("cname", ssrcs);
5597 AddSendStream(stream_params);
5598 uint32_t primary_ssrc = stream_params.first_ssrc();
5599
Niels Mollera882fb32019-01-21 08:44:37 +00005600 // Using the FakeVideoCapturerWithTaskQueue, we manually send a full size
Tommi85959932018-02-07 19:26:06 +01005601 // frame. This creates multiple VideoStreams for all simulcast layers when
5602 // reconfiguring, and allows us to test this behavior.
Niels Mollera882fb32019-01-21 08:44:37 +00005603 FakeVideoCapturerWithTaskQueue capturer;
Seth Hampson24722b32017-12-22 09:36:42 -08005604 VideoOptions options;
Niels Mollera882fb32019-01-21 08:44:37 +00005605 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, &options, &capturer));
5606 EXPECT_EQ(cricket::CS_RUNNING,
5607 capturer.Start(cricket::VideoFormat(
5608 1920, 1080, cricket::VideoFormat::FpsToInterval(30),
5609 cricket::FOURCC_I420)));
Seth Hampson24722b32017-12-22 09:36:42 -08005610 channel_->SetSend(true);
Niels Mollera882fb32019-01-21 08:44:37 +00005611 EXPECT_TRUE(capturer.CaptureFrame());
Seth Hampson24722b32017-12-22 09:36:42 -08005612 // Get and set the rtp encoding parameters.
5613 webrtc::RtpParameters parameters =
5614 channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02005615 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson24722b32017-12-22 09:36:42 -08005616 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5617 parameters.encodings[0].bitrate_priority);
5618 // Change the value and set it on the VideoChannel.
5619 double new_bitrate_priority = 2.0;
5620 parameters.encodings[0].bitrate_priority = new_bitrate_priority;
Zach Steinba37b4b2018-01-23 15:02:36 -08005621 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005622
5623 // Verify that the encoding parameters priority is set on the VideoChannel.
5624 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02005625 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson24722b32017-12-22 09:36:42 -08005626 EXPECT_EQ(new_bitrate_priority, parameters.encodings[0].bitrate_priority);
5627
5628 // Verify that the new value propagated down to the encoder.
5629 std::vector<FakeVideoSendStream*> video_send_streams =
5630 fake_call_->GetVideoSendStreams();
5631 EXPECT_EQ(1UL, video_send_streams.size());
5632 FakeVideoSendStream* video_send_stream = video_send_streams.front();
5633 // Check that the WebRtcVideoSendStream updated the VideoEncoderConfig
5634 // appropriately.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005635 EXPECT_EQ(kNumSimulcastStreams,
Seth Hampson24722b32017-12-22 09:36:42 -08005636 video_send_stream->GetEncoderConfig().number_of_streams);
5637 EXPECT_EQ(new_bitrate_priority,
5638 video_send_stream->GetEncoderConfig().bitrate_priority);
5639 // Check that the vector of VideoStreams also propagated correctly. The
5640 // FakeVideoSendStream calls CreateEncoderStreams, and we are testing that
5641 // these are created appropriately for the simulcast case.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005642 EXPECT_EQ(kNumSimulcastStreams, video_send_stream->GetVideoStreams().size());
Danil Chapovalov00c71832018-06-15 15:58:38 +02005643 EXPECT_EQ(absl::optional<double>(new_bitrate_priority),
Seth Hampson24722b32017-12-22 09:36:42 -08005644 video_send_stream->GetVideoStreams()[0].bitrate_priority);
5645 // Since we are only setting bitrate priority per-sender, the other
5646 // VideoStreams should have a bitrate priority of 0.
Danil Chapovalov00c71832018-06-15 15:58:38 +02005647 EXPECT_EQ(absl::nullopt,
Seth Hampson24722b32017-12-22 09:36:42 -08005648 video_send_stream->GetVideoStreams()[1].bitrate_priority);
Danil Chapovalov00c71832018-06-15 15:58:38 +02005649 EXPECT_EQ(absl::nullopt,
Seth Hampson24722b32017-12-22 09:36:42 -08005650 video_send_stream->GetVideoStreams()[2].bitrate_priority);
Niels Möllerff40b142018-04-09 08:49:14 +02005651 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, nullptr, nullptr));
Seth Hampson24722b32017-12-22 09:36:42 -08005652}
5653
Tim Haloun648d28a2018-10-18 16:52:22 -07005654// RTCRtpEncodingParameters.network_priority must be one of a few values
5655// derived from the default priority, corresponding to very-low, low, medium,
5656// or high.
5657TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersInvalidNetworkPriority) {
5658 AddSendStream();
5659 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5660 EXPECT_EQ(1UL, parameters.encodings.size());
5661 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5662 parameters.encodings[0].network_priority);
5663
5664 double good_values[] = {0.5, 1.0, 2.0, 4.0};
5665 double bad_values[] = {-1.0, 0.0, 0.49, 0.51, 1.1, 3.99, 4.1, 5.0};
5666 for (auto it : good_values) {
5667 parameters.encodings[0].network_priority = it;
5668 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5669 }
5670 for (auto it : bad_values) {
5671 parameters.encodings[0].network_priority = it;
5672 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5673 }
5674}
5675
Åsa Persson8c1bf952018-09-13 10:42:19 +02005676TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersMaxFramerate) {
5677 const size_t kNumSimulcastStreams = 3;
5678 SetUpSimulcast(true, false);
5679
5680 // Get and set the rtp encoding parameters.
5681 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5682 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5683 for (const auto& encoding : parameters.encodings) {
5684 EXPECT_FALSE(encoding.max_framerate);
5685 }
5686
5687 // Change the value and set it on the VideoChannel.
5688 parameters.encodings[0].max_framerate = 10;
5689 parameters.encodings[1].max_framerate = 20;
5690 parameters.encodings[2].max_framerate = 25;
5691 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5692
5693 // Verify that the bitrates are set on the VideoChannel.
5694 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5695 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5696 EXPECT_EQ(10, parameters.encodings[0].max_framerate);
5697 EXPECT_EQ(20, parameters.encodings[1].max_framerate);
5698 EXPECT_EQ(25, parameters.encodings[2].max_framerate);
5699}
5700
Åsa Persson23eba222018-10-02 14:47:06 +02005701TEST_F(WebRtcVideoChannelTest,
5702 SetRtpSendParametersNumTemporalLayersFailsForInvalidRange) {
5703 const size_t kNumSimulcastStreams = 3;
5704 SetUpSimulcast(true, false);
5705
5706 // Get and set the rtp encoding parameters.
5707 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5708 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5709
5710 // Num temporal layers should be in the range [1, kMaxTemporalStreams].
5711 parameters.encodings[0].num_temporal_layers = 0;
5712 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
5713 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
5714 parameters.encodings[0].num_temporal_layers = webrtc::kMaxTemporalStreams + 1;
5715 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
5716 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
5717}
5718
5719TEST_F(WebRtcVideoChannelTest,
5720 SetRtpSendParametersNumTemporalLayersFailsForInvalidModification) {
5721 const size_t kNumSimulcastStreams = 3;
5722 SetUpSimulcast(true, false);
5723
5724 // Get and set the rtp encoding parameters.
5725 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5726 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5727
5728 // No/all layers should be set.
5729 parameters.encodings[0].num_temporal_layers = 1;
5730 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION,
5731 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
5732
5733 // Different values not supported.
5734 parameters.encodings[0].num_temporal_layers = 1;
5735 parameters.encodings[1].num_temporal_layers = 2;
5736 parameters.encodings[2].num_temporal_layers = 2;
5737 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION,
5738 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
5739}
5740
5741TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersNumTemporalLayers) {
5742 const size_t kNumSimulcastStreams = 3;
5743 SetUpSimulcast(true, false);
5744
5745 // Get and set the rtp encoding parameters.
5746 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5747 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5748 for (const auto& encoding : parameters.encodings)
5749 EXPECT_FALSE(encoding.num_temporal_layers);
5750
5751 // Change the value and set it on the VideoChannel.
5752 parameters.encodings[0].num_temporal_layers = 3;
5753 parameters.encodings[1].num_temporal_layers = 3;
5754 parameters.encodings[2].num_temporal_layers = 3;
5755 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5756
5757 // Verify that the number of temporal layers are set on the VideoChannel.
5758 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5759 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5760 EXPECT_EQ(3, parameters.encodings[0].num_temporal_layers);
5761 EXPECT_EQ(3, parameters.encodings[1].num_temporal_layers);
5762 EXPECT_EQ(3, parameters.encodings[2].num_temporal_layers);
5763}
5764
5765TEST_F(WebRtcVideoChannelTest, NumTemporalLayersPropagatedToEncoder) {
5766 const size_t kNumSimulcastStreams = 3;
5767 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5768
5769 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Mollera882fb32019-01-21 08:44:37 +00005770 FakeVideoCapturerWithTaskQueue capturer;
Åsa Persson23eba222018-10-02 14:47:06 +02005771 VideoOptions options;
Niels Mollera882fb32019-01-21 08:44:37 +00005772 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
5773 EXPECT_EQ(cricket::CS_RUNNING,
5774 capturer.Start(capturer.GetSupportedFormats()->front()));
Åsa Persson23eba222018-10-02 14:47:06 +02005775 channel_->SetSend(true);
Niels Mollera882fb32019-01-21 08:44:37 +00005776 EXPECT_TRUE(capturer.CaptureFrame());
Åsa Persson23eba222018-10-02 14:47:06 +02005777
5778 // Get and set the rtp encoding parameters.
5779 // Change the value and set it on the VideoChannel.
5780 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5781 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5782 parameters.encodings[0].num_temporal_layers = 2;
5783 parameters.encodings[1].num_temporal_layers = 2;
5784 parameters.encodings[2].num_temporal_layers = 2;
5785 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5786
5787 // Verify that the new value is propagated down to the encoder.
5788 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
5789 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
5790 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
5791 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
5792 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
5793 EXPECT_EQ(2UL, encoder_config.simulcast_layers[0].num_temporal_layers);
5794 EXPECT_EQ(2UL, encoder_config.simulcast_layers[1].num_temporal_layers);
5795 EXPECT_EQ(2UL, encoder_config.simulcast_layers[2].num_temporal_layers);
5796
5797 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
5798 // VideoStreams are created appropriately for the simulcast case.
5799 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5800 EXPECT_EQ(2UL, stream->GetVideoStreams()[0].num_temporal_layers);
5801 EXPECT_EQ(2UL, stream->GetVideoStreams()[1].num_temporal_layers);
5802 EXPECT_EQ(2UL, stream->GetVideoStreams()[2].num_temporal_layers);
5803
5804 // No parameter changed, encoder should not be reconfigured.
5805 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5806 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
5807
5808 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5809}
5810
5811TEST_F(WebRtcVideoChannelTest,
5812 DefaultValuePropagatedToEncoderForUnsetNumTemporalLayers) {
5813 const size_t kDefaultNumTemporalLayers = 3;
5814 const size_t kNumSimulcastStreams = 3;
5815 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5816
5817 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Mollera882fb32019-01-21 08:44:37 +00005818 FakeVideoCapturerWithTaskQueue capturer;
Åsa Persson23eba222018-10-02 14:47:06 +02005819 VideoOptions options;
Niels Mollera882fb32019-01-21 08:44:37 +00005820 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
5821 EXPECT_EQ(cricket::CS_RUNNING,
5822 capturer.Start(capturer.GetSupportedFormats()->front()));
Åsa Persson23eba222018-10-02 14:47:06 +02005823 channel_->SetSend(true);
Niels Mollera882fb32019-01-21 08:44:37 +00005824 EXPECT_TRUE(capturer.CaptureFrame());
Åsa Persson23eba222018-10-02 14:47:06 +02005825
5826 // Change rtp encoding parameters, num_temporal_layers not changed.
5827 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5828 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5829 parameters.encodings[0].min_bitrate_bps = 33000;
5830 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5831
5832 // Verify that no value is propagated down to the encoder.
5833 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
5834 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
5835 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
5836 EXPECT_FALSE(encoder_config.simulcast_layers[0].num_temporal_layers);
5837 EXPECT_FALSE(encoder_config.simulcast_layers[1].num_temporal_layers);
5838 EXPECT_FALSE(encoder_config.simulcast_layers[2].num_temporal_layers);
5839
5840 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
5841 // VideoStreams are created appropriately for the simulcast case.
5842 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5843 EXPECT_EQ(kDefaultNumTemporalLayers,
5844 stream->GetVideoStreams()[0].num_temporal_layers);
5845 EXPECT_EQ(kDefaultNumTemporalLayers,
5846 stream->GetVideoStreams()[1].num_temporal_layers);
5847 EXPECT_EQ(kDefaultNumTemporalLayers,
5848 stream->GetVideoStreams()[2].num_temporal_layers);
5849
5850 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5851}
5852
Åsa Persson8c1bf952018-09-13 10:42:19 +02005853TEST_F(WebRtcVideoChannelTest, MaxSimulcastFrameratePropagatedToEncoder) {
5854 const size_t kNumSimulcastStreams = 3;
5855 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5856
5857 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Mollera882fb32019-01-21 08:44:37 +00005858 FakeVideoCapturerWithTaskQueue capturer;
Åsa Persson8c1bf952018-09-13 10:42:19 +02005859 VideoOptions options;
Niels Mollera882fb32019-01-21 08:44:37 +00005860 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
5861 EXPECT_EQ(cricket::CS_RUNNING,
5862 capturer.Start(capturer.GetSupportedFormats()->front()));
Åsa Persson8c1bf952018-09-13 10:42:19 +02005863 channel_->SetSend(true);
Niels Mollera882fb32019-01-21 08:44:37 +00005864 EXPECT_TRUE(capturer.CaptureFrame());
Åsa Persson8c1bf952018-09-13 10:42:19 +02005865
5866 // Get and set the rtp encoding parameters.
5867 // Change the value and set it on the VideoChannel.
5868 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5869 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5870 parameters.encodings[0].max_framerate = 15;
5871 parameters.encodings[1].max_framerate = 25;
5872 parameters.encodings[2].max_framerate = 20;
5873 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5874
5875 // Verify that the new value propagated down to the encoder.
5876 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
5877 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
5878 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
5879 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
5880 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
5881 EXPECT_EQ(15, encoder_config.simulcast_layers[0].max_framerate);
5882 EXPECT_EQ(25, encoder_config.simulcast_layers[1].max_framerate);
5883 EXPECT_EQ(20, encoder_config.simulcast_layers[2].max_framerate);
5884
5885 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
5886 // VideoStreams are created appropriately for the simulcast case.
5887 // Currently the maximum |max_framerate| is used.
5888 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5889 EXPECT_EQ(25, stream->GetVideoStreams()[0].max_framerate);
5890 EXPECT_EQ(25, stream->GetVideoStreams()[1].max_framerate);
5891 EXPECT_EQ(25, stream->GetVideoStreams()[2].max_framerate);
5892
5893 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5894}
5895
5896TEST_F(WebRtcVideoChannelTest,
5897 DefaultValuePropagatedToEncoderForUnsetFramerate) {
5898 const size_t kNumSimulcastStreams = 3;
5899 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
5900 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5901
5902 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Mollera882fb32019-01-21 08:44:37 +00005903 FakeVideoCapturerWithTaskQueue capturer;
Åsa Persson8c1bf952018-09-13 10:42:19 +02005904 VideoOptions options;
Niels Mollera882fb32019-01-21 08:44:37 +00005905 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
5906 EXPECT_EQ(cricket::CS_RUNNING,
5907 capturer.Start(capturer.GetSupportedFormats()->front()));
Åsa Persson8c1bf952018-09-13 10:42:19 +02005908 channel_->SetSend(true);
Niels Mollera882fb32019-01-21 08:44:37 +00005909 EXPECT_TRUE(capturer.CaptureFrame());
Åsa Persson8c1bf952018-09-13 10:42:19 +02005910
5911 // Get and set the rtp encoding parameters.
5912 // Change the value and set it on the VideoChannel.
5913 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5914 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5915 parameters.encodings[0].max_framerate = 15;
5916 parameters.encodings[2].max_framerate = 20;
5917 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5918
5919 // Verify that the new value propagated down to the encoder.
5920 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
5921 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
5922 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
5923 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
5924 EXPECT_EQ(15, encoder_config.simulcast_layers[0].max_framerate);
5925 EXPECT_EQ(-1, encoder_config.simulcast_layers[1].max_framerate);
5926 EXPECT_EQ(20, encoder_config.simulcast_layers[2].max_framerate);
5927
5928 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
5929 // VideoStreams are created appropriately for the simulcast case.
5930 // The maximum |max_framerate| is used, kDefaultVideoMaxFramerate: 60.
5931 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5932 EXPECT_EQ(kDefaultVideoMaxFramerate,
5933 stream->GetVideoStreams()[0].max_framerate);
5934 EXPECT_EQ(kDefaultVideoMaxFramerate,
5935 stream->GetVideoStreams()[1].max_framerate);
5936 EXPECT_EQ(kDefaultVideoMaxFramerate,
5937 stream->GetVideoStreams()[2].max_framerate);
5938
5939 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5940}
5941
Åsa Persson55659812018-06-18 17:51:32 +02005942TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersMinAndMaxBitrate) {
5943 const size_t kNumSimulcastStreams = 3;
5944 SetUpSimulcast(true, false);
5945
5946 // Get and set the rtp encoding parameters.
5947 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5948 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5949 for (const auto& encoding : parameters.encodings) {
5950 EXPECT_FALSE(encoding.min_bitrate_bps);
5951 EXPECT_FALSE(encoding.max_bitrate_bps);
5952 }
5953
5954 // Change the value and set it on the VideoChannel.
5955 parameters.encodings[0].min_bitrate_bps = 100000;
5956 parameters.encodings[0].max_bitrate_bps = 200000;
5957 parameters.encodings[1].min_bitrate_bps = 300000;
5958 parameters.encodings[1].max_bitrate_bps = 400000;
5959 parameters.encodings[2].min_bitrate_bps = 500000;
5960 parameters.encodings[2].max_bitrate_bps = 600000;
5961 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5962
5963 // Verify that the bitrates are set on the VideoChannel.
5964 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5965 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5966 EXPECT_EQ(100000, parameters.encodings[0].min_bitrate_bps);
5967 EXPECT_EQ(200000, parameters.encodings[0].max_bitrate_bps);
5968 EXPECT_EQ(300000, parameters.encodings[1].min_bitrate_bps);
5969 EXPECT_EQ(400000, parameters.encodings[1].max_bitrate_bps);
5970 EXPECT_EQ(500000, parameters.encodings[2].min_bitrate_bps);
5971 EXPECT_EQ(600000, parameters.encodings[2].max_bitrate_bps);
5972}
5973
5974TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersFailsWithIncorrectBitrate) {
5975 const size_t kNumSimulcastStreams = 3;
5976 SetUpSimulcast(true, false);
5977
5978 // Get and set the rtp encoding parameters.
5979 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5980 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5981
5982 // Max bitrate lower than min bitrate should fail.
5983 parameters.encodings[2].min_bitrate_bps = 100000;
5984 parameters.encodings[2].max_bitrate_bps = 100000 - 1;
5985 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
5986 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
5987}
5988
5989// Test that min and max bitrate values set via RtpParameters are correctly
5990// propagated to the underlying encoder, and that the target is set to 3/4 of
5991// the maximum (3/4 was chosen because it's similar to the simulcast defaults
5992// that are used if no min/max are specified).
5993TEST_F(WebRtcVideoChannelTest, MinAndMaxSimulcastBitratePropagatedToEncoder) {
5994 const size_t kNumSimulcastStreams = 3;
5995 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5996
5997 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Mollera882fb32019-01-21 08:44:37 +00005998 FakeVideoCapturerWithTaskQueue capturer;
Åsa Persson55659812018-06-18 17:51:32 +02005999 VideoOptions options;
Niels Mollera882fb32019-01-21 08:44:37 +00006000 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
6001 EXPECT_EQ(cricket::CS_RUNNING,
6002 capturer.Start(capturer.GetSupportedFormats()->front()));
Åsa Persson55659812018-06-18 17:51:32 +02006003 channel_->SetSend(true);
Niels Mollera882fb32019-01-21 08:44:37 +00006004 EXPECT_TRUE(capturer.CaptureFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006005
6006 // Get and set the rtp encoding parameters.
6007 // Change the value and set it on the VideoChannel.
6008 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6009 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6010 parameters.encodings[0].min_bitrate_bps = 100000;
6011 parameters.encodings[0].max_bitrate_bps = 200000;
6012 parameters.encodings[1].min_bitrate_bps = 300000;
6013 parameters.encodings[1].max_bitrate_bps = 400000;
6014 parameters.encodings[2].min_bitrate_bps = 500000;
6015 parameters.encodings[2].max_bitrate_bps = 600000;
6016 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6017
6018 // Verify that the new value propagated down to the encoder.
6019 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6020 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6021 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6022 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6023 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6024 EXPECT_EQ(100000, encoder_config.simulcast_layers[0].min_bitrate_bps);
6025 EXPECT_EQ(200000, encoder_config.simulcast_layers[0].max_bitrate_bps);
6026 EXPECT_EQ(300000, encoder_config.simulcast_layers[1].min_bitrate_bps);
6027 EXPECT_EQ(400000, encoder_config.simulcast_layers[1].max_bitrate_bps);
6028 EXPECT_EQ(500000, encoder_config.simulcast_layers[2].min_bitrate_bps);
6029 EXPECT_EQ(600000, encoder_config.simulcast_layers[2].max_bitrate_bps);
6030
6031 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6032 // VideoStreams are created appropriately for the simulcast case.
6033 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6034 // Target bitrate: 200000 * 3 / 4 = 150000.
6035 EXPECT_EQ(100000, stream->GetVideoStreams()[0].min_bitrate_bps);
6036 EXPECT_EQ(150000, stream->GetVideoStreams()[0].target_bitrate_bps);
6037 EXPECT_EQ(200000, stream->GetVideoStreams()[0].max_bitrate_bps);
6038 // Target bitrate: 400000 * 3 / 4 = 300000.
6039 EXPECT_EQ(300000, stream->GetVideoStreams()[1].min_bitrate_bps);
6040 EXPECT_EQ(300000, stream->GetVideoStreams()[1].target_bitrate_bps);
6041 EXPECT_EQ(400000, stream->GetVideoStreams()[1].max_bitrate_bps);
6042 // Target bitrate: 600000 * 3 / 4 = 450000, less than min -> max.
6043 EXPECT_EQ(500000, stream->GetVideoStreams()[2].min_bitrate_bps);
6044 EXPECT_EQ(600000, stream->GetVideoStreams()[2].target_bitrate_bps);
6045 EXPECT_EQ(600000, stream->GetVideoStreams()[2].max_bitrate_bps);
6046
6047 // No parameter changed, encoder should not be reconfigured.
6048 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6049 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6050
6051 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6052}
6053
6054// Test to only specify the min or max bitrate value for a layer via
6055// RtpParameters. The unspecified min/max and target value should be set to the
6056// simulcast default that is used if no min/max are specified.
6057TEST_F(WebRtcVideoChannelTest, MinOrMaxSimulcastBitratePropagatedToEncoder) {
6058 const size_t kNumSimulcastStreams = 3;
6059 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6060 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6061
6062 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Mollera882fb32019-01-21 08:44:37 +00006063 FakeVideoCapturerWithTaskQueue capturer;
Åsa Persson55659812018-06-18 17:51:32 +02006064 VideoOptions options;
Niels Mollera882fb32019-01-21 08:44:37 +00006065 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
6066 EXPECT_EQ(cricket::CS_RUNNING,
6067 capturer.Start(capturer.GetSupportedFormats()->front()));
Åsa Persson55659812018-06-18 17:51:32 +02006068 channel_->SetSend(true);
Niels Mollera882fb32019-01-21 08:44:37 +00006069 EXPECT_TRUE(capturer.CaptureFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006070
6071 // Get and set the rtp encoding parameters.
6072 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6073 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6074
6075 // Change the value and set it on the VideoChannel.
6076 // Layer 0: only configure min bitrate.
6077 const int kMinBpsLayer0 = kDefault[0].min_bitrate_bps + 1;
6078 parameters.encodings[0].min_bitrate_bps = kMinBpsLayer0;
6079 // Layer 1: only configure max bitrate.
6080 const int kMaxBpsLayer1 = kDefault[1].max_bitrate_bps - 1;
6081 parameters.encodings[1].max_bitrate_bps = kMaxBpsLayer1;
6082 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6083
6084 // Verify that the new value propagated down to the encoder.
6085 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6086 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6087 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6088 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6089 EXPECT_EQ(kMinBpsLayer0, encoder_config.simulcast_layers[0].min_bitrate_bps);
6090 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].max_bitrate_bps);
6091 EXPECT_EQ(-1, encoder_config.simulcast_layers[1].min_bitrate_bps);
6092 EXPECT_EQ(kMaxBpsLayer1, encoder_config.simulcast_layers[1].max_bitrate_bps);
6093 EXPECT_EQ(-1, encoder_config.simulcast_layers[2].min_bitrate_bps);
6094 EXPECT_EQ(-1, encoder_config.simulcast_layers[2].max_bitrate_bps);
6095
6096 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6097 // VideoStreams are created appropriately for the simulcast case.
6098 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6099 // Layer 0: min configured bitrate should overwrite min default.
6100 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].min_bitrate_bps);
6101 EXPECT_EQ(kDefault[0].target_bitrate_bps,
6102 stream->GetVideoStreams()[0].target_bitrate_bps);
6103 EXPECT_EQ(kDefault[0].max_bitrate_bps,
6104 stream->GetVideoStreams()[0].max_bitrate_bps);
6105 // Layer 1: max configured bitrate should overwrite max default.
6106 EXPECT_EQ(kDefault[1].min_bitrate_bps,
6107 stream->GetVideoStreams()[1].min_bitrate_bps);
6108 EXPECT_EQ(kDefault[1].target_bitrate_bps,
6109 stream->GetVideoStreams()[1].target_bitrate_bps);
6110 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].max_bitrate_bps);
6111 // Layer 2: min and max bitrate not configured, default expected.
6112 EXPECT_EQ(kDefault[2].min_bitrate_bps,
6113 stream->GetVideoStreams()[2].min_bitrate_bps);
6114 EXPECT_EQ(kDefault[2].target_bitrate_bps,
6115 stream->GetVideoStreams()[2].target_bitrate_bps);
6116 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6117 stream->GetVideoStreams()[2].max_bitrate_bps);
6118
6119 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6120}
6121
6122// Test that specifying the min (or max) bitrate value for a layer via
6123// RtpParameters above (or below) the simulcast default max (or min) adjusts the
6124// unspecified values accordingly.
6125TEST_F(WebRtcVideoChannelTest, SetMinAndMaxSimulcastBitrateAboveBelowDefault) {
6126 const size_t kNumSimulcastStreams = 3;
6127 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6128 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6129
6130 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Mollera882fb32019-01-21 08:44:37 +00006131 FakeVideoCapturerWithTaskQueue capturer;
Åsa Persson55659812018-06-18 17:51:32 +02006132 VideoOptions options;
Niels Mollera882fb32019-01-21 08:44:37 +00006133 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
6134 EXPECT_EQ(cricket::CS_RUNNING,
6135 capturer.Start(capturer.GetSupportedFormats()->front()));
Åsa Persson55659812018-06-18 17:51:32 +02006136 channel_->SetSend(true);
Niels Mollera882fb32019-01-21 08:44:37 +00006137 EXPECT_TRUE(capturer.CaptureFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006138
6139 // Get and set the rtp encoding parameters.
6140 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6141 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6142
6143 // Change the value and set it on the VideoChannel.
6144 // For layer 0, set the min bitrate above the default max.
6145 const int kMinBpsLayer0 = kDefault[0].max_bitrate_bps + 1;
6146 parameters.encodings[0].min_bitrate_bps = kMinBpsLayer0;
6147 // For layer 1, set the max bitrate below the default min.
6148 const int kMaxBpsLayer1 = kDefault[1].min_bitrate_bps - 1;
6149 parameters.encodings[1].max_bitrate_bps = kMaxBpsLayer1;
6150 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6151
6152 // Verify that the new value propagated down to the encoder.
6153 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6154 // VideoStreams are created appropriately for the simulcast case.
6155 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6156 // Layer 0: Min bitrate above default max (target/max should be adjusted).
6157 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].min_bitrate_bps);
6158 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].target_bitrate_bps);
6159 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].max_bitrate_bps);
6160 // Layer 1: Max bitrate below default min (min/target should be adjusted).
6161 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].min_bitrate_bps);
6162 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].target_bitrate_bps);
6163 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].max_bitrate_bps);
6164 // Layer 2: min and max bitrate not configured, default expected.
6165 EXPECT_EQ(kDefault[2].min_bitrate_bps,
6166 stream->GetVideoStreams()[2].min_bitrate_bps);
6167 EXPECT_EQ(kDefault[2].target_bitrate_bps,
6168 stream->GetVideoStreams()[2].target_bitrate_bps);
6169 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6170 stream->GetVideoStreams()[2].max_bitrate_bps);
6171
6172 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6173}
6174
6175TEST_F(WebRtcVideoChannelTest, BandwidthAboveTotalMaxBitrateGivenToMaxLayer) {
6176 const size_t kNumSimulcastStreams = 3;
6177 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6178 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6179
6180 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Mollera882fb32019-01-21 08:44:37 +00006181 FakeVideoCapturerWithTaskQueue capturer;
Åsa Persson55659812018-06-18 17:51:32 +02006182 VideoOptions options;
Niels Mollera882fb32019-01-21 08:44:37 +00006183 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
6184 EXPECT_EQ(cricket::CS_RUNNING,
6185 capturer.Start(capturer.GetSupportedFormats()->front()));
Åsa Persson55659812018-06-18 17:51:32 +02006186 channel_->SetSend(true);
Niels Mollera882fb32019-01-21 08:44:37 +00006187 EXPECT_TRUE(capturer.CaptureFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006188
6189 // Set max bitrate for all but the highest layer.
6190 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6191 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6192 parameters.encodings[0].max_bitrate_bps = kDefault[0].max_bitrate_bps;
6193 parameters.encodings[1].max_bitrate_bps = kDefault[1].max_bitrate_bps;
6194 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6195
6196 // Set max bandwidth equal to total max bitrate.
6197 send_parameters_.max_bandwidth_bps =
6198 GetTotalMaxBitrateBps(stream->GetVideoStreams());
6199 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6200 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6201
6202 // No bitrate above the total max to give to the highest layer.
6203 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6204 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6205 stream->GetVideoStreams()[2].max_bitrate_bps);
6206
6207 // Set max bandwidth above the total max bitrate.
6208 send_parameters_.max_bandwidth_bps =
6209 GetTotalMaxBitrateBps(stream->GetVideoStreams()) + 1;
6210 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6211 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6212
6213 // The highest layer has no max bitrate set -> the bitrate above the total
6214 // max should be given to the highest layer.
6215 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6216 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
6217 GetTotalMaxBitrateBps(stream->GetVideoStreams()));
6218 EXPECT_EQ(kDefault[2].max_bitrate_bps + 1,
6219 stream->GetVideoStreams()[2].max_bitrate_bps);
6220
6221 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6222}
6223
6224TEST_F(WebRtcVideoChannelTest,
6225 BandwidthAboveTotalMaxBitrateNotGivenToMaxLayerIfMaxBitrateSet) {
6226 const size_t kNumSimulcastStreams = 3;
6227 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6228 EXPECT_EQ(kNumSimulcastStreams, kDefault.size());
6229 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6230
6231 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Mollera882fb32019-01-21 08:44:37 +00006232 FakeVideoCapturerWithTaskQueue capturer;
Åsa Persson55659812018-06-18 17:51:32 +02006233 VideoOptions options;
Niels Mollera882fb32019-01-21 08:44:37 +00006234 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
6235 EXPECT_EQ(cricket::CS_RUNNING,
6236 capturer.Start(capturer.GetSupportedFormats()->front()));
Åsa Persson55659812018-06-18 17:51:32 +02006237 channel_->SetSend(true);
Niels Mollera882fb32019-01-21 08:44:37 +00006238 EXPECT_TRUE(capturer.CaptureFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006239
6240 // Set max bitrate for the highest layer.
6241 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6242 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6243 parameters.encodings[2].max_bitrate_bps = kDefault[2].max_bitrate_bps;
6244 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6245
6246 // Set max bandwidth above the total max bitrate.
6247 send_parameters_.max_bandwidth_bps =
6248 GetTotalMaxBitrateBps(stream->GetVideoStreams()) + 1;
6249 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6250 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6251
6252 // The highest layer has the max bitrate set -> the bitrate above the total
6253 // max should not be given to the highest layer.
6254 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6255 EXPECT_EQ(*parameters.encodings[2].max_bitrate_bps,
6256 stream->GetVideoStreams()[2].max_bitrate_bps);
6257
6258 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6259}
6260
Åsa Perssonbdee46d2018-06-25 11:28:06 +02006261// Test that min and max bitrate values set via RtpParameters are correctly
6262// propagated to the underlying encoder for a single stream.
6263TEST_F(WebRtcVideoChannelTest, MinAndMaxBitratePropagatedToEncoder) {
6264 FakeVideoSendStream* stream = AddSendStream();
6265 EXPECT_TRUE(channel_->SetSend(true));
6266 EXPECT_TRUE(stream->IsSending());
6267
6268 // Set min and max bitrate.
6269 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6270 EXPECT_EQ(1u, parameters.encodings.size());
6271 parameters.encodings[0].min_bitrate_bps = 80000;
6272 parameters.encodings[0].max_bitrate_bps = 150000;
6273 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6274
6275 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6276 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6277 EXPECT_EQ(1u, encoder_config.number_of_streams);
6278 EXPECT_EQ(1u, encoder_config.simulcast_layers.size());
6279 EXPECT_EQ(80000, encoder_config.simulcast_layers[0].min_bitrate_bps);
6280 EXPECT_EQ(150000, encoder_config.simulcast_layers[0].max_bitrate_bps);
6281
6282 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6283 // VideoStreams are created appropriately.
6284 EXPECT_EQ(1u, stream->GetVideoStreams().size());
6285 EXPECT_EQ(80000, stream->GetVideoStreams()[0].min_bitrate_bps);
6286 EXPECT_EQ(150000, stream->GetVideoStreams()[0].target_bitrate_bps);
6287 EXPECT_EQ(150000, stream->GetVideoStreams()[0].max_bitrate_bps);
6288}
6289
6290// Test the default min and max bitrate value are correctly propagated to the
6291// underlying encoder for a single stream (when the values are not set via
6292// RtpParameters).
6293TEST_F(WebRtcVideoChannelTest, DefaultMinAndMaxBitratePropagatedToEncoder) {
6294 FakeVideoSendStream* stream = AddSendStream();
6295 EXPECT_TRUE(channel_->SetSend(true));
6296 EXPECT_TRUE(stream->IsSending());
6297
6298 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6299 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6300 EXPECT_EQ(1u, encoder_config.number_of_streams);
6301 EXPECT_EQ(1u, encoder_config.simulcast_layers.size());
6302 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].min_bitrate_bps);
6303 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].max_bitrate_bps);
6304
6305 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6306 // VideoStreams are created appropriately.
6307 EXPECT_EQ(1u, stream->GetVideoStreams().size());
6308 EXPECT_EQ(cricket::kMinVideoBitrateBps,
6309 stream->GetVideoStreams()[0].min_bitrate_bps);
6310 EXPECT_GT(stream->GetVideoStreams()[0].max_bitrate_bps,
6311 stream->GetVideoStreams()[0].min_bitrate_bps);
6312 EXPECT_EQ(stream->GetVideoStreams()[0].max_bitrate_bps,
6313 stream->GetVideoStreams()[0].target_bitrate_bps);
6314}
6315
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006316// Test that a stream will not be sending if its encoding is made inactive
6317// through SetRtpSendParameters.
Seth Hampson8234ead2018-02-02 15:16:24 -08006318TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersOneEncodingActive) {
deadbeefdbe2b872016-03-22 15:42:00 -07006319 FakeVideoSendStream* stream = AddSendStream();
6320 EXPECT_TRUE(channel_->SetSend(true));
6321 EXPECT_TRUE(stream->IsSending());
6322
6323 // Get current parameters and change "active" to false.
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006324 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
deadbeefdbe2b872016-03-22 15:42:00 -07006325 ASSERT_EQ(1u, parameters.encodings.size());
6326 ASSERT_TRUE(parameters.encodings[0].active);
6327 parameters.encodings[0].active = false;
Zach Steinba37b4b2018-01-23 15:02:36 -08006328 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeefdbe2b872016-03-22 15:42:00 -07006329 EXPECT_FALSE(stream->IsSending());
6330
6331 // Now change it back to active and verify we resume sending.
6332 parameters.encodings[0].active = true;
Zach Steinba37b4b2018-01-23 15:02:36 -08006333 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeefdbe2b872016-03-22 15:42:00 -07006334 EXPECT_TRUE(stream->IsSending());
6335}
6336
Seth Hampson8234ead2018-02-02 15:16:24 -08006337// Tests that when active is updated for any simulcast layer then the send
6338// stream's sending state will be updated and it will be reconfigured with the
6339// new appropriate active simulcast streams.
6340TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersMultipleEncodingsActive) {
6341 // Create the stream params with multiple ssrcs for simulcast.
Åsa Persson31cb8f92018-06-27 10:44:56 +02006342 const size_t kNumSimulcastStreams = 3;
Seth Hampson8234ead2018-02-02 15:16:24 -08006343 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
6344 StreamParams stream_params = CreateSimStreamParams("cname", ssrcs);
6345 FakeVideoSendStream* fake_video_send_stream = AddSendStream(stream_params);
6346 uint32_t primary_ssrc = stream_params.first_ssrc();
6347
Niels Mollera882fb32019-01-21 08:44:37 +00006348 // Using the FakeVideoCapturerWithTaskQueue, we manually send a full size
Tommi85959932018-02-07 19:26:06 +01006349 // frame. This allows us to test that ReconfigureEncoder is called
6350 // appropriately.
Niels Mollera882fb32019-01-21 08:44:37 +00006351 cricket::FakeVideoCapturerWithTaskQueue capturer;
Seth Hampson8234ead2018-02-02 15:16:24 -08006352 VideoOptions options;
Niels Mollera882fb32019-01-21 08:44:37 +00006353 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, &options, &capturer));
6354 EXPECT_EQ(cricket::CS_RUNNING,
6355 capturer.Start(cricket::VideoFormat(
6356 1920, 1080, cricket::VideoFormat::FpsToInterval(30),
6357 cricket::FOURCC_I420)));
Seth Hampson8234ead2018-02-02 15:16:24 -08006358 channel_->SetSend(true);
Niels Mollera882fb32019-01-21 08:44:37 +00006359 EXPECT_TRUE(capturer.CaptureFrame());
Seth Hampson8234ead2018-02-02 15:16:24 -08006360
6361 // Check that all encodings are initially active.
6362 webrtc::RtpParameters parameters =
6363 channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02006364 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006365 EXPECT_TRUE(parameters.encodings[0].active);
6366 EXPECT_TRUE(parameters.encodings[1].active);
6367 EXPECT_TRUE(parameters.encodings[2].active);
6368 EXPECT_TRUE(fake_video_send_stream->IsSending());
6369
6370 // Only turn on only the middle stream.
6371 parameters.encodings[0].active = false;
6372 parameters.encodings[1].active = true;
6373 parameters.encodings[2].active = false;
6374 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
6375 // Verify that the active fields are set on the VideoChannel.
6376 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02006377 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006378 EXPECT_FALSE(parameters.encodings[0].active);
6379 EXPECT_TRUE(parameters.encodings[1].active);
6380 EXPECT_FALSE(parameters.encodings[2].active);
6381 // Check that the VideoSendStream is updated appropriately. This means its
6382 // send state was updated and it was reconfigured.
6383 EXPECT_TRUE(fake_video_send_stream->IsSending());
6384 std::vector<webrtc::VideoStream> simulcast_streams =
6385 fake_video_send_stream->GetVideoStreams();
Åsa Persson31cb8f92018-06-27 10:44:56 +02006386 EXPECT_EQ(kNumSimulcastStreams, simulcast_streams.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006387 EXPECT_FALSE(simulcast_streams[0].active);
6388 EXPECT_TRUE(simulcast_streams[1].active);
6389 EXPECT_FALSE(simulcast_streams[2].active);
6390
6391 // Turn off all streams.
6392 parameters.encodings[0].active = false;
6393 parameters.encodings[1].active = false;
6394 parameters.encodings[2].active = false;
6395 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
6396 // Verify that the active fields are set on the VideoChannel.
6397 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02006398 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006399 EXPECT_FALSE(parameters.encodings[0].active);
6400 EXPECT_FALSE(parameters.encodings[1].active);
6401 EXPECT_FALSE(parameters.encodings[2].active);
6402 // Check that the VideoSendStream is off.
6403 EXPECT_FALSE(fake_video_send_stream->IsSending());
6404 simulcast_streams = fake_video_send_stream->GetVideoStreams();
Åsa Persson31cb8f92018-06-27 10:44:56 +02006405 EXPECT_EQ(kNumSimulcastStreams, simulcast_streams.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006406 EXPECT_FALSE(simulcast_streams[0].active);
6407 EXPECT_FALSE(simulcast_streams[1].active);
6408 EXPECT_FALSE(simulcast_streams[2].active);
6409
Niels Möllerff40b142018-04-09 08:49:14 +02006410 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, nullptr, nullptr));
Seth Hampson8234ead2018-02-02 15:16:24 -08006411}
6412
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006413// Test that if a stream is reconfigured (due to a codec change or other
6414// change) while its encoding is still inactive, it doesn't start sending.
eladalonf1841382017-06-12 01:16:46 -07006415TEST_F(WebRtcVideoChannelTest,
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006416 InactiveStreamDoesntStartSendingWhenReconfigured) {
6417 // Set an initial codec list, which will be modified later.
6418 cricket::VideoSendParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08006419 parameters1.codecs.push_back(GetEngineCodec("VP8"));
6420 parameters1.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006421 EXPECT_TRUE(channel_->SetSendParameters(parameters1));
6422
6423 FakeVideoSendStream* stream = AddSendStream();
6424 EXPECT_TRUE(channel_->SetSend(true));
6425 EXPECT_TRUE(stream->IsSending());
6426
6427 // Get current parameters and change "active" to false.
6428 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6429 ASSERT_EQ(1u, parameters.encodings.size());
6430 ASSERT_TRUE(parameters.encodings[0].active);
6431 parameters.encodings[0].active = false;
6432 EXPECT_EQ(1u, GetFakeSendStreams().size());
6433 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
Zach Steinba37b4b2018-01-23 15:02:36 -08006434 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006435 EXPECT_FALSE(stream->IsSending());
6436
6437 // Reorder the codec list, causing the stream to be reconfigured.
6438 cricket::VideoSendParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08006439 parameters2.codecs.push_back(GetEngineCodec("VP9"));
6440 parameters2.codecs.push_back(GetEngineCodec("VP8"));
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006441 EXPECT_TRUE(channel_->SetSendParameters(parameters2));
6442 auto new_streams = GetFakeSendStreams();
6443 // Assert that a new underlying stream was created due to the codec change.
6444 // Otherwise, this test isn't testing what it set out to test.
6445 EXPECT_EQ(1u, GetFakeSendStreams().size());
6446 EXPECT_EQ(2, fake_call_->GetNumCreatedSendStreams());
6447
6448 // Verify that we still are not sending anything, due to the inactive
6449 // encoding.
6450 EXPECT_FALSE(new_streams[0]->IsSending());
6451}
6452
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006453// Test that GetRtpSendParameters returns the currently configured codecs.
eladalonf1841382017-06-12 01:16:46 -07006454TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersCodecs) {
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006455 AddSendStream();
6456 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006457 parameters.codecs.push_back(GetEngineCodec("VP8"));
6458 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006459 EXPECT_TRUE(channel_->SetSendParameters(parameters));
6460
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006461 webrtc::RtpParameters rtp_parameters =
6462 channel_->GetRtpSendParameters(last_ssrc_);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006463 ASSERT_EQ(2u, rtp_parameters.codecs.size());
magjed509e4fe2016-11-18 01:34:11 -08006464 EXPECT_EQ(GetEngineCodec("VP8").ToCodecParameters(),
6465 rtp_parameters.codecs[0]);
6466 EXPECT_EQ(GetEngineCodec("VP9").ToCodecParameters(),
6467 rtp_parameters.codecs[1]);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006468}
6469
Florent Castellidacec712018-05-24 16:24:21 +02006470// Test that GetRtpSendParameters returns the currently configured RTCP CNAME.
6471TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersRtcpCname) {
6472 StreamParams params = StreamParams::CreateLegacy(kSsrc);
6473 params.cname = "rtcpcname";
6474 AddSendStream(params);
6475
6476 webrtc::RtpParameters rtp_parameters = channel_->GetRtpSendParameters(kSsrc);
6477 EXPECT_STREQ("rtcpcname", rtp_parameters.rtcp.cname.c_str());
6478}
6479
deadbeeffb2aced2017-01-06 23:05:37 -08006480// Test that RtpParameters for send stream has one encoding and it has
6481// the correct SSRC.
eladalonf1841382017-06-12 01:16:46 -07006482TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersSsrc) {
deadbeeffb2aced2017-01-06 23:05:37 -08006483 AddSendStream();
6484
6485 webrtc::RtpParameters rtp_parameters =
6486 channel_->GetRtpSendParameters(last_ssrc_);
6487 ASSERT_EQ(1u, rtp_parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01006488 EXPECT_EQ(last_ssrc_, rtp_parameters.encodings[0].ssrc);
deadbeeffb2aced2017-01-06 23:05:37 -08006489}
6490
Florent Castelliabe301f2018-06-12 18:33:49 +02006491TEST_F(WebRtcVideoChannelTest, DetectRtpSendParameterHeaderExtensionsChange) {
6492 AddSendStream();
6493
6494 webrtc::RtpParameters rtp_parameters =
6495 channel_->GetRtpSendParameters(last_ssrc_);
6496 rtp_parameters.header_extensions.emplace_back();
6497
6498 EXPECT_NE(0u, rtp_parameters.header_extensions.size());
6499
6500 webrtc::RTCError result =
6501 channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6502 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION, result.type());
6503}
6504
Florent Castelli87b3c512018-07-18 16:00:28 +02006505TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersDegradationPreference) {
6506 AddSendStream();
6507
Niels Mollera882fb32019-01-21 08:44:37 +00006508 FakeVideoCapturerWithTaskQueue capturer;
6509 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
Florent Castelli87b3c512018-07-18 16:00:28 +02006510
6511 webrtc::RtpParameters rtp_parameters =
6512 channel_->GetRtpSendParameters(last_ssrc_);
6513 EXPECT_EQ(rtp_parameters.degradation_preference,
6514 webrtc::DegradationPreference::BALANCED);
6515 rtp_parameters.degradation_preference =
6516 webrtc::DegradationPreference::MAINTAIN_FRAMERATE;
6517
6518 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters).ok());
6519
6520 webrtc::RtpParameters updated_rtp_parameters =
6521 channel_->GetRtpSendParameters(last_ssrc_);
6522 EXPECT_EQ(updated_rtp_parameters.degradation_preference,
6523 webrtc::DegradationPreference::MAINTAIN_FRAMERATE);
6524
6525 // Remove the source since it will be destroyed before the channel
6526 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6527}
6528
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006529// Test that if we set/get parameters multiple times, we get the same results.
eladalonf1841382017-06-12 01:16:46 -07006530TEST_F(WebRtcVideoChannelTest, SetAndGetRtpSendParameters) {
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006531 AddSendStream();
6532 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006533 parameters.codecs.push_back(GetEngineCodec("VP8"));
6534 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006535 EXPECT_TRUE(channel_->SetSendParameters(parameters));
6536
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006537 webrtc::RtpParameters initial_params =
6538 channel_->GetRtpSendParameters(last_ssrc_);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006539
6540 // We should be able to set the params we just got.
Zach Steinba37b4b2018-01-23 15:02:36 -08006541 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, initial_params).ok());
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006542
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006543 // ... And this shouldn't change the params returned by GetRtpSendParameters.
6544 EXPECT_EQ(initial_params, channel_->GetRtpSendParameters(last_ssrc_));
6545}
6546
6547// Test that GetRtpReceiveParameters returns the currently configured codecs.
eladalonf1841382017-06-12 01:16:46 -07006548TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersCodecs) {
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006549 AddRecvStream();
6550 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006551 parameters.codecs.push_back(GetEngineCodec("VP8"));
6552 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006553 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6554
6555 webrtc::RtpParameters rtp_parameters =
6556 channel_->GetRtpReceiveParameters(last_ssrc_);
6557 ASSERT_EQ(2u, rtp_parameters.codecs.size());
magjed509e4fe2016-11-18 01:34:11 -08006558 EXPECT_EQ(GetEngineCodec("VP8").ToCodecParameters(),
6559 rtp_parameters.codecs[0]);
6560 EXPECT_EQ(GetEngineCodec("VP9").ToCodecParameters(),
6561 rtp_parameters.codecs[1]);
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006562}
6563
johan073ece42016-08-26 02:59:47 -07006564#if defined(WEBRTC_USE_H264)
eladalonf1841382017-06-12 01:16:46 -07006565TEST_F(WebRtcVideoChannelTest, GetRtpReceiveFmtpSprop) {
johan073ece42016-08-26 02:59:47 -07006566#else
eladalonf1841382017-06-12 01:16:46 -07006567TEST_F(WebRtcVideoChannelTest, DISABLED_GetRtpReceiveFmtpSprop) {
johan073ece42016-08-26 02:59:47 -07006568#endif
johan3859c892016-08-05 09:19:25 -07006569 cricket::VideoRecvParameters parameters;
perkj26752742016-10-24 01:21:16 -07006570 cricket::VideoCodec kH264sprop1(101, "H264");
magjed5dfac562016-11-25 03:56:37 -08006571 kH264sprop1.SetParam(kH264FmtpSpropParameterSets, "uvw");
johan3859c892016-08-05 09:19:25 -07006572 parameters.codecs.push_back(kH264sprop1);
perkj26752742016-10-24 01:21:16 -07006573 cricket::VideoCodec kH264sprop2(102, "H264");
magjed5dfac562016-11-25 03:56:37 -08006574 kH264sprop2.SetParam(kH264FmtpSpropParameterSets, "xyz");
johan3859c892016-08-05 09:19:25 -07006575 parameters.codecs.push_back(kH264sprop2);
6576 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6577
6578 FakeVideoReceiveStream* recv_stream = AddRecvStream();
6579 const webrtc::VideoReceiveStream::Config& cfg = recv_stream->GetConfig();
6580 webrtc::RtpParameters rtp_parameters =
6581 channel_->GetRtpReceiveParameters(last_ssrc_);
6582 ASSERT_EQ(2u, rtp_parameters.codecs.size());
6583 EXPECT_EQ(kH264sprop1.ToCodecParameters(), rtp_parameters.codecs[0]);
6584 ASSERT_EQ(2u, cfg.decoders.size());
6585 EXPECT_EQ(101, cfg.decoders[0].payload_type);
Niels Möllercb7e1d22018-09-11 15:56:04 +02006586 EXPECT_EQ("H264", cfg.decoders[0].video_format.name);
magjed5dfac562016-11-25 03:56:37 -08006587 const auto it0 =
Niels Möllercb7e1d22018-09-11 15:56:04 +02006588 cfg.decoders[0].video_format.parameters.find(kH264FmtpSpropParameterSets);
6589 ASSERT_TRUE(it0 != cfg.decoders[0].video_format.parameters.end());
magjed5dfac562016-11-25 03:56:37 -08006590 EXPECT_EQ("uvw", it0->second);
johan3859c892016-08-05 09:19:25 -07006591
6592 EXPECT_EQ(102, cfg.decoders[1].payload_type);
Niels Möllercb7e1d22018-09-11 15:56:04 +02006593 EXPECT_EQ("H264", cfg.decoders[1].video_format.name);
magjed5dfac562016-11-25 03:56:37 -08006594 const auto it1 =
Niels Möllercb7e1d22018-09-11 15:56:04 +02006595 cfg.decoders[1].video_format.parameters.find(kH264FmtpSpropParameterSets);
6596 ASSERT_TRUE(it1 != cfg.decoders[1].video_format.parameters.end());
magjed5dfac562016-11-25 03:56:37 -08006597 EXPECT_EQ("xyz", it1->second);
johan3859c892016-08-05 09:19:25 -07006598}
6599
sakal1fd95952016-06-22 00:46:15 -07006600// Test that RtpParameters for receive stream has one encoding and it has
6601// the correct SSRC.
eladalonf1841382017-06-12 01:16:46 -07006602TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersSsrc) {
sakal1fd95952016-06-22 00:46:15 -07006603 AddRecvStream();
6604
6605 webrtc::RtpParameters rtp_parameters =
6606 channel_->GetRtpReceiveParameters(last_ssrc_);
6607 ASSERT_EQ(1u, rtp_parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01006608 EXPECT_EQ(last_ssrc_, rtp_parameters.encodings[0].ssrc);
sakal1fd95952016-06-22 00:46:15 -07006609}
6610
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006611// Test that if we set/get parameters multiple times, we get the same results.
eladalonf1841382017-06-12 01:16:46 -07006612TEST_F(WebRtcVideoChannelTest, SetAndGetRtpReceiveParameters) {
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006613 AddRecvStream();
6614 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006615 parameters.codecs.push_back(GetEngineCodec("VP8"));
6616 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006617 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6618
6619 webrtc::RtpParameters initial_params =
6620 channel_->GetRtpReceiveParameters(last_ssrc_);
6621
6622 // We should be able to set the params we just got.
6623 EXPECT_TRUE(channel_->SetRtpReceiveParameters(last_ssrc_, initial_params));
6624
6625 // ... And this shouldn't change the params returned by
6626 // GetRtpReceiveParameters.
6627 EXPECT_EQ(initial_params, channel_->GetRtpReceiveParameters(last_ssrc_));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006628}
6629
deadbeef3bc15102017-04-20 19:25:07 -07006630// Test that GetRtpReceiveParameters returns parameters correctly when SSRCs
6631// aren't signaled. It should always return an empty "RtpEncodingParameters",
6632// even after a packet is received and the unsignaled SSRC is known.
eladalonf1841382017-06-12 01:16:46 -07006633TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersWithUnsignaledSsrc) {
deadbeef3bc15102017-04-20 19:25:07 -07006634 // Call necessary methods to configure receiving a default stream as
6635 // soon as it arrives.
6636 cricket::VideoRecvParameters parameters;
6637 parameters.codecs.push_back(GetEngineCodec("VP8"));
6638 parameters.codecs.push_back(GetEngineCodec("VP9"));
6639 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6640
6641 // Call GetRtpReceiveParameters before configured to receive an unsignaled
6642 // stream. Should return nothing.
6643 EXPECT_EQ(webrtc::RtpParameters(), channel_->GetRtpReceiveParameters(0));
6644
6645 // Set a sink for an unsignaled stream.
6646 cricket::FakeVideoRenderer renderer;
6647 // Value of "0" means "unsignaled stream".
6648 EXPECT_TRUE(channel_->SetSink(0, &renderer));
6649
6650 // Call GetRtpReceiveParameters before the SSRC is known. Value of "0"
6651 // in this method means "unsignaled stream".
6652 webrtc::RtpParameters rtp_parameters = channel_->GetRtpReceiveParameters(0);
6653 ASSERT_EQ(1u, rtp_parameters.encodings.size());
6654 EXPECT_FALSE(rtp_parameters.encodings[0].ssrc);
6655
6656 // Receive VP8 packet.
6657 uint8_t data[kMinRtpPacketLen];
6658 cricket::RtpHeader rtpHeader;
6659 rtpHeader.payload_type = GetEngineCodec("VP8").id;
6660 rtpHeader.seq_num = rtpHeader.timestamp = 0;
6661 rtpHeader.ssrc = kIncomingUnsignalledSsrc;
6662 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
6663 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
Niels Möllere6933812018-11-05 13:01:41 +01006664 channel_->OnPacketReceived(&packet, /* packet_time_us */ -1);
deadbeef3bc15102017-04-20 19:25:07 -07006665
6666 // The |ssrc| member should still be unset.
6667 rtp_parameters = channel_->GetRtpReceiveParameters(0);
6668 ASSERT_EQ(1u, rtp_parameters.encodings.size());
6669 EXPECT_FALSE(rtp_parameters.encodings[0].ssrc);
6670}
6671
eladalonf1841382017-06-12 01:16:46 -07006672void WebRtcVideoChannelTest::TestReceiverLocalSsrcConfiguration(
Peter Boström3548dd22015-05-22 18:48:36 +02006673 bool receiver_first) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02006674 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boström3548dd22015-05-22 18:48:36 +02006675
6676 const uint32_t kSenderSsrc = 0xC0FFEE;
Peter Boströmdfa28152015-10-21 17:21:10 +02006677 const uint32_t kSecondSenderSsrc = 0xBADCAFE;
Peter Boström3548dd22015-05-22 18:48:36 +02006678 const uint32_t kReceiverSsrc = 0x4711;
Peter Boströmdfa28152015-10-21 17:21:10 +02006679 const uint32_t kExpectedDefaultReceiverSsrc = 1;
Peter Boström3548dd22015-05-22 18:48:36 +02006680
6681 if (receiver_first) {
6682 AddRecvStream(StreamParams::CreateLegacy(kReceiverSsrc));
6683 std::vector<FakeVideoReceiveStream*> receive_streams =
6684 fake_call_->GetVideoReceiveStreams();
6685 ASSERT_EQ(1u, receive_streams.size());
Peter Boströmdfa28152015-10-21 17:21:10 +02006686 // Default local SSRC when we have no sender.
6687 EXPECT_EQ(kExpectedDefaultReceiverSsrc,
6688 receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boström3548dd22015-05-22 18:48:36 +02006689 }
6690 AddSendStream(StreamParams::CreateLegacy(kSenderSsrc));
6691 if (!receiver_first)
6692 AddRecvStream(StreamParams::CreateLegacy(kReceiverSsrc));
6693 std::vector<FakeVideoReceiveStream*> receive_streams =
6694 fake_call_->GetVideoReceiveStreams();
6695 ASSERT_EQ(1u, receive_streams.size());
6696 EXPECT_EQ(kSenderSsrc, receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boströmdfa28152015-10-21 17:21:10 +02006697
6698 // Removing first sender should fall back to another (in this case the second)
6699 // local send stream's SSRC.
6700 AddSendStream(StreamParams::CreateLegacy(kSecondSenderSsrc));
6701 ASSERT_TRUE(channel_->RemoveSendStream(kSenderSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02006702 receive_streams = fake_call_->GetVideoReceiveStreams();
Peter Boströmdfa28152015-10-21 17:21:10 +02006703 ASSERT_EQ(1u, receive_streams.size());
6704 EXPECT_EQ(kSecondSenderSsrc, receive_streams[0]->GetConfig().rtp.local_ssrc);
6705
6706 // Removing the last sender should fall back to default local SSRC.
6707 ASSERT_TRUE(channel_->RemoveSendStream(kSecondSenderSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02006708 receive_streams = fake_call_->GetVideoReceiveStreams();
Peter Boströmdfa28152015-10-21 17:21:10 +02006709 ASSERT_EQ(1u, receive_streams.size());
6710 EXPECT_EQ(kExpectedDefaultReceiverSsrc,
6711 receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boström3548dd22015-05-22 18:48:36 +02006712}
6713
eladalonf1841382017-06-12 01:16:46 -07006714TEST_F(WebRtcVideoChannelTest, ConfiguresLocalSsrc) {
Peter Boström3548dd22015-05-22 18:48:36 +02006715 TestReceiverLocalSsrcConfiguration(false);
6716}
6717
eladalonf1841382017-06-12 01:16:46 -07006718TEST_F(WebRtcVideoChannelTest, ConfiguresLocalSsrcOnExistingReceivers) {
Peter Boström3548dd22015-05-22 18:48:36 +02006719 TestReceiverLocalSsrcConfiguration(true);
6720}
6721
eladalonf1841382017-06-12 01:16:46 -07006722class WebRtcVideoChannelSimulcastTest : public testing::Test {
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006723 public:
eladalonf1841382017-06-12 01:16:46 -07006724 WebRtcVideoChannelSimulcastTest()
Sebastian Jansson8f83b422018-02-21 13:07:13 +01006725 : fake_call_(),
Magnus Jedvert02e7a192017-09-23 17:21:32 +02006726 encoder_factory_(new cricket::FakeWebRtcVideoEncoderFactory),
6727 decoder_factory_(new cricket::FakeWebRtcVideoDecoderFactory),
Jiawei Ouc2ebe212018-11-08 10:02:56 -08006728 mock_rate_allocator_factory_(
6729 new webrtc::MockVideoBitrateAllocatorFactory),
Anders Carlsson67537952018-05-03 11:28:29 +02006730 engine_(std::unique_ptr<cricket::FakeWebRtcVideoEncoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +02006731 encoder_factory_),
Anders Carlsson67537952018-05-03 11:28:29 +02006732 std::unique_ptr<cricket::FakeWebRtcVideoDecoderFactory>(
Jiawei Ouc2ebe212018-11-08 10:02:56 -08006733 decoder_factory_),
6734 std::unique_ptr<webrtc::VideoBitrateAllocatorFactory>(
6735 mock_rate_allocator_factory_)),
magjed2475ae22017-09-12 04:42:15 -07006736 last_ssrc_(0) {}
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006737
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00006738 void SetUp() override {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02006739 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson84848f22018-11-16 10:40:36 +01006740 channel_.reset(engine_.CreateMediaChannel(&fake_call_, GetMediaConfig(),
6741 VideoOptions(),
6742 webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08006743 channel_->OnReadyToSend(true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006744 last_ssrc_ = 123;
6745 }
6746
6747 protected:
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006748 void VerifySimulcastSettings(const VideoCodec& codec,
perkj26752742016-10-24 01:21:16 -07006749 int capture_width,
6750 int capture_height,
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006751 size_t num_configured_streams,
sprang429600d2017-01-26 06:12:26 -08006752 size_t expected_num_streams,
6753 bool screenshare,
6754 bool conference_mode) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02006755 cricket::VideoSendParameters parameters;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02006756 parameters.codecs.push_back(codec);
sprang429600d2017-01-26 06:12:26 -08006757 parameters.conference_mode = conference_mode;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02006758 ASSERT_TRUE(channel_->SetSendParameters(parameters));
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006759
Peter Boström0c4e06b2015-10-07 12:23:21 +02006760 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
henrikg91d6ede2015-09-17 00:24:34 -07006761 RTC_DCHECK(num_configured_streams <= ssrcs.size());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006762 ssrcs.resize(num_configured_streams);
6763
sprangf24a0642017-02-28 13:23:26 -08006764 AddSendStream(CreateSimStreamParams("cname", ssrcs));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00006765 // Send a full-size frame to trigger a stream reconfiguration to use all
6766 // expected simulcast layers.
Niels Mollera882fb32019-01-21 08:44:37 +00006767 FakeVideoCapturerWithTaskQueue capturer;
sprangf24a0642017-02-28 13:23:26 -08006768 VideoOptions options;
6769 if (screenshare)
Oskar Sundbom78807582017-11-16 11:09:55 +01006770 options.is_screencast = screenshare;
Niels Mollera882fb32019-01-21 08:44:37 +00006771 EXPECT_TRUE(channel_->SetVideoSend(ssrcs.front(), &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08006772 // Fetch the latest stream since SetVideoSend() may recreate it if the
6773 // screen content setting is changed.
6774 FakeVideoSendStream* stream = fake_call_.GetVideoSendStreams().front();
Niels Mollera882fb32019-01-21 08:44:37 +00006775 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(cricket::VideoFormat(
6776 capture_width, capture_height,
6777 cricket::VideoFormat::FpsToInterval(30),
6778 cricket::FOURCC_I420)));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00006779 channel_->SetSend(true);
Niels Mollera882fb32019-01-21 08:44:37 +00006780 EXPECT_TRUE(capturer.CaptureFrame());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006781
Zach Stein3ca452b2018-01-18 10:01:24 -08006782 auto rtp_parameters = channel_->GetRtpSendParameters(kSsrcs3[0]);
6783 EXPECT_EQ(num_configured_streams, rtp_parameters.encodings.size());
6784
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006785 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6786 ASSERT_EQ(expected_num_streams, video_streams.size());
6787
sprang429600d2017-01-26 06:12:26 -08006788 std::vector<webrtc::VideoStream> expected_streams;
6789 if (conference_mode) {
6790 expected_streams = GetSimulcastConfig(
6791 num_configured_streams, capture_width, capture_height, 0,
Seth Hampson24722b32017-12-22 09:36:42 -08006792 webrtc::kDefaultBitratePriority, kDefaultQpMax,
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +02006793 kDefaultVideoMaxFramerate, screenshare, true);
sprang3ebabf12017-02-16 07:35:22 -08006794 if (screenshare) {
6795 for (const webrtc::VideoStream& stream : expected_streams) {
6796 // Never scale screen content.
Danil Chapovalov350531e2018-06-08 11:04:04 +00006797 EXPECT_EQ(stream.width, rtc::checked_cast<size_t>(capture_width));
6798 EXPECT_EQ(stream.height, rtc::checked_cast<size_t>(capture_height));
sprang3ebabf12017-02-16 07:35:22 -08006799 }
6800 }
sprang429600d2017-01-26 06:12:26 -08006801 } else {
6802 webrtc::VideoStream stream;
6803 stream.width = capture_width;
6804 stream.height = capture_height;
6805 stream.max_framerate = kDefaultVideoMaxFramerate;
Åsa Persson45bbc8a2017-11-13 10:16:47 +01006806 stream.min_bitrate_bps = cricket::kMinVideoBitrateBps;
sprang429600d2017-01-26 06:12:26 -08006807 stream.target_bitrate_bps = stream.max_bitrate_bps =
Åsa Perssonbdee46d2018-06-25 11:28:06 +02006808 GetMaxDefaultBitrateBps(capture_width, capture_height);
sprang429600d2017-01-26 06:12:26 -08006809 stream.max_qp = kDefaultQpMax;
6810 expected_streams.push_back(stream);
6811 }
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006812
6813 ASSERT_EQ(expected_streams.size(), video_streams.size());
6814
6815 size_t num_streams = video_streams.size();
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00006816 int total_max_bitrate_bps = 0;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006817 for (size_t i = 0; i < num_streams; ++i) {
6818 EXPECT_EQ(expected_streams[i].width, video_streams[i].width);
6819 EXPECT_EQ(expected_streams[i].height, video_streams[i].height);
6820
6821 EXPECT_GT(video_streams[i].max_framerate, 0);
6822 EXPECT_EQ(expected_streams[i].max_framerate,
6823 video_streams[i].max_framerate);
6824
6825 EXPECT_GT(video_streams[i].min_bitrate_bps, 0);
6826 EXPECT_EQ(expected_streams[i].min_bitrate_bps,
6827 video_streams[i].min_bitrate_bps);
6828
6829 EXPECT_GT(video_streams[i].target_bitrate_bps, 0);
6830 EXPECT_EQ(expected_streams[i].target_bitrate_bps,
6831 video_streams[i].target_bitrate_bps);
6832
6833 EXPECT_GT(video_streams[i].max_bitrate_bps, 0);
6834 EXPECT_EQ(expected_streams[i].max_bitrate_bps,
6835 video_streams[i].max_bitrate_bps);
6836
6837 EXPECT_GT(video_streams[i].max_qp, 0);
6838 EXPECT_EQ(expected_streams[i].max_qp, video_streams[i].max_qp);
6839
Sergey Silkina796a7e2018-03-01 15:11:29 +01006840 EXPECT_EQ(conference_mode,
6841 expected_streams[i].num_temporal_layers.has_value());
6842
6843 if (conference_mode) {
6844 EXPECT_EQ(expected_streams[i].num_temporal_layers,
6845 video_streams[i].num_temporal_layers);
6846 }
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00006847
6848 if (i == num_streams - 1) {
6849 total_max_bitrate_bps += video_streams[i].max_bitrate_bps;
6850 } else {
6851 total_max_bitrate_bps += video_streams[i].target_bitrate_bps;
6852 }
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006853 }
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00006854
Niels Möllerff40b142018-04-09 08:49:14 +02006855 EXPECT_TRUE(channel_->SetVideoSend(ssrcs.front(), nullptr, nullptr));
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006856 }
6857
6858 FakeVideoSendStream* AddSendStream() {
6859 return AddSendStream(StreamParams::CreateLegacy(last_ssrc_++));
6860 }
6861
6862 FakeVideoSendStream* AddSendStream(const StreamParams& sp) {
Yves Gerey665174f2018-06-19 15:03:05 +02006863 size_t num_streams = fake_call_.GetVideoSendStreams().size();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006864 EXPECT_TRUE(channel_->AddSendStream(sp));
6865 std::vector<FakeVideoSendStream*> streams =
Fredrik Solenberg709ed672015-09-15 12:26:33 +02006866 fake_call_.GetVideoSendStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006867 EXPECT_EQ(num_streams + 1, streams.size());
6868 return streams[streams.size() - 1];
6869 }
6870
6871 std::vector<FakeVideoSendStream*> GetFakeSendStreams() {
Fredrik Solenberg709ed672015-09-15 12:26:33 +02006872 return fake_call_.GetVideoSendStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006873 }
6874
6875 FakeVideoReceiveStream* AddRecvStream() {
6876 return AddRecvStream(StreamParams::CreateLegacy(last_ssrc_++));
6877 }
6878
6879 FakeVideoReceiveStream* AddRecvStream(const StreamParams& sp) {
Yves Gerey665174f2018-06-19 15:03:05 +02006880 size_t num_streams = fake_call_.GetVideoReceiveStreams().size();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006881 EXPECT_TRUE(channel_->AddRecvStream(sp));
6882 std::vector<FakeVideoReceiveStream*> streams =
Fredrik Solenberg709ed672015-09-15 12:26:33 +02006883 fake_call_.GetVideoReceiveStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006884 EXPECT_EQ(num_streams + 1, streams.size());
6885 return streams[streams.size() - 1];
6886 }
6887
skvlad11a9cbf2016-10-07 11:53:05 -07006888 webrtc::RtcEventLogNullImpl event_log_;
Fredrik Solenberg709ed672015-09-15 12:26:33 +02006889 FakeCall fake_call_;
Magnus Jedvert02e7a192017-09-23 17:21:32 +02006890 cricket::FakeWebRtcVideoEncoderFactory* encoder_factory_;
6891 cricket::FakeWebRtcVideoDecoderFactory* decoder_factory_;
Jiawei Ouc2ebe212018-11-08 10:02:56 -08006892 webrtc::MockVideoBitrateAllocatorFactory* mock_rate_allocator_factory_;
eladalonf1841382017-06-12 01:16:46 -07006893 WebRtcVideoEngine engine_;
kwiberg686a8ef2016-02-26 03:00:35 -08006894 std::unique_ptr<VideoMediaChannel> channel_;
Peter Boström0c4e06b2015-10-07 12:23:21 +02006895 uint32_t last_ssrc_;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006896};
6897
eladalonf1841382017-06-12 01:16:46 -07006898TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWith2SimulcastStreams) {
sprang429600d2017-01-26 06:12:26 -08006899 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 640, 360, 2, 2, false,
6900 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006901}
6902
eladalonf1841382017-06-12 01:16:46 -07006903TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWith3SimulcastStreams) {
sprang429600d2017-01-26 06:12:26 -08006904 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 3, false,
6905 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006906}
6907
6908// Test that we normalize send codec format size in simulcast.
eladalonf1841382017-06-12 01:16:46 -07006909TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWithOddSizeInSimulcast) {
sprang429600d2017-01-26 06:12:26 -08006910 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 541, 271, 2, 2, false,
6911 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006912}
sprang429600d2017-01-26 06:12:26 -08006913
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02006914TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsForScreenshare) {
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02006915 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
6916 false);
6917}
6918
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02006919TEST_F(WebRtcVideoChannelSimulcastTest,
6920 SetSendCodecsForConferenceModeScreenshare) {
Erik Språng72e52ee2018-11-29 11:41:53 +01006921 webrtc::test::ScopedFieldTrials field_trials(
6922 "WebRTC-SimulcastScreenshare/Disabled/");
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02006923 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
6924 true);
6925}
6926
eladalonf1841382017-06-12 01:16:46 -07006927TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsForSimulcastScreenshare) {
sprang429600d2017-01-26 06:12:26 -08006928 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 2, true,
6929 true);
6930}
6931
eladalonf1841382017-06-12 01:16:46 -07006932TEST_F(WebRtcVideoChannelSimulcastTest,
sprangfe627f32017-03-29 08:24:59 -07006933 NoSimulcastScreenshareWithoutConference) {
sprangfe627f32017-03-29 08:24:59 -07006934 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
6935 false);
6936}
6937
Yves Gereyb6a89422018-10-08 10:08:32 +02006938class WebRtcVideoFakeClock {
Jonas Oreland49ac5952018-09-26 16:04:32 +02006939 public:
Yves Gereyb6a89422018-10-08 10:08:32 +02006940 WebRtcVideoFakeClock() {
Jonas Oreland49ac5952018-09-26 16:04:32 +02006941 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(1)); // avoid time=0
6942 }
6943 rtc::ScopedFakeClock fake_clock_;
6944};
6945
Yves Gereyb6a89422018-10-08 10:08:32 +02006946// The fake clock needs to be initialized before the call, and not
6947// destroyed until after all threads spawned by the test have been stopped.
6948// This mixin ensures that.
6949class WebRtcVideoChannelTestWithClock : public WebRtcVideoFakeClock,
6950 public WebRtcVideoChannelBaseTest {};
6951
Jonas Oreland49ac5952018-09-26 16:04:32 +02006952TEST_F(WebRtcVideoChannelTestWithClock, GetSources) {
6953 uint8_t data1[] = {0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
6954 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
6955
6956 EXPECT_EQ(0u, channel_->GetSources(kSsrc).size());
6957
6958 rtc::CopyOnWriteBuffer packet1(data1, sizeof(data1));
6959 rtc::SetBE32(packet1.data() + 8, kSsrc);
6960 channel_->SetSink(kDefaultReceiveSsrc, NULL);
6961 EXPECT_TRUE(SetDefaultCodec());
6962 EXPECT_TRUE(SetSend(true));
6963 EXPECT_EQ(0, renderer_.num_rendered_frames());
Niels Möller29e13fd2018-12-17 12:35:30 +01006964 channel_->OnPacketReceived(&packet1, /*packet_time_us=*/-1);
Jonas Oreland49ac5952018-09-26 16:04:32 +02006965
6966 std::vector<webrtc::RtpSource> sources = channel_->GetSources(kSsrc);
6967 EXPECT_EQ(1u, sources.size());
6968 EXPECT_EQ(webrtc::RtpSourceType::SSRC, sources[0].source_type());
6969 int64_t timestamp1 = sources[0].timestamp_ms();
6970
6971 // a new packet.
6972 int64_t timeDeltaMs = 1;
6973 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(timeDeltaMs));
Niels Möller29e13fd2018-12-17 12:35:30 +01006974 channel_->OnPacketReceived(&packet1, /*packet_time_us=*/-1);
Jonas Oreland49ac5952018-09-26 16:04:32 +02006975 int64_t timestamp2 = channel_->GetSources(kSsrc)[0].timestamp_ms();
6976 EXPECT_EQ(timestamp2, timestamp1 + timeDeltaMs);
6977
6978 // It only keeps 10s of history.
6979 fake_clock_.AdvanceTime(webrtc::TimeDelta::seconds(10));
6980 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(1));
6981 EXPECT_EQ(0u, channel_->GetSources(kSsrc).size());
6982}
6983
6984TEST_F(WebRtcVideoChannelTestWithClock, GetContributingSources) {
6985 uint8_t data1[] = {0x81, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
6986 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
6987
6988 uint32_t kCsrc = 4321u;
6989 EXPECT_EQ(0u, channel_->GetSources(kSsrc).size());
6990 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
6991
6992 rtc::CopyOnWriteBuffer packet1(data1, sizeof(data1));
6993 rtc::SetBE32(packet1.data() + 8, kSsrc);
6994 rtc::SetBE32(packet1.data() + 12, kCsrc);
6995 channel_->SetSink(kDefaultReceiveSsrc, NULL);
6996 EXPECT_TRUE(SetDefaultCodec());
6997 EXPECT_TRUE(SetSend(true));
6998 EXPECT_EQ(0, renderer_.num_rendered_frames());
Niels Möller29e13fd2018-12-17 12:35:30 +01006999 channel_->OnPacketReceived(&packet1, /*packet_time_us=*/-1);
Jonas Oreland49ac5952018-09-26 16:04:32 +02007000
7001 {
7002 ASSERT_EQ(2u, channel_->GetSources(kSsrc).size());
7003 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7004 std::vector<webrtc::RtpSource> sources = channel_->GetSources(kSsrc);
7005 EXPECT_EQ(sources[0].timestamp_ms(), sources[1].timestamp_ms());
7006 // 1 SSRC and 1 CSRC.
7007 EXPECT_EQ(1, std::count_if(sources.begin(), sources.end(),
7008 [](const webrtc::RtpSource& source) {
7009 return source.source_type() ==
7010 webrtc::RtpSourceType::SSRC;
7011 }));
7012 EXPECT_EQ(1, std::count_if(sources.begin(), sources.end(),
7013 [](const webrtc::RtpSource& source) {
7014 return source.source_type() ==
7015 webrtc::RtpSourceType::CSRC;
7016 }));
7017 }
7018 int64_t timestamp1 = channel_->GetSources(kSsrc)[0].timestamp_ms();
7019
7020 // a new packet with only ssrc (i.e no csrc).
7021 uint8_t data2[] = {0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
7022 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
7023 rtc::CopyOnWriteBuffer packet2(data2, sizeof(data2));
7024 rtc::SetBE32(packet2.data() + 8, kSsrc);
7025
7026 int64_t timeDeltaMs = 1;
7027 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(timeDeltaMs));
Niels Möller29e13fd2018-12-17 12:35:30 +01007028 channel_->OnPacketReceived(&packet2, /*packet_time_us=*/-1);
Jonas Oreland49ac5952018-09-26 16:04:32 +02007029
7030 {
7031 ASSERT_EQ(2u, channel_->GetSources(kSsrc).size());
7032 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7033 std::vector<webrtc::RtpSource> sources = channel_->GetSources(kSsrc);
7034 EXPECT_NE(sources[0].timestamp_ms(), sources[1].timestamp_ms());
7035 // 1 SSRC and 1 CSRC.
7036 EXPECT_EQ(1, std::count_if(sources.begin(), sources.end(),
7037 [](const webrtc::RtpSource& source) {
7038 return source.source_type() ==
7039 webrtc::RtpSourceType::SSRC;
7040 }));
7041 EXPECT_EQ(1, std::count_if(sources.begin(), sources.end(),
7042 [](const webrtc::RtpSource& source) {
7043 return source.source_type() ==
7044 webrtc::RtpSourceType::CSRC;
7045 }));
7046 auto ssrcSource = std::find_if(
7047 sources.begin(), sources.end(), [](const webrtc::RtpSource& source) {
7048 return source.source_type() == webrtc::RtpSourceType::SSRC;
7049 });
7050 auto csrcSource = std::find_if(
7051 sources.begin(), sources.end(), [](const webrtc::RtpSource& source) {
7052 return source.source_type() == webrtc::RtpSourceType::CSRC;
7053 });
7054
7055 EXPECT_EQ(ssrcSource->timestamp_ms(), timestamp1 + timeDeltaMs);
7056 EXPECT_EQ(csrcSource->timestamp_ms(), timestamp1);
7057 }
7058
7059 // It only keeps 10s of history.
7060 fake_clock_.AdvanceTime(webrtc::TimeDelta::seconds(10));
7061
7062 {
7063 ASSERT_EQ(1u, channel_->GetSources(kSsrc).size());
7064 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7065 std::vector<webrtc::RtpSource> sources = channel_->GetSources(kSsrc);
7066 EXPECT_EQ(1, std::count_if(sources.begin(), sources.end(),
7067 [](const webrtc::RtpSource& source) {
7068 return source.source_type() ==
7069 webrtc::RtpSourceType::SSRC;
7070 }));
7071 EXPECT_EQ(0, std::count_if(sources.begin(), sources.end(),
7072 [](const webrtc::RtpSource& source) {
7073 return source.source_type() ==
7074 webrtc::RtpSourceType::CSRC;
7075 }));
7076 }
7077
7078 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(1));
7079 EXPECT_EQ(0u, channel_->GetSources(kSsrc).size());
7080 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7081}
7082
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00007083} // namespace cricket