blob: 493c18c40e2786f6810ade636f9afbea88314b3b [file] [log] [blame]
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001/*
kjellander1afca732016-02-07 20:46:45 -08002 * Copyright (c) 2004 The WebRTC project authors. All Rights Reserved.
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003 *
kjellander1afca732016-02-07 20:46:45 -08004 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00009 */
10
11#include <map>
kwiberg686a8ef2016-02-26 03:00:35 -080012#include <memory>
Steve Antone78bcb92017-10-31 09:53:08 -070013#include <utility>
pbos@webrtc.org86f613d2014-06-10 08:53:05 +000014#include <vector>
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000015
Steve Anton2c9ebef2019-01-28 17:27:58 -080016#include "absl/algorithm/container.h"
Niels Möller805a27e2019-01-21 12:21:27 +010017#include "absl/memory/memory.h"
Niels Möller039743e2018-10-23 10:07:25 +020018#include "absl/strings/match.h"
Steve Anton10542f22019-01-11 09:11:00 -080019#include "api/rtp_parameters.h"
Jiawei Ouc2ebe212018-11-08 10:02:56 -080020#include "api/test/mock_video_bitrate_allocator.h"
21#include "api/test/mock_video_bitrate_allocator_factory.h"
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -070022#include "api/test/mock_video_decoder_factory.h"
23#include "api/test/mock_video_encoder_factory.h"
Jonas Oreland49ac5952018-09-26 16:04:32 +020024#include "api/units/time_delta.h"
Jiawei Ouc2ebe212018-11-08 10:02:56 -080025#include "api/video/builtin_video_bitrate_allocator_factory.h"
Niels Möller805a27e2019-01-21 12:21:27 +010026#include "api/video/i420_buffer.h"
Åsa Persson23eba222018-10-02 14:47:06 +020027#include "api/video/video_bitrate_allocation.h"
Anders Carlsson5f2bb622018-05-14 09:48:06 +020028#include "api/video_codecs/builtin_video_decoder_factory.h"
29#include "api/video_codecs/builtin_video_encoder_factory.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020030#include "api/video_codecs/sdp_video_format.h"
31#include "api/video_codecs/video_decoder_factory.h"
32#include "api/video_codecs/video_encoder.h"
33#include "api/video_codecs/video_encoder_factory.h"
34#include "call/flexfec_receive_stream.h"
35#include "common_video/h264/profile_level_id.h"
36#include "logging/rtc_event_log/rtc_event_log.h"
Niels Möller805a27e2019-01-21 12:21:27 +010037#include "media/base/fake_frame_source.h"
Steve Anton10542f22019-01-11 09:11:00 -080038#include "media/base/fake_network_interface.h"
Steve Anton10542f22019-01-11 09:11:00 -080039#include "media/base/fake_video_renderer.h"
40#include "media/base/media_constants.h"
41#include "media/base/rtp_utils.h"
42#include "media/base/test_utils.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020043#include "media/engine/constants.h"
Steve Anton10542f22019-01-11 09:11:00 -080044#include "media/engine/fake_webrtc_call.h"
45#include "media/engine/fake_webrtc_video_engine.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020046#include "media/engine/simulcast.h"
Steve Anton10542f22019-01-11 09:11:00 -080047#include "media/engine/webrtc_video_engine.h"
48#include "media/engine/webrtc_voice_engine.h"
Åsa Persson23cd45a2018-07-03 10:40:40 +020049#include "modules/rtp_rtcp/include/rtp_header_parser.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020050#include "rtc_base/arraysize.h"
Steve Anton10542f22019-01-11 09:11:00 -080051#include "rtc_base/fake_clock.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020052#include "rtc_base/gunit.h"
Yves Gerey665174f2018-06-19 15:03:05 +020053#include "rtc_base/numerics/safe_conversions.h"
Steve Antonf3802842019-01-24 19:07:40 -080054#include "rtc_base/time_utils.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020055#include "test/field_trial.h"
Niels Möllerd0f0f682019-01-14 09:09:53 +010056#include "test/frame_generator.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020057#include "test/gmock.h"
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000058
Niels Möller805a27e2019-01-21 12:21:27 +010059using testing::Field;
Sebastian Jansson8f83b422018-02-21 13:07:13 +010060using webrtc::BitrateConstraints;
isheriff6f8d6862016-05-26 11:24:55 -070061using webrtc::RtpExtension;
62
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000063namespace {
buildbot@webrtc.orga8530772014-12-10 09:01:18 +000064static const int kDefaultQpMax = 56;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +000065
noahricd10a68e2015-07-10 11:27:55 -070066static const uint8_t kRedRtxPayloadType = 125;
67
Niels Möller6557d0c2018-04-11 15:18:34 +020068static const uint32_t kTimeout = 5000U;
69static const uint32_t kDefaultReceiveSsrc = 0;
70static const uint32_t kSsrc = 1234u;
71static const uint32_t kSsrcs4[] = {1, 2, 3, 4};
72static const int kVideoWidth = 640;
73static const int kVideoHeight = 360;
74static const int kFramerate = 30;
75
Peter Boström0c4e06b2015-10-07 12:23:21 +020076static const uint32_t kSsrcs1[] = {1};
77static const uint32_t kSsrcs3[] = {1, 2, 3};
78static const uint32_t kRtxSsrcs1[] = {4};
brandtr468da7c2016-11-22 02:16:47 -080079static const uint32_t kFlexfecSsrc = 5;
Peter Boström0c4e06b2015-10-07 12:23:21 +020080static const uint32_t kIncomingUnsignalledSsrc = 0xC0FFEE;
mzanaty8a855d62017-02-17 15:46:43 -080081static const uint32_t kDefaultRecvSsrc = 0;
82
pbos@webrtc.org3c107582014-07-20 15:27:35 +000083static const char kUnsupportedExtensionName[] =
84 "urn:ietf:params:rtp-hdrext:unsupported";
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000085
magjed509e4fe2016-11-18 01:34:11 -080086cricket::VideoCodec RemoveFeedbackParams(cricket::VideoCodec&& codec) {
87 codec.feedback_params = cricket::FeedbackParams();
Mirko Bonadei29a8d102018-04-25 23:58:26 +020088 return std::move(codec);
magjed509e4fe2016-11-18 01:34:11 -080089}
90
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000091void VerifyCodecHasDefaultFeedbackParams(const cricket::VideoCodec& codec) {
92 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
93 cricket::kRtcpFbParamNack, cricket::kParamValueEmpty)));
94 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
95 cricket::kRtcpFbParamNack, cricket::kRtcpFbNackParamPli)));
96 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
97 cricket::kRtcpFbParamRemb, cricket::kParamValueEmpty)));
98 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
stefan43edf0f2015-11-20 18:05:48 -080099 cricket::kRtcpFbParamTransportCc, cricket::kParamValueEmpty)));
100 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +0000101 cricket::kRtcpFbParamCcm, cricket::kRtcpFbCcmParamFir)));
102}
103
magjed725e4842016-11-16 00:48:13 -0800104// Return true if any codec in |codecs| is an RTX codec with associated payload
105// type |payload_type|.
106bool HasRtxCodec(const std::vector<cricket::VideoCodec>& codecs,
107 int payload_type) {
108 for (const cricket::VideoCodec& codec : codecs) {
109 int associated_payload_type;
Niels Möller039743e2018-10-23 10:07:25 +0200110 if (absl::EqualsIgnoreCase(codec.name.c_str(), "rtx") &&
magjed725e4842016-11-16 00:48:13 -0800111 codec.GetParam(cricket::kCodecParamAssociatedPayloadType,
112 &associated_payload_type) &&
113 associated_payload_type == payload_type) {
114 return true;
115 }
116 }
117 return false;
118}
119
nisseca5706d2017-09-11 02:32:16 -0700120// TODO(nisse): Duplicated in call.cc.
121const int* FindKeyByValue(const std::map<int, int>& m, int v) {
122 for (const auto& kv : m) {
123 if (kv.second == v)
124 return &kv.first;
125 }
126 return nullptr;
127}
128
Yves Gerey665174f2018-06-19 15:03:05 +0200129bool HasRtxReceiveAssociation(const webrtc::VideoReceiveStream::Config& config,
130 int payload_type) {
nisseca5706d2017-09-11 02:32:16 -0700131 return FindKeyByValue(config.rtp.rtx_associated_payload_types,
132 payload_type) != nullptr;
133}
134
135// Check that there's an Rtx payload type for each decoder.
136bool VerifyRtxReceiveAssociations(
137 const webrtc::VideoReceiveStream::Config& config) {
138 for (const auto& decoder : config.decoders) {
139 if (!HasRtxReceiveAssociation(config, decoder.payload_type))
140 return false;
141 }
142 return true;
143}
144
brandtrffc61182016-11-28 06:02:22 -0800145rtc::scoped_refptr<webrtc::VideoFrameBuffer> CreateBlackFrameBuffer(
nisse64ec8f82016-09-27 00:17:25 -0700146 int width,
147 int height) {
148 rtc::scoped_refptr<webrtc::I420Buffer> buffer =
149 webrtc::I420Buffer::Create(width, height);
nisseaf916892017-01-10 07:44:26 -0800150 webrtc::I420Buffer::SetBlack(buffer);
nisse64ec8f82016-09-27 00:17:25 -0700151 return buffer;
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +0000152}
153
Shao Changbine62202f2015-04-21 20:24:50 +0800154void VerifySendStreamHasRtxTypes(const webrtc::VideoSendStream::Config& config,
155 const std::map<int, int>& rtx_types) {
156 std::map<int, int>::const_iterator it;
Niels Möller259a4972018-04-05 15:36:51 +0200157 it = rtx_types.find(config.rtp.payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800158 EXPECT_TRUE(it != rtx_types.end() &&
159 it->second == config.rtp.rtx.payload_type);
160
brandtrb5f2c3f2016-10-04 23:28:39 -0700161 if (config.rtp.ulpfec.red_rtx_payload_type != -1) {
162 it = rtx_types.find(config.rtp.ulpfec.red_payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800163 EXPECT_TRUE(it != rtx_types.end() &&
brandtrb5f2c3f2016-10-04 23:28:39 -0700164 it->second == config.rtp.ulpfec.red_rtx_payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800165 }
166}
kthelgason2bc68642017-02-07 07:02:22 -0800167
168cricket::MediaConfig GetMediaConfig() {
169 cricket::MediaConfig media_config;
Niels Möller1d7ecd22018-01-18 15:25:12 +0100170 media_config.video.enable_cpu_adaptation = false;
kthelgason2bc68642017-02-07 07:02:22 -0800171 return media_config;
172}
nisse26e3abb2017-08-25 04:44:25 -0700173
Åsa Perssonbdee46d2018-06-25 11:28:06 +0200174// Values from GetMaxDefaultVideoBitrateKbps in webrtcvideoengine.cc.
175int GetMaxDefaultBitrateBps(size_t width, size_t height) {
176 if (width * height <= 320 * 240) {
177 return 600000;
178 } else if (width * height <= 640 * 480) {
179 return 1700000;
180 } else if (width * height <= 960 * 540) {
181 return 2000000;
182 } else {
183 return 2500000;
184 }
185}
186
Niels Möller731a2c22018-07-30 15:08:07 +0200187class MockVideoSource : public rtc::VideoSourceInterface<webrtc::VideoFrame> {
188 public:
189 MOCK_METHOD2(AddOrUpdateSink,
190 void(rtc::VideoSinkInterface<webrtc::VideoFrame>* sink,
191 const rtc::VideoSinkWants& wants));
192 MOCK_METHOD1(RemoveSink,
193 void(rtc::VideoSinkInterface<webrtc::VideoFrame>* sink));
194};
195
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000196} // namespace
197
Yves Gerey665174f2018-06-19 15:03:05 +0200198#define EXPECT_FRAME_WAIT(c, w, h, t) \
Niels Möller6557d0c2018-04-11 15:18:34 +0200199 EXPECT_EQ_WAIT((c), renderer_.num_rendered_frames(), (t)); \
Yves Gerey665174f2018-06-19 15:03:05 +0200200 EXPECT_EQ((w), renderer_.width()); \
201 EXPECT_EQ((h), renderer_.height()); \
Niels Möller6557d0c2018-04-11 15:18:34 +0200202 EXPECT_EQ(0, renderer_.errors());
203
Yves Gerey665174f2018-06-19 15:03:05 +0200204#define EXPECT_FRAME_ON_RENDERER_WAIT(r, c, w, h, t) \
Niels Möller6557d0c2018-04-11 15:18:34 +0200205 EXPECT_EQ_WAIT((c), (r).num_rendered_frames(), (t)); \
Yves Gerey665174f2018-06-19 15:03:05 +0200206 EXPECT_EQ((w), (r).width()); \
207 EXPECT_EQ((h), (r).height()); \
Niels Möller6557d0c2018-04-11 15:18:34 +0200208 EXPECT_EQ(0, (r).errors());
209
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000210namespace cricket {
eladalonf1841382017-06-12 01:16:46 -0700211class WebRtcVideoEngineTest : public ::testing::Test {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000212 public:
eladalonf1841382017-06-12 01:16:46 -0700213 WebRtcVideoEngineTest() : WebRtcVideoEngineTest("") {}
214 explicit WebRtcVideoEngineTest(const char* field_trials)
stefanc1aeaf02015-10-15 07:26:07 -0700215 : override_field_trials_(field_trials),
skvlad11a9cbf2016-10-07 11:53:05 -0700216 call_(webrtc::Call::Create(webrtc::Call::Config(&event_log_))),
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200217 encoder_factory_(new cricket::FakeWebRtcVideoEncoderFactory),
218 decoder_factory_(new cricket::FakeWebRtcVideoDecoderFactory),
Anders Carlsson67537952018-05-03 11:28:29 +0200219 engine_(std::unique_ptr<cricket::FakeWebRtcVideoEncoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200220 encoder_factory_),
Anders Carlsson67537952018-05-03 11:28:29 +0200221 std::unique_ptr<cricket::FakeWebRtcVideoDecoderFactory>(
Jiawei Ouc2ebe212018-11-08 10:02:56 -0800222 decoder_factory_),
223 webrtc::CreateBuiltinVideoBitrateAllocatorFactory()) {
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +0200224 // Ensure fake clock doesn't return 0, which will cause some initializations
225 // fail inside RTP senders.
226 fake_clock_.AdvanceTimeMicros(1);
227 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000228
229 protected:
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200230 void AssignDefaultAptRtxTypes();
231 void AssignDefaultCodec();
232
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100233 // Find the index of the codec in the engine with the given name. The codec
234 // must be present.
Oleh Prypina40f8242017-12-21 13:32:23 +0100235 size_t GetEngineCodecIndex(const std::string& name) const;
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100236
magjed509e4fe2016-11-18 01:34:11 -0800237 // Find the codec in the engine with the given name. The codec must be
238 // present.
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100239 cricket::VideoCodec GetEngineCodec(const std::string& name) const;
magjed509e4fe2016-11-18 01:34:11 -0800240
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200241 VideoMediaChannel* SetSendParamsWithAllSupportedCodecs();
pbos@webrtc.orgfa553ef2014-10-20 11:07:07 +0000242
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200243 VideoMediaChannel* SetRecvParamsWithSupportedCodecs(
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000244 const std::vector<VideoCodec>& codecs);
245
Elad Alon157540a2019-02-08 23:37:52 +0100246 void ExpectRtpCapabilitySupport(const char* uri, bool supported) const;
Peter Boströme4499152016-02-05 11:13:28 +0100247
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +0200248 // Has to be the first one, so it is initialized before the call or there is a
249 // race condition in the clock access.
250 rtc::ScopedFakeClock fake_clock_;
stefanc1aeaf02015-10-15 07:26:07 -0700251 webrtc::test::ScopedFieldTrials override_field_trials_;
skvlad11a9cbf2016-10-07 11:53:05 -0700252 webrtc::RtcEventLogNullImpl event_log_;
eladalonf1841382017-06-12 01:16:46 -0700253 // Used in WebRtcVideoEngineVoiceTest, but defined here so it's properly
pbos@webrtc.orgf1f0d9a2015-03-02 13:30:15 +0000254 // initialized when the constructor is called.
kwiberg686a8ef2016-02-26 03:00:35 -0800255 std::unique_ptr<webrtc::Call> call_;
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200256 cricket::FakeWebRtcVideoEncoderFactory* encoder_factory_;
257 cricket::FakeWebRtcVideoDecoderFactory* decoder_factory_;
eladalonf1841382017-06-12 01:16:46 -0700258 WebRtcVideoEngine engine_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000259 VideoCodec default_codec_;
Shao Changbine62202f2015-04-21 20:24:50 +0800260 std::map<int, int> default_apt_rtx_types_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000261};
262
eladalonf1841382017-06-12 01:16:46 -0700263TEST_F(WebRtcVideoEngineTest, DefaultRtxCodecHasAssociatedPayloadTypeSet) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200264 encoder_factory_->AddSupportedVideoCodecType("VP8");
265 AssignDefaultCodec();
266
pbos@webrtc.orge322a172014-06-13 11:47:28 +0000267 std::vector<VideoCodec> engine_codecs = engine_.codecs();
268 for (size_t i = 0; i < engine_codecs.size(); ++i) {
269 if (engine_codecs[i].name != kRtxCodecName)
270 continue;
271 int associated_payload_type;
272 EXPECT_TRUE(engine_codecs[i].GetParam(kCodecParamAssociatedPayloadType,
pbos@webrtc.org42684be2014-10-03 11:25:45 +0000273 &associated_payload_type));
pbos@webrtc.orge322a172014-06-13 11:47:28 +0000274 EXPECT_EQ(default_codec_.id, associated_payload_type);
275 return;
276 }
277 FAIL() << "No RTX codec found among default codecs.";
278}
279
eladalonf1841382017-06-12 01:16:46 -0700280TEST_F(WebRtcVideoEngineTest, SupportsTimestampOffsetHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100281 ExpectRtpCapabilitySupport(RtpExtension::kTimestampOffsetUri, true);
pbos@webrtc.org587ef602014-06-16 17:32:02 +0000282}
283
eladalonf1841382017-06-12 01:16:46 -0700284TEST_F(WebRtcVideoEngineTest, SupportsAbsoluteSenderTimeHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100285 ExpectRtpCapabilitySupport(RtpExtension::kAbsSendTimeUri, true);
pbos@webrtc.org587ef602014-06-16 17:32:02 +0000286}
287
eladalonf1841382017-06-12 01:16:46 -0700288TEST_F(WebRtcVideoEngineTest, SupportsTransportSequenceNumberHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100289 ExpectRtpCapabilitySupport(RtpExtension::kTransportSequenceNumberUri, true);
stefanc1aeaf02015-10-15 07:26:07 -0700290}
291
eladalonf1841382017-06-12 01:16:46 -0700292TEST_F(WebRtcVideoEngineTest, SupportsVideoRotationHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100293 ExpectRtpCapabilitySupport(RtpExtension::kVideoRotationUri, true);
294}
295
296TEST_F(WebRtcVideoEngineTest, SupportsPlayoutDelayHeaderExtension) {
297 ExpectRtpCapabilitySupport(RtpExtension::kPlayoutDelayUri, true);
298}
299
300TEST_F(WebRtcVideoEngineTest, SupportsVideoContentTypeHeaderExtension) {
301 ExpectRtpCapabilitySupport(RtpExtension::kVideoContentTypeUri, true);
302}
303
304TEST_F(WebRtcVideoEngineTest, SupportsVideoTimingHeaderExtension) {
305 ExpectRtpCapabilitySupport(RtpExtension::kVideoTimingUri, true);
306}
307
308TEST_F(WebRtcVideoEngineTest, SupportsFrameMarkingHeaderExtension) {
309 ExpectRtpCapabilitySupport(RtpExtension::kFrameMarkingUri, true);
Johannes Krond0b69a82018-12-03 14:18:53 +0100310}
311
312TEST_F(WebRtcVideoEngineTest, SupportsColorSpaceHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100313 ExpectRtpCapabilitySupport(RtpExtension::kColorSpaceUri, true);
314}
315
Elad Alonccb9b752019-02-19 13:01:31 +0100316TEST_F(WebRtcVideoEngineTest, AdvertiseGenericDescriptor00) {
317 ExpectRtpCapabilitySupport(RtpExtension::kGenericFrameDescriptorUri00, false);
318}
319
320TEST_F(WebRtcVideoEngineTest, AdvertiseGenericDescriptor01) {
321 ExpectRtpCapabilitySupport(RtpExtension::kGenericFrameDescriptorUri01, false);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700322}
323
philipel1e054862018-10-08 16:13:53 +0200324class WebRtcVideoEngineTestWithGenericDescriptor
325 : public WebRtcVideoEngineTest {
326 public:
327 WebRtcVideoEngineTestWithGenericDescriptor()
328 : WebRtcVideoEngineTest("WebRTC-GenericDescriptorAdvertised/Enabled/") {}
329};
330
Elad Alonccb9b752019-02-19 13:01:31 +0100331TEST_F(WebRtcVideoEngineTestWithGenericDescriptor,
332 AdvertiseGenericDescriptor00) {
333 ExpectRtpCapabilitySupport(RtpExtension::kGenericFrameDescriptorUri00, true);
334}
335
336TEST_F(WebRtcVideoEngineTestWithGenericDescriptor,
337 AdvertiseGenericDescriptor01) {
338 ExpectRtpCapabilitySupport(RtpExtension::kGenericFrameDescriptorUri01, true);
philipel1e054862018-10-08 16:13:53 +0200339}
340
eladalonf1841382017-06-12 01:16:46 -0700341TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionBeforeCapturer) {
Niels Möller731a2c22018-07-30 15:08:07 +0200342 // Allocate the source first to prevent early destruction before channel's
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700343 // dtor is called.
Niels Möller731a2c22018-07-30 15:08:07 +0200344 testing::NiceMock<MockVideoSource> video_source;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700345
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200346 encoder_factory_->AddSupportedVideoCodecType("VP8");
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700347
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200348 std::unique_ptr<VideoMediaChannel> channel(
349 SetSendParamsWithAllSupportedCodecs());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700350 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
351
352 // Add CVO extension.
353 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800354 cricket::VideoSendParameters parameters;
355 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200356 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700357 RtpExtension(RtpExtension::kVideoRotationUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200358 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700359
Niels Möller731a2c22018-07-30 15:08:07 +0200360 EXPECT_CALL(
361 video_source,
362 AddOrUpdateSink(testing::_,
363 Field(&rtc::VideoSinkWants::rotation_applied, false)));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700364 // Set capturer.
Niels Möller731a2c22018-07-30 15:08:07 +0200365 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700366
367 // Verify capturer has turned off applying rotation.
Niels Möller731a2c22018-07-30 15:08:07 +0200368 testing::Mock::VerifyAndClear(&video_source);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700369
370 // Verify removing header extension turns on applying rotation.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200371 parameters.extensions.clear();
Niels Möller731a2c22018-07-30 15:08:07 +0200372 EXPECT_CALL(
373 video_source,
374 AddOrUpdateSink(testing::_,
375 Field(&rtc::VideoSinkWants::rotation_applied, true)));
376
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200377 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700378}
379
eladalonf1841382017-06-12 01:16:46 -0700380TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionBeforeAddSendStream) {
Niels Möller731a2c22018-07-30 15:08:07 +0200381 // Allocate the source first to prevent early destruction before channel's
perkj91e1c152016-03-02 05:34:00 -0800382 // dtor is called.
Niels Möller731a2c22018-07-30 15:08:07 +0200383 testing::NiceMock<MockVideoSource> video_source;
perkj91e1c152016-03-02 05:34:00 -0800384
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200385 encoder_factory_->AddSupportedVideoCodecType("VP8");
perkj91e1c152016-03-02 05:34:00 -0800386
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200387 std::unique_ptr<VideoMediaChannel> channel(
388 SetSendParamsWithAllSupportedCodecs());
perkj91e1c152016-03-02 05:34:00 -0800389 // Add CVO extension.
390 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800391 cricket::VideoSendParameters parameters;
392 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkj91e1c152016-03-02 05:34:00 -0800393 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700394 RtpExtension(RtpExtension::kVideoRotationUri, id));
perkj91e1c152016-03-02 05:34:00 -0800395 EXPECT_TRUE(channel->SetSendParameters(parameters));
396 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
397
Niels Möller731a2c22018-07-30 15:08:07 +0200398 // Set source.
399 EXPECT_CALL(
400 video_source,
401 AddOrUpdateSink(testing::_,
402 Field(&rtc::VideoSinkWants::rotation_applied, false)));
403 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
perkj91e1c152016-03-02 05:34:00 -0800404}
405
eladalonf1841382017-06-12 01:16:46 -0700406TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionAfterCapturer) {
Niels Möller731a2c22018-07-30 15:08:07 +0200407 testing::NiceMock<MockVideoSource> video_source;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700408
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200409 encoder_factory_->AddSupportedVideoCodecType("VP8");
410 encoder_factory_->AddSupportedVideoCodecType("VP9");
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700411
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200412 std::unique_ptr<VideoMediaChannel> channel(
413 SetSendParamsWithAllSupportedCodecs());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700414 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
415
416 // Set capturer.
Niels Möller731a2c22018-07-30 15:08:07 +0200417 EXPECT_CALL(
418 video_source,
419 AddOrUpdateSink(testing::_,
420 Field(&rtc::VideoSinkWants::rotation_applied, true)));
421 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700422
perkjcaafdba2016-03-20 07:34:29 -0700423 // Verify capturer has turned on applying rotation.
Niels Möller731a2c22018-07-30 15:08:07 +0200424 testing::Mock::VerifyAndClear(&video_source);
perkjcaafdba2016-03-20 07:34:29 -0700425
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700426 // Add CVO extension.
427 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800428 cricket::VideoSendParameters parameters;
429 parameters.codecs.push_back(GetEngineCodec("VP8"));
430 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200431 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700432 RtpExtension(RtpExtension::kVideoRotationUri, id));
perkjcaafdba2016-03-20 07:34:29 -0700433 // Also remove the first codec to trigger a codec change as well.
434 parameters.codecs.erase(parameters.codecs.begin());
Niels Möller731a2c22018-07-30 15:08:07 +0200435 EXPECT_CALL(
436 video_source,
437 AddOrUpdateSink(testing::_,
438 Field(&rtc::VideoSinkWants::rotation_applied, false)));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200439 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700440
441 // Verify capturer has turned off applying rotation.
Niels Möller731a2c22018-07-30 15:08:07 +0200442 testing::Mock::VerifyAndClear(&video_source);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700443
444 // Verify removing header extension turns on applying rotation.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200445 parameters.extensions.clear();
Niels Möller731a2c22018-07-30 15:08:07 +0200446 EXPECT_CALL(
447 video_source,
448 AddOrUpdateSink(testing::_,
449 Field(&rtc::VideoSinkWants::rotation_applied, true)));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200450 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700451}
452
eladalonf1841382017-06-12 01:16:46 -0700453TEST_F(WebRtcVideoEngineTest, SetSendFailsBeforeSettingCodecs) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200454 encoder_factory_->AddSupportedVideoCodecType("VP8");
455
Sebastian Jansson84848f22018-11-16 10:40:36 +0100456 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700457 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
pbos@webrtc.org5301b0f2014-07-17 08:51:46 +0000458
459 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(123)));
460
461 EXPECT_FALSE(channel->SetSend(true))
462 << "Channel should not start without codecs.";
463 EXPECT_TRUE(channel->SetSend(false))
464 << "Channel should be stoppable even without set codecs.";
465}
466
eladalonf1841382017-06-12 01:16:46 -0700467TEST_F(WebRtcVideoEngineTest, GetStatsWithoutSendCodecsSetDoesNotCrash) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200468 encoder_factory_->AddSupportedVideoCodecType("VP8");
469
Sebastian Jansson84848f22018-11-16 10:40:36 +0100470 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700471 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
pbos@webrtc.orgc3d2bd22014-08-12 20:55:10 +0000472 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(123)));
473 VideoMediaInfo info;
474 channel->GetStats(&info);
475}
476
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200477TEST_F(WebRtcVideoEngineTest, UseFactoryForVp8WhenSupported) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200478 encoder_factory_->AddSupportedVideoCodecType("VP8");
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000479
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200480 std::unique_ptr<VideoMediaChannel> channel(
481 SetSendParamsWithAllSupportedCodecs());
Sergey Ulanove2b15012016-11-22 16:08:30 -0800482 channel->OnReadyToSend(true);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000483
484 EXPECT_TRUE(
485 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200486 EXPECT_EQ(0, encoder_factory_->GetNumCreatedEncoders());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000487 EXPECT_TRUE(channel->SetSend(true));
Niels Möllerd0f0f682019-01-14 09:09:53 +0100488 webrtc::test::FrameForwarder frame_forwarder;
489 cricket::FakeFrameSource frame_source(1280, 720,
490 rtc::kNumMicrosecsPerSec / 30);
491 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
492 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Per21d45d22016-10-30 21:37:57 +0100493 // Sending one frame will have allocate the encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200494 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
495 EXPECT_TRUE_WAIT(encoder_factory_->encoders()[0]->GetNumEncodedFrames() > 0,
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000496 kTimeout);
497
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200498 int num_created_encoders = encoder_factory_->GetNumCreatedEncoders();
Per21d45d22016-10-30 21:37:57 +0100499 EXPECT_EQ(num_created_encoders, 1);
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000500
501 // Setting codecs of the same type should not reallocate any encoders
502 // (expecting a no-op).
magjed509e4fe2016-11-18 01:34:11 -0800503 cricket::VideoSendParameters parameters;
504 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200505 EXPECT_TRUE(channel->SetSendParameters(parameters));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200506 EXPECT_EQ(num_created_encoders, encoder_factory_->GetNumCreatedEncoders());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000507
508 // Remove stream previously added to free the external encoder instance.
509 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200510 EXPECT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000511}
512
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200513// Test that when an encoder factory supports H264, we add an RTX
514// codec for it.
515// TODO(deadbeef): This test should be updated if/when we start
516// adding RTX codecs for unrecognized codec names.
517TEST_F(WebRtcVideoEngineTest, RtxCodecAddedForH264Codec) {
magjed725e4842016-11-16 00:48:13 -0800518 using webrtc::H264::ProfileLevelIdToString;
519 using webrtc::H264::ProfileLevelId;
520 using webrtc::H264::kLevel1;
Anders Carlsson67537952018-05-03 11:28:29 +0200521 webrtc::SdpVideoFormat h264_constrained_baseline("H264");
522 h264_constrained_baseline.parameters[kH264FmtpProfileLevelId] =
magjed725e4842016-11-16 00:48:13 -0800523 *ProfileLevelIdToString(
524 ProfileLevelId(webrtc::H264::kProfileConstrainedBaseline, kLevel1));
Anders Carlsson67537952018-05-03 11:28:29 +0200525 webrtc::SdpVideoFormat h264_constrained_high("H264");
526 h264_constrained_high.parameters[kH264FmtpProfileLevelId] =
magjed725e4842016-11-16 00:48:13 -0800527 *ProfileLevelIdToString(
528 ProfileLevelId(webrtc::H264::kProfileConstrainedHigh, kLevel1));
Anders Carlsson67537952018-05-03 11:28:29 +0200529 webrtc::SdpVideoFormat h264_high("H264");
530 h264_high.parameters[kH264FmtpProfileLevelId] = *ProfileLevelIdToString(
magjed725e4842016-11-16 00:48:13 -0800531 ProfileLevelId(webrtc::H264::kProfileHigh, kLevel1));
532
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200533 encoder_factory_->AddSupportedVideoCodec(h264_constrained_baseline);
534 encoder_factory_->AddSupportedVideoCodec(h264_constrained_high);
535 encoder_factory_->AddSupportedVideoCodec(h264_high);
Taylor Brandstetter6c3e7882016-06-29 11:14:19 -0700536
magjed725e4842016-11-16 00:48:13 -0800537 // First figure out what payload types the test codecs got assigned.
538 const std::vector<cricket::VideoCodec> codecs = engine_.codecs();
magjed509e4fe2016-11-18 01:34:11 -0800539 // Now search for RTX codecs for them. Expect that they all have associated
540 // RTX codecs.
magjed725e4842016-11-16 00:48:13 -0800541 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200542 codecs,
543 FindMatchingCodec(codecs, cricket::VideoCodec(h264_constrained_baseline))
544 ->id));
magjed725e4842016-11-16 00:48:13 -0800545 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200546 codecs,
547 FindMatchingCodec(codecs, cricket::VideoCodec(h264_constrained_high))
548 ->id));
magjed509e4fe2016-11-18 01:34:11 -0800549 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200550 codecs, FindMatchingCodec(codecs, cricket::VideoCodec(h264_high))->id));
Taylor Brandstetter6c3e7882016-06-29 11:14:19 -0700551}
552
Mirko Bonadei8ef57932018-11-16 14:38:03 +0100553#if defined(RTC_ENABLE_VP9)
eladalonf1841382017-06-12 01:16:46 -0700554TEST_F(WebRtcVideoEngineTest, CanConstructDecoderForVp9EncoderFactory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200555 encoder_factory_->AddSupportedVideoCodecType("VP9");
Peter Boström53eda3d2015-03-27 15:53:18 +0100556
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200557 std::unique_ptr<VideoMediaChannel> channel(
558 SetSendParamsWithAllSupportedCodecs());
Peter Boström53eda3d2015-03-27 15:53:18 +0100559
560 EXPECT_TRUE(
561 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
562}
Mirko Bonadei8ef57932018-11-16 14:38:03 +0100563#endif // defined(RTC_ENABLE_VP9)
Peter Boström53eda3d2015-03-27 15:53:18 +0100564
eladalonf1841382017-06-12 01:16:46 -0700565TEST_F(WebRtcVideoEngineTest, PropagatesInputFrameTimestamp) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200566 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson8f83b422018-02-21 13:07:13 +0100567 FakeCall* fake_call = new FakeCall();
Fredrik Solenberg709ed672015-09-15 12:26:33 +0200568 call_.reset(fake_call);
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200569 std::unique_ptr<VideoMediaChannel> channel(
570 SetSendParamsWithAllSupportedCodecs());
qiangchenc27d89f2015-07-16 10:27:16 -0700571
572 EXPECT_TRUE(
573 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
574
Niels Möllerd0f0f682019-01-14 09:09:53 +0100575 webrtc::test::FrameForwarder frame_forwarder;
576 cricket::FakeFrameSource frame_source(1280, 720,
577 rtc::kNumMicrosecsPerSec / 60);
578 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
qiangchenc27d89f2015-07-16 10:27:16 -0700579 channel->SetSend(true);
580
Fredrik Solenberg709ed672015-09-15 12:26:33 +0200581 FakeVideoSendStream* stream = fake_call->GetVideoSendStreams()[0];
qiangchenc27d89f2015-07-16 10:27:16 -0700582
Niels Möllerd0f0f682019-01-14 09:09:53 +0100583 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos1cb121d2015-09-14 11:38:38 -0700584 int64_t last_timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700585 for (int i = 0; i < 10; i++) {
Niels Möllerd0f0f682019-01-14 09:09:53 +0100586 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos1cb121d2015-09-14 11:38:38 -0700587 int64_t timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700588 int64_t interval = timestamp - last_timestamp;
589
590 // Precision changes from nanosecond to millisecond.
591 // Allow error to be no more than 1.
592 EXPECT_NEAR(cricket::VideoFormat::FpsToInterval(60) / 1E6, interval, 1);
593
594 last_timestamp = timestamp;
595 }
596
Niels Möllerd0f0f682019-01-14 09:09:53 +0100597 frame_forwarder.IncomingCapturedFrame(
598 frame_source.GetFrame(1280, 720, webrtc::VideoRotation::kVideoRotation_0,
599 rtc::kNumMicrosecsPerSec / 30));
qiangchenc27d89f2015-07-16 10:27:16 -0700600 last_timestamp = stream->GetLastTimestamp();
601 for (int i = 0; i < 10; i++) {
Niels Möllerd0f0f682019-01-14 09:09:53 +0100602 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame(
603 1280, 720, webrtc::VideoRotation::kVideoRotation_0,
604 rtc::kNumMicrosecsPerSec / 30));
pbos1cb121d2015-09-14 11:38:38 -0700605 int64_t timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700606 int64_t interval = timestamp - last_timestamp;
607
608 // Precision changes from nanosecond to millisecond.
609 // Allow error to be no more than 1.
610 EXPECT_NEAR(cricket::VideoFormat::FpsToInterval(30) / 1E6, interval, 1);
611
612 last_timestamp = timestamp;
613 }
614
615 // Remove stream previously added to free the external encoder instance.
616 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
617}
618
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200619void WebRtcVideoEngineTest::AssignDefaultAptRtxTypes() {
620 std::vector<VideoCodec> engine_codecs = engine_.codecs();
621 RTC_DCHECK(!engine_codecs.empty());
622 for (const cricket::VideoCodec& codec : engine_codecs) {
623 if (codec.name == "rtx") {
624 int associated_payload_type;
625 if (codec.GetParam(kCodecParamAssociatedPayloadType,
626 &associated_payload_type)) {
627 default_apt_rtx_types_[associated_payload_type] = codec.id;
628 }
629 }
630 }
631}
632
633void WebRtcVideoEngineTest::AssignDefaultCodec() {
634 std::vector<VideoCodec> engine_codecs = engine_.codecs();
635 RTC_DCHECK(!engine_codecs.empty());
636 bool codec_set = false;
637 for (const cricket::VideoCodec& codec : engine_codecs) {
638 if (!codec_set && codec.name != "rtx" && codec.name != "red" &&
639 codec.name != "ulpfec") {
640 default_codec_ = codec;
641 codec_set = true;
642 }
643 }
644
645 RTC_DCHECK(codec_set);
646}
647
Oleh Prypina40f8242017-12-21 13:32:23 +0100648size_t WebRtcVideoEngineTest::GetEngineCodecIndex(
649 const std::string& name) const {
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100650 const std::vector<cricket::VideoCodec> codecs = engine_.codecs();
651 for (size_t i = 0; i < codecs.size(); ++i) {
652 const cricket::VideoCodec engine_codec = codecs[i];
Niels Möller039743e2018-10-23 10:07:25 +0200653 if (!absl::EqualsIgnoreCase(name, engine_codec.name))
Magnus Jedvert8deb8182017-10-05 13:13:32 +0200654 continue;
655 // The tests only use H264 Constrained Baseline. Make sure we don't return
656 // an internal H264 codec from the engine with a different H264 profile.
Niels Möller039743e2018-10-23 10:07:25 +0200657 if (absl::EqualsIgnoreCase(name.c_str(), kH264CodecName)) {
Danil Chapovalov00c71832018-06-15 15:58:38 +0200658 const absl::optional<webrtc::H264::ProfileLevelId> profile_level_id =
Magnus Jedvert8deb8182017-10-05 13:13:32 +0200659 webrtc::H264::ParseSdpProfileLevelId(engine_codec.params);
660 if (profile_level_id->profile !=
661 webrtc::H264::kProfileConstrainedBaseline) {
662 continue;
663 }
664 }
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100665 return i;
magjed509e4fe2016-11-18 01:34:11 -0800666 }
667 // This point should never be reached.
668 ADD_FAILURE() << "Unrecognized codec name: " << name;
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100669 return -1;
670}
671
672cricket::VideoCodec WebRtcVideoEngineTest::GetEngineCodec(
673 const std::string& name) const {
674 return engine_.codecs()[GetEngineCodecIndex(name)];
magjed509e4fe2016-11-18 01:34:11 -0800675}
676
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200677VideoMediaChannel*
678WebRtcVideoEngineTest::SetSendParamsWithAllSupportedCodecs() {
Sebastian Jansson84848f22018-11-16 10:40:36 +0100679 VideoMediaChannel* channel = engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700680 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions());
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200681 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -0800682 // We need to look up the codec in the engine to get the correct payload type.
Anders Carlsson67537952018-05-03 11:28:29 +0200683 for (const webrtc::SdpVideoFormat& format :
684 encoder_factory_->GetSupportedFormats()) {
685 cricket::VideoCodec engine_codec = GetEngineCodec(format.name);
Steve Anton2c9ebef2019-01-28 17:27:58 -0800686 if (!absl::c_linear_search(parameters.codecs, engine_codec)) {
Anders Carlsson67537952018-05-03 11:28:29 +0200687 parameters.codecs.push_back(engine_codec);
688 }
689 }
magjed509e4fe2016-11-18 01:34:11 -0800690
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200691 EXPECT_TRUE(channel->SetSendParameters(parameters));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000692
693 return channel;
694}
695
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200696VideoMediaChannel* WebRtcVideoEngineTest::SetRecvParamsWithSupportedCodecs(
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000697 const std::vector<VideoCodec>& codecs) {
Sebastian Jansson84848f22018-11-16 10:40:36 +0100698 VideoMediaChannel* channel = engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700699 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions());
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200700 cricket::VideoRecvParameters parameters;
701 parameters.codecs = codecs;
702 EXPECT_TRUE(channel->SetRecvParameters(parameters));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000703
704 return channel;
705}
706
Elad Alon157540a2019-02-08 23:37:52 +0100707void WebRtcVideoEngineTest::ExpectRtpCapabilitySupport(const char* uri,
708 bool supported) const {
709 const RtpCapabilities capabilities = engine_.GetCapabilities();
710 if (supported) {
711 EXPECT_THAT(capabilities.header_extensions,
712 testing::Contains(testing::Field(&RtpExtension::uri, uri)));
713 } else {
714 EXPECT_THAT(
715 capabilities.header_extensions,
716 testing::Each(testing::Field(&RtpExtension::uri, testing::StrNe(uri))));
717 }
718}
719
eladalonf1841382017-06-12 01:16:46 -0700720TEST_F(WebRtcVideoEngineTest, UsesSimulcastAdapterForVp8Factories) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200721 encoder_factory_->AddSupportedVideoCodecType("VP8");
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000722
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200723 std::unique_ptr<VideoMediaChannel> channel(
724 SetSendParamsWithAllSupportedCodecs());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000725
Peter Boström0c4e06b2015-10-07 12:23:21 +0200726 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000727
Yves Gerey665174f2018-06-19 15:03:05 +0200728 EXPECT_TRUE(channel->AddSendStream(CreateSimStreamParams("cname", ssrcs)));
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000729 EXPECT_TRUE(channel->SetSend(true));
730
Niels Möller805a27e2019-01-21 12:21:27 +0100731 webrtc::test::FrameForwarder frame_forwarder;
732 cricket::FakeFrameSource frame_source(1280, 720,
733 rtc::kNumMicrosecsPerSec / 60);
734 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, &frame_forwarder));
735 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000736
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200737 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000738
739 // Verify that encoders are configured for simulcast through adapter
740 // (increasing resolution and only configured to send one stream each).
741 int prev_width = -1;
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200742 for (size_t i = 0; i < encoder_factory_->encoders().size(); ++i) {
743 ASSERT_TRUE(encoder_factory_->encoders()[i]->WaitForInitEncode());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000744 webrtc::VideoCodec codec_settings =
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200745 encoder_factory_->encoders()[i]->GetCodecSettings();
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000746 EXPECT_EQ(0, codec_settings.numberOfSimulcastStreams);
747 EXPECT_GT(codec_settings.width, prev_width);
748 prev_width = codec_settings.width;
749 }
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000750
Niels Möllerff40b142018-04-09 08:49:14 +0200751 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, nullptr));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000752
753 channel.reset();
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200754 ASSERT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000755}
756
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200757TEST_F(WebRtcVideoEngineTest, ChannelWithH264CanChangeToVp8) {
758 encoder_factory_->AddSupportedVideoCodecType("VP8");
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200759 encoder_factory_->AddSupportedVideoCodecType("H264");
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000760
Niels Möllerd0f0f682019-01-14 09:09:53 +0100761 // Frame source.
762 webrtc::test::FrameForwarder frame_forwarder;
763 cricket::FakeFrameSource frame_source(1280, 720,
764 rtc::kNumMicrosecsPerSec / 30);
Niels Möller4db138e2018-04-19 09:04:13 +0200765
Sebastian Jansson84848f22018-11-16 10:40:36 +0100766 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700767 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
Anders Carlsson67537952018-05-03 11:28:29 +0200768 cricket::VideoSendParameters parameters;
769 parameters.codecs.push_back(GetEngineCodec("H264"));
770 EXPECT_TRUE(channel->SetSendParameters(parameters));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000771
772 EXPECT_TRUE(
773 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möllerd0f0f682019-01-14 09:09:53 +0100774 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
Niels Möller4db138e2018-04-19 09:04:13 +0200775 // Sending one frame will have allocate the encoder.
Niels Möllerd0f0f682019-01-14 09:09:53 +0100776 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller4db138e2018-04-19 09:04:13 +0200777
778 ASSERT_EQ_WAIT(1u, encoder_factory_->encoders().size(), kTimeout);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000779
Anders Carlsson67537952018-05-03 11:28:29 +0200780 cricket::VideoSendParameters new_parameters;
781 new_parameters.codecs.push_back(GetEngineCodec("VP8"));
782 EXPECT_TRUE(channel->SetSendParameters(new_parameters));
Niels Möller4db138e2018-04-19 09:04:13 +0200783
784 // Sending one frame will switch encoder.
Niels Möllerd0f0f682019-01-14 09:09:53 +0100785 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller4db138e2018-04-19 09:04:13 +0200786
Anders Carlsson8a150d92018-05-14 12:40:04 +0200787 EXPECT_EQ_WAIT(1u, encoder_factory_->encoders().size(), kTimeout);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000788}
789
eladalonf1841382017-06-12 01:16:46 -0700790TEST_F(WebRtcVideoEngineTest,
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000791 UsesSimulcastAdapterForVp8WithCombinedVP8AndH264Factory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200792 encoder_factory_->AddSupportedVideoCodecType("VP8");
793 encoder_factory_->AddSupportedVideoCodecType("H264");
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000794
Sebastian Jansson84848f22018-11-16 10:40:36 +0100795 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700796 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
magjed509e4fe2016-11-18 01:34:11 -0800797 cricket::VideoSendParameters parameters;
798 parameters.codecs.push_back(GetEngineCodec("VP8"));
799 EXPECT_TRUE(channel->SetSendParameters(parameters));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000800
Peter Boström0c4e06b2015-10-07 12:23:21 +0200801 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000802
Yves Gerey665174f2018-06-19 15:03:05 +0200803 EXPECT_TRUE(channel->AddSendStream(CreateSimStreamParams("cname", ssrcs)));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000804 EXPECT_TRUE(channel->SetSend(true));
805
806 // Send a fake frame, or else the media engine will configure the simulcast
807 // encoder adapter at a low-enough size that it'll only create a single
808 // encoder layer.
Niels Möller805a27e2019-01-21 12:21:27 +0100809 webrtc::test::FrameForwarder frame_forwarder;
810 cricket::FakeFrameSource frame_source(1280, 720,
811 rtc::kNumMicrosecsPerSec / 30);
812 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, &frame_forwarder));
813 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000814
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200815 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
816 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000817 EXPECT_EQ(webrtc::kVideoCodecVP8,
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200818 encoder_factory_->encoders()[0]->GetCodecSettings().codecType);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000819
820 channel.reset();
821 // Make sure DestroyVideoEncoder was called on the factory.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200822 EXPECT_EQ(0u, encoder_factory_->encoders().size());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000823}
824
eladalonf1841382017-06-12 01:16:46 -0700825TEST_F(WebRtcVideoEngineTest,
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000826 DestroysNonSimulcastEncoderFromCombinedVP8AndH264Factory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200827 encoder_factory_->AddSupportedVideoCodecType("VP8");
828 encoder_factory_->AddSupportedVideoCodecType("H264");
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000829
Sebastian Jansson84848f22018-11-16 10:40:36 +0100830 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700831 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
magjed509e4fe2016-11-18 01:34:11 -0800832 cricket::VideoSendParameters parameters;
833 parameters.codecs.push_back(GetEngineCodec("H264"));
834 EXPECT_TRUE(channel->SetSendParameters(parameters));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000835
836 EXPECT_TRUE(
837 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Per21d45d22016-10-30 21:37:57 +0100838
839 // Send a frame of 720p. This should trigger a "real" encoder initialization.
Niels Möller805a27e2019-01-21 12:21:27 +0100840 webrtc::test::FrameForwarder frame_forwarder;
841 cricket::FakeFrameSource frame_source(1280, 720,
842 rtc::kNumMicrosecsPerSec / 30);
843 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
844 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller4db138e2018-04-19 09:04:13 +0200845 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
846 ASSERT_EQ(1u, encoder_factory_->encoders().size());
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200847 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000848 EXPECT_EQ(webrtc::kVideoCodecH264,
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200849 encoder_factory_->encoders()[0]->GetCodecSettings().codecType);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000850
851 channel.reset();
852 // Make sure DestroyVideoEncoder was called on the factory.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200853 ASSERT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000854}
855
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200856TEST_F(WebRtcVideoEngineTest, SimulcastEnabledForH264BehindFieldTrial) {
857 webrtc::test::ScopedFieldTrials override_field_trials_(
858 "WebRTC-H264Simulcast/Enabled/");
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200859 encoder_factory_->AddSupportedVideoCodecType("H264");
noahricfdac5162015-08-27 01:59:29 -0700860
Sebastian Jansson84848f22018-11-16 10:40:36 +0100861 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700862 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
Anders Carlsson67537952018-05-03 11:28:29 +0200863 cricket::VideoSendParameters parameters;
864 parameters.codecs.push_back(GetEngineCodec("H264"));
865 EXPECT_TRUE(channel->SetSendParameters(parameters));
noahricfdac5162015-08-27 01:59:29 -0700866
Peter Boström0c4e06b2015-10-07 12:23:21 +0200867 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
noahricfdac5162015-08-27 01:59:29 -0700868 EXPECT_TRUE(
869 channel->AddSendStream(cricket::CreateSimStreamParams("cname", ssrcs)));
Peter Boströmce23bee2016-02-02 14:14:30 +0100870
871 // Send a frame of 720p. This should trigger a "real" encoder initialization.
Niels Möller805a27e2019-01-21 12:21:27 +0100872 webrtc::test::FrameForwarder frame_forwarder;
873 cricket::FakeFrameSource frame_source(1280, 720,
874 rtc::kNumMicrosecsPerSec / 30);
875 EXPECT_TRUE(channel->SetVideoSend(ssrcs[0], nullptr, &frame_forwarder));
876 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Peter Boströmce23bee2016-02-02 14:14:30 +0100877
Niels Möller4db138e2018-04-19 09:04:13 +0200878 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200879 ASSERT_EQ(1u, encoder_factory_->encoders().size());
880 FakeWebRtcVideoEncoder* encoder = encoder_factory_->encoders()[0];
881 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
noahricfdac5162015-08-27 01:59:29 -0700882 EXPECT_EQ(webrtc::kVideoCodecH264, encoder->GetCodecSettings().codecType);
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200883 EXPECT_LT(1u, encoder->GetCodecSettings().numberOfSimulcastStreams);
Niels Möllerff40b142018-04-09 08:49:14 +0200884 EXPECT_TRUE(channel->SetVideoSend(ssrcs[0], nullptr, nullptr));
noahricfdac5162015-08-27 01:59:29 -0700885}
886
brandtrffc61182016-11-28 06:02:22 -0800887// Test that the FlexFEC field trial properly alters the output of
eladalonf1841382017-06-12 01:16:46 -0700888// WebRtcVideoEngine::codecs(), for an existing |engine_| object.
brandtrffc61182016-11-28 06:02:22 -0800889//
890// TODO(brandtr): Remove this test, when the FlexFEC field trial is gone.
eladalonf1841382017-06-12 01:16:46 -0700891TEST_F(WebRtcVideoEngineTest,
brandtrffc61182016-11-28 06:02:22 -0800892 Flexfec03SupportedAsInternalCodecBehindFieldTrial) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200893 encoder_factory_->AddSupportedVideoCodecType("VP8");
894
Steve Anton2c9ebef2019-01-28 17:27:58 -0800895 auto flexfec = Field("name", &VideoCodec::name, "flexfec-03");
brandtrffc61182016-11-28 06:02:22 -0800896
897 // FlexFEC is not active without field trial.
Steve Anton2c9ebef2019-01-28 17:27:58 -0800898 EXPECT_THAT(engine_.codecs(), Not(Contains(flexfec)));
brandtrffc61182016-11-28 06:02:22 -0800899
900 // FlexFEC is active with field trial.
901 webrtc::test::ScopedFieldTrials override_field_trials_(
brandtr340e3fd2017-02-28 15:43:10 -0800902 "WebRTC-FlexFEC-03-Advertised/Enabled/");
Steve Anton2c9ebef2019-01-28 17:27:58 -0800903 EXPECT_THAT(engine_.codecs(), Contains(flexfec));
brandtrffc61182016-11-28 06:02:22 -0800904}
905
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200906// Test that codecs are added in the order they are reported from the factory.
907TEST_F(WebRtcVideoEngineTest, ReportSupportedCodecs) {
908 encoder_factory_->AddSupportedVideoCodecType("VP8");
909 const char* kFakeCodecName = "FakeCodec";
910 encoder_factory_->AddSupportedVideoCodecType(kFakeCodecName);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000911
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200912 // The last reported codec should appear after the first codec in the vector.
Oleh Prypina40f8242017-12-21 13:32:23 +0100913 const size_t vp8_index = GetEngineCodecIndex("VP8");
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200914 const size_t fake_codec_index = GetEngineCodecIndex(kFakeCodecName);
915 EXPECT_LT(vp8_index, fake_codec_index);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000916}
917
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200918// Test that a codec that was added after the engine was initialized
brandtrffc61182016-11-28 06:02:22 -0800919// does show up in the codec list after it was added.
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200920TEST_F(WebRtcVideoEngineTest, ReportSupportedAddedCodec) {
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100921 const char* kFakeExternalCodecName1 = "FakeExternalCodec1";
922 const char* kFakeExternalCodecName2 = "FakeExternalCodec2";
Magnus Jedvert154ee1f2017-11-15 19:27:11 +0100923
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100924 // Set up external encoder factory with first codec, and initialize engine.
925 encoder_factory_->AddSupportedVideoCodecType(kFakeExternalCodecName1);
926
brandtrffc61182016-11-28 06:02:22 -0800927 std::vector<cricket::VideoCodec> codecs_before(engine_.codecs());
brandtrffc61182016-11-28 06:02:22 -0800928
929 // Add second codec.
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100930 encoder_factory_->AddSupportedVideoCodecType(kFakeExternalCodecName2);
brandtrffc61182016-11-28 06:02:22 -0800931 std::vector<cricket::VideoCodec> codecs_after(engine_.codecs());
Sami Kalliomäkie9a18b22018-07-13 10:28:21 +0200932 // The codec itself and RTX should have been added.
933 EXPECT_EQ(codecs_before.size() + 2, codecs_after.size());
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100934
935 // Check that both fake codecs are present and that the second fake codec
936 // appears after the first fake codec.
Oleh Prypina40f8242017-12-21 13:32:23 +0100937 const size_t fake_codec_index1 = GetEngineCodecIndex(kFakeExternalCodecName1);
938 const size_t fake_codec_index2 = GetEngineCodecIndex(kFakeExternalCodecName2);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100939 EXPECT_LT(fake_codec_index1, fake_codec_index2);
brandtrffc61182016-11-28 06:02:22 -0800940}
941
Sami Kalliomäkie9a18b22018-07-13 10:28:21 +0200942TEST_F(WebRtcVideoEngineTest, ReportRtxForExternalCodec) {
943 const char* kFakeCodecName = "FakeCodec";
944 encoder_factory_->AddSupportedVideoCodecType(kFakeCodecName);
945
946 const size_t fake_codec_index = GetEngineCodecIndex(kFakeCodecName);
947 EXPECT_EQ("rtx", engine_.codecs().at(fake_codec_index + 1).name);
948}
949
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200950TEST_F(WebRtcVideoEngineTest, RegisterDecodersIfSupported) {
951 encoder_factory_->AddSupportedVideoCodecType("VP8");
Anders Carlsson67537952018-05-03 11:28:29 +0200952 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200953 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -0800954 parameters.codecs.push_back(GetEngineCodec("VP8"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000955
kwiberg686a8ef2016-02-26 03:00:35 -0800956 std::unique_ptr<VideoMediaChannel> channel(
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200957 SetRecvParamsWithSupportedCodecs(parameters.codecs));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000958
959 EXPECT_TRUE(
960 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200961 ASSERT_EQ(1u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000962
963 // Setting codecs of the same type should not reallocate the decoder.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200964 EXPECT_TRUE(channel->SetRecvParameters(parameters));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200965 EXPECT_EQ(1, decoder_factory_->GetNumCreatedDecoders());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000966
967 // Remove stream previously added to free the external decoder instance.
968 EXPECT_TRUE(channel->RemoveRecvStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200969 EXPECT_EQ(0u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000970}
971
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200972// Verifies that we can set up decoders.
973TEST_F(WebRtcVideoEngineTest, RegisterH264DecoderIfSupported) {
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000974 // TODO(pbos): Do not assume that encoder/decoder support is symmetric. We
975 // can't even query the WebRtcVideoDecoderFactory for supported codecs.
976 // For now we add a FakeWebRtcVideoEncoderFactory to add H264 to supported
977 // codecs.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200978 encoder_factory_->AddSupportedVideoCodecType("H264");
Anders Carlsson67537952018-05-03 11:28:29 +0200979 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("H264"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000980 std::vector<cricket::VideoCodec> codecs;
magjed509e4fe2016-11-18 01:34:11 -0800981 codecs.push_back(GetEngineCodec("H264"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000982
kwiberg686a8ef2016-02-26 03:00:35 -0800983 std::unique_ptr<VideoMediaChannel> channel(
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200984 SetRecvParamsWithSupportedCodecs(codecs));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000985
986 EXPECT_TRUE(
987 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200988 ASSERT_EQ(1u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000989}
990
Jonas Oreland49ac5952018-09-26 16:04:32 +0200991// Tests when GetSources is called with non-existing ssrc, it will return an
992// empty list of RtpSource without crashing.
993TEST_F(WebRtcVideoEngineTest, GetSourcesWithNonExistingSsrc) {
994 // Setup an recv stream with |kSsrc|.
995 encoder_factory_->AddSupportedVideoCodecType("VP8");
996 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("VP8"));
997 cricket::VideoRecvParameters parameters;
998 parameters.codecs.push_back(GetEngineCodec("VP8"));
999 std::unique_ptr<VideoMediaChannel> channel(
1000 SetRecvParamsWithSupportedCodecs(parameters.codecs));
1001
1002 EXPECT_TRUE(
1003 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
1004
1005 // Call GetSources with |kSsrc + 1| which doesn't exist.
1006 std::vector<webrtc::RtpSource> sources = channel->GetSources(kSsrc + 1);
1007 EXPECT_EQ(0u, sources.size());
1008}
1009
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001010TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, NullFactories) {
1011 std::unique_ptr<webrtc::VideoEncoderFactory> encoder_factory;
1012 std::unique_ptr<webrtc::VideoDecoderFactory> decoder_factory;
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001013 std::unique_ptr<webrtc::VideoBitrateAllocatorFactory> rate_allocator_factory;
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001014 WebRtcVideoEngine engine(std::move(encoder_factory),
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001015 std::move(decoder_factory),
1016 std::move(rate_allocator_factory));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001017 EXPECT_EQ(0u, engine.codecs().size());
1018}
1019
1020TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, EmptyFactories) {
1021 // |engine| take ownership of the factories.
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -07001022 webrtc::MockVideoEncoderFactory* encoder_factory =
1023 new webrtc::MockVideoEncoderFactory();
1024 webrtc::MockVideoDecoderFactory* decoder_factory =
1025 new webrtc::MockVideoDecoderFactory();
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001026 webrtc::MockVideoBitrateAllocatorFactory* rate_allocator_factory =
1027 new webrtc::MockVideoBitrateAllocatorFactory();
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001028 WebRtcVideoEngine engine(
1029 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001030 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)),
1031 (std::unique_ptr<webrtc::VideoBitrateAllocatorFactory>(
1032 rate_allocator_factory)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001033 EXPECT_CALL(*encoder_factory, GetSupportedFormats());
1034 EXPECT_EQ(0u, engine.codecs().size());
1035 EXPECT_CALL(*encoder_factory, Die());
1036 EXPECT_CALL(*decoder_factory, Die());
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001037 EXPECT_CALL(*rate_allocator_factory, Die());
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001038}
1039
1040// Test full behavior in the video engine when video codec factories of the new
1041// type are injected supporting the single codec Vp8. Check the returned codecs
1042// from the engine and that we will create a Vp8 encoder and decoder using the
1043// new factories.
1044TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, Vp8) {
1045 // |engine| take ownership of the factories.
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -07001046 webrtc::MockVideoEncoderFactory* encoder_factory =
1047 new webrtc::MockVideoEncoderFactory();
1048 webrtc::MockVideoDecoderFactory* decoder_factory =
1049 new webrtc::MockVideoDecoderFactory();
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001050 webrtc::MockVideoBitrateAllocatorFactory* rate_allocator_factory =
1051 new webrtc::MockVideoBitrateAllocatorFactory();
1052 EXPECT_CALL(*rate_allocator_factory,
1053 CreateVideoBitrateAllocatorProxy(Field(
1054 &webrtc::VideoCodec::codecType, webrtc::kVideoCodecVP8)))
1055 .WillOnce(testing::Return(new webrtc::MockVideoBitrateAllocator()));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001056 WebRtcVideoEngine engine(
1057 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001058 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)),
1059 (std::unique_ptr<webrtc::VideoBitrateAllocatorFactory>(
1060 rate_allocator_factory)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001061 const webrtc::SdpVideoFormat vp8_format("VP8");
1062 const std::vector<webrtc::SdpVideoFormat> supported_formats = {vp8_format};
1063 EXPECT_CALL(*encoder_factory, GetSupportedFormats())
1064 .WillRepeatedly(testing::Return(supported_formats));
1065
1066 // Verify the codecs from the engine.
1067 const std::vector<VideoCodec> engine_codecs = engine.codecs();
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001068 // Verify default codecs has been added correctly.
1069 EXPECT_EQ(5u, engine_codecs.size());
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001070 EXPECT_EQ("VP8", engine_codecs.at(0).name);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001071
1072 // RTX codec for VP8.
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001073 EXPECT_EQ("rtx", engine_codecs.at(1).name);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001074 int vp8_associated_payload;
1075 EXPECT_TRUE(engine_codecs.at(1).GetParam(kCodecParamAssociatedPayloadType,
1076 &vp8_associated_payload));
1077 EXPECT_EQ(vp8_associated_payload, engine_codecs.at(0).id);
1078
1079 EXPECT_EQ(kRedCodecName, engine_codecs.at(2).name);
1080
1081 // RTX codec for RED.
1082 EXPECT_EQ("rtx", engine_codecs.at(3).name);
1083 int red_associated_payload;
1084 EXPECT_TRUE(engine_codecs.at(3).GetParam(kCodecParamAssociatedPayloadType,
1085 &red_associated_payload));
1086 EXPECT_EQ(red_associated_payload, engine_codecs.at(2).id);
1087
1088 EXPECT_EQ(kUlpfecCodecName, engine_codecs.at(4).name);
1089
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001090 int associated_payload_type;
1091 EXPECT_TRUE(engine_codecs.at(1).GetParam(
1092 cricket::kCodecParamAssociatedPayloadType, &associated_payload_type));
1093 EXPECT_EQ(engine_codecs.at(0).id, associated_payload_type);
1094 // Verify default parameters has been added to the VP8 codec.
1095 VerifyCodecHasDefaultFeedbackParams(engine_codecs.at(0));
1096
1097 // Mock encoder creation. |engine| take ownership of the encoder.
Mirta Dvornicic1ec2a162018-12-10 09:47:34 +00001098 webrtc::VideoEncoderFactory::CodecInfo codec_info;
1099 codec_info.is_hardware_accelerated = false;
1100 codec_info.has_internal_source = false;
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001101 const webrtc::SdpVideoFormat format("VP8");
Mirta Dvornicic1ec2a162018-12-10 09:47:34 +00001102 EXPECT_CALL(*encoder_factory, QueryVideoEncoder(format))
1103 .WillRepeatedly(testing::Return(codec_info));
Anders Carlsson67537952018-05-03 11:28:29 +02001104 FakeWebRtcVideoEncoder* const encoder = new FakeWebRtcVideoEncoder(nullptr);
Niels Möllerc572ff32018-11-07 08:43:50 +01001105 rtc::Event encoder_created;
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001106 EXPECT_CALL(*encoder_factory, CreateVideoEncoderProxy(format))
Niels Möller4db138e2018-04-19 09:04:13 +02001107 .WillOnce(
1108 ::testing::DoAll(::testing::InvokeWithoutArgs(
1109 [&encoder_created]() { encoder_created.Set(); }),
1110 ::testing::Return(encoder)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001111
1112 // Mock decoder creation. |engine| take ownership of the decoder.
Anders Carlsson67537952018-05-03 11:28:29 +02001113 FakeWebRtcVideoDecoder* const decoder = new FakeWebRtcVideoDecoder(nullptr);
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001114 EXPECT_CALL(*decoder_factory, CreateVideoDecoderProxy(format))
1115 .WillOnce(testing::Return(decoder));
1116
1117 // Create a call.
1118 webrtc::RtcEventLogNullImpl event_log;
1119 std::unique_ptr<webrtc::Call> call(
1120 webrtc::Call::Create(webrtc::Call::Config(&event_log)));
1121
1122 // Create send channel.
1123 const int send_ssrc = 123;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001124 std::unique_ptr<VideoMediaChannel> send_channel(engine.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07001125 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001126 cricket::VideoSendParameters send_parameters;
1127 send_parameters.codecs.push_back(engine_codecs.at(0));
1128 EXPECT_TRUE(send_channel->SetSendParameters(send_parameters));
1129 send_channel->OnReadyToSend(true);
1130 EXPECT_TRUE(
1131 send_channel->AddSendStream(StreamParams::CreateLegacy(send_ssrc)));
1132 EXPECT_TRUE(send_channel->SetSend(true));
1133
Niels Möller4db138e2018-04-19 09:04:13 +02001134 // Set capturer.
Niels Möller805a27e2019-01-21 12:21:27 +01001135 webrtc::test::FrameForwarder frame_forwarder;
1136 cricket::FakeFrameSource frame_source(1280, 720,
1137 rtc::kNumMicrosecsPerSec / 30);
1138 EXPECT_TRUE(send_channel->SetVideoSend(send_ssrc, nullptr, &frame_forwarder));
Niels Möller4db138e2018-04-19 09:04:13 +02001139 // Sending one frame will allocate the encoder.
Niels Möller805a27e2019-01-21 12:21:27 +01001140 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller4db138e2018-04-19 09:04:13 +02001141 encoder_created.Wait(kTimeout);
1142
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001143 // Create recv channel.
1144 const int recv_ssrc = 321;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001145 std::unique_ptr<VideoMediaChannel> recv_channel(engine.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07001146 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001147 cricket::VideoRecvParameters recv_parameters;
1148 recv_parameters.codecs.push_back(engine_codecs.at(0));
1149 EXPECT_TRUE(recv_channel->SetRecvParameters(recv_parameters));
1150 EXPECT_TRUE(recv_channel->AddRecvStream(
1151 cricket::StreamParams::CreateLegacy(recv_ssrc)));
1152
1153 // Remove streams previously added to free the encoder and decoder instance.
1154 EXPECT_CALL(*encoder_factory, Die());
1155 EXPECT_CALL(*decoder_factory, Die());
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001156 EXPECT_CALL(*rate_allocator_factory, Die());
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001157 EXPECT_TRUE(send_channel->RemoveSendStream(send_ssrc));
1158 EXPECT_TRUE(recv_channel->RemoveRecvStream(recv_ssrc));
1159}
1160
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001161// Test behavior when decoder factory fails to create a decoder (returns null).
1162TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, NullDecoder) {
1163 // |engine| take ownership of the factories.
1164 webrtc::MockVideoEncoderFactory* encoder_factory =
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001165 new webrtc::MockVideoEncoderFactory();
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001166 webrtc::MockVideoDecoderFactory* decoder_factory =
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001167 new webrtc::MockVideoDecoderFactory();
1168 webrtc::MockVideoBitrateAllocatorFactory* rate_allocator_factory =
1169 new webrtc::MockVideoBitrateAllocatorFactory();
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001170 WebRtcVideoEngine engine(
1171 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001172 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)),
1173 (std::unique_ptr<webrtc::VideoBitrateAllocatorFactory>(
1174 rate_allocator_factory)));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001175 const webrtc::SdpVideoFormat vp8_format("VP8");
1176 const std::vector<webrtc::SdpVideoFormat> supported_formats = {vp8_format};
1177 EXPECT_CALL(*encoder_factory, GetSupportedFormats())
1178 .WillRepeatedly(testing::Return(supported_formats));
1179
1180 // Decoder creation fails.
1181 EXPECT_CALL(*decoder_factory, CreateVideoDecoderProxy(testing::_))
1182 .WillOnce(testing::Return(nullptr));
1183
1184 // Create a call.
1185 webrtc::RtcEventLogNullImpl event_log;
1186 std::unique_ptr<webrtc::Call> call(
1187 webrtc::Call::Create(webrtc::Call::Config(&event_log)));
1188
1189 // Create recv channel.
1190 const int recv_ssrc = 321;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001191 std::unique_ptr<VideoMediaChannel> recv_channel(engine.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07001192 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001193 cricket::VideoRecvParameters recv_parameters;
1194 recv_parameters.codecs.push_back(engine.codecs().front());
1195 EXPECT_TRUE(recv_channel->SetRecvParameters(recv_parameters));
1196 EXPECT_TRUE(recv_channel->AddRecvStream(
1197 cricket::StreamParams::CreateLegacy(recv_ssrc)));
1198
1199 // Remove streams previously added to free the encoder and decoder instance.
1200 EXPECT_TRUE(recv_channel->RemoveRecvStream(recv_ssrc));
1201}
1202
eladalonf1841382017-06-12 01:16:46 -07001203TEST_F(WebRtcVideoEngineTest, DISABLED_RecreatesEncoderOnContentTypeChange) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001204 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson8f83b422018-02-21 13:07:13 +01001205 std::unique_ptr<FakeCall> fake_call(new FakeCall());
Anders Carlsson5f2bb622018-05-14 09:48:06 +02001206 std::unique_ptr<VideoMediaChannel> channel(
1207 SetSendParamsWithAllSupportedCodecs());
sprangf24a0642017-02-28 13:23:26 -08001208 ASSERT_TRUE(
1209 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
1210 cricket::VideoCodec codec = GetEngineCodec("VP8");
1211 cricket::VideoSendParameters parameters;
1212 parameters.codecs.push_back(codec);
1213 channel->OnReadyToSend(true);
1214 channel->SetSend(true);
1215 ASSERT_TRUE(channel->SetSendParameters(parameters));
1216
Niels Möller805a27e2019-01-21 12:21:27 +01001217 webrtc::test::FrameForwarder frame_forwarder;
1218 cricket::FakeFrameSource frame_source(1280, 720,
1219 rtc::kNumMicrosecsPerSec / 30);
sprangf24a0642017-02-28 13:23:26 -08001220 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01001221 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
sprangf24a0642017-02-28 13:23:26 -08001222
Niels Möller805a27e2019-01-21 12:21:27 +01001223 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001224 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001225 EXPECT_EQ(webrtc::VideoCodecMode::kRealtimeVideo,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001226 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001227
Niels Möller805a27e2019-01-21 12:21:27 +01001228 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
1229 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
sprangf24a0642017-02-28 13:23:26 -08001230 // No change in content type, keep current encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001231 EXPECT_EQ(1, encoder_factory_->GetNumCreatedEncoders());
sprangf24a0642017-02-28 13:23:26 -08001232
1233 options.is_screencast.emplace(true);
Niels Möller805a27e2019-01-21 12:21:27 +01001234 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
1235 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
sprangf24a0642017-02-28 13:23:26 -08001236 // Change to screen content, recreate encoder. For the simulcast encoder
1237 // adapter case, this will result in two calls since InitEncode triggers a
1238 // a new instance.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001239 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001240 EXPECT_EQ(webrtc::VideoCodecMode::kScreensharing,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001241 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001242
Niels Möller805a27e2019-01-21 12:21:27 +01001243 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
1244 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
sprangf24a0642017-02-28 13:23:26 -08001245 // Still screen content, no need to update encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001246 EXPECT_EQ(2, encoder_factory_->GetNumCreatedEncoders());
sprangf24a0642017-02-28 13:23:26 -08001247
1248 options.is_screencast.emplace(false);
1249 options.video_noise_reduction.emplace(false);
Niels Möller805a27e2019-01-21 12:21:27 +01001250 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
sprangf24a0642017-02-28 13:23:26 -08001251 // Change back to regular video content, update encoder. Also change
1252 // a non |is_screencast| option just to verify it doesn't affect recreation.
Niels Möller805a27e2019-01-21 12:21:27 +01001253 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001254 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(3));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001255 EXPECT_EQ(webrtc::VideoCodecMode::kRealtimeVideo,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001256 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001257
1258 // Remove stream previously added to free the external encoder instance.
1259 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001260 EXPECT_EQ(0u, encoder_factory_->encoders().size());
sprangf24a0642017-02-28 13:23:26 -08001261}
1262
Niels Möller6557d0c2018-04-11 15:18:34 +02001263class WebRtcVideoChannelBaseTest : public testing::Test {
1264 protected:
1265 WebRtcVideoChannelBaseTest()
Jonas Oreland49ac5952018-09-26 16:04:32 +02001266 : engine_(webrtc::CreateBuiltinVideoEncoderFactory(),
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001267 webrtc::CreateBuiltinVideoDecoderFactory(),
1268 webrtc::CreateBuiltinVideoBitrateAllocatorFactory()) {}
Niels Möller6557d0c2018-04-11 15:18:34 +02001269
1270 virtual void SetUp() {
Jonas Oreland49ac5952018-09-26 16:04:32 +02001271 // One testcase calls SetUp in a loop, only create call_ once.
1272 if (!call_) {
1273 call_.reset(webrtc::Call::Create(webrtc::Call::Config(&event_log_)));
1274 }
Niels Möller6557d0c2018-04-11 15:18:34 +02001275 cricket::MediaConfig media_config;
1276 // Disabling cpu overuse detection actually disables quality scaling too; it
1277 // implies DegradationPreference kMaintainResolution. Automatic scaling
1278 // needs to be disabled, otherwise, tests which check the size of received
1279 // frames become flaky.
1280 media_config.video.enable_cpu_adaptation = false;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001281 channel_.reset(
1282 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
1283 call_.get(), media_config, cricket::VideoOptions(),
1284 webrtc::CryptoOptions())));
Niels Möller6557d0c2018-04-11 15:18:34 +02001285 channel_->OnReadyToSend(true);
1286 EXPECT_TRUE(channel_.get() != NULL);
1287 network_interface_.SetDestination(channel_.get());
Anton Sukhanov98a462c2018-10-17 13:15:42 -07001288 channel_->SetInterface(&network_interface_, /*media_transport=*/nullptr);
Niels Möller6557d0c2018-04-11 15:18:34 +02001289 cricket::VideoRecvParameters parameters;
1290 parameters.codecs = engine_.codecs();
1291 channel_->SetRecvParameters(parameters);
1292 EXPECT_TRUE(channel_->AddSendStream(DefaultSendStreamParams()));
Niels Möller805a27e2019-01-21 12:21:27 +01001293 frame_forwarder_ = absl::make_unique<webrtc::test::FrameForwarder>();
1294 frame_source_ = absl::make_unique<cricket::FakeFrameSource>(
1295 640, 480, rtc::kNumMicrosecsPerSec / kFramerate);
1296 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, frame_forwarder_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001297 }
1298
1299 // Utility method to setup an additional stream to send and receive video.
1300 // Used to test send and recv between two streams.
1301 void SetUpSecondStream() {
1302 SetUpSecondStreamWithNoRecv();
1303 // Setup recv for second stream.
1304 EXPECT_TRUE(channel_->AddRecvStream(
1305 cricket::StreamParams::CreateLegacy(kSsrc + 2)));
1306 // Make the second renderer available for use by a new stream.
1307 EXPECT_TRUE(channel_->SetSink(kSsrc + 2, &renderer2_));
1308 }
1309 // Setup an additional stream just to send video. Defer add recv stream.
1310 // This is required if you want to test unsignalled recv of video rtp packets.
1311 void SetUpSecondStreamWithNoRecv() {
1312 // SetUp() already added kSsrc make sure duplicate SSRCs cant be added.
Yves Gerey665174f2018-06-19 15:03:05 +02001313 EXPECT_TRUE(
1314 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001315 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
Yves Gerey665174f2018-06-19 15:03:05 +02001316 EXPECT_FALSE(
1317 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001318 EXPECT_TRUE(channel_->AddSendStream(
1319 cricket::StreamParams::CreateLegacy(kSsrc + 2)));
1320 // We dont add recv for the second stream.
1321
1322 // Setup the receive and renderer for second stream after send.
Niels Möller805a27e2019-01-21 12:21:27 +01001323 frame_forwarder_2_ = absl::make_unique<webrtc::test::FrameForwarder>();
Yves Gerey665174f2018-06-19 15:03:05 +02001324 EXPECT_TRUE(
Niels Möller805a27e2019-01-21 12:21:27 +01001325 channel_->SetVideoSend(kSsrc + 2, nullptr, frame_forwarder_2_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001326 }
Yves Gerey665174f2018-06-19 15:03:05 +02001327 virtual void TearDown() { channel_.reset(); }
1328 bool SetDefaultCodec() { return SetOneCodec(DefaultCodec()); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001329
1330 bool SetOneCodec(const cricket::VideoCodec& codec) {
Niels Möller805a27e2019-01-21 12:21:27 +01001331 frame_source_ = absl::make_unique<cricket::FakeFrameSource>(
1332 kVideoWidth, kVideoHeight, rtc::kNumMicrosecsPerSec / kFramerate);
Niels Möller6557d0c2018-04-11 15:18:34 +02001333
1334 bool sending = channel_->sending();
1335 bool success = SetSend(false);
1336 if (success) {
1337 cricket::VideoSendParameters parameters;
1338 parameters.codecs.push_back(codec);
1339 success = channel_->SetSendParameters(parameters);
1340 }
1341 if (success) {
1342 success = SetSend(sending);
1343 }
1344 return success;
1345 }
Yves Gerey665174f2018-06-19 15:03:05 +02001346 bool SetSend(bool send) { return channel_->SetSend(send); }
Niels Möller805a27e2019-01-21 12:21:27 +01001347 void SendFrame() {
1348 if (frame_forwarder_2_) {
1349 frame_forwarder_2_->IncomingCapturedFrame(frame_source_->GetFrame());
Niels Möller6557d0c2018-04-11 15:18:34 +02001350 }
Niels Möller805a27e2019-01-21 12:21:27 +01001351 frame_forwarder_->IncomingCapturedFrame(frame_source_->GetFrame());
Niels Möller6557d0c2018-04-11 15:18:34 +02001352 }
1353 bool WaitAndSendFrame(int wait_ms) {
1354 bool ret = rtc::Thread::Current()->ProcessMessages(wait_ms);
Niels Möller805a27e2019-01-21 12:21:27 +01001355 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001356 return ret;
1357 }
Yves Gerey665174f2018-06-19 15:03:05 +02001358 int NumRtpBytes() { return network_interface_.NumRtpBytes(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001359 int NumRtpBytes(uint32_t ssrc) {
1360 return network_interface_.NumRtpBytes(ssrc);
1361 }
Yves Gerey665174f2018-06-19 15:03:05 +02001362 int NumRtpPackets() { return network_interface_.NumRtpPackets(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001363 int NumRtpPackets(uint32_t ssrc) {
1364 return network_interface_.NumRtpPackets(ssrc);
1365 }
Yves Gerey665174f2018-06-19 15:03:05 +02001366 int NumSentSsrcs() { return network_interface_.NumSentSsrcs(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001367 const rtc::CopyOnWriteBuffer* GetRtpPacket(int index) {
1368 return network_interface_.GetRtpPacket(index);
1369 }
1370 static int GetPayloadType(const rtc::CopyOnWriteBuffer* p) {
Åsa Persson23cd45a2018-07-03 10:40:40 +02001371 webrtc::RTPHeader header;
1372 EXPECT_TRUE(ParseRtpPacket(p, &header));
1373 return header.payloadType;
Niels Möller6557d0c2018-04-11 15:18:34 +02001374 }
Åsa Persson23cd45a2018-07-03 10:40:40 +02001375
Niels Möller6557d0c2018-04-11 15:18:34 +02001376 static bool ParseRtpPacket(const rtc::CopyOnWriteBuffer* p,
Åsa Persson23cd45a2018-07-03 10:40:40 +02001377 webrtc::RTPHeader* header) {
1378 std::unique_ptr<webrtc::RtpHeaderParser> parser(
1379 webrtc::RtpHeaderParser::Create());
1380 return parser->Parse(p->cdata(), p->size(), header);
Niels Möller6557d0c2018-04-11 15:18:34 +02001381 }
1382
1383 // Tests that we can send and receive frames.
1384 void SendAndReceive(const cricket::VideoCodec& codec) {
1385 EXPECT_TRUE(SetOneCodec(codec));
1386 EXPECT_TRUE(SetSend(true));
1387 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1388 EXPECT_EQ(0, renderer_.num_rendered_frames());
Niels Möller805a27e2019-01-21 12:21:27 +01001389 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001390 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1391 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1392 EXPECT_EQ(codec.id, GetPayloadType(p.get()));
1393 }
1394
1395 void SendReceiveManyAndGetStats(const cricket::VideoCodec& codec,
Yves Gerey665174f2018-06-19 15:03:05 +02001396 int duration_sec,
1397 int fps) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001398 EXPECT_TRUE(SetOneCodec(codec));
1399 EXPECT_TRUE(SetSend(true));
1400 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1401 EXPECT_EQ(0, renderer_.num_rendered_frames());
1402 for (int i = 0; i < duration_sec; ++i) {
1403 for (int frame = 1; frame <= fps; ++frame) {
1404 EXPECT_TRUE(WaitAndSendFrame(1000 / fps));
1405 EXPECT_FRAME_WAIT(frame + i * fps, kVideoWidth, kVideoHeight, kTimeout);
1406 }
1407 }
1408 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1409 EXPECT_EQ(codec.id, GetPayloadType(p.get()));
1410 }
1411
Niels Möller6557d0c2018-04-11 15:18:34 +02001412 cricket::VideoSenderInfo GetSenderStats(size_t i) {
1413 cricket::VideoMediaInfo info;
1414 EXPECT_TRUE(channel_->GetStats(&info));
1415 return info.senders[i];
1416 }
1417
1418 cricket::VideoReceiverInfo GetReceiverStats(size_t i) {
1419 cricket::VideoMediaInfo info;
1420 EXPECT_TRUE(channel_->GetStats(&info));
1421 return info.receivers[i];
1422 }
1423
1424 // Two streams one channel tests.
1425
1426 // Tests that we can send and receive frames.
1427 void TwoStreamsSendAndReceive(const cricket::VideoCodec& codec) {
1428 SetUpSecondStream();
1429 // Test sending and receiving on first stream.
1430 SendAndReceive(codec);
1431 // Test sending and receiving on second stream.
1432 EXPECT_EQ_WAIT(1, renderer2_.num_rendered_frames(), kTimeout);
1433 EXPECT_GT(NumRtpPackets(), 0);
1434 EXPECT_EQ(1, renderer2_.num_rendered_frames());
1435 }
1436
1437 cricket::VideoCodec GetEngineCodec(const std::string& name) {
1438 for (const cricket::VideoCodec& engine_codec : engine_.codecs()) {
Niels Möller039743e2018-10-23 10:07:25 +02001439 if (absl::EqualsIgnoreCase(name, engine_codec.name))
Niels Möller6557d0c2018-04-11 15:18:34 +02001440 return engine_codec;
1441 }
1442 // This point should never be reached.
1443 ADD_FAILURE() << "Unrecognized codec name: " << name;
1444 return cricket::VideoCodec();
1445 }
1446
1447 cricket::VideoCodec DefaultCodec() { return GetEngineCodec("VP8"); }
1448
1449 cricket::StreamParams DefaultSendStreamParams() {
1450 return cricket::StreamParams::CreateLegacy(kSsrc);
1451 }
1452
1453 webrtc::RtcEventLogNullImpl event_log_;
Jonas Oreland49ac5952018-09-26 16:04:32 +02001454 std::unique_ptr<webrtc::Call> call_;
Niels Möller6557d0c2018-04-11 15:18:34 +02001455 WebRtcVideoEngine engine_;
Niels Möller805a27e2019-01-21 12:21:27 +01001456
1457 std::unique_ptr<cricket::FakeFrameSource> frame_source_;
1458 std::unique_ptr<webrtc::test::FrameForwarder> frame_forwarder_;
1459 std::unique_ptr<webrtc::test::FrameForwarder> frame_forwarder_2_;
1460
Niels Möller6557d0c2018-04-11 15:18:34 +02001461 std::unique_ptr<WebRtcVideoChannel> channel_;
1462 cricket::FakeNetworkInterface network_interface_;
1463 cricket::FakeVideoRenderer renderer_;
1464
1465 // Used by test cases where 2 streams are run on the same channel.
1466 cricket::FakeVideoRenderer renderer2_;
1467};
1468
1469// Test that SetSend works.
srtee0c2eea2017-12-15 17:44:33 +01001470TEST_F(WebRtcVideoChannelBaseTest, SetSend) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001471 EXPECT_FALSE(channel_->sending());
Niels Möller805a27e2019-01-21 12:21:27 +01001472 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, frame_forwarder_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001473 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1474 EXPECT_FALSE(channel_->sending());
1475 EXPECT_TRUE(SetSend(true));
1476 EXPECT_TRUE(channel_->sending());
Niels Möller805a27e2019-01-21 12:21:27 +01001477 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001478 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
1479 EXPECT_TRUE(SetSend(false));
1480 EXPECT_FALSE(channel_->sending());
srtee0c2eea2017-12-15 17:44:33 +01001481}
Niels Möller6557d0c2018-04-11 15:18:34 +02001482
1483// Test that SetSend fails without codecs being set.
srtee0c2eea2017-12-15 17:44:33 +01001484TEST_F(WebRtcVideoChannelBaseTest, SetSendWithoutCodecs) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001485 EXPECT_FALSE(channel_->sending());
1486 EXPECT_FALSE(SetSend(true));
1487 EXPECT_FALSE(channel_->sending());
srtee0c2eea2017-12-15 17:44:33 +01001488}
Niels Möller6557d0c2018-04-11 15:18:34 +02001489
1490// Test that we properly set the send and recv buffer sizes by the time
1491// SetSend is called.
srtee0c2eea2017-12-15 17:44:33 +01001492TEST_F(WebRtcVideoChannelBaseTest, SetSendSetsTransportBufferSizes) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001493 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1494 EXPECT_TRUE(SetSend(true));
1495 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
Johannes Krond38a2b82018-10-23 11:31:19 +02001496 EXPECT_EQ(256 * 1024, network_interface_.recvbuf_size());
Erik Språng820ebd02018-08-20 17:14:25 +02001497}
1498
Niels Möller6557d0c2018-04-11 15:18:34 +02001499// Test that stats work properly for a 1-1 call.
srtee0c2eea2017-12-15 17:44:33 +01001500TEST_F(WebRtcVideoChannelBaseTest, GetStats) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001501 const int kDurationSec = 3;
1502 const int kFps = 10;
1503 SendReceiveManyAndGetStats(DefaultCodec(), kDurationSec, kFps);
1504
1505 cricket::VideoMediaInfo info;
1506 EXPECT_TRUE(channel_->GetStats(&info));
1507
1508 ASSERT_EQ(1U, info.senders.size());
1509 // TODO(whyuan): bytes_sent and bytes_rcvd are different. Are both payload?
1510 // For webrtc, bytes_sent does not include the RTP header length.
1511 EXPECT_GT(info.senders[0].bytes_sent, 0);
1512 EXPECT_EQ(NumRtpPackets(), info.senders[0].packets_sent);
1513 EXPECT_EQ(0.0, info.senders[0].fraction_lost);
1514 ASSERT_TRUE(info.senders[0].codec_payload_type);
1515 EXPECT_EQ(DefaultCodec().id, *info.senders[0].codec_payload_type);
1516 EXPECT_EQ(0, info.senders[0].firs_rcvd);
1517 EXPECT_EQ(0, info.senders[0].plis_rcvd);
1518 EXPECT_EQ(0, info.senders[0].nacks_rcvd);
1519 EXPECT_EQ(kVideoWidth, info.senders[0].send_frame_width);
1520 EXPECT_EQ(kVideoHeight, info.senders[0].send_frame_height);
1521 EXPECT_GT(info.senders[0].framerate_input, 0);
1522 EXPECT_GT(info.senders[0].framerate_sent, 0);
1523
1524 EXPECT_EQ(1U, info.send_codecs.count(DefaultCodec().id));
1525 EXPECT_EQ(DefaultCodec().ToCodecParameters(),
1526 info.send_codecs[DefaultCodec().id]);
1527
1528 ASSERT_EQ(1U, info.receivers.size());
1529 EXPECT_EQ(1U, info.senders[0].ssrcs().size());
1530 EXPECT_EQ(1U, info.receivers[0].ssrcs().size());
1531 EXPECT_EQ(info.senders[0].ssrcs()[0], info.receivers[0].ssrcs()[0]);
1532 ASSERT_TRUE(info.receivers[0].codec_payload_type);
1533 EXPECT_EQ(DefaultCodec().id, *info.receivers[0].codec_payload_type);
1534 EXPECT_EQ(NumRtpBytes(), info.receivers[0].bytes_rcvd);
1535 EXPECT_EQ(NumRtpPackets(), info.receivers[0].packets_rcvd);
1536 EXPECT_EQ(0.0, info.receivers[0].fraction_lost);
1537 EXPECT_EQ(0, info.receivers[0].packets_lost);
1538 // TODO(asapersson): Not set for webrtc. Handle missing stats.
1539 // EXPECT_EQ(0, info.receivers[0].packets_concealed);
1540 EXPECT_EQ(0, info.receivers[0].firs_sent);
1541 EXPECT_EQ(0, info.receivers[0].plis_sent);
1542 EXPECT_EQ(0, info.receivers[0].nacks_sent);
1543 EXPECT_EQ(kVideoWidth, info.receivers[0].frame_width);
1544 EXPECT_EQ(kVideoHeight, info.receivers[0].frame_height);
1545 EXPECT_GT(info.receivers[0].framerate_rcvd, 0);
1546 EXPECT_GT(info.receivers[0].framerate_decoded, 0);
1547 EXPECT_GT(info.receivers[0].framerate_output, 0);
1548
1549 EXPECT_EQ(1U, info.receive_codecs.count(DefaultCodec().id));
1550 EXPECT_EQ(DefaultCodec().ToCodecParameters(),
1551 info.receive_codecs[DefaultCodec().id]);
srtee0c2eea2017-12-15 17:44:33 +01001552}
Niels Möller6557d0c2018-04-11 15:18:34 +02001553
1554// Test that stats work properly for a conf call with multiple recv streams.
srtee0c2eea2017-12-15 17:44:33 +01001555TEST_F(WebRtcVideoChannelBaseTest, GetStatsMultipleRecvStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001556 cricket::FakeVideoRenderer renderer1, renderer2;
1557 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1558 cricket::VideoSendParameters parameters;
1559 parameters.codecs.push_back(DefaultCodec());
1560 parameters.conference_mode = true;
1561 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1562 EXPECT_TRUE(SetSend(true));
Yves Gerey665174f2018-06-19 15:03:05 +02001563 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
1564 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001565 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
1566 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
1567 EXPECT_EQ(0, renderer1.num_rendered_frames());
1568 EXPECT_EQ(0, renderer2.num_rendered_frames());
1569 std::vector<uint32_t> ssrcs;
1570 ssrcs.push_back(1);
1571 ssrcs.push_back(2);
1572 network_interface_.SetConferenceMode(true, ssrcs);
Niels Möller805a27e2019-01-21 12:21:27 +01001573 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001574 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kVideoWidth, kVideoHeight,
1575 kTimeout);
1576 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kVideoWidth, kVideoHeight,
1577 kTimeout);
1578
1579 EXPECT_TRUE(channel_->SetSend(false));
1580
1581 cricket::VideoMediaInfo info;
1582 EXPECT_TRUE(channel_->GetStats(&info));
1583 ASSERT_EQ(1U, info.senders.size());
1584 // TODO(whyuan): bytes_sent and bytes_rcvd are different. Are both payload?
1585 // For webrtc, bytes_sent does not include the RTP header length.
1586 EXPECT_GT(GetSenderStats(0).bytes_sent, 0);
1587 EXPECT_EQ_WAIT(NumRtpPackets(), GetSenderStats(0).packets_sent, kTimeout);
1588 EXPECT_EQ(kVideoWidth, GetSenderStats(0).send_frame_width);
1589 EXPECT_EQ(kVideoHeight, GetSenderStats(0).send_frame_height);
1590
1591 ASSERT_EQ(2U, info.receivers.size());
1592 for (size_t i = 0; i < info.receivers.size(); ++i) {
1593 EXPECT_EQ(1U, GetReceiverStats(i).ssrcs().size());
1594 EXPECT_EQ(i + 1, GetReceiverStats(i).ssrcs()[0]);
1595 EXPECT_EQ_WAIT(NumRtpBytes(), GetReceiverStats(i).bytes_rcvd, kTimeout);
Yves Gerey665174f2018-06-19 15:03:05 +02001596 EXPECT_EQ_WAIT(NumRtpPackets(), GetReceiverStats(i).packets_rcvd, kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001597 EXPECT_EQ_WAIT(kVideoWidth, GetReceiverStats(i).frame_width, kTimeout);
1598 EXPECT_EQ_WAIT(kVideoHeight, GetReceiverStats(i).frame_height, kTimeout);
1599 }
srtee0c2eea2017-12-15 17:44:33 +01001600}
Niels Möller6557d0c2018-04-11 15:18:34 +02001601
1602// Test that stats work properly for a conf call with multiple send streams.
srtee0c2eea2017-12-15 17:44:33 +01001603TEST_F(WebRtcVideoChannelBaseTest, GetStatsMultipleSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001604 // Normal setup; note that we set the SSRC explicitly to ensure that
1605 // it will come first in the senders map.
1606 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1607 cricket::VideoSendParameters parameters;
1608 parameters.codecs.push_back(DefaultCodec());
1609 parameters.conference_mode = true;
1610 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Yves Gerey665174f2018-06-19 15:03:05 +02001611 EXPECT_TRUE(
1612 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001613 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
1614 EXPECT_TRUE(SetSend(true));
Niels Möller805a27e2019-01-21 12:21:27 +01001615 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001616 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
1617 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1618
1619 // Add an additional capturer, and hook up a renderer to receive it.
1620 cricket::FakeVideoRenderer renderer2;
Niels Möller805a27e2019-01-21 12:21:27 +01001621 webrtc::test::FrameForwarder frame_forwarder;
Niels Möller6557d0c2018-04-11 15:18:34 +02001622 const int kTestWidth = 160;
1623 const int kTestHeight = 120;
Niels Möller805a27e2019-01-21 12:21:27 +01001624 cricket::FakeFrameSource frame_source(kTestWidth, kTestHeight,
1625 rtc::kNumMicrosecsPerSec / 5);
Yves Gerey665174f2018-06-19 15:03:05 +02001626 EXPECT_TRUE(
1627 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(5678)));
Niels Möller805a27e2019-01-21 12:21:27 +01001628 EXPECT_TRUE(channel_->SetVideoSend(5678, nullptr, &frame_forwarder));
Yves Gerey665174f2018-06-19 15:03:05 +02001629 EXPECT_TRUE(
1630 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(5678)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001631 EXPECT_TRUE(channel_->SetSink(5678, &renderer2));
Niels Möller805a27e2019-01-21 12:21:27 +01001632 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Yves Gerey665174f2018-06-19 15:03:05 +02001633 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kTestWidth, kTestHeight,
1634 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001635
1636 // Get stats, and make sure they are correct for two senders. We wait until
1637 // the number of expected packets have been sent to avoid races where we
1638 // check stats before it has been updated.
1639 cricket::VideoMediaInfo info;
1640 for (uint32_t i = 0; i < kTimeout; ++i) {
1641 rtc::Thread::Current()->ProcessMessages(1);
1642 EXPECT_TRUE(channel_->GetStats(&info));
1643 ASSERT_EQ(2U, info.senders.size());
1644 if (info.senders[0].packets_sent + info.senders[1].packets_sent ==
1645 NumRtpPackets()) {
1646 // Stats have been updated for both sent frames, expectations can be
1647 // checked now.
1648 break;
1649 }
1650 }
1651 EXPECT_EQ(NumRtpPackets(),
1652 info.senders[0].packets_sent + info.senders[1].packets_sent)
1653 << "Timed out while waiting for packet counts for all sent packets.";
1654 EXPECT_EQ(1U, info.senders[0].ssrcs().size());
1655 EXPECT_EQ(1234U, info.senders[0].ssrcs()[0]);
1656 EXPECT_EQ(kVideoWidth, info.senders[0].send_frame_width);
1657 EXPECT_EQ(kVideoHeight, info.senders[0].send_frame_height);
1658 EXPECT_EQ(1U, info.senders[1].ssrcs().size());
1659 EXPECT_EQ(5678U, info.senders[1].ssrcs()[0]);
1660 EXPECT_EQ(kTestWidth, info.senders[1].send_frame_width);
1661 EXPECT_EQ(kTestHeight, info.senders[1].send_frame_height);
1662 // The capturer must be unregistered here as it runs out of it's scope next.
1663 channel_->SetVideoSend(5678, nullptr, nullptr);
srtee0c2eea2017-12-15 17:44:33 +01001664}
pbos@webrtc.org8fdeee62014-07-20 14:40:23 +00001665
Niels Möller6557d0c2018-04-11 15:18:34 +02001666// Test that we can set the bandwidth.
srtee0c2eea2017-12-15 17:44:33 +01001667TEST_F(WebRtcVideoChannelBaseTest, SetSendBandwidth) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001668 cricket::VideoSendParameters parameters;
1669 parameters.codecs.push_back(DefaultCodec());
1670 parameters.max_bandwidth_bps = -1; // <= 0 means unlimited.
1671 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1672 parameters.max_bandwidth_bps = 128 * 1024;
1673 EXPECT_TRUE(channel_->SetSendParameters(parameters));
srtee0c2eea2017-12-15 17:44:33 +01001674}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001675
Niels Möller6557d0c2018-04-11 15:18:34 +02001676// Test that we can set the SSRC for the default send source.
srtee0c2eea2017-12-15 17:44:33 +01001677TEST_F(WebRtcVideoChannelBaseTest, SetSendSsrc) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001678 EXPECT_TRUE(SetDefaultCodec());
1679 EXPECT_TRUE(SetSend(true));
Niels Möller805a27e2019-01-21 12:21:27 +01001680 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001681 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001682 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001683 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001684 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1685 EXPECT_EQ(kSsrc, header.ssrc);
1686
Niels Möller6557d0c2018-04-11 15:18:34 +02001687 // Packets are being paced out, so these can mismatch between the first and
1688 // second call to NumRtpPackets until pending packets are paced out.
Åsa Persson23cd45a2018-07-03 10:40:40 +02001689 EXPECT_EQ_WAIT(NumRtpPackets(), NumRtpPackets(header.ssrc), kTimeout);
1690 EXPECT_EQ_WAIT(NumRtpBytes(), NumRtpBytes(header.ssrc), kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001691 EXPECT_EQ(1, NumSentSsrcs());
1692 EXPECT_EQ(0, NumRtpPackets(kSsrc - 1));
1693 EXPECT_EQ(0, NumRtpBytes(kSsrc - 1));
srtee0c2eea2017-12-15 17:44:33 +01001694}
Niels Möller6557d0c2018-04-11 15:18:34 +02001695
1696// Test that we can set the SSRC even after codecs are set.
srtee0c2eea2017-12-15 17:44:33 +01001697TEST_F(WebRtcVideoChannelBaseTest, SetSendSsrcAfterSetCodecs) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001698 // Remove stream added in Setup.
1699 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1700 EXPECT_TRUE(SetDefaultCodec());
Niels Möller6557d0c2018-04-11 15:18:34 +02001701 EXPECT_TRUE(
Yves Gerey665174f2018-06-19 15:03:05 +02001702 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(999)));
Niels Möller805a27e2019-01-21 12:21:27 +01001703 EXPECT_TRUE(channel_->SetVideoSend(999u, nullptr, frame_forwarder_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001704 EXPECT_TRUE(SetSend(true));
1705 EXPECT_TRUE(WaitAndSendFrame(0));
1706 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001707 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001708 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001709 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1710 EXPECT_EQ(999u, header.ssrc);
Niels Möller6557d0c2018-04-11 15:18:34 +02001711 // Packets are being paced out, so these can mismatch between the first and
1712 // second call to NumRtpPackets until pending packets are paced out.
Åsa Persson23cd45a2018-07-03 10:40:40 +02001713 EXPECT_EQ_WAIT(NumRtpPackets(), NumRtpPackets(header.ssrc), kTimeout);
1714 EXPECT_EQ_WAIT(NumRtpBytes(), NumRtpBytes(header.ssrc), kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001715 EXPECT_EQ(1, NumSentSsrcs());
1716 EXPECT_EQ(0, NumRtpPackets(kSsrc));
1717 EXPECT_EQ(0, NumRtpBytes(kSsrc));
srtee0c2eea2017-12-15 17:44:33 +01001718}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001719
Niels Möller6557d0c2018-04-11 15:18:34 +02001720// Test that we can set the default video renderer before and after
1721// media is received.
srtee0c2eea2017-12-15 17:44:33 +01001722TEST_F(WebRtcVideoChannelBaseTest, SetSink) {
Yves Gerey665174f2018-06-19 15:03:05 +02001723 uint8_t data1[] = {0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
1724 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
Niels Möller6557d0c2018-04-11 15:18:34 +02001725
1726 rtc::CopyOnWriteBuffer packet1(data1, sizeof(data1));
1727 rtc::SetBE32(packet1.data() + 8, kSsrc);
1728 channel_->SetSink(kDefaultReceiveSsrc, NULL);
1729 EXPECT_TRUE(SetDefaultCodec());
1730 EXPECT_TRUE(SetSend(true));
1731 EXPECT_EQ(0, renderer_.num_rendered_frames());
Niels Möllere6933812018-11-05 13:01:41 +01001732 channel_->OnPacketReceived(&packet1, /* packet_time_us */ -1);
Niels Möller6557d0c2018-04-11 15:18:34 +02001733 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
Niels Möller805a27e2019-01-21 12:21:27 +01001734 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001735 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
srtee0c2eea2017-12-15 17:44:33 +01001736}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001737
Niels Möller6557d0c2018-04-11 15:18:34 +02001738// Tests setting up and configuring a send stream.
srtee0c2eea2017-12-15 17:44:33 +01001739TEST_F(WebRtcVideoChannelBaseTest, AddRemoveSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001740 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1741 EXPECT_TRUE(SetSend(true));
1742 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
Niels Möller805a27e2019-01-21 12:21:27 +01001743 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001744 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1745 EXPECT_GT(NumRtpPackets(), 0);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001746 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001747 size_t last_packet = NumRtpPackets() - 1;
Yves Gerey665174f2018-06-19 15:03:05 +02001748 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(
1749 GetRtpPacket(static_cast<int>(last_packet)));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001750 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1751 EXPECT_EQ(kSsrc, header.ssrc);
Niels Möller6557d0c2018-04-11 15:18:34 +02001752
1753 // Remove the send stream that was added during Setup.
1754 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1755 int rtp_packets = NumRtpPackets();
1756
Niels Möller6557d0c2018-04-11 15:18:34 +02001757 EXPECT_TRUE(
Yves Gerey665174f2018-06-19 15:03:05 +02001758 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(789u)));
Niels Möller805a27e2019-01-21 12:21:27 +01001759 EXPECT_TRUE(channel_->SetVideoSend(789u, nullptr, frame_forwarder_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001760 EXPECT_EQ(rtp_packets, NumRtpPackets());
1761 // Wait 30ms to guarantee the engine does not drop the frame.
1762 EXPECT_TRUE(WaitAndSendFrame(30));
1763 EXPECT_TRUE_WAIT(NumRtpPackets() > rtp_packets, kTimeout);
1764
1765 last_packet = NumRtpPackets() - 1;
1766 p.reset(GetRtpPacket(static_cast<int>(last_packet)));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001767 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1768 EXPECT_EQ(789u, header.ssrc);
srtee0c2eea2017-12-15 17:44:33 +01001769}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001770
Niels Möller6557d0c2018-04-11 15:18:34 +02001771// Tests the behavior of incoming streams in a conference scenario.
srtee0c2eea2017-12-15 17:44:33 +01001772TEST_F(WebRtcVideoChannelBaseTest, SimulateConference) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001773 cricket::FakeVideoRenderer renderer1, renderer2;
1774 EXPECT_TRUE(SetDefaultCodec());
1775 cricket::VideoSendParameters parameters;
1776 parameters.codecs.push_back(DefaultCodec());
1777 parameters.conference_mode = true;
1778 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1779 EXPECT_TRUE(SetSend(true));
Yves Gerey665174f2018-06-19 15:03:05 +02001780 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
1781 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001782 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
1783 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
1784 EXPECT_EQ(0, renderer1.num_rendered_frames());
1785 EXPECT_EQ(0, renderer2.num_rendered_frames());
1786 std::vector<uint32_t> ssrcs;
1787 ssrcs.push_back(1);
1788 ssrcs.push_back(2);
1789 network_interface_.SetConferenceMode(true, ssrcs);
Niels Möller805a27e2019-01-21 12:21:27 +01001790 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001791 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kVideoWidth, kVideoHeight,
1792 kTimeout);
1793 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kVideoWidth, kVideoHeight,
1794 kTimeout);
1795
1796 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1797 EXPECT_EQ(DefaultCodec().id, GetPayloadType(p.get()));
1798 EXPECT_EQ(kVideoWidth, renderer1.width());
1799 EXPECT_EQ(kVideoHeight, renderer1.height());
1800 EXPECT_EQ(kVideoWidth, renderer2.width());
1801 EXPECT_EQ(kVideoHeight, renderer2.height());
1802 EXPECT_TRUE(channel_->RemoveRecvStream(2));
1803 EXPECT_TRUE(channel_->RemoveRecvStream(1));
srtee0c2eea2017-12-15 17:44:33 +01001804}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001805
Niels Möller6557d0c2018-04-11 15:18:34 +02001806// Tests that we can add and remove capturers and frames are sent out properly
srtee0c2eea2017-12-15 17:44:33 +01001807TEST_F(WebRtcVideoChannelBaseTest, DISABLED_AddRemoveCapturer) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001808 using cricket::VideoCodec;
1809 using cricket::VideoOptions;
1810 using cricket::VideoFormat;
1811 using cricket::FOURCC_I420;
1812
1813 VideoCodec codec = DefaultCodec();
1814 const int time_between_send_ms = VideoFormat::FpsToInterval(kFramerate);
1815 EXPECT_TRUE(SetOneCodec(codec));
1816 EXPECT_TRUE(SetSend(true));
1817 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1818 EXPECT_EQ(0, renderer_.num_rendered_frames());
Niels Möller805a27e2019-01-21 12:21:27 +01001819 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001820 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
Niels Möller805a27e2019-01-21 12:21:27 +01001821
1822 webrtc::test::FrameForwarder frame_forwarder;
1823 cricket::FakeFrameSource frame_source(480, 360, rtc::kNumMicrosecsPerSec / 30,
1824 rtc::kNumMicrosecsPerSec / 30);
Niels Möller6557d0c2018-04-11 15:18:34 +02001825
1826 // TODO(nisse): This testcase fails if we don't configure
1827 // screencast. It's unclear why, I see nothing obvious in this
1828 // test which is related to screencast logic.
1829 VideoOptions video_options;
1830 video_options.is_screencast = true;
1831 channel_->SetVideoSend(kSsrc, &video_options, nullptr);
1832
Niels Möller6557d0c2018-04-11 15:18:34 +02001833 int captured_frames = 1;
1834 for (int iterations = 0; iterations < 2; ++iterations) {
Niels Möller805a27e2019-01-21 12:21:27 +01001835 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
Niels Möller6557d0c2018-04-11 15:18:34 +02001836 rtc::Thread::Current()->ProcessMessages(time_between_send_ms);
Niels Möller805a27e2019-01-21 12:21:27 +01001837 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
1838
Niels Möller6557d0c2018-04-11 15:18:34 +02001839 ++captured_frames;
1840 // Wait until frame of right size is captured.
1841 EXPECT_TRUE_WAIT(renderer_.num_rendered_frames() >= captured_frames &&
Niels Möller805a27e2019-01-21 12:21:27 +01001842 480 == renderer_.width() &&
1843 360 == renderer_.height() && !renderer_.black_frame(),
Yves Gerey665174f2018-06-19 15:03:05 +02001844 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001845 EXPECT_GE(renderer_.num_rendered_frames(), captured_frames);
Niels Möller805a27e2019-01-21 12:21:27 +01001846 EXPECT_EQ(480, renderer_.width());
1847 EXPECT_EQ(360, renderer_.height());
Niels Möller6557d0c2018-04-11 15:18:34 +02001848 captured_frames = renderer_.num_rendered_frames() + 1;
1849 EXPECT_FALSE(renderer_.black_frame());
1850 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1851 // Make sure a black frame is generated within the specified timeout.
1852 // The black frame should be the resolution of the previous frame to
1853 // prevent expensive encoder reconfigurations.
1854 EXPECT_TRUE_WAIT(renderer_.num_rendered_frames() >= captured_frames &&
Niels Möller805a27e2019-01-21 12:21:27 +01001855 480 == renderer_.width() &&
1856 360 == renderer_.height() && renderer_.black_frame(),
Yves Gerey665174f2018-06-19 15:03:05 +02001857 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001858 EXPECT_GE(renderer_.num_rendered_frames(), captured_frames);
Niels Möller805a27e2019-01-21 12:21:27 +01001859 EXPECT_EQ(480, renderer_.width());
1860 EXPECT_EQ(360, renderer_.height());
Niels Möller6557d0c2018-04-11 15:18:34 +02001861 EXPECT_TRUE(renderer_.black_frame());
1862
1863 // The black frame has the same timestamp as the next frame since it's
1864 // timestamp is set to the last frame's timestamp + interval. WebRTC will
1865 // not render a frame with the same timestamp so capture another frame
1866 // with the frame capturer to increment the next frame's timestamp.
Niels Möller805a27e2019-01-21 12:21:27 +01001867 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller6557d0c2018-04-11 15:18:34 +02001868 }
srtee0c2eea2017-12-15 17:44:33 +01001869}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001870
Niels Möller6557d0c2018-04-11 15:18:34 +02001871// Tests that if SetVideoSend is called with a NULL capturer after the
1872// capturer was already removed, the application doesn't crash (and no black
1873// frame is sent).
srtee0c2eea2017-12-15 17:44:33 +01001874TEST_F(WebRtcVideoChannelBaseTest, RemoveCapturerWithoutAdd) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001875 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1876 EXPECT_TRUE(SetSend(true));
1877 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1878 EXPECT_EQ(0, renderer_.num_rendered_frames());
Niels Möller805a27e2019-01-21 12:21:27 +01001879 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001880 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1881 // Wait for one frame so they don't get dropped because we send frames too
1882 // tightly.
1883 rtc::Thread::Current()->ProcessMessages(30);
1884 // Remove the capturer.
1885 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1886
1887 // No capturer was added, so this SetVideoSend shouldn't do anything.
1888 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1889 rtc::Thread::Current()->ProcessMessages(300);
1890 // Verify no more frames were sent.
1891 EXPECT_EQ(1, renderer_.num_rendered_frames());
srtee0c2eea2017-12-15 17:44:33 +01001892}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001893
Niels Möller6557d0c2018-04-11 15:18:34 +02001894// Tests that we can add and remove capturer as unique sources.
srtee0c2eea2017-12-15 17:44:33 +01001895TEST_F(WebRtcVideoChannelBaseTest, AddRemoveCapturerMultipleSources) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001896 // WebRTC implementation will drop frames if pushed to quickly. Wait the
1897 // interval time to avoid that.
1898 // WebRTC implementation will drop frames if pushed to quickly. Wait the
1899 // interval time to avoid that.
1900 // Set up the stream associated with the engine.
Yves Gerey665174f2018-06-19 15:03:05 +02001901 EXPECT_TRUE(
1902 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001903 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
1904 cricket::VideoFormat capture_format(
1905 kVideoWidth, kVideoHeight,
1906 cricket::VideoFormat::FpsToInterval(kFramerate), cricket::FOURCC_I420);
1907 // Set up additional stream 1.
1908 cricket::FakeVideoRenderer renderer1;
1909 EXPECT_FALSE(channel_->SetSink(1, &renderer1));
Yves Gerey665174f2018-06-19 15:03:05 +02001910 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001911 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
Yves Gerey665174f2018-06-19 15:03:05 +02001912 EXPECT_TRUE(channel_->AddSendStream(cricket::StreamParams::CreateLegacy(1)));
Niels Möller805a27e2019-01-21 12:21:27 +01001913
1914 webrtc::test::FrameForwarder frame_forwarder1;
1915 cricket::FakeFrameSource frame_source(kVideoWidth, kVideoHeight,
1916 rtc::kNumMicrosecsPerSec / kFramerate);
1917
Niels Möller6557d0c2018-04-11 15:18:34 +02001918 // Set up additional stream 2.
1919 cricket::FakeVideoRenderer renderer2;
1920 EXPECT_FALSE(channel_->SetSink(2, &renderer2));
Yves Gerey665174f2018-06-19 15:03:05 +02001921 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001922 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
Yves Gerey665174f2018-06-19 15:03:05 +02001923 EXPECT_TRUE(channel_->AddSendStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller805a27e2019-01-21 12:21:27 +01001924 webrtc::test::FrameForwarder frame_forwarder2;
1925
Niels Möller6557d0c2018-04-11 15:18:34 +02001926 // State for all the streams.
1927 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1928 // A limitation in the lmi implementation requires that SetVideoSend() is
1929 // called after SetOneCodec().
1930 // TODO(hellner): this seems like an unnecessary constraint, fix it.
Niels Möller805a27e2019-01-21 12:21:27 +01001931 EXPECT_TRUE(channel_->SetVideoSend(1, nullptr, &frame_forwarder1));
1932 EXPECT_TRUE(channel_->SetVideoSend(2, nullptr, &frame_forwarder2));
Niels Möller6557d0c2018-04-11 15:18:34 +02001933 EXPECT_TRUE(SetSend(true));
1934 // Test capturer associated with engine.
1935 const int kTestWidth = 160;
1936 const int kTestHeight = 120;
Niels Möller805a27e2019-01-21 12:21:27 +01001937 frame_forwarder1.IncomingCapturedFrame(frame_source.GetFrame(
1938 kTestWidth, kTestHeight, webrtc::VideoRotation::kVideoRotation_0,
1939 rtc::kNumMicrosecsPerSec / kFramerate));
Yves Gerey665174f2018-06-19 15:03:05 +02001940 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kTestWidth, kTestHeight,
1941 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001942 // Capture a frame with additional capturer2, frames should be received
Niels Möller805a27e2019-01-21 12:21:27 +01001943 frame_forwarder2.IncomingCapturedFrame(frame_source.GetFrame(
1944 kTestWidth, kTestHeight, webrtc::VideoRotation::kVideoRotation_0,
1945 rtc::kNumMicrosecsPerSec / kFramerate));
Yves Gerey665174f2018-06-19 15:03:05 +02001946 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kTestWidth, kTestHeight,
1947 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001948 // Successfully remove the capturer.
1949 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1950 // The capturers must be unregistered here as it runs out of it's scope
1951 // next.
1952 EXPECT_TRUE(channel_->SetVideoSend(1, nullptr, nullptr));
1953 EXPECT_TRUE(channel_->SetVideoSend(2, nullptr, nullptr));
srtee0c2eea2017-12-15 17:44:33 +01001954}
Niels Möller6557d0c2018-04-11 15:18:34 +02001955
1956// Tests empty StreamParams is rejected.
srtee0c2eea2017-12-15 17:44:33 +01001957TEST_F(WebRtcVideoChannelBaseTest, RejectEmptyStreamParams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001958 // Remove the send stream that was added during Setup.
1959 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1960
1961 cricket::StreamParams empty;
1962 EXPECT_FALSE(channel_->AddSendStream(empty));
Yves Gerey665174f2018-06-19 15:03:05 +02001963 EXPECT_TRUE(
1964 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(789u)));
srtee0c2eea2017-12-15 17:44:33 +01001965}
Niels Möller6557d0c2018-04-11 15:18:34 +02001966
1967// Test that multiple send streams can be created and deleted properly.
srtee0c2eea2017-12-15 17:44:33 +01001968TEST_F(WebRtcVideoChannelBaseTest, MultipleSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001969 // Remove stream added in Setup. I.e. remove stream corresponding to default
1970 // channel.
1971 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02001972 const unsigned int kSsrcsSize = sizeof(kSsrcs4) / sizeof(kSsrcs4[0]);
Niels Möller6557d0c2018-04-11 15:18:34 +02001973 for (unsigned int i = 0; i < kSsrcsSize; ++i) {
1974 EXPECT_TRUE(channel_->AddSendStream(
1975 cricket::StreamParams::CreateLegacy(kSsrcs4[i])));
1976 }
1977 // Delete one of the non default channel streams, let the destructor delete
1978 // the remaining ones.
1979 EXPECT_TRUE(channel_->RemoveSendStream(kSsrcs4[kSsrcsSize - 1]));
1980 // Stream should already be deleted.
1981 EXPECT_FALSE(channel_->RemoveSendStream(kSsrcs4[kSsrcsSize - 1]));
srtee0c2eea2017-12-15 17:44:33 +01001982}
pbos@webrtc.orgc4175b92014-09-03 15:25:49 +00001983
eladalonf1841382017-06-12 01:16:46 -07001984TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8Vga) {
magjed509e4fe2016-11-18 01:34:11 -08001985 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00001986}
1987
eladalonf1841382017-06-12 01:16:46 -07001988TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8Qvga) {
magjed509e4fe2016-11-18 01:34:11 -08001989 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00001990}
1991
eladalonf1841382017-06-12 01:16:46 -07001992TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8SvcQqvga) {
magjed509e4fe2016-11-18 01:34:11 -08001993 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00001994}
1995
eladalonf1841382017-06-12 01:16:46 -07001996TEST_F(WebRtcVideoChannelBaseTest, TwoStreamsSendAndReceive) {
Peter Boströmd1f584b2016-04-20 16:31:53 +02001997 // Set a high bitrate to not be downscaled by VP8 due to low initial start
1998 // bitrates. This currently happens at <250k, and two streams sharing 300k
1999 // initially will use QVGA instead of VGA.
2000 // TODO(pbos): Set up the quality scaler so that both senders reliably start
2001 // at QVGA, then verify that instead.
magjed509e4fe2016-11-18 01:34:11 -08002002 cricket::VideoCodec codec = GetEngineCodec("VP8");
Peter Boströmd1f584b2016-04-20 16:31:53 +02002003 codec.params[kCodecParamStartBitrate] = "1000000";
Niels Möller6557d0c2018-04-11 15:18:34 +02002004 TwoStreamsSendAndReceive(codec);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002005}
2006
eladalonf1841382017-06-12 01:16:46 -07002007class WebRtcVideoChannelTest : public WebRtcVideoEngineTest {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002008 public:
eladalonf1841382017-06-12 01:16:46 -07002009 WebRtcVideoChannelTest() : WebRtcVideoChannelTest("") {}
2010 explicit WebRtcVideoChannelTest(const char* field_trials)
Niels Möller805a27e2019-01-21 12:21:27 +01002011 : WebRtcVideoEngineTest(field_trials),
2012 frame_source_(1280, 720, rtc::kNumMicrosecsPerSec / 30),
2013 last_ssrc_(0) {}
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00002014 void SetUp() override {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02002015 encoder_factory_->AddSupportedVideoCodecType("VP8");
2016 encoder_factory_->AddSupportedVideoCodecType("VP9");
2017#if defined(WEBRTC_USE_H264)
2018 encoder_factory_->AddSupportedVideoCodecType("H264");
2019#endif
2020
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002021 fake_call_.reset(new FakeCall());
Sebastian Jansson84848f22018-11-16 10:40:36 +01002022 channel_.reset(engine_.CreateMediaChannel(fake_call_.get(),
2023 GetMediaConfig(), VideoOptions(),
2024 webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002025 channel_->OnReadyToSend(true);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002026 last_ssrc_ = 123;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002027 send_parameters_.codecs = engine_.codecs();
2028 recv_parameters_.codecs = engine_.codecs();
2029 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002030 }
2031
2032 protected:
2033 FakeVideoSendStream* AddSendStream() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002034 return AddSendStream(StreamParams::CreateLegacy(++last_ssrc_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002035 }
2036
2037 FakeVideoSendStream* AddSendStream(const StreamParams& sp) {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002038 size_t num_streams = fake_call_->GetVideoSendStreams().size();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002039 EXPECT_TRUE(channel_->AddSendStream(sp));
2040 std::vector<FakeVideoSendStream*> streams =
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002041 fake_call_->GetVideoSendStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002042 EXPECT_EQ(num_streams + 1, streams.size());
2043 return streams[streams.size() - 1];
2044 }
2045
2046 std::vector<FakeVideoSendStream*> GetFakeSendStreams() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002047 return fake_call_->GetVideoSendStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002048 }
2049
2050 FakeVideoReceiveStream* AddRecvStream() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002051 return AddRecvStream(StreamParams::CreateLegacy(++last_ssrc_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002052 }
2053
2054 FakeVideoReceiveStream* AddRecvStream(const StreamParams& sp) {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002055 size_t num_streams = fake_call_->GetVideoReceiveStreams().size();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002056 EXPECT_TRUE(channel_->AddRecvStream(sp));
2057 std::vector<FakeVideoReceiveStream*> streams =
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002058 fake_call_->GetVideoReceiveStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002059 EXPECT_EQ(num_streams + 1, streams.size());
2060 return streams[streams.size() - 1];
2061 }
2062
pbos@webrtc.org00873182014-11-25 14:03:34 +00002063 void SetSendCodecsShouldWorkForBitrates(const char* min_bitrate_kbps,
2064 int expected_min_bitrate_bps,
2065 const char* start_bitrate_kbps,
2066 int expected_start_bitrate_bps,
2067 const char* max_bitrate_kbps,
2068 int expected_max_bitrate_bps) {
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002069 ExpectSetBitrateParameters(expected_min_bitrate_bps,
2070 expected_start_bitrate_bps,
2071 expected_max_bitrate_bps);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002072 auto& codecs = send_parameters_.codecs;
2073 codecs.clear();
magjed509e4fe2016-11-18 01:34:11 -08002074 codecs.push_back(GetEngineCodec("VP8"));
pbos@webrtc.org00873182014-11-25 14:03:34 +00002075 codecs[0].params[kCodecParamMinBitrate] = min_bitrate_kbps;
2076 codecs[0].params[kCodecParamStartBitrate] = start_bitrate_kbps;
2077 codecs[0].params[kCodecParamMaxBitrate] = max_bitrate_kbps;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002078 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002079 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002080
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002081 void ExpectSetBitrateParameters(int min_bitrate_bps,
2082 int start_bitrate_bps,
2083 int max_bitrate_bps) {
2084 EXPECT_CALL(
2085 *fake_call_->GetMockTransportControllerSend(),
2086 SetSdpBitrateParameters(AllOf(
2087 Field(&BitrateConstraints::min_bitrate_bps, min_bitrate_bps),
2088 Field(&BitrateConstraints::start_bitrate_bps, start_bitrate_bps),
2089 Field(&BitrateConstraints::max_bitrate_bps, max_bitrate_bps))));
2090 }
2091
2092 void ExpectSetMaxBitrate(int max_bitrate_bps) {
2093 EXPECT_CALL(*fake_call_->GetMockTransportControllerSend(),
2094 SetSdpBitrateParameters(Field(
2095 &BitrateConstraints::max_bitrate_bps, max_bitrate_bps)));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002096 }
2097
Johannes Kron9190b822018-10-29 11:22:05 +01002098 void TestExtmapAllowMixedCaller(bool extmap_allow_mixed) {
2099 // For a caller, the answer will be applied in set remote description
2100 // where SetSendParameters() is called.
2101 EXPECT_TRUE(
2102 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
2103 send_parameters_.extmap_allow_mixed = extmap_allow_mixed;
2104 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
2105 const webrtc::VideoSendStream::Config& config =
2106 fake_call_->GetVideoSendStreams()[0]->GetConfig();
2107 EXPECT_EQ(extmap_allow_mixed, config.rtp.extmap_allow_mixed);
2108 }
2109
2110 void TestExtmapAllowMixedCallee(bool extmap_allow_mixed) {
2111 // For a callee, the answer will be applied in set local description
2112 // where SetExtmapAllowMixed() and AddSendStream() are called.
2113 channel_->SetExtmapAllowMixed(extmap_allow_mixed);
2114 EXPECT_TRUE(
2115 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
2116 const webrtc::VideoSendStream::Config& config =
2117 fake_call_->GetVideoSendStreams()[0]->GetConfig();
2118 EXPECT_EQ(extmap_allow_mixed, config.rtp.extmap_allow_mixed);
2119 }
2120
isheriff6f8d6862016-05-26 11:24:55 -07002121 void TestSetSendRtpHeaderExtensions(const std::string& ext_uri) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002122 // Enable extension.
2123 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002124 cricket::VideoSendParameters parameters = send_parameters_;
isheriff6f8d6862016-05-26 11:24:55 -07002125 parameters.extensions.push_back(RtpExtension(ext_uri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002126 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002127 FakeVideoSendStream* send_stream =
2128 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2129
2130 // Verify the send extension id.
2131 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2132 EXPECT_EQ(id, send_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002133 EXPECT_EQ(ext_uri, send_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002134 // Verify call with same set of extensions returns true.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002135 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002136 // Verify that SetSendRtpHeaderExtensions doesn't implicitly add them for
2137 // receivers.
2138 EXPECT_TRUE(AddRecvStream(cricket::StreamParams::CreateLegacy(123))
2139 ->GetConfig()
2140 .rtp.extensions.empty());
2141
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002142 // Verify that existing RTP header extensions can be removed.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002143 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002144 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2145 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002146 EXPECT_TRUE(send_stream->GetConfig().rtp.extensions.empty());
2147
2148 // Verify that adding receive RTP header extensions adds them for existing
2149 // streams.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002150 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002151 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002152 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2153 EXPECT_EQ(id, send_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002154 EXPECT_EQ(ext_uri, send_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002155 }
2156
isheriff6f8d6862016-05-26 11:24:55 -07002157 void TestSetRecvRtpHeaderExtensions(const std::string& ext_uri) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002158 // Enable extension.
2159 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002160 cricket::VideoRecvParameters parameters = recv_parameters_;
isheriff6f8d6862016-05-26 11:24:55 -07002161 parameters.extensions.push_back(RtpExtension(ext_uri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002162 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002163
2164 FakeVideoReceiveStream* recv_stream =
2165 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2166
2167 // Verify the recv extension id.
2168 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
2169 EXPECT_EQ(id, recv_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002170 EXPECT_EQ(ext_uri, recv_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002171 // Verify call with same set of extensions returns true.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002172 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002173
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002174 // Verify that SetRecvRtpHeaderExtensions doesn't implicitly add them for
2175 // senders.
2176 EXPECT_TRUE(AddSendStream(cricket::StreamParams::CreateLegacy(123))
2177 ->GetConfig()
2178 .rtp.extensions.empty());
2179
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002180 // Verify that existing RTP header extensions can be removed.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002181 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002182 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
2183 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002184 EXPECT_TRUE(recv_stream->GetConfig().rtp.extensions.empty());
2185
2186 // Verify that adding receive RTP header extensions adds them for existing
2187 // streams.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002188 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002189 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002190 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
2191 EXPECT_EQ(id, recv_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002192 EXPECT_EQ(ext_uri, recv_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002193 }
2194
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002195 void TestExtensionFilter(const std::vector<std::string>& extensions,
2196 const std::string& expected_extension) {
2197 cricket::VideoSendParameters parameters = send_parameters_;
2198 int expected_id = -1;
2199 int id = 1;
2200 for (const std::string& extension : extensions) {
2201 if (extension == expected_extension)
2202 expected_id = id;
isheriff6f8d6862016-05-26 11:24:55 -07002203 parameters.extensions.push_back(RtpExtension(extension, id++));
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002204 }
2205 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2206 FakeVideoSendStream* send_stream =
2207 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2208
2209 // Verify that only one of them has been set, and that it is the one with
2210 // highest priority (transport sequence number).
2211 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2212 EXPECT_EQ(expected_id, send_stream->GetConfig().rtp.extensions[0].id);
2213 EXPECT_EQ(expected_extension,
isheriff6f8d6862016-05-26 11:24:55 -07002214 send_stream->GetConfig().rtp.extensions[0].uri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002215 }
2216
asapersson3c81a1a2017-06-14 05:52:21 -07002217 void TestDegradationPreference(bool resolution_scaling_enabled,
2218 bool fps_scaling_enabled);
2219
Erik Språngefbde372015-04-29 16:21:28 +02002220 void TestCpuAdaptation(bool enable_overuse, bool is_screenshare);
Peter Boström3548dd22015-05-22 18:48:36 +02002221 void TestReceiverLocalSsrcConfiguration(bool receiver_first);
magjed509e4fe2016-11-18 01:34:11 -08002222 void TestReceiveUnsignaledSsrcPacket(uint8_t payload_type,
2223 bool expect_created_receive_stream);
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002224
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002225 FakeVideoSendStream* SetDenoisingOption(
nisse05103312016-03-16 02:22:50 -07002226 uint32_t ssrc,
Niels Möller805a27e2019-01-21 12:21:27 +01002227 webrtc::test::FrameForwarder* frame_forwarder,
nisse0db023a2016-03-01 04:29:59 -08002228 bool enabled) {
nisse05103312016-03-16 02:22:50 -07002229 cricket::VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002230 options.video_noise_reduction = enabled;
Niels Möller805a27e2019-01-21 12:21:27 +01002231 EXPECT_TRUE(channel_->SetVideoSend(ssrc, &options, frame_forwarder));
nisse0db023a2016-03-01 04:29:59 -08002232 // Options only take effect on the next frame.
Niels Möller805a27e2019-01-21 12:21:27 +01002233 frame_forwarder->IncomingCapturedFrame(frame_source_.GetFrame());
nisse0db023a2016-03-01 04:29:59 -08002234
Erik Språng143cec12015-04-28 10:01:41 +02002235 return fake_call_->GetVideoSendStreams().back();
2236 }
2237
Peter Boström2feafdb2015-09-09 14:32:14 +02002238 FakeVideoSendStream* SetUpSimulcast(bool enabled, bool with_rtx) {
2239 const int kRtxSsrcOffset = 0xDEADBEEF;
Erik Språng143cec12015-04-28 10:01:41 +02002240 last_ssrc_ += 3;
Peter Boström2feafdb2015-09-09 14:32:14 +02002241 std::vector<uint32_t> ssrcs;
2242 std::vector<uint32_t> rtx_ssrcs;
2243 uint32_t num_streams = enabled ? 3 : 1;
2244 for (uint32_t i = 0; i < num_streams; ++i) {
2245 uint32_t ssrc = last_ssrc_ + i;
2246 ssrcs.push_back(ssrc);
2247 if (with_rtx) {
2248 rtx_ssrcs.push_back(ssrc + kRtxSsrcOffset);
2249 }
Erik Språng143cec12015-04-28 10:01:41 +02002250 }
Peter Boström2feafdb2015-09-09 14:32:14 +02002251 if (with_rtx) {
2252 return AddSendStream(
2253 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
2254 }
2255 return AddSendStream(CreateSimStreamParams("cname", ssrcs));
Erik Språng143cec12015-04-28 10:01:41 +02002256 }
2257
perkjfa10b552016-10-02 23:45:26 -07002258 int GetMaxEncoderBitrate() {
skvladdc1c62c2016-03-16 19:07:43 -07002259 std::vector<FakeVideoSendStream*> streams =
2260 fake_call_->GetVideoSendStreams();
perkjfa10b552016-10-02 23:45:26 -07002261 EXPECT_EQ(1u, streams.size());
skvladdc1c62c2016-03-16 19:07:43 -07002262 FakeVideoSendStream* stream = streams[streams.size() - 1];
Mirko Bonadeif859e552018-05-30 15:31:29 +02002263 EXPECT_EQ(1u, stream->GetEncoderConfig().number_of_streams);
perkjfa10b552016-10-02 23:45:26 -07002264 return stream->GetVideoStreams()[0].max_bitrate_bps;
skvladdc1c62c2016-03-16 19:07:43 -07002265 }
2266
perkjfa10b552016-10-02 23:45:26 -07002267 void SetAndExpectMaxBitrate(int global_max,
skvladdc1c62c2016-03-16 19:07:43 -07002268 int stream_max,
2269 int expected_encoder_bitrate) {
2270 VideoSendParameters limited_send_params = send_parameters_;
2271 limited_send_params.max_bandwidth_bps = global_max;
2272 EXPECT_TRUE(channel_->SetSendParameters(limited_send_params));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07002273 webrtc::RtpParameters parameters =
2274 channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07002275 EXPECT_EQ(1UL, parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01002276 parameters.encodings[0].max_bitrate_bps = stream_max;
Zach Steinba37b4b2018-01-23 15:02:36 -08002277 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07002278 // Read back the parameteres and verify they have the correct value
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07002279 parameters = channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07002280 EXPECT_EQ(1UL, parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01002281 EXPECT_EQ(stream_max, parameters.encodings[0].max_bitrate_bps);
skvladdc1c62c2016-03-16 19:07:43 -07002282 // Verify that the new value propagated down to the encoder
perkjfa10b552016-10-02 23:45:26 -07002283 EXPECT_EQ(expected_encoder_bitrate, GetMaxEncoderBitrate());
skvladdc1c62c2016-03-16 19:07:43 -07002284 }
2285
Åsa Persson55659812018-06-18 17:51:32 +02002286 // Values from kSimulcastConfigs in simulcast.cc.
2287 const std::vector<webrtc::VideoStream> GetSimulcastBitrates720p() const {
2288 std::vector<webrtc::VideoStream> layers(3);
2289 layers[0].min_bitrate_bps = 30000;
2290 layers[0].target_bitrate_bps = 150000;
2291 layers[0].max_bitrate_bps = 200000;
2292 layers[1].min_bitrate_bps = 150000;
2293 layers[1].target_bitrate_bps = 500000;
2294 layers[1].max_bitrate_bps = 700000;
2295 layers[2].min_bitrate_bps = 600000;
2296 layers[2].target_bitrate_bps = 2500000;
2297 layers[2].max_bitrate_bps = 2500000;
2298 return layers;
2299 }
2300
Niels Möller805a27e2019-01-21 12:21:27 +01002301 cricket::FakeFrameSource frame_source_;
kwiberg686a8ef2016-02-26 03:00:35 -08002302 std::unique_ptr<FakeCall> fake_call_;
2303 std::unique_ptr<VideoMediaChannel> channel_;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002304 cricket::VideoSendParameters send_parameters_;
2305 cricket::VideoRecvParameters recv_parameters_;
Peter Boström0c4e06b2015-10-07 12:23:21 +02002306 uint32_t last_ssrc_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002307};
2308
eladalonf1841382017-06-12 01:16:46 -07002309TEST_F(WebRtcVideoChannelTest, SetsSyncGroupFromSyncLabel) {
Peter Boström0c4e06b2015-10-07 12:23:21 +02002310 const uint32_t kVideoSsrc = 123;
pbos8fc7fa72015-07-15 08:02:58 -07002311 const std::string kSyncLabel = "AvSyncLabel";
2312
2313 cricket::StreamParams sp = cricket::StreamParams::CreateLegacy(kVideoSsrc);
Seth Hampson845e8782018-03-02 11:34:10 -08002314 sp.set_stream_ids({kSyncLabel});
pbos8fc7fa72015-07-15 08:02:58 -07002315 EXPECT_TRUE(channel_->AddRecvStream(sp));
2316
Mirko Bonadeif859e552018-05-30 15:31:29 +02002317 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
pbos8fc7fa72015-07-15 08:02:58 -07002318 EXPECT_EQ(kSyncLabel,
2319 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group)
2320 << "SyncGroup should be set based on sync_label";
2321}
2322
eladalonf1841382017-06-12 01:16:46 -07002323TEST_F(WebRtcVideoChannelTest, RecvStreamWithSimAndRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002324 cricket::VideoSendParameters parameters;
2325 parameters.codecs = engine_.codecs();
2326 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002327 EXPECT_TRUE(channel_->SetSend(true));
nisse4b4dc862016-02-17 05:25:36 -08002328 parameters.conference_mode = true;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002329 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002330
2331 // Send side.
Peter Boström0c4e06b2015-10-07 12:23:21 +02002332 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
2333 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002334 FakeVideoSendStream* send_stream = AddSendStream(
2335 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
2336
2337 ASSERT_EQ(rtx_ssrcs.size(), send_stream->GetConfig().rtp.rtx.ssrcs.size());
2338 for (size_t i = 0; i < rtx_ssrcs.size(); ++i)
2339 EXPECT_EQ(rtx_ssrcs[i], send_stream->GetConfig().rtp.rtx.ssrcs[i]);
2340
2341 // Receiver side.
2342 FakeVideoReceiveStream* recv_stream = AddRecvStream(
2343 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
nisse26e3abb2017-08-25 04:44:25 -07002344 EXPECT_FALSE(
2345 recv_stream->GetConfig().rtp.rtx_associated_payload_types.empty());
nisseca5706d2017-09-11 02:32:16 -07002346 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
Peter Boströmd8b01092016-05-12 16:44:36 +02002347 << "RTX should be mapped for all decoders/payload types.";
nisseca5706d2017-09-11 02:32:16 -07002348 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02002349 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07002350 << "RTX should be mapped for the RED payload type";
2351
brandtr14742122017-01-27 04:53:07 -08002352 EXPECT_EQ(rtx_ssrcs[0], recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002353}
2354
eladalonf1841382017-06-12 01:16:46 -07002355TEST_F(WebRtcVideoChannelTest, RecvStreamWithRtx) {
pbos@webrtc.orge322a172014-06-13 11:47:28 +00002356 // Setup one channel with an associated RTX stream.
2357 cricket::StreamParams params =
2358 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
2359 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
2360 FakeVideoReceiveStream* recv_stream = AddRecvStream(params);
brandtr14742122017-01-27 04:53:07 -08002361 EXPECT_EQ(kRtxSsrcs1[0], recv_stream->GetConfig().rtp.rtx_ssrc);
nisseca5706d2017-09-11 02:32:16 -07002362
2363 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
2364 << "RTX should be mapped for all decoders/payload types.";
2365 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02002366 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07002367 << "RTX should be mapped for the RED payload type";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002368}
2369
eladalonf1841382017-06-12 01:16:46 -07002370TEST_F(WebRtcVideoChannelTest, RecvStreamNoRtx) {
pbos@webrtc.orge322a172014-06-13 11:47:28 +00002371 // Setup one channel without an associated RTX stream.
2372 cricket::StreamParams params =
2373 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
2374 FakeVideoReceiveStream* recv_stream = AddRecvStream(params);
brandtr14742122017-01-27 04:53:07 -08002375 ASSERT_EQ(0U, recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002376}
2377
Johannes Kron9190b822018-10-29 11:22:05 +01002378// Test propagation of extmap allow mixed setting.
2379TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedAsCaller) {
2380 TestExtmapAllowMixedCaller(/*extmap_allow_mixed=*/true);
2381}
2382TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedDisabledAsCaller) {
2383 TestExtmapAllowMixedCaller(/*extmap_allow_mixed=*/false);
2384}
2385TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedAsCallee) {
2386 TestExtmapAllowMixedCallee(/*extmap_allow_mixed=*/true);
2387}
2388TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedDisabledAsCallee) {
2389 TestExtmapAllowMixedCallee(/*extmap_allow_mixed=*/false);
2390}
2391
eladalonf1841382017-06-12 01:16:46 -07002392TEST_F(WebRtcVideoChannelTest, NoHeaderExtesionsByDefault) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002393 FakeVideoSendStream* send_stream =
2394 AddSendStream(cricket::StreamParams::CreateLegacy(kSsrcs1[0]));
2395 ASSERT_TRUE(send_stream->GetConfig().rtp.extensions.empty());
2396
2397 FakeVideoReceiveStream* recv_stream =
2398 AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrcs1[0]));
2399 ASSERT_TRUE(recv_stream->GetConfig().rtp.extensions.empty());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002400}
2401
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002402// Test support for RTP timestamp offset header extension.
eladalonf1841382017-06-12 01:16:46 -07002403TEST_F(WebRtcVideoChannelTest, SendRtpTimestampOffsetHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002404 TestSetSendRtpHeaderExtensions(RtpExtension::kTimestampOffsetUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002405}
isheriff6f8d6862016-05-26 11:24:55 -07002406
eladalonf1841382017-06-12 01:16:46 -07002407TEST_F(WebRtcVideoChannelTest, RecvRtpTimestampOffsetHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002408 TestSetRecvRtpHeaderExtensions(RtpExtension::kTimestampOffsetUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002409}
2410
2411// Test support for absolute send time header extension.
eladalonf1841382017-06-12 01:16:46 -07002412TEST_F(WebRtcVideoChannelTest, SendAbsoluteSendTimeHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002413 TestSetSendRtpHeaderExtensions(RtpExtension::kAbsSendTimeUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002414}
isheriff6f8d6862016-05-26 11:24:55 -07002415
eladalonf1841382017-06-12 01:16:46 -07002416TEST_F(WebRtcVideoChannelTest, RecvAbsoluteSendTimeHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002417 TestSetRecvRtpHeaderExtensions(RtpExtension::kAbsSendTimeUri);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002418}
2419
eladalonf1841382017-06-12 01:16:46 -07002420TEST_F(WebRtcVideoChannelTest, FiltersExtensionsPicksTransportSeqNum) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002421 // Enable three redundant extensions.
2422 std::vector<std::string> extensions;
isheriff6f8d6862016-05-26 11:24:55 -07002423 extensions.push_back(RtpExtension::kAbsSendTimeUri);
2424 extensions.push_back(RtpExtension::kTimestampOffsetUri);
2425 extensions.push_back(RtpExtension::kTransportSequenceNumberUri);
2426 TestExtensionFilter(extensions, RtpExtension::kTransportSequenceNumberUri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002427}
2428
eladalonf1841382017-06-12 01:16:46 -07002429TEST_F(WebRtcVideoChannelTest, FiltersExtensionsPicksAbsSendTime) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002430 // Enable two redundant extensions.
2431 std::vector<std::string> extensions;
isheriff6f8d6862016-05-26 11:24:55 -07002432 extensions.push_back(RtpExtension::kAbsSendTimeUri);
2433 extensions.push_back(RtpExtension::kTimestampOffsetUri);
2434 TestExtensionFilter(extensions, RtpExtension::kAbsSendTimeUri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002435}
2436
stefanc1aeaf02015-10-15 07:26:07 -07002437// Test support for transport sequence number header extension.
eladalonf1841382017-06-12 01:16:46 -07002438TEST_F(WebRtcVideoChannelTest, SendTransportSequenceNumberHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002439 TestSetSendRtpHeaderExtensions(RtpExtension::kTransportSequenceNumberUri);
stefanc1aeaf02015-10-15 07:26:07 -07002440}
eladalonf1841382017-06-12 01:16:46 -07002441TEST_F(WebRtcVideoChannelTest, RecvTransportSequenceNumberHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002442 TestSetRecvRtpHeaderExtensions(RtpExtension::kTransportSequenceNumberUri);
stefanc1aeaf02015-10-15 07:26:07 -07002443}
2444
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002445// Test support for video rotation header extension.
eladalonf1841382017-06-12 01:16:46 -07002446TEST_F(WebRtcVideoChannelTest, SendVideoRotationHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002447 TestSetSendRtpHeaderExtensions(RtpExtension::kVideoRotationUri);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002448}
eladalonf1841382017-06-12 01:16:46 -07002449TEST_F(WebRtcVideoChannelTest, RecvVideoRotationHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002450 TestSetRecvRtpHeaderExtensions(RtpExtension::kVideoRotationUri);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002451}
2452
eladalonf1841382017-06-12 01:16:46 -07002453TEST_F(WebRtcVideoChannelTest, IdenticalSendExtensionsDoesntRecreateStream) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002454 const int kAbsSendTimeId = 1;
2455 const int kVideoRotationId = 2;
isheriff6f8d6862016-05-26 11:24:55 -07002456 send_parameters_.extensions.push_back(
2457 RtpExtension(RtpExtension::kAbsSendTimeUri, kAbsSendTimeId));
2458 send_parameters_.extensions.push_back(
2459 RtpExtension(RtpExtension::kVideoRotationUri, kVideoRotationId));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002460
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002461 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002462 FakeVideoSendStream* send_stream =
2463 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2464
2465 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002466 ASSERT_EQ(2u, send_stream->GetConfig().rtp.extensions.size());
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002467
2468 // Setting the same extensions (even if in different order) shouldn't
2469 // reallocate the stream.
Steve Anton2c9ebef2019-01-28 17:27:58 -08002470 absl::c_reverse(send_parameters_.extensions);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002471 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002472
2473 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
2474
2475 // Setting different extensions should recreate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002476 send_parameters_.extensions.resize(1);
2477 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002478
2479 EXPECT_EQ(2, fake_call_->GetNumCreatedSendStreams());
2480}
2481
eladalonf1841382017-06-12 01:16:46 -07002482TEST_F(WebRtcVideoChannelTest, IdenticalRecvExtensionsDoesntRecreateStream) {
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002483 const int kTOffsetId = 1;
2484 const int kAbsSendTimeId = 2;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002485 const int kVideoRotationId = 3;
isheriff6f8d6862016-05-26 11:24:55 -07002486 recv_parameters_.extensions.push_back(
2487 RtpExtension(RtpExtension::kAbsSendTimeUri, kAbsSendTimeId));
2488 recv_parameters_.extensions.push_back(
2489 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
2490 recv_parameters_.extensions.push_back(
2491 RtpExtension(RtpExtension::kVideoRotationUri, kVideoRotationId));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002492
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002493 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
Peter Boström54be3e02015-05-25 15:04:24 +02002494 FakeVideoReceiveStream* recv_stream =
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002495 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2496
2497 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
Peter Boström54be3e02015-05-25 15:04:24 +02002498 ASSERT_EQ(3u, recv_stream->GetConfig().rtp.extensions.size());
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002499
2500 // Setting the same extensions (even if in different order) shouldn't
2501 // reallocate the stream.
Steve Anton2c9ebef2019-01-28 17:27:58 -08002502 absl::c_reverse(recv_parameters_.extensions);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002503 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002504
2505 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
2506
2507 // Setting different extensions should recreate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002508 recv_parameters_.extensions.resize(1);
2509 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002510
2511 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams());
2512}
2513
eladalonf1841382017-06-12 01:16:46 -07002514TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002515 SetSendRtpHeaderExtensionsExcludeUnsupportedExtensions) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002516 const int kUnsupportedId = 1;
2517 const int kTOffsetId = 2;
2518
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002519 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002520 RtpExtension(kUnsupportedExtensionName, kUnsupportedId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002521 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002522 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002523 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002524 FakeVideoSendStream* send_stream =
2525 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2526
2527 // Only timestamp offset extension is set to send stream,
2528 // unsupported rtp extension is ignored.
2529 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
isheriff6f8d6862016-05-26 11:24:55 -07002530 EXPECT_STREQ(RtpExtension::kTimestampOffsetUri,
2531 send_stream->GetConfig().rtp.extensions[0].uri.c_str());
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002532}
2533
eladalonf1841382017-06-12 01:16:46 -07002534TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002535 SetRecvRtpHeaderExtensionsExcludeUnsupportedExtensions) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002536 const int kUnsupportedId = 1;
2537 const int kTOffsetId = 2;
2538
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002539 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002540 RtpExtension(kUnsupportedExtensionName, kUnsupportedId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002541 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002542 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002543 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002544 FakeVideoReceiveStream* recv_stream =
2545 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2546
2547 // Only timestamp offset extension is set to receive stream,
2548 // unsupported rtp extension is ignored.
2549 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
isheriff6f8d6862016-05-26 11:24:55 -07002550 EXPECT_STREQ(RtpExtension::kTimestampOffsetUri,
2551 recv_stream->GetConfig().rtp.extensions[0].uri.c_str());
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002552}
2553
eladalonf1841382017-06-12 01:16:46 -07002554TEST_F(WebRtcVideoChannelTest, SetSendRtpHeaderExtensionsRejectsIncorrectIds) {
Peter Boström23914fe2015-03-31 15:08:04 +02002555 const int kIncorrectIds[] = {-2, -1, 0, 15, 16};
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00002556 for (size_t i = 0; i < arraysize(kIncorrectIds); ++i) {
isheriff6f8d6862016-05-26 11:24:55 -07002557 send_parameters_.extensions.push_back(
2558 RtpExtension(RtpExtension::kTimestampOffsetUri, kIncorrectIds[i]));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002559 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_))
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002560 << "Bad extension id '" << kIncorrectIds[i] << "' accepted.";
2561 }
2562}
2563
eladalonf1841382017-06-12 01:16:46 -07002564TEST_F(WebRtcVideoChannelTest, SetRecvRtpHeaderExtensionsRejectsIncorrectIds) {
Peter Boström23914fe2015-03-31 15:08:04 +02002565 const int kIncorrectIds[] = {-2, -1, 0, 15, 16};
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00002566 for (size_t i = 0; i < arraysize(kIncorrectIds); ++i) {
isheriff6f8d6862016-05-26 11:24:55 -07002567 recv_parameters_.extensions.push_back(
2568 RtpExtension(RtpExtension::kTimestampOffsetUri, kIncorrectIds[i]));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002569 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_))
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002570 << "Bad extension id '" << kIncorrectIds[i] << "' accepted.";
2571 }
2572}
2573
eladalonf1841382017-06-12 01:16:46 -07002574TEST_F(WebRtcVideoChannelTest, SetSendRtpHeaderExtensionsRejectsDuplicateIds) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002575 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002576 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002577 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002578 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002579 RtpExtension(RtpExtension::kAbsSendTimeUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002580 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002581
2582 // Duplicate entries are also not supported.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002583 send_parameters_.extensions.clear();
2584 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002585 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002586 send_parameters_.extensions.push_back(send_parameters_.extensions.back());
2587 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002588}
2589
eladalonf1841382017-06-12 01:16:46 -07002590TEST_F(WebRtcVideoChannelTest, SetRecvRtpHeaderExtensionsRejectsDuplicateIds) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002591 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002592 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002593 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002594 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002595 RtpExtension(RtpExtension::kAbsSendTimeUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002596 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002597
2598 // Duplicate entries are also not supported.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002599 recv_parameters_.extensions.clear();
2600 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002601 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002602 recv_parameters_.extensions.push_back(recv_parameters_.extensions.back());
2603 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002604}
2605
eladalonf1841382017-06-12 01:16:46 -07002606TEST_F(WebRtcVideoChannelTest, AddRecvStreamOnlyUsesOneReceiveStream) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002607 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002608 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002609}
2610
eladalonf1841382017-06-12 01:16:46 -07002611TEST_F(WebRtcVideoChannelTest, RtcpIsCompoundByDefault) {
Peter Boströmd7da1202015-06-05 14:09:38 +02002612 FakeVideoReceiveStream* stream = AddRecvStream();
pbosda903ea2015-10-02 02:36:56 -07002613 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream->GetConfig().rtp.rtcp_mode);
Peter Boströmd7da1202015-06-05 14:09:38 +02002614}
2615
eladalonf1841382017-06-12 01:16:46 -07002616TEST_F(WebRtcVideoChannelTest, RembIsEnabledByDefault) {
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002617 FakeVideoReceiveStream* stream = AddRecvStream();
2618 EXPECT_TRUE(stream->GetConfig().rtp.remb);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002619}
2620
eladalonf1841382017-06-12 01:16:46 -07002621TEST_F(WebRtcVideoChannelTest, TransportCcIsEnabledByDefault) {
stefan43edf0f2015-11-20 18:05:48 -08002622 FakeVideoReceiveStream* stream = AddRecvStream();
2623 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2624}
2625
eladalonf1841382017-06-12 01:16:46 -07002626TEST_F(WebRtcVideoChannelTest, RembCanBeEnabledAndDisabled) {
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002627 FakeVideoReceiveStream* stream = AddRecvStream();
2628 EXPECT_TRUE(stream->GetConfig().rtp.remb);
2629
Peter Boström126c03e2015-05-11 12:48:12 +02002630 // Verify that REMB is turned off when send(!) codecs without REMB are set.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002631 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002632 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002633 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2634 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002635 stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002636 EXPECT_FALSE(stream->GetConfig().rtp.remb);
2637
2638 // Verify that REMB is turned on when setting default codecs since the
2639 // default codecs have REMB enabled.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002640 parameters.codecs = engine_.codecs();
2641 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002642 stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002643 EXPECT_TRUE(stream->GetConfig().rtp.remb);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002644}
2645
eladalonf1841382017-06-12 01:16:46 -07002646TEST_F(WebRtcVideoChannelTest, TransportCcCanBeEnabledAndDisabled) {
stefan43edf0f2015-11-20 18:05:48 -08002647 FakeVideoReceiveStream* stream = AddRecvStream();
2648 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2649
2650 // Verify that transport cc feedback is turned off when send(!) codecs without
2651 // transport cc feedback are set.
2652 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002653 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
stefan43edf0f2015-11-20 18:05:48 -08002654 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2655 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2656 stream = fake_call_->GetVideoReceiveStreams()[0];
2657 EXPECT_FALSE(stream->GetConfig().rtp.transport_cc);
2658
2659 // Verify that transport cc feedback is turned on when setting default codecs
2660 // since the default codecs have transport cc feedback enabled.
2661 parameters.codecs = engine_.codecs();
2662 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2663 stream = fake_call_->GetVideoReceiveStreams()[0];
2664 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2665}
2666
eladalonf1841382017-06-12 01:16:46 -07002667TEST_F(WebRtcVideoChannelTest, NackIsEnabledByDefault) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02002668 AssignDefaultCodec();
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002669 VerifyCodecHasDefaultFeedbackParams(default_codec_);
2670
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002671 cricket::VideoSendParameters parameters;
2672 parameters.codecs = engine_.codecs();
2673 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org19864742014-05-30 07:35:47 +00002674 EXPECT_TRUE(channel_->SetSend(true));
2675
2676 // Send side.
2677 FakeVideoSendStream* send_stream =
2678 AddSendStream(cricket::StreamParams::CreateLegacy(1));
2679 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2680
2681 // Receiver side.
2682 FakeVideoReceiveStream* recv_stream =
2683 AddRecvStream(cricket::StreamParams::CreateLegacy(1));
2684 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2685
2686 // Nack history size should match between sender and receiver.
2687 EXPECT_EQ(send_stream->GetConfig().rtp.nack.rtp_history_ms,
2688 recv_stream->GetConfig().rtp.nack.rtp_history_ms);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002689}
2690
eladalonf1841382017-06-12 01:16:46 -07002691TEST_F(WebRtcVideoChannelTest, NackCanBeEnabledAndDisabled) {
Peter Boström67c9df72015-05-11 14:34:58 +02002692 FakeVideoSendStream* send_stream = AddSendStream();
Peter Boström3548dd22015-05-22 18:48:36 +02002693 FakeVideoReceiveStream* recv_stream = AddRecvStream();
Peter Boström67c9df72015-05-11 14:34:58 +02002694
2695 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2696 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2697
2698 // Verify that NACK is turned off when send(!) codecs without NACK are set.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002699 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002700 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002701 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2702 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström67c9df72015-05-11 14:34:58 +02002703 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2704 EXPECT_EQ(0, recv_stream->GetConfig().rtp.nack.rtp_history_ms);
2705 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002706 EXPECT_EQ(0, send_stream->GetConfig().rtp.nack.rtp_history_ms);
2707
Peter Boström67c9df72015-05-11 14:34:58 +02002708 // Verify that NACK is turned on when setting default codecs since the
2709 // default codecs have NACK enabled.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002710 parameters.codecs = engine_.codecs();
2711 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström67c9df72015-05-11 14:34:58 +02002712 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2713 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2714 send_stream = fake_call_->GetVideoSendStreams()[0];
2715 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002716}
2717
Peter Boströme7ba0862016-03-12 00:02:28 +01002718// This test verifies that new frame sizes reconfigures encoders even though not
2719// (yet) sending. The purpose of this is to permit encoding as quickly as
2720// possible once we start sending. Likely the frames being input are from the
2721// same source that will be sent later, which just means that we're ready
2722// earlier.
eladalonf1841382017-06-12 01:16:46 -07002723TEST_F(WebRtcVideoChannelTest, ReconfiguresEncodersWhenNotSending) {
Peter Boströme7ba0862016-03-12 00:02:28 +01002724 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002725 parameters.codecs.push_back(GetEngineCodec("VP8"));
Peter Boströme7ba0862016-03-12 00:02:28 +01002726 ASSERT_TRUE(channel_->SetSendParameters(parameters));
2727 channel_->SetSend(false);
2728
2729 FakeVideoSendStream* stream = AddSendStream();
2730
perkjfa10b552016-10-02 23:45:26 -07002731 // No frames entered.
Peter Boströme7ba0862016-03-12 00:02:28 +01002732 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002733 EXPECT_EQ(0u, streams[0].width);
2734 EXPECT_EQ(0u, streams[0].height);
Peter Boströme7ba0862016-03-12 00:02:28 +01002735
Niels Möller805a27e2019-01-21 12:21:27 +01002736 webrtc::test::FrameForwarder frame_forwarder;
2737 cricket::FakeFrameSource frame_source(1280, 720,
2738 rtc::kNumMicrosecsPerSec / 30);
2739
2740 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
2741 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Peter Boströme7ba0862016-03-12 00:02:28 +01002742
2743 // Frame entered, should be reconfigured to new dimensions.
2744 streams = stream->GetVideoStreams();
Niels Möller805a27e2019-01-21 12:21:27 +01002745 EXPECT_EQ(rtc::checked_cast<size_t>(1280), streams[0].width);
2746 EXPECT_EQ(rtc::checked_cast<size_t>(720), streams[0].height);
Peter Boströme7ba0862016-03-12 00:02:28 +01002747
Niels Möllerff40b142018-04-09 08:49:14 +02002748 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boströme7ba0862016-03-12 00:02:28 +01002749}
2750
eladalonf1841382017-06-12 01:16:46 -07002751TEST_F(WebRtcVideoChannelTest, UsesCorrectSettingsForScreencast) {
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002752 static const int kScreenshareMinBitrateKbps = 800;
magjed509e4fe2016-11-18 01:34:11 -08002753 cricket::VideoCodec codec = GetEngineCodec("VP8");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002754 cricket::VideoSendParameters parameters;
2755 parameters.codecs.push_back(codec);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002756 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002757 AddSendStream();
2758
Niels Möller805a27e2019-01-21 12:21:27 +01002759 webrtc::test::FrameForwarder frame_forwarder;
2760 cricket::FakeFrameSource frame_source(1280, 720,
2761 rtc::kNumMicrosecsPerSec / 30);
nisse05103312016-03-16 02:22:50 -07002762 VideoOptions min_bitrate_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002763 min_bitrate_options.screencast_min_bitrate_kbps = kScreenshareMinBitrateKbps;
Niels Möller805a27e2019-01-21 12:21:27 +01002764 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &min_bitrate_options,
2765 &frame_forwarder));
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002766
2767 EXPECT_TRUE(channel_->SetSend(true));
2768
Niels Möller805a27e2019-01-21 12:21:27 +01002769 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002770 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2771 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
2772
2773 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
2774
2775 // Verify non-screencast settings.
perkj26091b12016-09-01 01:17:40 -07002776 webrtc::VideoEncoderConfig encoder_config =
2777 send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002778 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kRealtimeVideo,
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002779 encoder_config.content_type);
perkjfa10b552016-10-02 23:45:26 -07002780 std::vector<webrtc::VideoStream> streams = send_stream->GetVideoStreams();
Niels Möller805a27e2019-01-21 12:21:27 +01002781 EXPECT_EQ(rtc::checked_cast<size_t>(1280), streams.front().width);
2782 EXPECT_EQ(rtc::checked_cast<size_t>(720), streams.front().height);
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002783 EXPECT_EQ(0, encoder_config.min_transmit_bitrate_bps)
2784 << "Non-screenshare shouldn't use min-transmit bitrate.";
2785
Niels Möllerff40b142018-04-09 08:49:14 +02002786 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
perkjd533aec2017-01-13 05:57:25 -08002787 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
nisse05103312016-03-16 02:22:50 -07002788 VideoOptions screencast_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002789 screencast_options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01002790 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &screencast_options,
2791 &frame_forwarder));
2792 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
sprangf24a0642017-02-28 13:23:26 -08002793 // Send stream recreated after option change.
2794 ASSERT_EQ(2, fake_call_->GetNumCreatedSendStreams());
2795 send_stream = fake_call_->GetVideoSendStreams().front();
2796 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002797
2798 // Verify screencast settings.
perkj26091b12016-09-01 01:17:40 -07002799 encoder_config = send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002800 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kScreen,
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002801 encoder_config.content_type);
2802 EXPECT_EQ(kScreenshareMinBitrateKbps * 1000,
2803 encoder_config.min_transmit_bitrate_bps);
2804
perkjfa10b552016-10-02 23:45:26 -07002805 streams = send_stream->GetVideoStreams();
Niels Möller805a27e2019-01-21 12:21:27 +01002806 EXPECT_EQ(rtc::checked_cast<size_t>(1280), streams.front().width);
2807 EXPECT_EQ(rtc::checked_cast<size_t>(720), streams.front().height);
Sergey Silkina796a7e2018-03-01 15:11:29 +01002808 EXPECT_FALSE(streams[0].num_temporal_layers.has_value());
Niels Möllerff40b142018-04-09 08:49:14 +02002809 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002810}
2811
eladalonf1841382017-06-12 01:16:46 -07002812TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002813 ConferenceModeScreencastConfiguresTemporalLayer) {
Rasmus Brandt195d1d72018-05-09 11:28:01 +02002814 static const int kConferenceScreencastTemporalBitrateBps = 200 * 1000;
nisse4b4dc862016-02-17 05:25:36 -08002815 send_parameters_.conference_mode = true;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002816 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002817
2818 AddSendStream();
nisse05103312016-03-16 02:22:50 -07002819 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002820 options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01002821 webrtc::test::FrameForwarder frame_forwarder;
2822 cricket::FakeFrameSource frame_source(1280, 720,
2823 rtc::kNumMicrosecsPerSec / 30);
2824 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002825 EXPECT_TRUE(channel_->SetSend(true));
2826
Niels Möller805a27e2019-01-21 12:21:27 +01002827 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002828 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2829 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
2830
perkj26091b12016-09-01 01:17:40 -07002831 webrtc::VideoEncoderConfig encoder_config =
2832 send_stream->GetEncoderConfig().Copy();
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002833
2834 // Verify screencast settings.
perkj26091b12016-09-01 01:17:40 -07002835 encoder_config = send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002836 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kScreen,
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002837 encoder_config.content_type);
perkjfa10b552016-10-02 23:45:26 -07002838
2839 std::vector<webrtc::VideoStream> streams = send_stream->GetVideoStreams();
2840 ASSERT_EQ(1u, streams.size());
Sergey Silkina796a7e2018-03-01 15:11:29 +01002841 ASSERT_EQ(2u, streams[0].num_temporal_layers);
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002842 EXPECT_EQ(kConferenceScreencastTemporalBitrateBps,
Sergey Silkina796a7e2018-03-01 15:11:29 +01002843 streams[0].target_bitrate_bps);
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002844
Niels Möllerff40b142018-04-09 08:49:14 +02002845 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002846}
2847
eladalonf1841382017-06-12 01:16:46 -07002848TEST_F(WebRtcVideoChannelTest, SuspendBelowMinBitrateDisabledByDefault) {
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002849 FakeVideoSendStream* stream = AddSendStream();
2850 EXPECT_FALSE(stream->GetConfig().suspend_below_min_bitrate);
2851}
2852
eladalonf1841382017-06-12 01:16:46 -07002853TEST_F(WebRtcVideoChannelTest, SetMediaConfigSuspendBelowMinBitrate) {
kthelgason2bc68642017-02-07 07:02:22 -08002854 MediaConfig media_config = GetMediaConfig();
nisse0db023a2016-03-01 04:29:59 -08002855 media_config.video.suspend_below_min_bitrate = true;
2856
Sebastian Jansson84848f22018-11-16 10:40:36 +01002857 channel_.reset(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07002858 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002859 channel_->OnReadyToSend(true);
nisse0db023a2016-03-01 04:29:59 -08002860
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002861 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002862
2863 FakeVideoSendStream* stream = AddSendStream();
2864 EXPECT_TRUE(stream->GetConfig().suspend_below_min_bitrate);
2865
nisse0db023a2016-03-01 04:29:59 -08002866 media_config.video.suspend_below_min_bitrate = false;
Sebastian Jansson84848f22018-11-16 10:40:36 +01002867 channel_.reset(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07002868 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002869 channel_->OnReadyToSend(true);
nisse0db023a2016-03-01 04:29:59 -08002870
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002871 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002872
nisse0db023a2016-03-01 04:29:59 -08002873 stream = AddSendStream();
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002874 EXPECT_FALSE(stream->GetConfig().suspend_below_min_bitrate);
2875}
2876
eladalonf1841382017-06-12 01:16:46 -07002877TEST_F(WebRtcVideoChannelTest, Vp8DenoisingEnabledByDefault) {
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002878 FakeVideoSendStream* stream = AddSendStream();
2879 webrtc::VideoCodecVP8 vp8_settings;
2880 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2881 EXPECT_TRUE(vp8_settings.denoisingOn);
2882}
2883
eladalonf1841382017-06-12 01:16:46 -07002884TEST_F(WebRtcVideoChannelTest, VerifyVp8SpecificSettings) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002885 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002886 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002887 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002888
Peter Boström2feafdb2015-09-09 14:32:14 +02002889 // Single-stream settings should apply with RTX as well (verifies that we
2890 // check number of regular SSRCs and not StreamParams::ssrcs which contains
2891 // both RTX and regular SSRCs).
2892 FakeVideoSendStream* stream = SetUpSimulcast(false, true);
Erik Språng143cec12015-04-28 10:01:41 +02002893
Niels Möller805a27e2019-01-21 12:21:27 +01002894 webrtc::test::FrameForwarder frame_forwarder;
2895 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Erik Språng143cec12015-04-28 10:01:41 +02002896 channel_->SetSend(true);
2897
Niels Möller805a27e2019-01-21 12:21:27 +01002898 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Erik Språng143cec12015-04-28 10:01:41 +02002899
pbos4cba4eb2015-10-26 11:18:18 -07002900 webrtc::VideoCodecVP8 vp8_settings;
2901 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2902 EXPECT_TRUE(vp8_settings.denoisingOn)
2903 << "VP8 denoising should be on by default.";
2904
Niels Möller805a27e2019-01-21 12:21:27 +01002905 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02002906
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002907 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2908 EXPECT_FALSE(vp8_settings.denoisingOn);
Erik Språng143cec12015-04-28 10:01:41 +02002909 EXPECT_TRUE(vp8_settings.automaticResizeOn);
2910 EXPECT_TRUE(vp8_settings.frameDroppingOn);
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002911
Niels Möller805a27e2019-01-21 12:21:27 +01002912 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, true);
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002913
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002914 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2915 EXPECT_TRUE(vp8_settings.denoisingOn);
Erik Språng143cec12015-04-28 10:01:41 +02002916 EXPECT_TRUE(vp8_settings.automaticResizeOn);
2917 EXPECT_TRUE(vp8_settings.frameDroppingOn);
2918
Niels Möllerff40b142018-04-09 08:49:14 +02002919 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boström2feafdb2015-09-09 14:32:14 +02002920 stream = SetUpSimulcast(true, false);
Niels Möller805a27e2019-01-21 12:21:27 +01002921 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Erik Språng143cec12015-04-28 10:01:41 +02002922 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01002923 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Erik Språng143cec12015-04-28 10:01:41 +02002924
Mirko Bonadeif859e552018-05-30 15:31:29 +02002925 EXPECT_EQ(3u, stream->GetVideoStreams().size());
Erik Språng143cec12015-04-28 10:01:41 +02002926 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2927 // Autmatic resize off when using simulcast.
2928 EXPECT_FALSE(vp8_settings.automaticResizeOn);
2929 EXPECT_TRUE(vp8_settings.frameDroppingOn);
2930
2931 // In screen-share mode, denoising is forced off and simulcast disabled.
nisse05103312016-03-16 02:22:50 -07002932 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002933 options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01002934 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Niels Möller60653ba2016-03-02 11:41:36 +01002935
Niels Möller805a27e2019-01-21 12:21:27 +01002936 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02002937
Mirko Bonadeif859e552018-05-30 15:31:29 +02002938 EXPECT_EQ(1u, stream->GetVideoStreams().size());
Erik Språng143cec12015-04-28 10:01:41 +02002939 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2940 EXPECT_FALSE(vp8_settings.denoisingOn);
2941 // Resizing and frame dropping always off for screen sharing.
2942 EXPECT_FALSE(vp8_settings.automaticResizeOn);
2943 EXPECT_FALSE(vp8_settings.frameDroppingOn);
2944
Niels Möller805a27e2019-01-21 12:21:27 +01002945 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, true);
Erik Språng143cec12015-04-28 10:01:41 +02002946
2947 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2948 EXPECT_FALSE(vp8_settings.denoisingOn);
2949 EXPECT_FALSE(vp8_settings.automaticResizeOn);
2950 EXPECT_FALSE(vp8_settings.frameDroppingOn);
2951
Niels Möllerff40b142018-04-09 08:49:14 +02002952 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Erik Språng143cec12015-04-28 10:01:41 +02002953}
2954
deadbeef119760a2016-04-04 11:43:27 -07002955// Test that setting the same options doesn't result in the encoder being
2956// reconfigured.
eladalonf1841382017-06-12 01:16:46 -07002957TEST_F(WebRtcVideoChannelTest, SetIdenticalOptionsDoesntReconfigureEncoder) {
deadbeef119760a2016-04-04 11:43:27 -07002958 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01002959 webrtc::test::FrameForwarder frame_forwarder;
deadbeef119760a2016-04-04 11:43:27 -07002960
perkjfa10b552016-10-02 23:45:26 -07002961 AddSendStream();
perkjfa10b552016-10-02 23:45:26 -07002962 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002963 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkjfa10b552016-10-02 23:45:26 -07002964 ASSERT_TRUE(channel_->SetSendParameters(parameters));
2965 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
2966
Niels Möller805a27e2019-01-21 12:21:27 +01002967 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
2968 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
2969 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
perkjfa10b552016-10-02 23:45:26 -07002970 // Expect 1 reconfigurations at this point from the initial configuration.
2971 EXPECT_EQ(1, send_stream->num_encoder_reconfigurations());
deadbeef119760a2016-04-04 11:43:27 -07002972
2973 // Set the options one more time and expect no additional reconfigurations.
Niels Möller805a27e2019-01-21 12:21:27 +01002974 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
perkjfa10b552016-10-02 23:45:26 -07002975 EXPECT_EQ(1, send_stream->num_encoder_reconfigurations());
2976
2977 // Change |options| and expect 2 reconfigurations.
Oskar Sundbom78807582017-11-16 11:09:55 +01002978 options.video_noise_reduction = true;
Niels Möller805a27e2019-01-21 12:21:27 +01002979 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
deadbeef119760a2016-04-04 11:43:27 -07002980 EXPECT_EQ(2, send_stream->num_encoder_reconfigurations());
2981
Niels Möllerff40b142018-04-09 08:49:14 +02002982 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
deadbeef119760a2016-04-04 11:43:27 -07002983}
2984
eladalonf1841382017-06-12 01:16:46 -07002985class Vp9SettingsTest : public WebRtcVideoChannelTest {
Erik Språng143cec12015-04-28 10:01:41 +02002986 public:
asaperssonc5dabdd2016-03-21 04:15:50 -07002987 Vp9SettingsTest() : Vp9SettingsTest("") {}
2988 explicit Vp9SettingsTest(const char* field_trials)
eladalonf1841382017-06-12 01:16:46 -07002989 : WebRtcVideoChannelTest(field_trials) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +02002990 encoder_factory_->AddSupportedVideoCodecType("VP9");
Erik Språng143cec12015-04-28 10:01:41 +02002991 }
2992 virtual ~Vp9SettingsTest() {}
2993
2994 protected:
Erik Språng143cec12015-04-28 10:01:41 +02002995 void TearDown() override {
2996 // Remove references to encoder_factory_ since this will be destroyed
2997 // before channel_ and engine_.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002998 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
Erik Språng143cec12015-04-28 10:01:41 +02002999 }
Erik Språng143cec12015-04-28 10:01:41 +02003000};
3001
3002TEST_F(Vp9SettingsTest, VerifyVp9SpecificSettings) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003003 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003004 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003005 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Erik Språng143cec12015-04-28 10:01:41 +02003006
Peter Boström2feafdb2015-09-09 14:32:14 +02003007 FakeVideoSendStream* stream = SetUpSimulcast(false, false);
Erik Språng143cec12015-04-28 10:01:41 +02003008
Niels Möller805a27e2019-01-21 12:21:27 +01003009 webrtc::test::FrameForwarder frame_forwarder;
3010 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Erik Språng143cec12015-04-28 10:01:41 +02003011 channel_->SetSend(true);
3012
Niels Möller805a27e2019-01-21 12:21:27 +01003013 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Erik Språng143cec12015-04-28 10:01:41 +02003014
pbos4cba4eb2015-10-26 11:18:18 -07003015 webrtc::VideoCodecVP9 vp9_settings;
3016 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
jianja5e8aa62017-03-27 10:09:00 -07003017 EXPECT_TRUE(vp9_settings.denoisingOn)
3018 << "VP9 denoising should be on by default.";
pbos4cba4eb2015-10-26 11:18:18 -07003019
Niels Möller805a27e2019-01-21 12:21:27 +01003020 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02003021
Erik Språng143cec12015-04-28 10:01:41 +02003022 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3023 EXPECT_FALSE(vp9_settings.denoisingOn);
3024 // Frame dropping always on for real time video.
3025 EXPECT_TRUE(vp9_settings.frameDroppingOn);
3026
Niels Möller805a27e2019-01-21 12:21:27 +01003027 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, true);
Erik Språng143cec12015-04-28 10:01:41 +02003028
3029 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3030 EXPECT_TRUE(vp9_settings.denoisingOn);
3031 EXPECT_TRUE(vp9_settings.frameDroppingOn);
3032
3033 // In screen-share mode, denoising is forced off.
nisse05103312016-03-16 02:22:50 -07003034 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003035 options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01003036 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
perkj2d5f0912016-02-29 00:04:41 -08003037
Niels Möller805a27e2019-01-21 12:21:27 +01003038 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02003039
3040 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3041 EXPECT_FALSE(vp9_settings.denoisingOn);
Sergey Silkinbe71a1e2018-05-17 16:46:43 +02003042 // Frame dropping always on for screen sharing.
3043 EXPECT_TRUE(vp9_settings.frameDroppingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003044
Niels Möller805a27e2019-01-21 12:21:27 +01003045 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02003046
3047 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3048 EXPECT_FALSE(vp9_settings.denoisingOn);
Sergey Silkinbe71a1e2018-05-17 16:46:43 +02003049 EXPECT_TRUE(vp9_settings.frameDroppingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003050
Niels Möllerff40b142018-04-09 08:49:14 +02003051 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003052}
3053
Sergey Silkinf18072e2018-03-14 10:35:35 +01003054TEST_F(Vp9SettingsTest, MultipleSsrcsEnablesSvc) {
3055 cricket::VideoSendParameters parameters;
3056 parameters.codecs.push_back(GetEngineCodec("VP9"));
3057 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3058
3059 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
3060
3061 FakeVideoSendStream* stream =
3062 AddSendStream(CreateSimStreamParams("cname", ssrcs));
3063
3064 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3065 EXPECT_EQ(ssrcs.size(), config.rtp.ssrcs.size());
3066
Niels Möller805a27e2019-01-21 12:21:27 +01003067 webrtc::test::FrameForwarder frame_forwarder;
3068 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, &frame_forwarder));
Sergey Silkinf18072e2018-03-14 10:35:35 +01003069 channel_->SetSend(true);
3070
Niels Möller805a27e2019-01-21 12:21:27 +01003071 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Sergey Silkinf18072e2018-03-14 10:35:35 +01003072
3073 webrtc::VideoCodecVP9 vp9_settings;
3074 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3075
3076 const size_t kNumSpatialLayers = ssrcs.size();
3077 const size_t kNumTemporalLayers = 3;
3078 EXPECT_EQ(vp9_settings.numberOfSpatialLayers, kNumSpatialLayers);
3079 EXPECT_EQ(vp9_settings.numberOfTemporalLayers, kNumTemporalLayers);
3080
Niels Möllerff40b142018-04-09 08:49:14 +02003081 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, nullptr));
Sergey Silkinf18072e2018-03-14 10:35:35 +01003082}
3083
Sergey Silkin8b9b5f92018-12-10 09:28:53 +01003084TEST_F(Vp9SettingsTest, AllEncodingParametersCopied) {
3085 cricket::VideoSendParameters send_parameters;
3086 send_parameters.codecs.push_back(GetEngineCodec("VP9"));
3087 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
3088
3089 const size_t kNumSpatialLayers = 3;
3090 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
3091
3092 FakeVideoSendStream* stream =
3093 AddSendStream(CreateSimStreamParams("cname", ssrcs));
3094
3095 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(ssrcs[0]);
3096 ASSERT_EQ(kNumSpatialLayers, parameters.encodings.size());
3097 ASSERT_TRUE(parameters.encodings[0].active);
3098 ASSERT_TRUE(parameters.encodings[1].active);
3099 ASSERT_TRUE(parameters.encodings[2].active);
3100 // Invert value to verify copying.
3101 parameters.encodings[1].active = false;
3102 EXPECT_TRUE(channel_->SetRtpSendParameters(ssrcs[0], parameters).ok());
3103
3104 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
3105
3106 // number_of_streams should be 1 since all spatial layers are sent on the
3107 // same SSRC. But encoding parameters of all layers is supposed to be copied
3108 // and stored in simulcast_layers[].
3109 EXPECT_EQ(1u, encoder_config.number_of_streams);
3110 EXPECT_EQ(encoder_config.simulcast_layers.size(), kNumSpatialLayers);
3111 EXPECT_TRUE(encoder_config.simulcast_layers[0].active);
3112 EXPECT_FALSE(encoder_config.simulcast_layers[1].active);
3113 EXPECT_TRUE(encoder_config.simulcast_layers[2].active);
3114}
3115
asaperssonc5dabdd2016-03-21 04:15:50 -07003116class Vp9SettingsTestWithFieldTrial : public Vp9SettingsTest {
3117 public:
brandtr468da7c2016-11-22 02:16:47 -08003118 explicit Vp9SettingsTestWithFieldTrial(const char* field_trials)
asaperssonc5dabdd2016-03-21 04:15:50 -07003119 : Vp9SettingsTest(field_trials) {}
3120
3121 protected:
3122 void VerifySettings(int num_spatial_layers, int num_temporal_layers) {
3123 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003124 parameters.codecs.push_back(GetEngineCodec("VP9"));
asaperssonc5dabdd2016-03-21 04:15:50 -07003125 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3126
3127 FakeVideoSendStream* stream = SetUpSimulcast(false, false);
3128
Niels Möller805a27e2019-01-21 12:21:27 +01003129 webrtc::test::FrameForwarder frame_forwarder;
3130 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
asaperssonc5dabdd2016-03-21 04:15:50 -07003131 channel_->SetSend(true);
3132
Niels Möller805a27e2019-01-21 12:21:27 +01003133 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
asaperssonc5dabdd2016-03-21 04:15:50 -07003134
3135 webrtc::VideoCodecVP9 vp9_settings;
3136 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3137 EXPECT_EQ(num_spatial_layers, vp9_settings.numberOfSpatialLayers);
3138 EXPECT_EQ(num_temporal_layers, vp9_settings.numberOfTemporalLayers);
3139
Niels Möllerff40b142018-04-09 08:49:14 +02003140 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
asaperssonc5dabdd2016-03-21 04:15:50 -07003141 }
3142};
3143
3144class Vp9SettingsTestWithNoFlag : public Vp9SettingsTestWithFieldTrial {
3145 public:
3146 Vp9SettingsTestWithNoFlag() : Vp9SettingsTestWithFieldTrial("") {}
3147};
3148
3149TEST_F(Vp9SettingsTestWithNoFlag, VerifySettings) {
3150 const int kNumSpatialLayers = 1;
3151 const int kNumTemporalLayers = 1;
3152 VerifySettings(kNumSpatialLayers, kNumTemporalLayers);
3153}
3154
3155class Vp9SettingsTestWithInvalidFlag : public Vp9SettingsTestWithFieldTrial {
3156 public:
3157 Vp9SettingsTestWithInvalidFlag()
3158 : Vp9SettingsTestWithFieldTrial("WebRTC-SupportVP9SVC/Default/") {}
3159};
3160
3161TEST_F(Vp9SettingsTestWithInvalidFlag, VerifySettings) {
3162 const int kNumSpatialLayers = 1;
3163 const int kNumTemporalLayers = 1;
3164 VerifySettings(kNumSpatialLayers, kNumTemporalLayers);
3165}
3166
3167class Vp9SettingsTestWith2SL3TLFlag : public Vp9SettingsTestWithFieldTrial {
3168 public:
3169 Vp9SettingsTestWith2SL3TLFlag()
3170 : Vp9SettingsTestWithFieldTrial(
3171 "WebRTC-SupportVP9SVC/EnabledByFlag_2SL3TL/") {}
3172};
3173
3174TEST_F(Vp9SettingsTestWith2SL3TLFlag, VerifySettings) {
3175 const int kNumSpatialLayers = 2;
3176 const int kNumTemporalLayers = 3;
3177 VerifySettings(kNumSpatialLayers, kNumTemporalLayers);
3178}
3179
Åsa Persson45bbc8a2017-11-13 10:16:47 +01003180TEST_F(WebRtcVideoChannelTest, VerifyMinBitrate) {
3181 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3182 ASSERT_EQ(1u, streams.size());
3183 EXPECT_EQ(cricket::kMinVideoBitrateBps, streams[0].min_bitrate_bps);
3184}
3185
3186TEST_F(WebRtcVideoChannelTest, VerifyMinBitrateWithForcedFallbackFieldTrial) {
3187 webrtc::test::ScopedFieldTrials override_field_trials_(
3188 "WebRTC-VP8-Forced-Fallback-Encoder-v2/Enabled-1,2,34567/");
3189 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3190 ASSERT_EQ(1u, streams.size());
3191 EXPECT_EQ(34567, streams[0].min_bitrate_bps);
3192}
3193
asapersson3c81a1a2017-06-14 05:52:21 -07003194TEST_F(WebRtcVideoChannelTest,
3195 BalancedDegradationPreferenceNotSupportedWithoutFieldtrial) {
3196 webrtc::test::ScopedFieldTrials override_field_trials_(
3197 "WebRTC-Video-BalancedDegradation/Disabled/");
3198 const bool kResolutionScalingEnabled = true;
3199 const bool kFpsScalingEnabled = false;
3200 TestDegradationPreference(kResolutionScalingEnabled, kFpsScalingEnabled);
3201}
3202
3203TEST_F(WebRtcVideoChannelTest,
3204 BalancedDegradationPreferenceSupportedBehindFieldtrial) {
3205 webrtc::test::ScopedFieldTrials override_field_trials_(
3206 "WebRTC-Video-BalancedDegradation/Enabled/");
3207 const bool kResolutionScalingEnabled = true;
3208 const bool kFpsScalingEnabled = true;
3209 TestDegradationPreference(kResolutionScalingEnabled, kFpsScalingEnabled);
3210}
3211
eladalonf1841382017-06-12 01:16:46 -07003212TEST_F(WebRtcVideoChannelTest, AdaptsOnOveruse) {
Erik Språngefbde372015-04-29 16:21:28 +02003213 TestCpuAdaptation(true, false);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003214}
3215
eladalonf1841382017-06-12 01:16:46 -07003216TEST_F(WebRtcVideoChannelTest, DoesNotAdaptOnOveruseWhenDisabled) {
Erik Språngefbde372015-04-29 16:21:28 +02003217 TestCpuAdaptation(false, false);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003218}
3219
Niels Möller3de32e62019-01-18 08:42:18 +01003220TEST_F(WebRtcVideoChannelTest, DoesNotAdaptWhenScreeensharing) {
3221 TestCpuAdaptation(false, true);
3222}
3223
eladalonf1841382017-06-12 01:16:46 -07003224TEST_F(WebRtcVideoChannelTest, DoesNotAdaptOnOveruseWhenScreensharing) {
Erik Språngefbde372015-04-29 16:21:28 +02003225 TestCpuAdaptation(true, true);
3226}
3227
eladalonf1841382017-06-12 01:16:46 -07003228TEST_F(WebRtcVideoChannelTest, PreviousAdaptationDoesNotApplyToScreenshare) {
magjed509e4fe2016-11-18 01:34:11 -08003229 cricket::VideoCodec codec = GetEngineCodec("VP8");
Per766ad3b2016-04-05 15:23:49 +02003230 cricket::VideoSendParameters parameters;
3231 parameters.codecs.push_back(codec);
3232
kthelgason2bc68642017-02-07 07:02:22 -08003233 MediaConfig media_config = GetMediaConfig();
Niels Möller1d7ecd22018-01-18 15:25:12 +01003234 media_config.video.enable_cpu_adaptation = true;
Sebastian Jansson84848f22018-11-16 10:40:36 +01003235 channel_.reset(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07003236 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003237 channel_->OnReadyToSend(true);
Per766ad3b2016-04-05 15:23:49 +02003238 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3239
3240 AddSendStream();
Niels Möller805a27e2019-01-21 12:21:27 +01003241 webrtc::test::FrameForwarder frame_forwarder;
Per766ad3b2016-04-05 15:23:49 +02003242
Per766ad3b2016-04-05 15:23:49 +02003243 ASSERT_TRUE(channel_->SetSend(true));
3244 cricket::VideoOptions camera_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003245 camera_options.is_screencast = false;
Niels Möller805a27e2019-01-21 12:21:27 +01003246 channel_->SetVideoSend(last_ssrc_, &camera_options, &frame_forwarder);
Per766ad3b2016-04-05 15:23:49 +02003247
3248 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3249 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
Per766ad3b2016-04-05 15:23:49 +02003250
Niels Möllerdcc70292019-01-15 16:32:38 +01003251 EXPECT_TRUE(send_stream->resolution_scaling_enabled());
3252 // Dont' expect anything on framerate_scaling_enabled, since the default is
3253 // transitioning from MAINTAIN_FRAMERATE to BALANCED.
Per766ad3b2016-04-05 15:23:49 +02003254
Niels Möllerdcc70292019-01-15 16:32:38 +01003255 // Switch to screen share. Expect no resolution scaling.
Per766ad3b2016-04-05 15:23:49 +02003256 cricket::VideoOptions screenshare_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003257 screenshare_options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01003258 channel_->SetVideoSend(last_ssrc_, &screenshare_options, &frame_forwarder);
sprangf24a0642017-02-28 13:23:26 -08003259 ASSERT_EQ(2, fake_call_->GetNumCreatedSendStreams());
3260 send_stream = fake_call_->GetVideoSendStreams().front();
Niels Möllerdcc70292019-01-15 16:32:38 +01003261 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
Per766ad3b2016-04-05 15:23:49 +02003262
Niels Möllerdcc70292019-01-15 16:32:38 +01003263 // Switch back to the normal capturer. Expect resolution scaling to be
3264 // reenabled.
Niels Möller805a27e2019-01-21 12:21:27 +01003265 channel_->SetVideoSend(last_ssrc_, &camera_options, &frame_forwarder);
3266 send_stream = fake_call_->GetVideoSendStreams().front();
sprangf24a0642017-02-28 13:23:26 -08003267 ASSERT_EQ(3, fake_call_->GetNumCreatedSendStreams());
3268 send_stream = fake_call_->GetVideoSendStreams().front();
Niels Möllerdcc70292019-01-15 16:32:38 +01003269 EXPECT_TRUE(send_stream->resolution_scaling_enabled());
Per766ad3b2016-04-05 15:23:49 +02003270
Niels Möllerff40b142018-04-09 08:49:14 +02003271 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Per766ad3b2016-04-05 15:23:49 +02003272}
3273
asapersson3c81a1a2017-06-14 05:52:21 -07003274// TODO(asapersson): Remove this test when the balanced field trial is removed.
3275void WebRtcVideoChannelTest::TestDegradationPreference(
3276 bool resolution_scaling_enabled,
3277 bool fps_scaling_enabled) {
3278 cricket::VideoCodec codec = GetEngineCodec("VP8");
3279 cricket::VideoSendParameters parameters;
3280 parameters.codecs.push_back(codec);
3281
3282 MediaConfig media_config = GetMediaConfig();
Niels Möller1d7ecd22018-01-18 15:25:12 +01003283 media_config.video.enable_cpu_adaptation = true;
Sebastian Jansson84848f22018-11-16 10:40:36 +01003284 channel_.reset(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07003285 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
asapersson3c81a1a2017-06-14 05:52:21 -07003286 channel_->OnReadyToSend(true);
3287
3288 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3289
3290 AddSendStream();
3291
Niels Möller805a27e2019-01-21 12:21:27 +01003292 webrtc::test::FrameForwarder frame_forwarder;
asapersson3c81a1a2017-06-14 05:52:21 -07003293 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01003294 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
asapersson3c81a1a2017-06-14 05:52:21 -07003295
3296 EXPECT_TRUE(channel_->SetSend(true));
3297
3298 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
3299 EXPECT_EQ(resolution_scaling_enabled,
3300 send_stream->resolution_scaling_enabled());
3301 EXPECT_EQ(fps_scaling_enabled, send_stream->framerate_scaling_enabled());
3302
Niels Möllerff40b142018-04-09 08:49:14 +02003303 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
asapersson3c81a1a2017-06-14 05:52:21 -07003304}
3305
eladalonf1841382017-06-12 01:16:46 -07003306void WebRtcVideoChannelTest::TestCpuAdaptation(bool enable_overuse,
3307 bool is_screenshare) {
magjed509e4fe2016-11-18 01:34:11 -08003308 cricket::VideoCodec codec = GetEngineCodec("VP8");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003309 cricket::VideoSendParameters parameters;
3310 parameters.codecs.push_back(codec);
nisse51542be2016-02-12 02:27:06 -08003311
kthelgason2bc68642017-02-07 07:02:22 -08003312 MediaConfig media_config = GetMediaConfig();
3313 if (enable_overuse) {
Niels Möller1d7ecd22018-01-18 15:25:12 +01003314 media_config.video.enable_cpu_adaptation = true;
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003315 }
Sebastian Jansson84848f22018-11-16 10:40:36 +01003316 channel_.reset(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07003317 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003318 channel_->OnReadyToSend(true);
nisse51542be2016-02-12 02:27:06 -08003319
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003320 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003321
3322 AddSendStream();
3323
Niels Möller805a27e2019-01-21 12:21:27 +01003324 webrtc::test::FrameForwarder frame_forwarder;
nisse05103312016-03-16 02:22:50 -07003325 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003326 options.is_screencast = is_screenshare;
Niels Möller805a27e2019-01-21 12:21:27 +01003327 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003328
3329 EXPECT_TRUE(channel_->SetSend(true));
3330
solenberge5269742015-09-08 05:13:22 -07003331 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
perkj2d5f0912016-02-29 00:04:41 -08003332
sprangc5d62e22017-04-02 23:53:04 -07003333 if (!enable_overuse) {
perkj803d97f2016-11-01 11:45:46 -07003334 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
sprangc5d62e22017-04-02 23:53:04 -07003335 EXPECT_FALSE(send_stream->framerate_scaling_enabled());
Niels Möller805a27e2019-01-21 12:21:27 +01003336 } else if (is_screenshare) {
sprangc5d62e22017-04-02 23:53:04 -07003337 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
3338 EXPECT_TRUE(send_stream->framerate_scaling_enabled());
3339 } else {
3340 EXPECT_TRUE(send_stream->resolution_scaling_enabled());
3341 EXPECT_FALSE(send_stream->framerate_scaling_enabled());
3342 }
Niels Möllerff40b142018-04-09 08:49:14 +02003343 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003344}
3345
eladalonf1841382017-06-12 01:16:46 -07003346TEST_F(WebRtcVideoChannelTest, EstimatesNtpStartTimeCorrectly) {
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003347 // Start at last timestamp to verify that wraparounds are estimated correctly.
3348 static const uint32_t kInitialTimestamp = 0xFFFFFFFFu;
3349 static const int64_t kInitialNtpTimeMs = 1247891230;
3350 static const int kFrameOffsetMs = 20;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003351 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003352
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003353 FakeVideoReceiveStream* stream = AddRecvStream();
3354 cricket::FakeVideoRenderer renderer;
nisse08582ff2016-02-04 01:24:52 -08003355 EXPECT_TRUE(channel_->SetSink(last_ssrc_, &renderer));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003356
Artem Titov1ebfb6a2019-01-03 23:49:37 +01003357 webrtc::VideoFrame video_frame =
3358 webrtc::VideoFrame::Builder()
3359 .set_video_frame_buffer(CreateBlackFrameBuffer(4, 4))
3360 .set_timestamp_rtp(kInitialTimestamp)
3361 .set_timestamp_us(0)
3362 .set_rotation(webrtc::kVideoRotation_0)
3363 .build();
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003364 // Initial NTP time is not available on the first frame, but should still be
3365 // able to be estimated.
nisseeb83a1a2016-03-21 01:27:56 -07003366 stream->InjectFrame(video_frame);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003367
3368 EXPECT_EQ(1, renderer.num_rendered_frames());
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003369
3370 // This timestamp is kInitialTimestamp (-1) + kFrameOffsetMs * 90, which
3371 // triggers a constant-overflow warning, hence we're calculating it explicitly
3372 // here.
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +02003373 fake_clock_.AdvanceTimeMicros(kFrameOffsetMs * rtc::kNumMicrosecsPerMillisec);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003374 video_frame.set_timestamp(kFrameOffsetMs * 90 - 1);
3375 video_frame.set_ntp_time_ms(kInitialNtpTimeMs + kFrameOffsetMs);
nisseeb83a1a2016-03-21 01:27:56 -07003376 stream->InjectFrame(video_frame);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003377
3378 EXPECT_EQ(2, renderer.num_rendered_frames());
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003379
3380 // Verify that NTP time has been correctly deduced.
3381 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00003382 ASSERT_TRUE(channel_->GetStats(&info));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003383 ASSERT_EQ(1u, info.receivers.size());
3384 EXPECT_EQ(kInitialNtpTimeMs, info.receivers[0].capture_start_ntp_time_ms);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003385}
3386
eladalonf1841382017-06-12 01:16:46 -07003387TEST_F(WebRtcVideoChannelTest, SetDefaultSendCodecs) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02003388 AssignDefaultAptRtxTypes();
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003389 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003390
3391 VideoCodec codec;
3392 EXPECT_TRUE(channel_->GetSendCodec(&codec));
pbos@webrtc.org9fbb7172014-06-13 09:34:13 +00003393 EXPECT_TRUE(codec.Matches(engine_.codecs()[0]));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003394
3395 // Using a RTX setup to verify that the default RTX payload type is good.
Peter Boström0c4e06b2015-10-07 12:23:21 +02003396 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
3397 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003398 FakeVideoSendStream* stream = AddSendStream(
3399 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
perkj26091b12016-09-01 01:17:40 -07003400 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003401
3402 // Make sure NACK and FEC are enabled on the correct payload types.
3403 EXPECT_EQ(1000, config.rtp.nack.rtp_history_ms);
magjed509e4fe2016-11-18 01:34:11 -08003404 EXPECT_EQ(GetEngineCodec("ulpfec").id, config.rtp.ulpfec.ulpfec_payload_type);
3405 EXPECT_EQ(GetEngineCodec("red").id, config.rtp.ulpfec.red_payload_type);
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003406
3407 EXPECT_EQ(1u, config.rtp.rtx.ssrcs.size());
3408 EXPECT_EQ(kRtxSsrcs1[0], config.rtp.rtx.ssrcs[0]);
Shao Changbine62202f2015-04-21 20:24:50 +08003409 VerifySendStreamHasRtxTypes(config, default_apt_rtx_types_);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003410 // TODO(juberti): Check RTCP, PLI, TMMBR.
3411}
3412
brandtr31bd2242017-05-19 05:47:46 -07003413// The following four tests ensures that FlexFEC is not activated by default
3414// when the field trials are not enabled.
3415// TODO(brandtr): Remove or update these tests when FlexFEC _is_ enabled by
3416// default.
Yves Gerey665174f2018-06-19 15:03:05 +02003417TEST_F(WebRtcVideoChannelTest, FlexfecSendCodecWithoutSsrcNotExposedByDefault) {
brandtr468da7c2016-11-22 02:16:47 -08003418 FakeVideoSendStream* stream = AddSendStream();
3419 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3420
brandtr3d200bd2017-01-16 06:59:19 -08003421 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr31bd2242017-05-19 05:47:46 -07003422 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3423 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
brandtr468da7c2016-11-22 02:16:47 -08003424}
3425
eladalonf1841382017-06-12 01:16:46 -07003426TEST_F(WebRtcVideoChannelTest, FlexfecSendCodecWithSsrcNotExposedByDefault) {
brandtr468da7c2016-11-22 02:16:47 -08003427 FakeVideoSendStream* stream = AddSendStream(
3428 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3429 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3430
brandtr3d200bd2017-01-16 06:59:19 -08003431 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr31bd2242017-05-19 05:47:46 -07003432 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3433 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3434}
3435
Yves Gerey665174f2018-06-19 15:03:05 +02003436TEST_F(WebRtcVideoChannelTest, FlexfecRecvCodecWithoutSsrcNotExposedByDefault) {
brandtr31bd2242017-05-19 05:47:46 -07003437 AddRecvStream();
3438
3439 const std::vector<FakeFlexfecReceiveStream*>& streams =
3440 fake_call_->GetFlexfecReceiveStreams();
3441 EXPECT_TRUE(streams.empty());
3442}
3443
eladalonf1841382017-06-12 01:16:46 -07003444TEST_F(WebRtcVideoChannelTest, FlexfecRecvCodecWithSsrcNotExposedByDefault) {
brandtr31bd2242017-05-19 05:47:46 -07003445 AddRecvStream(
3446 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3447
3448 const std::vector<FakeFlexfecReceiveStream*>& streams =
3449 fake_call_->GetFlexfecReceiveStreams();
3450 EXPECT_TRUE(streams.empty());
brandtr468da7c2016-11-22 02:16:47 -08003451}
3452
3453// TODO(brandtr): When FlexFEC is no longer behind a field trial, merge all
3454// tests that use this test fixture into the corresponding "non-field trial"
3455// tests.
eladalonf1841382017-06-12 01:16:46 -07003456class WebRtcVideoChannelFlexfecRecvTest : public WebRtcVideoChannelTest {
brandtr468da7c2016-11-22 02:16:47 -08003457 public:
eladalonf1841382017-06-12 01:16:46 -07003458 WebRtcVideoChannelFlexfecRecvTest()
3459 : WebRtcVideoChannelTest("WebRTC-FlexFEC-03-Advertised/Enabled/") {}
brandtr468da7c2016-11-22 02:16:47 -08003460};
3461
eladalonf1841382017-06-12 01:16:46 -07003462TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr36e7d702017-01-13 07:15:54 -08003463 DefaultFlexfecCodecHasTransportCcAndRembFeedbackParam) {
3464 EXPECT_TRUE(cricket::HasTransportCc(GetEngineCodec("flexfec-03")));
3465 EXPECT_TRUE(cricket::HasRemb(GetEngineCodec("flexfec-03")));
3466}
3467
eladalonf1841382017-06-12 01:16:46 -07003468TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetDefaultRecvCodecsWithoutSsrc) {
brandtr31bd2242017-05-19 05:47:46 -07003469 AddRecvStream();
3470
3471 const std::vector<FakeFlexfecReceiveStream*>& streams =
3472 fake_call_->GetFlexfecReceiveStreams();
3473 EXPECT_TRUE(streams.empty());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003474
3475 const std::vector<FakeVideoReceiveStream*>& video_streams =
3476 fake_call_->GetVideoReceiveStreams();
3477 ASSERT_EQ(1U, video_streams.size());
3478 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3479 EXPECT_EQ(0, video_stream.GetNumAddedSecondarySinks());
3480 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr31bd2242017-05-19 05:47:46 -07003481}
3482
eladalonf1841382017-06-12 01:16:46 -07003483TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetDefaultRecvCodecsWithSsrc) {
brandtr31bd2242017-05-19 05:47:46 -07003484 AddRecvStream(
3485 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3486
3487 const std::vector<FakeFlexfecReceiveStream*>& streams =
3488 fake_call_->GetFlexfecReceiveStreams();
3489 ASSERT_EQ(1U, streams.size());
3490 const FakeFlexfecReceiveStream* stream = streams.front();
3491 const webrtc::FlexfecReceiveStream::Config& config = stream->GetConfig();
3492 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.payload_type);
3493 EXPECT_EQ(kFlexfecSsrc, config.remote_ssrc);
3494 ASSERT_EQ(1U, config.protected_media_ssrcs.size());
3495 EXPECT_EQ(kSsrcs1[0], config.protected_media_ssrcs[0]);
brandtr7cd28b92017-09-22 00:26:25 -07003496
3497 const std::vector<FakeVideoReceiveStream*>& video_streams =
3498 fake_call_->GetVideoReceiveStreams();
3499 ASSERT_EQ(1U, video_streams.size());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003500 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3501 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
brandtr7cd28b92017-09-22 00:26:25 -07003502 const webrtc::VideoReceiveStream::Config& video_config =
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003503 video_stream.GetConfig();
brandtr7cd28b92017-09-22 00:26:25 -07003504 EXPECT_TRUE(video_config.rtp.protected_by_flexfec);
brandtr31bd2242017-05-19 05:47:46 -07003505}
3506
eladalonf1841382017-06-12 01:16:46 -07003507TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr11fb4722017-05-30 01:31:37 -07003508 EnablingFlexfecDoesNotRecreateVideoReceiveStream) {
3509 cricket::VideoRecvParameters recv_parameters;
3510 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3511 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3512
3513 AddRecvStream(
3514 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3515 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003516 const std::vector<FakeVideoReceiveStream*>& video_streams =
3517 fake_call_->GetVideoReceiveStreams();
3518 ASSERT_EQ(1U, video_streams.size());
3519 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3520 EXPECT_EQ(0, video_stream.GetNumAddedSecondarySinks());
3521 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003522
3523 // Enable FlexFEC.
3524 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3525 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3526 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams())
3527 << "Enabling FlexFEC should create FlexfecReceiveStream.";
3528 EXPECT_EQ(1U, fake_call_->GetVideoReceiveStreams().size())
3529 << "Enabling FlexFEC should not create VideoReceiveStream.";
3530 EXPECT_EQ(1U, fake_call_->GetFlexfecReceiveStreams().size())
3531 << "Enabling FlexFEC should create a single FlexfecReceiveStream.";
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003532 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3533 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003534}
3535
eladalonf1841382017-06-12 01:16:46 -07003536TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr11fb4722017-05-30 01:31:37 -07003537 DisablingFlexfecDoesNotRecreateVideoReceiveStream) {
3538 cricket::VideoRecvParameters recv_parameters;
3539 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3540 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3541 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3542
3543 AddRecvStream(
3544 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3545 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams());
brandtr11fb4722017-05-30 01:31:37 -07003546 EXPECT_EQ(1U, fake_call_->GetFlexfecReceiveStreams().size());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003547 const std::vector<FakeVideoReceiveStream*>& video_streams =
3548 fake_call_->GetVideoReceiveStreams();
3549 ASSERT_EQ(1U, video_streams.size());
3550 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3551 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3552 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003553
3554 // Disable FlexFEC.
3555 recv_parameters.codecs.clear();
3556 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3557 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3558 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams())
3559 << "Disabling FlexFEC should not recreate VideoReceiveStream.";
3560 EXPECT_EQ(1U, fake_call_->GetVideoReceiveStreams().size())
3561 << "Disabling FlexFEC should not destroy VideoReceiveStream.";
3562 EXPECT_TRUE(fake_call_->GetFlexfecReceiveStreams().empty())
3563 << "Disabling FlexFEC should destroy FlexfecReceiveStream.";
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003564 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3565 EXPECT_EQ(1, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003566}
3567
brandtr31bd2242017-05-19 05:47:46 -07003568// TODO(brandtr): When FlexFEC is no longer behind a field trial, merge all
3569// tests that use this test fixture into the corresponding "non-field trial"
3570// tests.
eladalonf1841382017-06-12 01:16:46 -07003571class WebRtcVideoChannelFlexfecSendRecvTest : public WebRtcVideoChannelTest {
brandtr31bd2242017-05-19 05:47:46 -07003572 public:
eladalonf1841382017-06-12 01:16:46 -07003573 WebRtcVideoChannelFlexfecSendRecvTest()
3574 : WebRtcVideoChannelTest(
brandtr31bd2242017-05-19 05:47:46 -07003575 "WebRTC-FlexFEC-03-Advertised/Enabled/WebRTC-FlexFEC-03/Enabled/") {
3576 }
3577};
3578
Yves Gerey665174f2018-06-19 15:03:05 +02003579TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetDefaultSendCodecsWithoutSsrc) {
brandtr468da7c2016-11-22 02:16:47 -08003580 FakeVideoSendStream* stream = AddSendStream();
3581 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3582
brandtr3d200bd2017-01-16 06:59:19 -08003583 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3584 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3585 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
brandtr468da7c2016-11-22 02:16:47 -08003586}
3587
eladalonf1841382017-06-12 01:16:46 -07003588TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetDefaultSendCodecsWithSsrc) {
brandtr468da7c2016-11-22 02:16:47 -08003589 FakeVideoSendStream* stream = AddSendStream(
3590 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3591 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3592
brandtr3d200bd2017-01-16 06:59:19 -08003593 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3594 EXPECT_EQ(kFlexfecSsrc, config.rtp.flexfec.ssrc);
3595 ASSERT_EQ(1U, config.rtp.flexfec.protected_media_ssrcs.size());
3596 EXPECT_EQ(kSsrcs1[0], config.rtp.flexfec.protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08003597}
3598
eladalonf1841382017-06-12 01:16:46 -07003599TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003600 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003601 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003602 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003603
3604 FakeVideoSendStream* stream = AddSendStream();
perkj26091b12016-09-01 01:17:40 -07003605 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003606
brandtrb5f2c3f2016-10-04 23:28:39 -07003607 EXPECT_EQ(-1, config.rtp.ulpfec.ulpfec_payload_type);
3608 EXPECT_EQ(-1, config.rtp.ulpfec.red_payload_type);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003609}
3610
eladalonf1841382017-06-12 01:16:46 -07003611TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetSendCodecsWithoutFec) {
brandtr468da7c2016-11-22 02:16:47 -08003612 cricket::VideoSendParameters parameters;
3613 parameters.codecs.push_back(GetEngineCodec("VP8"));
3614 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3615
3616 FakeVideoSendStream* stream = AddSendStream();
3617 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3618
brandtr3d200bd2017-01-16 06:59:19 -08003619 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr468da7c2016-11-22 02:16:47 -08003620}
3621
eladalonf1841382017-06-12 01:16:46 -07003622TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetRecvCodecsWithFec) {
brandtr9c3d4c42017-01-23 06:59:13 -08003623 AddRecvStream(
3624 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08003625
3626 cricket::VideoRecvParameters recv_parameters;
3627 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3628 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3629 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
brandtr9d58d942017-02-03 04:43:41 -08003630
3631 const std::vector<FakeFlexfecReceiveStream*>& flexfec_streams =
3632 fake_call_->GetFlexfecReceiveStreams();
3633 ASSERT_EQ(1U, flexfec_streams.size());
3634 const FakeFlexfecReceiveStream* flexfec_stream = flexfec_streams.front();
3635 const webrtc::FlexfecReceiveStream::Config& flexfec_stream_config =
3636 flexfec_stream->GetConfig();
brandtr9c3d4c42017-01-23 06:59:13 -08003637 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9d58d942017-02-03 04:43:41 -08003638 flexfec_stream_config.payload_type);
3639 EXPECT_EQ(kFlexfecSsrc, flexfec_stream_config.remote_ssrc);
3640 ASSERT_EQ(1U, flexfec_stream_config.protected_media_ssrcs.size());
3641 EXPECT_EQ(kSsrcs1[0], flexfec_stream_config.protected_media_ssrcs[0]);
3642 const std::vector<FakeVideoReceiveStream*>& video_streams =
3643 fake_call_->GetVideoReceiveStreams();
3644 const FakeVideoReceiveStream* video_stream = video_streams.front();
3645 const webrtc::VideoReceiveStream::Config& video_stream_config =
3646 video_stream->GetConfig();
3647 EXPECT_EQ(video_stream_config.rtp.local_ssrc,
3648 flexfec_stream_config.local_ssrc);
3649 EXPECT_EQ(video_stream_config.rtp.rtcp_mode, flexfec_stream_config.rtcp_mode);
3650 EXPECT_EQ(video_stream_config.rtcp_send_transport,
3651 flexfec_stream_config.rtcp_send_transport);
3652 // TODO(brandtr): Update this EXPECT when we set |transport_cc| in a
3653 // spec-compliant way.
3654 EXPECT_EQ(video_stream_config.rtp.transport_cc,
3655 flexfec_stream_config.transport_cc);
3656 EXPECT_EQ(video_stream_config.rtp.rtcp_mode, flexfec_stream_config.rtcp_mode);
3657 EXPECT_EQ(video_stream_config.rtp.extensions,
3658 flexfec_stream_config.rtp_header_extensions);
brandtr9c3d4c42017-01-23 06:59:13 -08003659}
3660
brandtr31bd2242017-05-19 05:47:46 -07003661// We should not send FlexFEC, even if we advertise it, unless the right
3662// field trial is set.
3663// TODO(brandtr): Remove when FlexFEC is enabled by default.
eladalonf1841382017-06-12 01:16:46 -07003664TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003665 SetSendCodecsWithoutSsrcWithFecDoesNotEnableFec) {
3666 cricket::VideoSendParameters parameters;
3667 parameters.codecs.push_back(GetEngineCodec("VP8"));
3668 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3669 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3670
3671 FakeVideoSendStream* stream = AddSendStream();
3672 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3673
3674 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
Mirko Bonadeif859e552018-05-30 15:31:29 +02003675 EXPECT_EQ(0u, config.rtp.flexfec.ssrc);
brandtr31bd2242017-05-19 05:47:46 -07003676 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3677}
3678
eladalonf1841382017-06-12 01:16:46 -07003679TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003680 SetSendCodecsWithSsrcWithFecDoesNotEnableFec) {
3681 cricket::VideoSendParameters parameters;
3682 parameters.codecs.push_back(GetEngineCodec("VP8"));
3683 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3684 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3685
3686 FakeVideoSendStream* stream = AddSendStream(
3687 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3688 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3689
3690 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
Mirko Bonadeif859e552018-05-30 15:31:29 +02003691 EXPECT_EQ(0u, config.rtp.flexfec.ssrc);
brandtr31bd2242017-05-19 05:47:46 -07003692 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3693}
3694
eladalonf1841382017-06-12 01:16:46 -07003695TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003696 SetSendCodecRejectsRtxWithoutAssociatedPayloadType) {
magjed509e4fe2016-11-18 01:34:11 -08003697 const int kUnusedPayloadType = 127;
3698 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType));
3699
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003700 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003701 cricket::VideoCodec rtx_codec(kUnusedPayloadType, "rtx");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003702 parameters.codecs.push_back(rtx_codec);
3703 EXPECT_FALSE(channel_->SetSendParameters(parameters))
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003704 << "RTX codec without associated payload type should be rejected.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003705}
3706
eladalonf1841382017-06-12 01:16:46 -07003707TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003708 SetSendCodecRejectsRtxWithoutMatchingVideoCodec) {
magjed509e4fe2016-11-18 01:34:11 -08003709 const int kUnusedPayloadType1 = 126;
3710 const int kUnusedPayloadType2 = 127;
3711 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
3712 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
3713 {
3714 cricket::VideoCodec rtx_codec = cricket::VideoCodec::CreateRtxCodec(
3715 kUnusedPayloadType1, GetEngineCodec("VP8").id);
3716 cricket::VideoSendParameters parameters;
3717 parameters.codecs.push_back(GetEngineCodec("VP8"));
3718 parameters.codecs.push_back(rtx_codec);
3719 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3720 }
3721 {
3722 cricket::VideoCodec rtx_codec = cricket::VideoCodec::CreateRtxCodec(
3723 kUnusedPayloadType1, kUnusedPayloadType2);
3724 cricket::VideoSendParameters parameters;
3725 parameters.codecs.push_back(GetEngineCodec("VP8"));
3726 parameters.codecs.push_back(rtx_codec);
3727 EXPECT_FALSE(channel_->SetSendParameters(parameters))
3728 << "RTX without matching video codec should be rejected.";
3729 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003730}
3731
eladalonf1841382017-06-12 01:16:46 -07003732TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithChangedRtxPayloadType) {
brandtr14742122017-01-27 04:53:07 -08003733 const int kUnusedPayloadType1 = 126;
3734 const int kUnusedPayloadType2 = 127;
3735 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
3736 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
3737
3738 // SSRCs for RTX.
3739 cricket::StreamParams params =
3740 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
3741 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
3742 AddSendStream(params);
3743
3744 // Original payload type for RTX.
3745 cricket::VideoSendParameters parameters;
3746 parameters.codecs.push_back(GetEngineCodec("VP8"));
3747 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
3748 rtx_codec.SetParam("apt", GetEngineCodec("VP8").id);
3749 parameters.codecs.push_back(rtx_codec);
3750 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3751 ASSERT_EQ(1U, fake_call_->GetVideoSendStreams().size());
3752 const webrtc::VideoSendStream::Config& config_before =
3753 fake_call_->GetVideoSendStreams()[0]->GetConfig();
3754 EXPECT_EQ(kUnusedPayloadType1, config_before.rtp.rtx.payload_type);
3755 ASSERT_EQ(1U, config_before.rtp.rtx.ssrcs.size());
3756 EXPECT_EQ(kRtxSsrcs1[0], config_before.rtp.rtx.ssrcs[0]);
3757
3758 // Change payload type for RTX.
3759 parameters.codecs[1].id = kUnusedPayloadType2;
3760 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3761 ASSERT_EQ(1U, fake_call_->GetVideoSendStreams().size());
3762 const webrtc::VideoSendStream::Config& config_after =
3763 fake_call_->GetVideoSendStreams()[0]->GetConfig();
3764 EXPECT_EQ(kUnusedPayloadType2, config_after.rtp.rtx.payload_type);
3765 ASSERT_EQ(1U, config_after.rtp.rtx.ssrcs.size());
3766 EXPECT_EQ(kRtxSsrcs1[0], config_after.rtp.rtx.ssrcs[0]);
3767}
3768
eladalonf1841382017-06-12 01:16:46 -07003769TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutFecDisablesFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003770 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003771 parameters.codecs.push_back(GetEngineCodec("VP8"));
3772 parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003773 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003774
3775 FakeVideoSendStream* stream = AddSendStream();
perkj26091b12016-09-01 01:17:40 -07003776 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003777
magjed509e4fe2016-11-18 01:34:11 -08003778 EXPECT_EQ(GetEngineCodec("ulpfec").id, config.rtp.ulpfec.ulpfec_payload_type);
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003779
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003780 parameters.codecs.pop_back();
3781 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003782 stream = fake_call_->GetVideoSendStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08003783 ASSERT_TRUE(stream != nullptr);
perkj26091b12016-09-01 01:17:40 -07003784 config = stream->GetConfig().Copy();
brandtrb5f2c3f2016-10-04 23:28:39 -07003785 EXPECT_EQ(-1, config.rtp.ulpfec.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08003786 << "SetSendCodec without ULPFEC should disable current ULPFEC.";
3787}
3788
eladalonf1841382017-06-12 01:16:46 -07003789TEST_F(WebRtcVideoChannelFlexfecSendRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003790 SetSendCodecsWithoutFecDisablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08003791 cricket::VideoSendParameters parameters;
3792 parameters.codecs.push_back(GetEngineCodec("VP8"));
3793 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3794 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3795
3796 FakeVideoSendStream* stream = AddSendStream(
3797 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3798 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3799
brandtr3d200bd2017-01-16 06:59:19 -08003800 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3801 EXPECT_EQ(kFlexfecSsrc, config.rtp.flexfec.ssrc);
brandtr468da7c2016-11-22 02:16:47 -08003802 ASSERT_EQ(1U, config.rtp.flexfec.protected_media_ssrcs.size());
3803 EXPECT_EQ(kSsrcs1[0], config.rtp.flexfec.protected_media_ssrcs[0]);
3804
3805 parameters.codecs.pop_back();
3806 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3807 stream = fake_call_->GetVideoSendStreams()[0];
3808 ASSERT_TRUE(stream != nullptr);
3809 config = stream->GetConfig().Copy();
brandtr3d200bd2017-01-16 06:59:19 -08003810 EXPECT_EQ(-1, config.rtp.flexfec.payload_type)
brandtr468da7c2016-11-22 02:16:47 -08003811 << "SetSendCodec without FlexFEC should disable current FlexFEC.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003812}
3813
eladalonf1841382017-06-12 01:16:46 -07003814TEST_F(WebRtcVideoChannelTest, SetSendCodecsChangesExistingStreams) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003815 cricket::VideoSendParameters parameters;
perkj26752742016-10-24 01:21:16 -07003816 cricket::VideoCodec codec(100, "VP8");
3817 codec.SetParam(kCodecParamMaxQuantization, kDefaultQpMax);
3818 parameters.codecs.push_back(codec);
perkjfa10b552016-10-02 23:45:26 -07003819
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003820 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00003821 channel_->SetSend(true);
pbos@webrtc.org38ce7d02014-07-16 08:01:38 +00003822
pbos@webrtc.org86196c42015-02-16 21:02:00 +00003823 FakeVideoSendStream* stream = AddSendStream();
Niels Möller805a27e2019-01-21 12:21:27 +01003824 webrtc::test::FrameForwarder frame_forwarder;
3825 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00003826
3827 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
perkjfa10b552016-10-02 23:45:26 -07003828 EXPECT_EQ(kDefaultQpMax, streams[0].max_qp);
pbos@webrtc.org38ce7d02014-07-16 08:01:38 +00003829
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003830 parameters.codecs.clear();
perkj26752742016-10-24 01:21:16 -07003831 codec.SetParam(kCodecParamMaxQuantization, kDefaultQpMax + 1);
3832 parameters.codecs.push_back(codec);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003833 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003834 streams = fake_call_->GetVideoSendStreams()[0]->GetVideoStreams();
perkjfa10b552016-10-02 23:45:26 -07003835 EXPECT_EQ(kDefaultQpMax + 1, streams[0].max_qp);
Niels Möllerff40b142018-04-09 08:49:14 +02003836 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003837}
3838
eladalonf1841382017-06-12 01:16:46 -07003839TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithBitrates) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00003840 SetSendCodecsShouldWorkForBitrates("100", 100000, "150", 150000, "200",
3841 200000);
3842}
3843
eladalonf1841382017-06-12 01:16:46 -07003844TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithHighMaxBitrate) {
pbos@webrtc.orga5f6fb52015-03-23 22:29:39 +00003845 SetSendCodecsShouldWorkForBitrates("", 0, "", -1, "10000", 10000000);
3846 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3847 ASSERT_EQ(1u, streams.size());
3848 EXPECT_EQ(10000000, streams[0].max_bitrate_bps);
3849}
3850
eladalonf1841382017-06-12 01:16:46 -07003851TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org00873182014-11-25 14:03:34 +00003852 SetSendCodecsWithoutBitratesUsesCorrectDefaults) {
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003853 SetSendCodecsShouldWorkForBitrates("", 0, "", -1, "", -1);
pbos@webrtc.org00873182014-11-25 14:03:34 +00003854}
3855
eladalonf1841382017-06-12 01:16:46 -07003856TEST_F(WebRtcVideoChannelTest, SetSendCodecsCapsMinAndStartBitrate) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00003857 SetSendCodecsShouldWorkForBitrates("-1", 0, "-100", -1, "", -1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003858}
3859
eladalonf1841382017-06-12 01:16:46 -07003860TEST_F(WebRtcVideoChannelTest, SetSendCodecsRejectsMaxLessThanMinBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003861 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "300";
3862 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "200";
3863 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003864}
3865
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003866// Test that when both the codec-specific bitrate params and max_bandwidth_bps
3867// are present in the same send parameters, the settings are combined correctly.
eladalonf1841382017-06-12 01:16:46 -07003868TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithBitratesAndMaxSendBandwidth) {
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003869 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
3870 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
3871 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
3872 send_parameters_.max_bandwidth_bps = 400000;
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003873 // We expect max_bandwidth_bps to take priority, if set.
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003874 ExpectSetBitrateParameters(100000, 200000, 400000);
3875 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
3876 // Since the codec isn't changing, start_bitrate_bps should be -1.
3877 ExpectSetBitrateParameters(100000, -1, 350000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003878
3879 // Decrease max_bandwidth_bps.
3880 send_parameters_.max_bandwidth_bps = 350000;
3881 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003882
3883 // Now try again with the values flipped around.
3884 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "400";
3885 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003886 ExpectSetBitrateParameters(100000, 200000, 300000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003887 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003888
3889 // If we change the codec max, max_bandwidth_bps should still apply.
3890 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "350";
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003891 ExpectSetBitrateParameters(100000, 200000, 300000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003892 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003893}
3894
Yves Gerey665174f2018-06-19 15:03:05 +02003895TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthShouldPreserveOtherBitrates) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00003896 SetSendCodecsShouldWorkForBitrates("100", 100000, "150", 150000, "200",
3897 200000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003898 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003899 // Setting max bitrate should keep previous min bitrate.
3900 // Setting max bitrate should not reset start bitrate.
3901 ExpectSetBitrateParameters(100000, -1, 300000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003902 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org00873182014-11-25 14:03:34 +00003903}
3904
eladalonf1841382017-06-12 01:16:46 -07003905TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthShouldBeRemovable) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003906 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003907 ExpectSetMaxBitrate(300000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003908 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos5c7760a2017-03-10 11:23:12 -08003909 // -1 means to disable max bitrate (set infinite).
3910 send_parameters_.max_bandwidth_bps = -1;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003911 ExpectSetMaxBitrate(-1);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003912 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003913}
3914
eladalonf1841382017-06-12 01:16:46 -07003915TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthAndAddSendStream) {
perkjfa10b552016-10-02 23:45:26 -07003916 send_parameters_.max_bandwidth_bps = 99999;
3917 FakeVideoSendStream* stream = AddSendStream();
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003918 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
perkjfa10b552016-10-02 23:45:26 -07003919 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
perkjfa10b552016-10-02 23:45:26 -07003920 ASSERT_EQ(1u, stream->GetVideoStreams().size());
3921 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
3922 stream->GetVideoStreams()[0].max_bitrate_bps);
3923
3924 send_parameters_.max_bandwidth_bps = 77777;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003925 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
perkjfa10b552016-10-02 23:45:26 -07003926 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
3927 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
perkjfa10b552016-10-02 23:45:26 -07003928 stream->GetVideoStreams()[0].max_bitrate_bps);
3929}
3930
Seth Hampsonfeec91e2018-07-13 10:41:10 -07003931// Tests that when the codec specific max bitrate and VideoSendParameters
3932// max_bandwidth_bps are used, that it sets the VideoStream's max bitrate
3933// appropriately.
3934TEST_F(WebRtcVideoChannelTest,
3935 MaxBitratePrioritizesVideoSendParametersOverCodecMaxBitrate) {
3936 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
3937 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
3938 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
3939 send_parameters_.max_bandwidth_bps = -1;
3940 AddSendStream();
3941 ExpectSetMaxBitrate(300000);
3942 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
3943
3944 std::vector<FakeVideoSendStream*> video_send_streams = GetFakeSendStreams();
3945 ASSERT_EQ(1u, video_send_streams.size());
3946 FakeVideoSendStream* video_send_stream = video_send_streams[0];
3947 ASSERT_EQ(1u, video_send_streams[0]->GetVideoStreams().size());
3948 // First the max bitrate is set based upon the codec param.
3949 EXPECT_EQ(300000,
3950 video_send_streams[0]->GetVideoStreams()[0].max_bitrate_bps);
3951
3952 // The VideoSendParameters max bitrate overrides the codec's.
3953 send_parameters_.max_bandwidth_bps = 500000;
3954 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
3955 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
3956 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
3957 EXPECT_EQ(500000, video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
3958}
3959
3960// Tests that when the codec specific max bitrate and RtpParameters
3961// max_bitrate_bps are used, that it sets the VideoStream's max bitrate
3962// appropriately.
3963TEST_F(WebRtcVideoChannelTest,
3964 MaxBitratePrioritizesRtpParametersOverCodecMaxBitrate) {
3965 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
3966 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
3967 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
3968 send_parameters_.max_bandwidth_bps = -1;
3969 AddSendStream();
3970 ExpectSetMaxBitrate(300000);
3971 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
3972
3973 std::vector<FakeVideoSendStream*> video_send_streams = GetFakeSendStreams();
3974 ASSERT_EQ(1u, video_send_streams.size());
3975 FakeVideoSendStream* video_send_stream = video_send_streams[0];
3976 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
3977 // First the max bitrate is set based upon the codec param.
3978 EXPECT_EQ(300000, video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
3979
3980 // The RtpParameter max bitrate overrides the codec's.
3981 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
3982 ASSERT_EQ(1u, parameters.encodings.size());
3983 parameters.encodings[0].max_bitrate_bps = 500000;
3984 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
3985 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
3986 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps,
3987 video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
3988}
3989
Åsa Persson55659812018-06-18 17:51:32 +02003990TEST_F(WebRtcVideoChannelTest,
3991 MaxBitrateIsMinimumOfMaxSendBandwidthAndMaxEncodingBitrate) {
3992 send_parameters_.max_bandwidth_bps = 99999;
3993 FakeVideoSendStream* stream = AddSendStream();
3994 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
3995 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
3996 ASSERT_EQ(1u, stream->GetVideoStreams().size());
3997 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
3998 stream->GetVideoStreams()[0].max_bitrate_bps);
3999
4000 // Get and set the rtp encoding parameters.
4001 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
4002 EXPECT_EQ(1u, parameters.encodings.size());
4003
4004 parameters.encodings[0].max_bitrate_bps = 99999 - 1;
4005 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4006 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps,
4007 stream->GetVideoStreams()[0].max_bitrate_bps);
4008
4009 parameters.encodings[0].max_bitrate_bps = 99999 + 1;
4010 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4011 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4012 stream->GetVideoStreams()[0].max_bitrate_bps);
4013}
4014
eladalonf1841382017-06-12 01:16:46 -07004015TEST_F(WebRtcVideoChannelTest, SetMaxSendBitrateCanIncreaseSenderBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004016 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004017 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004018 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004019 channel_->SetSend(true);
4020
4021 FakeVideoSendStream* stream = AddSendStream();
4022
Niels Möller805a27e2019-01-21 12:21:27 +01004023 webrtc::test::FrameForwarder frame_forwarder;
4024 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Peter Boström3afc8c42016-01-27 16:45:21 +01004025
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004026 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
4027 int initial_max_bitrate_bps = streams[0].max_bitrate_bps;
4028 EXPECT_GT(initial_max_bitrate_bps, 0);
4029
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004030 parameters.max_bandwidth_bps = initial_max_bitrate_bps * 2;
4031 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström3afc8c42016-01-27 16:45:21 +01004032 // Insert a frame to update the encoder config.
Niels Möller805a27e2019-01-21 12:21:27 +01004033 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004034 streams = stream->GetVideoStreams();
4035 EXPECT_EQ(initial_max_bitrate_bps * 2, streams[0].max_bitrate_bps);
Niels Möllerff40b142018-04-09 08:49:14 +02004036 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004037}
4038
eladalonf1841382017-06-12 01:16:46 -07004039TEST_F(WebRtcVideoChannelTest,
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004040 SetMaxSendBitrateCanIncreaseSimulcastSenderBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004041 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004042 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004043 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004044 channel_->SetSend(true);
4045
4046 FakeVideoSendStream* stream = AddSendStream(
4047 cricket::CreateSimStreamParams("cname", MAKE_VECTOR(kSsrcs3)));
4048
4049 // Send a frame to make sure this scales up to >1 stream (simulcast).
Niels Möller805a27e2019-01-21 12:21:27 +01004050 webrtc::test::FrameForwarder frame_forwarder;
4051 EXPECT_TRUE(channel_->SetVideoSend(kSsrcs3[0], nullptr, &frame_forwarder));
4052 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004053
4054 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
4055 ASSERT_GT(streams.size(), 1u)
4056 << "Without simulcast this test doesn't make sense.";
pbosbe16f792015-10-16 12:49:39 -07004057 int initial_max_bitrate_bps = GetTotalMaxBitrateBps(streams);
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004058 EXPECT_GT(initial_max_bitrate_bps, 0);
4059
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004060 parameters.max_bandwidth_bps = initial_max_bitrate_bps * 2;
4061 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström3afc8c42016-01-27 16:45:21 +01004062 // Insert a frame to update the encoder config.
Niels Möller805a27e2019-01-21 12:21:27 +01004063 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004064 streams = stream->GetVideoStreams();
pbosbe16f792015-10-16 12:49:39 -07004065 int increased_max_bitrate_bps = GetTotalMaxBitrateBps(streams);
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004066 EXPECT_EQ(initial_max_bitrate_bps * 2, increased_max_bitrate_bps);
4067
Niels Möllerff40b142018-04-09 08:49:14 +02004068 EXPECT_TRUE(channel_->SetVideoSend(kSsrcs3[0], nullptr, nullptr));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004069}
4070
eladalonf1841382017-06-12 01:16:46 -07004071TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithMaxQuantization) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004072 static const char* kMaxQuantization = "21";
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004073 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004074 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004075 parameters.codecs[0].params[kCodecParamMaxQuantization] = kMaxQuantization;
4076 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Mirko Bonadeif859e552018-05-30 15:31:29 +02004077 EXPECT_EQ(atoi(kMaxQuantization),
pbos@webrtc.org6ae48c62014-06-06 10:49:19 +00004078 AddSendStream()->GetVideoStreams().back().max_qp);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004079
4080 VideoCodec codec;
4081 EXPECT_TRUE(channel_->GetSendCodec(&codec));
4082 EXPECT_EQ(kMaxQuantization, codec.params[kCodecParamMaxQuantization]);
4083}
4084
eladalonf1841382017-06-12 01:16:46 -07004085TEST_F(WebRtcVideoChannelTest, SetSendCodecsRejectBadPayloadTypes) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004086 // TODO(pbos): Should we only allow the dynamic range?
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00004087 static const int kIncorrectPayloads[] = {-2, -1, 128, 129};
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004088 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004089 parameters.codecs.push_back(GetEngineCodec("VP8"));
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00004090 for (size_t i = 0; i < arraysize(kIncorrectPayloads); ++i) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004091 parameters.codecs[0].id = kIncorrectPayloads[i];
4092 EXPECT_FALSE(channel_->SetSendParameters(parameters))
pkasting@chromium.orgd3245462015-02-23 21:28:22 +00004093 << "Bad payload type '" << kIncorrectPayloads[i] << "' accepted.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004094 }
4095}
4096
eladalonf1841382017-06-12 01:16:46 -07004097TEST_F(WebRtcVideoChannelTest, SetSendCodecsAcceptAllValidPayloadTypes) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004098 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004099 parameters.codecs.push_back(GetEngineCodec("VP8"));
magjedf823ede2016-11-12 09:53:04 -08004100 for (int payload_type = 96; payload_type <= 127; ++payload_type) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004101 parameters.codecs[0].id = payload_type;
4102 EXPECT_TRUE(channel_->SetSendParameters(parameters))
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004103 << "Payload type '" << payload_type << "' rejected.";
4104 }
4105}
4106
deadbeef67cf2c12016-04-13 10:07:16 -07004107// Test that setting the a different set of codecs but with an identical front
4108// codec doesn't result in the stream being recreated.
4109// This may happen when a subsequent negotiation includes fewer codecs, as a
4110// result of one of the codecs being rejected.
eladalonf1841382017-06-12 01:16:46 -07004111TEST_F(WebRtcVideoChannelTest,
deadbeef67cf2c12016-04-13 10:07:16 -07004112 SetSendCodecsIdenticalFirstCodecDoesntRecreateStream) {
4113 cricket::VideoSendParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08004114 parameters1.codecs.push_back(GetEngineCodec("VP8"));
4115 parameters1.codecs.push_back(GetEngineCodec("VP9"));
deadbeef67cf2c12016-04-13 10:07:16 -07004116 EXPECT_TRUE(channel_->SetSendParameters(parameters1));
4117
4118 AddSendStream();
4119 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
4120
4121 cricket::VideoSendParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08004122 parameters2.codecs.push_back(GetEngineCodec("VP8"));
deadbeef67cf2c12016-04-13 10:07:16 -07004123 EXPECT_TRUE(channel_->SetSendParameters(parameters2));
4124 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
4125}
4126
eladalonf1841382017-06-12 01:16:46 -07004127TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithOnlyVp8) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004128 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004129 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004130 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004131}
4132
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004133// Test that we set our inbound RTX codecs properly.
eladalonf1841382017-06-12 01:16:46 -07004134TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithRtx) {
magjed509e4fe2016-11-18 01:34:11 -08004135 const int kUnusedPayloadType1 = 126;
4136 const int kUnusedPayloadType2 = 127;
4137 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4138 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4139
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004140 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004141 parameters.codecs.push_back(GetEngineCodec("VP8"));
4142 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004143 parameters.codecs.push_back(rtx_codec);
4144 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004145 << "RTX codec without associated payload should be rejected.";
4146
magjed509e4fe2016-11-18 01:34:11 -08004147 parameters.codecs[1].SetParam("apt", kUnusedPayloadType2);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004148 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004149 << "RTX codec with invalid associated payload type should be rejected.";
4150
magjed509e4fe2016-11-18 01:34:11 -08004151 parameters.codecs[1].SetParam("apt", GetEngineCodec("VP8").id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004152 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004153
magjed509e4fe2016-11-18 01:34:11 -08004154 cricket::VideoCodec rtx_codec2(kUnusedPayloadType2, "rtx");
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004155 rtx_codec2.SetParam("apt", rtx_codec.id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004156 parameters.codecs.push_back(rtx_codec2);
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004157
Yves Gerey665174f2018-06-19 15:03:05 +02004158 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
4159 << "RTX codec with another RTX as associated payload type should be "
4160 "rejected.";
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004161}
4162
eladalonf1841382017-06-12 01:16:46 -07004163TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithChangedRtxPayloadType) {
brandtr14742122017-01-27 04:53:07 -08004164 const int kUnusedPayloadType1 = 126;
4165 const int kUnusedPayloadType2 = 127;
4166 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4167 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4168
4169 // SSRCs for RTX.
4170 cricket::StreamParams params =
4171 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
4172 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
4173 AddRecvStream(params);
4174
4175 // Original payload type for RTX.
4176 cricket::VideoRecvParameters parameters;
4177 parameters.codecs.push_back(GetEngineCodec("VP8"));
4178 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
4179 rtx_codec.SetParam("apt", GetEngineCodec("VP8").id);
4180 parameters.codecs.push_back(rtx_codec);
4181 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4182 ASSERT_EQ(1U, fake_call_->GetVideoReceiveStreams().size());
4183 const webrtc::VideoReceiveStream::Config& config_before =
4184 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
nisse26e3abb2017-08-25 04:44:25 -07004185 EXPECT_EQ(1U, config_before.rtp.rtx_associated_payload_types.size());
4186 const int* payload_type_before = FindKeyByValue(
4187 config_before.rtp.rtx_associated_payload_types, GetEngineCodec("VP8").id);
4188 ASSERT_NE(payload_type_before, nullptr);
4189 EXPECT_EQ(kUnusedPayloadType1, *payload_type_before);
brandtr14742122017-01-27 04:53:07 -08004190 EXPECT_EQ(kRtxSsrcs1[0], config_before.rtp.rtx_ssrc);
4191
4192 // Change payload type for RTX.
4193 parameters.codecs[1].id = kUnusedPayloadType2;
4194 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4195 ASSERT_EQ(1U, fake_call_->GetVideoReceiveStreams().size());
4196 const webrtc::VideoReceiveStream::Config& config_after =
4197 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
nisse26e3abb2017-08-25 04:44:25 -07004198 EXPECT_EQ(1U, config_after.rtp.rtx_associated_payload_types.size());
4199 const int* payload_type_after = FindKeyByValue(
4200 config_after.rtp.rtx_associated_payload_types, GetEngineCodec("VP8").id);
4201 ASSERT_NE(payload_type_after, nullptr);
4202 EXPECT_EQ(kUnusedPayloadType2, *payload_type_after);
brandtr14742122017-01-27 04:53:07 -08004203 EXPECT_EQ(kRtxSsrcs1[0], config_after.rtp.rtx_ssrc);
4204}
4205
eladalonf1841382017-06-12 01:16:46 -07004206TEST_F(WebRtcVideoChannelTest, SetRecvCodecsDifferentPayloadType) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004207 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004208 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004209 parameters.codecs[0].id = 99;
4210 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004211}
4212
eladalonf1841382017-06-12 01:16:46 -07004213TEST_F(WebRtcVideoChannelTest, SetRecvCodecsAcceptDefaultCodecs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004214 cricket::VideoRecvParameters parameters;
4215 parameters.codecs = engine_.codecs();
4216 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgccbed3b2014-07-11 13:02:54 +00004217
4218 FakeVideoReceiveStream* stream = AddRecvStream();
Tommi733b5472016-06-10 17:58:01 +02004219 const webrtc::VideoReceiveStream::Config& config = stream->GetConfig();
Niels Möllercb7e1d22018-09-11 15:56:04 +02004220 EXPECT_EQ(engine_.codecs()[0].name, config.decoders[0].video_format.name);
pbos@webrtc.org776e6f22014-10-29 15:28:39 +00004221 EXPECT_EQ(engine_.codecs()[0].id, config.decoders[0].payload_type);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004222}
4223
eladalonf1841382017-06-12 01:16:46 -07004224TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectUnsupportedCodec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004225 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004226 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkj26752742016-10-24 01:21:16 -07004227 parameters.codecs.push_back(VideoCodec(101, "WTF3"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004228 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004229}
4230
eladalonf1841382017-06-12 01:16:46 -07004231TEST_F(WebRtcVideoChannelTest, SetRecvCodecsAcceptsMultipleVideoCodecs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004232 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004233 parameters.codecs.push_back(GetEngineCodec("VP8"));
4234 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004235 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004236}
4237
eladalonf1841382017-06-12 01:16:46 -07004238TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithoutFecDisablesFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004239 cricket::VideoSendParameters send_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004240 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4241 send_parameters.codecs.push_back(GetEngineCodec("red"));
4242 send_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004243 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004244
4245 FakeVideoReceiveStream* stream = AddRecvStream();
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004246
magjed509e4fe2016-11-18 01:34:11 -08004247 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004248 stream->GetConfig().rtp.ulpfec_payload_type);
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004249
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004250 cricket::VideoRecvParameters recv_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004251 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004252 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00004253 stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004254 ASSERT_TRUE(stream != nullptr);
nisse3b3622f2017-09-26 02:49:21 -07004255 EXPECT_EQ(-1, stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004256 << "SetSendCodec without ULPFEC should disable current ULPFEC.";
4257}
4258
eladalonf1841382017-06-12 01:16:46 -07004259TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetRecvParamsWithoutFecDisablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004260 AddRecvStream(
4261 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08004262 const std::vector<FakeFlexfecReceiveStream*>& streams =
brandtr468da7c2016-11-22 02:16:47 -08004263 fake_call_->GetFlexfecReceiveStreams();
4264
4265 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004266 const FakeFlexfecReceiveStream* stream = streams.front();
4267 EXPECT_EQ(GetEngineCodec("flexfec-03").id, stream->GetConfig().payload_type);
4268 EXPECT_EQ(kFlexfecSsrc, stream->GetConfig().remote_ssrc);
4269 ASSERT_EQ(1U, stream->GetConfig().protected_media_ssrcs.size());
4270 EXPECT_EQ(kSsrcs1[0], stream->GetConfig().protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08004271
4272 cricket::VideoRecvParameters recv_parameters;
4273 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4274 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4275 EXPECT_TRUE(streams.empty())
4276 << "SetSendCodec without FlexFEC should disable current FlexFEC.";
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004277}
4278
eladalonf1841382017-06-12 01:16:46 -07004279TEST_F(WebRtcVideoChannelTest, SetSendParamsWithFecEnablesFec) {
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004280 FakeVideoReceiveStream* stream = AddRecvStream();
magjed509e4fe2016-11-18 01:34:11 -08004281 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004282 stream->GetConfig().rtp.ulpfec_payload_type);
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004283
4284 cricket::VideoRecvParameters recv_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004285 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4286 recv_parameters.codecs.push_back(GetEngineCodec("red"));
4287 recv_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004288 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4289 stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004290 ASSERT_TRUE(stream != nullptr);
magjed509e4fe2016-11-18 01:34:11 -08004291 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004292 stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004293 << "ULPFEC should be enabled on the receive stream.";
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004294
4295 cricket::VideoSendParameters send_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004296 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4297 send_parameters.codecs.push_back(GetEngineCodec("red"));
4298 send_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004299 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
4300 stream = fake_call_->GetVideoReceiveStreams()[0];
magjed509e4fe2016-11-18 01:34:11 -08004301 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004302 stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004303 << "ULPFEC should be enabled on the receive stream.";
4304}
4305
eladalonf1841382017-06-12 01:16:46 -07004306TEST_F(WebRtcVideoChannelFlexfecSendRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004307 SetSendRecvParamsWithFecEnablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004308 AddRecvStream(
4309 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08004310 const std::vector<FakeFlexfecReceiveStream*>& streams =
brandtr468da7c2016-11-22 02:16:47 -08004311 fake_call_->GetFlexfecReceiveStreams();
4312
4313 cricket::VideoRecvParameters recv_parameters;
4314 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4315 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4316 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4317 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004318 const FakeFlexfecReceiveStream* stream_with_recv_params = streams.front();
brandtr468da7c2016-11-22 02:16:47 -08004319 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9c3d4c42017-01-23 06:59:13 -08004320 stream_with_recv_params->GetConfig().payload_type);
4321 EXPECT_EQ(kFlexfecSsrc, stream_with_recv_params->GetConfig().remote_ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004322 EXPECT_EQ(1U,
brandtr9c3d4c42017-01-23 06:59:13 -08004323 stream_with_recv_params->GetConfig().protected_media_ssrcs.size());
brandtr468da7c2016-11-22 02:16:47 -08004324 EXPECT_EQ(kSsrcs1[0],
brandtr9c3d4c42017-01-23 06:59:13 -08004325 stream_with_recv_params->GetConfig().protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08004326
4327 cricket::VideoSendParameters send_parameters;
4328 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4329 send_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4330 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
4331 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004332 const FakeFlexfecReceiveStream* stream_with_send_params = streams.front();
brandtr468da7c2016-11-22 02:16:47 -08004333 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9c3d4c42017-01-23 06:59:13 -08004334 stream_with_send_params->GetConfig().payload_type);
4335 EXPECT_EQ(kFlexfecSsrc, stream_with_send_params->GetConfig().remote_ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004336 EXPECT_EQ(1U,
brandtr9c3d4c42017-01-23 06:59:13 -08004337 stream_with_send_params->GetConfig().protected_media_ssrcs.size());
brandtr468da7c2016-11-22 02:16:47 -08004338 EXPECT_EQ(kSsrcs1[0],
brandtr9c3d4c42017-01-23 06:59:13 -08004339 stream_with_send_params->GetConfig().protected_media_ssrcs[0]);
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004340}
4341
eladalonf1841382017-06-12 01:16:46 -07004342TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectDuplicateFecPayloads) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004343 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004344 parameters.codecs.push_back(GetEngineCodec("VP8"));
4345 parameters.codecs.push_back(GetEngineCodec("red"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004346 parameters.codecs[1].id = parameters.codecs[0].id;
4347 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004348}
4349
eladalonf1841382017-06-12 01:16:46 -07004350TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004351 SetRecvCodecsRejectDuplicateFecPayloads) {
brandtr468da7c2016-11-22 02:16:47 -08004352 cricket::VideoRecvParameters parameters;
4353 parameters.codecs.push_back(GetEngineCodec("VP8"));
4354 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4355 parameters.codecs[1].id = parameters.codecs[0].id;
4356 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
4357}
4358
eladalonf1841382017-06-12 01:16:46 -07004359TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectDuplicateCodecPayloads) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004360 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004361 parameters.codecs.push_back(GetEngineCodec("VP8"));
4362 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004363 parameters.codecs[1].id = parameters.codecs[0].id;
4364 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004365}
4366
eladalonf1841382017-06-12 01:16:46 -07004367TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004368 SetRecvCodecsAcceptSameCodecOnMultiplePayloadTypes) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004369 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004370 parameters.codecs.push_back(GetEngineCodec("VP8"));
4371 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004372 parameters.codecs[1].id += 1;
4373 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004374}
4375
deadbeef67cf2c12016-04-13 10:07:16 -07004376// Test that setting the same codecs but with a different order
deadbeef874ca3a2015-08-20 17:19:20 -07004377// doesn't result in the stream being recreated.
eladalonf1841382017-06-12 01:16:46 -07004378TEST_F(WebRtcVideoChannelTest,
deadbeef67cf2c12016-04-13 10:07:16 -07004379 SetRecvCodecsDifferentOrderDoesntRecreateStream) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004380 cricket::VideoRecvParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08004381 parameters1.codecs.push_back(GetEngineCodec("VP8"));
4382 parameters1.codecs.push_back(GetEngineCodec("red"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004383 EXPECT_TRUE(channel_->SetRecvParameters(parameters1));
deadbeef874ca3a2015-08-20 17:19:20 -07004384
4385 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
4386 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
4387
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004388 cricket::VideoRecvParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08004389 parameters2.codecs.push_back(GetEngineCodec("red"));
4390 parameters2.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004391 EXPECT_TRUE(channel_->SetRecvParameters(parameters2));
deadbeef874ca3a2015-08-20 17:19:20 -07004392 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
4393}
4394
eladalonf1841382017-06-12 01:16:46 -07004395TEST_F(WebRtcVideoChannelTest, SendStreamNotSendingByDefault) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004396 EXPECT_FALSE(AddSendStream()->IsSending());
4397}
4398
eladalonf1841382017-06-12 01:16:46 -07004399TEST_F(WebRtcVideoChannelTest, ReceiveStreamReceivingByDefault) {
pbos@webrtc.org85f42942014-07-22 09:14:58 +00004400 EXPECT_TRUE(AddRecvStream()->IsReceiving());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004401}
4402
eladalonf1841382017-06-12 01:16:46 -07004403TEST_F(WebRtcVideoChannelTest, SetSend) {
pbos@webrtc.org5301b0f2014-07-17 08:51:46 +00004404 FakeVideoSendStream* stream = AddSendStream();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004405 EXPECT_FALSE(stream->IsSending());
4406
4407 // false->true
4408 EXPECT_TRUE(channel_->SetSend(true));
4409 EXPECT_TRUE(stream->IsSending());
4410 // true->true
4411 EXPECT_TRUE(channel_->SetSend(true));
4412 EXPECT_TRUE(stream->IsSending());
4413 // true->false
4414 EXPECT_TRUE(channel_->SetSend(false));
4415 EXPECT_FALSE(stream->IsSending());
4416 // false->false
4417 EXPECT_TRUE(channel_->SetSend(false));
4418 EXPECT_FALSE(stream->IsSending());
4419
4420 EXPECT_TRUE(channel_->SetSend(true));
4421 FakeVideoSendStream* new_stream = AddSendStream();
4422 EXPECT_TRUE(new_stream->IsSending())
4423 << "Send stream created after SetSend(true) not sending initially.";
4424}
4425
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004426// This test verifies DSCP settings are properly applied on video media channel.
eladalonf1841382017-06-12 01:16:46 -07004427TEST_F(WebRtcVideoChannelTest, TestSetDscpOptions) {
kwiberg686a8ef2016-02-26 03:00:35 -08004428 std::unique_ptr<cricket::FakeNetworkInterface> network_interface(
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004429 new cricket::FakeNetworkInterface);
nisse51542be2016-02-12 02:27:06 -08004430 MediaConfig config;
Tim Haloun6ca98362018-09-17 17:06:08 -07004431 std::unique_ptr<cricket::WebRtcVideoChannel> channel;
Tim Haloun648d28a2018-10-18 16:52:22 -07004432 webrtc::RtpParameters parameters;
nisse51542be2016-02-12 02:27:06 -08004433
Sebastian Jansson84848f22018-11-16 10:40:36 +01004434 channel.reset(
4435 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
4436 call_.get(), config, VideoOptions(), webrtc::CryptoOptions())));
Anton Sukhanov98a462c2018-10-17 13:15:42 -07004437 channel->SetInterface(network_interface.get(), /*media_transport=*/nullptr);
nisse51542be2016-02-12 02:27:06 -08004438 // Default value when DSCP is disabled should be DSCP_DEFAULT.
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004439 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
nisse51542be2016-02-12 02:27:06 -08004440
Tim Haloun648d28a2018-10-18 16:52:22 -07004441 // Default value when DSCP is enabled is also DSCP_DEFAULT, until it is set
4442 // through rtp parameters.
nisse51542be2016-02-12 02:27:06 -08004443 config.enable_dscp = true;
Sebastian Jansson84848f22018-11-16 10:40:36 +01004444 channel.reset(
4445 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
4446 call_.get(), config, VideoOptions(), webrtc::CryptoOptions())));
Anton Sukhanov98a462c2018-10-17 13:15:42 -07004447 channel->SetInterface(network_interface.get(), /*media_transport=*/nullptr);
Tim Haloun648d28a2018-10-18 16:52:22 -07004448 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
4449
4450 // Create a send stream to configure
4451 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
4452 parameters = channel->GetRtpSendParameters(kSsrc);
4453 ASSERT_FALSE(parameters.encodings.empty());
4454
4455 // Various priorities map to various dscp values.
4456 parameters.encodings[0].network_priority = 4.0;
4457 ASSERT_TRUE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
nisse51542be2016-02-12 02:27:06 -08004458 EXPECT_EQ(rtc::DSCP_AF41, network_interface->dscp());
Tim Haloun648d28a2018-10-18 16:52:22 -07004459 parameters.encodings[0].network_priority = 0.5;
4460 ASSERT_TRUE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
4461 EXPECT_EQ(rtc::DSCP_CS1, network_interface->dscp());
4462
4463 // A bad priority does not change the dscp value.
4464 parameters.encodings[0].network_priority = 0.0;
4465 ASSERT_FALSE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
4466 EXPECT_EQ(rtc::DSCP_CS1, network_interface->dscp());
nisse51542be2016-02-12 02:27:06 -08004467
Tim Haloun6ca98362018-09-17 17:06:08 -07004468 // Packets should also self-identify their dscp in PacketOptions.
4469 const uint8_t kData[10] = {0};
4470 EXPECT_TRUE(static_cast<webrtc::Transport*>(channel.get())
4471 ->SendRtcp(kData, sizeof(kData)));
Tim Haloun648d28a2018-10-18 16:52:22 -07004472 EXPECT_EQ(rtc::DSCP_CS1, network_interface->options().dscp);
Tim Haloun6ca98362018-09-17 17:06:08 -07004473
nisse51542be2016-02-12 02:27:06 -08004474 // Verify that setting the option to false resets the
4475 // DiffServCodePoint.
4476 config.enable_dscp = false;
Sebastian Jansson84848f22018-11-16 10:40:36 +01004477 channel.reset(
4478 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
4479 call_.get(), config, VideoOptions(), webrtc::CryptoOptions())));
Anton Sukhanov98a462c2018-10-17 13:15:42 -07004480 channel->SetInterface(network_interface.get(), /*media_transport=*/nullptr);
nisse51542be2016-02-12 02:27:06 -08004481 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004482}
4483
deadbeef13871492015-12-09 12:37:51 -08004484// This test verifies that the RTCP reduced size mode is properly applied to
4485// send video streams.
eladalonf1841382017-06-12 01:16:46 -07004486TEST_F(WebRtcVideoChannelTest, TestSetSendRtcpReducedSize) {
deadbeef13871492015-12-09 12:37:51 -08004487 // Create stream, expecting that default mode is "compound".
4488 FakeVideoSendStream* stream1 = AddSendStream();
4489 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream1->GetConfig().rtp.rtcp_mode);
Florent Castellidacec712018-05-24 16:24:21 +02004490 webrtc::RtpParameters rtp_parameters =
4491 channel_->GetRtpSendParameters(last_ssrc_);
4492 EXPECT_FALSE(rtp_parameters.rtcp.reduced_size);
deadbeef13871492015-12-09 12:37:51 -08004493
4494 // Now enable reduced size mode.
4495 send_parameters_.rtcp.reduced_size = true;
4496 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
4497 stream1 = fake_call_->GetVideoSendStreams()[0];
4498 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream1->GetConfig().rtp.rtcp_mode);
Florent Castellidacec712018-05-24 16:24:21 +02004499 rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
4500 EXPECT_TRUE(rtp_parameters.rtcp.reduced_size);
deadbeef13871492015-12-09 12:37:51 -08004501
4502 // Create a new stream and ensure it picks up the reduced size mode.
4503 FakeVideoSendStream* stream2 = AddSendStream();
4504 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream2->GetConfig().rtp.rtcp_mode);
4505}
4506
4507// This test verifies that the RTCP reduced size mode is properly applied to
4508// receive video streams.
eladalonf1841382017-06-12 01:16:46 -07004509TEST_F(WebRtcVideoChannelTest, TestSetRecvRtcpReducedSize) {
deadbeef13871492015-12-09 12:37:51 -08004510 // Create stream, expecting that default mode is "compound".
4511 FakeVideoReceiveStream* stream1 = AddRecvStream();
4512 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream1->GetConfig().rtp.rtcp_mode);
4513
4514 // Now enable reduced size mode.
Taylor Brandstetter5f0b83b2016-03-18 15:02:07 -07004515 // TODO(deadbeef): Once "recv_parameters" becomes "receiver_parameters",
4516 // the reduced_size flag should come from that.
4517 send_parameters_.rtcp.reduced_size = true;
4518 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
deadbeef13871492015-12-09 12:37:51 -08004519 stream1 = fake_call_->GetVideoReceiveStreams()[0];
4520 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream1->GetConfig().rtp.rtcp_mode);
4521
4522 // Create a new stream and ensure it picks up the reduced size mode.
4523 FakeVideoReceiveStream* stream2 = AddRecvStream();
4524 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream2->GetConfig().rtp.rtcp_mode);
4525}
4526
eladalonf1841382017-06-12 01:16:46 -07004527TEST_F(WebRtcVideoChannelTest, OnReadyToSendSignalsNetworkState) {
skvlad7a43d252016-03-22 15:32:27 -07004528 EXPECT_EQ(webrtc::kNetworkUp,
4529 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4530 EXPECT_EQ(webrtc::kNetworkUp,
4531 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.org26c0c412014-09-03 16:17:12 +00004532
4533 channel_->OnReadyToSend(false);
skvlad7a43d252016-03-22 15:32:27 -07004534 EXPECT_EQ(webrtc::kNetworkDown,
4535 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4536 EXPECT_EQ(webrtc::kNetworkUp,
4537 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.org26c0c412014-09-03 16:17:12 +00004538
4539 channel_->OnReadyToSend(true);
skvlad7a43d252016-03-22 15:32:27 -07004540 EXPECT_EQ(webrtc::kNetworkUp,
4541 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4542 EXPECT_EQ(webrtc::kNetworkUp,
4543 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004544}
4545
eladalonf1841382017-06-12 01:16:46 -07004546TEST_F(WebRtcVideoChannelTest, GetStatsReportsSentCodecName) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004547 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004548 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004549 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström74d9ed72015-03-26 16:28:31 +01004550
4551 AddSendStream();
4552
4553 cricket::VideoMediaInfo info;
4554 ASSERT_TRUE(channel_->GetStats(&info));
magjed509e4fe2016-11-18 01:34:11 -08004555 EXPECT_EQ("VP8", info.senders[0].codec_name);
Peter Boström74d9ed72015-03-26 16:28:31 +01004556}
4557
eladalonf1841382017-06-12 01:16:46 -07004558TEST_F(WebRtcVideoChannelTest, GetStatsReportsEncoderImplementationName) {
Peter Boströmb7d9a972015-12-18 16:01:11 +01004559 FakeVideoSendStream* stream = AddSendStream();
4560 webrtc::VideoSendStream::Stats stats;
4561 stats.encoder_implementation_name = "encoder_implementation_name";
4562 stream->SetStats(stats);
4563
4564 cricket::VideoMediaInfo info;
4565 ASSERT_TRUE(channel_->GetStats(&info));
4566 EXPECT_EQ(stats.encoder_implementation_name,
4567 info.senders[0].encoder_implementation_name);
4568}
4569
eladalonf1841382017-06-12 01:16:46 -07004570TEST_F(WebRtcVideoChannelTest, GetStatsReportsCpuOveruseMetrics) {
pbos@webrtc.org3e6e2712015-02-26 12:19:31 +00004571 FakeVideoSendStream* stream = AddSendStream();
4572 webrtc::VideoSendStream::Stats stats;
4573 stats.avg_encode_time_ms = 13;
4574 stats.encode_usage_percent = 42;
4575 stream->SetStats(stats);
4576
4577 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004578 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org3e6e2712015-02-26 12:19:31 +00004579 EXPECT_EQ(stats.avg_encode_time_ms, info.senders[0].avg_encode_ms);
4580 EXPECT_EQ(stats.encode_usage_percent, info.senders[0].encode_usage_percent);
4581}
4582
eladalonf1841382017-06-12 01:16:46 -07004583TEST_F(WebRtcVideoChannelTest, GetStatsReportsFramesEncoded) {
sakal43536c32016-10-24 01:46:43 -07004584 FakeVideoSendStream* stream = AddSendStream();
4585 webrtc::VideoSendStream::Stats stats;
4586 stats.frames_encoded = 13;
4587 stream->SetStats(stats);
4588
4589 cricket::VideoMediaInfo info;
4590 ASSERT_TRUE(channel_->GetStats(&info));
4591 EXPECT_EQ(stats.frames_encoded, info.senders[0].frames_encoded);
4592}
4593
eladalonf1841382017-06-12 01:16:46 -07004594TEST_F(WebRtcVideoChannelTest, GetStatsReportsQpSum) {
sakal87da4042016-10-31 06:53:47 -07004595 FakeVideoSendStream* stream = AddSendStream();
4596 webrtc::VideoSendStream::Stats stats;
Oskar Sundbom78807582017-11-16 11:09:55 +01004597 stats.qp_sum = 13;
sakal87da4042016-10-31 06:53:47 -07004598 stream->SetStats(stats);
4599
4600 cricket::VideoMediaInfo info;
4601 ASSERT_TRUE(channel_->GetStats(&info));
4602 EXPECT_EQ(stats.qp_sum, info.senders[0].qp_sum);
4603}
4604
eladalonf1841382017-06-12 01:16:46 -07004605TEST_F(WebRtcVideoChannelTest, GetStatsReportsUpperResolution) {
pbos@webrtc.org273a4142014-12-01 15:23:21 +00004606 FakeVideoSendStream* stream = AddSendStream();
4607 webrtc::VideoSendStream::Stats stats;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004608 stats.substreams[17].width = 123;
4609 stats.substreams[17].height = 40;
4610 stats.substreams[42].width = 80;
4611 stats.substreams[42].height = 31;
4612 stats.substreams[11].width = 20;
4613 stats.substreams[11].height = 90;
pbos@webrtc.org273a4142014-12-01 15:23:21 +00004614 stream->SetStats(stats);
4615
4616 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004617 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org273a4142014-12-01 15:23:21 +00004618 ASSERT_EQ(1u, info.senders.size());
4619 EXPECT_EQ(123, info.senders[0].send_frame_width);
4620 EXPECT_EQ(90, info.senders[0].send_frame_height);
4621}
4622
eladalonf1841382017-06-12 01:16:46 -07004623TEST_F(WebRtcVideoChannelTest, GetStatsReportsCpuAdaptationStats) {
perkj803d97f2016-11-01 11:45:46 -07004624 FakeVideoSendStream* stream = AddSendStream();
4625 webrtc::VideoSendStream::Stats stats;
4626 stats.number_of_cpu_adapt_changes = 2;
4627 stats.cpu_limited_resolution = true;
4628 stream->SetStats(stats);
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004629
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004630 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004631 EXPECT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004632 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07004633 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_CPU, info.senders[0].adapt_reason);
perkj803d97f2016-11-01 11:45:46 -07004634 EXPECT_EQ(stats.number_of_cpu_adapt_changes, info.senders[0].adapt_changes);
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004635}
4636
eladalonf1841382017-06-12 01:16:46 -07004637TEST_F(WebRtcVideoChannelTest, GetStatsReportsAdaptationAndBandwidthStats) {
perkj803d97f2016-11-01 11:45:46 -07004638 FakeVideoSendStream* stream = AddSendStream();
asapersson17821db2015-12-14 02:08:12 -08004639 webrtc::VideoSendStream::Stats stats;
perkj803d97f2016-11-01 11:45:46 -07004640 stats.number_of_cpu_adapt_changes = 2;
4641 stats.cpu_limited_resolution = true;
asapersson17821db2015-12-14 02:08:12 -08004642 stats.bw_limited_resolution = true;
perkj803d97f2016-11-01 11:45:46 -07004643 stream->SetStats(stats);
4644
4645 cricket::VideoMediaInfo info;
asapersson17821db2015-12-14 02:08:12 -08004646 EXPECT_TRUE(channel_->GetStats(&info));
4647 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07004648 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_CPU |
4649 WebRtcVideoChannel::ADAPTREASON_BANDWIDTH,
asapersson17821db2015-12-14 02:08:12 -08004650 info.senders[0].adapt_reason);
perkj803d97f2016-11-01 11:45:46 -07004651 EXPECT_EQ(stats.number_of_cpu_adapt_changes, info.senders[0].adapt_changes);
asapersson17821db2015-12-14 02:08:12 -08004652}
4653
eladalonf1841382017-06-12 01:16:46 -07004654TEST_F(WebRtcVideoChannelTest,
asapersson17821db2015-12-14 02:08:12 -08004655 GetStatsTranslatesBandwidthLimitedResolutionCorrectly) {
4656 FakeVideoSendStream* stream = AddSendStream();
4657 webrtc::VideoSendStream::Stats stats;
4658 stats.bw_limited_resolution = true;
4659 stream->SetStats(stats);
4660
4661 cricket::VideoMediaInfo info;
4662 EXPECT_TRUE(channel_->GetStats(&info));
4663 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07004664 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_BANDWIDTH,
asapersson17821db2015-12-14 02:08:12 -08004665 info.senders[0].adapt_reason);
4666}
4667
Yves Gerey665174f2018-06-19 15:03:05 +02004668TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesSendRtcpPacketTypesCorrectly) {
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004669 FakeVideoSendStream* stream = AddSendStream();
4670 webrtc::VideoSendStream::Stats stats;
4671 stats.substreams[17].rtcp_packet_type_counts.fir_packets = 2;
4672 stats.substreams[17].rtcp_packet_type_counts.nack_packets = 3;
4673 stats.substreams[17].rtcp_packet_type_counts.pli_packets = 4;
4674
4675 stats.substreams[42].rtcp_packet_type_counts.fir_packets = 5;
4676 stats.substreams[42].rtcp_packet_type_counts.nack_packets = 7;
4677 stats.substreams[42].rtcp_packet_type_counts.pli_packets = 9;
4678
4679 stream->SetStats(stats);
4680
4681 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004682 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004683 EXPECT_EQ(7, info.senders[0].firs_rcvd);
4684 EXPECT_EQ(10, info.senders[0].nacks_rcvd);
4685 EXPECT_EQ(13, info.senders[0].plis_rcvd);
4686}
4687
eladalonf1841382017-06-12 01:16:46 -07004688TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004689 GetStatsTranslatesReceiveRtcpPacketTypesCorrectly) {
4690 FakeVideoReceiveStream* stream = AddRecvStream();
4691 webrtc::VideoReceiveStream::Stats stats;
4692 stats.rtcp_packet_type_counts.fir_packets = 2;
4693 stats.rtcp_packet_type_counts.nack_packets = 3;
4694 stats.rtcp_packet_type_counts.pli_packets = 4;
4695 stream->SetStats(stats);
4696
4697 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004698 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004699 EXPECT_EQ(stats.rtcp_packet_type_counts.fir_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004700 rtc::checked_cast<unsigned int>(info.receivers[0].firs_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004701 EXPECT_EQ(stats.rtcp_packet_type_counts.nack_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004702 rtc::checked_cast<unsigned int>(info.receivers[0].nacks_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004703 EXPECT_EQ(stats.rtcp_packet_type_counts.pli_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004704 rtc::checked_cast<unsigned int>(info.receivers[0].plis_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004705}
4706
eladalonf1841382017-06-12 01:16:46 -07004707TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesDecodeStatsCorrectly) {
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004708 FakeVideoReceiveStream* stream = AddRecvStream();
4709 webrtc::VideoReceiveStream::Stats stats;
Peter Boströmb7d9a972015-12-18 16:01:11 +01004710 stats.decoder_implementation_name = "decoder_implementation_name";
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004711 stats.decode_ms = 2;
4712 stats.max_decode_ms = 3;
4713 stats.current_delay_ms = 4;
4714 stats.target_delay_ms = 5;
4715 stats.jitter_buffer_ms = 6;
4716 stats.min_playout_delay_ms = 7;
4717 stats.render_delay_ms = 8;
asapersson26dd92b2016-08-30 00:45:45 -07004718 stats.width = 9;
4719 stats.height = 10;
hbos42f6d2f2017-01-20 03:56:50 -08004720 stats.frame_counts.key_frames = 11;
4721 stats.frame_counts.delta_frames = 12;
hbos50cfe1f2017-01-23 07:21:55 -08004722 stats.frames_rendered = 13;
4723 stats.frames_decoded = 14;
Oskar Sundbom78807582017-11-16 11:09:55 +01004724 stats.qp_sum = 15;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004725 stream->SetStats(stats);
4726
4727 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004728 ASSERT_TRUE(channel_->GetStats(&info));
Peter Boströmb7d9a972015-12-18 16:01:11 +01004729 EXPECT_EQ(stats.decoder_implementation_name,
4730 info.receivers[0].decoder_implementation_name);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004731 EXPECT_EQ(stats.decode_ms, info.receivers[0].decode_ms);
4732 EXPECT_EQ(stats.max_decode_ms, info.receivers[0].max_decode_ms);
4733 EXPECT_EQ(stats.current_delay_ms, info.receivers[0].current_delay_ms);
4734 EXPECT_EQ(stats.target_delay_ms, info.receivers[0].target_delay_ms);
4735 EXPECT_EQ(stats.jitter_buffer_ms, info.receivers[0].jitter_buffer_ms);
4736 EXPECT_EQ(stats.min_playout_delay_ms, info.receivers[0].min_playout_delay_ms);
4737 EXPECT_EQ(stats.render_delay_ms, info.receivers[0].render_delay_ms);
asapersson26dd92b2016-08-30 00:45:45 -07004738 EXPECT_EQ(stats.width, info.receivers[0].frame_width);
4739 EXPECT_EQ(stats.height, info.receivers[0].frame_height);
Mirko Bonadeif859e552018-05-30 15:31:29 +02004740 EXPECT_EQ(rtc::checked_cast<unsigned int>(stats.frame_counts.key_frames +
4741 stats.frame_counts.delta_frames),
hbos42f6d2f2017-01-20 03:56:50 -08004742 info.receivers[0].frames_received);
hbos50cfe1f2017-01-23 07:21:55 -08004743 EXPECT_EQ(stats.frames_rendered, info.receivers[0].frames_rendered);
sakale5ba44e2016-10-26 07:09:24 -07004744 EXPECT_EQ(stats.frames_decoded, info.receivers[0].frames_decoded);
sakalcc452e12017-02-09 04:53:45 -08004745 EXPECT_EQ(stats.qp_sum, info.receivers[0].qp_sum);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004746}
4747
eladalonf1841382017-06-12 01:16:46 -07004748TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesReceivePacketStatsCorrectly) {
Peter Boström393347f2015-04-22 14:52:45 +02004749 FakeVideoReceiveStream* stream = AddRecvStream();
4750 webrtc::VideoReceiveStream::Stats stats;
4751 stats.rtp_stats.transmitted.payload_bytes = 2;
4752 stats.rtp_stats.transmitted.header_bytes = 3;
4753 stats.rtp_stats.transmitted.padding_bytes = 4;
4754 stats.rtp_stats.transmitted.packets = 5;
srte186d9c32017-08-04 05:03:53 -07004755 stats.rtcp_stats.packets_lost = 6;
Peter Boström393347f2015-04-22 14:52:45 +02004756 stats.rtcp_stats.fraction_lost = 7;
4757 stream->SetStats(stats);
4758
4759 cricket::VideoMediaInfo info;
4760 ASSERT_TRUE(channel_->GetStats(&info));
4761 EXPECT_EQ(stats.rtp_stats.transmitted.payload_bytes +
4762 stats.rtp_stats.transmitted.header_bytes +
4763 stats.rtp_stats.transmitted.padding_bytes,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004764 rtc::checked_cast<size_t>(info.receivers[0].bytes_rcvd));
Peter Boström393347f2015-04-22 14:52:45 +02004765 EXPECT_EQ(stats.rtp_stats.transmitted.packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004766 rtc::checked_cast<unsigned int>(info.receivers[0].packets_rcvd));
srte186d9c32017-08-04 05:03:53 -07004767 EXPECT_EQ(stats.rtcp_stats.packets_lost, info.receivers[0].packets_lost);
Mirko Bonadeif859e552018-05-30 15:31:29 +02004768 EXPECT_EQ(rtc::checked_cast<float>(stats.rtcp_stats.fraction_lost) / (1 << 8),
Peter Boström393347f2015-04-22 14:52:45 +02004769 info.receivers[0].fraction_lost);
4770}
4771
eladalonf1841382017-06-12 01:16:46 -07004772TEST_F(WebRtcVideoChannelTest, TranslatesCallStatsCorrectly) {
pbos@webrtc.org2b19f062014-12-11 13:26:09 +00004773 AddSendStream();
4774 AddSendStream();
4775 webrtc::Call::Stats stats;
4776 stats.rtt_ms = 123;
4777 fake_call_->SetStats(stats);
4778
4779 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004780 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org2b19f062014-12-11 13:26:09 +00004781 ASSERT_EQ(2u, info.senders.size());
4782 EXPECT_EQ(stats.rtt_ms, info.senders[0].rtt_ms);
4783 EXPECT_EQ(stats.rtt_ms, info.senders[1].rtt_ms);
4784}
4785
eladalonf1841382017-06-12 01:16:46 -07004786TEST_F(WebRtcVideoChannelTest, TranslatesSenderBitrateStatsCorrectly) {
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004787 FakeVideoSendStream* stream = AddSendStream();
4788 webrtc::VideoSendStream::Stats stats;
pbos@webrtc.org891d4832015-02-26 13:15:22 +00004789 stats.target_media_bitrate_bps = 156;
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004790 stats.media_bitrate_bps = 123;
4791 stats.substreams[17].total_bitrate_bps = 1;
4792 stats.substreams[17].retransmit_bitrate_bps = 2;
4793 stats.substreams[42].total_bitrate_bps = 3;
4794 stats.substreams[42].retransmit_bitrate_bps = 4;
4795 stream->SetStats(stats);
4796
4797 FakeVideoSendStream* stream2 = AddSendStream();
4798 webrtc::VideoSendStream::Stats stats2;
pbos@webrtc.org891d4832015-02-26 13:15:22 +00004799 stats2.target_media_bitrate_bps = 200;
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004800 stats2.media_bitrate_bps = 321;
4801 stats2.substreams[13].total_bitrate_bps = 5;
4802 stats2.substreams[13].retransmit_bitrate_bps = 6;
4803 stats2.substreams[21].total_bitrate_bps = 7;
4804 stats2.substreams[21].retransmit_bitrate_bps = 8;
4805 stream2->SetStats(stats2);
4806
4807 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004808 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004809 ASSERT_EQ(2u, info.senders.size());
stefanf79ade12017-06-02 06:44:03 -07004810 BandwidthEstimationInfo bwe_info;
4811 channel_->FillBitrateInfo(&bwe_info);
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004812 // Assuming stream and stream2 corresponds to senders[0] and [1] respectively
4813 // is OK as std::maps are sorted and AddSendStream() gives increasing SSRCs.
4814 EXPECT_EQ(stats.media_bitrate_bps, info.senders[0].nominal_bitrate);
4815 EXPECT_EQ(stats2.media_bitrate_bps, info.senders[1].nominal_bitrate);
pbos@webrtc.org891d4832015-02-26 13:15:22 +00004816 EXPECT_EQ(stats.target_media_bitrate_bps + stats2.target_media_bitrate_bps,
stefanf79ade12017-06-02 06:44:03 -07004817 bwe_info.target_enc_bitrate);
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004818 EXPECT_EQ(stats.media_bitrate_bps + stats2.media_bitrate_bps,
stefanf79ade12017-06-02 06:44:03 -07004819 bwe_info.actual_enc_bitrate);
4820 EXPECT_EQ(1 + 3 + 5 + 7, bwe_info.transmit_bitrate)
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004821 << "Bandwidth stats should take all streams into account.";
stefanf79ade12017-06-02 06:44:03 -07004822 EXPECT_EQ(2 + 4 + 6 + 8, bwe_info.retransmit_bitrate)
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004823 << "Bandwidth stats should take all streams into account.";
4824}
4825
eladalonf1841382017-06-12 01:16:46 -07004826TEST_F(WebRtcVideoChannelTest, DefaultReceiveStreamReconfiguresToUseRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004827 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004828
Peter Boström0c4e06b2015-10-07 12:23:21 +02004829 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
4830 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004831
4832 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
4833 const size_t kDataLength = 12;
4834 uint8_t data[kDataLength];
4835 memset(data, 0, sizeof(data));
4836 rtc::SetBE32(&data[8], ssrcs[0]);
jbaucheec21bd2016-03-20 06:15:43 -07004837 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Niels Möllere6933812018-11-05 13:01:41 +01004838 channel_->OnPacketReceived(&packet, /* packet_time_us */ -1);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004839
4840 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
4841 << "No default receive stream created.";
4842 FakeVideoReceiveStream* recv_stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr14742122017-01-27 04:53:07 -08004843 EXPECT_EQ(0u, recv_stream->GetConfig().rtp.rtx_ssrc)
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004844 << "Default receive stream should not have configured RTX";
4845
4846 EXPECT_TRUE(channel_->AddRecvStream(
4847 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs)));
4848 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
brandtr14742122017-01-27 04:53:07 -08004849 << "AddRecvStream should have reconfigured, not added a new receiver.";
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004850 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
nisse26e3abb2017-08-25 04:44:25 -07004851 EXPECT_FALSE(
4852 recv_stream->GetConfig().rtp.rtx_associated_payload_types.empty());
nisseca5706d2017-09-11 02:32:16 -07004853 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
Peter Boströmd8b01092016-05-12 16:44:36 +02004854 << "RTX should be mapped for all decoders/payload types.";
nisseca5706d2017-09-11 02:32:16 -07004855 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02004856 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07004857 << "RTX should be mapped also for the RED payload type";
brandtr14742122017-01-27 04:53:07 -08004858 EXPECT_EQ(rtx_ssrcs[0], recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004859}
4860
eladalonf1841382017-06-12 01:16:46 -07004861TEST_F(WebRtcVideoChannelTest, RejectsAddingStreamsWithMissingSsrcsForRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004862 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd4362cd2015-03-25 14:17:23 +01004863
Peter Boström0c4e06b2015-10-07 12:23:21 +02004864 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
4865 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
Peter Boströmd4362cd2015-03-25 14:17:23 +01004866
4867 StreamParams sp =
4868 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs);
4869 sp.ssrcs = ssrcs; // Without RTXs, this is the important part.
4870
4871 EXPECT_FALSE(channel_->AddSendStream(sp));
4872 EXPECT_FALSE(channel_->AddRecvStream(sp));
4873}
4874
eladalonf1841382017-06-12 01:16:46 -07004875TEST_F(WebRtcVideoChannelTest, RejectsAddingStreamsWithOverlappingRtxSsrcs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004876 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd6f4c252015-03-26 16:23:04 +01004877
Peter Boström0c4e06b2015-10-07 12:23:21 +02004878 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
4879 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
Peter Boströmd6f4c252015-03-26 16:23:04 +01004880
4881 StreamParams sp =
4882 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs);
4883
4884 EXPECT_TRUE(channel_->AddSendStream(sp));
4885 EXPECT_TRUE(channel_->AddRecvStream(sp));
4886
4887 // The RTX SSRC is already used in previous streams, using it should fail.
4888 sp = cricket::StreamParams::CreateLegacy(rtx_ssrcs[0]);
4889 EXPECT_FALSE(channel_->AddSendStream(sp));
4890 EXPECT_FALSE(channel_->AddRecvStream(sp));
4891
4892 // After removing the original stream this should be fine to add (makes sure
4893 // that RTX ssrcs are not forever taken).
4894 EXPECT_TRUE(channel_->RemoveSendStream(ssrcs[0]));
4895 EXPECT_TRUE(channel_->RemoveRecvStream(ssrcs[0]));
4896 EXPECT_TRUE(channel_->AddSendStream(sp));
4897 EXPECT_TRUE(channel_->AddRecvStream(sp));
4898}
4899
eladalonf1841382017-06-12 01:16:46 -07004900TEST_F(WebRtcVideoChannelTest,
Peter Boströmd6f4c252015-03-26 16:23:04 +01004901 RejectsAddingStreamsWithOverlappingSimulcastSsrcs) {
Peter Boström0c4e06b2015-10-07 12:23:21 +02004902 static const uint32_t kFirstStreamSsrcs[] = {1, 2, 3};
4903 static const uint32_t kOverlappingStreamSsrcs[] = {4, 3, 5};
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004904 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd6f4c252015-03-26 16:23:04 +01004905
Peter Boströmd6f4c252015-03-26 16:23:04 +01004906 StreamParams sp =
4907 cricket::CreateSimStreamParams("cname", MAKE_VECTOR(kFirstStreamSsrcs));
4908
4909 EXPECT_TRUE(channel_->AddSendStream(sp));
4910 EXPECT_TRUE(channel_->AddRecvStream(sp));
4911
4912 // One of the SSRCs is already used in previous streams, using it should fail.
4913 sp = cricket::CreateSimStreamParams("cname",
4914 MAKE_VECTOR(kOverlappingStreamSsrcs));
4915 EXPECT_FALSE(channel_->AddSendStream(sp));
4916 EXPECT_FALSE(channel_->AddRecvStream(sp));
4917
4918 // After removing the original stream this should be fine to add (makes sure
4919 // that RTX ssrcs are not forever taken).
Peter Boström3548dd22015-05-22 18:48:36 +02004920 EXPECT_TRUE(channel_->RemoveSendStream(kFirstStreamSsrcs[0]));
4921 EXPECT_TRUE(channel_->RemoveRecvStream(kFirstStreamSsrcs[0]));
Peter Boströmd6f4c252015-03-26 16:23:04 +01004922 EXPECT_TRUE(channel_->AddSendStream(sp));
4923 EXPECT_TRUE(channel_->AddRecvStream(sp));
4924}
4925
eladalonf1841382017-06-12 01:16:46 -07004926TEST_F(WebRtcVideoChannelTest, ReportsSsrcGroupsInStats) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004927 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boström259bd202015-05-28 13:39:50 +02004928
4929 static const uint32_t kSenderSsrcs[] = {4, 7, 10};
4930 static const uint32_t kSenderRtxSsrcs[] = {5, 8, 11};
4931
4932 StreamParams sender_sp = cricket::CreateSimWithRtxStreamParams(
4933 "cname", MAKE_VECTOR(kSenderSsrcs), MAKE_VECTOR(kSenderRtxSsrcs));
4934
4935 EXPECT_TRUE(channel_->AddSendStream(sender_sp));
4936
4937 static const uint32_t kReceiverSsrcs[] = {3};
4938 static const uint32_t kReceiverRtxSsrcs[] = {2};
4939
4940 StreamParams receiver_sp = cricket::CreateSimWithRtxStreamParams(
4941 "cname", MAKE_VECTOR(kReceiverSsrcs), MAKE_VECTOR(kReceiverRtxSsrcs));
4942 EXPECT_TRUE(channel_->AddRecvStream(receiver_sp));
4943
4944 cricket::VideoMediaInfo info;
4945 ASSERT_TRUE(channel_->GetStats(&info));
4946
4947 ASSERT_EQ(1u, info.senders.size());
4948 ASSERT_EQ(1u, info.receivers.size());
4949
4950 EXPECT_NE(sender_sp.ssrc_groups, receiver_sp.ssrc_groups);
4951 EXPECT_EQ(sender_sp.ssrc_groups, info.senders[0].ssrc_groups);
4952 EXPECT_EQ(receiver_sp.ssrc_groups, info.receivers[0].ssrc_groups);
4953}
4954
eladalonf1841382017-06-12 01:16:46 -07004955TEST_F(WebRtcVideoChannelTest, MapsReceivedPayloadTypeToCodecName) {
pbosf42376c2015-08-28 07:35:32 -07004956 FakeVideoReceiveStream* stream = AddRecvStream();
4957 webrtc::VideoReceiveStream::Stats stats;
4958 cricket::VideoMediaInfo info;
4959
4960 // Report no codec name before receiving.
4961 stream->SetStats(stats);
4962 ASSERT_TRUE(channel_->GetStats(&info));
4963 EXPECT_STREQ("", info.receivers[0].codec_name.c_str());
4964
4965 // Report VP8 if we're receiving it.
magjed509e4fe2016-11-18 01:34:11 -08004966 stats.current_payload_type = GetEngineCodec("VP8").id;
pbosf42376c2015-08-28 07:35:32 -07004967 stream->SetStats(stats);
4968 ASSERT_TRUE(channel_->GetStats(&info));
4969 EXPECT_STREQ(kVp8CodecName, info.receivers[0].codec_name.c_str());
4970
4971 // Report no codec name for unknown playload types.
4972 stats.current_payload_type = 3;
4973 stream->SetStats(stats);
4974 ASSERT_TRUE(channel_->GetStats(&info));
4975 EXPECT_STREQ("", info.receivers[0].codec_name.c_str());
4976}
4977
Seth Hampson5897a6e2018-04-03 11:16:33 -07004978// Tests that when we add a stream without SSRCs, but contains a stream_id
4979// that it is stored and its stream id is later used when the first packet
4980// arrives to properly create a receive stream with a sync label.
4981TEST_F(WebRtcVideoChannelTest, RecvUnsignaledSsrcWithSignaledStreamId) {
4982 const char kSyncLabel[] = "sync_label";
4983 cricket::StreamParams unsignaled_stream;
4984 unsignaled_stream.set_stream_ids({kSyncLabel});
4985 ASSERT_TRUE(channel_->AddRecvStream(unsignaled_stream));
4986 // The stream shouldn't have been created at this point because it doesn't
4987 // have any SSRCs.
Mirko Bonadeif859e552018-05-30 15:31:29 +02004988 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
Seth Hampson5897a6e2018-04-03 11:16:33 -07004989
4990 // Create and deliver packet.
4991 const size_t kDataLength = 12;
4992 uint8_t data[kDataLength];
4993 memset(data, 0, sizeof(data));
4994 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
4995 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Niels Möllere6933812018-11-05 13:01:41 +01004996 channel_->OnPacketReceived(&packet, /* packet_time_us */ -1);
Seth Hampson5897a6e2018-04-03 11:16:33 -07004997
4998 // The stream should now be created with the appropriate sync label.
4999 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5000 EXPECT_EQ(kSyncLabel,
5001 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group);
5002
5003 // Removing the unsignaled stream should clear the cache. This time when
5004 // a default video receive stream is created it won't have a sync_group.
5005 ASSERT_TRUE(channel_->RemoveRecvStream(0));
5006 ASSERT_TRUE(channel_->RemoveRecvStream(kIncomingUnsignalledSsrc));
5007 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5008
Niels Möllere6933812018-11-05 13:01:41 +01005009 channel_->OnPacketReceived(&packet, /* packet_time_us */ -1);
Seth Hampson5897a6e2018-04-03 11:16:33 -07005010 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5011 EXPECT_TRUE(
5012 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group.empty());
5013}
5014
eladalonf1841382017-06-12 01:16:46 -07005015void WebRtcVideoChannelTest::TestReceiveUnsignaledSsrcPacket(
noahricd10a68e2015-07-10 11:27:55 -07005016 uint8_t payload_type,
5017 bool expect_created_receive_stream) {
magjed509e4fe2016-11-18 01:34:11 -08005018 // kRedRtxPayloadType must currently be unused.
5019 EXPECT_FALSE(FindCodecById(engine_.codecs(), kRedRtxPayloadType));
5020
noahricd10a68e2015-07-10 11:27:55 -07005021 // Add a RED RTX codec.
5022 VideoCodec red_rtx_codec =
magjed509e4fe2016-11-18 01:34:11 -08005023 VideoCodec::CreateRtxCodec(kRedRtxPayloadType, GetEngineCodec("red").id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005024 recv_parameters_.codecs.push_back(red_rtx_codec);
5025 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
noahricd10a68e2015-07-10 11:27:55 -07005026
5027 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5028 const size_t kDataLength = 12;
5029 uint8_t data[kDataLength];
5030 memset(data, 0, sizeof(data));
5031
5032 rtc::Set8(data, 1, payload_type);
5033 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
jbaucheec21bd2016-03-20 06:15:43 -07005034 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Niels Möllere6933812018-11-05 13:01:41 +01005035 channel_->OnPacketReceived(&packet, /* packet_time_us */ -1);
noahricd10a68e2015-07-10 11:27:55 -07005036
5037 if (expect_created_receive_stream) {
5038 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
5039 << "Should have created a receive stream for payload type: "
5040 << payload_type;
5041 } else {
5042 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size())
5043 << "Shouldn't have created a receive stream for payload type: "
5044 << payload_type;
5045 }
5046}
5047
Åsa Persson2c7149b2018-10-15 09:36:10 +02005048class WebRtcVideoChannelDiscardUnknownSsrcTest : public WebRtcVideoChannelTest {
5049 public:
5050 WebRtcVideoChannelDiscardUnknownSsrcTest()
5051 : WebRtcVideoChannelTest(
5052 "WebRTC-Video-DiscardPacketsWithUnknownSsrc/Enabled/") {}
5053};
5054
5055TEST_F(WebRtcVideoChannelDiscardUnknownSsrcTest, NoUnsignalledStreamCreated) {
5056 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP8").id,
5057 false /* expect_created_receive_stream */);
5058}
5059
eladalonf1841382017-06-12 01:16:46 -07005060TEST_F(WebRtcVideoChannelTest, Vp8PacketCreatesUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005061 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP8").id,
5062 true /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005063}
5064
eladalonf1841382017-06-12 01:16:46 -07005065TEST_F(WebRtcVideoChannelTest, Vp9PacketCreatesUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005066 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP9").id,
5067 true /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005068}
5069
eladalonf1841382017-06-12 01:16:46 -07005070TEST_F(WebRtcVideoChannelTest, RtxPacketDoesntCreateUnsignalledStream) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02005071 AssignDefaultAptRtxTypes();
magjed509e4fe2016-11-18 01:34:11 -08005072 const cricket::VideoCodec vp8 = GetEngineCodec("VP8");
5073 const int rtx_vp8_payload_type = default_apt_rtx_types_[vp8.id];
5074 TestReceiveUnsignaledSsrcPacket(rtx_vp8_payload_type,
5075 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005076}
5077
eladalonf1841382017-06-12 01:16:46 -07005078TEST_F(WebRtcVideoChannelTest, UlpfecPacketDoesntCreateUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005079 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("ulpfec").id,
5080 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005081}
5082
eladalonf1841382017-06-12 01:16:46 -07005083TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr468da7c2016-11-22 02:16:47 -08005084 FlexfecPacketDoesntCreateUnsignalledStream) {
5085 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("flexfec-03").id,
5086 false /* expect_created_receive_stream */);
5087}
5088
eladalonf1841382017-06-12 01:16:46 -07005089TEST_F(WebRtcVideoChannelTest, RedRtxPacketDoesntCreateUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005090 TestReceiveUnsignaledSsrcPacket(kRedRtxPayloadType,
5091 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005092}
5093
mzanaty8a855d62017-02-17 15:46:43 -08005094// Test that receiving any unsignalled SSRC works even if it changes.
5095// The first unsignalled SSRC received will create a default receive stream.
5096// Any different unsignalled SSRC received will replace the default.
eladalonf1841382017-06-12 01:16:46 -07005097TEST_F(WebRtcVideoChannelTest, ReceiveDifferentUnsignaledSsrc) {
mzanaty8a855d62017-02-17 15:46:43 -08005098 // Allow receiving VP8, VP9, H264 (if enabled).
5099 cricket::VideoRecvParameters parameters;
5100 parameters.codecs.push_back(GetEngineCodec("VP8"));
5101 parameters.codecs.push_back(GetEngineCodec("VP9"));
5102
5103#if defined(WEBRTC_USE_H264)
5104 cricket::VideoCodec H264codec(126, "H264");
5105 parameters.codecs.push_back(H264codec);
5106#endif
5107
5108 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
5109 // No receive streams yet.
5110 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5111 cricket::FakeVideoRenderer renderer;
5112 EXPECT_TRUE(channel_->SetSink(kDefaultRecvSsrc, &renderer));
5113
5114 // Receive VP8 packet on first SSRC.
5115 uint8_t data[kMinRtpPacketLen];
5116 cricket::RtpHeader rtpHeader;
5117 rtpHeader.payload_type = GetEngineCodec("VP8").id;
5118 rtpHeader.seq_num = rtpHeader.timestamp = 0;
Yves Gerey665174f2018-06-19 15:03:05 +02005119 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 1;
mzanaty8a855d62017-02-17 15:46:43 -08005120 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5121 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
Niels Möllere6933812018-11-05 13:01:41 +01005122 channel_->OnPacketReceived(&packet, /* packet_time_us */ -1);
mzanaty8a855d62017-02-17 15:46:43 -08005123 // VP8 packet should create default receive stream.
5124 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
Yves Gerey665174f2018-06-19 15:03:05 +02005125 FakeVideoReceiveStream* recv_stream = fake_call_->GetVideoReceiveStreams()[0];
mzanaty8a855d62017-02-17 15:46:43 -08005126 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5127 // Verify that the receive stream sinks to a renderer.
Artem Titov1ebfb6a2019-01-03 23:49:37 +01005128 webrtc::VideoFrame video_frame =
5129 webrtc::VideoFrame::Builder()
5130 .set_video_frame_buffer(CreateBlackFrameBuffer(4, 4))
5131 .set_timestamp_rtp(100)
5132 .set_timestamp_us(0)
5133 .set_rotation(webrtc::kVideoRotation_0)
5134 .build();
mzanaty8a855d62017-02-17 15:46:43 -08005135 recv_stream->InjectFrame(video_frame);
5136 EXPECT_EQ(1, renderer.num_rendered_frames());
5137
5138 // Receive VP9 packet on second SSRC.
5139 rtpHeader.payload_type = GetEngineCodec("VP9").id;
Yves Gerey665174f2018-06-19 15:03:05 +02005140 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 2;
mzanaty8a855d62017-02-17 15:46:43 -08005141 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5142 rtc::CopyOnWriteBuffer packet2(data, sizeof(data));
Niels Möllere6933812018-11-05 13:01:41 +01005143 channel_->OnPacketReceived(&packet2, /* packet_time_us */ -1);
mzanaty8a855d62017-02-17 15:46:43 -08005144 // VP9 packet should replace the default receive SSRC.
5145 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5146 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
5147 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5148 // Verify that the receive stream sinks to a renderer.
Artem Titov1ebfb6a2019-01-03 23:49:37 +01005149 webrtc::VideoFrame video_frame2 =
5150 webrtc::VideoFrame::Builder()
5151 .set_video_frame_buffer(CreateBlackFrameBuffer(4, 4))
5152 .set_timestamp_rtp(200)
5153 .set_timestamp_us(0)
5154 .set_rotation(webrtc::kVideoRotation_0)
5155 .build();
mzanaty8a855d62017-02-17 15:46:43 -08005156 recv_stream->InjectFrame(video_frame2);
5157 EXPECT_EQ(2, renderer.num_rendered_frames());
5158
5159#if defined(WEBRTC_USE_H264)
5160 // Receive H264 packet on third SSRC.
5161 rtpHeader.payload_type = 126;
Yves Gerey665174f2018-06-19 15:03:05 +02005162 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 3;
mzanaty8a855d62017-02-17 15:46:43 -08005163 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5164 rtc::CopyOnWriteBuffer packet3(data, sizeof(data));
Niels Möllere6933812018-11-05 13:01:41 +01005165 channel_->OnPacketReceived(&packet3, /* packet_time_us */ -1);
mzanaty8a855d62017-02-17 15:46:43 -08005166 // H264 packet should replace the default receive SSRC.
5167 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5168 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
5169 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5170 // Verify that the receive stream sinks to a renderer.
Artem Titov1ebfb6a2019-01-03 23:49:37 +01005171 webrtc::VideoFrame video_frame3 =
5172 webrtc::VideoFrame::Builder()
5173 .set_video_frame_buffer(CreateBlackFrameBuffer(4, 4))
5174 .set_timestamp_rtp(300)
5175 .set_timestamp_us(0)
5176 .set_rotation(webrtc::kVideoRotation_0)
5177 .build();
mzanaty8a855d62017-02-17 15:46:43 -08005178 recv_stream->InjectFrame(video_frame3);
5179 EXPECT_EQ(3, renderer.num_rendered_frames());
5180#endif
5181}
5182
brandtr0dc57ea2017-05-29 23:33:31 -07005183// This test verifies that when a new default stream is created for a new
5184// unsignaled SSRC, the new stream does not overwrite any old stream that had
5185// been the default receive stream before being properly signaled.
eladalonf1841382017-06-12 01:16:46 -07005186TEST_F(WebRtcVideoChannelTest,
brandtr0dc57ea2017-05-29 23:33:31 -07005187 NewUnsignaledStreamDoesNotDestroyPreviouslyUnsignaledStream) {
5188 cricket::VideoRecvParameters parameters;
5189 parameters.codecs.push_back(GetEngineCodec("VP8"));
5190 ASSERT_TRUE(channel_->SetRecvParameters(parameters));
5191
5192 // No streams signaled and no packets received, so we should not have any
5193 // stream objects created yet.
5194 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5195
5196 // Receive packet on an unsignaled SSRC.
5197 uint8_t data[kMinRtpPacketLen];
5198 cricket::RtpHeader rtp_header;
5199 rtp_header.payload_type = GetEngineCodec("VP8").id;
5200 rtp_header.seq_num = rtp_header.timestamp = 0;
5201 rtp_header.ssrc = kSsrcs3[0];
5202 cricket::SetRtpHeader(data, sizeof(data), rtp_header);
5203 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
Niels Möllere6933812018-11-05 13:01:41 +01005204 channel_->OnPacketReceived(&packet, /* packet_time_us */ -1);
brandtr0dc57ea2017-05-29 23:33:31 -07005205 // Default receive stream should be created.
5206 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5207 FakeVideoReceiveStream* recv_stream0 =
5208 fake_call_->GetVideoReceiveStreams()[0];
5209 EXPECT_EQ(kSsrcs3[0], recv_stream0->GetConfig().rtp.remote_ssrc);
5210
5211 // Signal the SSRC.
5212 EXPECT_TRUE(
5213 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrcs3[0])));
5214 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5215 recv_stream0 = fake_call_->GetVideoReceiveStreams()[0];
5216 EXPECT_EQ(kSsrcs3[0], recv_stream0->GetConfig().rtp.remote_ssrc);
5217
5218 // Receive packet on a different unsignaled SSRC.
5219 rtp_header.ssrc = kSsrcs3[1];
5220 cricket::SetRtpHeader(data, sizeof(data), rtp_header);
5221 packet.SetData(data, sizeof(data));
Niels Möllere6933812018-11-05 13:01:41 +01005222 channel_->OnPacketReceived(&packet, /* packet_time_us */ -1);
brandtr0dc57ea2017-05-29 23:33:31 -07005223 // New default receive stream should be created, but old stream should remain.
5224 ASSERT_EQ(2u, fake_call_->GetVideoReceiveStreams().size());
5225 EXPECT_EQ(recv_stream0, fake_call_->GetVideoReceiveStreams()[0]);
5226 FakeVideoReceiveStream* recv_stream1 =
5227 fake_call_->GetVideoReceiveStreams()[1];
5228 EXPECT_EQ(kSsrcs3[1], recv_stream1->GetConfig().rtp.remote_ssrc);
5229}
5230
Seth Hampson7c682e02018-05-04 16:28:15 -07005231TEST_F(WebRtcVideoChannelTest, CanSetMaxBitrateForExistingStream) {
skvladdc1c62c2016-03-16 19:07:43 -07005232 AddSendStream();
5233
Niels Möller805a27e2019-01-21 12:21:27 +01005234 webrtc::test::FrameForwarder frame_forwarder;
5235 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
skvladdc1c62c2016-03-16 19:07:43 -07005236 EXPECT_TRUE(channel_->SetSend(true));
Niels Möller805a27e2019-01-21 12:21:27 +01005237 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
skvladdc1c62c2016-03-16 19:07:43 -07005238
perkjfa10b552016-10-02 23:45:26 -07005239 int default_encoder_bitrate = GetMaxEncoderBitrate();
brandtr468da7c2016-11-22 02:16:47 -08005240 EXPECT_GT(default_encoder_bitrate, 1000);
skvladdc1c62c2016-03-16 19:07:43 -07005241
5242 // TODO(skvlad): Resolve the inconsistency between the interpretation
5243 // of the global bitrate limit for audio and video:
5244 // - Audio: max_bandwidth_bps = 0 - fail the operation,
5245 // max_bandwidth_bps = -1 - remove the bandwidth limit
5246 // - Video: max_bandwidth_bps = 0 - remove the bandwidth limit,
pbos5c7760a2017-03-10 11:23:12 -08005247 // max_bandwidth_bps = -1 - remove the bandwidth limit
skvladdc1c62c2016-03-16 19:07:43 -07005248
perkjfa10b552016-10-02 23:45:26 -07005249 SetAndExpectMaxBitrate(1000, 0, 1000);
5250 SetAndExpectMaxBitrate(1000, 800, 800);
5251 SetAndExpectMaxBitrate(600, 800, 600);
5252 SetAndExpectMaxBitrate(0, 800, 800);
5253 SetAndExpectMaxBitrate(0, 0, default_encoder_bitrate);
skvladdc1c62c2016-03-16 19:07:43 -07005254
Niels Möllerff40b142018-04-09 08:49:14 +02005255 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
skvladdc1c62c2016-03-16 19:07:43 -07005256}
5257
eladalonf1841382017-06-12 01:16:46 -07005258TEST_F(WebRtcVideoChannelTest, CannotSetMaxBitrateForNonexistentStream) {
skvladdc1c62c2016-03-16 19:07:43 -07005259 webrtc::RtpParameters nonexistent_parameters =
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005260 channel_->GetRtpSendParameters(last_ssrc_);
Mirko Bonadeif859e552018-05-30 15:31:29 +02005261 EXPECT_EQ(0u, nonexistent_parameters.encodings.size());
skvladdc1c62c2016-03-16 19:07:43 -07005262
5263 nonexistent_parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005264 EXPECT_FALSE(
Zach Steinba37b4b2018-01-23 15:02:36 -08005265 channel_->SetRtpSendParameters(last_ssrc_, nonexistent_parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07005266}
5267
eladalonf1841382017-06-12 01:16:46 -07005268TEST_F(WebRtcVideoChannelTest,
Seth Hampson7c682e02018-05-04 16:28:15 -07005269 SetLowMaxBitrateOverwritesVideoStreamMinBitrate) {
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005270 FakeVideoSendStream* stream = AddSendStream();
5271
Seth Hampson7c682e02018-05-04 16:28:15 -07005272 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5273 EXPECT_EQ(1UL, parameters.encodings.size());
5274 EXPECT_FALSE(parameters.encodings[0].max_bitrate_bps.has_value());
5275 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5276
5277 // Note that this is testing the behavior of the FakeVideoSendStream, which
5278 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5279 // we are just testing the behavior of
5280 // EncoderStreamFactory::CreateEncoderStreams.
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005281 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5282 EXPECT_EQ(kMinVideoBitrateBps, stream->GetVideoStreams()[0].min_bitrate_bps);
Seth Hampson7c682e02018-05-04 16:28:15 -07005283
5284 // Set a low max bitrate & check that VideoStream.min_bitrate_bps is limited
5285 // by this amount.
5286 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5287 int low_max_bitrate_bps = kMinVideoBitrateBps - 1000;
5288 parameters.encodings[0].max_bitrate_bps = low_max_bitrate_bps;
5289 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5290
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005291 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5292 EXPECT_EQ(low_max_bitrate_bps, stream->GetVideoStreams()[0].min_bitrate_bps);
5293 EXPECT_EQ(low_max_bitrate_bps, stream->GetVideoStreams()[0].max_bitrate_bps);
5294}
5295
5296TEST_F(WebRtcVideoChannelTest,
5297 SetHighMinBitrateOverwritesVideoStreamMaxBitrate) {
5298 FakeVideoSendStream* stream = AddSendStream();
5299
5300 // Note that this is testing the behavior of the FakeVideoSendStream, which
5301 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5302 // we are just testing the behavior of
5303 // EncoderStreamFactory::CreateEncoderStreams.
5304 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5305 int high_min_bitrate_bps = stream->GetVideoStreams()[0].max_bitrate_bps + 1;
5306
5307 // Set a high min bitrate and check that max_bitrate_bps is adjusted up.
5308 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5309 EXPECT_EQ(1UL, parameters.encodings.size());
5310 parameters.encodings[0].min_bitrate_bps = high_min_bitrate_bps;
5311 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5312
5313 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5314 EXPECT_EQ(high_min_bitrate_bps, stream->GetVideoStreams()[0].min_bitrate_bps);
5315 EXPECT_EQ(high_min_bitrate_bps, stream->GetVideoStreams()[0].max_bitrate_bps);
5316}
5317
5318TEST_F(WebRtcVideoChannelTest,
5319 SetMinBitrateAboveMaxBitrateLimitAdjustsMinBitrateDown) {
5320 send_parameters_.max_bandwidth_bps = 99999;
5321 FakeVideoSendStream* stream = AddSendStream();
5322 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
5323 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
5324 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5325 EXPECT_EQ(kMinVideoBitrateBps, stream->GetVideoStreams()[0].min_bitrate_bps);
5326 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5327 stream->GetVideoStreams()[0].max_bitrate_bps);
5328
5329 // Set min bitrate above global max bitrate and check that min_bitrate_bps is
5330 // adjusted down.
5331 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5332 EXPECT_EQ(1UL, parameters.encodings.size());
5333 parameters.encodings[0].min_bitrate_bps = 99999 + 1;
5334 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5335 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5336 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5337 stream->GetVideoStreams()[0].min_bitrate_bps);
5338 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5339 stream->GetVideoStreams()[0].max_bitrate_bps);
Seth Hampson7c682e02018-05-04 16:28:15 -07005340}
5341
Åsa Persson8c1bf952018-09-13 10:42:19 +02005342TEST_F(WebRtcVideoChannelTest, SetMaxFramerateOneStream) {
5343 FakeVideoSendStream* stream = AddSendStream();
5344
5345 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5346 EXPECT_EQ(1UL, parameters.encodings.size());
5347 EXPECT_FALSE(parameters.encodings[0].max_framerate.has_value());
5348 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5349
5350 // Note that this is testing the behavior of the FakeVideoSendStream, which
5351 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5352 // we are just testing the behavior of
5353 // EncoderStreamFactory::CreateEncoderStreams.
5354 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5355 EXPECT_EQ(kDefaultVideoMaxFramerate,
5356 stream->GetVideoStreams()[0].max_framerate);
5357
5358 // Set max framerate and check that VideoStream.max_framerate is set.
5359 const int kNewMaxFramerate = kDefaultVideoMaxFramerate - 1;
5360 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5361 parameters.encodings[0].max_framerate = kNewMaxFramerate;
5362 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5363
5364 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5365 EXPECT_EQ(kNewMaxFramerate, stream->GetVideoStreams()[0].max_framerate);
5366}
5367
Åsa Persson23eba222018-10-02 14:47:06 +02005368TEST_F(WebRtcVideoChannelTest, SetNumTemporalLayersForSingleStream) {
5369 FakeVideoSendStream* stream = AddSendStream();
5370
5371 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5372 EXPECT_EQ(1UL, parameters.encodings.size());
5373 EXPECT_FALSE(parameters.encodings[0].num_temporal_layers.has_value());
5374 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5375
5376 // Note that this is testing the behavior of the FakeVideoSendStream, which
5377 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5378 // we are just testing the behavior of
5379 // EncoderStreamFactory::CreateEncoderStreams.
5380 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5381 EXPECT_FALSE(stream->GetVideoStreams()[0].num_temporal_layers.has_value());
5382
5383 // Set temporal layers and check that VideoStream.num_temporal_layers is set.
5384 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5385 parameters.encodings[0].num_temporal_layers = 2;
5386 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5387
5388 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5389 EXPECT_EQ(2UL, stream->GetVideoStreams()[0].num_temporal_layers);
5390}
5391
Seth Hampson7c682e02018-05-04 16:28:15 -07005392TEST_F(WebRtcVideoChannelTest,
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005393 CannotSetRtpSendParametersWithIncorrectNumberOfEncodings) {
skvladdc1c62c2016-03-16 19:07:43 -07005394 AddSendStream();
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005395 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07005396 // Two or more encodings should result in failure.
5397 parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Zach Steinba37b4b2018-01-23 15:02:36 -08005398 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeeffb2aced2017-01-06 23:05:37 -08005399 // Zero encodings should also fail.
5400 parameters.encodings.clear();
Zach Steinba37b4b2018-01-23 15:02:36 -08005401 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeeffb2aced2017-01-06 23:05:37 -08005402}
5403
Zach Stein3ca452b2018-01-18 10:01:24 -08005404TEST_F(WebRtcVideoChannelTest,
5405 CannotSetSimulcastRtpSendParametersWithIncorrectNumberOfEncodings) {
5406 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
5407 StreamParams sp = CreateSimStreamParams("cname", ssrcs);
5408 AddSendStream(sp);
5409
5410 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5411
5412 // Additional encodings should result in failure.
5413 parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Zach Steinba37b4b2018-01-23 15:02:36 -08005414 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Zach Stein3ca452b2018-01-18 10:01:24 -08005415 // Zero encodings should also fail.
5416 parameters.encodings.clear();
Zach Steinba37b4b2018-01-23 15:02:36 -08005417 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Zach Stein3ca452b2018-01-18 10:01:24 -08005418}
5419
deadbeeffb2aced2017-01-06 23:05:37 -08005420// Changing the SSRC through RtpParameters is not allowed.
eladalonf1841382017-06-12 01:16:46 -07005421TEST_F(WebRtcVideoChannelTest, CannotSetSsrcInRtpSendParameters) {
deadbeeffb2aced2017-01-06 23:05:37 -08005422 AddSendStream();
5423 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
Oskar Sundbom78807582017-11-16 11:09:55 +01005424 parameters.encodings[0].ssrc = 0xdeadbeef;
Zach Steinba37b4b2018-01-23 15:02:36 -08005425 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07005426}
5427
Seth Hampson24722b32017-12-22 09:36:42 -08005428// Tests that when RTCRtpEncodingParameters.bitrate_priority gets set to
5429// a value <= 0, setting the parameters returns false.
5430TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersInvalidBitratePriority) {
5431 AddSendStream();
5432 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5433 EXPECT_EQ(1UL, parameters.encodings.size());
5434 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5435 parameters.encodings[0].bitrate_priority);
5436
5437 parameters.encodings[0].bitrate_priority = 0;
Zach Steinba37b4b2018-01-23 15:02:36 -08005438 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005439 parameters.encodings[0].bitrate_priority = -2;
Zach Steinba37b4b2018-01-23 15:02:36 -08005440 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005441}
5442
5443// Tests when the the RTCRtpEncodingParameters.bitrate_priority gets set
5444// properly on the VideoChannel and propogates down to the video encoder.
5445TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersPriorityOneStream) {
5446 AddSendStream();
5447 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5448 EXPECT_EQ(1UL, parameters.encodings.size());
5449 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5450 parameters.encodings[0].bitrate_priority);
5451
5452 // Change the value and set it on the VideoChannel.
5453 double new_bitrate_priority = 2.0;
5454 parameters.encodings[0].bitrate_priority = new_bitrate_priority;
Zach Steinba37b4b2018-01-23 15:02:36 -08005455 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005456
5457 // Verify that the encoding parameters bitrate_priority is set for the
5458 // VideoChannel.
5459 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5460 EXPECT_EQ(1UL, parameters.encodings.size());
5461 EXPECT_EQ(new_bitrate_priority, parameters.encodings[0].bitrate_priority);
5462
5463 // Verify that the new value propagated down to the encoder.
5464 std::vector<FakeVideoSendStream*> video_send_streams =
5465 fake_call_->GetVideoSendStreams();
5466 EXPECT_EQ(1UL, video_send_streams.size());
5467 FakeVideoSendStream* video_send_stream = video_send_streams.front();
5468 // Check that the WebRtcVideoSendStream updated the VideoEncoderConfig
5469 // appropriately.
5470 EXPECT_EQ(new_bitrate_priority,
5471 video_send_stream->GetEncoderConfig().bitrate_priority);
5472 // Check that the vector of VideoStreams also was propagated correctly. Note
5473 // that this is testing the behavior of the FakeVideoSendStream, which mimics
5474 // the calls to CreateEncoderStreams to get the VideoStreams.
Danil Chapovalov00c71832018-06-15 15:58:38 +02005475 EXPECT_EQ(absl::optional<double>(new_bitrate_priority),
Seth Hampson24722b32017-12-22 09:36:42 -08005476 video_send_stream->GetVideoStreams()[0].bitrate_priority);
5477}
5478
5479// Tests that the RTCRtpEncodingParameters.bitrate_priority is set for the
5480// VideoChannel and the value propogates to the video encoder with all simulcast
5481// streams.
5482TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersPrioritySimulcastStreams) {
5483 // Create the stream params with multiple ssrcs for simulcast.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005484 const size_t kNumSimulcastStreams = 3;
Seth Hampson24722b32017-12-22 09:36:42 -08005485 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
5486 StreamParams stream_params = CreateSimStreamParams("cname", ssrcs);
5487 AddSendStream(stream_params);
5488 uint32_t primary_ssrc = stream_params.first_ssrc();
5489
Niels Möller805a27e2019-01-21 12:21:27 +01005490 // Using the FrameForwarder, we manually send a full size
Tommi85959932018-02-07 19:26:06 +01005491 // frame. This creates multiple VideoStreams for all simulcast layers when
5492 // reconfiguring, and allows us to test this behavior.
Niels Möller805a27e2019-01-21 12:21:27 +01005493 webrtc::test::FrameForwarder frame_forwarder;
Seth Hampson24722b32017-12-22 09:36:42 -08005494 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01005495 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, &options, &frame_forwarder));
Seth Hampson24722b32017-12-22 09:36:42 -08005496 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01005497 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame(
5498 1920, 1080, webrtc::VideoRotation::kVideoRotation_0,
5499 rtc::kNumMicrosecsPerSec / 30));
5500
Seth Hampson24722b32017-12-22 09:36:42 -08005501 // Get and set the rtp encoding parameters.
5502 webrtc::RtpParameters parameters =
5503 channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02005504 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson24722b32017-12-22 09:36:42 -08005505 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5506 parameters.encodings[0].bitrate_priority);
5507 // Change the value and set it on the VideoChannel.
5508 double new_bitrate_priority = 2.0;
5509 parameters.encodings[0].bitrate_priority = new_bitrate_priority;
Zach Steinba37b4b2018-01-23 15:02:36 -08005510 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005511
5512 // Verify that the encoding parameters priority is set on the VideoChannel.
5513 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02005514 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson24722b32017-12-22 09:36:42 -08005515 EXPECT_EQ(new_bitrate_priority, parameters.encodings[0].bitrate_priority);
5516
5517 // Verify that the new value propagated down to the encoder.
5518 std::vector<FakeVideoSendStream*> video_send_streams =
5519 fake_call_->GetVideoSendStreams();
5520 EXPECT_EQ(1UL, video_send_streams.size());
5521 FakeVideoSendStream* video_send_stream = video_send_streams.front();
5522 // Check that the WebRtcVideoSendStream updated the VideoEncoderConfig
5523 // appropriately.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005524 EXPECT_EQ(kNumSimulcastStreams,
Seth Hampson24722b32017-12-22 09:36:42 -08005525 video_send_stream->GetEncoderConfig().number_of_streams);
5526 EXPECT_EQ(new_bitrate_priority,
5527 video_send_stream->GetEncoderConfig().bitrate_priority);
5528 // Check that the vector of VideoStreams also propagated correctly. The
5529 // FakeVideoSendStream calls CreateEncoderStreams, and we are testing that
5530 // these are created appropriately for the simulcast case.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005531 EXPECT_EQ(kNumSimulcastStreams, video_send_stream->GetVideoStreams().size());
Danil Chapovalov00c71832018-06-15 15:58:38 +02005532 EXPECT_EQ(absl::optional<double>(new_bitrate_priority),
Seth Hampson24722b32017-12-22 09:36:42 -08005533 video_send_stream->GetVideoStreams()[0].bitrate_priority);
5534 // Since we are only setting bitrate priority per-sender, the other
5535 // VideoStreams should have a bitrate priority of 0.
Danil Chapovalov00c71832018-06-15 15:58:38 +02005536 EXPECT_EQ(absl::nullopt,
Seth Hampson24722b32017-12-22 09:36:42 -08005537 video_send_stream->GetVideoStreams()[1].bitrate_priority);
Danil Chapovalov00c71832018-06-15 15:58:38 +02005538 EXPECT_EQ(absl::nullopt,
Seth Hampson24722b32017-12-22 09:36:42 -08005539 video_send_stream->GetVideoStreams()[2].bitrate_priority);
Niels Möllerff40b142018-04-09 08:49:14 +02005540 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, nullptr, nullptr));
Seth Hampson24722b32017-12-22 09:36:42 -08005541}
5542
Tim Haloun648d28a2018-10-18 16:52:22 -07005543// RTCRtpEncodingParameters.network_priority must be one of a few values
5544// derived from the default priority, corresponding to very-low, low, medium,
5545// or high.
5546TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersInvalidNetworkPriority) {
5547 AddSendStream();
5548 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5549 EXPECT_EQ(1UL, parameters.encodings.size());
5550 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5551 parameters.encodings[0].network_priority);
5552
5553 double good_values[] = {0.5, 1.0, 2.0, 4.0};
5554 double bad_values[] = {-1.0, 0.0, 0.49, 0.51, 1.1, 3.99, 4.1, 5.0};
5555 for (auto it : good_values) {
5556 parameters.encodings[0].network_priority = it;
5557 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5558 }
5559 for (auto it : bad_values) {
5560 parameters.encodings[0].network_priority = it;
5561 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5562 }
5563}
5564
Florent Castellic1a0bcb2019-01-29 14:26:48 +01005565TEST_F(WebRtcVideoChannelTest,
5566 GetAndSetRtpSendParametersScaleResolutionDownByVP8) {
Rasmus Brandt9387b522019-02-05 14:23:26 +01005567 VideoSendParameters parameters;
5568 parameters.codecs.push_back(VideoCodec(kVp8CodecName));
Florent Castellic1a0bcb2019-01-29 14:26:48 +01005569 ASSERT_TRUE(channel_->SetSendParameters(parameters));
5570 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5571
5572 webrtc::test::FrameForwarder frame_forwarder;
Rasmus Brandt9387b522019-02-05 14:23:26 +01005573 FakeFrameSource frame_source(1280, 720, rtc::kNumMicrosecsPerSec / 30);
Florent Castellic1a0bcb2019-01-29 14:26:48 +01005574
5575 VideoOptions options;
5576 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
5577 channel_->SetSend(true);
5578
5579 // Try layers in natural order (smallest to largest).
5580 {
5581 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
5582 ASSERT_EQ(3u, rtp_parameters.encodings.size());
5583 rtp_parameters.encodings[0].scale_resolution_down_by = 4.0;
5584 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
5585 rtp_parameters.encodings[2].scale_resolution_down_by = 1.0;
5586 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
5587 ASSERT_TRUE(result.ok());
5588
5589 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
5590
5591 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
5592 ASSERT_EQ(3u, video_streams.size());
5593 EXPECT_EQ(320u, video_streams[0].width);
5594 EXPECT_EQ(180u, video_streams[0].height);
5595 EXPECT_EQ(640u, video_streams[1].width);
5596 EXPECT_EQ(360u, video_streams[1].height);
5597 EXPECT_EQ(1280u, video_streams[2].width);
5598 EXPECT_EQ(720u, video_streams[2].height);
5599 }
5600
5601 // Try layers in reverse natural order (largest to smallest).
5602 {
5603 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
5604 ASSERT_EQ(3u, rtp_parameters.encodings.size());
5605 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
5606 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
5607 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
5608 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
5609 ASSERT_TRUE(result.ok());
5610
5611 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
5612
5613 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
5614 ASSERT_EQ(3u, video_streams.size());
5615 EXPECT_EQ(1280u, video_streams[0].width);
5616 EXPECT_EQ(720u, video_streams[0].height);
5617 EXPECT_EQ(640u, video_streams[1].width);
5618 EXPECT_EQ(360u, video_streams[1].height);
5619 EXPECT_EQ(320u, video_streams[2].width);
5620 EXPECT_EQ(180u, video_streams[2].height);
5621 }
5622
5623 // Try layers in mixed order.
5624 {
5625 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
5626 ASSERT_EQ(3u, rtp_parameters.encodings.size());
5627 rtp_parameters.encodings[0].scale_resolution_down_by = 10.0;
5628 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
5629 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
5630 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
5631 ASSERT_TRUE(result.ok());
5632
5633 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
5634
5635 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
5636 ASSERT_EQ(3u, video_streams.size());
5637 EXPECT_EQ(128u, video_streams[0].width);
5638 EXPECT_EQ(72u, video_streams[0].height);
5639 EXPECT_EQ(640u, video_streams[1].width);
5640 EXPECT_EQ(360u, video_streams[1].height);
5641 EXPECT_EQ(320u, video_streams[2].width);
5642 EXPECT_EQ(180u, video_streams[2].height);
5643 }
5644
5645 // Try with a missing scale setting, defaults to 1.0 if any other is set.
5646 {
5647 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
5648 ASSERT_EQ(3u, rtp_parameters.encodings.size());
5649 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
5650 rtp_parameters.encodings[1].scale_resolution_down_by.reset();
5651 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
5652 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
5653 ASSERT_TRUE(result.ok());
5654
5655 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
5656
5657 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
5658 ASSERT_EQ(3u, video_streams.size());
5659 EXPECT_EQ(1280u, video_streams[0].width);
5660 EXPECT_EQ(720u, video_streams[0].height);
5661 EXPECT_EQ(1280u, video_streams[1].width);
5662 EXPECT_EQ(720u, video_streams[1].height);
5663 EXPECT_EQ(320u, video_streams[2].width);
5664 EXPECT_EQ(180u, video_streams[2].height);
5665 }
5666
5667 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5668}
5669
5670TEST_F(WebRtcVideoChannelTest,
Rasmus Brandt9387b522019-02-05 14:23:26 +01005671 GetAndSetRtpSendParametersScaleResolutionDownByVP8WithOddResolution) {
5672 // Ensure that the top layer has width and height divisible by 2^3,
5673 // so that the bottom layer has width and height divisible by 2.
5674 // TODO(bugs.webrtc.org/8785): Remove this field trial when we fully trust
5675 // the number of simulcast layers set by the app.
5676 webrtc::test::ScopedFieldTrials field_trial(
5677 "WebRTC-NormalizeSimulcastResolution/Enabled-3/");
5678
5679 // Set up WebRtcVideoChannel for 3-layer VP8 simulcast.
5680 VideoSendParameters parameters;
5681 parameters.codecs.push_back(VideoCodec(kVp8CodecName));
5682 ASSERT_TRUE(channel_->SetSendParameters(parameters));
5683 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5684 webrtc::test::FrameForwarder frame_forwarder;
5685 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, /*options=*/nullptr,
5686 &frame_forwarder));
5687 channel_->SetSend(true);
5688
5689 // Set |scale_resolution_down_by|'s.
5690 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
5691 ASSERT_EQ(rtp_parameters.encodings.size(), 3u);
5692 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
5693 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
5694 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
5695 const auto result =
5696 channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
5697 ASSERT_TRUE(result.ok());
5698
5699 // Use a capture resolution whose width and height are not divisible by 2^3.
5700 // (See field trial set at the top of the test.)
5701 FakeFrameSource frame_source(2007, 1207, rtc::kNumMicrosecsPerSec / 30);
5702 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
5703
5704 // Ensure the scaling is correct.
5705 const auto video_streams = stream->GetVideoStreams();
5706 ASSERT_EQ(video_streams.size(), 3u);
5707 // Ensure that we round the capture resolution down for the top layer...
5708 EXPECT_EQ(video_streams[0].width, 2000u);
5709 EXPECT_EQ(video_streams[0].height, 1200u);
5710 EXPECT_EQ(video_streams[1].width, 1000u);
5711 EXPECT_EQ(video_streams[1].height, 600u);
5712 // ...and that the bottom layer has a width/height divisible by 2.
5713 EXPECT_EQ(video_streams[2].width, 500u);
5714 EXPECT_EQ(video_streams[2].height, 300u);
5715
5716 // Tear down.
5717 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5718}
5719
5720TEST_F(WebRtcVideoChannelTest,
Florent Castellic1a0bcb2019-01-29 14:26:48 +01005721 GetAndSetRtpSendParametersScaleResolutionDownByH264) {
Rasmus Brandt9387b522019-02-05 14:23:26 +01005722 encoder_factory_->AddSupportedVideoCodecType(kH264CodecName);
5723 VideoSendParameters parameters;
5724 parameters.codecs.push_back(VideoCodec(kH264CodecName));
Florent Castellic1a0bcb2019-01-29 14:26:48 +01005725 ASSERT_TRUE(channel_->SetSendParameters(parameters));
5726 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5727
5728 webrtc::test::FrameForwarder frame_forwarder;
Rasmus Brandt9387b522019-02-05 14:23:26 +01005729 FakeFrameSource frame_source(1280, 720, rtc::kNumMicrosecsPerSec / 30);
Florent Castellic1a0bcb2019-01-29 14:26:48 +01005730
5731 VideoOptions options;
5732 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
5733 channel_->SetSend(true);
5734
5735 // Try layers in natural order (smallest to largest).
5736 {
5737 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
5738 ASSERT_EQ(3u, rtp_parameters.encodings.size());
5739 rtp_parameters.encodings[0].scale_resolution_down_by = 4.0;
5740 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
5741 rtp_parameters.encodings[2].scale_resolution_down_by = 1.0;
5742 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
5743 ASSERT_TRUE(result.ok());
5744
5745 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
5746
5747 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
5748 ASSERT_EQ(3u, video_streams.size());
5749 EXPECT_EQ(320u, video_streams[0].width);
5750 EXPECT_EQ(180u, video_streams[0].height);
5751 EXPECT_EQ(640u, video_streams[1].width);
5752 EXPECT_EQ(360u, video_streams[1].height);
5753 EXPECT_EQ(1280u, video_streams[2].width);
5754 EXPECT_EQ(720u, video_streams[2].height);
5755 }
5756
5757 // Try layers in reverse natural order (largest to smallest).
5758 {
5759 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
5760 ASSERT_EQ(3u, rtp_parameters.encodings.size());
5761 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
5762 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
5763 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
5764 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
5765 ASSERT_TRUE(result.ok());
5766
5767 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
5768
5769 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
5770 ASSERT_EQ(3u, video_streams.size());
5771 EXPECT_EQ(1280u, video_streams[0].width);
5772 EXPECT_EQ(720u, video_streams[0].height);
5773 EXPECT_EQ(640u, video_streams[1].width);
5774 EXPECT_EQ(360u, video_streams[1].height);
5775 EXPECT_EQ(320u, video_streams[2].width);
5776 EXPECT_EQ(180u, video_streams[2].height);
5777 }
5778
5779 // Try layers in mixed order.
5780 {
5781 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
5782 ASSERT_EQ(3u, rtp_parameters.encodings.size());
5783 rtp_parameters.encodings[0].scale_resolution_down_by = 10.0;
5784 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
5785 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
5786 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
5787 ASSERT_TRUE(result.ok());
5788
5789 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
5790
5791 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
5792 ASSERT_EQ(3u, video_streams.size());
5793 EXPECT_EQ(128u, video_streams[0].width);
5794 EXPECT_EQ(72u, video_streams[0].height);
5795 EXPECT_EQ(640u, video_streams[1].width);
5796 EXPECT_EQ(360u, video_streams[1].height);
5797 EXPECT_EQ(320u, video_streams[2].width);
5798 EXPECT_EQ(180u, video_streams[2].height);
5799 }
5800
5801 // Try with a missing scale setting, defaults to 1.0 if any other is set.
5802 {
5803 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
5804 ASSERT_EQ(3u, rtp_parameters.encodings.size());
5805 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
5806 rtp_parameters.encodings[1].scale_resolution_down_by.reset();
5807 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
5808 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
5809 ASSERT_TRUE(result.ok());
5810
5811 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
5812
5813 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
5814 ASSERT_EQ(3u, video_streams.size());
5815 EXPECT_EQ(1280u, video_streams[0].width);
5816 EXPECT_EQ(720u, video_streams[0].height);
5817 EXPECT_EQ(1280u, video_streams[1].width);
5818 EXPECT_EQ(720u, video_streams[1].height);
5819 EXPECT_EQ(320u, video_streams[2].width);
5820 EXPECT_EQ(180u, video_streams[2].height);
5821 }
5822 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5823}
5824
Rasmus Brandt9387b522019-02-05 14:23:26 +01005825TEST_F(WebRtcVideoChannelTest,
5826 GetAndSetRtpSendParametersScaleResolutionDownByH264WithOddResolution) {
5827 // Ensure that the top layer has width and height divisible by 2^3,
5828 // so that the bottom layer has width and height divisible by 2.
5829 // TODO(bugs.webrtc.org/8785): Remove this field trial when we fully trust
5830 // the number of simulcast layers set by the app.
5831 webrtc::test::ScopedFieldTrials field_trial(
5832 "WebRTC-NormalizeSimulcastResolution/Enabled-3/");
5833
5834 // Set up WebRtcVideoChannel for 3-layer H264 simulcast.
5835 encoder_factory_->AddSupportedVideoCodecType(kH264CodecName);
5836 VideoSendParameters parameters;
5837 parameters.codecs.push_back(VideoCodec(kH264CodecName));
5838 ASSERT_TRUE(channel_->SetSendParameters(parameters));
5839 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5840 webrtc::test::FrameForwarder frame_forwarder;
5841 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, /*options=*/nullptr,
5842 &frame_forwarder));
5843 channel_->SetSend(true);
5844
5845 // Set |scale_resolution_down_by|'s.
5846 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
5847 ASSERT_EQ(rtp_parameters.encodings.size(), 3u);
5848 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
5849 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
5850 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
5851 const auto result =
5852 channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
5853 ASSERT_TRUE(result.ok());
5854
5855 // Use a capture resolution whose width and height are not divisible by 2^3.
5856 // (See field trial set at the top of the test.)
5857 FakeFrameSource frame_source(2007, 1207, rtc::kNumMicrosecsPerSec / 30);
5858 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
5859
5860 // Ensure the scaling is correct.
5861 const auto video_streams = stream->GetVideoStreams();
5862 ASSERT_EQ(video_streams.size(), 3u);
5863 // Ensure that we round the capture resolution down for the top layer...
5864 EXPECT_EQ(video_streams[0].width, 2000u);
5865 EXPECT_EQ(video_streams[0].height, 1200u);
5866 EXPECT_EQ(video_streams[1].width, 1000u);
5867 EXPECT_EQ(video_streams[1].height, 600u);
5868 // ...and that the bottom layer has a width/height divisible by 2.
5869 EXPECT_EQ(video_streams[2].width, 500u);
5870 EXPECT_EQ(video_streams[2].height, 300u);
5871
5872 // Tear down.
5873 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5874}
5875
Åsa Persson8c1bf952018-09-13 10:42:19 +02005876TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersMaxFramerate) {
5877 const size_t kNumSimulcastStreams = 3;
5878 SetUpSimulcast(true, false);
5879
5880 // Get and set the rtp encoding parameters.
5881 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5882 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5883 for (const auto& encoding : parameters.encodings) {
5884 EXPECT_FALSE(encoding.max_framerate);
5885 }
5886
5887 // Change the value and set it on the VideoChannel.
5888 parameters.encodings[0].max_framerate = 10;
5889 parameters.encodings[1].max_framerate = 20;
5890 parameters.encodings[2].max_framerate = 25;
5891 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5892
5893 // Verify that the bitrates are set on the VideoChannel.
5894 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5895 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5896 EXPECT_EQ(10, parameters.encodings[0].max_framerate);
5897 EXPECT_EQ(20, parameters.encodings[1].max_framerate);
5898 EXPECT_EQ(25, parameters.encodings[2].max_framerate);
5899}
5900
Åsa Persson23eba222018-10-02 14:47:06 +02005901TEST_F(WebRtcVideoChannelTest,
5902 SetRtpSendParametersNumTemporalLayersFailsForInvalidRange) {
5903 const size_t kNumSimulcastStreams = 3;
5904 SetUpSimulcast(true, false);
5905
5906 // Get and set the rtp encoding parameters.
5907 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5908 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5909
5910 // Num temporal layers should be in the range [1, kMaxTemporalStreams].
5911 parameters.encodings[0].num_temporal_layers = 0;
5912 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
5913 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
5914 parameters.encodings[0].num_temporal_layers = webrtc::kMaxTemporalStreams + 1;
5915 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
5916 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
5917}
5918
5919TEST_F(WebRtcVideoChannelTest,
5920 SetRtpSendParametersNumTemporalLayersFailsForInvalidModification) {
5921 const size_t kNumSimulcastStreams = 3;
5922 SetUpSimulcast(true, false);
5923
5924 // Get and set the rtp encoding parameters.
5925 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5926 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5927
5928 // No/all layers should be set.
5929 parameters.encodings[0].num_temporal_layers = 1;
5930 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION,
5931 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
5932
5933 // Different values not supported.
5934 parameters.encodings[0].num_temporal_layers = 1;
5935 parameters.encodings[1].num_temporal_layers = 2;
5936 parameters.encodings[2].num_temporal_layers = 2;
5937 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION,
5938 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
5939}
5940
5941TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersNumTemporalLayers) {
5942 const size_t kNumSimulcastStreams = 3;
5943 SetUpSimulcast(true, false);
5944
5945 // Get and set the rtp encoding parameters.
5946 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5947 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5948 for (const auto& encoding : parameters.encodings)
5949 EXPECT_FALSE(encoding.num_temporal_layers);
5950
5951 // Change the value and set it on the VideoChannel.
5952 parameters.encodings[0].num_temporal_layers = 3;
5953 parameters.encodings[1].num_temporal_layers = 3;
5954 parameters.encodings[2].num_temporal_layers = 3;
5955 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5956
5957 // Verify that the number of temporal layers are set on the VideoChannel.
5958 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5959 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5960 EXPECT_EQ(3, parameters.encodings[0].num_temporal_layers);
5961 EXPECT_EQ(3, parameters.encodings[1].num_temporal_layers);
5962 EXPECT_EQ(3, parameters.encodings[2].num_temporal_layers);
5963}
5964
5965TEST_F(WebRtcVideoChannelTest, NumTemporalLayersPropagatedToEncoder) {
5966 const size_t kNumSimulcastStreams = 3;
5967 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5968
5969 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01005970 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson23eba222018-10-02 14:47:06 +02005971 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01005972 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson23eba222018-10-02 14:47:06 +02005973 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01005974 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson23eba222018-10-02 14:47:06 +02005975
5976 // Get and set the rtp encoding parameters.
5977 // Change the value and set it on the VideoChannel.
5978 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5979 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5980 parameters.encodings[0].num_temporal_layers = 2;
5981 parameters.encodings[1].num_temporal_layers = 2;
5982 parameters.encodings[2].num_temporal_layers = 2;
5983 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5984
5985 // Verify that the new value is propagated down to the encoder.
5986 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
5987 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
5988 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
5989 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
5990 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
5991 EXPECT_EQ(2UL, encoder_config.simulcast_layers[0].num_temporal_layers);
5992 EXPECT_EQ(2UL, encoder_config.simulcast_layers[1].num_temporal_layers);
5993 EXPECT_EQ(2UL, encoder_config.simulcast_layers[2].num_temporal_layers);
5994
5995 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
5996 // VideoStreams are created appropriately for the simulcast case.
5997 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5998 EXPECT_EQ(2UL, stream->GetVideoStreams()[0].num_temporal_layers);
5999 EXPECT_EQ(2UL, stream->GetVideoStreams()[1].num_temporal_layers);
6000 EXPECT_EQ(2UL, stream->GetVideoStreams()[2].num_temporal_layers);
6001
6002 // No parameter changed, encoder should not be reconfigured.
6003 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6004 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6005
6006 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6007}
6008
6009TEST_F(WebRtcVideoChannelTest,
6010 DefaultValuePropagatedToEncoderForUnsetNumTemporalLayers) {
6011 const size_t kDefaultNumTemporalLayers = 3;
6012 const size_t kNumSimulcastStreams = 3;
6013 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6014
6015 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006016 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson23eba222018-10-02 14:47:06 +02006017 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006018 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson23eba222018-10-02 14:47:06 +02006019 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006020 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson23eba222018-10-02 14:47:06 +02006021
6022 // Change rtp encoding parameters, num_temporal_layers not changed.
6023 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6024 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6025 parameters.encodings[0].min_bitrate_bps = 33000;
6026 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6027
6028 // Verify that no value is propagated down to the encoder.
6029 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6030 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6031 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6032 EXPECT_FALSE(encoder_config.simulcast_layers[0].num_temporal_layers);
6033 EXPECT_FALSE(encoder_config.simulcast_layers[1].num_temporal_layers);
6034 EXPECT_FALSE(encoder_config.simulcast_layers[2].num_temporal_layers);
6035
6036 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6037 // VideoStreams are created appropriately for the simulcast case.
6038 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6039 EXPECT_EQ(kDefaultNumTemporalLayers,
6040 stream->GetVideoStreams()[0].num_temporal_layers);
6041 EXPECT_EQ(kDefaultNumTemporalLayers,
6042 stream->GetVideoStreams()[1].num_temporal_layers);
6043 EXPECT_EQ(kDefaultNumTemporalLayers,
6044 stream->GetVideoStreams()[2].num_temporal_layers);
6045
6046 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6047}
6048
Åsa Persson8c1bf952018-09-13 10:42:19 +02006049TEST_F(WebRtcVideoChannelTest, MaxSimulcastFrameratePropagatedToEncoder) {
6050 const size_t kNumSimulcastStreams = 3;
6051 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6052
6053 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006054 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson8c1bf952018-09-13 10:42:19 +02006055 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006056 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson8c1bf952018-09-13 10:42:19 +02006057 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006058 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson8c1bf952018-09-13 10:42:19 +02006059
6060 // Get and set the rtp encoding parameters.
6061 // Change the value and set it on the VideoChannel.
6062 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6063 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6064 parameters.encodings[0].max_framerate = 15;
6065 parameters.encodings[1].max_framerate = 25;
6066 parameters.encodings[2].max_framerate = 20;
6067 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6068
6069 // Verify that the new value propagated down to the encoder.
6070 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6071 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6072 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6073 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6074 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6075 EXPECT_EQ(15, encoder_config.simulcast_layers[0].max_framerate);
6076 EXPECT_EQ(25, encoder_config.simulcast_layers[1].max_framerate);
6077 EXPECT_EQ(20, encoder_config.simulcast_layers[2].max_framerate);
6078
6079 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6080 // VideoStreams are created appropriately for the simulcast case.
6081 // Currently the maximum |max_framerate| is used.
6082 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6083 EXPECT_EQ(25, stream->GetVideoStreams()[0].max_framerate);
6084 EXPECT_EQ(25, stream->GetVideoStreams()[1].max_framerate);
6085 EXPECT_EQ(25, stream->GetVideoStreams()[2].max_framerate);
6086
6087 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6088}
6089
6090TEST_F(WebRtcVideoChannelTest,
6091 DefaultValuePropagatedToEncoderForUnsetFramerate) {
6092 const size_t kNumSimulcastStreams = 3;
6093 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6094 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6095
6096 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006097 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson8c1bf952018-09-13 10:42:19 +02006098 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006099 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson8c1bf952018-09-13 10:42:19 +02006100 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006101 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson8c1bf952018-09-13 10:42:19 +02006102
6103 // Get and set the rtp encoding parameters.
6104 // Change the value and set it on the VideoChannel.
6105 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6106 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6107 parameters.encodings[0].max_framerate = 15;
6108 parameters.encodings[2].max_framerate = 20;
6109 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6110
6111 // Verify that the new value propagated down to the encoder.
6112 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6113 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6114 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6115 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6116 EXPECT_EQ(15, encoder_config.simulcast_layers[0].max_framerate);
6117 EXPECT_EQ(-1, encoder_config.simulcast_layers[1].max_framerate);
6118 EXPECT_EQ(20, encoder_config.simulcast_layers[2].max_framerate);
6119
6120 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6121 // VideoStreams are created appropriately for the simulcast case.
6122 // The maximum |max_framerate| is used, kDefaultVideoMaxFramerate: 60.
6123 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6124 EXPECT_EQ(kDefaultVideoMaxFramerate,
6125 stream->GetVideoStreams()[0].max_framerate);
6126 EXPECT_EQ(kDefaultVideoMaxFramerate,
6127 stream->GetVideoStreams()[1].max_framerate);
6128 EXPECT_EQ(kDefaultVideoMaxFramerate,
6129 stream->GetVideoStreams()[2].max_framerate);
6130
6131 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6132}
6133
Åsa Persson55659812018-06-18 17:51:32 +02006134TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersMinAndMaxBitrate) {
6135 const size_t kNumSimulcastStreams = 3;
6136 SetUpSimulcast(true, false);
6137
6138 // Get and set the rtp encoding parameters.
6139 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6140 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6141 for (const auto& encoding : parameters.encodings) {
6142 EXPECT_FALSE(encoding.min_bitrate_bps);
6143 EXPECT_FALSE(encoding.max_bitrate_bps);
6144 }
6145
6146 // Change the value and set it on the VideoChannel.
6147 parameters.encodings[0].min_bitrate_bps = 100000;
6148 parameters.encodings[0].max_bitrate_bps = 200000;
6149 parameters.encodings[1].min_bitrate_bps = 300000;
6150 parameters.encodings[1].max_bitrate_bps = 400000;
6151 parameters.encodings[2].min_bitrate_bps = 500000;
6152 parameters.encodings[2].max_bitrate_bps = 600000;
6153 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6154
6155 // Verify that the bitrates are set on the VideoChannel.
6156 parameters = channel_->GetRtpSendParameters(last_ssrc_);
6157 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6158 EXPECT_EQ(100000, parameters.encodings[0].min_bitrate_bps);
6159 EXPECT_EQ(200000, parameters.encodings[0].max_bitrate_bps);
6160 EXPECT_EQ(300000, parameters.encodings[1].min_bitrate_bps);
6161 EXPECT_EQ(400000, parameters.encodings[1].max_bitrate_bps);
6162 EXPECT_EQ(500000, parameters.encodings[2].min_bitrate_bps);
6163 EXPECT_EQ(600000, parameters.encodings[2].max_bitrate_bps);
6164}
6165
6166TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersFailsWithIncorrectBitrate) {
6167 const size_t kNumSimulcastStreams = 3;
6168 SetUpSimulcast(true, false);
6169
6170 // Get and set the rtp encoding parameters.
6171 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6172 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6173
6174 // Max bitrate lower than min bitrate should fail.
6175 parameters.encodings[2].min_bitrate_bps = 100000;
6176 parameters.encodings[2].max_bitrate_bps = 100000 - 1;
6177 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
6178 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6179}
6180
6181// Test that min and max bitrate values set via RtpParameters are correctly
6182// propagated to the underlying encoder, and that the target is set to 3/4 of
6183// the maximum (3/4 was chosen because it's similar to the simulcast defaults
6184// that are used if no min/max are specified).
6185TEST_F(WebRtcVideoChannelTest, MinAndMaxSimulcastBitratePropagatedToEncoder) {
6186 const size_t kNumSimulcastStreams = 3;
6187 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6188
6189 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006190 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006191 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006192 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006193 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006194 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006195
6196 // Get and set the rtp encoding parameters.
6197 // Change the value and set it on the VideoChannel.
6198 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6199 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6200 parameters.encodings[0].min_bitrate_bps = 100000;
6201 parameters.encodings[0].max_bitrate_bps = 200000;
6202 parameters.encodings[1].min_bitrate_bps = 300000;
6203 parameters.encodings[1].max_bitrate_bps = 400000;
6204 parameters.encodings[2].min_bitrate_bps = 500000;
6205 parameters.encodings[2].max_bitrate_bps = 600000;
6206 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6207
6208 // Verify that the new value propagated down to the encoder.
6209 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6210 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6211 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6212 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6213 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6214 EXPECT_EQ(100000, encoder_config.simulcast_layers[0].min_bitrate_bps);
6215 EXPECT_EQ(200000, encoder_config.simulcast_layers[0].max_bitrate_bps);
6216 EXPECT_EQ(300000, encoder_config.simulcast_layers[1].min_bitrate_bps);
6217 EXPECT_EQ(400000, encoder_config.simulcast_layers[1].max_bitrate_bps);
6218 EXPECT_EQ(500000, encoder_config.simulcast_layers[2].min_bitrate_bps);
6219 EXPECT_EQ(600000, encoder_config.simulcast_layers[2].max_bitrate_bps);
6220
6221 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6222 // VideoStreams are created appropriately for the simulcast case.
6223 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6224 // Target bitrate: 200000 * 3 / 4 = 150000.
6225 EXPECT_EQ(100000, stream->GetVideoStreams()[0].min_bitrate_bps);
6226 EXPECT_EQ(150000, stream->GetVideoStreams()[0].target_bitrate_bps);
6227 EXPECT_EQ(200000, stream->GetVideoStreams()[0].max_bitrate_bps);
6228 // Target bitrate: 400000 * 3 / 4 = 300000.
6229 EXPECT_EQ(300000, stream->GetVideoStreams()[1].min_bitrate_bps);
6230 EXPECT_EQ(300000, stream->GetVideoStreams()[1].target_bitrate_bps);
6231 EXPECT_EQ(400000, stream->GetVideoStreams()[1].max_bitrate_bps);
6232 // Target bitrate: 600000 * 3 / 4 = 450000, less than min -> max.
6233 EXPECT_EQ(500000, stream->GetVideoStreams()[2].min_bitrate_bps);
6234 EXPECT_EQ(600000, stream->GetVideoStreams()[2].target_bitrate_bps);
6235 EXPECT_EQ(600000, stream->GetVideoStreams()[2].max_bitrate_bps);
6236
6237 // No parameter changed, encoder should not be reconfigured.
6238 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6239 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6240
6241 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6242}
6243
6244// Test to only specify the min or max bitrate value for a layer via
6245// RtpParameters. The unspecified min/max and target value should be set to the
6246// simulcast default that is used if no min/max are specified.
6247TEST_F(WebRtcVideoChannelTest, MinOrMaxSimulcastBitratePropagatedToEncoder) {
6248 const size_t kNumSimulcastStreams = 3;
6249 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6250 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6251
6252 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006253 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006254 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006255 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006256 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006257 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006258
6259 // Get and set the rtp encoding parameters.
6260 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6261 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6262
6263 // Change the value and set it on the VideoChannel.
6264 // Layer 0: only configure min bitrate.
6265 const int kMinBpsLayer0 = kDefault[0].min_bitrate_bps + 1;
6266 parameters.encodings[0].min_bitrate_bps = kMinBpsLayer0;
6267 // Layer 1: only configure max bitrate.
6268 const int kMaxBpsLayer1 = kDefault[1].max_bitrate_bps - 1;
6269 parameters.encodings[1].max_bitrate_bps = kMaxBpsLayer1;
6270 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6271
6272 // Verify that the new value propagated down to the encoder.
6273 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6274 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6275 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6276 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6277 EXPECT_EQ(kMinBpsLayer0, encoder_config.simulcast_layers[0].min_bitrate_bps);
6278 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].max_bitrate_bps);
6279 EXPECT_EQ(-1, encoder_config.simulcast_layers[1].min_bitrate_bps);
6280 EXPECT_EQ(kMaxBpsLayer1, encoder_config.simulcast_layers[1].max_bitrate_bps);
6281 EXPECT_EQ(-1, encoder_config.simulcast_layers[2].min_bitrate_bps);
6282 EXPECT_EQ(-1, encoder_config.simulcast_layers[2].max_bitrate_bps);
6283
6284 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6285 // VideoStreams are created appropriately for the simulcast case.
6286 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6287 // Layer 0: min configured bitrate should overwrite min default.
6288 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].min_bitrate_bps);
6289 EXPECT_EQ(kDefault[0].target_bitrate_bps,
6290 stream->GetVideoStreams()[0].target_bitrate_bps);
6291 EXPECT_EQ(kDefault[0].max_bitrate_bps,
6292 stream->GetVideoStreams()[0].max_bitrate_bps);
6293 // Layer 1: max configured bitrate should overwrite max default.
6294 EXPECT_EQ(kDefault[1].min_bitrate_bps,
6295 stream->GetVideoStreams()[1].min_bitrate_bps);
6296 EXPECT_EQ(kDefault[1].target_bitrate_bps,
6297 stream->GetVideoStreams()[1].target_bitrate_bps);
6298 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].max_bitrate_bps);
6299 // Layer 2: min and max bitrate not configured, default expected.
6300 EXPECT_EQ(kDefault[2].min_bitrate_bps,
6301 stream->GetVideoStreams()[2].min_bitrate_bps);
6302 EXPECT_EQ(kDefault[2].target_bitrate_bps,
6303 stream->GetVideoStreams()[2].target_bitrate_bps);
6304 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6305 stream->GetVideoStreams()[2].max_bitrate_bps);
6306
6307 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6308}
6309
6310// Test that specifying the min (or max) bitrate value for a layer via
6311// RtpParameters above (or below) the simulcast default max (or min) adjusts the
6312// unspecified values accordingly.
6313TEST_F(WebRtcVideoChannelTest, SetMinAndMaxSimulcastBitrateAboveBelowDefault) {
6314 const size_t kNumSimulcastStreams = 3;
6315 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6316 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6317
6318 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006319 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006320 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006321 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006322 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006323 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006324
6325 // Get and set the rtp encoding parameters.
6326 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6327 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6328
6329 // Change the value and set it on the VideoChannel.
6330 // For layer 0, set the min bitrate above the default max.
6331 const int kMinBpsLayer0 = kDefault[0].max_bitrate_bps + 1;
6332 parameters.encodings[0].min_bitrate_bps = kMinBpsLayer0;
6333 // For layer 1, set the max bitrate below the default min.
6334 const int kMaxBpsLayer1 = kDefault[1].min_bitrate_bps - 1;
6335 parameters.encodings[1].max_bitrate_bps = kMaxBpsLayer1;
6336 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6337
6338 // Verify that the new value propagated down to the encoder.
6339 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6340 // VideoStreams are created appropriately for the simulcast case.
6341 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6342 // Layer 0: Min bitrate above default max (target/max should be adjusted).
6343 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].min_bitrate_bps);
6344 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].target_bitrate_bps);
6345 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].max_bitrate_bps);
6346 // Layer 1: Max bitrate below default min (min/target should be adjusted).
6347 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].min_bitrate_bps);
6348 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].target_bitrate_bps);
6349 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].max_bitrate_bps);
6350 // Layer 2: min and max bitrate not configured, default expected.
6351 EXPECT_EQ(kDefault[2].min_bitrate_bps,
6352 stream->GetVideoStreams()[2].min_bitrate_bps);
6353 EXPECT_EQ(kDefault[2].target_bitrate_bps,
6354 stream->GetVideoStreams()[2].target_bitrate_bps);
6355 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6356 stream->GetVideoStreams()[2].max_bitrate_bps);
6357
6358 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6359}
6360
6361TEST_F(WebRtcVideoChannelTest, BandwidthAboveTotalMaxBitrateGivenToMaxLayer) {
6362 const size_t kNumSimulcastStreams = 3;
6363 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6364 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6365
6366 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006367 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006368 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006369 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006370 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006371 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006372
6373 // Set max bitrate for all but the highest layer.
6374 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6375 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6376 parameters.encodings[0].max_bitrate_bps = kDefault[0].max_bitrate_bps;
6377 parameters.encodings[1].max_bitrate_bps = kDefault[1].max_bitrate_bps;
6378 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6379
6380 // Set max bandwidth equal to total max bitrate.
6381 send_parameters_.max_bandwidth_bps =
6382 GetTotalMaxBitrateBps(stream->GetVideoStreams());
6383 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6384 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6385
6386 // No bitrate above the total max to give to the highest layer.
6387 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6388 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6389 stream->GetVideoStreams()[2].max_bitrate_bps);
6390
6391 // Set max bandwidth above the total max bitrate.
6392 send_parameters_.max_bandwidth_bps =
6393 GetTotalMaxBitrateBps(stream->GetVideoStreams()) + 1;
6394 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6395 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6396
6397 // The highest layer has no max bitrate set -> the bitrate above the total
6398 // max should be given to the highest layer.
6399 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6400 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
6401 GetTotalMaxBitrateBps(stream->GetVideoStreams()));
6402 EXPECT_EQ(kDefault[2].max_bitrate_bps + 1,
6403 stream->GetVideoStreams()[2].max_bitrate_bps);
6404
6405 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6406}
6407
6408TEST_F(WebRtcVideoChannelTest,
6409 BandwidthAboveTotalMaxBitrateNotGivenToMaxLayerIfMaxBitrateSet) {
6410 const size_t kNumSimulcastStreams = 3;
6411 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6412 EXPECT_EQ(kNumSimulcastStreams, kDefault.size());
6413 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6414
6415 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006416 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006417 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006418 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006419 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006420 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006421
6422 // Set max bitrate for the highest layer.
6423 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6424 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6425 parameters.encodings[2].max_bitrate_bps = kDefault[2].max_bitrate_bps;
6426 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6427
6428 // Set max bandwidth above the total max bitrate.
6429 send_parameters_.max_bandwidth_bps =
6430 GetTotalMaxBitrateBps(stream->GetVideoStreams()) + 1;
6431 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6432 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6433
6434 // The highest layer has the max bitrate set -> the bitrate above the total
6435 // max should not be given to the highest layer.
6436 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6437 EXPECT_EQ(*parameters.encodings[2].max_bitrate_bps,
6438 stream->GetVideoStreams()[2].max_bitrate_bps);
6439
6440 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6441}
6442
Åsa Perssonbdee46d2018-06-25 11:28:06 +02006443// Test that min and max bitrate values set via RtpParameters are correctly
6444// propagated to the underlying encoder for a single stream.
6445TEST_F(WebRtcVideoChannelTest, MinAndMaxBitratePropagatedToEncoder) {
6446 FakeVideoSendStream* stream = AddSendStream();
6447 EXPECT_TRUE(channel_->SetSend(true));
6448 EXPECT_TRUE(stream->IsSending());
6449
6450 // Set min and max bitrate.
6451 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6452 EXPECT_EQ(1u, parameters.encodings.size());
6453 parameters.encodings[0].min_bitrate_bps = 80000;
6454 parameters.encodings[0].max_bitrate_bps = 150000;
6455 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6456
6457 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6458 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6459 EXPECT_EQ(1u, encoder_config.number_of_streams);
6460 EXPECT_EQ(1u, encoder_config.simulcast_layers.size());
6461 EXPECT_EQ(80000, encoder_config.simulcast_layers[0].min_bitrate_bps);
6462 EXPECT_EQ(150000, encoder_config.simulcast_layers[0].max_bitrate_bps);
6463
6464 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6465 // VideoStreams are created appropriately.
6466 EXPECT_EQ(1u, stream->GetVideoStreams().size());
6467 EXPECT_EQ(80000, stream->GetVideoStreams()[0].min_bitrate_bps);
6468 EXPECT_EQ(150000, stream->GetVideoStreams()[0].target_bitrate_bps);
6469 EXPECT_EQ(150000, stream->GetVideoStreams()[0].max_bitrate_bps);
6470}
6471
6472// Test the default min and max bitrate value are correctly propagated to the
6473// underlying encoder for a single stream (when the values are not set via
6474// RtpParameters).
6475TEST_F(WebRtcVideoChannelTest, DefaultMinAndMaxBitratePropagatedToEncoder) {
6476 FakeVideoSendStream* stream = AddSendStream();
6477 EXPECT_TRUE(channel_->SetSend(true));
6478 EXPECT_TRUE(stream->IsSending());
6479
6480 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6481 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6482 EXPECT_EQ(1u, encoder_config.number_of_streams);
6483 EXPECT_EQ(1u, encoder_config.simulcast_layers.size());
6484 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].min_bitrate_bps);
6485 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].max_bitrate_bps);
6486
6487 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6488 // VideoStreams are created appropriately.
6489 EXPECT_EQ(1u, stream->GetVideoStreams().size());
6490 EXPECT_EQ(cricket::kMinVideoBitrateBps,
6491 stream->GetVideoStreams()[0].min_bitrate_bps);
6492 EXPECT_GT(stream->GetVideoStreams()[0].max_bitrate_bps,
6493 stream->GetVideoStreams()[0].min_bitrate_bps);
6494 EXPECT_EQ(stream->GetVideoStreams()[0].max_bitrate_bps,
6495 stream->GetVideoStreams()[0].target_bitrate_bps);
6496}
6497
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006498// Test that a stream will not be sending if its encoding is made inactive
6499// through SetRtpSendParameters.
Seth Hampson8234ead2018-02-02 15:16:24 -08006500TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersOneEncodingActive) {
deadbeefdbe2b872016-03-22 15:42:00 -07006501 FakeVideoSendStream* stream = AddSendStream();
6502 EXPECT_TRUE(channel_->SetSend(true));
6503 EXPECT_TRUE(stream->IsSending());
6504
6505 // Get current parameters and change "active" to false.
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006506 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
deadbeefdbe2b872016-03-22 15:42:00 -07006507 ASSERT_EQ(1u, parameters.encodings.size());
6508 ASSERT_TRUE(parameters.encodings[0].active);
6509 parameters.encodings[0].active = false;
Zach Steinba37b4b2018-01-23 15:02:36 -08006510 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeefdbe2b872016-03-22 15:42:00 -07006511 EXPECT_FALSE(stream->IsSending());
6512
6513 // Now change it back to active and verify we resume sending.
6514 parameters.encodings[0].active = true;
Zach Steinba37b4b2018-01-23 15:02:36 -08006515 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeefdbe2b872016-03-22 15:42:00 -07006516 EXPECT_TRUE(stream->IsSending());
6517}
6518
Seth Hampson8234ead2018-02-02 15:16:24 -08006519// Tests that when active is updated for any simulcast layer then the send
6520// stream's sending state will be updated and it will be reconfigured with the
6521// new appropriate active simulcast streams.
6522TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersMultipleEncodingsActive) {
6523 // Create the stream params with multiple ssrcs for simulcast.
Åsa Persson31cb8f92018-06-27 10:44:56 +02006524 const size_t kNumSimulcastStreams = 3;
Seth Hampson8234ead2018-02-02 15:16:24 -08006525 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
6526 StreamParams stream_params = CreateSimStreamParams("cname", ssrcs);
6527 FakeVideoSendStream* fake_video_send_stream = AddSendStream(stream_params);
6528 uint32_t primary_ssrc = stream_params.first_ssrc();
6529
Niels Möller805a27e2019-01-21 12:21:27 +01006530 // Using the FrameForwarder, we manually send a full size
Tommi85959932018-02-07 19:26:06 +01006531 // frame. This allows us to test that ReconfigureEncoder is called
6532 // appropriately.
Niels Möller805a27e2019-01-21 12:21:27 +01006533 webrtc::test::FrameForwarder frame_forwarder;
Seth Hampson8234ead2018-02-02 15:16:24 -08006534 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006535 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, &options, &frame_forwarder));
Seth Hampson8234ead2018-02-02 15:16:24 -08006536 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006537 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame(
6538 1920, 1080, webrtc::VideoRotation::kVideoRotation_0,
6539 rtc::kNumMicrosecsPerSec / 30));
Seth Hampson8234ead2018-02-02 15:16:24 -08006540
6541 // Check that all encodings are initially active.
6542 webrtc::RtpParameters parameters =
6543 channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02006544 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006545 EXPECT_TRUE(parameters.encodings[0].active);
6546 EXPECT_TRUE(parameters.encodings[1].active);
6547 EXPECT_TRUE(parameters.encodings[2].active);
6548 EXPECT_TRUE(fake_video_send_stream->IsSending());
6549
6550 // Only turn on only the middle stream.
6551 parameters.encodings[0].active = false;
6552 parameters.encodings[1].active = true;
6553 parameters.encodings[2].active = false;
6554 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
6555 // Verify that the active fields are set on the VideoChannel.
6556 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02006557 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006558 EXPECT_FALSE(parameters.encodings[0].active);
6559 EXPECT_TRUE(parameters.encodings[1].active);
6560 EXPECT_FALSE(parameters.encodings[2].active);
6561 // Check that the VideoSendStream is updated appropriately. This means its
6562 // send state was updated and it was reconfigured.
6563 EXPECT_TRUE(fake_video_send_stream->IsSending());
6564 std::vector<webrtc::VideoStream> simulcast_streams =
6565 fake_video_send_stream->GetVideoStreams();
Åsa Persson31cb8f92018-06-27 10:44:56 +02006566 EXPECT_EQ(kNumSimulcastStreams, simulcast_streams.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006567 EXPECT_FALSE(simulcast_streams[0].active);
6568 EXPECT_TRUE(simulcast_streams[1].active);
6569 EXPECT_FALSE(simulcast_streams[2].active);
6570
6571 // Turn off all streams.
6572 parameters.encodings[0].active = false;
6573 parameters.encodings[1].active = false;
6574 parameters.encodings[2].active = false;
6575 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
6576 // Verify that the active fields are set on the VideoChannel.
6577 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02006578 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006579 EXPECT_FALSE(parameters.encodings[0].active);
6580 EXPECT_FALSE(parameters.encodings[1].active);
6581 EXPECT_FALSE(parameters.encodings[2].active);
6582 // Check that the VideoSendStream is off.
6583 EXPECT_FALSE(fake_video_send_stream->IsSending());
6584 simulcast_streams = fake_video_send_stream->GetVideoStreams();
Åsa Persson31cb8f92018-06-27 10:44:56 +02006585 EXPECT_EQ(kNumSimulcastStreams, simulcast_streams.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006586 EXPECT_FALSE(simulcast_streams[0].active);
6587 EXPECT_FALSE(simulcast_streams[1].active);
6588 EXPECT_FALSE(simulcast_streams[2].active);
6589
Niels Möllerff40b142018-04-09 08:49:14 +02006590 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, nullptr, nullptr));
Seth Hampson8234ead2018-02-02 15:16:24 -08006591}
6592
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006593// Test that if a stream is reconfigured (due to a codec change or other
6594// change) while its encoding is still inactive, it doesn't start sending.
eladalonf1841382017-06-12 01:16:46 -07006595TEST_F(WebRtcVideoChannelTest,
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006596 InactiveStreamDoesntStartSendingWhenReconfigured) {
6597 // Set an initial codec list, which will be modified later.
6598 cricket::VideoSendParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08006599 parameters1.codecs.push_back(GetEngineCodec("VP8"));
6600 parameters1.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006601 EXPECT_TRUE(channel_->SetSendParameters(parameters1));
6602
6603 FakeVideoSendStream* stream = AddSendStream();
6604 EXPECT_TRUE(channel_->SetSend(true));
6605 EXPECT_TRUE(stream->IsSending());
6606
6607 // Get current parameters and change "active" to false.
6608 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6609 ASSERT_EQ(1u, parameters.encodings.size());
6610 ASSERT_TRUE(parameters.encodings[0].active);
6611 parameters.encodings[0].active = false;
6612 EXPECT_EQ(1u, GetFakeSendStreams().size());
6613 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
Zach Steinba37b4b2018-01-23 15:02:36 -08006614 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006615 EXPECT_FALSE(stream->IsSending());
6616
6617 // Reorder the codec list, causing the stream to be reconfigured.
6618 cricket::VideoSendParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08006619 parameters2.codecs.push_back(GetEngineCodec("VP9"));
6620 parameters2.codecs.push_back(GetEngineCodec("VP8"));
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006621 EXPECT_TRUE(channel_->SetSendParameters(parameters2));
6622 auto new_streams = GetFakeSendStreams();
6623 // Assert that a new underlying stream was created due to the codec change.
6624 // Otherwise, this test isn't testing what it set out to test.
6625 EXPECT_EQ(1u, GetFakeSendStreams().size());
6626 EXPECT_EQ(2, fake_call_->GetNumCreatedSendStreams());
6627
6628 // Verify that we still are not sending anything, due to the inactive
6629 // encoding.
6630 EXPECT_FALSE(new_streams[0]->IsSending());
6631}
6632
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006633// Test that GetRtpSendParameters returns the currently configured codecs.
eladalonf1841382017-06-12 01:16:46 -07006634TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersCodecs) {
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006635 AddSendStream();
6636 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006637 parameters.codecs.push_back(GetEngineCodec("VP8"));
6638 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006639 EXPECT_TRUE(channel_->SetSendParameters(parameters));
6640
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006641 webrtc::RtpParameters rtp_parameters =
6642 channel_->GetRtpSendParameters(last_ssrc_);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006643 ASSERT_EQ(2u, rtp_parameters.codecs.size());
magjed509e4fe2016-11-18 01:34:11 -08006644 EXPECT_EQ(GetEngineCodec("VP8").ToCodecParameters(),
6645 rtp_parameters.codecs[0]);
6646 EXPECT_EQ(GetEngineCodec("VP9").ToCodecParameters(),
6647 rtp_parameters.codecs[1]);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006648}
6649
Florent Castellidacec712018-05-24 16:24:21 +02006650// Test that GetRtpSendParameters returns the currently configured RTCP CNAME.
6651TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersRtcpCname) {
6652 StreamParams params = StreamParams::CreateLegacy(kSsrc);
6653 params.cname = "rtcpcname";
6654 AddSendStream(params);
6655
6656 webrtc::RtpParameters rtp_parameters = channel_->GetRtpSendParameters(kSsrc);
6657 EXPECT_STREQ("rtcpcname", rtp_parameters.rtcp.cname.c_str());
6658}
6659
deadbeeffb2aced2017-01-06 23:05:37 -08006660// Test that RtpParameters for send stream has one encoding and it has
6661// the correct SSRC.
eladalonf1841382017-06-12 01:16:46 -07006662TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersSsrc) {
deadbeeffb2aced2017-01-06 23:05:37 -08006663 AddSendStream();
6664
6665 webrtc::RtpParameters rtp_parameters =
6666 channel_->GetRtpSendParameters(last_ssrc_);
6667 ASSERT_EQ(1u, rtp_parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01006668 EXPECT_EQ(last_ssrc_, rtp_parameters.encodings[0].ssrc);
deadbeeffb2aced2017-01-06 23:05:37 -08006669}
6670
Florent Castelliabe301f2018-06-12 18:33:49 +02006671TEST_F(WebRtcVideoChannelTest, DetectRtpSendParameterHeaderExtensionsChange) {
6672 AddSendStream();
6673
6674 webrtc::RtpParameters rtp_parameters =
6675 channel_->GetRtpSendParameters(last_ssrc_);
6676 rtp_parameters.header_extensions.emplace_back();
6677
6678 EXPECT_NE(0u, rtp_parameters.header_extensions.size());
6679
6680 webrtc::RTCError result =
6681 channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6682 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION, result.type());
6683}
6684
Florent Castelli87b3c512018-07-18 16:00:28 +02006685TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersDegradationPreference) {
6686 AddSendStream();
6687
Niels Möller805a27e2019-01-21 12:21:27 +01006688 webrtc::test::FrameForwarder frame_forwarder;
6689 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Florent Castelli87b3c512018-07-18 16:00:28 +02006690
6691 webrtc::RtpParameters rtp_parameters =
6692 channel_->GetRtpSendParameters(last_ssrc_);
6693 EXPECT_EQ(rtp_parameters.degradation_preference,
6694 webrtc::DegradationPreference::BALANCED);
6695 rtp_parameters.degradation_preference =
6696 webrtc::DegradationPreference::MAINTAIN_FRAMERATE;
6697
6698 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters).ok());
6699
6700 webrtc::RtpParameters updated_rtp_parameters =
6701 channel_->GetRtpSendParameters(last_ssrc_);
6702 EXPECT_EQ(updated_rtp_parameters.degradation_preference,
6703 webrtc::DegradationPreference::MAINTAIN_FRAMERATE);
6704
6705 // Remove the source since it will be destroyed before the channel
6706 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6707}
6708
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006709// Test that if we set/get parameters multiple times, we get the same results.
eladalonf1841382017-06-12 01:16:46 -07006710TEST_F(WebRtcVideoChannelTest, SetAndGetRtpSendParameters) {
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006711 AddSendStream();
6712 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006713 parameters.codecs.push_back(GetEngineCodec("VP8"));
6714 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006715 EXPECT_TRUE(channel_->SetSendParameters(parameters));
6716
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006717 webrtc::RtpParameters initial_params =
6718 channel_->GetRtpSendParameters(last_ssrc_);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006719
6720 // We should be able to set the params we just got.
Zach Steinba37b4b2018-01-23 15:02:36 -08006721 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, initial_params).ok());
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006722
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006723 // ... And this shouldn't change the params returned by GetRtpSendParameters.
6724 EXPECT_EQ(initial_params, channel_->GetRtpSendParameters(last_ssrc_));
6725}
6726
6727// Test that GetRtpReceiveParameters returns the currently configured codecs.
eladalonf1841382017-06-12 01:16:46 -07006728TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersCodecs) {
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006729 AddRecvStream();
6730 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006731 parameters.codecs.push_back(GetEngineCodec("VP8"));
6732 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006733 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6734
6735 webrtc::RtpParameters rtp_parameters =
6736 channel_->GetRtpReceiveParameters(last_ssrc_);
6737 ASSERT_EQ(2u, rtp_parameters.codecs.size());
magjed509e4fe2016-11-18 01:34:11 -08006738 EXPECT_EQ(GetEngineCodec("VP8").ToCodecParameters(),
6739 rtp_parameters.codecs[0]);
6740 EXPECT_EQ(GetEngineCodec("VP9").ToCodecParameters(),
6741 rtp_parameters.codecs[1]);
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006742}
6743
johan073ece42016-08-26 02:59:47 -07006744#if defined(WEBRTC_USE_H264)
eladalonf1841382017-06-12 01:16:46 -07006745TEST_F(WebRtcVideoChannelTest, GetRtpReceiveFmtpSprop) {
johan073ece42016-08-26 02:59:47 -07006746#else
eladalonf1841382017-06-12 01:16:46 -07006747TEST_F(WebRtcVideoChannelTest, DISABLED_GetRtpReceiveFmtpSprop) {
johan073ece42016-08-26 02:59:47 -07006748#endif
johan3859c892016-08-05 09:19:25 -07006749 cricket::VideoRecvParameters parameters;
perkj26752742016-10-24 01:21:16 -07006750 cricket::VideoCodec kH264sprop1(101, "H264");
magjed5dfac562016-11-25 03:56:37 -08006751 kH264sprop1.SetParam(kH264FmtpSpropParameterSets, "uvw");
johan3859c892016-08-05 09:19:25 -07006752 parameters.codecs.push_back(kH264sprop1);
perkj26752742016-10-24 01:21:16 -07006753 cricket::VideoCodec kH264sprop2(102, "H264");
magjed5dfac562016-11-25 03:56:37 -08006754 kH264sprop2.SetParam(kH264FmtpSpropParameterSets, "xyz");
johan3859c892016-08-05 09:19:25 -07006755 parameters.codecs.push_back(kH264sprop2);
6756 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6757
6758 FakeVideoReceiveStream* recv_stream = AddRecvStream();
6759 const webrtc::VideoReceiveStream::Config& cfg = recv_stream->GetConfig();
6760 webrtc::RtpParameters rtp_parameters =
6761 channel_->GetRtpReceiveParameters(last_ssrc_);
6762 ASSERT_EQ(2u, rtp_parameters.codecs.size());
6763 EXPECT_EQ(kH264sprop1.ToCodecParameters(), rtp_parameters.codecs[0]);
6764 ASSERT_EQ(2u, cfg.decoders.size());
6765 EXPECT_EQ(101, cfg.decoders[0].payload_type);
Niels Möllercb7e1d22018-09-11 15:56:04 +02006766 EXPECT_EQ("H264", cfg.decoders[0].video_format.name);
magjed5dfac562016-11-25 03:56:37 -08006767 const auto it0 =
Niels Möllercb7e1d22018-09-11 15:56:04 +02006768 cfg.decoders[0].video_format.parameters.find(kH264FmtpSpropParameterSets);
6769 ASSERT_TRUE(it0 != cfg.decoders[0].video_format.parameters.end());
magjed5dfac562016-11-25 03:56:37 -08006770 EXPECT_EQ("uvw", it0->second);
johan3859c892016-08-05 09:19:25 -07006771
6772 EXPECT_EQ(102, cfg.decoders[1].payload_type);
Niels Möllercb7e1d22018-09-11 15:56:04 +02006773 EXPECT_EQ("H264", cfg.decoders[1].video_format.name);
magjed5dfac562016-11-25 03:56:37 -08006774 const auto it1 =
Niels Möllercb7e1d22018-09-11 15:56:04 +02006775 cfg.decoders[1].video_format.parameters.find(kH264FmtpSpropParameterSets);
6776 ASSERT_TRUE(it1 != cfg.decoders[1].video_format.parameters.end());
magjed5dfac562016-11-25 03:56:37 -08006777 EXPECT_EQ("xyz", it1->second);
johan3859c892016-08-05 09:19:25 -07006778}
6779
sakal1fd95952016-06-22 00:46:15 -07006780// Test that RtpParameters for receive stream has one encoding and it has
6781// the correct SSRC.
eladalonf1841382017-06-12 01:16:46 -07006782TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersSsrc) {
sakal1fd95952016-06-22 00:46:15 -07006783 AddRecvStream();
6784
6785 webrtc::RtpParameters rtp_parameters =
6786 channel_->GetRtpReceiveParameters(last_ssrc_);
6787 ASSERT_EQ(1u, rtp_parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01006788 EXPECT_EQ(last_ssrc_, rtp_parameters.encodings[0].ssrc);
sakal1fd95952016-06-22 00:46:15 -07006789}
6790
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006791// Test that if we set/get parameters multiple times, we get the same results.
eladalonf1841382017-06-12 01:16:46 -07006792TEST_F(WebRtcVideoChannelTest, SetAndGetRtpReceiveParameters) {
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006793 AddRecvStream();
6794 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006795 parameters.codecs.push_back(GetEngineCodec("VP8"));
6796 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006797 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6798
6799 webrtc::RtpParameters initial_params =
6800 channel_->GetRtpReceiveParameters(last_ssrc_);
6801
6802 // We should be able to set the params we just got.
6803 EXPECT_TRUE(channel_->SetRtpReceiveParameters(last_ssrc_, initial_params));
6804
6805 // ... And this shouldn't change the params returned by
6806 // GetRtpReceiveParameters.
6807 EXPECT_EQ(initial_params, channel_->GetRtpReceiveParameters(last_ssrc_));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006808}
6809
deadbeef3bc15102017-04-20 19:25:07 -07006810// Test that GetRtpReceiveParameters returns parameters correctly when SSRCs
6811// aren't signaled. It should always return an empty "RtpEncodingParameters",
6812// even after a packet is received and the unsignaled SSRC is known.
eladalonf1841382017-06-12 01:16:46 -07006813TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersWithUnsignaledSsrc) {
deadbeef3bc15102017-04-20 19:25:07 -07006814 // Call necessary methods to configure receiving a default stream as
6815 // soon as it arrives.
6816 cricket::VideoRecvParameters parameters;
6817 parameters.codecs.push_back(GetEngineCodec("VP8"));
6818 parameters.codecs.push_back(GetEngineCodec("VP9"));
6819 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6820
6821 // Call GetRtpReceiveParameters before configured to receive an unsignaled
6822 // stream. Should return nothing.
6823 EXPECT_EQ(webrtc::RtpParameters(), channel_->GetRtpReceiveParameters(0));
6824
6825 // Set a sink for an unsignaled stream.
6826 cricket::FakeVideoRenderer renderer;
6827 // Value of "0" means "unsignaled stream".
6828 EXPECT_TRUE(channel_->SetSink(0, &renderer));
6829
6830 // Call GetRtpReceiveParameters before the SSRC is known. Value of "0"
6831 // in this method means "unsignaled stream".
6832 webrtc::RtpParameters rtp_parameters = channel_->GetRtpReceiveParameters(0);
6833 ASSERT_EQ(1u, rtp_parameters.encodings.size());
6834 EXPECT_FALSE(rtp_parameters.encodings[0].ssrc);
6835
6836 // Receive VP8 packet.
6837 uint8_t data[kMinRtpPacketLen];
6838 cricket::RtpHeader rtpHeader;
6839 rtpHeader.payload_type = GetEngineCodec("VP8").id;
6840 rtpHeader.seq_num = rtpHeader.timestamp = 0;
6841 rtpHeader.ssrc = kIncomingUnsignalledSsrc;
6842 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
6843 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
Niels Möllere6933812018-11-05 13:01:41 +01006844 channel_->OnPacketReceived(&packet, /* packet_time_us */ -1);
deadbeef3bc15102017-04-20 19:25:07 -07006845
6846 // The |ssrc| member should still be unset.
6847 rtp_parameters = channel_->GetRtpReceiveParameters(0);
6848 ASSERT_EQ(1u, rtp_parameters.encodings.size());
6849 EXPECT_FALSE(rtp_parameters.encodings[0].ssrc);
6850}
6851
eladalonf1841382017-06-12 01:16:46 -07006852void WebRtcVideoChannelTest::TestReceiverLocalSsrcConfiguration(
Peter Boström3548dd22015-05-22 18:48:36 +02006853 bool receiver_first) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02006854 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boström3548dd22015-05-22 18:48:36 +02006855
6856 const uint32_t kSenderSsrc = 0xC0FFEE;
Peter Boströmdfa28152015-10-21 17:21:10 +02006857 const uint32_t kSecondSenderSsrc = 0xBADCAFE;
Peter Boström3548dd22015-05-22 18:48:36 +02006858 const uint32_t kReceiverSsrc = 0x4711;
Peter Boströmdfa28152015-10-21 17:21:10 +02006859 const uint32_t kExpectedDefaultReceiverSsrc = 1;
Peter Boström3548dd22015-05-22 18:48:36 +02006860
6861 if (receiver_first) {
6862 AddRecvStream(StreamParams::CreateLegacy(kReceiverSsrc));
6863 std::vector<FakeVideoReceiveStream*> receive_streams =
6864 fake_call_->GetVideoReceiveStreams();
6865 ASSERT_EQ(1u, receive_streams.size());
Peter Boströmdfa28152015-10-21 17:21:10 +02006866 // Default local SSRC when we have no sender.
6867 EXPECT_EQ(kExpectedDefaultReceiverSsrc,
6868 receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boström3548dd22015-05-22 18:48:36 +02006869 }
6870 AddSendStream(StreamParams::CreateLegacy(kSenderSsrc));
6871 if (!receiver_first)
6872 AddRecvStream(StreamParams::CreateLegacy(kReceiverSsrc));
6873 std::vector<FakeVideoReceiveStream*> receive_streams =
6874 fake_call_->GetVideoReceiveStreams();
6875 ASSERT_EQ(1u, receive_streams.size());
6876 EXPECT_EQ(kSenderSsrc, receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boströmdfa28152015-10-21 17:21:10 +02006877
6878 // Removing first sender should fall back to another (in this case the second)
6879 // local send stream's SSRC.
6880 AddSendStream(StreamParams::CreateLegacy(kSecondSenderSsrc));
6881 ASSERT_TRUE(channel_->RemoveSendStream(kSenderSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02006882 receive_streams = fake_call_->GetVideoReceiveStreams();
Peter Boströmdfa28152015-10-21 17:21:10 +02006883 ASSERT_EQ(1u, receive_streams.size());
6884 EXPECT_EQ(kSecondSenderSsrc, receive_streams[0]->GetConfig().rtp.local_ssrc);
6885
6886 // Removing the last sender should fall back to default local SSRC.
6887 ASSERT_TRUE(channel_->RemoveSendStream(kSecondSenderSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02006888 receive_streams = fake_call_->GetVideoReceiveStreams();
Peter Boströmdfa28152015-10-21 17:21:10 +02006889 ASSERT_EQ(1u, receive_streams.size());
6890 EXPECT_EQ(kExpectedDefaultReceiverSsrc,
6891 receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boström3548dd22015-05-22 18:48:36 +02006892}
6893
eladalonf1841382017-06-12 01:16:46 -07006894TEST_F(WebRtcVideoChannelTest, ConfiguresLocalSsrc) {
Peter Boström3548dd22015-05-22 18:48:36 +02006895 TestReceiverLocalSsrcConfiguration(false);
6896}
6897
eladalonf1841382017-06-12 01:16:46 -07006898TEST_F(WebRtcVideoChannelTest, ConfiguresLocalSsrcOnExistingReceivers) {
Peter Boström3548dd22015-05-22 18:48:36 +02006899 TestReceiverLocalSsrcConfiguration(true);
6900}
6901
eladalonf1841382017-06-12 01:16:46 -07006902class WebRtcVideoChannelSimulcastTest : public testing::Test {
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006903 public:
eladalonf1841382017-06-12 01:16:46 -07006904 WebRtcVideoChannelSimulcastTest()
Sebastian Jansson8f83b422018-02-21 13:07:13 +01006905 : fake_call_(),
Magnus Jedvert02e7a192017-09-23 17:21:32 +02006906 encoder_factory_(new cricket::FakeWebRtcVideoEncoderFactory),
6907 decoder_factory_(new cricket::FakeWebRtcVideoDecoderFactory),
Jiawei Ouc2ebe212018-11-08 10:02:56 -08006908 mock_rate_allocator_factory_(
6909 new webrtc::MockVideoBitrateAllocatorFactory),
Anders Carlsson67537952018-05-03 11:28:29 +02006910 engine_(std::unique_ptr<cricket::FakeWebRtcVideoEncoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +02006911 encoder_factory_),
Anders Carlsson67537952018-05-03 11:28:29 +02006912 std::unique_ptr<cricket::FakeWebRtcVideoDecoderFactory>(
Jiawei Ouc2ebe212018-11-08 10:02:56 -08006913 decoder_factory_),
6914 std::unique_ptr<webrtc::VideoBitrateAllocatorFactory>(
6915 mock_rate_allocator_factory_)),
magjed2475ae22017-09-12 04:42:15 -07006916 last_ssrc_(0) {}
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006917
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00006918 void SetUp() override {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02006919 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson84848f22018-11-16 10:40:36 +01006920 channel_.reset(engine_.CreateMediaChannel(&fake_call_, GetMediaConfig(),
6921 VideoOptions(),
6922 webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08006923 channel_->OnReadyToSend(true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006924 last_ssrc_ = 123;
6925 }
6926
6927 protected:
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006928 void VerifySimulcastSettings(const VideoCodec& codec,
perkj26752742016-10-24 01:21:16 -07006929 int capture_width,
6930 int capture_height,
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006931 size_t num_configured_streams,
sprang429600d2017-01-26 06:12:26 -08006932 size_t expected_num_streams,
6933 bool screenshare,
6934 bool conference_mode) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02006935 cricket::VideoSendParameters parameters;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02006936 parameters.codecs.push_back(codec);
sprang429600d2017-01-26 06:12:26 -08006937 parameters.conference_mode = conference_mode;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02006938 ASSERT_TRUE(channel_->SetSendParameters(parameters));
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006939
Peter Boström0c4e06b2015-10-07 12:23:21 +02006940 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
henrikg91d6ede2015-09-17 00:24:34 -07006941 RTC_DCHECK(num_configured_streams <= ssrcs.size());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006942 ssrcs.resize(num_configured_streams);
6943
sprangf24a0642017-02-28 13:23:26 -08006944 AddSendStream(CreateSimStreamParams("cname", ssrcs));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00006945 // Send a full-size frame to trigger a stream reconfiguration to use all
6946 // expected simulcast layers.
Niels Möller805a27e2019-01-21 12:21:27 +01006947 webrtc::test::FrameForwarder frame_forwarder;
6948 cricket::FakeFrameSource frame_source(capture_width, capture_height,
6949 rtc::kNumMicrosecsPerSec / 30);
6950
sprangf24a0642017-02-28 13:23:26 -08006951 VideoOptions options;
6952 if (screenshare)
Oskar Sundbom78807582017-11-16 11:09:55 +01006953 options.is_screencast = screenshare;
Niels Möller805a27e2019-01-21 12:21:27 +01006954 EXPECT_TRUE(
6955 channel_->SetVideoSend(ssrcs.front(), &options, &frame_forwarder));
sprangf24a0642017-02-28 13:23:26 -08006956 // Fetch the latest stream since SetVideoSend() may recreate it if the
6957 // screen content setting is changed.
6958 FakeVideoSendStream* stream = fake_call_.GetVideoSendStreams().front();
pbos@webrtc.org86196c42015-02-16 21:02:00 +00006959 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006960 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006961
Zach Stein3ca452b2018-01-18 10:01:24 -08006962 auto rtp_parameters = channel_->GetRtpSendParameters(kSsrcs3[0]);
6963 EXPECT_EQ(num_configured_streams, rtp_parameters.encodings.size());
6964
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006965 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6966 ASSERT_EQ(expected_num_streams, video_streams.size());
6967
sprang429600d2017-01-26 06:12:26 -08006968 std::vector<webrtc::VideoStream> expected_streams;
6969 if (conference_mode) {
6970 expected_streams = GetSimulcastConfig(
6971 num_configured_streams, capture_width, capture_height, 0,
Seth Hampson24722b32017-12-22 09:36:42 -08006972 webrtc::kDefaultBitratePriority, kDefaultQpMax,
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +02006973 kDefaultVideoMaxFramerate, screenshare, true);
sprang3ebabf12017-02-16 07:35:22 -08006974 if (screenshare) {
6975 for (const webrtc::VideoStream& stream : expected_streams) {
6976 // Never scale screen content.
Danil Chapovalov350531e2018-06-08 11:04:04 +00006977 EXPECT_EQ(stream.width, rtc::checked_cast<size_t>(capture_width));
6978 EXPECT_EQ(stream.height, rtc::checked_cast<size_t>(capture_height));
sprang3ebabf12017-02-16 07:35:22 -08006979 }
6980 }
sprang429600d2017-01-26 06:12:26 -08006981 } else {
6982 webrtc::VideoStream stream;
6983 stream.width = capture_width;
6984 stream.height = capture_height;
6985 stream.max_framerate = kDefaultVideoMaxFramerate;
Åsa Persson45bbc8a2017-11-13 10:16:47 +01006986 stream.min_bitrate_bps = cricket::kMinVideoBitrateBps;
sprang429600d2017-01-26 06:12:26 -08006987 stream.target_bitrate_bps = stream.max_bitrate_bps =
Åsa Perssonbdee46d2018-06-25 11:28:06 +02006988 GetMaxDefaultBitrateBps(capture_width, capture_height);
sprang429600d2017-01-26 06:12:26 -08006989 stream.max_qp = kDefaultQpMax;
6990 expected_streams.push_back(stream);
6991 }
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006992
6993 ASSERT_EQ(expected_streams.size(), video_streams.size());
6994
6995 size_t num_streams = video_streams.size();
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00006996 int total_max_bitrate_bps = 0;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006997 for (size_t i = 0; i < num_streams; ++i) {
6998 EXPECT_EQ(expected_streams[i].width, video_streams[i].width);
6999 EXPECT_EQ(expected_streams[i].height, video_streams[i].height);
7000
7001 EXPECT_GT(video_streams[i].max_framerate, 0);
7002 EXPECT_EQ(expected_streams[i].max_framerate,
7003 video_streams[i].max_framerate);
7004
7005 EXPECT_GT(video_streams[i].min_bitrate_bps, 0);
7006 EXPECT_EQ(expected_streams[i].min_bitrate_bps,
7007 video_streams[i].min_bitrate_bps);
7008
7009 EXPECT_GT(video_streams[i].target_bitrate_bps, 0);
7010 EXPECT_EQ(expected_streams[i].target_bitrate_bps,
7011 video_streams[i].target_bitrate_bps);
7012
7013 EXPECT_GT(video_streams[i].max_bitrate_bps, 0);
7014 EXPECT_EQ(expected_streams[i].max_bitrate_bps,
7015 video_streams[i].max_bitrate_bps);
7016
7017 EXPECT_GT(video_streams[i].max_qp, 0);
7018 EXPECT_EQ(expected_streams[i].max_qp, video_streams[i].max_qp);
7019
Sergey Silkina796a7e2018-03-01 15:11:29 +01007020 EXPECT_EQ(conference_mode,
7021 expected_streams[i].num_temporal_layers.has_value());
7022
7023 if (conference_mode) {
7024 EXPECT_EQ(expected_streams[i].num_temporal_layers,
7025 video_streams[i].num_temporal_layers);
7026 }
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00007027
7028 if (i == num_streams - 1) {
7029 total_max_bitrate_bps += video_streams[i].max_bitrate_bps;
7030 } else {
7031 total_max_bitrate_bps += video_streams[i].target_bitrate_bps;
7032 }
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007033 }
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00007034
Niels Möllerff40b142018-04-09 08:49:14 +02007035 EXPECT_TRUE(channel_->SetVideoSend(ssrcs.front(), nullptr, nullptr));
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007036 }
7037
7038 FakeVideoSendStream* AddSendStream() {
7039 return AddSendStream(StreamParams::CreateLegacy(last_ssrc_++));
7040 }
7041
7042 FakeVideoSendStream* AddSendStream(const StreamParams& sp) {
Yves Gerey665174f2018-06-19 15:03:05 +02007043 size_t num_streams = fake_call_.GetVideoSendStreams().size();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007044 EXPECT_TRUE(channel_->AddSendStream(sp));
7045 std::vector<FakeVideoSendStream*> streams =
Fredrik Solenberg709ed672015-09-15 12:26:33 +02007046 fake_call_.GetVideoSendStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007047 EXPECT_EQ(num_streams + 1, streams.size());
7048 return streams[streams.size() - 1];
7049 }
7050
7051 std::vector<FakeVideoSendStream*> GetFakeSendStreams() {
Fredrik Solenberg709ed672015-09-15 12:26:33 +02007052 return fake_call_.GetVideoSendStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007053 }
7054
7055 FakeVideoReceiveStream* AddRecvStream() {
7056 return AddRecvStream(StreamParams::CreateLegacy(last_ssrc_++));
7057 }
7058
7059 FakeVideoReceiveStream* AddRecvStream(const StreamParams& sp) {
Yves Gerey665174f2018-06-19 15:03:05 +02007060 size_t num_streams = fake_call_.GetVideoReceiveStreams().size();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007061 EXPECT_TRUE(channel_->AddRecvStream(sp));
7062 std::vector<FakeVideoReceiveStream*> streams =
Fredrik Solenberg709ed672015-09-15 12:26:33 +02007063 fake_call_.GetVideoReceiveStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007064 EXPECT_EQ(num_streams + 1, streams.size());
7065 return streams[streams.size() - 1];
7066 }
7067
skvlad11a9cbf2016-10-07 11:53:05 -07007068 webrtc::RtcEventLogNullImpl event_log_;
Fredrik Solenberg709ed672015-09-15 12:26:33 +02007069 FakeCall fake_call_;
Magnus Jedvert02e7a192017-09-23 17:21:32 +02007070 cricket::FakeWebRtcVideoEncoderFactory* encoder_factory_;
7071 cricket::FakeWebRtcVideoDecoderFactory* decoder_factory_;
Jiawei Ouc2ebe212018-11-08 10:02:56 -08007072 webrtc::MockVideoBitrateAllocatorFactory* mock_rate_allocator_factory_;
eladalonf1841382017-06-12 01:16:46 -07007073 WebRtcVideoEngine engine_;
kwiberg686a8ef2016-02-26 03:00:35 -08007074 std::unique_ptr<VideoMediaChannel> channel_;
Peter Boström0c4e06b2015-10-07 12:23:21 +02007075 uint32_t last_ssrc_;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007076};
7077
eladalonf1841382017-06-12 01:16:46 -07007078TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWith2SimulcastStreams) {
sprang429600d2017-01-26 06:12:26 -08007079 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 640, 360, 2, 2, false,
7080 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007081}
7082
eladalonf1841382017-06-12 01:16:46 -07007083TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWith3SimulcastStreams) {
sprang429600d2017-01-26 06:12:26 -08007084 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 3, false,
7085 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007086}
7087
7088// Test that we normalize send codec format size in simulcast.
eladalonf1841382017-06-12 01:16:46 -07007089TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWithOddSizeInSimulcast) {
sprang429600d2017-01-26 06:12:26 -08007090 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 541, 271, 2, 2, false,
7091 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007092}
sprang429600d2017-01-26 06:12:26 -08007093
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02007094TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsForScreenshare) {
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02007095 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
7096 false);
7097}
7098
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02007099TEST_F(WebRtcVideoChannelSimulcastTest,
7100 SetSendCodecsForConferenceModeScreenshare) {
Erik Språng72e52ee2018-11-29 11:41:53 +01007101 webrtc::test::ScopedFieldTrials field_trials(
7102 "WebRTC-SimulcastScreenshare/Disabled/");
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02007103 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
7104 true);
7105}
7106
eladalonf1841382017-06-12 01:16:46 -07007107TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsForSimulcastScreenshare) {
sprang429600d2017-01-26 06:12:26 -08007108 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 2, true,
7109 true);
7110}
7111
eladalonf1841382017-06-12 01:16:46 -07007112TEST_F(WebRtcVideoChannelSimulcastTest,
sprangfe627f32017-03-29 08:24:59 -07007113 NoSimulcastScreenshareWithoutConference) {
sprangfe627f32017-03-29 08:24:59 -07007114 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
7115 false);
7116}
7117
Yves Gereyb6a89422018-10-08 10:08:32 +02007118class WebRtcVideoFakeClock {
Jonas Oreland49ac5952018-09-26 16:04:32 +02007119 public:
Yves Gereyb6a89422018-10-08 10:08:32 +02007120 WebRtcVideoFakeClock() {
Jonas Oreland49ac5952018-09-26 16:04:32 +02007121 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(1)); // avoid time=0
7122 }
7123 rtc::ScopedFakeClock fake_clock_;
7124};
7125
Yves Gereyb6a89422018-10-08 10:08:32 +02007126// The fake clock needs to be initialized before the call, and not
7127// destroyed until after all threads spawned by the test have been stopped.
7128// This mixin ensures that.
7129class WebRtcVideoChannelTestWithClock : public WebRtcVideoFakeClock,
7130 public WebRtcVideoChannelBaseTest {};
7131
Jonas Oreland49ac5952018-09-26 16:04:32 +02007132TEST_F(WebRtcVideoChannelTestWithClock, GetSources) {
7133 uint8_t data1[] = {0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
7134 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
7135
7136 EXPECT_EQ(0u, channel_->GetSources(kSsrc).size());
7137
7138 rtc::CopyOnWriteBuffer packet1(data1, sizeof(data1));
7139 rtc::SetBE32(packet1.data() + 8, kSsrc);
7140 channel_->SetSink(kDefaultReceiveSsrc, NULL);
7141 EXPECT_TRUE(SetDefaultCodec());
7142 EXPECT_TRUE(SetSend(true));
7143 EXPECT_EQ(0, renderer_.num_rendered_frames());
Niels Möller29e13fd2018-12-17 12:35:30 +01007144 channel_->OnPacketReceived(&packet1, /*packet_time_us=*/-1);
Jonas Oreland49ac5952018-09-26 16:04:32 +02007145
7146 std::vector<webrtc::RtpSource> sources = channel_->GetSources(kSsrc);
7147 EXPECT_EQ(1u, sources.size());
7148 EXPECT_EQ(webrtc::RtpSourceType::SSRC, sources[0].source_type());
7149 int64_t timestamp1 = sources[0].timestamp_ms();
7150
7151 // a new packet.
7152 int64_t timeDeltaMs = 1;
7153 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(timeDeltaMs));
Niels Möller29e13fd2018-12-17 12:35:30 +01007154 channel_->OnPacketReceived(&packet1, /*packet_time_us=*/-1);
Jonas Oreland49ac5952018-09-26 16:04:32 +02007155 int64_t timestamp2 = channel_->GetSources(kSsrc)[0].timestamp_ms();
7156 EXPECT_EQ(timestamp2, timestamp1 + timeDeltaMs);
7157
7158 // It only keeps 10s of history.
7159 fake_clock_.AdvanceTime(webrtc::TimeDelta::seconds(10));
7160 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(1));
7161 EXPECT_EQ(0u, channel_->GetSources(kSsrc).size());
7162}
7163
7164TEST_F(WebRtcVideoChannelTestWithClock, GetContributingSources) {
7165 uint8_t data1[] = {0x81, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
7166 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
7167
7168 uint32_t kCsrc = 4321u;
7169 EXPECT_EQ(0u, channel_->GetSources(kSsrc).size());
7170 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7171
7172 rtc::CopyOnWriteBuffer packet1(data1, sizeof(data1));
7173 rtc::SetBE32(packet1.data() + 8, kSsrc);
7174 rtc::SetBE32(packet1.data() + 12, kCsrc);
7175 channel_->SetSink(kDefaultReceiveSsrc, NULL);
7176 EXPECT_TRUE(SetDefaultCodec());
7177 EXPECT_TRUE(SetSend(true));
7178 EXPECT_EQ(0, renderer_.num_rendered_frames());
Niels Möller29e13fd2018-12-17 12:35:30 +01007179 channel_->OnPacketReceived(&packet1, /*packet_time_us=*/-1);
Jonas Oreland49ac5952018-09-26 16:04:32 +02007180
7181 {
7182 ASSERT_EQ(2u, channel_->GetSources(kSsrc).size());
7183 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7184 std::vector<webrtc::RtpSource> sources = channel_->GetSources(kSsrc);
7185 EXPECT_EQ(sources[0].timestamp_ms(), sources[1].timestamp_ms());
7186 // 1 SSRC and 1 CSRC.
Steve Anton2c9ebef2019-01-28 17:27:58 -08007187 EXPECT_EQ(1, absl::c_count_if(sources, [](const webrtc::RtpSource& source) {
7188 return source.source_type() == webrtc::RtpSourceType::SSRC;
7189 }));
7190 EXPECT_EQ(1, absl::c_count_if(sources, [](const webrtc::RtpSource& source) {
7191 return source.source_type() == webrtc::RtpSourceType::CSRC;
7192 }));
Jonas Oreland49ac5952018-09-26 16:04:32 +02007193 }
7194 int64_t timestamp1 = channel_->GetSources(kSsrc)[0].timestamp_ms();
7195
7196 // a new packet with only ssrc (i.e no csrc).
7197 uint8_t data2[] = {0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
7198 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
7199 rtc::CopyOnWriteBuffer packet2(data2, sizeof(data2));
7200 rtc::SetBE32(packet2.data() + 8, kSsrc);
7201
7202 int64_t timeDeltaMs = 1;
7203 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(timeDeltaMs));
Niels Möller29e13fd2018-12-17 12:35:30 +01007204 channel_->OnPacketReceived(&packet2, /*packet_time_us=*/-1);
Jonas Oreland49ac5952018-09-26 16:04:32 +02007205
7206 {
7207 ASSERT_EQ(2u, channel_->GetSources(kSsrc).size());
7208 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7209 std::vector<webrtc::RtpSource> sources = channel_->GetSources(kSsrc);
7210 EXPECT_NE(sources[0].timestamp_ms(), sources[1].timestamp_ms());
7211 // 1 SSRC and 1 CSRC.
Steve Anton2c9ebef2019-01-28 17:27:58 -08007212 EXPECT_EQ(1, absl::c_count_if(sources, [](const webrtc::RtpSource& source) {
7213 return source.source_type() == webrtc::RtpSourceType::SSRC;
7214 }));
7215 EXPECT_EQ(1, absl::c_count_if(sources, [](const webrtc::RtpSource& source) {
7216 return source.source_type() == webrtc::RtpSourceType::CSRC;
7217 }));
7218 auto ssrcSource =
7219 absl::c_find_if(sources, [](const webrtc::RtpSource& source) {
Jonas Oreland49ac5952018-09-26 16:04:32 +02007220 return source.source_type() == webrtc::RtpSourceType::SSRC;
7221 });
Steve Anton2c9ebef2019-01-28 17:27:58 -08007222 auto csrcSource =
7223 absl::c_find_if(sources, [](const webrtc::RtpSource& source) {
Jonas Oreland49ac5952018-09-26 16:04:32 +02007224 return source.source_type() == webrtc::RtpSourceType::CSRC;
7225 });
7226
7227 EXPECT_EQ(ssrcSource->timestamp_ms(), timestamp1 + timeDeltaMs);
7228 EXPECT_EQ(csrcSource->timestamp_ms(), timestamp1);
7229 }
7230
7231 // It only keeps 10s of history.
7232 fake_clock_.AdvanceTime(webrtc::TimeDelta::seconds(10));
7233
7234 {
7235 ASSERT_EQ(1u, channel_->GetSources(kSsrc).size());
7236 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7237 std::vector<webrtc::RtpSource> sources = channel_->GetSources(kSsrc);
Steve Anton2c9ebef2019-01-28 17:27:58 -08007238 EXPECT_EQ(1, absl::c_count_if(sources, [](const webrtc::RtpSource& source) {
7239 return source.source_type() == webrtc::RtpSourceType::SSRC;
7240 }));
7241 EXPECT_EQ(0, absl::c_count_if(sources, [](const webrtc::RtpSource& source) {
7242 return source.source_type() == webrtc::RtpSourceType::CSRC;
7243 }));
Jonas Oreland49ac5952018-09-26 16:04:32 +02007244 }
7245
7246 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(1));
7247 EXPECT_EQ(0u, channel_->GetSources(kSsrc).size());
7248 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7249}
7250
Amit Hilbuchb000b712019-02-25 10:22:14 -08007251TEST_F(WebRtcVideoChannelTest, SetsRidsOnSendStream) {
7252 StreamParams sp = CreateSimStreamParams("cname", {123, 456, 789});
7253
7254 std::vector<std::string> rids = {"f", "h", "q"};
7255 std::vector<cricket::RidDescription> rid_descriptions;
7256 for (const auto& rid : rids) {
7257 rid_descriptions.emplace_back(rid, cricket::RidDirection::kSend);
7258 }
7259 sp.set_rids(rid_descriptions);
7260
7261 ASSERT_TRUE(channel_->AddSendStream(sp));
7262 const auto& streams = fake_call_->GetVideoSendStreams();
7263 ASSERT_EQ(1u, streams.size());
7264 auto stream = streams[0];
7265 ASSERT_NE(stream, nullptr);
7266 const auto& config = stream->GetConfig();
7267 EXPECT_THAT(config.rtp.rids, ::testing::ElementsAreArray(rids));
7268}
7269
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00007270} // namespace cricket