blob: 14b42322367d32edf7ec58b758c005a2587e34fe [file] [log] [blame]
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001/*
kjellander1afca732016-02-07 20:46:45 -08002 * Copyright (c) 2004 The WebRTC project authors. All Rights Reserved.
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003 *
kjellander1afca732016-02-07 20:46:45 -08004 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00009 */
10
11#include <map>
kwiberg686a8ef2016-02-26 03:00:35 -080012#include <memory>
Steve Antone78bcb92017-10-31 09:53:08 -070013#include <utility>
pbos@webrtc.org86f613d2014-06-10 08:53:05 +000014#include <vector>
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000015
Steve Anton2c9ebef2019-01-28 17:27:58 -080016#include "absl/algorithm/container.h"
Niels Möller805a27e2019-01-21 12:21:27 +010017#include "absl/memory/memory.h"
Niels Möller039743e2018-10-23 10:07:25 +020018#include "absl/strings/match.h"
Steve Anton10542f22019-01-11 09:11:00 -080019#include "api/rtp_parameters.h"
Jiawei Ouc2ebe212018-11-08 10:02:56 -080020#include "api/test/mock_video_bitrate_allocator.h"
21#include "api/test/mock_video_bitrate_allocator_factory.h"
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -070022#include "api/test/mock_video_decoder_factory.h"
23#include "api/test/mock_video_encoder_factory.h"
Jonas Oreland49ac5952018-09-26 16:04:32 +020024#include "api/units/time_delta.h"
Jiawei Ouc2ebe212018-11-08 10:02:56 -080025#include "api/video/builtin_video_bitrate_allocator_factory.h"
Niels Möller805a27e2019-01-21 12:21:27 +010026#include "api/video/i420_buffer.h"
Åsa Persson23eba222018-10-02 14:47:06 +020027#include "api/video/video_bitrate_allocation.h"
Anders Carlsson5f2bb622018-05-14 09:48:06 +020028#include "api/video_codecs/builtin_video_decoder_factory.h"
29#include "api/video_codecs/builtin_video_encoder_factory.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020030#include "api/video_codecs/sdp_video_format.h"
31#include "api/video_codecs/video_decoder_factory.h"
32#include "api/video_codecs/video_encoder.h"
33#include "api/video_codecs/video_encoder_factory.h"
34#include "call/flexfec_receive_stream.h"
35#include "common_video/h264/profile_level_id.h"
36#include "logging/rtc_event_log/rtc_event_log.h"
Niels Möller805a27e2019-01-21 12:21:27 +010037#include "media/base/fake_frame_source.h"
Steve Anton10542f22019-01-11 09:11:00 -080038#include "media/base/fake_network_interface.h"
Steve Anton10542f22019-01-11 09:11:00 -080039#include "media/base/fake_video_renderer.h"
40#include "media/base/media_constants.h"
41#include "media/base/rtp_utils.h"
42#include "media/base/test_utils.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020043#include "media/engine/constants.h"
Steve Anton10542f22019-01-11 09:11:00 -080044#include "media/engine/fake_webrtc_call.h"
45#include "media/engine/fake_webrtc_video_engine.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020046#include "media/engine/simulcast.h"
Steve Anton10542f22019-01-11 09:11:00 -080047#include "media/engine/webrtc_video_engine.h"
48#include "media/engine/webrtc_voice_engine.h"
Åsa Persson23cd45a2018-07-03 10:40:40 +020049#include "modules/rtp_rtcp/include/rtp_header_parser.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020050#include "rtc_base/arraysize.h"
Steve Anton10542f22019-01-11 09:11:00 -080051#include "rtc_base/fake_clock.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020052#include "rtc_base/gunit.h"
Yves Gerey665174f2018-06-19 15:03:05 +020053#include "rtc_base/numerics/safe_conversions.h"
Steve Antonf3802842019-01-24 19:07:40 -080054#include "rtc_base/time_utils.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020055#include "test/field_trial.h"
Niels Möllerd0f0f682019-01-14 09:09:53 +010056#include "test/frame_generator.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020057#include "test/gmock.h"
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000058
Niels Möller805a27e2019-01-21 12:21:27 +010059using testing::Field;
Sebastian Jansson8f83b422018-02-21 13:07:13 +010060using webrtc::BitrateConstraints;
isheriff6f8d6862016-05-26 11:24:55 -070061using webrtc::RtpExtension;
62
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000063namespace {
buildbot@webrtc.orga8530772014-12-10 09:01:18 +000064static const int kDefaultQpMax = 56;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +000065
noahricd10a68e2015-07-10 11:27:55 -070066static const uint8_t kRedRtxPayloadType = 125;
67
Niels Möller6557d0c2018-04-11 15:18:34 +020068static const uint32_t kTimeout = 5000U;
69static const uint32_t kDefaultReceiveSsrc = 0;
70static const uint32_t kSsrc = 1234u;
71static const uint32_t kSsrcs4[] = {1, 2, 3, 4};
72static const int kVideoWidth = 640;
73static const int kVideoHeight = 360;
74static const int kFramerate = 30;
75
Peter Boström0c4e06b2015-10-07 12:23:21 +020076static const uint32_t kSsrcs1[] = {1};
77static const uint32_t kSsrcs3[] = {1, 2, 3};
78static const uint32_t kRtxSsrcs1[] = {4};
brandtr468da7c2016-11-22 02:16:47 -080079static const uint32_t kFlexfecSsrc = 5;
Peter Boström0c4e06b2015-10-07 12:23:21 +020080static const uint32_t kIncomingUnsignalledSsrc = 0xC0FFEE;
mzanaty8a855d62017-02-17 15:46:43 -080081static const uint32_t kDefaultRecvSsrc = 0;
82
pbos@webrtc.org3c107582014-07-20 15:27:35 +000083static const char kUnsupportedExtensionName[] =
84 "urn:ietf:params:rtp-hdrext:unsupported";
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000085
magjed509e4fe2016-11-18 01:34:11 -080086cricket::VideoCodec RemoveFeedbackParams(cricket::VideoCodec&& codec) {
87 codec.feedback_params = cricket::FeedbackParams();
Mirko Bonadei29a8d102018-04-25 23:58:26 +020088 return std::move(codec);
magjed509e4fe2016-11-18 01:34:11 -080089}
90
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000091void VerifyCodecHasDefaultFeedbackParams(const cricket::VideoCodec& codec) {
92 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
93 cricket::kRtcpFbParamNack, cricket::kParamValueEmpty)));
94 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
95 cricket::kRtcpFbParamNack, cricket::kRtcpFbNackParamPli)));
96 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
97 cricket::kRtcpFbParamRemb, cricket::kParamValueEmpty)));
98 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
stefan43edf0f2015-11-20 18:05:48 -080099 cricket::kRtcpFbParamTransportCc, cricket::kParamValueEmpty)));
100 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +0000101 cricket::kRtcpFbParamCcm, cricket::kRtcpFbCcmParamFir)));
102}
103
magjed725e4842016-11-16 00:48:13 -0800104// Return true if any codec in |codecs| is an RTX codec with associated payload
105// type |payload_type|.
106bool HasRtxCodec(const std::vector<cricket::VideoCodec>& codecs,
107 int payload_type) {
108 for (const cricket::VideoCodec& codec : codecs) {
109 int associated_payload_type;
Niels Möller039743e2018-10-23 10:07:25 +0200110 if (absl::EqualsIgnoreCase(codec.name.c_str(), "rtx") &&
magjed725e4842016-11-16 00:48:13 -0800111 codec.GetParam(cricket::kCodecParamAssociatedPayloadType,
112 &associated_payload_type) &&
113 associated_payload_type == payload_type) {
114 return true;
115 }
116 }
117 return false;
118}
119
nisseca5706d2017-09-11 02:32:16 -0700120// TODO(nisse): Duplicated in call.cc.
121const int* FindKeyByValue(const std::map<int, int>& m, int v) {
122 for (const auto& kv : m) {
123 if (kv.second == v)
124 return &kv.first;
125 }
126 return nullptr;
127}
128
Yves Gerey665174f2018-06-19 15:03:05 +0200129bool HasRtxReceiveAssociation(const webrtc::VideoReceiveStream::Config& config,
130 int payload_type) {
nisseca5706d2017-09-11 02:32:16 -0700131 return FindKeyByValue(config.rtp.rtx_associated_payload_types,
132 payload_type) != nullptr;
133}
134
135// Check that there's an Rtx payload type for each decoder.
136bool VerifyRtxReceiveAssociations(
137 const webrtc::VideoReceiveStream::Config& config) {
138 for (const auto& decoder : config.decoders) {
139 if (!HasRtxReceiveAssociation(config, decoder.payload_type))
140 return false;
141 }
142 return true;
143}
144
brandtrffc61182016-11-28 06:02:22 -0800145rtc::scoped_refptr<webrtc::VideoFrameBuffer> CreateBlackFrameBuffer(
nisse64ec8f82016-09-27 00:17:25 -0700146 int width,
147 int height) {
148 rtc::scoped_refptr<webrtc::I420Buffer> buffer =
149 webrtc::I420Buffer::Create(width, height);
nisseaf916892017-01-10 07:44:26 -0800150 webrtc::I420Buffer::SetBlack(buffer);
nisse64ec8f82016-09-27 00:17:25 -0700151 return buffer;
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +0000152}
153
Shao Changbine62202f2015-04-21 20:24:50 +0800154void VerifySendStreamHasRtxTypes(const webrtc::VideoSendStream::Config& config,
155 const std::map<int, int>& rtx_types) {
156 std::map<int, int>::const_iterator it;
Niels Möller259a4972018-04-05 15:36:51 +0200157 it = rtx_types.find(config.rtp.payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800158 EXPECT_TRUE(it != rtx_types.end() &&
159 it->second == config.rtp.rtx.payload_type);
160
brandtrb5f2c3f2016-10-04 23:28:39 -0700161 if (config.rtp.ulpfec.red_rtx_payload_type != -1) {
162 it = rtx_types.find(config.rtp.ulpfec.red_payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800163 EXPECT_TRUE(it != rtx_types.end() &&
brandtrb5f2c3f2016-10-04 23:28:39 -0700164 it->second == config.rtp.ulpfec.red_rtx_payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800165 }
166}
kthelgason2bc68642017-02-07 07:02:22 -0800167
168cricket::MediaConfig GetMediaConfig() {
169 cricket::MediaConfig media_config;
Niels Möller1d7ecd22018-01-18 15:25:12 +0100170 media_config.video.enable_cpu_adaptation = false;
kthelgason2bc68642017-02-07 07:02:22 -0800171 return media_config;
172}
nisse26e3abb2017-08-25 04:44:25 -0700173
Åsa Perssonbdee46d2018-06-25 11:28:06 +0200174// Values from GetMaxDefaultVideoBitrateKbps in webrtcvideoengine.cc.
175int GetMaxDefaultBitrateBps(size_t width, size_t height) {
176 if (width * height <= 320 * 240) {
177 return 600000;
178 } else if (width * height <= 640 * 480) {
179 return 1700000;
180 } else if (width * height <= 960 * 540) {
181 return 2000000;
182 } else {
183 return 2500000;
184 }
185}
186
Niels Möller731a2c22018-07-30 15:08:07 +0200187class MockVideoSource : public rtc::VideoSourceInterface<webrtc::VideoFrame> {
188 public:
189 MOCK_METHOD2(AddOrUpdateSink,
190 void(rtc::VideoSinkInterface<webrtc::VideoFrame>* sink,
191 const rtc::VideoSinkWants& wants));
192 MOCK_METHOD1(RemoveSink,
193 void(rtc::VideoSinkInterface<webrtc::VideoFrame>* sink));
194};
195
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000196} // namespace
197
Yves Gerey665174f2018-06-19 15:03:05 +0200198#define EXPECT_FRAME_WAIT(c, w, h, t) \
Niels Möller6557d0c2018-04-11 15:18:34 +0200199 EXPECT_EQ_WAIT((c), renderer_.num_rendered_frames(), (t)); \
Yves Gerey665174f2018-06-19 15:03:05 +0200200 EXPECT_EQ((w), renderer_.width()); \
201 EXPECT_EQ((h), renderer_.height()); \
Niels Möller6557d0c2018-04-11 15:18:34 +0200202 EXPECT_EQ(0, renderer_.errors());
203
Yves Gerey665174f2018-06-19 15:03:05 +0200204#define EXPECT_FRAME_ON_RENDERER_WAIT(r, c, w, h, t) \
Niels Möller6557d0c2018-04-11 15:18:34 +0200205 EXPECT_EQ_WAIT((c), (r).num_rendered_frames(), (t)); \
Yves Gerey665174f2018-06-19 15:03:05 +0200206 EXPECT_EQ((w), (r).width()); \
207 EXPECT_EQ((h), (r).height()); \
Niels Möller6557d0c2018-04-11 15:18:34 +0200208 EXPECT_EQ(0, (r).errors());
209
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000210namespace cricket {
eladalonf1841382017-06-12 01:16:46 -0700211class WebRtcVideoEngineTest : public ::testing::Test {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000212 public:
eladalonf1841382017-06-12 01:16:46 -0700213 WebRtcVideoEngineTest() : WebRtcVideoEngineTest("") {}
214 explicit WebRtcVideoEngineTest(const char* field_trials)
stefanc1aeaf02015-10-15 07:26:07 -0700215 : override_field_trials_(field_trials),
skvlad11a9cbf2016-10-07 11:53:05 -0700216 call_(webrtc::Call::Create(webrtc::Call::Config(&event_log_))),
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200217 encoder_factory_(new cricket::FakeWebRtcVideoEncoderFactory),
218 decoder_factory_(new cricket::FakeWebRtcVideoDecoderFactory),
Anders Carlsson67537952018-05-03 11:28:29 +0200219 engine_(std::unique_ptr<cricket::FakeWebRtcVideoEncoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200220 encoder_factory_),
Anders Carlsson67537952018-05-03 11:28:29 +0200221 std::unique_ptr<cricket::FakeWebRtcVideoDecoderFactory>(
Jiawei Ouc2ebe212018-11-08 10:02:56 -0800222 decoder_factory_),
223 webrtc::CreateBuiltinVideoBitrateAllocatorFactory()) {
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +0200224 // Ensure fake clock doesn't return 0, which will cause some initializations
225 // fail inside RTP senders.
226 fake_clock_.AdvanceTimeMicros(1);
227 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000228
229 protected:
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200230 void AssignDefaultAptRtxTypes();
231 void AssignDefaultCodec();
232
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100233 // Find the index of the codec in the engine with the given name. The codec
234 // must be present.
Oleh Prypina40f8242017-12-21 13:32:23 +0100235 size_t GetEngineCodecIndex(const std::string& name) const;
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100236
magjed509e4fe2016-11-18 01:34:11 -0800237 // Find the codec in the engine with the given name. The codec must be
238 // present.
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100239 cricket::VideoCodec GetEngineCodec(const std::string& name) const;
magjed509e4fe2016-11-18 01:34:11 -0800240
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200241 VideoMediaChannel* SetSendParamsWithAllSupportedCodecs();
pbos@webrtc.orgfa553ef2014-10-20 11:07:07 +0000242
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200243 VideoMediaChannel* SetRecvParamsWithSupportedCodecs(
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000244 const std::vector<VideoCodec>& codecs);
245
Peter Boströme4499152016-02-05 11:13:28 +0100246 void TestExtendedEncoderOveruse(bool use_external_encoder);
247
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +0200248 // Has to be the first one, so it is initialized before the call or there is a
249 // race condition in the clock access.
250 rtc::ScopedFakeClock fake_clock_;
stefanc1aeaf02015-10-15 07:26:07 -0700251 webrtc::test::ScopedFieldTrials override_field_trials_;
skvlad11a9cbf2016-10-07 11:53:05 -0700252 webrtc::RtcEventLogNullImpl event_log_;
eladalonf1841382017-06-12 01:16:46 -0700253 // Used in WebRtcVideoEngineVoiceTest, but defined here so it's properly
pbos@webrtc.orgf1f0d9a2015-03-02 13:30:15 +0000254 // initialized when the constructor is called.
kwiberg686a8ef2016-02-26 03:00:35 -0800255 std::unique_ptr<webrtc::Call> call_;
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200256 cricket::FakeWebRtcVideoEncoderFactory* encoder_factory_;
257 cricket::FakeWebRtcVideoDecoderFactory* decoder_factory_;
eladalonf1841382017-06-12 01:16:46 -0700258 WebRtcVideoEngine engine_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000259 VideoCodec default_codec_;
Shao Changbine62202f2015-04-21 20:24:50 +0800260 std::map<int, int> default_apt_rtx_types_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000261};
262
eladalonf1841382017-06-12 01:16:46 -0700263TEST_F(WebRtcVideoEngineTest, DefaultRtxCodecHasAssociatedPayloadTypeSet) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200264 encoder_factory_->AddSupportedVideoCodecType("VP8");
265 AssignDefaultCodec();
266
pbos@webrtc.orge322a172014-06-13 11:47:28 +0000267 std::vector<VideoCodec> engine_codecs = engine_.codecs();
268 for (size_t i = 0; i < engine_codecs.size(); ++i) {
269 if (engine_codecs[i].name != kRtxCodecName)
270 continue;
271 int associated_payload_type;
272 EXPECT_TRUE(engine_codecs[i].GetParam(kCodecParamAssociatedPayloadType,
pbos@webrtc.org42684be2014-10-03 11:25:45 +0000273 &associated_payload_type));
pbos@webrtc.orge322a172014-06-13 11:47:28 +0000274 EXPECT_EQ(default_codec_.id, associated_payload_type);
275 return;
276 }
277 FAIL() << "No RTX codec found among default codecs.";
278}
279
eladalonf1841382017-06-12 01:16:46 -0700280TEST_F(WebRtcVideoEngineTest, SupportsTimestampOffsetHeaderExtension) {
Stefan Holmer9d69c3f2015-12-07 10:45:43 +0100281 RtpCapabilities capabilities = engine_.GetCapabilities();
Johannes Krond0b69a82018-12-03 14:18:53 +0100282 EXPECT_THAT(
283 capabilities.header_extensions,
284 testing::Contains(RtpExtension(RtpExtension::kTimestampOffsetUri,
285 RtpExtension::kTimestampOffsetDefaultId)));
pbos@webrtc.org587ef602014-06-16 17:32:02 +0000286}
287
eladalonf1841382017-06-12 01:16:46 -0700288TEST_F(WebRtcVideoEngineTest, SupportsAbsoluteSenderTimeHeaderExtension) {
Stefan Holmer9d69c3f2015-12-07 10:45:43 +0100289 RtpCapabilities capabilities = engine_.GetCapabilities();
Johannes Krond0b69a82018-12-03 14:18:53 +0100290 EXPECT_THAT(
291 capabilities.header_extensions,
292 testing::Contains(RtpExtension(RtpExtension::kAbsSendTimeUri,
293 RtpExtension::kAbsSendTimeDefaultId)));
pbos@webrtc.org587ef602014-06-16 17:32:02 +0000294}
295
eladalonf1841382017-06-12 01:16:46 -0700296TEST_F(WebRtcVideoEngineTest, SupportsTransportSequenceNumberHeaderExtension) {
Stefan Holmer9d69c3f2015-12-07 10:45:43 +0100297 RtpCapabilities capabilities = engine_.GetCapabilities();
Johannes Krond0b69a82018-12-03 14:18:53 +0100298 EXPECT_THAT(capabilities.header_extensions,
299 testing::Contains(RtpExtension(
300 RtpExtension::kTransportSequenceNumberUri,
301 RtpExtension::kTransportSequenceNumberDefaultId)));
stefanc1aeaf02015-10-15 07:26:07 -0700302}
303
eladalonf1841382017-06-12 01:16:46 -0700304TEST_F(WebRtcVideoEngineTest, SupportsVideoRotationHeaderExtension) {
Stefan Holmer9d69c3f2015-12-07 10:45:43 +0100305 RtpCapabilities capabilities = engine_.GetCapabilities();
Johannes Krond0b69a82018-12-03 14:18:53 +0100306 EXPECT_THAT(
307 capabilities.header_extensions,
308 testing::Contains(RtpExtension(RtpExtension::kVideoRotationUri,
309 RtpExtension::kVideoRotationDefaultId)));
310}
311
312TEST_F(WebRtcVideoEngineTest, SupportsColorSpaceHeaderExtension) {
313 RtpCapabilities capabilities = engine_.GetCapabilities();
314 EXPECT_THAT(
315 capabilities.header_extensions,
316 testing::Contains(RtpExtension(RtpExtension::kColorSpaceUri,
317 RtpExtension::kColorSpaceDefaultId)));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700318}
319
philipel1e054862018-10-08 16:13:53 +0200320class WebRtcVideoEngineTestWithGenericDescriptor
321 : public WebRtcVideoEngineTest {
322 public:
323 WebRtcVideoEngineTestWithGenericDescriptor()
324 : WebRtcVideoEngineTest("WebRTC-GenericDescriptorAdvertised/Enabled/") {}
325};
326
327TEST_F(WebRtcVideoEngineTestWithGenericDescriptor, AdvertiseGenericDescriptor) {
328 RtpCapabilities capabilities = engine_.GetCapabilities();
329 ASSERT_FALSE(capabilities.header_extensions.empty());
330 for (const RtpExtension& extension : capabilities.header_extensions) {
331 if (extension.uri == RtpExtension::kGenericFrameDescriptorUri) {
332 EXPECT_EQ(RtpExtension::kGenericFrameDescriptorDefaultId, extension.id);
333 return;
334 }
335 }
336 FAIL() << "Generic descriptor extension not in header-extension list.";
337}
338
eladalonf1841382017-06-12 01:16:46 -0700339TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionBeforeCapturer) {
Niels Möller731a2c22018-07-30 15:08:07 +0200340 // Allocate the source first to prevent early destruction before channel's
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700341 // dtor is called.
Niels Möller731a2c22018-07-30 15:08:07 +0200342 testing::NiceMock<MockVideoSource> video_source;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700343
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200344 encoder_factory_->AddSupportedVideoCodecType("VP8");
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700345
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200346 std::unique_ptr<VideoMediaChannel> channel(
347 SetSendParamsWithAllSupportedCodecs());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700348 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
349
350 // Add CVO extension.
351 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800352 cricket::VideoSendParameters parameters;
353 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200354 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700355 RtpExtension(RtpExtension::kVideoRotationUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200356 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700357
Niels Möller731a2c22018-07-30 15:08:07 +0200358 EXPECT_CALL(
359 video_source,
360 AddOrUpdateSink(testing::_,
361 Field(&rtc::VideoSinkWants::rotation_applied, false)));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700362 // Set capturer.
Niels Möller731a2c22018-07-30 15:08:07 +0200363 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700364
365 // Verify capturer has turned off applying rotation.
Niels Möller731a2c22018-07-30 15:08:07 +0200366 testing::Mock::VerifyAndClear(&video_source);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700367
368 // Verify removing header extension turns on applying rotation.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200369 parameters.extensions.clear();
Niels Möller731a2c22018-07-30 15:08:07 +0200370 EXPECT_CALL(
371 video_source,
372 AddOrUpdateSink(testing::_,
373 Field(&rtc::VideoSinkWants::rotation_applied, true)));
374
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200375 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700376}
377
eladalonf1841382017-06-12 01:16:46 -0700378TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionBeforeAddSendStream) {
Niels Möller731a2c22018-07-30 15:08:07 +0200379 // Allocate the source first to prevent early destruction before channel's
perkj91e1c152016-03-02 05:34:00 -0800380 // dtor is called.
Niels Möller731a2c22018-07-30 15:08:07 +0200381 testing::NiceMock<MockVideoSource> video_source;
perkj91e1c152016-03-02 05:34:00 -0800382
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200383 encoder_factory_->AddSupportedVideoCodecType("VP8");
perkj91e1c152016-03-02 05:34:00 -0800384
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200385 std::unique_ptr<VideoMediaChannel> channel(
386 SetSendParamsWithAllSupportedCodecs());
perkj91e1c152016-03-02 05:34:00 -0800387 // Add CVO extension.
388 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800389 cricket::VideoSendParameters parameters;
390 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkj91e1c152016-03-02 05:34:00 -0800391 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700392 RtpExtension(RtpExtension::kVideoRotationUri, id));
perkj91e1c152016-03-02 05:34:00 -0800393 EXPECT_TRUE(channel->SetSendParameters(parameters));
394 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
395
Niels Möller731a2c22018-07-30 15:08:07 +0200396 // Set source.
397 EXPECT_CALL(
398 video_source,
399 AddOrUpdateSink(testing::_,
400 Field(&rtc::VideoSinkWants::rotation_applied, false)));
401 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
perkj91e1c152016-03-02 05:34:00 -0800402}
403
eladalonf1841382017-06-12 01:16:46 -0700404TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionAfterCapturer) {
Niels Möller731a2c22018-07-30 15:08:07 +0200405 testing::NiceMock<MockVideoSource> video_source;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700406
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200407 encoder_factory_->AddSupportedVideoCodecType("VP8");
408 encoder_factory_->AddSupportedVideoCodecType("VP9");
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700409
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200410 std::unique_ptr<VideoMediaChannel> channel(
411 SetSendParamsWithAllSupportedCodecs());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700412 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
413
414 // Set capturer.
Niels Möller731a2c22018-07-30 15:08:07 +0200415 EXPECT_CALL(
416 video_source,
417 AddOrUpdateSink(testing::_,
418 Field(&rtc::VideoSinkWants::rotation_applied, true)));
419 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700420
perkjcaafdba2016-03-20 07:34:29 -0700421 // Verify capturer has turned on applying rotation.
Niels Möller731a2c22018-07-30 15:08:07 +0200422 testing::Mock::VerifyAndClear(&video_source);
perkjcaafdba2016-03-20 07:34:29 -0700423
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700424 // Add CVO extension.
425 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800426 cricket::VideoSendParameters parameters;
427 parameters.codecs.push_back(GetEngineCodec("VP8"));
428 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200429 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700430 RtpExtension(RtpExtension::kVideoRotationUri, id));
perkjcaafdba2016-03-20 07:34:29 -0700431 // Also remove the first codec to trigger a codec change as well.
432 parameters.codecs.erase(parameters.codecs.begin());
Niels Möller731a2c22018-07-30 15:08:07 +0200433 EXPECT_CALL(
434 video_source,
435 AddOrUpdateSink(testing::_,
436 Field(&rtc::VideoSinkWants::rotation_applied, false)));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200437 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700438
439 // Verify capturer has turned off applying rotation.
Niels Möller731a2c22018-07-30 15:08:07 +0200440 testing::Mock::VerifyAndClear(&video_source);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700441
442 // Verify removing header extension turns on applying rotation.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200443 parameters.extensions.clear();
Niels Möller731a2c22018-07-30 15:08:07 +0200444 EXPECT_CALL(
445 video_source,
446 AddOrUpdateSink(testing::_,
447 Field(&rtc::VideoSinkWants::rotation_applied, true)));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200448 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700449}
450
eladalonf1841382017-06-12 01:16:46 -0700451TEST_F(WebRtcVideoEngineTest, SetSendFailsBeforeSettingCodecs) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200452 encoder_factory_->AddSupportedVideoCodecType("VP8");
453
Sebastian Jansson84848f22018-11-16 10:40:36 +0100454 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700455 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
pbos@webrtc.org5301b0f2014-07-17 08:51:46 +0000456
457 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(123)));
458
459 EXPECT_FALSE(channel->SetSend(true))
460 << "Channel should not start without codecs.";
461 EXPECT_TRUE(channel->SetSend(false))
462 << "Channel should be stoppable even without set codecs.";
463}
464
eladalonf1841382017-06-12 01:16:46 -0700465TEST_F(WebRtcVideoEngineTest, GetStatsWithoutSendCodecsSetDoesNotCrash) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200466 encoder_factory_->AddSupportedVideoCodecType("VP8");
467
Sebastian Jansson84848f22018-11-16 10:40:36 +0100468 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700469 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
pbos@webrtc.orgc3d2bd22014-08-12 20:55:10 +0000470 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(123)));
471 VideoMediaInfo info;
472 channel->GetStats(&info);
473}
474
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200475TEST_F(WebRtcVideoEngineTest, UseFactoryForVp8WhenSupported) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200476 encoder_factory_->AddSupportedVideoCodecType("VP8");
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000477
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200478 std::unique_ptr<VideoMediaChannel> channel(
479 SetSendParamsWithAllSupportedCodecs());
Sergey Ulanove2b15012016-11-22 16:08:30 -0800480 channel->OnReadyToSend(true);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000481
482 EXPECT_TRUE(
483 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200484 EXPECT_EQ(0, encoder_factory_->GetNumCreatedEncoders());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000485 EXPECT_TRUE(channel->SetSend(true));
Niels Möllerd0f0f682019-01-14 09:09:53 +0100486 webrtc::test::FrameForwarder frame_forwarder;
487 cricket::FakeFrameSource frame_source(1280, 720,
488 rtc::kNumMicrosecsPerSec / 30);
489 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
490 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Per21d45d22016-10-30 21:37:57 +0100491 // Sending one frame will have allocate the encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200492 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
493 EXPECT_TRUE_WAIT(encoder_factory_->encoders()[0]->GetNumEncodedFrames() > 0,
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000494 kTimeout);
495
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200496 int num_created_encoders = encoder_factory_->GetNumCreatedEncoders();
Per21d45d22016-10-30 21:37:57 +0100497 EXPECT_EQ(num_created_encoders, 1);
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000498
499 // Setting codecs of the same type should not reallocate any encoders
500 // (expecting a no-op).
magjed509e4fe2016-11-18 01:34:11 -0800501 cricket::VideoSendParameters parameters;
502 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200503 EXPECT_TRUE(channel->SetSendParameters(parameters));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200504 EXPECT_EQ(num_created_encoders, encoder_factory_->GetNumCreatedEncoders());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000505
506 // Remove stream previously added to free the external encoder instance.
507 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200508 EXPECT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000509}
510
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200511// Test that when an encoder factory supports H264, we add an RTX
512// codec for it.
513// TODO(deadbeef): This test should be updated if/when we start
514// adding RTX codecs for unrecognized codec names.
515TEST_F(WebRtcVideoEngineTest, RtxCodecAddedForH264Codec) {
magjed725e4842016-11-16 00:48:13 -0800516 using webrtc::H264::ProfileLevelIdToString;
517 using webrtc::H264::ProfileLevelId;
518 using webrtc::H264::kLevel1;
Anders Carlsson67537952018-05-03 11:28:29 +0200519 webrtc::SdpVideoFormat h264_constrained_baseline("H264");
520 h264_constrained_baseline.parameters[kH264FmtpProfileLevelId] =
magjed725e4842016-11-16 00:48:13 -0800521 *ProfileLevelIdToString(
522 ProfileLevelId(webrtc::H264::kProfileConstrainedBaseline, kLevel1));
Anders Carlsson67537952018-05-03 11:28:29 +0200523 webrtc::SdpVideoFormat h264_constrained_high("H264");
524 h264_constrained_high.parameters[kH264FmtpProfileLevelId] =
magjed725e4842016-11-16 00:48:13 -0800525 *ProfileLevelIdToString(
526 ProfileLevelId(webrtc::H264::kProfileConstrainedHigh, kLevel1));
Anders Carlsson67537952018-05-03 11:28:29 +0200527 webrtc::SdpVideoFormat h264_high("H264");
528 h264_high.parameters[kH264FmtpProfileLevelId] = *ProfileLevelIdToString(
magjed725e4842016-11-16 00:48:13 -0800529 ProfileLevelId(webrtc::H264::kProfileHigh, kLevel1));
530
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200531 encoder_factory_->AddSupportedVideoCodec(h264_constrained_baseline);
532 encoder_factory_->AddSupportedVideoCodec(h264_constrained_high);
533 encoder_factory_->AddSupportedVideoCodec(h264_high);
Taylor Brandstetter6c3e7882016-06-29 11:14:19 -0700534
magjed725e4842016-11-16 00:48:13 -0800535 // First figure out what payload types the test codecs got assigned.
536 const std::vector<cricket::VideoCodec> codecs = engine_.codecs();
magjed509e4fe2016-11-18 01:34:11 -0800537 // Now search for RTX codecs for them. Expect that they all have associated
538 // RTX codecs.
magjed725e4842016-11-16 00:48:13 -0800539 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200540 codecs,
541 FindMatchingCodec(codecs, cricket::VideoCodec(h264_constrained_baseline))
542 ->id));
magjed725e4842016-11-16 00:48:13 -0800543 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200544 codecs,
545 FindMatchingCodec(codecs, cricket::VideoCodec(h264_constrained_high))
546 ->id));
magjed509e4fe2016-11-18 01:34:11 -0800547 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200548 codecs, FindMatchingCodec(codecs, cricket::VideoCodec(h264_high))->id));
Taylor Brandstetter6c3e7882016-06-29 11:14:19 -0700549}
550
Mirko Bonadei8ef57932018-11-16 14:38:03 +0100551#if defined(RTC_ENABLE_VP9)
eladalonf1841382017-06-12 01:16:46 -0700552TEST_F(WebRtcVideoEngineTest, CanConstructDecoderForVp9EncoderFactory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200553 encoder_factory_->AddSupportedVideoCodecType("VP9");
Peter Boström53eda3d2015-03-27 15:53:18 +0100554
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200555 std::unique_ptr<VideoMediaChannel> channel(
556 SetSendParamsWithAllSupportedCodecs());
Peter Boström53eda3d2015-03-27 15:53:18 +0100557
558 EXPECT_TRUE(
559 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
560}
Mirko Bonadei8ef57932018-11-16 14:38:03 +0100561#endif // defined(RTC_ENABLE_VP9)
Peter Boström53eda3d2015-03-27 15:53:18 +0100562
eladalonf1841382017-06-12 01:16:46 -0700563TEST_F(WebRtcVideoEngineTest, PropagatesInputFrameTimestamp) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200564 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson8f83b422018-02-21 13:07:13 +0100565 FakeCall* fake_call = new FakeCall();
Fredrik Solenberg709ed672015-09-15 12:26:33 +0200566 call_.reset(fake_call);
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200567 std::unique_ptr<VideoMediaChannel> channel(
568 SetSendParamsWithAllSupportedCodecs());
qiangchenc27d89f2015-07-16 10:27:16 -0700569
570 EXPECT_TRUE(
571 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
572
Niels Möllerd0f0f682019-01-14 09:09:53 +0100573 webrtc::test::FrameForwarder frame_forwarder;
574 cricket::FakeFrameSource frame_source(1280, 720,
575 rtc::kNumMicrosecsPerSec / 60);
576 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
qiangchenc27d89f2015-07-16 10:27:16 -0700577 channel->SetSend(true);
578
Fredrik Solenberg709ed672015-09-15 12:26:33 +0200579 FakeVideoSendStream* stream = fake_call->GetVideoSendStreams()[0];
qiangchenc27d89f2015-07-16 10:27:16 -0700580
Niels Möllerd0f0f682019-01-14 09:09:53 +0100581 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos1cb121d2015-09-14 11:38:38 -0700582 int64_t last_timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700583 for (int i = 0; i < 10; i++) {
Niels Möllerd0f0f682019-01-14 09:09:53 +0100584 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos1cb121d2015-09-14 11:38:38 -0700585 int64_t timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700586 int64_t interval = timestamp - last_timestamp;
587
588 // Precision changes from nanosecond to millisecond.
589 // Allow error to be no more than 1.
590 EXPECT_NEAR(cricket::VideoFormat::FpsToInterval(60) / 1E6, interval, 1);
591
592 last_timestamp = timestamp;
593 }
594
Niels Möllerd0f0f682019-01-14 09:09:53 +0100595 frame_forwarder.IncomingCapturedFrame(
596 frame_source.GetFrame(1280, 720, webrtc::VideoRotation::kVideoRotation_0,
597 rtc::kNumMicrosecsPerSec / 30));
qiangchenc27d89f2015-07-16 10:27:16 -0700598 last_timestamp = stream->GetLastTimestamp();
599 for (int i = 0; i < 10; i++) {
Niels Möllerd0f0f682019-01-14 09:09:53 +0100600 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame(
601 1280, 720, webrtc::VideoRotation::kVideoRotation_0,
602 rtc::kNumMicrosecsPerSec / 30));
pbos1cb121d2015-09-14 11:38:38 -0700603 int64_t timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700604 int64_t interval = timestamp - last_timestamp;
605
606 // Precision changes from nanosecond to millisecond.
607 // Allow error to be no more than 1.
608 EXPECT_NEAR(cricket::VideoFormat::FpsToInterval(30) / 1E6, interval, 1);
609
610 last_timestamp = timestamp;
611 }
612
613 // Remove stream previously added to free the external encoder instance.
614 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
615}
616
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200617void WebRtcVideoEngineTest::AssignDefaultAptRtxTypes() {
618 std::vector<VideoCodec> engine_codecs = engine_.codecs();
619 RTC_DCHECK(!engine_codecs.empty());
620 for (const cricket::VideoCodec& codec : engine_codecs) {
621 if (codec.name == "rtx") {
622 int associated_payload_type;
623 if (codec.GetParam(kCodecParamAssociatedPayloadType,
624 &associated_payload_type)) {
625 default_apt_rtx_types_[associated_payload_type] = codec.id;
626 }
627 }
628 }
629}
630
631void WebRtcVideoEngineTest::AssignDefaultCodec() {
632 std::vector<VideoCodec> engine_codecs = engine_.codecs();
633 RTC_DCHECK(!engine_codecs.empty());
634 bool codec_set = false;
635 for (const cricket::VideoCodec& codec : engine_codecs) {
636 if (!codec_set && codec.name != "rtx" && codec.name != "red" &&
637 codec.name != "ulpfec") {
638 default_codec_ = codec;
639 codec_set = true;
640 }
641 }
642
643 RTC_DCHECK(codec_set);
644}
645
Oleh Prypina40f8242017-12-21 13:32:23 +0100646size_t WebRtcVideoEngineTest::GetEngineCodecIndex(
647 const std::string& name) const {
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100648 const std::vector<cricket::VideoCodec> codecs = engine_.codecs();
649 for (size_t i = 0; i < codecs.size(); ++i) {
650 const cricket::VideoCodec engine_codec = codecs[i];
Niels Möller039743e2018-10-23 10:07:25 +0200651 if (!absl::EqualsIgnoreCase(name, engine_codec.name))
Magnus Jedvert8deb8182017-10-05 13:13:32 +0200652 continue;
653 // The tests only use H264 Constrained Baseline. Make sure we don't return
654 // an internal H264 codec from the engine with a different H264 profile.
Niels Möller039743e2018-10-23 10:07:25 +0200655 if (absl::EqualsIgnoreCase(name.c_str(), kH264CodecName)) {
Danil Chapovalov00c71832018-06-15 15:58:38 +0200656 const absl::optional<webrtc::H264::ProfileLevelId> profile_level_id =
Magnus Jedvert8deb8182017-10-05 13:13:32 +0200657 webrtc::H264::ParseSdpProfileLevelId(engine_codec.params);
658 if (profile_level_id->profile !=
659 webrtc::H264::kProfileConstrainedBaseline) {
660 continue;
661 }
662 }
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100663 return i;
magjed509e4fe2016-11-18 01:34:11 -0800664 }
665 // This point should never be reached.
666 ADD_FAILURE() << "Unrecognized codec name: " << name;
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100667 return -1;
668}
669
670cricket::VideoCodec WebRtcVideoEngineTest::GetEngineCodec(
671 const std::string& name) const {
672 return engine_.codecs()[GetEngineCodecIndex(name)];
magjed509e4fe2016-11-18 01:34:11 -0800673}
674
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200675VideoMediaChannel*
676WebRtcVideoEngineTest::SetSendParamsWithAllSupportedCodecs() {
Sebastian Jansson84848f22018-11-16 10:40:36 +0100677 VideoMediaChannel* channel = engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700678 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions());
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200679 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -0800680 // We need to look up the codec in the engine to get the correct payload type.
Anders Carlsson67537952018-05-03 11:28:29 +0200681 for (const webrtc::SdpVideoFormat& format :
682 encoder_factory_->GetSupportedFormats()) {
683 cricket::VideoCodec engine_codec = GetEngineCodec(format.name);
Steve Anton2c9ebef2019-01-28 17:27:58 -0800684 if (!absl::c_linear_search(parameters.codecs, engine_codec)) {
Anders Carlsson67537952018-05-03 11:28:29 +0200685 parameters.codecs.push_back(engine_codec);
686 }
687 }
magjed509e4fe2016-11-18 01:34:11 -0800688
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200689 EXPECT_TRUE(channel->SetSendParameters(parameters));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000690
691 return channel;
692}
693
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200694VideoMediaChannel* WebRtcVideoEngineTest::SetRecvParamsWithSupportedCodecs(
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000695 const std::vector<VideoCodec>& codecs) {
Sebastian Jansson84848f22018-11-16 10:40:36 +0100696 VideoMediaChannel* channel = engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700697 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions());
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200698 cricket::VideoRecvParameters parameters;
699 parameters.codecs = codecs;
700 EXPECT_TRUE(channel->SetRecvParameters(parameters));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000701
702 return channel;
703}
704
eladalonf1841382017-06-12 01:16:46 -0700705TEST_F(WebRtcVideoEngineTest, UsesSimulcastAdapterForVp8Factories) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200706 encoder_factory_->AddSupportedVideoCodecType("VP8");
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000707
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200708 std::unique_ptr<VideoMediaChannel> channel(
709 SetSendParamsWithAllSupportedCodecs());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000710
Peter Boström0c4e06b2015-10-07 12:23:21 +0200711 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000712
Yves Gerey665174f2018-06-19 15:03:05 +0200713 EXPECT_TRUE(channel->AddSendStream(CreateSimStreamParams("cname", ssrcs)));
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000714 EXPECT_TRUE(channel->SetSend(true));
715
Niels Möller805a27e2019-01-21 12:21:27 +0100716 webrtc::test::FrameForwarder frame_forwarder;
717 cricket::FakeFrameSource frame_source(1280, 720,
718 rtc::kNumMicrosecsPerSec / 60);
719 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, &frame_forwarder));
720 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000721
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200722 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000723
724 // Verify that encoders are configured for simulcast through adapter
725 // (increasing resolution and only configured to send one stream each).
726 int prev_width = -1;
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200727 for (size_t i = 0; i < encoder_factory_->encoders().size(); ++i) {
728 ASSERT_TRUE(encoder_factory_->encoders()[i]->WaitForInitEncode());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000729 webrtc::VideoCodec codec_settings =
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200730 encoder_factory_->encoders()[i]->GetCodecSettings();
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000731 EXPECT_EQ(0, codec_settings.numberOfSimulcastStreams);
732 EXPECT_GT(codec_settings.width, prev_width);
733 prev_width = codec_settings.width;
734 }
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000735
Niels Möllerff40b142018-04-09 08:49:14 +0200736 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, nullptr));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000737
738 channel.reset();
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200739 ASSERT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000740}
741
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200742TEST_F(WebRtcVideoEngineTest, ChannelWithH264CanChangeToVp8) {
743 encoder_factory_->AddSupportedVideoCodecType("VP8");
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200744 encoder_factory_->AddSupportedVideoCodecType("H264");
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000745
Niels Möllerd0f0f682019-01-14 09:09:53 +0100746 // Frame source.
747 webrtc::test::FrameForwarder frame_forwarder;
748 cricket::FakeFrameSource frame_source(1280, 720,
749 rtc::kNumMicrosecsPerSec / 30);
Niels Möller4db138e2018-04-19 09:04:13 +0200750
Sebastian Jansson84848f22018-11-16 10:40:36 +0100751 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700752 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
Anders Carlsson67537952018-05-03 11:28:29 +0200753 cricket::VideoSendParameters parameters;
754 parameters.codecs.push_back(GetEngineCodec("H264"));
755 EXPECT_TRUE(channel->SetSendParameters(parameters));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000756
757 EXPECT_TRUE(
758 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möllerd0f0f682019-01-14 09:09:53 +0100759 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
Niels Möller4db138e2018-04-19 09:04:13 +0200760 // Sending one frame will have allocate the encoder.
Niels Möllerd0f0f682019-01-14 09:09:53 +0100761 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller4db138e2018-04-19 09:04:13 +0200762
763 ASSERT_EQ_WAIT(1u, encoder_factory_->encoders().size(), kTimeout);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000764
Anders Carlsson67537952018-05-03 11:28:29 +0200765 cricket::VideoSendParameters new_parameters;
766 new_parameters.codecs.push_back(GetEngineCodec("VP8"));
767 EXPECT_TRUE(channel->SetSendParameters(new_parameters));
Niels Möller4db138e2018-04-19 09:04:13 +0200768
769 // Sending one frame will switch encoder.
Niels Möllerd0f0f682019-01-14 09:09:53 +0100770 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller4db138e2018-04-19 09:04:13 +0200771
Anders Carlsson8a150d92018-05-14 12:40:04 +0200772 EXPECT_EQ_WAIT(1u, encoder_factory_->encoders().size(), kTimeout);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000773}
774
eladalonf1841382017-06-12 01:16:46 -0700775TEST_F(WebRtcVideoEngineTest,
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000776 UsesSimulcastAdapterForVp8WithCombinedVP8AndH264Factory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200777 encoder_factory_->AddSupportedVideoCodecType("VP8");
778 encoder_factory_->AddSupportedVideoCodecType("H264");
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000779
Sebastian Jansson84848f22018-11-16 10:40:36 +0100780 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700781 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
magjed509e4fe2016-11-18 01:34:11 -0800782 cricket::VideoSendParameters parameters;
783 parameters.codecs.push_back(GetEngineCodec("VP8"));
784 EXPECT_TRUE(channel->SetSendParameters(parameters));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000785
Peter Boström0c4e06b2015-10-07 12:23:21 +0200786 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000787
Yves Gerey665174f2018-06-19 15:03:05 +0200788 EXPECT_TRUE(channel->AddSendStream(CreateSimStreamParams("cname", ssrcs)));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000789 EXPECT_TRUE(channel->SetSend(true));
790
791 // Send a fake frame, or else the media engine will configure the simulcast
792 // encoder adapter at a low-enough size that it'll only create a single
793 // encoder layer.
Niels Möller805a27e2019-01-21 12:21:27 +0100794 webrtc::test::FrameForwarder frame_forwarder;
795 cricket::FakeFrameSource frame_source(1280, 720,
796 rtc::kNumMicrosecsPerSec / 30);
797 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, &frame_forwarder));
798 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000799
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200800 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
801 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000802 EXPECT_EQ(webrtc::kVideoCodecVP8,
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200803 encoder_factory_->encoders()[0]->GetCodecSettings().codecType);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000804
805 channel.reset();
806 // Make sure DestroyVideoEncoder was called on the factory.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200807 EXPECT_EQ(0u, encoder_factory_->encoders().size());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000808}
809
eladalonf1841382017-06-12 01:16:46 -0700810TEST_F(WebRtcVideoEngineTest,
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000811 DestroysNonSimulcastEncoderFromCombinedVP8AndH264Factory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200812 encoder_factory_->AddSupportedVideoCodecType("VP8");
813 encoder_factory_->AddSupportedVideoCodecType("H264");
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000814
Sebastian Jansson84848f22018-11-16 10:40:36 +0100815 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700816 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
magjed509e4fe2016-11-18 01:34:11 -0800817 cricket::VideoSendParameters parameters;
818 parameters.codecs.push_back(GetEngineCodec("H264"));
819 EXPECT_TRUE(channel->SetSendParameters(parameters));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000820
821 EXPECT_TRUE(
822 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Per21d45d22016-10-30 21:37:57 +0100823
824 // Send a frame of 720p. This should trigger a "real" encoder initialization.
Niels Möller805a27e2019-01-21 12:21:27 +0100825 webrtc::test::FrameForwarder frame_forwarder;
826 cricket::FakeFrameSource frame_source(1280, 720,
827 rtc::kNumMicrosecsPerSec / 30);
828 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
829 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller4db138e2018-04-19 09:04:13 +0200830 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
831 ASSERT_EQ(1u, encoder_factory_->encoders().size());
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200832 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000833 EXPECT_EQ(webrtc::kVideoCodecH264,
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200834 encoder_factory_->encoders()[0]->GetCodecSettings().codecType);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000835
836 channel.reset();
837 // Make sure DestroyVideoEncoder was called on the factory.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200838 ASSERT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000839}
840
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200841TEST_F(WebRtcVideoEngineTest, SimulcastEnabledForH264BehindFieldTrial) {
842 webrtc::test::ScopedFieldTrials override_field_trials_(
843 "WebRTC-H264Simulcast/Enabled/");
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200844 encoder_factory_->AddSupportedVideoCodecType("H264");
noahricfdac5162015-08-27 01:59:29 -0700845
Sebastian Jansson84848f22018-11-16 10:40:36 +0100846 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700847 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
Anders Carlsson67537952018-05-03 11:28:29 +0200848 cricket::VideoSendParameters parameters;
849 parameters.codecs.push_back(GetEngineCodec("H264"));
850 EXPECT_TRUE(channel->SetSendParameters(parameters));
noahricfdac5162015-08-27 01:59:29 -0700851
Peter Boström0c4e06b2015-10-07 12:23:21 +0200852 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
noahricfdac5162015-08-27 01:59:29 -0700853 EXPECT_TRUE(
854 channel->AddSendStream(cricket::CreateSimStreamParams("cname", ssrcs)));
Peter Boströmce23bee2016-02-02 14:14:30 +0100855
856 // Send a frame of 720p. This should trigger a "real" encoder initialization.
Niels Möller805a27e2019-01-21 12:21:27 +0100857 webrtc::test::FrameForwarder frame_forwarder;
858 cricket::FakeFrameSource frame_source(1280, 720,
859 rtc::kNumMicrosecsPerSec / 30);
860 EXPECT_TRUE(channel->SetVideoSend(ssrcs[0], nullptr, &frame_forwarder));
861 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Peter Boströmce23bee2016-02-02 14:14:30 +0100862
Niels Möller4db138e2018-04-19 09:04:13 +0200863 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200864 ASSERT_EQ(1u, encoder_factory_->encoders().size());
865 FakeWebRtcVideoEncoder* encoder = encoder_factory_->encoders()[0];
866 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
noahricfdac5162015-08-27 01:59:29 -0700867 EXPECT_EQ(webrtc::kVideoCodecH264, encoder->GetCodecSettings().codecType);
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200868 EXPECT_LT(1u, encoder->GetCodecSettings().numberOfSimulcastStreams);
Niels Möllerff40b142018-04-09 08:49:14 +0200869 EXPECT_TRUE(channel->SetVideoSend(ssrcs[0], nullptr, nullptr));
noahricfdac5162015-08-27 01:59:29 -0700870}
871
brandtrffc61182016-11-28 06:02:22 -0800872// Test that the FlexFEC field trial properly alters the output of
eladalonf1841382017-06-12 01:16:46 -0700873// WebRtcVideoEngine::codecs(), for an existing |engine_| object.
brandtrffc61182016-11-28 06:02:22 -0800874//
875// TODO(brandtr): Remove this test, when the FlexFEC field trial is gone.
eladalonf1841382017-06-12 01:16:46 -0700876TEST_F(WebRtcVideoEngineTest,
brandtrffc61182016-11-28 06:02:22 -0800877 Flexfec03SupportedAsInternalCodecBehindFieldTrial) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200878 encoder_factory_->AddSupportedVideoCodecType("VP8");
879
Steve Anton2c9ebef2019-01-28 17:27:58 -0800880 auto flexfec = Field("name", &VideoCodec::name, "flexfec-03");
brandtrffc61182016-11-28 06:02:22 -0800881
882 // FlexFEC is not active without field trial.
Steve Anton2c9ebef2019-01-28 17:27:58 -0800883 EXPECT_THAT(engine_.codecs(), Not(Contains(flexfec)));
brandtrffc61182016-11-28 06:02:22 -0800884
885 // FlexFEC is active with field trial.
886 webrtc::test::ScopedFieldTrials override_field_trials_(
brandtr340e3fd2017-02-28 15:43:10 -0800887 "WebRTC-FlexFEC-03-Advertised/Enabled/");
Steve Anton2c9ebef2019-01-28 17:27:58 -0800888 EXPECT_THAT(engine_.codecs(), Contains(flexfec));
brandtrffc61182016-11-28 06:02:22 -0800889}
890
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200891// Test that codecs are added in the order they are reported from the factory.
892TEST_F(WebRtcVideoEngineTest, ReportSupportedCodecs) {
893 encoder_factory_->AddSupportedVideoCodecType("VP8");
894 const char* kFakeCodecName = "FakeCodec";
895 encoder_factory_->AddSupportedVideoCodecType(kFakeCodecName);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000896
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200897 // The last reported codec should appear after the first codec in the vector.
Oleh Prypina40f8242017-12-21 13:32:23 +0100898 const size_t vp8_index = GetEngineCodecIndex("VP8");
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200899 const size_t fake_codec_index = GetEngineCodecIndex(kFakeCodecName);
900 EXPECT_LT(vp8_index, fake_codec_index);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000901}
902
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200903// Test that a codec that was added after the engine was initialized
brandtrffc61182016-11-28 06:02:22 -0800904// does show up in the codec list after it was added.
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200905TEST_F(WebRtcVideoEngineTest, ReportSupportedAddedCodec) {
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100906 const char* kFakeExternalCodecName1 = "FakeExternalCodec1";
907 const char* kFakeExternalCodecName2 = "FakeExternalCodec2";
Magnus Jedvert154ee1f2017-11-15 19:27:11 +0100908
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100909 // Set up external encoder factory with first codec, and initialize engine.
910 encoder_factory_->AddSupportedVideoCodecType(kFakeExternalCodecName1);
911
brandtrffc61182016-11-28 06:02:22 -0800912 std::vector<cricket::VideoCodec> codecs_before(engine_.codecs());
brandtrffc61182016-11-28 06:02:22 -0800913
914 // Add second codec.
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100915 encoder_factory_->AddSupportedVideoCodecType(kFakeExternalCodecName2);
brandtrffc61182016-11-28 06:02:22 -0800916 std::vector<cricket::VideoCodec> codecs_after(engine_.codecs());
Sami Kalliomäkie9a18b22018-07-13 10:28:21 +0200917 // The codec itself and RTX should have been added.
918 EXPECT_EQ(codecs_before.size() + 2, codecs_after.size());
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100919
920 // Check that both fake codecs are present and that the second fake codec
921 // appears after the first fake codec.
Oleh Prypina40f8242017-12-21 13:32:23 +0100922 const size_t fake_codec_index1 = GetEngineCodecIndex(kFakeExternalCodecName1);
923 const size_t fake_codec_index2 = GetEngineCodecIndex(kFakeExternalCodecName2);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100924 EXPECT_LT(fake_codec_index1, fake_codec_index2);
brandtrffc61182016-11-28 06:02:22 -0800925}
926
Sami Kalliomäkie9a18b22018-07-13 10:28:21 +0200927TEST_F(WebRtcVideoEngineTest, ReportRtxForExternalCodec) {
928 const char* kFakeCodecName = "FakeCodec";
929 encoder_factory_->AddSupportedVideoCodecType(kFakeCodecName);
930
931 const size_t fake_codec_index = GetEngineCodecIndex(kFakeCodecName);
932 EXPECT_EQ("rtx", engine_.codecs().at(fake_codec_index + 1).name);
933}
934
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200935TEST_F(WebRtcVideoEngineTest, RegisterDecodersIfSupported) {
936 encoder_factory_->AddSupportedVideoCodecType("VP8");
Anders Carlsson67537952018-05-03 11:28:29 +0200937 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200938 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -0800939 parameters.codecs.push_back(GetEngineCodec("VP8"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000940
kwiberg686a8ef2016-02-26 03:00:35 -0800941 std::unique_ptr<VideoMediaChannel> channel(
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200942 SetRecvParamsWithSupportedCodecs(parameters.codecs));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000943
944 EXPECT_TRUE(
945 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200946 ASSERT_EQ(1u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000947
948 // Setting codecs of the same type should not reallocate the decoder.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200949 EXPECT_TRUE(channel->SetRecvParameters(parameters));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200950 EXPECT_EQ(1, decoder_factory_->GetNumCreatedDecoders());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000951
952 // Remove stream previously added to free the external decoder instance.
953 EXPECT_TRUE(channel->RemoveRecvStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200954 EXPECT_EQ(0u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000955}
956
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200957// Verifies that we can set up decoders.
958TEST_F(WebRtcVideoEngineTest, RegisterH264DecoderIfSupported) {
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000959 // TODO(pbos): Do not assume that encoder/decoder support is symmetric. We
960 // can't even query the WebRtcVideoDecoderFactory for supported codecs.
961 // For now we add a FakeWebRtcVideoEncoderFactory to add H264 to supported
962 // codecs.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200963 encoder_factory_->AddSupportedVideoCodecType("H264");
Anders Carlsson67537952018-05-03 11:28:29 +0200964 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("H264"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000965 std::vector<cricket::VideoCodec> codecs;
magjed509e4fe2016-11-18 01:34:11 -0800966 codecs.push_back(GetEngineCodec("H264"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000967
kwiberg686a8ef2016-02-26 03:00:35 -0800968 std::unique_ptr<VideoMediaChannel> channel(
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200969 SetRecvParamsWithSupportedCodecs(codecs));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000970
971 EXPECT_TRUE(
972 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200973 ASSERT_EQ(1u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000974}
975
Jonas Oreland49ac5952018-09-26 16:04:32 +0200976// Tests when GetSources is called with non-existing ssrc, it will return an
977// empty list of RtpSource without crashing.
978TEST_F(WebRtcVideoEngineTest, GetSourcesWithNonExistingSsrc) {
979 // Setup an recv stream with |kSsrc|.
980 encoder_factory_->AddSupportedVideoCodecType("VP8");
981 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("VP8"));
982 cricket::VideoRecvParameters parameters;
983 parameters.codecs.push_back(GetEngineCodec("VP8"));
984 std::unique_ptr<VideoMediaChannel> channel(
985 SetRecvParamsWithSupportedCodecs(parameters.codecs));
986
987 EXPECT_TRUE(
988 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
989
990 // Call GetSources with |kSsrc + 1| which doesn't exist.
991 std::vector<webrtc::RtpSource> sources = channel->GetSources(kSsrc + 1);
992 EXPECT_EQ(0u, sources.size());
993}
994
Magnus Jedvertd4b0c052017-09-14 10:24:54 +0200995TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, NullFactories) {
996 std::unique_ptr<webrtc::VideoEncoderFactory> encoder_factory;
997 std::unique_ptr<webrtc::VideoDecoderFactory> decoder_factory;
Jiawei Ouc2ebe212018-11-08 10:02:56 -0800998 std::unique_ptr<webrtc::VideoBitrateAllocatorFactory> rate_allocator_factory;
Magnus Jedvertd4b0c052017-09-14 10:24:54 +0200999 WebRtcVideoEngine engine(std::move(encoder_factory),
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001000 std::move(decoder_factory),
1001 std::move(rate_allocator_factory));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001002 EXPECT_EQ(0u, engine.codecs().size());
1003}
1004
1005TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, EmptyFactories) {
1006 // |engine| take ownership of the factories.
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -07001007 webrtc::MockVideoEncoderFactory* encoder_factory =
1008 new webrtc::MockVideoEncoderFactory();
1009 webrtc::MockVideoDecoderFactory* decoder_factory =
1010 new webrtc::MockVideoDecoderFactory();
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001011 webrtc::MockVideoBitrateAllocatorFactory* rate_allocator_factory =
1012 new webrtc::MockVideoBitrateAllocatorFactory();
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001013 WebRtcVideoEngine engine(
1014 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001015 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)),
1016 (std::unique_ptr<webrtc::VideoBitrateAllocatorFactory>(
1017 rate_allocator_factory)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001018 EXPECT_CALL(*encoder_factory, GetSupportedFormats());
1019 EXPECT_EQ(0u, engine.codecs().size());
1020 EXPECT_CALL(*encoder_factory, Die());
1021 EXPECT_CALL(*decoder_factory, Die());
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001022 EXPECT_CALL(*rate_allocator_factory, Die());
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001023}
1024
1025// Test full behavior in the video engine when video codec factories of the new
1026// type are injected supporting the single codec Vp8. Check the returned codecs
1027// from the engine and that we will create a Vp8 encoder and decoder using the
1028// new factories.
1029TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, Vp8) {
1030 // |engine| take ownership of the factories.
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -07001031 webrtc::MockVideoEncoderFactory* encoder_factory =
1032 new webrtc::MockVideoEncoderFactory();
1033 webrtc::MockVideoDecoderFactory* decoder_factory =
1034 new webrtc::MockVideoDecoderFactory();
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001035 webrtc::MockVideoBitrateAllocatorFactory* rate_allocator_factory =
1036 new webrtc::MockVideoBitrateAllocatorFactory();
1037 EXPECT_CALL(*rate_allocator_factory,
1038 CreateVideoBitrateAllocatorProxy(Field(
1039 &webrtc::VideoCodec::codecType, webrtc::kVideoCodecVP8)))
1040 .WillOnce(testing::Return(new webrtc::MockVideoBitrateAllocator()));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001041 WebRtcVideoEngine engine(
1042 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001043 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)),
1044 (std::unique_ptr<webrtc::VideoBitrateAllocatorFactory>(
1045 rate_allocator_factory)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001046 const webrtc::SdpVideoFormat vp8_format("VP8");
1047 const std::vector<webrtc::SdpVideoFormat> supported_formats = {vp8_format};
1048 EXPECT_CALL(*encoder_factory, GetSupportedFormats())
1049 .WillRepeatedly(testing::Return(supported_formats));
1050
1051 // Verify the codecs from the engine.
1052 const std::vector<VideoCodec> engine_codecs = engine.codecs();
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001053 // Verify default codecs has been added correctly.
1054 EXPECT_EQ(5u, engine_codecs.size());
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001055 EXPECT_EQ("VP8", engine_codecs.at(0).name);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001056
1057 // RTX codec for VP8.
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001058 EXPECT_EQ("rtx", engine_codecs.at(1).name);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001059 int vp8_associated_payload;
1060 EXPECT_TRUE(engine_codecs.at(1).GetParam(kCodecParamAssociatedPayloadType,
1061 &vp8_associated_payload));
1062 EXPECT_EQ(vp8_associated_payload, engine_codecs.at(0).id);
1063
1064 EXPECT_EQ(kRedCodecName, engine_codecs.at(2).name);
1065
1066 // RTX codec for RED.
1067 EXPECT_EQ("rtx", engine_codecs.at(3).name);
1068 int red_associated_payload;
1069 EXPECT_TRUE(engine_codecs.at(3).GetParam(kCodecParamAssociatedPayloadType,
1070 &red_associated_payload));
1071 EXPECT_EQ(red_associated_payload, engine_codecs.at(2).id);
1072
1073 EXPECT_EQ(kUlpfecCodecName, engine_codecs.at(4).name);
1074
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001075 int associated_payload_type;
1076 EXPECT_TRUE(engine_codecs.at(1).GetParam(
1077 cricket::kCodecParamAssociatedPayloadType, &associated_payload_type));
1078 EXPECT_EQ(engine_codecs.at(0).id, associated_payload_type);
1079 // Verify default parameters has been added to the VP8 codec.
1080 VerifyCodecHasDefaultFeedbackParams(engine_codecs.at(0));
1081
1082 // Mock encoder creation. |engine| take ownership of the encoder.
Mirta Dvornicic1ec2a162018-12-10 09:47:34 +00001083 webrtc::VideoEncoderFactory::CodecInfo codec_info;
1084 codec_info.is_hardware_accelerated = false;
1085 codec_info.has_internal_source = false;
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001086 const webrtc::SdpVideoFormat format("VP8");
Mirta Dvornicic1ec2a162018-12-10 09:47:34 +00001087 EXPECT_CALL(*encoder_factory, QueryVideoEncoder(format))
1088 .WillRepeatedly(testing::Return(codec_info));
Anders Carlsson67537952018-05-03 11:28:29 +02001089 FakeWebRtcVideoEncoder* const encoder = new FakeWebRtcVideoEncoder(nullptr);
Niels Möllerc572ff32018-11-07 08:43:50 +01001090 rtc::Event encoder_created;
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001091 EXPECT_CALL(*encoder_factory, CreateVideoEncoderProxy(format))
Niels Möller4db138e2018-04-19 09:04:13 +02001092 .WillOnce(
1093 ::testing::DoAll(::testing::InvokeWithoutArgs(
1094 [&encoder_created]() { encoder_created.Set(); }),
1095 ::testing::Return(encoder)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001096
1097 // Mock decoder creation. |engine| take ownership of the decoder.
Anders Carlsson67537952018-05-03 11:28:29 +02001098 FakeWebRtcVideoDecoder* const decoder = new FakeWebRtcVideoDecoder(nullptr);
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001099 EXPECT_CALL(*decoder_factory, CreateVideoDecoderProxy(format))
1100 .WillOnce(testing::Return(decoder));
1101
1102 // Create a call.
1103 webrtc::RtcEventLogNullImpl event_log;
1104 std::unique_ptr<webrtc::Call> call(
1105 webrtc::Call::Create(webrtc::Call::Config(&event_log)));
1106
1107 // Create send channel.
1108 const int send_ssrc = 123;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001109 std::unique_ptr<VideoMediaChannel> send_channel(engine.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07001110 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001111 cricket::VideoSendParameters send_parameters;
1112 send_parameters.codecs.push_back(engine_codecs.at(0));
1113 EXPECT_TRUE(send_channel->SetSendParameters(send_parameters));
1114 send_channel->OnReadyToSend(true);
1115 EXPECT_TRUE(
1116 send_channel->AddSendStream(StreamParams::CreateLegacy(send_ssrc)));
1117 EXPECT_TRUE(send_channel->SetSend(true));
1118
Niels Möller4db138e2018-04-19 09:04:13 +02001119 // Set capturer.
Niels Möller805a27e2019-01-21 12:21:27 +01001120 webrtc::test::FrameForwarder frame_forwarder;
1121 cricket::FakeFrameSource frame_source(1280, 720,
1122 rtc::kNumMicrosecsPerSec / 30);
1123 EXPECT_TRUE(send_channel->SetVideoSend(send_ssrc, nullptr, &frame_forwarder));
Niels Möller4db138e2018-04-19 09:04:13 +02001124 // Sending one frame will allocate the encoder.
Niels Möller805a27e2019-01-21 12:21:27 +01001125 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller4db138e2018-04-19 09:04:13 +02001126 encoder_created.Wait(kTimeout);
1127
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001128 // Create recv channel.
1129 const int recv_ssrc = 321;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001130 std::unique_ptr<VideoMediaChannel> recv_channel(engine.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07001131 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001132 cricket::VideoRecvParameters recv_parameters;
1133 recv_parameters.codecs.push_back(engine_codecs.at(0));
1134 EXPECT_TRUE(recv_channel->SetRecvParameters(recv_parameters));
1135 EXPECT_TRUE(recv_channel->AddRecvStream(
1136 cricket::StreamParams::CreateLegacy(recv_ssrc)));
1137
1138 // Remove streams previously added to free the encoder and decoder instance.
1139 EXPECT_CALL(*encoder_factory, Die());
1140 EXPECT_CALL(*decoder_factory, Die());
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001141 EXPECT_CALL(*rate_allocator_factory, Die());
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001142 EXPECT_TRUE(send_channel->RemoveSendStream(send_ssrc));
1143 EXPECT_TRUE(recv_channel->RemoveRecvStream(recv_ssrc));
1144}
1145
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001146// Test behavior when decoder factory fails to create a decoder (returns null).
1147TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, NullDecoder) {
1148 // |engine| take ownership of the factories.
1149 webrtc::MockVideoEncoderFactory* encoder_factory =
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001150 new webrtc::MockVideoEncoderFactory();
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001151 webrtc::MockVideoDecoderFactory* decoder_factory =
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001152 new webrtc::MockVideoDecoderFactory();
1153 webrtc::MockVideoBitrateAllocatorFactory* rate_allocator_factory =
1154 new webrtc::MockVideoBitrateAllocatorFactory();
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001155 WebRtcVideoEngine engine(
1156 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001157 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)),
1158 (std::unique_ptr<webrtc::VideoBitrateAllocatorFactory>(
1159 rate_allocator_factory)));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001160 const webrtc::SdpVideoFormat vp8_format("VP8");
1161 const std::vector<webrtc::SdpVideoFormat> supported_formats = {vp8_format};
1162 EXPECT_CALL(*encoder_factory, GetSupportedFormats())
1163 .WillRepeatedly(testing::Return(supported_formats));
1164
1165 // Decoder creation fails.
1166 EXPECT_CALL(*decoder_factory, CreateVideoDecoderProxy(testing::_))
1167 .WillOnce(testing::Return(nullptr));
1168
1169 // Create a call.
1170 webrtc::RtcEventLogNullImpl event_log;
1171 std::unique_ptr<webrtc::Call> call(
1172 webrtc::Call::Create(webrtc::Call::Config(&event_log)));
1173
1174 // Create recv channel.
1175 const int recv_ssrc = 321;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001176 std::unique_ptr<VideoMediaChannel> recv_channel(engine.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07001177 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001178 cricket::VideoRecvParameters recv_parameters;
1179 recv_parameters.codecs.push_back(engine.codecs().front());
1180 EXPECT_TRUE(recv_channel->SetRecvParameters(recv_parameters));
1181 EXPECT_TRUE(recv_channel->AddRecvStream(
1182 cricket::StreamParams::CreateLegacy(recv_ssrc)));
1183
1184 // Remove streams previously added to free the encoder and decoder instance.
1185 EXPECT_TRUE(recv_channel->RemoveRecvStream(recv_ssrc));
1186}
1187
eladalonf1841382017-06-12 01:16:46 -07001188TEST_F(WebRtcVideoEngineTest, DISABLED_RecreatesEncoderOnContentTypeChange) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001189 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson8f83b422018-02-21 13:07:13 +01001190 std::unique_ptr<FakeCall> fake_call(new FakeCall());
Anders Carlsson5f2bb622018-05-14 09:48:06 +02001191 std::unique_ptr<VideoMediaChannel> channel(
1192 SetSendParamsWithAllSupportedCodecs());
sprangf24a0642017-02-28 13:23:26 -08001193 ASSERT_TRUE(
1194 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
1195 cricket::VideoCodec codec = GetEngineCodec("VP8");
1196 cricket::VideoSendParameters parameters;
1197 parameters.codecs.push_back(codec);
1198 channel->OnReadyToSend(true);
1199 channel->SetSend(true);
1200 ASSERT_TRUE(channel->SetSendParameters(parameters));
1201
Niels Möller805a27e2019-01-21 12:21:27 +01001202 webrtc::test::FrameForwarder frame_forwarder;
1203 cricket::FakeFrameSource frame_source(1280, 720,
1204 rtc::kNumMicrosecsPerSec / 30);
sprangf24a0642017-02-28 13:23:26 -08001205 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01001206 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
sprangf24a0642017-02-28 13:23:26 -08001207
Niels Möller805a27e2019-01-21 12:21:27 +01001208 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001209 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001210 EXPECT_EQ(webrtc::VideoCodecMode::kRealtimeVideo,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001211 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001212
Niels Möller805a27e2019-01-21 12:21:27 +01001213 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
1214 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
sprangf24a0642017-02-28 13:23:26 -08001215 // No change in content type, keep current encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001216 EXPECT_EQ(1, encoder_factory_->GetNumCreatedEncoders());
sprangf24a0642017-02-28 13:23:26 -08001217
1218 options.is_screencast.emplace(true);
Niels Möller805a27e2019-01-21 12:21:27 +01001219 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
1220 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
sprangf24a0642017-02-28 13:23:26 -08001221 // Change to screen content, recreate encoder. For the simulcast encoder
1222 // adapter case, this will result in two calls since InitEncode triggers a
1223 // a new instance.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001224 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001225 EXPECT_EQ(webrtc::VideoCodecMode::kScreensharing,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001226 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001227
Niels Möller805a27e2019-01-21 12:21:27 +01001228 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
1229 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
sprangf24a0642017-02-28 13:23:26 -08001230 // Still screen content, no need to update encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001231 EXPECT_EQ(2, encoder_factory_->GetNumCreatedEncoders());
sprangf24a0642017-02-28 13:23:26 -08001232
1233 options.is_screencast.emplace(false);
1234 options.video_noise_reduction.emplace(false);
Niels Möller805a27e2019-01-21 12:21:27 +01001235 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
sprangf24a0642017-02-28 13:23:26 -08001236 // Change back to regular video content, update encoder. Also change
1237 // a non |is_screencast| option just to verify it doesn't affect recreation.
Niels Möller805a27e2019-01-21 12:21:27 +01001238 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001239 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(3));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001240 EXPECT_EQ(webrtc::VideoCodecMode::kRealtimeVideo,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001241 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001242
1243 // Remove stream previously added to free the external encoder instance.
1244 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001245 EXPECT_EQ(0u, encoder_factory_->encoders().size());
sprangf24a0642017-02-28 13:23:26 -08001246}
1247
Niels Möller6557d0c2018-04-11 15:18:34 +02001248class WebRtcVideoChannelBaseTest : public testing::Test {
1249 protected:
1250 WebRtcVideoChannelBaseTest()
Jonas Oreland49ac5952018-09-26 16:04:32 +02001251 : engine_(webrtc::CreateBuiltinVideoEncoderFactory(),
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001252 webrtc::CreateBuiltinVideoDecoderFactory(),
1253 webrtc::CreateBuiltinVideoBitrateAllocatorFactory()) {}
Niels Möller6557d0c2018-04-11 15:18:34 +02001254
1255 virtual void SetUp() {
Jonas Oreland49ac5952018-09-26 16:04:32 +02001256 // One testcase calls SetUp in a loop, only create call_ once.
1257 if (!call_) {
1258 call_.reset(webrtc::Call::Create(webrtc::Call::Config(&event_log_)));
1259 }
Niels Möller6557d0c2018-04-11 15:18:34 +02001260 cricket::MediaConfig media_config;
1261 // Disabling cpu overuse detection actually disables quality scaling too; it
1262 // implies DegradationPreference kMaintainResolution. Automatic scaling
1263 // needs to be disabled, otherwise, tests which check the size of received
1264 // frames become flaky.
1265 media_config.video.enable_cpu_adaptation = false;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001266 channel_.reset(
1267 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
1268 call_.get(), media_config, cricket::VideoOptions(),
1269 webrtc::CryptoOptions())));
Niels Möller6557d0c2018-04-11 15:18:34 +02001270 channel_->OnReadyToSend(true);
1271 EXPECT_TRUE(channel_.get() != NULL);
1272 network_interface_.SetDestination(channel_.get());
Anton Sukhanov98a462c2018-10-17 13:15:42 -07001273 channel_->SetInterface(&network_interface_, /*media_transport=*/nullptr);
Niels Möller6557d0c2018-04-11 15:18:34 +02001274 cricket::VideoRecvParameters parameters;
1275 parameters.codecs = engine_.codecs();
1276 channel_->SetRecvParameters(parameters);
1277 EXPECT_TRUE(channel_->AddSendStream(DefaultSendStreamParams()));
Niels Möller805a27e2019-01-21 12:21:27 +01001278 frame_forwarder_ = absl::make_unique<webrtc::test::FrameForwarder>();
1279 frame_source_ = absl::make_unique<cricket::FakeFrameSource>(
1280 640, 480, rtc::kNumMicrosecsPerSec / kFramerate);
1281 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, frame_forwarder_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001282 }
1283
1284 // Utility method to setup an additional stream to send and receive video.
1285 // Used to test send and recv between two streams.
1286 void SetUpSecondStream() {
1287 SetUpSecondStreamWithNoRecv();
1288 // Setup recv for second stream.
1289 EXPECT_TRUE(channel_->AddRecvStream(
1290 cricket::StreamParams::CreateLegacy(kSsrc + 2)));
1291 // Make the second renderer available for use by a new stream.
1292 EXPECT_TRUE(channel_->SetSink(kSsrc + 2, &renderer2_));
1293 }
1294 // Setup an additional stream just to send video. Defer add recv stream.
1295 // This is required if you want to test unsignalled recv of video rtp packets.
1296 void SetUpSecondStreamWithNoRecv() {
1297 // SetUp() already added kSsrc make sure duplicate SSRCs cant be added.
Yves Gerey665174f2018-06-19 15:03:05 +02001298 EXPECT_TRUE(
1299 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001300 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
Yves Gerey665174f2018-06-19 15:03:05 +02001301 EXPECT_FALSE(
1302 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001303 EXPECT_TRUE(channel_->AddSendStream(
1304 cricket::StreamParams::CreateLegacy(kSsrc + 2)));
1305 // We dont add recv for the second stream.
1306
1307 // Setup the receive and renderer for second stream after send.
Niels Möller805a27e2019-01-21 12:21:27 +01001308 frame_forwarder_2_ = absl::make_unique<webrtc::test::FrameForwarder>();
Yves Gerey665174f2018-06-19 15:03:05 +02001309 EXPECT_TRUE(
Niels Möller805a27e2019-01-21 12:21:27 +01001310 channel_->SetVideoSend(kSsrc + 2, nullptr, frame_forwarder_2_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001311 }
Yves Gerey665174f2018-06-19 15:03:05 +02001312 virtual void TearDown() { channel_.reset(); }
1313 bool SetDefaultCodec() { return SetOneCodec(DefaultCodec()); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001314
1315 bool SetOneCodec(const cricket::VideoCodec& codec) {
Niels Möller805a27e2019-01-21 12:21:27 +01001316 frame_source_ = absl::make_unique<cricket::FakeFrameSource>(
1317 kVideoWidth, kVideoHeight, rtc::kNumMicrosecsPerSec / kFramerate);
Niels Möller6557d0c2018-04-11 15:18:34 +02001318
1319 bool sending = channel_->sending();
1320 bool success = SetSend(false);
1321 if (success) {
1322 cricket::VideoSendParameters parameters;
1323 parameters.codecs.push_back(codec);
1324 success = channel_->SetSendParameters(parameters);
1325 }
1326 if (success) {
1327 success = SetSend(sending);
1328 }
1329 return success;
1330 }
Yves Gerey665174f2018-06-19 15:03:05 +02001331 bool SetSend(bool send) { return channel_->SetSend(send); }
Niels Möller805a27e2019-01-21 12:21:27 +01001332 void SendFrame() {
1333 if (frame_forwarder_2_) {
1334 frame_forwarder_2_->IncomingCapturedFrame(frame_source_->GetFrame());
Niels Möller6557d0c2018-04-11 15:18:34 +02001335 }
Niels Möller805a27e2019-01-21 12:21:27 +01001336 frame_forwarder_->IncomingCapturedFrame(frame_source_->GetFrame());
Niels Möller6557d0c2018-04-11 15:18:34 +02001337 }
1338 bool WaitAndSendFrame(int wait_ms) {
1339 bool ret = rtc::Thread::Current()->ProcessMessages(wait_ms);
Niels Möller805a27e2019-01-21 12:21:27 +01001340 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001341 return ret;
1342 }
Yves Gerey665174f2018-06-19 15:03:05 +02001343 int NumRtpBytes() { return network_interface_.NumRtpBytes(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001344 int NumRtpBytes(uint32_t ssrc) {
1345 return network_interface_.NumRtpBytes(ssrc);
1346 }
Yves Gerey665174f2018-06-19 15:03:05 +02001347 int NumRtpPackets() { return network_interface_.NumRtpPackets(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001348 int NumRtpPackets(uint32_t ssrc) {
1349 return network_interface_.NumRtpPackets(ssrc);
1350 }
Yves Gerey665174f2018-06-19 15:03:05 +02001351 int NumSentSsrcs() { return network_interface_.NumSentSsrcs(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001352 const rtc::CopyOnWriteBuffer* GetRtpPacket(int index) {
1353 return network_interface_.GetRtpPacket(index);
1354 }
1355 static int GetPayloadType(const rtc::CopyOnWriteBuffer* p) {
Åsa Persson23cd45a2018-07-03 10:40:40 +02001356 webrtc::RTPHeader header;
1357 EXPECT_TRUE(ParseRtpPacket(p, &header));
1358 return header.payloadType;
Niels Möller6557d0c2018-04-11 15:18:34 +02001359 }
Åsa Persson23cd45a2018-07-03 10:40:40 +02001360
Niels Möller6557d0c2018-04-11 15:18:34 +02001361 static bool ParseRtpPacket(const rtc::CopyOnWriteBuffer* p,
Åsa Persson23cd45a2018-07-03 10:40:40 +02001362 webrtc::RTPHeader* header) {
1363 std::unique_ptr<webrtc::RtpHeaderParser> parser(
1364 webrtc::RtpHeaderParser::Create());
1365 return parser->Parse(p->cdata(), p->size(), header);
Niels Möller6557d0c2018-04-11 15:18:34 +02001366 }
1367
1368 // Tests that we can send and receive frames.
1369 void SendAndReceive(const cricket::VideoCodec& codec) {
1370 EXPECT_TRUE(SetOneCodec(codec));
1371 EXPECT_TRUE(SetSend(true));
1372 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1373 EXPECT_EQ(0, renderer_.num_rendered_frames());
Niels Möller805a27e2019-01-21 12:21:27 +01001374 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001375 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1376 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1377 EXPECT_EQ(codec.id, GetPayloadType(p.get()));
1378 }
1379
1380 void SendReceiveManyAndGetStats(const cricket::VideoCodec& codec,
Yves Gerey665174f2018-06-19 15:03:05 +02001381 int duration_sec,
1382 int fps) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001383 EXPECT_TRUE(SetOneCodec(codec));
1384 EXPECT_TRUE(SetSend(true));
1385 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1386 EXPECT_EQ(0, renderer_.num_rendered_frames());
1387 for (int i = 0; i < duration_sec; ++i) {
1388 for (int frame = 1; frame <= fps; ++frame) {
1389 EXPECT_TRUE(WaitAndSendFrame(1000 / fps));
1390 EXPECT_FRAME_WAIT(frame + i * fps, kVideoWidth, kVideoHeight, kTimeout);
1391 }
1392 }
1393 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1394 EXPECT_EQ(codec.id, GetPayloadType(p.get()));
1395 }
1396
Niels Möller6557d0c2018-04-11 15:18:34 +02001397 cricket::VideoSenderInfo GetSenderStats(size_t i) {
1398 cricket::VideoMediaInfo info;
1399 EXPECT_TRUE(channel_->GetStats(&info));
1400 return info.senders[i];
1401 }
1402
1403 cricket::VideoReceiverInfo GetReceiverStats(size_t i) {
1404 cricket::VideoMediaInfo info;
1405 EXPECT_TRUE(channel_->GetStats(&info));
1406 return info.receivers[i];
1407 }
1408
1409 // Two streams one channel tests.
1410
1411 // Tests that we can send and receive frames.
1412 void TwoStreamsSendAndReceive(const cricket::VideoCodec& codec) {
1413 SetUpSecondStream();
1414 // Test sending and receiving on first stream.
1415 SendAndReceive(codec);
1416 // Test sending and receiving on second stream.
1417 EXPECT_EQ_WAIT(1, renderer2_.num_rendered_frames(), kTimeout);
1418 EXPECT_GT(NumRtpPackets(), 0);
1419 EXPECT_EQ(1, renderer2_.num_rendered_frames());
1420 }
1421
1422 cricket::VideoCodec GetEngineCodec(const std::string& name) {
1423 for (const cricket::VideoCodec& engine_codec : engine_.codecs()) {
Niels Möller039743e2018-10-23 10:07:25 +02001424 if (absl::EqualsIgnoreCase(name, engine_codec.name))
Niels Möller6557d0c2018-04-11 15:18:34 +02001425 return engine_codec;
1426 }
1427 // This point should never be reached.
1428 ADD_FAILURE() << "Unrecognized codec name: " << name;
1429 return cricket::VideoCodec();
1430 }
1431
1432 cricket::VideoCodec DefaultCodec() { return GetEngineCodec("VP8"); }
1433
1434 cricket::StreamParams DefaultSendStreamParams() {
1435 return cricket::StreamParams::CreateLegacy(kSsrc);
1436 }
1437
1438 webrtc::RtcEventLogNullImpl event_log_;
Jonas Oreland49ac5952018-09-26 16:04:32 +02001439 std::unique_ptr<webrtc::Call> call_;
Niels Möller6557d0c2018-04-11 15:18:34 +02001440 WebRtcVideoEngine engine_;
Niels Möller805a27e2019-01-21 12:21:27 +01001441
1442 std::unique_ptr<cricket::FakeFrameSource> frame_source_;
1443 std::unique_ptr<webrtc::test::FrameForwarder> frame_forwarder_;
1444 std::unique_ptr<webrtc::test::FrameForwarder> frame_forwarder_2_;
1445
Niels Möller6557d0c2018-04-11 15:18:34 +02001446 std::unique_ptr<WebRtcVideoChannel> channel_;
1447 cricket::FakeNetworkInterface network_interface_;
1448 cricket::FakeVideoRenderer renderer_;
1449
1450 // Used by test cases where 2 streams are run on the same channel.
1451 cricket::FakeVideoRenderer renderer2_;
1452};
1453
1454// Test that SetSend works.
srtee0c2eea2017-12-15 17:44:33 +01001455TEST_F(WebRtcVideoChannelBaseTest, SetSend) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001456 EXPECT_FALSE(channel_->sending());
Niels Möller805a27e2019-01-21 12:21:27 +01001457 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, frame_forwarder_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001458 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1459 EXPECT_FALSE(channel_->sending());
1460 EXPECT_TRUE(SetSend(true));
1461 EXPECT_TRUE(channel_->sending());
Niels Möller805a27e2019-01-21 12:21:27 +01001462 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001463 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
1464 EXPECT_TRUE(SetSend(false));
1465 EXPECT_FALSE(channel_->sending());
srtee0c2eea2017-12-15 17:44:33 +01001466}
Niels Möller6557d0c2018-04-11 15:18:34 +02001467
1468// Test that SetSend fails without codecs being set.
srtee0c2eea2017-12-15 17:44:33 +01001469TEST_F(WebRtcVideoChannelBaseTest, SetSendWithoutCodecs) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001470 EXPECT_FALSE(channel_->sending());
1471 EXPECT_FALSE(SetSend(true));
1472 EXPECT_FALSE(channel_->sending());
srtee0c2eea2017-12-15 17:44:33 +01001473}
Niels Möller6557d0c2018-04-11 15:18:34 +02001474
1475// Test that we properly set the send and recv buffer sizes by the time
1476// SetSend is called.
srtee0c2eea2017-12-15 17:44:33 +01001477TEST_F(WebRtcVideoChannelBaseTest, SetSendSetsTransportBufferSizes) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001478 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1479 EXPECT_TRUE(SetSend(true));
1480 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
Johannes Krond38a2b82018-10-23 11:31:19 +02001481 EXPECT_EQ(256 * 1024, network_interface_.recvbuf_size());
Erik Språng820ebd02018-08-20 17:14:25 +02001482}
1483
Niels Möller6557d0c2018-04-11 15:18:34 +02001484// Test that stats work properly for a 1-1 call.
srtee0c2eea2017-12-15 17:44:33 +01001485TEST_F(WebRtcVideoChannelBaseTest, GetStats) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001486 const int kDurationSec = 3;
1487 const int kFps = 10;
1488 SendReceiveManyAndGetStats(DefaultCodec(), kDurationSec, kFps);
1489
1490 cricket::VideoMediaInfo info;
1491 EXPECT_TRUE(channel_->GetStats(&info));
1492
1493 ASSERT_EQ(1U, info.senders.size());
1494 // TODO(whyuan): bytes_sent and bytes_rcvd are different. Are both payload?
1495 // For webrtc, bytes_sent does not include the RTP header length.
1496 EXPECT_GT(info.senders[0].bytes_sent, 0);
1497 EXPECT_EQ(NumRtpPackets(), info.senders[0].packets_sent);
1498 EXPECT_EQ(0.0, info.senders[0].fraction_lost);
1499 ASSERT_TRUE(info.senders[0].codec_payload_type);
1500 EXPECT_EQ(DefaultCodec().id, *info.senders[0].codec_payload_type);
1501 EXPECT_EQ(0, info.senders[0].firs_rcvd);
1502 EXPECT_EQ(0, info.senders[0].plis_rcvd);
1503 EXPECT_EQ(0, info.senders[0].nacks_rcvd);
1504 EXPECT_EQ(kVideoWidth, info.senders[0].send_frame_width);
1505 EXPECT_EQ(kVideoHeight, info.senders[0].send_frame_height);
1506 EXPECT_GT(info.senders[0].framerate_input, 0);
1507 EXPECT_GT(info.senders[0].framerate_sent, 0);
1508
1509 EXPECT_EQ(1U, info.send_codecs.count(DefaultCodec().id));
1510 EXPECT_EQ(DefaultCodec().ToCodecParameters(),
1511 info.send_codecs[DefaultCodec().id]);
1512
1513 ASSERT_EQ(1U, info.receivers.size());
1514 EXPECT_EQ(1U, info.senders[0].ssrcs().size());
1515 EXPECT_EQ(1U, info.receivers[0].ssrcs().size());
1516 EXPECT_EQ(info.senders[0].ssrcs()[0], info.receivers[0].ssrcs()[0]);
1517 ASSERT_TRUE(info.receivers[0].codec_payload_type);
1518 EXPECT_EQ(DefaultCodec().id, *info.receivers[0].codec_payload_type);
1519 EXPECT_EQ(NumRtpBytes(), info.receivers[0].bytes_rcvd);
1520 EXPECT_EQ(NumRtpPackets(), info.receivers[0].packets_rcvd);
1521 EXPECT_EQ(0.0, info.receivers[0].fraction_lost);
1522 EXPECT_EQ(0, info.receivers[0].packets_lost);
1523 // TODO(asapersson): Not set for webrtc. Handle missing stats.
1524 // EXPECT_EQ(0, info.receivers[0].packets_concealed);
1525 EXPECT_EQ(0, info.receivers[0].firs_sent);
1526 EXPECT_EQ(0, info.receivers[0].plis_sent);
1527 EXPECT_EQ(0, info.receivers[0].nacks_sent);
1528 EXPECT_EQ(kVideoWidth, info.receivers[0].frame_width);
1529 EXPECT_EQ(kVideoHeight, info.receivers[0].frame_height);
1530 EXPECT_GT(info.receivers[0].framerate_rcvd, 0);
1531 EXPECT_GT(info.receivers[0].framerate_decoded, 0);
1532 EXPECT_GT(info.receivers[0].framerate_output, 0);
1533
1534 EXPECT_EQ(1U, info.receive_codecs.count(DefaultCodec().id));
1535 EXPECT_EQ(DefaultCodec().ToCodecParameters(),
1536 info.receive_codecs[DefaultCodec().id]);
srtee0c2eea2017-12-15 17:44:33 +01001537}
Niels Möller6557d0c2018-04-11 15:18:34 +02001538
1539// Test that stats work properly for a conf call with multiple recv streams.
srtee0c2eea2017-12-15 17:44:33 +01001540TEST_F(WebRtcVideoChannelBaseTest, GetStatsMultipleRecvStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001541 cricket::FakeVideoRenderer renderer1, renderer2;
1542 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1543 cricket::VideoSendParameters parameters;
1544 parameters.codecs.push_back(DefaultCodec());
1545 parameters.conference_mode = true;
1546 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1547 EXPECT_TRUE(SetSend(true));
Yves Gerey665174f2018-06-19 15:03:05 +02001548 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
1549 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001550 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
1551 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
1552 EXPECT_EQ(0, renderer1.num_rendered_frames());
1553 EXPECT_EQ(0, renderer2.num_rendered_frames());
1554 std::vector<uint32_t> ssrcs;
1555 ssrcs.push_back(1);
1556 ssrcs.push_back(2);
1557 network_interface_.SetConferenceMode(true, ssrcs);
Niels Möller805a27e2019-01-21 12:21:27 +01001558 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001559 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kVideoWidth, kVideoHeight,
1560 kTimeout);
1561 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kVideoWidth, kVideoHeight,
1562 kTimeout);
1563
1564 EXPECT_TRUE(channel_->SetSend(false));
1565
1566 cricket::VideoMediaInfo info;
1567 EXPECT_TRUE(channel_->GetStats(&info));
1568 ASSERT_EQ(1U, info.senders.size());
1569 // TODO(whyuan): bytes_sent and bytes_rcvd are different. Are both payload?
1570 // For webrtc, bytes_sent does not include the RTP header length.
1571 EXPECT_GT(GetSenderStats(0).bytes_sent, 0);
1572 EXPECT_EQ_WAIT(NumRtpPackets(), GetSenderStats(0).packets_sent, kTimeout);
1573 EXPECT_EQ(kVideoWidth, GetSenderStats(0).send_frame_width);
1574 EXPECT_EQ(kVideoHeight, GetSenderStats(0).send_frame_height);
1575
1576 ASSERT_EQ(2U, info.receivers.size());
1577 for (size_t i = 0; i < info.receivers.size(); ++i) {
1578 EXPECT_EQ(1U, GetReceiverStats(i).ssrcs().size());
1579 EXPECT_EQ(i + 1, GetReceiverStats(i).ssrcs()[0]);
1580 EXPECT_EQ_WAIT(NumRtpBytes(), GetReceiverStats(i).bytes_rcvd, kTimeout);
Yves Gerey665174f2018-06-19 15:03:05 +02001581 EXPECT_EQ_WAIT(NumRtpPackets(), GetReceiverStats(i).packets_rcvd, kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001582 EXPECT_EQ_WAIT(kVideoWidth, GetReceiverStats(i).frame_width, kTimeout);
1583 EXPECT_EQ_WAIT(kVideoHeight, GetReceiverStats(i).frame_height, kTimeout);
1584 }
srtee0c2eea2017-12-15 17:44:33 +01001585}
Niels Möller6557d0c2018-04-11 15:18:34 +02001586
1587// Test that stats work properly for a conf call with multiple send streams.
srtee0c2eea2017-12-15 17:44:33 +01001588TEST_F(WebRtcVideoChannelBaseTest, GetStatsMultipleSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001589 // Normal setup; note that we set the SSRC explicitly to ensure that
1590 // it will come first in the senders map.
1591 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1592 cricket::VideoSendParameters parameters;
1593 parameters.codecs.push_back(DefaultCodec());
1594 parameters.conference_mode = true;
1595 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Yves Gerey665174f2018-06-19 15:03:05 +02001596 EXPECT_TRUE(
1597 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001598 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
1599 EXPECT_TRUE(SetSend(true));
Niels Möller805a27e2019-01-21 12:21:27 +01001600 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001601 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
1602 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1603
1604 // Add an additional capturer, and hook up a renderer to receive it.
1605 cricket::FakeVideoRenderer renderer2;
Niels Möller805a27e2019-01-21 12:21:27 +01001606 webrtc::test::FrameForwarder frame_forwarder;
Niels Möller6557d0c2018-04-11 15:18:34 +02001607 const int kTestWidth = 160;
1608 const int kTestHeight = 120;
Niels Möller805a27e2019-01-21 12:21:27 +01001609 cricket::FakeFrameSource frame_source(kTestWidth, kTestHeight,
1610 rtc::kNumMicrosecsPerSec / 5);
Yves Gerey665174f2018-06-19 15:03:05 +02001611 EXPECT_TRUE(
1612 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(5678)));
Niels Möller805a27e2019-01-21 12:21:27 +01001613 EXPECT_TRUE(channel_->SetVideoSend(5678, nullptr, &frame_forwarder));
Yves Gerey665174f2018-06-19 15:03:05 +02001614 EXPECT_TRUE(
1615 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(5678)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001616 EXPECT_TRUE(channel_->SetSink(5678, &renderer2));
Niels Möller805a27e2019-01-21 12:21:27 +01001617 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Yves Gerey665174f2018-06-19 15:03:05 +02001618 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kTestWidth, kTestHeight,
1619 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001620
1621 // Get stats, and make sure they are correct for two senders. We wait until
1622 // the number of expected packets have been sent to avoid races where we
1623 // check stats before it has been updated.
1624 cricket::VideoMediaInfo info;
1625 for (uint32_t i = 0; i < kTimeout; ++i) {
1626 rtc::Thread::Current()->ProcessMessages(1);
1627 EXPECT_TRUE(channel_->GetStats(&info));
1628 ASSERT_EQ(2U, info.senders.size());
1629 if (info.senders[0].packets_sent + info.senders[1].packets_sent ==
1630 NumRtpPackets()) {
1631 // Stats have been updated for both sent frames, expectations can be
1632 // checked now.
1633 break;
1634 }
1635 }
1636 EXPECT_EQ(NumRtpPackets(),
1637 info.senders[0].packets_sent + info.senders[1].packets_sent)
1638 << "Timed out while waiting for packet counts for all sent packets.";
1639 EXPECT_EQ(1U, info.senders[0].ssrcs().size());
1640 EXPECT_EQ(1234U, info.senders[0].ssrcs()[0]);
1641 EXPECT_EQ(kVideoWidth, info.senders[0].send_frame_width);
1642 EXPECT_EQ(kVideoHeight, info.senders[0].send_frame_height);
1643 EXPECT_EQ(1U, info.senders[1].ssrcs().size());
1644 EXPECT_EQ(5678U, info.senders[1].ssrcs()[0]);
1645 EXPECT_EQ(kTestWidth, info.senders[1].send_frame_width);
1646 EXPECT_EQ(kTestHeight, info.senders[1].send_frame_height);
1647 // The capturer must be unregistered here as it runs out of it's scope next.
1648 channel_->SetVideoSend(5678, nullptr, nullptr);
srtee0c2eea2017-12-15 17:44:33 +01001649}
pbos@webrtc.org8fdeee62014-07-20 14:40:23 +00001650
Niels Möller6557d0c2018-04-11 15:18:34 +02001651// Test that we can set the bandwidth.
srtee0c2eea2017-12-15 17:44:33 +01001652TEST_F(WebRtcVideoChannelBaseTest, SetSendBandwidth) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001653 cricket::VideoSendParameters parameters;
1654 parameters.codecs.push_back(DefaultCodec());
1655 parameters.max_bandwidth_bps = -1; // <= 0 means unlimited.
1656 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1657 parameters.max_bandwidth_bps = 128 * 1024;
1658 EXPECT_TRUE(channel_->SetSendParameters(parameters));
srtee0c2eea2017-12-15 17:44:33 +01001659}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001660
Niels Möller6557d0c2018-04-11 15:18:34 +02001661// Test that we can set the SSRC for the default send source.
srtee0c2eea2017-12-15 17:44:33 +01001662TEST_F(WebRtcVideoChannelBaseTest, SetSendSsrc) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001663 EXPECT_TRUE(SetDefaultCodec());
1664 EXPECT_TRUE(SetSend(true));
Niels Möller805a27e2019-01-21 12:21:27 +01001665 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001666 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001667 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001668 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001669 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1670 EXPECT_EQ(kSsrc, header.ssrc);
1671
Niels Möller6557d0c2018-04-11 15:18:34 +02001672 // Packets are being paced out, so these can mismatch between the first and
1673 // second call to NumRtpPackets until pending packets are paced out.
Åsa Persson23cd45a2018-07-03 10:40:40 +02001674 EXPECT_EQ_WAIT(NumRtpPackets(), NumRtpPackets(header.ssrc), kTimeout);
1675 EXPECT_EQ_WAIT(NumRtpBytes(), NumRtpBytes(header.ssrc), kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001676 EXPECT_EQ(1, NumSentSsrcs());
1677 EXPECT_EQ(0, NumRtpPackets(kSsrc - 1));
1678 EXPECT_EQ(0, NumRtpBytes(kSsrc - 1));
srtee0c2eea2017-12-15 17:44:33 +01001679}
Niels Möller6557d0c2018-04-11 15:18:34 +02001680
1681// Test that we can set the SSRC even after codecs are set.
srtee0c2eea2017-12-15 17:44:33 +01001682TEST_F(WebRtcVideoChannelBaseTest, SetSendSsrcAfterSetCodecs) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001683 // Remove stream added in Setup.
1684 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1685 EXPECT_TRUE(SetDefaultCodec());
Niels Möller6557d0c2018-04-11 15:18:34 +02001686 EXPECT_TRUE(
Yves Gerey665174f2018-06-19 15:03:05 +02001687 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(999)));
Niels Möller805a27e2019-01-21 12:21:27 +01001688 EXPECT_TRUE(channel_->SetVideoSend(999u, nullptr, frame_forwarder_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001689 EXPECT_TRUE(SetSend(true));
1690 EXPECT_TRUE(WaitAndSendFrame(0));
1691 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001692 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001693 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001694 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1695 EXPECT_EQ(999u, header.ssrc);
Niels Möller6557d0c2018-04-11 15:18:34 +02001696 // Packets are being paced out, so these can mismatch between the first and
1697 // second call to NumRtpPackets until pending packets are paced out.
Åsa Persson23cd45a2018-07-03 10:40:40 +02001698 EXPECT_EQ_WAIT(NumRtpPackets(), NumRtpPackets(header.ssrc), kTimeout);
1699 EXPECT_EQ_WAIT(NumRtpBytes(), NumRtpBytes(header.ssrc), kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001700 EXPECT_EQ(1, NumSentSsrcs());
1701 EXPECT_EQ(0, NumRtpPackets(kSsrc));
1702 EXPECT_EQ(0, NumRtpBytes(kSsrc));
srtee0c2eea2017-12-15 17:44:33 +01001703}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001704
Niels Möller6557d0c2018-04-11 15:18:34 +02001705// Test that we can set the default video renderer before and after
1706// media is received.
srtee0c2eea2017-12-15 17:44:33 +01001707TEST_F(WebRtcVideoChannelBaseTest, SetSink) {
Yves Gerey665174f2018-06-19 15:03:05 +02001708 uint8_t data1[] = {0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
1709 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
Niels Möller6557d0c2018-04-11 15:18:34 +02001710
1711 rtc::CopyOnWriteBuffer packet1(data1, sizeof(data1));
1712 rtc::SetBE32(packet1.data() + 8, kSsrc);
1713 channel_->SetSink(kDefaultReceiveSsrc, NULL);
1714 EXPECT_TRUE(SetDefaultCodec());
1715 EXPECT_TRUE(SetSend(true));
1716 EXPECT_EQ(0, renderer_.num_rendered_frames());
Niels Möllere6933812018-11-05 13:01:41 +01001717 channel_->OnPacketReceived(&packet1, /* packet_time_us */ -1);
Niels Möller6557d0c2018-04-11 15:18:34 +02001718 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
Niels Möller805a27e2019-01-21 12:21:27 +01001719 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001720 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
srtee0c2eea2017-12-15 17:44:33 +01001721}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001722
Niels Möller6557d0c2018-04-11 15:18:34 +02001723// Tests setting up and configuring a send stream.
srtee0c2eea2017-12-15 17:44:33 +01001724TEST_F(WebRtcVideoChannelBaseTest, AddRemoveSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001725 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1726 EXPECT_TRUE(SetSend(true));
1727 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
Niels Möller805a27e2019-01-21 12:21:27 +01001728 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001729 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1730 EXPECT_GT(NumRtpPackets(), 0);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001731 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001732 size_t last_packet = NumRtpPackets() - 1;
Yves Gerey665174f2018-06-19 15:03:05 +02001733 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(
1734 GetRtpPacket(static_cast<int>(last_packet)));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001735 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1736 EXPECT_EQ(kSsrc, header.ssrc);
Niels Möller6557d0c2018-04-11 15:18:34 +02001737
1738 // Remove the send stream that was added during Setup.
1739 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1740 int rtp_packets = NumRtpPackets();
1741
Niels Möller6557d0c2018-04-11 15:18:34 +02001742 EXPECT_TRUE(
Yves Gerey665174f2018-06-19 15:03:05 +02001743 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(789u)));
Niels Möller805a27e2019-01-21 12:21:27 +01001744 EXPECT_TRUE(channel_->SetVideoSend(789u, nullptr, frame_forwarder_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001745 EXPECT_EQ(rtp_packets, NumRtpPackets());
1746 // Wait 30ms to guarantee the engine does not drop the frame.
1747 EXPECT_TRUE(WaitAndSendFrame(30));
1748 EXPECT_TRUE_WAIT(NumRtpPackets() > rtp_packets, kTimeout);
1749
1750 last_packet = NumRtpPackets() - 1;
1751 p.reset(GetRtpPacket(static_cast<int>(last_packet)));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001752 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1753 EXPECT_EQ(789u, header.ssrc);
srtee0c2eea2017-12-15 17:44:33 +01001754}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001755
Niels Möller6557d0c2018-04-11 15:18:34 +02001756// Tests the behavior of incoming streams in a conference scenario.
srtee0c2eea2017-12-15 17:44:33 +01001757TEST_F(WebRtcVideoChannelBaseTest, SimulateConference) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001758 cricket::FakeVideoRenderer renderer1, renderer2;
1759 EXPECT_TRUE(SetDefaultCodec());
1760 cricket::VideoSendParameters parameters;
1761 parameters.codecs.push_back(DefaultCodec());
1762 parameters.conference_mode = true;
1763 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1764 EXPECT_TRUE(SetSend(true));
Yves Gerey665174f2018-06-19 15:03:05 +02001765 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
1766 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001767 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
1768 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
1769 EXPECT_EQ(0, renderer1.num_rendered_frames());
1770 EXPECT_EQ(0, renderer2.num_rendered_frames());
1771 std::vector<uint32_t> ssrcs;
1772 ssrcs.push_back(1);
1773 ssrcs.push_back(2);
1774 network_interface_.SetConferenceMode(true, ssrcs);
Niels Möller805a27e2019-01-21 12:21:27 +01001775 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001776 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kVideoWidth, kVideoHeight,
1777 kTimeout);
1778 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kVideoWidth, kVideoHeight,
1779 kTimeout);
1780
1781 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1782 EXPECT_EQ(DefaultCodec().id, GetPayloadType(p.get()));
1783 EXPECT_EQ(kVideoWidth, renderer1.width());
1784 EXPECT_EQ(kVideoHeight, renderer1.height());
1785 EXPECT_EQ(kVideoWidth, renderer2.width());
1786 EXPECT_EQ(kVideoHeight, renderer2.height());
1787 EXPECT_TRUE(channel_->RemoveRecvStream(2));
1788 EXPECT_TRUE(channel_->RemoveRecvStream(1));
srtee0c2eea2017-12-15 17:44:33 +01001789}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001790
Niels Möller6557d0c2018-04-11 15:18:34 +02001791// Tests that we can add and remove capturers and frames are sent out properly
srtee0c2eea2017-12-15 17:44:33 +01001792TEST_F(WebRtcVideoChannelBaseTest, DISABLED_AddRemoveCapturer) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001793 using cricket::VideoCodec;
1794 using cricket::VideoOptions;
1795 using cricket::VideoFormat;
1796 using cricket::FOURCC_I420;
1797
1798 VideoCodec codec = DefaultCodec();
1799 const int time_between_send_ms = VideoFormat::FpsToInterval(kFramerate);
1800 EXPECT_TRUE(SetOneCodec(codec));
1801 EXPECT_TRUE(SetSend(true));
1802 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1803 EXPECT_EQ(0, renderer_.num_rendered_frames());
Niels Möller805a27e2019-01-21 12:21:27 +01001804 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001805 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
Niels Möller805a27e2019-01-21 12:21:27 +01001806
1807 webrtc::test::FrameForwarder frame_forwarder;
1808 cricket::FakeFrameSource frame_source(480, 360, rtc::kNumMicrosecsPerSec / 30,
1809 rtc::kNumMicrosecsPerSec / 30);
Niels Möller6557d0c2018-04-11 15:18:34 +02001810
1811 // TODO(nisse): This testcase fails if we don't configure
1812 // screencast. It's unclear why, I see nothing obvious in this
1813 // test which is related to screencast logic.
1814 VideoOptions video_options;
1815 video_options.is_screencast = true;
1816 channel_->SetVideoSend(kSsrc, &video_options, nullptr);
1817
Niels Möller6557d0c2018-04-11 15:18:34 +02001818 int captured_frames = 1;
1819 for (int iterations = 0; iterations < 2; ++iterations) {
Niels Möller805a27e2019-01-21 12:21:27 +01001820 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
Niels Möller6557d0c2018-04-11 15:18:34 +02001821 rtc::Thread::Current()->ProcessMessages(time_between_send_ms);
Niels Möller805a27e2019-01-21 12:21:27 +01001822 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
1823
Niels Möller6557d0c2018-04-11 15:18:34 +02001824 ++captured_frames;
1825 // Wait until frame of right size is captured.
1826 EXPECT_TRUE_WAIT(renderer_.num_rendered_frames() >= captured_frames &&
Niels Möller805a27e2019-01-21 12:21:27 +01001827 480 == renderer_.width() &&
1828 360 == renderer_.height() && !renderer_.black_frame(),
Yves Gerey665174f2018-06-19 15:03:05 +02001829 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001830 EXPECT_GE(renderer_.num_rendered_frames(), captured_frames);
Niels Möller805a27e2019-01-21 12:21:27 +01001831 EXPECT_EQ(480, renderer_.width());
1832 EXPECT_EQ(360, renderer_.height());
Niels Möller6557d0c2018-04-11 15:18:34 +02001833 captured_frames = renderer_.num_rendered_frames() + 1;
1834 EXPECT_FALSE(renderer_.black_frame());
1835 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1836 // Make sure a black frame is generated within the specified timeout.
1837 // The black frame should be the resolution of the previous frame to
1838 // prevent expensive encoder reconfigurations.
1839 EXPECT_TRUE_WAIT(renderer_.num_rendered_frames() >= captured_frames &&
Niels Möller805a27e2019-01-21 12:21:27 +01001840 480 == renderer_.width() &&
1841 360 == renderer_.height() && renderer_.black_frame(),
Yves Gerey665174f2018-06-19 15:03:05 +02001842 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001843 EXPECT_GE(renderer_.num_rendered_frames(), captured_frames);
Niels Möller805a27e2019-01-21 12:21:27 +01001844 EXPECT_EQ(480, renderer_.width());
1845 EXPECT_EQ(360, renderer_.height());
Niels Möller6557d0c2018-04-11 15:18:34 +02001846 EXPECT_TRUE(renderer_.black_frame());
1847
1848 // The black frame has the same timestamp as the next frame since it's
1849 // timestamp is set to the last frame's timestamp + interval. WebRTC will
1850 // not render a frame with the same timestamp so capture another frame
1851 // with the frame capturer to increment the next frame's timestamp.
Niels Möller805a27e2019-01-21 12:21:27 +01001852 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller6557d0c2018-04-11 15:18:34 +02001853 }
srtee0c2eea2017-12-15 17:44:33 +01001854}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001855
Niels Möller6557d0c2018-04-11 15:18:34 +02001856// Tests that if SetVideoSend is called with a NULL capturer after the
1857// capturer was already removed, the application doesn't crash (and no black
1858// frame is sent).
srtee0c2eea2017-12-15 17:44:33 +01001859TEST_F(WebRtcVideoChannelBaseTest, RemoveCapturerWithoutAdd) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001860 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1861 EXPECT_TRUE(SetSend(true));
1862 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1863 EXPECT_EQ(0, renderer_.num_rendered_frames());
Niels Möller805a27e2019-01-21 12:21:27 +01001864 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001865 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1866 // Wait for one frame so they don't get dropped because we send frames too
1867 // tightly.
1868 rtc::Thread::Current()->ProcessMessages(30);
1869 // Remove the capturer.
1870 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1871
1872 // No capturer was added, so this SetVideoSend shouldn't do anything.
1873 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1874 rtc::Thread::Current()->ProcessMessages(300);
1875 // Verify no more frames were sent.
1876 EXPECT_EQ(1, renderer_.num_rendered_frames());
srtee0c2eea2017-12-15 17:44:33 +01001877}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001878
Niels Möller6557d0c2018-04-11 15:18:34 +02001879// Tests that we can add and remove capturer as unique sources.
srtee0c2eea2017-12-15 17:44:33 +01001880TEST_F(WebRtcVideoChannelBaseTest, AddRemoveCapturerMultipleSources) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001881 // WebRTC implementation will drop frames if pushed to quickly. Wait the
1882 // interval time to avoid that.
1883 // WebRTC implementation will drop frames if pushed to quickly. Wait the
1884 // interval time to avoid that.
1885 // Set up the stream associated with the engine.
Yves Gerey665174f2018-06-19 15:03:05 +02001886 EXPECT_TRUE(
1887 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001888 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
1889 cricket::VideoFormat capture_format(
1890 kVideoWidth, kVideoHeight,
1891 cricket::VideoFormat::FpsToInterval(kFramerate), cricket::FOURCC_I420);
1892 // Set up additional stream 1.
1893 cricket::FakeVideoRenderer renderer1;
1894 EXPECT_FALSE(channel_->SetSink(1, &renderer1));
Yves Gerey665174f2018-06-19 15:03:05 +02001895 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001896 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
Yves Gerey665174f2018-06-19 15:03:05 +02001897 EXPECT_TRUE(channel_->AddSendStream(cricket::StreamParams::CreateLegacy(1)));
Niels Möller805a27e2019-01-21 12:21:27 +01001898
1899 webrtc::test::FrameForwarder frame_forwarder1;
1900 cricket::FakeFrameSource frame_source(kVideoWidth, kVideoHeight,
1901 rtc::kNumMicrosecsPerSec / kFramerate);
1902
Niels Möller6557d0c2018-04-11 15:18:34 +02001903 // Set up additional stream 2.
1904 cricket::FakeVideoRenderer renderer2;
1905 EXPECT_FALSE(channel_->SetSink(2, &renderer2));
Yves Gerey665174f2018-06-19 15:03:05 +02001906 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001907 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
Yves Gerey665174f2018-06-19 15:03:05 +02001908 EXPECT_TRUE(channel_->AddSendStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller805a27e2019-01-21 12:21:27 +01001909 webrtc::test::FrameForwarder frame_forwarder2;
1910
Niels Möller6557d0c2018-04-11 15:18:34 +02001911 // State for all the streams.
1912 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1913 // A limitation in the lmi implementation requires that SetVideoSend() is
1914 // called after SetOneCodec().
1915 // TODO(hellner): this seems like an unnecessary constraint, fix it.
Niels Möller805a27e2019-01-21 12:21:27 +01001916 EXPECT_TRUE(channel_->SetVideoSend(1, nullptr, &frame_forwarder1));
1917 EXPECT_TRUE(channel_->SetVideoSend(2, nullptr, &frame_forwarder2));
Niels Möller6557d0c2018-04-11 15:18:34 +02001918 EXPECT_TRUE(SetSend(true));
1919 // Test capturer associated with engine.
1920 const int kTestWidth = 160;
1921 const int kTestHeight = 120;
Niels Möller805a27e2019-01-21 12:21:27 +01001922 frame_forwarder1.IncomingCapturedFrame(frame_source.GetFrame(
1923 kTestWidth, kTestHeight, webrtc::VideoRotation::kVideoRotation_0,
1924 rtc::kNumMicrosecsPerSec / kFramerate));
Yves Gerey665174f2018-06-19 15:03:05 +02001925 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kTestWidth, kTestHeight,
1926 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001927 // Capture a frame with additional capturer2, frames should be received
Niels Möller805a27e2019-01-21 12:21:27 +01001928 frame_forwarder2.IncomingCapturedFrame(frame_source.GetFrame(
1929 kTestWidth, kTestHeight, webrtc::VideoRotation::kVideoRotation_0,
1930 rtc::kNumMicrosecsPerSec / kFramerate));
Yves Gerey665174f2018-06-19 15:03:05 +02001931 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kTestWidth, kTestHeight,
1932 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001933 // Successfully remove the capturer.
1934 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1935 // The capturers must be unregistered here as it runs out of it's scope
1936 // next.
1937 EXPECT_TRUE(channel_->SetVideoSend(1, nullptr, nullptr));
1938 EXPECT_TRUE(channel_->SetVideoSend(2, nullptr, nullptr));
srtee0c2eea2017-12-15 17:44:33 +01001939}
Niels Möller6557d0c2018-04-11 15:18:34 +02001940
1941// Tests empty StreamParams is rejected.
srtee0c2eea2017-12-15 17:44:33 +01001942TEST_F(WebRtcVideoChannelBaseTest, RejectEmptyStreamParams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001943 // Remove the send stream that was added during Setup.
1944 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1945
1946 cricket::StreamParams empty;
1947 EXPECT_FALSE(channel_->AddSendStream(empty));
Yves Gerey665174f2018-06-19 15:03:05 +02001948 EXPECT_TRUE(
1949 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(789u)));
srtee0c2eea2017-12-15 17:44:33 +01001950}
Niels Möller6557d0c2018-04-11 15:18:34 +02001951
1952// Test that multiple send streams can be created and deleted properly.
srtee0c2eea2017-12-15 17:44:33 +01001953TEST_F(WebRtcVideoChannelBaseTest, MultipleSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001954 // Remove stream added in Setup. I.e. remove stream corresponding to default
1955 // channel.
1956 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02001957 const unsigned int kSsrcsSize = sizeof(kSsrcs4) / sizeof(kSsrcs4[0]);
Niels Möller6557d0c2018-04-11 15:18:34 +02001958 for (unsigned int i = 0; i < kSsrcsSize; ++i) {
1959 EXPECT_TRUE(channel_->AddSendStream(
1960 cricket::StreamParams::CreateLegacy(kSsrcs4[i])));
1961 }
1962 // Delete one of the non default channel streams, let the destructor delete
1963 // the remaining ones.
1964 EXPECT_TRUE(channel_->RemoveSendStream(kSsrcs4[kSsrcsSize - 1]));
1965 // Stream should already be deleted.
1966 EXPECT_FALSE(channel_->RemoveSendStream(kSsrcs4[kSsrcsSize - 1]));
srtee0c2eea2017-12-15 17:44:33 +01001967}
pbos@webrtc.orgc4175b92014-09-03 15:25:49 +00001968
eladalonf1841382017-06-12 01:16:46 -07001969TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8Vga) {
magjed509e4fe2016-11-18 01:34:11 -08001970 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00001971}
1972
eladalonf1841382017-06-12 01:16:46 -07001973TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8Qvga) {
magjed509e4fe2016-11-18 01:34:11 -08001974 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00001975}
1976
eladalonf1841382017-06-12 01:16:46 -07001977TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8SvcQqvga) {
magjed509e4fe2016-11-18 01:34:11 -08001978 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00001979}
1980
eladalonf1841382017-06-12 01:16:46 -07001981TEST_F(WebRtcVideoChannelBaseTest, TwoStreamsSendAndReceive) {
Peter Boströmd1f584b2016-04-20 16:31:53 +02001982 // Set a high bitrate to not be downscaled by VP8 due to low initial start
1983 // bitrates. This currently happens at <250k, and two streams sharing 300k
1984 // initially will use QVGA instead of VGA.
1985 // TODO(pbos): Set up the quality scaler so that both senders reliably start
1986 // at QVGA, then verify that instead.
magjed509e4fe2016-11-18 01:34:11 -08001987 cricket::VideoCodec codec = GetEngineCodec("VP8");
Peter Boströmd1f584b2016-04-20 16:31:53 +02001988 codec.params[kCodecParamStartBitrate] = "1000000";
Niels Möller6557d0c2018-04-11 15:18:34 +02001989 TwoStreamsSendAndReceive(codec);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001990}
1991
eladalonf1841382017-06-12 01:16:46 -07001992class WebRtcVideoChannelTest : public WebRtcVideoEngineTest {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001993 public:
eladalonf1841382017-06-12 01:16:46 -07001994 WebRtcVideoChannelTest() : WebRtcVideoChannelTest("") {}
1995 explicit WebRtcVideoChannelTest(const char* field_trials)
Niels Möller805a27e2019-01-21 12:21:27 +01001996 : WebRtcVideoEngineTest(field_trials),
1997 frame_source_(1280, 720, rtc::kNumMicrosecsPerSec / 30),
1998 last_ssrc_(0) {}
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00001999 void SetUp() override {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02002000 encoder_factory_->AddSupportedVideoCodecType("VP8");
2001 encoder_factory_->AddSupportedVideoCodecType("VP9");
2002#if defined(WEBRTC_USE_H264)
2003 encoder_factory_->AddSupportedVideoCodecType("H264");
2004#endif
2005
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002006 fake_call_.reset(new FakeCall());
Sebastian Jansson84848f22018-11-16 10:40:36 +01002007 channel_.reset(engine_.CreateMediaChannel(fake_call_.get(),
2008 GetMediaConfig(), VideoOptions(),
2009 webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002010 channel_->OnReadyToSend(true);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002011 last_ssrc_ = 123;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002012 send_parameters_.codecs = engine_.codecs();
2013 recv_parameters_.codecs = engine_.codecs();
2014 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002015 }
2016
2017 protected:
2018 FakeVideoSendStream* AddSendStream() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002019 return AddSendStream(StreamParams::CreateLegacy(++last_ssrc_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002020 }
2021
2022 FakeVideoSendStream* AddSendStream(const StreamParams& sp) {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002023 size_t num_streams = fake_call_->GetVideoSendStreams().size();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002024 EXPECT_TRUE(channel_->AddSendStream(sp));
2025 std::vector<FakeVideoSendStream*> streams =
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002026 fake_call_->GetVideoSendStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002027 EXPECT_EQ(num_streams + 1, streams.size());
2028 return streams[streams.size() - 1];
2029 }
2030
2031 std::vector<FakeVideoSendStream*> GetFakeSendStreams() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002032 return fake_call_->GetVideoSendStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002033 }
2034
2035 FakeVideoReceiveStream* AddRecvStream() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002036 return AddRecvStream(StreamParams::CreateLegacy(++last_ssrc_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002037 }
2038
2039 FakeVideoReceiveStream* AddRecvStream(const StreamParams& sp) {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002040 size_t num_streams = fake_call_->GetVideoReceiveStreams().size();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002041 EXPECT_TRUE(channel_->AddRecvStream(sp));
2042 std::vector<FakeVideoReceiveStream*> streams =
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002043 fake_call_->GetVideoReceiveStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002044 EXPECT_EQ(num_streams + 1, streams.size());
2045 return streams[streams.size() - 1];
2046 }
2047
pbos@webrtc.org00873182014-11-25 14:03:34 +00002048 void SetSendCodecsShouldWorkForBitrates(const char* min_bitrate_kbps,
2049 int expected_min_bitrate_bps,
2050 const char* start_bitrate_kbps,
2051 int expected_start_bitrate_bps,
2052 const char* max_bitrate_kbps,
2053 int expected_max_bitrate_bps) {
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002054 ExpectSetBitrateParameters(expected_min_bitrate_bps,
2055 expected_start_bitrate_bps,
2056 expected_max_bitrate_bps);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002057 auto& codecs = send_parameters_.codecs;
2058 codecs.clear();
magjed509e4fe2016-11-18 01:34:11 -08002059 codecs.push_back(GetEngineCodec("VP8"));
pbos@webrtc.org00873182014-11-25 14:03:34 +00002060 codecs[0].params[kCodecParamMinBitrate] = min_bitrate_kbps;
2061 codecs[0].params[kCodecParamStartBitrate] = start_bitrate_kbps;
2062 codecs[0].params[kCodecParamMaxBitrate] = max_bitrate_kbps;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002063 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002064 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002065
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002066 void ExpectSetBitrateParameters(int min_bitrate_bps,
2067 int start_bitrate_bps,
2068 int max_bitrate_bps) {
2069 EXPECT_CALL(
2070 *fake_call_->GetMockTransportControllerSend(),
2071 SetSdpBitrateParameters(AllOf(
2072 Field(&BitrateConstraints::min_bitrate_bps, min_bitrate_bps),
2073 Field(&BitrateConstraints::start_bitrate_bps, start_bitrate_bps),
2074 Field(&BitrateConstraints::max_bitrate_bps, max_bitrate_bps))));
2075 }
2076
2077 void ExpectSetMaxBitrate(int max_bitrate_bps) {
2078 EXPECT_CALL(*fake_call_->GetMockTransportControllerSend(),
2079 SetSdpBitrateParameters(Field(
2080 &BitrateConstraints::max_bitrate_bps, max_bitrate_bps)));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002081 }
2082
Johannes Kron9190b822018-10-29 11:22:05 +01002083 void TestExtmapAllowMixedCaller(bool extmap_allow_mixed) {
2084 // For a caller, the answer will be applied in set remote description
2085 // where SetSendParameters() is called.
2086 EXPECT_TRUE(
2087 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
2088 send_parameters_.extmap_allow_mixed = extmap_allow_mixed;
2089 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
2090 const webrtc::VideoSendStream::Config& config =
2091 fake_call_->GetVideoSendStreams()[0]->GetConfig();
2092 EXPECT_EQ(extmap_allow_mixed, config.rtp.extmap_allow_mixed);
2093 }
2094
2095 void TestExtmapAllowMixedCallee(bool extmap_allow_mixed) {
2096 // For a callee, the answer will be applied in set local description
2097 // where SetExtmapAllowMixed() and AddSendStream() are called.
2098 channel_->SetExtmapAllowMixed(extmap_allow_mixed);
2099 EXPECT_TRUE(
2100 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
2101 const webrtc::VideoSendStream::Config& config =
2102 fake_call_->GetVideoSendStreams()[0]->GetConfig();
2103 EXPECT_EQ(extmap_allow_mixed, config.rtp.extmap_allow_mixed);
2104 }
2105
isheriff6f8d6862016-05-26 11:24:55 -07002106 void TestSetSendRtpHeaderExtensions(const std::string& ext_uri) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002107 // Enable extension.
2108 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002109 cricket::VideoSendParameters parameters = send_parameters_;
isheriff6f8d6862016-05-26 11:24:55 -07002110 parameters.extensions.push_back(RtpExtension(ext_uri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002111 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002112 FakeVideoSendStream* send_stream =
2113 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2114
2115 // Verify the send extension id.
2116 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2117 EXPECT_EQ(id, send_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002118 EXPECT_EQ(ext_uri, send_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002119 // Verify call with same set of extensions returns true.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002120 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002121 // Verify that SetSendRtpHeaderExtensions doesn't implicitly add them for
2122 // receivers.
2123 EXPECT_TRUE(AddRecvStream(cricket::StreamParams::CreateLegacy(123))
2124 ->GetConfig()
2125 .rtp.extensions.empty());
2126
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002127 // Verify that existing RTP header extensions can be removed.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002128 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002129 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2130 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002131 EXPECT_TRUE(send_stream->GetConfig().rtp.extensions.empty());
2132
2133 // Verify that adding receive RTP header extensions adds them for existing
2134 // streams.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002135 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002136 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002137 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2138 EXPECT_EQ(id, send_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002139 EXPECT_EQ(ext_uri, send_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002140 }
2141
isheriff6f8d6862016-05-26 11:24:55 -07002142 void TestSetRecvRtpHeaderExtensions(const std::string& ext_uri) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002143 // Enable extension.
2144 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002145 cricket::VideoRecvParameters parameters = recv_parameters_;
isheriff6f8d6862016-05-26 11:24:55 -07002146 parameters.extensions.push_back(RtpExtension(ext_uri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002147 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002148
2149 FakeVideoReceiveStream* recv_stream =
2150 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2151
2152 // Verify the recv extension id.
2153 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
2154 EXPECT_EQ(id, recv_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002155 EXPECT_EQ(ext_uri, recv_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002156 // Verify call with same set of extensions returns true.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002157 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002158
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002159 // Verify that SetRecvRtpHeaderExtensions doesn't implicitly add them for
2160 // senders.
2161 EXPECT_TRUE(AddSendStream(cricket::StreamParams::CreateLegacy(123))
2162 ->GetConfig()
2163 .rtp.extensions.empty());
2164
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002165 // Verify that existing RTP header extensions can be removed.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002166 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002167 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
2168 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002169 EXPECT_TRUE(recv_stream->GetConfig().rtp.extensions.empty());
2170
2171 // Verify that adding receive RTP header extensions adds them for existing
2172 // streams.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002173 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002174 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002175 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
2176 EXPECT_EQ(id, recv_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002177 EXPECT_EQ(ext_uri, recv_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002178 }
2179
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002180 void TestExtensionFilter(const std::vector<std::string>& extensions,
2181 const std::string& expected_extension) {
2182 cricket::VideoSendParameters parameters = send_parameters_;
2183 int expected_id = -1;
2184 int id = 1;
2185 for (const std::string& extension : extensions) {
2186 if (extension == expected_extension)
2187 expected_id = id;
isheriff6f8d6862016-05-26 11:24:55 -07002188 parameters.extensions.push_back(RtpExtension(extension, id++));
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002189 }
2190 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2191 FakeVideoSendStream* send_stream =
2192 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2193
2194 // Verify that only one of them has been set, and that it is the one with
2195 // highest priority (transport sequence number).
2196 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2197 EXPECT_EQ(expected_id, send_stream->GetConfig().rtp.extensions[0].id);
2198 EXPECT_EQ(expected_extension,
isheriff6f8d6862016-05-26 11:24:55 -07002199 send_stream->GetConfig().rtp.extensions[0].uri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002200 }
2201
asapersson3c81a1a2017-06-14 05:52:21 -07002202 void TestDegradationPreference(bool resolution_scaling_enabled,
2203 bool fps_scaling_enabled);
2204
Erik Språngefbde372015-04-29 16:21:28 +02002205 void TestCpuAdaptation(bool enable_overuse, bool is_screenshare);
Peter Boström3548dd22015-05-22 18:48:36 +02002206 void TestReceiverLocalSsrcConfiguration(bool receiver_first);
magjed509e4fe2016-11-18 01:34:11 -08002207 void TestReceiveUnsignaledSsrcPacket(uint8_t payload_type,
2208 bool expect_created_receive_stream);
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002209
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002210 FakeVideoSendStream* SetDenoisingOption(
nisse05103312016-03-16 02:22:50 -07002211 uint32_t ssrc,
Niels Möller805a27e2019-01-21 12:21:27 +01002212 webrtc::test::FrameForwarder* frame_forwarder,
nisse0db023a2016-03-01 04:29:59 -08002213 bool enabled) {
nisse05103312016-03-16 02:22:50 -07002214 cricket::VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002215 options.video_noise_reduction = enabled;
Niels Möller805a27e2019-01-21 12:21:27 +01002216 EXPECT_TRUE(channel_->SetVideoSend(ssrc, &options, frame_forwarder));
nisse0db023a2016-03-01 04:29:59 -08002217 // Options only take effect on the next frame.
Niels Möller805a27e2019-01-21 12:21:27 +01002218 frame_forwarder->IncomingCapturedFrame(frame_source_.GetFrame());
nisse0db023a2016-03-01 04:29:59 -08002219
Erik Språng143cec12015-04-28 10:01:41 +02002220 return fake_call_->GetVideoSendStreams().back();
2221 }
2222
Peter Boström2feafdb2015-09-09 14:32:14 +02002223 FakeVideoSendStream* SetUpSimulcast(bool enabled, bool with_rtx) {
2224 const int kRtxSsrcOffset = 0xDEADBEEF;
Erik Språng143cec12015-04-28 10:01:41 +02002225 last_ssrc_ += 3;
Peter Boström2feafdb2015-09-09 14:32:14 +02002226 std::vector<uint32_t> ssrcs;
2227 std::vector<uint32_t> rtx_ssrcs;
2228 uint32_t num_streams = enabled ? 3 : 1;
2229 for (uint32_t i = 0; i < num_streams; ++i) {
2230 uint32_t ssrc = last_ssrc_ + i;
2231 ssrcs.push_back(ssrc);
2232 if (with_rtx) {
2233 rtx_ssrcs.push_back(ssrc + kRtxSsrcOffset);
2234 }
Erik Språng143cec12015-04-28 10:01:41 +02002235 }
Peter Boström2feafdb2015-09-09 14:32:14 +02002236 if (with_rtx) {
2237 return AddSendStream(
2238 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
2239 }
2240 return AddSendStream(CreateSimStreamParams("cname", ssrcs));
Erik Språng143cec12015-04-28 10:01:41 +02002241 }
2242
perkjfa10b552016-10-02 23:45:26 -07002243 int GetMaxEncoderBitrate() {
skvladdc1c62c2016-03-16 19:07:43 -07002244 std::vector<FakeVideoSendStream*> streams =
2245 fake_call_->GetVideoSendStreams();
perkjfa10b552016-10-02 23:45:26 -07002246 EXPECT_EQ(1u, streams.size());
skvladdc1c62c2016-03-16 19:07:43 -07002247 FakeVideoSendStream* stream = streams[streams.size() - 1];
Mirko Bonadeif859e552018-05-30 15:31:29 +02002248 EXPECT_EQ(1u, stream->GetEncoderConfig().number_of_streams);
perkjfa10b552016-10-02 23:45:26 -07002249 return stream->GetVideoStreams()[0].max_bitrate_bps;
skvladdc1c62c2016-03-16 19:07:43 -07002250 }
2251
perkjfa10b552016-10-02 23:45:26 -07002252 void SetAndExpectMaxBitrate(int global_max,
skvladdc1c62c2016-03-16 19:07:43 -07002253 int stream_max,
2254 int expected_encoder_bitrate) {
2255 VideoSendParameters limited_send_params = send_parameters_;
2256 limited_send_params.max_bandwidth_bps = global_max;
2257 EXPECT_TRUE(channel_->SetSendParameters(limited_send_params));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07002258 webrtc::RtpParameters parameters =
2259 channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07002260 EXPECT_EQ(1UL, parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01002261 parameters.encodings[0].max_bitrate_bps = stream_max;
Zach Steinba37b4b2018-01-23 15:02:36 -08002262 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07002263 // Read back the parameteres and verify they have the correct value
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07002264 parameters = channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07002265 EXPECT_EQ(1UL, parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01002266 EXPECT_EQ(stream_max, parameters.encodings[0].max_bitrate_bps);
skvladdc1c62c2016-03-16 19:07:43 -07002267 // Verify that the new value propagated down to the encoder
perkjfa10b552016-10-02 23:45:26 -07002268 EXPECT_EQ(expected_encoder_bitrate, GetMaxEncoderBitrate());
skvladdc1c62c2016-03-16 19:07:43 -07002269 }
2270
Åsa Persson55659812018-06-18 17:51:32 +02002271 // Values from kSimulcastConfigs in simulcast.cc.
2272 const std::vector<webrtc::VideoStream> GetSimulcastBitrates720p() const {
2273 std::vector<webrtc::VideoStream> layers(3);
2274 layers[0].min_bitrate_bps = 30000;
2275 layers[0].target_bitrate_bps = 150000;
2276 layers[0].max_bitrate_bps = 200000;
2277 layers[1].min_bitrate_bps = 150000;
2278 layers[1].target_bitrate_bps = 500000;
2279 layers[1].max_bitrate_bps = 700000;
2280 layers[2].min_bitrate_bps = 600000;
2281 layers[2].target_bitrate_bps = 2500000;
2282 layers[2].max_bitrate_bps = 2500000;
2283 return layers;
2284 }
2285
Niels Möller805a27e2019-01-21 12:21:27 +01002286 cricket::FakeFrameSource frame_source_;
kwiberg686a8ef2016-02-26 03:00:35 -08002287 std::unique_ptr<FakeCall> fake_call_;
2288 std::unique_ptr<VideoMediaChannel> channel_;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002289 cricket::VideoSendParameters send_parameters_;
2290 cricket::VideoRecvParameters recv_parameters_;
Peter Boström0c4e06b2015-10-07 12:23:21 +02002291 uint32_t last_ssrc_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002292};
2293
eladalonf1841382017-06-12 01:16:46 -07002294TEST_F(WebRtcVideoChannelTest, SetsSyncGroupFromSyncLabel) {
Peter Boström0c4e06b2015-10-07 12:23:21 +02002295 const uint32_t kVideoSsrc = 123;
pbos8fc7fa72015-07-15 08:02:58 -07002296 const std::string kSyncLabel = "AvSyncLabel";
2297
2298 cricket::StreamParams sp = cricket::StreamParams::CreateLegacy(kVideoSsrc);
Seth Hampson845e8782018-03-02 11:34:10 -08002299 sp.set_stream_ids({kSyncLabel});
pbos8fc7fa72015-07-15 08:02:58 -07002300 EXPECT_TRUE(channel_->AddRecvStream(sp));
2301
Mirko Bonadeif859e552018-05-30 15:31:29 +02002302 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
pbos8fc7fa72015-07-15 08:02:58 -07002303 EXPECT_EQ(kSyncLabel,
2304 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group)
2305 << "SyncGroup should be set based on sync_label";
2306}
2307
eladalonf1841382017-06-12 01:16:46 -07002308TEST_F(WebRtcVideoChannelTest, RecvStreamWithSimAndRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002309 cricket::VideoSendParameters parameters;
2310 parameters.codecs = engine_.codecs();
2311 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002312 EXPECT_TRUE(channel_->SetSend(true));
nisse4b4dc862016-02-17 05:25:36 -08002313 parameters.conference_mode = true;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002314 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002315
2316 // Send side.
Peter Boström0c4e06b2015-10-07 12:23:21 +02002317 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
2318 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002319 FakeVideoSendStream* send_stream = AddSendStream(
2320 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
2321
2322 ASSERT_EQ(rtx_ssrcs.size(), send_stream->GetConfig().rtp.rtx.ssrcs.size());
2323 for (size_t i = 0; i < rtx_ssrcs.size(); ++i)
2324 EXPECT_EQ(rtx_ssrcs[i], send_stream->GetConfig().rtp.rtx.ssrcs[i]);
2325
2326 // Receiver side.
2327 FakeVideoReceiveStream* recv_stream = AddRecvStream(
2328 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
nisse26e3abb2017-08-25 04:44:25 -07002329 EXPECT_FALSE(
2330 recv_stream->GetConfig().rtp.rtx_associated_payload_types.empty());
nisseca5706d2017-09-11 02:32:16 -07002331 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
Peter Boströmd8b01092016-05-12 16:44:36 +02002332 << "RTX should be mapped for all decoders/payload types.";
nisseca5706d2017-09-11 02:32:16 -07002333 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02002334 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07002335 << "RTX should be mapped for the RED payload type";
2336
brandtr14742122017-01-27 04:53:07 -08002337 EXPECT_EQ(rtx_ssrcs[0], recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002338}
2339
eladalonf1841382017-06-12 01:16:46 -07002340TEST_F(WebRtcVideoChannelTest, RecvStreamWithRtx) {
pbos@webrtc.orge322a172014-06-13 11:47:28 +00002341 // Setup one channel with an associated RTX stream.
2342 cricket::StreamParams params =
2343 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
2344 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
2345 FakeVideoReceiveStream* recv_stream = AddRecvStream(params);
brandtr14742122017-01-27 04:53:07 -08002346 EXPECT_EQ(kRtxSsrcs1[0], recv_stream->GetConfig().rtp.rtx_ssrc);
nisseca5706d2017-09-11 02:32:16 -07002347
2348 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
2349 << "RTX should be mapped for all decoders/payload types.";
2350 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02002351 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07002352 << "RTX should be mapped for the RED payload type";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002353}
2354
eladalonf1841382017-06-12 01:16:46 -07002355TEST_F(WebRtcVideoChannelTest, RecvStreamNoRtx) {
pbos@webrtc.orge322a172014-06-13 11:47:28 +00002356 // Setup one channel without an associated RTX stream.
2357 cricket::StreamParams params =
2358 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
2359 FakeVideoReceiveStream* recv_stream = AddRecvStream(params);
brandtr14742122017-01-27 04:53:07 -08002360 ASSERT_EQ(0U, recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002361}
2362
Johannes Kron9190b822018-10-29 11:22:05 +01002363// Test propagation of extmap allow mixed setting.
2364TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedAsCaller) {
2365 TestExtmapAllowMixedCaller(/*extmap_allow_mixed=*/true);
2366}
2367TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedDisabledAsCaller) {
2368 TestExtmapAllowMixedCaller(/*extmap_allow_mixed=*/false);
2369}
2370TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedAsCallee) {
2371 TestExtmapAllowMixedCallee(/*extmap_allow_mixed=*/true);
2372}
2373TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedDisabledAsCallee) {
2374 TestExtmapAllowMixedCallee(/*extmap_allow_mixed=*/false);
2375}
2376
eladalonf1841382017-06-12 01:16:46 -07002377TEST_F(WebRtcVideoChannelTest, NoHeaderExtesionsByDefault) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002378 FakeVideoSendStream* send_stream =
2379 AddSendStream(cricket::StreamParams::CreateLegacy(kSsrcs1[0]));
2380 ASSERT_TRUE(send_stream->GetConfig().rtp.extensions.empty());
2381
2382 FakeVideoReceiveStream* recv_stream =
2383 AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrcs1[0]));
2384 ASSERT_TRUE(recv_stream->GetConfig().rtp.extensions.empty());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002385}
2386
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002387// Test support for RTP timestamp offset header extension.
eladalonf1841382017-06-12 01:16:46 -07002388TEST_F(WebRtcVideoChannelTest, SendRtpTimestampOffsetHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002389 TestSetSendRtpHeaderExtensions(RtpExtension::kTimestampOffsetUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002390}
isheriff6f8d6862016-05-26 11:24:55 -07002391
eladalonf1841382017-06-12 01:16:46 -07002392TEST_F(WebRtcVideoChannelTest, RecvRtpTimestampOffsetHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002393 TestSetRecvRtpHeaderExtensions(RtpExtension::kTimestampOffsetUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002394}
2395
2396// Test support for absolute send time header extension.
eladalonf1841382017-06-12 01:16:46 -07002397TEST_F(WebRtcVideoChannelTest, SendAbsoluteSendTimeHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002398 TestSetSendRtpHeaderExtensions(RtpExtension::kAbsSendTimeUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002399}
isheriff6f8d6862016-05-26 11:24:55 -07002400
eladalonf1841382017-06-12 01:16:46 -07002401TEST_F(WebRtcVideoChannelTest, RecvAbsoluteSendTimeHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002402 TestSetRecvRtpHeaderExtensions(RtpExtension::kAbsSendTimeUri);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002403}
2404
eladalonf1841382017-06-12 01:16:46 -07002405TEST_F(WebRtcVideoChannelTest, FiltersExtensionsPicksTransportSeqNum) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002406 // Enable three redundant extensions.
2407 std::vector<std::string> extensions;
isheriff6f8d6862016-05-26 11:24:55 -07002408 extensions.push_back(RtpExtension::kAbsSendTimeUri);
2409 extensions.push_back(RtpExtension::kTimestampOffsetUri);
2410 extensions.push_back(RtpExtension::kTransportSequenceNumberUri);
2411 TestExtensionFilter(extensions, RtpExtension::kTransportSequenceNumberUri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002412}
2413
eladalonf1841382017-06-12 01:16:46 -07002414TEST_F(WebRtcVideoChannelTest, FiltersExtensionsPicksAbsSendTime) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002415 // Enable two redundant extensions.
2416 std::vector<std::string> extensions;
isheriff6f8d6862016-05-26 11:24:55 -07002417 extensions.push_back(RtpExtension::kAbsSendTimeUri);
2418 extensions.push_back(RtpExtension::kTimestampOffsetUri);
2419 TestExtensionFilter(extensions, RtpExtension::kAbsSendTimeUri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002420}
2421
stefanc1aeaf02015-10-15 07:26:07 -07002422// Test support for transport sequence number header extension.
eladalonf1841382017-06-12 01:16:46 -07002423TEST_F(WebRtcVideoChannelTest, SendTransportSequenceNumberHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002424 TestSetSendRtpHeaderExtensions(RtpExtension::kTransportSequenceNumberUri);
stefanc1aeaf02015-10-15 07:26:07 -07002425}
eladalonf1841382017-06-12 01:16:46 -07002426TEST_F(WebRtcVideoChannelTest, RecvTransportSequenceNumberHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002427 TestSetRecvRtpHeaderExtensions(RtpExtension::kTransportSequenceNumberUri);
stefanc1aeaf02015-10-15 07:26:07 -07002428}
2429
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002430// Test support for video rotation header extension.
eladalonf1841382017-06-12 01:16:46 -07002431TEST_F(WebRtcVideoChannelTest, SendVideoRotationHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002432 TestSetSendRtpHeaderExtensions(RtpExtension::kVideoRotationUri);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002433}
eladalonf1841382017-06-12 01:16:46 -07002434TEST_F(WebRtcVideoChannelTest, RecvVideoRotationHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002435 TestSetRecvRtpHeaderExtensions(RtpExtension::kVideoRotationUri);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002436}
2437
eladalonf1841382017-06-12 01:16:46 -07002438TEST_F(WebRtcVideoChannelTest, IdenticalSendExtensionsDoesntRecreateStream) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002439 const int kAbsSendTimeId = 1;
2440 const int kVideoRotationId = 2;
isheriff6f8d6862016-05-26 11:24:55 -07002441 send_parameters_.extensions.push_back(
2442 RtpExtension(RtpExtension::kAbsSendTimeUri, kAbsSendTimeId));
2443 send_parameters_.extensions.push_back(
2444 RtpExtension(RtpExtension::kVideoRotationUri, kVideoRotationId));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002445
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002446 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002447 FakeVideoSendStream* send_stream =
2448 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2449
2450 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002451 ASSERT_EQ(2u, send_stream->GetConfig().rtp.extensions.size());
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002452
2453 // Setting the same extensions (even if in different order) shouldn't
2454 // reallocate the stream.
Steve Anton2c9ebef2019-01-28 17:27:58 -08002455 absl::c_reverse(send_parameters_.extensions);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002456 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002457
2458 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
2459
2460 // Setting different extensions should recreate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002461 send_parameters_.extensions.resize(1);
2462 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002463
2464 EXPECT_EQ(2, fake_call_->GetNumCreatedSendStreams());
2465}
2466
eladalonf1841382017-06-12 01:16:46 -07002467TEST_F(WebRtcVideoChannelTest, IdenticalRecvExtensionsDoesntRecreateStream) {
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002468 const int kTOffsetId = 1;
2469 const int kAbsSendTimeId = 2;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002470 const int kVideoRotationId = 3;
isheriff6f8d6862016-05-26 11:24:55 -07002471 recv_parameters_.extensions.push_back(
2472 RtpExtension(RtpExtension::kAbsSendTimeUri, kAbsSendTimeId));
2473 recv_parameters_.extensions.push_back(
2474 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
2475 recv_parameters_.extensions.push_back(
2476 RtpExtension(RtpExtension::kVideoRotationUri, kVideoRotationId));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002477
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002478 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
Peter Boström54be3e02015-05-25 15:04:24 +02002479 FakeVideoReceiveStream* recv_stream =
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002480 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2481
2482 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
Peter Boström54be3e02015-05-25 15:04:24 +02002483 ASSERT_EQ(3u, recv_stream->GetConfig().rtp.extensions.size());
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002484
2485 // Setting the same extensions (even if in different order) shouldn't
2486 // reallocate the stream.
Steve Anton2c9ebef2019-01-28 17:27:58 -08002487 absl::c_reverse(recv_parameters_.extensions);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002488 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002489
2490 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
2491
2492 // Setting different extensions should recreate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002493 recv_parameters_.extensions.resize(1);
2494 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002495
2496 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams());
2497}
2498
eladalonf1841382017-06-12 01:16:46 -07002499TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002500 SetSendRtpHeaderExtensionsExcludeUnsupportedExtensions) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002501 const int kUnsupportedId = 1;
2502 const int kTOffsetId = 2;
2503
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002504 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002505 RtpExtension(kUnsupportedExtensionName, kUnsupportedId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002506 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002507 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002508 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002509 FakeVideoSendStream* send_stream =
2510 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2511
2512 // Only timestamp offset extension is set to send stream,
2513 // unsupported rtp extension is ignored.
2514 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
isheriff6f8d6862016-05-26 11:24:55 -07002515 EXPECT_STREQ(RtpExtension::kTimestampOffsetUri,
2516 send_stream->GetConfig().rtp.extensions[0].uri.c_str());
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002517}
2518
eladalonf1841382017-06-12 01:16:46 -07002519TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002520 SetRecvRtpHeaderExtensionsExcludeUnsupportedExtensions) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002521 const int kUnsupportedId = 1;
2522 const int kTOffsetId = 2;
2523
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002524 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002525 RtpExtension(kUnsupportedExtensionName, kUnsupportedId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002526 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002527 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002528 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002529 FakeVideoReceiveStream* recv_stream =
2530 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2531
2532 // Only timestamp offset extension is set to receive stream,
2533 // unsupported rtp extension is ignored.
2534 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
isheriff6f8d6862016-05-26 11:24:55 -07002535 EXPECT_STREQ(RtpExtension::kTimestampOffsetUri,
2536 recv_stream->GetConfig().rtp.extensions[0].uri.c_str());
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002537}
2538
eladalonf1841382017-06-12 01:16:46 -07002539TEST_F(WebRtcVideoChannelTest, SetSendRtpHeaderExtensionsRejectsIncorrectIds) {
Peter Boström23914fe2015-03-31 15:08:04 +02002540 const int kIncorrectIds[] = {-2, -1, 0, 15, 16};
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00002541 for (size_t i = 0; i < arraysize(kIncorrectIds); ++i) {
isheriff6f8d6862016-05-26 11:24:55 -07002542 send_parameters_.extensions.push_back(
2543 RtpExtension(RtpExtension::kTimestampOffsetUri, kIncorrectIds[i]));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002544 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_))
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002545 << "Bad extension id '" << kIncorrectIds[i] << "' accepted.";
2546 }
2547}
2548
eladalonf1841382017-06-12 01:16:46 -07002549TEST_F(WebRtcVideoChannelTest, SetRecvRtpHeaderExtensionsRejectsIncorrectIds) {
Peter Boström23914fe2015-03-31 15:08:04 +02002550 const int kIncorrectIds[] = {-2, -1, 0, 15, 16};
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00002551 for (size_t i = 0; i < arraysize(kIncorrectIds); ++i) {
isheriff6f8d6862016-05-26 11:24:55 -07002552 recv_parameters_.extensions.push_back(
2553 RtpExtension(RtpExtension::kTimestampOffsetUri, kIncorrectIds[i]));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002554 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_))
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002555 << "Bad extension id '" << kIncorrectIds[i] << "' accepted.";
2556 }
2557}
2558
eladalonf1841382017-06-12 01:16:46 -07002559TEST_F(WebRtcVideoChannelTest, SetSendRtpHeaderExtensionsRejectsDuplicateIds) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002560 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002561 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002562 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002563 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002564 RtpExtension(RtpExtension::kAbsSendTimeUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002565 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002566
2567 // Duplicate entries are also not supported.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002568 send_parameters_.extensions.clear();
2569 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002570 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002571 send_parameters_.extensions.push_back(send_parameters_.extensions.back());
2572 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002573}
2574
eladalonf1841382017-06-12 01:16:46 -07002575TEST_F(WebRtcVideoChannelTest, SetRecvRtpHeaderExtensionsRejectsDuplicateIds) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002576 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002577 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002578 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002579 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002580 RtpExtension(RtpExtension::kAbsSendTimeUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002581 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002582
2583 // Duplicate entries are also not supported.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002584 recv_parameters_.extensions.clear();
2585 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002586 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002587 recv_parameters_.extensions.push_back(recv_parameters_.extensions.back());
2588 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002589}
2590
eladalonf1841382017-06-12 01:16:46 -07002591TEST_F(WebRtcVideoChannelTest, AddRecvStreamOnlyUsesOneReceiveStream) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002592 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002593 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002594}
2595
eladalonf1841382017-06-12 01:16:46 -07002596TEST_F(WebRtcVideoChannelTest, RtcpIsCompoundByDefault) {
Peter Boströmd7da1202015-06-05 14:09:38 +02002597 FakeVideoReceiveStream* stream = AddRecvStream();
pbosda903ea2015-10-02 02:36:56 -07002598 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream->GetConfig().rtp.rtcp_mode);
Peter Boströmd7da1202015-06-05 14:09:38 +02002599}
2600
eladalonf1841382017-06-12 01:16:46 -07002601TEST_F(WebRtcVideoChannelTest, RembIsEnabledByDefault) {
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002602 FakeVideoReceiveStream* stream = AddRecvStream();
2603 EXPECT_TRUE(stream->GetConfig().rtp.remb);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002604}
2605
eladalonf1841382017-06-12 01:16:46 -07002606TEST_F(WebRtcVideoChannelTest, TransportCcIsEnabledByDefault) {
stefan43edf0f2015-11-20 18:05:48 -08002607 FakeVideoReceiveStream* stream = AddRecvStream();
2608 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2609}
2610
eladalonf1841382017-06-12 01:16:46 -07002611TEST_F(WebRtcVideoChannelTest, RembCanBeEnabledAndDisabled) {
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002612 FakeVideoReceiveStream* stream = AddRecvStream();
2613 EXPECT_TRUE(stream->GetConfig().rtp.remb);
2614
Peter Boström126c03e2015-05-11 12:48:12 +02002615 // Verify that REMB is turned off when send(!) codecs without REMB are set.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002616 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002617 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002618 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2619 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002620 stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002621 EXPECT_FALSE(stream->GetConfig().rtp.remb);
2622
2623 // Verify that REMB is turned on when setting default codecs since the
2624 // default codecs have REMB enabled.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002625 parameters.codecs = engine_.codecs();
2626 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002627 stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002628 EXPECT_TRUE(stream->GetConfig().rtp.remb);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002629}
2630
eladalonf1841382017-06-12 01:16:46 -07002631TEST_F(WebRtcVideoChannelTest, TransportCcCanBeEnabledAndDisabled) {
stefan43edf0f2015-11-20 18:05:48 -08002632 FakeVideoReceiveStream* stream = AddRecvStream();
2633 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2634
2635 // Verify that transport cc feedback is turned off when send(!) codecs without
2636 // transport cc feedback are set.
2637 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002638 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
stefan43edf0f2015-11-20 18:05:48 -08002639 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2640 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2641 stream = fake_call_->GetVideoReceiveStreams()[0];
2642 EXPECT_FALSE(stream->GetConfig().rtp.transport_cc);
2643
2644 // Verify that transport cc feedback is turned on when setting default codecs
2645 // since the default codecs have transport cc feedback enabled.
2646 parameters.codecs = engine_.codecs();
2647 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2648 stream = fake_call_->GetVideoReceiveStreams()[0];
2649 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2650}
2651
eladalonf1841382017-06-12 01:16:46 -07002652TEST_F(WebRtcVideoChannelTest, NackIsEnabledByDefault) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02002653 AssignDefaultCodec();
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002654 VerifyCodecHasDefaultFeedbackParams(default_codec_);
2655
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002656 cricket::VideoSendParameters parameters;
2657 parameters.codecs = engine_.codecs();
2658 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org19864742014-05-30 07:35:47 +00002659 EXPECT_TRUE(channel_->SetSend(true));
2660
2661 // Send side.
2662 FakeVideoSendStream* send_stream =
2663 AddSendStream(cricket::StreamParams::CreateLegacy(1));
2664 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2665
2666 // Receiver side.
2667 FakeVideoReceiveStream* recv_stream =
2668 AddRecvStream(cricket::StreamParams::CreateLegacy(1));
2669 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2670
2671 // Nack history size should match between sender and receiver.
2672 EXPECT_EQ(send_stream->GetConfig().rtp.nack.rtp_history_ms,
2673 recv_stream->GetConfig().rtp.nack.rtp_history_ms);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002674}
2675
eladalonf1841382017-06-12 01:16:46 -07002676TEST_F(WebRtcVideoChannelTest, NackCanBeEnabledAndDisabled) {
Peter Boström67c9df72015-05-11 14:34:58 +02002677 FakeVideoSendStream* send_stream = AddSendStream();
Peter Boström3548dd22015-05-22 18:48:36 +02002678 FakeVideoReceiveStream* recv_stream = AddRecvStream();
Peter Boström67c9df72015-05-11 14:34:58 +02002679
2680 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2681 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2682
2683 // Verify that NACK is turned off when send(!) codecs without NACK are set.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002684 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002685 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002686 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2687 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström67c9df72015-05-11 14:34:58 +02002688 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2689 EXPECT_EQ(0, recv_stream->GetConfig().rtp.nack.rtp_history_ms);
2690 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002691 EXPECT_EQ(0, send_stream->GetConfig().rtp.nack.rtp_history_ms);
2692
Peter Boström67c9df72015-05-11 14:34:58 +02002693 // Verify that NACK is turned on when setting default codecs since the
2694 // default codecs have NACK enabled.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002695 parameters.codecs = engine_.codecs();
2696 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström67c9df72015-05-11 14:34:58 +02002697 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2698 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2699 send_stream = fake_call_->GetVideoSendStreams()[0];
2700 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002701}
2702
Peter Boströme7ba0862016-03-12 00:02:28 +01002703// This test verifies that new frame sizes reconfigures encoders even though not
2704// (yet) sending. The purpose of this is to permit encoding as quickly as
2705// possible once we start sending. Likely the frames being input are from the
2706// same source that will be sent later, which just means that we're ready
2707// earlier.
eladalonf1841382017-06-12 01:16:46 -07002708TEST_F(WebRtcVideoChannelTest, ReconfiguresEncodersWhenNotSending) {
Peter Boströme7ba0862016-03-12 00:02:28 +01002709 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002710 parameters.codecs.push_back(GetEngineCodec("VP8"));
Peter Boströme7ba0862016-03-12 00:02:28 +01002711 ASSERT_TRUE(channel_->SetSendParameters(parameters));
2712 channel_->SetSend(false);
2713
2714 FakeVideoSendStream* stream = AddSendStream();
2715
perkjfa10b552016-10-02 23:45:26 -07002716 // No frames entered.
Peter Boströme7ba0862016-03-12 00:02:28 +01002717 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002718 EXPECT_EQ(0u, streams[0].width);
2719 EXPECT_EQ(0u, streams[0].height);
Peter Boströme7ba0862016-03-12 00:02:28 +01002720
Niels Möller805a27e2019-01-21 12:21:27 +01002721 webrtc::test::FrameForwarder frame_forwarder;
2722 cricket::FakeFrameSource frame_source(1280, 720,
2723 rtc::kNumMicrosecsPerSec / 30);
2724
2725 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
2726 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Peter Boströme7ba0862016-03-12 00:02:28 +01002727
2728 // Frame entered, should be reconfigured to new dimensions.
2729 streams = stream->GetVideoStreams();
Niels Möller805a27e2019-01-21 12:21:27 +01002730 EXPECT_EQ(rtc::checked_cast<size_t>(1280), streams[0].width);
2731 EXPECT_EQ(rtc::checked_cast<size_t>(720), streams[0].height);
Peter Boströme7ba0862016-03-12 00:02:28 +01002732
Niels Möllerff40b142018-04-09 08:49:14 +02002733 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boströme7ba0862016-03-12 00:02:28 +01002734}
2735
eladalonf1841382017-06-12 01:16:46 -07002736TEST_F(WebRtcVideoChannelTest, UsesCorrectSettingsForScreencast) {
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002737 static const int kScreenshareMinBitrateKbps = 800;
magjed509e4fe2016-11-18 01:34:11 -08002738 cricket::VideoCodec codec = GetEngineCodec("VP8");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002739 cricket::VideoSendParameters parameters;
2740 parameters.codecs.push_back(codec);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002741 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002742 AddSendStream();
2743
Niels Möller805a27e2019-01-21 12:21:27 +01002744 webrtc::test::FrameForwarder frame_forwarder;
2745 cricket::FakeFrameSource frame_source(1280, 720,
2746 rtc::kNumMicrosecsPerSec / 30);
nisse05103312016-03-16 02:22:50 -07002747 VideoOptions min_bitrate_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002748 min_bitrate_options.screencast_min_bitrate_kbps = kScreenshareMinBitrateKbps;
Niels Möller805a27e2019-01-21 12:21:27 +01002749 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &min_bitrate_options,
2750 &frame_forwarder));
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002751
2752 EXPECT_TRUE(channel_->SetSend(true));
2753
Niels Möller805a27e2019-01-21 12:21:27 +01002754 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002755 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2756 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
2757
2758 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
2759
2760 // Verify non-screencast settings.
perkj26091b12016-09-01 01:17:40 -07002761 webrtc::VideoEncoderConfig encoder_config =
2762 send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002763 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kRealtimeVideo,
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002764 encoder_config.content_type);
perkjfa10b552016-10-02 23:45:26 -07002765 std::vector<webrtc::VideoStream> streams = send_stream->GetVideoStreams();
Niels Möller805a27e2019-01-21 12:21:27 +01002766 EXPECT_EQ(rtc::checked_cast<size_t>(1280), streams.front().width);
2767 EXPECT_EQ(rtc::checked_cast<size_t>(720), streams.front().height);
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002768 EXPECT_EQ(0, encoder_config.min_transmit_bitrate_bps)
2769 << "Non-screenshare shouldn't use min-transmit bitrate.";
2770
Niels Möllerff40b142018-04-09 08:49:14 +02002771 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
perkjd533aec2017-01-13 05:57:25 -08002772 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
nisse05103312016-03-16 02:22:50 -07002773 VideoOptions screencast_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002774 screencast_options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01002775 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &screencast_options,
2776 &frame_forwarder));
2777 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
sprangf24a0642017-02-28 13:23:26 -08002778 // Send stream recreated after option change.
2779 ASSERT_EQ(2, fake_call_->GetNumCreatedSendStreams());
2780 send_stream = fake_call_->GetVideoSendStreams().front();
2781 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002782
2783 // Verify screencast settings.
perkj26091b12016-09-01 01:17:40 -07002784 encoder_config = send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002785 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kScreen,
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002786 encoder_config.content_type);
2787 EXPECT_EQ(kScreenshareMinBitrateKbps * 1000,
2788 encoder_config.min_transmit_bitrate_bps);
2789
perkjfa10b552016-10-02 23:45:26 -07002790 streams = send_stream->GetVideoStreams();
Niels Möller805a27e2019-01-21 12:21:27 +01002791 EXPECT_EQ(rtc::checked_cast<size_t>(1280), streams.front().width);
2792 EXPECT_EQ(rtc::checked_cast<size_t>(720), streams.front().height);
Sergey Silkina796a7e2018-03-01 15:11:29 +01002793 EXPECT_FALSE(streams[0].num_temporal_layers.has_value());
Niels Möllerff40b142018-04-09 08:49:14 +02002794 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002795}
2796
eladalonf1841382017-06-12 01:16:46 -07002797TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002798 ConferenceModeScreencastConfiguresTemporalLayer) {
Rasmus Brandt195d1d72018-05-09 11:28:01 +02002799 static const int kConferenceScreencastTemporalBitrateBps = 200 * 1000;
nisse4b4dc862016-02-17 05:25:36 -08002800 send_parameters_.conference_mode = true;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002801 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002802
2803 AddSendStream();
nisse05103312016-03-16 02:22:50 -07002804 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002805 options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01002806 webrtc::test::FrameForwarder frame_forwarder;
2807 cricket::FakeFrameSource frame_source(1280, 720,
2808 rtc::kNumMicrosecsPerSec / 30);
2809 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002810 EXPECT_TRUE(channel_->SetSend(true));
2811
Niels Möller805a27e2019-01-21 12:21:27 +01002812 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002813 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2814 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
2815
perkj26091b12016-09-01 01:17:40 -07002816 webrtc::VideoEncoderConfig encoder_config =
2817 send_stream->GetEncoderConfig().Copy();
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002818
2819 // Verify screencast settings.
perkj26091b12016-09-01 01:17:40 -07002820 encoder_config = send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002821 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kScreen,
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002822 encoder_config.content_type);
perkjfa10b552016-10-02 23:45:26 -07002823
2824 std::vector<webrtc::VideoStream> streams = send_stream->GetVideoStreams();
2825 ASSERT_EQ(1u, streams.size());
Sergey Silkina796a7e2018-03-01 15:11:29 +01002826 ASSERT_EQ(2u, streams[0].num_temporal_layers);
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002827 EXPECT_EQ(kConferenceScreencastTemporalBitrateBps,
Sergey Silkina796a7e2018-03-01 15:11:29 +01002828 streams[0].target_bitrate_bps);
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002829
Niels Möllerff40b142018-04-09 08:49:14 +02002830 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002831}
2832
eladalonf1841382017-06-12 01:16:46 -07002833TEST_F(WebRtcVideoChannelTest, SuspendBelowMinBitrateDisabledByDefault) {
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002834 FakeVideoSendStream* stream = AddSendStream();
2835 EXPECT_FALSE(stream->GetConfig().suspend_below_min_bitrate);
2836}
2837
eladalonf1841382017-06-12 01:16:46 -07002838TEST_F(WebRtcVideoChannelTest, SetMediaConfigSuspendBelowMinBitrate) {
kthelgason2bc68642017-02-07 07:02:22 -08002839 MediaConfig media_config = GetMediaConfig();
nisse0db023a2016-03-01 04:29:59 -08002840 media_config.video.suspend_below_min_bitrate = true;
2841
Sebastian Jansson84848f22018-11-16 10:40:36 +01002842 channel_.reset(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07002843 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002844 channel_->OnReadyToSend(true);
nisse0db023a2016-03-01 04:29:59 -08002845
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002846 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002847
2848 FakeVideoSendStream* stream = AddSendStream();
2849 EXPECT_TRUE(stream->GetConfig().suspend_below_min_bitrate);
2850
nisse0db023a2016-03-01 04:29:59 -08002851 media_config.video.suspend_below_min_bitrate = false;
Sebastian Jansson84848f22018-11-16 10:40:36 +01002852 channel_.reset(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07002853 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002854 channel_->OnReadyToSend(true);
nisse0db023a2016-03-01 04:29:59 -08002855
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002856 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002857
nisse0db023a2016-03-01 04:29:59 -08002858 stream = AddSendStream();
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002859 EXPECT_FALSE(stream->GetConfig().suspend_below_min_bitrate);
2860}
2861
eladalonf1841382017-06-12 01:16:46 -07002862TEST_F(WebRtcVideoChannelTest, Vp8DenoisingEnabledByDefault) {
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002863 FakeVideoSendStream* stream = AddSendStream();
2864 webrtc::VideoCodecVP8 vp8_settings;
2865 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2866 EXPECT_TRUE(vp8_settings.denoisingOn);
2867}
2868
eladalonf1841382017-06-12 01:16:46 -07002869TEST_F(WebRtcVideoChannelTest, VerifyVp8SpecificSettings) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002870 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002871 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002872 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002873
Peter Boström2feafdb2015-09-09 14:32:14 +02002874 // Single-stream settings should apply with RTX as well (verifies that we
2875 // check number of regular SSRCs and not StreamParams::ssrcs which contains
2876 // both RTX and regular SSRCs).
2877 FakeVideoSendStream* stream = SetUpSimulcast(false, true);
Erik Språng143cec12015-04-28 10:01:41 +02002878
Niels Möller805a27e2019-01-21 12:21:27 +01002879 webrtc::test::FrameForwarder frame_forwarder;
2880 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Erik Språng143cec12015-04-28 10:01:41 +02002881 channel_->SetSend(true);
2882
Niels Möller805a27e2019-01-21 12:21:27 +01002883 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Erik Språng143cec12015-04-28 10:01:41 +02002884
pbos4cba4eb2015-10-26 11:18:18 -07002885 webrtc::VideoCodecVP8 vp8_settings;
2886 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2887 EXPECT_TRUE(vp8_settings.denoisingOn)
2888 << "VP8 denoising should be on by default.";
2889
Niels Möller805a27e2019-01-21 12:21:27 +01002890 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02002891
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002892 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2893 EXPECT_FALSE(vp8_settings.denoisingOn);
Erik Språng143cec12015-04-28 10:01:41 +02002894 EXPECT_TRUE(vp8_settings.automaticResizeOn);
2895 EXPECT_TRUE(vp8_settings.frameDroppingOn);
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002896
Niels Möller805a27e2019-01-21 12:21:27 +01002897 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, true);
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002898
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002899 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2900 EXPECT_TRUE(vp8_settings.denoisingOn);
Erik Språng143cec12015-04-28 10:01:41 +02002901 EXPECT_TRUE(vp8_settings.automaticResizeOn);
2902 EXPECT_TRUE(vp8_settings.frameDroppingOn);
2903
Niels Möllerff40b142018-04-09 08:49:14 +02002904 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boström2feafdb2015-09-09 14:32:14 +02002905 stream = SetUpSimulcast(true, false);
Niels Möller805a27e2019-01-21 12:21:27 +01002906 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Erik Språng143cec12015-04-28 10:01:41 +02002907 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01002908 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Erik Språng143cec12015-04-28 10:01:41 +02002909
Mirko Bonadeif859e552018-05-30 15:31:29 +02002910 EXPECT_EQ(3u, stream->GetVideoStreams().size());
Erik Språng143cec12015-04-28 10:01:41 +02002911 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2912 // Autmatic resize off when using simulcast.
2913 EXPECT_FALSE(vp8_settings.automaticResizeOn);
2914 EXPECT_TRUE(vp8_settings.frameDroppingOn);
2915
2916 // In screen-share mode, denoising is forced off and simulcast disabled.
nisse05103312016-03-16 02:22:50 -07002917 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002918 options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01002919 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Niels Möller60653ba2016-03-02 11:41:36 +01002920
Niels Möller805a27e2019-01-21 12:21:27 +01002921 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02002922
Mirko Bonadeif859e552018-05-30 15:31:29 +02002923 EXPECT_EQ(1u, stream->GetVideoStreams().size());
Erik Språng143cec12015-04-28 10:01:41 +02002924 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2925 EXPECT_FALSE(vp8_settings.denoisingOn);
2926 // Resizing and frame dropping always off for screen sharing.
2927 EXPECT_FALSE(vp8_settings.automaticResizeOn);
2928 EXPECT_FALSE(vp8_settings.frameDroppingOn);
2929
Niels Möller805a27e2019-01-21 12:21:27 +01002930 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, true);
Erik Språng143cec12015-04-28 10:01:41 +02002931
2932 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2933 EXPECT_FALSE(vp8_settings.denoisingOn);
2934 EXPECT_FALSE(vp8_settings.automaticResizeOn);
2935 EXPECT_FALSE(vp8_settings.frameDroppingOn);
2936
Niels Möllerff40b142018-04-09 08:49:14 +02002937 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Erik Språng143cec12015-04-28 10:01:41 +02002938}
2939
deadbeef119760a2016-04-04 11:43:27 -07002940// Test that setting the same options doesn't result in the encoder being
2941// reconfigured.
eladalonf1841382017-06-12 01:16:46 -07002942TEST_F(WebRtcVideoChannelTest, SetIdenticalOptionsDoesntReconfigureEncoder) {
deadbeef119760a2016-04-04 11:43:27 -07002943 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01002944 webrtc::test::FrameForwarder frame_forwarder;
deadbeef119760a2016-04-04 11:43:27 -07002945
perkjfa10b552016-10-02 23:45:26 -07002946 AddSendStream();
perkjfa10b552016-10-02 23:45:26 -07002947 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002948 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkjfa10b552016-10-02 23:45:26 -07002949 ASSERT_TRUE(channel_->SetSendParameters(parameters));
2950 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
2951
Niels Möller805a27e2019-01-21 12:21:27 +01002952 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
2953 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
2954 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
perkjfa10b552016-10-02 23:45:26 -07002955 // Expect 1 reconfigurations at this point from the initial configuration.
2956 EXPECT_EQ(1, send_stream->num_encoder_reconfigurations());
deadbeef119760a2016-04-04 11:43:27 -07002957
2958 // Set the options one more time and expect no additional reconfigurations.
Niels Möller805a27e2019-01-21 12:21:27 +01002959 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
perkjfa10b552016-10-02 23:45:26 -07002960 EXPECT_EQ(1, send_stream->num_encoder_reconfigurations());
2961
2962 // Change |options| and expect 2 reconfigurations.
Oskar Sundbom78807582017-11-16 11:09:55 +01002963 options.video_noise_reduction = true;
Niels Möller805a27e2019-01-21 12:21:27 +01002964 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
deadbeef119760a2016-04-04 11:43:27 -07002965 EXPECT_EQ(2, send_stream->num_encoder_reconfigurations());
2966
Niels Möllerff40b142018-04-09 08:49:14 +02002967 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
deadbeef119760a2016-04-04 11:43:27 -07002968}
2969
eladalonf1841382017-06-12 01:16:46 -07002970class Vp9SettingsTest : public WebRtcVideoChannelTest {
Erik Språng143cec12015-04-28 10:01:41 +02002971 public:
asaperssonc5dabdd2016-03-21 04:15:50 -07002972 Vp9SettingsTest() : Vp9SettingsTest("") {}
2973 explicit Vp9SettingsTest(const char* field_trials)
eladalonf1841382017-06-12 01:16:46 -07002974 : WebRtcVideoChannelTest(field_trials) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +02002975 encoder_factory_->AddSupportedVideoCodecType("VP9");
Erik Språng143cec12015-04-28 10:01:41 +02002976 }
2977 virtual ~Vp9SettingsTest() {}
2978
2979 protected:
Erik Språng143cec12015-04-28 10:01:41 +02002980 void TearDown() override {
2981 // Remove references to encoder_factory_ since this will be destroyed
2982 // before channel_ and engine_.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002983 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
Erik Språng143cec12015-04-28 10:01:41 +02002984 }
Erik Språng143cec12015-04-28 10:01:41 +02002985};
2986
2987TEST_F(Vp9SettingsTest, VerifyVp9SpecificSettings) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002988 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002989 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002990 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Erik Språng143cec12015-04-28 10:01:41 +02002991
Peter Boström2feafdb2015-09-09 14:32:14 +02002992 FakeVideoSendStream* stream = SetUpSimulcast(false, false);
Erik Språng143cec12015-04-28 10:01:41 +02002993
Niels Möller805a27e2019-01-21 12:21:27 +01002994 webrtc::test::FrameForwarder frame_forwarder;
2995 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Erik Språng143cec12015-04-28 10:01:41 +02002996 channel_->SetSend(true);
2997
Niels Möller805a27e2019-01-21 12:21:27 +01002998 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Erik Språng143cec12015-04-28 10:01:41 +02002999
pbos4cba4eb2015-10-26 11:18:18 -07003000 webrtc::VideoCodecVP9 vp9_settings;
3001 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
jianja5e8aa62017-03-27 10:09:00 -07003002 EXPECT_TRUE(vp9_settings.denoisingOn)
3003 << "VP9 denoising should be on by default.";
pbos4cba4eb2015-10-26 11:18:18 -07003004
Niels Möller805a27e2019-01-21 12:21:27 +01003005 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02003006
Erik Språng143cec12015-04-28 10:01:41 +02003007 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3008 EXPECT_FALSE(vp9_settings.denoisingOn);
3009 // Frame dropping always on for real time video.
3010 EXPECT_TRUE(vp9_settings.frameDroppingOn);
3011
Niels Möller805a27e2019-01-21 12:21:27 +01003012 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, true);
Erik Språng143cec12015-04-28 10:01:41 +02003013
3014 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3015 EXPECT_TRUE(vp9_settings.denoisingOn);
3016 EXPECT_TRUE(vp9_settings.frameDroppingOn);
3017
3018 // In screen-share mode, denoising is forced off.
nisse05103312016-03-16 02:22:50 -07003019 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003020 options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01003021 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
perkj2d5f0912016-02-29 00:04:41 -08003022
Niels Möller805a27e2019-01-21 12:21:27 +01003023 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02003024
3025 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3026 EXPECT_FALSE(vp9_settings.denoisingOn);
Sergey Silkinbe71a1e2018-05-17 16:46:43 +02003027 // Frame dropping always on for screen sharing.
3028 EXPECT_TRUE(vp9_settings.frameDroppingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003029
Niels Möller805a27e2019-01-21 12:21:27 +01003030 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02003031
3032 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3033 EXPECT_FALSE(vp9_settings.denoisingOn);
Sergey Silkinbe71a1e2018-05-17 16:46:43 +02003034 EXPECT_TRUE(vp9_settings.frameDroppingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003035
Niels Möllerff40b142018-04-09 08:49:14 +02003036 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003037}
3038
Sergey Silkinf18072e2018-03-14 10:35:35 +01003039TEST_F(Vp9SettingsTest, MultipleSsrcsEnablesSvc) {
3040 cricket::VideoSendParameters parameters;
3041 parameters.codecs.push_back(GetEngineCodec("VP9"));
3042 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3043
3044 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
3045
3046 FakeVideoSendStream* stream =
3047 AddSendStream(CreateSimStreamParams("cname", ssrcs));
3048
3049 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3050 EXPECT_EQ(ssrcs.size(), config.rtp.ssrcs.size());
3051
Niels Möller805a27e2019-01-21 12:21:27 +01003052 webrtc::test::FrameForwarder frame_forwarder;
3053 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, &frame_forwarder));
Sergey Silkinf18072e2018-03-14 10:35:35 +01003054 channel_->SetSend(true);
3055
Niels Möller805a27e2019-01-21 12:21:27 +01003056 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Sergey Silkinf18072e2018-03-14 10:35:35 +01003057
3058 webrtc::VideoCodecVP9 vp9_settings;
3059 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3060
3061 const size_t kNumSpatialLayers = ssrcs.size();
3062 const size_t kNumTemporalLayers = 3;
3063 EXPECT_EQ(vp9_settings.numberOfSpatialLayers, kNumSpatialLayers);
3064 EXPECT_EQ(vp9_settings.numberOfTemporalLayers, kNumTemporalLayers);
3065
Niels Möllerff40b142018-04-09 08:49:14 +02003066 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, nullptr));
Sergey Silkinf18072e2018-03-14 10:35:35 +01003067}
3068
Sergey Silkin8b9b5f92018-12-10 09:28:53 +01003069TEST_F(Vp9SettingsTest, AllEncodingParametersCopied) {
3070 cricket::VideoSendParameters send_parameters;
3071 send_parameters.codecs.push_back(GetEngineCodec("VP9"));
3072 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
3073
3074 const size_t kNumSpatialLayers = 3;
3075 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
3076
3077 FakeVideoSendStream* stream =
3078 AddSendStream(CreateSimStreamParams("cname", ssrcs));
3079
3080 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(ssrcs[0]);
3081 ASSERT_EQ(kNumSpatialLayers, parameters.encodings.size());
3082 ASSERT_TRUE(parameters.encodings[0].active);
3083 ASSERT_TRUE(parameters.encodings[1].active);
3084 ASSERT_TRUE(parameters.encodings[2].active);
3085 // Invert value to verify copying.
3086 parameters.encodings[1].active = false;
3087 EXPECT_TRUE(channel_->SetRtpSendParameters(ssrcs[0], parameters).ok());
3088
3089 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
3090
3091 // number_of_streams should be 1 since all spatial layers are sent on the
3092 // same SSRC. But encoding parameters of all layers is supposed to be copied
3093 // and stored in simulcast_layers[].
3094 EXPECT_EQ(1u, encoder_config.number_of_streams);
3095 EXPECT_EQ(encoder_config.simulcast_layers.size(), kNumSpatialLayers);
3096 EXPECT_TRUE(encoder_config.simulcast_layers[0].active);
3097 EXPECT_FALSE(encoder_config.simulcast_layers[1].active);
3098 EXPECT_TRUE(encoder_config.simulcast_layers[2].active);
3099}
3100
asaperssonc5dabdd2016-03-21 04:15:50 -07003101class Vp9SettingsTestWithFieldTrial : public Vp9SettingsTest {
3102 public:
brandtr468da7c2016-11-22 02:16:47 -08003103 explicit Vp9SettingsTestWithFieldTrial(const char* field_trials)
asaperssonc5dabdd2016-03-21 04:15:50 -07003104 : Vp9SettingsTest(field_trials) {}
3105
3106 protected:
3107 void VerifySettings(int num_spatial_layers, int num_temporal_layers) {
3108 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003109 parameters.codecs.push_back(GetEngineCodec("VP9"));
asaperssonc5dabdd2016-03-21 04:15:50 -07003110 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3111
3112 FakeVideoSendStream* stream = SetUpSimulcast(false, false);
3113
Niels Möller805a27e2019-01-21 12:21:27 +01003114 webrtc::test::FrameForwarder frame_forwarder;
3115 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
asaperssonc5dabdd2016-03-21 04:15:50 -07003116 channel_->SetSend(true);
3117
Niels Möller805a27e2019-01-21 12:21:27 +01003118 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
asaperssonc5dabdd2016-03-21 04:15:50 -07003119
3120 webrtc::VideoCodecVP9 vp9_settings;
3121 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3122 EXPECT_EQ(num_spatial_layers, vp9_settings.numberOfSpatialLayers);
3123 EXPECT_EQ(num_temporal_layers, vp9_settings.numberOfTemporalLayers);
3124
Niels Möllerff40b142018-04-09 08:49:14 +02003125 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
asaperssonc5dabdd2016-03-21 04:15:50 -07003126 }
3127};
3128
3129class Vp9SettingsTestWithNoFlag : public Vp9SettingsTestWithFieldTrial {
3130 public:
3131 Vp9SettingsTestWithNoFlag() : Vp9SettingsTestWithFieldTrial("") {}
3132};
3133
3134TEST_F(Vp9SettingsTestWithNoFlag, VerifySettings) {
3135 const int kNumSpatialLayers = 1;
3136 const int kNumTemporalLayers = 1;
3137 VerifySettings(kNumSpatialLayers, kNumTemporalLayers);
3138}
3139
3140class Vp9SettingsTestWithInvalidFlag : public Vp9SettingsTestWithFieldTrial {
3141 public:
3142 Vp9SettingsTestWithInvalidFlag()
3143 : Vp9SettingsTestWithFieldTrial("WebRTC-SupportVP9SVC/Default/") {}
3144};
3145
3146TEST_F(Vp9SettingsTestWithInvalidFlag, VerifySettings) {
3147 const int kNumSpatialLayers = 1;
3148 const int kNumTemporalLayers = 1;
3149 VerifySettings(kNumSpatialLayers, kNumTemporalLayers);
3150}
3151
3152class Vp9SettingsTestWith2SL3TLFlag : public Vp9SettingsTestWithFieldTrial {
3153 public:
3154 Vp9SettingsTestWith2SL3TLFlag()
3155 : Vp9SettingsTestWithFieldTrial(
3156 "WebRTC-SupportVP9SVC/EnabledByFlag_2SL3TL/") {}
3157};
3158
3159TEST_F(Vp9SettingsTestWith2SL3TLFlag, VerifySettings) {
3160 const int kNumSpatialLayers = 2;
3161 const int kNumTemporalLayers = 3;
3162 VerifySettings(kNumSpatialLayers, kNumTemporalLayers);
3163}
3164
Åsa Persson45bbc8a2017-11-13 10:16:47 +01003165TEST_F(WebRtcVideoChannelTest, VerifyMinBitrate) {
3166 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3167 ASSERT_EQ(1u, streams.size());
3168 EXPECT_EQ(cricket::kMinVideoBitrateBps, streams[0].min_bitrate_bps);
3169}
3170
3171TEST_F(WebRtcVideoChannelTest, VerifyMinBitrateWithForcedFallbackFieldTrial) {
3172 webrtc::test::ScopedFieldTrials override_field_trials_(
3173 "WebRTC-VP8-Forced-Fallback-Encoder-v2/Enabled-1,2,34567/");
3174 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3175 ASSERT_EQ(1u, streams.size());
3176 EXPECT_EQ(34567, streams[0].min_bitrate_bps);
3177}
3178
asapersson3c81a1a2017-06-14 05:52:21 -07003179TEST_F(WebRtcVideoChannelTest,
3180 BalancedDegradationPreferenceNotSupportedWithoutFieldtrial) {
3181 webrtc::test::ScopedFieldTrials override_field_trials_(
3182 "WebRTC-Video-BalancedDegradation/Disabled/");
3183 const bool kResolutionScalingEnabled = true;
3184 const bool kFpsScalingEnabled = false;
3185 TestDegradationPreference(kResolutionScalingEnabled, kFpsScalingEnabled);
3186}
3187
3188TEST_F(WebRtcVideoChannelTest,
3189 BalancedDegradationPreferenceSupportedBehindFieldtrial) {
3190 webrtc::test::ScopedFieldTrials override_field_trials_(
3191 "WebRTC-Video-BalancedDegradation/Enabled/");
3192 const bool kResolutionScalingEnabled = true;
3193 const bool kFpsScalingEnabled = true;
3194 TestDegradationPreference(kResolutionScalingEnabled, kFpsScalingEnabled);
3195}
3196
eladalonf1841382017-06-12 01:16:46 -07003197TEST_F(WebRtcVideoChannelTest, AdaptsOnOveruse) {
Erik Språngefbde372015-04-29 16:21:28 +02003198 TestCpuAdaptation(true, false);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003199}
3200
eladalonf1841382017-06-12 01:16:46 -07003201TEST_F(WebRtcVideoChannelTest, DoesNotAdaptOnOveruseWhenDisabled) {
Erik Språngefbde372015-04-29 16:21:28 +02003202 TestCpuAdaptation(false, false);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003203}
3204
Niels Möller3de32e62019-01-18 08:42:18 +01003205TEST_F(WebRtcVideoChannelTest, DoesNotAdaptWhenScreeensharing) {
3206 TestCpuAdaptation(false, true);
3207}
3208
eladalonf1841382017-06-12 01:16:46 -07003209TEST_F(WebRtcVideoChannelTest, DoesNotAdaptOnOveruseWhenScreensharing) {
Erik Språngefbde372015-04-29 16:21:28 +02003210 TestCpuAdaptation(true, true);
3211}
3212
eladalonf1841382017-06-12 01:16:46 -07003213TEST_F(WebRtcVideoChannelTest, PreviousAdaptationDoesNotApplyToScreenshare) {
magjed509e4fe2016-11-18 01:34:11 -08003214 cricket::VideoCodec codec = GetEngineCodec("VP8");
Per766ad3b2016-04-05 15:23:49 +02003215 cricket::VideoSendParameters parameters;
3216 parameters.codecs.push_back(codec);
3217
kthelgason2bc68642017-02-07 07:02:22 -08003218 MediaConfig media_config = GetMediaConfig();
Niels Möller1d7ecd22018-01-18 15:25:12 +01003219 media_config.video.enable_cpu_adaptation = true;
Sebastian Jansson84848f22018-11-16 10:40:36 +01003220 channel_.reset(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07003221 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003222 channel_->OnReadyToSend(true);
Per766ad3b2016-04-05 15:23:49 +02003223 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3224
3225 AddSendStream();
Niels Möller805a27e2019-01-21 12:21:27 +01003226 webrtc::test::FrameForwarder frame_forwarder;
Per766ad3b2016-04-05 15:23:49 +02003227
Per766ad3b2016-04-05 15:23:49 +02003228 ASSERT_TRUE(channel_->SetSend(true));
3229 cricket::VideoOptions camera_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003230 camera_options.is_screencast = false;
Niels Möller805a27e2019-01-21 12:21:27 +01003231 channel_->SetVideoSend(last_ssrc_, &camera_options, &frame_forwarder);
Per766ad3b2016-04-05 15:23:49 +02003232
3233 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3234 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
Per766ad3b2016-04-05 15:23:49 +02003235
Niels Möllerdcc70292019-01-15 16:32:38 +01003236 EXPECT_TRUE(send_stream->resolution_scaling_enabled());
3237 // Dont' expect anything on framerate_scaling_enabled, since the default is
3238 // transitioning from MAINTAIN_FRAMERATE to BALANCED.
Per766ad3b2016-04-05 15:23:49 +02003239
Niels Möllerdcc70292019-01-15 16:32:38 +01003240 // Switch to screen share. Expect no resolution scaling.
Per766ad3b2016-04-05 15:23:49 +02003241 cricket::VideoOptions screenshare_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003242 screenshare_options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01003243 channel_->SetVideoSend(last_ssrc_, &screenshare_options, &frame_forwarder);
sprangf24a0642017-02-28 13:23:26 -08003244 ASSERT_EQ(2, fake_call_->GetNumCreatedSendStreams());
3245 send_stream = fake_call_->GetVideoSendStreams().front();
Niels Möllerdcc70292019-01-15 16:32:38 +01003246 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
Per766ad3b2016-04-05 15:23:49 +02003247
Niels Möllerdcc70292019-01-15 16:32:38 +01003248 // Switch back to the normal capturer. Expect resolution scaling to be
3249 // reenabled.
Niels Möller805a27e2019-01-21 12:21:27 +01003250 channel_->SetVideoSend(last_ssrc_, &camera_options, &frame_forwarder);
3251 send_stream = fake_call_->GetVideoSendStreams().front();
sprangf24a0642017-02-28 13:23:26 -08003252 ASSERT_EQ(3, fake_call_->GetNumCreatedSendStreams());
3253 send_stream = fake_call_->GetVideoSendStreams().front();
Niels Möllerdcc70292019-01-15 16:32:38 +01003254 EXPECT_TRUE(send_stream->resolution_scaling_enabled());
Per766ad3b2016-04-05 15:23:49 +02003255
Niels Möllerff40b142018-04-09 08:49:14 +02003256 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Per766ad3b2016-04-05 15:23:49 +02003257}
3258
asapersson3c81a1a2017-06-14 05:52:21 -07003259// TODO(asapersson): Remove this test when the balanced field trial is removed.
3260void WebRtcVideoChannelTest::TestDegradationPreference(
3261 bool resolution_scaling_enabled,
3262 bool fps_scaling_enabled) {
3263 cricket::VideoCodec codec = GetEngineCodec("VP8");
3264 cricket::VideoSendParameters parameters;
3265 parameters.codecs.push_back(codec);
3266
3267 MediaConfig media_config = GetMediaConfig();
Niels Möller1d7ecd22018-01-18 15:25:12 +01003268 media_config.video.enable_cpu_adaptation = true;
Sebastian Jansson84848f22018-11-16 10:40:36 +01003269 channel_.reset(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07003270 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
asapersson3c81a1a2017-06-14 05:52:21 -07003271 channel_->OnReadyToSend(true);
3272
3273 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3274
3275 AddSendStream();
3276
Niels Möller805a27e2019-01-21 12:21:27 +01003277 webrtc::test::FrameForwarder frame_forwarder;
asapersson3c81a1a2017-06-14 05:52:21 -07003278 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01003279 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
asapersson3c81a1a2017-06-14 05:52:21 -07003280
3281 EXPECT_TRUE(channel_->SetSend(true));
3282
3283 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
3284 EXPECT_EQ(resolution_scaling_enabled,
3285 send_stream->resolution_scaling_enabled());
3286 EXPECT_EQ(fps_scaling_enabled, send_stream->framerate_scaling_enabled());
3287
Niels Möllerff40b142018-04-09 08:49:14 +02003288 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
asapersson3c81a1a2017-06-14 05:52:21 -07003289}
3290
eladalonf1841382017-06-12 01:16:46 -07003291void WebRtcVideoChannelTest::TestCpuAdaptation(bool enable_overuse,
3292 bool is_screenshare) {
magjed509e4fe2016-11-18 01:34:11 -08003293 cricket::VideoCodec codec = GetEngineCodec("VP8");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003294 cricket::VideoSendParameters parameters;
3295 parameters.codecs.push_back(codec);
nisse51542be2016-02-12 02:27:06 -08003296
kthelgason2bc68642017-02-07 07:02:22 -08003297 MediaConfig media_config = GetMediaConfig();
3298 if (enable_overuse) {
Niels Möller1d7ecd22018-01-18 15:25:12 +01003299 media_config.video.enable_cpu_adaptation = true;
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003300 }
Sebastian Jansson84848f22018-11-16 10:40:36 +01003301 channel_.reset(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07003302 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003303 channel_->OnReadyToSend(true);
nisse51542be2016-02-12 02:27:06 -08003304
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003305 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003306
3307 AddSendStream();
3308
Niels Möller805a27e2019-01-21 12:21:27 +01003309 webrtc::test::FrameForwarder frame_forwarder;
nisse05103312016-03-16 02:22:50 -07003310 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003311 options.is_screencast = is_screenshare;
Niels Möller805a27e2019-01-21 12:21:27 +01003312 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003313
3314 EXPECT_TRUE(channel_->SetSend(true));
3315
solenberge5269742015-09-08 05:13:22 -07003316 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
perkj2d5f0912016-02-29 00:04:41 -08003317
sprangc5d62e22017-04-02 23:53:04 -07003318 if (!enable_overuse) {
perkj803d97f2016-11-01 11:45:46 -07003319 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
sprangc5d62e22017-04-02 23:53:04 -07003320 EXPECT_FALSE(send_stream->framerate_scaling_enabled());
Niels Möller805a27e2019-01-21 12:21:27 +01003321 } else if (is_screenshare) {
sprangc5d62e22017-04-02 23:53:04 -07003322 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
3323 EXPECT_TRUE(send_stream->framerate_scaling_enabled());
3324 } else {
3325 EXPECT_TRUE(send_stream->resolution_scaling_enabled());
3326 EXPECT_FALSE(send_stream->framerate_scaling_enabled());
3327 }
Niels Möllerff40b142018-04-09 08:49:14 +02003328 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003329}
3330
eladalonf1841382017-06-12 01:16:46 -07003331TEST_F(WebRtcVideoChannelTest, EstimatesNtpStartTimeCorrectly) {
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003332 // Start at last timestamp to verify that wraparounds are estimated correctly.
3333 static const uint32_t kInitialTimestamp = 0xFFFFFFFFu;
3334 static const int64_t kInitialNtpTimeMs = 1247891230;
3335 static const int kFrameOffsetMs = 20;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003336 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003337
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003338 FakeVideoReceiveStream* stream = AddRecvStream();
3339 cricket::FakeVideoRenderer renderer;
nisse08582ff2016-02-04 01:24:52 -08003340 EXPECT_TRUE(channel_->SetSink(last_ssrc_, &renderer));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003341
Artem Titov1ebfb6a2019-01-03 23:49:37 +01003342 webrtc::VideoFrame video_frame =
3343 webrtc::VideoFrame::Builder()
3344 .set_video_frame_buffer(CreateBlackFrameBuffer(4, 4))
3345 .set_timestamp_rtp(kInitialTimestamp)
3346 .set_timestamp_us(0)
3347 .set_rotation(webrtc::kVideoRotation_0)
3348 .build();
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003349 // Initial NTP time is not available on the first frame, but should still be
3350 // able to be estimated.
nisseeb83a1a2016-03-21 01:27:56 -07003351 stream->InjectFrame(video_frame);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003352
3353 EXPECT_EQ(1, renderer.num_rendered_frames());
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003354
3355 // This timestamp is kInitialTimestamp (-1) + kFrameOffsetMs * 90, which
3356 // triggers a constant-overflow warning, hence we're calculating it explicitly
3357 // here.
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +02003358 fake_clock_.AdvanceTimeMicros(kFrameOffsetMs * rtc::kNumMicrosecsPerMillisec);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003359 video_frame.set_timestamp(kFrameOffsetMs * 90 - 1);
3360 video_frame.set_ntp_time_ms(kInitialNtpTimeMs + kFrameOffsetMs);
nisseeb83a1a2016-03-21 01:27:56 -07003361 stream->InjectFrame(video_frame);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003362
3363 EXPECT_EQ(2, renderer.num_rendered_frames());
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003364
3365 // Verify that NTP time has been correctly deduced.
3366 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00003367 ASSERT_TRUE(channel_->GetStats(&info));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003368 ASSERT_EQ(1u, info.receivers.size());
3369 EXPECT_EQ(kInitialNtpTimeMs, info.receivers[0].capture_start_ntp_time_ms);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003370}
3371
eladalonf1841382017-06-12 01:16:46 -07003372TEST_F(WebRtcVideoChannelTest, SetDefaultSendCodecs) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02003373 AssignDefaultAptRtxTypes();
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003374 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003375
3376 VideoCodec codec;
3377 EXPECT_TRUE(channel_->GetSendCodec(&codec));
pbos@webrtc.org9fbb7172014-06-13 09:34:13 +00003378 EXPECT_TRUE(codec.Matches(engine_.codecs()[0]));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003379
3380 // Using a RTX setup to verify that the default RTX payload type is good.
Peter Boström0c4e06b2015-10-07 12:23:21 +02003381 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
3382 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003383 FakeVideoSendStream* stream = AddSendStream(
3384 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
perkj26091b12016-09-01 01:17:40 -07003385 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003386
3387 // Make sure NACK and FEC are enabled on the correct payload types.
3388 EXPECT_EQ(1000, config.rtp.nack.rtp_history_ms);
magjed509e4fe2016-11-18 01:34:11 -08003389 EXPECT_EQ(GetEngineCodec("ulpfec").id, config.rtp.ulpfec.ulpfec_payload_type);
3390 EXPECT_EQ(GetEngineCodec("red").id, config.rtp.ulpfec.red_payload_type);
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003391
3392 EXPECT_EQ(1u, config.rtp.rtx.ssrcs.size());
3393 EXPECT_EQ(kRtxSsrcs1[0], config.rtp.rtx.ssrcs[0]);
Shao Changbine62202f2015-04-21 20:24:50 +08003394 VerifySendStreamHasRtxTypes(config, default_apt_rtx_types_);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003395 // TODO(juberti): Check RTCP, PLI, TMMBR.
3396}
3397
brandtr31bd2242017-05-19 05:47:46 -07003398// The following four tests ensures that FlexFEC is not activated by default
3399// when the field trials are not enabled.
3400// TODO(brandtr): Remove or update these tests when FlexFEC _is_ enabled by
3401// default.
Yves Gerey665174f2018-06-19 15:03:05 +02003402TEST_F(WebRtcVideoChannelTest, FlexfecSendCodecWithoutSsrcNotExposedByDefault) {
brandtr468da7c2016-11-22 02:16:47 -08003403 FakeVideoSendStream* stream = AddSendStream();
3404 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3405
brandtr3d200bd2017-01-16 06:59:19 -08003406 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr31bd2242017-05-19 05:47:46 -07003407 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3408 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
brandtr468da7c2016-11-22 02:16:47 -08003409}
3410
eladalonf1841382017-06-12 01:16:46 -07003411TEST_F(WebRtcVideoChannelTest, FlexfecSendCodecWithSsrcNotExposedByDefault) {
brandtr468da7c2016-11-22 02:16:47 -08003412 FakeVideoSendStream* stream = AddSendStream(
3413 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3414 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3415
brandtr3d200bd2017-01-16 06:59:19 -08003416 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr31bd2242017-05-19 05:47:46 -07003417 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3418 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3419}
3420
Yves Gerey665174f2018-06-19 15:03:05 +02003421TEST_F(WebRtcVideoChannelTest, FlexfecRecvCodecWithoutSsrcNotExposedByDefault) {
brandtr31bd2242017-05-19 05:47:46 -07003422 AddRecvStream();
3423
3424 const std::vector<FakeFlexfecReceiveStream*>& streams =
3425 fake_call_->GetFlexfecReceiveStreams();
3426 EXPECT_TRUE(streams.empty());
3427}
3428
eladalonf1841382017-06-12 01:16:46 -07003429TEST_F(WebRtcVideoChannelTest, FlexfecRecvCodecWithSsrcNotExposedByDefault) {
brandtr31bd2242017-05-19 05:47:46 -07003430 AddRecvStream(
3431 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3432
3433 const std::vector<FakeFlexfecReceiveStream*>& streams =
3434 fake_call_->GetFlexfecReceiveStreams();
3435 EXPECT_TRUE(streams.empty());
brandtr468da7c2016-11-22 02:16:47 -08003436}
3437
3438// TODO(brandtr): When FlexFEC is no longer behind a field trial, merge all
3439// tests that use this test fixture into the corresponding "non-field trial"
3440// tests.
eladalonf1841382017-06-12 01:16:46 -07003441class WebRtcVideoChannelFlexfecRecvTest : public WebRtcVideoChannelTest {
brandtr468da7c2016-11-22 02:16:47 -08003442 public:
eladalonf1841382017-06-12 01:16:46 -07003443 WebRtcVideoChannelFlexfecRecvTest()
3444 : WebRtcVideoChannelTest("WebRTC-FlexFEC-03-Advertised/Enabled/") {}
brandtr468da7c2016-11-22 02:16:47 -08003445};
3446
eladalonf1841382017-06-12 01:16:46 -07003447TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr36e7d702017-01-13 07:15:54 -08003448 DefaultFlexfecCodecHasTransportCcAndRembFeedbackParam) {
3449 EXPECT_TRUE(cricket::HasTransportCc(GetEngineCodec("flexfec-03")));
3450 EXPECT_TRUE(cricket::HasRemb(GetEngineCodec("flexfec-03")));
3451}
3452
eladalonf1841382017-06-12 01:16:46 -07003453TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetDefaultRecvCodecsWithoutSsrc) {
brandtr31bd2242017-05-19 05:47:46 -07003454 AddRecvStream();
3455
3456 const std::vector<FakeFlexfecReceiveStream*>& streams =
3457 fake_call_->GetFlexfecReceiveStreams();
3458 EXPECT_TRUE(streams.empty());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003459
3460 const std::vector<FakeVideoReceiveStream*>& video_streams =
3461 fake_call_->GetVideoReceiveStreams();
3462 ASSERT_EQ(1U, video_streams.size());
3463 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3464 EXPECT_EQ(0, video_stream.GetNumAddedSecondarySinks());
3465 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr31bd2242017-05-19 05:47:46 -07003466}
3467
eladalonf1841382017-06-12 01:16:46 -07003468TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetDefaultRecvCodecsWithSsrc) {
brandtr31bd2242017-05-19 05:47:46 -07003469 AddRecvStream(
3470 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3471
3472 const std::vector<FakeFlexfecReceiveStream*>& streams =
3473 fake_call_->GetFlexfecReceiveStreams();
3474 ASSERT_EQ(1U, streams.size());
3475 const FakeFlexfecReceiveStream* stream = streams.front();
3476 const webrtc::FlexfecReceiveStream::Config& config = stream->GetConfig();
3477 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.payload_type);
3478 EXPECT_EQ(kFlexfecSsrc, config.remote_ssrc);
3479 ASSERT_EQ(1U, config.protected_media_ssrcs.size());
3480 EXPECT_EQ(kSsrcs1[0], config.protected_media_ssrcs[0]);
brandtr7cd28b92017-09-22 00:26:25 -07003481
3482 const std::vector<FakeVideoReceiveStream*>& video_streams =
3483 fake_call_->GetVideoReceiveStreams();
3484 ASSERT_EQ(1U, video_streams.size());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003485 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3486 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
brandtr7cd28b92017-09-22 00:26:25 -07003487 const webrtc::VideoReceiveStream::Config& video_config =
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003488 video_stream.GetConfig();
brandtr7cd28b92017-09-22 00:26:25 -07003489 EXPECT_TRUE(video_config.rtp.protected_by_flexfec);
brandtr31bd2242017-05-19 05:47:46 -07003490}
3491
eladalonf1841382017-06-12 01:16:46 -07003492TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr11fb4722017-05-30 01:31:37 -07003493 EnablingFlexfecDoesNotRecreateVideoReceiveStream) {
3494 cricket::VideoRecvParameters recv_parameters;
3495 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3496 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3497
3498 AddRecvStream(
3499 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3500 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003501 const std::vector<FakeVideoReceiveStream*>& video_streams =
3502 fake_call_->GetVideoReceiveStreams();
3503 ASSERT_EQ(1U, video_streams.size());
3504 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3505 EXPECT_EQ(0, video_stream.GetNumAddedSecondarySinks());
3506 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003507
3508 // Enable FlexFEC.
3509 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3510 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3511 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams())
3512 << "Enabling FlexFEC should create FlexfecReceiveStream.";
3513 EXPECT_EQ(1U, fake_call_->GetVideoReceiveStreams().size())
3514 << "Enabling FlexFEC should not create VideoReceiveStream.";
3515 EXPECT_EQ(1U, fake_call_->GetFlexfecReceiveStreams().size())
3516 << "Enabling FlexFEC should create a single FlexfecReceiveStream.";
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003517 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3518 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003519}
3520
eladalonf1841382017-06-12 01:16:46 -07003521TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr11fb4722017-05-30 01:31:37 -07003522 DisablingFlexfecDoesNotRecreateVideoReceiveStream) {
3523 cricket::VideoRecvParameters recv_parameters;
3524 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3525 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3526 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3527
3528 AddRecvStream(
3529 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3530 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams());
brandtr11fb4722017-05-30 01:31:37 -07003531 EXPECT_EQ(1U, fake_call_->GetFlexfecReceiveStreams().size());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003532 const std::vector<FakeVideoReceiveStream*>& video_streams =
3533 fake_call_->GetVideoReceiveStreams();
3534 ASSERT_EQ(1U, video_streams.size());
3535 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3536 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3537 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003538
3539 // Disable FlexFEC.
3540 recv_parameters.codecs.clear();
3541 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3542 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3543 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams())
3544 << "Disabling FlexFEC should not recreate VideoReceiveStream.";
3545 EXPECT_EQ(1U, fake_call_->GetVideoReceiveStreams().size())
3546 << "Disabling FlexFEC should not destroy VideoReceiveStream.";
3547 EXPECT_TRUE(fake_call_->GetFlexfecReceiveStreams().empty())
3548 << "Disabling FlexFEC should destroy FlexfecReceiveStream.";
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003549 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3550 EXPECT_EQ(1, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003551}
3552
brandtr31bd2242017-05-19 05:47:46 -07003553// TODO(brandtr): When FlexFEC is no longer behind a field trial, merge all
3554// tests that use this test fixture into the corresponding "non-field trial"
3555// tests.
eladalonf1841382017-06-12 01:16:46 -07003556class WebRtcVideoChannelFlexfecSendRecvTest : public WebRtcVideoChannelTest {
brandtr31bd2242017-05-19 05:47:46 -07003557 public:
eladalonf1841382017-06-12 01:16:46 -07003558 WebRtcVideoChannelFlexfecSendRecvTest()
3559 : WebRtcVideoChannelTest(
brandtr31bd2242017-05-19 05:47:46 -07003560 "WebRTC-FlexFEC-03-Advertised/Enabled/WebRTC-FlexFEC-03/Enabled/") {
3561 }
3562};
3563
Yves Gerey665174f2018-06-19 15:03:05 +02003564TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetDefaultSendCodecsWithoutSsrc) {
brandtr468da7c2016-11-22 02:16:47 -08003565 FakeVideoSendStream* stream = AddSendStream();
3566 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3567
brandtr3d200bd2017-01-16 06:59:19 -08003568 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3569 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3570 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
brandtr468da7c2016-11-22 02:16:47 -08003571}
3572
eladalonf1841382017-06-12 01:16:46 -07003573TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetDefaultSendCodecsWithSsrc) {
brandtr468da7c2016-11-22 02:16:47 -08003574 FakeVideoSendStream* stream = AddSendStream(
3575 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3576 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3577
brandtr3d200bd2017-01-16 06:59:19 -08003578 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3579 EXPECT_EQ(kFlexfecSsrc, config.rtp.flexfec.ssrc);
3580 ASSERT_EQ(1U, config.rtp.flexfec.protected_media_ssrcs.size());
3581 EXPECT_EQ(kSsrcs1[0], config.rtp.flexfec.protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08003582}
3583
eladalonf1841382017-06-12 01:16:46 -07003584TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003585 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003586 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003587 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003588
3589 FakeVideoSendStream* stream = AddSendStream();
perkj26091b12016-09-01 01:17:40 -07003590 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003591
brandtrb5f2c3f2016-10-04 23:28:39 -07003592 EXPECT_EQ(-1, config.rtp.ulpfec.ulpfec_payload_type);
3593 EXPECT_EQ(-1, config.rtp.ulpfec.red_payload_type);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003594}
3595
eladalonf1841382017-06-12 01:16:46 -07003596TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetSendCodecsWithoutFec) {
brandtr468da7c2016-11-22 02:16:47 -08003597 cricket::VideoSendParameters parameters;
3598 parameters.codecs.push_back(GetEngineCodec("VP8"));
3599 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3600
3601 FakeVideoSendStream* stream = AddSendStream();
3602 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3603
brandtr3d200bd2017-01-16 06:59:19 -08003604 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr468da7c2016-11-22 02:16:47 -08003605}
3606
eladalonf1841382017-06-12 01:16:46 -07003607TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetRecvCodecsWithFec) {
brandtr9c3d4c42017-01-23 06:59:13 -08003608 AddRecvStream(
3609 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08003610
3611 cricket::VideoRecvParameters recv_parameters;
3612 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3613 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3614 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
brandtr9d58d942017-02-03 04:43:41 -08003615
3616 const std::vector<FakeFlexfecReceiveStream*>& flexfec_streams =
3617 fake_call_->GetFlexfecReceiveStreams();
3618 ASSERT_EQ(1U, flexfec_streams.size());
3619 const FakeFlexfecReceiveStream* flexfec_stream = flexfec_streams.front();
3620 const webrtc::FlexfecReceiveStream::Config& flexfec_stream_config =
3621 flexfec_stream->GetConfig();
brandtr9c3d4c42017-01-23 06:59:13 -08003622 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9d58d942017-02-03 04:43:41 -08003623 flexfec_stream_config.payload_type);
3624 EXPECT_EQ(kFlexfecSsrc, flexfec_stream_config.remote_ssrc);
3625 ASSERT_EQ(1U, flexfec_stream_config.protected_media_ssrcs.size());
3626 EXPECT_EQ(kSsrcs1[0], flexfec_stream_config.protected_media_ssrcs[0]);
3627 const std::vector<FakeVideoReceiveStream*>& video_streams =
3628 fake_call_->GetVideoReceiveStreams();
3629 const FakeVideoReceiveStream* video_stream = video_streams.front();
3630 const webrtc::VideoReceiveStream::Config& video_stream_config =
3631 video_stream->GetConfig();
3632 EXPECT_EQ(video_stream_config.rtp.local_ssrc,
3633 flexfec_stream_config.local_ssrc);
3634 EXPECT_EQ(video_stream_config.rtp.rtcp_mode, flexfec_stream_config.rtcp_mode);
3635 EXPECT_EQ(video_stream_config.rtcp_send_transport,
3636 flexfec_stream_config.rtcp_send_transport);
3637 // TODO(brandtr): Update this EXPECT when we set |transport_cc| in a
3638 // spec-compliant way.
3639 EXPECT_EQ(video_stream_config.rtp.transport_cc,
3640 flexfec_stream_config.transport_cc);
3641 EXPECT_EQ(video_stream_config.rtp.rtcp_mode, flexfec_stream_config.rtcp_mode);
3642 EXPECT_EQ(video_stream_config.rtp.extensions,
3643 flexfec_stream_config.rtp_header_extensions);
brandtr9c3d4c42017-01-23 06:59:13 -08003644}
3645
brandtr31bd2242017-05-19 05:47:46 -07003646// We should not send FlexFEC, even if we advertise it, unless the right
3647// field trial is set.
3648// TODO(brandtr): Remove when FlexFEC is enabled by default.
eladalonf1841382017-06-12 01:16:46 -07003649TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003650 SetSendCodecsWithoutSsrcWithFecDoesNotEnableFec) {
3651 cricket::VideoSendParameters parameters;
3652 parameters.codecs.push_back(GetEngineCodec("VP8"));
3653 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3654 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3655
3656 FakeVideoSendStream* stream = AddSendStream();
3657 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3658
3659 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
Mirko Bonadeif859e552018-05-30 15:31:29 +02003660 EXPECT_EQ(0u, config.rtp.flexfec.ssrc);
brandtr31bd2242017-05-19 05:47:46 -07003661 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3662}
3663
eladalonf1841382017-06-12 01:16:46 -07003664TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003665 SetSendCodecsWithSsrcWithFecDoesNotEnableFec) {
3666 cricket::VideoSendParameters parameters;
3667 parameters.codecs.push_back(GetEngineCodec("VP8"));
3668 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3669 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3670
3671 FakeVideoSendStream* stream = AddSendStream(
3672 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3673 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3674
3675 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
Mirko Bonadeif859e552018-05-30 15:31:29 +02003676 EXPECT_EQ(0u, config.rtp.flexfec.ssrc);
brandtr31bd2242017-05-19 05:47:46 -07003677 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3678}
3679
eladalonf1841382017-06-12 01:16:46 -07003680TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003681 SetSendCodecRejectsRtxWithoutAssociatedPayloadType) {
magjed509e4fe2016-11-18 01:34:11 -08003682 const int kUnusedPayloadType = 127;
3683 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType));
3684
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003685 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003686 cricket::VideoCodec rtx_codec(kUnusedPayloadType, "rtx");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003687 parameters.codecs.push_back(rtx_codec);
3688 EXPECT_FALSE(channel_->SetSendParameters(parameters))
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003689 << "RTX codec without associated payload type should be rejected.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003690}
3691
eladalonf1841382017-06-12 01:16:46 -07003692TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003693 SetSendCodecRejectsRtxWithoutMatchingVideoCodec) {
magjed509e4fe2016-11-18 01:34:11 -08003694 const int kUnusedPayloadType1 = 126;
3695 const int kUnusedPayloadType2 = 127;
3696 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
3697 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
3698 {
3699 cricket::VideoCodec rtx_codec = cricket::VideoCodec::CreateRtxCodec(
3700 kUnusedPayloadType1, GetEngineCodec("VP8").id);
3701 cricket::VideoSendParameters parameters;
3702 parameters.codecs.push_back(GetEngineCodec("VP8"));
3703 parameters.codecs.push_back(rtx_codec);
3704 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3705 }
3706 {
3707 cricket::VideoCodec rtx_codec = cricket::VideoCodec::CreateRtxCodec(
3708 kUnusedPayloadType1, kUnusedPayloadType2);
3709 cricket::VideoSendParameters parameters;
3710 parameters.codecs.push_back(GetEngineCodec("VP8"));
3711 parameters.codecs.push_back(rtx_codec);
3712 EXPECT_FALSE(channel_->SetSendParameters(parameters))
3713 << "RTX without matching video codec should be rejected.";
3714 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003715}
3716
eladalonf1841382017-06-12 01:16:46 -07003717TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithChangedRtxPayloadType) {
brandtr14742122017-01-27 04:53:07 -08003718 const int kUnusedPayloadType1 = 126;
3719 const int kUnusedPayloadType2 = 127;
3720 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
3721 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
3722
3723 // SSRCs for RTX.
3724 cricket::StreamParams params =
3725 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
3726 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
3727 AddSendStream(params);
3728
3729 // Original payload type for RTX.
3730 cricket::VideoSendParameters parameters;
3731 parameters.codecs.push_back(GetEngineCodec("VP8"));
3732 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
3733 rtx_codec.SetParam("apt", GetEngineCodec("VP8").id);
3734 parameters.codecs.push_back(rtx_codec);
3735 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3736 ASSERT_EQ(1U, fake_call_->GetVideoSendStreams().size());
3737 const webrtc::VideoSendStream::Config& config_before =
3738 fake_call_->GetVideoSendStreams()[0]->GetConfig();
3739 EXPECT_EQ(kUnusedPayloadType1, config_before.rtp.rtx.payload_type);
3740 ASSERT_EQ(1U, config_before.rtp.rtx.ssrcs.size());
3741 EXPECT_EQ(kRtxSsrcs1[0], config_before.rtp.rtx.ssrcs[0]);
3742
3743 // Change payload type for RTX.
3744 parameters.codecs[1].id = kUnusedPayloadType2;
3745 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3746 ASSERT_EQ(1U, fake_call_->GetVideoSendStreams().size());
3747 const webrtc::VideoSendStream::Config& config_after =
3748 fake_call_->GetVideoSendStreams()[0]->GetConfig();
3749 EXPECT_EQ(kUnusedPayloadType2, config_after.rtp.rtx.payload_type);
3750 ASSERT_EQ(1U, config_after.rtp.rtx.ssrcs.size());
3751 EXPECT_EQ(kRtxSsrcs1[0], config_after.rtp.rtx.ssrcs[0]);
3752}
3753
eladalonf1841382017-06-12 01:16:46 -07003754TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutFecDisablesFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003755 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003756 parameters.codecs.push_back(GetEngineCodec("VP8"));
3757 parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003758 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003759
3760 FakeVideoSendStream* stream = AddSendStream();
perkj26091b12016-09-01 01:17:40 -07003761 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003762
magjed509e4fe2016-11-18 01:34:11 -08003763 EXPECT_EQ(GetEngineCodec("ulpfec").id, config.rtp.ulpfec.ulpfec_payload_type);
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003764
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003765 parameters.codecs.pop_back();
3766 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003767 stream = fake_call_->GetVideoSendStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08003768 ASSERT_TRUE(stream != nullptr);
perkj26091b12016-09-01 01:17:40 -07003769 config = stream->GetConfig().Copy();
brandtrb5f2c3f2016-10-04 23:28:39 -07003770 EXPECT_EQ(-1, config.rtp.ulpfec.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08003771 << "SetSendCodec without ULPFEC should disable current ULPFEC.";
3772}
3773
eladalonf1841382017-06-12 01:16:46 -07003774TEST_F(WebRtcVideoChannelFlexfecSendRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003775 SetSendCodecsWithoutFecDisablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08003776 cricket::VideoSendParameters parameters;
3777 parameters.codecs.push_back(GetEngineCodec("VP8"));
3778 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3779 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3780
3781 FakeVideoSendStream* stream = AddSendStream(
3782 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3783 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3784
brandtr3d200bd2017-01-16 06:59:19 -08003785 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3786 EXPECT_EQ(kFlexfecSsrc, config.rtp.flexfec.ssrc);
brandtr468da7c2016-11-22 02:16:47 -08003787 ASSERT_EQ(1U, config.rtp.flexfec.protected_media_ssrcs.size());
3788 EXPECT_EQ(kSsrcs1[0], config.rtp.flexfec.protected_media_ssrcs[0]);
3789
3790 parameters.codecs.pop_back();
3791 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3792 stream = fake_call_->GetVideoSendStreams()[0];
3793 ASSERT_TRUE(stream != nullptr);
3794 config = stream->GetConfig().Copy();
brandtr3d200bd2017-01-16 06:59:19 -08003795 EXPECT_EQ(-1, config.rtp.flexfec.payload_type)
brandtr468da7c2016-11-22 02:16:47 -08003796 << "SetSendCodec without FlexFEC should disable current FlexFEC.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003797}
3798
eladalonf1841382017-06-12 01:16:46 -07003799TEST_F(WebRtcVideoChannelTest, SetSendCodecsChangesExistingStreams) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003800 cricket::VideoSendParameters parameters;
perkj26752742016-10-24 01:21:16 -07003801 cricket::VideoCodec codec(100, "VP8");
3802 codec.SetParam(kCodecParamMaxQuantization, kDefaultQpMax);
3803 parameters.codecs.push_back(codec);
perkjfa10b552016-10-02 23:45:26 -07003804
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003805 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00003806 channel_->SetSend(true);
pbos@webrtc.org38ce7d02014-07-16 08:01:38 +00003807
pbos@webrtc.org86196c42015-02-16 21:02:00 +00003808 FakeVideoSendStream* stream = AddSendStream();
Niels Möller805a27e2019-01-21 12:21:27 +01003809 webrtc::test::FrameForwarder frame_forwarder;
3810 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00003811
3812 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
perkjfa10b552016-10-02 23:45:26 -07003813 EXPECT_EQ(kDefaultQpMax, streams[0].max_qp);
pbos@webrtc.org38ce7d02014-07-16 08:01:38 +00003814
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003815 parameters.codecs.clear();
perkj26752742016-10-24 01:21:16 -07003816 codec.SetParam(kCodecParamMaxQuantization, kDefaultQpMax + 1);
3817 parameters.codecs.push_back(codec);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003818 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003819 streams = fake_call_->GetVideoSendStreams()[0]->GetVideoStreams();
perkjfa10b552016-10-02 23:45:26 -07003820 EXPECT_EQ(kDefaultQpMax + 1, streams[0].max_qp);
Niels Möllerff40b142018-04-09 08:49:14 +02003821 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003822}
3823
eladalonf1841382017-06-12 01:16:46 -07003824TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithBitrates) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00003825 SetSendCodecsShouldWorkForBitrates("100", 100000, "150", 150000, "200",
3826 200000);
3827}
3828
eladalonf1841382017-06-12 01:16:46 -07003829TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithHighMaxBitrate) {
pbos@webrtc.orga5f6fb52015-03-23 22:29:39 +00003830 SetSendCodecsShouldWorkForBitrates("", 0, "", -1, "10000", 10000000);
3831 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3832 ASSERT_EQ(1u, streams.size());
3833 EXPECT_EQ(10000000, streams[0].max_bitrate_bps);
3834}
3835
eladalonf1841382017-06-12 01:16:46 -07003836TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org00873182014-11-25 14:03:34 +00003837 SetSendCodecsWithoutBitratesUsesCorrectDefaults) {
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003838 SetSendCodecsShouldWorkForBitrates("", 0, "", -1, "", -1);
pbos@webrtc.org00873182014-11-25 14:03:34 +00003839}
3840
eladalonf1841382017-06-12 01:16:46 -07003841TEST_F(WebRtcVideoChannelTest, SetSendCodecsCapsMinAndStartBitrate) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00003842 SetSendCodecsShouldWorkForBitrates("-1", 0, "-100", -1, "", -1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003843}
3844
eladalonf1841382017-06-12 01:16:46 -07003845TEST_F(WebRtcVideoChannelTest, SetSendCodecsRejectsMaxLessThanMinBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003846 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "300";
3847 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "200";
3848 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003849}
3850
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003851// Test that when both the codec-specific bitrate params and max_bandwidth_bps
3852// are present in the same send parameters, the settings are combined correctly.
eladalonf1841382017-06-12 01:16:46 -07003853TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithBitratesAndMaxSendBandwidth) {
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003854 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
3855 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
3856 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
3857 send_parameters_.max_bandwidth_bps = 400000;
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003858 // We expect max_bandwidth_bps to take priority, if set.
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003859 ExpectSetBitrateParameters(100000, 200000, 400000);
3860 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
3861 // Since the codec isn't changing, start_bitrate_bps should be -1.
3862 ExpectSetBitrateParameters(100000, -1, 350000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003863
3864 // Decrease max_bandwidth_bps.
3865 send_parameters_.max_bandwidth_bps = 350000;
3866 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003867
3868 // Now try again with the values flipped around.
3869 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "400";
3870 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003871 ExpectSetBitrateParameters(100000, 200000, 300000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003872 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003873
3874 // If we change the codec max, max_bandwidth_bps should still apply.
3875 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "350";
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003876 ExpectSetBitrateParameters(100000, 200000, 300000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003877 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003878}
3879
Yves Gerey665174f2018-06-19 15:03:05 +02003880TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthShouldPreserveOtherBitrates) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00003881 SetSendCodecsShouldWorkForBitrates("100", 100000, "150", 150000, "200",
3882 200000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003883 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003884 // Setting max bitrate should keep previous min bitrate.
3885 // Setting max bitrate should not reset start bitrate.
3886 ExpectSetBitrateParameters(100000, -1, 300000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003887 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org00873182014-11-25 14:03:34 +00003888}
3889
eladalonf1841382017-06-12 01:16:46 -07003890TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthShouldBeRemovable) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003891 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003892 ExpectSetMaxBitrate(300000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003893 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos5c7760a2017-03-10 11:23:12 -08003894 // -1 means to disable max bitrate (set infinite).
3895 send_parameters_.max_bandwidth_bps = -1;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003896 ExpectSetMaxBitrate(-1);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003897 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003898}
3899
eladalonf1841382017-06-12 01:16:46 -07003900TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthAndAddSendStream) {
perkjfa10b552016-10-02 23:45:26 -07003901 send_parameters_.max_bandwidth_bps = 99999;
3902 FakeVideoSendStream* stream = AddSendStream();
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003903 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
perkjfa10b552016-10-02 23:45:26 -07003904 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
perkjfa10b552016-10-02 23:45:26 -07003905 ASSERT_EQ(1u, stream->GetVideoStreams().size());
3906 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
3907 stream->GetVideoStreams()[0].max_bitrate_bps);
3908
3909 send_parameters_.max_bandwidth_bps = 77777;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003910 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
perkjfa10b552016-10-02 23:45:26 -07003911 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
3912 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
perkjfa10b552016-10-02 23:45:26 -07003913 stream->GetVideoStreams()[0].max_bitrate_bps);
3914}
3915
Seth Hampsonfeec91e2018-07-13 10:41:10 -07003916// Tests that when the codec specific max bitrate and VideoSendParameters
3917// max_bandwidth_bps are used, that it sets the VideoStream's max bitrate
3918// appropriately.
3919TEST_F(WebRtcVideoChannelTest,
3920 MaxBitratePrioritizesVideoSendParametersOverCodecMaxBitrate) {
3921 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
3922 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
3923 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
3924 send_parameters_.max_bandwidth_bps = -1;
3925 AddSendStream();
3926 ExpectSetMaxBitrate(300000);
3927 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
3928
3929 std::vector<FakeVideoSendStream*> video_send_streams = GetFakeSendStreams();
3930 ASSERT_EQ(1u, video_send_streams.size());
3931 FakeVideoSendStream* video_send_stream = video_send_streams[0];
3932 ASSERT_EQ(1u, video_send_streams[0]->GetVideoStreams().size());
3933 // First the max bitrate is set based upon the codec param.
3934 EXPECT_EQ(300000,
3935 video_send_streams[0]->GetVideoStreams()[0].max_bitrate_bps);
3936
3937 // The VideoSendParameters max bitrate overrides the codec's.
3938 send_parameters_.max_bandwidth_bps = 500000;
3939 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
3940 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
3941 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
3942 EXPECT_EQ(500000, video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
3943}
3944
3945// Tests that when the codec specific max bitrate and RtpParameters
3946// max_bitrate_bps are used, that it sets the VideoStream's max bitrate
3947// appropriately.
3948TEST_F(WebRtcVideoChannelTest,
3949 MaxBitratePrioritizesRtpParametersOverCodecMaxBitrate) {
3950 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
3951 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
3952 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
3953 send_parameters_.max_bandwidth_bps = -1;
3954 AddSendStream();
3955 ExpectSetMaxBitrate(300000);
3956 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
3957
3958 std::vector<FakeVideoSendStream*> video_send_streams = GetFakeSendStreams();
3959 ASSERT_EQ(1u, video_send_streams.size());
3960 FakeVideoSendStream* video_send_stream = video_send_streams[0];
3961 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
3962 // First the max bitrate is set based upon the codec param.
3963 EXPECT_EQ(300000, video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
3964
3965 // The RtpParameter max bitrate overrides the codec's.
3966 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
3967 ASSERT_EQ(1u, parameters.encodings.size());
3968 parameters.encodings[0].max_bitrate_bps = 500000;
3969 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
3970 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
3971 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps,
3972 video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
3973}
3974
Åsa Persson55659812018-06-18 17:51:32 +02003975TEST_F(WebRtcVideoChannelTest,
3976 MaxBitrateIsMinimumOfMaxSendBandwidthAndMaxEncodingBitrate) {
3977 send_parameters_.max_bandwidth_bps = 99999;
3978 FakeVideoSendStream* stream = AddSendStream();
3979 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
3980 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
3981 ASSERT_EQ(1u, stream->GetVideoStreams().size());
3982 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
3983 stream->GetVideoStreams()[0].max_bitrate_bps);
3984
3985 // Get and set the rtp encoding parameters.
3986 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
3987 EXPECT_EQ(1u, parameters.encodings.size());
3988
3989 parameters.encodings[0].max_bitrate_bps = 99999 - 1;
3990 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
3991 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps,
3992 stream->GetVideoStreams()[0].max_bitrate_bps);
3993
3994 parameters.encodings[0].max_bitrate_bps = 99999 + 1;
3995 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
3996 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
3997 stream->GetVideoStreams()[0].max_bitrate_bps);
3998}
3999
eladalonf1841382017-06-12 01:16:46 -07004000TEST_F(WebRtcVideoChannelTest, SetMaxSendBitrateCanIncreaseSenderBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004001 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004002 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004003 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004004 channel_->SetSend(true);
4005
4006 FakeVideoSendStream* stream = AddSendStream();
4007
Niels Möller805a27e2019-01-21 12:21:27 +01004008 webrtc::test::FrameForwarder frame_forwarder;
4009 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Peter Boström3afc8c42016-01-27 16:45:21 +01004010
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004011 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
4012 int initial_max_bitrate_bps = streams[0].max_bitrate_bps;
4013 EXPECT_GT(initial_max_bitrate_bps, 0);
4014
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004015 parameters.max_bandwidth_bps = initial_max_bitrate_bps * 2;
4016 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström3afc8c42016-01-27 16:45:21 +01004017 // Insert a frame to update the encoder config.
Niels Möller805a27e2019-01-21 12:21:27 +01004018 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004019 streams = stream->GetVideoStreams();
4020 EXPECT_EQ(initial_max_bitrate_bps * 2, streams[0].max_bitrate_bps);
Niels Möllerff40b142018-04-09 08:49:14 +02004021 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004022}
4023
eladalonf1841382017-06-12 01:16:46 -07004024TEST_F(WebRtcVideoChannelTest,
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004025 SetMaxSendBitrateCanIncreaseSimulcastSenderBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004026 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004027 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004028 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004029 channel_->SetSend(true);
4030
4031 FakeVideoSendStream* stream = AddSendStream(
4032 cricket::CreateSimStreamParams("cname", MAKE_VECTOR(kSsrcs3)));
4033
4034 // Send a frame to make sure this scales up to >1 stream (simulcast).
Niels Möller805a27e2019-01-21 12:21:27 +01004035 webrtc::test::FrameForwarder frame_forwarder;
4036 EXPECT_TRUE(channel_->SetVideoSend(kSsrcs3[0], nullptr, &frame_forwarder));
4037 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004038
4039 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
4040 ASSERT_GT(streams.size(), 1u)
4041 << "Without simulcast this test doesn't make sense.";
pbosbe16f792015-10-16 12:49:39 -07004042 int initial_max_bitrate_bps = GetTotalMaxBitrateBps(streams);
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004043 EXPECT_GT(initial_max_bitrate_bps, 0);
4044
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004045 parameters.max_bandwidth_bps = initial_max_bitrate_bps * 2;
4046 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström3afc8c42016-01-27 16:45:21 +01004047 // Insert a frame to update the encoder config.
Niels Möller805a27e2019-01-21 12:21:27 +01004048 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004049 streams = stream->GetVideoStreams();
pbosbe16f792015-10-16 12:49:39 -07004050 int increased_max_bitrate_bps = GetTotalMaxBitrateBps(streams);
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004051 EXPECT_EQ(initial_max_bitrate_bps * 2, increased_max_bitrate_bps);
4052
Niels Möllerff40b142018-04-09 08:49:14 +02004053 EXPECT_TRUE(channel_->SetVideoSend(kSsrcs3[0], nullptr, nullptr));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004054}
4055
eladalonf1841382017-06-12 01:16:46 -07004056TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithMaxQuantization) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004057 static const char* kMaxQuantization = "21";
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004058 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004059 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004060 parameters.codecs[0].params[kCodecParamMaxQuantization] = kMaxQuantization;
4061 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Mirko Bonadeif859e552018-05-30 15:31:29 +02004062 EXPECT_EQ(atoi(kMaxQuantization),
pbos@webrtc.org6ae48c62014-06-06 10:49:19 +00004063 AddSendStream()->GetVideoStreams().back().max_qp);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004064
4065 VideoCodec codec;
4066 EXPECT_TRUE(channel_->GetSendCodec(&codec));
4067 EXPECT_EQ(kMaxQuantization, codec.params[kCodecParamMaxQuantization]);
4068}
4069
eladalonf1841382017-06-12 01:16:46 -07004070TEST_F(WebRtcVideoChannelTest, SetSendCodecsRejectBadPayloadTypes) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004071 // TODO(pbos): Should we only allow the dynamic range?
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00004072 static const int kIncorrectPayloads[] = {-2, -1, 128, 129};
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004073 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004074 parameters.codecs.push_back(GetEngineCodec("VP8"));
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00004075 for (size_t i = 0; i < arraysize(kIncorrectPayloads); ++i) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004076 parameters.codecs[0].id = kIncorrectPayloads[i];
4077 EXPECT_FALSE(channel_->SetSendParameters(parameters))
pkasting@chromium.orgd3245462015-02-23 21:28:22 +00004078 << "Bad payload type '" << kIncorrectPayloads[i] << "' accepted.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004079 }
4080}
4081
eladalonf1841382017-06-12 01:16:46 -07004082TEST_F(WebRtcVideoChannelTest, SetSendCodecsAcceptAllValidPayloadTypes) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004083 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004084 parameters.codecs.push_back(GetEngineCodec("VP8"));
magjedf823ede2016-11-12 09:53:04 -08004085 for (int payload_type = 96; payload_type <= 127; ++payload_type) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004086 parameters.codecs[0].id = payload_type;
4087 EXPECT_TRUE(channel_->SetSendParameters(parameters))
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004088 << "Payload type '" << payload_type << "' rejected.";
4089 }
4090}
4091
deadbeef67cf2c12016-04-13 10:07:16 -07004092// Test that setting the a different set of codecs but with an identical front
4093// codec doesn't result in the stream being recreated.
4094// This may happen when a subsequent negotiation includes fewer codecs, as a
4095// result of one of the codecs being rejected.
eladalonf1841382017-06-12 01:16:46 -07004096TEST_F(WebRtcVideoChannelTest,
deadbeef67cf2c12016-04-13 10:07:16 -07004097 SetSendCodecsIdenticalFirstCodecDoesntRecreateStream) {
4098 cricket::VideoSendParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08004099 parameters1.codecs.push_back(GetEngineCodec("VP8"));
4100 parameters1.codecs.push_back(GetEngineCodec("VP9"));
deadbeef67cf2c12016-04-13 10:07:16 -07004101 EXPECT_TRUE(channel_->SetSendParameters(parameters1));
4102
4103 AddSendStream();
4104 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
4105
4106 cricket::VideoSendParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08004107 parameters2.codecs.push_back(GetEngineCodec("VP8"));
deadbeef67cf2c12016-04-13 10:07:16 -07004108 EXPECT_TRUE(channel_->SetSendParameters(parameters2));
4109 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
4110}
4111
eladalonf1841382017-06-12 01:16:46 -07004112TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithOnlyVp8) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004113 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004114 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004115 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004116}
4117
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004118// Test that we set our inbound RTX codecs properly.
eladalonf1841382017-06-12 01:16:46 -07004119TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithRtx) {
magjed509e4fe2016-11-18 01:34:11 -08004120 const int kUnusedPayloadType1 = 126;
4121 const int kUnusedPayloadType2 = 127;
4122 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4123 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4124
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004125 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004126 parameters.codecs.push_back(GetEngineCodec("VP8"));
4127 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004128 parameters.codecs.push_back(rtx_codec);
4129 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004130 << "RTX codec without associated payload should be rejected.";
4131
magjed509e4fe2016-11-18 01:34:11 -08004132 parameters.codecs[1].SetParam("apt", kUnusedPayloadType2);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004133 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004134 << "RTX codec with invalid associated payload type should be rejected.";
4135
magjed509e4fe2016-11-18 01:34:11 -08004136 parameters.codecs[1].SetParam("apt", GetEngineCodec("VP8").id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004137 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004138
magjed509e4fe2016-11-18 01:34:11 -08004139 cricket::VideoCodec rtx_codec2(kUnusedPayloadType2, "rtx");
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004140 rtx_codec2.SetParam("apt", rtx_codec.id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004141 parameters.codecs.push_back(rtx_codec2);
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004142
Yves Gerey665174f2018-06-19 15:03:05 +02004143 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
4144 << "RTX codec with another RTX as associated payload type should be "
4145 "rejected.";
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004146}
4147
eladalonf1841382017-06-12 01:16:46 -07004148TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithChangedRtxPayloadType) {
brandtr14742122017-01-27 04:53:07 -08004149 const int kUnusedPayloadType1 = 126;
4150 const int kUnusedPayloadType2 = 127;
4151 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4152 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4153
4154 // SSRCs for RTX.
4155 cricket::StreamParams params =
4156 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
4157 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
4158 AddRecvStream(params);
4159
4160 // Original payload type for RTX.
4161 cricket::VideoRecvParameters parameters;
4162 parameters.codecs.push_back(GetEngineCodec("VP8"));
4163 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
4164 rtx_codec.SetParam("apt", GetEngineCodec("VP8").id);
4165 parameters.codecs.push_back(rtx_codec);
4166 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4167 ASSERT_EQ(1U, fake_call_->GetVideoReceiveStreams().size());
4168 const webrtc::VideoReceiveStream::Config& config_before =
4169 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
nisse26e3abb2017-08-25 04:44:25 -07004170 EXPECT_EQ(1U, config_before.rtp.rtx_associated_payload_types.size());
4171 const int* payload_type_before = FindKeyByValue(
4172 config_before.rtp.rtx_associated_payload_types, GetEngineCodec("VP8").id);
4173 ASSERT_NE(payload_type_before, nullptr);
4174 EXPECT_EQ(kUnusedPayloadType1, *payload_type_before);
brandtr14742122017-01-27 04:53:07 -08004175 EXPECT_EQ(kRtxSsrcs1[0], config_before.rtp.rtx_ssrc);
4176
4177 // Change payload type for RTX.
4178 parameters.codecs[1].id = kUnusedPayloadType2;
4179 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4180 ASSERT_EQ(1U, fake_call_->GetVideoReceiveStreams().size());
4181 const webrtc::VideoReceiveStream::Config& config_after =
4182 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
nisse26e3abb2017-08-25 04:44:25 -07004183 EXPECT_EQ(1U, config_after.rtp.rtx_associated_payload_types.size());
4184 const int* payload_type_after = FindKeyByValue(
4185 config_after.rtp.rtx_associated_payload_types, GetEngineCodec("VP8").id);
4186 ASSERT_NE(payload_type_after, nullptr);
4187 EXPECT_EQ(kUnusedPayloadType2, *payload_type_after);
brandtr14742122017-01-27 04:53:07 -08004188 EXPECT_EQ(kRtxSsrcs1[0], config_after.rtp.rtx_ssrc);
4189}
4190
eladalonf1841382017-06-12 01:16:46 -07004191TEST_F(WebRtcVideoChannelTest, SetRecvCodecsDifferentPayloadType) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004192 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004193 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004194 parameters.codecs[0].id = 99;
4195 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004196}
4197
eladalonf1841382017-06-12 01:16:46 -07004198TEST_F(WebRtcVideoChannelTest, SetRecvCodecsAcceptDefaultCodecs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004199 cricket::VideoRecvParameters parameters;
4200 parameters.codecs = engine_.codecs();
4201 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgccbed3b2014-07-11 13:02:54 +00004202
4203 FakeVideoReceiveStream* stream = AddRecvStream();
Tommi733b5472016-06-10 17:58:01 +02004204 const webrtc::VideoReceiveStream::Config& config = stream->GetConfig();
Niels Möllercb7e1d22018-09-11 15:56:04 +02004205 EXPECT_EQ(engine_.codecs()[0].name, config.decoders[0].video_format.name);
pbos@webrtc.org776e6f22014-10-29 15:28:39 +00004206 EXPECT_EQ(engine_.codecs()[0].id, config.decoders[0].payload_type);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004207}
4208
eladalonf1841382017-06-12 01:16:46 -07004209TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectUnsupportedCodec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004210 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004211 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkj26752742016-10-24 01:21:16 -07004212 parameters.codecs.push_back(VideoCodec(101, "WTF3"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004213 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004214}
4215
eladalonf1841382017-06-12 01:16:46 -07004216TEST_F(WebRtcVideoChannelTest, SetRecvCodecsAcceptsMultipleVideoCodecs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004217 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004218 parameters.codecs.push_back(GetEngineCodec("VP8"));
4219 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004220 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004221}
4222
eladalonf1841382017-06-12 01:16:46 -07004223TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithoutFecDisablesFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004224 cricket::VideoSendParameters send_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004225 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4226 send_parameters.codecs.push_back(GetEngineCodec("red"));
4227 send_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004228 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004229
4230 FakeVideoReceiveStream* stream = AddRecvStream();
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004231
magjed509e4fe2016-11-18 01:34:11 -08004232 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004233 stream->GetConfig().rtp.ulpfec_payload_type);
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004234
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004235 cricket::VideoRecvParameters recv_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004236 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004237 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00004238 stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004239 ASSERT_TRUE(stream != nullptr);
nisse3b3622f2017-09-26 02:49:21 -07004240 EXPECT_EQ(-1, stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004241 << "SetSendCodec without ULPFEC should disable current ULPFEC.";
4242}
4243
eladalonf1841382017-06-12 01:16:46 -07004244TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetRecvParamsWithoutFecDisablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004245 AddRecvStream(
4246 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08004247 const std::vector<FakeFlexfecReceiveStream*>& streams =
brandtr468da7c2016-11-22 02:16:47 -08004248 fake_call_->GetFlexfecReceiveStreams();
4249
4250 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004251 const FakeFlexfecReceiveStream* stream = streams.front();
4252 EXPECT_EQ(GetEngineCodec("flexfec-03").id, stream->GetConfig().payload_type);
4253 EXPECT_EQ(kFlexfecSsrc, stream->GetConfig().remote_ssrc);
4254 ASSERT_EQ(1U, stream->GetConfig().protected_media_ssrcs.size());
4255 EXPECT_EQ(kSsrcs1[0], stream->GetConfig().protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08004256
4257 cricket::VideoRecvParameters recv_parameters;
4258 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4259 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4260 EXPECT_TRUE(streams.empty())
4261 << "SetSendCodec without FlexFEC should disable current FlexFEC.";
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004262}
4263
eladalonf1841382017-06-12 01:16:46 -07004264TEST_F(WebRtcVideoChannelTest, SetSendParamsWithFecEnablesFec) {
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004265 FakeVideoReceiveStream* stream = AddRecvStream();
magjed509e4fe2016-11-18 01:34:11 -08004266 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004267 stream->GetConfig().rtp.ulpfec_payload_type);
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004268
4269 cricket::VideoRecvParameters recv_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004270 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4271 recv_parameters.codecs.push_back(GetEngineCodec("red"));
4272 recv_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004273 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4274 stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004275 ASSERT_TRUE(stream != nullptr);
magjed509e4fe2016-11-18 01:34:11 -08004276 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004277 stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004278 << "ULPFEC should be enabled on the receive stream.";
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004279
4280 cricket::VideoSendParameters send_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004281 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4282 send_parameters.codecs.push_back(GetEngineCodec("red"));
4283 send_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004284 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
4285 stream = fake_call_->GetVideoReceiveStreams()[0];
magjed509e4fe2016-11-18 01:34:11 -08004286 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004287 stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004288 << "ULPFEC should be enabled on the receive stream.";
4289}
4290
eladalonf1841382017-06-12 01:16:46 -07004291TEST_F(WebRtcVideoChannelFlexfecSendRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004292 SetSendRecvParamsWithFecEnablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004293 AddRecvStream(
4294 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08004295 const std::vector<FakeFlexfecReceiveStream*>& streams =
brandtr468da7c2016-11-22 02:16:47 -08004296 fake_call_->GetFlexfecReceiveStreams();
4297
4298 cricket::VideoRecvParameters recv_parameters;
4299 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4300 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4301 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4302 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004303 const FakeFlexfecReceiveStream* stream_with_recv_params = streams.front();
brandtr468da7c2016-11-22 02:16:47 -08004304 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9c3d4c42017-01-23 06:59:13 -08004305 stream_with_recv_params->GetConfig().payload_type);
4306 EXPECT_EQ(kFlexfecSsrc, stream_with_recv_params->GetConfig().remote_ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004307 EXPECT_EQ(1U,
brandtr9c3d4c42017-01-23 06:59:13 -08004308 stream_with_recv_params->GetConfig().protected_media_ssrcs.size());
brandtr468da7c2016-11-22 02:16:47 -08004309 EXPECT_EQ(kSsrcs1[0],
brandtr9c3d4c42017-01-23 06:59:13 -08004310 stream_with_recv_params->GetConfig().protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08004311
4312 cricket::VideoSendParameters send_parameters;
4313 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4314 send_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4315 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
4316 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004317 const FakeFlexfecReceiveStream* stream_with_send_params = streams.front();
brandtr468da7c2016-11-22 02:16:47 -08004318 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9c3d4c42017-01-23 06:59:13 -08004319 stream_with_send_params->GetConfig().payload_type);
4320 EXPECT_EQ(kFlexfecSsrc, stream_with_send_params->GetConfig().remote_ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004321 EXPECT_EQ(1U,
brandtr9c3d4c42017-01-23 06:59:13 -08004322 stream_with_send_params->GetConfig().protected_media_ssrcs.size());
brandtr468da7c2016-11-22 02:16:47 -08004323 EXPECT_EQ(kSsrcs1[0],
brandtr9c3d4c42017-01-23 06:59:13 -08004324 stream_with_send_params->GetConfig().protected_media_ssrcs[0]);
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004325}
4326
eladalonf1841382017-06-12 01:16:46 -07004327TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectDuplicateFecPayloads) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004328 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004329 parameters.codecs.push_back(GetEngineCodec("VP8"));
4330 parameters.codecs.push_back(GetEngineCodec("red"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004331 parameters.codecs[1].id = parameters.codecs[0].id;
4332 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004333}
4334
eladalonf1841382017-06-12 01:16:46 -07004335TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004336 SetRecvCodecsRejectDuplicateFecPayloads) {
brandtr468da7c2016-11-22 02:16:47 -08004337 cricket::VideoRecvParameters parameters;
4338 parameters.codecs.push_back(GetEngineCodec("VP8"));
4339 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4340 parameters.codecs[1].id = parameters.codecs[0].id;
4341 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
4342}
4343
eladalonf1841382017-06-12 01:16:46 -07004344TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectDuplicateCodecPayloads) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004345 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004346 parameters.codecs.push_back(GetEngineCodec("VP8"));
4347 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004348 parameters.codecs[1].id = parameters.codecs[0].id;
4349 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004350}
4351
eladalonf1841382017-06-12 01:16:46 -07004352TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004353 SetRecvCodecsAcceptSameCodecOnMultiplePayloadTypes) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004354 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004355 parameters.codecs.push_back(GetEngineCodec("VP8"));
4356 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004357 parameters.codecs[1].id += 1;
4358 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004359}
4360
deadbeef67cf2c12016-04-13 10:07:16 -07004361// Test that setting the same codecs but with a different order
deadbeef874ca3a2015-08-20 17:19:20 -07004362// doesn't result in the stream being recreated.
eladalonf1841382017-06-12 01:16:46 -07004363TEST_F(WebRtcVideoChannelTest,
deadbeef67cf2c12016-04-13 10:07:16 -07004364 SetRecvCodecsDifferentOrderDoesntRecreateStream) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004365 cricket::VideoRecvParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08004366 parameters1.codecs.push_back(GetEngineCodec("VP8"));
4367 parameters1.codecs.push_back(GetEngineCodec("red"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004368 EXPECT_TRUE(channel_->SetRecvParameters(parameters1));
deadbeef874ca3a2015-08-20 17:19:20 -07004369
4370 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
4371 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
4372
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004373 cricket::VideoRecvParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08004374 parameters2.codecs.push_back(GetEngineCodec("red"));
4375 parameters2.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004376 EXPECT_TRUE(channel_->SetRecvParameters(parameters2));
deadbeef874ca3a2015-08-20 17:19:20 -07004377 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
4378}
4379
eladalonf1841382017-06-12 01:16:46 -07004380TEST_F(WebRtcVideoChannelTest, SendStreamNotSendingByDefault) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004381 EXPECT_FALSE(AddSendStream()->IsSending());
4382}
4383
eladalonf1841382017-06-12 01:16:46 -07004384TEST_F(WebRtcVideoChannelTest, ReceiveStreamReceivingByDefault) {
pbos@webrtc.org85f42942014-07-22 09:14:58 +00004385 EXPECT_TRUE(AddRecvStream()->IsReceiving());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004386}
4387
eladalonf1841382017-06-12 01:16:46 -07004388TEST_F(WebRtcVideoChannelTest, SetSend) {
pbos@webrtc.org5301b0f2014-07-17 08:51:46 +00004389 FakeVideoSendStream* stream = AddSendStream();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004390 EXPECT_FALSE(stream->IsSending());
4391
4392 // false->true
4393 EXPECT_TRUE(channel_->SetSend(true));
4394 EXPECT_TRUE(stream->IsSending());
4395 // true->true
4396 EXPECT_TRUE(channel_->SetSend(true));
4397 EXPECT_TRUE(stream->IsSending());
4398 // true->false
4399 EXPECT_TRUE(channel_->SetSend(false));
4400 EXPECT_FALSE(stream->IsSending());
4401 // false->false
4402 EXPECT_TRUE(channel_->SetSend(false));
4403 EXPECT_FALSE(stream->IsSending());
4404
4405 EXPECT_TRUE(channel_->SetSend(true));
4406 FakeVideoSendStream* new_stream = AddSendStream();
4407 EXPECT_TRUE(new_stream->IsSending())
4408 << "Send stream created after SetSend(true) not sending initially.";
4409}
4410
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004411// This test verifies DSCP settings are properly applied on video media channel.
eladalonf1841382017-06-12 01:16:46 -07004412TEST_F(WebRtcVideoChannelTest, TestSetDscpOptions) {
kwiberg686a8ef2016-02-26 03:00:35 -08004413 std::unique_ptr<cricket::FakeNetworkInterface> network_interface(
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004414 new cricket::FakeNetworkInterface);
nisse51542be2016-02-12 02:27:06 -08004415 MediaConfig config;
Tim Haloun6ca98362018-09-17 17:06:08 -07004416 std::unique_ptr<cricket::WebRtcVideoChannel> channel;
Tim Haloun648d28a2018-10-18 16:52:22 -07004417 webrtc::RtpParameters parameters;
nisse51542be2016-02-12 02:27:06 -08004418
Sebastian Jansson84848f22018-11-16 10:40:36 +01004419 channel.reset(
4420 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
4421 call_.get(), config, VideoOptions(), webrtc::CryptoOptions())));
Anton Sukhanov98a462c2018-10-17 13:15:42 -07004422 channel->SetInterface(network_interface.get(), /*media_transport=*/nullptr);
nisse51542be2016-02-12 02:27:06 -08004423 // Default value when DSCP is disabled should be DSCP_DEFAULT.
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004424 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
nisse51542be2016-02-12 02:27:06 -08004425
Tim Haloun648d28a2018-10-18 16:52:22 -07004426 // Default value when DSCP is enabled is also DSCP_DEFAULT, until it is set
4427 // through rtp parameters.
nisse51542be2016-02-12 02:27:06 -08004428 config.enable_dscp = true;
Sebastian Jansson84848f22018-11-16 10:40:36 +01004429 channel.reset(
4430 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
4431 call_.get(), config, VideoOptions(), webrtc::CryptoOptions())));
Anton Sukhanov98a462c2018-10-17 13:15:42 -07004432 channel->SetInterface(network_interface.get(), /*media_transport=*/nullptr);
Tim Haloun648d28a2018-10-18 16:52:22 -07004433 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
4434
4435 // Create a send stream to configure
4436 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
4437 parameters = channel->GetRtpSendParameters(kSsrc);
4438 ASSERT_FALSE(parameters.encodings.empty());
4439
4440 // Various priorities map to various dscp values.
4441 parameters.encodings[0].network_priority = 4.0;
4442 ASSERT_TRUE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
nisse51542be2016-02-12 02:27:06 -08004443 EXPECT_EQ(rtc::DSCP_AF41, network_interface->dscp());
Tim Haloun648d28a2018-10-18 16:52:22 -07004444 parameters.encodings[0].network_priority = 0.5;
4445 ASSERT_TRUE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
4446 EXPECT_EQ(rtc::DSCP_CS1, network_interface->dscp());
4447
4448 // A bad priority does not change the dscp value.
4449 parameters.encodings[0].network_priority = 0.0;
4450 ASSERT_FALSE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
4451 EXPECT_EQ(rtc::DSCP_CS1, network_interface->dscp());
nisse51542be2016-02-12 02:27:06 -08004452
Tim Haloun6ca98362018-09-17 17:06:08 -07004453 // Packets should also self-identify their dscp in PacketOptions.
4454 const uint8_t kData[10] = {0};
4455 EXPECT_TRUE(static_cast<webrtc::Transport*>(channel.get())
4456 ->SendRtcp(kData, sizeof(kData)));
Tim Haloun648d28a2018-10-18 16:52:22 -07004457 EXPECT_EQ(rtc::DSCP_CS1, network_interface->options().dscp);
Tim Haloun6ca98362018-09-17 17:06:08 -07004458
nisse51542be2016-02-12 02:27:06 -08004459 // Verify that setting the option to false resets the
4460 // DiffServCodePoint.
4461 config.enable_dscp = false;
Sebastian Jansson84848f22018-11-16 10:40:36 +01004462 channel.reset(
4463 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
4464 call_.get(), config, VideoOptions(), webrtc::CryptoOptions())));
Anton Sukhanov98a462c2018-10-17 13:15:42 -07004465 channel->SetInterface(network_interface.get(), /*media_transport=*/nullptr);
nisse51542be2016-02-12 02:27:06 -08004466 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004467}
4468
deadbeef13871492015-12-09 12:37:51 -08004469// This test verifies that the RTCP reduced size mode is properly applied to
4470// send video streams.
eladalonf1841382017-06-12 01:16:46 -07004471TEST_F(WebRtcVideoChannelTest, TestSetSendRtcpReducedSize) {
deadbeef13871492015-12-09 12:37:51 -08004472 // Create stream, expecting that default mode is "compound".
4473 FakeVideoSendStream* stream1 = AddSendStream();
4474 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream1->GetConfig().rtp.rtcp_mode);
Florent Castellidacec712018-05-24 16:24:21 +02004475 webrtc::RtpParameters rtp_parameters =
4476 channel_->GetRtpSendParameters(last_ssrc_);
4477 EXPECT_FALSE(rtp_parameters.rtcp.reduced_size);
deadbeef13871492015-12-09 12:37:51 -08004478
4479 // Now enable reduced size mode.
4480 send_parameters_.rtcp.reduced_size = true;
4481 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
4482 stream1 = fake_call_->GetVideoSendStreams()[0];
4483 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream1->GetConfig().rtp.rtcp_mode);
Florent Castellidacec712018-05-24 16:24:21 +02004484 rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
4485 EXPECT_TRUE(rtp_parameters.rtcp.reduced_size);
deadbeef13871492015-12-09 12:37:51 -08004486
4487 // Create a new stream and ensure it picks up the reduced size mode.
4488 FakeVideoSendStream* stream2 = AddSendStream();
4489 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream2->GetConfig().rtp.rtcp_mode);
4490}
4491
4492// This test verifies that the RTCP reduced size mode is properly applied to
4493// receive video streams.
eladalonf1841382017-06-12 01:16:46 -07004494TEST_F(WebRtcVideoChannelTest, TestSetRecvRtcpReducedSize) {
deadbeef13871492015-12-09 12:37:51 -08004495 // Create stream, expecting that default mode is "compound".
4496 FakeVideoReceiveStream* stream1 = AddRecvStream();
4497 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream1->GetConfig().rtp.rtcp_mode);
4498
4499 // Now enable reduced size mode.
Taylor Brandstetter5f0b83b2016-03-18 15:02:07 -07004500 // TODO(deadbeef): Once "recv_parameters" becomes "receiver_parameters",
4501 // the reduced_size flag should come from that.
4502 send_parameters_.rtcp.reduced_size = true;
4503 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
deadbeef13871492015-12-09 12:37:51 -08004504 stream1 = fake_call_->GetVideoReceiveStreams()[0];
4505 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream1->GetConfig().rtp.rtcp_mode);
4506
4507 // Create a new stream and ensure it picks up the reduced size mode.
4508 FakeVideoReceiveStream* stream2 = AddRecvStream();
4509 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream2->GetConfig().rtp.rtcp_mode);
4510}
4511
eladalonf1841382017-06-12 01:16:46 -07004512TEST_F(WebRtcVideoChannelTest, OnReadyToSendSignalsNetworkState) {
skvlad7a43d252016-03-22 15:32:27 -07004513 EXPECT_EQ(webrtc::kNetworkUp,
4514 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4515 EXPECT_EQ(webrtc::kNetworkUp,
4516 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.org26c0c412014-09-03 16:17:12 +00004517
4518 channel_->OnReadyToSend(false);
skvlad7a43d252016-03-22 15:32:27 -07004519 EXPECT_EQ(webrtc::kNetworkDown,
4520 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4521 EXPECT_EQ(webrtc::kNetworkUp,
4522 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.org26c0c412014-09-03 16:17:12 +00004523
4524 channel_->OnReadyToSend(true);
skvlad7a43d252016-03-22 15:32:27 -07004525 EXPECT_EQ(webrtc::kNetworkUp,
4526 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4527 EXPECT_EQ(webrtc::kNetworkUp,
4528 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004529}
4530
eladalonf1841382017-06-12 01:16:46 -07004531TEST_F(WebRtcVideoChannelTest, GetStatsReportsSentCodecName) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004532 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004533 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004534 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström74d9ed72015-03-26 16:28:31 +01004535
4536 AddSendStream();
4537
4538 cricket::VideoMediaInfo info;
4539 ASSERT_TRUE(channel_->GetStats(&info));
magjed509e4fe2016-11-18 01:34:11 -08004540 EXPECT_EQ("VP8", info.senders[0].codec_name);
Peter Boström74d9ed72015-03-26 16:28:31 +01004541}
4542
eladalonf1841382017-06-12 01:16:46 -07004543TEST_F(WebRtcVideoChannelTest, GetStatsReportsEncoderImplementationName) {
Peter Boströmb7d9a972015-12-18 16:01:11 +01004544 FakeVideoSendStream* stream = AddSendStream();
4545 webrtc::VideoSendStream::Stats stats;
4546 stats.encoder_implementation_name = "encoder_implementation_name";
4547 stream->SetStats(stats);
4548
4549 cricket::VideoMediaInfo info;
4550 ASSERT_TRUE(channel_->GetStats(&info));
4551 EXPECT_EQ(stats.encoder_implementation_name,
4552 info.senders[0].encoder_implementation_name);
4553}
4554
eladalonf1841382017-06-12 01:16:46 -07004555TEST_F(WebRtcVideoChannelTest, GetStatsReportsCpuOveruseMetrics) {
pbos@webrtc.org3e6e2712015-02-26 12:19:31 +00004556 FakeVideoSendStream* stream = AddSendStream();
4557 webrtc::VideoSendStream::Stats stats;
4558 stats.avg_encode_time_ms = 13;
4559 stats.encode_usage_percent = 42;
4560 stream->SetStats(stats);
4561
4562 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004563 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org3e6e2712015-02-26 12:19:31 +00004564 EXPECT_EQ(stats.avg_encode_time_ms, info.senders[0].avg_encode_ms);
4565 EXPECT_EQ(stats.encode_usage_percent, info.senders[0].encode_usage_percent);
4566}
4567
eladalonf1841382017-06-12 01:16:46 -07004568TEST_F(WebRtcVideoChannelTest, GetStatsReportsFramesEncoded) {
sakal43536c32016-10-24 01:46:43 -07004569 FakeVideoSendStream* stream = AddSendStream();
4570 webrtc::VideoSendStream::Stats stats;
4571 stats.frames_encoded = 13;
4572 stream->SetStats(stats);
4573
4574 cricket::VideoMediaInfo info;
4575 ASSERT_TRUE(channel_->GetStats(&info));
4576 EXPECT_EQ(stats.frames_encoded, info.senders[0].frames_encoded);
4577}
4578
eladalonf1841382017-06-12 01:16:46 -07004579TEST_F(WebRtcVideoChannelTest, GetStatsReportsQpSum) {
sakal87da4042016-10-31 06:53:47 -07004580 FakeVideoSendStream* stream = AddSendStream();
4581 webrtc::VideoSendStream::Stats stats;
Oskar Sundbom78807582017-11-16 11:09:55 +01004582 stats.qp_sum = 13;
sakal87da4042016-10-31 06:53:47 -07004583 stream->SetStats(stats);
4584
4585 cricket::VideoMediaInfo info;
4586 ASSERT_TRUE(channel_->GetStats(&info));
4587 EXPECT_EQ(stats.qp_sum, info.senders[0].qp_sum);
4588}
4589
eladalonf1841382017-06-12 01:16:46 -07004590TEST_F(WebRtcVideoChannelTest, GetStatsReportsUpperResolution) {
pbos@webrtc.org273a4142014-12-01 15:23:21 +00004591 FakeVideoSendStream* stream = AddSendStream();
4592 webrtc::VideoSendStream::Stats stats;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004593 stats.substreams[17].width = 123;
4594 stats.substreams[17].height = 40;
4595 stats.substreams[42].width = 80;
4596 stats.substreams[42].height = 31;
4597 stats.substreams[11].width = 20;
4598 stats.substreams[11].height = 90;
pbos@webrtc.org273a4142014-12-01 15:23:21 +00004599 stream->SetStats(stats);
4600
4601 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004602 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org273a4142014-12-01 15:23:21 +00004603 ASSERT_EQ(1u, info.senders.size());
4604 EXPECT_EQ(123, info.senders[0].send_frame_width);
4605 EXPECT_EQ(90, info.senders[0].send_frame_height);
4606}
4607
eladalonf1841382017-06-12 01:16:46 -07004608TEST_F(WebRtcVideoChannelTest, GetStatsReportsCpuAdaptationStats) {
perkj803d97f2016-11-01 11:45:46 -07004609 FakeVideoSendStream* stream = AddSendStream();
4610 webrtc::VideoSendStream::Stats stats;
4611 stats.number_of_cpu_adapt_changes = 2;
4612 stats.cpu_limited_resolution = true;
4613 stream->SetStats(stats);
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004614
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004615 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004616 EXPECT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004617 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07004618 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_CPU, info.senders[0].adapt_reason);
perkj803d97f2016-11-01 11:45:46 -07004619 EXPECT_EQ(stats.number_of_cpu_adapt_changes, info.senders[0].adapt_changes);
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004620}
4621
eladalonf1841382017-06-12 01:16:46 -07004622TEST_F(WebRtcVideoChannelTest, GetStatsReportsAdaptationAndBandwidthStats) {
perkj803d97f2016-11-01 11:45:46 -07004623 FakeVideoSendStream* stream = AddSendStream();
asapersson17821db2015-12-14 02:08:12 -08004624 webrtc::VideoSendStream::Stats stats;
perkj803d97f2016-11-01 11:45:46 -07004625 stats.number_of_cpu_adapt_changes = 2;
4626 stats.cpu_limited_resolution = true;
asapersson17821db2015-12-14 02:08:12 -08004627 stats.bw_limited_resolution = true;
perkj803d97f2016-11-01 11:45:46 -07004628 stream->SetStats(stats);
4629
4630 cricket::VideoMediaInfo info;
asapersson17821db2015-12-14 02:08:12 -08004631 EXPECT_TRUE(channel_->GetStats(&info));
4632 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07004633 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_CPU |
4634 WebRtcVideoChannel::ADAPTREASON_BANDWIDTH,
asapersson17821db2015-12-14 02:08:12 -08004635 info.senders[0].adapt_reason);
perkj803d97f2016-11-01 11:45:46 -07004636 EXPECT_EQ(stats.number_of_cpu_adapt_changes, info.senders[0].adapt_changes);
asapersson17821db2015-12-14 02:08:12 -08004637}
4638
eladalonf1841382017-06-12 01:16:46 -07004639TEST_F(WebRtcVideoChannelTest,
asapersson17821db2015-12-14 02:08:12 -08004640 GetStatsTranslatesBandwidthLimitedResolutionCorrectly) {
4641 FakeVideoSendStream* stream = AddSendStream();
4642 webrtc::VideoSendStream::Stats stats;
4643 stats.bw_limited_resolution = true;
4644 stream->SetStats(stats);
4645
4646 cricket::VideoMediaInfo info;
4647 EXPECT_TRUE(channel_->GetStats(&info));
4648 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07004649 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_BANDWIDTH,
asapersson17821db2015-12-14 02:08:12 -08004650 info.senders[0].adapt_reason);
4651}
4652
Yves Gerey665174f2018-06-19 15:03:05 +02004653TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesSendRtcpPacketTypesCorrectly) {
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004654 FakeVideoSendStream* stream = AddSendStream();
4655 webrtc::VideoSendStream::Stats stats;
4656 stats.substreams[17].rtcp_packet_type_counts.fir_packets = 2;
4657 stats.substreams[17].rtcp_packet_type_counts.nack_packets = 3;
4658 stats.substreams[17].rtcp_packet_type_counts.pli_packets = 4;
4659
4660 stats.substreams[42].rtcp_packet_type_counts.fir_packets = 5;
4661 stats.substreams[42].rtcp_packet_type_counts.nack_packets = 7;
4662 stats.substreams[42].rtcp_packet_type_counts.pli_packets = 9;
4663
4664 stream->SetStats(stats);
4665
4666 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004667 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004668 EXPECT_EQ(7, info.senders[0].firs_rcvd);
4669 EXPECT_EQ(10, info.senders[0].nacks_rcvd);
4670 EXPECT_EQ(13, info.senders[0].plis_rcvd);
4671}
4672
eladalonf1841382017-06-12 01:16:46 -07004673TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004674 GetStatsTranslatesReceiveRtcpPacketTypesCorrectly) {
4675 FakeVideoReceiveStream* stream = AddRecvStream();
4676 webrtc::VideoReceiveStream::Stats stats;
4677 stats.rtcp_packet_type_counts.fir_packets = 2;
4678 stats.rtcp_packet_type_counts.nack_packets = 3;
4679 stats.rtcp_packet_type_counts.pli_packets = 4;
4680 stream->SetStats(stats);
4681
4682 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004683 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004684 EXPECT_EQ(stats.rtcp_packet_type_counts.fir_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004685 rtc::checked_cast<unsigned int>(info.receivers[0].firs_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004686 EXPECT_EQ(stats.rtcp_packet_type_counts.nack_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004687 rtc::checked_cast<unsigned int>(info.receivers[0].nacks_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004688 EXPECT_EQ(stats.rtcp_packet_type_counts.pli_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004689 rtc::checked_cast<unsigned int>(info.receivers[0].plis_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004690}
4691
eladalonf1841382017-06-12 01:16:46 -07004692TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesDecodeStatsCorrectly) {
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004693 FakeVideoReceiveStream* stream = AddRecvStream();
4694 webrtc::VideoReceiveStream::Stats stats;
Peter Boströmb7d9a972015-12-18 16:01:11 +01004695 stats.decoder_implementation_name = "decoder_implementation_name";
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004696 stats.decode_ms = 2;
4697 stats.max_decode_ms = 3;
4698 stats.current_delay_ms = 4;
4699 stats.target_delay_ms = 5;
4700 stats.jitter_buffer_ms = 6;
4701 stats.min_playout_delay_ms = 7;
4702 stats.render_delay_ms = 8;
asapersson26dd92b2016-08-30 00:45:45 -07004703 stats.width = 9;
4704 stats.height = 10;
hbos42f6d2f2017-01-20 03:56:50 -08004705 stats.frame_counts.key_frames = 11;
4706 stats.frame_counts.delta_frames = 12;
hbos50cfe1f2017-01-23 07:21:55 -08004707 stats.frames_rendered = 13;
4708 stats.frames_decoded = 14;
Oskar Sundbom78807582017-11-16 11:09:55 +01004709 stats.qp_sum = 15;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004710 stream->SetStats(stats);
4711
4712 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004713 ASSERT_TRUE(channel_->GetStats(&info));
Peter Boströmb7d9a972015-12-18 16:01:11 +01004714 EXPECT_EQ(stats.decoder_implementation_name,
4715 info.receivers[0].decoder_implementation_name);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004716 EXPECT_EQ(stats.decode_ms, info.receivers[0].decode_ms);
4717 EXPECT_EQ(stats.max_decode_ms, info.receivers[0].max_decode_ms);
4718 EXPECT_EQ(stats.current_delay_ms, info.receivers[0].current_delay_ms);
4719 EXPECT_EQ(stats.target_delay_ms, info.receivers[0].target_delay_ms);
4720 EXPECT_EQ(stats.jitter_buffer_ms, info.receivers[0].jitter_buffer_ms);
4721 EXPECT_EQ(stats.min_playout_delay_ms, info.receivers[0].min_playout_delay_ms);
4722 EXPECT_EQ(stats.render_delay_ms, info.receivers[0].render_delay_ms);
asapersson26dd92b2016-08-30 00:45:45 -07004723 EXPECT_EQ(stats.width, info.receivers[0].frame_width);
4724 EXPECT_EQ(stats.height, info.receivers[0].frame_height);
Mirko Bonadeif859e552018-05-30 15:31:29 +02004725 EXPECT_EQ(rtc::checked_cast<unsigned int>(stats.frame_counts.key_frames +
4726 stats.frame_counts.delta_frames),
hbos42f6d2f2017-01-20 03:56:50 -08004727 info.receivers[0].frames_received);
hbos50cfe1f2017-01-23 07:21:55 -08004728 EXPECT_EQ(stats.frames_rendered, info.receivers[0].frames_rendered);
sakale5ba44e2016-10-26 07:09:24 -07004729 EXPECT_EQ(stats.frames_decoded, info.receivers[0].frames_decoded);
sakalcc452e12017-02-09 04:53:45 -08004730 EXPECT_EQ(stats.qp_sum, info.receivers[0].qp_sum);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004731}
4732
eladalonf1841382017-06-12 01:16:46 -07004733TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesReceivePacketStatsCorrectly) {
Peter Boström393347f2015-04-22 14:52:45 +02004734 FakeVideoReceiveStream* stream = AddRecvStream();
4735 webrtc::VideoReceiveStream::Stats stats;
4736 stats.rtp_stats.transmitted.payload_bytes = 2;
4737 stats.rtp_stats.transmitted.header_bytes = 3;
4738 stats.rtp_stats.transmitted.padding_bytes = 4;
4739 stats.rtp_stats.transmitted.packets = 5;
srte186d9c32017-08-04 05:03:53 -07004740 stats.rtcp_stats.packets_lost = 6;
Peter Boström393347f2015-04-22 14:52:45 +02004741 stats.rtcp_stats.fraction_lost = 7;
4742 stream->SetStats(stats);
4743
4744 cricket::VideoMediaInfo info;
4745 ASSERT_TRUE(channel_->GetStats(&info));
4746 EXPECT_EQ(stats.rtp_stats.transmitted.payload_bytes +
4747 stats.rtp_stats.transmitted.header_bytes +
4748 stats.rtp_stats.transmitted.padding_bytes,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004749 rtc::checked_cast<size_t>(info.receivers[0].bytes_rcvd));
Peter Boström393347f2015-04-22 14:52:45 +02004750 EXPECT_EQ(stats.rtp_stats.transmitted.packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004751 rtc::checked_cast<unsigned int>(info.receivers[0].packets_rcvd));
srte186d9c32017-08-04 05:03:53 -07004752 EXPECT_EQ(stats.rtcp_stats.packets_lost, info.receivers[0].packets_lost);
Mirko Bonadeif859e552018-05-30 15:31:29 +02004753 EXPECT_EQ(rtc::checked_cast<float>(stats.rtcp_stats.fraction_lost) / (1 << 8),
Peter Boström393347f2015-04-22 14:52:45 +02004754 info.receivers[0].fraction_lost);
4755}
4756
eladalonf1841382017-06-12 01:16:46 -07004757TEST_F(WebRtcVideoChannelTest, TranslatesCallStatsCorrectly) {
pbos@webrtc.org2b19f062014-12-11 13:26:09 +00004758 AddSendStream();
4759 AddSendStream();
4760 webrtc::Call::Stats stats;
4761 stats.rtt_ms = 123;
4762 fake_call_->SetStats(stats);
4763
4764 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004765 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org2b19f062014-12-11 13:26:09 +00004766 ASSERT_EQ(2u, info.senders.size());
4767 EXPECT_EQ(stats.rtt_ms, info.senders[0].rtt_ms);
4768 EXPECT_EQ(stats.rtt_ms, info.senders[1].rtt_ms);
4769}
4770
eladalonf1841382017-06-12 01:16:46 -07004771TEST_F(WebRtcVideoChannelTest, TranslatesSenderBitrateStatsCorrectly) {
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004772 FakeVideoSendStream* stream = AddSendStream();
4773 webrtc::VideoSendStream::Stats stats;
pbos@webrtc.org891d4832015-02-26 13:15:22 +00004774 stats.target_media_bitrate_bps = 156;
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004775 stats.media_bitrate_bps = 123;
4776 stats.substreams[17].total_bitrate_bps = 1;
4777 stats.substreams[17].retransmit_bitrate_bps = 2;
4778 stats.substreams[42].total_bitrate_bps = 3;
4779 stats.substreams[42].retransmit_bitrate_bps = 4;
4780 stream->SetStats(stats);
4781
4782 FakeVideoSendStream* stream2 = AddSendStream();
4783 webrtc::VideoSendStream::Stats stats2;
pbos@webrtc.org891d4832015-02-26 13:15:22 +00004784 stats2.target_media_bitrate_bps = 200;
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004785 stats2.media_bitrate_bps = 321;
4786 stats2.substreams[13].total_bitrate_bps = 5;
4787 stats2.substreams[13].retransmit_bitrate_bps = 6;
4788 stats2.substreams[21].total_bitrate_bps = 7;
4789 stats2.substreams[21].retransmit_bitrate_bps = 8;
4790 stream2->SetStats(stats2);
4791
4792 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004793 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004794 ASSERT_EQ(2u, info.senders.size());
stefanf79ade12017-06-02 06:44:03 -07004795 BandwidthEstimationInfo bwe_info;
4796 channel_->FillBitrateInfo(&bwe_info);
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004797 // Assuming stream and stream2 corresponds to senders[0] and [1] respectively
4798 // is OK as std::maps are sorted and AddSendStream() gives increasing SSRCs.
4799 EXPECT_EQ(stats.media_bitrate_bps, info.senders[0].nominal_bitrate);
4800 EXPECT_EQ(stats2.media_bitrate_bps, info.senders[1].nominal_bitrate);
pbos@webrtc.org891d4832015-02-26 13:15:22 +00004801 EXPECT_EQ(stats.target_media_bitrate_bps + stats2.target_media_bitrate_bps,
stefanf79ade12017-06-02 06:44:03 -07004802 bwe_info.target_enc_bitrate);
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004803 EXPECT_EQ(stats.media_bitrate_bps + stats2.media_bitrate_bps,
stefanf79ade12017-06-02 06:44:03 -07004804 bwe_info.actual_enc_bitrate);
4805 EXPECT_EQ(1 + 3 + 5 + 7, bwe_info.transmit_bitrate)
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004806 << "Bandwidth stats should take all streams into account.";
stefanf79ade12017-06-02 06:44:03 -07004807 EXPECT_EQ(2 + 4 + 6 + 8, bwe_info.retransmit_bitrate)
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004808 << "Bandwidth stats should take all streams into account.";
4809}
4810
eladalonf1841382017-06-12 01:16:46 -07004811TEST_F(WebRtcVideoChannelTest, DefaultReceiveStreamReconfiguresToUseRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004812 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004813
Peter Boström0c4e06b2015-10-07 12:23:21 +02004814 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
4815 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004816
4817 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
4818 const size_t kDataLength = 12;
4819 uint8_t data[kDataLength];
4820 memset(data, 0, sizeof(data));
4821 rtc::SetBE32(&data[8], ssrcs[0]);
jbaucheec21bd2016-03-20 06:15:43 -07004822 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Niels Möllere6933812018-11-05 13:01:41 +01004823 channel_->OnPacketReceived(&packet, /* packet_time_us */ -1);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004824
4825 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
4826 << "No default receive stream created.";
4827 FakeVideoReceiveStream* recv_stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr14742122017-01-27 04:53:07 -08004828 EXPECT_EQ(0u, recv_stream->GetConfig().rtp.rtx_ssrc)
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004829 << "Default receive stream should not have configured RTX";
4830
4831 EXPECT_TRUE(channel_->AddRecvStream(
4832 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs)));
4833 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
brandtr14742122017-01-27 04:53:07 -08004834 << "AddRecvStream should have reconfigured, not added a new receiver.";
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004835 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
nisse26e3abb2017-08-25 04:44:25 -07004836 EXPECT_FALSE(
4837 recv_stream->GetConfig().rtp.rtx_associated_payload_types.empty());
nisseca5706d2017-09-11 02:32:16 -07004838 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
Peter Boströmd8b01092016-05-12 16:44:36 +02004839 << "RTX should be mapped for all decoders/payload types.";
nisseca5706d2017-09-11 02:32:16 -07004840 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02004841 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07004842 << "RTX should be mapped also for the RED payload type";
brandtr14742122017-01-27 04:53:07 -08004843 EXPECT_EQ(rtx_ssrcs[0], recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004844}
4845
eladalonf1841382017-06-12 01:16:46 -07004846TEST_F(WebRtcVideoChannelTest, RejectsAddingStreamsWithMissingSsrcsForRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004847 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd4362cd2015-03-25 14:17:23 +01004848
Peter Boström0c4e06b2015-10-07 12:23:21 +02004849 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
4850 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
Peter Boströmd4362cd2015-03-25 14:17:23 +01004851
4852 StreamParams sp =
4853 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs);
4854 sp.ssrcs = ssrcs; // Without RTXs, this is the important part.
4855
4856 EXPECT_FALSE(channel_->AddSendStream(sp));
4857 EXPECT_FALSE(channel_->AddRecvStream(sp));
4858}
4859
eladalonf1841382017-06-12 01:16:46 -07004860TEST_F(WebRtcVideoChannelTest, RejectsAddingStreamsWithOverlappingRtxSsrcs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004861 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd6f4c252015-03-26 16:23:04 +01004862
Peter Boström0c4e06b2015-10-07 12:23:21 +02004863 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
4864 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
Peter Boströmd6f4c252015-03-26 16:23:04 +01004865
4866 StreamParams sp =
4867 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs);
4868
4869 EXPECT_TRUE(channel_->AddSendStream(sp));
4870 EXPECT_TRUE(channel_->AddRecvStream(sp));
4871
4872 // The RTX SSRC is already used in previous streams, using it should fail.
4873 sp = cricket::StreamParams::CreateLegacy(rtx_ssrcs[0]);
4874 EXPECT_FALSE(channel_->AddSendStream(sp));
4875 EXPECT_FALSE(channel_->AddRecvStream(sp));
4876
4877 // After removing the original stream this should be fine to add (makes sure
4878 // that RTX ssrcs are not forever taken).
4879 EXPECT_TRUE(channel_->RemoveSendStream(ssrcs[0]));
4880 EXPECT_TRUE(channel_->RemoveRecvStream(ssrcs[0]));
4881 EXPECT_TRUE(channel_->AddSendStream(sp));
4882 EXPECT_TRUE(channel_->AddRecvStream(sp));
4883}
4884
eladalonf1841382017-06-12 01:16:46 -07004885TEST_F(WebRtcVideoChannelTest,
Peter Boströmd6f4c252015-03-26 16:23:04 +01004886 RejectsAddingStreamsWithOverlappingSimulcastSsrcs) {
Peter Boström0c4e06b2015-10-07 12:23:21 +02004887 static const uint32_t kFirstStreamSsrcs[] = {1, 2, 3};
4888 static const uint32_t kOverlappingStreamSsrcs[] = {4, 3, 5};
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004889 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd6f4c252015-03-26 16:23:04 +01004890
Peter Boströmd6f4c252015-03-26 16:23:04 +01004891 StreamParams sp =
4892 cricket::CreateSimStreamParams("cname", MAKE_VECTOR(kFirstStreamSsrcs));
4893
4894 EXPECT_TRUE(channel_->AddSendStream(sp));
4895 EXPECT_TRUE(channel_->AddRecvStream(sp));
4896
4897 // One of the SSRCs is already used in previous streams, using it should fail.
4898 sp = cricket::CreateSimStreamParams("cname",
4899 MAKE_VECTOR(kOverlappingStreamSsrcs));
4900 EXPECT_FALSE(channel_->AddSendStream(sp));
4901 EXPECT_FALSE(channel_->AddRecvStream(sp));
4902
4903 // After removing the original stream this should be fine to add (makes sure
4904 // that RTX ssrcs are not forever taken).
Peter Boström3548dd22015-05-22 18:48:36 +02004905 EXPECT_TRUE(channel_->RemoveSendStream(kFirstStreamSsrcs[0]));
4906 EXPECT_TRUE(channel_->RemoveRecvStream(kFirstStreamSsrcs[0]));
Peter Boströmd6f4c252015-03-26 16:23:04 +01004907 EXPECT_TRUE(channel_->AddSendStream(sp));
4908 EXPECT_TRUE(channel_->AddRecvStream(sp));
4909}
4910
eladalonf1841382017-06-12 01:16:46 -07004911TEST_F(WebRtcVideoChannelTest, ReportsSsrcGroupsInStats) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004912 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boström259bd202015-05-28 13:39:50 +02004913
4914 static const uint32_t kSenderSsrcs[] = {4, 7, 10};
4915 static const uint32_t kSenderRtxSsrcs[] = {5, 8, 11};
4916
4917 StreamParams sender_sp = cricket::CreateSimWithRtxStreamParams(
4918 "cname", MAKE_VECTOR(kSenderSsrcs), MAKE_VECTOR(kSenderRtxSsrcs));
4919
4920 EXPECT_TRUE(channel_->AddSendStream(sender_sp));
4921
4922 static const uint32_t kReceiverSsrcs[] = {3};
4923 static const uint32_t kReceiverRtxSsrcs[] = {2};
4924
4925 StreamParams receiver_sp = cricket::CreateSimWithRtxStreamParams(
4926 "cname", MAKE_VECTOR(kReceiverSsrcs), MAKE_VECTOR(kReceiverRtxSsrcs));
4927 EXPECT_TRUE(channel_->AddRecvStream(receiver_sp));
4928
4929 cricket::VideoMediaInfo info;
4930 ASSERT_TRUE(channel_->GetStats(&info));
4931
4932 ASSERT_EQ(1u, info.senders.size());
4933 ASSERT_EQ(1u, info.receivers.size());
4934
4935 EXPECT_NE(sender_sp.ssrc_groups, receiver_sp.ssrc_groups);
4936 EXPECT_EQ(sender_sp.ssrc_groups, info.senders[0].ssrc_groups);
4937 EXPECT_EQ(receiver_sp.ssrc_groups, info.receivers[0].ssrc_groups);
4938}
4939
eladalonf1841382017-06-12 01:16:46 -07004940TEST_F(WebRtcVideoChannelTest, MapsReceivedPayloadTypeToCodecName) {
pbosf42376c2015-08-28 07:35:32 -07004941 FakeVideoReceiveStream* stream = AddRecvStream();
4942 webrtc::VideoReceiveStream::Stats stats;
4943 cricket::VideoMediaInfo info;
4944
4945 // Report no codec name before receiving.
4946 stream->SetStats(stats);
4947 ASSERT_TRUE(channel_->GetStats(&info));
4948 EXPECT_STREQ("", info.receivers[0].codec_name.c_str());
4949
4950 // Report VP8 if we're receiving it.
magjed509e4fe2016-11-18 01:34:11 -08004951 stats.current_payload_type = GetEngineCodec("VP8").id;
pbosf42376c2015-08-28 07:35:32 -07004952 stream->SetStats(stats);
4953 ASSERT_TRUE(channel_->GetStats(&info));
4954 EXPECT_STREQ(kVp8CodecName, info.receivers[0].codec_name.c_str());
4955
4956 // Report no codec name for unknown playload types.
4957 stats.current_payload_type = 3;
4958 stream->SetStats(stats);
4959 ASSERT_TRUE(channel_->GetStats(&info));
4960 EXPECT_STREQ("", info.receivers[0].codec_name.c_str());
4961}
4962
Seth Hampson5897a6e2018-04-03 11:16:33 -07004963// Tests that when we add a stream without SSRCs, but contains a stream_id
4964// that it is stored and its stream id is later used when the first packet
4965// arrives to properly create a receive stream with a sync label.
4966TEST_F(WebRtcVideoChannelTest, RecvUnsignaledSsrcWithSignaledStreamId) {
4967 const char kSyncLabel[] = "sync_label";
4968 cricket::StreamParams unsignaled_stream;
4969 unsignaled_stream.set_stream_ids({kSyncLabel});
4970 ASSERT_TRUE(channel_->AddRecvStream(unsignaled_stream));
4971 // The stream shouldn't have been created at this point because it doesn't
4972 // have any SSRCs.
Mirko Bonadeif859e552018-05-30 15:31:29 +02004973 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
Seth Hampson5897a6e2018-04-03 11:16:33 -07004974
4975 // Create and deliver packet.
4976 const size_t kDataLength = 12;
4977 uint8_t data[kDataLength];
4978 memset(data, 0, sizeof(data));
4979 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
4980 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Niels Möllere6933812018-11-05 13:01:41 +01004981 channel_->OnPacketReceived(&packet, /* packet_time_us */ -1);
Seth Hampson5897a6e2018-04-03 11:16:33 -07004982
4983 // The stream should now be created with the appropriate sync label.
4984 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
4985 EXPECT_EQ(kSyncLabel,
4986 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group);
4987
4988 // Removing the unsignaled stream should clear the cache. This time when
4989 // a default video receive stream is created it won't have a sync_group.
4990 ASSERT_TRUE(channel_->RemoveRecvStream(0));
4991 ASSERT_TRUE(channel_->RemoveRecvStream(kIncomingUnsignalledSsrc));
4992 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
4993
Niels Möllere6933812018-11-05 13:01:41 +01004994 channel_->OnPacketReceived(&packet, /* packet_time_us */ -1);
Seth Hampson5897a6e2018-04-03 11:16:33 -07004995 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
4996 EXPECT_TRUE(
4997 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group.empty());
4998}
4999
eladalonf1841382017-06-12 01:16:46 -07005000void WebRtcVideoChannelTest::TestReceiveUnsignaledSsrcPacket(
noahricd10a68e2015-07-10 11:27:55 -07005001 uint8_t payload_type,
5002 bool expect_created_receive_stream) {
magjed509e4fe2016-11-18 01:34:11 -08005003 // kRedRtxPayloadType must currently be unused.
5004 EXPECT_FALSE(FindCodecById(engine_.codecs(), kRedRtxPayloadType));
5005
noahricd10a68e2015-07-10 11:27:55 -07005006 // Add a RED RTX codec.
5007 VideoCodec red_rtx_codec =
magjed509e4fe2016-11-18 01:34:11 -08005008 VideoCodec::CreateRtxCodec(kRedRtxPayloadType, GetEngineCodec("red").id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005009 recv_parameters_.codecs.push_back(red_rtx_codec);
5010 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
noahricd10a68e2015-07-10 11:27:55 -07005011
5012 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5013 const size_t kDataLength = 12;
5014 uint8_t data[kDataLength];
5015 memset(data, 0, sizeof(data));
5016
5017 rtc::Set8(data, 1, payload_type);
5018 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
jbaucheec21bd2016-03-20 06:15:43 -07005019 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Niels Möllere6933812018-11-05 13:01:41 +01005020 channel_->OnPacketReceived(&packet, /* packet_time_us */ -1);
noahricd10a68e2015-07-10 11:27:55 -07005021
5022 if (expect_created_receive_stream) {
5023 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
5024 << "Should have created a receive stream for payload type: "
5025 << payload_type;
5026 } else {
5027 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size())
5028 << "Shouldn't have created a receive stream for payload type: "
5029 << payload_type;
5030 }
5031}
5032
Åsa Persson2c7149b2018-10-15 09:36:10 +02005033class WebRtcVideoChannelDiscardUnknownSsrcTest : public WebRtcVideoChannelTest {
5034 public:
5035 WebRtcVideoChannelDiscardUnknownSsrcTest()
5036 : WebRtcVideoChannelTest(
5037 "WebRTC-Video-DiscardPacketsWithUnknownSsrc/Enabled/") {}
5038};
5039
5040TEST_F(WebRtcVideoChannelDiscardUnknownSsrcTest, NoUnsignalledStreamCreated) {
5041 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP8").id,
5042 false /* expect_created_receive_stream */);
5043}
5044
eladalonf1841382017-06-12 01:16:46 -07005045TEST_F(WebRtcVideoChannelTest, Vp8PacketCreatesUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005046 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP8").id,
5047 true /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005048}
5049
eladalonf1841382017-06-12 01:16:46 -07005050TEST_F(WebRtcVideoChannelTest, Vp9PacketCreatesUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005051 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP9").id,
5052 true /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005053}
5054
eladalonf1841382017-06-12 01:16:46 -07005055TEST_F(WebRtcVideoChannelTest, RtxPacketDoesntCreateUnsignalledStream) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02005056 AssignDefaultAptRtxTypes();
magjed509e4fe2016-11-18 01:34:11 -08005057 const cricket::VideoCodec vp8 = GetEngineCodec("VP8");
5058 const int rtx_vp8_payload_type = default_apt_rtx_types_[vp8.id];
5059 TestReceiveUnsignaledSsrcPacket(rtx_vp8_payload_type,
5060 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005061}
5062
eladalonf1841382017-06-12 01:16:46 -07005063TEST_F(WebRtcVideoChannelTest, UlpfecPacketDoesntCreateUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005064 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("ulpfec").id,
5065 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005066}
5067
eladalonf1841382017-06-12 01:16:46 -07005068TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr468da7c2016-11-22 02:16:47 -08005069 FlexfecPacketDoesntCreateUnsignalledStream) {
5070 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("flexfec-03").id,
5071 false /* expect_created_receive_stream */);
5072}
5073
eladalonf1841382017-06-12 01:16:46 -07005074TEST_F(WebRtcVideoChannelTest, RedRtxPacketDoesntCreateUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005075 TestReceiveUnsignaledSsrcPacket(kRedRtxPayloadType,
5076 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005077}
5078
mzanaty8a855d62017-02-17 15:46:43 -08005079// Test that receiving any unsignalled SSRC works even if it changes.
5080// The first unsignalled SSRC received will create a default receive stream.
5081// Any different unsignalled SSRC received will replace the default.
eladalonf1841382017-06-12 01:16:46 -07005082TEST_F(WebRtcVideoChannelTest, ReceiveDifferentUnsignaledSsrc) {
mzanaty8a855d62017-02-17 15:46:43 -08005083 // Allow receiving VP8, VP9, H264 (if enabled).
5084 cricket::VideoRecvParameters parameters;
5085 parameters.codecs.push_back(GetEngineCodec("VP8"));
5086 parameters.codecs.push_back(GetEngineCodec("VP9"));
5087
5088#if defined(WEBRTC_USE_H264)
5089 cricket::VideoCodec H264codec(126, "H264");
5090 parameters.codecs.push_back(H264codec);
5091#endif
5092
5093 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
5094 // No receive streams yet.
5095 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5096 cricket::FakeVideoRenderer renderer;
5097 EXPECT_TRUE(channel_->SetSink(kDefaultRecvSsrc, &renderer));
5098
5099 // Receive VP8 packet on first SSRC.
5100 uint8_t data[kMinRtpPacketLen];
5101 cricket::RtpHeader rtpHeader;
5102 rtpHeader.payload_type = GetEngineCodec("VP8").id;
5103 rtpHeader.seq_num = rtpHeader.timestamp = 0;
Yves Gerey665174f2018-06-19 15:03:05 +02005104 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 1;
mzanaty8a855d62017-02-17 15:46:43 -08005105 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5106 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
Niels Möllere6933812018-11-05 13:01:41 +01005107 channel_->OnPacketReceived(&packet, /* packet_time_us */ -1);
mzanaty8a855d62017-02-17 15:46:43 -08005108 // VP8 packet should create default receive stream.
5109 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
Yves Gerey665174f2018-06-19 15:03:05 +02005110 FakeVideoReceiveStream* recv_stream = fake_call_->GetVideoReceiveStreams()[0];
mzanaty8a855d62017-02-17 15:46:43 -08005111 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5112 // Verify that the receive stream sinks to a renderer.
Artem Titov1ebfb6a2019-01-03 23:49:37 +01005113 webrtc::VideoFrame video_frame =
5114 webrtc::VideoFrame::Builder()
5115 .set_video_frame_buffer(CreateBlackFrameBuffer(4, 4))
5116 .set_timestamp_rtp(100)
5117 .set_timestamp_us(0)
5118 .set_rotation(webrtc::kVideoRotation_0)
5119 .build();
mzanaty8a855d62017-02-17 15:46:43 -08005120 recv_stream->InjectFrame(video_frame);
5121 EXPECT_EQ(1, renderer.num_rendered_frames());
5122
5123 // Receive VP9 packet on second SSRC.
5124 rtpHeader.payload_type = GetEngineCodec("VP9").id;
Yves Gerey665174f2018-06-19 15:03:05 +02005125 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 2;
mzanaty8a855d62017-02-17 15:46:43 -08005126 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5127 rtc::CopyOnWriteBuffer packet2(data, sizeof(data));
Niels Möllere6933812018-11-05 13:01:41 +01005128 channel_->OnPacketReceived(&packet2, /* packet_time_us */ -1);
mzanaty8a855d62017-02-17 15:46:43 -08005129 // VP9 packet should replace the default receive SSRC.
5130 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5131 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
5132 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5133 // Verify that the receive stream sinks to a renderer.
Artem Titov1ebfb6a2019-01-03 23:49:37 +01005134 webrtc::VideoFrame video_frame2 =
5135 webrtc::VideoFrame::Builder()
5136 .set_video_frame_buffer(CreateBlackFrameBuffer(4, 4))
5137 .set_timestamp_rtp(200)
5138 .set_timestamp_us(0)
5139 .set_rotation(webrtc::kVideoRotation_0)
5140 .build();
mzanaty8a855d62017-02-17 15:46:43 -08005141 recv_stream->InjectFrame(video_frame2);
5142 EXPECT_EQ(2, renderer.num_rendered_frames());
5143
5144#if defined(WEBRTC_USE_H264)
5145 // Receive H264 packet on third SSRC.
5146 rtpHeader.payload_type = 126;
Yves Gerey665174f2018-06-19 15:03:05 +02005147 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 3;
mzanaty8a855d62017-02-17 15:46:43 -08005148 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5149 rtc::CopyOnWriteBuffer packet3(data, sizeof(data));
Niels Möllere6933812018-11-05 13:01:41 +01005150 channel_->OnPacketReceived(&packet3, /* packet_time_us */ -1);
mzanaty8a855d62017-02-17 15:46:43 -08005151 // H264 packet should replace the default receive SSRC.
5152 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5153 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
5154 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5155 // Verify that the receive stream sinks to a renderer.
Artem Titov1ebfb6a2019-01-03 23:49:37 +01005156 webrtc::VideoFrame video_frame3 =
5157 webrtc::VideoFrame::Builder()
5158 .set_video_frame_buffer(CreateBlackFrameBuffer(4, 4))
5159 .set_timestamp_rtp(300)
5160 .set_timestamp_us(0)
5161 .set_rotation(webrtc::kVideoRotation_0)
5162 .build();
mzanaty8a855d62017-02-17 15:46:43 -08005163 recv_stream->InjectFrame(video_frame3);
5164 EXPECT_EQ(3, renderer.num_rendered_frames());
5165#endif
5166}
5167
brandtr0dc57ea2017-05-29 23:33:31 -07005168// This test verifies that when a new default stream is created for a new
5169// unsignaled SSRC, the new stream does not overwrite any old stream that had
5170// been the default receive stream before being properly signaled.
eladalonf1841382017-06-12 01:16:46 -07005171TEST_F(WebRtcVideoChannelTest,
brandtr0dc57ea2017-05-29 23:33:31 -07005172 NewUnsignaledStreamDoesNotDestroyPreviouslyUnsignaledStream) {
5173 cricket::VideoRecvParameters parameters;
5174 parameters.codecs.push_back(GetEngineCodec("VP8"));
5175 ASSERT_TRUE(channel_->SetRecvParameters(parameters));
5176
5177 // No streams signaled and no packets received, so we should not have any
5178 // stream objects created yet.
5179 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5180
5181 // Receive packet on an unsignaled SSRC.
5182 uint8_t data[kMinRtpPacketLen];
5183 cricket::RtpHeader rtp_header;
5184 rtp_header.payload_type = GetEngineCodec("VP8").id;
5185 rtp_header.seq_num = rtp_header.timestamp = 0;
5186 rtp_header.ssrc = kSsrcs3[0];
5187 cricket::SetRtpHeader(data, sizeof(data), rtp_header);
5188 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
Niels Möllere6933812018-11-05 13:01:41 +01005189 channel_->OnPacketReceived(&packet, /* packet_time_us */ -1);
brandtr0dc57ea2017-05-29 23:33:31 -07005190 // Default receive stream should be created.
5191 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5192 FakeVideoReceiveStream* recv_stream0 =
5193 fake_call_->GetVideoReceiveStreams()[0];
5194 EXPECT_EQ(kSsrcs3[0], recv_stream0->GetConfig().rtp.remote_ssrc);
5195
5196 // Signal the SSRC.
5197 EXPECT_TRUE(
5198 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrcs3[0])));
5199 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5200 recv_stream0 = fake_call_->GetVideoReceiveStreams()[0];
5201 EXPECT_EQ(kSsrcs3[0], recv_stream0->GetConfig().rtp.remote_ssrc);
5202
5203 // Receive packet on a different unsignaled SSRC.
5204 rtp_header.ssrc = kSsrcs3[1];
5205 cricket::SetRtpHeader(data, sizeof(data), rtp_header);
5206 packet.SetData(data, sizeof(data));
Niels Möllere6933812018-11-05 13:01:41 +01005207 channel_->OnPacketReceived(&packet, /* packet_time_us */ -1);
brandtr0dc57ea2017-05-29 23:33:31 -07005208 // New default receive stream should be created, but old stream should remain.
5209 ASSERT_EQ(2u, fake_call_->GetVideoReceiveStreams().size());
5210 EXPECT_EQ(recv_stream0, fake_call_->GetVideoReceiveStreams()[0]);
5211 FakeVideoReceiveStream* recv_stream1 =
5212 fake_call_->GetVideoReceiveStreams()[1];
5213 EXPECT_EQ(kSsrcs3[1], recv_stream1->GetConfig().rtp.remote_ssrc);
5214}
5215
Seth Hampson7c682e02018-05-04 16:28:15 -07005216TEST_F(WebRtcVideoChannelTest, CanSetMaxBitrateForExistingStream) {
skvladdc1c62c2016-03-16 19:07:43 -07005217 AddSendStream();
5218
Niels Möller805a27e2019-01-21 12:21:27 +01005219 webrtc::test::FrameForwarder frame_forwarder;
5220 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
skvladdc1c62c2016-03-16 19:07:43 -07005221 EXPECT_TRUE(channel_->SetSend(true));
Niels Möller805a27e2019-01-21 12:21:27 +01005222 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
skvladdc1c62c2016-03-16 19:07:43 -07005223
perkjfa10b552016-10-02 23:45:26 -07005224 int default_encoder_bitrate = GetMaxEncoderBitrate();
brandtr468da7c2016-11-22 02:16:47 -08005225 EXPECT_GT(default_encoder_bitrate, 1000);
skvladdc1c62c2016-03-16 19:07:43 -07005226
5227 // TODO(skvlad): Resolve the inconsistency between the interpretation
5228 // of the global bitrate limit for audio and video:
5229 // - Audio: max_bandwidth_bps = 0 - fail the operation,
5230 // max_bandwidth_bps = -1 - remove the bandwidth limit
5231 // - Video: max_bandwidth_bps = 0 - remove the bandwidth limit,
pbos5c7760a2017-03-10 11:23:12 -08005232 // max_bandwidth_bps = -1 - remove the bandwidth limit
skvladdc1c62c2016-03-16 19:07:43 -07005233
perkjfa10b552016-10-02 23:45:26 -07005234 SetAndExpectMaxBitrate(1000, 0, 1000);
5235 SetAndExpectMaxBitrate(1000, 800, 800);
5236 SetAndExpectMaxBitrate(600, 800, 600);
5237 SetAndExpectMaxBitrate(0, 800, 800);
5238 SetAndExpectMaxBitrate(0, 0, default_encoder_bitrate);
skvladdc1c62c2016-03-16 19:07:43 -07005239
Niels Möllerff40b142018-04-09 08:49:14 +02005240 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
skvladdc1c62c2016-03-16 19:07:43 -07005241}
5242
eladalonf1841382017-06-12 01:16:46 -07005243TEST_F(WebRtcVideoChannelTest, CannotSetMaxBitrateForNonexistentStream) {
skvladdc1c62c2016-03-16 19:07:43 -07005244 webrtc::RtpParameters nonexistent_parameters =
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005245 channel_->GetRtpSendParameters(last_ssrc_);
Mirko Bonadeif859e552018-05-30 15:31:29 +02005246 EXPECT_EQ(0u, nonexistent_parameters.encodings.size());
skvladdc1c62c2016-03-16 19:07:43 -07005247
5248 nonexistent_parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005249 EXPECT_FALSE(
Zach Steinba37b4b2018-01-23 15:02:36 -08005250 channel_->SetRtpSendParameters(last_ssrc_, nonexistent_parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07005251}
5252
eladalonf1841382017-06-12 01:16:46 -07005253TEST_F(WebRtcVideoChannelTest,
Seth Hampson7c682e02018-05-04 16:28:15 -07005254 SetLowMaxBitrateOverwritesVideoStreamMinBitrate) {
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005255 FakeVideoSendStream* stream = AddSendStream();
5256
Seth Hampson7c682e02018-05-04 16:28:15 -07005257 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5258 EXPECT_EQ(1UL, parameters.encodings.size());
5259 EXPECT_FALSE(parameters.encodings[0].max_bitrate_bps.has_value());
5260 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5261
5262 // Note that this is testing the behavior of the FakeVideoSendStream, which
5263 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5264 // we are just testing the behavior of
5265 // EncoderStreamFactory::CreateEncoderStreams.
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005266 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5267 EXPECT_EQ(kMinVideoBitrateBps, stream->GetVideoStreams()[0].min_bitrate_bps);
Seth Hampson7c682e02018-05-04 16:28:15 -07005268
5269 // Set a low max bitrate & check that VideoStream.min_bitrate_bps is limited
5270 // by this amount.
5271 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5272 int low_max_bitrate_bps = kMinVideoBitrateBps - 1000;
5273 parameters.encodings[0].max_bitrate_bps = low_max_bitrate_bps;
5274 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5275
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005276 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5277 EXPECT_EQ(low_max_bitrate_bps, stream->GetVideoStreams()[0].min_bitrate_bps);
5278 EXPECT_EQ(low_max_bitrate_bps, stream->GetVideoStreams()[0].max_bitrate_bps);
5279}
5280
5281TEST_F(WebRtcVideoChannelTest,
5282 SetHighMinBitrateOverwritesVideoStreamMaxBitrate) {
5283 FakeVideoSendStream* stream = AddSendStream();
5284
5285 // Note that this is testing the behavior of the FakeVideoSendStream, which
5286 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5287 // we are just testing the behavior of
5288 // EncoderStreamFactory::CreateEncoderStreams.
5289 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5290 int high_min_bitrate_bps = stream->GetVideoStreams()[0].max_bitrate_bps + 1;
5291
5292 // Set a high min bitrate and check that max_bitrate_bps is adjusted up.
5293 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5294 EXPECT_EQ(1UL, parameters.encodings.size());
5295 parameters.encodings[0].min_bitrate_bps = high_min_bitrate_bps;
5296 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5297
5298 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5299 EXPECT_EQ(high_min_bitrate_bps, stream->GetVideoStreams()[0].min_bitrate_bps);
5300 EXPECT_EQ(high_min_bitrate_bps, stream->GetVideoStreams()[0].max_bitrate_bps);
5301}
5302
5303TEST_F(WebRtcVideoChannelTest,
5304 SetMinBitrateAboveMaxBitrateLimitAdjustsMinBitrateDown) {
5305 send_parameters_.max_bandwidth_bps = 99999;
5306 FakeVideoSendStream* stream = AddSendStream();
5307 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
5308 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
5309 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5310 EXPECT_EQ(kMinVideoBitrateBps, stream->GetVideoStreams()[0].min_bitrate_bps);
5311 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5312 stream->GetVideoStreams()[0].max_bitrate_bps);
5313
5314 // Set min bitrate above global max bitrate and check that min_bitrate_bps is
5315 // adjusted down.
5316 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5317 EXPECT_EQ(1UL, parameters.encodings.size());
5318 parameters.encodings[0].min_bitrate_bps = 99999 + 1;
5319 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5320 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5321 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5322 stream->GetVideoStreams()[0].min_bitrate_bps);
5323 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5324 stream->GetVideoStreams()[0].max_bitrate_bps);
Seth Hampson7c682e02018-05-04 16:28:15 -07005325}
5326
Åsa Persson8c1bf952018-09-13 10:42:19 +02005327TEST_F(WebRtcVideoChannelTest, SetMaxFramerateOneStream) {
5328 FakeVideoSendStream* stream = AddSendStream();
5329
5330 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5331 EXPECT_EQ(1UL, parameters.encodings.size());
5332 EXPECT_FALSE(parameters.encodings[0].max_framerate.has_value());
5333 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5334
5335 // Note that this is testing the behavior of the FakeVideoSendStream, which
5336 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5337 // we are just testing the behavior of
5338 // EncoderStreamFactory::CreateEncoderStreams.
5339 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5340 EXPECT_EQ(kDefaultVideoMaxFramerate,
5341 stream->GetVideoStreams()[0].max_framerate);
5342
5343 // Set max framerate and check that VideoStream.max_framerate is set.
5344 const int kNewMaxFramerate = kDefaultVideoMaxFramerate - 1;
5345 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5346 parameters.encodings[0].max_framerate = kNewMaxFramerate;
5347 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5348
5349 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5350 EXPECT_EQ(kNewMaxFramerate, stream->GetVideoStreams()[0].max_framerate);
5351}
5352
Åsa Persson23eba222018-10-02 14:47:06 +02005353TEST_F(WebRtcVideoChannelTest, SetNumTemporalLayersForSingleStream) {
5354 FakeVideoSendStream* stream = AddSendStream();
5355
5356 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5357 EXPECT_EQ(1UL, parameters.encodings.size());
5358 EXPECT_FALSE(parameters.encodings[0].num_temporal_layers.has_value());
5359 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5360
5361 // Note that this is testing the behavior of the FakeVideoSendStream, which
5362 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5363 // we are just testing the behavior of
5364 // EncoderStreamFactory::CreateEncoderStreams.
5365 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5366 EXPECT_FALSE(stream->GetVideoStreams()[0].num_temporal_layers.has_value());
5367
5368 // Set temporal layers and check that VideoStream.num_temporal_layers is set.
5369 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5370 parameters.encodings[0].num_temporal_layers = 2;
5371 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5372
5373 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5374 EXPECT_EQ(2UL, stream->GetVideoStreams()[0].num_temporal_layers);
5375}
5376
Seth Hampson7c682e02018-05-04 16:28:15 -07005377TEST_F(WebRtcVideoChannelTest,
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005378 CannotSetRtpSendParametersWithIncorrectNumberOfEncodings) {
skvladdc1c62c2016-03-16 19:07:43 -07005379 AddSendStream();
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005380 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07005381 // Two or more encodings should result in failure.
5382 parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Zach Steinba37b4b2018-01-23 15:02:36 -08005383 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeeffb2aced2017-01-06 23:05:37 -08005384 // Zero encodings should also fail.
5385 parameters.encodings.clear();
Zach Steinba37b4b2018-01-23 15:02:36 -08005386 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeeffb2aced2017-01-06 23:05:37 -08005387}
5388
Zach Stein3ca452b2018-01-18 10:01:24 -08005389TEST_F(WebRtcVideoChannelTest,
5390 CannotSetSimulcastRtpSendParametersWithIncorrectNumberOfEncodings) {
5391 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
5392 StreamParams sp = CreateSimStreamParams("cname", ssrcs);
5393 AddSendStream(sp);
5394
5395 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5396
5397 // Additional encodings should result in failure.
5398 parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Zach Steinba37b4b2018-01-23 15:02:36 -08005399 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Zach Stein3ca452b2018-01-18 10:01:24 -08005400 // Zero encodings should also fail.
5401 parameters.encodings.clear();
Zach Steinba37b4b2018-01-23 15:02:36 -08005402 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Zach Stein3ca452b2018-01-18 10:01:24 -08005403}
5404
deadbeeffb2aced2017-01-06 23:05:37 -08005405// Changing the SSRC through RtpParameters is not allowed.
eladalonf1841382017-06-12 01:16:46 -07005406TEST_F(WebRtcVideoChannelTest, CannotSetSsrcInRtpSendParameters) {
deadbeeffb2aced2017-01-06 23:05:37 -08005407 AddSendStream();
5408 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
Oskar Sundbom78807582017-11-16 11:09:55 +01005409 parameters.encodings[0].ssrc = 0xdeadbeef;
Zach Steinba37b4b2018-01-23 15:02:36 -08005410 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07005411}
5412
Seth Hampson24722b32017-12-22 09:36:42 -08005413// Tests that when RTCRtpEncodingParameters.bitrate_priority gets set to
5414// a value <= 0, setting the parameters returns false.
5415TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersInvalidBitratePriority) {
5416 AddSendStream();
5417 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5418 EXPECT_EQ(1UL, parameters.encodings.size());
5419 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5420 parameters.encodings[0].bitrate_priority);
5421
5422 parameters.encodings[0].bitrate_priority = 0;
Zach Steinba37b4b2018-01-23 15:02:36 -08005423 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005424 parameters.encodings[0].bitrate_priority = -2;
Zach Steinba37b4b2018-01-23 15:02:36 -08005425 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005426}
5427
5428// Tests when the the RTCRtpEncodingParameters.bitrate_priority gets set
5429// properly on the VideoChannel and propogates down to the video encoder.
5430TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersPriorityOneStream) {
5431 AddSendStream();
5432 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5433 EXPECT_EQ(1UL, parameters.encodings.size());
5434 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5435 parameters.encodings[0].bitrate_priority);
5436
5437 // Change the value and set it on the VideoChannel.
5438 double new_bitrate_priority = 2.0;
5439 parameters.encodings[0].bitrate_priority = new_bitrate_priority;
Zach Steinba37b4b2018-01-23 15:02:36 -08005440 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005441
5442 // Verify that the encoding parameters bitrate_priority is set for the
5443 // VideoChannel.
5444 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5445 EXPECT_EQ(1UL, parameters.encodings.size());
5446 EXPECT_EQ(new_bitrate_priority, parameters.encodings[0].bitrate_priority);
5447
5448 // Verify that the new value propagated down to the encoder.
5449 std::vector<FakeVideoSendStream*> video_send_streams =
5450 fake_call_->GetVideoSendStreams();
5451 EXPECT_EQ(1UL, video_send_streams.size());
5452 FakeVideoSendStream* video_send_stream = video_send_streams.front();
5453 // Check that the WebRtcVideoSendStream updated the VideoEncoderConfig
5454 // appropriately.
5455 EXPECT_EQ(new_bitrate_priority,
5456 video_send_stream->GetEncoderConfig().bitrate_priority);
5457 // Check that the vector of VideoStreams also was propagated correctly. Note
5458 // that this is testing the behavior of the FakeVideoSendStream, which mimics
5459 // the calls to CreateEncoderStreams to get the VideoStreams.
Danil Chapovalov00c71832018-06-15 15:58:38 +02005460 EXPECT_EQ(absl::optional<double>(new_bitrate_priority),
Seth Hampson24722b32017-12-22 09:36:42 -08005461 video_send_stream->GetVideoStreams()[0].bitrate_priority);
5462}
5463
5464// Tests that the RTCRtpEncodingParameters.bitrate_priority is set for the
5465// VideoChannel and the value propogates to the video encoder with all simulcast
5466// streams.
5467TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersPrioritySimulcastStreams) {
5468 // Create the stream params with multiple ssrcs for simulcast.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005469 const size_t kNumSimulcastStreams = 3;
Seth Hampson24722b32017-12-22 09:36:42 -08005470 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
5471 StreamParams stream_params = CreateSimStreamParams("cname", ssrcs);
5472 AddSendStream(stream_params);
5473 uint32_t primary_ssrc = stream_params.first_ssrc();
5474
Niels Möller805a27e2019-01-21 12:21:27 +01005475 // Using the FrameForwarder, we manually send a full size
Tommi85959932018-02-07 19:26:06 +01005476 // frame. This creates multiple VideoStreams for all simulcast layers when
5477 // reconfiguring, and allows us to test this behavior.
Niels Möller805a27e2019-01-21 12:21:27 +01005478 webrtc::test::FrameForwarder frame_forwarder;
Seth Hampson24722b32017-12-22 09:36:42 -08005479 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01005480 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, &options, &frame_forwarder));
Seth Hampson24722b32017-12-22 09:36:42 -08005481 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01005482 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame(
5483 1920, 1080, webrtc::VideoRotation::kVideoRotation_0,
5484 rtc::kNumMicrosecsPerSec / 30));
5485
Seth Hampson24722b32017-12-22 09:36:42 -08005486 // Get and set the rtp encoding parameters.
5487 webrtc::RtpParameters parameters =
5488 channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02005489 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson24722b32017-12-22 09:36:42 -08005490 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5491 parameters.encodings[0].bitrate_priority);
5492 // Change the value and set it on the VideoChannel.
5493 double new_bitrate_priority = 2.0;
5494 parameters.encodings[0].bitrate_priority = new_bitrate_priority;
Zach Steinba37b4b2018-01-23 15:02:36 -08005495 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005496
5497 // Verify that the encoding parameters priority is set on the VideoChannel.
5498 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02005499 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson24722b32017-12-22 09:36:42 -08005500 EXPECT_EQ(new_bitrate_priority, parameters.encodings[0].bitrate_priority);
5501
5502 // Verify that the new value propagated down to the encoder.
5503 std::vector<FakeVideoSendStream*> video_send_streams =
5504 fake_call_->GetVideoSendStreams();
5505 EXPECT_EQ(1UL, video_send_streams.size());
5506 FakeVideoSendStream* video_send_stream = video_send_streams.front();
5507 // Check that the WebRtcVideoSendStream updated the VideoEncoderConfig
5508 // appropriately.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005509 EXPECT_EQ(kNumSimulcastStreams,
Seth Hampson24722b32017-12-22 09:36:42 -08005510 video_send_stream->GetEncoderConfig().number_of_streams);
5511 EXPECT_EQ(new_bitrate_priority,
5512 video_send_stream->GetEncoderConfig().bitrate_priority);
5513 // Check that the vector of VideoStreams also propagated correctly. The
5514 // FakeVideoSendStream calls CreateEncoderStreams, and we are testing that
5515 // these are created appropriately for the simulcast case.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005516 EXPECT_EQ(kNumSimulcastStreams, video_send_stream->GetVideoStreams().size());
Danil Chapovalov00c71832018-06-15 15:58:38 +02005517 EXPECT_EQ(absl::optional<double>(new_bitrate_priority),
Seth Hampson24722b32017-12-22 09:36:42 -08005518 video_send_stream->GetVideoStreams()[0].bitrate_priority);
5519 // Since we are only setting bitrate priority per-sender, the other
5520 // VideoStreams should have a bitrate priority of 0.
Danil Chapovalov00c71832018-06-15 15:58:38 +02005521 EXPECT_EQ(absl::nullopt,
Seth Hampson24722b32017-12-22 09:36:42 -08005522 video_send_stream->GetVideoStreams()[1].bitrate_priority);
Danil Chapovalov00c71832018-06-15 15:58:38 +02005523 EXPECT_EQ(absl::nullopt,
Seth Hampson24722b32017-12-22 09:36:42 -08005524 video_send_stream->GetVideoStreams()[2].bitrate_priority);
Niels Möllerff40b142018-04-09 08:49:14 +02005525 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, nullptr, nullptr));
Seth Hampson24722b32017-12-22 09:36:42 -08005526}
5527
Tim Haloun648d28a2018-10-18 16:52:22 -07005528// RTCRtpEncodingParameters.network_priority must be one of a few values
5529// derived from the default priority, corresponding to very-low, low, medium,
5530// or high.
5531TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersInvalidNetworkPriority) {
5532 AddSendStream();
5533 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5534 EXPECT_EQ(1UL, parameters.encodings.size());
5535 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5536 parameters.encodings[0].network_priority);
5537
5538 double good_values[] = {0.5, 1.0, 2.0, 4.0};
5539 double bad_values[] = {-1.0, 0.0, 0.49, 0.51, 1.1, 3.99, 4.1, 5.0};
5540 for (auto it : good_values) {
5541 parameters.encodings[0].network_priority = it;
5542 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5543 }
5544 for (auto it : bad_values) {
5545 parameters.encodings[0].network_priority = it;
5546 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5547 }
5548}
5549
Åsa Persson8c1bf952018-09-13 10:42:19 +02005550TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersMaxFramerate) {
5551 const size_t kNumSimulcastStreams = 3;
5552 SetUpSimulcast(true, false);
5553
5554 // Get and set the rtp encoding parameters.
5555 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5556 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5557 for (const auto& encoding : parameters.encodings) {
5558 EXPECT_FALSE(encoding.max_framerate);
5559 }
5560
5561 // Change the value and set it on the VideoChannel.
5562 parameters.encodings[0].max_framerate = 10;
5563 parameters.encodings[1].max_framerate = 20;
5564 parameters.encodings[2].max_framerate = 25;
5565 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5566
5567 // Verify that the bitrates are set on the VideoChannel.
5568 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5569 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5570 EXPECT_EQ(10, parameters.encodings[0].max_framerate);
5571 EXPECT_EQ(20, parameters.encodings[1].max_framerate);
5572 EXPECT_EQ(25, parameters.encodings[2].max_framerate);
5573}
5574
Åsa Persson23eba222018-10-02 14:47:06 +02005575TEST_F(WebRtcVideoChannelTest,
5576 SetRtpSendParametersNumTemporalLayersFailsForInvalidRange) {
5577 const size_t kNumSimulcastStreams = 3;
5578 SetUpSimulcast(true, false);
5579
5580 // Get and set the rtp encoding parameters.
5581 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5582 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5583
5584 // Num temporal layers should be in the range [1, kMaxTemporalStreams].
5585 parameters.encodings[0].num_temporal_layers = 0;
5586 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
5587 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
5588 parameters.encodings[0].num_temporal_layers = webrtc::kMaxTemporalStreams + 1;
5589 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
5590 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
5591}
5592
5593TEST_F(WebRtcVideoChannelTest,
5594 SetRtpSendParametersNumTemporalLayersFailsForInvalidModification) {
5595 const size_t kNumSimulcastStreams = 3;
5596 SetUpSimulcast(true, false);
5597
5598 // Get and set the rtp encoding parameters.
5599 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5600 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5601
5602 // No/all layers should be set.
5603 parameters.encodings[0].num_temporal_layers = 1;
5604 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION,
5605 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
5606
5607 // Different values not supported.
5608 parameters.encodings[0].num_temporal_layers = 1;
5609 parameters.encodings[1].num_temporal_layers = 2;
5610 parameters.encodings[2].num_temporal_layers = 2;
5611 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION,
5612 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
5613}
5614
5615TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersNumTemporalLayers) {
5616 const size_t kNumSimulcastStreams = 3;
5617 SetUpSimulcast(true, false);
5618
5619 // Get and set the rtp encoding parameters.
5620 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5621 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5622 for (const auto& encoding : parameters.encodings)
5623 EXPECT_FALSE(encoding.num_temporal_layers);
5624
5625 // Change the value and set it on the VideoChannel.
5626 parameters.encodings[0].num_temporal_layers = 3;
5627 parameters.encodings[1].num_temporal_layers = 3;
5628 parameters.encodings[2].num_temporal_layers = 3;
5629 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5630
5631 // Verify that the number of temporal layers are set on the VideoChannel.
5632 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5633 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5634 EXPECT_EQ(3, parameters.encodings[0].num_temporal_layers);
5635 EXPECT_EQ(3, parameters.encodings[1].num_temporal_layers);
5636 EXPECT_EQ(3, parameters.encodings[2].num_temporal_layers);
5637}
5638
5639TEST_F(WebRtcVideoChannelTest, NumTemporalLayersPropagatedToEncoder) {
5640 const size_t kNumSimulcastStreams = 3;
5641 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5642
5643 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01005644 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson23eba222018-10-02 14:47:06 +02005645 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01005646 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson23eba222018-10-02 14:47:06 +02005647 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01005648 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson23eba222018-10-02 14:47:06 +02005649
5650 // Get and set the rtp encoding parameters.
5651 // Change the value and set it on the VideoChannel.
5652 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5653 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5654 parameters.encodings[0].num_temporal_layers = 2;
5655 parameters.encodings[1].num_temporal_layers = 2;
5656 parameters.encodings[2].num_temporal_layers = 2;
5657 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5658
5659 // Verify that the new value is propagated down to the encoder.
5660 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
5661 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
5662 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
5663 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
5664 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
5665 EXPECT_EQ(2UL, encoder_config.simulcast_layers[0].num_temporal_layers);
5666 EXPECT_EQ(2UL, encoder_config.simulcast_layers[1].num_temporal_layers);
5667 EXPECT_EQ(2UL, encoder_config.simulcast_layers[2].num_temporal_layers);
5668
5669 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
5670 // VideoStreams are created appropriately for the simulcast case.
5671 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5672 EXPECT_EQ(2UL, stream->GetVideoStreams()[0].num_temporal_layers);
5673 EXPECT_EQ(2UL, stream->GetVideoStreams()[1].num_temporal_layers);
5674 EXPECT_EQ(2UL, stream->GetVideoStreams()[2].num_temporal_layers);
5675
5676 // No parameter changed, encoder should not be reconfigured.
5677 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5678 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
5679
5680 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5681}
5682
5683TEST_F(WebRtcVideoChannelTest,
5684 DefaultValuePropagatedToEncoderForUnsetNumTemporalLayers) {
5685 const size_t kDefaultNumTemporalLayers = 3;
5686 const size_t kNumSimulcastStreams = 3;
5687 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5688
5689 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01005690 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson23eba222018-10-02 14:47:06 +02005691 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01005692 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson23eba222018-10-02 14:47:06 +02005693 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01005694 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson23eba222018-10-02 14:47:06 +02005695
5696 // Change rtp encoding parameters, num_temporal_layers not changed.
5697 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5698 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5699 parameters.encodings[0].min_bitrate_bps = 33000;
5700 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5701
5702 // Verify that no value is propagated down to the encoder.
5703 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
5704 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
5705 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
5706 EXPECT_FALSE(encoder_config.simulcast_layers[0].num_temporal_layers);
5707 EXPECT_FALSE(encoder_config.simulcast_layers[1].num_temporal_layers);
5708 EXPECT_FALSE(encoder_config.simulcast_layers[2].num_temporal_layers);
5709
5710 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
5711 // VideoStreams are created appropriately for the simulcast case.
5712 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5713 EXPECT_EQ(kDefaultNumTemporalLayers,
5714 stream->GetVideoStreams()[0].num_temporal_layers);
5715 EXPECT_EQ(kDefaultNumTemporalLayers,
5716 stream->GetVideoStreams()[1].num_temporal_layers);
5717 EXPECT_EQ(kDefaultNumTemporalLayers,
5718 stream->GetVideoStreams()[2].num_temporal_layers);
5719
5720 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5721}
5722
Åsa Persson8c1bf952018-09-13 10:42:19 +02005723TEST_F(WebRtcVideoChannelTest, MaxSimulcastFrameratePropagatedToEncoder) {
5724 const size_t kNumSimulcastStreams = 3;
5725 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5726
5727 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01005728 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson8c1bf952018-09-13 10:42:19 +02005729 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01005730 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson8c1bf952018-09-13 10:42:19 +02005731 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01005732 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson8c1bf952018-09-13 10:42:19 +02005733
5734 // Get and set the rtp encoding parameters.
5735 // Change the value and set it on the VideoChannel.
5736 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5737 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5738 parameters.encodings[0].max_framerate = 15;
5739 parameters.encodings[1].max_framerate = 25;
5740 parameters.encodings[2].max_framerate = 20;
5741 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5742
5743 // Verify that the new value propagated down to the encoder.
5744 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
5745 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
5746 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
5747 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
5748 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
5749 EXPECT_EQ(15, encoder_config.simulcast_layers[0].max_framerate);
5750 EXPECT_EQ(25, encoder_config.simulcast_layers[1].max_framerate);
5751 EXPECT_EQ(20, encoder_config.simulcast_layers[2].max_framerate);
5752
5753 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
5754 // VideoStreams are created appropriately for the simulcast case.
5755 // Currently the maximum |max_framerate| is used.
5756 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5757 EXPECT_EQ(25, stream->GetVideoStreams()[0].max_framerate);
5758 EXPECT_EQ(25, stream->GetVideoStreams()[1].max_framerate);
5759 EXPECT_EQ(25, stream->GetVideoStreams()[2].max_framerate);
5760
5761 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5762}
5763
5764TEST_F(WebRtcVideoChannelTest,
5765 DefaultValuePropagatedToEncoderForUnsetFramerate) {
5766 const size_t kNumSimulcastStreams = 3;
5767 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
5768 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5769
5770 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01005771 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson8c1bf952018-09-13 10:42:19 +02005772 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01005773 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson8c1bf952018-09-13 10:42:19 +02005774 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01005775 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson8c1bf952018-09-13 10:42:19 +02005776
5777 // Get and set the rtp encoding parameters.
5778 // Change the value and set it on the VideoChannel.
5779 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5780 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5781 parameters.encodings[0].max_framerate = 15;
5782 parameters.encodings[2].max_framerate = 20;
5783 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5784
5785 // Verify that the new value propagated down to the encoder.
5786 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
5787 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
5788 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
5789 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
5790 EXPECT_EQ(15, encoder_config.simulcast_layers[0].max_framerate);
5791 EXPECT_EQ(-1, encoder_config.simulcast_layers[1].max_framerate);
5792 EXPECT_EQ(20, encoder_config.simulcast_layers[2].max_framerate);
5793
5794 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
5795 // VideoStreams are created appropriately for the simulcast case.
5796 // The maximum |max_framerate| is used, kDefaultVideoMaxFramerate: 60.
5797 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5798 EXPECT_EQ(kDefaultVideoMaxFramerate,
5799 stream->GetVideoStreams()[0].max_framerate);
5800 EXPECT_EQ(kDefaultVideoMaxFramerate,
5801 stream->GetVideoStreams()[1].max_framerate);
5802 EXPECT_EQ(kDefaultVideoMaxFramerate,
5803 stream->GetVideoStreams()[2].max_framerate);
5804
5805 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5806}
5807
Åsa Persson55659812018-06-18 17:51:32 +02005808TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersMinAndMaxBitrate) {
5809 const size_t kNumSimulcastStreams = 3;
5810 SetUpSimulcast(true, false);
5811
5812 // Get and set the rtp encoding parameters.
5813 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5814 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5815 for (const auto& encoding : parameters.encodings) {
5816 EXPECT_FALSE(encoding.min_bitrate_bps);
5817 EXPECT_FALSE(encoding.max_bitrate_bps);
5818 }
5819
5820 // Change the value and set it on the VideoChannel.
5821 parameters.encodings[0].min_bitrate_bps = 100000;
5822 parameters.encodings[0].max_bitrate_bps = 200000;
5823 parameters.encodings[1].min_bitrate_bps = 300000;
5824 parameters.encodings[1].max_bitrate_bps = 400000;
5825 parameters.encodings[2].min_bitrate_bps = 500000;
5826 parameters.encodings[2].max_bitrate_bps = 600000;
5827 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5828
5829 // Verify that the bitrates are set on the VideoChannel.
5830 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5831 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5832 EXPECT_EQ(100000, parameters.encodings[0].min_bitrate_bps);
5833 EXPECT_EQ(200000, parameters.encodings[0].max_bitrate_bps);
5834 EXPECT_EQ(300000, parameters.encodings[1].min_bitrate_bps);
5835 EXPECT_EQ(400000, parameters.encodings[1].max_bitrate_bps);
5836 EXPECT_EQ(500000, parameters.encodings[2].min_bitrate_bps);
5837 EXPECT_EQ(600000, parameters.encodings[2].max_bitrate_bps);
5838}
5839
5840TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersFailsWithIncorrectBitrate) {
5841 const size_t kNumSimulcastStreams = 3;
5842 SetUpSimulcast(true, false);
5843
5844 // Get and set the rtp encoding parameters.
5845 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5846 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5847
5848 // Max bitrate lower than min bitrate should fail.
5849 parameters.encodings[2].min_bitrate_bps = 100000;
5850 parameters.encodings[2].max_bitrate_bps = 100000 - 1;
5851 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
5852 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
5853}
5854
5855// Test that min and max bitrate values set via RtpParameters are correctly
5856// propagated to the underlying encoder, and that the target is set to 3/4 of
5857// the maximum (3/4 was chosen because it's similar to the simulcast defaults
5858// that are used if no min/max are specified).
5859TEST_F(WebRtcVideoChannelTest, MinAndMaxSimulcastBitratePropagatedToEncoder) {
5860 const size_t kNumSimulcastStreams = 3;
5861 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5862
5863 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01005864 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02005865 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01005866 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02005867 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01005868 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02005869
5870 // Get and set the rtp encoding parameters.
5871 // Change the value and set it on the VideoChannel.
5872 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5873 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5874 parameters.encodings[0].min_bitrate_bps = 100000;
5875 parameters.encodings[0].max_bitrate_bps = 200000;
5876 parameters.encodings[1].min_bitrate_bps = 300000;
5877 parameters.encodings[1].max_bitrate_bps = 400000;
5878 parameters.encodings[2].min_bitrate_bps = 500000;
5879 parameters.encodings[2].max_bitrate_bps = 600000;
5880 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5881
5882 // Verify that the new value propagated down to the encoder.
5883 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
5884 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
5885 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
5886 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
5887 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
5888 EXPECT_EQ(100000, encoder_config.simulcast_layers[0].min_bitrate_bps);
5889 EXPECT_EQ(200000, encoder_config.simulcast_layers[0].max_bitrate_bps);
5890 EXPECT_EQ(300000, encoder_config.simulcast_layers[1].min_bitrate_bps);
5891 EXPECT_EQ(400000, encoder_config.simulcast_layers[1].max_bitrate_bps);
5892 EXPECT_EQ(500000, encoder_config.simulcast_layers[2].min_bitrate_bps);
5893 EXPECT_EQ(600000, encoder_config.simulcast_layers[2].max_bitrate_bps);
5894
5895 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
5896 // VideoStreams are created appropriately for the simulcast case.
5897 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5898 // Target bitrate: 200000 * 3 / 4 = 150000.
5899 EXPECT_EQ(100000, stream->GetVideoStreams()[0].min_bitrate_bps);
5900 EXPECT_EQ(150000, stream->GetVideoStreams()[0].target_bitrate_bps);
5901 EXPECT_EQ(200000, stream->GetVideoStreams()[0].max_bitrate_bps);
5902 // Target bitrate: 400000 * 3 / 4 = 300000.
5903 EXPECT_EQ(300000, stream->GetVideoStreams()[1].min_bitrate_bps);
5904 EXPECT_EQ(300000, stream->GetVideoStreams()[1].target_bitrate_bps);
5905 EXPECT_EQ(400000, stream->GetVideoStreams()[1].max_bitrate_bps);
5906 // Target bitrate: 600000 * 3 / 4 = 450000, less than min -> max.
5907 EXPECT_EQ(500000, stream->GetVideoStreams()[2].min_bitrate_bps);
5908 EXPECT_EQ(600000, stream->GetVideoStreams()[2].target_bitrate_bps);
5909 EXPECT_EQ(600000, stream->GetVideoStreams()[2].max_bitrate_bps);
5910
5911 // No parameter changed, encoder should not be reconfigured.
5912 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5913 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
5914
5915 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5916}
5917
5918// Test to only specify the min or max bitrate value for a layer via
5919// RtpParameters. The unspecified min/max and target value should be set to the
5920// simulcast default that is used if no min/max are specified.
5921TEST_F(WebRtcVideoChannelTest, MinOrMaxSimulcastBitratePropagatedToEncoder) {
5922 const size_t kNumSimulcastStreams = 3;
5923 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
5924 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5925
5926 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01005927 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02005928 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01005929 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02005930 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01005931 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02005932
5933 // Get and set the rtp encoding parameters.
5934 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5935 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5936
5937 // Change the value and set it on the VideoChannel.
5938 // Layer 0: only configure min bitrate.
5939 const int kMinBpsLayer0 = kDefault[0].min_bitrate_bps + 1;
5940 parameters.encodings[0].min_bitrate_bps = kMinBpsLayer0;
5941 // Layer 1: only configure max bitrate.
5942 const int kMaxBpsLayer1 = kDefault[1].max_bitrate_bps - 1;
5943 parameters.encodings[1].max_bitrate_bps = kMaxBpsLayer1;
5944 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5945
5946 // Verify that the new value propagated down to the encoder.
5947 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
5948 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
5949 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
5950 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
5951 EXPECT_EQ(kMinBpsLayer0, encoder_config.simulcast_layers[0].min_bitrate_bps);
5952 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].max_bitrate_bps);
5953 EXPECT_EQ(-1, encoder_config.simulcast_layers[1].min_bitrate_bps);
5954 EXPECT_EQ(kMaxBpsLayer1, encoder_config.simulcast_layers[1].max_bitrate_bps);
5955 EXPECT_EQ(-1, encoder_config.simulcast_layers[2].min_bitrate_bps);
5956 EXPECT_EQ(-1, encoder_config.simulcast_layers[2].max_bitrate_bps);
5957
5958 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
5959 // VideoStreams are created appropriately for the simulcast case.
5960 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5961 // Layer 0: min configured bitrate should overwrite min default.
5962 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].min_bitrate_bps);
5963 EXPECT_EQ(kDefault[0].target_bitrate_bps,
5964 stream->GetVideoStreams()[0].target_bitrate_bps);
5965 EXPECT_EQ(kDefault[0].max_bitrate_bps,
5966 stream->GetVideoStreams()[0].max_bitrate_bps);
5967 // Layer 1: max configured bitrate should overwrite max default.
5968 EXPECT_EQ(kDefault[1].min_bitrate_bps,
5969 stream->GetVideoStreams()[1].min_bitrate_bps);
5970 EXPECT_EQ(kDefault[1].target_bitrate_bps,
5971 stream->GetVideoStreams()[1].target_bitrate_bps);
5972 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].max_bitrate_bps);
5973 // Layer 2: min and max bitrate not configured, default expected.
5974 EXPECT_EQ(kDefault[2].min_bitrate_bps,
5975 stream->GetVideoStreams()[2].min_bitrate_bps);
5976 EXPECT_EQ(kDefault[2].target_bitrate_bps,
5977 stream->GetVideoStreams()[2].target_bitrate_bps);
5978 EXPECT_EQ(kDefault[2].max_bitrate_bps,
5979 stream->GetVideoStreams()[2].max_bitrate_bps);
5980
5981 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5982}
5983
5984// Test that specifying the min (or max) bitrate value for a layer via
5985// RtpParameters above (or below) the simulcast default max (or min) adjusts the
5986// unspecified values accordingly.
5987TEST_F(WebRtcVideoChannelTest, SetMinAndMaxSimulcastBitrateAboveBelowDefault) {
5988 const size_t kNumSimulcastStreams = 3;
5989 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
5990 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5991
5992 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01005993 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02005994 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01005995 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02005996 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01005997 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02005998
5999 // Get and set the rtp encoding parameters.
6000 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6001 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6002
6003 // Change the value and set it on the VideoChannel.
6004 // For layer 0, set the min bitrate above the default max.
6005 const int kMinBpsLayer0 = kDefault[0].max_bitrate_bps + 1;
6006 parameters.encodings[0].min_bitrate_bps = kMinBpsLayer0;
6007 // For layer 1, set the max bitrate below the default min.
6008 const int kMaxBpsLayer1 = kDefault[1].min_bitrate_bps - 1;
6009 parameters.encodings[1].max_bitrate_bps = kMaxBpsLayer1;
6010 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6011
6012 // Verify that the new value propagated down to the encoder.
6013 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6014 // VideoStreams are created appropriately for the simulcast case.
6015 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6016 // Layer 0: Min bitrate above default max (target/max should be adjusted).
6017 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].min_bitrate_bps);
6018 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].target_bitrate_bps);
6019 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].max_bitrate_bps);
6020 // Layer 1: Max bitrate below default min (min/target should be adjusted).
6021 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].min_bitrate_bps);
6022 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].target_bitrate_bps);
6023 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].max_bitrate_bps);
6024 // Layer 2: min and max bitrate not configured, default expected.
6025 EXPECT_EQ(kDefault[2].min_bitrate_bps,
6026 stream->GetVideoStreams()[2].min_bitrate_bps);
6027 EXPECT_EQ(kDefault[2].target_bitrate_bps,
6028 stream->GetVideoStreams()[2].target_bitrate_bps);
6029 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6030 stream->GetVideoStreams()[2].max_bitrate_bps);
6031
6032 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6033}
6034
6035TEST_F(WebRtcVideoChannelTest, BandwidthAboveTotalMaxBitrateGivenToMaxLayer) {
6036 const size_t kNumSimulcastStreams = 3;
6037 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6038 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6039
6040 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006041 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006042 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006043 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006044 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006045 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006046
6047 // Set max bitrate for all but the highest layer.
6048 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6049 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6050 parameters.encodings[0].max_bitrate_bps = kDefault[0].max_bitrate_bps;
6051 parameters.encodings[1].max_bitrate_bps = kDefault[1].max_bitrate_bps;
6052 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6053
6054 // Set max bandwidth equal to total max bitrate.
6055 send_parameters_.max_bandwidth_bps =
6056 GetTotalMaxBitrateBps(stream->GetVideoStreams());
6057 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6058 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6059
6060 // No bitrate above the total max to give to the highest layer.
6061 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6062 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6063 stream->GetVideoStreams()[2].max_bitrate_bps);
6064
6065 // Set max bandwidth above the total max bitrate.
6066 send_parameters_.max_bandwidth_bps =
6067 GetTotalMaxBitrateBps(stream->GetVideoStreams()) + 1;
6068 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6069 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6070
6071 // The highest layer has no max bitrate set -> the bitrate above the total
6072 // max should be given to the highest layer.
6073 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6074 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
6075 GetTotalMaxBitrateBps(stream->GetVideoStreams()));
6076 EXPECT_EQ(kDefault[2].max_bitrate_bps + 1,
6077 stream->GetVideoStreams()[2].max_bitrate_bps);
6078
6079 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6080}
6081
6082TEST_F(WebRtcVideoChannelTest,
6083 BandwidthAboveTotalMaxBitrateNotGivenToMaxLayerIfMaxBitrateSet) {
6084 const size_t kNumSimulcastStreams = 3;
6085 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6086 EXPECT_EQ(kNumSimulcastStreams, kDefault.size());
6087 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6088
6089 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006090 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006091 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006092 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006093 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006094 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006095
6096 // Set max bitrate for the highest layer.
6097 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6098 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6099 parameters.encodings[2].max_bitrate_bps = kDefault[2].max_bitrate_bps;
6100 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6101
6102 // Set max bandwidth above the total max bitrate.
6103 send_parameters_.max_bandwidth_bps =
6104 GetTotalMaxBitrateBps(stream->GetVideoStreams()) + 1;
6105 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6106 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6107
6108 // The highest layer has the max bitrate set -> the bitrate above the total
6109 // max should not be given to the highest layer.
6110 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6111 EXPECT_EQ(*parameters.encodings[2].max_bitrate_bps,
6112 stream->GetVideoStreams()[2].max_bitrate_bps);
6113
6114 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6115}
6116
Åsa Perssonbdee46d2018-06-25 11:28:06 +02006117// Test that min and max bitrate values set via RtpParameters are correctly
6118// propagated to the underlying encoder for a single stream.
6119TEST_F(WebRtcVideoChannelTest, MinAndMaxBitratePropagatedToEncoder) {
6120 FakeVideoSendStream* stream = AddSendStream();
6121 EXPECT_TRUE(channel_->SetSend(true));
6122 EXPECT_TRUE(stream->IsSending());
6123
6124 // Set min and max bitrate.
6125 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6126 EXPECT_EQ(1u, parameters.encodings.size());
6127 parameters.encodings[0].min_bitrate_bps = 80000;
6128 parameters.encodings[0].max_bitrate_bps = 150000;
6129 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6130
6131 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6132 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6133 EXPECT_EQ(1u, encoder_config.number_of_streams);
6134 EXPECT_EQ(1u, encoder_config.simulcast_layers.size());
6135 EXPECT_EQ(80000, encoder_config.simulcast_layers[0].min_bitrate_bps);
6136 EXPECT_EQ(150000, encoder_config.simulcast_layers[0].max_bitrate_bps);
6137
6138 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6139 // VideoStreams are created appropriately.
6140 EXPECT_EQ(1u, stream->GetVideoStreams().size());
6141 EXPECT_EQ(80000, stream->GetVideoStreams()[0].min_bitrate_bps);
6142 EXPECT_EQ(150000, stream->GetVideoStreams()[0].target_bitrate_bps);
6143 EXPECT_EQ(150000, stream->GetVideoStreams()[0].max_bitrate_bps);
6144}
6145
6146// Test the default min and max bitrate value are correctly propagated to the
6147// underlying encoder for a single stream (when the values are not set via
6148// RtpParameters).
6149TEST_F(WebRtcVideoChannelTest, DefaultMinAndMaxBitratePropagatedToEncoder) {
6150 FakeVideoSendStream* stream = AddSendStream();
6151 EXPECT_TRUE(channel_->SetSend(true));
6152 EXPECT_TRUE(stream->IsSending());
6153
6154 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6155 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6156 EXPECT_EQ(1u, encoder_config.number_of_streams);
6157 EXPECT_EQ(1u, encoder_config.simulcast_layers.size());
6158 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].min_bitrate_bps);
6159 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].max_bitrate_bps);
6160
6161 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6162 // VideoStreams are created appropriately.
6163 EXPECT_EQ(1u, stream->GetVideoStreams().size());
6164 EXPECT_EQ(cricket::kMinVideoBitrateBps,
6165 stream->GetVideoStreams()[0].min_bitrate_bps);
6166 EXPECT_GT(stream->GetVideoStreams()[0].max_bitrate_bps,
6167 stream->GetVideoStreams()[0].min_bitrate_bps);
6168 EXPECT_EQ(stream->GetVideoStreams()[0].max_bitrate_bps,
6169 stream->GetVideoStreams()[0].target_bitrate_bps);
6170}
6171
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006172// Test that a stream will not be sending if its encoding is made inactive
6173// through SetRtpSendParameters.
Seth Hampson8234ead2018-02-02 15:16:24 -08006174TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersOneEncodingActive) {
deadbeefdbe2b872016-03-22 15:42:00 -07006175 FakeVideoSendStream* stream = AddSendStream();
6176 EXPECT_TRUE(channel_->SetSend(true));
6177 EXPECT_TRUE(stream->IsSending());
6178
6179 // Get current parameters and change "active" to false.
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006180 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
deadbeefdbe2b872016-03-22 15:42:00 -07006181 ASSERT_EQ(1u, parameters.encodings.size());
6182 ASSERT_TRUE(parameters.encodings[0].active);
6183 parameters.encodings[0].active = false;
Zach Steinba37b4b2018-01-23 15:02:36 -08006184 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeefdbe2b872016-03-22 15:42:00 -07006185 EXPECT_FALSE(stream->IsSending());
6186
6187 // Now change it back to active and verify we resume sending.
6188 parameters.encodings[0].active = true;
Zach Steinba37b4b2018-01-23 15:02:36 -08006189 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeefdbe2b872016-03-22 15:42:00 -07006190 EXPECT_TRUE(stream->IsSending());
6191}
6192
Seth Hampson8234ead2018-02-02 15:16:24 -08006193// Tests that when active is updated for any simulcast layer then the send
6194// stream's sending state will be updated and it will be reconfigured with the
6195// new appropriate active simulcast streams.
6196TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersMultipleEncodingsActive) {
6197 // Create the stream params with multiple ssrcs for simulcast.
Åsa Persson31cb8f92018-06-27 10:44:56 +02006198 const size_t kNumSimulcastStreams = 3;
Seth Hampson8234ead2018-02-02 15:16:24 -08006199 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
6200 StreamParams stream_params = CreateSimStreamParams("cname", ssrcs);
6201 FakeVideoSendStream* fake_video_send_stream = AddSendStream(stream_params);
6202 uint32_t primary_ssrc = stream_params.first_ssrc();
6203
Niels Möller805a27e2019-01-21 12:21:27 +01006204 // Using the FrameForwarder, we manually send a full size
Tommi85959932018-02-07 19:26:06 +01006205 // frame. This allows us to test that ReconfigureEncoder is called
6206 // appropriately.
Niels Möller805a27e2019-01-21 12:21:27 +01006207 webrtc::test::FrameForwarder frame_forwarder;
Seth Hampson8234ead2018-02-02 15:16:24 -08006208 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006209 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, &options, &frame_forwarder));
Seth Hampson8234ead2018-02-02 15:16:24 -08006210 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006211 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame(
6212 1920, 1080, webrtc::VideoRotation::kVideoRotation_0,
6213 rtc::kNumMicrosecsPerSec / 30));
Seth Hampson8234ead2018-02-02 15:16:24 -08006214
6215 // Check that all encodings are initially active.
6216 webrtc::RtpParameters parameters =
6217 channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02006218 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006219 EXPECT_TRUE(parameters.encodings[0].active);
6220 EXPECT_TRUE(parameters.encodings[1].active);
6221 EXPECT_TRUE(parameters.encodings[2].active);
6222 EXPECT_TRUE(fake_video_send_stream->IsSending());
6223
6224 // Only turn on only the middle stream.
6225 parameters.encodings[0].active = false;
6226 parameters.encodings[1].active = true;
6227 parameters.encodings[2].active = false;
6228 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
6229 // Verify that the active fields are set on the VideoChannel.
6230 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02006231 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006232 EXPECT_FALSE(parameters.encodings[0].active);
6233 EXPECT_TRUE(parameters.encodings[1].active);
6234 EXPECT_FALSE(parameters.encodings[2].active);
6235 // Check that the VideoSendStream is updated appropriately. This means its
6236 // send state was updated and it was reconfigured.
6237 EXPECT_TRUE(fake_video_send_stream->IsSending());
6238 std::vector<webrtc::VideoStream> simulcast_streams =
6239 fake_video_send_stream->GetVideoStreams();
Åsa Persson31cb8f92018-06-27 10:44:56 +02006240 EXPECT_EQ(kNumSimulcastStreams, simulcast_streams.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006241 EXPECT_FALSE(simulcast_streams[0].active);
6242 EXPECT_TRUE(simulcast_streams[1].active);
6243 EXPECT_FALSE(simulcast_streams[2].active);
6244
6245 // Turn off all streams.
6246 parameters.encodings[0].active = false;
6247 parameters.encodings[1].active = false;
6248 parameters.encodings[2].active = false;
6249 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
6250 // Verify that the active fields are set on the VideoChannel.
6251 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02006252 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006253 EXPECT_FALSE(parameters.encodings[0].active);
6254 EXPECT_FALSE(parameters.encodings[1].active);
6255 EXPECT_FALSE(parameters.encodings[2].active);
6256 // Check that the VideoSendStream is off.
6257 EXPECT_FALSE(fake_video_send_stream->IsSending());
6258 simulcast_streams = fake_video_send_stream->GetVideoStreams();
Åsa Persson31cb8f92018-06-27 10:44:56 +02006259 EXPECT_EQ(kNumSimulcastStreams, simulcast_streams.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006260 EXPECT_FALSE(simulcast_streams[0].active);
6261 EXPECT_FALSE(simulcast_streams[1].active);
6262 EXPECT_FALSE(simulcast_streams[2].active);
6263
Niels Möllerff40b142018-04-09 08:49:14 +02006264 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, nullptr, nullptr));
Seth Hampson8234ead2018-02-02 15:16:24 -08006265}
6266
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006267// Test that if a stream is reconfigured (due to a codec change or other
6268// change) while its encoding is still inactive, it doesn't start sending.
eladalonf1841382017-06-12 01:16:46 -07006269TEST_F(WebRtcVideoChannelTest,
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006270 InactiveStreamDoesntStartSendingWhenReconfigured) {
6271 // Set an initial codec list, which will be modified later.
6272 cricket::VideoSendParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08006273 parameters1.codecs.push_back(GetEngineCodec("VP8"));
6274 parameters1.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006275 EXPECT_TRUE(channel_->SetSendParameters(parameters1));
6276
6277 FakeVideoSendStream* stream = AddSendStream();
6278 EXPECT_TRUE(channel_->SetSend(true));
6279 EXPECT_TRUE(stream->IsSending());
6280
6281 // Get current parameters and change "active" to false.
6282 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6283 ASSERT_EQ(1u, parameters.encodings.size());
6284 ASSERT_TRUE(parameters.encodings[0].active);
6285 parameters.encodings[0].active = false;
6286 EXPECT_EQ(1u, GetFakeSendStreams().size());
6287 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
Zach Steinba37b4b2018-01-23 15:02:36 -08006288 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006289 EXPECT_FALSE(stream->IsSending());
6290
6291 // Reorder the codec list, causing the stream to be reconfigured.
6292 cricket::VideoSendParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08006293 parameters2.codecs.push_back(GetEngineCodec("VP9"));
6294 parameters2.codecs.push_back(GetEngineCodec("VP8"));
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006295 EXPECT_TRUE(channel_->SetSendParameters(parameters2));
6296 auto new_streams = GetFakeSendStreams();
6297 // Assert that a new underlying stream was created due to the codec change.
6298 // Otherwise, this test isn't testing what it set out to test.
6299 EXPECT_EQ(1u, GetFakeSendStreams().size());
6300 EXPECT_EQ(2, fake_call_->GetNumCreatedSendStreams());
6301
6302 // Verify that we still are not sending anything, due to the inactive
6303 // encoding.
6304 EXPECT_FALSE(new_streams[0]->IsSending());
6305}
6306
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006307// Test that GetRtpSendParameters returns the currently configured codecs.
eladalonf1841382017-06-12 01:16:46 -07006308TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersCodecs) {
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006309 AddSendStream();
6310 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006311 parameters.codecs.push_back(GetEngineCodec("VP8"));
6312 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006313 EXPECT_TRUE(channel_->SetSendParameters(parameters));
6314
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006315 webrtc::RtpParameters rtp_parameters =
6316 channel_->GetRtpSendParameters(last_ssrc_);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006317 ASSERT_EQ(2u, rtp_parameters.codecs.size());
magjed509e4fe2016-11-18 01:34:11 -08006318 EXPECT_EQ(GetEngineCodec("VP8").ToCodecParameters(),
6319 rtp_parameters.codecs[0]);
6320 EXPECT_EQ(GetEngineCodec("VP9").ToCodecParameters(),
6321 rtp_parameters.codecs[1]);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006322}
6323
Florent Castellidacec712018-05-24 16:24:21 +02006324// Test that GetRtpSendParameters returns the currently configured RTCP CNAME.
6325TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersRtcpCname) {
6326 StreamParams params = StreamParams::CreateLegacy(kSsrc);
6327 params.cname = "rtcpcname";
6328 AddSendStream(params);
6329
6330 webrtc::RtpParameters rtp_parameters = channel_->GetRtpSendParameters(kSsrc);
6331 EXPECT_STREQ("rtcpcname", rtp_parameters.rtcp.cname.c_str());
6332}
6333
deadbeeffb2aced2017-01-06 23:05:37 -08006334// Test that RtpParameters for send stream has one encoding and it has
6335// the correct SSRC.
eladalonf1841382017-06-12 01:16:46 -07006336TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersSsrc) {
deadbeeffb2aced2017-01-06 23:05:37 -08006337 AddSendStream();
6338
6339 webrtc::RtpParameters rtp_parameters =
6340 channel_->GetRtpSendParameters(last_ssrc_);
6341 ASSERT_EQ(1u, rtp_parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01006342 EXPECT_EQ(last_ssrc_, rtp_parameters.encodings[0].ssrc);
deadbeeffb2aced2017-01-06 23:05:37 -08006343}
6344
Florent Castelliabe301f2018-06-12 18:33:49 +02006345TEST_F(WebRtcVideoChannelTest, DetectRtpSendParameterHeaderExtensionsChange) {
6346 AddSendStream();
6347
6348 webrtc::RtpParameters rtp_parameters =
6349 channel_->GetRtpSendParameters(last_ssrc_);
6350 rtp_parameters.header_extensions.emplace_back();
6351
6352 EXPECT_NE(0u, rtp_parameters.header_extensions.size());
6353
6354 webrtc::RTCError result =
6355 channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6356 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION, result.type());
6357}
6358
Florent Castelli87b3c512018-07-18 16:00:28 +02006359TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersDegradationPreference) {
6360 AddSendStream();
6361
Niels Möller805a27e2019-01-21 12:21:27 +01006362 webrtc::test::FrameForwarder frame_forwarder;
6363 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Florent Castelli87b3c512018-07-18 16:00:28 +02006364
6365 webrtc::RtpParameters rtp_parameters =
6366 channel_->GetRtpSendParameters(last_ssrc_);
6367 EXPECT_EQ(rtp_parameters.degradation_preference,
6368 webrtc::DegradationPreference::BALANCED);
6369 rtp_parameters.degradation_preference =
6370 webrtc::DegradationPreference::MAINTAIN_FRAMERATE;
6371
6372 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters).ok());
6373
6374 webrtc::RtpParameters updated_rtp_parameters =
6375 channel_->GetRtpSendParameters(last_ssrc_);
6376 EXPECT_EQ(updated_rtp_parameters.degradation_preference,
6377 webrtc::DegradationPreference::MAINTAIN_FRAMERATE);
6378
6379 // Remove the source since it will be destroyed before the channel
6380 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6381}
6382
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006383// Test that if we set/get parameters multiple times, we get the same results.
eladalonf1841382017-06-12 01:16:46 -07006384TEST_F(WebRtcVideoChannelTest, SetAndGetRtpSendParameters) {
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006385 AddSendStream();
6386 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006387 parameters.codecs.push_back(GetEngineCodec("VP8"));
6388 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006389 EXPECT_TRUE(channel_->SetSendParameters(parameters));
6390
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006391 webrtc::RtpParameters initial_params =
6392 channel_->GetRtpSendParameters(last_ssrc_);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006393
6394 // We should be able to set the params we just got.
Zach Steinba37b4b2018-01-23 15:02:36 -08006395 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, initial_params).ok());
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006396
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006397 // ... And this shouldn't change the params returned by GetRtpSendParameters.
6398 EXPECT_EQ(initial_params, channel_->GetRtpSendParameters(last_ssrc_));
6399}
6400
6401// Test that GetRtpReceiveParameters returns the currently configured codecs.
eladalonf1841382017-06-12 01:16:46 -07006402TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersCodecs) {
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006403 AddRecvStream();
6404 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006405 parameters.codecs.push_back(GetEngineCodec("VP8"));
6406 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006407 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6408
6409 webrtc::RtpParameters rtp_parameters =
6410 channel_->GetRtpReceiveParameters(last_ssrc_);
6411 ASSERT_EQ(2u, rtp_parameters.codecs.size());
magjed509e4fe2016-11-18 01:34:11 -08006412 EXPECT_EQ(GetEngineCodec("VP8").ToCodecParameters(),
6413 rtp_parameters.codecs[0]);
6414 EXPECT_EQ(GetEngineCodec("VP9").ToCodecParameters(),
6415 rtp_parameters.codecs[1]);
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006416}
6417
johan073ece42016-08-26 02:59:47 -07006418#if defined(WEBRTC_USE_H264)
eladalonf1841382017-06-12 01:16:46 -07006419TEST_F(WebRtcVideoChannelTest, GetRtpReceiveFmtpSprop) {
johan073ece42016-08-26 02:59:47 -07006420#else
eladalonf1841382017-06-12 01:16:46 -07006421TEST_F(WebRtcVideoChannelTest, DISABLED_GetRtpReceiveFmtpSprop) {
johan073ece42016-08-26 02:59:47 -07006422#endif
johan3859c892016-08-05 09:19:25 -07006423 cricket::VideoRecvParameters parameters;
perkj26752742016-10-24 01:21:16 -07006424 cricket::VideoCodec kH264sprop1(101, "H264");
magjed5dfac562016-11-25 03:56:37 -08006425 kH264sprop1.SetParam(kH264FmtpSpropParameterSets, "uvw");
johan3859c892016-08-05 09:19:25 -07006426 parameters.codecs.push_back(kH264sprop1);
perkj26752742016-10-24 01:21:16 -07006427 cricket::VideoCodec kH264sprop2(102, "H264");
magjed5dfac562016-11-25 03:56:37 -08006428 kH264sprop2.SetParam(kH264FmtpSpropParameterSets, "xyz");
johan3859c892016-08-05 09:19:25 -07006429 parameters.codecs.push_back(kH264sprop2);
6430 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6431
6432 FakeVideoReceiveStream* recv_stream = AddRecvStream();
6433 const webrtc::VideoReceiveStream::Config& cfg = recv_stream->GetConfig();
6434 webrtc::RtpParameters rtp_parameters =
6435 channel_->GetRtpReceiveParameters(last_ssrc_);
6436 ASSERT_EQ(2u, rtp_parameters.codecs.size());
6437 EXPECT_EQ(kH264sprop1.ToCodecParameters(), rtp_parameters.codecs[0]);
6438 ASSERT_EQ(2u, cfg.decoders.size());
6439 EXPECT_EQ(101, cfg.decoders[0].payload_type);
Niels Möllercb7e1d22018-09-11 15:56:04 +02006440 EXPECT_EQ("H264", cfg.decoders[0].video_format.name);
magjed5dfac562016-11-25 03:56:37 -08006441 const auto it0 =
Niels Möllercb7e1d22018-09-11 15:56:04 +02006442 cfg.decoders[0].video_format.parameters.find(kH264FmtpSpropParameterSets);
6443 ASSERT_TRUE(it0 != cfg.decoders[0].video_format.parameters.end());
magjed5dfac562016-11-25 03:56:37 -08006444 EXPECT_EQ("uvw", it0->second);
johan3859c892016-08-05 09:19:25 -07006445
6446 EXPECT_EQ(102, cfg.decoders[1].payload_type);
Niels Möllercb7e1d22018-09-11 15:56:04 +02006447 EXPECT_EQ("H264", cfg.decoders[1].video_format.name);
magjed5dfac562016-11-25 03:56:37 -08006448 const auto it1 =
Niels Möllercb7e1d22018-09-11 15:56:04 +02006449 cfg.decoders[1].video_format.parameters.find(kH264FmtpSpropParameterSets);
6450 ASSERT_TRUE(it1 != cfg.decoders[1].video_format.parameters.end());
magjed5dfac562016-11-25 03:56:37 -08006451 EXPECT_EQ("xyz", it1->second);
johan3859c892016-08-05 09:19:25 -07006452}
6453
sakal1fd95952016-06-22 00:46:15 -07006454// Test that RtpParameters for receive stream has one encoding and it has
6455// the correct SSRC.
eladalonf1841382017-06-12 01:16:46 -07006456TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersSsrc) {
sakal1fd95952016-06-22 00:46:15 -07006457 AddRecvStream();
6458
6459 webrtc::RtpParameters rtp_parameters =
6460 channel_->GetRtpReceiveParameters(last_ssrc_);
6461 ASSERT_EQ(1u, rtp_parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01006462 EXPECT_EQ(last_ssrc_, rtp_parameters.encodings[0].ssrc);
sakal1fd95952016-06-22 00:46:15 -07006463}
6464
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006465// Test that if we set/get parameters multiple times, we get the same results.
eladalonf1841382017-06-12 01:16:46 -07006466TEST_F(WebRtcVideoChannelTest, SetAndGetRtpReceiveParameters) {
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006467 AddRecvStream();
6468 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006469 parameters.codecs.push_back(GetEngineCodec("VP8"));
6470 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006471 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6472
6473 webrtc::RtpParameters initial_params =
6474 channel_->GetRtpReceiveParameters(last_ssrc_);
6475
6476 // We should be able to set the params we just got.
6477 EXPECT_TRUE(channel_->SetRtpReceiveParameters(last_ssrc_, initial_params));
6478
6479 // ... And this shouldn't change the params returned by
6480 // GetRtpReceiveParameters.
6481 EXPECT_EQ(initial_params, channel_->GetRtpReceiveParameters(last_ssrc_));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006482}
6483
deadbeef3bc15102017-04-20 19:25:07 -07006484// Test that GetRtpReceiveParameters returns parameters correctly when SSRCs
6485// aren't signaled. It should always return an empty "RtpEncodingParameters",
6486// even after a packet is received and the unsignaled SSRC is known.
eladalonf1841382017-06-12 01:16:46 -07006487TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersWithUnsignaledSsrc) {
deadbeef3bc15102017-04-20 19:25:07 -07006488 // Call necessary methods to configure receiving a default stream as
6489 // soon as it arrives.
6490 cricket::VideoRecvParameters parameters;
6491 parameters.codecs.push_back(GetEngineCodec("VP8"));
6492 parameters.codecs.push_back(GetEngineCodec("VP9"));
6493 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6494
6495 // Call GetRtpReceiveParameters before configured to receive an unsignaled
6496 // stream. Should return nothing.
6497 EXPECT_EQ(webrtc::RtpParameters(), channel_->GetRtpReceiveParameters(0));
6498
6499 // Set a sink for an unsignaled stream.
6500 cricket::FakeVideoRenderer renderer;
6501 // Value of "0" means "unsignaled stream".
6502 EXPECT_TRUE(channel_->SetSink(0, &renderer));
6503
6504 // Call GetRtpReceiveParameters before the SSRC is known. Value of "0"
6505 // in this method means "unsignaled stream".
6506 webrtc::RtpParameters rtp_parameters = channel_->GetRtpReceiveParameters(0);
6507 ASSERT_EQ(1u, rtp_parameters.encodings.size());
6508 EXPECT_FALSE(rtp_parameters.encodings[0].ssrc);
6509
6510 // Receive VP8 packet.
6511 uint8_t data[kMinRtpPacketLen];
6512 cricket::RtpHeader rtpHeader;
6513 rtpHeader.payload_type = GetEngineCodec("VP8").id;
6514 rtpHeader.seq_num = rtpHeader.timestamp = 0;
6515 rtpHeader.ssrc = kIncomingUnsignalledSsrc;
6516 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
6517 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
Niels Möllere6933812018-11-05 13:01:41 +01006518 channel_->OnPacketReceived(&packet, /* packet_time_us */ -1);
deadbeef3bc15102017-04-20 19:25:07 -07006519
6520 // The |ssrc| member should still be unset.
6521 rtp_parameters = channel_->GetRtpReceiveParameters(0);
6522 ASSERT_EQ(1u, rtp_parameters.encodings.size());
6523 EXPECT_FALSE(rtp_parameters.encodings[0].ssrc);
6524}
6525
eladalonf1841382017-06-12 01:16:46 -07006526void WebRtcVideoChannelTest::TestReceiverLocalSsrcConfiguration(
Peter Boström3548dd22015-05-22 18:48:36 +02006527 bool receiver_first) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02006528 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boström3548dd22015-05-22 18:48:36 +02006529
6530 const uint32_t kSenderSsrc = 0xC0FFEE;
Peter Boströmdfa28152015-10-21 17:21:10 +02006531 const uint32_t kSecondSenderSsrc = 0xBADCAFE;
Peter Boström3548dd22015-05-22 18:48:36 +02006532 const uint32_t kReceiverSsrc = 0x4711;
Peter Boströmdfa28152015-10-21 17:21:10 +02006533 const uint32_t kExpectedDefaultReceiverSsrc = 1;
Peter Boström3548dd22015-05-22 18:48:36 +02006534
6535 if (receiver_first) {
6536 AddRecvStream(StreamParams::CreateLegacy(kReceiverSsrc));
6537 std::vector<FakeVideoReceiveStream*> receive_streams =
6538 fake_call_->GetVideoReceiveStreams();
6539 ASSERT_EQ(1u, receive_streams.size());
Peter Boströmdfa28152015-10-21 17:21:10 +02006540 // Default local SSRC when we have no sender.
6541 EXPECT_EQ(kExpectedDefaultReceiverSsrc,
6542 receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boström3548dd22015-05-22 18:48:36 +02006543 }
6544 AddSendStream(StreamParams::CreateLegacy(kSenderSsrc));
6545 if (!receiver_first)
6546 AddRecvStream(StreamParams::CreateLegacy(kReceiverSsrc));
6547 std::vector<FakeVideoReceiveStream*> receive_streams =
6548 fake_call_->GetVideoReceiveStreams();
6549 ASSERT_EQ(1u, receive_streams.size());
6550 EXPECT_EQ(kSenderSsrc, receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boströmdfa28152015-10-21 17:21:10 +02006551
6552 // Removing first sender should fall back to another (in this case the second)
6553 // local send stream's SSRC.
6554 AddSendStream(StreamParams::CreateLegacy(kSecondSenderSsrc));
6555 ASSERT_TRUE(channel_->RemoveSendStream(kSenderSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02006556 receive_streams = fake_call_->GetVideoReceiveStreams();
Peter Boströmdfa28152015-10-21 17:21:10 +02006557 ASSERT_EQ(1u, receive_streams.size());
6558 EXPECT_EQ(kSecondSenderSsrc, receive_streams[0]->GetConfig().rtp.local_ssrc);
6559
6560 // Removing the last sender should fall back to default local SSRC.
6561 ASSERT_TRUE(channel_->RemoveSendStream(kSecondSenderSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02006562 receive_streams = fake_call_->GetVideoReceiveStreams();
Peter Boströmdfa28152015-10-21 17:21:10 +02006563 ASSERT_EQ(1u, receive_streams.size());
6564 EXPECT_EQ(kExpectedDefaultReceiverSsrc,
6565 receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boström3548dd22015-05-22 18:48:36 +02006566}
6567
eladalonf1841382017-06-12 01:16:46 -07006568TEST_F(WebRtcVideoChannelTest, ConfiguresLocalSsrc) {
Peter Boström3548dd22015-05-22 18:48:36 +02006569 TestReceiverLocalSsrcConfiguration(false);
6570}
6571
eladalonf1841382017-06-12 01:16:46 -07006572TEST_F(WebRtcVideoChannelTest, ConfiguresLocalSsrcOnExistingReceivers) {
Peter Boström3548dd22015-05-22 18:48:36 +02006573 TestReceiverLocalSsrcConfiguration(true);
6574}
6575
eladalonf1841382017-06-12 01:16:46 -07006576class WebRtcVideoChannelSimulcastTest : public testing::Test {
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006577 public:
eladalonf1841382017-06-12 01:16:46 -07006578 WebRtcVideoChannelSimulcastTest()
Sebastian Jansson8f83b422018-02-21 13:07:13 +01006579 : fake_call_(),
Magnus Jedvert02e7a192017-09-23 17:21:32 +02006580 encoder_factory_(new cricket::FakeWebRtcVideoEncoderFactory),
6581 decoder_factory_(new cricket::FakeWebRtcVideoDecoderFactory),
Jiawei Ouc2ebe212018-11-08 10:02:56 -08006582 mock_rate_allocator_factory_(
6583 new webrtc::MockVideoBitrateAllocatorFactory),
Anders Carlsson67537952018-05-03 11:28:29 +02006584 engine_(std::unique_ptr<cricket::FakeWebRtcVideoEncoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +02006585 encoder_factory_),
Anders Carlsson67537952018-05-03 11:28:29 +02006586 std::unique_ptr<cricket::FakeWebRtcVideoDecoderFactory>(
Jiawei Ouc2ebe212018-11-08 10:02:56 -08006587 decoder_factory_),
6588 std::unique_ptr<webrtc::VideoBitrateAllocatorFactory>(
6589 mock_rate_allocator_factory_)),
magjed2475ae22017-09-12 04:42:15 -07006590 last_ssrc_(0) {}
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006591
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00006592 void SetUp() override {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02006593 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson84848f22018-11-16 10:40:36 +01006594 channel_.reset(engine_.CreateMediaChannel(&fake_call_, GetMediaConfig(),
6595 VideoOptions(),
6596 webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08006597 channel_->OnReadyToSend(true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006598 last_ssrc_ = 123;
6599 }
6600
6601 protected:
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006602 void VerifySimulcastSettings(const VideoCodec& codec,
perkj26752742016-10-24 01:21:16 -07006603 int capture_width,
6604 int capture_height,
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006605 size_t num_configured_streams,
sprang429600d2017-01-26 06:12:26 -08006606 size_t expected_num_streams,
6607 bool screenshare,
6608 bool conference_mode) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02006609 cricket::VideoSendParameters parameters;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02006610 parameters.codecs.push_back(codec);
sprang429600d2017-01-26 06:12:26 -08006611 parameters.conference_mode = conference_mode;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02006612 ASSERT_TRUE(channel_->SetSendParameters(parameters));
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006613
Peter Boström0c4e06b2015-10-07 12:23:21 +02006614 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
henrikg91d6ede2015-09-17 00:24:34 -07006615 RTC_DCHECK(num_configured_streams <= ssrcs.size());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006616 ssrcs.resize(num_configured_streams);
6617
sprangf24a0642017-02-28 13:23:26 -08006618 AddSendStream(CreateSimStreamParams("cname", ssrcs));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00006619 // Send a full-size frame to trigger a stream reconfiguration to use all
6620 // expected simulcast layers.
Niels Möller805a27e2019-01-21 12:21:27 +01006621 webrtc::test::FrameForwarder frame_forwarder;
6622 cricket::FakeFrameSource frame_source(capture_width, capture_height,
6623 rtc::kNumMicrosecsPerSec / 30);
6624
sprangf24a0642017-02-28 13:23:26 -08006625 VideoOptions options;
6626 if (screenshare)
Oskar Sundbom78807582017-11-16 11:09:55 +01006627 options.is_screencast = screenshare;
Niels Möller805a27e2019-01-21 12:21:27 +01006628 EXPECT_TRUE(
6629 channel_->SetVideoSend(ssrcs.front(), &options, &frame_forwarder));
sprangf24a0642017-02-28 13:23:26 -08006630 // Fetch the latest stream since SetVideoSend() may recreate it if the
6631 // screen content setting is changed.
6632 FakeVideoSendStream* stream = fake_call_.GetVideoSendStreams().front();
pbos@webrtc.org86196c42015-02-16 21:02:00 +00006633 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006634 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006635
Zach Stein3ca452b2018-01-18 10:01:24 -08006636 auto rtp_parameters = channel_->GetRtpSendParameters(kSsrcs3[0]);
6637 EXPECT_EQ(num_configured_streams, rtp_parameters.encodings.size());
6638
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006639 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6640 ASSERT_EQ(expected_num_streams, video_streams.size());
6641
sprang429600d2017-01-26 06:12:26 -08006642 std::vector<webrtc::VideoStream> expected_streams;
6643 if (conference_mode) {
6644 expected_streams = GetSimulcastConfig(
6645 num_configured_streams, capture_width, capture_height, 0,
Seth Hampson24722b32017-12-22 09:36:42 -08006646 webrtc::kDefaultBitratePriority, kDefaultQpMax,
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +02006647 kDefaultVideoMaxFramerate, screenshare, true);
sprang3ebabf12017-02-16 07:35:22 -08006648 if (screenshare) {
6649 for (const webrtc::VideoStream& stream : expected_streams) {
6650 // Never scale screen content.
Danil Chapovalov350531e2018-06-08 11:04:04 +00006651 EXPECT_EQ(stream.width, rtc::checked_cast<size_t>(capture_width));
6652 EXPECT_EQ(stream.height, rtc::checked_cast<size_t>(capture_height));
sprang3ebabf12017-02-16 07:35:22 -08006653 }
6654 }
sprang429600d2017-01-26 06:12:26 -08006655 } else {
6656 webrtc::VideoStream stream;
6657 stream.width = capture_width;
6658 stream.height = capture_height;
6659 stream.max_framerate = kDefaultVideoMaxFramerate;
Åsa Persson45bbc8a2017-11-13 10:16:47 +01006660 stream.min_bitrate_bps = cricket::kMinVideoBitrateBps;
sprang429600d2017-01-26 06:12:26 -08006661 stream.target_bitrate_bps = stream.max_bitrate_bps =
Åsa Perssonbdee46d2018-06-25 11:28:06 +02006662 GetMaxDefaultBitrateBps(capture_width, capture_height);
sprang429600d2017-01-26 06:12:26 -08006663 stream.max_qp = kDefaultQpMax;
6664 expected_streams.push_back(stream);
6665 }
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006666
6667 ASSERT_EQ(expected_streams.size(), video_streams.size());
6668
6669 size_t num_streams = video_streams.size();
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00006670 int total_max_bitrate_bps = 0;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006671 for (size_t i = 0; i < num_streams; ++i) {
6672 EXPECT_EQ(expected_streams[i].width, video_streams[i].width);
6673 EXPECT_EQ(expected_streams[i].height, video_streams[i].height);
6674
6675 EXPECT_GT(video_streams[i].max_framerate, 0);
6676 EXPECT_EQ(expected_streams[i].max_framerate,
6677 video_streams[i].max_framerate);
6678
6679 EXPECT_GT(video_streams[i].min_bitrate_bps, 0);
6680 EXPECT_EQ(expected_streams[i].min_bitrate_bps,
6681 video_streams[i].min_bitrate_bps);
6682
6683 EXPECT_GT(video_streams[i].target_bitrate_bps, 0);
6684 EXPECT_EQ(expected_streams[i].target_bitrate_bps,
6685 video_streams[i].target_bitrate_bps);
6686
6687 EXPECT_GT(video_streams[i].max_bitrate_bps, 0);
6688 EXPECT_EQ(expected_streams[i].max_bitrate_bps,
6689 video_streams[i].max_bitrate_bps);
6690
6691 EXPECT_GT(video_streams[i].max_qp, 0);
6692 EXPECT_EQ(expected_streams[i].max_qp, video_streams[i].max_qp);
6693
Sergey Silkina796a7e2018-03-01 15:11:29 +01006694 EXPECT_EQ(conference_mode,
6695 expected_streams[i].num_temporal_layers.has_value());
6696
6697 if (conference_mode) {
6698 EXPECT_EQ(expected_streams[i].num_temporal_layers,
6699 video_streams[i].num_temporal_layers);
6700 }
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00006701
6702 if (i == num_streams - 1) {
6703 total_max_bitrate_bps += video_streams[i].max_bitrate_bps;
6704 } else {
6705 total_max_bitrate_bps += video_streams[i].target_bitrate_bps;
6706 }
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006707 }
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00006708
Niels Möllerff40b142018-04-09 08:49:14 +02006709 EXPECT_TRUE(channel_->SetVideoSend(ssrcs.front(), nullptr, nullptr));
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006710 }
6711
6712 FakeVideoSendStream* AddSendStream() {
6713 return AddSendStream(StreamParams::CreateLegacy(last_ssrc_++));
6714 }
6715
6716 FakeVideoSendStream* AddSendStream(const StreamParams& sp) {
Yves Gerey665174f2018-06-19 15:03:05 +02006717 size_t num_streams = fake_call_.GetVideoSendStreams().size();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006718 EXPECT_TRUE(channel_->AddSendStream(sp));
6719 std::vector<FakeVideoSendStream*> streams =
Fredrik Solenberg709ed672015-09-15 12:26:33 +02006720 fake_call_.GetVideoSendStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006721 EXPECT_EQ(num_streams + 1, streams.size());
6722 return streams[streams.size() - 1];
6723 }
6724
6725 std::vector<FakeVideoSendStream*> GetFakeSendStreams() {
Fredrik Solenberg709ed672015-09-15 12:26:33 +02006726 return fake_call_.GetVideoSendStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006727 }
6728
6729 FakeVideoReceiveStream* AddRecvStream() {
6730 return AddRecvStream(StreamParams::CreateLegacy(last_ssrc_++));
6731 }
6732
6733 FakeVideoReceiveStream* AddRecvStream(const StreamParams& sp) {
Yves Gerey665174f2018-06-19 15:03:05 +02006734 size_t num_streams = fake_call_.GetVideoReceiveStreams().size();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006735 EXPECT_TRUE(channel_->AddRecvStream(sp));
6736 std::vector<FakeVideoReceiveStream*> streams =
Fredrik Solenberg709ed672015-09-15 12:26:33 +02006737 fake_call_.GetVideoReceiveStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006738 EXPECT_EQ(num_streams + 1, streams.size());
6739 return streams[streams.size() - 1];
6740 }
6741
skvlad11a9cbf2016-10-07 11:53:05 -07006742 webrtc::RtcEventLogNullImpl event_log_;
Fredrik Solenberg709ed672015-09-15 12:26:33 +02006743 FakeCall fake_call_;
Magnus Jedvert02e7a192017-09-23 17:21:32 +02006744 cricket::FakeWebRtcVideoEncoderFactory* encoder_factory_;
6745 cricket::FakeWebRtcVideoDecoderFactory* decoder_factory_;
Jiawei Ouc2ebe212018-11-08 10:02:56 -08006746 webrtc::MockVideoBitrateAllocatorFactory* mock_rate_allocator_factory_;
eladalonf1841382017-06-12 01:16:46 -07006747 WebRtcVideoEngine engine_;
kwiberg686a8ef2016-02-26 03:00:35 -08006748 std::unique_ptr<VideoMediaChannel> channel_;
Peter Boström0c4e06b2015-10-07 12:23:21 +02006749 uint32_t last_ssrc_;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006750};
6751
eladalonf1841382017-06-12 01:16:46 -07006752TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWith2SimulcastStreams) {
sprang429600d2017-01-26 06:12:26 -08006753 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 640, 360, 2, 2, false,
6754 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006755}
6756
eladalonf1841382017-06-12 01:16:46 -07006757TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWith3SimulcastStreams) {
sprang429600d2017-01-26 06:12:26 -08006758 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 3, false,
6759 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006760}
6761
6762// Test that we normalize send codec format size in simulcast.
eladalonf1841382017-06-12 01:16:46 -07006763TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWithOddSizeInSimulcast) {
sprang429600d2017-01-26 06:12:26 -08006764 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 541, 271, 2, 2, false,
6765 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006766}
sprang429600d2017-01-26 06:12:26 -08006767
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02006768TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsForScreenshare) {
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02006769 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
6770 false);
6771}
6772
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02006773TEST_F(WebRtcVideoChannelSimulcastTest,
6774 SetSendCodecsForConferenceModeScreenshare) {
Erik Språng72e52ee2018-11-29 11:41:53 +01006775 webrtc::test::ScopedFieldTrials field_trials(
6776 "WebRTC-SimulcastScreenshare/Disabled/");
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02006777 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
6778 true);
6779}
6780
eladalonf1841382017-06-12 01:16:46 -07006781TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsForSimulcastScreenshare) {
sprang429600d2017-01-26 06:12:26 -08006782 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 2, true,
6783 true);
6784}
6785
eladalonf1841382017-06-12 01:16:46 -07006786TEST_F(WebRtcVideoChannelSimulcastTest,
sprangfe627f32017-03-29 08:24:59 -07006787 NoSimulcastScreenshareWithoutConference) {
sprangfe627f32017-03-29 08:24:59 -07006788 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
6789 false);
6790}
6791
Yves Gereyb6a89422018-10-08 10:08:32 +02006792class WebRtcVideoFakeClock {
Jonas Oreland49ac5952018-09-26 16:04:32 +02006793 public:
Yves Gereyb6a89422018-10-08 10:08:32 +02006794 WebRtcVideoFakeClock() {
Jonas Oreland49ac5952018-09-26 16:04:32 +02006795 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(1)); // avoid time=0
6796 }
6797 rtc::ScopedFakeClock fake_clock_;
6798};
6799
Yves Gereyb6a89422018-10-08 10:08:32 +02006800// The fake clock needs to be initialized before the call, and not
6801// destroyed until after all threads spawned by the test have been stopped.
6802// This mixin ensures that.
6803class WebRtcVideoChannelTestWithClock : public WebRtcVideoFakeClock,
6804 public WebRtcVideoChannelBaseTest {};
6805
Jonas Oreland49ac5952018-09-26 16:04:32 +02006806TEST_F(WebRtcVideoChannelTestWithClock, GetSources) {
6807 uint8_t data1[] = {0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
6808 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
6809
6810 EXPECT_EQ(0u, channel_->GetSources(kSsrc).size());
6811
6812 rtc::CopyOnWriteBuffer packet1(data1, sizeof(data1));
6813 rtc::SetBE32(packet1.data() + 8, kSsrc);
6814 channel_->SetSink(kDefaultReceiveSsrc, NULL);
6815 EXPECT_TRUE(SetDefaultCodec());
6816 EXPECT_TRUE(SetSend(true));
6817 EXPECT_EQ(0, renderer_.num_rendered_frames());
Niels Möller29e13fd2018-12-17 12:35:30 +01006818 channel_->OnPacketReceived(&packet1, /*packet_time_us=*/-1);
Jonas Oreland49ac5952018-09-26 16:04:32 +02006819
6820 std::vector<webrtc::RtpSource> sources = channel_->GetSources(kSsrc);
6821 EXPECT_EQ(1u, sources.size());
6822 EXPECT_EQ(webrtc::RtpSourceType::SSRC, sources[0].source_type());
6823 int64_t timestamp1 = sources[0].timestamp_ms();
6824
6825 // a new packet.
6826 int64_t timeDeltaMs = 1;
6827 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(timeDeltaMs));
Niels Möller29e13fd2018-12-17 12:35:30 +01006828 channel_->OnPacketReceived(&packet1, /*packet_time_us=*/-1);
Jonas Oreland49ac5952018-09-26 16:04:32 +02006829 int64_t timestamp2 = channel_->GetSources(kSsrc)[0].timestamp_ms();
6830 EXPECT_EQ(timestamp2, timestamp1 + timeDeltaMs);
6831
6832 // It only keeps 10s of history.
6833 fake_clock_.AdvanceTime(webrtc::TimeDelta::seconds(10));
6834 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(1));
6835 EXPECT_EQ(0u, channel_->GetSources(kSsrc).size());
6836}
6837
6838TEST_F(WebRtcVideoChannelTestWithClock, GetContributingSources) {
6839 uint8_t data1[] = {0x81, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
6840 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
6841
6842 uint32_t kCsrc = 4321u;
6843 EXPECT_EQ(0u, channel_->GetSources(kSsrc).size());
6844 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
6845
6846 rtc::CopyOnWriteBuffer packet1(data1, sizeof(data1));
6847 rtc::SetBE32(packet1.data() + 8, kSsrc);
6848 rtc::SetBE32(packet1.data() + 12, kCsrc);
6849 channel_->SetSink(kDefaultReceiveSsrc, NULL);
6850 EXPECT_TRUE(SetDefaultCodec());
6851 EXPECT_TRUE(SetSend(true));
6852 EXPECT_EQ(0, renderer_.num_rendered_frames());
Niels Möller29e13fd2018-12-17 12:35:30 +01006853 channel_->OnPacketReceived(&packet1, /*packet_time_us=*/-1);
Jonas Oreland49ac5952018-09-26 16:04:32 +02006854
6855 {
6856 ASSERT_EQ(2u, channel_->GetSources(kSsrc).size());
6857 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
6858 std::vector<webrtc::RtpSource> sources = channel_->GetSources(kSsrc);
6859 EXPECT_EQ(sources[0].timestamp_ms(), sources[1].timestamp_ms());
6860 // 1 SSRC and 1 CSRC.
Steve Anton2c9ebef2019-01-28 17:27:58 -08006861 EXPECT_EQ(1, absl::c_count_if(sources, [](const webrtc::RtpSource& source) {
6862 return source.source_type() == webrtc::RtpSourceType::SSRC;
6863 }));
6864 EXPECT_EQ(1, absl::c_count_if(sources, [](const webrtc::RtpSource& source) {
6865 return source.source_type() == webrtc::RtpSourceType::CSRC;
6866 }));
Jonas Oreland49ac5952018-09-26 16:04:32 +02006867 }
6868 int64_t timestamp1 = channel_->GetSources(kSsrc)[0].timestamp_ms();
6869
6870 // a new packet with only ssrc (i.e no csrc).
6871 uint8_t data2[] = {0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
6872 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
6873 rtc::CopyOnWriteBuffer packet2(data2, sizeof(data2));
6874 rtc::SetBE32(packet2.data() + 8, kSsrc);
6875
6876 int64_t timeDeltaMs = 1;
6877 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(timeDeltaMs));
Niels Möller29e13fd2018-12-17 12:35:30 +01006878 channel_->OnPacketReceived(&packet2, /*packet_time_us=*/-1);
Jonas Oreland49ac5952018-09-26 16:04:32 +02006879
6880 {
6881 ASSERT_EQ(2u, channel_->GetSources(kSsrc).size());
6882 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
6883 std::vector<webrtc::RtpSource> sources = channel_->GetSources(kSsrc);
6884 EXPECT_NE(sources[0].timestamp_ms(), sources[1].timestamp_ms());
6885 // 1 SSRC and 1 CSRC.
Steve Anton2c9ebef2019-01-28 17:27:58 -08006886 EXPECT_EQ(1, absl::c_count_if(sources, [](const webrtc::RtpSource& source) {
6887 return source.source_type() == webrtc::RtpSourceType::SSRC;
6888 }));
6889 EXPECT_EQ(1, absl::c_count_if(sources, [](const webrtc::RtpSource& source) {
6890 return source.source_type() == webrtc::RtpSourceType::CSRC;
6891 }));
6892 auto ssrcSource =
6893 absl::c_find_if(sources, [](const webrtc::RtpSource& source) {
Jonas Oreland49ac5952018-09-26 16:04:32 +02006894 return source.source_type() == webrtc::RtpSourceType::SSRC;
6895 });
Steve Anton2c9ebef2019-01-28 17:27:58 -08006896 auto csrcSource =
6897 absl::c_find_if(sources, [](const webrtc::RtpSource& source) {
Jonas Oreland49ac5952018-09-26 16:04:32 +02006898 return source.source_type() == webrtc::RtpSourceType::CSRC;
6899 });
6900
6901 EXPECT_EQ(ssrcSource->timestamp_ms(), timestamp1 + timeDeltaMs);
6902 EXPECT_EQ(csrcSource->timestamp_ms(), timestamp1);
6903 }
6904
6905 // It only keeps 10s of history.
6906 fake_clock_.AdvanceTime(webrtc::TimeDelta::seconds(10));
6907
6908 {
6909 ASSERT_EQ(1u, channel_->GetSources(kSsrc).size());
6910 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
6911 std::vector<webrtc::RtpSource> sources = channel_->GetSources(kSsrc);
Steve Anton2c9ebef2019-01-28 17:27:58 -08006912 EXPECT_EQ(1, absl::c_count_if(sources, [](const webrtc::RtpSource& source) {
6913 return source.source_type() == webrtc::RtpSourceType::SSRC;
6914 }));
6915 EXPECT_EQ(0, absl::c_count_if(sources, [](const webrtc::RtpSource& source) {
6916 return source.source_type() == webrtc::RtpSourceType::CSRC;
6917 }));
Jonas Oreland49ac5952018-09-26 16:04:32 +02006918 }
6919
6920 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(1));
6921 EXPECT_EQ(0u, channel_->GetSources(kSsrc).size());
6922 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
6923}
6924
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00006925} // namespace cricket