blob: 9f02e85ad03a71be2e4b60c16cc176d4ed7184e6 [file] [log] [blame]
maruel@chromium.org725f1c32011-04-01 20:24:54 +00001#!/usr/bin/env python
maruel@chromium.org3bbf2942012-01-10 16:52:06 +00002# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
6"""Enables directory-specific presubmit checks to run at upload and/or commit.
7"""
8
Raul Tambre80ee78e2019-05-06 22:41:05 +00009from __future__ import print_function
10
stip@chromium.orgf7d31f52014-01-03 20:14:46 +000011__version__ = '1.8.0'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000012
13# TODO(joi) Add caching where appropriate/needed. The API is designed to allow
14# caching (between all different invocations of presubmit scripts for a given
15# change). We should add it as our presubmit scripts start feeling slow.
16
Edward Lemura5799e32020-01-17 19:26:51 +000017import argparse
Takeshi Yoshino07a6bea2017-08-02 02:44:06 +090018import ast # Exposed through the API.
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +000019import contextlib
Yoshisato Yanagisawa406de132018-06-29 05:43:25 +000020import cpplint
dcheng091b7db2016-06-16 01:27:51 -070021import fnmatch # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000022import glob
asvitkine@chromium.org15169952011-09-27 14:30:53 +000023import inspect
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +000024import itertools
maruel@chromium.org4f6852c2012-04-20 20:39:20 +000025import json # Exposed through the API.
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +000026import logging
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000027import multiprocessing
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000028import os # Somewhat exposed through the API.
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000029import random
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000030import re # Exposed through the API.
Edward Lesmes8e282792018-04-03 18:50:29 -040031import signal
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000032import sys # Parts exposed through API.
33import tempfile # Exposed through the API.
Edward Lesmes8e282792018-04-03 18:50:29 -040034import threading
jam@chromium.org2a891dc2009-08-20 20:33:37 +000035import time
Edward Lemurde9e3ca2019-10-24 21:13:31 +000036import traceback
maruel@chromium.org1487d532009-06-06 00:22:57 +000037import unittest # Exposed through the API.
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000038from warnings import warn
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000039
40# Local imports.
maruel@chromium.org35625c72011-03-23 17:34:02 +000041import fix_encoding
Yoshisato Yanagisawa04600b42019-03-15 03:03:41 +000042import gclient_paths # Exposed through the API
43import gclient_utils
Aaron Gableb584c4f2017-04-26 16:28:08 -070044import git_footers
tandrii@chromium.org015ebae2016-04-25 19:37:22 +000045import gerrit_util
dpranke@chromium.org2a009622011-03-01 02:43:31 +000046import owners
Jochen Eisinger76f5fc62017-04-07 16:27:46 +020047import owners_finder
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000048import presubmit_canned_checks
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +000049import scm
maruel@chromium.org84f4fe32011-04-06 13:26:45 +000050import subprocess2 as subprocess # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000051
Edward Lemur16af3562019-10-17 22:11:33 +000052if sys.version_info.major == 2:
53 # TODO(1009814): Expose urllib2 only through urllib_request and urllib_error
54 import urllib2 # Exposed through the API.
55 import urlparse
56 import urllib2 as urllib_request
57 import urllib2 as urllib_error
58else:
59 import urllib.parse as urlparse
60 import urllib.request as urllib_request
61 import urllib.error as urllib_error
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000062
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000063# Ask for feedback only once in program lifetime.
64_ASKED_FOR_FEEDBACK = False
65
66
Edward Lemurecc27072020-01-06 16:42:34 +000067def time_time():
68 # Use this so that it can be mocked in tests without interfering with python
69 # system machinery.
70 return time.time()
71
72
maruel@chromium.org899e1c12011-04-07 17:03:18 +000073class PresubmitFailure(Exception):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000074 pass
75
76
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000077class CommandData(object):
Edward Lemur940c2822019-08-23 00:34:25 +000078 def __init__(self, name, cmd, kwargs, message, python3=False):
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000079 self.name = name
80 self.cmd = cmd
Edward Lesmes8e282792018-04-03 18:50:29 -040081 self.stdin = kwargs.get('stdin', None)
Edward Lemur2d6b67c2019-08-23 22:25:41 +000082 self.kwargs = kwargs.copy()
Edward Lesmes8e282792018-04-03 18:50:29 -040083 self.kwargs['stdout'] = subprocess.PIPE
84 self.kwargs['stderr'] = subprocess.STDOUT
85 self.kwargs['stdin'] = subprocess.PIPE
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000086 self.message = message
87 self.info = None
Edward Lemur940c2822019-08-23 00:34:25 +000088 self.python3 = python3
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000089
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000090
Edward Lesmes8e282792018-04-03 18:50:29 -040091# Adapted from
92# https://github.com/google/gtest-parallel/blob/master/gtest_parallel.py#L37
93#
94# An object that catches SIGINT sent to the Python process and notices
95# if processes passed to wait() die by SIGINT (we need to look for
96# both of those cases, because pressing Ctrl+C can result in either
97# the main process or one of the subprocesses getting the signal).
98#
99# Before a SIGINT is seen, wait(p) will simply call p.wait() and
100# return the result. Once a SIGINT has been seen (in the main process
101# or a subprocess, including the one the current call is waiting for),
Edward Lemur9a5bb612019-09-26 02:01:52 +0000102# wait(p) will call p.terminate().
Edward Lesmes8e282792018-04-03 18:50:29 -0400103class SigintHandler(object):
Edward Lesmes8e282792018-04-03 18:50:29 -0400104 sigint_returncodes = {-signal.SIGINT, # Unix
105 -1073741510, # Windows
106 }
107 def __init__(self):
108 self.__lock = threading.Lock()
109 self.__processes = set()
110 self.__got_sigint = False
Edward Lemur9a5bb612019-09-26 02:01:52 +0000111 self.__previous_signal = signal.signal(signal.SIGINT, self.interrupt)
Edward Lesmes8e282792018-04-03 18:50:29 -0400112
113 def __on_sigint(self):
114 self.__got_sigint = True
115 while self.__processes:
116 try:
117 self.__processes.pop().terminate()
118 except OSError:
119 pass
120
Edward Lemur9a5bb612019-09-26 02:01:52 +0000121 def interrupt(self, signal_num, frame):
Edward Lesmes8e282792018-04-03 18:50:29 -0400122 with self.__lock:
123 self.__on_sigint()
Edward Lemur9a5bb612019-09-26 02:01:52 +0000124 self.__previous_signal(signal_num, frame)
Edward Lesmes8e282792018-04-03 18:50:29 -0400125
126 def got_sigint(self):
127 with self.__lock:
128 return self.__got_sigint
129
130 def wait(self, p, stdin):
131 with self.__lock:
132 if self.__got_sigint:
133 p.terminate()
134 self.__processes.add(p)
135 stdout, stderr = p.communicate(stdin)
136 code = p.returncode
137 with self.__lock:
138 self.__processes.discard(p)
139 if code in self.sigint_returncodes:
140 self.__on_sigint()
Edward Lesmes8e282792018-04-03 18:50:29 -0400141 return stdout, stderr
142
143sigint_handler = SigintHandler()
144
145
Edward Lemurecc27072020-01-06 16:42:34 +0000146class Timer(object):
147 def __init__(self, timeout, fn):
148 self.completed = False
149 self._fn = fn
150 self._timer = threading.Timer(timeout, self._onTimer) if timeout else None
151
152 def __enter__(self):
153 if self._timer:
154 self._timer.start()
155 return self
156
157 def __exit__(self, _type, _value, _traceback):
158 if self._timer:
159 self._timer.cancel()
160
161 def _onTimer(self):
162 self._fn()
163 self.completed = True
164
165
Edward Lesmes8e282792018-04-03 18:50:29 -0400166class ThreadPool(object):
Edward Lemurecc27072020-01-06 16:42:34 +0000167 def __init__(self, pool_size=None, timeout=None):
168 self.timeout = timeout
Edward Lesmes8e282792018-04-03 18:50:29 -0400169 self._pool_size = pool_size or multiprocessing.cpu_count()
170 self._messages = []
171 self._messages_lock = threading.Lock()
172 self._tests = []
173 self._tests_lock = threading.Lock()
174 self._nonparallel_tests = []
175
Edward Lemurecc27072020-01-06 16:42:34 +0000176 def _GetCommand(self, test):
Edward Lemur940c2822019-08-23 00:34:25 +0000177 vpython = 'vpython'
178 if test.python3:
179 vpython += '3'
180 if sys.platform == 'win32':
181 vpython += '.bat'
Edward Lesmes8e282792018-04-03 18:50:29 -0400182
183 cmd = test.cmd
184 if cmd[0] == 'python':
185 cmd = list(cmd)
186 cmd[0] = vpython
187 elif cmd[0].endswith('.py'):
188 cmd = [vpython] + cmd
189
Edward Lemur336e51f2019-11-14 21:42:04 +0000190 # On Windows, scripts on the current directory take precedence over PATH, so
191 # that when testing depot_tools on Windows, calling `vpython.bat` will
192 # execute the copy of vpython of the depot_tools under test instead of the
193 # one in the bot.
194 # As a workaround, we run the tests from the parent directory instead.
195 if (cmd[0] == vpython and
196 'cwd' in test.kwargs and
197 os.path.basename(test.kwargs['cwd']) == 'depot_tools'):
198 test.kwargs['cwd'] = os.path.dirname(test.kwargs['cwd'])
199 cmd[1] = os.path.join('depot_tools', cmd[1])
200
Edward Lemurecc27072020-01-06 16:42:34 +0000201 return cmd
202
203 def _RunWithTimeout(self, cmd, stdin, kwargs):
204 p = subprocess.Popen(cmd, **kwargs)
205 with Timer(self.timeout, p.terminate) as timer:
206 stdout, _ = sigint_handler.wait(p, stdin)
207 if timer.completed:
208 stdout = 'Process timed out after %ss\n%s' % (self.timeout, stdout)
209 return p.returncode, stdout
210
211 def CallCommand(self, test):
212 """Runs an external program.
213
Edward Lemura5799e32020-01-17 19:26:51 +0000214 This function converts invocation of .py files and invocations of 'python'
Edward Lemurecc27072020-01-06 16:42:34 +0000215 to vpython invocations.
216 """
217 cmd = self._GetCommand(test)
Edward Lesmes8e282792018-04-03 18:50:29 -0400218 try:
Edward Lemurecc27072020-01-06 16:42:34 +0000219 start = time_time()
220 returncode, stdout = self._RunWithTimeout(cmd, test.stdin, test.kwargs)
221 duration = time_time() - start
Edward Lemur7cf94382019-11-15 22:36:41 +0000222 except Exception:
Edward Lemurecc27072020-01-06 16:42:34 +0000223 duration = time_time() - start
Edward Lesmes8e282792018-04-03 18:50:29 -0400224 return test.message(
Edward Lemur7cf94382019-11-15 22:36:41 +0000225 '%s\n%s exec failure (%4.2fs)\n%s' % (
226 test.name, ' '.join(cmd), duration, traceback.format_exc()))
Edward Lemurde9e3ca2019-10-24 21:13:31 +0000227
Edward Lemurecc27072020-01-06 16:42:34 +0000228 if returncode != 0:
Edward Lesmes8e282792018-04-03 18:50:29 -0400229 return test.message(
Edward Lemur7cf94382019-11-15 22:36:41 +0000230 '%s\n%s (%4.2fs) failed\n%s' % (
231 test.name, ' '.join(cmd), duration, stdout))
Edward Lemurecc27072020-01-06 16:42:34 +0000232
Edward Lesmes8e282792018-04-03 18:50:29 -0400233 if test.info:
Edward Lemur7cf94382019-11-15 22:36:41 +0000234 return test.info('%s\n%s (%4.2fs)' % (test.name, ' '.join(cmd), duration))
Edward Lesmes8e282792018-04-03 18:50:29 -0400235
236 def AddTests(self, tests, parallel=True):
237 if parallel:
238 self._tests.extend(tests)
239 else:
240 self._nonparallel_tests.extend(tests)
241
242 def RunAsync(self):
243 self._messages = []
244
245 def _WorkerFn():
246 while True:
247 test = None
248 with self._tests_lock:
249 if not self._tests:
250 break
251 test = self._tests.pop()
252 result = self.CallCommand(test)
253 if result:
254 with self._messages_lock:
255 self._messages.append(result)
256
257 def _StartDaemon():
258 t = threading.Thread(target=_WorkerFn)
259 t.daemon = True
260 t.start()
261 return t
262
263 while self._nonparallel_tests:
264 test = self._nonparallel_tests.pop()
265 result = self.CallCommand(test)
266 if result:
267 self._messages.append(result)
268
269 if self._tests:
270 threads = [_StartDaemon() for _ in range(self._pool_size)]
271 for worker in threads:
272 worker.join()
273
274 return self._messages
275
276
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000277def normpath(path):
278 '''Version of os.path.normpath that also changes backward slashes to
279 forward slashes when not running on Windows.
280 '''
281 # This is safe to always do because the Windows version of os.path.normpath
282 # will replace forward slashes with backward slashes.
283 path = path.replace(os.sep, '/')
284 return os.path.normpath(path)
285
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000286
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000287def _RightHandSideLinesImpl(affected_files):
288 """Implements RightHandSideLines for InputApi and GclChange."""
289 for af in affected_files:
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000290 lines = af.ChangedContents()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000291 for line in lines:
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000292 yield (af, line[0], line[1])
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000293
294
Edward Lemur6eb1d322020-02-27 22:20:15 +0000295def prompt_should_continue(prompt_string):
296 sys.stdout.write(prompt_string)
297 response = sys.stdin.readline().strip().lower()
298 return response in ('y', 'yes')
dpranke@chromium.org5ac21012011-03-16 02:58:25 +0000299
300
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000301# Top level object so multiprocessing can pickle
302# Public access through OutputApi object.
303class _PresubmitResult(object):
304 """Base class for result objects."""
305 fatal = False
306 should_prompt = False
307
308 def __init__(self, message, items=None, long_text=''):
309 """
310 message: A short one-line message to indicate errors.
311 items: A list of short strings to indicate where errors occurred.
312 long_text: multi-line text output, e.g. from another tool
313 """
314 self._message = message
315 self._items = items or []
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000316 self._long_text = long_text.rstrip()
317
Edward Lemur6eb1d322020-02-27 22:20:15 +0000318 def handle(self):
319 sys.stdout.write(self._message)
320 sys.stdout.write('\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000321 for index, item in enumerate(self._items):
Edward Lemur6eb1d322020-02-27 22:20:15 +0000322 sys.stdout.write(' ')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000323 # Write separately in case it's unicode.
Edward Lemur6eb1d322020-02-27 22:20:15 +0000324 sys.stdout.write(str(item))
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000325 if index < len(self._items) - 1:
Edward Lemur6eb1d322020-02-27 22:20:15 +0000326 sys.stdout.write(' \\')
327 sys.stdout.write('\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000328 if self._long_text:
Edward Lemur6eb1d322020-02-27 22:20:15 +0000329 sys.stdout.write('\n***************\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000330 # Write separately in case it's unicode.
Edward Lemur6eb1d322020-02-27 22:20:15 +0000331 sys.stdout.write(self._long_text)
332 sys.stdout.write('\n***************\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000333
Debrian Figueroadd2737e2019-06-21 23:50:13 +0000334 def json_format(self):
335 return {
336 'message': self._message,
Debrian Figueroa6095d402019-06-28 18:47:18 +0000337 'items': [str(item) for item in self._items],
Debrian Figueroadd2737e2019-06-21 23:50:13 +0000338 'long_text': self._long_text,
339 'fatal': self.fatal
340 }
341
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000342
343# Top level object so multiprocessing can pickle
344# Public access through OutputApi object.
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000345class _PresubmitError(_PresubmitResult):
346 """A hard presubmit error."""
347 fatal = True
348
349
350# Top level object so multiprocessing can pickle
351# Public access through OutputApi object.
352class _PresubmitPromptWarning(_PresubmitResult):
353 """An warning that prompts the user if they want to continue."""
354 should_prompt = True
355
356
357# Top level object so multiprocessing can pickle
358# Public access through OutputApi object.
359class _PresubmitNotifyResult(_PresubmitResult):
360 """Just print something to the screen -- but it's not even a warning."""
361 pass
362
363
364# Top level object so multiprocessing can pickle
365# Public access through OutputApi object.
366class _MailTextResult(_PresubmitResult):
367 """A warning that should be included in the review request email."""
368 def __init__(self, *args, **kwargs):
369 super(_MailTextResult, self).__init__()
370 raise NotImplementedError()
371
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000372class GerritAccessor(object):
373 """Limited Gerrit functionality for canned presubmit checks to work.
374
375 To avoid excessive Gerrit calls, caches the results.
376 """
377
378 def __init__(self, host):
379 self.host = host
380 self.cache = {}
381
382 def _FetchChangeDetail(self, issue):
383 # Separate function to be easily mocked in tests.
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +0100384 try:
385 return gerrit_util.GetChangeDetail(
386 self.host, str(issue),
Aaron Gable6f5a8d92017-04-18 14:49:05 -0700387 ['ALL_REVISIONS', 'DETAILED_LABELS', 'ALL_COMMITS'])
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +0100388 except gerrit_util.GerritError as e:
389 if e.http_status == 404:
390 raise Exception('Either Gerrit issue %s doesn\'t exist, or '
391 'no credentials to fetch issue details' % issue)
392 raise
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000393
394 def GetChangeInfo(self, issue):
395 """Returns labels and all revisions (patchsets) for this issue.
396
397 The result is a dictionary according to Gerrit REST Api.
398 https://gerrit-review.googlesource.com/Documentation/rest-api.html
399
400 However, API isn't very clear what's inside, so see tests for example.
401 """
402 assert issue
403 cache_key = int(issue)
404 if cache_key not in self.cache:
405 self.cache[cache_key] = self._FetchChangeDetail(issue)
406 return self.cache[cache_key]
407
408 def GetChangeDescription(self, issue, patchset=None):
409 """If patchset is none, fetches current patchset."""
410 info = self.GetChangeInfo(issue)
411 # info is a reference to cache. We'll modify it here adding description to
412 # it to the right patchset, if it is not yet there.
413
414 # Find revision info for the patchset we want.
415 if patchset is not None:
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +0000416 for rev, rev_info in info['revisions'].items():
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000417 if str(rev_info['_number']) == str(patchset):
418 break
419 else:
420 raise Exception('patchset %s doesn\'t exist in issue %s' % (
421 patchset, issue))
422 else:
423 rev = info['current_revision']
424 rev_info = info['revisions'][rev]
425
Andrii Shyshkalov9c3a4642017-01-24 17:41:22 +0100426 return rev_info['commit']['message']
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000427
Mun Yong Jang603d01e2017-12-19 16:38:30 -0800428 def GetDestRef(self, issue):
429 ref = self.GetChangeInfo(issue)['branch']
430 if not ref.startswith('refs/'):
431 # NOTE: it is possible to create 'refs/x' branch,
432 # aka 'refs/heads/refs/x'. However, this is ill-advised.
433 ref = 'refs/heads/%s' % ref
434 return ref
435
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000436 def GetChangeOwner(self, issue):
437 return self.GetChangeInfo(issue)['owner']['email']
438
439 def GetChangeReviewers(self, issue, approving_only=True):
Aaron Gable8b478f02017-07-31 15:33:19 -0700440 changeinfo = self.GetChangeInfo(issue)
441 if approving_only:
442 labelinfo = changeinfo.get('labels', {}).get('Code-Review', {})
443 values = labelinfo.get('values', {}).keys()
444 try:
445 max_value = max(int(v) for v in values)
446 reviewers = [r for r in labelinfo.get('all', [])
447 if r.get('value', 0) == max_value]
448 except ValueError: # values is the empty list
449 reviewers = []
450 else:
451 reviewers = changeinfo.get('reviewers', {}).get('REVIEWER', [])
452 return [r.get('email') for r in reviewers]
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000453
Edward Lemure4d329c2020-02-03 20:41:18 +0000454 def UpdateDescription(self, description, issue):
455 gerrit_util.SetCommitMessage(self.host, issue, description, notify='NONE')
456
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000457
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000458class OutputApi(object):
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000459 """An instance of OutputApi gets passed to presubmit scripts so that they
460 can output various types of results.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000461 """
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000462 PresubmitResult = _PresubmitResult
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000463 PresubmitError = _PresubmitError
464 PresubmitPromptWarning = _PresubmitPromptWarning
465 PresubmitNotifyResult = _PresubmitNotifyResult
466 MailTextResult = _MailTextResult
467
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000468 def __init__(self, is_committing):
469 self.is_committing = is_committing
Daniel Cheng7227d212017-11-17 08:12:37 -0800470 self.more_cc = []
471
472 def AppendCC(self, cc):
473 """Appends a user to cc for this change."""
474 self.more_cc.append(cc)
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000475
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000476 def PresubmitPromptOrNotify(self, *args, **kwargs):
477 """Warn the user when uploading, but only notify if committing."""
478 if self.is_committing:
479 return self.PresubmitNotifyResult(*args, **kwargs)
480 return self.PresubmitPromptWarning(*args, **kwargs)
481
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000482
483class InputApi(object):
484 """An instance of this object is passed to presubmit scripts so they can
485 know stuff about the change they're looking at.
486 """
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000487 # Method could be a function
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800488 # pylint: disable=no-self-use
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000489
maruel@chromium.org3410d912009-06-09 20:56:16 +0000490 # File extensions that are considered source files from a style guide
491 # perspective. Don't modify this list from a presubmit script!
maruel@chromium.orgc33455a2011-06-24 19:14:18 +0000492 #
493 # Files without an extension aren't included in the list. If you want to
Edward Lemura5799e32020-01-17 19:26:51 +0000494 # filter them as source files, add r'(^|.*?[\\\/])[^.]+$' to the white list.
maruel@chromium.orgc33455a2011-06-24 19:14:18 +0000495 # Note that ALL CAPS files are black listed in DEFAULT_BLACK_LIST below.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000496 DEFAULT_WHITE_LIST = (
497 # C++ and friends
Edward Lemura5799e32020-01-17 19:26:51 +0000498 r'.+\.c$', r'.+\.cc$', r'.+\.cpp$', r'.+\.h$', r'.+\.m$', r'.+\.mm$',
499 r'.+\.inl$', r'.+\.asm$', r'.+\.hxx$', r'.+\.hpp$', r'.+\.s$', r'.+\.S$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000500 # Scripts
Edward Lemura5799e32020-01-17 19:26:51 +0000501 r'.+\.js$', r'.+\.py$', r'.+\.sh$', r'.+\.rb$', r'.+\.pl$', r'.+\.pm$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000502 # Other
Edward Lemura5799e32020-01-17 19:26:51 +0000503 r'.+\.java$', r'.+\.mk$', r'.+\.am$', r'.+\.css$', r'.+\.mojom$',
504 r'.+\.fidl$'
maruel@chromium.org3410d912009-06-09 20:56:16 +0000505 )
506
507 # Path regexp that should be excluded from being considered containing source
508 # files. Don't modify this list from a presubmit script!
509 DEFAULT_BLACK_LIST = (
Edward Lemura5799e32020-01-17 19:26:51 +0000510 r'testing_support[\\\/]google_appengine[\\\/].*',
511 r'.*\bexperimental[\\\/].*',
Kent Tamura179dd1e2018-04-26 15:07:41 +0900512 # Exclude third_party/.* but NOT third_party/{WebKit,blink}
513 # (crbug.com/539768 and crbug.com/836555).
Edward Lemura5799e32020-01-17 19:26:51 +0000514 r'.*\bthird_party[\\\/](?!(WebKit|blink)[\\\/]).*',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000515 # Output directories (just in case)
Edward Lemura5799e32020-01-17 19:26:51 +0000516 r'.*\bDebug[\\\/].*',
517 r'.*\bRelease[\\\/].*',
518 r'.*\bxcodebuild[\\\/].*',
519 r'.*\bout[\\\/].*',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000520 # All caps files like README and LICENCE.
Edward Lemura5799e32020-01-17 19:26:51 +0000521 r'.*\b[A-Z0-9_]{2,}$',
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000522 # SCM (can happen in dual SCM configuration). (Slightly over aggressive)
Edward Lemura5799e32020-01-17 19:26:51 +0000523 r'(|.*[\\\/])\.git[\\\/].*',
524 r'(|.*[\\\/])\.svn[\\\/].*',
maruel@chromium.org7ccb4bb2011-11-07 20:26:20 +0000525 # There is no point in processing a patch file.
Edward Lemura5799e32020-01-17 19:26:51 +0000526 r'.+\.diff$',
527 r'.+\.patch$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000528 )
529
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000530 def __init__(self, change, presubmit_path, is_committing,
Edward Lesmes8e282792018-04-03 18:50:29 -0400531 verbose, gerrit_obj, dry_run=None, thread_pool=None, parallel=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000532 """Builds an InputApi object.
533
534 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000535 change: A presubmit.Change object.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000536 presubmit_path: The path to the presubmit script being processed.
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000537 is_committing: True if the change is about to be committed.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000538 gerrit_obj: provides basic Gerrit codereview functionality.
539 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -0400540 parallel: if true, all tests reported via input_api.RunTests for all
541 PRESUBMIT files will be run in parallel.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000542 """
maruel@chromium.org9711bba2009-05-22 23:51:39 +0000543 # Version number of the presubmit_support script.
544 self.version = [int(x) for x in __version__.split('.')]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000545 self.change = change
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000546 self.is_committing = is_committing
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000547 self.gerrit = gerrit_obj
tandrii@chromium.org57bafac2016-04-28 05:09:03 +0000548 self.dry_run = dry_run
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000549
Edward Lesmes8e282792018-04-03 18:50:29 -0400550 self.parallel = parallel
551 self.thread_pool = thread_pool or ThreadPool()
552
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000553 # We expose various modules and functions as attributes of the input_api
554 # so that presubmit scripts don't have to import them.
Takeshi Yoshino07a6bea2017-08-02 02:44:06 +0900555 self.ast = ast
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000556 self.basename = os.path.basename
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000557 self.cpplint = cpplint
dcheng091b7db2016-06-16 01:27:51 -0700558 self.fnmatch = fnmatch
Yoshisato Yanagisawa04600b42019-03-15 03:03:41 +0000559 self.gclient_paths = gclient_paths
Yoshisato Yanagisawa57dd17b2019-03-22 09:10:29 +0000560 # TODO(yyanagisawa): stop exposing this when python3 become default.
561 # Since python3's tempfile has TemporaryDirectory, we do not need this.
562 self.temporary_directory = gclient_utils.temporary_directory
dpranke@chromium.org17cc2442012-10-17 21:12:09 +0000563 self.glob = glob.glob
maruel@chromium.orgfb11c7b2010-03-18 18:22:14 +0000564 self.json = json
maruel@chromium.org6fba34d2011-06-02 13:45:12 +0000565 self.logging = logging.getLogger('PRESUBMIT')
maruel@chromium.org2b5ce562011-03-31 16:15:44 +0000566 self.os_listdir = os.listdir
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000567 self.os_path = os.path
pgervais@chromium.orgbd0cace2014-10-02 23:23:46 +0000568 self.os_stat = os.stat
Yoshisato Yanagisawa406de132018-06-29 05:43:25 +0000569 self.os_walk = os.walk
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000570 self.re = re
571 self.subprocess = subprocess
Edward Lemurb9830242019-10-30 22:19:20 +0000572 self.sys = sys
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000573 self.tempfile = tempfile
dpranke@chromium.org0d1bdea2011-03-24 22:54:38 +0000574 self.time = time
maruel@chromium.org1487d532009-06-06 00:22:57 +0000575 self.unittest = unittest
Edward Lemurb9830242019-10-30 22:19:20 +0000576 if sys.version_info.major == 2:
577 self.urllib2 = urllib2
Edward Lemur16af3562019-10-17 22:11:33 +0000578 self.urllib_request = urllib_request
579 self.urllib_error = urllib_error
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000580
Robert Iannucci50258932018-03-19 10:30:59 -0700581 self.is_windows = sys.platform == 'win32'
582
Edward Lemurb9646622019-10-25 20:57:35 +0000583 # Set python_executable to 'vpython' in order to allow scripts in other
584 # repos (e.g. src.git) to automatically pick up that repo's .vpython file,
585 # instead of inheriting the one in depot_tools.
586 self.python_executable = 'vpython'
maruel@chromium.orgc0b22972009-06-25 16:19:14 +0000587 self.environ = os.environ
588
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000589 # InputApi.platform is the platform you're currently running on.
590 self.platform = sys.platform
591
iannucci@chromium.org0af3bb32015-06-12 20:44:35 +0000592 self.cpu_count = multiprocessing.cpu_count()
593
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000594 # The local path of the currently-being-processed presubmit script.
maruel@chromium.org3d235242009-05-15 12:40:48 +0000595 self._current_presubmit_path = os.path.dirname(presubmit_path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000596
597 # We carry the canned checks so presubmit scripts can easily use them.
598 self.canned_checks = presubmit_canned_checks
599
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +0100600 # Temporary files we must manually remove at the end of a run.
601 self._named_temporary_files = []
Jochen Eisinger72606f82017-04-04 10:44:18 +0200602
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000603 # TODO(dpranke): figure out a list of all approved owners for a repo
604 # in order to be able to handle wildcard OWNERS files?
605 self.owners_db = owners.Database(change.RepositoryRoot(),
Edward Lemurb9830242019-10-30 22:19:20 +0000606 fopen=open, os_path=self.os_path)
Jochen Eisinger76f5fc62017-04-07 16:27:46 +0200607 self.owners_finder = owners_finder.OwnersFinder
maruel@chromium.org899e1c12011-04-07 17:03:18 +0000608 self.verbose = verbose
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000609 self.Command = CommandData
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000610
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000611 # Replace <hash_map> and <hash_set> as headers that need to be included
Edward Lemura5799e32020-01-17 19:26:51 +0000612 # with 'base/containers/hash_tables.h' instead.
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000613 # Access to a protected member _XX of a client class
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800614 # pylint: disable=protected-access
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000615 self.cpplint._re_pattern_templates = [
danakj@chromium.org18278522013-06-11 22:42:32 +0000616 (a, b, 'base/containers/hash_tables.h')
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000617 if header in ('<hash_map>', '<hash_set>') else (a, b, header)
618 for (a, b, header) in cpplint._re_pattern_templates
619 ]
620
Edward Lemurecc27072020-01-06 16:42:34 +0000621 def SetTimeout(self, timeout):
622 self.thread_pool.timeout = timeout
623
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000624 def PresubmitLocalPath(self):
625 """Returns the local path of the presubmit script currently being run.
626
627 This is useful if you don't want to hard-code absolute paths in the
628 presubmit script. For example, It can be used to find another file
629 relative to the PRESUBMIT.py script, so the whole tree can be branched and
630 the presubmit script still works, without editing its content.
631 """
maruel@chromium.org3d235242009-05-15 12:40:48 +0000632 return self._current_presubmit_path
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000633
agable0b65e732016-11-22 09:25:46 -0800634 def AffectedFiles(self, include_deletes=True, file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000635 """Same as input_api.change.AffectedFiles() except only lists files
636 (and optionally directories) in the same directory as the current presubmit
637 script, or subdirectories thereof.
638 """
Edward Lemura5799e32020-01-17 19:26:51 +0000639 dir_with_slash = normpath('%s/' % self.PresubmitLocalPath())
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000640 if len(dir_with_slash) == 1:
641 dir_with_slash = ''
sail@chromium.org5538e022011-05-12 17:53:16 +0000642
Edward Lemurb9830242019-10-30 22:19:20 +0000643 return list(filter(
maruel@chromium.org4661e0c2009-06-04 00:45:26 +0000644 lambda x: normpath(x.AbsoluteLocalPath()).startswith(dir_with_slash),
Edward Lemurb9830242019-10-30 22:19:20 +0000645 self.change.AffectedFiles(include_deletes, file_filter)))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000646
agable0b65e732016-11-22 09:25:46 -0800647 def LocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000648 """Returns local paths of input_api.AffectedFiles()."""
agable0b65e732016-11-22 09:25:46 -0800649 paths = [af.LocalPath() for af in self.AffectedFiles()]
Edward Lemura5799e32020-01-17 19:26:51 +0000650 logging.debug('LocalPaths: %s', paths)
pgervais@chromium.org2f64f782014-04-25 00:12:33 +0000651 return paths
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000652
agable0b65e732016-11-22 09:25:46 -0800653 def AbsoluteLocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000654 """Returns absolute local paths of input_api.AffectedFiles()."""
agable0b65e732016-11-22 09:25:46 -0800655 return [af.AbsoluteLocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000656
John Budorick16162372018-04-18 10:39:53 -0700657 def AffectedTestableFiles(self, include_deletes=None, **kwargs):
agable0b65e732016-11-22 09:25:46 -0800658 """Same as input_api.change.AffectedTestableFiles() except only lists files
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000659 in the same directory as the current presubmit script, or subdirectories
660 thereof.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000661 """
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000662 if include_deletes is not None:
Edward Lemura5799e32020-01-17 19:26:51 +0000663 warn('AffectedTestableFiles(include_deletes=%s)'
664 ' is deprecated and ignored' % str(include_deletes),
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000665 category=DeprecationWarning,
666 stacklevel=2)
Edward Lemurb9830242019-10-30 22:19:20 +0000667 return list(filter(
668 lambda x: x.IsTestableFile(),
669 self.AffectedFiles(include_deletes=False, **kwargs)))
agable0b65e732016-11-22 09:25:46 -0800670
671 def AffectedTextFiles(self, include_deletes=None):
672 """An alias to AffectedTestableFiles for backwards compatibility."""
673 return self.AffectedTestableFiles(include_deletes=include_deletes)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000674
maruel@chromium.org3410d912009-06-09 20:56:16 +0000675 def FilterSourceFile(self, affected_file, white_list=None, black_list=None):
Edward Lemura5799e32020-01-17 19:26:51 +0000676 """Filters out files that aren't considered 'source file'.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000677
678 If white_list or black_list is None, InputApi.DEFAULT_WHITE_LIST
679 and InputApi.DEFAULT_BLACK_LIST is used respectively.
680
681 The lists will be compiled as regular expression and
682 AffectedFile.LocalPath() needs to pass both list.
683
684 Note: Copy-paste this function to suit your needs or use a lambda function.
685 """
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000686 def Find(affected_file, items):
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000687 local_path = affected_file.LocalPath()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000688 for item in items:
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000689 if self.re.match(item, local_path):
maruel@chromium.org3410d912009-06-09 20:56:16 +0000690 return True
691 return False
692 return (Find(affected_file, white_list or self.DEFAULT_WHITE_LIST) and
693 not Find(affected_file, black_list or self.DEFAULT_BLACK_LIST))
694
695 def AffectedSourceFiles(self, source_file):
agable0b65e732016-11-22 09:25:46 -0800696 """Filter the list of AffectedTestableFiles by the function source_file.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000697
698 If source_file is None, InputApi.FilterSourceFile() is used.
699 """
700 if not source_file:
701 source_file = self.FilterSourceFile
Edward Lemurb9830242019-10-30 22:19:20 +0000702 return list(filter(source_file, self.AffectedTestableFiles()))
maruel@chromium.org3410d912009-06-09 20:56:16 +0000703
704 def RightHandSideLines(self, source_file_filter=None):
Edward Lemura5799e32020-01-17 19:26:51 +0000705 """An iterator over all text lines in 'new' version of changed files.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000706
707 Only lists lines from new or modified text files in the change that are
708 contained by the directory of the currently executing presubmit script.
709
710 This is useful for doing line-by-line regex checks, like checking for
711 trailing whitespace.
712
713 Yields:
714 a 3 tuple:
715 the AffectedFile instance of the current file;
716 integer line number (1-based); and
717 the contents of the line as a string.
maruel@chromium.org1487d532009-06-06 00:22:57 +0000718
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000719 Note: The carriage return (LF or CR) is stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000720 """
maruel@chromium.org3410d912009-06-09 20:56:16 +0000721 files = self.AffectedSourceFiles(source_file_filter)
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000722 return _RightHandSideLinesImpl(files)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000723
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000724 def ReadFile(self, file_item, mode='r'):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000725 """Reads an arbitrary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000726
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000727 Deny reading anything outside the repository.
728 """
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000729 if isinstance(file_item, AffectedFile):
730 file_item = file_item.AbsoluteLocalPath()
731 if not file_item.startswith(self.change.RepositoryRoot()):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000732 raise IOError('Access outside the repository root is denied.')
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +0000733 return gclient_utils.FileRead(file_item, mode)
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000734
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +0100735 def CreateTemporaryFile(self, **kwargs):
736 """Returns a named temporary file that must be removed with a call to
737 RemoveTemporaryFiles().
738
739 All keyword arguments are forwarded to tempfile.NamedTemporaryFile(),
740 except for |delete|, which is always set to False.
741
742 Presubmit checks that need to create a temporary file and pass it for
743 reading should use this function instead of NamedTemporaryFile(), as
744 Windows fails to open a file that is already open for writing.
745
746 with input_api.CreateTemporaryFile() as f:
747 f.write('xyz')
748 f.close()
749 input_api.subprocess.check_output(['script-that', '--reads-from',
750 f.name])
751
752
753 Note that callers of CreateTemporaryFile() should not worry about removing
754 any temporary file; this is done transparently by the presubmit handling
755 code.
756 """
757 if 'delete' in kwargs:
758 # Prevent users from passing |delete|; we take care of file deletion
759 # ourselves and this prevents unintuitive error messages when we pass
760 # delete=False and 'delete' is also in kwargs.
761 raise TypeError('CreateTemporaryFile() does not take a "delete" '
762 'argument, file deletion is handled automatically by '
763 'the same presubmit_support code that creates InputApi '
764 'objects.')
765 temp_file = self.tempfile.NamedTemporaryFile(delete=False, **kwargs)
766 self._named_temporary_files.append(temp_file.name)
767 return temp_file
768
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000769 @property
770 def tbr(self):
771 """Returns if a change is TBR'ed."""
Jeremy Romandce22502017-06-20 15:37:29 -0400772 return 'TBR' in self.change.tags or self.change.TBRsFromDescription()
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000773
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000774 def RunTests(self, tests_mix, parallel=True):
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000775 tests = []
776 msgs = []
777 for t in tests_mix:
Edward Lesmes8e282792018-04-03 18:50:29 -0400778 if isinstance(t, OutputApi.PresubmitResult) and t:
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000779 msgs.append(t)
780 else:
781 assert issubclass(t.message, _PresubmitResult)
782 tests.append(t)
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000783 if self.verbose:
784 t.info = _PresubmitNotifyResult
Edward Lemur1037c742018-05-01 18:56:04 -0400785 if not t.kwargs.get('cwd'):
786 t.kwargs['cwd'] = self.PresubmitLocalPath()
Edward Lesmes8e282792018-04-03 18:50:29 -0400787 self.thread_pool.AddTests(tests, parallel)
Edward Lemur21000eb2019-05-24 23:25:58 +0000788 # When self.parallel is True (i.e. --parallel is passed as an option)
789 # RunTests doesn't actually run tests. It adds them to a ThreadPool that
790 # will run all tests once all PRESUBMIT files are processed.
791 # Otherwise, it will run them and return the results.
792 if not self.parallel:
Edward Lesmes8e282792018-04-03 18:50:29 -0400793 msgs.extend(self.thread_pool.RunAsync())
794 return msgs
scottmg86099d72016-09-01 09:16:51 -0700795
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000796
nick@chromium.orgff526192013-06-10 19:30:26 +0000797class _DiffCache(object):
798 """Caches diffs retrieved from a particular SCM."""
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000799 def __init__(self, upstream=None):
800 """Stores the upstream revision against which all diffs will be computed."""
801 self._upstream = upstream
nick@chromium.orgff526192013-06-10 19:30:26 +0000802
803 def GetDiff(self, path, local_root):
804 """Get the diff for a particular path."""
805 raise NotImplementedError()
806
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700807 def GetOldContents(self, path, local_root):
808 """Get the old version for a particular path."""
809 raise NotImplementedError()
810
nick@chromium.orgff526192013-06-10 19:30:26 +0000811
nick@chromium.orgff526192013-06-10 19:30:26 +0000812class _GitDiffCache(_DiffCache):
813 """DiffCache implementation for git; gets all file diffs at once."""
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000814 def __init__(self, upstream):
815 super(_GitDiffCache, self).__init__(upstream=upstream)
nick@chromium.orgff526192013-06-10 19:30:26 +0000816 self._diffs_by_file = None
817
818 def GetDiff(self, path, local_root):
819 if not self._diffs_by_file:
820 # Compute a single diff for all files and parse the output; should
821 # with git this is much faster than computing one diff for each file.
822 diffs = {}
823
824 # Don't specify any filenames below, because there are command line length
825 # limits on some platforms and GenerateDiff would fail.
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000826 unified_diff = scm.GIT.GenerateDiff(local_root, files=[], full_move=True,
827 branch=self._upstream)
nick@chromium.orgff526192013-06-10 19:30:26 +0000828
829 # This regex matches the path twice, separated by a space. Note that
830 # filename itself may contain spaces.
831 file_marker = re.compile('^diff --git (?P<filename>.*) (?P=filename)$')
832 current_diff = []
833 keep_line_endings = True
834 for x in unified_diff.splitlines(keep_line_endings):
835 match = file_marker.match(x)
836 if match:
837 # Marks the start of a new per-file section.
838 diffs[match.group('filename')] = current_diff = [x]
839 elif x.startswith('diff --git'):
840 raise PresubmitFailure('Unexpected diff line: %s' % x)
841 else:
842 current_diff.append(x)
843
844 self._diffs_by_file = dict(
845 (normpath(path), ''.join(diff)) for path, diff in diffs.items())
846
847 if path not in self._diffs_by_file:
848 raise PresubmitFailure(
849 'Unified diff did not contain entry for file %s' % path)
850
851 return self._diffs_by_file[path]
852
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700853 def GetOldContents(self, path, local_root):
854 return scm.GIT.GetOldContents(local_root, path, branch=self._upstream)
855
nick@chromium.orgff526192013-06-10 19:30:26 +0000856
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000857class AffectedFile(object):
858 """Representation of a file in a change."""
nick@chromium.orgff526192013-06-10 19:30:26 +0000859
860 DIFF_CACHE = _DiffCache
861
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000862 # Method could be a function
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800863 # pylint: disable=no-self-use
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000864 def __init__(self, path, action, repository_root, diff_cache):
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000865 self._path = path
866 self._action = action
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000867 self._local_root = repository_root
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000868 self._is_directory = None
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000869 self._cached_changed_contents = None
870 self._cached_new_contents = None
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000871 self._diff_cache = diff_cache
tobiasjs2836bcf2016-08-16 04:08:16 -0700872 logging.debug('%s(%s)', self.__class__.__name__, self._path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000873
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000874 def LocalPath(self):
875 """Returns the path of this file on the local disk relative to client root.
Andrew Grieve92b8b992017-11-02 09:42:24 -0400876
877 This should be used for error messages but not for accessing files,
878 because presubmit checks are run with CWD=PresubmitLocalPath() (which is
879 often != client root).
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000880 """
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000881 return normpath(self._path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000882
883 def AbsoluteLocalPath(self):
884 """Returns the absolute path of this file on the local disk.
885 """
chase@chromium.org8e416c82009-10-06 04:30:44 +0000886 return os.path.abspath(os.path.join(self._local_root, self.LocalPath()))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000887
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000888 def Action(self):
889 """Returns the action on this opened file, e.g. A, M, D, etc."""
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000890 return self._action
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000891
agable0b65e732016-11-22 09:25:46 -0800892 def IsTestableFile(self):
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000893 """Returns True if the file is a text file and not a binary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000894
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000895 Deleted files are not text file."""
maruel@chromium.org1e08c002009-05-28 19:09:33 +0000896 raise NotImplementedError() # Implement when needed
897
agable0b65e732016-11-22 09:25:46 -0800898 def IsTextFile(self):
899 """An alias to IsTestableFile for backwards compatibility."""
900 return self.IsTestableFile()
901
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700902 def OldContents(self):
903 """Returns an iterator over the lines in the old version of file.
904
Daniel Cheng2da34fe2017-03-21 20:42:12 -0700905 The old version is the file before any modifications in the user's
Edward Lemura5799e32020-01-17 19:26:51 +0000906 workspace, i.e. the 'left hand side'.
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700907
908 Contents will be empty if the file is a directory or does not exist.
909 Note: The carriage returns (LF or CR) are stripped off.
910 """
911 return self._diff_cache.GetOldContents(self.LocalPath(),
912 self._local_root).splitlines()
913
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000914 def NewContents(self):
915 """Returns an iterator over the lines in the new version of file.
916
Edward Lemura5799e32020-01-17 19:26:51 +0000917 The new version is the file in the user's workspace, i.e. the 'right hand
918 side'.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000919
920 Contents will be empty if the file is a directory or does not exist.
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000921 Note: The carriage returns (LF or CR) are stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000922 """
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000923 if self._cached_new_contents is None:
924 self._cached_new_contents = []
agable0b65e732016-11-22 09:25:46 -0800925 try:
926 self._cached_new_contents = gclient_utils.FileRead(
927 self.AbsoluteLocalPath(), 'rU').splitlines()
928 except IOError:
929 pass # File not found? That's fine; maybe it was deleted.
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000930 return self._cached_new_contents[:]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000931
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000932 def ChangedContents(self):
933 """Returns a list of tuples (line number, line text) of all new lines.
934
935 This relies on the scm diff output describing each changed code section
936 with a line of the form
937
938 ^@@ <old line num>,<old size> <new line num>,<new size> @@$
939 """
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000940 if self._cached_changed_contents is not None:
941 return self._cached_changed_contents[:]
942 self._cached_changed_contents = []
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000943 line_num = 0
944
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000945 for line in self.GenerateScmDiff().splitlines():
Edward Lemurac5c55f2020-02-29 00:17:16 +0000946 m = re.match(r'^@@ [0-9\,\+\-]+ \+([0-9]+)\,[0-9]+ @@', line)
947 if m:
948 line_num = int(m.groups(1)[0])
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000949 continue
950 if line.startswith('+') and not line.startswith('++'):
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000951 self._cached_changed_contents.append((line_num, line[1:]))
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000952 if not line.startswith('-'):
953 line_num += 1
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000954 return self._cached_changed_contents[:]
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000955
maruel@chromium.org5de13972009-06-10 18:16:06 +0000956 def __str__(self):
957 return self.LocalPath()
958
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000959 def GenerateScmDiff(self):
nick@chromium.orgff526192013-06-10 19:30:26 +0000960 return self._diff_cache.GetDiff(self.LocalPath(), self._local_root)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000961
maruel@chromium.org58407af2011-04-12 23:15:57 +0000962
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000963class GitAffectedFile(AffectedFile):
964 """Representation of a file in a change out of a git checkout."""
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000965 # Method 'NNN' is abstract in class 'NNN' but is not overridden
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800966 # pylint: disable=abstract-method
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000967
nick@chromium.orgff526192013-06-10 19:30:26 +0000968 DIFF_CACHE = _GitDiffCache
969
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000970 def __init__(self, *args, **kwargs):
971 AffectedFile.__init__(self, *args, **kwargs)
972 self._server_path = None
agable0b65e732016-11-22 09:25:46 -0800973 self._is_testable_file = None
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000974
agable0b65e732016-11-22 09:25:46 -0800975 def IsTestableFile(self):
976 if self._is_testable_file is None:
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000977 if self.Action() == 'D':
agable0b65e732016-11-22 09:25:46 -0800978 # A deleted file is not testable.
979 self._is_testable_file = False
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000980 else:
agable0b65e732016-11-22 09:25:46 -0800981 self._is_testable_file = os.path.isfile(self.AbsoluteLocalPath())
982 return self._is_testable_file
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000983
maruel@chromium.orgc1938752011-04-12 23:11:13 +0000984
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000985class Change(object):
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000986 """Describe a change.
987
988 Used directly by the presubmit scripts to query the current change being
989 tested.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000990
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000991 Instance members:
nick@chromium.orgff526192013-06-10 19:30:26 +0000992 tags: Dictionary of KEY=VALUE pairs found in the change description.
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000993 self.KEY: equivalent to tags['KEY']
994 """
995
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000996 _AFFECTED_FILES = AffectedFile
997
Edward Lemura5799e32020-01-17 19:26:51 +0000998 # Matches key/value (or 'tag') lines in changelist descriptions.
maruel@chromium.org428342a2011-11-10 15:46:33 +0000999 TAG_LINE_RE = re.compile(
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001000 '^[ \t]*(?P<key>[A-Z][A-Z_0-9]*)[ \t]*=[ \t]*(?P<value>.*?)[ \t]*$')
maruel@chromium.orgc1938752011-04-12 23:11:13 +00001001 scm = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001002
maruel@chromium.org58407af2011-04-12 23:15:57 +00001003 def __init__(
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001004 self, name, description, local_root, files, issue, patchset, author,
1005 upstream=None):
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001006 if files is None:
1007 files = []
1008 self._name = name
chase@chromium.org8e416c82009-10-06 04:30:44 +00001009 # Convert root into an absolute path.
1010 self._local_root = os.path.abspath(local_root)
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001011 self._upstream = upstream
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001012 self.issue = issue
1013 self.patchset = patchset
maruel@chromium.org58407af2011-04-12 23:15:57 +00001014 self.author_email = author
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001015
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001016 self._full_description = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001017 self.tags = {}
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001018 self._description_without_tags = ''
1019 self.SetDescriptionText(description)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001020
maruel@chromium.orge085d812011-10-10 19:49:15 +00001021 assert all(
1022 (isinstance(f, (list, tuple)) and len(f) == 2) for f in files), files
1023
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001024 diff_cache = self._AFFECTED_FILES.DIFF_CACHE(self._upstream)
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001025 self._affected_files = [
nick@chromium.orgff526192013-06-10 19:30:26 +00001026 self._AFFECTED_FILES(path, action.strip(), self._local_root, diff_cache)
1027 for action, path in files
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +00001028 ]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001029
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001030 def Name(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001031 """Returns the change name."""
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001032 return self._name
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001033
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001034 def DescriptionText(self):
1035 """Returns the user-entered changelist description, minus tags.
1036
Edward Lemura5799e32020-01-17 19:26:51 +00001037 Any line in the user-provided description starting with e.g. 'FOO='
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001038 (whitespace permitted before and around) is considered a tag line. Such
1039 lines are stripped out of the description this function returns.
1040 """
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001041 return self._description_without_tags
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001042
1043 def FullDescriptionText(self):
1044 """Returns the complete changelist description including tags."""
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001045 return self._full_description
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001046
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001047 def SetDescriptionText(self, description):
1048 """Sets the full description text (including tags) to |description|.
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001049
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001050 Also updates the list of tags."""
1051 self._full_description = description
1052
1053 # From the description text, build up a dictionary of key/value pairs
Edward Lemura5799e32020-01-17 19:26:51 +00001054 # plus the description minus all key/value or 'tag' lines.
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001055 description_without_tags = []
1056 self.tags = {}
1057 for line in self._full_description.splitlines():
1058 m = self.TAG_LINE_RE.match(line)
1059 if m:
1060 self.tags[m.group('key')] = m.group('value')
1061 else:
1062 description_without_tags.append(line)
1063
1064 # Change back to text and remove whitespace at end.
1065 self._description_without_tags = (
1066 '\n'.join(description_without_tags).rstrip())
1067
Edward Lemur69bb8be2020-02-03 20:37:38 +00001068 def AddDescriptionFooter(self, key, value):
1069 """Adds the given footer to the change description.
1070
1071 Args:
1072 key: A string with the key for the git footer. It must conform to
1073 the git footers format (i.e. 'List-Of-Tokens') and will be case
1074 normalized so that each token is title-cased.
1075 value: A string with the value for the git footer.
1076 """
1077 description = git_footers.add_footer(
1078 self.FullDescriptionText(), git_footers.normalize_name(key), value)
1079 self.SetDescriptionText(description)
1080
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001081 def RepositoryRoot(self):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001082 """Returns the repository (checkout) root directory for this change,
1083 as an absolute path.
1084 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001085 return self._local_root
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001086
1087 def __getattr__(self, attr):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001088 """Return tags directly as attributes on the object."""
Edward Lemura5799e32020-01-17 19:26:51 +00001089 if not re.match(r'^[A-Z_]*$', attr):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001090 raise AttributeError(self, attr)
maruel@chromium.orge1a524f2009-05-27 14:43:46 +00001091 return self.tags.get(attr)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001092
Edward Lemur69bb8be2020-02-03 20:37:38 +00001093 def GitFootersFromDescription(self):
1094 """Return the git footers present in the description.
1095
1096 Returns:
1097 footers: A dict of {footer: [values]} containing a multimap of the footers
1098 in the change description.
1099 """
1100 return git_footers.parse_footers(self.FullDescriptionText())
1101
Aaron Gablefc03e672017-05-15 14:09:42 -07001102 def BugsFromDescription(self):
1103 """Returns all bugs referenced in the commit description."""
Aaron Gable12ef5012017-05-15 14:29:00 -07001104 tags = [b.strip() for b in self.tags.get('BUG', '').split(',') if b.strip()]
Caleb Rouleauc0546b92019-02-22 06:12:57 +00001105 footers = []
Edward Lemur69bb8be2020-02-03 20:37:38 +00001106 parsed = self.GitFootersFromDescription()
Dan Beam62954042019-10-03 21:20:33 +00001107 unsplit_footers = parsed.get('Bug', []) + parsed.get('Fixed', [])
Caleb Rouleauc0546b92019-02-22 06:12:57 +00001108 for unsplit_footer in unsplit_footers:
1109 footers += [b.strip() for b in unsplit_footer.split(',')]
Aaron Gable12ef5012017-05-15 14:29:00 -07001110 return sorted(set(tags + footers))
Aaron Gablefc03e672017-05-15 14:09:42 -07001111
1112 def ReviewersFromDescription(self):
1113 """Returns all reviewers listed in the commit description."""
Edward Lemura5799e32020-01-17 19:26:51 +00001114 # We don't support a 'R:' git-footer for reviewers; that is in metadata.
Aaron Gable12ef5012017-05-15 14:29:00 -07001115 tags = [r.strip() for r in self.tags.get('R', '').split(',') if r.strip()]
1116 return sorted(set(tags))
Aaron Gablefc03e672017-05-15 14:09:42 -07001117
1118 def TBRsFromDescription(self):
1119 """Returns all TBR reviewers listed in the commit description."""
Aaron Gable12ef5012017-05-15 14:29:00 -07001120 tags = [r.strip() for r in self.tags.get('TBR', '').split(',') if r.strip()]
1121 # TODO(agable): Remove support for 'Tbr:' when TBRs are programmatically
1122 # determined by self-CR+1s.
Edward Lemur69bb8be2020-02-03 20:37:38 +00001123 footers = self.GitFootersFromDescription().get('Tbr', [])
Aaron Gable12ef5012017-05-15 14:29:00 -07001124 return sorted(set(tags + footers))
Aaron Gablefc03e672017-05-15 14:09:42 -07001125
1126 # TODO(agable): Delete these once we're sure they're unused.
1127 @property
1128 def BUG(self):
1129 return ','.join(self.BugsFromDescription())
1130 @property
1131 def R(self):
1132 return ','.join(self.ReviewersFromDescription())
1133 @property
1134 def TBR(self):
1135 return ','.join(self.TBRsFromDescription())
1136
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001137 def AllFiles(self, root=None):
1138 """List all files under source control in the repo."""
1139 raise NotImplementedError()
1140
agable0b65e732016-11-22 09:25:46 -08001141 def AffectedFiles(self, include_deletes=True, file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001142 """Returns a list of AffectedFile instances for all files in the change.
1143
1144 Args:
1145 include_deletes: If false, deleted files will be filtered out.
sail@chromium.org5538e022011-05-12 17:53:16 +00001146 file_filter: An additional filter to apply.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001147
1148 Returns:
1149 [AffectedFile(path, action), AffectedFile(path, action)]
1150 """
Edward Lemurb9830242019-10-30 22:19:20 +00001151 affected = list(filter(file_filter, self._affected_files))
sail@chromium.org5538e022011-05-12 17:53:16 +00001152
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001153 if include_deletes:
1154 return affected
Edward Lemurb9830242019-10-30 22:19:20 +00001155 return list(filter(lambda x: x.Action() != 'D', affected))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001156
John Budorick16162372018-04-18 10:39:53 -07001157 def AffectedTestableFiles(self, include_deletes=None, **kwargs):
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +00001158 """Return a list of the existing text files in a change."""
1159 if include_deletes is not None:
Edward Lemura5799e32020-01-17 19:26:51 +00001160 warn('AffectedTeestableFiles(include_deletes=%s)'
1161 ' is deprecated and ignored' % str(include_deletes),
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +00001162 category=DeprecationWarning,
1163 stacklevel=2)
Edward Lemurb9830242019-10-30 22:19:20 +00001164 return list(filter(
1165 lambda x: x.IsTestableFile(),
1166 self.AffectedFiles(include_deletes=False, **kwargs)))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001167
agable0b65e732016-11-22 09:25:46 -08001168 def AffectedTextFiles(self, include_deletes=None):
1169 """An alias to AffectedTestableFiles for backwards compatibility."""
1170 return self.AffectedTestableFiles(include_deletes=include_deletes)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001171
agable0b65e732016-11-22 09:25:46 -08001172 def LocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001173 """Convenience function."""
agable0b65e732016-11-22 09:25:46 -08001174 return [af.LocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001175
agable0b65e732016-11-22 09:25:46 -08001176 def AbsoluteLocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001177 """Convenience function."""
agable0b65e732016-11-22 09:25:46 -08001178 return [af.AbsoluteLocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001179
1180 def RightHandSideLines(self):
Edward Lemura5799e32020-01-17 19:26:51 +00001181 """An iterator over all text lines in 'new' version of changed files.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001182
1183 Lists lines from new or modified text files in the change.
1184
1185 This is useful for doing line-by-line regex checks, like checking for
1186 trailing whitespace.
1187
1188 Yields:
1189 a 3 tuple:
1190 the AffectedFile instance of the current file;
1191 integer line number (1-based); and
1192 the contents of the line as a string.
1193 """
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +00001194 return _RightHandSideLinesImpl(
1195 x for x in self.AffectedFiles(include_deletes=False)
agable0b65e732016-11-22 09:25:46 -08001196 if x.IsTestableFile())
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001197
Jochen Eisingerd0573ec2017-04-13 10:55:06 +02001198 def OriginalOwnersFiles(self):
1199 """A map from path names of affected OWNERS files to their old content."""
1200 def owners_file_filter(f):
1201 return 'OWNERS' in os.path.split(f.LocalPath())[1]
1202 files = self.AffectedFiles(file_filter=owners_file_filter)
1203 return dict([(f.LocalPath(), f.OldContents()) for f in files])
1204
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001205
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001206class GitChange(Change):
1207 _AFFECTED_FILES = GitAffectedFile
maruel@chromium.orgc1938752011-04-12 23:11:13 +00001208 scm = 'git'
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +00001209
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001210 def AllFiles(self, root=None):
1211 """List all files under source control in the repo."""
1212 root = root or self.RepositoryRoot()
1213 return subprocess.check_output(
Aaron Gable7817f022017-12-12 09:43:17 -08001214 ['git', '-c', 'core.quotePath=false', 'ls-files', '--', '.'],
1215 cwd=root).splitlines()
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001216
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001217
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001218def ListRelevantPresubmitFiles(files, root):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001219 """Finds all presubmit files that apply to a given set of source files.
1220
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001221 If inherit-review-settings-ok is present right under root, looks for
1222 PRESUBMIT.py in directories enclosing root.
1223
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001224 Args:
1225 files: An iterable container containing file paths.
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001226 root: Path where to stop searching.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001227
1228 Return:
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001229 List of absolute paths of the existing PRESUBMIT.py scripts.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001230 """
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001231 files = [normpath(os.path.join(root, f)) for f in files]
1232
1233 # List all the individual directories containing files.
1234 directories = set([os.path.dirname(f) for f in files])
1235
1236 # Ignore root if inherit-review-settings-ok is present.
1237 if os.path.isfile(os.path.join(root, 'inherit-review-settings-ok')):
1238 root = None
1239
1240 # Collect all unique directories that may contain PRESUBMIT.py.
1241 candidates = set()
1242 for directory in directories:
1243 while True:
1244 if directory in candidates:
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001245 break
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001246 candidates.add(directory)
1247 if directory == root:
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001248 break
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001249 parent_dir = os.path.dirname(directory)
1250 if parent_dir == directory:
1251 # We hit the system root directory.
1252 break
1253 directory = parent_dir
1254
1255 # Look for PRESUBMIT.py in all candidate directories.
1256 results = []
1257 for directory in sorted(list(candidates)):
tobiasjsff061c02016-08-17 03:23:57 -07001258 try:
1259 for f in os.listdir(directory):
1260 p = os.path.join(directory, f)
1261 if os.path.isfile(p) and re.match(
1262 r'PRESUBMIT.*\.py$', f) and not f.startswith('PRESUBMIT_test'):
1263 results.append(p)
1264 except OSError:
1265 pass
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001266
tobiasjs2836bcf2016-08-16 04:08:16 -07001267 logging.debug('Presubmit files: %s', ','.join(results))
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001268 return results
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001269
1270
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001271class GetTryMastersExecuter(object):
1272 @staticmethod
1273 def ExecPresubmitScript(script_text, presubmit_path, project, change):
1274 """Executes GetPreferredTryMasters() from a single presubmit script.
1275
1276 Args:
1277 script_text: The text of the presubmit script.
1278 presubmit_path: Project script to run.
1279 project: Project name to pass to presubmit script for bot selection.
1280
1281 Return:
1282 A map of try masters to map of builders to set of tests.
1283 """
1284 context = {}
1285 try:
Raul Tambre09e64b42019-05-14 01:57:22 +00001286 exec(compile(script_text, 'PRESUBMIT.py', 'exec', dont_inherit=True),
1287 context)
Raul Tambre7c938462019-05-24 16:35:35 +00001288 except Exception as e:
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001289 raise PresubmitFailure('"%s" had an exception.\n%s'
1290 % (presubmit_path, e))
1291
1292 function_name = 'GetPreferredTryMasters'
1293 if function_name not in context:
1294 return {}
1295 get_preferred_try_masters = context[function_name]
1296 if not len(inspect.getargspec(get_preferred_try_masters)[0]) == 2:
1297 raise PresubmitFailure(
1298 'Expected function "GetPreferredTryMasters" to take two arguments.')
1299 return get_preferred_try_masters(project, change)
1300
1301
rmistry@google.com5626a922015-02-26 14:03:30 +00001302class GetPostUploadExecuter(object):
1303 @staticmethod
Edward Lemur016a0872020-02-04 22:13:28 +00001304 def ExecPresubmitScript(script_text, presubmit_path, gerrit_obj, change):
rmistry@google.com5626a922015-02-26 14:03:30 +00001305 """Executes PostUploadHook() from a single presubmit script.
1306
1307 Args:
1308 script_text: The text of the presubmit script.
1309 presubmit_path: Project script to run.
Edward Lemur016a0872020-02-04 22:13:28 +00001310 gerrit_obj: The GerritAccessor object.
rmistry@google.com5626a922015-02-26 14:03:30 +00001311 change: The Change object.
1312
1313 Return:
1314 A list of results objects.
1315 """
1316 context = {}
1317 try:
Raul Tambre09e64b42019-05-14 01:57:22 +00001318 exec(compile(script_text, 'PRESUBMIT.py', 'exec', dont_inherit=True),
1319 context)
Raul Tambre7c938462019-05-24 16:35:35 +00001320 except Exception as e:
rmistry@google.com5626a922015-02-26 14:03:30 +00001321 raise PresubmitFailure('"%s" had an exception.\n%s'
1322 % (presubmit_path, e))
1323
1324 function_name = 'PostUploadHook'
1325 if function_name not in context:
1326 return {}
1327 post_upload_hook = context[function_name]
1328 if not len(inspect.getargspec(post_upload_hook)[0]) == 3:
1329 raise PresubmitFailure(
1330 'Expected function "PostUploadHook" to take three arguments.')
Edward Lemur016a0872020-02-04 22:13:28 +00001331 return post_upload_hook(gerrit_obj, change, OutputApi(False))
rmistry@google.com5626a922015-02-26 14:03:30 +00001332
1333
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001334def _MergeMasters(masters1, masters2):
1335 """Merges two master maps. Merges also the tests of each builder."""
1336 result = {}
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001337 for (master, builders) in itertools.chain(masters1.items(),
1338 masters2.items()):
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001339 new_builders = result.setdefault(master, {})
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001340 for (builder, tests) in builders.items():
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001341 new_builders.setdefault(builder, set([])).update(tests)
1342 return result
1343
1344
1345def DoGetTryMasters(change,
1346 changed_files,
1347 repository_root,
1348 default_presubmit,
1349 project,
1350 verbose,
1351 output_stream):
1352 """Get the list of try masters from the presubmit scripts.
1353
1354 Args:
1355 changed_files: List of modified files.
1356 repository_root: The repository root.
1357 default_presubmit: A default presubmit script to execute in any case.
1358 project: Optional name of a project used in selecting trybots.
1359 verbose: Prints debug info.
1360 output_stream: A stream to write debug output to.
1361
1362 Return:
1363 Map of try masters to map of builders to set of tests.
1364 """
1365 presubmit_files = ListRelevantPresubmitFiles(changed_files, repository_root)
1366 if not presubmit_files and verbose:
Edward Lemura5799e32020-01-17 19:26:51 +00001367 output_stream.write('Warning, no PRESUBMIT.py found.\n')
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001368 results = {}
1369 executer = GetTryMastersExecuter()
1370
1371 if default_presubmit:
1372 if verbose:
Edward Lemura5799e32020-01-17 19:26:51 +00001373 output_stream.write('Running default presubmit script.\n')
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001374 fake_path = os.path.join(repository_root, 'PRESUBMIT.py')
1375 results = _MergeMasters(results, executer.ExecPresubmitScript(
1376 default_presubmit, fake_path, project, change))
1377 for filename in presubmit_files:
1378 filename = os.path.abspath(filename)
1379 if verbose:
Edward Lemura5799e32020-01-17 19:26:51 +00001380 output_stream.write('Running %s\n' % filename)
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001381 # Accept CRLF presubmit script.
1382 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1383 results = _MergeMasters(results, executer.ExecPresubmitScript(
1384 presubmit_script, filename, project, change))
1385
1386 # Make sets to lists again for later JSON serialization.
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001387 for builders in results.values():
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001388 for builder in builders:
1389 builders[builder] = list(builders[builder])
1390
1391 if results and verbose:
1392 output_stream.write('%s\n' % str(results))
1393 return results
1394
1395
rmistry@google.com5626a922015-02-26 14:03:30 +00001396def DoPostUploadExecuter(change,
Edward Lemur016a0872020-02-04 22:13:28 +00001397 gerrit_obj,
Edward Lemur6eb1d322020-02-27 22:20:15 +00001398 verbose):
rmistry@google.com5626a922015-02-26 14:03:30 +00001399 """Execute the post upload hook.
1400
1401 Args:
1402 change: The Change object.
Edward Lemur016a0872020-02-04 22:13:28 +00001403 gerrit_obj: The GerritAccessor object.
rmistry@google.com5626a922015-02-26 14:03:30 +00001404 verbose: Prints debug info.
rmistry@google.com5626a922015-02-26 14:03:30 +00001405 """
1406 presubmit_files = ListRelevantPresubmitFiles(
Edward Lemur6eb1d322020-02-27 22:20:15 +00001407 change.LocalPaths(), change.RepositoryRoot())
rmistry@google.com5626a922015-02-26 14:03:30 +00001408 if not presubmit_files and verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001409 sys.stdout.write('Warning, no PRESUBMIT.py found.\n')
rmistry@google.com5626a922015-02-26 14:03:30 +00001410 results = []
1411 executer = GetPostUploadExecuter()
1412 # The root presubmit file should be executed after the ones in subdirectories.
1413 # i.e. the specific post upload hooks should run before the general ones.
1414 # Thus, reverse the order provided by ListRelevantPresubmitFiles.
1415 presubmit_files.reverse()
1416
1417 for filename in presubmit_files:
1418 filename = os.path.abspath(filename)
1419 if verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001420 sys.stdout.write('Running %s\n' % filename)
rmistry@google.com5626a922015-02-26 14:03:30 +00001421 # Accept CRLF presubmit script.
1422 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1423 results.extend(executer.ExecPresubmitScript(
Edward Lemur016a0872020-02-04 22:13:28 +00001424 presubmit_script, filename, gerrit_obj, change))
rmistry@google.com5626a922015-02-26 14:03:30 +00001425
Edward Lemur6eb1d322020-02-27 22:20:15 +00001426 if not results:
1427 return 0
1428
1429 sys.stdout.write('\n')
1430 sys.stdout.write('** Post Upload Hook Messages **\n')
1431
1432 exit_code = 0
1433 for result in results:
1434 if result.fatal:
1435 exit_code = 1
1436 result.handle()
1437 sys.stdout.write('\n')
1438
1439 return exit_code
rmistry@google.com5626a922015-02-26 14:03:30 +00001440
1441
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001442class PresubmitExecuter(object):
Aaron Gable668c1d82018-04-03 10:19:16 -07001443 def __init__(self, change, committing, verbose,
Edward Lesmes8e282792018-04-03 18:50:29 -04001444 gerrit_obj, dry_run=None, thread_pool=None, parallel=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001445 """
1446 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001447 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001448 committing: True if 'git cl land' is running, False if 'git cl upload' is.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001449 gerrit_obj: provides basic Gerrit codereview functionality.
1450 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -04001451 parallel: if true, all tests reported via input_api.RunTests for all
1452 PRESUBMIT files will be run in parallel.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001453 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001454 self.change = change
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001455 self.committing = committing
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001456 self.gerrit = gerrit_obj
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001457 self.verbose = verbose
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001458 self.dry_run = dry_run
Daniel Cheng7227d212017-11-17 08:12:37 -08001459 self.more_cc = []
Edward Lesmes8e282792018-04-03 18:50:29 -04001460 self.thread_pool = thread_pool
1461 self.parallel = parallel
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001462
1463 def ExecPresubmitScript(self, script_text, presubmit_path):
1464 """Executes a single presubmit script.
1465
1466 Args:
1467 script_text: The text of the presubmit script.
1468 presubmit_path: The path to the presubmit file (this will be reported via
1469 input_api.PresubmitLocalPath()).
1470
1471 Return:
1472 A list of result objects, empty if no problems.
1473 """
thakis@chromium.orgc6ef53a2014-11-04 00:13:54 +00001474
chase@chromium.org8e416c82009-10-06 04:30:44 +00001475 # Change to the presubmit file's directory to support local imports.
1476 main_path = os.getcwd()
1477 os.chdir(os.path.dirname(presubmit_path))
1478
1479 # Load the presubmit script into context.
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001480 input_api = InputApi(self.change, presubmit_path, self.committing,
Aaron Gable668c1d82018-04-03 10:19:16 -07001481 self.verbose, gerrit_obj=self.gerrit,
Edward Lesmes8e282792018-04-03 18:50:29 -04001482 dry_run=self.dry_run, thread_pool=self.thread_pool,
1483 parallel=self.parallel)
Daniel Cheng7227d212017-11-17 08:12:37 -08001484 output_api = OutputApi(self.committing)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001485 context = {}
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001486 try:
Raul Tambre09e64b42019-05-14 01:57:22 +00001487 exec(compile(script_text, 'PRESUBMIT.py', 'exec', dont_inherit=True),
1488 context)
Raul Tambre7c938462019-05-24 16:35:35 +00001489 except Exception as e:
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001490 raise PresubmitFailure('"%s" had an exception.\n%s' % (presubmit_path, e))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001491
1492 # These function names must change if we make substantial changes to
1493 # the presubmit API that are not backwards compatible.
1494 if self.committing:
1495 function_name = 'CheckChangeOnCommit'
1496 else:
1497 function_name = 'CheckChangeOnUpload'
1498 if function_name in context:
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +01001499 try:
Daniel Cheng7227d212017-11-17 08:12:37 -08001500 context['__args'] = (input_api, output_api)
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +01001501 logging.debug('Running %s in %s', function_name, presubmit_path)
1502 result = eval(function_name + '(*__args)', context)
1503 logging.debug('Running %s done.', function_name)
Daniel Chengd36fce42017-11-21 21:52:52 -08001504 self.more_cc.extend(output_api.more_cc)
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +01001505 finally:
Edward Lemurb9830242019-10-30 22:19:20 +00001506 for f in input_api._named_temporary_files:
1507 os.remove(f)
1508 if not isinstance(result, (tuple, list)):
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001509 raise PresubmitFailure(
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001510 'Presubmit functions must return a tuple or list')
1511 for item in result:
1512 if not isinstance(item, OutputApi.PresubmitResult):
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001513 raise PresubmitFailure(
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001514 'All presubmit results must be of types derived from '
1515 'output_api.PresubmitResult')
1516 else:
1517 result = () # no error since the script doesn't care about current event.
1518
chase@chromium.org8e416c82009-10-06 04:30:44 +00001519 # Return the process to the original working directory.
1520 os.chdir(main_path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001521 return result
1522
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001523def DoPresubmitChecks(change,
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001524 committing,
1525 verbose,
maruel@chromium.orgb0dfd352009-06-10 14:12:54 +00001526 default_presubmit,
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001527 may_prompt,
Aaron Gable668c1d82018-04-03 10:19:16 -07001528 gerrit_obj,
Edward Lesmes8e282792018-04-03 18:50:29 -04001529 dry_run=None,
Debrian Figueroadd2737e2019-06-21 23:50:13 +00001530 parallel=False,
1531 json_output=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001532 """Runs all presubmit checks that apply to the files in the change.
1533
1534 This finds all PRESUBMIT.py files in directories enclosing the files in the
1535 change (up to the repository root) and calls the relevant entrypoint function
1536 depending on whether the change is being committed or uploaded.
1537
1538 Prints errors, warnings and notifications. Prompts the user for warnings
1539 when needed.
1540
1541 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001542 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001543 committing: True if 'git cl land' is running, False if 'git cl upload' is.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001544 verbose: Prints debug info.
maruel@chromium.org0ff1fab2009-05-22 13:08:15 +00001545 default_presubmit: A default presubmit script to execute in any case.
Quinten Yearsley516fe7f2016-12-14 11:50:18 -08001546 may_prompt: Enable (y/n) questions on warning or error. If False,
1547 any questions are answered with yes by default.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001548 gerrit_obj: provides basic Gerrit codereview functionality.
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001549 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -04001550 parallel: if true, all tests specified by input_api.RunTests in all
1551 PRESUBMIT files will be run in parallel.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001552
1553 Return:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001554 1 if presubmit checks failed or 0 otherwise.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001555 """
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001556 old_environ = os.environ
1557 try:
1558 # Make sure python subprocesses won't generate .pyc files.
1559 os.environ = os.environ.copy()
Edward Lemurb9830242019-10-30 22:19:20 +00001560 os.environ['PYTHONDONTWRITEBYTECODE'] = '1'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001561
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001562 if committing:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001563 sys.stdout.write('Running presubmit commit checks ...\n')
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001564 else:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001565 sys.stdout.write('Running presubmit upload checks ...\n')
Edward Lemurecc27072020-01-06 16:42:34 +00001566 start_time = time_time()
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001567 presubmit_files = ListRelevantPresubmitFiles(
agable0b65e732016-11-22 09:25:46 -08001568 change.AbsoluteLocalPaths(), change.RepositoryRoot())
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001569 if not presubmit_files and verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001570 sys.stdout.write('Warning, no PRESUBMIT.py found.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001571 results = []
Edward Lesmes8e282792018-04-03 18:50:29 -04001572 thread_pool = ThreadPool()
Edward Lemur7e3c67f2018-07-20 20:52:49 +00001573 executer = PresubmitExecuter(change, committing, verbose, gerrit_obj,
1574 dry_run, thread_pool, parallel)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001575 if default_presubmit:
1576 if verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001577 sys.stdout.write('Running default presubmit script.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001578 fake_path = os.path.join(change.RepositoryRoot(), 'PRESUBMIT.py')
1579 results += executer.ExecPresubmitScript(default_presubmit, fake_path)
1580 for filename in presubmit_files:
1581 filename = os.path.abspath(filename)
1582 if verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001583 sys.stdout.write('Running %s\n' % filename)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001584 # Accept CRLF presubmit script.
1585 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1586 results += executer.ExecPresubmitScript(presubmit_script, filename)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001587
Edward Lesmes8e282792018-04-03 18:50:29 -04001588 results += thread_pool.RunAsync()
1589
Edward Lemur6eb1d322020-02-27 22:20:15 +00001590 messages = {}
1591 should_prompt = False
1592 presubmits_failed = False
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001593 for result in results:
1594 if result.fatal:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001595 presubmits_failed = True
1596 messages.setdefault('ERRORS', []).append(result)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001597 elif result.should_prompt:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001598 should_prompt = True
1599 messages.setdefault('Warnings', []).append(result)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001600 else:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001601 messages.setdefault('Messages', []).append(result)
pam@chromium.orged9a0832009-09-09 22:48:55 +00001602
Edward Lemur6eb1d322020-02-27 22:20:15 +00001603 sys.stdout.write('\n')
1604 for name, items in messages.items():
1605 sys.stdout.write('** Presubmit %s **\n' % name)
1606 for item in items:
1607 item.handle()
1608 sys.stdout.write('\n')
pam@chromium.orged9a0832009-09-09 22:48:55 +00001609
Edward Lemurecc27072020-01-06 16:42:34 +00001610 total_time = time_time() - start_time
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001611 if total_time > 1.0:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001612 sys.stdout.write(
1613 'Presubmit checks took %.1fs to calculate.\n\n' % total_time)
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +00001614
Edward Lemur6eb1d322020-02-27 22:20:15 +00001615 if not should_prompt and not presubmits_failed:
1616 sys.stdout.write('Presubmit checks passed.\n')
1617 elif should_prompt:
1618 sys.stdout.write('There were presubmit warnings. ')
Quinten Yearsley516fe7f2016-12-14 11:50:18 -08001619 if may_prompt:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001620 presubmits_failed = not prompt_should_continue(
1621 'Are you sure you wish to continue? (y/N): ')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001622
Edward Lemur1dc66e12020-02-21 21:36:34 +00001623 if json_output:
1624 # Write the presubmit results to json output
1625 presubmit_results = {
1626 'errors': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001627 error.json_format()
1628 for error in messages.get('ERRORS', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001629 ],
1630 'notifications': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001631 notification.json_format()
1632 for notification in messages.get('Messages', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001633 ],
1634 'warnings': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001635 warning.json_format()
1636 for warning in messages.get('Warnings', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001637 ],
Edward Lemur6eb1d322020-02-27 22:20:15 +00001638 'more_cc': executer.more_cc,
Edward Lemur1dc66e12020-02-21 21:36:34 +00001639 }
1640
1641 gclient_utils.FileWrite(
1642 json_output, json.dumps(presubmit_results, sort_keys=True))
1643
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001644 global _ASKED_FOR_FEEDBACK
1645 # Ask for feedback one time out of 5.
1646 if (len(results) and random.randint(0, 4) == 0 and not _ASKED_FOR_FEEDBACK):
Edward Lemur6eb1d322020-02-27 22:20:15 +00001647 sys.stdout.write(
maruel@chromium.org1ce8e662014-01-14 15:23:00 +00001648 'Was the presubmit check useful? If not, run "git cl presubmit -v"\n'
1649 'to figure out which PRESUBMIT.py was run, then run git blame\n'
1650 'on the file to figure out who to ask for help.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001651 _ASKED_FOR_FEEDBACK = True
Edward Lemur6eb1d322020-02-27 22:20:15 +00001652
1653 return 1 if presubmits_failed else 0
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001654 finally:
1655 os.environ = old_environ
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001656
1657
Edward Lemur50984a62020-02-06 18:10:18 +00001658def _scan_sub_dirs(mask, recursive):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001659 if not recursive:
pgervais@chromium.orge57b09d2014-05-07 00:58:13 +00001660 return [x for x in glob.glob(mask) if x not in ('.svn', '.git')]
Lei Zhang9611c4c2017-04-04 01:41:56 -07001661
1662 results = []
1663 for root, dirs, files in os.walk('.'):
1664 if '.svn' in dirs:
1665 dirs.remove('.svn')
1666 if '.git' in dirs:
1667 dirs.remove('.git')
1668 for name in files:
1669 if fnmatch.fnmatch(name, mask):
1670 results.append(os.path.join(root, name))
1671 return results
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001672
1673
Edward Lemur50984a62020-02-06 18:10:18 +00001674def _parse_files(args, recursive):
tobiasjs2836bcf2016-08-16 04:08:16 -07001675 logging.debug('Searching for %s', args)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001676 files = []
1677 for arg in args:
Edward Lemur50984a62020-02-06 18:10:18 +00001678 files.extend([('M', f) for f in _scan_sub_dirs(arg, recursive)])
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001679 return files
1680
1681
Edward Lemur50984a62020-02-06 18:10:18 +00001682def _parse_change(parser, options):
1683 """Process change options.
1684
1685 Args:
1686 parser: The parser used to parse the arguments from command line.
1687 options: The arguments parsed from command line.
1688 Returns:
1689 A GitChange if the change root is a git repository, or a Change otherwise.
1690 """
1691 if options.files and options.all_files:
1692 parser.error('<files> cannot be specified when --all-files is set.')
1693
Edward Lesmes44ea3ff2020-02-05 00:14:30 +00001694 change_scm = scm.determine_scm(options.root)
Edward Lemur50984a62020-02-06 18:10:18 +00001695 if change_scm != 'git' and not options.files:
1696 parser.error('<files> is not optional for unversioned directories.')
1697
1698 if options.files:
1699 change_files = _parse_files(options.files, options.recursive)
1700 elif options.all_files:
1701 change_files = [('M', f) for f in scm.GIT.GetAllFiles(options.root)]
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001702 else:
Edward Lemur50984a62020-02-06 18:10:18 +00001703 change_files = scm.GIT.CaptureStatus(
Edward Lemur7f6dec02020-02-06 20:23:58 +00001704 options.root, options.upstream or None)
Edward Lemur50984a62020-02-06 18:10:18 +00001705
1706 logging.info('Found %d file(s).', len(change_files))
1707
1708 change_class = GitChange if change_scm == 'git' else Change
1709 return change_class(
1710 options.name,
1711 options.description,
1712 options.root,
1713 change_files,
1714 options.issue,
1715 options.patchset,
1716 options.author,
1717 upstream=options.upstream)
1718
1719
1720def _parse_gerrit_options(parser, options):
1721 """Process gerrit options.
1722
1723 SIDE EFFECTS: Modifies options.author and options.description from Gerrit if
1724 options.gerrit_fetch is set.
1725
1726 Args:
1727 parser: The parser used to parse the arguments from command line.
1728 options: The arguments parsed from command line.
1729 Returns:
1730 A GerritAccessor object if options.gerrit_url is set, or None otherwise.
1731 """
1732 gerrit_obj = None
1733 if options.gerrit_url:
1734 gerrit_obj = GerritAccessor(urlparse.urlparse(options.gerrit_url).netloc)
1735
1736 if not options.gerrit_fetch:
1737 return gerrit_obj
1738
1739 if not options.gerrit_url or not options.issue or not options.patchset:
1740 parser.error(
1741 '--gerrit_fetch requires --gerrit_url, --issue and --patchset.')
1742
1743 options.author = gerrit_obj.GetChangeOwner(options.issue)
1744 options.description = gerrit_obj.GetChangeDescription(
1745 options.issue, options.patchset)
1746
1747 logging.info('Got author: "%s"', options.author)
1748 logging.info('Got description: """\n%s\n"""', options.description)
1749
1750 return gerrit_obj
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001751
1752
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001753@contextlib.contextmanager
1754def canned_check_filter(method_names):
1755 filtered = {}
1756 try:
1757 for method_name in method_names:
1758 if not hasattr(presubmit_canned_checks, method_name):
Aaron Gableecee74c2018-04-02 15:13:08 -07001759 logging.warn('Skipping unknown "canned" check %s' % method_name)
1760 continue
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001761 filtered[method_name] = getattr(presubmit_canned_checks, method_name)
1762 setattr(presubmit_canned_checks, method_name, lambda *_a, **_kw: [])
1763 yield
1764 finally:
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001765 for name, method in filtered.items():
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001766 setattr(presubmit_canned_checks, name, method)
1767
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001768
sbc@chromium.org013731e2015-02-26 18:28:43 +00001769def main(argv=None):
Edward Lemura5799e32020-01-17 19:26:51 +00001770 parser = argparse.ArgumentParser(usage='%(prog)s [options] <files...>')
1771 hooks = parser.add_mutually_exclusive_group()
1772 hooks.add_argument('-c', '--commit', action='store_true',
1773 help='Use commit instead of upload checks.')
1774 hooks.add_argument('-u', '--upload', action='store_false', dest='commit',
1775 help='Use upload instead of commit checks.')
Edward Lemur75526302020-02-27 22:31:05 +00001776 hooks.add_argument('--post_upload', action='store_true',
1777 help='Run post-upload commit hooks.')
Edward Lemura5799e32020-01-17 19:26:51 +00001778 parser.add_argument('-r', '--recursive', action='store_true',
1779 help='Act recursively.')
1780 parser.add_argument('-v', '--verbose', action='count', default=0,
1781 help='Use 2 times for more debug info.')
1782 parser.add_argument('--name', default='no name')
1783 parser.add_argument('--author')
Edward Lemur227d5102020-02-25 23:45:35 +00001784 desc = parser.add_mutually_exclusive_group()
1785 desc.add_argument('--description', default='', help='The change description.')
1786 desc.add_argument('--description_file',
1787 help='File to read change description from.')
Edward Lemura5799e32020-01-17 19:26:51 +00001788 parser.add_argument('--issue', type=int, default=0)
1789 parser.add_argument('--patchset', type=int, default=0)
1790 parser.add_argument('--root', default=os.getcwd(),
1791 help='Search for PRESUBMIT.py up to this directory. '
1792 'If inherit-review-settings-ok is present in this '
1793 'directory, parent directories up to the root file '
1794 'system directories will also be searched.')
1795 parser.add_argument('--upstream',
1796 help='Git only: the base ref or upstream branch against '
1797 'which the diff should be computed.')
1798 parser.add_argument('--default_presubmit')
1799 parser.add_argument('--may_prompt', action='store_true', default=False)
1800 parser.add_argument('--skip_canned', action='append', default=[],
1801 help='A list of checks to skip which appear in '
1802 'presubmit_canned_checks. Can be provided multiple times '
1803 'to skip multiple canned checks.')
1804 parser.add_argument('--dry_run', action='store_true', help=argparse.SUPPRESS)
1805 parser.add_argument('--gerrit_url', help=argparse.SUPPRESS)
1806 parser.add_argument('--gerrit_fetch', action='store_true',
1807 help=argparse.SUPPRESS)
1808 parser.add_argument('--parallel', action='store_true',
1809 help='Run all tests specified by input_api.RunTests in '
1810 'all PRESUBMIT files in parallel.')
1811 parser.add_argument('--json_output',
1812 help='Write presubmit errors to json output.')
Edward Lemur1dc66e12020-02-21 21:36:34 +00001813 parser.add_argument('--all_files', action='store_true',
Edward Lemur50984a62020-02-06 18:10:18 +00001814 help='Mark all files under source control as modified.')
Edward Lemura5799e32020-01-17 19:26:51 +00001815 parser.add_argument('files', nargs='*',
1816 help='List of files to be marked as modified when '
1817 'executing presubmit or post-upload hooks. fnmatch '
1818 'wildcards can also be used.')
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001819
Edward Lemura5799e32020-01-17 19:26:51 +00001820 options = parser.parse_args(argv)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001821
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001822 if options.verbose >= 2:
maruel@chromium.org7444c502011-02-09 14:02:11 +00001823 logging.basicConfig(level=logging.DEBUG)
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001824 elif options.verbose:
1825 logging.basicConfig(level=logging.INFO)
1826 else:
1827 logging.basicConfig(level=logging.ERROR)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001828
Edward Lemur227d5102020-02-25 23:45:35 +00001829 if options.description_file:
1830 options.description = gclient_utils.FileRead(options.description_file)
Edward Lemur50984a62020-02-06 18:10:18 +00001831 gerrit_obj = _parse_gerrit_options(parser, options)
1832 change = _parse_change(parser, options)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001833
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001834 try:
Edward Lemur75526302020-02-27 22:31:05 +00001835 if options.post_upload:
1836 return DoPostUploadExecuter(
1837 change,
1838 gerrit_obj,
1839 options.verbose)
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001840 with canned_check_filter(options.skip_canned):
Edward Lemur6eb1d322020-02-27 22:20:15 +00001841 return DoPresubmitChecks(
Edward Lemur50984a62020-02-06 18:10:18 +00001842 change,
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001843 options.commit,
1844 options.verbose,
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001845 options.default_presubmit,
1846 options.may_prompt,
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001847 gerrit_obj,
Edward Lesmes8e282792018-04-03 18:50:29 -04001848 options.dry_run,
Debrian Figueroadd2737e2019-06-21 23:50:13 +00001849 options.parallel,
1850 options.json_output)
Raul Tambre7c938462019-05-24 16:35:35 +00001851 except PresubmitFailure as e:
Raul Tambre80ee78e2019-05-06 22:41:05 +00001852 print(e, file=sys.stderr)
1853 print('Maybe your depot_tools is out of date?', file=sys.stderr)
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001854 return 2
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001855
1856
1857if __name__ == '__main__':
maruel@chromium.org35625c72011-03-23 17:34:02 +00001858 fix_encoding.fix_encoding()
sbc@chromium.org013731e2015-02-26 18:28:43 +00001859 try:
1860 sys.exit(main())
1861 except KeyboardInterrupt:
1862 sys.stderr.write('interrupted\n')
sergiybf8a3b382016-07-05 11:21:30 -07001863 sys.exit(2)