blob: a2695cf7962cc78aab3ad379ce6edfbe544d44ef [file] [log] [blame]
Edward Lesmes365720e2019-07-25 20:51:36 +00001#!/usr/bin/env python
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +02002# Copyright (c) 2013 The Chromium Authors. All rights reserved.
maruel@chromium.org725f1c32011-04-01 20:24:54 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00006# Copyright (C) 2008 Evan Martin <martine@danga.com>
7
Andrii Shyshkalov03da1502018-10-15 03:42:34 +00008"""A git-command for integrating reviews on Gerrit."""
maruel@chromium.org725f1c32011-04-01 20:24:54 +00009
vapiera7fbd5a2016-06-16 09:17:49 -070010from __future__ import print_function
11
tapted@chromium.org6a0b07c2013-07-10 01:29:19 +000012from distutils.version import LooseVersion
calamity@chromium.orgffde55c2015-03-12 00:44:17 +000013from multiprocessing.pool import ThreadPool
thakis@chromium.org3421c992014-11-02 02:20:32 +000014import base64
rmistry@google.com2dd99862015-06-22 12:22:18 +000015import collections
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +010016import contextlib
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +010017import datetime
Andrii Shyshkalovcd6a9362016-12-07 12:04:12 +010018import fnmatch
sheyang@google.com6ebaf782015-05-12 19:17:54 +000019import httplib
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +010020import itertools
maruel@chromium.org4f6852c2012-04-20 20:39:20 +000021import json
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000022import logging
calamity@chromium.orgcf197482016-04-29 20:15:53 +000023import multiprocessing
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000024import optparse
25import os
26import re
Andrii Shyshkalov353637c2017-03-14 16:52:18 +010027import shutil
ukai@chromium.org78c4b982012-02-14 02:20:26 +000028import stat
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000029import sys
Aaron Gable9a03ae02017-11-03 11:31:07 -070030import tempfile
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000031import textwrap
Edward Lemurfec80c42018-11-01 23:14:14 +000032import time
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +000033import urllib
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000034import urllib2
maruel@chromium.org967c0a82013-06-17 22:52:24 +000035import urlparse
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +000036import uuid
thestig@chromium.org00858c82013-12-02 23:08:03 +000037import webbrowser
thakis@chromium.org3421c992014-11-02 02:20:32 +000038import zlib
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000039
maruel@chromium.org2e23ce32013-05-07 12:42:28 +000040from third_party import colorama
sheyang@google.com6ebaf782015-05-12 19:17:54 +000041from third_party import httplib2
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +000042import auth
skobes6468b902016-10-24 08:45:10 -070043import checkout
nick@chromium.org3ac1c4e2014-01-16 02:44:42 +000044import clang_format
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +000045import dart_format
iannucci@chromium.org596cd5c2016-04-04 21:34:39 +000046import setup_color
maruel@chromium.org6f09cd92011-04-01 16:38:12 +000047import fix_encoding
maruel@chromium.org0e0436a2011-10-25 13:32:41 +000048import gclient_utils
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +000049import gerrit_util
szager@chromium.org151ebcf2016-03-09 01:08:25 +000050import git_cache
iannucci@chromium.org9e849272014-04-04 00:31:55 +000051import git_common
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +000052import git_footers
Edward Lemur5ba1e9c2018-07-23 18:19:02 +000053import metrics
Edward Lesmes93277a72018-10-18 22:04:26 +000054import metrics_utils
piman@chromium.org336f9122014-09-04 02:16:55 +000055import owners
iannucci@chromium.org9e849272014-04-04 00:31:55 +000056import owners_finder
maruel@chromium.org2a74d372011-03-29 19:05:50 +000057import presubmit_support
58import scm
Francois Dorayd42c6812017-05-30 15:10:20 -040059import split_cl
maruel@chromium.org0633fb42013-08-16 20:06:14 +000060import subcommand
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +000061import subprocess2
maruel@chromium.org2a74d372011-03-29 19:05:50 +000062import watchlists
63
tandrii7400cf02016-06-21 08:48:07 -070064__version__ = '2.0'
maruel@chromium.org2a74d372011-03-29 19:05:50 +000065
Edward Lemur0f58ae42019-04-30 17:24:12 +000066# Traces for git push will be stored in a traces directory inside the
67# depot_tools checkout.
68DEPOT_TOOLS = os.path.dirname(os.path.abspath(__file__))
69TRACES_DIR = os.path.join(DEPOT_TOOLS, 'traces')
70
71# When collecting traces, Git hashes will be reduced to 6 characters to reduce
72# the size after compression.
73GIT_HASH_RE = re.compile(r'\b([a-f0-9]{6})[a-f0-9]{34}\b', flags=re.I)
74# Used to redact the cookies from the gitcookies file.
75GITCOOKIES_REDACT_RE = re.compile(r'1/.*')
76
Edward Lemur1b52d872019-05-09 21:12:12 +000077# The maximum number of traces we will keep. Multiplied by 3 since we store
78# 3 files per trace.
79MAX_TRACES = 3 * 10
Edward Lemur5737f022019-05-17 01:24:00 +000080# Message to be displayed to the user to inform where to find the traces for a
81# git-cl upload execution.
Edward Lemur0f58ae42019-04-30 17:24:12 +000082TRACES_MESSAGE = (
Edward Lemur1b52d872019-05-09 21:12:12 +000083'\n'
Edward Lemur5737f022019-05-17 01:24:00 +000084'The traces of this git-cl execution have been recorded at:\n'
Edward Lemur1b52d872019-05-09 21:12:12 +000085' %(trace_name)s-traces.zip\n'
Edward Lemur5737f022019-05-17 01:24:00 +000086'Copies of your gitcookies file and git config have been recorded at:\n'
87' %(trace_name)s-git-info.zip\n')
Edward Lemur1b52d872019-05-09 21:12:12 +000088# Format of the message to be stored as part of the traces to give developers a
89# better context when they go through traces.
90TRACES_README_FORMAT = (
91'Date: %(now)s\n'
92'\n'
93'Change: https://%(gerrit_host)s/q/%(change_id)s\n'
94'Title: %(title)s\n'
95'\n'
96'%(description)s\n'
97'\n'
98'Execution time: %(execution_time)s\n'
99'Exit code: %(exit_code)s\n') + TRACES_MESSAGE
Edward Lemur0f58ae42019-04-30 17:24:12 +0000100
tandrii9d2c7a32016-06-22 03:42:45 -0700101COMMIT_BOT_EMAIL = 'commit-bot@chromium.org'
Aaron Gable1bc7bfe2016-12-19 10:08:14 -0800102POSTUPSTREAM_HOOK = '.git/hooks/post-cl-land'
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000103DESCRIPTION_BACKUP_FILE = '~/.git_cl_description_backup'
rmistry@google.comc68112d2015-03-03 12:48:06 +0000104REFS_THAT_ALIAS_TO_OTHER_REFS = {
105 'refs/remotes/origin/lkgr': 'refs/remotes/origin/master',
106 'refs/remotes/origin/lkcr': 'refs/remotes/origin/master',
107}
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000108
thestig@chromium.org44202a22014-03-11 19:22:18 +0000109# Valid extensions for files we want to lint.
110DEFAULT_LINT_REGEX = r"(.*\.cpp|.*\.cc|.*\.h)"
111DEFAULT_LINT_IGNORE_REGEX = r"$^"
112
Aiden Bennerc08566e2018-10-03 17:52:42 +0000113# File name for yapf style config files.
114YAPF_CONFIG_FILENAME = '.style.yapf'
115
borenet6c0efe62016-10-19 08:13:29 -0700116# Buildbucket master name prefix.
117MASTER_PREFIX = 'master.'
118
maruel@chromium.org2e23ce32013-05-07 12:42:28 +0000119# Shortcut since it quickly becomes redundant.
120Fore = colorama.Fore
maruel@chromium.org90541732011-04-01 17:54:18 +0000121
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000122# Initialized in main()
123settings = None
124
Andrii Shyshkalov768f1d82016-12-08 15:10:13 +0100125# Used by tests/git_cl_test.py to add extra logging.
126# Inside the weirdly failing test, add this:
127# >>> self.mock(git_cl, '_IS_BEING_TESTED', True)
Quinten Yearsley0c62da92017-05-31 13:39:42 -0700128# And scroll up to see the stack trace printed.
Andrii Shyshkalov768f1d82016-12-08 15:10:13 +0100129_IS_BEING_TESTED = False
130
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000131
Christopher Lamf732cd52017-01-24 12:40:11 +1100132def DieWithError(message, change_desc=None):
133 if change_desc:
134 SaveDescriptionBackup(change_desc)
135
vapiera7fbd5a2016-06-16 09:17:49 -0700136 print(message, file=sys.stderr)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000137 sys.exit(1)
138
139
Christopher Lamf732cd52017-01-24 12:40:11 +1100140def SaveDescriptionBackup(change_desc):
141 backup_path = os.path.expanduser(DESCRIPTION_BACKUP_FILE)
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000142 print('\nsaving CL description to %s\n' % backup_path)
Christopher Lamf732cd52017-01-24 12:40:11 +1100143 backup_file = open(backup_path, 'w')
144 backup_file.write(change_desc.description)
145 backup_file.close()
146
147
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000148def GetNoGitPagerEnv():
149 env = os.environ.copy()
150 # 'cat' is a magical git string that disables pagers on all platforms.
151 env['GIT_PAGER'] = 'cat'
152 return env
153
vadimsh@chromium.org566a02a2014-08-22 01:34:13 +0000154
bsep@chromium.org627d9002016-04-29 00:00:52 +0000155def RunCommand(args, error_ok=False, error_message=None, shell=False, **kwargs):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000156 try:
bsep@chromium.org627d9002016-04-29 00:00:52 +0000157 return subprocess2.check_output(args, shell=shell, **kwargs)
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000158 except subprocess2.CalledProcessError as e:
159 logging.debug('Failed running %s', args)
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +0000160 if not error_ok:
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000161 DieWithError(
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +0000162 'Command "%s" failed.\n%s' % (
163 ' '.join(args), error_message or e.stdout or ''))
164 return e.stdout
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000165
166
167def RunGit(args, **kwargs):
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +0000168 """Returns stdout."""
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000169 return RunCommand(['git'] + args, **kwargs)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000170
171
enne@chromium.org3b7e15c2014-01-21 17:44:47 +0000172def RunGitWithCode(args, suppress_stderr=False):
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +0000173 """Returns return code and stdout."""
tandrii5d48c322016-08-18 16:19:37 -0700174 if suppress_stderr:
175 stderr = subprocess2.VOID
176 else:
177 stderr = sys.stderr
szager@chromium.org9bb85e22012-06-13 20:28:23 +0000178 try:
tandrii5d48c322016-08-18 16:19:37 -0700179 (out, _), code = subprocess2.communicate(['git'] + args,
180 env=GetNoGitPagerEnv(),
181 stdout=subprocess2.PIPE,
182 stderr=stderr)
183 return code, out
184 except subprocess2.CalledProcessError as e:
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +0900185 logging.debug('Failed running %s', ['git'] + args)
tandrii5d48c322016-08-18 16:19:37 -0700186 return e.returncode, e.stdout
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000187
188
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000189def RunGitSilent(args):
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +0000190 """Returns stdout, suppresses stderr and ignores the return code."""
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000191 return RunGitWithCode(args, suppress_stderr=True)[1]
192
193
tapted@chromium.org6a0b07c2013-07-10 01:29:19 +0000194def IsGitVersionAtLeast(min_version):
ilevy@chromium.orgcc56ee42013-07-10 22:16:29 +0000195 prefix = 'git version '
tapted@chromium.org6a0b07c2013-07-10 01:29:19 +0000196 version = RunGit(['--version']).strip()
ilevy@chromium.orgcc56ee42013-07-10 22:16:29 +0000197 return (version.startswith(prefix) and
198 LooseVersion(version[len(prefix):]) >= LooseVersion(min_version))
tapted@chromium.org6a0b07c2013-07-10 01:29:19 +0000199
200
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +0000201def BranchExists(branch):
202 """Return True if specified branch exists."""
203 code, _ = RunGitWithCode(['rev-parse', '--verify', branch],
204 suppress_stderr=True)
205 return not code
206
207
tandrii2a16b952016-10-19 07:09:44 -0700208def time_sleep(seconds):
209 # Use this so that it can be mocked in tests without interfering with python
210 # system machinery.
tandrii2a16b952016-10-19 07:09:44 -0700211 return time.sleep(seconds)
212
213
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000214def time_time():
215 # Use this so that it can be mocked in tests without interfering with python
216 # system machinery.
217 return time.time()
218
219
Edward Lemur1b52d872019-05-09 21:12:12 +0000220def datetime_now():
221 # Use this so that it can be mocked in tests without interfering with python
222 # system machinery.
223 return datetime.datetime.now()
224
225
maruel@chromium.org90541732011-04-01 17:54:18 +0000226def ask_for_data(prompt):
227 try:
228 return raw_input(prompt)
229 except KeyboardInterrupt:
230 # Hide the exception.
231 sys.exit(1)
232
233
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100234def confirm_or_exit(prefix='', action='confirm'):
235 """Asks user to press enter to continue or press Ctrl+C to abort."""
236 if not prefix or prefix.endswith('\n'):
237 mid = 'Press'
Andrii Shyshkalov353637c2017-03-14 16:52:18 +0100238 elif prefix.endswith('.') or prefix.endswith('?'):
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100239 mid = ' Press'
240 elif prefix.endswith(' '):
241 mid = 'press'
242 else:
243 mid = ' press'
244 ask_for_data('%s%s Enter to %s, or Ctrl+C to abort' % (prefix, mid, action))
245
246
247def ask_for_explicit_yes(prompt):
Quinten Yearsleyd242ed72019-07-25 17:17:55 +0000248 """Returns whether user typed 'y' or 'yes' to confirm the given prompt."""
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100249 result = ask_for_data(prompt + ' [Yes/No]: ').lower()
250 while True:
251 if 'yes'.startswith(result):
252 return True
253 if 'no'.startswith(result):
254 return False
255 result = ask_for_data('Please, type yes or no: ').lower()
256
257
tandrii5d48c322016-08-18 16:19:37 -0700258def _git_branch_config_key(branch, key):
259 """Helper method to return Git config key for a branch."""
260 assert branch, 'branch name is required to set git config for it'
261 return 'branch.%s.%s' % (branch, key)
262
263
264def _git_get_branch_config_value(key, default=None, value_type=str,
265 branch=False):
266 """Returns git config value of given or current branch if any.
267
268 Returns default in all other cases.
269 """
270 assert value_type in (int, str, bool)
271 if branch is False: # Distinguishing default arg value from None.
272 branch = GetCurrentBranch()
273
rogerta@chromium.orgcaa16552013-03-18 20:45:05 +0000274 if not branch:
tandrii5d48c322016-08-18 16:19:37 -0700275 return default
rogerta@chromium.orgcaa16552013-03-18 20:45:05 +0000276
tandrii5d48c322016-08-18 16:19:37 -0700277 args = ['config']
tandrii33a46ff2016-08-23 05:53:40 -0700278 if value_type == bool:
tandrii5d48c322016-08-18 16:19:37 -0700279 args.append('--bool')
tandrii33a46ff2016-08-23 05:53:40 -0700280 # git config also has --int, but apparently git config suffers from integer
281 # overflows (http://crbug.com/640115), so don't use it.
tandrii5d48c322016-08-18 16:19:37 -0700282 args.append(_git_branch_config_key(branch, key))
283 code, out = RunGitWithCode(args)
284 if code == 0:
285 value = out.strip()
286 if value_type == int:
287 return int(value)
288 if value_type == bool:
289 return bool(value.lower() == 'true')
290 return value
iannucci@chromium.org79540052012-10-19 23:15:26 +0000291 return default
292
293
tandrii5d48c322016-08-18 16:19:37 -0700294def _git_set_branch_config_value(key, value, branch=None, **kwargs):
Quinten Yearsleyd242ed72019-07-25 17:17:55 +0000295 """Sets or unsets the git branch config value.
tandrii5d48c322016-08-18 16:19:37 -0700296
Quinten Yearsleyd242ed72019-07-25 17:17:55 +0000297 If value is None, the key will be unset, otherwise it will be set.
298 If no branch is given, the currently checked out branch is used.
tandrii5d48c322016-08-18 16:19:37 -0700299 """
300 if not branch:
301 branch = GetCurrentBranch()
302 assert branch, 'a branch name OR currently checked out branch is required'
303 args = ['config']
qyearsley12fa6ff2016-08-24 09:18:40 -0700304 # Check for boolean first, because bool is int, but int is not bool.
tandrii5d48c322016-08-18 16:19:37 -0700305 if value is None:
306 args.append('--unset')
307 elif isinstance(value, bool):
308 args.append('--bool')
309 value = str(value).lower()
tandrii5d48c322016-08-18 16:19:37 -0700310 else:
tandrii33a46ff2016-08-23 05:53:40 -0700311 # git config also has --int, but apparently git config suffers from integer
312 # overflows (http://crbug.com/640115), so don't use it.
tandrii5d48c322016-08-18 16:19:37 -0700313 value = str(value)
314 args.append(_git_branch_config_key(branch, key))
315 if value is not None:
316 args.append(value)
317 RunGit(args, **kwargs)
318
319
Andrii Shyshkalova6695812016-12-06 17:47:09 +0100320def _get_committer_timestamp(commit):
Quinten Yearsley0c62da92017-05-31 13:39:42 -0700321 """Returns Unix timestamp as integer of a committer in a commit.
Andrii Shyshkalova6695812016-12-06 17:47:09 +0100322
323 Commit can be whatever git show would recognize, such as HEAD, sha1 or ref.
324 """
325 # Git also stores timezone offset, but it only affects visual display,
326 # actual point in time is defined by this timestamp only.
327 return int(RunGit(['show', '-s', '--format=%ct', commit]).strip())
328
329
330def _git_amend_head(message, committer_timestamp):
331 """Amends commit with new message and desired committer_timestamp.
332
333 Sets committer timezone to UTC.
334 """
335 env = os.environ.copy()
336 env['GIT_COMMITTER_DATE'] = '%d+0000' % committer_timestamp
337 return RunGit(['commit', '--amend', '-m', message], env=env)
338
339
machenbach@chromium.org45453142015-09-15 08:45:22 +0000340def _get_properties_from_options(options):
341 properties = dict(x.split('=', 1) for x in options.properties)
342 for key, val in properties.iteritems():
343 try:
344 properties[key] = json.loads(val)
345 except ValueError:
346 pass # If a value couldn't be evaluated, treat it as a string.
347 return properties
348
349
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000350def _prefix_master(master):
351 """Convert user-specified master name to full master name.
352
353 Buildbucket uses full master name(master.tryserver.chromium.linux) as bucket
354 name, while the developers always use shortened master name
355 (tryserver.chromium.linux) by stripping off the prefix 'master.'. This
356 function does the conversion for buildbucket migration.
357 """
borenet6c0efe62016-10-19 08:13:29 -0700358 if master.startswith(MASTER_PREFIX):
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000359 return master
borenet6c0efe62016-10-19 08:13:29 -0700360 return '%s%s' % (MASTER_PREFIX, master)
361
362
363def _unprefix_master(bucket):
364 """Convert bucket name to shortened master name.
365
366 Buildbucket uses full master name(master.tryserver.chromium.linux) as bucket
367 name, while the developers always use shortened master name
368 (tryserver.chromium.linux) by stripping off the prefix 'master.'. This
369 function does the conversion for buildbucket migration.
370 """
371 if bucket.startswith(MASTER_PREFIX):
372 return bucket[len(MASTER_PREFIX):]
373 return bucket
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000374
375
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000376def _buildbucket_retry(operation_name, http, *args, **kwargs):
377 """Retries requests to buildbucket service and returns parsed json content."""
378 try_count = 0
379 while True:
380 response, content = http.request(*args, **kwargs)
381 try:
382 content_json = json.loads(content)
383 except ValueError:
384 content_json = None
385
386 # Buildbucket could return an error even if status==200.
387 if content_json and content_json.get('error'):
nodir@chromium.orgbaff4e12016-03-08 00:33:57 +0000388 error = content_json.get('error')
389 if error.get('code') == 403:
390 raise BuildbucketResponseException(
391 'Access denied: %s' % error.get('message', ''))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000392 msg = 'Error in response. Reason: %s. Message: %s.' % (
nodir@chromium.orgbaff4e12016-03-08 00:33:57 +0000393 error.get('reason', ''), error.get('message', ''))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000394 raise BuildbucketResponseException(msg)
395
396 if response.status == 200:
Nodir Turakulov23d75d22018-06-04 12:37:32 -0700397 if content_json is None:
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000398 raise BuildbucketResponseException(
399 'Buildbucket returns invalid json content: %s.\n'
Nodir Turakulov9ac59792018-06-04 12:34:14 -0700400 'Please file bugs at http://crbug.com, '
401 'component "Infra>Platform>BuildBucket".' %
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000402 content)
403 return content_json
404 if response.status < 500 or try_count >= 2:
405 raise httplib2.HttpLib2Error(content)
406
407 # status >= 500 means transient failures.
408 logging.debug('Transient errors when %s. Will retry.', operation_name)
tandrii2a16b952016-10-19 07:09:44 -0700409 time_sleep(0.5 + 1.5*try_count)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000410 try_count += 1
411 assert False, 'unreachable'
412
413
qyearsley1fdfcb62016-10-24 13:22:03 -0700414def _get_bucket_map(changelist, options, option_parser):
qyearsleydd49f942016-10-28 11:57:22 -0700415 """Returns a dict mapping bucket names to builders and tests,
416 for triggering try jobs.
qyearsley1fdfcb62016-10-24 13:22:03 -0700417 """
qyearsleydd49f942016-10-28 11:57:22 -0700418 # If no bots are listed, we try to get a set of builders and tests based
419 # on GetPreferredTryMasters functions in PRESUBMIT.py files.
qyearsley1fdfcb62016-10-24 13:22:03 -0700420 if not options.bot:
421 change = changelist.GetChange(
422 changelist.GetCommonAncestorWithUpstream(), None)
qyearsley136b49f2016-10-31 09:02:26 -0700423 # Get try masters from PRESUBMIT.py files.
nodire4f0fe02016-11-04 16:23:30 -0700424 masters = presubmit_support.DoGetTryMasters(
qyearsley1fdfcb62016-10-24 13:22:03 -0700425 change=change,
426 changed_files=change.LocalPaths(),
427 repository_root=settings.GetRoot(),
428 default_presubmit=None,
429 project=None,
430 verbose=options.verbose,
431 output_stream=sys.stdout)
nodire4f0fe02016-11-04 16:23:30 -0700432 if masters is None:
433 return None
Sergiy Byelozyorov935b93f2016-11-28 20:41:56 +0100434 return {_prefix_master(m): b for m, b in masters.iteritems()}
qyearsley1fdfcb62016-10-24 13:22:03 -0700435
qyearsley1fdfcb62016-10-24 13:22:03 -0700436 if options.bucket:
437 return {options.bucket: {b: [] for b in options.bot}}
qyearsleydd49f942016-10-28 11:57:22 -0700438 if options.master:
439 return {_prefix_master(options.master): {b: [] for b in options.bot}}
qyearsley1fdfcb62016-10-24 13:22:03 -0700440
qyearsleydd49f942016-10-28 11:57:22 -0700441 # If bots are listed but no master or bucket, then we need to find out
442 # the corresponding master for each bot.
443 bucket_map, error_message = _get_bucket_map_for_builders(options.bot)
444 if error_message:
445 option_parser.error(
446 'Tryserver master cannot be found because: %s\n'
447 'Please manually specify the tryserver master, e.g. '
448 '"-m tryserver.chromium.linux".' % error_message)
449 return bucket_map
qyearsley1fdfcb62016-10-24 13:22:03 -0700450
451
qyearsley123a4682016-10-26 09:12:17 -0700452def _get_bucket_map_for_builders(builders):
453 """Returns a map of buckets to builders for the given builders."""
qyearsley1fdfcb62016-10-24 13:22:03 -0700454 map_url = 'https://builders-map.appspot.com/'
455 try:
qyearsley123a4682016-10-26 09:12:17 -0700456 builders_map = json.load(urllib2.urlopen(map_url))
qyearsley1fdfcb62016-10-24 13:22:03 -0700457 except urllib2.URLError as e:
458 return None, ('Failed to fetch builder-to-master map from %s. Error: %s.' %
459 (map_url, e))
460 except ValueError as e:
461 return None, ('Invalid json string from %s. Error: %s.' % (map_url, e))
qyearsley123a4682016-10-26 09:12:17 -0700462 if not builders_map:
qyearsley1fdfcb62016-10-24 13:22:03 -0700463 return None, 'Failed to build master map.'
464
qyearsley123a4682016-10-26 09:12:17 -0700465 bucket_map = {}
466 for builder in builders:
Nodir Turakulovb422e682018-02-20 22:51:30 -0800467 bucket = builders_map.get(builder, {}).get('bucket')
468 if bucket:
469 bucket_map.setdefault(bucket, {})[builder] = []
qyearsley123a4682016-10-26 09:12:17 -0700470 return bucket_map, None
qyearsley1fdfcb62016-10-24 13:22:03 -0700471
472
Andrii Shyshkalovf9648b52018-02-21 22:32:42 -0800473def _trigger_try_jobs(auth_config, changelist, buckets, options, patchset):
qyearsley1fdfcb62016-10-24 13:22:03 -0700474 """Sends a request to Buildbucket to trigger try jobs for a changelist.
475
476 Args:
Aaron Gablefb28d482018-04-02 13:08:06 -0700477 auth_config: AuthConfig for Buildbucket.
qyearsley1fdfcb62016-10-24 13:22:03 -0700478 changelist: Changelist that the try jobs are associated with.
479 buckets: A nested dict mapping bucket names to builders to tests.
480 options: Command-line options.
481 """
tandriide281ae2016-10-12 06:02:30 -0700482 assert changelist.GetIssue(), 'CL must be uploaded first'
483 codereview_url = changelist.GetCodereviewServer()
484 assert codereview_url, 'CL must be uploaded first'
485 patchset = patchset or changelist.GetMostRecentPatchset()
486 assert patchset, 'CL must be uploaded first'
487
488 codereview_host = urlparse.urlparse(codereview_url).hostname
Aaron Gablefb28d482018-04-02 13:08:06 -0700489 # Cache the buildbucket credentials under the codereview host key, so that
490 # users can use different credentials for different buckets.
tandriide281ae2016-10-12 06:02:30 -0700491 authenticator = auth.get_authenticator_for_host(codereview_host, auth_config)
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000492 http = authenticator.authorize(httplib2.Http())
493 http.force_exception_to_status_code = True
tandriide281ae2016-10-12 06:02:30 -0700494
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000495 buildbucket_put_url = (
496 'https://{hostname}/_ah/api/buildbucket/v1/builds/batch'.format(
sheyang@chromium.orgdb375572015-08-17 19:22:23 +0000497 hostname=options.buildbucket_host))
Andrii Shyshkalov03da1502018-10-15 03:42:34 +0000498 buildset = 'patch/gerrit/{hostname}/{issue}/{patch}'.format(
tandriide281ae2016-10-12 06:02:30 -0700499 hostname=codereview_host,
500 issue=changelist.GetIssue(),
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000501 patch=patchset)
tandrii8c5a3532016-11-04 07:52:02 -0700502
Quinten Yearsley0c62da92017-05-31 13:39:42 -0700503 shared_parameters_properties = changelist.GetTryJobProperties(patchset)
Andrii Shyshkalovf9648b52018-02-21 22:32:42 -0800504 shared_parameters_properties['category'] = options.category
tandrii8c5a3532016-11-04 07:52:02 -0700505 if options.clobber:
506 shared_parameters_properties['clobber'] = True
tandriide281ae2016-10-12 06:02:30 -0700507 extra_properties = _get_properties_from_options(options)
tandrii8c5a3532016-11-04 07:52:02 -0700508 if extra_properties:
509 shared_parameters_properties.update(extra_properties)
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000510
511 batch_req_body = {'builds': []}
512 print_text = []
513 print_text.append('Tried jobs on:')
borenet6c0efe62016-10-19 08:13:29 -0700514 for bucket, builders_and_tests in sorted(buckets.iteritems()):
515 print_text.append('Bucket: %s' % bucket)
516 master = None
517 if bucket.startswith(MASTER_PREFIX):
518 master = _unprefix_master(bucket)
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000519 for builder, tests in sorted(builders_and_tests.iteritems()):
520 print_text.append(' %s: %s' % (builder, tests))
521 parameters = {
522 'builder_name': builder,
nodir@chromium.orgd2217312015-09-21 15:51:21 +0000523 'changes': [{
Andrii Shyshkaloveadad922017-01-26 09:38:30 +0100524 'author': {'email': changelist.GetIssueOwner()},
nodir@chromium.orgd2217312015-09-21 15:51:21 +0000525 'revision': options.revision,
526 }],
tandrii8c5a3532016-11-04 07:52:02 -0700527 'properties': shared_parameters_properties.copy(),
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000528 }
machenbach@chromium.org2403e802016-04-29 12:34:42 +0000529 if 'presubmit' in builder.lower():
530 parameters['properties']['dry_run'] = 'true'
tandrii@chromium.org3764fa22015-10-21 16:40:40 +0000531 if tests:
532 parameters['properties']['testfilter'] = tests
borenet6c0efe62016-10-19 08:13:29 -0700533
534 tags = [
535 'builder:%s' % builder,
536 'buildset:%s' % buildset,
537 'user_agent:git_cl_try',
538 ]
539 if master:
540 parameters['properties']['master'] = master
541 tags.append('master:%s' % master)
542
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000543 batch_req_body['builds'].append(
544 {
545 'bucket': bucket,
546 'parameters_json': json.dumps(parameters),
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000547 'client_operation_id': str(uuid.uuid4()),
borenet6c0efe62016-10-19 08:13:29 -0700548 'tags': tags,
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000549 }
550 )
551
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000552 _buildbucket_retry(
qyearsleyeab3c042016-08-24 09:18:28 -0700553 'triggering try jobs',
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000554 http,
555 buildbucket_put_url,
556 'PUT',
557 body=json.dumps(batch_req_body),
558 headers={'Content-Type': 'application/json'}
559 )
tandrii@chromium.org35c61452016-02-26 15:24:57 +0000560 print_text.append('To see results here, run: git cl try-results')
561 print_text.append('To see results in browser, run: git cl web')
vapiera7fbd5a2016-06-16 09:17:49 -0700562 print('\n'.join(print_text))
kjellander@chromium.org44424542015-06-02 18:35:29 +0000563
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000564
tandrii221ab252016-10-06 08:12:04 -0700565def fetch_try_jobs(auth_config, changelist, buildbucket_host,
566 patchset=None):
qyearsleyeab3c042016-08-24 09:18:28 -0700567 """Fetches try jobs from buildbucket.
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000568
qyearsley53f48a12016-09-01 10:45:13 -0700569 Returns a map from build id to build info as a dictionary.
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000570 """
tandrii221ab252016-10-06 08:12:04 -0700571 assert buildbucket_host
572 assert changelist.GetIssue(), 'CL must be uploaded first'
573 assert changelist.GetCodereviewServer(), 'CL must be uploaded first'
574 patchset = patchset or changelist.GetMostRecentPatchset()
575 assert patchset, 'CL must be uploaded first'
576
577 codereview_url = changelist.GetCodereviewServer()
578 codereview_host = urlparse.urlparse(codereview_url).hostname
579 authenticator = auth.get_authenticator_for_host(codereview_host, auth_config)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000580 if authenticator.has_cached_credentials():
581 http = authenticator.authorize(httplib2.Http())
582 else:
vapiera7fbd5a2016-06-16 09:17:49 -0700583 print('Warning: Some results might be missing because %s' %
584 # Get the message on how to login.
tandrii221ab252016-10-06 08:12:04 -0700585 (auth.LoginRequiredError(codereview_host).message,))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000586 http = httplib2.Http()
587
588 http.force_exception_to_status_code = True
589
Andrii Shyshkalov03da1502018-10-15 03:42:34 +0000590 buildset = 'patch/gerrit/{hostname}/{issue}/{patch}'.format(
tandrii221ab252016-10-06 08:12:04 -0700591 hostname=codereview_host,
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000592 issue=changelist.GetIssue(),
tandrii221ab252016-10-06 08:12:04 -0700593 patch=patchset)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000594 params = {'tag': 'buildset:%s' % buildset}
595
596 builds = {}
597 while True:
598 url = 'https://{hostname}/_ah/api/buildbucket/v1/search?{params}'.format(
tandrii221ab252016-10-06 08:12:04 -0700599 hostname=buildbucket_host,
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000600 params=urllib.urlencode(params))
qyearsleyeab3c042016-08-24 09:18:28 -0700601 content = _buildbucket_retry('fetching try jobs', http, url, 'GET')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000602 for build in content.get('builds', []):
603 builds[build['id']] = build
604 if 'next_cursor' in content:
605 params['start_cursor'] = content['next_cursor']
606 else:
607 break
608 return builds
609
610
qyearsleyeab3c042016-08-24 09:18:28 -0700611def print_try_jobs(options, builds):
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000612 """Prints nicely result of fetch_try_jobs."""
613 if not builds:
Quinten Yearsley0c62da92017-05-31 13:39:42 -0700614 print('No try jobs scheduled.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000615 return
616
617 # Make a copy, because we'll be modifying builds dictionary.
618 builds = builds.copy()
619 builder_names_cache = {}
620
621 def get_builder(b):
622 try:
623 return builder_names_cache[b['id']]
624 except KeyError:
625 try:
626 parameters = json.loads(b['parameters_json'])
627 name = parameters['builder_name']
628 except (ValueError, KeyError) as error:
Quinten Yearsley0c62da92017-05-31 13:39:42 -0700629 print('WARNING: Failed to get builder name for build %s: %s' % (
vapiera7fbd5a2016-06-16 09:17:49 -0700630 b['id'], error))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000631 name = None
632 builder_names_cache[b['id']] = name
633 return name
634
635 def get_bucket(b):
636 bucket = b['bucket']
637 if bucket.startswith('master.'):
638 return bucket[len('master.'):]
639 return bucket
640
641 if options.print_master:
642 name_fmt = '%%-%ds %%-%ds' % (
643 max(len(str(get_bucket(b))) for b in builds.itervalues()),
644 max(len(str(get_builder(b))) for b in builds.itervalues()))
645 def get_name(b):
646 return name_fmt % (get_bucket(b), get_builder(b))
647 else:
648 name_fmt = '%%-%ds' % (
649 max(len(str(get_builder(b))) for b in builds.itervalues()))
650 def get_name(b):
651 return name_fmt % get_builder(b)
652
653 def sort_key(b):
654 return b['status'], b.get('result'), get_name(b), b.get('url')
655
656 def pop(title, f, color=None, **kwargs):
657 """Pop matching builds from `builds` dict and print them."""
658
tandrii@chromium.org6cf98c82016-03-15 11:56:00 +0000659 if not options.color or color is None:
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000660 colorize = str
661 else:
662 colorize = lambda x: '%s%s%s' % (color, x, Fore.RESET)
663
664 result = []
665 for b in builds.values():
666 if all(b.get(k) == v for k, v in kwargs.iteritems()):
667 builds.pop(b['id'])
668 result.append(b)
669 if result:
vapiera7fbd5a2016-06-16 09:17:49 -0700670 print(colorize(title))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000671 for b in sorted(result, key=sort_key):
vapiera7fbd5a2016-06-16 09:17:49 -0700672 print(' ', colorize('\t'.join(map(str, f(b)))))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000673
674 total = len(builds)
675 pop(status='COMPLETED', result='SUCCESS',
676 title='Successes:', color=Fore.GREEN,
677 f=lambda b: (get_name(b), b.get('url')))
678 pop(status='COMPLETED', result='FAILURE', failure_reason='INFRA_FAILURE',
679 title='Infra Failures:', color=Fore.MAGENTA,
680 f=lambda b: (get_name(b), b.get('url')))
681 pop(status='COMPLETED', result='FAILURE', failure_reason='BUILD_FAILURE',
682 title='Failures:', color=Fore.RED,
683 f=lambda b: (get_name(b), b.get('url')))
684 pop(status='COMPLETED', result='CANCELED',
685 title='Canceled:', color=Fore.MAGENTA,
686 f=lambda b: (get_name(b),))
687 pop(status='COMPLETED', result='FAILURE',
688 failure_reason='INVALID_BUILD_DEFINITION',
689 title='Wrong master/builder name:', color=Fore.MAGENTA,
690 f=lambda b: (get_name(b),))
691 pop(status='COMPLETED', result='FAILURE',
692 title='Other failures:',
693 f=lambda b: (get_name(b), b.get('failure_reason'), b.get('url')))
694 pop(status='COMPLETED',
695 title='Other finished:',
696 f=lambda b: (get_name(b), b.get('result'), b.get('url')))
697 pop(status='STARTED',
698 title='Started:', color=Fore.YELLOW,
699 f=lambda b: (get_name(b), b.get('url')))
700 pop(status='SCHEDULED',
701 title='Scheduled:',
702 f=lambda b: (get_name(b), 'id=%s' % b['id']))
703 # The last section is just in case buildbucket API changes OR there is a bug.
704 pop(title='Other:',
705 f=lambda b: (get_name(b), 'id=%s' % b['id']))
706 assert len(builds) == 0
qyearsleyeab3c042016-08-24 09:18:28 -0700707 print('Total: %d try jobs' % total)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000708
709
Aiden Bennerc08566e2018-10-03 17:52:42 +0000710def _ComputeDiffLineRanges(files, upstream_commit):
711 """Gets the changed line ranges for each file since upstream_commit.
712
713 Parses a git diff on provided files and returns a dict that maps a file name
714 to an ordered list of range tuples in the form (start_line, count).
715 Ranges are in the same format as a git diff.
716 """
717 # If files is empty then diff_output will be a full diff.
718 if len(files) == 0:
719 return {}
720
Aiden Benner6c18a1a2018-11-23 20:18:23 +0000721 # Take the git diff and find the line ranges where there are changes.
Aiden Bennerc08566e2018-10-03 17:52:42 +0000722 diff_cmd = BuildGitDiffCmd('-U0', upstream_commit, files, allow_prefix=True)
723 diff_output = RunGit(diff_cmd)
724
725 pattern = r'(?:^diff --git a/(?:.*) b/(.*))|(?:^@@.*\+(.*) @@)'
726 # 2 capture groups
727 # 0 == fname of diff file
728 # 1 == 'diff_start,diff_count' or 'diff_start'
729 # will match each of
730 # diff --git a/foo.foo b/foo.py
731 # @@ -12,2 +14,3 @@
732 # @@ -12,2 +17 @@
733 # running re.findall on the above string with pattern will give
734 # [('foo.py', ''), ('', '14,3'), ('', '17')]
735
736 curr_file = None
737 line_diffs = {}
738 for match in re.findall(pattern, diff_output, flags=re.MULTILINE):
739 if match[0] != '':
740 # Will match the second filename in diff --git a/a.py b/b.py.
741 curr_file = match[0]
742 line_diffs[curr_file] = []
743 else:
744 # Matches +14,3
745 if ',' in match[1]:
746 diff_start, diff_count = match[1].split(',')
747 else:
748 # Single line changes are of the form +12 instead of +12,1.
749 diff_start = match[1]
750 diff_count = 1
751
752 diff_start = int(diff_start)
753 diff_count = int(diff_count)
754
755 # If diff_count == 0 this is a removal we can ignore.
756 line_diffs[curr_file].append((diff_start, diff_count))
757
758 return line_diffs
759
760
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000761def _FindYapfConfigFile(fpath, yapf_config_cache, top_dir=None):
Aiden Bennerc08566e2018-10-03 17:52:42 +0000762 """Checks if a yapf file is in any parent directory of fpath until top_dir.
763
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000764 Recursively checks parent directories to find yapf file and if no yapf file
765 is found returns None. Uses yapf_config_cache as a cache for
766 previously found configs.
Aiden Bennerc08566e2018-10-03 17:52:42 +0000767 """
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000768 fpath = os.path.abspath(fpath)
Aiden Bennerc08566e2018-10-03 17:52:42 +0000769 # Return result if we've already computed it.
770 if fpath in yapf_config_cache:
771 return yapf_config_cache[fpath]
772
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000773 parent_dir = os.path.dirname(fpath)
774 if os.path.isfile(fpath):
775 ret = _FindYapfConfigFile(parent_dir, yapf_config_cache, top_dir)
Aiden Bennerc08566e2018-10-03 17:52:42 +0000776 else:
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000777 # Otherwise fpath is a directory
778 yapf_file = os.path.join(fpath, YAPF_CONFIG_FILENAME)
779 if os.path.isfile(yapf_file):
780 ret = yapf_file
781 elif fpath == top_dir or parent_dir == fpath:
782 # If we're at the top level directory, or if we're at root
783 # there is no provided style.
784 ret = None
785 else:
786 # Otherwise recurse on the current directory.
787 ret = _FindYapfConfigFile(parent_dir, yapf_config_cache, top_dir)
Aiden Bennerc08566e2018-10-03 17:52:42 +0000788 yapf_config_cache[fpath] = ret
789 return ret
790
791
qyearsley53f48a12016-09-01 10:45:13 -0700792def write_try_results_json(output_file, builds):
793 """Writes a subset of the data from fetch_try_jobs to a file as JSON.
794
795 The input |builds| dict is assumed to be generated by Buildbucket.
796 Buildbucket documentation: http://goo.gl/G0s101
797 """
798
799 def convert_build_dict(build):
Quinten Yearsleya563d722017-12-11 16:36:54 -0800800 """Extracts some of the information from one build dict."""
801 parameters = json.loads(build.get('parameters_json', '{}')) or {}
qyearsley53f48a12016-09-01 10:45:13 -0700802 return {
803 'buildbucket_id': build.get('id'),
qyearsley53f48a12016-09-01 10:45:13 -0700804 'bucket': build.get('bucket'),
Quinten Yearsleya563d722017-12-11 16:36:54 -0800805 'builder_name': parameters.get('builder_name'),
806 'created_ts': build.get('created_ts'),
807 'experimental': build.get('experimental'),
qyearsley53f48a12016-09-01 10:45:13 -0700808 'failure_reason': build.get('failure_reason'),
Quinten Yearsleya563d722017-12-11 16:36:54 -0800809 'result': build.get('result'),
810 'status': build.get('status'),
811 'tags': build.get('tags'),
qyearsley53f48a12016-09-01 10:45:13 -0700812 'url': build.get('url'),
813 }
814
815 converted = []
816 for _, build in sorted(builds.items()):
Aiden Bennerc08566e2018-10-03 17:52:42 +0000817 converted.append(convert_build_dict(build))
qyearsley53f48a12016-09-01 10:45:13 -0700818 write_json(output_file, converted)
819
820
Aaron Gable13101a62018-02-09 13:20:41 -0800821def print_stats(args):
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000822 """Prints statistics about the change to the user."""
823 # --no-ext-diff is broken in some versions of Git, so try to work around
824 # this by overriding the environment (but there is still a problem if the
825 # git config key "diff.external" is used).
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000826 env = GetNoGitPagerEnv()
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000827 if 'GIT_EXTERNAL_DIFF' in env:
828 del env['GIT_EXTERNAL_DIFF']
iannucci@chromium.org79540052012-10-19 23:15:26 +0000829
szager@chromium.orgd057f9a2014-05-29 21:09:36 +0000830 try:
831 stdout = sys.stdout.fileno()
832 except AttributeError:
833 stdout = None
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000834 return subprocess2.call(
Aaron Gable13101a62018-02-09 13:20:41 -0800835 ['git', 'diff', '--no-ext-diff', '--stat', '-l100000', '-C50'] + args,
szager@chromium.orgd057f9a2014-05-29 21:09:36 +0000836 stdout=stdout, env=env)
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000837
838
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000839class BuildbucketResponseException(Exception):
840 pass
841
842
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000843class Settings(object):
844 def __init__(self):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000845 self.cc = None
thestig@chromium.org7a54e812014-02-11 19:57:22 +0000846 self.root = None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000847 self.tree_status_url = None
848 self.viewvc_url = None
849 self.updated = False
ukai@chromium.orge8077812012-02-03 03:41:46 +0000850 self.is_gerrit = None
bauerb@chromium.org54b400c2016-01-14 10:08:25 +0000851 self.squash_gerrit_uploads = None
tandrii@chromium.org28253532016-04-14 13:46:56 +0000852 self.gerrit_skip_ensure_authenticated = None
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000853 self.git_editor = None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000854
855 def LazyUpdateIfNeeded(self):
856 """Updates the settings from a codereview.settings file, if available."""
857 if not self.updated:
pgervais@chromium.org87884cc2014-01-03 22:23:41 +0000858 # The only value that actually changes the behavior is
859 # autoupdate = "false". Everything else means "true".
nick@chromium.org3ac1c4e2014-01-16 02:44:42 +0000860 autoupdate = RunGit(['config', 'rietveld.autoupdate'],
pgervais@chromium.org87884cc2014-01-03 22:23:41 +0000861 error_ok=True
862 ).strip().lower()
863
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000864 cr_settings_file = FindCodereviewSettingsFile()
pgervais@chromium.org87884cc2014-01-03 22:23:41 +0000865 if autoupdate != 'false' and cr_settings_file:
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000866 LoadCodereviewSettingsFromFile(cr_settings_file)
867 self.updated = True
868
thestig@chromium.org7a54e812014-02-11 19:57:22 +0000869 @staticmethod
870 def GetRelativeRoot():
871 return RunGit(['rev-parse', '--show-cdup']).strip()
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000872
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000873 def GetRoot(self):
thestig@chromium.org7a54e812014-02-11 19:57:22 +0000874 if self.root is None:
875 self.root = os.path.abspath(self.GetRelativeRoot())
876 return self.root
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000877
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000878 def GetTreeStatusUrl(self, error_ok=False):
879 if not self.tree_status_url:
880 error_message = ('You must configure your tree status URL by running '
881 '"git cl config".')
Edward Lemur61ea3072018-12-01 00:34:36 +0000882 self.tree_status_url = self._GetConfig(
883 'rietveld.tree-status-url', error_ok=error_ok,
884 error_message=error_message)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000885 return self.tree_status_url
886
887 def GetViewVCUrl(self):
888 if not self.viewvc_url:
Edward Lemur61ea3072018-12-01 00:34:36 +0000889 self.viewvc_url = self._GetConfig('rietveld.viewvc-url', error_ok=True)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000890 return self.viewvc_url
891
rmistry@google.com90752582014-01-14 21:04:50 +0000892 def GetBugPrefix(self):
Edward Lemur61ea3072018-12-01 00:34:36 +0000893 return self._GetConfig('rietveld.bug-prefix', error_ok=True)
rmistry@google.com78948ed2015-07-08 23:09:57 +0000894
rmistry@google.com5626a922015-02-26 14:03:30 +0000895 def GetRunPostUploadHook(self):
Edward Lemur61ea3072018-12-01 00:34:36 +0000896 run_post_upload_hook = self._GetConfig(
897 'rietveld.run-post-upload-hook', error_ok=True)
rmistry@google.com5626a922015-02-26 14:03:30 +0000898 return run_post_upload_hook == "True"
899
bauerb@chromium.orgae6df352011-04-06 17:40:39 +0000900 def GetDefaultCCList(self):
Edward Lemur61ea3072018-12-01 00:34:36 +0000901 return self._GetConfig('rietveld.cc', error_ok=True)
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000902
ukai@chromium.orge8077812012-02-03 03:41:46 +0000903 def GetIsGerrit(self):
Quinten Yearsley0c62da92017-05-31 13:39:42 -0700904 """Return true if this repo is associated with gerrit code review system."""
ukai@chromium.orge8077812012-02-03 03:41:46 +0000905 if self.is_gerrit is None:
Aaron Gable9b465272017-05-12 10:53:51 -0700906 self.is_gerrit = (
907 self._GetConfig('gerrit.host', error_ok=True).lower() == 'true')
ukai@chromium.orge8077812012-02-03 03:41:46 +0000908 return self.is_gerrit
909
bauerb@chromium.org54b400c2016-01-14 10:08:25 +0000910 def GetSquashGerritUploads(self):
911 """Return true if uploads to Gerrit should be squashed by default."""
912 if self.squash_gerrit_uploads is None:
tandriia60502f2016-06-20 02:01:53 -0700913 self.squash_gerrit_uploads = self.GetSquashGerritUploadsOverride()
914 if self.squash_gerrit_uploads is None:
915 # Default is squash now (http://crbug.com/611892#c23).
916 self.squash_gerrit_uploads = not (
917 RunGit(['config', '--bool', 'gerrit.squash-uploads'],
918 error_ok=True).strip() == 'false')
bauerb@chromium.org54b400c2016-01-14 10:08:25 +0000919 return self.squash_gerrit_uploads
920
tandriia60502f2016-06-20 02:01:53 -0700921 def GetSquashGerritUploadsOverride(self):
922 """Return True or False if codereview.settings should be overridden.
923
924 Returns None if no override has been defined.
925 """
926 # See also http://crbug.com/611892#c23
927 result = RunGit(['config', '--bool', 'gerrit.override-squash-uploads'],
928 error_ok=True).strip()
929 if result == 'true':
930 return True
931 if result == 'false':
932 return False
933 return None
934
tandrii@chromium.org28253532016-04-14 13:46:56 +0000935 def GetGerritSkipEnsureAuthenticated(self):
936 """Return True if EnsureAuthenticated should not be done for Gerrit
937 uploads."""
938 if self.gerrit_skip_ensure_authenticated is None:
939 self.gerrit_skip_ensure_authenticated = (
shinyak@chromium.org00dbccd2016-04-15 07:24:43 +0000940 RunGit(['config', '--bool', 'gerrit.skip-ensure-authenticated'],
tandrii@chromium.org28253532016-04-14 13:46:56 +0000941 error_ok=True).strip() == 'true')
942 return self.gerrit_skip_ensure_authenticated
943
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000944 def GetGitEditor(self):
945 """Return the editor specified in the git config, or None if none is."""
946 if self.git_editor is None:
Raul Tambre5a525872019-02-12 19:08:08 +0000947 # Git requires single quotes for paths with spaces. We need to replace
948 # them with double quotes for Windows to treat such paths as a single
949 # path.
950 self.git_editor = self._GetConfig(
951 'core.editor', error_ok=True).replace('\'', '"')
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000952 return self.git_editor or None
953
thestig@chromium.org44202a22014-03-11 19:22:18 +0000954 def GetLintRegex(self):
Edward Lemur61ea3072018-12-01 00:34:36 +0000955 return (self._GetConfig('rietveld.cpplint-regex', error_ok=True) or
thestig@chromium.org44202a22014-03-11 19:22:18 +0000956 DEFAULT_LINT_REGEX)
957
958 def GetLintIgnoreRegex(self):
Edward Lemur61ea3072018-12-01 00:34:36 +0000959 return (self._GetConfig('rietveld.cpplint-ignore-regex', error_ok=True) or
thestig@chromium.org44202a22014-03-11 19:22:18 +0000960 DEFAULT_LINT_IGNORE_REGEX)
961
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000962 def _GetConfig(self, param, **kwargs):
963 self.LazyUpdateIfNeeded()
964 return RunGit(['config', param], **kwargs).strip()
965
966
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +0100967@contextlib.contextmanager
968def _get_gerrit_project_config_file(remote_url):
969 """Context manager to fetch and store Gerrit's project.config from
970 refs/meta/config branch and store it in temp file.
971
972 Provides a temporary filename or None if there was error.
973 """
974 error, _ = RunGitWithCode([
975 'fetch', remote_url,
976 '+refs/meta/config:refs/git_cl/meta/config'])
977 if error:
978 # Ref doesn't exist or isn't accessible to current user.
Quinten Yearsley0c62da92017-05-31 13:39:42 -0700979 print('WARNING: Failed to fetch project config for %s: %s' %
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +0100980 (remote_url, error))
981 yield None
982 return
983
984 error, project_config_data = RunGitWithCode(
985 ['show', 'refs/git_cl/meta/config:project.config'])
986 if error:
987 print('WARNING: project.config file not found')
988 yield None
989 return
990
991 with gclient_utils.temporary_directory() as tempdir:
992 project_config_file = os.path.join(tempdir, 'project.config')
993 gclient_utils.FileWrite(project_config_file, project_config_data)
994 yield project_config_file
995
996
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000997def ShortBranchName(branch):
998 """Convert a name like 'refs/heads/foo' to just 'foo'."""
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +0000999 return branch.replace('refs/heads/', '', 1)
1000
1001
1002def GetCurrentBranchRef():
1003 """Returns branch ref (e.g., refs/heads/master) or None."""
1004 return RunGit(['symbolic-ref', 'HEAD'],
1005 stderr=subprocess2.VOID, error_ok=True).strip() or None
1006
1007
1008def GetCurrentBranch():
1009 """Returns current branch or None.
1010
1011 For refs/heads/* branches, returns just last part. For others, full ref.
1012 """
1013 branchref = GetCurrentBranchRef()
1014 if branchref:
1015 return ShortBranchName(branchref)
1016 return None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001017
1018
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001019class _CQState(object):
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00001020 """Enum for states of CL with respect to CQ."""
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001021 NONE = 'none'
1022 DRY_RUN = 'dry_run'
1023 COMMIT = 'commit'
1024
1025 ALL_STATES = [NONE, DRY_RUN, COMMIT]
1026
1027
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001028class _ParsedIssueNumberArgument(object):
Andrii Shyshkalov90f31922017-04-10 16:10:21 +02001029 def __init__(self, issue=None, patchset=None, hostname=None, codereview=None):
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001030 self.issue = issue
1031 self.patchset = patchset
1032 self.hostname = hostname
Andrii Shyshkalovf5569d22018-10-15 03:35:23 +00001033 assert codereview in (None, 'gerrit', 'rietveld')
Andrii Shyshkalov90f31922017-04-10 16:10:21 +02001034 self.codereview = codereview
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001035
1036 @property
1037 def valid(self):
1038 return self.issue is not None
1039
1040
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001041def ParseIssueNumberArgument(arg, codereview=None):
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001042 """Parses the issue argument and returns _ParsedIssueNumberArgument."""
1043 fail_result = _ParsedIssueNumberArgument()
1044
1045 if arg.isdigit():
Aaron Gableaee6c852017-06-26 12:49:01 -07001046 return _ParsedIssueNumberArgument(issue=int(arg), codereview=codereview)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001047 if not arg.startswith('http'):
1048 return fail_result
Aaron Gableaee6c852017-06-26 12:49:01 -07001049
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001050 url = gclient_utils.UpgradeToHttps(arg)
1051 try:
1052 parsed_url = urlparse.urlparse(url)
1053 except ValueError:
1054 return fail_result
Andrii Shyshkalov28d840e2017-04-10 15:45:09 +02001055
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001056 if codereview is not None:
1057 parsed = _CODEREVIEW_IMPLEMENTATIONS[codereview].ParseIssueURL(parsed_url)
1058 return parsed or fail_result
1059
Andrii Shyshkalov0a264d82018-11-21 00:36:16 +00001060 return _GerritChangelistImpl.ParseIssueURL(parsed_url) or fail_result
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001061
1062
Andrii Shyshkalovb07575f2018-10-16 06:16:21 +00001063def _create_description_from_log(args):
1064 """Pulls out the commit log to use as a base for the CL description."""
1065 log_args = []
1066 if len(args) == 1 and not args[0].endswith('.'):
1067 log_args = [args[0] + '..']
1068 elif len(args) == 1 and args[0].endswith('...'):
1069 log_args = [args[0][:-1]]
1070 elif len(args) == 2:
1071 log_args = [args[0] + '..' + args[1]]
1072 else:
1073 log_args = args[:] # Hope for the best!
1074 return RunGit(['log', '--pretty=format:%s\n\n%b'] + log_args)
1075
1076
Aaron Gablea45ee112016-11-22 15:14:38 -08001077class GerritChangeNotExists(Exception):
tandriic2405f52016-10-10 08:13:15 -07001078 def __init__(self, issue, url):
1079 self.issue = issue
1080 self.url = url
Aaron Gablea45ee112016-11-22 15:14:38 -08001081 super(GerritChangeNotExists, self).__init__()
tandriic2405f52016-10-10 08:13:15 -07001082
1083 def __str__(self):
Aaron Gablea45ee112016-11-22 15:14:38 -08001084 return 'change %s at %s does not exist or you have no access to it' % (
tandriic2405f52016-10-10 08:13:15 -07001085 self.issue, self.url)
1086
1087
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01001088_CommentSummary = collections.namedtuple(
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001089 '_CommentSummary', ['date', 'message', 'sender', 'autogenerated',
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01001090 # TODO(tandrii): these two aren't known in Gerrit.
1091 'approval', 'disapproval'])
1092
1093
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001094class Changelist(object):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001095 """Changelist works with one changelist in local branch.
1096
1097 Supports two codereview backends: Rietveld or Gerrit, selected at object
1098 creation.
1099
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00001100 Notes:
1101 * Not safe for concurrent multi-{thread,process} use.
1102 * Caches values from current branch. Therefore, re-use after branch change
tandrii5d48c322016-08-18 16:19:37 -07001103 with great care.
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001104 """
1105
1106 def __init__(self, branchref=None, issue=None, codereview=None, **kwargs):
1107 """Create a new ChangeList instance.
1108
1109 If issue is given, the codereview must be given too.
1110
1111 If `codereview` is given, it must be 'rietveld' or 'gerrit'.
1112 Otherwise, it's decided based on current configuration of the local branch,
1113 with default being 'rietveld' for backwards compatibility.
1114 See _load_codereview_impl for more details.
1115
1116 **kwargs will be passed directly to codereview implementation.
1117 """
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001118 # Poke settings so we get the "configure your server" message if necessary.
maruel@chromium.org379d07a2011-11-30 14:58:10 +00001119 global settings
1120 if not settings:
1121 # Happens when git_cl.py is used as a utility library.
1122 settings = Settings()
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001123
1124 if issue:
1125 assert codereview, 'codereview must be known, if issue is known'
1126
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001127 self.branchref = branchref
1128 if self.branchref:
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00001129 assert branchref.startswith('refs/heads/')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001130 self.branch = ShortBranchName(self.branchref)
1131 else:
1132 self.branch = None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001133 self.upstream_branch = None
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001134 self.lookedup_issue = False
1135 self.issue = issue or None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001136 self.has_description = False
1137 self.description = None
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001138 self.lookedup_patchset = False
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001139 self.patchset = None
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001140 self.cc = None
Daniel Cheng7227d212017-11-17 08:12:37 -08001141 self.more_cc = []
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00001142 self._remote = None
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001143 self._cached_remote_url = (False, None) # (is_cached, value)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00001144
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001145 self._codereview_impl = None
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00001146 self._codereview = None
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001147 self._load_codereview_impl(codereview, **kwargs)
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00001148 assert self._codereview_impl
1149 assert self._codereview in _CODEREVIEW_IMPLEMENTATIONS
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001150
1151 def _load_codereview_impl(self, codereview=None, **kwargs):
1152 if codereview:
Joe Masond87b0962018-12-03 21:04:46 +00001153 assert codereview in _CODEREVIEW_IMPLEMENTATIONS, (
1154 'codereview {} not in {}'.format(codereview,
1155 _CODEREVIEW_IMPLEMENTATIONS))
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00001156 cls = _CODEREVIEW_IMPLEMENTATIONS[codereview]
1157 self._codereview = codereview
1158 self._codereview_impl = cls(self, **kwargs)
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001159 return
1160
1161 # Automatic selection based on issue number set for a current branch.
1162 # Rietveld takes precedence over Gerrit.
1163 assert not self.issue
1164 # Whether we find issue or not, we are doing the lookup.
1165 self.lookedup_issue = True
tandrii5d48c322016-08-18 16:19:37 -07001166 if self.GetBranch():
1167 for codereview, cls in _CODEREVIEW_IMPLEMENTATIONS.iteritems():
1168 issue = _git_get_branch_config_value(
1169 cls.IssueConfigKey(), value_type=int, branch=self.GetBranch())
1170 if issue:
1171 self._codereview = codereview
1172 self._codereview_impl = cls(self, **kwargs)
1173 self.issue = int(issue)
1174 return
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001175
Bryce Thomascfc97122018-12-13 20:21:47 +00001176 # No issue is set for this branch, so default to gerrit.
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001177 return self._load_codereview_impl(
Bryce Thomascfc97122018-12-13 20:21:47 +00001178 codereview='gerrit',
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001179 **kwargs)
1180
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00001181 def IsGerrit(self):
1182 return self._codereview == 'gerrit'
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001183
1184 def GetCCList(self):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001185 """Returns the users cc'd on this CL.
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001186
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001187 The return value is a string suitable for passing to git cl with the --cc
1188 flag.
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001189 """
1190 if self.cc is None:
tyoshino@chromium.org99918ab2013-09-30 06:17:28 +00001191 base_cc = settings.GetDefaultCCList()
Daniel Cheng7227d212017-11-17 08:12:37 -08001192 more_cc = ','.join(self.more_cc)
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001193 self.cc = ','.join(filter(None, (base_cc, more_cc))) or ''
1194 return self.cc
1195
tyoshino@chromium.org99918ab2013-09-30 06:17:28 +00001196 def GetCCListWithoutDefault(self):
1197 """Return the users cc'd on this CL excluding default ones."""
1198 if self.cc is None:
Daniel Cheng7227d212017-11-17 08:12:37 -08001199 self.cc = ','.join(self.more_cc)
tyoshino@chromium.org99918ab2013-09-30 06:17:28 +00001200 return self.cc
1201
Daniel Cheng7227d212017-11-17 08:12:37 -08001202 def ExtendCC(self, more_cc):
1203 """Extends the list of users to cc on this CL based on the changed files."""
1204 self.more_cc.extend(more_cc)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001205
1206 def GetBranch(self):
1207 """Returns the short branch name, e.g. 'master'."""
1208 if not self.branch:
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001209 branchref = GetCurrentBranchRef()
szager@chromium.orgd62c61f2014-10-20 22:33:21 +00001210 if not branchref:
1211 return None
1212 self.branchref = branchref
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001213 self.branch = ShortBranchName(self.branchref)
1214 return self.branch
1215
1216 def GetBranchRef(self):
1217 """Returns the full branch name, e.g. 'refs/heads/master'."""
1218 self.GetBranch() # Poke the lazy loader.
1219 return self.branchref
1220
tandrii@chromium.org534f67a2016-04-07 18:47:05 +00001221 def ClearBranch(self):
1222 """Clears cached branch data of this object."""
1223 self.branch = self.branchref = None
1224
tandrii5d48c322016-08-18 16:19:37 -07001225 def _GitGetBranchConfigValue(self, key, default=None, **kwargs):
1226 assert 'branch' not in kwargs, 'this CL branch is used automatically'
1227 kwargs['branch'] = self.GetBranch()
1228 return _git_get_branch_config_value(key, default, **kwargs)
1229
1230 def _GitSetBranchConfigValue(self, key, value, **kwargs):
1231 assert 'branch' not in kwargs, 'this CL branch is used automatically'
1232 assert self.GetBranch(), (
1233 'this CL must have an associated branch to %sset %s%s' %
1234 ('un' if value is None else '',
1235 key,
1236 '' if value is None else ' to %r' % value))
1237 kwargs['branch'] = self.GetBranch()
1238 return _git_set_branch_config_value(key, value, **kwargs)
1239
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001240 @staticmethod
1241 def FetchUpstreamTuple(branch):
pgervais@chromium.orgd6617f32013-11-19 00:34:54 +00001242 """Returns a tuple containing remote and remote ref,
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001243 e.g. 'origin', 'refs/heads/master'
1244 """
1245 remote = '.'
tandrii5d48c322016-08-18 16:19:37 -07001246 upstream_branch = _git_get_branch_config_value('merge', branch=branch)
1247
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001248 if upstream_branch:
tandrii5d48c322016-08-18 16:19:37 -07001249 remote = _git_get_branch_config_value('remote', branch=branch)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001250 else:
bauerb@chromium.orgade368c2011-03-01 08:57:50 +00001251 upstream_branch = RunGit(['config', 'rietveld.upstream-branch'],
1252 error_ok=True).strip()
1253 if upstream_branch:
1254 remote = RunGit(['config', 'rietveld.upstream-remote']).strip()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001255 else:
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08001256 # Else, try to guess the origin remote.
1257 remote_branches = RunGit(['branch', '-r']).split()
1258 if 'origin/master' in remote_branches:
1259 # Fall back on origin/master if it exits.
1260 remote = 'origin'
1261 upstream_branch = 'refs/heads/master'
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001262 else:
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08001263 DieWithError(
1264 'Unable to determine default branch to diff against.\n'
1265 'Either pass complete "git diff"-style arguments, like\n'
1266 ' git cl upload origin/master\n'
1267 'or verify this branch is set up to track another \n'
1268 '(via the --track argument to "git checkout -b ...").')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001269
1270 return remote, upstream_branch
1271
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00001272 def GetCommonAncestorWithUpstream(self):
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +00001273 upstream_branch = self.GetUpstreamBranch()
1274 if not BranchExists(upstream_branch):
1275 DieWithError('The upstream for the current branch (%s) does not exist '
1276 'anymore.\nPlease fix it and try again.' % self.GetBranch())
iannucci@chromium.org9e849272014-04-04 00:31:55 +00001277 return git_common.get_or_create_merge_base(self.GetBranch(),
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +00001278 upstream_branch)
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00001279
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001280 def GetUpstreamBranch(self):
1281 if self.upstream_branch is None:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001282 remote, upstream_branch = self.FetchUpstreamTuple(self.GetBranch())
Raul Tambrefe1dbe12019-05-02 04:43:57 +00001283 if remote != '.':
mmoss@chromium.orge7585452014-08-24 01:41:11 +00001284 upstream_branch = upstream_branch.replace('refs/heads/',
1285 'refs/remotes/%s/' % remote)
1286 upstream_branch = upstream_branch.replace('refs/branch-heads/',
1287 'refs/remotes/branch-heads/')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001288 self.upstream_branch = upstream_branch
1289 return self.upstream_branch
1290
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001291 def GetRemoteBranch(self):
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001292 if not self._remote:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001293 remote, branch = None, self.GetBranch()
1294 seen_branches = set()
1295 while branch not in seen_branches:
1296 seen_branches.add(branch)
1297 remote, branch = self.FetchUpstreamTuple(branch)
1298 branch = ShortBranchName(branch)
1299 if remote != '.' or branch.startswith('refs/remotes'):
1300 break
1301 else:
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001302 remotes = RunGit(['remote'], error_ok=True).split()
1303 if len(remotes) == 1:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001304 remote, = remotes
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001305 elif 'origin' in remotes:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001306 remote = 'origin'
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08001307 logging.warn('Could not determine which remote this change is '
1308 'associated with, so defaulting to "%s".' % self._remote)
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001309 else:
1310 logging.warn('Could not determine which remote this change is '
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08001311 'associated with.')
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001312 branch = 'HEAD'
1313 if branch.startswith('refs/remotes'):
1314 self._remote = (remote, branch)
mmoss@chromium.orge7585452014-08-24 01:41:11 +00001315 elif branch.startswith('refs/branch-heads/'):
1316 self._remote = (remote, branch.replace('refs/', 'refs/remotes/'))
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001317 else:
1318 self._remote = (remote, 'refs/remotes/%s/%s' % (remote, branch))
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001319 return self._remote
1320
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001321 def GitSanityChecks(self, upstream_git_obj):
1322 """Checks git repo status and ensures diff is from local commits."""
1323
sbc@chromium.org79706062015-01-14 21:18:12 +00001324 if upstream_git_obj is None:
1325 if self.GetBranch() is None:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001326 print('ERROR: Unable to determine current branch (detached HEAD?)',
vapiera7fbd5a2016-06-16 09:17:49 -07001327 file=sys.stderr)
sbc@chromium.org79706062015-01-14 21:18:12 +00001328 else:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001329 print('ERROR: No upstream branch.', file=sys.stderr)
sbc@chromium.org79706062015-01-14 21:18:12 +00001330 return False
1331
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001332 # Verify the commit we're diffing against is in our current branch.
1333 upstream_sha = RunGit(['rev-parse', '--verify', upstream_git_obj]).strip()
1334 common_ancestor = RunGit(['merge-base', upstream_sha, 'HEAD']).strip()
1335 if upstream_sha != common_ancestor:
vapiera7fbd5a2016-06-16 09:17:49 -07001336 print('ERROR: %s is not in the current branch. You may need to rebase '
1337 'your tracking branch' % upstream_sha, file=sys.stderr)
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001338 return False
1339
1340 # List the commits inside the diff, and verify they are all local.
1341 commits_in_diff = RunGit(
1342 ['rev-list', '^%s' % upstream_sha, 'HEAD']).splitlines()
1343 code, remote_branch = RunGitWithCode(['config', 'gitcl.remotebranch'])
1344 remote_branch = remote_branch.strip()
1345 if code != 0:
1346 _, remote_branch = self.GetRemoteBranch()
1347
1348 commits_in_remote = RunGit(
1349 ['rev-list', '^%s' % upstream_sha, remote_branch]).splitlines()
1350
1351 common_commits = set(commits_in_diff) & set(commits_in_remote)
1352 if common_commits:
vapiera7fbd5a2016-06-16 09:17:49 -07001353 print('ERROR: Your diff contains %d commits already in %s.\n'
1354 'Run "git log --oneline %s..HEAD" to get a list of commits in '
1355 'the diff. If you are using a custom git flow, you can override'
1356 ' the reference used for this check with "git config '
1357 'gitcl.remotebranch <git-ref>".' % (
1358 len(common_commits), remote_branch, upstream_git_obj),
1359 file=sys.stderr)
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001360 return False
1361 return True
1362
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00001363 def GetGitBaseUrlFromConfig(self):
sheyang@chromium.orga656e702014-05-15 20:43:05 +00001364 """Return the configured base URL from branch.<branchname>.baseurl.
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00001365
1366 Returns None if it is not set.
1367 """
tandrii5d48c322016-08-18 16:19:37 -07001368 return self._GitGetBranchConfigValue('base-url')
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001369
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001370 def GetRemoteUrl(self):
1371 """Return the configured remote URL, e.g. 'git://example.org/foo.git/'.
1372
1373 Returns None if there is no remote.
1374 """
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001375 is_cached, value = self._cached_remote_url
1376 if is_cached:
1377 return value
1378
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001379 remote, _ = self.GetRemoteBranch()
dyen@chromium.org2a13d4f2014-06-13 00:06:37 +00001380 url = RunGit(['config', 'remote.%s.url' % remote], error_ok=True).strip()
1381
Edward Lemur298f2cf2019-02-22 21:40:39 +00001382 # Check if the remote url can be parsed as an URL.
1383 host = urlparse.urlparse(url).netloc
1384 if host:
1385 self._cached_remote_url = (True, url)
1386 return url
1387
1388 # If it cannot be parsed as an url, assume it is a local directory, probably
1389 # a git cache.
1390 logging.warning('"%s" doesn\'t appear to point to a git host. '
1391 'Interpreting it as a local directory.', url)
1392 if not os.path.isdir(url):
1393 logging.error(
1394 'Remote "%s" for branch "%s" points to "%s", but it doesn\'t exist.',
1395 remote, url, self.GetBranch())
1396 return None
1397
1398 cache_path = url
1399 url = RunGit(['config', 'remote.%s.url' % remote],
1400 error_ok=True,
1401 cwd=url).strip()
1402
1403 host = urlparse.urlparse(url).netloc
1404 if not host:
1405 logging.error(
1406 'Remote "%(remote)s" for branch "%(branch)s" points to '
1407 '"%(cache_path)s", but it is misconfigured.\n'
1408 '"%(cache_path)s" must be a git repo and must have a remote named '
1409 '"%(remote)s" pointing to the git host.', {
1410 'remote': remote,
1411 'cache_path': cache_path,
1412 'branch': self.GetBranch()})
1413 return None
1414
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001415 self._cached_remote_url = (True, url)
dyen@chromium.org2a13d4f2014-06-13 00:06:37 +00001416 return url
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001417
tandrii@chromium.org87985d22016-03-24 17:33:33 +00001418 def GetIssue(self):
maruel@chromium.org52424302012-08-29 15:14:30 +00001419 """Returns the issue number as a int or None if not set."""
tandrii@chromium.org87985d22016-03-24 17:33:33 +00001420 if self.issue is None and not self.lookedup_issue:
tandrii5d48c322016-08-18 16:19:37 -07001421 self.issue = self._GitGetBranchConfigValue(
1422 self._codereview_impl.IssueConfigKey(), value_type=int)
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001423 self.lookedup_issue = True
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001424 return self.issue
1425
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001426 def GetIssueURL(self):
1427 """Get the URL for a particular issue."""
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001428 issue = self.GetIssue()
1429 if not issue:
dbeam@chromium.org015fd3d2013-06-18 19:02:50 +00001430 return None
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001431 return '%s/%s' % (self._codereview_impl.GetCodereviewServer(), issue)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001432
Andrii Shyshkalov31863012017-02-08 11:35:12 +01001433 def GetDescription(self, pretty=False, force=False):
1434 if not self.has_description or force:
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001435 if self.GetIssue():
Kenneth Russell61e2ed42017-02-15 11:47:13 -08001436 self.description = self._codereview_impl.FetchDescription(force=force)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001437 self.has_description = True
1438 if pretty:
Asanka Herath7c61dcb2016-12-14 13:01:58 -05001439 # Set width to 72 columns + 2 space indent.
1440 wrapper = textwrap.TextWrapper(width=74, replace_whitespace=True)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001441 wrapper.initial_indent = wrapper.subsequent_indent = ' '
Asanka Herath7c61dcb2016-12-14 13:01:58 -05001442 lines = self.description.splitlines()
1443 return '\n'.join([wrapper.fill(line) for line in lines])
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001444 return self.description
1445
Robert Iannucci09f1f3d2017-03-28 16:54:32 -07001446 def GetDescriptionFooters(self):
1447 """Returns (non_footer_lines, footers) for the commit message.
1448
1449 Returns:
1450 non_footer_lines (list(str)) - Simple list of description lines without
1451 any footer. The lines do not contain newlines, nor does the list contain
1452 the empty line between the message and the footers.
1453 footers (list(tuple(KEY, VALUE))) - List of parsed footers, e.g.
1454 [("Change-Id", "Ideadbeef...."), ...]
1455 """
1456 raw_description = self.GetDescription()
1457 msg_lines, _, footers = git_footers.split_footers(raw_description)
1458 if footers:
1459 msg_lines = msg_lines[:len(msg_lines)-1]
1460 return msg_lines, footers
1461
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001462 def GetPatchset(self):
maruel@chromium.org52424302012-08-29 15:14:30 +00001463 """Returns the patchset number as a int or None if not set."""
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001464 if self.patchset is None and not self.lookedup_patchset:
tandrii5d48c322016-08-18 16:19:37 -07001465 self.patchset = self._GitGetBranchConfigValue(
1466 self._codereview_impl.PatchsetConfigKey(), value_type=int)
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001467 self.lookedup_patchset = True
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001468 return self.patchset
1469
1470 def SetPatchset(self, patchset):
tandrii5d48c322016-08-18 16:19:37 -07001471 """Set this branch's patchset. If patchset=0, clears the patchset."""
1472 assert self.GetBranch()
1473 if not patchset:
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001474 self.patchset = None
tandrii5d48c322016-08-18 16:19:37 -07001475 else:
1476 self.patchset = int(patchset)
1477 self._GitSetBranchConfigValue(
1478 self._codereview_impl.PatchsetConfigKey(), self.patchset)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001479
tandrii@chromium.orga342c922016-03-16 07:08:25 +00001480 def SetIssue(self, issue=None):
tandrii5d48c322016-08-18 16:19:37 -07001481 """Set this branch's issue. If issue isn't given, clears the issue."""
1482 assert self.GetBranch()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001483 if issue:
tandrii5d48c322016-08-18 16:19:37 -07001484 issue = int(issue)
1485 self._GitSetBranchConfigValue(
1486 self._codereview_impl.IssueConfigKey(), issue)
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001487 self.issue = issue
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001488 codereview_server = self._codereview_impl.GetCodereviewServer()
1489 if codereview_server:
tandrii5d48c322016-08-18 16:19:37 -07001490 self._GitSetBranchConfigValue(
1491 self._codereview_impl.CodereviewServerConfigKey(),
1492 codereview_server)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001493 else:
tandrii5d48c322016-08-18 16:19:37 -07001494 # Reset all of these just to be clean.
1495 reset_suffixes = [
1496 'last-upload-hash',
1497 self._codereview_impl.IssueConfigKey(),
1498 self._codereview_impl.PatchsetConfigKey(),
1499 self._codereview_impl.CodereviewServerConfigKey(),
1500 ] + self._PostUnsetIssueProperties()
1501 for prop in reset_suffixes:
1502 self._GitSetBranchConfigValue(prop, None, error_ok=True)
Aaron Gableca01e2c2017-07-19 11:16:02 -07001503 msg = RunGit(['log', '-1', '--format=%B']).strip()
1504 if msg and git_footers.get_footer_change_id(msg):
1505 print('WARNING: The change patched into this branch has a Change-Id. '
1506 'Removing it.')
1507 RunGit(['commit', '--amend', '-m',
1508 git_footers.remove_footer(msg, 'Change-Id')])
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001509 self.issue = None
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00001510 self.patchset = None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001511
dnjba1b0f32016-09-02 12:37:42 -07001512 def GetChange(self, upstream_branch, author, local_description=False):
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001513 if not self.GitSanityChecks(upstream_branch):
1514 DieWithError('\nGit sanity check failure')
1515
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00001516 root = settings.GetRelativeRoot()
bratell@opera.comf267b0e2013-05-02 09:11:43 +00001517 if not root:
1518 root = '.'
bauerb@chromium.org512f1ef2011-04-20 15:17:57 +00001519 absroot = os.path.abspath(root)
bauerb@chromium.org6fb99c62011-04-18 15:57:28 +00001520
1521 # We use the sha1 of HEAD as a name of this change.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00001522 name = RunGitWithCode(['rev-parse', 'HEAD'])[1].strip()
bauerb@chromium.org512f1ef2011-04-20 15:17:57 +00001523 # Need to pass a relative path for msysgit.
maruel@chromium.org2b38e9c2011-10-19 00:04:35 +00001524 try:
maruel@chromium.org80a9ef12011-12-13 20:44:10 +00001525 files = scm.GIT.CaptureStatus([root], '.', upstream_branch)
maruel@chromium.org2b38e9c2011-10-19 00:04:35 +00001526 except subprocess2.CalledProcessError:
1527 DieWithError(
pgervais@chromium.orgd6617f32013-11-19 00:34:54 +00001528 ('\nFailed to diff against upstream branch %s\n\n'
maruel@chromium.org2b38e9c2011-10-19 00:04:35 +00001529 'This branch probably doesn\'t exist anymore. To reset the\n'
1530 'tracking branch, please run\n'
stip7a3dd352016-09-22 17:32:28 -07001531 ' git branch --set-upstream-to origin/master %s\n'
1532 'or replace origin/master with the relevant branch') %
maruel@chromium.org2b38e9c2011-10-19 00:04:35 +00001533 (upstream_branch, self.GetBranch()))
bauerb@chromium.org6fb99c62011-04-18 15:57:28 +00001534
maruel@chromium.org52424302012-08-29 15:14:30 +00001535 issue = self.GetIssue()
1536 patchset = self.GetPatchset()
dnjba1b0f32016-09-02 12:37:42 -07001537 if issue and not local_description:
bauerb@chromium.org6fb99c62011-04-18 15:57:28 +00001538 description = self.GetDescription()
1539 else:
1540 # If the change was never uploaded, use the log messages of all commits
1541 # up to the branch point, as git cl upload will prefill the description
1542 # with these log messages.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00001543 args = ['log', '--pretty=format:%s%n%n%b', '%s...' % (upstream_branch)]
1544 description = RunGitWithCode(args)[1].strip()
maruel@chromium.org03b3bdc2011-06-14 13:04:12 +00001545
1546 if not author:
maruel@chromium.org13f623c2011-07-22 16:02:23 +00001547 author = RunGit(['config', 'user.email']).strip() or None
asvitkine@chromium.org15169952011-09-27 14:30:53 +00001548 return presubmit_support.GitChange(
bauerb@chromium.org6fb99c62011-04-18 15:57:28 +00001549 name,
1550 description,
1551 absroot,
1552 files,
1553 issue,
1554 patchset,
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001555 author,
1556 upstream=upstream_branch)
bauerb@chromium.org6fb99c62011-04-18 15:57:28 +00001557
dsansomee2d6fd92016-09-08 00:10:47 -07001558 def UpdateDescription(self, description, force=False):
Andrii Shyshkalov83051152017-02-07 23:47:29 +01001559 self._codereview_impl.UpdateDescriptionRemote(description, force=force)
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001560 self.description = description
Andrii Shyshkalov83051152017-02-07 23:47:29 +01001561 self.has_description = True
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001562
Robert Iannucci09f1f3d2017-03-28 16:54:32 -07001563 def UpdateDescriptionFooters(self, description_lines, footers, force=False):
1564 """Sets the description for this CL remotely.
1565
1566 You can get description_lines and footers with GetDescriptionFooters.
1567
1568 Args:
1569 description_lines (list(str)) - List of CL description lines without
1570 newline characters.
1571 footers (list(tuple(KEY, VALUE))) - List of footers, as returned by
1572 GetDescriptionFooters. Key must conform to the git footers format (i.e.
1573 `List-Of-Tokens`). It will be case-normalized so that each token is
1574 title-cased.
1575 """
1576 new_description = '\n'.join(description_lines)
1577 if footers:
1578 new_description += '\n'
1579 for k, v in footers:
1580 foot = '%s: %s' % (git_footers.normalize_name(k), v)
1581 if not git_footers.FOOTER_PATTERN.match(foot):
1582 raise ValueError('Invalid footer %r' % foot)
1583 new_description += foot + '\n'
1584 self.UpdateDescription(new_description, force)
1585
Edward Lesmes8e282792018-04-03 18:50:29 -04001586 def RunHook(self, committing, may_prompt, verbose, change, parallel):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001587 """Calls sys.exit() if the hook fails; returns a HookResults otherwise."""
1588 try:
Edward Lemur2c48f242019-06-04 16:14:09 +00001589 start = time_time()
1590 result = presubmit_support.DoPresubmitChecks(change, committing,
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001591 verbose=verbose, output_stream=sys.stdout, input_stream=sys.stdin,
1592 default_presubmit=None, may_prompt=may_prompt,
Edward Lesmes8e282792018-04-03 18:50:29 -04001593 gerrit_obj=self._codereview_impl.GetGerritObjForPresubmit(),
1594 parallel=parallel)
Edward Lemur2c48f242019-06-04 16:14:09 +00001595 metrics.collector.add_repeated('sub_commands', {
1596 'command': 'presubmit',
1597 'execution_time': time_time() - start,
1598 'exit_code': 0 if result.should_continue() else 1,
1599 })
1600 return result
vapierfd77ac72016-06-16 08:33:57 -07001601 except presubmit_support.PresubmitFailure as e:
Aaron Gable5d5f22c2018-02-02 09:12:41 -08001602 DieWithError('%s\nMaybe your depot_tools is out of date?' % e)
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001603
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001604 def CMDPatchIssue(self, issue_arg, reject, nocommit, directory):
1605 """Fetches and applies the issue patch from codereview to local branch."""
tandrii@chromium.orgef7c68c2016-04-07 09:39:39 +00001606 if isinstance(issue_arg, (int, long)) or issue_arg.isdigit():
1607 parsed_issue_arg = _ParsedIssueNumberArgument(int(issue_arg))
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001608 else:
1609 # Assume url.
1610 parsed_issue_arg = self._codereview_impl.ParseIssueURL(
1611 urlparse.urlparse(issue_arg))
1612 if not parsed_issue_arg or not parsed_issue_arg.valid:
1613 DieWithError('Failed to parse issue argument "%s". '
1614 'Must be an issue number or a valid URL.' % issue_arg)
1615 return self._codereview_impl.CMDPatchWithParsedIssue(
Aaron Gable62619a32017-06-16 08:22:09 -07001616 parsed_issue_arg, reject, nocommit, directory, False)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001617
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001618 def CMDUpload(self, options, git_diff_args, orig_args):
1619 """Uploads a change to codereview."""
Andrii Shyshkalov9f274432018-10-15 16:40:23 +00001620 assert self.IsGerrit()
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001621 custom_cl_base = None
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001622 if git_diff_args:
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001623 custom_cl_base = base_branch = git_diff_args[0]
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001624 else:
1625 if self.GetBranch() is None:
1626 DieWithError('Can\'t upload from detached HEAD state. Get on a branch!')
1627
1628 # Default to diffing against common ancestor of upstream branch
1629 base_branch = self.GetCommonAncestorWithUpstream()
1630 git_diff_args = [base_branch, 'HEAD']
1631
Aaron Gablec4c40d12017-05-22 11:49:53 -07001632
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01001633 # Fast best-effort checks to abort before running potentially
1634 # expensive hooks if uploading is likely to fail anyway. Passing these
1635 # checks does not guarantee that uploading will not fail.
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001636 self._codereview_impl.EnsureAuthenticated(force=options.force)
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001637 self._codereview_impl.EnsureCanUploadPatchset(force=options.force)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001638
1639 # Apply watchlists on upload.
1640 change = self.GetChange(base_branch, None)
1641 watchlist = watchlists.Watchlists(change.RepositoryRoot())
1642 files = [f.LocalPath() for f in change.AffectedFiles()]
1643 if not options.bypass_watchlists:
Daniel Cheng7227d212017-11-17 08:12:37 -08001644 self.ExtendCC(watchlist.GetWatchersForPaths(files))
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001645
1646 if not options.bypass_hooks:
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001647 if options.reviewers or options.tbrs or options.add_owners_to:
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001648 # Set the reviewer list now so that presubmit checks can access it.
1649 change_description = ChangeDescription(change.FullDescriptionText())
1650 change_description.update_reviewers(options.reviewers,
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001651 options.tbrs,
Robert Iannuccif2708bd2017-04-17 15:49:02 -07001652 options.add_owners_to,
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001653 change)
1654 change.SetDescriptionText(change_description.description)
1655 hook_results = self.RunHook(committing=False,
Edward Lesmes8e282792018-04-03 18:50:29 -04001656 may_prompt=not options.force,
1657 verbose=options.verbose,
1658 change=change, parallel=options.parallel)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001659 if not hook_results.should_continue():
1660 return 1
1661 if not options.reviewers and hook_results.reviewers:
1662 options.reviewers = hook_results.reviewers.split(',')
Daniel Cheng7227d212017-11-17 08:12:37 -08001663 self.ExtendCC(hook_results.more_cc)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001664
Aaron Gable13101a62018-02-09 13:20:41 -08001665 print_stats(git_diff_args)
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001666 ret = self.CMDUploadChange(options, git_diff_args, custom_cl_base, change)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001667 if not ret:
tandrii5d48c322016-08-18 16:19:37 -07001668 _git_set_branch_config_value('last-upload-hash',
1669 RunGit(['rev-parse', 'HEAD']).strip())
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001670 # Run post upload hooks, if specified.
1671 if settings.GetRunPostUploadHook():
1672 presubmit_support.DoPostUploadExecuter(
1673 change,
1674 self,
1675 settings.GetRoot(),
1676 options.verbose,
1677 sys.stdout)
1678
1679 # Upload all dependencies if specified.
1680 if options.dependencies:
vapiera7fbd5a2016-06-16 09:17:49 -07001681 print()
1682 print('--dependencies has been specified.')
1683 print('All dependent local branches will be re-uploaded.')
1684 print()
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001685 # Remove the dependencies flag from args so that we do not end up in a
1686 # loop.
1687 orig_args.remove('--dependencies')
1688 ret = upload_branch_deps(self, orig_args)
1689 return ret
1690
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001691 def SetCQState(self, new_state):
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07001692 """Updates the CQ state for the latest patchset.
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001693
1694 Issue must have been already uploaded and known.
1695 """
1696 assert new_state in _CQState.ALL_STATES
1697 assert self.GetIssue()
qyearsley1fdfcb62016-10-24 13:22:03 -07001698 try:
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07001699 self._codereview_impl.SetCQState(new_state)
qyearsley1fdfcb62016-10-24 13:22:03 -07001700 return 0
1701 except KeyboardInterrupt:
1702 raise
1703 except:
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07001704 print('WARNING: Failed to %s.\n'
qyearsley1fdfcb62016-10-24 13:22:03 -07001705 'Either:\n'
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07001706 ' * Your project has no CQ,\n'
1707 ' * You don\'t have permission to change the CQ state,\n'
1708 ' * There\'s a bug in this code (see stack trace below).\n'
1709 'Consider specifying which bots to trigger manually or asking your '
1710 'project owners for permissions or contacting Chrome Infra at:\n'
1711 'https://www.chromium.org/infra\n\n' %
1712 ('cancel CQ' if new_state == _CQState.NONE else 'trigger CQ'))
qyearsley1fdfcb62016-10-24 13:22:03 -07001713 # Still raise exception so that stack trace is printed.
1714 raise
1715
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001716 # Forward methods to codereview specific implementation.
1717
Aaron Gable636b13f2017-07-14 10:42:48 -07001718 def AddComment(self, message, publish=None):
1719 return self._codereview_impl.AddComment(message, publish=publish)
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01001720
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001721 def GetCommentsSummary(self, readable=True):
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01001722 """Returns list of _CommentSummary for each comment.
1723
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001724 args:
1725 readable: determines whether the output is designed for a human or a machine
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01001726 """
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001727 return self._codereview_impl.GetCommentsSummary(readable)
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01001728
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001729 def CloseIssue(self):
1730 return self._codereview_impl.CloseIssue()
1731
1732 def GetStatus(self):
1733 return self._codereview_impl.GetStatus()
1734
1735 def GetCodereviewServer(self):
1736 return self._codereview_impl.GetCodereviewServer()
1737
tandriide281ae2016-10-12 06:02:30 -07001738 def GetIssueOwner(self):
1739 """Get owner from codereview, which may differ from this checkout."""
1740 return self._codereview_impl.GetIssueOwner()
1741
Edward Lemur707d70b2018-02-07 00:50:14 +01001742 def GetReviewers(self):
1743 return self._codereview_impl.GetReviewers()
1744
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001745 def GetMostRecentPatchset(self):
1746 return self._codereview_impl.GetMostRecentPatchset()
1747
tandriide281ae2016-10-12 06:02:30 -07001748 def CannotTriggerTryJobReason(self):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001749 """Returns reason (str) if unable trigger try jobs on this CL or None."""
tandriide281ae2016-10-12 06:02:30 -07001750 return self._codereview_impl.CannotTriggerTryJobReason()
1751
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001752 def GetTryJobProperties(self, patchset=None):
1753 """Returns dictionary of properties to launch try job."""
1754 return self._codereview_impl.GetTryJobProperties(patchset=patchset)
tandrii8c5a3532016-11-04 07:52:02 -07001755
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001756 def __getattr__(self, attr):
1757 # This is because lots of untested code accesses Rietveld-specific stuff
1758 # directly, and it's hard to fix for sure. So, just let it work, and fix
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00001759 # on a case by case basis.
tandrii4d895502016-08-18 08:26:19 -07001760 # Note that child method defines __getattr__ as well, and forwards it here,
1761 # because _RietveldChangelistImpl is not cleaned up yet, and given
1762 # deprecation of Rietveld, it should probably be just removed.
1763 # Until that time, avoid infinite recursion by bypassing __getattr__
1764 # of implementation class.
1765 return self._codereview_impl.__getattribute__(attr)
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001766
1767
1768class _ChangelistCodereviewBase(object):
1769 """Abstract base class encapsulating codereview specifics of a changelist."""
1770 def __init__(self, changelist):
1771 self._changelist = changelist # instance of Changelist
1772
1773 def __getattr__(self, attr):
1774 # Forward methods to changelist.
1775 # TODO(tandrii): maybe clean up _GerritChangelistImpl and
1776 # _RietveldChangelistImpl to avoid this hack?
1777 return getattr(self._changelist, attr)
1778
1779 def GetStatus(self):
1780 """Apply a rough heuristic to give a simple summary of an issue's review
1781 or CQ status, assuming adherence to a common workflow.
1782
1783 Returns None if no issue for this branch, or specific string keywords.
1784 """
1785 raise NotImplementedError()
1786
1787 def GetCodereviewServer(self):
1788 """Returns server URL without end slash, like "https://codereview.com"."""
1789 raise NotImplementedError()
1790
Kenneth Russell61e2ed42017-02-15 11:47:13 -08001791 def FetchDescription(self, force=False):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001792 """Fetches and returns description from the codereview server."""
1793 raise NotImplementedError()
1794
tandrii5d48c322016-08-18 16:19:37 -07001795 @classmethod
1796 def IssueConfigKey(cls):
1797 """Returns branch setting storing issue number."""
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001798 raise NotImplementedError()
1799
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001800 @classmethod
tandrii5d48c322016-08-18 16:19:37 -07001801 def PatchsetConfigKey(cls):
1802 """Returns branch setting storing patchset number."""
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001803 raise NotImplementedError()
1804
tandrii5d48c322016-08-18 16:19:37 -07001805 @classmethod
1806 def CodereviewServerConfigKey(cls):
1807 """Returns branch setting storing codereview server."""
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001808 raise NotImplementedError()
1809
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00001810 def _PostUnsetIssueProperties(self):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001811 """Which branch-specific properties to erase when unsetting issue."""
tandrii5d48c322016-08-18 16:19:37 -07001812 return []
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00001813
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001814 def GetGerritObjForPresubmit(self):
1815 # None is valid return value, otherwise presubmit_support.GerritAccessor.
1816 return None
1817
dsansomee2d6fd92016-09-08 00:10:47 -07001818 def UpdateDescriptionRemote(self, description, force=False):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001819 """Update the description on codereview site."""
1820 raise NotImplementedError()
1821
Aaron Gable636b13f2017-07-14 10:42:48 -07001822 def AddComment(self, message, publish=None):
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01001823 """Posts a comment to the codereview site."""
1824 raise NotImplementedError()
1825
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001826 def GetCommentsSummary(self, readable=True):
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01001827 raise NotImplementedError()
1828
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001829 def CloseIssue(self):
1830 """Closes the issue."""
1831 raise NotImplementedError()
1832
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001833 def GetMostRecentPatchset(self):
1834 """Returns the most recent patchset number from the codereview site."""
1835 raise NotImplementedError()
1836
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001837 def CMDPatchWithParsedIssue(self, parsed_issue_arg, reject, nocommit,
Aaron Gable62619a32017-06-16 08:22:09 -07001838 directory, force):
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001839 """Fetches and applies the issue.
1840
1841 Arguments:
1842 parsed_issue_arg: instance of _ParsedIssueNumberArgument.
1843 reject: if True, reject the failed patch instead of switching to 3-way
1844 merge. Rietveld only.
1845 nocommit: do not commit the patch, thus leave the tree dirty. Rietveld
1846 only.
1847 directory: switch to directory before applying the patch. Rietveld only.
Aaron Gable62619a32017-06-16 08:22:09 -07001848 force: if true, overwrites existing local state.
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001849 """
1850 raise NotImplementedError()
1851
1852 @staticmethod
1853 def ParseIssueURL(parsed_url):
1854 """Parses url and returns instance of _ParsedIssueNumberArgument or None if
1855 failed."""
1856 raise NotImplementedError()
1857
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01001858 def EnsureAuthenticated(self, force, refresh=False):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001859 """Best effort check that user is authenticated with codereview server.
1860
1861 Arguments:
1862 force: whether to skip confirmation questions.
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01001863 refresh: whether to attempt to refresh credentials. Ignored if not
1864 applicable.
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001865 """
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001866 raise NotImplementedError()
1867
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001868 def EnsureCanUploadPatchset(self, force):
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01001869 """Best effort check that uploading isn't supposed to fail for predictable
1870 reasons.
1871
1872 This method should raise informative exception if uploading shouldn't
1873 proceed.
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001874
1875 Arguments:
1876 force: whether to skip confirmation questions.
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01001877 """
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001878 raise NotImplementedError()
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01001879
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001880 def CMDUploadChange(self, options, git_diff_args, custom_cl_base, change):
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00001881 """Uploads a change to codereview."""
1882 raise NotImplementedError()
1883
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001884 def SetCQState(self, new_state):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001885 """Updates the CQ state for the latest patchset.
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001886
1887 Issue must have been already uploaded and known.
1888 """
1889 raise NotImplementedError()
1890
tandriie113dfd2016-10-11 10:20:12 -07001891 def CannotTriggerTryJobReason(self):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001892 """Returns reason (str) if unable trigger try jobs on this CL or None."""
tandriie113dfd2016-10-11 10:20:12 -07001893 raise NotImplementedError()
1894
tandriide281ae2016-10-12 06:02:30 -07001895 def GetIssueOwner(self):
1896 raise NotImplementedError()
1897
Edward Lemur707d70b2018-02-07 00:50:14 +01001898 def GetReviewers(self):
1899 raise NotImplementedError()
1900
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001901 def GetTryJobProperties(self, patchset=None):
tandriide281ae2016-10-12 06:02:30 -07001902 raise NotImplementedError()
1903
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001904
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001905class _GerritChangelistImpl(_ChangelistCodereviewBase):
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01001906 def __init__(self, changelist, auth_config=None, codereview_host=None):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001907 # auth_config is Rietveld thing, kept here to preserve interface only.
1908 super(_GerritChangelistImpl, self).__init__(changelist)
1909 self._change_id = None
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001910 # Lazily cached values.
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001911 self._gerrit_host = None # e.g. chromium-review.googlesource.com
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01001912 self._gerrit_server = None # e.g. https://chromium-review.googlesource.com
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01001913 # Map from change number (issue) to its detail cache.
1914 self._detail_cache = {}
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001915
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01001916 if codereview_host is not None:
1917 assert not codereview_host.startswith('https://'), codereview_host
1918 self._gerrit_host = codereview_host
1919 self._gerrit_server = 'https://%s' % codereview_host
1920
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001921 def _GetGerritHost(self):
1922 # Lazy load of configs.
1923 self.GetCodereviewServer()
tandriie32e3ea2016-06-22 02:52:48 -07001924 if self._gerrit_host and '.' not in self._gerrit_host:
1925 # Abbreviated domain like "chromium" instead of chromium.googlesource.com.
1926 # This happens for internal stuff http://crbug.com/614312.
1927 parsed = urlparse.urlparse(self.GetRemoteUrl())
1928 if parsed.scheme == 'sso':
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001929 print('WARNING: using non-https URLs for remote is likely broken\n'
tandriie32e3ea2016-06-22 02:52:48 -07001930 ' Your current remote is: %s' % self.GetRemoteUrl())
1931 self._gerrit_host = '%s.googlesource.com' % self._gerrit_host
1932 self._gerrit_server = 'https://%s' % self._gerrit_host
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001933 return self._gerrit_host
1934
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001935 def _GetGitHost(self):
1936 """Returns git host to be used when uploading change to Gerrit."""
Edward Lemur298f2cf2019-02-22 21:40:39 +00001937 remote_url = self.GetRemoteUrl()
1938 if not remote_url:
1939 return None
1940 return urlparse.urlparse(remote_url).netloc
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001941
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001942 def GetCodereviewServer(self):
1943 if not self._gerrit_server:
1944 # If we're on a branch then get the server potentially associated
1945 # with that branch.
1946 if self.GetIssue():
tandrii5d48c322016-08-18 16:19:37 -07001947 self._gerrit_server = self._GitGetBranchConfigValue(
1948 self.CodereviewServerConfigKey())
1949 if self._gerrit_server:
1950 self._gerrit_host = urlparse.urlparse(self._gerrit_server).netloc
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001951 if not self._gerrit_server:
1952 # We assume repo to be hosted on Gerrit, and hence Gerrit server
1953 # has "-review" suffix for lowest level subdomain.
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001954 parts = self._GetGitHost().split('.')
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001955 parts[0] = parts[0] + '-review'
1956 self._gerrit_host = '.'.join(parts)
1957 self._gerrit_server = 'https://%s' % self._gerrit_host
1958 return self._gerrit_server
1959
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00001960 def _GetGerritProject(self):
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001961 """Returns Gerrit project name based on remote git URL."""
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00001962 remote_url = self.GetRemoteUrl()
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001963 if remote_url is None:
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00001964 logging.warn('can\'t detect Gerrit project.')
1965 return None
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001966 project = urlparse.urlparse(remote_url).path.strip('/')
1967 if project.endswith('.git'):
1968 project = project[:-len('.git')]
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00001969 # *.googlesource.com hosts ensure that Git/Gerrit projects don't start with
1970 # 'a/' prefix, because 'a/' prefix is used to force authentication in
1971 # gitiles/git-over-https protocol. E.g.,
1972 # https://chromium.googlesource.com/a/v8/v8 refers to the same repo/project
1973 # as
1974 # https://chromium.googlesource.com/v8/v8
1975 if project.startswith('a/'):
1976 project = project[len('a/'):]
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001977 return project
1978
Andrii Shyshkalovd06cc782018-08-23 17:24:19 +00001979 def _GerritChangeIdentifier(self):
1980 """Handy method for gerrit_util.ChangeIdentifier for a given CL.
1981
1982 Not to be confused by value of "Change-Id:" footer.
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00001983 If Gerrit project can be determined, this will speed up Gerrit HTTP API RPC.
Andrii Shyshkalovd06cc782018-08-23 17:24:19 +00001984 """
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00001985 project = self._GetGerritProject()
1986 if project:
1987 return gerrit_util.ChangeIdentifier(project, self.GetIssue())
1988 # Fall back on still unique, but less efficient change number.
1989 return str(self.GetIssue())
Andrii Shyshkalovd06cc782018-08-23 17:24:19 +00001990
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001991 @classmethod
tandrii5d48c322016-08-18 16:19:37 -07001992 def IssueConfigKey(cls):
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001993 return 'gerritissue'
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001994
tandrii5d48c322016-08-18 16:19:37 -07001995 @classmethod
1996 def PatchsetConfigKey(cls):
1997 return 'gerritpatchset'
1998
1999 @classmethod
2000 def CodereviewServerConfigKey(cls):
2001 return 'gerritserver'
2002
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01002003 def EnsureAuthenticated(self, force, refresh=None):
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00002004 """Best effort check that user is authenticated with Gerrit server."""
tandrii@chromium.org28253532016-04-14 13:46:56 +00002005 if settings.GetGerritSkipEnsureAuthenticated():
2006 # For projects with unusual authentication schemes.
2007 # See http://crbug.com/603378.
2008 return
Vadim Shtayurab250ec12018-10-04 00:21:08 +00002009
2010 # Check presence of cookies only if using cookies-based auth method.
2011 cookie_auth = gerrit_util.Authenticator.get()
2012 if not isinstance(cookie_auth, gerrit_util.CookiesAuthenticator):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002013 return
Vadim Shtayurab250ec12018-10-04 00:21:08 +00002014
Daniel Chengcf6269b2019-05-18 01:02:12 +00002015 if urlparse.urlparse(self.GetRemoteUrl()).scheme != 'https':
2016 print('WARNING: Ignoring branch %s with non-https remote %s' %
2017 (self._changelist.branch, self.GetRemoteUrl()))
2018 return
2019
Vadim Shtayurab250ec12018-10-04 00:21:08 +00002020 # Lazy-loader to identify Gerrit and Git hosts.
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002021 self.GetCodereviewServer()
2022 git_host = self._GetGitHost()
Edward Lemur298f2cf2019-02-22 21:40:39 +00002023 assert self._gerrit_server and self._gerrit_host and git_host
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002024
2025 gerrit_auth = cookie_auth.get_auth_header(self._gerrit_host)
2026 git_auth = cookie_auth.get_auth_header(git_host)
2027 if gerrit_auth and git_auth:
2028 if gerrit_auth == git_auth:
2029 return
Andrii Shyshkalov354e1d22017-06-09 19:31:33 +02002030 all_gsrc = cookie_auth.get_auth_header('d0esN0tEx1st.googlesource.com')
Raul Tambre80ee78e2019-05-06 22:41:05 +00002031 print(
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002032 'WARNING: You have different credentials for Gerrit and git hosts:\n'
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002033 ' %s\n'
2034 ' %s\n'
Andrii Shyshkalov51acef92017-04-11 17:19:59 +02002035 ' Consider running the following command:\n'
2036 ' git cl creds-check\n'
Andrii Shyshkalov354e1d22017-06-09 19:31:33 +02002037 ' %s\n'
Raul Tambre80ee78e2019-05-06 22:41:05 +00002038 ' %s' %
Andrii Shyshkalov51acef92017-04-11 17:19:59 +02002039 (git_host, self._gerrit_host,
Andrii Shyshkalov354e1d22017-06-09 19:31:33 +02002040 ('Hint: delete creds for .googlesource.com' if all_gsrc else ''),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002041 cookie_auth.get_new_password_message(git_host)))
2042 if not force:
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002043 confirm_or_exit('If you know what you are doing', action='continue')
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002044 return
2045 else:
2046 missing = (
Anna Henningsen4e891442017-07-06 21:40:58 +02002047 ([] if gerrit_auth else [self._gerrit_host]) +
2048 ([] if git_auth else [git_host]))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002049 DieWithError('Credentials for the following hosts are required:\n'
2050 ' %s\n'
2051 'These are read from %s (or legacy %s)\n'
2052 '%s' % (
2053 '\n '.join(missing),
2054 cookie_auth.get_gitcookies_path(),
2055 cookie_auth.get_netrc_path(),
2056 cookie_auth.get_new_password_message(git_host)))
2057
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002058 def EnsureCanUploadPatchset(self, force):
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01002059 if not self.GetIssue():
2060 return
2061
2062 # Warm change details cache now to avoid RPCs later, reducing latency for
2063 # developers.
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002064 self._GetChangeDetail(
Andrii Shyshkalovc4a73562018-09-25 18:40:17 +00002065 ['DETAILED_ACCOUNTS', 'CURRENT_REVISION', 'CURRENT_COMMIT', 'LABELS'])
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01002066
2067 status = self._GetChangeDetail()['status']
2068 if status in ('MERGED', 'ABANDONED'):
2069 DieWithError('Change %s has been %s, new uploads are not allowed' %
2070 (self.GetIssueURL(),
2071 'submitted' if status == 'MERGED' else 'abandoned'))
2072
Vadim Shtayurab250ec12018-10-04 00:21:08 +00002073 # TODO(vadimsh): For some reason the chunk of code below was skipped if
2074 # 'is_gce' is True. I'm just refactoring it to be 'skip if not cookies'.
2075 # Apparently this check is not very important? Otherwise get_auth_email
2076 # could have been added to other implementations of Authenticator.
2077 cookies_auth = gerrit_util.Authenticator.get()
2078 if not isinstance(cookies_auth, gerrit_util.CookiesAuthenticator):
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002079 return
Vadim Shtayurab250ec12018-10-04 00:21:08 +00002080
2081 cookies_user = cookies_auth.get_auth_email(self._GetGerritHost())
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002082 if self.GetIssueOwner() == cookies_user:
2083 return
2084 logging.debug('change %s owner is %s, cookies user is %s',
2085 self.GetIssue(), self.GetIssueOwner(), cookies_user)
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002086 # Maybe user has linked accounts or something like that,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002087 # so ask what Gerrit thinks of this user.
2088 details = gerrit_util.GetAccountDetails(self._GetGerritHost(), 'self')
2089 if details['email'] == self.GetIssueOwner():
2090 return
2091 if not force:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002092 print('WARNING: Change %s is owned by %s, but you authenticate to Gerrit '
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002093 'as %s.\n'
2094 'Uploading may fail due to lack of permissions.' %
2095 (self.GetIssue(), self.GetIssueOwner(), details['email']))
2096 confirm_or_exit(action='upload')
2097
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002098 def _PostUnsetIssueProperties(self):
2099 """Which branch-specific properties to erase when unsetting issue."""
tandrii5d48c322016-08-18 16:19:37 -07002100 return ['gerritsquashhash']
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002101
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00002102 def GetGerritObjForPresubmit(self):
2103 return presubmit_support.GerritAccessor(self._GetGerritHost())
2104
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002105 def GetStatus(self):
tandrii@chromium.org013a2802016-03-29 09:52:33 +00002106 """Apply a rough heuristic to give a simple summary of an issue's review
2107 or CQ status, assuming adherence to a common workflow.
2108
2109 Returns None if no issue for this branch, or one of the following keywords:
Aaron Gable9ab38c62017-04-06 14:36:33 -07002110 * 'error' - error from review tool (including deleted issues)
2111 * 'unsent' - no reviewers added
2112 * 'waiting' - waiting for review
2113 * 'reply' - waiting for uploader to reply to review
2114 * 'lgtm' - Code-Review label has been set
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00002115 * 'dry-run' - dry-running in the CQ
2116 * 'commit' - in the CQ
Aaron Gable9ab38c62017-04-06 14:36:33 -07002117 * 'closed' - successfully submitted or abandoned
tandrii@chromium.org013a2802016-03-29 09:52:33 +00002118 """
2119 if not self.GetIssue():
2120 return None
2121
2122 try:
Aaron Gable9ab38c62017-04-06 14:36:33 -07002123 data = self._GetChangeDetail([
2124 'DETAILED_LABELS', 'CURRENT_REVISION', 'SUBMITTABLE'])
Aaron Gablea45ee112016-11-22 15:14:38 -08002125 except (httplib.HTTPException, GerritChangeNotExists):
tandrii@chromium.org013a2802016-03-29 09:52:33 +00002126 return 'error'
2127
tandrii@chromium.org5e1bf382016-05-17 08:43:24 +00002128 if data['status'] in ('ABANDONED', 'MERGED'):
tandrii@chromium.org013a2802016-03-29 09:52:33 +00002129 return 'closed'
2130
Andrii Shyshkalovb8268ca2019-04-03 23:33:44 +00002131 cq_label = data['labels'].get('Commit-Queue', {})
2132 max_cq_vote = 0
2133 for vote in cq_label.get('all', []):
2134 max_cq_vote = max(max_cq_vote, vote.get('value', 0))
2135 if max_cq_vote == 2:
Aaron Gable9ab38c62017-04-06 14:36:33 -07002136 return 'commit'
Andrii Shyshkalovb8268ca2019-04-03 23:33:44 +00002137 if max_cq_vote == 1:
2138 return 'dry-run'
tandrii@chromium.org013a2802016-03-29 09:52:33 +00002139
Aaron Gable9ab38c62017-04-06 14:36:33 -07002140 if data['labels'].get('Code-Review', {}).get('approved'):
2141 return 'lgtm'
tandrii@chromium.org013a2802016-03-29 09:52:33 +00002142
2143 if not data.get('reviewers', {}).get('REVIEWER', []):
2144 return 'unsent'
2145
Andrii Shyshkalov33e88a42017-01-27 14:45:30 +01002146 owner = data['owner'].get('_account_id')
Aaron Gable9ab38c62017-04-06 14:36:33 -07002147 messages = sorted(data.get('messages', []), key=lambda m: m.get('updated'))
2148 last_message_author = messages.pop().get('author', {})
2149 while last_message_author:
Andrii Shyshkalov33e88a42017-01-27 14:45:30 +01002150 if last_message_author.get('email') == COMMIT_BOT_EMAIL:
2151 # Ignore replies from CQ.
Aaron Gable9ab38c62017-04-06 14:36:33 -07002152 last_message_author = messages.pop().get('author', {})
Andrii Shyshkalov33e88a42017-01-27 14:45:30 +01002153 continue
Aaron Gable9ab38c62017-04-06 14:36:33 -07002154 if last_message_author.get('_account_id') == owner:
2155 # Most recent message was by owner.
2156 return 'waiting'
2157 else:
tandrii@chromium.org013a2802016-03-29 09:52:33 +00002158 # Some reply from non-owner.
2159 return 'reply'
Aaron Gable9ab38c62017-04-06 14:36:33 -07002160
2161 # Somehow there are no messages even though there are reviewers.
2162 return 'unsent'
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002163
2164 def GetMostRecentPatchset(self):
tandrii@chromium.org013a2802016-03-29 09:52:33 +00002165 data = self._GetChangeDetail(['CURRENT_REVISION'])
Aaron Gablee8856ee2017-12-07 12:41:46 -08002166 patchset = data['revisions'][data['current_revision']]['_number']
2167 self.SetPatchset(patchset)
2168 return patchset
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002169
Kenneth Russell61e2ed42017-02-15 11:47:13 -08002170 def FetchDescription(self, force=False):
2171 data = self._GetChangeDetail(['CURRENT_REVISION', 'CURRENT_COMMIT'],
2172 no_cache=force)
tandrii@chromium.org2d3da632016-04-25 19:23:27 +00002173 current_rev = data['current_revision']
Dan Beamcf6df902018-11-08 01:48:37 +00002174 return data['revisions'][current_rev]['commit']['message'].encode(
2175 'utf-8', 'ignore')
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002176
dsansomee2d6fd92016-09-08 00:10:47 -07002177 def UpdateDescriptionRemote(self, description, force=False):
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002178 if gerrit_util.HasPendingChangeEdit(
2179 self._GetGerritHost(), self._GerritChangeIdentifier()):
dsansomee2d6fd92016-09-08 00:10:47 -07002180 if not force:
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002181 confirm_or_exit(
dsansomee2d6fd92016-09-08 00:10:47 -07002182 'The description cannot be modified while the issue has a pending '
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002183 'unpublished edit. Either publish the edit in the Gerrit web UI '
2184 'or delete it.\n\n', action='delete the unpublished edit')
dsansomee2d6fd92016-09-08 00:10:47 -07002185
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002186 gerrit_util.DeletePendingChangeEdit(
2187 self._GetGerritHost(), self._GerritChangeIdentifier())
2188 gerrit_util.SetCommitMessage(
2189 self._GetGerritHost(), self._GerritChangeIdentifier(),
2190 description, notify='NONE')
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002191
Aaron Gable636b13f2017-07-14 10:42:48 -07002192 def AddComment(self, message, publish=None):
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002193 gerrit_util.SetReview(
2194 self._GetGerritHost(), self._GerritChangeIdentifier(),
2195 msg=message, ready=publish)
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002196
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002197 def GetCommentsSummary(self, readable=True):
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002198 # DETAILED_ACCOUNTS is to get emails in accounts.
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002199 # CURRENT_REVISION is included to get the latest patchset so that
2200 # only the robot comments from the latest patchset can be shown.
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002201 messages = self._GetChangeDetail(
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002202 options=['MESSAGES', 'DETAILED_ACCOUNTS',
2203 'CURRENT_REVISION']).get('messages', [])
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002204 file_comments = gerrit_util.GetChangeComments(
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002205 self._GetGerritHost(), self._GerritChangeIdentifier())
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002206 robot_file_comments = gerrit_util.GetChangeRobotComments(
2207 self._GetGerritHost(), self._GerritChangeIdentifier())
2208
2209 # Add the robot comments onto the list of comments, but only
2210 # keep those that are from the latest pachset.
2211 latest_patch_set = self.GetMostRecentPatchset()
2212 for path, robot_comments in robot_file_comments.iteritems():
2213 line_comments = file_comments.setdefault(path, [])
2214 line_comments.extend(
2215 [c for c in robot_comments if c['patch_set'] == latest_patch_set])
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002216
2217 # Build dictionary of file comments for easy access and sorting later.
2218 # {author+date: {path: {patchset: {line: url+message}}}}
2219 comments = collections.defaultdict(
2220 lambda: collections.defaultdict(lambda: collections.defaultdict(dict)))
2221 for path, line_comments in file_comments.iteritems():
2222 for comment in line_comments:
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002223 tag = comment.get('tag', '')
2224 if tag.startswith('autogenerated') and 'robot_id' not in comment:
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002225 continue
2226 key = (comment['author']['email'], comment['updated'])
2227 if comment.get('side', 'REVISION') == 'PARENT':
2228 patchset = 'Base'
2229 else:
2230 patchset = 'PS%d' % comment['patch_set']
2231 line = comment.get('line', 0)
2232 url = ('https://%s/c/%s/%s/%s#%s%s' %
2233 (self._GetGerritHost(), self.GetIssue(), comment['patch_set'], path,
2234 'b' if comment.get('side') == 'PARENT' else '',
2235 str(line) if line else ''))
2236 comments[key][path][patchset][line] = (url, comment['message'])
2237
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002238 summaries = []
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002239 for msg in messages:
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002240 summary = self._BuildCommentSummary(msg, comments, readable)
2241 if summary:
2242 summaries.append(summary)
2243 return summaries
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002244
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002245 @staticmethod
2246 def _BuildCommentSummary(msg, comments, readable):
2247 key = (msg['author']['email'], msg['date'])
2248 # Don't bother showing autogenerated messages that don't have associated
2249 # file or line comments. this will filter out most autogenerated
2250 # messages, but will keep robot comments like those from Tricium.
2251 is_autogenerated = msg.get('tag', '').startswith('autogenerated')
2252 if is_autogenerated and not comments.get(key):
2253 return None
2254 message = msg['message']
2255 # Gerrit spits out nanoseconds.
2256 assert len(msg['date'].split('.')[-1]) == 9
2257 date = datetime.datetime.strptime(msg['date'][:-3],
2258 '%Y-%m-%d %H:%M:%S.%f')
2259 if key in comments:
2260 message += '\n'
2261 for path, patchsets in sorted(comments.get(key, {}).items()):
2262 if readable:
2263 message += '\n%s' % path
2264 for patchset, lines in sorted(patchsets.items()):
2265 for line, (url, content) in sorted(lines.items()):
2266 if line:
2267 line_str = 'Line %d' % line
2268 path_str = '%s:%d:' % (path, line)
2269 else:
2270 line_str = 'File comment'
2271 path_str = '%s:0:' % path
2272 if readable:
2273 message += '\n %s, %s: %s' % (patchset, line_str, url)
2274 message += '\n %s\n' % content
2275 else:
2276 message += '\n%s ' % path_str
2277 message += '\n%s\n' % content
2278
2279 return _CommentSummary(
2280 date=date,
2281 message=message,
2282 sender=msg['author']['email'],
2283 autogenerated=is_autogenerated,
2284 # These could be inferred from the text messages and correlated with
2285 # Code-Review label maximum, however this is not reliable.
2286 # Leaving as is until the need arises.
2287 approval=False,
2288 disapproval=False,
2289 )
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01002290
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002291 def CloseIssue(self):
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002292 gerrit_util.AbandonChange(
2293 self._GetGerritHost(), self._GerritChangeIdentifier(), msg='')
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002294
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002295 def SubmitIssue(self, wait_for_merge=True):
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002296 gerrit_util.SubmitChange(
2297 self._GetGerritHost(), self._GerritChangeIdentifier(),
2298 wait_for_merge=wait_for_merge)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002299
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00002300 def _GetChangeDetail(self, options=None, no_cache=False):
2301 """Returns details of associated Gerrit change and caching results.
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002302
2303 If fresh data is needed, set no_cache=True which will clear cache and
2304 thus new data will be fetched from Gerrit.
2305 """
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002306 options = options or []
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002307 assert self.GetIssue(), 'issue is required to query Gerrit'
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002308
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01002309 # Optimization to avoid multiple RPCs:
2310 if (('CURRENT_REVISION' in options or 'ALL_REVISIONS' in options) and
2311 'CURRENT_COMMIT' not in options):
2312 options.append('CURRENT_COMMIT')
2313
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002314 # Normalize issue and options for consistent keys in cache.
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002315 cache_key = str(self.GetIssue())
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002316 options = [o.upper() for o in options]
2317
2318 # Check in cache first unless no_cache is True.
2319 if no_cache:
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002320 self._detail_cache.pop(cache_key, None)
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002321 else:
2322 options_set = frozenset(options)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002323 for cached_options_set, data in self._detail_cache.get(cache_key, []):
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002324 # Assumption: data fetched before with extra options is suitable
2325 # for return for a smaller set of options.
2326 # For example, if we cached data for
2327 # options=[CURRENT_REVISION, DETAILED_FOOTERS]
2328 # and request is for options=[CURRENT_REVISION],
2329 # THEN we can return prior cached data.
2330 if options_set.issubset(cached_options_set):
2331 return data
2332
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01002333 try:
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002334 data = gerrit_util.GetChangeDetail(
2335 self._GetGerritHost(), self._GerritChangeIdentifier(), options)
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01002336 except gerrit_util.GerritError as e:
2337 if e.http_status == 404:
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002338 raise GerritChangeNotExists(self.GetIssue(), self.GetCodereviewServer())
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01002339 raise
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002340
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002341 self._detail_cache.setdefault(cache_key, []).append(
2342 (frozenset(options), data))
tandriic2405f52016-10-10 08:13:15 -07002343 return data
tandrii@chromium.org013a2802016-03-29 09:52:33 +00002344
Andrii Shyshkalovcc5f17e2018-08-22 23:35:59 +00002345 def _GetChangeCommit(self):
Andrii Shyshkalove2633162018-08-27 23:50:31 +00002346 assert self.GetIssue(), 'issue must be set to query Gerrit'
Aaron Gable6f5a8d92017-04-18 14:49:05 -07002347 try:
Andrii Shyshkalove2633162018-08-27 23:50:31 +00002348 data = gerrit_util.GetChangeCommit(
2349 self._GetGerritHost(), self._GerritChangeIdentifier())
Aaron Gable6f5a8d92017-04-18 14:49:05 -07002350 except gerrit_util.GerritError as e:
2351 if e.http_status == 404:
Andrii Shyshkalove2633162018-08-27 23:50:31 +00002352 raise GerritChangeNotExists(self.GetIssue(), self.GetCodereviewServer())
Aaron Gable6f5a8d92017-04-18 14:49:05 -07002353 raise
agable32978d92016-11-01 12:55:02 -07002354 return data
2355
Karen Qian40c19422019-03-13 21:28:29 +00002356 def _IsCqConfigured(self):
2357 detail = self._GetChangeDetail(['LABELS'])
2358 if not u'Commit-Queue' in detail.get('labels', {}):
2359 return False
2360 # TODO(crbug/753213): Remove temporary hack
2361 if ('https://chromium.googlesource.com/chromium/src' ==
2362 self._changelist.GetRemoteUrl() and
2363 detail['branch'].startswith('refs/branch-heads/')):
2364 return False
2365 return True
2366
Olivier Robin75ee7252018-04-13 10:02:56 +02002367 def CMDLand(self, force, bypass_hooks, verbose, parallel):
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002368 if git_common.is_dirty_git_tree('land'):
2369 return 1
Karen Qian40c19422019-03-13 21:28:29 +00002370
tandriid60367b2016-06-22 05:25:12 -07002371 detail = self._GetChangeDetail(['CURRENT_REVISION', 'LABELS'])
Karen Qian40c19422019-03-13 21:28:29 +00002372 if not force and self._IsCqConfigured():
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00002373 confirm_or_exit('\nIt seems this repository has a CQ, '
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002374 'which can test and land changes for you. '
2375 'Are you sure you wish to bypass it?\n',
2376 action='bypass CQ')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002377 differs = True
tandriic4344b52016-08-29 06:04:54 -07002378 last_upload = self._GitGetBranchConfigValue('gerritsquashhash')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002379 # Note: git diff outputs nothing if there is no diff.
2380 if not last_upload or RunGit(['diff', last_upload]).strip():
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002381 print('WARNING: Some changes from local branch haven\'t been uploaded.')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002382 else:
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002383 if detail['current_revision'] == last_upload:
2384 differs = False
2385 else:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002386 print('WARNING: Local branch contents differ from latest uploaded '
2387 'patchset.')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002388 if differs:
2389 if not force:
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002390 confirm_or_exit(
2391 'Do you want to submit latest Gerrit patchset and bypass hooks?\n',
2392 action='submit')
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002393 print('WARNING: Bypassing hooks and submitting latest uploaded patchset.')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002394 elif not bypass_hooks:
2395 hook_results = self.RunHook(
2396 committing=True,
2397 may_prompt=not force,
2398 verbose=verbose,
Olivier Robin75ee7252018-04-13 10:02:56 +02002399 change=self.GetChange(self.GetCommonAncestorWithUpstream(), None),
2400 parallel=parallel)
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002401 if not hook_results.should_continue():
2402 return 1
2403
2404 self.SubmitIssue(wait_for_merge=True)
2405 print('Issue %s has been submitted.' % self.GetIssueURL())
agable32978d92016-11-01 12:55:02 -07002406 links = self._GetChangeCommit().get('web_links', [])
2407 for link in links:
Aaron Gable02cdbb42016-12-13 16:24:25 -08002408 if link.get('name') == 'gitiles' and link.get('url'):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002409 print('Landed as: %s' % link.get('url'))
agable32978d92016-11-01 12:55:02 -07002410 break
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002411 return 0
2412
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002413 def CMDPatchWithParsedIssue(self, parsed_issue_arg, reject, nocommit,
Aaron Gable62619a32017-06-16 08:22:09 -07002414 directory, force):
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002415 assert not reject
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002416 assert not directory
2417 assert parsed_issue_arg.valid
2418
2419 self._changelist.issue = parsed_issue_arg.issue
2420
2421 if parsed_issue_arg.hostname:
2422 self._gerrit_host = parsed_issue_arg.hostname
2423 self._gerrit_server = 'https://%s' % self._gerrit_host
2424
tandriic2405f52016-10-10 08:13:15 -07002425 try:
2426 detail = self._GetChangeDetail(['ALL_REVISIONS'])
Aaron Gablea45ee112016-11-22 15:14:38 -08002427 except GerritChangeNotExists as e:
tandriic2405f52016-10-10 08:13:15 -07002428 DieWithError(str(e))
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002429
2430 if not parsed_issue_arg.patchset:
2431 # Use current revision by default.
2432 revision_info = detail['revisions'][detail['current_revision']]
2433 patchset = int(revision_info['_number'])
2434 else:
2435 patchset = parsed_issue_arg.patchset
2436 for revision_info in detail['revisions'].itervalues():
2437 if int(revision_info['_number']) == parsed_issue_arg.patchset:
2438 break
2439 else:
Aaron Gablea45ee112016-11-22 15:14:38 -08002440 DieWithError('Couldn\'t find patchset %i in change %i' %
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002441 (parsed_issue_arg.patchset, self.GetIssue()))
2442
Aaron Gable697a91b2018-01-19 15:20:15 -08002443 remote_url = self._changelist.GetRemoteUrl()
2444 if remote_url.endswith('.git'):
2445 remote_url = remote_url[:-len('.git')]
erikchen0d14d0d2018-08-28 18:57:09 +00002446 remote_url = remote_url.rstrip('/')
2447
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002448 fetch_info = revision_info['fetch']['http']
erikchen0d14d0d2018-08-28 18:57:09 +00002449 fetch_info['url'] = fetch_info['url'].rstrip('/')
Aaron Gable697a91b2018-01-19 15:20:15 -08002450
2451 if remote_url != fetch_info['url']:
2452 DieWithError('Trying to patch a change from %s but this repo appears '
2453 'to be %s.' % (fetch_info['url'], remote_url))
2454
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002455 RunGit(['fetch', fetch_info['url'], fetch_info['ref']])
Aaron Gable9387b4f2017-06-08 10:50:03 -07002456
Aaron Gable62619a32017-06-16 08:22:09 -07002457 if force:
2458 RunGit(['reset', '--hard', 'FETCH_HEAD'])
2459 print('Checked out commit for change %i patchset %i locally' %
2460 (parsed_issue_arg.issue, patchset))
Stefan Zager2d5f0392017-10-10 15:17:53 -07002461 elif nocommit:
2462 RunGit(['cherry-pick', '--no-commit', 'FETCH_HEAD'])
2463 print('Patch applied to index.')
Aaron Gable62619a32017-06-16 08:22:09 -07002464 else:
Aaron Gable9387b4f2017-06-08 10:50:03 -07002465 RunGit(['cherry-pick', 'FETCH_HEAD'])
2466 print('Committed patch for change %i patchset %i locally.' %
Aaron Gable62619a32017-06-16 08:22:09 -07002467 (parsed_issue_arg.issue, patchset))
2468 print('Note: this created a local commit which does not have '
2469 'the same hash as the one uploaded for review. This will make '
2470 'uploading changes based on top of this branch difficult.\n'
2471 'If you want to do that, use "git cl patch --force" instead.')
2472
Stefan Zagerd08043c2017-10-12 12:07:02 -07002473 if self.GetBranch():
2474 self.SetIssue(parsed_issue_arg.issue)
2475 self.SetPatchset(patchset)
2476 fetched_hash = RunGit(['rev-parse', 'FETCH_HEAD']).strip()
2477 self._GitSetBranchConfigValue('last-upload-hash', fetched_hash)
2478 self._GitSetBranchConfigValue('gerritsquashhash', fetched_hash)
2479 else:
2480 print('WARNING: You are in detached HEAD state.\n'
2481 'The patch has been applied to your checkout, but you will not be '
2482 'able to upload a new patch set to the gerrit issue.\n'
2483 'Try using the \'-b\' option if you would like to work on a '
2484 'branch and/or upload a new patch set.')
2485
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002486 return 0
2487
2488 @staticmethod
2489 def ParseIssueURL(parsed_url):
2490 if not parsed_url.scheme or not parsed_url.scheme.startswith('http'):
2491 return None
Aaron Gable01b91062017-08-24 17:48:40 -07002492 # Gerrit's new UI is https://domain/c/project/+/<issue_number>[/[patchset]]
2493 # But old GWT UI is https://domain/#/c/project/+/<issue_number>[/[patchset]]
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002494 # Short urls like https://domain/<issue_number> can be used, but don't allow
2495 # specifying the patchset (you'd 404), but we allow that here.
2496 if parsed_url.path == '/':
2497 part = parsed_url.fragment
2498 else:
2499 part = parsed_url.path
Bruce Dawson9c062012019-05-02 19:20:28 +00002500 match = re.match(r'(/c(/.*/\+)?)?/(\d+)(/(\d+)?/?)?$', part)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002501 if match:
2502 return _ParsedIssueNumberArgument(
Aaron Gable01b91062017-08-24 17:48:40 -07002503 issue=int(match.group(3)),
2504 patchset=int(match.group(5)) if match.group(5) else None,
Andrii Shyshkalov90f31922017-04-10 16:10:21 +02002505 hostname=parsed_url.netloc,
2506 codereview='gerrit')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002507 return None
2508
tandrii16e0b4e2016-06-07 10:34:28 -07002509 def _GerritCommitMsgHookCheck(self, offer_removal):
2510 hook = os.path.join(settings.GetRoot(), '.git', 'hooks', 'commit-msg')
2511 if not os.path.exists(hook):
2512 return
2513 # Crude attempt to distinguish Gerrit Codereview hook from potentially
2514 # custom developer made one.
2515 data = gclient_utils.FileRead(hook)
2516 if not('From Gerrit Code Review' in data and 'add_ChangeId()' in data):
2517 return
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002518 print('WARNING: You have Gerrit commit-msg hook installed.\n'
qyearsley12fa6ff2016-08-24 09:18:40 -07002519 'It is not necessary for uploading with git cl in squash mode, '
tandrii16e0b4e2016-06-07 10:34:28 -07002520 'and may interfere with it in subtle ways.\n'
2521 'We recommend you remove the commit-msg hook.')
2522 if offer_removal:
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002523 if ask_for_explicit_yes('Do you want to remove it now?'):
tandrii16e0b4e2016-06-07 10:34:28 -07002524 gclient_utils.rm_file_or_tree(hook)
2525 print('Gerrit commit-msg hook removed.')
2526 else:
2527 print('OK, will keep Gerrit commit-msg hook in place.')
2528
Edward Lemur1b52d872019-05-09 21:12:12 +00002529 def _CleanUpOldTraces(self):
2530 """Keep only the last |MAX_TRACES| traces."""
2531 try:
2532 traces = sorted([
2533 os.path.join(TRACES_DIR, f)
2534 for f in os.listdir(TRACES_DIR)
2535 if (os.path.isfile(os.path.join(TRACES_DIR, f))
2536 and not f.startswith('tmp'))
2537 ])
2538 traces_to_delete = traces[:-MAX_TRACES]
2539 for trace in traces_to_delete:
Daniel Chengcf6269b2019-05-18 01:02:12 +00002540 os.remove(trace)
Edward Lemur1b52d872019-05-09 21:12:12 +00002541 except OSError:
2542 print('WARNING: Failed to remove old git traces from\n'
2543 ' %s'
2544 'Consider removing them manually.' % TRACES_DIR)
Edward Lemurdc8e23d2019-05-07 00:45:48 +00002545
Edward Lemur5737f022019-05-17 01:24:00 +00002546 def _WriteGitPushTraces(self, trace_name, traces_dir, git_push_metadata):
Edward Lemur1b52d872019-05-09 21:12:12 +00002547 """Zip and write the git push traces stored in traces_dir."""
2548 gclient_utils.safe_makedirs(TRACES_DIR)
Edward Lemur1b52d872019-05-09 21:12:12 +00002549 traces_zip = trace_name + '-traces'
2550 traces_readme = trace_name + '-README'
Michael Mosse7f0b4c2019-05-08 04:36:24 +00002551 # Create a temporary dir to store git config and gitcookies in. It will be
2552 # compressed and stored next to the traces.
2553 git_info_dir = tempfile.mkdtemp()
Edward Lemur1b52d872019-05-09 21:12:12 +00002554 git_info_zip = trace_name + '-git-info'
2555
Edward Lemur5737f022019-05-17 01:24:00 +00002556 git_push_metadata['now'] = datetime_now().strftime('%c')
Eric Boren67c48202019-05-30 16:52:51 +00002557 if sys.stdin.encoding and sys.stdin.encoding != 'utf-8':
sangwoo.ko7a614332019-05-22 02:46:19 +00002558 git_push_metadata['now'] = git_push_metadata['now'].decode(
2559 sys.stdin.encoding)
2560
Edward Lemur1b52d872019-05-09 21:12:12 +00002561 git_push_metadata['trace_name'] = trace_name
2562 gclient_utils.FileWrite(
2563 traces_readme, TRACES_README_FORMAT % git_push_metadata)
2564
2565 # Keep only the first 6 characters of the git hashes on the packet
2566 # trace. This greatly decreases size after compression.
2567 packet_traces = os.path.join(traces_dir, 'trace-packet')
2568 if os.path.isfile(packet_traces):
2569 contents = gclient_utils.FileRead(packet_traces)
2570 gclient_utils.FileWrite(
2571 packet_traces, GIT_HASH_RE.sub(r'\1', contents))
2572 shutil.make_archive(traces_zip, 'zip', traces_dir)
2573
2574 # Collect and compress the git config and gitcookies.
2575 git_config = RunGit(['config', '-l'])
2576 gclient_utils.FileWrite(
2577 os.path.join(git_info_dir, 'git-config'),
2578 git_config)
2579
2580 cookie_auth = gerrit_util.Authenticator.get()
2581 if isinstance(cookie_auth, gerrit_util.CookiesAuthenticator):
2582 gitcookies_path = cookie_auth.get_gitcookies_path()
2583 if os.path.isfile(gitcookies_path):
2584 gitcookies = gclient_utils.FileRead(gitcookies_path)
2585 gclient_utils.FileWrite(
2586 os.path.join(git_info_dir, 'gitcookies'),
2587 GITCOOKIES_REDACT_RE.sub('REDACTED', gitcookies))
2588 shutil.make_archive(git_info_zip, 'zip', git_info_dir)
2589
Edward Lemur1b52d872019-05-09 21:12:12 +00002590 gclient_utils.rmtree(git_info_dir)
2591
2592 def _RunGitPushWithTraces(
2593 self, change_desc, refspec, refspec_opts, git_push_metadata):
2594 """Run git push and collect the traces resulting from the execution."""
2595 # Create a temporary directory to store traces in. Traces will be compressed
2596 # and stored in a 'traces' dir inside depot_tools.
2597 traces_dir = tempfile.mkdtemp()
Edward Lemur5737f022019-05-17 01:24:00 +00002598 trace_name = os.path.join(
2599 TRACES_DIR, datetime_now().strftime('%Y%m%dT%H%M%S.%f'))
Edward Lemur0f58ae42019-04-30 17:24:12 +00002600
2601 env = os.environ.copy()
2602 env['GIT_REDACT_COOKIES'] = 'o,SSO,GSSO_Uberproxy'
2603 env['GIT_TR2_EVENT'] = os.path.join(traces_dir, 'tr2-event')
Jonathan Nieder9779b142019-05-29 23:19:29 +00002604 env['GIT_TRACE2_EVENT'] = os.path.join(traces_dir, 'tr2-event')
Edward Lemur0f58ae42019-04-30 17:24:12 +00002605 env['GIT_TRACE_CURL'] = os.path.join(traces_dir, 'trace-curl')
2606 env['GIT_TRACE_CURL_NO_DATA'] = '1'
2607 env['GIT_TRACE_PACKET'] = os.path.join(traces_dir, 'trace-packet')
2608
2609 try:
2610 push_returncode = 0
Edward Lemur1b52d872019-05-09 21:12:12 +00002611 remote_url = self.GetRemoteUrl()
Edward Lemur0f58ae42019-04-30 17:24:12 +00002612 before_push = time_time()
2613 push_stdout = gclient_utils.CheckCallAndFilter(
Edward Lemur1b52d872019-05-09 21:12:12 +00002614 ['git', 'push', remote_url, refspec],
Edward Lemur0f58ae42019-04-30 17:24:12 +00002615 env=env,
2616 print_stdout=True,
2617 # Flush after every line: useful for seeing progress when running as
2618 # recipe.
2619 filter_fn=lambda _: sys.stdout.flush())
2620 except subprocess2.CalledProcessError as e:
2621 push_returncode = e.returncode
2622 DieWithError('Failed to create a change. Please examine output above '
2623 'for the reason of the failure.\n'
2624 'Hint: run command below to diagnose common Git/Gerrit '
2625 'credential problems:\n'
Edward Lemur5737f022019-05-17 01:24:00 +00002626 ' git cl creds-check\n'
2627 '\n'
2628 'If git-cl is not working correctly, file a bug under the '
2629 'Infra>SDK component including the files below.\n'
2630 'Review the files before upload, since they might contain '
2631 'sensitive information.\n'
2632 'Set the Restrict-View-Google label so that they are not '
2633 'publicly accessible.\n'
2634 + TRACES_MESSAGE % {'trace_name': trace_name},
Edward Lemur0f58ae42019-04-30 17:24:12 +00002635 change_desc)
2636 finally:
2637 execution_time = time_time() - before_push
2638 metrics.collector.add_repeated('sub_commands', {
2639 'command': 'git push',
2640 'execution_time': execution_time,
2641 'exit_code': push_returncode,
2642 'arguments': metrics_utils.extract_known_subcommand_args(refspec_opts),
2643 })
2644
Edward Lemur1b52d872019-05-09 21:12:12 +00002645 git_push_metadata['execution_time'] = execution_time
2646 git_push_metadata['exit_code'] = push_returncode
Edward Lemur5737f022019-05-17 01:24:00 +00002647 self._WriteGitPushTraces(trace_name, traces_dir, git_push_metadata)
Edward Lemur0f58ae42019-04-30 17:24:12 +00002648
Edward Lemur1b52d872019-05-09 21:12:12 +00002649 self._CleanUpOldTraces()
Edward Lemur0f58ae42019-04-30 17:24:12 +00002650 gclient_utils.rmtree(traces_dir)
2651
2652 return push_stdout
2653
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002654 def CMDUploadChange(self, options, git_diff_args, custom_cl_base, change):
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002655 """Upload the current branch to Gerrit."""
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00002656 if options.squash and options.no_squash:
2657 DieWithError('Can only use one of --squash or --no-squash')
tandriia60502f2016-06-20 02:01:53 -07002658
2659 if not options.squash and not options.no_squash:
2660 # Load default for user, repo, squash=true, in this order.
2661 options.squash = settings.GetSquashGerritUploads()
2662 elif options.no_squash:
2663 options.squash = False
tandrii26f3e4e2016-06-10 08:37:04 -07002664
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002665 remote, remote_branch = self.GetRemoteBranch()
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01002666 branch = GetTargetRef(remote, remote_branch, options.target_branch)
Aaron Gableb56ad332017-01-06 15:24:31 -08002667 # This may be None; default fallback value is determined in logic below.
2668 title = options.title
2669
Dominic Battre7d1c4842017-10-27 09:17:28 +02002670 # Extract bug number from branch name.
2671 bug = options.bug
2672 match = re.match(r'(?:bug|fix)[_-]?(\d+)', self.GetBranch())
2673 if not bug and match:
2674 bug = match.group(1)
2675
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002676 if options.squash:
tandrii16e0b4e2016-06-07 10:34:28 -07002677 self._GerritCommitMsgHookCheck(offer_removal=not options.force)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002678 if self.GetIssue():
2679 # Try to get the message from a previous upload.
2680 message = self.GetDescription()
2681 if not message:
2682 DieWithError(
Aaron Gablea45ee112016-11-22 15:14:38 -08002683 'failed to fetch description from current Gerrit change %d\n'
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002684 '%s' % (self.GetIssue(), self.GetIssueURL()))
Aaron Gableb56ad332017-01-06 15:24:31 -08002685 if not title:
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02002686 if options.message:
Aaron Gable7303dcb2017-06-07 14:17:32 -07002687 # When uploading a subsequent patchset, -m|--message is taken
2688 # as the patchset title if --title was not provided.
2689 title = options.message.strip()
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02002690 else:
2691 default_title = RunGit(
2692 ['show', '-s', '--format=%s', 'HEAD']).strip()
Aaron Gable7303dcb2017-06-07 14:17:32 -07002693 if options.force:
2694 title = default_title
2695 else:
2696 title = ask_for_data(
2697 'Title for patchset [%s]: ' % default_title) or default_title
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002698 change_id = self._GetChangeDetail()['change_id']
2699 while True:
2700 footer_change_ids = git_footers.get_footer_change_id(message)
2701 if footer_change_ids == [change_id]:
2702 break
2703 if not footer_change_ids:
2704 message = git_footers.add_footer_change_id(message, change_id)
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002705 print('WARNING: appended missing Change-Id to change description.')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002706 continue
2707 # There is already a valid footer but with different or several ids.
2708 # Doing this automatically is non-trivial as we don't want to lose
2709 # existing other footers, yet we want to append just 1 desired
2710 # Change-Id. Thus, just create a new footer, but let user verify the
2711 # new description.
2712 message = '%s\n\nChange-Id: %s' % (message, change_id)
2713 print(
Aaron Gablea45ee112016-11-22 15:14:38 -08002714 'WARNING: change %s has Change-Id footer(s):\n'
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002715 ' %s\n'
Aaron Gablea45ee112016-11-22 15:14:38 -08002716 'but change has Change-Id %s, according to Gerrit.\n'
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002717 'Please, check the proposed correction to the description, '
2718 'and edit it if necessary but keep the "Change-Id: %s" footer\n'
2719 % (self.GetIssue(), '\n '.join(footer_change_ids), change_id,
2720 change_id))
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002721 confirm_or_exit(action='edit')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002722 if not options.force:
2723 change_desc = ChangeDescription(message)
Dominic Battre7d1c4842017-10-27 09:17:28 +02002724 change_desc.prompt(bug=bug)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002725 message = change_desc.description
2726 if not message:
2727 DieWithError("Description is empty. Aborting...")
2728 # Continue the while loop.
2729 # Sanity check of this code - we should end up with proper message
2730 # footer.
2731 assert [change_id] == git_footers.get_footer_change_id(message)
2732 change_desc = ChangeDescription(message)
Aaron Gableb56ad332017-01-06 15:24:31 -08002733 else: # if not self.GetIssue()
2734 if options.message:
2735 message = options.message
2736 else:
Andrii Shyshkalovb07575f2018-10-16 06:16:21 +00002737 message = _create_description_from_log(git_diff_args)
Aaron Gableb56ad332017-01-06 15:24:31 -08002738 if options.title:
2739 message = options.title + '\n\n' + message
2740 change_desc = ChangeDescription(message)
Andrii Shyshkalov8c90d032017-04-19 21:27:26 +02002741
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002742 if not options.force:
Dominic Battre7d1c4842017-10-27 09:17:28 +02002743 change_desc.prompt(bug=bug)
Aaron Gableb56ad332017-01-06 15:24:31 -08002744 # On first upload, patchset title is always this string, while
2745 # --title flag gets converted to first line of message.
2746 title = 'Initial upload'
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002747 if not change_desc.description:
2748 DieWithError("Description is empty. Aborting...")
Andrii Shyshkalov8c90d032017-04-19 21:27:26 +02002749 change_ids = git_footers.get_footer_change_id(change_desc.description)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002750 if len(change_ids) > 1:
2751 DieWithError('too many Change-Id footers, at most 1 allowed.')
2752 if not change_ids:
2753 # Generate the Change-Id automatically.
Andrii Shyshkalov8c90d032017-04-19 21:27:26 +02002754 change_desc.set_description(git_footers.add_footer_change_id(
2755 change_desc.description,
2756 GenerateGerritChangeId(change_desc.description)))
2757 change_ids = git_footers.get_footer_change_id(change_desc.description)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002758 assert len(change_ids) == 1
2759 change_id = change_ids[0]
2760
Robert Iannuccidb02dd02017-04-19 12:18:20 -07002761 if options.reviewers or options.tbrs or options.add_owners_to:
2762 change_desc.update_reviewers(options.reviewers, options.tbrs,
2763 options.add_owners_to, change)
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +00002764 if options.preserve_tryjobs:
2765 change_desc.set_preserve_tryjobs()
Robert Iannuccidb02dd02017-04-19 12:18:20 -07002766
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002767 remote, upstream_branch = self.FetchUpstreamTuple(self.GetBranch())
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002768 parent = self._ComputeParent(remote, upstream_branch, custom_cl_base,
2769 options.force, change_desc)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002770 tree = RunGit(['rev-parse', 'HEAD:']).strip()
Aaron Gable9a03ae02017-11-03 11:31:07 -07002771 with tempfile.NamedTemporaryFile(delete=False) as desc_tempfile:
2772 desc_tempfile.write(change_desc.description)
2773 desc_tempfile.close()
2774 ref_to_push = RunGit(['commit-tree', tree, '-p', parent,
2775 '-F', desc_tempfile.name]).strip()
2776 os.remove(desc_tempfile.name)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002777 else:
2778 change_desc = ChangeDescription(
Andrii Shyshkalovb07575f2018-10-16 06:16:21 +00002779 options.message or _create_description_from_log(git_diff_args))
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002780 if not change_desc.description:
2781 DieWithError("Description is empty. Aborting...")
2782
2783 if not git_footers.get_footer_change_id(change_desc.description):
2784 DownloadGerritHook(False)
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002785 change_desc.set_description(
2786 self._AddChangeIdToCommitMessage(options, git_diff_args))
Robert Iannuccidb02dd02017-04-19 12:18:20 -07002787 if options.reviewers or options.tbrs or options.add_owners_to:
2788 change_desc.update_reviewers(options.reviewers, options.tbrs,
2789 options.add_owners_to, change)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002790 ref_to_push = 'HEAD'
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002791 # For no-squash mode, we assume the remote called "origin" is the one we
2792 # want. It is not worthwhile to support different workflows for
2793 # no-squash mode.
2794 parent = 'origin/%s' % branch
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002795 change_id = git_footers.get_footer_change_id(change_desc.description)[0]
2796
2797 assert change_desc
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +00002798 SaveDescriptionBackup(change_desc)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002799 commits = RunGitSilent(['rev-list', '%s..%s' % (parent,
2800 ref_to_push)]).splitlines()
2801 if len(commits) > 1:
2802 print('WARNING: This will upload %d commits. Run the following command '
2803 'to see which commits will be uploaded: ' % len(commits))
2804 print('git log %s..%s' % (parent, ref_to_push))
2805 print('You can also use `git squash-branch` to squash these into a '
2806 'single commit.')
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002807 confirm_or_exit(action='upload')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002808
Aaron Gable6dadfbf2017-05-09 14:27:58 -07002809 if options.reviewers or options.tbrs or options.add_owners_to:
2810 change_desc.update_reviewers(options.reviewers, options.tbrs,
2811 options.add_owners_to, change)
2812
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00002813 reviewers = sorted(change_desc.get_reviewers())
2814 # Add cc's from the CC_LIST and --cc flag (if any).
2815 if not options.private and not options.no_autocc:
2816 cc = self.GetCCList().split(',')
2817 else:
2818 cc = []
2819 if options.cc:
2820 cc.extend(options.cc)
2821 cc = filter(None, [email.strip() for email in cc])
2822 if change_desc.get_cced():
2823 cc.extend(change_desc.get_cced())
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00002824 if self._GetGerritHost() == 'chromium-review.googlesource.com':
2825 valid_accounts = set(reviewers + cc)
2826 # TODO(crbug/877717): relax this for all hosts.
2827 else:
2828 valid_accounts = gerrit_util.ValidAccounts(
2829 self._GetGerritHost(), reviewers + cc)
Andrii Shyshkalovf170af42018-10-30 07:00:44 +00002830 logging.info('accounts %s are recognized, %s invalid',
2831 sorted(valid_accounts),
2832 set(reviewers + cc).difference(set(valid_accounts)))
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00002833
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00002834 # Extra options that can be specified at push time. Doc:
2835 # https://gerrit-review.googlesource.com/Documentation/user-upload.html
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00002836 refspec_opts = []
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02002837
Aaron Gable844cf292017-06-28 11:32:59 -07002838 # By default, new changes are started in WIP mode, and subsequent patchsets
2839 # don't send email. At any time, passing --send-mail will mark the change
2840 # ready and send email for that particular patch.
Aaron Gableafd52772017-06-27 16:40:10 -07002841 if options.send_mail:
2842 refspec_opts.append('ready')
Aaron Gable844cf292017-06-28 11:32:59 -07002843 refspec_opts.append('notify=ALL')
Jamie Madill276da0b2018-04-27 14:41:20 -04002844 elif not self.GetIssue() and options.squash:
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08002845 refspec_opts.append('wip')
Aaron Gableafd52772017-06-27 16:40:10 -07002846 else:
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08002847 refspec_opts.append('notify=NONE')
Aaron Gable70f4e242017-06-26 10:45:59 -07002848
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02002849 # TODO(tandrii): options.message should be posted as a comment
Aaron Gablee5adf612017-07-14 10:43:58 -07002850 # if --send-mail is set on non-initial upload as Rietveld used to do it.
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02002851
Aaron Gable9b713dd2016-12-14 16:04:21 -08002852 if title:
Nick Carter8692b182017-11-06 16:30:38 -08002853 # Punctuation and whitespace in |title| must be percent-encoded.
2854 refspec_opts.append('m=' + gerrit_util.PercentEncodeForGitRef(title))
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00002855
agablec6787972016-09-09 16:13:34 -07002856 if options.private:
Aaron Gableb02daf02017-05-23 11:53:46 -07002857 refspec_opts.append('private')
agablec6787972016-09-09 16:13:34 -07002858
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00002859 for r in sorted(reviewers):
2860 if r in valid_accounts:
2861 refspec_opts.append('r=%s' % r)
2862 reviewers.remove(r)
2863 else:
2864 # TODO(tandrii): this should probably be a hard failure.
2865 print('WARNING: reviewer %s doesn\'t have a Gerrit account, skipping'
2866 % r)
2867 for c in sorted(cc):
2868 # refspec option will be rejected if cc doesn't correspond to an
2869 # account, even though REST call to add such arbitrary cc may succeed.
2870 if c in valid_accounts:
2871 refspec_opts.append('cc=%s' % c)
2872 cc.remove(c)
2873
rmistry9eadede2016-09-19 11:22:43 -07002874 if options.topic:
2875 # Documentation on Gerrit topics is here:
2876 # https://gerrit-review.googlesource.com/Documentation/user-upload.html#topic
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00002877 refspec_opts.append('topic=%s' % options.topic)
rmistry9eadede2016-09-19 11:22:43 -07002878
Edward Lemur687ca902018-12-05 02:30:30 +00002879 if options.enable_auto_submit:
2880 refspec_opts.append('l=Auto-Submit+1')
2881 if options.use_commit_queue:
2882 refspec_opts.append('l=Commit-Queue+2')
2883 elif options.cq_dry_run:
2884 refspec_opts.append('l=Commit-Queue+1')
2885
2886 if change_desc.get_reviewers(tbr_only=True):
2887 score = gerrit_util.GetCodeReviewTbrScore(
2888 self._GetGerritHost(),
2889 self._GetGerritProject())
2890 refspec_opts.append('l=Code-Review+%s' % score)
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00002891
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08002892 # Gerrit sorts hashtags, so order is not important.
Nodir Turakulov23b82142017-11-16 11:04:25 -08002893 hashtags = {change_desc.sanitize_hash_tag(t) for t in options.hashtags}
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08002894 if not self.GetIssue():
Nodir Turakulov23b82142017-11-16 11:04:25 -08002895 hashtags.update(change_desc.get_hash_tags())
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08002896 refspec_opts += ['hashtag=%s' % t for t in sorted(hashtags)]
2897
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00002898 refspec_suffix = ''
2899 if refspec_opts:
2900 refspec_suffix = '%' + ','.join(refspec_opts)
2901 assert ' ' not in refspec_suffix, (
2902 'spaces not allowed in refspec: "%s"' % refspec_suffix)
2903 refspec = '%s:refs/for/%s%s' % (ref_to_push, branch, refspec_suffix)
2904
Edward Lemur1b52d872019-05-09 21:12:12 +00002905 git_push_metadata = {
2906 'gerrit_host': self._GetGerritHost(),
2907 'title': title or '<untitled>',
2908 'change_id': change_id,
2909 'description': change_desc.description,
2910 }
2911 push_stdout = self._RunGitPushWithTraces(
2912 change_desc, refspec, refspec_opts, git_push_metadata)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002913
2914 if options.squash:
Aaron Gable289b4312017-09-13 14:06:16 -07002915 regex = re.compile(r'remote:\s+https?://[\w\-\.\+\/#]*/(\d+)\s.*')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002916 change_numbers = [m.group(1)
2917 for m in map(regex.match, push_stdout.splitlines())
2918 if m]
2919 if len(change_numbers) != 1:
2920 DieWithError(
2921 ('Created|Updated %d issues on Gerrit, but only 1 expected.\n'
Christopher Lamf732cd52017-01-24 12:40:11 +11002922 'Change-Id: %s') % (len(change_numbers), change_id), change_desc)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002923 self.SetIssue(change_numbers[0])
tandrii5d48c322016-08-18 16:19:37 -07002924 self._GitSetBranchConfigValue('gerritsquashhash', ref_to_push)
tandrii88189772016-09-29 04:29:57 -07002925
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00002926 if self.GetIssue() and (reviewers or cc):
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00002927 # GetIssue() is not set in case of non-squash uploads according to tests.
2928 # TODO(agable): non-squash uploads in git cl should be removed.
2929 gerrit_util.AddReviewers(
2930 self._GetGerritHost(),
Andrii Shyshkalovd06cc782018-08-23 17:24:19 +00002931 self._GerritChangeIdentifier(),
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00002932 reviewers, cc,
2933 notify=bool(options.send_mail))
Aaron Gable6dadfbf2017-05-09 14:27:58 -07002934
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002935 return 0
2936
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002937 def _ComputeParent(self, remote, upstream_branch, custom_cl_base, force,
2938 change_desc):
2939 """Computes parent of the generated commit to be uploaded to Gerrit.
2940
2941 Returns revision or a ref name.
2942 """
2943 if custom_cl_base:
2944 # Try to avoid creating additional unintended CLs when uploading, unless
2945 # user wants to take this risk.
2946 local_ref_of_target_remote = self.GetRemoteBranch()[1]
2947 code, _ = RunGitWithCode(['merge-base', '--is-ancestor', custom_cl_base,
2948 local_ref_of_target_remote])
2949 if code == 1:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002950 print('\nWARNING: Manually specified base of this CL `%s` '
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002951 'doesn\'t seem to belong to target remote branch `%s`.\n\n'
2952 'If you proceed with upload, more than 1 CL may be created by '
2953 'Gerrit as a result, in turn confusing or crashing git cl.\n\n'
2954 'If you are certain that specified base `%s` has already been '
2955 'uploaded to Gerrit as another CL, you may proceed.\n' %
2956 (custom_cl_base, local_ref_of_target_remote, custom_cl_base))
2957 if not force:
2958 confirm_or_exit(
2959 'Do you take responsibility for cleaning up potential mess '
2960 'resulting from proceeding with upload?',
2961 action='upload')
2962 return custom_cl_base
2963
Aaron Gablef97e33d2017-03-30 15:44:27 -07002964 if remote != '.':
2965 return self.GetCommonAncestorWithUpstream()
2966
2967 # If our upstream branch is local, we base our squashed commit on its
2968 # squashed version.
2969 upstream_branch_name = scm.GIT.ShortBranchName(upstream_branch)
2970
Aaron Gablef97e33d2017-03-30 15:44:27 -07002971 if upstream_branch_name == 'master':
Aaron Gable0bbd1c22017-05-08 14:37:08 -07002972 return self.GetCommonAncestorWithUpstream()
Aaron Gablef97e33d2017-03-30 15:44:27 -07002973
2974 # Check the squashed hash of the parent.
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002975 # TODO(tandrii): consider checking parent change in Gerrit and using its
2976 # hash if tree hash of latest parent revision (patchset) in Gerrit matches
2977 # the tree hash of the parent branch. The upside is less likely bogus
2978 # requests to reupload parent change just because it's uploadhash is
2979 # missing, yet the downside likely exists, too (albeit unknown to me yet).
Aaron Gablef97e33d2017-03-30 15:44:27 -07002980 parent = RunGit(['config',
2981 'branch.%s.gerritsquashhash' % upstream_branch_name],
2982 error_ok=True).strip()
2983 # Verify that the upstream branch has been uploaded too, otherwise
2984 # Gerrit will create additional CLs when uploading.
2985 if not parent or (RunGitSilent(['rev-parse', upstream_branch + ':']) !=
2986 RunGitSilent(['rev-parse', parent + ':'])):
2987 DieWithError(
2988 '\nUpload upstream branch %s first.\n'
2989 'It is likely that this branch has been rebased since its last '
2990 'upload, so you just need to upload it again.\n'
2991 '(If you uploaded it with --no-squash, then branch dependencies '
2992 'are not supported, and you should reupload with --squash.)'
2993 % upstream_branch_name,
2994 change_desc)
2995 return parent
2996
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00002997 def _AddChangeIdToCommitMessage(self, options, args):
2998 """Re-commits using the current message, assumes the commit hook is in
2999 place.
3000 """
Andrii Shyshkalovb07575f2018-10-16 06:16:21 +00003001 log_desc = options.message or _create_description_from_log(args)
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00003002 git_command = ['commit', '--amend', '-m', log_desc]
3003 RunGit(git_command)
Andrii Shyshkalovb07575f2018-10-16 06:16:21 +00003004 new_log_desc = _create_description_from_log(args)
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00003005 if git_footers.get_footer_change_id(new_log_desc):
vapiera7fbd5a2016-06-16 09:17:49 -07003006 print('git-cl: Added Change-Id to commit message.')
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00003007 return new_log_desc
3008 else:
tandrii@chromium.orgb067ec52016-05-31 15:24:44 +00003009 DieWithError('ERROR: Gerrit commit-msg hook not installed.')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00003010
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00003011 def SetCQState(self, new_state):
3012 """Sets the Commit-Queue label assuming canonical CQ config for Gerrit."""
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00003013 vote_map = {
3014 _CQState.NONE: 0,
3015 _CQState.DRY_RUN: 1,
Andrii Shyshkalov18975322017-01-25 16:44:13 +01003016 _CQState.COMMIT: 2,
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00003017 }
Aaron Gablefc62f762017-07-17 11:12:07 -07003018 labels = {'Commit-Queue': vote_map[new_state]}
3019 notify = False if new_state == _CQState.DRY_RUN else None
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00003020 gerrit_util.SetReview(
3021 self._GetGerritHost(), self._GerritChangeIdentifier(),
3022 labels=labels, notify=notify)
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00003023
tandriie113dfd2016-10-11 10:20:12 -07003024 def CannotTriggerTryJobReason(self):
tandrii8c5a3532016-11-04 07:52:02 -07003025 try:
3026 data = self._GetChangeDetail()
Aaron Gablea45ee112016-11-22 15:14:38 -08003027 except GerritChangeNotExists:
3028 return 'Gerrit doesn\'t know about your change %s' % self.GetIssue()
tandrii8c5a3532016-11-04 07:52:02 -07003029
3030 if data['status'] in ('ABANDONED', 'MERGED'):
3031 return 'CL %s is closed' % self.GetIssue()
3032
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003033 def GetTryJobProperties(self, patchset=None):
3034 """Returns dictionary of properties to launch try job."""
tandrii8c5a3532016-11-04 07:52:02 -07003035 data = self._GetChangeDetail(['ALL_REVISIONS'])
3036 patchset = int(patchset or self.GetPatchset())
3037 assert patchset
3038 revision_data = None # Pylint wants it to be defined.
3039 for revision_data in data['revisions'].itervalues():
3040 if int(revision_data['_number']) == patchset:
3041 break
3042 else:
Aaron Gablea45ee112016-11-22 15:14:38 -08003043 raise Exception('Patchset %d is not known in Gerrit change %d' %
tandrii8c5a3532016-11-04 07:52:02 -07003044 (patchset, self.GetIssue()))
3045 return {
3046 'patch_issue': self.GetIssue(),
3047 'patch_set': patchset or self.GetPatchset(),
3048 'patch_project': data['project'],
3049 'patch_storage': 'gerrit',
3050 'patch_ref': revision_data['fetch']['http']['ref'],
3051 'patch_repository_url': revision_data['fetch']['http']['url'],
3052 'patch_gerrit_url': self.GetCodereviewServer(),
3053 }
tandriie113dfd2016-10-11 10:20:12 -07003054
tandriide281ae2016-10-12 06:02:30 -07003055 def GetIssueOwner(self):
tandrii8c5a3532016-11-04 07:52:02 -07003056 return self._GetChangeDetail(['DETAILED_ACCOUNTS'])['owner']['email']
tandriide281ae2016-10-12 06:02:30 -07003057
Edward Lemur707d70b2018-02-07 00:50:14 +01003058 def GetReviewers(self):
3059 details = self._GetChangeDetail(['DETAILED_ACCOUNTS'])
Mohamed Heikal171c0742018-11-09 20:38:51 +00003060 return [r['email'] for r in details['reviewers'].get('REVIEWER', [])]
Edward Lemur707d70b2018-02-07 00:50:14 +01003061
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00003062
3063_CODEREVIEW_IMPLEMENTATIONS = {
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00003064 'gerrit': _GerritChangelistImpl,
3065}
3066
tandrii@chromium.org013a2802016-03-29 09:52:33 +00003067
iannuccie53c9352016-08-17 14:40:40 -07003068def _add_codereview_issue_select_options(parser, extra=""):
3069 _add_codereview_select_options(parser)
3070
3071 text = ('Operate on this issue number instead of the current branch\'s '
3072 'implicit issue.')
3073 if extra:
3074 text += ' '+extra
3075 parser.add_option('-i', '--issue', type=int, help=text)
3076
3077
3078def _process_codereview_issue_select_options(parser, options):
3079 _process_codereview_select_options(parser, options)
3080 if options.issue is not None and not options.forced_codereview:
3081 parser.error('--issue must be specified with either --rietveld or --gerrit')
3082
3083
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00003084def _add_codereview_select_options(parser):
3085 """Appends --gerrit and --rietveld options to force specific codereview."""
3086 parser.codereview_group = optparse.OptionGroup(
3087 parser, 'EXPERIMENTAL! Codereview override options')
3088 parser.add_option_group(parser.codereview_group)
3089 parser.codereview_group.add_option(
3090 '--gerrit', action='store_true',
3091 help='Force the use of Gerrit for codereview')
3092 parser.codereview_group.add_option(
3093 '--rietveld', action='store_true',
3094 help='Force the use of Rietveld for codereview')
3095
3096
3097def _process_codereview_select_options(parser, options):
Andrii Shyshkalovfeec80e2018-10-16 01:00:47 +00003098 if options.rietveld:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00003099 parser.error('--rietveld is no longer supported.')
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00003100 options.forced_codereview = None
3101 if options.gerrit:
3102 options.forced_codereview = 'gerrit'
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00003103
3104
tandriif9aefb72016-07-01 09:06:51 -07003105def _get_bug_line_values(default_project, bugs):
3106 """Given default_project and comma separated list of bugs, yields bug line
3107 values.
3108
3109 Each bug can be either:
3110 * a number, which is combined with default_project
3111 * string, which is left as is.
3112
3113 This function may produce more than one line, because bugdroid expects one
3114 project per line.
3115
3116 >>> list(_get_bug_line_values('v8', '123,chromium:789'))
3117 ['v8:123', 'chromium:789']
3118 """
3119 default_bugs = []
3120 others = []
3121 for bug in bugs.split(','):
3122 bug = bug.strip()
3123 if bug:
3124 try:
3125 default_bugs.append(int(bug))
3126 except ValueError:
3127 others.append(bug)
3128
3129 if default_bugs:
3130 default_bugs = ','.join(map(str, default_bugs))
3131 if default_project:
3132 yield '%s:%s' % (default_project, default_bugs)
3133 else:
3134 yield default_bugs
3135 for other in sorted(others):
3136 # Don't bother finding common prefixes, CLs with >2 bugs are very very rare.
3137 yield other
3138
3139
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00003140class ChangeDescription(object):
3141 """Contains a parsed form of the change description."""
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00003142 R_LINE = r'^[ \t]*(TBR|R)[ \t]*=[ \t]*(.*?)[ \t]*$'
bradnelsond975b302016-10-23 12:20:23 -07003143 CC_LINE = r'^[ \t]*(CC)[ \t]*=[ \t]*(.*?)[ \t]*$'
Aaron Gable3a16ed12017-03-23 10:51:55 -07003144 BUG_LINE = r'^[ \t]*(?:(BUG)[ \t]*=|Bug:)[ \t]*(.*?)[ \t]*$'
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01003145 CHERRY_PICK_LINE = r'^\(cherry picked from commit [a-fA-F0-9]{40}\)$'
Nodir Turakulov23b82142017-11-16 11:04:25 -08003146 STRIP_HASH_TAG_PREFIX = r'^(\s*(revert|reland)( "|:)?\s*)*'
3147 BRACKET_HASH_TAG = r'\s*\[([^\[\]]+)\]'
3148 COLON_SEPARATED_HASH_TAG = r'^([a-zA-Z0-9_\- ]+):'
3149 BAD_HASH_TAG_CHUNK = r'[^a-zA-Z0-9]+'
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00003150
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003151 def __init__(self, description):
agable@chromium.org42c20792013-09-12 17:34:49 +00003152 self._description_lines = (description or '').strip().splitlines()
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003153
agable@chromium.org42c20792013-09-12 17:34:49 +00003154 @property # www.logilab.org/ticket/89786
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08003155 def description(self): # pylint: disable=method-hidden
agable@chromium.org42c20792013-09-12 17:34:49 +00003156 return '\n'.join(self._description_lines)
3157
3158 def set_description(self, desc):
3159 if isinstance(desc, basestring):
3160 lines = desc.splitlines()
3161 else:
3162 lines = [line.rstrip() for line in desc]
3163 while lines and not lines[0]:
3164 lines.pop(0)
3165 while lines and not lines[-1]:
3166 lines.pop(-1)
3167 self._description_lines = lines
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003168
Robert Iannucci6c98dc62017-04-18 11:38:00 -07003169 def update_reviewers(self, reviewers, tbrs, add_owners_to=None, change=None):
3170 """Rewrites the R=/TBR= line(s) as a single line each.
3171
3172 Args:
3173 reviewers (list(str)) - list of additional emails to use for reviewers.
3174 tbrs (list(str)) - list of additional emails to use for TBRs.
3175 add_owners_to (None|'R'|'TBR') - Pass to do an OWNERS lookup for files in
3176 the change that are missing OWNER coverage. If this is not None, you
3177 must also pass a value for `change`.
3178 change (Change) - The Change that should be used for OWNERS lookups.
3179 """
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003180 assert isinstance(reviewers, list), reviewers
Robert Iannucci6c98dc62017-04-18 11:38:00 -07003181 assert isinstance(tbrs, list), tbrs
3182
Robert Iannuccif2708bd2017-04-17 15:49:02 -07003183 assert add_owners_to in (None, 'TBR', 'R'), add_owners_to
Robert Iannuccia28592e2017-04-18 13:14:49 -07003184 assert not add_owners_to or change, add_owners_to
Robert Iannucci6c98dc62017-04-18 11:38:00 -07003185
3186 if not reviewers and not tbrs and not add_owners_to:
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003187 return
Robert Iannucci6c98dc62017-04-18 11:38:00 -07003188
3189 reviewers = set(reviewers)
3190 tbrs = set(tbrs)
3191 LOOKUP = {
3192 'TBR': tbrs,
3193 'R': reviewers,
3194 }
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003195
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003196 # Get the set of R= and TBR= lines and remove them from the description.
agable@chromium.org42c20792013-09-12 17:34:49 +00003197 regexp = re.compile(self.R_LINE)
3198 matches = [regexp.match(line) for line in self._description_lines]
3199 new_desc = [l for i, l in enumerate(self._description_lines)
3200 if not matches[i]]
3201 self.set_description(new_desc)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003202
agable@chromium.org42c20792013-09-12 17:34:49 +00003203 # Construct new unified R= and TBR= lines.
Robert Iannucci6c98dc62017-04-18 11:38:00 -07003204
3205 # First, update tbrs/reviewers with names from the R=/TBR= lines (if any).
agable@chromium.org42c20792013-09-12 17:34:49 +00003206 for match in matches:
3207 if not match:
3208 continue
Robert Iannucci6c98dc62017-04-18 11:38:00 -07003209 LOOKUP[match.group(1)].update(cleanup_list([match.group(2).strip()]))
3210
3211 # Next, maybe fill in OWNERS coverage gaps to either tbrs/reviewers.
Robert Iannuccif2708bd2017-04-17 15:49:02 -07003212 if add_owners_to:
piman@chromium.org336f9122014-09-04 02:16:55 +00003213 owners_db = owners.Database(change.RepositoryRoot(),
Jochen Eisinger72606f82017-04-04 10:44:18 +02003214 fopen=file, os_path=os.path)
piman@chromium.org336f9122014-09-04 02:16:55 +00003215 missing_files = owners_db.files_not_covered_by(change.LocalPaths(),
Robert Iannucci100aa212017-04-18 17:28:26 -07003216 (tbrs | reviewers))
Robert Iannucci6c98dc62017-04-18 11:38:00 -07003217 LOOKUP[add_owners_to].update(
3218 owners_db.reviewers_for(missing_files, change.author_email))
Robert Iannuccif2708bd2017-04-17 15:49:02 -07003219
Robert Iannucci6c98dc62017-04-18 11:38:00 -07003220 # If any folks ended up in both groups, remove them from tbrs.
3221 tbrs -= reviewers
Robert Iannuccif2708bd2017-04-17 15:49:02 -07003222
Robert Iannucci6c98dc62017-04-18 11:38:00 -07003223 new_r_line = 'R=' + ', '.join(sorted(reviewers)) if reviewers else None
3224 new_tbr_line = 'TBR=' + ', '.join(sorted(tbrs)) if tbrs else None
agable@chromium.org42c20792013-09-12 17:34:49 +00003225
3226 # Put the new lines in the description where the old first R= line was.
3227 line_loc = next((i for i, match in enumerate(matches) if match), -1)
3228 if 0 <= line_loc < len(self._description_lines):
3229 if new_tbr_line:
3230 self._description_lines.insert(line_loc, new_tbr_line)
3231 if new_r_line:
3232 self._description_lines.insert(line_loc, new_r_line)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003233 else:
agable@chromium.org42c20792013-09-12 17:34:49 +00003234 if new_r_line:
3235 self.append_footer(new_r_line)
3236 if new_tbr_line:
3237 self.append_footer(new_tbr_line)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003238
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +00003239 def set_preserve_tryjobs(self):
3240 """Ensures description footer contains 'Cq-Do-Not-Cancel-Tryjobs: true'."""
3241 footers = git_footers.parse_footers(self.description)
3242 for v in footers.get('Cq-Do-Not-Cancel-Tryjobs', []):
3243 if v.lower() == 'true':
3244 return
3245 self.append_footer('Cq-Do-Not-Cancel-Tryjobs: true')
3246
Aaron Gable3a16ed12017-03-23 10:51:55 -07003247 def prompt(self, bug=None, git_footer=True):
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003248 """Asks the user to update the description."""
agable@chromium.org42c20792013-09-12 17:34:49 +00003249 self.set_description([
3250 '# Enter a description of the change.',
3251 '# This will be displayed on the codereview site.',
3252 '# The first line will also be used as the subject of the review.',
alancutter@chromium.orgbd1073e2013-06-01 00:34:38 +00003253 '#--------------------This line is 72 characters long'
agable@chromium.org42c20792013-09-12 17:34:49 +00003254 '--------------------',
3255 ] + self._description_lines)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003256
agable@chromium.org42c20792013-09-12 17:34:49 +00003257 regexp = re.compile(self.BUG_LINE)
Jonas Termansend0f79112019-03-22 15:28:26 +00003258 prefix = settings.GetBugPrefix()
agable@chromium.org42c20792013-09-12 17:34:49 +00003259 if not any((regexp.match(line) for line in self._description_lines)):
tandriif9aefb72016-07-01 09:06:51 -07003260 values = list(_get_bug_line_values(prefix, bug or '')) or [prefix]
Aaron Gable3a16ed12017-03-23 10:51:55 -07003261 if git_footer:
3262 self.append_footer('Bug: %s' % ', '.join(values))
3263 else:
3264 for value in values:
3265 self.append_footer('BUG=%s' % value)
tandriif9aefb72016-07-01 09:06:51 -07003266
agable@chromium.org42c20792013-09-12 17:34:49 +00003267 content = gclient_utils.RunEditor(self.description, True,
jbroman@chromium.org615a2622013-05-03 13:20:14 +00003268 git_editor=settings.GetGitEditor())
maruel@chromium.org0e0436a2011-10-25 13:32:41 +00003269 if not content:
3270 DieWithError('Running editor failed')
agable@chromium.org42c20792013-09-12 17:34:49 +00003271 lines = content.splitlines()
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003272
Bruce Dawson2377b012018-01-11 16:46:49 -08003273 # Strip off comments and default inserted "Bug:" line.
3274 clean_lines = [line.rstrip() for line in lines if not
Jonas Termansend0f79112019-03-22 15:28:26 +00003275 (line.startswith('#') or
3276 line.rstrip() == "Bug:" or
3277 line.rstrip() == "Bug: " + prefix)]
agable@chromium.org42c20792013-09-12 17:34:49 +00003278 if not clean_lines:
maruel@chromium.org0e0436a2011-10-25 13:32:41 +00003279 DieWithError('No CL description, aborting')
agable@chromium.org42c20792013-09-12 17:34:49 +00003280 self.set_description(clean_lines)
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00003281
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003282 def append_footer(self, line):
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00003283 """Adds a footer line to the description.
3284
3285 Differentiates legacy "KEY=xxx" footers (used to be called tags) and
3286 Gerrit's footers in the form of "Footer-Key: footer any value" and ensures
3287 that Gerrit footers are always at the end.
3288 """
3289 parsed_footer_line = git_footers.parse_footer(line)
3290 if parsed_footer_line:
3291 # Line is a gerrit footer in the form: Footer-Key: any value.
3292 # Thus, must be appended observing Gerrit footer rules.
3293 self.set_description(
3294 git_footers.add_footer(self.description,
3295 key=parsed_footer_line[0],
3296 value=parsed_footer_line[1]))
3297 return
3298
3299 if not self._description_lines:
3300 self._description_lines.append(line)
3301 return
3302
3303 top_lines, gerrit_footers, _ = git_footers.split_footers(self.description)
3304 if gerrit_footers:
3305 # git_footers.split_footers ensures that there is an empty line before
3306 # actual (gerrit) footers, if any. We have to keep it that way.
3307 assert top_lines and top_lines[-1] == ''
3308 top_lines, separator = top_lines[:-1], top_lines[-1:]
3309 else:
3310 separator = [] # No need for separator if there are no gerrit_footers.
3311
3312 prev_line = top_lines[-1] if top_lines else ''
3313 if (not presubmit_support.Change.TAG_LINE_RE.match(prev_line) or
3314 not presubmit_support.Change.TAG_LINE_RE.match(line)):
3315 top_lines.append('')
3316 top_lines.append(line)
3317 self._description_lines = top_lines + separator + gerrit_footers
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00003318
tandrii99a72f22016-08-17 14:33:24 -07003319 def get_reviewers(self, tbr_only=False):
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003320 """Retrieves the list of reviewers."""
agable@chromium.org42c20792013-09-12 17:34:49 +00003321 matches = [re.match(self.R_LINE, line) for line in self._description_lines]
tandrii99a72f22016-08-17 14:33:24 -07003322 reviewers = [match.group(2).strip()
3323 for match in matches
3324 if match and (not tbr_only or match.group(1).upper() == 'TBR')]
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003325 return cleanup_list(reviewers)
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00003326
bradnelsond975b302016-10-23 12:20:23 -07003327 def get_cced(self):
3328 """Retrieves the list of reviewers."""
3329 matches = [re.match(self.CC_LINE, line) for line in self._description_lines]
3330 cced = [match.group(2).strip() for match in matches if match]
3331 return cleanup_list(cced)
3332
Nodir Turakulov23b82142017-11-16 11:04:25 -08003333 def get_hash_tags(self):
3334 """Extracts and sanitizes a list of Gerrit hashtags."""
3335 subject = (self._description_lines or ('',))[0]
3336 subject = re.sub(
3337 self.STRIP_HASH_TAG_PREFIX, '', subject, flags=re.IGNORECASE)
3338
3339 tags = []
3340 start = 0
3341 bracket_exp = re.compile(self.BRACKET_HASH_TAG)
3342 while True:
3343 m = bracket_exp.match(subject, start)
3344 if not m:
3345 break
3346 tags.append(self.sanitize_hash_tag(m.group(1)))
3347 start = m.end()
3348
3349 if not tags:
3350 # Try "Tag: " prefix.
3351 m = re.match(self.COLON_SEPARATED_HASH_TAG, subject)
3352 if m:
3353 tags.append(self.sanitize_hash_tag(m.group(1)))
3354 return tags
3355
3356 @classmethod
3357 def sanitize_hash_tag(cls, tag):
3358 """Returns a sanitized Gerrit hash tag.
3359
3360 A sanitized hashtag can be used as a git push refspec parameter value.
3361 """
3362 return re.sub(cls.BAD_HASH_TAG_CHUNK, '-', tag).strip('-').lower()
3363
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01003364 def update_with_git_number_footers(self, parent_hash, parent_msg, dest_ref):
3365 """Updates this commit description given the parent.
3366
3367 This is essentially what Gnumbd used to do.
3368 Consult https://goo.gl/WMmpDe for more details.
3369 """
3370 assert parent_msg # No, orphan branch creation isn't supported.
3371 assert parent_hash
3372 assert dest_ref
3373 parent_footer_map = git_footers.parse_footers(parent_msg)
3374 # This will also happily parse svn-position, which GnumbD is no longer
3375 # supporting. While we'd generate correct footers, the verifier plugin
3376 # installed in Gerrit will block such commit (ie git push below will fail).
3377 parent_position = git_footers.get_position(parent_footer_map)
3378
3379 # Cherry-picks may have last line obscuring their prior footers,
3380 # from git_footers perspective. This is also what Gnumbd did.
3381 cp_line = None
3382 if (self._description_lines and
3383 re.match(self.CHERRY_PICK_LINE, self._description_lines[-1])):
3384 cp_line = self._description_lines.pop()
3385
Andrii Shyshkalovde37c012017-07-06 21:06:50 +02003386 top_lines, footer_lines, _ = git_footers.split_footers(self.description)
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01003387
3388 # Original-ify all Cr- footers, to avoid re-lands, cherry-picks, or just
3389 # user interference with actual footers we'd insert below.
Andrii Shyshkalovde37c012017-07-06 21:06:50 +02003390 for i, line in enumerate(footer_lines):
3391 k, v = git_footers.parse_footer(line) or (None, None)
3392 if k and k.startswith('Cr-'):
3393 footer_lines[i] = '%s: %s' % ('Cr-Original-' + k[len('Cr-'):], v)
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01003394
3395 # Add Position and Lineage footers based on the parent.
Andrii Shyshkalovb5effa12016-12-14 19:35:12 +01003396 lineage = list(reversed(parent_footer_map.get('Cr-Branched-From', [])))
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01003397 if parent_position[0] == dest_ref:
3398 # Same branch as parent.
3399 number = int(parent_position[1]) + 1
3400 else:
3401 number = 1 # New branch, and extra lineage.
3402 lineage.insert(0, '%s-%s@{#%d}' % (parent_hash, parent_position[0],
3403 int(parent_position[1])))
3404
Andrii Shyshkalovde37c012017-07-06 21:06:50 +02003405 footer_lines.append('Cr-Commit-Position: %s@{#%d}' % (dest_ref, number))
3406 footer_lines.extend('Cr-Branched-From: %s' % v for v in lineage)
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01003407
3408 self._description_lines = top_lines
3409 if cp_line:
3410 self._description_lines.append(cp_line)
3411 if self._description_lines[-1] != '':
3412 self._description_lines.append('') # Ensure footer separator.
Andrii Shyshkalovde37c012017-07-06 21:06:50 +02003413 self._description_lines.extend(footer_lines)
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01003414
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00003415
Aaron Gablea1bab272017-04-11 16:38:18 -07003416def get_approving_reviewers(props, disapproval=False):
maruel@chromium.orge52678e2013-04-26 18:34:44 +00003417 """Retrieves the reviewers that approved a CL from the issue properties with
3418 messages.
3419
3420 Note that the list may contain reviewers that are not committer, thus are not
3421 considered by the CQ.
Aaron Gablea1bab272017-04-11 16:38:18 -07003422
3423 If disapproval is True, instead returns reviewers who 'not lgtm'd the CL.
maruel@chromium.orge52678e2013-04-26 18:34:44 +00003424 """
Aaron Gablea1bab272017-04-11 16:38:18 -07003425 approval_type = 'disapproval' if disapproval else 'approval'
maruel@chromium.orge52678e2013-04-26 18:34:44 +00003426 return sorted(
3427 set(
3428 message['sender']
3429 for message in props['messages']
Aaron Gablea1bab272017-04-11 16:38:18 -07003430 if message[approval_type] and message['sender'] in props['reviewers']
maruel@chromium.orge52678e2013-04-26 18:34:44 +00003431 )
3432 )
3433
3434
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003435def FindCodereviewSettingsFile(filename='codereview.settings'):
3436 """Finds the given file starting in the cwd and going up.
3437
3438 Only looks up to the top of the repository unless an
3439 'inherit-review-settings-ok' file exists in the root of the repository.
3440 """
3441 inherit_ok_file = 'inherit-review-settings-ok'
3442 cwd = os.getcwd()
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00003443 root = settings.GetRoot()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003444 if os.path.isfile(os.path.join(root, inherit_ok_file)):
3445 root = '/'
3446 while True:
3447 if filename in os.listdir(cwd):
3448 if os.path.isfile(os.path.join(cwd, filename)):
3449 return open(os.path.join(cwd, filename))
3450 if cwd == root:
3451 break
3452 cwd = os.path.dirname(cwd)
3453
3454
3455def LoadCodereviewSettingsFromFile(fileobj):
3456 """Parse a codereview.settings file and updates hooks."""
maruel@chromium.org99ac1c52012-01-16 14:52:12 +00003457 keyvals = gclient_utils.ParseCodereviewSettingsContent(fileobj.read())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003458
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003459 def SetProperty(name, setting, unset_error_ok=False):
3460 fullname = 'rietveld.' + name
3461 if setting in keyvals:
3462 RunGit(['config', fullname, keyvals[setting]])
3463 else:
3464 RunGit(['config', '--unset-all', fullname], error_ok=unset_error_ok)
3465
tandrii48df5812016-10-17 03:55:37 -07003466 if not keyvals.get('GERRIT_HOST', False):
3467 SetProperty('server', 'CODE_REVIEW_SERVER')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003468 # Only server setting is required. Other settings can be absent.
3469 # In that case, we ignore errors raised during option deletion attempt.
3470 SetProperty('cc', 'CC_LIST', unset_error_ok=True)
3471 SetProperty('tree-status-url', 'STATUS', unset_error_ok=True)
3472 SetProperty('viewvc-url', 'VIEW_VC', unset_error_ok=True)
rmistry@google.com90752582014-01-14 21:04:50 +00003473 SetProperty('bug-prefix', 'BUG_PREFIX', unset_error_ok=True)
thestig@chromium.org44202a22014-03-11 19:22:18 +00003474 SetProperty('cpplint-regex', 'LINT_REGEX', unset_error_ok=True)
3475 SetProperty('cpplint-ignore-regex', 'LINT_IGNORE_REGEX', unset_error_ok=True)
rmistry@google.com5626a922015-02-26 14:03:30 +00003476 SetProperty('run-post-upload-hook', 'RUN_POST_UPLOAD_HOOK',
3477 unset_error_ok=True)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003478
ukai@chromium.org7044efc2013-11-28 01:51:21 +00003479 if 'GERRIT_HOST' in keyvals:
ukai@chromium.orge8077812012-02-03 03:41:46 +00003480 RunGit(['config', 'gerrit.host', keyvals['GERRIT_HOST']])
ukai@chromium.orge8077812012-02-03 03:41:46 +00003481
bauerb@chromium.org54b400c2016-01-14 10:08:25 +00003482 if 'GERRIT_SQUASH_UPLOADS' in keyvals:
tandrii8dd81ea2016-06-16 13:24:23 -07003483 RunGit(['config', 'gerrit.squash-uploads',
3484 keyvals['GERRIT_SQUASH_UPLOADS']])
bauerb@chromium.org54b400c2016-01-14 10:08:25 +00003485
tandrii@chromium.org28253532016-04-14 13:46:56 +00003486 if 'GERRIT_SKIP_ENSURE_AUTHENTICATED' in keyvals:
shinyak@chromium.org00dbccd2016-04-15 07:24:43 +00003487 RunGit(['config', 'gerrit.skip-ensure-authenticated',
tandrii@chromium.org28253532016-04-14 13:46:56 +00003488 keyvals['GERRIT_SKIP_ENSURE_AUTHENTICATED']])
3489
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003490 if 'PUSH_URL_CONFIG' in keyvals and 'ORIGIN_URL_CONFIG' in keyvals:
Andrii Shyshkalov18975322017-01-25 16:44:13 +01003491 # should be of the form
3492 # PUSH_URL_CONFIG: url.ssh://gitrw.chromium.org.pushinsteadof
3493 # ORIGIN_URL_CONFIG: http://src.chromium.org/git
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003494 RunGit(['config', keyvals['PUSH_URL_CONFIG'],
3495 keyvals['ORIGIN_URL_CONFIG']])
3496
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003497
joshua.lock@intel.com426f69b2012-08-02 23:41:49 +00003498def urlretrieve(source, destination):
3499 """urllib is broken for SSL connections via a proxy therefore we
3500 can't use urllib.urlretrieve()."""
3501 with open(destination, 'w') as f:
3502 f.write(urllib2.urlopen(source).read())
3503
3504
ukai@chromium.org712d6102013-11-27 00:52:58 +00003505def hasSheBang(fname):
3506 """Checks fname is a #! script."""
3507 with open(fname) as f:
3508 return f.read(2).startswith('#!')
3509
3510
bpastene@chromium.org917f0ff2016-04-05 00:45:30 +00003511# TODO(bpastene) Remove once a cleaner fix to crbug.com/600473 presents itself.
3512def DownloadHooks(*args, **kwargs):
3513 pass
3514
3515
tandrii@chromium.org18630d62016-03-04 12:06:02 +00003516def DownloadGerritHook(force):
3517 """Download and install Gerrit commit-msg hook.
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003518
3519 Args:
3520 force: True to update hooks. False to install hooks if not present.
3521 """
3522 if not settings.GetIsGerrit():
3523 return
ukai@chromium.org712d6102013-11-27 00:52:58 +00003524 src = 'https://gerrit-review.googlesource.com/tools/hooks/commit-msg'
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003525 dst = os.path.join(settings.GetRoot(), '.git', 'hooks', 'commit-msg')
3526 if not os.access(dst, os.X_OK):
3527 if os.path.exists(dst):
3528 if not force:
3529 return
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003530 try:
joshua.lock@intel.com426f69b2012-08-02 23:41:49 +00003531 urlretrieve(src, dst)
ukai@chromium.org712d6102013-11-27 00:52:58 +00003532 if not hasSheBang(dst):
3533 DieWithError('Not a script: %s\n'
3534 'You need to download from\n%s\n'
3535 'into .git/hooks/commit-msg and '
3536 'chmod +x .git/hooks/commit-msg' % (dst, src))
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003537 os.chmod(dst, stat.S_IRUSR | stat.S_IWUSR | stat.S_IXUSR)
3538 except Exception:
3539 if os.path.exists(dst):
3540 os.remove(dst)
ukai@chromium.org712d6102013-11-27 00:52:58 +00003541 DieWithError('\nFailed to download hooks.\n'
3542 'You need to download from\n%s\n'
3543 'into .git/hooks/commit-msg and '
3544 'chmod +x .git/hooks/commit-msg' % src)
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003545
3546
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003547class _GitCookiesChecker(object):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003548 """Provides facilities for validating and suggesting fixes to .gitcookies."""
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003549
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003550 _GOOGLESOURCE = 'googlesource.com'
3551
3552 def __init__(self):
3553 # Cached list of [host, identity, source], where source is either
3554 # .gitcookies or .netrc.
3555 self._all_hosts = None
3556
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003557 def ensure_configured_gitcookies(self):
3558 """Runs checks and suggests fixes to make git use .gitcookies from default
3559 path."""
3560 default = gerrit_util.CookiesAuthenticator.get_gitcookies_path()
3561 configured_path = RunGitSilent(
3562 ['config', '--global', 'http.cookiefile']).strip()
Andrii Shyshkalov1e250cd2017-05-10 15:39:31 +02003563 configured_path = os.path.expanduser(configured_path)
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003564 if configured_path:
3565 self._ensure_default_gitcookies_path(configured_path, default)
3566 else:
3567 self._configure_gitcookies_path(default)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003568
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003569 @staticmethod
3570 def _ensure_default_gitcookies_path(configured_path, default_path):
3571 assert configured_path
3572 if configured_path == default_path:
3573 print('git is already configured to use your .gitcookies from %s' %
3574 configured_path)
3575 return
3576
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003577 print('WARNING: You have configured custom path to .gitcookies: %s\n'
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003578 'Gerrit and other depot_tools expect .gitcookies at %s\n' %
3579 (configured_path, default_path))
3580
3581 if not os.path.exists(configured_path):
3582 print('However, your configured .gitcookies file is missing.')
3583 confirm_or_exit('Reconfigure git to use default .gitcookies?',
3584 action='reconfigure')
3585 RunGit(['config', '--global', 'http.cookiefile', default_path])
3586 return
3587
3588 if os.path.exists(default_path):
3589 print('WARNING: default .gitcookies file already exists %s' %
3590 default_path)
3591 DieWithError('Please delete %s manually and re-run git cl creds-check' %
3592 default_path)
3593
3594 confirm_or_exit('Move existing .gitcookies to default location?',
3595 action='move')
3596 shutil.move(configured_path, default_path)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003597 RunGit(['config', '--global', 'http.cookiefile', default_path])
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003598 print('Moved and reconfigured git to use .gitcookies from %s' %
3599 default_path)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003600
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003601 @staticmethod
3602 def _configure_gitcookies_path(default_path):
3603 netrc_path = gerrit_util.CookiesAuthenticator.get_netrc_path()
3604 if os.path.exists(netrc_path):
3605 print('You seem to be using outdated .netrc for git credentials: %s' %
3606 netrc_path)
3607 print('This tool will guide you through setting up recommended '
3608 '.gitcookies store for git credentials.\n'
3609 '\n'
3610 'IMPORTANT: If something goes wrong and you decide to go back, do:\n'
3611 ' git config --global --unset http.cookiefile\n'
3612 ' mv %s %s.backup\n\n' % (default_path, default_path))
3613 confirm_or_exit(action='setup .gitcookies')
3614 RunGit(['config', '--global', 'http.cookiefile', default_path])
3615 print('Configured git to use .gitcookies from %s' % default_path)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003616
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003617 def get_hosts_with_creds(self, include_netrc=False):
3618 if self._all_hosts is None:
3619 a = gerrit_util.CookiesAuthenticator()
3620 self._all_hosts = [
3621 (h, u, s)
3622 for h, u, s in itertools.chain(
3623 ((h, u, '.netrc') for h, (u, _, _) in a.netrc.hosts.iteritems()),
3624 ((h, u, '.gitcookies') for h, (u, _) in a.gitcookies.iteritems())
3625 )
3626 if h.endswith(self._GOOGLESOURCE)
3627 ]
3628
3629 if include_netrc:
3630 return self._all_hosts
3631 return [(h, u, s) for h, u, s in self._all_hosts if s != '.netrc']
3632
3633 def print_current_creds(self, include_netrc=False):
3634 hosts = sorted(self.get_hosts_with_creds(include_netrc=include_netrc))
3635 if not hosts:
3636 print('No Git/Gerrit credentials found')
3637 return
3638 lengths = [max(map(len, (row[i] for row in hosts))) for i in xrange(3)]
3639 header = [('Host', 'User', 'Which file'),
3640 ['=' * l for l in lengths]]
3641 for row in (header + hosts):
3642 print('\t'.join((('%%+%ds' % l) % s)
3643 for l, s in zip(lengths, row)))
3644
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003645 @staticmethod
3646 def _parse_identity(identity):
Lei Zhangd3f769a2017-12-15 15:16:14 -08003647 """Parses identity "git-<username>.domain" into <username> and domain."""
3648 # Special case: usernames that contain ".", which are generally not
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +02003649 # distinguishable from sub-domains. But we do know typical domains:
3650 if identity.endswith('.chromium.org'):
3651 domain = 'chromium.org'
3652 username = identity[:-len('.chromium.org')]
3653 else:
3654 username, domain = identity.split('.', 1)
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003655 if username.startswith('git-'):
3656 username = username[len('git-'):]
3657 return username, domain
3658
3659 def _get_usernames_of_domain(self, domain):
3660 """Returns list of usernames referenced by .gitcookies in a given domain."""
3661 identities_by_domain = {}
3662 for _, identity, _ in self.get_hosts_with_creds():
3663 username, domain = self._parse_identity(identity)
3664 identities_by_domain.setdefault(domain, []).append(username)
3665 return identities_by_domain.get(domain)
3666
3667 def _canonical_git_googlesource_host(self, host):
3668 """Normalizes Gerrit hosts (with '-review') to Git host."""
3669 assert host.endswith(self._GOOGLESOURCE)
3670 # Prefix doesn't include '.' at the end.
3671 prefix = host[:-(1 + len(self._GOOGLESOURCE))]
3672 if prefix.endswith('-review'):
3673 prefix = prefix[:-len('-review')]
3674 return prefix + '.' + self._GOOGLESOURCE
3675
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003676 def _canonical_gerrit_googlesource_host(self, host):
3677 git_host = self._canonical_git_googlesource_host(host)
3678 prefix = git_host.split('.', 1)[0]
3679 return prefix + '-review.' + self._GOOGLESOURCE
3680
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003681 def _get_counterpart_host(self, host):
3682 assert host.endswith(self._GOOGLESOURCE)
3683 git = self._canonical_git_googlesource_host(host)
3684 gerrit = self._canonical_gerrit_googlesource_host(git)
3685 return git if gerrit == host else gerrit
3686
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003687 def has_generic_host(self):
3688 """Returns whether generic .googlesource.com has been configured.
3689
3690 Chrome Infra recommends to use explicit ${host}.googlesource.com instead.
3691 """
3692 for host, _, _ in self.get_hosts_with_creds(include_netrc=False):
3693 if host == '.' + self._GOOGLESOURCE:
3694 return True
3695 return False
3696
3697 def _get_git_gerrit_identity_pairs(self):
3698 """Returns map from canonic host to pair of identities (Git, Gerrit).
3699
3700 One of identities might be None, meaning not configured.
3701 """
3702 host_to_identity_pairs = {}
3703 for host, identity, _ in self.get_hosts_with_creds():
3704 canonical = self._canonical_git_googlesource_host(host)
3705 pair = host_to_identity_pairs.setdefault(canonical, [None, None])
3706 idx = 0 if canonical == host else 1
3707 pair[idx] = identity
3708 return host_to_identity_pairs
3709
3710 def get_partially_configured_hosts(self):
3711 return set(
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003712 (host if i1 else self._canonical_gerrit_googlesource_host(host))
3713 for host, (i1, i2) in self._get_git_gerrit_identity_pairs().iteritems()
3714 if None in (i1, i2) and host != '.' + self._GOOGLESOURCE)
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003715
3716 def get_conflicting_hosts(self):
3717 return set(
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003718 host
3719 for host, (i1, i2) in self._get_git_gerrit_identity_pairs().iteritems()
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003720 if None not in (i1, i2) and i1 != i2)
3721
3722 def get_duplicated_hosts(self):
3723 counters = collections.Counter(h for h, _, _ in self.get_hosts_with_creds())
3724 return set(host for host, count in counters.iteritems() if count > 1)
3725
3726 _EXPECTED_HOST_IDENTITY_DOMAINS = {
3727 'chromium.googlesource.com': 'chromium.org',
3728 'chrome-internal.googlesource.com': 'google.com',
3729 }
3730
3731 def get_hosts_with_wrong_identities(self):
3732 """Finds hosts which **likely** reference wrong identities.
3733
3734 Note: skips hosts which have conflicting identities for Git and Gerrit.
3735 """
3736 hosts = set()
3737 for host, expected in self._EXPECTED_HOST_IDENTITY_DOMAINS.iteritems():
3738 pair = self._get_git_gerrit_identity_pairs().get(host)
3739 if pair and pair[0] == pair[1]:
3740 _, domain = self._parse_identity(pair[0])
3741 if domain != expected:
3742 hosts.add(host)
3743 return hosts
3744
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003745 @staticmethod
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003746 def _format_hosts(hosts, extra_column_func=None):
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003747 hosts = sorted(hosts)
3748 assert hosts
3749 if extra_column_func is None:
3750 extras = [''] * len(hosts)
3751 else:
3752 extras = [extra_column_func(host) for host in hosts]
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003753 tmpl = '%%-%ds %%-%ds' % (max(map(len, hosts)), max(map(len, extras)))
3754 lines = []
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003755 for he in zip(hosts, extras):
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003756 lines.append(tmpl % he)
3757 return lines
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003758
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003759 def _find_problems(self):
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003760 if self.has_generic_host():
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003761 yield ('.googlesource.com wildcard record detected',
3762 ['Chrome Infrastructure team recommends to list full host names '
3763 'explicitly.'],
3764 None)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003765
3766 dups = self.get_duplicated_hosts()
3767 if dups:
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003768 yield ('The following hosts were defined twice',
3769 self._format_hosts(dups),
3770 None)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003771
3772 partial = self.get_partially_configured_hosts()
3773 if partial:
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003774 yield ('Credentials should come in pairs for Git and Gerrit hosts. '
3775 'These hosts are missing',
3776 self._format_hosts(partial, lambda host: 'but %s defined' %
3777 self._get_counterpart_host(host)),
3778 partial)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003779
3780 conflicting = self.get_conflicting_hosts()
3781 if conflicting:
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003782 yield ('The following Git hosts have differing credentials from their '
3783 'Gerrit counterparts',
3784 self._format_hosts(conflicting, lambda host: '%s vs %s' %
3785 tuple(self._get_git_gerrit_identity_pairs()[host])),
3786 conflicting)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003787
3788 wrong = self.get_hosts_with_wrong_identities()
3789 if wrong:
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003790 yield ('These hosts likely use wrong identity',
3791 self._format_hosts(wrong, lambda host: '%s but %s recommended' %
3792 (self._get_git_gerrit_identity_pairs()[host][0],
3793 self._EXPECTED_HOST_IDENTITY_DOMAINS[host])),
3794 wrong)
3795
3796 def find_and_report_problems(self):
3797 """Returns True if there was at least one problem, else False."""
3798 found = False
3799 bad_hosts = set()
3800 for title, sublines, hosts in self._find_problems():
3801 if not found:
3802 found = True
3803 print('\n\n.gitcookies problem report:\n')
3804 bad_hosts.update(hosts or [])
3805 print(' %s%s' % (title , (':' if sublines else '')))
3806 if sublines:
3807 print()
3808 print(' %s' % '\n '.join(sublines))
3809 print()
3810
3811 if bad_hosts:
3812 assert found
3813 print(' You can manually remove corresponding lines in your %s file and '
3814 'visit the following URLs with correct account to generate '
3815 'correct credential lines:\n' %
3816 gerrit_util.CookiesAuthenticator.get_gitcookies_path())
3817 print(' %s' % '\n '.join(sorted(set(
3818 gerrit_util.CookiesAuthenticator().get_new_password_url(
3819 self._canonical_git_googlesource_host(host))
3820 for host in bad_hosts
3821 ))))
3822 return found
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003823
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003824
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003825@metrics.collector.collect_metrics('git cl creds-check')
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003826def CMDcreds_check(parser, args):
3827 """Checks credentials and suggests changes."""
3828 _, _ = parser.parse_args(args)
3829
Vadim Shtayurab250ec12018-10-04 00:21:08 +00003830 # Code below checks .gitcookies. Abort if using something else.
3831 authn = gerrit_util.Authenticator.get()
3832 if not isinstance(authn, gerrit_util.CookiesAuthenticator):
3833 if isinstance(authn, gerrit_util.GceAuthenticator):
3834 DieWithError(
3835 'This command is not designed for GCE, are you on a bot?\n'
3836 'If you need to run this on GCE, export SKIP_GCE_AUTH_FOR_GIT=1 '
3837 'in your env.')
Aaron Gabled10ca0e2017-09-11 11:24:10 -07003838 DieWithError(
Vadim Shtayurab250ec12018-10-04 00:21:08 +00003839 'This command is not designed for bot environment. It checks '
3840 '~/.gitcookies file not generally used on bots.')
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003841
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003842 checker = _GitCookiesChecker()
3843 checker.ensure_configured_gitcookies()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003844
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003845 print('Your .netrc and .gitcookies have credentials for these hosts:')
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003846 checker.print_current_creds(include_netrc=True)
3847
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003848 if not checker.find_and_report_problems():
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003849 print('\nNo problems detected in your .gitcookies file.')
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003850 return 0
3851 return 1
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003852
3853
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003854@metrics.collector.collect_metrics('git cl baseurl')
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00003855def CMDbaseurl(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003856 """Gets or sets base-url for this branch."""
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00003857 branchref = RunGit(['symbolic-ref', 'HEAD']).strip()
3858 branch = ShortBranchName(branchref)
3859 _, args = parser.parse_args(args)
3860 if not args:
vapiera7fbd5a2016-06-16 09:17:49 -07003861 print('Current base-url:')
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00003862 return RunGit(['config', 'branch.%s.base-url' % branch],
3863 error_ok=False).strip()
3864 else:
vapiera7fbd5a2016-06-16 09:17:49 -07003865 print('Setting base-url to %s' % args[0])
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00003866 return RunGit(['config', 'branch.%s.base-url' % branch, args[0]],
3867 error_ok=False).strip()
3868
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00003869def color_for_status(status):
3870 """Maps a Changelist status to color, for CMDstatus and other tools."""
3871 return {
Aaron Gable9ab38c62017-04-06 14:36:33 -07003872 'unsent': Fore.YELLOW,
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00003873 'waiting': Fore.BLUE,
3874 'reply': Fore.YELLOW,
Aaron Gable9ab38c62017-04-06 14:36:33 -07003875 'not lgtm': Fore.RED,
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00003876 'lgtm': Fore.GREEN,
3877 'commit': Fore.MAGENTA,
3878 'closed': Fore.CYAN,
3879 'error': Fore.WHITE,
3880 }.get(status, Fore.WHITE)
3881
tandrii@chromium.org04ea8462016-04-25 19:51:21 +00003882
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003883def get_cl_statuses(changes, fine_grained, max_processes=None):
3884 """Returns a blocking iterable of (cl, status) for given branches.
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003885
3886 If fine_grained is true, this will fetch CL statuses from the server.
3887 Otherwise, simply indicate if there's a matching url for the given branches.
3888
3889 If max_processes is specified, it is used as the maximum number of processes
3890 to spawn to fetch CL status from the server. Otherwise 1 process per branch is
3891 spawned.
calamity@chromium.orgcf197482016-04-29 20:15:53 +00003892
3893 See GetStatus() for a list of possible statuses.
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003894 """
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003895 if not changes:
3896 raise StopIteration()
calamity@chromium.orgcf197482016-04-29 20:15:53 +00003897
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003898 if not fine_grained:
3899 # Fast path which doesn't involve querying codereview servers.
Aaron Gablea1bab272017-04-11 16:38:18 -07003900 # Do not use get_approving_reviewers(), since it requires an HTTP request.
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003901 for cl in changes:
3902 yield (cl, 'waiting' if cl.GetIssueURL() else 'error')
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003903 return
3904
3905 # First, sort out authentication issues.
3906 logging.debug('ensuring credentials exist')
3907 for cl in changes:
3908 cl.EnsureAuthenticated(force=False, refresh=True)
3909
3910 def fetch(cl):
3911 try:
3912 return (cl, cl.GetStatus())
3913 except:
3914 # See http://crbug.com/629863.
Andrii Shyshkalov98824232018-04-19 11:37:15 -07003915 logging.exception('failed to fetch status for cl %s:', cl.GetIssue())
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003916 raise
3917
3918 threads_count = len(changes)
3919 if max_processes:
3920 threads_count = max(1, min(threads_count, max_processes))
3921 logging.debug('querying %d CLs using %d threads', len(changes), threads_count)
3922
3923 pool = ThreadPool(threads_count)
3924 fetched_cls = set()
3925 try:
3926 it = pool.imap_unordered(fetch, changes).__iter__()
3927 while True:
3928 try:
3929 cl, status = it.next(timeout=5)
3930 except multiprocessing.TimeoutError:
3931 break
3932 fetched_cls.add(cl)
3933 yield cl, status
3934 finally:
3935 pool.close()
3936
3937 # Add any branches that failed to fetch.
3938 for cl in set(changes) - fetched_cls:
3939 yield (cl, 'error')
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00003940
rmistry@google.com2dd99862015-06-22 12:22:18 +00003941
3942def upload_branch_deps(cl, args):
3943 """Uploads CLs of local branches that are dependents of the current branch.
3944
3945 If the local branch dependency tree looks like:
3946 test1 -> test2.1 -> test3.1
3947 -> test3.2
3948 -> test2.2 -> test3.3
3949
3950 and you run "git cl upload --dependencies" from test1 then "git cl upload" is
3951 run on the dependent branches in this order:
3952 test2.1, test3.1, test3.2, test2.2, test3.3
3953
3954 Note: This function does not rebase your local dependent branches. Use it when
3955 you make a change to the parent branch that will not conflict with its
3956 dependent branches, and you would like their dependencies updated in
3957 Rietveld.
3958 """
3959 if git_common.is_dirty_git_tree('upload-branch-deps'):
3960 return 1
3961
3962 root_branch = cl.GetBranch()
3963 if root_branch is None:
3964 DieWithError('Can\'t find dependent branches from detached HEAD state. '
3965 'Get on a branch!')
Andrii Shyshkalov9f274432018-10-15 16:40:23 +00003966 if not cl.GetIssue():
rmistry@google.com2dd99862015-06-22 12:22:18 +00003967 DieWithError('Current branch does not have an uploaded CL. We cannot set '
3968 'patchset dependencies without an uploaded CL.')
3969
3970 branches = RunGit(['for-each-ref',
3971 '--format=%(refname:short) %(upstream:short)',
3972 'refs/heads'])
3973 if not branches:
3974 print('No local branches found.')
3975 return 0
3976
3977 # Create a dictionary of all local branches to the branches that are dependent
3978 # on it.
3979 tracked_to_dependents = collections.defaultdict(list)
3980 for b in branches.splitlines():
3981 tokens = b.split()
3982 if len(tokens) == 2:
3983 branch_name, tracked = tokens
3984 tracked_to_dependents[tracked].append(branch_name)
3985
vapiera7fbd5a2016-06-16 09:17:49 -07003986 print()
3987 print('The dependent local branches of %s are:' % root_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00003988 dependents = []
3989 def traverse_dependents_preorder(branch, padding=''):
3990 dependents_to_process = tracked_to_dependents.get(branch, [])
3991 padding += ' '
3992 for dependent in dependents_to_process:
vapiera7fbd5a2016-06-16 09:17:49 -07003993 print('%s%s' % (padding, dependent))
rmistry@google.com2dd99862015-06-22 12:22:18 +00003994 dependents.append(dependent)
3995 traverse_dependents_preorder(dependent, padding)
3996 traverse_dependents_preorder(root_branch)
vapiera7fbd5a2016-06-16 09:17:49 -07003997 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00003998
3999 if not dependents:
vapiera7fbd5a2016-06-16 09:17:49 -07004000 print('There are no dependent local branches for %s' % root_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00004001 return 0
4002
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01004003 confirm_or_exit('This command will checkout all dependent branches and run '
4004 '"git cl upload".', action='continue')
rmistry@google.com2dd99862015-06-22 12:22:18 +00004005
rmistry@google.com2dd99862015-06-22 12:22:18 +00004006 # Record all dependents that failed to upload.
4007 failures = {}
4008 # Go through all dependents, checkout the branch and upload.
4009 try:
4010 for dependent_branch in dependents:
vapiera7fbd5a2016-06-16 09:17:49 -07004011 print()
4012 print('--------------------------------------')
4013 print('Running "git cl upload" from %s:' % dependent_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00004014 RunGit(['checkout', '-q', dependent_branch])
vapiera7fbd5a2016-06-16 09:17:49 -07004015 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00004016 try:
4017 if CMDupload(OptionParser(), args) != 0:
vapiera7fbd5a2016-06-16 09:17:49 -07004018 print('Upload failed for %s!' % dependent_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00004019 failures[dependent_branch] = 1
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08004020 except: # pylint: disable=bare-except
rmistry@google.com2dd99862015-06-22 12:22:18 +00004021 failures[dependent_branch] = 1
vapiera7fbd5a2016-06-16 09:17:49 -07004022 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00004023 finally:
4024 # Swap back to the original root branch.
4025 RunGit(['checkout', '-q', root_branch])
4026
vapiera7fbd5a2016-06-16 09:17:49 -07004027 print()
4028 print('Upload complete for dependent branches!')
rmistry@google.com2dd99862015-06-22 12:22:18 +00004029 for dependent_branch in dependents:
4030 upload_status = 'failed' if failures.get(dependent_branch) else 'succeeded'
vapiera7fbd5a2016-06-16 09:17:49 -07004031 print(' %s : %s' % (dependent_branch, upload_status))
4032 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00004033
4034 return 0
4035
4036
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004037@metrics.collector.collect_metrics('git cl archive')
kmarshall3bff56b2016-06-06 18:31:47 -07004038def CMDarchive(parser, args):
4039 """Archives and deletes branches associated with closed changelists."""
4040 parser.add_option(
4041 '-j', '--maxjobs', action='store', type=int,
kmarshall9249e012016-08-23 12:02:16 -07004042 help='The maximum number of jobs to use when retrieving review status.')
kmarshall3bff56b2016-06-06 18:31:47 -07004043 parser.add_option(
4044 '-f', '--force', action='store_true',
4045 help='Bypasses the confirmation prompt.')
kmarshall9249e012016-08-23 12:02:16 -07004046 parser.add_option(
4047 '-d', '--dry-run', action='store_true',
4048 help='Skip the branch tagging and removal steps.')
4049 parser.add_option(
4050 '-t', '--notags', action='store_true',
4051 help='Do not tag archived branches. '
4052 'Note: local commit history may be lost.')
kmarshall3bff56b2016-06-06 18:31:47 -07004053
4054 auth.add_auth_options(parser)
4055 options, args = parser.parse_args(args)
4056 if args:
4057 parser.error('Unsupported args: %s' % ' '.join(args))
4058 auth_config = auth.extract_auth_config_from_options(options)
4059
4060 branches = RunGit(['for-each-ref', '--format=%(refname)', 'refs/heads'])
4061 if not branches:
4062 return 0
4063
vapiera7fbd5a2016-06-16 09:17:49 -07004064 print('Finding all branches associated with closed issues...')
kmarshall3bff56b2016-06-06 18:31:47 -07004065 changes = [Changelist(branchref=b, auth_config=auth_config)
4066 for b in branches.splitlines()]
4067 alignment = max(5, max(len(c.GetBranch()) for c in changes))
4068 statuses = get_cl_statuses(changes,
4069 fine_grained=True,
4070 max_processes=options.maxjobs)
4071 proposal = [(cl.GetBranch(),
4072 'git-cl-archived-%s-%s' % (cl.GetIssue(), cl.GetBranch()))
4073 for cl, status in statuses
Andrii Shyshkalov51bdf8c2018-10-18 01:07:58 +00004074 if status in ('closed', 'rietveld-not-supported')]
kmarshall3bff56b2016-06-06 18:31:47 -07004075 proposal.sort()
4076
4077 if not proposal:
vapiera7fbd5a2016-06-16 09:17:49 -07004078 print('No branches with closed codereview issues found.')
kmarshall3bff56b2016-06-06 18:31:47 -07004079 return 0
4080
4081 current_branch = GetCurrentBranch()
4082
vapiera7fbd5a2016-06-16 09:17:49 -07004083 print('\nBranches with closed issues that will be archived:\n')
kmarshall9249e012016-08-23 12:02:16 -07004084 if options.notags:
4085 for next_item in proposal:
4086 print(' ' + next_item[0])
4087 else:
4088 print('%*s | %s' % (alignment, 'Branch name', 'Archival tag name'))
4089 for next_item in proposal:
4090 print('%*s %s' % (alignment, next_item[0], next_item[1]))
kmarshall3bff56b2016-06-06 18:31:47 -07004091
kmarshall9249e012016-08-23 12:02:16 -07004092 # Quit now on precondition failure or if instructed by the user, either
4093 # via an interactive prompt or by command line flags.
4094 if options.dry_run:
4095 print('\nNo changes were made (dry run).\n')
4096 return 0
4097 elif any(branch == current_branch for branch, _ in proposal):
kmarshall3bff56b2016-06-06 18:31:47 -07004098 print('You are currently on a branch \'%s\' which is associated with a '
4099 'closed codereview issue, so archive cannot proceed. Please '
4100 'checkout another branch and run this command again.' %
4101 current_branch)
4102 return 1
kmarshall9249e012016-08-23 12:02:16 -07004103 elif not options.force:
sergiyb4a5ecbe2016-06-20 09:46:00 -07004104 answer = ask_for_data('\nProceed with deletion (Y/n)? ').lower()
4105 if answer not in ('y', ''):
vapiera7fbd5a2016-06-16 09:17:49 -07004106 print('Aborted.')
kmarshall3bff56b2016-06-06 18:31:47 -07004107 return 1
4108
4109 for branch, tagname in proposal:
kmarshall9249e012016-08-23 12:02:16 -07004110 if not options.notags:
4111 RunGit(['tag', tagname, branch])
kmarshall3bff56b2016-06-06 18:31:47 -07004112 RunGit(['branch', '-D', branch])
kmarshall9249e012016-08-23 12:02:16 -07004113
vapiera7fbd5a2016-06-16 09:17:49 -07004114 print('\nJob\'s done!')
kmarshall3bff56b2016-06-06 18:31:47 -07004115
4116 return 0
4117
4118
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004119@metrics.collector.collect_metrics('git cl status')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004120def CMDstatus(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004121 """Show status of changelists.
4122
4123 Colors are used to tell the state of the CL unless --fast is used:
jsbell@chromium.orgaeab41a2013-12-10 20:01:22 +00004124 - Blue waiting for review
Aaron Gable9ab38c62017-04-06 14:36:33 -07004125 - Yellow waiting for you to reply to review, or not yet sent
jsbell@chromium.orgaeab41a2013-12-10 20:01:22 +00004126 - Green LGTM'ed
Aaron Gable9ab38c62017-04-06 14:36:33 -07004127 - Red 'not LGTM'ed
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00004128 - Magenta in the CQ
jsbell@chromium.orgaeab41a2013-12-10 20:01:22 +00004129 - Cyan was committed, branch can be deleted
Aaron Gable9ab38c62017-04-06 14:36:33 -07004130 - White error, or unknown status
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004131
4132 Also see 'git cl comments'.
4133 """
Alan Cuttera3be9a52019-03-04 18:50:33 +00004134 parser.add_option(
4135 '--no-branch-color',
4136 action='store_true',
4137 help='Disable colorized branch names')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004138 parser.add_option('--field',
phajdan.jr289d03e2016-08-16 08:21:06 -07004139 help='print only specific field (desc|id|patch|status|url)')
maruel@chromium.org1033efd2013-07-23 23:25:09 +00004140 parser.add_option('-f', '--fast', action='store_true',
4141 help='Do not retrieve review status')
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00004142 parser.add_option(
4143 '-j', '--maxjobs', action='store', type=int,
4144 help='The maximum number of jobs to use when retrieving review status')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004145
4146 auth.add_auth_options(parser)
iannuccie53c9352016-08-17 14:40:40 -07004147 _add_codereview_issue_select_options(
4148 parser, 'Must be in conjunction with --field.')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004149 options, args = parser.parse_args(args)
iannuccie53c9352016-08-17 14:40:40 -07004150 _process_codereview_issue_select_options(parser, options)
maruel@chromium.org39c0b222013-08-17 16:57:01 +00004151 if args:
4152 parser.error('Unsupported args: %s' % args)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004153 auth_config = auth.extract_auth_config_from_options(options)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004154
iannuccie53c9352016-08-17 14:40:40 -07004155 if options.issue is not None and not options.field:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004156 parser.error('--field must be specified with --issue.')
iannucci3c972b92016-08-17 13:24:10 -07004157
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004158 if options.field:
iannucci3c972b92016-08-17 13:24:10 -07004159 cl = Changelist(auth_config=auth_config, issue=options.issue,
4160 codereview=options.forced_codereview)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004161 if options.field.startswith('desc'):
vapiera7fbd5a2016-06-16 09:17:49 -07004162 print(cl.GetDescription())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004163 elif options.field == 'id':
4164 issueid = cl.GetIssue()
4165 if issueid:
vapiera7fbd5a2016-06-16 09:17:49 -07004166 print(issueid)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004167 elif options.field == 'patch':
Aaron Gablee8856ee2017-12-07 12:41:46 -08004168 patchset = cl.GetMostRecentPatchset()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004169 if patchset:
vapiera7fbd5a2016-06-16 09:17:49 -07004170 print(patchset)
phajdan.jr289d03e2016-08-16 08:21:06 -07004171 elif options.field == 'status':
4172 print(cl.GetStatus())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004173 elif options.field == 'url':
4174 url = cl.GetIssueURL()
4175 if url:
vapiera7fbd5a2016-06-16 09:17:49 -07004176 print(url)
maruel@chromium.orge25c75b2013-07-23 18:30:56 +00004177 return 0
4178
4179 branches = RunGit(['for-each-ref', '--format=%(refname)', 'refs/heads'])
4180 if not branches:
4181 print('No local branch found.')
4182 return 0
4183
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00004184 changes = [
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004185 Changelist(branchref=b, auth_config=auth_config)
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00004186 for b in branches.splitlines()]
vapiera7fbd5a2016-06-16 09:17:49 -07004187 print('Branches associated with reviews:')
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00004188 output = get_cl_statuses(changes,
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00004189 fine_grained=not options.fast,
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00004190 max_processes=options.maxjobs)
maruel@chromium.org1033efd2013-07-23 23:25:09 +00004191
Daniel McArdlea23bf592019-02-12 00:25:12 +00004192 current_branch = GetCurrentBranch()
4193
4194 def FormatBranchName(branch, colorize=False):
4195 """Simulates 'git branch' behavior. Colorizes and prefixes branch name with
4196 an asterisk when it is the current branch."""
4197
4198 asterisk = ""
4199 color = Fore.RESET
4200 if branch == current_branch:
4201 asterisk = "* "
4202 color = Fore.GREEN
4203 branch_name = ShortBranchName(branch)
4204
4205 if colorize:
4206 return asterisk + color + branch_name + Fore.RESET
Daniel McArdle452a49f2019-02-14 17:28:31 +00004207 return asterisk + branch_name
4208
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00004209 branch_statuses = {}
Daniel McArdlea23bf592019-02-12 00:25:12 +00004210
4211 alignment = max(5, max(len(FormatBranchName(c.GetBranch())) for c in changes))
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00004212 for cl in sorted(changes, key=lambda c: c.GetBranch()):
4213 branch = cl.GetBranch()
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00004214 while branch not in branch_statuses:
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00004215 c, status = output.next()
4216 branch_statuses[c.GetBranch()] = status
4217 status = branch_statuses.pop(branch)
4218 url = cl.GetIssueURL()
4219 if url and (not status or status == 'error'):
4220 # The issue probably doesn't exist anymore.
4221 url += ' (broken)'
4222
nodir@chromium.orga6de1f42015-06-10 04:23:17 +00004223 color = color_for_status(status)
maruel@chromium.org885f6512013-07-27 02:17:26 +00004224 reset = Fore.RESET
iannucci@chromium.org596cd5c2016-04-04 21:34:39 +00004225 if not setup_color.IS_TTY:
maruel@chromium.org885f6512013-07-27 02:17:26 +00004226 color = ''
4227 reset = ''
nodir@chromium.orga6de1f42015-06-10 04:23:17 +00004228 status_str = '(%s)' % status if status else ''
Daniel McArdle452a49f2019-02-14 17:28:31 +00004229
Alan Cuttera3be9a52019-03-04 18:50:33 +00004230 branch_display = FormatBranchName(branch)
4231 padding = ' ' * (alignment - len(branch_display))
4232 if not options.no_branch_color:
4233 branch_display = FormatBranchName(branch, colorize=True)
Daniel McArdle452a49f2019-02-14 17:28:31 +00004234
Alan Cuttera3be9a52019-03-04 18:50:33 +00004235 print(' %s : %s%s %s%s' % (padding + branch_display, color, url,
4236 status_str, reset))
Andrii Shyshkalovd0e1d9d2017-01-24 17:10:51 +01004237
vapiera7fbd5a2016-06-16 09:17:49 -07004238 print()
Daniel McArdlea23bf592019-02-12 00:25:12 +00004239 print('Current branch: %s' % current_branch)
Andrii Shyshkalovd0e1d9d2017-01-24 17:10:51 +01004240 for cl in changes:
Daniel McArdlea23bf592019-02-12 00:25:12 +00004241 if cl.GetBranch() == current_branch:
Andrii Shyshkalovd0e1d9d2017-01-24 17:10:51 +01004242 break
dpranke@chromium.orgee87f582015-07-31 18:46:25 +00004243 if not cl.GetIssue():
vapiera7fbd5a2016-06-16 09:17:49 -07004244 print('No issue assigned.')
dpranke@chromium.orgee87f582015-07-31 18:46:25 +00004245 return 0
vapiera7fbd5a2016-06-16 09:17:49 -07004246 print('Issue number: %s (%s)' % (cl.GetIssue(), cl.GetIssueURL()))
maruel@chromium.org85616e02014-07-28 15:37:55 +00004247 if not options.fast:
vapiera7fbd5a2016-06-16 09:17:49 -07004248 print('Issue description:')
4249 print(cl.GetDescription(pretty=True))
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004250 return 0
4251
4252
maruel@chromium.org39c0b222013-08-17 16:57:01 +00004253def colorize_CMDstatus_doc():
4254 """To be called once in main() to add colors to git cl status help."""
4255 colors = [i for i in dir(Fore) if i[0].isupper()]
4256
4257 def colorize_line(line):
4258 for color in colors:
4259 if color in line.upper():
Quinten Yearsley0c62da92017-05-31 13:39:42 -07004260 # Extract whitespace first and the leading '-'.
maruel@chromium.org39c0b222013-08-17 16:57:01 +00004261 indent = len(line) - len(line.lstrip(' ')) + 1
4262 return line[:indent] + getattr(Fore, color) + line[indent:] + Fore.RESET
4263 return line
4264
4265 lines = CMDstatus.__doc__.splitlines()
4266 CMDstatus.__doc__ = '\n'.join(colorize_line(l) for l in lines)
4267
4268
phajdan.jre328cf92016-08-22 04:12:17 -07004269def write_json(path, contents):
Stefan Zager1306bd02017-06-22 19:26:46 -07004270 if path == '-':
4271 json.dump(contents, sys.stdout)
4272 else:
4273 with open(path, 'w') as f:
4274 json.dump(contents, f)
phajdan.jre328cf92016-08-22 04:12:17 -07004275
4276
maruel@chromium.org0633fb42013-08-16 20:06:14 +00004277@subcommand.usage('[issue_number]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004278@metrics.collector.collect_metrics('git cl issue')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004279def CMDissue(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004280 """Sets or displays the current code review issue number.
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004281
4282 Pass issue number 0 to clear the current issue.
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004283 """
dnj@chromium.org406c4402015-03-03 17:22:28 +00004284 parser.add_option('-r', '--reverse', action='store_true',
4285 help='Lookup the branch(es) for the specified issues. If '
4286 'no issues are specified, all branches with mapped '
4287 'issues will be listed.')
Stefan Zager1306bd02017-06-22 19:26:46 -07004288 parser.add_option('--json',
4289 help='Path to JSON output file, or "-" for stdout.')
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00004290 _add_codereview_select_options(parser)
dnj@chromium.org406c4402015-03-03 17:22:28 +00004291 options, args = parser.parse_args(args)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00004292 _process_codereview_select_options(parser, options)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004293
dnj@chromium.org406c4402015-03-03 17:22:28 +00004294 if options.reverse:
4295 branches = RunGit(['for-each-ref', 'refs/heads',
Aaron Gablead64abd2017-12-04 09:49:13 -08004296 '--format=%(refname)']).splitlines()
dnj@chromium.org406c4402015-03-03 17:22:28 +00004297 # Reverse issue lookup.
4298 issue_branch_map = {}
Daniel Bratellb56a43a2018-09-06 15:49:03 +00004299
4300 git_config = {}
4301 for config in RunGit(['config', '--get-regexp',
4302 r'branch\..*issue']).splitlines():
4303 name, _space, val = config.partition(' ')
4304 git_config[name] = val
4305
dnj@chromium.org406c4402015-03-03 17:22:28 +00004306 for branch in branches:
Daniel Bratellb56a43a2018-09-06 15:49:03 +00004307 for cls in _CODEREVIEW_IMPLEMENTATIONS.values():
4308 config_key = _git_branch_config_key(ShortBranchName(branch),
4309 cls.IssueConfigKey())
4310 issue = git_config.get(config_key)
4311 if issue:
4312 issue_branch_map.setdefault(int(issue), []).append(branch)
dnj@chromium.org406c4402015-03-03 17:22:28 +00004313 if not args:
4314 args = sorted(issue_branch_map.iterkeys())
phajdan.jre328cf92016-08-22 04:12:17 -07004315 result = {}
dnj@chromium.org406c4402015-03-03 17:22:28 +00004316 for issue in args:
Lei Zhang5a368d42019-03-25 23:18:19 +00004317 try:
4318 issue_num = int(issue)
4319 except ValueError:
4320 print('ERROR cannot parse issue number: %s' % issue, file=sys.stderr)
dnj@chromium.org406c4402015-03-03 17:22:28 +00004321 continue
Lei Zhang5a368d42019-03-25 23:18:19 +00004322 result[issue_num] = issue_branch_map.get(issue_num)
vapiera7fbd5a2016-06-16 09:17:49 -07004323 print('Branch for issue number %s: %s' % (
Lei Zhang5a368d42019-03-25 23:18:19 +00004324 issue, ', '.join(issue_branch_map.get(issue_num) or ('None',))))
phajdan.jre328cf92016-08-22 04:12:17 -07004325 if options.json:
4326 write_json(options.json, result)
Aaron Gable78753da2017-06-15 10:35:49 -07004327 return 0
4328
4329 if len(args) > 0:
4330 issue = ParseIssueNumberArgument(args[0], options.forced_codereview)
4331 if not issue.valid:
4332 DieWithError('Pass a url or number to set the issue, 0 to unset it, '
4333 'or no argument to list it.\n'
4334 'Maybe you want to run git cl status?')
4335 cl = Changelist(codereview=issue.codereview)
4336 cl.SetIssue(issue.issue)
dnj@chromium.org406c4402015-03-03 17:22:28 +00004337 else:
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00004338 cl = Changelist(codereview=options.forced_codereview)
Aaron Gable78753da2017-06-15 10:35:49 -07004339 print('Issue number: %s (%s)' % (cl.GetIssue(), cl.GetIssueURL()))
4340 if options.json:
4341 write_json(options.json, {
4342 'issue': cl.GetIssue(),
4343 'issue_url': cl.GetIssueURL(),
4344 })
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004345 return 0
4346
4347
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004348@metrics.collector.collect_metrics('git cl comments')
maruel@chromium.org9977a2e2012-06-06 22:30:56 +00004349def CMDcomments(parser, args):
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004350 """Shows or posts review comments for any changelist."""
4351 parser.add_option('-a', '--add-comment', dest='comment',
4352 help='comment to add to an issue')
Sergiy Byelozyorovcb629a42018-10-28 19:20:39 +00004353 parser.add_option('-p', '--publish', action='store_true',
4354 help='marks CL as ready and sends comment to reviewers')
Andrii Shyshkalov0d6b46e2017-03-17 22:23:22 +01004355 parser.add_option('-i', '--issue', dest='issue',
4356 help='review issue id (defaults to current issue). '
4357 'If given, requires --rietveld or --gerrit')
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07004358 parser.add_option('-m', '--machine-readable', dest='readable',
4359 action='store_false', default=True,
4360 help='output comments in a format compatible with '
4361 'editor parsing')
smut@google.comc85ac942015-09-15 16:34:43 +00004362 parser.add_option('-j', '--json-file',
Stefan Zager1306bd02017-06-22 19:26:46 -07004363 help='File to write JSON summary to, or "-" for stdout')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004364 auth.add_auth_options(parser)
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01004365 _add_codereview_select_options(parser)
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004366 options, args = parser.parse_args(args)
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01004367 _process_codereview_select_options(parser, options)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004368 auth_config = auth.extract_auth_config_from_options(options)
maruel@chromium.org9977a2e2012-06-06 22:30:56 +00004369
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004370 issue = None
4371 if options.issue:
4372 try:
4373 issue = int(options.issue)
4374 except ValueError:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004375 DieWithError('A review issue ID is expected to be a number.')
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004376
Andrii Shyshkalov642641d2018-10-16 05:54:41 +00004377 cl = Changelist(issue=issue, codereview='gerrit', auth_config=auth_config)
4378
4379 if not cl.IsGerrit():
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004380 parser.error('Rietveld is not supported.')
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004381
4382 if options.comment:
Sergiy Byelozyorovcb629a42018-10-28 19:20:39 +00004383 cl.AddComment(options.comment, options.publish)
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004384 return 0
4385
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07004386 summary = sorted(cl.GetCommentsSummary(readable=options.readable),
4387 key=lambda c: c.date)
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01004388 for comment in summary:
4389 if comment.disapproval:
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004390 color = Fore.RED
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01004391 elif comment.approval:
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004392 color = Fore.GREEN
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01004393 elif comment.sender == cl.GetIssueOwner():
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004394 color = Fore.MAGENTA
Quinten Yearsley0e617c02019-02-20 00:37:03 +00004395 elif comment.autogenerated:
4396 color = Fore.CYAN
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004397 else:
4398 color = Fore.BLUE
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01004399 print('\n%s%s %s%s\n%s' % (
4400 color,
4401 comment.date.strftime('%Y-%m-%d %H:%M:%S UTC'),
4402 comment.sender,
4403 Fore.RESET,
4404 '\n'.join(' ' + l for l in comment.message.strip().splitlines())))
4405
smut@google.comc85ac942015-09-15 16:34:43 +00004406 if options.json_file:
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01004407 def pre_serialize(c):
4408 dct = c.__dict__.copy()
4409 dct['date'] = dct['date'].strftime('%Y-%m-%d %H:%M:%S.%f')
4410 return dct
Leszek Swirski45b20c42018-09-17 17:05:26 +00004411 write_json(options.json_file, map(pre_serialize, summary))
maruel@chromium.org9977a2e2012-06-06 22:30:56 +00004412 return 0
4413
4414
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00004415@subcommand.usage('[codereview url or issue id]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004416@metrics.collector.collect_metrics('git cl description')
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00004417def CMDdescription(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004418 """Brings up the editor for the current CL's description."""
smut@google.com34fb6b12015-07-13 20:03:26 +00004419 parser.add_option('-d', '--display', action='store_true',
4420 help='Display the description instead of opening an editor')
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00004421 parser.add_option('-n', '--new-description',
dnjba1b0f32016-09-02 12:37:42 -07004422 help='New description to set for this issue (- for stdin, '
4423 '+ to load from local commit HEAD)')
dsansomee2d6fd92016-09-08 00:10:47 -07004424 parser.add_option('-f', '--force', action='store_true',
4425 help='Delete any unpublished Gerrit edits for this issue '
4426 'without prompting')
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00004427
4428 _add_codereview_select_options(parser)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004429 auth.add_auth_options(parser)
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00004430 options, args = parser.parse_args(args)
4431 _process_codereview_select_options(parser, options)
4432
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01004433 target_issue_arg = None
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00004434 if len(args) > 0:
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004435 target_issue_arg = ParseIssueNumberArgument(args[0],
4436 options.forced_codereview)
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01004437 if not target_issue_arg.valid:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004438 parser.error('Invalid issue ID or URL.')
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00004439
martiniss6eda05f2016-06-30 10:18:35 -07004440 kwargs = {
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00004441 'auth_config': auth.extract_auth_config_from_options(options),
4442 'codereview': options.forced_codereview,
martiniss6eda05f2016-06-30 10:18:35 -07004443 }
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004444 detected_codereview_from_url = False
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01004445 if target_issue_arg:
4446 kwargs['issue'] = target_issue_arg.issue
4447 kwargs['codereview_host'] = target_issue_arg.hostname
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004448 if target_issue_arg.codereview and not options.forced_codereview:
4449 detected_codereview_from_url = True
4450 kwargs['codereview'] = target_issue_arg.codereview
martiniss6eda05f2016-06-30 10:18:35 -07004451
4452 cl = Changelist(**kwargs)
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00004453 if not cl.GetIssue():
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004454 assert not detected_codereview_from_url
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00004455 DieWithError('This branch has no associated changelist.')
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004456
4457 if detected_codereview_from_url:
4458 logging.info('canonical issue/change URL: %s (type: %s)\n',
4459 cl.GetIssueURL(), target_issue_arg.codereview)
4460
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00004461 description = ChangeDescription(cl.GetDescription())
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00004462
smut@google.com34fb6b12015-07-13 20:03:26 +00004463 if options.display:
vapiera7fbd5a2016-06-16 09:17:49 -07004464 print(description.description)
smut@google.com34fb6b12015-07-13 20:03:26 +00004465 return 0
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00004466
4467 if options.new_description:
4468 text = options.new_description
4469 if text == '-':
4470 text = '\n'.join(l.rstrip() for l in sys.stdin)
dnjba1b0f32016-09-02 12:37:42 -07004471 elif text == '+':
4472 base_branch = cl.GetCommonAncestorWithUpstream()
4473 change = cl.GetChange(base_branch, None, local_description=True)
4474 text = change.FullDescriptionText()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00004475
4476 description.set_description(text)
4477 else:
Aaron Gable3a16ed12017-03-23 10:51:55 -07004478 description.prompt(git_footer=cl.IsGerrit())
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00004479
Andrii Shyshkalov680253d2017-03-15 21:07:36 +01004480 if cl.GetDescription().strip() != description.description:
dsansomee2d6fd92016-09-08 00:10:47 -07004481 cl.UpdateDescription(description.description, force=options.force)
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00004482 return 0
4483
4484
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004485@metrics.collector.collect_metrics('git cl lint')
thestig@chromium.org44202a22014-03-11 19:22:18 +00004486def CMDlint(parser, args):
4487 """Runs cpplint on the current changelist."""
tzik@chromium.orgf204d4b2014-03-13 07:40:55 +00004488 parser.add_option('--filter', action='append', metavar='-x,+y',
4489 help='Comma-separated list of cpplint\'s category-filters')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004490 auth.add_auth_options(parser)
4491 options, args = parser.parse_args(args)
4492 auth_config = auth.extract_auth_config_from_options(options)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004493
4494 # Access to a protected member _XX of a client class
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08004495 # pylint: disable=protected-access
thestig@chromium.org44202a22014-03-11 19:22:18 +00004496 try:
4497 import cpplint
4498 import cpplint_chromium
4499 except ImportError:
vapiera7fbd5a2016-06-16 09:17:49 -07004500 print('Your depot_tools is missing cpplint.py and/or cpplint_chromium.py.')
thestig@chromium.org44202a22014-03-11 19:22:18 +00004501 return 1
4502
4503 # Change the current working directory before calling lint so that it
4504 # shows the correct base.
4505 previous_cwd = os.getcwd()
4506 os.chdir(settings.GetRoot())
4507 try:
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004508 cl = Changelist(auth_config=auth_config)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004509 change = cl.GetChange(cl.GetCommonAncestorWithUpstream(), None)
4510 files = [f.LocalPath() for f in change.AffectedFiles()]
thestig@chromium.org5839eb52014-05-30 16:20:51 +00004511 if not files:
vapiera7fbd5a2016-06-16 09:17:49 -07004512 print('Cannot lint an empty CL')
thestig@chromium.org5839eb52014-05-30 16:20:51 +00004513 return 1
thestig@chromium.org44202a22014-03-11 19:22:18 +00004514
4515 # Process cpplints arguments if any.
tzik@chromium.orgf204d4b2014-03-13 07:40:55 +00004516 command = args + files
4517 if options.filter:
4518 command = ['--filter=' + ','.join(options.filter)] + command
4519 filenames = cpplint.ParseArguments(command)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004520
4521 white_regex = re.compile(settings.GetLintRegex())
4522 black_regex = re.compile(settings.GetLintIgnoreRegex())
4523 extra_check_functions = [cpplint_chromium.CheckPointerDeclarationWhitespace]
4524 for filename in filenames:
4525 if white_regex.match(filename):
4526 if black_regex.match(filename):
vapiera7fbd5a2016-06-16 09:17:49 -07004527 print('Ignoring file %s' % filename)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004528 else:
4529 cpplint.ProcessFile(filename, cpplint._cpplint_state.verbose_level,
4530 extra_check_functions)
4531 else:
vapiera7fbd5a2016-06-16 09:17:49 -07004532 print('Skipping file %s' % filename)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004533 finally:
4534 os.chdir(previous_cwd)
vapiera7fbd5a2016-06-16 09:17:49 -07004535 print('Total errors found: %d\n' % cpplint._cpplint_state.error_count)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004536 if cpplint._cpplint_state.error_count != 0:
4537 return 1
4538 return 0
4539
4540
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004541@metrics.collector.collect_metrics('git cl presubmit')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004542def CMDpresubmit(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004543 """Runs presubmit tests on the current changelist."""
ilevy@chromium.org375a9022013-01-07 01:12:05 +00004544 parser.add_option('-u', '--upload', action='store_true',
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004545 help='Run upload hook instead of the push hook')
ilevy@chromium.org375a9022013-01-07 01:12:05 +00004546 parser.add_option('-f', '--force', action='store_true',
sbc@chromium.org495ad152012-09-04 23:07:42 +00004547 help='Run checks even if tree is dirty')
Aaron Gable8076c282017-11-29 14:39:41 -08004548 parser.add_option('--all', action='store_true',
4549 help='Run checks against all files, not just modified ones')
Edward Lesmes8e282792018-04-03 18:50:29 -04004550 parser.add_option('--parallel', action='store_true',
4551 help='Run all tests specified by input_api.RunTests in all '
4552 'PRESUBMIT files in parallel.')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004553 auth.add_auth_options(parser)
4554 options, args = parser.parse_args(args)
4555 auth_config = auth.extract_auth_config_from_options(options)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004556
sbc@chromium.org71437c02015-04-09 19:29:40 +00004557 if not options.force and git_common.is_dirty_git_tree('presubmit'):
vapiera7fbd5a2016-06-16 09:17:49 -07004558 print('use --force to check even if tree is dirty.')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004559 return 1
4560
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004561 cl = Changelist(auth_config=auth_config)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004562 if args:
4563 base_branch = args[0]
4564 else:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00004565 # Default to diffing against the common ancestor of the upstream branch.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00004566 base_branch = cl.GetCommonAncestorWithUpstream()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004567
Aaron Gable8076c282017-11-29 14:39:41 -08004568 if options.all:
4569 base_change = cl.GetChange(base_branch, None)
4570 files = [('M', f) for f in base_change.AllFiles()]
4571 change = presubmit_support.GitChange(
4572 base_change.Name(),
4573 base_change.FullDescriptionText(),
4574 base_change.RepositoryRoot(),
4575 files,
4576 base_change.issue,
4577 base_change.patchset,
4578 base_change.author_email,
4579 base_change._upstream)
4580 else:
4581 change = cl.GetChange(base_branch, None)
4582
ilevy@chromium.org051ad0e2013-03-04 21:57:34 +00004583 cl.RunHook(
4584 committing=not options.upload,
4585 may_prompt=False,
4586 verbose=options.verbose,
Edward Lesmes8e282792018-04-03 18:50:29 -04004587 change=change,
4588 parallel=options.parallel)
dpranke@chromium.org0a2bb372011-03-25 01:16:22 +00004589 return 0
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004590
4591
tandrii@chromium.org65874e12016-03-04 12:03:02 +00004592def GenerateGerritChangeId(message):
4593 """Returns Ixxxxxx...xxx change id.
4594
4595 Works the same way as
4596 https://gerrit-review.googlesource.com/tools/hooks/commit-msg
4597 but can be called on demand on all platforms.
4598
4599 The basic idea is to generate git hash of a state of the tree, original commit
4600 message, author/committer info and timestamps.
4601 """
4602 lines = []
4603 tree_hash = RunGitSilent(['write-tree'])
4604 lines.append('tree %s' % tree_hash.strip())
4605 code, parent = RunGitWithCode(['rev-parse', 'HEAD~0'], suppress_stderr=False)
4606 if code == 0:
4607 lines.append('parent %s' % parent.strip())
4608 author = RunGitSilent(['var', 'GIT_AUTHOR_IDENT'])
4609 lines.append('author %s' % author.strip())
4610 committer = RunGitSilent(['var', 'GIT_COMMITTER_IDENT'])
4611 lines.append('committer %s' % committer.strip())
4612 lines.append('')
4613 # Note: Gerrit's commit-hook actually cleans message of some lines and
4614 # whitespace. This code is not doing this, but it clearly won't decrease
4615 # entropy.
4616 lines.append(message)
4617 change_hash = RunCommand(['git', 'hash-object', '-t', 'commit', '--stdin'],
Raul Tambreb946b232019-03-26 14:48:46 +00004618 stdin=('\n'.join(lines)).encode())
tandrii@chromium.org65874e12016-03-04 12:03:02 +00004619 return 'I%s' % change_hash.strip()
4620
4621
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01004622def GetTargetRef(remote, remote_branch, target_branch):
wittman@chromium.org455dc922015-01-26 20:15:50 +00004623 """Computes the remote branch ref to use for the CL.
4624
4625 Args:
4626 remote (str): The git remote for the CL.
4627 remote_branch (str): The git remote branch for the CL.
4628 target_branch (str): The target branch specified by the user.
wittman@chromium.org455dc922015-01-26 20:15:50 +00004629 """
4630 if not (remote and remote_branch):
4631 return None
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00004632
wittman@chromium.org455dc922015-01-26 20:15:50 +00004633 if target_branch:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07004634 # Canonicalize branch references to the equivalent local full symbolic
wittman@chromium.org455dc922015-01-26 20:15:50 +00004635 # refs, which are then translated into the remote full symbolic refs
4636 # below.
4637 if '/' not in target_branch:
4638 remote_branch = 'refs/remotes/%s/%s' % (remote, target_branch)
4639 else:
4640 prefix_replacements = (
4641 ('^((refs/)?remotes/)?branch-heads/', 'refs/remotes/branch-heads/'),
4642 ('^((refs/)?remotes/)?%s/' % remote, 'refs/remotes/%s/' % remote),
4643 ('^(refs/)?heads/', 'refs/remotes/%s/' % remote),
4644 )
4645 match = None
4646 for regex, replacement in prefix_replacements:
4647 match = re.search(regex, target_branch)
4648 if match:
4649 remote_branch = target_branch.replace(match.group(0), replacement)
4650 break
4651 if not match:
4652 # This is a branch path but not one we recognize; use as-is.
4653 remote_branch = target_branch
rmistry@google.comc68112d2015-03-03 12:48:06 +00004654 elif remote_branch in REFS_THAT_ALIAS_TO_OTHER_REFS:
4655 # Handle the refs that need to land in different refs.
4656 remote_branch = REFS_THAT_ALIAS_TO_OTHER_REFS[remote_branch]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00004657
wittman@chromium.org455dc922015-01-26 20:15:50 +00004658 # Create the true path to the remote branch.
4659 # Does the following translation:
4660 # * refs/remotes/origin/refs/diff/test -> refs/diff/test
4661 # * refs/remotes/origin/master -> refs/heads/master
4662 # * refs/remotes/branch-heads/test -> refs/branch-heads/test
4663 if remote_branch.startswith('refs/remotes/%s/refs/' % remote):
4664 remote_branch = remote_branch.replace('refs/remotes/%s/' % remote, '')
4665 elif remote_branch.startswith('refs/remotes/%s/' % remote):
4666 remote_branch = remote_branch.replace('refs/remotes/%s/' % remote,
4667 'refs/heads/')
4668 elif remote_branch.startswith('refs/remotes/branch-heads'):
4669 remote_branch = remote_branch.replace('refs/remotes/', 'refs/')
Andrii Shyshkalov768f1d82016-12-08 15:10:13 +01004670
wittman@chromium.org455dc922015-01-26 20:15:50 +00004671 return remote_branch
4672
4673
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004674def cleanup_list(l):
4675 """Fixes a list so that comma separated items are put as individual items.
4676
4677 So that "--reviewers joe@c,john@c --reviewers joa@c" results in
4678 options.reviewers == sorted(['joe@c', 'john@c', 'joa@c']).
4679 """
4680 items = sum((i.split(',') for i in l), [])
4681 stripped_items = (i.strip() for i in items)
4682 return sorted(filter(None, stripped_items))
4683
4684
Aaron Gable4db38df2017-11-03 14:59:07 -07004685@subcommand.usage('[flags]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004686@metrics.collector.collect_metrics('git cl upload')
ukai@chromium.orge8077812012-02-03 03:41:46 +00004687def CMDupload(parser, args):
rmistry@google.com78948ed2015-07-08 23:09:57 +00004688 """Uploads the current changelist to codereview.
4689
4690 Can skip dependency patchset uploads for a branch by running:
4691 git config branch.branch_name.skip-deps-uploads True
4692 To unset run:
4693 git config --unset branch.branch_name.skip-deps-uploads
4694 Can also set the above globally by using the --global flag.
Dominic Battre7d1c4842017-10-27 09:17:28 +02004695
4696 If the name of the checked out branch starts with "bug-" or "fix-" followed by
4697 a bug number, this bug number is automatically populated in the CL
4698 description.
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004699
4700 If subject contains text in square brackets or has "<text>: " prefix, such
4701 text(s) is treated as Gerrit hashtags. For example, CLs with subjects
4702 [git-cl] add support for hashtags
4703 Foo bar: implement foo
4704 will be hashtagged with "git-cl" and "foo-bar" respectively.
rmistry@google.com78948ed2015-07-08 23:09:57 +00004705 """
ukai@chromium.orge8077812012-02-03 03:41:46 +00004706 parser.add_option('--bypass-hooks', action='store_true', dest='bypass_hooks',
4707 help='bypass upload presubmit hook')
brettw@chromium.orgb65c43c2013-06-10 22:04:49 +00004708 parser.add_option('--bypass-watchlists', action='store_true',
4709 dest='bypass_watchlists',
4710 help='bypass watchlists auto CC-ing reviewers')
Aaron Gablef7543cd2017-07-20 14:26:31 -07004711 parser.add_option('-f', '--force', action='store_true', dest='force',
ukai@chromium.orge8077812012-02-03 03:41:46 +00004712 help="force yes to questions (don't prompt)")
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004713 parser.add_option('--message', '-m', dest='message',
4714 help='message for patchset')
tandriif9aefb72016-07-01 09:06:51 -07004715 parser.add_option('-b', '--bug',
4716 help='pre-populate the bug number(s) for this issue. '
4717 'If several, separate with commas')
tandriib80458a2016-06-23 12:20:07 -07004718 parser.add_option('--message-file', dest='message_file',
4719 help='file which contains message for patchset')
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004720 parser.add_option('--title', '-t', dest='title',
4721 help='title for patchset')
ukai@chromium.orge8077812012-02-03 03:41:46 +00004722 parser.add_option('-r', '--reviewers',
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004723 action='append', default=[],
ukai@chromium.orge8077812012-02-03 03:41:46 +00004724 help='reviewer email addresses')
Robert Iannucci6c98dc62017-04-18 11:38:00 -07004725 parser.add_option('--tbrs',
4726 action='append', default=[],
4727 help='TBR email addresses')
ukai@chromium.orge8077812012-02-03 03:41:46 +00004728 parser.add_option('--cc',
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004729 action='append', default=[],
ukai@chromium.orge8077812012-02-03 03:41:46 +00004730 help='cc email addresses')
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004731 parser.add_option('--hashtag', dest='hashtags',
4732 action='append', default=[],
4733 help=('Gerrit hashtag for new CL; '
4734 'can be applied multiple times'))
adamk@chromium.org36f47302013-04-05 01:08:31 +00004735 parser.add_option('-s', '--send-mail', action='store_true',
Aaron Gable59f48512017-01-12 10:54:46 -08004736 help='send email to reviewer(s) and cc(s) immediately')
ukai@chromium.org8ef7ab22012-11-28 04:24:52 +00004737 parser.add_option('--target_branch',
pgervais@chromium.orgb9f27512014-08-08 15:52:33 +00004738 '--target-branch',
wittman@chromium.org455dc922015-01-26 20:15:50 +00004739 metavar='TARGET',
4740 help='Apply CL to remote ref TARGET. ' +
4741 'Default: remote branch head, or master')
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00004742 parser.add_option('--squash', action='store_true',
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004743 help='Squash multiple commits into one')
bauerb@chromium.org54b400c2016-01-14 10:08:25 +00004744 parser.add_option('--no-squash', action='store_true',
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004745 help='Don\'t squash multiple commits into one')
rmistry9eadede2016-09-19 11:22:43 -07004746 parser.add_option('--topic', default=None,
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004747 help='Topic to specify when uploading')
Robert Iannuccif2708bd2017-04-17 15:49:02 -07004748 parser.add_option('--tbr-owners', dest='add_owners_to', action='store_const',
4749 const='TBR', help='add a set of OWNERS to TBR')
4750 parser.add_option('--r-owners', dest='add_owners_to', action='store_const',
4751 const='R', help='add a set of OWNERS to R')
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00004752 parser.add_option('-c', '--use-commit-queue', action='store_true',
4753 help='tell the CQ to commit this patchset; '
4754 'implies --send-mail')
tandrii@chromium.orgd50452a2015-11-23 16:38:15 +00004755 parser.add_option('-d', '--cq-dry-run', dest='cq_dry_run',
4756 action='store_true',
rmistry@google.comef966222015-04-07 11:15:01 +00004757 help='Send the patchset to do a CQ dry run right after '
4758 'upload.')
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +00004759 parser.add_option('--preserve-tryjobs', action='store_true',
4760 help='instruct the CQ to let tryjobs running even after '
4761 'new patchsets are uploaded instead of canceling '
4762 'prior patchset\' tryjobs')
rmistry@google.com2dd99862015-06-22 12:22:18 +00004763 parser.add_option('--dependencies', action='store_true',
4764 help='Uploads CLs of all the local branches that depend on '
4765 'the current branch')
Ravi Mistry31e7d562018-04-02 12:53:57 -04004766 parser.add_option('-a', '--enable-auto-submit', action='store_true',
4767 help='Sends your change to the CQ after an approval. Only '
4768 'works on repos that have the Auto-Submit label '
4769 'enabled')
Edward Lesmes8e282792018-04-03 18:50:29 -04004770 parser.add_option('--parallel', action='store_true',
4771 help='Run all tests specified by input_api.RunTests in all '
4772 'PRESUBMIT files in parallel.')
pgervais@chromium.org91141372014-01-09 23:27:20 +00004773
Sergiy Byelozyorov1aa405f2018-09-18 17:38:43 +00004774 parser.add_option('--no-autocc', action='store_true',
4775 help='Disables automatic addition of CC emails')
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004776 parser.add_option('--private', action='store_true',
Sergiy Byelozyorov1aa405f2018-09-18 17:38:43 +00004777 help='Set the review private. This implies --no-autocc.')
4778
rmistry@google.com2dd99862015-06-22 12:22:18 +00004779 orig_args = args
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004780 auth.add_auth_options(parser)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00004781 _add_codereview_select_options(parser)
ukai@chromium.orge8077812012-02-03 03:41:46 +00004782 (options, args) = parser.parse_args(args)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00004783 _process_codereview_select_options(parser, options)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004784 auth_config = auth.extract_auth_config_from_options(options)
ukai@chromium.orge8077812012-02-03 03:41:46 +00004785
sbc@chromium.org71437c02015-04-09 19:29:40 +00004786 if git_common.is_dirty_git_tree('upload'):
ukai@chromium.orge8077812012-02-03 03:41:46 +00004787 return 1
4788
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004789 options.reviewers = cleanup_list(options.reviewers)
Robert Iannucci6c98dc62017-04-18 11:38:00 -07004790 options.tbrs = cleanup_list(options.tbrs)
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004791 options.cc = cleanup_list(options.cc)
4792
tandriib80458a2016-06-23 12:20:07 -07004793 if options.message_file:
4794 if options.message:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004795 parser.error('Only one of --message and --message-file allowed.')
tandriib80458a2016-06-23 12:20:07 -07004796 options.message = gclient_utils.FileRead(options.message_file)
4797 options.message_file = None
4798
tandrii4d0545a2016-07-06 03:56:49 -07004799 if options.cq_dry_run and options.use_commit_queue:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004800 parser.error('Only one of --use-commit-queue and --cq-dry-run allowed.')
tandrii4d0545a2016-07-06 03:56:49 -07004801
Aaron Gableedbc4132017-09-11 13:22:28 -07004802 if options.use_commit_queue:
4803 options.send_mail = True
4804
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00004805 # For sanity of test expectations, do this otherwise lazy-loading *now*.
4806 settings.GetIsGerrit()
4807
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00004808 cl = Changelist(auth_config=auth_config, codereview=options.forced_codereview)
Andrii Shyshkalov9f274432018-10-15 16:40:23 +00004809 if not cl.IsGerrit():
4810 # Error out with instructions for repos not yet configured for Gerrit.
4811 print('=====================================')
4812 print('NOTICE: Rietveld is no longer supported. '
4813 'You can upload changes to Gerrit with')
4814 print(' git cl upload --gerrit')
4815 print('or set Gerrit to be your default code review tool with')
4816 print(' git config gerrit.host true')
4817 print('=====================================')
4818 return 1
4819
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00004820 return cl.CMDUpload(options, args, orig_args)
ukai@chromium.orge8077812012-02-03 03:41:46 +00004821
4822
Francois Dorayd42c6812017-05-30 15:10:20 -04004823@subcommand.usage('--description=<description file>')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004824@metrics.collector.collect_metrics('git cl split')
Francois Dorayd42c6812017-05-30 15:10:20 -04004825def CMDsplit(parser, args):
4826 """Splits a branch into smaller branches and uploads CLs.
4827
4828 Creates a branch and uploads a CL for each group of files modified in the
4829 current branch that share a common OWNERS file. In the CL description and
Quinten Yearsley0c62da92017-05-31 13:39:42 -07004830 comment, the string '$directory', is replaced with the directory containing
Francois Dorayd42c6812017-05-30 15:10:20 -04004831 the shared OWNERS file.
4832 """
4833 parser.add_option("-d", "--description", dest="description_file",
Gabriel Charette02b5ee82017-11-08 16:36:05 -05004834 help="A text file containing a CL description in which "
4835 "$directory will be replaced by each CL's directory.")
Francois Dorayd42c6812017-05-30 15:10:20 -04004836 parser.add_option("-c", "--comment", dest="comment_file",
4837 help="A text file containing a CL comment.")
Chris Watkinsba28e462017-12-13 11:22:17 +11004838 parser.add_option("-n", "--dry-run", dest="dry_run", action='store_true',
4839 default=False,
4840 help="List the files and reviewers for each CL that would "
4841 "be created, but don't create branches or CLs.")
Stephen Martiniscb326682018-08-29 21:06:30 +00004842 parser.add_option("--cq-dry-run", action='store_true',
4843 help="If set, will do a cq dry run for each uploaded CL. "
4844 "Please be careful when doing this; more than ~10 CLs "
4845 "has the potential to overload our build "
4846 "infrastructure. Try to upload these not during high "
4847 "load times (usually 11-3 Mountain View time). Email "
4848 "infra-dev@chromium.org with any questions.")
Takuto Ikuta51eca592019-02-14 19:40:52 +00004849 parser.add_option('-a', '--enable-auto-submit', action='store_true',
4850 default=True,
4851 help='Sends your change to the CQ after an approval. Only '
4852 'works on repos that have the Auto-Submit label '
4853 'enabled')
Francois Dorayd42c6812017-05-30 15:10:20 -04004854 options, _ = parser.parse_args(args)
4855
4856 if not options.description_file:
4857 parser.error('No --description flag specified.')
4858
4859 def WrappedCMDupload(args):
4860 return CMDupload(OptionParser(), args)
4861
4862 return split_cl.SplitCl(options.description_file, options.comment_file,
Stephen Martiniscb326682018-08-29 21:06:30 +00004863 Changelist, WrappedCMDupload, options.dry_run,
Takuto Ikuta51eca592019-02-14 19:40:52 +00004864 options.cq_dry_run, options.enable_auto_submit)
Francois Dorayd42c6812017-05-30 15:10:20 -04004865
4866
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004867@subcommand.usage('DEPRECATED')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004868@metrics.collector.collect_metrics('git cl commit')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004869def CMDdcommit(parser, args):
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004870 """DEPRECATED: Used to commit the current changelist via git-svn."""
4871 message = ('git-cl no longer supports committing to SVN repositories via '
4872 'git-svn. You probably want to use `git cl land` instead.')
4873 print(message)
4874 return 1
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004875
4876
Andrii Shyshkalovaa31b972017-03-24 16:16:33 +01004877# Two special branches used by git cl land.
4878MERGE_BRANCH = 'git-cl-commit'
4879CHERRY_PICK_BRANCH = 'git-cl-cherry-pick'
4880
4881
maruel@chromium.org0633fb42013-08-16 20:06:14 +00004882@subcommand.usage('[upstream branch to apply against]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004883@metrics.collector.collect_metrics('git cl land')
pgervais@chromium.orgcee6dc42014-05-07 17:04:03 +00004884def CMDland(parser, args):
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004885 """Commits the current changelist via git.
4886
4887 In case of Gerrit, uses Gerrit REST api to "submit" the issue, which pushes
4888 upstream and closes the issue automatically and atomically.
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004889 """
4890 parser.add_option('--bypass-hooks', action='store_true', dest='bypass_hooks',
4891 help='bypass upload presubmit hook')
Aaron Gablef7543cd2017-07-20 14:26:31 -07004892 parser.add_option('-f', '--force', action='store_true', dest='force',
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004893 help="force yes to questions (don't prompt)")
Edward Lesmes67b3faa2018-04-13 17:50:52 -04004894 parser.add_option('--parallel', action='store_true',
4895 help='Run all tests specified by input_api.RunTests in all '
4896 'PRESUBMIT files in parallel.')
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004897 auth.add_auth_options(parser)
4898 (options, args) = parser.parse_args(args)
4899 auth_config = auth.extract_auth_config_from_options(options)
4900
4901 cl = Changelist(auth_config=auth_config)
4902
Robert Iannucci2e73d432018-03-14 01:10:47 -07004903 if not cl.IsGerrit():
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004904 parser.error('Rietveld is not supported.')
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004905
Robert Iannucci2e73d432018-03-14 01:10:47 -07004906 if not cl.GetIssue():
4907 DieWithError('You must upload the change first to Gerrit.\n'
4908 ' If you would rather have `git cl land` upload '
4909 'automatically for you, see http://crbug.com/642759')
4910 return cl._codereview_impl.CMDLand(options.force, options.bypass_hooks,
Olivier Robin75ee7252018-04-13 10:02:56 +02004911 options.verbose, options.parallel)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004912
4913
dsinclair@chromium.orgfbed6562015-09-25 21:22:36 +00004914@subcommand.usage('<patch url or issue id or issue url>')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004915@metrics.collector.collect_metrics('git cl patch')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004916def CMDpatch(parser, args):
marq@chromium.orge5e59002013-10-02 23:21:25 +00004917 """Patches in a code review."""
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004918 parser.add_option('-b', dest='newbranch',
4919 help='create a new branch off trunk for the patch')
qsr@chromium.org1ef44af2013-10-16 16:24:32 +00004920 parser.add_option('-f', '--force', action='store_true',
Aaron Gable62619a32017-06-16 08:22:09 -07004921 help='overwrite state on the current or chosen branch')
qsr@chromium.org1ef44af2013-10-16 16:24:32 +00004922 parser.add_option('-d', '--directory', action='store', metavar='DIR',
Aaron Gable62619a32017-06-16 08:22:09 -07004923 help='change to the directory DIR immediately, '
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00004924 'before doing anything else. Rietveld only.')
qsr@chromium.org1ef44af2013-10-16 16:24:32 +00004925 parser.add_option('--reject', action='store_true',
tapted@chromium.org6a0b07c2013-07-10 01:29:19 +00004926 help='failed patches spew .rej files rather than '
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00004927 'attempting a 3-way merge. Rietveld only.')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004928 parser.add_option('-n', '--no-commit', action='store_true', dest='nocommit',
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00004929 help='don\'t commit after patch applies. Rietveld only.')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004930
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00004931
4932 group = optparse.OptionGroup(
4933 parser,
4934 'Options for continuing work on the current issue uploaded from a '
4935 'different clone (e.g. different machine). Must be used independently '
4936 'from the other options. No issue number should be specified, and the '
4937 'branch must have an issue number associated with it')
4938 group.add_option('--reapply', action='store_true', dest='reapply',
4939 help='Reset the branch and reapply the issue.\n'
4940 'CAUTION: This will undo any local changes in this '
4941 'branch')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004942
4943 group.add_option('--pull', action='store_true', dest='pull',
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00004944 help='Performs a pull before reapplying.')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004945 parser.add_option_group(group)
4946
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004947 auth.add_auth_options(parser)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00004948 _add_codereview_select_options(parser)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004949 (options, args) = parser.parse_args(args)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00004950 _process_codereview_select_options(parser, options)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004951 auth_config = auth.extract_auth_config_from_options(options)
4952
Andrii Shyshkalov18975322017-01-25 16:44:13 +01004953 if options.reapply:
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004954 if options.newbranch:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004955 parser.error('--reapply works on the current branch only.')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004956 if len(args) > 0:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004957 parser.error('--reapply implies no additional arguments.')
dsinclair@chromium.orgfbed6562015-09-25 21:22:36 +00004958
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004959 cl = Changelist(auth_config=auth_config,
4960 codereview=options.forced_codereview)
4961 if not cl.GetIssue():
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004962 parser.error('Current branch must have an associated issue.')
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004963
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004964 upstream = cl.GetUpstreamBranch()
Andrii Shyshkalov18975322017-01-25 16:44:13 +01004965 if upstream is None:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004966 parser.error('No upstream branch specified. Cannot reset branch.')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004967
4968 RunGit(['reset', '--hard', upstream])
4969 if options.pull:
4970 RunGit(['pull'])
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004971
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004972 return cl.CMDPatchIssue(cl.GetIssue(), options.reject, options.nocommit,
4973 options.directory)
4974
4975 if len(args) != 1 or not args[0]:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004976 parser.error('Must specify issue number or URL.')
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004977
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004978 target_issue_arg = ParseIssueNumberArgument(args[0],
4979 options.forced_codereview)
4980 if not target_issue_arg.valid:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004981 parser.error('Invalid issue ID or URL.')
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004982
4983 cl_kwargs = {
4984 'auth_config': auth_config,
4985 'codereview_host': target_issue_arg.hostname,
4986 'codereview': options.forced_codereview,
4987 }
4988 detected_codereview_from_url = False
4989 if target_issue_arg.codereview and not options.forced_codereview:
4990 detected_codereview_from_url = True
4991 cl_kwargs['codereview'] = target_issue_arg.codereview
4992 cl_kwargs['issue'] = target_issue_arg.issue
4993
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004994 # We don't want uncommitted changes mixed up with the patch.
4995 if git_common.is_dirty_git_tree('patch'):
dsinclair@chromium.orgfbed6562015-09-25 21:22:36 +00004996 return 1
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004997
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004998 if options.newbranch:
4999 if options.force:
5000 RunGit(['branch', '-D', options.newbranch],
5001 stderr=subprocess2.PIPE, error_ok=True)
5002 RunGit(['new-branch', options.newbranch])
5003
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02005004 cl = Changelist(**cl_kwargs)
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00005005
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00005006 if cl.IsGerrit():
5007 if options.reject:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00005008 parser.error('--reject is not supported with Gerrit code review.')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00005009 if options.directory:
5010 parser.error('--directory is not supported with Gerrit codereview.')
5011
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02005012 if detected_codereview_from_url:
5013 print('canonical issue/change URL: %s (type: %s)\n' %
5014 (cl.GetIssueURL(), target_issue_arg.codereview))
5015
5016 return cl.CMDPatchWithParsedIssue(target_issue_arg, options.reject,
Aaron Gable62619a32017-06-16 08:22:09 -07005017 options.nocommit, options.directory,
5018 options.force)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005019
5020
jochen@chromium.org3ec0d542014-01-14 20:00:03 +00005021def GetTreeStatus(url=None):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005022 """Fetches the tree status and returns either 'open', 'closed',
5023 'unknown' or 'unset'."""
jochen@chromium.org3ec0d542014-01-14 20:00:03 +00005024 url = url or settings.GetTreeStatusUrl(error_ok=True)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005025 if url:
5026 status = urllib2.urlopen(url).read().lower()
5027 if status.find('closed') != -1 or status == '0':
5028 return 'closed'
5029 elif status.find('open') != -1 or status == '1':
5030 return 'open'
5031 return 'unknown'
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005032 return 'unset'
5033
dpranke@chromium.org970c5222011-03-12 00:32:24 +00005034
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005035def GetTreeStatusReason():
5036 """Fetches the tree status from a json url and returns the message
5037 with the reason for the tree to be opened or closed."""
msb@chromium.orgbf1a7ba2011-02-01 16:21:46 +00005038 url = settings.GetTreeStatusUrl()
5039 json_url = urlparse.urljoin(url, '/current?format=json')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005040 connection = urllib2.urlopen(json_url)
5041 status = json.loads(connection.read())
5042 connection.close()
5043 return status['message']
5044
dpranke@chromium.org970c5222011-03-12 00:32:24 +00005045
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005046@metrics.collector.collect_metrics('git cl tree')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005047def CMDtree(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005048 """Shows the status of the tree."""
dpranke@chromium.org97ae58e2011-03-18 00:29:20 +00005049 _, args = parser.parse_args(args)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005050 status = GetTreeStatus()
5051 if 'unset' == status:
vapiera7fbd5a2016-06-16 09:17:49 -07005052 print('You must configure your tree status URL by running "git cl config".')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005053 return 2
5054
vapiera7fbd5a2016-06-16 09:17:49 -07005055 print('The tree is %s' % status)
5056 print()
5057 print(GetTreeStatusReason())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005058 if status != 'open':
5059 return 1
5060 return 0
5061
5062
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005063@metrics.collector.collect_metrics('git cl try')
maruel@chromium.org15192402012-09-06 12:38:29 +00005064def CMDtry(parser, args):
Quinten Yearsleyd242ed72019-07-25 17:17:55 +00005065 """Triggers tryjobs using either BuildBucket or CQ dry run."""
tandrii1838bad2016-10-06 00:10:52 -07005066 group = optparse.OptionGroup(parser, 'Try job options')
maruel@chromium.org15192402012-09-06 12:38:29 +00005067 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07005068 '-b', '--bot', action='append',
5069 help=('IMPORTANT: specify ONE builder per --bot flag. Use it multiple '
5070 'times to specify multiple builders. ex: '
5071 '"-b win_rel -b win_layout". See '
5072 'the try server waterfall for the builders name and the tests '
5073 'available.'))
maruel@chromium.org15192402012-09-06 12:38:29 +00005074 group.add_option(
borenet6c0efe62016-10-19 08:13:29 -07005075 '-B', '--bucket', default='',
5076 help=('Buildbucket bucket to send the try requests.'))
5077 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07005078 '-m', '--master', default='',
Nodir Turakulovf6929a12017-10-09 12:34:44 -07005079 help=('DEPRECATED, use -B. The try master where to run the builds.'))
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00005080 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07005081 '-r', '--revision',
tandriif7b29d42016-10-07 08:45:41 -07005082 help='Revision to use for the try job; default: the revision will '
5083 'be determined by the try recipe that builder runs, which usually '
5084 'defaults to HEAD of origin/master')
maruel@chromium.org15192402012-09-06 12:38:29 +00005085 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07005086 '-c', '--clobber', action='store_true', default=False,
tandriif7b29d42016-10-07 08:45:41 -07005087 help='Force a clobber before building; that is don\'t do an '
tandrii1838bad2016-10-06 00:10:52 -07005088 'incremental build')
maruel@chromium.org15192402012-09-06 12:38:29 +00005089 group.add_option(
Andrii Shyshkalovf9648b52018-02-21 22:32:42 -08005090 '--category', default='git_cl_try', help='Specify custom build category.')
5091 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07005092 '--project',
5093 help='Override which project to use. Projects are defined '
tandriif7b29d42016-10-07 08:45:41 -07005094 'in recipe to determine to which repository or directory to '
5095 'apply the patch')
maruel@chromium.org15192402012-09-06 12:38:29 +00005096 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07005097 '-p', '--property', dest='properties', action='append', default=[],
5098 help='Specify generic properties in the form -p key1=value1 -p '
tandriif7b29d42016-10-07 08:45:41 -07005099 'key2=value2 etc. The value will be treated as '
5100 'json if decodable, or as string otherwise. '
5101 'NOTE: using this may make your try job not usable for CQ, '
5102 'which will then schedule another try job with default properties')
sheyang@chromium.orgdb375572015-08-17 19:22:23 +00005103 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07005104 '--buildbucket-host', default='cr-buildbucket.appspot.com',
5105 help='Host of buildbucket. The default host is %default.')
maruel@chromium.org15192402012-09-06 12:38:29 +00005106 parser.add_option_group(group)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005107 auth.add_auth_options(parser)
Koji Ishii31c14782018-01-08 17:17:33 +09005108 _add_codereview_issue_select_options(parser)
maruel@chromium.org15192402012-09-06 12:38:29 +00005109 options, args = parser.parse_args(args)
Koji Ishii31c14782018-01-08 17:17:33 +09005110 _process_codereview_issue_select_options(parser, options)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005111 auth_config = auth.extract_auth_config_from_options(options)
maruel@chromium.org15192402012-09-06 12:38:29 +00005112
Nodir Turakulovf6929a12017-10-09 12:34:44 -07005113 if options.master and options.master.startswith('luci.'):
5114 parser.error(
5115 '-m option does not support LUCI. Please pass -B %s' % options.master)
machenbach@chromium.org45453142015-09-15 08:45:22 +00005116 # Make sure that all properties are prop=value pairs.
5117 bad_params = [x for x in options.properties if '=' not in x]
5118 if bad_params:
5119 parser.error('Got properties with missing "=": %s' % bad_params)
5120
maruel@chromium.org15192402012-09-06 12:38:29 +00005121 if args:
5122 parser.error('Unknown arguments: %s' % args)
5123
Koji Ishii31c14782018-01-08 17:17:33 +09005124 cl = Changelist(auth_config=auth_config, issue=options.issue,
5125 codereview=options.forced_codereview)
maruel@chromium.org15192402012-09-06 12:38:29 +00005126 if not cl.GetIssue():
Quinten Yearsleyc4202212019-07-22 23:34:40 +00005127 parser.error('Need to upload first.')
maruel@chromium.org15192402012-09-06 12:38:29 +00005128
Andrii Shyshkaloveadad922017-01-26 09:38:30 +01005129 if cl.IsGerrit():
5130 # HACK: warm up Gerrit change detail cache to save on RPCs.
5131 cl._codereview_impl._GetChangeDetail(['DETAILED_ACCOUNTS', 'ALL_REVISIONS'])
5132
tandriie113dfd2016-10-11 10:20:12 -07005133 error_message = cl.CannotTriggerTryJobReason()
5134 if error_message:
qyearsley99e2cdf2016-10-23 12:51:41 -07005135 parser.error('Can\'t trigger try jobs: %s' % error_message)
jrobbins@chromium.org16f10f72014-06-24 22:14:36 +00005136
borenet6c0efe62016-10-19 08:13:29 -07005137 if options.bucket and options.master:
5138 parser.error('Only one of --bucket and --master may be used.')
5139
qyearsley1fdfcb62016-10-24 13:22:03 -07005140 buckets = _get_bucket_map(cl, options, parser)
phajdan.jr@chromium.org8da7f272014-03-14 01:28:39 +00005141
qyearsleydd49f942016-10-28 11:57:22 -07005142 # If no bots are listed and we couldn't get a list based on PRESUBMIT files,
5143 # then we default to triggering a CQ dry run (see http://crbug.com/625697).
qyearsley1fdfcb62016-10-24 13:22:03 -07005144 if not buckets:
qyearsley1fdfcb62016-10-24 13:22:03 -07005145 if options.verbose:
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07005146 print('git cl try with no bots now defaults to CQ dry run.')
5147 print('Scheduling CQ dry run on: %s' % cl.GetIssueURL())
5148 return cl.SetCQState(_CQState.DRY_RUN)
stip@chromium.org43064fd2013-12-18 20:07:44 +00005149
borenet6c0efe62016-10-19 08:13:29 -07005150 for builders in buckets.itervalues():
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00005151 if any('triggered' in b for b in builders):
vapiera7fbd5a2016-06-16 09:17:49 -07005152 print('ERROR You are trying to send a job to a triggered bot. This type '
tandriide281ae2016-10-12 06:02:30 -07005153 'of bot requires an initial job from a parent (usually a builder). '
5154 'Instead send your job to the parent.\n'
vapiera7fbd5a2016-06-16 09:17:49 -07005155 'Bot list: %s' % builders, file=sys.stderr)
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00005156 return 1
ilevy@chromium.orgf3b21232012-09-24 20:48:55 +00005157
ilevy@chromium.org36e420b2013-08-06 23:21:12 +00005158 patchset = cl.GetMostRecentPatchset()
tandrii568043b2016-10-11 07:49:18 -07005159 try:
Andrii Shyshkalovf9648b52018-02-21 22:32:42 -08005160 _trigger_try_jobs(auth_config, cl, buckets, options, patchset)
tandrii568043b2016-10-11 07:49:18 -07005161 except BuildbucketResponseException as ex:
5162 print('ERROR: %s' % ex)
5163 return 1
maruel@chromium.org15192402012-09-06 12:38:29 +00005164 return 0
5165
5166
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005167@metrics.collector.collect_metrics('git cl try-results')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005168def CMDtry_results(parser, args):
Quinten Yearsleyd242ed72019-07-25 17:17:55 +00005169 """Prints info about results for tryjobs associated with the current CL."""
tandrii1838bad2016-10-06 00:10:52 -07005170 group = optparse.OptionGroup(parser, 'Try job results options')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005171 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07005172 '-p', '--patchset', type=int, help='patchset number if not current.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005173 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07005174 '--print-master', action='store_true', help='print master name as well.')
tandrii@chromium.org6cf98c82016-03-15 11:56:00 +00005175 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07005176 '--color', action='store_true', default=setup_color.IS_TTY,
5177 help='force color output, useful when piping output.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005178 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07005179 '--buildbucket-host', default='cr-buildbucket.appspot.com',
5180 help='Host of buildbucket. The default host is %default.')
qyearsley53f48a12016-09-01 10:45:13 -07005181 group.add_option(
Stefan Zager1306bd02017-06-22 19:26:46 -07005182 '--json', help=('Path of JSON output file to write try job results to,'
5183 'or "-" for stdout.'))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005184 parser.add_option_group(group)
5185 auth.add_auth_options(parser)
Stefan Zager27db3f22017-10-10 15:15:01 -07005186 _add_codereview_issue_select_options(parser)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005187 options, args = parser.parse_args(args)
Stefan Zager27db3f22017-10-10 15:15:01 -07005188 _process_codereview_issue_select_options(parser, options)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005189 if args:
5190 parser.error('Unrecognized args: %s' % ' '.join(args))
5191
5192 auth_config = auth.extract_auth_config_from_options(options)
Stefan Zager27db3f22017-10-10 15:15:01 -07005193 cl = Changelist(
5194 issue=options.issue, codereview=options.forced_codereview,
5195 auth_config=auth_config)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005196 if not cl.GetIssue():
Quinten Yearsleyc4202212019-07-22 23:34:40 +00005197 parser.error('Need to upload first.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005198
tandrii221ab252016-10-06 08:12:04 -07005199 patchset = options.patchset
5200 if not patchset:
5201 patchset = cl.GetMostRecentPatchset()
5202 if not patchset:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00005203 parser.error('Code review host doesn\'t know about issue %s. '
tandrii221ab252016-10-06 08:12:04 -07005204 'No access to issue or wrong issue number?\n'
Quinten Yearsleyc4202212019-07-22 23:34:40 +00005205 'Either upload first, or pass --patchset explicitly.' %
tandrii221ab252016-10-06 08:12:04 -07005206 cl.GetIssue())
5207
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005208 try:
tandrii221ab252016-10-06 08:12:04 -07005209 jobs = fetch_try_jobs(auth_config, cl, options.buildbucket_host, patchset)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005210 except BuildbucketResponseException as ex:
vapiera7fbd5a2016-06-16 09:17:49 -07005211 print('Buildbucket error: %s' % ex)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005212 return 1
qyearsley53f48a12016-09-01 10:45:13 -07005213 if options.json:
5214 write_try_results_json(options.json, jobs)
5215 else:
5216 print_try_jobs(options, jobs)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005217 return 0
5218
5219
maruel@chromium.org0633fb42013-08-16 20:06:14 +00005220@subcommand.usage('[new upstream branch]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005221@metrics.collector.collect_metrics('git cl upstream')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005222def CMDupstream(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005223 """Prints or sets the name of the upstream branch, if any."""
dpranke@chromium.org97ae58e2011-03-18 00:29:20 +00005224 _, args = parser.parse_args(args)
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00005225 if len(args) > 1:
maruel@chromium.org27bb3872011-05-30 20:33:19 +00005226 parser.error('Unrecognized args: %s' % ' '.join(args))
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00005227
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005228 cl = Changelist()
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00005229 if args:
5230 # One arg means set upstream branch.
bauerb@chromium.orgc9cf90a2014-04-28 20:32:31 +00005231 branch = cl.GetBranch()
stip7a3dd352016-09-22 17:32:28 -07005232 RunGit(['branch', '--set-upstream-to', args[0], branch])
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00005233 cl = Changelist()
vapiera7fbd5a2016-06-16 09:17:49 -07005234 print('Upstream branch set to %s' % (cl.GetUpstreamBranch(),))
bauerb@chromium.orgc9cf90a2014-04-28 20:32:31 +00005235
5236 # Clear configured merge-base, if there is one.
5237 git_common.remove_merge_base(branch)
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00005238 else:
vapiera7fbd5a2016-06-16 09:17:49 -07005239 print(cl.GetUpstreamBranch())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005240 return 0
5241
5242
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005243@metrics.collector.collect_metrics('git cl web')
thestig@chromium.org00858c82013-12-02 23:08:03 +00005244def CMDweb(parser, args):
5245 """Opens the current CL in the web browser."""
5246 _, args = parser.parse_args(args)
5247 if args:
5248 parser.error('Unrecognized args: %s' % ' '.join(args))
5249
5250 issue_url = Changelist().GetIssueURL()
5251 if not issue_url:
vapiera7fbd5a2016-06-16 09:17:49 -07005252 print('ERROR No issue to open', file=sys.stderr)
thestig@chromium.org00858c82013-12-02 23:08:03 +00005253 return 1
5254
Sergiy Byelozyorov2b718322018-10-24 17:43:31 +00005255 # Redirect I/O before invoking browser to hide its output. For example, this
5256 # allows to hide "Created new window in existing browser session." message
5257 # from Chrome. Based on https://stackoverflow.com/a/2323563.
5258 saved_stdout = os.dup(1)
Sergiy Belozorov06684032019-03-06 16:53:08 +00005259 saved_stderr = os.dup(2)
Sergiy Byelozyorov2b718322018-10-24 17:43:31 +00005260 os.close(1)
Sergiy Belozorov06684032019-03-06 16:53:08 +00005261 os.close(2)
Sergiy Byelozyorov2b718322018-10-24 17:43:31 +00005262 os.open(os.devnull, os.O_RDWR)
5263 try:
5264 webbrowser.open(issue_url)
5265 finally:
5266 os.dup2(saved_stdout, 1)
Sergiy Belozorov06684032019-03-06 16:53:08 +00005267 os.dup2(saved_stderr, 2)
thestig@chromium.org00858c82013-12-02 23:08:03 +00005268 return 0
5269
5270
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005271@metrics.collector.collect_metrics('git cl set-commit')
maruel@chromium.org27bb3872011-05-30 20:33:19 +00005272def CMDset_commit(parser, args):
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00005273 """Sets the commit bit to trigger the CQ."""
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00005274 parser.add_option('-d', '--dry-run', action='store_true',
5275 help='trigger in dry run mode')
5276 parser.add_option('-c', '--clear', action='store_true',
5277 help='stop CQ run, if any')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005278 auth.add_auth_options(parser)
iannuccie53c9352016-08-17 14:40:40 -07005279 _add_codereview_issue_select_options(parser)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005280 options, args = parser.parse_args(args)
iannuccie53c9352016-08-17 14:40:40 -07005281 _process_codereview_issue_select_options(parser, options)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005282 auth_config = auth.extract_auth_config_from_options(options)
maruel@chromium.org27bb3872011-05-30 20:33:19 +00005283 if args:
5284 parser.error('Unrecognized args: %s' % ' '.join(args))
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00005285 if options.dry_run and options.clear:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00005286 parser.error('Only one of --dry-run and --clear are allowed.')
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00005287
iannuccie53c9352016-08-17 14:40:40 -07005288 cl = Changelist(auth_config=auth_config, issue=options.issue,
5289 codereview=options.forced_codereview)
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00005290 if options.clear:
tandriid9e5ce52016-07-13 02:32:59 -07005291 state = _CQState.NONE
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00005292 elif options.dry_run:
5293 state = _CQState.DRY_RUN
5294 else:
5295 state = _CQState.COMMIT
5296 if not cl.GetIssue():
Quinten Yearsleyc4202212019-07-22 23:34:40 +00005297 parser.error('Must upload the issue first.')
tandrii9de9ec62016-07-13 03:01:59 -07005298 cl.SetCQState(state)
maruel@chromium.org27bb3872011-05-30 20:33:19 +00005299 return 0
5300
5301
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005302@metrics.collector.collect_metrics('git cl set-close')
groby@chromium.org411034a2013-02-26 15:12:01 +00005303def CMDset_close(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005304 """Closes the issue."""
iannuccie53c9352016-08-17 14:40:40 -07005305 _add_codereview_issue_select_options(parser)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005306 auth.add_auth_options(parser)
5307 options, args = parser.parse_args(args)
iannuccie53c9352016-08-17 14:40:40 -07005308 _process_codereview_issue_select_options(parser, options)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005309 auth_config = auth.extract_auth_config_from_options(options)
groby@chromium.org411034a2013-02-26 15:12:01 +00005310 if args:
5311 parser.error('Unrecognized args: %s' % ' '.join(args))
iannuccie53c9352016-08-17 14:40:40 -07005312 cl = Changelist(auth_config=auth_config, issue=options.issue,
5313 codereview=options.forced_codereview)
groby@chromium.org411034a2013-02-26 15:12:01 +00005314 # Ensure there actually is an issue to close.
Aaron Gable7139a4e2017-09-05 17:53:09 -07005315 if not cl.GetIssue():
Quinten Yearsleyc4202212019-07-22 23:34:40 +00005316 DieWithError('ERROR: No issue to close.')
groby@chromium.org411034a2013-02-26 15:12:01 +00005317 cl.CloseIssue()
5318 return 0
5319
5320
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005321@metrics.collector.collect_metrics('git cl diff')
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00005322def CMDdiff(parser, args):
wychen@chromium.org37b2ec02015-04-03 00:49:15 +00005323 """Shows differences between local tree and last upload."""
thomasanderson074beb22016-08-29 14:03:20 -07005324 parser.add_option(
5325 '--stat',
5326 action='store_true',
5327 dest='stat',
5328 help='Generate a diffstat')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005329 auth.add_auth_options(parser)
5330 options, args = parser.parse_args(args)
5331 auth_config = auth.extract_auth_config_from_options(options)
5332 if args:
5333 parser.error('Unrecognized args: %s' % ' '.join(args))
wychen@chromium.org46309bf2015-04-03 21:04:49 +00005334
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005335 cl = Changelist(auth_config=auth_config)
sbc@chromium.org78dc9842013-11-25 18:43:44 +00005336 issue = cl.GetIssue()
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00005337 branch = cl.GetBranch()
sbc@chromium.org78dc9842013-11-25 18:43:44 +00005338 if not issue:
5339 DieWithError('No issue found for current branch (%s)' % branch)
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00005340
Aaron Gablea718c3e2017-08-28 17:47:28 -07005341 base = cl._GitGetBranchConfigValue('last-upload-hash')
5342 if not base:
5343 base = cl._GitGetBranchConfigValue('gerritsquashhash')
5344 if not base:
5345 detail = cl._GetChangeDetail(['CURRENT_REVISION', 'CURRENT_COMMIT'])
5346 revision_info = detail['revisions'][detail['current_revision']]
5347 fetch_info = revision_info['fetch']['http']
5348 RunGit(['fetch', fetch_info['url'], fetch_info['ref']])
5349 base = 'FETCH_HEAD'
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00005350
Aaron Gablea718c3e2017-08-28 17:47:28 -07005351 cmd = ['git', 'diff']
5352 if options.stat:
5353 cmd.append('--stat')
5354 cmd.append(base)
5355 subprocess2.check_call(cmd)
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00005356
5357 return 0
5358
5359
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005360@metrics.collector.collect_metrics('git cl owners')
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005361def CMDowners(parser, args):
Dirk Prankebf980882017-09-02 15:08:00 -07005362 """Finds potential owners for reviewing."""
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005363 parser.add_option(
Sidney San Martín8e6f58c2018-06-08 01:02:56 +00005364 '--ignore-current',
5365 action='store_true',
5366 help='Ignore the CL\'s current reviewers and start from scratch.')
5367 parser.add_option(
Sylvain Defresneb1f865d2019-02-12 12:38:22 +00005368 '--ignore-self',
5369 action='store_true',
5370 help='Do not consider CL\'s author as an owners.')
5371 parser.add_option(
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005372 '--no-color',
5373 action='store_true',
5374 help='Use this option to disable color output')
Dirk Prankebf980882017-09-02 15:08:00 -07005375 parser.add_option(
5376 '--batch',
5377 action='store_true',
5378 help='Do not run interactively, just suggest some')
Yang Guo6e269a02019-06-26 11:17:02 +00005379 # TODO: Consider moving this to another command, since other
5380 # git-cl owners commands deal with owners for a given CL.
5381 parser.add_option(
5382 '--show-all',
5383 action='store_true',
5384 help='Show all owners for a particular file')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005385 auth.add_auth_options(parser)
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005386 options, args = parser.parse_args(args)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005387 auth_config = auth.extract_auth_config_from_options(options)
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005388
5389 author = RunGit(['config', 'user.email']).strip() or None
5390
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005391 cl = Changelist(auth_config=auth_config)
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005392
Yang Guo6e269a02019-06-26 11:17:02 +00005393 if options.show_all:
5394 for arg in args:
5395 base_branch = cl.GetCommonAncestorWithUpstream()
5396 change = cl.GetChange(base_branch, None)
5397 database = owners.Database(change.RepositoryRoot(), file, os.path)
5398 database.load_data_needed_for([arg])
5399 print('Owners for %s:' % arg)
5400 for owner in sorted(database.all_possible_owners([arg], None)):
5401 print(' - %s' % owner)
5402 return 0
5403
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005404 if args:
5405 if len(args) > 1:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00005406 parser.error('Unknown args.')
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005407 base_branch = args[0]
5408 else:
5409 # Default to diffing against the common ancestor of the upstream branch.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00005410 base_branch = cl.GetCommonAncestorWithUpstream()
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005411
5412 change = cl.GetChange(base_branch, None)
Dirk Prankebf980882017-09-02 15:08:00 -07005413 affected_files = [f.LocalPath() for f in change.AffectedFiles()]
5414
5415 if options.batch:
5416 db = owners.Database(change.RepositoryRoot(), file, os.path)
5417 print('\n'.join(db.reviewers_for(affected_files, author)))
5418 return 0
5419
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005420 return owners_finder.OwnersFinder(
Dirk Prankebf980882017-09-02 15:08:00 -07005421 affected_files,
Jochen Eisinger72606f82017-04-04 10:44:18 +02005422 change.RepositoryRoot(),
Edward Lemur707d70b2018-02-07 00:50:14 +01005423 author,
Sidney San Martín8e6f58c2018-06-08 01:02:56 +00005424 [] if options.ignore_current else cl.GetReviewers(),
Edward Lemur707d70b2018-02-07 00:50:14 +01005425 fopen=file, os_path=os.path,
Jochen Eisingerd0573ec2017-04-13 10:55:06 +02005426 disable_color=options.no_color,
Sylvain Defresneb1f865d2019-02-12 12:38:22 +00005427 override_files=change.OriginalOwnersFiles(),
5428 ignore_author=options.ignore_self).run()
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005429
5430
Aiden Bennerc08566e2018-10-03 17:52:42 +00005431def BuildGitDiffCmd(diff_type, upstream_commit, args, allow_prefix=False):
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005432 """Generates a diff command."""
5433 # Generate diff for the current branch's changes.
Aiden Bennerc08566e2018-10-03 17:52:42 +00005434 diff_cmd = ['-c', 'core.quotePath=false', 'diff', '--no-ext-diff']
5435
Aiden Benner6c18a1a2018-11-23 20:18:23 +00005436 if allow_prefix:
5437 # explicitly setting --src-prefix and --dst-prefix is necessary in the
5438 # case that diff.noprefix is set in the user's git config.
5439 diff_cmd += ['--src-prefix=a/', '--dst-prefix=b/']
5440 else:
Aiden Bennerc08566e2018-10-03 17:52:42 +00005441 diff_cmd += ['--no-prefix']
5442
5443 diff_cmd += [diff_type, upstream_commit, '--']
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005444
5445 if args:
5446 for arg in args:
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005447 if os.path.isdir(arg) or os.path.isfile(arg):
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005448 diff_cmd.append(arg)
5449 else:
5450 DieWithError('Argument "%s" is not a file or a directory' % arg)
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005451
5452 return diff_cmd
5453
Andrii Shyshkalov18975322017-01-25 16:44:13 +01005454
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005455def MatchingFileType(file_name, extensions):
Quinten Yearsleyd242ed72019-07-25 17:17:55 +00005456 """Returns True if the file name ends with one of the given extensions."""
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005457 return bool([ext for ext in extensions if file_name.lower().endswith(ext)])
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005458
Andrii Shyshkalov18975322017-01-25 16:44:13 +01005459
enne@chromium.org555cfe42014-01-29 18:21:39 +00005460@subcommand.usage('[files or directories to diff]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005461@metrics.collector.collect_metrics('git cl format')
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005462def CMDformat(parser, args):
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00005463 """Runs auto-formatting tools (clang-format etc.) on the diff."""
Christopher Lamc5ba6922017-01-24 11:19:14 +11005464 CLANG_EXTS = ['.cc', '.cpp', '.h', '.m', '.mm', '.proto', '.java']
kylechar58edce22016-06-17 06:07:51 -07005465 GN_EXTS = ['.gn', '.gni', '.typemap']
enne@chromium.org3b7e15c2014-01-21 17:44:47 +00005466 parser.add_option('--full', action='store_true',
5467 help='Reformat the full content of all touched files')
5468 parser.add_option('--dry-run', action='store_true',
5469 help='Don\'t modify any file on disk.')
Aiden Benner99b0ccb2018-11-20 19:53:31 +00005470 parser.add_option(
5471 '--python',
5472 action='store_true',
5473 default=None,
5474 help='Enables python formatting on all python files.')
5475 parser.add_option(
5476 '--no-python',
5477 action='store_true',
5478 dest='python',
5479 help='Disables python formatting on all python files. '
5480 'Takes precedence over --python. '
5481 'If neither --python or --no-python are set, python '
5482 'files that have a .style.yapf file in an ancestor '
5483 'directory will be formatted.')
Christopher Lamc5ba6922017-01-24 11:19:14 +11005484 parser.add_option('--js', action='store_true',
5485 help='Format javascript code with clang-format.')
wittman@chromium.org04d5a222014-03-07 18:30:42 +00005486 parser.add_option('--diff', action='store_true',
5487 help='Print diff to stdout rather than modifying files.')
Ilya Shermane081cbe2017-08-15 17:51:04 -07005488 parser.add_option('--presubmit', action='store_true',
5489 help='Used when running the script from a presubmit.')
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005490 opts, args = parser.parse_args(args)
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005491
Daniel Chengc55eecf2016-12-30 03:11:02 -08005492 # Normalize any remaining args against the current path, so paths relative to
5493 # the current directory are still resolved as expected.
5494 args = [os.path.join(os.getcwd(), arg) for arg in args]
5495
enne@chromium.orgff7a1fb2013-12-10 19:21:41 +00005496 # git diff generates paths against the root of the repository. Change
5497 # to that directory so clang-format can find files even within subdirs.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00005498 rel_base_path = settings.GetRelativeRoot()
enne@chromium.orgff7a1fb2013-12-10 19:21:41 +00005499 if rel_base_path:
5500 os.chdir(rel_base_path)
5501
digit@chromium.org29e47272013-05-17 17:01:46 +00005502 # Grab the merge-base commit, i.e. the upstream commit of the current
5503 # branch when it was created or the last time it was rebased. This is
5504 # to cover the case where the user may have called "git fetch origin",
5505 # moving the origin branch to a newer commit, but hasn't rebased yet.
5506 upstream_commit = None
5507 cl = Changelist()
5508 upstream_branch = cl.GetUpstreamBranch()
5509 if upstream_branch:
5510 upstream_commit = RunGit(['merge-base', 'HEAD', upstream_branch])
5511 upstream_commit = upstream_commit.strip()
5512
5513 if not upstream_commit:
5514 DieWithError('Could not find base commit for this branch. '
5515 'Are you in detached state?')
5516
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005517 changed_files_cmd = BuildGitDiffCmd('--name-only', upstream_commit, args)
5518 diff_output = RunGit(changed_files_cmd)
5519 diff_files = diff_output.splitlines()
jkarlin@chromium.orgad21b922016-01-28 17:48:42 +00005520 # Filter out files deleted by this CL
5521 diff_files = [x for x in diff_files if os.path.isfile(x)]
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005522
Christopher Lamc5ba6922017-01-24 11:19:14 +11005523 if opts.js:
Deepanjan Roy605dd312018-07-02 17:48:54 +00005524 CLANG_EXTS.extend(['.js', '.ts'])
Christopher Lamc5ba6922017-01-24 11:19:14 +11005525
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005526 clang_diff_files = [x for x in diff_files if MatchingFileType(x, CLANG_EXTS)]
5527 python_diff_files = [x for x in diff_files if MatchingFileType(x, ['.py'])]
5528 dart_diff_files = [x for x in diff_files if MatchingFileType(x, ['.dart'])]
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00005529 gn_diff_files = [x for x in diff_files if MatchingFileType(x, GN_EXTS)]
digit@chromium.org29e47272013-05-17 17:01:46 +00005530
nick@chromium.org3ac1c4e2014-01-16 02:44:42 +00005531 top_dir = os.path.normpath(
5532 RunGit(["rev-parse", "--show-toplevel"]).rstrip('\n'))
5533
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005534 # Set to 2 to signal to CheckPatchFormatted() that this patch isn't
5535 # formatted. This is used to block during the presubmit.
5536 return_value = 0
5537
sammc@chromium.org0b35f5d2016-02-25 22:39:23 +00005538 if clang_diff_files:
techtonik@gmail.com5573df12016-04-12 18:34:10 +00005539 # Locate the clang-format binary in the checkout
5540 try:
5541 clang_format_tool = clang_format.FindClangFormatToolInChromiumTree()
vapierfd77ac72016-06-16 08:33:57 -07005542 except clang_format.NotFoundError as e:
techtonik@gmail.com5573df12016-04-12 18:34:10 +00005543 DieWithError(e)
5544
sammc@chromium.org0b35f5d2016-02-25 22:39:23 +00005545 if opts.full:
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005546 cmd = [clang_format_tool]
5547 if not opts.dry_run and not opts.diff:
5548 cmd.append('-i')
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005549 stdout = RunCommand(cmd + clang_diff_files, cwd=top_dir)
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005550 if opts.diff:
5551 sys.stdout.write(stdout)
sammc@chromium.org0b35f5d2016-02-25 22:39:23 +00005552 else:
5553 env = os.environ.copy()
5554 env['PATH'] = str(os.path.dirname(clang_format_tool))
5555 try:
5556 script = clang_format.FindClangFormatScriptInChromiumTree(
5557 'clang-format-diff.py')
vapierfd77ac72016-06-16 08:33:57 -07005558 except clang_format.NotFoundError as e:
sammc@chromium.org0b35f5d2016-02-25 22:39:23 +00005559 DieWithError(e)
digit@chromium.orgd6ddc1c2013-10-25 15:36:32 +00005560
sammc@chromium.org0b35f5d2016-02-25 22:39:23 +00005561 cmd = [sys.executable, script, '-p0']
5562 if not opts.dry_run and not opts.diff:
5563 cmd.append('-i')
digit@chromium.orgd6ddc1c2013-10-25 15:36:32 +00005564
sammc@chromium.org0b35f5d2016-02-25 22:39:23 +00005565 diff_cmd = BuildGitDiffCmd('-U0', upstream_commit, clang_diff_files)
5566 diff_output = RunGit(diff_cmd)
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005567
sammc@chromium.org0b35f5d2016-02-25 22:39:23 +00005568 stdout = RunCommand(cmd, stdin=diff_output, cwd=top_dir, env=env)
5569 if opts.diff:
5570 sys.stdout.write(stdout)
5571 if opts.dry_run and len(stdout) > 0:
5572 return_value = 2
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005573
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00005574 # Similar code to above, but using yapf on .py files rather than clang-format
5575 # on C/C++ files
Aiden Benner99b0ccb2018-11-20 19:53:31 +00005576 py_explicitly_disabled = opts.python is not None and not opts.python
5577 if python_diff_files and not py_explicitly_disabled:
Aiden Bennere47ac152018-11-20 16:44:03 +00005578 depot_tools_path = os.path.dirname(os.path.abspath(__file__))
5579 yapf_tool = os.path.join(depot_tools_path, 'yapf')
5580 if sys.platform.startswith('win'):
5581 yapf_tool += '.bat'
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00005582
Aiden Bennerc08566e2018-10-03 17:52:42 +00005583 # If we couldn't find a yapf file we'll default to the chromium style
5584 # specified in depot_tools.
Aiden Bennerc08566e2018-10-03 17:52:42 +00005585 chromium_default_yapf_style = os.path.join(depot_tools_path,
5586 YAPF_CONFIG_FILENAME)
Aiden Bennerc08566e2018-10-03 17:52:42 +00005587 # Used for caching.
5588 yapf_configs = {}
5589 for f in python_diff_files:
5590 # Find the yapf style config for the current file, defaults to depot
5591 # tools default.
Aiden Benner99b0ccb2018-11-20 19:53:31 +00005592 _FindYapfConfigFile(f, yapf_configs, top_dir)
5593
5594 # Turn on python formatting by default if a yapf config is specified.
5595 # This breaks in the case of this repo though since the specified
5596 # style file is also the global default.
5597 if opts.python is None:
5598 filtered_py_files = []
5599 for f in python_diff_files:
5600 if _FindYapfConfigFile(f, yapf_configs, top_dir) is not None:
5601 filtered_py_files.append(f)
5602 else:
5603 filtered_py_files = python_diff_files
5604
5605 # Note: yapf still seems to fix indentation of the entire file
5606 # even if line ranges are specified.
5607 # See https://github.com/google/yapf/issues/499
5608 if not opts.full and filtered_py_files:
5609 py_line_diffs = _ComputeDiffLineRanges(filtered_py_files, upstream_commit)
5610
5611 for f in filtered_py_files:
5612 yapf_config = _FindYapfConfigFile(f, yapf_configs, top_dir)
5613 if yapf_config is None:
5614 yapf_config = chromium_default_yapf_style
Aiden Bennerc08566e2018-10-03 17:52:42 +00005615
5616 cmd = [yapf_tool, '--style', yapf_config, f]
5617
5618 has_formattable_lines = False
5619 if not opts.full:
5620 # Only run yapf over changed line ranges.
5621 for diff_start, diff_len in py_line_diffs[f]:
5622 diff_end = diff_start + diff_len - 1
5623 # Yapf errors out if diff_end < diff_start but this
5624 # is a valid line range diff for a removal.
5625 if diff_end >= diff_start:
5626 has_formattable_lines = True
5627 cmd += ['-l', '{}-{}'.format(diff_start, diff_end)]
5628 # If all line diffs were removals we have nothing to format.
5629 if not has_formattable_lines:
5630 continue
5631
5632 if opts.diff or opts.dry_run:
5633 cmd += ['--diff']
5634 # Will return non-zero exit code if non-empty diff.
5635 stdout = RunCommand(cmd, error_ok=True, cwd=top_dir)
5636 if opts.diff:
5637 sys.stdout.write(stdout)
5638 elif len(stdout) > 0:
5639 return_value = 2
5640 else:
5641 cmd += ['-i']
5642 RunCommand(cmd, cwd=top_dir)
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00005643
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005644 # Dart's formatter does not have the nice property of only operating on
5645 # modified chunks, so hard code full.
5646 if dart_diff_files:
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005647 try:
5648 command = [dart_format.FindDartFmtToolInChromiumTree()]
5649 if not opts.dry_run and not opts.diff:
5650 command.append('-w')
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005651 command.extend(dart_diff_files)
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005652
ppi@chromium.org6593d932016-03-03 15:41:15 +00005653 stdout = RunCommand(command, cwd=top_dir)
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005654 if opts.dry_run and stdout:
5655 return_value = 2
5656 except dart_format.NotFoundError as e:
vapiera7fbd5a2016-06-16 09:17:49 -07005657 print('Warning: Unable to check Dart code formatting. Dart SDK not '
5658 'found in this checkout. Files in other languages are still '
5659 'formatted.')
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005660
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00005661 # Format GN build files. Always run on full build files for canonical form.
5662 if gn_diff_files:
Andrii Shyshkalov18975322017-01-25 16:44:13 +01005663 cmd = ['gn', 'format']
brettw4b8ed592016-08-05 16:19:12 -07005664 if opts.dry_run or opts.diff:
5665 cmd.append('--dry-run')
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00005666 for gn_diff_file in gn_diff_files:
brettw4b8ed592016-08-05 16:19:12 -07005667 gn_ret = subprocess2.call(cmd + [gn_diff_file],
5668 shell=sys.platform == 'win32',
5669 cwd=top_dir)
5670 if opts.dry_run and gn_ret == 2:
5671 return_value = 2 # Not formatted.
5672 elif opts.diff and gn_ret == 2:
5673 # TODO this should compute and print the actual diff.
5674 print("This change has GN build file diff for " + gn_diff_file)
5675 elif gn_ret != 0:
5676 # For non-dry run cases (and non-2 return values for dry-run), a
5677 # nonzero error code indicates a failure, probably because the file
5678 # doesn't parse.
5679 DieWithError("gn format failed on " + gn_diff_file +
5680 "\nTry running 'gn format' on this file manually.")
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00005681
Ilya Shermane081cbe2017-08-15 17:51:04 -07005682 # Skip the metrics formatting from the global presubmit hook. These files have
5683 # a separate presubmit hook that issues an error if the files need formatting,
5684 # whereas the top-level presubmit script merely issues a warning. Formatting
5685 # these files is somewhat slow, so it's important not to duplicate the work.
5686 if not opts.presubmit:
5687 for xml_dir in GetDirtyMetricsDirs(diff_files):
5688 tool_dir = os.path.join(top_dir, xml_dir)
5689 cmd = [os.path.join(tool_dir, 'pretty_print.py'), '--non-interactive']
5690 if opts.dry_run or opts.diff:
5691 cmd.append('--diff')
Ilya Sherman235b70d2017-08-22 17:46:38 -07005692 stdout = RunCommand(cmd, cwd=top_dir)
Ilya Shermane081cbe2017-08-15 17:51:04 -07005693 if opts.diff:
5694 sys.stdout.write(stdout)
5695 if opts.dry_run and stdout:
5696 return_value = 2 # Not formatted.
Alexei Svitkinef3cac412017-02-06 11:08:50 -05005697
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005698 return return_value
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005699
Steven Holte2e664bf2017-04-21 13:10:47 -07005700def GetDirtyMetricsDirs(diff_files):
5701 xml_diff_files = [x for x in diff_files if MatchingFileType(x, ['.xml'])]
5702 metrics_xml_dirs = [
5703 os.path.join('tools', 'metrics', 'actions'),
5704 os.path.join('tools', 'metrics', 'histograms'),
5705 os.path.join('tools', 'metrics', 'rappor'),
5706 os.path.join('tools', 'metrics', 'ukm')]
5707 for xml_dir in metrics_xml_dirs:
5708 if any(file.startswith(xml_dir) for file in xml_diff_files):
5709 yield xml_dir
5710
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005711
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005712@subcommand.usage('<codereview url or issue id>')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005713@metrics.collector.collect_metrics('git cl checkout')
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005714def CMDcheckout(parser, args):
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00005715 """Checks out a branch associated with a given Rietveld or Gerrit issue."""
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005716 _, args = parser.parse_args(args)
5717
5718 if len(args) != 1:
5719 parser.print_help()
5720 return 1
5721
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00005722 issue_arg = ParseIssueNumberArgument(args[0])
tandrii@chromium.orgde6c9a12016-04-11 15:33:53 +00005723 if not issue_arg.valid:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00005724 parser.error('Invalid issue ID or URL.')
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02005725
tandrii@chromium.orgabd27e52016-04-11 15:43:32 +00005726 target_issue = str(issue_arg.issue)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005727
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00005728 def find_issues(issueprefix):
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00005729 output = RunGit(['config', '--local', '--get-regexp',
5730 r'branch\..*\.%s' % issueprefix],
5731 error_ok=True)
5732 for key, issue in [x.split() for x in output.splitlines()]:
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00005733 if issue == target_issue:
5734 yield re.sub(r'branch\.(.*)\.%s' % issueprefix, r'\1', key)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005735
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00005736 branches = []
5737 for cls in _CODEREVIEW_IMPLEMENTATIONS.values():
tandrii5d48c322016-08-18 16:19:37 -07005738 branches.extend(find_issues(cls.IssueConfigKey()))
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005739 if len(branches) == 0:
vapiera7fbd5a2016-06-16 09:17:49 -07005740 print('No branch found for issue %s.' % target_issue)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005741 return 1
5742 if len(branches) == 1:
5743 RunGit(['checkout', branches[0]])
5744 else:
vapiera7fbd5a2016-06-16 09:17:49 -07005745 print('Multiple branches match issue %s:' % target_issue)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005746 for i in range(len(branches)):
vapiera7fbd5a2016-06-16 09:17:49 -07005747 print('%d: %s' % (i, branches[i]))
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005748 which = raw_input('Choose by index: ')
5749 try:
5750 RunGit(['checkout', branches[int(which)]])
5751 except (IndexError, ValueError):
vapiera7fbd5a2016-06-16 09:17:49 -07005752 print('Invalid selection, not checking out any branch.')
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005753 return 1
5754
5755 return 0
5756
5757
maruel@chromium.org29404b52014-09-08 22:58:00 +00005758def CMDlol(parser, args):
5759 # This command is intentionally undocumented.
vapiera7fbd5a2016-06-16 09:17:49 -07005760 print(zlib.decompress(base64.b64decode(
thakis@chromium.org3421c992014-11-02 02:20:32 +00005761 'eNptkLEOwyAMRHe+wupCIqW57v0Vq84WqWtXyrcXnCBsmgMJ+/SSAxMZgRB6NzE'
5762 'E2ObgCKJooYdu4uAQVffUEoE1sRQLxAcqzd7uK2gmStrll1ucV3uZyaY5sXyDd9'
5763 'JAnN+lAXsOMJ90GANAi43mq5/VeeacylKVgi8o6F1SC63FxnagHfJUTfUYdCR/W'
vapiera7fbd5a2016-06-16 09:17:49 -07005764 'Ofe+0dHL7PicpytKP750Fh1q2qnLVof4w8OZWNY')))
maruel@chromium.org29404b52014-09-08 22:58:00 +00005765 return 0
5766
5767
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005768class OptionParser(optparse.OptionParser):
5769 """Creates the option parse and add --verbose support."""
5770 def __init__(self, *args, **kwargs):
maruel@chromium.org0633fb42013-08-16 20:06:14 +00005771 optparse.OptionParser.__init__(
5772 self, *args, prog='git cl', version=__version__, **kwargs)
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005773 self.add_option(
5774 '-v', '--verbose', action='count', default=0,
5775 help='Use 2 times for more debugging info')
5776
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005777 def parse_args(self, args=None, _values=None):
Andrii Shyshkalov46f20cd2018-10-30 06:42:54 +00005778 try:
5779 return self._parse_args(args)
5780 finally:
5781 # Regardless of success or failure of args parsing, we want to report
5782 # metrics, but only after logging has been initialized (if parsing
5783 # succeeded).
5784 global settings
5785 settings = Settings()
5786
5787 if not metrics.DISABLE_METRICS_COLLECTION:
5788 # GetViewVCUrl ultimately calls logging method.
5789 project_url = settings.GetViewVCUrl().strip('/+')
5790 if project_url in metrics_utils.KNOWN_PROJECT_URLS:
5791 metrics.collector.add('project_urls', [project_url])
5792
5793 def _parse_args(self, args=None):
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005794 # Create an optparse.Values object that will store only the actual passed
5795 # options, without the defaults.
5796 actual_options = optparse.Values()
5797 _, args = optparse.OptionParser.parse_args(self, args, actual_options)
5798 # Create an optparse.Values object with the default options.
5799 options = optparse.Values(self.get_default_values().__dict__)
5800 # Update it with the options passed by the user.
5801 options._update_careful(actual_options.__dict__)
5802 # Store the options passed by the user in an _actual_options attribute.
5803 # We store only the keys, and not the values, since the values can contain
5804 # arbitrary information, which might be PII.
5805 metrics.collector.add('arguments', actual_options.__dict__.keys())
5806
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005807 levels = [logging.WARNING, logging.INFO, logging.DEBUG]
Andrii Shyshkalov5b04a572017-01-23 17:44:41 +01005808 logging.basicConfig(
5809 level=levels[min(options.verbose, len(levels) - 1)],
5810 format='[%(levelname).1s%(asctime)s %(process)d %(thread)d '
5811 '%(filename)s] %(message)s')
Edward Lemur83bd7f42018-10-10 00:14:21 +00005812
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005813 return options, args
5814
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005815
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005816def main(argv):
maruel@chromium.org82798cb2012-02-23 18:16:12 +00005817 if sys.hexversion < 0x02060000:
vapiera7fbd5a2016-06-16 09:17:49 -07005818 print('\nYour python version %s is unsupported, please upgrade.\n' %
5819 (sys.version.split(' ', 1)[0],), file=sys.stderr)
maruel@chromium.org82798cb2012-02-23 18:16:12 +00005820 return 2
maruel@chromium.org2e23ce32013-05-07 12:42:28 +00005821
maruel@chromium.org39c0b222013-08-17 16:57:01 +00005822 colorize_CMDstatus_doc()
maruel@chromium.org0633fb42013-08-16 20:06:14 +00005823 dispatcher = subcommand.CommandDispatcher(__name__)
5824 try:
5825 return dispatcher.execute(OptionParser(), argv)
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +00005826 except auth.AuthenticationError as e:
5827 DieWithError(str(e))
vapierfd77ac72016-06-16 08:33:57 -07005828 except urllib2.HTTPError as e:
maruel@chromium.org0633fb42013-08-16 20:06:14 +00005829 if e.code != 500:
5830 raise
5831 DieWithError(
5832 ('AppEngine is misbehaving and returned HTTP %d, again. Keep faith '
Quinten Yearsleyc4202212019-07-22 23:34:40 +00005833 'and retry or visit go/isgaeup.\n%s') % (e.code, str(e)))
sbc@chromium.org013731e2015-02-26 18:28:43 +00005834 return 0
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005835
5836
5837if __name__ == '__main__':
maruel@chromium.org2e23ce32013-05-07 12:42:28 +00005838 # These affect sys.stdout so do it outside of main() to simplify mocks in
5839 # unit testing.
maruel@chromium.org6f09cd92011-04-01 16:38:12 +00005840 fix_encoding.fix_encoding()
iannucci@chromium.org596cd5c2016-04-04 21:34:39 +00005841 setup_color.init()
Edward Lemur6f812e12018-07-31 22:45:57 +00005842 with metrics.collector.print_notice_and_exit():
sbc@chromium.org013731e2015-02-26 18:28:43 +00005843 sys.exit(main(sys.argv[1:]))