blob: d56b3b689236e7413a344322839f7bb0c45fdbd6 [file] [log] [blame]
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001/*
kjellander1afca732016-02-07 20:46:45 -08002 * Copyright (c) 2004 The WebRTC project authors. All Rights Reserved.
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003 *
kjellander1afca732016-02-07 20:46:45 -08004 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00009 */
10
11#include <map>
kwiberg686a8ef2016-02-26 03:00:35 -080012#include <memory>
Steve Antone78bcb92017-10-31 09:53:08 -070013#include <utility>
pbos@webrtc.org86f613d2014-06-10 08:53:05 +000014#include <vector>
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000015
Steve Anton2c9ebef2019-01-28 17:27:58 -080016#include "absl/algorithm/container.h"
Niels Möller805a27e2019-01-21 12:21:27 +010017#include "absl/memory/memory.h"
Niels Möller039743e2018-10-23 10:07:25 +020018#include "absl/strings/match.h"
Steve Anton10542f22019-01-11 09:11:00 -080019#include "api/rtp_parameters.h"
Piotr (Peter) Slatala946b9682019-03-18 10:25:02 -070020#include "api/test/fake_media_transport.h"
Jiawei Ouc2ebe212018-11-08 10:02:56 -080021#include "api/test/mock_video_bitrate_allocator.h"
22#include "api/test/mock_video_bitrate_allocator_factory.h"
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -070023#include "api/test/mock_video_decoder_factory.h"
24#include "api/test/mock_video_encoder_factory.h"
Jonas Oreland49ac5952018-09-26 16:04:32 +020025#include "api/units/time_delta.h"
Jiawei Ouc2ebe212018-11-08 10:02:56 -080026#include "api/video/builtin_video_bitrate_allocator_factory.h"
Niels Möller805a27e2019-01-21 12:21:27 +010027#include "api/video/i420_buffer.h"
Åsa Persson23eba222018-10-02 14:47:06 +020028#include "api/video/video_bitrate_allocation.h"
Anders Carlsson5f2bb622018-05-14 09:48:06 +020029#include "api/video_codecs/builtin_video_decoder_factory.h"
30#include "api/video_codecs/builtin_video_encoder_factory.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020031#include "api/video_codecs/sdp_video_format.h"
32#include "api/video_codecs/video_decoder_factory.h"
33#include "api/video_codecs/video_encoder.h"
34#include "api/video_codecs/video_encoder_factory.h"
35#include "call/flexfec_receive_stream.h"
36#include "common_video/h264/profile_level_id.h"
37#include "logging/rtc_event_log/rtc_event_log.h"
Niels Möller805a27e2019-01-21 12:21:27 +010038#include "media/base/fake_frame_source.h"
Steve Anton10542f22019-01-11 09:11:00 -080039#include "media/base/fake_network_interface.h"
Steve Anton10542f22019-01-11 09:11:00 -080040#include "media/base/fake_video_renderer.h"
41#include "media/base/media_constants.h"
42#include "media/base/rtp_utils.h"
43#include "media/base/test_utils.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020044#include "media/engine/constants.h"
Steve Anton10542f22019-01-11 09:11:00 -080045#include "media/engine/fake_webrtc_call.h"
46#include "media/engine/fake_webrtc_video_engine.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020047#include "media/engine/simulcast.h"
Steve Anton10542f22019-01-11 09:11:00 -080048#include "media/engine/webrtc_video_engine.h"
49#include "media/engine/webrtc_voice_engine.h"
Åsa Persson23cd45a2018-07-03 10:40:40 +020050#include "modules/rtp_rtcp/include/rtp_header_parser.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020051#include "rtc_base/arraysize.h"
Steve Anton10542f22019-01-11 09:11:00 -080052#include "rtc_base/fake_clock.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020053#include "rtc_base/gunit.h"
Yves Gerey665174f2018-06-19 15:03:05 +020054#include "rtc_base/numerics/safe_conversions.h"
Steve Antonf3802842019-01-24 19:07:40 -080055#include "rtc_base/time_utils.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020056#include "test/field_trial.h"
Niels Möllerd0f0f682019-01-14 09:09:53 +010057#include "test/frame_generator.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020058#include "test/gmock.h"
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000059
Niels Möller805a27e2019-01-21 12:21:27 +010060using testing::Field;
Sebastian Jansson8f83b422018-02-21 13:07:13 +010061using webrtc::BitrateConstraints;
isheriff6f8d6862016-05-26 11:24:55 -070062using webrtc::RtpExtension;
63
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000064namespace {
buildbot@webrtc.orga8530772014-12-10 09:01:18 +000065static const int kDefaultQpMax = 56;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +000066
noahricd10a68e2015-07-10 11:27:55 -070067static const uint8_t kRedRtxPayloadType = 125;
68
Niels Möller6557d0c2018-04-11 15:18:34 +020069static const uint32_t kTimeout = 5000U;
70static const uint32_t kDefaultReceiveSsrc = 0;
71static const uint32_t kSsrc = 1234u;
72static const uint32_t kSsrcs4[] = {1, 2, 3, 4};
73static const int kVideoWidth = 640;
74static const int kVideoHeight = 360;
75static const int kFramerate = 30;
76
Peter Boström0c4e06b2015-10-07 12:23:21 +020077static const uint32_t kSsrcs1[] = {1};
78static const uint32_t kSsrcs3[] = {1, 2, 3};
79static const uint32_t kRtxSsrcs1[] = {4};
brandtr468da7c2016-11-22 02:16:47 -080080static const uint32_t kFlexfecSsrc = 5;
Peter Boström0c4e06b2015-10-07 12:23:21 +020081static const uint32_t kIncomingUnsignalledSsrc = 0xC0FFEE;
mzanaty8a855d62017-02-17 15:46:43 -080082static const uint32_t kDefaultRecvSsrc = 0;
83
pbos@webrtc.org3c107582014-07-20 15:27:35 +000084static const char kUnsupportedExtensionName[] =
85 "urn:ietf:params:rtp-hdrext:unsupported";
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000086
magjed509e4fe2016-11-18 01:34:11 -080087cricket::VideoCodec RemoveFeedbackParams(cricket::VideoCodec&& codec) {
88 codec.feedback_params = cricket::FeedbackParams();
Mirko Bonadei29a8d102018-04-25 23:58:26 +020089 return std::move(codec);
magjed509e4fe2016-11-18 01:34:11 -080090}
91
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000092void VerifyCodecHasDefaultFeedbackParams(const cricket::VideoCodec& codec) {
93 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
94 cricket::kRtcpFbParamNack, cricket::kParamValueEmpty)));
95 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
96 cricket::kRtcpFbParamNack, cricket::kRtcpFbNackParamPli)));
97 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
98 cricket::kRtcpFbParamRemb, cricket::kParamValueEmpty)));
99 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
stefan43edf0f2015-11-20 18:05:48 -0800100 cricket::kRtcpFbParamTransportCc, cricket::kParamValueEmpty)));
101 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +0000102 cricket::kRtcpFbParamCcm, cricket::kRtcpFbCcmParamFir)));
103}
104
magjed725e4842016-11-16 00:48:13 -0800105// Return true if any codec in |codecs| is an RTX codec with associated payload
106// type |payload_type|.
107bool HasRtxCodec(const std::vector<cricket::VideoCodec>& codecs,
108 int payload_type) {
109 for (const cricket::VideoCodec& codec : codecs) {
110 int associated_payload_type;
Niels Möller039743e2018-10-23 10:07:25 +0200111 if (absl::EqualsIgnoreCase(codec.name.c_str(), "rtx") &&
magjed725e4842016-11-16 00:48:13 -0800112 codec.GetParam(cricket::kCodecParamAssociatedPayloadType,
113 &associated_payload_type) &&
114 associated_payload_type == payload_type) {
115 return true;
116 }
117 }
118 return false;
119}
120
nisseca5706d2017-09-11 02:32:16 -0700121// TODO(nisse): Duplicated in call.cc.
122const int* FindKeyByValue(const std::map<int, int>& m, int v) {
123 for (const auto& kv : m) {
124 if (kv.second == v)
125 return &kv.first;
126 }
127 return nullptr;
128}
129
Yves Gerey665174f2018-06-19 15:03:05 +0200130bool HasRtxReceiveAssociation(const webrtc::VideoReceiveStream::Config& config,
131 int payload_type) {
nisseca5706d2017-09-11 02:32:16 -0700132 return FindKeyByValue(config.rtp.rtx_associated_payload_types,
133 payload_type) != nullptr;
134}
135
136// Check that there's an Rtx payload type for each decoder.
137bool VerifyRtxReceiveAssociations(
138 const webrtc::VideoReceiveStream::Config& config) {
139 for (const auto& decoder : config.decoders) {
140 if (!HasRtxReceiveAssociation(config, decoder.payload_type))
141 return false;
142 }
143 return true;
144}
145
brandtrffc61182016-11-28 06:02:22 -0800146rtc::scoped_refptr<webrtc::VideoFrameBuffer> CreateBlackFrameBuffer(
nisse64ec8f82016-09-27 00:17:25 -0700147 int width,
148 int height) {
149 rtc::scoped_refptr<webrtc::I420Buffer> buffer =
150 webrtc::I420Buffer::Create(width, height);
nisseaf916892017-01-10 07:44:26 -0800151 webrtc::I420Buffer::SetBlack(buffer);
nisse64ec8f82016-09-27 00:17:25 -0700152 return buffer;
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +0000153}
154
Shao Changbine62202f2015-04-21 20:24:50 +0800155void VerifySendStreamHasRtxTypes(const webrtc::VideoSendStream::Config& config,
156 const std::map<int, int>& rtx_types) {
157 std::map<int, int>::const_iterator it;
Niels Möller259a4972018-04-05 15:36:51 +0200158 it = rtx_types.find(config.rtp.payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800159 EXPECT_TRUE(it != rtx_types.end() &&
160 it->second == config.rtp.rtx.payload_type);
161
brandtrb5f2c3f2016-10-04 23:28:39 -0700162 if (config.rtp.ulpfec.red_rtx_payload_type != -1) {
163 it = rtx_types.find(config.rtp.ulpfec.red_payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800164 EXPECT_TRUE(it != rtx_types.end() &&
brandtrb5f2c3f2016-10-04 23:28:39 -0700165 it->second == config.rtp.ulpfec.red_rtx_payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800166 }
167}
kthelgason2bc68642017-02-07 07:02:22 -0800168
169cricket::MediaConfig GetMediaConfig() {
170 cricket::MediaConfig media_config;
Niels Möller1d7ecd22018-01-18 15:25:12 +0100171 media_config.video.enable_cpu_adaptation = false;
kthelgason2bc68642017-02-07 07:02:22 -0800172 return media_config;
173}
nisse26e3abb2017-08-25 04:44:25 -0700174
Åsa Perssonbdee46d2018-06-25 11:28:06 +0200175// Values from GetMaxDefaultVideoBitrateKbps in webrtcvideoengine.cc.
176int GetMaxDefaultBitrateBps(size_t width, size_t height) {
177 if (width * height <= 320 * 240) {
178 return 600000;
179 } else if (width * height <= 640 * 480) {
180 return 1700000;
181 } else if (width * height <= 960 * 540) {
182 return 2000000;
183 } else {
184 return 2500000;
185 }
186}
187
Niels Möller731a2c22018-07-30 15:08:07 +0200188class MockVideoSource : public rtc::VideoSourceInterface<webrtc::VideoFrame> {
189 public:
190 MOCK_METHOD2(AddOrUpdateSink,
191 void(rtc::VideoSinkInterface<webrtc::VideoFrame>* sink,
192 const rtc::VideoSinkWants& wants));
193 MOCK_METHOD1(RemoveSink,
194 void(rtc::VideoSinkInterface<webrtc::VideoFrame>* sink));
195};
196
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000197} // namespace
198
Yves Gerey665174f2018-06-19 15:03:05 +0200199#define EXPECT_FRAME_WAIT(c, w, h, t) \
Niels Möller6557d0c2018-04-11 15:18:34 +0200200 EXPECT_EQ_WAIT((c), renderer_.num_rendered_frames(), (t)); \
Yves Gerey665174f2018-06-19 15:03:05 +0200201 EXPECT_EQ((w), renderer_.width()); \
202 EXPECT_EQ((h), renderer_.height()); \
Niels Möller6557d0c2018-04-11 15:18:34 +0200203 EXPECT_EQ(0, renderer_.errors());
204
Yves Gerey665174f2018-06-19 15:03:05 +0200205#define EXPECT_FRAME_ON_RENDERER_WAIT(r, c, w, h, t) \
Niels Möller6557d0c2018-04-11 15:18:34 +0200206 EXPECT_EQ_WAIT((c), (r).num_rendered_frames(), (t)); \
Yves Gerey665174f2018-06-19 15:03:05 +0200207 EXPECT_EQ((w), (r).width()); \
208 EXPECT_EQ((h), (r).height()); \
Niels Möller6557d0c2018-04-11 15:18:34 +0200209 EXPECT_EQ(0, (r).errors());
210
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000211namespace cricket {
eladalonf1841382017-06-12 01:16:46 -0700212class WebRtcVideoEngineTest : public ::testing::Test {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000213 public:
eladalonf1841382017-06-12 01:16:46 -0700214 WebRtcVideoEngineTest() : WebRtcVideoEngineTest("") {}
215 explicit WebRtcVideoEngineTest(const char* field_trials)
stefanc1aeaf02015-10-15 07:26:07 -0700216 : override_field_trials_(field_trials),
skvlad11a9cbf2016-10-07 11:53:05 -0700217 call_(webrtc::Call::Create(webrtc::Call::Config(&event_log_))),
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200218 encoder_factory_(new cricket::FakeWebRtcVideoEncoderFactory),
219 decoder_factory_(new cricket::FakeWebRtcVideoDecoderFactory),
Anders Carlsson67537952018-05-03 11:28:29 +0200220 engine_(std::unique_ptr<cricket::FakeWebRtcVideoEncoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200221 encoder_factory_),
Anders Carlsson67537952018-05-03 11:28:29 +0200222 std::unique_ptr<cricket::FakeWebRtcVideoDecoderFactory>(
Jiawei Ouc2ebe212018-11-08 10:02:56 -0800223 decoder_factory_),
224 webrtc::CreateBuiltinVideoBitrateAllocatorFactory()) {
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +0200225 // Ensure fake clock doesn't return 0, which will cause some initializations
226 // fail inside RTP senders.
227 fake_clock_.AdvanceTimeMicros(1);
228 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000229
230 protected:
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200231 void AssignDefaultAptRtxTypes();
232 void AssignDefaultCodec();
233
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100234 // Find the index of the codec in the engine with the given name. The codec
235 // must be present.
Oleh Prypina40f8242017-12-21 13:32:23 +0100236 size_t GetEngineCodecIndex(const std::string& name) const;
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100237
magjed509e4fe2016-11-18 01:34:11 -0800238 // Find the codec in the engine with the given name. The codec must be
239 // present.
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100240 cricket::VideoCodec GetEngineCodec(const std::string& name) const;
magjed509e4fe2016-11-18 01:34:11 -0800241
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200242 VideoMediaChannel* SetSendParamsWithAllSupportedCodecs();
pbos@webrtc.orgfa553ef2014-10-20 11:07:07 +0000243
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200244 VideoMediaChannel* SetRecvParamsWithSupportedCodecs(
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000245 const std::vector<VideoCodec>& codecs);
246
Elad Alon157540a2019-02-08 23:37:52 +0100247 void ExpectRtpCapabilitySupport(const char* uri, bool supported) const;
Peter Boströme4499152016-02-05 11:13:28 +0100248
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +0200249 // Has to be the first one, so it is initialized before the call or there is a
250 // race condition in the clock access.
251 rtc::ScopedFakeClock fake_clock_;
stefanc1aeaf02015-10-15 07:26:07 -0700252 webrtc::test::ScopedFieldTrials override_field_trials_;
skvlad11a9cbf2016-10-07 11:53:05 -0700253 webrtc::RtcEventLogNullImpl event_log_;
eladalonf1841382017-06-12 01:16:46 -0700254 // Used in WebRtcVideoEngineVoiceTest, but defined here so it's properly
pbos@webrtc.orgf1f0d9a2015-03-02 13:30:15 +0000255 // initialized when the constructor is called.
kwiberg686a8ef2016-02-26 03:00:35 -0800256 std::unique_ptr<webrtc::Call> call_;
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200257 cricket::FakeWebRtcVideoEncoderFactory* encoder_factory_;
258 cricket::FakeWebRtcVideoDecoderFactory* decoder_factory_;
eladalonf1841382017-06-12 01:16:46 -0700259 WebRtcVideoEngine engine_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000260 VideoCodec default_codec_;
Shao Changbine62202f2015-04-21 20:24:50 +0800261 std::map<int, int> default_apt_rtx_types_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000262};
263
eladalonf1841382017-06-12 01:16:46 -0700264TEST_F(WebRtcVideoEngineTest, DefaultRtxCodecHasAssociatedPayloadTypeSet) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200265 encoder_factory_->AddSupportedVideoCodecType("VP8");
266 AssignDefaultCodec();
267
pbos@webrtc.orge322a172014-06-13 11:47:28 +0000268 std::vector<VideoCodec> engine_codecs = engine_.codecs();
269 for (size_t i = 0; i < engine_codecs.size(); ++i) {
270 if (engine_codecs[i].name != kRtxCodecName)
271 continue;
272 int associated_payload_type;
273 EXPECT_TRUE(engine_codecs[i].GetParam(kCodecParamAssociatedPayloadType,
pbos@webrtc.org42684be2014-10-03 11:25:45 +0000274 &associated_payload_type));
pbos@webrtc.orge322a172014-06-13 11:47:28 +0000275 EXPECT_EQ(default_codec_.id, associated_payload_type);
276 return;
277 }
278 FAIL() << "No RTX codec found among default codecs.";
279}
280
eladalonf1841382017-06-12 01:16:46 -0700281TEST_F(WebRtcVideoEngineTest, SupportsTimestampOffsetHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100282 ExpectRtpCapabilitySupport(RtpExtension::kTimestampOffsetUri, true);
pbos@webrtc.org587ef602014-06-16 17:32:02 +0000283}
284
eladalonf1841382017-06-12 01:16:46 -0700285TEST_F(WebRtcVideoEngineTest, SupportsAbsoluteSenderTimeHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100286 ExpectRtpCapabilitySupport(RtpExtension::kAbsSendTimeUri, true);
pbos@webrtc.org587ef602014-06-16 17:32:02 +0000287}
288
eladalonf1841382017-06-12 01:16:46 -0700289TEST_F(WebRtcVideoEngineTest, SupportsTransportSequenceNumberHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100290 ExpectRtpCapabilitySupport(RtpExtension::kTransportSequenceNumberUri, true);
stefanc1aeaf02015-10-15 07:26:07 -0700291}
292
eladalonf1841382017-06-12 01:16:46 -0700293TEST_F(WebRtcVideoEngineTest, SupportsVideoRotationHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100294 ExpectRtpCapabilitySupport(RtpExtension::kVideoRotationUri, true);
295}
296
297TEST_F(WebRtcVideoEngineTest, SupportsPlayoutDelayHeaderExtension) {
298 ExpectRtpCapabilitySupport(RtpExtension::kPlayoutDelayUri, true);
299}
300
301TEST_F(WebRtcVideoEngineTest, SupportsVideoContentTypeHeaderExtension) {
302 ExpectRtpCapabilitySupport(RtpExtension::kVideoContentTypeUri, true);
303}
304
305TEST_F(WebRtcVideoEngineTest, SupportsVideoTimingHeaderExtension) {
306 ExpectRtpCapabilitySupport(RtpExtension::kVideoTimingUri, true);
307}
308
309TEST_F(WebRtcVideoEngineTest, SupportsFrameMarkingHeaderExtension) {
310 ExpectRtpCapabilitySupport(RtpExtension::kFrameMarkingUri, true);
Johannes Krond0b69a82018-12-03 14:18:53 +0100311}
312
313TEST_F(WebRtcVideoEngineTest, SupportsColorSpaceHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100314 ExpectRtpCapabilitySupport(RtpExtension::kColorSpaceUri, true);
315}
316
Elad Alonccb9b752019-02-19 13:01:31 +0100317TEST_F(WebRtcVideoEngineTest, AdvertiseGenericDescriptor00) {
318 ExpectRtpCapabilitySupport(RtpExtension::kGenericFrameDescriptorUri00, false);
319}
320
321TEST_F(WebRtcVideoEngineTest, AdvertiseGenericDescriptor01) {
322 ExpectRtpCapabilitySupport(RtpExtension::kGenericFrameDescriptorUri01, false);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700323}
324
philipel1e054862018-10-08 16:13:53 +0200325class WebRtcVideoEngineTestWithGenericDescriptor
326 : public WebRtcVideoEngineTest {
327 public:
328 WebRtcVideoEngineTestWithGenericDescriptor()
329 : WebRtcVideoEngineTest("WebRTC-GenericDescriptorAdvertised/Enabled/") {}
330};
331
Elad Alonccb9b752019-02-19 13:01:31 +0100332TEST_F(WebRtcVideoEngineTestWithGenericDescriptor,
333 AdvertiseGenericDescriptor00) {
334 ExpectRtpCapabilitySupport(RtpExtension::kGenericFrameDescriptorUri00, true);
335}
336
337TEST_F(WebRtcVideoEngineTestWithGenericDescriptor,
338 AdvertiseGenericDescriptor01) {
339 ExpectRtpCapabilitySupport(RtpExtension::kGenericFrameDescriptorUri01, true);
philipel1e054862018-10-08 16:13:53 +0200340}
341
eladalonf1841382017-06-12 01:16:46 -0700342TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionBeforeCapturer) {
Niels Möller731a2c22018-07-30 15:08:07 +0200343 // Allocate the source first to prevent early destruction before channel's
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700344 // dtor is called.
Niels Möller731a2c22018-07-30 15:08:07 +0200345 testing::NiceMock<MockVideoSource> video_source;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700346
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200347 encoder_factory_->AddSupportedVideoCodecType("VP8");
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700348
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200349 std::unique_ptr<VideoMediaChannel> channel(
350 SetSendParamsWithAllSupportedCodecs());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700351 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
352
353 // Add CVO extension.
354 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800355 cricket::VideoSendParameters parameters;
356 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200357 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700358 RtpExtension(RtpExtension::kVideoRotationUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200359 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700360
Niels Möller731a2c22018-07-30 15:08:07 +0200361 EXPECT_CALL(
362 video_source,
363 AddOrUpdateSink(testing::_,
364 Field(&rtc::VideoSinkWants::rotation_applied, false)));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700365 // Set capturer.
Niels Möller731a2c22018-07-30 15:08:07 +0200366 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700367
368 // Verify capturer has turned off applying rotation.
Niels Möller731a2c22018-07-30 15:08:07 +0200369 testing::Mock::VerifyAndClear(&video_source);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700370
371 // Verify removing header extension turns on applying rotation.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200372 parameters.extensions.clear();
Niels Möller731a2c22018-07-30 15:08:07 +0200373 EXPECT_CALL(
374 video_source,
375 AddOrUpdateSink(testing::_,
376 Field(&rtc::VideoSinkWants::rotation_applied, true)));
377
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200378 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700379}
380
eladalonf1841382017-06-12 01:16:46 -0700381TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionBeforeAddSendStream) {
Niels Möller731a2c22018-07-30 15:08:07 +0200382 // Allocate the source first to prevent early destruction before channel's
perkj91e1c152016-03-02 05:34:00 -0800383 // dtor is called.
Niels Möller731a2c22018-07-30 15:08:07 +0200384 testing::NiceMock<MockVideoSource> video_source;
perkj91e1c152016-03-02 05:34:00 -0800385
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200386 encoder_factory_->AddSupportedVideoCodecType("VP8");
perkj91e1c152016-03-02 05:34:00 -0800387
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200388 std::unique_ptr<VideoMediaChannel> channel(
389 SetSendParamsWithAllSupportedCodecs());
perkj91e1c152016-03-02 05:34:00 -0800390 // Add CVO extension.
391 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800392 cricket::VideoSendParameters parameters;
393 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkj91e1c152016-03-02 05:34:00 -0800394 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700395 RtpExtension(RtpExtension::kVideoRotationUri, id));
perkj91e1c152016-03-02 05:34:00 -0800396 EXPECT_TRUE(channel->SetSendParameters(parameters));
397 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
398
Niels Möller731a2c22018-07-30 15:08:07 +0200399 // Set source.
400 EXPECT_CALL(
401 video_source,
402 AddOrUpdateSink(testing::_,
403 Field(&rtc::VideoSinkWants::rotation_applied, false)));
404 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
perkj91e1c152016-03-02 05:34:00 -0800405}
406
eladalonf1841382017-06-12 01:16:46 -0700407TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionAfterCapturer) {
Niels Möller731a2c22018-07-30 15:08:07 +0200408 testing::NiceMock<MockVideoSource> video_source;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700409
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200410 encoder_factory_->AddSupportedVideoCodecType("VP8");
411 encoder_factory_->AddSupportedVideoCodecType("VP9");
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700412
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200413 std::unique_ptr<VideoMediaChannel> channel(
414 SetSendParamsWithAllSupportedCodecs());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700415 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
416
417 // Set capturer.
Niels Möller731a2c22018-07-30 15:08:07 +0200418 EXPECT_CALL(
419 video_source,
420 AddOrUpdateSink(testing::_,
421 Field(&rtc::VideoSinkWants::rotation_applied, true)));
422 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700423
perkjcaafdba2016-03-20 07:34:29 -0700424 // Verify capturer has turned on applying rotation.
Niels Möller731a2c22018-07-30 15:08:07 +0200425 testing::Mock::VerifyAndClear(&video_source);
perkjcaafdba2016-03-20 07:34:29 -0700426
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700427 // Add CVO extension.
428 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800429 cricket::VideoSendParameters parameters;
430 parameters.codecs.push_back(GetEngineCodec("VP8"));
431 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200432 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700433 RtpExtension(RtpExtension::kVideoRotationUri, id));
perkjcaafdba2016-03-20 07:34:29 -0700434 // Also remove the first codec to trigger a codec change as well.
435 parameters.codecs.erase(parameters.codecs.begin());
Niels Möller731a2c22018-07-30 15:08:07 +0200436 EXPECT_CALL(
437 video_source,
438 AddOrUpdateSink(testing::_,
439 Field(&rtc::VideoSinkWants::rotation_applied, false)));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200440 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700441
442 // Verify capturer has turned off applying rotation.
Niels Möller731a2c22018-07-30 15:08:07 +0200443 testing::Mock::VerifyAndClear(&video_source);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700444
445 // Verify removing header extension turns on applying rotation.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200446 parameters.extensions.clear();
Niels Möller731a2c22018-07-30 15:08:07 +0200447 EXPECT_CALL(
448 video_source,
449 AddOrUpdateSink(testing::_,
450 Field(&rtc::VideoSinkWants::rotation_applied, true)));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200451 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700452}
453
eladalonf1841382017-06-12 01:16:46 -0700454TEST_F(WebRtcVideoEngineTest, SetSendFailsBeforeSettingCodecs) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200455 encoder_factory_->AddSupportedVideoCodecType("VP8");
456
Sebastian Jansson84848f22018-11-16 10:40:36 +0100457 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700458 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
pbos@webrtc.org5301b0f2014-07-17 08:51:46 +0000459
460 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(123)));
461
462 EXPECT_FALSE(channel->SetSend(true))
463 << "Channel should not start without codecs.";
464 EXPECT_TRUE(channel->SetSend(false))
465 << "Channel should be stoppable even without set codecs.";
466}
467
eladalonf1841382017-06-12 01:16:46 -0700468TEST_F(WebRtcVideoEngineTest, GetStatsWithoutSendCodecsSetDoesNotCrash) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200469 encoder_factory_->AddSupportedVideoCodecType("VP8");
470
Sebastian Jansson84848f22018-11-16 10:40:36 +0100471 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700472 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
pbos@webrtc.orgc3d2bd22014-08-12 20:55:10 +0000473 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(123)));
474 VideoMediaInfo info;
475 channel->GetStats(&info);
476}
477
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200478TEST_F(WebRtcVideoEngineTest, UseFactoryForVp8WhenSupported) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200479 encoder_factory_->AddSupportedVideoCodecType("VP8");
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000480
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200481 std::unique_ptr<VideoMediaChannel> channel(
482 SetSendParamsWithAllSupportedCodecs());
Sergey Ulanove2b15012016-11-22 16:08:30 -0800483 channel->OnReadyToSend(true);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000484
485 EXPECT_TRUE(
486 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200487 EXPECT_EQ(0, encoder_factory_->GetNumCreatedEncoders());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000488 EXPECT_TRUE(channel->SetSend(true));
Niels Möllerd0f0f682019-01-14 09:09:53 +0100489 webrtc::test::FrameForwarder frame_forwarder;
490 cricket::FakeFrameSource frame_source(1280, 720,
491 rtc::kNumMicrosecsPerSec / 30);
492 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
493 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Per21d45d22016-10-30 21:37:57 +0100494 // Sending one frame will have allocate the encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200495 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
496 EXPECT_TRUE_WAIT(encoder_factory_->encoders()[0]->GetNumEncodedFrames() > 0,
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000497 kTimeout);
498
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200499 int num_created_encoders = encoder_factory_->GetNumCreatedEncoders();
Per21d45d22016-10-30 21:37:57 +0100500 EXPECT_EQ(num_created_encoders, 1);
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000501
502 // Setting codecs of the same type should not reallocate any encoders
503 // (expecting a no-op).
magjed509e4fe2016-11-18 01:34:11 -0800504 cricket::VideoSendParameters parameters;
505 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200506 EXPECT_TRUE(channel->SetSendParameters(parameters));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200507 EXPECT_EQ(num_created_encoders, encoder_factory_->GetNumCreatedEncoders());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000508
509 // Remove stream previously added to free the external encoder instance.
510 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200511 EXPECT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000512}
513
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200514// Test that when an encoder factory supports H264, we add an RTX
515// codec for it.
516// TODO(deadbeef): This test should be updated if/when we start
517// adding RTX codecs for unrecognized codec names.
518TEST_F(WebRtcVideoEngineTest, RtxCodecAddedForH264Codec) {
magjed725e4842016-11-16 00:48:13 -0800519 using webrtc::H264::ProfileLevelIdToString;
520 using webrtc::H264::ProfileLevelId;
521 using webrtc::H264::kLevel1;
Anders Carlsson67537952018-05-03 11:28:29 +0200522 webrtc::SdpVideoFormat h264_constrained_baseline("H264");
523 h264_constrained_baseline.parameters[kH264FmtpProfileLevelId] =
magjed725e4842016-11-16 00:48:13 -0800524 *ProfileLevelIdToString(
525 ProfileLevelId(webrtc::H264::kProfileConstrainedBaseline, kLevel1));
Anders Carlsson67537952018-05-03 11:28:29 +0200526 webrtc::SdpVideoFormat h264_constrained_high("H264");
527 h264_constrained_high.parameters[kH264FmtpProfileLevelId] =
magjed725e4842016-11-16 00:48:13 -0800528 *ProfileLevelIdToString(
529 ProfileLevelId(webrtc::H264::kProfileConstrainedHigh, kLevel1));
Anders Carlsson67537952018-05-03 11:28:29 +0200530 webrtc::SdpVideoFormat h264_high("H264");
531 h264_high.parameters[kH264FmtpProfileLevelId] = *ProfileLevelIdToString(
magjed725e4842016-11-16 00:48:13 -0800532 ProfileLevelId(webrtc::H264::kProfileHigh, kLevel1));
533
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200534 encoder_factory_->AddSupportedVideoCodec(h264_constrained_baseline);
535 encoder_factory_->AddSupportedVideoCodec(h264_constrained_high);
536 encoder_factory_->AddSupportedVideoCodec(h264_high);
Taylor Brandstetter6c3e7882016-06-29 11:14:19 -0700537
magjed725e4842016-11-16 00:48:13 -0800538 // First figure out what payload types the test codecs got assigned.
539 const std::vector<cricket::VideoCodec> codecs = engine_.codecs();
magjed509e4fe2016-11-18 01:34:11 -0800540 // Now search for RTX codecs for them. Expect that they all have associated
541 // RTX codecs.
magjed725e4842016-11-16 00:48:13 -0800542 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200543 codecs,
544 FindMatchingCodec(codecs, cricket::VideoCodec(h264_constrained_baseline))
545 ->id));
magjed725e4842016-11-16 00:48:13 -0800546 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200547 codecs,
548 FindMatchingCodec(codecs, cricket::VideoCodec(h264_constrained_high))
549 ->id));
magjed509e4fe2016-11-18 01:34:11 -0800550 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200551 codecs, FindMatchingCodec(codecs, cricket::VideoCodec(h264_high))->id));
Taylor Brandstetter6c3e7882016-06-29 11:14:19 -0700552}
553
Mirko Bonadei8ef57932018-11-16 14:38:03 +0100554#if defined(RTC_ENABLE_VP9)
eladalonf1841382017-06-12 01:16:46 -0700555TEST_F(WebRtcVideoEngineTest, CanConstructDecoderForVp9EncoderFactory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200556 encoder_factory_->AddSupportedVideoCodecType("VP9");
Peter Boström53eda3d2015-03-27 15:53:18 +0100557
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200558 std::unique_ptr<VideoMediaChannel> channel(
559 SetSendParamsWithAllSupportedCodecs());
Peter Boström53eda3d2015-03-27 15:53:18 +0100560
561 EXPECT_TRUE(
562 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
563}
Mirko Bonadei8ef57932018-11-16 14:38:03 +0100564#endif // defined(RTC_ENABLE_VP9)
Peter Boström53eda3d2015-03-27 15:53:18 +0100565
eladalonf1841382017-06-12 01:16:46 -0700566TEST_F(WebRtcVideoEngineTest, PropagatesInputFrameTimestamp) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200567 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson8f83b422018-02-21 13:07:13 +0100568 FakeCall* fake_call = new FakeCall();
Fredrik Solenberg709ed672015-09-15 12:26:33 +0200569 call_.reset(fake_call);
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200570 std::unique_ptr<VideoMediaChannel> channel(
571 SetSendParamsWithAllSupportedCodecs());
qiangchenc27d89f2015-07-16 10:27:16 -0700572
573 EXPECT_TRUE(
574 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
575
Niels Möllerd0f0f682019-01-14 09:09:53 +0100576 webrtc::test::FrameForwarder frame_forwarder;
577 cricket::FakeFrameSource frame_source(1280, 720,
578 rtc::kNumMicrosecsPerSec / 60);
579 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
qiangchenc27d89f2015-07-16 10:27:16 -0700580 channel->SetSend(true);
581
Fredrik Solenberg709ed672015-09-15 12:26:33 +0200582 FakeVideoSendStream* stream = fake_call->GetVideoSendStreams()[0];
qiangchenc27d89f2015-07-16 10:27:16 -0700583
Niels Möllerd0f0f682019-01-14 09:09:53 +0100584 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos1cb121d2015-09-14 11:38:38 -0700585 int64_t last_timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700586 for (int i = 0; i < 10; i++) {
Niels Möllerd0f0f682019-01-14 09:09:53 +0100587 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos1cb121d2015-09-14 11:38:38 -0700588 int64_t timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700589 int64_t interval = timestamp - last_timestamp;
590
591 // Precision changes from nanosecond to millisecond.
592 // Allow error to be no more than 1.
593 EXPECT_NEAR(cricket::VideoFormat::FpsToInterval(60) / 1E6, interval, 1);
594
595 last_timestamp = timestamp;
596 }
597
Niels Möllerd0f0f682019-01-14 09:09:53 +0100598 frame_forwarder.IncomingCapturedFrame(
599 frame_source.GetFrame(1280, 720, webrtc::VideoRotation::kVideoRotation_0,
600 rtc::kNumMicrosecsPerSec / 30));
qiangchenc27d89f2015-07-16 10:27:16 -0700601 last_timestamp = stream->GetLastTimestamp();
602 for (int i = 0; i < 10; i++) {
Niels Möllerd0f0f682019-01-14 09:09:53 +0100603 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame(
604 1280, 720, webrtc::VideoRotation::kVideoRotation_0,
605 rtc::kNumMicrosecsPerSec / 30));
pbos1cb121d2015-09-14 11:38:38 -0700606 int64_t timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700607 int64_t interval = timestamp - last_timestamp;
608
609 // Precision changes from nanosecond to millisecond.
610 // Allow error to be no more than 1.
611 EXPECT_NEAR(cricket::VideoFormat::FpsToInterval(30) / 1E6, interval, 1);
612
613 last_timestamp = timestamp;
614 }
615
616 // Remove stream previously added to free the external encoder instance.
617 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
618}
619
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200620void WebRtcVideoEngineTest::AssignDefaultAptRtxTypes() {
621 std::vector<VideoCodec> engine_codecs = engine_.codecs();
622 RTC_DCHECK(!engine_codecs.empty());
623 for (const cricket::VideoCodec& codec : engine_codecs) {
624 if (codec.name == "rtx") {
625 int associated_payload_type;
626 if (codec.GetParam(kCodecParamAssociatedPayloadType,
627 &associated_payload_type)) {
628 default_apt_rtx_types_[associated_payload_type] = codec.id;
629 }
630 }
631 }
632}
633
634void WebRtcVideoEngineTest::AssignDefaultCodec() {
635 std::vector<VideoCodec> engine_codecs = engine_.codecs();
636 RTC_DCHECK(!engine_codecs.empty());
637 bool codec_set = false;
638 for (const cricket::VideoCodec& codec : engine_codecs) {
639 if (!codec_set && codec.name != "rtx" && codec.name != "red" &&
640 codec.name != "ulpfec") {
641 default_codec_ = codec;
642 codec_set = true;
643 }
644 }
645
646 RTC_DCHECK(codec_set);
647}
648
Oleh Prypina40f8242017-12-21 13:32:23 +0100649size_t WebRtcVideoEngineTest::GetEngineCodecIndex(
650 const std::string& name) const {
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100651 const std::vector<cricket::VideoCodec> codecs = engine_.codecs();
652 for (size_t i = 0; i < codecs.size(); ++i) {
653 const cricket::VideoCodec engine_codec = codecs[i];
Niels Möller039743e2018-10-23 10:07:25 +0200654 if (!absl::EqualsIgnoreCase(name, engine_codec.name))
Magnus Jedvert8deb8182017-10-05 13:13:32 +0200655 continue;
656 // The tests only use H264 Constrained Baseline. Make sure we don't return
657 // an internal H264 codec from the engine with a different H264 profile.
Niels Möller039743e2018-10-23 10:07:25 +0200658 if (absl::EqualsIgnoreCase(name.c_str(), kH264CodecName)) {
Danil Chapovalov00c71832018-06-15 15:58:38 +0200659 const absl::optional<webrtc::H264::ProfileLevelId> profile_level_id =
Magnus Jedvert8deb8182017-10-05 13:13:32 +0200660 webrtc::H264::ParseSdpProfileLevelId(engine_codec.params);
661 if (profile_level_id->profile !=
662 webrtc::H264::kProfileConstrainedBaseline) {
663 continue;
664 }
665 }
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100666 return i;
magjed509e4fe2016-11-18 01:34:11 -0800667 }
668 // This point should never be reached.
669 ADD_FAILURE() << "Unrecognized codec name: " << name;
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100670 return -1;
671}
672
673cricket::VideoCodec WebRtcVideoEngineTest::GetEngineCodec(
674 const std::string& name) const {
675 return engine_.codecs()[GetEngineCodecIndex(name)];
magjed509e4fe2016-11-18 01:34:11 -0800676}
677
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200678VideoMediaChannel*
679WebRtcVideoEngineTest::SetSendParamsWithAllSupportedCodecs() {
Sebastian Jansson84848f22018-11-16 10:40:36 +0100680 VideoMediaChannel* channel = engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700681 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions());
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200682 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -0800683 // We need to look up the codec in the engine to get the correct payload type.
Anders Carlsson67537952018-05-03 11:28:29 +0200684 for (const webrtc::SdpVideoFormat& format :
685 encoder_factory_->GetSupportedFormats()) {
686 cricket::VideoCodec engine_codec = GetEngineCodec(format.name);
Steve Anton2c9ebef2019-01-28 17:27:58 -0800687 if (!absl::c_linear_search(parameters.codecs, engine_codec)) {
Anders Carlsson67537952018-05-03 11:28:29 +0200688 parameters.codecs.push_back(engine_codec);
689 }
690 }
magjed509e4fe2016-11-18 01:34:11 -0800691
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200692 EXPECT_TRUE(channel->SetSendParameters(parameters));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000693
694 return channel;
695}
696
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200697VideoMediaChannel* WebRtcVideoEngineTest::SetRecvParamsWithSupportedCodecs(
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000698 const std::vector<VideoCodec>& codecs) {
Sebastian Jansson84848f22018-11-16 10:40:36 +0100699 VideoMediaChannel* channel = engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700700 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions());
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200701 cricket::VideoRecvParameters parameters;
702 parameters.codecs = codecs;
703 EXPECT_TRUE(channel->SetRecvParameters(parameters));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000704
705 return channel;
706}
707
Elad Alon157540a2019-02-08 23:37:52 +0100708void WebRtcVideoEngineTest::ExpectRtpCapabilitySupport(const char* uri,
709 bool supported) const {
710 const RtpCapabilities capabilities = engine_.GetCapabilities();
711 if (supported) {
712 EXPECT_THAT(capabilities.header_extensions,
713 testing::Contains(testing::Field(&RtpExtension::uri, uri)));
714 } else {
715 EXPECT_THAT(
716 capabilities.header_extensions,
717 testing::Each(testing::Field(&RtpExtension::uri, testing::StrNe(uri))));
718 }
719}
720
eladalonf1841382017-06-12 01:16:46 -0700721TEST_F(WebRtcVideoEngineTest, UsesSimulcastAdapterForVp8Factories) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200722 encoder_factory_->AddSupportedVideoCodecType("VP8");
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000723
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200724 std::unique_ptr<VideoMediaChannel> channel(
725 SetSendParamsWithAllSupportedCodecs());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000726
Peter Boström0c4e06b2015-10-07 12:23:21 +0200727 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000728
Yves Gerey665174f2018-06-19 15:03:05 +0200729 EXPECT_TRUE(channel->AddSendStream(CreateSimStreamParams("cname", ssrcs)));
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000730 EXPECT_TRUE(channel->SetSend(true));
731
Niels Möller805a27e2019-01-21 12:21:27 +0100732 webrtc::test::FrameForwarder frame_forwarder;
733 cricket::FakeFrameSource frame_source(1280, 720,
734 rtc::kNumMicrosecsPerSec / 60);
735 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, &frame_forwarder));
736 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000737
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200738 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000739
740 // Verify that encoders are configured for simulcast through adapter
741 // (increasing resolution and only configured to send one stream each).
742 int prev_width = -1;
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200743 for (size_t i = 0; i < encoder_factory_->encoders().size(); ++i) {
744 ASSERT_TRUE(encoder_factory_->encoders()[i]->WaitForInitEncode());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000745 webrtc::VideoCodec codec_settings =
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200746 encoder_factory_->encoders()[i]->GetCodecSettings();
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000747 EXPECT_EQ(0, codec_settings.numberOfSimulcastStreams);
748 EXPECT_GT(codec_settings.width, prev_width);
749 prev_width = codec_settings.width;
750 }
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000751
Niels Möllerff40b142018-04-09 08:49:14 +0200752 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, nullptr));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000753
754 channel.reset();
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200755 ASSERT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000756}
757
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200758TEST_F(WebRtcVideoEngineTest, ChannelWithH264CanChangeToVp8) {
759 encoder_factory_->AddSupportedVideoCodecType("VP8");
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200760 encoder_factory_->AddSupportedVideoCodecType("H264");
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000761
Niels Möllerd0f0f682019-01-14 09:09:53 +0100762 // Frame source.
763 webrtc::test::FrameForwarder frame_forwarder;
764 cricket::FakeFrameSource frame_source(1280, 720,
765 rtc::kNumMicrosecsPerSec / 30);
Niels Möller4db138e2018-04-19 09:04:13 +0200766
Sebastian Jansson84848f22018-11-16 10:40:36 +0100767 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700768 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
Anders Carlsson67537952018-05-03 11:28:29 +0200769 cricket::VideoSendParameters parameters;
770 parameters.codecs.push_back(GetEngineCodec("H264"));
771 EXPECT_TRUE(channel->SetSendParameters(parameters));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000772
773 EXPECT_TRUE(
774 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möllerd0f0f682019-01-14 09:09:53 +0100775 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
Niels Möller4db138e2018-04-19 09:04:13 +0200776 // Sending one frame will have allocate the encoder.
Niels Möllerd0f0f682019-01-14 09:09:53 +0100777 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller4db138e2018-04-19 09:04:13 +0200778
779 ASSERT_EQ_WAIT(1u, encoder_factory_->encoders().size(), kTimeout);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000780
Anders Carlsson67537952018-05-03 11:28:29 +0200781 cricket::VideoSendParameters new_parameters;
782 new_parameters.codecs.push_back(GetEngineCodec("VP8"));
783 EXPECT_TRUE(channel->SetSendParameters(new_parameters));
Niels Möller4db138e2018-04-19 09:04:13 +0200784
785 // Sending one frame will switch encoder.
Niels Möllerd0f0f682019-01-14 09:09:53 +0100786 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller4db138e2018-04-19 09:04:13 +0200787
Anders Carlsson8a150d92018-05-14 12:40:04 +0200788 EXPECT_EQ_WAIT(1u, encoder_factory_->encoders().size(), kTimeout);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000789}
790
eladalonf1841382017-06-12 01:16:46 -0700791TEST_F(WebRtcVideoEngineTest,
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000792 UsesSimulcastAdapterForVp8WithCombinedVP8AndH264Factory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200793 encoder_factory_->AddSupportedVideoCodecType("VP8");
794 encoder_factory_->AddSupportedVideoCodecType("H264");
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000795
Sebastian Jansson84848f22018-11-16 10:40:36 +0100796 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700797 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
magjed509e4fe2016-11-18 01:34:11 -0800798 cricket::VideoSendParameters parameters;
799 parameters.codecs.push_back(GetEngineCodec("VP8"));
800 EXPECT_TRUE(channel->SetSendParameters(parameters));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000801
Peter Boström0c4e06b2015-10-07 12:23:21 +0200802 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000803
Yves Gerey665174f2018-06-19 15:03:05 +0200804 EXPECT_TRUE(channel->AddSendStream(CreateSimStreamParams("cname", ssrcs)));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000805 EXPECT_TRUE(channel->SetSend(true));
806
807 // Send a fake frame, or else the media engine will configure the simulcast
808 // encoder adapter at a low-enough size that it'll only create a single
809 // encoder layer.
Niels Möller805a27e2019-01-21 12:21:27 +0100810 webrtc::test::FrameForwarder frame_forwarder;
811 cricket::FakeFrameSource frame_source(1280, 720,
812 rtc::kNumMicrosecsPerSec / 30);
813 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, &frame_forwarder));
814 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000815
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200816 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
817 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000818 EXPECT_EQ(webrtc::kVideoCodecVP8,
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200819 encoder_factory_->encoders()[0]->GetCodecSettings().codecType);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000820
821 channel.reset();
822 // Make sure DestroyVideoEncoder was called on the factory.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200823 EXPECT_EQ(0u, encoder_factory_->encoders().size());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000824}
825
eladalonf1841382017-06-12 01:16:46 -0700826TEST_F(WebRtcVideoEngineTest,
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000827 DestroysNonSimulcastEncoderFromCombinedVP8AndH264Factory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200828 encoder_factory_->AddSupportedVideoCodecType("VP8");
829 encoder_factory_->AddSupportedVideoCodecType("H264");
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000830
Sebastian Jansson84848f22018-11-16 10:40:36 +0100831 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700832 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
magjed509e4fe2016-11-18 01:34:11 -0800833 cricket::VideoSendParameters parameters;
834 parameters.codecs.push_back(GetEngineCodec("H264"));
835 EXPECT_TRUE(channel->SetSendParameters(parameters));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000836
837 EXPECT_TRUE(
838 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Per21d45d22016-10-30 21:37:57 +0100839
840 // Send a frame of 720p. This should trigger a "real" encoder initialization.
Niels Möller805a27e2019-01-21 12:21:27 +0100841 webrtc::test::FrameForwarder frame_forwarder;
842 cricket::FakeFrameSource frame_source(1280, 720,
843 rtc::kNumMicrosecsPerSec / 30);
844 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
845 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller4db138e2018-04-19 09:04:13 +0200846 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
847 ASSERT_EQ(1u, encoder_factory_->encoders().size());
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200848 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000849 EXPECT_EQ(webrtc::kVideoCodecH264,
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200850 encoder_factory_->encoders()[0]->GetCodecSettings().codecType);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000851
852 channel.reset();
853 // Make sure DestroyVideoEncoder was called on the factory.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200854 ASSERT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000855}
856
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200857TEST_F(WebRtcVideoEngineTest, SimulcastEnabledForH264BehindFieldTrial) {
858 webrtc::test::ScopedFieldTrials override_field_trials_(
859 "WebRTC-H264Simulcast/Enabled/");
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200860 encoder_factory_->AddSupportedVideoCodecType("H264");
noahricfdac5162015-08-27 01:59:29 -0700861
Sebastian Jansson84848f22018-11-16 10:40:36 +0100862 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700863 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
Anders Carlsson67537952018-05-03 11:28:29 +0200864 cricket::VideoSendParameters parameters;
865 parameters.codecs.push_back(GetEngineCodec("H264"));
866 EXPECT_TRUE(channel->SetSendParameters(parameters));
noahricfdac5162015-08-27 01:59:29 -0700867
Peter Boström0c4e06b2015-10-07 12:23:21 +0200868 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
noahricfdac5162015-08-27 01:59:29 -0700869 EXPECT_TRUE(
870 channel->AddSendStream(cricket::CreateSimStreamParams("cname", ssrcs)));
Peter Boströmce23bee2016-02-02 14:14:30 +0100871
872 // Send a frame of 720p. This should trigger a "real" encoder initialization.
Niels Möller805a27e2019-01-21 12:21:27 +0100873 webrtc::test::FrameForwarder frame_forwarder;
874 cricket::FakeFrameSource frame_source(1280, 720,
875 rtc::kNumMicrosecsPerSec / 30);
876 EXPECT_TRUE(channel->SetVideoSend(ssrcs[0], nullptr, &frame_forwarder));
877 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Peter Boströmce23bee2016-02-02 14:14:30 +0100878
Niels Möller4db138e2018-04-19 09:04:13 +0200879 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200880 ASSERT_EQ(1u, encoder_factory_->encoders().size());
881 FakeWebRtcVideoEncoder* encoder = encoder_factory_->encoders()[0];
882 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
noahricfdac5162015-08-27 01:59:29 -0700883 EXPECT_EQ(webrtc::kVideoCodecH264, encoder->GetCodecSettings().codecType);
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200884 EXPECT_LT(1u, encoder->GetCodecSettings().numberOfSimulcastStreams);
Niels Möllerff40b142018-04-09 08:49:14 +0200885 EXPECT_TRUE(channel->SetVideoSend(ssrcs[0], nullptr, nullptr));
noahricfdac5162015-08-27 01:59:29 -0700886}
887
brandtrffc61182016-11-28 06:02:22 -0800888// Test that the FlexFEC field trial properly alters the output of
eladalonf1841382017-06-12 01:16:46 -0700889// WebRtcVideoEngine::codecs(), for an existing |engine_| object.
brandtrffc61182016-11-28 06:02:22 -0800890//
891// TODO(brandtr): Remove this test, when the FlexFEC field trial is gone.
eladalonf1841382017-06-12 01:16:46 -0700892TEST_F(WebRtcVideoEngineTest,
brandtrffc61182016-11-28 06:02:22 -0800893 Flexfec03SupportedAsInternalCodecBehindFieldTrial) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200894 encoder_factory_->AddSupportedVideoCodecType("VP8");
895
Steve Anton2c9ebef2019-01-28 17:27:58 -0800896 auto flexfec = Field("name", &VideoCodec::name, "flexfec-03");
brandtrffc61182016-11-28 06:02:22 -0800897
898 // FlexFEC is not active without field trial.
Steve Anton2c9ebef2019-01-28 17:27:58 -0800899 EXPECT_THAT(engine_.codecs(), Not(Contains(flexfec)));
brandtrffc61182016-11-28 06:02:22 -0800900
901 // FlexFEC is active with field trial.
902 webrtc::test::ScopedFieldTrials override_field_trials_(
brandtr340e3fd2017-02-28 15:43:10 -0800903 "WebRTC-FlexFEC-03-Advertised/Enabled/");
Steve Anton2c9ebef2019-01-28 17:27:58 -0800904 EXPECT_THAT(engine_.codecs(), Contains(flexfec));
brandtrffc61182016-11-28 06:02:22 -0800905}
906
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200907// Test that codecs are added in the order they are reported from the factory.
908TEST_F(WebRtcVideoEngineTest, ReportSupportedCodecs) {
909 encoder_factory_->AddSupportedVideoCodecType("VP8");
910 const char* kFakeCodecName = "FakeCodec";
911 encoder_factory_->AddSupportedVideoCodecType(kFakeCodecName);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000912
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200913 // The last reported codec should appear after the first codec in the vector.
Oleh Prypina40f8242017-12-21 13:32:23 +0100914 const size_t vp8_index = GetEngineCodecIndex("VP8");
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200915 const size_t fake_codec_index = GetEngineCodecIndex(kFakeCodecName);
916 EXPECT_LT(vp8_index, fake_codec_index);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000917}
918
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200919// Test that a codec that was added after the engine was initialized
brandtrffc61182016-11-28 06:02:22 -0800920// does show up in the codec list after it was added.
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200921TEST_F(WebRtcVideoEngineTest, ReportSupportedAddedCodec) {
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100922 const char* kFakeExternalCodecName1 = "FakeExternalCodec1";
923 const char* kFakeExternalCodecName2 = "FakeExternalCodec2";
Magnus Jedvert154ee1f2017-11-15 19:27:11 +0100924
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100925 // Set up external encoder factory with first codec, and initialize engine.
926 encoder_factory_->AddSupportedVideoCodecType(kFakeExternalCodecName1);
927
brandtrffc61182016-11-28 06:02:22 -0800928 std::vector<cricket::VideoCodec> codecs_before(engine_.codecs());
brandtrffc61182016-11-28 06:02:22 -0800929
930 // Add second codec.
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100931 encoder_factory_->AddSupportedVideoCodecType(kFakeExternalCodecName2);
brandtrffc61182016-11-28 06:02:22 -0800932 std::vector<cricket::VideoCodec> codecs_after(engine_.codecs());
Sami Kalliomäkie9a18b22018-07-13 10:28:21 +0200933 // The codec itself and RTX should have been added.
934 EXPECT_EQ(codecs_before.size() + 2, codecs_after.size());
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100935
936 // Check that both fake codecs are present and that the second fake codec
937 // appears after the first fake codec.
Oleh Prypina40f8242017-12-21 13:32:23 +0100938 const size_t fake_codec_index1 = GetEngineCodecIndex(kFakeExternalCodecName1);
939 const size_t fake_codec_index2 = GetEngineCodecIndex(kFakeExternalCodecName2);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100940 EXPECT_LT(fake_codec_index1, fake_codec_index2);
brandtrffc61182016-11-28 06:02:22 -0800941}
942
Sami Kalliomäkie9a18b22018-07-13 10:28:21 +0200943TEST_F(WebRtcVideoEngineTest, ReportRtxForExternalCodec) {
944 const char* kFakeCodecName = "FakeCodec";
945 encoder_factory_->AddSupportedVideoCodecType(kFakeCodecName);
946
947 const size_t fake_codec_index = GetEngineCodecIndex(kFakeCodecName);
948 EXPECT_EQ("rtx", engine_.codecs().at(fake_codec_index + 1).name);
949}
950
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200951TEST_F(WebRtcVideoEngineTest, RegisterDecodersIfSupported) {
952 encoder_factory_->AddSupportedVideoCodecType("VP8");
Anders Carlsson67537952018-05-03 11:28:29 +0200953 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200954 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -0800955 parameters.codecs.push_back(GetEngineCodec("VP8"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000956
kwiberg686a8ef2016-02-26 03:00:35 -0800957 std::unique_ptr<VideoMediaChannel> channel(
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200958 SetRecvParamsWithSupportedCodecs(parameters.codecs));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000959
960 EXPECT_TRUE(
961 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200962 ASSERT_EQ(1u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000963
964 // Setting codecs of the same type should not reallocate the decoder.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200965 EXPECT_TRUE(channel->SetRecvParameters(parameters));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200966 EXPECT_EQ(1, decoder_factory_->GetNumCreatedDecoders());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000967
968 // Remove stream previously added to free the external decoder instance.
969 EXPECT_TRUE(channel->RemoveRecvStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200970 EXPECT_EQ(0u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000971}
972
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200973// Verifies that we can set up decoders.
974TEST_F(WebRtcVideoEngineTest, RegisterH264DecoderIfSupported) {
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000975 // TODO(pbos): Do not assume that encoder/decoder support is symmetric. We
976 // can't even query the WebRtcVideoDecoderFactory for supported codecs.
977 // For now we add a FakeWebRtcVideoEncoderFactory to add H264 to supported
978 // codecs.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200979 encoder_factory_->AddSupportedVideoCodecType("H264");
Anders Carlsson67537952018-05-03 11:28:29 +0200980 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("H264"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000981 std::vector<cricket::VideoCodec> codecs;
magjed509e4fe2016-11-18 01:34:11 -0800982 codecs.push_back(GetEngineCodec("H264"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000983
kwiberg686a8ef2016-02-26 03:00:35 -0800984 std::unique_ptr<VideoMediaChannel> channel(
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200985 SetRecvParamsWithSupportedCodecs(codecs));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000986
987 EXPECT_TRUE(
988 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200989 ASSERT_EQ(1u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000990}
991
Jonas Oreland49ac5952018-09-26 16:04:32 +0200992// Tests when GetSources is called with non-existing ssrc, it will return an
993// empty list of RtpSource without crashing.
994TEST_F(WebRtcVideoEngineTest, GetSourcesWithNonExistingSsrc) {
995 // Setup an recv stream with |kSsrc|.
996 encoder_factory_->AddSupportedVideoCodecType("VP8");
997 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("VP8"));
998 cricket::VideoRecvParameters parameters;
999 parameters.codecs.push_back(GetEngineCodec("VP8"));
1000 std::unique_ptr<VideoMediaChannel> channel(
1001 SetRecvParamsWithSupportedCodecs(parameters.codecs));
1002
1003 EXPECT_TRUE(
1004 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
1005
1006 // Call GetSources with |kSsrc + 1| which doesn't exist.
1007 std::vector<webrtc::RtpSource> sources = channel->GetSources(kSsrc + 1);
1008 EXPECT_EQ(0u, sources.size());
1009}
1010
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001011TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, NullFactories) {
1012 std::unique_ptr<webrtc::VideoEncoderFactory> encoder_factory;
1013 std::unique_ptr<webrtc::VideoDecoderFactory> decoder_factory;
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001014 std::unique_ptr<webrtc::VideoBitrateAllocatorFactory> rate_allocator_factory;
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001015 WebRtcVideoEngine engine(std::move(encoder_factory),
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001016 std::move(decoder_factory),
1017 std::move(rate_allocator_factory));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001018 EXPECT_EQ(0u, engine.codecs().size());
1019}
1020
1021TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, EmptyFactories) {
1022 // |engine| take ownership of the factories.
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -07001023 webrtc::MockVideoEncoderFactory* encoder_factory =
1024 new webrtc::MockVideoEncoderFactory();
1025 webrtc::MockVideoDecoderFactory* decoder_factory =
1026 new webrtc::MockVideoDecoderFactory();
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001027 webrtc::MockVideoBitrateAllocatorFactory* rate_allocator_factory =
1028 new webrtc::MockVideoBitrateAllocatorFactory();
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001029 WebRtcVideoEngine engine(
1030 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001031 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)),
1032 (std::unique_ptr<webrtc::VideoBitrateAllocatorFactory>(
1033 rate_allocator_factory)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001034 EXPECT_CALL(*encoder_factory, GetSupportedFormats());
1035 EXPECT_EQ(0u, engine.codecs().size());
1036 EXPECT_CALL(*encoder_factory, Die());
1037 EXPECT_CALL(*decoder_factory, Die());
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001038 EXPECT_CALL(*rate_allocator_factory, Die());
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001039}
1040
1041// Test full behavior in the video engine when video codec factories of the new
1042// type are injected supporting the single codec Vp8. Check the returned codecs
1043// from the engine and that we will create a Vp8 encoder and decoder using the
1044// new factories.
1045TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, Vp8) {
1046 // |engine| take ownership of the factories.
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -07001047 webrtc::MockVideoEncoderFactory* encoder_factory =
1048 new webrtc::MockVideoEncoderFactory();
1049 webrtc::MockVideoDecoderFactory* decoder_factory =
1050 new webrtc::MockVideoDecoderFactory();
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001051 webrtc::MockVideoBitrateAllocatorFactory* rate_allocator_factory =
1052 new webrtc::MockVideoBitrateAllocatorFactory();
1053 EXPECT_CALL(*rate_allocator_factory,
1054 CreateVideoBitrateAllocatorProxy(Field(
1055 &webrtc::VideoCodec::codecType, webrtc::kVideoCodecVP8)))
1056 .WillOnce(testing::Return(new webrtc::MockVideoBitrateAllocator()));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001057 WebRtcVideoEngine engine(
1058 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001059 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)),
1060 (std::unique_ptr<webrtc::VideoBitrateAllocatorFactory>(
1061 rate_allocator_factory)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001062 const webrtc::SdpVideoFormat vp8_format("VP8");
1063 const std::vector<webrtc::SdpVideoFormat> supported_formats = {vp8_format};
1064 EXPECT_CALL(*encoder_factory, GetSupportedFormats())
1065 .WillRepeatedly(testing::Return(supported_formats));
1066
1067 // Verify the codecs from the engine.
1068 const std::vector<VideoCodec> engine_codecs = engine.codecs();
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001069 // Verify default codecs has been added correctly.
1070 EXPECT_EQ(5u, engine_codecs.size());
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001071 EXPECT_EQ("VP8", engine_codecs.at(0).name);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001072
1073 // RTX codec for VP8.
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001074 EXPECT_EQ("rtx", engine_codecs.at(1).name);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001075 int vp8_associated_payload;
1076 EXPECT_TRUE(engine_codecs.at(1).GetParam(kCodecParamAssociatedPayloadType,
1077 &vp8_associated_payload));
1078 EXPECT_EQ(vp8_associated_payload, engine_codecs.at(0).id);
1079
1080 EXPECT_EQ(kRedCodecName, engine_codecs.at(2).name);
1081
1082 // RTX codec for RED.
1083 EXPECT_EQ("rtx", engine_codecs.at(3).name);
1084 int red_associated_payload;
1085 EXPECT_TRUE(engine_codecs.at(3).GetParam(kCodecParamAssociatedPayloadType,
1086 &red_associated_payload));
1087 EXPECT_EQ(red_associated_payload, engine_codecs.at(2).id);
1088
1089 EXPECT_EQ(kUlpfecCodecName, engine_codecs.at(4).name);
1090
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001091 int associated_payload_type;
1092 EXPECT_TRUE(engine_codecs.at(1).GetParam(
1093 cricket::kCodecParamAssociatedPayloadType, &associated_payload_type));
1094 EXPECT_EQ(engine_codecs.at(0).id, associated_payload_type);
1095 // Verify default parameters has been added to the VP8 codec.
1096 VerifyCodecHasDefaultFeedbackParams(engine_codecs.at(0));
1097
1098 // Mock encoder creation. |engine| take ownership of the encoder.
Mirta Dvornicic1ec2a162018-12-10 09:47:34 +00001099 webrtc::VideoEncoderFactory::CodecInfo codec_info;
1100 codec_info.is_hardware_accelerated = false;
1101 codec_info.has_internal_source = false;
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001102 const webrtc::SdpVideoFormat format("VP8");
Mirta Dvornicic1ec2a162018-12-10 09:47:34 +00001103 EXPECT_CALL(*encoder_factory, QueryVideoEncoder(format))
1104 .WillRepeatedly(testing::Return(codec_info));
Anders Carlsson67537952018-05-03 11:28:29 +02001105 FakeWebRtcVideoEncoder* const encoder = new FakeWebRtcVideoEncoder(nullptr);
Niels Möllerc572ff32018-11-07 08:43:50 +01001106 rtc::Event encoder_created;
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001107 EXPECT_CALL(*encoder_factory, CreateVideoEncoderProxy(format))
Niels Möller4db138e2018-04-19 09:04:13 +02001108 .WillOnce(
1109 ::testing::DoAll(::testing::InvokeWithoutArgs(
1110 [&encoder_created]() { encoder_created.Set(); }),
1111 ::testing::Return(encoder)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001112
1113 // Mock decoder creation. |engine| take ownership of the decoder.
Anders Carlsson67537952018-05-03 11:28:29 +02001114 FakeWebRtcVideoDecoder* const decoder = new FakeWebRtcVideoDecoder(nullptr);
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001115 EXPECT_CALL(*decoder_factory, CreateVideoDecoderProxy(format))
1116 .WillOnce(testing::Return(decoder));
1117
1118 // Create a call.
1119 webrtc::RtcEventLogNullImpl event_log;
1120 std::unique_ptr<webrtc::Call> call(
1121 webrtc::Call::Create(webrtc::Call::Config(&event_log)));
1122
1123 // Create send channel.
1124 const int send_ssrc = 123;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001125 std::unique_ptr<VideoMediaChannel> send_channel(engine.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07001126 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001127 cricket::VideoSendParameters send_parameters;
1128 send_parameters.codecs.push_back(engine_codecs.at(0));
1129 EXPECT_TRUE(send_channel->SetSendParameters(send_parameters));
1130 send_channel->OnReadyToSend(true);
1131 EXPECT_TRUE(
1132 send_channel->AddSendStream(StreamParams::CreateLegacy(send_ssrc)));
1133 EXPECT_TRUE(send_channel->SetSend(true));
1134
Niels Möller4db138e2018-04-19 09:04:13 +02001135 // Set capturer.
Niels Möller805a27e2019-01-21 12:21:27 +01001136 webrtc::test::FrameForwarder frame_forwarder;
1137 cricket::FakeFrameSource frame_source(1280, 720,
1138 rtc::kNumMicrosecsPerSec / 30);
1139 EXPECT_TRUE(send_channel->SetVideoSend(send_ssrc, nullptr, &frame_forwarder));
Niels Möller4db138e2018-04-19 09:04:13 +02001140 // Sending one frame will allocate the encoder.
Niels Möller805a27e2019-01-21 12:21:27 +01001141 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller4db138e2018-04-19 09:04:13 +02001142 encoder_created.Wait(kTimeout);
1143
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001144 // Create recv channel.
1145 const int recv_ssrc = 321;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001146 std::unique_ptr<VideoMediaChannel> recv_channel(engine.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07001147 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001148 cricket::VideoRecvParameters recv_parameters;
1149 recv_parameters.codecs.push_back(engine_codecs.at(0));
1150 EXPECT_TRUE(recv_channel->SetRecvParameters(recv_parameters));
1151 EXPECT_TRUE(recv_channel->AddRecvStream(
1152 cricket::StreamParams::CreateLegacy(recv_ssrc)));
1153
1154 // Remove streams previously added to free the encoder and decoder instance.
1155 EXPECT_CALL(*encoder_factory, Die());
1156 EXPECT_CALL(*decoder_factory, Die());
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001157 EXPECT_CALL(*rate_allocator_factory, Die());
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001158 EXPECT_TRUE(send_channel->RemoveSendStream(send_ssrc));
1159 EXPECT_TRUE(recv_channel->RemoveRecvStream(recv_ssrc));
1160}
1161
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001162// Test behavior when decoder factory fails to create a decoder (returns null).
1163TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, NullDecoder) {
1164 // |engine| take ownership of the factories.
1165 webrtc::MockVideoEncoderFactory* encoder_factory =
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001166 new webrtc::MockVideoEncoderFactory();
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001167 webrtc::MockVideoDecoderFactory* decoder_factory =
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001168 new webrtc::MockVideoDecoderFactory();
1169 webrtc::MockVideoBitrateAllocatorFactory* rate_allocator_factory =
1170 new webrtc::MockVideoBitrateAllocatorFactory();
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001171 WebRtcVideoEngine engine(
1172 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001173 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)),
1174 (std::unique_ptr<webrtc::VideoBitrateAllocatorFactory>(
1175 rate_allocator_factory)));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001176 const webrtc::SdpVideoFormat vp8_format("VP8");
1177 const std::vector<webrtc::SdpVideoFormat> supported_formats = {vp8_format};
1178 EXPECT_CALL(*encoder_factory, GetSupportedFormats())
1179 .WillRepeatedly(testing::Return(supported_formats));
1180
1181 // Decoder creation fails.
1182 EXPECT_CALL(*decoder_factory, CreateVideoDecoderProxy(testing::_))
1183 .WillOnce(testing::Return(nullptr));
1184
1185 // Create a call.
1186 webrtc::RtcEventLogNullImpl event_log;
1187 std::unique_ptr<webrtc::Call> call(
1188 webrtc::Call::Create(webrtc::Call::Config(&event_log)));
1189
1190 // Create recv channel.
1191 const int recv_ssrc = 321;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001192 std::unique_ptr<VideoMediaChannel> recv_channel(engine.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07001193 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001194 cricket::VideoRecvParameters recv_parameters;
1195 recv_parameters.codecs.push_back(engine.codecs().front());
1196 EXPECT_TRUE(recv_channel->SetRecvParameters(recv_parameters));
1197 EXPECT_TRUE(recv_channel->AddRecvStream(
1198 cricket::StreamParams::CreateLegacy(recv_ssrc)));
1199
1200 // Remove streams previously added to free the encoder and decoder instance.
1201 EXPECT_TRUE(recv_channel->RemoveRecvStream(recv_ssrc));
1202}
1203
eladalonf1841382017-06-12 01:16:46 -07001204TEST_F(WebRtcVideoEngineTest, DISABLED_RecreatesEncoderOnContentTypeChange) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001205 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson8f83b422018-02-21 13:07:13 +01001206 std::unique_ptr<FakeCall> fake_call(new FakeCall());
Anders Carlsson5f2bb622018-05-14 09:48:06 +02001207 std::unique_ptr<VideoMediaChannel> channel(
1208 SetSendParamsWithAllSupportedCodecs());
sprangf24a0642017-02-28 13:23:26 -08001209 ASSERT_TRUE(
1210 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
1211 cricket::VideoCodec codec = GetEngineCodec("VP8");
1212 cricket::VideoSendParameters parameters;
1213 parameters.codecs.push_back(codec);
1214 channel->OnReadyToSend(true);
1215 channel->SetSend(true);
1216 ASSERT_TRUE(channel->SetSendParameters(parameters));
1217
Niels Möller805a27e2019-01-21 12:21:27 +01001218 webrtc::test::FrameForwarder frame_forwarder;
1219 cricket::FakeFrameSource frame_source(1280, 720,
1220 rtc::kNumMicrosecsPerSec / 30);
sprangf24a0642017-02-28 13:23:26 -08001221 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01001222 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
sprangf24a0642017-02-28 13:23:26 -08001223
Niels Möller805a27e2019-01-21 12:21:27 +01001224 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001225 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001226 EXPECT_EQ(webrtc::VideoCodecMode::kRealtimeVideo,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001227 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001228
Niels Möller805a27e2019-01-21 12:21:27 +01001229 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
1230 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
sprangf24a0642017-02-28 13:23:26 -08001231 // No change in content type, keep current encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001232 EXPECT_EQ(1, encoder_factory_->GetNumCreatedEncoders());
sprangf24a0642017-02-28 13:23:26 -08001233
1234 options.is_screencast.emplace(true);
Niels Möller805a27e2019-01-21 12:21:27 +01001235 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
1236 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
sprangf24a0642017-02-28 13:23:26 -08001237 // Change to screen content, recreate encoder. For the simulcast encoder
1238 // adapter case, this will result in two calls since InitEncode triggers a
1239 // a new instance.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001240 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001241 EXPECT_EQ(webrtc::VideoCodecMode::kScreensharing,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001242 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001243
Niels Möller805a27e2019-01-21 12:21:27 +01001244 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
1245 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
sprangf24a0642017-02-28 13:23:26 -08001246 // Still screen content, no need to update encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001247 EXPECT_EQ(2, encoder_factory_->GetNumCreatedEncoders());
sprangf24a0642017-02-28 13:23:26 -08001248
1249 options.is_screencast.emplace(false);
1250 options.video_noise_reduction.emplace(false);
Niels Möller805a27e2019-01-21 12:21:27 +01001251 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
sprangf24a0642017-02-28 13:23:26 -08001252 // Change back to regular video content, update encoder. Also change
1253 // a non |is_screencast| option just to verify it doesn't affect recreation.
Niels Möller805a27e2019-01-21 12:21:27 +01001254 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001255 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(3));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001256 EXPECT_EQ(webrtc::VideoCodecMode::kRealtimeVideo,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001257 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001258
1259 // Remove stream previously added to free the external encoder instance.
1260 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001261 EXPECT_EQ(0u, encoder_factory_->encoders().size());
sprangf24a0642017-02-28 13:23:26 -08001262}
1263
Niels Möller6557d0c2018-04-11 15:18:34 +02001264class WebRtcVideoChannelBaseTest : public testing::Test {
1265 protected:
1266 WebRtcVideoChannelBaseTest()
Jonas Oreland49ac5952018-09-26 16:04:32 +02001267 : engine_(webrtc::CreateBuiltinVideoEncoderFactory(),
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001268 webrtc::CreateBuiltinVideoDecoderFactory(),
1269 webrtc::CreateBuiltinVideoBitrateAllocatorFactory()) {}
Niels Möller6557d0c2018-04-11 15:18:34 +02001270
1271 virtual void SetUp() {
Jonas Oreland49ac5952018-09-26 16:04:32 +02001272 // One testcase calls SetUp in a loop, only create call_ once.
1273 if (!call_) {
1274 call_.reset(webrtc::Call::Create(webrtc::Call::Config(&event_log_)));
1275 }
Niels Möller6557d0c2018-04-11 15:18:34 +02001276 cricket::MediaConfig media_config;
1277 // Disabling cpu overuse detection actually disables quality scaling too; it
1278 // implies DegradationPreference kMaintainResolution. Automatic scaling
1279 // needs to be disabled, otherwise, tests which check the size of received
1280 // frames become flaky.
1281 media_config.video.enable_cpu_adaptation = false;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001282 channel_.reset(
1283 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
1284 call_.get(), media_config, cricket::VideoOptions(),
1285 webrtc::CryptoOptions())));
Niels Möller6557d0c2018-04-11 15:18:34 +02001286 channel_->OnReadyToSend(true);
1287 EXPECT_TRUE(channel_.get() != NULL);
1288 network_interface_.SetDestination(channel_.get());
Anton Sukhanov98a462c2018-10-17 13:15:42 -07001289 channel_->SetInterface(&network_interface_, /*media_transport=*/nullptr);
Niels Möller6557d0c2018-04-11 15:18:34 +02001290 cricket::VideoRecvParameters parameters;
1291 parameters.codecs = engine_.codecs();
1292 channel_->SetRecvParameters(parameters);
1293 EXPECT_TRUE(channel_->AddSendStream(DefaultSendStreamParams()));
Niels Möller805a27e2019-01-21 12:21:27 +01001294 frame_forwarder_ = absl::make_unique<webrtc::test::FrameForwarder>();
1295 frame_source_ = absl::make_unique<cricket::FakeFrameSource>(
1296 640, 480, rtc::kNumMicrosecsPerSec / kFramerate);
1297 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, frame_forwarder_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001298 }
1299
1300 // Utility method to setup an additional stream to send and receive video.
1301 // Used to test send and recv between two streams.
1302 void SetUpSecondStream() {
1303 SetUpSecondStreamWithNoRecv();
1304 // Setup recv for second stream.
1305 EXPECT_TRUE(channel_->AddRecvStream(
1306 cricket::StreamParams::CreateLegacy(kSsrc + 2)));
1307 // Make the second renderer available for use by a new stream.
1308 EXPECT_TRUE(channel_->SetSink(kSsrc + 2, &renderer2_));
1309 }
1310 // Setup an additional stream just to send video. Defer add recv stream.
1311 // This is required if you want to test unsignalled recv of video rtp packets.
1312 void SetUpSecondStreamWithNoRecv() {
1313 // SetUp() already added kSsrc make sure duplicate SSRCs cant be added.
Yves Gerey665174f2018-06-19 15:03:05 +02001314 EXPECT_TRUE(
1315 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001316 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
Yves Gerey665174f2018-06-19 15:03:05 +02001317 EXPECT_FALSE(
1318 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001319 EXPECT_TRUE(channel_->AddSendStream(
1320 cricket::StreamParams::CreateLegacy(kSsrc + 2)));
1321 // We dont add recv for the second stream.
1322
1323 // Setup the receive and renderer for second stream after send.
Niels Möller805a27e2019-01-21 12:21:27 +01001324 frame_forwarder_2_ = absl::make_unique<webrtc::test::FrameForwarder>();
Yves Gerey665174f2018-06-19 15:03:05 +02001325 EXPECT_TRUE(
Niels Möller805a27e2019-01-21 12:21:27 +01001326 channel_->SetVideoSend(kSsrc + 2, nullptr, frame_forwarder_2_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001327 }
Yves Gerey665174f2018-06-19 15:03:05 +02001328 virtual void TearDown() { channel_.reset(); }
1329 bool SetDefaultCodec() { return SetOneCodec(DefaultCodec()); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001330
1331 bool SetOneCodec(const cricket::VideoCodec& codec) {
Niels Möller805a27e2019-01-21 12:21:27 +01001332 frame_source_ = absl::make_unique<cricket::FakeFrameSource>(
1333 kVideoWidth, kVideoHeight, rtc::kNumMicrosecsPerSec / kFramerate);
Niels Möller6557d0c2018-04-11 15:18:34 +02001334
1335 bool sending = channel_->sending();
1336 bool success = SetSend(false);
1337 if (success) {
1338 cricket::VideoSendParameters parameters;
1339 parameters.codecs.push_back(codec);
1340 success = channel_->SetSendParameters(parameters);
1341 }
1342 if (success) {
1343 success = SetSend(sending);
1344 }
1345 return success;
1346 }
Yves Gerey665174f2018-06-19 15:03:05 +02001347 bool SetSend(bool send) { return channel_->SetSend(send); }
Niels Möller805a27e2019-01-21 12:21:27 +01001348 void SendFrame() {
1349 if (frame_forwarder_2_) {
1350 frame_forwarder_2_->IncomingCapturedFrame(frame_source_->GetFrame());
Niels Möller6557d0c2018-04-11 15:18:34 +02001351 }
Niels Möller805a27e2019-01-21 12:21:27 +01001352 frame_forwarder_->IncomingCapturedFrame(frame_source_->GetFrame());
Niels Möller6557d0c2018-04-11 15:18:34 +02001353 }
1354 bool WaitAndSendFrame(int wait_ms) {
1355 bool ret = rtc::Thread::Current()->ProcessMessages(wait_ms);
Niels Möller805a27e2019-01-21 12:21:27 +01001356 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001357 return ret;
1358 }
Yves Gerey665174f2018-06-19 15:03:05 +02001359 int NumRtpBytes() { return network_interface_.NumRtpBytes(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001360 int NumRtpBytes(uint32_t ssrc) {
1361 return network_interface_.NumRtpBytes(ssrc);
1362 }
Yves Gerey665174f2018-06-19 15:03:05 +02001363 int NumRtpPackets() { return network_interface_.NumRtpPackets(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001364 int NumRtpPackets(uint32_t ssrc) {
1365 return network_interface_.NumRtpPackets(ssrc);
1366 }
Yves Gerey665174f2018-06-19 15:03:05 +02001367 int NumSentSsrcs() { return network_interface_.NumSentSsrcs(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001368 const rtc::CopyOnWriteBuffer* GetRtpPacket(int index) {
1369 return network_interface_.GetRtpPacket(index);
1370 }
1371 static int GetPayloadType(const rtc::CopyOnWriteBuffer* p) {
Åsa Persson23cd45a2018-07-03 10:40:40 +02001372 webrtc::RTPHeader header;
1373 EXPECT_TRUE(ParseRtpPacket(p, &header));
1374 return header.payloadType;
Niels Möller6557d0c2018-04-11 15:18:34 +02001375 }
Åsa Persson23cd45a2018-07-03 10:40:40 +02001376
Niels Möller6557d0c2018-04-11 15:18:34 +02001377 static bool ParseRtpPacket(const rtc::CopyOnWriteBuffer* p,
Åsa Persson23cd45a2018-07-03 10:40:40 +02001378 webrtc::RTPHeader* header) {
1379 std::unique_ptr<webrtc::RtpHeaderParser> parser(
1380 webrtc::RtpHeaderParser::Create());
1381 return parser->Parse(p->cdata(), p->size(), header);
Niels Möller6557d0c2018-04-11 15:18:34 +02001382 }
1383
1384 // Tests that we can send and receive frames.
1385 void SendAndReceive(const cricket::VideoCodec& codec) {
1386 EXPECT_TRUE(SetOneCodec(codec));
1387 EXPECT_TRUE(SetSend(true));
1388 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1389 EXPECT_EQ(0, renderer_.num_rendered_frames());
Niels Möller805a27e2019-01-21 12:21:27 +01001390 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001391 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1392 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1393 EXPECT_EQ(codec.id, GetPayloadType(p.get()));
1394 }
1395
1396 void SendReceiveManyAndGetStats(const cricket::VideoCodec& codec,
Yves Gerey665174f2018-06-19 15:03:05 +02001397 int duration_sec,
1398 int fps) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001399 EXPECT_TRUE(SetOneCodec(codec));
1400 EXPECT_TRUE(SetSend(true));
1401 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1402 EXPECT_EQ(0, renderer_.num_rendered_frames());
1403 for (int i = 0; i < duration_sec; ++i) {
1404 for (int frame = 1; frame <= fps; ++frame) {
1405 EXPECT_TRUE(WaitAndSendFrame(1000 / fps));
1406 EXPECT_FRAME_WAIT(frame + i * fps, kVideoWidth, kVideoHeight, kTimeout);
1407 }
1408 }
1409 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1410 EXPECT_EQ(codec.id, GetPayloadType(p.get()));
1411 }
1412
Niels Möller6557d0c2018-04-11 15:18:34 +02001413 cricket::VideoSenderInfo GetSenderStats(size_t i) {
1414 cricket::VideoMediaInfo info;
1415 EXPECT_TRUE(channel_->GetStats(&info));
1416 return info.senders[i];
1417 }
1418
1419 cricket::VideoReceiverInfo GetReceiverStats(size_t i) {
1420 cricket::VideoMediaInfo info;
1421 EXPECT_TRUE(channel_->GetStats(&info));
1422 return info.receivers[i];
1423 }
1424
1425 // Two streams one channel tests.
1426
1427 // Tests that we can send and receive frames.
1428 void TwoStreamsSendAndReceive(const cricket::VideoCodec& codec) {
1429 SetUpSecondStream();
1430 // Test sending and receiving on first stream.
1431 SendAndReceive(codec);
1432 // Test sending and receiving on second stream.
1433 EXPECT_EQ_WAIT(1, renderer2_.num_rendered_frames(), kTimeout);
1434 EXPECT_GT(NumRtpPackets(), 0);
1435 EXPECT_EQ(1, renderer2_.num_rendered_frames());
1436 }
1437
1438 cricket::VideoCodec GetEngineCodec(const std::string& name) {
1439 for (const cricket::VideoCodec& engine_codec : engine_.codecs()) {
Niels Möller039743e2018-10-23 10:07:25 +02001440 if (absl::EqualsIgnoreCase(name, engine_codec.name))
Niels Möller6557d0c2018-04-11 15:18:34 +02001441 return engine_codec;
1442 }
1443 // This point should never be reached.
1444 ADD_FAILURE() << "Unrecognized codec name: " << name;
1445 return cricket::VideoCodec();
1446 }
1447
1448 cricket::VideoCodec DefaultCodec() { return GetEngineCodec("VP8"); }
1449
1450 cricket::StreamParams DefaultSendStreamParams() {
1451 return cricket::StreamParams::CreateLegacy(kSsrc);
1452 }
1453
1454 webrtc::RtcEventLogNullImpl event_log_;
Jonas Oreland49ac5952018-09-26 16:04:32 +02001455 std::unique_ptr<webrtc::Call> call_;
Niels Möller6557d0c2018-04-11 15:18:34 +02001456 WebRtcVideoEngine engine_;
Niels Möller805a27e2019-01-21 12:21:27 +01001457
1458 std::unique_ptr<cricket::FakeFrameSource> frame_source_;
1459 std::unique_ptr<webrtc::test::FrameForwarder> frame_forwarder_;
1460 std::unique_ptr<webrtc::test::FrameForwarder> frame_forwarder_2_;
1461
Niels Möller6557d0c2018-04-11 15:18:34 +02001462 std::unique_ptr<WebRtcVideoChannel> channel_;
1463 cricket::FakeNetworkInterface network_interface_;
1464 cricket::FakeVideoRenderer renderer_;
1465
1466 // Used by test cases where 2 streams are run on the same channel.
1467 cricket::FakeVideoRenderer renderer2_;
1468};
1469
1470// Test that SetSend works.
srtee0c2eea2017-12-15 17:44:33 +01001471TEST_F(WebRtcVideoChannelBaseTest, SetSend) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001472 EXPECT_FALSE(channel_->sending());
Niels Möller805a27e2019-01-21 12:21:27 +01001473 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, frame_forwarder_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001474 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1475 EXPECT_FALSE(channel_->sending());
1476 EXPECT_TRUE(SetSend(true));
1477 EXPECT_TRUE(channel_->sending());
Niels Möller805a27e2019-01-21 12:21:27 +01001478 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001479 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
1480 EXPECT_TRUE(SetSend(false));
1481 EXPECT_FALSE(channel_->sending());
srtee0c2eea2017-12-15 17:44:33 +01001482}
Niels Möller6557d0c2018-04-11 15:18:34 +02001483
1484// Test that SetSend fails without codecs being set.
srtee0c2eea2017-12-15 17:44:33 +01001485TEST_F(WebRtcVideoChannelBaseTest, SetSendWithoutCodecs) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001486 EXPECT_FALSE(channel_->sending());
1487 EXPECT_FALSE(SetSend(true));
1488 EXPECT_FALSE(channel_->sending());
srtee0c2eea2017-12-15 17:44:33 +01001489}
Niels Möller6557d0c2018-04-11 15:18:34 +02001490
1491// Test that we properly set the send and recv buffer sizes by the time
1492// SetSend is called.
srtee0c2eea2017-12-15 17:44:33 +01001493TEST_F(WebRtcVideoChannelBaseTest, SetSendSetsTransportBufferSizes) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001494 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1495 EXPECT_TRUE(SetSend(true));
1496 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
Johannes Krond38a2b82018-10-23 11:31:19 +02001497 EXPECT_EQ(256 * 1024, network_interface_.recvbuf_size());
Erik Språng820ebd02018-08-20 17:14:25 +02001498}
1499
Johannes Kron5a0665b2019-04-08 10:35:50 +02001500// Test that we properly set the send and recv buffer sizes when overriding
1501// via field trials.
1502TEST_F(WebRtcVideoChannelBaseTest, OverridesRecvBufferSize) {
1503 // Set field trial to override the default recv buffer size, and then re-run
1504 // setup where the interface is created and configured.
1505 const int kCustomRecvBufferSize = 123456;
1506 webrtc::test::ScopedFieldTrials field_trial(
1507 "WebRTC-IncreasedReceivebuffers/123456/");
1508 SetUp();
1509
1510 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1511 EXPECT_TRUE(SetSend(true));
1512 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
1513 EXPECT_EQ(kCustomRecvBufferSize, network_interface_.recvbuf_size());
1514}
1515
1516// Test that we properly set the send and recv buffer sizes when overriding
1517// via field trials with suffix.
1518TEST_F(WebRtcVideoChannelBaseTest, OverridesRecvBufferSizeWithSuffix) {
1519 // Set field trial to override the default recv buffer size, and then re-run
1520 // setup where the interface is created and configured.
1521 const int kCustomRecvBufferSize = 123456;
1522 webrtc::test::ScopedFieldTrials field_trial(
1523 "WebRTC-IncreasedReceivebuffers/123456_Dogfood/");
1524 SetUp();
1525
1526 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1527 EXPECT_TRUE(SetSend(true));
1528 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
1529 EXPECT_EQ(kCustomRecvBufferSize, network_interface_.recvbuf_size());
1530}
1531
1532// Test that we properly set the send and recv buffer sizes when overriding
1533// via field trials that don't make any sense.
1534TEST_F(WebRtcVideoChannelBaseTest, InvalidRecvBufferSize) {
1535 // Set bogus field trial values to override the default recv buffer size, and
1536 // then re-run setup where the interface is created and configured. The
1537 // default value should still be used.
1538
1539 for (std::string group : {" ", "NotANumber", "-1", "0"}) {
1540 std::string field_trial_string = "WebRTC-IncreasedReceivebuffers/";
1541 field_trial_string += group;
1542 field_trial_string += "/";
1543 webrtc::test::ScopedFieldTrials field_trial(field_trial_string);
1544 SetUp();
1545
1546 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1547 EXPECT_TRUE(SetSend(true));
1548 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
1549 EXPECT_EQ(256 * 1024, network_interface_.recvbuf_size());
1550 }
1551}
1552
Niels Möller6557d0c2018-04-11 15:18:34 +02001553// Test that stats work properly for a 1-1 call.
srtee0c2eea2017-12-15 17:44:33 +01001554TEST_F(WebRtcVideoChannelBaseTest, GetStats) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001555 const int kDurationSec = 3;
1556 const int kFps = 10;
1557 SendReceiveManyAndGetStats(DefaultCodec(), kDurationSec, kFps);
1558
1559 cricket::VideoMediaInfo info;
1560 EXPECT_TRUE(channel_->GetStats(&info));
1561
1562 ASSERT_EQ(1U, info.senders.size());
1563 // TODO(whyuan): bytes_sent and bytes_rcvd are different. Are both payload?
1564 // For webrtc, bytes_sent does not include the RTP header length.
1565 EXPECT_GT(info.senders[0].bytes_sent, 0);
1566 EXPECT_EQ(NumRtpPackets(), info.senders[0].packets_sent);
1567 EXPECT_EQ(0.0, info.senders[0].fraction_lost);
1568 ASSERT_TRUE(info.senders[0].codec_payload_type);
1569 EXPECT_EQ(DefaultCodec().id, *info.senders[0].codec_payload_type);
1570 EXPECT_EQ(0, info.senders[0].firs_rcvd);
1571 EXPECT_EQ(0, info.senders[0].plis_rcvd);
1572 EXPECT_EQ(0, info.senders[0].nacks_rcvd);
1573 EXPECT_EQ(kVideoWidth, info.senders[0].send_frame_width);
1574 EXPECT_EQ(kVideoHeight, info.senders[0].send_frame_height);
1575 EXPECT_GT(info.senders[0].framerate_input, 0);
1576 EXPECT_GT(info.senders[0].framerate_sent, 0);
1577
1578 EXPECT_EQ(1U, info.send_codecs.count(DefaultCodec().id));
1579 EXPECT_EQ(DefaultCodec().ToCodecParameters(),
1580 info.send_codecs[DefaultCodec().id]);
1581
1582 ASSERT_EQ(1U, info.receivers.size());
1583 EXPECT_EQ(1U, info.senders[0].ssrcs().size());
1584 EXPECT_EQ(1U, info.receivers[0].ssrcs().size());
1585 EXPECT_EQ(info.senders[0].ssrcs()[0], info.receivers[0].ssrcs()[0]);
1586 ASSERT_TRUE(info.receivers[0].codec_payload_type);
1587 EXPECT_EQ(DefaultCodec().id, *info.receivers[0].codec_payload_type);
1588 EXPECT_EQ(NumRtpBytes(), info.receivers[0].bytes_rcvd);
1589 EXPECT_EQ(NumRtpPackets(), info.receivers[0].packets_rcvd);
1590 EXPECT_EQ(0.0, info.receivers[0].fraction_lost);
1591 EXPECT_EQ(0, info.receivers[0].packets_lost);
1592 // TODO(asapersson): Not set for webrtc. Handle missing stats.
1593 // EXPECT_EQ(0, info.receivers[0].packets_concealed);
1594 EXPECT_EQ(0, info.receivers[0].firs_sent);
1595 EXPECT_EQ(0, info.receivers[0].plis_sent);
1596 EXPECT_EQ(0, info.receivers[0].nacks_sent);
1597 EXPECT_EQ(kVideoWidth, info.receivers[0].frame_width);
1598 EXPECT_EQ(kVideoHeight, info.receivers[0].frame_height);
1599 EXPECT_GT(info.receivers[0].framerate_rcvd, 0);
1600 EXPECT_GT(info.receivers[0].framerate_decoded, 0);
1601 EXPECT_GT(info.receivers[0].framerate_output, 0);
1602
1603 EXPECT_EQ(1U, info.receive_codecs.count(DefaultCodec().id));
1604 EXPECT_EQ(DefaultCodec().ToCodecParameters(),
1605 info.receive_codecs[DefaultCodec().id]);
srtee0c2eea2017-12-15 17:44:33 +01001606}
Niels Möller6557d0c2018-04-11 15:18:34 +02001607
1608// Test that stats work properly for a conf call with multiple recv streams.
srtee0c2eea2017-12-15 17:44:33 +01001609TEST_F(WebRtcVideoChannelBaseTest, GetStatsMultipleRecvStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001610 cricket::FakeVideoRenderer renderer1, renderer2;
1611 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1612 cricket::VideoSendParameters parameters;
1613 parameters.codecs.push_back(DefaultCodec());
1614 parameters.conference_mode = true;
1615 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1616 EXPECT_TRUE(SetSend(true));
Yves Gerey665174f2018-06-19 15:03:05 +02001617 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
1618 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001619 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
1620 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
1621 EXPECT_EQ(0, renderer1.num_rendered_frames());
1622 EXPECT_EQ(0, renderer2.num_rendered_frames());
1623 std::vector<uint32_t> ssrcs;
1624 ssrcs.push_back(1);
1625 ssrcs.push_back(2);
1626 network_interface_.SetConferenceMode(true, ssrcs);
Niels Möller805a27e2019-01-21 12:21:27 +01001627 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001628 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kVideoWidth, kVideoHeight,
1629 kTimeout);
1630 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kVideoWidth, kVideoHeight,
1631 kTimeout);
1632
1633 EXPECT_TRUE(channel_->SetSend(false));
1634
1635 cricket::VideoMediaInfo info;
1636 EXPECT_TRUE(channel_->GetStats(&info));
1637 ASSERT_EQ(1U, info.senders.size());
1638 // TODO(whyuan): bytes_sent and bytes_rcvd are different. Are both payload?
1639 // For webrtc, bytes_sent does not include the RTP header length.
1640 EXPECT_GT(GetSenderStats(0).bytes_sent, 0);
1641 EXPECT_EQ_WAIT(NumRtpPackets(), GetSenderStats(0).packets_sent, kTimeout);
1642 EXPECT_EQ(kVideoWidth, GetSenderStats(0).send_frame_width);
1643 EXPECT_EQ(kVideoHeight, GetSenderStats(0).send_frame_height);
1644
1645 ASSERT_EQ(2U, info.receivers.size());
1646 for (size_t i = 0; i < info.receivers.size(); ++i) {
1647 EXPECT_EQ(1U, GetReceiverStats(i).ssrcs().size());
1648 EXPECT_EQ(i + 1, GetReceiverStats(i).ssrcs()[0]);
1649 EXPECT_EQ_WAIT(NumRtpBytes(), GetReceiverStats(i).bytes_rcvd, kTimeout);
Yves Gerey665174f2018-06-19 15:03:05 +02001650 EXPECT_EQ_WAIT(NumRtpPackets(), GetReceiverStats(i).packets_rcvd, kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001651 EXPECT_EQ_WAIT(kVideoWidth, GetReceiverStats(i).frame_width, kTimeout);
1652 EXPECT_EQ_WAIT(kVideoHeight, GetReceiverStats(i).frame_height, kTimeout);
1653 }
srtee0c2eea2017-12-15 17:44:33 +01001654}
Niels Möller6557d0c2018-04-11 15:18:34 +02001655
1656// Test that stats work properly for a conf call with multiple send streams.
srtee0c2eea2017-12-15 17:44:33 +01001657TEST_F(WebRtcVideoChannelBaseTest, GetStatsMultipleSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001658 // Normal setup; note that we set the SSRC explicitly to ensure that
1659 // it will come first in the senders map.
1660 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1661 cricket::VideoSendParameters parameters;
1662 parameters.codecs.push_back(DefaultCodec());
1663 parameters.conference_mode = true;
1664 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Yves Gerey665174f2018-06-19 15:03:05 +02001665 EXPECT_TRUE(
1666 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001667 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
1668 EXPECT_TRUE(SetSend(true));
Niels Möller805a27e2019-01-21 12:21:27 +01001669 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001670 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
1671 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1672
1673 // Add an additional capturer, and hook up a renderer to receive it.
1674 cricket::FakeVideoRenderer renderer2;
Niels Möller805a27e2019-01-21 12:21:27 +01001675 webrtc::test::FrameForwarder frame_forwarder;
Niels Möller6557d0c2018-04-11 15:18:34 +02001676 const int kTestWidth = 160;
1677 const int kTestHeight = 120;
Niels Möller805a27e2019-01-21 12:21:27 +01001678 cricket::FakeFrameSource frame_source(kTestWidth, kTestHeight,
1679 rtc::kNumMicrosecsPerSec / 5);
Yves Gerey665174f2018-06-19 15:03:05 +02001680 EXPECT_TRUE(
1681 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(5678)));
Niels Möller805a27e2019-01-21 12:21:27 +01001682 EXPECT_TRUE(channel_->SetVideoSend(5678, nullptr, &frame_forwarder));
Yves Gerey665174f2018-06-19 15:03:05 +02001683 EXPECT_TRUE(
1684 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(5678)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001685 EXPECT_TRUE(channel_->SetSink(5678, &renderer2));
Niels Möller805a27e2019-01-21 12:21:27 +01001686 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Yves Gerey665174f2018-06-19 15:03:05 +02001687 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kTestWidth, kTestHeight,
1688 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001689
1690 // Get stats, and make sure they are correct for two senders. We wait until
1691 // the number of expected packets have been sent to avoid races where we
1692 // check stats before it has been updated.
1693 cricket::VideoMediaInfo info;
1694 for (uint32_t i = 0; i < kTimeout; ++i) {
1695 rtc::Thread::Current()->ProcessMessages(1);
1696 EXPECT_TRUE(channel_->GetStats(&info));
1697 ASSERT_EQ(2U, info.senders.size());
1698 if (info.senders[0].packets_sent + info.senders[1].packets_sent ==
1699 NumRtpPackets()) {
1700 // Stats have been updated for both sent frames, expectations can be
1701 // checked now.
1702 break;
1703 }
1704 }
1705 EXPECT_EQ(NumRtpPackets(),
1706 info.senders[0].packets_sent + info.senders[1].packets_sent)
1707 << "Timed out while waiting for packet counts for all sent packets.";
1708 EXPECT_EQ(1U, info.senders[0].ssrcs().size());
1709 EXPECT_EQ(1234U, info.senders[0].ssrcs()[0]);
1710 EXPECT_EQ(kVideoWidth, info.senders[0].send_frame_width);
1711 EXPECT_EQ(kVideoHeight, info.senders[0].send_frame_height);
1712 EXPECT_EQ(1U, info.senders[1].ssrcs().size());
1713 EXPECT_EQ(5678U, info.senders[1].ssrcs()[0]);
1714 EXPECT_EQ(kTestWidth, info.senders[1].send_frame_width);
1715 EXPECT_EQ(kTestHeight, info.senders[1].send_frame_height);
1716 // The capturer must be unregistered here as it runs out of it's scope next.
1717 channel_->SetVideoSend(5678, nullptr, nullptr);
srtee0c2eea2017-12-15 17:44:33 +01001718}
pbos@webrtc.org8fdeee62014-07-20 14:40:23 +00001719
Niels Möller6557d0c2018-04-11 15:18:34 +02001720// Test that we can set the bandwidth.
srtee0c2eea2017-12-15 17:44:33 +01001721TEST_F(WebRtcVideoChannelBaseTest, SetSendBandwidth) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001722 cricket::VideoSendParameters parameters;
1723 parameters.codecs.push_back(DefaultCodec());
1724 parameters.max_bandwidth_bps = -1; // <= 0 means unlimited.
1725 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1726 parameters.max_bandwidth_bps = 128 * 1024;
1727 EXPECT_TRUE(channel_->SetSendParameters(parameters));
srtee0c2eea2017-12-15 17:44:33 +01001728}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001729
Niels Möller6557d0c2018-04-11 15:18:34 +02001730// Test that we can set the SSRC for the default send source.
srtee0c2eea2017-12-15 17:44:33 +01001731TEST_F(WebRtcVideoChannelBaseTest, SetSendSsrc) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001732 EXPECT_TRUE(SetDefaultCodec());
1733 EXPECT_TRUE(SetSend(true));
Niels Möller805a27e2019-01-21 12:21:27 +01001734 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001735 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001736 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001737 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001738 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1739 EXPECT_EQ(kSsrc, header.ssrc);
1740
Niels Möller6557d0c2018-04-11 15:18:34 +02001741 // Packets are being paced out, so these can mismatch between the first and
1742 // second call to NumRtpPackets until pending packets are paced out.
Åsa Persson23cd45a2018-07-03 10:40:40 +02001743 EXPECT_EQ_WAIT(NumRtpPackets(), NumRtpPackets(header.ssrc), kTimeout);
1744 EXPECT_EQ_WAIT(NumRtpBytes(), NumRtpBytes(header.ssrc), kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001745 EXPECT_EQ(1, NumSentSsrcs());
1746 EXPECT_EQ(0, NumRtpPackets(kSsrc - 1));
1747 EXPECT_EQ(0, NumRtpBytes(kSsrc - 1));
srtee0c2eea2017-12-15 17:44:33 +01001748}
Niels Möller6557d0c2018-04-11 15:18:34 +02001749
1750// Test that we can set the SSRC even after codecs are set.
srtee0c2eea2017-12-15 17:44:33 +01001751TEST_F(WebRtcVideoChannelBaseTest, SetSendSsrcAfterSetCodecs) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001752 // Remove stream added in Setup.
1753 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1754 EXPECT_TRUE(SetDefaultCodec());
Niels Möller6557d0c2018-04-11 15:18:34 +02001755 EXPECT_TRUE(
Yves Gerey665174f2018-06-19 15:03:05 +02001756 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(999)));
Niels Möller805a27e2019-01-21 12:21:27 +01001757 EXPECT_TRUE(channel_->SetVideoSend(999u, nullptr, frame_forwarder_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001758 EXPECT_TRUE(SetSend(true));
1759 EXPECT_TRUE(WaitAndSendFrame(0));
1760 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001761 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001762 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001763 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1764 EXPECT_EQ(999u, header.ssrc);
Niels Möller6557d0c2018-04-11 15:18:34 +02001765 // Packets are being paced out, so these can mismatch between the first and
1766 // second call to NumRtpPackets until pending packets are paced out.
Åsa Persson23cd45a2018-07-03 10:40:40 +02001767 EXPECT_EQ_WAIT(NumRtpPackets(), NumRtpPackets(header.ssrc), kTimeout);
1768 EXPECT_EQ_WAIT(NumRtpBytes(), NumRtpBytes(header.ssrc), kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001769 EXPECT_EQ(1, NumSentSsrcs());
1770 EXPECT_EQ(0, NumRtpPackets(kSsrc));
1771 EXPECT_EQ(0, NumRtpBytes(kSsrc));
srtee0c2eea2017-12-15 17:44:33 +01001772}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001773
Niels Möller6557d0c2018-04-11 15:18:34 +02001774// Test that we can set the default video renderer before and after
1775// media is received.
srtee0c2eea2017-12-15 17:44:33 +01001776TEST_F(WebRtcVideoChannelBaseTest, SetSink) {
Yves Gerey665174f2018-06-19 15:03:05 +02001777 uint8_t data1[] = {0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
1778 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
Niels Möller6557d0c2018-04-11 15:18:34 +02001779
1780 rtc::CopyOnWriteBuffer packet1(data1, sizeof(data1));
1781 rtc::SetBE32(packet1.data() + 8, kSsrc);
1782 channel_->SetSink(kDefaultReceiveSsrc, NULL);
1783 EXPECT_TRUE(SetDefaultCodec());
1784 EXPECT_TRUE(SetSend(true));
1785 EXPECT_EQ(0, renderer_.num_rendered_frames());
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07001786 channel_->OnPacketReceived(packet1, /* packet_time_us */ -1);
Niels Möller6557d0c2018-04-11 15:18:34 +02001787 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
Niels Möller805a27e2019-01-21 12:21:27 +01001788 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001789 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
srtee0c2eea2017-12-15 17:44:33 +01001790}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001791
Niels Möller6557d0c2018-04-11 15:18:34 +02001792// Tests setting up and configuring a send stream.
srtee0c2eea2017-12-15 17:44:33 +01001793TEST_F(WebRtcVideoChannelBaseTest, AddRemoveSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001794 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1795 EXPECT_TRUE(SetSend(true));
1796 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
Niels Möller805a27e2019-01-21 12:21:27 +01001797 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001798 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1799 EXPECT_GT(NumRtpPackets(), 0);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001800 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001801 size_t last_packet = NumRtpPackets() - 1;
Yves Gerey665174f2018-06-19 15:03:05 +02001802 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(
1803 GetRtpPacket(static_cast<int>(last_packet)));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001804 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1805 EXPECT_EQ(kSsrc, header.ssrc);
Niels Möller6557d0c2018-04-11 15:18:34 +02001806
1807 // Remove the send stream that was added during Setup.
1808 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1809 int rtp_packets = NumRtpPackets();
1810
Niels Möller6557d0c2018-04-11 15:18:34 +02001811 EXPECT_TRUE(
Yves Gerey665174f2018-06-19 15:03:05 +02001812 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(789u)));
Niels Möller805a27e2019-01-21 12:21:27 +01001813 EXPECT_TRUE(channel_->SetVideoSend(789u, nullptr, frame_forwarder_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001814 EXPECT_EQ(rtp_packets, NumRtpPackets());
1815 // Wait 30ms to guarantee the engine does not drop the frame.
1816 EXPECT_TRUE(WaitAndSendFrame(30));
1817 EXPECT_TRUE_WAIT(NumRtpPackets() > rtp_packets, kTimeout);
1818
1819 last_packet = NumRtpPackets() - 1;
1820 p.reset(GetRtpPacket(static_cast<int>(last_packet)));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001821 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1822 EXPECT_EQ(789u, header.ssrc);
srtee0c2eea2017-12-15 17:44:33 +01001823}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001824
Niels Möller6557d0c2018-04-11 15:18:34 +02001825// Tests the behavior of incoming streams in a conference scenario.
srtee0c2eea2017-12-15 17:44:33 +01001826TEST_F(WebRtcVideoChannelBaseTest, SimulateConference) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001827 cricket::FakeVideoRenderer renderer1, renderer2;
1828 EXPECT_TRUE(SetDefaultCodec());
1829 cricket::VideoSendParameters parameters;
1830 parameters.codecs.push_back(DefaultCodec());
1831 parameters.conference_mode = true;
1832 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1833 EXPECT_TRUE(SetSend(true));
Yves Gerey665174f2018-06-19 15:03:05 +02001834 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
1835 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001836 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
1837 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
1838 EXPECT_EQ(0, renderer1.num_rendered_frames());
1839 EXPECT_EQ(0, renderer2.num_rendered_frames());
1840 std::vector<uint32_t> ssrcs;
1841 ssrcs.push_back(1);
1842 ssrcs.push_back(2);
1843 network_interface_.SetConferenceMode(true, ssrcs);
Niels Möller805a27e2019-01-21 12:21:27 +01001844 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001845 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kVideoWidth, kVideoHeight,
1846 kTimeout);
1847 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kVideoWidth, kVideoHeight,
1848 kTimeout);
1849
1850 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1851 EXPECT_EQ(DefaultCodec().id, GetPayloadType(p.get()));
1852 EXPECT_EQ(kVideoWidth, renderer1.width());
1853 EXPECT_EQ(kVideoHeight, renderer1.height());
1854 EXPECT_EQ(kVideoWidth, renderer2.width());
1855 EXPECT_EQ(kVideoHeight, renderer2.height());
1856 EXPECT_TRUE(channel_->RemoveRecvStream(2));
1857 EXPECT_TRUE(channel_->RemoveRecvStream(1));
srtee0c2eea2017-12-15 17:44:33 +01001858}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001859
Niels Möller6557d0c2018-04-11 15:18:34 +02001860// Tests that we can add and remove capturers and frames are sent out properly
srtee0c2eea2017-12-15 17:44:33 +01001861TEST_F(WebRtcVideoChannelBaseTest, DISABLED_AddRemoveCapturer) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001862 using cricket::VideoCodec;
1863 using cricket::VideoOptions;
1864 using cricket::VideoFormat;
1865 using cricket::FOURCC_I420;
1866
1867 VideoCodec codec = DefaultCodec();
1868 const int time_between_send_ms = VideoFormat::FpsToInterval(kFramerate);
1869 EXPECT_TRUE(SetOneCodec(codec));
1870 EXPECT_TRUE(SetSend(true));
1871 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1872 EXPECT_EQ(0, renderer_.num_rendered_frames());
Niels Möller805a27e2019-01-21 12:21:27 +01001873 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001874 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
Niels Möller805a27e2019-01-21 12:21:27 +01001875
1876 webrtc::test::FrameForwarder frame_forwarder;
1877 cricket::FakeFrameSource frame_source(480, 360, rtc::kNumMicrosecsPerSec / 30,
1878 rtc::kNumMicrosecsPerSec / 30);
Niels Möller6557d0c2018-04-11 15:18:34 +02001879
1880 // TODO(nisse): This testcase fails if we don't configure
1881 // screencast. It's unclear why, I see nothing obvious in this
1882 // test which is related to screencast logic.
1883 VideoOptions video_options;
1884 video_options.is_screencast = true;
1885 channel_->SetVideoSend(kSsrc, &video_options, nullptr);
1886
Niels Möller6557d0c2018-04-11 15:18:34 +02001887 int captured_frames = 1;
1888 for (int iterations = 0; iterations < 2; ++iterations) {
Niels Möller805a27e2019-01-21 12:21:27 +01001889 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
Niels Möller6557d0c2018-04-11 15:18:34 +02001890 rtc::Thread::Current()->ProcessMessages(time_between_send_ms);
Niels Möller805a27e2019-01-21 12:21:27 +01001891 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
1892
Niels Möller6557d0c2018-04-11 15:18:34 +02001893 ++captured_frames;
1894 // Wait until frame of right size is captured.
1895 EXPECT_TRUE_WAIT(renderer_.num_rendered_frames() >= captured_frames &&
Niels Möller805a27e2019-01-21 12:21:27 +01001896 480 == renderer_.width() &&
1897 360 == renderer_.height() && !renderer_.black_frame(),
Yves Gerey665174f2018-06-19 15:03:05 +02001898 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001899 EXPECT_GE(renderer_.num_rendered_frames(), captured_frames);
Niels Möller805a27e2019-01-21 12:21:27 +01001900 EXPECT_EQ(480, renderer_.width());
1901 EXPECT_EQ(360, renderer_.height());
Niels Möller6557d0c2018-04-11 15:18:34 +02001902 captured_frames = renderer_.num_rendered_frames() + 1;
1903 EXPECT_FALSE(renderer_.black_frame());
1904 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1905 // Make sure a black frame is generated within the specified timeout.
1906 // The black frame should be the resolution of the previous frame to
1907 // prevent expensive encoder reconfigurations.
1908 EXPECT_TRUE_WAIT(renderer_.num_rendered_frames() >= captured_frames &&
Niels Möller805a27e2019-01-21 12:21:27 +01001909 480 == renderer_.width() &&
1910 360 == renderer_.height() && renderer_.black_frame(),
Yves Gerey665174f2018-06-19 15:03:05 +02001911 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001912 EXPECT_GE(renderer_.num_rendered_frames(), captured_frames);
Niels Möller805a27e2019-01-21 12:21:27 +01001913 EXPECT_EQ(480, renderer_.width());
1914 EXPECT_EQ(360, renderer_.height());
Niels Möller6557d0c2018-04-11 15:18:34 +02001915 EXPECT_TRUE(renderer_.black_frame());
1916
1917 // The black frame has the same timestamp as the next frame since it's
1918 // timestamp is set to the last frame's timestamp + interval. WebRTC will
1919 // not render a frame with the same timestamp so capture another frame
1920 // with the frame capturer to increment the next frame's timestamp.
Niels Möller805a27e2019-01-21 12:21:27 +01001921 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller6557d0c2018-04-11 15:18:34 +02001922 }
srtee0c2eea2017-12-15 17:44:33 +01001923}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001924
Niels Möller6557d0c2018-04-11 15:18:34 +02001925// Tests that if SetVideoSend is called with a NULL capturer after the
1926// capturer was already removed, the application doesn't crash (and no black
1927// frame is sent).
srtee0c2eea2017-12-15 17:44:33 +01001928TEST_F(WebRtcVideoChannelBaseTest, RemoveCapturerWithoutAdd) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001929 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1930 EXPECT_TRUE(SetSend(true));
1931 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1932 EXPECT_EQ(0, renderer_.num_rendered_frames());
Niels Möller805a27e2019-01-21 12:21:27 +01001933 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001934 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1935 // Wait for one frame so they don't get dropped because we send frames too
1936 // tightly.
1937 rtc::Thread::Current()->ProcessMessages(30);
1938 // Remove the capturer.
1939 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1940
1941 // No capturer was added, so this SetVideoSend shouldn't do anything.
1942 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1943 rtc::Thread::Current()->ProcessMessages(300);
1944 // Verify no more frames were sent.
1945 EXPECT_EQ(1, renderer_.num_rendered_frames());
srtee0c2eea2017-12-15 17:44:33 +01001946}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001947
Niels Möller6557d0c2018-04-11 15:18:34 +02001948// Tests that we can add and remove capturer as unique sources.
srtee0c2eea2017-12-15 17:44:33 +01001949TEST_F(WebRtcVideoChannelBaseTest, AddRemoveCapturerMultipleSources) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001950 // WebRTC implementation will drop frames if pushed to quickly. Wait the
1951 // interval time to avoid that.
1952 // WebRTC implementation will drop frames if pushed to quickly. Wait the
1953 // interval time to avoid that.
1954 // Set up the stream associated with the engine.
Yves Gerey665174f2018-06-19 15:03:05 +02001955 EXPECT_TRUE(
1956 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001957 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
1958 cricket::VideoFormat capture_format(
1959 kVideoWidth, kVideoHeight,
1960 cricket::VideoFormat::FpsToInterval(kFramerate), cricket::FOURCC_I420);
1961 // Set up additional stream 1.
1962 cricket::FakeVideoRenderer renderer1;
1963 EXPECT_FALSE(channel_->SetSink(1, &renderer1));
Yves Gerey665174f2018-06-19 15:03:05 +02001964 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001965 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
Yves Gerey665174f2018-06-19 15:03:05 +02001966 EXPECT_TRUE(channel_->AddSendStream(cricket::StreamParams::CreateLegacy(1)));
Niels Möller805a27e2019-01-21 12:21:27 +01001967
1968 webrtc::test::FrameForwarder frame_forwarder1;
1969 cricket::FakeFrameSource frame_source(kVideoWidth, kVideoHeight,
1970 rtc::kNumMicrosecsPerSec / kFramerate);
1971
Niels Möller6557d0c2018-04-11 15:18:34 +02001972 // Set up additional stream 2.
1973 cricket::FakeVideoRenderer renderer2;
1974 EXPECT_FALSE(channel_->SetSink(2, &renderer2));
Yves Gerey665174f2018-06-19 15:03:05 +02001975 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001976 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
Yves Gerey665174f2018-06-19 15:03:05 +02001977 EXPECT_TRUE(channel_->AddSendStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller805a27e2019-01-21 12:21:27 +01001978 webrtc::test::FrameForwarder frame_forwarder2;
1979
Niels Möller6557d0c2018-04-11 15:18:34 +02001980 // State for all the streams.
1981 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1982 // A limitation in the lmi implementation requires that SetVideoSend() is
1983 // called after SetOneCodec().
1984 // TODO(hellner): this seems like an unnecessary constraint, fix it.
Niels Möller805a27e2019-01-21 12:21:27 +01001985 EXPECT_TRUE(channel_->SetVideoSend(1, nullptr, &frame_forwarder1));
1986 EXPECT_TRUE(channel_->SetVideoSend(2, nullptr, &frame_forwarder2));
Niels Möller6557d0c2018-04-11 15:18:34 +02001987 EXPECT_TRUE(SetSend(true));
1988 // Test capturer associated with engine.
1989 const int kTestWidth = 160;
1990 const int kTestHeight = 120;
Niels Möller805a27e2019-01-21 12:21:27 +01001991 frame_forwarder1.IncomingCapturedFrame(frame_source.GetFrame(
1992 kTestWidth, kTestHeight, webrtc::VideoRotation::kVideoRotation_0,
1993 rtc::kNumMicrosecsPerSec / kFramerate));
Yves Gerey665174f2018-06-19 15:03:05 +02001994 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kTestWidth, kTestHeight,
1995 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001996 // Capture a frame with additional capturer2, frames should be received
Niels Möller805a27e2019-01-21 12:21:27 +01001997 frame_forwarder2.IncomingCapturedFrame(frame_source.GetFrame(
1998 kTestWidth, kTestHeight, webrtc::VideoRotation::kVideoRotation_0,
1999 rtc::kNumMicrosecsPerSec / kFramerate));
Yves Gerey665174f2018-06-19 15:03:05 +02002000 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kTestWidth, kTestHeight,
2001 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02002002 // Successfully remove the capturer.
2003 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
2004 // The capturers must be unregistered here as it runs out of it's scope
2005 // next.
2006 EXPECT_TRUE(channel_->SetVideoSend(1, nullptr, nullptr));
2007 EXPECT_TRUE(channel_->SetVideoSend(2, nullptr, nullptr));
srtee0c2eea2017-12-15 17:44:33 +01002008}
Niels Möller6557d0c2018-04-11 15:18:34 +02002009
2010// Tests empty StreamParams is rejected.
srtee0c2eea2017-12-15 17:44:33 +01002011TEST_F(WebRtcVideoChannelBaseTest, RejectEmptyStreamParams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02002012 // Remove the send stream that was added during Setup.
2013 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
2014
2015 cricket::StreamParams empty;
2016 EXPECT_FALSE(channel_->AddSendStream(empty));
Yves Gerey665174f2018-06-19 15:03:05 +02002017 EXPECT_TRUE(
2018 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(789u)));
srtee0c2eea2017-12-15 17:44:33 +01002019}
Niels Möller6557d0c2018-04-11 15:18:34 +02002020
2021// Test that multiple send streams can be created and deleted properly.
srtee0c2eea2017-12-15 17:44:33 +01002022TEST_F(WebRtcVideoChannelBaseTest, MultipleSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02002023 // Remove stream added in Setup. I.e. remove stream corresponding to default
2024 // channel.
2025 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02002026 const unsigned int kSsrcsSize = sizeof(kSsrcs4) / sizeof(kSsrcs4[0]);
Niels Möller6557d0c2018-04-11 15:18:34 +02002027 for (unsigned int i = 0; i < kSsrcsSize; ++i) {
2028 EXPECT_TRUE(channel_->AddSendStream(
2029 cricket::StreamParams::CreateLegacy(kSsrcs4[i])));
2030 }
2031 // Delete one of the non default channel streams, let the destructor delete
2032 // the remaining ones.
2033 EXPECT_TRUE(channel_->RemoveSendStream(kSsrcs4[kSsrcsSize - 1]));
2034 // Stream should already be deleted.
2035 EXPECT_FALSE(channel_->RemoveSendStream(kSsrcs4[kSsrcsSize - 1]));
srtee0c2eea2017-12-15 17:44:33 +01002036}
pbos@webrtc.orgc4175b92014-09-03 15:25:49 +00002037
eladalonf1841382017-06-12 01:16:46 -07002038TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8Vga) {
magjed509e4fe2016-11-18 01:34:11 -08002039 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00002040}
2041
eladalonf1841382017-06-12 01:16:46 -07002042TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8Qvga) {
magjed509e4fe2016-11-18 01:34:11 -08002043 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00002044}
2045
eladalonf1841382017-06-12 01:16:46 -07002046TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8SvcQqvga) {
magjed509e4fe2016-11-18 01:34:11 -08002047 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00002048}
2049
eladalonf1841382017-06-12 01:16:46 -07002050TEST_F(WebRtcVideoChannelBaseTest, TwoStreamsSendAndReceive) {
Peter Boströmd1f584b2016-04-20 16:31:53 +02002051 // Set a high bitrate to not be downscaled by VP8 due to low initial start
2052 // bitrates. This currently happens at <250k, and two streams sharing 300k
2053 // initially will use QVGA instead of VGA.
2054 // TODO(pbos): Set up the quality scaler so that both senders reliably start
2055 // at QVGA, then verify that instead.
magjed509e4fe2016-11-18 01:34:11 -08002056 cricket::VideoCodec codec = GetEngineCodec("VP8");
Peter Boströmd1f584b2016-04-20 16:31:53 +02002057 codec.params[kCodecParamStartBitrate] = "1000000";
Niels Möller6557d0c2018-04-11 15:18:34 +02002058 TwoStreamsSendAndReceive(codec);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002059}
2060
eladalonf1841382017-06-12 01:16:46 -07002061class WebRtcVideoChannelTest : public WebRtcVideoEngineTest {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002062 public:
eladalonf1841382017-06-12 01:16:46 -07002063 WebRtcVideoChannelTest() : WebRtcVideoChannelTest("") {}
2064 explicit WebRtcVideoChannelTest(const char* field_trials)
Niels Möller805a27e2019-01-21 12:21:27 +01002065 : WebRtcVideoEngineTest(field_trials),
2066 frame_source_(1280, 720, rtc::kNumMicrosecsPerSec / 30),
2067 last_ssrc_(0) {}
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00002068 void SetUp() override {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02002069 encoder_factory_->AddSupportedVideoCodecType("VP8");
2070 encoder_factory_->AddSupportedVideoCodecType("VP9");
2071#if defined(WEBRTC_USE_H264)
2072 encoder_factory_->AddSupportedVideoCodecType("H264");
2073#endif
2074
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002075 fake_call_.reset(new FakeCall());
Sebastian Jansson84848f22018-11-16 10:40:36 +01002076 channel_.reset(engine_.CreateMediaChannel(fake_call_.get(),
2077 GetMediaConfig(), VideoOptions(),
2078 webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002079 channel_->OnReadyToSend(true);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002080 last_ssrc_ = 123;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002081 send_parameters_.codecs = engine_.codecs();
2082 recv_parameters_.codecs = engine_.codecs();
2083 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002084 }
2085
2086 protected:
2087 FakeVideoSendStream* AddSendStream() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002088 return AddSendStream(StreamParams::CreateLegacy(++last_ssrc_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002089 }
2090
2091 FakeVideoSendStream* AddSendStream(const StreamParams& sp) {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002092 size_t num_streams = fake_call_->GetVideoSendStreams().size();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002093 EXPECT_TRUE(channel_->AddSendStream(sp));
2094 std::vector<FakeVideoSendStream*> streams =
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002095 fake_call_->GetVideoSendStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002096 EXPECT_EQ(num_streams + 1, streams.size());
2097 return streams[streams.size() - 1];
2098 }
2099
2100 std::vector<FakeVideoSendStream*> GetFakeSendStreams() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002101 return fake_call_->GetVideoSendStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002102 }
2103
2104 FakeVideoReceiveStream* AddRecvStream() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002105 return AddRecvStream(StreamParams::CreateLegacy(++last_ssrc_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002106 }
2107
2108 FakeVideoReceiveStream* AddRecvStream(const StreamParams& sp) {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002109 size_t num_streams = fake_call_->GetVideoReceiveStreams().size();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002110 EXPECT_TRUE(channel_->AddRecvStream(sp));
2111 std::vector<FakeVideoReceiveStream*> streams =
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002112 fake_call_->GetVideoReceiveStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002113 EXPECT_EQ(num_streams + 1, streams.size());
2114 return streams[streams.size() - 1];
2115 }
2116
pbos@webrtc.org00873182014-11-25 14:03:34 +00002117 void SetSendCodecsShouldWorkForBitrates(const char* min_bitrate_kbps,
2118 int expected_min_bitrate_bps,
2119 const char* start_bitrate_kbps,
2120 int expected_start_bitrate_bps,
2121 const char* max_bitrate_kbps,
2122 int expected_max_bitrate_bps) {
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002123 ExpectSetBitrateParameters(expected_min_bitrate_bps,
2124 expected_start_bitrate_bps,
2125 expected_max_bitrate_bps);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002126 auto& codecs = send_parameters_.codecs;
2127 codecs.clear();
magjed509e4fe2016-11-18 01:34:11 -08002128 codecs.push_back(GetEngineCodec("VP8"));
pbos@webrtc.org00873182014-11-25 14:03:34 +00002129 codecs[0].params[kCodecParamMinBitrate] = min_bitrate_kbps;
2130 codecs[0].params[kCodecParamStartBitrate] = start_bitrate_kbps;
2131 codecs[0].params[kCodecParamMaxBitrate] = max_bitrate_kbps;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002132 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002133 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002134
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002135 void ExpectSetBitrateParameters(int min_bitrate_bps,
2136 int start_bitrate_bps,
2137 int max_bitrate_bps) {
2138 EXPECT_CALL(
2139 *fake_call_->GetMockTransportControllerSend(),
2140 SetSdpBitrateParameters(AllOf(
2141 Field(&BitrateConstraints::min_bitrate_bps, min_bitrate_bps),
2142 Field(&BitrateConstraints::start_bitrate_bps, start_bitrate_bps),
2143 Field(&BitrateConstraints::max_bitrate_bps, max_bitrate_bps))));
2144 }
2145
2146 void ExpectSetMaxBitrate(int max_bitrate_bps) {
2147 EXPECT_CALL(*fake_call_->GetMockTransportControllerSend(),
2148 SetSdpBitrateParameters(Field(
2149 &BitrateConstraints::max_bitrate_bps, max_bitrate_bps)));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002150 }
2151
Johannes Kron9190b822018-10-29 11:22:05 +01002152 void TestExtmapAllowMixedCaller(bool extmap_allow_mixed) {
2153 // For a caller, the answer will be applied in set remote description
2154 // where SetSendParameters() is called.
2155 EXPECT_TRUE(
2156 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
2157 send_parameters_.extmap_allow_mixed = extmap_allow_mixed;
2158 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
2159 const webrtc::VideoSendStream::Config& config =
2160 fake_call_->GetVideoSendStreams()[0]->GetConfig();
2161 EXPECT_EQ(extmap_allow_mixed, config.rtp.extmap_allow_mixed);
2162 }
2163
2164 void TestExtmapAllowMixedCallee(bool extmap_allow_mixed) {
2165 // For a callee, the answer will be applied in set local description
2166 // where SetExtmapAllowMixed() and AddSendStream() are called.
2167 channel_->SetExtmapAllowMixed(extmap_allow_mixed);
2168 EXPECT_TRUE(
2169 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
2170 const webrtc::VideoSendStream::Config& config =
2171 fake_call_->GetVideoSendStreams()[0]->GetConfig();
2172 EXPECT_EQ(extmap_allow_mixed, config.rtp.extmap_allow_mixed);
2173 }
2174
isheriff6f8d6862016-05-26 11:24:55 -07002175 void TestSetSendRtpHeaderExtensions(const std::string& ext_uri) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002176 // Enable extension.
2177 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002178 cricket::VideoSendParameters parameters = send_parameters_;
isheriff6f8d6862016-05-26 11:24:55 -07002179 parameters.extensions.push_back(RtpExtension(ext_uri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002180 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002181 FakeVideoSendStream* send_stream =
2182 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2183
2184 // Verify the send extension id.
2185 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2186 EXPECT_EQ(id, send_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002187 EXPECT_EQ(ext_uri, send_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002188 // Verify call with same set of extensions returns true.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002189 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002190 // Verify that SetSendRtpHeaderExtensions doesn't implicitly add them for
2191 // receivers.
2192 EXPECT_TRUE(AddRecvStream(cricket::StreamParams::CreateLegacy(123))
2193 ->GetConfig()
2194 .rtp.extensions.empty());
2195
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002196 // Verify that existing RTP header extensions can be removed.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002197 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002198 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2199 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002200 EXPECT_TRUE(send_stream->GetConfig().rtp.extensions.empty());
2201
2202 // Verify that adding receive RTP header extensions adds them for existing
2203 // streams.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002204 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002205 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002206 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2207 EXPECT_EQ(id, send_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002208 EXPECT_EQ(ext_uri, send_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002209 }
2210
isheriff6f8d6862016-05-26 11:24:55 -07002211 void TestSetRecvRtpHeaderExtensions(const std::string& ext_uri) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002212 // Enable extension.
2213 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002214 cricket::VideoRecvParameters parameters = recv_parameters_;
isheriff6f8d6862016-05-26 11:24:55 -07002215 parameters.extensions.push_back(RtpExtension(ext_uri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002216 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002217
2218 FakeVideoReceiveStream* recv_stream =
2219 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2220
2221 // Verify the recv extension id.
2222 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
2223 EXPECT_EQ(id, recv_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002224 EXPECT_EQ(ext_uri, recv_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002225 // Verify call with same set of extensions returns true.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002226 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002227
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002228 // Verify that SetRecvRtpHeaderExtensions doesn't implicitly add them for
2229 // senders.
2230 EXPECT_TRUE(AddSendStream(cricket::StreamParams::CreateLegacy(123))
2231 ->GetConfig()
2232 .rtp.extensions.empty());
2233
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002234 // Verify that existing RTP header extensions can be removed.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002235 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002236 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
2237 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002238 EXPECT_TRUE(recv_stream->GetConfig().rtp.extensions.empty());
2239
2240 // Verify that adding receive RTP header extensions adds them for existing
2241 // streams.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002242 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002243 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002244 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
2245 EXPECT_EQ(id, recv_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002246 EXPECT_EQ(ext_uri, recv_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002247 }
2248
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002249 void TestExtensionFilter(const std::vector<std::string>& extensions,
2250 const std::string& expected_extension) {
2251 cricket::VideoSendParameters parameters = send_parameters_;
2252 int expected_id = -1;
2253 int id = 1;
2254 for (const std::string& extension : extensions) {
2255 if (extension == expected_extension)
2256 expected_id = id;
isheriff6f8d6862016-05-26 11:24:55 -07002257 parameters.extensions.push_back(RtpExtension(extension, id++));
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002258 }
2259 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2260 FakeVideoSendStream* send_stream =
2261 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2262
2263 // Verify that only one of them has been set, and that it is the one with
2264 // highest priority (transport sequence number).
2265 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2266 EXPECT_EQ(expected_id, send_stream->GetConfig().rtp.extensions[0].id);
2267 EXPECT_EQ(expected_extension,
isheriff6f8d6862016-05-26 11:24:55 -07002268 send_stream->GetConfig().rtp.extensions[0].uri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002269 }
2270
asapersson3c81a1a2017-06-14 05:52:21 -07002271 void TestDegradationPreference(bool resolution_scaling_enabled,
2272 bool fps_scaling_enabled);
2273
Erik Språngefbde372015-04-29 16:21:28 +02002274 void TestCpuAdaptation(bool enable_overuse, bool is_screenshare);
Peter Boström3548dd22015-05-22 18:48:36 +02002275 void TestReceiverLocalSsrcConfiguration(bool receiver_first);
magjed509e4fe2016-11-18 01:34:11 -08002276 void TestReceiveUnsignaledSsrcPacket(uint8_t payload_type,
2277 bool expect_created_receive_stream);
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002278
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002279 FakeVideoSendStream* SetDenoisingOption(
nisse05103312016-03-16 02:22:50 -07002280 uint32_t ssrc,
Niels Möller805a27e2019-01-21 12:21:27 +01002281 webrtc::test::FrameForwarder* frame_forwarder,
nisse0db023a2016-03-01 04:29:59 -08002282 bool enabled) {
nisse05103312016-03-16 02:22:50 -07002283 cricket::VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002284 options.video_noise_reduction = enabled;
Niels Möller805a27e2019-01-21 12:21:27 +01002285 EXPECT_TRUE(channel_->SetVideoSend(ssrc, &options, frame_forwarder));
nisse0db023a2016-03-01 04:29:59 -08002286 // Options only take effect on the next frame.
Niels Möller805a27e2019-01-21 12:21:27 +01002287 frame_forwarder->IncomingCapturedFrame(frame_source_.GetFrame());
nisse0db023a2016-03-01 04:29:59 -08002288
Erik Språng143cec12015-04-28 10:01:41 +02002289 return fake_call_->GetVideoSendStreams().back();
2290 }
2291
Peter Boström2feafdb2015-09-09 14:32:14 +02002292 FakeVideoSendStream* SetUpSimulcast(bool enabled, bool with_rtx) {
2293 const int kRtxSsrcOffset = 0xDEADBEEF;
Erik Språng143cec12015-04-28 10:01:41 +02002294 last_ssrc_ += 3;
Peter Boström2feafdb2015-09-09 14:32:14 +02002295 std::vector<uint32_t> ssrcs;
2296 std::vector<uint32_t> rtx_ssrcs;
2297 uint32_t num_streams = enabled ? 3 : 1;
2298 for (uint32_t i = 0; i < num_streams; ++i) {
2299 uint32_t ssrc = last_ssrc_ + i;
2300 ssrcs.push_back(ssrc);
2301 if (with_rtx) {
2302 rtx_ssrcs.push_back(ssrc + kRtxSsrcOffset);
2303 }
Erik Språng143cec12015-04-28 10:01:41 +02002304 }
Peter Boström2feafdb2015-09-09 14:32:14 +02002305 if (with_rtx) {
2306 return AddSendStream(
2307 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
2308 }
2309 return AddSendStream(CreateSimStreamParams("cname", ssrcs));
Erik Språng143cec12015-04-28 10:01:41 +02002310 }
2311
perkjfa10b552016-10-02 23:45:26 -07002312 int GetMaxEncoderBitrate() {
skvladdc1c62c2016-03-16 19:07:43 -07002313 std::vector<FakeVideoSendStream*> streams =
2314 fake_call_->GetVideoSendStreams();
perkjfa10b552016-10-02 23:45:26 -07002315 EXPECT_EQ(1u, streams.size());
skvladdc1c62c2016-03-16 19:07:43 -07002316 FakeVideoSendStream* stream = streams[streams.size() - 1];
Mirko Bonadeif859e552018-05-30 15:31:29 +02002317 EXPECT_EQ(1u, stream->GetEncoderConfig().number_of_streams);
perkjfa10b552016-10-02 23:45:26 -07002318 return stream->GetVideoStreams()[0].max_bitrate_bps;
skvladdc1c62c2016-03-16 19:07:43 -07002319 }
2320
perkjfa10b552016-10-02 23:45:26 -07002321 void SetAndExpectMaxBitrate(int global_max,
skvladdc1c62c2016-03-16 19:07:43 -07002322 int stream_max,
2323 int expected_encoder_bitrate) {
2324 VideoSendParameters limited_send_params = send_parameters_;
2325 limited_send_params.max_bandwidth_bps = global_max;
2326 EXPECT_TRUE(channel_->SetSendParameters(limited_send_params));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07002327 webrtc::RtpParameters parameters =
2328 channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07002329 EXPECT_EQ(1UL, parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01002330 parameters.encodings[0].max_bitrate_bps = stream_max;
Zach Steinba37b4b2018-01-23 15:02:36 -08002331 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07002332 // Read back the parameteres and verify they have the correct value
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07002333 parameters = channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07002334 EXPECT_EQ(1UL, parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01002335 EXPECT_EQ(stream_max, parameters.encodings[0].max_bitrate_bps);
skvladdc1c62c2016-03-16 19:07:43 -07002336 // Verify that the new value propagated down to the encoder
perkjfa10b552016-10-02 23:45:26 -07002337 EXPECT_EQ(expected_encoder_bitrate, GetMaxEncoderBitrate());
skvladdc1c62c2016-03-16 19:07:43 -07002338 }
2339
Åsa Persson55659812018-06-18 17:51:32 +02002340 // Values from kSimulcastConfigs in simulcast.cc.
2341 const std::vector<webrtc::VideoStream> GetSimulcastBitrates720p() const {
2342 std::vector<webrtc::VideoStream> layers(3);
2343 layers[0].min_bitrate_bps = 30000;
2344 layers[0].target_bitrate_bps = 150000;
2345 layers[0].max_bitrate_bps = 200000;
2346 layers[1].min_bitrate_bps = 150000;
2347 layers[1].target_bitrate_bps = 500000;
2348 layers[1].max_bitrate_bps = 700000;
2349 layers[2].min_bitrate_bps = 600000;
2350 layers[2].target_bitrate_bps = 2500000;
2351 layers[2].max_bitrate_bps = 2500000;
2352 return layers;
2353 }
2354
Niels Möller805a27e2019-01-21 12:21:27 +01002355 cricket::FakeFrameSource frame_source_;
kwiberg686a8ef2016-02-26 03:00:35 -08002356 std::unique_ptr<FakeCall> fake_call_;
2357 std::unique_ptr<VideoMediaChannel> channel_;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002358 cricket::VideoSendParameters send_parameters_;
2359 cricket::VideoRecvParameters recv_parameters_;
Peter Boström0c4e06b2015-10-07 12:23:21 +02002360 uint32_t last_ssrc_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002361};
2362
eladalonf1841382017-06-12 01:16:46 -07002363TEST_F(WebRtcVideoChannelTest, SetsSyncGroupFromSyncLabel) {
Peter Boström0c4e06b2015-10-07 12:23:21 +02002364 const uint32_t kVideoSsrc = 123;
pbos8fc7fa72015-07-15 08:02:58 -07002365 const std::string kSyncLabel = "AvSyncLabel";
2366
2367 cricket::StreamParams sp = cricket::StreamParams::CreateLegacy(kVideoSsrc);
Seth Hampson845e8782018-03-02 11:34:10 -08002368 sp.set_stream_ids({kSyncLabel});
pbos8fc7fa72015-07-15 08:02:58 -07002369 EXPECT_TRUE(channel_->AddRecvStream(sp));
2370
Mirko Bonadeif859e552018-05-30 15:31:29 +02002371 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
pbos8fc7fa72015-07-15 08:02:58 -07002372 EXPECT_EQ(kSyncLabel,
2373 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group)
2374 << "SyncGroup should be set based on sync_label";
2375}
2376
eladalonf1841382017-06-12 01:16:46 -07002377TEST_F(WebRtcVideoChannelTest, RecvStreamWithSimAndRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002378 cricket::VideoSendParameters parameters;
2379 parameters.codecs = engine_.codecs();
2380 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002381 EXPECT_TRUE(channel_->SetSend(true));
nisse4b4dc862016-02-17 05:25:36 -08002382 parameters.conference_mode = true;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002383 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002384
2385 // Send side.
Peter Boström0c4e06b2015-10-07 12:23:21 +02002386 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
2387 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002388 FakeVideoSendStream* send_stream = AddSendStream(
2389 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
2390
2391 ASSERT_EQ(rtx_ssrcs.size(), send_stream->GetConfig().rtp.rtx.ssrcs.size());
2392 for (size_t i = 0; i < rtx_ssrcs.size(); ++i)
2393 EXPECT_EQ(rtx_ssrcs[i], send_stream->GetConfig().rtp.rtx.ssrcs[i]);
2394
2395 // Receiver side.
2396 FakeVideoReceiveStream* recv_stream = AddRecvStream(
2397 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
nisse26e3abb2017-08-25 04:44:25 -07002398 EXPECT_FALSE(
2399 recv_stream->GetConfig().rtp.rtx_associated_payload_types.empty());
nisseca5706d2017-09-11 02:32:16 -07002400 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
Peter Boströmd8b01092016-05-12 16:44:36 +02002401 << "RTX should be mapped for all decoders/payload types.";
nisseca5706d2017-09-11 02:32:16 -07002402 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02002403 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07002404 << "RTX should be mapped for the RED payload type";
2405
brandtr14742122017-01-27 04:53:07 -08002406 EXPECT_EQ(rtx_ssrcs[0], recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002407}
2408
eladalonf1841382017-06-12 01:16:46 -07002409TEST_F(WebRtcVideoChannelTest, RecvStreamWithRtx) {
pbos@webrtc.orge322a172014-06-13 11:47:28 +00002410 // Setup one channel with an associated RTX stream.
2411 cricket::StreamParams params =
2412 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
2413 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
2414 FakeVideoReceiveStream* recv_stream = AddRecvStream(params);
brandtr14742122017-01-27 04:53:07 -08002415 EXPECT_EQ(kRtxSsrcs1[0], recv_stream->GetConfig().rtp.rtx_ssrc);
nisseca5706d2017-09-11 02:32:16 -07002416
2417 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
2418 << "RTX should be mapped for all decoders/payload types.";
2419 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02002420 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07002421 << "RTX should be mapped for the RED payload type";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002422}
2423
eladalonf1841382017-06-12 01:16:46 -07002424TEST_F(WebRtcVideoChannelTest, RecvStreamNoRtx) {
pbos@webrtc.orge322a172014-06-13 11:47:28 +00002425 // Setup one channel without an associated RTX stream.
2426 cricket::StreamParams params =
2427 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
2428 FakeVideoReceiveStream* recv_stream = AddRecvStream(params);
brandtr14742122017-01-27 04:53:07 -08002429 ASSERT_EQ(0U, recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002430}
2431
Johannes Kron9190b822018-10-29 11:22:05 +01002432// Test propagation of extmap allow mixed setting.
2433TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedAsCaller) {
2434 TestExtmapAllowMixedCaller(/*extmap_allow_mixed=*/true);
2435}
2436TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedDisabledAsCaller) {
2437 TestExtmapAllowMixedCaller(/*extmap_allow_mixed=*/false);
2438}
2439TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedAsCallee) {
2440 TestExtmapAllowMixedCallee(/*extmap_allow_mixed=*/true);
2441}
2442TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedDisabledAsCallee) {
2443 TestExtmapAllowMixedCallee(/*extmap_allow_mixed=*/false);
2444}
2445
eladalonf1841382017-06-12 01:16:46 -07002446TEST_F(WebRtcVideoChannelTest, NoHeaderExtesionsByDefault) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002447 FakeVideoSendStream* send_stream =
2448 AddSendStream(cricket::StreamParams::CreateLegacy(kSsrcs1[0]));
2449 ASSERT_TRUE(send_stream->GetConfig().rtp.extensions.empty());
2450
2451 FakeVideoReceiveStream* recv_stream =
2452 AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrcs1[0]));
2453 ASSERT_TRUE(recv_stream->GetConfig().rtp.extensions.empty());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002454}
2455
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002456// Test support for RTP timestamp offset header extension.
eladalonf1841382017-06-12 01:16:46 -07002457TEST_F(WebRtcVideoChannelTest, SendRtpTimestampOffsetHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002458 TestSetSendRtpHeaderExtensions(RtpExtension::kTimestampOffsetUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002459}
isheriff6f8d6862016-05-26 11:24:55 -07002460
eladalonf1841382017-06-12 01:16:46 -07002461TEST_F(WebRtcVideoChannelTest, RecvRtpTimestampOffsetHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002462 TestSetRecvRtpHeaderExtensions(RtpExtension::kTimestampOffsetUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002463}
2464
2465// Test support for absolute send time header extension.
eladalonf1841382017-06-12 01:16:46 -07002466TEST_F(WebRtcVideoChannelTest, SendAbsoluteSendTimeHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002467 TestSetSendRtpHeaderExtensions(RtpExtension::kAbsSendTimeUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002468}
isheriff6f8d6862016-05-26 11:24:55 -07002469
eladalonf1841382017-06-12 01:16:46 -07002470TEST_F(WebRtcVideoChannelTest, RecvAbsoluteSendTimeHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002471 TestSetRecvRtpHeaderExtensions(RtpExtension::kAbsSendTimeUri);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002472}
2473
eladalonf1841382017-06-12 01:16:46 -07002474TEST_F(WebRtcVideoChannelTest, FiltersExtensionsPicksTransportSeqNum) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002475 // Enable three redundant extensions.
2476 std::vector<std::string> extensions;
isheriff6f8d6862016-05-26 11:24:55 -07002477 extensions.push_back(RtpExtension::kAbsSendTimeUri);
2478 extensions.push_back(RtpExtension::kTimestampOffsetUri);
2479 extensions.push_back(RtpExtension::kTransportSequenceNumberUri);
2480 TestExtensionFilter(extensions, RtpExtension::kTransportSequenceNumberUri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002481}
2482
eladalonf1841382017-06-12 01:16:46 -07002483TEST_F(WebRtcVideoChannelTest, FiltersExtensionsPicksAbsSendTime) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002484 // Enable two redundant extensions.
2485 std::vector<std::string> extensions;
isheriff6f8d6862016-05-26 11:24:55 -07002486 extensions.push_back(RtpExtension::kAbsSendTimeUri);
2487 extensions.push_back(RtpExtension::kTimestampOffsetUri);
2488 TestExtensionFilter(extensions, RtpExtension::kAbsSendTimeUri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002489}
2490
stefanc1aeaf02015-10-15 07:26:07 -07002491// Test support for transport sequence number header extension.
eladalonf1841382017-06-12 01:16:46 -07002492TEST_F(WebRtcVideoChannelTest, SendTransportSequenceNumberHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002493 TestSetSendRtpHeaderExtensions(RtpExtension::kTransportSequenceNumberUri);
stefanc1aeaf02015-10-15 07:26:07 -07002494}
eladalonf1841382017-06-12 01:16:46 -07002495TEST_F(WebRtcVideoChannelTest, RecvTransportSequenceNumberHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002496 TestSetRecvRtpHeaderExtensions(RtpExtension::kTransportSequenceNumberUri);
stefanc1aeaf02015-10-15 07:26:07 -07002497}
2498
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002499// Test support for video rotation header extension.
eladalonf1841382017-06-12 01:16:46 -07002500TEST_F(WebRtcVideoChannelTest, SendVideoRotationHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002501 TestSetSendRtpHeaderExtensions(RtpExtension::kVideoRotationUri);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002502}
eladalonf1841382017-06-12 01:16:46 -07002503TEST_F(WebRtcVideoChannelTest, RecvVideoRotationHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002504 TestSetRecvRtpHeaderExtensions(RtpExtension::kVideoRotationUri);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002505}
2506
eladalonf1841382017-06-12 01:16:46 -07002507TEST_F(WebRtcVideoChannelTest, IdenticalSendExtensionsDoesntRecreateStream) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002508 const int kAbsSendTimeId = 1;
2509 const int kVideoRotationId = 2;
isheriff6f8d6862016-05-26 11:24:55 -07002510 send_parameters_.extensions.push_back(
2511 RtpExtension(RtpExtension::kAbsSendTimeUri, kAbsSendTimeId));
2512 send_parameters_.extensions.push_back(
2513 RtpExtension(RtpExtension::kVideoRotationUri, kVideoRotationId));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002514
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002515 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002516 FakeVideoSendStream* send_stream =
2517 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2518
2519 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002520 ASSERT_EQ(2u, send_stream->GetConfig().rtp.extensions.size());
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002521
2522 // Setting the same extensions (even if in different order) shouldn't
2523 // reallocate the stream.
Steve Anton2c9ebef2019-01-28 17:27:58 -08002524 absl::c_reverse(send_parameters_.extensions);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002525 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002526
2527 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
2528
2529 // Setting different extensions should recreate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002530 send_parameters_.extensions.resize(1);
2531 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002532
2533 EXPECT_EQ(2, fake_call_->GetNumCreatedSendStreams());
2534}
2535
eladalonf1841382017-06-12 01:16:46 -07002536TEST_F(WebRtcVideoChannelTest, IdenticalRecvExtensionsDoesntRecreateStream) {
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002537 const int kTOffsetId = 1;
2538 const int kAbsSendTimeId = 2;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002539 const int kVideoRotationId = 3;
isheriff6f8d6862016-05-26 11:24:55 -07002540 recv_parameters_.extensions.push_back(
2541 RtpExtension(RtpExtension::kAbsSendTimeUri, kAbsSendTimeId));
2542 recv_parameters_.extensions.push_back(
2543 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
2544 recv_parameters_.extensions.push_back(
2545 RtpExtension(RtpExtension::kVideoRotationUri, kVideoRotationId));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002546
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002547 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
Peter Boström54be3e02015-05-25 15:04:24 +02002548 FakeVideoReceiveStream* recv_stream =
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002549 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2550
2551 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
Peter Boström54be3e02015-05-25 15:04:24 +02002552 ASSERT_EQ(3u, recv_stream->GetConfig().rtp.extensions.size());
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002553
2554 // Setting the same extensions (even if in different order) shouldn't
2555 // reallocate the stream.
Steve Anton2c9ebef2019-01-28 17:27:58 -08002556 absl::c_reverse(recv_parameters_.extensions);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002557 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002558
2559 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
2560
2561 // Setting different extensions should recreate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002562 recv_parameters_.extensions.resize(1);
2563 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002564
2565 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams());
2566}
2567
eladalonf1841382017-06-12 01:16:46 -07002568TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002569 SetSendRtpHeaderExtensionsExcludeUnsupportedExtensions) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002570 const int kUnsupportedId = 1;
2571 const int kTOffsetId = 2;
2572
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002573 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002574 RtpExtension(kUnsupportedExtensionName, kUnsupportedId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002575 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002576 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002577 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002578 FakeVideoSendStream* send_stream =
2579 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2580
2581 // Only timestamp offset extension is set to send stream,
2582 // unsupported rtp extension is ignored.
2583 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
isheriff6f8d6862016-05-26 11:24:55 -07002584 EXPECT_STREQ(RtpExtension::kTimestampOffsetUri,
2585 send_stream->GetConfig().rtp.extensions[0].uri.c_str());
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002586}
2587
eladalonf1841382017-06-12 01:16:46 -07002588TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002589 SetRecvRtpHeaderExtensionsExcludeUnsupportedExtensions) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002590 const int kUnsupportedId = 1;
2591 const int kTOffsetId = 2;
2592
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002593 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002594 RtpExtension(kUnsupportedExtensionName, kUnsupportedId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002595 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002596 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002597 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002598 FakeVideoReceiveStream* recv_stream =
2599 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2600
2601 // Only timestamp offset extension is set to receive stream,
2602 // unsupported rtp extension is ignored.
2603 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
isheriff6f8d6862016-05-26 11:24:55 -07002604 EXPECT_STREQ(RtpExtension::kTimestampOffsetUri,
2605 recv_stream->GetConfig().rtp.extensions[0].uri.c_str());
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002606}
2607
eladalonf1841382017-06-12 01:16:46 -07002608TEST_F(WebRtcVideoChannelTest, SetSendRtpHeaderExtensionsRejectsIncorrectIds) {
Peter Boström23914fe2015-03-31 15:08:04 +02002609 const int kIncorrectIds[] = {-2, -1, 0, 15, 16};
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00002610 for (size_t i = 0; i < arraysize(kIncorrectIds); ++i) {
isheriff6f8d6862016-05-26 11:24:55 -07002611 send_parameters_.extensions.push_back(
2612 RtpExtension(RtpExtension::kTimestampOffsetUri, kIncorrectIds[i]));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002613 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_))
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002614 << "Bad extension id '" << kIncorrectIds[i] << "' accepted.";
2615 }
2616}
2617
eladalonf1841382017-06-12 01:16:46 -07002618TEST_F(WebRtcVideoChannelTest, SetRecvRtpHeaderExtensionsRejectsIncorrectIds) {
Peter Boström23914fe2015-03-31 15:08:04 +02002619 const int kIncorrectIds[] = {-2, -1, 0, 15, 16};
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00002620 for (size_t i = 0; i < arraysize(kIncorrectIds); ++i) {
isheriff6f8d6862016-05-26 11:24:55 -07002621 recv_parameters_.extensions.push_back(
2622 RtpExtension(RtpExtension::kTimestampOffsetUri, kIncorrectIds[i]));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002623 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_))
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002624 << "Bad extension id '" << kIncorrectIds[i] << "' accepted.";
2625 }
2626}
2627
eladalonf1841382017-06-12 01:16:46 -07002628TEST_F(WebRtcVideoChannelTest, SetSendRtpHeaderExtensionsRejectsDuplicateIds) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002629 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002630 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002631 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002632 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002633 RtpExtension(RtpExtension::kAbsSendTimeUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002634 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002635
2636 // Duplicate entries are also not supported.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002637 send_parameters_.extensions.clear();
2638 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002639 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002640 send_parameters_.extensions.push_back(send_parameters_.extensions.back());
2641 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002642}
2643
eladalonf1841382017-06-12 01:16:46 -07002644TEST_F(WebRtcVideoChannelTest, SetRecvRtpHeaderExtensionsRejectsDuplicateIds) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002645 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002646 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002647 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002648 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002649 RtpExtension(RtpExtension::kAbsSendTimeUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002650 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002651
2652 // Duplicate entries are also not supported.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002653 recv_parameters_.extensions.clear();
2654 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002655 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002656 recv_parameters_.extensions.push_back(recv_parameters_.extensions.back());
2657 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002658}
2659
eladalonf1841382017-06-12 01:16:46 -07002660TEST_F(WebRtcVideoChannelTest, AddRecvStreamOnlyUsesOneReceiveStream) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002661 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002662 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002663}
2664
eladalonf1841382017-06-12 01:16:46 -07002665TEST_F(WebRtcVideoChannelTest, RtcpIsCompoundByDefault) {
Peter Boströmd7da1202015-06-05 14:09:38 +02002666 FakeVideoReceiveStream* stream = AddRecvStream();
pbosda903ea2015-10-02 02:36:56 -07002667 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream->GetConfig().rtp.rtcp_mode);
Peter Boströmd7da1202015-06-05 14:09:38 +02002668}
2669
eladalonf1841382017-06-12 01:16:46 -07002670TEST_F(WebRtcVideoChannelTest, RembIsEnabledByDefault) {
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002671 FakeVideoReceiveStream* stream = AddRecvStream();
2672 EXPECT_TRUE(stream->GetConfig().rtp.remb);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002673}
2674
eladalonf1841382017-06-12 01:16:46 -07002675TEST_F(WebRtcVideoChannelTest, TransportCcIsEnabledByDefault) {
stefan43edf0f2015-11-20 18:05:48 -08002676 FakeVideoReceiveStream* stream = AddRecvStream();
2677 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2678}
2679
eladalonf1841382017-06-12 01:16:46 -07002680TEST_F(WebRtcVideoChannelTest, RembCanBeEnabledAndDisabled) {
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002681 FakeVideoReceiveStream* stream = AddRecvStream();
2682 EXPECT_TRUE(stream->GetConfig().rtp.remb);
2683
Peter Boström126c03e2015-05-11 12:48:12 +02002684 // Verify that REMB is turned off when send(!) codecs without REMB are set.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002685 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002686 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002687 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2688 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002689 stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002690 EXPECT_FALSE(stream->GetConfig().rtp.remb);
2691
2692 // Verify that REMB is turned on when setting default codecs since the
2693 // default codecs have REMB enabled.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002694 parameters.codecs = engine_.codecs();
2695 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002696 stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002697 EXPECT_TRUE(stream->GetConfig().rtp.remb);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002698}
2699
eladalonf1841382017-06-12 01:16:46 -07002700TEST_F(WebRtcVideoChannelTest, TransportCcCanBeEnabledAndDisabled) {
stefan43edf0f2015-11-20 18:05:48 -08002701 FakeVideoReceiveStream* stream = AddRecvStream();
2702 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2703
2704 // Verify that transport cc feedback is turned off when send(!) codecs without
2705 // transport cc feedback are set.
2706 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002707 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
stefan43edf0f2015-11-20 18:05:48 -08002708 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2709 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2710 stream = fake_call_->GetVideoReceiveStreams()[0];
2711 EXPECT_FALSE(stream->GetConfig().rtp.transport_cc);
2712
2713 // Verify that transport cc feedback is turned on when setting default codecs
2714 // since the default codecs have transport cc feedback enabled.
2715 parameters.codecs = engine_.codecs();
2716 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2717 stream = fake_call_->GetVideoReceiveStreams()[0];
2718 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2719}
2720
eladalonf1841382017-06-12 01:16:46 -07002721TEST_F(WebRtcVideoChannelTest, NackIsEnabledByDefault) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02002722 AssignDefaultCodec();
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002723 VerifyCodecHasDefaultFeedbackParams(default_codec_);
2724
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002725 cricket::VideoSendParameters parameters;
2726 parameters.codecs = engine_.codecs();
2727 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org19864742014-05-30 07:35:47 +00002728 EXPECT_TRUE(channel_->SetSend(true));
2729
2730 // Send side.
2731 FakeVideoSendStream* send_stream =
2732 AddSendStream(cricket::StreamParams::CreateLegacy(1));
2733 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2734
2735 // Receiver side.
2736 FakeVideoReceiveStream* recv_stream =
2737 AddRecvStream(cricket::StreamParams::CreateLegacy(1));
2738 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2739
2740 // Nack history size should match between sender and receiver.
2741 EXPECT_EQ(send_stream->GetConfig().rtp.nack.rtp_history_ms,
2742 recv_stream->GetConfig().rtp.nack.rtp_history_ms);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002743}
2744
eladalonf1841382017-06-12 01:16:46 -07002745TEST_F(WebRtcVideoChannelTest, NackCanBeEnabledAndDisabled) {
Peter Boström67c9df72015-05-11 14:34:58 +02002746 FakeVideoSendStream* send_stream = AddSendStream();
Peter Boström3548dd22015-05-22 18:48:36 +02002747 FakeVideoReceiveStream* recv_stream = AddRecvStream();
Peter Boström67c9df72015-05-11 14:34:58 +02002748
2749 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2750 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2751
2752 // Verify that NACK is turned off when send(!) codecs without NACK are set.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002753 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002754 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002755 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2756 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström67c9df72015-05-11 14:34:58 +02002757 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2758 EXPECT_EQ(0, recv_stream->GetConfig().rtp.nack.rtp_history_ms);
2759 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002760 EXPECT_EQ(0, send_stream->GetConfig().rtp.nack.rtp_history_ms);
2761
Peter Boström67c9df72015-05-11 14:34:58 +02002762 // Verify that NACK is turned on when setting default codecs since the
2763 // default codecs have NACK enabled.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002764 parameters.codecs = engine_.codecs();
2765 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström67c9df72015-05-11 14:34:58 +02002766 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2767 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2768 send_stream = fake_call_->GetVideoSendStreams()[0];
2769 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002770}
2771
Peter Boströme7ba0862016-03-12 00:02:28 +01002772// This test verifies that new frame sizes reconfigures encoders even though not
2773// (yet) sending. The purpose of this is to permit encoding as quickly as
2774// possible once we start sending. Likely the frames being input are from the
2775// same source that will be sent later, which just means that we're ready
2776// earlier.
eladalonf1841382017-06-12 01:16:46 -07002777TEST_F(WebRtcVideoChannelTest, ReconfiguresEncodersWhenNotSending) {
Peter Boströme7ba0862016-03-12 00:02:28 +01002778 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002779 parameters.codecs.push_back(GetEngineCodec("VP8"));
Peter Boströme7ba0862016-03-12 00:02:28 +01002780 ASSERT_TRUE(channel_->SetSendParameters(parameters));
2781 channel_->SetSend(false);
2782
2783 FakeVideoSendStream* stream = AddSendStream();
2784
perkjfa10b552016-10-02 23:45:26 -07002785 // No frames entered.
Peter Boströme7ba0862016-03-12 00:02:28 +01002786 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002787 EXPECT_EQ(0u, streams[0].width);
2788 EXPECT_EQ(0u, streams[0].height);
Peter Boströme7ba0862016-03-12 00:02:28 +01002789
Niels Möller805a27e2019-01-21 12:21:27 +01002790 webrtc::test::FrameForwarder frame_forwarder;
2791 cricket::FakeFrameSource frame_source(1280, 720,
2792 rtc::kNumMicrosecsPerSec / 30);
2793
2794 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
2795 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Peter Boströme7ba0862016-03-12 00:02:28 +01002796
2797 // Frame entered, should be reconfigured to new dimensions.
2798 streams = stream->GetVideoStreams();
Niels Möller805a27e2019-01-21 12:21:27 +01002799 EXPECT_EQ(rtc::checked_cast<size_t>(1280), streams[0].width);
2800 EXPECT_EQ(rtc::checked_cast<size_t>(720), streams[0].height);
Peter Boströme7ba0862016-03-12 00:02:28 +01002801
Niels Möllerff40b142018-04-09 08:49:14 +02002802 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boströme7ba0862016-03-12 00:02:28 +01002803}
2804
eladalonf1841382017-06-12 01:16:46 -07002805TEST_F(WebRtcVideoChannelTest, UsesCorrectSettingsForScreencast) {
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002806 static const int kScreenshareMinBitrateKbps = 800;
magjed509e4fe2016-11-18 01:34:11 -08002807 cricket::VideoCodec codec = GetEngineCodec("VP8");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002808 cricket::VideoSendParameters parameters;
2809 parameters.codecs.push_back(codec);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002810 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002811 AddSendStream();
2812
Niels Möller805a27e2019-01-21 12:21:27 +01002813 webrtc::test::FrameForwarder frame_forwarder;
2814 cricket::FakeFrameSource frame_source(1280, 720,
2815 rtc::kNumMicrosecsPerSec / 30);
nisse05103312016-03-16 02:22:50 -07002816 VideoOptions min_bitrate_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002817 min_bitrate_options.screencast_min_bitrate_kbps = kScreenshareMinBitrateKbps;
Niels Möller805a27e2019-01-21 12:21:27 +01002818 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &min_bitrate_options,
2819 &frame_forwarder));
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002820
2821 EXPECT_TRUE(channel_->SetSend(true));
2822
Niels Möller805a27e2019-01-21 12:21:27 +01002823 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002824 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2825 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
2826
2827 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
2828
2829 // Verify non-screencast settings.
perkj26091b12016-09-01 01:17:40 -07002830 webrtc::VideoEncoderConfig encoder_config =
2831 send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002832 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kRealtimeVideo,
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002833 encoder_config.content_type);
perkjfa10b552016-10-02 23:45:26 -07002834 std::vector<webrtc::VideoStream> streams = send_stream->GetVideoStreams();
Niels Möller805a27e2019-01-21 12:21:27 +01002835 EXPECT_EQ(rtc::checked_cast<size_t>(1280), streams.front().width);
2836 EXPECT_EQ(rtc::checked_cast<size_t>(720), streams.front().height);
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002837 EXPECT_EQ(0, encoder_config.min_transmit_bitrate_bps)
2838 << "Non-screenshare shouldn't use min-transmit bitrate.";
2839
Niels Möllerff40b142018-04-09 08:49:14 +02002840 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
perkjd533aec2017-01-13 05:57:25 -08002841 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
nisse05103312016-03-16 02:22:50 -07002842 VideoOptions screencast_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002843 screencast_options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01002844 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &screencast_options,
2845 &frame_forwarder));
2846 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
sprangf24a0642017-02-28 13:23:26 -08002847 // Send stream recreated after option change.
2848 ASSERT_EQ(2, fake_call_->GetNumCreatedSendStreams());
2849 send_stream = fake_call_->GetVideoSendStreams().front();
2850 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002851
2852 // Verify screencast settings.
perkj26091b12016-09-01 01:17:40 -07002853 encoder_config = send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002854 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kScreen,
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002855 encoder_config.content_type);
2856 EXPECT_EQ(kScreenshareMinBitrateKbps * 1000,
2857 encoder_config.min_transmit_bitrate_bps);
2858
perkjfa10b552016-10-02 23:45:26 -07002859 streams = send_stream->GetVideoStreams();
Niels Möller805a27e2019-01-21 12:21:27 +01002860 EXPECT_EQ(rtc::checked_cast<size_t>(1280), streams.front().width);
2861 EXPECT_EQ(rtc::checked_cast<size_t>(720), streams.front().height);
Sergey Silkina796a7e2018-03-01 15:11:29 +01002862 EXPECT_FALSE(streams[0].num_temporal_layers.has_value());
Niels Möllerff40b142018-04-09 08:49:14 +02002863 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002864}
2865
eladalonf1841382017-06-12 01:16:46 -07002866TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002867 ConferenceModeScreencastConfiguresTemporalLayer) {
Rasmus Brandt195d1d72018-05-09 11:28:01 +02002868 static const int kConferenceScreencastTemporalBitrateBps = 200 * 1000;
nisse4b4dc862016-02-17 05:25:36 -08002869 send_parameters_.conference_mode = true;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002870 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002871
2872 AddSendStream();
nisse05103312016-03-16 02:22:50 -07002873 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002874 options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01002875 webrtc::test::FrameForwarder frame_forwarder;
2876 cricket::FakeFrameSource frame_source(1280, 720,
2877 rtc::kNumMicrosecsPerSec / 30);
2878 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002879 EXPECT_TRUE(channel_->SetSend(true));
2880
Niels Möller805a27e2019-01-21 12:21:27 +01002881 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002882 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2883 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
2884
perkj26091b12016-09-01 01:17:40 -07002885 webrtc::VideoEncoderConfig encoder_config =
2886 send_stream->GetEncoderConfig().Copy();
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002887
2888 // Verify screencast settings.
perkj26091b12016-09-01 01:17:40 -07002889 encoder_config = send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002890 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kScreen,
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002891 encoder_config.content_type);
perkjfa10b552016-10-02 23:45:26 -07002892
2893 std::vector<webrtc::VideoStream> streams = send_stream->GetVideoStreams();
2894 ASSERT_EQ(1u, streams.size());
Sergey Silkina796a7e2018-03-01 15:11:29 +01002895 ASSERT_EQ(2u, streams[0].num_temporal_layers);
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002896 EXPECT_EQ(kConferenceScreencastTemporalBitrateBps,
Sergey Silkina796a7e2018-03-01 15:11:29 +01002897 streams[0].target_bitrate_bps);
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002898
Niels Möllerff40b142018-04-09 08:49:14 +02002899 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002900}
2901
eladalonf1841382017-06-12 01:16:46 -07002902TEST_F(WebRtcVideoChannelTest, SuspendBelowMinBitrateDisabledByDefault) {
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002903 FakeVideoSendStream* stream = AddSendStream();
2904 EXPECT_FALSE(stream->GetConfig().suspend_below_min_bitrate);
2905}
2906
eladalonf1841382017-06-12 01:16:46 -07002907TEST_F(WebRtcVideoChannelTest, SetMediaConfigSuspendBelowMinBitrate) {
kthelgason2bc68642017-02-07 07:02:22 -08002908 MediaConfig media_config = GetMediaConfig();
nisse0db023a2016-03-01 04:29:59 -08002909 media_config.video.suspend_below_min_bitrate = true;
2910
Sebastian Jansson84848f22018-11-16 10:40:36 +01002911 channel_.reset(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07002912 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002913 channel_->OnReadyToSend(true);
nisse0db023a2016-03-01 04:29:59 -08002914
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002915 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002916
2917 FakeVideoSendStream* stream = AddSendStream();
2918 EXPECT_TRUE(stream->GetConfig().suspend_below_min_bitrate);
2919
nisse0db023a2016-03-01 04:29:59 -08002920 media_config.video.suspend_below_min_bitrate = false;
Sebastian Jansson84848f22018-11-16 10:40:36 +01002921 channel_.reset(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07002922 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002923 channel_->OnReadyToSend(true);
nisse0db023a2016-03-01 04:29:59 -08002924
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002925 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002926
nisse0db023a2016-03-01 04:29:59 -08002927 stream = AddSendStream();
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002928 EXPECT_FALSE(stream->GetConfig().suspend_below_min_bitrate);
2929}
2930
eladalonf1841382017-06-12 01:16:46 -07002931TEST_F(WebRtcVideoChannelTest, Vp8DenoisingEnabledByDefault) {
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002932 FakeVideoSendStream* stream = AddSendStream();
2933 webrtc::VideoCodecVP8 vp8_settings;
2934 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2935 EXPECT_TRUE(vp8_settings.denoisingOn);
2936}
2937
eladalonf1841382017-06-12 01:16:46 -07002938TEST_F(WebRtcVideoChannelTest, VerifyVp8SpecificSettings) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002939 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002940 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002941 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002942
Peter Boström2feafdb2015-09-09 14:32:14 +02002943 // Single-stream settings should apply with RTX as well (verifies that we
2944 // check number of regular SSRCs and not StreamParams::ssrcs which contains
2945 // both RTX and regular SSRCs).
2946 FakeVideoSendStream* stream = SetUpSimulcast(false, true);
Erik Språng143cec12015-04-28 10:01:41 +02002947
Niels Möller805a27e2019-01-21 12:21:27 +01002948 webrtc::test::FrameForwarder frame_forwarder;
2949 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Erik Språng143cec12015-04-28 10:01:41 +02002950 channel_->SetSend(true);
2951
Niels Möller805a27e2019-01-21 12:21:27 +01002952 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Erik Språng143cec12015-04-28 10:01:41 +02002953
pbos4cba4eb2015-10-26 11:18:18 -07002954 webrtc::VideoCodecVP8 vp8_settings;
2955 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2956 EXPECT_TRUE(vp8_settings.denoisingOn)
2957 << "VP8 denoising should be on by default.";
2958
Niels Möller805a27e2019-01-21 12:21:27 +01002959 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02002960
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002961 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2962 EXPECT_FALSE(vp8_settings.denoisingOn);
Erik Språng143cec12015-04-28 10:01:41 +02002963 EXPECT_TRUE(vp8_settings.automaticResizeOn);
2964 EXPECT_TRUE(vp8_settings.frameDroppingOn);
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002965
Niels Möller805a27e2019-01-21 12:21:27 +01002966 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, true);
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002967
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002968 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2969 EXPECT_TRUE(vp8_settings.denoisingOn);
Erik Språng143cec12015-04-28 10:01:41 +02002970 EXPECT_TRUE(vp8_settings.automaticResizeOn);
2971 EXPECT_TRUE(vp8_settings.frameDroppingOn);
2972
Niels Möllerff40b142018-04-09 08:49:14 +02002973 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boström2feafdb2015-09-09 14:32:14 +02002974 stream = SetUpSimulcast(true, false);
Niels Möller805a27e2019-01-21 12:21:27 +01002975 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Erik Språng143cec12015-04-28 10:01:41 +02002976 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01002977 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Erik Språng143cec12015-04-28 10:01:41 +02002978
Mirko Bonadeif859e552018-05-30 15:31:29 +02002979 EXPECT_EQ(3u, stream->GetVideoStreams().size());
Erik Språng143cec12015-04-28 10:01:41 +02002980 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2981 // Autmatic resize off when using simulcast.
2982 EXPECT_FALSE(vp8_settings.automaticResizeOn);
2983 EXPECT_TRUE(vp8_settings.frameDroppingOn);
2984
2985 // In screen-share mode, denoising is forced off and simulcast disabled.
nisse05103312016-03-16 02:22:50 -07002986 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002987 options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01002988 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Niels Möller60653ba2016-03-02 11:41:36 +01002989
Niels Möller805a27e2019-01-21 12:21:27 +01002990 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02002991
Mirko Bonadeif859e552018-05-30 15:31:29 +02002992 EXPECT_EQ(1u, stream->GetVideoStreams().size());
Erik Språng143cec12015-04-28 10:01:41 +02002993 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2994 EXPECT_FALSE(vp8_settings.denoisingOn);
2995 // Resizing and frame dropping always off for screen sharing.
2996 EXPECT_FALSE(vp8_settings.automaticResizeOn);
2997 EXPECT_FALSE(vp8_settings.frameDroppingOn);
2998
Niels Möller805a27e2019-01-21 12:21:27 +01002999 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, true);
Erik Språng143cec12015-04-28 10:01:41 +02003000
3001 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3002 EXPECT_FALSE(vp8_settings.denoisingOn);
3003 EXPECT_FALSE(vp8_settings.automaticResizeOn);
3004 EXPECT_FALSE(vp8_settings.frameDroppingOn);
3005
Niels Möllerff40b142018-04-09 08:49:14 +02003006 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Erik Språng143cec12015-04-28 10:01:41 +02003007}
3008
deadbeef119760a2016-04-04 11:43:27 -07003009// Test that setting the same options doesn't result in the encoder being
3010// reconfigured.
eladalonf1841382017-06-12 01:16:46 -07003011TEST_F(WebRtcVideoChannelTest, SetIdenticalOptionsDoesntReconfigureEncoder) {
deadbeef119760a2016-04-04 11:43:27 -07003012 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01003013 webrtc::test::FrameForwarder frame_forwarder;
deadbeef119760a2016-04-04 11:43:27 -07003014
perkjfa10b552016-10-02 23:45:26 -07003015 AddSendStream();
perkjfa10b552016-10-02 23:45:26 -07003016 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003017 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkjfa10b552016-10-02 23:45:26 -07003018 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3019 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
3020
Niels Möller805a27e2019-01-21 12:21:27 +01003021 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
3022 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
3023 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
perkjfa10b552016-10-02 23:45:26 -07003024 // Expect 1 reconfigurations at this point from the initial configuration.
3025 EXPECT_EQ(1, send_stream->num_encoder_reconfigurations());
deadbeef119760a2016-04-04 11:43:27 -07003026
3027 // Set the options one more time and expect no additional reconfigurations.
Niels Möller805a27e2019-01-21 12:21:27 +01003028 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
perkjfa10b552016-10-02 23:45:26 -07003029 EXPECT_EQ(1, send_stream->num_encoder_reconfigurations());
3030
3031 // Change |options| and expect 2 reconfigurations.
Oskar Sundbom78807582017-11-16 11:09:55 +01003032 options.video_noise_reduction = true;
Niels Möller805a27e2019-01-21 12:21:27 +01003033 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
deadbeef119760a2016-04-04 11:43:27 -07003034 EXPECT_EQ(2, send_stream->num_encoder_reconfigurations());
3035
Niels Möllerff40b142018-04-09 08:49:14 +02003036 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
deadbeef119760a2016-04-04 11:43:27 -07003037}
3038
eladalonf1841382017-06-12 01:16:46 -07003039class Vp9SettingsTest : public WebRtcVideoChannelTest {
Erik Språng143cec12015-04-28 10:01:41 +02003040 public:
asaperssonc5dabdd2016-03-21 04:15:50 -07003041 Vp9SettingsTest() : Vp9SettingsTest("") {}
3042 explicit Vp9SettingsTest(const char* field_trials)
eladalonf1841382017-06-12 01:16:46 -07003043 : WebRtcVideoChannelTest(field_trials) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +02003044 encoder_factory_->AddSupportedVideoCodecType("VP9");
Erik Språng143cec12015-04-28 10:01:41 +02003045 }
3046 virtual ~Vp9SettingsTest() {}
3047
3048 protected:
Erik Språng143cec12015-04-28 10:01:41 +02003049 void TearDown() override {
3050 // Remove references to encoder_factory_ since this will be destroyed
3051 // before channel_ and engine_.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003052 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
Erik Språng143cec12015-04-28 10:01:41 +02003053 }
Erik Språng143cec12015-04-28 10:01:41 +02003054};
3055
3056TEST_F(Vp9SettingsTest, VerifyVp9SpecificSettings) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003057 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003058 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003059 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Erik Språng143cec12015-04-28 10:01:41 +02003060
Peter Boström2feafdb2015-09-09 14:32:14 +02003061 FakeVideoSendStream* stream = SetUpSimulcast(false, false);
Erik Språng143cec12015-04-28 10:01:41 +02003062
Niels Möller805a27e2019-01-21 12:21:27 +01003063 webrtc::test::FrameForwarder frame_forwarder;
3064 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Erik Språng143cec12015-04-28 10:01:41 +02003065 channel_->SetSend(true);
3066
Niels Möller805a27e2019-01-21 12:21:27 +01003067 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Erik Språng143cec12015-04-28 10:01:41 +02003068
pbos4cba4eb2015-10-26 11:18:18 -07003069 webrtc::VideoCodecVP9 vp9_settings;
3070 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
jianja5e8aa62017-03-27 10:09:00 -07003071 EXPECT_TRUE(vp9_settings.denoisingOn)
3072 << "VP9 denoising should be on by default.";
pbos4cba4eb2015-10-26 11:18:18 -07003073
Niels Möller805a27e2019-01-21 12:21:27 +01003074 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02003075
Erik Språng143cec12015-04-28 10:01:41 +02003076 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3077 EXPECT_FALSE(vp9_settings.denoisingOn);
3078 // Frame dropping always on for real time video.
3079 EXPECT_TRUE(vp9_settings.frameDroppingOn);
3080
Niels Möller805a27e2019-01-21 12:21:27 +01003081 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, true);
Erik Språng143cec12015-04-28 10:01:41 +02003082
3083 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3084 EXPECT_TRUE(vp9_settings.denoisingOn);
3085 EXPECT_TRUE(vp9_settings.frameDroppingOn);
3086
3087 // In screen-share mode, denoising is forced off.
nisse05103312016-03-16 02:22:50 -07003088 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003089 options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01003090 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
perkj2d5f0912016-02-29 00:04:41 -08003091
Niels Möller805a27e2019-01-21 12:21:27 +01003092 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02003093
3094 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3095 EXPECT_FALSE(vp9_settings.denoisingOn);
Sergey Silkinbe71a1e2018-05-17 16:46:43 +02003096 // Frame dropping always on for screen sharing.
3097 EXPECT_TRUE(vp9_settings.frameDroppingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003098
Niels Möller805a27e2019-01-21 12:21:27 +01003099 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02003100
3101 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3102 EXPECT_FALSE(vp9_settings.denoisingOn);
Sergey Silkinbe71a1e2018-05-17 16:46:43 +02003103 EXPECT_TRUE(vp9_settings.frameDroppingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003104
Niels Möllerff40b142018-04-09 08:49:14 +02003105 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003106}
3107
Sergey Silkinf18072e2018-03-14 10:35:35 +01003108TEST_F(Vp9SettingsTest, MultipleSsrcsEnablesSvc) {
3109 cricket::VideoSendParameters parameters;
3110 parameters.codecs.push_back(GetEngineCodec("VP9"));
3111 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3112
3113 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
3114
3115 FakeVideoSendStream* stream =
3116 AddSendStream(CreateSimStreamParams("cname", ssrcs));
3117
3118 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
Sergey Silkinf18072e2018-03-14 10:35:35 +01003119
Niels Möller805a27e2019-01-21 12:21:27 +01003120 webrtc::test::FrameForwarder frame_forwarder;
3121 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, &frame_forwarder));
Sergey Silkinf18072e2018-03-14 10:35:35 +01003122 channel_->SetSend(true);
3123
Niels Möller805a27e2019-01-21 12:21:27 +01003124 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Sergey Silkinf18072e2018-03-14 10:35:35 +01003125
3126 webrtc::VideoCodecVP9 vp9_settings;
3127 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3128
3129 const size_t kNumSpatialLayers = ssrcs.size();
3130 const size_t kNumTemporalLayers = 3;
3131 EXPECT_EQ(vp9_settings.numberOfSpatialLayers, kNumSpatialLayers);
3132 EXPECT_EQ(vp9_settings.numberOfTemporalLayers, kNumTemporalLayers);
3133
Niels Möllerff40b142018-04-09 08:49:14 +02003134 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, nullptr));
Sergey Silkinf18072e2018-03-14 10:35:35 +01003135}
3136
Ilya Nikolaevskiy33d2a912019-04-02 11:05:03 +02003137TEST_F(Vp9SettingsTest, SvcModeCreatesSingleRtpStream) {
3138 cricket::VideoSendParameters parameters;
3139 parameters.codecs.push_back(GetEngineCodec("VP9"));
3140 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3141
3142 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
3143
3144 FakeVideoSendStream* stream =
3145 AddSendStream(CreateSimStreamParams("cname", ssrcs));
3146
3147 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3148
3149 // Despite 3 ssrcs provided, single layer is used.
3150 EXPECT_EQ(1u, config.rtp.ssrcs.size());
3151
3152 webrtc::test::FrameForwarder frame_forwarder;
3153 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, &frame_forwarder));
3154 channel_->SetSend(true);
3155
3156 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
3157
3158 webrtc::VideoCodecVP9 vp9_settings;
3159 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3160
3161 const size_t kNumSpatialLayers = ssrcs.size();
3162 EXPECT_EQ(vp9_settings.numberOfSpatialLayers, kNumSpatialLayers);
3163
3164 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, nullptr));
3165}
3166
Sergey Silkin8b9b5f92018-12-10 09:28:53 +01003167TEST_F(Vp9SettingsTest, AllEncodingParametersCopied) {
3168 cricket::VideoSendParameters send_parameters;
3169 send_parameters.codecs.push_back(GetEngineCodec("VP9"));
3170 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
3171
3172 const size_t kNumSpatialLayers = 3;
3173 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
3174
3175 FakeVideoSendStream* stream =
3176 AddSendStream(CreateSimStreamParams("cname", ssrcs));
3177
3178 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(ssrcs[0]);
3179 ASSERT_EQ(kNumSpatialLayers, parameters.encodings.size());
3180 ASSERT_TRUE(parameters.encodings[0].active);
3181 ASSERT_TRUE(parameters.encodings[1].active);
3182 ASSERT_TRUE(parameters.encodings[2].active);
3183 // Invert value to verify copying.
3184 parameters.encodings[1].active = false;
3185 EXPECT_TRUE(channel_->SetRtpSendParameters(ssrcs[0], parameters).ok());
3186
3187 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
3188
3189 // number_of_streams should be 1 since all spatial layers are sent on the
3190 // same SSRC. But encoding parameters of all layers is supposed to be copied
3191 // and stored in simulcast_layers[].
3192 EXPECT_EQ(1u, encoder_config.number_of_streams);
3193 EXPECT_EQ(encoder_config.simulcast_layers.size(), kNumSpatialLayers);
3194 EXPECT_TRUE(encoder_config.simulcast_layers[0].active);
3195 EXPECT_FALSE(encoder_config.simulcast_layers[1].active);
3196 EXPECT_TRUE(encoder_config.simulcast_layers[2].active);
3197}
3198
asaperssonc5dabdd2016-03-21 04:15:50 -07003199class Vp9SettingsTestWithFieldTrial : public Vp9SettingsTest {
3200 public:
brandtr468da7c2016-11-22 02:16:47 -08003201 explicit Vp9SettingsTestWithFieldTrial(const char* field_trials)
asaperssonc5dabdd2016-03-21 04:15:50 -07003202 : Vp9SettingsTest(field_trials) {}
3203
3204 protected:
3205 void VerifySettings(int num_spatial_layers, int num_temporal_layers) {
3206 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003207 parameters.codecs.push_back(GetEngineCodec("VP9"));
asaperssonc5dabdd2016-03-21 04:15:50 -07003208 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3209
3210 FakeVideoSendStream* stream = SetUpSimulcast(false, false);
3211
Niels Möller805a27e2019-01-21 12:21:27 +01003212 webrtc::test::FrameForwarder frame_forwarder;
3213 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
asaperssonc5dabdd2016-03-21 04:15:50 -07003214 channel_->SetSend(true);
3215
Niels Möller805a27e2019-01-21 12:21:27 +01003216 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
asaperssonc5dabdd2016-03-21 04:15:50 -07003217
3218 webrtc::VideoCodecVP9 vp9_settings;
3219 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3220 EXPECT_EQ(num_spatial_layers, vp9_settings.numberOfSpatialLayers);
3221 EXPECT_EQ(num_temporal_layers, vp9_settings.numberOfTemporalLayers);
3222
Niels Möllerff40b142018-04-09 08:49:14 +02003223 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
asaperssonc5dabdd2016-03-21 04:15:50 -07003224 }
3225};
3226
3227class Vp9SettingsTestWithNoFlag : public Vp9SettingsTestWithFieldTrial {
3228 public:
3229 Vp9SettingsTestWithNoFlag() : Vp9SettingsTestWithFieldTrial("") {}
3230};
3231
3232TEST_F(Vp9SettingsTestWithNoFlag, VerifySettings) {
3233 const int kNumSpatialLayers = 1;
3234 const int kNumTemporalLayers = 1;
3235 VerifySettings(kNumSpatialLayers, kNumTemporalLayers);
3236}
3237
3238class Vp9SettingsTestWithInvalidFlag : public Vp9SettingsTestWithFieldTrial {
3239 public:
3240 Vp9SettingsTestWithInvalidFlag()
3241 : Vp9SettingsTestWithFieldTrial("WebRTC-SupportVP9SVC/Default/") {}
3242};
3243
3244TEST_F(Vp9SettingsTestWithInvalidFlag, VerifySettings) {
3245 const int kNumSpatialLayers = 1;
3246 const int kNumTemporalLayers = 1;
3247 VerifySettings(kNumSpatialLayers, kNumTemporalLayers);
3248}
3249
3250class Vp9SettingsTestWith2SL3TLFlag : public Vp9SettingsTestWithFieldTrial {
3251 public:
3252 Vp9SettingsTestWith2SL3TLFlag()
3253 : Vp9SettingsTestWithFieldTrial(
3254 "WebRTC-SupportVP9SVC/EnabledByFlag_2SL3TL/") {}
3255};
3256
3257TEST_F(Vp9SettingsTestWith2SL3TLFlag, VerifySettings) {
3258 const int kNumSpatialLayers = 2;
3259 const int kNumTemporalLayers = 3;
3260 VerifySettings(kNumSpatialLayers, kNumTemporalLayers);
3261}
3262
Åsa Persson45bbc8a2017-11-13 10:16:47 +01003263TEST_F(WebRtcVideoChannelTest, VerifyMinBitrate) {
3264 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3265 ASSERT_EQ(1u, streams.size());
3266 EXPECT_EQ(cricket::kMinVideoBitrateBps, streams[0].min_bitrate_bps);
3267}
3268
3269TEST_F(WebRtcVideoChannelTest, VerifyMinBitrateWithForcedFallbackFieldTrial) {
3270 webrtc::test::ScopedFieldTrials override_field_trials_(
3271 "WebRTC-VP8-Forced-Fallback-Encoder-v2/Enabled-1,2,34567/");
3272 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3273 ASSERT_EQ(1u, streams.size());
3274 EXPECT_EQ(34567, streams[0].min_bitrate_bps);
3275}
3276
asapersson3c81a1a2017-06-14 05:52:21 -07003277TEST_F(WebRtcVideoChannelTest,
3278 BalancedDegradationPreferenceNotSupportedWithoutFieldtrial) {
3279 webrtc::test::ScopedFieldTrials override_field_trials_(
3280 "WebRTC-Video-BalancedDegradation/Disabled/");
3281 const bool kResolutionScalingEnabled = true;
3282 const bool kFpsScalingEnabled = false;
3283 TestDegradationPreference(kResolutionScalingEnabled, kFpsScalingEnabled);
3284}
3285
3286TEST_F(WebRtcVideoChannelTest,
3287 BalancedDegradationPreferenceSupportedBehindFieldtrial) {
3288 webrtc::test::ScopedFieldTrials override_field_trials_(
3289 "WebRTC-Video-BalancedDegradation/Enabled/");
3290 const bool kResolutionScalingEnabled = true;
3291 const bool kFpsScalingEnabled = true;
3292 TestDegradationPreference(kResolutionScalingEnabled, kFpsScalingEnabled);
3293}
3294
eladalonf1841382017-06-12 01:16:46 -07003295TEST_F(WebRtcVideoChannelTest, AdaptsOnOveruse) {
Erik Språngefbde372015-04-29 16:21:28 +02003296 TestCpuAdaptation(true, false);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003297}
3298
eladalonf1841382017-06-12 01:16:46 -07003299TEST_F(WebRtcVideoChannelTest, DoesNotAdaptOnOveruseWhenDisabled) {
Erik Språngefbde372015-04-29 16:21:28 +02003300 TestCpuAdaptation(false, false);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003301}
3302
Niels Möller3de32e62019-01-18 08:42:18 +01003303TEST_F(WebRtcVideoChannelTest, DoesNotAdaptWhenScreeensharing) {
3304 TestCpuAdaptation(false, true);
3305}
3306
eladalonf1841382017-06-12 01:16:46 -07003307TEST_F(WebRtcVideoChannelTest, DoesNotAdaptOnOveruseWhenScreensharing) {
Erik Språngefbde372015-04-29 16:21:28 +02003308 TestCpuAdaptation(true, true);
3309}
3310
eladalonf1841382017-06-12 01:16:46 -07003311TEST_F(WebRtcVideoChannelTest, PreviousAdaptationDoesNotApplyToScreenshare) {
magjed509e4fe2016-11-18 01:34:11 -08003312 cricket::VideoCodec codec = GetEngineCodec("VP8");
Per766ad3b2016-04-05 15:23:49 +02003313 cricket::VideoSendParameters parameters;
3314 parameters.codecs.push_back(codec);
3315
kthelgason2bc68642017-02-07 07:02:22 -08003316 MediaConfig media_config = GetMediaConfig();
Niels Möller1d7ecd22018-01-18 15:25:12 +01003317 media_config.video.enable_cpu_adaptation = true;
Sebastian Jansson84848f22018-11-16 10:40:36 +01003318 channel_.reset(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07003319 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003320 channel_->OnReadyToSend(true);
Per766ad3b2016-04-05 15:23:49 +02003321 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3322
3323 AddSendStream();
Niels Möller805a27e2019-01-21 12:21:27 +01003324 webrtc::test::FrameForwarder frame_forwarder;
Per766ad3b2016-04-05 15:23:49 +02003325
Per766ad3b2016-04-05 15:23:49 +02003326 ASSERT_TRUE(channel_->SetSend(true));
3327 cricket::VideoOptions camera_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003328 camera_options.is_screencast = false;
Niels Möller805a27e2019-01-21 12:21:27 +01003329 channel_->SetVideoSend(last_ssrc_, &camera_options, &frame_forwarder);
Per766ad3b2016-04-05 15:23:49 +02003330
3331 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3332 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
Per766ad3b2016-04-05 15:23:49 +02003333
Niels Möllerdcc70292019-01-15 16:32:38 +01003334 EXPECT_TRUE(send_stream->resolution_scaling_enabled());
3335 // Dont' expect anything on framerate_scaling_enabled, since the default is
3336 // transitioning from MAINTAIN_FRAMERATE to BALANCED.
Per766ad3b2016-04-05 15:23:49 +02003337
Niels Möllerdcc70292019-01-15 16:32:38 +01003338 // Switch to screen share. Expect no resolution scaling.
Per766ad3b2016-04-05 15:23:49 +02003339 cricket::VideoOptions screenshare_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003340 screenshare_options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01003341 channel_->SetVideoSend(last_ssrc_, &screenshare_options, &frame_forwarder);
sprangf24a0642017-02-28 13:23:26 -08003342 ASSERT_EQ(2, fake_call_->GetNumCreatedSendStreams());
3343 send_stream = fake_call_->GetVideoSendStreams().front();
Niels Möllerdcc70292019-01-15 16:32:38 +01003344 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
Per766ad3b2016-04-05 15:23:49 +02003345
Niels Möllerdcc70292019-01-15 16:32:38 +01003346 // Switch back to the normal capturer. Expect resolution scaling to be
3347 // reenabled.
Niels Möller805a27e2019-01-21 12:21:27 +01003348 channel_->SetVideoSend(last_ssrc_, &camera_options, &frame_forwarder);
3349 send_stream = fake_call_->GetVideoSendStreams().front();
sprangf24a0642017-02-28 13:23:26 -08003350 ASSERT_EQ(3, fake_call_->GetNumCreatedSendStreams());
3351 send_stream = fake_call_->GetVideoSendStreams().front();
Niels Möllerdcc70292019-01-15 16:32:38 +01003352 EXPECT_TRUE(send_stream->resolution_scaling_enabled());
Per766ad3b2016-04-05 15:23:49 +02003353
Niels Möllerff40b142018-04-09 08:49:14 +02003354 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Per766ad3b2016-04-05 15:23:49 +02003355}
3356
asapersson3c81a1a2017-06-14 05:52:21 -07003357// TODO(asapersson): Remove this test when the balanced field trial is removed.
3358void WebRtcVideoChannelTest::TestDegradationPreference(
3359 bool resolution_scaling_enabled,
3360 bool fps_scaling_enabled) {
3361 cricket::VideoCodec codec = GetEngineCodec("VP8");
3362 cricket::VideoSendParameters parameters;
3363 parameters.codecs.push_back(codec);
3364
3365 MediaConfig media_config = GetMediaConfig();
Niels Möller1d7ecd22018-01-18 15:25:12 +01003366 media_config.video.enable_cpu_adaptation = true;
Sebastian Jansson84848f22018-11-16 10:40:36 +01003367 channel_.reset(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07003368 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
asapersson3c81a1a2017-06-14 05:52:21 -07003369 channel_->OnReadyToSend(true);
3370
3371 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3372
3373 AddSendStream();
3374
Niels Möller805a27e2019-01-21 12:21:27 +01003375 webrtc::test::FrameForwarder frame_forwarder;
asapersson3c81a1a2017-06-14 05:52:21 -07003376 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01003377 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
asapersson3c81a1a2017-06-14 05:52:21 -07003378
3379 EXPECT_TRUE(channel_->SetSend(true));
3380
3381 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
3382 EXPECT_EQ(resolution_scaling_enabled,
3383 send_stream->resolution_scaling_enabled());
3384 EXPECT_EQ(fps_scaling_enabled, send_stream->framerate_scaling_enabled());
3385
Niels Möllerff40b142018-04-09 08:49:14 +02003386 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
asapersson3c81a1a2017-06-14 05:52:21 -07003387}
3388
eladalonf1841382017-06-12 01:16:46 -07003389void WebRtcVideoChannelTest::TestCpuAdaptation(bool enable_overuse,
3390 bool is_screenshare) {
magjed509e4fe2016-11-18 01:34:11 -08003391 cricket::VideoCodec codec = GetEngineCodec("VP8");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003392 cricket::VideoSendParameters parameters;
3393 parameters.codecs.push_back(codec);
nisse51542be2016-02-12 02:27:06 -08003394
kthelgason2bc68642017-02-07 07:02:22 -08003395 MediaConfig media_config = GetMediaConfig();
3396 if (enable_overuse) {
Niels Möller1d7ecd22018-01-18 15:25:12 +01003397 media_config.video.enable_cpu_adaptation = true;
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003398 }
Sebastian Jansson84848f22018-11-16 10:40:36 +01003399 channel_.reset(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07003400 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003401 channel_->OnReadyToSend(true);
nisse51542be2016-02-12 02:27:06 -08003402
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003403 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003404
3405 AddSendStream();
3406
Niels Möller805a27e2019-01-21 12:21:27 +01003407 webrtc::test::FrameForwarder frame_forwarder;
nisse05103312016-03-16 02:22:50 -07003408 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003409 options.is_screencast = is_screenshare;
Niels Möller805a27e2019-01-21 12:21:27 +01003410 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003411
3412 EXPECT_TRUE(channel_->SetSend(true));
3413
solenberge5269742015-09-08 05:13:22 -07003414 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
perkj2d5f0912016-02-29 00:04:41 -08003415
sprangc5d62e22017-04-02 23:53:04 -07003416 if (!enable_overuse) {
perkj803d97f2016-11-01 11:45:46 -07003417 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
sprangc5d62e22017-04-02 23:53:04 -07003418 EXPECT_FALSE(send_stream->framerate_scaling_enabled());
Niels Möller805a27e2019-01-21 12:21:27 +01003419 } else if (is_screenshare) {
sprangc5d62e22017-04-02 23:53:04 -07003420 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
3421 EXPECT_TRUE(send_stream->framerate_scaling_enabled());
3422 } else {
3423 EXPECT_TRUE(send_stream->resolution_scaling_enabled());
3424 EXPECT_FALSE(send_stream->framerate_scaling_enabled());
3425 }
Niels Möllerff40b142018-04-09 08:49:14 +02003426 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003427}
3428
eladalonf1841382017-06-12 01:16:46 -07003429TEST_F(WebRtcVideoChannelTest, EstimatesNtpStartTimeCorrectly) {
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003430 // Start at last timestamp to verify that wraparounds are estimated correctly.
3431 static const uint32_t kInitialTimestamp = 0xFFFFFFFFu;
3432 static const int64_t kInitialNtpTimeMs = 1247891230;
3433 static const int kFrameOffsetMs = 20;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003434 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003435
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003436 FakeVideoReceiveStream* stream = AddRecvStream();
3437 cricket::FakeVideoRenderer renderer;
nisse08582ff2016-02-04 01:24:52 -08003438 EXPECT_TRUE(channel_->SetSink(last_ssrc_, &renderer));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003439
Artem Titov1ebfb6a2019-01-03 23:49:37 +01003440 webrtc::VideoFrame video_frame =
3441 webrtc::VideoFrame::Builder()
3442 .set_video_frame_buffer(CreateBlackFrameBuffer(4, 4))
3443 .set_timestamp_rtp(kInitialTimestamp)
3444 .set_timestamp_us(0)
3445 .set_rotation(webrtc::kVideoRotation_0)
3446 .build();
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003447 // Initial NTP time is not available on the first frame, but should still be
3448 // able to be estimated.
nisseeb83a1a2016-03-21 01:27:56 -07003449 stream->InjectFrame(video_frame);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003450
3451 EXPECT_EQ(1, renderer.num_rendered_frames());
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003452
3453 // This timestamp is kInitialTimestamp (-1) + kFrameOffsetMs * 90, which
3454 // triggers a constant-overflow warning, hence we're calculating it explicitly
3455 // here.
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +02003456 fake_clock_.AdvanceTimeMicros(kFrameOffsetMs * rtc::kNumMicrosecsPerMillisec);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003457 video_frame.set_timestamp(kFrameOffsetMs * 90 - 1);
3458 video_frame.set_ntp_time_ms(kInitialNtpTimeMs + kFrameOffsetMs);
nisseeb83a1a2016-03-21 01:27:56 -07003459 stream->InjectFrame(video_frame);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003460
3461 EXPECT_EQ(2, renderer.num_rendered_frames());
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003462
3463 // Verify that NTP time has been correctly deduced.
3464 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00003465 ASSERT_TRUE(channel_->GetStats(&info));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003466 ASSERT_EQ(1u, info.receivers.size());
3467 EXPECT_EQ(kInitialNtpTimeMs, info.receivers[0].capture_start_ntp_time_ms);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003468}
3469
eladalonf1841382017-06-12 01:16:46 -07003470TEST_F(WebRtcVideoChannelTest, SetDefaultSendCodecs) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02003471 AssignDefaultAptRtxTypes();
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003472 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003473
3474 VideoCodec codec;
3475 EXPECT_TRUE(channel_->GetSendCodec(&codec));
pbos@webrtc.org9fbb7172014-06-13 09:34:13 +00003476 EXPECT_TRUE(codec.Matches(engine_.codecs()[0]));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003477
3478 // Using a RTX setup to verify that the default RTX payload type is good.
Peter Boström0c4e06b2015-10-07 12:23:21 +02003479 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
3480 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003481 FakeVideoSendStream* stream = AddSendStream(
3482 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
perkj26091b12016-09-01 01:17:40 -07003483 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003484
3485 // Make sure NACK and FEC are enabled on the correct payload types.
3486 EXPECT_EQ(1000, config.rtp.nack.rtp_history_ms);
magjed509e4fe2016-11-18 01:34:11 -08003487 EXPECT_EQ(GetEngineCodec("ulpfec").id, config.rtp.ulpfec.ulpfec_payload_type);
3488 EXPECT_EQ(GetEngineCodec("red").id, config.rtp.ulpfec.red_payload_type);
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003489
3490 EXPECT_EQ(1u, config.rtp.rtx.ssrcs.size());
3491 EXPECT_EQ(kRtxSsrcs1[0], config.rtp.rtx.ssrcs[0]);
Shao Changbine62202f2015-04-21 20:24:50 +08003492 VerifySendStreamHasRtxTypes(config, default_apt_rtx_types_);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003493 // TODO(juberti): Check RTCP, PLI, TMMBR.
3494}
3495
brandtr31bd2242017-05-19 05:47:46 -07003496// The following four tests ensures that FlexFEC is not activated by default
3497// when the field trials are not enabled.
3498// TODO(brandtr): Remove or update these tests when FlexFEC _is_ enabled by
3499// default.
Yves Gerey665174f2018-06-19 15:03:05 +02003500TEST_F(WebRtcVideoChannelTest, FlexfecSendCodecWithoutSsrcNotExposedByDefault) {
brandtr468da7c2016-11-22 02:16:47 -08003501 FakeVideoSendStream* stream = AddSendStream();
3502 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3503
brandtr3d200bd2017-01-16 06:59:19 -08003504 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr31bd2242017-05-19 05:47:46 -07003505 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3506 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
brandtr468da7c2016-11-22 02:16:47 -08003507}
3508
eladalonf1841382017-06-12 01:16:46 -07003509TEST_F(WebRtcVideoChannelTest, FlexfecSendCodecWithSsrcNotExposedByDefault) {
brandtr468da7c2016-11-22 02:16:47 -08003510 FakeVideoSendStream* stream = AddSendStream(
3511 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3512 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3513
brandtr3d200bd2017-01-16 06:59:19 -08003514 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr31bd2242017-05-19 05:47:46 -07003515 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3516 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3517}
3518
Yves Gerey665174f2018-06-19 15:03:05 +02003519TEST_F(WebRtcVideoChannelTest, FlexfecRecvCodecWithoutSsrcNotExposedByDefault) {
brandtr31bd2242017-05-19 05:47:46 -07003520 AddRecvStream();
3521
3522 const std::vector<FakeFlexfecReceiveStream*>& streams =
3523 fake_call_->GetFlexfecReceiveStreams();
3524 EXPECT_TRUE(streams.empty());
3525}
3526
eladalonf1841382017-06-12 01:16:46 -07003527TEST_F(WebRtcVideoChannelTest, FlexfecRecvCodecWithSsrcNotExposedByDefault) {
brandtr31bd2242017-05-19 05:47:46 -07003528 AddRecvStream(
3529 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3530
3531 const std::vector<FakeFlexfecReceiveStream*>& streams =
3532 fake_call_->GetFlexfecReceiveStreams();
3533 EXPECT_TRUE(streams.empty());
brandtr468da7c2016-11-22 02:16:47 -08003534}
3535
3536// TODO(brandtr): When FlexFEC is no longer behind a field trial, merge all
3537// tests that use this test fixture into the corresponding "non-field trial"
3538// tests.
eladalonf1841382017-06-12 01:16:46 -07003539class WebRtcVideoChannelFlexfecRecvTest : public WebRtcVideoChannelTest {
brandtr468da7c2016-11-22 02:16:47 -08003540 public:
eladalonf1841382017-06-12 01:16:46 -07003541 WebRtcVideoChannelFlexfecRecvTest()
3542 : WebRtcVideoChannelTest("WebRTC-FlexFEC-03-Advertised/Enabled/") {}
brandtr468da7c2016-11-22 02:16:47 -08003543};
3544
eladalonf1841382017-06-12 01:16:46 -07003545TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr36e7d702017-01-13 07:15:54 -08003546 DefaultFlexfecCodecHasTransportCcAndRembFeedbackParam) {
3547 EXPECT_TRUE(cricket::HasTransportCc(GetEngineCodec("flexfec-03")));
3548 EXPECT_TRUE(cricket::HasRemb(GetEngineCodec("flexfec-03")));
3549}
3550
eladalonf1841382017-06-12 01:16:46 -07003551TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetDefaultRecvCodecsWithoutSsrc) {
brandtr31bd2242017-05-19 05:47:46 -07003552 AddRecvStream();
3553
3554 const std::vector<FakeFlexfecReceiveStream*>& streams =
3555 fake_call_->GetFlexfecReceiveStreams();
3556 EXPECT_TRUE(streams.empty());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003557
3558 const std::vector<FakeVideoReceiveStream*>& video_streams =
3559 fake_call_->GetVideoReceiveStreams();
3560 ASSERT_EQ(1U, video_streams.size());
3561 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3562 EXPECT_EQ(0, video_stream.GetNumAddedSecondarySinks());
3563 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr31bd2242017-05-19 05:47:46 -07003564}
3565
eladalonf1841382017-06-12 01:16:46 -07003566TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetDefaultRecvCodecsWithSsrc) {
brandtr31bd2242017-05-19 05:47:46 -07003567 AddRecvStream(
3568 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3569
3570 const std::vector<FakeFlexfecReceiveStream*>& streams =
3571 fake_call_->GetFlexfecReceiveStreams();
3572 ASSERT_EQ(1U, streams.size());
3573 const FakeFlexfecReceiveStream* stream = streams.front();
3574 const webrtc::FlexfecReceiveStream::Config& config = stream->GetConfig();
3575 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.payload_type);
3576 EXPECT_EQ(kFlexfecSsrc, config.remote_ssrc);
3577 ASSERT_EQ(1U, config.protected_media_ssrcs.size());
3578 EXPECT_EQ(kSsrcs1[0], config.protected_media_ssrcs[0]);
brandtr7cd28b92017-09-22 00:26:25 -07003579
3580 const std::vector<FakeVideoReceiveStream*>& video_streams =
3581 fake_call_->GetVideoReceiveStreams();
3582 ASSERT_EQ(1U, video_streams.size());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003583 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3584 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
brandtr7cd28b92017-09-22 00:26:25 -07003585 const webrtc::VideoReceiveStream::Config& video_config =
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003586 video_stream.GetConfig();
brandtr7cd28b92017-09-22 00:26:25 -07003587 EXPECT_TRUE(video_config.rtp.protected_by_flexfec);
brandtr31bd2242017-05-19 05:47:46 -07003588}
3589
eladalonf1841382017-06-12 01:16:46 -07003590TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr11fb4722017-05-30 01:31:37 -07003591 EnablingFlexfecDoesNotRecreateVideoReceiveStream) {
3592 cricket::VideoRecvParameters recv_parameters;
3593 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3594 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3595
3596 AddRecvStream(
3597 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3598 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003599 const std::vector<FakeVideoReceiveStream*>& video_streams =
3600 fake_call_->GetVideoReceiveStreams();
3601 ASSERT_EQ(1U, video_streams.size());
3602 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3603 EXPECT_EQ(0, video_stream.GetNumAddedSecondarySinks());
3604 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003605
3606 // Enable FlexFEC.
3607 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3608 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3609 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams())
3610 << "Enabling FlexFEC should create FlexfecReceiveStream.";
3611 EXPECT_EQ(1U, fake_call_->GetVideoReceiveStreams().size())
3612 << "Enabling FlexFEC should not create VideoReceiveStream.";
3613 EXPECT_EQ(1U, fake_call_->GetFlexfecReceiveStreams().size())
3614 << "Enabling FlexFEC should create a single FlexfecReceiveStream.";
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003615 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3616 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003617}
3618
eladalonf1841382017-06-12 01:16:46 -07003619TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr11fb4722017-05-30 01:31:37 -07003620 DisablingFlexfecDoesNotRecreateVideoReceiveStream) {
3621 cricket::VideoRecvParameters recv_parameters;
3622 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3623 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3624 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3625
3626 AddRecvStream(
3627 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3628 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams());
brandtr11fb4722017-05-30 01:31:37 -07003629 EXPECT_EQ(1U, fake_call_->GetFlexfecReceiveStreams().size());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003630 const std::vector<FakeVideoReceiveStream*>& video_streams =
3631 fake_call_->GetVideoReceiveStreams();
3632 ASSERT_EQ(1U, video_streams.size());
3633 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3634 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3635 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003636
3637 // Disable FlexFEC.
3638 recv_parameters.codecs.clear();
3639 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3640 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3641 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams())
3642 << "Disabling FlexFEC should not recreate VideoReceiveStream.";
3643 EXPECT_EQ(1U, fake_call_->GetVideoReceiveStreams().size())
3644 << "Disabling FlexFEC should not destroy VideoReceiveStream.";
3645 EXPECT_TRUE(fake_call_->GetFlexfecReceiveStreams().empty())
3646 << "Disabling FlexFEC should destroy FlexfecReceiveStream.";
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003647 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3648 EXPECT_EQ(1, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003649}
3650
brandtr31bd2242017-05-19 05:47:46 -07003651// TODO(brandtr): When FlexFEC is no longer behind a field trial, merge all
3652// tests that use this test fixture into the corresponding "non-field trial"
3653// tests.
eladalonf1841382017-06-12 01:16:46 -07003654class WebRtcVideoChannelFlexfecSendRecvTest : public WebRtcVideoChannelTest {
brandtr31bd2242017-05-19 05:47:46 -07003655 public:
eladalonf1841382017-06-12 01:16:46 -07003656 WebRtcVideoChannelFlexfecSendRecvTest()
3657 : WebRtcVideoChannelTest(
brandtr31bd2242017-05-19 05:47:46 -07003658 "WebRTC-FlexFEC-03-Advertised/Enabled/WebRTC-FlexFEC-03/Enabled/") {
3659 }
3660};
3661
Yves Gerey665174f2018-06-19 15:03:05 +02003662TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetDefaultSendCodecsWithoutSsrc) {
brandtr468da7c2016-11-22 02:16:47 -08003663 FakeVideoSendStream* stream = AddSendStream();
3664 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3665
brandtr3d200bd2017-01-16 06:59:19 -08003666 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3667 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3668 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
brandtr468da7c2016-11-22 02:16:47 -08003669}
3670
eladalonf1841382017-06-12 01:16:46 -07003671TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetDefaultSendCodecsWithSsrc) {
brandtr468da7c2016-11-22 02:16:47 -08003672 FakeVideoSendStream* stream = AddSendStream(
3673 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3674 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3675
brandtr3d200bd2017-01-16 06:59:19 -08003676 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3677 EXPECT_EQ(kFlexfecSsrc, config.rtp.flexfec.ssrc);
3678 ASSERT_EQ(1U, config.rtp.flexfec.protected_media_ssrcs.size());
3679 EXPECT_EQ(kSsrcs1[0], config.rtp.flexfec.protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08003680}
3681
eladalonf1841382017-06-12 01:16:46 -07003682TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003683 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003684 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003685 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003686
3687 FakeVideoSendStream* stream = AddSendStream();
perkj26091b12016-09-01 01:17:40 -07003688 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003689
brandtrb5f2c3f2016-10-04 23:28:39 -07003690 EXPECT_EQ(-1, config.rtp.ulpfec.ulpfec_payload_type);
3691 EXPECT_EQ(-1, config.rtp.ulpfec.red_payload_type);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003692}
3693
eladalonf1841382017-06-12 01:16:46 -07003694TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetSendCodecsWithoutFec) {
brandtr468da7c2016-11-22 02:16:47 -08003695 cricket::VideoSendParameters parameters;
3696 parameters.codecs.push_back(GetEngineCodec("VP8"));
3697 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3698
3699 FakeVideoSendStream* stream = AddSendStream();
3700 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3701
brandtr3d200bd2017-01-16 06:59:19 -08003702 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr468da7c2016-11-22 02:16:47 -08003703}
3704
eladalonf1841382017-06-12 01:16:46 -07003705TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetRecvCodecsWithFec) {
brandtr9c3d4c42017-01-23 06:59:13 -08003706 AddRecvStream(
3707 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08003708
3709 cricket::VideoRecvParameters recv_parameters;
3710 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3711 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3712 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
brandtr9d58d942017-02-03 04:43:41 -08003713
3714 const std::vector<FakeFlexfecReceiveStream*>& flexfec_streams =
3715 fake_call_->GetFlexfecReceiveStreams();
3716 ASSERT_EQ(1U, flexfec_streams.size());
3717 const FakeFlexfecReceiveStream* flexfec_stream = flexfec_streams.front();
3718 const webrtc::FlexfecReceiveStream::Config& flexfec_stream_config =
3719 flexfec_stream->GetConfig();
brandtr9c3d4c42017-01-23 06:59:13 -08003720 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9d58d942017-02-03 04:43:41 -08003721 flexfec_stream_config.payload_type);
3722 EXPECT_EQ(kFlexfecSsrc, flexfec_stream_config.remote_ssrc);
3723 ASSERT_EQ(1U, flexfec_stream_config.protected_media_ssrcs.size());
3724 EXPECT_EQ(kSsrcs1[0], flexfec_stream_config.protected_media_ssrcs[0]);
3725 const std::vector<FakeVideoReceiveStream*>& video_streams =
3726 fake_call_->GetVideoReceiveStreams();
3727 const FakeVideoReceiveStream* video_stream = video_streams.front();
3728 const webrtc::VideoReceiveStream::Config& video_stream_config =
3729 video_stream->GetConfig();
3730 EXPECT_EQ(video_stream_config.rtp.local_ssrc,
3731 flexfec_stream_config.local_ssrc);
3732 EXPECT_EQ(video_stream_config.rtp.rtcp_mode, flexfec_stream_config.rtcp_mode);
3733 EXPECT_EQ(video_stream_config.rtcp_send_transport,
3734 flexfec_stream_config.rtcp_send_transport);
3735 // TODO(brandtr): Update this EXPECT when we set |transport_cc| in a
3736 // spec-compliant way.
3737 EXPECT_EQ(video_stream_config.rtp.transport_cc,
3738 flexfec_stream_config.transport_cc);
3739 EXPECT_EQ(video_stream_config.rtp.rtcp_mode, flexfec_stream_config.rtcp_mode);
3740 EXPECT_EQ(video_stream_config.rtp.extensions,
3741 flexfec_stream_config.rtp_header_extensions);
brandtr9c3d4c42017-01-23 06:59:13 -08003742}
3743
brandtr31bd2242017-05-19 05:47:46 -07003744// We should not send FlexFEC, even if we advertise it, unless the right
3745// field trial is set.
3746// TODO(brandtr): Remove when FlexFEC is enabled by default.
eladalonf1841382017-06-12 01:16:46 -07003747TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003748 SetSendCodecsWithoutSsrcWithFecDoesNotEnableFec) {
3749 cricket::VideoSendParameters parameters;
3750 parameters.codecs.push_back(GetEngineCodec("VP8"));
3751 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3752 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3753
3754 FakeVideoSendStream* stream = AddSendStream();
3755 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3756
3757 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
Mirko Bonadeif859e552018-05-30 15:31:29 +02003758 EXPECT_EQ(0u, config.rtp.flexfec.ssrc);
brandtr31bd2242017-05-19 05:47:46 -07003759 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3760}
3761
eladalonf1841382017-06-12 01:16:46 -07003762TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003763 SetSendCodecsWithSsrcWithFecDoesNotEnableFec) {
3764 cricket::VideoSendParameters parameters;
3765 parameters.codecs.push_back(GetEngineCodec("VP8"));
3766 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3767 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3768
3769 FakeVideoSendStream* stream = AddSendStream(
3770 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3771 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3772
3773 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
Mirko Bonadeif859e552018-05-30 15:31:29 +02003774 EXPECT_EQ(0u, config.rtp.flexfec.ssrc);
brandtr31bd2242017-05-19 05:47:46 -07003775 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3776}
3777
eladalonf1841382017-06-12 01:16:46 -07003778TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003779 SetSendCodecRejectsRtxWithoutAssociatedPayloadType) {
magjed509e4fe2016-11-18 01:34:11 -08003780 const int kUnusedPayloadType = 127;
3781 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType));
3782
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003783 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003784 cricket::VideoCodec rtx_codec(kUnusedPayloadType, "rtx");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003785 parameters.codecs.push_back(rtx_codec);
3786 EXPECT_FALSE(channel_->SetSendParameters(parameters))
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003787 << "RTX codec without associated payload type should be rejected.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003788}
3789
eladalonf1841382017-06-12 01:16:46 -07003790TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003791 SetSendCodecRejectsRtxWithoutMatchingVideoCodec) {
magjed509e4fe2016-11-18 01:34:11 -08003792 const int kUnusedPayloadType1 = 126;
3793 const int kUnusedPayloadType2 = 127;
3794 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
3795 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
3796 {
3797 cricket::VideoCodec rtx_codec = cricket::VideoCodec::CreateRtxCodec(
3798 kUnusedPayloadType1, GetEngineCodec("VP8").id);
3799 cricket::VideoSendParameters parameters;
3800 parameters.codecs.push_back(GetEngineCodec("VP8"));
3801 parameters.codecs.push_back(rtx_codec);
3802 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3803 }
3804 {
3805 cricket::VideoCodec rtx_codec = cricket::VideoCodec::CreateRtxCodec(
3806 kUnusedPayloadType1, kUnusedPayloadType2);
3807 cricket::VideoSendParameters parameters;
3808 parameters.codecs.push_back(GetEngineCodec("VP8"));
3809 parameters.codecs.push_back(rtx_codec);
3810 EXPECT_FALSE(channel_->SetSendParameters(parameters))
3811 << "RTX without matching video codec should be rejected.";
3812 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003813}
3814
eladalonf1841382017-06-12 01:16:46 -07003815TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithChangedRtxPayloadType) {
brandtr14742122017-01-27 04:53:07 -08003816 const int kUnusedPayloadType1 = 126;
3817 const int kUnusedPayloadType2 = 127;
3818 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
3819 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
3820
3821 // SSRCs for RTX.
3822 cricket::StreamParams params =
3823 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
3824 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
3825 AddSendStream(params);
3826
3827 // Original payload type for RTX.
3828 cricket::VideoSendParameters parameters;
3829 parameters.codecs.push_back(GetEngineCodec("VP8"));
3830 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
3831 rtx_codec.SetParam("apt", GetEngineCodec("VP8").id);
3832 parameters.codecs.push_back(rtx_codec);
3833 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3834 ASSERT_EQ(1U, fake_call_->GetVideoSendStreams().size());
3835 const webrtc::VideoSendStream::Config& config_before =
3836 fake_call_->GetVideoSendStreams()[0]->GetConfig();
3837 EXPECT_EQ(kUnusedPayloadType1, config_before.rtp.rtx.payload_type);
3838 ASSERT_EQ(1U, config_before.rtp.rtx.ssrcs.size());
3839 EXPECT_EQ(kRtxSsrcs1[0], config_before.rtp.rtx.ssrcs[0]);
3840
3841 // Change payload type for RTX.
3842 parameters.codecs[1].id = kUnusedPayloadType2;
3843 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3844 ASSERT_EQ(1U, fake_call_->GetVideoSendStreams().size());
3845 const webrtc::VideoSendStream::Config& config_after =
3846 fake_call_->GetVideoSendStreams()[0]->GetConfig();
3847 EXPECT_EQ(kUnusedPayloadType2, config_after.rtp.rtx.payload_type);
3848 ASSERT_EQ(1U, config_after.rtp.rtx.ssrcs.size());
3849 EXPECT_EQ(kRtxSsrcs1[0], config_after.rtp.rtx.ssrcs[0]);
3850}
3851
eladalonf1841382017-06-12 01:16:46 -07003852TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutFecDisablesFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003853 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003854 parameters.codecs.push_back(GetEngineCodec("VP8"));
3855 parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003856 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003857
3858 FakeVideoSendStream* stream = AddSendStream();
perkj26091b12016-09-01 01:17:40 -07003859 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003860
magjed509e4fe2016-11-18 01:34:11 -08003861 EXPECT_EQ(GetEngineCodec("ulpfec").id, config.rtp.ulpfec.ulpfec_payload_type);
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003862
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003863 parameters.codecs.pop_back();
3864 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003865 stream = fake_call_->GetVideoSendStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08003866 ASSERT_TRUE(stream != nullptr);
perkj26091b12016-09-01 01:17:40 -07003867 config = stream->GetConfig().Copy();
brandtrb5f2c3f2016-10-04 23:28:39 -07003868 EXPECT_EQ(-1, config.rtp.ulpfec.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08003869 << "SetSendCodec without ULPFEC should disable current ULPFEC.";
3870}
3871
eladalonf1841382017-06-12 01:16:46 -07003872TEST_F(WebRtcVideoChannelFlexfecSendRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003873 SetSendCodecsWithoutFecDisablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08003874 cricket::VideoSendParameters parameters;
3875 parameters.codecs.push_back(GetEngineCodec("VP8"));
3876 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3877 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3878
3879 FakeVideoSendStream* stream = AddSendStream(
3880 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3881 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3882
brandtr3d200bd2017-01-16 06:59:19 -08003883 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3884 EXPECT_EQ(kFlexfecSsrc, config.rtp.flexfec.ssrc);
brandtr468da7c2016-11-22 02:16:47 -08003885 ASSERT_EQ(1U, config.rtp.flexfec.protected_media_ssrcs.size());
3886 EXPECT_EQ(kSsrcs1[0], config.rtp.flexfec.protected_media_ssrcs[0]);
3887
3888 parameters.codecs.pop_back();
3889 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3890 stream = fake_call_->GetVideoSendStreams()[0];
3891 ASSERT_TRUE(stream != nullptr);
3892 config = stream->GetConfig().Copy();
brandtr3d200bd2017-01-16 06:59:19 -08003893 EXPECT_EQ(-1, config.rtp.flexfec.payload_type)
brandtr468da7c2016-11-22 02:16:47 -08003894 << "SetSendCodec without FlexFEC should disable current FlexFEC.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003895}
3896
eladalonf1841382017-06-12 01:16:46 -07003897TEST_F(WebRtcVideoChannelTest, SetSendCodecsChangesExistingStreams) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003898 cricket::VideoSendParameters parameters;
perkj26752742016-10-24 01:21:16 -07003899 cricket::VideoCodec codec(100, "VP8");
3900 codec.SetParam(kCodecParamMaxQuantization, kDefaultQpMax);
3901 parameters.codecs.push_back(codec);
perkjfa10b552016-10-02 23:45:26 -07003902
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003903 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00003904 channel_->SetSend(true);
pbos@webrtc.org38ce7d02014-07-16 08:01:38 +00003905
pbos@webrtc.org86196c42015-02-16 21:02:00 +00003906 FakeVideoSendStream* stream = AddSendStream();
Niels Möller805a27e2019-01-21 12:21:27 +01003907 webrtc::test::FrameForwarder frame_forwarder;
3908 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00003909
3910 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
perkjfa10b552016-10-02 23:45:26 -07003911 EXPECT_EQ(kDefaultQpMax, streams[0].max_qp);
pbos@webrtc.org38ce7d02014-07-16 08:01:38 +00003912
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003913 parameters.codecs.clear();
perkj26752742016-10-24 01:21:16 -07003914 codec.SetParam(kCodecParamMaxQuantization, kDefaultQpMax + 1);
3915 parameters.codecs.push_back(codec);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003916 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003917 streams = fake_call_->GetVideoSendStreams()[0]->GetVideoStreams();
perkjfa10b552016-10-02 23:45:26 -07003918 EXPECT_EQ(kDefaultQpMax + 1, streams[0].max_qp);
Niels Möllerff40b142018-04-09 08:49:14 +02003919 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003920}
3921
eladalonf1841382017-06-12 01:16:46 -07003922TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithBitrates) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00003923 SetSendCodecsShouldWorkForBitrates("100", 100000, "150", 150000, "200",
3924 200000);
3925}
3926
eladalonf1841382017-06-12 01:16:46 -07003927TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithHighMaxBitrate) {
pbos@webrtc.orga5f6fb52015-03-23 22:29:39 +00003928 SetSendCodecsShouldWorkForBitrates("", 0, "", -1, "10000", 10000000);
3929 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3930 ASSERT_EQ(1u, streams.size());
3931 EXPECT_EQ(10000000, streams[0].max_bitrate_bps);
3932}
3933
eladalonf1841382017-06-12 01:16:46 -07003934TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org00873182014-11-25 14:03:34 +00003935 SetSendCodecsWithoutBitratesUsesCorrectDefaults) {
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003936 SetSendCodecsShouldWorkForBitrates("", 0, "", -1, "", -1);
pbos@webrtc.org00873182014-11-25 14:03:34 +00003937}
3938
eladalonf1841382017-06-12 01:16:46 -07003939TEST_F(WebRtcVideoChannelTest, SetSendCodecsCapsMinAndStartBitrate) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00003940 SetSendCodecsShouldWorkForBitrates("-1", 0, "-100", -1, "", -1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003941}
3942
eladalonf1841382017-06-12 01:16:46 -07003943TEST_F(WebRtcVideoChannelTest, SetSendCodecsRejectsMaxLessThanMinBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003944 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "300";
3945 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "200";
3946 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003947}
3948
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003949// Test that when both the codec-specific bitrate params and max_bandwidth_bps
3950// are present in the same send parameters, the settings are combined correctly.
eladalonf1841382017-06-12 01:16:46 -07003951TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithBitratesAndMaxSendBandwidth) {
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003952 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
3953 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
3954 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
3955 send_parameters_.max_bandwidth_bps = 400000;
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003956 // We expect max_bandwidth_bps to take priority, if set.
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003957 ExpectSetBitrateParameters(100000, 200000, 400000);
3958 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
3959 // Since the codec isn't changing, start_bitrate_bps should be -1.
3960 ExpectSetBitrateParameters(100000, -1, 350000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003961
3962 // Decrease max_bandwidth_bps.
3963 send_parameters_.max_bandwidth_bps = 350000;
3964 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003965
3966 // Now try again with the values flipped around.
3967 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "400";
3968 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003969 ExpectSetBitrateParameters(100000, 200000, 300000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003970 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003971
3972 // If we change the codec max, max_bandwidth_bps should still apply.
3973 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "350";
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003974 ExpectSetBitrateParameters(100000, 200000, 300000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003975 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003976}
3977
Piotr (Peter) Slatala946b9682019-03-18 10:25:02 -07003978// Test that when both the codec-specific bitrate params and max_bandwidth_bps
3979// are present in the same send parameters, the settings are combined correctly.
3980TEST_F(WebRtcVideoChannelTest,
3981 SetSendCodecsWithBitratesAndMaxSendBandwidthForMediaTransport) {
3982 // Same as SetSendCodecsWithBitratesAndMaxSendBandwidth but with Media
3983 // Transport.
3984 webrtc::MediaTransportSettings settings;
3985 settings.is_caller = true;
3986 webrtc::FakeMediaTransport fake_media_transport(settings);
3987 std::unique_ptr<cricket::FakeNetworkInterface> network_interface(
3988 new cricket::FakeNetworkInterface);
3989 channel_->SetInterface(network_interface.get(), &fake_media_transport);
3990
3991 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
3992 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
3993 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
3994 send_parameters_.max_bandwidth_bps = 400000;
3995 {
3996 // We expect max_bandwidth_bps to take priority, if set.
3997 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
3998 ASSERT_EQ(1u,
3999 fake_media_transport.target_rate_constraints_in_order().size());
4000 const webrtc::MediaTransportTargetRateConstraints& constraint =
4001 fake_media_transport.target_rate_constraints_in_order()[0];
4002 ASSERT_EQ(webrtc::DataRate::bps(100000), constraint.min_bitrate);
4003 ASSERT_EQ(webrtc::DataRate::bps(200000), constraint.starting_bitrate);
4004 ASSERT_EQ(webrtc::DataRate::bps(400000), constraint.max_bitrate);
4005 }
4006
4007 {
4008 // Decrease max_bandwidth_bps.
4009 send_parameters_.max_bandwidth_bps = 350000;
4010 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4011 ASSERT_EQ(2u,
4012 fake_media_transport.target_rate_constraints_in_order().size());
4013 const webrtc::MediaTransportTargetRateConstraints& constraint =
4014 fake_media_transport.target_rate_constraints_in_order()[1];
4015
4016 // Since the codec isn't changing, start_bitrate_bps should be 0.
4017 ASSERT_EQ(webrtc::DataRate::bps(100000), constraint.min_bitrate);
4018 ASSERT_EQ(absl::nullopt, constraint.starting_bitrate);
4019 ASSERT_EQ(webrtc::DataRate::bps(350000), constraint.max_bitrate);
4020 }
4021
4022 {
4023 // Now try again with the values flipped around.
4024 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "400";
4025 send_parameters_.max_bandwidth_bps = 300000;
4026 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4027 ASSERT_EQ(3u,
4028 fake_media_transport.target_rate_constraints_in_order().size());
4029 const webrtc::MediaTransportTargetRateConstraints& constraint =
4030 fake_media_transport.target_rate_constraints_in_order()[2];
4031
4032 ASSERT_EQ(webrtc::DataRate::bps(100000), constraint.min_bitrate);
4033 ASSERT_EQ(webrtc::DataRate::bps(200000), constraint.starting_bitrate);
4034 ASSERT_EQ(webrtc::DataRate::bps(300000), constraint.max_bitrate);
4035 }
4036
4037 {
4038 // Now try again with the values flipped around.
4039 // If we change the codec max, max_bandwidth_bps should still apply.
4040 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "350";
4041 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4042 ASSERT_EQ(4u,
4043 fake_media_transport.target_rate_constraints_in_order().size());
4044 const webrtc::MediaTransportTargetRateConstraints& constraint =
4045 fake_media_transport.target_rate_constraints_in_order()[3];
4046
4047 ASSERT_EQ(webrtc::DataRate::bps(100000), constraint.min_bitrate);
4048 ASSERT_EQ(webrtc::DataRate::bps(200000), constraint.starting_bitrate);
4049 ASSERT_EQ(webrtc::DataRate::bps(300000), constraint.max_bitrate);
4050 }
4051}
4052
Yves Gerey665174f2018-06-19 15:03:05 +02004053TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthShouldPreserveOtherBitrates) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00004054 SetSendCodecsShouldWorkForBitrates("100", 100000, "150", 150000, "200",
4055 200000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004056 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004057 // Setting max bitrate should keep previous min bitrate.
4058 // Setting max bitrate should not reset start bitrate.
4059 ExpectSetBitrateParameters(100000, -1, 300000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004060 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org00873182014-11-25 14:03:34 +00004061}
4062
eladalonf1841382017-06-12 01:16:46 -07004063TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthShouldBeRemovable) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004064 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004065 ExpectSetMaxBitrate(300000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004066 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos5c7760a2017-03-10 11:23:12 -08004067 // -1 means to disable max bitrate (set infinite).
4068 send_parameters_.max_bandwidth_bps = -1;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004069 ExpectSetMaxBitrate(-1);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004070 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004071}
4072
eladalonf1841382017-06-12 01:16:46 -07004073TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthAndAddSendStream) {
perkjfa10b552016-10-02 23:45:26 -07004074 send_parameters_.max_bandwidth_bps = 99999;
4075 FakeVideoSendStream* stream = AddSendStream();
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004076 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
perkjfa10b552016-10-02 23:45:26 -07004077 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
perkjfa10b552016-10-02 23:45:26 -07004078 ASSERT_EQ(1u, stream->GetVideoStreams().size());
4079 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4080 stream->GetVideoStreams()[0].max_bitrate_bps);
4081
4082 send_parameters_.max_bandwidth_bps = 77777;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004083 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
perkjfa10b552016-10-02 23:45:26 -07004084 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4085 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
perkjfa10b552016-10-02 23:45:26 -07004086 stream->GetVideoStreams()[0].max_bitrate_bps);
4087}
4088
Seth Hampsonfeec91e2018-07-13 10:41:10 -07004089// Tests that when the codec specific max bitrate and VideoSendParameters
4090// max_bandwidth_bps are used, that it sets the VideoStream's max bitrate
4091// appropriately.
4092TEST_F(WebRtcVideoChannelTest,
4093 MaxBitratePrioritizesVideoSendParametersOverCodecMaxBitrate) {
4094 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4095 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4096 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4097 send_parameters_.max_bandwidth_bps = -1;
4098 AddSendStream();
4099 ExpectSetMaxBitrate(300000);
4100 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4101
4102 std::vector<FakeVideoSendStream*> video_send_streams = GetFakeSendStreams();
4103 ASSERT_EQ(1u, video_send_streams.size());
4104 FakeVideoSendStream* video_send_stream = video_send_streams[0];
4105 ASSERT_EQ(1u, video_send_streams[0]->GetVideoStreams().size());
4106 // First the max bitrate is set based upon the codec param.
4107 EXPECT_EQ(300000,
4108 video_send_streams[0]->GetVideoStreams()[0].max_bitrate_bps);
4109
4110 // The VideoSendParameters max bitrate overrides the codec's.
4111 send_parameters_.max_bandwidth_bps = 500000;
4112 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
4113 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4114 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4115 EXPECT_EQ(500000, video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4116}
4117
4118// Tests that when the codec specific max bitrate and RtpParameters
4119// max_bitrate_bps are used, that it sets the VideoStream's max bitrate
4120// appropriately.
4121TEST_F(WebRtcVideoChannelTest,
4122 MaxBitratePrioritizesRtpParametersOverCodecMaxBitrate) {
4123 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4124 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4125 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4126 send_parameters_.max_bandwidth_bps = -1;
4127 AddSendStream();
4128 ExpectSetMaxBitrate(300000);
4129 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4130
4131 std::vector<FakeVideoSendStream*> video_send_streams = GetFakeSendStreams();
4132 ASSERT_EQ(1u, video_send_streams.size());
4133 FakeVideoSendStream* video_send_stream = video_send_streams[0];
4134 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4135 // First the max bitrate is set based upon the codec param.
4136 EXPECT_EQ(300000, video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4137
4138 // The RtpParameter max bitrate overrides the codec's.
4139 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
4140 ASSERT_EQ(1u, parameters.encodings.size());
4141 parameters.encodings[0].max_bitrate_bps = 500000;
4142 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4143 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4144 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps,
4145 video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4146}
4147
Åsa Persson55659812018-06-18 17:51:32 +02004148TEST_F(WebRtcVideoChannelTest,
4149 MaxBitrateIsMinimumOfMaxSendBandwidthAndMaxEncodingBitrate) {
4150 send_parameters_.max_bandwidth_bps = 99999;
4151 FakeVideoSendStream* stream = AddSendStream();
4152 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
4153 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4154 ASSERT_EQ(1u, stream->GetVideoStreams().size());
4155 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4156 stream->GetVideoStreams()[0].max_bitrate_bps);
4157
4158 // Get and set the rtp encoding parameters.
4159 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
4160 EXPECT_EQ(1u, parameters.encodings.size());
4161
4162 parameters.encodings[0].max_bitrate_bps = 99999 - 1;
4163 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4164 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps,
4165 stream->GetVideoStreams()[0].max_bitrate_bps);
4166
4167 parameters.encodings[0].max_bitrate_bps = 99999 + 1;
4168 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4169 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4170 stream->GetVideoStreams()[0].max_bitrate_bps);
4171}
4172
eladalonf1841382017-06-12 01:16:46 -07004173TEST_F(WebRtcVideoChannelTest, SetMaxSendBitrateCanIncreaseSenderBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004174 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004175 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004176 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004177 channel_->SetSend(true);
4178
4179 FakeVideoSendStream* stream = AddSendStream();
4180
Niels Möller805a27e2019-01-21 12:21:27 +01004181 webrtc::test::FrameForwarder frame_forwarder;
4182 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Peter Boström3afc8c42016-01-27 16:45:21 +01004183
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004184 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
4185 int initial_max_bitrate_bps = streams[0].max_bitrate_bps;
4186 EXPECT_GT(initial_max_bitrate_bps, 0);
4187
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004188 parameters.max_bandwidth_bps = initial_max_bitrate_bps * 2;
4189 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström3afc8c42016-01-27 16:45:21 +01004190 // Insert a frame to update the encoder config.
Niels Möller805a27e2019-01-21 12:21:27 +01004191 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004192 streams = stream->GetVideoStreams();
4193 EXPECT_EQ(initial_max_bitrate_bps * 2, streams[0].max_bitrate_bps);
Niels Möllerff40b142018-04-09 08:49:14 +02004194 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004195}
4196
eladalonf1841382017-06-12 01:16:46 -07004197TEST_F(WebRtcVideoChannelTest,
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004198 SetMaxSendBitrateCanIncreaseSimulcastSenderBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004199 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004200 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004201 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004202 channel_->SetSend(true);
4203
4204 FakeVideoSendStream* stream = AddSendStream(
4205 cricket::CreateSimStreamParams("cname", MAKE_VECTOR(kSsrcs3)));
4206
4207 // Send a frame to make sure this scales up to >1 stream (simulcast).
Niels Möller805a27e2019-01-21 12:21:27 +01004208 webrtc::test::FrameForwarder frame_forwarder;
4209 EXPECT_TRUE(channel_->SetVideoSend(kSsrcs3[0], nullptr, &frame_forwarder));
4210 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004211
4212 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
4213 ASSERT_GT(streams.size(), 1u)
4214 << "Without simulcast this test doesn't make sense.";
pbosbe16f792015-10-16 12:49:39 -07004215 int initial_max_bitrate_bps = GetTotalMaxBitrateBps(streams);
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004216 EXPECT_GT(initial_max_bitrate_bps, 0);
4217
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004218 parameters.max_bandwidth_bps = initial_max_bitrate_bps * 2;
4219 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström3afc8c42016-01-27 16:45:21 +01004220 // Insert a frame to update the encoder config.
Niels Möller805a27e2019-01-21 12:21:27 +01004221 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004222 streams = stream->GetVideoStreams();
pbosbe16f792015-10-16 12:49:39 -07004223 int increased_max_bitrate_bps = GetTotalMaxBitrateBps(streams);
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004224 EXPECT_EQ(initial_max_bitrate_bps * 2, increased_max_bitrate_bps);
4225
Niels Möllerff40b142018-04-09 08:49:14 +02004226 EXPECT_TRUE(channel_->SetVideoSend(kSsrcs3[0], nullptr, nullptr));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004227}
4228
eladalonf1841382017-06-12 01:16:46 -07004229TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithMaxQuantization) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004230 static const char* kMaxQuantization = "21";
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004231 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004232 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004233 parameters.codecs[0].params[kCodecParamMaxQuantization] = kMaxQuantization;
4234 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Mirko Bonadeif859e552018-05-30 15:31:29 +02004235 EXPECT_EQ(atoi(kMaxQuantization),
pbos@webrtc.org6ae48c62014-06-06 10:49:19 +00004236 AddSendStream()->GetVideoStreams().back().max_qp);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004237
4238 VideoCodec codec;
4239 EXPECT_TRUE(channel_->GetSendCodec(&codec));
4240 EXPECT_EQ(kMaxQuantization, codec.params[kCodecParamMaxQuantization]);
4241}
4242
eladalonf1841382017-06-12 01:16:46 -07004243TEST_F(WebRtcVideoChannelTest, SetSendCodecsRejectBadPayloadTypes) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004244 // TODO(pbos): Should we only allow the dynamic range?
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00004245 static const int kIncorrectPayloads[] = {-2, -1, 128, 129};
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004246 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004247 parameters.codecs.push_back(GetEngineCodec("VP8"));
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00004248 for (size_t i = 0; i < arraysize(kIncorrectPayloads); ++i) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004249 parameters.codecs[0].id = kIncorrectPayloads[i];
4250 EXPECT_FALSE(channel_->SetSendParameters(parameters))
pkasting@chromium.orgd3245462015-02-23 21:28:22 +00004251 << "Bad payload type '" << kIncorrectPayloads[i] << "' accepted.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004252 }
4253}
4254
eladalonf1841382017-06-12 01:16:46 -07004255TEST_F(WebRtcVideoChannelTest, SetSendCodecsAcceptAllValidPayloadTypes) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004256 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004257 parameters.codecs.push_back(GetEngineCodec("VP8"));
magjedf823ede2016-11-12 09:53:04 -08004258 for (int payload_type = 96; payload_type <= 127; ++payload_type) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004259 parameters.codecs[0].id = payload_type;
4260 EXPECT_TRUE(channel_->SetSendParameters(parameters))
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004261 << "Payload type '" << payload_type << "' rejected.";
4262 }
4263}
4264
deadbeef67cf2c12016-04-13 10:07:16 -07004265// Test that setting the a different set of codecs but with an identical front
4266// codec doesn't result in the stream being recreated.
4267// This may happen when a subsequent negotiation includes fewer codecs, as a
4268// result of one of the codecs being rejected.
eladalonf1841382017-06-12 01:16:46 -07004269TEST_F(WebRtcVideoChannelTest,
deadbeef67cf2c12016-04-13 10:07:16 -07004270 SetSendCodecsIdenticalFirstCodecDoesntRecreateStream) {
4271 cricket::VideoSendParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08004272 parameters1.codecs.push_back(GetEngineCodec("VP8"));
4273 parameters1.codecs.push_back(GetEngineCodec("VP9"));
deadbeef67cf2c12016-04-13 10:07:16 -07004274 EXPECT_TRUE(channel_->SetSendParameters(parameters1));
4275
4276 AddSendStream();
4277 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
4278
4279 cricket::VideoSendParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08004280 parameters2.codecs.push_back(GetEngineCodec("VP8"));
deadbeef67cf2c12016-04-13 10:07:16 -07004281 EXPECT_TRUE(channel_->SetSendParameters(parameters2));
4282 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
4283}
4284
eladalonf1841382017-06-12 01:16:46 -07004285TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithOnlyVp8) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004286 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004287 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004288 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004289}
4290
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004291// Test that we set our inbound RTX codecs properly.
eladalonf1841382017-06-12 01:16:46 -07004292TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithRtx) {
magjed509e4fe2016-11-18 01:34:11 -08004293 const int kUnusedPayloadType1 = 126;
4294 const int kUnusedPayloadType2 = 127;
4295 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4296 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4297
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004298 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004299 parameters.codecs.push_back(GetEngineCodec("VP8"));
4300 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004301 parameters.codecs.push_back(rtx_codec);
4302 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004303 << "RTX codec without associated payload should be rejected.";
4304
magjed509e4fe2016-11-18 01:34:11 -08004305 parameters.codecs[1].SetParam("apt", kUnusedPayloadType2);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004306 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004307 << "RTX codec with invalid associated payload type should be rejected.";
4308
magjed509e4fe2016-11-18 01:34:11 -08004309 parameters.codecs[1].SetParam("apt", GetEngineCodec("VP8").id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004310 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004311
magjed509e4fe2016-11-18 01:34:11 -08004312 cricket::VideoCodec rtx_codec2(kUnusedPayloadType2, "rtx");
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004313 rtx_codec2.SetParam("apt", rtx_codec.id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004314 parameters.codecs.push_back(rtx_codec2);
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004315
Yves Gerey665174f2018-06-19 15:03:05 +02004316 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
4317 << "RTX codec with another RTX as associated payload type should be "
4318 "rejected.";
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004319}
4320
eladalonf1841382017-06-12 01:16:46 -07004321TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithChangedRtxPayloadType) {
brandtr14742122017-01-27 04:53:07 -08004322 const int kUnusedPayloadType1 = 126;
4323 const int kUnusedPayloadType2 = 127;
4324 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4325 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4326
4327 // SSRCs for RTX.
4328 cricket::StreamParams params =
4329 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
4330 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
4331 AddRecvStream(params);
4332
4333 // Original payload type for RTX.
4334 cricket::VideoRecvParameters parameters;
4335 parameters.codecs.push_back(GetEngineCodec("VP8"));
4336 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
4337 rtx_codec.SetParam("apt", GetEngineCodec("VP8").id);
4338 parameters.codecs.push_back(rtx_codec);
4339 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4340 ASSERT_EQ(1U, fake_call_->GetVideoReceiveStreams().size());
4341 const webrtc::VideoReceiveStream::Config& config_before =
4342 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
nisse26e3abb2017-08-25 04:44:25 -07004343 EXPECT_EQ(1U, config_before.rtp.rtx_associated_payload_types.size());
4344 const int* payload_type_before = FindKeyByValue(
4345 config_before.rtp.rtx_associated_payload_types, GetEngineCodec("VP8").id);
4346 ASSERT_NE(payload_type_before, nullptr);
4347 EXPECT_EQ(kUnusedPayloadType1, *payload_type_before);
brandtr14742122017-01-27 04:53:07 -08004348 EXPECT_EQ(kRtxSsrcs1[0], config_before.rtp.rtx_ssrc);
4349
4350 // Change payload type for RTX.
4351 parameters.codecs[1].id = kUnusedPayloadType2;
4352 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4353 ASSERT_EQ(1U, fake_call_->GetVideoReceiveStreams().size());
4354 const webrtc::VideoReceiveStream::Config& config_after =
4355 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
nisse26e3abb2017-08-25 04:44:25 -07004356 EXPECT_EQ(1U, config_after.rtp.rtx_associated_payload_types.size());
4357 const int* payload_type_after = FindKeyByValue(
4358 config_after.rtp.rtx_associated_payload_types, GetEngineCodec("VP8").id);
4359 ASSERT_NE(payload_type_after, nullptr);
4360 EXPECT_EQ(kUnusedPayloadType2, *payload_type_after);
brandtr14742122017-01-27 04:53:07 -08004361 EXPECT_EQ(kRtxSsrcs1[0], config_after.rtp.rtx_ssrc);
4362}
4363
eladalonf1841382017-06-12 01:16:46 -07004364TEST_F(WebRtcVideoChannelTest, SetRecvCodecsDifferentPayloadType) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004365 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004366 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004367 parameters.codecs[0].id = 99;
4368 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004369}
4370
eladalonf1841382017-06-12 01:16:46 -07004371TEST_F(WebRtcVideoChannelTest, SetRecvCodecsAcceptDefaultCodecs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004372 cricket::VideoRecvParameters parameters;
4373 parameters.codecs = engine_.codecs();
4374 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgccbed3b2014-07-11 13:02:54 +00004375
4376 FakeVideoReceiveStream* stream = AddRecvStream();
Tommi733b5472016-06-10 17:58:01 +02004377 const webrtc::VideoReceiveStream::Config& config = stream->GetConfig();
Niels Möllercb7e1d22018-09-11 15:56:04 +02004378 EXPECT_EQ(engine_.codecs()[0].name, config.decoders[0].video_format.name);
pbos@webrtc.org776e6f22014-10-29 15:28:39 +00004379 EXPECT_EQ(engine_.codecs()[0].id, config.decoders[0].payload_type);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004380}
4381
eladalonf1841382017-06-12 01:16:46 -07004382TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectUnsupportedCodec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004383 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004384 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkj26752742016-10-24 01:21:16 -07004385 parameters.codecs.push_back(VideoCodec(101, "WTF3"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004386 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004387}
4388
eladalonf1841382017-06-12 01:16:46 -07004389TEST_F(WebRtcVideoChannelTest, SetRecvCodecsAcceptsMultipleVideoCodecs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004390 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004391 parameters.codecs.push_back(GetEngineCodec("VP8"));
4392 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004393 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004394}
4395
eladalonf1841382017-06-12 01:16:46 -07004396TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithoutFecDisablesFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004397 cricket::VideoSendParameters send_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004398 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4399 send_parameters.codecs.push_back(GetEngineCodec("red"));
4400 send_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004401 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004402
4403 FakeVideoReceiveStream* stream = AddRecvStream();
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004404
magjed509e4fe2016-11-18 01:34:11 -08004405 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004406 stream->GetConfig().rtp.ulpfec_payload_type);
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004407
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004408 cricket::VideoRecvParameters recv_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004409 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004410 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00004411 stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004412 ASSERT_TRUE(stream != nullptr);
nisse3b3622f2017-09-26 02:49:21 -07004413 EXPECT_EQ(-1, stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004414 << "SetSendCodec without ULPFEC should disable current ULPFEC.";
4415}
4416
eladalonf1841382017-06-12 01:16:46 -07004417TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetRecvParamsWithoutFecDisablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004418 AddRecvStream(
4419 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08004420 const std::vector<FakeFlexfecReceiveStream*>& streams =
brandtr468da7c2016-11-22 02:16:47 -08004421 fake_call_->GetFlexfecReceiveStreams();
4422
4423 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004424 const FakeFlexfecReceiveStream* stream = streams.front();
4425 EXPECT_EQ(GetEngineCodec("flexfec-03").id, stream->GetConfig().payload_type);
4426 EXPECT_EQ(kFlexfecSsrc, stream->GetConfig().remote_ssrc);
4427 ASSERT_EQ(1U, stream->GetConfig().protected_media_ssrcs.size());
4428 EXPECT_EQ(kSsrcs1[0], stream->GetConfig().protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08004429
4430 cricket::VideoRecvParameters recv_parameters;
4431 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4432 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4433 EXPECT_TRUE(streams.empty())
4434 << "SetSendCodec without FlexFEC should disable current FlexFEC.";
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004435}
4436
eladalonf1841382017-06-12 01:16:46 -07004437TEST_F(WebRtcVideoChannelTest, SetSendParamsWithFecEnablesFec) {
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004438 FakeVideoReceiveStream* stream = AddRecvStream();
magjed509e4fe2016-11-18 01:34:11 -08004439 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004440 stream->GetConfig().rtp.ulpfec_payload_type);
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004441
4442 cricket::VideoRecvParameters recv_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004443 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4444 recv_parameters.codecs.push_back(GetEngineCodec("red"));
4445 recv_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004446 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4447 stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004448 ASSERT_TRUE(stream != nullptr);
magjed509e4fe2016-11-18 01:34:11 -08004449 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004450 stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004451 << "ULPFEC should be enabled on the receive stream.";
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004452
4453 cricket::VideoSendParameters send_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004454 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4455 send_parameters.codecs.push_back(GetEngineCodec("red"));
4456 send_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004457 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
4458 stream = fake_call_->GetVideoReceiveStreams()[0];
magjed509e4fe2016-11-18 01:34:11 -08004459 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004460 stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004461 << "ULPFEC should be enabled on the receive stream.";
4462}
4463
eladalonf1841382017-06-12 01:16:46 -07004464TEST_F(WebRtcVideoChannelFlexfecSendRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004465 SetSendRecvParamsWithFecEnablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004466 AddRecvStream(
4467 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08004468 const std::vector<FakeFlexfecReceiveStream*>& streams =
brandtr468da7c2016-11-22 02:16:47 -08004469 fake_call_->GetFlexfecReceiveStreams();
4470
4471 cricket::VideoRecvParameters recv_parameters;
4472 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4473 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4474 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4475 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004476 const FakeFlexfecReceiveStream* stream_with_recv_params = streams.front();
brandtr468da7c2016-11-22 02:16:47 -08004477 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9c3d4c42017-01-23 06:59:13 -08004478 stream_with_recv_params->GetConfig().payload_type);
4479 EXPECT_EQ(kFlexfecSsrc, stream_with_recv_params->GetConfig().remote_ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004480 EXPECT_EQ(1U,
brandtr9c3d4c42017-01-23 06:59:13 -08004481 stream_with_recv_params->GetConfig().protected_media_ssrcs.size());
brandtr468da7c2016-11-22 02:16:47 -08004482 EXPECT_EQ(kSsrcs1[0],
brandtr9c3d4c42017-01-23 06:59:13 -08004483 stream_with_recv_params->GetConfig().protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08004484
4485 cricket::VideoSendParameters send_parameters;
4486 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4487 send_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4488 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
4489 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004490 const FakeFlexfecReceiveStream* stream_with_send_params = streams.front();
brandtr468da7c2016-11-22 02:16:47 -08004491 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9c3d4c42017-01-23 06:59:13 -08004492 stream_with_send_params->GetConfig().payload_type);
4493 EXPECT_EQ(kFlexfecSsrc, stream_with_send_params->GetConfig().remote_ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004494 EXPECT_EQ(1U,
brandtr9c3d4c42017-01-23 06:59:13 -08004495 stream_with_send_params->GetConfig().protected_media_ssrcs.size());
brandtr468da7c2016-11-22 02:16:47 -08004496 EXPECT_EQ(kSsrcs1[0],
brandtr9c3d4c42017-01-23 06:59:13 -08004497 stream_with_send_params->GetConfig().protected_media_ssrcs[0]);
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004498}
4499
eladalonf1841382017-06-12 01:16:46 -07004500TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectDuplicateFecPayloads) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004501 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004502 parameters.codecs.push_back(GetEngineCodec("VP8"));
4503 parameters.codecs.push_back(GetEngineCodec("red"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004504 parameters.codecs[1].id = parameters.codecs[0].id;
4505 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004506}
4507
eladalonf1841382017-06-12 01:16:46 -07004508TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004509 SetRecvCodecsRejectDuplicateFecPayloads) {
brandtr468da7c2016-11-22 02:16:47 -08004510 cricket::VideoRecvParameters parameters;
4511 parameters.codecs.push_back(GetEngineCodec("VP8"));
4512 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4513 parameters.codecs[1].id = parameters.codecs[0].id;
4514 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
4515}
4516
eladalonf1841382017-06-12 01:16:46 -07004517TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectDuplicateCodecPayloads) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004518 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004519 parameters.codecs.push_back(GetEngineCodec("VP8"));
4520 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004521 parameters.codecs[1].id = parameters.codecs[0].id;
4522 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004523}
4524
eladalonf1841382017-06-12 01:16:46 -07004525TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004526 SetRecvCodecsAcceptSameCodecOnMultiplePayloadTypes) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004527 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004528 parameters.codecs.push_back(GetEngineCodec("VP8"));
4529 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004530 parameters.codecs[1].id += 1;
4531 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004532}
4533
deadbeef67cf2c12016-04-13 10:07:16 -07004534// Test that setting the same codecs but with a different order
deadbeef874ca3a2015-08-20 17:19:20 -07004535// doesn't result in the stream being recreated.
eladalonf1841382017-06-12 01:16:46 -07004536TEST_F(WebRtcVideoChannelTest,
deadbeef67cf2c12016-04-13 10:07:16 -07004537 SetRecvCodecsDifferentOrderDoesntRecreateStream) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004538 cricket::VideoRecvParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08004539 parameters1.codecs.push_back(GetEngineCodec("VP8"));
4540 parameters1.codecs.push_back(GetEngineCodec("red"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004541 EXPECT_TRUE(channel_->SetRecvParameters(parameters1));
deadbeef874ca3a2015-08-20 17:19:20 -07004542
4543 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
4544 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
4545
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004546 cricket::VideoRecvParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08004547 parameters2.codecs.push_back(GetEngineCodec("red"));
4548 parameters2.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004549 EXPECT_TRUE(channel_->SetRecvParameters(parameters2));
deadbeef874ca3a2015-08-20 17:19:20 -07004550 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
4551}
4552
eladalonf1841382017-06-12 01:16:46 -07004553TEST_F(WebRtcVideoChannelTest, SendStreamNotSendingByDefault) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004554 EXPECT_FALSE(AddSendStream()->IsSending());
4555}
4556
eladalonf1841382017-06-12 01:16:46 -07004557TEST_F(WebRtcVideoChannelTest, ReceiveStreamReceivingByDefault) {
pbos@webrtc.org85f42942014-07-22 09:14:58 +00004558 EXPECT_TRUE(AddRecvStream()->IsReceiving());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004559}
4560
eladalonf1841382017-06-12 01:16:46 -07004561TEST_F(WebRtcVideoChannelTest, SetSend) {
pbos@webrtc.org5301b0f2014-07-17 08:51:46 +00004562 FakeVideoSendStream* stream = AddSendStream();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004563 EXPECT_FALSE(stream->IsSending());
4564
4565 // false->true
4566 EXPECT_TRUE(channel_->SetSend(true));
4567 EXPECT_TRUE(stream->IsSending());
4568 // true->true
4569 EXPECT_TRUE(channel_->SetSend(true));
4570 EXPECT_TRUE(stream->IsSending());
4571 // true->false
4572 EXPECT_TRUE(channel_->SetSend(false));
4573 EXPECT_FALSE(stream->IsSending());
4574 // false->false
4575 EXPECT_TRUE(channel_->SetSend(false));
4576 EXPECT_FALSE(stream->IsSending());
4577
4578 EXPECT_TRUE(channel_->SetSend(true));
4579 FakeVideoSendStream* new_stream = AddSendStream();
4580 EXPECT_TRUE(new_stream->IsSending())
4581 << "Send stream created after SetSend(true) not sending initially.";
4582}
4583
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004584// This test verifies DSCP settings are properly applied on video media channel.
eladalonf1841382017-06-12 01:16:46 -07004585TEST_F(WebRtcVideoChannelTest, TestSetDscpOptions) {
kwiberg686a8ef2016-02-26 03:00:35 -08004586 std::unique_ptr<cricket::FakeNetworkInterface> network_interface(
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004587 new cricket::FakeNetworkInterface);
nisse51542be2016-02-12 02:27:06 -08004588 MediaConfig config;
Tim Haloun6ca98362018-09-17 17:06:08 -07004589 std::unique_ptr<cricket::WebRtcVideoChannel> channel;
Tim Haloun648d28a2018-10-18 16:52:22 -07004590 webrtc::RtpParameters parameters;
nisse51542be2016-02-12 02:27:06 -08004591
Sebastian Jansson84848f22018-11-16 10:40:36 +01004592 channel.reset(
4593 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
4594 call_.get(), config, VideoOptions(), webrtc::CryptoOptions())));
Anton Sukhanov98a462c2018-10-17 13:15:42 -07004595 channel->SetInterface(network_interface.get(), /*media_transport=*/nullptr);
nisse51542be2016-02-12 02:27:06 -08004596 // Default value when DSCP is disabled should be DSCP_DEFAULT.
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004597 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
nisse51542be2016-02-12 02:27:06 -08004598
Tim Haloun648d28a2018-10-18 16:52:22 -07004599 // Default value when DSCP is enabled is also DSCP_DEFAULT, until it is set
4600 // through rtp parameters.
nisse51542be2016-02-12 02:27:06 -08004601 config.enable_dscp = true;
Sebastian Jansson84848f22018-11-16 10:40:36 +01004602 channel.reset(
4603 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
4604 call_.get(), config, VideoOptions(), webrtc::CryptoOptions())));
Anton Sukhanov98a462c2018-10-17 13:15:42 -07004605 channel->SetInterface(network_interface.get(), /*media_transport=*/nullptr);
Tim Haloun648d28a2018-10-18 16:52:22 -07004606 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
4607
4608 // Create a send stream to configure
4609 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
4610 parameters = channel->GetRtpSendParameters(kSsrc);
4611 ASSERT_FALSE(parameters.encodings.empty());
4612
4613 // Various priorities map to various dscp values.
4614 parameters.encodings[0].network_priority = 4.0;
4615 ASSERT_TRUE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
nisse51542be2016-02-12 02:27:06 -08004616 EXPECT_EQ(rtc::DSCP_AF41, network_interface->dscp());
Tim Haloun648d28a2018-10-18 16:52:22 -07004617 parameters.encodings[0].network_priority = 0.5;
4618 ASSERT_TRUE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
4619 EXPECT_EQ(rtc::DSCP_CS1, network_interface->dscp());
4620
4621 // A bad priority does not change the dscp value.
4622 parameters.encodings[0].network_priority = 0.0;
4623 ASSERT_FALSE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
4624 EXPECT_EQ(rtc::DSCP_CS1, network_interface->dscp());
nisse51542be2016-02-12 02:27:06 -08004625
Tim Haloun6ca98362018-09-17 17:06:08 -07004626 // Packets should also self-identify their dscp in PacketOptions.
4627 const uint8_t kData[10] = {0};
4628 EXPECT_TRUE(static_cast<webrtc::Transport*>(channel.get())
4629 ->SendRtcp(kData, sizeof(kData)));
Tim Haloun648d28a2018-10-18 16:52:22 -07004630 EXPECT_EQ(rtc::DSCP_CS1, network_interface->options().dscp);
Tim Haloun6ca98362018-09-17 17:06:08 -07004631
nisse51542be2016-02-12 02:27:06 -08004632 // Verify that setting the option to false resets the
4633 // DiffServCodePoint.
4634 config.enable_dscp = false;
Sebastian Jansson84848f22018-11-16 10:40:36 +01004635 channel.reset(
4636 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
4637 call_.get(), config, VideoOptions(), webrtc::CryptoOptions())));
Anton Sukhanov98a462c2018-10-17 13:15:42 -07004638 channel->SetInterface(network_interface.get(), /*media_transport=*/nullptr);
nisse51542be2016-02-12 02:27:06 -08004639 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004640}
4641
deadbeef13871492015-12-09 12:37:51 -08004642// This test verifies that the RTCP reduced size mode is properly applied to
4643// send video streams.
eladalonf1841382017-06-12 01:16:46 -07004644TEST_F(WebRtcVideoChannelTest, TestSetSendRtcpReducedSize) {
deadbeef13871492015-12-09 12:37:51 -08004645 // Create stream, expecting that default mode is "compound".
4646 FakeVideoSendStream* stream1 = AddSendStream();
4647 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream1->GetConfig().rtp.rtcp_mode);
Florent Castellidacec712018-05-24 16:24:21 +02004648 webrtc::RtpParameters rtp_parameters =
4649 channel_->GetRtpSendParameters(last_ssrc_);
4650 EXPECT_FALSE(rtp_parameters.rtcp.reduced_size);
deadbeef13871492015-12-09 12:37:51 -08004651
4652 // Now enable reduced size mode.
4653 send_parameters_.rtcp.reduced_size = true;
4654 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
4655 stream1 = fake_call_->GetVideoSendStreams()[0];
4656 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream1->GetConfig().rtp.rtcp_mode);
Florent Castellidacec712018-05-24 16:24:21 +02004657 rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
4658 EXPECT_TRUE(rtp_parameters.rtcp.reduced_size);
deadbeef13871492015-12-09 12:37:51 -08004659
4660 // Create a new stream and ensure it picks up the reduced size mode.
4661 FakeVideoSendStream* stream2 = AddSendStream();
4662 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream2->GetConfig().rtp.rtcp_mode);
4663}
4664
4665// This test verifies that the RTCP reduced size mode is properly applied to
4666// receive video streams.
eladalonf1841382017-06-12 01:16:46 -07004667TEST_F(WebRtcVideoChannelTest, TestSetRecvRtcpReducedSize) {
deadbeef13871492015-12-09 12:37:51 -08004668 // Create stream, expecting that default mode is "compound".
4669 FakeVideoReceiveStream* stream1 = AddRecvStream();
4670 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream1->GetConfig().rtp.rtcp_mode);
4671
4672 // Now enable reduced size mode.
Taylor Brandstetter5f0b83b2016-03-18 15:02:07 -07004673 // TODO(deadbeef): Once "recv_parameters" becomes "receiver_parameters",
4674 // the reduced_size flag should come from that.
4675 send_parameters_.rtcp.reduced_size = true;
4676 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
deadbeef13871492015-12-09 12:37:51 -08004677 stream1 = fake_call_->GetVideoReceiveStreams()[0];
4678 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream1->GetConfig().rtp.rtcp_mode);
4679
4680 // Create a new stream and ensure it picks up the reduced size mode.
4681 FakeVideoReceiveStream* stream2 = AddRecvStream();
4682 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream2->GetConfig().rtp.rtcp_mode);
4683}
4684
eladalonf1841382017-06-12 01:16:46 -07004685TEST_F(WebRtcVideoChannelTest, OnReadyToSendSignalsNetworkState) {
skvlad7a43d252016-03-22 15:32:27 -07004686 EXPECT_EQ(webrtc::kNetworkUp,
4687 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4688 EXPECT_EQ(webrtc::kNetworkUp,
4689 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.org26c0c412014-09-03 16:17:12 +00004690
4691 channel_->OnReadyToSend(false);
skvlad7a43d252016-03-22 15:32:27 -07004692 EXPECT_EQ(webrtc::kNetworkDown,
4693 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4694 EXPECT_EQ(webrtc::kNetworkUp,
4695 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.org26c0c412014-09-03 16:17:12 +00004696
4697 channel_->OnReadyToSend(true);
skvlad7a43d252016-03-22 15:32:27 -07004698 EXPECT_EQ(webrtc::kNetworkUp,
4699 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4700 EXPECT_EQ(webrtc::kNetworkUp,
4701 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004702}
4703
eladalonf1841382017-06-12 01:16:46 -07004704TEST_F(WebRtcVideoChannelTest, GetStatsReportsSentCodecName) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004705 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004706 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004707 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström74d9ed72015-03-26 16:28:31 +01004708
4709 AddSendStream();
4710
4711 cricket::VideoMediaInfo info;
4712 ASSERT_TRUE(channel_->GetStats(&info));
magjed509e4fe2016-11-18 01:34:11 -08004713 EXPECT_EQ("VP8", info.senders[0].codec_name);
Peter Boström74d9ed72015-03-26 16:28:31 +01004714}
4715
eladalonf1841382017-06-12 01:16:46 -07004716TEST_F(WebRtcVideoChannelTest, GetStatsReportsEncoderImplementationName) {
Peter Boströmb7d9a972015-12-18 16:01:11 +01004717 FakeVideoSendStream* stream = AddSendStream();
4718 webrtc::VideoSendStream::Stats stats;
4719 stats.encoder_implementation_name = "encoder_implementation_name";
4720 stream->SetStats(stats);
4721
4722 cricket::VideoMediaInfo info;
4723 ASSERT_TRUE(channel_->GetStats(&info));
4724 EXPECT_EQ(stats.encoder_implementation_name,
4725 info.senders[0].encoder_implementation_name);
4726}
4727
eladalonf1841382017-06-12 01:16:46 -07004728TEST_F(WebRtcVideoChannelTest, GetStatsReportsCpuOveruseMetrics) {
pbos@webrtc.org3e6e2712015-02-26 12:19:31 +00004729 FakeVideoSendStream* stream = AddSendStream();
4730 webrtc::VideoSendStream::Stats stats;
4731 stats.avg_encode_time_ms = 13;
4732 stats.encode_usage_percent = 42;
4733 stream->SetStats(stats);
4734
4735 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004736 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org3e6e2712015-02-26 12:19:31 +00004737 EXPECT_EQ(stats.avg_encode_time_ms, info.senders[0].avg_encode_ms);
4738 EXPECT_EQ(stats.encode_usage_percent, info.senders[0].encode_usage_percent);
4739}
4740
eladalonf1841382017-06-12 01:16:46 -07004741TEST_F(WebRtcVideoChannelTest, GetStatsReportsFramesEncoded) {
sakal43536c32016-10-24 01:46:43 -07004742 FakeVideoSendStream* stream = AddSendStream();
4743 webrtc::VideoSendStream::Stats stats;
4744 stats.frames_encoded = 13;
4745 stream->SetStats(stats);
4746
4747 cricket::VideoMediaInfo info;
4748 ASSERT_TRUE(channel_->GetStats(&info));
4749 EXPECT_EQ(stats.frames_encoded, info.senders[0].frames_encoded);
4750}
4751
eladalonf1841382017-06-12 01:16:46 -07004752TEST_F(WebRtcVideoChannelTest, GetStatsReportsQpSum) {
sakal87da4042016-10-31 06:53:47 -07004753 FakeVideoSendStream* stream = AddSendStream();
4754 webrtc::VideoSendStream::Stats stats;
Oskar Sundbom78807582017-11-16 11:09:55 +01004755 stats.qp_sum = 13;
sakal87da4042016-10-31 06:53:47 -07004756 stream->SetStats(stats);
4757
4758 cricket::VideoMediaInfo info;
4759 ASSERT_TRUE(channel_->GetStats(&info));
4760 EXPECT_EQ(stats.qp_sum, info.senders[0].qp_sum);
4761}
4762
eladalonf1841382017-06-12 01:16:46 -07004763TEST_F(WebRtcVideoChannelTest, GetStatsReportsUpperResolution) {
pbos@webrtc.org273a4142014-12-01 15:23:21 +00004764 FakeVideoSendStream* stream = AddSendStream();
4765 webrtc::VideoSendStream::Stats stats;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004766 stats.substreams[17].width = 123;
4767 stats.substreams[17].height = 40;
4768 stats.substreams[42].width = 80;
4769 stats.substreams[42].height = 31;
4770 stats.substreams[11].width = 20;
4771 stats.substreams[11].height = 90;
pbos@webrtc.org273a4142014-12-01 15:23:21 +00004772 stream->SetStats(stats);
4773
4774 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004775 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org273a4142014-12-01 15:23:21 +00004776 ASSERT_EQ(1u, info.senders.size());
4777 EXPECT_EQ(123, info.senders[0].send_frame_width);
4778 EXPECT_EQ(90, info.senders[0].send_frame_height);
4779}
4780
eladalonf1841382017-06-12 01:16:46 -07004781TEST_F(WebRtcVideoChannelTest, GetStatsReportsCpuAdaptationStats) {
perkj803d97f2016-11-01 11:45:46 -07004782 FakeVideoSendStream* stream = AddSendStream();
4783 webrtc::VideoSendStream::Stats stats;
4784 stats.number_of_cpu_adapt_changes = 2;
4785 stats.cpu_limited_resolution = true;
4786 stream->SetStats(stats);
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004787
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004788 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004789 EXPECT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004790 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07004791 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_CPU, info.senders[0].adapt_reason);
perkj803d97f2016-11-01 11:45:46 -07004792 EXPECT_EQ(stats.number_of_cpu_adapt_changes, info.senders[0].adapt_changes);
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004793}
4794
eladalonf1841382017-06-12 01:16:46 -07004795TEST_F(WebRtcVideoChannelTest, GetStatsReportsAdaptationAndBandwidthStats) {
perkj803d97f2016-11-01 11:45:46 -07004796 FakeVideoSendStream* stream = AddSendStream();
asapersson17821db2015-12-14 02:08:12 -08004797 webrtc::VideoSendStream::Stats stats;
perkj803d97f2016-11-01 11:45:46 -07004798 stats.number_of_cpu_adapt_changes = 2;
4799 stats.cpu_limited_resolution = true;
asapersson17821db2015-12-14 02:08:12 -08004800 stats.bw_limited_resolution = true;
perkj803d97f2016-11-01 11:45:46 -07004801 stream->SetStats(stats);
4802
4803 cricket::VideoMediaInfo info;
asapersson17821db2015-12-14 02:08:12 -08004804 EXPECT_TRUE(channel_->GetStats(&info));
4805 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07004806 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_CPU |
4807 WebRtcVideoChannel::ADAPTREASON_BANDWIDTH,
asapersson17821db2015-12-14 02:08:12 -08004808 info.senders[0].adapt_reason);
perkj803d97f2016-11-01 11:45:46 -07004809 EXPECT_EQ(stats.number_of_cpu_adapt_changes, info.senders[0].adapt_changes);
asapersson17821db2015-12-14 02:08:12 -08004810}
4811
eladalonf1841382017-06-12 01:16:46 -07004812TEST_F(WebRtcVideoChannelTest,
asapersson17821db2015-12-14 02:08:12 -08004813 GetStatsTranslatesBandwidthLimitedResolutionCorrectly) {
4814 FakeVideoSendStream* stream = AddSendStream();
4815 webrtc::VideoSendStream::Stats stats;
4816 stats.bw_limited_resolution = true;
4817 stream->SetStats(stats);
4818
4819 cricket::VideoMediaInfo info;
4820 EXPECT_TRUE(channel_->GetStats(&info));
4821 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07004822 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_BANDWIDTH,
asapersson17821db2015-12-14 02:08:12 -08004823 info.senders[0].adapt_reason);
4824}
4825
Yves Gerey665174f2018-06-19 15:03:05 +02004826TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesSendRtcpPacketTypesCorrectly) {
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004827 FakeVideoSendStream* stream = AddSendStream();
4828 webrtc::VideoSendStream::Stats stats;
4829 stats.substreams[17].rtcp_packet_type_counts.fir_packets = 2;
4830 stats.substreams[17].rtcp_packet_type_counts.nack_packets = 3;
4831 stats.substreams[17].rtcp_packet_type_counts.pli_packets = 4;
4832
4833 stats.substreams[42].rtcp_packet_type_counts.fir_packets = 5;
4834 stats.substreams[42].rtcp_packet_type_counts.nack_packets = 7;
4835 stats.substreams[42].rtcp_packet_type_counts.pli_packets = 9;
4836
4837 stream->SetStats(stats);
4838
4839 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004840 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004841 EXPECT_EQ(7, info.senders[0].firs_rcvd);
4842 EXPECT_EQ(10, info.senders[0].nacks_rcvd);
4843 EXPECT_EQ(13, info.senders[0].plis_rcvd);
4844}
4845
eladalonf1841382017-06-12 01:16:46 -07004846TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004847 GetStatsTranslatesReceiveRtcpPacketTypesCorrectly) {
4848 FakeVideoReceiveStream* stream = AddRecvStream();
4849 webrtc::VideoReceiveStream::Stats stats;
4850 stats.rtcp_packet_type_counts.fir_packets = 2;
4851 stats.rtcp_packet_type_counts.nack_packets = 3;
4852 stats.rtcp_packet_type_counts.pli_packets = 4;
4853 stream->SetStats(stats);
4854
4855 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004856 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004857 EXPECT_EQ(stats.rtcp_packet_type_counts.fir_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004858 rtc::checked_cast<unsigned int>(info.receivers[0].firs_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004859 EXPECT_EQ(stats.rtcp_packet_type_counts.nack_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004860 rtc::checked_cast<unsigned int>(info.receivers[0].nacks_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004861 EXPECT_EQ(stats.rtcp_packet_type_counts.pli_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004862 rtc::checked_cast<unsigned int>(info.receivers[0].plis_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004863}
4864
eladalonf1841382017-06-12 01:16:46 -07004865TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesDecodeStatsCorrectly) {
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004866 FakeVideoReceiveStream* stream = AddRecvStream();
4867 webrtc::VideoReceiveStream::Stats stats;
Peter Boströmb7d9a972015-12-18 16:01:11 +01004868 stats.decoder_implementation_name = "decoder_implementation_name";
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004869 stats.decode_ms = 2;
4870 stats.max_decode_ms = 3;
4871 stats.current_delay_ms = 4;
4872 stats.target_delay_ms = 5;
4873 stats.jitter_buffer_ms = 6;
4874 stats.min_playout_delay_ms = 7;
4875 stats.render_delay_ms = 8;
asapersson26dd92b2016-08-30 00:45:45 -07004876 stats.width = 9;
4877 stats.height = 10;
hbos42f6d2f2017-01-20 03:56:50 -08004878 stats.frame_counts.key_frames = 11;
4879 stats.frame_counts.delta_frames = 12;
hbos50cfe1f2017-01-23 07:21:55 -08004880 stats.frames_rendered = 13;
4881 stats.frames_decoded = 14;
Oskar Sundbom78807582017-11-16 11:09:55 +01004882 stats.qp_sum = 15;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004883 stream->SetStats(stats);
4884
4885 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004886 ASSERT_TRUE(channel_->GetStats(&info));
Peter Boströmb7d9a972015-12-18 16:01:11 +01004887 EXPECT_EQ(stats.decoder_implementation_name,
4888 info.receivers[0].decoder_implementation_name);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004889 EXPECT_EQ(stats.decode_ms, info.receivers[0].decode_ms);
4890 EXPECT_EQ(stats.max_decode_ms, info.receivers[0].max_decode_ms);
4891 EXPECT_EQ(stats.current_delay_ms, info.receivers[0].current_delay_ms);
4892 EXPECT_EQ(stats.target_delay_ms, info.receivers[0].target_delay_ms);
4893 EXPECT_EQ(stats.jitter_buffer_ms, info.receivers[0].jitter_buffer_ms);
4894 EXPECT_EQ(stats.min_playout_delay_ms, info.receivers[0].min_playout_delay_ms);
4895 EXPECT_EQ(stats.render_delay_ms, info.receivers[0].render_delay_ms);
asapersson26dd92b2016-08-30 00:45:45 -07004896 EXPECT_EQ(stats.width, info.receivers[0].frame_width);
4897 EXPECT_EQ(stats.height, info.receivers[0].frame_height);
Mirko Bonadeif859e552018-05-30 15:31:29 +02004898 EXPECT_EQ(rtc::checked_cast<unsigned int>(stats.frame_counts.key_frames +
4899 stats.frame_counts.delta_frames),
hbos42f6d2f2017-01-20 03:56:50 -08004900 info.receivers[0].frames_received);
hbos50cfe1f2017-01-23 07:21:55 -08004901 EXPECT_EQ(stats.frames_rendered, info.receivers[0].frames_rendered);
sakale5ba44e2016-10-26 07:09:24 -07004902 EXPECT_EQ(stats.frames_decoded, info.receivers[0].frames_decoded);
sakalcc452e12017-02-09 04:53:45 -08004903 EXPECT_EQ(stats.qp_sum, info.receivers[0].qp_sum);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004904}
4905
eladalonf1841382017-06-12 01:16:46 -07004906TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesReceivePacketStatsCorrectly) {
Peter Boström393347f2015-04-22 14:52:45 +02004907 FakeVideoReceiveStream* stream = AddRecvStream();
4908 webrtc::VideoReceiveStream::Stats stats;
4909 stats.rtp_stats.transmitted.payload_bytes = 2;
4910 stats.rtp_stats.transmitted.header_bytes = 3;
4911 stats.rtp_stats.transmitted.padding_bytes = 4;
4912 stats.rtp_stats.transmitted.packets = 5;
srte186d9c32017-08-04 05:03:53 -07004913 stats.rtcp_stats.packets_lost = 6;
Peter Boström393347f2015-04-22 14:52:45 +02004914 stats.rtcp_stats.fraction_lost = 7;
4915 stream->SetStats(stats);
4916
4917 cricket::VideoMediaInfo info;
4918 ASSERT_TRUE(channel_->GetStats(&info));
4919 EXPECT_EQ(stats.rtp_stats.transmitted.payload_bytes +
4920 stats.rtp_stats.transmitted.header_bytes +
4921 stats.rtp_stats.transmitted.padding_bytes,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004922 rtc::checked_cast<size_t>(info.receivers[0].bytes_rcvd));
Peter Boström393347f2015-04-22 14:52:45 +02004923 EXPECT_EQ(stats.rtp_stats.transmitted.packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004924 rtc::checked_cast<unsigned int>(info.receivers[0].packets_rcvd));
srte186d9c32017-08-04 05:03:53 -07004925 EXPECT_EQ(stats.rtcp_stats.packets_lost, info.receivers[0].packets_lost);
Mirko Bonadeif859e552018-05-30 15:31:29 +02004926 EXPECT_EQ(rtc::checked_cast<float>(stats.rtcp_stats.fraction_lost) / (1 << 8),
Peter Boström393347f2015-04-22 14:52:45 +02004927 info.receivers[0].fraction_lost);
4928}
4929
eladalonf1841382017-06-12 01:16:46 -07004930TEST_F(WebRtcVideoChannelTest, TranslatesCallStatsCorrectly) {
pbos@webrtc.org2b19f062014-12-11 13:26:09 +00004931 AddSendStream();
4932 AddSendStream();
4933 webrtc::Call::Stats stats;
4934 stats.rtt_ms = 123;
4935 fake_call_->SetStats(stats);
4936
4937 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004938 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org2b19f062014-12-11 13:26:09 +00004939 ASSERT_EQ(2u, info.senders.size());
4940 EXPECT_EQ(stats.rtt_ms, info.senders[0].rtt_ms);
4941 EXPECT_EQ(stats.rtt_ms, info.senders[1].rtt_ms);
4942}
4943
eladalonf1841382017-06-12 01:16:46 -07004944TEST_F(WebRtcVideoChannelTest, TranslatesSenderBitrateStatsCorrectly) {
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004945 FakeVideoSendStream* stream = AddSendStream();
4946 webrtc::VideoSendStream::Stats stats;
pbos@webrtc.org891d4832015-02-26 13:15:22 +00004947 stats.target_media_bitrate_bps = 156;
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004948 stats.media_bitrate_bps = 123;
4949 stats.substreams[17].total_bitrate_bps = 1;
4950 stats.substreams[17].retransmit_bitrate_bps = 2;
4951 stats.substreams[42].total_bitrate_bps = 3;
4952 stats.substreams[42].retransmit_bitrate_bps = 4;
4953 stream->SetStats(stats);
4954
4955 FakeVideoSendStream* stream2 = AddSendStream();
4956 webrtc::VideoSendStream::Stats stats2;
pbos@webrtc.org891d4832015-02-26 13:15:22 +00004957 stats2.target_media_bitrate_bps = 200;
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004958 stats2.media_bitrate_bps = 321;
4959 stats2.substreams[13].total_bitrate_bps = 5;
4960 stats2.substreams[13].retransmit_bitrate_bps = 6;
4961 stats2.substreams[21].total_bitrate_bps = 7;
4962 stats2.substreams[21].retransmit_bitrate_bps = 8;
4963 stream2->SetStats(stats2);
4964
4965 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004966 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004967 ASSERT_EQ(2u, info.senders.size());
stefanf79ade12017-06-02 06:44:03 -07004968 BandwidthEstimationInfo bwe_info;
4969 channel_->FillBitrateInfo(&bwe_info);
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004970 // Assuming stream and stream2 corresponds to senders[0] and [1] respectively
4971 // is OK as std::maps are sorted and AddSendStream() gives increasing SSRCs.
4972 EXPECT_EQ(stats.media_bitrate_bps, info.senders[0].nominal_bitrate);
4973 EXPECT_EQ(stats2.media_bitrate_bps, info.senders[1].nominal_bitrate);
pbos@webrtc.org891d4832015-02-26 13:15:22 +00004974 EXPECT_EQ(stats.target_media_bitrate_bps + stats2.target_media_bitrate_bps,
stefanf79ade12017-06-02 06:44:03 -07004975 bwe_info.target_enc_bitrate);
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004976 EXPECT_EQ(stats.media_bitrate_bps + stats2.media_bitrate_bps,
stefanf79ade12017-06-02 06:44:03 -07004977 bwe_info.actual_enc_bitrate);
4978 EXPECT_EQ(1 + 3 + 5 + 7, bwe_info.transmit_bitrate)
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004979 << "Bandwidth stats should take all streams into account.";
stefanf79ade12017-06-02 06:44:03 -07004980 EXPECT_EQ(2 + 4 + 6 + 8, bwe_info.retransmit_bitrate)
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004981 << "Bandwidth stats should take all streams into account.";
4982}
4983
eladalonf1841382017-06-12 01:16:46 -07004984TEST_F(WebRtcVideoChannelTest, DefaultReceiveStreamReconfiguresToUseRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004985 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004986
Peter Boström0c4e06b2015-10-07 12:23:21 +02004987 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
4988 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004989
4990 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
4991 const size_t kDataLength = 12;
4992 uint8_t data[kDataLength];
4993 memset(data, 0, sizeof(data));
4994 rtc::SetBE32(&data[8], ssrcs[0]);
jbaucheec21bd2016-03-20 06:15:43 -07004995 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07004996 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004997
4998 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
4999 << "No default receive stream created.";
5000 FakeVideoReceiveStream* recv_stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr14742122017-01-27 04:53:07 -08005001 EXPECT_EQ(0u, recv_stream->GetConfig().rtp.rtx_ssrc)
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005002 << "Default receive stream should not have configured RTX";
5003
5004 EXPECT_TRUE(channel_->AddRecvStream(
5005 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs)));
5006 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
brandtr14742122017-01-27 04:53:07 -08005007 << "AddRecvStream should have reconfigured, not added a new receiver.";
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005008 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
nisse26e3abb2017-08-25 04:44:25 -07005009 EXPECT_FALSE(
5010 recv_stream->GetConfig().rtp.rtx_associated_payload_types.empty());
nisseca5706d2017-09-11 02:32:16 -07005011 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
Peter Boströmd8b01092016-05-12 16:44:36 +02005012 << "RTX should be mapped for all decoders/payload types.";
nisseca5706d2017-09-11 02:32:16 -07005013 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02005014 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07005015 << "RTX should be mapped also for the RED payload type";
brandtr14742122017-01-27 04:53:07 -08005016 EXPECT_EQ(rtx_ssrcs[0], recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005017}
5018
eladalonf1841382017-06-12 01:16:46 -07005019TEST_F(WebRtcVideoChannelTest, RejectsAddingStreamsWithMissingSsrcsForRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005020 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd4362cd2015-03-25 14:17:23 +01005021
Peter Boström0c4e06b2015-10-07 12:23:21 +02005022 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
5023 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
Peter Boströmd4362cd2015-03-25 14:17:23 +01005024
5025 StreamParams sp =
5026 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs);
5027 sp.ssrcs = ssrcs; // Without RTXs, this is the important part.
5028
5029 EXPECT_FALSE(channel_->AddSendStream(sp));
5030 EXPECT_FALSE(channel_->AddRecvStream(sp));
5031}
5032
eladalonf1841382017-06-12 01:16:46 -07005033TEST_F(WebRtcVideoChannelTest, RejectsAddingStreamsWithOverlappingRtxSsrcs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005034 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005035
Peter Boström0c4e06b2015-10-07 12:23:21 +02005036 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
5037 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
Peter Boströmd6f4c252015-03-26 16:23:04 +01005038
5039 StreamParams sp =
5040 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs);
5041
5042 EXPECT_TRUE(channel_->AddSendStream(sp));
5043 EXPECT_TRUE(channel_->AddRecvStream(sp));
5044
5045 // The RTX SSRC is already used in previous streams, using it should fail.
5046 sp = cricket::StreamParams::CreateLegacy(rtx_ssrcs[0]);
5047 EXPECT_FALSE(channel_->AddSendStream(sp));
5048 EXPECT_FALSE(channel_->AddRecvStream(sp));
5049
5050 // After removing the original stream this should be fine to add (makes sure
5051 // that RTX ssrcs are not forever taken).
5052 EXPECT_TRUE(channel_->RemoveSendStream(ssrcs[0]));
5053 EXPECT_TRUE(channel_->RemoveRecvStream(ssrcs[0]));
5054 EXPECT_TRUE(channel_->AddSendStream(sp));
5055 EXPECT_TRUE(channel_->AddRecvStream(sp));
5056}
5057
eladalonf1841382017-06-12 01:16:46 -07005058TEST_F(WebRtcVideoChannelTest,
Peter Boströmd6f4c252015-03-26 16:23:04 +01005059 RejectsAddingStreamsWithOverlappingSimulcastSsrcs) {
Peter Boström0c4e06b2015-10-07 12:23:21 +02005060 static const uint32_t kFirstStreamSsrcs[] = {1, 2, 3};
5061 static const uint32_t kOverlappingStreamSsrcs[] = {4, 3, 5};
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005062 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005063
Peter Boströmd6f4c252015-03-26 16:23:04 +01005064 StreamParams sp =
5065 cricket::CreateSimStreamParams("cname", MAKE_VECTOR(kFirstStreamSsrcs));
5066
5067 EXPECT_TRUE(channel_->AddSendStream(sp));
5068 EXPECT_TRUE(channel_->AddRecvStream(sp));
5069
5070 // One of the SSRCs is already used in previous streams, using it should fail.
5071 sp = cricket::CreateSimStreamParams("cname",
5072 MAKE_VECTOR(kOverlappingStreamSsrcs));
5073 EXPECT_FALSE(channel_->AddSendStream(sp));
5074 EXPECT_FALSE(channel_->AddRecvStream(sp));
5075
5076 // After removing the original stream this should be fine to add (makes sure
5077 // that RTX ssrcs are not forever taken).
Peter Boström3548dd22015-05-22 18:48:36 +02005078 EXPECT_TRUE(channel_->RemoveSendStream(kFirstStreamSsrcs[0]));
5079 EXPECT_TRUE(channel_->RemoveRecvStream(kFirstStreamSsrcs[0]));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005080 EXPECT_TRUE(channel_->AddSendStream(sp));
5081 EXPECT_TRUE(channel_->AddRecvStream(sp));
5082}
5083
eladalonf1841382017-06-12 01:16:46 -07005084TEST_F(WebRtcVideoChannelTest, ReportsSsrcGroupsInStats) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005085 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boström259bd202015-05-28 13:39:50 +02005086
5087 static const uint32_t kSenderSsrcs[] = {4, 7, 10};
5088 static const uint32_t kSenderRtxSsrcs[] = {5, 8, 11};
5089
5090 StreamParams sender_sp = cricket::CreateSimWithRtxStreamParams(
5091 "cname", MAKE_VECTOR(kSenderSsrcs), MAKE_VECTOR(kSenderRtxSsrcs));
5092
5093 EXPECT_TRUE(channel_->AddSendStream(sender_sp));
5094
5095 static const uint32_t kReceiverSsrcs[] = {3};
5096 static const uint32_t kReceiverRtxSsrcs[] = {2};
5097
5098 StreamParams receiver_sp = cricket::CreateSimWithRtxStreamParams(
5099 "cname", MAKE_VECTOR(kReceiverSsrcs), MAKE_VECTOR(kReceiverRtxSsrcs));
5100 EXPECT_TRUE(channel_->AddRecvStream(receiver_sp));
5101
5102 cricket::VideoMediaInfo info;
5103 ASSERT_TRUE(channel_->GetStats(&info));
5104
5105 ASSERT_EQ(1u, info.senders.size());
5106 ASSERT_EQ(1u, info.receivers.size());
5107
5108 EXPECT_NE(sender_sp.ssrc_groups, receiver_sp.ssrc_groups);
5109 EXPECT_EQ(sender_sp.ssrc_groups, info.senders[0].ssrc_groups);
5110 EXPECT_EQ(receiver_sp.ssrc_groups, info.receivers[0].ssrc_groups);
5111}
5112
eladalonf1841382017-06-12 01:16:46 -07005113TEST_F(WebRtcVideoChannelTest, MapsReceivedPayloadTypeToCodecName) {
pbosf42376c2015-08-28 07:35:32 -07005114 FakeVideoReceiveStream* stream = AddRecvStream();
5115 webrtc::VideoReceiveStream::Stats stats;
5116 cricket::VideoMediaInfo info;
5117
5118 // Report no codec name before receiving.
5119 stream->SetStats(stats);
5120 ASSERT_TRUE(channel_->GetStats(&info));
5121 EXPECT_STREQ("", info.receivers[0].codec_name.c_str());
5122
5123 // Report VP8 if we're receiving it.
magjed509e4fe2016-11-18 01:34:11 -08005124 stats.current_payload_type = GetEngineCodec("VP8").id;
pbosf42376c2015-08-28 07:35:32 -07005125 stream->SetStats(stats);
5126 ASSERT_TRUE(channel_->GetStats(&info));
5127 EXPECT_STREQ(kVp8CodecName, info.receivers[0].codec_name.c_str());
5128
5129 // Report no codec name for unknown playload types.
5130 stats.current_payload_type = 3;
5131 stream->SetStats(stats);
5132 ASSERT_TRUE(channel_->GetStats(&info));
5133 EXPECT_STREQ("", info.receivers[0].codec_name.c_str());
5134}
5135
Seth Hampson5897a6e2018-04-03 11:16:33 -07005136// Tests that when we add a stream without SSRCs, but contains a stream_id
5137// that it is stored and its stream id is later used when the first packet
5138// arrives to properly create a receive stream with a sync label.
5139TEST_F(WebRtcVideoChannelTest, RecvUnsignaledSsrcWithSignaledStreamId) {
5140 const char kSyncLabel[] = "sync_label";
5141 cricket::StreamParams unsignaled_stream;
5142 unsignaled_stream.set_stream_ids({kSyncLabel});
5143 ASSERT_TRUE(channel_->AddRecvStream(unsignaled_stream));
5144 // The stream shouldn't have been created at this point because it doesn't
5145 // have any SSRCs.
Mirko Bonadeif859e552018-05-30 15:31:29 +02005146 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
Seth Hampson5897a6e2018-04-03 11:16:33 -07005147
5148 // Create and deliver packet.
5149 const size_t kDataLength = 12;
5150 uint8_t data[kDataLength];
5151 memset(data, 0, sizeof(data));
5152 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
5153 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005154 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
Seth Hampson5897a6e2018-04-03 11:16:33 -07005155
5156 // The stream should now be created with the appropriate sync label.
5157 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5158 EXPECT_EQ(kSyncLabel,
5159 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group);
5160
5161 // Removing the unsignaled stream should clear the cache. This time when
5162 // a default video receive stream is created it won't have a sync_group.
5163 ASSERT_TRUE(channel_->RemoveRecvStream(0));
5164 ASSERT_TRUE(channel_->RemoveRecvStream(kIncomingUnsignalledSsrc));
5165 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5166
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005167 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
Seth Hampson5897a6e2018-04-03 11:16:33 -07005168 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5169 EXPECT_TRUE(
5170 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group.empty());
5171}
5172
Ruslan Burakov493a6502019-02-27 15:32:48 +01005173// Test BaseMinimumPlayoutDelayMs on receive streams.
5174TEST_F(WebRtcVideoChannelTest, BaseMinimumPlayoutDelayMs) {
5175 // Test that set won't work for non-existing receive streams.
5176 EXPECT_FALSE(channel_->SetBaseMinimumPlayoutDelayMs(kSsrc + 2, 200));
5177 // Test that get won't work for non-existing receive streams.
5178 EXPECT_FALSE(channel_->GetBaseMinimumPlayoutDelayMs(kSsrc + 2));
5179
5180 EXPECT_TRUE(AddRecvStream());
5181 // Test that set works for the existing receive stream.
5182 EXPECT_TRUE(channel_->SetBaseMinimumPlayoutDelayMs(last_ssrc_, 200));
5183 auto* recv_stream = fake_call_->GetVideoReceiveStream(last_ssrc_);
5184 EXPECT_TRUE(recv_stream);
5185 EXPECT_EQ(recv_stream->base_mininum_playout_delay_ms(), 200);
5186 EXPECT_EQ(channel_->GetBaseMinimumPlayoutDelayMs(last_ssrc_).value_or(0),
5187 200);
5188}
5189
5190// Test BaseMinimumPlayoutDelayMs on unsignaled receive streams.
5191TEST_F(WebRtcVideoChannelTest, BaseMinimumPlayoutDelayMsUnsignaledRecvStream) {
5192 absl::optional<int> delay_ms;
5193 const FakeVideoReceiveStream* recv_stream;
5194
5195 // Set default stream with SSRC 0
5196 EXPECT_TRUE(channel_->SetBaseMinimumPlayoutDelayMs(0, 200));
5197 EXPECT_EQ(200, channel_->GetBaseMinimumPlayoutDelayMs(0).value_or(0));
5198
5199 // Spawn an unsignaled stream by sending a packet, it should inherit
5200 // default delay 200.
5201 const size_t kDataLength = 12;
5202 uint8_t data[kDataLength];
5203 memset(data, 0, sizeof(data));
5204 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
5205 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005206 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
Ruslan Burakov493a6502019-02-27 15:32:48 +01005207
5208 recv_stream = fake_call_->GetVideoReceiveStream(kIncomingUnsignalledSsrc);
5209 EXPECT_EQ(recv_stream->base_mininum_playout_delay_ms(), 200);
5210 delay_ms = channel_->GetBaseMinimumPlayoutDelayMs(kIncomingUnsignalledSsrc);
5211 EXPECT_EQ(200, delay_ms.value_or(0));
5212
5213 // Check that now if we change delay for SSRC 0 it will change delay for the
5214 // default receiving stream as well.
5215 EXPECT_TRUE(channel_->SetBaseMinimumPlayoutDelayMs(0, 300));
5216 EXPECT_EQ(300, channel_->GetBaseMinimumPlayoutDelayMs(0).value_or(0));
5217 delay_ms = channel_->GetBaseMinimumPlayoutDelayMs(kIncomingUnsignalledSsrc);
5218 EXPECT_EQ(300, delay_ms.value_or(0));
5219 recv_stream = fake_call_->GetVideoReceiveStream(kIncomingUnsignalledSsrc);
5220 EXPECT_EQ(recv_stream->base_mininum_playout_delay_ms(), 300);
5221}
5222
eladalonf1841382017-06-12 01:16:46 -07005223void WebRtcVideoChannelTest::TestReceiveUnsignaledSsrcPacket(
noahricd10a68e2015-07-10 11:27:55 -07005224 uint8_t payload_type,
5225 bool expect_created_receive_stream) {
magjed509e4fe2016-11-18 01:34:11 -08005226 // kRedRtxPayloadType must currently be unused.
5227 EXPECT_FALSE(FindCodecById(engine_.codecs(), kRedRtxPayloadType));
5228
noahricd10a68e2015-07-10 11:27:55 -07005229 // Add a RED RTX codec.
5230 VideoCodec red_rtx_codec =
magjed509e4fe2016-11-18 01:34:11 -08005231 VideoCodec::CreateRtxCodec(kRedRtxPayloadType, GetEngineCodec("red").id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005232 recv_parameters_.codecs.push_back(red_rtx_codec);
5233 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
noahricd10a68e2015-07-10 11:27:55 -07005234
5235 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5236 const size_t kDataLength = 12;
5237 uint8_t data[kDataLength];
5238 memset(data, 0, sizeof(data));
5239
5240 rtc::Set8(data, 1, payload_type);
5241 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
jbaucheec21bd2016-03-20 06:15:43 -07005242 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005243 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
noahricd10a68e2015-07-10 11:27:55 -07005244
5245 if (expect_created_receive_stream) {
5246 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
5247 << "Should have created a receive stream for payload type: "
5248 << payload_type;
5249 } else {
5250 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size())
5251 << "Shouldn't have created a receive stream for payload type: "
5252 << payload_type;
5253 }
5254}
5255
Åsa Persson2c7149b2018-10-15 09:36:10 +02005256class WebRtcVideoChannelDiscardUnknownSsrcTest : public WebRtcVideoChannelTest {
5257 public:
5258 WebRtcVideoChannelDiscardUnknownSsrcTest()
5259 : WebRtcVideoChannelTest(
5260 "WebRTC-Video-DiscardPacketsWithUnknownSsrc/Enabled/") {}
5261};
5262
5263TEST_F(WebRtcVideoChannelDiscardUnknownSsrcTest, NoUnsignalledStreamCreated) {
5264 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP8").id,
5265 false /* expect_created_receive_stream */);
5266}
5267
eladalonf1841382017-06-12 01:16:46 -07005268TEST_F(WebRtcVideoChannelTest, Vp8PacketCreatesUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005269 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP8").id,
5270 true /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005271}
5272
eladalonf1841382017-06-12 01:16:46 -07005273TEST_F(WebRtcVideoChannelTest, Vp9PacketCreatesUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005274 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP9").id,
5275 true /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005276}
5277
eladalonf1841382017-06-12 01:16:46 -07005278TEST_F(WebRtcVideoChannelTest, RtxPacketDoesntCreateUnsignalledStream) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02005279 AssignDefaultAptRtxTypes();
magjed509e4fe2016-11-18 01:34:11 -08005280 const cricket::VideoCodec vp8 = GetEngineCodec("VP8");
5281 const int rtx_vp8_payload_type = default_apt_rtx_types_[vp8.id];
5282 TestReceiveUnsignaledSsrcPacket(rtx_vp8_payload_type,
5283 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005284}
5285
eladalonf1841382017-06-12 01:16:46 -07005286TEST_F(WebRtcVideoChannelTest, UlpfecPacketDoesntCreateUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005287 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("ulpfec").id,
5288 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005289}
5290
eladalonf1841382017-06-12 01:16:46 -07005291TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr468da7c2016-11-22 02:16:47 -08005292 FlexfecPacketDoesntCreateUnsignalledStream) {
5293 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("flexfec-03").id,
5294 false /* expect_created_receive_stream */);
5295}
5296
eladalonf1841382017-06-12 01:16:46 -07005297TEST_F(WebRtcVideoChannelTest, RedRtxPacketDoesntCreateUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005298 TestReceiveUnsignaledSsrcPacket(kRedRtxPayloadType,
5299 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005300}
5301
mzanaty8a855d62017-02-17 15:46:43 -08005302// Test that receiving any unsignalled SSRC works even if it changes.
5303// The first unsignalled SSRC received will create a default receive stream.
5304// Any different unsignalled SSRC received will replace the default.
eladalonf1841382017-06-12 01:16:46 -07005305TEST_F(WebRtcVideoChannelTest, ReceiveDifferentUnsignaledSsrc) {
mzanaty8a855d62017-02-17 15:46:43 -08005306 // Allow receiving VP8, VP9, H264 (if enabled).
5307 cricket::VideoRecvParameters parameters;
5308 parameters.codecs.push_back(GetEngineCodec("VP8"));
5309 parameters.codecs.push_back(GetEngineCodec("VP9"));
5310
5311#if defined(WEBRTC_USE_H264)
5312 cricket::VideoCodec H264codec(126, "H264");
5313 parameters.codecs.push_back(H264codec);
5314#endif
5315
5316 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
5317 // No receive streams yet.
5318 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5319 cricket::FakeVideoRenderer renderer;
5320 EXPECT_TRUE(channel_->SetSink(kDefaultRecvSsrc, &renderer));
5321
5322 // Receive VP8 packet on first SSRC.
5323 uint8_t data[kMinRtpPacketLen];
5324 cricket::RtpHeader rtpHeader;
5325 rtpHeader.payload_type = GetEngineCodec("VP8").id;
5326 rtpHeader.seq_num = rtpHeader.timestamp = 0;
Yves Gerey665174f2018-06-19 15:03:05 +02005327 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 1;
mzanaty8a855d62017-02-17 15:46:43 -08005328 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5329 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005330 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
mzanaty8a855d62017-02-17 15:46:43 -08005331 // VP8 packet should create default receive stream.
5332 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
Yves Gerey665174f2018-06-19 15:03:05 +02005333 FakeVideoReceiveStream* recv_stream = fake_call_->GetVideoReceiveStreams()[0];
mzanaty8a855d62017-02-17 15:46:43 -08005334 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5335 // Verify that the receive stream sinks to a renderer.
Artem Titov1ebfb6a2019-01-03 23:49:37 +01005336 webrtc::VideoFrame video_frame =
5337 webrtc::VideoFrame::Builder()
5338 .set_video_frame_buffer(CreateBlackFrameBuffer(4, 4))
5339 .set_timestamp_rtp(100)
5340 .set_timestamp_us(0)
5341 .set_rotation(webrtc::kVideoRotation_0)
5342 .build();
mzanaty8a855d62017-02-17 15:46:43 -08005343 recv_stream->InjectFrame(video_frame);
5344 EXPECT_EQ(1, renderer.num_rendered_frames());
5345
5346 // Receive VP9 packet on second SSRC.
5347 rtpHeader.payload_type = GetEngineCodec("VP9").id;
Yves Gerey665174f2018-06-19 15:03:05 +02005348 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 2;
mzanaty8a855d62017-02-17 15:46:43 -08005349 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5350 rtc::CopyOnWriteBuffer packet2(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005351 channel_->OnPacketReceived(packet2, /* packet_time_us */ -1);
mzanaty8a855d62017-02-17 15:46:43 -08005352 // VP9 packet should replace the default receive SSRC.
5353 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5354 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
5355 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5356 // Verify that the receive stream sinks to a renderer.
Artem Titov1ebfb6a2019-01-03 23:49:37 +01005357 webrtc::VideoFrame video_frame2 =
5358 webrtc::VideoFrame::Builder()
5359 .set_video_frame_buffer(CreateBlackFrameBuffer(4, 4))
5360 .set_timestamp_rtp(200)
5361 .set_timestamp_us(0)
5362 .set_rotation(webrtc::kVideoRotation_0)
5363 .build();
mzanaty8a855d62017-02-17 15:46:43 -08005364 recv_stream->InjectFrame(video_frame2);
5365 EXPECT_EQ(2, renderer.num_rendered_frames());
5366
5367#if defined(WEBRTC_USE_H264)
5368 // Receive H264 packet on third SSRC.
5369 rtpHeader.payload_type = 126;
Yves Gerey665174f2018-06-19 15:03:05 +02005370 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 3;
mzanaty8a855d62017-02-17 15:46:43 -08005371 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5372 rtc::CopyOnWriteBuffer packet3(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005373 channel_->OnPacketReceived(packet3, /* packet_time_us */ -1);
mzanaty8a855d62017-02-17 15:46:43 -08005374 // H264 packet should replace the default receive SSRC.
5375 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5376 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
5377 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5378 // Verify that the receive stream sinks to a renderer.
Artem Titov1ebfb6a2019-01-03 23:49:37 +01005379 webrtc::VideoFrame video_frame3 =
5380 webrtc::VideoFrame::Builder()
5381 .set_video_frame_buffer(CreateBlackFrameBuffer(4, 4))
5382 .set_timestamp_rtp(300)
5383 .set_timestamp_us(0)
5384 .set_rotation(webrtc::kVideoRotation_0)
5385 .build();
mzanaty8a855d62017-02-17 15:46:43 -08005386 recv_stream->InjectFrame(video_frame3);
5387 EXPECT_EQ(3, renderer.num_rendered_frames());
5388#endif
5389}
5390
brandtr0dc57ea2017-05-29 23:33:31 -07005391// This test verifies that when a new default stream is created for a new
5392// unsignaled SSRC, the new stream does not overwrite any old stream that had
5393// been the default receive stream before being properly signaled.
eladalonf1841382017-06-12 01:16:46 -07005394TEST_F(WebRtcVideoChannelTest,
brandtr0dc57ea2017-05-29 23:33:31 -07005395 NewUnsignaledStreamDoesNotDestroyPreviouslyUnsignaledStream) {
5396 cricket::VideoRecvParameters parameters;
5397 parameters.codecs.push_back(GetEngineCodec("VP8"));
5398 ASSERT_TRUE(channel_->SetRecvParameters(parameters));
5399
5400 // No streams signaled and no packets received, so we should not have any
5401 // stream objects created yet.
5402 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5403
5404 // Receive packet on an unsignaled SSRC.
5405 uint8_t data[kMinRtpPacketLen];
5406 cricket::RtpHeader rtp_header;
5407 rtp_header.payload_type = GetEngineCodec("VP8").id;
5408 rtp_header.seq_num = rtp_header.timestamp = 0;
5409 rtp_header.ssrc = kSsrcs3[0];
5410 cricket::SetRtpHeader(data, sizeof(data), rtp_header);
5411 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005412 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
brandtr0dc57ea2017-05-29 23:33:31 -07005413 // Default receive stream should be created.
5414 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5415 FakeVideoReceiveStream* recv_stream0 =
5416 fake_call_->GetVideoReceiveStreams()[0];
5417 EXPECT_EQ(kSsrcs3[0], recv_stream0->GetConfig().rtp.remote_ssrc);
5418
5419 // Signal the SSRC.
5420 EXPECT_TRUE(
5421 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrcs3[0])));
5422 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5423 recv_stream0 = fake_call_->GetVideoReceiveStreams()[0];
5424 EXPECT_EQ(kSsrcs3[0], recv_stream0->GetConfig().rtp.remote_ssrc);
5425
5426 // Receive packet on a different unsignaled SSRC.
5427 rtp_header.ssrc = kSsrcs3[1];
5428 cricket::SetRtpHeader(data, sizeof(data), rtp_header);
5429 packet.SetData(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005430 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
brandtr0dc57ea2017-05-29 23:33:31 -07005431 // New default receive stream should be created, but old stream should remain.
5432 ASSERT_EQ(2u, fake_call_->GetVideoReceiveStreams().size());
5433 EXPECT_EQ(recv_stream0, fake_call_->GetVideoReceiveStreams()[0]);
5434 FakeVideoReceiveStream* recv_stream1 =
5435 fake_call_->GetVideoReceiveStreams()[1];
5436 EXPECT_EQ(kSsrcs3[1], recv_stream1->GetConfig().rtp.remote_ssrc);
5437}
5438
Seth Hampson7c682e02018-05-04 16:28:15 -07005439TEST_F(WebRtcVideoChannelTest, CanSetMaxBitrateForExistingStream) {
skvladdc1c62c2016-03-16 19:07:43 -07005440 AddSendStream();
5441
Niels Möller805a27e2019-01-21 12:21:27 +01005442 webrtc::test::FrameForwarder frame_forwarder;
5443 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
skvladdc1c62c2016-03-16 19:07:43 -07005444 EXPECT_TRUE(channel_->SetSend(true));
Niels Möller805a27e2019-01-21 12:21:27 +01005445 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
skvladdc1c62c2016-03-16 19:07:43 -07005446
perkjfa10b552016-10-02 23:45:26 -07005447 int default_encoder_bitrate = GetMaxEncoderBitrate();
brandtr468da7c2016-11-22 02:16:47 -08005448 EXPECT_GT(default_encoder_bitrate, 1000);
skvladdc1c62c2016-03-16 19:07:43 -07005449
5450 // TODO(skvlad): Resolve the inconsistency between the interpretation
5451 // of the global bitrate limit for audio and video:
5452 // - Audio: max_bandwidth_bps = 0 - fail the operation,
5453 // max_bandwidth_bps = -1 - remove the bandwidth limit
5454 // - Video: max_bandwidth_bps = 0 - remove the bandwidth limit,
pbos5c7760a2017-03-10 11:23:12 -08005455 // max_bandwidth_bps = -1 - remove the bandwidth limit
skvladdc1c62c2016-03-16 19:07:43 -07005456
perkjfa10b552016-10-02 23:45:26 -07005457 SetAndExpectMaxBitrate(1000, 0, 1000);
5458 SetAndExpectMaxBitrate(1000, 800, 800);
5459 SetAndExpectMaxBitrate(600, 800, 600);
5460 SetAndExpectMaxBitrate(0, 800, 800);
5461 SetAndExpectMaxBitrate(0, 0, default_encoder_bitrate);
skvladdc1c62c2016-03-16 19:07:43 -07005462
Niels Möllerff40b142018-04-09 08:49:14 +02005463 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
skvladdc1c62c2016-03-16 19:07:43 -07005464}
5465
eladalonf1841382017-06-12 01:16:46 -07005466TEST_F(WebRtcVideoChannelTest, CannotSetMaxBitrateForNonexistentStream) {
skvladdc1c62c2016-03-16 19:07:43 -07005467 webrtc::RtpParameters nonexistent_parameters =
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005468 channel_->GetRtpSendParameters(last_ssrc_);
Mirko Bonadeif859e552018-05-30 15:31:29 +02005469 EXPECT_EQ(0u, nonexistent_parameters.encodings.size());
skvladdc1c62c2016-03-16 19:07:43 -07005470
5471 nonexistent_parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005472 EXPECT_FALSE(
Zach Steinba37b4b2018-01-23 15:02:36 -08005473 channel_->SetRtpSendParameters(last_ssrc_, nonexistent_parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07005474}
5475
eladalonf1841382017-06-12 01:16:46 -07005476TEST_F(WebRtcVideoChannelTest,
Seth Hampson7c682e02018-05-04 16:28:15 -07005477 SetLowMaxBitrateOverwritesVideoStreamMinBitrate) {
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005478 FakeVideoSendStream* stream = AddSendStream();
5479
Seth Hampson7c682e02018-05-04 16:28:15 -07005480 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5481 EXPECT_EQ(1UL, parameters.encodings.size());
5482 EXPECT_FALSE(parameters.encodings[0].max_bitrate_bps.has_value());
5483 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5484
5485 // Note that this is testing the behavior of the FakeVideoSendStream, which
5486 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5487 // we are just testing the behavior of
5488 // EncoderStreamFactory::CreateEncoderStreams.
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005489 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5490 EXPECT_EQ(kMinVideoBitrateBps, stream->GetVideoStreams()[0].min_bitrate_bps);
Seth Hampson7c682e02018-05-04 16:28:15 -07005491
5492 // Set a low max bitrate & check that VideoStream.min_bitrate_bps is limited
5493 // by this amount.
5494 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5495 int low_max_bitrate_bps = kMinVideoBitrateBps - 1000;
5496 parameters.encodings[0].max_bitrate_bps = low_max_bitrate_bps;
5497 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5498
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005499 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5500 EXPECT_EQ(low_max_bitrate_bps, stream->GetVideoStreams()[0].min_bitrate_bps);
5501 EXPECT_EQ(low_max_bitrate_bps, stream->GetVideoStreams()[0].max_bitrate_bps);
5502}
5503
5504TEST_F(WebRtcVideoChannelTest,
5505 SetHighMinBitrateOverwritesVideoStreamMaxBitrate) {
5506 FakeVideoSendStream* stream = AddSendStream();
5507
5508 // Note that this is testing the behavior of the FakeVideoSendStream, which
5509 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5510 // we are just testing the behavior of
5511 // EncoderStreamFactory::CreateEncoderStreams.
5512 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5513 int high_min_bitrate_bps = stream->GetVideoStreams()[0].max_bitrate_bps + 1;
5514
5515 // Set a high min bitrate and check that max_bitrate_bps is adjusted up.
5516 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5517 EXPECT_EQ(1UL, parameters.encodings.size());
5518 parameters.encodings[0].min_bitrate_bps = high_min_bitrate_bps;
5519 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5520
5521 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5522 EXPECT_EQ(high_min_bitrate_bps, stream->GetVideoStreams()[0].min_bitrate_bps);
5523 EXPECT_EQ(high_min_bitrate_bps, stream->GetVideoStreams()[0].max_bitrate_bps);
5524}
5525
5526TEST_F(WebRtcVideoChannelTest,
5527 SetMinBitrateAboveMaxBitrateLimitAdjustsMinBitrateDown) {
5528 send_parameters_.max_bandwidth_bps = 99999;
5529 FakeVideoSendStream* stream = AddSendStream();
5530 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
5531 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
5532 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5533 EXPECT_EQ(kMinVideoBitrateBps, stream->GetVideoStreams()[0].min_bitrate_bps);
5534 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5535 stream->GetVideoStreams()[0].max_bitrate_bps);
5536
5537 // Set min bitrate above global max bitrate and check that min_bitrate_bps is
5538 // adjusted down.
5539 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5540 EXPECT_EQ(1UL, parameters.encodings.size());
5541 parameters.encodings[0].min_bitrate_bps = 99999 + 1;
5542 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5543 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5544 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5545 stream->GetVideoStreams()[0].min_bitrate_bps);
5546 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5547 stream->GetVideoStreams()[0].max_bitrate_bps);
Seth Hampson7c682e02018-05-04 16:28:15 -07005548}
5549
Åsa Persson8c1bf952018-09-13 10:42:19 +02005550TEST_F(WebRtcVideoChannelTest, SetMaxFramerateOneStream) {
5551 FakeVideoSendStream* stream = AddSendStream();
5552
5553 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5554 EXPECT_EQ(1UL, parameters.encodings.size());
5555 EXPECT_FALSE(parameters.encodings[0].max_framerate.has_value());
5556 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5557
5558 // Note that this is testing the behavior of the FakeVideoSendStream, which
5559 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5560 // we are just testing the behavior of
5561 // EncoderStreamFactory::CreateEncoderStreams.
5562 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5563 EXPECT_EQ(kDefaultVideoMaxFramerate,
5564 stream->GetVideoStreams()[0].max_framerate);
5565
5566 // Set max framerate and check that VideoStream.max_framerate is set.
5567 const int kNewMaxFramerate = kDefaultVideoMaxFramerate - 1;
5568 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5569 parameters.encodings[0].max_framerate = kNewMaxFramerate;
5570 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5571
5572 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5573 EXPECT_EQ(kNewMaxFramerate, stream->GetVideoStreams()[0].max_framerate);
5574}
5575
Åsa Persson23eba222018-10-02 14:47:06 +02005576TEST_F(WebRtcVideoChannelTest, SetNumTemporalLayersForSingleStream) {
5577 FakeVideoSendStream* stream = AddSendStream();
5578
5579 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5580 EXPECT_EQ(1UL, parameters.encodings.size());
5581 EXPECT_FALSE(parameters.encodings[0].num_temporal_layers.has_value());
5582 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5583
5584 // Note that this is testing the behavior of the FakeVideoSendStream, which
5585 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5586 // we are just testing the behavior of
5587 // EncoderStreamFactory::CreateEncoderStreams.
5588 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5589 EXPECT_FALSE(stream->GetVideoStreams()[0].num_temporal_layers.has_value());
5590
5591 // Set temporal layers and check that VideoStream.num_temporal_layers is set.
5592 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5593 parameters.encodings[0].num_temporal_layers = 2;
5594 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5595
5596 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5597 EXPECT_EQ(2UL, stream->GetVideoStreams()[0].num_temporal_layers);
5598}
5599
Seth Hampson7c682e02018-05-04 16:28:15 -07005600TEST_F(WebRtcVideoChannelTest,
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005601 CannotSetRtpSendParametersWithIncorrectNumberOfEncodings) {
skvladdc1c62c2016-03-16 19:07:43 -07005602 AddSendStream();
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005603 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07005604 // Two or more encodings should result in failure.
5605 parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Zach Steinba37b4b2018-01-23 15:02:36 -08005606 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeeffb2aced2017-01-06 23:05:37 -08005607 // Zero encodings should also fail.
5608 parameters.encodings.clear();
Zach Steinba37b4b2018-01-23 15:02:36 -08005609 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeeffb2aced2017-01-06 23:05:37 -08005610}
5611
Zach Stein3ca452b2018-01-18 10:01:24 -08005612TEST_F(WebRtcVideoChannelTest,
5613 CannotSetSimulcastRtpSendParametersWithIncorrectNumberOfEncodings) {
5614 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
5615 StreamParams sp = CreateSimStreamParams("cname", ssrcs);
5616 AddSendStream(sp);
5617
5618 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5619
5620 // Additional encodings should result in failure.
5621 parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Zach Steinba37b4b2018-01-23 15:02:36 -08005622 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Zach Stein3ca452b2018-01-18 10:01:24 -08005623 // Zero encodings should also fail.
5624 parameters.encodings.clear();
Zach Steinba37b4b2018-01-23 15:02:36 -08005625 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Zach Stein3ca452b2018-01-18 10:01:24 -08005626}
5627
deadbeeffb2aced2017-01-06 23:05:37 -08005628// Changing the SSRC through RtpParameters is not allowed.
eladalonf1841382017-06-12 01:16:46 -07005629TEST_F(WebRtcVideoChannelTest, CannotSetSsrcInRtpSendParameters) {
deadbeeffb2aced2017-01-06 23:05:37 -08005630 AddSendStream();
5631 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
Oskar Sundbom78807582017-11-16 11:09:55 +01005632 parameters.encodings[0].ssrc = 0xdeadbeef;
Zach Steinba37b4b2018-01-23 15:02:36 -08005633 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07005634}
5635
Seth Hampson24722b32017-12-22 09:36:42 -08005636// Tests that when RTCRtpEncodingParameters.bitrate_priority gets set to
5637// a value <= 0, setting the parameters returns false.
5638TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersInvalidBitratePriority) {
5639 AddSendStream();
5640 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5641 EXPECT_EQ(1UL, parameters.encodings.size());
5642 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5643 parameters.encodings[0].bitrate_priority);
5644
5645 parameters.encodings[0].bitrate_priority = 0;
Zach Steinba37b4b2018-01-23 15:02:36 -08005646 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005647 parameters.encodings[0].bitrate_priority = -2;
Zach Steinba37b4b2018-01-23 15:02:36 -08005648 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005649}
5650
5651// Tests when the the RTCRtpEncodingParameters.bitrate_priority gets set
5652// properly on the VideoChannel and propogates down to the video encoder.
5653TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersPriorityOneStream) {
5654 AddSendStream();
5655 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5656 EXPECT_EQ(1UL, parameters.encodings.size());
5657 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5658 parameters.encodings[0].bitrate_priority);
5659
5660 // Change the value and set it on the VideoChannel.
5661 double new_bitrate_priority = 2.0;
5662 parameters.encodings[0].bitrate_priority = new_bitrate_priority;
Zach Steinba37b4b2018-01-23 15:02:36 -08005663 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005664
5665 // Verify that the encoding parameters bitrate_priority is set for the
5666 // VideoChannel.
5667 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5668 EXPECT_EQ(1UL, parameters.encodings.size());
5669 EXPECT_EQ(new_bitrate_priority, parameters.encodings[0].bitrate_priority);
5670
5671 // Verify that the new value propagated down to the encoder.
5672 std::vector<FakeVideoSendStream*> video_send_streams =
5673 fake_call_->GetVideoSendStreams();
5674 EXPECT_EQ(1UL, video_send_streams.size());
5675 FakeVideoSendStream* video_send_stream = video_send_streams.front();
5676 // Check that the WebRtcVideoSendStream updated the VideoEncoderConfig
5677 // appropriately.
5678 EXPECT_EQ(new_bitrate_priority,
5679 video_send_stream->GetEncoderConfig().bitrate_priority);
5680 // Check that the vector of VideoStreams also was propagated correctly. Note
5681 // that this is testing the behavior of the FakeVideoSendStream, which mimics
5682 // the calls to CreateEncoderStreams to get the VideoStreams.
Danil Chapovalov00c71832018-06-15 15:58:38 +02005683 EXPECT_EQ(absl::optional<double>(new_bitrate_priority),
Seth Hampson24722b32017-12-22 09:36:42 -08005684 video_send_stream->GetVideoStreams()[0].bitrate_priority);
5685}
5686
5687// Tests that the RTCRtpEncodingParameters.bitrate_priority is set for the
5688// VideoChannel and the value propogates to the video encoder with all simulcast
5689// streams.
5690TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersPrioritySimulcastStreams) {
5691 // Create the stream params with multiple ssrcs for simulcast.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005692 const size_t kNumSimulcastStreams = 3;
Seth Hampson24722b32017-12-22 09:36:42 -08005693 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
5694 StreamParams stream_params = CreateSimStreamParams("cname", ssrcs);
5695 AddSendStream(stream_params);
5696 uint32_t primary_ssrc = stream_params.first_ssrc();
5697
Niels Möller805a27e2019-01-21 12:21:27 +01005698 // Using the FrameForwarder, we manually send a full size
Tommi85959932018-02-07 19:26:06 +01005699 // frame. This creates multiple VideoStreams for all simulcast layers when
5700 // reconfiguring, and allows us to test this behavior.
Niels Möller805a27e2019-01-21 12:21:27 +01005701 webrtc::test::FrameForwarder frame_forwarder;
Seth Hampson24722b32017-12-22 09:36:42 -08005702 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01005703 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, &options, &frame_forwarder));
Seth Hampson24722b32017-12-22 09:36:42 -08005704 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01005705 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame(
5706 1920, 1080, webrtc::VideoRotation::kVideoRotation_0,
5707 rtc::kNumMicrosecsPerSec / 30));
5708
Seth Hampson24722b32017-12-22 09:36:42 -08005709 // Get and set the rtp encoding parameters.
5710 webrtc::RtpParameters parameters =
5711 channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02005712 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson24722b32017-12-22 09:36:42 -08005713 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5714 parameters.encodings[0].bitrate_priority);
5715 // Change the value and set it on the VideoChannel.
5716 double new_bitrate_priority = 2.0;
5717 parameters.encodings[0].bitrate_priority = new_bitrate_priority;
Zach Steinba37b4b2018-01-23 15:02:36 -08005718 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005719
5720 // Verify that the encoding parameters priority is set on the VideoChannel.
5721 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02005722 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson24722b32017-12-22 09:36:42 -08005723 EXPECT_EQ(new_bitrate_priority, parameters.encodings[0].bitrate_priority);
5724
5725 // Verify that the new value propagated down to the encoder.
5726 std::vector<FakeVideoSendStream*> video_send_streams =
5727 fake_call_->GetVideoSendStreams();
5728 EXPECT_EQ(1UL, video_send_streams.size());
5729 FakeVideoSendStream* video_send_stream = video_send_streams.front();
5730 // Check that the WebRtcVideoSendStream updated the VideoEncoderConfig
5731 // appropriately.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005732 EXPECT_EQ(kNumSimulcastStreams,
Seth Hampson24722b32017-12-22 09:36:42 -08005733 video_send_stream->GetEncoderConfig().number_of_streams);
5734 EXPECT_EQ(new_bitrate_priority,
5735 video_send_stream->GetEncoderConfig().bitrate_priority);
5736 // Check that the vector of VideoStreams also propagated correctly. The
5737 // FakeVideoSendStream calls CreateEncoderStreams, and we are testing that
5738 // these are created appropriately for the simulcast case.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005739 EXPECT_EQ(kNumSimulcastStreams, video_send_stream->GetVideoStreams().size());
Danil Chapovalov00c71832018-06-15 15:58:38 +02005740 EXPECT_EQ(absl::optional<double>(new_bitrate_priority),
Seth Hampson24722b32017-12-22 09:36:42 -08005741 video_send_stream->GetVideoStreams()[0].bitrate_priority);
5742 // Since we are only setting bitrate priority per-sender, the other
5743 // VideoStreams should have a bitrate priority of 0.
Danil Chapovalov00c71832018-06-15 15:58:38 +02005744 EXPECT_EQ(absl::nullopt,
Seth Hampson24722b32017-12-22 09:36:42 -08005745 video_send_stream->GetVideoStreams()[1].bitrate_priority);
Danil Chapovalov00c71832018-06-15 15:58:38 +02005746 EXPECT_EQ(absl::nullopt,
Seth Hampson24722b32017-12-22 09:36:42 -08005747 video_send_stream->GetVideoStreams()[2].bitrate_priority);
Niels Möllerff40b142018-04-09 08:49:14 +02005748 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, nullptr, nullptr));
Seth Hampson24722b32017-12-22 09:36:42 -08005749}
5750
Tim Haloun648d28a2018-10-18 16:52:22 -07005751// RTCRtpEncodingParameters.network_priority must be one of a few values
5752// derived from the default priority, corresponding to very-low, low, medium,
5753// or high.
5754TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersInvalidNetworkPriority) {
5755 AddSendStream();
5756 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5757 EXPECT_EQ(1UL, parameters.encodings.size());
5758 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5759 parameters.encodings[0].network_priority);
5760
5761 double good_values[] = {0.5, 1.0, 2.0, 4.0};
5762 double bad_values[] = {-1.0, 0.0, 0.49, 0.51, 1.1, 3.99, 4.1, 5.0};
5763 for (auto it : good_values) {
5764 parameters.encodings[0].network_priority = it;
5765 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5766 }
5767 for (auto it : bad_values) {
5768 parameters.encodings[0].network_priority = it;
5769 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5770 }
5771}
5772
Florent Castellic1a0bcb2019-01-29 14:26:48 +01005773TEST_F(WebRtcVideoChannelTest,
5774 GetAndSetRtpSendParametersScaleResolutionDownByVP8) {
Rasmus Brandt9387b522019-02-05 14:23:26 +01005775 VideoSendParameters parameters;
5776 parameters.codecs.push_back(VideoCodec(kVp8CodecName));
Florent Castellic1a0bcb2019-01-29 14:26:48 +01005777 ASSERT_TRUE(channel_->SetSendParameters(parameters));
5778 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5779
5780 webrtc::test::FrameForwarder frame_forwarder;
Rasmus Brandt9387b522019-02-05 14:23:26 +01005781 FakeFrameSource frame_source(1280, 720, rtc::kNumMicrosecsPerSec / 30);
Florent Castellic1a0bcb2019-01-29 14:26:48 +01005782
5783 VideoOptions options;
5784 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
5785 channel_->SetSend(true);
5786
5787 // Try layers in natural order (smallest to largest).
5788 {
5789 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
5790 ASSERT_EQ(3u, rtp_parameters.encodings.size());
5791 rtp_parameters.encodings[0].scale_resolution_down_by = 4.0;
5792 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
5793 rtp_parameters.encodings[2].scale_resolution_down_by = 1.0;
5794 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
5795 ASSERT_TRUE(result.ok());
5796
5797 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
5798
5799 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
5800 ASSERT_EQ(3u, video_streams.size());
5801 EXPECT_EQ(320u, video_streams[0].width);
5802 EXPECT_EQ(180u, video_streams[0].height);
5803 EXPECT_EQ(640u, video_streams[1].width);
5804 EXPECT_EQ(360u, video_streams[1].height);
5805 EXPECT_EQ(1280u, video_streams[2].width);
5806 EXPECT_EQ(720u, video_streams[2].height);
5807 }
5808
5809 // Try layers in reverse natural order (largest to smallest).
5810 {
5811 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
5812 ASSERT_EQ(3u, rtp_parameters.encodings.size());
5813 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
5814 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
5815 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
5816 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
5817 ASSERT_TRUE(result.ok());
5818
5819 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
5820
5821 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
5822 ASSERT_EQ(3u, video_streams.size());
5823 EXPECT_EQ(1280u, video_streams[0].width);
5824 EXPECT_EQ(720u, video_streams[0].height);
5825 EXPECT_EQ(640u, video_streams[1].width);
5826 EXPECT_EQ(360u, video_streams[1].height);
5827 EXPECT_EQ(320u, video_streams[2].width);
5828 EXPECT_EQ(180u, video_streams[2].height);
5829 }
5830
5831 // Try layers in mixed order.
5832 {
5833 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
5834 ASSERT_EQ(3u, rtp_parameters.encodings.size());
5835 rtp_parameters.encodings[0].scale_resolution_down_by = 10.0;
5836 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
5837 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
5838 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
5839 ASSERT_TRUE(result.ok());
5840
5841 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
5842
5843 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
5844 ASSERT_EQ(3u, video_streams.size());
5845 EXPECT_EQ(128u, video_streams[0].width);
5846 EXPECT_EQ(72u, video_streams[0].height);
5847 EXPECT_EQ(640u, video_streams[1].width);
5848 EXPECT_EQ(360u, video_streams[1].height);
5849 EXPECT_EQ(320u, video_streams[2].width);
5850 EXPECT_EQ(180u, video_streams[2].height);
5851 }
5852
5853 // Try with a missing scale setting, defaults to 1.0 if any other is set.
5854 {
5855 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
5856 ASSERT_EQ(3u, rtp_parameters.encodings.size());
5857 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
5858 rtp_parameters.encodings[1].scale_resolution_down_by.reset();
5859 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
5860 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
5861 ASSERT_TRUE(result.ok());
5862
5863 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
5864
5865 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
5866 ASSERT_EQ(3u, video_streams.size());
5867 EXPECT_EQ(1280u, video_streams[0].width);
5868 EXPECT_EQ(720u, video_streams[0].height);
5869 EXPECT_EQ(1280u, video_streams[1].width);
5870 EXPECT_EQ(720u, video_streams[1].height);
5871 EXPECT_EQ(320u, video_streams[2].width);
5872 EXPECT_EQ(180u, video_streams[2].height);
5873 }
5874
5875 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5876}
5877
5878TEST_F(WebRtcVideoChannelTest,
Rasmus Brandt9387b522019-02-05 14:23:26 +01005879 GetAndSetRtpSendParametersScaleResolutionDownByVP8WithOddResolution) {
5880 // Ensure that the top layer has width and height divisible by 2^3,
5881 // so that the bottom layer has width and height divisible by 2.
5882 // TODO(bugs.webrtc.org/8785): Remove this field trial when we fully trust
5883 // the number of simulcast layers set by the app.
5884 webrtc::test::ScopedFieldTrials field_trial(
5885 "WebRTC-NormalizeSimulcastResolution/Enabled-3/");
5886
5887 // Set up WebRtcVideoChannel for 3-layer VP8 simulcast.
5888 VideoSendParameters parameters;
5889 parameters.codecs.push_back(VideoCodec(kVp8CodecName));
5890 ASSERT_TRUE(channel_->SetSendParameters(parameters));
5891 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5892 webrtc::test::FrameForwarder frame_forwarder;
5893 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, /*options=*/nullptr,
5894 &frame_forwarder));
5895 channel_->SetSend(true);
5896
5897 // Set |scale_resolution_down_by|'s.
5898 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
5899 ASSERT_EQ(rtp_parameters.encodings.size(), 3u);
5900 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
5901 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
5902 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
5903 const auto result =
5904 channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
5905 ASSERT_TRUE(result.ok());
5906
5907 // Use a capture resolution whose width and height are not divisible by 2^3.
5908 // (See field trial set at the top of the test.)
5909 FakeFrameSource frame_source(2007, 1207, rtc::kNumMicrosecsPerSec / 30);
5910 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
5911
5912 // Ensure the scaling is correct.
5913 const auto video_streams = stream->GetVideoStreams();
5914 ASSERT_EQ(video_streams.size(), 3u);
5915 // Ensure that we round the capture resolution down for the top layer...
5916 EXPECT_EQ(video_streams[0].width, 2000u);
5917 EXPECT_EQ(video_streams[0].height, 1200u);
5918 EXPECT_EQ(video_streams[1].width, 1000u);
5919 EXPECT_EQ(video_streams[1].height, 600u);
5920 // ...and that the bottom layer has a width/height divisible by 2.
5921 EXPECT_EQ(video_streams[2].width, 500u);
5922 EXPECT_EQ(video_streams[2].height, 300u);
5923
5924 // Tear down.
5925 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5926}
5927
5928TEST_F(WebRtcVideoChannelTest,
Florent Castellic1a0bcb2019-01-29 14:26:48 +01005929 GetAndSetRtpSendParametersScaleResolutionDownByH264) {
Rasmus Brandt9387b522019-02-05 14:23:26 +01005930 encoder_factory_->AddSupportedVideoCodecType(kH264CodecName);
5931 VideoSendParameters parameters;
5932 parameters.codecs.push_back(VideoCodec(kH264CodecName));
Florent Castellic1a0bcb2019-01-29 14:26:48 +01005933 ASSERT_TRUE(channel_->SetSendParameters(parameters));
5934 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5935
5936 webrtc::test::FrameForwarder frame_forwarder;
Rasmus Brandt9387b522019-02-05 14:23:26 +01005937 FakeFrameSource frame_source(1280, 720, rtc::kNumMicrosecsPerSec / 30);
Florent Castellic1a0bcb2019-01-29 14:26:48 +01005938
5939 VideoOptions options;
5940 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
5941 channel_->SetSend(true);
5942
5943 // Try layers in natural order (smallest to largest).
5944 {
5945 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
5946 ASSERT_EQ(3u, rtp_parameters.encodings.size());
5947 rtp_parameters.encodings[0].scale_resolution_down_by = 4.0;
5948 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
5949 rtp_parameters.encodings[2].scale_resolution_down_by = 1.0;
5950 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
5951 ASSERT_TRUE(result.ok());
5952
5953 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
5954
5955 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
5956 ASSERT_EQ(3u, video_streams.size());
5957 EXPECT_EQ(320u, video_streams[0].width);
5958 EXPECT_EQ(180u, video_streams[0].height);
5959 EXPECT_EQ(640u, video_streams[1].width);
5960 EXPECT_EQ(360u, video_streams[1].height);
5961 EXPECT_EQ(1280u, video_streams[2].width);
5962 EXPECT_EQ(720u, video_streams[2].height);
5963 }
5964
5965 // Try layers in reverse natural order (largest to smallest).
5966 {
5967 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
5968 ASSERT_EQ(3u, rtp_parameters.encodings.size());
5969 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
5970 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
5971 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
5972 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
5973 ASSERT_TRUE(result.ok());
5974
5975 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
5976
5977 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
5978 ASSERT_EQ(3u, video_streams.size());
5979 EXPECT_EQ(1280u, video_streams[0].width);
5980 EXPECT_EQ(720u, video_streams[0].height);
5981 EXPECT_EQ(640u, video_streams[1].width);
5982 EXPECT_EQ(360u, video_streams[1].height);
5983 EXPECT_EQ(320u, video_streams[2].width);
5984 EXPECT_EQ(180u, video_streams[2].height);
5985 }
5986
5987 // Try layers in mixed order.
5988 {
5989 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
5990 ASSERT_EQ(3u, rtp_parameters.encodings.size());
5991 rtp_parameters.encodings[0].scale_resolution_down_by = 10.0;
5992 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
5993 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
5994 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
5995 ASSERT_TRUE(result.ok());
5996
5997 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
5998
5999 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6000 ASSERT_EQ(3u, video_streams.size());
6001 EXPECT_EQ(128u, video_streams[0].width);
6002 EXPECT_EQ(72u, video_streams[0].height);
6003 EXPECT_EQ(640u, video_streams[1].width);
6004 EXPECT_EQ(360u, video_streams[1].height);
6005 EXPECT_EQ(320u, video_streams[2].width);
6006 EXPECT_EQ(180u, video_streams[2].height);
6007 }
6008
6009 // Try with a missing scale setting, defaults to 1.0 if any other is set.
6010 {
6011 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6012 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6013 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
6014 rtp_parameters.encodings[1].scale_resolution_down_by.reset();
6015 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6016 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6017 ASSERT_TRUE(result.ok());
6018
6019 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6020
6021 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6022 ASSERT_EQ(3u, video_streams.size());
6023 EXPECT_EQ(1280u, video_streams[0].width);
6024 EXPECT_EQ(720u, video_streams[0].height);
6025 EXPECT_EQ(1280u, video_streams[1].width);
6026 EXPECT_EQ(720u, video_streams[1].height);
6027 EXPECT_EQ(320u, video_streams[2].width);
6028 EXPECT_EQ(180u, video_streams[2].height);
6029 }
6030 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6031}
6032
Rasmus Brandt9387b522019-02-05 14:23:26 +01006033TEST_F(WebRtcVideoChannelTest,
6034 GetAndSetRtpSendParametersScaleResolutionDownByH264WithOddResolution) {
6035 // Ensure that the top layer has width and height divisible by 2^3,
6036 // so that the bottom layer has width and height divisible by 2.
6037 // TODO(bugs.webrtc.org/8785): Remove this field trial when we fully trust
6038 // the number of simulcast layers set by the app.
6039 webrtc::test::ScopedFieldTrials field_trial(
6040 "WebRTC-NormalizeSimulcastResolution/Enabled-3/");
6041
6042 // Set up WebRtcVideoChannel for 3-layer H264 simulcast.
6043 encoder_factory_->AddSupportedVideoCodecType(kH264CodecName);
6044 VideoSendParameters parameters;
6045 parameters.codecs.push_back(VideoCodec(kH264CodecName));
6046 ASSERT_TRUE(channel_->SetSendParameters(parameters));
6047 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6048 webrtc::test::FrameForwarder frame_forwarder;
6049 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, /*options=*/nullptr,
6050 &frame_forwarder));
6051 channel_->SetSend(true);
6052
6053 // Set |scale_resolution_down_by|'s.
6054 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6055 ASSERT_EQ(rtp_parameters.encodings.size(), 3u);
6056 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
6057 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6058 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6059 const auto result =
6060 channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6061 ASSERT_TRUE(result.ok());
6062
6063 // Use a capture resolution whose width and height are not divisible by 2^3.
6064 // (See field trial set at the top of the test.)
6065 FakeFrameSource frame_source(2007, 1207, rtc::kNumMicrosecsPerSec / 30);
6066 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6067
6068 // Ensure the scaling is correct.
6069 const auto video_streams = stream->GetVideoStreams();
6070 ASSERT_EQ(video_streams.size(), 3u);
6071 // Ensure that we round the capture resolution down for the top layer...
6072 EXPECT_EQ(video_streams[0].width, 2000u);
6073 EXPECT_EQ(video_streams[0].height, 1200u);
6074 EXPECT_EQ(video_streams[1].width, 1000u);
6075 EXPECT_EQ(video_streams[1].height, 600u);
6076 // ...and that the bottom layer has a width/height divisible by 2.
6077 EXPECT_EQ(video_streams[2].width, 500u);
6078 EXPECT_EQ(video_streams[2].height, 300u);
6079
6080 // Tear down.
6081 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6082}
6083
Åsa Persson8c1bf952018-09-13 10:42:19 +02006084TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersMaxFramerate) {
6085 const size_t kNumSimulcastStreams = 3;
6086 SetUpSimulcast(true, false);
6087
6088 // Get and set the rtp encoding parameters.
6089 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6090 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6091 for (const auto& encoding : parameters.encodings) {
6092 EXPECT_FALSE(encoding.max_framerate);
6093 }
6094
6095 // Change the value and set it on the VideoChannel.
6096 parameters.encodings[0].max_framerate = 10;
6097 parameters.encodings[1].max_framerate = 20;
6098 parameters.encodings[2].max_framerate = 25;
6099 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6100
6101 // Verify that the bitrates are set on the VideoChannel.
6102 parameters = channel_->GetRtpSendParameters(last_ssrc_);
6103 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6104 EXPECT_EQ(10, parameters.encodings[0].max_framerate);
6105 EXPECT_EQ(20, parameters.encodings[1].max_framerate);
6106 EXPECT_EQ(25, parameters.encodings[2].max_framerate);
6107}
6108
Åsa Persson23eba222018-10-02 14:47:06 +02006109TEST_F(WebRtcVideoChannelTest,
6110 SetRtpSendParametersNumTemporalLayersFailsForInvalidRange) {
6111 const size_t kNumSimulcastStreams = 3;
6112 SetUpSimulcast(true, false);
6113
6114 // Get and set the rtp encoding parameters.
6115 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6116 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6117
6118 // Num temporal layers should be in the range [1, kMaxTemporalStreams].
6119 parameters.encodings[0].num_temporal_layers = 0;
6120 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
6121 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6122 parameters.encodings[0].num_temporal_layers = webrtc::kMaxTemporalStreams + 1;
6123 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
6124 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6125}
6126
6127TEST_F(WebRtcVideoChannelTest,
6128 SetRtpSendParametersNumTemporalLayersFailsForInvalidModification) {
6129 const size_t kNumSimulcastStreams = 3;
6130 SetUpSimulcast(true, false);
6131
6132 // Get and set the rtp encoding parameters.
6133 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6134 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6135
6136 // No/all layers should be set.
6137 parameters.encodings[0].num_temporal_layers = 1;
6138 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION,
6139 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6140
6141 // Different values not supported.
6142 parameters.encodings[0].num_temporal_layers = 1;
6143 parameters.encodings[1].num_temporal_layers = 2;
6144 parameters.encodings[2].num_temporal_layers = 2;
6145 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION,
6146 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6147}
6148
6149TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersNumTemporalLayers) {
6150 const size_t kNumSimulcastStreams = 3;
6151 SetUpSimulcast(true, false);
6152
6153 // Get and set the rtp encoding parameters.
6154 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6155 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6156 for (const auto& encoding : parameters.encodings)
6157 EXPECT_FALSE(encoding.num_temporal_layers);
6158
6159 // Change the value and set it on the VideoChannel.
6160 parameters.encodings[0].num_temporal_layers = 3;
6161 parameters.encodings[1].num_temporal_layers = 3;
6162 parameters.encodings[2].num_temporal_layers = 3;
6163 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6164
6165 // Verify that the number of temporal layers are set on the VideoChannel.
6166 parameters = channel_->GetRtpSendParameters(last_ssrc_);
6167 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6168 EXPECT_EQ(3, parameters.encodings[0].num_temporal_layers);
6169 EXPECT_EQ(3, parameters.encodings[1].num_temporal_layers);
6170 EXPECT_EQ(3, parameters.encodings[2].num_temporal_layers);
6171}
6172
6173TEST_F(WebRtcVideoChannelTest, NumTemporalLayersPropagatedToEncoder) {
6174 const size_t kNumSimulcastStreams = 3;
6175 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6176
6177 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006178 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson23eba222018-10-02 14:47:06 +02006179 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006180 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson23eba222018-10-02 14:47:06 +02006181 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006182 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson23eba222018-10-02 14:47:06 +02006183
6184 // Get and set the rtp encoding parameters.
6185 // Change the value and set it on the VideoChannel.
6186 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6187 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6188 parameters.encodings[0].num_temporal_layers = 2;
6189 parameters.encodings[1].num_temporal_layers = 2;
6190 parameters.encodings[2].num_temporal_layers = 2;
6191 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6192
6193 // Verify that the new value is propagated down to the encoder.
6194 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6195 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6196 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6197 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6198 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6199 EXPECT_EQ(2UL, encoder_config.simulcast_layers[0].num_temporal_layers);
6200 EXPECT_EQ(2UL, encoder_config.simulcast_layers[1].num_temporal_layers);
6201 EXPECT_EQ(2UL, encoder_config.simulcast_layers[2].num_temporal_layers);
6202
6203 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6204 // VideoStreams are created appropriately for the simulcast case.
6205 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6206 EXPECT_EQ(2UL, stream->GetVideoStreams()[0].num_temporal_layers);
6207 EXPECT_EQ(2UL, stream->GetVideoStreams()[1].num_temporal_layers);
6208 EXPECT_EQ(2UL, stream->GetVideoStreams()[2].num_temporal_layers);
6209
6210 // No parameter changed, encoder should not be reconfigured.
6211 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6212 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6213
6214 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6215}
6216
6217TEST_F(WebRtcVideoChannelTest,
6218 DefaultValuePropagatedToEncoderForUnsetNumTemporalLayers) {
6219 const size_t kDefaultNumTemporalLayers = 3;
6220 const size_t kNumSimulcastStreams = 3;
6221 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6222
6223 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006224 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson23eba222018-10-02 14:47:06 +02006225 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006226 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson23eba222018-10-02 14:47:06 +02006227 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006228 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson23eba222018-10-02 14:47:06 +02006229
6230 // Change rtp encoding parameters, num_temporal_layers not changed.
6231 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6232 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6233 parameters.encodings[0].min_bitrate_bps = 33000;
6234 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6235
6236 // Verify that no value is propagated down to the encoder.
6237 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6238 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6239 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6240 EXPECT_FALSE(encoder_config.simulcast_layers[0].num_temporal_layers);
6241 EXPECT_FALSE(encoder_config.simulcast_layers[1].num_temporal_layers);
6242 EXPECT_FALSE(encoder_config.simulcast_layers[2].num_temporal_layers);
6243
6244 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6245 // VideoStreams are created appropriately for the simulcast case.
6246 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6247 EXPECT_EQ(kDefaultNumTemporalLayers,
6248 stream->GetVideoStreams()[0].num_temporal_layers);
6249 EXPECT_EQ(kDefaultNumTemporalLayers,
6250 stream->GetVideoStreams()[1].num_temporal_layers);
6251 EXPECT_EQ(kDefaultNumTemporalLayers,
6252 stream->GetVideoStreams()[2].num_temporal_layers);
6253
6254 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6255}
6256
Åsa Persson8c1bf952018-09-13 10:42:19 +02006257TEST_F(WebRtcVideoChannelTest, MaxSimulcastFrameratePropagatedToEncoder) {
6258 const size_t kNumSimulcastStreams = 3;
6259 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6260
6261 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006262 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson8c1bf952018-09-13 10:42:19 +02006263 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006264 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson8c1bf952018-09-13 10:42:19 +02006265 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006266 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson8c1bf952018-09-13 10:42:19 +02006267
6268 // Get and set the rtp encoding parameters.
6269 // Change the value and set it on the VideoChannel.
6270 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6271 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6272 parameters.encodings[0].max_framerate = 15;
6273 parameters.encodings[1].max_framerate = 25;
6274 parameters.encodings[2].max_framerate = 20;
6275 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6276
6277 // Verify that the new value propagated down to the encoder.
6278 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6279 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6280 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6281 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6282 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6283 EXPECT_EQ(15, encoder_config.simulcast_layers[0].max_framerate);
6284 EXPECT_EQ(25, encoder_config.simulcast_layers[1].max_framerate);
6285 EXPECT_EQ(20, encoder_config.simulcast_layers[2].max_framerate);
6286
6287 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6288 // VideoStreams are created appropriately for the simulcast case.
6289 // Currently the maximum |max_framerate| is used.
6290 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6291 EXPECT_EQ(25, stream->GetVideoStreams()[0].max_framerate);
6292 EXPECT_EQ(25, stream->GetVideoStreams()[1].max_framerate);
6293 EXPECT_EQ(25, stream->GetVideoStreams()[2].max_framerate);
6294
6295 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6296}
6297
6298TEST_F(WebRtcVideoChannelTest,
6299 DefaultValuePropagatedToEncoderForUnsetFramerate) {
6300 const size_t kNumSimulcastStreams = 3;
6301 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6302 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6303
6304 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006305 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson8c1bf952018-09-13 10:42:19 +02006306 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006307 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson8c1bf952018-09-13 10:42:19 +02006308 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006309 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson8c1bf952018-09-13 10:42:19 +02006310
6311 // Get and set the rtp encoding parameters.
6312 // Change the value and set it on the VideoChannel.
6313 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6314 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6315 parameters.encodings[0].max_framerate = 15;
6316 parameters.encodings[2].max_framerate = 20;
6317 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6318
6319 // Verify that the new value propagated down to the encoder.
6320 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6321 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6322 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6323 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6324 EXPECT_EQ(15, encoder_config.simulcast_layers[0].max_framerate);
6325 EXPECT_EQ(-1, encoder_config.simulcast_layers[1].max_framerate);
6326 EXPECT_EQ(20, encoder_config.simulcast_layers[2].max_framerate);
6327
6328 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6329 // VideoStreams are created appropriately for the simulcast case.
6330 // The maximum |max_framerate| is used, kDefaultVideoMaxFramerate: 60.
6331 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6332 EXPECT_EQ(kDefaultVideoMaxFramerate,
6333 stream->GetVideoStreams()[0].max_framerate);
6334 EXPECT_EQ(kDefaultVideoMaxFramerate,
6335 stream->GetVideoStreams()[1].max_framerate);
6336 EXPECT_EQ(kDefaultVideoMaxFramerate,
6337 stream->GetVideoStreams()[2].max_framerate);
6338
6339 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6340}
6341
Åsa Persson55659812018-06-18 17:51:32 +02006342TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersMinAndMaxBitrate) {
6343 const size_t kNumSimulcastStreams = 3;
6344 SetUpSimulcast(true, false);
6345
6346 // Get and set the rtp encoding parameters.
6347 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6348 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6349 for (const auto& encoding : parameters.encodings) {
6350 EXPECT_FALSE(encoding.min_bitrate_bps);
6351 EXPECT_FALSE(encoding.max_bitrate_bps);
6352 }
6353
6354 // Change the value and set it on the VideoChannel.
6355 parameters.encodings[0].min_bitrate_bps = 100000;
6356 parameters.encodings[0].max_bitrate_bps = 200000;
6357 parameters.encodings[1].min_bitrate_bps = 300000;
6358 parameters.encodings[1].max_bitrate_bps = 400000;
6359 parameters.encodings[2].min_bitrate_bps = 500000;
6360 parameters.encodings[2].max_bitrate_bps = 600000;
6361 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6362
6363 // Verify that the bitrates are set on the VideoChannel.
6364 parameters = channel_->GetRtpSendParameters(last_ssrc_);
6365 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6366 EXPECT_EQ(100000, parameters.encodings[0].min_bitrate_bps);
6367 EXPECT_EQ(200000, parameters.encodings[0].max_bitrate_bps);
6368 EXPECT_EQ(300000, parameters.encodings[1].min_bitrate_bps);
6369 EXPECT_EQ(400000, parameters.encodings[1].max_bitrate_bps);
6370 EXPECT_EQ(500000, parameters.encodings[2].min_bitrate_bps);
6371 EXPECT_EQ(600000, parameters.encodings[2].max_bitrate_bps);
6372}
6373
6374TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersFailsWithIncorrectBitrate) {
6375 const size_t kNumSimulcastStreams = 3;
6376 SetUpSimulcast(true, false);
6377
6378 // Get and set the rtp encoding parameters.
6379 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6380 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6381
6382 // Max bitrate lower than min bitrate should fail.
6383 parameters.encodings[2].min_bitrate_bps = 100000;
6384 parameters.encodings[2].max_bitrate_bps = 100000 - 1;
6385 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
6386 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6387}
6388
6389// Test that min and max bitrate values set via RtpParameters are correctly
6390// propagated to the underlying encoder, and that the target is set to 3/4 of
6391// the maximum (3/4 was chosen because it's similar to the simulcast defaults
6392// that are used if no min/max are specified).
6393TEST_F(WebRtcVideoChannelTest, MinAndMaxSimulcastBitratePropagatedToEncoder) {
6394 const size_t kNumSimulcastStreams = 3;
6395 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6396
6397 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006398 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006399 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006400 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006401 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006402 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006403
6404 // Get and set the rtp encoding parameters.
6405 // Change the value and set it on the VideoChannel.
6406 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6407 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6408 parameters.encodings[0].min_bitrate_bps = 100000;
6409 parameters.encodings[0].max_bitrate_bps = 200000;
6410 parameters.encodings[1].min_bitrate_bps = 300000;
6411 parameters.encodings[1].max_bitrate_bps = 400000;
6412 parameters.encodings[2].min_bitrate_bps = 500000;
6413 parameters.encodings[2].max_bitrate_bps = 600000;
6414 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6415
6416 // Verify that the new value propagated down to the encoder.
6417 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6418 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6419 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6420 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6421 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6422 EXPECT_EQ(100000, encoder_config.simulcast_layers[0].min_bitrate_bps);
6423 EXPECT_EQ(200000, encoder_config.simulcast_layers[0].max_bitrate_bps);
6424 EXPECT_EQ(300000, encoder_config.simulcast_layers[1].min_bitrate_bps);
6425 EXPECT_EQ(400000, encoder_config.simulcast_layers[1].max_bitrate_bps);
6426 EXPECT_EQ(500000, encoder_config.simulcast_layers[2].min_bitrate_bps);
6427 EXPECT_EQ(600000, encoder_config.simulcast_layers[2].max_bitrate_bps);
6428
6429 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6430 // VideoStreams are created appropriately for the simulcast case.
6431 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6432 // Target bitrate: 200000 * 3 / 4 = 150000.
6433 EXPECT_EQ(100000, stream->GetVideoStreams()[0].min_bitrate_bps);
6434 EXPECT_EQ(150000, stream->GetVideoStreams()[0].target_bitrate_bps);
6435 EXPECT_EQ(200000, stream->GetVideoStreams()[0].max_bitrate_bps);
6436 // Target bitrate: 400000 * 3 / 4 = 300000.
6437 EXPECT_EQ(300000, stream->GetVideoStreams()[1].min_bitrate_bps);
6438 EXPECT_EQ(300000, stream->GetVideoStreams()[1].target_bitrate_bps);
6439 EXPECT_EQ(400000, stream->GetVideoStreams()[1].max_bitrate_bps);
6440 // Target bitrate: 600000 * 3 / 4 = 450000, less than min -> max.
6441 EXPECT_EQ(500000, stream->GetVideoStreams()[2].min_bitrate_bps);
6442 EXPECT_EQ(600000, stream->GetVideoStreams()[2].target_bitrate_bps);
6443 EXPECT_EQ(600000, stream->GetVideoStreams()[2].max_bitrate_bps);
6444
6445 // No parameter changed, encoder should not be reconfigured.
6446 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6447 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6448
6449 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6450}
6451
6452// Test to only specify the min or max bitrate value for a layer via
6453// RtpParameters. The unspecified min/max and target value should be set to the
6454// simulcast default that is used if no min/max are specified.
6455TEST_F(WebRtcVideoChannelTest, MinOrMaxSimulcastBitratePropagatedToEncoder) {
6456 const size_t kNumSimulcastStreams = 3;
6457 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6458 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6459
6460 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006461 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006462 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006463 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006464 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006465 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006466
6467 // Get and set the rtp encoding parameters.
6468 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6469 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6470
6471 // Change the value and set it on the VideoChannel.
6472 // Layer 0: only configure min bitrate.
6473 const int kMinBpsLayer0 = kDefault[0].min_bitrate_bps + 1;
6474 parameters.encodings[0].min_bitrate_bps = kMinBpsLayer0;
6475 // Layer 1: only configure max bitrate.
6476 const int kMaxBpsLayer1 = kDefault[1].max_bitrate_bps - 1;
6477 parameters.encodings[1].max_bitrate_bps = kMaxBpsLayer1;
6478 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6479
6480 // Verify that the new value propagated down to the encoder.
6481 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6482 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6483 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6484 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6485 EXPECT_EQ(kMinBpsLayer0, encoder_config.simulcast_layers[0].min_bitrate_bps);
6486 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].max_bitrate_bps);
6487 EXPECT_EQ(-1, encoder_config.simulcast_layers[1].min_bitrate_bps);
6488 EXPECT_EQ(kMaxBpsLayer1, encoder_config.simulcast_layers[1].max_bitrate_bps);
6489 EXPECT_EQ(-1, encoder_config.simulcast_layers[2].min_bitrate_bps);
6490 EXPECT_EQ(-1, encoder_config.simulcast_layers[2].max_bitrate_bps);
6491
6492 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6493 // VideoStreams are created appropriately for the simulcast case.
6494 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6495 // Layer 0: min configured bitrate should overwrite min default.
6496 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].min_bitrate_bps);
6497 EXPECT_EQ(kDefault[0].target_bitrate_bps,
6498 stream->GetVideoStreams()[0].target_bitrate_bps);
6499 EXPECT_EQ(kDefault[0].max_bitrate_bps,
6500 stream->GetVideoStreams()[0].max_bitrate_bps);
6501 // Layer 1: max configured bitrate should overwrite max default.
6502 EXPECT_EQ(kDefault[1].min_bitrate_bps,
6503 stream->GetVideoStreams()[1].min_bitrate_bps);
6504 EXPECT_EQ(kDefault[1].target_bitrate_bps,
6505 stream->GetVideoStreams()[1].target_bitrate_bps);
6506 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].max_bitrate_bps);
6507 // Layer 2: min and max bitrate not configured, default expected.
6508 EXPECT_EQ(kDefault[2].min_bitrate_bps,
6509 stream->GetVideoStreams()[2].min_bitrate_bps);
6510 EXPECT_EQ(kDefault[2].target_bitrate_bps,
6511 stream->GetVideoStreams()[2].target_bitrate_bps);
6512 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6513 stream->GetVideoStreams()[2].max_bitrate_bps);
6514
6515 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6516}
6517
6518// Test that specifying the min (or max) bitrate value for a layer via
6519// RtpParameters above (or below) the simulcast default max (or min) adjusts the
6520// unspecified values accordingly.
6521TEST_F(WebRtcVideoChannelTest, SetMinAndMaxSimulcastBitrateAboveBelowDefault) {
6522 const size_t kNumSimulcastStreams = 3;
6523 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6524 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6525
6526 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006527 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006528 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006529 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006530 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006531 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006532
6533 // Get and set the rtp encoding parameters.
6534 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6535 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6536
6537 // Change the value and set it on the VideoChannel.
6538 // For layer 0, set the min bitrate above the default max.
6539 const int kMinBpsLayer0 = kDefault[0].max_bitrate_bps + 1;
6540 parameters.encodings[0].min_bitrate_bps = kMinBpsLayer0;
6541 // For layer 1, set the max bitrate below the default min.
6542 const int kMaxBpsLayer1 = kDefault[1].min_bitrate_bps - 1;
6543 parameters.encodings[1].max_bitrate_bps = kMaxBpsLayer1;
6544 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6545
6546 // Verify that the new value propagated down to the encoder.
6547 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6548 // VideoStreams are created appropriately for the simulcast case.
6549 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6550 // Layer 0: Min bitrate above default max (target/max should be adjusted).
6551 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].min_bitrate_bps);
6552 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].target_bitrate_bps);
6553 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].max_bitrate_bps);
6554 // Layer 1: Max bitrate below default min (min/target should be adjusted).
6555 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].min_bitrate_bps);
6556 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].target_bitrate_bps);
6557 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].max_bitrate_bps);
6558 // Layer 2: min and max bitrate not configured, default expected.
6559 EXPECT_EQ(kDefault[2].min_bitrate_bps,
6560 stream->GetVideoStreams()[2].min_bitrate_bps);
6561 EXPECT_EQ(kDefault[2].target_bitrate_bps,
6562 stream->GetVideoStreams()[2].target_bitrate_bps);
6563 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6564 stream->GetVideoStreams()[2].max_bitrate_bps);
6565
6566 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6567}
6568
6569TEST_F(WebRtcVideoChannelTest, BandwidthAboveTotalMaxBitrateGivenToMaxLayer) {
6570 const size_t kNumSimulcastStreams = 3;
6571 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6572 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6573
6574 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006575 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006576 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006577 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006578 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006579 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006580
6581 // Set max bitrate for all but the highest layer.
6582 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6583 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6584 parameters.encodings[0].max_bitrate_bps = kDefault[0].max_bitrate_bps;
6585 parameters.encodings[1].max_bitrate_bps = kDefault[1].max_bitrate_bps;
6586 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6587
6588 // Set max bandwidth equal to total max bitrate.
6589 send_parameters_.max_bandwidth_bps =
6590 GetTotalMaxBitrateBps(stream->GetVideoStreams());
6591 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6592 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6593
6594 // No bitrate above the total max to give to the highest layer.
6595 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6596 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6597 stream->GetVideoStreams()[2].max_bitrate_bps);
6598
6599 // Set max bandwidth above the total max bitrate.
6600 send_parameters_.max_bandwidth_bps =
6601 GetTotalMaxBitrateBps(stream->GetVideoStreams()) + 1;
6602 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6603 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6604
6605 // The highest layer has no max bitrate set -> the bitrate above the total
6606 // max should be given to the highest layer.
6607 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6608 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
6609 GetTotalMaxBitrateBps(stream->GetVideoStreams()));
6610 EXPECT_EQ(kDefault[2].max_bitrate_bps + 1,
6611 stream->GetVideoStreams()[2].max_bitrate_bps);
6612
6613 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6614}
6615
6616TEST_F(WebRtcVideoChannelTest,
6617 BandwidthAboveTotalMaxBitrateNotGivenToMaxLayerIfMaxBitrateSet) {
6618 const size_t kNumSimulcastStreams = 3;
6619 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6620 EXPECT_EQ(kNumSimulcastStreams, kDefault.size());
6621 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6622
6623 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006624 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006625 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006626 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006627 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006628 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006629
6630 // Set max bitrate for the highest layer.
6631 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6632 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6633 parameters.encodings[2].max_bitrate_bps = kDefault[2].max_bitrate_bps;
6634 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6635
6636 // Set max bandwidth above the total max bitrate.
6637 send_parameters_.max_bandwidth_bps =
6638 GetTotalMaxBitrateBps(stream->GetVideoStreams()) + 1;
6639 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6640 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6641
6642 // The highest layer has the max bitrate set -> the bitrate above the total
6643 // max should not be given to the highest layer.
6644 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6645 EXPECT_EQ(*parameters.encodings[2].max_bitrate_bps,
6646 stream->GetVideoStreams()[2].max_bitrate_bps);
6647
6648 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6649}
6650
Åsa Perssonbdee46d2018-06-25 11:28:06 +02006651// Test that min and max bitrate values set via RtpParameters are correctly
6652// propagated to the underlying encoder for a single stream.
6653TEST_F(WebRtcVideoChannelTest, MinAndMaxBitratePropagatedToEncoder) {
6654 FakeVideoSendStream* stream = AddSendStream();
6655 EXPECT_TRUE(channel_->SetSend(true));
6656 EXPECT_TRUE(stream->IsSending());
6657
6658 // Set min and max bitrate.
6659 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6660 EXPECT_EQ(1u, parameters.encodings.size());
6661 parameters.encodings[0].min_bitrate_bps = 80000;
6662 parameters.encodings[0].max_bitrate_bps = 150000;
6663 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6664
6665 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6666 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6667 EXPECT_EQ(1u, encoder_config.number_of_streams);
6668 EXPECT_EQ(1u, encoder_config.simulcast_layers.size());
6669 EXPECT_EQ(80000, encoder_config.simulcast_layers[0].min_bitrate_bps);
6670 EXPECT_EQ(150000, encoder_config.simulcast_layers[0].max_bitrate_bps);
6671
6672 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6673 // VideoStreams are created appropriately.
6674 EXPECT_EQ(1u, stream->GetVideoStreams().size());
6675 EXPECT_EQ(80000, stream->GetVideoStreams()[0].min_bitrate_bps);
6676 EXPECT_EQ(150000, stream->GetVideoStreams()[0].target_bitrate_bps);
6677 EXPECT_EQ(150000, stream->GetVideoStreams()[0].max_bitrate_bps);
6678}
6679
6680// Test the default min and max bitrate value are correctly propagated to the
6681// underlying encoder for a single stream (when the values are not set via
6682// RtpParameters).
6683TEST_F(WebRtcVideoChannelTest, DefaultMinAndMaxBitratePropagatedToEncoder) {
6684 FakeVideoSendStream* stream = AddSendStream();
6685 EXPECT_TRUE(channel_->SetSend(true));
6686 EXPECT_TRUE(stream->IsSending());
6687
6688 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6689 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6690 EXPECT_EQ(1u, encoder_config.number_of_streams);
6691 EXPECT_EQ(1u, encoder_config.simulcast_layers.size());
6692 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].min_bitrate_bps);
6693 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].max_bitrate_bps);
6694
6695 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6696 // VideoStreams are created appropriately.
6697 EXPECT_EQ(1u, stream->GetVideoStreams().size());
6698 EXPECT_EQ(cricket::kMinVideoBitrateBps,
6699 stream->GetVideoStreams()[0].min_bitrate_bps);
6700 EXPECT_GT(stream->GetVideoStreams()[0].max_bitrate_bps,
6701 stream->GetVideoStreams()[0].min_bitrate_bps);
6702 EXPECT_EQ(stream->GetVideoStreams()[0].max_bitrate_bps,
6703 stream->GetVideoStreams()[0].target_bitrate_bps);
6704}
6705
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006706// Test that a stream will not be sending if its encoding is made inactive
6707// through SetRtpSendParameters.
Seth Hampson8234ead2018-02-02 15:16:24 -08006708TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersOneEncodingActive) {
deadbeefdbe2b872016-03-22 15:42:00 -07006709 FakeVideoSendStream* stream = AddSendStream();
6710 EXPECT_TRUE(channel_->SetSend(true));
6711 EXPECT_TRUE(stream->IsSending());
6712
6713 // Get current parameters and change "active" to false.
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006714 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
deadbeefdbe2b872016-03-22 15:42:00 -07006715 ASSERT_EQ(1u, parameters.encodings.size());
6716 ASSERT_TRUE(parameters.encodings[0].active);
6717 parameters.encodings[0].active = false;
Zach Steinba37b4b2018-01-23 15:02:36 -08006718 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeefdbe2b872016-03-22 15:42:00 -07006719 EXPECT_FALSE(stream->IsSending());
6720
6721 // Now change it back to active and verify we resume sending.
6722 parameters.encodings[0].active = true;
Zach Steinba37b4b2018-01-23 15:02:36 -08006723 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeefdbe2b872016-03-22 15:42:00 -07006724 EXPECT_TRUE(stream->IsSending());
6725}
6726
Seth Hampson8234ead2018-02-02 15:16:24 -08006727// Tests that when active is updated for any simulcast layer then the send
6728// stream's sending state will be updated and it will be reconfigured with the
6729// new appropriate active simulcast streams.
6730TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersMultipleEncodingsActive) {
6731 // Create the stream params with multiple ssrcs for simulcast.
Åsa Persson31cb8f92018-06-27 10:44:56 +02006732 const size_t kNumSimulcastStreams = 3;
Seth Hampson8234ead2018-02-02 15:16:24 -08006733 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
6734 StreamParams stream_params = CreateSimStreamParams("cname", ssrcs);
6735 FakeVideoSendStream* fake_video_send_stream = AddSendStream(stream_params);
6736 uint32_t primary_ssrc = stream_params.first_ssrc();
6737
Niels Möller805a27e2019-01-21 12:21:27 +01006738 // Using the FrameForwarder, we manually send a full size
Tommi85959932018-02-07 19:26:06 +01006739 // frame. This allows us to test that ReconfigureEncoder is called
6740 // appropriately.
Niels Möller805a27e2019-01-21 12:21:27 +01006741 webrtc::test::FrameForwarder frame_forwarder;
Seth Hampson8234ead2018-02-02 15:16:24 -08006742 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006743 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, &options, &frame_forwarder));
Seth Hampson8234ead2018-02-02 15:16:24 -08006744 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006745 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame(
6746 1920, 1080, webrtc::VideoRotation::kVideoRotation_0,
6747 rtc::kNumMicrosecsPerSec / 30));
Seth Hampson8234ead2018-02-02 15:16:24 -08006748
6749 // Check that all encodings are initially active.
6750 webrtc::RtpParameters parameters =
6751 channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02006752 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006753 EXPECT_TRUE(parameters.encodings[0].active);
6754 EXPECT_TRUE(parameters.encodings[1].active);
6755 EXPECT_TRUE(parameters.encodings[2].active);
6756 EXPECT_TRUE(fake_video_send_stream->IsSending());
6757
6758 // Only turn on only the middle stream.
6759 parameters.encodings[0].active = false;
6760 parameters.encodings[1].active = true;
6761 parameters.encodings[2].active = false;
6762 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
6763 // Verify that the active fields are set on the VideoChannel.
6764 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02006765 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006766 EXPECT_FALSE(parameters.encodings[0].active);
6767 EXPECT_TRUE(parameters.encodings[1].active);
6768 EXPECT_FALSE(parameters.encodings[2].active);
6769 // Check that the VideoSendStream is updated appropriately. This means its
6770 // send state was updated and it was reconfigured.
6771 EXPECT_TRUE(fake_video_send_stream->IsSending());
6772 std::vector<webrtc::VideoStream> simulcast_streams =
6773 fake_video_send_stream->GetVideoStreams();
Åsa Persson31cb8f92018-06-27 10:44:56 +02006774 EXPECT_EQ(kNumSimulcastStreams, simulcast_streams.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006775 EXPECT_FALSE(simulcast_streams[0].active);
6776 EXPECT_TRUE(simulcast_streams[1].active);
6777 EXPECT_FALSE(simulcast_streams[2].active);
6778
6779 // Turn off all streams.
6780 parameters.encodings[0].active = false;
6781 parameters.encodings[1].active = false;
6782 parameters.encodings[2].active = false;
6783 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
6784 // Verify that the active fields are set on the VideoChannel.
6785 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02006786 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006787 EXPECT_FALSE(parameters.encodings[0].active);
6788 EXPECT_FALSE(parameters.encodings[1].active);
6789 EXPECT_FALSE(parameters.encodings[2].active);
6790 // Check that the VideoSendStream is off.
6791 EXPECT_FALSE(fake_video_send_stream->IsSending());
6792 simulcast_streams = fake_video_send_stream->GetVideoStreams();
Åsa Persson31cb8f92018-06-27 10:44:56 +02006793 EXPECT_EQ(kNumSimulcastStreams, simulcast_streams.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006794 EXPECT_FALSE(simulcast_streams[0].active);
6795 EXPECT_FALSE(simulcast_streams[1].active);
6796 EXPECT_FALSE(simulcast_streams[2].active);
6797
Niels Möllerff40b142018-04-09 08:49:14 +02006798 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, nullptr, nullptr));
Seth Hampson8234ead2018-02-02 15:16:24 -08006799}
6800
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006801// Test that if a stream is reconfigured (due to a codec change or other
6802// change) while its encoding is still inactive, it doesn't start sending.
eladalonf1841382017-06-12 01:16:46 -07006803TEST_F(WebRtcVideoChannelTest,
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006804 InactiveStreamDoesntStartSendingWhenReconfigured) {
6805 // Set an initial codec list, which will be modified later.
6806 cricket::VideoSendParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08006807 parameters1.codecs.push_back(GetEngineCodec("VP8"));
6808 parameters1.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006809 EXPECT_TRUE(channel_->SetSendParameters(parameters1));
6810
6811 FakeVideoSendStream* stream = AddSendStream();
6812 EXPECT_TRUE(channel_->SetSend(true));
6813 EXPECT_TRUE(stream->IsSending());
6814
6815 // Get current parameters and change "active" to false.
6816 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6817 ASSERT_EQ(1u, parameters.encodings.size());
6818 ASSERT_TRUE(parameters.encodings[0].active);
6819 parameters.encodings[0].active = false;
6820 EXPECT_EQ(1u, GetFakeSendStreams().size());
6821 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
Zach Steinba37b4b2018-01-23 15:02:36 -08006822 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006823 EXPECT_FALSE(stream->IsSending());
6824
6825 // Reorder the codec list, causing the stream to be reconfigured.
6826 cricket::VideoSendParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08006827 parameters2.codecs.push_back(GetEngineCodec("VP9"));
6828 parameters2.codecs.push_back(GetEngineCodec("VP8"));
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006829 EXPECT_TRUE(channel_->SetSendParameters(parameters2));
6830 auto new_streams = GetFakeSendStreams();
6831 // Assert that a new underlying stream was created due to the codec change.
6832 // Otherwise, this test isn't testing what it set out to test.
6833 EXPECT_EQ(1u, GetFakeSendStreams().size());
6834 EXPECT_EQ(2, fake_call_->GetNumCreatedSendStreams());
6835
6836 // Verify that we still are not sending anything, due to the inactive
6837 // encoding.
6838 EXPECT_FALSE(new_streams[0]->IsSending());
6839}
6840
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006841// Test that GetRtpSendParameters returns the currently configured codecs.
eladalonf1841382017-06-12 01:16:46 -07006842TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersCodecs) {
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006843 AddSendStream();
6844 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006845 parameters.codecs.push_back(GetEngineCodec("VP8"));
6846 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006847 EXPECT_TRUE(channel_->SetSendParameters(parameters));
6848
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006849 webrtc::RtpParameters rtp_parameters =
6850 channel_->GetRtpSendParameters(last_ssrc_);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006851 ASSERT_EQ(2u, rtp_parameters.codecs.size());
magjed509e4fe2016-11-18 01:34:11 -08006852 EXPECT_EQ(GetEngineCodec("VP8").ToCodecParameters(),
6853 rtp_parameters.codecs[0]);
6854 EXPECT_EQ(GetEngineCodec("VP9").ToCodecParameters(),
6855 rtp_parameters.codecs[1]);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006856}
6857
Florent Castellidacec712018-05-24 16:24:21 +02006858// Test that GetRtpSendParameters returns the currently configured RTCP CNAME.
6859TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersRtcpCname) {
6860 StreamParams params = StreamParams::CreateLegacy(kSsrc);
6861 params.cname = "rtcpcname";
6862 AddSendStream(params);
6863
6864 webrtc::RtpParameters rtp_parameters = channel_->GetRtpSendParameters(kSsrc);
6865 EXPECT_STREQ("rtcpcname", rtp_parameters.rtcp.cname.c_str());
6866}
6867
deadbeeffb2aced2017-01-06 23:05:37 -08006868// Test that RtpParameters for send stream has one encoding and it has
6869// the correct SSRC.
eladalonf1841382017-06-12 01:16:46 -07006870TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersSsrc) {
deadbeeffb2aced2017-01-06 23:05:37 -08006871 AddSendStream();
6872
6873 webrtc::RtpParameters rtp_parameters =
6874 channel_->GetRtpSendParameters(last_ssrc_);
6875 ASSERT_EQ(1u, rtp_parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01006876 EXPECT_EQ(last_ssrc_, rtp_parameters.encodings[0].ssrc);
deadbeeffb2aced2017-01-06 23:05:37 -08006877}
6878
Florent Castelliabe301f2018-06-12 18:33:49 +02006879TEST_F(WebRtcVideoChannelTest, DetectRtpSendParameterHeaderExtensionsChange) {
6880 AddSendStream();
6881
6882 webrtc::RtpParameters rtp_parameters =
6883 channel_->GetRtpSendParameters(last_ssrc_);
6884 rtp_parameters.header_extensions.emplace_back();
6885
6886 EXPECT_NE(0u, rtp_parameters.header_extensions.size());
6887
6888 webrtc::RTCError result =
6889 channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6890 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION, result.type());
6891}
6892
Florent Castelli87b3c512018-07-18 16:00:28 +02006893TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersDegradationPreference) {
6894 AddSendStream();
6895
Niels Möller805a27e2019-01-21 12:21:27 +01006896 webrtc::test::FrameForwarder frame_forwarder;
6897 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Florent Castelli87b3c512018-07-18 16:00:28 +02006898
6899 webrtc::RtpParameters rtp_parameters =
6900 channel_->GetRtpSendParameters(last_ssrc_);
6901 EXPECT_EQ(rtp_parameters.degradation_preference,
6902 webrtc::DegradationPreference::BALANCED);
6903 rtp_parameters.degradation_preference =
6904 webrtc::DegradationPreference::MAINTAIN_FRAMERATE;
6905
6906 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters).ok());
6907
6908 webrtc::RtpParameters updated_rtp_parameters =
6909 channel_->GetRtpSendParameters(last_ssrc_);
6910 EXPECT_EQ(updated_rtp_parameters.degradation_preference,
6911 webrtc::DegradationPreference::MAINTAIN_FRAMERATE);
6912
6913 // Remove the source since it will be destroyed before the channel
6914 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6915}
6916
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006917// Test that if we set/get parameters multiple times, we get the same results.
eladalonf1841382017-06-12 01:16:46 -07006918TEST_F(WebRtcVideoChannelTest, SetAndGetRtpSendParameters) {
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006919 AddSendStream();
6920 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006921 parameters.codecs.push_back(GetEngineCodec("VP8"));
6922 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006923 EXPECT_TRUE(channel_->SetSendParameters(parameters));
6924
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006925 webrtc::RtpParameters initial_params =
6926 channel_->GetRtpSendParameters(last_ssrc_);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006927
6928 // We should be able to set the params we just got.
Zach Steinba37b4b2018-01-23 15:02:36 -08006929 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, initial_params).ok());
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006930
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006931 // ... And this shouldn't change the params returned by GetRtpSendParameters.
6932 EXPECT_EQ(initial_params, channel_->GetRtpSendParameters(last_ssrc_));
6933}
6934
6935// Test that GetRtpReceiveParameters returns the currently configured codecs.
eladalonf1841382017-06-12 01:16:46 -07006936TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersCodecs) {
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006937 AddRecvStream();
6938 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006939 parameters.codecs.push_back(GetEngineCodec("VP8"));
6940 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006941 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6942
6943 webrtc::RtpParameters rtp_parameters =
6944 channel_->GetRtpReceiveParameters(last_ssrc_);
6945 ASSERT_EQ(2u, rtp_parameters.codecs.size());
magjed509e4fe2016-11-18 01:34:11 -08006946 EXPECT_EQ(GetEngineCodec("VP8").ToCodecParameters(),
6947 rtp_parameters.codecs[0]);
6948 EXPECT_EQ(GetEngineCodec("VP9").ToCodecParameters(),
6949 rtp_parameters.codecs[1]);
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006950}
6951
johan073ece42016-08-26 02:59:47 -07006952#if defined(WEBRTC_USE_H264)
eladalonf1841382017-06-12 01:16:46 -07006953TEST_F(WebRtcVideoChannelTest, GetRtpReceiveFmtpSprop) {
johan073ece42016-08-26 02:59:47 -07006954#else
eladalonf1841382017-06-12 01:16:46 -07006955TEST_F(WebRtcVideoChannelTest, DISABLED_GetRtpReceiveFmtpSprop) {
johan073ece42016-08-26 02:59:47 -07006956#endif
johan3859c892016-08-05 09:19:25 -07006957 cricket::VideoRecvParameters parameters;
perkj26752742016-10-24 01:21:16 -07006958 cricket::VideoCodec kH264sprop1(101, "H264");
magjed5dfac562016-11-25 03:56:37 -08006959 kH264sprop1.SetParam(kH264FmtpSpropParameterSets, "uvw");
johan3859c892016-08-05 09:19:25 -07006960 parameters.codecs.push_back(kH264sprop1);
perkj26752742016-10-24 01:21:16 -07006961 cricket::VideoCodec kH264sprop2(102, "H264");
magjed5dfac562016-11-25 03:56:37 -08006962 kH264sprop2.SetParam(kH264FmtpSpropParameterSets, "xyz");
johan3859c892016-08-05 09:19:25 -07006963 parameters.codecs.push_back(kH264sprop2);
6964 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6965
6966 FakeVideoReceiveStream* recv_stream = AddRecvStream();
6967 const webrtc::VideoReceiveStream::Config& cfg = recv_stream->GetConfig();
6968 webrtc::RtpParameters rtp_parameters =
6969 channel_->GetRtpReceiveParameters(last_ssrc_);
6970 ASSERT_EQ(2u, rtp_parameters.codecs.size());
6971 EXPECT_EQ(kH264sprop1.ToCodecParameters(), rtp_parameters.codecs[0]);
6972 ASSERT_EQ(2u, cfg.decoders.size());
6973 EXPECT_EQ(101, cfg.decoders[0].payload_type);
Niels Möllercb7e1d22018-09-11 15:56:04 +02006974 EXPECT_EQ("H264", cfg.decoders[0].video_format.name);
magjed5dfac562016-11-25 03:56:37 -08006975 const auto it0 =
Niels Möllercb7e1d22018-09-11 15:56:04 +02006976 cfg.decoders[0].video_format.parameters.find(kH264FmtpSpropParameterSets);
6977 ASSERT_TRUE(it0 != cfg.decoders[0].video_format.parameters.end());
magjed5dfac562016-11-25 03:56:37 -08006978 EXPECT_EQ("uvw", it0->second);
johan3859c892016-08-05 09:19:25 -07006979
6980 EXPECT_EQ(102, cfg.decoders[1].payload_type);
Niels Möllercb7e1d22018-09-11 15:56:04 +02006981 EXPECT_EQ("H264", cfg.decoders[1].video_format.name);
magjed5dfac562016-11-25 03:56:37 -08006982 const auto it1 =
Niels Möllercb7e1d22018-09-11 15:56:04 +02006983 cfg.decoders[1].video_format.parameters.find(kH264FmtpSpropParameterSets);
6984 ASSERT_TRUE(it1 != cfg.decoders[1].video_format.parameters.end());
magjed5dfac562016-11-25 03:56:37 -08006985 EXPECT_EQ("xyz", it1->second);
johan3859c892016-08-05 09:19:25 -07006986}
6987
sakal1fd95952016-06-22 00:46:15 -07006988// Test that RtpParameters for receive stream has one encoding and it has
6989// the correct SSRC.
eladalonf1841382017-06-12 01:16:46 -07006990TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersSsrc) {
sakal1fd95952016-06-22 00:46:15 -07006991 AddRecvStream();
6992
6993 webrtc::RtpParameters rtp_parameters =
6994 channel_->GetRtpReceiveParameters(last_ssrc_);
6995 ASSERT_EQ(1u, rtp_parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01006996 EXPECT_EQ(last_ssrc_, rtp_parameters.encodings[0].ssrc);
sakal1fd95952016-06-22 00:46:15 -07006997}
6998
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006999// Test that if we set/get parameters multiple times, we get the same results.
eladalonf1841382017-06-12 01:16:46 -07007000TEST_F(WebRtcVideoChannelTest, SetAndGetRtpReceiveParameters) {
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007001 AddRecvStream();
7002 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08007003 parameters.codecs.push_back(GetEngineCodec("VP8"));
7004 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007005 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
7006
7007 webrtc::RtpParameters initial_params =
7008 channel_->GetRtpReceiveParameters(last_ssrc_);
7009
7010 // We should be able to set the params we just got.
7011 EXPECT_TRUE(channel_->SetRtpReceiveParameters(last_ssrc_, initial_params));
7012
7013 // ... And this shouldn't change the params returned by
7014 // GetRtpReceiveParameters.
7015 EXPECT_EQ(initial_params, channel_->GetRtpReceiveParameters(last_ssrc_));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007016}
7017
deadbeef3bc15102017-04-20 19:25:07 -07007018// Test that GetRtpReceiveParameters returns parameters correctly when SSRCs
7019// aren't signaled. It should always return an empty "RtpEncodingParameters",
7020// even after a packet is received and the unsignaled SSRC is known.
eladalonf1841382017-06-12 01:16:46 -07007021TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersWithUnsignaledSsrc) {
deadbeef3bc15102017-04-20 19:25:07 -07007022 // Call necessary methods to configure receiving a default stream as
7023 // soon as it arrives.
7024 cricket::VideoRecvParameters parameters;
7025 parameters.codecs.push_back(GetEngineCodec("VP8"));
7026 parameters.codecs.push_back(GetEngineCodec("VP9"));
7027 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
7028
7029 // Call GetRtpReceiveParameters before configured to receive an unsignaled
7030 // stream. Should return nothing.
7031 EXPECT_EQ(webrtc::RtpParameters(), channel_->GetRtpReceiveParameters(0));
7032
7033 // Set a sink for an unsignaled stream.
7034 cricket::FakeVideoRenderer renderer;
7035 // Value of "0" means "unsignaled stream".
7036 EXPECT_TRUE(channel_->SetSink(0, &renderer));
7037
7038 // Call GetRtpReceiveParameters before the SSRC is known. Value of "0"
7039 // in this method means "unsignaled stream".
7040 webrtc::RtpParameters rtp_parameters = channel_->GetRtpReceiveParameters(0);
7041 ASSERT_EQ(1u, rtp_parameters.encodings.size());
7042 EXPECT_FALSE(rtp_parameters.encodings[0].ssrc);
7043
7044 // Receive VP8 packet.
7045 uint8_t data[kMinRtpPacketLen];
7046 cricket::RtpHeader rtpHeader;
7047 rtpHeader.payload_type = GetEngineCodec("VP8").id;
7048 rtpHeader.seq_num = rtpHeader.timestamp = 0;
7049 rtpHeader.ssrc = kIncomingUnsignalledSsrc;
7050 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
7051 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07007052 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
deadbeef3bc15102017-04-20 19:25:07 -07007053
7054 // The |ssrc| member should still be unset.
7055 rtp_parameters = channel_->GetRtpReceiveParameters(0);
7056 ASSERT_EQ(1u, rtp_parameters.encodings.size());
7057 EXPECT_FALSE(rtp_parameters.encodings[0].ssrc);
7058}
7059
eladalonf1841382017-06-12 01:16:46 -07007060void WebRtcVideoChannelTest::TestReceiverLocalSsrcConfiguration(
Peter Boström3548dd22015-05-22 18:48:36 +02007061 bool receiver_first) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02007062 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boström3548dd22015-05-22 18:48:36 +02007063
7064 const uint32_t kSenderSsrc = 0xC0FFEE;
Peter Boströmdfa28152015-10-21 17:21:10 +02007065 const uint32_t kSecondSenderSsrc = 0xBADCAFE;
Peter Boström3548dd22015-05-22 18:48:36 +02007066 const uint32_t kReceiverSsrc = 0x4711;
Peter Boströmdfa28152015-10-21 17:21:10 +02007067 const uint32_t kExpectedDefaultReceiverSsrc = 1;
Peter Boström3548dd22015-05-22 18:48:36 +02007068
7069 if (receiver_first) {
7070 AddRecvStream(StreamParams::CreateLegacy(kReceiverSsrc));
7071 std::vector<FakeVideoReceiveStream*> receive_streams =
7072 fake_call_->GetVideoReceiveStreams();
7073 ASSERT_EQ(1u, receive_streams.size());
Peter Boströmdfa28152015-10-21 17:21:10 +02007074 // Default local SSRC when we have no sender.
7075 EXPECT_EQ(kExpectedDefaultReceiverSsrc,
7076 receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boström3548dd22015-05-22 18:48:36 +02007077 }
7078 AddSendStream(StreamParams::CreateLegacy(kSenderSsrc));
7079 if (!receiver_first)
7080 AddRecvStream(StreamParams::CreateLegacy(kReceiverSsrc));
7081 std::vector<FakeVideoReceiveStream*> receive_streams =
7082 fake_call_->GetVideoReceiveStreams();
7083 ASSERT_EQ(1u, receive_streams.size());
7084 EXPECT_EQ(kSenderSsrc, receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boströmdfa28152015-10-21 17:21:10 +02007085
7086 // Removing first sender should fall back to another (in this case the second)
7087 // local send stream's SSRC.
7088 AddSendStream(StreamParams::CreateLegacy(kSecondSenderSsrc));
7089 ASSERT_TRUE(channel_->RemoveSendStream(kSenderSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02007090 receive_streams = fake_call_->GetVideoReceiveStreams();
Peter Boströmdfa28152015-10-21 17:21:10 +02007091 ASSERT_EQ(1u, receive_streams.size());
7092 EXPECT_EQ(kSecondSenderSsrc, receive_streams[0]->GetConfig().rtp.local_ssrc);
7093
7094 // Removing the last sender should fall back to default local SSRC.
7095 ASSERT_TRUE(channel_->RemoveSendStream(kSecondSenderSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02007096 receive_streams = fake_call_->GetVideoReceiveStreams();
Peter Boströmdfa28152015-10-21 17:21:10 +02007097 ASSERT_EQ(1u, receive_streams.size());
7098 EXPECT_EQ(kExpectedDefaultReceiverSsrc,
7099 receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boström3548dd22015-05-22 18:48:36 +02007100}
7101
eladalonf1841382017-06-12 01:16:46 -07007102TEST_F(WebRtcVideoChannelTest, ConfiguresLocalSsrc) {
Peter Boström3548dd22015-05-22 18:48:36 +02007103 TestReceiverLocalSsrcConfiguration(false);
7104}
7105
eladalonf1841382017-06-12 01:16:46 -07007106TEST_F(WebRtcVideoChannelTest, ConfiguresLocalSsrcOnExistingReceivers) {
Peter Boström3548dd22015-05-22 18:48:36 +02007107 TestReceiverLocalSsrcConfiguration(true);
7108}
7109
eladalonf1841382017-06-12 01:16:46 -07007110class WebRtcVideoChannelSimulcastTest : public testing::Test {
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007111 public:
eladalonf1841382017-06-12 01:16:46 -07007112 WebRtcVideoChannelSimulcastTest()
Sebastian Jansson8f83b422018-02-21 13:07:13 +01007113 : fake_call_(),
Magnus Jedvert02e7a192017-09-23 17:21:32 +02007114 encoder_factory_(new cricket::FakeWebRtcVideoEncoderFactory),
7115 decoder_factory_(new cricket::FakeWebRtcVideoDecoderFactory),
Jiawei Ouc2ebe212018-11-08 10:02:56 -08007116 mock_rate_allocator_factory_(
7117 new webrtc::MockVideoBitrateAllocatorFactory),
Anders Carlsson67537952018-05-03 11:28:29 +02007118 engine_(std::unique_ptr<cricket::FakeWebRtcVideoEncoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +02007119 encoder_factory_),
Anders Carlsson67537952018-05-03 11:28:29 +02007120 std::unique_ptr<cricket::FakeWebRtcVideoDecoderFactory>(
Jiawei Ouc2ebe212018-11-08 10:02:56 -08007121 decoder_factory_),
7122 std::unique_ptr<webrtc::VideoBitrateAllocatorFactory>(
7123 mock_rate_allocator_factory_)),
magjed2475ae22017-09-12 04:42:15 -07007124 last_ssrc_(0) {}
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007125
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00007126 void SetUp() override {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02007127 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson84848f22018-11-16 10:40:36 +01007128 channel_.reset(engine_.CreateMediaChannel(&fake_call_, GetMediaConfig(),
7129 VideoOptions(),
7130 webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08007131 channel_->OnReadyToSend(true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007132 last_ssrc_ = 123;
7133 }
7134
7135 protected:
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007136 void VerifySimulcastSettings(const VideoCodec& codec,
perkj26752742016-10-24 01:21:16 -07007137 int capture_width,
7138 int capture_height,
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007139 size_t num_configured_streams,
sprang429600d2017-01-26 06:12:26 -08007140 size_t expected_num_streams,
7141 bool screenshare,
7142 bool conference_mode) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02007143 cricket::VideoSendParameters parameters;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02007144 parameters.codecs.push_back(codec);
sprang429600d2017-01-26 06:12:26 -08007145 parameters.conference_mode = conference_mode;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02007146 ASSERT_TRUE(channel_->SetSendParameters(parameters));
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007147
Peter Boström0c4e06b2015-10-07 12:23:21 +02007148 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
henrikg91d6ede2015-09-17 00:24:34 -07007149 RTC_DCHECK(num_configured_streams <= ssrcs.size());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007150 ssrcs.resize(num_configured_streams);
7151
sprangf24a0642017-02-28 13:23:26 -08007152 AddSendStream(CreateSimStreamParams("cname", ssrcs));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00007153 // Send a full-size frame to trigger a stream reconfiguration to use all
7154 // expected simulcast layers.
Niels Möller805a27e2019-01-21 12:21:27 +01007155 webrtc::test::FrameForwarder frame_forwarder;
7156 cricket::FakeFrameSource frame_source(capture_width, capture_height,
7157 rtc::kNumMicrosecsPerSec / 30);
7158
sprangf24a0642017-02-28 13:23:26 -08007159 VideoOptions options;
7160 if (screenshare)
Oskar Sundbom78807582017-11-16 11:09:55 +01007161 options.is_screencast = screenshare;
Niels Möller805a27e2019-01-21 12:21:27 +01007162 EXPECT_TRUE(
7163 channel_->SetVideoSend(ssrcs.front(), &options, &frame_forwarder));
sprangf24a0642017-02-28 13:23:26 -08007164 // Fetch the latest stream since SetVideoSend() may recreate it if the
7165 // screen content setting is changed.
7166 FakeVideoSendStream* stream = fake_call_.GetVideoSendStreams().front();
pbos@webrtc.org86196c42015-02-16 21:02:00 +00007167 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01007168 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007169
Zach Stein3ca452b2018-01-18 10:01:24 -08007170 auto rtp_parameters = channel_->GetRtpSendParameters(kSsrcs3[0]);
7171 EXPECT_EQ(num_configured_streams, rtp_parameters.encodings.size());
7172
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007173 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
7174 ASSERT_EQ(expected_num_streams, video_streams.size());
Ilya Nikolaevskiy33d2a912019-04-02 11:05:03 +02007175 EXPECT_LE(expected_num_streams, stream->GetConfig().rtp.ssrcs.size());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007176
sprang429600d2017-01-26 06:12:26 -08007177 std::vector<webrtc::VideoStream> expected_streams;
7178 if (conference_mode) {
7179 expected_streams = GetSimulcastConfig(
7180 num_configured_streams, capture_width, capture_height, 0,
Seth Hampson24722b32017-12-22 09:36:42 -08007181 webrtc::kDefaultBitratePriority, kDefaultQpMax,
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +02007182 kDefaultVideoMaxFramerate, screenshare, true);
sprang3ebabf12017-02-16 07:35:22 -08007183 if (screenshare) {
7184 for (const webrtc::VideoStream& stream : expected_streams) {
7185 // Never scale screen content.
Danil Chapovalov350531e2018-06-08 11:04:04 +00007186 EXPECT_EQ(stream.width, rtc::checked_cast<size_t>(capture_width));
7187 EXPECT_EQ(stream.height, rtc::checked_cast<size_t>(capture_height));
sprang3ebabf12017-02-16 07:35:22 -08007188 }
7189 }
sprang429600d2017-01-26 06:12:26 -08007190 } else {
7191 webrtc::VideoStream stream;
7192 stream.width = capture_width;
7193 stream.height = capture_height;
7194 stream.max_framerate = kDefaultVideoMaxFramerate;
Åsa Persson45bbc8a2017-11-13 10:16:47 +01007195 stream.min_bitrate_bps = cricket::kMinVideoBitrateBps;
sprang429600d2017-01-26 06:12:26 -08007196 stream.target_bitrate_bps = stream.max_bitrate_bps =
Åsa Perssonbdee46d2018-06-25 11:28:06 +02007197 GetMaxDefaultBitrateBps(capture_width, capture_height);
sprang429600d2017-01-26 06:12:26 -08007198 stream.max_qp = kDefaultQpMax;
7199 expected_streams.push_back(stream);
7200 }
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007201
7202 ASSERT_EQ(expected_streams.size(), video_streams.size());
7203
7204 size_t num_streams = video_streams.size();
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00007205 int total_max_bitrate_bps = 0;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007206 for (size_t i = 0; i < num_streams; ++i) {
7207 EXPECT_EQ(expected_streams[i].width, video_streams[i].width);
7208 EXPECT_EQ(expected_streams[i].height, video_streams[i].height);
7209
7210 EXPECT_GT(video_streams[i].max_framerate, 0);
7211 EXPECT_EQ(expected_streams[i].max_framerate,
7212 video_streams[i].max_framerate);
7213
7214 EXPECT_GT(video_streams[i].min_bitrate_bps, 0);
7215 EXPECT_EQ(expected_streams[i].min_bitrate_bps,
7216 video_streams[i].min_bitrate_bps);
7217
7218 EXPECT_GT(video_streams[i].target_bitrate_bps, 0);
7219 EXPECT_EQ(expected_streams[i].target_bitrate_bps,
7220 video_streams[i].target_bitrate_bps);
7221
7222 EXPECT_GT(video_streams[i].max_bitrate_bps, 0);
7223 EXPECT_EQ(expected_streams[i].max_bitrate_bps,
7224 video_streams[i].max_bitrate_bps);
7225
7226 EXPECT_GT(video_streams[i].max_qp, 0);
7227 EXPECT_EQ(expected_streams[i].max_qp, video_streams[i].max_qp);
7228
Sergey Silkina796a7e2018-03-01 15:11:29 +01007229 EXPECT_EQ(conference_mode,
7230 expected_streams[i].num_temporal_layers.has_value());
7231
7232 if (conference_mode) {
7233 EXPECT_EQ(expected_streams[i].num_temporal_layers,
7234 video_streams[i].num_temporal_layers);
7235 }
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00007236
7237 if (i == num_streams - 1) {
7238 total_max_bitrate_bps += video_streams[i].max_bitrate_bps;
7239 } else {
7240 total_max_bitrate_bps += video_streams[i].target_bitrate_bps;
7241 }
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007242 }
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00007243
Niels Möllerff40b142018-04-09 08:49:14 +02007244 EXPECT_TRUE(channel_->SetVideoSend(ssrcs.front(), nullptr, nullptr));
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007245 }
7246
7247 FakeVideoSendStream* AddSendStream() {
7248 return AddSendStream(StreamParams::CreateLegacy(last_ssrc_++));
7249 }
7250
7251 FakeVideoSendStream* AddSendStream(const StreamParams& sp) {
Yves Gerey665174f2018-06-19 15:03:05 +02007252 size_t num_streams = fake_call_.GetVideoSendStreams().size();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007253 EXPECT_TRUE(channel_->AddSendStream(sp));
7254 std::vector<FakeVideoSendStream*> streams =
Fredrik Solenberg709ed672015-09-15 12:26:33 +02007255 fake_call_.GetVideoSendStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007256 EXPECT_EQ(num_streams + 1, streams.size());
7257 return streams[streams.size() - 1];
7258 }
7259
7260 std::vector<FakeVideoSendStream*> GetFakeSendStreams() {
Fredrik Solenberg709ed672015-09-15 12:26:33 +02007261 return fake_call_.GetVideoSendStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007262 }
7263
7264 FakeVideoReceiveStream* AddRecvStream() {
7265 return AddRecvStream(StreamParams::CreateLegacy(last_ssrc_++));
7266 }
7267
7268 FakeVideoReceiveStream* AddRecvStream(const StreamParams& sp) {
Yves Gerey665174f2018-06-19 15:03:05 +02007269 size_t num_streams = fake_call_.GetVideoReceiveStreams().size();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007270 EXPECT_TRUE(channel_->AddRecvStream(sp));
7271 std::vector<FakeVideoReceiveStream*> streams =
Fredrik Solenberg709ed672015-09-15 12:26:33 +02007272 fake_call_.GetVideoReceiveStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007273 EXPECT_EQ(num_streams + 1, streams.size());
7274 return streams[streams.size() - 1];
7275 }
7276
skvlad11a9cbf2016-10-07 11:53:05 -07007277 webrtc::RtcEventLogNullImpl event_log_;
Fredrik Solenberg709ed672015-09-15 12:26:33 +02007278 FakeCall fake_call_;
Magnus Jedvert02e7a192017-09-23 17:21:32 +02007279 cricket::FakeWebRtcVideoEncoderFactory* encoder_factory_;
7280 cricket::FakeWebRtcVideoDecoderFactory* decoder_factory_;
Jiawei Ouc2ebe212018-11-08 10:02:56 -08007281 webrtc::MockVideoBitrateAllocatorFactory* mock_rate_allocator_factory_;
eladalonf1841382017-06-12 01:16:46 -07007282 WebRtcVideoEngine engine_;
kwiberg686a8ef2016-02-26 03:00:35 -08007283 std::unique_ptr<VideoMediaChannel> channel_;
Peter Boström0c4e06b2015-10-07 12:23:21 +02007284 uint32_t last_ssrc_;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007285};
7286
eladalonf1841382017-06-12 01:16:46 -07007287TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWith2SimulcastStreams) {
sprang429600d2017-01-26 06:12:26 -08007288 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 640, 360, 2, 2, false,
7289 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007290}
7291
eladalonf1841382017-06-12 01:16:46 -07007292TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWith3SimulcastStreams) {
sprang429600d2017-01-26 06:12:26 -08007293 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 3, false,
7294 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007295}
7296
7297// Test that we normalize send codec format size in simulcast.
eladalonf1841382017-06-12 01:16:46 -07007298TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWithOddSizeInSimulcast) {
sprang429600d2017-01-26 06:12:26 -08007299 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 541, 271, 2, 2, false,
7300 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007301}
sprang429600d2017-01-26 06:12:26 -08007302
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02007303TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsForScreenshare) {
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02007304 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
7305 false);
7306}
7307
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02007308TEST_F(WebRtcVideoChannelSimulcastTest,
7309 SetSendCodecsForConferenceModeScreenshare) {
Erik Språng72e52ee2018-11-29 11:41:53 +01007310 webrtc::test::ScopedFieldTrials field_trials(
7311 "WebRTC-SimulcastScreenshare/Disabled/");
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02007312 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
7313 true);
7314}
7315
eladalonf1841382017-06-12 01:16:46 -07007316TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsForSimulcastScreenshare) {
sprang429600d2017-01-26 06:12:26 -08007317 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 2, true,
7318 true);
7319}
7320
eladalonf1841382017-06-12 01:16:46 -07007321TEST_F(WebRtcVideoChannelSimulcastTest,
sprangfe627f32017-03-29 08:24:59 -07007322 NoSimulcastScreenshareWithoutConference) {
sprangfe627f32017-03-29 08:24:59 -07007323 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
7324 false);
7325}
7326
Yves Gereyb6a89422018-10-08 10:08:32 +02007327class WebRtcVideoFakeClock {
Jonas Oreland49ac5952018-09-26 16:04:32 +02007328 public:
Yves Gereyb6a89422018-10-08 10:08:32 +02007329 WebRtcVideoFakeClock() {
Jonas Oreland49ac5952018-09-26 16:04:32 +02007330 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(1)); // avoid time=0
7331 }
7332 rtc::ScopedFakeClock fake_clock_;
7333};
7334
Yves Gereyb6a89422018-10-08 10:08:32 +02007335// The fake clock needs to be initialized before the call, and not
7336// destroyed until after all threads spawned by the test have been stopped.
7337// This mixin ensures that.
7338class WebRtcVideoChannelTestWithClock : public WebRtcVideoFakeClock,
7339 public WebRtcVideoChannelBaseTest {};
7340
Jonas Oreland49ac5952018-09-26 16:04:32 +02007341TEST_F(WebRtcVideoChannelTestWithClock, GetSources) {
7342 uint8_t data1[] = {0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
7343 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
7344
7345 EXPECT_EQ(0u, channel_->GetSources(kSsrc).size());
7346
7347 rtc::CopyOnWriteBuffer packet1(data1, sizeof(data1));
7348 rtc::SetBE32(packet1.data() + 8, kSsrc);
7349 channel_->SetSink(kDefaultReceiveSsrc, NULL);
7350 EXPECT_TRUE(SetDefaultCodec());
7351 EXPECT_TRUE(SetSend(true));
7352 EXPECT_EQ(0, renderer_.num_rendered_frames());
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07007353 channel_->OnPacketReceived(packet1, /*packet_time_us=*/-1);
Jonas Oreland49ac5952018-09-26 16:04:32 +02007354
7355 std::vector<webrtc::RtpSource> sources = channel_->GetSources(kSsrc);
7356 EXPECT_EQ(1u, sources.size());
7357 EXPECT_EQ(webrtc::RtpSourceType::SSRC, sources[0].source_type());
7358 int64_t timestamp1 = sources[0].timestamp_ms();
7359
7360 // a new packet.
7361 int64_t timeDeltaMs = 1;
7362 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(timeDeltaMs));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07007363 channel_->OnPacketReceived(packet1, /*packet_time_us=*/-1);
Jonas Oreland49ac5952018-09-26 16:04:32 +02007364 int64_t timestamp2 = channel_->GetSources(kSsrc)[0].timestamp_ms();
7365 EXPECT_EQ(timestamp2, timestamp1 + timeDeltaMs);
7366
7367 // It only keeps 10s of history.
7368 fake_clock_.AdvanceTime(webrtc::TimeDelta::seconds(10));
7369 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(1));
7370 EXPECT_EQ(0u, channel_->GetSources(kSsrc).size());
7371}
7372
7373TEST_F(WebRtcVideoChannelTestWithClock, GetContributingSources) {
7374 uint8_t data1[] = {0x81, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
7375 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
7376
7377 uint32_t kCsrc = 4321u;
7378 EXPECT_EQ(0u, channel_->GetSources(kSsrc).size());
7379 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7380
7381 rtc::CopyOnWriteBuffer packet1(data1, sizeof(data1));
7382 rtc::SetBE32(packet1.data() + 8, kSsrc);
7383 rtc::SetBE32(packet1.data() + 12, kCsrc);
7384 channel_->SetSink(kDefaultReceiveSsrc, NULL);
7385 EXPECT_TRUE(SetDefaultCodec());
7386 EXPECT_TRUE(SetSend(true));
7387 EXPECT_EQ(0, renderer_.num_rendered_frames());
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07007388 channel_->OnPacketReceived(packet1, /*packet_time_us=*/-1);
Jonas Oreland49ac5952018-09-26 16:04:32 +02007389
7390 {
7391 ASSERT_EQ(2u, channel_->GetSources(kSsrc).size());
7392 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7393 std::vector<webrtc::RtpSource> sources = channel_->GetSources(kSsrc);
7394 EXPECT_EQ(sources[0].timestamp_ms(), sources[1].timestamp_ms());
7395 // 1 SSRC and 1 CSRC.
Steve Anton2c9ebef2019-01-28 17:27:58 -08007396 EXPECT_EQ(1, absl::c_count_if(sources, [](const webrtc::RtpSource& source) {
7397 return source.source_type() == webrtc::RtpSourceType::SSRC;
7398 }));
7399 EXPECT_EQ(1, absl::c_count_if(sources, [](const webrtc::RtpSource& source) {
7400 return source.source_type() == webrtc::RtpSourceType::CSRC;
7401 }));
Jonas Oreland49ac5952018-09-26 16:04:32 +02007402 }
7403 int64_t timestamp1 = channel_->GetSources(kSsrc)[0].timestamp_ms();
7404
7405 // a new packet with only ssrc (i.e no csrc).
7406 uint8_t data2[] = {0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
7407 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
7408 rtc::CopyOnWriteBuffer packet2(data2, sizeof(data2));
7409 rtc::SetBE32(packet2.data() + 8, kSsrc);
7410
7411 int64_t timeDeltaMs = 1;
7412 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(timeDeltaMs));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07007413 channel_->OnPacketReceived(packet2, /*packet_time_us=*/-1);
Jonas Oreland49ac5952018-09-26 16:04:32 +02007414
7415 {
7416 ASSERT_EQ(2u, channel_->GetSources(kSsrc).size());
7417 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7418 std::vector<webrtc::RtpSource> sources = channel_->GetSources(kSsrc);
7419 EXPECT_NE(sources[0].timestamp_ms(), sources[1].timestamp_ms());
7420 // 1 SSRC and 1 CSRC.
Steve Anton2c9ebef2019-01-28 17:27:58 -08007421 EXPECT_EQ(1, absl::c_count_if(sources, [](const webrtc::RtpSource& source) {
7422 return source.source_type() == webrtc::RtpSourceType::SSRC;
7423 }));
7424 EXPECT_EQ(1, absl::c_count_if(sources, [](const webrtc::RtpSource& source) {
7425 return source.source_type() == webrtc::RtpSourceType::CSRC;
7426 }));
7427 auto ssrcSource =
7428 absl::c_find_if(sources, [](const webrtc::RtpSource& source) {
Jonas Oreland49ac5952018-09-26 16:04:32 +02007429 return source.source_type() == webrtc::RtpSourceType::SSRC;
7430 });
Steve Anton2c9ebef2019-01-28 17:27:58 -08007431 auto csrcSource =
7432 absl::c_find_if(sources, [](const webrtc::RtpSource& source) {
Jonas Oreland49ac5952018-09-26 16:04:32 +02007433 return source.source_type() == webrtc::RtpSourceType::CSRC;
7434 });
7435
7436 EXPECT_EQ(ssrcSource->timestamp_ms(), timestamp1 + timeDeltaMs);
7437 EXPECT_EQ(csrcSource->timestamp_ms(), timestamp1);
7438 }
7439
7440 // It only keeps 10s of history.
7441 fake_clock_.AdvanceTime(webrtc::TimeDelta::seconds(10));
7442
7443 {
7444 ASSERT_EQ(1u, channel_->GetSources(kSsrc).size());
7445 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7446 std::vector<webrtc::RtpSource> sources = channel_->GetSources(kSsrc);
Steve Anton2c9ebef2019-01-28 17:27:58 -08007447 EXPECT_EQ(1, absl::c_count_if(sources, [](const webrtc::RtpSource& source) {
7448 return source.source_type() == webrtc::RtpSourceType::SSRC;
7449 }));
7450 EXPECT_EQ(0, absl::c_count_if(sources, [](const webrtc::RtpSource& source) {
7451 return source.source_type() == webrtc::RtpSourceType::CSRC;
7452 }));
Jonas Oreland49ac5952018-09-26 16:04:32 +02007453 }
7454
7455 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(1));
7456 EXPECT_EQ(0u, channel_->GetSources(kSsrc).size());
7457 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7458}
7459
Amit Hilbuchb000b712019-02-25 10:22:14 -08007460TEST_F(WebRtcVideoChannelTest, SetsRidsOnSendStream) {
7461 StreamParams sp = CreateSimStreamParams("cname", {123, 456, 789});
7462
7463 std::vector<std::string> rids = {"f", "h", "q"};
7464 std::vector<cricket::RidDescription> rid_descriptions;
7465 for (const auto& rid : rids) {
7466 rid_descriptions.emplace_back(rid, cricket::RidDirection::kSend);
7467 }
7468 sp.set_rids(rid_descriptions);
7469
7470 ASSERT_TRUE(channel_->AddSendStream(sp));
7471 const auto& streams = fake_call_->GetVideoSendStreams();
7472 ASSERT_EQ(1u, streams.size());
7473 auto stream = streams[0];
7474 ASSERT_NE(stream, nullptr);
7475 const auto& config = stream->GetConfig();
7476 EXPECT_THAT(config.rtp.rids, ::testing::ElementsAreArray(rids));
7477}
7478
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00007479} // namespace cricket