asapersson@webrtc.org | 5249cc8 | 2011-12-16 14:31:37 +0000 | [diff] [blame] | 1 | /* |
phoglund@webrtc.org | 78088c2 | 2012-02-07 14:56:45 +0000 | [diff] [blame] | 2 | * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. |
asapersson@webrtc.org | 5249cc8 | 2011-12-16 14:31:37 +0000 | [diff] [blame] | 3 | * |
| 4 | * Use of this source code is governed by a BSD-style license |
| 5 | * that can be found in the LICENSE file in the root of the source |
| 6 | * tree. An additional intellectual property rights grant can be found |
| 7 | * in the file PATENTS. All contributing project authors may |
| 8 | * be found in the AUTHORS file in the root of the source tree. |
| 9 | */ |
| 10 | |
Jonas Olsson | a4d8737 | 2019-07-05 19:08:33 +0200 | [diff] [blame] | 11 | #include "modules/rtp_rtcp/source/rtp_sender.h" |
| 12 | |
kwiberg | 84be511 | 2016-04-27 01:19:58 -0700 | [diff] [blame] | 13 | #include <memory> |
danilchap | b8b6fbb | 2015-12-10 05:05:27 -0800 | [diff] [blame] | 14 | #include <vector> |
| 15 | |
Danil Chapovalov | 16cb1f6 | 2019-09-05 11:29:59 +0200 | [diff] [blame] | 16 | #include "api/rtc_event_log/rtc_event.h" |
Per Kjellander | e11b7d2 | 2019-02-21 07:55:59 +0100 | [diff] [blame] | 17 | #include "api/transport/field_trial_based_config.h" |
Erik Språng | f93eda1 | 2019-01-16 17:10:57 +0100 | [diff] [blame] | 18 | #include "api/video/video_codec_constants.h" |
Mirko Bonadei | 92ea95e | 2017-09-15 06:47:31 +0200 | [diff] [blame] | 19 | #include "api/video/video_timing.h" |
| 20 | #include "logging/rtc_event_log/mock/mock_rtc_event_log.h" |
| 21 | #include "modules/rtp_rtcp/include/rtp_cvo.h" |
| 22 | #include "modules/rtp_rtcp/include/rtp_header_extension_map.h" |
Erik Språng | aa59eca | 2019-07-24 14:52:55 +0200 | [diff] [blame] | 23 | #include "modules/rtp_rtcp/include/rtp_packet_sender.h" |
Mirko Bonadei | 92ea95e | 2017-09-15 06:47:31 +0200 | [diff] [blame] | 24 | #include "modules/rtp_rtcp/include/rtp_rtcp_defines.h" |
| 25 | #include "modules/rtp_rtcp/source/rtcp_packet/transport_feedback.h" |
| 26 | #include "modules/rtp_rtcp/source/rtp_format_video_generic.h" |
philipel | b3e42a4 | 2018-09-13 10:57:14 +0200 | [diff] [blame] | 27 | #include "modules/rtp_rtcp/source/rtp_generic_frame_descriptor.h" |
| 28 | #include "modules/rtp_rtcp/source/rtp_generic_frame_descriptor_extension.h" |
Mirko Bonadei | 92ea95e | 2017-09-15 06:47:31 +0200 | [diff] [blame] | 29 | #include "modules/rtp_rtcp/source/rtp_header_extensions.h" |
| 30 | #include "modules/rtp_rtcp/source/rtp_packet_received.h" |
| 31 | #include "modules/rtp_rtcp/source/rtp_packet_to_send.h" |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 32 | #include "modules/rtp_rtcp/source/rtp_sender_egress.h" |
Mirko Bonadei | 92ea95e | 2017-09-15 06:47:31 +0200 | [diff] [blame] | 33 | #include "modules/rtp_rtcp/source/rtp_sender_video.h" |
| 34 | #include "modules/rtp_rtcp/source/rtp_utility.h" |
| 35 | #include "rtc_base/arraysize.h" |
Mirko Bonadei | 92ea95e | 2017-09-15 06:47:31 +0200 | [diff] [blame] | 36 | #include "rtc_base/rate_limiter.h" |
| 37 | #include "test/field_trial.h" |
| 38 | #include "test/gmock.h" |
| 39 | #include "test/gtest.h" |
| 40 | #include "test/mock_transport.h" |
Tommi | 25eb47c | 2019-08-29 16:39:05 +0200 | [diff] [blame] | 41 | #include "test/rtp_header_parser.h" |
asapersson@webrtc.org | 5249cc8 | 2011-12-16 14:31:37 +0000 | [diff] [blame] | 42 | |
| 43 | namespace webrtc { |
| 44 | |
andrew@webrtc.org | 8a44259 | 2011-12-16 21:24:30 +0000 | [diff] [blame] | 45 | namespace { |
Elad Alon | d8d3248 | 2019-02-18 23:45:57 +0100 | [diff] [blame] | 46 | enum : int { // The first valid value is 1. |
| 47 | kAbsoluteSendTimeExtensionId = 1, |
| 48 | kAudioLevelExtensionId, |
Elad Alon | ccb9b75 | 2019-02-19 13:01:31 +0100 | [diff] [blame] | 49 | kGenericDescriptorId00, |
| 50 | kGenericDescriptorId01, |
Elad Alon | d8d3248 | 2019-02-18 23:45:57 +0100 | [diff] [blame] | 51 | kMidExtensionId, |
| 52 | kRepairedRidExtensionId, |
| 53 | kRidExtensionId, |
| 54 | kTransmissionTimeOffsetExtensionId, |
| 55 | kTransportSequenceNumberExtensionId, |
| 56 | kVideoRotationExtensionId, |
| 57 | kVideoTimingExtensionId, |
| 58 | }; |
| 59 | |
andrew@webrtc.org | 8a44259 | 2011-12-16 21:24:30 +0000 | [diff] [blame] | 60 | const int kPayload = 100; |
Shao Changbin | e62202f | 2015-04-21 20:24:50 +0800 | [diff] [blame] | 61 | const int kRtxPayload = 98; |
andrew@webrtc.org | 8a44259 | 2011-12-16 21:24:30 +0000 | [diff] [blame] | 62 | const uint32_t kTimestamp = 10; |
| 63 | const uint16_t kSeqNum = 33; |
brandtr | 9dfff29 | 2016-11-14 05:14:50 -0800 | [diff] [blame] | 64 | const uint32_t kSsrc = 725242; |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 65 | const uint32_t kRtxSsrc = 12345; |
| 66 | const uint32_t kFlexFecSsrc = 45678; |
Erik Språng | 1fbfecd | 2019-08-26 19:00:05 +0200 | [diff] [blame] | 67 | const uint16_t kTransportSequenceNumber = 1; |
sprang@webrtc.org | 6811b6e | 2013-12-13 09:46:59 +0000 | [diff] [blame] | 68 | const uint64_t kStartTime = 123456789; |
pbos@webrtc.org | 2f4b14e | 2014-07-15 15:25:39 +0000 | [diff] [blame] | 69 | const size_t kMaxPaddingSize = 224u; |
Stefan Holmer | a246cfb | 2016-08-23 17:51:42 +0200 | [diff] [blame] | 70 | const uint8_t kPayloadData[] = {47, 11, 32, 93, 89}; |
sprang | a8ae6f2 | 2017-09-04 07:23:56 -0700 | [diff] [blame] | 71 | const int64_t kDefaultExpectedRetransmissionTimeMs = 125; |
Amit Hilbuch | 77938e6 | 2018-12-21 09:23:38 -0800 | [diff] [blame] | 72 | const char kNoRid[] = ""; |
| 73 | const char kNoMid[] = ""; |
andrew@webrtc.org | 8a44259 | 2011-12-16 21:24:30 +0000 | [diff] [blame] | 74 | |
Danil Chapovalov | 5e57b17 | 2016-09-02 19:15:59 +0200 | [diff] [blame] | 75 | using ::testing::_; |
Erik Språng | 30a276b | 2019-04-23 12:00:11 +0200 | [diff] [blame] | 76 | using ::testing::AllOf; |
Erik Språng | ea55b08 | 2019-10-02 14:57:46 +0200 | [diff] [blame] | 77 | using ::testing::Contains; |
Danil Chapovalov | 5e57b17 | 2016-09-02 19:15:59 +0200 | [diff] [blame] | 78 | using ::testing::ElementsAreArray; |
Erik Språng | 30a276b | 2019-04-23 12:00:11 +0200 | [diff] [blame] | 79 | using ::testing::Field; |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 80 | using ::testing::NiceMock; |
Erik Språng | 478cb46 | 2019-06-26 15:49:27 +0200 | [diff] [blame] | 81 | using ::testing::Pointee; |
| 82 | using ::testing::Property; |
Erik Språng | 214f543 | 2019-06-20 15:09:58 +0200 | [diff] [blame] | 83 | using ::testing::Return; |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 84 | using ::testing::StrictMock; |
pwestin@webrtc.org | b0061f9 | 2013-04-27 00:41:08 +0000 | [diff] [blame] | 85 | |
henrik.lundin@webrtc.org | 6e95d7a | 2013-11-15 08:59:19 +0000 | [diff] [blame] | 86 | uint64_t ConvertMsToAbsSendTime(int64_t time_ms) { |
Stefan Holmer | 0a87ffc | 2015-10-21 13:41:48 +0200 | [diff] [blame] | 87 | return (((time_ms << 18) + 500) / 1000) & 0x00ffffff; |
henrik.lundin@webrtc.org | 6e95d7a | 2013-11-15 08:59:19 +0000 | [diff] [blame] | 88 | } |
| 89 | |
asapersson@webrtc.org | 0b3c35a | 2012-01-16 11:06:31 +0000 | [diff] [blame] | 90 | class LoopbackTransportTest : public webrtc::Transport { |
| 91 | public: |
Petter Strandmark | 26bc669 | 2018-05-29 08:43:35 +0200 | [diff] [blame] | 92 | LoopbackTransportTest() : total_bytes_sent_(0) { |
Danil Chapovalov | a74e477 | 2019-09-12 17:53:04 +0200 | [diff] [blame] | 93 | receivers_extensions_.Register<TransmissionOffset>( |
| 94 | kTransmissionTimeOffsetExtensionId); |
| 95 | receivers_extensions_.Register<AbsoluteSendTime>( |
| 96 | kAbsoluteSendTimeExtensionId); |
| 97 | receivers_extensions_.Register<TransportSequenceNumber>( |
| 98 | kTransportSequenceNumberExtensionId); |
| 99 | receivers_extensions_.Register<VideoOrientation>(kVideoRotationExtensionId); |
| 100 | receivers_extensions_.Register<AudioLevel>(kAudioLevelExtensionId); |
| 101 | receivers_extensions_.Register<VideoTimingExtension>( |
| 102 | kVideoTimingExtensionId); |
| 103 | receivers_extensions_.Register<RtpMid>(kMidExtensionId); |
| 104 | receivers_extensions_.Register<RtpGenericFrameDescriptorExtension00>( |
| 105 | kGenericDescriptorId00); |
| 106 | receivers_extensions_.Register<RtpGenericFrameDescriptorExtension01>( |
| 107 | kGenericDescriptorId01); |
| 108 | receivers_extensions_.Register<RtpStreamId>(kRidExtensionId); |
| 109 | receivers_extensions_.Register<RepairedRtpStreamId>( |
| 110 | kRepairedRidExtensionId); |
guoweis@webrtc.org | 4536289 | 2015-03-04 22:55:15 +0000 | [diff] [blame] | 111 | } |
danilchap | 12ba186 | 2016-10-26 02:41:55 -0700 | [diff] [blame] | 112 | |
stefan | 1d8a506 | 2015-10-02 03:39:33 -0700 | [diff] [blame] | 113 | bool SendRtp(const uint8_t* data, |
| 114 | size_t len, |
| 115 | const PacketOptions& options) override { |
Petter Strandmark | 26bc669 | 2018-05-29 08:43:35 +0200 | [diff] [blame] | 116 | last_options_ = options; |
pkasting@chromium.org | 4591fbd | 2014-11-20 22:28:14 +0000 | [diff] [blame] | 117 | total_bytes_sent_ += len; |
danilchap | 12ba186 | 2016-10-26 02:41:55 -0700 | [diff] [blame] | 118 | sent_packets_.push_back(RtpPacketReceived(&receivers_extensions_)); |
| 119 | EXPECT_TRUE(sent_packets_.back().Parse(data, len)); |
pbos | 2d56668 | 2015-09-28 09:59:31 -0700 | [diff] [blame] | 120 | return true; |
asapersson@webrtc.org | 0b3c35a | 2012-01-16 11:06:31 +0000 | [diff] [blame] | 121 | } |
danilchap | 162abd3 | 2015-12-10 02:39:40 -0800 | [diff] [blame] | 122 | bool SendRtcp(const uint8_t* data, size_t len) override { return false; } |
danilchap | 12ba186 | 2016-10-26 02:41:55 -0700 | [diff] [blame] | 123 | const RtpPacketReceived& last_sent_packet() { return sent_packets_.back(); } |
| 124 | int packets_sent() { return sent_packets_.size(); } |
| 125 | |
pbos@webrtc.org | 72491b9 | 2014-07-10 16:24:54 +0000 | [diff] [blame] | 126 | size_t total_bytes_sent_; |
Petter Strandmark | 26bc669 | 2018-05-29 08:43:35 +0200 | [diff] [blame] | 127 | PacketOptions last_options_; |
danilchap | 12ba186 | 2016-10-26 02:41:55 -0700 | [diff] [blame] | 128 | std::vector<RtpPacketReceived> sent_packets_; |
| 129 | |
| 130 | private: |
| 131 | RtpHeaderExtensionMap receivers_extensions_; |
asapersson@webrtc.org | 0b3c35a | 2012-01-16 11:06:31 +0000 | [diff] [blame] | 132 | }; |
| 133 | |
Elad Alon | 4a87e1c | 2017-10-03 16:11:34 +0200 | [diff] [blame] | 134 | MATCHER_P(SameRtcEventTypeAs, value, "") { |
| 135 | return value == arg->GetType(); |
| 136 | } |
| 137 | |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 138 | struct TestConfig { |
Erik Språng | f5815fa | 2019-08-21 14:27:31 +0200 | [diff] [blame] | 139 | explicit TestConfig(bool with_overhead) : with_overhead(with_overhead) {} |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 140 | bool with_overhead = false; |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 141 | }; |
| 142 | |
| 143 | std::string ToFieldTrialString(TestConfig config) { |
| 144 | std::string field_trials; |
| 145 | if (config.with_overhead) { |
| 146 | field_trials += "WebRTC-SendSideBwe-WithOverhead/Enabled/"; |
| 147 | } |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 148 | return field_trials; |
| 149 | } |
| 150 | |
Erik Språng | aa59eca | 2019-07-24 14:52:55 +0200 | [diff] [blame] | 151 | class MockRtpPacketPacer : public RtpPacketSender { |
sprang | ebbf8a8 | 2015-09-21 15:11:14 -0700 | [diff] [blame] | 152 | public: |
Erik Språng | 59b8654 | 2019-06-23 18:24:46 +0200 | [diff] [blame] | 153 | MockRtpPacketPacer() {} |
| 154 | virtual ~MockRtpPacketPacer() {} |
| 155 | |
Erik Språng | ea55b08 | 2019-10-02 14:57:46 +0200 | [diff] [blame] | 156 | MOCK_METHOD1(EnqueuePackets, |
| 157 | void(std::vector<std::unique_ptr<RtpPacketToSend>>)); |
sprang | ebbf8a8 | 2015-09-21 15:11:14 -0700 | [diff] [blame] | 158 | |
Erik Språng | aa59eca | 2019-07-24 14:52:55 +0200 | [diff] [blame] | 159 | MOCK_METHOD2(CreateProbeCluster, void(int bitrate_bps, int cluster_id)); |
| 160 | |
| 161 | MOCK_METHOD0(Pause, void()); |
| 162 | MOCK_METHOD0(Resume, void()); |
| 163 | MOCK_METHOD1(SetCongestionWindow, |
| 164 | void(absl::optional<int64_t> congestion_window_bytes)); |
| 165 | MOCK_METHOD1(UpdateOutstandingData, void(int64_t outstanding_bytes)); |
| 166 | MOCK_METHOD1(SetAccountForAudioPackets, void(bool account_for_audio)); |
sprang | ebbf8a8 | 2015-09-21 15:11:14 -0700 | [diff] [blame] | 167 | }; |
| 168 | |
Johannes Kron | 4a8a5e7 | 2018-09-26 09:57:48 +0200 | [diff] [blame] | 169 | class MockSendSideDelayObserver : public SendSideDelayObserver { |
| 170 | public: |
Henrik Boström | 9fe1834 | 2019-05-16 18:38:20 +0200 | [diff] [blame] | 171 | MOCK_METHOD4(SendSideDelayUpdated, void(int, int, uint64_t, uint32_t)); |
Johannes Kron | 4a8a5e7 | 2018-09-26 09:57:48 +0200 | [diff] [blame] | 172 | }; |
| 173 | |
asapersson | 35151f3 | 2016-05-02 23:44:01 -0700 | [diff] [blame] | 174 | class MockSendPacketObserver : public SendPacketObserver { |
| 175 | public: |
| 176 | MOCK_METHOD3(OnSendPacket, void(uint16_t, int64_t, uint32_t)); |
| 177 | }; |
| 178 | |
Stefan Holmer | a246cfb | 2016-08-23 17:51:42 +0200 | [diff] [blame] | 179 | class MockTransportFeedbackObserver : public TransportFeedbackObserver { |
| 180 | public: |
Erik Språng | 30a276b | 2019-04-23 12:00:11 +0200 | [diff] [blame] | 181 | MOCK_METHOD1(OnAddPacket, void(const RtpPacketSendInfo&)); |
Stefan Holmer | a246cfb | 2016-08-23 17:51:42 +0200 | [diff] [blame] | 182 | MOCK_METHOD1(OnTransportFeedback, void(const rtcp::TransportFeedback&)); |
elad.alon | f949000 | 2017-03-06 05:32:21 -0800 | [diff] [blame] | 183 | MOCK_CONST_METHOD0(GetTransportFeedbackVector, std::vector<PacketFeedback>()); |
Stefan Holmer | a246cfb | 2016-08-23 17:51:42 +0200 | [diff] [blame] | 184 | }; |
| 185 | |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 186 | class MockOverheadObserver : public OverheadObserver { |
| 187 | public: |
| 188 | MOCK_METHOD1(OnOverheadChanged, void(size_t overhead_bytes_per_packet)); |
| 189 | }; |
| 190 | |
Erik Språng | 7ea9b80 | 2019-10-16 19:03:38 +0200 | [diff] [blame] | 191 | class StreamDataTestCallback : public StreamDataCountersCallback { |
| 192 | public: |
| 193 | StreamDataTestCallback() |
| 194 | : StreamDataCountersCallback(), ssrc_(0), counters_() {} |
| 195 | ~StreamDataTestCallback() override = default; |
| 196 | |
| 197 | void DataCountersUpdated(const StreamDataCounters& counters, |
| 198 | uint32_t ssrc) override { |
| 199 | ssrc_ = ssrc; |
| 200 | counters_ = counters; |
| 201 | } |
| 202 | |
| 203 | uint32_t ssrc_; |
| 204 | StreamDataCounters counters_; |
| 205 | |
| 206 | void MatchPacketCounter(const RtpPacketCounter& expected, |
| 207 | const RtpPacketCounter& actual) { |
| 208 | EXPECT_EQ(expected.payload_bytes, actual.payload_bytes); |
| 209 | EXPECT_EQ(expected.header_bytes, actual.header_bytes); |
| 210 | EXPECT_EQ(expected.padding_bytes, actual.padding_bytes); |
| 211 | EXPECT_EQ(expected.packets, actual.packets); |
| 212 | } |
| 213 | |
| 214 | void Matches(uint32_t ssrc, const StreamDataCounters& counters) { |
| 215 | EXPECT_EQ(ssrc, ssrc_); |
| 216 | MatchPacketCounter(counters.transmitted, counters_.transmitted); |
| 217 | MatchPacketCounter(counters.retransmitted, counters_.retransmitted); |
| 218 | EXPECT_EQ(counters.fec.packets, counters_.fec.packets); |
| 219 | } |
| 220 | }; |
| 221 | |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 222 | // Mimics ModuleRtpRtcp::RtpSenderContext. |
| 223 | // TODO(sprang): Split up unit tests and test these components individually |
| 224 | // wherever possible. |
| 225 | struct RtpSenderContext { |
| 226 | explicit RtpSenderContext(const RtpRtcp::Configuration& config) |
| 227 | : packet_history_(config.clock), |
| 228 | packet_sender_(config, &packet_history_), |
| 229 | non_paced_sender_(&packet_sender_), |
| 230 | packet_generator_( |
| 231 | config, |
| 232 | &packet_history_, |
| 233 | config.paced_sender ? config.paced_sender : &non_paced_sender_) {} |
| 234 | RtpPacketHistory packet_history_; |
| 235 | RtpSenderEgress packet_sender_; |
| 236 | RtpSenderEgress::NonPacedPacketSender non_paced_sender_; |
| 237 | RTPSender packet_generator_; |
| 238 | }; |
| 239 | |
| 240 | } // namespace |
| 241 | |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 242 | class RtpSenderTest : public ::testing::TestWithParam<TestConfig> { |
asapersson@webrtc.org | 5249cc8 | 2011-12-16 14:31:37 +0000 | [diff] [blame] | 243 | protected: |
| 244 | RtpSenderTest() |
sprang@webrtc.org | 6811b6e | 2013-12-13 09:46:59 +0000 | [diff] [blame] | 245 | : fake_clock_(kStartTime), |
sprang | cd349d9 | 2016-07-13 09:11:28 -0700 | [diff] [blame] | 246 | retransmission_rate_limiter_(&fake_clock_, 1000), |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 247 | flexfec_sender_(0, |
| 248 | kFlexFecSsrc, |
| 249 | kSsrc, |
| 250 | "", |
| 251 | std::vector<RtpExtension>(), |
| 252 | std::vector<RtpExtensionSize>(), |
| 253 | nullptr, |
| 254 | &fake_clock_), |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 255 | kMarkerBit(true), |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 256 | field_trials_(ToFieldTrialString(GetParam())) {} |
solenberg@webrtc.org | c0352d5 | 2013-05-20 20:55:07 +0000 | [diff] [blame] | 257 | |
Erik Språng | 7b52f10 | 2018-02-07 14:37:37 +0100 | [diff] [blame] | 258 | void SetUp() override { SetUpRtpSender(true, false); } |
Peter Boström | e23e737 | 2015-10-08 11:44:14 +0200 | [diff] [blame] | 259 | |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 260 | RTPSender* rtp_sender() { |
| 261 | RTC_DCHECK(rtp_sender_context_); |
| 262 | return &rtp_sender_context_->packet_generator_; |
| 263 | } |
| 264 | |
| 265 | RtpSenderEgress* rtp_egress() { |
| 266 | RTC_DCHECK(rtp_sender_context_); |
| 267 | return &rtp_sender_context_->packet_sender_; |
| 268 | } |
| 269 | |
Erik Språng | 7b52f10 | 2018-02-07 14:37:37 +0100 | [diff] [blame] | 270 | void SetUpRtpSender(bool pacer, bool populate_network2) { |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 271 | RtpRtcp::Configuration config; |
| 272 | config.clock = &fake_clock_; |
| 273 | config.outgoing_transport = &transport_; |
Erik Språng | 54d5d2c | 2019-08-20 17:22:36 +0200 | [diff] [blame] | 274 | config.local_media_ssrc = kSsrc; |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 275 | config.rtx_send_ssrc = kRtxSsrc; |
| 276 | config.flexfec_sender = &flexfec_sender_; |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 277 | config.event_log = &mock_rtc_event_log_; |
| 278 | config.send_packet_observer = &send_packet_observer_; |
| 279 | config.retransmission_rate_limiter = &retransmission_rate_limiter_; |
| 280 | config.paced_sender = pacer ? &mock_paced_sender_ : nullptr; |
| 281 | config.populate_network2_timestamp = populate_network2; |
Erik Språng | 7ea9b80 | 2019-10-16 19:03:38 +0200 | [diff] [blame] | 282 | config.rtp_stats_callback = &rtp_stats_callback_; |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 283 | rtp_sender_context_ = std::make_unique<RtpSenderContext>(config); |
| 284 | rtp_sender()->SetSequenceNumber(kSeqNum); |
| 285 | rtp_sender()->SetTimestampOffset(0); |
solenberg@webrtc.org | c0352d5 | 2013-05-20 20:55:07 +0000 | [diff] [blame] | 286 | } |
| 287 | |
stefan@webrtc.org | a678a3b | 2013-01-21 07:42:11 +0000 | [diff] [blame] | 288 | SimulatedClock fake_clock_; |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 289 | NiceMock<MockRtcEventLog> mock_rtc_event_log_; |
Erik Språng | 59b8654 | 2019-06-23 18:24:46 +0200 | [diff] [blame] | 290 | MockRtpPacketPacer mock_paced_sender_; |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 291 | StrictMock<MockSendPacketObserver> send_packet_observer_; |
| 292 | StrictMock<MockTransportFeedbackObserver> feedback_observer_; |
sprang | cd349d9 | 2016-07-13 09:11:28 -0700 | [diff] [blame] | 293 | RateLimiter retransmission_rate_limiter_; |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 294 | FlexfecSender flexfec_sender_; |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 295 | |
| 296 | std::unique_ptr<RtpSenderContext> rtp_sender_context_; |
| 297 | |
asapersson@webrtc.org | 0b3c35a | 2012-01-16 11:06:31 +0000 | [diff] [blame] | 298 | LoopbackTransportTest transport_; |
asapersson@webrtc.org | 5249cc8 | 2011-12-16 14:31:37 +0000 | [diff] [blame] | 299 | const bool kMarkerBit; |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 300 | test::ScopedFieldTrials field_trials_; |
Erik Språng | 7ea9b80 | 2019-10-16 19:03:38 +0200 | [diff] [blame] | 301 | StreamDataTestCallback rtp_stats_callback_; |
asapersson@webrtc.org | 5249cc8 | 2011-12-16 14:31:37 +0000 | [diff] [blame] | 302 | |
danilchap | b6f1fb5 | 2016-10-19 06:11:39 -0700 | [diff] [blame] | 303 | std::unique_ptr<RtpPacketToSend> BuildRtpPacket(int payload_type, |
| 304 | bool marker_bit, |
| 305 | uint32_t timestamp, |
| 306 | int64_t capture_time_ms) { |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 307 | auto packet = rtp_sender()->AllocatePacket(); |
danilchap | b6f1fb5 | 2016-10-19 06:11:39 -0700 | [diff] [blame] | 308 | packet->SetPayloadType(payload_type); |
Erik Språng | 60ffc31 | 2019-07-30 22:03:49 +0200 | [diff] [blame] | 309 | packet->set_packet_type(RtpPacketToSend::Type::kVideo); |
danilchap | b6f1fb5 | 2016-10-19 06:11:39 -0700 | [diff] [blame] | 310 | packet->SetMarker(marker_bit); |
| 311 | packet->SetTimestamp(timestamp); |
| 312 | packet->set_capture_time_ms(capture_time_ms); |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 313 | EXPECT_TRUE(rtp_sender()->AssignSequenceNumber(packet.get())); |
danilchap | b6f1fb5 | 2016-10-19 06:11:39 -0700 | [diff] [blame] | 314 | return packet; |
| 315 | } |
| 316 | |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 317 | std::unique_ptr<RtpPacketToSend> SendPacket(int64_t capture_time_ms, |
| 318 | int payload_length) { |
stefan@webrtc.org | 7e9315b | 2013-12-04 10:24:26 +0000 | [diff] [blame] | 319 | uint32_t timestamp = capture_time_ms * 90; |
danilchap | b6f1fb5 | 2016-10-19 06:11:39 -0700 | [diff] [blame] | 320 | auto packet = |
| 321 | BuildRtpPacket(kPayload, kMarkerBit, timestamp, capture_time_ms); |
| 322 | packet->AllocatePayload(payload_length); |
Erik Språng | 70768f4 | 2019-08-27 18:16:26 +0200 | [diff] [blame] | 323 | packet->set_allow_retransmission(true); |
stefan@webrtc.org | 7e9315b | 2013-12-04 10:24:26 +0000 | [diff] [blame] | 324 | |
| 325 | // Packet should be stored in a send bucket. |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 326 | EXPECT_TRUE(rtp_sender()->SendToNetwork( |
| 327 | std::make_unique<RtpPacketToSend>(*packet))); |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 328 | return packet; |
stefan@webrtc.org | 7e9315b | 2013-12-04 10:24:26 +0000 | [diff] [blame] | 329 | } |
asapersson | 35151f3 | 2016-05-02 23:44:01 -0700 | [diff] [blame] | 330 | |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 331 | std::unique_ptr<RtpPacketToSend> SendGenericPacket() { |
asapersson | 35151f3 | 2016-05-02 23:44:01 -0700 | [diff] [blame] | 332 | const int64_t kCaptureTimeMs = fake_clock_.TimeInMilliseconds(); |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 333 | return SendPacket(kCaptureTimeMs, sizeof(kPayloadData)); |
asapersson | 35151f3 | 2016-05-02 23:44:01 -0700 | [diff] [blame] | 334 | } |
Steve Anton | 2bac7da | 2019-07-21 15:04:21 -0400 | [diff] [blame] | 335 | |
Erik Språng | 4208a13 | 2019-08-26 08:58:45 +0200 | [diff] [blame] | 336 | size_t GenerateAndSendPadding(size_t target_size_bytes) { |
| 337 | size_t generated_bytes = 0; |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 338 | for (auto& packet : |
| 339 | rtp_sender()->GeneratePadding(target_size_bytes, true)) { |
Erik Språng | 4208a13 | 2019-08-26 08:58:45 +0200 | [diff] [blame] | 340 | generated_bytes += packet->payload_size() + packet->padding_size(); |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 341 | rtp_egress()->SendPacket(packet.get(), PacedPacketInfo()); |
Erik Språng | 4208a13 | 2019-08-26 08:58:45 +0200 | [diff] [blame] | 342 | } |
| 343 | return generated_bytes; |
| 344 | } |
| 345 | |
Steve Anton | 2bac7da | 2019-07-21 15:04:21 -0400 | [diff] [blame] | 346 | // The following are helpers for configuring the RTPSender. They must be |
| 347 | // called before sending any packets. |
| 348 | |
| 349 | // Enable the retransmission stream with sizable packet storage. |
| 350 | void EnableRtx() { |
| 351 | // RTX needs to be able to read the source packets from the packet store. |
| 352 | // Pick a number of packets to store big enough for any unit test. |
| 353 | constexpr uint16_t kNumberOfPacketsToStore = 100; |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 354 | rtp_sender_context_->packet_history_.SetStorePacketsStatus( |
| 355 | RtpPacketHistory::StorageMode::kStoreAndCull, kNumberOfPacketsToStore); |
| 356 | rtp_sender()->SetRtxPayloadType(kRtxPayload, kPayload); |
| 357 | rtp_sender()->SetRtxStatus(kRtxRetransmitted | kRtxRedundantPayloads); |
Steve Anton | 2bac7da | 2019-07-21 15:04:21 -0400 | [diff] [blame] | 358 | } |
| 359 | |
| 360 | // Enable sending of the MID header extension for both the primary SSRC and |
| 361 | // the RTX SSRC. |
| 362 | void EnableMidSending(const std::string& mid) { |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 363 | rtp_sender()->RegisterRtpHeaderExtension(kRtpExtensionMid, kMidExtensionId); |
| 364 | rtp_sender()->SetMid(mid); |
Steve Anton | 2bac7da | 2019-07-21 15:04:21 -0400 | [diff] [blame] | 365 | } |
| 366 | |
| 367 | // Enable sending of the RSID header extension for the primary SSRC and the |
| 368 | // RRSID header extension for the RTX SSRC. |
| 369 | void EnableRidSending(const std::string& rid) { |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 370 | rtp_sender()->RegisterRtpHeaderExtension(kRtpExtensionRtpStreamId, |
| 371 | kRidExtensionId); |
| 372 | rtp_sender()->RegisterRtpHeaderExtension(kRtpExtensionRepairedRtpStreamId, |
| 373 | kRepairedRidExtensionId); |
| 374 | rtp_sender()->SetRid(rid); |
Steve Anton | 2bac7da | 2019-07-21 15:04:21 -0400 | [diff] [blame] | 375 | } |
asapersson@webrtc.org | 5249cc8 | 2011-12-16 14:31:37 +0000 | [diff] [blame] | 376 | }; |
| 377 | |
Peter Boström | e23e737 | 2015-10-08 11:44:14 +0200 | [diff] [blame] | 378 | // TODO(pbos): Move tests over from WithoutPacer to RtpSenderTest as this is our |
| 379 | // default code path. |
| 380 | class RtpSenderTestWithoutPacer : public RtpSenderTest { |
| 381 | public: |
Erik Språng | 7b52f10 | 2018-02-07 14:37:37 +0100 | [diff] [blame] | 382 | void SetUp() override { SetUpRtpSender(false, false); } |
Peter Boström | e23e737 | 2015-10-08 11:44:14 +0200 | [diff] [blame] | 383 | }; |
| 384 | |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 385 | TEST_P(RtpSenderTestWithoutPacer, AllocatePacketSetCsrc) { |
Danil Chapovalov | 5e57b17 | 2016-09-02 19:15:59 +0200 | [diff] [blame] | 386 | // Configure rtp_sender with csrc. |
| 387 | std::vector<uint32_t> csrcs; |
| 388 | csrcs.push_back(0x23456789); |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 389 | rtp_sender()->SetCsrcs(csrcs); |
Danil Chapovalov | 5e57b17 | 2016-09-02 19:15:59 +0200 | [diff] [blame] | 390 | |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 391 | auto packet = rtp_sender()->AllocatePacket(); |
Danil Chapovalov | 5e57b17 | 2016-09-02 19:15:59 +0200 | [diff] [blame] | 392 | |
| 393 | ASSERT_TRUE(packet); |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 394 | EXPECT_EQ(rtp_sender()->SSRC(), packet->Ssrc()); |
Danil Chapovalov | 5e57b17 | 2016-09-02 19:15:59 +0200 | [diff] [blame] | 395 | EXPECT_EQ(csrcs, packet->Csrcs()); |
| 396 | } |
| 397 | |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 398 | TEST_P(RtpSenderTestWithoutPacer, AllocatePacketReserveExtensions) { |
Danil Chapovalov | 5e57b17 | 2016-09-02 19:15:59 +0200 | [diff] [blame] | 399 | // Configure rtp_sender with extensions. |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 400 | ASSERT_EQ(0, rtp_sender()->RegisterRtpHeaderExtension( |
Danil Chapovalov | 5e57b17 | 2016-09-02 19:15:59 +0200 | [diff] [blame] | 401 | kRtpExtensionTransmissionTimeOffset, |
| 402 | kTransmissionTimeOffsetExtensionId)); |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 403 | ASSERT_EQ(0, |
| 404 | rtp_sender()->RegisterRtpHeaderExtension( |
| 405 | kRtpExtensionAbsoluteSendTime, kAbsoluteSendTimeExtensionId)); |
| 406 | ASSERT_EQ(0, rtp_sender()->RegisterRtpHeaderExtension( |
| 407 | kRtpExtensionAudioLevel, kAudioLevelExtensionId)); |
| 408 | ASSERT_EQ(0, rtp_sender()->RegisterRtpHeaderExtension( |
Danil Chapovalov | 5e57b17 | 2016-09-02 19:15:59 +0200 | [diff] [blame] | 409 | kRtpExtensionTransportSequenceNumber, |
| 410 | kTransportSequenceNumberExtensionId)); |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 411 | ASSERT_EQ(0, rtp_sender()->RegisterRtpHeaderExtension( |
Danil Chapovalov | 5e57b17 | 2016-09-02 19:15:59 +0200 | [diff] [blame] | 412 | kRtpExtensionVideoRotation, kVideoRotationExtensionId)); |
| 413 | |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 414 | auto packet = rtp_sender()->AllocatePacket(); |
Danil Chapovalov | 5e57b17 | 2016-09-02 19:15:59 +0200 | [diff] [blame] | 415 | |
| 416 | ASSERT_TRUE(packet); |
| 417 | // Preallocate BWE extensions RtpSender set itself. |
| 418 | EXPECT_TRUE(packet->HasExtension<TransmissionOffset>()); |
| 419 | EXPECT_TRUE(packet->HasExtension<AbsoluteSendTime>()); |
| 420 | EXPECT_TRUE(packet->HasExtension<TransportSequenceNumber>()); |
| 421 | // Do not allocate media specific extensions. |
| 422 | EXPECT_FALSE(packet->HasExtension<AudioLevel>()); |
| 423 | EXPECT_FALSE(packet->HasExtension<VideoOrientation>()); |
| 424 | } |
| 425 | |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 426 | TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberAdvanceSequenceNumber) { |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 427 | auto packet = rtp_sender()->AllocatePacket(); |
Danil Chapovalov | 5e57b17 | 2016-09-02 19:15:59 +0200 | [diff] [blame] | 428 | ASSERT_TRUE(packet); |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 429 | const uint16_t sequence_number = rtp_sender()->SequenceNumber(); |
Danil Chapovalov | 5e57b17 | 2016-09-02 19:15:59 +0200 | [diff] [blame] | 430 | |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 431 | EXPECT_TRUE(rtp_sender()->AssignSequenceNumber(packet.get())); |
Danil Chapovalov | 5e57b17 | 2016-09-02 19:15:59 +0200 | [diff] [blame] | 432 | |
| 433 | EXPECT_EQ(sequence_number, packet->SequenceNumber()); |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 434 | EXPECT_EQ(sequence_number + 1, rtp_sender()->SequenceNumber()); |
Danil Chapovalov | 5e57b17 | 2016-09-02 19:15:59 +0200 | [diff] [blame] | 435 | } |
| 436 | |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 437 | TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberFailsOnNotSending) { |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 438 | auto packet = rtp_sender()->AllocatePacket(); |
Danil Chapovalov | 5e57b17 | 2016-09-02 19:15:59 +0200 | [diff] [blame] | 439 | ASSERT_TRUE(packet); |
| 440 | |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 441 | rtp_sender()->SetSendingMediaStatus(false); |
| 442 | EXPECT_FALSE(rtp_sender()->AssignSequenceNumber(packet.get())); |
Danil Chapovalov | 5e57b17 | 2016-09-02 19:15:59 +0200 | [diff] [blame] | 443 | } |
| 444 | |
Danil Chapovalov | b3179c7 | 2018-03-22 10:13:07 +0100 | [diff] [blame] | 445 | TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberMayAllowPaddingOnVideo) { |
Danil Chapovalov | 5e57b17 | 2016-09-02 19:15:59 +0200 | [diff] [blame] | 446 | constexpr size_t kPaddingSize = 100; |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 447 | auto packet = rtp_sender()->AllocatePacket(); |
Danil Chapovalov | 5e57b17 | 2016-09-02 19:15:59 +0200 | [diff] [blame] | 448 | ASSERT_TRUE(packet); |
| 449 | |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 450 | ASSERT_TRUE(rtp_sender()->GeneratePadding(kPaddingSize, true).empty()); |
Danil Chapovalov | 5e57b17 | 2016-09-02 19:15:59 +0200 | [diff] [blame] | 451 | packet->SetMarker(false); |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 452 | ASSERT_TRUE(rtp_sender()->AssignSequenceNumber(packet.get())); |
Danil Chapovalov | b3179c7 | 2018-03-22 10:13:07 +0100 | [diff] [blame] | 453 | // Packet without marker bit doesn't allow padding on video stream. |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 454 | ASSERT_TRUE(rtp_sender()->GeneratePadding(kPaddingSize, true).empty()); |
Danil Chapovalov | 5e57b17 | 2016-09-02 19:15:59 +0200 | [diff] [blame] | 455 | |
| 456 | packet->SetMarker(true); |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 457 | ASSERT_TRUE(rtp_sender()->AssignSequenceNumber(packet.get())); |
Danil Chapovalov | 5e57b17 | 2016-09-02 19:15:59 +0200 | [diff] [blame] | 458 | // Packet with marker bit allows send padding. |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 459 | ASSERT_FALSE(rtp_sender()->GeneratePadding(kPaddingSize, true).empty()); |
Danil Chapovalov | 5e57b17 | 2016-09-02 19:15:59 +0200 | [diff] [blame] | 460 | } |
| 461 | |
Danil Chapovalov | b3179c7 | 2018-03-22 10:13:07 +0100 | [diff] [blame] | 462 | TEST_P(RtpSenderTest, AssignSequenceNumberAllowsPaddingOnAudio) { |
| 463 | MockTransport transport; |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 464 | RtpRtcp::Configuration config; |
| 465 | config.audio = true; |
| 466 | config.clock = &fake_clock_; |
| 467 | config.outgoing_transport = &transport; |
| 468 | config.paced_sender = &mock_paced_sender_; |
Erik Språng | 54d5d2c | 2019-08-20 17:22:36 +0200 | [diff] [blame] | 469 | config.local_media_ssrc = kSsrc; |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 470 | config.event_log = &mock_rtc_event_log_; |
| 471 | config.retransmission_rate_limiter = &retransmission_rate_limiter_; |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 472 | rtp_sender_context_ = std::make_unique<RtpSenderContext>(config); |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 473 | |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 474 | rtp_sender()->SetTimestampOffset(0); |
Danil Chapovalov | b3179c7 | 2018-03-22 10:13:07 +0100 | [diff] [blame] | 475 | |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 476 | std::unique_ptr<RtpPacketToSend> audio_packet = |
| 477 | rtp_sender()->AllocatePacket(); |
Danil Chapovalov | b3179c7 | 2018-03-22 10:13:07 +0100 | [diff] [blame] | 478 | // Padding on audio stream allowed regardless of marker in the last packet. |
| 479 | audio_packet->SetMarker(false); |
| 480 | audio_packet->SetPayloadType(kPayload); |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 481 | rtp_sender()->AssignSequenceNumber(audio_packet.get()); |
Danil Chapovalov | b3179c7 | 2018-03-22 10:13:07 +0100 | [diff] [blame] | 482 | |
| 483 | const size_t kPaddingSize = 59; |
| 484 | EXPECT_CALL(transport, SendRtp(_, kPaddingSize + kRtpHeaderSize, _)) |
Erik Språng | 214f543 | 2019-06-20 15:09:58 +0200 | [diff] [blame] | 485 | .WillOnce(Return(true)); |
Erik Språng | 4208a13 | 2019-08-26 08:58:45 +0200 | [diff] [blame] | 486 | EXPECT_EQ(kPaddingSize, GenerateAndSendPadding(kPaddingSize)); |
Danil Chapovalov | b3179c7 | 2018-03-22 10:13:07 +0100 | [diff] [blame] | 487 | |
| 488 | // Requested padding size is too small, will send a larger one. |
| 489 | const size_t kMinPaddingSize = 50; |
| 490 | EXPECT_CALL(transport, SendRtp(_, kMinPaddingSize + kRtpHeaderSize, _)) |
Erik Språng | 214f543 | 2019-06-20 15:09:58 +0200 | [diff] [blame] | 491 | .WillOnce(Return(true)); |
Erik Språng | 4208a13 | 2019-08-26 08:58:45 +0200 | [diff] [blame] | 492 | EXPECT_EQ(kMinPaddingSize, GenerateAndSendPadding(kMinPaddingSize - 5)); |
Danil Chapovalov | b3179c7 | 2018-03-22 10:13:07 +0100 | [diff] [blame] | 493 | } |
| 494 | |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 495 | TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberSetPaddingTimestamps) { |
Danil Chapovalov | 5e57b17 | 2016-09-02 19:15:59 +0200 | [diff] [blame] | 496 | constexpr size_t kPaddingSize = 100; |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 497 | auto packet = rtp_sender()->AllocatePacket(); |
Danil Chapovalov | 5e57b17 | 2016-09-02 19:15:59 +0200 | [diff] [blame] | 498 | ASSERT_TRUE(packet); |
| 499 | packet->SetMarker(true); |
| 500 | packet->SetTimestamp(kTimestamp); |
| 501 | |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 502 | ASSERT_TRUE(rtp_sender()->AssignSequenceNumber(packet.get())); |
| 503 | auto padding_packets = rtp_sender()->GeneratePadding(kPaddingSize, true); |
Danil Chapovalov | 5e57b17 | 2016-09-02 19:15:59 +0200 | [diff] [blame] | 504 | |
Erik Språng | 4208a13 | 2019-08-26 08:58:45 +0200 | [diff] [blame] | 505 | ASSERT_EQ(1u, padding_packets.size()); |
danilchap | 12ba186 | 2016-10-26 02:41:55 -0700 | [diff] [blame] | 506 | // Verify padding packet timestamp. |
Erik Språng | 4208a13 | 2019-08-26 08:58:45 +0200 | [diff] [blame] | 507 | EXPECT_EQ(kTimestamp, padding_packets[0]->Timestamp()); |
Danil Chapovalov | 5e57b17 | 2016-09-02 19:15:59 +0200 | [diff] [blame] | 508 | } |
| 509 | |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 510 | TEST_P(RtpSenderTestWithoutPacer, |
| 511 | TransportFeedbackObserverGetsCorrectByteCount) { |
| 512 | constexpr int kRtpOverheadBytesPerPacket = 12 + 8; |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 513 | NiceMock<MockOverheadObserver> mock_overhead_observer; |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 514 | |
| 515 | RtpRtcp::Configuration config; |
| 516 | config.clock = &fake_clock_; |
| 517 | config.outgoing_transport = &transport_; |
Erik Språng | 54d5d2c | 2019-08-20 17:22:36 +0200 | [diff] [blame] | 518 | config.local_media_ssrc = kSsrc; |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 519 | config.transport_feedback_callback = &feedback_observer_; |
| 520 | config.event_log = &mock_rtc_event_log_; |
| 521 | config.retransmission_rate_limiter = &retransmission_rate_limiter_; |
| 522 | config.overhead_observer = &mock_overhead_observer; |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 523 | rtp_sender_context_ = std::make_unique<RtpSenderContext>(config); |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 524 | |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 525 | EXPECT_EQ(0, rtp_sender()->RegisterRtpHeaderExtension( |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 526 | kRtpExtensionTransportSequenceNumber, |
| 527 | kTransportSequenceNumberExtensionId)); |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 528 | |
| 529 | const size_t expected_bytes = |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 530 | GetParam().with_overhead |
| 531 | ? sizeof(kPayloadData) + kRtpOverheadBytesPerPacket |
| 532 | : sizeof(kPayloadData); |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 533 | |
| 534 | EXPECT_CALL(feedback_observer_, |
Erik Språng | 30a276b | 2019-04-23 12:00:11 +0200 | [diff] [blame] | 535 | OnAddPacket(AllOf( |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 536 | Field(&RtpPacketSendInfo::ssrc, rtp_sender()->SSRC()), |
Erik Språng | 30a276b | 2019-04-23 12:00:11 +0200 | [diff] [blame] | 537 | Field(&RtpPacketSendInfo::transport_sequence_number, |
| 538 | kTransportSequenceNumber), |
| 539 | Field(&RtpPacketSendInfo::rtp_sequence_number, |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 540 | rtp_sender()->SequenceNumber()), |
Erik Språng | 30a276b | 2019-04-23 12:00:11 +0200 | [diff] [blame] | 541 | Field(&RtpPacketSendInfo::length, expected_bytes), |
| 542 | Field(&RtpPacketSendInfo::pacing_info, PacedPacketInfo())))) |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 543 | .Times(1); |
| 544 | EXPECT_CALL(mock_overhead_observer, |
| 545 | OnOverheadChanged(kRtpOverheadBytesPerPacket)) |
| 546 | .Times(1); |
Niels Möller | e7b9e6b | 2019-02-06 18:23:44 +0100 | [diff] [blame] | 547 | SendGenericPacket(); |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 548 | } |
| 549 | |
| 550 | TEST_P(RtpSenderTestWithoutPacer, SendsPacketsWithTransportSequenceNumber) { |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 551 | RtpRtcp::Configuration config; |
| 552 | config.clock = &fake_clock_; |
| 553 | config.outgoing_transport = &transport_; |
Erik Språng | 54d5d2c | 2019-08-20 17:22:36 +0200 | [diff] [blame] | 554 | config.local_media_ssrc = kSsrc; |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 555 | config.transport_feedback_callback = &feedback_observer_; |
| 556 | config.event_log = &mock_rtc_event_log_; |
| 557 | config.send_packet_observer = &send_packet_observer_; |
| 558 | config.retransmission_rate_limiter = &retransmission_rate_limiter_; |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 559 | rtp_sender_context_ = std::make_unique<RtpSenderContext>(config); |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 560 | |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 561 | EXPECT_EQ(0, rtp_sender()->RegisterRtpHeaderExtension( |
Stefan Holmer | f5dca48 | 2016-01-27 12:58:51 +0100 | [diff] [blame] | 562 | kRtpExtensionTransportSequenceNumber, |
| 563 | kTransportSequenceNumberExtensionId)); |
| 564 | |
asapersson | 35151f3 | 2016-05-02 23:44:01 -0700 | [diff] [blame] | 565 | EXPECT_CALL(send_packet_observer_, |
| 566 | OnSendPacket(kTransportSequenceNumber, _, _)) |
| 567 | .Times(1); |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 568 | |
| 569 | EXPECT_CALL(feedback_observer_, |
Erik Språng | 30a276b | 2019-04-23 12:00:11 +0200 | [diff] [blame] | 570 | OnAddPacket(AllOf( |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 571 | Field(&RtpPacketSendInfo::ssrc, rtp_sender()->SSRC()), |
Erik Språng | 30a276b | 2019-04-23 12:00:11 +0200 | [diff] [blame] | 572 | Field(&RtpPacketSendInfo::transport_sequence_number, |
| 573 | kTransportSequenceNumber), |
| 574 | Field(&RtpPacketSendInfo::rtp_sequence_number, |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 575 | rtp_sender()->SequenceNumber()), |
Erik Språng | 30a276b | 2019-04-23 12:00:11 +0200 | [diff] [blame] | 576 | Field(&RtpPacketSendInfo::pacing_info, PacedPacketInfo())))) |
Stefan Holmer | a246cfb | 2016-08-23 17:51:42 +0200 | [diff] [blame] | 577 | .Times(1); |
asapersson | 35151f3 | 2016-05-02 23:44:01 -0700 | [diff] [blame] | 578 | |
Niels Möller | e7b9e6b | 2019-02-06 18:23:44 +0100 | [diff] [blame] | 579 | SendGenericPacket(); |
Stefan Holmer | f5dca48 | 2016-01-27 12:58:51 +0100 | [diff] [blame] | 580 | |
danilchap | 12ba186 | 2016-10-26 02:41:55 -0700 | [diff] [blame] | 581 | const auto& packet = transport_.last_sent_packet(); |
| 582 | uint16_t transport_seq_no; |
| 583 | ASSERT_TRUE(packet.GetExtension<TransportSequenceNumber>(&transport_seq_no)); |
| 584 | EXPECT_EQ(kTransportSequenceNumber, transport_seq_no); |
Petter Strandmark | 26bc669 | 2018-05-29 08:43:35 +0200 | [diff] [blame] | 585 | EXPECT_EQ(transport_.last_options_.packet_id, transport_seq_no); |
Sebastian Jansson | 1bca65b | 2018-10-10 09:58:08 +0200 | [diff] [blame] | 586 | EXPECT_TRUE(transport_.last_options_.included_in_allocation); |
Petter Strandmark | 26bc669 | 2018-05-29 08:43:35 +0200 | [diff] [blame] | 587 | } |
| 588 | |
| 589 | TEST_P(RtpSenderTestWithoutPacer, PacketOptionsNoRetransmission) { |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 590 | RtpRtcp::Configuration config; |
| 591 | config.clock = &fake_clock_; |
| 592 | config.outgoing_transport = &transport_; |
Erik Språng | 54d5d2c | 2019-08-20 17:22:36 +0200 | [diff] [blame] | 593 | config.local_media_ssrc = kSsrc; |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 594 | config.transport_feedback_callback = &feedback_observer_; |
| 595 | config.event_log = &mock_rtc_event_log_; |
| 596 | config.send_packet_observer = &send_packet_observer_; |
| 597 | config.retransmission_rate_limiter = &retransmission_rate_limiter_; |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 598 | rtp_sender_context_ = std::make_unique<RtpSenderContext>(config); |
Petter Strandmark | 26bc669 | 2018-05-29 08:43:35 +0200 | [diff] [blame] | 599 | |
Niels Möller | e7b9e6b | 2019-02-06 18:23:44 +0100 | [diff] [blame] | 600 | SendGenericPacket(); |
Petter Strandmark | 26bc669 | 2018-05-29 08:43:35 +0200 | [diff] [blame] | 601 | |
| 602 | EXPECT_FALSE(transport_.last_options_.is_retransmit); |
Stefan Holmer | f5dca48 | 2016-01-27 12:58:51 +0100 | [diff] [blame] | 603 | } |
| 604 | |
Sebastian Jansson | 1bca65b | 2018-10-10 09:58:08 +0200 | [diff] [blame] | 605 | TEST_P(RtpSenderTestWithoutPacer, |
| 606 | SetsIncludedInFeedbackWhenTransportSequenceNumberExtensionIsRegistered) { |
| 607 | SetUpRtpSender(false, false); |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 608 | rtp_sender()->RegisterRtpHeaderExtension(kRtpExtensionTransportSequenceNumber, |
| 609 | kTransportSequenceNumberExtensionId); |
Sebastian Jansson | 1bca65b | 2018-10-10 09:58:08 +0200 | [diff] [blame] | 610 | EXPECT_CALL(send_packet_observer_, OnSendPacket).Times(1); |
Niels Möller | e7b9e6b | 2019-02-06 18:23:44 +0100 | [diff] [blame] | 611 | SendGenericPacket(); |
Sebastian Jansson | 1bca65b | 2018-10-10 09:58:08 +0200 | [diff] [blame] | 612 | EXPECT_TRUE(transport_.last_options_.included_in_feedback); |
| 613 | } |
| 614 | |
| 615 | TEST_P( |
| 616 | RtpSenderTestWithoutPacer, |
| 617 | SetsIncludedInAllocationWhenTransportSequenceNumberExtensionIsRegistered) { |
| 618 | SetUpRtpSender(false, false); |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 619 | rtp_sender()->RegisterRtpHeaderExtension(kRtpExtensionTransportSequenceNumber, |
| 620 | kTransportSequenceNumberExtensionId); |
Sebastian Jansson | 1bca65b | 2018-10-10 09:58:08 +0200 | [diff] [blame] | 621 | EXPECT_CALL(send_packet_observer_, OnSendPacket).Times(1); |
Niels Möller | e7b9e6b | 2019-02-06 18:23:44 +0100 | [diff] [blame] | 622 | SendGenericPacket(); |
Sebastian Jansson | 1bca65b | 2018-10-10 09:58:08 +0200 | [diff] [blame] | 623 | EXPECT_TRUE(transport_.last_options_.included_in_allocation); |
| 624 | } |
| 625 | |
| 626 | TEST_P(RtpSenderTestWithoutPacer, |
| 627 | SetsIncludedInAllocationWhenForcedAsPartOfAllocation) { |
| 628 | SetUpRtpSender(false, false); |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 629 | rtp_egress()->ForceIncludeSendPacketsInAllocation(true); |
Niels Möller | e7b9e6b | 2019-02-06 18:23:44 +0100 | [diff] [blame] | 630 | SendGenericPacket(); |
Sebastian Jansson | 1bca65b | 2018-10-10 09:58:08 +0200 | [diff] [blame] | 631 | EXPECT_FALSE(transport_.last_options_.included_in_feedback); |
| 632 | EXPECT_TRUE(transport_.last_options_.included_in_allocation); |
| 633 | } |
| 634 | |
| 635 | TEST_P(RtpSenderTestWithoutPacer, DoesnSetIncludedInAllocationByDefault) { |
| 636 | SetUpRtpSender(false, false); |
Niels Möller | e7b9e6b | 2019-02-06 18:23:44 +0100 | [diff] [blame] | 637 | SendGenericPacket(); |
Sebastian Jansson | 1bca65b | 2018-10-10 09:58:08 +0200 | [diff] [blame] | 638 | EXPECT_FALSE(transport_.last_options_.included_in_feedback); |
| 639 | EXPECT_FALSE(transport_.last_options_.included_in_allocation); |
stefan | a23fc62 | 2016-07-28 07:56:38 -0700 | [diff] [blame] | 640 | } |
asapersson | 35151f3 | 2016-05-02 23:44:01 -0700 | [diff] [blame] | 641 | |
Johannes Kron | 4a8a5e7 | 2018-09-26 09:57:48 +0200 | [diff] [blame] | 642 | TEST_P(RtpSenderTestWithoutPacer, OnSendSideDelayUpdated) { |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 643 | StrictMock<MockSendSideDelayObserver> send_side_delay_observer_; |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 644 | |
| 645 | RtpRtcp::Configuration config; |
| 646 | config.clock = &fake_clock_; |
| 647 | config.outgoing_transport = &transport_; |
Erik Språng | 54d5d2c | 2019-08-20 17:22:36 +0200 | [diff] [blame] | 648 | config.local_media_ssrc = kSsrc; |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 649 | config.send_side_delay_observer = &send_side_delay_observer_; |
| 650 | config.event_log = &mock_rtc_event_log_; |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 651 | rtp_sender_context_ = std::make_unique<RtpSenderContext>(config); |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 652 | |
Niels Möller | 5fe9510 | 2019-03-04 16:49:25 +0100 | [diff] [blame] | 653 | PlayoutDelayOracle playout_delay_oracle; |
Erik Språng | dc34a25 | 2019-10-04 15:17:29 +0200 | [diff] [blame] | 654 | FieldTrialBasedConfig field_trials; |
| 655 | RTPSenderVideo::Config video_config; |
| 656 | video_config.clock = &fake_clock_; |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 657 | video_config.rtp_sender = rtp_sender(); |
Erik Språng | dc34a25 | 2019-10-04 15:17:29 +0200 | [diff] [blame] | 658 | video_config.playout_delay_oracle = &playout_delay_oracle; |
| 659 | video_config.field_trials = &field_trials; |
| 660 | RTPSenderVideo rtp_sender_video(video_config); |
Johannes Kron | 4a8a5e7 | 2018-09-26 09:57:48 +0200 | [diff] [blame] | 661 | |
| 662 | const uint8_t kPayloadType = 127; |
Erik Språng | 6cf554e | 2019-10-02 20:55:39 +0200 | [diff] [blame] | 663 | const absl::optional<VideoCodecType> kCodecType = |
| 664 | VideoCodecType::kVideoCodecGeneric; |
Niels Möller | 59ab1cf | 2019-02-06 22:48:11 +0100 | [diff] [blame] | 665 | |
| 666 | const uint32_t kCaptureTimeMsToRtpTimestamp = 90; // 90 kHz clock |
Johannes Kron | 4a8a5e7 | 2018-09-26 09:57:48 +0200 | [diff] [blame] | 667 | RTPVideoHeader video_header; |
Johannes Kron | 4a8a5e7 | 2018-09-26 09:57:48 +0200 | [diff] [blame] | 668 | |
Henrik Boström | 9fe1834 | 2019-05-16 18:38:20 +0200 | [diff] [blame] | 669 | // Send packet with 10 ms send-side delay. The average, max and total should |
| 670 | // be 10 ms. |
| 671 | EXPECT_CALL(send_side_delay_observer_, |
| 672 | SendSideDelayUpdated(10, 10, 10, kSsrc)) |
Johannes Kron | 4a8a5e7 | 2018-09-26 09:57:48 +0200 | [diff] [blame] | 673 | .Times(1); |
| 674 | int64_t capture_time_ms = fake_clock_.TimeInMilliseconds(); |
| 675 | fake_clock_.AdvanceTimeMilliseconds(10); |
Danil Chapovalov | 51bf200 | 2019-10-11 10:53:27 +0200 | [diff] [blame] | 676 | video_header.frame_type = VideoFrameType::kVideoFrameKey; |
Niels Möller | 59ab1cf | 2019-02-06 22:48:11 +0100 | [diff] [blame] | 677 | EXPECT_TRUE(rtp_sender_video.SendVideo( |
Danil Chapovalov | 51bf200 | 2019-10-11 10:53:27 +0200 | [diff] [blame] | 678 | kPayloadType, kCodecType, capture_time_ms * kCaptureTimeMsToRtpTimestamp, |
| 679 | capture_time_ms, kPayloadData, nullptr, video_header, |
Johannes Kron | 4a8a5e7 | 2018-09-26 09:57:48 +0200 | [diff] [blame] | 680 | kDefaultExpectedRetransmissionTimeMs)); |
| 681 | |
Henrik Boström | 9fe1834 | 2019-05-16 18:38:20 +0200 | [diff] [blame] | 682 | // Send another packet with 20 ms delay. The average, max and total should be |
| 683 | // 15, 20 and 30 ms respectively. |
| 684 | EXPECT_CALL(send_side_delay_observer_, |
| 685 | SendSideDelayUpdated(15, 20, 30, kSsrc)) |
Johannes Kron | 4a8a5e7 | 2018-09-26 09:57:48 +0200 | [diff] [blame] | 686 | .Times(1); |
| 687 | fake_clock_.AdvanceTimeMilliseconds(10); |
Danil Chapovalov | 51bf200 | 2019-10-11 10:53:27 +0200 | [diff] [blame] | 688 | video_header.frame_type = VideoFrameType::kVideoFrameKey; |
Niels Möller | 59ab1cf | 2019-02-06 22:48:11 +0100 | [diff] [blame] | 689 | EXPECT_TRUE(rtp_sender_video.SendVideo( |
Danil Chapovalov | 51bf200 | 2019-10-11 10:53:27 +0200 | [diff] [blame] | 690 | kPayloadType, kCodecType, capture_time_ms * kCaptureTimeMsToRtpTimestamp, |
| 691 | capture_time_ms, kPayloadData, nullptr, video_header, |
Johannes Kron | 4a8a5e7 | 2018-09-26 09:57:48 +0200 | [diff] [blame] | 692 | kDefaultExpectedRetransmissionTimeMs)); |
| 693 | |
| 694 | // Send another packet at the same time, which replaces the last packet. |
| 695 | // Since this packet has 0 ms delay, the average is now 5 ms and max is 10 ms. |
Henrik Boström | 9fe1834 | 2019-05-16 18:38:20 +0200 | [diff] [blame] | 696 | // The total counter stays the same though. |
Johannes Kron | 4a8a5e7 | 2018-09-26 09:57:48 +0200 | [diff] [blame] | 697 | // TODO(terelius): Is is not clear that this is the right behavior. |
Henrik Boström | 9fe1834 | 2019-05-16 18:38:20 +0200 | [diff] [blame] | 698 | EXPECT_CALL(send_side_delay_observer_, SendSideDelayUpdated(5, 10, 30, kSsrc)) |
Johannes Kron | 4a8a5e7 | 2018-09-26 09:57:48 +0200 | [diff] [blame] | 699 | .Times(1); |
| 700 | capture_time_ms = fake_clock_.TimeInMilliseconds(); |
Danil Chapovalov | 51bf200 | 2019-10-11 10:53:27 +0200 | [diff] [blame] | 701 | video_header.frame_type = VideoFrameType::kVideoFrameKey; |
Niels Möller | 59ab1cf | 2019-02-06 22:48:11 +0100 | [diff] [blame] | 702 | EXPECT_TRUE(rtp_sender_video.SendVideo( |
Danil Chapovalov | 51bf200 | 2019-10-11 10:53:27 +0200 | [diff] [blame] | 703 | kPayloadType, kCodecType, capture_time_ms * kCaptureTimeMsToRtpTimestamp, |
| 704 | capture_time_ms, kPayloadData, nullptr, video_header, |
Johannes Kron | 4a8a5e7 | 2018-09-26 09:57:48 +0200 | [diff] [blame] | 705 | kDefaultExpectedRetransmissionTimeMs)); |
| 706 | |
| 707 | // Send a packet 1 second later. The earlier packets should have timed |
Henrik Boström | 9fe1834 | 2019-05-16 18:38:20 +0200 | [diff] [blame] | 708 | // out, so both max and average should be the delay of this packet. The total |
| 709 | // keeps increasing. |
Johannes Kron | 4a8a5e7 | 2018-09-26 09:57:48 +0200 | [diff] [blame] | 710 | fake_clock_.AdvanceTimeMilliseconds(1000); |
| 711 | capture_time_ms = fake_clock_.TimeInMilliseconds(); |
| 712 | fake_clock_.AdvanceTimeMilliseconds(1); |
Henrik Boström | 9fe1834 | 2019-05-16 18:38:20 +0200 | [diff] [blame] | 713 | EXPECT_CALL(send_side_delay_observer_, SendSideDelayUpdated(1, 1, 31, kSsrc)) |
Johannes Kron | 4a8a5e7 | 2018-09-26 09:57:48 +0200 | [diff] [blame] | 714 | .Times(1); |
Danil Chapovalov | 51bf200 | 2019-10-11 10:53:27 +0200 | [diff] [blame] | 715 | video_header.frame_type = VideoFrameType::kVideoFrameKey; |
Niels Möller | 59ab1cf | 2019-02-06 22:48:11 +0100 | [diff] [blame] | 716 | EXPECT_TRUE(rtp_sender_video.SendVideo( |
Danil Chapovalov | 51bf200 | 2019-10-11 10:53:27 +0200 | [diff] [blame] | 717 | kPayloadType, kCodecType, capture_time_ms * kCaptureTimeMsToRtpTimestamp, |
| 718 | capture_time_ms, kPayloadData, nullptr, video_header, |
Johannes Kron | 4a8a5e7 | 2018-09-26 09:57:48 +0200 | [diff] [blame] | 719 | kDefaultExpectedRetransmissionTimeMs)); |
| 720 | } |
| 721 | |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 722 | TEST_P(RtpSenderTestWithoutPacer, OnSendPacketUpdated) { |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 723 | EXPECT_EQ(0, rtp_sender()->RegisterRtpHeaderExtension( |
stefan | a23fc62 | 2016-07-28 07:56:38 -0700 | [diff] [blame] | 724 | kRtpExtensionTransportSequenceNumber, |
| 725 | kTransportSequenceNumberExtensionId)); |
asapersson | 35151f3 | 2016-05-02 23:44:01 -0700 | [diff] [blame] | 726 | EXPECT_CALL(send_packet_observer_, |
| 727 | OnSendPacket(kTransportSequenceNumber, _, _)) |
| 728 | .Times(1); |
| 729 | |
Niels Möller | e7b9e6b | 2019-02-06 18:23:44 +0100 | [diff] [blame] | 730 | SendGenericPacket(); |
asapersson | 35151f3 | 2016-05-02 23:44:01 -0700 | [diff] [blame] | 731 | } |
| 732 | |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 733 | TEST_P(RtpSenderTest, SendsPacketsWithTransportSequenceNumber) { |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 734 | RtpRtcp::Configuration config; |
| 735 | config.clock = &fake_clock_; |
| 736 | config.outgoing_transport = &transport_; |
| 737 | config.paced_sender = &mock_paced_sender_; |
Erik Språng | 54d5d2c | 2019-08-20 17:22:36 +0200 | [diff] [blame] | 738 | config.local_media_ssrc = kSsrc; |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 739 | config.transport_feedback_callback = &feedback_observer_; |
| 740 | config.event_log = &mock_rtc_event_log_; |
| 741 | config.send_packet_observer = &send_packet_observer_; |
| 742 | config.retransmission_rate_limiter = &retransmission_rate_limiter_; |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 743 | rtp_sender_context_ = std::make_unique<RtpSenderContext>(config); |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 744 | |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 745 | rtp_sender()->SetSequenceNumber(kSeqNum); |
| 746 | rtp_sender_context_->packet_history_.SetStorePacketsStatus( |
| 747 | RtpPacketHistory::StorageMode::kStoreAndCull, 10); |
| 748 | EXPECT_EQ(0, rtp_sender()->RegisterRtpHeaderExtension( |
Stefan Holmer | a246cfb | 2016-08-23 17:51:42 +0200 | [diff] [blame] | 749 | kRtpExtensionTransportSequenceNumber, |
| 750 | kTransportSequenceNumberExtensionId)); |
| 751 | |
Stefan Holmer | a246cfb | 2016-08-23 17:51:42 +0200 | [diff] [blame] | 752 | EXPECT_CALL(send_packet_observer_, |
| 753 | OnSendPacket(kTransportSequenceNumber, _, _)) |
| 754 | .Times(1); |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 755 | EXPECT_CALL(feedback_observer_, |
Erik Språng | 30a276b | 2019-04-23 12:00:11 +0200 | [diff] [blame] | 756 | OnAddPacket(AllOf( |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 757 | Field(&RtpPacketSendInfo::ssrc, rtp_sender()->SSRC()), |
Erik Språng | 30a276b | 2019-04-23 12:00:11 +0200 | [diff] [blame] | 758 | Field(&RtpPacketSendInfo::transport_sequence_number, |
| 759 | kTransportSequenceNumber), |
| 760 | Field(&RtpPacketSendInfo::rtp_sequence_number, |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 761 | rtp_sender()->SequenceNumber()), |
Erik Språng | 30a276b | 2019-04-23 12:00:11 +0200 | [diff] [blame] | 762 | Field(&RtpPacketSendInfo::pacing_info, PacedPacketInfo())))) |
Stefan Holmer | a246cfb | 2016-08-23 17:51:42 +0200 | [diff] [blame] | 763 | .Times(1); |
| 764 | |
Erik Språng | f5815fa | 2019-08-21 14:27:31 +0200 | [diff] [blame] | 765 | EXPECT_CALL( |
| 766 | mock_paced_sender_, |
Erik Språng | ea55b08 | 2019-10-02 14:57:46 +0200 | [diff] [blame] | 767 | EnqueuePackets(Contains(AllOf( |
| 768 | Pointee(Property(&RtpPacketToSend::Ssrc, kSsrc)), |
| 769 | Pointee(Property(&RtpPacketToSend::SequenceNumber, kSeqNum)))))); |
Erik Språng | f5815fa | 2019-08-21 14:27:31 +0200 | [diff] [blame] | 770 | auto packet = SendGenericPacket(); |
| 771 | packet->set_packet_type(RtpPacketToSend::Type::kVideo); |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 772 | // Transport sequence number is set by PacketRouter, before SendPacket(). |
Erik Språng | f5815fa | 2019-08-21 14:27:31 +0200 | [diff] [blame] | 773 | packet->SetExtension<TransportSequenceNumber>(kTransportSequenceNumber); |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 774 | rtp_egress()->SendPacket(packet.get(), PacedPacketInfo()); |
Stefan Holmer | a246cfb | 2016-08-23 17:51:42 +0200 | [diff] [blame] | 775 | |
danilchap | 12ba186 | 2016-10-26 02:41:55 -0700 | [diff] [blame] | 776 | uint16_t transport_seq_no; |
Erik Språng | f5815fa | 2019-08-21 14:27:31 +0200 | [diff] [blame] | 777 | EXPECT_TRUE( |
| 778 | transport_.last_sent_packet().GetExtension<TransportSequenceNumber>( |
| 779 | &transport_seq_no)); |
danilchap | 12ba186 | 2016-10-26 02:41:55 -0700 | [diff] [blame] | 780 | EXPECT_EQ(kTransportSequenceNumber, transport_seq_no); |
Petter Strandmark | 26bc669 | 2018-05-29 08:43:35 +0200 | [diff] [blame] | 781 | EXPECT_EQ(transport_.last_options_.packet_id, transport_seq_no); |
Stefan Holmer | a246cfb | 2016-08-23 17:51:42 +0200 | [diff] [blame] | 782 | } |
| 783 | |
Erik Språng | 7b52f10 | 2018-02-07 14:37:37 +0100 | [diff] [blame] | 784 | TEST_P(RtpSenderTest, WritesPacerExitToTimingExtension) { |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 785 | rtp_sender_context_->packet_history_.SetStorePacketsStatus( |
| 786 | RtpPacketHistory::StorageMode::kStoreAndCull, 10); |
| 787 | EXPECT_EQ(0, rtp_sender()->RegisterRtpHeaderExtension( |
ilnik | 04f4d12 | 2017-06-19 07:18:55 -0700 | [diff] [blame] | 788 | kRtpExtensionVideoTiming, kVideoTimingExtensionId)); |
| 789 | int64_t capture_time_ms = fake_clock_.TimeInMilliseconds(); |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 790 | auto packet = rtp_sender()->AllocatePacket(); |
ilnik | 04f4d12 | 2017-06-19 07:18:55 -0700 | [diff] [blame] | 791 | packet->SetPayloadType(kPayload); |
| 792 | packet->SetMarker(true); |
| 793 | packet->SetTimestamp(kTimestamp); |
| 794 | packet->set_capture_time_ms(capture_time_ms); |
ilnik | 2edc684 | 2017-07-06 03:06:50 -0700 | [diff] [blame] | 795 | const VideoSendTiming kVideoTiming = {0u, 0u, 0u, 0u, 0u, 0u, true}; |
ilnik | 04f4d12 | 2017-06-19 07:18:55 -0700 | [diff] [blame] | 796 | packet->SetExtension<VideoTimingExtension>(kVideoTiming); |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 797 | EXPECT_TRUE(rtp_sender()->AssignSequenceNumber(packet.get())); |
ilnik | 04f4d12 | 2017-06-19 07:18:55 -0700 | [diff] [blame] | 798 | size_t packet_size = packet->size(); |
ilnik | 04f4d12 | 2017-06-19 07:18:55 -0700 | [diff] [blame] | 799 | |
| 800 | const int kStoredTimeInMs = 100; |
Erik Språng | f5815fa | 2019-08-21 14:27:31 +0200 | [diff] [blame] | 801 | packet->set_packet_type(RtpPacketToSend::Type::kVideo); |
Erik Språng | 70768f4 | 2019-08-27 18:16:26 +0200 | [diff] [blame] | 802 | packet->set_allow_retransmission(true); |
Erik Språng | ea55b08 | 2019-10-02 14:57:46 +0200 | [diff] [blame] | 803 | EXPECT_CALL(mock_paced_sender_, EnqueuePackets(Contains(Pointee(Property( |
| 804 | &RtpPacketToSend::Ssrc, kSsrc))))); |
Erik Språng | 70768f4 | 2019-08-27 18:16:26 +0200 | [diff] [blame] | 805 | EXPECT_TRUE( |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 806 | rtp_sender()->SendToNetwork(std::make_unique<RtpPacketToSend>(*packet))); |
Erik Språng | f5815fa | 2019-08-21 14:27:31 +0200 | [diff] [blame] | 807 | fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs); |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 808 | rtp_egress()->SendPacket(packet.get(), PacedPacketInfo()); |
ilnik | 04f4d12 | 2017-06-19 07:18:55 -0700 | [diff] [blame] | 809 | EXPECT_EQ(1, transport_.packets_sent()); |
| 810 | EXPECT_EQ(packet_size, transport_.last_sent_packet().size()); |
| 811 | |
danilchap | ce25181 | 2017-09-11 12:24:41 -0700 | [diff] [blame] | 812 | VideoSendTiming video_timing; |
| 813 | EXPECT_TRUE(transport_.last_sent_packet().GetExtension<VideoTimingExtension>( |
| 814 | &video_timing)); |
| 815 | EXPECT_EQ(kStoredTimeInMs, video_timing.pacer_exit_delta_ms); |
Erik Språng | 7b52f10 | 2018-02-07 14:37:37 +0100 | [diff] [blame] | 816 | } |
ilnik | 04f4d12 | 2017-06-19 07:18:55 -0700 | [diff] [blame] | 817 | |
Danil Chapovalov | af52b68 | 2018-11-27 10:48:27 +0100 | [diff] [blame] | 818 | TEST_P(RtpSenderTest, WritesNetwork2ToTimingExtensionWithPacer) { |
| 819 | SetUpRtpSender(/*pacer=*/true, /*populate_network2=*/true); |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 820 | rtp_sender_context_->packet_history_.SetStorePacketsStatus( |
| 821 | RtpPacketHistory::StorageMode::kStoreAndCull, 10); |
| 822 | EXPECT_EQ(0, rtp_sender()->RegisterRtpHeaderExtension( |
Erik Språng | 7b52f10 | 2018-02-07 14:37:37 +0100 | [diff] [blame] | 823 | kRtpExtensionVideoTiming, kVideoTimingExtensionId)); |
| 824 | int64_t capture_time_ms = fake_clock_.TimeInMilliseconds(); |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 825 | auto packet = rtp_sender()->AllocatePacket(); |
Erik Språng | 7b52f10 | 2018-02-07 14:37:37 +0100 | [diff] [blame] | 826 | packet->SetPayloadType(kPayload); |
| 827 | packet->SetMarker(true); |
| 828 | packet->SetTimestamp(kTimestamp); |
| 829 | packet->set_capture_time_ms(capture_time_ms); |
| 830 | const uint16_t kPacerExitMs = 1234u; |
| 831 | const VideoSendTiming kVideoTiming = {0u, 0u, 0u, kPacerExitMs, 0u, 0u, true}; |
| 832 | packet->SetExtension<VideoTimingExtension>(kVideoTiming); |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 833 | EXPECT_TRUE(rtp_sender()->AssignSequenceNumber(packet.get())); |
Erik Språng | 7b52f10 | 2018-02-07 14:37:37 +0100 | [diff] [blame] | 834 | size_t packet_size = packet->size(); |
| 835 | |
| 836 | const int kStoredTimeInMs = 100; |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 837 | |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 838 | packet->set_packet_type(RtpPacketToSend::Type::kVideo); |
Erik Språng | 70768f4 | 2019-08-27 18:16:26 +0200 | [diff] [blame] | 839 | packet->set_allow_retransmission(true); |
Erik Språng | ea55b08 | 2019-10-02 14:57:46 +0200 | [diff] [blame] | 840 | EXPECT_CALL(mock_paced_sender_, EnqueuePackets(Contains(Pointee(Property( |
| 841 | &RtpPacketToSend::Ssrc, kSsrc))))); |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 842 | EXPECT_TRUE(rtp_sender()->SendToNetwork( |
| 843 | std::make_unique<RtpPacketToSend>(*packet))); |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 844 | fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs); |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 845 | rtp_egress()->SendPacket(packet.get(), PacedPacketInfo()); |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 846 | |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 847 | EXPECT_EQ(1, transport_.packets_sent()); |
| 848 | EXPECT_EQ(packet_size, transport_.last_sent_packet().size()); |
ilnik | 04f4d12 | 2017-06-19 07:18:55 -0700 | [diff] [blame] | 849 | |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 850 | VideoSendTiming video_timing; |
| 851 | EXPECT_TRUE( |
| 852 | transport_.last_sent_packet().GetExtension<VideoTimingExtension>( |
| 853 | &video_timing)); |
| 854 | EXPECT_EQ(kStoredTimeInMs, video_timing.network2_timestamp_delta_ms); |
| 855 | EXPECT_EQ(kPacerExitMs, video_timing.pacer_exit_delta_ms); |
ilnik | 04f4d12 | 2017-06-19 07:18:55 -0700 | [diff] [blame] | 856 | } |
| 857 | |
Danil Chapovalov | af52b68 | 2018-11-27 10:48:27 +0100 | [diff] [blame] | 858 | TEST_P(RtpSenderTest, WritesNetwork2ToTimingExtensionWithoutPacer) { |
| 859 | SetUpRtpSender(/*pacer=*/false, /*populate_network2=*/true); |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 860 | EXPECT_EQ(0, rtp_sender()->RegisterRtpHeaderExtension( |
Danil Chapovalov | af52b68 | 2018-11-27 10:48:27 +0100 | [diff] [blame] | 861 | kRtpExtensionVideoTiming, kVideoTimingExtensionId)); |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 862 | auto packet = rtp_sender()->AllocatePacket(); |
Danil Chapovalov | af52b68 | 2018-11-27 10:48:27 +0100 | [diff] [blame] | 863 | packet->SetMarker(true); |
| 864 | packet->set_capture_time_ms(fake_clock_.TimeInMilliseconds()); |
| 865 | const VideoSendTiming kVideoTiming = {0u, 0u, 0u, 0u, 0u, 0u, true}; |
| 866 | packet->SetExtension<VideoTimingExtension>(kVideoTiming); |
Erik Språng | 70768f4 | 2019-08-27 18:16:26 +0200 | [diff] [blame] | 867 | packet->set_allow_retransmission(true); |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 868 | EXPECT_TRUE(rtp_sender()->AssignSequenceNumber(packet.get())); |
Erik Språng | 1fbfecd | 2019-08-26 19:00:05 +0200 | [diff] [blame] | 869 | packet->set_packet_type(RtpPacketToSend::Type::kVideo); |
Danil Chapovalov | af52b68 | 2018-11-27 10:48:27 +0100 | [diff] [blame] | 870 | |
| 871 | const int kPropagateTimeMs = 10; |
| 872 | fake_clock_.AdvanceTimeMilliseconds(kPropagateTimeMs); |
| 873 | |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 874 | EXPECT_TRUE(rtp_sender()->SendToNetwork(std::move(packet))); |
Danil Chapovalov | af52b68 | 2018-11-27 10:48:27 +0100 | [diff] [blame] | 875 | |
| 876 | EXPECT_EQ(1, transport_.packets_sent()); |
| 877 | absl::optional<VideoSendTiming> video_timing = |
| 878 | transport_.last_sent_packet().GetExtension<VideoTimingExtension>(); |
| 879 | ASSERT_TRUE(video_timing); |
| 880 | EXPECT_EQ(kPropagateTimeMs, video_timing->network2_timestamp_delta_ms); |
| 881 | } |
| 882 | |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 883 | TEST_P(RtpSenderTest, TrafficSmoothingWithExtensions) { |
Elad Alon | 4a87e1c | 2017-10-03 16:11:34 +0200 | [diff] [blame] | 884 | EXPECT_CALL(mock_rtc_event_log_, |
| 885 | LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing))); |
asapersson@webrtc.org | 0b3c35a | 2012-01-16 11:06:31 +0000 | [diff] [blame] | 886 | |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 887 | rtp_sender_context_->packet_history_.SetStorePacketsStatus( |
| 888 | RtpPacketHistory::StorageMode::kStoreAndCull, 10); |
| 889 | EXPECT_EQ(0, rtp_sender()->RegisterRtpHeaderExtension( |
danilchap | 162abd3 | 2015-12-10 02:39:40 -0800 | [diff] [blame] | 890 | kRtpExtensionTransmissionTimeOffset, |
| 891 | kTransmissionTimeOffsetExtensionId)); |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 892 | EXPECT_EQ(0, |
| 893 | rtp_sender()->RegisterRtpHeaderExtension( |
| 894 | kRtpExtensionAbsoluteSendTime, kAbsoluteSendTimeExtensionId)); |
stefan@webrtc.org | 8ccb9f9 | 2013-06-19 14:13:42 +0000 | [diff] [blame] | 895 | int64_t capture_time_ms = fake_clock_.TimeInMilliseconds(); |
danilchap | b6f1fb5 | 2016-10-19 06:11:39 -0700 | [diff] [blame] | 896 | auto packet = |
| 897 | BuildRtpPacket(kPayload, kMarkerBit, kTimestamp, capture_time_ms); |
| 898 | size_t packet_size = packet->size(); |
pwestin@webrtc.org | b0061f9 | 2013-04-27 00:41:08 +0000 | [diff] [blame] | 899 | |
asapersson@webrtc.org | 0b3c35a | 2012-01-16 11:06:31 +0000 | [diff] [blame] | 900 | const int kStoredTimeInMs = 100; |
Erik Språng | ea55b08 | 2019-10-02 14:57:46 +0200 | [diff] [blame] | 901 | EXPECT_CALL( |
| 902 | mock_paced_sender_, |
| 903 | EnqueuePackets(Contains(AllOf( |
| 904 | Pointee(Property(&RtpPacketToSend::Ssrc, kSsrc)), |
| 905 | Pointee(Property(&RtpPacketToSend::SequenceNumber, kSeqNum)))))); |
| 906 | packet->set_packet_type(RtpPacketToSend::Type::kVideo); |
| 907 | packet->set_allow_retransmission(true); |
| 908 | EXPECT_TRUE( |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 909 | rtp_sender()->SendToNetwork(std::make_unique<RtpPacketToSend>(*packet))); |
Erik Språng | ea55b08 | 2019-10-02 14:57:46 +0200 | [diff] [blame] | 910 | EXPECT_EQ(0, transport_.packets_sent()); |
| 911 | fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs); |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 912 | rtp_egress()->SendPacket(packet.get(), PacedPacketInfo()); |
pwestin@webrtc.org | b0061f9 | 2013-04-27 00:41:08 +0000 | [diff] [blame] | 913 | |
asapersson@webrtc.org | 0b3c35a | 2012-01-16 11:06:31 +0000 | [diff] [blame] | 914 | // Process send bucket. Packet should now be sent. |
danilchap | 12ba186 | 2016-10-26 02:41:55 -0700 | [diff] [blame] | 915 | EXPECT_EQ(1, transport_.packets_sent()); |
| 916 | EXPECT_EQ(packet_size, transport_.last_sent_packet().size()); |
| 917 | |
stefan@webrtc.org | a5cb98c | 2013-05-29 12:12:51 +0000 | [diff] [blame] | 918 | webrtc::RTPHeader rtp_header; |
danilchap | 12ba186 | 2016-10-26 02:41:55 -0700 | [diff] [blame] | 919 | transport_.last_sent_packet().GetHeader(&rtp_header); |
pwestin@webrtc.org | b0061f9 | 2013-04-27 00:41:08 +0000 | [diff] [blame] | 920 | |
| 921 | // Verify transmission time offset. |
| 922 | EXPECT_EQ(kStoredTimeInMs * 90, rtp_header.extension.transmissionTimeOffset); |
solenberg@webrtc.org | 7ebbea1 | 2013-05-16 11:10:31 +0000 | [diff] [blame] | 923 | uint64_t expected_send_time = |
henrik.lundin@webrtc.org | 6e95d7a | 2013-11-15 08:59:19 +0000 | [diff] [blame] | 924 | ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds()); |
solenberg@webrtc.org | 7ebbea1 | 2013-05-16 11:10:31 +0000 | [diff] [blame] | 925 | EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime); |
pwestin@webrtc.org | b0061f9 | 2013-04-27 00:41:08 +0000 | [diff] [blame] | 926 | } |
| 927 | |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 928 | TEST_P(RtpSenderTest, TrafficSmoothingRetransmits) { |
Elad Alon | 4a87e1c | 2017-10-03 16:11:34 +0200 | [diff] [blame] | 929 | EXPECT_CALL(mock_rtc_event_log_, |
| 930 | LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing))); |
pwestin@webrtc.org | b0061f9 | 2013-04-27 00:41:08 +0000 | [diff] [blame] | 931 | |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 932 | rtp_sender_context_->packet_history_.SetStorePacketsStatus( |
| 933 | RtpPacketHistory::StorageMode::kStoreAndCull, 10); |
| 934 | EXPECT_EQ(0, rtp_sender()->RegisterRtpHeaderExtension( |
danilchap | 162abd3 | 2015-12-10 02:39:40 -0800 | [diff] [blame] | 935 | kRtpExtensionTransmissionTimeOffset, |
| 936 | kTransmissionTimeOffsetExtensionId)); |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 937 | EXPECT_EQ(0, |
| 938 | rtp_sender()->RegisterRtpHeaderExtension( |
| 939 | kRtpExtensionAbsoluteSendTime, kAbsoluteSendTimeExtensionId)); |
stefan@webrtc.org | 8ccb9f9 | 2013-06-19 14:13:42 +0000 | [diff] [blame] | 940 | int64_t capture_time_ms = fake_clock_.TimeInMilliseconds(); |
danilchap | b6f1fb5 | 2016-10-19 06:11:39 -0700 | [diff] [blame] | 941 | auto packet = |
| 942 | BuildRtpPacket(kPayload, kMarkerBit, kTimestamp, capture_time_ms); |
| 943 | size_t packet_size = packet->size(); |
pwestin@webrtc.org | b0061f9 | 2013-04-27 00:41:08 +0000 | [diff] [blame] | 944 | |
| 945 | // Packet should be stored in a send bucket. |
Erik Språng | ea55b08 | 2019-10-02 14:57:46 +0200 | [diff] [blame] | 946 | EXPECT_CALL( |
| 947 | mock_paced_sender_, |
| 948 | EnqueuePackets(Contains(AllOf( |
| 949 | Pointee(Property(&RtpPacketToSend::Ssrc, kSsrc)), |
| 950 | Pointee(Property(&RtpPacketToSend::SequenceNumber, kSeqNum)))))); |
| 951 | packet->set_packet_type(RtpPacketToSend::Type::kVideo); |
| 952 | packet->set_allow_retransmission(true); |
| 953 | EXPECT_TRUE( |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 954 | rtp_sender()->SendToNetwork(std::make_unique<RtpPacketToSend>(*packet))); |
Erik Språng | ea55b08 | 2019-10-02 14:57:46 +0200 | [diff] [blame] | 955 | // Immediately process send bucket and send packet. |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 956 | rtp_egress()->SendPacket(packet.get(), PacedPacketInfo()); |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 957 | |
Erik Språng | 0f4f055 | 2019-05-08 10:15:05 -0700 | [diff] [blame] | 958 | EXPECT_EQ(1, transport_.packets_sent()); |
pwestin@webrtc.org | b0061f9 | 2013-04-27 00:41:08 +0000 | [diff] [blame] | 959 | |
Erik Språng | 0f4f055 | 2019-05-08 10:15:05 -0700 | [diff] [blame] | 960 | // Retransmit packet. |
pwestin@webrtc.org | b0061f9 | 2013-04-27 00:41:08 +0000 | [diff] [blame] | 961 | const int kStoredTimeInMs = 100; |
| 962 | fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs); |
| 963 | |
Erik Språng | 0f4f055 | 2019-05-08 10:15:05 -0700 | [diff] [blame] | 964 | EXPECT_CALL(mock_rtc_event_log_, |
| 965 | LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing))); |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 966 | packet->set_packet_type(RtpPacketToSend::Type::kRetransmission); |
| 967 | packet->set_retransmitted_sequence_number(kSeqNum); |
| 968 | EXPECT_CALL( |
| 969 | mock_paced_sender_, |
Erik Språng | ea55b08 | 2019-10-02 14:57:46 +0200 | [diff] [blame] | 970 | EnqueuePackets(Contains(AllOf( |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 971 | Pointee(Property(&RtpPacketToSend::Ssrc, kSsrc)), |
Erik Språng | ea55b08 | 2019-10-02 14:57:46 +0200 | [diff] [blame] | 972 | Pointee(Property(&RtpPacketToSend::SequenceNumber, kSeqNum)))))); |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 973 | EXPECT_EQ(static_cast<int>(packet_size), |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 974 | rtp_sender()->ReSendPacket(kSeqNum)); |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 975 | EXPECT_EQ(1, transport_.packets_sent()); |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 976 | rtp_egress()->SendPacket(packet.get(), PacedPacketInfo()); |
pwestin@webrtc.org | b0061f9 | 2013-04-27 00:41:08 +0000 | [diff] [blame] | 977 | |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 978 | // Process send bucket. Packet should now be sent. |
| 979 | EXPECT_EQ(2, transport_.packets_sent()); |
| 980 | EXPECT_EQ(packet_size, transport_.last_sent_packet().size()); |
pwestin@webrtc.org | b0061f9 | 2013-04-27 00:41:08 +0000 | [diff] [blame] | 981 | |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 982 | webrtc::RTPHeader rtp_header; |
| 983 | transport_.last_sent_packet().GetHeader(&rtp_header); |
pwestin@webrtc.org | b0061f9 | 2013-04-27 00:41:08 +0000 | [diff] [blame] | 984 | |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 985 | // Verify transmission time offset. |
| 986 | EXPECT_EQ(kStoredTimeInMs * 90, |
| 987 | rtp_header.extension.transmissionTimeOffset); |
| 988 | uint64_t expected_send_time = |
| 989 | ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds()); |
| 990 | EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime); |
henrik.lundin@webrtc.org | 6e95d7a | 2013-11-15 08:59:19 +0000 | [diff] [blame] | 991 | } |
| 992 | |
| 993 | // This test sends 1 regular video packet, then 4 padding packets, and then |
| 994 | // 1 more regular packet. |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 995 | TEST_P(RtpSenderTest, SendPadding) { |
henrik.lundin@webrtc.org | 6e95d7a | 2013-11-15 08:59:19 +0000 | [diff] [blame] | 996 | // Make all (non-padding) packets go to send queue. |
Elad Alon | 4a87e1c | 2017-10-03 16:11:34 +0200 | [diff] [blame] | 997 | EXPECT_CALL(mock_rtc_event_log_, |
| 998 | LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing))) |
| 999 | .Times(1 + 4 + 1); |
henrik.lundin@webrtc.org | 6e95d7a | 2013-11-15 08:59:19 +0000 | [diff] [blame] | 1000 | |
| 1001 | uint16_t seq_num = kSeqNum; |
| 1002 | uint32_t timestamp = kTimestamp; |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 1003 | rtp_sender_context_->packet_history_.SetStorePacketsStatus( |
| 1004 | RtpPacketHistory::StorageMode::kStoreAndCull, 10); |
pkasting@chromium.org | 4591fbd | 2014-11-20 22:28:14 +0000 | [diff] [blame] | 1005 | size_t rtp_header_len = kRtpHeaderSize; |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 1006 | EXPECT_EQ(0, rtp_sender()->RegisterRtpHeaderExtension( |
danilchap | 162abd3 | 2015-12-10 02:39:40 -0800 | [diff] [blame] | 1007 | kRtpExtensionTransmissionTimeOffset, |
| 1008 | kTransmissionTimeOffsetExtensionId)); |
henrik.lundin@webrtc.org | 6e95d7a | 2013-11-15 08:59:19 +0000 | [diff] [blame] | 1009 | rtp_header_len += 4; // 4 bytes extension. |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 1010 | EXPECT_EQ(0, |
| 1011 | rtp_sender()->RegisterRtpHeaderExtension( |
| 1012 | kRtpExtensionAbsoluteSendTime, kAbsoluteSendTimeExtensionId)); |
henrik.lundin@webrtc.org | 6e95d7a | 2013-11-15 08:59:19 +0000 | [diff] [blame] | 1013 | rtp_header_len += 4; // 4 bytes extension. |
| 1014 | rtp_header_len += 4; // 4 extra bytes common to all extension headers. |
| 1015 | |
henrik.lundin@webrtc.org | 6e95d7a | 2013-11-15 08:59:19 +0000 | [diff] [blame] | 1016 | webrtc::RTPHeader rtp_header; |
| 1017 | |
henrik.lundin@webrtc.org | 6e95d7a | 2013-11-15 08:59:19 +0000 | [diff] [blame] | 1018 | int64_t capture_time_ms = fake_clock_.TimeInMilliseconds(); |
danilchap | b6f1fb5 | 2016-10-19 06:11:39 -0700 | [diff] [blame] | 1019 | auto packet = |
| 1020 | BuildRtpPacket(kPayload, kMarkerBit, timestamp, capture_time_ms); |
Stefan Holmer | 586b19b | 2015-09-18 11:14:31 +0200 | [diff] [blame] | 1021 | const uint32_t media_packet_timestamp = timestamp; |
danilchap | b6f1fb5 | 2016-10-19 06:11:39 -0700 | [diff] [blame] | 1022 | size_t packet_size = packet->size(); |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 1023 | int total_packets_sent = 0; |
| 1024 | const int kStoredTimeInMs = 100; |
henrik.lundin@webrtc.org | 6e95d7a | 2013-11-15 08:59:19 +0000 | [diff] [blame] | 1025 | |
| 1026 | // Packet should be stored in a send bucket. |
Erik Språng | ea55b08 | 2019-10-02 14:57:46 +0200 | [diff] [blame] | 1027 | EXPECT_CALL( |
| 1028 | mock_paced_sender_, |
| 1029 | EnqueuePackets(Contains(AllOf( |
| 1030 | Pointee(Property(&RtpPacketToSend::Ssrc, kSsrc)), |
| 1031 | Pointee(Property(&RtpPacketToSend::SequenceNumber, kSeqNum)))))); |
| 1032 | packet->set_packet_type(RtpPacketToSend::Type::kVideo); |
| 1033 | packet->set_allow_retransmission(true); |
| 1034 | EXPECT_TRUE( |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 1035 | rtp_sender()->SendToNetwork(std::make_unique<RtpPacketToSend>(*packet))); |
Erik Språng | ea55b08 | 2019-10-02 14:57:46 +0200 | [diff] [blame] | 1036 | EXPECT_EQ(total_packets_sent, transport_.packets_sent()); |
| 1037 | fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs); |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 1038 | rtp_egress()->SendPacket(packet.get(), PacedPacketInfo()); |
Erik Språng | ea55b08 | 2019-10-02 14:57:46 +0200 | [diff] [blame] | 1039 | ++seq_num; |
henrik.lundin@webrtc.org | 6e95d7a | 2013-11-15 08:59:19 +0000 | [diff] [blame] | 1040 | |
henrik.lundin@webrtc.org | 6e95d7a | 2013-11-15 08:59:19 +0000 | [diff] [blame] | 1041 | // Packet should now be sent. This test doesn't verify the regular video |
| 1042 | // packet, since it is tested in another test. |
danilchap | 12ba186 | 2016-10-26 02:41:55 -0700 | [diff] [blame] | 1043 | EXPECT_EQ(++total_packets_sent, transport_.packets_sent()); |
henrik.lundin@webrtc.org | 6e95d7a | 2013-11-15 08:59:19 +0000 | [diff] [blame] | 1044 | timestamp += 90 * kStoredTimeInMs; |
| 1045 | |
| 1046 | // Send padding 4 times, waiting 50 ms between each. |
| 1047 | for (int i = 0; i < 4; ++i) { |
| 1048 | const int kPaddingPeriodMs = 50; |
pkasting@chromium.org | 4591fbd | 2014-11-20 22:28:14 +0000 | [diff] [blame] | 1049 | const size_t kPaddingBytes = 100; |
| 1050 | const size_t kMaxPaddingLength = 224; // Value taken from rtp_sender.cc. |
henrik.lundin@webrtc.org | 6e95d7a | 2013-11-15 08:59:19 +0000 | [diff] [blame] | 1051 | // Padding will be forced to full packets. |
Erik Språng | 4208a13 | 2019-08-26 08:58:45 +0200 | [diff] [blame] | 1052 | EXPECT_EQ(kMaxPaddingLength, GenerateAndSendPadding(kPaddingBytes)); |
henrik.lundin@webrtc.org | 6e95d7a | 2013-11-15 08:59:19 +0000 | [diff] [blame] | 1053 | |
| 1054 | // Process send bucket. Padding should now be sent. |
danilchap | 12ba186 | 2016-10-26 02:41:55 -0700 | [diff] [blame] | 1055 | EXPECT_EQ(++total_packets_sent, transport_.packets_sent()); |
henrik.lundin@webrtc.org | 6e95d7a | 2013-11-15 08:59:19 +0000 | [diff] [blame] | 1056 | EXPECT_EQ(kMaxPaddingLength + rtp_header_len, |
danilchap | 12ba186 | 2016-10-26 02:41:55 -0700 | [diff] [blame] | 1057 | transport_.last_sent_packet().size()); |
| 1058 | |
| 1059 | transport_.last_sent_packet().GetHeader(&rtp_header); |
pbos | bd2522a | 2015-07-01 05:35:53 -0700 | [diff] [blame] | 1060 | EXPECT_EQ(kMaxPaddingLength, rtp_header.paddingLength); |
henrik.lundin@webrtc.org | 6e95d7a | 2013-11-15 08:59:19 +0000 | [diff] [blame] | 1061 | |
Stefan Holmer | 586b19b | 2015-09-18 11:14:31 +0200 | [diff] [blame] | 1062 | // Verify sequence number and timestamp. The timestamp should be the same |
| 1063 | // as the last media packet. |
henrik.lundin@webrtc.org | 6e95d7a | 2013-11-15 08:59:19 +0000 | [diff] [blame] | 1064 | EXPECT_EQ(seq_num++, rtp_header.sequenceNumber); |
Stefan Holmer | 586b19b | 2015-09-18 11:14:31 +0200 | [diff] [blame] | 1065 | EXPECT_EQ(media_packet_timestamp, rtp_header.timestamp); |
henrik.lundin@webrtc.org | 6e95d7a | 2013-11-15 08:59:19 +0000 | [diff] [blame] | 1066 | // Verify transmission time offset. |
Stefan Holmer | 586b19b | 2015-09-18 11:14:31 +0200 | [diff] [blame] | 1067 | int offset = timestamp - media_packet_timestamp; |
| 1068 | EXPECT_EQ(offset, rtp_header.extension.transmissionTimeOffset); |
henrik.lundin@webrtc.org | 6e95d7a | 2013-11-15 08:59:19 +0000 | [diff] [blame] | 1069 | uint64_t expected_send_time = |
| 1070 | ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds()); |
| 1071 | EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime); |
| 1072 | fake_clock_.AdvanceTimeMilliseconds(kPaddingPeriodMs); |
| 1073 | timestamp += 90 * kPaddingPeriodMs; |
| 1074 | } |
| 1075 | |
| 1076 | // Send a regular video packet again. |
| 1077 | capture_time_ms = fake_clock_.TimeInMilliseconds(); |
danilchap | b6f1fb5 | 2016-10-19 06:11:39 -0700 | [diff] [blame] | 1078 | packet = BuildRtpPacket(kPayload, kMarkerBit, timestamp, capture_time_ms); |
| 1079 | packet_size = packet->size(); |
henrik.lundin@webrtc.org | 6e95d7a | 2013-11-15 08:59:19 +0000 | [diff] [blame] | 1080 | |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 1081 | packet->set_packet_type(RtpPacketToSend::Type::kVideo); |
Erik Språng | 70768f4 | 2019-08-27 18:16:26 +0200 | [diff] [blame] | 1082 | packet->set_allow_retransmission(true); |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 1083 | EXPECT_CALL( |
| 1084 | mock_paced_sender_, |
Erik Språng | ea55b08 | 2019-10-02 14:57:46 +0200 | [diff] [blame] | 1085 | EnqueuePackets(Contains(AllOf( |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 1086 | Pointee(Property(&RtpPacketToSend::Ssrc, kSsrc)), |
Erik Språng | ea55b08 | 2019-10-02 14:57:46 +0200 | [diff] [blame] | 1087 | Pointee(Property(&RtpPacketToSend::SequenceNumber, seq_num)))))); |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 1088 | EXPECT_TRUE(rtp_sender()->SendToNetwork( |
| 1089 | std::make_unique<RtpPacketToSend>(*packet))); |
| 1090 | rtp_egress()->SendPacket(packet.get(), PacedPacketInfo()); |
terelius | 5d332ac | 2016-01-14 14:37:39 -0800 | [diff] [blame] | 1091 | |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 1092 | // Process send bucket. |
| 1093 | EXPECT_EQ(++total_packets_sent, transport_.packets_sent()); |
| 1094 | EXPECT_EQ(packet_size, transport_.last_sent_packet().size()); |
| 1095 | transport_.last_sent_packet().GetHeader(&rtp_header); |
henrik.lundin@webrtc.org | 6e95d7a | 2013-11-15 08:59:19 +0000 | [diff] [blame] | 1096 | |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 1097 | // Verify sequence number and timestamp. |
| 1098 | EXPECT_EQ(seq_num, rtp_header.sequenceNumber); |
| 1099 | EXPECT_EQ(timestamp, rtp_header.timestamp); |
| 1100 | // Verify transmission time offset. This packet is sent without delay. |
| 1101 | EXPECT_EQ(0, rtp_header.extension.transmissionTimeOffset); |
| 1102 | uint64_t expected_send_time = |
| 1103 | ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds()); |
| 1104 | EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime); |
asapersson@webrtc.org | 0b3c35a | 2012-01-16 11:06:31 +0000 | [diff] [blame] | 1105 | } |
pbos@webrtc.org | 8911ce4 | 2013-03-18 16:39:03 +0000 | [diff] [blame] | 1106 | |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 1107 | TEST_P(RtpSenderTest, OnSendPacketUpdated) { |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 1108 | EXPECT_EQ(0, rtp_sender()->RegisterRtpHeaderExtension( |
stefan | a23fc62 | 2016-07-28 07:56:38 -0700 | [diff] [blame] | 1109 | kRtpExtensionTransportSequenceNumber, |
| 1110 | kTransportSequenceNumberExtensionId)); |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 1111 | rtp_sender_context_->packet_history_.SetStorePacketsStatus( |
| 1112 | RtpPacketHistory::StorageMode::kStoreAndCull, 10); |
asapersson | 35151f3 | 2016-05-02 23:44:01 -0700 | [diff] [blame] | 1113 | |
| 1114 | EXPECT_CALL(send_packet_observer_, |
| 1115 | OnSendPacket(kTransportSequenceNumber, _, _)) |
| 1116 | .Times(1); |
asapersson | 35151f3 | 2016-05-02 23:44:01 -0700 | [diff] [blame] | 1117 | |
Erik Språng | ea55b08 | 2019-10-02 14:57:46 +0200 | [diff] [blame] | 1118 | EXPECT_CALL( |
| 1119 | mock_paced_sender_, |
| 1120 | EnqueuePackets(Contains(AllOf( |
| 1121 | Pointee(Property(&RtpPacketToSend::Ssrc, kSsrc)), |
| 1122 | Pointee(Property(&RtpPacketToSend::SequenceNumber, kSeqNum)))))); |
| 1123 | auto packet = SendGenericPacket(); |
| 1124 | packet->set_packet_type(RtpPacketToSend::Type::kVideo); |
| 1125 | packet->SetExtension<TransportSequenceNumber>(kTransportSequenceNumber); |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 1126 | rtp_egress()->SendPacket(packet.get(), PacedPacketInfo()); |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 1127 | |
danilchap | 12ba186 | 2016-10-26 02:41:55 -0700 | [diff] [blame] | 1128 | EXPECT_EQ(1, transport_.packets_sent()); |
asapersson | 35151f3 | 2016-05-02 23:44:01 -0700 | [diff] [blame] | 1129 | } |
| 1130 | |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 1131 | TEST_P(RtpSenderTest, OnSendPacketNotUpdatedForRetransmits) { |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 1132 | EXPECT_EQ(0, rtp_sender()->RegisterRtpHeaderExtension( |
stefan | a23fc62 | 2016-07-28 07:56:38 -0700 | [diff] [blame] | 1133 | kRtpExtensionTransportSequenceNumber, |
| 1134 | kTransportSequenceNumberExtensionId)); |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 1135 | rtp_sender_context_->packet_history_.SetStorePacketsStatus( |
| 1136 | RtpPacketHistory::StorageMode::kStoreAndCull, 10); |
asapersson | 35151f3 | 2016-05-02 23:44:01 -0700 | [diff] [blame] | 1137 | |
| 1138 | EXPECT_CALL(send_packet_observer_, OnSendPacket(_, _, _)).Times(0); |
asapersson | 35151f3 | 2016-05-02 23:44:01 -0700 | [diff] [blame] | 1139 | |
Erik Språng | ea55b08 | 2019-10-02 14:57:46 +0200 | [diff] [blame] | 1140 | EXPECT_CALL( |
| 1141 | mock_paced_sender_, |
| 1142 | EnqueuePackets(Contains(AllOf( |
| 1143 | Pointee(Property(&RtpPacketToSend::Ssrc, kSsrc)), |
| 1144 | Pointee(Property(&RtpPacketToSend::SequenceNumber, kSeqNum)))))); |
| 1145 | auto packet = SendGenericPacket(); |
| 1146 | packet->set_packet_type(RtpPacketToSend::Type::kRetransmission); |
| 1147 | packet->SetExtension<TransportSequenceNumber>(kTransportSequenceNumber); |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 1148 | rtp_egress()->SendPacket(packet.get(), PacedPacketInfo()); |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 1149 | |
danilchap | 12ba186 | 2016-10-26 02:41:55 -0700 | [diff] [blame] | 1150 | EXPECT_EQ(1, transport_.packets_sent()); |
Petter Strandmark | 26bc669 | 2018-05-29 08:43:35 +0200 | [diff] [blame] | 1151 | EXPECT_TRUE(transport_.last_options_.is_retransmit); |
asapersson | 35151f3 | 2016-05-02 23:44:01 -0700 | [diff] [blame] | 1152 | } |
| 1153 | |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 1154 | TEST_P(RtpSenderTestWithoutPacer, SendGenericVideo) { |
Erik Språng | 6cf554e | 2019-10-02 20:55:39 +0200 | [diff] [blame] | 1155 | const uint8_t kPayloadType = 127; |
| 1156 | const VideoCodecType kCodecType = VideoCodecType::kVideoCodecGeneric; |
Niels Möller | 5fe9510 | 2019-03-04 16:49:25 +0100 | [diff] [blame] | 1157 | PlayoutDelayOracle playout_delay_oracle; |
Erik Språng | dc34a25 | 2019-10-04 15:17:29 +0200 | [diff] [blame] | 1158 | FieldTrialBasedConfig field_trials; |
| 1159 | RTPSenderVideo::Config video_config; |
| 1160 | video_config.clock = &fake_clock_; |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 1161 | video_config.rtp_sender = rtp_sender(); |
Erik Språng | dc34a25 | 2019-10-04 15:17:29 +0200 | [diff] [blame] | 1162 | video_config.playout_delay_oracle = &playout_delay_oracle; |
| 1163 | video_config.field_trials = &field_trials; |
| 1164 | RTPSenderVideo rtp_sender_video(video_config); |
pbos@webrtc.org | 8911ce4 | 2013-03-18 16:39:03 +0000 | [diff] [blame] | 1165 | uint8_t payload[] = {47, 11, 32, 93, 89}; |
| 1166 | |
| 1167 | // Send keyframe |
Sami Kalliomäki | 426a80c | 2018-08-08 11:37:59 +0200 | [diff] [blame] | 1168 | RTPVideoHeader video_header; |
Danil Chapovalov | 51bf200 | 2019-10-11 10:53:27 +0200 | [diff] [blame] | 1169 | video_header.frame_type = VideoFrameType::kVideoFrameKey; |
| 1170 | ASSERT_TRUE(rtp_sender_video.SendVideo(kPayloadType, kCodecType, 1234, 4321, |
| 1171 | payload, nullptr, video_header, |
| 1172 | kDefaultExpectedRetransmissionTimeMs)); |
pbos@webrtc.org | 8911ce4 | 2013-03-18 16:39:03 +0000 | [diff] [blame] | 1173 | |
danilchap | 96c1587 | 2016-11-21 01:35:29 -0800 | [diff] [blame] | 1174 | auto sent_payload = transport_.last_sent_packet().payload(); |
| 1175 | uint8_t generic_header = sent_payload[0]; |
pbos@webrtc.org | 8911ce4 | 2013-03-18 16:39:03 +0000 | [diff] [blame] | 1176 | EXPECT_TRUE(generic_header & RtpFormatVideoGeneric::kKeyFrameBit); |
| 1177 | EXPECT_TRUE(generic_header & RtpFormatVideoGeneric::kFirstPacketBit); |
danilchap | 96c1587 | 2016-11-21 01:35:29 -0800 | [diff] [blame] | 1178 | EXPECT_THAT(sent_payload.subview(1), ElementsAreArray(payload)); |
pbos@webrtc.org | 8911ce4 | 2013-03-18 16:39:03 +0000 | [diff] [blame] | 1179 | |
| 1180 | // Send delta frame |
| 1181 | payload[0] = 13; |
| 1182 | payload[1] = 42; |
| 1183 | payload[4] = 13; |
| 1184 | |
Danil Chapovalov | 51bf200 | 2019-10-11 10:53:27 +0200 | [diff] [blame] | 1185 | video_header.frame_type = VideoFrameType::kVideoFrameDelta; |
| 1186 | ASSERT_TRUE(rtp_sender_video.SendVideo(kPayloadType, kCodecType, 1234, 4321, |
| 1187 | payload, nullptr, video_header, |
| 1188 | kDefaultExpectedRetransmissionTimeMs)); |
pbos@webrtc.org | 8911ce4 | 2013-03-18 16:39:03 +0000 | [diff] [blame] | 1189 | |
danilchap | 96c1587 | 2016-11-21 01:35:29 -0800 | [diff] [blame] | 1190 | sent_payload = transport_.last_sent_packet().payload(); |
| 1191 | generic_header = sent_payload[0]; |
pbos@webrtc.org | 8911ce4 | 2013-03-18 16:39:03 +0000 | [diff] [blame] | 1192 | EXPECT_FALSE(generic_header & RtpFormatVideoGeneric::kKeyFrameBit); |
| 1193 | EXPECT_TRUE(generic_header & RtpFormatVideoGeneric::kFirstPacketBit); |
danilchap | 96c1587 | 2016-11-21 01:35:29 -0800 | [diff] [blame] | 1194 | EXPECT_THAT(sent_payload.subview(1), ElementsAreArray(payload)); |
pbos@webrtc.org | 8911ce4 | 2013-03-18 16:39:03 +0000 | [diff] [blame] | 1195 | } |
| 1196 | |
Mirta Dvornicic | fe68daa | 2019-05-23 13:21:12 +0200 | [diff] [blame] | 1197 | TEST_P(RtpSenderTestWithoutPacer, SendRawVideo) { |
Erik Språng | 6cf554e | 2019-10-02 20:55:39 +0200 | [diff] [blame] | 1198 | const uint8_t kPayloadType = 111; |
Mirta Dvornicic | fe68daa | 2019-05-23 13:21:12 +0200 | [diff] [blame] | 1199 | const uint8_t payload[] = {11, 22, 33, 44, 55}; |
| 1200 | |
| 1201 | PlayoutDelayOracle playout_delay_oracle; |
Erik Språng | dc34a25 | 2019-10-04 15:17:29 +0200 | [diff] [blame] | 1202 | FieldTrialBasedConfig field_trials; |
| 1203 | RTPSenderVideo::Config video_config; |
| 1204 | video_config.clock = &fake_clock_; |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 1205 | video_config.rtp_sender = rtp_sender(); |
Erik Språng | dc34a25 | 2019-10-04 15:17:29 +0200 | [diff] [blame] | 1206 | video_config.playout_delay_oracle = &playout_delay_oracle; |
| 1207 | video_config.field_trials = &field_trials; |
| 1208 | RTPSenderVideo rtp_sender_video(video_config); |
Mirta Dvornicic | fe68daa | 2019-05-23 13:21:12 +0200 | [diff] [blame] | 1209 | |
| 1210 | // Send a frame. |
| 1211 | RTPVideoHeader video_header; |
Danil Chapovalov | 51bf200 | 2019-10-11 10:53:27 +0200 | [diff] [blame] | 1212 | video_header.frame_type = VideoFrameType::kVideoFrameKey; |
| 1213 | ASSERT_TRUE(rtp_sender_video.SendVideo(kPayloadType, absl::nullopt, 1234, |
| 1214 | 4321, payload, nullptr, video_header, |
| 1215 | kDefaultExpectedRetransmissionTimeMs)); |
Mirta Dvornicic | fe68daa | 2019-05-23 13:21:12 +0200 | [diff] [blame] | 1216 | |
| 1217 | auto sent_payload = transport_.last_sent_packet().payload(); |
| 1218 | EXPECT_THAT(sent_payload, ElementsAreArray(payload)); |
| 1219 | } |
| 1220 | |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 1221 | TEST_P(RtpSenderTest, SendFlexfecPackets) { |
Niels Möller | e7b9e6b | 2019-02-06 18:23:44 +0100 | [diff] [blame] | 1222 | constexpr uint32_t kTimestamp = 1234; |
brandtr | dbdb3f1 | 2016-11-10 05:04:48 -0800 | [diff] [blame] | 1223 | constexpr int kMediaPayloadType = 127; |
Erik Språng | 6cf554e | 2019-10-02 20:55:39 +0200 | [diff] [blame] | 1224 | constexpr VideoCodecType kCodecType = VideoCodecType::kVideoCodecGeneric; |
brandtr | dbdb3f1 | 2016-11-10 05:04:48 -0800 | [diff] [blame] | 1225 | constexpr int kFlexfecPayloadType = 118; |
brandtr | dbdb3f1 | 2016-11-10 05:04:48 -0800 | [diff] [blame] | 1226 | const std::vector<RtpExtension> kNoRtpExtensions; |
erikvarga | 2788373 | 2017-05-17 05:08:38 -0700 | [diff] [blame] | 1227 | const std::vector<RtpExtensionSize> kNoRtpExtensionSizes; |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 1228 | FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexFecSsrc, kSsrc, kNoMid, |
| 1229 | kNoRtpExtensions, kNoRtpExtensionSizes, |
brandtr | 48d21a2 | 2017-05-30 02:32:12 -0700 | [diff] [blame] | 1230 | nullptr /* rtp_state */, &fake_clock_); |
brandtr | dbdb3f1 | 2016-11-10 05:04:48 -0800 | [diff] [blame] | 1231 | |
| 1232 | // Reset |rtp_sender_| to use FlexFEC. |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 1233 | RtpRtcp::Configuration config; |
| 1234 | config.clock = &fake_clock_; |
| 1235 | config.outgoing_transport = &transport_; |
| 1236 | config.paced_sender = &mock_paced_sender_; |
Erik Språng | 54d5d2c | 2019-08-20 17:22:36 +0200 | [diff] [blame] | 1237 | config.local_media_ssrc = kSsrc; |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 1238 | config.flexfec_sender = &flexfec_sender_; |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 1239 | config.event_log = &mock_rtc_event_log_; |
| 1240 | config.send_packet_observer = &send_packet_observer_; |
| 1241 | config.retransmission_rate_limiter = &retransmission_rate_limiter_; |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 1242 | rtp_sender_context_ = std::make_unique<RtpSenderContext>(config); |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 1243 | |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 1244 | rtp_sender()->SetSequenceNumber(kSeqNum); |
| 1245 | rtp_sender_context_->packet_history_.SetStorePacketsStatus( |
| 1246 | RtpPacketHistory::StorageMode::kStoreAndCull, 10); |
brandtr | dbdb3f1 | 2016-11-10 05:04:48 -0800 | [diff] [blame] | 1247 | |
Niels Möller | 5fe9510 | 2019-03-04 16:49:25 +0100 | [diff] [blame] | 1248 | PlayoutDelayOracle playout_delay_oracle; |
Erik Språng | dc34a25 | 2019-10-04 15:17:29 +0200 | [diff] [blame] | 1249 | FieldTrialBasedConfig field_trials; |
| 1250 | RTPSenderVideo::Config video_config; |
| 1251 | video_config.clock = &fake_clock_; |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 1252 | video_config.rtp_sender = rtp_sender(); |
Erik Språng | dc34a25 | 2019-10-04 15:17:29 +0200 | [diff] [blame] | 1253 | video_config.flexfec_sender = &flexfec_sender; |
| 1254 | video_config.playout_delay_oracle = &playout_delay_oracle; |
| 1255 | video_config.field_trials = &field_trials; |
| 1256 | RTPSenderVideo rtp_sender_video(video_config); |
Niels Möller | e7b9e6b | 2019-02-06 18:23:44 +0100 | [diff] [blame] | 1257 | |
brandtr | dbdb3f1 | 2016-11-10 05:04:48 -0800 | [diff] [blame] | 1258 | // Parameters selected to generate a single FEC packet per media packet. |
| 1259 | FecProtectionParams params; |
| 1260 | params.fec_rate = 15; |
| 1261 | params.max_fec_frames = 1; |
| 1262 | params.fec_mask_type = kFecMaskRandom; |
Niels Möller | e7b9e6b | 2019-02-06 18:23:44 +0100 | [diff] [blame] | 1263 | rtp_sender_video.SetFecParameters(params, params); |
brandtr | dbdb3f1 | 2016-11-10 05:04:48 -0800 | [diff] [blame] | 1264 | |
brandtr | 9dfff29 | 2016-11-14 05:14:50 -0800 | [diff] [blame] | 1265 | uint16_t flexfec_seq_num; |
Niels Möller | e7b9e6b | 2019-02-06 18:23:44 +0100 | [diff] [blame] | 1266 | RTPVideoHeader video_header; |
Niels Möller | e7b9e6b | 2019-02-06 18:23:44 +0100 | [diff] [blame] | 1267 | |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 1268 | std::unique_ptr<RtpPacketToSend> media_packet; |
| 1269 | std::unique_ptr<RtpPacketToSend> fec_packet; |
| 1270 | |
Erik Språng | ea55b08 | 2019-10-02 14:57:46 +0200 | [diff] [blame] | 1271 | EXPECT_CALL(mock_paced_sender_, EnqueuePackets) |
Erik Språng | fc78aac | 2019-10-24 12:55:30 +0200 | [diff] [blame] | 1272 | .WillOnce([&](std::vector<std::unique_ptr<RtpPacketToSend>> packets) { |
| 1273 | for (auto& packet : packets) { |
| 1274 | if (packet->packet_type() == RtpPacketToSend::Type::kVideo) { |
| 1275 | EXPECT_EQ(packet->Ssrc(), kSsrc); |
| 1276 | EXPECT_EQ(packet->SequenceNumber(), kSeqNum); |
| 1277 | media_packet = std::move(packet); |
| 1278 | } else { |
| 1279 | EXPECT_EQ(packet->packet_type(), |
| 1280 | RtpPacketToSend::Type::kForwardErrorCorrection); |
| 1281 | EXPECT_EQ(packet->Ssrc(), kFlexFecSsrc); |
| 1282 | fec_packet = std::move(packet); |
| 1283 | } |
| 1284 | } |
| 1285 | }); |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 1286 | |
Danil Chapovalov | 51bf200 | 2019-10-11 10:53:27 +0200 | [diff] [blame] | 1287 | video_header.frame_type = VideoFrameType::kVideoFrameKey; |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 1288 | EXPECT_TRUE(rtp_sender_video.SendVideo( |
Danil Chapovalov | 51bf200 | 2019-10-11 10:53:27 +0200 | [diff] [blame] | 1289 | kMediaPayloadType, kCodecType, kTimestamp, |
| 1290 | fake_clock_.TimeInMilliseconds(), kPayloadData, nullptr, video_header, |
Erik Språng | 6cf554e | 2019-10-02 20:55:39 +0200 | [diff] [blame] | 1291 | kDefaultExpectedRetransmissionTimeMs)); |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 1292 | ASSERT_TRUE(media_packet != nullptr); |
| 1293 | ASSERT_TRUE(fec_packet != nullptr); |
| 1294 | |
| 1295 | flexfec_seq_num = fec_packet->SequenceNumber(); |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 1296 | rtp_egress()->SendPacket(media_packet.get(), PacedPacketInfo()); |
| 1297 | rtp_egress()->SendPacket(fec_packet.get(), PacedPacketInfo()); |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 1298 | |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 1299 | ASSERT_EQ(2, transport_.packets_sent()); |
| 1300 | const RtpPacketReceived& sent_media_packet = transport_.sent_packets_[0]; |
| 1301 | EXPECT_EQ(kMediaPayloadType, sent_media_packet.PayloadType()); |
| 1302 | EXPECT_EQ(kSeqNum, sent_media_packet.SequenceNumber()); |
| 1303 | EXPECT_EQ(kSsrc, sent_media_packet.Ssrc()); |
| 1304 | const RtpPacketReceived& sent_flexfec_packet = transport_.sent_packets_[1]; |
| 1305 | EXPECT_EQ(kFlexfecPayloadType, sent_flexfec_packet.PayloadType()); |
| 1306 | EXPECT_EQ(flexfec_seq_num, sent_flexfec_packet.SequenceNumber()); |
| 1307 | EXPECT_EQ(kFlexFecSsrc, sent_flexfec_packet.Ssrc()); |
brandtr | dbdb3f1 | 2016-11-10 05:04:48 -0800 | [diff] [blame] | 1308 | } |
| 1309 | |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 1310 | // TODO(ilnik): because of webrtc:7859. Once FEC moved below pacer, this test |
| 1311 | // should be removed. |
| 1312 | TEST_P(RtpSenderTest, NoFlexfecForTimingFrames) { |
| 1313 | constexpr uint32_t kTimestamp = 1234; |
| 1314 | const int64_t kCaptureTimeMs = fake_clock_.TimeInMilliseconds(); |
| 1315 | constexpr int kMediaPayloadType = 127; |
Erik Språng | 6cf554e | 2019-10-02 20:55:39 +0200 | [diff] [blame] | 1316 | constexpr VideoCodecType kCodecType = VideoCodecType::kVideoCodecGeneric; |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 1317 | constexpr int kFlexfecPayloadType = 118; |
| 1318 | const std::vector<RtpExtension> kNoRtpExtensions; |
| 1319 | const std::vector<RtpExtensionSize> kNoRtpExtensionSizes; |
| 1320 | |
| 1321 | FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexFecSsrc, kSsrc, kNoMid, |
| 1322 | kNoRtpExtensions, kNoRtpExtensionSizes, |
| 1323 | nullptr /* rtp_state */, &fake_clock_); |
| 1324 | |
| 1325 | // Reset |rtp_sender_| to use FlexFEC. |
Erik Språng | 630443a | 2019-07-26 16:44:55 +0200 | [diff] [blame] | 1326 | RtpRtcp::Configuration config; |
| 1327 | config.clock = &fake_clock_; |
| 1328 | config.outgoing_transport = &transport_; |
| 1329 | config.paced_sender = &mock_paced_sender_; |
| 1330 | config.flexfec_sender = &flexfec_sender; |
Erik Språng | 630443a | 2019-07-26 16:44:55 +0200 | [diff] [blame] | 1331 | config.event_log = &mock_rtc_event_log_; |
| 1332 | config.send_packet_observer = &send_packet_observer_; |
| 1333 | config.retransmission_rate_limiter = &retransmission_rate_limiter_; |
Erik Språng | 54d5d2c | 2019-08-20 17:22:36 +0200 | [diff] [blame] | 1334 | config.local_media_ssrc = kSsrc; |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 1335 | rtp_sender_context_ = std::make_unique<RtpSenderContext>(config); |
| 1336 | rtp_sender()->SetSequenceNumber(kSeqNum); |
| 1337 | rtp_sender_context_->packet_history_.SetStorePacketsStatus( |
| 1338 | RtpPacketHistory::StorageMode::kStoreAndCull, 10); |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 1339 | |
| 1340 | PlayoutDelayOracle playout_delay_oracle; |
Erik Språng | dc34a25 | 2019-10-04 15:17:29 +0200 | [diff] [blame] | 1341 | FieldTrialBasedConfig field_trials; |
| 1342 | RTPSenderVideo::Config video_config; |
| 1343 | video_config.clock = &fake_clock_; |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 1344 | video_config.rtp_sender = rtp_sender(); |
Erik Språng | dc34a25 | 2019-10-04 15:17:29 +0200 | [diff] [blame] | 1345 | video_config.flexfec_sender = &flexfec_sender; |
| 1346 | video_config.playout_delay_oracle = &playout_delay_oracle; |
| 1347 | video_config.field_trials = &field_trials; |
| 1348 | RTPSenderVideo rtp_sender_video(video_config); |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 1349 | |
| 1350 | // Need extension to be registered for timing frames to be sent. |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 1351 | ASSERT_EQ(0, rtp_sender()->RegisterRtpHeaderExtension( |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 1352 | kRtpExtensionVideoTiming, kVideoTimingExtensionId)); |
| 1353 | |
| 1354 | // Parameters selected to generate a single FEC packet per media packet. |
| 1355 | FecProtectionParams params; |
| 1356 | params.fec_rate = 15; |
| 1357 | params.max_fec_frames = 1; |
| 1358 | params.fec_mask_type = kFecMaskRandom; |
| 1359 | rtp_sender_video.SetFecParameters(params, params); |
| 1360 | |
| 1361 | RTPVideoHeader video_header; |
| 1362 | video_header.video_timing.flags = VideoSendTiming::kTriggeredByTimer; |
| 1363 | |
| 1364 | EXPECT_CALL(mock_rtc_event_log_, |
| 1365 | LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing))) |
| 1366 | .Times(1); |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 1367 | std::unique_ptr<RtpPacketToSend> rtp_packet; |
| 1368 | EXPECT_CALL( |
| 1369 | mock_paced_sender_, |
Erik Språng | ea55b08 | 2019-10-02 14:57:46 +0200 | [diff] [blame] | 1370 | EnqueuePackets(Contains(AllOf( |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 1371 | Pointee(Property(&RtpPacketToSend::Ssrc, kSsrc)), |
Erik Språng | ea55b08 | 2019-10-02 14:57:46 +0200 | [diff] [blame] | 1372 | Pointee(Property(&RtpPacketToSend::SequenceNumber, kSeqNum)))))) |
| 1373 | .WillOnce([&rtp_packet]( |
| 1374 | std::vector<std::unique_ptr<RtpPacketToSend>> packets) { |
| 1375 | EXPECT_EQ(packets.size(), 1u); |
| 1376 | rtp_packet = std::move(packets[0]); |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 1377 | }); |
| 1378 | |
Erik Språng | ea55b08 | 2019-10-02 14:57:46 +0200 | [diff] [blame] | 1379 | EXPECT_CALL(mock_paced_sender_, |
| 1380 | EnqueuePackets(Contains( |
| 1381 | Pointee(Property(&RtpPacketToSend::Ssrc, kFlexFecSsrc))))) |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 1382 | .Times(0); // Not called because packet should not be protected. |
| 1383 | |
Danil Chapovalov | 51bf200 | 2019-10-11 10:53:27 +0200 | [diff] [blame] | 1384 | video_header.frame_type = VideoFrameType::kVideoFrameKey; |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 1385 | EXPECT_TRUE(rtp_sender_video.SendVideo( |
Danil Chapovalov | 51bf200 | 2019-10-11 10:53:27 +0200 | [diff] [blame] | 1386 | kMediaPayloadType, kCodecType, kTimestamp, kCaptureTimeMs, kPayloadData, |
| 1387 | nullptr, video_header, kDefaultExpectedRetransmissionTimeMs)); |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 1388 | |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 1389 | rtp_egress()->SendPacket(rtp_packet.get(), PacedPacketInfo()); |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 1390 | |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 1391 | ASSERT_EQ(1, transport_.packets_sent()); |
| 1392 | const RtpPacketReceived& sent_media_packet1 = transport_.sent_packets_[0]; |
| 1393 | EXPECT_EQ(kMediaPayloadType, sent_media_packet1.PayloadType()); |
| 1394 | EXPECT_EQ(kSeqNum, sent_media_packet1.SequenceNumber()); |
| 1395 | EXPECT_EQ(kSsrc, sent_media_packet1.Ssrc()); |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 1396 | |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 1397 | // Now try to send not a timing frame. |
| 1398 | uint16_t flexfec_seq_num; |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 1399 | |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 1400 | EXPECT_CALL(mock_rtc_event_log_, |
| 1401 | LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing))) |
| 1402 | .Times(2); |
| 1403 | std::unique_ptr<RtpPacketToSend> media_packet2; |
| 1404 | std::unique_ptr<RtpPacketToSend> fec_packet; |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 1405 | |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 1406 | EXPECT_CALL(mock_paced_sender_, EnqueuePackets) |
| 1407 | .WillOnce([&](std::vector<std::unique_ptr<RtpPacketToSend>> packets) { |
| 1408 | for (auto& packet : packets) { |
| 1409 | if (packet->packet_type() == RtpPacketToSend::Type::kVideo) { |
| 1410 | EXPECT_EQ(packet->Ssrc(), kSsrc); |
| 1411 | EXPECT_EQ(packet->SequenceNumber(), kSeqNum + 1); |
| 1412 | media_packet2 = std::move(packet); |
| 1413 | } else { |
| 1414 | EXPECT_EQ(packet->packet_type(), |
| 1415 | RtpPacketToSend::Type::kForwardErrorCorrection); |
| 1416 | EXPECT_EQ(packet->Ssrc(), kFlexFecSsrc); |
| 1417 | fec_packet = std::move(packet); |
| 1418 | } |
Erik Språng | fc78aac | 2019-10-24 12:55:30 +0200 | [diff] [blame] | 1419 | } |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 1420 | }); |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 1421 | |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 1422 | video_header.video_timing.flags = VideoSendTiming::kInvalid; |
| 1423 | video_header.frame_type = VideoFrameType::kVideoFrameKey; |
| 1424 | EXPECT_TRUE(rtp_sender_video.SendVideo( |
| 1425 | kMediaPayloadType, kCodecType, kTimestamp + 1, kCaptureTimeMs + 1, |
| 1426 | kPayloadData, nullptr, video_header, |
| 1427 | kDefaultExpectedRetransmissionTimeMs)); |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 1428 | |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 1429 | ASSERT_TRUE(media_packet2 != nullptr); |
| 1430 | ASSERT_TRUE(fec_packet != nullptr); |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 1431 | |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 1432 | flexfec_seq_num = fec_packet->SequenceNumber(); |
| 1433 | rtp_egress()->SendPacket(media_packet2.get(), PacedPacketInfo()); |
| 1434 | rtp_egress()->SendPacket(fec_packet.get(), PacedPacketInfo()); |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 1435 | |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 1436 | ASSERT_EQ(3, transport_.packets_sent()); |
| 1437 | const RtpPacketReceived& sent_media_packet2 = transport_.sent_packets_[1]; |
| 1438 | EXPECT_EQ(kMediaPayloadType, sent_media_packet2.PayloadType()); |
| 1439 | EXPECT_EQ(kSeqNum + 1, sent_media_packet2.SequenceNumber()); |
| 1440 | EXPECT_EQ(kSsrc, sent_media_packet2.Ssrc()); |
| 1441 | const RtpPacketReceived& flexfec_packet = transport_.sent_packets_[2]; |
| 1442 | EXPECT_EQ(kFlexfecPayloadType, flexfec_packet.PayloadType()); |
| 1443 | EXPECT_EQ(flexfec_seq_num, flexfec_packet.SequenceNumber()); |
| 1444 | EXPECT_EQ(kFlexFecSsrc, flexfec_packet.Ssrc()); |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 1445 | } |
| 1446 | |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 1447 | TEST_P(RtpSenderTestWithoutPacer, SendFlexfecPackets) { |
Niels Möller | e7b9e6b | 2019-02-06 18:23:44 +0100 | [diff] [blame] | 1448 | constexpr uint32_t kTimestamp = 1234; |
brandtr | dbdb3f1 | 2016-11-10 05:04:48 -0800 | [diff] [blame] | 1449 | constexpr int kMediaPayloadType = 127; |
Erik Språng | 6cf554e | 2019-10-02 20:55:39 +0200 | [diff] [blame] | 1450 | constexpr VideoCodecType kCodecType = VideoCodecType::kVideoCodecGeneric; |
brandtr | dbdb3f1 | 2016-11-10 05:04:48 -0800 | [diff] [blame] | 1451 | constexpr int kFlexfecPayloadType = 118; |
brandtr | dbdb3f1 | 2016-11-10 05:04:48 -0800 | [diff] [blame] | 1452 | const std::vector<RtpExtension> kNoRtpExtensions; |
erikvarga | 2788373 | 2017-05-17 05:08:38 -0700 | [diff] [blame] | 1453 | const std::vector<RtpExtensionSize> kNoRtpExtensionSizes; |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 1454 | FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexFecSsrc, kSsrc, kNoMid, |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 1455 | kNoRtpExtensions, kNoRtpExtensionSizes, |
brandtr | 48d21a2 | 2017-05-30 02:32:12 -0700 | [diff] [blame] | 1456 | nullptr /* rtp_state */, &fake_clock_); |
brandtr | dbdb3f1 | 2016-11-10 05:04:48 -0800 | [diff] [blame] | 1457 | |
| 1458 | // Reset |rtp_sender_| to use FlexFEC. |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 1459 | RtpRtcp::Configuration config; |
| 1460 | config.clock = &fake_clock_; |
| 1461 | config.outgoing_transport = &transport_; |
Erik Språng | 54d5d2c | 2019-08-20 17:22:36 +0200 | [diff] [blame] | 1462 | config.local_media_ssrc = kSsrc; |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 1463 | config.flexfec_sender = &flexfec_sender; |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 1464 | config.event_log = &mock_rtc_event_log_; |
| 1465 | config.send_packet_observer = &send_packet_observer_; |
| 1466 | config.retransmission_rate_limiter = &retransmission_rate_limiter_; |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 1467 | rtp_sender_context_ = std::make_unique<RtpSenderContext>(config); |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 1468 | |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 1469 | rtp_sender()->SetSequenceNumber(kSeqNum); |
brandtr | dbdb3f1 | 2016-11-10 05:04:48 -0800 | [diff] [blame] | 1470 | |
Niels Möller | 5fe9510 | 2019-03-04 16:49:25 +0100 | [diff] [blame] | 1471 | PlayoutDelayOracle playout_delay_oracle; |
Erik Språng | dc34a25 | 2019-10-04 15:17:29 +0200 | [diff] [blame] | 1472 | FieldTrialBasedConfig field_trials; |
| 1473 | RTPSenderVideo::Config video_config; |
| 1474 | video_config.clock = &fake_clock_; |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 1475 | video_config.rtp_sender = rtp_sender(); |
Erik Språng | dc34a25 | 2019-10-04 15:17:29 +0200 | [diff] [blame] | 1476 | video_config.flexfec_sender = &flexfec_sender; |
| 1477 | video_config.playout_delay_oracle = &playout_delay_oracle; |
| 1478 | video_config.field_trials = &field_trials; |
| 1479 | RTPSenderVideo rtp_sender_video(video_config); |
Niels Möller | e7b9e6b | 2019-02-06 18:23:44 +0100 | [diff] [blame] | 1480 | |
brandtr | dbdb3f1 | 2016-11-10 05:04:48 -0800 | [diff] [blame] | 1481 | // Parameters selected to generate a single FEC packet per media packet. |
| 1482 | FecProtectionParams params; |
| 1483 | params.fec_rate = 15; |
| 1484 | params.max_fec_frames = 1; |
| 1485 | params.fec_mask_type = kFecMaskRandom; |
Niels Möller | e7b9e6b | 2019-02-06 18:23:44 +0100 | [diff] [blame] | 1486 | rtp_sender_video.SetFecParameters(params, params); |
brandtr | dbdb3f1 | 2016-11-10 05:04:48 -0800 | [diff] [blame] | 1487 | |
Elad Alon | 4a87e1c | 2017-10-03 16:11:34 +0200 | [diff] [blame] | 1488 | EXPECT_CALL(mock_rtc_event_log_, |
| 1489 | LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing))) |
| 1490 | .Times(2); |
Niels Möller | e7b9e6b | 2019-02-06 18:23:44 +0100 | [diff] [blame] | 1491 | RTPVideoHeader video_header; |
Danil Chapovalov | 51bf200 | 2019-10-11 10:53:27 +0200 | [diff] [blame] | 1492 | video_header.frame_type = VideoFrameType::kVideoFrameKey; |
Niels Möller | e7b9e6b | 2019-02-06 18:23:44 +0100 | [diff] [blame] | 1493 | EXPECT_TRUE(rtp_sender_video.SendVideo( |
Danil Chapovalov | 51bf200 | 2019-10-11 10:53:27 +0200 | [diff] [blame] | 1494 | kMediaPayloadType, kCodecType, kTimestamp, |
| 1495 | fake_clock_.TimeInMilliseconds(), kPayloadData, nullptr, video_header, |
| 1496 | kDefaultExpectedRetransmissionTimeMs)); |
Niels Möller | e7b9e6b | 2019-02-06 18:23:44 +0100 | [diff] [blame] | 1497 | |
brandtr | dbdb3f1 | 2016-11-10 05:04:48 -0800 | [diff] [blame] | 1498 | ASSERT_EQ(2, transport_.packets_sent()); |
| 1499 | const RtpPacketReceived& media_packet = transport_.sent_packets_[0]; |
| 1500 | EXPECT_EQ(kMediaPayloadType, media_packet.PayloadType()); |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 1501 | EXPECT_EQ(kSsrc, media_packet.Ssrc()); |
brandtr | dbdb3f1 | 2016-11-10 05:04:48 -0800 | [diff] [blame] | 1502 | const RtpPacketReceived& flexfec_packet = transport_.sent_packets_[1]; |
| 1503 | EXPECT_EQ(kFlexfecPayloadType, flexfec_packet.PayloadType()); |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 1504 | EXPECT_EQ(kFlexFecSsrc, flexfec_packet.Ssrc()); |
brandtr | dbdb3f1 | 2016-11-10 05:04:48 -0800 | [diff] [blame] | 1505 | } |
| 1506 | |
Steve Anton | 296a0ce | 2018-03-22 15:17:27 -0700 | [diff] [blame] | 1507 | // Test that the MID header extension is included on sent packets when |
| 1508 | // configured. |
| 1509 | TEST_P(RtpSenderTestWithoutPacer, MidIncludedOnSentPackets) { |
| 1510 | const char kMid[] = "mid"; |
| 1511 | |
Steve Anton | 2bac7da | 2019-07-21 15:04:21 -0400 | [diff] [blame] | 1512 | EnableMidSending(kMid); |
Steve Anton | 296a0ce | 2018-03-22 15:17:27 -0700 | [diff] [blame] | 1513 | |
| 1514 | // Send a couple packets. |
Niels Möller | e7b9e6b | 2019-02-06 18:23:44 +0100 | [diff] [blame] | 1515 | SendGenericPacket(); |
| 1516 | SendGenericPacket(); |
Steve Anton | 296a0ce | 2018-03-22 15:17:27 -0700 | [diff] [blame] | 1517 | |
| 1518 | // Expect both packets to have the MID set. |
| 1519 | ASSERT_EQ(2u, transport_.sent_packets_.size()); |
| 1520 | for (const RtpPacketReceived& packet : transport_.sent_packets_) { |
| 1521 | std::string mid; |
| 1522 | ASSERT_TRUE(packet.GetExtension<RtpMid>(&mid)); |
| 1523 | EXPECT_EQ(kMid, mid); |
| 1524 | } |
| 1525 | } |
| 1526 | |
Amit Hilbuch | 77938e6 | 2018-12-21 09:23:38 -0800 | [diff] [blame] | 1527 | TEST_P(RtpSenderTestWithoutPacer, RidIncludedOnSentPackets) { |
| 1528 | const char kRid[] = "f"; |
| 1529 | |
Steve Anton | 2bac7da | 2019-07-21 15:04:21 -0400 | [diff] [blame] | 1530 | EnableRidSending(kRid); |
Amit Hilbuch | 77938e6 | 2018-12-21 09:23:38 -0800 | [diff] [blame] | 1531 | |
Niels Möller | e7b9e6b | 2019-02-06 18:23:44 +0100 | [diff] [blame] | 1532 | SendGenericPacket(); |
Amit Hilbuch | 77938e6 | 2018-12-21 09:23:38 -0800 | [diff] [blame] | 1533 | |
| 1534 | ASSERT_EQ(1u, transport_.sent_packets_.size()); |
| 1535 | const RtpPacketReceived& packet = transport_.sent_packets_[0]; |
| 1536 | std::string rid; |
| 1537 | ASSERT_TRUE(packet.GetExtension<RtpStreamId>(&rid)); |
| 1538 | EXPECT_EQ(kRid, rid); |
| 1539 | } |
| 1540 | |
| 1541 | TEST_P(RtpSenderTestWithoutPacer, RidIncludedOnRtxSentPackets) { |
| 1542 | const char kRid[] = "f"; |
Amit Hilbuch | 77938e6 | 2018-12-21 09:23:38 -0800 | [diff] [blame] | 1543 | |
Steve Anton | 2bac7da | 2019-07-21 15:04:21 -0400 | [diff] [blame] | 1544 | EnableRtx(); |
| 1545 | EnableRidSending(kRid); |
Amit Hilbuch | 77938e6 | 2018-12-21 09:23:38 -0800 | [diff] [blame] | 1546 | |
Niels Möller | e7b9e6b | 2019-02-06 18:23:44 +0100 | [diff] [blame] | 1547 | SendGenericPacket(); |
Amit Hilbuch | 77938e6 | 2018-12-21 09:23:38 -0800 | [diff] [blame] | 1548 | ASSERT_EQ(1u, transport_.sent_packets_.size()); |
| 1549 | const RtpPacketReceived& packet = transport_.sent_packets_[0]; |
| 1550 | std::string rid; |
| 1551 | ASSERT_TRUE(packet.GetExtension<RtpStreamId>(&rid)); |
| 1552 | EXPECT_EQ(kRid, rid); |
| 1553 | rid = kNoRid; |
Steve Anton | 2bac7da | 2019-07-21 15:04:21 -0400 | [diff] [blame] | 1554 | EXPECT_FALSE(packet.HasExtension<RepairedRtpStreamId>()); |
Amit Hilbuch | 77938e6 | 2018-12-21 09:23:38 -0800 | [diff] [blame] | 1555 | |
| 1556 | uint16_t packet_id = packet.SequenceNumber(); |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 1557 | rtp_sender()->ReSendPacket(packet_id); |
Amit Hilbuch | 77938e6 | 2018-12-21 09:23:38 -0800 | [diff] [blame] | 1558 | ASSERT_EQ(2u, transport_.sent_packets_.size()); |
| 1559 | const RtpPacketReceived& rtx_packet = transport_.sent_packets_[1]; |
| 1560 | ASSERT_TRUE(rtx_packet.GetExtension<RepairedRtpStreamId>(&rid)); |
| 1561 | EXPECT_EQ(kRid, rid); |
| 1562 | EXPECT_FALSE(rtx_packet.HasExtension<RtpStreamId>()); |
| 1563 | } |
| 1564 | |
Steve Anton | 2bac7da | 2019-07-21 15:04:21 -0400 | [diff] [blame] | 1565 | TEST_P(RtpSenderTestWithoutPacer, MidAndRidNotIncludedOnSentPacketsAfterAck) { |
| 1566 | const char kMid[] = "mid"; |
| 1567 | const char kRid[] = "f"; |
| 1568 | |
| 1569 | EnableMidSending(kMid); |
| 1570 | EnableRidSending(kRid); |
| 1571 | |
| 1572 | // This first packet should include both MID and RID. |
| 1573 | auto first_built_packet = SendGenericPacket(); |
| 1574 | |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 1575 | rtp_sender()->OnReceivedAckOnSsrc(first_built_packet->SequenceNumber()); |
Steve Anton | 2bac7da | 2019-07-21 15:04:21 -0400 | [diff] [blame] | 1576 | |
| 1577 | // The second packet should include neither since an ack was received. |
| 1578 | SendGenericPacket(); |
| 1579 | |
| 1580 | ASSERT_EQ(2u, transport_.sent_packets_.size()); |
| 1581 | |
| 1582 | const RtpPacketReceived& first_packet = transport_.sent_packets_[0]; |
| 1583 | std::string mid, rid; |
| 1584 | ASSERT_TRUE(first_packet.GetExtension<RtpMid>(&mid)); |
| 1585 | EXPECT_EQ(kMid, mid); |
| 1586 | ASSERT_TRUE(first_packet.GetExtension<RtpStreamId>(&rid)); |
| 1587 | EXPECT_EQ(kRid, rid); |
| 1588 | |
| 1589 | const RtpPacketReceived& second_packet = transport_.sent_packets_[1]; |
| 1590 | EXPECT_FALSE(second_packet.HasExtension<RtpMid>()); |
| 1591 | EXPECT_FALSE(second_packet.HasExtension<RtpStreamId>()); |
| 1592 | } |
| 1593 | |
| 1594 | // Test that the first RTX packet includes both MID and RRID even if the packet |
| 1595 | // being retransmitted did not have MID or RID. The MID and RID are needed on |
| 1596 | // the first packets for a given SSRC, and RTX packets are sent on a separate |
| 1597 | // SSRC. |
| 1598 | TEST_P(RtpSenderTestWithoutPacer, MidAndRidIncludedOnFirstRtxPacket) { |
| 1599 | const char kMid[] = "mid"; |
| 1600 | const char kRid[] = "f"; |
| 1601 | |
| 1602 | EnableRtx(); |
| 1603 | EnableMidSending(kMid); |
| 1604 | EnableRidSending(kRid); |
| 1605 | |
| 1606 | // This first packet will include both MID and RID. |
| 1607 | auto first_built_packet = SendGenericPacket(); |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 1608 | rtp_sender()->OnReceivedAckOnSsrc(first_built_packet->SequenceNumber()); |
Steve Anton | 2bac7da | 2019-07-21 15:04:21 -0400 | [diff] [blame] | 1609 | |
| 1610 | // The second packet will include neither since an ack was received. |
| 1611 | auto second_built_packet = SendGenericPacket(); |
| 1612 | |
| 1613 | // The first RTX packet should include MID and RRID. |
| 1614 | ASSERT_LT(0, |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 1615 | rtp_sender()->ReSendPacket(second_built_packet->SequenceNumber())); |
Steve Anton | 2bac7da | 2019-07-21 15:04:21 -0400 | [diff] [blame] | 1616 | |
| 1617 | ASSERT_EQ(3u, transport_.sent_packets_.size()); |
| 1618 | |
| 1619 | const RtpPacketReceived& rtx_packet = transport_.sent_packets_[2]; |
| 1620 | std::string mid, rrid; |
| 1621 | ASSERT_TRUE(rtx_packet.GetExtension<RtpMid>(&mid)); |
| 1622 | EXPECT_EQ(kMid, mid); |
| 1623 | ASSERT_TRUE(rtx_packet.GetExtension<RepairedRtpStreamId>(&rrid)); |
| 1624 | EXPECT_EQ(kRid, rrid); |
| 1625 | } |
| 1626 | |
| 1627 | // Test that the RTX packets sent after receving an ACK on the RTX SSRC does |
| 1628 | // not include either MID or RRID even if the packet being retransmitted did |
| 1629 | // had a MID or RID. |
| 1630 | TEST_P(RtpSenderTestWithoutPacer, MidAndRidNotIncludedOnRtxPacketsAfterAck) { |
| 1631 | const char kMid[] = "mid"; |
| 1632 | const char kRid[] = "f"; |
| 1633 | |
| 1634 | EnableRtx(); |
| 1635 | EnableMidSending(kMid); |
| 1636 | EnableRidSending(kRid); |
| 1637 | |
| 1638 | // This first packet will include both MID and RID. |
| 1639 | auto first_built_packet = SendGenericPacket(); |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 1640 | rtp_sender()->OnReceivedAckOnSsrc(first_built_packet->SequenceNumber()); |
Steve Anton | 2bac7da | 2019-07-21 15:04:21 -0400 | [diff] [blame] | 1641 | |
| 1642 | // The second packet will include neither since an ack was received. |
| 1643 | auto second_built_packet = SendGenericPacket(); |
| 1644 | |
| 1645 | // The first RTX packet will include MID and RRID. |
| 1646 | ASSERT_LT(0, |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 1647 | rtp_sender()->ReSendPacket(second_built_packet->SequenceNumber())); |
Steve Anton | 2bac7da | 2019-07-21 15:04:21 -0400 | [diff] [blame] | 1648 | |
| 1649 | ASSERT_EQ(3u, transport_.sent_packets_.size()); |
| 1650 | const RtpPacketReceived& first_rtx_packet = transport_.sent_packets_[2]; |
| 1651 | |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 1652 | rtp_sender()->OnReceivedAckOnRtxSsrc(first_rtx_packet.SequenceNumber()); |
Steve Anton | 2bac7da | 2019-07-21 15:04:21 -0400 | [diff] [blame] | 1653 | |
| 1654 | // The second and third RTX packets should not include MID nor RRID. |
Steve Anton | 2bac7da | 2019-07-21 15:04:21 -0400 | [diff] [blame] | 1655 | ASSERT_LT(0, |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 1656 | rtp_sender()->ReSendPacket(first_built_packet->SequenceNumber())); |
| 1657 | ASSERT_LT(0, |
| 1658 | rtp_sender()->ReSendPacket(second_built_packet->SequenceNumber())); |
Steve Anton | 2bac7da | 2019-07-21 15:04:21 -0400 | [diff] [blame] | 1659 | |
| 1660 | ASSERT_EQ(5u, transport_.sent_packets_.size()); |
| 1661 | |
| 1662 | const RtpPacketReceived& second_rtx_packet = transport_.sent_packets_[3]; |
| 1663 | EXPECT_FALSE(second_rtx_packet.HasExtension<RtpMid>()); |
| 1664 | EXPECT_FALSE(second_rtx_packet.HasExtension<RepairedRtpStreamId>()); |
| 1665 | |
| 1666 | const RtpPacketReceived& third_rtx_packet = transport_.sent_packets_[4]; |
| 1667 | EXPECT_FALSE(third_rtx_packet.HasExtension<RtpMid>()); |
| 1668 | EXPECT_FALSE(third_rtx_packet.HasExtension<RepairedRtpStreamId>()); |
| 1669 | } |
| 1670 | |
| 1671 | // Test that if the RtpState indicates an ACK has been received on that SSRC |
| 1672 | // then neither the MID nor RID header extensions will be sent. |
| 1673 | TEST_P(RtpSenderTestWithoutPacer, |
| 1674 | MidAndRidNotIncludedOnSentPacketsAfterRtpStateRestored) { |
| 1675 | const char kMid[] = "mid"; |
| 1676 | const char kRid[] = "f"; |
| 1677 | |
| 1678 | EnableMidSending(kMid); |
| 1679 | EnableRidSending(kRid); |
| 1680 | |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 1681 | RtpState state = rtp_sender()->GetRtpState(); |
Steve Anton | 2bac7da | 2019-07-21 15:04:21 -0400 | [diff] [blame] | 1682 | EXPECT_FALSE(state.ssrc_has_acked); |
| 1683 | state.ssrc_has_acked = true; |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 1684 | rtp_sender()->SetRtpState(state); |
Steve Anton | 2bac7da | 2019-07-21 15:04:21 -0400 | [diff] [blame] | 1685 | |
| 1686 | SendGenericPacket(); |
| 1687 | |
| 1688 | ASSERT_EQ(1u, transport_.sent_packets_.size()); |
| 1689 | const RtpPacketReceived& packet = transport_.sent_packets_[0]; |
| 1690 | EXPECT_FALSE(packet.HasExtension<RtpMid>()); |
| 1691 | EXPECT_FALSE(packet.HasExtension<RtpStreamId>()); |
| 1692 | } |
| 1693 | |
| 1694 | // Test that if the RTX RtpState indicates an ACK has been received on that |
| 1695 | // RTX SSRC then neither the MID nor RRID header extensions will be sent on |
| 1696 | // RTX packets. |
| 1697 | TEST_P(RtpSenderTestWithoutPacer, |
| 1698 | MidAndRridNotIncludedOnRtxPacketsAfterRtpStateRestored) { |
| 1699 | const char kMid[] = "mid"; |
| 1700 | const char kRid[] = "f"; |
| 1701 | |
| 1702 | EnableRtx(); |
| 1703 | EnableMidSending(kMid); |
| 1704 | EnableRidSending(kRid); |
| 1705 | |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 1706 | RtpState rtx_state = rtp_sender()->GetRtxRtpState(); |
Steve Anton | 2bac7da | 2019-07-21 15:04:21 -0400 | [diff] [blame] | 1707 | EXPECT_FALSE(rtx_state.ssrc_has_acked); |
| 1708 | rtx_state.ssrc_has_acked = true; |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 1709 | rtp_sender()->SetRtxRtpState(rtx_state); |
Steve Anton | 2bac7da | 2019-07-21 15:04:21 -0400 | [diff] [blame] | 1710 | |
| 1711 | auto built_packet = SendGenericPacket(); |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 1712 | ASSERT_LT(0, rtp_sender()->ReSendPacket(built_packet->SequenceNumber())); |
Steve Anton | 2bac7da | 2019-07-21 15:04:21 -0400 | [diff] [blame] | 1713 | |
| 1714 | ASSERT_EQ(2u, transport_.sent_packets_.size()); |
| 1715 | const RtpPacketReceived& rtx_packet = transport_.sent_packets_[1]; |
| 1716 | EXPECT_FALSE(rtx_packet.HasExtension<RtpMid>()); |
| 1717 | EXPECT_FALSE(rtx_packet.HasExtension<RepairedRtpStreamId>()); |
| 1718 | } |
| 1719 | |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 1720 | TEST_P(RtpSenderTest, FecOverheadRate) { |
Niels Möller | e7b9e6b | 2019-02-06 18:23:44 +0100 | [diff] [blame] | 1721 | constexpr uint32_t kTimestamp = 1234; |
| 1722 | constexpr int kMediaPayloadType = 127; |
Erik Språng | 6cf554e | 2019-10-02 20:55:39 +0200 | [diff] [blame] | 1723 | constexpr VideoCodecType kCodecType = VideoCodecType::kVideoCodecGeneric; |
brandtr | 81eab61 | 2017-01-24 04:06:09 -0800 | [diff] [blame] | 1724 | constexpr int kFlexfecPayloadType = 118; |
brandtr | 81eab61 | 2017-01-24 04:06:09 -0800 | [diff] [blame] | 1725 | const std::vector<RtpExtension> kNoRtpExtensions; |
erikvarga | 2788373 | 2017-05-17 05:08:38 -0700 | [diff] [blame] | 1726 | const std::vector<RtpExtensionSize> kNoRtpExtensionSizes; |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 1727 | FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexFecSsrc, kSsrc, kNoMid, |
| 1728 | kNoRtpExtensions, kNoRtpExtensionSizes, |
brandtr | 48d21a2 | 2017-05-30 02:32:12 -0700 | [diff] [blame] | 1729 | nullptr /* rtp_state */, &fake_clock_); |
brandtr | 81eab61 | 2017-01-24 04:06:09 -0800 | [diff] [blame] | 1730 | |
| 1731 | // Reset |rtp_sender_| to use FlexFEC. |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 1732 | RtpRtcp::Configuration config; |
| 1733 | config.clock = &fake_clock_; |
| 1734 | config.outgoing_transport = &transport_; |
| 1735 | config.paced_sender = &mock_paced_sender_; |
Erik Språng | 54d5d2c | 2019-08-20 17:22:36 +0200 | [diff] [blame] | 1736 | config.local_media_ssrc = kSsrc; |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 1737 | config.flexfec_sender = &flexfec_sender; |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 1738 | config.event_log = &mock_rtc_event_log_; |
| 1739 | config.send_packet_observer = &send_packet_observer_; |
| 1740 | config.retransmission_rate_limiter = &retransmission_rate_limiter_; |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 1741 | rtp_sender_context_ = std::make_unique<RtpSenderContext>(config); |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 1742 | |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 1743 | rtp_sender()->SetSequenceNumber(kSeqNum); |
brandtr | 81eab61 | 2017-01-24 04:06:09 -0800 | [diff] [blame] | 1744 | |
Niels Möller | 5fe9510 | 2019-03-04 16:49:25 +0100 | [diff] [blame] | 1745 | PlayoutDelayOracle playout_delay_oracle; |
Erik Språng | dc34a25 | 2019-10-04 15:17:29 +0200 | [diff] [blame] | 1746 | FieldTrialBasedConfig field_trials; |
| 1747 | RTPSenderVideo::Config video_config; |
| 1748 | video_config.clock = &fake_clock_; |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 1749 | video_config.rtp_sender = rtp_sender(); |
Erik Språng | dc34a25 | 2019-10-04 15:17:29 +0200 | [diff] [blame] | 1750 | video_config.flexfec_sender = &flexfec_sender; |
| 1751 | video_config.playout_delay_oracle = &playout_delay_oracle; |
| 1752 | video_config.field_trials = &field_trials; |
| 1753 | RTPSenderVideo rtp_sender_video(video_config); |
brandtr | 81eab61 | 2017-01-24 04:06:09 -0800 | [diff] [blame] | 1754 | // Parameters selected to generate a single FEC packet per media packet. |
| 1755 | FecProtectionParams params; |
| 1756 | params.fec_rate = 15; |
| 1757 | params.max_fec_frames = 1; |
| 1758 | params.fec_mask_type = kFecMaskRandom; |
Niels Möller | e7b9e6b | 2019-02-06 18:23:44 +0100 | [diff] [blame] | 1759 | rtp_sender_video.SetFecParameters(params, params); |
brandtr | 81eab61 | 2017-01-24 04:06:09 -0800 | [diff] [blame] | 1760 | |
| 1761 | constexpr size_t kNumMediaPackets = 10; |
| 1762 | constexpr size_t kNumFecPackets = kNumMediaPackets; |
| 1763 | constexpr int64_t kTimeBetweenPacketsMs = 10; |
Erik Språng | fc78aac | 2019-10-24 12:55:30 +0200 | [diff] [blame] | 1764 | EXPECT_CALL(mock_paced_sender_, EnqueuePackets).Times(kNumMediaPackets); |
brandtr | 81eab61 | 2017-01-24 04:06:09 -0800 | [diff] [blame] | 1765 | for (size_t i = 0; i < kNumMediaPackets; ++i) { |
Niels Möller | e7b9e6b | 2019-02-06 18:23:44 +0100 | [diff] [blame] | 1766 | RTPVideoHeader video_header; |
| 1767 | |
Danil Chapovalov | 51bf200 | 2019-10-11 10:53:27 +0200 | [diff] [blame] | 1768 | video_header.frame_type = VideoFrameType::kVideoFrameKey; |
Niels Möller | e7b9e6b | 2019-02-06 18:23:44 +0100 | [diff] [blame] | 1769 | EXPECT_TRUE(rtp_sender_video.SendVideo( |
Danil Chapovalov | 51bf200 | 2019-10-11 10:53:27 +0200 | [diff] [blame] | 1770 | kMediaPayloadType, kCodecType, kTimestamp, |
| 1771 | fake_clock_.TimeInMilliseconds(), kPayloadData, nullptr, video_header, |
Erik Språng | 6cf554e | 2019-10-02 20:55:39 +0200 | [diff] [blame] | 1772 | kDefaultExpectedRetransmissionTimeMs)); |
Niels Möller | e7b9e6b | 2019-02-06 18:23:44 +0100 | [diff] [blame] | 1773 | |
brandtr | 81eab61 | 2017-01-24 04:06:09 -0800 | [diff] [blame] | 1774 | fake_clock_.AdvanceTimeMilliseconds(kTimeBetweenPacketsMs); |
| 1775 | } |
| 1776 | constexpr size_t kRtpHeaderLength = 12; |
| 1777 | constexpr size_t kFlexfecHeaderLength = 20; |
| 1778 | constexpr size_t kGenericCodecHeaderLength = 1; |
| 1779 | constexpr size_t kPayloadLength = sizeof(kPayloadData); |
| 1780 | constexpr size_t kPacketLength = kRtpHeaderLength + kFlexfecHeaderLength + |
| 1781 | kGenericCodecHeaderLength + kPayloadLength; |
| 1782 | EXPECT_NEAR(kNumFecPackets * kPacketLength * 8 / |
| 1783 | (kNumFecPackets * kTimeBetweenPacketsMs / 1000.0f), |
Niels Möller | e7b9e6b | 2019-02-06 18:23:44 +0100 | [diff] [blame] | 1784 | rtp_sender_video.FecOverheadRate(), 500); |
brandtr | 81eab61 | 2017-01-24 04:06:09 -0800 | [diff] [blame] | 1785 | } |
| 1786 | |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 1787 | TEST_P(RtpSenderTest, BitrateCallbacks) { |
sprang@webrtc.org | 6811b6e | 2013-12-13 09:46:59 +0000 | [diff] [blame] | 1788 | class TestCallback : public BitrateStatisticsObserver { |
| 1789 | public: |
sprang | cd349d9 | 2016-07-13 09:11:28 -0700 | [diff] [blame] | 1790 | TestCallback() |
| 1791 | : BitrateStatisticsObserver(), |
| 1792 | num_calls_(0), |
| 1793 | ssrc_(0), |
| 1794 | total_bitrate_(0), |
| 1795 | retransmit_bitrate_(0) {} |
Danil Chapovalov | dd7e284 | 2018-03-09 15:37:03 +0000 | [diff] [blame] | 1796 | ~TestCallback() override = default; |
sprang@webrtc.org | 6811b6e | 2013-12-13 09:46:59 +0000 | [diff] [blame] | 1797 | |
sprang | cd349d9 | 2016-07-13 09:11:28 -0700 | [diff] [blame] | 1798 | void Notify(uint32_t total_bitrate, |
| 1799 | uint32_t retransmit_bitrate, |
kjellander@webrtc.org | 14665ff | 2015-03-04 12:58:35 +0000 | [diff] [blame] | 1800 | uint32_t ssrc) override { |
sprang@webrtc.org | 6811b6e | 2013-12-13 09:46:59 +0000 | [diff] [blame] | 1801 | ++num_calls_; |
| 1802 | ssrc_ = ssrc; |
sprang | cd349d9 | 2016-07-13 09:11:28 -0700 | [diff] [blame] | 1803 | total_bitrate_ = total_bitrate; |
| 1804 | retransmit_bitrate_ = retransmit_bitrate; |
sprang@webrtc.org | 6811b6e | 2013-12-13 09:46:59 +0000 | [diff] [blame] | 1805 | } |
| 1806 | |
| 1807 | uint32_t num_calls_; |
| 1808 | uint32_t ssrc_; |
sprang | cd349d9 | 2016-07-13 09:11:28 -0700 | [diff] [blame] | 1809 | uint32_t total_bitrate_; |
| 1810 | uint32_t retransmit_bitrate_; |
sprang@webrtc.org | 6811b6e | 2013-12-13 09:46:59 +0000 | [diff] [blame] | 1811 | } callback; |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 1812 | |
| 1813 | RtpRtcp::Configuration config; |
| 1814 | config.clock = &fake_clock_; |
| 1815 | config.outgoing_transport = &transport_; |
Erik Språng | 54d5d2c | 2019-08-20 17:22:36 +0200 | [diff] [blame] | 1816 | config.local_media_ssrc = kSsrc; |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 1817 | config.send_bitrate_observer = &callback; |
| 1818 | config.retransmission_rate_limiter = &retransmission_rate_limiter_; |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 1819 | rtp_sender_context_ = std::make_unique<RtpSenderContext>(config); |
sprang@webrtc.org | 6811b6e | 2013-12-13 09:46:59 +0000 | [diff] [blame] | 1820 | |
Niels Möller | 5fe9510 | 2019-03-04 16:49:25 +0100 | [diff] [blame] | 1821 | PlayoutDelayOracle playout_delay_oracle; |
Erik Språng | dc34a25 | 2019-10-04 15:17:29 +0200 | [diff] [blame] | 1822 | FieldTrialBasedConfig field_trials; |
| 1823 | RTPSenderVideo::Config video_config; |
| 1824 | video_config.clock = &fake_clock_; |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 1825 | video_config.rtp_sender = rtp_sender(); |
Erik Språng | dc34a25 | 2019-10-04 15:17:29 +0200 | [diff] [blame] | 1826 | video_config.playout_delay_oracle = &playout_delay_oracle; |
| 1827 | video_config.field_trials = &field_trials; |
| 1828 | RTPSenderVideo rtp_sender_video(video_config); |
Erik Språng | 6cf554e | 2019-10-02 20:55:39 +0200 | [diff] [blame] | 1829 | const VideoCodecType kCodecType = VideoCodecType::kVideoCodecGeneric; |
| 1830 | const uint8_t kPayloadType = 127; |
Niels Möller | 59ab1cf | 2019-02-06 22:48:11 +0100 | [diff] [blame] | 1831 | |
sprang | cd349d9 | 2016-07-13 09:11:28 -0700 | [diff] [blame] | 1832 | // Simulate kNumPackets sent with kPacketInterval ms intervals, with the |
| 1833 | // number of packets selected so that we fill (but don't overflow) the one |
| 1834 | // second averaging window. |
| 1835 | const uint32_t kWindowSizeMs = 1000; |
sprang@webrtc.org | 6811b6e | 2013-12-13 09:46:59 +0000 | [diff] [blame] | 1836 | const uint32_t kPacketInterval = 20; |
sprang | cd349d9 | 2016-07-13 09:11:28 -0700 | [diff] [blame] | 1837 | const uint32_t kNumPackets = |
| 1838 | (kWindowSizeMs - kPacketInterval) / kPacketInterval; |
sprang@webrtc.org | 6811b6e | 2013-12-13 09:46:59 +0000 | [diff] [blame] | 1839 | // Overhead = 12 bytes RTP header + 1 byte generic header. |
| 1840 | const uint32_t kPacketOverhead = 13; |
| 1841 | |
sprang@webrtc.org | 6811b6e | 2013-12-13 09:46:59 +0000 | [diff] [blame] | 1842 | uint8_t payload[] = {47, 11, 32, 93, 89}; |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 1843 | rtp_sender_context_->packet_history_.SetStorePacketsStatus( |
| 1844 | RtpPacketHistory::StorageMode::kStoreAndCull, 1); |
| 1845 | uint32_t ssrc = rtp_sender()->SSRC(); |
sprang@webrtc.org | 6811b6e | 2013-12-13 09:46:59 +0000 | [diff] [blame] | 1846 | |
sprang@webrtc.org | 6811b6e | 2013-12-13 09:46:59 +0000 | [diff] [blame] | 1847 | // Initial process call so we get a new time window. |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 1848 | rtp_egress()->ProcessBitrateAndNotifyObservers(); |
sprang@webrtc.org | 6811b6e | 2013-12-13 09:46:59 +0000 | [diff] [blame] | 1849 | |
| 1850 | // Send a few frames. |
Sami Kalliomäki | 426a80c | 2018-08-08 11:37:59 +0200 | [diff] [blame] | 1851 | RTPVideoHeader video_header; |
sprang@webrtc.org | 6811b6e | 2013-12-13 09:46:59 +0000 | [diff] [blame] | 1852 | for (uint32_t i = 0; i < kNumPackets; ++i) { |
Danil Chapovalov | 51bf200 | 2019-10-11 10:53:27 +0200 | [diff] [blame] | 1853 | video_header.frame_type = VideoFrameType::kVideoFrameKey; |
Niels Möller | 59ab1cf | 2019-02-06 22:48:11 +0100 | [diff] [blame] | 1854 | ASSERT_TRUE(rtp_sender_video.SendVideo( |
Danil Chapovalov | 51bf200 | 2019-10-11 10:53:27 +0200 | [diff] [blame] | 1855 | kPayloadType, kCodecType, 1234, 4321, payload, nullptr, video_header, |
Niels Möller | 8f7ce22 | 2019-03-21 15:43:58 +0100 | [diff] [blame] | 1856 | kDefaultExpectedRetransmissionTimeMs)); |
sprang@webrtc.org | 6811b6e | 2013-12-13 09:46:59 +0000 | [diff] [blame] | 1857 | fake_clock_.AdvanceTimeMilliseconds(kPacketInterval); |
| 1858 | } |
| 1859 | |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 1860 | rtp_egress()->ProcessBitrateAndNotifyObservers(); |
sprang@webrtc.org | 6811b6e | 2013-12-13 09:46:59 +0000 | [diff] [blame] | 1861 | |
stefan@webrtc.org | 0bae1fa | 2014-11-05 14:05:29 +0000 | [diff] [blame] | 1862 | // We get one call for every stats updated, thus two calls since both the |
| 1863 | // stream stats and the retransmit stats are updated once. |
| 1864 | EXPECT_EQ(2u, callback.num_calls_); |
sprang@webrtc.org | 6811b6e | 2013-12-13 09:46:59 +0000 | [diff] [blame] | 1865 | EXPECT_EQ(ssrc, callback.ssrc_); |
sprang | cd349d9 | 2016-07-13 09:11:28 -0700 | [diff] [blame] | 1866 | const uint32_t kTotalPacketSize = kPacketOverhead + sizeof(payload); |
| 1867 | // Bitrate measured over delta between last and first timestamp, plus one. |
| 1868 | const uint32_t kExpectedWindowMs = kNumPackets * kPacketInterval + 1; |
| 1869 | const uint32_t kExpectedBitsAccumulated = kTotalPacketSize * kNumPackets * 8; |
| 1870 | const uint32_t kExpectedRateBps = |
| 1871 | (kExpectedBitsAccumulated * 1000 + (kExpectedWindowMs / 2)) / |
| 1872 | kExpectedWindowMs; |
| 1873 | EXPECT_EQ(kExpectedRateBps, callback.total_bitrate_); |
sprang@webrtc.org | 6811b6e | 2013-12-13 09:46:59 +0000 | [diff] [blame] | 1874 | } |
| 1875 | |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 1876 | TEST_P(RtpSenderTestWithoutPacer, StreamDataCountersCallbacks) { |
Erik Språng | 6cf554e | 2019-10-02 20:55:39 +0200 | [diff] [blame] | 1877 | const uint8_t kPayloadType = 127; |
| 1878 | const VideoCodecType kCodecType = VideoCodecType::kVideoCodecGeneric; |
Niels Möller | 5fe9510 | 2019-03-04 16:49:25 +0100 | [diff] [blame] | 1879 | PlayoutDelayOracle playout_delay_oracle; |
Erik Språng | dc34a25 | 2019-10-04 15:17:29 +0200 | [diff] [blame] | 1880 | FieldTrialBasedConfig field_trials; |
| 1881 | RTPSenderVideo::Config video_config; |
| 1882 | video_config.clock = &fake_clock_; |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 1883 | video_config.rtp_sender = rtp_sender(); |
Erik Språng | dc34a25 | 2019-10-04 15:17:29 +0200 | [diff] [blame] | 1884 | video_config.playout_delay_oracle = &playout_delay_oracle; |
| 1885 | video_config.field_trials = &field_trials; |
| 1886 | RTPSenderVideo rtp_sender_video(video_config); |
sprang@webrtc.org | ebad765 | 2013-12-05 14:29:02 +0000 | [diff] [blame] | 1887 | uint8_t payload[] = {47, 11, 32, 93, 89}; |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 1888 | rtp_sender_context_->packet_history_.SetStorePacketsStatus( |
| 1889 | RtpPacketHistory::StorageMode::kStoreAndCull, 1); |
| 1890 | uint32_t ssrc = rtp_sender()->SSRC(); |
sprang@webrtc.org | ebad765 | 2013-12-05 14:29:02 +0000 | [diff] [blame] | 1891 | |
sprang@webrtc.org | ebad765 | 2013-12-05 14:29:02 +0000 | [diff] [blame] | 1892 | // Send a frame. |
Sami Kalliomäki | 426a80c | 2018-08-08 11:37:59 +0200 | [diff] [blame] | 1893 | RTPVideoHeader video_header; |
Danil Chapovalov | 51bf200 | 2019-10-11 10:53:27 +0200 | [diff] [blame] | 1894 | video_header.frame_type = VideoFrameType::kVideoFrameKey; |
| 1895 | ASSERT_TRUE(rtp_sender_video.SendVideo(kPayloadType, kCodecType, 1234, 4321, |
| 1896 | payload, nullptr, video_header, |
| 1897 | kDefaultExpectedRetransmissionTimeMs)); |
asapersson@webrtc.org | 97d0489 | 2014-12-09 09:47:53 +0000 | [diff] [blame] | 1898 | StreamDataCounters expected; |
asapersson@webrtc.org | cfd82df | 2015-01-22 09:39:59 +0000 | [diff] [blame] | 1899 | expected.transmitted.payload_bytes = 6; |
| 1900 | expected.transmitted.header_bytes = 12; |
| 1901 | expected.transmitted.padding_bytes = 0; |
| 1902 | expected.transmitted.packets = 1; |
| 1903 | expected.retransmitted.payload_bytes = 0; |
| 1904 | expected.retransmitted.header_bytes = 0; |
| 1905 | expected.retransmitted.padding_bytes = 0; |
| 1906 | expected.retransmitted.packets = 0; |
| 1907 | expected.fec.packets = 0; |
Erik Språng | 7ea9b80 | 2019-10-16 19:03:38 +0200 | [diff] [blame] | 1908 | rtp_stats_callback_.Matches(ssrc, expected); |
sprang@webrtc.org | ebad765 | 2013-12-05 14:29:02 +0000 | [diff] [blame] | 1909 | |
| 1910 | // Retransmit a frame. |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 1911 | uint16_t seqno = rtp_sender()->SequenceNumber() - 1; |
| 1912 | rtp_sender()->ReSendPacket(seqno); |
asapersson@webrtc.org | cfd82df | 2015-01-22 09:39:59 +0000 | [diff] [blame] | 1913 | expected.transmitted.payload_bytes = 12; |
| 1914 | expected.transmitted.header_bytes = 24; |
| 1915 | expected.transmitted.packets = 2; |
| 1916 | expected.retransmitted.payload_bytes = 6; |
| 1917 | expected.retransmitted.header_bytes = 12; |
| 1918 | expected.retransmitted.padding_bytes = 0; |
| 1919 | expected.retransmitted.packets = 1; |
Erik Språng | 7ea9b80 | 2019-10-16 19:03:38 +0200 | [diff] [blame] | 1920 | rtp_stats_callback_.Matches(ssrc, expected); |
sprang@webrtc.org | ebad765 | 2013-12-05 14:29:02 +0000 | [diff] [blame] | 1921 | |
| 1922 | // Send padding. |
Erik Språng | 4208a13 | 2019-08-26 08:58:45 +0200 | [diff] [blame] | 1923 | GenerateAndSendPadding(kMaxPaddingSize); |
asapersson@webrtc.org | cfd82df | 2015-01-22 09:39:59 +0000 | [diff] [blame] | 1924 | expected.transmitted.payload_bytes = 12; |
| 1925 | expected.transmitted.header_bytes = 36; |
| 1926 | expected.transmitted.padding_bytes = kMaxPaddingSize; |
| 1927 | expected.transmitted.packets = 3; |
Erik Språng | 7ea9b80 | 2019-10-16 19:03:38 +0200 | [diff] [blame] | 1928 | rtp_stats_callback_.Matches(ssrc, expected); |
Erik Språng | dc34a25 | 2019-10-04 15:17:29 +0200 | [diff] [blame] | 1929 | } |
| 1930 | |
| 1931 | TEST_P(RtpSenderTestWithoutPacer, StreamDataCountersCallbacksUlpfec) { |
Erik Språng | dc34a25 | 2019-10-04 15:17:29 +0200 | [diff] [blame] | 1932 | const uint8_t kRedPayloadType = 96; |
| 1933 | const uint8_t kUlpfecPayloadType = 97; |
| 1934 | const uint8_t kPayloadType = 127; |
| 1935 | const VideoCodecType kCodecType = VideoCodecType::kVideoCodecGeneric; |
| 1936 | PlayoutDelayOracle playout_delay_oracle; |
| 1937 | FieldTrialBasedConfig field_trials; |
| 1938 | RTPSenderVideo::Config video_config; |
| 1939 | video_config.clock = &fake_clock_; |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 1940 | video_config.rtp_sender = rtp_sender(); |
Erik Språng | dc34a25 | 2019-10-04 15:17:29 +0200 | [diff] [blame] | 1941 | video_config.playout_delay_oracle = &playout_delay_oracle; |
| 1942 | video_config.field_trials = &field_trials; |
| 1943 | video_config.red_payload_type = kRedPayloadType; |
| 1944 | video_config.ulpfec_payload_type = kUlpfecPayloadType; |
| 1945 | RTPSenderVideo rtp_sender_video(video_config); |
| 1946 | uint8_t payload[] = {47, 11, 32, 93, 89}; |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 1947 | rtp_sender_context_->packet_history_.SetStorePacketsStatus( |
| 1948 | RtpPacketHistory::StorageMode::kStoreAndCull, 1); |
| 1949 | uint32_t ssrc = rtp_sender()->SSRC(); |
Erik Språng | dc34a25 | 2019-10-04 15:17:29 +0200 | [diff] [blame] | 1950 | |
Erik Språng | dc34a25 | 2019-10-04 15:17:29 +0200 | [diff] [blame] | 1951 | RTPVideoHeader video_header; |
| 1952 | StreamDataCounters expected; |
| 1953 | |
brandtr | f1bb476 | 2016-11-07 03:05:06 -0800 | [diff] [blame] | 1954 | // Send ULPFEC. |
sprang@webrtc.org | ebad765 | 2013-12-05 14:29:02 +0000 | [diff] [blame] | 1955 | FecProtectionParams fec_params; |
| 1956 | fec_params.fec_mask_type = kFecMaskRandom; |
| 1957 | fec_params.fec_rate = 1; |
| 1958 | fec_params.max_fec_frames = 1; |
Niels Möller | 59ab1cf | 2019-02-06 22:48:11 +0100 | [diff] [blame] | 1959 | rtp_sender_video.SetFecParameters(fec_params, fec_params); |
Danil Chapovalov | 51bf200 | 2019-10-11 10:53:27 +0200 | [diff] [blame] | 1960 | video_header.frame_type = VideoFrameType::kVideoFrameDelta; |
| 1961 | ASSERT_TRUE(rtp_sender_video.SendVideo(kPayloadType, kCodecType, 1234, 4321, |
| 1962 | payload, nullptr, video_header, |
| 1963 | kDefaultExpectedRetransmissionTimeMs)); |
Erik Språng | dc34a25 | 2019-10-04 15:17:29 +0200 | [diff] [blame] | 1964 | expected.transmitted.payload_bytes = 28; |
| 1965 | expected.transmitted.header_bytes = 24; |
| 1966 | expected.transmitted.packets = 2; |
asapersson@webrtc.org | cfd82df | 2015-01-22 09:39:59 +0000 | [diff] [blame] | 1967 | expected.fec.packets = 1; |
Erik Språng | 7ea9b80 | 2019-10-16 19:03:38 +0200 | [diff] [blame] | 1968 | rtp_stats_callback_.Matches(ssrc, expected); |
sprang@webrtc.org | ebad765 | 2013-12-05 14:29:02 +0000 | [diff] [blame] | 1969 | } |
| 1970 | |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 1971 | TEST_P(RtpSenderTestWithoutPacer, BytesReportedCorrectly) { |
Niels Möller | 59ab1cf | 2019-02-06 22:48:11 +0100 | [diff] [blame] | 1972 | // XXX const char* kPayloadName = "GENERIC"; |
pbos@webrtc.org | 72491b9 | 2014-07-10 16:24:54 +0000 | [diff] [blame] | 1973 | const uint8_t kPayloadType = 127; |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 1974 | rtp_sender()->SetRtxPayloadType(kPayloadType - 1, kPayloadType); |
| 1975 | rtp_sender()->SetRtxStatus(kRtxRetransmitted | kRtxRedundantPayloads); |
pbos@webrtc.org | 72491b9 | 2014-07-10 16:24:54 +0000 | [diff] [blame] | 1976 | |
Niels Möller | 59ab1cf | 2019-02-06 22:48:11 +0100 | [diff] [blame] | 1977 | SendGenericPacket(); |
pbos@webrtc.org | 2f4b14e | 2014-07-15 15:25:39 +0000 | [diff] [blame] | 1978 | // Will send 2 full-size padding packets. |
Erik Språng | 4208a13 | 2019-08-26 08:58:45 +0200 | [diff] [blame] | 1979 | GenerateAndSendPadding(1); |
| 1980 | GenerateAndSendPadding(1); |
pbos@webrtc.org | 72491b9 | 2014-07-10 16:24:54 +0000 | [diff] [blame] | 1981 | |
pbos@webrtc.org | 2f4b14e | 2014-07-15 15:25:39 +0000 | [diff] [blame] | 1982 | StreamDataCounters rtp_stats; |
| 1983 | StreamDataCounters rtx_stats; |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 1984 | rtp_egress()->GetDataCounters(&rtp_stats, &rtx_stats); |
pbos@webrtc.org | 72491b9 | 2014-07-10 16:24:54 +0000 | [diff] [blame] | 1985 | |
Niels Möller | 59ab1cf | 2019-02-06 22:48:11 +0100 | [diff] [blame] | 1986 | // Payload |
asapersson@webrtc.org | d08d389 | 2014-12-16 12:03:11 +0000 | [diff] [blame] | 1987 | EXPECT_GT(rtp_stats.first_packet_time_ms, -1); |
Niels Möller | 59ab1cf | 2019-02-06 22:48:11 +0100 | [diff] [blame] | 1988 | EXPECT_EQ(rtp_stats.transmitted.payload_bytes, sizeof(kPayloadData)); |
asapersson@webrtc.org | cfd82df | 2015-01-22 09:39:59 +0000 | [diff] [blame] | 1989 | EXPECT_EQ(rtp_stats.transmitted.header_bytes, 12u); |
| 1990 | EXPECT_EQ(rtp_stats.transmitted.padding_bytes, 0u); |
| 1991 | EXPECT_EQ(rtx_stats.transmitted.payload_bytes, 0u); |
| 1992 | EXPECT_EQ(rtx_stats.transmitted.header_bytes, 24u); |
| 1993 | EXPECT_EQ(rtx_stats.transmitted.padding_bytes, 2 * kMaxPaddingSize); |
pbos@webrtc.org | 2f4b14e | 2014-07-15 15:25:39 +0000 | [diff] [blame] | 1994 | |
asapersson@webrtc.org | cfd82df | 2015-01-22 09:39:59 +0000 | [diff] [blame] | 1995 | EXPECT_EQ(rtp_stats.transmitted.TotalBytes(), |
danilchap | 162abd3 | 2015-12-10 02:39:40 -0800 | [diff] [blame] | 1996 | rtp_stats.transmitted.payload_bytes + |
| 1997 | rtp_stats.transmitted.header_bytes + |
| 1998 | rtp_stats.transmitted.padding_bytes); |
asapersson@webrtc.org | cfd82df | 2015-01-22 09:39:59 +0000 | [diff] [blame] | 1999 | EXPECT_EQ(rtx_stats.transmitted.TotalBytes(), |
danilchap | 162abd3 | 2015-12-10 02:39:40 -0800 | [diff] [blame] | 2000 | rtx_stats.transmitted.payload_bytes + |
| 2001 | rtx_stats.transmitted.header_bytes + |
| 2002 | rtx_stats.transmitted.padding_bytes); |
asapersson@webrtc.org | 97d0489 | 2014-12-09 09:47:53 +0000 | [diff] [blame] | 2003 | |
danilchap | 162abd3 | 2015-12-10 02:39:40 -0800 | [diff] [blame] | 2004 | EXPECT_EQ( |
| 2005 | transport_.total_bytes_sent_, |
| 2006 | rtp_stats.transmitted.TotalBytes() + rtx_stats.transmitted.TotalBytes()); |
pbos@webrtc.org | 72491b9 | 2014-07-10 16:24:54 +0000 | [diff] [blame] | 2007 | } |
guoweis@webrtc.org | 4536289 | 2015-03-04 22:55:15 +0000 | [diff] [blame] | 2008 | |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 2009 | TEST_P(RtpSenderTestWithoutPacer, RespectsNackBitrateLimit) { |
sprang | 38778b0 | 2015-09-29 09:48:22 -0700 | [diff] [blame] | 2010 | const int32_t kPacketSize = 1400; |
| 2011 | const int32_t kNumPackets = 30; |
| 2012 | |
sprang | cd349d9 | 2016-07-13 09:11:28 -0700 | [diff] [blame] | 2013 | retransmission_rate_limiter_.SetMaxRate(kPacketSize * kNumPackets * 8); |
| 2014 | |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 2015 | rtp_sender_context_->packet_history_.SetStorePacketsStatus( |
| 2016 | RtpPacketHistory::StorageMode::kStoreAndCull, kNumPackets); |
| 2017 | const uint16_t kStartSequenceNumber = rtp_sender()->SequenceNumber(); |
Danil Chapovalov | 2800d74 | 2016-08-26 18:48:46 +0200 | [diff] [blame] | 2018 | std::vector<uint16_t> sequence_numbers; |
sprang | 38778b0 | 2015-09-29 09:48:22 -0700 | [diff] [blame] | 2019 | for (int32_t i = 0; i < kNumPackets; ++i) { |
| 2020 | sequence_numbers.push_back(kStartSequenceNumber + i); |
| 2021 | fake_clock_.AdvanceTimeMilliseconds(1); |
| 2022 | SendPacket(fake_clock_.TimeInMilliseconds(), kPacketSize); |
| 2023 | } |
danilchap | 12ba186 | 2016-10-26 02:41:55 -0700 | [diff] [blame] | 2024 | EXPECT_EQ(kNumPackets, transport_.packets_sent()); |
sprang | 38778b0 | 2015-09-29 09:48:22 -0700 | [diff] [blame] | 2025 | |
| 2026 | fake_clock_.AdvanceTimeMilliseconds(1000 - kNumPackets); |
| 2027 | |
| 2028 | // Resending should work - brings the bandwidth up to the limit. |
| 2029 | // NACK bitrate is capped to the same bitrate as the encoder, since the max |
| 2030 | // protection overhead is 50% (see MediaOptimization::SetTargetRates). |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 2031 | rtp_sender()->OnReceivedNack(sequence_numbers, 0); |
danilchap | 12ba186 | 2016-10-26 02:41:55 -0700 | [diff] [blame] | 2032 | EXPECT_EQ(kNumPackets * 2, transport_.packets_sent()); |
sprang | 38778b0 | 2015-09-29 09:48:22 -0700 | [diff] [blame] | 2033 | |
sprang | cd349d9 | 2016-07-13 09:11:28 -0700 | [diff] [blame] | 2034 | // Must be at least 5ms in between retransmission attempts. |
| 2035 | fake_clock_.AdvanceTimeMilliseconds(5); |
| 2036 | |
sprang | 38778b0 | 2015-09-29 09:48:22 -0700 | [diff] [blame] | 2037 | // Resending should not work, bandwidth exceeded. |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 2038 | rtp_sender()->OnReceivedNack(sequence_numbers, 0); |
danilchap | 12ba186 | 2016-10-26 02:41:55 -0700 | [diff] [blame] | 2039 | EXPECT_EQ(kNumPackets * 2, transport_.packets_sent()); |
sprang | 38778b0 | 2015-09-29 09:48:22 -0700 | [diff] [blame] | 2040 | } |
| 2041 | |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 2042 | TEST_P(RtpSenderTest, OnOverheadChanged) { |
michaelt | 4da3044 | 2016-11-17 01:38:43 -0800 | [diff] [blame] | 2043 | MockOverheadObserver mock_overhead_observer; |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 2044 | RtpRtcp::Configuration config; |
| 2045 | config.clock = &fake_clock_; |
| 2046 | config.outgoing_transport = &transport_; |
Erik Språng | 54d5d2c | 2019-08-20 17:22:36 +0200 | [diff] [blame] | 2047 | config.local_media_ssrc = kSsrc; |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 2048 | config.retransmission_rate_limiter = &retransmission_rate_limiter_; |
| 2049 | config.overhead_observer = &mock_overhead_observer; |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 2050 | rtp_sender_context_ = std::make_unique<RtpSenderContext>(config); |
michaelt | 4da3044 | 2016-11-17 01:38:43 -0800 | [diff] [blame] | 2051 | |
michaelt | 4da3044 | 2016-11-17 01:38:43 -0800 | [diff] [blame] | 2052 | // RTP overhead is 12B. |
nisse | 284542b | 2017-01-10 08:58:32 -0800 | [diff] [blame] | 2053 | EXPECT_CALL(mock_overhead_observer, OnOverheadChanged(12)).Times(1); |
Niels Möller | e7b9e6b | 2019-02-06 18:23:44 +0100 | [diff] [blame] | 2054 | SendGenericPacket(); |
michaelt | 4da3044 | 2016-11-17 01:38:43 -0800 | [diff] [blame] | 2055 | |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 2056 | rtp_sender()->RegisterRtpHeaderExtension(kRtpExtensionTransmissionTimeOffset, |
| 2057 | kTransmissionTimeOffsetExtensionId); |
michaelt | 4da3044 | 2016-11-17 01:38:43 -0800 | [diff] [blame] | 2058 | |
| 2059 | // TransmissionTimeOffset extension has a size of 8B. |
nisse | 284542b | 2017-01-10 08:58:32 -0800 | [diff] [blame] | 2060 | // 12B + 8B = 20B |
| 2061 | EXPECT_CALL(mock_overhead_observer, OnOverheadChanged(20)).Times(1); |
Niels Möller | e7b9e6b | 2019-02-06 18:23:44 +0100 | [diff] [blame] | 2062 | SendGenericPacket(); |
michaelt | 4da3044 | 2016-11-17 01:38:43 -0800 | [diff] [blame] | 2063 | } |
| 2064 | |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 2065 | TEST_P(RtpSenderTest, DoesNotUpdateOverheadOnEqualSize) { |
michaelt | 4da3044 | 2016-11-17 01:38:43 -0800 | [diff] [blame] | 2066 | MockOverheadObserver mock_overhead_observer; |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 2067 | RtpRtcp::Configuration config; |
| 2068 | config.clock = &fake_clock_; |
| 2069 | config.outgoing_transport = &transport_; |
Erik Språng | 54d5d2c | 2019-08-20 17:22:36 +0200 | [diff] [blame] | 2070 | config.local_media_ssrc = kSsrc; |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 2071 | config.retransmission_rate_limiter = &retransmission_rate_limiter_; |
| 2072 | config.overhead_observer = &mock_overhead_observer; |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 2073 | rtp_sender_context_ = std::make_unique<RtpSenderContext>(config); |
michaelt | 4da3044 | 2016-11-17 01:38:43 -0800 | [diff] [blame] | 2074 | |
| 2075 | EXPECT_CALL(mock_overhead_observer, OnOverheadChanged(_)).Times(1); |
Niels Möller | e7b9e6b | 2019-02-06 18:23:44 +0100 | [diff] [blame] | 2076 | SendGenericPacket(); |
| 2077 | SendGenericPacket(); |
michaelt | 4da3044 | 2016-11-17 01:38:43 -0800 | [diff] [blame] | 2078 | } |
| 2079 | |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 2080 | TEST_P(RtpSenderTest, SendPacketMatchesVideo) { |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 2081 | std::unique_ptr<RtpPacketToSend> packet = |
| 2082 | BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds()); |
| 2083 | packet->set_packet_type(RtpPacketToSend::Type::kVideo); |
| 2084 | |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 2085 | // Verify sent with correct SSRC. |
| 2086 | packet = BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds()); |
| 2087 | packet->SetSsrc(kSsrc); |
| 2088 | packet->set_packet_type(RtpPacketToSend::Type::kVideo); |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 2089 | rtp_egress()->SendPacket(packet.get(), PacedPacketInfo()); |
Erik Språng | 671b403 | 2019-10-17 16:56:22 +0200 | [diff] [blame] | 2090 | EXPECT_EQ(transport_.packets_sent(), 1); |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 2091 | } |
| 2092 | |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 2093 | TEST_P(RtpSenderTest, SendPacketMatchesAudio) { |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 2094 | std::unique_ptr<RtpPacketToSend> packet = |
| 2095 | BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds()); |
| 2096 | packet->set_packet_type(RtpPacketToSend::Type::kAudio); |
| 2097 | |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 2098 | // Verify sent with correct SSRC. |
| 2099 | packet = BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds()); |
| 2100 | packet->SetSsrc(kSsrc); |
| 2101 | packet->set_packet_type(RtpPacketToSend::Type::kAudio); |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 2102 | rtp_egress()->SendPacket(packet.get(), PacedPacketInfo()); |
Erik Språng | 671b403 | 2019-10-17 16:56:22 +0200 | [diff] [blame] | 2103 | EXPECT_EQ(transport_.packets_sent(), 1); |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 2104 | } |
| 2105 | |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 2106 | TEST_P(RtpSenderTest, SendPacketMatchesRetransmissions) { |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 2107 | std::unique_ptr<RtpPacketToSend> packet = |
| 2108 | BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds()); |
| 2109 | packet->set_packet_type(RtpPacketToSend::Type::kRetransmission); |
| 2110 | |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 2111 | // Verify sent with correct SSRC (non-RTX). |
| 2112 | packet = BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds()); |
| 2113 | packet->SetSsrc(kSsrc); |
| 2114 | packet->set_packet_type(RtpPacketToSend::Type::kRetransmission); |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 2115 | rtp_egress()->SendPacket(packet.get(), PacedPacketInfo()); |
Erik Språng | 671b403 | 2019-10-17 16:56:22 +0200 | [diff] [blame] | 2116 | EXPECT_EQ(transport_.packets_sent(), 1); |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 2117 | |
| 2118 | // RTX retransmission. |
| 2119 | packet = BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds()); |
| 2120 | packet->SetSsrc(kRtxSsrc); |
| 2121 | packet->set_packet_type(RtpPacketToSend::Type::kRetransmission); |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 2122 | rtp_egress()->SendPacket(packet.get(), PacedPacketInfo()); |
Erik Språng | 671b403 | 2019-10-17 16:56:22 +0200 | [diff] [blame] | 2123 | EXPECT_EQ(transport_.packets_sent(), 2); |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 2124 | } |
| 2125 | |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 2126 | TEST_P(RtpSenderTest, SendPacketMatchesPadding) { |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 2127 | std::unique_ptr<RtpPacketToSend> packet = |
| 2128 | BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds()); |
| 2129 | packet->set_packet_type(RtpPacketToSend::Type::kPadding); |
| 2130 | |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 2131 | // Verify sent with correct SSRC (non-RTX). |
| 2132 | packet = BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds()); |
| 2133 | packet->SetSsrc(kSsrc); |
| 2134 | packet->set_packet_type(RtpPacketToSend::Type::kPadding); |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 2135 | rtp_egress()->SendPacket(packet.get(), PacedPacketInfo()); |
Erik Språng | 671b403 | 2019-10-17 16:56:22 +0200 | [diff] [blame] | 2136 | EXPECT_EQ(transport_.packets_sent(), 1); |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 2137 | |
| 2138 | // RTX padding. |
| 2139 | packet = BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds()); |
| 2140 | packet->SetSsrc(kRtxSsrc); |
| 2141 | packet->set_packet_type(RtpPacketToSend::Type::kPadding); |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 2142 | rtp_egress()->SendPacket(packet.get(), PacedPacketInfo()); |
Erik Språng | 671b403 | 2019-10-17 16:56:22 +0200 | [diff] [blame] | 2143 | EXPECT_EQ(transport_.packets_sent(), 2); |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 2144 | } |
| 2145 | |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 2146 | TEST_P(RtpSenderTest, SendPacketMatchesFlexfec) { |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 2147 | std::unique_ptr<RtpPacketToSend> packet = |
| 2148 | BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds()); |
| 2149 | packet->set_packet_type(RtpPacketToSend::Type::kForwardErrorCorrection); |
| 2150 | |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 2151 | // Verify sent with correct SSRC. |
| 2152 | packet = BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds()); |
| 2153 | packet->SetSsrc(kFlexFecSsrc); |
| 2154 | packet->set_packet_type(RtpPacketToSend::Type::kForwardErrorCorrection); |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 2155 | rtp_egress()->SendPacket(packet.get(), PacedPacketInfo()); |
Erik Språng | 671b403 | 2019-10-17 16:56:22 +0200 | [diff] [blame] | 2156 | EXPECT_EQ(transport_.packets_sent(), 1); |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 2157 | } |
| 2158 | |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 2159 | TEST_P(RtpSenderTest, SendPacketMatchesUlpfec) { |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 2160 | std::unique_ptr<RtpPacketToSend> packet = |
| 2161 | BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds()); |
| 2162 | packet->set_packet_type(RtpPacketToSend::Type::kForwardErrorCorrection); |
| 2163 | |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 2164 | // Verify sent with correct SSRC. |
| 2165 | packet = BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds()); |
| 2166 | packet->SetSsrc(kSsrc); |
| 2167 | packet->set_packet_type(RtpPacketToSend::Type::kForwardErrorCorrection); |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 2168 | rtp_egress()->SendPacket(packet.get(), PacedPacketInfo()); |
Erik Språng | 671b403 | 2019-10-17 16:56:22 +0200 | [diff] [blame] | 2169 | EXPECT_EQ(transport_.packets_sent(), 1); |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 2170 | } |
| 2171 | |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 2172 | TEST_P(RtpSenderTest, SendPacketHandlesRetransmissionHistory) { |
| 2173 | rtp_sender_context_->packet_history_.SetStorePacketsStatus( |
| 2174 | RtpPacketHistory::StorageMode::kStoreAndCull, 10); |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 2175 | |
| 2176 | // Build a media packet and send it. |
| 2177 | std::unique_ptr<RtpPacketToSend> packet = |
| 2178 | BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds()); |
| 2179 | const uint16_t media_sequence_number = packet->SequenceNumber(); |
| 2180 | packet->set_packet_type(RtpPacketToSend::Type::kVideo); |
| 2181 | packet->set_allow_retransmission(true); |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 2182 | rtp_egress()->SendPacket(packet.get(), PacedPacketInfo()); |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 2183 | |
| 2184 | // Simulate retransmission request. |
| 2185 | fake_clock_.AdvanceTimeMilliseconds(30); |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 2186 | EXPECT_GT(rtp_sender()->ReSendPacket(media_sequence_number), 0); |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 2187 | |
| 2188 | // Packet already pending, retransmission not allowed. |
| 2189 | fake_clock_.AdvanceTimeMilliseconds(30); |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 2190 | EXPECT_EQ(rtp_sender()->ReSendPacket(media_sequence_number), 0); |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 2191 | |
| 2192 | // Packet exiting pacer, mark as not longer pending. |
| 2193 | packet = BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds()); |
| 2194 | EXPECT_NE(packet->SequenceNumber(), media_sequence_number); |
| 2195 | packet->set_packet_type(RtpPacketToSend::Type::kRetransmission); |
| 2196 | packet->SetSsrc(kRtxSsrc); |
| 2197 | packet->set_retransmitted_sequence_number(media_sequence_number); |
| 2198 | packet->set_allow_retransmission(false); |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 2199 | rtp_egress()->SendPacket(packet.get(), PacedPacketInfo()); |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 2200 | |
| 2201 | // Retransmissions allowed again. |
| 2202 | fake_clock_.AdvanceTimeMilliseconds(30); |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 2203 | EXPECT_GT(rtp_sender()->ReSendPacket(media_sequence_number), 0); |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 2204 | |
| 2205 | // Retransmission of RTX packet should not be allowed. |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 2206 | EXPECT_EQ(rtp_sender()->ReSendPacket(packet->SequenceNumber()), 0); |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 2207 | } |
| 2208 | |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 2209 | TEST_P(RtpSenderTest, SendPacketUpdatesExtensions) { |
| 2210 | ASSERT_EQ(rtp_sender()->RegisterRtpHeaderExtension( |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 2211 | kRtpExtensionTransmissionTimeOffset, |
| 2212 | kTransmissionTimeOffsetExtensionId), |
| 2213 | 0); |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 2214 | ASSERT_EQ(rtp_sender()->RegisterRtpHeaderExtension( |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 2215 | kRtpExtensionAbsoluteSendTime, kAbsoluteSendTimeExtensionId), |
| 2216 | 0); |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 2217 | ASSERT_EQ(rtp_sender()->RegisterRtpHeaderExtension(kRtpExtensionVideoTiming, |
| 2218 | kVideoTimingExtensionId), |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 2219 | 0); |
| 2220 | |
| 2221 | std::unique_ptr<RtpPacketToSend> packet = |
| 2222 | BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds()); |
| 2223 | packet->set_packetization_finish_time_ms(fake_clock_.TimeInMilliseconds()); |
| 2224 | |
| 2225 | const int32_t kDiffMs = 10; |
| 2226 | fake_clock_.AdvanceTimeMilliseconds(kDiffMs); |
| 2227 | |
| 2228 | packet->set_packet_type(RtpPacketToSend::Type::kVideo); |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 2229 | rtp_egress()->SendPacket(packet.get(), PacedPacketInfo()); |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 2230 | |
| 2231 | const RtpPacketReceived& received_packet = transport_.last_sent_packet(); |
| 2232 | |
| 2233 | EXPECT_EQ(received_packet.GetExtension<TransmissionOffset>(), kDiffMs * 90); |
| 2234 | |
| 2235 | EXPECT_EQ(received_packet.GetExtension<AbsoluteSendTime>(), |
| 2236 | AbsoluteSendTime::MsTo24Bits(fake_clock_.TimeInMilliseconds())); |
| 2237 | |
| 2238 | VideoSendTiming timing; |
| 2239 | EXPECT_TRUE(received_packet.GetExtension<VideoTimingExtension>(&timing)); |
| 2240 | EXPECT_EQ(timing.pacer_exit_delta_ms, kDiffMs); |
| 2241 | } |
| 2242 | |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 2243 | TEST_P(RtpSenderTest, SendPacketSetsPacketOptions) { |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 2244 | const uint16_t kPacketId = 42; |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 2245 | ASSERT_EQ(rtp_sender()->RegisterRtpHeaderExtension( |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 2246 | kRtpExtensionTransportSequenceNumber, |
| 2247 | kTransportSequenceNumberExtensionId), |
| 2248 | 0); |
| 2249 | std::unique_ptr<RtpPacketToSend> packet = |
| 2250 | BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds()); |
| 2251 | packet->SetExtension<TransportSequenceNumber>(kPacketId); |
| 2252 | |
| 2253 | packet->set_packet_type(RtpPacketToSend::Type::kVideo); |
| 2254 | EXPECT_CALL(send_packet_observer_, OnSendPacket); |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 2255 | rtp_egress()->SendPacket(packet.get(), PacedPacketInfo()); |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 2256 | |
| 2257 | EXPECT_EQ(transport_.last_options_.packet_id, kPacketId); |
| 2258 | EXPECT_TRUE(transport_.last_options_.included_in_allocation); |
| 2259 | EXPECT_TRUE(transport_.last_options_.included_in_feedback); |
| 2260 | EXPECT_FALSE(transport_.last_options_.is_retransmit); |
| 2261 | |
| 2262 | // Send another packet as retransmission, verify options are populated. |
| 2263 | packet = BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds()); |
| 2264 | packet->SetExtension<TransportSequenceNumber>(kPacketId + 1); |
| 2265 | packet->set_packet_type(RtpPacketToSend::Type::kRetransmission); |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 2266 | rtp_egress()->SendPacket(packet.get(), PacedPacketInfo()); |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 2267 | EXPECT_TRUE(transport_.last_options_.is_retransmit); |
| 2268 | } |
| 2269 | |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 2270 | TEST_P(RtpSenderTest, SendPacketUpdatesStats) { |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 2271 | const size_t kPayloadSize = 1000; |
| 2272 | |
| 2273 | StrictMock<MockSendSideDelayObserver> send_side_delay_observer; |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 2274 | |
| 2275 | RtpRtcp::Configuration config; |
| 2276 | config.clock = &fake_clock_; |
| 2277 | config.outgoing_transport = &transport_; |
Erik Språng | 54d5d2c | 2019-08-20 17:22:36 +0200 | [diff] [blame] | 2278 | config.local_media_ssrc = kSsrc; |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 2279 | config.rtx_send_ssrc = kRtxSsrc; |
| 2280 | config.flexfec_sender = &flexfec_sender_; |
| 2281 | config.send_side_delay_observer = &send_side_delay_observer; |
| 2282 | config.event_log = &mock_rtc_event_log_; |
| 2283 | config.send_packet_observer = &send_packet_observer_; |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 2284 | rtp_sender_context_ = std::make_unique<RtpSenderContext>(config); |
| 2285 | ASSERT_EQ(0, rtp_sender()->RegisterRtpHeaderExtension( |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 2286 | kRtpExtensionTransportSequenceNumber, |
| 2287 | kTransportSequenceNumberExtensionId)); |
| 2288 | |
| 2289 | const int64_t capture_time_ms = fake_clock_.TimeInMilliseconds(); |
| 2290 | |
| 2291 | std::unique_ptr<RtpPacketToSend> video_packet = |
| 2292 | BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds()); |
| 2293 | video_packet->set_packet_type(RtpPacketToSend::Type::kVideo); |
| 2294 | video_packet->SetPayloadSize(kPayloadSize); |
| 2295 | video_packet->SetExtension<TransportSequenceNumber>(1); |
| 2296 | |
| 2297 | std::unique_ptr<RtpPacketToSend> rtx_packet = |
| 2298 | BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds()); |
| 2299 | rtx_packet->SetSsrc(kRtxSsrc); |
| 2300 | rtx_packet->set_packet_type(RtpPacketToSend::Type::kRetransmission); |
| 2301 | rtx_packet->SetPayloadSize(kPayloadSize); |
| 2302 | rtx_packet->SetExtension<TransportSequenceNumber>(2); |
| 2303 | |
| 2304 | std::unique_ptr<RtpPacketToSend> fec_packet = |
| 2305 | BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds()); |
| 2306 | fec_packet->SetSsrc(kFlexFecSsrc); |
| 2307 | fec_packet->set_packet_type(RtpPacketToSend::Type::kForwardErrorCorrection); |
| 2308 | fec_packet->SetPayloadSize(kPayloadSize); |
| 2309 | fec_packet->SetExtension<TransportSequenceNumber>(3); |
| 2310 | |
| 2311 | const int64_t kDiffMs = 25; |
| 2312 | fake_clock_.AdvanceTimeMilliseconds(kDiffMs); |
| 2313 | |
| 2314 | EXPECT_CALL(send_side_delay_observer, |
| 2315 | SendSideDelayUpdated(kDiffMs, kDiffMs, kDiffMs, kSsrc)); |
| 2316 | EXPECT_CALL( |
| 2317 | send_side_delay_observer, |
| 2318 | SendSideDelayUpdated(kDiffMs, kDiffMs, 2 * kDiffMs, kFlexFecSsrc)); |
| 2319 | |
| 2320 | EXPECT_CALL(send_packet_observer_, OnSendPacket(1, capture_time_ms, kSsrc)); |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 2321 | |
| 2322 | rtp_egress()->SendPacket(video_packet.get(), PacedPacketInfo()); |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 2323 | |
| 2324 | // Send packet observer not called for padding/retransmissions. |
| 2325 | EXPECT_CALL(send_packet_observer_, OnSendPacket(2, _, _)).Times(0); |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 2326 | rtp_egress()->SendPacket(rtx_packet.get(), PacedPacketInfo()); |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 2327 | |
| 2328 | EXPECT_CALL(send_packet_observer_, |
| 2329 | OnSendPacket(3, capture_time_ms, kFlexFecSsrc)); |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 2330 | rtp_egress()->SendPacket(fec_packet.get(), PacedPacketInfo()); |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 2331 | |
| 2332 | StreamDataCounters rtp_stats; |
| 2333 | StreamDataCounters rtx_stats; |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 2334 | rtp_egress()->GetDataCounters(&rtp_stats, &rtx_stats); |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 2335 | EXPECT_EQ(rtp_stats.transmitted.packets, 2u); |
| 2336 | EXPECT_EQ(rtp_stats.fec.packets, 1u); |
| 2337 | EXPECT_EQ(rtx_stats.retransmitted.packets, 1u); |
| 2338 | } |
| 2339 | |
Erik Språng | 478cb46 | 2019-06-26 15:49:27 +0200 | [diff] [blame] | 2340 | TEST_P(RtpSenderTest, GeneratePaddingResendsOldPacketsWithRtx) { |
Mirko Bonadei | a7e3bce | 2019-07-12 17:35:56 +0000 | [diff] [blame] | 2341 | // Min requested size in order to use RTX payload. |
| 2342 | const size_t kMinPaddingSize = 50; |
| 2343 | |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 2344 | rtp_sender()->SetRtxStatus(kRtxRetransmitted | kRtxRedundantPayloads); |
| 2345 | rtp_sender()->SetRtxPayloadType(kRtxPayload, kPayload); |
| 2346 | rtp_sender_context_->packet_history_.SetStorePacketsStatus( |
| 2347 | RtpPacketHistory::StorageMode::kStoreAndCull, 1); |
Erik Språng | 478cb46 | 2019-06-26 15:49:27 +0200 | [diff] [blame] | 2348 | |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 2349 | ASSERT_EQ(0, rtp_sender()->RegisterRtpHeaderExtension( |
Erik Språng | 0f6191d | 2019-07-15 20:33:40 +0200 | [diff] [blame] | 2350 | kRtpExtensionTransmissionTimeOffset, |
| 2351 | kTransmissionTimeOffsetExtensionId)); |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 2352 | ASSERT_EQ(0, |
| 2353 | rtp_sender()->RegisterRtpHeaderExtension( |
| 2354 | kRtpExtensionAbsoluteSendTime, kAbsoluteSendTimeExtensionId)); |
| 2355 | ASSERT_EQ(0, rtp_sender()->RegisterRtpHeaderExtension( |
Erik Språng | 0f6191d | 2019-07-15 20:33:40 +0200 | [diff] [blame] | 2356 | kRtpExtensionTransportSequenceNumber, |
| 2357 | kTransportSequenceNumberExtensionId)); |
| 2358 | |
Erik Språng | 478cb46 | 2019-06-26 15:49:27 +0200 | [diff] [blame] | 2359 | const size_t kPayloadPacketSize = 1234; |
| 2360 | std::unique_ptr<RtpPacketToSend> packet = |
| 2361 | BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds()); |
| 2362 | packet->set_allow_retransmission(true); |
| 2363 | packet->SetPayloadSize(kPayloadPacketSize); |
| 2364 | packet->set_packet_type(RtpPacketToSend::Type::kVideo); |
| 2365 | |
| 2366 | // Send a dummy video packet so it ends up in the packet history. |
Erik Språng | 0f6191d | 2019-07-15 20:33:40 +0200 | [diff] [blame] | 2367 | EXPECT_CALL(send_packet_observer_, OnSendPacket).Times(1); |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 2368 | rtp_egress()->SendPacket(packet.get(), PacedPacketInfo()); |
Erik Språng | 478cb46 | 2019-06-26 15:49:27 +0200 | [diff] [blame] | 2369 | |
| 2370 | // Generated padding has large enough budget that the video packet should be |
| 2371 | // retransmitted as padding. |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 2372 | std::vector<std::unique_ptr<RtpPacketToSend>> generated_packets = |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 2373 | rtp_sender()->GeneratePadding(kMinPaddingSize, true); |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 2374 | ASSERT_EQ(generated_packets.size(), 1u); |
| 2375 | auto& padding_packet = generated_packets.front(); |
| 2376 | EXPECT_EQ(padding_packet->packet_type(), RtpPacketToSend::Type::kPadding); |
| 2377 | EXPECT_EQ(padding_packet->Ssrc(), kRtxSsrc); |
| 2378 | EXPECT_EQ(padding_packet->payload_size(), |
| 2379 | kPayloadPacketSize + kRtxHeaderSize); |
Erik Språng | 0f6191d | 2019-07-15 20:33:40 +0200 | [diff] [blame] | 2380 | EXPECT_TRUE(padding_packet->IsExtensionReserved<TransportSequenceNumber>()); |
| 2381 | EXPECT_TRUE(padding_packet->IsExtensionReserved<AbsoluteSendTime>()); |
| 2382 | EXPECT_TRUE(padding_packet->IsExtensionReserved<TransmissionOffset>()); |
| 2383 | |
| 2384 | // Verify all header extensions are received. |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 2385 | rtp_egress()->SendPacket(padding_packet.get(), PacedPacketInfo()); |
Erik Språng | 0f6191d | 2019-07-15 20:33:40 +0200 | [diff] [blame] | 2386 | webrtc::RTPHeader rtp_header; |
| 2387 | transport_.last_sent_packet().GetHeader(&rtp_header); |
| 2388 | EXPECT_TRUE(rtp_header.extension.hasAbsoluteSendTime); |
| 2389 | EXPECT_TRUE(rtp_header.extension.hasTransmissionTimeOffset); |
| 2390 | EXPECT_TRUE(rtp_header.extension.hasTransportSequenceNumber); |
Erik Språng | 478cb46 | 2019-06-26 15:49:27 +0200 | [diff] [blame] | 2391 | |
| 2392 | // Not enough budged for payload padding, use plain padding instead. |
Mirko Bonadei | a7e3bce | 2019-07-12 17:35:56 +0000 | [diff] [blame] | 2393 | const size_t kPaddingBytesRequested = kMinPaddingSize - 1; |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 2394 | |
| 2395 | size_t padding_bytes_generated = 0; |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 2396 | generated_packets = |
| 2397 | rtp_sender()->GeneratePadding(kPaddingBytesRequested, true); |
Mirko Bonadei | a7e3bce | 2019-07-12 17:35:56 +0000 | [diff] [blame] | 2398 | EXPECT_EQ(generated_packets.size(), 1u); |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 2399 | for (auto& packet : generated_packets) { |
| 2400 | EXPECT_EQ(packet->packet_type(), RtpPacketToSend::Type::kPadding); |
| 2401 | EXPECT_EQ(packet->Ssrc(), kRtxSsrc); |
| 2402 | EXPECT_EQ(packet->payload_size(), 0u); |
| 2403 | EXPECT_GT(packet->padding_size(), 0u); |
| 2404 | padding_bytes_generated += packet->padding_size(); |
Erik Språng | 0f6191d | 2019-07-15 20:33:40 +0200 | [diff] [blame] | 2405 | |
| 2406 | EXPECT_TRUE(packet->IsExtensionReserved<TransportSequenceNumber>()); |
| 2407 | EXPECT_TRUE(packet->IsExtensionReserved<AbsoluteSendTime>()); |
| 2408 | EXPECT_TRUE(packet->IsExtensionReserved<TransmissionOffset>()); |
| 2409 | |
| 2410 | // Verify all header extensions are received. |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 2411 | rtp_egress()->SendPacket(packet.get(), PacedPacketInfo()); |
Erik Språng | 0f6191d | 2019-07-15 20:33:40 +0200 | [diff] [blame] | 2412 | webrtc::RTPHeader rtp_header; |
| 2413 | transport_.last_sent_packet().GetHeader(&rtp_header); |
| 2414 | EXPECT_TRUE(rtp_header.extension.hasAbsoluteSendTime); |
| 2415 | EXPECT_TRUE(rtp_header.extension.hasTransmissionTimeOffset); |
| 2416 | EXPECT_TRUE(rtp_header.extension.hasTransportSequenceNumber); |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 2417 | } |
| 2418 | |
Mirko Bonadei | a7e3bce | 2019-07-12 17:35:56 +0000 | [diff] [blame] | 2419 | EXPECT_EQ(padding_bytes_generated, kMaxPaddingSize); |
Erik Språng | 478cb46 | 2019-06-26 15:49:27 +0200 | [diff] [blame] | 2420 | } |
| 2421 | |
| 2422 | TEST_P(RtpSenderTest, GeneratePaddingCreatesPurePaddingWithoutRtx) { |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 2423 | rtp_sender_context_->packet_history_.SetStorePacketsStatus( |
| 2424 | RtpPacketHistory::StorageMode::kStoreAndCull, 1); |
| 2425 | ASSERT_EQ(0, rtp_sender()->RegisterRtpHeaderExtension( |
Erik Språng | 0f6191d | 2019-07-15 20:33:40 +0200 | [diff] [blame] | 2426 | kRtpExtensionTransmissionTimeOffset, |
| 2427 | kTransmissionTimeOffsetExtensionId)); |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 2428 | ASSERT_EQ(0, |
| 2429 | rtp_sender()->RegisterRtpHeaderExtension( |
| 2430 | kRtpExtensionAbsoluteSendTime, kAbsoluteSendTimeExtensionId)); |
| 2431 | ASSERT_EQ(0, rtp_sender()->RegisterRtpHeaderExtension( |
Erik Språng | 0f6191d | 2019-07-15 20:33:40 +0200 | [diff] [blame] | 2432 | kRtpExtensionTransportSequenceNumber, |
| 2433 | kTransportSequenceNumberExtensionId)); |
Erik Språng | 478cb46 | 2019-06-26 15:49:27 +0200 | [diff] [blame] | 2434 | |
| 2435 | const size_t kPayloadPacketSize = 1234; |
| 2436 | // Send a dummy video packet so it ends up in the packet history. Since we |
| 2437 | // are not using RTX, it should never be used as padding. |
| 2438 | std::unique_ptr<RtpPacketToSend> packet = |
| 2439 | BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds()); |
| 2440 | packet->set_allow_retransmission(true); |
| 2441 | packet->SetPayloadSize(kPayloadPacketSize); |
| 2442 | packet->set_packet_type(RtpPacketToSend::Type::kVideo); |
Erik Språng | 0f6191d | 2019-07-15 20:33:40 +0200 | [diff] [blame] | 2443 | EXPECT_CALL(send_packet_observer_, OnSendPacket).Times(1); |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 2444 | rtp_egress()->SendPacket(packet.get(), PacedPacketInfo()); |
Erik Språng | 478cb46 | 2019-06-26 15:49:27 +0200 | [diff] [blame] | 2445 | |
| 2446 | // Payload padding not available without RTX, only generate plain padding on |
| 2447 | // the media SSRC. |
| 2448 | // Number of padding packets is the requested padding size divided by max |
| 2449 | // padding packet size, rounded up. Pure padding packets are always of the |
| 2450 | // maximum size. |
| 2451 | const size_t kPaddingBytesRequested = kPayloadPacketSize + kRtxHeaderSize; |
| 2452 | const size_t kExpectedNumPaddingPackets = |
| 2453 | (kPaddingBytesRequested + kMaxPaddingSize - 1) / kMaxPaddingSize; |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 2454 | size_t padding_bytes_generated = 0; |
| 2455 | std::vector<std::unique_ptr<RtpPacketToSend>> padding_packets = |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 2456 | rtp_sender()->GeneratePadding(kPaddingBytesRequested, true); |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 2457 | EXPECT_EQ(padding_packets.size(), kExpectedNumPaddingPackets); |
| 2458 | for (auto& packet : padding_packets) { |
| 2459 | EXPECT_EQ(packet->packet_type(), RtpPacketToSend::Type::kPadding); |
| 2460 | EXPECT_EQ(packet->Ssrc(), kSsrc); |
| 2461 | EXPECT_EQ(packet->payload_size(), 0u); |
| 2462 | EXPECT_GT(packet->padding_size(), 0u); |
| 2463 | padding_bytes_generated += packet->padding_size(); |
Erik Språng | 0f6191d | 2019-07-15 20:33:40 +0200 | [diff] [blame] | 2464 | EXPECT_TRUE(packet->IsExtensionReserved<TransportSequenceNumber>()); |
| 2465 | EXPECT_TRUE(packet->IsExtensionReserved<AbsoluteSendTime>()); |
| 2466 | EXPECT_TRUE(packet->IsExtensionReserved<TransmissionOffset>()); |
| 2467 | |
| 2468 | // Verify all header extensions are received. |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 2469 | rtp_egress()->SendPacket(packet.get(), PacedPacketInfo()); |
Erik Språng | 0f6191d | 2019-07-15 20:33:40 +0200 | [diff] [blame] | 2470 | webrtc::RTPHeader rtp_header; |
| 2471 | transport_.last_sent_packet().GetHeader(&rtp_header); |
| 2472 | EXPECT_TRUE(rtp_header.extension.hasAbsoluteSendTime); |
| 2473 | EXPECT_TRUE(rtp_header.extension.hasTransmissionTimeOffset); |
| 2474 | EXPECT_TRUE(rtp_header.extension.hasTransportSequenceNumber); |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 2475 | } |
| 2476 | |
| 2477 | EXPECT_EQ(padding_bytes_generated, |
| 2478 | kExpectedNumPaddingPackets * kMaxPaddingSize); |
Erik Språng | 478cb46 | 2019-06-26 15:49:27 +0200 | [diff] [blame] | 2479 | } |
| 2480 | |
Mirko Bonadei | 999a72a | 2019-07-12 17:33:46 +0000 | [diff] [blame] | 2481 | TEST_P(RtpSenderTest, SupportsPadding) { |
| 2482 | bool kSendingMediaStats[] = {true, false}; |
| 2483 | bool kEnableRedundantPayloads[] = {true, false}; |
| 2484 | RTPExtensionType kBweExtensionTypes[] = { |
| 2485 | kRtpExtensionTransportSequenceNumber, |
| 2486 | kRtpExtensionTransportSequenceNumber02, kRtpExtensionAbsoluteSendTime, |
| 2487 | kRtpExtensionTransmissionTimeOffset}; |
| 2488 | const int kExtensionsId = 7; |
| 2489 | |
| 2490 | for (bool sending_media : kSendingMediaStats) { |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 2491 | rtp_sender()->SetSendingMediaStatus(sending_media); |
Mirko Bonadei | 999a72a | 2019-07-12 17:33:46 +0000 | [diff] [blame] | 2492 | for (bool redundant_payloads : kEnableRedundantPayloads) { |
| 2493 | int rtx_mode = kRtxRetransmitted; |
| 2494 | if (redundant_payloads) { |
| 2495 | rtx_mode |= kRtxRedundantPayloads; |
| 2496 | } |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 2497 | rtp_sender()->SetRtxStatus(rtx_mode); |
Mirko Bonadei | 999a72a | 2019-07-12 17:33:46 +0000 | [diff] [blame] | 2498 | |
| 2499 | for (auto extension_type : kBweExtensionTypes) { |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 2500 | EXPECT_FALSE(rtp_sender()->SupportsPadding()); |
| 2501 | rtp_sender()->RegisterRtpHeaderExtension(extension_type, kExtensionsId); |
Mirko Bonadei | 999a72a | 2019-07-12 17:33:46 +0000 | [diff] [blame] | 2502 | if (!sending_media) { |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 2503 | EXPECT_FALSE(rtp_sender()->SupportsPadding()); |
Mirko Bonadei | 999a72a | 2019-07-12 17:33:46 +0000 | [diff] [blame] | 2504 | } else { |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 2505 | EXPECT_TRUE(rtp_sender()->SupportsPadding()); |
Mirko Bonadei | 999a72a | 2019-07-12 17:33:46 +0000 | [diff] [blame] | 2506 | if (redundant_payloads) { |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 2507 | EXPECT_TRUE(rtp_sender()->SupportsRtxPayloadPadding()); |
Mirko Bonadei | 999a72a | 2019-07-12 17:33:46 +0000 | [diff] [blame] | 2508 | } else { |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 2509 | EXPECT_FALSE(rtp_sender()->SupportsRtxPayloadPadding()); |
Mirko Bonadei | 999a72a | 2019-07-12 17:33:46 +0000 | [diff] [blame] | 2510 | } |
| 2511 | } |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 2512 | rtp_sender()->DeregisterRtpHeaderExtension(extension_type); |
| 2513 | EXPECT_FALSE(rtp_sender()->SupportsPadding()); |
Mirko Bonadei | 999a72a | 2019-07-12 17:33:46 +0000 | [diff] [blame] | 2514 | } |
| 2515 | } |
| 2516 | } |
| 2517 | } |
| 2518 | |
Erik Språng | a57711c | 2019-07-24 10:47:20 +0200 | [diff] [blame] | 2519 | TEST_P(RtpSenderTest, SetsCaptureTimeAndPopulatesTransmissionOffset) { |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 2520 | rtp_sender()->RegisterRtpHeaderExtension(kRtpExtensionTransmissionTimeOffset, |
| 2521 | kTransmissionTimeOffsetExtensionId); |
Erik Språng | a57711c | 2019-07-24 10:47:20 +0200 | [diff] [blame] | 2522 | |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 2523 | rtp_sender()->SetSendingMediaStatus(true); |
| 2524 | rtp_sender()->SetRtxStatus(kRtxRetransmitted | kRtxRedundantPayloads); |
| 2525 | rtp_sender()->SetRtxPayloadType(kRtxPayload, kPayload); |
| 2526 | rtp_sender_context_->packet_history_.SetStorePacketsStatus( |
| 2527 | RtpPacketHistory::StorageMode::kStoreAndCull, 10); |
Erik Språng | a57711c | 2019-07-24 10:47:20 +0200 | [diff] [blame] | 2528 | |
| 2529 | const int64_t kMissingCaptureTimeMs = 0; |
| 2530 | const uint32_t kTimestampTicksPerMs = 90; |
| 2531 | const int64_t kOffsetMs = 10; |
| 2532 | |
Erik Språng | a57711c | 2019-07-24 10:47:20 +0200 | [diff] [blame] | 2533 | auto packet = |
| 2534 | BuildRtpPacket(kPayload, kMarkerBit, fake_clock_.TimeInMilliseconds(), |
| 2535 | kMissingCaptureTimeMs); |
| 2536 | packet->set_packet_type(RtpPacketToSend::Type::kVideo); |
| 2537 | packet->ReserveExtension<TransmissionOffset>(); |
| 2538 | packet->AllocatePayload(sizeof(kPayloadData)); |
| 2539 | |
| 2540 | std::unique_ptr<RtpPacketToSend> packet_to_pace; |
Erik Språng | ea55b08 | 2019-10-02 14:57:46 +0200 | [diff] [blame] | 2541 | EXPECT_CALL(mock_paced_sender_, EnqueuePackets) |
| 2542 | .WillOnce([&](std::vector<std::unique_ptr<RtpPacketToSend>> packets) { |
| 2543 | EXPECT_EQ(packets.size(), 1u); |
| 2544 | EXPECT_GT(packets[0]->capture_time_ms(), 0); |
| 2545 | packet_to_pace = std::move(packets[0]); |
Erik Språng | a57711c | 2019-07-24 10:47:20 +0200 | [diff] [blame] | 2546 | }); |
| 2547 | |
Erik Språng | 70768f4 | 2019-08-27 18:16:26 +0200 | [diff] [blame] | 2548 | packet->set_allow_retransmission(true); |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 2549 | EXPECT_TRUE(rtp_sender()->SendToNetwork(std::move(packet))); |
Erik Språng | a57711c | 2019-07-24 10:47:20 +0200 | [diff] [blame] | 2550 | |
| 2551 | fake_clock_.AdvanceTimeMilliseconds(kOffsetMs); |
| 2552 | |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 2553 | rtp_egress()->SendPacket(packet_to_pace.get(), PacedPacketInfo()); |
Erik Språng | a57711c | 2019-07-24 10:47:20 +0200 | [diff] [blame] | 2554 | |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 2555 | EXPECT_EQ(1, transport_.packets_sent()); |
| 2556 | absl::optional<int32_t> transmission_time_extension = |
| 2557 | transport_.sent_packets_.back().GetExtension<TransmissionOffset>(); |
| 2558 | ASSERT_TRUE(transmission_time_extension.has_value()); |
| 2559 | EXPECT_EQ(*transmission_time_extension, kOffsetMs * kTimestampTicksPerMs); |
Erik Språng | a57711c | 2019-07-24 10:47:20 +0200 | [diff] [blame] | 2560 | |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 2561 | // Retransmit packet. The RTX packet should get the same capture time as the |
| 2562 | // original packet, so offset is delta from original packet to now. |
| 2563 | fake_clock_.AdvanceTimeMilliseconds(kOffsetMs); |
Erik Språng | a57711c | 2019-07-24 10:47:20 +0200 | [diff] [blame] | 2564 | |
Erik Språng | a57711c | 2019-07-24 10:47:20 +0200 | [diff] [blame] | 2565 | std::unique_ptr<RtpPacketToSend> rtx_packet_to_pace; |
Erik Språng | ea55b08 | 2019-10-02 14:57:46 +0200 | [diff] [blame] | 2566 | EXPECT_CALL(mock_paced_sender_, EnqueuePackets) |
| 2567 | .WillOnce([&](std::vector<std::unique_ptr<RtpPacketToSend>> packets) { |
| 2568 | EXPECT_GT(packets[0]->capture_time_ms(), 0); |
| 2569 | rtx_packet_to_pace = std::move(packets[0]); |
Erik Språng | a57711c | 2019-07-24 10:47:20 +0200 | [diff] [blame] | 2570 | }); |
| 2571 | |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 2572 | EXPECT_GT(rtp_sender()->ReSendPacket(kSeqNum), 0); |
| 2573 | rtp_egress()->SendPacket(rtx_packet_to_pace.get(), PacedPacketInfo()); |
Erik Språng | a57711c | 2019-07-24 10:47:20 +0200 | [diff] [blame] | 2574 | |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 2575 | EXPECT_EQ(2, transport_.packets_sent()); |
| 2576 | transmission_time_extension = |
| 2577 | transport_.sent_packets_.back().GetExtension<TransmissionOffset>(); |
| 2578 | ASSERT_TRUE(transmission_time_extension.has_value()); |
| 2579 | EXPECT_EQ(*transmission_time_extension, |
| 2580 | 2 * kOffsetMs * kTimestampTicksPerMs); |
Erik Språng | a57711c | 2019-07-24 10:47:20 +0200 | [diff] [blame] | 2581 | } |
| 2582 | |
Erik Språng | 6cacef2 | 2019-07-24 14:15:51 +0200 | [diff] [blame] | 2583 | TEST_P(RtpSenderTestWithoutPacer, ClearHistoryOnSequenceNumberCange) { |
| 2584 | const int64_t kRtt = 10; |
| 2585 | |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 2586 | rtp_sender()->SetSendingMediaStatus(true); |
| 2587 | rtp_sender()->SetRtxStatus(kRtxRetransmitted | kRtxRedundantPayloads); |
| 2588 | rtp_sender()->SetRtxPayloadType(kRtxPayload, kPayload); |
| 2589 | rtp_sender_context_->packet_history_.SetStorePacketsStatus( |
| 2590 | RtpPacketHistory::StorageMode::kStoreAndCull, 10); |
| 2591 | rtp_sender_context_->packet_history_.SetRtt(kRtt); |
Erik Språng | 6cacef2 | 2019-07-24 14:15:51 +0200 | [diff] [blame] | 2592 | |
| 2593 | // Send a packet and record its sequence numbers. |
| 2594 | SendGenericPacket(); |
| 2595 | ASSERT_EQ(1u, transport_.sent_packets_.size()); |
| 2596 | const uint16_t packet_seqence_number = |
| 2597 | transport_.sent_packets_.back().SequenceNumber(); |
| 2598 | |
| 2599 | // Advance time and make sure it can be retransmitted, even if we try to set |
| 2600 | // the ssrc the what it already is. |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 2601 | rtp_sender()->SetSequenceNumber(rtp_sender()->SequenceNumber()); |
Erik Språng | 6cacef2 | 2019-07-24 14:15:51 +0200 | [diff] [blame] | 2602 | fake_clock_.AdvanceTimeMilliseconds(kRtt); |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 2603 | EXPECT_GT(rtp_sender()->ReSendPacket(packet_seqence_number), 0); |
Erik Språng | 6cacef2 | 2019-07-24 14:15:51 +0200 | [diff] [blame] | 2604 | |
| 2605 | // Change the sequence number, then move the time and try to retransmit again. |
| 2606 | // The old packet should now be gone. |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 2607 | rtp_sender()->SetSequenceNumber(rtp_sender()->SequenceNumber() - 1); |
Erik Språng | 6cacef2 | 2019-07-24 14:15:51 +0200 | [diff] [blame] | 2608 | fake_clock_.AdvanceTimeMilliseconds(kRtt); |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 2609 | EXPECT_EQ(rtp_sender()->ReSendPacket(packet_seqence_number), 0); |
Erik Språng | 6cacef2 | 2019-07-24 14:15:51 +0200 | [diff] [blame] | 2610 | } |
| 2611 | |
Erik Språng | 60ffc31 | 2019-07-30 22:03:49 +0200 | [diff] [blame] | 2612 | TEST_P(RtpSenderTest, IgnoresNackAfterDisablingMedia) { |
| 2613 | const int64_t kRtt = 10; |
| 2614 | |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 2615 | rtp_sender()->SetSendingMediaStatus(true); |
| 2616 | rtp_sender()->SetRtxStatus(kRtxRetransmitted | kRtxRedundantPayloads); |
| 2617 | rtp_sender()->SetRtxPayloadType(kRtxPayload, kPayload); |
| 2618 | rtp_sender_context_->packet_history_.SetStorePacketsStatus( |
| 2619 | RtpPacketHistory::StorageMode::kStoreAndCull, 10); |
| 2620 | rtp_sender_context_->packet_history_.SetRtt(kRtt); |
Erik Språng | 60ffc31 | 2019-07-30 22:03:49 +0200 | [diff] [blame] | 2621 | |
| 2622 | // Send a packet so it is in the packet history. |
Erik Språng | 60ffc31 | 2019-07-30 22:03:49 +0200 | [diff] [blame] | 2623 | std::unique_ptr<RtpPacketToSend> packet_to_pace; |
Erik Språng | ea55b08 | 2019-10-02 14:57:46 +0200 | [diff] [blame] | 2624 | EXPECT_CALL(mock_paced_sender_, EnqueuePackets) |
| 2625 | .WillOnce([&](std::vector<std::unique_ptr<RtpPacketToSend>> packets) { |
| 2626 | packet_to_pace = std::move(packets[0]); |
Erik Språng | 60ffc31 | 2019-07-30 22:03:49 +0200 | [diff] [blame] | 2627 | }); |
| 2628 | |
| 2629 | SendGenericPacket(); |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 2630 | rtp_egress()->SendPacket(packet_to_pace.get(), PacedPacketInfo()); |
Erik Språng | 60ffc31 | 2019-07-30 22:03:49 +0200 | [diff] [blame] | 2631 | |
| 2632 | ASSERT_EQ(1u, transport_.sent_packets_.size()); |
| 2633 | |
| 2634 | // Disable media sending and try to retransmit the packet, it should fail. |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 2635 | rtp_sender()->SetSendingMediaStatus(false); |
Erik Språng | 60ffc31 | 2019-07-30 22:03:49 +0200 | [diff] [blame] | 2636 | fake_clock_.AdvanceTimeMilliseconds(kRtt); |
Erik Språng | b533010 | 2019-10-28 10:09:43 +0100 | [diff] [blame^] | 2637 | EXPECT_LT(rtp_sender()->ReSendPacket(kSeqNum), 0); |
Erik Språng | 60ffc31 | 2019-07-30 22:03:49 +0200 | [diff] [blame] | 2638 | } |
| 2639 | |
Mirko Bonadei | c84f661 | 2019-01-31 12:20:57 +0100 | [diff] [blame] | 2640 | INSTANTIATE_TEST_SUITE_P(WithAndWithoutOverhead, |
| 2641 | RtpSenderTest, |
Erik Språng | f5815fa | 2019-08-21 14:27:31 +0200 | [diff] [blame] | 2642 | ::testing::Values(TestConfig{false}, |
| 2643 | TestConfig{true})); |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 2644 | |
Mirko Bonadei | c84f661 | 2019-01-31 12:20:57 +0100 | [diff] [blame] | 2645 | INSTANTIATE_TEST_SUITE_P(WithAndWithoutOverhead, |
| 2646 | RtpSenderTestWithoutPacer, |
Erik Språng | f5815fa | 2019-08-21 14:27:31 +0200 | [diff] [blame] | 2647 | ::testing::Values(TestConfig{false}, |
| 2648 | TestConfig{true})); |
Niels Möller | a34d776 | 2019-02-01 14:13:29 +0100 | [diff] [blame] | 2649 | |
solenberg@webrtc.org | c0352d5 | 2013-05-20 20:55:07 +0000 | [diff] [blame] | 2650 | } // namespace webrtc |