blob: b51b95b7af2299fce7a079c1bb48c9869dca15b4 [file] [log] [blame]
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +00001/*
phoglund@webrtc.org78088c22012-02-07 14:56:45 +00002 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +00003 *
4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
9 */
10
Jonas Olssona4d87372019-07-05 19:08:33 +020011#include "modules/rtp_rtcp/source/rtp_sender.h"
12
kwiberg84be5112016-04-27 01:19:58 -070013#include <memory>
danilchapb8b6fbb2015-12-10 05:05:27 -080014#include <vector>
15
Danil Chapovalov16cb1f62019-09-05 11:29:59 +020016#include "api/rtc_event_log/rtc_event.h"
Per Kjellandere11b7d22019-02-21 07:55:59 +010017#include "api/transport/field_trial_based_config.h"
Erik Språngf93eda12019-01-16 17:10:57 +010018#include "api/video/video_codec_constants.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020019#include "api/video/video_timing.h"
20#include "logging/rtc_event_log/mock/mock_rtc_event_log.h"
21#include "modules/rtp_rtcp/include/rtp_cvo.h"
22#include "modules/rtp_rtcp/include/rtp_header_extension_map.h"
Erik Språngaa59eca2019-07-24 14:52:55 +020023#include "modules/rtp_rtcp/include/rtp_packet_sender.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020024#include "modules/rtp_rtcp/include/rtp_rtcp_defines.h"
25#include "modules/rtp_rtcp/source/rtcp_packet/transport_feedback.h"
26#include "modules/rtp_rtcp/source/rtp_format_video_generic.h"
philipelb3e42a42018-09-13 10:57:14 +020027#include "modules/rtp_rtcp/source/rtp_generic_frame_descriptor.h"
28#include "modules/rtp_rtcp/source/rtp_generic_frame_descriptor_extension.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020029#include "modules/rtp_rtcp/source/rtp_header_extensions.h"
30#include "modules/rtp_rtcp/source/rtp_packet_received.h"
31#include "modules/rtp_rtcp/source/rtp_packet_to_send.h"
Erik Språngb5330102019-10-28 10:09:43 +010032#include "modules/rtp_rtcp/source/rtp_sender_egress.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020033#include "modules/rtp_rtcp/source/rtp_sender_video.h"
34#include "modules/rtp_rtcp/source/rtp_utility.h"
35#include "rtc_base/arraysize.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020036#include "rtc_base/rate_limiter.h"
37#include "test/field_trial.h"
38#include "test/gmock.h"
39#include "test/gtest.h"
40#include "test/mock_transport.h"
Tommi25eb47c2019-08-29 16:39:05 +020041#include "test/rtp_header_parser.h"
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +000042
43namespace webrtc {
44
andrew@webrtc.org8a442592011-12-16 21:24:30 +000045namespace {
Elad Alond8d32482019-02-18 23:45:57 +010046enum : int { // The first valid value is 1.
47 kAbsoluteSendTimeExtensionId = 1,
48 kAudioLevelExtensionId,
Elad Alonccb9b752019-02-19 13:01:31 +010049 kGenericDescriptorId00,
50 kGenericDescriptorId01,
Elad Alond8d32482019-02-18 23:45:57 +010051 kMidExtensionId,
52 kRepairedRidExtensionId,
53 kRidExtensionId,
54 kTransmissionTimeOffsetExtensionId,
55 kTransportSequenceNumberExtensionId,
56 kVideoRotationExtensionId,
57 kVideoTimingExtensionId,
58};
59
andrew@webrtc.org8a442592011-12-16 21:24:30 +000060const int kPayload = 100;
Shao Changbine62202f2015-04-21 20:24:50 +080061const int kRtxPayload = 98;
andrew@webrtc.org8a442592011-12-16 21:24:30 +000062const uint32_t kTimestamp = 10;
63const uint16_t kSeqNum = 33;
brandtr9dfff292016-11-14 05:14:50 -080064const uint32_t kSsrc = 725242;
Erik Språng9c771c22019-06-17 16:31:53 +020065const uint32_t kRtxSsrc = 12345;
66const uint32_t kFlexFecSsrc = 45678;
Erik Språng1fbfecd2019-08-26 19:00:05 +020067const uint16_t kTransportSequenceNumber = 1;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +000068const uint64_t kStartTime = 123456789;
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +000069const size_t kMaxPaddingSize = 224u;
Stefan Holmera246cfb2016-08-23 17:51:42 +020070const uint8_t kPayloadData[] = {47, 11, 32, 93, 89};
spranga8ae6f22017-09-04 07:23:56 -070071const int64_t kDefaultExpectedRetransmissionTimeMs = 125;
Amit Hilbuch77938e62018-12-21 09:23:38 -080072const char kNoRid[] = "";
73const char kNoMid[] = "";
andrew@webrtc.org8a442592011-12-16 21:24:30 +000074
Danil Chapovalov5e57b172016-09-02 19:15:59 +020075using ::testing::_;
Erik Språng30a276b2019-04-23 12:00:11 +020076using ::testing::AllOf;
Erik Språngea55b082019-10-02 14:57:46 +020077using ::testing::Contains;
Danil Chapovalov5e57b172016-09-02 19:15:59 +020078using ::testing::ElementsAreArray;
Erik Språng30a276b2019-04-23 12:00:11 +020079using ::testing::Field;
Erik Språng9c771c22019-06-17 16:31:53 +020080using ::testing::NiceMock;
Erik Språng478cb462019-06-26 15:49:27 +020081using ::testing::Pointee;
82using ::testing::Property;
Erik Språng214f5432019-06-20 15:09:58 +020083using ::testing::Return;
Erik Språng9c771c22019-06-17 16:31:53 +020084using ::testing::StrictMock;
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +000085
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +000086uint64_t ConvertMsToAbsSendTime(int64_t time_ms) {
Stefan Holmer0a87ffc2015-10-21 13:41:48 +020087 return (((time_ms << 18) + 500) / 1000) & 0x00ffffff;
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +000088}
89
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +000090class LoopbackTransportTest : public webrtc::Transport {
91 public:
Petter Strandmark26bc6692018-05-29 08:43:35 +020092 LoopbackTransportTest() : total_bytes_sent_(0) {
Danil Chapovalova74e4772019-09-12 17:53:04 +020093 receivers_extensions_.Register<TransmissionOffset>(
94 kTransmissionTimeOffsetExtensionId);
95 receivers_extensions_.Register<AbsoluteSendTime>(
96 kAbsoluteSendTimeExtensionId);
97 receivers_extensions_.Register<TransportSequenceNumber>(
98 kTransportSequenceNumberExtensionId);
99 receivers_extensions_.Register<VideoOrientation>(kVideoRotationExtensionId);
100 receivers_extensions_.Register<AudioLevel>(kAudioLevelExtensionId);
101 receivers_extensions_.Register<VideoTimingExtension>(
102 kVideoTimingExtensionId);
103 receivers_extensions_.Register<RtpMid>(kMidExtensionId);
104 receivers_extensions_.Register<RtpGenericFrameDescriptorExtension00>(
105 kGenericDescriptorId00);
106 receivers_extensions_.Register<RtpGenericFrameDescriptorExtension01>(
107 kGenericDescriptorId01);
108 receivers_extensions_.Register<RtpStreamId>(kRidExtensionId);
109 receivers_extensions_.Register<RepairedRtpStreamId>(
110 kRepairedRidExtensionId);
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000111 }
danilchap12ba1862016-10-26 02:41:55 -0700112
stefan1d8a5062015-10-02 03:39:33 -0700113 bool SendRtp(const uint8_t* data,
114 size_t len,
115 const PacketOptions& options) override {
Petter Strandmark26bc6692018-05-29 08:43:35 +0200116 last_options_ = options;
pkasting@chromium.org4591fbd2014-11-20 22:28:14 +0000117 total_bytes_sent_ += len;
danilchap12ba1862016-10-26 02:41:55 -0700118 sent_packets_.push_back(RtpPacketReceived(&receivers_extensions_));
119 EXPECT_TRUE(sent_packets_.back().Parse(data, len));
pbos2d566682015-09-28 09:59:31 -0700120 return true;
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000121 }
danilchap162abd32015-12-10 02:39:40 -0800122 bool SendRtcp(const uint8_t* data, size_t len) override { return false; }
danilchap12ba1862016-10-26 02:41:55 -0700123 const RtpPacketReceived& last_sent_packet() { return sent_packets_.back(); }
124 int packets_sent() { return sent_packets_.size(); }
125
pbos@webrtc.org72491b92014-07-10 16:24:54 +0000126 size_t total_bytes_sent_;
Petter Strandmark26bc6692018-05-29 08:43:35 +0200127 PacketOptions last_options_;
danilchap12ba1862016-10-26 02:41:55 -0700128 std::vector<RtpPacketReceived> sent_packets_;
129
130 private:
131 RtpHeaderExtensionMap receivers_extensions_;
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000132};
133
Elad Alon4a87e1c2017-10-03 16:11:34 +0200134MATCHER_P(SameRtcEventTypeAs, value, "") {
135 return value == arg->GetType();
136}
137
Erik Språngf6468d22019-07-05 16:53:43 +0200138struct TestConfig {
Erik Språngf5815fa2019-08-21 14:27:31 +0200139 explicit TestConfig(bool with_overhead) : with_overhead(with_overhead) {}
Erik Språngf6468d22019-07-05 16:53:43 +0200140 bool with_overhead = false;
Erik Språngf6468d22019-07-05 16:53:43 +0200141};
142
143std::string ToFieldTrialString(TestConfig config) {
144 std::string field_trials;
145 if (config.with_overhead) {
146 field_trials += "WebRTC-SendSideBwe-WithOverhead/Enabled/";
147 }
Erik Språngf6468d22019-07-05 16:53:43 +0200148 return field_trials;
149}
150
Erik Språngaa59eca2019-07-24 14:52:55 +0200151class MockRtpPacketPacer : public RtpPacketSender {
sprangebbf8a82015-09-21 15:11:14 -0700152 public:
Erik Språng59b86542019-06-23 18:24:46 +0200153 MockRtpPacketPacer() {}
154 virtual ~MockRtpPacketPacer() {}
155
Erik Språngea55b082019-10-02 14:57:46 +0200156 MOCK_METHOD1(EnqueuePackets,
157 void(std::vector<std::unique_ptr<RtpPacketToSend>>));
sprangebbf8a82015-09-21 15:11:14 -0700158
Erik Språngaa59eca2019-07-24 14:52:55 +0200159 MOCK_METHOD2(CreateProbeCluster, void(int bitrate_bps, int cluster_id));
160
161 MOCK_METHOD0(Pause, void());
162 MOCK_METHOD0(Resume, void());
163 MOCK_METHOD1(SetCongestionWindow,
164 void(absl::optional<int64_t> congestion_window_bytes));
165 MOCK_METHOD1(UpdateOutstandingData, void(int64_t outstanding_bytes));
166 MOCK_METHOD1(SetAccountForAudioPackets, void(bool account_for_audio));
sprangebbf8a82015-09-21 15:11:14 -0700167};
168
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200169class MockSendSideDelayObserver : public SendSideDelayObserver {
170 public:
Henrik Boström9fe18342019-05-16 18:38:20 +0200171 MOCK_METHOD4(SendSideDelayUpdated, void(int, int, uint64_t, uint32_t));
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200172};
173
asapersson35151f32016-05-02 23:44:01 -0700174class MockSendPacketObserver : public SendPacketObserver {
175 public:
176 MOCK_METHOD3(OnSendPacket, void(uint16_t, int64_t, uint32_t));
177};
178
Stefan Holmera246cfb2016-08-23 17:51:42 +0200179class MockTransportFeedbackObserver : public TransportFeedbackObserver {
180 public:
Erik Språng30a276b2019-04-23 12:00:11 +0200181 MOCK_METHOD1(OnAddPacket, void(const RtpPacketSendInfo&));
Stefan Holmera246cfb2016-08-23 17:51:42 +0200182 MOCK_METHOD1(OnTransportFeedback, void(const rtcp::TransportFeedback&));
elad.alonf9490002017-03-06 05:32:21 -0800183 MOCK_CONST_METHOD0(GetTransportFeedbackVector, std::vector<PacketFeedback>());
Stefan Holmera246cfb2016-08-23 17:51:42 +0200184};
185
minyue3a407ee2017-04-03 01:10:33 -0700186class MockOverheadObserver : public OverheadObserver {
187 public:
188 MOCK_METHOD1(OnOverheadChanged, void(size_t overhead_bytes_per_packet));
189};
190
Erik Språng7ea9b802019-10-16 19:03:38 +0200191class StreamDataTestCallback : public StreamDataCountersCallback {
192 public:
193 StreamDataTestCallback()
194 : StreamDataCountersCallback(), ssrc_(0), counters_() {}
195 ~StreamDataTestCallback() override = default;
196
197 void DataCountersUpdated(const StreamDataCounters& counters,
198 uint32_t ssrc) override {
199 ssrc_ = ssrc;
200 counters_ = counters;
201 }
202
203 uint32_t ssrc_;
204 StreamDataCounters counters_;
205
206 void MatchPacketCounter(const RtpPacketCounter& expected,
207 const RtpPacketCounter& actual) {
208 EXPECT_EQ(expected.payload_bytes, actual.payload_bytes);
209 EXPECT_EQ(expected.header_bytes, actual.header_bytes);
210 EXPECT_EQ(expected.padding_bytes, actual.padding_bytes);
211 EXPECT_EQ(expected.packets, actual.packets);
212 }
213
214 void Matches(uint32_t ssrc, const StreamDataCounters& counters) {
215 EXPECT_EQ(ssrc, ssrc_);
216 MatchPacketCounter(counters.transmitted, counters_.transmitted);
217 MatchPacketCounter(counters.retransmitted, counters_.retransmitted);
218 EXPECT_EQ(counters.fec.packets, counters_.fec.packets);
219 }
220};
221
Erik Språngb5330102019-10-28 10:09:43 +0100222// Mimics ModuleRtpRtcp::RtpSenderContext.
223// TODO(sprang): Split up unit tests and test these components individually
224// wherever possible.
225struct RtpSenderContext {
226 explicit RtpSenderContext(const RtpRtcp::Configuration& config)
227 : packet_history_(config.clock),
228 packet_sender_(config, &packet_history_),
229 non_paced_sender_(&packet_sender_),
230 packet_generator_(
231 config,
232 &packet_history_,
233 config.paced_sender ? config.paced_sender : &non_paced_sender_) {}
234 RtpPacketHistory packet_history_;
235 RtpSenderEgress packet_sender_;
236 RtpSenderEgress::NonPacedPacketSender non_paced_sender_;
237 RTPSender packet_generator_;
238};
239
240} // namespace
241
Erik Språngf6468d22019-07-05 16:53:43 +0200242class RtpSenderTest : public ::testing::TestWithParam<TestConfig> {
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000243 protected:
244 RtpSenderTest()
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +0000245 : fake_clock_(kStartTime),
sprangcd349d92016-07-13 09:11:28 -0700246 retransmission_rate_limiter_(&fake_clock_, 1000),
Erik Språng4580ca22019-07-04 10:38:43 +0200247 flexfec_sender_(0,
248 kFlexFecSsrc,
249 kSsrc,
250 "",
251 std::vector<RtpExtension>(),
252 std::vector<RtpExtensionSize>(),
253 nullptr,
254 &fake_clock_),
minyue3a407ee2017-04-03 01:10:33 -0700255 kMarkerBit(true),
Erik Språngf6468d22019-07-05 16:53:43 +0200256 field_trials_(ToFieldTrialString(GetParam())) {}
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +0000257
Erik Språng7b52f102018-02-07 14:37:37 +0100258 void SetUp() override { SetUpRtpSender(true, false); }
Peter Boströme23e7372015-10-08 11:44:14 +0200259
Erik Språngb5330102019-10-28 10:09:43 +0100260 RTPSender* rtp_sender() {
261 RTC_DCHECK(rtp_sender_context_);
262 return &rtp_sender_context_->packet_generator_;
263 }
264
265 RtpSenderEgress* rtp_egress() {
266 RTC_DCHECK(rtp_sender_context_);
267 return &rtp_sender_context_->packet_sender_;
268 }
269
Erik Språng7b52f102018-02-07 14:37:37 +0100270 void SetUpRtpSender(bool pacer, bool populate_network2) {
Erik Språng4580ca22019-07-04 10:38:43 +0200271 RtpRtcp::Configuration config;
272 config.clock = &fake_clock_;
273 config.outgoing_transport = &transport_;
Erik Språng54d5d2c2019-08-20 17:22:36 +0200274 config.local_media_ssrc = kSsrc;
Erik Språng4580ca22019-07-04 10:38:43 +0200275 config.rtx_send_ssrc = kRtxSsrc;
276 config.flexfec_sender = &flexfec_sender_;
Erik Språng4580ca22019-07-04 10:38:43 +0200277 config.event_log = &mock_rtc_event_log_;
278 config.send_packet_observer = &send_packet_observer_;
279 config.retransmission_rate_limiter = &retransmission_rate_limiter_;
280 config.paced_sender = pacer ? &mock_paced_sender_ : nullptr;
281 config.populate_network2_timestamp = populate_network2;
Erik Språng7ea9b802019-10-16 19:03:38 +0200282 config.rtp_stats_callback = &rtp_stats_callback_;
Erik Språngb5330102019-10-28 10:09:43 +0100283 rtp_sender_context_ = std::make_unique<RtpSenderContext>(config);
284 rtp_sender()->SetSequenceNumber(kSeqNum);
285 rtp_sender()->SetTimestampOffset(0);
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +0000286 }
287
stefan@webrtc.orga678a3b2013-01-21 07:42:11 +0000288 SimulatedClock fake_clock_;
Erik Språng9c771c22019-06-17 16:31:53 +0200289 NiceMock<MockRtcEventLog> mock_rtc_event_log_;
Erik Språng59b86542019-06-23 18:24:46 +0200290 MockRtpPacketPacer mock_paced_sender_;
Erik Språng9c771c22019-06-17 16:31:53 +0200291 StrictMock<MockSendPacketObserver> send_packet_observer_;
292 StrictMock<MockTransportFeedbackObserver> feedback_observer_;
sprangcd349d92016-07-13 09:11:28 -0700293 RateLimiter retransmission_rate_limiter_;
Erik Språng4580ca22019-07-04 10:38:43 +0200294 FlexfecSender flexfec_sender_;
Erik Språngb5330102019-10-28 10:09:43 +0100295
296 std::unique_ptr<RtpSenderContext> rtp_sender_context_;
297
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000298 LoopbackTransportTest transport_;
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000299 const bool kMarkerBit;
minyue3a407ee2017-04-03 01:10:33 -0700300 test::ScopedFieldTrials field_trials_;
Erik Språng7ea9b802019-10-16 19:03:38 +0200301 StreamDataTestCallback rtp_stats_callback_;
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000302
danilchapb6f1fb52016-10-19 06:11:39 -0700303 std::unique_ptr<RtpPacketToSend> BuildRtpPacket(int payload_type,
304 bool marker_bit,
305 uint32_t timestamp,
306 int64_t capture_time_ms) {
Erik Språngb5330102019-10-28 10:09:43 +0100307 auto packet = rtp_sender()->AllocatePacket();
danilchapb6f1fb52016-10-19 06:11:39 -0700308 packet->SetPayloadType(payload_type);
Erik Språng60ffc312019-07-30 22:03:49 +0200309 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
danilchapb6f1fb52016-10-19 06:11:39 -0700310 packet->SetMarker(marker_bit);
311 packet->SetTimestamp(timestamp);
312 packet->set_capture_time_ms(capture_time_ms);
Erik Språngb5330102019-10-28 10:09:43 +0100313 EXPECT_TRUE(rtp_sender()->AssignSequenceNumber(packet.get()));
danilchapb6f1fb52016-10-19 06:11:39 -0700314 return packet;
315 }
316
Erik Språngf6468d22019-07-05 16:53:43 +0200317 std::unique_ptr<RtpPacketToSend> SendPacket(int64_t capture_time_ms,
318 int payload_length) {
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000319 uint32_t timestamp = capture_time_ms * 90;
danilchapb6f1fb52016-10-19 06:11:39 -0700320 auto packet =
321 BuildRtpPacket(kPayload, kMarkerBit, timestamp, capture_time_ms);
322 packet->AllocatePayload(payload_length);
Erik Språng70768f42019-08-27 18:16:26 +0200323 packet->set_allow_retransmission(true);
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000324
325 // Packet should be stored in a send bucket.
Erik Språngb5330102019-10-28 10:09:43 +0100326 EXPECT_TRUE(rtp_sender()->SendToNetwork(
327 std::make_unique<RtpPacketToSend>(*packet)));
Erik Språngf6468d22019-07-05 16:53:43 +0200328 return packet;
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000329 }
asapersson35151f32016-05-02 23:44:01 -0700330
Erik Språngf6468d22019-07-05 16:53:43 +0200331 std::unique_ptr<RtpPacketToSend> SendGenericPacket() {
asapersson35151f32016-05-02 23:44:01 -0700332 const int64_t kCaptureTimeMs = fake_clock_.TimeInMilliseconds();
Erik Språngf6468d22019-07-05 16:53:43 +0200333 return SendPacket(kCaptureTimeMs, sizeof(kPayloadData));
asapersson35151f32016-05-02 23:44:01 -0700334 }
Steve Anton2bac7da2019-07-21 15:04:21 -0400335
Erik Språng4208a132019-08-26 08:58:45 +0200336 size_t GenerateAndSendPadding(size_t target_size_bytes) {
337 size_t generated_bytes = 0;
Erik Språngb5330102019-10-28 10:09:43 +0100338 for (auto& packet :
339 rtp_sender()->GeneratePadding(target_size_bytes, true)) {
Erik Språng4208a132019-08-26 08:58:45 +0200340 generated_bytes += packet->payload_size() + packet->padding_size();
Erik Språngb5330102019-10-28 10:09:43 +0100341 rtp_egress()->SendPacket(packet.get(), PacedPacketInfo());
Erik Språng4208a132019-08-26 08:58:45 +0200342 }
343 return generated_bytes;
344 }
345
Steve Anton2bac7da2019-07-21 15:04:21 -0400346 // The following are helpers for configuring the RTPSender. They must be
347 // called before sending any packets.
348
349 // Enable the retransmission stream with sizable packet storage.
350 void EnableRtx() {
351 // RTX needs to be able to read the source packets from the packet store.
352 // Pick a number of packets to store big enough for any unit test.
353 constexpr uint16_t kNumberOfPacketsToStore = 100;
Erik Språngb5330102019-10-28 10:09:43 +0100354 rtp_sender_context_->packet_history_.SetStorePacketsStatus(
355 RtpPacketHistory::StorageMode::kStoreAndCull, kNumberOfPacketsToStore);
356 rtp_sender()->SetRtxPayloadType(kRtxPayload, kPayload);
357 rtp_sender()->SetRtxStatus(kRtxRetransmitted | kRtxRedundantPayloads);
Steve Anton2bac7da2019-07-21 15:04:21 -0400358 }
359
360 // Enable sending of the MID header extension for both the primary SSRC and
361 // the RTX SSRC.
362 void EnableMidSending(const std::string& mid) {
Erik Språngb5330102019-10-28 10:09:43 +0100363 rtp_sender()->RegisterRtpHeaderExtension(kRtpExtensionMid, kMidExtensionId);
364 rtp_sender()->SetMid(mid);
Steve Anton2bac7da2019-07-21 15:04:21 -0400365 }
366
367 // Enable sending of the RSID header extension for the primary SSRC and the
368 // RRSID header extension for the RTX SSRC.
369 void EnableRidSending(const std::string& rid) {
Erik Språngb5330102019-10-28 10:09:43 +0100370 rtp_sender()->RegisterRtpHeaderExtension(kRtpExtensionRtpStreamId,
371 kRidExtensionId);
372 rtp_sender()->RegisterRtpHeaderExtension(kRtpExtensionRepairedRtpStreamId,
373 kRepairedRidExtensionId);
374 rtp_sender()->SetRid(rid);
Steve Anton2bac7da2019-07-21 15:04:21 -0400375 }
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000376};
377
Peter Boströme23e7372015-10-08 11:44:14 +0200378// TODO(pbos): Move tests over from WithoutPacer to RtpSenderTest as this is our
379// default code path.
380class RtpSenderTestWithoutPacer : public RtpSenderTest {
381 public:
Erik Språng7b52f102018-02-07 14:37:37 +0100382 void SetUp() override { SetUpRtpSender(false, false); }
Peter Boströme23e7372015-10-08 11:44:14 +0200383};
384
minyue3a407ee2017-04-03 01:10:33 -0700385TEST_P(RtpSenderTestWithoutPacer, AllocatePacketSetCsrc) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200386 // Configure rtp_sender with csrc.
387 std::vector<uint32_t> csrcs;
388 csrcs.push_back(0x23456789);
Erik Språngb5330102019-10-28 10:09:43 +0100389 rtp_sender()->SetCsrcs(csrcs);
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200390
Erik Språngb5330102019-10-28 10:09:43 +0100391 auto packet = rtp_sender()->AllocatePacket();
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200392
393 ASSERT_TRUE(packet);
Erik Språngb5330102019-10-28 10:09:43 +0100394 EXPECT_EQ(rtp_sender()->SSRC(), packet->Ssrc());
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200395 EXPECT_EQ(csrcs, packet->Csrcs());
396}
397
minyue3a407ee2017-04-03 01:10:33 -0700398TEST_P(RtpSenderTestWithoutPacer, AllocatePacketReserveExtensions) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200399 // Configure rtp_sender with extensions.
Erik Språngb5330102019-10-28 10:09:43 +0100400 ASSERT_EQ(0, rtp_sender()->RegisterRtpHeaderExtension(
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200401 kRtpExtensionTransmissionTimeOffset,
402 kTransmissionTimeOffsetExtensionId));
Erik Språngb5330102019-10-28 10:09:43 +0100403 ASSERT_EQ(0,
404 rtp_sender()->RegisterRtpHeaderExtension(
405 kRtpExtensionAbsoluteSendTime, kAbsoluteSendTimeExtensionId));
406 ASSERT_EQ(0, rtp_sender()->RegisterRtpHeaderExtension(
407 kRtpExtensionAudioLevel, kAudioLevelExtensionId));
408 ASSERT_EQ(0, rtp_sender()->RegisterRtpHeaderExtension(
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200409 kRtpExtensionTransportSequenceNumber,
410 kTransportSequenceNumberExtensionId));
Erik Språngb5330102019-10-28 10:09:43 +0100411 ASSERT_EQ(0, rtp_sender()->RegisterRtpHeaderExtension(
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200412 kRtpExtensionVideoRotation, kVideoRotationExtensionId));
413
Erik Språngb5330102019-10-28 10:09:43 +0100414 auto packet = rtp_sender()->AllocatePacket();
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200415
416 ASSERT_TRUE(packet);
417 // Preallocate BWE extensions RtpSender set itself.
418 EXPECT_TRUE(packet->HasExtension<TransmissionOffset>());
419 EXPECT_TRUE(packet->HasExtension<AbsoluteSendTime>());
420 EXPECT_TRUE(packet->HasExtension<TransportSequenceNumber>());
421 // Do not allocate media specific extensions.
422 EXPECT_FALSE(packet->HasExtension<AudioLevel>());
423 EXPECT_FALSE(packet->HasExtension<VideoOrientation>());
424}
425
minyue3a407ee2017-04-03 01:10:33 -0700426TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberAdvanceSequenceNumber) {
Erik Språngb5330102019-10-28 10:09:43 +0100427 auto packet = rtp_sender()->AllocatePacket();
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200428 ASSERT_TRUE(packet);
Erik Språngb5330102019-10-28 10:09:43 +0100429 const uint16_t sequence_number = rtp_sender()->SequenceNumber();
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200430
Erik Språngb5330102019-10-28 10:09:43 +0100431 EXPECT_TRUE(rtp_sender()->AssignSequenceNumber(packet.get()));
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200432
433 EXPECT_EQ(sequence_number, packet->SequenceNumber());
Erik Språngb5330102019-10-28 10:09:43 +0100434 EXPECT_EQ(sequence_number + 1, rtp_sender()->SequenceNumber());
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200435}
436
minyue3a407ee2017-04-03 01:10:33 -0700437TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberFailsOnNotSending) {
Erik Språngb5330102019-10-28 10:09:43 +0100438 auto packet = rtp_sender()->AllocatePacket();
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200439 ASSERT_TRUE(packet);
440
Erik Språngb5330102019-10-28 10:09:43 +0100441 rtp_sender()->SetSendingMediaStatus(false);
442 EXPECT_FALSE(rtp_sender()->AssignSequenceNumber(packet.get()));
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200443}
444
Danil Chapovalovb3179c72018-03-22 10:13:07 +0100445TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberMayAllowPaddingOnVideo) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200446 constexpr size_t kPaddingSize = 100;
Erik Språngb5330102019-10-28 10:09:43 +0100447 auto packet = rtp_sender()->AllocatePacket();
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200448 ASSERT_TRUE(packet);
449
Erik Språngb5330102019-10-28 10:09:43 +0100450 ASSERT_TRUE(rtp_sender()->GeneratePadding(kPaddingSize, true).empty());
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200451 packet->SetMarker(false);
Erik Språngb5330102019-10-28 10:09:43 +0100452 ASSERT_TRUE(rtp_sender()->AssignSequenceNumber(packet.get()));
Danil Chapovalovb3179c72018-03-22 10:13:07 +0100453 // Packet without marker bit doesn't allow padding on video stream.
Erik Språngb5330102019-10-28 10:09:43 +0100454 ASSERT_TRUE(rtp_sender()->GeneratePadding(kPaddingSize, true).empty());
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200455
456 packet->SetMarker(true);
Erik Språngb5330102019-10-28 10:09:43 +0100457 ASSERT_TRUE(rtp_sender()->AssignSequenceNumber(packet.get()));
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200458 // Packet with marker bit allows send padding.
Erik Språngb5330102019-10-28 10:09:43 +0100459 ASSERT_FALSE(rtp_sender()->GeneratePadding(kPaddingSize, true).empty());
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200460}
461
Danil Chapovalovb3179c72018-03-22 10:13:07 +0100462TEST_P(RtpSenderTest, AssignSequenceNumberAllowsPaddingOnAudio) {
463 MockTransport transport;
Erik Språng4580ca22019-07-04 10:38:43 +0200464 RtpRtcp::Configuration config;
465 config.audio = true;
466 config.clock = &fake_clock_;
467 config.outgoing_transport = &transport;
468 config.paced_sender = &mock_paced_sender_;
Erik Språng54d5d2c2019-08-20 17:22:36 +0200469 config.local_media_ssrc = kSsrc;
Erik Språng4580ca22019-07-04 10:38:43 +0200470 config.event_log = &mock_rtc_event_log_;
471 config.retransmission_rate_limiter = &retransmission_rate_limiter_;
Erik Språngb5330102019-10-28 10:09:43 +0100472 rtp_sender_context_ = std::make_unique<RtpSenderContext>(config);
Erik Språng4580ca22019-07-04 10:38:43 +0200473
Erik Språngb5330102019-10-28 10:09:43 +0100474 rtp_sender()->SetTimestampOffset(0);
Danil Chapovalovb3179c72018-03-22 10:13:07 +0100475
Erik Språngb5330102019-10-28 10:09:43 +0100476 std::unique_ptr<RtpPacketToSend> audio_packet =
477 rtp_sender()->AllocatePacket();
Danil Chapovalovb3179c72018-03-22 10:13:07 +0100478 // Padding on audio stream allowed regardless of marker in the last packet.
479 audio_packet->SetMarker(false);
480 audio_packet->SetPayloadType(kPayload);
Erik Språngb5330102019-10-28 10:09:43 +0100481 rtp_sender()->AssignSequenceNumber(audio_packet.get());
Danil Chapovalovb3179c72018-03-22 10:13:07 +0100482
483 const size_t kPaddingSize = 59;
484 EXPECT_CALL(transport, SendRtp(_, kPaddingSize + kRtpHeaderSize, _))
Erik Språng214f5432019-06-20 15:09:58 +0200485 .WillOnce(Return(true));
Erik Språng4208a132019-08-26 08:58:45 +0200486 EXPECT_EQ(kPaddingSize, GenerateAndSendPadding(kPaddingSize));
Danil Chapovalovb3179c72018-03-22 10:13:07 +0100487
488 // Requested padding size is too small, will send a larger one.
489 const size_t kMinPaddingSize = 50;
490 EXPECT_CALL(transport, SendRtp(_, kMinPaddingSize + kRtpHeaderSize, _))
Erik Språng214f5432019-06-20 15:09:58 +0200491 .WillOnce(Return(true));
Erik Språng4208a132019-08-26 08:58:45 +0200492 EXPECT_EQ(kMinPaddingSize, GenerateAndSendPadding(kMinPaddingSize - 5));
Danil Chapovalovb3179c72018-03-22 10:13:07 +0100493}
494
minyue3a407ee2017-04-03 01:10:33 -0700495TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberSetPaddingTimestamps) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200496 constexpr size_t kPaddingSize = 100;
Erik Språngb5330102019-10-28 10:09:43 +0100497 auto packet = rtp_sender()->AllocatePacket();
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200498 ASSERT_TRUE(packet);
499 packet->SetMarker(true);
500 packet->SetTimestamp(kTimestamp);
501
Erik Språngb5330102019-10-28 10:09:43 +0100502 ASSERT_TRUE(rtp_sender()->AssignSequenceNumber(packet.get()));
503 auto padding_packets = rtp_sender()->GeneratePadding(kPaddingSize, true);
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200504
Erik Språng4208a132019-08-26 08:58:45 +0200505 ASSERT_EQ(1u, padding_packets.size());
danilchap12ba1862016-10-26 02:41:55 -0700506 // Verify padding packet timestamp.
Erik Språng4208a132019-08-26 08:58:45 +0200507 EXPECT_EQ(kTimestamp, padding_packets[0]->Timestamp());
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200508}
509
minyue3a407ee2017-04-03 01:10:33 -0700510TEST_P(RtpSenderTestWithoutPacer,
511 TransportFeedbackObserverGetsCorrectByteCount) {
512 constexpr int kRtpOverheadBytesPerPacket = 12 + 8;
Erik Språng9c771c22019-06-17 16:31:53 +0200513 NiceMock<MockOverheadObserver> mock_overhead_observer;
Erik Språng4580ca22019-07-04 10:38:43 +0200514
515 RtpRtcp::Configuration config;
516 config.clock = &fake_clock_;
517 config.outgoing_transport = &transport_;
Erik Språng54d5d2c2019-08-20 17:22:36 +0200518 config.local_media_ssrc = kSsrc;
Erik Språng4580ca22019-07-04 10:38:43 +0200519 config.transport_feedback_callback = &feedback_observer_;
520 config.event_log = &mock_rtc_event_log_;
521 config.retransmission_rate_limiter = &retransmission_rate_limiter_;
522 config.overhead_observer = &mock_overhead_observer;
Erik Språngb5330102019-10-28 10:09:43 +0100523 rtp_sender_context_ = std::make_unique<RtpSenderContext>(config);
Erik Språng4580ca22019-07-04 10:38:43 +0200524
Erik Språngb5330102019-10-28 10:09:43 +0100525 EXPECT_EQ(0, rtp_sender()->RegisterRtpHeaderExtension(
minyue3a407ee2017-04-03 01:10:33 -0700526 kRtpExtensionTransportSequenceNumber,
527 kTransportSequenceNumberExtensionId));
minyue3a407ee2017-04-03 01:10:33 -0700528
529 const size_t expected_bytes =
Erik Språngf6468d22019-07-05 16:53:43 +0200530 GetParam().with_overhead
531 ? sizeof(kPayloadData) + kRtpOverheadBytesPerPacket
532 : sizeof(kPayloadData);
minyue3a407ee2017-04-03 01:10:33 -0700533
534 EXPECT_CALL(feedback_observer_,
Erik Språng30a276b2019-04-23 12:00:11 +0200535 OnAddPacket(AllOf(
Erik Språngb5330102019-10-28 10:09:43 +0100536 Field(&RtpPacketSendInfo::ssrc, rtp_sender()->SSRC()),
Erik Språng30a276b2019-04-23 12:00:11 +0200537 Field(&RtpPacketSendInfo::transport_sequence_number,
538 kTransportSequenceNumber),
539 Field(&RtpPacketSendInfo::rtp_sequence_number,
Erik Språngb5330102019-10-28 10:09:43 +0100540 rtp_sender()->SequenceNumber()),
Erik Språng30a276b2019-04-23 12:00:11 +0200541 Field(&RtpPacketSendInfo::length, expected_bytes),
542 Field(&RtpPacketSendInfo::pacing_info, PacedPacketInfo()))))
minyue3a407ee2017-04-03 01:10:33 -0700543 .Times(1);
544 EXPECT_CALL(mock_overhead_observer,
545 OnOverheadChanged(kRtpOverheadBytesPerPacket))
546 .Times(1);
Niels Möllere7b9e6b2019-02-06 18:23:44 +0100547 SendGenericPacket();
minyue3a407ee2017-04-03 01:10:33 -0700548}
549
550TEST_P(RtpSenderTestWithoutPacer, SendsPacketsWithTransportSequenceNumber) {
Erik Språng4580ca22019-07-04 10:38:43 +0200551 RtpRtcp::Configuration config;
552 config.clock = &fake_clock_;
553 config.outgoing_transport = &transport_;
Erik Språng54d5d2c2019-08-20 17:22:36 +0200554 config.local_media_ssrc = kSsrc;
Erik Språng4580ca22019-07-04 10:38:43 +0200555 config.transport_feedback_callback = &feedback_observer_;
556 config.event_log = &mock_rtc_event_log_;
557 config.send_packet_observer = &send_packet_observer_;
558 config.retransmission_rate_limiter = &retransmission_rate_limiter_;
Erik Språngb5330102019-10-28 10:09:43 +0100559 rtp_sender_context_ = std::make_unique<RtpSenderContext>(config);
Erik Språng4580ca22019-07-04 10:38:43 +0200560
Erik Språngb5330102019-10-28 10:09:43 +0100561 EXPECT_EQ(0, rtp_sender()->RegisterRtpHeaderExtension(
Stefan Holmerf5dca482016-01-27 12:58:51 +0100562 kRtpExtensionTransportSequenceNumber,
563 kTransportSequenceNumberExtensionId));
564
asapersson35151f32016-05-02 23:44:01 -0700565 EXPECT_CALL(send_packet_observer_,
566 OnSendPacket(kTransportSequenceNumber, _, _))
567 .Times(1);
minyue3a407ee2017-04-03 01:10:33 -0700568
569 EXPECT_CALL(feedback_observer_,
Erik Språng30a276b2019-04-23 12:00:11 +0200570 OnAddPacket(AllOf(
Erik Språngb5330102019-10-28 10:09:43 +0100571 Field(&RtpPacketSendInfo::ssrc, rtp_sender()->SSRC()),
Erik Språng30a276b2019-04-23 12:00:11 +0200572 Field(&RtpPacketSendInfo::transport_sequence_number,
573 kTransportSequenceNumber),
574 Field(&RtpPacketSendInfo::rtp_sequence_number,
Erik Språngb5330102019-10-28 10:09:43 +0100575 rtp_sender()->SequenceNumber()),
Erik Språng30a276b2019-04-23 12:00:11 +0200576 Field(&RtpPacketSendInfo::pacing_info, PacedPacketInfo()))))
Stefan Holmera246cfb2016-08-23 17:51:42 +0200577 .Times(1);
asapersson35151f32016-05-02 23:44:01 -0700578
Niels Möllere7b9e6b2019-02-06 18:23:44 +0100579 SendGenericPacket();
Stefan Holmerf5dca482016-01-27 12:58:51 +0100580
danilchap12ba1862016-10-26 02:41:55 -0700581 const auto& packet = transport_.last_sent_packet();
582 uint16_t transport_seq_no;
583 ASSERT_TRUE(packet.GetExtension<TransportSequenceNumber>(&transport_seq_no));
584 EXPECT_EQ(kTransportSequenceNumber, transport_seq_no);
Petter Strandmark26bc6692018-05-29 08:43:35 +0200585 EXPECT_EQ(transport_.last_options_.packet_id, transport_seq_no);
Sebastian Jansson1bca65b2018-10-10 09:58:08 +0200586 EXPECT_TRUE(transport_.last_options_.included_in_allocation);
Petter Strandmark26bc6692018-05-29 08:43:35 +0200587}
588
589TEST_P(RtpSenderTestWithoutPacer, PacketOptionsNoRetransmission) {
Erik Språng4580ca22019-07-04 10:38:43 +0200590 RtpRtcp::Configuration config;
591 config.clock = &fake_clock_;
592 config.outgoing_transport = &transport_;
Erik Språng54d5d2c2019-08-20 17:22:36 +0200593 config.local_media_ssrc = kSsrc;
Erik Språng4580ca22019-07-04 10:38:43 +0200594 config.transport_feedback_callback = &feedback_observer_;
595 config.event_log = &mock_rtc_event_log_;
596 config.send_packet_observer = &send_packet_observer_;
597 config.retransmission_rate_limiter = &retransmission_rate_limiter_;
Erik Språngb5330102019-10-28 10:09:43 +0100598 rtp_sender_context_ = std::make_unique<RtpSenderContext>(config);
Petter Strandmark26bc6692018-05-29 08:43:35 +0200599
Niels Möllere7b9e6b2019-02-06 18:23:44 +0100600 SendGenericPacket();
Petter Strandmark26bc6692018-05-29 08:43:35 +0200601
602 EXPECT_FALSE(transport_.last_options_.is_retransmit);
Stefan Holmerf5dca482016-01-27 12:58:51 +0100603}
604
Sebastian Jansson1bca65b2018-10-10 09:58:08 +0200605TEST_P(RtpSenderTestWithoutPacer,
606 SetsIncludedInFeedbackWhenTransportSequenceNumberExtensionIsRegistered) {
607 SetUpRtpSender(false, false);
Erik Språngb5330102019-10-28 10:09:43 +0100608 rtp_sender()->RegisterRtpHeaderExtension(kRtpExtensionTransportSequenceNumber,
609 kTransportSequenceNumberExtensionId);
Sebastian Jansson1bca65b2018-10-10 09:58:08 +0200610 EXPECT_CALL(send_packet_observer_, OnSendPacket).Times(1);
Niels Möllere7b9e6b2019-02-06 18:23:44 +0100611 SendGenericPacket();
Sebastian Jansson1bca65b2018-10-10 09:58:08 +0200612 EXPECT_TRUE(transport_.last_options_.included_in_feedback);
613}
614
615TEST_P(
616 RtpSenderTestWithoutPacer,
617 SetsIncludedInAllocationWhenTransportSequenceNumberExtensionIsRegistered) {
618 SetUpRtpSender(false, false);
Erik Språngb5330102019-10-28 10:09:43 +0100619 rtp_sender()->RegisterRtpHeaderExtension(kRtpExtensionTransportSequenceNumber,
620 kTransportSequenceNumberExtensionId);
Sebastian Jansson1bca65b2018-10-10 09:58:08 +0200621 EXPECT_CALL(send_packet_observer_, OnSendPacket).Times(1);
Niels Möllere7b9e6b2019-02-06 18:23:44 +0100622 SendGenericPacket();
Sebastian Jansson1bca65b2018-10-10 09:58:08 +0200623 EXPECT_TRUE(transport_.last_options_.included_in_allocation);
624}
625
626TEST_P(RtpSenderTestWithoutPacer,
627 SetsIncludedInAllocationWhenForcedAsPartOfAllocation) {
628 SetUpRtpSender(false, false);
Erik Språngb5330102019-10-28 10:09:43 +0100629 rtp_egress()->ForceIncludeSendPacketsInAllocation(true);
Niels Möllere7b9e6b2019-02-06 18:23:44 +0100630 SendGenericPacket();
Sebastian Jansson1bca65b2018-10-10 09:58:08 +0200631 EXPECT_FALSE(transport_.last_options_.included_in_feedback);
632 EXPECT_TRUE(transport_.last_options_.included_in_allocation);
633}
634
635TEST_P(RtpSenderTestWithoutPacer, DoesnSetIncludedInAllocationByDefault) {
636 SetUpRtpSender(false, false);
Niels Möllere7b9e6b2019-02-06 18:23:44 +0100637 SendGenericPacket();
Sebastian Jansson1bca65b2018-10-10 09:58:08 +0200638 EXPECT_FALSE(transport_.last_options_.included_in_feedback);
639 EXPECT_FALSE(transport_.last_options_.included_in_allocation);
stefana23fc622016-07-28 07:56:38 -0700640}
asapersson35151f32016-05-02 23:44:01 -0700641
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200642TEST_P(RtpSenderTestWithoutPacer, OnSendSideDelayUpdated) {
Erik Språng9c771c22019-06-17 16:31:53 +0200643 StrictMock<MockSendSideDelayObserver> send_side_delay_observer_;
Erik Språng4580ca22019-07-04 10:38:43 +0200644
645 RtpRtcp::Configuration config;
646 config.clock = &fake_clock_;
647 config.outgoing_transport = &transport_;
Erik Språng54d5d2c2019-08-20 17:22:36 +0200648 config.local_media_ssrc = kSsrc;
Erik Språng4580ca22019-07-04 10:38:43 +0200649 config.send_side_delay_observer = &send_side_delay_observer_;
650 config.event_log = &mock_rtc_event_log_;
Erik Språngb5330102019-10-28 10:09:43 +0100651 rtp_sender_context_ = std::make_unique<RtpSenderContext>(config);
Erik Språng4580ca22019-07-04 10:38:43 +0200652
Niels Möller5fe95102019-03-04 16:49:25 +0100653 PlayoutDelayOracle playout_delay_oracle;
Erik Språngdc34a252019-10-04 15:17:29 +0200654 FieldTrialBasedConfig field_trials;
655 RTPSenderVideo::Config video_config;
656 video_config.clock = &fake_clock_;
Erik Språngb5330102019-10-28 10:09:43 +0100657 video_config.rtp_sender = rtp_sender();
Erik Språngdc34a252019-10-04 15:17:29 +0200658 video_config.playout_delay_oracle = &playout_delay_oracle;
659 video_config.field_trials = &field_trials;
660 RTPSenderVideo rtp_sender_video(video_config);
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200661
662 const uint8_t kPayloadType = 127;
Erik Språng6cf554e2019-10-02 20:55:39 +0200663 const absl::optional<VideoCodecType> kCodecType =
664 VideoCodecType::kVideoCodecGeneric;
Niels Möller59ab1cf2019-02-06 22:48:11 +0100665
666 const uint32_t kCaptureTimeMsToRtpTimestamp = 90; // 90 kHz clock
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200667 RTPVideoHeader video_header;
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200668
Henrik Boström9fe18342019-05-16 18:38:20 +0200669 // Send packet with 10 ms send-side delay. The average, max and total should
670 // be 10 ms.
671 EXPECT_CALL(send_side_delay_observer_,
672 SendSideDelayUpdated(10, 10, 10, kSsrc))
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200673 .Times(1);
674 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
675 fake_clock_.AdvanceTimeMilliseconds(10);
Danil Chapovalov51bf2002019-10-11 10:53:27 +0200676 video_header.frame_type = VideoFrameType::kVideoFrameKey;
Niels Möller59ab1cf2019-02-06 22:48:11 +0100677 EXPECT_TRUE(rtp_sender_video.SendVideo(
Danil Chapovalov51bf2002019-10-11 10:53:27 +0200678 kPayloadType, kCodecType, capture_time_ms * kCaptureTimeMsToRtpTimestamp,
679 capture_time_ms, kPayloadData, nullptr, video_header,
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200680 kDefaultExpectedRetransmissionTimeMs));
681
Henrik Boström9fe18342019-05-16 18:38:20 +0200682 // Send another packet with 20 ms delay. The average, max and total should be
683 // 15, 20 and 30 ms respectively.
684 EXPECT_CALL(send_side_delay_observer_,
685 SendSideDelayUpdated(15, 20, 30, kSsrc))
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200686 .Times(1);
687 fake_clock_.AdvanceTimeMilliseconds(10);
Danil Chapovalov51bf2002019-10-11 10:53:27 +0200688 video_header.frame_type = VideoFrameType::kVideoFrameKey;
Niels Möller59ab1cf2019-02-06 22:48:11 +0100689 EXPECT_TRUE(rtp_sender_video.SendVideo(
Danil Chapovalov51bf2002019-10-11 10:53:27 +0200690 kPayloadType, kCodecType, capture_time_ms * kCaptureTimeMsToRtpTimestamp,
691 capture_time_ms, kPayloadData, nullptr, video_header,
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200692 kDefaultExpectedRetransmissionTimeMs));
693
694 // Send another packet at the same time, which replaces the last packet.
695 // Since this packet has 0 ms delay, the average is now 5 ms and max is 10 ms.
Henrik Boström9fe18342019-05-16 18:38:20 +0200696 // The total counter stays the same though.
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200697 // TODO(terelius): Is is not clear that this is the right behavior.
Henrik Boström9fe18342019-05-16 18:38:20 +0200698 EXPECT_CALL(send_side_delay_observer_, SendSideDelayUpdated(5, 10, 30, kSsrc))
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200699 .Times(1);
700 capture_time_ms = fake_clock_.TimeInMilliseconds();
Danil Chapovalov51bf2002019-10-11 10:53:27 +0200701 video_header.frame_type = VideoFrameType::kVideoFrameKey;
Niels Möller59ab1cf2019-02-06 22:48:11 +0100702 EXPECT_TRUE(rtp_sender_video.SendVideo(
Danil Chapovalov51bf2002019-10-11 10:53:27 +0200703 kPayloadType, kCodecType, capture_time_ms * kCaptureTimeMsToRtpTimestamp,
704 capture_time_ms, kPayloadData, nullptr, video_header,
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200705 kDefaultExpectedRetransmissionTimeMs));
706
707 // Send a packet 1 second later. The earlier packets should have timed
Henrik Boström9fe18342019-05-16 18:38:20 +0200708 // out, so both max and average should be the delay of this packet. The total
709 // keeps increasing.
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200710 fake_clock_.AdvanceTimeMilliseconds(1000);
711 capture_time_ms = fake_clock_.TimeInMilliseconds();
712 fake_clock_.AdvanceTimeMilliseconds(1);
Henrik Boström9fe18342019-05-16 18:38:20 +0200713 EXPECT_CALL(send_side_delay_observer_, SendSideDelayUpdated(1, 1, 31, kSsrc))
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200714 .Times(1);
Danil Chapovalov51bf2002019-10-11 10:53:27 +0200715 video_header.frame_type = VideoFrameType::kVideoFrameKey;
Niels Möller59ab1cf2019-02-06 22:48:11 +0100716 EXPECT_TRUE(rtp_sender_video.SendVideo(
Danil Chapovalov51bf2002019-10-11 10:53:27 +0200717 kPayloadType, kCodecType, capture_time_ms * kCaptureTimeMsToRtpTimestamp,
718 capture_time_ms, kPayloadData, nullptr, video_header,
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200719 kDefaultExpectedRetransmissionTimeMs));
720}
721
minyue3a407ee2017-04-03 01:10:33 -0700722TEST_P(RtpSenderTestWithoutPacer, OnSendPacketUpdated) {
Erik Språngb5330102019-10-28 10:09:43 +0100723 EXPECT_EQ(0, rtp_sender()->RegisterRtpHeaderExtension(
stefana23fc622016-07-28 07:56:38 -0700724 kRtpExtensionTransportSequenceNumber,
725 kTransportSequenceNumberExtensionId));
asapersson35151f32016-05-02 23:44:01 -0700726 EXPECT_CALL(send_packet_observer_,
727 OnSendPacket(kTransportSequenceNumber, _, _))
728 .Times(1);
729
Niels Möllere7b9e6b2019-02-06 18:23:44 +0100730 SendGenericPacket();
asapersson35151f32016-05-02 23:44:01 -0700731}
732
minyue3a407ee2017-04-03 01:10:33 -0700733TEST_P(RtpSenderTest, SendsPacketsWithTransportSequenceNumber) {
Erik Språng4580ca22019-07-04 10:38:43 +0200734 RtpRtcp::Configuration config;
735 config.clock = &fake_clock_;
736 config.outgoing_transport = &transport_;
737 config.paced_sender = &mock_paced_sender_;
Erik Språng54d5d2c2019-08-20 17:22:36 +0200738 config.local_media_ssrc = kSsrc;
Erik Språng4580ca22019-07-04 10:38:43 +0200739 config.transport_feedback_callback = &feedback_observer_;
740 config.event_log = &mock_rtc_event_log_;
741 config.send_packet_observer = &send_packet_observer_;
742 config.retransmission_rate_limiter = &retransmission_rate_limiter_;
Erik Språngb5330102019-10-28 10:09:43 +0100743 rtp_sender_context_ = std::make_unique<RtpSenderContext>(config);
Erik Språng4580ca22019-07-04 10:38:43 +0200744
Erik Språngb5330102019-10-28 10:09:43 +0100745 rtp_sender()->SetSequenceNumber(kSeqNum);
746 rtp_sender_context_->packet_history_.SetStorePacketsStatus(
747 RtpPacketHistory::StorageMode::kStoreAndCull, 10);
748 EXPECT_EQ(0, rtp_sender()->RegisterRtpHeaderExtension(
Stefan Holmera246cfb2016-08-23 17:51:42 +0200749 kRtpExtensionTransportSequenceNumber,
750 kTransportSequenceNumberExtensionId));
751
Stefan Holmera246cfb2016-08-23 17:51:42 +0200752 EXPECT_CALL(send_packet_observer_,
753 OnSendPacket(kTransportSequenceNumber, _, _))
754 .Times(1);
minyue3a407ee2017-04-03 01:10:33 -0700755 EXPECT_CALL(feedback_observer_,
Erik Språng30a276b2019-04-23 12:00:11 +0200756 OnAddPacket(AllOf(
Erik Språngb5330102019-10-28 10:09:43 +0100757 Field(&RtpPacketSendInfo::ssrc, rtp_sender()->SSRC()),
Erik Språng30a276b2019-04-23 12:00:11 +0200758 Field(&RtpPacketSendInfo::transport_sequence_number,
759 kTransportSequenceNumber),
760 Field(&RtpPacketSendInfo::rtp_sequence_number,
Erik Språngb5330102019-10-28 10:09:43 +0100761 rtp_sender()->SequenceNumber()),
Erik Språng30a276b2019-04-23 12:00:11 +0200762 Field(&RtpPacketSendInfo::pacing_info, PacedPacketInfo()))))
Stefan Holmera246cfb2016-08-23 17:51:42 +0200763 .Times(1);
764
Erik Språngf5815fa2019-08-21 14:27:31 +0200765 EXPECT_CALL(
766 mock_paced_sender_,
Erik Språngea55b082019-10-02 14:57:46 +0200767 EnqueuePackets(Contains(AllOf(
768 Pointee(Property(&RtpPacketToSend::Ssrc, kSsrc)),
769 Pointee(Property(&RtpPacketToSend::SequenceNumber, kSeqNum))))));
Erik Språngf5815fa2019-08-21 14:27:31 +0200770 auto packet = SendGenericPacket();
771 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
Erik Språngb5330102019-10-28 10:09:43 +0100772 // Transport sequence number is set by PacketRouter, before SendPacket().
Erik Språngf5815fa2019-08-21 14:27:31 +0200773 packet->SetExtension<TransportSequenceNumber>(kTransportSequenceNumber);
Erik Språngb5330102019-10-28 10:09:43 +0100774 rtp_egress()->SendPacket(packet.get(), PacedPacketInfo());
Stefan Holmera246cfb2016-08-23 17:51:42 +0200775
danilchap12ba1862016-10-26 02:41:55 -0700776 uint16_t transport_seq_no;
Erik Språngf5815fa2019-08-21 14:27:31 +0200777 EXPECT_TRUE(
778 transport_.last_sent_packet().GetExtension<TransportSequenceNumber>(
779 &transport_seq_no));
danilchap12ba1862016-10-26 02:41:55 -0700780 EXPECT_EQ(kTransportSequenceNumber, transport_seq_no);
Petter Strandmark26bc6692018-05-29 08:43:35 +0200781 EXPECT_EQ(transport_.last_options_.packet_id, transport_seq_no);
Stefan Holmera246cfb2016-08-23 17:51:42 +0200782}
783
Erik Språng7b52f102018-02-07 14:37:37 +0100784TEST_P(RtpSenderTest, WritesPacerExitToTimingExtension) {
Erik Språngb5330102019-10-28 10:09:43 +0100785 rtp_sender_context_->packet_history_.SetStorePacketsStatus(
786 RtpPacketHistory::StorageMode::kStoreAndCull, 10);
787 EXPECT_EQ(0, rtp_sender()->RegisterRtpHeaderExtension(
ilnik04f4d122017-06-19 07:18:55 -0700788 kRtpExtensionVideoTiming, kVideoTimingExtensionId));
789 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
Erik Språngb5330102019-10-28 10:09:43 +0100790 auto packet = rtp_sender()->AllocatePacket();
ilnik04f4d122017-06-19 07:18:55 -0700791 packet->SetPayloadType(kPayload);
792 packet->SetMarker(true);
793 packet->SetTimestamp(kTimestamp);
794 packet->set_capture_time_ms(capture_time_ms);
ilnik2edc6842017-07-06 03:06:50 -0700795 const VideoSendTiming kVideoTiming = {0u, 0u, 0u, 0u, 0u, 0u, true};
ilnik04f4d122017-06-19 07:18:55 -0700796 packet->SetExtension<VideoTimingExtension>(kVideoTiming);
Erik Språngb5330102019-10-28 10:09:43 +0100797 EXPECT_TRUE(rtp_sender()->AssignSequenceNumber(packet.get()));
ilnik04f4d122017-06-19 07:18:55 -0700798 size_t packet_size = packet->size();
ilnik04f4d122017-06-19 07:18:55 -0700799
800 const int kStoredTimeInMs = 100;
Erik Språngf5815fa2019-08-21 14:27:31 +0200801 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
Erik Språng70768f42019-08-27 18:16:26 +0200802 packet->set_allow_retransmission(true);
Erik Språngea55b082019-10-02 14:57:46 +0200803 EXPECT_CALL(mock_paced_sender_, EnqueuePackets(Contains(Pointee(Property(
804 &RtpPacketToSend::Ssrc, kSsrc)))));
Erik Språng70768f42019-08-27 18:16:26 +0200805 EXPECT_TRUE(
Erik Språngb5330102019-10-28 10:09:43 +0100806 rtp_sender()->SendToNetwork(std::make_unique<RtpPacketToSend>(*packet)));
Erik Språngf5815fa2019-08-21 14:27:31 +0200807 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
Erik Språngb5330102019-10-28 10:09:43 +0100808 rtp_egress()->SendPacket(packet.get(), PacedPacketInfo());
ilnik04f4d122017-06-19 07:18:55 -0700809 EXPECT_EQ(1, transport_.packets_sent());
810 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
811
danilchapce251812017-09-11 12:24:41 -0700812 VideoSendTiming video_timing;
813 EXPECT_TRUE(transport_.last_sent_packet().GetExtension<VideoTimingExtension>(
814 &video_timing));
815 EXPECT_EQ(kStoredTimeInMs, video_timing.pacer_exit_delta_ms);
Erik Språng7b52f102018-02-07 14:37:37 +0100816}
ilnik04f4d122017-06-19 07:18:55 -0700817
Danil Chapovalovaf52b682018-11-27 10:48:27 +0100818TEST_P(RtpSenderTest, WritesNetwork2ToTimingExtensionWithPacer) {
819 SetUpRtpSender(/*pacer=*/true, /*populate_network2=*/true);
Erik Språngb5330102019-10-28 10:09:43 +0100820 rtp_sender_context_->packet_history_.SetStorePacketsStatus(
821 RtpPacketHistory::StorageMode::kStoreAndCull, 10);
822 EXPECT_EQ(0, rtp_sender()->RegisterRtpHeaderExtension(
Erik Språng7b52f102018-02-07 14:37:37 +0100823 kRtpExtensionVideoTiming, kVideoTimingExtensionId));
824 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
Erik Språngb5330102019-10-28 10:09:43 +0100825 auto packet = rtp_sender()->AllocatePacket();
Erik Språng7b52f102018-02-07 14:37:37 +0100826 packet->SetPayloadType(kPayload);
827 packet->SetMarker(true);
828 packet->SetTimestamp(kTimestamp);
829 packet->set_capture_time_ms(capture_time_ms);
830 const uint16_t kPacerExitMs = 1234u;
831 const VideoSendTiming kVideoTiming = {0u, 0u, 0u, kPacerExitMs, 0u, 0u, true};
832 packet->SetExtension<VideoTimingExtension>(kVideoTiming);
Erik Språngb5330102019-10-28 10:09:43 +0100833 EXPECT_TRUE(rtp_sender()->AssignSequenceNumber(packet.get()));
Erik Språng7b52f102018-02-07 14:37:37 +0100834 size_t packet_size = packet->size();
835
836 const int kStoredTimeInMs = 100;
Erik Språngf6468d22019-07-05 16:53:43 +0200837
Erik Språngf6468d22019-07-05 16:53:43 +0200838 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
Erik Språng70768f42019-08-27 18:16:26 +0200839 packet->set_allow_retransmission(true);
Erik Språngea55b082019-10-02 14:57:46 +0200840 EXPECT_CALL(mock_paced_sender_, EnqueuePackets(Contains(Pointee(Property(
841 &RtpPacketToSend::Ssrc, kSsrc)))));
Erik Språngb5330102019-10-28 10:09:43 +0100842 EXPECT_TRUE(rtp_sender()->SendToNetwork(
843 std::make_unique<RtpPacketToSend>(*packet)));
Erik Språngf6468d22019-07-05 16:53:43 +0200844 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
Erik Språngb5330102019-10-28 10:09:43 +0100845 rtp_egress()->SendPacket(packet.get(), PacedPacketInfo());
Erik Språngf6468d22019-07-05 16:53:43 +0200846
Erik Språngb5330102019-10-28 10:09:43 +0100847 EXPECT_EQ(1, transport_.packets_sent());
848 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
ilnik04f4d122017-06-19 07:18:55 -0700849
Erik Språngb5330102019-10-28 10:09:43 +0100850 VideoSendTiming video_timing;
851 EXPECT_TRUE(
852 transport_.last_sent_packet().GetExtension<VideoTimingExtension>(
853 &video_timing));
854 EXPECT_EQ(kStoredTimeInMs, video_timing.network2_timestamp_delta_ms);
855 EXPECT_EQ(kPacerExitMs, video_timing.pacer_exit_delta_ms);
ilnik04f4d122017-06-19 07:18:55 -0700856}
857
Danil Chapovalovaf52b682018-11-27 10:48:27 +0100858TEST_P(RtpSenderTest, WritesNetwork2ToTimingExtensionWithoutPacer) {
859 SetUpRtpSender(/*pacer=*/false, /*populate_network2=*/true);
Erik Språngb5330102019-10-28 10:09:43 +0100860 EXPECT_EQ(0, rtp_sender()->RegisterRtpHeaderExtension(
Danil Chapovalovaf52b682018-11-27 10:48:27 +0100861 kRtpExtensionVideoTiming, kVideoTimingExtensionId));
Erik Språngb5330102019-10-28 10:09:43 +0100862 auto packet = rtp_sender()->AllocatePacket();
Danil Chapovalovaf52b682018-11-27 10:48:27 +0100863 packet->SetMarker(true);
864 packet->set_capture_time_ms(fake_clock_.TimeInMilliseconds());
865 const VideoSendTiming kVideoTiming = {0u, 0u, 0u, 0u, 0u, 0u, true};
866 packet->SetExtension<VideoTimingExtension>(kVideoTiming);
Erik Språng70768f42019-08-27 18:16:26 +0200867 packet->set_allow_retransmission(true);
Erik Språngb5330102019-10-28 10:09:43 +0100868 EXPECT_TRUE(rtp_sender()->AssignSequenceNumber(packet.get()));
Erik Språng1fbfecd2019-08-26 19:00:05 +0200869 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
Danil Chapovalovaf52b682018-11-27 10:48:27 +0100870
871 const int kPropagateTimeMs = 10;
872 fake_clock_.AdvanceTimeMilliseconds(kPropagateTimeMs);
873
Erik Språngb5330102019-10-28 10:09:43 +0100874 EXPECT_TRUE(rtp_sender()->SendToNetwork(std::move(packet)));
Danil Chapovalovaf52b682018-11-27 10:48:27 +0100875
876 EXPECT_EQ(1, transport_.packets_sent());
877 absl::optional<VideoSendTiming> video_timing =
878 transport_.last_sent_packet().GetExtension<VideoTimingExtension>();
879 ASSERT_TRUE(video_timing);
880 EXPECT_EQ(kPropagateTimeMs, video_timing->network2_timestamp_delta_ms);
881}
882
minyue3a407ee2017-04-03 01:10:33 -0700883TEST_P(RtpSenderTest, TrafficSmoothingWithExtensions) {
Elad Alon4a87e1c2017-10-03 16:11:34 +0200884 EXPECT_CALL(mock_rtc_event_log_,
885 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)));
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000886
Erik Språngb5330102019-10-28 10:09:43 +0100887 rtp_sender_context_->packet_history_.SetStorePacketsStatus(
888 RtpPacketHistory::StorageMode::kStoreAndCull, 10);
889 EXPECT_EQ(0, rtp_sender()->RegisterRtpHeaderExtension(
danilchap162abd32015-12-10 02:39:40 -0800890 kRtpExtensionTransmissionTimeOffset,
891 kTransmissionTimeOffsetExtensionId));
Erik Språngb5330102019-10-28 10:09:43 +0100892 EXPECT_EQ(0,
893 rtp_sender()->RegisterRtpHeaderExtension(
894 kRtpExtensionAbsoluteSendTime, kAbsoluteSendTimeExtensionId));
stefan@webrtc.org8ccb9f92013-06-19 14:13:42 +0000895 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
danilchapb6f1fb52016-10-19 06:11:39 -0700896 auto packet =
897 BuildRtpPacket(kPayload, kMarkerBit, kTimestamp, capture_time_ms);
898 size_t packet_size = packet->size();
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000899
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000900 const int kStoredTimeInMs = 100;
Erik Språngea55b082019-10-02 14:57:46 +0200901 EXPECT_CALL(
902 mock_paced_sender_,
903 EnqueuePackets(Contains(AllOf(
904 Pointee(Property(&RtpPacketToSend::Ssrc, kSsrc)),
905 Pointee(Property(&RtpPacketToSend::SequenceNumber, kSeqNum))))));
906 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
907 packet->set_allow_retransmission(true);
908 EXPECT_TRUE(
Erik Språngb5330102019-10-28 10:09:43 +0100909 rtp_sender()->SendToNetwork(std::make_unique<RtpPacketToSend>(*packet)));
Erik Språngea55b082019-10-02 14:57:46 +0200910 EXPECT_EQ(0, transport_.packets_sent());
911 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
Erik Språngb5330102019-10-28 10:09:43 +0100912 rtp_egress()->SendPacket(packet.get(), PacedPacketInfo());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000913
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000914 // Process send bucket. Packet should now be sent.
danilchap12ba1862016-10-26 02:41:55 -0700915 EXPECT_EQ(1, transport_.packets_sent());
916 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
917
stefan@webrtc.orga5cb98c2013-05-29 12:12:51 +0000918 webrtc::RTPHeader rtp_header;
danilchap12ba1862016-10-26 02:41:55 -0700919 transport_.last_sent_packet().GetHeader(&rtp_header);
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000920
921 // Verify transmission time offset.
922 EXPECT_EQ(kStoredTimeInMs * 90, rtp_header.extension.transmissionTimeOffset);
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000923 uint64_t expected_send_time =
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000924 ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds());
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000925 EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime);
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000926}
927
minyue3a407ee2017-04-03 01:10:33 -0700928TEST_P(RtpSenderTest, TrafficSmoothingRetransmits) {
Elad Alon4a87e1c2017-10-03 16:11:34 +0200929 EXPECT_CALL(mock_rtc_event_log_,
930 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)));
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000931
Erik Språngb5330102019-10-28 10:09:43 +0100932 rtp_sender_context_->packet_history_.SetStorePacketsStatus(
933 RtpPacketHistory::StorageMode::kStoreAndCull, 10);
934 EXPECT_EQ(0, rtp_sender()->RegisterRtpHeaderExtension(
danilchap162abd32015-12-10 02:39:40 -0800935 kRtpExtensionTransmissionTimeOffset,
936 kTransmissionTimeOffsetExtensionId));
Erik Språngb5330102019-10-28 10:09:43 +0100937 EXPECT_EQ(0,
938 rtp_sender()->RegisterRtpHeaderExtension(
939 kRtpExtensionAbsoluteSendTime, kAbsoluteSendTimeExtensionId));
stefan@webrtc.org8ccb9f92013-06-19 14:13:42 +0000940 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
danilchapb6f1fb52016-10-19 06:11:39 -0700941 auto packet =
942 BuildRtpPacket(kPayload, kMarkerBit, kTimestamp, capture_time_ms);
943 size_t packet_size = packet->size();
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000944
945 // Packet should be stored in a send bucket.
Erik Språngea55b082019-10-02 14:57:46 +0200946 EXPECT_CALL(
947 mock_paced_sender_,
948 EnqueuePackets(Contains(AllOf(
949 Pointee(Property(&RtpPacketToSend::Ssrc, kSsrc)),
950 Pointee(Property(&RtpPacketToSend::SequenceNumber, kSeqNum))))));
951 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
952 packet->set_allow_retransmission(true);
953 EXPECT_TRUE(
Erik Språngb5330102019-10-28 10:09:43 +0100954 rtp_sender()->SendToNetwork(std::make_unique<RtpPacketToSend>(*packet)));
Erik Språngea55b082019-10-02 14:57:46 +0200955 // Immediately process send bucket and send packet.
Erik Språngb5330102019-10-28 10:09:43 +0100956 rtp_egress()->SendPacket(packet.get(), PacedPacketInfo());
Erik Språngf6468d22019-07-05 16:53:43 +0200957
Erik Språng0f4f0552019-05-08 10:15:05 -0700958 EXPECT_EQ(1, transport_.packets_sent());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000959
Erik Språng0f4f0552019-05-08 10:15:05 -0700960 // Retransmit packet.
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000961 const int kStoredTimeInMs = 100;
962 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
963
Erik Språng0f4f0552019-05-08 10:15:05 -0700964 EXPECT_CALL(mock_rtc_event_log_,
965 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)));
Erik Språngf6468d22019-07-05 16:53:43 +0200966 packet->set_packet_type(RtpPacketToSend::Type::kRetransmission);
967 packet->set_retransmitted_sequence_number(kSeqNum);
968 EXPECT_CALL(
969 mock_paced_sender_,
Erik Språngea55b082019-10-02 14:57:46 +0200970 EnqueuePackets(Contains(AllOf(
Erik Språngf6468d22019-07-05 16:53:43 +0200971 Pointee(Property(&RtpPacketToSend::Ssrc, kSsrc)),
Erik Språngea55b082019-10-02 14:57:46 +0200972 Pointee(Property(&RtpPacketToSend::SequenceNumber, kSeqNum))))));
Erik Språngf6468d22019-07-05 16:53:43 +0200973 EXPECT_EQ(static_cast<int>(packet_size),
Erik Språngb5330102019-10-28 10:09:43 +0100974 rtp_sender()->ReSendPacket(kSeqNum));
Erik Språngf6468d22019-07-05 16:53:43 +0200975 EXPECT_EQ(1, transport_.packets_sent());
Erik Språngb5330102019-10-28 10:09:43 +0100976 rtp_egress()->SendPacket(packet.get(), PacedPacketInfo());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000977
Erik Språngb5330102019-10-28 10:09:43 +0100978 // Process send bucket. Packet should now be sent.
979 EXPECT_EQ(2, transport_.packets_sent());
980 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000981
Erik Språngb5330102019-10-28 10:09:43 +0100982 webrtc::RTPHeader rtp_header;
983 transport_.last_sent_packet().GetHeader(&rtp_header);
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000984
Erik Språngb5330102019-10-28 10:09:43 +0100985 // Verify transmission time offset.
986 EXPECT_EQ(kStoredTimeInMs * 90,
987 rtp_header.extension.transmissionTimeOffset);
988 uint64_t expected_send_time =
989 ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds());
990 EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000991}
992
993// This test sends 1 regular video packet, then 4 padding packets, and then
994// 1 more regular packet.
minyue3a407ee2017-04-03 01:10:33 -0700995TEST_P(RtpSenderTest, SendPadding) {
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000996 // Make all (non-padding) packets go to send queue.
Elad Alon4a87e1c2017-10-03 16:11:34 +0200997 EXPECT_CALL(mock_rtc_event_log_,
998 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
999 .Times(1 + 4 + 1);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +00001000
1001 uint16_t seq_num = kSeqNum;
1002 uint32_t timestamp = kTimestamp;
Erik Språngb5330102019-10-28 10:09:43 +01001003 rtp_sender_context_->packet_history_.SetStorePacketsStatus(
1004 RtpPacketHistory::StorageMode::kStoreAndCull, 10);
pkasting@chromium.org4591fbd2014-11-20 22:28:14 +00001005 size_t rtp_header_len = kRtpHeaderSize;
Erik Språngb5330102019-10-28 10:09:43 +01001006 EXPECT_EQ(0, rtp_sender()->RegisterRtpHeaderExtension(
danilchap162abd32015-12-10 02:39:40 -08001007 kRtpExtensionTransmissionTimeOffset,
1008 kTransmissionTimeOffsetExtensionId));
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +00001009 rtp_header_len += 4; // 4 bytes extension.
Erik Språngb5330102019-10-28 10:09:43 +01001010 EXPECT_EQ(0,
1011 rtp_sender()->RegisterRtpHeaderExtension(
1012 kRtpExtensionAbsoluteSendTime, kAbsoluteSendTimeExtensionId));
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +00001013 rtp_header_len += 4; // 4 bytes extension.
1014 rtp_header_len += 4; // 4 extra bytes common to all extension headers.
1015
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +00001016 webrtc::RTPHeader rtp_header;
1017
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +00001018 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
danilchapb6f1fb52016-10-19 06:11:39 -07001019 auto packet =
1020 BuildRtpPacket(kPayload, kMarkerBit, timestamp, capture_time_ms);
Stefan Holmer586b19b2015-09-18 11:14:31 +02001021 const uint32_t media_packet_timestamp = timestamp;
danilchapb6f1fb52016-10-19 06:11:39 -07001022 size_t packet_size = packet->size();
Erik Språngf6468d22019-07-05 16:53:43 +02001023 int total_packets_sent = 0;
1024 const int kStoredTimeInMs = 100;
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +00001025
1026 // Packet should be stored in a send bucket.
Erik Språngea55b082019-10-02 14:57:46 +02001027 EXPECT_CALL(
1028 mock_paced_sender_,
1029 EnqueuePackets(Contains(AllOf(
1030 Pointee(Property(&RtpPacketToSend::Ssrc, kSsrc)),
1031 Pointee(Property(&RtpPacketToSend::SequenceNumber, kSeqNum))))));
1032 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
1033 packet->set_allow_retransmission(true);
1034 EXPECT_TRUE(
Erik Språngb5330102019-10-28 10:09:43 +01001035 rtp_sender()->SendToNetwork(std::make_unique<RtpPacketToSend>(*packet)));
Erik Språngea55b082019-10-02 14:57:46 +02001036 EXPECT_EQ(total_packets_sent, transport_.packets_sent());
1037 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
Erik Språngb5330102019-10-28 10:09:43 +01001038 rtp_egress()->SendPacket(packet.get(), PacedPacketInfo());
Erik Språngea55b082019-10-02 14:57:46 +02001039 ++seq_num;
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +00001040
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +00001041 // Packet should now be sent. This test doesn't verify the regular video
1042 // packet, since it is tested in another test.
danilchap12ba1862016-10-26 02:41:55 -07001043 EXPECT_EQ(++total_packets_sent, transport_.packets_sent());
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +00001044 timestamp += 90 * kStoredTimeInMs;
1045
1046 // Send padding 4 times, waiting 50 ms between each.
1047 for (int i = 0; i < 4; ++i) {
1048 const int kPaddingPeriodMs = 50;
pkasting@chromium.org4591fbd2014-11-20 22:28:14 +00001049 const size_t kPaddingBytes = 100;
1050 const size_t kMaxPaddingLength = 224; // Value taken from rtp_sender.cc.
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +00001051 // Padding will be forced to full packets.
Erik Språng4208a132019-08-26 08:58:45 +02001052 EXPECT_EQ(kMaxPaddingLength, GenerateAndSendPadding(kPaddingBytes));
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +00001053
1054 // Process send bucket. Padding should now be sent.
danilchap12ba1862016-10-26 02:41:55 -07001055 EXPECT_EQ(++total_packets_sent, transport_.packets_sent());
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +00001056 EXPECT_EQ(kMaxPaddingLength + rtp_header_len,
danilchap12ba1862016-10-26 02:41:55 -07001057 transport_.last_sent_packet().size());
1058
1059 transport_.last_sent_packet().GetHeader(&rtp_header);
pbosbd2522a2015-07-01 05:35:53 -07001060 EXPECT_EQ(kMaxPaddingLength, rtp_header.paddingLength);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +00001061
Stefan Holmer586b19b2015-09-18 11:14:31 +02001062 // Verify sequence number and timestamp. The timestamp should be the same
1063 // as the last media packet.
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +00001064 EXPECT_EQ(seq_num++, rtp_header.sequenceNumber);
Stefan Holmer586b19b2015-09-18 11:14:31 +02001065 EXPECT_EQ(media_packet_timestamp, rtp_header.timestamp);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +00001066 // Verify transmission time offset.
Stefan Holmer586b19b2015-09-18 11:14:31 +02001067 int offset = timestamp - media_packet_timestamp;
1068 EXPECT_EQ(offset, rtp_header.extension.transmissionTimeOffset);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +00001069 uint64_t expected_send_time =
1070 ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds());
1071 EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime);
1072 fake_clock_.AdvanceTimeMilliseconds(kPaddingPeriodMs);
1073 timestamp += 90 * kPaddingPeriodMs;
1074 }
1075
1076 // Send a regular video packet again.
1077 capture_time_ms = fake_clock_.TimeInMilliseconds();
danilchapb6f1fb52016-10-19 06:11:39 -07001078 packet = BuildRtpPacket(kPayload, kMarkerBit, timestamp, capture_time_ms);
1079 packet_size = packet->size();
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +00001080
Erik Språngf6468d22019-07-05 16:53:43 +02001081 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
Erik Språng70768f42019-08-27 18:16:26 +02001082 packet->set_allow_retransmission(true);
Erik Språngf6468d22019-07-05 16:53:43 +02001083 EXPECT_CALL(
1084 mock_paced_sender_,
Erik Språngea55b082019-10-02 14:57:46 +02001085 EnqueuePackets(Contains(AllOf(
Erik Språngf6468d22019-07-05 16:53:43 +02001086 Pointee(Property(&RtpPacketToSend::Ssrc, kSsrc)),
Erik Språngea55b082019-10-02 14:57:46 +02001087 Pointee(Property(&RtpPacketToSend::SequenceNumber, seq_num))))));
Erik Språngb5330102019-10-28 10:09:43 +01001088 EXPECT_TRUE(rtp_sender()->SendToNetwork(
1089 std::make_unique<RtpPacketToSend>(*packet)));
1090 rtp_egress()->SendPacket(packet.get(), PacedPacketInfo());
terelius5d332ac2016-01-14 14:37:39 -08001091
Erik Språngb5330102019-10-28 10:09:43 +01001092 // Process send bucket.
1093 EXPECT_EQ(++total_packets_sent, transport_.packets_sent());
1094 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
1095 transport_.last_sent_packet().GetHeader(&rtp_header);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +00001096
Erik Språngb5330102019-10-28 10:09:43 +01001097 // Verify sequence number and timestamp.
1098 EXPECT_EQ(seq_num, rtp_header.sequenceNumber);
1099 EXPECT_EQ(timestamp, rtp_header.timestamp);
1100 // Verify transmission time offset. This packet is sent without delay.
1101 EXPECT_EQ(0, rtp_header.extension.transmissionTimeOffset);
1102 uint64_t expected_send_time =
1103 ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds());
1104 EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime);
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +00001105}
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001106
minyue3a407ee2017-04-03 01:10:33 -07001107TEST_P(RtpSenderTest, OnSendPacketUpdated) {
Erik Språngb5330102019-10-28 10:09:43 +01001108 EXPECT_EQ(0, rtp_sender()->RegisterRtpHeaderExtension(
stefana23fc622016-07-28 07:56:38 -07001109 kRtpExtensionTransportSequenceNumber,
1110 kTransportSequenceNumberExtensionId));
Erik Språngb5330102019-10-28 10:09:43 +01001111 rtp_sender_context_->packet_history_.SetStorePacketsStatus(
1112 RtpPacketHistory::StorageMode::kStoreAndCull, 10);
asapersson35151f32016-05-02 23:44:01 -07001113
1114 EXPECT_CALL(send_packet_observer_,
1115 OnSendPacket(kTransportSequenceNumber, _, _))
1116 .Times(1);
asapersson35151f32016-05-02 23:44:01 -07001117
Erik Språngea55b082019-10-02 14:57:46 +02001118 EXPECT_CALL(
1119 mock_paced_sender_,
1120 EnqueuePackets(Contains(AllOf(
1121 Pointee(Property(&RtpPacketToSend::Ssrc, kSsrc)),
1122 Pointee(Property(&RtpPacketToSend::SequenceNumber, kSeqNum))))));
1123 auto packet = SendGenericPacket();
1124 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
1125 packet->SetExtension<TransportSequenceNumber>(kTransportSequenceNumber);
Erik Språngb5330102019-10-28 10:09:43 +01001126 rtp_egress()->SendPacket(packet.get(), PacedPacketInfo());
Erik Språngf6468d22019-07-05 16:53:43 +02001127
danilchap12ba1862016-10-26 02:41:55 -07001128 EXPECT_EQ(1, transport_.packets_sent());
asapersson35151f32016-05-02 23:44:01 -07001129}
1130
minyue3a407ee2017-04-03 01:10:33 -07001131TEST_P(RtpSenderTest, OnSendPacketNotUpdatedForRetransmits) {
Erik Språngb5330102019-10-28 10:09:43 +01001132 EXPECT_EQ(0, rtp_sender()->RegisterRtpHeaderExtension(
stefana23fc622016-07-28 07:56:38 -07001133 kRtpExtensionTransportSequenceNumber,
1134 kTransportSequenceNumberExtensionId));
Erik Språngb5330102019-10-28 10:09:43 +01001135 rtp_sender_context_->packet_history_.SetStorePacketsStatus(
1136 RtpPacketHistory::StorageMode::kStoreAndCull, 10);
asapersson35151f32016-05-02 23:44:01 -07001137
1138 EXPECT_CALL(send_packet_observer_, OnSendPacket(_, _, _)).Times(0);
asapersson35151f32016-05-02 23:44:01 -07001139
Erik Språngea55b082019-10-02 14:57:46 +02001140 EXPECT_CALL(
1141 mock_paced_sender_,
1142 EnqueuePackets(Contains(AllOf(
1143 Pointee(Property(&RtpPacketToSend::Ssrc, kSsrc)),
1144 Pointee(Property(&RtpPacketToSend::SequenceNumber, kSeqNum))))));
1145 auto packet = SendGenericPacket();
1146 packet->set_packet_type(RtpPacketToSend::Type::kRetransmission);
1147 packet->SetExtension<TransportSequenceNumber>(kTransportSequenceNumber);
Erik Språngb5330102019-10-28 10:09:43 +01001148 rtp_egress()->SendPacket(packet.get(), PacedPacketInfo());
Erik Språngf6468d22019-07-05 16:53:43 +02001149
danilchap12ba1862016-10-26 02:41:55 -07001150 EXPECT_EQ(1, transport_.packets_sent());
Petter Strandmark26bc6692018-05-29 08:43:35 +02001151 EXPECT_TRUE(transport_.last_options_.is_retransmit);
asapersson35151f32016-05-02 23:44:01 -07001152}
1153
minyue3a407ee2017-04-03 01:10:33 -07001154TEST_P(RtpSenderTestWithoutPacer, SendGenericVideo) {
Erik Språng6cf554e2019-10-02 20:55:39 +02001155 const uint8_t kPayloadType = 127;
1156 const VideoCodecType kCodecType = VideoCodecType::kVideoCodecGeneric;
Niels Möller5fe95102019-03-04 16:49:25 +01001157 PlayoutDelayOracle playout_delay_oracle;
Erik Språngdc34a252019-10-04 15:17:29 +02001158 FieldTrialBasedConfig field_trials;
1159 RTPSenderVideo::Config video_config;
1160 video_config.clock = &fake_clock_;
Erik Språngb5330102019-10-28 10:09:43 +01001161 video_config.rtp_sender = rtp_sender();
Erik Språngdc34a252019-10-04 15:17:29 +02001162 video_config.playout_delay_oracle = &playout_delay_oracle;
1163 video_config.field_trials = &field_trials;
1164 RTPSenderVideo rtp_sender_video(video_config);
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001165 uint8_t payload[] = {47, 11, 32, 93, 89};
1166
1167 // Send keyframe
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001168 RTPVideoHeader video_header;
Danil Chapovalov51bf2002019-10-11 10:53:27 +02001169 video_header.frame_type = VideoFrameType::kVideoFrameKey;
1170 ASSERT_TRUE(rtp_sender_video.SendVideo(kPayloadType, kCodecType, 1234, 4321,
1171 payload, nullptr, video_header,
1172 kDefaultExpectedRetransmissionTimeMs));
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001173
danilchap96c15872016-11-21 01:35:29 -08001174 auto sent_payload = transport_.last_sent_packet().payload();
1175 uint8_t generic_header = sent_payload[0];
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001176 EXPECT_TRUE(generic_header & RtpFormatVideoGeneric::kKeyFrameBit);
1177 EXPECT_TRUE(generic_header & RtpFormatVideoGeneric::kFirstPacketBit);
danilchap96c15872016-11-21 01:35:29 -08001178 EXPECT_THAT(sent_payload.subview(1), ElementsAreArray(payload));
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001179
1180 // Send delta frame
1181 payload[0] = 13;
1182 payload[1] = 42;
1183 payload[4] = 13;
1184
Danil Chapovalov51bf2002019-10-11 10:53:27 +02001185 video_header.frame_type = VideoFrameType::kVideoFrameDelta;
1186 ASSERT_TRUE(rtp_sender_video.SendVideo(kPayloadType, kCodecType, 1234, 4321,
1187 payload, nullptr, video_header,
1188 kDefaultExpectedRetransmissionTimeMs));
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001189
danilchap96c15872016-11-21 01:35:29 -08001190 sent_payload = transport_.last_sent_packet().payload();
1191 generic_header = sent_payload[0];
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001192 EXPECT_FALSE(generic_header & RtpFormatVideoGeneric::kKeyFrameBit);
1193 EXPECT_TRUE(generic_header & RtpFormatVideoGeneric::kFirstPacketBit);
danilchap96c15872016-11-21 01:35:29 -08001194 EXPECT_THAT(sent_payload.subview(1), ElementsAreArray(payload));
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001195}
1196
Mirta Dvornicicfe68daa2019-05-23 13:21:12 +02001197TEST_P(RtpSenderTestWithoutPacer, SendRawVideo) {
Erik Språng6cf554e2019-10-02 20:55:39 +02001198 const uint8_t kPayloadType = 111;
Mirta Dvornicicfe68daa2019-05-23 13:21:12 +02001199 const uint8_t payload[] = {11, 22, 33, 44, 55};
1200
1201 PlayoutDelayOracle playout_delay_oracle;
Erik Språngdc34a252019-10-04 15:17:29 +02001202 FieldTrialBasedConfig field_trials;
1203 RTPSenderVideo::Config video_config;
1204 video_config.clock = &fake_clock_;
Erik Språngb5330102019-10-28 10:09:43 +01001205 video_config.rtp_sender = rtp_sender();
Erik Språngdc34a252019-10-04 15:17:29 +02001206 video_config.playout_delay_oracle = &playout_delay_oracle;
1207 video_config.field_trials = &field_trials;
1208 RTPSenderVideo rtp_sender_video(video_config);
Mirta Dvornicicfe68daa2019-05-23 13:21:12 +02001209
1210 // Send a frame.
1211 RTPVideoHeader video_header;
Danil Chapovalov51bf2002019-10-11 10:53:27 +02001212 video_header.frame_type = VideoFrameType::kVideoFrameKey;
1213 ASSERT_TRUE(rtp_sender_video.SendVideo(kPayloadType, absl::nullopt, 1234,
1214 4321, payload, nullptr, video_header,
1215 kDefaultExpectedRetransmissionTimeMs));
Mirta Dvornicicfe68daa2019-05-23 13:21:12 +02001216
1217 auto sent_payload = transport_.last_sent_packet().payload();
1218 EXPECT_THAT(sent_payload, ElementsAreArray(payload));
1219}
1220
minyue3a407ee2017-04-03 01:10:33 -07001221TEST_P(RtpSenderTest, SendFlexfecPackets) {
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001222 constexpr uint32_t kTimestamp = 1234;
brandtrdbdb3f12016-11-10 05:04:48 -08001223 constexpr int kMediaPayloadType = 127;
Erik Språng6cf554e2019-10-02 20:55:39 +02001224 constexpr VideoCodecType kCodecType = VideoCodecType::kVideoCodecGeneric;
brandtrdbdb3f12016-11-10 05:04:48 -08001225 constexpr int kFlexfecPayloadType = 118;
brandtrdbdb3f12016-11-10 05:04:48 -08001226 const std::vector<RtpExtension> kNoRtpExtensions;
erikvarga27883732017-05-17 05:08:38 -07001227 const std::vector<RtpExtensionSize> kNoRtpExtensionSizes;
Erik Språng4580ca22019-07-04 10:38:43 +02001228 FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexFecSsrc, kSsrc, kNoMid,
1229 kNoRtpExtensions, kNoRtpExtensionSizes,
brandtr48d21a22017-05-30 02:32:12 -07001230 nullptr /* rtp_state */, &fake_clock_);
brandtrdbdb3f12016-11-10 05:04:48 -08001231
1232 // Reset |rtp_sender_| to use FlexFEC.
Erik Språng4580ca22019-07-04 10:38:43 +02001233 RtpRtcp::Configuration config;
1234 config.clock = &fake_clock_;
1235 config.outgoing_transport = &transport_;
1236 config.paced_sender = &mock_paced_sender_;
Erik Språng54d5d2c2019-08-20 17:22:36 +02001237 config.local_media_ssrc = kSsrc;
Erik Språng4580ca22019-07-04 10:38:43 +02001238 config.flexfec_sender = &flexfec_sender_;
Erik Språng4580ca22019-07-04 10:38:43 +02001239 config.event_log = &mock_rtc_event_log_;
1240 config.send_packet_observer = &send_packet_observer_;
1241 config.retransmission_rate_limiter = &retransmission_rate_limiter_;
Erik Språngb5330102019-10-28 10:09:43 +01001242 rtp_sender_context_ = std::make_unique<RtpSenderContext>(config);
Erik Språng4580ca22019-07-04 10:38:43 +02001243
Erik Språngb5330102019-10-28 10:09:43 +01001244 rtp_sender()->SetSequenceNumber(kSeqNum);
1245 rtp_sender_context_->packet_history_.SetStorePacketsStatus(
1246 RtpPacketHistory::StorageMode::kStoreAndCull, 10);
brandtrdbdb3f12016-11-10 05:04:48 -08001247
Niels Möller5fe95102019-03-04 16:49:25 +01001248 PlayoutDelayOracle playout_delay_oracle;
Erik Språngdc34a252019-10-04 15:17:29 +02001249 FieldTrialBasedConfig field_trials;
1250 RTPSenderVideo::Config video_config;
1251 video_config.clock = &fake_clock_;
Erik Språngb5330102019-10-28 10:09:43 +01001252 video_config.rtp_sender = rtp_sender();
Erik Språngdc34a252019-10-04 15:17:29 +02001253 video_config.flexfec_sender = &flexfec_sender;
1254 video_config.playout_delay_oracle = &playout_delay_oracle;
1255 video_config.field_trials = &field_trials;
1256 RTPSenderVideo rtp_sender_video(video_config);
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001257
brandtrdbdb3f12016-11-10 05:04:48 -08001258 // Parameters selected to generate a single FEC packet per media packet.
1259 FecProtectionParams params;
1260 params.fec_rate = 15;
1261 params.max_fec_frames = 1;
1262 params.fec_mask_type = kFecMaskRandom;
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001263 rtp_sender_video.SetFecParameters(params, params);
brandtrdbdb3f12016-11-10 05:04:48 -08001264
brandtr9dfff292016-11-14 05:14:50 -08001265 uint16_t flexfec_seq_num;
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001266 RTPVideoHeader video_header;
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001267
Erik Språngf6468d22019-07-05 16:53:43 +02001268 std::unique_ptr<RtpPacketToSend> media_packet;
1269 std::unique_ptr<RtpPacketToSend> fec_packet;
1270
Erik Språngea55b082019-10-02 14:57:46 +02001271 EXPECT_CALL(mock_paced_sender_, EnqueuePackets)
Erik Språngfc78aac2019-10-24 12:55:30 +02001272 .WillOnce([&](std::vector<std::unique_ptr<RtpPacketToSend>> packets) {
1273 for (auto& packet : packets) {
1274 if (packet->packet_type() == RtpPacketToSend::Type::kVideo) {
1275 EXPECT_EQ(packet->Ssrc(), kSsrc);
1276 EXPECT_EQ(packet->SequenceNumber(), kSeqNum);
1277 media_packet = std::move(packet);
1278 } else {
1279 EXPECT_EQ(packet->packet_type(),
1280 RtpPacketToSend::Type::kForwardErrorCorrection);
1281 EXPECT_EQ(packet->Ssrc(), kFlexFecSsrc);
1282 fec_packet = std::move(packet);
1283 }
1284 }
1285 });
Erik Språngf6468d22019-07-05 16:53:43 +02001286
Danil Chapovalov51bf2002019-10-11 10:53:27 +02001287 video_header.frame_type = VideoFrameType::kVideoFrameKey;
Erik Språngf6468d22019-07-05 16:53:43 +02001288 EXPECT_TRUE(rtp_sender_video.SendVideo(
Danil Chapovalov51bf2002019-10-11 10:53:27 +02001289 kMediaPayloadType, kCodecType, kTimestamp,
1290 fake_clock_.TimeInMilliseconds(), kPayloadData, nullptr, video_header,
Erik Språng6cf554e2019-10-02 20:55:39 +02001291 kDefaultExpectedRetransmissionTimeMs));
Erik Språngf6468d22019-07-05 16:53:43 +02001292 ASSERT_TRUE(media_packet != nullptr);
1293 ASSERT_TRUE(fec_packet != nullptr);
1294
1295 flexfec_seq_num = fec_packet->SequenceNumber();
Erik Språngb5330102019-10-28 10:09:43 +01001296 rtp_egress()->SendPacket(media_packet.get(), PacedPacketInfo());
1297 rtp_egress()->SendPacket(fec_packet.get(), PacedPacketInfo());
Erik Språngf6468d22019-07-05 16:53:43 +02001298
Erik Språngb5330102019-10-28 10:09:43 +01001299 ASSERT_EQ(2, transport_.packets_sent());
1300 const RtpPacketReceived& sent_media_packet = transport_.sent_packets_[0];
1301 EXPECT_EQ(kMediaPayloadType, sent_media_packet.PayloadType());
1302 EXPECT_EQ(kSeqNum, sent_media_packet.SequenceNumber());
1303 EXPECT_EQ(kSsrc, sent_media_packet.Ssrc());
1304 const RtpPacketReceived& sent_flexfec_packet = transport_.sent_packets_[1];
1305 EXPECT_EQ(kFlexfecPayloadType, sent_flexfec_packet.PayloadType());
1306 EXPECT_EQ(flexfec_seq_num, sent_flexfec_packet.SequenceNumber());
1307 EXPECT_EQ(kFlexFecSsrc, sent_flexfec_packet.Ssrc());
brandtrdbdb3f12016-11-10 05:04:48 -08001308}
1309
Erik Språngf6468d22019-07-05 16:53:43 +02001310// TODO(ilnik): because of webrtc:7859. Once FEC moved below pacer, this test
1311// should be removed.
1312TEST_P(RtpSenderTest, NoFlexfecForTimingFrames) {
1313 constexpr uint32_t kTimestamp = 1234;
1314 const int64_t kCaptureTimeMs = fake_clock_.TimeInMilliseconds();
1315 constexpr int kMediaPayloadType = 127;
Erik Språng6cf554e2019-10-02 20:55:39 +02001316 constexpr VideoCodecType kCodecType = VideoCodecType::kVideoCodecGeneric;
Erik Språngf6468d22019-07-05 16:53:43 +02001317 constexpr int kFlexfecPayloadType = 118;
1318 const std::vector<RtpExtension> kNoRtpExtensions;
1319 const std::vector<RtpExtensionSize> kNoRtpExtensionSizes;
1320
1321 FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexFecSsrc, kSsrc, kNoMid,
1322 kNoRtpExtensions, kNoRtpExtensionSizes,
1323 nullptr /* rtp_state */, &fake_clock_);
1324
1325 // Reset |rtp_sender_| to use FlexFEC.
Erik Språng630443a2019-07-26 16:44:55 +02001326 RtpRtcp::Configuration config;
1327 config.clock = &fake_clock_;
1328 config.outgoing_transport = &transport_;
1329 config.paced_sender = &mock_paced_sender_;
1330 config.flexfec_sender = &flexfec_sender;
Erik Språng630443a2019-07-26 16:44:55 +02001331 config.event_log = &mock_rtc_event_log_;
1332 config.send_packet_observer = &send_packet_observer_;
1333 config.retransmission_rate_limiter = &retransmission_rate_limiter_;
Erik Språng54d5d2c2019-08-20 17:22:36 +02001334 config.local_media_ssrc = kSsrc;
Erik Språngb5330102019-10-28 10:09:43 +01001335 rtp_sender_context_ = std::make_unique<RtpSenderContext>(config);
1336 rtp_sender()->SetSequenceNumber(kSeqNum);
1337 rtp_sender_context_->packet_history_.SetStorePacketsStatus(
1338 RtpPacketHistory::StorageMode::kStoreAndCull, 10);
Erik Språngf6468d22019-07-05 16:53:43 +02001339
1340 PlayoutDelayOracle playout_delay_oracle;
Erik Språngdc34a252019-10-04 15:17:29 +02001341 FieldTrialBasedConfig field_trials;
1342 RTPSenderVideo::Config video_config;
1343 video_config.clock = &fake_clock_;
Erik Språngb5330102019-10-28 10:09:43 +01001344 video_config.rtp_sender = rtp_sender();
Erik Språngdc34a252019-10-04 15:17:29 +02001345 video_config.flexfec_sender = &flexfec_sender;
1346 video_config.playout_delay_oracle = &playout_delay_oracle;
1347 video_config.field_trials = &field_trials;
1348 RTPSenderVideo rtp_sender_video(video_config);
Erik Språngf6468d22019-07-05 16:53:43 +02001349
1350 // Need extension to be registered for timing frames to be sent.
Erik Språngb5330102019-10-28 10:09:43 +01001351 ASSERT_EQ(0, rtp_sender()->RegisterRtpHeaderExtension(
Erik Språngf6468d22019-07-05 16:53:43 +02001352 kRtpExtensionVideoTiming, kVideoTimingExtensionId));
1353
1354 // Parameters selected to generate a single FEC packet per media packet.
1355 FecProtectionParams params;
1356 params.fec_rate = 15;
1357 params.max_fec_frames = 1;
1358 params.fec_mask_type = kFecMaskRandom;
1359 rtp_sender_video.SetFecParameters(params, params);
1360
1361 RTPVideoHeader video_header;
1362 video_header.video_timing.flags = VideoSendTiming::kTriggeredByTimer;
1363
1364 EXPECT_CALL(mock_rtc_event_log_,
1365 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
1366 .Times(1);
Erik Språngf6468d22019-07-05 16:53:43 +02001367 std::unique_ptr<RtpPacketToSend> rtp_packet;
1368 EXPECT_CALL(
1369 mock_paced_sender_,
Erik Språngea55b082019-10-02 14:57:46 +02001370 EnqueuePackets(Contains(AllOf(
Erik Språngf6468d22019-07-05 16:53:43 +02001371 Pointee(Property(&RtpPacketToSend::Ssrc, kSsrc)),
Erik Språngea55b082019-10-02 14:57:46 +02001372 Pointee(Property(&RtpPacketToSend::SequenceNumber, kSeqNum))))))
1373 .WillOnce([&rtp_packet](
1374 std::vector<std::unique_ptr<RtpPacketToSend>> packets) {
1375 EXPECT_EQ(packets.size(), 1u);
1376 rtp_packet = std::move(packets[0]);
Erik Språngf6468d22019-07-05 16:53:43 +02001377 });
1378
Erik Språngea55b082019-10-02 14:57:46 +02001379 EXPECT_CALL(mock_paced_sender_,
1380 EnqueuePackets(Contains(
1381 Pointee(Property(&RtpPacketToSend::Ssrc, kFlexFecSsrc)))))
Erik Språngf6468d22019-07-05 16:53:43 +02001382 .Times(0); // Not called because packet should not be protected.
1383
Danil Chapovalov51bf2002019-10-11 10:53:27 +02001384 video_header.frame_type = VideoFrameType::kVideoFrameKey;
Erik Språngf6468d22019-07-05 16:53:43 +02001385 EXPECT_TRUE(rtp_sender_video.SendVideo(
Danil Chapovalov51bf2002019-10-11 10:53:27 +02001386 kMediaPayloadType, kCodecType, kTimestamp, kCaptureTimeMs, kPayloadData,
1387 nullptr, video_header, kDefaultExpectedRetransmissionTimeMs));
Erik Språngf6468d22019-07-05 16:53:43 +02001388
Erik Språngb5330102019-10-28 10:09:43 +01001389 rtp_egress()->SendPacket(rtp_packet.get(), PacedPacketInfo());
Erik Språngf6468d22019-07-05 16:53:43 +02001390
Erik Språngb5330102019-10-28 10:09:43 +01001391 ASSERT_EQ(1, transport_.packets_sent());
1392 const RtpPacketReceived& sent_media_packet1 = transport_.sent_packets_[0];
1393 EXPECT_EQ(kMediaPayloadType, sent_media_packet1.PayloadType());
1394 EXPECT_EQ(kSeqNum, sent_media_packet1.SequenceNumber());
1395 EXPECT_EQ(kSsrc, sent_media_packet1.Ssrc());
Erik Språngf6468d22019-07-05 16:53:43 +02001396
Erik Språngb5330102019-10-28 10:09:43 +01001397 // Now try to send not a timing frame.
1398 uint16_t flexfec_seq_num;
Erik Språngf6468d22019-07-05 16:53:43 +02001399
Erik Språngb5330102019-10-28 10:09:43 +01001400 EXPECT_CALL(mock_rtc_event_log_,
1401 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
1402 .Times(2);
1403 std::unique_ptr<RtpPacketToSend> media_packet2;
1404 std::unique_ptr<RtpPacketToSend> fec_packet;
Erik Språngf6468d22019-07-05 16:53:43 +02001405
Erik Språngb5330102019-10-28 10:09:43 +01001406 EXPECT_CALL(mock_paced_sender_, EnqueuePackets)
1407 .WillOnce([&](std::vector<std::unique_ptr<RtpPacketToSend>> packets) {
1408 for (auto& packet : packets) {
1409 if (packet->packet_type() == RtpPacketToSend::Type::kVideo) {
1410 EXPECT_EQ(packet->Ssrc(), kSsrc);
1411 EXPECT_EQ(packet->SequenceNumber(), kSeqNum + 1);
1412 media_packet2 = std::move(packet);
1413 } else {
1414 EXPECT_EQ(packet->packet_type(),
1415 RtpPacketToSend::Type::kForwardErrorCorrection);
1416 EXPECT_EQ(packet->Ssrc(), kFlexFecSsrc);
1417 fec_packet = std::move(packet);
1418 }
Erik Språngfc78aac2019-10-24 12:55:30 +02001419 }
Erik Språngb5330102019-10-28 10:09:43 +01001420 });
Erik Språngf6468d22019-07-05 16:53:43 +02001421
Erik Språngb5330102019-10-28 10:09:43 +01001422 video_header.video_timing.flags = VideoSendTiming::kInvalid;
1423 video_header.frame_type = VideoFrameType::kVideoFrameKey;
1424 EXPECT_TRUE(rtp_sender_video.SendVideo(
1425 kMediaPayloadType, kCodecType, kTimestamp + 1, kCaptureTimeMs + 1,
1426 kPayloadData, nullptr, video_header,
1427 kDefaultExpectedRetransmissionTimeMs));
Erik Språngf6468d22019-07-05 16:53:43 +02001428
Erik Språngb5330102019-10-28 10:09:43 +01001429 ASSERT_TRUE(media_packet2 != nullptr);
1430 ASSERT_TRUE(fec_packet != nullptr);
Erik Språngf6468d22019-07-05 16:53:43 +02001431
Erik Språngb5330102019-10-28 10:09:43 +01001432 flexfec_seq_num = fec_packet->SequenceNumber();
1433 rtp_egress()->SendPacket(media_packet2.get(), PacedPacketInfo());
1434 rtp_egress()->SendPacket(fec_packet.get(), PacedPacketInfo());
Erik Språngf6468d22019-07-05 16:53:43 +02001435
Erik Språngb5330102019-10-28 10:09:43 +01001436 ASSERT_EQ(3, transport_.packets_sent());
1437 const RtpPacketReceived& sent_media_packet2 = transport_.sent_packets_[1];
1438 EXPECT_EQ(kMediaPayloadType, sent_media_packet2.PayloadType());
1439 EXPECT_EQ(kSeqNum + 1, sent_media_packet2.SequenceNumber());
1440 EXPECT_EQ(kSsrc, sent_media_packet2.Ssrc());
1441 const RtpPacketReceived& flexfec_packet = transport_.sent_packets_[2];
1442 EXPECT_EQ(kFlexfecPayloadType, flexfec_packet.PayloadType());
1443 EXPECT_EQ(flexfec_seq_num, flexfec_packet.SequenceNumber());
1444 EXPECT_EQ(kFlexFecSsrc, flexfec_packet.Ssrc());
Erik Språngf6468d22019-07-05 16:53:43 +02001445}
1446
minyue3a407ee2017-04-03 01:10:33 -07001447TEST_P(RtpSenderTestWithoutPacer, SendFlexfecPackets) {
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001448 constexpr uint32_t kTimestamp = 1234;
brandtrdbdb3f12016-11-10 05:04:48 -08001449 constexpr int kMediaPayloadType = 127;
Erik Språng6cf554e2019-10-02 20:55:39 +02001450 constexpr VideoCodecType kCodecType = VideoCodecType::kVideoCodecGeneric;
brandtrdbdb3f12016-11-10 05:04:48 -08001451 constexpr int kFlexfecPayloadType = 118;
brandtrdbdb3f12016-11-10 05:04:48 -08001452 const std::vector<RtpExtension> kNoRtpExtensions;
erikvarga27883732017-05-17 05:08:38 -07001453 const std::vector<RtpExtensionSize> kNoRtpExtensionSizes;
Erik Språngf6468d22019-07-05 16:53:43 +02001454 FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexFecSsrc, kSsrc, kNoMid,
Erik Språng4580ca22019-07-04 10:38:43 +02001455 kNoRtpExtensions, kNoRtpExtensionSizes,
brandtr48d21a22017-05-30 02:32:12 -07001456 nullptr /* rtp_state */, &fake_clock_);
brandtrdbdb3f12016-11-10 05:04:48 -08001457
1458 // Reset |rtp_sender_| to use FlexFEC.
Erik Språng4580ca22019-07-04 10:38:43 +02001459 RtpRtcp::Configuration config;
1460 config.clock = &fake_clock_;
1461 config.outgoing_transport = &transport_;
Erik Språng54d5d2c2019-08-20 17:22:36 +02001462 config.local_media_ssrc = kSsrc;
Erik Språng4580ca22019-07-04 10:38:43 +02001463 config.flexfec_sender = &flexfec_sender;
Erik Språng4580ca22019-07-04 10:38:43 +02001464 config.event_log = &mock_rtc_event_log_;
1465 config.send_packet_observer = &send_packet_observer_;
1466 config.retransmission_rate_limiter = &retransmission_rate_limiter_;
Erik Språngb5330102019-10-28 10:09:43 +01001467 rtp_sender_context_ = std::make_unique<RtpSenderContext>(config);
Erik Språng4580ca22019-07-04 10:38:43 +02001468
Erik Språngb5330102019-10-28 10:09:43 +01001469 rtp_sender()->SetSequenceNumber(kSeqNum);
brandtrdbdb3f12016-11-10 05:04:48 -08001470
Niels Möller5fe95102019-03-04 16:49:25 +01001471 PlayoutDelayOracle playout_delay_oracle;
Erik Språngdc34a252019-10-04 15:17:29 +02001472 FieldTrialBasedConfig field_trials;
1473 RTPSenderVideo::Config video_config;
1474 video_config.clock = &fake_clock_;
Erik Språngb5330102019-10-28 10:09:43 +01001475 video_config.rtp_sender = rtp_sender();
Erik Språngdc34a252019-10-04 15:17:29 +02001476 video_config.flexfec_sender = &flexfec_sender;
1477 video_config.playout_delay_oracle = &playout_delay_oracle;
1478 video_config.field_trials = &field_trials;
1479 RTPSenderVideo rtp_sender_video(video_config);
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001480
brandtrdbdb3f12016-11-10 05:04:48 -08001481 // Parameters selected to generate a single FEC packet per media packet.
1482 FecProtectionParams params;
1483 params.fec_rate = 15;
1484 params.max_fec_frames = 1;
1485 params.fec_mask_type = kFecMaskRandom;
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001486 rtp_sender_video.SetFecParameters(params, params);
brandtrdbdb3f12016-11-10 05:04:48 -08001487
Elad Alon4a87e1c2017-10-03 16:11:34 +02001488 EXPECT_CALL(mock_rtc_event_log_,
1489 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
1490 .Times(2);
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001491 RTPVideoHeader video_header;
Danil Chapovalov51bf2002019-10-11 10:53:27 +02001492 video_header.frame_type = VideoFrameType::kVideoFrameKey;
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001493 EXPECT_TRUE(rtp_sender_video.SendVideo(
Danil Chapovalov51bf2002019-10-11 10:53:27 +02001494 kMediaPayloadType, kCodecType, kTimestamp,
1495 fake_clock_.TimeInMilliseconds(), kPayloadData, nullptr, video_header,
1496 kDefaultExpectedRetransmissionTimeMs));
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001497
brandtrdbdb3f12016-11-10 05:04:48 -08001498 ASSERT_EQ(2, transport_.packets_sent());
1499 const RtpPacketReceived& media_packet = transport_.sent_packets_[0];
1500 EXPECT_EQ(kMediaPayloadType, media_packet.PayloadType());
Erik Språng4580ca22019-07-04 10:38:43 +02001501 EXPECT_EQ(kSsrc, media_packet.Ssrc());
brandtrdbdb3f12016-11-10 05:04:48 -08001502 const RtpPacketReceived& flexfec_packet = transport_.sent_packets_[1];
1503 EXPECT_EQ(kFlexfecPayloadType, flexfec_packet.PayloadType());
Erik Språngf6468d22019-07-05 16:53:43 +02001504 EXPECT_EQ(kFlexFecSsrc, flexfec_packet.Ssrc());
brandtrdbdb3f12016-11-10 05:04:48 -08001505}
1506
Steve Anton296a0ce2018-03-22 15:17:27 -07001507// Test that the MID header extension is included on sent packets when
1508// configured.
1509TEST_P(RtpSenderTestWithoutPacer, MidIncludedOnSentPackets) {
1510 const char kMid[] = "mid";
1511
Steve Anton2bac7da2019-07-21 15:04:21 -04001512 EnableMidSending(kMid);
Steve Anton296a0ce2018-03-22 15:17:27 -07001513
1514 // Send a couple packets.
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001515 SendGenericPacket();
1516 SendGenericPacket();
Steve Anton296a0ce2018-03-22 15:17:27 -07001517
1518 // Expect both packets to have the MID set.
1519 ASSERT_EQ(2u, transport_.sent_packets_.size());
1520 for (const RtpPacketReceived& packet : transport_.sent_packets_) {
1521 std::string mid;
1522 ASSERT_TRUE(packet.GetExtension<RtpMid>(&mid));
1523 EXPECT_EQ(kMid, mid);
1524 }
1525}
1526
Amit Hilbuch77938e62018-12-21 09:23:38 -08001527TEST_P(RtpSenderTestWithoutPacer, RidIncludedOnSentPackets) {
1528 const char kRid[] = "f";
1529
Steve Anton2bac7da2019-07-21 15:04:21 -04001530 EnableRidSending(kRid);
Amit Hilbuch77938e62018-12-21 09:23:38 -08001531
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001532 SendGenericPacket();
Amit Hilbuch77938e62018-12-21 09:23:38 -08001533
1534 ASSERT_EQ(1u, transport_.sent_packets_.size());
1535 const RtpPacketReceived& packet = transport_.sent_packets_[0];
1536 std::string rid;
1537 ASSERT_TRUE(packet.GetExtension<RtpStreamId>(&rid));
1538 EXPECT_EQ(kRid, rid);
1539}
1540
1541TEST_P(RtpSenderTestWithoutPacer, RidIncludedOnRtxSentPackets) {
1542 const char kRid[] = "f";
Amit Hilbuch77938e62018-12-21 09:23:38 -08001543
Steve Anton2bac7da2019-07-21 15:04:21 -04001544 EnableRtx();
1545 EnableRidSending(kRid);
Amit Hilbuch77938e62018-12-21 09:23:38 -08001546
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001547 SendGenericPacket();
Amit Hilbuch77938e62018-12-21 09:23:38 -08001548 ASSERT_EQ(1u, transport_.sent_packets_.size());
1549 const RtpPacketReceived& packet = transport_.sent_packets_[0];
1550 std::string rid;
1551 ASSERT_TRUE(packet.GetExtension<RtpStreamId>(&rid));
1552 EXPECT_EQ(kRid, rid);
1553 rid = kNoRid;
Steve Anton2bac7da2019-07-21 15:04:21 -04001554 EXPECT_FALSE(packet.HasExtension<RepairedRtpStreamId>());
Amit Hilbuch77938e62018-12-21 09:23:38 -08001555
1556 uint16_t packet_id = packet.SequenceNumber();
Erik Språngb5330102019-10-28 10:09:43 +01001557 rtp_sender()->ReSendPacket(packet_id);
Amit Hilbuch77938e62018-12-21 09:23:38 -08001558 ASSERT_EQ(2u, transport_.sent_packets_.size());
1559 const RtpPacketReceived& rtx_packet = transport_.sent_packets_[1];
1560 ASSERT_TRUE(rtx_packet.GetExtension<RepairedRtpStreamId>(&rid));
1561 EXPECT_EQ(kRid, rid);
1562 EXPECT_FALSE(rtx_packet.HasExtension<RtpStreamId>());
1563}
1564
Steve Anton2bac7da2019-07-21 15:04:21 -04001565TEST_P(RtpSenderTestWithoutPacer, MidAndRidNotIncludedOnSentPacketsAfterAck) {
1566 const char kMid[] = "mid";
1567 const char kRid[] = "f";
1568
1569 EnableMidSending(kMid);
1570 EnableRidSending(kRid);
1571
1572 // This first packet should include both MID and RID.
1573 auto first_built_packet = SendGenericPacket();
1574
Erik Språngb5330102019-10-28 10:09:43 +01001575 rtp_sender()->OnReceivedAckOnSsrc(first_built_packet->SequenceNumber());
Steve Anton2bac7da2019-07-21 15:04:21 -04001576
1577 // The second packet should include neither since an ack was received.
1578 SendGenericPacket();
1579
1580 ASSERT_EQ(2u, transport_.sent_packets_.size());
1581
1582 const RtpPacketReceived& first_packet = transport_.sent_packets_[0];
1583 std::string mid, rid;
1584 ASSERT_TRUE(first_packet.GetExtension<RtpMid>(&mid));
1585 EXPECT_EQ(kMid, mid);
1586 ASSERT_TRUE(first_packet.GetExtension<RtpStreamId>(&rid));
1587 EXPECT_EQ(kRid, rid);
1588
1589 const RtpPacketReceived& second_packet = transport_.sent_packets_[1];
1590 EXPECT_FALSE(second_packet.HasExtension<RtpMid>());
1591 EXPECT_FALSE(second_packet.HasExtension<RtpStreamId>());
1592}
1593
1594// Test that the first RTX packet includes both MID and RRID even if the packet
1595// being retransmitted did not have MID or RID. The MID and RID are needed on
1596// the first packets for a given SSRC, and RTX packets are sent on a separate
1597// SSRC.
1598TEST_P(RtpSenderTestWithoutPacer, MidAndRidIncludedOnFirstRtxPacket) {
1599 const char kMid[] = "mid";
1600 const char kRid[] = "f";
1601
1602 EnableRtx();
1603 EnableMidSending(kMid);
1604 EnableRidSending(kRid);
1605
1606 // This first packet will include both MID and RID.
1607 auto first_built_packet = SendGenericPacket();
Erik Språngb5330102019-10-28 10:09:43 +01001608 rtp_sender()->OnReceivedAckOnSsrc(first_built_packet->SequenceNumber());
Steve Anton2bac7da2019-07-21 15:04:21 -04001609
1610 // The second packet will include neither since an ack was received.
1611 auto second_built_packet = SendGenericPacket();
1612
1613 // The first RTX packet should include MID and RRID.
1614 ASSERT_LT(0,
Erik Språngb5330102019-10-28 10:09:43 +01001615 rtp_sender()->ReSendPacket(second_built_packet->SequenceNumber()));
Steve Anton2bac7da2019-07-21 15:04:21 -04001616
1617 ASSERT_EQ(3u, transport_.sent_packets_.size());
1618
1619 const RtpPacketReceived& rtx_packet = transport_.sent_packets_[2];
1620 std::string mid, rrid;
1621 ASSERT_TRUE(rtx_packet.GetExtension<RtpMid>(&mid));
1622 EXPECT_EQ(kMid, mid);
1623 ASSERT_TRUE(rtx_packet.GetExtension<RepairedRtpStreamId>(&rrid));
1624 EXPECT_EQ(kRid, rrid);
1625}
1626
1627// Test that the RTX packets sent after receving an ACK on the RTX SSRC does
1628// not include either MID or RRID even if the packet being retransmitted did
1629// had a MID or RID.
1630TEST_P(RtpSenderTestWithoutPacer, MidAndRidNotIncludedOnRtxPacketsAfterAck) {
1631 const char kMid[] = "mid";
1632 const char kRid[] = "f";
1633
1634 EnableRtx();
1635 EnableMidSending(kMid);
1636 EnableRidSending(kRid);
1637
1638 // This first packet will include both MID and RID.
1639 auto first_built_packet = SendGenericPacket();
Erik Språngb5330102019-10-28 10:09:43 +01001640 rtp_sender()->OnReceivedAckOnSsrc(first_built_packet->SequenceNumber());
Steve Anton2bac7da2019-07-21 15:04:21 -04001641
1642 // The second packet will include neither since an ack was received.
1643 auto second_built_packet = SendGenericPacket();
1644
1645 // The first RTX packet will include MID and RRID.
1646 ASSERT_LT(0,
Erik Språngb5330102019-10-28 10:09:43 +01001647 rtp_sender()->ReSendPacket(second_built_packet->SequenceNumber()));
Steve Anton2bac7da2019-07-21 15:04:21 -04001648
1649 ASSERT_EQ(3u, transport_.sent_packets_.size());
1650 const RtpPacketReceived& first_rtx_packet = transport_.sent_packets_[2];
1651
Erik Språngb5330102019-10-28 10:09:43 +01001652 rtp_sender()->OnReceivedAckOnRtxSsrc(first_rtx_packet.SequenceNumber());
Steve Anton2bac7da2019-07-21 15:04:21 -04001653
1654 // The second and third RTX packets should not include MID nor RRID.
Steve Anton2bac7da2019-07-21 15:04:21 -04001655 ASSERT_LT(0,
Erik Språngb5330102019-10-28 10:09:43 +01001656 rtp_sender()->ReSendPacket(first_built_packet->SequenceNumber()));
1657 ASSERT_LT(0,
1658 rtp_sender()->ReSendPacket(second_built_packet->SequenceNumber()));
Steve Anton2bac7da2019-07-21 15:04:21 -04001659
1660 ASSERT_EQ(5u, transport_.sent_packets_.size());
1661
1662 const RtpPacketReceived& second_rtx_packet = transport_.sent_packets_[3];
1663 EXPECT_FALSE(second_rtx_packet.HasExtension<RtpMid>());
1664 EXPECT_FALSE(second_rtx_packet.HasExtension<RepairedRtpStreamId>());
1665
1666 const RtpPacketReceived& third_rtx_packet = transport_.sent_packets_[4];
1667 EXPECT_FALSE(third_rtx_packet.HasExtension<RtpMid>());
1668 EXPECT_FALSE(third_rtx_packet.HasExtension<RepairedRtpStreamId>());
1669}
1670
1671// Test that if the RtpState indicates an ACK has been received on that SSRC
1672// then neither the MID nor RID header extensions will be sent.
1673TEST_P(RtpSenderTestWithoutPacer,
1674 MidAndRidNotIncludedOnSentPacketsAfterRtpStateRestored) {
1675 const char kMid[] = "mid";
1676 const char kRid[] = "f";
1677
1678 EnableMidSending(kMid);
1679 EnableRidSending(kRid);
1680
Erik Språngb5330102019-10-28 10:09:43 +01001681 RtpState state = rtp_sender()->GetRtpState();
Steve Anton2bac7da2019-07-21 15:04:21 -04001682 EXPECT_FALSE(state.ssrc_has_acked);
1683 state.ssrc_has_acked = true;
Erik Språngb5330102019-10-28 10:09:43 +01001684 rtp_sender()->SetRtpState(state);
Steve Anton2bac7da2019-07-21 15:04:21 -04001685
1686 SendGenericPacket();
1687
1688 ASSERT_EQ(1u, transport_.sent_packets_.size());
1689 const RtpPacketReceived& packet = transport_.sent_packets_[0];
1690 EXPECT_FALSE(packet.HasExtension<RtpMid>());
1691 EXPECT_FALSE(packet.HasExtension<RtpStreamId>());
1692}
1693
1694// Test that if the RTX RtpState indicates an ACK has been received on that
1695// RTX SSRC then neither the MID nor RRID header extensions will be sent on
1696// RTX packets.
1697TEST_P(RtpSenderTestWithoutPacer,
1698 MidAndRridNotIncludedOnRtxPacketsAfterRtpStateRestored) {
1699 const char kMid[] = "mid";
1700 const char kRid[] = "f";
1701
1702 EnableRtx();
1703 EnableMidSending(kMid);
1704 EnableRidSending(kRid);
1705
Erik Språngb5330102019-10-28 10:09:43 +01001706 RtpState rtx_state = rtp_sender()->GetRtxRtpState();
Steve Anton2bac7da2019-07-21 15:04:21 -04001707 EXPECT_FALSE(rtx_state.ssrc_has_acked);
1708 rtx_state.ssrc_has_acked = true;
Erik Språngb5330102019-10-28 10:09:43 +01001709 rtp_sender()->SetRtxRtpState(rtx_state);
Steve Anton2bac7da2019-07-21 15:04:21 -04001710
1711 auto built_packet = SendGenericPacket();
Erik Språngb5330102019-10-28 10:09:43 +01001712 ASSERT_LT(0, rtp_sender()->ReSendPacket(built_packet->SequenceNumber()));
Steve Anton2bac7da2019-07-21 15:04:21 -04001713
1714 ASSERT_EQ(2u, transport_.sent_packets_.size());
1715 const RtpPacketReceived& rtx_packet = transport_.sent_packets_[1];
1716 EXPECT_FALSE(rtx_packet.HasExtension<RtpMid>());
1717 EXPECT_FALSE(rtx_packet.HasExtension<RepairedRtpStreamId>());
1718}
1719
minyue3a407ee2017-04-03 01:10:33 -07001720TEST_P(RtpSenderTest, FecOverheadRate) {
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001721 constexpr uint32_t kTimestamp = 1234;
1722 constexpr int kMediaPayloadType = 127;
Erik Språng6cf554e2019-10-02 20:55:39 +02001723 constexpr VideoCodecType kCodecType = VideoCodecType::kVideoCodecGeneric;
brandtr81eab612017-01-24 04:06:09 -08001724 constexpr int kFlexfecPayloadType = 118;
brandtr81eab612017-01-24 04:06:09 -08001725 const std::vector<RtpExtension> kNoRtpExtensions;
erikvarga27883732017-05-17 05:08:38 -07001726 const std::vector<RtpExtensionSize> kNoRtpExtensionSizes;
Erik Språng4580ca22019-07-04 10:38:43 +02001727 FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexFecSsrc, kSsrc, kNoMid,
1728 kNoRtpExtensions, kNoRtpExtensionSizes,
brandtr48d21a22017-05-30 02:32:12 -07001729 nullptr /* rtp_state */, &fake_clock_);
brandtr81eab612017-01-24 04:06:09 -08001730
1731 // Reset |rtp_sender_| to use FlexFEC.
Erik Språng4580ca22019-07-04 10:38:43 +02001732 RtpRtcp::Configuration config;
1733 config.clock = &fake_clock_;
1734 config.outgoing_transport = &transport_;
1735 config.paced_sender = &mock_paced_sender_;
Erik Språng54d5d2c2019-08-20 17:22:36 +02001736 config.local_media_ssrc = kSsrc;
Erik Språng4580ca22019-07-04 10:38:43 +02001737 config.flexfec_sender = &flexfec_sender;
Erik Språng4580ca22019-07-04 10:38:43 +02001738 config.event_log = &mock_rtc_event_log_;
1739 config.send_packet_observer = &send_packet_observer_;
1740 config.retransmission_rate_limiter = &retransmission_rate_limiter_;
Erik Språngb5330102019-10-28 10:09:43 +01001741 rtp_sender_context_ = std::make_unique<RtpSenderContext>(config);
Erik Språng4580ca22019-07-04 10:38:43 +02001742
Erik Språngb5330102019-10-28 10:09:43 +01001743 rtp_sender()->SetSequenceNumber(kSeqNum);
brandtr81eab612017-01-24 04:06:09 -08001744
Niels Möller5fe95102019-03-04 16:49:25 +01001745 PlayoutDelayOracle playout_delay_oracle;
Erik Språngdc34a252019-10-04 15:17:29 +02001746 FieldTrialBasedConfig field_trials;
1747 RTPSenderVideo::Config video_config;
1748 video_config.clock = &fake_clock_;
Erik Språngb5330102019-10-28 10:09:43 +01001749 video_config.rtp_sender = rtp_sender();
Erik Språngdc34a252019-10-04 15:17:29 +02001750 video_config.flexfec_sender = &flexfec_sender;
1751 video_config.playout_delay_oracle = &playout_delay_oracle;
1752 video_config.field_trials = &field_trials;
1753 RTPSenderVideo rtp_sender_video(video_config);
brandtr81eab612017-01-24 04:06:09 -08001754 // Parameters selected to generate a single FEC packet per media packet.
1755 FecProtectionParams params;
1756 params.fec_rate = 15;
1757 params.max_fec_frames = 1;
1758 params.fec_mask_type = kFecMaskRandom;
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001759 rtp_sender_video.SetFecParameters(params, params);
brandtr81eab612017-01-24 04:06:09 -08001760
1761 constexpr size_t kNumMediaPackets = 10;
1762 constexpr size_t kNumFecPackets = kNumMediaPackets;
1763 constexpr int64_t kTimeBetweenPacketsMs = 10;
Erik Språngfc78aac2019-10-24 12:55:30 +02001764 EXPECT_CALL(mock_paced_sender_, EnqueuePackets).Times(kNumMediaPackets);
brandtr81eab612017-01-24 04:06:09 -08001765 for (size_t i = 0; i < kNumMediaPackets; ++i) {
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001766 RTPVideoHeader video_header;
1767
Danil Chapovalov51bf2002019-10-11 10:53:27 +02001768 video_header.frame_type = VideoFrameType::kVideoFrameKey;
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001769 EXPECT_TRUE(rtp_sender_video.SendVideo(
Danil Chapovalov51bf2002019-10-11 10:53:27 +02001770 kMediaPayloadType, kCodecType, kTimestamp,
1771 fake_clock_.TimeInMilliseconds(), kPayloadData, nullptr, video_header,
Erik Språng6cf554e2019-10-02 20:55:39 +02001772 kDefaultExpectedRetransmissionTimeMs));
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001773
brandtr81eab612017-01-24 04:06:09 -08001774 fake_clock_.AdvanceTimeMilliseconds(kTimeBetweenPacketsMs);
1775 }
1776 constexpr size_t kRtpHeaderLength = 12;
1777 constexpr size_t kFlexfecHeaderLength = 20;
1778 constexpr size_t kGenericCodecHeaderLength = 1;
1779 constexpr size_t kPayloadLength = sizeof(kPayloadData);
1780 constexpr size_t kPacketLength = kRtpHeaderLength + kFlexfecHeaderLength +
1781 kGenericCodecHeaderLength + kPayloadLength;
1782 EXPECT_NEAR(kNumFecPackets * kPacketLength * 8 /
1783 (kNumFecPackets * kTimeBetweenPacketsMs / 1000.0f),
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001784 rtp_sender_video.FecOverheadRate(), 500);
brandtr81eab612017-01-24 04:06:09 -08001785}
1786
minyue3a407ee2017-04-03 01:10:33 -07001787TEST_P(RtpSenderTest, BitrateCallbacks) {
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001788 class TestCallback : public BitrateStatisticsObserver {
1789 public:
sprangcd349d92016-07-13 09:11:28 -07001790 TestCallback()
1791 : BitrateStatisticsObserver(),
1792 num_calls_(0),
1793 ssrc_(0),
1794 total_bitrate_(0),
1795 retransmit_bitrate_(0) {}
Danil Chapovalovdd7e2842018-03-09 15:37:03 +00001796 ~TestCallback() override = default;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001797
sprangcd349d92016-07-13 09:11:28 -07001798 void Notify(uint32_t total_bitrate,
1799 uint32_t retransmit_bitrate,
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00001800 uint32_t ssrc) override {
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001801 ++num_calls_;
1802 ssrc_ = ssrc;
sprangcd349d92016-07-13 09:11:28 -07001803 total_bitrate_ = total_bitrate;
1804 retransmit_bitrate_ = retransmit_bitrate;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001805 }
1806
1807 uint32_t num_calls_;
1808 uint32_t ssrc_;
sprangcd349d92016-07-13 09:11:28 -07001809 uint32_t total_bitrate_;
1810 uint32_t retransmit_bitrate_;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001811 } callback;
Erik Språng4580ca22019-07-04 10:38:43 +02001812
1813 RtpRtcp::Configuration config;
1814 config.clock = &fake_clock_;
1815 config.outgoing_transport = &transport_;
Erik Språng54d5d2c2019-08-20 17:22:36 +02001816 config.local_media_ssrc = kSsrc;
Erik Språng4580ca22019-07-04 10:38:43 +02001817 config.send_bitrate_observer = &callback;
1818 config.retransmission_rate_limiter = &retransmission_rate_limiter_;
Erik Språngb5330102019-10-28 10:09:43 +01001819 rtp_sender_context_ = std::make_unique<RtpSenderContext>(config);
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001820
Niels Möller5fe95102019-03-04 16:49:25 +01001821 PlayoutDelayOracle playout_delay_oracle;
Erik Språngdc34a252019-10-04 15:17:29 +02001822 FieldTrialBasedConfig field_trials;
1823 RTPSenderVideo::Config video_config;
1824 video_config.clock = &fake_clock_;
Erik Språngb5330102019-10-28 10:09:43 +01001825 video_config.rtp_sender = rtp_sender();
Erik Språngdc34a252019-10-04 15:17:29 +02001826 video_config.playout_delay_oracle = &playout_delay_oracle;
1827 video_config.field_trials = &field_trials;
1828 RTPSenderVideo rtp_sender_video(video_config);
Erik Språng6cf554e2019-10-02 20:55:39 +02001829 const VideoCodecType kCodecType = VideoCodecType::kVideoCodecGeneric;
1830 const uint8_t kPayloadType = 127;
Niels Möller59ab1cf2019-02-06 22:48:11 +01001831
sprangcd349d92016-07-13 09:11:28 -07001832 // Simulate kNumPackets sent with kPacketInterval ms intervals, with the
1833 // number of packets selected so that we fill (but don't overflow) the one
1834 // second averaging window.
1835 const uint32_t kWindowSizeMs = 1000;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001836 const uint32_t kPacketInterval = 20;
sprangcd349d92016-07-13 09:11:28 -07001837 const uint32_t kNumPackets =
1838 (kWindowSizeMs - kPacketInterval) / kPacketInterval;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001839 // Overhead = 12 bytes RTP header + 1 byte generic header.
1840 const uint32_t kPacketOverhead = 13;
1841
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001842 uint8_t payload[] = {47, 11, 32, 93, 89};
Erik Språngb5330102019-10-28 10:09:43 +01001843 rtp_sender_context_->packet_history_.SetStorePacketsStatus(
1844 RtpPacketHistory::StorageMode::kStoreAndCull, 1);
1845 uint32_t ssrc = rtp_sender()->SSRC();
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001846
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001847 // Initial process call so we get a new time window.
Erik Språngb5330102019-10-28 10:09:43 +01001848 rtp_egress()->ProcessBitrateAndNotifyObservers();
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001849
1850 // Send a few frames.
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001851 RTPVideoHeader video_header;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001852 for (uint32_t i = 0; i < kNumPackets; ++i) {
Danil Chapovalov51bf2002019-10-11 10:53:27 +02001853 video_header.frame_type = VideoFrameType::kVideoFrameKey;
Niels Möller59ab1cf2019-02-06 22:48:11 +01001854 ASSERT_TRUE(rtp_sender_video.SendVideo(
Danil Chapovalov51bf2002019-10-11 10:53:27 +02001855 kPayloadType, kCodecType, 1234, 4321, payload, nullptr, video_header,
Niels Möller8f7ce222019-03-21 15:43:58 +01001856 kDefaultExpectedRetransmissionTimeMs));
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001857 fake_clock_.AdvanceTimeMilliseconds(kPacketInterval);
1858 }
1859
Erik Språngb5330102019-10-28 10:09:43 +01001860 rtp_egress()->ProcessBitrateAndNotifyObservers();
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001861
stefan@webrtc.org0bae1fa2014-11-05 14:05:29 +00001862 // We get one call for every stats updated, thus two calls since both the
1863 // stream stats and the retransmit stats are updated once.
1864 EXPECT_EQ(2u, callback.num_calls_);
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001865 EXPECT_EQ(ssrc, callback.ssrc_);
sprangcd349d92016-07-13 09:11:28 -07001866 const uint32_t kTotalPacketSize = kPacketOverhead + sizeof(payload);
1867 // Bitrate measured over delta between last and first timestamp, plus one.
1868 const uint32_t kExpectedWindowMs = kNumPackets * kPacketInterval + 1;
1869 const uint32_t kExpectedBitsAccumulated = kTotalPacketSize * kNumPackets * 8;
1870 const uint32_t kExpectedRateBps =
1871 (kExpectedBitsAccumulated * 1000 + (kExpectedWindowMs / 2)) /
1872 kExpectedWindowMs;
1873 EXPECT_EQ(kExpectedRateBps, callback.total_bitrate_);
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001874}
1875
minyue3a407ee2017-04-03 01:10:33 -07001876TEST_P(RtpSenderTestWithoutPacer, StreamDataCountersCallbacks) {
Erik Språng6cf554e2019-10-02 20:55:39 +02001877 const uint8_t kPayloadType = 127;
1878 const VideoCodecType kCodecType = VideoCodecType::kVideoCodecGeneric;
Niels Möller5fe95102019-03-04 16:49:25 +01001879 PlayoutDelayOracle playout_delay_oracle;
Erik Språngdc34a252019-10-04 15:17:29 +02001880 FieldTrialBasedConfig field_trials;
1881 RTPSenderVideo::Config video_config;
1882 video_config.clock = &fake_clock_;
Erik Språngb5330102019-10-28 10:09:43 +01001883 video_config.rtp_sender = rtp_sender();
Erik Språngdc34a252019-10-04 15:17:29 +02001884 video_config.playout_delay_oracle = &playout_delay_oracle;
1885 video_config.field_trials = &field_trials;
1886 RTPSenderVideo rtp_sender_video(video_config);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001887 uint8_t payload[] = {47, 11, 32, 93, 89};
Erik Språngb5330102019-10-28 10:09:43 +01001888 rtp_sender_context_->packet_history_.SetStorePacketsStatus(
1889 RtpPacketHistory::StorageMode::kStoreAndCull, 1);
1890 uint32_t ssrc = rtp_sender()->SSRC();
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001891
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001892 // Send a frame.
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001893 RTPVideoHeader video_header;
Danil Chapovalov51bf2002019-10-11 10:53:27 +02001894 video_header.frame_type = VideoFrameType::kVideoFrameKey;
1895 ASSERT_TRUE(rtp_sender_video.SendVideo(kPayloadType, kCodecType, 1234, 4321,
1896 payload, nullptr, video_header,
1897 kDefaultExpectedRetransmissionTimeMs));
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001898 StreamDataCounters expected;
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001899 expected.transmitted.payload_bytes = 6;
1900 expected.transmitted.header_bytes = 12;
1901 expected.transmitted.padding_bytes = 0;
1902 expected.transmitted.packets = 1;
1903 expected.retransmitted.payload_bytes = 0;
1904 expected.retransmitted.header_bytes = 0;
1905 expected.retransmitted.padding_bytes = 0;
1906 expected.retransmitted.packets = 0;
1907 expected.fec.packets = 0;
Erik Språng7ea9b802019-10-16 19:03:38 +02001908 rtp_stats_callback_.Matches(ssrc, expected);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001909
1910 // Retransmit a frame.
Erik Språngb5330102019-10-28 10:09:43 +01001911 uint16_t seqno = rtp_sender()->SequenceNumber() - 1;
1912 rtp_sender()->ReSendPacket(seqno);
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001913 expected.transmitted.payload_bytes = 12;
1914 expected.transmitted.header_bytes = 24;
1915 expected.transmitted.packets = 2;
1916 expected.retransmitted.payload_bytes = 6;
1917 expected.retransmitted.header_bytes = 12;
1918 expected.retransmitted.padding_bytes = 0;
1919 expected.retransmitted.packets = 1;
Erik Språng7ea9b802019-10-16 19:03:38 +02001920 rtp_stats_callback_.Matches(ssrc, expected);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001921
1922 // Send padding.
Erik Språng4208a132019-08-26 08:58:45 +02001923 GenerateAndSendPadding(kMaxPaddingSize);
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001924 expected.transmitted.payload_bytes = 12;
1925 expected.transmitted.header_bytes = 36;
1926 expected.transmitted.padding_bytes = kMaxPaddingSize;
1927 expected.transmitted.packets = 3;
Erik Språng7ea9b802019-10-16 19:03:38 +02001928 rtp_stats_callback_.Matches(ssrc, expected);
Erik Språngdc34a252019-10-04 15:17:29 +02001929}
1930
1931TEST_P(RtpSenderTestWithoutPacer, StreamDataCountersCallbacksUlpfec) {
Erik Språngdc34a252019-10-04 15:17:29 +02001932 const uint8_t kRedPayloadType = 96;
1933 const uint8_t kUlpfecPayloadType = 97;
1934 const uint8_t kPayloadType = 127;
1935 const VideoCodecType kCodecType = VideoCodecType::kVideoCodecGeneric;
1936 PlayoutDelayOracle playout_delay_oracle;
1937 FieldTrialBasedConfig field_trials;
1938 RTPSenderVideo::Config video_config;
1939 video_config.clock = &fake_clock_;
Erik Språngb5330102019-10-28 10:09:43 +01001940 video_config.rtp_sender = rtp_sender();
Erik Språngdc34a252019-10-04 15:17:29 +02001941 video_config.playout_delay_oracle = &playout_delay_oracle;
1942 video_config.field_trials = &field_trials;
1943 video_config.red_payload_type = kRedPayloadType;
1944 video_config.ulpfec_payload_type = kUlpfecPayloadType;
1945 RTPSenderVideo rtp_sender_video(video_config);
1946 uint8_t payload[] = {47, 11, 32, 93, 89};
Erik Språngb5330102019-10-28 10:09:43 +01001947 rtp_sender_context_->packet_history_.SetStorePacketsStatus(
1948 RtpPacketHistory::StorageMode::kStoreAndCull, 1);
1949 uint32_t ssrc = rtp_sender()->SSRC();
Erik Språngdc34a252019-10-04 15:17:29 +02001950
Erik Språngdc34a252019-10-04 15:17:29 +02001951 RTPVideoHeader video_header;
1952 StreamDataCounters expected;
1953
brandtrf1bb4762016-11-07 03:05:06 -08001954 // Send ULPFEC.
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001955 FecProtectionParams fec_params;
1956 fec_params.fec_mask_type = kFecMaskRandom;
1957 fec_params.fec_rate = 1;
1958 fec_params.max_fec_frames = 1;
Niels Möller59ab1cf2019-02-06 22:48:11 +01001959 rtp_sender_video.SetFecParameters(fec_params, fec_params);
Danil Chapovalov51bf2002019-10-11 10:53:27 +02001960 video_header.frame_type = VideoFrameType::kVideoFrameDelta;
1961 ASSERT_TRUE(rtp_sender_video.SendVideo(kPayloadType, kCodecType, 1234, 4321,
1962 payload, nullptr, video_header,
1963 kDefaultExpectedRetransmissionTimeMs));
Erik Språngdc34a252019-10-04 15:17:29 +02001964 expected.transmitted.payload_bytes = 28;
1965 expected.transmitted.header_bytes = 24;
1966 expected.transmitted.packets = 2;
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001967 expected.fec.packets = 1;
Erik Språng7ea9b802019-10-16 19:03:38 +02001968 rtp_stats_callback_.Matches(ssrc, expected);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001969}
1970
minyue3a407ee2017-04-03 01:10:33 -07001971TEST_P(RtpSenderTestWithoutPacer, BytesReportedCorrectly) {
Niels Möller59ab1cf2019-02-06 22:48:11 +01001972 // XXX const char* kPayloadName = "GENERIC";
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001973 const uint8_t kPayloadType = 127;
Erik Språngb5330102019-10-28 10:09:43 +01001974 rtp_sender()->SetRtxPayloadType(kPayloadType - 1, kPayloadType);
1975 rtp_sender()->SetRtxStatus(kRtxRetransmitted | kRtxRedundantPayloads);
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001976
Niels Möller59ab1cf2019-02-06 22:48:11 +01001977 SendGenericPacket();
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +00001978 // Will send 2 full-size padding packets.
Erik Språng4208a132019-08-26 08:58:45 +02001979 GenerateAndSendPadding(1);
1980 GenerateAndSendPadding(1);
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001981
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +00001982 StreamDataCounters rtp_stats;
1983 StreamDataCounters rtx_stats;
Erik Språngb5330102019-10-28 10:09:43 +01001984 rtp_egress()->GetDataCounters(&rtp_stats, &rtx_stats);
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001985
Niels Möller59ab1cf2019-02-06 22:48:11 +01001986 // Payload
asapersson@webrtc.orgd08d3892014-12-16 12:03:11 +00001987 EXPECT_GT(rtp_stats.first_packet_time_ms, -1);
Niels Möller59ab1cf2019-02-06 22:48:11 +01001988 EXPECT_EQ(rtp_stats.transmitted.payload_bytes, sizeof(kPayloadData));
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001989 EXPECT_EQ(rtp_stats.transmitted.header_bytes, 12u);
1990 EXPECT_EQ(rtp_stats.transmitted.padding_bytes, 0u);
1991 EXPECT_EQ(rtx_stats.transmitted.payload_bytes, 0u);
1992 EXPECT_EQ(rtx_stats.transmitted.header_bytes, 24u);
1993 EXPECT_EQ(rtx_stats.transmitted.padding_bytes, 2 * kMaxPaddingSize);
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +00001994
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001995 EXPECT_EQ(rtp_stats.transmitted.TotalBytes(),
danilchap162abd32015-12-10 02:39:40 -08001996 rtp_stats.transmitted.payload_bytes +
1997 rtp_stats.transmitted.header_bytes +
1998 rtp_stats.transmitted.padding_bytes);
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001999 EXPECT_EQ(rtx_stats.transmitted.TotalBytes(),
danilchap162abd32015-12-10 02:39:40 -08002000 rtx_stats.transmitted.payload_bytes +
2001 rtx_stats.transmitted.header_bytes +
2002 rtx_stats.transmitted.padding_bytes);
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00002003
danilchap162abd32015-12-10 02:39:40 -08002004 EXPECT_EQ(
2005 transport_.total_bytes_sent_,
2006 rtp_stats.transmitted.TotalBytes() + rtx_stats.transmitted.TotalBytes());
pbos@webrtc.org72491b92014-07-10 16:24:54 +00002007}
guoweis@webrtc.org45362892015-03-04 22:55:15 +00002008
minyue3a407ee2017-04-03 01:10:33 -07002009TEST_P(RtpSenderTestWithoutPacer, RespectsNackBitrateLimit) {
sprang38778b02015-09-29 09:48:22 -07002010 const int32_t kPacketSize = 1400;
2011 const int32_t kNumPackets = 30;
2012
sprangcd349d92016-07-13 09:11:28 -07002013 retransmission_rate_limiter_.SetMaxRate(kPacketSize * kNumPackets * 8);
2014
Erik Språngb5330102019-10-28 10:09:43 +01002015 rtp_sender_context_->packet_history_.SetStorePacketsStatus(
2016 RtpPacketHistory::StorageMode::kStoreAndCull, kNumPackets);
2017 const uint16_t kStartSequenceNumber = rtp_sender()->SequenceNumber();
Danil Chapovalov2800d742016-08-26 18:48:46 +02002018 std::vector<uint16_t> sequence_numbers;
sprang38778b02015-09-29 09:48:22 -07002019 for (int32_t i = 0; i < kNumPackets; ++i) {
2020 sequence_numbers.push_back(kStartSequenceNumber + i);
2021 fake_clock_.AdvanceTimeMilliseconds(1);
2022 SendPacket(fake_clock_.TimeInMilliseconds(), kPacketSize);
2023 }
danilchap12ba1862016-10-26 02:41:55 -07002024 EXPECT_EQ(kNumPackets, transport_.packets_sent());
sprang38778b02015-09-29 09:48:22 -07002025
2026 fake_clock_.AdvanceTimeMilliseconds(1000 - kNumPackets);
2027
2028 // Resending should work - brings the bandwidth up to the limit.
2029 // NACK bitrate is capped to the same bitrate as the encoder, since the max
2030 // protection overhead is 50% (see MediaOptimization::SetTargetRates).
Erik Språngb5330102019-10-28 10:09:43 +01002031 rtp_sender()->OnReceivedNack(sequence_numbers, 0);
danilchap12ba1862016-10-26 02:41:55 -07002032 EXPECT_EQ(kNumPackets * 2, transport_.packets_sent());
sprang38778b02015-09-29 09:48:22 -07002033
sprangcd349d92016-07-13 09:11:28 -07002034 // Must be at least 5ms in between retransmission attempts.
2035 fake_clock_.AdvanceTimeMilliseconds(5);
2036
sprang38778b02015-09-29 09:48:22 -07002037 // Resending should not work, bandwidth exceeded.
Erik Språngb5330102019-10-28 10:09:43 +01002038 rtp_sender()->OnReceivedNack(sequence_numbers, 0);
danilchap12ba1862016-10-26 02:41:55 -07002039 EXPECT_EQ(kNumPackets * 2, transport_.packets_sent());
sprang38778b02015-09-29 09:48:22 -07002040}
2041
minyue3a407ee2017-04-03 01:10:33 -07002042TEST_P(RtpSenderTest, OnOverheadChanged) {
michaelt4da30442016-11-17 01:38:43 -08002043 MockOverheadObserver mock_overhead_observer;
Erik Språng4580ca22019-07-04 10:38:43 +02002044 RtpRtcp::Configuration config;
2045 config.clock = &fake_clock_;
2046 config.outgoing_transport = &transport_;
Erik Språng54d5d2c2019-08-20 17:22:36 +02002047 config.local_media_ssrc = kSsrc;
Erik Språng4580ca22019-07-04 10:38:43 +02002048 config.retransmission_rate_limiter = &retransmission_rate_limiter_;
2049 config.overhead_observer = &mock_overhead_observer;
Erik Språngb5330102019-10-28 10:09:43 +01002050 rtp_sender_context_ = std::make_unique<RtpSenderContext>(config);
michaelt4da30442016-11-17 01:38:43 -08002051
michaelt4da30442016-11-17 01:38:43 -08002052 // RTP overhead is 12B.
nisse284542b2017-01-10 08:58:32 -08002053 EXPECT_CALL(mock_overhead_observer, OnOverheadChanged(12)).Times(1);
Niels Möllere7b9e6b2019-02-06 18:23:44 +01002054 SendGenericPacket();
michaelt4da30442016-11-17 01:38:43 -08002055
Erik Språngb5330102019-10-28 10:09:43 +01002056 rtp_sender()->RegisterRtpHeaderExtension(kRtpExtensionTransmissionTimeOffset,
2057 kTransmissionTimeOffsetExtensionId);
michaelt4da30442016-11-17 01:38:43 -08002058
2059 // TransmissionTimeOffset extension has a size of 8B.
nisse284542b2017-01-10 08:58:32 -08002060 // 12B + 8B = 20B
2061 EXPECT_CALL(mock_overhead_observer, OnOverheadChanged(20)).Times(1);
Niels Möllere7b9e6b2019-02-06 18:23:44 +01002062 SendGenericPacket();
michaelt4da30442016-11-17 01:38:43 -08002063}
2064
minyue3a407ee2017-04-03 01:10:33 -07002065TEST_P(RtpSenderTest, DoesNotUpdateOverheadOnEqualSize) {
michaelt4da30442016-11-17 01:38:43 -08002066 MockOverheadObserver mock_overhead_observer;
Erik Språng4580ca22019-07-04 10:38:43 +02002067 RtpRtcp::Configuration config;
2068 config.clock = &fake_clock_;
2069 config.outgoing_transport = &transport_;
Erik Språng54d5d2c2019-08-20 17:22:36 +02002070 config.local_media_ssrc = kSsrc;
Erik Språng4580ca22019-07-04 10:38:43 +02002071 config.retransmission_rate_limiter = &retransmission_rate_limiter_;
2072 config.overhead_observer = &mock_overhead_observer;
Erik Språngb5330102019-10-28 10:09:43 +01002073 rtp_sender_context_ = std::make_unique<RtpSenderContext>(config);
michaelt4da30442016-11-17 01:38:43 -08002074
2075 EXPECT_CALL(mock_overhead_observer, OnOverheadChanged(_)).Times(1);
Niels Möllere7b9e6b2019-02-06 18:23:44 +01002076 SendGenericPacket();
2077 SendGenericPacket();
michaelt4da30442016-11-17 01:38:43 -08002078}
2079
Erik Språngb5330102019-10-28 10:09:43 +01002080TEST_P(RtpSenderTest, SendPacketMatchesVideo) {
Erik Språng9c771c22019-06-17 16:31:53 +02002081 std::unique_ptr<RtpPacketToSend> packet =
2082 BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2083 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
2084
Erik Språng9c771c22019-06-17 16:31:53 +02002085 // Verify sent with correct SSRC.
2086 packet = BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2087 packet->SetSsrc(kSsrc);
2088 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
Erik Språngb5330102019-10-28 10:09:43 +01002089 rtp_egress()->SendPacket(packet.get(), PacedPacketInfo());
Erik Språng671b4032019-10-17 16:56:22 +02002090 EXPECT_EQ(transport_.packets_sent(), 1);
Erik Språng9c771c22019-06-17 16:31:53 +02002091}
2092
Erik Språngb5330102019-10-28 10:09:43 +01002093TEST_P(RtpSenderTest, SendPacketMatchesAudio) {
Erik Språng9c771c22019-06-17 16:31:53 +02002094 std::unique_ptr<RtpPacketToSend> packet =
2095 BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2096 packet->set_packet_type(RtpPacketToSend::Type::kAudio);
2097
Erik Språng9c771c22019-06-17 16:31:53 +02002098 // Verify sent with correct SSRC.
2099 packet = BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2100 packet->SetSsrc(kSsrc);
2101 packet->set_packet_type(RtpPacketToSend::Type::kAudio);
Erik Språngb5330102019-10-28 10:09:43 +01002102 rtp_egress()->SendPacket(packet.get(), PacedPacketInfo());
Erik Språng671b4032019-10-17 16:56:22 +02002103 EXPECT_EQ(transport_.packets_sent(), 1);
Erik Språng9c771c22019-06-17 16:31:53 +02002104}
2105
Erik Språngb5330102019-10-28 10:09:43 +01002106TEST_P(RtpSenderTest, SendPacketMatchesRetransmissions) {
Erik Språng9c771c22019-06-17 16:31:53 +02002107 std::unique_ptr<RtpPacketToSend> packet =
2108 BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2109 packet->set_packet_type(RtpPacketToSend::Type::kRetransmission);
2110
Erik Språng9c771c22019-06-17 16:31:53 +02002111 // Verify sent with correct SSRC (non-RTX).
2112 packet = BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2113 packet->SetSsrc(kSsrc);
2114 packet->set_packet_type(RtpPacketToSend::Type::kRetransmission);
Erik Språngb5330102019-10-28 10:09:43 +01002115 rtp_egress()->SendPacket(packet.get(), PacedPacketInfo());
Erik Språng671b4032019-10-17 16:56:22 +02002116 EXPECT_EQ(transport_.packets_sent(), 1);
Erik Språng9c771c22019-06-17 16:31:53 +02002117
2118 // RTX retransmission.
2119 packet = BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2120 packet->SetSsrc(kRtxSsrc);
2121 packet->set_packet_type(RtpPacketToSend::Type::kRetransmission);
Erik Språngb5330102019-10-28 10:09:43 +01002122 rtp_egress()->SendPacket(packet.get(), PacedPacketInfo());
Erik Språng671b4032019-10-17 16:56:22 +02002123 EXPECT_EQ(transport_.packets_sent(), 2);
Erik Språng9c771c22019-06-17 16:31:53 +02002124}
2125
Erik Språngb5330102019-10-28 10:09:43 +01002126TEST_P(RtpSenderTest, SendPacketMatchesPadding) {
Erik Språng9c771c22019-06-17 16:31:53 +02002127 std::unique_ptr<RtpPacketToSend> packet =
2128 BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2129 packet->set_packet_type(RtpPacketToSend::Type::kPadding);
2130
Erik Språng9c771c22019-06-17 16:31:53 +02002131 // Verify sent with correct SSRC (non-RTX).
2132 packet = BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2133 packet->SetSsrc(kSsrc);
2134 packet->set_packet_type(RtpPacketToSend::Type::kPadding);
Erik Språngb5330102019-10-28 10:09:43 +01002135 rtp_egress()->SendPacket(packet.get(), PacedPacketInfo());
Erik Språng671b4032019-10-17 16:56:22 +02002136 EXPECT_EQ(transport_.packets_sent(), 1);
Erik Språng9c771c22019-06-17 16:31:53 +02002137
2138 // RTX padding.
2139 packet = BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2140 packet->SetSsrc(kRtxSsrc);
2141 packet->set_packet_type(RtpPacketToSend::Type::kPadding);
Erik Språngb5330102019-10-28 10:09:43 +01002142 rtp_egress()->SendPacket(packet.get(), PacedPacketInfo());
Erik Språng671b4032019-10-17 16:56:22 +02002143 EXPECT_EQ(transport_.packets_sent(), 2);
Erik Språng9c771c22019-06-17 16:31:53 +02002144}
2145
Erik Språngb5330102019-10-28 10:09:43 +01002146TEST_P(RtpSenderTest, SendPacketMatchesFlexfec) {
Erik Språng9c771c22019-06-17 16:31:53 +02002147 std::unique_ptr<RtpPacketToSend> packet =
2148 BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2149 packet->set_packet_type(RtpPacketToSend::Type::kForwardErrorCorrection);
2150
Erik Språng9c771c22019-06-17 16:31:53 +02002151 // Verify sent with correct SSRC.
2152 packet = BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2153 packet->SetSsrc(kFlexFecSsrc);
2154 packet->set_packet_type(RtpPacketToSend::Type::kForwardErrorCorrection);
Erik Språngb5330102019-10-28 10:09:43 +01002155 rtp_egress()->SendPacket(packet.get(), PacedPacketInfo());
Erik Språng671b4032019-10-17 16:56:22 +02002156 EXPECT_EQ(transport_.packets_sent(), 1);
Erik Språng9c771c22019-06-17 16:31:53 +02002157}
2158
Erik Språngb5330102019-10-28 10:09:43 +01002159TEST_P(RtpSenderTest, SendPacketMatchesUlpfec) {
Erik Språng9c771c22019-06-17 16:31:53 +02002160 std::unique_ptr<RtpPacketToSend> packet =
2161 BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2162 packet->set_packet_type(RtpPacketToSend::Type::kForwardErrorCorrection);
2163
Erik Språng9c771c22019-06-17 16:31:53 +02002164 // Verify sent with correct SSRC.
2165 packet = BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2166 packet->SetSsrc(kSsrc);
2167 packet->set_packet_type(RtpPacketToSend::Type::kForwardErrorCorrection);
Erik Språngb5330102019-10-28 10:09:43 +01002168 rtp_egress()->SendPacket(packet.get(), PacedPacketInfo());
Erik Språng671b4032019-10-17 16:56:22 +02002169 EXPECT_EQ(transport_.packets_sent(), 1);
Erik Språng9c771c22019-06-17 16:31:53 +02002170}
2171
Erik Språngb5330102019-10-28 10:09:43 +01002172TEST_P(RtpSenderTest, SendPacketHandlesRetransmissionHistory) {
2173 rtp_sender_context_->packet_history_.SetStorePacketsStatus(
2174 RtpPacketHistory::StorageMode::kStoreAndCull, 10);
Erik Språng9c771c22019-06-17 16:31:53 +02002175
2176 // Build a media packet and send it.
2177 std::unique_ptr<RtpPacketToSend> packet =
2178 BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2179 const uint16_t media_sequence_number = packet->SequenceNumber();
2180 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
2181 packet->set_allow_retransmission(true);
Erik Språngb5330102019-10-28 10:09:43 +01002182 rtp_egress()->SendPacket(packet.get(), PacedPacketInfo());
Erik Språng9c771c22019-06-17 16:31:53 +02002183
2184 // Simulate retransmission request.
2185 fake_clock_.AdvanceTimeMilliseconds(30);
Erik Språngb5330102019-10-28 10:09:43 +01002186 EXPECT_GT(rtp_sender()->ReSendPacket(media_sequence_number), 0);
Erik Språng9c771c22019-06-17 16:31:53 +02002187
2188 // Packet already pending, retransmission not allowed.
2189 fake_clock_.AdvanceTimeMilliseconds(30);
Erik Språngb5330102019-10-28 10:09:43 +01002190 EXPECT_EQ(rtp_sender()->ReSendPacket(media_sequence_number), 0);
Erik Språng9c771c22019-06-17 16:31:53 +02002191
2192 // Packet exiting pacer, mark as not longer pending.
2193 packet = BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2194 EXPECT_NE(packet->SequenceNumber(), media_sequence_number);
2195 packet->set_packet_type(RtpPacketToSend::Type::kRetransmission);
2196 packet->SetSsrc(kRtxSsrc);
2197 packet->set_retransmitted_sequence_number(media_sequence_number);
2198 packet->set_allow_retransmission(false);
Erik Språngb5330102019-10-28 10:09:43 +01002199 rtp_egress()->SendPacket(packet.get(), PacedPacketInfo());
Erik Språng9c771c22019-06-17 16:31:53 +02002200
2201 // Retransmissions allowed again.
2202 fake_clock_.AdvanceTimeMilliseconds(30);
Erik Språngb5330102019-10-28 10:09:43 +01002203 EXPECT_GT(rtp_sender()->ReSendPacket(media_sequence_number), 0);
Erik Språng9c771c22019-06-17 16:31:53 +02002204
2205 // Retransmission of RTX packet should not be allowed.
Erik Språngb5330102019-10-28 10:09:43 +01002206 EXPECT_EQ(rtp_sender()->ReSendPacket(packet->SequenceNumber()), 0);
Erik Språng9c771c22019-06-17 16:31:53 +02002207}
2208
Erik Språngb5330102019-10-28 10:09:43 +01002209TEST_P(RtpSenderTest, SendPacketUpdatesExtensions) {
2210 ASSERT_EQ(rtp_sender()->RegisterRtpHeaderExtension(
Erik Språng9c771c22019-06-17 16:31:53 +02002211 kRtpExtensionTransmissionTimeOffset,
2212 kTransmissionTimeOffsetExtensionId),
2213 0);
Erik Språngb5330102019-10-28 10:09:43 +01002214 ASSERT_EQ(rtp_sender()->RegisterRtpHeaderExtension(
Erik Språng9c771c22019-06-17 16:31:53 +02002215 kRtpExtensionAbsoluteSendTime, kAbsoluteSendTimeExtensionId),
2216 0);
Erik Språngb5330102019-10-28 10:09:43 +01002217 ASSERT_EQ(rtp_sender()->RegisterRtpHeaderExtension(kRtpExtensionVideoTiming,
2218 kVideoTimingExtensionId),
Erik Språng9c771c22019-06-17 16:31:53 +02002219 0);
2220
2221 std::unique_ptr<RtpPacketToSend> packet =
2222 BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2223 packet->set_packetization_finish_time_ms(fake_clock_.TimeInMilliseconds());
2224
2225 const int32_t kDiffMs = 10;
2226 fake_clock_.AdvanceTimeMilliseconds(kDiffMs);
2227
2228 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
Erik Språngb5330102019-10-28 10:09:43 +01002229 rtp_egress()->SendPacket(packet.get(), PacedPacketInfo());
Erik Språng9c771c22019-06-17 16:31:53 +02002230
2231 const RtpPacketReceived& received_packet = transport_.last_sent_packet();
2232
2233 EXPECT_EQ(received_packet.GetExtension<TransmissionOffset>(), kDiffMs * 90);
2234
2235 EXPECT_EQ(received_packet.GetExtension<AbsoluteSendTime>(),
2236 AbsoluteSendTime::MsTo24Bits(fake_clock_.TimeInMilliseconds()));
2237
2238 VideoSendTiming timing;
2239 EXPECT_TRUE(received_packet.GetExtension<VideoTimingExtension>(&timing));
2240 EXPECT_EQ(timing.pacer_exit_delta_ms, kDiffMs);
2241}
2242
Erik Språngb5330102019-10-28 10:09:43 +01002243TEST_P(RtpSenderTest, SendPacketSetsPacketOptions) {
Erik Språng9c771c22019-06-17 16:31:53 +02002244 const uint16_t kPacketId = 42;
Erik Språngb5330102019-10-28 10:09:43 +01002245 ASSERT_EQ(rtp_sender()->RegisterRtpHeaderExtension(
Erik Språng9c771c22019-06-17 16:31:53 +02002246 kRtpExtensionTransportSequenceNumber,
2247 kTransportSequenceNumberExtensionId),
2248 0);
2249 std::unique_ptr<RtpPacketToSend> packet =
2250 BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2251 packet->SetExtension<TransportSequenceNumber>(kPacketId);
2252
2253 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
2254 EXPECT_CALL(send_packet_observer_, OnSendPacket);
Erik Språngb5330102019-10-28 10:09:43 +01002255 rtp_egress()->SendPacket(packet.get(), PacedPacketInfo());
Erik Språng9c771c22019-06-17 16:31:53 +02002256
2257 EXPECT_EQ(transport_.last_options_.packet_id, kPacketId);
2258 EXPECT_TRUE(transport_.last_options_.included_in_allocation);
2259 EXPECT_TRUE(transport_.last_options_.included_in_feedback);
2260 EXPECT_FALSE(transport_.last_options_.is_retransmit);
2261
2262 // Send another packet as retransmission, verify options are populated.
2263 packet = BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2264 packet->SetExtension<TransportSequenceNumber>(kPacketId + 1);
2265 packet->set_packet_type(RtpPacketToSend::Type::kRetransmission);
Erik Språngb5330102019-10-28 10:09:43 +01002266 rtp_egress()->SendPacket(packet.get(), PacedPacketInfo());
Erik Språng9c771c22019-06-17 16:31:53 +02002267 EXPECT_TRUE(transport_.last_options_.is_retransmit);
2268}
2269
Erik Språngb5330102019-10-28 10:09:43 +01002270TEST_P(RtpSenderTest, SendPacketUpdatesStats) {
Erik Språng9c771c22019-06-17 16:31:53 +02002271 const size_t kPayloadSize = 1000;
2272
2273 StrictMock<MockSendSideDelayObserver> send_side_delay_observer;
Erik Språng4580ca22019-07-04 10:38:43 +02002274
2275 RtpRtcp::Configuration config;
2276 config.clock = &fake_clock_;
2277 config.outgoing_transport = &transport_;
Erik Språng54d5d2c2019-08-20 17:22:36 +02002278 config.local_media_ssrc = kSsrc;
Erik Språng4580ca22019-07-04 10:38:43 +02002279 config.rtx_send_ssrc = kRtxSsrc;
2280 config.flexfec_sender = &flexfec_sender_;
2281 config.send_side_delay_observer = &send_side_delay_observer;
2282 config.event_log = &mock_rtc_event_log_;
2283 config.send_packet_observer = &send_packet_observer_;
Erik Språngb5330102019-10-28 10:09:43 +01002284 rtp_sender_context_ = std::make_unique<RtpSenderContext>(config);
2285 ASSERT_EQ(0, rtp_sender()->RegisterRtpHeaderExtension(
Erik Språng9c771c22019-06-17 16:31:53 +02002286 kRtpExtensionTransportSequenceNumber,
2287 kTransportSequenceNumberExtensionId));
2288
2289 const int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
2290
2291 std::unique_ptr<RtpPacketToSend> video_packet =
2292 BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2293 video_packet->set_packet_type(RtpPacketToSend::Type::kVideo);
2294 video_packet->SetPayloadSize(kPayloadSize);
2295 video_packet->SetExtension<TransportSequenceNumber>(1);
2296
2297 std::unique_ptr<RtpPacketToSend> rtx_packet =
2298 BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2299 rtx_packet->SetSsrc(kRtxSsrc);
2300 rtx_packet->set_packet_type(RtpPacketToSend::Type::kRetransmission);
2301 rtx_packet->SetPayloadSize(kPayloadSize);
2302 rtx_packet->SetExtension<TransportSequenceNumber>(2);
2303
2304 std::unique_ptr<RtpPacketToSend> fec_packet =
2305 BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2306 fec_packet->SetSsrc(kFlexFecSsrc);
2307 fec_packet->set_packet_type(RtpPacketToSend::Type::kForwardErrorCorrection);
2308 fec_packet->SetPayloadSize(kPayloadSize);
2309 fec_packet->SetExtension<TransportSequenceNumber>(3);
2310
2311 const int64_t kDiffMs = 25;
2312 fake_clock_.AdvanceTimeMilliseconds(kDiffMs);
2313
2314 EXPECT_CALL(send_side_delay_observer,
2315 SendSideDelayUpdated(kDiffMs, kDiffMs, kDiffMs, kSsrc));
2316 EXPECT_CALL(
2317 send_side_delay_observer,
2318 SendSideDelayUpdated(kDiffMs, kDiffMs, 2 * kDiffMs, kFlexFecSsrc));
2319
2320 EXPECT_CALL(send_packet_observer_, OnSendPacket(1, capture_time_ms, kSsrc));
Erik Språngb5330102019-10-28 10:09:43 +01002321
2322 rtp_egress()->SendPacket(video_packet.get(), PacedPacketInfo());
Erik Språng9c771c22019-06-17 16:31:53 +02002323
2324 // Send packet observer not called for padding/retransmissions.
2325 EXPECT_CALL(send_packet_observer_, OnSendPacket(2, _, _)).Times(0);
Erik Språngb5330102019-10-28 10:09:43 +01002326 rtp_egress()->SendPacket(rtx_packet.get(), PacedPacketInfo());
Erik Språng9c771c22019-06-17 16:31:53 +02002327
2328 EXPECT_CALL(send_packet_observer_,
2329 OnSendPacket(3, capture_time_ms, kFlexFecSsrc));
Erik Språngb5330102019-10-28 10:09:43 +01002330 rtp_egress()->SendPacket(fec_packet.get(), PacedPacketInfo());
Erik Språng9c771c22019-06-17 16:31:53 +02002331
2332 StreamDataCounters rtp_stats;
2333 StreamDataCounters rtx_stats;
Erik Språngb5330102019-10-28 10:09:43 +01002334 rtp_egress()->GetDataCounters(&rtp_stats, &rtx_stats);
Erik Språng9c771c22019-06-17 16:31:53 +02002335 EXPECT_EQ(rtp_stats.transmitted.packets, 2u);
2336 EXPECT_EQ(rtp_stats.fec.packets, 1u);
2337 EXPECT_EQ(rtx_stats.retransmitted.packets, 1u);
2338}
2339
Erik Språng478cb462019-06-26 15:49:27 +02002340TEST_P(RtpSenderTest, GeneratePaddingResendsOldPacketsWithRtx) {
Mirko Bonadeia7e3bce2019-07-12 17:35:56 +00002341 // Min requested size in order to use RTX payload.
2342 const size_t kMinPaddingSize = 50;
2343
Erik Språngb5330102019-10-28 10:09:43 +01002344 rtp_sender()->SetRtxStatus(kRtxRetransmitted | kRtxRedundantPayloads);
2345 rtp_sender()->SetRtxPayloadType(kRtxPayload, kPayload);
2346 rtp_sender_context_->packet_history_.SetStorePacketsStatus(
2347 RtpPacketHistory::StorageMode::kStoreAndCull, 1);
Erik Språng478cb462019-06-26 15:49:27 +02002348
Erik Språngb5330102019-10-28 10:09:43 +01002349 ASSERT_EQ(0, rtp_sender()->RegisterRtpHeaderExtension(
Erik Språng0f6191d2019-07-15 20:33:40 +02002350 kRtpExtensionTransmissionTimeOffset,
2351 kTransmissionTimeOffsetExtensionId));
Erik Språngb5330102019-10-28 10:09:43 +01002352 ASSERT_EQ(0,
2353 rtp_sender()->RegisterRtpHeaderExtension(
2354 kRtpExtensionAbsoluteSendTime, kAbsoluteSendTimeExtensionId));
2355 ASSERT_EQ(0, rtp_sender()->RegisterRtpHeaderExtension(
Erik Språng0f6191d2019-07-15 20:33:40 +02002356 kRtpExtensionTransportSequenceNumber,
2357 kTransportSequenceNumberExtensionId));
2358
Erik Språng478cb462019-06-26 15:49:27 +02002359 const size_t kPayloadPacketSize = 1234;
2360 std::unique_ptr<RtpPacketToSend> packet =
2361 BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2362 packet->set_allow_retransmission(true);
2363 packet->SetPayloadSize(kPayloadPacketSize);
2364 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
2365
2366 // Send a dummy video packet so it ends up in the packet history.
Erik Språng0f6191d2019-07-15 20:33:40 +02002367 EXPECT_CALL(send_packet_observer_, OnSendPacket).Times(1);
Erik Språngb5330102019-10-28 10:09:43 +01002368 rtp_egress()->SendPacket(packet.get(), PacedPacketInfo());
Erik Språng478cb462019-06-26 15:49:27 +02002369
2370 // Generated padding has large enough budget that the video packet should be
2371 // retransmitted as padding.
Erik Språngf6468d22019-07-05 16:53:43 +02002372 std::vector<std::unique_ptr<RtpPacketToSend>> generated_packets =
Erik Språngb5330102019-10-28 10:09:43 +01002373 rtp_sender()->GeneratePadding(kMinPaddingSize, true);
Erik Språngf6468d22019-07-05 16:53:43 +02002374 ASSERT_EQ(generated_packets.size(), 1u);
2375 auto& padding_packet = generated_packets.front();
2376 EXPECT_EQ(padding_packet->packet_type(), RtpPacketToSend::Type::kPadding);
2377 EXPECT_EQ(padding_packet->Ssrc(), kRtxSsrc);
2378 EXPECT_EQ(padding_packet->payload_size(),
2379 kPayloadPacketSize + kRtxHeaderSize);
Erik Språng0f6191d2019-07-15 20:33:40 +02002380 EXPECT_TRUE(padding_packet->IsExtensionReserved<TransportSequenceNumber>());
2381 EXPECT_TRUE(padding_packet->IsExtensionReserved<AbsoluteSendTime>());
2382 EXPECT_TRUE(padding_packet->IsExtensionReserved<TransmissionOffset>());
2383
2384 // Verify all header extensions are received.
Erik Språngb5330102019-10-28 10:09:43 +01002385 rtp_egress()->SendPacket(padding_packet.get(), PacedPacketInfo());
Erik Språng0f6191d2019-07-15 20:33:40 +02002386 webrtc::RTPHeader rtp_header;
2387 transport_.last_sent_packet().GetHeader(&rtp_header);
2388 EXPECT_TRUE(rtp_header.extension.hasAbsoluteSendTime);
2389 EXPECT_TRUE(rtp_header.extension.hasTransmissionTimeOffset);
2390 EXPECT_TRUE(rtp_header.extension.hasTransportSequenceNumber);
Erik Språng478cb462019-06-26 15:49:27 +02002391
2392 // Not enough budged for payload padding, use plain padding instead.
Mirko Bonadeia7e3bce2019-07-12 17:35:56 +00002393 const size_t kPaddingBytesRequested = kMinPaddingSize - 1;
Erik Språngf6468d22019-07-05 16:53:43 +02002394
2395 size_t padding_bytes_generated = 0;
Erik Språngb5330102019-10-28 10:09:43 +01002396 generated_packets =
2397 rtp_sender()->GeneratePadding(kPaddingBytesRequested, true);
Mirko Bonadeia7e3bce2019-07-12 17:35:56 +00002398 EXPECT_EQ(generated_packets.size(), 1u);
Erik Språngf6468d22019-07-05 16:53:43 +02002399 for (auto& packet : generated_packets) {
2400 EXPECT_EQ(packet->packet_type(), RtpPacketToSend::Type::kPadding);
2401 EXPECT_EQ(packet->Ssrc(), kRtxSsrc);
2402 EXPECT_EQ(packet->payload_size(), 0u);
2403 EXPECT_GT(packet->padding_size(), 0u);
2404 padding_bytes_generated += packet->padding_size();
Erik Språng0f6191d2019-07-15 20:33:40 +02002405
2406 EXPECT_TRUE(packet->IsExtensionReserved<TransportSequenceNumber>());
2407 EXPECT_TRUE(packet->IsExtensionReserved<AbsoluteSendTime>());
2408 EXPECT_TRUE(packet->IsExtensionReserved<TransmissionOffset>());
2409
2410 // Verify all header extensions are received.
Erik Språngb5330102019-10-28 10:09:43 +01002411 rtp_egress()->SendPacket(packet.get(), PacedPacketInfo());
Erik Språng0f6191d2019-07-15 20:33:40 +02002412 webrtc::RTPHeader rtp_header;
2413 transport_.last_sent_packet().GetHeader(&rtp_header);
2414 EXPECT_TRUE(rtp_header.extension.hasAbsoluteSendTime);
2415 EXPECT_TRUE(rtp_header.extension.hasTransmissionTimeOffset);
2416 EXPECT_TRUE(rtp_header.extension.hasTransportSequenceNumber);
Erik Språngf6468d22019-07-05 16:53:43 +02002417 }
2418
Mirko Bonadeia7e3bce2019-07-12 17:35:56 +00002419 EXPECT_EQ(padding_bytes_generated, kMaxPaddingSize);
Erik Språng478cb462019-06-26 15:49:27 +02002420}
2421
2422TEST_P(RtpSenderTest, GeneratePaddingCreatesPurePaddingWithoutRtx) {
Erik Språngb5330102019-10-28 10:09:43 +01002423 rtp_sender_context_->packet_history_.SetStorePacketsStatus(
2424 RtpPacketHistory::StorageMode::kStoreAndCull, 1);
2425 ASSERT_EQ(0, rtp_sender()->RegisterRtpHeaderExtension(
Erik Språng0f6191d2019-07-15 20:33:40 +02002426 kRtpExtensionTransmissionTimeOffset,
2427 kTransmissionTimeOffsetExtensionId));
Erik Språngb5330102019-10-28 10:09:43 +01002428 ASSERT_EQ(0,
2429 rtp_sender()->RegisterRtpHeaderExtension(
2430 kRtpExtensionAbsoluteSendTime, kAbsoluteSendTimeExtensionId));
2431 ASSERT_EQ(0, rtp_sender()->RegisterRtpHeaderExtension(
Erik Språng0f6191d2019-07-15 20:33:40 +02002432 kRtpExtensionTransportSequenceNumber,
2433 kTransportSequenceNumberExtensionId));
Erik Språng478cb462019-06-26 15:49:27 +02002434
2435 const size_t kPayloadPacketSize = 1234;
2436 // Send a dummy video packet so it ends up in the packet history. Since we
2437 // are not using RTX, it should never be used as padding.
2438 std::unique_ptr<RtpPacketToSend> packet =
2439 BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2440 packet->set_allow_retransmission(true);
2441 packet->SetPayloadSize(kPayloadPacketSize);
2442 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
Erik Språng0f6191d2019-07-15 20:33:40 +02002443 EXPECT_CALL(send_packet_observer_, OnSendPacket).Times(1);
Erik Språngb5330102019-10-28 10:09:43 +01002444 rtp_egress()->SendPacket(packet.get(), PacedPacketInfo());
Erik Språng478cb462019-06-26 15:49:27 +02002445
2446 // Payload padding not available without RTX, only generate plain padding on
2447 // the media SSRC.
2448 // Number of padding packets is the requested padding size divided by max
2449 // padding packet size, rounded up. Pure padding packets are always of the
2450 // maximum size.
2451 const size_t kPaddingBytesRequested = kPayloadPacketSize + kRtxHeaderSize;
2452 const size_t kExpectedNumPaddingPackets =
2453 (kPaddingBytesRequested + kMaxPaddingSize - 1) / kMaxPaddingSize;
Erik Språngf6468d22019-07-05 16:53:43 +02002454 size_t padding_bytes_generated = 0;
2455 std::vector<std::unique_ptr<RtpPacketToSend>> padding_packets =
Erik Språngb5330102019-10-28 10:09:43 +01002456 rtp_sender()->GeneratePadding(kPaddingBytesRequested, true);
Erik Språngf6468d22019-07-05 16:53:43 +02002457 EXPECT_EQ(padding_packets.size(), kExpectedNumPaddingPackets);
2458 for (auto& packet : padding_packets) {
2459 EXPECT_EQ(packet->packet_type(), RtpPacketToSend::Type::kPadding);
2460 EXPECT_EQ(packet->Ssrc(), kSsrc);
2461 EXPECT_EQ(packet->payload_size(), 0u);
2462 EXPECT_GT(packet->padding_size(), 0u);
2463 padding_bytes_generated += packet->padding_size();
Erik Språng0f6191d2019-07-15 20:33:40 +02002464 EXPECT_TRUE(packet->IsExtensionReserved<TransportSequenceNumber>());
2465 EXPECT_TRUE(packet->IsExtensionReserved<AbsoluteSendTime>());
2466 EXPECT_TRUE(packet->IsExtensionReserved<TransmissionOffset>());
2467
2468 // Verify all header extensions are received.
Erik Språngb5330102019-10-28 10:09:43 +01002469 rtp_egress()->SendPacket(packet.get(), PacedPacketInfo());
Erik Språng0f6191d2019-07-15 20:33:40 +02002470 webrtc::RTPHeader rtp_header;
2471 transport_.last_sent_packet().GetHeader(&rtp_header);
2472 EXPECT_TRUE(rtp_header.extension.hasAbsoluteSendTime);
2473 EXPECT_TRUE(rtp_header.extension.hasTransmissionTimeOffset);
2474 EXPECT_TRUE(rtp_header.extension.hasTransportSequenceNumber);
Erik Språngf6468d22019-07-05 16:53:43 +02002475 }
2476
2477 EXPECT_EQ(padding_bytes_generated,
2478 kExpectedNumPaddingPackets * kMaxPaddingSize);
Erik Språng478cb462019-06-26 15:49:27 +02002479}
2480
Mirko Bonadei999a72a2019-07-12 17:33:46 +00002481TEST_P(RtpSenderTest, SupportsPadding) {
2482 bool kSendingMediaStats[] = {true, false};
2483 bool kEnableRedundantPayloads[] = {true, false};
2484 RTPExtensionType kBweExtensionTypes[] = {
2485 kRtpExtensionTransportSequenceNumber,
2486 kRtpExtensionTransportSequenceNumber02, kRtpExtensionAbsoluteSendTime,
2487 kRtpExtensionTransmissionTimeOffset};
2488 const int kExtensionsId = 7;
2489
2490 for (bool sending_media : kSendingMediaStats) {
Erik Språngb5330102019-10-28 10:09:43 +01002491 rtp_sender()->SetSendingMediaStatus(sending_media);
Mirko Bonadei999a72a2019-07-12 17:33:46 +00002492 for (bool redundant_payloads : kEnableRedundantPayloads) {
2493 int rtx_mode = kRtxRetransmitted;
2494 if (redundant_payloads) {
2495 rtx_mode |= kRtxRedundantPayloads;
2496 }
Erik Språngb5330102019-10-28 10:09:43 +01002497 rtp_sender()->SetRtxStatus(rtx_mode);
Mirko Bonadei999a72a2019-07-12 17:33:46 +00002498
2499 for (auto extension_type : kBweExtensionTypes) {
Erik Språngb5330102019-10-28 10:09:43 +01002500 EXPECT_FALSE(rtp_sender()->SupportsPadding());
2501 rtp_sender()->RegisterRtpHeaderExtension(extension_type, kExtensionsId);
Mirko Bonadei999a72a2019-07-12 17:33:46 +00002502 if (!sending_media) {
Erik Språngb5330102019-10-28 10:09:43 +01002503 EXPECT_FALSE(rtp_sender()->SupportsPadding());
Mirko Bonadei999a72a2019-07-12 17:33:46 +00002504 } else {
Erik Språngb5330102019-10-28 10:09:43 +01002505 EXPECT_TRUE(rtp_sender()->SupportsPadding());
Mirko Bonadei999a72a2019-07-12 17:33:46 +00002506 if (redundant_payloads) {
Erik Språngb5330102019-10-28 10:09:43 +01002507 EXPECT_TRUE(rtp_sender()->SupportsRtxPayloadPadding());
Mirko Bonadei999a72a2019-07-12 17:33:46 +00002508 } else {
Erik Språngb5330102019-10-28 10:09:43 +01002509 EXPECT_FALSE(rtp_sender()->SupportsRtxPayloadPadding());
Mirko Bonadei999a72a2019-07-12 17:33:46 +00002510 }
2511 }
Erik Språngb5330102019-10-28 10:09:43 +01002512 rtp_sender()->DeregisterRtpHeaderExtension(extension_type);
2513 EXPECT_FALSE(rtp_sender()->SupportsPadding());
Mirko Bonadei999a72a2019-07-12 17:33:46 +00002514 }
2515 }
2516 }
2517}
2518
Erik Språnga57711c2019-07-24 10:47:20 +02002519TEST_P(RtpSenderTest, SetsCaptureTimeAndPopulatesTransmissionOffset) {
Erik Språngb5330102019-10-28 10:09:43 +01002520 rtp_sender()->RegisterRtpHeaderExtension(kRtpExtensionTransmissionTimeOffset,
2521 kTransmissionTimeOffsetExtensionId);
Erik Språnga57711c2019-07-24 10:47:20 +02002522
Erik Språngb5330102019-10-28 10:09:43 +01002523 rtp_sender()->SetSendingMediaStatus(true);
2524 rtp_sender()->SetRtxStatus(kRtxRetransmitted | kRtxRedundantPayloads);
2525 rtp_sender()->SetRtxPayloadType(kRtxPayload, kPayload);
2526 rtp_sender_context_->packet_history_.SetStorePacketsStatus(
2527 RtpPacketHistory::StorageMode::kStoreAndCull, 10);
Erik Språnga57711c2019-07-24 10:47:20 +02002528
2529 const int64_t kMissingCaptureTimeMs = 0;
2530 const uint32_t kTimestampTicksPerMs = 90;
2531 const int64_t kOffsetMs = 10;
2532
Erik Språnga57711c2019-07-24 10:47:20 +02002533 auto packet =
2534 BuildRtpPacket(kPayload, kMarkerBit, fake_clock_.TimeInMilliseconds(),
2535 kMissingCaptureTimeMs);
2536 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
2537 packet->ReserveExtension<TransmissionOffset>();
2538 packet->AllocatePayload(sizeof(kPayloadData));
2539
2540 std::unique_ptr<RtpPacketToSend> packet_to_pace;
Erik Språngea55b082019-10-02 14:57:46 +02002541 EXPECT_CALL(mock_paced_sender_, EnqueuePackets)
2542 .WillOnce([&](std::vector<std::unique_ptr<RtpPacketToSend>> packets) {
2543 EXPECT_EQ(packets.size(), 1u);
2544 EXPECT_GT(packets[0]->capture_time_ms(), 0);
2545 packet_to_pace = std::move(packets[0]);
Erik Språnga57711c2019-07-24 10:47:20 +02002546 });
2547
Erik Språng70768f42019-08-27 18:16:26 +02002548 packet->set_allow_retransmission(true);
Erik Språngb5330102019-10-28 10:09:43 +01002549 EXPECT_TRUE(rtp_sender()->SendToNetwork(std::move(packet)));
Erik Språnga57711c2019-07-24 10:47:20 +02002550
2551 fake_clock_.AdvanceTimeMilliseconds(kOffsetMs);
2552
Erik Språngb5330102019-10-28 10:09:43 +01002553 rtp_egress()->SendPacket(packet_to_pace.get(), PacedPacketInfo());
Erik Språnga57711c2019-07-24 10:47:20 +02002554
Erik Språngb5330102019-10-28 10:09:43 +01002555 EXPECT_EQ(1, transport_.packets_sent());
2556 absl::optional<int32_t> transmission_time_extension =
2557 transport_.sent_packets_.back().GetExtension<TransmissionOffset>();
2558 ASSERT_TRUE(transmission_time_extension.has_value());
2559 EXPECT_EQ(*transmission_time_extension, kOffsetMs * kTimestampTicksPerMs);
Erik Språnga57711c2019-07-24 10:47:20 +02002560
Erik Språngb5330102019-10-28 10:09:43 +01002561 // Retransmit packet. The RTX packet should get the same capture time as the
2562 // original packet, so offset is delta from original packet to now.
2563 fake_clock_.AdvanceTimeMilliseconds(kOffsetMs);
Erik Språnga57711c2019-07-24 10:47:20 +02002564
Erik Språnga57711c2019-07-24 10:47:20 +02002565 std::unique_ptr<RtpPacketToSend> rtx_packet_to_pace;
Erik Språngea55b082019-10-02 14:57:46 +02002566 EXPECT_CALL(mock_paced_sender_, EnqueuePackets)
2567 .WillOnce([&](std::vector<std::unique_ptr<RtpPacketToSend>> packets) {
2568 EXPECT_GT(packets[0]->capture_time_ms(), 0);
2569 rtx_packet_to_pace = std::move(packets[0]);
Erik Språnga57711c2019-07-24 10:47:20 +02002570 });
2571
Erik Språngb5330102019-10-28 10:09:43 +01002572 EXPECT_GT(rtp_sender()->ReSendPacket(kSeqNum), 0);
2573 rtp_egress()->SendPacket(rtx_packet_to_pace.get(), PacedPacketInfo());
Erik Språnga57711c2019-07-24 10:47:20 +02002574
Erik Språngb5330102019-10-28 10:09:43 +01002575 EXPECT_EQ(2, transport_.packets_sent());
2576 transmission_time_extension =
2577 transport_.sent_packets_.back().GetExtension<TransmissionOffset>();
2578 ASSERT_TRUE(transmission_time_extension.has_value());
2579 EXPECT_EQ(*transmission_time_extension,
2580 2 * kOffsetMs * kTimestampTicksPerMs);
Erik Språnga57711c2019-07-24 10:47:20 +02002581}
2582
Erik Språng6cacef22019-07-24 14:15:51 +02002583TEST_P(RtpSenderTestWithoutPacer, ClearHistoryOnSequenceNumberCange) {
2584 const int64_t kRtt = 10;
2585
Erik Språngb5330102019-10-28 10:09:43 +01002586 rtp_sender()->SetSendingMediaStatus(true);
2587 rtp_sender()->SetRtxStatus(kRtxRetransmitted | kRtxRedundantPayloads);
2588 rtp_sender()->SetRtxPayloadType(kRtxPayload, kPayload);
2589 rtp_sender_context_->packet_history_.SetStorePacketsStatus(
2590 RtpPacketHistory::StorageMode::kStoreAndCull, 10);
2591 rtp_sender_context_->packet_history_.SetRtt(kRtt);
Erik Språng6cacef22019-07-24 14:15:51 +02002592
2593 // Send a packet and record its sequence numbers.
2594 SendGenericPacket();
2595 ASSERT_EQ(1u, transport_.sent_packets_.size());
2596 const uint16_t packet_seqence_number =
2597 transport_.sent_packets_.back().SequenceNumber();
2598
2599 // Advance time and make sure it can be retransmitted, even if we try to set
2600 // the ssrc the what it already is.
Erik Språngb5330102019-10-28 10:09:43 +01002601 rtp_sender()->SetSequenceNumber(rtp_sender()->SequenceNumber());
Erik Språng6cacef22019-07-24 14:15:51 +02002602 fake_clock_.AdvanceTimeMilliseconds(kRtt);
Erik Språngb5330102019-10-28 10:09:43 +01002603 EXPECT_GT(rtp_sender()->ReSendPacket(packet_seqence_number), 0);
Erik Språng6cacef22019-07-24 14:15:51 +02002604
2605 // Change the sequence number, then move the time and try to retransmit again.
2606 // The old packet should now be gone.
Erik Språngb5330102019-10-28 10:09:43 +01002607 rtp_sender()->SetSequenceNumber(rtp_sender()->SequenceNumber() - 1);
Erik Språng6cacef22019-07-24 14:15:51 +02002608 fake_clock_.AdvanceTimeMilliseconds(kRtt);
Erik Språngb5330102019-10-28 10:09:43 +01002609 EXPECT_EQ(rtp_sender()->ReSendPacket(packet_seqence_number), 0);
Erik Språng6cacef22019-07-24 14:15:51 +02002610}
2611
Erik Språng60ffc312019-07-30 22:03:49 +02002612TEST_P(RtpSenderTest, IgnoresNackAfterDisablingMedia) {
2613 const int64_t kRtt = 10;
2614
Erik Språngb5330102019-10-28 10:09:43 +01002615 rtp_sender()->SetSendingMediaStatus(true);
2616 rtp_sender()->SetRtxStatus(kRtxRetransmitted | kRtxRedundantPayloads);
2617 rtp_sender()->SetRtxPayloadType(kRtxPayload, kPayload);
2618 rtp_sender_context_->packet_history_.SetStorePacketsStatus(
2619 RtpPacketHistory::StorageMode::kStoreAndCull, 10);
2620 rtp_sender_context_->packet_history_.SetRtt(kRtt);
Erik Språng60ffc312019-07-30 22:03:49 +02002621
2622 // Send a packet so it is in the packet history.
Erik Språng60ffc312019-07-30 22:03:49 +02002623 std::unique_ptr<RtpPacketToSend> packet_to_pace;
Erik Språngea55b082019-10-02 14:57:46 +02002624 EXPECT_CALL(mock_paced_sender_, EnqueuePackets)
2625 .WillOnce([&](std::vector<std::unique_ptr<RtpPacketToSend>> packets) {
2626 packet_to_pace = std::move(packets[0]);
Erik Språng60ffc312019-07-30 22:03:49 +02002627 });
2628
2629 SendGenericPacket();
Erik Språngb5330102019-10-28 10:09:43 +01002630 rtp_egress()->SendPacket(packet_to_pace.get(), PacedPacketInfo());
Erik Språng60ffc312019-07-30 22:03:49 +02002631
2632 ASSERT_EQ(1u, transport_.sent_packets_.size());
2633
2634 // Disable media sending and try to retransmit the packet, it should fail.
Erik Språngb5330102019-10-28 10:09:43 +01002635 rtp_sender()->SetSendingMediaStatus(false);
Erik Språng60ffc312019-07-30 22:03:49 +02002636 fake_clock_.AdvanceTimeMilliseconds(kRtt);
Erik Språngb5330102019-10-28 10:09:43 +01002637 EXPECT_LT(rtp_sender()->ReSendPacket(kSeqNum), 0);
Erik Språng60ffc312019-07-30 22:03:49 +02002638}
2639
Mirko Bonadeic84f6612019-01-31 12:20:57 +01002640INSTANTIATE_TEST_SUITE_P(WithAndWithoutOverhead,
2641 RtpSenderTest,
Erik Språngf5815fa2019-08-21 14:27:31 +02002642 ::testing::Values(TestConfig{false},
2643 TestConfig{true}));
Erik Språngf6468d22019-07-05 16:53:43 +02002644
Mirko Bonadeic84f6612019-01-31 12:20:57 +01002645INSTANTIATE_TEST_SUITE_P(WithAndWithoutOverhead,
2646 RtpSenderTestWithoutPacer,
Erik Språngf5815fa2019-08-21 14:27:31 +02002647 ::testing::Values(TestConfig{false},
2648 TestConfig{true}));
Niels Möllera34d7762019-02-01 14:13:29 +01002649
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00002650} // namespace webrtc