blob: 6d8de07a468931030330479eb423aa1f4aef4f0e [file] [log] [blame]
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +00001/*
phoglund@webrtc.org78088c22012-02-07 14:56:45 +00002 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +00003 *
4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
9 */
10
kwiberg84be5112016-04-27 01:19:58 -070011#include <memory>
danilchapb8b6fbb2015-12-10 05:05:27 -080012#include <vector>
13
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020014#include "api/video/video_timing.h"
Elad Alon4a87e1c2017-10-03 16:11:34 +020015#include "logging/rtc_event_log/events/rtc_event.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020016#include "logging/rtc_event_log/mock/mock_rtc_event_log.h"
17#include "modules/rtp_rtcp/include/rtp_cvo.h"
18#include "modules/rtp_rtcp/include/rtp_header_extension_map.h"
19#include "modules/rtp_rtcp/include/rtp_header_parser.h"
20#include "modules/rtp_rtcp/include/rtp_rtcp_defines.h"
21#include "modules/rtp_rtcp/source/rtcp_packet/transport_feedback.h"
22#include "modules/rtp_rtcp/source/rtp_format_video_generic.h"
23#include "modules/rtp_rtcp/source/rtp_header_extensions.h"
24#include "modules/rtp_rtcp/source/rtp_packet_received.h"
25#include "modules/rtp_rtcp/source/rtp_packet_to_send.h"
26#include "modules/rtp_rtcp/source/rtp_sender.h"
27#include "modules/rtp_rtcp/source/rtp_sender_video.h"
28#include "modules/rtp_rtcp/source/rtp_utility.h"
29#include "rtc_base/arraysize.h"
30#include "rtc_base/buffer.h"
31#include "rtc_base/ptr_util.h"
32#include "rtc_base/rate_limiter.h"
33#include "test/field_trial.h"
34#include "test/gmock.h"
35#include "test/gtest.h"
36#include "test/mock_transport.h"
Mirko Bonadei71207422017-09-15 13:58:09 +020037#include "typedefs.h" // NOLINT(build/include)
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +000038
39namespace webrtc {
40
andrew@webrtc.org8a442592011-12-16 21:24:30 +000041namespace {
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +000042const int kTransmissionTimeOffsetExtensionId = 1;
43const int kAbsoluteSendTimeExtensionId = 14;
sprang@webrtc.org30933902015-03-17 14:33:12 +000044const int kTransportSequenceNumberExtensionId = 13;
ilnik04f4d122017-06-19 07:18:55 -070045const int kVideoTimingExtensionId = 12;
andrew@webrtc.org8a442592011-12-16 21:24:30 +000046const int kPayload = 100;
Shao Changbine62202f2015-04-21 20:24:50 +080047const int kRtxPayload = 98;
andrew@webrtc.org8a442592011-12-16 21:24:30 +000048const uint32_t kTimestamp = 10;
49const uint16_t kSeqNum = 33;
brandtr9dfff292016-11-14 05:14:50 -080050const uint32_t kSsrc = 725242;
andrew@webrtc.org8a442592011-12-16 21:24:30 +000051const int kMaxPacketLength = 1500;
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +000052const uint8_t kAudioLevel = 0x5a;
sprang@webrtc.org30933902015-03-17 14:33:12 +000053const uint16_t kTransportSequenceNumber = 0xaabbu;
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +000054const uint8_t kAudioLevelExtensionId = 9;
55const int kAudioPayload = 103;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +000056const uint64_t kStartTime = 123456789;
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +000057const size_t kMaxPaddingSize = 224u;
guoweis@webrtc.org45362892015-03-04 22:55:15 +000058const int kVideoRotationExtensionId = 5;
Stefan Holmera246cfb2016-08-23 17:51:42 +020059const size_t kGenericHeaderLength = 1;
60const uint8_t kPayloadData[] = {47, 11, 32, 93, 89};
spranga8ae6f22017-09-04 07:23:56 -070061const int64_t kDefaultExpectedRetransmissionTimeMs = 125;
andrew@webrtc.org8a442592011-12-16 21:24:30 +000062
Danil Chapovalov5e57b172016-09-02 19:15:59 +020063using ::testing::_;
64using ::testing::ElementsAreArray;
sprang168794c2017-07-06 04:38:06 -070065using ::testing::Invoke;
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +000066
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +000067uint64_t ConvertMsToAbsSendTime(int64_t time_ms) {
Stefan Holmer0a87ffc2015-10-21 13:41:48 +020068 return (((time_ms << 18) + 500) / 1000) & 0x00ffffff;
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +000069}
70
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +000071class LoopbackTransportTest : public webrtc::Transport {
72 public:
danilchap12ba1862016-10-26 02:41:55 -070073 LoopbackTransportTest() : total_bytes_sent_(0), last_packet_id_(-1) {
74 receivers_extensions_.Register(kRtpExtensionTransmissionTimeOffset,
75 kTransmissionTimeOffsetExtensionId);
76 receivers_extensions_.Register(kRtpExtensionAbsoluteSendTime,
77 kAbsoluteSendTimeExtensionId);
78 receivers_extensions_.Register(kRtpExtensionTransportSequenceNumber,
79 kTransportSequenceNumberExtensionId);
80 receivers_extensions_.Register(kRtpExtensionVideoRotation,
81 kVideoRotationExtensionId);
82 receivers_extensions_.Register(kRtpExtensionAudioLevel,
83 kAudioLevelExtensionId);
ilnik04f4d122017-06-19 07:18:55 -070084 receivers_extensions_.Register(kRtpExtensionVideoTiming,
85 kVideoTimingExtensionId);
guoweis@webrtc.org45362892015-03-04 22:55:15 +000086 }
danilchap12ba1862016-10-26 02:41:55 -070087
stefan1d8a5062015-10-02 03:39:33 -070088 bool SendRtp(const uint8_t* data,
89 size_t len,
90 const PacketOptions& options) override {
Stefan Holmerf5dca482016-01-27 12:58:51 +010091 last_packet_id_ = options.packet_id;
pkasting@chromium.org4591fbd2014-11-20 22:28:14 +000092 total_bytes_sent_ += len;
danilchap12ba1862016-10-26 02:41:55 -070093 sent_packets_.push_back(RtpPacketReceived(&receivers_extensions_));
94 EXPECT_TRUE(sent_packets_.back().Parse(data, len));
pbos2d566682015-09-28 09:59:31 -070095 return true;
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +000096 }
danilchap162abd32015-12-10 02:39:40 -080097 bool SendRtcp(const uint8_t* data, size_t len) override { return false; }
danilchap12ba1862016-10-26 02:41:55 -070098 const RtpPacketReceived& last_sent_packet() { return sent_packets_.back(); }
99 int packets_sent() { return sent_packets_.size(); }
100
pbos@webrtc.org72491b92014-07-10 16:24:54 +0000101 size_t total_bytes_sent_;
Stefan Holmerf5dca482016-01-27 12:58:51 +0100102 int last_packet_id_;
danilchap12ba1862016-10-26 02:41:55 -0700103 std::vector<RtpPacketReceived> sent_packets_;
104
105 private:
106 RtpHeaderExtensionMap receivers_extensions_;
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000107};
108
Elad Alon4a87e1c2017-10-03 16:11:34 +0200109MATCHER_P(SameRtcEventTypeAs, value, "") {
110 return value == arg->GetType();
111}
112
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000113} // namespace
114
sprangebbf8a82015-09-21 15:11:14 -0700115class MockRtpPacketSender : public RtpPacketSender {
116 public:
117 MockRtpPacketSender() {}
118 virtual ~MockRtpPacketSender() {}
119
Peter Boströme23e7372015-10-08 11:44:14 +0200120 MOCK_METHOD6(InsertPacket,
121 void(Priority priority,
sprangebbf8a82015-09-21 15:11:14 -0700122 uint32_t ssrc,
123 uint16_t sequence_number,
124 int64_t capture_time_ms,
125 size_t bytes,
126 bool retransmission));
127};
128
Stefan Holmerf5dca482016-01-27 12:58:51 +0100129class MockTransportSequenceNumberAllocator
130 : public TransportSequenceNumberAllocator {
131 public:
132 MOCK_METHOD0(AllocateSequenceNumber, uint16_t());
133};
134
asapersson35151f32016-05-02 23:44:01 -0700135class MockSendPacketObserver : public SendPacketObserver {
136 public:
137 MOCK_METHOD3(OnSendPacket, void(uint16_t, int64_t, uint32_t));
138};
139
Stefan Holmera246cfb2016-08-23 17:51:42 +0200140class MockTransportFeedbackObserver : public TransportFeedbackObserver {
141 public:
elad.alond12a8e12017-03-23 11:04:48 -0700142 MOCK_METHOD4(AddPacket,
143 void(uint32_t, uint16_t, size_t, const PacedPacketInfo&));
Stefan Holmera246cfb2016-08-23 17:51:42 +0200144 MOCK_METHOD1(OnTransportFeedback, void(const rtcp::TransportFeedback&));
elad.alonf9490002017-03-06 05:32:21 -0800145 MOCK_CONST_METHOD0(GetTransportFeedbackVector, std::vector<PacketFeedback>());
Stefan Holmera246cfb2016-08-23 17:51:42 +0200146};
147
minyue3a407ee2017-04-03 01:10:33 -0700148class MockOverheadObserver : public OverheadObserver {
149 public:
150 MOCK_METHOD1(OnOverheadChanged, void(size_t overhead_bytes_per_packet));
151};
152
153class RtpSenderTest : public ::testing::TestWithParam<bool> {
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000154 protected:
155 RtpSenderTest()
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +0000156 : fake_clock_(kStartTime),
terelius429c3452016-01-21 05:42:04 -0800157 mock_rtc_event_log_(),
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +0000158 mock_paced_sender_(),
sprangcd349d92016-07-13 09:11:28 -0700159 retransmission_rate_limiter_(&fake_clock_, 1000),
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +0000160 rtp_sender_(),
161 payload_(kPayload),
162 transport_(),
minyue3a407ee2017-04-03 01:10:33 -0700163 kMarkerBit(true),
164 field_trials_(GetParam() ? "WebRTC-SendSideBwe-WithOverhead/Enabled/"
165 : "") {}
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +0000166
Erik Språng7b52f102018-02-07 14:37:37 +0100167 void SetUp() override { SetUpRtpSender(true, false); }
Peter Boströme23e7372015-10-08 11:44:14 +0200168
Erik Språng7b52f102018-02-07 14:37:37 +0100169 void SetUpRtpSender(bool pacer, bool populate_network2) {
asapersson35151f32016-05-02 23:44:01 -0700170 rtp_sender_.reset(new RTPSender(
171 false, &fake_clock_, &transport_, pacer ? &mock_paced_sender_ : nullptr,
brandtrdbdb3f12016-11-10 05:04:48 -0800172 nullptr, &seq_num_allocator_, nullptr, nullptr, nullptr, nullptr,
sprangcd349d92016-07-13 09:11:28 -0700173 &mock_rtc_event_log_, &send_packet_observer_,
Erik Språng7b52f102018-02-07 14:37:37 +0100174 &retransmission_rate_limiter_, nullptr, populate_network2));
brandtr9dfff292016-11-14 05:14:50 -0800175 rtp_sender_->SetSequenceNumber(kSeqNum);
danilchap71fead22016-08-18 02:01:49 -0700176 rtp_sender_->SetTimestampOffset(0);
brandtr9dfff292016-11-14 05:14:50 -0800177 rtp_sender_->SetSSRC(kSsrc);
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +0000178 }
179
stefan@webrtc.orga678a3b2013-01-21 07:42:11 +0000180 SimulatedClock fake_clock_;
stefana23fc622016-07-28 07:56:38 -0700181 testing::NiceMock<MockRtcEventLog> mock_rtc_event_log_;
sprangebbf8a82015-09-21 15:11:14 -0700182 MockRtpPacketSender mock_paced_sender_;
stefana23fc622016-07-28 07:56:38 -0700183 testing::StrictMock<MockTransportSequenceNumberAllocator> seq_num_allocator_;
184 testing::StrictMock<MockSendPacketObserver> send_packet_observer_;
Stefan Holmera246cfb2016-08-23 17:51:42 +0200185 testing::StrictMock<MockTransportFeedbackObserver> feedback_observer_;
sprangcd349d92016-07-13 09:11:28 -0700186 RateLimiter retransmission_rate_limiter_;
kwiberg84be5112016-04-27 01:19:58 -0700187 std::unique_ptr<RTPSender> rtp_sender_;
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +0000188 int payload_;
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000189 LoopbackTransportTest transport_;
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000190 const bool kMarkerBit;
minyue3a407ee2017-04-03 01:10:33 -0700191 test::ScopedFieldTrials field_trials_;
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000192
stefan@webrtc.orga5cb98c2013-05-29 12:12:51 +0000193 void VerifyRTPHeaderCommon(const RTPHeader& rtp_header) {
danilchapd9e62f52016-01-14 14:55:19 -0800194 VerifyRTPHeaderCommon(rtp_header, kMarkerBit, 0);
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000195 }
196
197 void VerifyRTPHeaderCommon(const RTPHeader& rtp_header, bool marker_bit) {
danilchapd9e62f52016-01-14 14:55:19 -0800198 VerifyRTPHeaderCommon(rtp_header, marker_bit, 0);
199 }
200
201 void VerifyRTPHeaderCommon(const RTPHeader& rtp_header,
202 bool marker_bit,
203 uint8_t number_of_csrcs) {
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000204 EXPECT_EQ(marker_bit, rtp_header.markerBit);
stefan@webrtc.orga5cb98c2013-05-29 12:12:51 +0000205 EXPECT_EQ(payload_, rtp_header.payloadType);
206 EXPECT_EQ(kSeqNum, rtp_header.sequenceNumber);
207 EXPECT_EQ(kTimestamp, rtp_header.timestamp);
208 EXPECT_EQ(rtp_sender_->SSRC(), rtp_header.ssrc);
danilchapd9e62f52016-01-14 14:55:19 -0800209 EXPECT_EQ(number_of_csrcs, rtp_header.numCSRCs);
pkasting@chromium.org4591fbd2014-11-20 22:28:14 +0000210 EXPECT_EQ(0U, rtp_header.paddingLength);
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000211 }
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000212
danilchapb6f1fb52016-10-19 06:11:39 -0700213 std::unique_ptr<RtpPacketToSend> BuildRtpPacket(int payload_type,
214 bool marker_bit,
215 uint32_t timestamp,
216 int64_t capture_time_ms) {
217 auto packet = rtp_sender_->AllocatePacket();
218 packet->SetPayloadType(payload_type);
219 packet->SetMarker(marker_bit);
220 packet->SetTimestamp(timestamp);
221 packet->set_capture_time_ms(capture_time_ms);
222 EXPECT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
223 return packet;
224 }
225
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000226 void SendPacket(int64_t capture_time_ms, int payload_length) {
227 uint32_t timestamp = capture_time_ms * 90;
danilchapb6f1fb52016-10-19 06:11:39 -0700228 auto packet =
229 BuildRtpPacket(kPayload, kMarkerBit, timestamp, capture_time_ms);
230 packet->AllocatePayload(payload_length);
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000231
232 // Packet should be stored in a send bucket.
danilchapb6f1fb52016-10-19 06:11:39 -0700233 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
234 kAllowRetransmission,
235 RtpPacketSender::kNormalPriority));
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000236 }
asapersson35151f32016-05-02 23:44:01 -0700237
238 void SendGenericPayload() {
asapersson35151f32016-05-02 23:44:01 -0700239 const uint32_t kTimestamp = 1234;
240 const uint8_t kPayloadType = 127;
241 const int64_t kCaptureTimeMs = fake_clock_.TimeInMilliseconds();
242 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
243 EXPECT_EQ(0, rtp_sender_->RegisterPayload(payload_name, kPayloadType, 90000,
244 0, 1500));
245
Sergey Ulanov525df3f2016-08-02 17:46:41 -0700246 EXPECT_TRUE(rtp_sender_->SendOutgoingData(
Stefan Holmera246cfb2016-08-23 17:51:42 +0200247 kVideoFrameKey, kPayloadType, kTimestamp, kCaptureTimeMs, kPayloadData,
spranga8ae6f22017-09-04 07:23:56 -0700248 sizeof(kPayloadData), nullptr, nullptr, nullptr,
249 kDefaultExpectedRetransmissionTimeMs));
asapersson35151f32016-05-02 23:44:01 -0700250 }
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000251};
252
Peter Boströme23e7372015-10-08 11:44:14 +0200253// TODO(pbos): Move tests over from WithoutPacer to RtpSenderTest as this is our
254// default code path.
255class RtpSenderTestWithoutPacer : public RtpSenderTest {
256 public:
Erik Språng7b52f102018-02-07 14:37:37 +0100257 void SetUp() override { SetUpRtpSender(false, false); }
Peter Boströme23e7372015-10-08 11:44:14 +0200258};
259
spranga8ae6f22017-09-04 07:23:56 -0700260class TestRtpSenderVideo : public RTPSenderVideo {
261 public:
262 TestRtpSenderVideo(Clock* clock,
263 RTPSender* rtp_sender,
264 FlexfecSender* flexfec_sender)
265 : RTPSenderVideo(clock, rtp_sender, flexfec_sender) {}
266 ~TestRtpSenderVideo() override {}
267
268 StorageType GetStorageType(const RTPVideoHeader& header,
269 int32_t retransmission_settings,
270 int64_t expected_retransmission_time_ms) {
271 return RTPSenderVideo::GetStorageType(GetTemporalId(header),
272 retransmission_settings,
273 expected_retransmission_time_ms);
274 }
275};
276
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000277class RtpSenderVideoTest : public RtpSenderTest {
278 protected:
danilchap162abd32015-12-10 02:39:40 -0800279 void SetUp() override {
Peter Boströme23e7372015-10-08 11:44:14 +0200280 // TODO(pbos): Set up to use pacer.
Erik Språng7b52f102018-02-07 14:37:37 +0100281 SetUpRtpSender(false, false);
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000282 rtp_sender_video_.reset(
spranga8ae6f22017-09-04 07:23:56 -0700283 new TestRtpSenderVideo(&fake_clock_, rtp_sender_.get(), nullptr));
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000284 }
spranga8ae6f22017-09-04 07:23:56 -0700285 std::unique_ptr<TestRtpSenderVideo> rtp_sender_video_;
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000286};
287
minyue3a407ee2017-04-03 01:10:33 -0700288TEST_P(RtpSenderTestWithoutPacer, AllocatePacketSetCsrc) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200289 // Configure rtp_sender with csrc.
290 std::vector<uint32_t> csrcs;
291 csrcs.push_back(0x23456789);
292 rtp_sender_->SetCsrcs(csrcs);
293
294 auto packet = rtp_sender_->AllocatePacket();
295
296 ASSERT_TRUE(packet);
297 EXPECT_EQ(rtp_sender_->SSRC(), packet->Ssrc());
298 EXPECT_EQ(csrcs, packet->Csrcs());
299}
300
minyue3a407ee2017-04-03 01:10:33 -0700301TEST_P(RtpSenderTestWithoutPacer, AllocatePacketReserveExtensions) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200302 // Configure rtp_sender with extensions.
303 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
304 kRtpExtensionTransmissionTimeOffset,
305 kTransmissionTimeOffsetExtensionId));
306 ASSERT_EQ(
307 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
308 kAbsoluteSendTimeExtensionId));
309 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAudioLevel,
310 kAudioLevelExtensionId));
311 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
312 kRtpExtensionTransportSequenceNumber,
313 kTransportSequenceNumberExtensionId));
314 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
315 kRtpExtensionVideoRotation, kVideoRotationExtensionId));
316
317 auto packet = rtp_sender_->AllocatePacket();
318
319 ASSERT_TRUE(packet);
320 // Preallocate BWE extensions RtpSender set itself.
321 EXPECT_TRUE(packet->HasExtension<TransmissionOffset>());
322 EXPECT_TRUE(packet->HasExtension<AbsoluteSendTime>());
323 EXPECT_TRUE(packet->HasExtension<TransportSequenceNumber>());
324 // Do not allocate media specific extensions.
325 EXPECT_FALSE(packet->HasExtension<AudioLevel>());
326 EXPECT_FALSE(packet->HasExtension<VideoOrientation>());
327}
328
minyue3a407ee2017-04-03 01:10:33 -0700329TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberAdvanceSequenceNumber) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200330 auto packet = rtp_sender_->AllocatePacket();
331 ASSERT_TRUE(packet);
332 const uint16_t sequence_number = rtp_sender_->SequenceNumber();
333
334 EXPECT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
335
336 EXPECT_EQ(sequence_number, packet->SequenceNumber());
337 EXPECT_EQ(sequence_number + 1, rtp_sender_->SequenceNumber());
338}
339
minyue3a407ee2017-04-03 01:10:33 -0700340TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberFailsOnNotSending) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200341 auto packet = rtp_sender_->AllocatePacket();
342 ASSERT_TRUE(packet);
343
344 rtp_sender_->SetSendingMediaStatus(false);
345 EXPECT_FALSE(rtp_sender_->AssignSequenceNumber(packet.get()));
346}
347
Danil Chapovalovb3179c72018-03-22 10:13:07 +0100348TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberMayAllowPaddingOnVideo) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200349 constexpr size_t kPaddingSize = 100;
350 auto packet = rtp_sender_->AllocatePacket();
351 ASSERT_TRUE(packet);
352
philipel8aadd502017-02-23 02:56:13 -0800353 ASSERT_FALSE(rtp_sender_->TimeToSendPadding(kPaddingSize, PacedPacketInfo()));
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200354 packet->SetMarker(false);
355 ASSERT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
Danil Chapovalovb3179c72018-03-22 10:13:07 +0100356 // Packet without marker bit doesn't allow padding on video stream.
philipel8aadd502017-02-23 02:56:13 -0800357 EXPECT_FALSE(rtp_sender_->TimeToSendPadding(kPaddingSize, PacedPacketInfo()));
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200358
359 packet->SetMarker(true);
360 ASSERT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
361 // Packet with marker bit allows send padding.
philipel8aadd502017-02-23 02:56:13 -0800362 EXPECT_TRUE(rtp_sender_->TimeToSendPadding(kPaddingSize, PacedPacketInfo()));
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200363}
364
Danil Chapovalovb3179c72018-03-22 10:13:07 +0100365TEST_P(RtpSenderTest, AssignSequenceNumberAllowsPaddingOnAudio) {
366 MockTransport transport;
367 const bool kEnableAudio = true;
368 rtp_sender_.reset(new RTPSender(
369 kEnableAudio, &fake_clock_, &transport, &mock_paced_sender_, nullptr,
370 nullptr, nullptr, nullptr, nullptr, nullptr, &mock_rtc_event_log_,
371 nullptr, &retransmission_rate_limiter_, nullptr, false));
372 rtp_sender_->SetTimestampOffset(0);
373 rtp_sender_->SetSSRC(kSsrc);
374
375 std::unique_ptr<RtpPacketToSend> audio_packet = rtp_sender_->AllocatePacket();
376 // Padding on audio stream allowed regardless of marker in the last packet.
377 audio_packet->SetMarker(false);
378 audio_packet->SetPayloadType(kPayload);
379 rtp_sender_->AssignSequenceNumber(audio_packet.get());
380
381 const size_t kPaddingSize = 59;
382 EXPECT_CALL(transport, SendRtp(_, kPaddingSize + kRtpHeaderSize, _))
383 .WillOnce(testing::Return(true));
384 EXPECT_EQ(kPaddingSize,
385 rtp_sender_->TimeToSendPadding(kPaddingSize, PacedPacketInfo()));
386
387 // Requested padding size is too small, will send a larger one.
388 const size_t kMinPaddingSize = 50;
389 EXPECT_CALL(transport, SendRtp(_, kMinPaddingSize + kRtpHeaderSize, _))
390 .WillOnce(testing::Return(true));
391 EXPECT_EQ(
392 kMinPaddingSize,
393 rtp_sender_->TimeToSendPadding(kMinPaddingSize - 5, PacedPacketInfo()));
394}
395
minyue3a407ee2017-04-03 01:10:33 -0700396TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberSetPaddingTimestamps) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200397 constexpr size_t kPaddingSize = 100;
398 auto packet = rtp_sender_->AllocatePacket();
399 ASSERT_TRUE(packet);
400 packet->SetMarker(true);
401 packet->SetTimestamp(kTimestamp);
402
403 ASSERT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
philipel8aadd502017-02-23 02:56:13 -0800404 ASSERT_TRUE(rtp_sender_->TimeToSendPadding(kPaddingSize, PacedPacketInfo()));
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200405
406 ASSERT_EQ(1u, transport_.sent_packets_.size());
danilchap12ba1862016-10-26 02:41:55 -0700407 // Verify padding packet timestamp.
408 EXPECT_EQ(kTimestamp, transport_.last_sent_packet().Timestamp());
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200409}
410
minyue3a407ee2017-04-03 01:10:33 -0700411TEST_P(RtpSenderTestWithoutPacer,
412 TransportFeedbackObserverGetsCorrectByteCount) {
413 constexpr int kRtpOverheadBytesPerPacket = 12 + 8;
414 testing::NiceMock<MockOverheadObserver> mock_overhead_observer;
415 rtp_sender_.reset(new RTPSender(
416 false, &fake_clock_, &transport_, nullptr, nullptr, &seq_num_allocator_,
417 &feedback_observer_, nullptr, nullptr, nullptr, &mock_rtc_event_log_,
Erik Språng7b52f102018-02-07 14:37:37 +0100418 nullptr, &retransmission_rate_limiter_, &mock_overhead_observer, false));
minyue3a407ee2017-04-03 01:10:33 -0700419 rtp_sender_->SetSSRC(kSsrc);
420 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
421 kRtpExtensionTransportSequenceNumber,
422 kTransportSequenceNumberExtensionId));
423 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
424 .WillOnce(testing::Return(kTransportSequenceNumber));
425
426 const size_t expected_bytes =
427 GetParam() ? sizeof(kPayloadData) + kGenericHeaderLength +
428 kRtpOverheadBytesPerPacket
429 : sizeof(kPayloadData) + kGenericHeaderLength;
430
431 EXPECT_CALL(feedback_observer_,
432 AddPacket(rtp_sender_->SSRC(), kTransportSequenceNumber,
433 expected_bytes, PacedPacketInfo()))
434 .Times(1);
435 EXPECT_CALL(mock_overhead_observer,
436 OnOverheadChanged(kRtpOverheadBytesPerPacket))
437 .Times(1);
438 SendGenericPayload();
439}
440
441TEST_P(RtpSenderTestWithoutPacer, SendsPacketsWithTransportSequenceNumber) {
Stefan Holmera246cfb2016-08-23 17:51:42 +0200442 rtp_sender_.reset(new RTPSender(
brandtrdbdb3f12016-11-10 05:04:48 -0800443 false, &fake_clock_, &transport_, nullptr, nullptr, &seq_num_allocator_,
444 &feedback_observer_, nullptr, nullptr, nullptr, &mock_rtc_event_log_,
Erik Språng7b52f102018-02-07 14:37:37 +0100445 &send_packet_observer_, &retransmission_rate_limiter_, nullptr, false));
nisse7d59f6b2017-02-21 03:40:24 -0800446 rtp_sender_->SetSSRC(kSsrc);
Stefan Holmerf5dca482016-01-27 12:58:51 +0100447 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
448 kRtpExtensionTransportSequenceNumber,
449 kTransportSequenceNumberExtensionId));
450
Stefan Holmerf5dca482016-01-27 12:58:51 +0100451 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
452 .WillOnce(testing::Return(kTransportSequenceNumber));
asapersson35151f32016-05-02 23:44:01 -0700453 EXPECT_CALL(send_packet_observer_,
454 OnSendPacket(kTransportSequenceNumber, _, _))
455 .Times(1);
minyue3a407ee2017-04-03 01:10:33 -0700456
457 EXPECT_CALL(feedback_observer_,
458 AddPacket(rtp_sender_->SSRC(), kTransportSequenceNumber, _,
459 PacedPacketInfo()))
Stefan Holmera246cfb2016-08-23 17:51:42 +0200460 .Times(1);
asapersson35151f32016-05-02 23:44:01 -0700461
462 SendGenericPayload();
Stefan Holmerf5dca482016-01-27 12:58:51 +0100463
danilchap12ba1862016-10-26 02:41:55 -0700464 const auto& packet = transport_.last_sent_packet();
465 uint16_t transport_seq_no;
466 ASSERT_TRUE(packet.GetExtension<TransportSequenceNumber>(&transport_seq_no));
467 EXPECT_EQ(kTransportSequenceNumber, transport_seq_no);
468 EXPECT_EQ(transport_.last_packet_id_, transport_seq_no);
Stefan Holmerf5dca482016-01-27 12:58:51 +0100469}
470
minyue3a407ee2017-04-03 01:10:33 -0700471TEST_P(RtpSenderTestWithoutPacer, NoAllocationIfNotRegistered) {
stefana23fc622016-07-28 07:56:38 -0700472 SendGenericPayload();
473}
asapersson35151f32016-05-02 23:44:01 -0700474
minyue3a407ee2017-04-03 01:10:33 -0700475TEST_P(RtpSenderTestWithoutPacer, OnSendPacketUpdated) {
stefana23fc622016-07-28 07:56:38 -0700476 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
477 kRtpExtensionTransportSequenceNumber,
478 kTransportSequenceNumberExtensionId));
asapersson35151f32016-05-02 23:44:01 -0700479 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
480 .WillOnce(testing::Return(kTransportSequenceNumber));
481 EXPECT_CALL(send_packet_observer_,
482 OnSendPacket(kTransportSequenceNumber, _, _))
483 .Times(1);
484
485 SendGenericPayload();
486}
487
minyue3a407ee2017-04-03 01:10:33 -0700488TEST_P(RtpSenderTest, SendsPacketsWithTransportSequenceNumber) {
michaelt4da30442016-11-17 01:38:43 -0800489 rtp_sender_.reset(new RTPSender(
490 false, &fake_clock_, &transport_, &mock_paced_sender_, nullptr,
491 &seq_num_allocator_, &feedback_observer_, nullptr, nullptr, nullptr,
492 &mock_rtc_event_log_, &send_packet_observer_,
Erik Språng7b52f102018-02-07 14:37:37 +0100493 &retransmission_rate_limiter_, nullptr, false));
brandtr9dfff292016-11-14 05:14:50 -0800494 rtp_sender_->SetSequenceNumber(kSeqNum);
495 rtp_sender_->SetSSRC(kSsrc);
Stefan Holmera246cfb2016-08-23 17:51:42 +0200496 rtp_sender_->SetStorePacketsStatus(true, 10);
497 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
498 kRtpExtensionTransportSequenceNumber,
499 kTransportSequenceNumberExtensionId));
500
brandtr9dfff292016-11-14 05:14:50 -0800501 EXPECT_CALL(mock_paced_sender_, InsertPacket(_, kSsrc, kSeqNum, _, _, _));
Stefan Holmera246cfb2016-08-23 17:51:42 +0200502 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
503 .WillOnce(testing::Return(kTransportSequenceNumber));
504 EXPECT_CALL(send_packet_observer_,
505 OnSendPacket(kTransportSequenceNumber, _, _))
506 .Times(1);
minyue3a407ee2017-04-03 01:10:33 -0700507 EXPECT_CALL(feedback_observer_,
508 AddPacket(rtp_sender_->SSRC(), kTransportSequenceNumber, _,
509 PacedPacketInfo()))
Stefan Holmera246cfb2016-08-23 17:51:42 +0200510 .Times(1);
511
512 SendGenericPayload();
philipel8aadd502017-02-23 02:56:13 -0800513 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum,
514 fake_clock_.TimeInMilliseconds(), false,
515 PacedPacketInfo());
Stefan Holmera246cfb2016-08-23 17:51:42 +0200516
danilchap12ba1862016-10-26 02:41:55 -0700517 const auto& packet = transport_.last_sent_packet();
518 uint16_t transport_seq_no;
519 EXPECT_TRUE(packet.GetExtension<TransportSequenceNumber>(&transport_seq_no));
520 EXPECT_EQ(kTransportSequenceNumber, transport_seq_no);
521 EXPECT_EQ(transport_.last_packet_id_, transport_seq_no);
Stefan Holmera246cfb2016-08-23 17:51:42 +0200522}
523
Erik Språng7b52f102018-02-07 14:37:37 +0100524TEST_P(RtpSenderTest, WritesPacerExitToTimingExtension) {
ilnik04f4d122017-06-19 07:18:55 -0700525 rtp_sender_->SetStorePacketsStatus(true, 10);
526 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
527 kRtpExtensionVideoTiming, kVideoTimingExtensionId));
528 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
529 auto packet = rtp_sender_->AllocatePacket();
530 packet->SetPayloadType(kPayload);
531 packet->SetMarker(true);
532 packet->SetTimestamp(kTimestamp);
533 packet->set_capture_time_ms(capture_time_ms);
ilnik2edc6842017-07-06 03:06:50 -0700534 const VideoSendTiming kVideoTiming = {0u, 0u, 0u, 0u, 0u, 0u, true};
ilnik04f4d122017-06-19 07:18:55 -0700535 packet->SetExtension<VideoTimingExtension>(kVideoTiming);
536 EXPECT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
537 size_t packet_size = packet->size();
ilnik04f4d122017-06-19 07:18:55 -0700538
539 const int kStoredTimeInMs = 100;
Erik Språng7b52f102018-02-07 14:37:37 +0100540 {
541 EXPECT_CALL(
542 mock_paced_sender_,
543 InsertPacket(RtpPacketSender::kNormalPriority, kSsrc, _, _, _, _));
544 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
545 kAllowRetransmission,
546 RtpPacketSender::kNormalPriority));
547 }
ilnik04f4d122017-06-19 07:18:55 -0700548 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
Erik Språng7b52f102018-02-07 14:37:37 +0100549 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum, capture_time_ms, false,
550 PacedPacketInfo());
ilnik04f4d122017-06-19 07:18:55 -0700551 EXPECT_EQ(1, transport_.packets_sent());
552 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
553
danilchapce251812017-09-11 12:24:41 -0700554 VideoSendTiming video_timing;
555 EXPECT_TRUE(transport_.last_sent_packet().GetExtension<VideoTimingExtension>(
556 &video_timing));
557 EXPECT_EQ(kStoredTimeInMs, video_timing.pacer_exit_delta_ms);
Erik Språng7b52f102018-02-07 14:37:37 +0100558}
ilnik04f4d122017-06-19 07:18:55 -0700559
Erik Språng7b52f102018-02-07 14:37:37 +0100560TEST_P(RtpSenderTest, WritesNetwork2ToTimingExtension) {
561 SetUpRtpSender(true, true);
562 rtp_sender_->SetStorePacketsStatus(true, 10);
563 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
564 kRtpExtensionVideoTiming, kVideoTimingExtensionId));
565 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
566 auto packet = rtp_sender_->AllocatePacket();
567 packet->SetPayloadType(kPayload);
568 packet->SetMarker(true);
569 packet->SetTimestamp(kTimestamp);
570 packet->set_capture_time_ms(capture_time_ms);
571 const uint16_t kPacerExitMs = 1234u;
572 const VideoSendTiming kVideoTiming = {0u, 0u, 0u, kPacerExitMs, 0u, 0u, true};
573 packet->SetExtension<VideoTimingExtension>(kVideoTiming);
574 EXPECT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
575 size_t packet_size = packet->size();
576
577 const int kStoredTimeInMs = 100;
578 {
579 EXPECT_CALL(
580 mock_paced_sender_,
581 InsertPacket(RtpPacketSender::kNormalPriority, kSsrc, _, _, _, _));
582 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
583 kAllowRetransmission,
584 RtpPacketSender::kNormalPriority));
585 }
ilnik04f4d122017-06-19 07:18:55 -0700586 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
587 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum, capture_time_ms, false,
588 PacedPacketInfo());
Erik Språng7b52f102018-02-07 14:37:37 +0100589 EXPECT_EQ(1, transport_.packets_sent());
ilnik04f4d122017-06-19 07:18:55 -0700590 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
591
Erik Språng7b52f102018-02-07 14:37:37 +0100592 VideoSendTiming video_timing;
danilchapce251812017-09-11 12:24:41 -0700593 EXPECT_TRUE(transport_.last_sent_packet().GetExtension<VideoTimingExtension>(
594 &video_timing));
Erik Språng7b52f102018-02-07 14:37:37 +0100595 EXPECT_EQ(kStoredTimeInMs, video_timing.network2_timestamp_delta_ms);
596 EXPECT_EQ(kPacerExitMs, video_timing.pacer_exit_delta_ms);
ilnik04f4d122017-06-19 07:18:55 -0700597}
598
minyue3a407ee2017-04-03 01:10:33 -0700599TEST_P(RtpSenderTest, TrafficSmoothingWithExtensions) {
Peter Boströme23e7372015-10-08 11:44:14 +0200600 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kNormalPriority,
brandtr9dfff292016-11-14 05:14:50 -0800601 kSsrc, kSeqNum, _, _, _));
Elad Alon4a87e1c2017-10-03 16:11:34 +0200602 EXPECT_CALL(mock_rtc_event_log_,
603 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)));
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000604
pwestin@webrtc.orgc66e8b32012-11-07 17:01:04 +0000605 rtp_sender_->SetStorePacketsStatus(true, 10);
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000606 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
danilchap162abd32015-12-10 02:39:40 -0800607 kRtpExtensionTransmissionTimeOffset,
608 kTransmissionTimeOffsetExtensionId));
609 EXPECT_EQ(
610 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
611 kAbsoluteSendTimeExtensionId));
stefan@webrtc.org8ccb9f92013-06-19 14:13:42 +0000612 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
danilchapb6f1fb52016-10-19 06:11:39 -0700613 auto packet =
614 BuildRtpPacket(kPayload, kMarkerBit, kTimestamp, capture_time_ms);
615 size_t packet_size = packet->size();
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000616
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000617 // Packet should be stored in a send bucket.
danilchapb6f1fb52016-10-19 06:11:39 -0700618 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
619 kAllowRetransmission,
Sergey Ulanov525df3f2016-08-02 17:46:41 -0700620 RtpPacketSender::kNormalPriority));
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000621
danilchap12ba1862016-10-26 02:41:55 -0700622 EXPECT_EQ(0, transport_.packets_sent());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000623
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000624 const int kStoredTimeInMs = 100;
stefan@webrtc.orga678a3b2013-01-21 07:42:11 +0000625 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000626
brandtr9dfff292016-11-14 05:14:50 -0800627 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum, capture_time_ms, false,
philipel8aadd502017-02-23 02:56:13 -0800628 PacedPacketInfo());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000629
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000630 // Process send bucket. Packet should now be sent.
danilchap12ba1862016-10-26 02:41:55 -0700631 EXPECT_EQ(1, transport_.packets_sent());
632 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
633
stefan@webrtc.orga5cb98c2013-05-29 12:12:51 +0000634 webrtc::RTPHeader rtp_header;
danilchap12ba1862016-10-26 02:41:55 -0700635 transport_.last_sent_packet().GetHeader(&rtp_header);
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000636
637 // Verify transmission time offset.
638 EXPECT_EQ(kStoredTimeInMs * 90, rtp_header.extension.transmissionTimeOffset);
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000639 uint64_t expected_send_time =
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000640 ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds());
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000641 EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime);
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000642}
643
minyue3a407ee2017-04-03 01:10:33 -0700644TEST_P(RtpSenderTest, TrafficSmoothingRetransmits) {
Peter Boströme23e7372015-10-08 11:44:14 +0200645 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kNormalPriority,
brandtr9dfff292016-11-14 05:14:50 -0800646 kSsrc, kSeqNum, _, _, _));
Elad Alon4a87e1c2017-10-03 16:11:34 +0200647 EXPECT_CALL(mock_rtc_event_log_,
648 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)));
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000649
650 rtp_sender_->SetStorePacketsStatus(true, 10);
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000651 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
danilchap162abd32015-12-10 02:39:40 -0800652 kRtpExtensionTransmissionTimeOffset,
653 kTransmissionTimeOffsetExtensionId));
654 EXPECT_EQ(
655 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
656 kAbsoluteSendTimeExtensionId));
stefan@webrtc.org8ccb9f92013-06-19 14:13:42 +0000657 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
danilchapb6f1fb52016-10-19 06:11:39 -0700658 auto packet =
659 BuildRtpPacket(kPayload, kMarkerBit, kTimestamp, capture_time_ms);
660 size_t packet_size = packet->size();
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000661
662 // Packet should be stored in a send bucket.
danilchapb6f1fb52016-10-19 06:11:39 -0700663 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
664 kAllowRetransmission,
Sergey Ulanov525df3f2016-08-02 17:46:41 -0700665 RtpPacketSender::kNormalPriority));
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000666
danilchap12ba1862016-10-26 02:41:55 -0700667 EXPECT_EQ(0, transport_.packets_sent());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000668
terelius5d332ac2016-01-14 14:37:39 -0800669 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kNormalPriority,
brandtr9dfff292016-11-14 05:14:50 -0800670 kSsrc, kSeqNum, _, _, _));
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000671
672 const int kStoredTimeInMs = 100;
673 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
674
danilchapb6f1fb52016-10-19 06:11:39 -0700675 EXPECT_EQ(static_cast<int>(packet_size), rtp_sender_->ReSendPacket(kSeqNum));
danilchap12ba1862016-10-26 02:41:55 -0700676 EXPECT_EQ(0, transport_.packets_sent());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000677
brandtr9dfff292016-11-14 05:14:50 -0800678 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum, capture_time_ms, false,
philipel8aadd502017-02-23 02:56:13 -0800679 PacedPacketInfo());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000680
681 // Process send bucket. Packet should now be sent.
danilchap12ba1862016-10-26 02:41:55 -0700682 EXPECT_EQ(1, transport_.packets_sent());
683 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000684
stefan@webrtc.orga5cb98c2013-05-29 12:12:51 +0000685 webrtc::RTPHeader rtp_header;
danilchap12ba1862016-10-26 02:41:55 -0700686 transport_.last_sent_packet().GetHeader(&rtp_header);
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000687
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000688 // Verify transmission time offset.
689 EXPECT_EQ(kStoredTimeInMs * 90, rtp_header.extension.transmissionTimeOffset);
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000690 uint64_t expected_send_time =
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000691 ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds());
692 EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime);
693}
694
695// This test sends 1 regular video packet, then 4 padding packets, and then
696// 1 more regular packet.
minyue3a407ee2017-04-03 01:10:33 -0700697TEST_P(RtpSenderTest, SendPadding) {
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000698 // Make all (non-padding) packets go to send queue.
terelius5d332ac2016-01-14 14:37:39 -0800699 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kNormalPriority,
brandtr9dfff292016-11-14 05:14:50 -0800700 kSsrc, kSeqNum, _, _, _));
Elad Alon4a87e1c2017-10-03 16:11:34 +0200701 EXPECT_CALL(mock_rtc_event_log_,
702 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
703 .Times(1 + 4 + 1);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000704
705 uint16_t seq_num = kSeqNum;
706 uint32_t timestamp = kTimestamp;
707 rtp_sender_->SetStorePacketsStatus(true, 10);
pkasting@chromium.org4591fbd2014-11-20 22:28:14 +0000708 size_t rtp_header_len = kRtpHeaderSize;
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000709 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
danilchap162abd32015-12-10 02:39:40 -0800710 kRtpExtensionTransmissionTimeOffset,
711 kTransmissionTimeOffsetExtensionId));
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000712 rtp_header_len += 4; // 4 bytes extension.
danilchap162abd32015-12-10 02:39:40 -0800713 EXPECT_EQ(
714 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
715 kAbsoluteSendTimeExtensionId));
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000716 rtp_header_len += 4; // 4 bytes extension.
717 rtp_header_len += 4; // 4 extra bytes common to all extension headers.
718
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000719 webrtc::RTPHeader rtp_header;
720
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000721 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
danilchapb6f1fb52016-10-19 06:11:39 -0700722 auto packet =
723 BuildRtpPacket(kPayload, kMarkerBit, timestamp, capture_time_ms);
Stefan Holmer586b19b2015-09-18 11:14:31 +0200724 const uint32_t media_packet_timestamp = timestamp;
danilchapb6f1fb52016-10-19 06:11:39 -0700725 size_t packet_size = packet->size();
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000726
727 // Packet should be stored in a send bucket.
danilchapb6f1fb52016-10-19 06:11:39 -0700728 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
729 kAllowRetransmission,
Sergey Ulanov525df3f2016-08-02 17:46:41 -0700730 RtpPacketSender::kNormalPriority));
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000731
732 int total_packets_sent = 0;
danilchap12ba1862016-10-26 02:41:55 -0700733 EXPECT_EQ(total_packets_sent, transport_.packets_sent());
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000734
735 const int kStoredTimeInMs = 100;
736 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
brandtr9dfff292016-11-14 05:14:50 -0800737 rtp_sender_->TimeToSendPacket(kSsrc, seq_num++, capture_time_ms, false,
philipel8aadd502017-02-23 02:56:13 -0800738 PacedPacketInfo());
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000739 // Packet should now be sent. This test doesn't verify the regular video
740 // packet, since it is tested in another test.
danilchap12ba1862016-10-26 02:41:55 -0700741 EXPECT_EQ(++total_packets_sent, transport_.packets_sent());
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000742 timestamp += 90 * kStoredTimeInMs;
743
744 // Send padding 4 times, waiting 50 ms between each.
745 for (int i = 0; i < 4; ++i) {
746 const int kPaddingPeriodMs = 50;
pkasting@chromium.org4591fbd2014-11-20 22:28:14 +0000747 const size_t kPaddingBytes = 100;
748 const size_t kMaxPaddingLength = 224; // Value taken from rtp_sender.cc.
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000749 // Padding will be forced to full packets.
philipelc7bf32a2017-02-17 03:59:43 -0800750 EXPECT_EQ(kMaxPaddingLength,
philipel8aadd502017-02-23 02:56:13 -0800751 rtp_sender_->TimeToSendPadding(kPaddingBytes, PacedPacketInfo()));
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000752
753 // Process send bucket. Padding should now be sent.
danilchap12ba1862016-10-26 02:41:55 -0700754 EXPECT_EQ(++total_packets_sent, transport_.packets_sent());
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000755 EXPECT_EQ(kMaxPaddingLength + rtp_header_len,
danilchap12ba1862016-10-26 02:41:55 -0700756 transport_.last_sent_packet().size());
757
758 transport_.last_sent_packet().GetHeader(&rtp_header);
pbosbd2522a2015-07-01 05:35:53 -0700759 EXPECT_EQ(kMaxPaddingLength, rtp_header.paddingLength);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000760
Stefan Holmer586b19b2015-09-18 11:14:31 +0200761 // Verify sequence number and timestamp. The timestamp should be the same
762 // as the last media packet.
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000763 EXPECT_EQ(seq_num++, rtp_header.sequenceNumber);
Stefan Holmer586b19b2015-09-18 11:14:31 +0200764 EXPECT_EQ(media_packet_timestamp, rtp_header.timestamp);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000765 // Verify transmission time offset.
Stefan Holmer586b19b2015-09-18 11:14:31 +0200766 int offset = timestamp - media_packet_timestamp;
767 EXPECT_EQ(offset, rtp_header.extension.transmissionTimeOffset);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000768 uint64_t expected_send_time =
769 ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds());
770 EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime);
771 fake_clock_.AdvanceTimeMilliseconds(kPaddingPeriodMs);
772 timestamp += 90 * kPaddingPeriodMs;
773 }
774
775 // Send a regular video packet again.
776 capture_time_ms = fake_clock_.TimeInMilliseconds();
danilchapb6f1fb52016-10-19 06:11:39 -0700777 packet = BuildRtpPacket(kPayload, kMarkerBit, timestamp, capture_time_ms);
778 packet_size = packet->size();
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000779
brandtr9dfff292016-11-14 05:14:50 -0800780 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kNormalPriority,
781 kSsrc, seq_num, _, _, _));
terelius5d332ac2016-01-14 14:37:39 -0800782
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000783 // Packet should be stored in a send bucket.
danilchapb6f1fb52016-10-19 06:11:39 -0700784 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
785 kAllowRetransmission,
Sergey Ulanov525df3f2016-08-02 17:46:41 -0700786 RtpPacketSender::kNormalPriority));
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000787
brandtr9dfff292016-11-14 05:14:50 -0800788 rtp_sender_->TimeToSendPacket(kSsrc, seq_num, capture_time_ms, false,
philipel8aadd502017-02-23 02:56:13 -0800789 PacedPacketInfo());
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000790 // Process send bucket.
danilchap12ba1862016-10-26 02:41:55 -0700791 EXPECT_EQ(++total_packets_sent, transport_.packets_sent());
792 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
793 transport_.last_sent_packet().GetHeader(&rtp_header);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000794
795 // Verify sequence number and timestamp.
796 EXPECT_EQ(seq_num, rtp_header.sequenceNumber);
797 EXPECT_EQ(timestamp, rtp_header.timestamp);
798 // Verify transmission time offset. This packet is sent without delay.
799 EXPECT_EQ(0, rtp_header.extension.transmissionTimeOffset);
800 uint64_t expected_send_time =
801 ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds());
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000802 EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime);
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000803}
pbos@webrtc.org8911ce42013-03-18 16:39:03 +0000804
minyue3a407ee2017-04-03 01:10:33 -0700805TEST_P(RtpSenderTest, OnSendPacketUpdated) {
stefana23fc622016-07-28 07:56:38 -0700806 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
807 kRtpExtensionTransportSequenceNumber,
808 kTransportSequenceNumberExtensionId));
asapersson35151f32016-05-02 23:44:01 -0700809 rtp_sender_->SetStorePacketsStatus(true, 10);
810
811 EXPECT_CALL(send_packet_observer_,
812 OnSendPacket(kTransportSequenceNumber, _, _))
813 .Times(1);
814 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
815 .WillOnce(testing::Return(kTransportSequenceNumber));
brandtr9dfff292016-11-14 05:14:50 -0800816 EXPECT_CALL(mock_paced_sender_, InsertPacket(_, kSsrc, kSeqNum, _, _, _))
817 .Times(1);
asapersson35151f32016-05-02 23:44:01 -0700818
819 SendGenericPayload(); // Packet passed to pacer.
820 const bool kIsRetransmit = false;
brandtr9dfff292016-11-14 05:14:50 -0800821 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum,
822 fake_clock_.TimeInMilliseconds(), kIsRetransmit,
philipel8aadd502017-02-23 02:56:13 -0800823 PacedPacketInfo());
danilchap12ba1862016-10-26 02:41:55 -0700824 EXPECT_EQ(1, transport_.packets_sent());
asapersson35151f32016-05-02 23:44:01 -0700825}
826
minyue3a407ee2017-04-03 01:10:33 -0700827TEST_P(RtpSenderTest, OnSendPacketNotUpdatedForRetransmits) {
stefana23fc622016-07-28 07:56:38 -0700828 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
829 kRtpExtensionTransportSequenceNumber,
830 kTransportSequenceNumberExtensionId));
asapersson35151f32016-05-02 23:44:01 -0700831 rtp_sender_->SetStorePacketsStatus(true, 10);
832
833 EXPECT_CALL(send_packet_observer_, OnSendPacket(_, _, _)).Times(0);
834 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
835 .WillOnce(testing::Return(kTransportSequenceNumber));
brandtr9dfff292016-11-14 05:14:50 -0800836 EXPECT_CALL(mock_paced_sender_, InsertPacket(_, kSsrc, kSeqNum, _, _, _))
837 .Times(1);
asapersson35151f32016-05-02 23:44:01 -0700838
839 SendGenericPayload(); // Packet passed to pacer.
840 const bool kIsRetransmit = true;
brandtr9dfff292016-11-14 05:14:50 -0800841 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum,
842 fake_clock_.TimeInMilliseconds(), kIsRetransmit,
philipel8aadd502017-02-23 02:56:13 -0800843 PacedPacketInfo());
danilchap12ba1862016-10-26 02:41:55 -0700844 EXPECT_EQ(1, transport_.packets_sent());
asapersson35151f32016-05-02 23:44:01 -0700845}
846
minyue3a407ee2017-04-03 01:10:33 -0700847TEST_P(RtpSenderTest, OnSendPacketNotUpdatedWithoutSeqNumAllocator) {
asapersson35151f32016-05-02 23:44:01 -0700848 rtp_sender_.reset(new RTPSender(
brandtrdbdb3f12016-11-10 05:04:48 -0800849 false, &fake_clock_, &transport_, &mock_paced_sender_, nullptr,
asapersson35151f32016-05-02 23:44:01 -0700850 nullptr /* TransportSequenceNumberAllocator */, nullptr, nullptr, nullptr,
michaelt4da30442016-11-17 01:38:43 -0800851 nullptr, nullptr, &send_packet_observer_, &retransmission_rate_limiter_,
Erik Språng7b52f102018-02-07 14:37:37 +0100852 nullptr, false));
brandtr9dfff292016-11-14 05:14:50 -0800853 rtp_sender_->SetSequenceNumber(kSeqNum);
854 rtp_sender_->SetSSRC(kSsrc);
stefana23fc622016-07-28 07:56:38 -0700855 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
856 kRtpExtensionTransportSequenceNumber,
857 kTransportSequenceNumberExtensionId));
asapersson35151f32016-05-02 23:44:01 -0700858 rtp_sender_->SetSequenceNumber(kSeqNum);
859 rtp_sender_->SetStorePacketsStatus(true, 10);
860
861 EXPECT_CALL(send_packet_observer_, OnSendPacket(_, _, _)).Times(0);
brandtr9dfff292016-11-14 05:14:50 -0800862 EXPECT_CALL(mock_paced_sender_, InsertPacket(_, kSsrc, kSeqNum, _, _, _))
863 .Times(1);
asapersson35151f32016-05-02 23:44:01 -0700864
865 SendGenericPayload(); // Packet passed to pacer.
866 const bool kIsRetransmit = false;
brandtr9dfff292016-11-14 05:14:50 -0800867 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum,
868 fake_clock_.TimeInMilliseconds(), kIsRetransmit,
philipel8aadd502017-02-23 02:56:13 -0800869 PacedPacketInfo());
danilchap12ba1862016-10-26 02:41:55 -0700870 EXPECT_EQ(1, transport_.packets_sent());
asapersson35151f32016-05-02 23:44:01 -0700871}
872
minyue3a407ee2017-04-03 01:10:33 -0700873TEST_P(RtpSenderTest, SendRedundantPayloads) {
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000874 MockTransport transport;
terelius429c3452016-01-21 05:42:04 -0800875 rtp_sender_.reset(new RTPSender(
asapersson35151f32016-05-02 23:44:01 -0700876 false, &fake_clock_, &transport, &mock_paced_sender_, nullptr, nullptr,
brandtrdbdb3f12016-11-10 05:04:48 -0800877 nullptr, nullptr, nullptr, nullptr, &mock_rtc_event_log_, nullptr,
Erik Språng7b52f102018-02-07 14:37:37 +0100878 &retransmission_rate_limiter_, nullptr, false));
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000879 rtp_sender_->SetSequenceNumber(kSeqNum);
brandtr9dfff292016-11-14 05:14:50 -0800880 rtp_sender_->SetSSRC(kSsrc);
Shao Changbine62202f2015-04-21 20:24:50 +0800881 rtp_sender_->SetRtxPayloadType(kRtxPayload, kPayload);
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000882
883 uint16_t seq_num = kSeqNum;
884 rtp_sender_->SetStorePacketsStatus(true, 10);
wu@webrtc.orgebdb0e32014-03-06 23:49:08 +0000885 int32_t rtp_header_len = kRtpHeaderSize;
danilchap162abd32015-12-10 02:39:40 -0800886 EXPECT_EQ(
887 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
888 kAbsoluteSendTimeExtensionId));
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000889 rtp_header_len += 4; // 4 bytes extension.
890 rtp_header_len += 4; // 4 extra bytes common to all extension headers.
891
pbos@webrtc.org0b0c2412015-01-13 14:15:15 +0000892 rtp_sender_->SetRtxStatus(kRtxRetransmitted | kRtxRedundantPayloads);
stefan@webrtc.orgef927552014-06-05 08:25:29 +0000893 rtp_sender_->SetRtxSsrc(1234);
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000894
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000895 const size_t kNumPayloadSizes = 10;
danilchap162abd32015-12-10 02:39:40 -0800896 const size_t kPayloadSizes[kNumPayloadSizes] = {500, 550, 600, 650, 700,
897 750, 800, 850, 900, 950};
terelius5d332ac2016-01-14 14:37:39 -0800898 // Expect all packets go through the pacer.
899 EXPECT_CALL(mock_paced_sender_,
brandtr9dfff292016-11-14 05:14:50 -0800900 InsertPacket(RtpPacketSender::kNormalPriority, kSsrc, _, _, _, _))
terelius5d332ac2016-01-14 14:37:39 -0800901 .Times(kNumPayloadSizes);
Elad Alon4a87e1c2017-10-03 16:11:34 +0200902 EXPECT_CALL(mock_rtc_event_log_,
903 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
terelius429c3452016-01-21 05:42:04 -0800904 .Times(kNumPayloadSizes);
905
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000906 // Send 10 packets of increasing size.
907 for (size_t i = 0; i < kNumPayloadSizes; ++i) {
908 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
stefan1d8a5062015-10-02 03:39:33 -0700909 EXPECT_CALL(transport, SendRtp(_, _, _)).WillOnce(testing::Return(true));
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000910 SendPacket(capture_time_ms, kPayloadSizes[i]);
brandtr9dfff292016-11-14 05:14:50 -0800911 rtp_sender_->TimeToSendPacket(kSsrc, seq_num++, capture_time_ms, false,
philipel8aadd502017-02-23 02:56:13 -0800912 PacedPacketInfo());
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000913 fake_clock_.AdvanceTimeMilliseconds(33);
914 }
terelius429c3452016-01-21 05:42:04 -0800915
Elad Alon4a87e1c2017-10-03 16:11:34 +0200916 EXPECT_CALL(mock_rtc_event_log_,
917 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
terelius429c3452016-01-21 05:42:04 -0800918 .Times(::testing::AtLeast(4));
919
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000920 // The amount of padding to send it too small to send a payload packet.
stefan1d8a5062015-10-02 03:39:33 -0700921 EXPECT_CALL(transport, SendRtp(_, kMaxPaddingSize + rtp_header_len, _))
pbos2d566682015-09-28 09:59:31 -0700922 .WillOnce(testing::Return(true));
philipela1ed0b32016-06-01 06:31:17 -0700923 EXPECT_EQ(kMaxPaddingSize,
philipel8aadd502017-02-23 02:56:13 -0800924 rtp_sender_->TimeToSendPadding(49, PacedPacketInfo()));
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000925
Peter Boströmac547a62015-09-17 23:03:57 +0200926 EXPECT_CALL(transport,
stefan1d8a5062015-10-02 03:39:33 -0700927 SendRtp(_, kPayloadSizes[0] + rtp_header_len + kRtxHeaderSize, _))
pbos2d566682015-09-28 09:59:31 -0700928 .WillOnce(testing::Return(true));
philipela1ed0b32016-06-01 06:31:17 -0700929 EXPECT_EQ(kPayloadSizes[0],
philipel8aadd502017-02-23 02:56:13 -0800930 rtp_sender_->TimeToSendPadding(500, PacedPacketInfo()));
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000931
pbos2d566682015-09-28 09:59:31 -0700932 EXPECT_CALL(transport, SendRtp(_, kPayloadSizes[kNumPayloadSizes - 1] +
stefan1d8a5062015-10-02 03:39:33 -0700933 rtp_header_len + kRtxHeaderSize,
934 _))
pbos2d566682015-09-28 09:59:31 -0700935 .WillOnce(testing::Return(true));
stefan1d8a5062015-10-02 03:39:33 -0700936 EXPECT_CALL(transport, SendRtp(_, kMaxPaddingSize + rtp_header_len, _))
pbos2d566682015-09-28 09:59:31 -0700937 .WillOnce(testing::Return(true));
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +0000938 EXPECT_EQ(kPayloadSizes[kNumPayloadSizes - 1] + kMaxPaddingSize,
philipel8aadd502017-02-23 02:56:13 -0800939 rtp_sender_->TimeToSendPadding(999, PacedPacketInfo()));
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000940}
941
minyue3a407ee2017-04-03 01:10:33 -0700942TEST_P(RtpSenderTestWithoutPacer, SendGenericVideo) {
pbos@webrtc.org8911ce42013-03-18 16:39:03 +0000943 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
944 const uint8_t payload_type = 127;
945 ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 90000,
946 0, 1500));
947 uint8_t payload[] = {47, 11, 32, 93, 89};
948
949 // Send keyframe
spranga8ae6f22017-09-04 07:23:56 -0700950 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
951 kVideoFrameKey, payload_type, 1234, 4321, payload, sizeof(payload),
952 nullptr, nullptr, nullptr, kDefaultExpectedRetransmissionTimeMs));
pbos@webrtc.org8911ce42013-03-18 16:39:03 +0000953
danilchap96c15872016-11-21 01:35:29 -0800954 auto sent_payload = transport_.last_sent_packet().payload();
955 uint8_t generic_header = sent_payload[0];
pbos@webrtc.org8911ce42013-03-18 16:39:03 +0000956 EXPECT_TRUE(generic_header & RtpFormatVideoGeneric::kKeyFrameBit);
957 EXPECT_TRUE(generic_header & RtpFormatVideoGeneric::kFirstPacketBit);
danilchap96c15872016-11-21 01:35:29 -0800958 EXPECT_THAT(sent_payload.subview(1), ElementsAreArray(payload));
pbos@webrtc.org8911ce42013-03-18 16:39:03 +0000959
960 // Send delta frame
961 payload[0] = 13;
962 payload[1] = 42;
963 payload[4] = 13;
964
Sergey Ulanov525df3f2016-08-02 17:46:41 -0700965 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
966 kVideoFrameDelta, payload_type, 1234, 4321, payload, sizeof(payload),
spranga8ae6f22017-09-04 07:23:56 -0700967 nullptr, nullptr, nullptr, kDefaultExpectedRetransmissionTimeMs));
pbos@webrtc.org8911ce42013-03-18 16:39:03 +0000968
danilchap96c15872016-11-21 01:35:29 -0800969 sent_payload = transport_.last_sent_packet().payload();
970 generic_header = sent_payload[0];
pbos@webrtc.org8911ce42013-03-18 16:39:03 +0000971 EXPECT_FALSE(generic_header & RtpFormatVideoGeneric::kKeyFrameBit);
972 EXPECT_TRUE(generic_header & RtpFormatVideoGeneric::kFirstPacketBit);
danilchap96c15872016-11-21 01:35:29 -0800973 EXPECT_THAT(sent_payload.subview(1), ElementsAreArray(payload));
pbos@webrtc.org8911ce42013-03-18 16:39:03 +0000974}
975
minyue3a407ee2017-04-03 01:10:33 -0700976TEST_P(RtpSenderTest, SendFlexfecPackets) {
brandtrdbdb3f12016-11-10 05:04:48 -0800977 constexpr int kMediaPayloadType = 127;
978 constexpr int kFlexfecPayloadType = 118;
979 constexpr uint32_t kMediaSsrc = 1234;
980 constexpr uint32_t kFlexfecSsrc = 5678;
981 const std::vector<RtpExtension> kNoRtpExtensions;
erikvarga27883732017-05-17 05:08:38 -0700982 const std::vector<RtpExtensionSize> kNoRtpExtensionSizes;
brandtrdbdb3f12016-11-10 05:04:48 -0800983 FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexfecSsrc, kMediaSsrc,
erikvarga27883732017-05-17 05:08:38 -0700984 kNoRtpExtensions, kNoRtpExtensionSizes,
brandtr48d21a22017-05-30 02:32:12 -0700985 nullptr /* rtp_state */, &fake_clock_);
brandtrdbdb3f12016-11-10 05:04:48 -0800986
987 // Reset |rtp_sender_| to use FlexFEC.
michaelt4da30442016-11-17 01:38:43 -0800988 rtp_sender_.reset(new RTPSender(
989 false, &fake_clock_, &transport_, &mock_paced_sender_, &flexfec_sender,
990 &seq_num_allocator_, nullptr, nullptr, nullptr, nullptr,
991 &mock_rtc_event_log_, &send_packet_observer_,
Erik Språng7b52f102018-02-07 14:37:37 +0100992 &retransmission_rate_limiter_, nullptr, false));
brandtrdbdb3f12016-11-10 05:04:48 -0800993 rtp_sender_->SetSSRC(kMediaSsrc);
994 rtp_sender_->SetSequenceNumber(kSeqNum);
brandtrdbdb3f12016-11-10 05:04:48 -0800995 rtp_sender_->SetStorePacketsStatus(true, 10);
996
997 // Parameters selected to generate a single FEC packet per media packet.
998 FecProtectionParams params;
999 params.fec_rate = 15;
1000 params.max_fec_frames = 1;
1001 params.fec_mask_type = kFecMaskRandom;
1002 rtp_sender_->SetFecParameters(params, params);
1003
brandtr9dfff292016-11-14 05:14:50 -08001004 EXPECT_CALL(mock_paced_sender_,
1005 InsertPacket(RtpPacketSender::kLowPriority, kMediaSsrc, kSeqNum,
1006 _, _, false));
1007 uint16_t flexfec_seq_num;
brandtrdbdb3f12016-11-10 05:04:48 -08001008 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kLowPriority,
brandtr9dfff292016-11-14 05:14:50 -08001009 kFlexfecSsrc, _, _, _, false))
1010 .WillOnce(testing::SaveArg<2>(&flexfec_seq_num));
brandtrdbdb3f12016-11-10 05:04:48 -08001011 SendGenericPayload();
Elad Alon4a87e1c2017-10-03 16:11:34 +02001012 EXPECT_CALL(mock_rtc_event_log_,
1013 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
1014 .Times(2);
philipel8aadd502017-02-23 02:56:13 -08001015 EXPECT_TRUE(rtp_sender_->TimeToSendPacket(kMediaSsrc, kSeqNum,
1016 fake_clock_.TimeInMilliseconds(),
1017 false, PacedPacketInfo()));
brandtr9dfff292016-11-14 05:14:50 -08001018 EXPECT_TRUE(rtp_sender_->TimeToSendPacket(kFlexfecSsrc, flexfec_seq_num,
1019 fake_clock_.TimeInMilliseconds(),
philipel8aadd502017-02-23 02:56:13 -08001020 false, PacedPacketInfo()));
brandtr9dfff292016-11-14 05:14:50 -08001021 ASSERT_EQ(2, transport_.packets_sent());
brandtrdbdb3f12016-11-10 05:04:48 -08001022 const RtpPacketReceived& media_packet = transport_.sent_packets_[0];
1023 EXPECT_EQ(kMediaPayloadType, media_packet.PayloadType());
brandtr9dfff292016-11-14 05:14:50 -08001024 EXPECT_EQ(kSeqNum, media_packet.SequenceNumber());
brandtrdbdb3f12016-11-10 05:04:48 -08001025 EXPECT_EQ(kMediaSsrc, media_packet.Ssrc());
brandtr9dfff292016-11-14 05:14:50 -08001026 const RtpPacketReceived& flexfec_packet = transport_.sent_packets_[1];
1027 EXPECT_EQ(kFlexfecPayloadType, flexfec_packet.PayloadType());
1028 EXPECT_EQ(flexfec_seq_num, flexfec_packet.SequenceNumber());
1029 EXPECT_EQ(kFlexfecSsrc, flexfec_packet.Ssrc());
brandtrdbdb3f12016-11-10 05:04:48 -08001030}
1031
ilnik10894992017-06-21 08:23:19 -07001032// TODO(ilnik): because of webrtc:7859. Once FEC moved below pacer, this test
1033// should be removed.
1034TEST_P(RtpSenderTest, NoFlexfecForTimingFrames) {
1035 constexpr int kMediaPayloadType = 127;
1036 constexpr int kFlexfecPayloadType = 118;
1037 constexpr uint32_t kMediaSsrc = 1234;
1038 constexpr uint32_t kFlexfecSsrc = 5678;
1039 const std::vector<RtpExtension> kNoRtpExtensions;
1040 const std::vector<RtpExtensionSize> kNoRtpExtensionSizes;
ilnike4350192017-06-29 02:27:44 -07001041
ilnik10894992017-06-21 08:23:19 -07001042 FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexfecSsrc, kMediaSsrc,
1043 kNoRtpExtensions, kNoRtpExtensionSizes,
1044 nullptr /* rtp_state */, &fake_clock_);
1045
1046 // Reset |rtp_sender_| to use FlexFEC.
1047 rtp_sender_.reset(new RTPSender(
1048 false, &fake_clock_, &transport_, &mock_paced_sender_, &flexfec_sender,
1049 &seq_num_allocator_, nullptr, nullptr, nullptr, nullptr,
1050 &mock_rtc_event_log_, &send_packet_observer_,
Erik Språng7b52f102018-02-07 14:37:37 +01001051 &retransmission_rate_limiter_, nullptr, false));
ilnik10894992017-06-21 08:23:19 -07001052 rtp_sender_->SetSSRC(kMediaSsrc);
1053 rtp_sender_->SetSequenceNumber(kSeqNum);
ilnik10894992017-06-21 08:23:19 -07001054 rtp_sender_->SetStorePacketsStatus(true, 10);
1055
ilnike4350192017-06-29 02:27:44 -07001056 // Need extension to be registered for timing frames to be sent.
1057 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
1058 kRtpExtensionVideoTiming, kVideoTimingExtensionId));
1059
ilnik10894992017-06-21 08:23:19 -07001060 // Parameters selected to generate a single FEC packet per media packet.
1061 FecProtectionParams params;
1062 params.fec_rate = 15;
1063 params.max_fec_frames = 1;
1064 params.fec_mask_type = kFecMaskRandom;
1065 rtp_sender_->SetFecParameters(params, params);
1066
1067 EXPECT_CALL(mock_paced_sender_,
1068 InsertPacket(RtpPacketSender::kLowPriority, kMediaSsrc, kSeqNum,
1069 _, _, false));
1070 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kLowPriority,
1071 kFlexfecSsrc, _, _, _, false))
1072 .Times(0); // Not called because packet should not be protected.
1073
1074 const uint32_t kTimestamp = 1234;
1075 const uint8_t kPayloadType = 127;
1076 const int64_t kCaptureTimeMs = fake_clock_.TimeInMilliseconds();
1077 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
1078 EXPECT_EQ(0, rtp_sender_->RegisterPayload(payload_name, kPayloadType, 90000,
1079 0, 1500));
1080 RTPVideoHeader video_header;
1081 memset(&video_header, 0, sizeof(RTPVideoHeader));
sprangba050a62017-08-18 02:51:12 -07001082 video_header.video_timing.flags = TimingFrameFlags::kTriggeredByTimer;
ilnik10894992017-06-21 08:23:19 -07001083 EXPECT_TRUE(rtp_sender_->SendOutgoingData(
1084 kVideoFrameKey, kPayloadType, kTimestamp, kCaptureTimeMs, kPayloadData,
spranga8ae6f22017-09-04 07:23:56 -07001085 sizeof(kPayloadData), nullptr, &video_header, nullptr,
1086 kDefaultExpectedRetransmissionTimeMs));
ilnik10894992017-06-21 08:23:19 -07001087
Elad Alon4a87e1c2017-10-03 16:11:34 +02001088 EXPECT_CALL(mock_rtc_event_log_,
1089 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
1090 .Times(1);
ilnik10894992017-06-21 08:23:19 -07001091 EXPECT_TRUE(rtp_sender_->TimeToSendPacket(kMediaSsrc, kSeqNum,
1092 fake_clock_.TimeInMilliseconds(),
1093 false, PacedPacketInfo()));
1094 ASSERT_EQ(1, transport_.packets_sent());
1095 const RtpPacketReceived& media_packet = transport_.sent_packets_[0];
1096 EXPECT_EQ(kMediaPayloadType, media_packet.PayloadType());
1097 EXPECT_EQ(kSeqNum, media_packet.SequenceNumber());
1098 EXPECT_EQ(kMediaSsrc, media_packet.Ssrc());
1099
1100 // Now try to send not a timing frame.
1101 uint16_t flexfec_seq_num;
1102 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kLowPriority,
1103 kFlexfecSsrc, _, _, _, false))
1104 .WillOnce(testing::SaveArg<2>(&flexfec_seq_num));
1105 EXPECT_CALL(mock_paced_sender_,
1106 InsertPacket(RtpPacketSender::kLowPriority, kMediaSsrc,
1107 kSeqNum + 1, _, _, false));
sprangba050a62017-08-18 02:51:12 -07001108 video_header.video_timing.flags = TimingFrameFlags::kInvalid;
ilnik10894992017-06-21 08:23:19 -07001109 EXPECT_TRUE(rtp_sender_->SendOutgoingData(
1110 kVideoFrameKey, kPayloadType, kTimestamp + 1, kCaptureTimeMs + 1,
spranga8ae6f22017-09-04 07:23:56 -07001111 kPayloadData, sizeof(kPayloadData), nullptr, &video_header, nullptr,
1112 kDefaultExpectedRetransmissionTimeMs));
ilnik10894992017-06-21 08:23:19 -07001113
Elad Alon4a87e1c2017-10-03 16:11:34 +02001114 EXPECT_CALL(mock_rtc_event_log_,
1115 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
1116 .Times(2);
ilnik10894992017-06-21 08:23:19 -07001117 EXPECT_TRUE(rtp_sender_->TimeToSendPacket(kMediaSsrc, kSeqNum + 1,
1118 fake_clock_.TimeInMilliseconds(),
1119 false, PacedPacketInfo()));
1120 EXPECT_TRUE(rtp_sender_->TimeToSendPacket(kFlexfecSsrc, flexfec_seq_num,
1121 fake_clock_.TimeInMilliseconds(),
1122 false, PacedPacketInfo()));
1123 ASSERT_EQ(3, transport_.packets_sent());
1124 const RtpPacketReceived& media_packet2 = transport_.sent_packets_[1];
1125 EXPECT_EQ(kMediaPayloadType, media_packet2.PayloadType());
1126 EXPECT_EQ(kSeqNum + 1, media_packet2.SequenceNumber());
1127 EXPECT_EQ(kMediaSsrc, media_packet2.Ssrc());
1128 const RtpPacketReceived& flexfec_packet = transport_.sent_packets_[2];
1129 EXPECT_EQ(kFlexfecPayloadType, flexfec_packet.PayloadType());
1130 EXPECT_EQ(flexfec_seq_num, flexfec_packet.SequenceNumber());
1131 EXPECT_EQ(kFlexfecSsrc, flexfec_packet.Ssrc());
1132}
1133
minyue3a407ee2017-04-03 01:10:33 -07001134TEST_P(RtpSenderTestWithoutPacer, SendFlexfecPackets) {
brandtrdbdb3f12016-11-10 05:04:48 -08001135 constexpr int kMediaPayloadType = 127;
1136 constexpr int kFlexfecPayloadType = 118;
1137 constexpr uint32_t kMediaSsrc = 1234;
1138 constexpr uint32_t kFlexfecSsrc = 5678;
1139 const std::vector<RtpExtension> kNoRtpExtensions;
erikvarga27883732017-05-17 05:08:38 -07001140 const std::vector<RtpExtensionSize> kNoRtpExtensionSizes;
brandtrdbdb3f12016-11-10 05:04:48 -08001141 FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexfecSsrc, kMediaSsrc,
erikvarga27883732017-05-17 05:08:38 -07001142 kNoRtpExtensions, kNoRtpExtensionSizes,
brandtr48d21a22017-05-30 02:32:12 -07001143 nullptr /* rtp_state */, &fake_clock_);
brandtrdbdb3f12016-11-10 05:04:48 -08001144
1145 // Reset |rtp_sender_| to use FlexFEC.
Erik Språng7b52f102018-02-07 14:37:37 +01001146 rtp_sender_.reset(
1147 new RTPSender(false, &fake_clock_, &transport_, nullptr, &flexfec_sender,
1148 &seq_num_allocator_, nullptr, nullptr, nullptr, nullptr,
1149 &mock_rtc_event_log_, &send_packet_observer_,
1150 &retransmission_rate_limiter_, nullptr, false));
brandtrdbdb3f12016-11-10 05:04:48 -08001151 rtp_sender_->SetSSRC(kMediaSsrc);
1152 rtp_sender_->SetSequenceNumber(kSeqNum);
brandtrdbdb3f12016-11-10 05:04:48 -08001153
1154 // Parameters selected to generate a single FEC packet per media packet.
1155 FecProtectionParams params;
1156 params.fec_rate = 15;
1157 params.max_fec_frames = 1;
1158 params.fec_mask_type = kFecMaskRandom;
1159 rtp_sender_->SetFecParameters(params, params);
1160
Elad Alon4a87e1c2017-10-03 16:11:34 +02001161 EXPECT_CALL(mock_rtc_event_log_,
1162 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
1163 .Times(2);
brandtrdbdb3f12016-11-10 05:04:48 -08001164 SendGenericPayload();
1165 ASSERT_EQ(2, transport_.packets_sent());
1166 const RtpPacketReceived& media_packet = transport_.sent_packets_[0];
1167 EXPECT_EQ(kMediaPayloadType, media_packet.PayloadType());
1168 EXPECT_EQ(kMediaSsrc, media_packet.Ssrc());
1169 const RtpPacketReceived& flexfec_packet = transport_.sent_packets_[1];
1170 EXPECT_EQ(kFlexfecPayloadType, flexfec_packet.PayloadType());
1171 EXPECT_EQ(kFlexfecSsrc, flexfec_packet.Ssrc());
1172}
1173
minyue3a407ee2017-04-03 01:10:33 -07001174TEST_P(RtpSenderTest, FecOverheadRate) {
brandtr81eab612017-01-24 04:06:09 -08001175 constexpr int kFlexfecPayloadType = 118;
1176 constexpr uint32_t kMediaSsrc = 1234;
1177 constexpr uint32_t kFlexfecSsrc = 5678;
1178 const std::vector<RtpExtension> kNoRtpExtensions;
erikvarga27883732017-05-17 05:08:38 -07001179 const std::vector<RtpExtensionSize> kNoRtpExtensionSizes;
brandtr81eab612017-01-24 04:06:09 -08001180 FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexfecSsrc, kMediaSsrc,
erikvarga27883732017-05-17 05:08:38 -07001181 kNoRtpExtensions, kNoRtpExtensionSizes,
brandtr48d21a22017-05-30 02:32:12 -07001182 nullptr /* rtp_state */, &fake_clock_);
brandtr81eab612017-01-24 04:06:09 -08001183
1184 // Reset |rtp_sender_| to use FlexFEC.
1185 rtp_sender_.reset(new RTPSender(
1186 false, &fake_clock_, &transport_, &mock_paced_sender_, &flexfec_sender,
1187 &seq_num_allocator_, nullptr, nullptr, nullptr, nullptr,
1188 &mock_rtc_event_log_, &send_packet_observer_,
Erik Språng7b52f102018-02-07 14:37:37 +01001189 &retransmission_rate_limiter_, nullptr, false));
brandtr81eab612017-01-24 04:06:09 -08001190 rtp_sender_->SetSSRC(kMediaSsrc);
1191 rtp_sender_->SetSequenceNumber(kSeqNum);
brandtr81eab612017-01-24 04:06:09 -08001192
1193 // Parameters selected to generate a single FEC packet per media packet.
1194 FecProtectionParams params;
1195 params.fec_rate = 15;
1196 params.max_fec_frames = 1;
1197 params.fec_mask_type = kFecMaskRandom;
1198 rtp_sender_->SetFecParameters(params, params);
1199
1200 constexpr size_t kNumMediaPackets = 10;
1201 constexpr size_t kNumFecPackets = kNumMediaPackets;
1202 constexpr int64_t kTimeBetweenPacketsMs = 10;
1203 EXPECT_CALL(mock_paced_sender_, InsertPacket(_, _, _, _, _, false))
1204 .Times(kNumMediaPackets + kNumFecPackets);
1205 for (size_t i = 0; i < kNumMediaPackets; ++i) {
1206 SendGenericPayload();
1207 fake_clock_.AdvanceTimeMilliseconds(kTimeBetweenPacketsMs);
1208 }
1209 constexpr size_t kRtpHeaderLength = 12;
1210 constexpr size_t kFlexfecHeaderLength = 20;
1211 constexpr size_t kGenericCodecHeaderLength = 1;
1212 constexpr size_t kPayloadLength = sizeof(kPayloadData);
1213 constexpr size_t kPacketLength = kRtpHeaderLength + kFlexfecHeaderLength +
1214 kGenericCodecHeaderLength + kPayloadLength;
1215 EXPECT_NEAR(kNumFecPackets * kPacketLength * 8 /
1216 (kNumFecPackets * kTimeBetweenPacketsMs / 1000.0f),
1217 rtp_sender_->FecOverheadRate(), 500);
1218}
1219
minyue3a407ee2017-04-03 01:10:33 -07001220TEST_P(RtpSenderTest, FrameCountCallbacks) {
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001221 class TestCallback : public FrameCountObserver {
1222 public:
pbos@webrtc.orgce4e9a32014-12-18 13:50:16 +00001223 TestCallback() : FrameCountObserver(), num_calls_(0), ssrc_(0) {}
Danil Chapovalovdd7e2842018-03-09 15:37:03 +00001224 ~TestCallback() override = default;
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001225
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00001226 void FrameCountUpdated(const FrameCounts& frame_counts,
1227 uint32_t ssrc) override {
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001228 ++num_calls_;
1229 ssrc_ = ssrc;
pbos@webrtc.orgce4e9a32014-12-18 13:50:16 +00001230 frame_counts_ = frame_counts;
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001231 }
1232
1233 uint32_t num_calls_;
1234 uint32_t ssrc_;
pbos@webrtc.orgce4e9a32014-12-18 13:50:16 +00001235 FrameCounts frame_counts_;
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001236 } callback;
1237
Erik Språng7b52f102018-02-07 14:37:37 +01001238 rtp_sender_.reset(new RTPSender(
1239 false, &fake_clock_, &transport_, &mock_paced_sender_, nullptr, nullptr,
1240 nullptr, nullptr, &callback, nullptr, nullptr, nullptr,
1241 &retransmission_rate_limiter_, nullptr, false));
nisse7d59f6b2017-02-21 03:40:24 -08001242 rtp_sender_->SetSSRC(kSsrc);
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001243 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
1244 const uint8_t payload_type = 127;
1245 ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 90000,
1246 0, 1500));
1247 uint8_t payload[] = {47, 11, 32, 93, 89};
1248 rtp_sender_->SetStorePacketsStatus(true, 1);
1249 uint32_t ssrc = rtp_sender_->SSRC();
1250
terelius5d332ac2016-01-14 14:37:39 -08001251 EXPECT_CALL(mock_paced_sender_, InsertPacket(_, _, _, _, _, _))
1252 .Times(::testing::AtLeast(2));
1253
spranga8ae6f22017-09-04 07:23:56 -07001254 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
1255 kVideoFrameKey, payload_type, 1234, 4321, payload, sizeof(payload),
1256 nullptr, nullptr, nullptr, kDefaultExpectedRetransmissionTimeMs));
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001257
1258 EXPECT_EQ(1U, callback.num_calls_);
1259 EXPECT_EQ(ssrc, callback.ssrc_);
pbos@webrtc.orgce4e9a32014-12-18 13:50:16 +00001260 EXPECT_EQ(1, callback.frame_counts_.key_frames);
1261 EXPECT_EQ(0, callback.frame_counts_.delta_frames);
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001262
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001263 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
1264 kVideoFrameDelta, payload_type, 1234, 4321, payload, sizeof(payload),
spranga8ae6f22017-09-04 07:23:56 -07001265 nullptr, nullptr, nullptr, kDefaultExpectedRetransmissionTimeMs));
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001266
1267 EXPECT_EQ(2U, callback.num_calls_);
1268 EXPECT_EQ(ssrc, callback.ssrc_);
pbos@webrtc.orgce4e9a32014-12-18 13:50:16 +00001269 EXPECT_EQ(1, callback.frame_counts_.key_frames);
1270 EXPECT_EQ(1, callback.frame_counts_.delta_frames);
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001271
andresp@webrtc.org8f151212014-07-10 09:39:23 +00001272 rtp_sender_.reset();
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001273}
1274
minyue3a407ee2017-04-03 01:10:33 -07001275TEST_P(RtpSenderTest, BitrateCallbacks) {
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001276 class TestCallback : public BitrateStatisticsObserver {
1277 public:
sprangcd349d92016-07-13 09:11:28 -07001278 TestCallback()
1279 : BitrateStatisticsObserver(),
1280 num_calls_(0),
1281 ssrc_(0),
1282 total_bitrate_(0),
1283 retransmit_bitrate_(0) {}
Danil Chapovalovdd7e2842018-03-09 15:37:03 +00001284 ~TestCallback() override = default;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001285
sprangcd349d92016-07-13 09:11:28 -07001286 void Notify(uint32_t total_bitrate,
1287 uint32_t retransmit_bitrate,
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00001288 uint32_t ssrc) override {
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001289 ++num_calls_;
1290 ssrc_ = ssrc;
sprangcd349d92016-07-13 09:11:28 -07001291 total_bitrate_ = total_bitrate;
1292 retransmit_bitrate_ = retransmit_bitrate;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001293 }
1294
1295 uint32_t num_calls_;
1296 uint32_t ssrc_;
sprangcd349d92016-07-13 09:11:28 -07001297 uint32_t total_bitrate_;
1298 uint32_t retransmit_bitrate_;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001299 } callback;
Erik Språng7b52f102018-02-07 14:37:37 +01001300 rtp_sender_.reset(
1301 new RTPSender(false, &fake_clock_, &transport_, nullptr, nullptr, nullptr,
1302 nullptr, &callback, nullptr, nullptr, nullptr, nullptr,
1303 &retransmission_rate_limiter_, nullptr, false));
nisse7d59f6b2017-02-21 03:40:24 -08001304 rtp_sender_->SetSSRC(kSsrc);
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001305
sprangcd349d92016-07-13 09:11:28 -07001306 // Simulate kNumPackets sent with kPacketInterval ms intervals, with the
1307 // number of packets selected so that we fill (but don't overflow) the one
1308 // second averaging window.
1309 const uint32_t kWindowSizeMs = 1000;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001310 const uint32_t kPacketInterval = 20;
sprangcd349d92016-07-13 09:11:28 -07001311 const uint32_t kNumPackets =
1312 (kWindowSizeMs - kPacketInterval) / kPacketInterval;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001313 // Overhead = 12 bytes RTP header + 1 byte generic header.
1314 const uint32_t kPacketOverhead = 13;
1315
1316 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
1317 const uint8_t payload_type = 127;
danilchap162abd32015-12-10 02:39:40 -08001318 ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 90000,
1319 0, 1500));
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001320 uint8_t payload[] = {47, 11, 32, 93, 89};
1321 rtp_sender_->SetStorePacketsStatus(true, 1);
1322 uint32_t ssrc = rtp_sender_->SSRC();
1323
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001324 // Initial process call so we get a new time window.
1325 rtp_sender_->ProcessBitrate();
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001326
1327 // Send a few frames.
1328 for (uint32_t i = 0; i < kNumPackets; ++i) {
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001329 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
1330 kVideoFrameKey, payload_type, 1234, 4321, payload, sizeof(payload),
spranga8ae6f22017-09-04 07:23:56 -07001331 nullptr, nullptr, nullptr, kDefaultExpectedRetransmissionTimeMs));
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001332 fake_clock_.AdvanceTimeMilliseconds(kPacketInterval);
1333 }
1334
1335 rtp_sender_->ProcessBitrate();
1336
stefan@webrtc.org0bae1fa2014-11-05 14:05:29 +00001337 // We get one call for every stats updated, thus two calls since both the
1338 // stream stats and the retransmit stats are updated once.
1339 EXPECT_EQ(2u, callback.num_calls_);
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001340 EXPECT_EQ(ssrc, callback.ssrc_);
sprangcd349d92016-07-13 09:11:28 -07001341 const uint32_t kTotalPacketSize = kPacketOverhead + sizeof(payload);
1342 // Bitrate measured over delta between last and first timestamp, plus one.
1343 const uint32_t kExpectedWindowMs = kNumPackets * kPacketInterval + 1;
1344 const uint32_t kExpectedBitsAccumulated = kTotalPacketSize * kNumPackets * 8;
1345 const uint32_t kExpectedRateBps =
1346 (kExpectedBitsAccumulated * 1000 + (kExpectedWindowMs / 2)) /
1347 kExpectedWindowMs;
1348 EXPECT_EQ(kExpectedRateBps, callback.total_bitrate_);
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001349
andresp@webrtc.orgd11bec42014-07-08 14:32:58 +00001350 rtp_sender_.reset();
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001351}
1352
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001353class RtpSenderAudioTest : public RtpSenderTest {
1354 protected:
1355 RtpSenderAudioTest() {}
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001356
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00001357 void SetUp() override {
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001358 payload_ = kAudioPayload;
Erik Språng7b52f102018-02-07 14:37:37 +01001359 rtp_sender_.reset(
1360 new RTPSender(true, &fake_clock_, &transport_, nullptr, nullptr,
1361 nullptr, nullptr, nullptr, nullptr, nullptr, nullptr,
1362 nullptr, &retransmission_rate_limiter_, nullptr, false));
nisse7d59f6b2017-02-21 03:40:24 -08001363 rtp_sender_->SetSSRC(kSsrc);
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001364 rtp_sender_->SetSequenceNumber(kSeqNum);
1365 }
1366};
1367
minyue3a407ee2017-04-03 01:10:33 -07001368TEST_P(RtpSenderTestWithoutPacer, StreamDataCountersCallbacks) {
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001369 class TestCallback : public StreamDataCountersCallback {
1370 public:
danilchap162abd32015-12-10 02:39:40 -08001371 TestCallback() : StreamDataCountersCallback(), ssrc_(0), counters_() {}
Danil Chapovalovdd7e2842018-03-09 15:37:03 +00001372 ~TestCallback() override = default;
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001373
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00001374 void DataCountersUpdated(const StreamDataCounters& counters,
1375 uint32_t ssrc) override {
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001376 ssrc_ = ssrc;
1377 counters_ = counters;
1378 }
1379
1380 uint32_t ssrc_;
1381 StreamDataCounters counters_;
asapersson@webrtc.org44149392015-02-04 08:34:47 +00001382
1383 void MatchPacketCounter(const RtpPacketCounter& expected,
1384 const RtpPacketCounter& actual) {
1385 EXPECT_EQ(expected.payload_bytes, actual.payload_bytes);
1386 EXPECT_EQ(expected.header_bytes, actual.header_bytes);
1387 EXPECT_EQ(expected.padding_bytes, actual.padding_bytes);
1388 EXPECT_EQ(expected.packets, actual.packets);
1389 }
1390
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001391 void Matches(uint32_t ssrc, const StreamDataCounters& counters) {
1392 EXPECT_EQ(ssrc, ssrc_);
asapersson@webrtc.org44149392015-02-04 08:34:47 +00001393 MatchPacketCounter(counters.transmitted, counters_.transmitted);
1394 MatchPacketCounter(counters.retransmitted, counters_.retransmitted);
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001395 EXPECT_EQ(counters.fec.packets, counters_.fec.packets);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001396 }
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001397 } callback;
1398
1399 const uint8_t kRedPayloadType = 96;
1400 const uint8_t kUlpfecPayloadType = 97;
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001401 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
1402 const uint8_t payload_type = 127;
1403 ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 90000,
1404 0, 1500));
1405 uint8_t payload[] = {47, 11, 32, 93, 89};
1406 rtp_sender_->SetStorePacketsStatus(true, 1);
1407 uint32_t ssrc = rtp_sender_->SSRC();
1408
1409 rtp_sender_->RegisterRtpStatisticsCallback(&callback);
1410
1411 // Send a frame.
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001412 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001413 kVideoFrameKey, payload_type, 1234, 4321, payload, sizeof(payload),
1414 nullptr, nullptr, nullptr, kDefaultExpectedRetransmissionTimeMs));
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001415 StreamDataCounters expected;
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001416 expected.transmitted.payload_bytes = 6;
1417 expected.transmitted.header_bytes = 12;
1418 expected.transmitted.padding_bytes = 0;
1419 expected.transmitted.packets = 1;
1420 expected.retransmitted.payload_bytes = 0;
1421 expected.retransmitted.header_bytes = 0;
1422 expected.retransmitted.padding_bytes = 0;
1423 expected.retransmitted.packets = 0;
1424 expected.fec.packets = 0;
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001425 callback.Matches(ssrc, expected);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001426
1427 // Retransmit a frame.
1428 uint16_t seqno = rtp_sender_->SequenceNumber() - 1;
Erik Språnga12b1d62018-03-14 12:39:24 +01001429 rtp_sender_->ReSendPacket(seqno);
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001430 expected.transmitted.payload_bytes = 12;
1431 expected.transmitted.header_bytes = 24;
1432 expected.transmitted.packets = 2;
1433 expected.retransmitted.payload_bytes = 6;
1434 expected.retransmitted.header_bytes = 12;
1435 expected.retransmitted.padding_bytes = 0;
1436 expected.retransmitted.packets = 1;
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001437 callback.Matches(ssrc, expected);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001438
1439 // Send padding.
philipel8aadd502017-02-23 02:56:13 -08001440 rtp_sender_->TimeToSendPadding(kMaxPaddingSize, PacedPacketInfo());
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001441 expected.transmitted.payload_bytes = 12;
1442 expected.transmitted.header_bytes = 36;
1443 expected.transmitted.padding_bytes = kMaxPaddingSize;
1444 expected.transmitted.packets = 3;
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001445 callback.Matches(ssrc, expected);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001446
brandtrf1bb4762016-11-07 03:05:06 -08001447 // Send ULPFEC.
1448 rtp_sender_->SetUlpfecConfig(kRedPayloadType, kUlpfecPayloadType);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001449 FecProtectionParams fec_params;
1450 fec_params.fec_mask_type = kFecMaskRandom;
1451 fec_params.fec_rate = 1;
1452 fec_params.max_fec_frames = 1;
brandtr1743a192016-11-07 03:36:05 -08001453 rtp_sender_->SetFecParameters(fec_params, fec_params);
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001454 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001455 kVideoFrameDelta, payload_type, 1234, 4321, payload, sizeof(payload),
1456 nullptr, nullptr, nullptr, kDefaultExpectedRetransmissionTimeMs));
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001457 expected.transmitted.payload_bytes = 40;
1458 expected.transmitted.header_bytes = 60;
1459 expected.transmitted.packets = 5;
1460 expected.fec.packets = 1;
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001461 callback.Matches(ssrc, expected);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001462
sprang867fb522015-08-03 04:38:41 -07001463 rtp_sender_->RegisterRtpStatisticsCallback(nullptr);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001464}
1465
minyue3a407ee2017-04-03 01:10:33 -07001466TEST_P(RtpSenderAudioTest, SendAudio) {
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001467 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "PAYLOAD_NAME";
1468 const uint8_t payload_type = 127;
1469 ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 48000,
1470 0, 1500));
1471 uint8_t payload[] = {47, 11, 32, 93, 89};
1472
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001473 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001474 kAudioFrameCN, payload_type, 1234, 4321, payload, sizeof(payload),
1475 nullptr, nullptr, nullptr, kDefaultExpectedRetransmissionTimeMs));
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001476
danilchap96c15872016-11-21 01:35:29 -08001477 auto sent_payload = transport_.last_sent_packet().payload();
1478 EXPECT_THAT(sent_payload, ElementsAreArray(payload));
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001479}
1480
minyue3a407ee2017-04-03 01:10:33 -07001481TEST_P(RtpSenderAudioTest, SendAudioWithAudioLevelExtension) {
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001482 EXPECT_EQ(0, rtp_sender_->SetAudioLevel(kAudioLevel));
danilchap162abd32015-12-10 02:39:40 -08001483 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAudioLevel,
1484 kAudioLevelExtensionId));
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001485
1486 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "PAYLOAD_NAME";
1487 const uint8_t payload_type = 127;
1488 ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 48000,
1489 0, 1500));
1490 uint8_t payload[] = {47, 11, 32, 93, 89};
1491
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001492 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001493 kAudioFrameCN, payload_type, 1234, 4321, payload, sizeof(payload),
1494 nullptr, nullptr, nullptr, kDefaultExpectedRetransmissionTimeMs));
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001495
danilchap96c15872016-11-21 01:35:29 -08001496 auto sent_payload = transport_.last_sent_packet().payload();
1497 EXPECT_THAT(sent_payload, ElementsAreArray(payload));
danilchap12ba1862016-10-26 02:41:55 -07001498 // Verify AudioLevel extension.
1499 bool voice_activity;
1500 uint8_t audio_level;
1501 EXPECT_TRUE(transport_.last_sent_packet().GetExtension<AudioLevel>(
1502 &voice_activity, &audio_level));
1503 EXPECT_EQ(kAudioLevel, audio_level);
1504 EXPECT_FALSE(voice_activity);
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001505}
1506
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001507// As RFC4733, named telephone events are carried as part of the audio stream
1508// and must use the same sequence number and timestamp base as the regular
1509// audio channel.
1510// This test checks the marker bit for the first packet and the consequent
1511// packets of the same telephone event. Since it is specifically for DTMF
pbos22993e12015-10-19 02:39:06 -07001512// events, ignoring audio packets and sending kEmptyFrame instead of those.
minyue3a407ee2017-04-03 01:10:33 -07001513TEST_P(RtpSenderAudioTest, CheckMarkerBitForTelephoneEvents) {
solenbergffbbcac2016-11-17 05:25:37 -08001514 const char* kDtmfPayloadName = "telephone-event";
1515 const uint32_t kPayloadFrequency = 8000;
1516 const uint8_t kPayloadType = 126;
1517 ASSERT_EQ(0, rtp_sender_->RegisterPayload(kDtmfPayloadName, kPayloadType,
1518 kPayloadFrequency, 0, 0));
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001519 // For Telephone events, payload is not added to the registered payload list,
1520 // it will register only the payload used for audio stream.
1521 // Registering the payload again for audio stream with different payload name.
solenbergffbbcac2016-11-17 05:25:37 -08001522 const char* kPayloadName = "payload_name";
1523 ASSERT_EQ(0, rtp_sender_->RegisterPayload(kPayloadName, kPayloadType,
1524 kPayloadFrequency, 1, 0));
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001525 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
1526 // DTMF event key=9, duration=500 and attenuationdB=10
1527 rtp_sender_->SendTelephoneEvent(9, 500, 10);
1528 // During start, it takes the starting timestamp as last sent timestamp.
1529 // The duration is calculated as the difference of current and last sent
1530 // timestamp. So for first call it will skip since the duration is zero.
spranga8ae6f22017-09-04 07:23:56 -07001531 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
1532 kEmptyFrame, kPayloadType, capture_time_ms, 0, nullptr, 0, nullptr,
1533 nullptr, nullptr, kDefaultExpectedRetransmissionTimeMs));
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001534 // DTMF Sample Length is (Frequency/1000) * Duration.
1535 // So in this case, it is (8000/1000) * 500 = 4000.
1536 // Sending it as two packets.
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001537 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001538 kEmptyFrame, kPayloadType, capture_time_ms + 2000, 0, nullptr, 0, nullptr,
1539 nullptr, nullptr, kDefaultExpectedRetransmissionTimeMs));
danilchap12ba1862016-10-26 02:41:55 -07001540
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001541 // Marker Bit should be set to 1 for first packet.
danilchap12ba1862016-10-26 02:41:55 -07001542 EXPECT_TRUE(transport_.last_sent_packet().Marker());
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001543
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001544 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001545 kEmptyFrame, kPayloadType, capture_time_ms + 4000, 0, nullptr, 0, nullptr,
1546 nullptr, nullptr, kDefaultExpectedRetransmissionTimeMs));
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001547 // Marker Bit should be set to 0 for rest of the packets.
danilchap12ba1862016-10-26 02:41:55 -07001548 EXPECT_FALSE(transport_.last_sent_packet().Marker());
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001549}
1550
minyue3a407ee2017-04-03 01:10:33 -07001551TEST_P(RtpSenderTestWithoutPacer, BytesReportedCorrectly) {
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001552 const char* kPayloadName = "GENERIC";
1553 const uint8_t kPayloadType = 127;
1554 rtp_sender_->SetSSRC(1234);
1555 rtp_sender_->SetRtxSsrc(4321);
Shao Changbine62202f2015-04-21 20:24:50 +08001556 rtp_sender_->SetRtxPayloadType(kPayloadType - 1, kPayloadType);
pbos@webrtc.org0b0c2412015-01-13 14:15:15 +00001557 rtp_sender_->SetRtxStatus(kRtxRetransmitted | kRtxRedundantPayloads);
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001558
danilchap162abd32015-12-10 02:39:40 -08001559 ASSERT_EQ(0, rtp_sender_->RegisterPayload(kPayloadName, kPayloadType, 90000,
1560 0, 1500));
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001561 uint8_t payload[] = {47, 11, 32, 93, 89};
1562
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001563 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001564 kVideoFrameKey, kPayloadType, 1234, 4321, payload, sizeof(payload),
1565 nullptr, nullptr, nullptr, kDefaultExpectedRetransmissionTimeMs));
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001566
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +00001567 // Will send 2 full-size padding packets.
philipel8aadd502017-02-23 02:56:13 -08001568 rtp_sender_->TimeToSendPadding(1, PacedPacketInfo());
1569 rtp_sender_->TimeToSendPadding(1, PacedPacketInfo());
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001570
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +00001571 StreamDataCounters rtp_stats;
1572 StreamDataCounters rtx_stats;
1573 rtp_sender_->GetDataCounters(&rtp_stats, &rtx_stats);
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001574
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +00001575 // Payload + 1-byte generic header.
asapersson@webrtc.orgd08d3892014-12-16 12:03:11 +00001576 EXPECT_GT(rtp_stats.first_packet_time_ms, -1);
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001577 EXPECT_EQ(rtp_stats.transmitted.payload_bytes, sizeof(payload) + 1);
1578 EXPECT_EQ(rtp_stats.transmitted.header_bytes, 12u);
1579 EXPECT_EQ(rtp_stats.transmitted.padding_bytes, 0u);
1580 EXPECT_EQ(rtx_stats.transmitted.payload_bytes, 0u);
1581 EXPECT_EQ(rtx_stats.transmitted.header_bytes, 24u);
1582 EXPECT_EQ(rtx_stats.transmitted.padding_bytes, 2 * kMaxPaddingSize);
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +00001583
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001584 EXPECT_EQ(rtp_stats.transmitted.TotalBytes(),
danilchap162abd32015-12-10 02:39:40 -08001585 rtp_stats.transmitted.payload_bytes +
1586 rtp_stats.transmitted.header_bytes +
1587 rtp_stats.transmitted.padding_bytes);
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001588 EXPECT_EQ(rtx_stats.transmitted.TotalBytes(),
danilchap162abd32015-12-10 02:39:40 -08001589 rtx_stats.transmitted.payload_bytes +
1590 rtx_stats.transmitted.header_bytes +
1591 rtx_stats.transmitted.padding_bytes);
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001592
danilchap162abd32015-12-10 02:39:40 -08001593 EXPECT_EQ(
1594 transport_.total_bytes_sent_,
1595 rtp_stats.transmitted.TotalBytes() + rtx_stats.transmitted.TotalBytes());
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001596}
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001597
minyue3a407ee2017-04-03 01:10:33 -07001598TEST_P(RtpSenderTestWithoutPacer, RespectsNackBitrateLimit) {
sprang38778b02015-09-29 09:48:22 -07001599 const int32_t kPacketSize = 1400;
1600 const int32_t kNumPackets = 30;
1601
sprangcd349d92016-07-13 09:11:28 -07001602 retransmission_rate_limiter_.SetMaxRate(kPacketSize * kNumPackets * 8);
1603
sprang38778b02015-09-29 09:48:22 -07001604 rtp_sender_->SetStorePacketsStatus(true, kNumPackets);
sprang38778b02015-09-29 09:48:22 -07001605 const uint16_t kStartSequenceNumber = rtp_sender_->SequenceNumber();
Danil Chapovalov2800d742016-08-26 18:48:46 +02001606 std::vector<uint16_t> sequence_numbers;
sprang38778b02015-09-29 09:48:22 -07001607 for (int32_t i = 0; i < kNumPackets; ++i) {
1608 sequence_numbers.push_back(kStartSequenceNumber + i);
1609 fake_clock_.AdvanceTimeMilliseconds(1);
1610 SendPacket(fake_clock_.TimeInMilliseconds(), kPacketSize);
1611 }
danilchap12ba1862016-10-26 02:41:55 -07001612 EXPECT_EQ(kNumPackets, transport_.packets_sent());
sprang38778b02015-09-29 09:48:22 -07001613
1614 fake_clock_.AdvanceTimeMilliseconds(1000 - kNumPackets);
1615
1616 // Resending should work - brings the bandwidth up to the limit.
1617 // NACK bitrate is capped to the same bitrate as the encoder, since the max
1618 // protection overhead is 50% (see MediaOptimization::SetTargetRates).
Danil Chapovalov2800d742016-08-26 18:48:46 +02001619 rtp_sender_->OnReceivedNack(sequence_numbers, 0);
danilchap12ba1862016-10-26 02:41:55 -07001620 EXPECT_EQ(kNumPackets * 2, transport_.packets_sent());
sprang38778b02015-09-29 09:48:22 -07001621
sprangcd349d92016-07-13 09:11:28 -07001622 // Must be at least 5ms in between retransmission attempts.
1623 fake_clock_.AdvanceTimeMilliseconds(5);
1624
sprang38778b02015-09-29 09:48:22 -07001625 // Resending should not work, bandwidth exceeded.
Danil Chapovalov2800d742016-08-26 18:48:46 +02001626 rtp_sender_->OnReceivedNack(sequence_numbers, 0);
danilchap12ba1862016-10-26 02:41:55 -07001627 EXPECT_EQ(kNumPackets * 2, transport_.packets_sent());
sprang38778b02015-09-29 09:48:22 -07001628}
1629
minyue3a407ee2017-04-03 01:10:33 -07001630TEST_P(RtpSenderVideoTest, KeyFrameHasCVO) {
danilchapb6f1fb52016-10-19 06:11:39 -07001631 uint8_t kFrame[kMaxPacketLength];
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001632 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
1633 kRtpExtensionVideoRotation, kVideoRotationExtensionId));
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001634
danilchapc1600c52016-10-26 03:33:11 -07001635 RTPVideoHeader hdr = {0};
1636 hdr.rotation = kVideoRotation_0;
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001637 rtp_sender_video_->SendVideo(kRtpVideoGeneric, kVideoFrameKey, kPayload,
danilchapb6f1fb52016-10-19 06:11:39 -07001638 kTimestamp, 0, kFrame, sizeof(kFrame), nullptr,
spranga8ae6f22017-09-04 07:23:56 -07001639 &hdr, kDefaultExpectedRetransmissionTimeMs);
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001640
danilchapc1600c52016-10-26 03:33:11 -07001641 VideoRotation rotation;
1642 EXPECT_TRUE(
1643 transport_.last_sent_packet().GetExtension<VideoOrientation>(&rotation));
1644 EXPECT_EQ(kVideoRotation_0, rotation);
1645}
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001646
ilnik04f4d122017-06-19 07:18:55 -07001647TEST_P(RtpSenderVideoTest, TimingFrameHasPacketizationTimstampSet) {
1648 uint8_t kFrame[kMaxPacketLength];
1649 const int64_t kPacketizationTimeMs = 100;
1650 const int64_t kEncodeStartDeltaMs = 10;
1651 const int64_t kEncodeFinishDeltaMs = 50;
1652 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
1653 kRtpExtensionVideoTiming, kVideoTimingExtensionId));
1654
1655 const int64_t kCaptureTimestamp = fake_clock_.TimeInMilliseconds();
1656
1657 RTPVideoHeader hdr = {0};
sprangba050a62017-08-18 02:51:12 -07001658 hdr.video_timing.flags = TimingFrameFlags::kTriggeredByTimer;
ilnik04f4d122017-06-19 07:18:55 -07001659 hdr.video_timing.encode_start_delta_ms = kEncodeStartDeltaMs;
1660 hdr.video_timing.encode_finish_delta_ms = kEncodeFinishDeltaMs;
1661
1662 fake_clock_.AdvanceTimeMilliseconds(kPacketizationTimeMs);
1663 rtp_sender_video_->SendVideo(kRtpVideoGeneric, kVideoFrameKey, kPayload,
1664 kTimestamp, kCaptureTimestamp, kFrame,
spranga8ae6f22017-09-04 07:23:56 -07001665 sizeof(kFrame), nullptr, &hdr,
1666 kDefaultExpectedRetransmissionTimeMs);
ilnik2edc6842017-07-06 03:06:50 -07001667 VideoSendTiming timing;
ilnik04f4d122017-06-19 07:18:55 -07001668 EXPECT_TRUE(transport_.last_sent_packet().GetExtension<VideoTimingExtension>(
1669 &timing));
1670 EXPECT_EQ(kPacketizationTimeMs, timing.packetization_finish_delta_ms);
1671 EXPECT_EQ(kEncodeStartDeltaMs, timing.encode_start_delta_ms);
1672 EXPECT_EQ(kEncodeFinishDeltaMs, timing.encode_finish_delta_ms);
1673}
1674
minyue3a407ee2017-04-03 01:10:33 -07001675TEST_P(RtpSenderVideoTest, DeltaFrameHasCVOWhenChanged) {
danilchapc1600c52016-10-26 03:33:11 -07001676 uint8_t kFrame[kMaxPacketLength];
1677 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
1678 kRtpExtensionVideoRotation, kVideoRotationExtensionId));
1679
1680 RTPVideoHeader hdr = {0};
1681 hdr.rotation = kVideoRotation_90;
spranga8ae6f22017-09-04 07:23:56 -07001682 EXPECT_TRUE(rtp_sender_video_->SendVideo(
1683 kRtpVideoGeneric, kVideoFrameKey, kPayload, kTimestamp, 0, kFrame,
1684 sizeof(kFrame), nullptr, &hdr, kDefaultExpectedRetransmissionTimeMs));
danilchapc1600c52016-10-26 03:33:11 -07001685
1686 hdr.rotation = kVideoRotation_0;
spranga8ae6f22017-09-04 07:23:56 -07001687 EXPECT_TRUE(rtp_sender_video_->SendVideo(
1688 kRtpVideoGeneric, kVideoFrameDelta, kPayload, kTimestamp + 1, 0, kFrame,
1689 sizeof(kFrame), nullptr, &hdr, kDefaultExpectedRetransmissionTimeMs));
danilchapc1600c52016-10-26 03:33:11 -07001690
1691 VideoRotation rotation;
1692 EXPECT_TRUE(
1693 transport_.last_sent_packet().GetExtension<VideoOrientation>(&rotation));
1694 EXPECT_EQ(kVideoRotation_0, rotation);
1695}
1696
minyue3a407ee2017-04-03 01:10:33 -07001697TEST_P(RtpSenderVideoTest, DeltaFrameHasCVOWhenNonZero) {
danilchapc1600c52016-10-26 03:33:11 -07001698 uint8_t kFrame[kMaxPacketLength];
1699 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
1700 kRtpExtensionVideoRotation, kVideoRotationExtensionId));
1701
1702 RTPVideoHeader hdr = {0};
1703 hdr.rotation = kVideoRotation_90;
spranga8ae6f22017-09-04 07:23:56 -07001704 EXPECT_TRUE(rtp_sender_video_->SendVideo(
1705 kRtpVideoGeneric, kVideoFrameKey, kPayload, kTimestamp, 0, kFrame,
1706 sizeof(kFrame), nullptr, &hdr, kDefaultExpectedRetransmissionTimeMs));
danilchapc1600c52016-10-26 03:33:11 -07001707
spranga8ae6f22017-09-04 07:23:56 -07001708 EXPECT_TRUE(rtp_sender_video_->SendVideo(
1709 kRtpVideoGeneric, kVideoFrameDelta, kPayload, kTimestamp + 1, 0, kFrame,
1710 sizeof(kFrame), nullptr, &hdr, kDefaultExpectedRetransmissionTimeMs));
danilchapc1600c52016-10-26 03:33:11 -07001711
1712 VideoRotation rotation;
1713 EXPECT_TRUE(
1714 transport_.last_sent_packet().GetExtension<VideoOrientation>(&rotation));
1715 EXPECT_EQ(kVideoRotation_90, rotation);
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001716}
magjed71eb61c2016-09-08 03:24:58 -07001717
1718// Make sure rotation is parsed correctly when the Camera (C) and Flip (F) bits
1719// are set in the CVO byte.
minyue3a407ee2017-04-03 01:10:33 -07001720TEST_P(RtpSenderVideoTest, SendVideoWithCameraAndFlipCVO) {
magjed71eb61c2016-09-08 03:24:58 -07001721 // Test extracting rotation when Camera (C) and Flip (F) bits are zero.
1722 EXPECT_EQ(kVideoRotation_0, ConvertCVOByteToVideoRotation(0));
1723 EXPECT_EQ(kVideoRotation_90, ConvertCVOByteToVideoRotation(1));
1724 EXPECT_EQ(kVideoRotation_180, ConvertCVOByteToVideoRotation(2));
1725 EXPECT_EQ(kVideoRotation_270, ConvertCVOByteToVideoRotation(3));
1726 // Test extracting rotation when Camera (C) and Flip (F) bits are set.
1727 const int flip_bit = 1 << 2;
1728 const int camera_bit = 1 << 3;
1729 EXPECT_EQ(kVideoRotation_0,
1730 ConvertCVOByteToVideoRotation(flip_bit | camera_bit | 0));
1731 EXPECT_EQ(kVideoRotation_90,
1732 ConvertCVOByteToVideoRotation(flip_bit | camera_bit | 1));
1733 EXPECT_EQ(kVideoRotation_180,
1734 ConvertCVOByteToVideoRotation(flip_bit | camera_bit | 2));
1735 EXPECT_EQ(kVideoRotation_270,
1736 ConvertCVOByteToVideoRotation(flip_bit | camera_bit | 3));
1737}
1738
spranga8ae6f22017-09-04 07:23:56 -07001739TEST_P(RtpSenderVideoTest, RetransmissionTypesGeneric) {
1740 RTPVideoHeader header;
1741 header.codec = kRtpVideoGeneric;
1742
1743 EXPECT_EQ(kDontRetransmit,
1744 rtp_sender_video_->GetStorageType(
1745 header, kRetransmitOff, kDefaultExpectedRetransmissionTimeMs));
1746 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1747 header, kRetransmitBaseLayer,
1748 kDefaultExpectedRetransmissionTimeMs));
1749 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1750 header, kRetransmitHigherLayers,
1751 kDefaultExpectedRetransmissionTimeMs));
1752 EXPECT_EQ(kAllowRetransmission,
1753 rtp_sender_video_->GetStorageType(
1754 header, kConditionallyRetransmitHigherLayers,
1755 kDefaultExpectedRetransmissionTimeMs));
1756 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1757 header, kRetransmitAllPackets,
1758 kDefaultExpectedRetransmissionTimeMs));
1759}
1760
1761TEST_P(RtpSenderVideoTest, RetransmissionTypesH264) {
1762 RTPVideoHeader header;
1763 header.codec = kRtpVideoH264;
1764 header.codecHeader.H264.packetization_mode =
1765 H264PacketizationMode::NonInterleaved;
1766
1767 EXPECT_EQ(kDontRetransmit,
1768 rtp_sender_video_->GetStorageType(
1769 header, kRetransmitOff, kDefaultExpectedRetransmissionTimeMs));
1770 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1771 header, kRetransmitBaseLayer,
1772 kDefaultExpectedRetransmissionTimeMs));
1773 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1774 header, kRetransmitHigherLayers,
1775 kDefaultExpectedRetransmissionTimeMs));
1776 EXPECT_EQ(kAllowRetransmission,
1777 rtp_sender_video_->GetStorageType(
1778 header, kConditionallyRetransmitHigherLayers,
1779 kDefaultExpectedRetransmissionTimeMs));
1780 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1781 header, kRetransmitAllPackets,
1782 kDefaultExpectedRetransmissionTimeMs));
1783}
1784
1785TEST_P(RtpSenderVideoTest, RetransmissionTypesVP8BaseLayer) {
1786 RTPVideoHeader header;
1787 header.codec = kRtpVideoVp8;
1788 header.codecHeader.VP8.temporalIdx = 0;
1789
1790 EXPECT_EQ(kDontRetransmit,
1791 rtp_sender_video_->GetStorageType(
1792 header, kRetransmitOff, kDefaultExpectedRetransmissionTimeMs));
1793 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1794 header, kRetransmitBaseLayer,
1795 kDefaultExpectedRetransmissionTimeMs));
1796 EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType(
1797 header, kRetransmitHigherLayers,
1798 kDefaultExpectedRetransmissionTimeMs));
1799 EXPECT_EQ(kAllowRetransmission,
1800 rtp_sender_video_->GetStorageType(
1801 header, kRetransmitHigherLayers | kRetransmitBaseLayer,
1802 kDefaultExpectedRetransmissionTimeMs));
1803 EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType(
1804 header, kConditionallyRetransmitHigherLayers,
1805 kDefaultExpectedRetransmissionTimeMs));
1806 EXPECT_EQ(
1807 kAllowRetransmission,
1808 rtp_sender_video_->GetStorageType(
1809 header, kRetransmitBaseLayer | kConditionallyRetransmitHigherLayers,
1810 kDefaultExpectedRetransmissionTimeMs));
1811 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1812 header, kRetransmitAllPackets,
1813 kDefaultExpectedRetransmissionTimeMs));
1814}
1815
1816TEST_P(RtpSenderVideoTest, RetransmissionTypesVP8HigherLayers) {
1817 RTPVideoHeader header;
1818 header.codec = kRtpVideoVp8;
1819
1820 for (int tid = 1; tid <= kMaxTemporalStreams; ++tid) {
1821 header.codecHeader.VP8.temporalIdx = tid;
1822
1823 EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType(
1824 header, kRetransmitOff,
1825 kDefaultExpectedRetransmissionTimeMs));
1826 EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType(
1827 header, kRetransmitBaseLayer,
1828 kDefaultExpectedRetransmissionTimeMs));
1829 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1830 header, kRetransmitHigherLayers,
1831 kDefaultExpectedRetransmissionTimeMs));
1832 EXPECT_EQ(kAllowRetransmission,
1833 rtp_sender_video_->GetStorageType(
1834 header, kRetransmitHigherLayers | kRetransmitBaseLayer,
1835 kDefaultExpectedRetransmissionTimeMs));
1836 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1837 header, kRetransmitAllPackets,
1838 kDefaultExpectedRetransmissionTimeMs));
1839 }
1840}
1841
1842TEST_P(RtpSenderVideoTest, RetransmissionTypesVP9) {
1843 RTPVideoHeader header;
1844 header.codec = kRtpVideoVp9;
1845
1846 for (int tid = 1; tid <= kMaxTemporalStreams; ++tid) {
1847 header.codecHeader.VP9.temporal_idx = tid;
1848
1849 EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType(
1850 header, kRetransmitOff,
1851 kDefaultExpectedRetransmissionTimeMs));
1852 EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType(
1853 header, kRetransmitBaseLayer,
1854 kDefaultExpectedRetransmissionTimeMs));
1855 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1856 header, kRetransmitHigherLayers,
1857 kDefaultExpectedRetransmissionTimeMs));
1858 EXPECT_EQ(kAllowRetransmission,
1859 rtp_sender_video_->GetStorageType(
1860 header, kRetransmitHigherLayers | kRetransmitBaseLayer,
1861 kDefaultExpectedRetransmissionTimeMs));
1862 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1863 header, kRetransmitAllPackets,
1864 kDefaultExpectedRetransmissionTimeMs));
1865 }
1866}
1867
1868TEST_P(RtpSenderVideoTest, ConditionalRetransmit) {
1869 const int64_t kFrameIntervalMs = 33;
1870 const int64_t kRttMs = (kFrameIntervalMs * 3) / 2;
1871 const uint8_t kSettings =
1872 kRetransmitBaseLayer | kConditionallyRetransmitHigherLayers;
1873
1874 // Insert VP8 frames for all temporal layers, but stop before the final index.
1875 RTPVideoHeader header;
1876 header.codec = kRtpVideoVp8;
1877
1878 // Fill averaging window to prevent rounding errors.
1879 constexpr int kNumRepetitions =
1880 (RTPSenderVideo::kTLRateWindowSizeMs + (kFrameIntervalMs / 2)) /
1881 kFrameIntervalMs;
1882 constexpr int kPattern[] = {0, 2, 1, 2};
1883 for (size_t i = 0; i < arraysize(kPattern) * kNumRepetitions; ++i) {
1884 header.codecHeader.VP8.temporalIdx = kPattern[i % arraysize(kPattern)];
1885 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs);
1886 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
1887 }
1888
1889 // Since we're at the start of the pattern, the next expected frame in TL0 is
1890 // right now. We will wait at most one expected retransmission time before
1891 // acknowledging that it did not arrive, which means this frame and the next
1892 // will not be retransmitted.
1893 header.codecHeader.VP8.temporalIdx = 1;
1894 EXPECT_EQ(StorageType::kDontRetransmit,
1895 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
1896 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
1897 EXPECT_EQ(StorageType::kDontRetransmit,
1898 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
1899 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
1900
1901 // The TL0 frame did not arrive. So allow retransmission.
1902 EXPECT_EQ(StorageType::kAllowRetransmission,
1903 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
1904 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
1905
1906 // Insert a frame for TL2. We just had frame in TL1, so the next one there is
1907 // in three frames away. TL0 is still too far in the past. So, allow
1908 // retransmission.
1909 header.codecHeader.VP8.temporalIdx = 2;
1910 EXPECT_EQ(StorageType::kAllowRetransmission,
1911 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
1912 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
1913
1914 // Another TL2, next in TL1 is two frames away. Allow again.
1915 EXPECT_EQ(StorageType::kAllowRetransmission,
1916 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
1917 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
1918
1919 // Yet another TL2, next in TL1 is now only one frame away, so don't store
1920 // for retransmission.
1921 EXPECT_EQ(StorageType::kDontRetransmit,
1922 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
1923}
1924
1925TEST_P(RtpSenderVideoTest, ConditionalRetransmitLimit) {
1926 const int64_t kFrameIntervalMs = 200;
1927 const int64_t kRttMs = (kFrameIntervalMs * 3) / 2;
1928 const int32_t kSettings =
1929 kRetransmitBaseLayer | kConditionallyRetransmitHigherLayers;
1930
1931 // Insert VP8 frames for all temporal layers, but stop before the final index.
1932 RTPVideoHeader header;
1933 header.codec = kRtpVideoVp8;
1934
1935 // Fill averaging window to prevent rounding errors.
1936 constexpr int kNumRepetitions =
1937 (RTPSenderVideo::kTLRateWindowSizeMs + (kFrameIntervalMs / 2)) /
1938 kFrameIntervalMs;
1939 constexpr int kPattern[] = {0, 2, 2, 2};
1940 for (size_t i = 0; i < arraysize(kPattern) * kNumRepetitions; ++i) {
1941 header.codecHeader.VP8.temporalIdx = kPattern[i % arraysize(kPattern)];
1942
1943 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs);
1944 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
1945 }
1946
1947 // Since we're at the start of the pattern, the next expected frame will be
1948 // right now in TL0. Put it in TL1 instead. Regular rules would dictate that
1949 // we don't store for retransmission because we expect a frame in a lower
1950 // layer, but that last frame in TL1 was a long time ago in absolute terms,
1951 // so allow retransmission anyway.
1952 header.codecHeader.VP8.temporalIdx = 1;
1953 EXPECT_EQ(StorageType::kAllowRetransmission,
1954 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
1955}
1956
minyue3a407ee2017-04-03 01:10:33 -07001957TEST_P(RtpSenderTest, OnOverheadChanged) {
michaelt4da30442016-11-17 01:38:43 -08001958 MockOverheadObserver mock_overhead_observer;
Erik Språng7b52f102018-02-07 14:37:37 +01001959 rtp_sender_.reset(new RTPSender(
1960 false, &fake_clock_, &transport_, nullptr, nullptr, nullptr, nullptr,
1961 nullptr, nullptr, nullptr, nullptr, nullptr,
1962 &retransmission_rate_limiter_, &mock_overhead_observer, false));
nisse7d59f6b2017-02-21 03:40:24 -08001963 rtp_sender_->SetSSRC(kSsrc);
michaelt4da30442016-11-17 01:38:43 -08001964
michaelt4da30442016-11-17 01:38:43 -08001965 // RTP overhead is 12B.
nisse284542b2017-01-10 08:58:32 -08001966 EXPECT_CALL(mock_overhead_observer, OnOverheadChanged(12)).Times(1);
michaelt4da30442016-11-17 01:38:43 -08001967 SendGenericPayload();
1968
1969 rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionTransmissionTimeOffset,
1970 kTransmissionTimeOffsetExtensionId);
1971
1972 // TransmissionTimeOffset extension has a size of 8B.
nisse284542b2017-01-10 08:58:32 -08001973 // 12B + 8B = 20B
1974 EXPECT_CALL(mock_overhead_observer, OnOverheadChanged(20)).Times(1);
michaelt4da30442016-11-17 01:38:43 -08001975 SendGenericPayload();
1976}
1977
minyue3a407ee2017-04-03 01:10:33 -07001978TEST_P(RtpSenderTest, DoesNotUpdateOverheadOnEqualSize) {
michaelt4da30442016-11-17 01:38:43 -08001979 MockOverheadObserver mock_overhead_observer;
Erik Språng7b52f102018-02-07 14:37:37 +01001980 rtp_sender_.reset(new RTPSender(
1981 false, &fake_clock_, &transport_, nullptr, nullptr, nullptr, nullptr,
1982 nullptr, nullptr, nullptr, nullptr, nullptr,
1983 &retransmission_rate_limiter_, &mock_overhead_observer, false));
nisse7d59f6b2017-02-21 03:40:24 -08001984 rtp_sender_->SetSSRC(kSsrc);
michaelt4da30442016-11-17 01:38:43 -08001985
1986 EXPECT_CALL(mock_overhead_observer, OnOverheadChanged(_)).Times(1);
michaelt4da30442016-11-17 01:38:43 -08001987 SendGenericPayload();
1988 SendGenericPayload();
1989}
1990
sprang168794c2017-07-06 04:38:06 -07001991TEST_P(RtpSenderTest, SendsKeepAlive) {
1992 MockTransport transport;
Erik Språng7b52f102018-02-07 14:37:37 +01001993 rtp_sender_.reset(
1994 new RTPSender(false, &fake_clock_, &transport, nullptr, nullptr, nullptr,
1995 nullptr, nullptr, nullptr, nullptr, &mock_rtc_event_log_,
1996 nullptr, &retransmission_rate_limiter_, nullptr, false));
sprang168794c2017-07-06 04:38:06 -07001997 rtp_sender_->SetSequenceNumber(kSeqNum);
1998 rtp_sender_->SetTimestampOffset(0);
1999 rtp_sender_->SetSSRC(kSsrc);
2000
2001 const uint8_t kKeepalivePayloadType = 20;
2002 RTC_CHECK_NE(kKeepalivePayloadType, kPayload);
2003
2004 EXPECT_CALL(transport, SendRtp(_, _, _))
2005 .WillOnce(
2006 Invoke([&kKeepalivePayloadType](const uint8_t* packet, size_t len,
2007 const PacketOptions& options) {
2008 webrtc::RTPHeader rtp_header;
2009 RtpUtility::RtpHeaderParser parser(packet, len);
2010 EXPECT_TRUE(parser.Parse(&rtp_header, nullptr));
2011 EXPECT_FALSE(rtp_header.markerBit);
2012 EXPECT_EQ(0U, rtp_header.paddingLength);
2013 EXPECT_EQ(kKeepalivePayloadType, rtp_header.payloadType);
2014 EXPECT_EQ(kSeqNum, rtp_header.sequenceNumber);
2015 EXPECT_EQ(kSsrc, rtp_header.ssrc);
2016 EXPECT_EQ(0u, len - rtp_header.headerLength);
2017 return true;
2018 }));
2019
2020 rtp_sender_->SendKeepAlive(kKeepalivePayloadType);
2021 EXPECT_EQ(kSeqNum + 1, rtp_sender_->SequenceNumber());
2022}
2023
minyue3a407ee2017-04-03 01:10:33 -07002024INSTANTIATE_TEST_CASE_P(WithAndWithoutOverhead,
2025 RtpSenderTest,
2026 ::testing::Bool());
2027INSTANTIATE_TEST_CASE_P(WithAndWithoutOverhead,
2028 RtpSenderTestWithoutPacer,
2029 ::testing::Bool());
2030INSTANTIATE_TEST_CASE_P(WithAndWithoutOverhead,
2031 RtpSenderVideoTest,
2032 ::testing::Bool());
2033INSTANTIATE_TEST_CASE_P(WithAndWithoutOverhead,
2034 RtpSenderAudioTest,
2035 ::testing::Bool());
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00002036} // namespace webrtc