blob: db760ecf7c81bda409f2dfdb05b6e34780c5d064 [file] [log] [blame]
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +00001/*
phoglund@webrtc.org78088c22012-02-07 14:56:45 +00002 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +00003 *
4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
9 */
10
kwiberg84be5112016-04-27 01:19:58 -070011#include <memory>
danilchapb8b6fbb2015-12-10 05:05:27 -080012#include <vector>
13
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020014#include "api/video/video_timing.h"
Elad Alon4a87e1c2017-10-03 16:11:34 +020015#include "logging/rtc_event_log/events/rtc_event.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020016#include "logging/rtc_event_log/mock/mock_rtc_event_log.h"
17#include "modules/rtp_rtcp/include/rtp_cvo.h"
18#include "modules/rtp_rtcp/include/rtp_header_extension_map.h"
19#include "modules/rtp_rtcp/include/rtp_header_parser.h"
20#include "modules/rtp_rtcp/include/rtp_rtcp_defines.h"
21#include "modules/rtp_rtcp/source/rtcp_packet/transport_feedback.h"
22#include "modules/rtp_rtcp/source/rtp_format_video_generic.h"
23#include "modules/rtp_rtcp/source/rtp_header_extensions.h"
24#include "modules/rtp_rtcp/source/rtp_packet_received.h"
25#include "modules/rtp_rtcp/source/rtp_packet_to_send.h"
26#include "modules/rtp_rtcp/source/rtp_sender.h"
27#include "modules/rtp_rtcp/source/rtp_sender_video.h"
28#include "modules/rtp_rtcp/source/rtp_utility.h"
29#include "rtc_base/arraysize.h"
30#include "rtc_base/buffer.h"
31#include "rtc_base/ptr_util.h"
32#include "rtc_base/rate_limiter.h"
33#include "test/field_trial.h"
34#include "test/gmock.h"
35#include "test/gtest.h"
36#include "test/mock_transport.h"
Mirko Bonadei71207422017-09-15 13:58:09 +020037#include "typedefs.h" // NOLINT(build/include)
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +000038
39namespace webrtc {
40
andrew@webrtc.org8a442592011-12-16 21:24:30 +000041namespace {
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +000042const int kTransmissionTimeOffsetExtensionId = 1;
43const int kAbsoluteSendTimeExtensionId = 14;
sprang@webrtc.org30933902015-03-17 14:33:12 +000044const int kTransportSequenceNumberExtensionId = 13;
ilnik04f4d122017-06-19 07:18:55 -070045const int kVideoTimingExtensionId = 12;
andrew@webrtc.org8a442592011-12-16 21:24:30 +000046const int kPayload = 100;
Shao Changbine62202f2015-04-21 20:24:50 +080047const int kRtxPayload = 98;
andrew@webrtc.org8a442592011-12-16 21:24:30 +000048const uint32_t kTimestamp = 10;
49const uint16_t kSeqNum = 33;
brandtr9dfff292016-11-14 05:14:50 -080050const uint32_t kSsrc = 725242;
andrew@webrtc.org8a442592011-12-16 21:24:30 +000051const int kMaxPacketLength = 1500;
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +000052const uint8_t kAudioLevel = 0x5a;
sprang@webrtc.org30933902015-03-17 14:33:12 +000053const uint16_t kTransportSequenceNumber = 0xaabbu;
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +000054const uint8_t kAudioLevelExtensionId = 9;
55const int kAudioPayload = 103;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +000056const uint64_t kStartTime = 123456789;
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +000057const size_t kMaxPaddingSize = 224u;
guoweis@webrtc.org45362892015-03-04 22:55:15 +000058const int kVideoRotationExtensionId = 5;
Stefan Holmera246cfb2016-08-23 17:51:42 +020059const size_t kGenericHeaderLength = 1;
60const uint8_t kPayloadData[] = {47, 11, 32, 93, 89};
spranga8ae6f22017-09-04 07:23:56 -070061const int64_t kDefaultExpectedRetransmissionTimeMs = 125;
andrew@webrtc.org8a442592011-12-16 21:24:30 +000062
Danil Chapovalov5e57b172016-09-02 19:15:59 +020063using ::testing::_;
64using ::testing::ElementsAreArray;
sprang168794c2017-07-06 04:38:06 -070065using ::testing::Invoke;
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +000066
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +000067uint64_t ConvertMsToAbsSendTime(int64_t time_ms) {
Stefan Holmer0a87ffc2015-10-21 13:41:48 +020068 return (((time_ms << 18) + 500) / 1000) & 0x00ffffff;
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +000069}
70
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +000071class LoopbackTransportTest : public webrtc::Transport {
72 public:
danilchap12ba1862016-10-26 02:41:55 -070073 LoopbackTransportTest() : total_bytes_sent_(0), last_packet_id_(-1) {
74 receivers_extensions_.Register(kRtpExtensionTransmissionTimeOffset,
75 kTransmissionTimeOffsetExtensionId);
76 receivers_extensions_.Register(kRtpExtensionAbsoluteSendTime,
77 kAbsoluteSendTimeExtensionId);
78 receivers_extensions_.Register(kRtpExtensionTransportSequenceNumber,
79 kTransportSequenceNumberExtensionId);
80 receivers_extensions_.Register(kRtpExtensionVideoRotation,
81 kVideoRotationExtensionId);
82 receivers_extensions_.Register(kRtpExtensionAudioLevel,
83 kAudioLevelExtensionId);
ilnik04f4d122017-06-19 07:18:55 -070084 receivers_extensions_.Register(kRtpExtensionVideoTiming,
85 kVideoTimingExtensionId);
guoweis@webrtc.org45362892015-03-04 22:55:15 +000086 }
danilchap12ba1862016-10-26 02:41:55 -070087
stefan1d8a5062015-10-02 03:39:33 -070088 bool SendRtp(const uint8_t* data,
89 size_t len,
90 const PacketOptions& options) override {
Stefan Holmerf5dca482016-01-27 12:58:51 +010091 last_packet_id_ = options.packet_id;
pkasting@chromium.org4591fbd2014-11-20 22:28:14 +000092 total_bytes_sent_ += len;
danilchap12ba1862016-10-26 02:41:55 -070093 sent_packets_.push_back(RtpPacketReceived(&receivers_extensions_));
94 EXPECT_TRUE(sent_packets_.back().Parse(data, len));
pbos2d566682015-09-28 09:59:31 -070095 return true;
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +000096 }
danilchap162abd32015-12-10 02:39:40 -080097 bool SendRtcp(const uint8_t* data, size_t len) override { return false; }
danilchap12ba1862016-10-26 02:41:55 -070098 const RtpPacketReceived& last_sent_packet() { return sent_packets_.back(); }
99 int packets_sent() { return sent_packets_.size(); }
100
pbos@webrtc.org72491b92014-07-10 16:24:54 +0000101 size_t total_bytes_sent_;
Stefan Holmerf5dca482016-01-27 12:58:51 +0100102 int last_packet_id_;
danilchap12ba1862016-10-26 02:41:55 -0700103 std::vector<RtpPacketReceived> sent_packets_;
104
105 private:
106 RtpHeaderExtensionMap receivers_extensions_;
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000107};
108
Elad Alon4a87e1c2017-10-03 16:11:34 +0200109MATCHER_P(SameRtcEventTypeAs, value, "") {
110 return value == arg->GetType();
111}
112
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000113} // namespace
114
sprangebbf8a82015-09-21 15:11:14 -0700115class MockRtpPacketSender : public RtpPacketSender {
116 public:
117 MockRtpPacketSender() {}
118 virtual ~MockRtpPacketSender() {}
119
Peter Boströme23e7372015-10-08 11:44:14 +0200120 MOCK_METHOD6(InsertPacket,
121 void(Priority priority,
sprangebbf8a82015-09-21 15:11:14 -0700122 uint32_t ssrc,
123 uint16_t sequence_number,
124 int64_t capture_time_ms,
125 size_t bytes,
126 bool retransmission));
127};
128
Stefan Holmerf5dca482016-01-27 12:58:51 +0100129class MockTransportSequenceNumberAllocator
130 : public TransportSequenceNumberAllocator {
131 public:
132 MOCK_METHOD0(AllocateSequenceNumber, uint16_t());
133};
134
asapersson35151f32016-05-02 23:44:01 -0700135class MockSendPacketObserver : public SendPacketObserver {
136 public:
137 MOCK_METHOD3(OnSendPacket, void(uint16_t, int64_t, uint32_t));
138};
139
Stefan Holmera246cfb2016-08-23 17:51:42 +0200140class MockTransportFeedbackObserver : public TransportFeedbackObserver {
141 public:
elad.alond12a8e12017-03-23 11:04:48 -0700142 MOCK_METHOD4(AddPacket,
143 void(uint32_t, uint16_t, size_t, const PacedPacketInfo&));
Stefan Holmera246cfb2016-08-23 17:51:42 +0200144 MOCK_METHOD1(OnTransportFeedback, void(const rtcp::TransportFeedback&));
elad.alonf9490002017-03-06 05:32:21 -0800145 MOCK_CONST_METHOD0(GetTransportFeedbackVector, std::vector<PacketFeedback>());
Stefan Holmera246cfb2016-08-23 17:51:42 +0200146};
147
minyue3a407ee2017-04-03 01:10:33 -0700148class MockOverheadObserver : public OverheadObserver {
149 public:
150 MOCK_METHOD1(OnOverheadChanged, void(size_t overhead_bytes_per_packet));
151};
152
153class RtpSenderTest : public ::testing::TestWithParam<bool> {
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000154 protected:
155 RtpSenderTest()
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +0000156 : fake_clock_(kStartTime),
terelius429c3452016-01-21 05:42:04 -0800157 mock_rtc_event_log_(),
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +0000158 mock_paced_sender_(),
sprangcd349d92016-07-13 09:11:28 -0700159 retransmission_rate_limiter_(&fake_clock_, 1000),
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +0000160 rtp_sender_(),
161 payload_(kPayload),
162 transport_(),
minyue3a407ee2017-04-03 01:10:33 -0700163 kMarkerBit(true),
164 field_trials_(GetParam() ? "WebRTC-SendSideBwe-WithOverhead/Enabled/"
165 : "") {}
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +0000166
Peter Boströme23e7372015-10-08 11:44:14 +0200167 void SetUp() override { SetUpRtpSender(true); }
168
169 void SetUpRtpSender(bool pacer) {
asapersson35151f32016-05-02 23:44:01 -0700170 rtp_sender_.reset(new RTPSender(
171 false, &fake_clock_, &transport_, pacer ? &mock_paced_sender_ : nullptr,
brandtrdbdb3f12016-11-10 05:04:48 -0800172 nullptr, &seq_num_allocator_, nullptr, nullptr, nullptr, nullptr,
sprangcd349d92016-07-13 09:11:28 -0700173 &mock_rtc_event_log_, &send_packet_observer_,
michaelt4da30442016-11-17 01:38:43 -0800174 &retransmission_rate_limiter_, nullptr));
Danil Chapovalov31e4e802016-08-03 18:27:40 +0200175 rtp_sender_->SetSendPayloadType(kPayload);
brandtr9dfff292016-11-14 05:14:50 -0800176 rtp_sender_->SetSequenceNumber(kSeqNum);
danilchap71fead22016-08-18 02:01:49 -0700177 rtp_sender_->SetTimestampOffset(0);
brandtr9dfff292016-11-14 05:14:50 -0800178 rtp_sender_->SetSSRC(kSsrc);
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +0000179 }
180
stefan@webrtc.orga678a3b2013-01-21 07:42:11 +0000181 SimulatedClock fake_clock_;
stefana23fc622016-07-28 07:56:38 -0700182 testing::NiceMock<MockRtcEventLog> mock_rtc_event_log_;
sprangebbf8a82015-09-21 15:11:14 -0700183 MockRtpPacketSender mock_paced_sender_;
stefana23fc622016-07-28 07:56:38 -0700184 testing::StrictMock<MockTransportSequenceNumberAllocator> seq_num_allocator_;
185 testing::StrictMock<MockSendPacketObserver> send_packet_observer_;
Stefan Holmera246cfb2016-08-23 17:51:42 +0200186 testing::StrictMock<MockTransportFeedbackObserver> feedback_observer_;
sprangcd349d92016-07-13 09:11:28 -0700187 RateLimiter retransmission_rate_limiter_;
kwiberg84be5112016-04-27 01:19:58 -0700188 std::unique_ptr<RTPSender> rtp_sender_;
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +0000189 int payload_;
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000190 LoopbackTransportTest transport_;
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000191 const bool kMarkerBit;
minyue3a407ee2017-04-03 01:10:33 -0700192 test::ScopedFieldTrials field_trials_;
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000193
stefan@webrtc.orga5cb98c2013-05-29 12:12:51 +0000194 void VerifyRTPHeaderCommon(const RTPHeader& rtp_header) {
danilchapd9e62f52016-01-14 14:55:19 -0800195 VerifyRTPHeaderCommon(rtp_header, kMarkerBit, 0);
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000196 }
197
198 void VerifyRTPHeaderCommon(const RTPHeader& rtp_header, bool marker_bit) {
danilchapd9e62f52016-01-14 14:55:19 -0800199 VerifyRTPHeaderCommon(rtp_header, marker_bit, 0);
200 }
201
202 void VerifyRTPHeaderCommon(const RTPHeader& rtp_header,
203 bool marker_bit,
204 uint8_t number_of_csrcs) {
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000205 EXPECT_EQ(marker_bit, rtp_header.markerBit);
stefan@webrtc.orga5cb98c2013-05-29 12:12:51 +0000206 EXPECT_EQ(payload_, rtp_header.payloadType);
207 EXPECT_EQ(kSeqNum, rtp_header.sequenceNumber);
208 EXPECT_EQ(kTimestamp, rtp_header.timestamp);
209 EXPECT_EQ(rtp_sender_->SSRC(), rtp_header.ssrc);
danilchapd9e62f52016-01-14 14:55:19 -0800210 EXPECT_EQ(number_of_csrcs, rtp_header.numCSRCs);
pkasting@chromium.org4591fbd2014-11-20 22:28:14 +0000211 EXPECT_EQ(0U, rtp_header.paddingLength);
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000212 }
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000213
danilchapb6f1fb52016-10-19 06:11:39 -0700214 std::unique_ptr<RtpPacketToSend> BuildRtpPacket(int payload_type,
215 bool marker_bit,
216 uint32_t timestamp,
217 int64_t capture_time_ms) {
218 auto packet = rtp_sender_->AllocatePacket();
219 packet->SetPayloadType(payload_type);
220 packet->SetMarker(marker_bit);
221 packet->SetTimestamp(timestamp);
222 packet->set_capture_time_ms(capture_time_ms);
223 EXPECT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
224 return packet;
225 }
226
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000227 void SendPacket(int64_t capture_time_ms, int payload_length) {
228 uint32_t timestamp = capture_time_ms * 90;
danilchapb6f1fb52016-10-19 06:11:39 -0700229 auto packet =
230 BuildRtpPacket(kPayload, kMarkerBit, timestamp, capture_time_ms);
231 packet->AllocatePayload(payload_length);
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000232
233 // Packet should be stored in a send bucket.
danilchapb6f1fb52016-10-19 06:11:39 -0700234 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
235 kAllowRetransmission,
236 RtpPacketSender::kNormalPriority));
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000237 }
asapersson35151f32016-05-02 23:44:01 -0700238
239 void SendGenericPayload() {
asapersson35151f32016-05-02 23:44:01 -0700240 const uint32_t kTimestamp = 1234;
241 const uint8_t kPayloadType = 127;
242 const int64_t kCaptureTimeMs = fake_clock_.TimeInMilliseconds();
243 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
244 EXPECT_EQ(0, rtp_sender_->RegisterPayload(payload_name, kPayloadType, 90000,
245 0, 1500));
246
Sergey Ulanov525df3f2016-08-02 17:46:41 -0700247 EXPECT_TRUE(rtp_sender_->SendOutgoingData(
Stefan Holmera246cfb2016-08-23 17:51:42 +0200248 kVideoFrameKey, kPayloadType, kTimestamp, kCaptureTimeMs, kPayloadData,
spranga8ae6f22017-09-04 07:23:56 -0700249 sizeof(kPayloadData), nullptr, nullptr, nullptr,
250 kDefaultExpectedRetransmissionTimeMs));
asapersson35151f32016-05-02 23:44:01 -0700251 }
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000252};
253
Peter Boströme23e7372015-10-08 11:44:14 +0200254// TODO(pbos): Move tests over from WithoutPacer to RtpSenderTest as this is our
255// default code path.
256class RtpSenderTestWithoutPacer : public RtpSenderTest {
257 public:
258 void SetUp() override { SetUpRtpSender(false); }
259};
260
spranga8ae6f22017-09-04 07:23:56 -0700261class TestRtpSenderVideo : public RTPSenderVideo {
262 public:
263 TestRtpSenderVideo(Clock* clock,
264 RTPSender* rtp_sender,
265 FlexfecSender* flexfec_sender)
266 : RTPSenderVideo(clock, rtp_sender, flexfec_sender) {}
267 ~TestRtpSenderVideo() override {}
268
269 StorageType GetStorageType(const RTPVideoHeader& header,
270 int32_t retransmission_settings,
271 int64_t expected_retransmission_time_ms) {
272 return RTPSenderVideo::GetStorageType(GetTemporalId(header),
273 retransmission_settings,
274 expected_retransmission_time_ms);
275 }
276};
277
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000278class RtpSenderVideoTest : public RtpSenderTest {
279 protected:
danilchap162abd32015-12-10 02:39:40 -0800280 void SetUp() override {
Peter Boströme23e7372015-10-08 11:44:14 +0200281 // TODO(pbos): Set up to use pacer.
282 SetUpRtpSender(false);
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000283 rtp_sender_video_.reset(
spranga8ae6f22017-09-04 07:23:56 -0700284 new TestRtpSenderVideo(&fake_clock_, rtp_sender_.get(), nullptr));
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000285 }
spranga8ae6f22017-09-04 07:23:56 -0700286 std::unique_ptr<TestRtpSenderVideo> rtp_sender_video_;
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000287};
288
minyue3a407ee2017-04-03 01:10:33 -0700289TEST_P(RtpSenderTestWithoutPacer, AllocatePacketSetCsrc) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200290 // Configure rtp_sender with csrc.
291 std::vector<uint32_t> csrcs;
292 csrcs.push_back(0x23456789);
293 rtp_sender_->SetCsrcs(csrcs);
294
295 auto packet = rtp_sender_->AllocatePacket();
296
297 ASSERT_TRUE(packet);
298 EXPECT_EQ(rtp_sender_->SSRC(), packet->Ssrc());
299 EXPECT_EQ(csrcs, packet->Csrcs());
300}
301
minyue3a407ee2017-04-03 01:10:33 -0700302TEST_P(RtpSenderTestWithoutPacer, AllocatePacketReserveExtensions) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200303 // Configure rtp_sender with extensions.
304 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
305 kRtpExtensionTransmissionTimeOffset,
306 kTransmissionTimeOffsetExtensionId));
307 ASSERT_EQ(
308 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
309 kAbsoluteSendTimeExtensionId));
310 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAudioLevel,
311 kAudioLevelExtensionId));
312 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
313 kRtpExtensionTransportSequenceNumber,
314 kTransportSequenceNumberExtensionId));
315 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
316 kRtpExtensionVideoRotation, kVideoRotationExtensionId));
317
318 auto packet = rtp_sender_->AllocatePacket();
319
320 ASSERT_TRUE(packet);
321 // Preallocate BWE extensions RtpSender set itself.
322 EXPECT_TRUE(packet->HasExtension<TransmissionOffset>());
323 EXPECT_TRUE(packet->HasExtension<AbsoluteSendTime>());
324 EXPECT_TRUE(packet->HasExtension<TransportSequenceNumber>());
325 // Do not allocate media specific extensions.
326 EXPECT_FALSE(packet->HasExtension<AudioLevel>());
327 EXPECT_FALSE(packet->HasExtension<VideoOrientation>());
328}
329
minyue3a407ee2017-04-03 01:10:33 -0700330TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberAdvanceSequenceNumber) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200331 auto packet = rtp_sender_->AllocatePacket();
332 ASSERT_TRUE(packet);
333 const uint16_t sequence_number = rtp_sender_->SequenceNumber();
334
335 EXPECT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
336
337 EXPECT_EQ(sequence_number, packet->SequenceNumber());
338 EXPECT_EQ(sequence_number + 1, rtp_sender_->SequenceNumber());
339}
340
minyue3a407ee2017-04-03 01:10:33 -0700341TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberFailsOnNotSending) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200342 auto packet = rtp_sender_->AllocatePacket();
343 ASSERT_TRUE(packet);
344
345 rtp_sender_->SetSendingMediaStatus(false);
346 EXPECT_FALSE(rtp_sender_->AssignSequenceNumber(packet.get()));
347}
348
minyue3a407ee2017-04-03 01:10:33 -0700349TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberMayAllowPadding) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200350 constexpr size_t kPaddingSize = 100;
351 auto packet = rtp_sender_->AllocatePacket();
352 ASSERT_TRUE(packet);
353
philipel8aadd502017-02-23 02:56:13 -0800354 ASSERT_FALSE(rtp_sender_->TimeToSendPadding(kPaddingSize, PacedPacketInfo()));
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200355 packet->SetMarker(false);
356 ASSERT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
357 // Packet without marker bit doesn't allow padding.
philipel8aadd502017-02-23 02:56:13 -0800358 EXPECT_FALSE(rtp_sender_->TimeToSendPadding(kPaddingSize, PacedPacketInfo()));
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200359
360 packet->SetMarker(true);
361 ASSERT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
362 // Packet with marker bit allows send padding.
philipel8aadd502017-02-23 02:56:13 -0800363 EXPECT_TRUE(rtp_sender_->TimeToSendPadding(kPaddingSize, PacedPacketInfo()));
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200364}
365
minyue3a407ee2017-04-03 01:10:33 -0700366TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberSetPaddingTimestamps) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200367 constexpr size_t kPaddingSize = 100;
368 auto packet = rtp_sender_->AllocatePacket();
369 ASSERT_TRUE(packet);
370 packet->SetMarker(true);
371 packet->SetTimestamp(kTimestamp);
372
373 ASSERT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
philipel8aadd502017-02-23 02:56:13 -0800374 ASSERT_TRUE(rtp_sender_->TimeToSendPadding(kPaddingSize, PacedPacketInfo()));
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200375
376 ASSERT_EQ(1u, transport_.sent_packets_.size());
danilchap12ba1862016-10-26 02:41:55 -0700377 // Verify padding packet timestamp.
378 EXPECT_EQ(kTimestamp, transport_.last_sent_packet().Timestamp());
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200379}
380
minyue3a407ee2017-04-03 01:10:33 -0700381TEST_P(RtpSenderTestWithoutPacer,
382 TransportFeedbackObserverGetsCorrectByteCount) {
383 constexpr int kRtpOverheadBytesPerPacket = 12 + 8;
384 testing::NiceMock<MockOverheadObserver> mock_overhead_observer;
385 rtp_sender_.reset(new RTPSender(
386 false, &fake_clock_, &transport_, nullptr, nullptr, &seq_num_allocator_,
387 &feedback_observer_, nullptr, nullptr, nullptr, &mock_rtc_event_log_,
388 nullptr, &retransmission_rate_limiter_, &mock_overhead_observer));
389 rtp_sender_->SetSSRC(kSsrc);
390 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
391 kRtpExtensionTransportSequenceNumber,
392 kTransportSequenceNumberExtensionId));
393 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
394 .WillOnce(testing::Return(kTransportSequenceNumber));
395
396 const size_t expected_bytes =
397 GetParam() ? sizeof(kPayloadData) + kGenericHeaderLength +
398 kRtpOverheadBytesPerPacket
399 : sizeof(kPayloadData) + kGenericHeaderLength;
400
401 EXPECT_CALL(feedback_observer_,
402 AddPacket(rtp_sender_->SSRC(), kTransportSequenceNumber,
403 expected_bytes, PacedPacketInfo()))
404 .Times(1);
405 EXPECT_CALL(mock_overhead_observer,
406 OnOverheadChanged(kRtpOverheadBytesPerPacket))
407 .Times(1);
408 SendGenericPayload();
409}
410
411TEST_P(RtpSenderTestWithoutPacer, SendsPacketsWithTransportSequenceNumber) {
Stefan Holmera246cfb2016-08-23 17:51:42 +0200412 rtp_sender_.reset(new RTPSender(
brandtrdbdb3f12016-11-10 05:04:48 -0800413 false, &fake_clock_, &transport_, nullptr, nullptr, &seq_num_allocator_,
414 &feedback_observer_, nullptr, nullptr, nullptr, &mock_rtc_event_log_,
michaelt4da30442016-11-17 01:38:43 -0800415 &send_packet_observer_, &retransmission_rate_limiter_, nullptr));
nisse7d59f6b2017-02-21 03:40:24 -0800416 rtp_sender_->SetSSRC(kSsrc);
Stefan Holmerf5dca482016-01-27 12:58:51 +0100417 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
418 kRtpExtensionTransportSequenceNumber,
419 kTransportSequenceNumberExtensionId));
420
Stefan Holmerf5dca482016-01-27 12:58:51 +0100421 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
422 .WillOnce(testing::Return(kTransportSequenceNumber));
asapersson35151f32016-05-02 23:44:01 -0700423 EXPECT_CALL(send_packet_observer_,
424 OnSendPacket(kTransportSequenceNumber, _, _))
425 .Times(1);
minyue3a407ee2017-04-03 01:10:33 -0700426
427 EXPECT_CALL(feedback_observer_,
428 AddPacket(rtp_sender_->SSRC(), kTransportSequenceNumber, _,
429 PacedPacketInfo()))
Stefan Holmera246cfb2016-08-23 17:51:42 +0200430 .Times(1);
asapersson35151f32016-05-02 23:44:01 -0700431
432 SendGenericPayload();
Stefan Holmerf5dca482016-01-27 12:58:51 +0100433
danilchap12ba1862016-10-26 02:41:55 -0700434 const auto& packet = transport_.last_sent_packet();
435 uint16_t transport_seq_no;
436 ASSERT_TRUE(packet.GetExtension<TransportSequenceNumber>(&transport_seq_no));
437 EXPECT_EQ(kTransportSequenceNumber, transport_seq_no);
438 EXPECT_EQ(transport_.last_packet_id_, transport_seq_no);
Stefan Holmerf5dca482016-01-27 12:58:51 +0100439}
440
minyue3a407ee2017-04-03 01:10:33 -0700441TEST_P(RtpSenderTestWithoutPacer, NoAllocationIfNotRegistered) {
stefana23fc622016-07-28 07:56:38 -0700442 SendGenericPayload();
443}
asapersson35151f32016-05-02 23:44:01 -0700444
minyue3a407ee2017-04-03 01:10:33 -0700445TEST_P(RtpSenderTestWithoutPacer, OnSendPacketUpdated) {
stefana23fc622016-07-28 07:56:38 -0700446 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
447 kRtpExtensionTransportSequenceNumber,
448 kTransportSequenceNumberExtensionId));
asapersson35151f32016-05-02 23:44:01 -0700449 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
450 .WillOnce(testing::Return(kTransportSequenceNumber));
451 EXPECT_CALL(send_packet_observer_,
452 OnSendPacket(kTransportSequenceNumber, _, _))
453 .Times(1);
454
455 SendGenericPayload();
456}
457
minyue3a407ee2017-04-03 01:10:33 -0700458TEST_P(RtpSenderTest, SendsPacketsWithTransportSequenceNumber) {
michaelt4da30442016-11-17 01:38:43 -0800459 rtp_sender_.reset(new RTPSender(
460 false, &fake_clock_, &transport_, &mock_paced_sender_, nullptr,
461 &seq_num_allocator_, &feedback_observer_, nullptr, nullptr, nullptr,
462 &mock_rtc_event_log_, &send_packet_observer_,
463 &retransmission_rate_limiter_, nullptr));
brandtr9dfff292016-11-14 05:14:50 -0800464 rtp_sender_->SetSequenceNumber(kSeqNum);
465 rtp_sender_->SetSSRC(kSsrc);
Stefan Holmera246cfb2016-08-23 17:51:42 +0200466 rtp_sender_->SetStorePacketsStatus(true, 10);
467 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
468 kRtpExtensionTransportSequenceNumber,
469 kTransportSequenceNumberExtensionId));
470
brandtr9dfff292016-11-14 05:14:50 -0800471 EXPECT_CALL(mock_paced_sender_, InsertPacket(_, kSsrc, kSeqNum, _, _, _));
Stefan Holmera246cfb2016-08-23 17:51:42 +0200472 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
473 .WillOnce(testing::Return(kTransportSequenceNumber));
474 EXPECT_CALL(send_packet_observer_,
475 OnSendPacket(kTransportSequenceNumber, _, _))
476 .Times(1);
minyue3a407ee2017-04-03 01:10:33 -0700477 EXPECT_CALL(feedback_observer_,
478 AddPacket(rtp_sender_->SSRC(), kTransportSequenceNumber, _,
479 PacedPacketInfo()))
Stefan Holmera246cfb2016-08-23 17:51:42 +0200480 .Times(1);
481
482 SendGenericPayload();
philipel8aadd502017-02-23 02:56:13 -0800483 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum,
484 fake_clock_.TimeInMilliseconds(), false,
485 PacedPacketInfo());
Stefan Holmera246cfb2016-08-23 17:51:42 +0200486
danilchap12ba1862016-10-26 02:41:55 -0700487 const auto& packet = transport_.last_sent_packet();
488 uint16_t transport_seq_no;
489 EXPECT_TRUE(packet.GetExtension<TransportSequenceNumber>(&transport_seq_no));
490 EXPECT_EQ(kTransportSequenceNumber, transport_seq_no);
491 EXPECT_EQ(transport_.last_packet_id_, transport_seq_no);
Stefan Holmera246cfb2016-08-23 17:51:42 +0200492}
493
ilnik10894992017-06-21 08:23:19 -0700494TEST_P(RtpSenderTestWithoutPacer, WritesTimestampToTimingExtension) {
ilnik04f4d122017-06-19 07:18:55 -0700495 rtp_sender_->SetStorePacketsStatus(true, 10);
496 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
497 kRtpExtensionVideoTiming, kVideoTimingExtensionId));
498 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
499 auto packet = rtp_sender_->AllocatePacket();
500 packet->SetPayloadType(kPayload);
501 packet->SetMarker(true);
502 packet->SetTimestamp(kTimestamp);
503 packet->set_capture_time_ms(capture_time_ms);
ilnik2edc6842017-07-06 03:06:50 -0700504 const VideoSendTiming kVideoTiming = {0u, 0u, 0u, 0u, 0u, 0u, true};
ilnik04f4d122017-06-19 07:18:55 -0700505 packet->SetExtension<VideoTimingExtension>(kVideoTiming);
506 EXPECT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
507 size_t packet_size = packet->size();
ilnik04f4d122017-06-19 07:18:55 -0700508
509 const int kStoredTimeInMs = 100;
510 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
511
512 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
513 kAllowRetransmission,
514 RtpPacketSender::kNormalPriority));
515 EXPECT_EQ(1, transport_.packets_sent());
516 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
517
danilchapce251812017-09-11 12:24:41 -0700518 VideoSendTiming video_timing;
519 EXPECT_TRUE(transport_.last_sent_packet().GetExtension<VideoTimingExtension>(
520 &video_timing));
521 EXPECT_EQ(kStoredTimeInMs, video_timing.pacer_exit_delta_ms);
ilnik04f4d122017-06-19 07:18:55 -0700522
523 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
524 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum, capture_time_ms, false,
525 PacedPacketInfo());
526
527 EXPECT_EQ(2, transport_.packets_sent());
528 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
529
danilchapce251812017-09-11 12:24:41 -0700530 EXPECT_TRUE(transport_.last_sent_packet().GetExtension<VideoTimingExtension>(
531 &video_timing));
532 EXPECT_EQ(kStoredTimeInMs * 2, video_timing.pacer_exit_delta_ms);
ilnik04f4d122017-06-19 07:18:55 -0700533}
534
minyue3a407ee2017-04-03 01:10:33 -0700535TEST_P(RtpSenderTest, TrafficSmoothingWithExtensions) {
Peter Boströme23e7372015-10-08 11:44:14 +0200536 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kNormalPriority,
brandtr9dfff292016-11-14 05:14:50 -0800537 kSsrc, kSeqNum, _, _, _));
Elad Alon4a87e1c2017-10-03 16:11:34 +0200538 EXPECT_CALL(mock_rtc_event_log_,
539 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)));
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000540
pwestin@webrtc.orgc66e8b32012-11-07 17:01:04 +0000541 rtp_sender_->SetStorePacketsStatus(true, 10);
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000542 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
danilchap162abd32015-12-10 02:39:40 -0800543 kRtpExtensionTransmissionTimeOffset,
544 kTransmissionTimeOffsetExtensionId));
545 EXPECT_EQ(
546 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
547 kAbsoluteSendTimeExtensionId));
stefan@webrtc.org8ccb9f92013-06-19 14:13:42 +0000548 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
danilchapb6f1fb52016-10-19 06:11:39 -0700549 auto packet =
550 BuildRtpPacket(kPayload, kMarkerBit, kTimestamp, capture_time_ms);
551 size_t packet_size = packet->size();
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000552
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000553 // Packet should be stored in a send bucket.
danilchapb6f1fb52016-10-19 06:11:39 -0700554 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
555 kAllowRetransmission,
Sergey Ulanov525df3f2016-08-02 17:46:41 -0700556 RtpPacketSender::kNormalPriority));
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000557
danilchap12ba1862016-10-26 02:41:55 -0700558 EXPECT_EQ(0, transport_.packets_sent());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000559
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000560 const int kStoredTimeInMs = 100;
stefan@webrtc.orga678a3b2013-01-21 07:42:11 +0000561 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000562
brandtr9dfff292016-11-14 05:14:50 -0800563 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum, capture_time_ms, false,
philipel8aadd502017-02-23 02:56:13 -0800564 PacedPacketInfo());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000565
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000566 // Process send bucket. Packet should now be sent.
danilchap12ba1862016-10-26 02:41:55 -0700567 EXPECT_EQ(1, transport_.packets_sent());
568 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
569
stefan@webrtc.orga5cb98c2013-05-29 12:12:51 +0000570 webrtc::RTPHeader rtp_header;
danilchap12ba1862016-10-26 02:41:55 -0700571 transport_.last_sent_packet().GetHeader(&rtp_header);
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000572
573 // Verify transmission time offset.
574 EXPECT_EQ(kStoredTimeInMs * 90, rtp_header.extension.transmissionTimeOffset);
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000575 uint64_t expected_send_time =
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000576 ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds());
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000577 EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime);
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000578}
579
minyue3a407ee2017-04-03 01:10:33 -0700580TEST_P(RtpSenderTest, TrafficSmoothingRetransmits) {
Peter Boströme23e7372015-10-08 11:44:14 +0200581 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kNormalPriority,
brandtr9dfff292016-11-14 05:14:50 -0800582 kSsrc, kSeqNum, _, _, _));
Elad Alon4a87e1c2017-10-03 16:11:34 +0200583 EXPECT_CALL(mock_rtc_event_log_,
584 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)));
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000585
586 rtp_sender_->SetStorePacketsStatus(true, 10);
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000587 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
danilchap162abd32015-12-10 02:39:40 -0800588 kRtpExtensionTransmissionTimeOffset,
589 kTransmissionTimeOffsetExtensionId));
590 EXPECT_EQ(
591 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
592 kAbsoluteSendTimeExtensionId));
stefan@webrtc.org8ccb9f92013-06-19 14:13:42 +0000593 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
danilchapb6f1fb52016-10-19 06:11:39 -0700594 auto packet =
595 BuildRtpPacket(kPayload, kMarkerBit, kTimestamp, capture_time_ms);
596 size_t packet_size = packet->size();
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000597
598 // Packet should be stored in a send bucket.
danilchapb6f1fb52016-10-19 06:11:39 -0700599 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
600 kAllowRetransmission,
Sergey Ulanov525df3f2016-08-02 17:46:41 -0700601 RtpPacketSender::kNormalPriority));
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000602
danilchap12ba1862016-10-26 02:41:55 -0700603 EXPECT_EQ(0, transport_.packets_sent());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000604
terelius5d332ac2016-01-14 14:37:39 -0800605 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kNormalPriority,
brandtr9dfff292016-11-14 05:14:50 -0800606 kSsrc, kSeqNum, _, _, _));
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000607
608 const int kStoredTimeInMs = 100;
609 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
610
danilchapb6f1fb52016-10-19 06:11:39 -0700611 EXPECT_EQ(static_cast<int>(packet_size), rtp_sender_->ReSendPacket(kSeqNum));
danilchap12ba1862016-10-26 02:41:55 -0700612 EXPECT_EQ(0, transport_.packets_sent());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000613
brandtr9dfff292016-11-14 05:14:50 -0800614 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum, capture_time_ms, false,
philipel8aadd502017-02-23 02:56:13 -0800615 PacedPacketInfo());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000616
617 // Process send bucket. Packet should now be sent.
danilchap12ba1862016-10-26 02:41:55 -0700618 EXPECT_EQ(1, transport_.packets_sent());
619 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000620
stefan@webrtc.orga5cb98c2013-05-29 12:12:51 +0000621 webrtc::RTPHeader rtp_header;
danilchap12ba1862016-10-26 02:41:55 -0700622 transport_.last_sent_packet().GetHeader(&rtp_header);
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000623
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000624 // Verify transmission time offset.
625 EXPECT_EQ(kStoredTimeInMs * 90, rtp_header.extension.transmissionTimeOffset);
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000626 uint64_t expected_send_time =
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000627 ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds());
628 EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime);
629}
630
631// This test sends 1 regular video packet, then 4 padding packets, and then
632// 1 more regular packet.
minyue3a407ee2017-04-03 01:10:33 -0700633TEST_P(RtpSenderTest, SendPadding) {
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000634 // Make all (non-padding) packets go to send queue.
terelius5d332ac2016-01-14 14:37:39 -0800635 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kNormalPriority,
brandtr9dfff292016-11-14 05:14:50 -0800636 kSsrc, kSeqNum, _, _, _));
Elad Alon4a87e1c2017-10-03 16:11:34 +0200637 EXPECT_CALL(mock_rtc_event_log_,
638 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
639 .Times(1 + 4 + 1);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000640
641 uint16_t seq_num = kSeqNum;
642 uint32_t timestamp = kTimestamp;
643 rtp_sender_->SetStorePacketsStatus(true, 10);
pkasting@chromium.org4591fbd2014-11-20 22:28:14 +0000644 size_t rtp_header_len = kRtpHeaderSize;
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000645 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
danilchap162abd32015-12-10 02:39:40 -0800646 kRtpExtensionTransmissionTimeOffset,
647 kTransmissionTimeOffsetExtensionId));
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000648 rtp_header_len += 4; // 4 bytes extension.
danilchap162abd32015-12-10 02:39:40 -0800649 EXPECT_EQ(
650 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
651 kAbsoluteSendTimeExtensionId));
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000652 rtp_header_len += 4; // 4 bytes extension.
653 rtp_header_len += 4; // 4 extra bytes common to all extension headers.
654
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000655 webrtc::RTPHeader rtp_header;
656
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000657 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
danilchapb6f1fb52016-10-19 06:11:39 -0700658 auto packet =
659 BuildRtpPacket(kPayload, kMarkerBit, timestamp, capture_time_ms);
Stefan Holmer586b19b2015-09-18 11:14:31 +0200660 const uint32_t media_packet_timestamp = timestamp;
danilchapb6f1fb52016-10-19 06:11:39 -0700661 size_t packet_size = packet->size();
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000662
663 // Packet should be stored in a send bucket.
danilchapb6f1fb52016-10-19 06:11:39 -0700664 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
665 kAllowRetransmission,
Sergey Ulanov525df3f2016-08-02 17:46:41 -0700666 RtpPacketSender::kNormalPriority));
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000667
668 int total_packets_sent = 0;
danilchap12ba1862016-10-26 02:41:55 -0700669 EXPECT_EQ(total_packets_sent, transport_.packets_sent());
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000670
671 const int kStoredTimeInMs = 100;
672 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
brandtr9dfff292016-11-14 05:14:50 -0800673 rtp_sender_->TimeToSendPacket(kSsrc, seq_num++, capture_time_ms, false,
philipel8aadd502017-02-23 02:56:13 -0800674 PacedPacketInfo());
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000675 // Packet should now be sent. This test doesn't verify the regular video
676 // packet, since it is tested in another test.
danilchap12ba1862016-10-26 02:41:55 -0700677 EXPECT_EQ(++total_packets_sent, transport_.packets_sent());
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000678 timestamp += 90 * kStoredTimeInMs;
679
680 // Send padding 4 times, waiting 50 ms between each.
681 for (int i = 0; i < 4; ++i) {
682 const int kPaddingPeriodMs = 50;
pkasting@chromium.org4591fbd2014-11-20 22:28:14 +0000683 const size_t kPaddingBytes = 100;
684 const size_t kMaxPaddingLength = 224; // Value taken from rtp_sender.cc.
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000685 // Padding will be forced to full packets.
philipelc7bf32a2017-02-17 03:59:43 -0800686 EXPECT_EQ(kMaxPaddingLength,
philipel8aadd502017-02-23 02:56:13 -0800687 rtp_sender_->TimeToSendPadding(kPaddingBytes, PacedPacketInfo()));
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000688
689 // Process send bucket. Padding should now be sent.
danilchap12ba1862016-10-26 02:41:55 -0700690 EXPECT_EQ(++total_packets_sent, transport_.packets_sent());
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000691 EXPECT_EQ(kMaxPaddingLength + rtp_header_len,
danilchap12ba1862016-10-26 02:41:55 -0700692 transport_.last_sent_packet().size());
693
694 transport_.last_sent_packet().GetHeader(&rtp_header);
pbosbd2522a2015-07-01 05:35:53 -0700695 EXPECT_EQ(kMaxPaddingLength, rtp_header.paddingLength);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000696
Stefan Holmer586b19b2015-09-18 11:14:31 +0200697 // Verify sequence number and timestamp. The timestamp should be the same
698 // as the last media packet.
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000699 EXPECT_EQ(seq_num++, rtp_header.sequenceNumber);
Stefan Holmer586b19b2015-09-18 11:14:31 +0200700 EXPECT_EQ(media_packet_timestamp, rtp_header.timestamp);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000701 // Verify transmission time offset.
Stefan Holmer586b19b2015-09-18 11:14:31 +0200702 int offset = timestamp - media_packet_timestamp;
703 EXPECT_EQ(offset, rtp_header.extension.transmissionTimeOffset);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000704 uint64_t expected_send_time =
705 ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds());
706 EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime);
707 fake_clock_.AdvanceTimeMilliseconds(kPaddingPeriodMs);
708 timestamp += 90 * kPaddingPeriodMs;
709 }
710
711 // Send a regular video packet again.
712 capture_time_ms = fake_clock_.TimeInMilliseconds();
danilchapb6f1fb52016-10-19 06:11:39 -0700713 packet = BuildRtpPacket(kPayload, kMarkerBit, timestamp, capture_time_ms);
714 packet_size = packet->size();
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000715
brandtr9dfff292016-11-14 05:14:50 -0800716 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kNormalPriority,
717 kSsrc, seq_num, _, _, _));
terelius5d332ac2016-01-14 14:37:39 -0800718
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000719 // Packet should be stored in a send bucket.
danilchapb6f1fb52016-10-19 06:11:39 -0700720 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
721 kAllowRetransmission,
Sergey Ulanov525df3f2016-08-02 17:46:41 -0700722 RtpPacketSender::kNormalPriority));
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000723
brandtr9dfff292016-11-14 05:14:50 -0800724 rtp_sender_->TimeToSendPacket(kSsrc, seq_num, capture_time_ms, false,
philipel8aadd502017-02-23 02:56:13 -0800725 PacedPacketInfo());
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000726 // Process send bucket.
danilchap12ba1862016-10-26 02:41:55 -0700727 EXPECT_EQ(++total_packets_sent, transport_.packets_sent());
728 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
729 transport_.last_sent_packet().GetHeader(&rtp_header);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000730
731 // Verify sequence number and timestamp.
732 EXPECT_EQ(seq_num, rtp_header.sequenceNumber);
733 EXPECT_EQ(timestamp, rtp_header.timestamp);
734 // Verify transmission time offset. This packet is sent without delay.
735 EXPECT_EQ(0, rtp_header.extension.transmissionTimeOffset);
736 uint64_t expected_send_time =
737 ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds());
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000738 EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime);
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000739}
pbos@webrtc.org8911ce42013-03-18 16:39:03 +0000740
minyue3a407ee2017-04-03 01:10:33 -0700741TEST_P(RtpSenderTest, OnSendPacketUpdated) {
stefana23fc622016-07-28 07:56:38 -0700742 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
743 kRtpExtensionTransportSequenceNumber,
744 kTransportSequenceNumberExtensionId));
asapersson35151f32016-05-02 23:44:01 -0700745 rtp_sender_->SetStorePacketsStatus(true, 10);
746
747 EXPECT_CALL(send_packet_observer_,
748 OnSendPacket(kTransportSequenceNumber, _, _))
749 .Times(1);
750 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
751 .WillOnce(testing::Return(kTransportSequenceNumber));
brandtr9dfff292016-11-14 05:14:50 -0800752 EXPECT_CALL(mock_paced_sender_, InsertPacket(_, kSsrc, kSeqNum, _, _, _))
753 .Times(1);
asapersson35151f32016-05-02 23:44:01 -0700754
755 SendGenericPayload(); // Packet passed to pacer.
756 const bool kIsRetransmit = false;
brandtr9dfff292016-11-14 05:14:50 -0800757 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum,
758 fake_clock_.TimeInMilliseconds(), kIsRetransmit,
philipel8aadd502017-02-23 02:56:13 -0800759 PacedPacketInfo());
danilchap12ba1862016-10-26 02:41:55 -0700760 EXPECT_EQ(1, transport_.packets_sent());
asapersson35151f32016-05-02 23:44:01 -0700761}
762
minyue3a407ee2017-04-03 01:10:33 -0700763TEST_P(RtpSenderTest, OnSendPacketNotUpdatedForRetransmits) {
stefana23fc622016-07-28 07:56:38 -0700764 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
765 kRtpExtensionTransportSequenceNumber,
766 kTransportSequenceNumberExtensionId));
asapersson35151f32016-05-02 23:44:01 -0700767 rtp_sender_->SetStorePacketsStatus(true, 10);
768
769 EXPECT_CALL(send_packet_observer_, OnSendPacket(_, _, _)).Times(0);
770 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
771 .WillOnce(testing::Return(kTransportSequenceNumber));
brandtr9dfff292016-11-14 05:14:50 -0800772 EXPECT_CALL(mock_paced_sender_, InsertPacket(_, kSsrc, kSeqNum, _, _, _))
773 .Times(1);
asapersson35151f32016-05-02 23:44:01 -0700774
775 SendGenericPayload(); // Packet passed to pacer.
776 const bool kIsRetransmit = true;
brandtr9dfff292016-11-14 05:14:50 -0800777 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum,
778 fake_clock_.TimeInMilliseconds(), kIsRetransmit,
philipel8aadd502017-02-23 02:56:13 -0800779 PacedPacketInfo());
danilchap12ba1862016-10-26 02:41:55 -0700780 EXPECT_EQ(1, transport_.packets_sent());
asapersson35151f32016-05-02 23:44:01 -0700781}
782
minyue3a407ee2017-04-03 01:10:33 -0700783TEST_P(RtpSenderTest, OnSendPacketNotUpdatedWithoutSeqNumAllocator) {
asapersson35151f32016-05-02 23:44:01 -0700784 rtp_sender_.reset(new RTPSender(
brandtrdbdb3f12016-11-10 05:04:48 -0800785 false, &fake_clock_, &transport_, &mock_paced_sender_, nullptr,
asapersson35151f32016-05-02 23:44:01 -0700786 nullptr /* TransportSequenceNumberAllocator */, nullptr, nullptr, nullptr,
michaelt4da30442016-11-17 01:38:43 -0800787 nullptr, nullptr, &send_packet_observer_, &retransmission_rate_limiter_,
788 nullptr));
brandtr9dfff292016-11-14 05:14:50 -0800789 rtp_sender_->SetSequenceNumber(kSeqNum);
790 rtp_sender_->SetSSRC(kSsrc);
stefana23fc622016-07-28 07:56:38 -0700791 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
792 kRtpExtensionTransportSequenceNumber,
793 kTransportSequenceNumberExtensionId));
asapersson35151f32016-05-02 23:44:01 -0700794 rtp_sender_->SetSequenceNumber(kSeqNum);
795 rtp_sender_->SetStorePacketsStatus(true, 10);
796
797 EXPECT_CALL(send_packet_observer_, OnSendPacket(_, _, _)).Times(0);
brandtr9dfff292016-11-14 05:14:50 -0800798 EXPECT_CALL(mock_paced_sender_, InsertPacket(_, kSsrc, kSeqNum, _, _, _))
799 .Times(1);
asapersson35151f32016-05-02 23:44:01 -0700800
801 SendGenericPayload(); // Packet passed to pacer.
802 const bool kIsRetransmit = false;
brandtr9dfff292016-11-14 05:14:50 -0800803 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum,
804 fake_clock_.TimeInMilliseconds(), kIsRetransmit,
philipel8aadd502017-02-23 02:56:13 -0800805 PacedPacketInfo());
danilchap12ba1862016-10-26 02:41:55 -0700806 EXPECT_EQ(1, transport_.packets_sent());
asapersson35151f32016-05-02 23:44:01 -0700807}
808
minyue3a407ee2017-04-03 01:10:33 -0700809TEST_P(RtpSenderTest, SendRedundantPayloads) {
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000810 MockTransport transport;
terelius429c3452016-01-21 05:42:04 -0800811 rtp_sender_.reset(new RTPSender(
asapersson35151f32016-05-02 23:44:01 -0700812 false, &fake_clock_, &transport, &mock_paced_sender_, nullptr, nullptr,
brandtrdbdb3f12016-11-10 05:04:48 -0800813 nullptr, nullptr, nullptr, nullptr, &mock_rtc_event_log_, nullptr,
michaelt4da30442016-11-17 01:38:43 -0800814 &retransmission_rate_limiter_, nullptr));
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000815 rtp_sender_->SetSequenceNumber(kSeqNum);
brandtr9dfff292016-11-14 05:14:50 -0800816 rtp_sender_->SetSSRC(kSsrc);
Shao Changbine62202f2015-04-21 20:24:50 +0800817 rtp_sender_->SetRtxPayloadType(kRtxPayload, kPayload);
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000818
819 uint16_t seq_num = kSeqNum;
820 rtp_sender_->SetStorePacketsStatus(true, 10);
wu@webrtc.orgebdb0e32014-03-06 23:49:08 +0000821 int32_t rtp_header_len = kRtpHeaderSize;
danilchap162abd32015-12-10 02:39:40 -0800822 EXPECT_EQ(
823 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
824 kAbsoluteSendTimeExtensionId));
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000825 rtp_header_len += 4; // 4 bytes extension.
826 rtp_header_len += 4; // 4 extra bytes common to all extension headers.
827
pbos@webrtc.org0b0c2412015-01-13 14:15:15 +0000828 rtp_sender_->SetRtxStatus(kRtxRetransmitted | kRtxRedundantPayloads);
stefan@webrtc.orgef927552014-06-05 08:25:29 +0000829 rtp_sender_->SetRtxSsrc(1234);
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000830
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000831 const size_t kNumPayloadSizes = 10;
danilchap162abd32015-12-10 02:39:40 -0800832 const size_t kPayloadSizes[kNumPayloadSizes] = {500, 550, 600, 650, 700,
833 750, 800, 850, 900, 950};
terelius5d332ac2016-01-14 14:37:39 -0800834 // Expect all packets go through the pacer.
835 EXPECT_CALL(mock_paced_sender_,
brandtr9dfff292016-11-14 05:14:50 -0800836 InsertPacket(RtpPacketSender::kNormalPriority, kSsrc, _, _, _, _))
terelius5d332ac2016-01-14 14:37:39 -0800837 .Times(kNumPayloadSizes);
Elad Alon4a87e1c2017-10-03 16:11:34 +0200838 EXPECT_CALL(mock_rtc_event_log_,
839 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
terelius429c3452016-01-21 05:42:04 -0800840 .Times(kNumPayloadSizes);
841
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000842 // Send 10 packets of increasing size.
843 for (size_t i = 0; i < kNumPayloadSizes; ++i) {
844 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
stefan1d8a5062015-10-02 03:39:33 -0700845 EXPECT_CALL(transport, SendRtp(_, _, _)).WillOnce(testing::Return(true));
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000846 SendPacket(capture_time_ms, kPayloadSizes[i]);
brandtr9dfff292016-11-14 05:14:50 -0800847 rtp_sender_->TimeToSendPacket(kSsrc, seq_num++, capture_time_ms, false,
philipel8aadd502017-02-23 02:56:13 -0800848 PacedPacketInfo());
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000849 fake_clock_.AdvanceTimeMilliseconds(33);
850 }
terelius429c3452016-01-21 05:42:04 -0800851
Elad Alon4a87e1c2017-10-03 16:11:34 +0200852 EXPECT_CALL(mock_rtc_event_log_,
853 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
terelius429c3452016-01-21 05:42:04 -0800854 .Times(::testing::AtLeast(4));
855
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000856 // The amount of padding to send it too small to send a payload packet.
stefan1d8a5062015-10-02 03:39:33 -0700857 EXPECT_CALL(transport, SendRtp(_, kMaxPaddingSize + rtp_header_len, _))
pbos2d566682015-09-28 09:59:31 -0700858 .WillOnce(testing::Return(true));
philipela1ed0b32016-06-01 06:31:17 -0700859 EXPECT_EQ(kMaxPaddingSize,
philipel8aadd502017-02-23 02:56:13 -0800860 rtp_sender_->TimeToSendPadding(49, PacedPacketInfo()));
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000861
Peter Boströmac547a62015-09-17 23:03:57 +0200862 EXPECT_CALL(transport,
stefan1d8a5062015-10-02 03:39:33 -0700863 SendRtp(_, kPayloadSizes[0] + rtp_header_len + kRtxHeaderSize, _))
pbos2d566682015-09-28 09:59:31 -0700864 .WillOnce(testing::Return(true));
philipela1ed0b32016-06-01 06:31:17 -0700865 EXPECT_EQ(kPayloadSizes[0],
philipel8aadd502017-02-23 02:56:13 -0800866 rtp_sender_->TimeToSendPadding(500, PacedPacketInfo()));
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000867
pbos2d566682015-09-28 09:59:31 -0700868 EXPECT_CALL(transport, SendRtp(_, kPayloadSizes[kNumPayloadSizes - 1] +
stefan1d8a5062015-10-02 03:39:33 -0700869 rtp_header_len + kRtxHeaderSize,
870 _))
pbos2d566682015-09-28 09:59:31 -0700871 .WillOnce(testing::Return(true));
stefan1d8a5062015-10-02 03:39:33 -0700872 EXPECT_CALL(transport, SendRtp(_, kMaxPaddingSize + rtp_header_len, _))
pbos2d566682015-09-28 09:59:31 -0700873 .WillOnce(testing::Return(true));
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +0000874 EXPECT_EQ(kPayloadSizes[kNumPayloadSizes - 1] + kMaxPaddingSize,
philipel8aadd502017-02-23 02:56:13 -0800875 rtp_sender_->TimeToSendPadding(999, PacedPacketInfo()));
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000876}
877
minyue3a407ee2017-04-03 01:10:33 -0700878TEST_P(RtpSenderTestWithoutPacer, SendGenericVideo) {
pbos@webrtc.org8911ce42013-03-18 16:39:03 +0000879 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
880 const uint8_t payload_type = 127;
881 ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 90000,
882 0, 1500));
883 uint8_t payload[] = {47, 11, 32, 93, 89};
884
885 // Send keyframe
spranga8ae6f22017-09-04 07:23:56 -0700886 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
887 kVideoFrameKey, payload_type, 1234, 4321, payload, sizeof(payload),
888 nullptr, nullptr, nullptr, kDefaultExpectedRetransmissionTimeMs));
pbos@webrtc.org8911ce42013-03-18 16:39:03 +0000889
danilchap96c15872016-11-21 01:35:29 -0800890 auto sent_payload = transport_.last_sent_packet().payload();
891 uint8_t generic_header = sent_payload[0];
pbos@webrtc.org8911ce42013-03-18 16:39:03 +0000892 EXPECT_TRUE(generic_header & RtpFormatVideoGeneric::kKeyFrameBit);
893 EXPECT_TRUE(generic_header & RtpFormatVideoGeneric::kFirstPacketBit);
danilchap96c15872016-11-21 01:35:29 -0800894 EXPECT_THAT(sent_payload.subview(1), ElementsAreArray(payload));
pbos@webrtc.org8911ce42013-03-18 16:39:03 +0000895
896 // Send delta frame
897 payload[0] = 13;
898 payload[1] = 42;
899 payload[4] = 13;
900
Sergey Ulanov525df3f2016-08-02 17:46:41 -0700901 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
902 kVideoFrameDelta, payload_type, 1234, 4321, payload, sizeof(payload),
spranga8ae6f22017-09-04 07:23:56 -0700903 nullptr, nullptr, nullptr, kDefaultExpectedRetransmissionTimeMs));
pbos@webrtc.org8911ce42013-03-18 16:39:03 +0000904
danilchap96c15872016-11-21 01:35:29 -0800905 sent_payload = transport_.last_sent_packet().payload();
906 generic_header = sent_payload[0];
pbos@webrtc.org8911ce42013-03-18 16:39:03 +0000907 EXPECT_FALSE(generic_header & RtpFormatVideoGeneric::kKeyFrameBit);
908 EXPECT_TRUE(generic_header & RtpFormatVideoGeneric::kFirstPacketBit);
danilchap96c15872016-11-21 01:35:29 -0800909 EXPECT_THAT(sent_payload.subview(1), ElementsAreArray(payload));
pbos@webrtc.org8911ce42013-03-18 16:39:03 +0000910}
911
minyue3a407ee2017-04-03 01:10:33 -0700912TEST_P(RtpSenderTest, SendFlexfecPackets) {
brandtrdbdb3f12016-11-10 05:04:48 -0800913 constexpr int kMediaPayloadType = 127;
914 constexpr int kFlexfecPayloadType = 118;
915 constexpr uint32_t kMediaSsrc = 1234;
916 constexpr uint32_t kFlexfecSsrc = 5678;
917 const std::vector<RtpExtension> kNoRtpExtensions;
erikvarga27883732017-05-17 05:08:38 -0700918 const std::vector<RtpExtensionSize> kNoRtpExtensionSizes;
brandtrdbdb3f12016-11-10 05:04:48 -0800919 FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexfecSsrc, kMediaSsrc,
erikvarga27883732017-05-17 05:08:38 -0700920 kNoRtpExtensions, kNoRtpExtensionSizes,
brandtr48d21a22017-05-30 02:32:12 -0700921 nullptr /* rtp_state */, &fake_clock_);
brandtrdbdb3f12016-11-10 05:04:48 -0800922
923 // Reset |rtp_sender_| to use FlexFEC.
michaelt4da30442016-11-17 01:38:43 -0800924 rtp_sender_.reset(new RTPSender(
925 false, &fake_clock_, &transport_, &mock_paced_sender_, &flexfec_sender,
926 &seq_num_allocator_, nullptr, nullptr, nullptr, nullptr,
927 &mock_rtc_event_log_, &send_packet_observer_,
928 &retransmission_rate_limiter_, nullptr));
brandtrdbdb3f12016-11-10 05:04:48 -0800929 rtp_sender_->SetSSRC(kMediaSsrc);
930 rtp_sender_->SetSequenceNumber(kSeqNum);
931 rtp_sender_->SetSendPayloadType(kMediaPayloadType);
932 rtp_sender_->SetStorePacketsStatus(true, 10);
933
934 // Parameters selected to generate a single FEC packet per media packet.
935 FecProtectionParams params;
936 params.fec_rate = 15;
937 params.max_fec_frames = 1;
938 params.fec_mask_type = kFecMaskRandom;
939 rtp_sender_->SetFecParameters(params, params);
940
brandtr9dfff292016-11-14 05:14:50 -0800941 EXPECT_CALL(mock_paced_sender_,
942 InsertPacket(RtpPacketSender::kLowPriority, kMediaSsrc, kSeqNum,
943 _, _, false));
944 uint16_t flexfec_seq_num;
brandtrdbdb3f12016-11-10 05:04:48 -0800945 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kLowPriority,
brandtr9dfff292016-11-14 05:14:50 -0800946 kFlexfecSsrc, _, _, _, false))
947 .WillOnce(testing::SaveArg<2>(&flexfec_seq_num));
brandtrdbdb3f12016-11-10 05:04:48 -0800948 SendGenericPayload();
Elad Alon4a87e1c2017-10-03 16:11:34 +0200949 EXPECT_CALL(mock_rtc_event_log_,
950 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
951 .Times(2);
philipel8aadd502017-02-23 02:56:13 -0800952 EXPECT_TRUE(rtp_sender_->TimeToSendPacket(kMediaSsrc, kSeqNum,
953 fake_clock_.TimeInMilliseconds(),
954 false, PacedPacketInfo()));
brandtr9dfff292016-11-14 05:14:50 -0800955 EXPECT_TRUE(rtp_sender_->TimeToSendPacket(kFlexfecSsrc, flexfec_seq_num,
956 fake_clock_.TimeInMilliseconds(),
philipel8aadd502017-02-23 02:56:13 -0800957 false, PacedPacketInfo()));
brandtr9dfff292016-11-14 05:14:50 -0800958 ASSERT_EQ(2, transport_.packets_sent());
brandtrdbdb3f12016-11-10 05:04:48 -0800959 const RtpPacketReceived& media_packet = transport_.sent_packets_[0];
960 EXPECT_EQ(kMediaPayloadType, media_packet.PayloadType());
brandtr9dfff292016-11-14 05:14:50 -0800961 EXPECT_EQ(kSeqNum, media_packet.SequenceNumber());
brandtrdbdb3f12016-11-10 05:04:48 -0800962 EXPECT_EQ(kMediaSsrc, media_packet.Ssrc());
brandtr9dfff292016-11-14 05:14:50 -0800963 const RtpPacketReceived& flexfec_packet = transport_.sent_packets_[1];
964 EXPECT_EQ(kFlexfecPayloadType, flexfec_packet.PayloadType());
965 EXPECT_EQ(flexfec_seq_num, flexfec_packet.SequenceNumber());
966 EXPECT_EQ(kFlexfecSsrc, flexfec_packet.Ssrc());
brandtrdbdb3f12016-11-10 05:04:48 -0800967}
968
ilnik10894992017-06-21 08:23:19 -0700969// TODO(ilnik): because of webrtc:7859. Once FEC moved below pacer, this test
970// should be removed.
971TEST_P(RtpSenderTest, NoFlexfecForTimingFrames) {
972 constexpr int kMediaPayloadType = 127;
973 constexpr int kFlexfecPayloadType = 118;
974 constexpr uint32_t kMediaSsrc = 1234;
975 constexpr uint32_t kFlexfecSsrc = 5678;
976 const std::vector<RtpExtension> kNoRtpExtensions;
977 const std::vector<RtpExtensionSize> kNoRtpExtensionSizes;
ilnike4350192017-06-29 02:27:44 -0700978
ilnik10894992017-06-21 08:23:19 -0700979 FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexfecSsrc, kMediaSsrc,
980 kNoRtpExtensions, kNoRtpExtensionSizes,
981 nullptr /* rtp_state */, &fake_clock_);
982
983 // Reset |rtp_sender_| to use FlexFEC.
984 rtp_sender_.reset(new RTPSender(
985 false, &fake_clock_, &transport_, &mock_paced_sender_, &flexfec_sender,
986 &seq_num_allocator_, nullptr, nullptr, nullptr, nullptr,
987 &mock_rtc_event_log_, &send_packet_observer_,
988 &retransmission_rate_limiter_, nullptr));
989 rtp_sender_->SetSSRC(kMediaSsrc);
990 rtp_sender_->SetSequenceNumber(kSeqNum);
991 rtp_sender_->SetSendPayloadType(kMediaPayloadType);
992 rtp_sender_->SetStorePacketsStatus(true, 10);
993
ilnike4350192017-06-29 02:27:44 -0700994 // Need extension to be registered for timing frames to be sent.
995 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
996 kRtpExtensionVideoTiming, kVideoTimingExtensionId));
997
ilnik10894992017-06-21 08:23:19 -0700998 // Parameters selected to generate a single FEC packet per media packet.
999 FecProtectionParams params;
1000 params.fec_rate = 15;
1001 params.max_fec_frames = 1;
1002 params.fec_mask_type = kFecMaskRandom;
1003 rtp_sender_->SetFecParameters(params, params);
1004
1005 EXPECT_CALL(mock_paced_sender_,
1006 InsertPacket(RtpPacketSender::kLowPriority, kMediaSsrc, kSeqNum,
1007 _, _, false));
1008 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kLowPriority,
1009 kFlexfecSsrc, _, _, _, false))
1010 .Times(0); // Not called because packet should not be protected.
1011
1012 const uint32_t kTimestamp = 1234;
1013 const uint8_t kPayloadType = 127;
1014 const int64_t kCaptureTimeMs = fake_clock_.TimeInMilliseconds();
1015 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
1016 EXPECT_EQ(0, rtp_sender_->RegisterPayload(payload_name, kPayloadType, 90000,
1017 0, 1500));
1018 RTPVideoHeader video_header;
1019 memset(&video_header, 0, sizeof(RTPVideoHeader));
sprangba050a62017-08-18 02:51:12 -07001020 video_header.video_timing.flags = TimingFrameFlags::kTriggeredByTimer;
ilnik10894992017-06-21 08:23:19 -07001021 EXPECT_TRUE(rtp_sender_->SendOutgoingData(
1022 kVideoFrameKey, kPayloadType, kTimestamp, kCaptureTimeMs, kPayloadData,
spranga8ae6f22017-09-04 07:23:56 -07001023 sizeof(kPayloadData), nullptr, &video_header, nullptr,
1024 kDefaultExpectedRetransmissionTimeMs));
ilnik10894992017-06-21 08:23:19 -07001025
Elad Alon4a87e1c2017-10-03 16:11:34 +02001026 EXPECT_CALL(mock_rtc_event_log_,
1027 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
1028 .Times(1);
ilnik10894992017-06-21 08:23:19 -07001029 EXPECT_TRUE(rtp_sender_->TimeToSendPacket(kMediaSsrc, kSeqNum,
1030 fake_clock_.TimeInMilliseconds(),
1031 false, PacedPacketInfo()));
1032 ASSERT_EQ(1, transport_.packets_sent());
1033 const RtpPacketReceived& media_packet = transport_.sent_packets_[0];
1034 EXPECT_EQ(kMediaPayloadType, media_packet.PayloadType());
1035 EXPECT_EQ(kSeqNum, media_packet.SequenceNumber());
1036 EXPECT_EQ(kMediaSsrc, media_packet.Ssrc());
1037
1038 // Now try to send not a timing frame.
1039 uint16_t flexfec_seq_num;
1040 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kLowPriority,
1041 kFlexfecSsrc, _, _, _, false))
1042 .WillOnce(testing::SaveArg<2>(&flexfec_seq_num));
1043 EXPECT_CALL(mock_paced_sender_,
1044 InsertPacket(RtpPacketSender::kLowPriority, kMediaSsrc,
1045 kSeqNum + 1, _, _, false));
sprangba050a62017-08-18 02:51:12 -07001046 video_header.video_timing.flags = TimingFrameFlags::kInvalid;
ilnik10894992017-06-21 08:23:19 -07001047 EXPECT_TRUE(rtp_sender_->SendOutgoingData(
1048 kVideoFrameKey, kPayloadType, kTimestamp + 1, kCaptureTimeMs + 1,
spranga8ae6f22017-09-04 07:23:56 -07001049 kPayloadData, sizeof(kPayloadData), nullptr, &video_header, nullptr,
1050 kDefaultExpectedRetransmissionTimeMs));
ilnik10894992017-06-21 08:23:19 -07001051
Elad Alon4a87e1c2017-10-03 16:11:34 +02001052 EXPECT_CALL(mock_rtc_event_log_,
1053 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
1054 .Times(2);
ilnik10894992017-06-21 08:23:19 -07001055 EXPECT_TRUE(rtp_sender_->TimeToSendPacket(kMediaSsrc, kSeqNum + 1,
1056 fake_clock_.TimeInMilliseconds(),
1057 false, PacedPacketInfo()));
1058 EXPECT_TRUE(rtp_sender_->TimeToSendPacket(kFlexfecSsrc, flexfec_seq_num,
1059 fake_clock_.TimeInMilliseconds(),
1060 false, PacedPacketInfo()));
1061 ASSERT_EQ(3, transport_.packets_sent());
1062 const RtpPacketReceived& media_packet2 = transport_.sent_packets_[1];
1063 EXPECT_EQ(kMediaPayloadType, media_packet2.PayloadType());
1064 EXPECT_EQ(kSeqNum + 1, media_packet2.SequenceNumber());
1065 EXPECT_EQ(kMediaSsrc, media_packet2.Ssrc());
1066 const RtpPacketReceived& flexfec_packet = transport_.sent_packets_[2];
1067 EXPECT_EQ(kFlexfecPayloadType, flexfec_packet.PayloadType());
1068 EXPECT_EQ(flexfec_seq_num, flexfec_packet.SequenceNumber());
1069 EXPECT_EQ(kFlexfecSsrc, flexfec_packet.Ssrc());
1070}
1071
minyue3a407ee2017-04-03 01:10:33 -07001072TEST_P(RtpSenderTestWithoutPacer, SendFlexfecPackets) {
brandtrdbdb3f12016-11-10 05:04:48 -08001073 constexpr int kMediaPayloadType = 127;
1074 constexpr int kFlexfecPayloadType = 118;
1075 constexpr uint32_t kMediaSsrc = 1234;
1076 constexpr uint32_t kFlexfecSsrc = 5678;
1077 const std::vector<RtpExtension> kNoRtpExtensions;
erikvarga27883732017-05-17 05:08:38 -07001078 const std::vector<RtpExtensionSize> kNoRtpExtensionSizes;
brandtrdbdb3f12016-11-10 05:04:48 -08001079 FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexfecSsrc, kMediaSsrc,
erikvarga27883732017-05-17 05:08:38 -07001080 kNoRtpExtensions, kNoRtpExtensionSizes,
brandtr48d21a22017-05-30 02:32:12 -07001081 nullptr /* rtp_state */, &fake_clock_);
brandtrdbdb3f12016-11-10 05:04:48 -08001082
1083 // Reset |rtp_sender_| to use FlexFEC.
1084 rtp_sender_.reset(new RTPSender(false, &fake_clock_, &transport_, nullptr,
1085 &flexfec_sender, &seq_num_allocator_, nullptr,
1086 nullptr, nullptr, nullptr,
1087 &mock_rtc_event_log_, &send_packet_observer_,
michaelt4da30442016-11-17 01:38:43 -08001088 &retransmission_rate_limiter_, nullptr));
brandtrdbdb3f12016-11-10 05:04:48 -08001089 rtp_sender_->SetSSRC(kMediaSsrc);
1090 rtp_sender_->SetSequenceNumber(kSeqNum);
1091 rtp_sender_->SetSendPayloadType(kMediaPayloadType);
1092
1093 // Parameters selected to generate a single FEC packet per media packet.
1094 FecProtectionParams params;
1095 params.fec_rate = 15;
1096 params.max_fec_frames = 1;
1097 params.fec_mask_type = kFecMaskRandom;
1098 rtp_sender_->SetFecParameters(params, params);
1099
Elad Alon4a87e1c2017-10-03 16:11:34 +02001100 EXPECT_CALL(mock_rtc_event_log_,
1101 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
1102 .Times(2);
brandtrdbdb3f12016-11-10 05:04:48 -08001103 SendGenericPayload();
1104 ASSERT_EQ(2, transport_.packets_sent());
1105 const RtpPacketReceived& media_packet = transport_.sent_packets_[0];
1106 EXPECT_EQ(kMediaPayloadType, media_packet.PayloadType());
1107 EXPECT_EQ(kMediaSsrc, media_packet.Ssrc());
1108 const RtpPacketReceived& flexfec_packet = transport_.sent_packets_[1];
1109 EXPECT_EQ(kFlexfecPayloadType, flexfec_packet.PayloadType());
1110 EXPECT_EQ(kFlexfecSsrc, flexfec_packet.Ssrc());
1111}
1112
minyue3a407ee2017-04-03 01:10:33 -07001113TEST_P(RtpSenderTest, FecOverheadRate) {
brandtr81eab612017-01-24 04:06:09 -08001114 constexpr int kMediaPayloadType = 127;
1115 constexpr int kFlexfecPayloadType = 118;
1116 constexpr uint32_t kMediaSsrc = 1234;
1117 constexpr uint32_t kFlexfecSsrc = 5678;
1118 const std::vector<RtpExtension> kNoRtpExtensions;
erikvarga27883732017-05-17 05:08:38 -07001119 const std::vector<RtpExtensionSize> kNoRtpExtensionSizes;
brandtr81eab612017-01-24 04:06:09 -08001120 FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexfecSsrc, kMediaSsrc,
erikvarga27883732017-05-17 05:08:38 -07001121 kNoRtpExtensions, kNoRtpExtensionSizes,
brandtr48d21a22017-05-30 02:32:12 -07001122 nullptr /* rtp_state */, &fake_clock_);
brandtr81eab612017-01-24 04:06:09 -08001123
1124 // Reset |rtp_sender_| to use FlexFEC.
1125 rtp_sender_.reset(new RTPSender(
1126 false, &fake_clock_, &transport_, &mock_paced_sender_, &flexfec_sender,
1127 &seq_num_allocator_, nullptr, nullptr, nullptr, nullptr,
1128 &mock_rtc_event_log_, &send_packet_observer_,
1129 &retransmission_rate_limiter_, nullptr));
1130 rtp_sender_->SetSSRC(kMediaSsrc);
1131 rtp_sender_->SetSequenceNumber(kSeqNum);
1132 rtp_sender_->SetSendPayloadType(kMediaPayloadType);
1133
1134 // Parameters selected to generate a single FEC packet per media packet.
1135 FecProtectionParams params;
1136 params.fec_rate = 15;
1137 params.max_fec_frames = 1;
1138 params.fec_mask_type = kFecMaskRandom;
1139 rtp_sender_->SetFecParameters(params, params);
1140
1141 constexpr size_t kNumMediaPackets = 10;
1142 constexpr size_t kNumFecPackets = kNumMediaPackets;
1143 constexpr int64_t kTimeBetweenPacketsMs = 10;
1144 EXPECT_CALL(mock_paced_sender_, InsertPacket(_, _, _, _, _, false))
1145 .Times(kNumMediaPackets + kNumFecPackets);
1146 for (size_t i = 0; i < kNumMediaPackets; ++i) {
1147 SendGenericPayload();
1148 fake_clock_.AdvanceTimeMilliseconds(kTimeBetweenPacketsMs);
1149 }
1150 constexpr size_t kRtpHeaderLength = 12;
1151 constexpr size_t kFlexfecHeaderLength = 20;
1152 constexpr size_t kGenericCodecHeaderLength = 1;
1153 constexpr size_t kPayloadLength = sizeof(kPayloadData);
1154 constexpr size_t kPacketLength = kRtpHeaderLength + kFlexfecHeaderLength +
1155 kGenericCodecHeaderLength + kPayloadLength;
1156 EXPECT_NEAR(kNumFecPackets * kPacketLength * 8 /
1157 (kNumFecPackets * kTimeBetweenPacketsMs / 1000.0f),
1158 rtp_sender_->FecOverheadRate(), 500);
1159}
1160
minyue3a407ee2017-04-03 01:10:33 -07001161TEST_P(RtpSenderTest, FrameCountCallbacks) {
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001162 class TestCallback : public FrameCountObserver {
1163 public:
pbos@webrtc.orgce4e9a32014-12-18 13:50:16 +00001164 TestCallback() : FrameCountObserver(), num_calls_(0), ssrc_(0) {}
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001165 virtual ~TestCallback() {}
1166
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00001167 void FrameCountUpdated(const FrameCounts& frame_counts,
1168 uint32_t ssrc) override {
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001169 ++num_calls_;
1170 ssrc_ = ssrc;
pbos@webrtc.orgce4e9a32014-12-18 13:50:16 +00001171 frame_counts_ = frame_counts;
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001172 }
1173
1174 uint32_t num_calls_;
1175 uint32_t ssrc_;
pbos@webrtc.orgce4e9a32014-12-18 13:50:16 +00001176 FrameCounts frame_counts_;
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001177 } callback;
1178
michaelt4da30442016-11-17 01:38:43 -08001179 rtp_sender_.reset(
1180 new RTPSender(false, &fake_clock_, &transport_, &mock_paced_sender_,
1181 nullptr, nullptr, nullptr, nullptr, &callback, nullptr,
1182 nullptr, nullptr, &retransmission_rate_limiter_, nullptr));
nisse7d59f6b2017-02-21 03:40:24 -08001183 rtp_sender_->SetSSRC(kSsrc);
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001184 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
1185 const uint8_t payload_type = 127;
1186 ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 90000,
1187 0, 1500));
1188 uint8_t payload[] = {47, 11, 32, 93, 89};
1189 rtp_sender_->SetStorePacketsStatus(true, 1);
1190 uint32_t ssrc = rtp_sender_->SSRC();
1191
terelius5d332ac2016-01-14 14:37:39 -08001192 EXPECT_CALL(mock_paced_sender_, InsertPacket(_, _, _, _, _, _))
1193 .Times(::testing::AtLeast(2));
1194
spranga8ae6f22017-09-04 07:23:56 -07001195 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
1196 kVideoFrameKey, payload_type, 1234, 4321, payload, sizeof(payload),
1197 nullptr, nullptr, nullptr, kDefaultExpectedRetransmissionTimeMs));
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001198
1199 EXPECT_EQ(1U, callback.num_calls_);
1200 EXPECT_EQ(ssrc, callback.ssrc_);
pbos@webrtc.orgce4e9a32014-12-18 13:50:16 +00001201 EXPECT_EQ(1, callback.frame_counts_.key_frames);
1202 EXPECT_EQ(0, callback.frame_counts_.delta_frames);
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001203
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001204 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
1205 kVideoFrameDelta, payload_type, 1234, 4321, payload, sizeof(payload),
spranga8ae6f22017-09-04 07:23:56 -07001206 nullptr, nullptr, nullptr, kDefaultExpectedRetransmissionTimeMs));
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001207
1208 EXPECT_EQ(2U, callback.num_calls_);
1209 EXPECT_EQ(ssrc, callback.ssrc_);
pbos@webrtc.orgce4e9a32014-12-18 13:50:16 +00001210 EXPECT_EQ(1, callback.frame_counts_.key_frames);
1211 EXPECT_EQ(1, callback.frame_counts_.delta_frames);
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001212
andresp@webrtc.org8f151212014-07-10 09:39:23 +00001213 rtp_sender_.reset();
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001214}
1215
minyue3a407ee2017-04-03 01:10:33 -07001216TEST_P(RtpSenderTest, BitrateCallbacks) {
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001217 class TestCallback : public BitrateStatisticsObserver {
1218 public:
sprangcd349d92016-07-13 09:11:28 -07001219 TestCallback()
1220 : BitrateStatisticsObserver(),
1221 num_calls_(0),
1222 ssrc_(0),
1223 total_bitrate_(0),
1224 retransmit_bitrate_(0) {}
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001225 virtual ~TestCallback() {}
1226
sprangcd349d92016-07-13 09:11:28 -07001227 void Notify(uint32_t total_bitrate,
1228 uint32_t retransmit_bitrate,
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00001229 uint32_t ssrc) override {
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001230 ++num_calls_;
1231 ssrc_ = ssrc;
sprangcd349d92016-07-13 09:11:28 -07001232 total_bitrate_ = total_bitrate;
1233 retransmit_bitrate_ = retransmit_bitrate;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001234 }
1235
1236 uint32_t num_calls_;
1237 uint32_t ssrc_;
sprangcd349d92016-07-13 09:11:28 -07001238 uint32_t total_bitrate_;
1239 uint32_t retransmit_bitrate_;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001240 } callback;
brandtrdbdb3f12016-11-10 05:04:48 -08001241 rtp_sender_.reset(new RTPSender(false, &fake_clock_, &transport_, nullptr,
1242 nullptr, nullptr, nullptr, &callback, nullptr,
1243 nullptr, nullptr, nullptr,
michaelt4da30442016-11-17 01:38:43 -08001244 &retransmission_rate_limiter_, nullptr));
nisse7d59f6b2017-02-21 03:40:24 -08001245 rtp_sender_->SetSSRC(kSsrc);
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001246
sprangcd349d92016-07-13 09:11:28 -07001247 // Simulate kNumPackets sent with kPacketInterval ms intervals, with the
1248 // number of packets selected so that we fill (but don't overflow) the one
1249 // second averaging window.
1250 const uint32_t kWindowSizeMs = 1000;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001251 const uint32_t kPacketInterval = 20;
sprangcd349d92016-07-13 09:11:28 -07001252 const uint32_t kNumPackets =
1253 (kWindowSizeMs - kPacketInterval) / kPacketInterval;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001254 // Overhead = 12 bytes RTP header + 1 byte generic header.
1255 const uint32_t kPacketOverhead = 13;
1256
1257 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
1258 const uint8_t payload_type = 127;
danilchap162abd32015-12-10 02:39:40 -08001259 ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 90000,
1260 0, 1500));
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001261 uint8_t payload[] = {47, 11, 32, 93, 89};
1262 rtp_sender_->SetStorePacketsStatus(true, 1);
1263 uint32_t ssrc = rtp_sender_->SSRC();
1264
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001265 // Initial process call so we get a new time window.
1266 rtp_sender_->ProcessBitrate();
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001267
1268 // Send a few frames.
1269 for (uint32_t i = 0; i < kNumPackets; ++i) {
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001270 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
1271 kVideoFrameKey, payload_type, 1234, 4321, payload, sizeof(payload),
spranga8ae6f22017-09-04 07:23:56 -07001272 nullptr, nullptr, nullptr, kDefaultExpectedRetransmissionTimeMs));
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001273 fake_clock_.AdvanceTimeMilliseconds(kPacketInterval);
1274 }
1275
1276 rtp_sender_->ProcessBitrate();
1277
stefan@webrtc.org0bae1fa2014-11-05 14:05:29 +00001278 // We get one call for every stats updated, thus two calls since both the
1279 // stream stats and the retransmit stats are updated once.
1280 EXPECT_EQ(2u, callback.num_calls_);
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001281 EXPECT_EQ(ssrc, callback.ssrc_);
sprangcd349d92016-07-13 09:11:28 -07001282 const uint32_t kTotalPacketSize = kPacketOverhead + sizeof(payload);
1283 // Bitrate measured over delta between last and first timestamp, plus one.
1284 const uint32_t kExpectedWindowMs = kNumPackets * kPacketInterval + 1;
1285 const uint32_t kExpectedBitsAccumulated = kTotalPacketSize * kNumPackets * 8;
1286 const uint32_t kExpectedRateBps =
1287 (kExpectedBitsAccumulated * 1000 + (kExpectedWindowMs / 2)) /
1288 kExpectedWindowMs;
1289 EXPECT_EQ(kExpectedRateBps, callback.total_bitrate_);
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001290
andresp@webrtc.orgd11bec42014-07-08 14:32:58 +00001291 rtp_sender_.reset();
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001292}
1293
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001294class RtpSenderAudioTest : public RtpSenderTest {
1295 protected:
1296 RtpSenderAudioTest() {}
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001297
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00001298 void SetUp() override {
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001299 payload_ = kAudioPayload;
brandtrdbdb3f12016-11-10 05:04:48 -08001300 rtp_sender_.reset(new RTPSender(true, &fake_clock_, &transport_, nullptr,
1301 nullptr, nullptr, nullptr, nullptr, nullptr,
1302 nullptr, nullptr, nullptr,
michaelt4da30442016-11-17 01:38:43 -08001303 &retransmission_rate_limiter_, nullptr));
nisse7d59f6b2017-02-21 03:40:24 -08001304 rtp_sender_->SetSSRC(kSsrc);
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001305 rtp_sender_->SetSequenceNumber(kSeqNum);
1306 }
1307};
1308
minyue3a407ee2017-04-03 01:10:33 -07001309TEST_P(RtpSenderTestWithoutPacer, StreamDataCountersCallbacks) {
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001310 class TestCallback : public StreamDataCountersCallback {
1311 public:
danilchap162abd32015-12-10 02:39:40 -08001312 TestCallback() : StreamDataCountersCallback(), ssrc_(0), counters_() {}
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001313 virtual ~TestCallback() {}
1314
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00001315 void DataCountersUpdated(const StreamDataCounters& counters,
1316 uint32_t ssrc) override {
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001317 ssrc_ = ssrc;
1318 counters_ = counters;
1319 }
1320
1321 uint32_t ssrc_;
1322 StreamDataCounters counters_;
asapersson@webrtc.org44149392015-02-04 08:34:47 +00001323
1324 void MatchPacketCounter(const RtpPacketCounter& expected,
1325 const RtpPacketCounter& actual) {
1326 EXPECT_EQ(expected.payload_bytes, actual.payload_bytes);
1327 EXPECT_EQ(expected.header_bytes, actual.header_bytes);
1328 EXPECT_EQ(expected.padding_bytes, actual.padding_bytes);
1329 EXPECT_EQ(expected.packets, actual.packets);
1330 }
1331
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001332 void Matches(uint32_t ssrc, const StreamDataCounters& counters) {
1333 EXPECT_EQ(ssrc, ssrc_);
asapersson@webrtc.org44149392015-02-04 08:34:47 +00001334 MatchPacketCounter(counters.transmitted, counters_.transmitted);
1335 MatchPacketCounter(counters.retransmitted, counters_.retransmitted);
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001336 EXPECT_EQ(counters.fec.packets, counters_.fec.packets);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001337 }
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001338 } callback;
1339
1340 const uint8_t kRedPayloadType = 96;
1341 const uint8_t kUlpfecPayloadType = 97;
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001342 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
1343 const uint8_t payload_type = 127;
1344 ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 90000,
1345 0, 1500));
1346 uint8_t payload[] = {47, 11, 32, 93, 89};
1347 rtp_sender_->SetStorePacketsStatus(true, 1);
1348 uint32_t ssrc = rtp_sender_->SSRC();
1349
1350 rtp_sender_->RegisterRtpStatisticsCallback(&callback);
1351
1352 // Send a frame.
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001353 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001354 kVideoFrameKey, payload_type, 1234, 4321, payload, sizeof(payload),
1355 nullptr, nullptr, nullptr, kDefaultExpectedRetransmissionTimeMs));
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001356 StreamDataCounters expected;
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001357 expected.transmitted.payload_bytes = 6;
1358 expected.transmitted.header_bytes = 12;
1359 expected.transmitted.padding_bytes = 0;
1360 expected.transmitted.packets = 1;
1361 expected.retransmitted.payload_bytes = 0;
1362 expected.retransmitted.header_bytes = 0;
1363 expected.retransmitted.padding_bytes = 0;
1364 expected.retransmitted.packets = 0;
1365 expected.fec.packets = 0;
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001366 callback.Matches(ssrc, expected);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001367
1368 // Retransmit a frame.
1369 uint16_t seqno = rtp_sender_->SequenceNumber() - 1;
1370 rtp_sender_->ReSendPacket(seqno, 0);
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001371 expected.transmitted.payload_bytes = 12;
1372 expected.transmitted.header_bytes = 24;
1373 expected.transmitted.packets = 2;
1374 expected.retransmitted.payload_bytes = 6;
1375 expected.retransmitted.header_bytes = 12;
1376 expected.retransmitted.padding_bytes = 0;
1377 expected.retransmitted.packets = 1;
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001378 callback.Matches(ssrc, expected);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001379
1380 // Send padding.
philipel8aadd502017-02-23 02:56:13 -08001381 rtp_sender_->TimeToSendPadding(kMaxPaddingSize, PacedPacketInfo());
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001382 expected.transmitted.payload_bytes = 12;
1383 expected.transmitted.header_bytes = 36;
1384 expected.transmitted.padding_bytes = kMaxPaddingSize;
1385 expected.transmitted.packets = 3;
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001386 callback.Matches(ssrc, expected);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001387
brandtrf1bb4762016-11-07 03:05:06 -08001388 // Send ULPFEC.
1389 rtp_sender_->SetUlpfecConfig(kRedPayloadType, kUlpfecPayloadType);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001390 FecProtectionParams fec_params;
1391 fec_params.fec_mask_type = kFecMaskRandom;
1392 fec_params.fec_rate = 1;
1393 fec_params.max_fec_frames = 1;
brandtr1743a192016-11-07 03:36:05 -08001394 rtp_sender_->SetFecParameters(fec_params, fec_params);
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001395 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001396 kVideoFrameDelta, payload_type, 1234, 4321, payload, sizeof(payload),
1397 nullptr, nullptr, nullptr, kDefaultExpectedRetransmissionTimeMs));
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001398 expected.transmitted.payload_bytes = 40;
1399 expected.transmitted.header_bytes = 60;
1400 expected.transmitted.packets = 5;
1401 expected.fec.packets = 1;
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001402 callback.Matches(ssrc, expected);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001403
sprang867fb522015-08-03 04:38:41 -07001404 rtp_sender_->RegisterRtpStatisticsCallback(nullptr);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001405}
1406
minyue3a407ee2017-04-03 01:10:33 -07001407TEST_P(RtpSenderAudioTest, SendAudio) {
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001408 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "PAYLOAD_NAME";
1409 const uint8_t payload_type = 127;
1410 ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 48000,
1411 0, 1500));
1412 uint8_t payload[] = {47, 11, 32, 93, 89};
1413
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001414 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001415 kAudioFrameCN, payload_type, 1234, 4321, payload, sizeof(payload),
1416 nullptr, nullptr, nullptr, kDefaultExpectedRetransmissionTimeMs));
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001417
danilchap96c15872016-11-21 01:35:29 -08001418 auto sent_payload = transport_.last_sent_packet().payload();
1419 EXPECT_THAT(sent_payload, ElementsAreArray(payload));
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001420}
1421
minyue3a407ee2017-04-03 01:10:33 -07001422TEST_P(RtpSenderAudioTest, SendAudioWithAudioLevelExtension) {
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001423 EXPECT_EQ(0, rtp_sender_->SetAudioLevel(kAudioLevel));
danilchap162abd32015-12-10 02:39:40 -08001424 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAudioLevel,
1425 kAudioLevelExtensionId));
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001426
1427 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "PAYLOAD_NAME";
1428 const uint8_t payload_type = 127;
1429 ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 48000,
1430 0, 1500));
1431 uint8_t payload[] = {47, 11, 32, 93, 89};
1432
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001433 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001434 kAudioFrameCN, payload_type, 1234, 4321, payload, sizeof(payload),
1435 nullptr, nullptr, nullptr, kDefaultExpectedRetransmissionTimeMs));
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001436
danilchap96c15872016-11-21 01:35:29 -08001437 auto sent_payload = transport_.last_sent_packet().payload();
1438 EXPECT_THAT(sent_payload, ElementsAreArray(payload));
danilchap12ba1862016-10-26 02:41:55 -07001439 // Verify AudioLevel extension.
1440 bool voice_activity;
1441 uint8_t audio_level;
1442 EXPECT_TRUE(transport_.last_sent_packet().GetExtension<AudioLevel>(
1443 &voice_activity, &audio_level));
1444 EXPECT_EQ(kAudioLevel, audio_level);
1445 EXPECT_FALSE(voice_activity);
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001446}
1447
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001448// As RFC4733, named telephone events are carried as part of the audio stream
1449// and must use the same sequence number and timestamp base as the regular
1450// audio channel.
1451// This test checks the marker bit for the first packet and the consequent
1452// packets of the same telephone event. Since it is specifically for DTMF
pbos22993e12015-10-19 02:39:06 -07001453// events, ignoring audio packets and sending kEmptyFrame instead of those.
minyue3a407ee2017-04-03 01:10:33 -07001454TEST_P(RtpSenderAudioTest, CheckMarkerBitForTelephoneEvents) {
solenbergffbbcac2016-11-17 05:25:37 -08001455 const char* kDtmfPayloadName = "telephone-event";
1456 const uint32_t kPayloadFrequency = 8000;
1457 const uint8_t kPayloadType = 126;
1458 ASSERT_EQ(0, rtp_sender_->RegisterPayload(kDtmfPayloadName, kPayloadType,
1459 kPayloadFrequency, 0, 0));
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001460 // For Telephone events, payload is not added to the registered payload list,
1461 // it will register only the payload used for audio stream.
1462 // Registering the payload again for audio stream with different payload name.
solenbergffbbcac2016-11-17 05:25:37 -08001463 const char* kPayloadName = "payload_name";
1464 ASSERT_EQ(0, rtp_sender_->RegisterPayload(kPayloadName, kPayloadType,
1465 kPayloadFrequency, 1, 0));
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001466 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
1467 // DTMF event key=9, duration=500 and attenuationdB=10
1468 rtp_sender_->SendTelephoneEvent(9, 500, 10);
1469 // During start, it takes the starting timestamp as last sent timestamp.
1470 // The duration is calculated as the difference of current and last sent
1471 // timestamp. So for first call it will skip since the duration is zero.
spranga8ae6f22017-09-04 07:23:56 -07001472 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
1473 kEmptyFrame, kPayloadType, capture_time_ms, 0, nullptr, 0, nullptr,
1474 nullptr, nullptr, kDefaultExpectedRetransmissionTimeMs));
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001475 // DTMF Sample Length is (Frequency/1000) * Duration.
1476 // So in this case, it is (8000/1000) * 500 = 4000.
1477 // Sending it as two packets.
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001478 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001479 kEmptyFrame, kPayloadType, capture_time_ms + 2000, 0, nullptr, 0, nullptr,
1480 nullptr, nullptr, kDefaultExpectedRetransmissionTimeMs));
danilchap12ba1862016-10-26 02:41:55 -07001481
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001482 // Marker Bit should be set to 1 for first packet.
danilchap12ba1862016-10-26 02:41:55 -07001483 EXPECT_TRUE(transport_.last_sent_packet().Marker());
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001484
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001485 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001486 kEmptyFrame, kPayloadType, capture_time_ms + 4000, 0, nullptr, 0, nullptr,
1487 nullptr, nullptr, kDefaultExpectedRetransmissionTimeMs));
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001488 // Marker Bit should be set to 0 for rest of the packets.
danilchap12ba1862016-10-26 02:41:55 -07001489 EXPECT_FALSE(transport_.last_sent_packet().Marker());
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001490}
1491
minyue3a407ee2017-04-03 01:10:33 -07001492TEST_P(RtpSenderTestWithoutPacer, BytesReportedCorrectly) {
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001493 const char* kPayloadName = "GENERIC";
1494 const uint8_t kPayloadType = 127;
1495 rtp_sender_->SetSSRC(1234);
1496 rtp_sender_->SetRtxSsrc(4321);
Shao Changbine62202f2015-04-21 20:24:50 +08001497 rtp_sender_->SetRtxPayloadType(kPayloadType - 1, kPayloadType);
pbos@webrtc.org0b0c2412015-01-13 14:15:15 +00001498 rtp_sender_->SetRtxStatus(kRtxRetransmitted | kRtxRedundantPayloads);
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001499
danilchap162abd32015-12-10 02:39:40 -08001500 ASSERT_EQ(0, rtp_sender_->RegisterPayload(kPayloadName, kPayloadType, 90000,
1501 0, 1500));
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001502 uint8_t payload[] = {47, 11, 32, 93, 89};
1503
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001504 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001505 kVideoFrameKey, kPayloadType, 1234, 4321, payload, sizeof(payload),
1506 nullptr, nullptr, nullptr, kDefaultExpectedRetransmissionTimeMs));
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001507
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +00001508 // Will send 2 full-size padding packets.
philipel8aadd502017-02-23 02:56:13 -08001509 rtp_sender_->TimeToSendPadding(1, PacedPacketInfo());
1510 rtp_sender_->TimeToSendPadding(1, PacedPacketInfo());
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001511
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +00001512 StreamDataCounters rtp_stats;
1513 StreamDataCounters rtx_stats;
1514 rtp_sender_->GetDataCounters(&rtp_stats, &rtx_stats);
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001515
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +00001516 // Payload + 1-byte generic header.
asapersson@webrtc.orgd08d3892014-12-16 12:03:11 +00001517 EXPECT_GT(rtp_stats.first_packet_time_ms, -1);
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001518 EXPECT_EQ(rtp_stats.transmitted.payload_bytes, sizeof(payload) + 1);
1519 EXPECT_EQ(rtp_stats.transmitted.header_bytes, 12u);
1520 EXPECT_EQ(rtp_stats.transmitted.padding_bytes, 0u);
1521 EXPECT_EQ(rtx_stats.transmitted.payload_bytes, 0u);
1522 EXPECT_EQ(rtx_stats.transmitted.header_bytes, 24u);
1523 EXPECT_EQ(rtx_stats.transmitted.padding_bytes, 2 * kMaxPaddingSize);
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +00001524
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001525 EXPECT_EQ(rtp_stats.transmitted.TotalBytes(),
danilchap162abd32015-12-10 02:39:40 -08001526 rtp_stats.transmitted.payload_bytes +
1527 rtp_stats.transmitted.header_bytes +
1528 rtp_stats.transmitted.padding_bytes);
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001529 EXPECT_EQ(rtx_stats.transmitted.TotalBytes(),
danilchap162abd32015-12-10 02:39:40 -08001530 rtx_stats.transmitted.payload_bytes +
1531 rtx_stats.transmitted.header_bytes +
1532 rtx_stats.transmitted.padding_bytes);
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001533
danilchap162abd32015-12-10 02:39:40 -08001534 EXPECT_EQ(
1535 transport_.total_bytes_sent_,
1536 rtp_stats.transmitted.TotalBytes() + rtx_stats.transmitted.TotalBytes());
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001537}
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001538
minyue3a407ee2017-04-03 01:10:33 -07001539TEST_P(RtpSenderTestWithoutPacer, RespectsNackBitrateLimit) {
sprang38778b02015-09-29 09:48:22 -07001540 const int32_t kPacketSize = 1400;
1541 const int32_t kNumPackets = 30;
1542
sprangcd349d92016-07-13 09:11:28 -07001543 retransmission_rate_limiter_.SetMaxRate(kPacketSize * kNumPackets * 8);
1544
sprang38778b02015-09-29 09:48:22 -07001545 rtp_sender_->SetStorePacketsStatus(true, kNumPackets);
sprang38778b02015-09-29 09:48:22 -07001546 const uint16_t kStartSequenceNumber = rtp_sender_->SequenceNumber();
Danil Chapovalov2800d742016-08-26 18:48:46 +02001547 std::vector<uint16_t> sequence_numbers;
sprang38778b02015-09-29 09:48:22 -07001548 for (int32_t i = 0; i < kNumPackets; ++i) {
1549 sequence_numbers.push_back(kStartSequenceNumber + i);
1550 fake_clock_.AdvanceTimeMilliseconds(1);
1551 SendPacket(fake_clock_.TimeInMilliseconds(), kPacketSize);
1552 }
danilchap12ba1862016-10-26 02:41:55 -07001553 EXPECT_EQ(kNumPackets, transport_.packets_sent());
sprang38778b02015-09-29 09:48:22 -07001554
1555 fake_clock_.AdvanceTimeMilliseconds(1000 - kNumPackets);
1556
1557 // Resending should work - brings the bandwidth up to the limit.
1558 // NACK bitrate is capped to the same bitrate as the encoder, since the max
1559 // protection overhead is 50% (see MediaOptimization::SetTargetRates).
Danil Chapovalov2800d742016-08-26 18:48:46 +02001560 rtp_sender_->OnReceivedNack(sequence_numbers, 0);
danilchap12ba1862016-10-26 02:41:55 -07001561 EXPECT_EQ(kNumPackets * 2, transport_.packets_sent());
sprang38778b02015-09-29 09:48:22 -07001562
sprangcd349d92016-07-13 09:11:28 -07001563 // Must be at least 5ms in between retransmission attempts.
1564 fake_clock_.AdvanceTimeMilliseconds(5);
1565
sprang38778b02015-09-29 09:48:22 -07001566 // Resending should not work, bandwidth exceeded.
Danil Chapovalov2800d742016-08-26 18:48:46 +02001567 rtp_sender_->OnReceivedNack(sequence_numbers, 0);
danilchap12ba1862016-10-26 02:41:55 -07001568 EXPECT_EQ(kNumPackets * 2, transport_.packets_sent());
sprang38778b02015-09-29 09:48:22 -07001569}
1570
minyue3a407ee2017-04-03 01:10:33 -07001571TEST_P(RtpSenderVideoTest, KeyFrameHasCVO) {
danilchapb6f1fb52016-10-19 06:11:39 -07001572 uint8_t kFrame[kMaxPacketLength];
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001573 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
1574 kRtpExtensionVideoRotation, kVideoRotationExtensionId));
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001575
danilchapc1600c52016-10-26 03:33:11 -07001576 RTPVideoHeader hdr = {0};
1577 hdr.rotation = kVideoRotation_0;
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001578 rtp_sender_video_->SendVideo(kRtpVideoGeneric, kVideoFrameKey, kPayload,
danilchapb6f1fb52016-10-19 06:11:39 -07001579 kTimestamp, 0, kFrame, sizeof(kFrame), nullptr,
spranga8ae6f22017-09-04 07:23:56 -07001580 &hdr, kDefaultExpectedRetransmissionTimeMs);
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001581
danilchapc1600c52016-10-26 03:33:11 -07001582 VideoRotation rotation;
1583 EXPECT_TRUE(
1584 transport_.last_sent_packet().GetExtension<VideoOrientation>(&rotation));
1585 EXPECT_EQ(kVideoRotation_0, rotation);
1586}
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001587
ilnik04f4d122017-06-19 07:18:55 -07001588TEST_P(RtpSenderVideoTest, TimingFrameHasPacketizationTimstampSet) {
1589 uint8_t kFrame[kMaxPacketLength];
1590 const int64_t kPacketizationTimeMs = 100;
1591 const int64_t kEncodeStartDeltaMs = 10;
1592 const int64_t kEncodeFinishDeltaMs = 50;
1593 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
1594 kRtpExtensionVideoTiming, kVideoTimingExtensionId));
1595
1596 const int64_t kCaptureTimestamp = fake_clock_.TimeInMilliseconds();
1597
1598 RTPVideoHeader hdr = {0};
sprangba050a62017-08-18 02:51:12 -07001599 hdr.video_timing.flags = TimingFrameFlags::kTriggeredByTimer;
ilnik04f4d122017-06-19 07:18:55 -07001600 hdr.video_timing.encode_start_delta_ms = kEncodeStartDeltaMs;
1601 hdr.video_timing.encode_finish_delta_ms = kEncodeFinishDeltaMs;
1602
1603 fake_clock_.AdvanceTimeMilliseconds(kPacketizationTimeMs);
1604 rtp_sender_video_->SendVideo(kRtpVideoGeneric, kVideoFrameKey, kPayload,
1605 kTimestamp, kCaptureTimestamp, kFrame,
spranga8ae6f22017-09-04 07:23:56 -07001606 sizeof(kFrame), nullptr, &hdr,
1607 kDefaultExpectedRetransmissionTimeMs);
ilnik2edc6842017-07-06 03:06:50 -07001608 VideoSendTiming timing;
ilnik04f4d122017-06-19 07:18:55 -07001609 EXPECT_TRUE(transport_.last_sent_packet().GetExtension<VideoTimingExtension>(
1610 &timing));
1611 EXPECT_EQ(kPacketizationTimeMs, timing.packetization_finish_delta_ms);
1612 EXPECT_EQ(kEncodeStartDeltaMs, timing.encode_start_delta_ms);
1613 EXPECT_EQ(kEncodeFinishDeltaMs, timing.encode_finish_delta_ms);
1614}
1615
minyue3a407ee2017-04-03 01:10:33 -07001616TEST_P(RtpSenderVideoTest, DeltaFrameHasCVOWhenChanged) {
danilchapc1600c52016-10-26 03:33:11 -07001617 uint8_t kFrame[kMaxPacketLength];
1618 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
1619 kRtpExtensionVideoRotation, kVideoRotationExtensionId));
1620
1621 RTPVideoHeader hdr = {0};
1622 hdr.rotation = kVideoRotation_90;
spranga8ae6f22017-09-04 07:23:56 -07001623 EXPECT_TRUE(rtp_sender_video_->SendVideo(
1624 kRtpVideoGeneric, kVideoFrameKey, kPayload, kTimestamp, 0, kFrame,
1625 sizeof(kFrame), nullptr, &hdr, kDefaultExpectedRetransmissionTimeMs));
danilchapc1600c52016-10-26 03:33:11 -07001626
1627 hdr.rotation = kVideoRotation_0;
spranga8ae6f22017-09-04 07:23:56 -07001628 EXPECT_TRUE(rtp_sender_video_->SendVideo(
1629 kRtpVideoGeneric, kVideoFrameDelta, kPayload, kTimestamp + 1, 0, kFrame,
1630 sizeof(kFrame), nullptr, &hdr, kDefaultExpectedRetransmissionTimeMs));
danilchapc1600c52016-10-26 03:33:11 -07001631
1632 VideoRotation rotation;
1633 EXPECT_TRUE(
1634 transport_.last_sent_packet().GetExtension<VideoOrientation>(&rotation));
1635 EXPECT_EQ(kVideoRotation_0, rotation);
1636}
1637
minyue3a407ee2017-04-03 01:10:33 -07001638TEST_P(RtpSenderVideoTest, DeltaFrameHasCVOWhenNonZero) {
danilchapc1600c52016-10-26 03:33:11 -07001639 uint8_t kFrame[kMaxPacketLength];
1640 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
1641 kRtpExtensionVideoRotation, kVideoRotationExtensionId));
1642
1643 RTPVideoHeader hdr = {0};
1644 hdr.rotation = kVideoRotation_90;
spranga8ae6f22017-09-04 07:23:56 -07001645 EXPECT_TRUE(rtp_sender_video_->SendVideo(
1646 kRtpVideoGeneric, kVideoFrameKey, kPayload, kTimestamp, 0, kFrame,
1647 sizeof(kFrame), nullptr, &hdr, kDefaultExpectedRetransmissionTimeMs));
danilchapc1600c52016-10-26 03:33:11 -07001648
spranga8ae6f22017-09-04 07:23:56 -07001649 EXPECT_TRUE(rtp_sender_video_->SendVideo(
1650 kRtpVideoGeneric, kVideoFrameDelta, kPayload, kTimestamp + 1, 0, kFrame,
1651 sizeof(kFrame), nullptr, &hdr, kDefaultExpectedRetransmissionTimeMs));
danilchapc1600c52016-10-26 03:33:11 -07001652
1653 VideoRotation rotation;
1654 EXPECT_TRUE(
1655 transport_.last_sent_packet().GetExtension<VideoOrientation>(&rotation));
1656 EXPECT_EQ(kVideoRotation_90, rotation);
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001657}
magjed71eb61c2016-09-08 03:24:58 -07001658
1659// Make sure rotation is parsed correctly when the Camera (C) and Flip (F) bits
1660// are set in the CVO byte.
minyue3a407ee2017-04-03 01:10:33 -07001661TEST_P(RtpSenderVideoTest, SendVideoWithCameraAndFlipCVO) {
magjed71eb61c2016-09-08 03:24:58 -07001662 // Test extracting rotation when Camera (C) and Flip (F) bits are zero.
1663 EXPECT_EQ(kVideoRotation_0, ConvertCVOByteToVideoRotation(0));
1664 EXPECT_EQ(kVideoRotation_90, ConvertCVOByteToVideoRotation(1));
1665 EXPECT_EQ(kVideoRotation_180, ConvertCVOByteToVideoRotation(2));
1666 EXPECT_EQ(kVideoRotation_270, ConvertCVOByteToVideoRotation(3));
1667 // Test extracting rotation when Camera (C) and Flip (F) bits are set.
1668 const int flip_bit = 1 << 2;
1669 const int camera_bit = 1 << 3;
1670 EXPECT_EQ(kVideoRotation_0,
1671 ConvertCVOByteToVideoRotation(flip_bit | camera_bit | 0));
1672 EXPECT_EQ(kVideoRotation_90,
1673 ConvertCVOByteToVideoRotation(flip_bit | camera_bit | 1));
1674 EXPECT_EQ(kVideoRotation_180,
1675 ConvertCVOByteToVideoRotation(flip_bit | camera_bit | 2));
1676 EXPECT_EQ(kVideoRotation_270,
1677 ConvertCVOByteToVideoRotation(flip_bit | camera_bit | 3));
1678}
1679
spranga8ae6f22017-09-04 07:23:56 -07001680TEST_P(RtpSenderVideoTest, RetransmissionTypesGeneric) {
1681 RTPVideoHeader header;
1682 header.codec = kRtpVideoGeneric;
1683
1684 EXPECT_EQ(kDontRetransmit,
1685 rtp_sender_video_->GetStorageType(
1686 header, kRetransmitOff, kDefaultExpectedRetransmissionTimeMs));
1687 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1688 header, kRetransmitBaseLayer,
1689 kDefaultExpectedRetransmissionTimeMs));
1690 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1691 header, kRetransmitHigherLayers,
1692 kDefaultExpectedRetransmissionTimeMs));
1693 EXPECT_EQ(kAllowRetransmission,
1694 rtp_sender_video_->GetStorageType(
1695 header, kConditionallyRetransmitHigherLayers,
1696 kDefaultExpectedRetransmissionTimeMs));
1697 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1698 header, kRetransmitAllPackets,
1699 kDefaultExpectedRetransmissionTimeMs));
1700}
1701
1702TEST_P(RtpSenderVideoTest, RetransmissionTypesH264) {
1703 RTPVideoHeader header;
1704 header.codec = kRtpVideoH264;
1705 header.codecHeader.H264.packetization_mode =
1706 H264PacketizationMode::NonInterleaved;
1707
1708 EXPECT_EQ(kDontRetransmit,
1709 rtp_sender_video_->GetStorageType(
1710 header, kRetransmitOff, kDefaultExpectedRetransmissionTimeMs));
1711 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1712 header, kRetransmitBaseLayer,
1713 kDefaultExpectedRetransmissionTimeMs));
1714 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1715 header, kRetransmitHigherLayers,
1716 kDefaultExpectedRetransmissionTimeMs));
1717 EXPECT_EQ(kAllowRetransmission,
1718 rtp_sender_video_->GetStorageType(
1719 header, kConditionallyRetransmitHigherLayers,
1720 kDefaultExpectedRetransmissionTimeMs));
1721 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1722 header, kRetransmitAllPackets,
1723 kDefaultExpectedRetransmissionTimeMs));
1724}
1725
1726TEST_P(RtpSenderVideoTest, RetransmissionTypesVP8BaseLayer) {
1727 RTPVideoHeader header;
1728 header.codec = kRtpVideoVp8;
1729 header.codecHeader.VP8.temporalIdx = 0;
1730
1731 EXPECT_EQ(kDontRetransmit,
1732 rtp_sender_video_->GetStorageType(
1733 header, kRetransmitOff, kDefaultExpectedRetransmissionTimeMs));
1734 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1735 header, kRetransmitBaseLayer,
1736 kDefaultExpectedRetransmissionTimeMs));
1737 EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType(
1738 header, kRetransmitHigherLayers,
1739 kDefaultExpectedRetransmissionTimeMs));
1740 EXPECT_EQ(kAllowRetransmission,
1741 rtp_sender_video_->GetStorageType(
1742 header, kRetransmitHigherLayers | kRetransmitBaseLayer,
1743 kDefaultExpectedRetransmissionTimeMs));
1744 EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType(
1745 header, kConditionallyRetransmitHigherLayers,
1746 kDefaultExpectedRetransmissionTimeMs));
1747 EXPECT_EQ(
1748 kAllowRetransmission,
1749 rtp_sender_video_->GetStorageType(
1750 header, kRetransmitBaseLayer | kConditionallyRetransmitHigherLayers,
1751 kDefaultExpectedRetransmissionTimeMs));
1752 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1753 header, kRetransmitAllPackets,
1754 kDefaultExpectedRetransmissionTimeMs));
1755}
1756
1757TEST_P(RtpSenderVideoTest, RetransmissionTypesVP8HigherLayers) {
1758 RTPVideoHeader header;
1759 header.codec = kRtpVideoVp8;
1760
1761 for (int tid = 1; tid <= kMaxTemporalStreams; ++tid) {
1762 header.codecHeader.VP8.temporalIdx = tid;
1763
1764 EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType(
1765 header, kRetransmitOff,
1766 kDefaultExpectedRetransmissionTimeMs));
1767 EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType(
1768 header, kRetransmitBaseLayer,
1769 kDefaultExpectedRetransmissionTimeMs));
1770 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1771 header, kRetransmitHigherLayers,
1772 kDefaultExpectedRetransmissionTimeMs));
1773 EXPECT_EQ(kAllowRetransmission,
1774 rtp_sender_video_->GetStorageType(
1775 header, kRetransmitHigherLayers | kRetransmitBaseLayer,
1776 kDefaultExpectedRetransmissionTimeMs));
1777 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1778 header, kRetransmitAllPackets,
1779 kDefaultExpectedRetransmissionTimeMs));
1780 }
1781}
1782
1783TEST_P(RtpSenderVideoTest, RetransmissionTypesVP9) {
1784 RTPVideoHeader header;
1785 header.codec = kRtpVideoVp9;
1786
1787 for (int tid = 1; tid <= kMaxTemporalStreams; ++tid) {
1788 header.codecHeader.VP9.temporal_idx = tid;
1789
1790 EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType(
1791 header, kRetransmitOff,
1792 kDefaultExpectedRetransmissionTimeMs));
1793 EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType(
1794 header, kRetransmitBaseLayer,
1795 kDefaultExpectedRetransmissionTimeMs));
1796 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1797 header, kRetransmitHigherLayers,
1798 kDefaultExpectedRetransmissionTimeMs));
1799 EXPECT_EQ(kAllowRetransmission,
1800 rtp_sender_video_->GetStorageType(
1801 header, kRetransmitHigherLayers | kRetransmitBaseLayer,
1802 kDefaultExpectedRetransmissionTimeMs));
1803 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1804 header, kRetransmitAllPackets,
1805 kDefaultExpectedRetransmissionTimeMs));
1806 }
1807}
1808
1809TEST_P(RtpSenderVideoTest, ConditionalRetransmit) {
1810 const int64_t kFrameIntervalMs = 33;
1811 const int64_t kRttMs = (kFrameIntervalMs * 3) / 2;
1812 const uint8_t kSettings =
1813 kRetransmitBaseLayer | kConditionallyRetransmitHigherLayers;
1814
1815 // Insert VP8 frames for all temporal layers, but stop before the final index.
1816 RTPVideoHeader header;
1817 header.codec = kRtpVideoVp8;
1818
1819 // Fill averaging window to prevent rounding errors.
1820 constexpr int kNumRepetitions =
1821 (RTPSenderVideo::kTLRateWindowSizeMs + (kFrameIntervalMs / 2)) /
1822 kFrameIntervalMs;
1823 constexpr int kPattern[] = {0, 2, 1, 2};
1824 for (size_t i = 0; i < arraysize(kPattern) * kNumRepetitions; ++i) {
1825 header.codecHeader.VP8.temporalIdx = kPattern[i % arraysize(kPattern)];
1826 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs);
1827 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
1828 }
1829
1830 // Since we're at the start of the pattern, the next expected frame in TL0 is
1831 // right now. We will wait at most one expected retransmission time before
1832 // acknowledging that it did not arrive, which means this frame and the next
1833 // will not be retransmitted.
1834 header.codecHeader.VP8.temporalIdx = 1;
1835 EXPECT_EQ(StorageType::kDontRetransmit,
1836 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
1837 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
1838 EXPECT_EQ(StorageType::kDontRetransmit,
1839 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
1840 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
1841
1842 // The TL0 frame did not arrive. So allow retransmission.
1843 EXPECT_EQ(StorageType::kAllowRetransmission,
1844 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
1845 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
1846
1847 // Insert a frame for TL2. We just had frame in TL1, so the next one there is
1848 // in three frames away. TL0 is still too far in the past. So, allow
1849 // retransmission.
1850 header.codecHeader.VP8.temporalIdx = 2;
1851 EXPECT_EQ(StorageType::kAllowRetransmission,
1852 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
1853 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
1854
1855 // Another TL2, next in TL1 is two frames away. Allow again.
1856 EXPECT_EQ(StorageType::kAllowRetransmission,
1857 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
1858 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
1859
1860 // Yet another TL2, next in TL1 is now only one frame away, so don't store
1861 // for retransmission.
1862 EXPECT_EQ(StorageType::kDontRetransmit,
1863 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
1864}
1865
1866TEST_P(RtpSenderVideoTest, ConditionalRetransmitLimit) {
1867 const int64_t kFrameIntervalMs = 200;
1868 const int64_t kRttMs = (kFrameIntervalMs * 3) / 2;
1869 const int32_t kSettings =
1870 kRetransmitBaseLayer | kConditionallyRetransmitHigherLayers;
1871
1872 // Insert VP8 frames for all temporal layers, but stop before the final index.
1873 RTPVideoHeader header;
1874 header.codec = kRtpVideoVp8;
1875
1876 // Fill averaging window to prevent rounding errors.
1877 constexpr int kNumRepetitions =
1878 (RTPSenderVideo::kTLRateWindowSizeMs + (kFrameIntervalMs / 2)) /
1879 kFrameIntervalMs;
1880 constexpr int kPattern[] = {0, 2, 2, 2};
1881 for (size_t i = 0; i < arraysize(kPattern) * kNumRepetitions; ++i) {
1882 header.codecHeader.VP8.temporalIdx = kPattern[i % arraysize(kPattern)];
1883
1884 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs);
1885 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
1886 }
1887
1888 // Since we're at the start of the pattern, the next expected frame will be
1889 // right now in TL0. Put it in TL1 instead. Regular rules would dictate that
1890 // we don't store for retransmission because we expect a frame in a lower
1891 // layer, but that last frame in TL1 was a long time ago in absolute terms,
1892 // so allow retransmission anyway.
1893 header.codecHeader.VP8.temporalIdx = 1;
1894 EXPECT_EQ(StorageType::kAllowRetransmission,
1895 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
1896}
1897
minyue3a407ee2017-04-03 01:10:33 -07001898TEST_P(RtpSenderTest, OnOverheadChanged) {
michaelt4da30442016-11-17 01:38:43 -08001899 MockOverheadObserver mock_overhead_observer;
1900 rtp_sender_.reset(
1901 new RTPSender(false, &fake_clock_, &transport_, nullptr, nullptr, nullptr,
1902 nullptr, nullptr, nullptr, nullptr, nullptr, nullptr,
1903 &retransmission_rate_limiter_, &mock_overhead_observer));
nisse7d59f6b2017-02-21 03:40:24 -08001904 rtp_sender_->SetSSRC(kSsrc);
michaelt4da30442016-11-17 01:38:43 -08001905
michaelt4da30442016-11-17 01:38:43 -08001906 // RTP overhead is 12B.
nisse284542b2017-01-10 08:58:32 -08001907 EXPECT_CALL(mock_overhead_observer, OnOverheadChanged(12)).Times(1);
michaelt4da30442016-11-17 01:38:43 -08001908 SendGenericPayload();
1909
1910 rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionTransmissionTimeOffset,
1911 kTransmissionTimeOffsetExtensionId);
1912
1913 // TransmissionTimeOffset extension has a size of 8B.
nisse284542b2017-01-10 08:58:32 -08001914 // 12B + 8B = 20B
1915 EXPECT_CALL(mock_overhead_observer, OnOverheadChanged(20)).Times(1);
michaelt4da30442016-11-17 01:38:43 -08001916 SendGenericPayload();
1917}
1918
minyue3a407ee2017-04-03 01:10:33 -07001919TEST_P(RtpSenderTest, DoesNotUpdateOverheadOnEqualSize) {
michaelt4da30442016-11-17 01:38:43 -08001920 MockOverheadObserver mock_overhead_observer;
1921 rtp_sender_.reset(
1922 new RTPSender(false, &fake_clock_, &transport_, nullptr, nullptr, nullptr,
1923 nullptr, nullptr, nullptr, nullptr, nullptr, nullptr,
1924 &retransmission_rate_limiter_, &mock_overhead_observer));
nisse7d59f6b2017-02-21 03:40:24 -08001925 rtp_sender_->SetSSRC(kSsrc);
michaelt4da30442016-11-17 01:38:43 -08001926
1927 EXPECT_CALL(mock_overhead_observer, OnOverheadChanged(_)).Times(1);
michaelt4da30442016-11-17 01:38:43 -08001928 SendGenericPayload();
1929 SendGenericPayload();
1930}
1931
minyue3a407ee2017-04-03 01:10:33 -07001932TEST_P(RtpSenderTest, SendAudioPadding) {
stefan53b6cc32017-02-03 08:13:57 -08001933 MockTransport transport;
1934 const bool kEnableAudio = true;
1935 rtp_sender_.reset(new RTPSender(
1936 kEnableAudio, &fake_clock_, &transport, &mock_paced_sender_, nullptr,
1937 nullptr, nullptr, nullptr, nullptr, nullptr, &mock_rtc_event_log_,
1938 nullptr, &retransmission_rate_limiter_, nullptr));
1939 rtp_sender_->SetSendPayloadType(kPayload);
1940 rtp_sender_->SetSequenceNumber(kSeqNum);
1941 rtp_sender_->SetTimestampOffset(0);
1942 rtp_sender_->SetSSRC(kSsrc);
1943
1944 const size_t kPaddingSize = 59;
1945 EXPECT_CALL(transport, SendRtp(_, kPaddingSize + kRtpHeaderSize, _))
1946 .WillOnce(testing::Return(true));
philipelc7bf32a2017-02-17 03:59:43 -08001947 EXPECT_EQ(kPaddingSize,
philipel8aadd502017-02-23 02:56:13 -08001948 rtp_sender_->TimeToSendPadding(kPaddingSize, PacedPacketInfo()));
stefan53b6cc32017-02-03 08:13:57 -08001949
1950 // Requested padding size is too small, will send a larger one.
1951 const size_t kMinPaddingSize = 50;
1952 EXPECT_CALL(transport, SendRtp(_, kMinPaddingSize + kRtpHeaderSize, _))
1953 .WillOnce(testing::Return(true));
philipel8aadd502017-02-23 02:56:13 -08001954 EXPECT_EQ(
1955 kMinPaddingSize,
1956 rtp_sender_->TimeToSendPadding(kMinPaddingSize - 5, PacedPacketInfo()));
stefan53b6cc32017-02-03 08:13:57 -08001957}
minyue3a407ee2017-04-03 01:10:33 -07001958
sprang168794c2017-07-06 04:38:06 -07001959TEST_P(RtpSenderTest, SendsKeepAlive) {
1960 MockTransport transport;
1961 rtp_sender_.reset(new RTPSender(false, &fake_clock_, &transport, nullptr,
1962 nullptr, nullptr, nullptr, nullptr, nullptr,
1963 nullptr, &mock_rtc_event_log_, nullptr,
1964 &retransmission_rate_limiter_, nullptr));
1965 rtp_sender_->SetSendPayloadType(kPayload);
1966 rtp_sender_->SetSequenceNumber(kSeqNum);
1967 rtp_sender_->SetTimestampOffset(0);
1968 rtp_sender_->SetSSRC(kSsrc);
1969
1970 const uint8_t kKeepalivePayloadType = 20;
1971 RTC_CHECK_NE(kKeepalivePayloadType, kPayload);
1972
1973 EXPECT_CALL(transport, SendRtp(_, _, _))
1974 .WillOnce(
1975 Invoke([&kKeepalivePayloadType](const uint8_t* packet, size_t len,
1976 const PacketOptions& options) {
1977 webrtc::RTPHeader rtp_header;
1978 RtpUtility::RtpHeaderParser parser(packet, len);
1979 EXPECT_TRUE(parser.Parse(&rtp_header, nullptr));
1980 EXPECT_FALSE(rtp_header.markerBit);
1981 EXPECT_EQ(0U, rtp_header.paddingLength);
1982 EXPECT_EQ(kKeepalivePayloadType, rtp_header.payloadType);
1983 EXPECT_EQ(kSeqNum, rtp_header.sequenceNumber);
1984 EXPECT_EQ(kSsrc, rtp_header.ssrc);
1985 EXPECT_EQ(0u, len - rtp_header.headerLength);
1986 return true;
1987 }));
1988
1989 rtp_sender_->SendKeepAlive(kKeepalivePayloadType);
1990 EXPECT_EQ(kSeqNum + 1, rtp_sender_->SequenceNumber());
1991}
1992
minyue3a407ee2017-04-03 01:10:33 -07001993INSTANTIATE_TEST_CASE_P(WithAndWithoutOverhead,
1994 RtpSenderTest,
1995 ::testing::Bool());
1996INSTANTIATE_TEST_CASE_P(WithAndWithoutOverhead,
1997 RtpSenderTestWithoutPacer,
1998 ::testing::Bool());
1999INSTANTIATE_TEST_CASE_P(WithAndWithoutOverhead,
2000 RtpSenderVideoTest,
2001 ::testing::Bool());
2002INSTANTIATE_TEST_CASE_P(WithAndWithoutOverhead,
2003 RtpSenderAudioTest,
2004 ::testing::Bool());
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00002005} // namespace webrtc