blob: d769ec31cd9335283964eac50c4bc9e88ad661bb [file] [log] [blame]
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +00001/*
phoglund@webrtc.org78088c22012-02-07 14:56:45 +00002 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +00003 *
4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
9 */
10
kwiberg84be5112016-04-27 01:19:58 -070011#include <memory>
danilchapb8b6fbb2015-12-10 05:05:27 -080012#include <vector>
13
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020014#include "api/video/video_timing.h"
Elad Alon4a87e1c2017-10-03 16:11:34 +020015#include "logging/rtc_event_log/events/rtc_event.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020016#include "logging/rtc_event_log/mock/mock_rtc_event_log.h"
17#include "modules/rtp_rtcp/include/rtp_cvo.h"
18#include "modules/rtp_rtcp/include/rtp_header_extension_map.h"
19#include "modules/rtp_rtcp/include/rtp_header_parser.h"
20#include "modules/rtp_rtcp/include/rtp_rtcp_defines.h"
21#include "modules/rtp_rtcp/source/rtcp_packet/transport_feedback.h"
22#include "modules/rtp_rtcp/source/rtp_format_video_generic.h"
23#include "modules/rtp_rtcp/source/rtp_header_extensions.h"
24#include "modules/rtp_rtcp/source/rtp_packet_received.h"
25#include "modules/rtp_rtcp/source/rtp_packet_to_send.h"
26#include "modules/rtp_rtcp/source/rtp_sender.h"
27#include "modules/rtp_rtcp/source/rtp_sender_video.h"
28#include "modules/rtp_rtcp/source/rtp_utility.h"
29#include "rtc_base/arraysize.h"
30#include "rtc_base/buffer.h"
31#include "rtc_base/ptr_util.h"
32#include "rtc_base/rate_limiter.h"
33#include "test/field_trial.h"
34#include "test/gmock.h"
35#include "test/gtest.h"
36#include "test/mock_transport.h"
Mirko Bonadei71207422017-09-15 13:58:09 +020037#include "typedefs.h" // NOLINT(build/include)
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +000038
39namespace webrtc {
40
andrew@webrtc.org8a442592011-12-16 21:24:30 +000041namespace {
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +000042const int kTransmissionTimeOffsetExtensionId = 1;
43const int kAbsoluteSendTimeExtensionId = 14;
sprang@webrtc.org30933902015-03-17 14:33:12 +000044const int kTransportSequenceNumberExtensionId = 13;
ilnik04f4d122017-06-19 07:18:55 -070045const int kVideoTimingExtensionId = 12;
Steve Anton296a0ce2018-03-22 15:17:27 -070046const int kMidExtensionId = 11;
andrew@webrtc.org8a442592011-12-16 21:24:30 +000047const int kPayload = 100;
Shao Changbine62202f2015-04-21 20:24:50 +080048const int kRtxPayload = 98;
andrew@webrtc.org8a442592011-12-16 21:24:30 +000049const uint32_t kTimestamp = 10;
50const uint16_t kSeqNum = 33;
brandtr9dfff292016-11-14 05:14:50 -080051const uint32_t kSsrc = 725242;
andrew@webrtc.org8a442592011-12-16 21:24:30 +000052const int kMaxPacketLength = 1500;
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +000053const uint8_t kAudioLevel = 0x5a;
sprang@webrtc.org30933902015-03-17 14:33:12 +000054const uint16_t kTransportSequenceNumber = 0xaabbu;
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +000055const uint8_t kAudioLevelExtensionId = 9;
56const int kAudioPayload = 103;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +000057const uint64_t kStartTime = 123456789;
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +000058const size_t kMaxPaddingSize = 224u;
guoweis@webrtc.org45362892015-03-04 22:55:15 +000059const int kVideoRotationExtensionId = 5;
Stefan Holmera246cfb2016-08-23 17:51:42 +020060const size_t kGenericHeaderLength = 1;
61const uint8_t kPayloadData[] = {47, 11, 32, 93, 89};
spranga8ae6f22017-09-04 07:23:56 -070062const int64_t kDefaultExpectedRetransmissionTimeMs = 125;
andrew@webrtc.org8a442592011-12-16 21:24:30 +000063
Danil Chapovalov5e57b172016-09-02 19:15:59 +020064using ::testing::_;
65using ::testing::ElementsAreArray;
sprang168794c2017-07-06 04:38:06 -070066using ::testing::Invoke;
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +000067
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +000068uint64_t ConvertMsToAbsSendTime(int64_t time_ms) {
Stefan Holmer0a87ffc2015-10-21 13:41:48 +020069 return (((time_ms << 18) + 500) / 1000) & 0x00ffffff;
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +000070}
71
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +000072class LoopbackTransportTest : public webrtc::Transport {
73 public:
danilchap12ba1862016-10-26 02:41:55 -070074 LoopbackTransportTest() : total_bytes_sent_(0), last_packet_id_(-1) {
75 receivers_extensions_.Register(kRtpExtensionTransmissionTimeOffset,
76 kTransmissionTimeOffsetExtensionId);
77 receivers_extensions_.Register(kRtpExtensionAbsoluteSendTime,
78 kAbsoluteSendTimeExtensionId);
79 receivers_extensions_.Register(kRtpExtensionTransportSequenceNumber,
80 kTransportSequenceNumberExtensionId);
81 receivers_extensions_.Register(kRtpExtensionVideoRotation,
82 kVideoRotationExtensionId);
83 receivers_extensions_.Register(kRtpExtensionAudioLevel,
84 kAudioLevelExtensionId);
ilnik04f4d122017-06-19 07:18:55 -070085 receivers_extensions_.Register(kRtpExtensionVideoTiming,
86 kVideoTimingExtensionId);
Steve Anton296a0ce2018-03-22 15:17:27 -070087 receivers_extensions_.Register(kRtpExtensionMid, kMidExtensionId);
guoweis@webrtc.org45362892015-03-04 22:55:15 +000088 }
danilchap12ba1862016-10-26 02:41:55 -070089
stefan1d8a5062015-10-02 03:39:33 -070090 bool SendRtp(const uint8_t* data,
91 size_t len,
92 const PacketOptions& options) override {
Stefan Holmerf5dca482016-01-27 12:58:51 +010093 last_packet_id_ = options.packet_id;
pkasting@chromium.org4591fbd2014-11-20 22:28:14 +000094 total_bytes_sent_ += len;
danilchap12ba1862016-10-26 02:41:55 -070095 sent_packets_.push_back(RtpPacketReceived(&receivers_extensions_));
96 EXPECT_TRUE(sent_packets_.back().Parse(data, len));
pbos2d566682015-09-28 09:59:31 -070097 return true;
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +000098 }
danilchap162abd32015-12-10 02:39:40 -080099 bool SendRtcp(const uint8_t* data, size_t len) override { return false; }
danilchap12ba1862016-10-26 02:41:55 -0700100 const RtpPacketReceived& last_sent_packet() { return sent_packets_.back(); }
101 int packets_sent() { return sent_packets_.size(); }
102
pbos@webrtc.org72491b92014-07-10 16:24:54 +0000103 size_t total_bytes_sent_;
Stefan Holmerf5dca482016-01-27 12:58:51 +0100104 int last_packet_id_;
danilchap12ba1862016-10-26 02:41:55 -0700105 std::vector<RtpPacketReceived> sent_packets_;
106
107 private:
108 RtpHeaderExtensionMap receivers_extensions_;
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000109};
110
Elad Alon4a87e1c2017-10-03 16:11:34 +0200111MATCHER_P(SameRtcEventTypeAs, value, "") {
112 return value == arg->GetType();
113}
114
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000115} // namespace
116
sprangebbf8a82015-09-21 15:11:14 -0700117class MockRtpPacketSender : public RtpPacketSender {
118 public:
119 MockRtpPacketSender() {}
120 virtual ~MockRtpPacketSender() {}
121
Peter Boströme23e7372015-10-08 11:44:14 +0200122 MOCK_METHOD6(InsertPacket,
123 void(Priority priority,
sprangebbf8a82015-09-21 15:11:14 -0700124 uint32_t ssrc,
125 uint16_t sequence_number,
126 int64_t capture_time_ms,
127 size_t bytes,
128 bool retransmission));
129};
130
Stefan Holmerf5dca482016-01-27 12:58:51 +0100131class MockTransportSequenceNumberAllocator
132 : public TransportSequenceNumberAllocator {
133 public:
134 MOCK_METHOD0(AllocateSequenceNumber, uint16_t());
135};
136
asapersson35151f32016-05-02 23:44:01 -0700137class MockSendPacketObserver : public SendPacketObserver {
138 public:
139 MOCK_METHOD3(OnSendPacket, void(uint16_t, int64_t, uint32_t));
140};
141
Stefan Holmera246cfb2016-08-23 17:51:42 +0200142class MockTransportFeedbackObserver : public TransportFeedbackObserver {
143 public:
elad.alond12a8e12017-03-23 11:04:48 -0700144 MOCK_METHOD4(AddPacket,
145 void(uint32_t, uint16_t, size_t, const PacedPacketInfo&));
Stefan Holmera246cfb2016-08-23 17:51:42 +0200146 MOCK_METHOD1(OnTransportFeedback, void(const rtcp::TransportFeedback&));
elad.alonf9490002017-03-06 05:32:21 -0800147 MOCK_CONST_METHOD0(GetTransportFeedbackVector, std::vector<PacketFeedback>());
Stefan Holmera246cfb2016-08-23 17:51:42 +0200148};
149
minyue3a407ee2017-04-03 01:10:33 -0700150class MockOverheadObserver : public OverheadObserver {
151 public:
152 MOCK_METHOD1(OnOverheadChanged, void(size_t overhead_bytes_per_packet));
153};
154
155class RtpSenderTest : public ::testing::TestWithParam<bool> {
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000156 protected:
157 RtpSenderTest()
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +0000158 : fake_clock_(kStartTime),
terelius429c3452016-01-21 05:42:04 -0800159 mock_rtc_event_log_(),
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +0000160 mock_paced_sender_(),
sprangcd349d92016-07-13 09:11:28 -0700161 retransmission_rate_limiter_(&fake_clock_, 1000),
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +0000162 rtp_sender_(),
163 payload_(kPayload),
164 transport_(),
minyue3a407ee2017-04-03 01:10:33 -0700165 kMarkerBit(true),
166 field_trials_(GetParam() ? "WebRTC-SendSideBwe-WithOverhead/Enabled/"
167 : "") {}
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +0000168
Erik Språng7b52f102018-02-07 14:37:37 +0100169 void SetUp() override { SetUpRtpSender(true, false); }
Peter Boströme23e7372015-10-08 11:44:14 +0200170
Erik Språng7b52f102018-02-07 14:37:37 +0100171 void SetUpRtpSender(bool pacer, bool populate_network2) {
asapersson35151f32016-05-02 23:44:01 -0700172 rtp_sender_.reset(new RTPSender(
173 false, &fake_clock_, &transport_, pacer ? &mock_paced_sender_ : nullptr,
brandtrdbdb3f12016-11-10 05:04:48 -0800174 nullptr, &seq_num_allocator_, nullptr, nullptr, nullptr, nullptr,
sprangcd349d92016-07-13 09:11:28 -0700175 &mock_rtc_event_log_, &send_packet_observer_,
Erik Språng7b52f102018-02-07 14:37:37 +0100176 &retransmission_rate_limiter_, nullptr, populate_network2));
brandtr9dfff292016-11-14 05:14:50 -0800177 rtp_sender_->SetSequenceNumber(kSeqNum);
danilchap71fead22016-08-18 02:01:49 -0700178 rtp_sender_->SetTimestampOffset(0);
brandtr9dfff292016-11-14 05:14:50 -0800179 rtp_sender_->SetSSRC(kSsrc);
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +0000180 }
181
stefan@webrtc.orga678a3b2013-01-21 07:42:11 +0000182 SimulatedClock fake_clock_;
stefana23fc622016-07-28 07:56:38 -0700183 testing::NiceMock<MockRtcEventLog> mock_rtc_event_log_;
sprangebbf8a82015-09-21 15:11:14 -0700184 MockRtpPacketSender mock_paced_sender_;
stefana23fc622016-07-28 07:56:38 -0700185 testing::StrictMock<MockTransportSequenceNumberAllocator> seq_num_allocator_;
186 testing::StrictMock<MockSendPacketObserver> send_packet_observer_;
Stefan Holmera246cfb2016-08-23 17:51:42 +0200187 testing::StrictMock<MockTransportFeedbackObserver> feedback_observer_;
sprangcd349d92016-07-13 09:11:28 -0700188 RateLimiter retransmission_rate_limiter_;
kwiberg84be5112016-04-27 01:19:58 -0700189 std::unique_ptr<RTPSender> rtp_sender_;
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +0000190 int payload_;
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000191 LoopbackTransportTest transport_;
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000192 const bool kMarkerBit;
minyue3a407ee2017-04-03 01:10:33 -0700193 test::ScopedFieldTrials field_trials_;
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000194
stefan@webrtc.orga5cb98c2013-05-29 12:12:51 +0000195 void VerifyRTPHeaderCommon(const RTPHeader& rtp_header) {
danilchapd9e62f52016-01-14 14:55:19 -0800196 VerifyRTPHeaderCommon(rtp_header, kMarkerBit, 0);
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000197 }
198
199 void VerifyRTPHeaderCommon(const RTPHeader& rtp_header, bool marker_bit) {
danilchapd9e62f52016-01-14 14:55:19 -0800200 VerifyRTPHeaderCommon(rtp_header, marker_bit, 0);
201 }
202
203 void VerifyRTPHeaderCommon(const RTPHeader& rtp_header,
204 bool marker_bit,
205 uint8_t number_of_csrcs) {
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000206 EXPECT_EQ(marker_bit, rtp_header.markerBit);
stefan@webrtc.orga5cb98c2013-05-29 12:12:51 +0000207 EXPECT_EQ(payload_, rtp_header.payloadType);
208 EXPECT_EQ(kSeqNum, rtp_header.sequenceNumber);
209 EXPECT_EQ(kTimestamp, rtp_header.timestamp);
210 EXPECT_EQ(rtp_sender_->SSRC(), rtp_header.ssrc);
danilchapd9e62f52016-01-14 14:55:19 -0800211 EXPECT_EQ(number_of_csrcs, rtp_header.numCSRCs);
pkasting@chromium.org4591fbd2014-11-20 22:28:14 +0000212 EXPECT_EQ(0U, rtp_header.paddingLength);
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000213 }
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000214
danilchapb6f1fb52016-10-19 06:11:39 -0700215 std::unique_ptr<RtpPacketToSend> BuildRtpPacket(int payload_type,
216 bool marker_bit,
217 uint32_t timestamp,
218 int64_t capture_time_ms) {
219 auto packet = rtp_sender_->AllocatePacket();
220 packet->SetPayloadType(payload_type);
221 packet->SetMarker(marker_bit);
222 packet->SetTimestamp(timestamp);
223 packet->set_capture_time_ms(capture_time_ms);
224 EXPECT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
225 return packet;
226 }
227
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000228 void SendPacket(int64_t capture_time_ms, int payload_length) {
229 uint32_t timestamp = capture_time_ms * 90;
danilchapb6f1fb52016-10-19 06:11:39 -0700230 auto packet =
231 BuildRtpPacket(kPayload, kMarkerBit, timestamp, capture_time_ms);
232 packet->AllocatePayload(payload_length);
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000233
234 // Packet should be stored in a send bucket.
danilchapb6f1fb52016-10-19 06:11:39 -0700235 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
236 kAllowRetransmission,
237 RtpPacketSender::kNormalPriority));
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000238 }
asapersson35151f32016-05-02 23:44:01 -0700239
240 void SendGenericPayload() {
asapersson35151f32016-05-02 23:44:01 -0700241 const uint32_t kTimestamp = 1234;
242 const uint8_t kPayloadType = 127;
243 const int64_t kCaptureTimeMs = fake_clock_.TimeInMilliseconds();
244 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
245 EXPECT_EQ(0, rtp_sender_->RegisterPayload(payload_name, kPayloadType, 90000,
246 0, 1500));
247
Sergey Ulanov525df3f2016-08-02 17:46:41 -0700248 EXPECT_TRUE(rtp_sender_->SendOutgoingData(
Stefan Holmera246cfb2016-08-23 17:51:42 +0200249 kVideoFrameKey, kPayloadType, kTimestamp, kCaptureTimeMs, kPayloadData,
spranga8ae6f22017-09-04 07:23:56 -0700250 sizeof(kPayloadData), nullptr, nullptr, nullptr,
251 kDefaultExpectedRetransmissionTimeMs));
asapersson35151f32016-05-02 23:44:01 -0700252 }
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000253};
254
Peter Boströme23e7372015-10-08 11:44:14 +0200255// TODO(pbos): Move tests over from WithoutPacer to RtpSenderTest as this is our
256// default code path.
257class RtpSenderTestWithoutPacer : public RtpSenderTest {
258 public:
Erik Språng7b52f102018-02-07 14:37:37 +0100259 void SetUp() override { SetUpRtpSender(false, false); }
Peter Boströme23e7372015-10-08 11:44:14 +0200260};
261
spranga8ae6f22017-09-04 07:23:56 -0700262class TestRtpSenderVideo : public RTPSenderVideo {
263 public:
264 TestRtpSenderVideo(Clock* clock,
265 RTPSender* rtp_sender,
266 FlexfecSender* flexfec_sender)
267 : RTPSenderVideo(clock, rtp_sender, flexfec_sender) {}
268 ~TestRtpSenderVideo() override {}
269
270 StorageType GetStorageType(const RTPVideoHeader& header,
271 int32_t retransmission_settings,
272 int64_t expected_retransmission_time_ms) {
273 return RTPSenderVideo::GetStorageType(GetTemporalId(header),
274 retransmission_settings,
275 expected_retransmission_time_ms);
276 }
277};
278
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000279class RtpSenderVideoTest : public RtpSenderTest {
280 protected:
danilchap162abd32015-12-10 02:39:40 -0800281 void SetUp() override {
Peter Boströme23e7372015-10-08 11:44:14 +0200282 // TODO(pbos): Set up to use pacer.
Erik Språng7b52f102018-02-07 14:37:37 +0100283 SetUpRtpSender(false, false);
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000284 rtp_sender_video_.reset(
spranga8ae6f22017-09-04 07:23:56 -0700285 new TestRtpSenderVideo(&fake_clock_, rtp_sender_.get(), nullptr));
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000286 }
spranga8ae6f22017-09-04 07:23:56 -0700287 std::unique_ptr<TestRtpSenderVideo> rtp_sender_video_;
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000288};
289
minyue3a407ee2017-04-03 01:10:33 -0700290TEST_P(RtpSenderTestWithoutPacer, AllocatePacketSetCsrc) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200291 // Configure rtp_sender with csrc.
292 std::vector<uint32_t> csrcs;
293 csrcs.push_back(0x23456789);
294 rtp_sender_->SetCsrcs(csrcs);
295
296 auto packet = rtp_sender_->AllocatePacket();
297
298 ASSERT_TRUE(packet);
299 EXPECT_EQ(rtp_sender_->SSRC(), packet->Ssrc());
300 EXPECT_EQ(csrcs, packet->Csrcs());
301}
302
minyue3a407ee2017-04-03 01:10:33 -0700303TEST_P(RtpSenderTestWithoutPacer, AllocatePacketReserveExtensions) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200304 // Configure rtp_sender with extensions.
305 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
306 kRtpExtensionTransmissionTimeOffset,
307 kTransmissionTimeOffsetExtensionId));
308 ASSERT_EQ(
309 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
310 kAbsoluteSendTimeExtensionId));
311 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAudioLevel,
312 kAudioLevelExtensionId));
313 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
314 kRtpExtensionTransportSequenceNumber,
315 kTransportSequenceNumberExtensionId));
316 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
317 kRtpExtensionVideoRotation, kVideoRotationExtensionId));
318
319 auto packet = rtp_sender_->AllocatePacket();
320
321 ASSERT_TRUE(packet);
322 // Preallocate BWE extensions RtpSender set itself.
323 EXPECT_TRUE(packet->HasExtension<TransmissionOffset>());
324 EXPECT_TRUE(packet->HasExtension<AbsoluteSendTime>());
325 EXPECT_TRUE(packet->HasExtension<TransportSequenceNumber>());
326 // Do not allocate media specific extensions.
327 EXPECT_FALSE(packet->HasExtension<AudioLevel>());
328 EXPECT_FALSE(packet->HasExtension<VideoOrientation>());
329}
330
minyue3a407ee2017-04-03 01:10:33 -0700331TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberAdvanceSequenceNumber) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200332 auto packet = rtp_sender_->AllocatePacket();
333 ASSERT_TRUE(packet);
334 const uint16_t sequence_number = rtp_sender_->SequenceNumber();
335
336 EXPECT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
337
338 EXPECT_EQ(sequence_number, packet->SequenceNumber());
339 EXPECT_EQ(sequence_number + 1, rtp_sender_->SequenceNumber());
340}
341
minyue3a407ee2017-04-03 01:10:33 -0700342TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberFailsOnNotSending) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200343 auto packet = rtp_sender_->AllocatePacket();
344 ASSERT_TRUE(packet);
345
346 rtp_sender_->SetSendingMediaStatus(false);
347 EXPECT_FALSE(rtp_sender_->AssignSequenceNumber(packet.get()));
348}
349
Danil Chapovalovb3179c72018-03-22 10:13:07 +0100350TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberMayAllowPaddingOnVideo) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200351 constexpr size_t kPaddingSize = 100;
352 auto packet = rtp_sender_->AllocatePacket();
353 ASSERT_TRUE(packet);
354
philipel8aadd502017-02-23 02:56:13 -0800355 ASSERT_FALSE(rtp_sender_->TimeToSendPadding(kPaddingSize, PacedPacketInfo()));
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200356 packet->SetMarker(false);
357 ASSERT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
Danil Chapovalovb3179c72018-03-22 10:13:07 +0100358 // Packet without marker bit doesn't allow padding on video stream.
philipel8aadd502017-02-23 02:56:13 -0800359 EXPECT_FALSE(rtp_sender_->TimeToSendPadding(kPaddingSize, PacedPacketInfo()));
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200360
361 packet->SetMarker(true);
362 ASSERT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
363 // Packet with marker bit allows send padding.
philipel8aadd502017-02-23 02:56:13 -0800364 EXPECT_TRUE(rtp_sender_->TimeToSendPadding(kPaddingSize, PacedPacketInfo()));
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200365}
366
Danil Chapovalovb3179c72018-03-22 10:13:07 +0100367TEST_P(RtpSenderTest, AssignSequenceNumberAllowsPaddingOnAudio) {
368 MockTransport transport;
369 const bool kEnableAudio = true;
370 rtp_sender_.reset(new RTPSender(
371 kEnableAudio, &fake_clock_, &transport, &mock_paced_sender_, nullptr,
372 nullptr, nullptr, nullptr, nullptr, nullptr, &mock_rtc_event_log_,
373 nullptr, &retransmission_rate_limiter_, nullptr, false));
374 rtp_sender_->SetTimestampOffset(0);
375 rtp_sender_->SetSSRC(kSsrc);
376
377 std::unique_ptr<RtpPacketToSend> audio_packet = rtp_sender_->AllocatePacket();
378 // Padding on audio stream allowed regardless of marker in the last packet.
379 audio_packet->SetMarker(false);
380 audio_packet->SetPayloadType(kPayload);
381 rtp_sender_->AssignSequenceNumber(audio_packet.get());
382
383 const size_t kPaddingSize = 59;
384 EXPECT_CALL(transport, SendRtp(_, kPaddingSize + kRtpHeaderSize, _))
385 .WillOnce(testing::Return(true));
386 EXPECT_EQ(kPaddingSize,
387 rtp_sender_->TimeToSendPadding(kPaddingSize, PacedPacketInfo()));
388
389 // Requested padding size is too small, will send a larger one.
390 const size_t kMinPaddingSize = 50;
391 EXPECT_CALL(transport, SendRtp(_, kMinPaddingSize + kRtpHeaderSize, _))
392 .WillOnce(testing::Return(true));
393 EXPECT_EQ(
394 kMinPaddingSize,
395 rtp_sender_->TimeToSendPadding(kMinPaddingSize - 5, PacedPacketInfo()));
396}
397
minyue3a407ee2017-04-03 01:10:33 -0700398TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberSetPaddingTimestamps) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200399 constexpr size_t kPaddingSize = 100;
400 auto packet = rtp_sender_->AllocatePacket();
401 ASSERT_TRUE(packet);
402 packet->SetMarker(true);
403 packet->SetTimestamp(kTimestamp);
404
405 ASSERT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
philipel8aadd502017-02-23 02:56:13 -0800406 ASSERT_TRUE(rtp_sender_->TimeToSendPadding(kPaddingSize, PacedPacketInfo()));
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200407
408 ASSERT_EQ(1u, transport_.sent_packets_.size());
danilchap12ba1862016-10-26 02:41:55 -0700409 // Verify padding packet timestamp.
410 EXPECT_EQ(kTimestamp, transport_.last_sent_packet().Timestamp());
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200411}
412
minyue3a407ee2017-04-03 01:10:33 -0700413TEST_P(RtpSenderTestWithoutPacer,
414 TransportFeedbackObserverGetsCorrectByteCount) {
415 constexpr int kRtpOverheadBytesPerPacket = 12 + 8;
416 testing::NiceMock<MockOverheadObserver> mock_overhead_observer;
417 rtp_sender_.reset(new RTPSender(
418 false, &fake_clock_, &transport_, nullptr, nullptr, &seq_num_allocator_,
419 &feedback_observer_, nullptr, nullptr, nullptr, &mock_rtc_event_log_,
Erik Språng7b52f102018-02-07 14:37:37 +0100420 nullptr, &retransmission_rate_limiter_, &mock_overhead_observer, false));
minyue3a407ee2017-04-03 01:10:33 -0700421 rtp_sender_->SetSSRC(kSsrc);
422 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
423 kRtpExtensionTransportSequenceNumber,
424 kTransportSequenceNumberExtensionId));
425 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
426 .WillOnce(testing::Return(kTransportSequenceNumber));
427
428 const size_t expected_bytes =
429 GetParam() ? sizeof(kPayloadData) + kGenericHeaderLength +
430 kRtpOverheadBytesPerPacket
431 : sizeof(kPayloadData) + kGenericHeaderLength;
432
433 EXPECT_CALL(feedback_observer_,
434 AddPacket(rtp_sender_->SSRC(), kTransportSequenceNumber,
435 expected_bytes, PacedPacketInfo()))
436 .Times(1);
437 EXPECT_CALL(mock_overhead_observer,
438 OnOverheadChanged(kRtpOverheadBytesPerPacket))
439 .Times(1);
440 SendGenericPayload();
441}
442
443TEST_P(RtpSenderTestWithoutPacer, SendsPacketsWithTransportSequenceNumber) {
Stefan Holmera246cfb2016-08-23 17:51:42 +0200444 rtp_sender_.reset(new RTPSender(
brandtrdbdb3f12016-11-10 05:04:48 -0800445 false, &fake_clock_, &transport_, nullptr, nullptr, &seq_num_allocator_,
446 &feedback_observer_, nullptr, nullptr, nullptr, &mock_rtc_event_log_,
Erik Språng7b52f102018-02-07 14:37:37 +0100447 &send_packet_observer_, &retransmission_rate_limiter_, nullptr, false));
nisse7d59f6b2017-02-21 03:40:24 -0800448 rtp_sender_->SetSSRC(kSsrc);
Stefan Holmerf5dca482016-01-27 12:58:51 +0100449 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
450 kRtpExtensionTransportSequenceNumber,
451 kTransportSequenceNumberExtensionId));
452
Stefan Holmerf5dca482016-01-27 12:58:51 +0100453 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
454 .WillOnce(testing::Return(kTransportSequenceNumber));
asapersson35151f32016-05-02 23:44:01 -0700455 EXPECT_CALL(send_packet_observer_,
456 OnSendPacket(kTransportSequenceNumber, _, _))
457 .Times(1);
minyue3a407ee2017-04-03 01:10:33 -0700458
459 EXPECT_CALL(feedback_observer_,
460 AddPacket(rtp_sender_->SSRC(), kTransportSequenceNumber, _,
461 PacedPacketInfo()))
Stefan Holmera246cfb2016-08-23 17:51:42 +0200462 .Times(1);
asapersson35151f32016-05-02 23:44:01 -0700463
464 SendGenericPayload();
Stefan Holmerf5dca482016-01-27 12:58:51 +0100465
danilchap12ba1862016-10-26 02:41:55 -0700466 const auto& packet = transport_.last_sent_packet();
467 uint16_t transport_seq_no;
468 ASSERT_TRUE(packet.GetExtension<TransportSequenceNumber>(&transport_seq_no));
469 EXPECT_EQ(kTransportSequenceNumber, transport_seq_no);
470 EXPECT_EQ(transport_.last_packet_id_, transport_seq_no);
Stefan Holmerf5dca482016-01-27 12:58:51 +0100471}
472
minyue3a407ee2017-04-03 01:10:33 -0700473TEST_P(RtpSenderTestWithoutPacer, NoAllocationIfNotRegistered) {
stefana23fc622016-07-28 07:56:38 -0700474 SendGenericPayload();
475}
asapersson35151f32016-05-02 23:44:01 -0700476
minyue3a407ee2017-04-03 01:10:33 -0700477TEST_P(RtpSenderTestWithoutPacer, OnSendPacketUpdated) {
stefana23fc622016-07-28 07:56:38 -0700478 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
479 kRtpExtensionTransportSequenceNumber,
480 kTransportSequenceNumberExtensionId));
asapersson35151f32016-05-02 23:44:01 -0700481 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
482 .WillOnce(testing::Return(kTransportSequenceNumber));
483 EXPECT_CALL(send_packet_observer_,
484 OnSendPacket(kTransportSequenceNumber, _, _))
485 .Times(1);
486
487 SendGenericPayload();
488}
489
minyue3a407ee2017-04-03 01:10:33 -0700490TEST_P(RtpSenderTest, SendsPacketsWithTransportSequenceNumber) {
michaelt4da30442016-11-17 01:38:43 -0800491 rtp_sender_.reset(new RTPSender(
492 false, &fake_clock_, &transport_, &mock_paced_sender_, nullptr,
493 &seq_num_allocator_, &feedback_observer_, nullptr, nullptr, nullptr,
494 &mock_rtc_event_log_, &send_packet_observer_,
Erik Språng7b52f102018-02-07 14:37:37 +0100495 &retransmission_rate_limiter_, nullptr, false));
brandtr9dfff292016-11-14 05:14:50 -0800496 rtp_sender_->SetSequenceNumber(kSeqNum);
497 rtp_sender_->SetSSRC(kSsrc);
Stefan Holmera246cfb2016-08-23 17:51:42 +0200498 rtp_sender_->SetStorePacketsStatus(true, 10);
499 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
500 kRtpExtensionTransportSequenceNumber,
501 kTransportSequenceNumberExtensionId));
502
brandtr9dfff292016-11-14 05:14:50 -0800503 EXPECT_CALL(mock_paced_sender_, InsertPacket(_, kSsrc, kSeqNum, _, _, _));
Stefan Holmera246cfb2016-08-23 17:51:42 +0200504 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
505 .WillOnce(testing::Return(kTransportSequenceNumber));
506 EXPECT_CALL(send_packet_observer_,
507 OnSendPacket(kTransportSequenceNumber, _, _))
508 .Times(1);
minyue3a407ee2017-04-03 01:10:33 -0700509 EXPECT_CALL(feedback_observer_,
510 AddPacket(rtp_sender_->SSRC(), kTransportSequenceNumber, _,
511 PacedPacketInfo()))
Stefan Holmera246cfb2016-08-23 17:51:42 +0200512 .Times(1);
513
514 SendGenericPayload();
philipel8aadd502017-02-23 02:56:13 -0800515 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum,
516 fake_clock_.TimeInMilliseconds(), false,
517 PacedPacketInfo());
Stefan Holmera246cfb2016-08-23 17:51:42 +0200518
danilchap12ba1862016-10-26 02:41:55 -0700519 const auto& packet = transport_.last_sent_packet();
520 uint16_t transport_seq_no;
521 EXPECT_TRUE(packet.GetExtension<TransportSequenceNumber>(&transport_seq_no));
522 EXPECT_EQ(kTransportSequenceNumber, transport_seq_no);
523 EXPECT_EQ(transport_.last_packet_id_, transport_seq_no);
Stefan Holmera246cfb2016-08-23 17:51:42 +0200524}
525
Erik Språng7b52f102018-02-07 14:37:37 +0100526TEST_P(RtpSenderTest, WritesPacerExitToTimingExtension) {
ilnik04f4d122017-06-19 07:18:55 -0700527 rtp_sender_->SetStorePacketsStatus(true, 10);
528 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
529 kRtpExtensionVideoTiming, kVideoTimingExtensionId));
530 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
531 auto packet = rtp_sender_->AllocatePacket();
532 packet->SetPayloadType(kPayload);
533 packet->SetMarker(true);
534 packet->SetTimestamp(kTimestamp);
535 packet->set_capture_time_ms(capture_time_ms);
ilnik2edc6842017-07-06 03:06:50 -0700536 const VideoSendTiming kVideoTiming = {0u, 0u, 0u, 0u, 0u, 0u, true};
ilnik04f4d122017-06-19 07:18:55 -0700537 packet->SetExtension<VideoTimingExtension>(kVideoTiming);
538 EXPECT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
539 size_t packet_size = packet->size();
ilnik04f4d122017-06-19 07:18:55 -0700540
541 const int kStoredTimeInMs = 100;
Erik Språng7b52f102018-02-07 14:37:37 +0100542 {
543 EXPECT_CALL(
544 mock_paced_sender_,
545 InsertPacket(RtpPacketSender::kNormalPriority, kSsrc, _, _, _, _));
546 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
547 kAllowRetransmission,
548 RtpPacketSender::kNormalPriority));
549 }
ilnik04f4d122017-06-19 07:18:55 -0700550 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
Erik Språng7b52f102018-02-07 14:37:37 +0100551 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum, capture_time_ms, false,
552 PacedPacketInfo());
ilnik04f4d122017-06-19 07:18:55 -0700553 EXPECT_EQ(1, transport_.packets_sent());
554 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
555
danilchapce251812017-09-11 12:24:41 -0700556 VideoSendTiming video_timing;
557 EXPECT_TRUE(transport_.last_sent_packet().GetExtension<VideoTimingExtension>(
558 &video_timing));
559 EXPECT_EQ(kStoredTimeInMs, video_timing.pacer_exit_delta_ms);
Erik Språng7b52f102018-02-07 14:37:37 +0100560}
ilnik04f4d122017-06-19 07:18:55 -0700561
Erik Språng7b52f102018-02-07 14:37:37 +0100562TEST_P(RtpSenderTest, WritesNetwork2ToTimingExtension) {
563 SetUpRtpSender(true, true);
564 rtp_sender_->SetStorePacketsStatus(true, 10);
565 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
566 kRtpExtensionVideoTiming, kVideoTimingExtensionId));
567 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
568 auto packet = rtp_sender_->AllocatePacket();
569 packet->SetPayloadType(kPayload);
570 packet->SetMarker(true);
571 packet->SetTimestamp(kTimestamp);
572 packet->set_capture_time_ms(capture_time_ms);
573 const uint16_t kPacerExitMs = 1234u;
574 const VideoSendTiming kVideoTiming = {0u, 0u, 0u, kPacerExitMs, 0u, 0u, true};
575 packet->SetExtension<VideoTimingExtension>(kVideoTiming);
576 EXPECT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
577 size_t packet_size = packet->size();
578
579 const int kStoredTimeInMs = 100;
580 {
581 EXPECT_CALL(
582 mock_paced_sender_,
583 InsertPacket(RtpPacketSender::kNormalPriority, kSsrc, _, _, _, _));
584 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
585 kAllowRetransmission,
586 RtpPacketSender::kNormalPriority));
587 }
ilnik04f4d122017-06-19 07:18:55 -0700588 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
589 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum, capture_time_ms, false,
590 PacedPacketInfo());
Erik Språng7b52f102018-02-07 14:37:37 +0100591 EXPECT_EQ(1, transport_.packets_sent());
ilnik04f4d122017-06-19 07:18:55 -0700592 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
593
Erik Språng7b52f102018-02-07 14:37:37 +0100594 VideoSendTiming video_timing;
danilchapce251812017-09-11 12:24:41 -0700595 EXPECT_TRUE(transport_.last_sent_packet().GetExtension<VideoTimingExtension>(
596 &video_timing));
Erik Språng7b52f102018-02-07 14:37:37 +0100597 EXPECT_EQ(kStoredTimeInMs, video_timing.network2_timestamp_delta_ms);
598 EXPECT_EQ(kPacerExitMs, video_timing.pacer_exit_delta_ms);
ilnik04f4d122017-06-19 07:18:55 -0700599}
600
minyue3a407ee2017-04-03 01:10:33 -0700601TEST_P(RtpSenderTest, TrafficSmoothingWithExtensions) {
Peter Boströme23e7372015-10-08 11:44:14 +0200602 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kNormalPriority,
brandtr9dfff292016-11-14 05:14:50 -0800603 kSsrc, kSeqNum, _, _, _));
Elad Alon4a87e1c2017-10-03 16:11:34 +0200604 EXPECT_CALL(mock_rtc_event_log_,
605 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)));
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000606
pwestin@webrtc.orgc66e8b32012-11-07 17:01:04 +0000607 rtp_sender_->SetStorePacketsStatus(true, 10);
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000608 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
danilchap162abd32015-12-10 02:39:40 -0800609 kRtpExtensionTransmissionTimeOffset,
610 kTransmissionTimeOffsetExtensionId));
611 EXPECT_EQ(
612 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
613 kAbsoluteSendTimeExtensionId));
stefan@webrtc.org8ccb9f92013-06-19 14:13:42 +0000614 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
danilchapb6f1fb52016-10-19 06:11:39 -0700615 auto packet =
616 BuildRtpPacket(kPayload, kMarkerBit, kTimestamp, capture_time_ms);
617 size_t packet_size = packet->size();
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000618
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000619 // Packet should be stored in a send bucket.
danilchapb6f1fb52016-10-19 06:11:39 -0700620 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
621 kAllowRetransmission,
Sergey Ulanov525df3f2016-08-02 17:46:41 -0700622 RtpPacketSender::kNormalPriority));
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000623
danilchap12ba1862016-10-26 02:41:55 -0700624 EXPECT_EQ(0, transport_.packets_sent());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000625
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000626 const int kStoredTimeInMs = 100;
stefan@webrtc.orga678a3b2013-01-21 07:42:11 +0000627 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000628
brandtr9dfff292016-11-14 05:14:50 -0800629 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum, capture_time_ms, false,
philipel8aadd502017-02-23 02:56:13 -0800630 PacedPacketInfo());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000631
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000632 // Process send bucket. Packet should now be sent.
danilchap12ba1862016-10-26 02:41:55 -0700633 EXPECT_EQ(1, transport_.packets_sent());
634 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
635
stefan@webrtc.orga5cb98c2013-05-29 12:12:51 +0000636 webrtc::RTPHeader rtp_header;
danilchap12ba1862016-10-26 02:41:55 -0700637 transport_.last_sent_packet().GetHeader(&rtp_header);
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000638
639 // Verify transmission time offset.
640 EXPECT_EQ(kStoredTimeInMs * 90, rtp_header.extension.transmissionTimeOffset);
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000641 uint64_t expected_send_time =
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000642 ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds());
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000643 EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime);
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000644}
645
minyue3a407ee2017-04-03 01:10:33 -0700646TEST_P(RtpSenderTest, TrafficSmoothingRetransmits) {
Peter Boströme23e7372015-10-08 11:44:14 +0200647 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kNormalPriority,
brandtr9dfff292016-11-14 05:14:50 -0800648 kSsrc, kSeqNum, _, _, _));
Elad Alon4a87e1c2017-10-03 16:11:34 +0200649 EXPECT_CALL(mock_rtc_event_log_,
650 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)));
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000651
652 rtp_sender_->SetStorePacketsStatus(true, 10);
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000653 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
danilchap162abd32015-12-10 02:39:40 -0800654 kRtpExtensionTransmissionTimeOffset,
655 kTransmissionTimeOffsetExtensionId));
656 EXPECT_EQ(
657 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
658 kAbsoluteSendTimeExtensionId));
stefan@webrtc.org8ccb9f92013-06-19 14:13:42 +0000659 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
danilchapb6f1fb52016-10-19 06:11:39 -0700660 auto packet =
661 BuildRtpPacket(kPayload, kMarkerBit, kTimestamp, capture_time_ms);
662 size_t packet_size = packet->size();
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000663
664 // Packet should be stored in a send bucket.
danilchapb6f1fb52016-10-19 06:11:39 -0700665 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
666 kAllowRetransmission,
Sergey Ulanov525df3f2016-08-02 17:46:41 -0700667 RtpPacketSender::kNormalPriority));
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000668
danilchap12ba1862016-10-26 02:41:55 -0700669 EXPECT_EQ(0, transport_.packets_sent());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000670
terelius5d332ac2016-01-14 14:37:39 -0800671 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kNormalPriority,
brandtr9dfff292016-11-14 05:14:50 -0800672 kSsrc, kSeqNum, _, _, _));
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000673
674 const int kStoredTimeInMs = 100;
675 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
676
danilchapb6f1fb52016-10-19 06:11:39 -0700677 EXPECT_EQ(static_cast<int>(packet_size), rtp_sender_->ReSendPacket(kSeqNum));
danilchap12ba1862016-10-26 02:41:55 -0700678 EXPECT_EQ(0, transport_.packets_sent());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000679
brandtr9dfff292016-11-14 05:14:50 -0800680 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum, capture_time_ms, false,
philipel8aadd502017-02-23 02:56:13 -0800681 PacedPacketInfo());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000682
683 // Process send bucket. Packet should now be sent.
danilchap12ba1862016-10-26 02:41:55 -0700684 EXPECT_EQ(1, transport_.packets_sent());
685 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000686
stefan@webrtc.orga5cb98c2013-05-29 12:12:51 +0000687 webrtc::RTPHeader rtp_header;
danilchap12ba1862016-10-26 02:41:55 -0700688 transport_.last_sent_packet().GetHeader(&rtp_header);
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000689
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000690 // Verify transmission time offset.
691 EXPECT_EQ(kStoredTimeInMs * 90, rtp_header.extension.transmissionTimeOffset);
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000692 uint64_t expected_send_time =
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000693 ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds());
694 EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime);
695}
696
697// This test sends 1 regular video packet, then 4 padding packets, and then
698// 1 more regular packet.
minyue3a407ee2017-04-03 01:10:33 -0700699TEST_P(RtpSenderTest, SendPadding) {
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000700 // Make all (non-padding) packets go to send queue.
terelius5d332ac2016-01-14 14:37:39 -0800701 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kNormalPriority,
brandtr9dfff292016-11-14 05:14:50 -0800702 kSsrc, kSeqNum, _, _, _));
Elad Alon4a87e1c2017-10-03 16:11:34 +0200703 EXPECT_CALL(mock_rtc_event_log_,
704 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
705 .Times(1 + 4 + 1);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000706
707 uint16_t seq_num = kSeqNum;
708 uint32_t timestamp = kTimestamp;
709 rtp_sender_->SetStorePacketsStatus(true, 10);
pkasting@chromium.org4591fbd2014-11-20 22:28:14 +0000710 size_t rtp_header_len = kRtpHeaderSize;
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000711 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
danilchap162abd32015-12-10 02:39:40 -0800712 kRtpExtensionTransmissionTimeOffset,
713 kTransmissionTimeOffsetExtensionId));
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000714 rtp_header_len += 4; // 4 bytes extension.
danilchap162abd32015-12-10 02:39:40 -0800715 EXPECT_EQ(
716 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
717 kAbsoluteSendTimeExtensionId));
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000718 rtp_header_len += 4; // 4 bytes extension.
719 rtp_header_len += 4; // 4 extra bytes common to all extension headers.
720
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000721 webrtc::RTPHeader rtp_header;
722
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000723 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
danilchapb6f1fb52016-10-19 06:11:39 -0700724 auto packet =
725 BuildRtpPacket(kPayload, kMarkerBit, timestamp, capture_time_ms);
Stefan Holmer586b19b2015-09-18 11:14:31 +0200726 const uint32_t media_packet_timestamp = timestamp;
danilchapb6f1fb52016-10-19 06:11:39 -0700727 size_t packet_size = packet->size();
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000728
729 // Packet should be stored in a send bucket.
danilchapb6f1fb52016-10-19 06:11:39 -0700730 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
731 kAllowRetransmission,
Sergey Ulanov525df3f2016-08-02 17:46:41 -0700732 RtpPacketSender::kNormalPriority));
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000733
734 int total_packets_sent = 0;
danilchap12ba1862016-10-26 02:41:55 -0700735 EXPECT_EQ(total_packets_sent, transport_.packets_sent());
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000736
737 const int kStoredTimeInMs = 100;
738 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
brandtr9dfff292016-11-14 05:14:50 -0800739 rtp_sender_->TimeToSendPacket(kSsrc, seq_num++, capture_time_ms, false,
philipel8aadd502017-02-23 02:56:13 -0800740 PacedPacketInfo());
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000741 // Packet should now be sent. This test doesn't verify the regular video
742 // packet, since it is tested in another test.
danilchap12ba1862016-10-26 02:41:55 -0700743 EXPECT_EQ(++total_packets_sent, transport_.packets_sent());
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000744 timestamp += 90 * kStoredTimeInMs;
745
746 // Send padding 4 times, waiting 50 ms between each.
747 for (int i = 0; i < 4; ++i) {
748 const int kPaddingPeriodMs = 50;
pkasting@chromium.org4591fbd2014-11-20 22:28:14 +0000749 const size_t kPaddingBytes = 100;
750 const size_t kMaxPaddingLength = 224; // Value taken from rtp_sender.cc.
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000751 // Padding will be forced to full packets.
philipelc7bf32a2017-02-17 03:59:43 -0800752 EXPECT_EQ(kMaxPaddingLength,
philipel8aadd502017-02-23 02:56:13 -0800753 rtp_sender_->TimeToSendPadding(kPaddingBytes, PacedPacketInfo()));
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000754
755 // Process send bucket. Padding should now be sent.
danilchap12ba1862016-10-26 02:41:55 -0700756 EXPECT_EQ(++total_packets_sent, transport_.packets_sent());
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000757 EXPECT_EQ(kMaxPaddingLength + rtp_header_len,
danilchap12ba1862016-10-26 02:41:55 -0700758 transport_.last_sent_packet().size());
759
760 transport_.last_sent_packet().GetHeader(&rtp_header);
pbosbd2522a2015-07-01 05:35:53 -0700761 EXPECT_EQ(kMaxPaddingLength, rtp_header.paddingLength);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000762
Stefan Holmer586b19b2015-09-18 11:14:31 +0200763 // Verify sequence number and timestamp. The timestamp should be the same
764 // as the last media packet.
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000765 EXPECT_EQ(seq_num++, rtp_header.sequenceNumber);
Stefan Holmer586b19b2015-09-18 11:14:31 +0200766 EXPECT_EQ(media_packet_timestamp, rtp_header.timestamp);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000767 // Verify transmission time offset.
Stefan Holmer586b19b2015-09-18 11:14:31 +0200768 int offset = timestamp - media_packet_timestamp;
769 EXPECT_EQ(offset, rtp_header.extension.transmissionTimeOffset);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000770 uint64_t expected_send_time =
771 ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds());
772 EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime);
773 fake_clock_.AdvanceTimeMilliseconds(kPaddingPeriodMs);
774 timestamp += 90 * kPaddingPeriodMs;
775 }
776
777 // Send a regular video packet again.
778 capture_time_ms = fake_clock_.TimeInMilliseconds();
danilchapb6f1fb52016-10-19 06:11:39 -0700779 packet = BuildRtpPacket(kPayload, kMarkerBit, timestamp, capture_time_ms);
780 packet_size = packet->size();
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000781
brandtr9dfff292016-11-14 05:14:50 -0800782 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kNormalPriority,
783 kSsrc, seq_num, _, _, _));
terelius5d332ac2016-01-14 14:37:39 -0800784
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000785 // Packet should be stored in a send bucket.
danilchapb6f1fb52016-10-19 06:11:39 -0700786 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
787 kAllowRetransmission,
Sergey Ulanov525df3f2016-08-02 17:46:41 -0700788 RtpPacketSender::kNormalPriority));
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000789
brandtr9dfff292016-11-14 05:14:50 -0800790 rtp_sender_->TimeToSendPacket(kSsrc, seq_num, capture_time_ms, false,
philipel8aadd502017-02-23 02:56:13 -0800791 PacedPacketInfo());
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000792 // Process send bucket.
danilchap12ba1862016-10-26 02:41:55 -0700793 EXPECT_EQ(++total_packets_sent, transport_.packets_sent());
794 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
795 transport_.last_sent_packet().GetHeader(&rtp_header);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000796
797 // Verify sequence number and timestamp.
798 EXPECT_EQ(seq_num, rtp_header.sequenceNumber);
799 EXPECT_EQ(timestamp, rtp_header.timestamp);
800 // Verify transmission time offset. This packet is sent without delay.
801 EXPECT_EQ(0, rtp_header.extension.transmissionTimeOffset);
802 uint64_t expected_send_time =
803 ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds());
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000804 EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime);
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000805}
pbos@webrtc.org8911ce42013-03-18 16:39:03 +0000806
minyue3a407ee2017-04-03 01:10:33 -0700807TEST_P(RtpSenderTest, OnSendPacketUpdated) {
stefana23fc622016-07-28 07:56:38 -0700808 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
809 kRtpExtensionTransportSequenceNumber,
810 kTransportSequenceNumberExtensionId));
asapersson35151f32016-05-02 23:44:01 -0700811 rtp_sender_->SetStorePacketsStatus(true, 10);
812
813 EXPECT_CALL(send_packet_observer_,
814 OnSendPacket(kTransportSequenceNumber, _, _))
815 .Times(1);
816 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
817 .WillOnce(testing::Return(kTransportSequenceNumber));
brandtr9dfff292016-11-14 05:14:50 -0800818 EXPECT_CALL(mock_paced_sender_, InsertPacket(_, kSsrc, kSeqNum, _, _, _))
819 .Times(1);
asapersson35151f32016-05-02 23:44:01 -0700820
821 SendGenericPayload(); // Packet passed to pacer.
822 const bool kIsRetransmit = false;
brandtr9dfff292016-11-14 05:14:50 -0800823 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum,
824 fake_clock_.TimeInMilliseconds(), kIsRetransmit,
philipel8aadd502017-02-23 02:56:13 -0800825 PacedPacketInfo());
danilchap12ba1862016-10-26 02:41:55 -0700826 EXPECT_EQ(1, transport_.packets_sent());
asapersson35151f32016-05-02 23:44:01 -0700827}
828
minyue3a407ee2017-04-03 01:10:33 -0700829TEST_P(RtpSenderTest, OnSendPacketNotUpdatedForRetransmits) {
stefana23fc622016-07-28 07:56:38 -0700830 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
831 kRtpExtensionTransportSequenceNumber,
832 kTransportSequenceNumberExtensionId));
asapersson35151f32016-05-02 23:44:01 -0700833 rtp_sender_->SetStorePacketsStatus(true, 10);
834
835 EXPECT_CALL(send_packet_observer_, OnSendPacket(_, _, _)).Times(0);
836 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
837 .WillOnce(testing::Return(kTransportSequenceNumber));
brandtr9dfff292016-11-14 05:14:50 -0800838 EXPECT_CALL(mock_paced_sender_, InsertPacket(_, kSsrc, kSeqNum, _, _, _))
839 .Times(1);
asapersson35151f32016-05-02 23:44:01 -0700840
841 SendGenericPayload(); // Packet passed to pacer.
842 const bool kIsRetransmit = true;
brandtr9dfff292016-11-14 05:14:50 -0800843 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum,
844 fake_clock_.TimeInMilliseconds(), kIsRetransmit,
philipel8aadd502017-02-23 02:56:13 -0800845 PacedPacketInfo());
danilchap12ba1862016-10-26 02:41:55 -0700846 EXPECT_EQ(1, transport_.packets_sent());
asapersson35151f32016-05-02 23:44:01 -0700847}
848
minyue3a407ee2017-04-03 01:10:33 -0700849TEST_P(RtpSenderTest, OnSendPacketNotUpdatedWithoutSeqNumAllocator) {
asapersson35151f32016-05-02 23:44:01 -0700850 rtp_sender_.reset(new RTPSender(
brandtrdbdb3f12016-11-10 05:04:48 -0800851 false, &fake_clock_, &transport_, &mock_paced_sender_, nullptr,
asapersson35151f32016-05-02 23:44:01 -0700852 nullptr /* TransportSequenceNumberAllocator */, nullptr, nullptr, nullptr,
michaelt4da30442016-11-17 01:38:43 -0800853 nullptr, nullptr, &send_packet_observer_, &retransmission_rate_limiter_,
Erik Språng7b52f102018-02-07 14:37:37 +0100854 nullptr, false));
brandtr9dfff292016-11-14 05:14:50 -0800855 rtp_sender_->SetSequenceNumber(kSeqNum);
856 rtp_sender_->SetSSRC(kSsrc);
stefana23fc622016-07-28 07:56:38 -0700857 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
858 kRtpExtensionTransportSequenceNumber,
859 kTransportSequenceNumberExtensionId));
asapersson35151f32016-05-02 23:44:01 -0700860 rtp_sender_->SetSequenceNumber(kSeqNum);
861 rtp_sender_->SetStorePacketsStatus(true, 10);
862
863 EXPECT_CALL(send_packet_observer_, OnSendPacket(_, _, _)).Times(0);
brandtr9dfff292016-11-14 05:14:50 -0800864 EXPECT_CALL(mock_paced_sender_, InsertPacket(_, kSsrc, kSeqNum, _, _, _))
865 .Times(1);
asapersson35151f32016-05-02 23:44:01 -0700866
867 SendGenericPayload(); // Packet passed to pacer.
868 const bool kIsRetransmit = false;
brandtr9dfff292016-11-14 05:14:50 -0800869 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum,
870 fake_clock_.TimeInMilliseconds(), kIsRetransmit,
philipel8aadd502017-02-23 02:56:13 -0800871 PacedPacketInfo());
danilchap12ba1862016-10-26 02:41:55 -0700872 EXPECT_EQ(1, transport_.packets_sent());
asapersson35151f32016-05-02 23:44:01 -0700873}
874
minyue3a407ee2017-04-03 01:10:33 -0700875TEST_P(RtpSenderTest, SendRedundantPayloads) {
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000876 MockTransport transport;
terelius429c3452016-01-21 05:42:04 -0800877 rtp_sender_.reset(new RTPSender(
asapersson35151f32016-05-02 23:44:01 -0700878 false, &fake_clock_, &transport, &mock_paced_sender_, nullptr, nullptr,
brandtrdbdb3f12016-11-10 05:04:48 -0800879 nullptr, nullptr, nullptr, nullptr, &mock_rtc_event_log_, nullptr,
Erik Språng7b52f102018-02-07 14:37:37 +0100880 &retransmission_rate_limiter_, nullptr, false));
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000881 rtp_sender_->SetSequenceNumber(kSeqNum);
brandtr9dfff292016-11-14 05:14:50 -0800882 rtp_sender_->SetSSRC(kSsrc);
Shao Changbine62202f2015-04-21 20:24:50 +0800883 rtp_sender_->SetRtxPayloadType(kRtxPayload, kPayload);
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000884
885 uint16_t seq_num = kSeqNum;
886 rtp_sender_->SetStorePacketsStatus(true, 10);
wu@webrtc.orgebdb0e32014-03-06 23:49:08 +0000887 int32_t rtp_header_len = kRtpHeaderSize;
danilchap162abd32015-12-10 02:39:40 -0800888 EXPECT_EQ(
889 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
890 kAbsoluteSendTimeExtensionId));
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000891 rtp_header_len += 4; // 4 bytes extension.
892 rtp_header_len += 4; // 4 extra bytes common to all extension headers.
893
pbos@webrtc.org0b0c2412015-01-13 14:15:15 +0000894 rtp_sender_->SetRtxStatus(kRtxRetransmitted | kRtxRedundantPayloads);
stefan@webrtc.orgef927552014-06-05 08:25:29 +0000895 rtp_sender_->SetRtxSsrc(1234);
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000896
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000897 const size_t kNumPayloadSizes = 10;
danilchap162abd32015-12-10 02:39:40 -0800898 const size_t kPayloadSizes[kNumPayloadSizes] = {500, 550, 600, 650, 700,
899 750, 800, 850, 900, 950};
terelius5d332ac2016-01-14 14:37:39 -0800900 // Expect all packets go through the pacer.
901 EXPECT_CALL(mock_paced_sender_,
brandtr9dfff292016-11-14 05:14:50 -0800902 InsertPacket(RtpPacketSender::kNormalPriority, kSsrc, _, _, _, _))
terelius5d332ac2016-01-14 14:37:39 -0800903 .Times(kNumPayloadSizes);
Elad Alon4a87e1c2017-10-03 16:11:34 +0200904 EXPECT_CALL(mock_rtc_event_log_,
905 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
terelius429c3452016-01-21 05:42:04 -0800906 .Times(kNumPayloadSizes);
907
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000908 // Send 10 packets of increasing size.
909 for (size_t i = 0; i < kNumPayloadSizes; ++i) {
910 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
stefan1d8a5062015-10-02 03:39:33 -0700911 EXPECT_CALL(transport, SendRtp(_, _, _)).WillOnce(testing::Return(true));
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000912 SendPacket(capture_time_ms, kPayloadSizes[i]);
brandtr9dfff292016-11-14 05:14:50 -0800913 rtp_sender_->TimeToSendPacket(kSsrc, seq_num++, capture_time_ms, false,
philipel8aadd502017-02-23 02:56:13 -0800914 PacedPacketInfo());
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000915 fake_clock_.AdvanceTimeMilliseconds(33);
916 }
terelius429c3452016-01-21 05:42:04 -0800917
Elad Alon4a87e1c2017-10-03 16:11:34 +0200918 EXPECT_CALL(mock_rtc_event_log_,
919 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
terelius429c3452016-01-21 05:42:04 -0800920 .Times(::testing::AtLeast(4));
921
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000922 // The amount of padding to send it too small to send a payload packet.
stefan1d8a5062015-10-02 03:39:33 -0700923 EXPECT_CALL(transport, SendRtp(_, kMaxPaddingSize + rtp_header_len, _))
pbos2d566682015-09-28 09:59:31 -0700924 .WillOnce(testing::Return(true));
philipela1ed0b32016-06-01 06:31:17 -0700925 EXPECT_EQ(kMaxPaddingSize,
philipel8aadd502017-02-23 02:56:13 -0800926 rtp_sender_->TimeToSendPadding(49, PacedPacketInfo()));
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000927
Peter Boströmac547a62015-09-17 23:03:57 +0200928 EXPECT_CALL(transport,
stefan1d8a5062015-10-02 03:39:33 -0700929 SendRtp(_, kPayloadSizes[0] + rtp_header_len + kRtxHeaderSize, _))
pbos2d566682015-09-28 09:59:31 -0700930 .WillOnce(testing::Return(true));
philipela1ed0b32016-06-01 06:31:17 -0700931 EXPECT_EQ(kPayloadSizes[0],
philipel8aadd502017-02-23 02:56:13 -0800932 rtp_sender_->TimeToSendPadding(500, PacedPacketInfo()));
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000933
pbos2d566682015-09-28 09:59:31 -0700934 EXPECT_CALL(transport, SendRtp(_, kPayloadSizes[kNumPayloadSizes - 1] +
stefan1d8a5062015-10-02 03:39:33 -0700935 rtp_header_len + kRtxHeaderSize,
936 _))
pbos2d566682015-09-28 09:59:31 -0700937 .WillOnce(testing::Return(true));
stefan1d8a5062015-10-02 03:39:33 -0700938 EXPECT_CALL(transport, SendRtp(_, kMaxPaddingSize + rtp_header_len, _))
pbos2d566682015-09-28 09:59:31 -0700939 .WillOnce(testing::Return(true));
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +0000940 EXPECT_EQ(kPayloadSizes[kNumPayloadSizes - 1] + kMaxPaddingSize,
philipel8aadd502017-02-23 02:56:13 -0800941 rtp_sender_->TimeToSendPadding(999, PacedPacketInfo()));
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000942}
943
minyue3a407ee2017-04-03 01:10:33 -0700944TEST_P(RtpSenderTestWithoutPacer, SendGenericVideo) {
pbos@webrtc.org8911ce42013-03-18 16:39:03 +0000945 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
946 const uint8_t payload_type = 127;
947 ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 90000,
948 0, 1500));
949 uint8_t payload[] = {47, 11, 32, 93, 89};
950
951 // Send keyframe
spranga8ae6f22017-09-04 07:23:56 -0700952 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
953 kVideoFrameKey, payload_type, 1234, 4321, payload, sizeof(payload),
954 nullptr, nullptr, nullptr, kDefaultExpectedRetransmissionTimeMs));
pbos@webrtc.org8911ce42013-03-18 16:39:03 +0000955
danilchap96c15872016-11-21 01:35:29 -0800956 auto sent_payload = transport_.last_sent_packet().payload();
957 uint8_t generic_header = sent_payload[0];
pbos@webrtc.org8911ce42013-03-18 16:39:03 +0000958 EXPECT_TRUE(generic_header & RtpFormatVideoGeneric::kKeyFrameBit);
959 EXPECT_TRUE(generic_header & RtpFormatVideoGeneric::kFirstPacketBit);
danilchap96c15872016-11-21 01:35:29 -0800960 EXPECT_THAT(sent_payload.subview(1), ElementsAreArray(payload));
pbos@webrtc.org8911ce42013-03-18 16:39:03 +0000961
962 // Send delta frame
963 payload[0] = 13;
964 payload[1] = 42;
965 payload[4] = 13;
966
Sergey Ulanov525df3f2016-08-02 17:46:41 -0700967 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
968 kVideoFrameDelta, payload_type, 1234, 4321, payload, sizeof(payload),
spranga8ae6f22017-09-04 07:23:56 -0700969 nullptr, nullptr, nullptr, kDefaultExpectedRetransmissionTimeMs));
pbos@webrtc.org8911ce42013-03-18 16:39:03 +0000970
danilchap96c15872016-11-21 01:35:29 -0800971 sent_payload = transport_.last_sent_packet().payload();
972 generic_header = sent_payload[0];
pbos@webrtc.org8911ce42013-03-18 16:39:03 +0000973 EXPECT_FALSE(generic_header & RtpFormatVideoGeneric::kKeyFrameBit);
974 EXPECT_TRUE(generic_header & RtpFormatVideoGeneric::kFirstPacketBit);
danilchap96c15872016-11-21 01:35:29 -0800975 EXPECT_THAT(sent_payload.subview(1), ElementsAreArray(payload));
pbos@webrtc.org8911ce42013-03-18 16:39:03 +0000976}
977
minyue3a407ee2017-04-03 01:10:33 -0700978TEST_P(RtpSenderTest, SendFlexfecPackets) {
brandtrdbdb3f12016-11-10 05:04:48 -0800979 constexpr int kMediaPayloadType = 127;
980 constexpr int kFlexfecPayloadType = 118;
981 constexpr uint32_t kMediaSsrc = 1234;
982 constexpr uint32_t kFlexfecSsrc = 5678;
983 const std::vector<RtpExtension> kNoRtpExtensions;
erikvarga27883732017-05-17 05:08:38 -0700984 const std::vector<RtpExtensionSize> kNoRtpExtensionSizes;
brandtrdbdb3f12016-11-10 05:04:48 -0800985 FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexfecSsrc, kMediaSsrc,
erikvarga27883732017-05-17 05:08:38 -0700986 kNoRtpExtensions, kNoRtpExtensionSizes,
brandtr48d21a22017-05-30 02:32:12 -0700987 nullptr /* rtp_state */, &fake_clock_);
brandtrdbdb3f12016-11-10 05:04:48 -0800988
989 // Reset |rtp_sender_| to use FlexFEC.
michaelt4da30442016-11-17 01:38:43 -0800990 rtp_sender_.reset(new RTPSender(
991 false, &fake_clock_, &transport_, &mock_paced_sender_, &flexfec_sender,
992 &seq_num_allocator_, nullptr, nullptr, nullptr, nullptr,
993 &mock_rtc_event_log_, &send_packet_observer_,
Erik Språng7b52f102018-02-07 14:37:37 +0100994 &retransmission_rate_limiter_, nullptr, false));
brandtrdbdb3f12016-11-10 05:04:48 -0800995 rtp_sender_->SetSSRC(kMediaSsrc);
996 rtp_sender_->SetSequenceNumber(kSeqNum);
brandtrdbdb3f12016-11-10 05:04:48 -0800997 rtp_sender_->SetStorePacketsStatus(true, 10);
998
999 // Parameters selected to generate a single FEC packet per media packet.
1000 FecProtectionParams params;
1001 params.fec_rate = 15;
1002 params.max_fec_frames = 1;
1003 params.fec_mask_type = kFecMaskRandom;
1004 rtp_sender_->SetFecParameters(params, params);
1005
brandtr9dfff292016-11-14 05:14:50 -08001006 EXPECT_CALL(mock_paced_sender_,
1007 InsertPacket(RtpPacketSender::kLowPriority, kMediaSsrc, kSeqNum,
1008 _, _, false));
1009 uint16_t flexfec_seq_num;
brandtrdbdb3f12016-11-10 05:04:48 -08001010 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kLowPriority,
brandtr9dfff292016-11-14 05:14:50 -08001011 kFlexfecSsrc, _, _, _, false))
1012 .WillOnce(testing::SaveArg<2>(&flexfec_seq_num));
brandtrdbdb3f12016-11-10 05:04:48 -08001013 SendGenericPayload();
Elad Alon4a87e1c2017-10-03 16:11:34 +02001014 EXPECT_CALL(mock_rtc_event_log_,
1015 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
1016 .Times(2);
philipel8aadd502017-02-23 02:56:13 -08001017 EXPECT_TRUE(rtp_sender_->TimeToSendPacket(kMediaSsrc, kSeqNum,
1018 fake_clock_.TimeInMilliseconds(),
1019 false, PacedPacketInfo()));
brandtr9dfff292016-11-14 05:14:50 -08001020 EXPECT_TRUE(rtp_sender_->TimeToSendPacket(kFlexfecSsrc, flexfec_seq_num,
1021 fake_clock_.TimeInMilliseconds(),
philipel8aadd502017-02-23 02:56:13 -08001022 false, PacedPacketInfo()));
brandtr9dfff292016-11-14 05:14:50 -08001023 ASSERT_EQ(2, transport_.packets_sent());
brandtrdbdb3f12016-11-10 05:04:48 -08001024 const RtpPacketReceived& media_packet = transport_.sent_packets_[0];
1025 EXPECT_EQ(kMediaPayloadType, media_packet.PayloadType());
brandtr9dfff292016-11-14 05:14:50 -08001026 EXPECT_EQ(kSeqNum, media_packet.SequenceNumber());
brandtrdbdb3f12016-11-10 05:04:48 -08001027 EXPECT_EQ(kMediaSsrc, media_packet.Ssrc());
brandtr9dfff292016-11-14 05:14:50 -08001028 const RtpPacketReceived& flexfec_packet = transport_.sent_packets_[1];
1029 EXPECT_EQ(kFlexfecPayloadType, flexfec_packet.PayloadType());
1030 EXPECT_EQ(flexfec_seq_num, flexfec_packet.SequenceNumber());
1031 EXPECT_EQ(kFlexfecSsrc, flexfec_packet.Ssrc());
brandtrdbdb3f12016-11-10 05:04:48 -08001032}
1033
ilnik10894992017-06-21 08:23:19 -07001034// TODO(ilnik): because of webrtc:7859. Once FEC moved below pacer, this test
1035// should be removed.
1036TEST_P(RtpSenderTest, NoFlexfecForTimingFrames) {
1037 constexpr int kMediaPayloadType = 127;
1038 constexpr int kFlexfecPayloadType = 118;
1039 constexpr uint32_t kMediaSsrc = 1234;
1040 constexpr uint32_t kFlexfecSsrc = 5678;
1041 const std::vector<RtpExtension> kNoRtpExtensions;
1042 const std::vector<RtpExtensionSize> kNoRtpExtensionSizes;
ilnike4350192017-06-29 02:27:44 -07001043
ilnik10894992017-06-21 08:23:19 -07001044 FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexfecSsrc, kMediaSsrc,
1045 kNoRtpExtensions, kNoRtpExtensionSizes,
1046 nullptr /* rtp_state */, &fake_clock_);
1047
1048 // Reset |rtp_sender_| to use FlexFEC.
1049 rtp_sender_.reset(new RTPSender(
1050 false, &fake_clock_, &transport_, &mock_paced_sender_, &flexfec_sender,
1051 &seq_num_allocator_, nullptr, nullptr, nullptr, nullptr,
1052 &mock_rtc_event_log_, &send_packet_observer_,
Erik Språng7b52f102018-02-07 14:37:37 +01001053 &retransmission_rate_limiter_, nullptr, false));
ilnik10894992017-06-21 08:23:19 -07001054 rtp_sender_->SetSSRC(kMediaSsrc);
1055 rtp_sender_->SetSequenceNumber(kSeqNum);
ilnik10894992017-06-21 08:23:19 -07001056 rtp_sender_->SetStorePacketsStatus(true, 10);
1057
ilnike4350192017-06-29 02:27:44 -07001058 // Need extension to be registered for timing frames to be sent.
1059 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
1060 kRtpExtensionVideoTiming, kVideoTimingExtensionId));
1061
ilnik10894992017-06-21 08:23:19 -07001062 // Parameters selected to generate a single FEC packet per media packet.
1063 FecProtectionParams params;
1064 params.fec_rate = 15;
1065 params.max_fec_frames = 1;
1066 params.fec_mask_type = kFecMaskRandom;
1067 rtp_sender_->SetFecParameters(params, params);
1068
1069 EXPECT_CALL(mock_paced_sender_,
1070 InsertPacket(RtpPacketSender::kLowPriority, kMediaSsrc, kSeqNum,
1071 _, _, false));
1072 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kLowPriority,
1073 kFlexfecSsrc, _, _, _, false))
1074 .Times(0); // Not called because packet should not be protected.
1075
1076 const uint32_t kTimestamp = 1234;
1077 const uint8_t kPayloadType = 127;
1078 const int64_t kCaptureTimeMs = fake_clock_.TimeInMilliseconds();
1079 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
1080 EXPECT_EQ(0, rtp_sender_->RegisterPayload(payload_name, kPayloadType, 90000,
1081 0, 1500));
1082 RTPVideoHeader video_header;
1083 memset(&video_header, 0, sizeof(RTPVideoHeader));
sprangba050a62017-08-18 02:51:12 -07001084 video_header.video_timing.flags = TimingFrameFlags::kTriggeredByTimer;
ilnik10894992017-06-21 08:23:19 -07001085 EXPECT_TRUE(rtp_sender_->SendOutgoingData(
1086 kVideoFrameKey, kPayloadType, kTimestamp, kCaptureTimeMs, kPayloadData,
spranga8ae6f22017-09-04 07:23:56 -07001087 sizeof(kPayloadData), nullptr, &video_header, nullptr,
1088 kDefaultExpectedRetransmissionTimeMs));
ilnik10894992017-06-21 08:23:19 -07001089
Elad Alon4a87e1c2017-10-03 16:11:34 +02001090 EXPECT_CALL(mock_rtc_event_log_,
1091 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
1092 .Times(1);
ilnik10894992017-06-21 08:23:19 -07001093 EXPECT_TRUE(rtp_sender_->TimeToSendPacket(kMediaSsrc, kSeqNum,
1094 fake_clock_.TimeInMilliseconds(),
1095 false, PacedPacketInfo()));
1096 ASSERT_EQ(1, transport_.packets_sent());
1097 const RtpPacketReceived& media_packet = transport_.sent_packets_[0];
1098 EXPECT_EQ(kMediaPayloadType, media_packet.PayloadType());
1099 EXPECT_EQ(kSeqNum, media_packet.SequenceNumber());
1100 EXPECT_EQ(kMediaSsrc, media_packet.Ssrc());
1101
1102 // Now try to send not a timing frame.
1103 uint16_t flexfec_seq_num;
1104 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kLowPriority,
1105 kFlexfecSsrc, _, _, _, false))
1106 .WillOnce(testing::SaveArg<2>(&flexfec_seq_num));
1107 EXPECT_CALL(mock_paced_sender_,
1108 InsertPacket(RtpPacketSender::kLowPriority, kMediaSsrc,
1109 kSeqNum + 1, _, _, false));
sprangba050a62017-08-18 02:51:12 -07001110 video_header.video_timing.flags = TimingFrameFlags::kInvalid;
ilnik10894992017-06-21 08:23:19 -07001111 EXPECT_TRUE(rtp_sender_->SendOutgoingData(
1112 kVideoFrameKey, kPayloadType, kTimestamp + 1, kCaptureTimeMs + 1,
spranga8ae6f22017-09-04 07:23:56 -07001113 kPayloadData, sizeof(kPayloadData), nullptr, &video_header, nullptr,
1114 kDefaultExpectedRetransmissionTimeMs));
ilnik10894992017-06-21 08:23:19 -07001115
Elad Alon4a87e1c2017-10-03 16:11:34 +02001116 EXPECT_CALL(mock_rtc_event_log_,
1117 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
1118 .Times(2);
ilnik10894992017-06-21 08:23:19 -07001119 EXPECT_TRUE(rtp_sender_->TimeToSendPacket(kMediaSsrc, kSeqNum + 1,
1120 fake_clock_.TimeInMilliseconds(),
1121 false, PacedPacketInfo()));
1122 EXPECT_TRUE(rtp_sender_->TimeToSendPacket(kFlexfecSsrc, flexfec_seq_num,
1123 fake_clock_.TimeInMilliseconds(),
1124 false, PacedPacketInfo()));
1125 ASSERT_EQ(3, transport_.packets_sent());
1126 const RtpPacketReceived& media_packet2 = transport_.sent_packets_[1];
1127 EXPECT_EQ(kMediaPayloadType, media_packet2.PayloadType());
1128 EXPECT_EQ(kSeqNum + 1, media_packet2.SequenceNumber());
1129 EXPECT_EQ(kMediaSsrc, media_packet2.Ssrc());
1130 const RtpPacketReceived& flexfec_packet = transport_.sent_packets_[2];
1131 EXPECT_EQ(kFlexfecPayloadType, flexfec_packet.PayloadType());
1132 EXPECT_EQ(flexfec_seq_num, flexfec_packet.SequenceNumber());
1133 EXPECT_EQ(kFlexfecSsrc, flexfec_packet.Ssrc());
1134}
1135
minyue3a407ee2017-04-03 01:10:33 -07001136TEST_P(RtpSenderTestWithoutPacer, SendFlexfecPackets) {
brandtrdbdb3f12016-11-10 05:04:48 -08001137 constexpr int kMediaPayloadType = 127;
1138 constexpr int kFlexfecPayloadType = 118;
1139 constexpr uint32_t kMediaSsrc = 1234;
1140 constexpr uint32_t kFlexfecSsrc = 5678;
1141 const std::vector<RtpExtension> kNoRtpExtensions;
erikvarga27883732017-05-17 05:08:38 -07001142 const std::vector<RtpExtensionSize> kNoRtpExtensionSizes;
brandtrdbdb3f12016-11-10 05:04:48 -08001143 FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexfecSsrc, kMediaSsrc,
erikvarga27883732017-05-17 05:08:38 -07001144 kNoRtpExtensions, kNoRtpExtensionSizes,
brandtr48d21a22017-05-30 02:32:12 -07001145 nullptr /* rtp_state */, &fake_clock_);
brandtrdbdb3f12016-11-10 05:04:48 -08001146
1147 // Reset |rtp_sender_| to use FlexFEC.
Erik Språng7b52f102018-02-07 14:37:37 +01001148 rtp_sender_.reset(
1149 new RTPSender(false, &fake_clock_, &transport_, nullptr, &flexfec_sender,
1150 &seq_num_allocator_, nullptr, nullptr, nullptr, nullptr,
1151 &mock_rtc_event_log_, &send_packet_observer_,
1152 &retransmission_rate_limiter_, nullptr, false));
brandtrdbdb3f12016-11-10 05:04:48 -08001153 rtp_sender_->SetSSRC(kMediaSsrc);
1154 rtp_sender_->SetSequenceNumber(kSeqNum);
brandtrdbdb3f12016-11-10 05:04:48 -08001155
1156 // Parameters selected to generate a single FEC packet per media packet.
1157 FecProtectionParams params;
1158 params.fec_rate = 15;
1159 params.max_fec_frames = 1;
1160 params.fec_mask_type = kFecMaskRandom;
1161 rtp_sender_->SetFecParameters(params, params);
1162
Elad Alon4a87e1c2017-10-03 16:11:34 +02001163 EXPECT_CALL(mock_rtc_event_log_,
1164 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
1165 .Times(2);
brandtrdbdb3f12016-11-10 05:04:48 -08001166 SendGenericPayload();
1167 ASSERT_EQ(2, transport_.packets_sent());
1168 const RtpPacketReceived& media_packet = transport_.sent_packets_[0];
1169 EXPECT_EQ(kMediaPayloadType, media_packet.PayloadType());
1170 EXPECT_EQ(kMediaSsrc, media_packet.Ssrc());
1171 const RtpPacketReceived& flexfec_packet = transport_.sent_packets_[1];
1172 EXPECT_EQ(kFlexfecPayloadType, flexfec_packet.PayloadType());
1173 EXPECT_EQ(kFlexfecSsrc, flexfec_packet.Ssrc());
1174}
1175
Steve Anton296a0ce2018-03-22 15:17:27 -07001176// Test that the MID header extension is included on sent packets when
1177// configured.
1178TEST_P(RtpSenderTestWithoutPacer, MidIncludedOnSentPackets) {
1179 const char kMid[] = "mid";
1180
1181 // Register MID header extension and set the MID for the RTPSender.
1182 rtp_sender_->SetSendingMediaStatus(false);
1183 rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionMid, kMidExtensionId);
1184 rtp_sender_->SetMid(kMid);
1185 rtp_sender_->SetSendingMediaStatus(true);
1186
1187 // Send a couple packets.
1188 SendGenericPayload();
1189 SendGenericPayload();
1190
1191 // Expect both packets to have the MID set.
1192 ASSERT_EQ(2u, transport_.sent_packets_.size());
1193 for (const RtpPacketReceived& packet : transport_.sent_packets_) {
1194 std::string mid;
1195 ASSERT_TRUE(packet.GetExtension<RtpMid>(&mid));
1196 EXPECT_EQ(kMid, mid);
1197 }
1198}
1199
minyue3a407ee2017-04-03 01:10:33 -07001200TEST_P(RtpSenderTest, FecOverheadRate) {
brandtr81eab612017-01-24 04:06:09 -08001201 constexpr int kFlexfecPayloadType = 118;
1202 constexpr uint32_t kMediaSsrc = 1234;
1203 constexpr uint32_t kFlexfecSsrc = 5678;
1204 const std::vector<RtpExtension> kNoRtpExtensions;
erikvarga27883732017-05-17 05:08:38 -07001205 const std::vector<RtpExtensionSize> kNoRtpExtensionSizes;
brandtr81eab612017-01-24 04:06:09 -08001206 FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexfecSsrc, kMediaSsrc,
erikvarga27883732017-05-17 05:08:38 -07001207 kNoRtpExtensions, kNoRtpExtensionSizes,
brandtr48d21a22017-05-30 02:32:12 -07001208 nullptr /* rtp_state */, &fake_clock_);
brandtr81eab612017-01-24 04:06:09 -08001209
1210 // Reset |rtp_sender_| to use FlexFEC.
1211 rtp_sender_.reset(new RTPSender(
1212 false, &fake_clock_, &transport_, &mock_paced_sender_, &flexfec_sender,
1213 &seq_num_allocator_, nullptr, nullptr, nullptr, nullptr,
1214 &mock_rtc_event_log_, &send_packet_observer_,
Erik Språng7b52f102018-02-07 14:37:37 +01001215 &retransmission_rate_limiter_, nullptr, false));
brandtr81eab612017-01-24 04:06:09 -08001216 rtp_sender_->SetSSRC(kMediaSsrc);
1217 rtp_sender_->SetSequenceNumber(kSeqNum);
brandtr81eab612017-01-24 04:06:09 -08001218
1219 // Parameters selected to generate a single FEC packet per media packet.
1220 FecProtectionParams params;
1221 params.fec_rate = 15;
1222 params.max_fec_frames = 1;
1223 params.fec_mask_type = kFecMaskRandom;
1224 rtp_sender_->SetFecParameters(params, params);
1225
1226 constexpr size_t kNumMediaPackets = 10;
1227 constexpr size_t kNumFecPackets = kNumMediaPackets;
1228 constexpr int64_t kTimeBetweenPacketsMs = 10;
1229 EXPECT_CALL(mock_paced_sender_, InsertPacket(_, _, _, _, _, false))
1230 .Times(kNumMediaPackets + kNumFecPackets);
1231 for (size_t i = 0; i < kNumMediaPackets; ++i) {
1232 SendGenericPayload();
1233 fake_clock_.AdvanceTimeMilliseconds(kTimeBetweenPacketsMs);
1234 }
1235 constexpr size_t kRtpHeaderLength = 12;
1236 constexpr size_t kFlexfecHeaderLength = 20;
1237 constexpr size_t kGenericCodecHeaderLength = 1;
1238 constexpr size_t kPayloadLength = sizeof(kPayloadData);
1239 constexpr size_t kPacketLength = kRtpHeaderLength + kFlexfecHeaderLength +
1240 kGenericCodecHeaderLength + kPayloadLength;
1241 EXPECT_NEAR(kNumFecPackets * kPacketLength * 8 /
1242 (kNumFecPackets * kTimeBetweenPacketsMs / 1000.0f),
1243 rtp_sender_->FecOverheadRate(), 500);
1244}
1245
minyue3a407ee2017-04-03 01:10:33 -07001246TEST_P(RtpSenderTest, FrameCountCallbacks) {
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001247 class TestCallback : public FrameCountObserver {
1248 public:
pbos@webrtc.orgce4e9a32014-12-18 13:50:16 +00001249 TestCallback() : FrameCountObserver(), num_calls_(0), ssrc_(0) {}
Danil Chapovalovdd7e2842018-03-09 15:37:03 +00001250 ~TestCallback() override = default;
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001251
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00001252 void FrameCountUpdated(const FrameCounts& frame_counts,
1253 uint32_t ssrc) override {
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001254 ++num_calls_;
1255 ssrc_ = ssrc;
pbos@webrtc.orgce4e9a32014-12-18 13:50:16 +00001256 frame_counts_ = frame_counts;
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001257 }
1258
1259 uint32_t num_calls_;
1260 uint32_t ssrc_;
pbos@webrtc.orgce4e9a32014-12-18 13:50:16 +00001261 FrameCounts frame_counts_;
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001262 } callback;
1263
Erik Språng7b52f102018-02-07 14:37:37 +01001264 rtp_sender_.reset(new RTPSender(
1265 false, &fake_clock_, &transport_, &mock_paced_sender_, nullptr, nullptr,
1266 nullptr, nullptr, &callback, nullptr, nullptr, nullptr,
1267 &retransmission_rate_limiter_, nullptr, false));
nisse7d59f6b2017-02-21 03:40:24 -08001268 rtp_sender_->SetSSRC(kSsrc);
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001269 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
1270 const uint8_t payload_type = 127;
1271 ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 90000,
1272 0, 1500));
1273 uint8_t payload[] = {47, 11, 32, 93, 89};
1274 rtp_sender_->SetStorePacketsStatus(true, 1);
1275 uint32_t ssrc = rtp_sender_->SSRC();
1276
terelius5d332ac2016-01-14 14:37:39 -08001277 EXPECT_CALL(mock_paced_sender_, InsertPacket(_, _, _, _, _, _))
1278 .Times(::testing::AtLeast(2));
1279
spranga8ae6f22017-09-04 07:23:56 -07001280 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
1281 kVideoFrameKey, payload_type, 1234, 4321, payload, sizeof(payload),
1282 nullptr, nullptr, nullptr, kDefaultExpectedRetransmissionTimeMs));
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001283
1284 EXPECT_EQ(1U, callback.num_calls_);
1285 EXPECT_EQ(ssrc, callback.ssrc_);
pbos@webrtc.orgce4e9a32014-12-18 13:50:16 +00001286 EXPECT_EQ(1, callback.frame_counts_.key_frames);
1287 EXPECT_EQ(0, callback.frame_counts_.delta_frames);
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001288
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001289 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
1290 kVideoFrameDelta, payload_type, 1234, 4321, payload, sizeof(payload),
spranga8ae6f22017-09-04 07:23:56 -07001291 nullptr, nullptr, nullptr, kDefaultExpectedRetransmissionTimeMs));
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001292
1293 EXPECT_EQ(2U, callback.num_calls_);
1294 EXPECT_EQ(ssrc, callback.ssrc_);
pbos@webrtc.orgce4e9a32014-12-18 13:50:16 +00001295 EXPECT_EQ(1, callback.frame_counts_.key_frames);
1296 EXPECT_EQ(1, callback.frame_counts_.delta_frames);
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001297
andresp@webrtc.org8f151212014-07-10 09:39:23 +00001298 rtp_sender_.reset();
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001299}
1300
minyue3a407ee2017-04-03 01:10:33 -07001301TEST_P(RtpSenderTest, BitrateCallbacks) {
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001302 class TestCallback : public BitrateStatisticsObserver {
1303 public:
sprangcd349d92016-07-13 09:11:28 -07001304 TestCallback()
1305 : BitrateStatisticsObserver(),
1306 num_calls_(0),
1307 ssrc_(0),
1308 total_bitrate_(0),
1309 retransmit_bitrate_(0) {}
Danil Chapovalovdd7e2842018-03-09 15:37:03 +00001310 ~TestCallback() override = default;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001311
sprangcd349d92016-07-13 09:11:28 -07001312 void Notify(uint32_t total_bitrate,
1313 uint32_t retransmit_bitrate,
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00001314 uint32_t ssrc) override {
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001315 ++num_calls_;
1316 ssrc_ = ssrc;
sprangcd349d92016-07-13 09:11:28 -07001317 total_bitrate_ = total_bitrate;
1318 retransmit_bitrate_ = retransmit_bitrate;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001319 }
1320
1321 uint32_t num_calls_;
1322 uint32_t ssrc_;
sprangcd349d92016-07-13 09:11:28 -07001323 uint32_t total_bitrate_;
1324 uint32_t retransmit_bitrate_;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001325 } callback;
Erik Språng7b52f102018-02-07 14:37:37 +01001326 rtp_sender_.reset(
1327 new RTPSender(false, &fake_clock_, &transport_, nullptr, nullptr, nullptr,
1328 nullptr, &callback, nullptr, nullptr, nullptr, nullptr,
1329 &retransmission_rate_limiter_, nullptr, false));
nisse7d59f6b2017-02-21 03:40:24 -08001330 rtp_sender_->SetSSRC(kSsrc);
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001331
sprangcd349d92016-07-13 09:11:28 -07001332 // Simulate kNumPackets sent with kPacketInterval ms intervals, with the
1333 // number of packets selected so that we fill (but don't overflow) the one
1334 // second averaging window.
1335 const uint32_t kWindowSizeMs = 1000;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001336 const uint32_t kPacketInterval = 20;
sprangcd349d92016-07-13 09:11:28 -07001337 const uint32_t kNumPackets =
1338 (kWindowSizeMs - kPacketInterval) / kPacketInterval;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001339 // Overhead = 12 bytes RTP header + 1 byte generic header.
1340 const uint32_t kPacketOverhead = 13;
1341
1342 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
1343 const uint8_t payload_type = 127;
danilchap162abd32015-12-10 02:39:40 -08001344 ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 90000,
1345 0, 1500));
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001346 uint8_t payload[] = {47, 11, 32, 93, 89};
1347 rtp_sender_->SetStorePacketsStatus(true, 1);
1348 uint32_t ssrc = rtp_sender_->SSRC();
1349
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001350 // Initial process call so we get a new time window.
1351 rtp_sender_->ProcessBitrate();
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001352
1353 // Send a few frames.
1354 for (uint32_t i = 0; i < kNumPackets; ++i) {
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001355 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
1356 kVideoFrameKey, payload_type, 1234, 4321, payload, sizeof(payload),
spranga8ae6f22017-09-04 07:23:56 -07001357 nullptr, nullptr, nullptr, kDefaultExpectedRetransmissionTimeMs));
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001358 fake_clock_.AdvanceTimeMilliseconds(kPacketInterval);
1359 }
1360
1361 rtp_sender_->ProcessBitrate();
1362
stefan@webrtc.org0bae1fa2014-11-05 14:05:29 +00001363 // We get one call for every stats updated, thus two calls since both the
1364 // stream stats and the retransmit stats are updated once.
1365 EXPECT_EQ(2u, callback.num_calls_);
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001366 EXPECT_EQ(ssrc, callback.ssrc_);
sprangcd349d92016-07-13 09:11:28 -07001367 const uint32_t kTotalPacketSize = kPacketOverhead + sizeof(payload);
1368 // Bitrate measured over delta between last and first timestamp, plus one.
1369 const uint32_t kExpectedWindowMs = kNumPackets * kPacketInterval + 1;
1370 const uint32_t kExpectedBitsAccumulated = kTotalPacketSize * kNumPackets * 8;
1371 const uint32_t kExpectedRateBps =
1372 (kExpectedBitsAccumulated * 1000 + (kExpectedWindowMs / 2)) /
1373 kExpectedWindowMs;
1374 EXPECT_EQ(kExpectedRateBps, callback.total_bitrate_);
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001375
andresp@webrtc.orgd11bec42014-07-08 14:32:58 +00001376 rtp_sender_.reset();
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001377}
1378
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001379class RtpSenderAudioTest : public RtpSenderTest {
1380 protected:
1381 RtpSenderAudioTest() {}
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001382
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00001383 void SetUp() override {
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001384 payload_ = kAudioPayload;
Erik Språng7b52f102018-02-07 14:37:37 +01001385 rtp_sender_.reset(
1386 new RTPSender(true, &fake_clock_, &transport_, nullptr, nullptr,
1387 nullptr, nullptr, nullptr, nullptr, nullptr, nullptr,
1388 nullptr, &retransmission_rate_limiter_, nullptr, false));
nisse7d59f6b2017-02-21 03:40:24 -08001389 rtp_sender_->SetSSRC(kSsrc);
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001390 rtp_sender_->SetSequenceNumber(kSeqNum);
1391 }
1392};
1393
minyue3a407ee2017-04-03 01:10:33 -07001394TEST_P(RtpSenderTestWithoutPacer, StreamDataCountersCallbacks) {
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001395 class TestCallback : public StreamDataCountersCallback {
1396 public:
danilchap162abd32015-12-10 02:39:40 -08001397 TestCallback() : StreamDataCountersCallback(), ssrc_(0), counters_() {}
Danil Chapovalovdd7e2842018-03-09 15:37:03 +00001398 ~TestCallback() override = default;
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001399
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00001400 void DataCountersUpdated(const StreamDataCounters& counters,
1401 uint32_t ssrc) override {
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001402 ssrc_ = ssrc;
1403 counters_ = counters;
1404 }
1405
1406 uint32_t ssrc_;
1407 StreamDataCounters counters_;
asapersson@webrtc.org44149392015-02-04 08:34:47 +00001408
1409 void MatchPacketCounter(const RtpPacketCounter& expected,
1410 const RtpPacketCounter& actual) {
1411 EXPECT_EQ(expected.payload_bytes, actual.payload_bytes);
1412 EXPECT_EQ(expected.header_bytes, actual.header_bytes);
1413 EXPECT_EQ(expected.padding_bytes, actual.padding_bytes);
1414 EXPECT_EQ(expected.packets, actual.packets);
1415 }
1416
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001417 void Matches(uint32_t ssrc, const StreamDataCounters& counters) {
1418 EXPECT_EQ(ssrc, ssrc_);
asapersson@webrtc.org44149392015-02-04 08:34:47 +00001419 MatchPacketCounter(counters.transmitted, counters_.transmitted);
1420 MatchPacketCounter(counters.retransmitted, counters_.retransmitted);
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001421 EXPECT_EQ(counters.fec.packets, counters_.fec.packets);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001422 }
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001423 } callback;
1424
1425 const uint8_t kRedPayloadType = 96;
1426 const uint8_t kUlpfecPayloadType = 97;
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001427 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
1428 const uint8_t payload_type = 127;
1429 ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 90000,
1430 0, 1500));
1431 uint8_t payload[] = {47, 11, 32, 93, 89};
1432 rtp_sender_->SetStorePacketsStatus(true, 1);
1433 uint32_t ssrc = rtp_sender_->SSRC();
1434
1435 rtp_sender_->RegisterRtpStatisticsCallback(&callback);
1436
1437 // Send a frame.
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001438 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001439 kVideoFrameKey, payload_type, 1234, 4321, payload, sizeof(payload),
1440 nullptr, nullptr, nullptr, kDefaultExpectedRetransmissionTimeMs));
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001441 StreamDataCounters expected;
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001442 expected.transmitted.payload_bytes = 6;
1443 expected.transmitted.header_bytes = 12;
1444 expected.transmitted.padding_bytes = 0;
1445 expected.transmitted.packets = 1;
1446 expected.retransmitted.payload_bytes = 0;
1447 expected.retransmitted.header_bytes = 0;
1448 expected.retransmitted.padding_bytes = 0;
1449 expected.retransmitted.packets = 0;
1450 expected.fec.packets = 0;
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001451 callback.Matches(ssrc, expected);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001452
1453 // Retransmit a frame.
1454 uint16_t seqno = rtp_sender_->SequenceNumber() - 1;
Erik Språnga12b1d62018-03-14 12:39:24 +01001455 rtp_sender_->ReSendPacket(seqno);
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001456 expected.transmitted.payload_bytes = 12;
1457 expected.transmitted.header_bytes = 24;
1458 expected.transmitted.packets = 2;
1459 expected.retransmitted.payload_bytes = 6;
1460 expected.retransmitted.header_bytes = 12;
1461 expected.retransmitted.padding_bytes = 0;
1462 expected.retransmitted.packets = 1;
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001463 callback.Matches(ssrc, expected);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001464
1465 // Send padding.
philipel8aadd502017-02-23 02:56:13 -08001466 rtp_sender_->TimeToSendPadding(kMaxPaddingSize, PacedPacketInfo());
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001467 expected.transmitted.payload_bytes = 12;
1468 expected.transmitted.header_bytes = 36;
1469 expected.transmitted.padding_bytes = kMaxPaddingSize;
1470 expected.transmitted.packets = 3;
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001471 callback.Matches(ssrc, expected);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001472
brandtrf1bb4762016-11-07 03:05:06 -08001473 // Send ULPFEC.
1474 rtp_sender_->SetUlpfecConfig(kRedPayloadType, kUlpfecPayloadType);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001475 FecProtectionParams fec_params;
1476 fec_params.fec_mask_type = kFecMaskRandom;
1477 fec_params.fec_rate = 1;
1478 fec_params.max_fec_frames = 1;
brandtr1743a192016-11-07 03:36:05 -08001479 rtp_sender_->SetFecParameters(fec_params, fec_params);
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001480 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001481 kVideoFrameDelta, payload_type, 1234, 4321, payload, sizeof(payload),
1482 nullptr, nullptr, nullptr, kDefaultExpectedRetransmissionTimeMs));
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001483 expected.transmitted.payload_bytes = 40;
1484 expected.transmitted.header_bytes = 60;
1485 expected.transmitted.packets = 5;
1486 expected.fec.packets = 1;
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001487 callback.Matches(ssrc, expected);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001488
sprang867fb522015-08-03 04:38:41 -07001489 rtp_sender_->RegisterRtpStatisticsCallback(nullptr);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001490}
1491
minyue3a407ee2017-04-03 01:10:33 -07001492TEST_P(RtpSenderAudioTest, SendAudio) {
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001493 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "PAYLOAD_NAME";
1494 const uint8_t payload_type = 127;
1495 ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 48000,
1496 0, 1500));
1497 uint8_t payload[] = {47, 11, 32, 93, 89};
1498
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001499 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001500 kAudioFrameCN, payload_type, 1234, 4321, payload, sizeof(payload),
1501 nullptr, nullptr, nullptr, kDefaultExpectedRetransmissionTimeMs));
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001502
danilchap96c15872016-11-21 01:35:29 -08001503 auto sent_payload = transport_.last_sent_packet().payload();
1504 EXPECT_THAT(sent_payload, ElementsAreArray(payload));
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001505}
1506
minyue3a407ee2017-04-03 01:10:33 -07001507TEST_P(RtpSenderAudioTest, SendAudioWithAudioLevelExtension) {
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001508 EXPECT_EQ(0, rtp_sender_->SetAudioLevel(kAudioLevel));
danilchap162abd32015-12-10 02:39:40 -08001509 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAudioLevel,
1510 kAudioLevelExtensionId));
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001511
1512 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "PAYLOAD_NAME";
1513 const uint8_t payload_type = 127;
1514 ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 48000,
1515 0, 1500));
1516 uint8_t payload[] = {47, 11, 32, 93, 89};
1517
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001518 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001519 kAudioFrameCN, payload_type, 1234, 4321, payload, sizeof(payload),
1520 nullptr, nullptr, nullptr, kDefaultExpectedRetransmissionTimeMs));
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001521
danilchap96c15872016-11-21 01:35:29 -08001522 auto sent_payload = transport_.last_sent_packet().payload();
1523 EXPECT_THAT(sent_payload, ElementsAreArray(payload));
danilchap12ba1862016-10-26 02:41:55 -07001524 // Verify AudioLevel extension.
1525 bool voice_activity;
1526 uint8_t audio_level;
1527 EXPECT_TRUE(transport_.last_sent_packet().GetExtension<AudioLevel>(
1528 &voice_activity, &audio_level));
1529 EXPECT_EQ(kAudioLevel, audio_level);
1530 EXPECT_FALSE(voice_activity);
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001531}
1532
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001533// As RFC4733, named telephone events are carried as part of the audio stream
1534// and must use the same sequence number and timestamp base as the regular
1535// audio channel.
1536// This test checks the marker bit for the first packet and the consequent
1537// packets of the same telephone event. Since it is specifically for DTMF
pbos22993e12015-10-19 02:39:06 -07001538// events, ignoring audio packets and sending kEmptyFrame instead of those.
minyue3a407ee2017-04-03 01:10:33 -07001539TEST_P(RtpSenderAudioTest, CheckMarkerBitForTelephoneEvents) {
solenbergffbbcac2016-11-17 05:25:37 -08001540 const char* kDtmfPayloadName = "telephone-event";
1541 const uint32_t kPayloadFrequency = 8000;
1542 const uint8_t kPayloadType = 126;
1543 ASSERT_EQ(0, rtp_sender_->RegisterPayload(kDtmfPayloadName, kPayloadType,
1544 kPayloadFrequency, 0, 0));
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001545 // For Telephone events, payload is not added to the registered payload list,
1546 // it will register only the payload used for audio stream.
1547 // Registering the payload again for audio stream with different payload name.
solenbergffbbcac2016-11-17 05:25:37 -08001548 const char* kPayloadName = "payload_name";
1549 ASSERT_EQ(0, rtp_sender_->RegisterPayload(kPayloadName, kPayloadType,
1550 kPayloadFrequency, 1, 0));
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001551 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
1552 // DTMF event key=9, duration=500 and attenuationdB=10
1553 rtp_sender_->SendTelephoneEvent(9, 500, 10);
1554 // During start, it takes the starting timestamp as last sent timestamp.
1555 // The duration is calculated as the difference of current and last sent
1556 // timestamp. So for first call it will skip since the duration is zero.
spranga8ae6f22017-09-04 07:23:56 -07001557 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
1558 kEmptyFrame, kPayloadType, capture_time_ms, 0, nullptr, 0, nullptr,
1559 nullptr, nullptr, kDefaultExpectedRetransmissionTimeMs));
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001560 // DTMF Sample Length is (Frequency/1000) * Duration.
1561 // So in this case, it is (8000/1000) * 500 = 4000.
1562 // Sending it as two packets.
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001563 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001564 kEmptyFrame, kPayloadType, capture_time_ms + 2000, 0, nullptr, 0, nullptr,
1565 nullptr, nullptr, kDefaultExpectedRetransmissionTimeMs));
danilchap12ba1862016-10-26 02:41:55 -07001566
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001567 // Marker Bit should be set to 1 for first packet.
danilchap12ba1862016-10-26 02:41:55 -07001568 EXPECT_TRUE(transport_.last_sent_packet().Marker());
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001569
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001570 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001571 kEmptyFrame, kPayloadType, capture_time_ms + 4000, 0, nullptr, 0, nullptr,
1572 nullptr, nullptr, kDefaultExpectedRetransmissionTimeMs));
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001573 // Marker Bit should be set to 0 for rest of the packets.
danilchap12ba1862016-10-26 02:41:55 -07001574 EXPECT_FALSE(transport_.last_sent_packet().Marker());
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001575}
1576
minyue3a407ee2017-04-03 01:10:33 -07001577TEST_P(RtpSenderTestWithoutPacer, BytesReportedCorrectly) {
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001578 const char* kPayloadName = "GENERIC";
1579 const uint8_t kPayloadType = 127;
1580 rtp_sender_->SetSSRC(1234);
1581 rtp_sender_->SetRtxSsrc(4321);
Shao Changbine62202f2015-04-21 20:24:50 +08001582 rtp_sender_->SetRtxPayloadType(kPayloadType - 1, kPayloadType);
pbos@webrtc.org0b0c2412015-01-13 14:15:15 +00001583 rtp_sender_->SetRtxStatus(kRtxRetransmitted | kRtxRedundantPayloads);
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001584
danilchap162abd32015-12-10 02:39:40 -08001585 ASSERT_EQ(0, rtp_sender_->RegisterPayload(kPayloadName, kPayloadType, 90000,
1586 0, 1500));
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001587 uint8_t payload[] = {47, 11, 32, 93, 89};
1588
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001589 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001590 kVideoFrameKey, kPayloadType, 1234, 4321, payload, sizeof(payload),
1591 nullptr, nullptr, nullptr, kDefaultExpectedRetransmissionTimeMs));
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001592
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +00001593 // Will send 2 full-size padding packets.
philipel8aadd502017-02-23 02:56:13 -08001594 rtp_sender_->TimeToSendPadding(1, PacedPacketInfo());
1595 rtp_sender_->TimeToSendPadding(1, PacedPacketInfo());
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001596
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +00001597 StreamDataCounters rtp_stats;
1598 StreamDataCounters rtx_stats;
1599 rtp_sender_->GetDataCounters(&rtp_stats, &rtx_stats);
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001600
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +00001601 // Payload + 1-byte generic header.
asapersson@webrtc.orgd08d3892014-12-16 12:03:11 +00001602 EXPECT_GT(rtp_stats.first_packet_time_ms, -1);
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001603 EXPECT_EQ(rtp_stats.transmitted.payload_bytes, sizeof(payload) + 1);
1604 EXPECT_EQ(rtp_stats.transmitted.header_bytes, 12u);
1605 EXPECT_EQ(rtp_stats.transmitted.padding_bytes, 0u);
1606 EXPECT_EQ(rtx_stats.transmitted.payload_bytes, 0u);
1607 EXPECT_EQ(rtx_stats.transmitted.header_bytes, 24u);
1608 EXPECT_EQ(rtx_stats.transmitted.padding_bytes, 2 * kMaxPaddingSize);
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +00001609
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001610 EXPECT_EQ(rtp_stats.transmitted.TotalBytes(),
danilchap162abd32015-12-10 02:39:40 -08001611 rtp_stats.transmitted.payload_bytes +
1612 rtp_stats.transmitted.header_bytes +
1613 rtp_stats.transmitted.padding_bytes);
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001614 EXPECT_EQ(rtx_stats.transmitted.TotalBytes(),
danilchap162abd32015-12-10 02:39:40 -08001615 rtx_stats.transmitted.payload_bytes +
1616 rtx_stats.transmitted.header_bytes +
1617 rtx_stats.transmitted.padding_bytes);
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001618
danilchap162abd32015-12-10 02:39:40 -08001619 EXPECT_EQ(
1620 transport_.total_bytes_sent_,
1621 rtp_stats.transmitted.TotalBytes() + rtx_stats.transmitted.TotalBytes());
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001622}
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001623
minyue3a407ee2017-04-03 01:10:33 -07001624TEST_P(RtpSenderTestWithoutPacer, RespectsNackBitrateLimit) {
sprang38778b02015-09-29 09:48:22 -07001625 const int32_t kPacketSize = 1400;
1626 const int32_t kNumPackets = 30;
1627
sprangcd349d92016-07-13 09:11:28 -07001628 retransmission_rate_limiter_.SetMaxRate(kPacketSize * kNumPackets * 8);
1629
sprang38778b02015-09-29 09:48:22 -07001630 rtp_sender_->SetStorePacketsStatus(true, kNumPackets);
sprang38778b02015-09-29 09:48:22 -07001631 const uint16_t kStartSequenceNumber = rtp_sender_->SequenceNumber();
Danil Chapovalov2800d742016-08-26 18:48:46 +02001632 std::vector<uint16_t> sequence_numbers;
sprang38778b02015-09-29 09:48:22 -07001633 for (int32_t i = 0; i < kNumPackets; ++i) {
1634 sequence_numbers.push_back(kStartSequenceNumber + i);
1635 fake_clock_.AdvanceTimeMilliseconds(1);
1636 SendPacket(fake_clock_.TimeInMilliseconds(), kPacketSize);
1637 }
danilchap12ba1862016-10-26 02:41:55 -07001638 EXPECT_EQ(kNumPackets, transport_.packets_sent());
sprang38778b02015-09-29 09:48:22 -07001639
1640 fake_clock_.AdvanceTimeMilliseconds(1000 - kNumPackets);
1641
1642 // Resending should work - brings the bandwidth up to the limit.
1643 // NACK bitrate is capped to the same bitrate as the encoder, since the max
1644 // protection overhead is 50% (see MediaOptimization::SetTargetRates).
Danil Chapovalov2800d742016-08-26 18:48:46 +02001645 rtp_sender_->OnReceivedNack(sequence_numbers, 0);
danilchap12ba1862016-10-26 02:41:55 -07001646 EXPECT_EQ(kNumPackets * 2, transport_.packets_sent());
sprang38778b02015-09-29 09:48:22 -07001647
sprangcd349d92016-07-13 09:11:28 -07001648 // Must be at least 5ms in between retransmission attempts.
1649 fake_clock_.AdvanceTimeMilliseconds(5);
1650
sprang38778b02015-09-29 09:48:22 -07001651 // Resending should not work, bandwidth exceeded.
Danil Chapovalov2800d742016-08-26 18:48:46 +02001652 rtp_sender_->OnReceivedNack(sequence_numbers, 0);
danilchap12ba1862016-10-26 02:41:55 -07001653 EXPECT_EQ(kNumPackets * 2, transport_.packets_sent());
sprang38778b02015-09-29 09:48:22 -07001654}
1655
minyue3a407ee2017-04-03 01:10:33 -07001656TEST_P(RtpSenderVideoTest, KeyFrameHasCVO) {
danilchapb6f1fb52016-10-19 06:11:39 -07001657 uint8_t kFrame[kMaxPacketLength];
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001658 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
1659 kRtpExtensionVideoRotation, kVideoRotationExtensionId));
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001660
danilchapc1600c52016-10-26 03:33:11 -07001661 RTPVideoHeader hdr = {0};
1662 hdr.rotation = kVideoRotation_0;
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001663 rtp_sender_video_->SendVideo(kRtpVideoGeneric, kVideoFrameKey, kPayload,
danilchapb6f1fb52016-10-19 06:11:39 -07001664 kTimestamp, 0, kFrame, sizeof(kFrame), nullptr,
spranga8ae6f22017-09-04 07:23:56 -07001665 &hdr, kDefaultExpectedRetransmissionTimeMs);
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001666
danilchapc1600c52016-10-26 03:33:11 -07001667 VideoRotation rotation;
1668 EXPECT_TRUE(
1669 transport_.last_sent_packet().GetExtension<VideoOrientation>(&rotation));
1670 EXPECT_EQ(kVideoRotation_0, rotation);
1671}
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001672
ilnik04f4d122017-06-19 07:18:55 -07001673TEST_P(RtpSenderVideoTest, TimingFrameHasPacketizationTimstampSet) {
1674 uint8_t kFrame[kMaxPacketLength];
1675 const int64_t kPacketizationTimeMs = 100;
1676 const int64_t kEncodeStartDeltaMs = 10;
1677 const int64_t kEncodeFinishDeltaMs = 50;
1678 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
1679 kRtpExtensionVideoTiming, kVideoTimingExtensionId));
1680
1681 const int64_t kCaptureTimestamp = fake_clock_.TimeInMilliseconds();
1682
1683 RTPVideoHeader hdr = {0};
sprangba050a62017-08-18 02:51:12 -07001684 hdr.video_timing.flags = TimingFrameFlags::kTriggeredByTimer;
ilnik04f4d122017-06-19 07:18:55 -07001685 hdr.video_timing.encode_start_delta_ms = kEncodeStartDeltaMs;
1686 hdr.video_timing.encode_finish_delta_ms = kEncodeFinishDeltaMs;
1687
1688 fake_clock_.AdvanceTimeMilliseconds(kPacketizationTimeMs);
1689 rtp_sender_video_->SendVideo(kRtpVideoGeneric, kVideoFrameKey, kPayload,
1690 kTimestamp, kCaptureTimestamp, kFrame,
spranga8ae6f22017-09-04 07:23:56 -07001691 sizeof(kFrame), nullptr, &hdr,
1692 kDefaultExpectedRetransmissionTimeMs);
ilnik2edc6842017-07-06 03:06:50 -07001693 VideoSendTiming timing;
ilnik04f4d122017-06-19 07:18:55 -07001694 EXPECT_TRUE(transport_.last_sent_packet().GetExtension<VideoTimingExtension>(
1695 &timing));
1696 EXPECT_EQ(kPacketizationTimeMs, timing.packetization_finish_delta_ms);
1697 EXPECT_EQ(kEncodeStartDeltaMs, timing.encode_start_delta_ms);
1698 EXPECT_EQ(kEncodeFinishDeltaMs, timing.encode_finish_delta_ms);
1699}
1700
minyue3a407ee2017-04-03 01:10:33 -07001701TEST_P(RtpSenderVideoTest, DeltaFrameHasCVOWhenChanged) {
danilchapc1600c52016-10-26 03:33:11 -07001702 uint8_t kFrame[kMaxPacketLength];
1703 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
1704 kRtpExtensionVideoRotation, kVideoRotationExtensionId));
1705
1706 RTPVideoHeader hdr = {0};
1707 hdr.rotation = kVideoRotation_90;
spranga8ae6f22017-09-04 07:23:56 -07001708 EXPECT_TRUE(rtp_sender_video_->SendVideo(
1709 kRtpVideoGeneric, kVideoFrameKey, kPayload, kTimestamp, 0, kFrame,
1710 sizeof(kFrame), nullptr, &hdr, kDefaultExpectedRetransmissionTimeMs));
danilchapc1600c52016-10-26 03:33:11 -07001711
1712 hdr.rotation = kVideoRotation_0;
spranga8ae6f22017-09-04 07:23:56 -07001713 EXPECT_TRUE(rtp_sender_video_->SendVideo(
1714 kRtpVideoGeneric, kVideoFrameDelta, kPayload, kTimestamp + 1, 0, kFrame,
1715 sizeof(kFrame), nullptr, &hdr, kDefaultExpectedRetransmissionTimeMs));
danilchapc1600c52016-10-26 03:33:11 -07001716
1717 VideoRotation rotation;
1718 EXPECT_TRUE(
1719 transport_.last_sent_packet().GetExtension<VideoOrientation>(&rotation));
1720 EXPECT_EQ(kVideoRotation_0, rotation);
1721}
1722
minyue3a407ee2017-04-03 01:10:33 -07001723TEST_P(RtpSenderVideoTest, DeltaFrameHasCVOWhenNonZero) {
danilchapc1600c52016-10-26 03:33:11 -07001724 uint8_t kFrame[kMaxPacketLength];
1725 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
1726 kRtpExtensionVideoRotation, kVideoRotationExtensionId));
1727
1728 RTPVideoHeader hdr = {0};
1729 hdr.rotation = kVideoRotation_90;
spranga8ae6f22017-09-04 07:23:56 -07001730 EXPECT_TRUE(rtp_sender_video_->SendVideo(
1731 kRtpVideoGeneric, kVideoFrameKey, kPayload, kTimestamp, 0, kFrame,
1732 sizeof(kFrame), nullptr, &hdr, kDefaultExpectedRetransmissionTimeMs));
danilchapc1600c52016-10-26 03:33:11 -07001733
spranga8ae6f22017-09-04 07:23:56 -07001734 EXPECT_TRUE(rtp_sender_video_->SendVideo(
1735 kRtpVideoGeneric, kVideoFrameDelta, kPayload, kTimestamp + 1, 0, kFrame,
1736 sizeof(kFrame), nullptr, &hdr, kDefaultExpectedRetransmissionTimeMs));
danilchapc1600c52016-10-26 03:33:11 -07001737
1738 VideoRotation rotation;
1739 EXPECT_TRUE(
1740 transport_.last_sent_packet().GetExtension<VideoOrientation>(&rotation));
1741 EXPECT_EQ(kVideoRotation_90, rotation);
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001742}
magjed71eb61c2016-09-08 03:24:58 -07001743
1744// Make sure rotation is parsed correctly when the Camera (C) and Flip (F) bits
1745// are set in the CVO byte.
minyue3a407ee2017-04-03 01:10:33 -07001746TEST_P(RtpSenderVideoTest, SendVideoWithCameraAndFlipCVO) {
magjed71eb61c2016-09-08 03:24:58 -07001747 // Test extracting rotation when Camera (C) and Flip (F) bits are zero.
1748 EXPECT_EQ(kVideoRotation_0, ConvertCVOByteToVideoRotation(0));
1749 EXPECT_EQ(kVideoRotation_90, ConvertCVOByteToVideoRotation(1));
1750 EXPECT_EQ(kVideoRotation_180, ConvertCVOByteToVideoRotation(2));
1751 EXPECT_EQ(kVideoRotation_270, ConvertCVOByteToVideoRotation(3));
1752 // Test extracting rotation when Camera (C) and Flip (F) bits are set.
1753 const int flip_bit = 1 << 2;
1754 const int camera_bit = 1 << 3;
1755 EXPECT_EQ(kVideoRotation_0,
1756 ConvertCVOByteToVideoRotation(flip_bit | camera_bit | 0));
1757 EXPECT_EQ(kVideoRotation_90,
1758 ConvertCVOByteToVideoRotation(flip_bit | camera_bit | 1));
1759 EXPECT_EQ(kVideoRotation_180,
1760 ConvertCVOByteToVideoRotation(flip_bit | camera_bit | 2));
1761 EXPECT_EQ(kVideoRotation_270,
1762 ConvertCVOByteToVideoRotation(flip_bit | camera_bit | 3));
1763}
1764
spranga8ae6f22017-09-04 07:23:56 -07001765TEST_P(RtpSenderVideoTest, RetransmissionTypesGeneric) {
1766 RTPVideoHeader header;
1767 header.codec = kRtpVideoGeneric;
1768
1769 EXPECT_EQ(kDontRetransmit,
1770 rtp_sender_video_->GetStorageType(
1771 header, kRetransmitOff, kDefaultExpectedRetransmissionTimeMs));
1772 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1773 header, kRetransmitBaseLayer,
1774 kDefaultExpectedRetransmissionTimeMs));
1775 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1776 header, kRetransmitHigherLayers,
1777 kDefaultExpectedRetransmissionTimeMs));
1778 EXPECT_EQ(kAllowRetransmission,
1779 rtp_sender_video_->GetStorageType(
1780 header, kConditionallyRetransmitHigherLayers,
1781 kDefaultExpectedRetransmissionTimeMs));
1782 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1783 header, kRetransmitAllPackets,
1784 kDefaultExpectedRetransmissionTimeMs));
1785}
1786
1787TEST_P(RtpSenderVideoTest, RetransmissionTypesH264) {
1788 RTPVideoHeader header;
1789 header.codec = kRtpVideoH264;
1790 header.codecHeader.H264.packetization_mode =
1791 H264PacketizationMode::NonInterleaved;
1792
1793 EXPECT_EQ(kDontRetransmit,
1794 rtp_sender_video_->GetStorageType(
1795 header, kRetransmitOff, kDefaultExpectedRetransmissionTimeMs));
1796 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1797 header, kRetransmitBaseLayer,
1798 kDefaultExpectedRetransmissionTimeMs));
1799 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1800 header, kRetransmitHigherLayers,
1801 kDefaultExpectedRetransmissionTimeMs));
1802 EXPECT_EQ(kAllowRetransmission,
1803 rtp_sender_video_->GetStorageType(
1804 header, kConditionallyRetransmitHigherLayers,
1805 kDefaultExpectedRetransmissionTimeMs));
1806 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1807 header, kRetransmitAllPackets,
1808 kDefaultExpectedRetransmissionTimeMs));
1809}
1810
1811TEST_P(RtpSenderVideoTest, RetransmissionTypesVP8BaseLayer) {
1812 RTPVideoHeader header;
1813 header.codec = kRtpVideoVp8;
1814 header.codecHeader.VP8.temporalIdx = 0;
1815
1816 EXPECT_EQ(kDontRetransmit,
1817 rtp_sender_video_->GetStorageType(
1818 header, kRetransmitOff, kDefaultExpectedRetransmissionTimeMs));
1819 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1820 header, kRetransmitBaseLayer,
1821 kDefaultExpectedRetransmissionTimeMs));
1822 EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType(
1823 header, kRetransmitHigherLayers,
1824 kDefaultExpectedRetransmissionTimeMs));
1825 EXPECT_EQ(kAllowRetransmission,
1826 rtp_sender_video_->GetStorageType(
1827 header, kRetransmitHigherLayers | kRetransmitBaseLayer,
1828 kDefaultExpectedRetransmissionTimeMs));
1829 EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType(
1830 header, kConditionallyRetransmitHigherLayers,
1831 kDefaultExpectedRetransmissionTimeMs));
1832 EXPECT_EQ(
1833 kAllowRetransmission,
1834 rtp_sender_video_->GetStorageType(
1835 header, kRetransmitBaseLayer | kConditionallyRetransmitHigherLayers,
1836 kDefaultExpectedRetransmissionTimeMs));
1837 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1838 header, kRetransmitAllPackets,
1839 kDefaultExpectedRetransmissionTimeMs));
1840}
1841
1842TEST_P(RtpSenderVideoTest, RetransmissionTypesVP8HigherLayers) {
1843 RTPVideoHeader header;
1844 header.codec = kRtpVideoVp8;
1845
1846 for (int tid = 1; tid <= kMaxTemporalStreams; ++tid) {
1847 header.codecHeader.VP8.temporalIdx = tid;
1848
1849 EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType(
1850 header, kRetransmitOff,
1851 kDefaultExpectedRetransmissionTimeMs));
1852 EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType(
1853 header, kRetransmitBaseLayer,
1854 kDefaultExpectedRetransmissionTimeMs));
1855 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1856 header, kRetransmitHigherLayers,
1857 kDefaultExpectedRetransmissionTimeMs));
1858 EXPECT_EQ(kAllowRetransmission,
1859 rtp_sender_video_->GetStorageType(
1860 header, kRetransmitHigherLayers | kRetransmitBaseLayer,
1861 kDefaultExpectedRetransmissionTimeMs));
1862 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1863 header, kRetransmitAllPackets,
1864 kDefaultExpectedRetransmissionTimeMs));
1865 }
1866}
1867
1868TEST_P(RtpSenderVideoTest, RetransmissionTypesVP9) {
1869 RTPVideoHeader header;
1870 header.codec = kRtpVideoVp9;
1871
1872 for (int tid = 1; tid <= kMaxTemporalStreams; ++tid) {
1873 header.codecHeader.VP9.temporal_idx = tid;
1874
1875 EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType(
1876 header, kRetransmitOff,
1877 kDefaultExpectedRetransmissionTimeMs));
1878 EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType(
1879 header, kRetransmitBaseLayer,
1880 kDefaultExpectedRetransmissionTimeMs));
1881 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1882 header, kRetransmitHigherLayers,
1883 kDefaultExpectedRetransmissionTimeMs));
1884 EXPECT_EQ(kAllowRetransmission,
1885 rtp_sender_video_->GetStorageType(
1886 header, kRetransmitHigherLayers | kRetransmitBaseLayer,
1887 kDefaultExpectedRetransmissionTimeMs));
1888 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1889 header, kRetransmitAllPackets,
1890 kDefaultExpectedRetransmissionTimeMs));
1891 }
1892}
1893
1894TEST_P(RtpSenderVideoTest, ConditionalRetransmit) {
1895 const int64_t kFrameIntervalMs = 33;
1896 const int64_t kRttMs = (kFrameIntervalMs * 3) / 2;
1897 const uint8_t kSettings =
1898 kRetransmitBaseLayer | kConditionallyRetransmitHigherLayers;
1899
1900 // Insert VP8 frames for all temporal layers, but stop before the final index.
1901 RTPVideoHeader header;
1902 header.codec = kRtpVideoVp8;
1903
1904 // Fill averaging window to prevent rounding errors.
1905 constexpr int kNumRepetitions =
1906 (RTPSenderVideo::kTLRateWindowSizeMs + (kFrameIntervalMs / 2)) /
1907 kFrameIntervalMs;
1908 constexpr int kPattern[] = {0, 2, 1, 2};
1909 for (size_t i = 0; i < arraysize(kPattern) * kNumRepetitions; ++i) {
1910 header.codecHeader.VP8.temporalIdx = kPattern[i % arraysize(kPattern)];
1911 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs);
1912 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
1913 }
1914
1915 // Since we're at the start of the pattern, the next expected frame in TL0 is
1916 // right now. We will wait at most one expected retransmission time before
1917 // acknowledging that it did not arrive, which means this frame and the next
1918 // will not be retransmitted.
1919 header.codecHeader.VP8.temporalIdx = 1;
1920 EXPECT_EQ(StorageType::kDontRetransmit,
1921 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
1922 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
1923 EXPECT_EQ(StorageType::kDontRetransmit,
1924 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
1925 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
1926
1927 // The TL0 frame did not arrive. So allow retransmission.
1928 EXPECT_EQ(StorageType::kAllowRetransmission,
1929 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
1930 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
1931
1932 // Insert a frame for TL2. We just had frame in TL1, so the next one there is
1933 // in three frames away. TL0 is still too far in the past. So, allow
1934 // retransmission.
1935 header.codecHeader.VP8.temporalIdx = 2;
1936 EXPECT_EQ(StorageType::kAllowRetransmission,
1937 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
1938 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
1939
1940 // Another TL2, next in TL1 is two frames away. Allow again.
1941 EXPECT_EQ(StorageType::kAllowRetransmission,
1942 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
1943 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
1944
1945 // Yet another TL2, next in TL1 is now only one frame away, so don't store
1946 // for retransmission.
1947 EXPECT_EQ(StorageType::kDontRetransmit,
1948 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
1949}
1950
1951TEST_P(RtpSenderVideoTest, ConditionalRetransmitLimit) {
1952 const int64_t kFrameIntervalMs = 200;
1953 const int64_t kRttMs = (kFrameIntervalMs * 3) / 2;
1954 const int32_t kSettings =
1955 kRetransmitBaseLayer | kConditionallyRetransmitHigherLayers;
1956
1957 // Insert VP8 frames for all temporal layers, but stop before the final index.
1958 RTPVideoHeader header;
1959 header.codec = kRtpVideoVp8;
1960
1961 // Fill averaging window to prevent rounding errors.
1962 constexpr int kNumRepetitions =
1963 (RTPSenderVideo::kTLRateWindowSizeMs + (kFrameIntervalMs / 2)) /
1964 kFrameIntervalMs;
1965 constexpr int kPattern[] = {0, 2, 2, 2};
1966 for (size_t i = 0; i < arraysize(kPattern) * kNumRepetitions; ++i) {
1967 header.codecHeader.VP8.temporalIdx = kPattern[i % arraysize(kPattern)];
1968
1969 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs);
1970 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
1971 }
1972
1973 // Since we're at the start of the pattern, the next expected frame will be
1974 // right now in TL0. Put it in TL1 instead. Regular rules would dictate that
1975 // we don't store for retransmission because we expect a frame in a lower
1976 // layer, but that last frame in TL1 was a long time ago in absolute terms,
1977 // so allow retransmission anyway.
1978 header.codecHeader.VP8.temporalIdx = 1;
1979 EXPECT_EQ(StorageType::kAllowRetransmission,
1980 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
1981}
1982
minyue3a407ee2017-04-03 01:10:33 -07001983TEST_P(RtpSenderTest, OnOverheadChanged) {
michaelt4da30442016-11-17 01:38:43 -08001984 MockOverheadObserver mock_overhead_observer;
Erik Språng7b52f102018-02-07 14:37:37 +01001985 rtp_sender_.reset(new RTPSender(
1986 false, &fake_clock_, &transport_, nullptr, nullptr, nullptr, nullptr,
1987 nullptr, nullptr, nullptr, nullptr, nullptr,
1988 &retransmission_rate_limiter_, &mock_overhead_observer, false));
nisse7d59f6b2017-02-21 03:40:24 -08001989 rtp_sender_->SetSSRC(kSsrc);
michaelt4da30442016-11-17 01:38:43 -08001990
michaelt4da30442016-11-17 01:38:43 -08001991 // RTP overhead is 12B.
nisse284542b2017-01-10 08:58:32 -08001992 EXPECT_CALL(mock_overhead_observer, OnOverheadChanged(12)).Times(1);
michaelt4da30442016-11-17 01:38:43 -08001993 SendGenericPayload();
1994
1995 rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionTransmissionTimeOffset,
1996 kTransmissionTimeOffsetExtensionId);
1997
1998 // TransmissionTimeOffset extension has a size of 8B.
nisse284542b2017-01-10 08:58:32 -08001999 // 12B + 8B = 20B
2000 EXPECT_CALL(mock_overhead_observer, OnOverheadChanged(20)).Times(1);
michaelt4da30442016-11-17 01:38:43 -08002001 SendGenericPayload();
2002}
2003
minyue3a407ee2017-04-03 01:10:33 -07002004TEST_P(RtpSenderTest, DoesNotUpdateOverheadOnEqualSize) {
michaelt4da30442016-11-17 01:38:43 -08002005 MockOverheadObserver mock_overhead_observer;
Erik Språng7b52f102018-02-07 14:37:37 +01002006 rtp_sender_.reset(new RTPSender(
2007 false, &fake_clock_, &transport_, nullptr, nullptr, nullptr, nullptr,
2008 nullptr, nullptr, nullptr, nullptr, nullptr,
2009 &retransmission_rate_limiter_, &mock_overhead_observer, false));
nisse7d59f6b2017-02-21 03:40:24 -08002010 rtp_sender_->SetSSRC(kSsrc);
michaelt4da30442016-11-17 01:38:43 -08002011
2012 EXPECT_CALL(mock_overhead_observer, OnOverheadChanged(_)).Times(1);
michaelt4da30442016-11-17 01:38:43 -08002013 SendGenericPayload();
2014 SendGenericPayload();
2015}
2016
sprang168794c2017-07-06 04:38:06 -07002017TEST_P(RtpSenderTest, SendsKeepAlive) {
2018 MockTransport transport;
Erik Språng7b52f102018-02-07 14:37:37 +01002019 rtp_sender_.reset(
2020 new RTPSender(false, &fake_clock_, &transport, nullptr, nullptr, nullptr,
2021 nullptr, nullptr, nullptr, nullptr, &mock_rtc_event_log_,
2022 nullptr, &retransmission_rate_limiter_, nullptr, false));
sprang168794c2017-07-06 04:38:06 -07002023 rtp_sender_->SetSequenceNumber(kSeqNum);
2024 rtp_sender_->SetTimestampOffset(0);
2025 rtp_sender_->SetSSRC(kSsrc);
2026
2027 const uint8_t kKeepalivePayloadType = 20;
2028 RTC_CHECK_NE(kKeepalivePayloadType, kPayload);
2029
2030 EXPECT_CALL(transport, SendRtp(_, _, _))
2031 .WillOnce(
2032 Invoke([&kKeepalivePayloadType](const uint8_t* packet, size_t len,
2033 const PacketOptions& options) {
2034 webrtc::RTPHeader rtp_header;
2035 RtpUtility::RtpHeaderParser parser(packet, len);
2036 EXPECT_TRUE(parser.Parse(&rtp_header, nullptr));
2037 EXPECT_FALSE(rtp_header.markerBit);
2038 EXPECT_EQ(0U, rtp_header.paddingLength);
2039 EXPECT_EQ(kKeepalivePayloadType, rtp_header.payloadType);
2040 EXPECT_EQ(kSeqNum, rtp_header.sequenceNumber);
2041 EXPECT_EQ(kSsrc, rtp_header.ssrc);
2042 EXPECT_EQ(0u, len - rtp_header.headerLength);
2043 return true;
2044 }));
2045
2046 rtp_sender_->SendKeepAlive(kKeepalivePayloadType);
2047 EXPECT_EQ(kSeqNum + 1, rtp_sender_->SequenceNumber());
2048}
2049
minyue3a407ee2017-04-03 01:10:33 -07002050INSTANTIATE_TEST_CASE_P(WithAndWithoutOverhead,
2051 RtpSenderTest,
2052 ::testing::Bool());
2053INSTANTIATE_TEST_CASE_P(WithAndWithoutOverhead,
2054 RtpSenderTestWithoutPacer,
2055 ::testing::Bool());
2056INSTANTIATE_TEST_CASE_P(WithAndWithoutOverhead,
2057 RtpSenderVideoTest,
2058 ::testing::Bool());
2059INSTANTIATE_TEST_CASE_P(WithAndWithoutOverhead,
2060 RtpSenderAudioTest,
2061 ::testing::Bool());
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00002062} // namespace webrtc