blob: 1b7e99298bd50ebc76b7fa2856bf8d192386106b [file] [log] [blame]
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +00001/*
phoglund@webrtc.org78088c22012-02-07 14:56:45 +00002 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +00003 *
4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
9 */
10
kwiberg84be5112016-04-27 01:19:58 -070011#include <memory>
danilchapb8b6fbb2015-12-10 05:05:27 -080012#include <vector>
13
Karl Wiberg918f50c2018-07-05 11:40:33 +020014#include "absl/memory/memory.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020015#include "api/video/video_timing.h"
Elad Alon4a87e1c2017-10-03 16:11:34 +020016#include "logging/rtc_event_log/events/rtc_event.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020017#include "logging/rtc_event_log/mock/mock_rtc_event_log.h"
18#include "modules/rtp_rtcp/include/rtp_cvo.h"
19#include "modules/rtp_rtcp/include/rtp_header_extension_map.h"
20#include "modules/rtp_rtcp/include/rtp_header_parser.h"
21#include "modules/rtp_rtcp/include/rtp_rtcp_defines.h"
22#include "modules/rtp_rtcp/source/rtcp_packet/transport_feedback.h"
23#include "modules/rtp_rtcp/source/rtp_format_video_generic.h"
philipelb3e42a42018-09-13 10:57:14 +020024#include "modules/rtp_rtcp/source/rtp_generic_frame_descriptor.h"
25#include "modules/rtp_rtcp/source/rtp_generic_frame_descriptor_extension.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020026#include "modules/rtp_rtcp/source/rtp_header_extensions.h"
27#include "modules/rtp_rtcp/source/rtp_packet_received.h"
28#include "modules/rtp_rtcp/source/rtp_packet_to_send.h"
29#include "modules/rtp_rtcp/source/rtp_sender.h"
30#include "modules/rtp_rtcp/source/rtp_sender_video.h"
31#include "modules/rtp_rtcp/source/rtp_utility.h"
32#include "rtc_base/arraysize.h"
33#include "rtc_base/buffer.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020034#include "rtc_base/rate_limiter.h"
35#include "test/field_trial.h"
36#include "test/gmock.h"
37#include "test/gtest.h"
38#include "test/mock_transport.h"
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +000039
40namespace webrtc {
41
andrew@webrtc.org8a442592011-12-16 21:24:30 +000042namespace {
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +000043const int kTransmissionTimeOffsetExtensionId = 1;
44const int kAbsoluteSendTimeExtensionId = 14;
sprang@webrtc.org30933902015-03-17 14:33:12 +000045const int kTransportSequenceNumberExtensionId = 13;
ilnik04f4d122017-06-19 07:18:55 -070046const int kVideoTimingExtensionId = 12;
Steve Anton296a0ce2018-03-22 15:17:27 -070047const int kMidExtensionId = 11;
andrew@webrtc.org8a442592011-12-16 21:24:30 +000048const int kPayload = 100;
Shao Changbine62202f2015-04-21 20:24:50 +080049const int kRtxPayload = 98;
andrew@webrtc.org8a442592011-12-16 21:24:30 +000050const uint32_t kTimestamp = 10;
51const uint16_t kSeqNum = 33;
brandtr9dfff292016-11-14 05:14:50 -080052const uint32_t kSsrc = 725242;
andrew@webrtc.org8a442592011-12-16 21:24:30 +000053const int kMaxPacketLength = 1500;
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +000054const uint8_t kAudioLevel = 0x5a;
sprang@webrtc.org30933902015-03-17 14:33:12 +000055const uint16_t kTransportSequenceNumber = 0xaabbu;
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +000056const uint8_t kAudioLevelExtensionId = 9;
57const int kAudioPayload = 103;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +000058const uint64_t kStartTime = 123456789;
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +000059const size_t kMaxPaddingSize = 224u;
guoweis@webrtc.org45362892015-03-04 22:55:15 +000060const int kVideoRotationExtensionId = 5;
Stefan Holmera246cfb2016-08-23 17:51:42 +020061const size_t kGenericHeaderLength = 1;
62const uint8_t kPayloadData[] = {47, 11, 32, 93, 89};
spranga8ae6f22017-09-04 07:23:56 -070063const int64_t kDefaultExpectedRetransmissionTimeMs = 125;
philipelb3e42a42018-09-13 10:57:14 +020064const int kGenericDescriptorId = 10;
andrew@webrtc.org8a442592011-12-16 21:24:30 +000065
Danil Chapovalov5e57b172016-09-02 19:15:59 +020066using ::testing::_;
philipelb3e42a42018-09-13 10:57:14 +020067using ::testing::ElementsAre;
Danil Chapovalov5e57b172016-09-02 19:15:59 +020068using ::testing::ElementsAreArray;
sprang168794c2017-07-06 04:38:06 -070069using ::testing::Invoke;
Danil Chapovalov84ffb352018-09-25 18:59:09 +020070using ::testing::SizeIs;
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +000071
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +000072uint64_t ConvertMsToAbsSendTime(int64_t time_ms) {
Stefan Holmer0a87ffc2015-10-21 13:41:48 +020073 return (((time_ms << 18) + 500) / 1000) & 0x00ffffff;
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +000074}
75
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +000076class LoopbackTransportTest : public webrtc::Transport {
77 public:
Petter Strandmark26bc6692018-05-29 08:43:35 +020078 LoopbackTransportTest() : total_bytes_sent_(0) {
danilchap12ba1862016-10-26 02:41:55 -070079 receivers_extensions_.Register(kRtpExtensionTransmissionTimeOffset,
80 kTransmissionTimeOffsetExtensionId);
81 receivers_extensions_.Register(kRtpExtensionAbsoluteSendTime,
82 kAbsoluteSendTimeExtensionId);
83 receivers_extensions_.Register(kRtpExtensionTransportSequenceNumber,
84 kTransportSequenceNumberExtensionId);
85 receivers_extensions_.Register(kRtpExtensionVideoRotation,
86 kVideoRotationExtensionId);
87 receivers_extensions_.Register(kRtpExtensionAudioLevel,
88 kAudioLevelExtensionId);
ilnik04f4d122017-06-19 07:18:55 -070089 receivers_extensions_.Register(kRtpExtensionVideoTiming,
90 kVideoTimingExtensionId);
Steve Anton296a0ce2018-03-22 15:17:27 -070091 receivers_extensions_.Register(kRtpExtensionMid, kMidExtensionId);
philipelb3e42a42018-09-13 10:57:14 +020092 receivers_extensions_.Register(kRtpExtensionGenericFrameDescriptor,
93 kGenericDescriptorId);
guoweis@webrtc.org45362892015-03-04 22:55:15 +000094 }
danilchap12ba1862016-10-26 02:41:55 -070095
stefan1d8a5062015-10-02 03:39:33 -070096 bool SendRtp(const uint8_t* data,
97 size_t len,
98 const PacketOptions& options) override {
Petter Strandmark26bc6692018-05-29 08:43:35 +020099 last_options_ = options;
pkasting@chromium.org4591fbd2014-11-20 22:28:14 +0000100 total_bytes_sent_ += len;
danilchap12ba1862016-10-26 02:41:55 -0700101 sent_packets_.push_back(RtpPacketReceived(&receivers_extensions_));
102 EXPECT_TRUE(sent_packets_.back().Parse(data, len));
pbos2d566682015-09-28 09:59:31 -0700103 return true;
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000104 }
danilchap162abd32015-12-10 02:39:40 -0800105 bool SendRtcp(const uint8_t* data, size_t len) override { return false; }
danilchap12ba1862016-10-26 02:41:55 -0700106 const RtpPacketReceived& last_sent_packet() { return sent_packets_.back(); }
107 int packets_sent() { return sent_packets_.size(); }
108
pbos@webrtc.org72491b92014-07-10 16:24:54 +0000109 size_t total_bytes_sent_;
Petter Strandmark26bc6692018-05-29 08:43:35 +0200110 PacketOptions last_options_;
danilchap12ba1862016-10-26 02:41:55 -0700111 std::vector<RtpPacketReceived> sent_packets_;
112
113 private:
114 RtpHeaderExtensionMap receivers_extensions_;
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000115};
116
Elad Alon4a87e1c2017-10-03 16:11:34 +0200117MATCHER_P(SameRtcEventTypeAs, value, "") {
118 return value == arg->GetType();
119}
120
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000121} // namespace
122
sprangebbf8a82015-09-21 15:11:14 -0700123class MockRtpPacketSender : public RtpPacketSender {
124 public:
125 MockRtpPacketSender() {}
126 virtual ~MockRtpPacketSender() {}
127
Peter Boströme23e7372015-10-08 11:44:14 +0200128 MOCK_METHOD6(InsertPacket,
129 void(Priority priority,
sprangebbf8a82015-09-21 15:11:14 -0700130 uint32_t ssrc,
131 uint16_t sequence_number,
132 int64_t capture_time_ms,
133 size_t bytes,
134 bool retransmission));
135};
136
Stefan Holmerf5dca482016-01-27 12:58:51 +0100137class MockTransportSequenceNumberAllocator
138 : public TransportSequenceNumberAllocator {
139 public:
140 MOCK_METHOD0(AllocateSequenceNumber, uint16_t());
141};
142
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200143class MockSendSideDelayObserver : public SendSideDelayObserver {
144 public:
145 MOCK_METHOD3(SendSideDelayUpdated, void(int, int, uint32_t));
146};
147
asapersson35151f32016-05-02 23:44:01 -0700148class MockSendPacketObserver : public SendPacketObserver {
149 public:
150 MOCK_METHOD3(OnSendPacket, void(uint16_t, int64_t, uint32_t));
151};
152
Stefan Holmera246cfb2016-08-23 17:51:42 +0200153class MockTransportFeedbackObserver : public TransportFeedbackObserver {
154 public:
elad.alond12a8e12017-03-23 11:04:48 -0700155 MOCK_METHOD4(AddPacket,
156 void(uint32_t, uint16_t, size_t, const PacedPacketInfo&));
Stefan Holmera246cfb2016-08-23 17:51:42 +0200157 MOCK_METHOD1(OnTransportFeedback, void(const rtcp::TransportFeedback&));
elad.alonf9490002017-03-06 05:32:21 -0800158 MOCK_CONST_METHOD0(GetTransportFeedbackVector, std::vector<PacketFeedback>());
Stefan Holmera246cfb2016-08-23 17:51:42 +0200159};
160
minyue3a407ee2017-04-03 01:10:33 -0700161class MockOverheadObserver : public OverheadObserver {
162 public:
163 MOCK_METHOD1(OnOverheadChanged, void(size_t overhead_bytes_per_packet));
164};
165
166class RtpSenderTest : public ::testing::TestWithParam<bool> {
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000167 protected:
168 RtpSenderTest()
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +0000169 : fake_clock_(kStartTime),
terelius429c3452016-01-21 05:42:04 -0800170 mock_rtc_event_log_(),
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +0000171 mock_paced_sender_(),
sprangcd349d92016-07-13 09:11:28 -0700172 retransmission_rate_limiter_(&fake_clock_, 1000),
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +0000173 rtp_sender_(),
174 payload_(kPayload),
175 transport_(),
minyue3a407ee2017-04-03 01:10:33 -0700176 kMarkerBit(true),
177 field_trials_(GetParam() ? "WebRTC-SendSideBwe-WithOverhead/Enabled/"
178 : "") {}
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +0000179
Erik Språng7b52f102018-02-07 14:37:37 +0100180 void SetUp() override { SetUpRtpSender(true, false); }
Peter Boströme23e7372015-10-08 11:44:14 +0200181
Erik Språng7b52f102018-02-07 14:37:37 +0100182 void SetUpRtpSender(bool pacer, bool populate_network2) {
asapersson35151f32016-05-02 23:44:01 -0700183 rtp_sender_.reset(new RTPSender(
184 false, &fake_clock_, &transport_, pacer ? &mock_paced_sender_ : nullptr,
brandtrdbdb3f12016-11-10 05:04:48 -0800185 nullptr, &seq_num_allocator_, nullptr, nullptr, nullptr, nullptr,
sprangcd349d92016-07-13 09:11:28 -0700186 &mock_rtc_event_log_, &send_packet_observer_,
Erik Språng7b52f102018-02-07 14:37:37 +0100187 &retransmission_rate_limiter_, nullptr, populate_network2));
brandtr9dfff292016-11-14 05:14:50 -0800188 rtp_sender_->SetSequenceNumber(kSeqNum);
danilchap71fead22016-08-18 02:01:49 -0700189 rtp_sender_->SetTimestampOffset(0);
brandtr9dfff292016-11-14 05:14:50 -0800190 rtp_sender_->SetSSRC(kSsrc);
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +0000191 }
192
stefan@webrtc.orga678a3b2013-01-21 07:42:11 +0000193 SimulatedClock fake_clock_;
stefana23fc622016-07-28 07:56:38 -0700194 testing::NiceMock<MockRtcEventLog> mock_rtc_event_log_;
sprangebbf8a82015-09-21 15:11:14 -0700195 MockRtpPacketSender mock_paced_sender_;
stefana23fc622016-07-28 07:56:38 -0700196 testing::StrictMock<MockTransportSequenceNumberAllocator> seq_num_allocator_;
197 testing::StrictMock<MockSendPacketObserver> send_packet_observer_;
Stefan Holmera246cfb2016-08-23 17:51:42 +0200198 testing::StrictMock<MockTransportFeedbackObserver> feedback_observer_;
sprangcd349d92016-07-13 09:11:28 -0700199 RateLimiter retransmission_rate_limiter_;
kwiberg84be5112016-04-27 01:19:58 -0700200 std::unique_ptr<RTPSender> rtp_sender_;
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +0000201 int payload_;
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000202 LoopbackTransportTest transport_;
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000203 const bool kMarkerBit;
minyue3a407ee2017-04-03 01:10:33 -0700204 test::ScopedFieldTrials field_trials_;
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000205
stefan@webrtc.orga5cb98c2013-05-29 12:12:51 +0000206 void VerifyRTPHeaderCommon(const RTPHeader& rtp_header) {
danilchapd9e62f52016-01-14 14:55:19 -0800207 VerifyRTPHeaderCommon(rtp_header, kMarkerBit, 0);
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000208 }
209
210 void VerifyRTPHeaderCommon(const RTPHeader& rtp_header, bool marker_bit) {
danilchapd9e62f52016-01-14 14:55:19 -0800211 VerifyRTPHeaderCommon(rtp_header, marker_bit, 0);
212 }
213
214 void VerifyRTPHeaderCommon(const RTPHeader& rtp_header,
215 bool marker_bit,
216 uint8_t number_of_csrcs) {
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000217 EXPECT_EQ(marker_bit, rtp_header.markerBit);
stefan@webrtc.orga5cb98c2013-05-29 12:12:51 +0000218 EXPECT_EQ(payload_, rtp_header.payloadType);
219 EXPECT_EQ(kSeqNum, rtp_header.sequenceNumber);
220 EXPECT_EQ(kTimestamp, rtp_header.timestamp);
221 EXPECT_EQ(rtp_sender_->SSRC(), rtp_header.ssrc);
danilchapd9e62f52016-01-14 14:55:19 -0800222 EXPECT_EQ(number_of_csrcs, rtp_header.numCSRCs);
pkasting@chromium.org4591fbd2014-11-20 22:28:14 +0000223 EXPECT_EQ(0U, rtp_header.paddingLength);
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000224 }
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000225
danilchapb6f1fb52016-10-19 06:11:39 -0700226 std::unique_ptr<RtpPacketToSend> BuildRtpPacket(int payload_type,
227 bool marker_bit,
228 uint32_t timestamp,
229 int64_t capture_time_ms) {
230 auto packet = rtp_sender_->AllocatePacket();
231 packet->SetPayloadType(payload_type);
232 packet->SetMarker(marker_bit);
233 packet->SetTimestamp(timestamp);
234 packet->set_capture_time_ms(capture_time_ms);
235 EXPECT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
236 return packet;
237 }
238
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000239 void SendPacket(int64_t capture_time_ms, int payload_length) {
240 uint32_t timestamp = capture_time_ms * 90;
danilchapb6f1fb52016-10-19 06:11:39 -0700241 auto packet =
242 BuildRtpPacket(kPayload, kMarkerBit, timestamp, capture_time_ms);
243 packet->AllocatePayload(payload_length);
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000244
245 // Packet should be stored in a send bucket.
danilchapb6f1fb52016-10-19 06:11:39 -0700246 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
247 kAllowRetransmission,
248 RtpPacketSender::kNormalPriority));
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000249 }
asapersson35151f32016-05-02 23:44:01 -0700250
251 void SendGenericPayload() {
asapersson35151f32016-05-02 23:44:01 -0700252 const uint32_t kTimestamp = 1234;
253 const uint8_t kPayloadType = 127;
254 const int64_t kCaptureTimeMs = fake_clock_.TimeInMilliseconds();
255 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
256 EXPECT_EQ(0, rtp_sender_->RegisterPayload(payload_name, kPayloadType, 90000,
257 0, 1500));
258
Sami Kalliomäki426a80c2018-08-08 11:37:59 +0200259 RTPVideoHeader video_header;
Sergey Ulanov525df3f2016-08-02 17:46:41 -0700260 EXPECT_TRUE(rtp_sender_->SendOutgoingData(
Stefan Holmera246cfb2016-08-23 17:51:42 +0200261 kVideoFrameKey, kPayloadType, kTimestamp, kCaptureTimeMs, kPayloadData,
Sami Kalliomäki426a80c2018-08-08 11:37:59 +0200262 sizeof(kPayloadData), nullptr, &video_header, nullptr,
spranga8ae6f22017-09-04 07:23:56 -0700263 kDefaultExpectedRetransmissionTimeMs));
asapersson35151f32016-05-02 23:44:01 -0700264 }
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000265};
266
Peter Boströme23e7372015-10-08 11:44:14 +0200267// TODO(pbos): Move tests over from WithoutPacer to RtpSenderTest as this is our
268// default code path.
269class RtpSenderTestWithoutPacer : public RtpSenderTest {
270 public:
Erik Språng7b52f102018-02-07 14:37:37 +0100271 void SetUp() override { SetUpRtpSender(false, false); }
Peter Boströme23e7372015-10-08 11:44:14 +0200272};
273
spranga8ae6f22017-09-04 07:23:56 -0700274class TestRtpSenderVideo : public RTPSenderVideo {
275 public:
276 TestRtpSenderVideo(Clock* clock,
277 RTPSender* rtp_sender,
278 FlexfecSender* flexfec_sender)
279 : RTPSenderVideo(clock, rtp_sender, flexfec_sender) {}
280 ~TestRtpSenderVideo() override {}
281
282 StorageType GetStorageType(const RTPVideoHeader& header,
283 int32_t retransmission_settings,
284 int64_t expected_retransmission_time_ms) {
285 return RTPSenderVideo::GetStorageType(GetTemporalId(header),
286 retransmission_settings,
287 expected_retransmission_time_ms);
288 }
289};
290
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000291class RtpSenderVideoTest : public RtpSenderTest {
292 protected:
danilchap162abd32015-12-10 02:39:40 -0800293 void SetUp() override {
Peter Boströme23e7372015-10-08 11:44:14 +0200294 // TODO(pbos): Set up to use pacer.
Erik Språng7b52f102018-02-07 14:37:37 +0100295 SetUpRtpSender(false, false);
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000296 rtp_sender_video_.reset(
spranga8ae6f22017-09-04 07:23:56 -0700297 new TestRtpSenderVideo(&fake_clock_, rtp_sender_.get(), nullptr));
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000298 }
spranga8ae6f22017-09-04 07:23:56 -0700299 std::unique_ptr<TestRtpSenderVideo> rtp_sender_video_;
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000300};
301
minyue3a407ee2017-04-03 01:10:33 -0700302TEST_P(RtpSenderTestWithoutPacer, AllocatePacketSetCsrc) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200303 // Configure rtp_sender with csrc.
304 std::vector<uint32_t> csrcs;
305 csrcs.push_back(0x23456789);
306 rtp_sender_->SetCsrcs(csrcs);
307
308 auto packet = rtp_sender_->AllocatePacket();
309
310 ASSERT_TRUE(packet);
311 EXPECT_EQ(rtp_sender_->SSRC(), packet->Ssrc());
312 EXPECT_EQ(csrcs, packet->Csrcs());
313}
314
minyue3a407ee2017-04-03 01:10:33 -0700315TEST_P(RtpSenderTestWithoutPacer, AllocatePacketReserveExtensions) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200316 // Configure rtp_sender with extensions.
317 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
318 kRtpExtensionTransmissionTimeOffset,
319 kTransmissionTimeOffsetExtensionId));
320 ASSERT_EQ(
321 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
322 kAbsoluteSendTimeExtensionId));
323 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAudioLevel,
324 kAudioLevelExtensionId));
325 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
326 kRtpExtensionTransportSequenceNumber,
327 kTransportSequenceNumberExtensionId));
328 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
329 kRtpExtensionVideoRotation, kVideoRotationExtensionId));
330
331 auto packet = rtp_sender_->AllocatePacket();
332
333 ASSERT_TRUE(packet);
334 // Preallocate BWE extensions RtpSender set itself.
335 EXPECT_TRUE(packet->HasExtension<TransmissionOffset>());
336 EXPECT_TRUE(packet->HasExtension<AbsoluteSendTime>());
337 EXPECT_TRUE(packet->HasExtension<TransportSequenceNumber>());
338 // Do not allocate media specific extensions.
339 EXPECT_FALSE(packet->HasExtension<AudioLevel>());
340 EXPECT_FALSE(packet->HasExtension<VideoOrientation>());
341}
342
minyue3a407ee2017-04-03 01:10:33 -0700343TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberAdvanceSequenceNumber) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200344 auto packet = rtp_sender_->AllocatePacket();
345 ASSERT_TRUE(packet);
346 const uint16_t sequence_number = rtp_sender_->SequenceNumber();
347
348 EXPECT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
349
350 EXPECT_EQ(sequence_number, packet->SequenceNumber());
351 EXPECT_EQ(sequence_number + 1, rtp_sender_->SequenceNumber());
352}
353
minyue3a407ee2017-04-03 01:10:33 -0700354TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberFailsOnNotSending) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200355 auto packet = rtp_sender_->AllocatePacket();
356 ASSERT_TRUE(packet);
357
358 rtp_sender_->SetSendingMediaStatus(false);
359 EXPECT_FALSE(rtp_sender_->AssignSequenceNumber(packet.get()));
360}
361
Danil Chapovalovb3179c72018-03-22 10:13:07 +0100362TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberMayAllowPaddingOnVideo) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200363 constexpr size_t kPaddingSize = 100;
364 auto packet = rtp_sender_->AllocatePacket();
365 ASSERT_TRUE(packet);
366
philipel8aadd502017-02-23 02:56:13 -0800367 ASSERT_FALSE(rtp_sender_->TimeToSendPadding(kPaddingSize, PacedPacketInfo()));
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200368 packet->SetMarker(false);
369 ASSERT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
Danil Chapovalovb3179c72018-03-22 10:13:07 +0100370 // Packet without marker bit doesn't allow padding on video stream.
philipel8aadd502017-02-23 02:56:13 -0800371 EXPECT_FALSE(rtp_sender_->TimeToSendPadding(kPaddingSize, PacedPacketInfo()));
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200372
373 packet->SetMarker(true);
374 ASSERT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
375 // Packet with marker bit allows send padding.
philipel8aadd502017-02-23 02:56:13 -0800376 EXPECT_TRUE(rtp_sender_->TimeToSendPadding(kPaddingSize, PacedPacketInfo()));
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200377}
378
Danil Chapovalovb3179c72018-03-22 10:13:07 +0100379TEST_P(RtpSenderTest, AssignSequenceNumberAllowsPaddingOnAudio) {
380 MockTransport transport;
381 const bool kEnableAudio = true;
382 rtp_sender_.reset(new RTPSender(
383 kEnableAudio, &fake_clock_, &transport, &mock_paced_sender_, nullptr,
384 nullptr, nullptr, nullptr, nullptr, nullptr, &mock_rtc_event_log_,
385 nullptr, &retransmission_rate_limiter_, nullptr, false));
386 rtp_sender_->SetTimestampOffset(0);
387 rtp_sender_->SetSSRC(kSsrc);
388
389 std::unique_ptr<RtpPacketToSend> audio_packet = rtp_sender_->AllocatePacket();
390 // Padding on audio stream allowed regardless of marker in the last packet.
391 audio_packet->SetMarker(false);
392 audio_packet->SetPayloadType(kPayload);
393 rtp_sender_->AssignSequenceNumber(audio_packet.get());
394
395 const size_t kPaddingSize = 59;
396 EXPECT_CALL(transport, SendRtp(_, kPaddingSize + kRtpHeaderSize, _))
397 .WillOnce(testing::Return(true));
398 EXPECT_EQ(kPaddingSize,
399 rtp_sender_->TimeToSendPadding(kPaddingSize, PacedPacketInfo()));
400
401 // Requested padding size is too small, will send a larger one.
402 const size_t kMinPaddingSize = 50;
403 EXPECT_CALL(transport, SendRtp(_, kMinPaddingSize + kRtpHeaderSize, _))
404 .WillOnce(testing::Return(true));
Yves Gerey665174f2018-06-19 15:03:05 +0200405 EXPECT_EQ(kMinPaddingSize, rtp_sender_->TimeToSendPadding(kMinPaddingSize - 5,
406 PacedPacketInfo()));
Danil Chapovalovb3179c72018-03-22 10:13:07 +0100407}
408
minyue3a407ee2017-04-03 01:10:33 -0700409TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberSetPaddingTimestamps) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200410 constexpr size_t kPaddingSize = 100;
411 auto packet = rtp_sender_->AllocatePacket();
412 ASSERT_TRUE(packet);
413 packet->SetMarker(true);
414 packet->SetTimestamp(kTimestamp);
415
416 ASSERT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
philipel8aadd502017-02-23 02:56:13 -0800417 ASSERT_TRUE(rtp_sender_->TimeToSendPadding(kPaddingSize, PacedPacketInfo()));
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200418
419 ASSERT_EQ(1u, transport_.sent_packets_.size());
danilchap12ba1862016-10-26 02:41:55 -0700420 // Verify padding packet timestamp.
421 EXPECT_EQ(kTimestamp, transport_.last_sent_packet().Timestamp());
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200422}
423
minyue3a407ee2017-04-03 01:10:33 -0700424TEST_P(RtpSenderTestWithoutPacer,
425 TransportFeedbackObserverGetsCorrectByteCount) {
426 constexpr int kRtpOverheadBytesPerPacket = 12 + 8;
427 testing::NiceMock<MockOverheadObserver> mock_overhead_observer;
428 rtp_sender_.reset(new RTPSender(
429 false, &fake_clock_, &transport_, nullptr, nullptr, &seq_num_allocator_,
430 &feedback_observer_, nullptr, nullptr, nullptr, &mock_rtc_event_log_,
Erik Språng7b52f102018-02-07 14:37:37 +0100431 nullptr, &retransmission_rate_limiter_, &mock_overhead_observer, false));
minyue3a407ee2017-04-03 01:10:33 -0700432 rtp_sender_->SetSSRC(kSsrc);
433 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
434 kRtpExtensionTransportSequenceNumber,
435 kTransportSequenceNumberExtensionId));
436 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
437 .WillOnce(testing::Return(kTransportSequenceNumber));
438
439 const size_t expected_bytes =
440 GetParam() ? sizeof(kPayloadData) + kGenericHeaderLength +
441 kRtpOverheadBytesPerPacket
442 : sizeof(kPayloadData) + kGenericHeaderLength;
443
444 EXPECT_CALL(feedback_observer_,
445 AddPacket(rtp_sender_->SSRC(), kTransportSequenceNumber,
446 expected_bytes, PacedPacketInfo()))
447 .Times(1);
448 EXPECT_CALL(mock_overhead_observer,
449 OnOverheadChanged(kRtpOverheadBytesPerPacket))
450 .Times(1);
451 SendGenericPayload();
452}
453
454TEST_P(RtpSenderTestWithoutPacer, SendsPacketsWithTransportSequenceNumber) {
Stefan Holmera246cfb2016-08-23 17:51:42 +0200455 rtp_sender_.reset(new RTPSender(
brandtrdbdb3f12016-11-10 05:04:48 -0800456 false, &fake_clock_, &transport_, nullptr, nullptr, &seq_num_allocator_,
457 &feedback_observer_, nullptr, nullptr, nullptr, &mock_rtc_event_log_,
Erik Språng7b52f102018-02-07 14:37:37 +0100458 &send_packet_observer_, &retransmission_rate_limiter_, nullptr, false));
nisse7d59f6b2017-02-21 03:40:24 -0800459 rtp_sender_->SetSSRC(kSsrc);
Stefan Holmerf5dca482016-01-27 12:58:51 +0100460 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
461 kRtpExtensionTransportSequenceNumber,
462 kTransportSequenceNumberExtensionId));
463
Stefan Holmerf5dca482016-01-27 12:58:51 +0100464 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
465 .WillOnce(testing::Return(kTransportSequenceNumber));
asapersson35151f32016-05-02 23:44:01 -0700466 EXPECT_CALL(send_packet_observer_,
467 OnSendPacket(kTransportSequenceNumber, _, _))
468 .Times(1);
minyue3a407ee2017-04-03 01:10:33 -0700469
470 EXPECT_CALL(feedback_observer_,
471 AddPacket(rtp_sender_->SSRC(), kTransportSequenceNumber, _,
472 PacedPacketInfo()))
Stefan Holmera246cfb2016-08-23 17:51:42 +0200473 .Times(1);
asapersson35151f32016-05-02 23:44:01 -0700474
475 SendGenericPayload();
Stefan Holmerf5dca482016-01-27 12:58:51 +0100476
danilchap12ba1862016-10-26 02:41:55 -0700477 const auto& packet = transport_.last_sent_packet();
478 uint16_t transport_seq_no;
479 ASSERT_TRUE(packet.GetExtension<TransportSequenceNumber>(&transport_seq_no));
480 EXPECT_EQ(kTransportSequenceNumber, transport_seq_no);
Petter Strandmark26bc6692018-05-29 08:43:35 +0200481 EXPECT_EQ(transport_.last_options_.packet_id, transport_seq_no);
Sebastian Jansson1bca65b2018-10-10 09:58:08 +0200482 EXPECT_TRUE(transport_.last_options_.included_in_allocation);
Petter Strandmark26bc6692018-05-29 08:43:35 +0200483}
484
485TEST_P(RtpSenderTestWithoutPacer, PacketOptionsNoRetransmission) {
486 rtp_sender_.reset(new RTPSender(
487 false, &fake_clock_, &transport_, nullptr, nullptr, &seq_num_allocator_,
488 &feedback_observer_, nullptr, nullptr, nullptr, &mock_rtc_event_log_,
489 &send_packet_observer_, &retransmission_rate_limiter_, nullptr, false));
490 rtp_sender_->SetSSRC(kSsrc);
491
492 SendGenericPayload();
493
494 EXPECT_FALSE(transport_.last_options_.is_retransmit);
Stefan Holmerf5dca482016-01-27 12:58:51 +0100495}
496
Sebastian Jansson1bca65b2018-10-10 09:58:08 +0200497TEST_P(RtpSenderTestWithoutPacer,
498 SetsIncludedInFeedbackWhenTransportSequenceNumberExtensionIsRegistered) {
499 SetUpRtpSender(false, false);
500 rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionTransportSequenceNumber,
501 kTransportSequenceNumberExtensionId);
502 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
503 .WillOnce(testing::Return(kTransportSequenceNumber));
504 EXPECT_CALL(send_packet_observer_, OnSendPacket).Times(1);
stefana23fc622016-07-28 07:56:38 -0700505 SendGenericPayload();
Sebastian Jansson1bca65b2018-10-10 09:58:08 +0200506 EXPECT_TRUE(transport_.last_options_.included_in_feedback);
507}
508
509TEST_P(
510 RtpSenderTestWithoutPacer,
511 SetsIncludedInAllocationWhenTransportSequenceNumberExtensionIsRegistered) {
512 SetUpRtpSender(false, false);
513 rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionTransportSequenceNumber,
514 kTransportSequenceNumberExtensionId);
515 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
516 .WillOnce(testing::Return(kTransportSequenceNumber));
517 EXPECT_CALL(send_packet_observer_, OnSendPacket).Times(1);
518 SendGenericPayload();
519 EXPECT_TRUE(transport_.last_options_.included_in_allocation);
520}
521
522TEST_P(RtpSenderTestWithoutPacer,
523 SetsIncludedInAllocationWhenForcedAsPartOfAllocation) {
524 SetUpRtpSender(false, false);
525 rtp_sender_->SetAsPartOfAllocation(true);
526 SendGenericPayload();
527 EXPECT_FALSE(transport_.last_options_.included_in_feedback);
528 EXPECT_TRUE(transport_.last_options_.included_in_allocation);
529}
530
531TEST_P(RtpSenderTestWithoutPacer, DoesnSetIncludedInAllocationByDefault) {
532 SetUpRtpSender(false, false);
533 SendGenericPayload();
534 EXPECT_FALSE(transport_.last_options_.included_in_feedback);
535 EXPECT_FALSE(transport_.last_options_.included_in_allocation);
stefana23fc622016-07-28 07:56:38 -0700536}
asapersson35151f32016-05-02 23:44:01 -0700537
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200538TEST_P(RtpSenderTestWithoutPacer, OnSendSideDelayUpdated) {
539 testing::StrictMock<MockSendSideDelayObserver> send_side_delay_observer_;
540 rtp_sender_.reset(
541 new RTPSender(false, &fake_clock_, &transport_, nullptr, nullptr, nullptr,
542 nullptr, nullptr, nullptr, &send_side_delay_observer_,
543 &mock_rtc_event_log_, nullptr, nullptr, nullptr, false));
544 rtp_sender_->SetSSRC(kSsrc);
545
546 const uint8_t kPayloadType = 127;
547 const uint32_t kCaptureTimeMsToRtpTimestamp = 90; // 90 kHz clock
548 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
549 RTPVideoHeader video_header;
550 EXPECT_EQ(0, rtp_sender_->RegisterPayload(payload_name, kPayloadType,
551 1000 * kCaptureTimeMsToRtpTimestamp,
552 0, 1500));
553
554 // Send packet with 10 ms send-side delay. The average and max should be 10
555 // ms.
556 EXPECT_CALL(send_side_delay_observer_, SendSideDelayUpdated(10, 10, kSsrc))
557 .Times(1);
558 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
559 fake_clock_.AdvanceTimeMilliseconds(10);
560 EXPECT_TRUE(rtp_sender_->SendOutgoingData(
561 kVideoFrameKey, kPayloadType,
562 capture_time_ms * kCaptureTimeMsToRtpTimestamp, capture_time_ms,
563 kPayloadData, sizeof(kPayloadData), nullptr, &video_header, nullptr,
564 kDefaultExpectedRetransmissionTimeMs));
565
566 // Send another packet with 20 ms delay. The average
567 // and max should be 15 and 20 ms respectively.
568 EXPECT_CALL(send_side_delay_observer_, SendSideDelayUpdated(15, 20, kSsrc))
569 .Times(1);
570 fake_clock_.AdvanceTimeMilliseconds(10);
571 EXPECT_TRUE(rtp_sender_->SendOutgoingData(
572 kVideoFrameKey, kPayloadType,
573 capture_time_ms * kCaptureTimeMsToRtpTimestamp, capture_time_ms,
574 kPayloadData, sizeof(kPayloadData), nullptr, &video_header, nullptr,
575 kDefaultExpectedRetransmissionTimeMs));
576
577 // Send another packet at the same time, which replaces the last packet.
578 // Since this packet has 0 ms delay, the average is now 5 ms and max is 10 ms.
579 // TODO(terelius): Is is not clear that this is the right behavior.
580 EXPECT_CALL(send_side_delay_observer_, SendSideDelayUpdated(5, 10, kSsrc))
581 .Times(1);
582 capture_time_ms = fake_clock_.TimeInMilliseconds();
583 EXPECT_TRUE(rtp_sender_->SendOutgoingData(
584 kVideoFrameKey, kPayloadType,
585 capture_time_ms * kCaptureTimeMsToRtpTimestamp, capture_time_ms,
586 kPayloadData, sizeof(kPayloadData), nullptr, &video_header, nullptr,
587 kDefaultExpectedRetransmissionTimeMs));
588
589 // Send a packet 1 second later. The earlier packets should have timed
590 // out, so both max and average should be the delay of this packet.
591 fake_clock_.AdvanceTimeMilliseconds(1000);
592 capture_time_ms = fake_clock_.TimeInMilliseconds();
593 fake_clock_.AdvanceTimeMilliseconds(1);
594 EXPECT_CALL(send_side_delay_observer_, SendSideDelayUpdated(1, 1, kSsrc))
595 .Times(1);
596 EXPECT_TRUE(rtp_sender_->SendOutgoingData(
597 kVideoFrameKey, kPayloadType,
598 capture_time_ms * kCaptureTimeMsToRtpTimestamp, capture_time_ms,
599 kPayloadData, sizeof(kPayloadData), nullptr, &video_header, nullptr,
600 kDefaultExpectedRetransmissionTimeMs));
601}
602
minyue3a407ee2017-04-03 01:10:33 -0700603TEST_P(RtpSenderTestWithoutPacer, OnSendPacketUpdated) {
stefana23fc622016-07-28 07:56:38 -0700604 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
605 kRtpExtensionTransportSequenceNumber,
606 kTransportSequenceNumberExtensionId));
asapersson35151f32016-05-02 23:44:01 -0700607 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
608 .WillOnce(testing::Return(kTransportSequenceNumber));
609 EXPECT_CALL(send_packet_observer_,
610 OnSendPacket(kTransportSequenceNumber, _, _))
611 .Times(1);
612
613 SendGenericPayload();
614}
615
minyue3a407ee2017-04-03 01:10:33 -0700616TEST_P(RtpSenderTest, SendsPacketsWithTransportSequenceNumber) {
michaelt4da30442016-11-17 01:38:43 -0800617 rtp_sender_.reset(new RTPSender(
618 false, &fake_clock_, &transport_, &mock_paced_sender_, nullptr,
619 &seq_num_allocator_, &feedback_observer_, nullptr, nullptr, nullptr,
620 &mock_rtc_event_log_, &send_packet_observer_,
Erik Språng7b52f102018-02-07 14:37:37 +0100621 &retransmission_rate_limiter_, nullptr, false));
brandtr9dfff292016-11-14 05:14:50 -0800622 rtp_sender_->SetSequenceNumber(kSeqNum);
623 rtp_sender_->SetSSRC(kSsrc);
Stefan Holmera246cfb2016-08-23 17:51:42 +0200624 rtp_sender_->SetStorePacketsStatus(true, 10);
625 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
626 kRtpExtensionTransportSequenceNumber,
627 kTransportSequenceNumberExtensionId));
628
brandtr9dfff292016-11-14 05:14:50 -0800629 EXPECT_CALL(mock_paced_sender_, InsertPacket(_, kSsrc, kSeqNum, _, _, _));
Stefan Holmera246cfb2016-08-23 17:51:42 +0200630 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
631 .WillOnce(testing::Return(kTransportSequenceNumber));
632 EXPECT_CALL(send_packet_observer_,
633 OnSendPacket(kTransportSequenceNumber, _, _))
634 .Times(1);
minyue3a407ee2017-04-03 01:10:33 -0700635 EXPECT_CALL(feedback_observer_,
636 AddPacket(rtp_sender_->SSRC(), kTransportSequenceNumber, _,
637 PacedPacketInfo()))
Stefan Holmera246cfb2016-08-23 17:51:42 +0200638 .Times(1);
639
640 SendGenericPayload();
philipel8aadd502017-02-23 02:56:13 -0800641 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum,
642 fake_clock_.TimeInMilliseconds(), false,
643 PacedPacketInfo());
Stefan Holmera246cfb2016-08-23 17:51:42 +0200644
danilchap12ba1862016-10-26 02:41:55 -0700645 const auto& packet = transport_.last_sent_packet();
646 uint16_t transport_seq_no;
647 EXPECT_TRUE(packet.GetExtension<TransportSequenceNumber>(&transport_seq_no));
648 EXPECT_EQ(kTransportSequenceNumber, transport_seq_no);
Petter Strandmark26bc6692018-05-29 08:43:35 +0200649 EXPECT_EQ(transport_.last_options_.packet_id, transport_seq_no);
Stefan Holmera246cfb2016-08-23 17:51:42 +0200650}
651
Erik Språng7b52f102018-02-07 14:37:37 +0100652TEST_P(RtpSenderTest, WritesPacerExitToTimingExtension) {
ilnik04f4d122017-06-19 07:18:55 -0700653 rtp_sender_->SetStorePacketsStatus(true, 10);
654 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
655 kRtpExtensionVideoTiming, kVideoTimingExtensionId));
656 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
657 auto packet = rtp_sender_->AllocatePacket();
658 packet->SetPayloadType(kPayload);
659 packet->SetMarker(true);
660 packet->SetTimestamp(kTimestamp);
661 packet->set_capture_time_ms(capture_time_ms);
ilnik2edc6842017-07-06 03:06:50 -0700662 const VideoSendTiming kVideoTiming = {0u, 0u, 0u, 0u, 0u, 0u, true};
ilnik04f4d122017-06-19 07:18:55 -0700663 packet->SetExtension<VideoTimingExtension>(kVideoTiming);
664 EXPECT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
665 size_t packet_size = packet->size();
ilnik04f4d122017-06-19 07:18:55 -0700666
667 const int kStoredTimeInMs = 100;
Erik Språng7b52f102018-02-07 14:37:37 +0100668 {
669 EXPECT_CALL(
670 mock_paced_sender_,
671 InsertPacket(RtpPacketSender::kNormalPriority, kSsrc, _, _, _, _));
672 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
673 kAllowRetransmission,
674 RtpPacketSender::kNormalPriority));
675 }
ilnik04f4d122017-06-19 07:18:55 -0700676 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
Erik Språng7b52f102018-02-07 14:37:37 +0100677 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum, capture_time_ms, false,
678 PacedPacketInfo());
ilnik04f4d122017-06-19 07:18:55 -0700679 EXPECT_EQ(1, transport_.packets_sent());
680 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
681
danilchapce251812017-09-11 12:24:41 -0700682 VideoSendTiming video_timing;
683 EXPECT_TRUE(transport_.last_sent_packet().GetExtension<VideoTimingExtension>(
684 &video_timing));
685 EXPECT_EQ(kStoredTimeInMs, video_timing.pacer_exit_delta_ms);
Erik Språng7b52f102018-02-07 14:37:37 +0100686}
ilnik04f4d122017-06-19 07:18:55 -0700687
Erik Språng7b52f102018-02-07 14:37:37 +0100688TEST_P(RtpSenderTest, WritesNetwork2ToTimingExtension) {
689 SetUpRtpSender(true, true);
690 rtp_sender_->SetStorePacketsStatus(true, 10);
691 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
692 kRtpExtensionVideoTiming, kVideoTimingExtensionId));
693 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
694 auto packet = rtp_sender_->AllocatePacket();
695 packet->SetPayloadType(kPayload);
696 packet->SetMarker(true);
697 packet->SetTimestamp(kTimestamp);
698 packet->set_capture_time_ms(capture_time_ms);
699 const uint16_t kPacerExitMs = 1234u;
700 const VideoSendTiming kVideoTiming = {0u, 0u, 0u, kPacerExitMs, 0u, 0u, true};
701 packet->SetExtension<VideoTimingExtension>(kVideoTiming);
702 EXPECT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
703 size_t packet_size = packet->size();
704
705 const int kStoredTimeInMs = 100;
706 {
707 EXPECT_CALL(
708 mock_paced_sender_,
709 InsertPacket(RtpPacketSender::kNormalPriority, kSsrc, _, _, _, _));
710 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
711 kAllowRetransmission,
712 RtpPacketSender::kNormalPriority));
713 }
ilnik04f4d122017-06-19 07:18:55 -0700714 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
715 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum, capture_time_ms, false,
716 PacedPacketInfo());
Erik Språng7b52f102018-02-07 14:37:37 +0100717 EXPECT_EQ(1, transport_.packets_sent());
ilnik04f4d122017-06-19 07:18:55 -0700718 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
719
Erik Språng7b52f102018-02-07 14:37:37 +0100720 VideoSendTiming video_timing;
danilchapce251812017-09-11 12:24:41 -0700721 EXPECT_TRUE(transport_.last_sent_packet().GetExtension<VideoTimingExtension>(
722 &video_timing));
Erik Språng7b52f102018-02-07 14:37:37 +0100723 EXPECT_EQ(kStoredTimeInMs, video_timing.network2_timestamp_delta_ms);
724 EXPECT_EQ(kPacerExitMs, video_timing.pacer_exit_delta_ms);
ilnik04f4d122017-06-19 07:18:55 -0700725}
726
minyue3a407ee2017-04-03 01:10:33 -0700727TEST_P(RtpSenderTest, TrafficSmoothingWithExtensions) {
Peter Boströme23e7372015-10-08 11:44:14 +0200728 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kNormalPriority,
brandtr9dfff292016-11-14 05:14:50 -0800729 kSsrc, kSeqNum, _, _, _));
Elad Alon4a87e1c2017-10-03 16:11:34 +0200730 EXPECT_CALL(mock_rtc_event_log_,
731 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)));
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000732
pwestin@webrtc.orgc66e8b32012-11-07 17:01:04 +0000733 rtp_sender_->SetStorePacketsStatus(true, 10);
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000734 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
danilchap162abd32015-12-10 02:39:40 -0800735 kRtpExtensionTransmissionTimeOffset,
736 kTransmissionTimeOffsetExtensionId));
737 EXPECT_EQ(
738 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
739 kAbsoluteSendTimeExtensionId));
stefan@webrtc.org8ccb9f92013-06-19 14:13:42 +0000740 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
danilchapb6f1fb52016-10-19 06:11:39 -0700741 auto packet =
742 BuildRtpPacket(kPayload, kMarkerBit, kTimestamp, capture_time_ms);
743 size_t packet_size = packet->size();
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000744
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000745 // Packet should be stored in a send bucket.
danilchapb6f1fb52016-10-19 06:11:39 -0700746 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
747 kAllowRetransmission,
Sergey Ulanov525df3f2016-08-02 17:46:41 -0700748 RtpPacketSender::kNormalPriority));
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000749
danilchap12ba1862016-10-26 02:41:55 -0700750 EXPECT_EQ(0, transport_.packets_sent());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000751
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000752 const int kStoredTimeInMs = 100;
stefan@webrtc.orga678a3b2013-01-21 07:42:11 +0000753 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000754
brandtr9dfff292016-11-14 05:14:50 -0800755 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum, capture_time_ms, false,
philipel8aadd502017-02-23 02:56:13 -0800756 PacedPacketInfo());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000757
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000758 // Process send bucket. Packet should now be sent.
danilchap12ba1862016-10-26 02:41:55 -0700759 EXPECT_EQ(1, transport_.packets_sent());
760 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
761
stefan@webrtc.orga5cb98c2013-05-29 12:12:51 +0000762 webrtc::RTPHeader rtp_header;
danilchap12ba1862016-10-26 02:41:55 -0700763 transport_.last_sent_packet().GetHeader(&rtp_header);
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000764
765 // Verify transmission time offset.
766 EXPECT_EQ(kStoredTimeInMs * 90, rtp_header.extension.transmissionTimeOffset);
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000767 uint64_t expected_send_time =
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000768 ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds());
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000769 EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime);
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000770}
771
minyue3a407ee2017-04-03 01:10:33 -0700772TEST_P(RtpSenderTest, TrafficSmoothingRetransmits) {
Peter Boströme23e7372015-10-08 11:44:14 +0200773 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kNormalPriority,
brandtr9dfff292016-11-14 05:14:50 -0800774 kSsrc, kSeqNum, _, _, _));
Elad Alon4a87e1c2017-10-03 16:11:34 +0200775 EXPECT_CALL(mock_rtc_event_log_,
776 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)));
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000777
778 rtp_sender_->SetStorePacketsStatus(true, 10);
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000779 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
danilchap162abd32015-12-10 02:39:40 -0800780 kRtpExtensionTransmissionTimeOffset,
781 kTransmissionTimeOffsetExtensionId));
782 EXPECT_EQ(
783 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
784 kAbsoluteSendTimeExtensionId));
stefan@webrtc.org8ccb9f92013-06-19 14:13:42 +0000785 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
danilchapb6f1fb52016-10-19 06:11:39 -0700786 auto packet =
787 BuildRtpPacket(kPayload, kMarkerBit, kTimestamp, capture_time_ms);
788 size_t packet_size = packet->size();
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000789
790 // Packet should be stored in a send bucket.
danilchapb6f1fb52016-10-19 06:11:39 -0700791 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
792 kAllowRetransmission,
Sergey Ulanov525df3f2016-08-02 17:46:41 -0700793 RtpPacketSender::kNormalPriority));
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000794
danilchap12ba1862016-10-26 02:41:55 -0700795 EXPECT_EQ(0, transport_.packets_sent());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000796
terelius5d332ac2016-01-14 14:37:39 -0800797 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kNormalPriority,
brandtr9dfff292016-11-14 05:14:50 -0800798 kSsrc, kSeqNum, _, _, _));
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000799
800 const int kStoredTimeInMs = 100;
801 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
802
danilchapb6f1fb52016-10-19 06:11:39 -0700803 EXPECT_EQ(static_cast<int>(packet_size), rtp_sender_->ReSendPacket(kSeqNum));
danilchap12ba1862016-10-26 02:41:55 -0700804 EXPECT_EQ(0, transport_.packets_sent());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000805
brandtr9dfff292016-11-14 05:14:50 -0800806 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum, capture_time_ms, false,
philipel8aadd502017-02-23 02:56:13 -0800807 PacedPacketInfo());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000808
809 // Process send bucket. Packet should now be sent.
danilchap12ba1862016-10-26 02:41:55 -0700810 EXPECT_EQ(1, transport_.packets_sent());
811 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000812
stefan@webrtc.orga5cb98c2013-05-29 12:12:51 +0000813 webrtc::RTPHeader rtp_header;
danilchap12ba1862016-10-26 02:41:55 -0700814 transport_.last_sent_packet().GetHeader(&rtp_header);
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000815
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000816 // Verify transmission time offset.
817 EXPECT_EQ(kStoredTimeInMs * 90, rtp_header.extension.transmissionTimeOffset);
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000818 uint64_t expected_send_time =
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000819 ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds());
820 EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime);
821}
822
823// This test sends 1 regular video packet, then 4 padding packets, and then
824// 1 more regular packet.
minyue3a407ee2017-04-03 01:10:33 -0700825TEST_P(RtpSenderTest, SendPadding) {
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000826 // Make all (non-padding) packets go to send queue.
terelius5d332ac2016-01-14 14:37:39 -0800827 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kNormalPriority,
brandtr9dfff292016-11-14 05:14:50 -0800828 kSsrc, kSeqNum, _, _, _));
Elad Alon4a87e1c2017-10-03 16:11:34 +0200829 EXPECT_CALL(mock_rtc_event_log_,
830 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
831 .Times(1 + 4 + 1);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000832
833 uint16_t seq_num = kSeqNum;
834 uint32_t timestamp = kTimestamp;
835 rtp_sender_->SetStorePacketsStatus(true, 10);
pkasting@chromium.org4591fbd2014-11-20 22:28:14 +0000836 size_t rtp_header_len = kRtpHeaderSize;
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000837 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
danilchap162abd32015-12-10 02:39:40 -0800838 kRtpExtensionTransmissionTimeOffset,
839 kTransmissionTimeOffsetExtensionId));
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000840 rtp_header_len += 4; // 4 bytes extension.
danilchap162abd32015-12-10 02:39:40 -0800841 EXPECT_EQ(
842 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
843 kAbsoluteSendTimeExtensionId));
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000844 rtp_header_len += 4; // 4 bytes extension.
845 rtp_header_len += 4; // 4 extra bytes common to all extension headers.
846
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000847 webrtc::RTPHeader rtp_header;
848
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000849 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
danilchapb6f1fb52016-10-19 06:11:39 -0700850 auto packet =
851 BuildRtpPacket(kPayload, kMarkerBit, timestamp, capture_time_ms);
Stefan Holmer586b19b2015-09-18 11:14:31 +0200852 const uint32_t media_packet_timestamp = timestamp;
danilchapb6f1fb52016-10-19 06:11:39 -0700853 size_t packet_size = packet->size();
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000854
855 // Packet should be stored in a send bucket.
danilchapb6f1fb52016-10-19 06:11:39 -0700856 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
857 kAllowRetransmission,
Sergey Ulanov525df3f2016-08-02 17:46:41 -0700858 RtpPacketSender::kNormalPriority));
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000859
860 int total_packets_sent = 0;
danilchap12ba1862016-10-26 02:41:55 -0700861 EXPECT_EQ(total_packets_sent, transport_.packets_sent());
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000862
863 const int kStoredTimeInMs = 100;
864 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
brandtr9dfff292016-11-14 05:14:50 -0800865 rtp_sender_->TimeToSendPacket(kSsrc, seq_num++, capture_time_ms, false,
philipel8aadd502017-02-23 02:56:13 -0800866 PacedPacketInfo());
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000867 // Packet should now be sent. This test doesn't verify the regular video
868 // packet, since it is tested in another test.
danilchap12ba1862016-10-26 02:41:55 -0700869 EXPECT_EQ(++total_packets_sent, transport_.packets_sent());
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000870 timestamp += 90 * kStoredTimeInMs;
871
872 // Send padding 4 times, waiting 50 ms between each.
873 for (int i = 0; i < 4; ++i) {
874 const int kPaddingPeriodMs = 50;
pkasting@chromium.org4591fbd2014-11-20 22:28:14 +0000875 const size_t kPaddingBytes = 100;
876 const size_t kMaxPaddingLength = 224; // Value taken from rtp_sender.cc.
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000877 // Padding will be forced to full packets.
philipelc7bf32a2017-02-17 03:59:43 -0800878 EXPECT_EQ(kMaxPaddingLength,
philipel8aadd502017-02-23 02:56:13 -0800879 rtp_sender_->TimeToSendPadding(kPaddingBytes, PacedPacketInfo()));
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000880
881 // Process send bucket. Padding should now be sent.
danilchap12ba1862016-10-26 02:41:55 -0700882 EXPECT_EQ(++total_packets_sent, transport_.packets_sent());
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000883 EXPECT_EQ(kMaxPaddingLength + rtp_header_len,
danilchap12ba1862016-10-26 02:41:55 -0700884 transport_.last_sent_packet().size());
885
886 transport_.last_sent_packet().GetHeader(&rtp_header);
pbosbd2522a2015-07-01 05:35:53 -0700887 EXPECT_EQ(kMaxPaddingLength, rtp_header.paddingLength);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000888
Stefan Holmer586b19b2015-09-18 11:14:31 +0200889 // Verify sequence number and timestamp. The timestamp should be the same
890 // as the last media packet.
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000891 EXPECT_EQ(seq_num++, rtp_header.sequenceNumber);
Stefan Holmer586b19b2015-09-18 11:14:31 +0200892 EXPECT_EQ(media_packet_timestamp, rtp_header.timestamp);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000893 // Verify transmission time offset.
Stefan Holmer586b19b2015-09-18 11:14:31 +0200894 int offset = timestamp - media_packet_timestamp;
895 EXPECT_EQ(offset, rtp_header.extension.transmissionTimeOffset);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000896 uint64_t expected_send_time =
897 ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds());
898 EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime);
899 fake_clock_.AdvanceTimeMilliseconds(kPaddingPeriodMs);
900 timestamp += 90 * kPaddingPeriodMs;
901 }
902
903 // Send a regular video packet again.
904 capture_time_ms = fake_clock_.TimeInMilliseconds();
danilchapb6f1fb52016-10-19 06:11:39 -0700905 packet = BuildRtpPacket(kPayload, kMarkerBit, timestamp, capture_time_ms);
906 packet_size = packet->size();
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000907
brandtr9dfff292016-11-14 05:14:50 -0800908 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kNormalPriority,
909 kSsrc, seq_num, _, _, _));
terelius5d332ac2016-01-14 14:37:39 -0800910
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000911 // Packet should be stored in a send bucket.
danilchapb6f1fb52016-10-19 06:11:39 -0700912 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
913 kAllowRetransmission,
Sergey Ulanov525df3f2016-08-02 17:46:41 -0700914 RtpPacketSender::kNormalPriority));
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000915
brandtr9dfff292016-11-14 05:14:50 -0800916 rtp_sender_->TimeToSendPacket(kSsrc, seq_num, capture_time_ms, false,
philipel8aadd502017-02-23 02:56:13 -0800917 PacedPacketInfo());
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000918 // Process send bucket.
danilchap12ba1862016-10-26 02:41:55 -0700919 EXPECT_EQ(++total_packets_sent, transport_.packets_sent());
920 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
921 transport_.last_sent_packet().GetHeader(&rtp_header);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000922
923 // Verify sequence number and timestamp.
924 EXPECT_EQ(seq_num, rtp_header.sequenceNumber);
925 EXPECT_EQ(timestamp, rtp_header.timestamp);
926 // Verify transmission time offset. This packet is sent without delay.
927 EXPECT_EQ(0, rtp_header.extension.transmissionTimeOffset);
928 uint64_t expected_send_time =
929 ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds());
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000930 EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime);
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000931}
pbos@webrtc.org8911ce42013-03-18 16:39:03 +0000932
minyue3a407ee2017-04-03 01:10:33 -0700933TEST_P(RtpSenderTest, OnSendPacketUpdated) {
stefana23fc622016-07-28 07:56:38 -0700934 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
935 kRtpExtensionTransportSequenceNumber,
936 kTransportSequenceNumberExtensionId));
asapersson35151f32016-05-02 23:44:01 -0700937 rtp_sender_->SetStorePacketsStatus(true, 10);
938
939 EXPECT_CALL(send_packet_observer_,
940 OnSendPacket(kTransportSequenceNumber, _, _))
941 .Times(1);
942 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
943 .WillOnce(testing::Return(kTransportSequenceNumber));
brandtr9dfff292016-11-14 05:14:50 -0800944 EXPECT_CALL(mock_paced_sender_, InsertPacket(_, kSsrc, kSeqNum, _, _, _))
945 .Times(1);
asapersson35151f32016-05-02 23:44:01 -0700946
947 SendGenericPayload(); // Packet passed to pacer.
948 const bool kIsRetransmit = false;
brandtr9dfff292016-11-14 05:14:50 -0800949 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum,
950 fake_clock_.TimeInMilliseconds(), kIsRetransmit,
philipel8aadd502017-02-23 02:56:13 -0800951 PacedPacketInfo());
danilchap12ba1862016-10-26 02:41:55 -0700952 EXPECT_EQ(1, transport_.packets_sent());
asapersson35151f32016-05-02 23:44:01 -0700953}
954
minyue3a407ee2017-04-03 01:10:33 -0700955TEST_P(RtpSenderTest, OnSendPacketNotUpdatedForRetransmits) {
stefana23fc622016-07-28 07:56:38 -0700956 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
957 kRtpExtensionTransportSequenceNumber,
958 kTransportSequenceNumberExtensionId));
asapersson35151f32016-05-02 23:44:01 -0700959 rtp_sender_->SetStorePacketsStatus(true, 10);
960
961 EXPECT_CALL(send_packet_observer_, OnSendPacket(_, _, _)).Times(0);
962 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
963 .WillOnce(testing::Return(kTransportSequenceNumber));
brandtr9dfff292016-11-14 05:14:50 -0800964 EXPECT_CALL(mock_paced_sender_, InsertPacket(_, kSsrc, kSeqNum, _, _, _))
965 .Times(1);
asapersson35151f32016-05-02 23:44:01 -0700966
967 SendGenericPayload(); // Packet passed to pacer.
968 const bool kIsRetransmit = true;
brandtr9dfff292016-11-14 05:14:50 -0800969 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum,
970 fake_clock_.TimeInMilliseconds(), kIsRetransmit,
philipel8aadd502017-02-23 02:56:13 -0800971 PacedPacketInfo());
danilchap12ba1862016-10-26 02:41:55 -0700972 EXPECT_EQ(1, transport_.packets_sent());
Petter Strandmark26bc6692018-05-29 08:43:35 +0200973 EXPECT_TRUE(transport_.last_options_.is_retransmit);
asapersson35151f32016-05-02 23:44:01 -0700974}
975
minyue3a407ee2017-04-03 01:10:33 -0700976TEST_P(RtpSenderTest, OnSendPacketNotUpdatedWithoutSeqNumAllocator) {
asapersson35151f32016-05-02 23:44:01 -0700977 rtp_sender_.reset(new RTPSender(
brandtrdbdb3f12016-11-10 05:04:48 -0800978 false, &fake_clock_, &transport_, &mock_paced_sender_, nullptr,
asapersson35151f32016-05-02 23:44:01 -0700979 nullptr /* TransportSequenceNumberAllocator */, nullptr, nullptr, nullptr,
michaelt4da30442016-11-17 01:38:43 -0800980 nullptr, nullptr, &send_packet_observer_, &retransmission_rate_limiter_,
Erik Språng7b52f102018-02-07 14:37:37 +0100981 nullptr, false));
brandtr9dfff292016-11-14 05:14:50 -0800982 rtp_sender_->SetSequenceNumber(kSeqNum);
983 rtp_sender_->SetSSRC(kSsrc);
stefana23fc622016-07-28 07:56:38 -0700984 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
985 kRtpExtensionTransportSequenceNumber,
986 kTransportSequenceNumberExtensionId));
asapersson35151f32016-05-02 23:44:01 -0700987 rtp_sender_->SetSequenceNumber(kSeqNum);
988 rtp_sender_->SetStorePacketsStatus(true, 10);
989
990 EXPECT_CALL(send_packet_observer_, OnSendPacket(_, _, _)).Times(0);
brandtr9dfff292016-11-14 05:14:50 -0800991 EXPECT_CALL(mock_paced_sender_, InsertPacket(_, kSsrc, kSeqNum, _, _, _))
992 .Times(1);
asapersson35151f32016-05-02 23:44:01 -0700993
994 SendGenericPayload(); // Packet passed to pacer.
995 const bool kIsRetransmit = false;
brandtr9dfff292016-11-14 05:14:50 -0800996 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum,
997 fake_clock_.TimeInMilliseconds(), kIsRetransmit,
philipel8aadd502017-02-23 02:56:13 -0800998 PacedPacketInfo());
danilchap12ba1862016-10-26 02:41:55 -0700999 EXPECT_EQ(1, transport_.packets_sent());
asapersson35151f32016-05-02 23:44:01 -07001000}
1001
minyue3a407ee2017-04-03 01:10:33 -07001002TEST_P(RtpSenderTest, SendRedundantPayloads) {
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +00001003 MockTransport transport;
terelius429c3452016-01-21 05:42:04 -08001004 rtp_sender_.reset(new RTPSender(
asapersson35151f32016-05-02 23:44:01 -07001005 false, &fake_clock_, &transport, &mock_paced_sender_, nullptr, nullptr,
brandtrdbdb3f12016-11-10 05:04:48 -08001006 nullptr, nullptr, nullptr, nullptr, &mock_rtc_event_log_, nullptr,
Erik Språng7b52f102018-02-07 14:37:37 +01001007 &retransmission_rate_limiter_, nullptr, false));
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +00001008 rtp_sender_->SetSequenceNumber(kSeqNum);
brandtr9dfff292016-11-14 05:14:50 -08001009 rtp_sender_->SetSSRC(kSsrc);
Shao Changbine62202f2015-04-21 20:24:50 +08001010 rtp_sender_->SetRtxPayloadType(kRtxPayload, kPayload);
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +00001011
1012 uint16_t seq_num = kSeqNum;
1013 rtp_sender_->SetStorePacketsStatus(true, 10);
wu@webrtc.orgebdb0e32014-03-06 23:49:08 +00001014 int32_t rtp_header_len = kRtpHeaderSize;
danilchap162abd32015-12-10 02:39:40 -08001015 EXPECT_EQ(
1016 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
1017 kAbsoluteSendTimeExtensionId));
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +00001018 rtp_header_len += 4; // 4 bytes extension.
1019 rtp_header_len += 4; // 4 extra bytes common to all extension headers.
1020
pbos@webrtc.org0b0c2412015-01-13 14:15:15 +00001021 rtp_sender_->SetRtxStatus(kRtxRetransmitted | kRtxRedundantPayloads);
stefan@webrtc.orgef927552014-06-05 08:25:29 +00001022 rtp_sender_->SetRtxSsrc(1234);
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +00001023
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +00001024 const size_t kNumPayloadSizes = 10;
danilchap162abd32015-12-10 02:39:40 -08001025 const size_t kPayloadSizes[kNumPayloadSizes] = {500, 550, 600, 650, 700,
1026 750, 800, 850, 900, 950};
terelius5d332ac2016-01-14 14:37:39 -08001027 // Expect all packets go through the pacer.
1028 EXPECT_CALL(mock_paced_sender_,
brandtr9dfff292016-11-14 05:14:50 -08001029 InsertPacket(RtpPacketSender::kNormalPriority, kSsrc, _, _, _, _))
terelius5d332ac2016-01-14 14:37:39 -08001030 .Times(kNumPayloadSizes);
Elad Alon4a87e1c2017-10-03 16:11:34 +02001031 EXPECT_CALL(mock_rtc_event_log_,
1032 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
terelius429c3452016-01-21 05:42:04 -08001033 .Times(kNumPayloadSizes);
1034
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +00001035 // Send 10 packets of increasing size.
1036 for (size_t i = 0; i < kNumPayloadSizes; ++i) {
1037 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
stefan1d8a5062015-10-02 03:39:33 -07001038 EXPECT_CALL(transport, SendRtp(_, _, _)).WillOnce(testing::Return(true));
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +00001039 SendPacket(capture_time_ms, kPayloadSizes[i]);
brandtr9dfff292016-11-14 05:14:50 -08001040 rtp_sender_->TimeToSendPacket(kSsrc, seq_num++, capture_time_ms, false,
philipel8aadd502017-02-23 02:56:13 -08001041 PacedPacketInfo());
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +00001042 fake_clock_.AdvanceTimeMilliseconds(33);
1043 }
terelius429c3452016-01-21 05:42:04 -08001044
Elad Alon4a87e1c2017-10-03 16:11:34 +02001045 EXPECT_CALL(mock_rtc_event_log_,
1046 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
terelius429c3452016-01-21 05:42:04 -08001047 .Times(::testing::AtLeast(4));
1048
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +00001049 // The amount of padding to send it too small to send a payload packet.
stefan1d8a5062015-10-02 03:39:33 -07001050 EXPECT_CALL(transport, SendRtp(_, kMaxPaddingSize + rtp_header_len, _))
pbos2d566682015-09-28 09:59:31 -07001051 .WillOnce(testing::Return(true));
philipela1ed0b32016-06-01 06:31:17 -07001052 EXPECT_EQ(kMaxPaddingSize,
philipel8aadd502017-02-23 02:56:13 -08001053 rtp_sender_->TimeToSendPadding(49, PacedPacketInfo()));
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +00001054
Petter Strandmark26bc6692018-05-29 08:43:35 +02001055 PacketOptions options;
Peter Boströmac547a62015-09-17 23:03:57 +02001056 EXPECT_CALL(transport,
stefan1d8a5062015-10-02 03:39:33 -07001057 SendRtp(_, kPayloadSizes[0] + rtp_header_len + kRtxHeaderSize, _))
Yves Gerey665174f2018-06-19 15:03:05 +02001058 .WillOnce(
1059 testing::DoAll(testing::SaveArg<2>(&options), testing::Return(true)));
philipela1ed0b32016-06-01 06:31:17 -07001060 EXPECT_EQ(kPayloadSizes[0],
philipel8aadd502017-02-23 02:56:13 -08001061 rtp_sender_->TimeToSendPadding(500, PacedPacketInfo()));
Petter Strandmark26bc6692018-05-29 08:43:35 +02001062 EXPECT_TRUE(options.is_retransmit);
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +00001063
Yves Gerey665174f2018-06-19 15:03:05 +02001064 EXPECT_CALL(transport, SendRtp(_,
1065 kPayloadSizes[kNumPayloadSizes - 1] +
1066 rtp_header_len + kRtxHeaderSize,
stefan1d8a5062015-10-02 03:39:33 -07001067 _))
pbos2d566682015-09-28 09:59:31 -07001068 .WillOnce(testing::Return(true));
Petter Strandmark26bc6692018-05-29 08:43:35 +02001069
1070 options.is_retransmit = false;
stefan1d8a5062015-10-02 03:39:33 -07001071 EXPECT_CALL(transport, SendRtp(_, kMaxPaddingSize + rtp_header_len, _))
Yves Gerey665174f2018-06-19 15:03:05 +02001072 .WillOnce(
1073 testing::DoAll(testing::SaveArg<2>(&options), testing::Return(true)));
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +00001074 EXPECT_EQ(kPayloadSizes[kNumPayloadSizes - 1] + kMaxPaddingSize,
philipel8aadd502017-02-23 02:56:13 -08001075 rtp_sender_->TimeToSendPadding(999, PacedPacketInfo()));
Petter Strandmark26bc6692018-05-29 08:43:35 +02001076 EXPECT_FALSE(options.is_retransmit);
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +00001077}
1078
minyue3a407ee2017-04-03 01:10:33 -07001079TEST_P(RtpSenderTestWithoutPacer, SendGenericVideo) {
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001080 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
1081 const uint8_t payload_type = 127;
1082 ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 90000,
1083 0, 1500));
1084 uint8_t payload[] = {47, 11, 32, 93, 89};
1085
1086 // Send keyframe
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001087 RTPVideoHeader video_header;
spranga8ae6f22017-09-04 07:23:56 -07001088 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
1089 kVideoFrameKey, payload_type, 1234, 4321, payload, sizeof(payload),
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001090 nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001091
danilchap96c15872016-11-21 01:35:29 -08001092 auto sent_payload = transport_.last_sent_packet().payload();
1093 uint8_t generic_header = sent_payload[0];
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001094 EXPECT_TRUE(generic_header & RtpFormatVideoGeneric::kKeyFrameBit);
1095 EXPECT_TRUE(generic_header & RtpFormatVideoGeneric::kFirstPacketBit);
danilchap96c15872016-11-21 01:35:29 -08001096 EXPECT_THAT(sent_payload.subview(1), ElementsAreArray(payload));
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001097
1098 // Send delta frame
1099 payload[0] = 13;
1100 payload[1] = 42;
1101 payload[4] = 13;
1102
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001103 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
1104 kVideoFrameDelta, payload_type, 1234, 4321, payload, sizeof(payload),
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001105 nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001106
danilchap96c15872016-11-21 01:35:29 -08001107 sent_payload = transport_.last_sent_packet().payload();
1108 generic_header = sent_payload[0];
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001109 EXPECT_FALSE(generic_header & RtpFormatVideoGeneric::kKeyFrameBit);
1110 EXPECT_TRUE(generic_header & RtpFormatVideoGeneric::kFirstPacketBit);
danilchap96c15872016-11-21 01:35:29 -08001111 EXPECT_THAT(sent_payload.subview(1), ElementsAreArray(payload));
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001112}
1113
minyue3a407ee2017-04-03 01:10:33 -07001114TEST_P(RtpSenderTest, SendFlexfecPackets) {
brandtrdbdb3f12016-11-10 05:04:48 -08001115 constexpr int kMediaPayloadType = 127;
1116 constexpr int kFlexfecPayloadType = 118;
1117 constexpr uint32_t kMediaSsrc = 1234;
1118 constexpr uint32_t kFlexfecSsrc = 5678;
Steve Antonf0482ea2018-04-09 13:33:52 -07001119 const char kNoMid[] = "";
brandtrdbdb3f12016-11-10 05:04:48 -08001120 const std::vector<RtpExtension> kNoRtpExtensions;
erikvarga27883732017-05-17 05:08:38 -07001121 const std::vector<RtpExtensionSize> kNoRtpExtensionSizes;
brandtrdbdb3f12016-11-10 05:04:48 -08001122 FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexfecSsrc, kMediaSsrc,
Steve Antonf0482ea2018-04-09 13:33:52 -07001123 kNoMid, kNoRtpExtensions, kNoRtpExtensionSizes,
brandtr48d21a22017-05-30 02:32:12 -07001124 nullptr /* rtp_state */, &fake_clock_);
brandtrdbdb3f12016-11-10 05:04:48 -08001125
1126 // Reset |rtp_sender_| to use FlexFEC.
michaelt4da30442016-11-17 01:38:43 -08001127 rtp_sender_.reset(new RTPSender(
1128 false, &fake_clock_, &transport_, &mock_paced_sender_, &flexfec_sender,
1129 &seq_num_allocator_, nullptr, nullptr, nullptr, nullptr,
1130 &mock_rtc_event_log_, &send_packet_observer_,
Erik Språng7b52f102018-02-07 14:37:37 +01001131 &retransmission_rate_limiter_, nullptr, false));
brandtrdbdb3f12016-11-10 05:04:48 -08001132 rtp_sender_->SetSSRC(kMediaSsrc);
1133 rtp_sender_->SetSequenceNumber(kSeqNum);
brandtrdbdb3f12016-11-10 05:04:48 -08001134 rtp_sender_->SetStorePacketsStatus(true, 10);
1135
1136 // Parameters selected to generate a single FEC packet per media packet.
1137 FecProtectionParams params;
1138 params.fec_rate = 15;
1139 params.max_fec_frames = 1;
1140 params.fec_mask_type = kFecMaskRandom;
1141 rtp_sender_->SetFecParameters(params, params);
1142
brandtr9dfff292016-11-14 05:14:50 -08001143 EXPECT_CALL(mock_paced_sender_,
1144 InsertPacket(RtpPacketSender::kLowPriority, kMediaSsrc, kSeqNum,
1145 _, _, false));
1146 uint16_t flexfec_seq_num;
brandtrdbdb3f12016-11-10 05:04:48 -08001147 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kLowPriority,
brandtr9dfff292016-11-14 05:14:50 -08001148 kFlexfecSsrc, _, _, _, false))
1149 .WillOnce(testing::SaveArg<2>(&flexfec_seq_num));
brandtrdbdb3f12016-11-10 05:04:48 -08001150 SendGenericPayload();
Elad Alon4a87e1c2017-10-03 16:11:34 +02001151 EXPECT_CALL(mock_rtc_event_log_,
1152 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
1153 .Times(2);
philipel8aadd502017-02-23 02:56:13 -08001154 EXPECT_TRUE(rtp_sender_->TimeToSendPacket(kMediaSsrc, kSeqNum,
1155 fake_clock_.TimeInMilliseconds(),
1156 false, PacedPacketInfo()));
brandtr9dfff292016-11-14 05:14:50 -08001157 EXPECT_TRUE(rtp_sender_->TimeToSendPacket(kFlexfecSsrc, flexfec_seq_num,
1158 fake_clock_.TimeInMilliseconds(),
philipel8aadd502017-02-23 02:56:13 -08001159 false, PacedPacketInfo()));
brandtr9dfff292016-11-14 05:14:50 -08001160 ASSERT_EQ(2, transport_.packets_sent());
brandtrdbdb3f12016-11-10 05:04:48 -08001161 const RtpPacketReceived& media_packet = transport_.sent_packets_[0];
1162 EXPECT_EQ(kMediaPayloadType, media_packet.PayloadType());
brandtr9dfff292016-11-14 05:14:50 -08001163 EXPECT_EQ(kSeqNum, media_packet.SequenceNumber());
brandtrdbdb3f12016-11-10 05:04:48 -08001164 EXPECT_EQ(kMediaSsrc, media_packet.Ssrc());
brandtr9dfff292016-11-14 05:14:50 -08001165 const RtpPacketReceived& flexfec_packet = transport_.sent_packets_[1];
1166 EXPECT_EQ(kFlexfecPayloadType, flexfec_packet.PayloadType());
1167 EXPECT_EQ(flexfec_seq_num, flexfec_packet.SequenceNumber());
1168 EXPECT_EQ(kFlexfecSsrc, flexfec_packet.Ssrc());
brandtrdbdb3f12016-11-10 05:04:48 -08001169}
1170
ilnik10894992017-06-21 08:23:19 -07001171// TODO(ilnik): because of webrtc:7859. Once FEC moved below pacer, this test
1172// should be removed.
1173TEST_P(RtpSenderTest, NoFlexfecForTimingFrames) {
1174 constexpr int kMediaPayloadType = 127;
1175 constexpr int kFlexfecPayloadType = 118;
1176 constexpr uint32_t kMediaSsrc = 1234;
1177 constexpr uint32_t kFlexfecSsrc = 5678;
Steve Antonf0482ea2018-04-09 13:33:52 -07001178 const char kNoMid[] = "";
ilnik10894992017-06-21 08:23:19 -07001179 const std::vector<RtpExtension> kNoRtpExtensions;
1180 const std::vector<RtpExtensionSize> kNoRtpExtensionSizes;
ilnike4350192017-06-29 02:27:44 -07001181
ilnik10894992017-06-21 08:23:19 -07001182 FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexfecSsrc, kMediaSsrc,
Steve Antonf0482ea2018-04-09 13:33:52 -07001183 kNoMid, kNoRtpExtensions, kNoRtpExtensionSizes,
ilnik10894992017-06-21 08:23:19 -07001184 nullptr /* rtp_state */, &fake_clock_);
1185
1186 // Reset |rtp_sender_| to use FlexFEC.
1187 rtp_sender_.reset(new RTPSender(
1188 false, &fake_clock_, &transport_, &mock_paced_sender_, &flexfec_sender,
1189 &seq_num_allocator_, nullptr, nullptr, nullptr, nullptr,
1190 &mock_rtc_event_log_, &send_packet_observer_,
Erik Språng7b52f102018-02-07 14:37:37 +01001191 &retransmission_rate_limiter_, nullptr, false));
ilnik10894992017-06-21 08:23:19 -07001192 rtp_sender_->SetSSRC(kMediaSsrc);
1193 rtp_sender_->SetSequenceNumber(kSeqNum);
ilnik10894992017-06-21 08:23:19 -07001194 rtp_sender_->SetStorePacketsStatus(true, 10);
1195
ilnike4350192017-06-29 02:27:44 -07001196 // Need extension to be registered for timing frames to be sent.
1197 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
1198 kRtpExtensionVideoTiming, kVideoTimingExtensionId));
1199
ilnik10894992017-06-21 08:23:19 -07001200 // Parameters selected to generate a single FEC packet per media packet.
1201 FecProtectionParams params;
1202 params.fec_rate = 15;
1203 params.max_fec_frames = 1;
1204 params.fec_mask_type = kFecMaskRandom;
1205 rtp_sender_->SetFecParameters(params, params);
1206
1207 EXPECT_CALL(mock_paced_sender_,
1208 InsertPacket(RtpPacketSender::kLowPriority, kMediaSsrc, kSeqNum,
1209 _, _, false));
1210 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kLowPriority,
1211 kFlexfecSsrc, _, _, _, false))
1212 .Times(0); // Not called because packet should not be protected.
1213
1214 const uint32_t kTimestamp = 1234;
1215 const uint8_t kPayloadType = 127;
1216 const int64_t kCaptureTimeMs = fake_clock_.TimeInMilliseconds();
1217 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
1218 EXPECT_EQ(0, rtp_sender_->RegisterPayload(payload_name, kPayloadType, 90000,
1219 0, 1500));
1220 RTPVideoHeader video_header;
Ilya Nikolaevskiyb6c462d2018-06-05 15:21:32 +02001221 video_header.video_timing.flags = VideoSendTiming::kTriggeredByTimer;
ilnik10894992017-06-21 08:23:19 -07001222 EXPECT_TRUE(rtp_sender_->SendOutgoingData(
1223 kVideoFrameKey, kPayloadType, kTimestamp, kCaptureTimeMs, kPayloadData,
spranga8ae6f22017-09-04 07:23:56 -07001224 sizeof(kPayloadData), nullptr, &video_header, nullptr,
1225 kDefaultExpectedRetransmissionTimeMs));
ilnik10894992017-06-21 08:23:19 -07001226
Elad Alon4a87e1c2017-10-03 16:11:34 +02001227 EXPECT_CALL(mock_rtc_event_log_,
1228 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
1229 .Times(1);
ilnik10894992017-06-21 08:23:19 -07001230 EXPECT_TRUE(rtp_sender_->TimeToSendPacket(kMediaSsrc, kSeqNum,
1231 fake_clock_.TimeInMilliseconds(),
1232 false, PacedPacketInfo()));
1233 ASSERT_EQ(1, transport_.packets_sent());
1234 const RtpPacketReceived& media_packet = transport_.sent_packets_[0];
1235 EXPECT_EQ(kMediaPayloadType, media_packet.PayloadType());
1236 EXPECT_EQ(kSeqNum, media_packet.SequenceNumber());
1237 EXPECT_EQ(kMediaSsrc, media_packet.Ssrc());
1238
1239 // Now try to send not a timing frame.
1240 uint16_t flexfec_seq_num;
1241 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kLowPriority,
1242 kFlexfecSsrc, _, _, _, false))
1243 .WillOnce(testing::SaveArg<2>(&flexfec_seq_num));
1244 EXPECT_CALL(mock_paced_sender_,
1245 InsertPacket(RtpPacketSender::kLowPriority, kMediaSsrc,
1246 kSeqNum + 1, _, _, false));
Ilya Nikolaevskiyb6c462d2018-06-05 15:21:32 +02001247 video_header.video_timing.flags = VideoSendTiming::kInvalid;
ilnik10894992017-06-21 08:23:19 -07001248 EXPECT_TRUE(rtp_sender_->SendOutgoingData(
1249 kVideoFrameKey, kPayloadType, kTimestamp + 1, kCaptureTimeMs + 1,
spranga8ae6f22017-09-04 07:23:56 -07001250 kPayloadData, sizeof(kPayloadData), nullptr, &video_header, nullptr,
1251 kDefaultExpectedRetransmissionTimeMs));
ilnik10894992017-06-21 08:23:19 -07001252
Elad Alon4a87e1c2017-10-03 16:11:34 +02001253 EXPECT_CALL(mock_rtc_event_log_,
1254 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
1255 .Times(2);
ilnik10894992017-06-21 08:23:19 -07001256 EXPECT_TRUE(rtp_sender_->TimeToSendPacket(kMediaSsrc, kSeqNum + 1,
1257 fake_clock_.TimeInMilliseconds(),
1258 false, PacedPacketInfo()));
1259 EXPECT_TRUE(rtp_sender_->TimeToSendPacket(kFlexfecSsrc, flexfec_seq_num,
1260 fake_clock_.TimeInMilliseconds(),
1261 false, PacedPacketInfo()));
1262 ASSERT_EQ(3, transport_.packets_sent());
1263 const RtpPacketReceived& media_packet2 = transport_.sent_packets_[1];
1264 EXPECT_EQ(kMediaPayloadType, media_packet2.PayloadType());
1265 EXPECT_EQ(kSeqNum + 1, media_packet2.SequenceNumber());
1266 EXPECT_EQ(kMediaSsrc, media_packet2.Ssrc());
1267 const RtpPacketReceived& flexfec_packet = transport_.sent_packets_[2];
1268 EXPECT_EQ(kFlexfecPayloadType, flexfec_packet.PayloadType());
1269 EXPECT_EQ(flexfec_seq_num, flexfec_packet.SequenceNumber());
1270 EXPECT_EQ(kFlexfecSsrc, flexfec_packet.Ssrc());
1271}
1272
minyue3a407ee2017-04-03 01:10:33 -07001273TEST_P(RtpSenderTestWithoutPacer, SendFlexfecPackets) {
brandtrdbdb3f12016-11-10 05:04:48 -08001274 constexpr int kMediaPayloadType = 127;
1275 constexpr int kFlexfecPayloadType = 118;
1276 constexpr uint32_t kMediaSsrc = 1234;
1277 constexpr uint32_t kFlexfecSsrc = 5678;
Steve Antonf0482ea2018-04-09 13:33:52 -07001278 const char kNoMid[] = "";
brandtrdbdb3f12016-11-10 05:04:48 -08001279 const std::vector<RtpExtension> kNoRtpExtensions;
erikvarga27883732017-05-17 05:08:38 -07001280 const std::vector<RtpExtensionSize> kNoRtpExtensionSizes;
brandtrdbdb3f12016-11-10 05:04:48 -08001281 FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexfecSsrc, kMediaSsrc,
Steve Antonf0482ea2018-04-09 13:33:52 -07001282 kNoMid, kNoRtpExtensions, kNoRtpExtensionSizes,
brandtr48d21a22017-05-30 02:32:12 -07001283 nullptr /* rtp_state */, &fake_clock_);
brandtrdbdb3f12016-11-10 05:04:48 -08001284
1285 // Reset |rtp_sender_| to use FlexFEC.
Erik Språng7b52f102018-02-07 14:37:37 +01001286 rtp_sender_.reset(
1287 new RTPSender(false, &fake_clock_, &transport_, nullptr, &flexfec_sender,
1288 &seq_num_allocator_, nullptr, nullptr, nullptr, nullptr,
1289 &mock_rtc_event_log_, &send_packet_observer_,
1290 &retransmission_rate_limiter_, nullptr, false));
brandtrdbdb3f12016-11-10 05:04:48 -08001291 rtp_sender_->SetSSRC(kMediaSsrc);
1292 rtp_sender_->SetSequenceNumber(kSeqNum);
brandtrdbdb3f12016-11-10 05:04:48 -08001293
1294 // Parameters selected to generate a single FEC packet per media packet.
1295 FecProtectionParams params;
1296 params.fec_rate = 15;
1297 params.max_fec_frames = 1;
1298 params.fec_mask_type = kFecMaskRandom;
1299 rtp_sender_->SetFecParameters(params, params);
1300
Elad Alon4a87e1c2017-10-03 16:11:34 +02001301 EXPECT_CALL(mock_rtc_event_log_,
1302 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
1303 .Times(2);
brandtrdbdb3f12016-11-10 05:04:48 -08001304 SendGenericPayload();
1305 ASSERT_EQ(2, transport_.packets_sent());
1306 const RtpPacketReceived& media_packet = transport_.sent_packets_[0];
1307 EXPECT_EQ(kMediaPayloadType, media_packet.PayloadType());
1308 EXPECT_EQ(kMediaSsrc, media_packet.Ssrc());
1309 const RtpPacketReceived& flexfec_packet = transport_.sent_packets_[1];
1310 EXPECT_EQ(kFlexfecPayloadType, flexfec_packet.PayloadType());
1311 EXPECT_EQ(kFlexfecSsrc, flexfec_packet.Ssrc());
1312}
1313
Steve Anton296a0ce2018-03-22 15:17:27 -07001314// Test that the MID header extension is included on sent packets when
1315// configured.
1316TEST_P(RtpSenderTestWithoutPacer, MidIncludedOnSentPackets) {
1317 const char kMid[] = "mid";
1318
1319 // Register MID header extension and set the MID for the RTPSender.
1320 rtp_sender_->SetSendingMediaStatus(false);
1321 rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionMid, kMidExtensionId);
1322 rtp_sender_->SetMid(kMid);
1323 rtp_sender_->SetSendingMediaStatus(true);
1324
1325 // Send a couple packets.
1326 SendGenericPayload();
1327 SendGenericPayload();
1328
1329 // Expect both packets to have the MID set.
1330 ASSERT_EQ(2u, transport_.sent_packets_.size());
1331 for (const RtpPacketReceived& packet : transport_.sent_packets_) {
1332 std::string mid;
1333 ASSERT_TRUE(packet.GetExtension<RtpMid>(&mid));
1334 EXPECT_EQ(kMid, mid);
1335 }
1336}
1337
minyue3a407ee2017-04-03 01:10:33 -07001338TEST_P(RtpSenderTest, FecOverheadRate) {
brandtr81eab612017-01-24 04:06:09 -08001339 constexpr int kFlexfecPayloadType = 118;
1340 constexpr uint32_t kMediaSsrc = 1234;
1341 constexpr uint32_t kFlexfecSsrc = 5678;
Steve Antonf0482ea2018-04-09 13:33:52 -07001342 const char kNoMid[] = "";
brandtr81eab612017-01-24 04:06:09 -08001343 const std::vector<RtpExtension> kNoRtpExtensions;
erikvarga27883732017-05-17 05:08:38 -07001344 const std::vector<RtpExtensionSize> kNoRtpExtensionSizes;
brandtr81eab612017-01-24 04:06:09 -08001345 FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexfecSsrc, kMediaSsrc,
Steve Antonf0482ea2018-04-09 13:33:52 -07001346 kNoMid, kNoRtpExtensions, kNoRtpExtensionSizes,
brandtr48d21a22017-05-30 02:32:12 -07001347 nullptr /* rtp_state */, &fake_clock_);
brandtr81eab612017-01-24 04:06:09 -08001348
1349 // Reset |rtp_sender_| to use FlexFEC.
1350 rtp_sender_.reset(new RTPSender(
1351 false, &fake_clock_, &transport_, &mock_paced_sender_, &flexfec_sender,
1352 &seq_num_allocator_, nullptr, nullptr, nullptr, nullptr,
1353 &mock_rtc_event_log_, &send_packet_observer_,
Erik Språng7b52f102018-02-07 14:37:37 +01001354 &retransmission_rate_limiter_, nullptr, false));
brandtr81eab612017-01-24 04:06:09 -08001355 rtp_sender_->SetSSRC(kMediaSsrc);
1356 rtp_sender_->SetSequenceNumber(kSeqNum);
brandtr81eab612017-01-24 04:06:09 -08001357
1358 // Parameters selected to generate a single FEC packet per media packet.
1359 FecProtectionParams params;
1360 params.fec_rate = 15;
1361 params.max_fec_frames = 1;
1362 params.fec_mask_type = kFecMaskRandom;
1363 rtp_sender_->SetFecParameters(params, params);
1364
1365 constexpr size_t kNumMediaPackets = 10;
1366 constexpr size_t kNumFecPackets = kNumMediaPackets;
1367 constexpr int64_t kTimeBetweenPacketsMs = 10;
1368 EXPECT_CALL(mock_paced_sender_, InsertPacket(_, _, _, _, _, false))
1369 .Times(kNumMediaPackets + kNumFecPackets);
1370 for (size_t i = 0; i < kNumMediaPackets; ++i) {
1371 SendGenericPayload();
1372 fake_clock_.AdvanceTimeMilliseconds(kTimeBetweenPacketsMs);
1373 }
1374 constexpr size_t kRtpHeaderLength = 12;
1375 constexpr size_t kFlexfecHeaderLength = 20;
1376 constexpr size_t kGenericCodecHeaderLength = 1;
1377 constexpr size_t kPayloadLength = sizeof(kPayloadData);
1378 constexpr size_t kPacketLength = kRtpHeaderLength + kFlexfecHeaderLength +
1379 kGenericCodecHeaderLength + kPayloadLength;
1380 EXPECT_NEAR(kNumFecPackets * kPacketLength * 8 /
1381 (kNumFecPackets * kTimeBetweenPacketsMs / 1000.0f),
1382 rtp_sender_->FecOverheadRate(), 500);
1383}
1384
minyue3a407ee2017-04-03 01:10:33 -07001385TEST_P(RtpSenderTest, FrameCountCallbacks) {
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001386 class TestCallback : public FrameCountObserver {
1387 public:
pbos@webrtc.orgce4e9a32014-12-18 13:50:16 +00001388 TestCallback() : FrameCountObserver(), num_calls_(0), ssrc_(0) {}
Danil Chapovalovdd7e2842018-03-09 15:37:03 +00001389 ~TestCallback() override = default;
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001390
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00001391 void FrameCountUpdated(const FrameCounts& frame_counts,
1392 uint32_t ssrc) override {
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001393 ++num_calls_;
1394 ssrc_ = ssrc;
pbos@webrtc.orgce4e9a32014-12-18 13:50:16 +00001395 frame_counts_ = frame_counts;
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001396 }
1397
1398 uint32_t num_calls_;
1399 uint32_t ssrc_;
pbos@webrtc.orgce4e9a32014-12-18 13:50:16 +00001400 FrameCounts frame_counts_;
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001401 } callback;
1402
Erik Språng7b52f102018-02-07 14:37:37 +01001403 rtp_sender_.reset(new RTPSender(
1404 false, &fake_clock_, &transport_, &mock_paced_sender_, nullptr, nullptr,
1405 nullptr, nullptr, &callback, nullptr, nullptr, nullptr,
1406 &retransmission_rate_limiter_, nullptr, false));
nisse7d59f6b2017-02-21 03:40:24 -08001407 rtp_sender_->SetSSRC(kSsrc);
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001408 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
1409 const uint8_t payload_type = 127;
1410 ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 90000,
1411 0, 1500));
1412 uint8_t payload[] = {47, 11, 32, 93, 89};
1413 rtp_sender_->SetStorePacketsStatus(true, 1);
1414 uint32_t ssrc = rtp_sender_->SSRC();
1415
terelius5d332ac2016-01-14 14:37:39 -08001416 EXPECT_CALL(mock_paced_sender_, InsertPacket(_, _, _, _, _, _))
1417 .Times(::testing::AtLeast(2));
1418
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001419 RTPVideoHeader video_header;
spranga8ae6f22017-09-04 07:23:56 -07001420 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
1421 kVideoFrameKey, payload_type, 1234, 4321, payload, sizeof(payload),
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001422 nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001423
1424 EXPECT_EQ(1U, callback.num_calls_);
1425 EXPECT_EQ(ssrc, callback.ssrc_);
pbos@webrtc.orgce4e9a32014-12-18 13:50:16 +00001426 EXPECT_EQ(1, callback.frame_counts_.key_frames);
1427 EXPECT_EQ(0, callback.frame_counts_.delta_frames);
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001428
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001429 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
1430 kVideoFrameDelta, payload_type, 1234, 4321, payload, sizeof(payload),
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001431 nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001432
1433 EXPECT_EQ(2U, callback.num_calls_);
1434 EXPECT_EQ(ssrc, callback.ssrc_);
pbos@webrtc.orgce4e9a32014-12-18 13:50:16 +00001435 EXPECT_EQ(1, callback.frame_counts_.key_frames);
1436 EXPECT_EQ(1, callback.frame_counts_.delta_frames);
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001437
andresp@webrtc.org8f151212014-07-10 09:39:23 +00001438 rtp_sender_.reset();
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001439}
1440
minyue3a407ee2017-04-03 01:10:33 -07001441TEST_P(RtpSenderTest, BitrateCallbacks) {
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001442 class TestCallback : public BitrateStatisticsObserver {
1443 public:
sprangcd349d92016-07-13 09:11:28 -07001444 TestCallback()
1445 : BitrateStatisticsObserver(),
1446 num_calls_(0),
1447 ssrc_(0),
1448 total_bitrate_(0),
1449 retransmit_bitrate_(0) {}
Danil Chapovalovdd7e2842018-03-09 15:37:03 +00001450 ~TestCallback() override = default;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001451
sprangcd349d92016-07-13 09:11:28 -07001452 void Notify(uint32_t total_bitrate,
1453 uint32_t retransmit_bitrate,
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00001454 uint32_t ssrc) override {
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001455 ++num_calls_;
1456 ssrc_ = ssrc;
sprangcd349d92016-07-13 09:11:28 -07001457 total_bitrate_ = total_bitrate;
1458 retransmit_bitrate_ = retransmit_bitrate;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001459 }
1460
1461 uint32_t num_calls_;
1462 uint32_t ssrc_;
sprangcd349d92016-07-13 09:11:28 -07001463 uint32_t total_bitrate_;
1464 uint32_t retransmit_bitrate_;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001465 } callback;
Erik Språng7b52f102018-02-07 14:37:37 +01001466 rtp_sender_.reset(
1467 new RTPSender(false, &fake_clock_, &transport_, nullptr, nullptr, nullptr,
1468 nullptr, &callback, nullptr, nullptr, nullptr, nullptr,
1469 &retransmission_rate_limiter_, nullptr, false));
nisse7d59f6b2017-02-21 03:40:24 -08001470 rtp_sender_->SetSSRC(kSsrc);
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001471
sprangcd349d92016-07-13 09:11:28 -07001472 // Simulate kNumPackets sent with kPacketInterval ms intervals, with the
1473 // number of packets selected so that we fill (but don't overflow) the one
1474 // second averaging window.
1475 const uint32_t kWindowSizeMs = 1000;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001476 const uint32_t kPacketInterval = 20;
sprangcd349d92016-07-13 09:11:28 -07001477 const uint32_t kNumPackets =
1478 (kWindowSizeMs - kPacketInterval) / kPacketInterval;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001479 // Overhead = 12 bytes RTP header + 1 byte generic header.
1480 const uint32_t kPacketOverhead = 13;
1481
1482 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
1483 const uint8_t payload_type = 127;
danilchap162abd32015-12-10 02:39:40 -08001484 ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 90000,
1485 0, 1500));
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001486 uint8_t payload[] = {47, 11, 32, 93, 89};
1487 rtp_sender_->SetStorePacketsStatus(true, 1);
1488 uint32_t ssrc = rtp_sender_->SSRC();
1489
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001490 // Initial process call so we get a new time window.
1491 rtp_sender_->ProcessBitrate();
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001492
1493 // Send a few frames.
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001494 RTPVideoHeader video_header;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001495 for (uint32_t i = 0; i < kNumPackets; ++i) {
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001496 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
1497 kVideoFrameKey, payload_type, 1234, 4321, payload, sizeof(payload),
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001498 nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001499 fake_clock_.AdvanceTimeMilliseconds(kPacketInterval);
1500 }
1501
1502 rtp_sender_->ProcessBitrate();
1503
stefan@webrtc.org0bae1fa2014-11-05 14:05:29 +00001504 // We get one call for every stats updated, thus two calls since both the
1505 // stream stats and the retransmit stats are updated once.
1506 EXPECT_EQ(2u, callback.num_calls_);
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001507 EXPECT_EQ(ssrc, callback.ssrc_);
sprangcd349d92016-07-13 09:11:28 -07001508 const uint32_t kTotalPacketSize = kPacketOverhead + sizeof(payload);
1509 // Bitrate measured over delta between last and first timestamp, plus one.
1510 const uint32_t kExpectedWindowMs = kNumPackets * kPacketInterval + 1;
1511 const uint32_t kExpectedBitsAccumulated = kTotalPacketSize * kNumPackets * 8;
1512 const uint32_t kExpectedRateBps =
1513 (kExpectedBitsAccumulated * 1000 + (kExpectedWindowMs / 2)) /
1514 kExpectedWindowMs;
1515 EXPECT_EQ(kExpectedRateBps, callback.total_bitrate_);
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001516
andresp@webrtc.orgd11bec42014-07-08 14:32:58 +00001517 rtp_sender_.reset();
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001518}
1519
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001520class RtpSenderAudioTest : public RtpSenderTest {
1521 protected:
1522 RtpSenderAudioTest() {}
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001523
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00001524 void SetUp() override {
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001525 payload_ = kAudioPayload;
Erik Språng7b52f102018-02-07 14:37:37 +01001526 rtp_sender_.reset(
1527 new RTPSender(true, &fake_clock_, &transport_, nullptr, nullptr,
1528 nullptr, nullptr, nullptr, nullptr, nullptr, nullptr,
1529 nullptr, &retransmission_rate_limiter_, nullptr, false));
nisse7d59f6b2017-02-21 03:40:24 -08001530 rtp_sender_->SetSSRC(kSsrc);
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001531 rtp_sender_->SetSequenceNumber(kSeqNum);
1532 }
1533};
1534
minyue3a407ee2017-04-03 01:10:33 -07001535TEST_P(RtpSenderTestWithoutPacer, StreamDataCountersCallbacks) {
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001536 class TestCallback : public StreamDataCountersCallback {
1537 public:
danilchap162abd32015-12-10 02:39:40 -08001538 TestCallback() : StreamDataCountersCallback(), ssrc_(0), counters_() {}
Danil Chapovalovdd7e2842018-03-09 15:37:03 +00001539 ~TestCallback() override = default;
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001540
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00001541 void DataCountersUpdated(const StreamDataCounters& counters,
1542 uint32_t ssrc) override {
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001543 ssrc_ = ssrc;
1544 counters_ = counters;
1545 }
1546
1547 uint32_t ssrc_;
1548 StreamDataCounters counters_;
asapersson@webrtc.org44149392015-02-04 08:34:47 +00001549
1550 void MatchPacketCounter(const RtpPacketCounter& expected,
1551 const RtpPacketCounter& actual) {
1552 EXPECT_EQ(expected.payload_bytes, actual.payload_bytes);
1553 EXPECT_EQ(expected.header_bytes, actual.header_bytes);
1554 EXPECT_EQ(expected.padding_bytes, actual.padding_bytes);
1555 EXPECT_EQ(expected.packets, actual.packets);
1556 }
1557
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001558 void Matches(uint32_t ssrc, const StreamDataCounters& counters) {
1559 EXPECT_EQ(ssrc, ssrc_);
asapersson@webrtc.org44149392015-02-04 08:34:47 +00001560 MatchPacketCounter(counters.transmitted, counters_.transmitted);
1561 MatchPacketCounter(counters.retransmitted, counters_.retransmitted);
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001562 EXPECT_EQ(counters.fec.packets, counters_.fec.packets);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001563 }
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001564 } callback;
1565
1566 const uint8_t kRedPayloadType = 96;
1567 const uint8_t kUlpfecPayloadType = 97;
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001568 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
1569 const uint8_t payload_type = 127;
1570 ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 90000,
1571 0, 1500));
1572 uint8_t payload[] = {47, 11, 32, 93, 89};
1573 rtp_sender_->SetStorePacketsStatus(true, 1);
1574 uint32_t ssrc = rtp_sender_->SSRC();
1575
1576 rtp_sender_->RegisterRtpStatisticsCallback(&callback);
1577
1578 // Send a frame.
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001579 RTPVideoHeader video_header;
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001580 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001581 kVideoFrameKey, payload_type, 1234, 4321, payload, sizeof(payload),
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001582 nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001583 StreamDataCounters expected;
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001584 expected.transmitted.payload_bytes = 6;
1585 expected.transmitted.header_bytes = 12;
1586 expected.transmitted.padding_bytes = 0;
1587 expected.transmitted.packets = 1;
1588 expected.retransmitted.payload_bytes = 0;
1589 expected.retransmitted.header_bytes = 0;
1590 expected.retransmitted.padding_bytes = 0;
1591 expected.retransmitted.packets = 0;
1592 expected.fec.packets = 0;
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001593 callback.Matches(ssrc, expected);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001594
1595 // Retransmit a frame.
1596 uint16_t seqno = rtp_sender_->SequenceNumber() - 1;
Erik Språnga12b1d62018-03-14 12:39:24 +01001597 rtp_sender_->ReSendPacket(seqno);
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001598 expected.transmitted.payload_bytes = 12;
1599 expected.transmitted.header_bytes = 24;
1600 expected.transmitted.packets = 2;
1601 expected.retransmitted.payload_bytes = 6;
1602 expected.retransmitted.header_bytes = 12;
1603 expected.retransmitted.padding_bytes = 0;
1604 expected.retransmitted.packets = 1;
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001605 callback.Matches(ssrc, expected);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001606
1607 // Send padding.
philipel8aadd502017-02-23 02:56:13 -08001608 rtp_sender_->TimeToSendPadding(kMaxPaddingSize, PacedPacketInfo());
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001609 expected.transmitted.payload_bytes = 12;
1610 expected.transmitted.header_bytes = 36;
1611 expected.transmitted.padding_bytes = kMaxPaddingSize;
1612 expected.transmitted.packets = 3;
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001613 callback.Matches(ssrc, expected);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001614
brandtrf1bb4762016-11-07 03:05:06 -08001615 // Send ULPFEC.
1616 rtp_sender_->SetUlpfecConfig(kRedPayloadType, kUlpfecPayloadType);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001617 FecProtectionParams fec_params;
1618 fec_params.fec_mask_type = kFecMaskRandom;
1619 fec_params.fec_rate = 1;
1620 fec_params.max_fec_frames = 1;
brandtr1743a192016-11-07 03:36:05 -08001621 rtp_sender_->SetFecParameters(fec_params, fec_params);
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001622 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001623 kVideoFrameDelta, payload_type, 1234, 4321, payload, sizeof(payload),
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001624 nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001625 expected.transmitted.payload_bytes = 40;
1626 expected.transmitted.header_bytes = 60;
1627 expected.transmitted.packets = 5;
1628 expected.fec.packets = 1;
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001629 callback.Matches(ssrc, expected);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001630
sprang867fb522015-08-03 04:38:41 -07001631 rtp_sender_->RegisterRtpStatisticsCallback(nullptr);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001632}
1633
minyue3a407ee2017-04-03 01:10:33 -07001634TEST_P(RtpSenderAudioTest, SendAudio) {
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001635 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "PAYLOAD_NAME";
1636 const uint8_t payload_type = 127;
1637 ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 48000,
1638 0, 1500));
1639 uint8_t payload[] = {47, 11, 32, 93, 89};
1640
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001641 RTPVideoHeader video_header;
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001642 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001643 kAudioFrameCN, payload_type, 1234, 4321, payload, sizeof(payload),
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001644 nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001645
danilchap96c15872016-11-21 01:35:29 -08001646 auto sent_payload = transport_.last_sent_packet().payload();
1647 EXPECT_THAT(sent_payload, ElementsAreArray(payload));
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001648}
1649
minyue3a407ee2017-04-03 01:10:33 -07001650TEST_P(RtpSenderAudioTest, SendAudioWithAudioLevelExtension) {
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001651 EXPECT_EQ(0, rtp_sender_->SetAudioLevel(kAudioLevel));
danilchap162abd32015-12-10 02:39:40 -08001652 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAudioLevel,
1653 kAudioLevelExtensionId));
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001654
1655 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "PAYLOAD_NAME";
1656 const uint8_t payload_type = 127;
1657 ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 48000,
1658 0, 1500));
1659 uint8_t payload[] = {47, 11, 32, 93, 89};
1660
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001661 RTPVideoHeader video_header;
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001662 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001663 kAudioFrameCN, payload_type, 1234, 4321, payload, sizeof(payload),
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001664 nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001665
danilchap96c15872016-11-21 01:35:29 -08001666 auto sent_payload = transport_.last_sent_packet().payload();
1667 EXPECT_THAT(sent_payload, ElementsAreArray(payload));
danilchap12ba1862016-10-26 02:41:55 -07001668 // Verify AudioLevel extension.
1669 bool voice_activity;
1670 uint8_t audio_level;
1671 EXPECT_TRUE(transport_.last_sent_packet().GetExtension<AudioLevel>(
1672 &voice_activity, &audio_level));
1673 EXPECT_EQ(kAudioLevel, audio_level);
1674 EXPECT_FALSE(voice_activity);
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001675}
1676
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001677// As RFC4733, named telephone events are carried as part of the audio stream
1678// and must use the same sequence number and timestamp base as the regular
1679// audio channel.
1680// This test checks the marker bit for the first packet and the consequent
1681// packets of the same telephone event. Since it is specifically for DTMF
pbos22993e12015-10-19 02:39:06 -07001682// events, ignoring audio packets and sending kEmptyFrame instead of those.
minyue3a407ee2017-04-03 01:10:33 -07001683TEST_P(RtpSenderAudioTest, CheckMarkerBitForTelephoneEvents) {
solenbergffbbcac2016-11-17 05:25:37 -08001684 const char* kDtmfPayloadName = "telephone-event";
1685 const uint32_t kPayloadFrequency = 8000;
1686 const uint8_t kPayloadType = 126;
1687 ASSERT_EQ(0, rtp_sender_->RegisterPayload(kDtmfPayloadName, kPayloadType,
1688 kPayloadFrequency, 0, 0));
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001689 // For Telephone events, payload is not added to the registered payload list,
1690 // it will register only the payload used for audio stream.
1691 // Registering the payload again for audio stream with different payload name.
solenbergffbbcac2016-11-17 05:25:37 -08001692 const char* kPayloadName = "payload_name";
1693 ASSERT_EQ(0, rtp_sender_->RegisterPayload(kPayloadName, kPayloadType,
1694 kPayloadFrequency, 1, 0));
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001695 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
1696 // DTMF event key=9, duration=500 and attenuationdB=10
1697 rtp_sender_->SendTelephoneEvent(9, 500, 10);
1698 // During start, it takes the starting timestamp as last sent timestamp.
1699 // The duration is calculated as the difference of current and last sent
1700 // timestamp. So for first call it will skip since the duration is zero.
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001701 RTPVideoHeader video_header;
spranga8ae6f22017-09-04 07:23:56 -07001702 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
1703 kEmptyFrame, kPayloadType, capture_time_ms, 0, nullptr, 0, nullptr,
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001704 &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001705 // DTMF Sample Length is (Frequency/1000) * Duration.
1706 // So in this case, it is (8000/1000) * 500 = 4000.
1707 // Sending it as two packets.
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001708 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001709 kEmptyFrame, kPayloadType, capture_time_ms + 2000, 0, nullptr, 0, nullptr,
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001710 &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
danilchap12ba1862016-10-26 02:41:55 -07001711
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001712 // Marker Bit should be set to 1 for first packet.
danilchap12ba1862016-10-26 02:41:55 -07001713 EXPECT_TRUE(transport_.last_sent_packet().Marker());
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001714
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001715 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001716 kEmptyFrame, kPayloadType, capture_time_ms + 4000, 0, nullptr, 0, nullptr,
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001717 &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001718 // Marker Bit should be set to 0 for rest of the packets.
danilchap12ba1862016-10-26 02:41:55 -07001719 EXPECT_FALSE(transport_.last_sent_packet().Marker());
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001720}
1721
minyue3a407ee2017-04-03 01:10:33 -07001722TEST_P(RtpSenderTestWithoutPacer, BytesReportedCorrectly) {
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001723 const char* kPayloadName = "GENERIC";
1724 const uint8_t kPayloadType = 127;
1725 rtp_sender_->SetSSRC(1234);
1726 rtp_sender_->SetRtxSsrc(4321);
Shao Changbine62202f2015-04-21 20:24:50 +08001727 rtp_sender_->SetRtxPayloadType(kPayloadType - 1, kPayloadType);
pbos@webrtc.org0b0c2412015-01-13 14:15:15 +00001728 rtp_sender_->SetRtxStatus(kRtxRetransmitted | kRtxRedundantPayloads);
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001729
danilchap162abd32015-12-10 02:39:40 -08001730 ASSERT_EQ(0, rtp_sender_->RegisterPayload(kPayloadName, kPayloadType, 90000,
1731 0, 1500));
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001732 uint8_t payload[] = {47, 11, 32, 93, 89};
1733
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001734 RTPVideoHeader video_header;
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001735 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001736 kVideoFrameKey, kPayloadType, 1234, 4321, payload, sizeof(payload),
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001737 nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001738
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +00001739 // Will send 2 full-size padding packets.
philipel8aadd502017-02-23 02:56:13 -08001740 rtp_sender_->TimeToSendPadding(1, PacedPacketInfo());
1741 rtp_sender_->TimeToSendPadding(1, PacedPacketInfo());
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001742
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +00001743 StreamDataCounters rtp_stats;
1744 StreamDataCounters rtx_stats;
1745 rtp_sender_->GetDataCounters(&rtp_stats, &rtx_stats);
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001746
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +00001747 // Payload + 1-byte generic header.
asapersson@webrtc.orgd08d3892014-12-16 12:03:11 +00001748 EXPECT_GT(rtp_stats.first_packet_time_ms, -1);
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001749 EXPECT_EQ(rtp_stats.transmitted.payload_bytes, sizeof(payload) + 1);
1750 EXPECT_EQ(rtp_stats.transmitted.header_bytes, 12u);
1751 EXPECT_EQ(rtp_stats.transmitted.padding_bytes, 0u);
1752 EXPECT_EQ(rtx_stats.transmitted.payload_bytes, 0u);
1753 EXPECT_EQ(rtx_stats.transmitted.header_bytes, 24u);
1754 EXPECT_EQ(rtx_stats.transmitted.padding_bytes, 2 * kMaxPaddingSize);
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +00001755
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001756 EXPECT_EQ(rtp_stats.transmitted.TotalBytes(),
danilchap162abd32015-12-10 02:39:40 -08001757 rtp_stats.transmitted.payload_bytes +
1758 rtp_stats.transmitted.header_bytes +
1759 rtp_stats.transmitted.padding_bytes);
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001760 EXPECT_EQ(rtx_stats.transmitted.TotalBytes(),
danilchap162abd32015-12-10 02:39:40 -08001761 rtx_stats.transmitted.payload_bytes +
1762 rtx_stats.transmitted.header_bytes +
1763 rtx_stats.transmitted.padding_bytes);
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001764
danilchap162abd32015-12-10 02:39:40 -08001765 EXPECT_EQ(
1766 transport_.total_bytes_sent_,
1767 rtp_stats.transmitted.TotalBytes() + rtx_stats.transmitted.TotalBytes());
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001768}
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001769
minyue3a407ee2017-04-03 01:10:33 -07001770TEST_P(RtpSenderTestWithoutPacer, RespectsNackBitrateLimit) {
sprang38778b02015-09-29 09:48:22 -07001771 const int32_t kPacketSize = 1400;
1772 const int32_t kNumPackets = 30;
1773
sprangcd349d92016-07-13 09:11:28 -07001774 retransmission_rate_limiter_.SetMaxRate(kPacketSize * kNumPackets * 8);
1775
sprang38778b02015-09-29 09:48:22 -07001776 rtp_sender_->SetStorePacketsStatus(true, kNumPackets);
sprang38778b02015-09-29 09:48:22 -07001777 const uint16_t kStartSequenceNumber = rtp_sender_->SequenceNumber();
Danil Chapovalov2800d742016-08-26 18:48:46 +02001778 std::vector<uint16_t> sequence_numbers;
sprang38778b02015-09-29 09:48:22 -07001779 for (int32_t i = 0; i < kNumPackets; ++i) {
1780 sequence_numbers.push_back(kStartSequenceNumber + i);
1781 fake_clock_.AdvanceTimeMilliseconds(1);
1782 SendPacket(fake_clock_.TimeInMilliseconds(), kPacketSize);
1783 }
danilchap12ba1862016-10-26 02:41:55 -07001784 EXPECT_EQ(kNumPackets, transport_.packets_sent());
sprang38778b02015-09-29 09:48:22 -07001785
1786 fake_clock_.AdvanceTimeMilliseconds(1000 - kNumPackets);
1787
1788 // Resending should work - brings the bandwidth up to the limit.
1789 // NACK bitrate is capped to the same bitrate as the encoder, since the max
1790 // protection overhead is 50% (see MediaOptimization::SetTargetRates).
Danil Chapovalov2800d742016-08-26 18:48:46 +02001791 rtp_sender_->OnReceivedNack(sequence_numbers, 0);
danilchap12ba1862016-10-26 02:41:55 -07001792 EXPECT_EQ(kNumPackets * 2, transport_.packets_sent());
sprang38778b02015-09-29 09:48:22 -07001793
sprangcd349d92016-07-13 09:11:28 -07001794 // Must be at least 5ms in between retransmission attempts.
1795 fake_clock_.AdvanceTimeMilliseconds(5);
1796
sprang38778b02015-09-29 09:48:22 -07001797 // Resending should not work, bandwidth exceeded.
Danil Chapovalov2800d742016-08-26 18:48:46 +02001798 rtp_sender_->OnReceivedNack(sequence_numbers, 0);
danilchap12ba1862016-10-26 02:41:55 -07001799 EXPECT_EQ(kNumPackets * 2, transport_.packets_sent());
sprang38778b02015-09-29 09:48:22 -07001800}
1801
minyue3a407ee2017-04-03 01:10:33 -07001802TEST_P(RtpSenderVideoTest, KeyFrameHasCVO) {
danilchapb6f1fb52016-10-19 06:11:39 -07001803 uint8_t kFrame[kMaxPacketLength];
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001804 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
1805 kRtpExtensionVideoRotation, kVideoRotationExtensionId));
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001806
philipel1a4746a2018-07-09 15:52:29 +02001807 RTPVideoHeader hdr;
danilchapc1600c52016-10-26 03:33:11 -07001808 hdr.rotation = kVideoRotation_0;
Niels Möller520ca4e2018-06-04 11:14:38 +02001809 rtp_sender_video_->SendVideo(kVideoCodecGeneric, kVideoFrameKey, kPayload,
danilchapb6f1fb52016-10-19 06:11:39 -07001810 kTimestamp, 0, kFrame, sizeof(kFrame), nullptr,
spranga8ae6f22017-09-04 07:23:56 -07001811 &hdr, kDefaultExpectedRetransmissionTimeMs);
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001812
danilchapc1600c52016-10-26 03:33:11 -07001813 VideoRotation rotation;
1814 EXPECT_TRUE(
1815 transport_.last_sent_packet().GetExtension<VideoOrientation>(&rotation));
1816 EXPECT_EQ(kVideoRotation_0, rotation);
1817}
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001818
ilnik04f4d122017-06-19 07:18:55 -07001819TEST_P(RtpSenderVideoTest, TimingFrameHasPacketizationTimstampSet) {
1820 uint8_t kFrame[kMaxPacketLength];
1821 const int64_t kPacketizationTimeMs = 100;
1822 const int64_t kEncodeStartDeltaMs = 10;
1823 const int64_t kEncodeFinishDeltaMs = 50;
1824 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
1825 kRtpExtensionVideoTiming, kVideoTimingExtensionId));
1826
1827 const int64_t kCaptureTimestamp = fake_clock_.TimeInMilliseconds();
1828
philipel1a4746a2018-07-09 15:52:29 +02001829 RTPVideoHeader hdr;
Ilya Nikolaevskiyb6c462d2018-06-05 15:21:32 +02001830 hdr.video_timing.flags = VideoSendTiming::kTriggeredByTimer;
ilnik04f4d122017-06-19 07:18:55 -07001831 hdr.video_timing.encode_start_delta_ms = kEncodeStartDeltaMs;
1832 hdr.video_timing.encode_finish_delta_ms = kEncodeFinishDeltaMs;
1833
1834 fake_clock_.AdvanceTimeMilliseconds(kPacketizationTimeMs);
Niels Möller520ca4e2018-06-04 11:14:38 +02001835 rtp_sender_video_->SendVideo(kVideoCodecGeneric, kVideoFrameKey, kPayload,
ilnik04f4d122017-06-19 07:18:55 -07001836 kTimestamp, kCaptureTimestamp, kFrame,
spranga8ae6f22017-09-04 07:23:56 -07001837 sizeof(kFrame), nullptr, &hdr,
1838 kDefaultExpectedRetransmissionTimeMs);
ilnik2edc6842017-07-06 03:06:50 -07001839 VideoSendTiming timing;
ilnik04f4d122017-06-19 07:18:55 -07001840 EXPECT_TRUE(transport_.last_sent_packet().GetExtension<VideoTimingExtension>(
1841 &timing));
1842 EXPECT_EQ(kPacketizationTimeMs, timing.packetization_finish_delta_ms);
1843 EXPECT_EQ(kEncodeStartDeltaMs, timing.encode_start_delta_ms);
1844 EXPECT_EQ(kEncodeFinishDeltaMs, timing.encode_finish_delta_ms);
1845}
1846
minyue3a407ee2017-04-03 01:10:33 -07001847TEST_P(RtpSenderVideoTest, DeltaFrameHasCVOWhenChanged) {
danilchapc1600c52016-10-26 03:33:11 -07001848 uint8_t kFrame[kMaxPacketLength];
1849 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
1850 kRtpExtensionVideoRotation, kVideoRotationExtensionId));
1851
philipel1a4746a2018-07-09 15:52:29 +02001852 RTPVideoHeader hdr;
danilchapc1600c52016-10-26 03:33:11 -07001853 hdr.rotation = kVideoRotation_90;
spranga8ae6f22017-09-04 07:23:56 -07001854 EXPECT_TRUE(rtp_sender_video_->SendVideo(
Niels Möller520ca4e2018-06-04 11:14:38 +02001855 kVideoCodecGeneric, kVideoFrameKey, kPayload, kTimestamp, 0, kFrame,
spranga8ae6f22017-09-04 07:23:56 -07001856 sizeof(kFrame), nullptr, &hdr, kDefaultExpectedRetransmissionTimeMs));
danilchapc1600c52016-10-26 03:33:11 -07001857
1858 hdr.rotation = kVideoRotation_0;
spranga8ae6f22017-09-04 07:23:56 -07001859 EXPECT_TRUE(rtp_sender_video_->SendVideo(
Niels Möller520ca4e2018-06-04 11:14:38 +02001860 kVideoCodecGeneric, kVideoFrameDelta, kPayload, kTimestamp + 1, 0, kFrame,
spranga8ae6f22017-09-04 07:23:56 -07001861 sizeof(kFrame), nullptr, &hdr, kDefaultExpectedRetransmissionTimeMs));
danilchapc1600c52016-10-26 03:33:11 -07001862
1863 VideoRotation rotation;
1864 EXPECT_TRUE(
1865 transport_.last_sent_packet().GetExtension<VideoOrientation>(&rotation));
1866 EXPECT_EQ(kVideoRotation_0, rotation);
1867}
1868
minyue3a407ee2017-04-03 01:10:33 -07001869TEST_P(RtpSenderVideoTest, DeltaFrameHasCVOWhenNonZero) {
danilchapc1600c52016-10-26 03:33:11 -07001870 uint8_t kFrame[kMaxPacketLength];
1871 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
1872 kRtpExtensionVideoRotation, kVideoRotationExtensionId));
1873
philipel1a4746a2018-07-09 15:52:29 +02001874 RTPVideoHeader hdr;
danilchapc1600c52016-10-26 03:33:11 -07001875 hdr.rotation = kVideoRotation_90;
spranga8ae6f22017-09-04 07:23:56 -07001876 EXPECT_TRUE(rtp_sender_video_->SendVideo(
Niels Möller520ca4e2018-06-04 11:14:38 +02001877 kVideoCodecGeneric, kVideoFrameKey, kPayload, kTimestamp, 0, kFrame,
spranga8ae6f22017-09-04 07:23:56 -07001878 sizeof(kFrame), nullptr, &hdr, kDefaultExpectedRetransmissionTimeMs));
danilchapc1600c52016-10-26 03:33:11 -07001879
spranga8ae6f22017-09-04 07:23:56 -07001880 EXPECT_TRUE(rtp_sender_video_->SendVideo(
Niels Möller520ca4e2018-06-04 11:14:38 +02001881 kVideoCodecGeneric, kVideoFrameDelta, kPayload, kTimestamp + 1, 0, kFrame,
spranga8ae6f22017-09-04 07:23:56 -07001882 sizeof(kFrame), nullptr, &hdr, kDefaultExpectedRetransmissionTimeMs));
danilchapc1600c52016-10-26 03:33:11 -07001883
1884 VideoRotation rotation;
1885 EXPECT_TRUE(
1886 transport_.last_sent_packet().GetExtension<VideoOrientation>(&rotation));
1887 EXPECT_EQ(kVideoRotation_90, rotation);
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001888}
magjed71eb61c2016-09-08 03:24:58 -07001889
1890// Make sure rotation is parsed correctly when the Camera (C) and Flip (F) bits
1891// are set in the CVO byte.
minyue3a407ee2017-04-03 01:10:33 -07001892TEST_P(RtpSenderVideoTest, SendVideoWithCameraAndFlipCVO) {
magjed71eb61c2016-09-08 03:24:58 -07001893 // Test extracting rotation when Camera (C) and Flip (F) bits are zero.
1894 EXPECT_EQ(kVideoRotation_0, ConvertCVOByteToVideoRotation(0));
1895 EXPECT_EQ(kVideoRotation_90, ConvertCVOByteToVideoRotation(1));
1896 EXPECT_EQ(kVideoRotation_180, ConvertCVOByteToVideoRotation(2));
1897 EXPECT_EQ(kVideoRotation_270, ConvertCVOByteToVideoRotation(3));
1898 // Test extracting rotation when Camera (C) and Flip (F) bits are set.
1899 const int flip_bit = 1 << 2;
1900 const int camera_bit = 1 << 3;
1901 EXPECT_EQ(kVideoRotation_0,
1902 ConvertCVOByteToVideoRotation(flip_bit | camera_bit | 0));
1903 EXPECT_EQ(kVideoRotation_90,
1904 ConvertCVOByteToVideoRotation(flip_bit | camera_bit | 1));
1905 EXPECT_EQ(kVideoRotation_180,
1906 ConvertCVOByteToVideoRotation(flip_bit | camera_bit | 2));
1907 EXPECT_EQ(kVideoRotation_270,
1908 ConvertCVOByteToVideoRotation(flip_bit | camera_bit | 3));
1909}
1910
spranga8ae6f22017-09-04 07:23:56 -07001911TEST_P(RtpSenderVideoTest, RetransmissionTypesGeneric) {
1912 RTPVideoHeader header;
Niels Möller520ca4e2018-06-04 11:14:38 +02001913 header.codec = kVideoCodecGeneric;
spranga8ae6f22017-09-04 07:23:56 -07001914
1915 EXPECT_EQ(kDontRetransmit,
1916 rtp_sender_video_->GetStorageType(
1917 header, kRetransmitOff, kDefaultExpectedRetransmissionTimeMs));
1918 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1919 header, kRetransmitBaseLayer,
1920 kDefaultExpectedRetransmissionTimeMs));
1921 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1922 header, kRetransmitHigherLayers,
1923 kDefaultExpectedRetransmissionTimeMs));
1924 EXPECT_EQ(kAllowRetransmission,
1925 rtp_sender_video_->GetStorageType(
1926 header, kConditionallyRetransmitHigherLayers,
1927 kDefaultExpectedRetransmissionTimeMs));
1928 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1929 header, kRetransmitAllPackets,
1930 kDefaultExpectedRetransmissionTimeMs));
1931}
1932
1933TEST_P(RtpSenderVideoTest, RetransmissionTypesH264) {
1934 RTPVideoHeader header;
philipel7d745e52018-08-02 14:03:53 +02001935 header.video_type_header.emplace<RTPVideoHeaderH264>().packetization_mode =
1936 H264PacketizationMode::NonInterleaved;
Niels Möller520ca4e2018-06-04 11:14:38 +02001937 header.codec = kVideoCodecH264;
spranga8ae6f22017-09-04 07:23:56 -07001938
1939 EXPECT_EQ(kDontRetransmit,
1940 rtp_sender_video_->GetStorageType(
1941 header, kRetransmitOff, kDefaultExpectedRetransmissionTimeMs));
1942 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1943 header, kRetransmitBaseLayer,
1944 kDefaultExpectedRetransmissionTimeMs));
1945 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1946 header, kRetransmitHigherLayers,
1947 kDefaultExpectedRetransmissionTimeMs));
1948 EXPECT_EQ(kAllowRetransmission,
1949 rtp_sender_video_->GetStorageType(
1950 header, kConditionallyRetransmitHigherLayers,
1951 kDefaultExpectedRetransmissionTimeMs));
1952 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1953 header, kRetransmitAllPackets,
1954 kDefaultExpectedRetransmissionTimeMs));
1955}
1956
1957TEST_P(RtpSenderVideoTest, RetransmissionTypesVP8BaseLayer) {
1958 RTPVideoHeader header;
Niels Möller520ca4e2018-06-04 11:14:38 +02001959 header.codec = kVideoCodecVP8;
Philip Eliassond52a1a62018-09-07 13:03:55 +00001960 auto& vp8_header = header.video_type_header.emplace<RTPVideoHeaderVP8>();
1961 vp8_header.temporalIdx = 0;
spranga8ae6f22017-09-04 07:23:56 -07001962
1963 EXPECT_EQ(kDontRetransmit,
1964 rtp_sender_video_->GetStorageType(
1965 header, kRetransmitOff, kDefaultExpectedRetransmissionTimeMs));
1966 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1967 header, kRetransmitBaseLayer,
1968 kDefaultExpectedRetransmissionTimeMs));
1969 EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType(
1970 header, kRetransmitHigherLayers,
1971 kDefaultExpectedRetransmissionTimeMs));
1972 EXPECT_EQ(kAllowRetransmission,
1973 rtp_sender_video_->GetStorageType(
1974 header, kRetransmitHigherLayers | kRetransmitBaseLayer,
1975 kDefaultExpectedRetransmissionTimeMs));
1976 EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType(
1977 header, kConditionallyRetransmitHigherLayers,
1978 kDefaultExpectedRetransmissionTimeMs));
1979 EXPECT_EQ(
1980 kAllowRetransmission,
1981 rtp_sender_video_->GetStorageType(
1982 header, kRetransmitBaseLayer | kConditionallyRetransmitHigherLayers,
1983 kDefaultExpectedRetransmissionTimeMs));
1984 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1985 header, kRetransmitAllPackets,
1986 kDefaultExpectedRetransmissionTimeMs));
1987}
1988
1989TEST_P(RtpSenderVideoTest, RetransmissionTypesVP8HigherLayers) {
1990 RTPVideoHeader header;
Niels Möller520ca4e2018-06-04 11:14:38 +02001991 header.codec = kVideoCodecVP8;
spranga8ae6f22017-09-04 07:23:56 -07001992
Philip Eliassond52a1a62018-09-07 13:03:55 +00001993 auto& vp8_header = header.video_type_header.emplace<RTPVideoHeaderVP8>();
spranga8ae6f22017-09-04 07:23:56 -07001994 for (int tid = 1; tid <= kMaxTemporalStreams; ++tid) {
Philip Eliassond52a1a62018-09-07 13:03:55 +00001995 vp8_header.temporalIdx = tid;
spranga8ae6f22017-09-04 07:23:56 -07001996
1997 EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType(
1998 header, kRetransmitOff,
1999 kDefaultExpectedRetransmissionTimeMs));
2000 EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType(
2001 header, kRetransmitBaseLayer,
2002 kDefaultExpectedRetransmissionTimeMs));
2003 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
2004 header, kRetransmitHigherLayers,
2005 kDefaultExpectedRetransmissionTimeMs));
2006 EXPECT_EQ(kAllowRetransmission,
2007 rtp_sender_video_->GetStorageType(
2008 header, kRetransmitHigherLayers | kRetransmitBaseLayer,
2009 kDefaultExpectedRetransmissionTimeMs));
2010 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
2011 header, kRetransmitAllPackets,
2012 kDefaultExpectedRetransmissionTimeMs));
2013 }
2014}
2015
2016TEST_P(RtpSenderVideoTest, RetransmissionTypesVP9) {
2017 RTPVideoHeader header;
Niels Möller520ca4e2018-06-04 11:14:38 +02002018 header.codec = kVideoCodecVP9;
spranga8ae6f22017-09-04 07:23:56 -07002019
philipel29d88462018-08-08 14:26:00 +02002020 auto& vp9_header = header.video_type_header.emplace<RTPVideoHeaderVP9>();
spranga8ae6f22017-09-04 07:23:56 -07002021 for (int tid = 1; tid <= kMaxTemporalStreams; ++tid) {
philipel29d88462018-08-08 14:26:00 +02002022 vp9_header.temporal_idx = tid;
spranga8ae6f22017-09-04 07:23:56 -07002023
2024 EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType(
2025 header, kRetransmitOff,
2026 kDefaultExpectedRetransmissionTimeMs));
2027 EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType(
2028 header, kRetransmitBaseLayer,
2029 kDefaultExpectedRetransmissionTimeMs));
2030 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
2031 header, kRetransmitHigherLayers,
2032 kDefaultExpectedRetransmissionTimeMs));
2033 EXPECT_EQ(kAllowRetransmission,
2034 rtp_sender_video_->GetStorageType(
2035 header, kRetransmitHigherLayers | kRetransmitBaseLayer,
2036 kDefaultExpectedRetransmissionTimeMs));
2037 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
2038 header, kRetransmitAllPackets,
2039 kDefaultExpectedRetransmissionTimeMs));
2040 }
2041}
2042
2043TEST_P(RtpSenderVideoTest, ConditionalRetransmit) {
2044 const int64_t kFrameIntervalMs = 33;
2045 const int64_t kRttMs = (kFrameIntervalMs * 3) / 2;
2046 const uint8_t kSettings =
2047 kRetransmitBaseLayer | kConditionallyRetransmitHigherLayers;
2048
2049 // Insert VP8 frames for all temporal layers, but stop before the final index.
2050 RTPVideoHeader header;
Niels Möller520ca4e2018-06-04 11:14:38 +02002051 header.codec = kVideoCodecVP8;
spranga8ae6f22017-09-04 07:23:56 -07002052
2053 // Fill averaging window to prevent rounding errors.
2054 constexpr int kNumRepetitions =
2055 (RTPSenderVideo::kTLRateWindowSizeMs + (kFrameIntervalMs / 2)) /
2056 kFrameIntervalMs;
2057 constexpr int kPattern[] = {0, 2, 1, 2};
Philip Eliassond52a1a62018-09-07 13:03:55 +00002058 auto& vp8_header = header.video_type_header.emplace<RTPVideoHeaderVP8>();
spranga8ae6f22017-09-04 07:23:56 -07002059 for (size_t i = 0; i < arraysize(kPattern) * kNumRepetitions; ++i) {
Philip Eliassond52a1a62018-09-07 13:03:55 +00002060 vp8_header.temporalIdx = kPattern[i % arraysize(kPattern)];
spranga8ae6f22017-09-04 07:23:56 -07002061 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs);
2062 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
2063 }
2064
2065 // Since we're at the start of the pattern, the next expected frame in TL0 is
2066 // right now. We will wait at most one expected retransmission time before
2067 // acknowledging that it did not arrive, which means this frame and the next
2068 // will not be retransmitted.
Philip Eliassond52a1a62018-09-07 13:03:55 +00002069 vp8_header.temporalIdx = 1;
spranga8ae6f22017-09-04 07:23:56 -07002070 EXPECT_EQ(StorageType::kDontRetransmit,
2071 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
2072 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
2073 EXPECT_EQ(StorageType::kDontRetransmit,
2074 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
2075 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
2076
2077 // The TL0 frame did not arrive. So allow retransmission.
2078 EXPECT_EQ(StorageType::kAllowRetransmission,
2079 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
2080 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
2081
2082 // Insert a frame for TL2. We just had frame in TL1, so the next one there is
2083 // in three frames away. TL0 is still too far in the past. So, allow
2084 // retransmission.
Philip Eliassond52a1a62018-09-07 13:03:55 +00002085 vp8_header.temporalIdx = 2;
spranga8ae6f22017-09-04 07:23:56 -07002086 EXPECT_EQ(StorageType::kAllowRetransmission,
2087 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
2088 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
2089
2090 // Another TL2, next in TL1 is two frames away. Allow again.
2091 EXPECT_EQ(StorageType::kAllowRetransmission,
2092 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
2093 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
2094
2095 // Yet another TL2, next in TL1 is now only one frame away, so don't store
2096 // for retransmission.
2097 EXPECT_EQ(StorageType::kDontRetransmit,
2098 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
2099}
2100
2101TEST_P(RtpSenderVideoTest, ConditionalRetransmitLimit) {
2102 const int64_t kFrameIntervalMs = 200;
2103 const int64_t kRttMs = (kFrameIntervalMs * 3) / 2;
2104 const int32_t kSettings =
2105 kRetransmitBaseLayer | kConditionallyRetransmitHigherLayers;
2106
2107 // Insert VP8 frames for all temporal layers, but stop before the final index.
2108 RTPVideoHeader header;
Niels Möller520ca4e2018-06-04 11:14:38 +02002109 header.codec = kVideoCodecVP8;
spranga8ae6f22017-09-04 07:23:56 -07002110
2111 // Fill averaging window to prevent rounding errors.
2112 constexpr int kNumRepetitions =
2113 (RTPSenderVideo::kTLRateWindowSizeMs + (kFrameIntervalMs / 2)) /
2114 kFrameIntervalMs;
2115 constexpr int kPattern[] = {0, 2, 2, 2};
Philip Eliassond52a1a62018-09-07 13:03:55 +00002116 auto& vp8_header = header.video_type_header.emplace<RTPVideoHeaderVP8>();
spranga8ae6f22017-09-04 07:23:56 -07002117 for (size_t i = 0; i < arraysize(kPattern) * kNumRepetitions; ++i) {
Philip Eliassond52a1a62018-09-07 13:03:55 +00002118 vp8_header.temporalIdx = kPattern[i % arraysize(kPattern)];
spranga8ae6f22017-09-04 07:23:56 -07002119
2120 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs);
2121 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
2122 }
2123
2124 // Since we're at the start of the pattern, the next expected frame will be
2125 // right now in TL0. Put it in TL1 instead. Regular rules would dictate that
2126 // we don't store for retransmission because we expect a frame in a lower
2127 // layer, but that last frame in TL1 was a long time ago in absolute terms,
2128 // so allow retransmission anyway.
Philip Eliassond52a1a62018-09-07 13:03:55 +00002129 vp8_header.temporalIdx = 1;
spranga8ae6f22017-09-04 07:23:56 -07002130 EXPECT_EQ(StorageType::kAllowRetransmission,
2131 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
2132}
2133
philipelb3e42a42018-09-13 10:57:14 +02002134TEST_P(RtpSenderVideoTest, PopulateGenericFrameDescriptor) {
2135 const int64_t kFrameId = 100000;
2136 uint8_t kFrame[100];
2137 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
2138 kRtpExtensionGenericFrameDescriptor, kGenericDescriptorId));
2139
2140 RTPVideoHeader hdr;
2141 RTPVideoHeader::GenericDescriptorInfo& generic = hdr.generic.emplace();
2142 generic.frame_id = kFrameId;
2143 generic.temporal_index = 3;
2144 generic.spatial_index = 2;
2145 generic.higher_spatial_layers.push_back(4);
2146 generic.dependencies.push_back(kFrameId - 1);
2147 generic.dependencies.push_back(kFrameId - 500);
2148 rtp_sender_video_->SendVideo(kVideoCodecGeneric, kVideoFrameDelta, kPayload,
2149 kTimestamp, 0, kFrame, sizeof(kFrame), nullptr,
2150 &hdr, kDefaultExpectedRetransmissionTimeMs);
2151
2152 RtpGenericFrameDescriptor descriptor_wire;
2153 EXPECT_EQ(1U, transport_.sent_packets_.size());
2154 EXPECT_TRUE(
2155 transport_.last_sent_packet()
2156 .GetExtension<RtpGenericFrameDescriptorExtension>(&descriptor_wire));
2157 EXPECT_EQ(static_cast<uint16_t>(generic.frame_id), descriptor_wire.FrameId());
2158 EXPECT_EQ(generic.temporal_index, descriptor_wire.TemporalLayer());
2159 EXPECT_THAT(descriptor_wire.FrameDependenciesDiffs(), ElementsAre(1, 500));
2160 uint8_t spatial_bitmask = 0x14;
2161 EXPECT_EQ(spatial_bitmask, descriptor_wire.SpatialLayersBitmask());
2162}
2163
Danil Chapovalov84ffb352018-09-25 18:59:09 +02002164TEST_P(RtpSenderVideoTest,
2165 UsesMinimalVp8DescriptorWhenGenericFrameDescriptorExtensionIsUsed) {
2166 const int64_t kFrameId = 100000;
2167 const size_t kFrameSize = 100;
2168 uint8_t kFrame[kFrameSize];
2169 ASSERT_TRUE(rtp_sender_->RegisterRtpHeaderExtension(
2170 RtpGenericFrameDescriptorExtension::kUri, kGenericDescriptorId));
2171
2172 RTPVideoHeader hdr;
2173 hdr.codec = kVideoCodecVP8;
2174 RTPVideoHeaderVP8& vp8 = hdr.video_type_header.emplace<RTPVideoHeaderVP8>();
2175 vp8.pictureId = kFrameId % 0X7FFF;
2176 vp8.tl0PicIdx = 13;
2177 vp8.temporalIdx = 1;
2178 vp8.keyIdx = 2;
2179 RTPVideoHeader::GenericDescriptorInfo& generic = hdr.generic.emplace();
2180 generic.frame_id = kFrameId;
2181 rtp_sender_video_->SendVideo(kVideoCodecVP8, kVideoFrameDelta, kPayload,
2182 kTimestamp, 0, kFrame, sizeof(kFrame), nullptr,
2183 &hdr, kDefaultExpectedRetransmissionTimeMs);
2184
2185 ASSERT_THAT(transport_.sent_packets_, SizeIs(1));
2186 // Expect only minimal 1-byte vp8 descriptor was generated.
2187 EXPECT_THAT(transport_.sent_packets_[0].payload_size(), 1 + kFrameSize);
2188}
2189
minyue3a407ee2017-04-03 01:10:33 -07002190TEST_P(RtpSenderTest, OnOverheadChanged) {
michaelt4da30442016-11-17 01:38:43 -08002191 MockOverheadObserver mock_overhead_observer;
Erik Språng7b52f102018-02-07 14:37:37 +01002192 rtp_sender_.reset(new RTPSender(
2193 false, &fake_clock_, &transport_, nullptr, nullptr, nullptr, nullptr,
2194 nullptr, nullptr, nullptr, nullptr, nullptr,
2195 &retransmission_rate_limiter_, &mock_overhead_observer, false));
nisse7d59f6b2017-02-21 03:40:24 -08002196 rtp_sender_->SetSSRC(kSsrc);
michaelt4da30442016-11-17 01:38:43 -08002197
michaelt4da30442016-11-17 01:38:43 -08002198 // RTP overhead is 12B.
nisse284542b2017-01-10 08:58:32 -08002199 EXPECT_CALL(mock_overhead_observer, OnOverheadChanged(12)).Times(1);
michaelt4da30442016-11-17 01:38:43 -08002200 SendGenericPayload();
2201
2202 rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionTransmissionTimeOffset,
2203 kTransmissionTimeOffsetExtensionId);
2204
2205 // TransmissionTimeOffset extension has a size of 8B.
nisse284542b2017-01-10 08:58:32 -08002206 // 12B + 8B = 20B
2207 EXPECT_CALL(mock_overhead_observer, OnOverheadChanged(20)).Times(1);
michaelt4da30442016-11-17 01:38:43 -08002208 SendGenericPayload();
2209}
2210
minyue3a407ee2017-04-03 01:10:33 -07002211TEST_P(RtpSenderTest, DoesNotUpdateOverheadOnEqualSize) {
michaelt4da30442016-11-17 01:38:43 -08002212 MockOverheadObserver mock_overhead_observer;
Erik Språng7b52f102018-02-07 14:37:37 +01002213 rtp_sender_.reset(new RTPSender(
2214 false, &fake_clock_, &transport_, nullptr, nullptr, nullptr, nullptr,
2215 nullptr, nullptr, nullptr, nullptr, nullptr,
2216 &retransmission_rate_limiter_, &mock_overhead_observer, false));
nisse7d59f6b2017-02-21 03:40:24 -08002217 rtp_sender_->SetSSRC(kSsrc);
michaelt4da30442016-11-17 01:38:43 -08002218
2219 EXPECT_CALL(mock_overhead_observer, OnOverheadChanged(_)).Times(1);
michaelt4da30442016-11-17 01:38:43 -08002220 SendGenericPayload();
2221 SendGenericPayload();
2222}
2223
sprang168794c2017-07-06 04:38:06 -07002224TEST_P(RtpSenderTest, SendsKeepAlive) {
2225 MockTransport transport;
Erik Språng7b52f102018-02-07 14:37:37 +01002226 rtp_sender_.reset(
2227 new RTPSender(false, &fake_clock_, &transport, nullptr, nullptr, nullptr,
2228 nullptr, nullptr, nullptr, nullptr, &mock_rtc_event_log_,
2229 nullptr, &retransmission_rate_limiter_, nullptr, false));
sprang168794c2017-07-06 04:38:06 -07002230 rtp_sender_->SetSequenceNumber(kSeqNum);
2231 rtp_sender_->SetTimestampOffset(0);
2232 rtp_sender_->SetSSRC(kSsrc);
2233
2234 const uint8_t kKeepalivePayloadType = 20;
2235 RTC_CHECK_NE(kKeepalivePayloadType, kPayload);
2236
2237 EXPECT_CALL(transport, SendRtp(_, _, _))
2238 .WillOnce(
2239 Invoke([&kKeepalivePayloadType](const uint8_t* packet, size_t len,
2240 const PacketOptions& options) {
2241 webrtc::RTPHeader rtp_header;
2242 RtpUtility::RtpHeaderParser parser(packet, len);
2243 EXPECT_TRUE(parser.Parse(&rtp_header, nullptr));
2244 EXPECT_FALSE(rtp_header.markerBit);
2245 EXPECT_EQ(0U, rtp_header.paddingLength);
2246 EXPECT_EQ(kKeepalivePayloadType, rtp_header.payloadType);
2247 EXPECT_EQ(kSeqNum, rtp_header.sequenceNumber);
2248 EXPECT_EQ(kSsrc, rtp_header.ssrc);
2249 EXPECT_EQ(0u, len - rtp_header.headerLength);
2250 return true;
2251 }));
2252
2253 rtp_sender_->SendKeepAlive(kKeepalivePayloadType);
2254 EXPECT_EQ(kSeqNum + 1, rtp_sender_->SequenceNumber());
2255}
2256
minyue3a407ee2017-04-03 01:10:33 -07002257INSTANTIATE_TEST_CASE_P(WithAndWithoutOverhead,
2258 RtpSenderTest,
2259 ::testing::Bool());
2260INSTANTIATE_TEST_CASE_P(WithAndWithoutOverhead,
2261 RtpSenderTestWithoutPacer,
2262 ::testing::Bool());
2263INSTANTIATE_TEST_CASE_P(WithAndWithoutOverhead,
2264 RtpSenderVideoTest,
2265 ::testing::Bool());
2266INSTANTIATE_TEST_CASE_P(WithAndWithoutOverhead,
2267 RtpSenderAudioTest,
2268 ::testing::Bool());
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00002269} // namespace webrtc