blob: 86b92da2e00b9cd14cbd3606c3555b8bb41f7816 [file] [log] [blame]
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +00001/*
phoglund@webrtc.org78088c22012-02-07 14:56:45 +00002 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +00003 *
4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
9 */
10
kwiberg84be5112016-04-27 01:19:58 -070011#include <memory>
danilchapb8b6fbb2015-12-10 05:05:27 -080012#include <vector>
13
Karl Wiberg918f50c2018-07-05 11:40:33 +020014#include "absl/memory/memory.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020015#include "api/video/video_timing.h"
Elad Alon4a87e1c2017-10-03 16:11:34 +020016#include "logging/rtc_event_log/events/rtc_event.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020017#include "logging/rtc_event_log/mock/mock_rtc_event_log.h"
18#include "modules/rtp_rtcp/include/rtp_cvo.h"
19#include "modules/rtp_rtcp/include/rtp_header_extension_map.h"
20#include "modules/rtp_rtcp/include/rtp_header_parser.h"
21#include "modules/rtp_rtcp/include/rtp_rtcp_defines.h"
22#include "modules/rtp_rtcp/source/rtcp_packet/transport_feedback.h"
23#include "modules/rtp_rtcp/source/rtp_format_video_generic.h"
philipelb3e42a42018-09-13 10:57:14 +020024#include "modules/rtp_rtcp/source/rtp_generic_frame_descriptor.h"
25#include "modules/rtp_rtcp/source/rtp_generic_frame_descriptor_extension.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020026#include "modules/rtp_rtcp/source/rtp_header_extensions.h"
27#include "modules/rtp_rtcp/source/rtp_packet_received.h"
28#include "modules/rtp_rtcp/source/rtp_packet_to_send.h"
29#include "modules/rtp_rtcp/source/rtp_sender.h"
30#include "modules/rtp_rtcp/source/rtp_sender_video.h"
31#include "modules/rtp_rtcp/source/rtp_utility.h"
32#include "rtc_base/arraysize.h"
33#include "rtc_base/buffer.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020034#include "rtc_base/rate_limiter.h"
35#include "test/field_trial.h"
36#include "test/gmock.h"
37#include "test/gtest.h"
38#include "test/mock_transport.h"
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +000039
40namespace webrtc {
41
andrew@webrtc.org8a442592011-12-16 21:24:30 +000042namespace {
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +000043const int kTransmissionTimeOffsetExtensionId = 1;
44const int kAbsoluteSendTimeExtensionId = 14;
sprang@webrtc.org30933902015-03-17 14:33:12 +000045const int kTransportSequenceNumberExtensionId = 13;
ilnik04f4d122017-06-19 07:18:55 -070046const int kVideoTimingExtensionId = 12;
Steve Anton296a0ce2018-03-22 15:17:27 -070047const int kMidExtensionId = 11;
andrew@webrtc.org8a442592011-12-16 21:24:30 +000048const int kPayload = 100;
Shao Changbine62202f2015-04-21 20:24:50 +080049const int kRtxPayload = 98;
andrew@webrtc.org8a442592011-12-16 21:24:30 +000050const uint32_t kTimestamp = 10;
51const uint16_t kSeqNum = 33;
brandtr9dfff292016-11-14 05:14:50 -080052const uint32_t kSsrc = 725242;
andrew@webrtc.org8a442592011-12-16 21:24:30 +000053const int kMaxPacketLength = 1500;
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +000054const uint8_t kAudioLevel = 0x5a;
sprang@webrtc.org30933902015-03-17 14:33:12 +000055const uint16_t kTransportSequenceNumber = 0xaabbu;
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +000056const uint8_t kAudioLevelExtensionId = 9;
57const int kAudioPayload = 103;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +000058const uint64_t kStartTime = 123456789;
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +000059const size_t kMaxPaddingSize = 224u;
guoweis@webrtc.org45362892015-03-04 22:55:15 +000060const int kVideoRotationExtensionId = 5;
Stefan Holmera246cfb2016-08-23 17:51:42 +020061const size_t kGenericHeaderLength = 1;
62const uint8_t kPayloadData[] = {47, 11, 32, 93, 89};
spranga8ae6f22017-09-04 07:23:56 -070063const int64_t kDefaultExpectedRetransmissionTimeMs = 125;
philipelb3e42a42018-09-13 10:57:14 +020064const int kGenericDescriptorId = 10;
andrew@webrtc.org8a442592011-12-16 21:24:30 +000065
Danil Chapovalov5e57b172016-09-02 19:15:59 +020066using ::testing::_;
philipelb3e42a42018-09-13 10:57:14 +020067using ::testing::ElementsAre;
Danil Chapovalov5e57b172016-09-02 19:15:59 +020068using ::testing::ElementsAreArray;
sprang168794c2017-07-06 04:38:06 -070069using ::testing::Invoke;
Danil Chapovalov84ffb352018-09-25 18:59:09 +020070using ::testing::SizeIs;
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +000071
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +000072uint64_t ConvertMsToAbsSendTime(int64_t time_ms) {
Stefan Holmer0a87ffc2015-10-21 13:41:48 +020073 return (((time_ms << 18) + 500) / 1000) & 0x00ffffff;
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +000074}
75
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +000076class LoopbackTransportTest : public webrtc::Transport {
77 public:
Petter Strandmark26bc6692018-05-29 08:43:35 +020078 LoopbackTransportTest() : total_bytes_sent_(0) {
danilchap12ba1862016-10-26 02:41:55 -070079 receivers_extensions_.Register(kRtpExtensionTransmissionTimeOffset,
80 kTransmissionTimeOffsetExtensionId);
81 receivers_extensions_.Register(kRtpExtensionAbsoluteSendTime,
82 kAbsoluteSendTimeExtensionId);
83 receivers_extensions_.Register(kRtpExtensionTransportSequenceNumber,
84 kTransportSequenceNumberExtensionId);
85 receivers_extensions_.Register(kRtpExtensionVideoRotation,
86 kVideoRotationExtensionId);
87 receivers_extensions_.Register(kRtpExtensionAudioLevel,
88 kAudioLevelExtensionId);
ilnik04f4d122017-06-19 07:18:55 -070089 receivers_extensions_.Register(kRtpExtensionVideoTiming,
90 kVideoTimingExtensionId);
Steve Anton296a0ce2018-03-22 15:17:27 -070091 receivers_extensions_.Register(kRtpExtensionMid, kMidExtensionId);
philipelb3e42a42018-09-13 10:57:14 +020092 receivers_extensions_.Register(kRtpExtensionGenericFrameDescriptor,
93 kGenericDescriptorId);
guoweis@webrtc.org45362892015-03-04 22:55:15 +000094 }
danilchap12ba1862016-10-26 02:41:55 -070095
stefan1d8a5062015-10-02 03:39:33 -070096 bool SendRtp(const uint8_t* data,
97 size_t len,
98 const PacketOptions& options) override {
Petter Strandmark26bc6692018-05-29 08:43:35 +020099 last_options_ = options;
pkasting@chromium.org4591fbd2014-11-20 22:28:14 +0000100 total_bytes_sent_ += len;
danilchap12ba1862016-10-26 02:41:55 -0700101 sent_packets_.push_back(RtpPacketReceived(&receivers_extensions_));
102 EXPECT_TRUE(sent_packets_.back().Parse(data, len));
pbos2d566682015-09-28 09:59:31 -0700103 return true;
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000104 }
danilchap162abd32015-12-10 02:39:40 -0800105 bool SendRtcp(const uint8_t* data, size_t len) override { return false; }
danilchap12ba1862016-10-26 02:41:55 -0700106 const RtpPacketReceived& last_sent_packet() { return sent_packets_.back(); }
107 int packets_sent() { return sent_packets_.size(); }
108
pbos@webrtc.org72491b92014-07-10 16:24:54 +0000109 size_t total_bytes_sent_;
Petter Strandmark26bc6692018-05-29 08:43:35 +0200110 PacketOptions last_options_;
danilchap12ba1862016-10-26 02:41:55 -0700111 std::vector<RtpPacketReceived> sent_packets_;
112
113 private:
114 RtpHeaderExtensionMap receivers_extensions_;
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000115};
116
Elad Alon4a87e1c2017-10-03 16:11:34 +0200117MATCHER_P(SameRtcEventTypeAs, value, "") {
118 return value == arg->GetType();
119}
120
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000121} // namespace
122
sprangebbf8a82015-09-21 15:11:14 -0700123class MockRtpPacketSender : public RtpPacketSender {
124 public:
125 MockRtpPacketSender() {}
126 virtual ~MockRtpPacketSender() {}
127
Peter Boströme23e7372015-10-08 11:44:14 +0200128 MOCK_METHOD6(InsertPacket,
129 void(Priority priority,
sprangebbf8a82015-09-21 15:11:14 -0700130 uint32_t ssrc,
131 uint16_t sequence_number,
132 int64_t capture_time_ms,
133 size_t bytes,
134 bool retransmission));
135};
136
Stefan Holmerf5dca482016-01-27 12:58:51 +0100137class MockTransportSequenceNumberAllocator
138 : public TransportSequenceNumberAllocator {
139 public:
140 MOCK_METHOD0(AllocateSequenceNumber, uint16_t());
141};
142
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200143class MockSendSideDelayObserver : public SendSideDelayObserver {
144 public:
145 MOCK_METHOD3(SendSideDelayUpdated, void(int, int, uint32_t));
146};
147
asapersson35151f32016-05-02 23:44:01 -0700148class MockSendPacketObserver : public SendPacketObserver {
149 public:
150 MOCK_METHOD3(OnSendPacket, void(uint16_t, int64_t, uint32_t));
151};
152
Stefan Holmera246cfb2016-08-23 17:51:42 +0200153class MockTransportFeedbackObserver : public TransportFeedbackObserver {
154 public:
elad.alond12a8e12017-03-23 11:04:48 -0700155 MOCK_METHOD4(AddPacket,
156 void(uint32_t, uint16_t, size_t, const PacedPacketInfo&));
Stefan Holmera246cfb2016-08-23 17:51:42 +0200157 MOCK_METHOD1(OnTransportFeedback, void(const rtcp::TransportFeedback&));
elad.alonf9490002017-03-06 05:32:21 -0800158 MOCK_CONST_METHOD0(GetTransportFeedbackVector, std::vector<PacketFeedback>());
Stefan Holmera246cfb2016-08-23 17:51:42 +0200159};
160
minyue3a407ee2017-04-03 01:10:33 -0700161class MockOverheadObserver : public OverheadObserver {
162 public:
163 MOCK_METHOD1(OnOverheadChanged, void(size_t overhead_bytes_per_packet));
164};
165
166class RtpSenderTest : public ::testing::TestWithParam<bool> {
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000167 protected:
168 RtpSenderTest()
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +0000169 : fake_clock_(kStartTime),
terelius429c3452016-01-21 05:42:04 -0800170 mock_rtc_event_log_(),
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +0000171 mock_paced_sender_(),
sprangcd349d92016-07-13 09:11:28 -0700172 retransmission_rate_limiter_(&fake_clock_, 1000),
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +0000173 rtp_sender_(),
174 payload_(kPayload),
175 transport_(),
minyue3a407ee2017-04-03 01:10:33 -0700176 kMarkerBit(true),
177 field_trials_(GetParam() ? "WebRTC-SendSideBwe-WithOverhead/Enabled/"
178 : "") {}
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +0000179
Erik Språng7b52f102018-02-07 14:37:37 +0100180 void SetUp() override { SetUpRtpSender(true, false); }
Peter Boströme23e7372015-10-08 11:44:14 +0200181
Erik Språng7b52f102018-02-07 14:37:37 +0100182 void SetUpRtpSender(bool pacer, bool populate_network2) {
asapersson35151f32016-05-02 23:44:01 -0700183 rtp_sender_.reset(new RTPSender(
184 false, &fake_clock_, &transport_, pacer ? &mock_paced_sender_ : nullptr,
brandtrdbdb3f12016-11-10 05:04:48 -0800185 nullptr, &seq_num_allocator_, nullptr, nullptr, nullptr, nullptr,
sprangcd349d92016-07-13 09:11:28 -0700186 &mock_rtc_event_log_, &send_packet_observer_,
Erik Språng7b52f102018-02-07 14:37:37 +0100187 &retransmission_rate_limiter_, nullptr, populate_network2));
brandtr9dfff292016-11-14 05:14:50 -0800188 rtp_sender_->SetSequenceNumber(kSeqNum);
danilchap71fead22016-08-18 02:01:49 -0700189 rtp_sender_->SetTimestampOffset(0);
brandtr9dfff292016-11-14 05:14:50 -0800190 rtp_sender_->SetSSRC(kSsrc);
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +0000191 }
192
stefan@webrtc.orga678a3b2013-01-21 07:42:11 +0000193 SimulatedClock fake_clock_;
stefana23fc622016-07-28 07:56:38 -0700194 testing::NiceMock<MockRtcEventLog> mock_rtc_event_log_;
sprangebbf8a82015-09-21 15:11:14 -0700195 MockRtpPacketSender mock_paced_sender_;
stefana23fc622016-07-28 07:56:38 -0700196 testing::StrictMock<MockTransportSequenceNumberAllocator> seq_num_allocator_;
197 testing::StrictMock<MockSendPacketObserver> send_packet_observer_;
Stefan Holmera246cfb2016-08-23 17:51:42 +0200198 testing::StrictMock<MockTransportFeedbackObserver> feedback_observer_;
sprangcd349d92016-07-13 09:11:28 -0700199 RateLimiter retransmission_rate_limiter_;
kwiberg84be5112016-04-27 01:19:58 -0700200 std::unique_ptr<RTPSender> rtp_sender_;
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +0000201 int payload_;
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000202 LoopbackTransportTest transport_;
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000203 const bool kMarkerBit;
minyue3a407ee2017-04-03 01:10:33 -0700204 test::ScopedFieldTrials field_trials_;
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000205
stefan@webrtc.orga5cb98c2013-05-29 12:12:51 +0000206 void VerifyRTPHeaderCommon(const RTPHeader& rtp_header) {
danilchapd9e62f52016-01-14 14:55:19 -0800207 VerifyRTPHeaderCommon(rtp_header, kMarkerBit, 0);
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000208 }
209
210 void VerifyRTPHeaderCommon(const RTPHeader& rtp_header, bool marker_bit) {
danilchapd9e62f52016-01-14 14:55:19 -0800211 VerifyRTPHeaderCommon(rtp_header, marker_bit, 0);
212 }
213
214 void VerifyRTPHeaderCommon(const RTPHeader& rtp_header,
215 bool marker_bit,
216 uint8_t number_of_csrcs) {
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000217 EXPECT_EQ(marker_bit, rtp_header.markerBit);
stefan@webrtc.orga5cb98c2013-05-29 12:12:51 +0000218 EXPECT_EQ(payload_, rtp_header.payloadType);
219 EXPECT_EQ(kSeqNum, rtp_header.sequenceNumber);
220 EXPECT_EQ(kTimestamp, rtp_header.timestamp);
221 EXPECT_EQ(rtp_sender_->SSRC(), rtp_header.ssrc);
danilchapd9e62f52016-01-14 14:55:19 -0800222 EXPECT_EQ(number_of_csrcs, rtp_header.numCSRCs);
pkasting@chromium.org4591fbd2014-11-20 22:28:14 +0000223 EXPECT_EQ(0U, rtp_header.paddingLength);
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000224 }
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000225
danilchapb6f1fb52016-10-19 06:11:39 -0700226 std::unique_ptr<RtpPacketToSend> BuildRtpPacket(int payload_type,
227 bool marker_bit,
228 uint32_t timestamp,
229 int64_t capture_time_ms) {
230 auto packet = rtp_sender_->AllocatePacket();
231 packet->SetPayloadType(payload_type);
232 packet->SetMarker(marker_bit);
233 packet->SetTimestamp(timestamp);
234 packet->set_capture_time_ms(capture_time_ms);
235 EXPECT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
236 return packet;
237 }
238
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000239 void SendPacket(int64_t capture_time_ms, int payload_length) {
240 uint32_t timestamp = capture_time_ms * 90;
danilchapb6f1fb52016-10-19 06:11:39 -0700241 auto packet =
242 BuildRtpPacket(kPayload, kMarkerBit, timestamp, capture_time_ms);
243 packet->AllocatePayload(payload_length);
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000244
245 // Packet should be stored in a send bucket.
danilchapb6f1fb52016-10-19 06:11:39 -0700246 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
247 kAllowRetransmission,
248 RtpPacketSender::kNormalPriority));
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000249 }
asapersson35151f32016-05-02 23:44:01 -0700250
251 void SendGenericPayload() {
asapersson35151f32016-05-02 23:44:01 -0700252 const uint32_t kTimestamp = 1234;
253 const uint8_t kPayloadType = 127;
254 const int64_t kCaptureTimeMs = fake_clock_.TimeInMilliseconds();
255 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
256 EXPECT_EQ(0, rtp_sender_->RegisterPayload(payload_name, kPayloadType, 90000,
257 0, 1500));
258
Sami Kalliomäki426a80c2018-08-08 11:37:59 +0200259 RTPVideoHeader video_header;
Sergey Ulanov525df3f2016-08-02 17:46:41 -0700260 EXPECT_TRUE(rtp_sender_->SendOutgoingData(
Stefan Holmera246cfb2016-08-23 17:51:42 +0200261 kVideoFrameKey, kPayloadType, kTimestamp, kCaptureTimeMs, kPayloadData,
Sami Kalliomäki426a80c2018-08-08 11:37:59 +0200262 sizeof(kPayloadData), nullptr, &video_header, nullptr,
spranga8ae6f22017-09-04 07:23:56 -0700263 kDefaultExpectedRetransmissionTimeMs));
asapersson35151f32016-05-02 23:44:01 -0700264 }
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000265};
266
Peter Boströme23e7372015-10-08 11:44:14 +0200267// TODO(pbos): Move tests over from WithoutPacer to RtpSenderTest as this is our
268// default code path.
269class RtpSenderTestWithoutPacer : public RtpSenderTest {
270 public:
Erik Språng7b52f102018-02-07 14:37:37 +0100271 void SetUp() override { SetUpRtpSender(false, false); }
Peter Boströme23e7372015-10-08 11:44:14 +0200272};
273
spranga8ae6f22017-09-04 07:23:56 -0700274class TestRtpSenderVideo : public RTPSenderVideo {
275 public:
276 TestRtpSenderVideo(Clock* clock,
277 RTPSender* rtp_sender,
278 FlexfecSender* flexfec_sender)
279 : RTPSenderVideo(clock, rtp_sender, flexfec_sender) {}
280 ~TestRtpSenderVideo() override {}
281
282 StorageType GetStorageType(const RTPVideoHeader& header,
283 int32_t retransmission_settings,
284 int64_t expected_retransmission_time_ms) {
285 return RTPSenderVideo::GetStorageType(GetTemporalId(header),
286 retransmission_settings,
287 expected_retransmission_time_ms);
288 }
289};
290
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000291class RtpSenderVideoTest : public RtpSenderTest {
292 protected:
danilchap162abd32015-12-10 02:39:40 -0800293 void SetUp() override {
Peter Boströme23e7372015-10-08 11:44:14 +0200294 // TODO(pbos): Set up to use pacer.
Erik Språng7b52f102018-02-07 14:37:37 +0100295 SetUpRtpSender(false, false);
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000296 rtp_sender_video_.reset(
spranga8ae6f22017-09-04 07:23:56 -0700297 new TestRtpSenderVideo(&fake_clock_, rtp_sender_.get(), nullptr));
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000298 }
spranga8ae6f22017-09-04 07:23:56 -0700299 std::unique_ptr<TestRtpSenderVideo> rtp_sender_video_;
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000300};
301
minyue3a407ee2017-04-03 01:10:33 -0700302TEST_P(RtpSenderTestWithoutPacer, AllocatePacketSetCsrc) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200303 // Configure rtp_sender with csrc.
304 std::vector<uint32_t> csrcs;
305 csrcs.push_back(0x23456789);
306 rtp_sender_->SetCsrcs(csrcs);
307
308 auto packet = rtp_sender_->AllocatePacket();
309
310 ASSERT_TRUE(packet);
311 EXPECT_EQ(rtp_sender_->SSRC(), packet->Ssrc());
312 EXPECT_EQ(csrcs, packet->Csrcs());
313}
314
minyue3a407ee2017-04-03 01:10:33 -0700315TEST_P(RtpSenderTestWithoutPacer, AllocatePacketReserveExtensions) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200316 // Configure rtp_sender with extensions.
317 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
318 kRtpExtensionTransmissionTimeOffset,
319 kTransmissionTimeOffsetExtensionId));
320 ASSERT_EQ(
321 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
322 kAbsoluteSendTimeExtensionId));
323 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAudioLevel,
324 kAudioLevelExtensionId));
325 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
326 kRtpExtensionTransportSequenceNumber,
327 kTransportSequenceNumberExtensionId));
328 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
329 kRtpExtensionVideoRotation, kVideoRotationExtensionId));
330
331 auto packet = rtp_sender_->AllocatePacket();
332
333 ASSERT_TRUE(packet);
334 // Preallocate BWE extensions RtpSender set itself.
335 EXPECT_TRUE(packet->HasExtension<TransmissionOffset>());
336 EXPECT_TRUE(packet->HasExtension<AbsoluteSendTime>());
337 EXPECT_TRUE(packet->HasExtension<TransportSequenceNumber>());
338 // Do not allocate media specific extensions.
339 EXPECT_FALSE(packet->HasExtension<AudioLevel>());
340 EXPECT_FALSE(packet->HasExtension<VideoOrientation>());
341}
342
minyue3a407ee2017-04-03 01:10:33 -0700343TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberAdvanceSequenceNumber) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200344 auto packet = rtp_sender_->AllocatePacket();
345 ASSERT_TRUE(packet);
346 const uint16_t sequence_number = rtp_sender_->SequenceNumber();
347
348 EXPECT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
349
350 EXPECT_EQ(sequence_number, packet->SequenceNumber());
351 EXPECT_EQ(sequence_number + 1, rtp_sender_->SequenceNumber());
352}
353
minyue3a407ee2017-04-03 01:10:33 -0700354TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberFailsOnNotSending) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200355 auto packet = rtp_sender_->AllocatePacket();
356 ASSERT_TRUE(packet);
357
358 rtp_sender_->SetSendingMediaStatus(false);
359 EXPECT_FALSE(rtp_sender_->AssignSequenceNumber(packet.get()));
360}
361
Danil Chapovalovb3179c72018-03-22 10:13:07 +0100362TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberMayAllowPaddingOnVideo) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200363 constexpr size_t kPaddingSize = 100;
364 auto packet = rtp_sender_->AllocatePacket();
365 ASSERT_TRUE(packet);
366
philipel8aadd502017-02-23 02:56:13 -0800367 ASSERT_FALSE(rtp_sender_->TimeToSendPadding(kPaddingSize, PacedPacketInfo()));
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200368 packet->SetMarker(false);
369 ASSERT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
Danil Chapovalovb3179c72018-03-22 10:13:07 +0100370 // Packet without marker bit doesn't allow padding on video stream.
philipel8aadd502017-02-23 02:56:13 -0800371 EXPECT_FALSE(rtp_sender_->TimeToSendPadding(kPaddingSize, PacedPacketInfo()));
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200372
373 packet->SetMarker(true);
374 ASSERT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
375 // Packet with marker bit allows send padding.
philipel8aadd502017-02-23 02:56:13 -0800376 EXPECT_TRUE(rtp_sender_->TimeToSendPadding(kPaddingSize, PacedPacketInfo()));
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200377}
378
Danil Chapovalovb3179c72018-03-22 10:13:07 +0100379TEST_P(RtpSenderTest, AssignSequenceNumberAllowsPaddingOnAudio) {
380 MockTransport transport;
381 const bool kEnableAudio = true;
382 rtp_sender_.reset(new RTPSender(
383 kEnableAudio, &fake_clock_, &transport, &mock_paced_sender_, nullptr,
384 nullptr, nullptr, nullptr, nullptr, nullptr, &mock_rtc_event_log_,
385 nullptr, &retransmission_rate_limiter_, nullptr, false));
386 rtp_sender_->SetTimestampOffset(0);
387 rtp_sender_->SetSSRC(kSsrc);
388
389 std::unique_ptr<RtpPacketToSend> audio_packet = rtp_sender_->AllocatePacket();
390 // Padding on audio stream allowed regardless of marker in the last packet.
391 audio_packet->SetMarker(false);
392 audio_packet->SetPayloadType(kPayload);
393 rtp_sender_->AssignSequenceNumber(audio_packet.get());
394
395 const size_t kPaddingSize = 59;
396 EXPECT_CALL(transport, SendRtp(_, kPaddingSize + kRtpHeaderSize, _))
397 .WillOnce(testing::Return(true));
398 EXPECT_EQ(kPaddingSize,
399 rtp_sender_->TimeToSendPadding(kPaddingSize, PacedPacketInfo()));
400
401 // Requested padding size is too small, will send a larger one.
402 const size_t kMinPaddingSize = 50;
403 EXPECT_CALL(transport, SendRtp(_, kMinPaddingSize + kRtpHeaderSize, _))
404 .WillOnce(testing::Return(true));
Yves Gerey665174f2018-06-19 15:03:05 +0200405 EXPECT_EQ(kMinPaddingSize, rtp_sender_->TimeToSendPadding(kMinPaddingSize - 5,
406 PacedPacketInfo()));
Danil Chapovalovb3179c72018-03-22 10:13:07 +0100407}
408
minyue3a407ee2017-04-03 01:10:33 -0700409TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberSetPaddingTimestamps) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200410 constexpr size_t kPaddingSize = 100;
411 auto packet = rtp_sender_->AllocatePacket();
412 ASSERT_TRUE(packet);
413 packet->SetMarker(true);
414 packet->SetTimestamp(kTimestamp);
415
416 ASSERT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
philipel8aadd502017-02-23 02:56:13 -0800417 ASSERT_TRUE(rtp_sender_->TimeToSendPadding(kPaddingSize, PacedPacketInfo()));
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200418
419 ASSERT_EQ(1u, transport_.sent_packets_.size());
danilchap12ba1862016-10-26 02:41:55 -0700420 // Verify padding packet timestamp.
421 EXPECT_EQ(kTimestamp, transport_.last_sent_packet().Timestamp());
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200422}
423
minyue3a407ee2017-04-03 01:10:33 -0700424TEST_P(RtpSenderTestWithoutPacer,
425 TransportFeedbackObserverGetsCorrectByteCount) {
426 constexpr int kRtpOverheadBytesPerPacket = 12 + 8;
427 testing::NiceMock<MockOverheadObserver> mock_overhead_observer;
428 rtp_sender_.reset(new RTPSender(
429 false, &fake_clock_, &transport_, nullptr, nullptr, &seq_num_allocator_,
430 &feedback_observer_, nullptr, nullptr, nullptr, &mock_rtc_event_log_,
Erik Språng7b52f102018-02-07 14:37:37 +0100431 nullptr, &retransmission_rate_limiter_, &mock_overhead_observer, false));
minyue3a407ee2017-04-03 01:10:33 -0700432 rtp_sender_->SetSSRC(kSsrc);
433 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
434 kRtpExtensionTransportSequenceNumber,
435 kTransportSequenceNumberExtensionId));
436 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
437 .WillOnce(testing::Return(kTransportSequenceNumber));
438
439 const size_t expected_bytes =
440 GetParam() ? sizeof(kPayloadData) + kGenericHeaderLength +
441 kRtpOverheadBytesPerPacket
442 : sizeof(kPayloadData) + kGenericHeaderLength;
443
444 EXPECT_CALL(feedback_observer_,
445 AddPacket(rtp_sender_->SSRC(), kTransportSequenceNumber,
446 expected_bytes, PacedPacketInfo()))
447 .Times(1);
448 EXPECT_CALL(mock_overhead_observer,
449 OnOverheadChanged(kRtpOverheadBytesPerPacket))
450 .Times(1);
451 SendGenericPayload();
452}
453
454TEST_P(RtpSenderTestWithoutPacer, SendsPacketsWithTransportSequenceNumber) {
Stefan Holmera246cfb2016-08-23 17:51:42 +0200455 rtp_sender_.reset(new RTPSender(
brandtrdbdb3f12016-11-10 05:04:48 -0800456 false, &fake_clock_, &transport_, nullptr, nullptr, &seq_num_allocator_,
457 &feedback_observer_, nullptr, nullptr, nullptr, &mock_rtc_event_log_,
Erik Språng7b52f102018-02-07 14:37:37 +0100458 &send_packet_observer_, &retransmission_rate_limiter_, nullptr, false));
nisse7d59f6b2017-02-21 03:40:24 -0800459 rtp_sender_->SetSSRC(kSsrc);
Stefan Holmerf5dca482016-01-27 12:58:51 +0100460 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
461 kRtpExtensionTransportSequenceNumber,
462 kTransportSequenceNumberExtensionId));
463
Stefan Holmerf5dca482016-01-27 12:58:51 +0100464 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
465 .WillOnce(testing::Return(kTransportSequenceNumber));
asapersson35151f32016-05-02 23:44:01 -0700466 EXPECT_CALL(send_packet_observer_,
467 OnSendPacket(kTransportSequenceNumber, _, _))
468 .Times(1);
minyue3a407ee2017-04-03 01:10:33 -0700469
470 EXPECT_CALL(feedback_observer_,
471 AddPacket(rtp_sender_->SSRC(), kTransportSequenceNumber, _,
472 PacedPacketInfo()))
Stefan Holmera246cfb2016-08-23 17:51:42 +0200473 .Times(1);
asapersson35151f32016-05-02 23:44:01 -0700474
475 SendGenericPayload();
Stefan Holmerf5dca482016-01-27 12:58:51 +0100476
danilchap12ba1862016-10-26 02:41:55 -0700477 const auto& packet = transport_.last_sent_packet();
478 uint16_t transport_seq_no;
479 ASSERT_TRUE(packet.GetExtension<TransportSequenceNumber>(&transport_seq_no));
480 EXPECT_EQ(kTransportSequenceNumber, transport_seq_no);
Petter Strandmark26bc6692018-05-29 08:43:35 +0200481 EXPECT_EQ(transport_.last_options_.packet_id, transport_seq_no);
482}
483
484TEST_P(RtpSenderTestWithoutPacer, PacketOptionsNoRetransmission) {
485 rtp_sender_.reset(new RTPSender(
486 false, &fake_clock_, &transport_, nullptr, nullptr, &seq_num_allocator_,
487 &feedback_observer_, nullptr, nullptr, nullptr, &mock_rtc_event_log_,
488 &send_packet_observer_, &retransmission_rate_limiter_, nullptr, false));
489 rtp_sender_->SetSSRC(kSsrc);
490
491 SendGenericPayload();
492
493 EXPECT_FALSE(transport_.last_options_.is_retransmit);
Stefan Holmerf5dca482016-01-27 12:58:51 +0100494}
495
minyue3a407ee2017-04-03 01:10:33 -0700496TEST_P(RtpSenderTestWithoutPacer, NoAllocationIfNotRegistered) {
stefana23fc622016-07-28 07:56:38 -0700497 SendGenericPayload();
498}
asapersson35151f32016-05-02 23:44:01 -0700499
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200500TEST_P(RtpSenderTestWithoutPacer, OnSendSideDelayUpdated) {
501 testing::StrictMock<MockSendSideDelayObserver> send_side_delay_observer_;
502 rtp_sender_.reset(
503 new RTPSender(false, &fake_clock_, &transport_, nullptr, nullptr, nullptr,
504 nullptr, nullptr, nullptr, &send_side_delay_observer_,
505 &mock_rtc_event_log_, nullptr, nullptr, nullptr, false));
506 rtp_sender_->SetSSRC(kSsrc);
507
508 const uint8_t kPayloadType = 127;
509 const uint32_t kCaptureTimeMsToRtpTimestamp = 90; // 90 kHz clock
510 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
511 RTPVideoHeader video_header;
512 EXPECT_EQ(0, rtp_sender_->RegisterPayload(payload_name, kPayloadType,
513 1000 * kCaptureTimeMsToRtpTimestamp,
514 0, 1500));
515
516 // Send packet with 10 ms send-side delay. The average and max should be 10
517 // ms.
518 EXPECT_CALL(send_side_delay_observer_, SendSideDelayUpdated(10, 10, kSsrc))
519 .Times(1);
520 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
521 fake_clock_.AdvanceTimeMilliseconds(10);
522 EXPECT_TRUE(rtp_sender_->SendOutgoingData(
523 kVideoFrameKey, kPayloadType,
524 capture_time_ms * kCaptureTimeMsToRtpTimestamp, capture_time_ms,
525 kPayloadData, sizeof(kPayloadData), nullptr, &video_header, nullptr,
526 kDefaultExpectedRetransmissionTimeMs));
527
528 // Send another packet with 20 ms delay. The average
529 // and max should be 15 and 20 ms respectively.
530 EXPECT_CALL(send_side_delay_observer_, SendSideDelayUpdated(15, 20, kSsrc))
531 .Times(1);
532 fake_clock_.AdvanceTimeMilliseconds(10);
533 EXPECT_TRUE(rtp_sender_->SendOutgoingData(
534 kVideoFrameKey, kPayloadType,
535 capture_time_ms * kCaptureTimeMsToRtpTimestamp, capture_time_ms,
536 kPayloadData, sizeof(kPayloadData), nullptr, &video_header, nullptr,
537 kDefaultExpectedRetransmissionTimeMs));
538
539 // Send another packet at the same time, which replaces the last packet.
540 // Since this packet has 0 ms delay, the average is now 5 ms and max is 10 ms.
541 // TODO(terelius): Is is not clear that this is the right behavior.
542 EXPECT_CALL(send_side_delay_observer_, SendSideDelayUpdated(5, 10, kSsrc))
543 .Times(1);
544 capture_time_ms = fake_clock_.TimeInMilliseconds();
545 EXPECT_TRUE(rtp_sender_->SendOutgoingData(
546 kVideoFrameKey, kPayloadType,
547 capture_time_ms * kCaptureTimeMsToRtpTimestamp, capture_time_ms,
548 kPayloadData, sizeof(kPayloadData), nullptr, &video_header, nullptr,
549 kDefaultExpectedRetransmissionTimeMs));
550
551 // Send a packet 1 second later. The earlier packets should have timed
552 // out, so both max and average should be the delay of this packet.
553 fake_clock_.AdvanceTimeMilliseconds(1000);
554 capture_time_ms = fake_clock_.TimeInMilliseconds();
555 fake_clock_.AdvanceTimeMilliseconds(1);
556 EXPECT_CALL(send_side_delay_observer_, SendSideDelayUpdated(1, 1, kSsrc))
557 .Times(1);
558 EXPECT_TRUE(rtp_sender_->SendOutgoingData(
559 kVideoFrameKey, kPayloadType,
560 capture_time_ms * kCaptureTimeMsToRtpTimestamp, capture_time_ms,
561 kPayloadData, sizeof(kPayloadData), nullptr, &video_header, nullptr,
562 kDefaultExpectedRetransmissionTimeMs));
563}
564
minyue3a407ee2017-04-03 01:10:33 -0700565TEST_P(RtpSenderTestWithoutPacer, OnSendPacketUpdated) {
stefana23fc622016-07-28 07:56:38 -0700566 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
567 kRtpExtensionTransportSequenceNumber,
568 kTransportSequenceNumberExtensionId));
asapersson35151f32016-05-02 23:44:01 -0700569 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
570 .WillOnce(testing::Return(kTransportSequenceNumber));
571 EXPECT_CALL(send_packet_observer_,
572 OnSendPacket(kTransportSequenceNumber, _, _))
573 .Times(1);
574
575 SendGenericPayload();
576}
577
minyue3a407ee2017-04-03 01:10:33 -0700578TEST_P(RtpSenderTest, SendsPacketsWithTransportSequenceNumber) {
michaelt4da30442016-11-17 01:38:43 -0800579 rtp_sender_.reset(new RTPSender(
580 false, &fake_clock_, &transport_, &mock_paced_sender_, nullptr,
581 &seq_num_allocator_, &feedback_observer_, nullptr, nullptr, nullptr,
582 &mock_rtc_event_log_, &send_packet_observer_,
Erik Språng7b52f102018-02-07 14:37:37 +0100583 &retransmission_rate_limiter_, nullptr, false));
brandtr9dfff292016-11-14 05:14:50 -0800584 rtp_sender_->SetSequenceNumber(kSeqNum);
585 rtp_sender_->SetSSRC(kSsrc);
Stefan Holmera246cfb2016-08-23 17:51:42 +0200586 rtp_sender_->SetStorePacketsStatus(true, 10);
587 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
588 kRtpExtensionTransportSequenceNumber,
589 kTransportSequenceNumberExtensionId));
590
brandtr9dfff292016-11-14 05:14:50 -0800591 EXPECT_CALL(mock_paced_sender_, InsertPacket(_, kSsrc, kSeqNum, _, _, _));
Stefan Holmera246cfb2016-08-23 17:51:42 +0200592 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
593 .WillOnce(testing::Return(kTransportSequenceNumber));
594 EXPECT_CALL(send_packet_observer_,
595 OnSendPacket(kTransportSequenceNumber, _, _))
596 .Times(1);
minyue3a407ee2017-04-03 01:10:33 -0700597 EXPECT_CALL(feedback_observer_,
598 AddPacket(rtp_sender_->SSRC(), kTransportSequenceNumber, _,
599 PacedPacketInfo()))
Stefan Holmera246cfb2016-08-23 17:51:42 +0200600 .Times(1);
601
602 SendGenericPayload();
philipel8aadd502017-02-23 02:56:13 -0800603 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum,
604 fake_clock_.TimeInMilliseconds(), false,
605 PacedPacketInfo());
Stefan Holmera246cfb2016-08-23 17:51:42 +0200606
danilchap12ba1862016-10-26 02:41:55 -0700607 const auto& packet = transport_.last_sent_packet();
608 uint16_t transport_seq_no;
609 EXPECT_TRUE(packet.GetExtension<TransportSequenceNumber>(&transport_seq_no));
610 EXPECT_EQ(kTransportSequenceNumber, transport_seq_no);
Petter Strandmark26bc6692018-05-29 08:43:35 +0200611 EXPECT_EQ(transport_.last_options_.packet_id, transport_seq_no);
Stefan Holmera246cfb2016-08-23 17:51:42 +0200612}
613
Erik Språng7b52f102018-02-07 14:37:37 +0100614TEST_P(RtpSenderTest, WritesPacerExitToTimingExtension) {
ilnik04f4d122017-06-19 07:18:55 -0700615 rtp_sender_->SetStorePacketsStatus(true, 10);
616 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
617 kRtpExtensionVideoTiming, kVideoTimingExtensionId));
618 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
619 auto packet = rtp_sender_->AllocatePacket();
620 packet->SetPayloadType(kPayload);
621 packet->SetMarker(true);
622 packet->SetTimestamp(kTimestamp);
623 packet->set_capture_time_ms(capture_time_ms);
ilnik2edc6842017-07-06 03:06:50 -0700624 const VideoSendTiming kVideoTiming = {0u, 0u, 0u, 0u, 0u, 0u, true};
ilnik04f4d122017-06-19 07:18:55 -0700625 packet->SetExtension<VideoTimingExtension>(kVideoTiming);
626 EXPECT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
627 size_t packet_size = packet->size();
ilnik04f4d122017-06-19 07:18:55 -0700628
629 const int kStoredTimeInMs = 100;
Erik Språng7b52f102018-02-07 14:37:37 +0100630 {
631 EXPECT_CALL(
632 mock_paced_sender_,
633 InsertPacket(RtpPacketSender::kNormalPriority, kSsrc, _, _, _, _));
634 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
635 kAllowRetransmission,
636 RtpPacketSender::kNormalPriority));
637 }
ilnik04f4d122017-06-19 07:18:55 -0700638 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
Erik Språng7b52f102018-02-07 14:37:37 +0100639 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum, capture_time_ms, false,
640 PacedPacketInfo());
ilnik04f4d122017-06-19 07:18:55 -0700641 EXPECT_EQ(1, transport_.packets_sent());
642 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
643
danilchapce251812017-09-11 12:24:41 -0700644 VideoSendTiming video_timing;
645 EXPECT_TRUE(transport_.last_sent_packet().GetExtension<VideoTimingExtension>(
646 &video_timing));
647 EXPECT_EQ(kStoredTimeInMs, video_timing.pacer_exit_delta_ms);
Erik Språng7b52f102018-02-07 14:37:37 +0100648}
ilnik04f4d122017-06-19 07:18:55 -0700649
Erik Språng7b52f102018-02-07 14:37:37 +0100650TEST_P(RtpSenderTest, WritesNetwork2ToTimingExtension) {
651 SetUpRtpSender(true, true);
652 rtp_sender_->SetStorePacketsStatus(true, 10);
653 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
654 kRtpExtensionVideoTiming, kVideoTimingExtensionId));
655 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
656 auto packet = rtp_sender_->AllocatePacket();
657 packet->SetPayloadType(kPayload);
658 packet->SetMarker(true);
659 packet->SetTimestamp(kTimestamp);
660 packet->set_capture_time_ms(capture_time_ms);
661 const uint16_t kPacerExitMs = 1234u;
662 const VideoSendTiming kVideoTiming = {0u, 0u, 0u, kPacerExitMs, 0u, 0u, true};
663 packet->SetExtension<VideoTimingExtension>(kVideoTiming);
664 EXPECT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
665 size_t packet_size = packet->size();
666
667 const int kStoredTimeInMs = 100;
668 {
669 EXPECT_CALL(
670 mock_paced_sender_,
671 InsertPacket(RtpPacketSender::kNormalPriority, kSsrc, _, _, _, _));
672 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
673 kAllowRetransmission,
674 RtpPacketSender::kNormalPriority));
675 }
ilnik04f4d122017-06-19 07:18:55 -0700676 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
677 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum, capture_time_ms, false,
678 PacedPacketInfo());
Erik Språng7b52f102018-02-07 14:37:37 +0100679 EXPECT_EQ(1, transport_.packets_sent());
ilnik04f4d122017-06-19 07:18:55 -0700680 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
681
Erik Språng7b52f102018-02-07 14:37:37 +0100682 VideoSendTiming video_timing;
danilchapce251812017-09-11 12:24:41 -0700683 EXPECT_TRUE(transport_.last_sent_packet().GetExtension<VideoTimingExtension>(
684 &video_timing));
Erik Språng7b52f102018-02-07 14:37:37 +0100685 EXPECT_EQ(kStoredTimeInMs, video_timing.network2_timestamp_delta_ms);
686 EXPECT_EQ(kPacerExitMs, video_timing.pacer_exit_delta_ms);
ilnik04f4d122017-06-19 07:18:55 -0700687}
688
minyue3a407ee2017-04-03 01:10:33 -0700689TEST_P(RtpSenderTest, TrafficSmoothingWithExtensions) {
Peter Boströme23e7372015-10-08 11:44:14 +0200690 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kNormalPriority,
brandtr9dfff292016-11-14 05:14:50 -0800691 kSsrc, kSeqNum, _, _, _));
Elad Alon4a87e1c2017-10-03 16:11:34 +0200692 EXPECT_CALL(mock_rtc_event_log_,
693 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)));
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000694
pwestin@webrtc.orgc66e8b32012-11-07 17:01:04 +0000695 rtp_sender_->SetStorePacketsStatus(true, 10);
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000696 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
danilchap162abd32015-12-10 02:39:40 -0800697 kRtpExtensionTransmissionTimeOffset,
698 kTransmissionTimeOffsetExtensionId));
699 EXPECT_EQ(
700 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
701 kAbsoluteSendTimeExtensionId));
stefan@webrtc.org8ccb9f92013-06-19 14:13:42 +0000702 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
danilchapb6f1fb52016-10-19 06:11:39 -0700703 auto packet =
704 BuildRtpPacket(kPayload, kMarkerBit, kTimestamp, capture_time_ms);
705 size_t packet_size = packet->size();
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000706
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000707 // Packet should be stored in a send bucket.
danilchapb6f1fb52016-10-19 06:11:39 -0700708 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
709 kAllowRetransmission,
Sergey Ulanov525df3f2016-08-02 17:46:41 -0700710 RtpPacketSender::kNormalPriority));
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000711
danilchap12ba1862016-10-26 02:41:55 -0700712 EXPECT_EQ(0, transport_.packets_sent());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000713
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000714 const int kStoredTimeInMs = 100;
stefan@webrtc.orga678a3b2013-01-21 07:42:11 +0000715 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000716
brandtr9dfff292016-11-14 05:14:50 -0800717 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum, capture_time_ms, false,
philipel8aadd502017-02-23 02:56:13 -0800718 PacedPacketInfo());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000719
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000720 // Process send bucket. Packet should now be sent.
danilchap12ba1862016-10-26 02:41:55 -0700721 EXPECT_EQ(1, transport_.packets_sent());
722 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
723
stefan@webrtc.orga5cb98c2013-05-29 12:12:51 +0000724 webrtc::RTPHeader rtp_header;
danilchap12ba1862016-10-26 02:41:55 -0700725 transport_.last_sent_packet().GetHeader(&rtp_header);
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000726
727 // Verify transmission time offset.
728 EXPECT_EQ(kStoredTimeInMs * 90, rtp_header.extension.transmissionTimeOffset);
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000729 uint64_t expected_send_time =
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000730 ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds());
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000731 EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime);
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000732}
733
minyue3a407ee2017-04-03 01:10:33 -0700734TEST_P(RtpSenderTest, TrafficSmoothingRetransmits) {
Peter Boströme23e7372015-10-08 11:44:14 +0200735 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kNormalPriority,
brandtr9dfff292016-11-14 05:14:50 -0800736 kSsrc, kSeqNum, _, _, _));
Elad Alon4a87e1c2017-10-03 16:11:34 +0200737 EXPECT_CALL(mock_rtc_event_log_,
738 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)));
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000739
740 rtp_sender_->SetStorePacketsStatus(true, 10);
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000741 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
danilchap162abd32015-12-10 02:39:40 -0800742 kRtpExtensionTransmissionTimeOffset,
743 kTransmissionTimeOffsetExtensionId));
744 EXPECT_EQ(
745 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
746 kAbsoluteSendTimeExtensionId));
stefan@webrtc.org8ccb9f92013-06-19 14:13:42 +0000747 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
danilchapb6f1fb52016-10-19 06:11:39 -0700748 auto packet =
749 BuildRtpPacket(kPayload, kMarkerBit, kTimestamp, capture_time_ms);
750 size_t packet_size = packet->size();
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000751
752 // Packet should be stored in a send bucket.
danilchapb6f1fb52016-10-19 06:11:39 -0700753 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
754 kAllowRetransmission,
Sergey Ulanov525df3f2016-08-02 17:46:41 -0700755 RtpPacketSender::kNormalPriority));
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000756
danilchap12ba1862016-10-26 02:41:55 -0700757 EXPECT_EQ(0, transport_.packets_sent());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000758
terelius5d332ac2016-01-14 14:37:39 -0800759 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kNormalPriority,
brandtr9dfff292016-11-14 05:14:50 -0800760 kSsrc, kSeqNum, _, _, _));
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000761
762 const int kStoredTimeInMs = 100;
763 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
764
danilchapb6f1fb52016-10-19 06:11:39 -0700765 EXPECT_EQ(static_cast<int>(packet_size), rtp_sender_->ReSendPacket(kSeqNum));
danilchap12ba1862016-10-26 02:41:55 -0700766 EXPECT_EQ(0, transport_.packets_sent());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000767
brandtr9dfff292016-11-14 05:14:50 -0800768 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum, capture_time_ms, false,
philipel8aadd502017-02-23 02:56:13 -0800769 PacedPacketInfo());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000770
771 // Process send bucket. Packet should now be sent.
danilchap12ba1862016-10-26 02:41:55 -0700772 EXPECT_EQ(1, transport_.packets_sent());
773 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000774
stefan@webrtc.orga5cb98c2013-05-29 12:12:51 +0000775 webrtc::RTPHeader rtp_header;
danilchap12ba1862016-10-26 02:41:55 -0700776 transport_.last_sent_packet().GetHeader(&rtp_header);
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000777
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000778 // Verify transmission time offset.
779 EXPECT_EQ(kStoredTimeInMs * 90, rtp_header.extension.transmissionTimeOffset);
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000780 uint64_t expected_send_time =
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000781 ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds());
782 EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime);
783}
784
785// This test sends 1 regular video packet, then 4 padding packets, and then
786// 1 more regular packet.
minyue3a407ee2017-04-03 01:10:33 -0700787TEST_P(RtpSenderTest, SendPadding) {
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000788 // Make all (non-padding) packets go to send queue.
terelius5d332ac2016-01-14 14:37:39 -0800789 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kNormalPriority,
brandtr9dfff292016-11-14 05:14:50 -0800790 kSsrc, kSeqNum, _, _, _));
Elad Alon4a87e1c2017-10-03 16:11:34 +0200791 EXPECT_CALL(mock_rtc_event_log_,
792 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
793 .Times(1 + 4 + 1);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000794
795 uint16_t seq_num = kSeqNum;
796 uint32_t timestamp = kTimestamp;
797 rtp_sender_->SetStorePacketsStatus(true, 10);
pkasting@chromium.org4591fbd2014-11-20 22:28:14 +0000798 size_t rtp_header_len = kRtpHeaderSize;
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000799 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
danilchap162abd32015-12-10 02:39:40 -0800800 kRtpExtensionTransmissionTimeOffset,
801 kTransmissionTimeOffsetExtensionId));
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000802 rtp_header_len += 4; // 4 bytes extension.
danilchap162abd32015-12-10 02:39:40 -0800803 EXPECT_EQ(
804 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
805 kAbsoluteSendTimeExtensionId));
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000806 rtp_header_len += 4; // 4 bytes extension.
807 rtp_header_len += 4; // 4 extra bytes common to all extension headers.
808
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000809 webrtc::RTPHeader rtp_header;
810
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000811 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
danilchapb6f1fb52016-10-19 06:11:39 -0700812 auto packet =
813 BuildRtpPacket(kPayload, kMarkerBit, timestamp, capture_time_ms);
Stefan Holmer586b19b2015-09-18 11:14:31 +0200814 const uint32_t media_packet_timestamp = timestamp;
danilchapb6f1fb52016-10-19 06:11:39 -0700815 size_t packet_size = packet->size();
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000816
817 // Packet should be stored in a send bucket.
danilchapb6f1fb52016-10-19 06:11:39 -0700818 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
819 kAllowRetransmission,
Sergey Ulanov525df3f2016-08-02 17:46:41 -0700820 RtpPacketSender::kNormalPriority));
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000821
822 int total_packets_sent = 0;
danilchap12ba1862016-10-26 02:41:55 -0700823 EXPECT_EQ(total_packets_sent, transport_.packets_sent());
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000824
825 const int kStoredTimeInMs = 100;
826 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
brandtr9dfff292016-11-14 05:14:50 -0800827 rtp_sender_->TimeToSendPacket(kSsrc, seq_num++, capture_time_ms, false,
philipel8aadd502017-02-23 02:56:13 -0800828 PacedPacketInfo());
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000829 // Packet should now be sent. This test doesn't verify the regular video
830 // packet, since it is tested in another test.
danilchap12ba1862016-10-26 02:41:55 -0700831 EXPECT_EQ(++total_packets_sent, transport_.packets_sent());
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000832 timestamp += 90 * kStoredTimeInMs;
833
834 // Send padding 4 times, waiting 50 ms between each.
835 for (int i = 0; i < 4; ++i) {
836 const int kPaddingPeriodMs = 50;
pkasting@chromium.org4591fbd2014-11-20 22:28:14 +0000837 const size_t kPaddingBytes = 100;
838 const size_t kMaxPaddingLength = 224; // Value taken from rtp_sender.cc.
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000839 // Padding will be forced to full packets.
philipelc7bf32a2017-02-17 03:59:43 -0800840 EXPECT_EQ(kMaxPaddingLength,
philipel8aadd502017-02-23 02:56:13 -0800841 rtp_sender_->TimeToSendPadding(kPaddingBytes, PacedPacketInfo()));
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000842
843 // Process send bucket. Padding should now be sent.
danilchap12ba1862016-10-26 02:41:55 -0700844 EXPECT_EQ(++total_packets_sent, transport_.packets_sent());
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000845 EXPECT_EQ(kMaxPaddingLength + rtp_header_len,
danilchap12ba1862016-10-26 02:41:55 -0700846 transport_.last_sent_packet().size());
847
848 transport_.last_sent_packet().GetHeader(&rtp_header);
pbosbd2522a2015-07-01 05:35:53 -0700849 EXPECT_EQ(kMaxPaddingLength, rtp_header.paddingLength);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000850
Stefan Holmer586b19b2015-09-18 11:14:31 +0200851 // Verify sequence number and timestamp. The timestamp should be the same
852 // as the last media packet.
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000853 EXPECT_EQ(seq_num++, rtp_header.sequenceNumber);
Stefan Holmer586b19b2015-09-18 11:14:31 +0200854 EXPECT_EQ(media_packet_timestamp, rtp_header.timestamp);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000855 // Verify transmission time offset.
Stefan Holmer586b19b2015-09-18 11:14:31 +0200856 int offset = timestamp - media_packet_timestamp;
857 EXPECT_EQ(offset, rtp_header.extension.transmissionTimeOffset);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000858 uint64_t expected_send_time =
859 ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds());
860 EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime);
861 fake_clock_.AdvanceTimeMilliseconds(kPaddingPeriodMs);
862 timestamp += 90 * kPaddingPeriodMs;
863 }
864
865 // Send a regular video packet again.
866 capture_time_ms = fake_clock_.TimeInMilliseconds();
danilchapb6f1fb52016-10-19 06:11:39 -0700867 packet = BuildRtpPacket(kPayload, kMarkerBit, timestamp, capture_time_ms);
868 packet_size = packet->size();
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000869
brandtr9dfff292016-11-14 05:14:50 -0800870 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kNormalPriority,
871 kSsrc, seq_num, _, _, _));
terelius5d332ac2016-01-14 14:37:39 -0800872
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000873 // Packet should be stored in a send bucket.
danilchapb6f1fb52016-10-19 06:11:39 -0700874 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
875 kAllowRetransmission,
Sergey Ulanov525df3f2016-08-02 17:46:41 -0700876 RtpPacketSender::kNormalPriority));
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000877
brandtr9dfff292016-11-14 05:14:50 -0800878 rtp_sender_->TimeToSendPacket(kSsrc, seq_num, capture_time_ms, false,
philipel8aadd502017-02-23 02:56:13 -0800879 PacedPacketInfo());
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000880 // Process send bucket.
danilchap12ba1862016-10-26 02:41:55 -0700881 EXPECT_EQ(++total_packets_sent, transport_.packets_sent());
882 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
883 transport_.last_sent_packet().GetHeader(&rtp_header);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000884
885 // Verify sequence number and timestamp.
886 EXPECT_EQ(seq_num, rtp_header.sequenceNumber);
887 EXPECT_EQ(timestamp, rtp_header.timestamp);
888 // Verify transmission time offset. This packet is sent without delay.
889 EXPECT_EQ(0, rtp_header.extension.transmissionTimeOffset);
890 uint64_t expected_send_time =
891 ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds());
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000892 EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime);
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000893}
pbos@webrtc.org8911ce42013-03-18 16:39:03 +0000894
minyue3a407ee2017-04-03 01:10:33 -0700895TEST_P(RtpSenderTest, OnSendPacketUpdated) {
stefana23fc622016-07-28 07:56:38 -0700896 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
897 kRtpExtensionTransportSequenceNumber,
898 kTransportSequenceNumberExtensionId));
asapersson35151f32016-05-02 23:44:01 -0700899 rtp_sender_->SetStorePacketsStatus(true, 10);
900
901 EXPECT_CALL(send_packet_observer_,
902 OnSendPacket(kTransportSequenceNumber, _, _))
903 .Times(1);
904 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
905 .WillOnce(testing::Return(kTransportSequenceNumber));
brandtr9dfff292016-11-14 05:14:50 -0800906 EXPECT_CALL(mock_paced_sender_, InsertPacket(_, kSsrc, kSeqNum, _, _, _))
907 .Times(1);
asapersson35151f32016-05-02 23:44:01 -0700908
909 SendGenericPayload(); // Packet passed to pacer.
910 const bool kIsRetransmit = false;
brandtr9dfff292016-11-14 05:14:50 -0800911 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum,
912 fake_clock_.TimeInMilliseconds(), kIsRetransmit,
philipel8aadd502017-02-23 02:56:13 -0800913 PacedPacketInfo());
danilchap12ba1862016-10-26 02:41:55 -0700914 EXPECT_EQ(1, transport_.packets_sent());
asapersson35151f32016-05-02 23:44:01 -0700915}
916
minyue3a407ee2017-04-03 01:10:33 -0700917TEST_P(RtpSenderTest, OnSendPacketNotUpdatedForRetransmits) {
stefana23fc622016-07-28 07:56:38 -0700918 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
919 kRtpExtensionTransportSequenceNumber,
920 kTransportSequenceNumberExtensionId));
asapersson35151f32016-05-02 23:44:01 -0700921 rtp_sender_->SetStorePacketsStatus(true, 10);
922
923 EXPECT_CALL(send_packet_observer_, OnSendPacket(_, _, _)).Times(0);
924 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
925 .WillOnce(testing::Return(kTransportSequenceNumber));
brandtr9dfff292016-11-14 05:14:50 -0800926 EXPECT_CALL(mock_paced_sender_, InsertPacket(_, kSsrc, kSeqNum, _, _, _))
927 .Times(1);
asapersson35151f32016-05-02 23:44:01 -0700928
929 SendGenericPayload(); // Packet passed to pacer.
930 const bool kIsRetransmit = true;
brandtr9dfff292016-11-14 05:14:50 -0800931 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum,
932 fake_clock_.TimeInMilliseconds(), kIsRetransmit,
philipel8aadd502017-02-23 02:56:13 -0800933 PacedPacketInfo());
danilchap12ba1862016-10-26 02:41:55 -0700934 EXPECT_EQ(1, transport_.packets_sent());
Petter Strandmark26bc6692018-05-29 08:43:35 +0200935 EXPECT_TRUE(transport_.last_options_.is_retransmit);
asapersson35151f32016-05-02 23:44:01 -0700936}
937
minyue3a407ee2017-04-03 01:10:33 -0700938TEST_P(RtpSenderTest, OnSendPacketNotUpdatedWithoutSeqNumAllocator) {
asapersson35151f32016-05-02 23:44:01 -0700939 rtp_sender_.reset(new RTPSender(
brandtrdbdb3f12016-11-10 05:04:48 -0800940 false, &fake_clock_, &transport_, &mock_paced_sender_, nullptr,
asapersson35151f32016-05-02 23:44:01 -0700941 nullptr /* TransportSequenceNumberAllocator */, nullptr, nullptr, nullptr,
michaelt4da30442016-11-17 01:38:43 -0800942 nullptr, nullptr, &send_packet_observer_, &retransmission_rate_limiter_,
Erik Språng7b52f102018-02-07 14:37:37 +0100943 nullptr, false));
brandtr9dfff292016-11-14 05:14:50 -0800944 rtp_sender_->SetSequenceNumber(kSeqNum);
945 rtp_sender_->SetSSRC(kSsrc);
stefana23fc622016-07-28 07:56:38 -0700946 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
947 kRtpExtensionTransportSequenceNumber,
948 kTransportSequenceNumberExtensionId));
asapersson35151f32016-05-02 23:44:01 -0700949 rtp_sender_->SetSequenceNumber(kSeqNum);
950 rtp_sender_->SetStorePacketsStatus(true, 10);
951
952 EXPECT_CALL(send_packet_observer_, OnSendPacket(_, _, _)).Times(0);
brandtr9dfff292016-11-14 05:14:50 -0800953 EXPECT_CALL(mock_paced_sender_, InsertPacket(_, kSsrc, kSeqNum, _, _, _))
954 .Times(1);
asapersson35151f32016-05-02 23:44:01 -0700955
956 SendGenericPayload(); // Packet passed to pacer.
957 const bool kIsRetransmit = false;
brandtr9dfff292016-11-14 05:14:50 -0800958 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum,
959 fake_clock_.TimeInMilliseconds(), kIsRetransmit,
philipel8aadd502017-02-23 02:56:13 -0800960 PacedPacketInfo());
danilchap12ba1862016-10-26 02:41:55 -0700961 EXPECT_EQ(1, transport_.packets_sent());
asapersson35151f32016-05-02 23:44:01 -0700962}
963
minyue3a407ee2017-04-03 01:10:33 -0700964TEST_P(RtpSenderTest, SendRedundantPayloads) {
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000965 MockTransport transport;
terelius429c3452016-01-21 05:42:04 -0800966 rtp_sender_.reset(new RTPSender(
asapersson35151f32016-05-02 23:44:01 -0700967 false, &fake_clock_, &transport, &mock_paced_sender_, nullptr, nullptr,
brandtrdbdb3f12016-11-10 05:04:48 -0800968 nullptr, nullptr, nullptr, nullptr, &mock_rtc_event_log_, nullptr,
Erik Språng7b52f102018-02-07 14:37:37 +0100969 &retransmission_rate_limiter_, nullptr, false));
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000970 rtp_sender_->SetSequenceNumber(kSeqNum);
brandtr9dfff292016-11-14 05:14:50 -0800971 rtp_sender_->SetSSRC(kSsrc);
Shao Changbine62202f2015-04-21 20:24:50 +0800972 rtp_sender_->SetRtxPayloadType(kRtxPayload, kPayload);
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000973
974 uint16_t seq_num = kSeqNum;
975 rtp_sender_->SetStorePacketsStatus(true, 10);
wu@webrtc.orgebdb0e32014-03-06 23:49:08 +0000976 int32_t rtp_header_len = kRtpHeaderSize;
danilchap162abd32015-12-10 02:39:40 -0800977 EXPECT_EQ(
978 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
979 kAbsoluteSendTimeExtensionId));
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000980 rtp_header_len += 4; // 4 bytes extension.
981 rtp_header_len += 4; // 4 extra bytes common to all extension headers.
982
pbos@webrtc.org0b0c2412015-01-13 14:15:15 +0000983 rtp_sender_->SetRtxStatus(kRtxRetransmitted | kRtxRedundantPayloads);
stefan@webrtc.orgef927552014-06-05 08:25:29 +0000984 rtp_sender_->SetRtxSsrc(1234);
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000985
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000986 const size_t kNumPayloadSizes = 10;
danilchap162abd32015-12-10 02:39:40 -0800987 const size_t kPayloadSizes[kNumPayloadSizes] = {500, 550, 600, 650, 700,
988 750, 800, 850, 900, 950};
terelius5d332ac2016-01-14 14:37:39 -0800989 // Expect all packets go through the pacer.
990 EXPECT_CALL(mock_paced_sender_,
brandtr9dfff292016-11-14 05:14:50 -0800991 InsertPacket(RtpPacketSender::kNormalPriority, kSsrc, _, _, _, _))
terelius5d332ac2016-01-14 14:37:39 -0800992 .Times(kNumPayloadSizes);
Elad Alon4a87e1c2017-10-03 16:11:34 +0200993 EXPECT_CALL(mock_rtc_event_log_,
994 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
terelius429c3452016-01-21 05:42:04 -0800995 .Times(kNumPayloadSizes);
996
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000997 // Send 10 packets of increasing size.
998 for (size_t i = 0; i < kNumPayloadSizes; ++i) {
999 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
stefan1d8a5062015-10-02 03:39:33 -07001000 EXPECT_CALL(transport, SendRtp(_, _, _)).WillOnce(testing::Return(true));
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +00001001 SendPacket(capture_time_ms, kPayloadSizes[i]);
brandtr9dfff292016-11-14 05:14:50 -08001002 rtp_sender_->TimeToSendPacket(kSsrc, seq_num++, capture_time_ms, false,
philipel8aadd502017-02-23 02:56:13 -08001003 PacedPacketInfo());
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +00001004 fake_clock_.AdvanceTimeMilliseconds(33);
1005 }
terelius429c3452016-01-21 05:42:04 -08001006
Elad Alon4a87e1c2017-10-03 16:11:34 +02001007 EXPECT_CALL(mock_rtc_event_log_,
1008 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
terelius429c3452016-01-21 05:42:04 -08001009 .Times(::testing::AtLeast(4));
1010
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +00001011 // The amount of padding to send it too small to send a payload packet.
stefan1d8a5062015-10-02 03:39:33 -07001012 EXPECT_CALL(transport, SendRtp(_, kMaxPaddingSize + rtp_header_len, _))
pbos2d566682015-09-28 09:59:31 -07001013 .WillOnce(testing::Return(true));
philipela1ed0b32016-06-01 06:31:17 -07001014 EXPECT_EQ(kMaxPaddingSize,
philipel8aadd502017-02-23 02:56:13 -08001015 rtp_sender_->TimeToSendPadding(49, PacedPacketInfo()));
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +00001016
Petter Strandmark26bc6692018-05-29 08:43:35 +02001017 PacketOptions options;
Peter Boströmac547a62015-09-17 23:03:57 +02001018 EXPECT_CALL(transport,
stefan1d8a5062015-10-02 03:39:33 -07001019 SendRtp(_, kPayloadSizes[0] + rtp_header_len + kRtxHeaderSize, _))
Yves Gerey665174f2018-06-19 15:03:05 +02001020 .WillOnce(
1021 testing::DoAll(testing::SaveArg<2>(&options), testing::Return(true)));
philipela1ed0b32016-06-01 06:31:17 -07001022 EXPECT_EQ(kPayloadSizes[0],
philipel8aadd502017-02-23 02:56:13 -08001023 rtp_sender_->TimeToSendPadding(500, PacedPacketInfo()));
Petter Strandmark26bc6692018-05-29 08:43:35 +02001024 EXPECT_TRUE(options.is_retransmit);
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +00001025
Yves Gerey665174f2018-06-19 15:03:05 +02001026 EXPECT_CALL(transport, SendRtp(_,
1027 kPayloadSizes[kNumPayloadSizes - 1] +
1028 rtp_header_len + kRtxHeaderSize,
stefan1d8a5062015-10-02 03:39:33 -07001029 _))
pbos2d566682015-09-28 09:59:31 -07001030 .WillOnce(testing::Return(true));
Petter Strandmark26bc6692018-05-29 08:43:35 +02001031
1032 options.is_retransmit = false;
stefan1d8a5062015-10-02 03:39:33 -07001033 EXPECT_CALL(transport, SendRtp(_, kMaxPaddingSize + rtp_header_len, _))
Yves Gerey665174f2018-06-19 15:03:05 +02001034 .WillOnce(
1035 testing::DoAll(testing::SaveArg<2>(&options), testing::Return(true)));
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +00001036 EXPECT_EQ(kPayloadSizes[kNumPayloadSizes - 1] + kMaxPaddingSize,
philipel8aadd502017-02-23 02:56:13 -08001037 rtp_sender_->TimeToSendPadding(999, PacedPacketInfo()));
Petter Strandmark26bc6692018-05-29 08:43:35 +02001038 EXPECT_FALSE(options.is_retransmit);
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +00001039}
1040
minyue3a407ee2017-04-03 01:10:33 -07001041TEST_P(RtpSenderTestWithoutPacer, SendGenericVideo) {
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001042 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
1043 const uint8_t payload_type = 127;
1044 ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 90000,
1045 0, 1500));
1046 uint8_t payload[] = {47, 11, 32, 93, 89};
1047
1048 // Send keyframe
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001049 RTPVideoHeader video_header;
spranga8ae6f22017-09-04 07:23:56 -07001050 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
1051 kVideoFrameKey, payload_type, 1234, 4321, payload, sizeof(payload),
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001052 nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001053
danilchap96c15872016-11-21 01:35:29 -08001054 auto sent_payload = transport_.last_sent_packet().payload();
1055 uint8_t generic_header = sent_payload[0];
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001056 EXPECT_TRUE(generic_header & RtpFormatVideoGeneric::kKeyFrameBit);
1057 EXPECT_TRUE(generic_header & RtpFormatVideoGeneric::kFirstPacketBit);
danilchap96c15872016-11-21 01:35:29 -08001058 EXPECT_THAT(sent_payload.subview(1), ElementsAreArray(payload));
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001059
1060 // Send delta frame
1061 payload[0] = 13;
1062 payload[1] = 42;
1063 payload[4] = 13;
1064
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001065 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
1066 kVideoFrameDelta, payload_type, 1234, 4321, payload, sizeof(payload),
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001067 nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001068
danilchap96c15872016-11-21 01:35:29 -08001069 sent_payload = transport_.last_sent_packet().payload();
1070 generic_header = sent_payload[0];
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001071 EXPECT_FALSE(generic_header & RtpFormatVideoGeneric::kKeyFrameBit);
1072 EXPECT_TRUE(generic_header & RtpFormatVideoGeneric::kFirstPacketBit);
danilchap96c15872016-11-21 01:35:29 -08001073 EXPECT_THAT(sent_payload.subview(1), ElementsAreArray(payload));
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001074}
1075
minyue3a407ee2017-04-03 01:10:33 -07001076TEST_P(RtpSenderTest, SendFlexfecPackets) {
brandtrdbdb3f12016-11-10 05:04:48 -08001077 constexpr int kMediaPayloadType = 127;
1078 constexpr int kFlexfecPayloadType = 118;
1079 constexpr uint32_t kMediaSsrc = 1234;
1080 constexpr uint32_t kFlexfecSsrc = 5678;
Steve Antonf0482ea2018-04-09 13:33:52 -07001081 const char kNoMid[] = "";
brandtrdbdb3f12016-11-10 05:04:48 -08001082 const std::vector<RtpExtension> kNoRtpExtensions;
erikvarga27883732017-05-17 05:08:38 -07001083 const std::vector<RtpExtensionSize> kNoRtpExtensionSizes;
brandtrdbdb3f12016-11-10 05:04:48 -08001084 FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexfecSsrc, kMediaSsrc,
Steve Antonf0482ea2018-04-09 13:33:52 -07001085 kNoMid, kNoRtpExtensions, kNoRtpExtensionSizes,
brandtr48d21a22017-05-30 02:32:12 -07001086 nullptr /* rtp_state */, &fake_clock_);
brandtrdbdb3f12016-11-10 05:04:48 -08001087
1088 // Reset |rtp_sender_| to use FlexFEC.
michaelt4da30442016-11-17 01:38:43 -08001089 rtp_sender_.reset(new RTPSender(
1090 false, &fake_clock_, &transport_, &mock_paced_sender_, &flexfec_sender,
1091 &seq_num_allocator_, nullptr, nullptr, nullptr, nullptr,
1092 &mock_rtc_event_log_, &send_packet_observer_,
Erik Språng7b52f102018-02-07 14:37:37 +01001093 &retransmission_rate_limiter_, nullptr, false));
brandtrdbdb3f12016-11-10 05:04:48 -08001094 rtp_sender_->SetSSRC(kMediaSsrc);
1095 rtp_sender_->SetSequenceNumber(kSeqNum);
brandtrdbdb3f12016-11-10 05:04:48 -08001096 rtp_sender_->SetStorePacketsStatus(true, 10);
1097
1098 // Parameters selected to generate a single FEC packet per media packet.
1099 FecProtectionParams params;
1100 params.fec_rate = 15;
1101 params.max_fec_frames = 1;
1102 params.fec_mask_type = kFecMaskRandom;
1103 rtp_sender_->SetFecParameters(params, params);
1104
brandtr9dfff292016-11-14 05:14:50 -08001105 EXPECT_CALL(mock_paced_sender_,
1106 InsertPacket(RtpPacketSender::kLowPriority, kMediaSsrc, kSeqNum,
1107 _, _, false));
1108 uint16_t flexfec_seq_num;
brandtrdbdb3f12016-11-10 05:04:48 -08001109 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kLowPriority,
brandtr9dfff292016-11-14 05:14:50 -08001110 kFlexfecSsrc, _, _, _, false))
1111 .WillOnce(testing::SaveArg<2>(&flexfec_seq_num));
brandtrdbdb3f12016-11-10 05:04:48 -08001112 SendGenericPayload();
Elad Alon4a87e1c2017-10-03 16:11:34 +02001113 EXPECT_CALL(mock_rtc_event_log_,
1114 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
1115 .Times(2);
philipel8aadd502017-02-23 02:56:13 -08001116 EXPECT_TRUE(rtp_sender_->TimeToSendPacket(kMediaSsrc, kSeqNum,
1117 fake_clock_.TimeInMilliseconds(),
1118 false, PacedPacketInfo()));
brandtr9dfff292016-11-14 05:14:50 -08001119 EXPECT_TRUE(rtp_sender_->TimeToSendPacket(kFlexfecSsrc, flexfec_seq_num,
1120 fake_clock_.TimeInMilliseconds(),
philipel8aadd502017-02-23 02:56:13 -08001121 false, PacedPacketInfo()));
brandtr9dfff292016-11-14 05:14:50 -08001122 ASSERT_EQ(2, transport_.packets_sent());
brandtrdbdb3f12016-11-10 05:04:48 -08001123 const RtpPacketReceived& media_packet = transport_.sent_packets_[0];
1124 EXPECT_EQ(kMediaPayloadType, media_packet.PayloadType());
brandtr9dfff292016-11-14 05:14:50 -08001125 EXPECT_EQ(kSeqNum, media_packet.SequenceNumber());
brandtrdbdb3f12016-11-10 05:04:48 -08001126 EXPECT_EQ(kMediaSsrc, media_packet.Ssrc());
brandtr9dfff292016-11-14 05:14:50 -08001127 const RtpPacketReceived& flexfec_packet = transport_.sent_packets_[1];
1128 EXPECT_EQ(kFlexfecPayloadType, flexfec_packet.PayloadType());
1129 EXPECT_EQ(flexfec_seq_num, flexfec_packet.SequenceNumber());
1130 EXPECT_EQ(kFlexfecSsrc, flexfec_packet.Ssrc());
brandtrdbdb3f12016-11-10 05:04:48 -08001131}
1132
ilnik10894992017-06-21 08:23:19 -07001133// TODO(ilnik): because of webrtc:7859. Once FEC moved below pacer, this test
1134// should be removed.
1135TEST_P(RtpSenderTest, NoFlexfecForTimingFrames) {
1136 constexpr int kMediaPayloadType = 127;
1137 constexpr int kFlexfecPayloadType = 118;
1138 constexpr uint32_t kMediaSsrc = 1234;
1139 constexpr uint32_t kFlexfecSsrc = 5678;
Steve Antonf0482ea2018-04-09 13:33:52 -07001140 const char kNoMid[] = "";
ilnik10894992017-06-21 08:23:19 -07001141 const std::vector<RtpExtension> kNoRtpExtensions;
1142 const std::vector<RtpExtensionSize> kNoRtpExtensionSizes;
ilnike4350192017-06-29 02:27:44 -07001143
ilnik10894992017-06-21 08:23:19 -07001144 FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexfecSsrc, kMediaSsrc,
Steve Antonf0482ea2018-04-09 13:33:52 -07001145 kNoMid, kNoRtpExtensions, kNoRtpExtensionSizes,
ilnik10894992017-06-21 08:23:19 -07001146 nullptr /* rtp_state */, &fake_clock_);
1147
1148 // Reset |rtp_sender_| to use FlexFEC.
1149 rtp_sender_.reset(new RTPSender(
1150 false, &fake_clock_, &transport_, &mock_paced_sender_, &flexfec_sender,
1151 &seq_num_allocator_, nullptr, nullptr, nullptr, nullptr,
1152 &mock_rtc_event_log_, &send_packet_observer_,
Erik Språng7b52f102018-02-07 14:37:37 +01001153 &retransmission_rate_limiter_, nullptr, false));
ilnik10894992017-06-21 08:23:19 -07001154 rtp_sender_->SetSSRC(kMediaSsrc);
1155 rtp_sender_->SetSequenceNumber(kSeqNum);
ilnik10894992017-06-21 08:23:19 -07001156 rtp_sender_->SetStorePacketsStatus(true, 10);
1157
ilnike4350192017-06-29 02:27:44 -07001158 // Need extension to be registered for timing frames to be sent.
1159 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
1160 kRtpExtensionVideoTiming, kVideoTimingExtensionId));
1161
ilnik10894992017-06-21 08:23:19 -07001162 // Parameters selected to generate a single FEC packet per media packet.
1163 FecProtectionParams params;
1164 params.fec_rate = 15;
1165 params.max_fec_frames = 1;
1166 params.fec_mask_type = kFecMaskRandom;
1167 rtp_sender_->SetFecParameters(params, params);
1168
1169 EXPECT_CALL(mock_paced_sender_,
1170 InsertPacket(RtpPacketSender::kLowPriority, kMediaSsrc, kSeqNum,
1171 _, _, false));
1172 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kLowPriority,
1173 kFlexfecSsrc, _, _, _, false))
1174 .Times(0); // Not called because packet should not be protected.
1175
1176 const uint32_t kTimestamp = 1234;
1177 const uint8_t kPayloadType = 127;
1178 const int64_t kCaptureTimeMs = fake_clock_.TimeInMilliseconds();
1179 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
1180 EXPECT_EQ(0, rtp_sender_->RegisterPayload(payload_name, kPayloadType, 90000,
1181 0, 1500));
1182 RTPVideoHeader video_header;
Ilya Nikolaevskiyb6c462d2018-06-05 15:21:32 +02001183 video_header.video_timing.flags = VideoSendTiming::kTriggeredByTimer;
ilnik10894992017-06-21 08:23:19 -07001184 EXPECT_TRUE(rtp_sender_->SendOutgoingData(
1185 kVideoFrameKey, kPayloadType, kTimestamp, kCaptureTimeMs, kPayloadData,
spranga8ae6f22017-09-04 07:23:56 -07001186 sizeof(kPayloadData), nullptr, &video_header, nullptr,
1187 kDefaultExpectedRetransmissionTimeMs));
ilnik10894992017-06-21 08:23:19 -07001188
Elad Alon4a87e1c2017-10-03 16:11:34 +02001189 EXPECT_CALL(mock_rtc_event_log_,
1190 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
1191 .Times(1);
ilnik10894992017-06-21 08:23:19 -07001192 EXPECT_TRUE(rtp_sender_->TimeToSendPacket(kMediaSsrc, kSeqNum,
1193 fake_clock_.TimeInMilliseconds(),
1194 false, PacedPacketInfo()));
1195 ASSERT_EQ(1, transport_.packets_sent());
1196 const RtpPacketReceived& media_packet = transport_.sent_packets_[0];
1197 EXPECT_EQ(kMediaPayloadType, media_packet.PayloadType());
1198 EXPECT_EQ(kSeqNum, media_packet.SequenceNumber());
1199 EXPECT_EQ(kMediaSsrc, media_packet.Ssrc());
1200
1201 // Now try to send not a timing frame.
1202 uint16_t flexfec_seq_num;
1203 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kLowPriority,
1204 kFlexfecSsrc, _, _, _, false))
1205 .WillOnce(testing::SaveArg<2>(&flexfec_seq_num));
1206 EXPECT_CALL(mock_paced_sender_,
1207 InsertPacket(RtpPacketSender::kLowPriority, kMediaSsrc,
1208 kSeqNum + 1, _, _, false));
Ilya Nikolaevskiyb6c462d2018-06-05 15:21:32 +02001209 video_header.video_timing.flags = VideoSendTiming::kInvalid;
ilnik10894992017-06-21 08:23:19 -07001210 EXPECT_TRUE(rtp_sender_->SendOutgoingData(
1211 kVideoFrameKey, kPayloadType, kTimestamp + 1, kCaptureTimeMs + 1,
spranga8ae6f22017-09-04 07:23:56 -07001212 kPayloadData, sizeof(kPayloadData), nullptr, &video_header, nullptr,
1213 kDefaultExpectedRetransmissionTimeMs));
ilnik10894992017-06-21 08:23:19 -07001214
Elad Alon4a87e1c2017-10-03 16:11:34 +02001215 EXPECT_CALL(mock_rtc_event_log_,
1216 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
1217 .Times(2);
ilnik10894992017-06-21 08:23:19 -07001218 EXPECT_TRUE(rtp_sender_->TimeToSendPacket(kMediaSsrc, kSeqNum + 1,
1219 fake_clock_.TimeInMilliseconds(),
1220 false, PacedPacketInfo()));
1221 EXPECT_TRUE(rtp_sender_->TimeToSendPacket(kFlexfecSsrc, flexfec_seq_num,
1222 fake_clock_.TimeInMilliseconds(),
1223 false, PacedPacketInfo()));
1224 ASSERT_EQ(3, transport_.packets_sent());
1225 const RtpPacketReceived& media_packet2 = transport_.sent_packets_[1];
1226 EXPECT_EQ(kMediaPayloadType, media_packet2.PayloadType());
1227 EXPECT_EQ(kSeqNum + 1, media_packet2.SequenceNumber());
1228 EXPECT_EQ(kMediaSsrc, media_packet2.Ssrc());
1229 const RtpPacketReceived& flexfec_packet = transport_.sent_packets_[2];
1230 EXPECT_EQ(kFlexfecPayloadType, flexfec_packet.PayloadType());
1231 EXPECT_EQ(flexfec_seq_num, flexfec_packet.SequenceNumber());
1232 EXPECT_EQ(kFlexfecSsrc, flexfec_packet.Ssrc());
1233}
1234
minyue3a407ee2017-04-03 01:10:33 -07001235TEST_P(RtpSenderTestWithoutPacer, SendFlexfecPackets) {
brandtrdbdb3f12016-11-10 05:04:48 -08001236 constexpr int kMediaPayloadType = 127;
1237 constexpr int kFlexfecPayloadType = 118;
1238 constexpr uint32_t kMediaSsrc = 1234;
1239 constexpr uint32_t kFlexfecSsrc = 5678;
Steve Antonf0482ea2018-04-09 13:33:52 -07001240 const char kNoMid[] = "";
brandtrdbdb3f12016-11-10 05:04:48 -08001241 const std::vector<RtpExtension> kNoRtpExtensions;
erikvarga27883732017-05-17 05:08:38 -07001242 const std::vector<RtpExtensionSize> kNoRtpExtensionSizes;
brandtrdbdb3f12016-11-10 05:04:48 -08001243 FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexfecSsrc, kMediaSsrc,
Steve Antonf0482ea2018-04-09 13:33:52 -07001244 kNoMid, kNoRtpExtensions, kNoRtpExtensionSizes,
brandtr48d21a22017-05-30 02:32:12 -07001245 nullptr /* rtp_state */, &fake_clock_);
brandtrdbdb3f12016-11-10 05:04:48 -08001246
1247 // Reset |rtp_sender_| to use FlexFEC.
Erik Språng7b52f102018-02-07 14:37:37 +01001248 rtp_sender_.reset(
1249 new RTPSender(false, &fake_clock_, &transport_, nullptr, &flexfec_sender,
1250 &seq_num_allocator_, nullptr, nullptr, nullptr, nullptr,
1251 &mock_rtc_event_log_, &send_packet_observer_,
1252 &retransmission_rate_limiter_, nullptr, false));
brandtrdbdb3f12016-11-10 05:04:48 -08001253 rtp_sender_->SetSSRC(kMediaSsrc);
1254 rtp_sender_->SetSequenceNumber(kSeqNum);
brandtrdbdb3f12016-11-10 05:04:48 -08001255
1256 // Parameters selected to generate a single FEC packet per media packet.
1257 FecProtectionParams params;
1258 params.fec_rate = 15;
1259 params.max_fec_frames = 1;
1260 params.fec_mask_type = kFecMaskRandom;
1261 rtp_sender_->SetFecParameters(params, params);
1262
Elad Alon4a87e1c2017-10-03 16:11:34 +02001263 EXPECT_CALL(mock_rtc_event_log_,
1264 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
1265 .Times(2);
brandtrdbdb3f12016-11-10 05:04:48 -08001266 SendGenericPayload();
1267 ASSERT_EQ(2, transport_.packets_sent());
1268 const RtpPacketReceived& media_packet = transport_.sent_packets_[0];
1269 EXPECT_EQ(kMediaPayloadType, media_packet.PayloadType());
1270 EXPECT_EQ(kMediaSsrc, media_packet.Ssrc());
1271 const RtpPacketReceived& flexfec_packet = transport_.sent_packets_[1];
1272 EXPECT_EQ(kFlexfecPayloadType, flexfec_packet.PayloadType());
1273 EXPECT_EQ(kFlexfecSsrc, flexfec_packet.Ssrc());
1274}
1275
Steve Anton296a0ce2018-03-22 15:17:27 -07001276// Test that the MID header extension is included on sent packets when
1277// configured.
1278TEST_P(RtpSenderTestWithoutPacer, MidIncludedOnSentPackets) {
1279 const char kMid[] = "mid";
1280
1281 // Register MID header extension and set the MID for the RTPSender.
1282 rtp_sender_->SetSendingMediaStatus(false);
1283 rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionMid, kMidExtensionId);
1284 rtp_sender_->SetMid(kMid);
1285 rtp_sender_->SetSendingMediaStatus(true);
1286
1287 // Send a couple packets.
1288 SendGenericPayload();
1289 SendGenericPayload();
1290
1291 // Expect both packets to have the MID set.
1292 ASSERT_EQ(2u, transport_.sent_packets_.size());
1293 for (const RtpPacketReceived& packet : transport_.sent_packets_) {
1294 std::string mid;
1295 ASSERT_TRUE(packet.GetExtension<RtpMid>(&mid));
1296 EXPECT_EQ(kMid, mid);
1297 }
1298}
1299
minyue3a407ee2017-04-03 01:10:33 -07001300TEST_P(RtpSenderTest, FecOverheadRate) {
brandtr81eab612017-01-24 04:06:09 -08001301 constexpr int kFlexfecPayloadType = 118;
1302 constexpr uint32_t kMediaSsrc = 1234;
1303 constexpr uint32_t kFlexfecSsrc = 5678;
Steve Antonf0482ea2018-04-09 13:33:52 -07001304 const char kNoMid[] = "";
brandtr81eab612017-01-24 04:06:09 -08001305 const std::vector<RtpExtension> kNoRtpExtensions;
erikvarga27883732017-05-17 05:08:38 -07001306 const std::vector<RtpExtensionSize> kNoRtpExtensionSizes;
brandtr81eab612017-01-24 04:06:09 -08001307 FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexfecSsrc, kMediaSsrc,
Steve Antonf0482ea2018-04-09 13:33:52 -07001308 kNoMid, kNoRtpExtensions, kNoRtpExtensionSizes,
brandtr48d21a22017-05-30 02:32:12 -07001309 nullptr /* rtp_state */, &fake_clock_);
brandtr81eab612017-01-24 04:06:09 -08001310
1311 // Reset |rtp_sender_| to use FlexFEC.
1312 rtp_sender_.reset(new RTPSender(
1313 false, &fake_clock_, &transport_, &mock_paced_sender_, &flexfec_sender,
1314 &seq_num_allocator_, nullptr, nullptr, nullptr, nullptr,
1315 &mock_rtc_event_log_, &send_packet_observer_,
Erik Språng7b52f102018-02-07 14:37:37 +01001316 &retransmission_rate_limiter_, nullptr, false));
brandtr81eab612017-01-24 04:06:09 -08001317 rtp_sender_->SetSSRC(kMediaSsrc);
1318 rtp_sender_->SetSequenceNumber(kSeqNum);
brandtr81eab612017-01-24 04:06:09 -08001319
1320 // Parameters selected to generate a single FEC packet per media packet.
1321 FecProtectionParams params;
1322 params.fec_rate = 15;
1323 params.max_fec_frames = 1;
1324 params.fec_mask_type = kFecMaskRandom;
1325 rtp_sender_->SetFecParameters(params, params);
1326
1327 constexpr size_t kNumMediaPackets = 10;
1328 constexpr size_t kNumFecPackets = kNumMediaPackets;
1329 constexpr int64_t kTimeBetweenPacketsMs = 10;
1330 EXPECT_CALL(mock_paced_sender_, InsertPacket(_, _, _, _, _, false))
1331 .Times(kNumMediaPackets + kNumFecPackets);
1332 for (size_t i = 0; i < kNumMediaPackets; ++i) {
1333 SendGenericPayload();
1334 fake_clock_.AdvanceTimeMilliseconds(kTimeBetweenPacketsMs);
1335 }
1336 constexpr size_t kRtpHeaderLength = 12;
1337 constexpr size_t kFlexfecHeaderLength = 20;
1338 constexpr size_t kGenericCodecHeaderLength = 1;
1339 constexpr size_t kPayloadLength = sizeof(kPayloadData);
1340 constexpr size_t kPacketLength = kRtpHeaderLength + kFlexfecHeaderLength +
1341 kGenericCodecHeaderLength + kPayloadLength;
1342 EXPECT_NEAR(kNumFecPackets * kPacketLength * 8 /
1343 (kNumFecPackets * kTimeBetweenPacketsMs / 1000.0f),
1344 rtp_sender_->FecOverheadRate(), 500);
1345}
1346
minyue3a407ee2017-04-03 01:10:33 -07001347TEST_P(RtpSenderTest, FrameCountCallbacks) {
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001348 class TestCallback : public FrameCountObserver {
1349 public:
pbos@webrtc.orgce4e9a32014-12-18 13:50:16 +00001350 TestCallback() : FrameCountObserver(), num_calls_(0), ssrc_(0) {}
Danil Chapovalovdd7e2842018-03-09 15:37:03 +00001351 ~TestCallback() override = default;
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001352
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00001353 void FrameCountUpdated(const FrameCounts& frame_counts,
1354 uint32_t ssrc) override {
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001355 ++num_calls_;
1356 ssrc_ = ssrc;
pbos@webrtc.orgce4e9a32014-12-18 13:50:16 +00001357 frame_counts_ = frame_counts;
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001358 }
1359
1360 uint32_t num_calls_;
1361 uint32_t ssrc_;
pbos@webrtc.orgce4e9a32014-12-18 13:50:16 +00001362 FrameCounts frame_counts_;
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001363 } callback;
1364
Erik Språng7b52f102018-02-07 14:37:37 +01001365 rtp_sender_.reset(new RTPSender(
1366 false, &fake_clock_, &transport_, &mock_paced_sender_, nullptr, nullptr,
1367 nullptr, nullptr, &callback, nullptr, nullptr, nullptr,
1368 &retransmission_rate_limiter_, nullptr, false));
nisse7d59f6b2017-02-21 03:40:24 -08001369 rtp_sender_->SetSSRC(kSsrc);
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001370 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
1371 const uint8_t payload_type = 127;
1372 ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 90000,
1373 0, 1500));
1374 uint8_t payload[] = {47, 11, 32, 93, 89};
1375 rtp_sender_->SetStorePacketsStatus(true, 1);
1376 uint32_t ssrc = rtp_sender_->SSRC();
1377
terelius5d332ac2016-01-14 14:37:39 -08001378 EXPECT_CALL(mock_paced_sender_, InsertPacket(_, _, _, _, _, _))
1379 .Times(::testing::AtLeast(2));
1380
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001381 RTPVideoHeader video_header;
spranga8ae6f22017-09-04 07:23:56 -07001382 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
1383 kVideoFrameKey, payload_type, 1234, 4321, payload, sizeof(payload),
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001384 nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001385
1386 EXPECT_EQ(1U, callback.num_calls_);
1387 EXPECT_EQ(ssrc, callback.ssrc_);
pbos@webrtc.orgce4e9a32014-12-18 13:50:16 +00001388 EXPECT_EQ(1, callback.frame_counts_.key_frames);
1389 EXPECT_EQ(0, callback.frame_counts_.delta_frames);
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001390
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001391 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
1392 kVideoFrameDelta, payload_type, 1234, 4321, payload, sizeof(payload),
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001393 nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001394
1395 EXPECT_EQ(2U, callback.num_calls_);
1396 EXPECT_EQ(ssrc, callback.ssrc_);
pbos@webrtc.orgce4e9a32014-12-18 13:50:16 +00001397 EXPECT_EQ(1, callback.frame_counts_.key_frames);
1398 EXPECT_EQ(1, callback.frame_counts_.delta_frames);
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001399
andresp@webrtc.org8f151212014-07-10 09:39:23 +00001400 rtp_sender_.reset();
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001401}
1402
minyue3a407ee2017-04-03 01:10:33 -07001403TEST_P(RtpSenderTest, BitrateCallbacks) {
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001404 class TestCallback : public BitrateStatisticsObserver {
1405 public:
sprangcd349d92016-07-13 09:11:28 -07001406 TestCallback()
1407 : BitrateStatisticsObserver(),
1408 num_calls_(0),
1409 ssrc_(0),
1410 total_bitrate_(0),
1411 retransmit_bitrate_(0) {}
Danil Chapovalovdd7e2842018-03-09 15:37:03 +00001412 ~TestCallback() override = default;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001413
sprangcd349d92016-07-13 09:11:28 -07001414 void Notify(uint32_t total_bitrate,
1415 uint32_t retransmit_bitrate,
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00001416 uint32_t ssrc) override {
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001417 ++num_calls_;
1418 ssrc_ = ssrc;
sprangcd349d92016-07-13 09:11:28 -07001419 total_bitrate_ = total_bitrate;
1420 retransmit_bitrate_ = retransmit_bitrate;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001421 }
1422
1423 uint32_t num_calls_;
1424 uint32_t ssrc_;
sprangcd349d92016-07-13 09:11:28 -07001425 uint32_t total_bitrate_;
1426 uint32_t retransmit_bitrate_;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001427 } callback;
Erik Språng7b52f102018-02-07 14:37:37 +01001428 rtp_sender_.reset(
1429 new RTPSender(false, &fake_clock_, &transport_, nullptr, nullptr, nullptr,
1430 nullptr, &callback, nullptr, nullptr, nullptr, nullptr,
1431 &retransmission_rate_limiter_, nullptr, false));
nisse7d59f6b2017-02-21 03:40:24 -08001432 rtp_sender_->SetSSRC(kSsrc);
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001433
sprangcd349d92016-07-13 09:11:28 -07001434 // Simulate kNumPackets sent with kPacketInterval ms intervals, with the
1435 // number of packets selected so that we fill (but don't overflow) the one
1436 // second averaging window.
1437 const uint32_t kWindowSizeMs = 1000;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001438 const uint32_t kPacketInterval = 20;
sprangcd349d92016-07-13 09:11:28 -07001439 const uint32_t kNumPackets =
1440 (kWindowSizeMs - kPacketInterval) / kPacketInterval;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001441 // Overhead = 12 bytes RTP header + 1 byte generic header.
1442 const uint32_t kPacketOverhead = 13;
1443
1444 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
1445 const uint8_t payload_type = 127;
danilchap162abd32015-12-10 02:39:40 -08001446 ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 90000,
1447 0, 1500));
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001448 uint8_t payload[] = {47, 11, 32, 93, 89};
1449 rtp_sender_->SetStorePacketsStatus(true, 1);
1450 uint32_t ssrc = rtp_sender_->SSRC();
1451
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001452 // Initial process call so we get a new time window.
1453 rtp_sender_->ProcessBitrate();
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001454
1455 // Send a few frames.
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001456 RTPVideoHeader video_header;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001457 for (uint32_t i = 0; i < kNumPackets; ++i) {
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001458 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
1459 kVideoFrameKey, payload_type, 1234, 4321, payload, sizeof(payload),
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001460 nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001461 fake_clock_.AdvanceTimeMilliseconds(kPacketInterval);
1462 }
1463
1464 rtp_sender_->ProcessBitrate();
1465
stefan@webrtc.org0bae1fa2014-11-05 14:05:29 +00001466 // We get one call for every stats updated, thus two calls since both the
1467 // stream stats and the retransmit stats are updated once.
1468 EXPECT_EQ(2u, callback.num_calls_);
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001469 EXPECT_EQ(ssrc, callback.ssrc_);
sprangcd349d92016-07-13 09:11:28 -07001470 const uint32_t kTotalPacketSize = kPacketOverhead + sizeof(payload);
1471 // Bitrate measured over delta between last and first timestamp, plus one.
1472 const uint32_t kExpectedWindowMs = kNumPackets * kPacketInterval + 1;
1473 const uint32_t kExpectedBitsAccumulated = kTotalPacketSize * kNumPackets * 8;
1474 const uint32_t kExpectedRateBps =
1475 (kExpectedBitsAccumulated * 1000 + (kExpectedWindowMs / 2)) /
1476 kExpectedWindowMs;
1477 EXPECT_EQ(kExpectedRateBps, callback.total_bitrate_);
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001478
andresp@webrtc.orgd11bec42014-07-08 14:32:58 +00001479 rtp_sender_.reset();
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001480}
1481
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001482class RtpSenderAudioTest : public RtpSenderTest {
1483 protected:
1484 RtpSenderAudioTest() {}
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001485
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00001486 void SetUp() override {
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001487 payload_ = kAudioPayload;
Erik Språng7b52f102018-02-07 14:37:37 +01001488 rtp_sender_.reset(
1489 new RTPSender(true, &fake_clock_, &transport_, nullptr, nullptr,
1490 nullptr, nullptr, nullptr, nullptr, nullptr, nullptr,
1491 nullptr, &retransmission_rate_limiter_, nullptr, false));
nisse7d59f6b2017-02-21 03:40:24 -08001492 rtp_sender_->SetSSRC(kSsrc);
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001493 rtp_sender_->SetSequenceNumber(kSeqNum);
1494 }
1495};
1496
minyue3a407ee2017-04-03 01:10:33 -07001497TEST_P(RtpSenderTestWithoutPacer, StreamDataCountersCallbacks) {
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001498 class TestCallback : public StreamDataCountersCallback {
1499 public:
danilchap162abd32015-12-10 02:39:40 -08001500 TestCallback() : StreamDataCountersCallback(), ssrc_(0), counters_() {}
Danil Chapovalovdd7e2842018-03-09 15:37:03 +00001501 ~TestCallback() override = default;
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001502
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00001503 void DataCountersUpdated(const StreamDataCounters& counters,
1504 uint32_t ssrc) override {
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001505 ssrc_ = ssrc;
1506 counters_ = counters;
1507 }
1508
1509 uint32_t ssrc_;
1510 StreamDataCounters counters_;
asapersson@webrtc.org44149392015-02-04 08:34:47 +00001511
1512 void MatchPacketCounter(const RtpPacketCounter& expected,
1513 const RtpPacketCounter& actual) {
1514 EXPECT_EQ(expected.payload_bytes, actual.payload_bytes);
1515 EXPECT_EQ(expected.header_bytes, actual.header_bytes);
1516 EXPECT_EQ(expected.padding_bytes, actual.padding_bytes);
1517 EXPECT_EQ(expected.packets, actual.packets);
1518 }
1519
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001520 void Matches(uint32_t ssrc, const StreamDataCounters& counters) {
1521 EXPECT_EQ(ssrc, ssrc_);
asapersson@webrtc.org44149392015-02-04 08:34:47 +00001522 MatchPacketCounter(counters.transmitted, counters_.transmitted);
1523 MatchPacketCounter(counters.retransmitted, counters_.retransmitted);
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001524 EXPECT_EQ(counters.fec.packets, counters_.fec.packets);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001525 }
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001526 } callback;
1527
1528 const uint8_t kRedPayloadType = 96;
1529 const uint8_t kUlpfecPayloadType = 97;
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001530 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
1531 const uint8_t payload_type = 127;
1532 ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 90000,
1533 0, 1500));
1534 uint8_t payload[] = {47, 11, 32, 93, 89};
1535 rtp_sender_->SetStorePacketsStatus(true, 1);
1536 uint32_t ssrc = rtp_sender_->SSRC();
1537
1538 rtp_sender_->RegisterRtpStatisticsCallback(&callback);
1539
1540 // Send a frame.
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001541 RTPVideoHeader video_header;
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001542 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001543 kVideoFrameKey, payload_type, 1234, 4321, payload, sizeof(payload),
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001544 nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001545 StreamDataCounters expected;
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001546 expected.transmitted.payload_bytes = 6;
1547 expected.transmitted.header_bytes = 12;
1548 expected.transmitted.padding_bytes = 0;
1549 expected.transmitted.packets = 1;
1550 expected.retransmitted.payload_bytes = 0;
1551 expected.retransmitted.header_bytes = 0;
1552 expected.retransmitted.padding_bytes = 0;
1553 expected.retransmitted.packets = 0;
1554 expected.fec.packets = 0;
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001555 callback.Matches(ssrc, expected);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001556
1557 // Retransmit a frame.
1558 uint16_t seqno = rtp_sender_->SequenceNumber() - 1;
Erik Språnga12b1d62018-03-14 12:39:24 +01001559 rtp_sender_->ReSendPacket(seqno);
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001560 expected.transmitted.payload_bytes = 12;
1561 expected.transmitted.header_bytes = 24;
1562 expected.transmitted.packets = 2;
1563 expected.retransmitted.payload_bytes = 6;
1564 expected.retransmitted.header_bytes = 12;
1565 expected.retransmitted.padding_bytes = 0;
1566 expected.retransmitted.packets = 1;
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001567 callback.Matches(ssrc, expected);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001568
1569 // Send padding.
philipel8aadd502017-02-23 02:56:13 -08001570 rtp_sender_->TimeToSendPadding(kMaxPaddingSize, PacedPacketInfo());
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001571 expected.transmitted.payload_bytes = 12;
1572 expected.transmitted.header_bytes = 36;
1573 expected.transmitted.padding_bytes = kMaxPaddingSize;
1574 expected.transmitted.packets = 3;
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001575 callback.Matches(ssrc, expected);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001576
brandtrf1bb4762016-11-07 03:05:06 -08001577 // Send ULPFEC.
1578 rtp_sender_->SetUlpfecConfig(kRedPayloadType, kUlpfecPayloadType);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001579 FecProtectionParams fec_params;
1580 fec_params.fec_mask_type = kFecMaskRandom;
1581 fec_params.fec_rate = 1;
1582 fec_params.max_fec_frames = 1;
brandtr1743a192016-11-07 03:36:05 -08001583 rtp_sender_->SetFecParameters(fec_params, fec_params);
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001584 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001585 kVideoFrameDelta, payload_type, 1234, 4321, payload, sizeof(payload),
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001586 nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001587 expected.transmitted.payload_bytes = 40;
1588 expected.transmitted.header_bytes = 60;
1589 expected.transmitted.packets = 5;
1590 expected.fec.packets = 1;
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001591 callback.Matches(ssrc, expected);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001592
sprang867fb522015-08-03 04:38:41 -07001593 rtp_sender_->RegisterRtpStatisticsCallback(nullptr);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001594}
1595
minyue3a407ee2017-04-03 01:10:33 -07001596TEST_P(RtpSenderAudioTest, SendAudio) {
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001597 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "PAYLOAD_NAME";
1598 const uint8_t payload_type = 127;
1599 ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 48000,
1600 0, 1500));
1601 uint8_t payload[] = {47, 11, 32, 93, 89};
1602
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001603 RTPVideoHeader video_header;
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001604 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001605 kAudioFrameCN, payload_type, 1234, 4321, payload, sizeof(payload),
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001606 nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001607
danilchap96c15872016-11-21 01:35:29 -08001608 auto sent_payload = transport_.last_sent_packet().payload();
1609 EXPECT_THAT(sent_payload, ElementsAreArray(payload));
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001610}
1611
minyue3a407ee2017-04-03 01:10:33 -07001612TEST_P(RtpSenderAudioTest, SendAudioWithAudioLevelExtension) {
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001613 EXPECT_EQ(0, rtp_sender_->SetAudioLevel(kAudioLevel));
danilchap162abd32015-12-10 02:39:40 -08001614 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAudioLevel,
1615 kAudioLevelExtensionId));
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001616
1617 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "PAYLOAD_NAME";
1618 const uint8_t payload_type = 127;
1619 ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 48000,
1620 0, 1500));
1621 uint8_t payload[] = {47, 11, 32, 93, 89};
1622
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001623 RTPVideoHeader video_header;
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001624 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001625 kAudioFrameCN, payload_type, 1234, 4321, payload, sizeof(payload),
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001626 nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001627
danilchap96c15872016-11-21 01:35:29 -08001628 auto sent_payload = transport_.last_sent_packet().payload();
1629 EXPECT_THAT(sent_payload, ElementsAreArray(payload));
danilchap12ba1862016-10-26 02:41:55 -07001630 // Verify AudioLevel extension.
1631 bool voice_activity;
1632 uint8_t audio_level;
1633 EXPECT_TRUE(transport_.last_sent_packet().GetExtension<AudioLevel>(
1634 &voice_activity, &audio_level));
1635 EXPECT_EQ(kAudioLevel, audio_level);
1636 EXPECT_FALSE(voice_activity);
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001637}
1638
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001639// As RFC4733, named telephone events are carried as part of the audio stream
1640// and must use the same sequence number and timestamp base as the regular
1641// audio channel.
1642// This test checks the marker bit for the first packet and the consequent
1643// packets of the same telephone event. Since it is specifically for DTMF
pbos22993e12015-10-19 02:39:06 -07001644// events, ignoring audio packets and sending kEmptyFrame instead of those.
minyue3a407ee2017-04-03 01:10:33 -07001645TEST_P(RtpSenderAudioTest, CheckMarkerBitForTelephoneEvents) {
solenbergffbbcac2016-11-17 05:25:37 -08001646 const char* kDtmfPayloadName = "telephone-event";
1647 const uint32_t kPayloadFrequency = 8000;
1648 const uint8_t kPayloadType = 126;
1649 ASSERT_EQ(0, rtp_sender_->RegisterPayload(kDtmfPayloadName, kPayloadType,
1650 kPayloadFrequency, 0, 0));
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001651 // For Telephone events, payload is not added to the registered payload list,
1652 // it will register only the payload used for audio stream.
1653 // Registering the payload again for audio stream with different payload name.
solenbergffbbcac2016-11-17 05:25:37 -08001654 const char* kPayloadName = "payload_name";
1655 ASSERT_EQ(0, rtp_sender_->RegisterPayload(kPayloadName, kPayloadType,
1656 kPayloadFrequency, 1, 0));
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001657 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
1658 // DTMF event key=9, duration=500 and attenuationdB=10
1659 rtp_sender_->SendTelephoneEvent(9, 500, 10);
1660 // During start, it takes the starting timestamp as last sent timestamp.
1661 // The duration is calculated as the difference of current and last sent
1662 // timestamp. So for first call it will skip since the duration is zero.
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001663 RTPVideoHeader video_header;
spranga8ae6f22017-09-04 07:23:56 -07001664 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
1665 kEmptyFrame, kPayloadType, capture_time_ms, 0, nullptr, 0, nullptr,
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001666 &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001667 // DTMF Sample Length is (Frequency/1000) * Duration.
1668 // So in this case, it is (8000/1000) * 500 = 4000.
1669 // Sending it as two packets.
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001670 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001671 kEmptyFrame, kPayloadType, capture_time_ms + 2000, 0, nullptr, 0, nullptr,
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001672 &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
danilchap12ba1862016-10-26 02:41:55 -07001673
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001674 // Marker Bit should be set to 1 for first packet.
danilchap12ba1862016-10-26 02:41:55 -07001675 EXPECT_TRUE(transport_.last_sent_packet().Marker());
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001676
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001677 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001678 kEmptyFrame, kPayloadType, capture_time_ms + 4000, 0, nullptr, 0, nullptr,
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001679 &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001680 // Marker Bit should be set to 0 for rest of the packets.
danilchap12ba1862016-10-26 02:41:55 -07001681 EXPECT_FALSE(transport_.last_sent_packet().Marker());
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001682}
1683
minyue3a407ee2017-04-03 01:10:33 -07001684TEST_P(RtpSenderTestWithoutPacer, BytesReportedCorrectly) {
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001685 const char* kPayloadName = "GENERIC";
1686 const uint8_t kPayloadType = 127;
1687 rtp_sender_->SetSSRC(1234);
1688 rtp_sender_->SetRtxSsrc(4321);
Shao Changbine62202f2015-04-21 20:24:50 +08001689 rtp_sender_->SetRtxPayloadType(kPayloadType - 1, kPayloadType);
pbos@webrtc.org0b0c2412015-01-13 14:15:15 +00001690 rtp_sender_->SetRtxStatus(kRtxRetransmitted | kRtxRedundantPayloads);
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001691
danilchap162abd32015-12-10 02:39:40 -08001692 ASSERT_EQ(0, rtp_sender_->RegisterPayload(kPayloadName, kPayloadType, 90000,
1693 0, 1500));
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001694 uint8_t payload[] = {47, 11, 32, 93, 89};
1695
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001696 RTPVideoHeader video_header;
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001697 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001698 kVideoFrameKey, kPayloadType, 1234, 4321, payload, sizeof(payload),
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001699 nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001700
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +00001701 // Will send 2 full-size padding packets.
philipel8aadd502017-02-23 02:56:13 -08001702 rtp_sender_->TimeToSendPadding(1, PacedPacketInfo());
1703 rtp_sender_->TimeToSendPadding(1, PacedPacketInfo());
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001704
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +00001705 StreamDataCounters rtp_stats;
1706 StreamDataCounters rtx_stats;
1707 rtp_sender_->GetDataCounters(&rtp_stats, &rtx_stats);
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001708
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +00001709 // Payload + 1-byte generic header.
asapersson@webrtc.orgd08d3892014-12-16 12:03:11 +00001710 EXPECT_GT(rtp_stats.first_packet_time_ms, -1);
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001711 EXPECT_EQ(rtp_stats.transmitted.payload_bytes, sizeof(payload) + 1);
1712 EXPECT_EQ(rtp_stats.transmitted.header_bytes, 12u);
1713 EXPECT_EQ(rtp_stats.transmitted.padding_bytes, 0u);
1714 EXPECT_EQ(rtx_stats.transmitted.payload_bytes, 0u);
1715 EXPECT_EQ(rtx_stats.transmitted.header_bytes, 24u);
1716 EXPECT_EQ(rtx_stats.transmitted.padding_bytes, 2 * kMaxPaddingSize);
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +00001717
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001718 EXPECT_EQ(rtp_stats.transmitted.TotalBytes(),
danilchap162abd32015-12-10 02:39:40 -08001719 rtp_stats.transmitted.payload_bytes +
1720 rtp_stats.transmitted.header_bytes +
1721 rtp_stats.transmitted.padding_bytes);
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001722 EXPECT_EQ(rtx_stats.transmitted.TotalBytes(),
danilchap162abd32015-12-10 02:39:40 -08001723 rtx_stats.transmitted.payload_bytes +
1724 rtx_stats.transmitted.header_bytes +
1725 rtx_stats.transmitted.padding_bytes);
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001726
danilchap162abd32015-12-10 02:39:40 -08001727 EXPECT_EQ(
1728 transport_.total_bytes_sent_,
1729 rtp_stats.transmitted.TotalBytes() + rtx_stats.transmitted.TotalBytes());
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001730}
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001731
minyue3a407ee2017-04-03 01:10:33 -07001732TEST_P(RtpSenderTestWithoutPacer, RespectsNackBitrateLimit) {
sprang38778b02015-09-29 09:48:22 -07001733 const int32_t kPacketSize = 1400;
1734 const int32_t kNumPackets = 30;
1735
sprangcd349d92016-07-13 09:11:28 -07001736 retransmission_rate_limiter_.SetMaxRate(kPacketSize * kNumPackets * 8);
1737
sprang38778b02015-09-29 09:48:22 -07001738 rtp_sender_->SetStorePacketsStatus(true, kNumPackets);
sprang38778b02015-09-29 09:48:22 -07001739 const uint16_t kStartSequenceNumber = rtp_sender_->SequenceNumber();
Danil Chapovalov2800d742016-08-26 18:48:46 +02001740 std::vector<uint16_t> sequence_numbers;
sprang38778b02015-09-29 09:48:22 -07001741 for (int32_t i = 0; i < kNumPackets; ++i) {
1742 sequence_numbers.push_back(kStartSequenceNumber + i);
1743 fake_clock_.AdvanceTimeMilliseconds(1);
1744 SendPacket(fake_clock_.TimeInMilliseconds(), kPacketSize);
1745 }
danilchap12ba1862016-10-26 02:41:55 -07001746 EXPECT_EQ(kNumPackets, transport_.packets_sent());
sprang38778b02015-09-29 09:48:22 -07001747
1748 fake_clock_.AdvanceTimeMilliseconds(1000 - kNumPackets);
1749
1750 // Resending should work - brings the bandwidth up to the limit.
1751 // NACK bitrate is capped to the same bitrate as the encoder, since the max
1752 // protection overhead is 50% (see MediaOptimization::SetTargetRates).
Danil Chapovalov2800d742016-08-26 18:48:46 +02001753 rtp_sender_->OnReceivedNack(sequence_numbers, 0);
danilchap12ba1862016-10-26 02:41:55 -07001754 EXPECT_EQ(kNumPackets * 2, transport_.packets_sent());
sprang38778b02015-09-29 09:48:22 -07001755
sprangcd349d92016-07-13 09:11:28 -07001756 // Must be at least 5ms in between retransmission attempts.
1757 fake_clock_.AdvanceTimeMilliseconds(5);
1758
sprang38778b02015-09-29 09:48:22 -07001759 // Resending should not work, bandwidth exceeded.
Danil Chapovalov2800d742016-08-26 18:48:46 +02001760 rtp_sender_->OnReceivedNack(sequence_numbers, 0);
danilchap12ba1862016-10-26 02:41:55 -07001761 EXPECT_EQ(kNumPackets * 2, transport_.packets_sent());
sprang38778b02015-09-29 09:48:22 -07001762}
1763
minyue3a407ee2017-04-03 01:10:33 -07001764TEST_P(RtpSenderVideoTest, KeyFrameHasCVO) {
danilchapb6f1fb52016-10-19 06:11:39 -07001765 uint8_t kFrame[kMaxPacketLength];
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001766 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
1767 kRtpExtensionVideoRotation, kVideoRotationExtensionId));
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001768
philipel1a4746a2018-07-09 15:52:29 +02001769 RTPVideoHeader hdr;
danilchapc1600c52016-10-26 03:33:11 -07001770 hdr.rotation = kVideoRotation_0;
Niels Möller520ca4e2018-06-04 11:14:38 +02001771 rtp_sender_video_->SendVideo(kVideoCodecGeneric, kVideoFrameKey, kPayload,
danilchapb6f1fb52016-10-19 06:11:39 -07001772 kTimestamp, 0, kFrame, sizeof(kFrame), nullptr,
spranga8ae6f22017-09-04 07:23:56 -07001773 &hdr, kDefaultExpectedRetransmissionTimeMs);
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001774
danilchapc1600c52016-10-26 03:33:11 -07001775 VideoRotation rotation;
1776 EXPECT_TRUE(
1777 transport_.last_sent_packet().GetExtension<VideoOrientation>(&rotation));
1778 EXPECT_EQ(kVideoRotation_0, rotation);
1779}
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001780
ilnik04f4d122017-06-19 07:18:55 -07001781TEST_P(RtpSenderVideoTest, TimingFrameHasPacketizationTimstampSet) {
1782 uint8_t kFrame[kMaxPacketLength];
1783 const int64_t kPacketizationTimeMs = 100;
1784 const int64_t kEncodeStartDeltaMs = 10;
1785 const int64_t kEncodeFinishDeltaMs = 50;
1786 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
1787 kRtpExtensionVideoTiming, kVideoTimingExtensionId));
1788
1789 const int64_t kCaptureTimestamp = fake_clock_.TimeInMilliseconds();
1790
philipel1a4746a2018-07-09 15:52:29 +02001791 RTPVideoHeader hdr;
Ilya Nikolaevskiyb6c462d2018-06-05 15:21:32 +02001792 hdr.video_timing.flags = VideoSendTiming::kTriggeredByTimer;
ilnik04f4d122017-06-19 07:18:55 -07001793 hdr.video_timing.encode_start_delta_ms = kEncodeStartDeltaMs;
1794 hdr.video_timing.encode_finish_delta_ms = kEncodeFinishDeltaMs;
1795
1796 fake_clock_.AdvanceTimeMilliseconds(kPacketizationTimeMs);
Niels Möller520ca4e2018-06-04 11:14:38 +02001797 rtp_sender_video_->SendVideo(kVideoCodecGeneric, kVideoFrameKey, kPayload,
ilnik04f4d122017-06-19 07:18:55 -07001798 kTimestamp, kCaptureTimestamp, kFrame,
spranga8ae6f22017-09-04 07:23:56 -07001799 sizeof(kFrame), nullptr, &hdr,
1800 kDefaultExpectedRetransmissionTimeMs);
ilnik2edc6842017-07-06 03:06:50 -07001801 VideoSendTiming timing;
ilnik04f4d122017-06-19 07:18:55 -07001802 EXPECT_TRUE(transport_.last_sent_packet().GetExtension<VideoTimingExtension>(
1803 &timing));
1804 EXPECT_EQ(kPacketizationTimeMs, timing.packetization_finish_delta_ms);
1805 EXPECT_EQ(kEncodeStartDeltaMs, timing.encode_start_delta_ms);
1806 EXPECT_EQ(kEncodeFinishDeltaMs, timing.encode_finish_delta_ms);
1807}
1808
minyue3a407ee2017-04-03 01:10:33 -07001809TEST_P(RtpSenderVideoTest, DeltaFrameHasCVOWhenChanged) {
danilchapc1600c52016-10-26 03:33:11 -07001810 uint8_t kFrame[kMaxPacketLength];
1811 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
1812 kRtpExtensionVideoRotation, kVideoRotationExtensionId));
1813
philipel1a4746a2018-07-09 15:52:29 +02001814 RTPVideoHeader hdr;
danilchapc1600c52016-10-26 03:33:11 -07001815 hdr.rotation = kVideoRotation_90;
spranga8ae6f22017-09-04 07:23:56 -07001816 EXPECT_TRUE(rtp_sender_video_->SendVideo(
Niels Möller520ca4e2018-06-04 11:14:38 +02001817 kVideoCodecGeneric, kVideoFrameKey, kPayload, kTimestamp, 0, kFrame,
spranga8ae6f22017-09-04 07:23:56 -07001818 sizeof(kFrame), nullptr, &hdr, kDefaultExpectedRetransmissionTimeMs));
danilchapc1600c52016-10-26 03:33:11 -07001819
1820 hdr.rotation = kVideoRotation_0;
spranga8ae6f22017-09-04 07:23:56 -07001821 EXPECT_TRUE(rtp_sender_video_->SendVideo(
Niels Möller520ca4e2018-06-04 11:14:38 +02001822 kVideoCodecGeneric, kVideoFrameDelta, kPayload, kTimestamp + 1, 0, kFrame,
spranga8ae6f22017-09-04 07:23:56 -07001823 sizeof(kFrame), nullptr, &hdr, kDefaultExpectedRetransmissionTimeMs));
danilchapc1600c52016-10-26 03:33:11 -07001824
1825 VideoRotation rotation;
1826 EXPECT_TRUE(
1827 transport_.last_sent_packet().GetExtension<VideoOrientation>(&rotation));
1828 EXPECT_EQ(kVideoRotation_0, rotation);
1829}
1830
minyue3a407ee2017-04-03 01:10:33 -07001831TEST_P(RtpSenderVideoTest, DeltaFrameHasCVOWhenNonZero) {
danilchapc1600c52016-10-26 03:33:11 -07001832 uint8_t kFrame[kMaxPacketLength];
1833 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
1834 kRtpExtensionVideoRotation, kVideoRotationExtensionId));
1835
philipel1a4746a2018-07-09 15:52:29 +02001836 RTPVideoHeader hdr;
danilchapc1600c52016-10-26 03:33:11 -07001837 hdr.rotation = kVideoRotation_90;
spranga8ae6f22017-09-04 07:23:56 -07001838 EXPECT_TRUE(rtp_sender_video_->SendVideo(
Niels Möller520ca4e2018-06-04 11:14:38 +02001839 kVideoCodecGeneric, kVideoFrameKey, kPayload, kTimestamp, 0, kFrame,
spranga8ae6f22017-09-04 07:23:56 -07001840 sizeof(kFrame), nullptr, &hdr, kDefaultExpectedRetransmissionTimeMs));
danilchapc1600c52016-10-26 03:33:11 -07001841
spranga8ae6f22017-09-04 07:23:56 -07001842 EXPECT_TRUE(rtp_sender_video_->SendVideo(
Niels Möller520ca4e2018-06-04 11:14:38 +02001843 kVideoCodecGeneric, kVideoFrameDelta, kPayload, kTimestamp + 1, 0, kFrame,
spranga8ae6f22017-09-04 07:23:56 -07001844 sizeof(kFrame), nullptr, &hdr, kDefaultExpectedRetransmissionTimeMs));
danilchapc1600c52016-10-26 03:33:11 -07001845
1846 VideoRotation rotation;
1847 EXPECT_TRUE(
1848 transport_.last_sent_packet().GetExtension<VideoOrientation>(&rotation));
1849 EXPECT_EQ(kVideoRotation_90, rotation);
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001850}
magjed71eb61c2016-09-08 03:24:58 -07001851
1852// Make sure rotation is parsed correctly when the Camera (C) and Flip (F) bits
1853// are set in the CVO byte.
minyue3a407ee2017-04-03 01:10:33 -07001854TEST_P(RtpSenderVideoTest, SendVideoWithCameraAndFlipCVO) {
magjed71eb61c2016-09-08 03:24:58 -07001855 // Test extracting rotation when Camera (C) and Flip (F) bits are zero.
1856 EXPECT_EQ(kVideoRotation_0, ConvertCVOByteToVideoRotation(0));
1857 EXPECT_EQ(kVideoRotation_90, ConvertCVOByteToVideoRotation(1));
1858 EXPECT_EQ(kVideoRotation_180, ConvertCVOByteToVideoRotation(2));
1859 EXPECT_EQ(kVideoRotation_270, ConvertCVOByteToVideoRotation(3));
1860 // Test extracting rotation when Camera (C) and Flip (F) bits are set.
1861 const int flip_bit = 1 << 2;
1862 const int camera_bit = 1 << 3;
1863 EXPECT_EQ(kVideoRotation_0,
1864 ConvertCVOByteToVideoRotation(flip_bit | camera_bit | 0));
1865 EXPECT_EQ(kVideoRotation_90,
1866 ConvertCVOByteToVideoRotation(flip_bit | camera_bit | 1));
1867 EXPECT_EQ(kVideoRotation_180,
1868 ConvertCVOByteToVideoRotation(flip_bit | camera_bit | 2));
1869 EXPECT_EQ(kVideoRotation_270,
1870 ConvertCVOByteToVideoRotation(flip_bit | camera_bit | 3));
1871}
1872
spranga8ae6f22017-09-04 07:23:56 -07001873TEST_P(RtpSenderVideoTest, RetransmissionTypesGeneric) {
1874 RTPVideoHeader header;
Niels Möller520ca4e2018-06-04 11:14:38 +02001875 header.codec = kVideoCodecGeneric;
spranga8ae6f22017-09-04 07:23:56 -07001876
1877 EXPECT_EQ(kDontRetransmit,
1878 rtp_sender_video_->GetStorageType(
1879 header, kRetransmitOff, kDefaultExpectedRetransmissionTimeMs));
1880 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1881 header, kRetransmitBaseLayer,
1882 kDefaultExpectedRetransmissionTimeMs));
1883 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1884 header, kRetransmitHigherLayers,
1885 kDefaultExpectedRetransmissionTimeMs));
1886 EXPECT_EQ(kAllowRetransmission,
1887 rtp_sender_video_->GetStorageType(
1888 header, kConditionallyRetransmitHigherLayers,
1889 kDefaultExpectedRetransmissionTimeMs));
1890 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1891 header, kRetransmitAllPackets,
1892 kDefaultExpectedRetransmissionTimeMs));
1893}
1894
1895TEST_P(RtpSenderVideoTest, RetransmissionTypesH264) {
1896 RTPVideoHeader header;
philipel7d745e52018-08-02 14:03:53 +02001897 header.video_type_header.emplace<RTPVideoHeaderH264>().packetization_mode =
1898 H264PacketizationMode::NonInterleaved;
Niels Möller520ca4e2018-06-04 11:14:38 +02001899 header.codec = kVideoCodecH264;
spranga8ae6f22017-09-04 07:23:56 -07001900
1901 EXPECT_EQ(kDontRetransmit,
1902 rtp_sender_video_->GetStorageType(
1903 header, kRetransmitOff, kDefaultExpectedRetransmissionTimeMs));
1904 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1905 header, kRetransmitBaseLayer,
1906 kDefaultExpectedRetransmissionTimeMs));
1907 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1908 header, kRetransmitHigherLayers,
1909 kDefaultExpectedRetransmissionTimeMs));
1910 EXPECT_EQ(kAllowRetransmission,
1911 rtp_sender_video_->GetStorageType(
1912 header, kConditionallyRetransmitHigherLayers,
1913 kDefaultExpectedRetransmissionTimeMs));
1914 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1915 header, kRetransmitAllPackets,
1916 kDefaultExpectedRetransmissionTimeMs));
1917}
1918
1919TEST_P(RtpSenderVideoTest, RetransmissionTypesVP8BaseLayer) {
1920 RTPVideoHeader header;
Niels Möller520ca4e2018-06-04 11:14:38 +02001921 header.codec = kVideoCodecVP8;
Philip Eliassond52a1a62018-09-07 13:03:55 +00001922 auto& vp8_header = header.video_type_header.emplace<RTPVideoHeaderVP8>();
1923 vp8_header.temporalIdx = 0;
spranga8ae6f22017-09-04 07:23:56 -07001924
1925 EXPECT_EQ(kDontRetransmit,
1926 rtp_sender_video_->GetStorageType(
1927 header, kRetransmitOff, kDefaultExpectedRetransmissionTimeMs));
1928 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1929 header, kRetransmitBaseLayer,
1930 kDefaultExpectedRetransmissionTimeMs));
1931 EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType(
1932 header, kRetransmitHigherLayers,
1933 kDefaultExpectedRetransmissionTimeMs));
1934 EXPECT_EQ(kAllowRetransmission,
1935 rtp_sender_video_->GetStorageType(
1936 header, kRetransmitHigherLayers | kRetransmitBaseLayer,
1937 kDefaultExpectedRetransmissionTimeMs));
1938 EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType(
1939 header, kConditionallyRetransmitHigherLayers,
1940 kDefaultExpectedRetransmissionTimeMs));
1941 EXPECT_EQ(
1942 kAllowRetransmission,
1943 rtp_sender_video_->GetStorageType(
1944 header, kRetransmitBaseLayer | kConditionallyRetransmitHigherLayers,
1945 kDefaultExpectedRetransmissionTimeMs));
1946 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1947 header, kRetransmitAllPackets,
1948 kDefaultExpectedRetransmissionTimeMs));
1949}
1950
1951TEST_P(RtpSenderVideoTest, RetransmissionTypesVP8HigherLayers) {
1952 RTPVideoHeader header;
Niels Möller520ca4e2018-06-04 11:14:38 +02001953 header.codec = kVideoCodecVP8;
spranga8ae6f22017-09-04 07:23:56 -07001954
Philip Eliassond52a1a62018-09-07 13:03:55 +00001955 auto& vp8_header = header.video_type_header.emplace<RTPVideoHeaderVP8>();
spranga8ae6f22017-09-04 07:23:56 -07001956 for (int tid = 1; tid <= kMaxTemporalStreams; ++tid) {
Philip Eliassond52a1a62018-09-07 13:03:55 +00001957 vp8_header.temporalIdx = tid;
spranga8ae6f22017-09-04 07:23:56 -07001958
1959 EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType(
1960 header, kRetransmitOff,
1961 kDefaultExpectedRetransmissionTimeMs));
1962 EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType(
1963 header, kRetransmitBaseLayer,
1964 kDefaultExpectedRetransmissionTimeMs));
1965 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1966 header, kRetransmitHigherLayers,
1967 kDefaultExpectedRetransmissionTimeMs));
1968 EXPECT_EQ(kAllowRetransmission,
1969 rtp_sender_video_->GetStorageType(
1970 header, kRetransmitHigherLayers | kRetransmitBaseLayer,
1971 kDefaultExpectedRetransmissionTimeMs));
1972 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1973 header, kRetransmitAllPackets,
1974 kDefaultExpectedRetransmissionTimeMs));
1975 }
1976}
1977
1978TEST_P(RtpSenderVideoTest, RetransmissionTypesVP9) {
1979 RTPVideoHeader header;
Niels Möller520ca4e2018-06-04 11:14:38 +02001980 header.codec = kVideoCodecVP9;
spranga8ae6f22017-09-04 07:23:56 -07001981
philipel29d88462018-08-08 14:26:00 +02001982 auto& vp9_header = header.video_type_header.emplace<RTPVideoHeaderVP9>();
spranga8ae6f22017-09-04 07:23:56 -07001983 for (int tid = 1; tid <= kMaxTemporalStreams; ++tid) {
philipel29d88462018-08-08 14:26:00 +02001984 vp9_header.temporal_idx = tid;
spranga8ae6f22017-09-04 07:23:56 -07001985
1986 EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType(
1987 header, kRetransmitOff,
1988 kDefaultExpectedRetransmissionTimeMs));
1989 EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType(
1990 header, kRetransmitBaseLayer,
1991 kDefaultExpectedRetransmissionTimeMs));
1992 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1993 header, kRetransmitHigherLayers,
1994 kDefaultExpectedRetransmissionTimeMs));
1995 EXPECT_EQ(kAllowRetransmission,
1996 rtp_sender_video_->GetStorageType(
1997 header, kRetransmitHigherLayers | kRetransmitBaseLayer,
1998 kDefaultExpectedRetransmissionTimeMs));
1999 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
2000 header, kRetransmitAllPackets,
2001 kDefaultExpectedRetransmissionTimeMs));
2002 }
2003}
2004
2005TEST_P(RtpSenderVideoTest, ConditionalRetransmit) {
2006 const int64_t kFrameIntervalMs = 33;
2007 const int64_t kRttMs = (kFrameIntervalMs * 3) / 2;
2008 const uint8_t kSettings =
2009 kRetransmitBaseLayer | kConditionallyRetransmitHigherLayers;
2010
2011 // Insert VP8 frames for all temporal layers, but stop before the final index.
2012 RTPVideoHeader header;
Niels Möller520ca4e2018-06-04 11:14:38 +02002013 header.codec = kVideoCodecVP8;
spranga8ae6f22017-09-04 07:23:56 -07002014
2015 // Fill averaging window to prevent rounding errors.
2016 constexpr int kNumRepetitions =
2017 (RTPSenderVideo::kTLRateWindowSizeMs + (kFrameIntervalMs / 2)) /
2018 kFrameIntervalMs;
2019 constexpr int kPattern[] = {0, 2, 1, 2};
Philip Eliassond52a1a62018-09-07 13:03:55 +00002020 auto& vp8_header = header.video_type_header.emplace<RTPVideoHeaderVP8>();
spranga8ae6f22017-09-04 07:23:56 -07002021 for (size_t i = 0; i < arraysize(kPattern) * kNumRepetitions; ++i) {
Philip Eliassond52a1a62018-09-07 13:03:55 +00002022 vp8_header.temporalIdx = kPattern[i % arraysize(kPattern)];
spranga8ae6f22017-09-04 07:23:56 -07002023 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs);
2024 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
2025 }
2026
2027 // Since we're at the start of the pattern, the next expected frame in TL0 is
2028 // right now. We will wait at most one expected retransmission time before
2029 // acknowledging that it did not arrive, which means this frame and the next
2030 // will not be retransmitted.
Philip Eliassond52a1a62018-09-07 13:03:55 +00002031 vp8_header.temporalIdx = 1;
spranga8ae6f22017-09-04 07:23:56 -07002032 EXPECT_EQ(StorageType::kDontRetransmit,
2033 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
2034 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
2035 EXPECT_EQ(StorageType::kDontRetransmit,
2036 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
2037 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
2038
2039 // The TL0 frame did not arrive. So allow retransmission.
2040 EXPECT_EQ(StorageType::kAllowRetransmission,
2041 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
2042 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
2043
2044 // Insert a frame for TL2. We just had frame in TL1, so the next one there is
2045 // in three frames away. TL0 is still too far in the past. So, allow
2046 // retransmission.
Philip Eliassond52a1a62018-09-07 13:03:55 +00002047 vp8_header.temporalIdx = 2;
spranga8ae6f22017-09-04 07:23:56 -07002048 EXPECT_EQ(StorageType::kAllowRetransmission,
2049 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
2050 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
2051
2052 // Another TL2, next in TL1 is two frames away. Allow again.
2053 EXPECT_EQ(StorageType::kAllowRetransmission,
2054 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
2055 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
2056
2057 // Yet another TL2, next in TL1 is now only one frame away, so don't store
2058 // for retransmission.
2059 EXPECT_EQ(StorageType::kDontRetransmit,
2060 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
2061}
2062
2063TEST_P(RtpSenderVideoTest, ConditionalRetransmitLimit) {
2064 const int64_t kFrameIntervalMs = 200;
2065 const int64_t kRttMs = (kFrameIntervalMs * 3) / 2;
2066 const int32_t kSettings =
2067 kRetransmitBaseLayer | kConditionallyRetransmitHigherLayers;
2068
2069 // Insert VP8 frames for all temporal layers, but stop before the final index.
2070 RTPVideoHeader header;
Niels Möller520ca4e2018-06-04 11:14:38 +02002071 header.codec = kVideoCodecVP8;
spranga8ae6f22017-09-04 07:23:56 -07002072
2073 // Fill averaging window to prevent rounding errors.
2074 constexpr int kNumRepetitions =
2075 (RTPSenderVideo::kTLRateWindowSizeMs + (kFrameIntervalMs / 2)) /
2076 kFrameIntervalMs;
2077 constexpr int kPattern[] = {0, 2, 2, 2};
Philip Eliassond52a1a62018-09-07 13:03:55 +00002078 auto& vp8_header = header.video_type_header.emplace<RTPVideoHeaderVP8>();
spranga8ae6f22017-09-04 07:23:56 -07002079 for (size_t i = 0; i < arraysize(kPattern) * kNumRepetitions; ++i) {
Philip Eliassond52a1a62018-09-07 13:03:55 +00002080 vp8_header.temporalIdx = kPattern[i % arraysize(kPattern)];
spranga8ae6f22017-09-04 07:23:56 -07002081
2082 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs);
2083 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
2084 }
2085
2086 // Since we're at the start of the pattern, the next expected frame will be
2087 // right now in TL0. Put it in TL1 instead. Regular rules would dictate that
2088 // we don't store for retransmission because we expect a frame in a lower
2089 // layer, but that last frame in TL1 was a long time ago in absolute terms,
2090 // so allow retransmission anyway.
Philip Eliassond52a1a62018-09-07 13:03:55 +00002091 vp8_header.temporalIdx = 1;
spranga8ae6f22017-09-04 07:23:56 -07002092 EXPECT_EQ(StorageType::kAllowRetransmission,
2093 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
2094}
2095
philipelb3e42a42018-09-13 10:57:14 +02002096TEST_P(RtpSenderVideoTest, PopulateGenericFrameDescriptor) {
2097 const int64_t kFrameId = 100000;
2098 uint8_t kFrame[100];
2099 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
2100 kRtpExtensionGenericFrameDescriptor, kGenericDescriptorId));
2101
2102 RTPVideoHeader hdr;
2103 RTPVideoHeader::GenericDescriptorInfo& generic = hdr.generic.emplace();
2104 generic.frame_id = kFrameId;
2105 generic.temporal_index = 3;
2106 generic.spatial_index = 2;
2107 generic.higher_spatial_layers.push_back(4);
2108 generic.dependencies.push_back(kFrameId - 1);
2109 generic.dependencies.push_back(kFrameId - 500);
2110 rtp_sender_video_->SendVideo(kVideoCodecGeneric, kVideoFrameDelta, kPayload,
2111 kTimestamp, 0, kFrame, sizeof(kFrame), nullptr,
2112 &hdr, kDefaultExpectedRetransmissionTimeMs);
2113
2114 RtpGenericFrameDescriptor descriptor_wire;
2115 EXPECT_EQ(1U, transport_.sent_packets_.size());
2116 EXPECT_TRUE(
2117 transport_.last_sent_packet()
2118 .GetExtension<RtpGenericFrameDescriptorExtension>(&descriptor_wire));
2119 EXPECT_EQ(static_cast<uint16_t>(generic.frame_id), descriptor_wire.FrameId());
2120 EXPECT_EQ(generic.temporal_index, descriptor_wire.TemporalLayer());
2121 EXPECT_THAT(descriptor_wire.FrameDependenciesDiffs(), ElementsAre(1, 500));
2122 uint8_t spatial_bitmask = 0x14;
2123 EXPECT_EQ(spatial_bitmask, descriptor_wire.SpatialLayersBitmask());
2124}
2125
Danil Chapovalov84ffb352018-09-25 18:59:09 +02002126TEST_P(RtpSenderVideoTest,
2127 UsesMinimalVp8DescriptorWhenGenericFrameDescriptorExtensionIsUsed) {
2128 const int64_t kFrameId = 100000;
2129 const size_t kFrameSize = 100;
2130 uint8_t kFrame[kFrameSize];
2131 ASSERT_TRUE(rtp_sender_->RegisterRtpHeaderExtension(
2132 RtpGenericFrameDescriptorExtension::kUri, kGenericDescriptorId));
2133
2134 RTPVideoHeader hdr;
2135 hdr.codec = kVideoCodecVP8;
2136 RTPVideoHeaderVP8& vp8 = hdr.video_type_header.emplace<RTPVideoHeaderVP8>();
2137 vp8.pictureId = kFrameId % 0X7FFF;
2138 vp8.tl0PicIdx = 13;
2139 vp8.temporalIdx = 1;
2140 vp8.keyIdx = 2;
2141 RTPVideoHeader::GenericDescriptorInfo& generic = hdr.generic.emplace();
2142 generic.frame_id = kFrameId;
2143 rtp_sender_video_->SendVideo(kVideoCodecVP8, kVideoFrameDelta, kPayload,
2144 kTimestamp, 0, kFrame, sizeof(kFrame), nullptr,
2145 &hdr, kDefaultExpectedRetransmissionTimeMs);
2146
2147 ASSERT_THAT(transport_.sent_packets_, SizeIs(1));
2148 // Expect only minimal 1-byte vp8 descriptor was generated.
2149 EXPECT_THAT(transport_.sent_packets_[0].payload_size(), 1 + kFrameSize);
2150}
2151
minyue3a407ee2017-04-03 01:10:33 -07002152TEST_P(RtpSenderTest, OnOverheadChanged) {
michaelt4da30442016-11-17 01:38:43 -08002153 MockOverheadObserver mock_overhead_observer;
Erik Språng7b52f102018-02-07 14:37:37 +01002154 rtp_sender_.reset(new RTPSender(
2155 false, &fake_clock_, &transport_, nullptr, nullptr, nullptr, nullptr,
2156 nullptr, nullptr, nullptr, nullptr, nullptr,
2157 &retransmission_rate_limiter_, &mock_overhead_observer, false));
nisse7d59f6b2017-02-21 03:40:24 -08002158 rtp_sender_->SetSSRC(kSsrc);
michaelt4da30442016-11-17 01:38:43 -08002159
michaelt4da30442016-11-17 01:38:43 -08002160 // RTP overhead is 12B.
nisse284542b2017-01-10 08:58:32 -08002161 EXPECT_CALL(mock_overhead_observer, OnOverheadChanged(12)).Times(1);
michaelt4da30442016-11-17 01:38:43 -08002162 SendGenericPayload();
2163
2164 rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionTransmissionTimeOffset,
2165 kTransmissionTimeOffsetExtensionId);
2166
2167 // TransmissionTimeOffset extension has a size of 8B.
nisse284542b2017-01-10 08:58:32 -08002168 // 12B + 8B = 20B
2169 EXPECT_CALL(mock_overhead_observer, OnOverheadChanged(20)).Times(1);
michaelt4da30442016-11-17 01:38:43 -08002170 SendGenericPayload();
2171}
2172
minyue3a407ee2017-04-03 01:10:33 -07002173TEST_P(RtpSenderTest, DoesNotUpdateOverheadOnEqualSize) {
michaelt4da30442016-11-17 01:38:43 -08002174 MockOverheadObserver mock_overhead_observer;
Erik Språng7b52f102018-02-07 14:37:37 +01002175 rtp_sender_.reset(new RTPSender(
2176 false, &fake_clock_, &transport_, nullptr, nullptr, nullptr, nullptr,
2177 nullptr, nullptr, nullptr, nullptr, nullptr,
2178 &retransmission_rate_limiter_, &mock_overhead_observer, false));
nisse7d59f6b2017-02-21 03:40:24 -08002179 rtp_sender_->SetSSRC(kSsrc);
michaelt4da30442016-11-17 01:38:43 -08002180
2181 EXPECT_CALL(mock_overhead_observer, OnOverheadChanged(_)).Times(1);
michaelt4da30442016-11-17 01:38:43 -08002182 SendGenericPayload();
2183 SendGenericPayload();
2184}
2185
sprang168794c2017-07-06 04:38:06 -07002186TEST_P(RtpSenderTest, SendsKeepAlive) {
2187 MockTransport transport;
Erik Språng7b52f102018-02-07 14:37:37 +01002188 rtp_sender_.reset(
2189 new RTPSender(false, &fake_clock_, &transport, nullptr, nullptr, nullptr,
2190 nullptr, nullptr, nullptr, nullptr, &mock_rtc_event_log_,
2191 nullptr, &retransmission_rate_limiter_, nullptr, false));
sprang168794c2017-07-06 04:38:06 -07002192 rtp_sender_->SetSequenceNumber(kSeqNum);
2193 rtp_sender_->SetTimestampOffset(0);
2194 rtp_sender_->SetSSRC(kSsrc);
2195
2196 const uint8_t kKeepalivePayloadType = 20;
2197 RTC_CHECK_NE(kKeepalivePayloadType, kPayload);
2198
2199 EXPECT_CALL(transport, SendRtp(_, _, _))
2200 .WillOnce(
2201 Invoke([&kKeepalivePayloadType](const uint8_t* packet, size_t len,
2202 const PacketOptions& options) {
2203 webrtc::RTPHeader rtp_header;
2204 RtpUtility::RtpHeaderParser parser(packet, len);
2205 EXPECT_TRUE(parser.Parse(&rtp_header, nullptr));
2206 EXPECT_FALSE(rtp_header.markerBit);
2207 EXPECT_EQ(0U, rtp_header.paddingLength);
2208 EXPECT_EQ(kKeepalivePayloadType, rtp_header.payloadType);
2209 EXPECT_EQ(kSeqNum, rtp_header.sequenceNumber);
2210 EXPECT_EQ(kSsrc, rtp_header.ssrc);
2211 EXPECT_EQ(0u, len - rtp_header.headerLength);
2212 return true;
2213 }));
2214
2215 rtp_sender_->SendKeepAlive(kKeepalivePayloadType);
2216 EXPECT_EQ(kSeqNum + 1, rtp_sender_->SequenceNumber());
2217}
2218
minyue3a407ee2017-04-03 01:10:33 -07002219INSTANTIATE_TEST_CASE_P(WithAndWithoutOverhead,
2220 RtpSenderTest,
2221 ::testing::Bool());
2222INSTANTIATE_TEST_CASE_P(WithAndWithoutOverhead,
2223 RtpSenderTestWithoutPacer,
2224 ::testing::Bool());
2225INSTANTIATE_TEST_CASE_P(WithAndWithoutOverhead,
2226 RtpSenderVideoTest,
2227 ::testing::Bool());
2228INSTANTIATE_TEST_CASE_P(WithAndWithoutOverhead,
2229 RtpSenderAudioTest,
2230 ::testing::Bool());
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00002231} // namespace webrtc