blob: 90b92b3c3e26ec7081c09a5f37323d8a91988cda [file] [log] [blame]
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +00001/*
phoglund@webrtc.org78088c22012-02-07 14:56:45 +00002 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +00003 *
4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
9 */
10
Jonas Olssona4d87372019-07-05 19:08:33 +020011#include "modules/rtp_rtcp/source/rtp_sender.h"
12
kwiberg84be5112016-04-27 01:19:58 -070013#include <memory>
danilchapb8b6fbb2015-12-10 05:05:27 -080014#include <vector>
15
Danil Chapovalov16cb1f62019-09-05 11:29:59 +020016#include "api/rtc_event_log/rtc_event.h"
Per Kjellandere11b7d22019-02-21 07:55:59 +010017#include "api/transport/field_trial_based_config.h"
Erik Språngf93eda12019-01-16 17:10:57 +010018#include "api/video/video_codec_constants.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020019#include "api/video/video_timing.h"
20#include "logging/rtc_event_log/mock/mock_rtc_event_log.h"
21#include "modules/rtp_rtcp/include/rtp_cvo.h"
22#include "modules/rtp_rtcp/include/rtp_header_extension_map.h"
Erik Språngaa59eca2019-07-24 14:52:55 +020023#include "modules/rtp_rtcp/include/rtp_packet_sender.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020024#include "modules/rtp_rtcp/include/rtp_rtcp_defines.h"
25#include "modules/rtp_rtcp/source/rtcp_packet/transport_feedback.h"
26#include "modules/rtp_rtcp/source/rtp_format_video_generic.h"
philipelb3e42a42018-09-13 10:57:14 +020027#include "modules/rtp_rtcp/source/rtp_generic_frame_descriptor.h"
28#include "modules/rtp_rtcp/source/rtp_generic_frame_descriptor_extension.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020029#include "modules/rtp_rtcp/source/rtp_header_extensions.h"
30#include "modules/rtp_rtcp/source/rtp_packet_received.h"
31#include "modules/rtp_rtcp/source/rtp_packet_to_send.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020032#include "modules/rtp_rtcp/source/rtp_sender_video.h"
33#include "modules/rtp_rtcp/source/rtp_utility.h"
34#include "rtc_base/arraysize.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020035#include "rtc_base/rate_limiter.h"
36#include "test/field_trial.h"
37#include "test/gmock.h"
38#include "test/gtest.h"
39#include "test/mock_transport.h"
Tommi25eb47c2019-08-29 16:39:05 +020040#include "test/rtp_header_parser.h"
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +000041
42namespace webrtc {
43
andrew@webrtc.org8a442592011-12-16 21:24:30 +000044namespace {
Elad Alond8d32482019-02-18 23:45:57 +010045enum : int { // The first valid value is 1.
46 kAbsoluteSendTimeExtensionId = 1,
47 kAudioLevelExtensionId,
Elad Alonccb9b752019-02-19 13:01:31 +010048 kGenericDescriptorId00,
49 kGenericDescriptorId01,
Elad Alond8d32482019-02-18 23:45:57 +010050 kMidExtensionId,
51 kRepairedRidExtensionId,
52 kRidExtensionId,
53 kTransmissionTimeOffsetExtensionId,
54 kTransportSequenceNumberExtensionId,
55 kVideoRotationExtensionId,
56 kVideoTimingExtensionId,
57};
58
andrew@webrtc.org8a442592011-12-16 21:24:30 +000059const int kPayload = 100;
Shao Changbine62202f2015-04-21 20:24:50 +080060const int kRtxPayload = 98;
andrew@webrtc.org8a442592011-12-16 21:24:30 +000061const uint32_t kTimestamp = 10;
62const uint16_t kSeqNum = 33;
brandtr9dfff292016-11-14 05:14:50 -080063const uint32_t kSsrc = 725242;
Erik Språng9c771c22019-06-17 16:31:53 +020064const uint32_t kRtxSsrc = 12345;
65const uint32_t kFlexFecSsrc = 45678;
Erik Språng1fbfecd2019-08-26 19:00:05 +020066const uint16_t kTransportSequenceNumber = 1;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +000067const uint64_t kStartTime = 123456789;
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +000068const size_t kMaxPaddingSize = 224u;
Stefan Holmera246cfb2016-08-23 17:51:42 +020069const uint8_t kPayloadData[] = {47, 11, 32, 93, 89};
spranga8ae6f22017-09-04 07:23:56 -070070const int64_t kDefaultExpectedRetransmissionTimeMs = 125;
Amit Hilbuch77938e62018-12-21 09:23:38 -080071const char kNoRid[] = "";
72const char kNoMid[] = "";
andrew@webrtc.org8a442592011-12-16 21:24:30 +000073
Danil Chapovalov5e57b172016-09-02 19:15:59 +020074using ::testing::_;
Erik Språng30a276b2019-04-23 12:00:11 +020075using ::testing::AllOf;
Erik Språngea55b082019-10-02 14:57:46 +020076using ::testing::Contains;
Danil Chapovalov5e57b172016-09-02 19:15:59 +020077using ::testing::ElementsAreArray;
Erik Språng30a276b2019-04-23 12:00:11 +020078using ::testing::Field;
Erik Språng9c771c22019-06-17 16:31:53 +020079using ::testing::NiceMock;
Erik Språng478cb462019-06-26 15:49:27 +020080using ::testing::Pointee;
81using ::testing::Property;
Erik Språng214f5432019-06-20 15:09:58 +020082using ::testing::Return;
Erik Språng9c771c22019-06-17 16:31:53 +020083using ::testing::StrictMock;
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +000084
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +000085uint64_t ConvertMsToAbsSendTime(int64_t time_ms) {
Stefan Holmer0a87ffc2015-10-21 13:41:48 +020086 return (((time_ms << 18) + 500) / 1000) & 0x00ffffff;
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +000087}
88
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +000089class LoopbackTransportTest : public webrtc::Transport {
90 public:
Petter Strandmark26bc6692018-05-29 08:43:35 +020091 LoopbackTransportTest() : total_bytes_sent_(0) {
Danil Chapovalova74e4772019-09-12 17:53:04 +020092 receivers_extensions_.Register<TransmissionOffset>(
93 kTransmissionTimeOffsetExtensionId);
94 receivers_extensions_.Register<AbsoluteSendTime>(
95 kAbsoluteSendTimeExtensionId);
96 receivers_extensions_.Register<TransportSequenceNumber>(
97 kTransportSequenceNumberExtensionId);
98 receivers_extensions_.Register<VideoOrientation>(kVideoRotationExtensionId);
99 receivers_extensions_.Register<AudioLevel>(kAudioLevelExtensionId);
100 receivers_extensions_.Register<VideoTimingExtension>(
101 kVideoTimingExtensionId);
102 receivers_extensions_.Register<RtpMid>(kMidExtensionId);
103 receivers_extensions_.Register<RtpGenericFrameDescriptorExtension00>(
104 kGenericDescriptorId00);
105 receivers_extensions_.Register<RtpGenericFrameDescriptorExtension01>(
106 kGenericDescriptorId01);
107 receivers_extensions_.Register<RtpStreamId>(kRidExtensionId);
108 receivers_extensions_.Register<RepairedRtpStreamId>(
109 kRepairedRidExtensionId);
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000110 }
danilchap12ba1862016-10-26 02:41:55 -0700111
stefan1d8a5062015-10-02 03:39:33 -0700112 bool SendRtp(const uint8_t* data,
113 size_t len,
114 const PacketOptions& options) override {
Petter Strandmark26bc6692018-05-29 08:43:35 +0200115 last_options_ = options;
pkasting@chromium.org4591fbd2014-11-20 22:28:14 +0000116 total_bytes_sent_ += len;
danilchap12ba1862016-10-26 02:41:55 -0700117 sent_packets_.push_back(RtpPacketReceived(&receivers_extensions_));
118 EXPECT_TRUE(sent_packets_.back().Parse(data, len));
pbos2d566682015-09-28 09:59:31 -0700119 return true;
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000120 }
danilchap162abd32015-12-10 02:39:40 -0800121 bool SendRtcp(const uint8_t* data, size_t len) override { return false; }
danilchap12ba1862016-10-26 02:41:55 -0700122 const RtpPacketReceived& last_sent_packet() { return sent_packets_.back(); }
123 int packets_sent() { return sent_packets_.size(); }
124
pbos@webrtc.org72491b92014-07-10 16:24:54 +0000125 size_t total_bytes_sent_;
Petter Strandmark26bc6692018-05-29 08:43:35 +0200126 PacketOptions last_options_;
danilchap12ba1862016-10-26 02:41:55 -0700127 std::vector<RtpPacketReceived> sent_packets_;
128
129 private:
130 RtpHeaderExtensionMap receivers_extensions_;
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000131};
132
Elad Alon4a87e1c2017-10-03 16:11:34 +0200133MATCHER_P(SameRtcEventTypeAs, value, "") {
134 return value == arg->GetType();
135}
136
Erik Språngf6468d22019-07-05 16:53:43 +0200137struct TestConfig {
Erik Språngf5815fa2019-08-21 14:27:31 +0200138 explicit TestConfig(bool with_overhead) : with_overhead(with_overhead) {}
Erik Språngf6468d22019-07-05 16:53:43 +0200139 bool with_overhead = false;
Erik Språngf6468d22019-07-05 16:53:43 +0200140};
141
142std::string ToFieldTrialString(TestConfig config) {
143 std::string field_trials;
144 if (config.with_overhead) {
145 field_trials += "WebRTC-SendSideBwe-WithOverhead/Enabled/";
146 }
Erik Språngf6468d22019-07-05 16:53:43 +0200147 return field_trials;
148}
149
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000150} // namespace
151
Erik Språngaa59eca2019-07-24 14:52:55 +0200152class MockRtpPacketPacer : public RtpPacketSender {
sprangebbf8a82015-09-21 15:11:14 -0700153 public:
Erik Språng59b86542019-06-23 18:24:46 +0200154 MockRtpPacketPacer() {}
155 virtual ~MockRtpPacketPacer() {}
156
Erik Språngea55b082019-10-02 14:57:46 +0200157 MOCK_METHOD1(EnqueuePackets,
158 void(std::vector<std::unique_ptr<RtpPacketToSend>>));
sprangebbf8a82015-09-21 15:11:14 -0700159
Erik Språngaa59eca2019-07-24 14:52:55 +0200160 MOCK_METHOD2(CreateProbeCluster, void(int bitrate_bps, int cluster_id));
161
162 MOCK_METHOD0(Pause, void());
163 MOCK_METHOD0(Resume, void());
164 MOCK_METHOD1(SetCongestionWindow,
165 void(absl::optional<int64_t> congestion_window_bytes));
166 MOCK_METHOD1(UpdateOutstandingData, void(int64_t outstanding_bytes));
167 MOCK_METHOD1(SetAccountForAudioPackets, void(bool account_for_audio));
sprangebbf8a82015-09-21 15:11:14 -0700168};
169
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200170class MockSendSideDelayObserver : public SendSideDelayObserver {
171 public:
Henrik Boström9fe18342019-05-16 18:38:20 +0200172 MOCK_METHOD4(SendSideDelayUpdated, void(int, int, uint64_t, uint32_t));
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200173};
174
asapersson35151f32016-05-02 23:44:01 -0700175class MockSendPacketObserver : public SendPacketObserver {
176 public:
177 MOCK_METHOD3(OnSendPacket, void(uint16_t, int64_t, uint32_t));
178};
179
Stefan Holmera246cfb2016-08-23 17:51:42 +0200180class MockTransportFeedbackObserver : public TransportFeedbackObserver {
181 public:
Erik Språng30a276b2019-04-23 12:00:11 +0200182 MOCK_METHOD1(OnAddPacket, void(const RtpPacketSendInfo&));
Stefan Holmera246cfb2016-08-23 17:51:42 +0200183 MOCK_METHOD1(OnTransportFeedback, void(const rtcp::TransportFeedback&));
elad.alonf9490002017-03-06 05:32:21 -0800184 MOCK_CONST_METHOD0(GetTransportFeedbackVector, std::vector<PacketFeedback>());
Stefan Holmera246cfb2016-08-23 17:51:42 +0200185};
186
minyue3a407ee2017-04-03 01:10:33 -0700187class MockOverheadObserver : public OverheadObserver {
188 public:
189 MOCK_METHOD1(OnOverheadChanged, void(size_t overhead_bytes_per_packet));
190};
191
Erik Språngf6468d22019-07-05 16:53:43 +0200192class RtpSenderTest : public ::testing::TestWithParam<TestConfig> {
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000193 protected:
194 RtpSenderTest()
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +0000195 : fake_clock_(kStartTime),
terelius429c3452016-01-21 05:42:04 -0800196 mock_rtc_event_log_(),
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +0000197 mock_paced_sender_(),
sprangcd349d92016-07-13 09:11:28 -0700198 retransmission_rate_limiter_(&fake_clock_, 1000),
Erik Språng4580ca22019-07-04 10:38:43 +0200199 flexfec_sender_(0,
200 kFlexFecSsrc,
201 kSsrc,
202 "",
203 std::vector<RtpExtension>(),
204 std::vector<RtpExtensionSize>(),
205 nullptr,
206 &fake_clock_),
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +0000207 rtp_sender_(),
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +0000208 transport_(),
minyue3a407ee2017-04-03 01:10:33 -0700209 kMarkerBit(true),
Erik Språngf6468d22019-07-05 16:53:43 +0200210 field_trials_(ToFieldTrialString(GetParam())) {}
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +0000211
Erik Språng7b52f102018-02-07 14:37:37 +0100212 void SetUp() override { SetUpRtpSender(true, false); }
Peter Boströme23e7372015-10-08 11:44:14 +0200213
Erik Språng7b52f102018-02-07 14:37:37 +0100214 void SetUpRtpSender(bool pacer, bool populate_network2) {
Erik Språng4580ca22019-07-04 10:38:43 +0200215 RtpRtcp::Configuration config;
216 config.clock = &fake_clock_;
217 config.outgoing_transport = &transport_;
Erik Språng54d5d2c2019-08-20 17:22:36 +0200218 config.local_media_ssrc = kSsrc;
Erik Språng4580ca22019-07-04 10:38:43 +0200219 config.rtx_send_ssrc = kRtxSsrc;
220 config.flexfec_sender = &flexfec_sender_;
Erik Språng4580ca22019-07-04 10:38:43 +0200221 config.event_log = &mock_rtc_event_log_;
222 config.send_packet_observer = &send_packet_observer_;
223 config.retransmission_rate_limiter = &retransmission_rate_limiter_;
224 config.paced_sender = pacer ? &mock_paced_sender_ : nullptr;
225 config.populate_network2_timestamp = populate_network2;
226 rtp_sender_.reset(new RTPSender(config));
brandtr9dfff292016-11-14 05:14:50 -0800227 rtp_sender_->SetSequenceNumber(kSeqNum);
danilchap71fead22016-08-18 02:01:49 -0700228 rtp_sender_->SetTimestampOffset(0);
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +0000229 }
230
stefan@webrtc.orga678a3b2013-01-21 07:42:11 +0000231 SimulatedClock fake_clock_;
Erik Språng9c771c22019-06-17 16:31:53 +0200232 NiceMock<MockRtcEventLog> mock_rtc_event_log_;
Erik Språng59b86542019-06-23 18:24:46 +0200233 MockRtpPacketPacer mock_paced_sender_;
Erik Språng9c771c22019-06-17 16:31:53 +0200234 StrictMock<MockSendPacketObserver> send_packet_observer_;
235 StrictMock<MockTransportFeedbackObserver> feedback_observer_;
sprangcd349d92016-07-13 09:11:28 -0700236 RateLimiter retransmission_rate_limiter_;
Erik Språng4580ca22019-07-04 10:38:43 +0200237 FlexfecSender flexfec_sender_;
kwiberg84be5112016-04-27 01:19:58 -0700238 std::unique_ptr<RTPSender> rtp_sender_;
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000239 LoopbackTransportTest transport_;
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000240 const bool kMarkerBit;
minyue3a407ee2017-04-03 01:10:33 -0700241 test::ScopedFieldTrials field_trials_;
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000242
danilchapb6f1fb52016-10-19 06:11:39 -0700243 std::unique_ptr<RtpPacketToSend> BuildRtpPacket(int payload_type,
244 bool marker_bit,
245 uint32_t timestamp,
246 int64_t capture_time_ms) {
247 auto packet = rtp_sender_->AllocatePacket();
248 packet->SetPayloadType(payload_type);
Erik Språng60ffc312019-07-30 22:03:49 +0200249 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
danilchapb6f1fb52016-10-19 06:11:39 -0700250 packet->SetMarker(marker_bit);
251 packet->SetTimestamp(timestamp);
252 packet->set_capture_time_ms(capture_time_ms);
253 EXPECT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
254 return packet;
255 }
256
Erik Språngf6468d22019-07-05 16:53:43 +0200257 std::unique_ptr<RtpPacketToSend> SendPacket(int64_t capture_time_ms,
258 int payload_length) {
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000259 uint32_t timestamp = capture_time_ms * 90;
danilchapb6f1fb52016-10-19 06:11:39 -0700260 auto packet =
261 BuildRtpPacket(kPayload, kMarkerBit, timestamp, capture_time_ms);
262 packet->AllocatePayload(payload_length);
Erik Språng70768f42019-08-27 18:16:26 +0200263 packet->set_allow_retransmission(true);
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000264
265 // Packet should be stored in a send bucket.
Mirko Bonadei317a1f02019-09-17 17:06:18 +0200266 EXPECT_TRUE(
267 rtp_sender_->SendToNetwork(std::make_unique<RtpPacketToSend>(*packet)));
Erik Språngf6468d22019-07-05 16:53:43 +0200268 return packet;
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000269 }
asapersson35151f32016-05-02 23:44:01 -0700270
Erik Språngf6468d22019-07-05 16:53:43 +0200271 std::unique_ptr<RtpPacketToSend> SendGenericPacket() {
asapersson35151f32016-05-02 23:44:01 -0700272 const int64_t kCaptureTimeMs = fake_clock_.TimeInMilliseconds();
Erik Språngf6468d22019-07-05 16:53:43 +0200273 return SendPacket(kCaptureTimeMs, sizeof(kPayloadData));
asapersson35151f32016-05-02 23:44:01 -0700274 }
Steve Anton2bac7da2019-07-21 15:04:21 -0400275
Erik Språng4208a132019-08-26 08:58:45 +0200276 size_t GenerateAndSendPadding(size_t target_size_bytes) {
277 size_t generated_bytes = 0;
278 for (auto& packet : rtp_sender_->GeneratePadding(target_size_bytes)) {
279 generated_bytes += packet->payload_size() + packet->padding_size();
280 rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo());
281 }
282 return generated_bytes;
283 }
284
Steve Anton2bac7da2019-07-21 15:04:21 -0400285 // The following are helpers for configuring the RTPSender. They must be
286 // called before sending any packets.
287
288 // Enable the retransmission stream with sizable packet storage.
289 void EnableRtx() {
290 // RTX needs to be able to read the source packets from the packet store.
291 // Pick a number of packets to store big enough for any unit test.
292 constexpr uint16_t kNumberOfPacketsToStore = 100;
293 rtp_sender_->SetStorePacketsStatus(true, kNumberOfPacketsToStore);
294 rtp_sender_->SetRtxPayloadType(kRtxPayload, kPayload);
295 rtp_sender_->SetRtxStatus(kRtxRetransmitted | kRtxRedundantPayloads);
296 }
297
298 // Enable sending of the MID header extension for both the primary SSRC and
299 // the RTX SSRC.
300 void EnableMidSending(const std::string& mid) {
301 rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionMid, kMidExtensionId);
302 rtp_sender_->SetMid(mid);
303 }
304
305 // Enable sending of the RSID header extension for the primary SSRC and the
306 // RRSID header extension for the RTX SSRC.
307 void EnableRidSending(const std::string& rid) {
308 rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionRtpStreamId,
309 kRidExtensionId);
310 rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionRepairedRtpStreamId,
311 kRepairedRidExtensionId);
312 rtp_sender_->SetRid(rid);
313 }
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000314};
315
Peter Boströme23e7372015-10-08 11:44:14 +0200316// TODO(pbos): Move tests over from WithoutPacer to RtpSenderTest as this is our
317// default code path.
318class RtpSenderTestWithoutPacer : public RtpSenderTest {
319 public:
Erik Språng7b52f102018-02-07 14:37:37 +0100320 void SetUp() override { SetUpRtpSender(false, false); }
Peter Boströme23e7372015-10-08 11:44:14 +0200321};
322
minyue3a407ee2017-04-03 01:10:33 -0700323TEST_P(RtpSenderTestWithoutPacer, AllocatePacketSetCsrc) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200324 // Configure rtp_sender with csrc.
325 std::vector<uint32_t> csrcs;
326 csrcs.push_back(0x23456789);
327 rtp_sender_->SetCsrcs(csrcs);
328
329 auto packet = rtp_sender_->AllocatePacket();
330
331 ASSERT_TRUE(packet);
332 EXPECT_EQ(rtp_sender_->SSRC(), packet->Ssrc());
333 EXPECT_EQ(csrcs, packet->Csrcs());
334}
335
minyue3a407ee2017-04-03 01:10:33 -0700336TEST_P(RtpSenderTestWithoutPacer, AllocatePacketReserveExtensions) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200337 // Configure rtp_sender with extensions.
338 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
339 kRtpExtensionTransmissionTimeOffset,
340 kTransmissionTimeOffsetExtensionId));
341 ASSERT_EQ(
342 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
343 kAbsoluteSendTimeExtensionId));
344 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAudioLevel,
345 kAudioLevelExtensionId));
346 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
347 kRtpExtensionTransportSequenceNumber,
348 kTransportSequenceNumberExtensionId));
349 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
350 kRtpExtensionVideoRotation, kVideoRotationExtensionId));
351
352 auto packet = rtp_sender_->AllocatePacket();
353
354 ASSERT_TRUE(packet);
355 // Preallocate BWE extensions RtpSender set itself.
356 EXPECT_TRUE(packet->HasExtension<TransmissionOffset>());
357 EXPECT_TRUE(packet->HasExtension<AbsoluteSendTime>());
358 EXPECT_TRUE(packet->HasExtension<TransportSequenceNumber>());
359 // Do not allocate media specific extensions.
360 EXPECT_FALSE(packet->HasExtension<AudioLevel>());
361 EXPECT_FALSE(packet->HasExtension<VideoOrientation>());
362}
363
minyue3a407ee2017-04-03 01:10:33 -0700364TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberAdvanceSequenceNumber) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200365 auto packet = rtp_sender_->AllocatePacket();
366 ASSERT_TRUE(packet);
367 const uint16_t sequence_number = rtp_sender_->SequenceNumber();
368
369 EXPECT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
370
371 EXPECT_EQ(sequence_number, packet->SequenceNumber());
372 EXPECT_EQ(sequence_number + 1, rtp_sender_->SequenceNumber());
373}
374
minyue3a407ee2017-04-03 01:10:33 -0700375TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberFailsOnNotSending) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200376 auto packet = rtp_sender_->AllocatePacket();
377 ASSERT_TRUE(packet);
378
379 rtp_sender_->SetSendingMediaStatus(false);
380 EXPECT_FALSE(rtp_sender_->AssignSequenceNumber(packet.get()));
381}
382
Danil Chapovalovb3179c72018-03-22 10:13:07 +0100383TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberMayAllowPaddingOnVideo) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200384 constexpr size_t kPaddingSize = 100;
385 auto packet = rtp_sender_->AllocatePacket();
386 ASSERT_TRUE(packet);
387
Erik Språng4208a132019-08-26 08:58:45 +0200388 ASSERT_TRUE(rtp_sender_->GeneratePadding(kPaddingSize).empty());
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200389 packet->SetMarker(false);
390 ASSERT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
Danil Chapovalovb3179c72018-03-22 10:13:07 +0100391 // Packet without marker bit doesn't allow padding on video stream.
Erik Språng4208a132019-08-26 08:58:45 +0200392 ASSERT_TRUE(rtp_sender_->GeneratePadding(kPaddingSize).empty());
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200393
394 packet->SetMarker(true);
395 ASSERT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
396 // Packet with marker bit allows send padding.
Erik Språng4208a132019-08-26 08:58:45 +0200397 ASSERT_FALSE(rtp_sender_->GeneratePadding(kPaddingSize).empty());
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200398}
399
Danil Chapovalovb3179c72018-03-22 10:13:07 +0100400TEST_P(RtpSenderTest, AssignSequenceNumberAllowsPaddingOnAudio) {
401 MockTransport transport;
Erik Språng4580ca22019-07-04 10:38:43 +0200402 RtpRtcp::Configuration config;
403 config.audio = true;
404 config.clock = &fake_clock_;
405 config.outgoing_transport = &transport;
406 config.paced_sender = &mock_paced_sender_;
Erik Språng54d5d2c2019-08-20 17:22:36 +0200407 config.local_media_ssrc = kSsrc;
Erik Språng4580ca22019-07-04 10:38:43 +0200408 config.event_log = &mock_rtc_event_log_;
409 config.retransmission_rate_limiter = &retransmission_rate_limiter_;
Mirko Bonadei317a1f02019-09-17 17:06:18 +0200410 rtp_sender_ = std::make_unique<RTPSender>(config);
Erik Språng4580ca22019-07-04 10:38:43 +0200411
Danil Chapovalovb3179c72018-03-22 10:13:07 +0100412 rtp_sender_->SetTimestampOffset(0);
Danil Chapovalovb3179c72018-03-22 10:13:07 +0100413
414 std::unique_ptr<RtpPacketToSend> audio_packet = rtp_sender_->AllocatePacket();
415 // Padding on audio stream allowed regardless of marker in the last packet.
416 audio_packet->SetMarker(false);
417 audio_packet->SetPayloadType(kPayload);
418 rtp_sender_->AssignSequenceNumber(audio_packet.get());
419
420 const size_t kPaddingSize = 59;
421 EXPECT_CALL(transport, SendRtp(_, kPaddingSize + kRtpHeaderSize, _))
Erik Språng214f5432019-06-20 15:09:58 +0200422 .WillOnce(Return(true));
Erik Språng4208a132019-08-26 08:58:45 +0200423 EXPECT_EQ(kPaddingSize, GenerateAndSendPadding(kPaddingSize));
Danil Chapovalovb3179c72018-03-22 10:13:07 +0100424
425 // Requested padding size is too small, will send a larger one.
426 const size_t kMinPaddingSize = 50;
427 EXPECT_CALL(transport, SendRtp(_, kMinPaddingSize + kRtpHeaderSize, _))
Erik Språng214f5432019-06-20 15:09:58 +0200428 .WillOnce(Return(true));
Erik Språng4208a132019-08-26 08:58:45 +0200429 EXPECT_EQ(kMinPaddingSize, GenerateAndSendPadding(kMinPaddingSize - 5));
Danil Chapovalovb3179c72018-03-22 10:13:07 +0100430}
431
minyue3a407ee2017-04-03 01:10:33 -0700432TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberSetPaddingTimestamps) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200433 constexpr size_t kPaddingSize = 100;
434 auto packet = rtp_sender_->AllocatePacket();
435 ASSERT_TRUE(packet);
436 packet->SetMarker(true);
437 packet->SetTimestamp(kTimestamp);
438
439 ASSERT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
Erik Språng4208a132019-08-26 08:58:45 +0200440 auto padding_packets = rtp_sender_->GeneratePadding(kPaddingSize);
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200441
Erik Språng4208a132019-08-26 08:58:45 +0200442 ASSERT_EQ(1u, padding_packets.size());
danilchap12ba1862016-10-26 02:41:55 -0700443 // Verify padding packet timestamp.
Erik Språng4208a132019-08-26 08:58:45 +0200444 EXPECT_EQ(kTimestamp, padding_packets[0]->Timestamp());
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200445}
446
minyue3a407ee2017-04-03 01:10:33 -0700447TEST_P(RtpSenderTestWithoutPacer,
448 TransportFeedbackObserverGetsCorrectByteCount) {
449 constexpr int kRtpOverheadBytesPerPacket = 12 + 8;
Erik Språng9c771c22019-06-17 16:31:53 +0200450 NiceMock<MockOverheadObserver> mock_overhead_observer;
Erik Språng4580ca22019-07-04 10:38:43 +0200451
452 RtpRtcp::Configuration config;
453 config.clock = &fake_clock_;
454 config.outgoing_transport = &transport_;
Erik Språng54d5d2c2019-08-20 17:22:36 +0200455 config.local_media_ssrc = kSsrc;
Erik Språng4580ca22019-07-04 10:38:43 +0200456 config.transport_feedback_callback = &feedback_observer_;
457 config.event_log = &mock_rtc_event_log_;
458 config.retransmission_rate_limiter = &retransmission_rate_limiter_;
459 config.overhead_observer = &mock_overhead_observer;
Mirko Bonadei317a1f02019-09-17 17:06:18 +0200460 rtp_sender_ = std::make_unique<RTPSender>(config);
Erik Språng4580ca22019-07-04 10:38:43 +0200461
minyue3a407ee2017-04-03 01:10:33 -0700462 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
463 kRtpExtensionTransportSequenceNumber,
464 kTransportSequenceNumberExtensionId));
minyue3a407ee2017-04-03 01:10:33 -0700465
466 const size_t expected_bytes =
Erik Språngf6468d22019-07-05 16:53:43 +0200467 GetParam().with_overhead
468 ? sizeof(kPayloadData) + kRtpOverheadBytesPerPacket
469 : sizeof(kPayloadData);
minyue3a407ee2017-04-03 01:10:33 -0700470
471 EXPECT_CALL(feedback_observer_,
Erik Språng30a276b2019-04-23 12:00:11 +0200472 OnAddPacket(AllOf(
473 Field(&RtpPacketSendInfo::ssrc, rtp_sender_->SSRC()),
474 Field(&RtpPacketSendInfo::transport_sequence_number,
475 kTransportSequenceNumber),
476 Field(&RtpPacketSendInfo::rtp_sequence_number,
477 rtp_sender_->SequenceNumber()),
478 Field(&RtpPacketSendInfo::length, expected_bytes),
479 Field(&RtpPacketSendInfo::pacing_info, PacedPacketInfo()))))
minyue3a407ee2017-04-03 01:10:33 -0700480 .Times(1);
481 EXPECT_CALL(mock_overhead_observer,
482 OnOverheadChanged(kRtpOverheadBytesPerPacket))
483 .Times(1);
Niels Möllere7b9e6b2019-02-06 18:23:44 +0100484 SendGenericPacket();
minyue3a407ee2017-04-03 01:10:33 -0700485}
486
487TEST_P(RtpSenderTestWithoutPacer, SendsPacketsWithTransportSequenceNumber) {
Erik Språng4580ca22019-07-04 10:38:43 +0200488 RtpRtcp::Configuration config;
489 config.clock = &fake_clock_;
490 config.outgoing_transport = &transport_;
Erik Språng54d5d2c2019-08-20 17:22:36 +0200491 config.local_media_ssrc = kSsrc;
Erik Språng4580ca22019-07-04 10:38:43 +0200492 config.transport_feedback_callback = &feedback_observer_;
493 config.event_log = &mock_rtc_event_log_;
494 config.send_packet_observer = &send_packet_observer_;
495 config.retransmission_rate_limiter = &retransmission_rate_limiter_;
Mirko Bonadei317a1f02019-09-17 17:06:18 +0200496 rtp_sender_ = std::make_unique<RTPSender>(config);
Erik Språng4580ca22019-07-04 10:38:43 +0200497
Stefan Holmerf5dca482016-01-27 12:58:51 +0100498 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
499 kRtpExtensionTransportSequenceNumber,
500 kTransportSequenceNumberExtensionId));
501
asapersson35151f32016-05-02 23:44:01 -0700502 EXPECT_CALL(send_packet_observer_,
503 OnSendPacket(kTransportSequenceNumber, _, _))
504 .Times(1);
minyue3a407ee2017-04-03 01:10:33 -0700505
506 EXPECT_CALL(feedback_observer_,
Erik Språng30a276b2019-04-23 12:00:11 +0200507 OnAddPacket(AllOf(
508 Field(&RtpPacketSendInfo::ssrc, rtp_sender_->SSRC()),
509 Field(&RtpPacketSendInfo::transport_sequence_number,
510 kTransportSequenceNumber),
511 Field(&RtpPacketSendInfo::rtp_sequence_number,
512 rtp_sender_->SequenceNumber()),
513 Field(&RtpPacketSendInfo::pacing_info, PacedPacketInfo()))))
Stefan Holmera246cfb2016-08-23 17:51:42 +0200514 .Times(1);
asapersson35151f32016-05-02 23:44:01 -0700515
Niels Möllere7b9e6b2019-02-06 18:23:44 +0100516 SendGenericPacket();
Stefan Holmerf5dca482016-01-27 12:58:51 +0100517
danilchap12ba1862016-10-26 02:41:55 -0700518 const auto& packet = transport_.last_sent_packet();
519 uint16_t transport_seq_no;
520 ASSERT_TRUE(packet.GetExtension<TransportSequenceNumber>(&transport_seq_no));
521 EXPECT_EQ(kTransportSequenceNumber, transport_seq_no);
Petter Strandmark26bc6692018-05-29 08:43:35 +0200522 EXPECT_EQ(transport_.last_options_.packet_id, transport_seq_no);
Sebastian Jansson1bca65b2018-10-10 09:58:08 +0200523 EXPECT_TRUE(transport_.last_options_.included_in_allocation);
Petter Strandmark26bc6692018-05-29 08:43:35 +0200524}
525
526TEST_P(RtpSenderTestWithoutPacer, PacketOptionsNoRetransmission) {
Erik Språng4580ca22019-07-04 10:38:43 +0200527 RtpRtcp::Configuration config;
528 config.clock = &fake_clock_;
529 config.outgoing_transport = &transport_;
Erik Språng54d5d2c2019-08-20 17:22:36 +0200530 config.local_media_ssrc = kSsrc;
Erik Språng4580ca22019-07-04 10:38:43 +0200531 config.transport_feedback_callback = &feedback_observer_;
532 config.event_log = &mock_rtc_event_log_;
533 config.send_packet_observer = &send_packet_observer_;
534 config.retransmission_rate_limiter = &retransmission_rate_limiter_;
Mirko Bonadei317a1f02019-09-17 17:06:18 +0200535 rtp_sender_ = std::make_unique<RTPSender>(config);
Petter Strandmark26bc6692018-05-29 08:43:35 +0200536
Niels Möllere7b9e6b2019-02-06 18:23:44 +0100537 SendGenericPacket();
Petter Strandmark26bc6692018-05-29 08:43:35 +0200538
539 EXPECT_FALSE(transport_.last_options_.is_retransmit);
Stefan Holmerf5dca482016-01-27 12:58:51 +0100540}
541
Sebastian Jansson1bca65b2018-10-10 09:58:08 +0200542TEST_P(RtpSenderTestWithoutPacer,
543 SetsIncludedInFeedbackWhenTransportSequenceNumberExtensionIsRegistered) {
544 SetUpRtpSender(false, false);
545 rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionTransportSequenceNumber,
546 kTransportSequenceNumberExtensionId);
Sebastian Jansson1bca65b2018-10-10 09:58:08 +0200547 EXPECT_CALL(send_packet_observer_, OnSendPacket).Times(1);
Niels Möllere7b9e6b2019-02-06 18:23:44 +0100548 SendGenericPacket();
Sebastian Jansson1bca65b2018-10-10 09:58:08 +0200549 EXPECT_TRUE(transport_.last_options_.included_in_feedback);
550}
551
552TEST_P(
553 RtpSenderTestWithoutPacer,
554 SetsIncludedInAllocationWhenTransportSequenceNumberExtensionIsRegistered) {
555 SetUpRtpSender(false, false);
556 rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionTransportSequenceNumber,
557 kTransportSequenceNumberExtensionId);
Sebastian Jansson1bca65b2018-10-10 09:58:08 +0200558 EXPECT_CALL(send_packet_observer_, OnSendPacket).Times(1);
Niels Möllere7b9e6b2019-02-06 18:23:44 +0100559 SendGenericPacket();
Sebastian Jansson1bca65b2018-10-10 09:58:08 +0200560 EXPECT_TRUE(transport_.last_options_.included_in_allocation);
561}
562
563TEST_P(RtpSenderTestWithoutPacer,
564 SetsIncludedInAllocationWhenForcedAsPartOfAllocation) {
565 SetUpRtpSender(false, false);
566 rtp_sender_->SetAsPartOfAllocation(true);
Niels Möllere7b9e6b2019-02-06 18:23:44 +0100567 SendGenericPacket();
Sebastian Jansson1bca65b2018-10-10 09:58:08 +0200568 EXPECT_FALSE(transport_.last_options_.included_in_feedback);
569 EXPECT_TRUE(transport_.last_options_.included_in_allocation);
570}
571
572TEST_P(RtpSenderTestWithoutPacer, DoesnSetIncludedInAllocationByDefault) {
573 SetUpRtpSender(false, false);
Niels Möllere7b9e6b2019-02-06 18:23:44 +0100574 SendGenericPacket();
Sebastian Jansson1bca65b2018-10-10 09:58:08 +0200575 EXPECT_FALSE(transport_.last_options_.included_in_feedback);
576 EXPECT_FALSE(transport_.last_options_.included_in_allocation);
stefana23fc622016-07-28 07:56:38 -0700577}
asapersson35151f32016-05-02 23:44:01 -0700578
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200579TEST_P(RtpSenderTestWithoutPacer, OnSendSideDelayUpdated) {
Erik Språng9c771c22019-06-17 16:31:53 +0200580 StrictMock<MockSendSideDelayObserver> send_side_delay_observer_;
Erik Språng4580ca22019-07-04 10:38:43 +0200581
582 RtpRtcp::Configuration config;
583 config.clock = &fake_clock_;
584 config.outgoing_transport = &transport_;
Erik Språng54d5d2c2019-08-20 17:22:36 +0200585 config.local_media_ssrc = kSsrc;
Erik Språng4580ca22019-07-04 10:38:43 +0200586 config.send_side_delay_observer = &send_side_delay_observer_;
587 config.event_log = &mock_rtc_event_log_;
Mirko Bonadei317a1f02019-09-17 17:06:18 +0200588 rtp_sender_ = std::make_unique<RTPSender>(config);
Erik Språng4580ca22019-07-04 10:38:43 +0200589
Niels Möller5fe95102019-03-04 16:49:25 +0100590 PlayoutDelayOracle playout_delay_oracle;
Erik Språngdc34a252019-10-04 15:17:29 +0200591 FieldTrialBasedConfig field_trials;
592 RTPSenderVideo::Config video_config;
593 video_config.clock = &fake_clock_;
594 video_config.rtp_sender = rtp_sender_.get();
595 video_config.playout_delay_oracle = &playout_delay_oracle;
596 video_config.field_trials = &field_trials;
597 RTPSenderVideo rtp_sender_video(video_config);
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200598
599 const uint8_t kPayloadType = 127;
Erik Språng6cf554e2019-10-02 20:55:39 +0200600 const absl::optional<VideoCodecType> kCodecType =
601 VideoCodecType::kVideoCodecGeneric;
Niels Möller59ab1cf2019-02-06 22:48:11 +0100602
603 const uint32_t kCaptureTimeMsToRtpTimestamp = 90; // 90 kHz clock
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200604 RTPVideoHeader video_header;
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200605
Henrik Boström9fe18342019-05-16 18:38:20 +0200606 // Send packet with 10 ms send-side delay. The average, max and total should
607 // be 10 ms.
608 EXPECT_CALL(send_side_delay_observer_,
609 SendSideDelayUpdated(10, 10, 10, kSsrc))
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200610 .Times(1);
611 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
612 fake_clock_.AdvanceTimeMilliseconds(10);
Niels Möller59ab1cf2019-02-06 22:48:11 +0100613 EXPECT_TRUE(rtp_sender_video.SendVideo(
Erik Språng6cf554e2019-10-02 20:55:39 +0200614 VideoFrameType::kVideoFrameKey, kPayloadType, kCodecType,
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200615 capture_time_ms * kCaptureTimeMsToRtpTimestamp, capture_time_ms,
Niels Möller59ab1cf2019-02-06 22:48:11 +0100616 kPayloadData, sizeof(kPayloadData), nullptr, &video_header,
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200617 kDefaultExpectedRetransmissionTimeMs));
618
Henrik Boström9fe18342019-05-16 18:38:20 +0200619 // Send another packet with 20 ms delay. The average, max and total should be
620 // 15, 20 and 30 ms respectively.
621 EXPECT_CALL(send_side_delay_observer_,
622 SendSideDelayUpdated(15, 20, 30, kSsrc))
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200623 .Times(1);
624 fake_clock_.AdvanceTimeMilliseconds(10);
Niels Möller59ab1cf2019-02-06 22:48:11 +0100625 EXPECT_TRUE(rtp_sender_video.SendVideo(
Erik Språng6cf554e2019-10-02 20:55:39 +0200626 VideoFrameType::kVideoFrameKey, kPayloadType, kCodecType,
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200627 capture_time_ms * kCaptureTimeMsToRtpTimestamp, capture_time_ms,
Niels Möller59ab1cf2019-02-06 22:48:11 +0100628 kPayloadData, sizeof(kPayloadData), nullptr, &video_header,
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200629 kDefaultExpectedRetransmissionTimeMs));
630
631 // Send another packet at the same time, which replaces the last packet.
632 // Since this packet has 0 ms delay, the average is now 5 ms and max is 10 ms.
Henrik Boström9fe18342019-05-16 18:38:20 +0200633 // The total counter stays the same though.
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200634 // TODO(terelius): Is is not clear that this is the right behavior.
Henrik Boström9fe18342019-05-16 18:38:20 +0200635 EXPECT_CALL(send_side_delay_observer_, SendSideDelayUpdated(5, 10, 30, kSsrc))
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200636 .Times(1);
637 capture_time_ms = fake_clock_.TimeInMilliseconds();
Niels Möller59ab1cf2019-02-06 22:48:11 +0100638 EXPECT_TRUE(rtp_sender_video.SendVideo(
Erik Språng6cf554e2019-10-02 20:55:39 +0200639 VideoFrameType::kVideoFrameKey, kPayloadType, kCodecType,
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200640 capture_time_ms * kCaptureTimeMsToRtpTimestamp, capture_time_ms,
Niels Möller59ab1cf2019-02-06 22:48:11 +0100641 kPayloadData, sizeof(kPayloadData), nullptr, &video_header,
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200642 kDefaultExpectedRetransmissionTimeMs));
643
644 // Send a packet 1 second later. The earlier packets should have timed
Henrik Boström9fe18342019-05-16 18:38:20 +0200645 // out, so both max and average should be the delay of this packet. The total
646 // keeps increasing.
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200647 fake_clock_.AdvanceTimeMilliseconds(1000);
648 capture_time_ms = fake_clock_.TimeInMilliseconds();
649 fake_clock_.AdvanceTimeMilliseconds(1);
Henrik Boström9fe18342019-05-16 18:38:20 +0200650 EXPECT_CALL(send_side_delay_observer_, SendSideDelayUpdated(1, 1, 31, kSsrc))
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200651 .Times(1);
Niels Möller59ab1cf2019-02-06 22:48:11 +0100652 EXPECT_TRUE(rtp_sender_video.SendVideo(
Erik Språng6cf554e2019-10-02 20:55:39 +0200653 VideoFrameType::kVideoFrameKey, kPayloadType, kCodecType,
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200654 capture_time_ms * kCaptureTimeMsToRtpTimestamp, capture_time_ms,
Niels Möller59ab1cf2019-02-06 22:48:11 +0100655 kPayloadData, sizeof(kPayloadData), nullptr, &video_header,
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200656 kDefaultExpectedRetransmissionTimeMs));
657}
658
minyue3a407ee2017-04-03 01:10:33 -0700659TEST_P(RtpSenderTestWithoutPacer, OnSendPacketUpdated) {
stefana23fc622016-07-28 07:56:38 -0700660 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
661 kRtpExtensionTransportSequenceNumber,
662 kTransportSequenceNumberExtensionId));
asapersson35151f32016-05-02 23:44:01 -0700663 EXPECT_CALL(send_packet_observer_,
664 OnSendPacket(kTransportSequenceNumber, _, _))
665 .Times(1);
666
Niels Möllere7b9e6b2019-02-06 18:23:44 +0100667 SendGenericPacket();
asapersson35151f32016-05-02 23:44:01 -0700668}
669
minyue3a407ee2017-04-03 01:10:33 -0700670TEST_P(RtpSenderTest, SendsPacketsWithTransportSequenceNumber) {
Erik Språng4580ca22019-07-04 10:38:43 +0200671 RtpRtcp::Configuration config;
672 config.clock = &fake_clock_;
673 config.outgoing_transport = &transport_;
674 config.paced_sender = &mock_paced_sender_;
Erik Språng54d5d2c2019-08-20 17:22:36 +0200675 config.local_media_ssrc = kSsrc;
Erik Språng4580ca22019-07-04 10:38:43 +0200676 config.transport_feedback_callback = &feedback_observer_;
677 config.event_log = &mock_rtc_event_log_;
678 config.send_packet_observer = &send_packet_observer_;
679 config.retransmission_rate_limiter = &retransmission_rate_limiter_;
Mirko Bonadei317a1f02019-09-17 17:06:18 +0200680 rtp_sender_ = std::make_unique<RTPSender>(config);
Erik Språng4580ca22019-07-04 10:38:43 +0200681
brandtr9dfff292016-11-14 05:14:50 -0800682 rtp_sender_->SetSequenceNumber(kSeqNum);
Stefan Holmera246cfb2016-08-23 17:51:42 +0200683 rtp_sender_->SetStorePacketsStatus(true, 10);
684 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
685 kRtpExtensionTransportSequenceNumber,
686 kTransportSequenceNumberExtensionId));
687
Stefan Holmera246cfb2016-08-23 17:51:42 +0200688 EXPECT_CALL(send_packet_observer_,
689 OnSendPacket(kTransportSequenceNumber, _, _))
690 .Times(1);
minyue3a407ee2017-04-03 01:10:33 -0700691 EXPECT_CALL(feedback_observer_,
Erik Språng30a276b2019-04-23 12:00:11 +0200692 OnAddPacket(AllOf(
693 Field(&RtpPacketSendInfo::ssrc, rtp_sender_->SSRC()),
694 Field(&RtpPacketSendInfo::transport_sequence_number,
695 kTransportSequenceNumber),
696 Field(&RtpPacketSendInfo::rtp_sequence_number,
697 rtp_sender_->SequenceNumber()),
698 Field(&RtpPacketSendInfo::pacing_info, PacedPacketInfo()))))
Stefan Holmera246cfb2016-08-23 17:51:42 +0200699 .Times(1);
700
Erik Språngf5815fa2019-08-21 14:27:31 +0200701 EXPECT_CALL(
702 mock_paced_sender_,
Erik Språngea55b082019-10-02 14:57:46 +0200703 EnqueuePackets(Contains(AllOf(
704 Pointee(Property(&RtpPacketToSend::Ssrc, kSsrc)),
705 Pointee(Property(&RtpPacketToSend::SequenceNumber, kSeqNum))))));
Erik Språngf5815fa2019-08-21 14:27:31 +0200706 auto packet = SendGenericPacket();
707 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
708 // Transport sequence number is set by PacketRouter, before TrySendPacket().
709 packet->SetExtension<TransportSequenceNumber>(kTransportSequenceNumber);
710 rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo());
Stefan Holmera246cfb2016-08-23 17:51:42 +0200711
danilchap12ba1862016-10-26 02:41:55 -0700712 uint16_t transport_seq_no;
Erik Språngf5815fa2019-08-21 14:27:31 +0200713 EXPECT_TRUE(
714 transport_.last_sent_packet().GetExtension<TransportSequenceNumber>(
715 &transport_seq_no));
danilchap12ba1862016-10-26 02:41:55 -0700716 EXPECT_EQ(kTransportSequenceNumber, transport_seq_no);
Petter Strandmark26bc6692018-05-29 08:43:35 +0200717 EXPECT_EQ(transport_.last_options_.packet_id, transport_seq_no);
Stefan Holmera246cfb2016-08-23 17:51:42 +0200718}
719
Erik Språng7b52f102018-02-07 14:37:37 +0100720TEST_P(RtpSenderTest, WritesPacerExitToTimingExtension) {
ilnik04f4d122017-06-19 07:18:55 -0700721 rtp_sender_->SetStorePacketsStatus(true, 10);
722 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
723 kRtpExtensionVideoTiming, kVideoTimingExtensionId));
724 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
725 auto packet = rtp_sender_->AllocatePacket();
726 packet->SetPayloadType(kPayload);
727 packet->SetMarker(true);
728 packet->SetTimestamp(kTimestamp);
729 packet->set_capture_time_ms(capture_time_ms);
ilnik2edc6842017-07-06 03:06:50 -0700730 const VideoSendTiming kVideoTiming = {0u, 0u, 0u, 0u, 0u, 0u, true};
ilnik04f4d122017-06-19 07:18:55 -0700731 packet->SetExtension<VideoTimingExtension>(kVideoTiming);
732 EXPECT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
733 size_t packet_size = packet->size();
ilnik04f4d122017-06-19 07:18:55 -0700734
735 const int kStoredTimeInMs = 100;
Erik Språngf5815fa2019-08-21 14:27:31 +0200736 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
Erik Språng70768f42019-08-27 18:16:26 +0200737 packet->set_allow_retransmission(true);
Erik Språngea55b082019-10-02 14:57:46 +0200738 EXPECT_CALL(mock_paced_sender_, EnqueuePackets(Contains(Pointee(Property(
739 &RtpPacketToSend::Ssrc, kSsrc)))));
Erik Språng70768f42019-08-27 18:16:26 +0200740 EXPECT_TRUE(
Mirko Bonadei317a1f02019-09-17 17:06:18 +0200741 rtp_sender_->SendToNetwork(std::make_unique<RtpPacketToSend>(*packet)));
Erik Språngf5815fa2019-08-21 14:27:31 +0200742 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
743 rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo());
ilnik04f4d122017-06-19 07:18:55 -0700744 EXPECT_EQ(1, transport_.packets_sent());
745 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
746
danilchapce251812017-09-11 12:24:41 -0700747 VideoSendTiming video_timing;
748 EXPECT_TRUE(transport_.last_sent_packet().GetExtension<VideoTimingExtension>(
749 &video_timing));
750 EXPECT_EQ(kStoredTimeInMs, video_timing.pacer_exit_delta_ms);
Erik Språng7b52f102018-02-07 14:37:37 +0100751}
ilnik04f4d122017-06-19 07:18:55 -0700752
Danil Chapovalovaf52b682018-11-27 10:48:27 +0100753TEST_P(RtpSenderTest, WritesNetwork2ToTimingExtensionWithPacer) {
754 SetUpRtpSender(/*pacer=*/true, /*populate_network2=*/true);
Erik Språng7b52f102018-02-07 14:37:37 +0100755 rtp_sender_->SetStorePacketsStatus(true, 10);
756 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
757 kRtpExtensionVideoTiming, kVideoTimingExtensionId));
758 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
759 auto packet = rtp_sender_->AllocatePacket();
760 packet->SetPayloadType(kPayload);
761 packet->SetMarker(true);
762 packet->SetTimestamp(kTimestamp);
763 packet->set_capture_time_ms(capture_time_ms);
764 const uint16_t kPacerExitMs = 1234u;
765 const VideoSendTiming kVideoTiming = {0u, 0u, 0u, kPacerExitMs, 0u, 0u, true};
766 packet->SetExtension<VideoTimingExtension>(kVideoTiming);
767 EXPECT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
768 size_t packet_size = packet->size();
769
770 const int kStoredTimeInMs = 100;
Erik Språngf6468d22019-07-05 16:53:43 +0200771
Erik Språngf6468d22019-07-05 16:53:43 +0200772 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
Erik Språng70768f42019-08-27 18:16:26 +0200773 packet->set_allow_retransmission(true);
Erik Språngea55b082019-10-02 14:57:46 +0200774 EXPECT_CALL(mock_paced_sender_, EnqueuePackets(Contains(Pointee(Property(
775 &RtpPacketToSend::Ssrc, kSsrc)))));
Mirko Bonadei317a1f02019-09-17 17:06:18 +0200776 EXPECT_TRUE(
777 rtp_sender_->SendToNetwork(std::make_unique<RtpPacketToSend>(*packet)));
Erik Språngf6468d22019-07-05 16:53:43 +0200778 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
779 rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo());
Erik Språngf6468d22019-07-05 16:53:43 +0200780
Erik Språng7b52f102018-02-07 14:37:37 +0100781 EXPECT_EQ(1, transport_.packets_sent());
ilnik04f4d122017-06-19 07:18:55 -0700782 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
783
Erik Språng7b52f102018-02-07 14:37:37 +0100784 VideoSendTiming video_timing;
danilchapce251812017-09-11 12:24:41 -0700785 EXPECT_TRUE(transport_.last_sent_packet().GetExtension<VideoTimingExtension>(
786 &video_timing));
Erik Språng7b52f102018-02-07 14:37:37 +0100787 EXPECT_EQ(kStoredTimeInMs, video_timing.network2_timestamp_delta_ms);
788 EXPECT_EQ(kPacerExitMs, video_timing.pacer_exit_delta_ms);
ilnik04f4d122017-06-19 07:18:55 -0700789}
790
Danil Chapovalovaf52b682018-11-27 10:48:27 +0100791TEST_P(RtpSenderTest, WritesNetwork2ToTimingExtensionWithoutPacer) {
792 SetUpRtpSender(/*pacer=*/false, /*populate_network2=*/true);
793 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
794 kRtpExtensionVideoTiming, kVideoTimingExtensionId));
795 auto packet = rtp_sender_->AllocatePacket();
796 packet->SetMarker(true);
797 packet->set_capture_time_ms(fake_clock_.TimeInMilliseconds());
798 const VideoSendTiming kVideoTiming = {0u, 0u, 0u, 0u, 0u, 0u, true};
799 packet->SetExtension<VideoTimingExtension>(kVideoTiming);
Erik Språng70768f42019-08-27 18:16:26 +0200800 packet->set_allow_retransmission(true);
Danil Chapovalovaf52b682018-11-27 10:48:27 +0100801 EXPECT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
Erik Språng1fbfecd2019-08-26 19:00:05 +0200802 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
Danil Chapovalovaf52b682018-11-27 10:48:27 +0100803
804 const int kPropagateTimeMs = 10;
805 fake_clock_.AdvanceTimeMilliseconds(kPropagateTimeMs);
806
Erik Språng70768f42019-08-27 18:16:26 +0200807 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet)));
Danil Chapovalovaf52b682018-11-27 10:48:27 +0100808
809 EXPECT_EQ(1, transport_.packets_sent());
810 absl::optional<VideoSendTiming> video_timing =
811 transport_.last_sent_packet().GetExtension<VideoTimingExtension>();
812 ASSERT_TRUE(video_timing);
813 EXPECT_EQ(kPropagateTimeMs, video_timing->network2_timestamp_delta_ms);
814}
815
minyue3a407ee2017-04-03 01:10:33 -0700816TEST_P(RtpSenderTest, TrafficSmoothingWithExtensions) {
Elad Alon4a87e1c2017-10-03 16:11:34 +0200817 EXPECT_CALL(mock_rtc_event_log_,
818 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)));
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000819
pwestin@webrtc.orgc66e8b32012-11-07 17:01:04 +0000820 rtp_sender_->SetStorePacketsStatus(true, 10);
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000821 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
danilchap162abd32015-12-10 02:39:40 -0800822 kRtpExtensionTransmissionTimeOffset,
823 kTransmissionTimeOffsetExtensionId));
824 EXPECT_EQ(
825 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
826 kAbsoluteSendTimeExtensionId));
stefan@webrtc.org8ccb9f92013-06-19 14:13:42 +0000827 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
danilchapb6f1fb52016-10-19 06:11:39 -0700828 auto packet =
829 BuildRtpPacket(kPayload, kMarkerBit, kTimestamp, capture_time_ms);
830 size_t packet_size = packet->size();
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000831
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000832 const int kStoredTimeInMs = 100;
Erik Språngea55b082019-10-02 14:57:46 +0200833 EXPECT_CALL(
834 mock_paced_sender_,
835 EnqueuePackets(Contains(AllOf(
836 Pointee(Property(&RtpPacketToSend::Ssrc, kSsrc)),
837 Pointee(Property(&RtpPacketToSend::SequenceNumber, kSeqNum))))));
838 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
839 packet->set_allow_retransmission(true);
840 EXPECT_TRUE(
841 rtp_sender_->SendToNetwork(std::make_unique<RtpPacketToSend>(*packet)));
842 EXPECT_EQ(0, transport_.packets_sent());
843 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
844 rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000845
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000846 // Process send bucket. Packet should now be sent.
danilchap12ba1862016-10-26 02:41:55 -0700847 EXPECT_EQ(1, transport_.packets_sent());
848 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
849
stefan@webrtc.orga5cb98c2013-05-29 12:12:51 +0000850 webrtc::RTPHeader rtp_header;
danilchap12ba1862016-10-26 02:41:55 -0700851 transport_.last_sent_packet().GetHeader(&rtp_header);
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000852
853 // Verify transmission time offset.
854 EXPECT_EQ(kStoredTimeInMs * 90, rtp_header.extension.transmissionTimeOffset);
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000855 uint64_t expected_send_time =
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000856 ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds());
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000857 EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime);
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000858}
859
minyue3a407ee2017-04-03 01:10:33 -0700860TEST_P(RtpSenderTest, TrafficSmoothingRetransmits) {
Elad Alon4a87e1c2017-10-03 16:11:34 +0200861 EXPECT_CALL(mock_rtc_event_log_,
862 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)));
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000863
864 rtp_sender_->SetStorePacketsStatus(true, 10);
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000865 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
danilchap162abd32015-12-10 02:39:40 -0800866 kRtpExtensionTransmissionTimeOffset,
867 kTransmissionTimeOffsetExtensionId));
868 EXPECT_EQ(
869 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
870 kAbsoluteSendTimeExtensionId));
stefan@webrtc.org8ccb9f92013-06-19 14:13:42 +0000871 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
danilchapb6f1fb52016-10-19 06:11:39 -0700872 auto packet =
873 BuildRtpPacket(kPayload, kMarkerBit, kTimestamp, capture_time_ms);
874 size_t packet_size = packet->size();
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000875
876 // Packet should be stored in a send bucket.
Erik Språngea55b082019-10-02 14:57:46 +0200877 EXPECT_CALL(
878 mock_paced_sender_,
879 EnqueuePackets(Contains(AllOf(
880 Pointee(Property(&RtpPacketToSend::Ssrc, kSsrc)),
881 Pointee(Property(&RtpPacketToSend::SequenceNumber, kSeqNum))))));
882 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
883 packet->set_allow_retransmission(true);
884 EXPECT_TRUE(
885 rtp_sender_->SendToNetwork(std::make_unique<RtpPacketToSend>(*packet)));
886 // Immediately process send bucket and send packet.
887 rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo());
Erik Språngf6468d22019-07-05 16:53:43 +0200888
Erik Språng0f4f0552019-05-08 10:15:05 -0700889 EXPECT_EQ(1, transport_.packets_sent());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000890
Erik Språng0f4f0552019-05-08 10:15:05 -0700891 // Retransmit packet.
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000892 const int kStoredTimeInMs = 100;
893 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
894
Erik Språng0f4f0552019-05-08 10:15:05 -0700895 EXPECT_CALL(mock_rtc_event_log_,
896 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)));
Erik Språngf6468d22019-07-05 16:53:43 +0200897 packet->set_packet_type(RtpPacketToSend::Type::kRetransmission);
898 packet->set_retransmitted_sequence_number(kSeqNum);
899 EXPECT_CALL(
900 mock_paced_sender_,
Erik Språngea55b082019-10-02 14:57:46 +0200901 EnqueuePackets(Contains(AllOf(
Erik Språngf6468d22019-07-05 16:53:43 +0200902 Pointee(Property(&RtpPacketToSend::Ssrc, kSsrc)),
Erik Språngea55b082019-10-02 14:57:46 +0200903 Pointee(Property(&RtpPacketToSend::SequenceNumber, kSeqNum))))));
Erik Språngf6468d22019-07-05 16:53:43 +0200904 EXPECT_EQ(static_cast<int>(packet_size),
905 rtp_sender_->ReSendPacket(kSeqNum));
906 EXPECT_EQ(1, transport_.packets_sent());
907 rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000908
909 // Process send bucket. Packet should now be sent.
Erik Språng0f4f0552019-05-08 10:15:05 -0700910 EXPECT_EQ(2, transport_.packets_sent());
danilchap12ba1862016-10-26 02:41:55 -0700911 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000912
stefan@webrtc.orga5cb98c2013-05-29 12:12:51 +0000913 webrtc::RTPHeader rtp_header;
danilchap12ba1862016-10-26 02:41:55 -0700914 transport_.last_sent_packet().GetHeader(&rtp_header);
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000915
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000916 // Verify transmission time offset.
917 EXPECT_EQ(kStoredTimeInMs * 90, rtp_header.extension.transmissionTimeOffset);
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000918 uint64_t expected_send_time =
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000919 ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds());
920 EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime);
921}
922
923// This test sends 1 regular video packet, then 4 padding packets, and then
924// 1 more regular packet.
minyue3a407ee2017-04-03 01:10:33 -0700925TEST_P(RtpSenderTest, SendPadding) {
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000926 // Make all (non-padding) packets go to send queue.
Elad Alon4a87e1c2017-10-03 16:11:34 +0200927 EXPECT_CALL(mock_rtc_event_log_,
928 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
929 .Times(1 + 4 + 1);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000930
931 uint16_t seq_num = kSeqNum;
932 uint32_t timestamp = kTimestamp;
933 rtp_sender_->SetStorePacketsStatus(true, 10);
pkasting@chromium.org4591fbd2014-11-20 22:28:14 +0000934 size_t rtp_header_len = kRtpHeaderSize;
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000935 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
danilchap162abd32015-12-10 02:39:40 -0800936 kRtpExtensionTransmissionTimeOffset,
937 kTransmissionTimeOffsetExtensionId));
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000938 rtp_header_len += 4; // 4 bytes extension.
danilchap162abd32015-12-10 02:39:40 -0800939 EXPECT_EQ(
940 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
941 kAbsoluteSendTimeExtensionId));
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000942 rtp_header_len += 4; // 4 bytes extension.
943 rtp_header_len += 4; // 4 extra bytes common to all extension headers.
944
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000945 webrtc::RTPHeader rtp_header;
946
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000947 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
danilchapb6f1fb52016-10-19 06:11:39 -0700948 auto packet =
949 BuildRtpPacket(kPayload, kMarkerBit, timestamp, capture_time_ms);
Stefan Holmer586b19b2015-09-18 11:14:31 +0200950 const uint32_t media_packet_timestamp = timestamp;
danilchapb6f1fb52016-10-19 06:11:39 -0700951 size_t packet_size = packet->size();
Erik Språngf6468d22019-07-05 16:53:43 +0200952 int total_packets_sent = 0;
953 const int kStoredTimeInMs = 100;
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000954
955 // Packet should be stored in a send bucket.
Erik Språngea55b082019-10-02 14:57:46 +0200956 EXPECT_CALL(
957 mock_paced_sender_,
958 EnqueuePackets(Contains(AllOf(
959 Pointee(Property(&RtpPacketToSend::Ssrc, kSsrc)),
960 Pointee(Property(&RtpPacketToSend::SequenceNumber, kSeqNum))))));
961 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
962 packet->set_allow_retransmission(true);
963 EXPECT_TRUE(
964 rtp_sender_->SendToNetwork(std::make_unique<RtpPacketToSend>(*packet)));
965 EXPECT_EQ(total_packets_sent, transport_.packets_sent());
966 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
967 rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo());
968 ++seq_num;
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000969
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000970 // Packet should now be sent. This test doesn't verify the regular video
971 // packet, since it is tested in another test.
danilchap12ba1862016-10-26 02:41:55 -0700972 EXPECT_EQ(++total_packets_sent, transport_.packets_sent());
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000973 timestamp += 90 * kStoredTimeInMs;
974
975 // Send padding 4 times, waiting 50 ms between each.
976 for (int i = 0; i < 4; ++i) {
977 const int kPaddingPeriodMs = 50;
pkasting@chromium.org4591fbd2014-11-20 22:28:14 +0000978 const size_t kPaddingBytes = 100;
979 const size_t kMaxPaddingLength = 224; // Value taken from rtp_sender.cc.
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000980 // Padding will be forced to full packets.
Erik Språng4208a132019-08-26 08:58:45 +0200981 EXPECT_EQ(kMaxPaddingLength, GenerateAndSendPadding(kPaddingBytes));
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000982
983 // Process send bucket. Padding should now be sent.
danilchap12ba1862016-10-26 02:41:55 -0700984 EXPECT_EQ(++total_packets_sent, transport_.packets_sent());
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000985 EXPECT_EQ(kMaxPaddingLength + rtp_header_len,
danilchap12ba1862016-10-26 02:41:55 -0700986 transport_.last_sent_packet().size());
987
988 transport_.last_sent_packet().GetHeader(&rtp_header);
pbosbd2522a2015-07-01 05:35:53 -0700989 EXPECT_EQ(kMaxPaddingLength, rtp_header.paddingLength);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000990
Stefan Holmer586b19b2015-09-18 11:14:31 +0200991 // Verify sequence number and timestamp. The timestamp should be the same
992 // as the last media packet.
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000993 EXPECT_EQ(seq_num++, rtp_header.sequenceNumber);
Stefan Holmer586b19b2015-09-18 11:14:31 +0200994 EXPECT_EQ(media_packet_timestamp, rtp_header.timestamp);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000995 // Verify transmission time offset.
Stefan Holmer586b19b2015-09-18 11:14:31 +0200996 int offset = timestamp - media_packet_timestamp;
997 EXPECT_EQ(offset, rtp_header.extension.transmissionTimeOffset);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000998 uint64_t expected_send_time =
999 ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds());
1000 EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime);
1001 fake_clock_.AdvanceTimeMilliseconds(kPaddingPeriodMs);
1002 timestamp += 90 * kPaddingPeriodMs;
1003 }
1004
1005 // Send a regular video packet again.
1006 capture_time_ms = fake_clock_.TimeInMilliseconds();
danilchapb6f1fb52016-10-19 06:11:39 -07001007 packet = BuildRtpPacket(kPayload, kMarkerBit, timestamp, capture_time_ms);
1008 packet_size = packet->size();
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +00001009
Erik Språngf6468d22019-07-05 16:53:43 +02001010 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
Erik Språng70768f42019-08-27 18:16:26 +02001011 packet->set_allow_retransmission(true);
Erik Språngf6468d22019-07-05 16:53:43 +02001012 EXPECT_CALL(
1013 mock_paced_sender_,
Erik Språngea55b082019-10-02 14:57:46 +02001014 EnqueuePackets(Contains(AllOf(
Erik Språngf6468d22019-07-05 16:53:43 +02001015 Pointee(Property(&RtpPacketToSend::Ssrc, kSsrc)),
Erik Språngea55b082019-10-02 14:57:46 +02001016 Pointee(Property(&RtpPacketToSend::SequenceNumber, seq_num))))));
Mirko Bonadei317a1f02019-09-17 17:06:18 +02001017 EXPECT_TRUE(
1018 rtp_sender_->SendToNetwork(std::make_unique<RtpPacketToSend>(*packet)));
Erik Språngf6468d22019-07-05 16:53:43 +02001019 rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo());
terelius5d332ac2016-01-14 14:37:39 -08001020
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +00001021 // Process send bucket.
danilchap12ba1862016-10-26 02:41:55 -07001022 EXPECT_EQ(++total_packets_sent, transport_.packets_sent());
1023 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
1024 transport_.last_sent_packet().GetHeader(&rtp_header);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +00001025
1026 // Verify sequence number and timestamp.
1027 EXPECT_EQ(seq_num, rtp_header.sequenceNumber);
1028 EXPECT_EQ(timestamp, rtp_header.timestamp);
1029 // Verify transmission time offset. This packet is sent without delay.
1030 EXPECT_EQ(0, rtp_header.extension.transmissionTimeOffset);
1031 uint64_t expected_send_time =
1032 ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds());
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +00001033 EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime);
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +00001034}
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001035
minyue3a407ee2017-04-03 01:10:33 -07001036TEST_P(RtpSenderTest, OnSendPacketUpdated) {
stefana23fc622016-07-28 07:56:38 -07001037 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
1038 kRtpExtensionTransportSequenceNumber,
1039 kTransportSequenceNumberExtensionId));
asapersson35151f32016-05-02 23:44:01 -07001040 rtp_sender_->SetStorePacketsStatus(true, 10);
1041
1042 EXPECT_CALL(send_packet_observer_,
1043 OnSendPacket(kTransportSequenceNumber, _, _))
1044 .Times(1);
asapersson35151f32016-05-02 23:44:01 -07001045
Erik Språngea55b082019-10-02 14:57:46 +02001046 EXPECT_CALL(
1047 mock_paced_sender_,
1048 EnqueuePackets(Contains(AllOf(
1049 Pointee(Property(&RtpPacketToSend::Ssrc, kSsrc)),
1050 Pointee(Property(&RtpPacketToSend::SequenceNumber, kSeqNum))))));
1051 auto packet = SendGenericPacket();
1052 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
1053 packet->SetExtension<TransportSequenceNumber>(kTransportSequenceNumber);
1054 rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo());
Erik Språngf6468d22019-07-05 16:53:43 +02001055
danilchap12ba1862016-10-26 02:41:55 -07001056 EXPECT_EQ(1, transport_.packets_sent());
asapersson35151f32016-05-02 23:44:01 -07001057}
1058
minyue3a407ee2017-04-03 01:10:33 -07001059TEST_P(RtpSenderTest, OnSendPacketNotUpdatedForRetransmits) {
stefana23fc622016-07-28 07:56:38 -07001060 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
1061 kRtpExtensionTransportSequenceNumber,
1062 kTransportSequenceNumberExtensionId));
asapersson35151f32016-05-02 23:44:01 -07001063 rtp_sender_->SetStorePacketsStatus(true, 10);
1064
1065 EXPECT_CALL(send_packet_observer_, OnSendPacket(_, _, _)).Times(0);
asapersson35151f32016-05-02 23:44:01 -07001066
Erik Språngea55b082019-10-02 14:57:46 +02001067 EXPECT_CALL(
1068 mock_paced_sender_,
1069 EnqueuePackets(Contains(AllOf(
1070 Pointee(Property(&RtpPacketToSend::Ssrc, kSsrc)),
1071 Pointee(Property(&RtpPacketToSend::SequenceNumber, kSeqNum))))));
1072 auto packet = SendGenericPacket();
1073 packet->set_packet_type(RtpPacketToSend::Type::kRetransmission);
1074 packet->SetExtension<TransportSequenceNumber>(kTransportSequenceNumber);
1075 rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo());
Erik Språngf6468d22019-07-05 16:53:43 +02001076
danilchap12ba1862016-10-26 02:41:55 -07001077 EXPECT_EQ(1, transport_.packets_sent());
Petter Strandmark26bc6692018-05-29 08:43:35 +02001078 EXPECT_TRUE(transport_.last_options_.is_retransmit);
asapersson35151f32016-05-02 23:44:01 -07001079}
1080
minyue3a407ee2017-04-03 01:10:33 -07001081TEST_P(RtpSenderTestWithoutPacer, SendGenericVideo) {
Erik Språng6cf554e2019-10-02 20:55:39 +02001082 const uint8_t kPayloadType = 127;
1083 const VideoCodecType kCodecType = VideoCodecType::kVideoCodecGeneric;
Niels Möller5fe95102019-03-04 16:49:25 +01001084 PlayoutDelayOracle playout_delay_oracle;
Erik Språngdc34a252019-10-04 15:17:29 +02001085 FieldTrialBasedConfig field_trials;
1086 RTPSenderVideo::Config video_config;
1087 video_config.clock = &fake_clock_;
1088 video_config.rtp_sender = rtp_sender_.get();
1089 video_config.playout_delay_oracle = &playout_delay_oracle;
1090 video_config.field_trials = &field_trials;
1091 RTPSenderVideo rtp_sender_video(video_config);
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001092 uint8_t payload[] = {47, 11, 32, 93, 89};
1093
1094 // Send keyframe
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001095 RTPVideoHeader video_header;
Niels Möller59ab1cf2019-02-06 22:48:11 +01001096 ASSERT_TRUE(rtp_sender_video.SendVideo(
Erik Språng6cf554e2019-10-02 20:55:39 +02001097 VideoFrameType::kVideoFrameKey, kPayloadType, kCodecType, 1234, 4321,
1098 payload, sizeof(payload), nullptr, &video_header,
Niels Möller8f7ce222019-03-21 15:43:58 +01001099 kDefaultExpectedRetransmissionTimeMs));
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001100
danilchap96c15872016-11-21 01:35:29 -08001101 auto sent_payload = transport_.last_sent_packet().payload();
1102 uint8_t generic_header = sent_payload[0];
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001103 EXPECT_TRUE(generic_header & RtpFormatVideoGeneric::kKeyFrameBit);
1104 EXPECT_TRUE(generic_header & RtpFormatVideoGeneric::kFirstPacketBit);
danilchap96c15872016-11-21 01:35:29 -08001105 EXPECT_THAT(sent_payload.subview(1), ElementsAreArray(payload));
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001106
1107 // Send delta frame
1108 payload[0] = 13;
1109 payload[1] = 42;
1110 payload[4] = 13;
1111
Niels Möller59ab1cf2019-02-06 22:48:11 +01001112 ASSERT_TRUE(rtp_sender_video.SendVideo(
Erik Språng6cf554e2019-10-02 20:55:39 +02001113 VideoFrameType::kVideoFrameDelta, kPayloadType, kCodecType, 1234, 4321,
1114 payload, sizeof(payload), nullptr, &video_header,
Niels Möller8f7ce222019-03-21 15:43:58 +01001115 kDefaultExpectedRetransmissionTimeMs));
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001116
danilchap96c15872016-11-21 01:35:29 -08001117 sent_payload = transport_.last_sent_packet().payload();
1118 generic_header = sent_payload[0];
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001119 EXPECT_FALSE(generic_header & RtpFormatVideoGeneric::kKeyFrameBit);
1120 EXPECT_TRUE(generic_header & RtpFormatVideoGeneric::kFirstPacketBit);
danilchap96c15872016-11-21 01:35:29 -08001121 EXPECT_THAT(sent_payload.subview(1), ElementsAreArray(payload));
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001122}
1123
Mirta Dvornicicfe68daa2019-05-23 13:21:12 +02001124TEST_P(RtpSenderTestWithoutPacer, SendRawVideo) {
Erik Språng6cf554e2019-10-02 20:55:39 +02001125 const uint8_t kPayloadType = 111;
Mirta Dvornicicfe68daa2019-05-23 13:21:12 +02001126 const uint8_t payload[] = {11, 22, 33, 44, 55};
1127
1128 PlayoutDelayOracle playout_delay_oracle;
Erik Språngdc34a252019-10-04 15:17:29 +02001129 FieldTrialBasedConfig field_trials;
1130 RTPSenderVideo::Config video_config;
1131 video_config.clock = &fake_clock_;
1132 video_config.rtp_sender = rtp_sender_.get();
1133 video_config.playout_delay_oracle = &playout_delay_oracle;
1134 video_config.field_trials = &field_trials;
1135 RTPSenderVideo rtp_sender_video(video_config);
Mirta Dvornicicfe68daa2019-05-23 13:21:12 +02001136
1137 // Send a frame.
1138 RTPVideoHeader video_header;
1139 ASSERT_TRUE(rtp_sender_video.SendVideo(
Erik Språng6cf554e2019-10-02 20:55:39 +02001140 VideoFrameType::kVideoFrameKey, kPayloadType, absl::nullopt, 1234, 4321,
1141 payload, sizeof(payload), nullptr, &video_header,
Mirta Dvornicicfe68daa2019-05-23 13:21:12 +02001142 kDefaultExpectedRetransmissionTimeMs));
1143
1144 auto sent_payload = transport_.last_sent_packet().payload();
1145 EXPECT_THAT(sent_payload, ElementsAreArray(payload));
1146}
1147
minyue3a407ee2017-04-03 01:10:33 -07001148TEST_P(RtpSenderTest, SendFlexfecPackets) {
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001149 constexpr uint32_t kTimestamp = 1234;
brandtrdbdb3f12016-11-10 05:04:48 -08001150 constexpr int kMediaPayloadType = 127;
Erik Språng6cf554e2019-10-02 20:55:39 +02001151 constexpr VideoCodecType kCodecType = VideoCodecType::kVideoCodecGeneric;
brandtrdbdb3f12016-11-10 05:04:48 -08001152 constexpr int kFlexfecPayloadType = 118;
brandtrdbdb3f12016-11-10 05:04:48 -08001153 const std::vector<RtpExtension> kNoRtpExtensions;
erikvarga27883732017-05-17 05:08:38 -07001154 const std::vector<RtpExtensionSize> kNoRtpExtensionSizes;
Erik Språng4580ca22019-07-04 10:38:43 +02001155 FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexFecSsrc, kSsrc, kNoMid,
1156 kNoRtpExtensions, kNoRtpExtensionSizes,
brandtr48d21a22017-05-30 02:32:12 -07001157 nullptr /* rtp_state */, &fake_clock_);
brandtrdbdb3f12016-11-10 05:04:48 -08001158
1159 // Reset |rtp_sender_| to use FlexFEC.
Erik Språng4580ca22019-07-04 10:38:43 +02001160 RtpRtcp::Configuration config;
1161 config.clock = &fake_clock_;
1162 config.outgoing_transport = &transport_;
1163 config.paced_sender = &mock_paced_sender_;
Erik Språng54d5d2c2019-08-20 17:22:36 +02001164 config.local_media_ssrc = kSsrc;
Erik Språng4580ca22019-07-04 10:38:43 +02001165 config.flexfec_sender = &flexfec_sender_;
Erik Språng4580ca22019-07-04 10:38:43 +02001166 config.event_log = &mock_rtc_event_log_;
1167 config.send_packet_observer = &send_packet_observer_;
1168 config.retransmission_rate_limiter = &retransmission_rate_limiter_;
Mirko Bonadei317a1f02019-09-17 17:06:18 +02001169 rtp_sender_ = std::make_unique<RTPSender>(config);
Erik Språng4580ca22019-07-04 10:38:43 +02001170
brandtrdbdb3f12016-11-10 05:04:48 -08001171 rtp_sender_->SetSequenceNumber(kSeqNum);
brandtrdbdb3f12016-11-10 05:04:48 -08001172 rtp_sender_->SetStorePacketsStatus(true, 10);
1173
Niels Möller5fe95102019-03-04 16:49:25 +01001174 PlayoutDelayOracle playout_delay_oracle;
Erik Språngdc34a252019-10-04 15:17:29 +02001175 FieldTrialBasedConfig field_trials;
1176 RTPSenderVideo::Config video_config;
1177 video_config.clock = &fake_clock_;
1178 video_config.rtp_sender = rtp_sender_.get();
1179 video_config.flexfec_sender = &flexfec_sender;
1180 video_config.playout_delay_oracle = &playout_delay_oracle;
1181 video_config.field_trials = &field_trials;
1182 RTPSenderVideo rtp_sender_video(video_config);
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001183
brandtrdbdb3f12016-11-10 05:04:48 -08001184 // Parameters selected to generate a single FEC packet per media packet.
1185 FecProtectionParams params;
1186 params.fec_rate = 15;
1187 params.max_fec_frames = 1;
1188 params.fec_mask_type = kFecMaskRandom;
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001189 rtp_sender_video.SetFecParameters(params, params);
brandtrdbdb3f12016-11-10 05:04:48 -08001190
brandtr9dfff292016-11-14 05:14:50 -08001191 uint16_t flexfec_seq_num;
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001192 RTPVideoHeader video_header;
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001193
Erik Språngf6468d22019-07-05 16:53:43 +02001194 std::unique_ptr<RtpPacketToSend> media_packet;
1195 std::unique_ptr<RtpPacketToSend> fec_packet;
1196
Erik Språngea55b082019-10-02 14:57:46 +02001197 EXPECT_CALL(mock_paced_sender_, EnqueuePackets)
Erik Språngf6468d22019-07-05 16:53:43 +02001198 .Times(2)
Erik Språngea55b082019-10-02 14:57:46 +02001199 .WillRepeatedly(
1200 [&](std::vector<std::unique_ptr<RtpPacketToSend>> packets) {
1201 for (auto& packet : packets) {
1202 if (packet->packet_type() == RtpPacketToSend::Type::kVideo) {
1203 EXPECT_EQ(packet->Ssrc(), kSsrc);
1204 EXPECT_EQ(packet->SequenceNumber(), kSeqNum);
1205 media_packet = std::move(packet);
1206 } else {
1207 EXPECT_EQ(packet->packet_type(),
1208 RtpPacketToSend::Type::kForwardErrorCorrection);
1209 EXPECT_EQ(packet->Ssrc(), kFlexFecSsrc);
1210 fec_packet = std::move(packet);
1211 }
1212 }
1213 });
Erik Språngf6468d22019-07-05 16:53:43 +02001214
1215 EXPECT_TRUE(rtp_sender_video.SendVideo(
Erik Språng6cf554e2019-10-02 20:55:39 +02001216 VideoFrameType::kVideoFrameKey, kMediaPayloadType, kCodecType,
1217 kTimestamp, fake_clock_.TimeInMilliseconds(), kPayloadData,
1218 sizeof(kPayloadData), nullptr, &video_header,
1219 kDefaultExpectedRetransmissionTimeMs));
Erik Språngf6468d22019-07-05 16:53:43 +02001220 ASSERT_TRUE(media_packet != nullptr);
1221 ASSERT_TRUE(fec_packet != nullptr);
1222
1223 flexfec_seq_num = fec_packet->SequenceNumber();
1224 rtp_sender_->TrySendPacket(media_packet.get(), PacedPacketInfo());
1225 rtp_sender_->TrySendPacket(fec_packet.get(), PacedPacketInfo());
Erik Språngf6468d22019-07-05 16:53:43 +02001226
brandtr9dfff292016-11-14 05:14:50 -08001227 ASSERT_EQ(2, transport_.packets_sent());
Erik Språngf5815fa2019-08-21 14:27:31 +02001228 const RtpPacketReceived& sent_media_packet = transport_.sent_packets_[0];
1229 EXPECT_EQ(kMediaPayloadType, sent_media_packet.PayloadType());
1230 EXPECT_EQ(kSeqNum, sent_media_packet.SequenceNumber());
1231 EXPECT_EQ(kSsrc, sent_media_packet.Ssrc());
1232 const RtpPacketReceived& sent_flexfec_packet = transport_.sent_packets_[1];
1233 EXPECT_EQ(kFlexfecPayloadType, sent_flexfec_packet.PayloadType());
1234 EXPECT_EQ(flexfec_seq_num, sent_flexfec_packet.SequenceNumber());
1235 EXPECT_EQ(kFlexFecSsrc, sent_flexfec_packet.Ssrc());
brandtrdbdb3f12016-11-10 05:04:48 -08001236}
1237
Erik Språngf6468d22019-07-05 16:53:43 +02001238// TODO(ilnik): because of webrtc:7859. Once FEC moved below pacer, this test
1239// should be removed.
1240TEST_P(RtpSenderTest, NoFlexfecForTimingFrames) {
1241 constexpr uint32_t kTimestamp = 1234;
1242 const int64_t kCaptureTimeMs = fake_clock_.TimeInMilliseconds();
1243 constexpr int kMediaPayloadType = 127;
Erik Språng6cf554e2019-10-02 20:55:39 +02001244 constexpr VideoCodecType kCodecType = VideoCodecType::kVideoCodecGeneric;
Erik Språngf6468d22019-07-05 16:53:43 +02001245 constexpr int kFlexfecPayloadType = 118;
1246 const std::vector<RtpExtension> kNoRtpExtensions;
1247 const std::vector<RtpExtensionSize> kNoRtpExtensionSizes;
1248
1249 FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexFecSsrc, kSsrc, kNoMid,
1250 kNoRtpExtensions, kNoRtpExtensionSizes,
1251 nullptr /* rtp_state */, &fake_clock_);
1252
1253 // Reset |rtp_sender_| to use FlexFEC.
Erik Språng630443a2019-07-26 16:44:55 +02001254 RtpRtcp::Configuration config;
1255 config.clock = &fake_clock_;
1256 config.outgoing_transport = &transport_;
1257 config.paced_sender = &mock_paced_sender_;
1258 config.flexfec_sender = &flexfec_sender;
Erik Språng630443a2019-07-26 16:44:55 +02001259 config.event_log = &mock_rtc_event_log_;
1260 config.send_packet_observer = &send_packet_observer_;
1261 config.retransmission_rate_limiter = &retransmission_rate_limiter_;
Erik Språng54d5d2c2019-08-20 17:22:36 +02001262 config.local_media_ssrc = kSsrc;
Mirko Bonadei317a1f02019-09-17 17:06:18 +02001263 rtp_sender_ = std::make_unique<RTPSender>(config);
Erik Språngf6468d22019-07-05 16:53:43 +02001264 rtp_sender_->SetSequenceNumber(kSeqNum);
1265 rtp_sender_->SetStorePacketsStatus(true, 10);
1266
1267 PlayoutDelayOracle playout_delay_oracle;
Erik Språngdc34a252019-10-04 15:17:29 +02001268 FieldTrialBasedConfig field_trials;
1269 RTPSenderVideo::Config video_config;
1270 video_config.clock = &fake_clock_;
1271 video_config.rtp_sender = rtp_sender_.get();
1272 video_config.flexfec_sender = &flexfec_sender;
1273 video_config.playout_delay_oracle = &playout_delay_oracle;
1274 video_config.field_trials = &field_trials;
1275 RTPSenderVideo rtp_sender_video(video_config);
Erik Språngf6468d22019-07-05 16:53:43 +02001276
1277 // Need extension to be registered for timing frames to be sent.
1278 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
1279 kRtpExtensionVideoTiming, kVideoTimingExtensionId));
1280
1281 // Parameters selected to generate a single FEC packet per media packet.
1282 FecProtectionParams params;
1283 params.fec_rate = 15;
1284 params.max_fec_frames = 1;
1285 params.fec_mask_type = kFecMaskRandom;
1286 rtp_sender_video.SetFecParameters(params, params);
1287
1288 RTPVideoHeader video_header;
1289 video_header.video_timing.flags = VideoSendTiming::kTriggeredByTimer;
1290
1291 EXPECT_CALL(mock_rtc_event_log_,
1292 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
1293 .Times(1);
Erik Språngf6468d22019-07-05 16:53:43 +02001294 std::unique_ptr<RtpPacketToSend> rtp_packet;
1295 EXPECT_CALL(
1296 mock_paced_sender_,
Erik Språngea55b082019-10-02 14:57:46 +02001297 EnqueuePackets(Contains(AllOf(
Erik Språngf6468d22019-07-05 16:53:43 +02001298 Pointee(Property(&RtpPacketToSend::Ssrc, kSsrc)),
Erik Språngea55b082019-10-02 14:57:46 +02001299 Pointee(Property(&RtpPacketToSend::SequenceNumber, kSeqNum))))))
1300 .WillOnce([&rtp_packet](
1301 std::vector<std::unique_ptr<RtpPacketToSend>> packets) {
1302 EXPECT_EQ(packets.size(), 1u);
1303 rtp_packet = std::move(packets[0]);
Erik Språngf6468d22019-07-05 16:53:43 +02001304 });
1305
Erik Språngea55b082019-10-02 14:57:46 +02001306 EXPECT_CALL(mock_paced_sender_,
1307 EnqueuePackets(Contains(
1308 Pointee(Property(&RtpPacketToSend::Ssrc, kFlexFecSsrc)))))
Erik Språngf6468d22019-07-05 16:53:43 +02001309 .Times(0); // Not called because packet should not be protected.
1310
1311 EXPECT_TRUE(rtp_sender_video.SendVideo(
Erik Språng6cf554e2019-10-02 20:55:39 +02001312 VideoFrameType::kVideoFrameKey, kMediaPayloadType, kCodecType,
1313 kTimestamp, kCaptureTimeMs, kPayloadData, sizeof(kPayloadData), nullptr,
Erik Språngf6468d22019-07-05 16:53:43 +02001314 &video_header, kDefaultExpectedRetransmissionTimeMs));
1315
1316 EXPECT_TRUE(
1317 rtp_sender_->TrySendPacket(rtp_packet.get(), PacedPacketInfo()));
Erik Språngf6468d22019-07-05 16:53:43 +02001318
1319 ASSERT_EQ(1, transport_.packets_sent());
Erik Språngf5815fa2019-08-21 14:27:31 +02001320 const RtpPacketReceived& sent_media_packet1 = transport_.sent_packets_[0];
1321 EXPECT_EQ(kMediaPayloadType, sent_media_packet1.PayloadType());
1322 EXPECT_EQ(kSeqNum, sent_media_packet1.SequenceNumber());
1323 EXPECT_EQ(kSsrc, sent_media_packet1.Ssrc());
Erik Språngf6468d22019-07-05 16:53:43 +02001324
1325 // Now try to send not a timing frame.
1326 uint16_t flexfec_seq_num;
1327
1328 EXPECT_CALL(mock_rtc_event_log_,
1329 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
1330 .Times(2);
Erik Språngf5815fa2019-08-21 14:27:31 +02001331 std::unique_ptr<RtpPacketToSend> media_packet2;
1332 std::unique_ptr<RtpPacketToSend> fec_packet;
Erik Språngf6468d22019-07-05 16:53:43 +02001333
Erik Språngea55b082019-10-02 14:57:46 +02001334 EXPECT_CALL(mock_paced_sender_, EnqueuePackets)
Erik Språngf5815fa2019-08-21 14:27:31 +02001335 .Times(2)
Erik Språngea55b082019-10-02 14:57:46 +02001336 .WillRepeatedly(
1337 [&](std::vector<std::unique_ptr<RtpPacketToSend>> packets) {
1338 for (auto& packet : packets) {
1339 if (packet->packet_type() == RtpPacketToSend::Type::kVideo) {
1340 EXPECT_EQ(packet->Ssrc(), kSsrc);
1341 EXPECT_EQ(packet->SequenceNumber(), kSeqNum + 1);
1342 media_packet2 = std::move(packet);
1343 } else {
1344 EXPECT_EQ(packet->packet_type(),
1345 RtpPacketToSend::Type::kForwardErrorCorrection);
1346 EXPECT_EQ(packet->Ssrc(), kFlexFecSsrc);
1347 fec_packet = std::move(packet);
1348 }
1349 }
1350 });
Erik Språngf6468d22019-07-05 16:53:43 +02001351
Erik Språngf5815fa2019-08-21 14:27:31 +02001352 video_header.video_timing.flags = VideoSendTiming::kInvalid;
1353 EXPECT_TRUE(rtp_sender_video.SendVideo(
Erik Språng6cf554e2019-10-02 20:55:39 +02001354 VideoFrameType::kVideoFrameKey, kMediaPayloadType, kCodecType,
1355 kTimestamp + 1, kCaptureTimeMs + 1, kPayloadData, sizeof(kPayloadData),
1356 nullptr, &video_header, kDefaultExpectedRetransmissionTimeMs));
Erik Språngf6468d22019-07-05 16:53:43 +02001357
Erik Språngf5815fa2019-08-21 14:27:31 +02001358 ASSERT_TRUE(media_packet2 != nullptr);
1359 ASSERT_TRUE(fec_packet != nullptr);
Erik Språngf6468d22019-07-05 16:53:43 +02001360
Erik Språngf5815fa2019-08-21 14:27:31 +02001361 flexfec_seq_num = fec_packet->SequenceNumber();
1362 rtp_sender_->TrySendPacket(media_packet2.get(), PacedPacketInfo());
1363 rtp_sender_->TrySendPacket(fec_packet.get(), PacedPacketInfo());
Erik Språngf6468d22019-07-05 16:53:43 +02001364
1365 ASSERT_EQ(3, transport_.packets_sent());
Erik Språngf5815fa2019-08-21 14:27:31 +02001366 const RtpPacketReceived& sent_media_packet2 = transport_.sent_packets_[1];
1367 EXPECT_EQ(kMediaPayloadType, sent_media_packet2.PayloadType());
1368 EXPECT_EQ(kSeqNum + 1, sent_media_packet2.SequenceNumber());
1369 EXPECT_EQ(kSsrc, sent_media_packet2.Ssrc());
Erik Språngf6468d22019-07-05 16:53:43 +02001370 const RtpPacketReceived& flexfec_packet = transport_.sent_packets_[2];
1371 EXPECT_EQ(kFlexfecPayloadType, flexfec_packet.PayloadType());
1372 EXPECT_EQ(flexfec_seq_num, flexfec_packet.SequenceNumber());
1373 EXPECT_EQ(kFlexFecSsrc, flexfec_packet.Ssrc());
1374}
1375
minyue3a407ee2017-04-03 01:10:33 -07001376TEST_P(RtpSenderTestWithoutPacer, SendFlexfecPackets) {
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001377 constexpr uint32_t kTimestamp = 1234;
brandtrdbdb3f12016-11-10 05:04:48 -08001378 constexpr int kMediaPayloadType = 127;
Erik Språng6cf554e2019-10-02 20:55:39 +02001379 constexpr VideoCodecType kCodecType = VideoCodecType::kVideoCodecGeneric;
brandtrdbdb3f12016-11-10 05:04:48 -08001380 constexpr int kFlexfecPayloadType = 118;
brandtrdbdb3f12016-11-10 05:04:48 -08001381 const std::vector<RtpExtension> kNoRtpExtensions;
erikvarga27883732017-05-17 05:08:38 -07001382 const std::vector<RtpExtensionSize> kNoRtpExtensionSizes;
Erik Språngf6468d22019-07-05 16:53:43 +02001383 FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexFecSsrc, kSsrc, kNoMid,
Erik Språng4580ca22019-07-04 10:38:43 +02001384 kNoRtpExtensions, kNoRtpExtensionSizes,
brandtr48d21a22017-05-30 02:32:12 -07001385 nullptr /* rtp_state */, &fake_clock_);
brandtrdbdb3f12016-11-10 05:04:48 -08001386
1387 // Reset |rtp_sender_| to use FlexFEC.
Erik Språng4580ca22019-07-04 10:38:43 +02001388 RtpRtcp::Configuration config;
1389 config.clock = &fake_clock_;
1390 config.outgoing_transport = &transport_;
Erik Språng54d5d2c2019-08-20 17:22:36 +02001391 config.local_media_ssrc = kSsrc;
Erik Språng4580ca22019-07-04 10:38:43 +02001392 config.flexfec_sender = &flexfec_sender;
Erik Språng4580ca22019-07-04 10:38:43 +02001393 config.event_log = &mock_rtc_event_log_;
1394 config.send_packet_observer = &send_packet_observer_;
1395 config.retransmission_rate_limiter = &retransmission_rate_limiter_;
Mirko Bonadei317a1f02019-09-17 17:06:18 +02001396 rtp_sender_ = std::make_unique<RTPSender>(config);
Erik Språng4580ca22019-07-04 10:38:43 +02001397
brandtrdbdb3f12016-11-10 05:04:48 -08001398 rtp_sender_->SetSequenceNumber(kSeqNum);
brandtrdbdb3f12016-11-10 05:04:48 -08001399
Niels Möller5fe95102019-03-04 16:49:25 +01001400 PlayoutDelayOracle playout_delay_oracle;
Erik Språngdc34a252019-10-04 15:17:29 +02001401 FieldTrialBasedConfig field_trials;
1402 RTPSenderVideo::Config video_config;
1403 video_config.clock = &fake_clock_;
1404 video_config.rtp_sender = rtp_sender_.get();
1405 video_config.flexfec_sender = &flexfec_sender;
1406 video_config.playout_delay_oracle = &playout_delay_oracle;
1407 video_config.field_trials = &field_trials;
1408 RTPSenderVideo rtp_sender_video(video_config);
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001409
brandtrdbdb3f12016-11-10 05:04:48 -08001410 // Parameters selected to generate a single FEC packet per media packet.
1411 FecProtectionParams params;
1412 params.fec_rate = 15;
1413 params.max_fec_frames = 1;
1414 params.fec_mask_type = kFecMaskRandom;
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001415 rtp_sender_video.SetFecParameters(params, params);
brandtrdbdb3f12016-11-10 05:04:48 -08001416
Elad Alon4a87e1c2017-10-03 16:11:34 +02001417 EXPECT_CALL(mock_rtc_event_log_,
1418 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
1419 .Times(2);
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001420 RTPVideoHeader video_header;
1421 EXPECT_TRUE(rtp_sender_video.SendVideo(
Erik Språng6cf554e2019-10-02 20:55:39 +02001422 VideoFrameType::kVideoFrameKey, kMediaPayloadType, kCodecType, kTimestamp,
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001423 fake_clock_.TimeInMilliseconds(), kPayloadData, sizeof(kPayloadData),
1424 nullptr, &video_header, kDefaultExpectedRetransmissionTimeMs));
1425
brandtrdbdb3f12016-11-10 05:04:48 -08001426 ASSERT_EQ(2, transport_.packets_sent());
1427 const RtpPacketReceived& media_packet = transport_.sent_packets_[0];
1428 EXPECT_EQ(kMediaPayloadType, media_packet.PayloadType());
Erik Språng4580ca22019-07-04 10:38:43 +02001429 EXPECT_EQ(kSsrc, media_packet.Ssrc());
brandtrdbdb3f12016-11-10 05:04:48 -08001430 const RtpPacketReceived& flexfec_packet = transport_.sent_packets_[1];
1431 EXPECT_EQ(kFlexfecPayloadType, flexfec_packet.PayloadType());
Erik Språngf6468d22019-07-05 16:53:43 +02001432 EXPECT_EQ(kFlexFecSsrc, flexfec_packet.Ssrc());
brandtrdbdb3f12016-11-10 05:04:48 -08001433}
1434
Steve Anton296a0ce2018-03-22 15:17:27 -07001435// Test that the MID header extension is included on sent packets when
1436// configured.
1437TEST_P(RtpSenderTestWithoutPacer, MidIncludedOnSentPackets) {
1438 const char kMid[] = "mid";
1439
Steve Anton2bac7da2019-07-21 15:04:21 -04001440 EnableMidSending(kMid);
Steve Anton296a0ce2018-03-22 15:17:27 -07001441
1442 // Send a couple packets.
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001443 SendGenericPacket();
1444 SendGenericPacket();
Steve Anton296a0ce2018-03-22 15:17:27 -07001445
1446 // Expect both packets to have the MID set.
1447 ASSERT_EQ(2u, transport_.sent_packets_.size());
1448 for (const RtpPacketReceived& packet : transport_.sent_packets_) {
1449 std::string mid;
1450 ASSERT_TRUE(packet.GetExtension<RtpMid>(&mid));
1451 EXPECT_EQ(kMid, mid);
1452 }
1453}
1454
Amit Hilbuch77938e62018-12-21 09:23:38 -08001455TEST_P(RtpSenderTestWithoutPacer, RidIncludedOnSentPackets) {
1456 const char kRid[] = "f";
1457
Steve Anton2bac7da2019-07-21 15:04:21 -04001458 EnableRidSending(kRid);
Amit Hilbuch77938e62018-12-21 09:23:38 -08001459
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001460 SendGenericPacket();
Amit Hilbuch77938e62018-12-21 09:23:38 -08001461
1462 ASSERT_EQ(1u, transport_.sent_packets_.size());
1463 const RtpPacketReceived& packet = transport_.sent_packets_[0];
1464 std::string rid;
1465 ASSERT_TRUE(packet.GetExtension<RtpStreamId>(&rid));
1466 EXPECT_EQ(kRid, rid);
1467}
1468
1469TEST_P(RtpSenderTestWithoutPacer, RidIncludedOnRtxSentPackets) {
1470 const char kRid[] = "f";
Amit Hilbuch77938e62018-12-21 09:23:38 -08001471
Steve Anton2bac7da2019-07-21 15:04:21 -04001472 EnableRtx();
1473 EnableRidSending(kRid);
Amit Hilbuch77938e62018-12-21 09:23:38 -08001474
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001475 SendGenericPacket();
Amit Hilbuch77938e62018-12-21 09:23:38 -08001476 ASSERT_EQ(1u, transport_.sent_packets_.size());
1477 const RtpPacketReceived& packet = transport_.sent_packets_[0];
1478 std::string rid;
1479 ASSERT_TRUE(packet.GetExtension<RtpStreamId>(&rid));
1480 EXPECT_EQ(kRid, rid);
1481 rid = kNoRid;
Steve Anton2bac7da2019-07-21 15:04:21 -04001482 EXPECT_FALSE(packet.HasExtension<RepairedRtpStreamId>());
Amit Hilbuch77938e62018-12-21 09:23:38 -08001483
1484 uint16_t packet_id = packet.SequenceNumber();
1485 rtp_sender_->ReSendPacket(packet_id);
1486 ASSERT_EQ(2u, transport_.sent_packets_.size());
1487 const RtpPacketReceived& rtx_packet = transport_.sent_packets_[1];
1488 ASSERT_TRUE(rtx_packet.GetExtension<RepairedRtpStreamId>(&rid));
1489 EXPECT_EQ(kRid, rid);
1490 EXPECT_FALSE(rtx_packet.HasExtension<RtpStreamId>());
1491}
1492
Steve Anton2bac7da2019-07-21 15:04:21 -04001493TEST_P(RtpSenderTestWithoutPacer, MidAndRidNotIncludedOnSentPacketsAfterAck) {
1494 const char kMid[] = "mid";
1495 const char kRid[] = "f";
1496
1497 EnableMidSending(kMid);
1498 EnableRidSending(kRid);
1499
1500 // This first packet should include both MID and RID.
1501 auto first_built_packet = SendGenericPacket();
1502
1503 rtp_sender_->OnReceivedAckOnSsrc(first_built_packet->SequenceNumber());
1504
1505 // The second packet should include neither since an ack was received.
1506 SendGenericPacket();
1507
1508 ASSERT_EQ(2u, transport_.sent_packets_.size());
1509
1510 const RtpPacketReceived& first_packet = transport_.sent_packets_[0];
1511 std::string mid, rid;
1512 ASSERT_TRUE(first_packet.GetExtension<RtpMid>(&mid));
1513 EXPECT_EQ(kMid, mid);
1514 ASSERT_TRUE(first_packet.GetExtension<RtpStreamId>(&rid));
1515 EXPECT_EQ(kRid, rid);
1516
1517 const RtpPacketReceived& second_packet = transport_.sent_packets_[1];
1518 EXPECT_FALSE(second_packet.HasExtension<RtpMid>());
1519 EXPECT_FALSE(second_packet.HasExtension<RtpStreamId>());
1520}
1521
1522// Test that the first RTX packet includes both MID and RRID even if the packet
1523// being retransmitted did not have MID or RID. The MID and RID are needed on
1524// the first packets for a given SSRC, and RTX packets are sent on a separate
1525// SSRC.
1526TEST_P(RtpSenderTestWithoutPacer, MidAndRidIncludedOnFirstRtxPacket) {
1527 const char kMid[] = "mid";
1528 const char kRid[] = "f";
1529
1530 EnableRtx();
1531 EnableMidSending(kMid);
1532 EnableRidSending(kRid);
1533
1534 // This first packet will include both MID and RID.
1535 auto first_built_packet = SendGenericPacket();
1536 rtp_sender_->OnReceivedAckOnSsrc(first_built_packet->SequenceNumber());
1537
1538 // The second packet will include neither since an ack was received.
1539 auto second_built_packet = SendGenericPacket();
1540
1541 // The first RTX packet should include MID and RRID.
1542 ASSERT_LT(0,
1543 rtp_sender_->ReSendPacket(second_built_packet->SequenceNumber()));
1544
1545 ASSERT_EQ(3u, transport_.sent_packets_.size());
1546
1547 const RtpPacketReceived& rtx_packet = transport_.sent_packets_[2];
1548 std::string mid, rrid;
1549 ASSERT_TRUE(rtx_packet.GetExtension<RtpMid>(&mid));
1550 EXPECT_EQ(kMid, mid);
1551 ASSERT_TRUE(rtx_packet.GetExtension<RepairedRtpStreamId>(&rrid));
1552 EXPECT_EQ(kRid, rrid);
1553}
1554
1555// Test that the RTX packets sent after receving an ACK on the RTX SSRC does
1556// not include either MID or RRID even if the packet being retransmitted did
1557// had a MID or RID.
1558TEST_P(RtpSenderTestWithoutPacer, MidAndRidNotIncludedOnRtxPacketsAfterAck) {
1559 const char kMid[] = "mid";
1560 const char kRid[] = "f";
1561
1562 EnableRtx();
1563 EnableMidSending(kMid);
1564 EnableRidSending(kRid);
1565
1566 // This first packet will include both MID and RID.
1567 auto first_built_packet = SendGenericPacket();
1568 rtp_sender_->OnReceivedAckOnSsrc(first_built_packet->SequenceNumber());
1569
1570 // The second packet will include neither since an ack was received.
1571 auto second_built_packet = SendGenericPacket();
1572
1573 // The first RTX packet will include MID and RRID.
1574 ASSERT_LT(0,
1575 rtp_sender_->ReSendPacket(second_built_packet->SequenceNumber()));
1576
1577 ASSERT_EQ(3u, transport_.sent_packets_.size());
1578 const RtpPacketReceived& first_rtx_packet = transport_.sent_packets_[2];
1579
1580 rtp_sender_->OnReceivedAckOnRtxSsrc(first_rtx_packet.SequenceNumber());
1581
1582 // The second and third RTX packets should not include MID nor RRID.
1583 ASSERT_LT(0, rtp_sender_->ReSendPacket(first_built_packet->SequenceNumber()));
1584 ASSERT_LT(0,
1585 rtp_sender_->ReSendPacket(second_built_packet->SequenceNumber()));
1586
1587 ASSERT_EQ(5u, transport_.sent_packets_.size());
1588
1589 const RtpPacketReceived& second_rtx_packet = transport_.sent_packets_[3];
1590 EXPECT_FALSE(second_rtx_packet.HasExtension<RtpMid>());
1591 EXPECT_FALSE(second_rtx_packet.HasExtension<RepairedRtpStreamId>());
1592
1593 const RtpPacketReceived& third_rtx_packet = transport_.sent_packets_[4];
1594 EXPECT_FALSE(third_rtx_packet.HasExtension<RtpMid>());
1595 EXPECT_FALSE(third_rtx_packet.HasExtension<RepairedRtpStreamId>());
1596}
1597
1598// Test that if the RtpState indicates an ACK has been received on that SSRC
1599// then neither the MID nor RID header extensions will be sent.
1600TEST_P(RtpSenderTestWithoutPacer,
1601 MidAndRidNotIncludedOnSentPacketsAfterRtpStateRestored) {
1602 const char kMid[] = "mid";
1603 const char kRid[] = "f";
1604
1605 EnableMidSending(kMid);
1606 EnableRidSending(kRid);
1607
1608 RtpState state = rtp_sender_->GetRtpState();
1609 EXPECT_FALSE(state.ssrc_has_acked);
1610 state.ssrc_has_acked = true;
1611 rtp_sender_->SetRtpState(state);
1612
1613 SendGenericPacket();
1614
1615 ASSERT_EQ(1u, transport_.sent_packets_.size());
1616 const RtpPacketReceived& packet = transport_.sent_packets_[0];
1617 EXPECT_FALSE(packet.HasExtension<RtpMid>());
1618 EXPECT_FALSE(packet.HasExtension<RtpStreamId>());
1619}
1620
1621// Test that if the RTX RtpState indicates an ACK has been received on that
1622// RTX SSRC then neither the MID nor RRID header extensions will be sent on
1623// RTX packets.
1624TEST_P(RtpSenderTestWithoutPacer,
1625 MidAndRridNotIncludedOnRtxPacketsAfterRtpStateRestored) {
1626 const char kMid[] = "mid";
1627 const char kRid[] = "f";
1628
1629 EnableRtx();
1630 EnableMidSending(kMid);
1631 EnableRidSending(kRid);
1632
1633 RtpState rtx_state = rtp_sender_->GetRtxRtpState();
1634 EXPECT_FALSE(rtx_state.ssrc_has_acked);
1635 rtx_state.ssrc_has_acked = true;
1636 rtp_sender_->SetRtxRtpState(rtx_state);
1637
1638 auto built_packet = SendGenericPacket();
1639 ASSERT_LT(0, rtp_sender_->ReSendPacket(built_packet->SequenceNumber()));
1640
1641 ASSERT_EQ(2u, transport_.sent_packets_.size());
1642 const RtpPacketReceived& rtx_packet = transport_.sent_packets_[1];
1643 EXPECT_FALSE(rtx_packet.HasExtension<RtpMid>());
1644 EXPECT_FALSE(rtx_packet.HasExtension<RepairedRtpStreamId>());
1645}
1646
minyue3a407ee2017-04-03 01:10:33 -07001647TEST_P(RtpSenderTest, FecOverheadRate) {
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001648 constexpr uint32_t kTimestamp = 1234;
1649 constexpr int kMediaPayloadType = 127;
Erik Språng6cf554e2019-10-02 20:55:39 +02001650 constexpr VideoCodecType kCodecType = VideoCodecType::kVideoCodecGeneric;
brandtr81eab612017-01-24 04:06:09 -08001651 constexpr int kFlexfecPayloadType = 118;
brandtr81eab612017-01-24 04:06:09 -08001652 const std::vector<RtpExtension> kNoRtpExtensions;
erikvarga27883732017-05-17 05:08:38 -07001653 const std::vector<RtpExtensionSize> kNoRtpExtensionSizes;
Erik Språng4580ca22019-07-04 10:38:43 +02001654 FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexFecSsrc, kSsrc, kNoMid,
1655 kNoRtpExtensions, kNoRtpExtensionSizes,
brandtr48d21a22017-05-30 02:32:12 -07001656 nullptr /* rtp_state */, &fake_clock_);
brandtr81eab612017-01-24 04:06:09 -08001657
1658 // Reset |rtp_sender_| to use FlexFEC.
Erik Språng4580ca22019-07-04 10:38:43 +02001659 RtpRtcp::Configuration config;
1660 config.clock = &fake_clock_;
1661 config.outgoing_transport = &transport_;
1662 config.paced_sender = &mock_paced_sender_;
Erik Språng54d5d2c2019-08-20 17:22:36 +02001663 config.local_media_ssrc = kSsrc;
Erik Språng4580ca22019-07-04 10:38:43 +02001664 config.flexfec_sender = &flexfec_sender;
Erik Språng4580ca22019-07-04 10:38:43 +02001665 config.event_log = &mock_rtc_event_log_;
1666 config.send_packet_observer = &send_packet_observer_;
1667 config.retransmission_rate_limiter = &retransmission_rate_limiter_;
Mirko Bonadei317a1f02019-09-17 17:06:18 +02001668 rtp_sender_ = std::make_unique<RTPSender>(config);
Erik Språng4580ca22019-07-04 10:38:43 +02001669
brandtr81eab612017-01-24 04:06:09 -08001670 rtp_sender_->SetSequenceNumber(kSeqNum);
brandtr81eab612017-01-24 04:06:09 -08001671
Niels Möller5fe95102019-03-04 16:49:25 +01001672 PlayoutDelayOracle playout_delay_oracle;
Erik Språngdc34a252019-10-04 15:17:29 +02001673 FieldTrialBasedConfig field_trials;
1674 RTPSenderVideo::Config video_config;
1675 video_config.clock = &fake_clock_;
1676 video_config.rtp_sender = rtp_sender_.get();
1677 video_config.flexfec_sender = &flexfec_sender;
1678 video_config.playout_delay_oracle = &playout_delay_oracle;
1679 video_config.field_trials = &field_trials;
1680 RTPSenderVideo rtp_sender_video(video_config);
brandtr81eab612017-01-24 04:06:09 -08001681 // Parameters selected to generate a single FEC packet per media packet.
1682 FecProtectionParams params;
1683 params.fec_rate = 15;
1684 params.max_fec_frames = 1;
1685 params.fec_mask_type = kFecMaskRandom;
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001686 rtp_sender_video.SetFecParameters(params, params);
brandtr81eab612017-01-24 04:06:09 -08001687
1688 constexpr size_t kNumMediaPackets = 10;
1689 constexpr size_t kNumFecPackets = kNumMediaPackets;
1690 constexpr int64_t kTimeBetweenPacketsMs = 10;
Erik Språngea55b082019-10-02 14:57:46 +02001691 EXPECT_CALL(mock_paced_sender_, EnqueuePackets)
1692 .Times(kNumMediaPackets + kNumFecPackets);
brandtr81eab612017-01-24 04:06:09 -08001693 for (size_t i = 0; i < kNumMediaPackets; ++i) {
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001694 RTPVideoHeader video_header;
1695
1696 EXPECT_TRUE(rtp_sender_video.SendVideo(
Erik Språng6cf554e2019-10-02 20:55:39 +02001697 VideoFrameType::kVideoFrameKey, kMediaPayloadType, kCodecType,
1698 kTimestamp, fake_clock_.TimeInMilliseconds(), kPayloadData,
1699 sizeof(kPayloadData), nullptr, &video_header,
1700 kDefaultExpectedRetransmissionTimeMs));
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001701
brandtr81eab612017-01-24 04:06:09 -08001702 fake_clock_.AdvanceTimeMilliseconds(kTimeBetweenPacketsMs);
1703 }
1704 constexpr size_t kRtpHeaderLength = 12;
1705 constexpr size_t kFlexfecHeaderLength = 20;
1706 constexpr size_t kGenericCodecHeaderLength = 1;
1707 constexpr size_t kPayloadLength = sizeof(kPayloadData);
1708 constexpr size_t kPacketLength = kRtpHeaderLength + kFlexfecHeaderLength +
1709 kGenericCodecHeaderLength + kPayloadLength;
1710 EXPECT_NEAR(kNumFecPackets * kPacketLength * 8 /
1711 (kNumFecPackets * kTimeBetweenPacketsMs / 1000.0f),
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001712 rtp_sender_video.FecOverheadRate(), 500);
brandtr81eab612017-01-24 04:06:09 -08001713}
1714
minyue3a407ee2017-04-03 01:10:33 -07001715TEST_P(RtpSenderTest, BitrateCallbacks) {
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001716 class TestCallback : public BitrateStatisticsObserver {
1717 public:
sprangcd349d92016-07-13 09:11:28 -07001718 TestCallback()
1719 : BitrateStatisticsObserver(),
1720 num_calls_(0),
1721 ssrc_(0),
1722 total_bitrate_(0),
1723 retransmit_bitrate_(0) {}
Danil Chapovalovdd7e2842018-03-09 15:37:03 +00001724 ~TestCallback() override = default;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001725
sprangcd349d92016-07-13 09:11:28 -07001726 void Notify(uint32_t total_bitrate,
1727 uint32_t retransmit_bitrate,
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00001728 uint32_t ssrc) override {
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001729 ++num_calls_;
1730 ssrc_ = ssrc;
sprangcd349d92016-07-13 09:11:28 -07001731 total_bitrate_ = total_bitrate;
1732 retransmit_bitrate_ = retransmit_bitrate;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001733 }
1734
1735 uint32_t num_calls_;
1736 uint32_t ssrc_;
sprangcd349d92016-07-13 09:11:28 -07001737 uint32_t total_bitrate_;
1738 uint32_t retransmit_bitrate_;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001739 } callback;
Erik Språng4580ca22019-07-04 10:38:43 +02001740
1741 RtpRtcp::Configuration config;
1742 config.clock = &fake_clock_;
1743 config.outgoing_transport = &transport_;
Erik Språng54d5d2c2019-08-20 17:22:36 +02001744 config.local_media_ssrc = kSsrc;
Erik Språng4580ca22019-07-04 10:38:43 +02001745 config.send_bitrate_observer = &callback;
1746 config.retransmission_rate_limiter = &retransmission_rate_limiter_;
Mirko Bonadei317a1f02019-09-17 17:06:18 +02001747 rtp_sender_ = std::make_unique<RTPSender>(config);
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001748
Niels Möller5fe95102019-03-04 16:49:25 +01001749 PlayoutDelayOracle playout_delay_oracle;
Erik Språngdc34a252019-10-04 15:17:29 +02001750 FieldTrialBasedConfig field_trials;
1751 RTPSenderVideo::Config video_config;
1752 video_config.clock = &fake_clock_;
1753 video_config.rtp_sender = rtp_sender_.get();
1754 video_config.playout_delay_oracle = &playout_delay_oracle;
1755 video_config.field_trials = &field_trials;
1756 RTPSenderVideo rtp_sender_video(video_config);
Erik Språng6cf554e2019-10-02 20:55:39 +02001757 const VideoCodecType kCodecType = VideoCodecType::kVideoCodecGeneric;
1758 const uint8_t kPayloadType = 127;
Niels Möller59ab1cf2019-02-06 22:48:11 +01001759
sprangcd349d92016-07-13 09:11:28 -07001760 // Simulate kNumPackets sent with kPacketInterval ms intervals, with the
1761 // number of packets selected so that we fill (but don't overflow) the one
1762 // second averaging window.
1763 const uint32_t kWindowSizeMs = 1000;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001764 const uint32_t kPacketInterval = 20;
sprangcd349d92016-07-13 09:11:28 -07001765 const uint32_t kNumPackets =
1766 (kWindowSizeMs - kPacketInterval) / kPacketInterval;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001767 // Overhead = 12 bytes RTP header + 1 byte generic header.
1768 const uint32_t kPacketOverhead = 13;
1769
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001770 uint8_t payload[] = {47, 11, 32, 93, 89};
1771 rtp_sender_->SetStorePacketsStatus(true, 1);
1772 uint32_t ssrc = rtp_sender_->SSRC();
1773
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001774 // Initial process call so we get a new time window.
1775 rtp_sender_->ProcessBitrate();
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001776
1777 // Send a few frames.
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001778 RTPVideoHeader video_header;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001779 for (uint32_t i = 0; i < kNumPackets; ++i) {
Niels Möller59ab1cf2019-02-06 22:48:11 +01001780 ASSERT_TRUE(rtp_sender_video.SendVideo(
Erik Språng6cf554e2019-10-02 20:55:39 +02001781 VideoFrameType::kVideoFrameKey, kPayloadType, kCodecType, 1234, 4321,
1782 payload, sizeof(payload), nullptr, &video_header,
Niels Möller8f7ce222019-03-21 15:43:58 +01001783 kDefaultExpectedRetransmissionTimeMs));
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001784 fake_clock_.AdvanceTimeMilliseconds(kPacketInterval);
1785 }
1786
1787 rtp_sender_->ProcessBitrate();
1788
stefan@webrtc.org0bae1fa2014-11-05 14:05:29 +00001789 // We get one call for every stats updated, thus two calls since both the
1790 // stream stats and the retransmit stats are updated once.
1791 EXPECT_EQ(2u, callback.num_calls_);
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001792 EXPECT_EQ(ssrc, callback.ssrc_);
sprangcd349d92016-07-13 09:11:28 -07001793 const uint32_t kTotalPacketSize = kPacketOverhead + sizeof(payload);
1794 // Bitrate measured over delta between last and first timestamp, plus one.
1795 const uint32_t kExpectedWindowMs = kNumPackets * kPacketInterval + 1;
1796 const uint32_t kExpectedBitsAccumulated = kTotalPacketSize * kNumPackets * 8;
1797 const uint32_t kExpectedRateBps =
1798 (kExpectedBitsAccumulated * 1000 + (kExpectedWindowMs / 2)) /
1799 kExpectedWindowMs;
1800 EXPECT_EQ(kExpectedRateBps, callback.total_bitrate_);
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001801
andresp@webrtc.orgd11bec42014-07-08 14:32:58 +00001802 rtp_sender_.reset();
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001803}
1804
Erik Språngdc34a252019-10-04 15:17:29 +02001805class StreamDataTestCallback : public StreamDataCountersCallback {
1806 public:
1807 StreamDataTestCallback()
1808 : StreamDataCountersCallback(), ssrc_(0), counters_() {}
1809 ~StreamDataTestCallback() override = default;
1810
1811 void DataCountersUpdated(const StreamDataCounters& counters,
1812 uint32_t ssrc) override {
1813 ssrc_ = ssrc;
1814 counters_ = counters;
1815 }
1816
1817 uint32_t ssrc_;
1818 StreamDataCounters counters_;
1819
1820 void MatchPacketCounter(const RtpPacketCounter& expected,
1821 const RtpPacketCounter& actual) {
1822 EXPECT_EQ(expected.payload_bytes, actual.payload_bytes);
1823 EXPECT_EQ(expected.header_bytes, actual.header_bytes);
1824 EXPECT_EQ(expected.padding_bytes, actual.padding_bytes);
1825 EXPECT_EQ(expected.packets, actual.packets);
1826 }
1827
1828 void Matches(uint32_t ssrc, const StreamDataCounters& counters) {
1829 EXPECT_EQ(ssrc, ssrc_);
1830 MatchPacketCounter(counters.transmitted, counters_.transmitted);
1831 MatchPacketCounter(counters.retransmitted, counters_.retransmitted);
1832 EXPECT_EQ(counters.fec.packets, counters_.fec.packets);
1833 }
1834};
1835
minyue3a407ee2017-04-03 01:10:33 -07001836TEST_P(RtpSenderTestWithoutPacer, StreamDataCountersCallbacks) {
Erik Språngdc34a252019-10-04 15:17:29 +02001837 StreamDataTestCallback callback;
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001838
Erik Språng6cf554e2019-10-02 20:55:39 +02001839 const uint8_t kPayloadType = 127;
1840 const VideoCodecType kCodecType = VideoCodecType::kVideoCodecGeneric;
Niels Möller5fe95102019-03-04 16:49:25 +01001841 PlayoutDelayOracle playout_delay_oracle;
Erik Språngdc34a252019-10-04 15:17:29 +02001842 FieldTrialBasedConfig field_trials;
1843 RTPSenderVideo::Config video_config;
1844 video_config.clock = &fake_clock_;
1845 video_config.rtp_sender = rtp_sender_.get();
1846 video_config.playout_delay_oracle = &playout_delay_oracle;
1847 video_config.field_trials = &field_trials;
1848 RTPSenderVideo rtp_sender_video(video_config);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001849 uint8_t payload[] = {47, 11, 32, 93, 89};
1850 rtp_sender_->SetStorePacketsStatus(true, 1);
1851 uint32_t ssrc = rtp_sender_->SSRC();
1852
1853 rtp_sender_->RegisterRtpStatisticsCallback(&callback);
1854
1855 // Send a frame.
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001856 RTPVideoHeader video_header;
Niels Möller59ab1cf2019-02-06 22:48:11 +01001857 ASSERT_TRUE(rtp_sender_video.SendVideo(
Erik Språng6cf554e2019-10-02 20:55:39 +02001858 VideoFrameType::kVideoFrameKey, kPayloadType, kCodecType, 1234, 4321,
1859 payload, sizeof(payload), nullptr, &video_header,
Niels Möller8f7ce222019-03-21 15:43:58 +01001860 kDefaultExpectedRetransmissionTimeMs));
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001861 StreamDataCounters expected;
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001862 expected.transmitted.payload_bytes = 6;
1863 expected.transmitted.header_bytes = 12;
1864 expected.transmitted.padding_bytes = 0;
1865 expected.transmitted.packets = 1;
1866 expected.retransmitted.payload_bytes = 0;
1867 expected.retransmitted.header_bytes = 0;
1868 expected.retransmitted.padding_bytes = 0;
1869 expected.retransmitted.packets = 0;
1870 expected.fec.packets = 0;
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001871 callback.Matches(ssrc, expected);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001872
1873 // Retransmit a frame.
1874 uint16_t seqno = rtp_sender_->SequenceNumber() - 1;
Erik Språnga12b1d62018-03-14 12:39:24 +01001875 rtp_sender_->ReSendPacket(seqno);
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001876 expected.transmitted.payload_bytes = 12;
1877 expected.transmitted.header_bytes = 24;
1878 expected.transmitted.packets = 2;
1879 expected.retransmitted.payload_bytes = 6;
1880 expected.retransmitted.header_bytes = 12;
1881 expected.retransmitted.padding_bytes = 0;
1882 expected.retransmitted.packets = 1;
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001883 callback.Matches(ssrc, expected);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001884
1885 // Send padding.
Erik Språng4208a132019-08-26 08:58:45 +02001886 GenerateAndSendPadding(kMaxPaddingSize);
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001887 expected.transmitted.payload_bytes = 12;
1888 expected.transmitted.header_bytes = 36;
1889 expected.transmitted.padding_bytes = kMaxPaddingSize;
1890 expected.transmitted.packets = 3;
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001891 callback.Matches(ssrc, expected);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001892
Erik Språngdc34a252019-10-04 15:17:29 +02001893 rtp_sender_->RegisterRtpStatisticsCallback(nullptr);
1894}
1895
1896TEST_P(RtpSenderTestWithoutPacer, StreamDataCountersCallbacksUlpfec) {
1897 StreamDataTestCallback callback;
1898
1899 const uint8_t kRedPayloadType = 96;
1900 const uint8_t kUlpfecPayloadType = 97;
1901 const uint8_t kPayloadType = 127;
1902 const VideoCodecType kCodecType = VideoCodecType::kVideoCodecGeneric;
1903 PlayoutDelayOracle playout_delay_oracle;
1904 FieldTrialBasedConfig field_trials;
1905 RTPSenderVideo::Config video_config;
1906 video_config.clock = &fake_clock_;
1907 video_config.rtp_sender = rtp_sender_.get();
1908 video_config.playout_delay_oracle = &playout_delay_oracle;
1909 video_config.field_trials = &field_trials;
1910 video_config.red_payload_type = kRedPayloadType;
1911 video_config.ulpfec_payload_type = kUlpfecPayloadType;
1912 RTPSenderVideo rtp_sender_video(video_config);
1913 uint8_t payload[] = {47, 11, 32, 93, 89};
1914 rtp_sender_->SetStorePacketsStatus(true, 1);
1915 uint32_t ssrc = rtp_sender_->SSRC();
1916
1917 rtp_sender_->RegisterRtpStatisticsCallback(&callback);
1918
1919 RTPVideoHeader video_header;
1920 StreamDataCounters expected;
1921
brandtrf1bb4762016-11-07 03:05:06 -08001922 // Send ULPFEC.
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001923 FecProtectionParams fec_params;
1924 fec_params.fec_mask_type = kFecMaskRandom;
1925 fec_params.fec_rate = 1;
1926 fec_params.max_fec_frames = 1;
Niels Möller59ab1cf2019-02-06 22:48:11 +01001927 rtp_sender_video.SetFecParameters(fec_params, fec_params);
1928 ASSERT_TRUE(rtp_sender_video.SendVideo(
Erik Språng6cf554e2019-10-02 20:55:39 +02001929 VideoFrameType::kVideoFrameDelta, kPayloadType, kCodecType, 1234, 4321,
1930 payload, sizeof(payload), nullptr, &video_header,
Niels Möller8f7ce222019-03-21 15:43:58 +01001931 kDefaultExpectedRetransmissionTimeMs));
Erik Språngdc34a252019-10-04 15:17:29 +02001932 expected.transmitted.payload_bytes = 28;
1933 expected.transmitted.header_bytes = 24;
1934 expected.transmitted.packets = 2;
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001935 expected.fec.packets = 1;
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001936 callback.Matches(ssrc, expected);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001937
sprang867fb522015-08-03 04:38:41 -07001938 rtp_sender_->RegisterRtpStatisticsCallback(nullptr);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001939}
1940
minyue3a407ee2017-04-03 01:10:33 -07001941TEST_P(RtpSenderTestWithoutPacer, BytesReportedCorrectly) {
Niels Möller59ab1cf2019-02-06 22:48:11 +01001942 // XXX const char* kPayloadName = "GENERIC";
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001943 const uint8_t kPayloadType = 127;
Shao Changbine62202f2015-04-21 20:24:50 +08001944 rtp_sender_->SetRtxPayloadType(kPayloadType - 1, kPayloadType);
pbos@webrtc.org0b0c2412015-01-13 14:15:15 +00001945 rtp_sender_->SetRtxStatus(kRtxRetransmitted | kRtxRedundantPayloads);
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001946
Niels Möller59ab1cf2019-02-06 22:48:11 +01001947 SendGenericPacket();
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +00001948 // Will send 2 full-size padding packets.
Erik Språng4208a132019-08-26 08:58:45 +02001949 GenerateAndSendPadding(1);
1950 GenerateAndSendPadding(1);
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001951
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +00001952 StreamDataCounters rtp_stats;
1953 StreamDataCounters rtx_stats;
1954 rtp_sender_->GetDataCounters(&rtp_stats, &rtx_stats);
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001955
Niels Möller59ab1cf2019-02-06 22:48:11 +01001956 // Payload
asapersson@webrtc.orgd08d3892014-12-16 12:03:11 +00001957 EXPECT_GT(rtp_stats.first_packet_time_ms, -1);
Niels Möller59ab1cf2019-02-06 22:48:11 +01001958 EXPECT_EQ(rtp_stats.transmitted.payload_bytes, sizeof(kPayloadData));
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001959 EXPECT_EQ(rtp_stats.transmitted.header_bytes, 12u);
1960 EXPECT_EQ(rtp_stats.transmitted.padding_bytes, 0u);
1961 EXPECT_EQ(rtx_stats.transmitted.payload_bytes, 0u);
1962 EXPECT_EQ(rtx_stats.transmitted.header_bytes, 24u);
1963 EXPECT_EQ(rtx_stats.transmitted.padding_bytes, 2 * kMaxPaddingSize);
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +00001964
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001965 EXPECT_EQ(rtp_stats.transmitted.TotalBytes(),
danilchap162abd32015-12-10 02:39:40 -08001966 rtp_stats.transmitted.payload_bytes +
1967 rtp_stats.transmitted.header_bytes +
1968 rtp_stats.transmitted.padding_bytes);
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001969 EXPECT_EQ(rtx_stats.transmitted.TotalBytes(),
danilchap162abd32015-12-10 02:39:40 -08001970 rtx_stats.transmitted.payload_bytes +
1971 rtx_stats.transmitted.header_bytes +
1972 rtx_stats.transmitted.padding_bytes);
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001973
danilchap162abd32015-12-10 02:39:40 -08001974 EXPECT_EQ(
1975 transport_.total_bytes_sent_,
1976 rtp_stats.transmitted.TotalBytes() + rtx_stats.transmitted.TotalBytes());
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001977}
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001978
minyue3a407ee2017-04-03 01:10:33 -07001979TEST_P(RtpSenderTestWithoutPacer, RespectsNackBitrateLimit) {
sprang38778b02015-09-29 09:48:22 -07001980 const int32_t kPacketSize = 1400;
1981 const int32_t kNumPackets = 30;
1982
sprangcd349d92016-07-13 09:11:28 -07001983 retransmission_rate_limiter_.SetMaxRate(kPacketSize * kNumPackets * 8);
1984
sprang38778b02015-09-29 09:48:22 -07001985 rtp_sender_->SetStorePacketsStatus(true, kNumPackets);
sprang38778b02015-09-29 09:48:22 -07001986 const uint16_t kStartSequenceNumber = rtp_sender_->SequenceNumber();
Danil Chapovalov2800d742016-08-26 18:48:46 +02001987 std::vector<uint16_t> sequence_numbers;
sprang38778b02015-09-29 09:48:22 -07001988 for (int32_t i = 0; i < kNumPackets; ++i) {
1989 sequence_numbers.push_back(kStartSequenceNumber + i);
1990 fake_clock_.AdvanceTimeMilliseconds(1);
1991 SendPacket(fake_clock_.TimeInMilliseconds(), kPacketSize);
1992 }
danilchap12ba1862016-10-26 02:41:55 -07001993 EXPECT_EQ(kNumPackets, transport_.packets_sent());
sprang38778b02015-09-29 09:48:22 -07001994
1995 fake_clock_.AdvanceTimeMilliseconds(1000 - kNumPackets);
1996
1997 // Resending should work - brings the bandwidth up to the limit.
1998 // NACK bitrate is capped to the same bitrate as the encoder, since the max
1999 // protection overhead is 50% (see MediaOptimization::SetTargetRates).
Danil Chapovalov2800d742016-08-26 18:48:46 +02002000 rtp_sender_->OnReceivedNack(sequence_numbers, 0);
danilchap12ba1862016-10-26 02:41:55 -07002001 EXPECT_EQ(kNumPackets * 2, transport_.packets_sent());
sprang38778b02015-09-29 09:48:22 -07002002
sprangcd349d92016-07-13 09:11:28 -07002003 // Must be at least 5ms in between retransmission attempts.
2004 fake_clock_.AdvanceTimeMilliseconds(5);
2005
sprang38778b02015-09-29 09:48:22 -07002006 // Resending should not work, bandwidth exceeded.
Danil Chapovalov2800d742016-08-26 18:48:46 +02002007 rtp_sender_->OnReceivedNack(sequence_numbers, 0);
danilchap12ba1862016-10-26 02:41:55 -07002008 EXPECT_EQ(kNumPackets * 2, transport_.packets_sent());
sprang38778b02015-09-29 09:48:22 -07002009}
2010
minyue3a407ee2017-04-03 01:10:33 -07002011TEST_P(RtpSenderTest, OnOverheadChanged) {
michaelt4da30442016-11-17 01:38:43 -08002012 MockOverheadObserver mock_overhead_observer;
Erik Språng4580ca22019-07-04 10:38:43 +02002013 RtpRtcp::Configuration config;
2014 config.clock = &fake_clock_;
2015 config.outgoing_transport = &transport_;
Erik Språng54d5d2c2019-08-20 17:22:36 +02002016 config.local_media_ssrc = kSsrc;
Erik Språng4580ca22019-07-04 10:38:43 +02002017 config.retransmission_rate_limiter = &retransmission_rate_limiter_;
2018 config.overhead_observer = &mock_overhead_observer;
Mirko Bonadei317a1f02019-09-17 17:06:18 +02002019 rtp_sender_ = std::make_unique<RTPSender>(config);
michaelt4da30442016-11-17 01:38:43 -08002020
michaelt4da30442016-11-17 01:38:43 -08002021 // RTP overhead is 12B.
nisse284542b2017-01-10 08:58:32 -08002022 EXPECT_CALL(mock_overhead_observer, OnOverheadChanged(12)).Times(1);
Niels Möllere7b9e6b2019-02-06 18:23:44 +01002023 SendGenericPacket();
michaelt4da30442016-11-17 01:38:43 -08002024
2025 rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionTransmissionTimeOffset,
2026 kTransmissionTimeOffsetExtensionId);
2027
2028 // TransmissionTimeOffset extension has a size of 8B.
nisse284542b2017-01-10 08:58:32 -08002029 // 12B + 8B = 20B
2030 EXPECT_CALL(mock_overhead_observer, OnOverheadChanged(20)).Times(1);
Niels Möllere7b9e6b2019-02-06 18:23:44 +01002031 SendGenericPacket();
michaelt4da30442016-11-17 01:38:43 -08002032}
2033
minyue3a407ee2017-04-03 01:10:33 -07002034TEST_P(RtpSenderTest, DoesNotUpdateOverheadOnEqualSize) {
michaelt4da30442016-11-17 01:38:43 -08002035 MockOverheadObserver mock_overhead_observer;
Erik Språng4580ca22019-07-04 10:38:43 +02002036 RtpRtcp::Configuration config;
2037 config.clock = &fake_clock_;
2038 config.outgoing_transport = &transport_;
Erik Språng54d5d2c2019-08-20 17:22:36 +02002039 config.local_media_ssrc = kSsrc;
Erik Språng4580ca22019-07-04 10:38:43 +02002040 config.retransmission_rate_limiter = &retransmission_rate_limiter_;
2041 config.overhead_observer = &mock_overhead_observer;
Mirko Bonadei317a1f02019-09-17 17:06:18 +02002042 rtp_sender_ = std::make_unique<RTPSender>(config);
michaelt4da30442016-11-17 01:38:43 -08002043
2044 EXPECT_CALL(mock_overhead_observer, OnOverheadChanged(_)).Times(1);
Niels Möllere7b9e6b2019-02-06 18:23:44 +01002045 SendGenericPacket();
2046 SendGenericPacket();
michaelt4da30442016-11-17 01:38:43 -08002047}
2048
Erik Språng9c771c22019-06-17 16:31:53 +02002049TEST_P(RtpSenderTest, TrySendPacketMatchesVideo) {
2050 std::unique_ptr<RtpPacketToSend> packet =
2051 BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2052 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
2053
2054 // Verify not sent with wrong SSRC.
2055 packet->SetSsrc(kSsrc + 1);
2056 EXPECT_FALSE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2057
2058 // Verify sent with correct SSRC.
2059 packet = BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2060 packet->SetSsrc(kSsrc);
2061 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
2062 EXPECT_TRUE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2063}
2064
2065TEST_P(RtpSenderTest, TrySendPacketMatchesAudio) {
2066 std::unique_ptr<RtpPacketToSend> packet =
2067 BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2068 packet->set_packet_type(RtpPacketToSend::Type::kAudio);
2069
2070 // Verify not sent with wrong SSRC.
2071 packet->SetSsrc(kSsrc + 1);
2072 EXPECT_FALSE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2073
2074 // Verify sent with correct SSRC.
2075 packet = BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2076 packet->SetSsrc(kSsrc);
2077 packet->set_packet_type(RtpPacketToSend::Type::kAudio);
2078 EXPECT_TRUE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2079}
2080
2081TEST_P(RtpSenderTest, TrySendPacketMatchesRetransmissions) {
2082 std::unique_ptr<RtpPacketToSend> packet =
2083 BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2084 packet->set_packet_type(RtpPacketToSend::Type::kRetransmission);
2085
2086 // Verify not sent with wrong SSRC.
2087 packet->SetSsrc(kSsrc + 1);
2088 EXPECT_FALSE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2089
2090 // Verify sent with correct SSRC (non-RTX).
2091 packet = BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2092 packet->SetSsrc(kSsrc);
2093 packet->set_packet_type(RtpPacketToSend::Type::kRetransmission);
2094 EXPECT_TRUE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2095
2096 // RTX retransmission.
2097 packet = BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2098 packet->SetSsrc(kRtxSsrc);
2099 packet->set_packet_type(RtpPacketToSend::Type::kRetransmission);
2100 EXPECT_TRUE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2101}
2102
2103TEST_P(RtpSenderTest, TrySendPacketMatchesPadding) {
2104 std::unique_ptr<RtpPacketToSend> packet =
2105 BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2106 packet->set_packet_type(RtpPacketToSend::Type::kPadding);
2107
2108 // Verify not sent with wrong SSRC.
2109 packet->SetSsrc(kSsrc + 1);
2110 EXPECT_FALSE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2111
2112 // Verify sent with correct SSRC (non-RTX).
2113 packet = BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2114 packet->SetSsrc(kSsrc);
2115 packet->set_packet_type(RtpPacketToSend::Type::kPadding);
2116 EXPECT_TRUE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2117
2118 // RTX padding.
2119 packet = BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2120 packet->SetSsrc(kRtxSsrc);
2121 packet->set_packet_type(RtpPacketToSend::Type::kPadding);
2122 EXPECT_TRUE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2123}
2124
2125TEST_P(RtpSenderTest, TrySendPacketMatchesFlexfec) {
2126 std::unique_ptr<RtpPacketToSend> packet =
2127 BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2128 packet->set_packet_type(RtpPacketToSend::Type::kForwardErrorCorrection);
2129
2130 // Verify not sent with wrong SSRC.
2131 packet->SetSsrc(kSsrc + 1);
2132 EXPECT_FALSE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2133
2134 // Verify sent with correct SSRC.
2135 packet = BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2136 packet->SetSsrc(kFlexFecSsrc);
2137 packet->set_packet_type(RtpPacketToSend::Type::kForwardErrorCorrection);
2138 EXPECT_TRUE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2139}
2140
2141TEST_P(RtpSenderTest, TrySendPacketMatchesUlpfec) {
2142 std::unique_ptr<RtpPacketToSend> packet =
2143 BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2144 packet->set_packet_type(RtpPacketToSend::Type::kForwardErrorCorrection);
2145
2146 // Verify not sent with wrong SSRC.
2147 packet->SetSsrc(kSsrc + 1);
2148 EXPECT_FALSE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2149
2150 // Verify sent with correct SSRC.
2151 packet = BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2152 packet->SetSsrc(kSsrc);
2153 packet->set_packet_type(RtpPacketToSend::Type::kForwardErrorCorrection);
2154 EXPECT_TRUE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2155}
2156
2157TEST_P(RtpSenderTest, TrySendPacketHandlesRetransmissionHistory) {
2158 rtp_sender_->SetStorePacketsStatus(true, 10);
2159
2160 // Build a media packet and send it.
2161 std::unique_ptr<RtpPacketToSend> packet =
2162 BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2163 const uint16_t media_sequence_number = packet->SequenceNumber();
2164 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
2165 packet->set_allow_retransmission(true);
2166 EXPECT_TRUE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2167
2168 // Simulate retransmission request.
2169 fake_clock_.AdvanceTimeMilliseconds(30);
2170 EXPECT_GT(rtp_sender_->ReSendPacket(media_sequence_number), 0);
2171
2172 // Packet already pending, retransmission not allowed.
2173 fake_clock_.AdvanceTimeMilliseconds(30);
2174 EXPECT_EQ(rtp_sender_->ReSendPacket(media_sequence_number), 0);
2175
2176 // Packet exiting pacer, mark as not longer pending.
2177 packet = BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2178 EXPECT_NE(packet->SequenceNumber(), media_sequence_number);
2179 packet->set_packet_type(RtpPacketToSend::Type::kRetransmission);
2180 packet->SetSsrc(kRtxSsrc);
2181 packet->set_retransmitted_sequence_number(media_sequence_number);
2182 packet->set_allow_retransmission(false);
2183 EXPECT_TRUE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2184
2185 // Retransmissions allowed again.
2186 fake_clock_.AdvanceTimeMilliseconds(30);
2187 EXPECT_GT(rtp_sender_->ReSendPacket(media_sequence_number), 0);
2188
2189 // Retransmission of RTX packet should not be allowed.
2190 EXPECT_EQ(rtp_sender_->ReSendPacket(packet->SequenceNumber()), 0);
2191}
2192
2193TEST_P(RtpSenderTest, TrySendPacketUpdatesExtensions) {
2194 ASSERT_EQ(rtp_sender_->RegisterRtpHeaderExtension(
2195 kRtpExtensionTransmissionTimeOffset,
2196 kTransmissionTimeOffsetExtensionId),
2197 0);
2198 ASSERT_EQ(rtp_sender_->RegisterRtpHeaderExtension(
2199 kRtpExtensionAbsoluteSendTime, kAbsoluteSendTimeExtensionId),
2200 0);
2201 ASSERT_EQ(rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionVideoTiming,
2202 kVideoTimingExtensionId),
2203 0);
2204
2205 std::unique_ptr<RtpPacketToSend> packet =
2206 BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2207 packet->set_packetization_finish_time_ms(fake_clock_.TimeInMilliseconds());
2208
2209 const int32_t kDiffMs = 10;
2210 fake_clock_.AdvanceTimeMilliseconds(kDiffMs);
2211
2212 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
2213 EXPECT_TRUE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2214
2215 const RtpPacketReceived& received_packet = transport_.last_sent_packet();
2216
2217 EXPECT_EQ(received_packet.GetExtension<TransmissionOffset>(), kDiffMs * 90);
2218
2219 EXPECT_EQ(received_packet.GetExtension<AbsoluteSendTime>(),
2220 AbsoluteSendTime::MsTo24Bits(fake_clock_.TimeInMilliseconds()));
2221
2222 VideoSendTiming timing;
2223 EXPECT_TRUE(received_packet.GetExtension<VideoTimingExtension>(&timing));
2224 EXPECT_EQ(timing.pacer_exit_delta_ms, kDiffMs);
2225}
2226
2227TEST_P(RtpSenderTest, TrySendPacketSetsPacketOptions) {
2228 const uint16_t kPacketId = 42;
2229 ASSERT_EQ(rtp_sender_->RegisterRtpHeaderExtension(
2230 kRtpExtensionTransportSequenceNumber,
2231 kTransportSequenceNumberExtensionId),
2232 0);
2233 std::unique_ptr<RtpPacketToSend> packet =
2234 BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2235 packet->SetExtension<TransportSequenceNumber>(kPacketId);
2236
2237 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
2238 EXPECT_CALL(send_packet_observer_, OnSendPacket);
2239 EXPECT_TRUE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2240
2241 EXPECT_EQ(transport_.last_options_.packet_id, kPacketId);
2242 EXPECT_TRUE(transport_.last_options_.included_in_allocation);
2243 EXPECT_TRUE(transport_.last_options_.included_in_feedback);
2244 EXPECT_FALSE(transport_.last_options_.is_retransmit);
2245
2246 // Send another packet as retransmission, verify options are populated.
2247 packet = BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2248 packet->SetExtension<TransportSequenceNumber>(kPacketId + 1);
2249 packet->set_packet_type(RtpPacketToSend::Type::kRetransmission);
2250 EXPECT_TRUE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2251 EXPECT_TRUE(transport_.last_options_.is_retransmit);
2252}
2253
2254TEST_P(RtpSenderTest, TrySendPacketUpdatesStats) {
2255 const size_t kPayloadSize = 1000;
2256
2257 StrictMock<MockSendSideDelayObserver> send_side_delay_observer;
Erik Språng4580ca22019-07-04 10:38:43 +02002258
2259 RtpRtcp::Configuration config;
2260 config.clock = &fake_clock_;
2261 config.outgoing_transport = &transport_;
Erik Språng54d5d2c2019-08-20 17:22:36 +02002262 config.local_media_ssrc = kSsrc;
Erik Språng4580ca22019-07-04 10:38:43 +02002263 config.rtx_send_ssrc = kRtxSsrc;
2264 config.flexfec_sender = &flexfec_sender_;
2265 config.send_side_delay_observer = &send_side_delay_observer;
2266 config.event_log = &mock_rtc_event_log_;
2267 config.send_packet_observer = &send_packet_observer_;
Mirko Bonadei317a1f02019-09-17 17:06:18 +02002268 rtp_sender_ = std::make_unique<RTPSender>(config);
Erik Språng9c771c22019-06-17 16:31:53 +02002269 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
2270 kRtpExtensionTransportSequenceNumber,
2271 kTransportSequenceNumberExtensionId));
2272
2273 const int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
2274
2275 std::unique_ptr<RtpPacketToSend> video_packet =
2276 BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2277 video_packet->set_packet_type(RtpPacketToSend::Type::kVideo);
2278 video_packet->SetPayloadSize(kPayloadSize);
2279 video_packet->SetExtension<TransportSequenceNumber>(1);
2280
2281 std::unique_ptr<RtpPacketToSend> rtx_packet =
2282 BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2283 rtx_packet->SetSsrc(kRtxSsrc);
2284 rtx_packet->set_packet_type(RtpPacketToSend::Type::kRetransmission);
2285 rtx_packet->SetPayloadSize(kPayloadSize);
2286 rtx_packet->SetExtension<TransportSequenceNumber>(2);
2287
2288 std::unique_ptr<RtpPacketToSend> fec_packet =
2289 BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2290 fec_packet->SetSsrc(kFlexFecSsrc);
2291 fec_packet->set_packet_type(RtpPacketToSend::Type::kForwardErrorCorrection);
2292 fec_packet->SetPayloadSize(kPayloadSize);
2293 fec_packet->SetExtension<TransportSequenceNumber>(3);
2294
2295 const int64_t kDiffMs = 25;
2296 fake_clock_.AdvanceTimeMilliseconds(kDiffMs);
2297
2298 EXPECT_CALL(send_side_delay_observer,
2299 SendSideDelayUpdated(kDiffMs, kDiffMs, kDiffMs, kSsrc));
2300 EXPECT_CALL(
2301 send_side_delay_observer,
2302 SendSideDelayUpdated(kDiffMs, kDiffMs, 2 * kDiffMs, kFlexFecSsrc));
2303
2304 EXPECT_CALL(send_packet_observer_, OnSendPacket(1, capture_time_ms, kSsrc));
2305 EXPECT_TRUE(
2306 rtp_sender_->TrySendPacket(video_packet.get(), PacedPacketInfo()));
2307
2308 // Send packet observer not called for padding/retransmissions.
2309 EXPECT_CALL(send_packet_observer_, OnSendPacket(2, _, _)).Times(0);
2310 EXPECT_TRUE(rtp_sender_->TrySendPacket(rtx_packet.get(), PacedPacketInfo()));
2311
2312 EXPECT_CALL(send_packet_observer_,
2313 OnSendPacket(3, capture_time_ms, kFlexFecSsrc));
2314 EXPECT_TRUE(rtp_sender_->TrySendPacket(fec_packet.get(), PacedPacketInfo()));
2315
2316 StreamDataCounters rtp_stats;
2317 StreamDataCounters rtx_stats;
2318 rtp_sender_->GetDataCounters(&rtp_stats, &rtx_stats);
2319 EXPECT_EQ(rtp_stats.transmitted.packets, 2u);
2320 EXPECT_EQ(rtp_stats.fec.packets, 1u);
2321 EXPECT_EQ(rtx_stats.retransmitted.packets, 1u);
2322}
2323
Erik Språng478cb462019-06-26 15:49:27 +02002324TEST_P(RtpSenderTest, GeneratePaddingResendsOldPacketsWithRtx) {
Mirko Bonadeia7e3bce2019-07-12 17:35:56 +00002325 // Min requested size in order to use RTX payload.
2326 const size_t kMinPaddingSize = 50;
2327
Erik Språng478cb462019-06-26 15:49:27 +02002328 rtp_sender_->SetRtxStatus(kRtxRetransmitted | kRtxRedundantPayloads);
2329 rtp_sender_->SetRtxPayloadType(kRtxPayload, kPayload);
2330 rtp_sender_->SetStorePacketsStatus(true, 1);
2331
Erik Språng0f6191d2019-07-15 20:33:40 +02002332 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
2333 kRtpExtensionTransmissionTimeOffset,
2334 kTransmissionTimeOffsetExtensionId));
2335 ASSERT_EQ(
2336 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
2337 kAbsoluteSendTimeExtensionId));
2338 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
2339 kRtpExtensionTransportSequenceNumber,
2340 kTransportSequenceNumberExtensionId));
2341
Erik Språng478cb462019-06-26 15:49:27 +02002342 const size_t kPayloadPacketSize = 1234;
2343 std::unique_ptr<RtpPacketToSend> packet =
2344 BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2345 packet->set_allow_retransmission(true);
2346 packet->SetPayloadSize(kPayloadPacketSize);
2347 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
2348
2349 // Send a dummy video packet so it ends up in the packet history.
Erik Språng0f6191d2019-07-15 20:33:40 +02002350 EXPECT_CALL(send_packet_observer_, OnSendPacket).Times(1);
Erik Språng478cb462019-06-26 15:49:27 +02002351 EXPECT_TRUE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2352
2353 // Generated padding has large enough budget that the video packet should be
2354 // retransmitted as padding.
Erik Språngf6468d22019-07-05 16:53:43 +02002355 std::vector<std::unique_ptr<RtpPacketToSend>> generated_packets =
Mirko Bonadeia7e3bce2019-07-12 17:35:56 +00002356 rtp_sender_->GeneratePadding(kMinPaddingSize);
Erik Språngf6468d22019-07-05 16:53:43 +02002357 ASSERT_EQ(generated_packets.size(), 1u);
2358 auto& padding_packet = generated_packets.front();
2359 EXPECT_EQ(padding_packet->packet_type(), RtpPacketToSend::Type::kPadding);
2360 EXPECT_EQ(padding_packet->Ssrc(), kRtxSsrc);
2361 EXPECT_EQ(padding_packet->payload_size(),
2362 kPayloadPacketSize + kRtxHeaderSize);
Erik Språng0f6191d2019-07-15 20:33:40 +02002363 EXPECT_TRUE(padding_packet->IsExtensionReserved<TransportSequenceNumber>());
2364 EXPECT_TRUE(padding_packet->IsExtensionReserved<AbsoluteSendTime>());
2365 EXPECT_TRUE(padding_packet->IsExtensionReserved<TransmissionOffset>());
2366
2367 // Verify all header extensions are received.
2368 EXPECT_TRUE(
2369 rtp_sender_->TrySendPacket(padding_packet.get(), PacedPacketInfo()));
2370 webrtc::RTPHeader rtp_header;
2371 transport_.last_sent_packet().GetHeader(&rtp_header);
2372 EXPECT_TRUE(rtp_header.extension.hasAbsoluteSendTime);
2373 EXPECT_TRUE(rtp_header.extension.hasTransmissionTimeOffset);
2374 EXPECT_TRUE(rtp_header.extension.hasTransportSequenceNumber);
Erik Språng478cb462019-06-26 15:49:27 +02002375
2376 // Not enough budged for payload padding, use plain padding instead.
Mirko Bonadeia7e3bce2019-07-12 17:35:56 +00002377 const size_t kPaddingBytesRequested = kMinPaddingSize - 1;
Erik Språngf6468d22019-07-05 16:53:43 +02002378
2379 size_t padding_bytes_generated = 0;
2380 generated_packets = rtp_sender_->GeneratePadding(kPaddingBytesRequested);
Mirko Bonadeia7e3bce2019-07-12 17:35:56 +00002381 EXPECT_EQ(generated_packets.size(), 1u);
Erik Språngf6468d22019-07-05 16:53:43 +02002382 for (auto& packet : generated_packets) {
2383 EXPECT_EQ(packet->packet_type(), RtpPacketToSend::Type::kPadding);
2384 EXPECT_EQ(packet->Ssrc(), kRtxSsrc);
2385 EXPECT_EQ(packet->payload_size(), 0u);
2386 EXPECT_GT(packet->padding_size(), 0u);
2387 padding_bytes_generated += packet->padding_size();
Erik Språng0f6191d2019-07-15 20:33:40 +02002388
2389 EXPECT_TRUE(packet->IsExtensionReserved<TransportSequenceNumber>());
2390 EXPECT_TRUE(packet->IsExtensionReserved<AbsoluteSendTime>());
2391 EXPECT_TRUE(packet->IsExtensionReserved<TransmissionOffset>());
2392
2393 // Verify all header extensions are received.
2394 EXPECT_TRUE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2395 webrtc::RTPHeader rtp_header;
2396 transport_.last_sent_packet().GetHeader(&rtp_header);
2397 EXPECT_TRUE(rtp_header.extension.hasAbsoluteSendTime);
2398 EXPECT_TRUE(rtp_header.extension.hasTransmissionTimeOffset);
2399 EXPECT_TRUE(rtp_header.extension.hasTransportSequenceNumber);
Erik Språngf6468d22019-07-05 16:53:43 +02002400 }
2401
Mirko Bonadeia7e3bce2019-07-12 17:35:56 +00002402 EXPECT_EQ(padding_bytes_generated, kMaxPaddingSize);
Erik Språng478cb462019-06-26 15:49:27 +02002403}
2404
2405TEST_P(RtpSenderTest, GeneratePaddingCreatesPurePaddingWithoutRtx) {
2406 rtp_sender_->SetStorePacketsStatus(true, 1);
Erik Språng0f6191d2019-07-15 20:33:40 +02002407 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
2408 kRtpExtensionTransmissionTimeOffset,
2409 kTransmissionTimeOffsetExtensionId));
2410 ASSERT_EQ(
2411 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
2412 kAbsoluteSendTimeExtensionId));
2413 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
2414 kRtpExtensionTransportSequenceNumber,
2415 kTransportSequenceNumberExtensionId));
Erik Språng478cb462019-06-26 15:49:27 +02002416
2417 const size_t kPayloadPacketSize = 1234;
2418 // Send a dummy video packet so it ends up in the packet history. Since we
2419 // are not using RTX, it should never be used as padding.
2420 std::unique_ptr<RtpPacketToSend> packet =
2421 BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2422 packet->set_allow_retransmission(true);
2423 packet->SetPayloadSize(kPayloadPacketSize);
2424 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
Erik Språng0f6191d2019-07-15 20:33:40 +02002425 EXPECT_CALL(send_packet_observer_, OnSendPacket).Times(1);
Erik Språng478cb462019-06-26 15:49:27 +02002426 EXPECT_TRUE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2427
2428 // Payload padding not available without RTX, only generate plain padding on
2429 // the media SSRC.
2430 // Number of padding packets is the requested padding size divided by max
2431 // padding packet size, rounded up. Pure padding packets are always of the
2432 // maximum size.
2433 const size_t kPaddingBytesRequested = kPayloadPacketSize + kRtxHeaderSize;
2434 const size_t kExpectedNumPaddingPackets =
2435 (kPaddingBytesRequested + kMaxPaddingSize - 1) / kMaxPaddingSize;
Erik Språngf6468d22019-07-05 16:53:43 +02002436 size_t padding_bytes_generated = 0;
2437 std::vector<std::unique_ptr<RtpPacketToSend>> padding_packets =
2438 rtp_sender_->GeneratePadding(kPaddingBytesRequested);
2439 EXPECT_EQ(padding_packets.size(), kExpectedNumPaddingPackets);
2440 for (auto& packet : padding_packets) {
2441 EXPECT_EQ(packet->packet_type(), RtpPacketToSend::Type::kPadding);
2442 EXPECT_EQ(packet->Ssrc(), kSsrc);
2443 EXPECT_EQ(packet->payload_size(), 0u);
2444 EXPECT_GT(packet->padding_size(), 0u);
2445 padding_bytes_generated += packet->padding_size();
Erik Språng0f6191d2019-07-15 20:33:40 +02002446 EXPECT_TRUE(packet->IsExtensionReserved<TransportSequenceNumber>());
2447 EXPECT_TRUE(packet->IsExtensionReserved<AbsoluteSendTime>());
2448 EXPECT_TRUE(packet->IsExtensionReserved<TransmissionOffset>());
2449
2450 // Verify all header extensions are received.
2451 EXPECT_TRUE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2452 webrtc::RTPHeader rtp_header;
2453 transport_.last_sent_packet().GetHeader(&rtp_header);
2454 EXPECT_TRUE(rtp_header.extension.hasAbsoluteSendTime);
2455 EXPECT_TRUE(rtp_header.extension.hasTransmissionTimeOffset);
2456 EXPECT_TRUE(rtp_header.extension.hasTransportSequenceNumber);
Erik Språngf6468d22019-07-05 16:53:43 +02002457 }
2458
2459 EXPECT_EQ(padding_bytes_generated,
2460 kExpectedNumPaddingPackets * kMaxPaddingSize);
Erik Språng478cb462019-06-26 15:49:27 +02002461}
2462
Mirko Bonadei999a72a2019-07-12 17:33:46 +00002463TEST_P(RtpSenderTest, SupportsPadding) {
2464 bool kSendingMediaStats[] = {true, false};
2465 bool kEnableRedundantPayloads[] = {true, false};
2466 RTPExtensionType kBweExtensionTypes[] = {
2467 kRtpExtensionTransportSequenceNumber,
2468 kRtpExtensionTransportSequenceNumber02, kRtpExtensionAbsoluteSendTime,
2469 kRtpExtensionTransmissionTimeOffset};
2470 const int kExtensionsId = 7;
2471
2472 for (bool sending_media : kSendingMediaStats) {
2473 rtp_sender_->SetSendingMediaStatus(sending_media);
2474 for (bool redundant_payloads : kEnableRedundantPayloads) {
2475 int rtx_mode = kRtxRetransmitted;
2476 if (redundant_payloads) {
2477 rtx_mode |= kRtxRedundantPayloads;
2478 }
2479 rtp_sender_->SetRtxStatus(rtx_mode);
2480
2481 for (auto extension_type : kBweExtensionTypes) {
2482 EXPECT_FALSE(rtp_sender_->SupportsPadding());
2483 rtp_sender_->RegisterRtpHeaderExtension(extension_type, kExtensionsId);
2484 if (!sending_media) {
2485 EXPECT_FALSE(rtp_sender_->SupportsPadding());
2486 } else {
2487 EXPECT_TRUE(rtp_sender_->SupportsPadding());
2488 if (redundant_payloads) {
2489 EXPECT_TRUE(rtp_sender_->SupportsRtxPayloadPadding());
2490 } else {
2491 EXPECT_FALSE(rtp_sender_->SupportsRtxPayloadPadding());
2492 }
2493 }
2494 rtp_sender_->DeregisterRtpHeaderExtension(extension_type);
2495 EXPECT_FALSE(rtp_sender_->SupportsPadding());
2496 }
2497 }
2498 }
2499}
2500
Erik Språnga57711c2019-07-24 10:47:20 +02002501TEST_P(RtpSenderTest, SetsCaptureTimeAndPopulatesTransmissionOffset) {
2502 rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionTransmissionTimeOffset,
2503 kTransmissionTimeOffsetExtensionId);
2504
2505 rtp_sender_->SetSendingMediaStatus(true);
2506 rtp_sender_->SetRtxStatus(kRtxRetransmitted | kRtxRedundantPayloads);
2507 rtp_sender_->SetRtxPayloadType(kRtxPayload, kPayload);
2508 rtp_sender_->SetStorePacketsStatus(true, 10);
2509
2510 const int64_t kMissingCaptureTimeMs = 0;
2511 const uint32_t kTimestampTicksPerMs = 90;
2512 const int64_t kOffsetMs = 10;
2513
Erik Språnga57711c2019-07-24 10:47:20 +02002514 auto packet =
2515 BuildRtpPacket(kPayload, kMarkerBit, fake_clock_.TimeInMilliseconds(),
2516 kMissingCaptureTimeMs);
2517 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
2518 packet->ReserveExtension<TransmissionOffset>();
2519 packet->AllocatePayload(sizeof(kPayloadData));
2520
2521 std::unique_ptr<RtpPacketToSend> packet_to_pace;
Erik Språngea55b082019-10-02 14:57:46 +02002522 EXPECT_CALL(mock_paced_sender_, EnqueuePackets)
2523 .WillOnce([&](std::vector<std::unique_ptr<RtpPacketToSend>> packets) {
2524 EXPECT_EQ(packets.size(), 1u);
2525 EXPECT_GT(packets[0]->capture_time_ms(), 0);
2526 packet_to_pace = std::move(packets[0]);
Erik Språnga57711c2019-07-24 10:47:20 +02002527 });
2528
Erik Språng70768f42019-08-27 18:16:26 +02002529 packet->set_allow_retransmission(true);
2530 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet)));
Erik Språnga57711c2019-07-24 10:47:20 +02002531
2532 fake_clock_.AdvanceTimeMilliseconds(kOffsetMs);
2533
2534 rtp_sender_->TrySendPacket(packet_to_pace.get(), PacedPacketInfo());
Erik Språnga57711c2019-07-24 10:47:20 +02002535
2536 EXPECT_EQ(1, transport_.packets_sent());
2537 absl::optional<int32_t> transmission_time_extension =
2538 transport_.sent_packets_.back().GetExtension<TransmissionOffset>();
2539 ASSERT_TRUE(transmission_time_extension.has_value());
2540 EXPECT_EQ(*transmission_time_extension, kOffsetMs * kTimestampTicksPerMs);
2541
2542 // Retransmit packet. The RTX packet should get the same capture time as the
2543 // original packet, so offset is delta from original packet to now.
2544 fake_clock_.AdvanceTimeMilliseconds(kOffsetMs);
2545
Erik Språnga57711c2019-07-24 10:47:20 +02002546 std::unique_ptr<RtpPacketToSend> rtx_packet_to_pace;
Erik Språngea55b082019-10-02 14:57:46 +02002547 EXPECT_CALL(mock_paced_sender_, EnqueuePackets)
2548 .WillOnce([&](std::vector<std::unique_ptr<RtpPacketToSend>> packets) {
2549 EXPECT_GT(packets[0]->capture_time_ms(), 0);
2550 rtx_packet_to_pace = std::move(packets[0]);
Erik Språnga57711c2019-07-24 10:47:20 +02002551 });
2552
2553 EXPECT_GT(rtp_sender_->ReSendPacket(kSeqNum), 0);
2554 rtp_sender_->TrySendPacket(rtx_packet_to_pace.get(), PacedPacketInfo());
Erik Språnga57711c2019-07-24 10:47:20 +02002555
2556 EXPECT_EQ(2, transport_.packets_sent());
2557 transmission_time_extension =
2558 transport_.sent_packets_.back().GetExtension<TransmissionOffset>();
2559 ASSERT_TRUE(transmission_time_extension.has_value());
2560 EXPECT_EQ(*transmission_time_extension, 2 * kOffsetMs * kTimestampTicksPerMs);
2561}
2562
Erik Språng6cacef22019-07-24 14:15:51 +02002563TEST_P(RtpSenderTestWithoutPacer, ClearHistoryOnSsrcChange) {
2564 const int64_t kRtt = 10;
2565
2566 rtp_sender_->SetSendingMediaStatus(true);
2567 rtp_sender_->SetRtxStatus(kRtxRetransmitted | kRtxRedundantPayloads);
2568 rtp_sender_->SetRtxPayloadType(kRtxPayload, kPayload);
2569 rtp_sender_->SetStorePacketsStatus(true, 10);
2570 rtp_sender_->SetRtt(kRtt);
Erik Språng6cacef22019-07-24 14:15:51 +02002571
2572 // Send a packet and record its sequence numbers.
2573 SendGenericPacket();
2574 ASSERT_EQ(1u, transport_.sent_packets_.size());
2575 const uint16_t packet_seqence_number =
2576 transport_.sent_packets_.back().SequenceNumber();
2577
2578 // Advance time and make sure it can be retransmitted, even if we try to set
2579 // the ssrc the what it already is.
2580 rtp_sender_->SetSSRC(kSsrc);
2581 fake_clock_.AdvanceTimeMilliseconds(kRtt);
2582 EXPECT_GT(rtp_sender_->ReSendPacket(packet_seqence_number), 0);
2583
2584 // Change the SSRC, then move the time and try to retransmit again. The old
2585 // packet should now be gone.
2586 rtp_sender_->SetSSRC(kSsrc + 1);
2587 fake_clock_.AdvanceTimeMilliseconds(kRtt);
2588 EXPECT_EQ(rtp_sender_->ReSendPacket(packet_seqence_number), 0);
2589}
2590
2591TEST_P(RtpSenderTestWithoutPacer, ClearHistoryOnSequenceNumberCange) {
2592 const int64_t kRtt = 10;
2593
2594 rtp_sender_->SetSendingMediaStatus(true);
2595 rtp_sender_->SetRtxStatus(kRtxRetransmitted | kRtxRedundantPayloads);
2596 rtp_sender_->SetRtxPayloadType(kRtxPayload, kPayload);
2597 rtp_sender_->SetStorePacketsStatus(true, 10);
2598 rtp_sender_->SetRtt(kRtt);
2599
2600 // Send a packet and record its sequence numbers.
2601 SendGenericPacket();
2602 ASSERT_EQ(1u, transport_.sent_packets_.size());
2603 const uint16_t packet_seqence_number =
2604 transport_.sent_packets_.back().SequenceNumber();
2605
2606 // Advance time and make sure it can be retransmitted, even if we try to set
2607 // the ssrc the what it already is.
2608 rtp_sender_->SetSequenceNumber(rtp_sender_->SequenceNumber());
2609 fake_clock_.AdvanceTimeMilliseconds(kRtt);
2610 EXPECT_GT(rtp_sender_->ReSendPacket(packet_seqence_number), 0);
2611
2612 // Change the sequence number, then move the time and try to retransmit again.
2613 // The old packet should now be gone.
2614 rtp_sender_->SetSequenceNumber(rtp_sender_->SequenceNumber() - 1);
2615 fake_clock_.AdvanceTimeMilliseconds(kRtt);
2616 EXPECT_EQ(rtp_sender_->ReSendPacket(packet_seqence_number), 0);
2617}
2618
Erik Språng60ffc312019-07-30 22:03:49 +02002619TEST_P(RtpSenderTest, IgnoresNackAfterDisablingMedia) {
2620 const int64_t kRtt = 10;
2621
2622 rtp_sender_->SetSendingMediaStatus(true);
2623 rtp_sender_->SetRtxStatus(kRtxRetransmitted | kRtxRedundantPayloads);
2624 rtp_sender_->SetRtxPayloadType(kRtxPayload, kPayload);
2625 rtp_sender_->SetStorePacketsStatus(true, 10);
2626 rtp_sender_->SetRtt(kRtt);
2627
2628 // Send a packet so it is in the packet history.
Erik Språng60ffc312019-07-30 22:03:49 +02002629 std::unique_ptr<RtpPacketToSend> packet_to_pace;
Erik Språngea55b082019-10-02 14:57:46 +02002630 EXPECT_CALL(mock_paced_sender_, EnqueuePackets)
2631 .WillOnce([&](std::vector<std::unique_ptr<RtpPacketToSend>> packets) {
2632 packet_to_pace = std::move(packets[0]);
Erik Språng60ffc312019-07-30 22:03:49 +02002633 });
2634
2635 SendGenericPacket();
2636 rtp_sender_->TrySendPacket(packet_to_pace.get(), PacedPacketInfo());
2637
2638 ASSERT_EQ(1u, transport_.sent_packets_.size());
2639
2640 // Disable media sending and try to retransmit the packet, it should fail.
2641 rtp_sender_->SetSendingMediaStatus(false);
2642 fake_clock_.AdvanceTimeMilliseconds(kRtt);
2643 EXPECT_LT(rtp_sender_->ReSendPacket(kSeqNum), 0);
Erik Språng60ffc312019-07-30 22:03:49 +02002644}
2645
Mirko Bonadeic84f6612019-01-31 12:20:57 +01002646INSTANTIATE_TEST_SUITE_P(WithAndWithoutOverhead,
2647 RtpSenderTest,
Erik Språngf5815fa2019-08-21 14:27:31 +02002648 ::testing::Values(TestConfig{false},
2649 TestConfig{true}));
Erik Språngf6468d22019-07-05 16:53:43 +02002650
Mirko Bonadeic84f6612019-01-31 12:20:57 +01002651INSTANTIATE_TEST_SUITE_P(WithAndWithoutOverhead,
2652 RtpSenderTestWithoutPacer,
Erik Språngf5815fa2019-08-21 14:27:31 +02002653 ::testing::Values(TestConfig{false},
2654 TestConfig{true}));
Niels Möllera34d7762019-02-01 14:13:29 +01002655
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00002656} // namespace webrtc