asapersson@webrtc.org | 5249cc8 | 2011-12-16 14:31:37 +0000 | [diff] [blame] | 1 | /* |
phoglund@webrtc.org | 78088c2 | 2012-02-07 14:56:45 +0000 | [diff] [blame] | 2 | * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. |
asapersson@webrtc.org | 5249cc8 | 2011-12-16 14:31:37 +0000 | [diff] [blame] | 3 | * |
| 4 | * Use of this source code is governed by a BSD-style license |
| 5 | * that can be found in the LICENSE file in the root of the source |
| 6 | * tree. An additional intellectual property rights grant can be found |
| 7 | * in the file PATENTS. All contributing project authors may |
| 8 | * be found in the AUTHORS file in the root of the source tree. |
| 9 | */ |
| 10 | |
kwiberg | 84be511 | 2016-04-27 01:19:58 -0700 | [diff] [blame] | 11 | #include <memory> |
danilchap | b8b6fbb | 2015-12-10 05:05:27 -0800 | [diff] [blame] | 12 | #include <vector> |
| 13 | |
Karl Wiberg | 918f50c | 2018-07-05 11:40:33 +0200 | [diff] [blame] | 14 | #include "absl/memory/memory.h" |
Mirko Bonadei | 92ea95e | 2017-09-15 06:47:31 +0200 | [diff] [blame] | 15 | #include "api/video/video_timing.h" |
Elad Alon | 4a87e1c | 2017-10-03 16:11:34 +0200 | [diff] [blame] | 16 | #include "logging/rtc_event_log/events/rtc_event.h" |
Mirko Bonadei | 92ea95e | 2017-09-15 06:47:31 +0200 | [diff] [blame] | 17 | #include "logging/rtc_event_log/mock/mock_rtc_event_log.h" |
| 18 | #include "modules/rtp_rtcp/include/rtp_cvo.h" |
| 19 | #include "modules/rtp_rtcp/include/rtp_header_extension_map.h" |
| 20 | #include "modules/rtp_rtcp/include/rtp_header_parser.h" |
| 21 | #include "modules/rtp_rtcp/include/rtp_rtcp_defines.h" |
| 22 | #include "modules/rtp_rtcp/source/rtcp_packet/transport_feedback.h" |
| 23 | #include "modules/rtp_rtcp/source/rtp_format_video_generic.h" |
philipel | b3e42a4 | 2018-09-13 10:57:14 +0200 | [diff] [blame] | 24 | #include "modules/rtp_rtcp/source/rtp_generic_frame_descriptor.h" |
| 25 | #include "modules/rtp_rtcp/source/rtp_generic_frame_descriptor_extension.h" |
Mirko Bonadei | 92ea95e | 2017-09-15 06:47:31 +0200 | [diff] [blame] | 26 | #include "modules/rtp_rtcp/source/rtp_header_extensions.h" |
| 27 | #include "modules/rtp_rtcp/source/rtp_packet_received.h" |
| 28 | #include "modules/rtp_rtcp/source/rtp_packet_to_send.h" |
| 29 | #include "modules/rtp_rtcp/source/rtp_sender.h" |
| 30 | #include "modules/rtp_rtcp/source/rtp_sender_video.h" |
| 31 | #include "modules/rtp_rtcp/source/rtp_utility.h" |
| 32 | #include "rtc_base/arraysize.h" |
| 33 | #include "rtc_base/buffer.h" |
Mirko Bonadei | 92ea95e | 2017-09-15 06:47:31 +0200 | [diff] [blame] | 34 | #include "rtc_base/rate_limiter.h" |
| 35 | #include "test/field_trial.h" |
| 36 | #include "test/gmock.h" |
| 37 | #include "test/gtest.h" |
| 38 | #include "test/mock_transport.h" |
asapersson@webrtc.org | 5249cc8 | 2011-12-16 14:31:37 +0000 | [diff] [blame] | 39 | |
| 40 | namespace webrtc { |
| 41 | |
andrew@webrtc.org | 8a44259 | 2011-12-16 21:24:30 +0000 | [diff] [blame] | 42 | namespace { |
solenberg@webrtc.org | 7ebbea1 | 2013-05-16 11:10:31 +0000 | [diff] [blame] | 43 | const int kTransmissionTimeOffsetExtensionId = 1; |
| 44 | const int kAbsoluteSendTimeExtensionId = 14; |
sprang@webrtc.org | 3093390 | 2015-03-17 14:33:12 +0000 | [diff] [blame] | 45 | const int kTransportSequenceNumberExtensionId = 13; |
ilnik | 04f4d12 | 2017-06-19 07:18:55 -0700 | [diff] [blame] | 46 | const int kVideoTimingExtensionId = 12; |
Steve Anton | 296a0ce | 2018-03-22 15:17:27 -0700 | [diff] [blame] | 47 | const int kMidExtensionId = 11; |
andrew@webrtc.org | 8a44259 | 2011-12-16 21:24:30 +0000 | [diff] [blame] | 48 | const int kPayload = 100; |
Shao Changbin | e62202f | 2015-04-21 20:24:50 +0800 | [diff] [blame] | 49 | const int kRtxPayload = 98; |
andrew@webrtc.org | 8a44259 | 2011-12-16 21:24:30 +0000 | [diff] [blame] | 50 | const uint32_t kTimestamp = 10; |
| 51 | const uint16_t kSeqNum = 33; |
brandtr | 9dfff29 | 2016-11-14 05:14:50 -0800 | [diff] [blame] | 52 | const uint32_t kSsrc = 725242; |
andrew@webrtc.org | 8a44259 | 2011-12-16 21:24:30 +0000 | [diff] [blame] | 53 | const int kMaxPacketLength = 1500; |
solenberg@webrtc.org | c0352d5 | 2013-05-20 20:55:07 +0000 | [diff] [blame] | 54 | const uint8_t kAudioLevel = 0x5a; |
sprang@webrtc.org | 3093390 | 2015-03-17 14:33:12 +0000 | [diff] [blame] | 55 | const uint16_t kTransportSequenceNumber = 0xaabbu; |
solenberg@webrtc.org | c0352d5 | 2013-05-20 20:55:07 +0000 | [diff] [blame] | 56 | const uint8_t kAudioLevelExtensionId = 9; |
| 57 | const int kAudioPayload = 103; |
sprang@webrtc.org | 6811b6e | 2013-12-13 09:46:59 +0000 | [diff] [blame] | 58 | const uint64_t kStartTime = 123456789; |
pbos@webrtc.org | 2f4b14e | 2014-07-15 15:25:39 +0000 | [diff] [blame] | 59 | const size_t kMaxPaddingSize = 224u; |
guoweis@webrtc.org | 4536289 | 2015-03-04 22:55:15 +0000 | [diff] [blame] | 60 | const int kVideoRotationExtensionId = 5; |
Stefan Holmer | a246cfb | 2016-08-23 17:51:42 +0200 | [diff] [blame] | 61 | const size_t kGenericHeaderLength = 1; |
| 62 | const uint8_t kPayloadData[] = {47, 11, 32, 93, 89}; |
sprang | a8ae6f2 | 2017-09-04 07:23:56 -0700 | [diff] [blame] | 63 | const int64_t kDefaultExpectedRetransmissionTimeMs = 125; |
philipel | b3e42a4 | 2018-09-13 10:57:14 +0200 | [diff] [blame] | 64 | const int kGenericDescriptorId = 10; |
andrew@webrtc.org | 8a44259 | 2011-12-16 21:24:30 +0000 | [diff] [blame] | 65 | |
Danil Chapovalov | 5e57b17 | 2016-09-02 19:15:59 +0200 | [diff] [blame] | 66 | using ::testing::_; |
philipel | b3e42a4 | 2018-09-13 10:57:14 +0200 | [diff] [blame] | 67 | using ::testing::ElementsAre; |
Danil Chapovalov | 5e57b17 | 2016-09-02 19:15:59 +0200 | [diff] [blame] | 68 | using ::testing::ElementsAreArray; |
sprang | 168794c | 2017-07-06 04:38:06 -0700 | [diff] [blame] | 69 | using ::testing::Invoke; |
Danil Chapovalov | 84ffb35 | 2018-09-25 18:59:09 +0200 | [diff] [blame] | 70 | using ::testing::SizeIs; |
pwestin@webrtc.org | b0061f9 | 2013-04-27 00:41:08 +0000 | [diff] [blame] | 71 | |
henrik.lundin@webrtc.org | 6e95d7a | 2013-11-15 08:59:19 +0000 | [diff] [blame] | 72 | uint64_t ConvertMsToAbsSendTime(int64_t time_ms) { |
Stefan Holmer | 0a87ffc | 2015-10-21 13:41:48 +0200 | [diff] [blame] | 73 | return (((time_ms << 18) + 500) / 1000) & 0x00ffffff; |
henrik.lundin@webrtc.org | 6e95d7a | 2013-11-15 08:59:19 +0000 | [diff] [blame] | 74 | } |
| 75 | |
asapersson@webrtc.org | 0b3c35a | 2012-01-16 11:06:31 +0000 | [diff] [blame] | 76 | class LoopbackTransportTest : public webrtc::Transport { |
| 77 | public: |
Petter Strandmark | 26bc669 | 2018-05-29 08:43:35 +0200 | [diff] [blame] | 78 | LoopbackTransportTest() : total_bytes_sent_(0) { |
danilchap | 12ba186 | 2016-10-26 02:41:55 -0700 | [diff] [blame] | 79 | receivers_extensions_.Register(kRtpExtensionTransmissionTimeOffset, |
| 80 | kTransmissionTimeOffsetExtensionId); |
| 81 | receivers_extensions_.Register(kRtpExtensionAbsoluteSendTime, |
| 82 | kAbsoluteSendTimeExtensionId); |
| 83 | receivers_extensions_.Register(kRtpExtensionTransportSequenceNumber, |
| 84 | kTransportSequenceNumberExtensionId); |
| 85 | receivers_extensions_.Register(kRtpExtensionVideoRotation, |
| 86 | kVideoRotationExtensionId); |
| 87 | receivers_extensions_.Register(kRtpExtensionAudioLevel, |
| 88 | kAudioLevelExtensionId); |
ilnik | 04f4d12 | 2017-06-19 07:18:55 -0700 | [diff] [blame] | 89 | receivers_extensions_.Register(kRtpExtensionVideoTiming, |
| 90 | kVideoTimingExtensionId); |
Steve Anton | 296a0ce | 2018-03-22 15:17:27 -0700 | [diff] [blame] | 91 | receivers_extensions_.Register(kRtpExtensionMid, kMidExtensionId); |
philipel | b3e42a4 | 2018-09-13 10:57:14 +0200 | [diff] [blame] | 92 | receivers_extensions_.Register(kRtpExtensionGenericFrameDescriptor, |
| 93 | kGenericDescriptorId); |
guoweis@webrtc.org | 4536289 | 2015-03-04 22:55:15 +0000 | [diff] [blame] | 94 | } |
danilchap | 12ba186 | 2016-10-26 02:41:55 -0700 | [diff] [blame] | 95 | |
stefan | 1d8a506 | 2015-10-02 03:39:33 -0700 | [diff] [blame] | 96 | bool SendRtp(const uint8_t* data, |
| 97 | size_t len, |
| 98 | const PacketOptions& options) override { |
Petter Strandmark | 26bc669 | 2018-05-29 08:43:35 +0200 | [diff] [blame] | 99 | last_options_ = options; |
pkasting@chromium.org | 4591fbd | 2014-11-20 22:28:14 +0000 | [diff] [blame] | 100 | total_bytes_sent_ += len; |
danilchap | 12ba186 | 2016-10-26 02:41:55 -0700 | [diff] [blame] | 101 | sent_packets_.push_back(RtpPacketReceived(&receivers_extensions_)); |
| 102 | EXPECT_TRUE(sent_packets_.back().Parse(data, len)); |
pbos | 2d56668 | 2015-09-28 09:59:31 -0700 | [diff] [blame] | 103 | return true; |
asapersson@webrtc.org | 0b3c35a | 2012-01-16 11:06:31 +0000 | [diff] [blame] | 104 | } |
danilchap | 162abd3 | 2015-12-10 02:39:40 -0800 | [diff] [blame] | 105 | bool SendRtcp(const uint8_t* data, size_t len) override { return false; } |
danilchap | 12ba186 | 2016-10-26 02:41:55 -0700 | [diff] [blame] | 106 | const RtpPacketReceived& last_sent_packet() { return sent_packets_.back(); } |
| 107 | int packets_sent() { return sent_packets_.size(); } |
| 108 | |
pbos@webrtc.org | 72491b9 | 2014-07-10 16:24:54 +0000 | [diff] [blame] | 109 | size_t total_bytes_sent_; |
Petter Strandmark | 26bc669 | 2018-05-29 08:43:35 +0200 | [diff] [blame] | 110 | PacketOptions last_options_; |
danilchap | 12ba186 | 2016-10-26 02:41:55 -0700 | [diff] [blame] | 111 | std::vector<RtpPacketReceived> sent_packets_; |
| 112 | |
| 113 | private: |
| 114 | RtpHeaderExtensionMap receivers_extensions_; |
asapersson@webrtc.org | 0b3c35a | 2012-01-16 11:06:31 +0000 | [diff] [blame] | 115 | }; |
| 116 | |
Elad Alon | 4a87e1c | 2017-10-03 16:11:34 +0200 | [diff] [blame] | 117 | MATCHER_P(SameRtcEventTypeAs, value, "") { |
| 118 | return value == arg->GetType(); |
| 119 | } |
| 120 | |
guoweis@webrtc.org | 4536289 | 2015-03-04 22:55:15 +0000 | [diff] [blame] | 121 | } // namespace |
| 122 | |
sprang | ebbf8a8 | 2015-09-21 15:11:14 -0700 | [diff] [blame] | 123 | class MockRtpPacketSender : public RtpPacketSender { |
| 124 | public: |
| 125 | MockRtpPacketSender() {} |
| 126 | virtual ~MockRtpPacketSender() {} |
| 127 | |
Peter Boström | e23e737 | 2015-10-08 11:44:14 +0200 | [diff] [blame] | 128 | MOCK_METHOD6(InsertPacket, |
| 129 | void(Priority priority, |
sprang | ebbf8a8 | 2015-09-21 15:11:14 -0700 | [diff] [blame] | 130 | uint32_t ssrc, |
| 131 | uint16_t sequence_number, |
| 132 | int64_t capture_time_ms, |
| 133 | size_t bytes, |
| 134 | bool retransmission)); |
| 135 | }; |
| 136 | |
Stefan Holmer | f5dca48 | 2016-01-27 12:58:51 +0100 | [diff] [blame] | 137 | class MockTransportSequenceNumberAllocator |
| 138 | : public TransportSequenceNumberAllocator { |
| 139 | public: |
| 140 | MOCK_METHOD0(AllocateSequenceNumber, uint16_t()); |
| 141 | }; |
| 142 | |
Johannes Kron | 4a8a5e7 | 2018-09-26 09:57:48 +0200 | [diff] [blame] | 143 | class MockSendSideDelayObserver : public SendSideDelayObserver { |
| 144 | public: |
| 145 | MOCK_METHOD3(SendSideDelayUpdated, void(int, int, uint32_t)); |
| 146 | }; |
| 147 | |
asapersson | 35151f3 | 2016-05-02 23:44:01 -0700 | [diff] [blame] | 148 | class MockSendPacketObserver : public SendPacketObserver { |
| 149 | public: |
| 150 | MOCK_METHOD3(OnSendPacket, void(uint16_t, int64_t, uint32_t)); |
| 151 | }; |
| 152 | |
Stefan Holmer | a246cfb | 2016-08-23 17:51:42 +0200 | [diff] [blame] | 153 | class MockTransportFeedbackObserver : public TransportFeedbackObserver { |
| 154 | public: |
elad.alon | d12a8e1 | 2017-03-23 11:04:48 -0700 | [diff] [blame] | 155 | MOCK_METHOD4(AddPacket, |
| 156 | void(uint32_t, uint16_t, size_t, const PacedPacketInfo&)); |
Stefan Holmer | a246cfb | 2016-08-23 17:51:42 +0200 | [diff] [blame] | 157 | MOCK_METHOD1(OnTransportFeedback, void(const rtcp::TransportFeedback&)); |
elad.alon | f949000 | 2017-03-06 05:32:21 -0800 | [diff] [blame] | 158 | MOCK_CONST_METHOD0(GetTransportFeedbackVector, std::vector<PacketFeedback>()); |
Stefan Holmer | a246cfb | 2016-08-23 17:51:42 +0200 | [diff] [blame] | 159 | }; |
| 160 | |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 161 | class MockOverheadObserver : public OverheadObserver { |
| 162 | public: |
| 163 | MOCK_METHOD1(OnOverheadChanged, void(size_t overhead_bytes_per_packet)); |
| 164 | }; |
| 165 | |
| 166 | class RtpSenderTest : public ::testing::TestWithParam<bool> { |
asapersson@webrtc.org | 5249cc8 | 2011-12-16 14:31:37 +0000 | [diff] [blame] | 167 | protected: |
| 168 | RtpSenderTest() |
sprang@webrtc.org | 6811b6e | 2013-12-13 09:46:59 +0000 | [diff] [blame] | 169 | : fake_clock_(kStartTime), |
terelius | 429c345 | 2016-01-21 05:42:04 -0800 | [diff] [blame] | 170 | mock_rtc_event_log_(), |
sprang@webrtc.org | 6811b6e | 2013-12-13 09:46:59 +0000 | [diff] [blame] | 171 | mock_paced_sender_(), |
sprang | cd349d9 | 2016-07-13 09:11:28 -0700 | [diff] [blame] | 172 | retransmission_rate_limiter_(&fake_clock_, 1000), |
sprang@webrtc.org | 6811b6e | 2013-12-13 09:46:59 +0000 | [diff] [blame] | 173 | rtp_sender_(), |
| 174 | payload_(kPayload), |
| 175 | transport_(), |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 176 | kMarkerBit(true), |
| 177 | field_trials_(GetParam() ? "WebRTC-SendSideBwe-WithOverhead/Enabled/" |
| 178 | : "") {} |
solenberg@webrtc.org | c0352d5 | 2013-05-20 20:55:07 +0000 | [diff] [blame] | 179 | |
Erik Språng | 7b52f10 | 2018-02-07 14:37:37 +0100 | [diff] [blame] | 180 | void SetUp() override { SetUpRtpSender(true, false); } |
Peter Boström | e23e737 | 2015-10-08 11:44:14 +0200 | [diff] [blame] | 181 | |
Erik Språng | 7b52f10 | 2018-02-07 14:37:37 +0100 | [diff] [blame] | 182 | void SetUpRtpSender(bool pacer, bool populate_network2) { |
asapersson | 35151f3 | 2016-05-02 23:44:01 -0700 | [diff] [blame] | 183 | rtp_sender_.reset(new RTPSender( |
| 184 | false, &fake_clock_, &transport_, pacer ? &mock_paced_sender_ : nullptr, |
brandtr | dbdb3f1 | 2016-11-10 05:04:48 -0800 | [diff] [blame] | 185 | nullptr, &seq_num_allocator_, nullptr, nullptr, nullptr, nullptr, |
sprang | cd349d9 | 2016-07-13 09:11:28 -0700 | [diff] [blame] | 186 | &mock_rtc_event_log_, &send_packet_observer_, |
Benjamin Wright | 192eeec | 2018-10-17 17:27:25 -0700 | [diff] [blame] | 187 | &retransmission_rate_limiter_, nullptr, populate_network2, nullptr, |
Johannes Kron | 9190b82 | 2018-10-29 11:22:05 +0100 | [diff] [blame] | 188 | false, false)); |
brandtr | 9dfff29 | 2016-11-14 05:14:50 -0800 | [diff] [blame] | 189 | rtp_sender_->SetSequenceNumber(kSeqNum); |
danilchap | 71fead2 | 2016-08-18 02:01:49 -0700 | [diff] [blame] | 190 | rtp_sender_->SetTimestampOffset(0); |
brandtr | 9dfff29 | 2016-11-14 05:14:50 -0800 | [diff] [blame] | 191 | rtp_sender_->SetSSRC(kSsrc); |
solenberg@webrtc.org | c0352d5 | 2013-05-20 20:55:07 +0000 | [diff] [blame] | 192 | } |
| 193 | |
stefan@webrtc.org | a678a3b | 2013-01-21 07:42:11 +0000 | [diff] [blame] | 194 | SimulatedClock fake_clock_; |
stefan | a23fc62 | 2016-07-28 07:56:38 -0700 | [diff] [blame] | 195 | testing::NiceMock<MockRtcEventLog> mock_rtc_event_log_; |
sprang | ebbf8a8 | 2015-09-21 15:11:14 -0700 | [diff] [blame] | 196 | MockRtpPacketSender mock_paced_sender_; |
stefan | a23fc62 | 2016-07-28 07:56:38 -0700 | [diff] [blame] | 197 | testing::StrictMock<MockTransportSequenceNumberAllocator> seq_num_allocator_; |
| 198 | testing::StrictMock<MockSendPacketObserver> send_packet_observer_; |
Stefan Holmer | a246cfb | 2016-08-23 17:51:42 +0200 | [diff] [blame] | 199 | testing::StrictMock<MockTransportFeedbackObserver> feedback_observer_; |
sprang | cd349d9 | 2016-07-13 09:11:28 -0700 | [diff] [blame] | 200 | RateLimiter retransmission_rate_limiter_; |
kwiberg | 84be511 | 2016-04-27 01:19:58 -0700 | [diff] [blame] | 201 | std::unique_ptr<RTPSender> rtp_sender_; |
solenberg@webrtc.org | c0352d5 | 2013-05-20 20:55:07 +0000 | [diff] [blame] | 202 | int payload_; |
asapersson@webrtc.org | 0b3c35a | 2012-01-16 11:06:31 +0000 | [diff] [blame] | 203 | LoopbackTransportTest transport_; |
asapersson@webrtc.org | 5249cc8 | 2011-12-16 14:31:37 +0000 | [diff] [blame] | 204 | const bool kMarkerBit; |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 205 | test::ScopedFieldTrials field_trials_; |
asapersson@webrtc.org | 5249cc8 | 2011-12-16 14:31:37 +0000 | [diff] [blame] | 206 | |
stefan@webrtc.org | a5cb98c | 2013-05-29 12:12:51 +0000 | [diff] [blame] | 207 | void VerifyRTPHeaderCommon(const RTPHeader& rtp_header) { |
danilchap | d9e62f5 | 2016-01-14 14:55:19 -0800 | [diff] [blame] | 208 | VerifyRTPHeaderCommon(rtp_header, kMarkerBit, 0); |
guoweis@webrtc.org | 4536289 | 2015-03-04 22:55:15 +0000 | [diff] [blame] | 209 | } |
| 210 | |
| 211 | void VerifyRTPHeaderCommon(const RTPHeader& rtp_header, bool marker_bit) { |
danilchap | d9e62f5 | 2016-01-14 14:55:19 -0800 | [diff] [blame] | 212 | VerifyRTPHeaderCommon(rtp_header, marker_bit, 0); |
| 213 | } |
| 214 | |
| 215 | void VerifyRTPHeaderCommon(const RTPHeader& rtp_header, |
| 216 | bool marker_bit, |
| 217 | uint8_t number_of_csrcs) { |
guoweis@webrtc.org | 4536289 | 2015-03-04 22:55:15 +0000 | [diff] [blame] | 218 | EXPECT_EQ(marker_bit, rtp_header.markerBit); |
stefan@webrtc.org | a5cb98c | 2013-05-29 12:12:51 +0000 | [diff] [blame] | 219 | EXPECT_EQ(payload_, rtp_header.payloadType); |
| 220 | EXPECT_EQ(kSeqNum, rtp_header.sequenceNumber); |
| 221 | EXPECT_EQ(kTimestamp, rtp_header.timestamp); |
| 222 | EXPECT_EQ(rtp_sender_->SSRC(), rtp_header.ssrc); |
danilchap | d9e62f5 | 2016-01-14 14:55:19 -0800 | [diff] [blame] | 223 | EXPECT_EQ(number_of_csrcs, rtp_header.numCSRCs); |
pkasting@chromium.org | 4591fbd | 2014-11-20 22:28:14 +0000 | [diff] [blame] | 224 | EXPECT_EQ(0U, rtp_header.paddingLength); |
asapersson@webrtc.org | 5249cc8 | 2011-12-16 14:31:37 +0000 | [diff] [blame] | 225 | } |
stefan@webrtc.org | 7e9315b | 2013-12-04 10:24:26 +0000 | [diff] [blame] | 226 | |
danilchap | b6f1fb5 | 2016-10-19 06:11:39 -0700 | [diff] [blame] | 227 | std::unique_ptr<RtpPacketToSend> BuildRtpPacket(int payload_type, |
| 228 | bool marker_bit, |
| 229 | uint32_t timestamp, |
| 230 | int64_t capture_time_ms) { |
| 231 | auto packet = rtp_sender_->AllocatePacket(); |
| 232 | packet->SetPayloadType(payload_type); |
| 233 | packet->SetMarker(marker_bit); |
| 234 | packet->SetTimestamp(timestamp); |
| 235 | packet->set_capture_time_ms(capture_time_ms); |
| 236 | EXPECT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get())); |
| 237 | return packet; |
| 238 | } |
| 239 | |
stefan@webrtc.org | 7e9315b | 2013-12-04 10:24:26 +0000 | [diff] [blame] | 240 | void SendPacket(int64_t capture_time_ms, int payload_length) { |
| 241 | uint32_t timestamp = capture_time_ms * 90; |
danilchap | b6f1fb5 | 2016-10-19 06:11:39 -0700 | [diff] [blame] | 242 | auto packet = |
| 243 | BuildRtpPacket(kPayload, kMarkerBit, timestamp, capture_time_ms); |
| 244 | packet->AllocatePayload(payload_length); |
stefan@webrtc.org | 7e9315b | 2013-12-04 10:24:26 +0000 | [diff] [blame] | 245 | |
| 246 | // Packet should be stored in a send bucket. |
danilchap | b6f1fb5 | 2016-10-19 06:11:39 -0700 | [diff] [blame] | 247 | EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet), |
| 248 | kAllowRetransmission, |
| 249 | RtpPacketSender::kNormalPriority)); |
stefan@webrtc.org | 7e9315b | 2013-12-04 10:24:26 +0000 | [diff] [blame] | 250 | } |
asapersson | 35151f3 | 2016-05-02 23:44:01 -0700 | [diff] [blame] | 251 | |
| 252 | void SendGenericPayload() { |
asapersson | 35151f3 | 2016-05-02 23:44:01 -0700 | [diff] [blame] | 253 | const uint32_t kTimestamp = 1234; |
| 254 | const uint8_t kPayloadType = 127; |
| 255 | const int64_t kCaptureTimeMs = fake_clock_.TimeInMilliseconds(); |
| 256 | char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC"; |
| 257 | EXPECT_EQ(0, rtp_sender_->RegisterPayload(payload_name, kPayloadType, 90000, |
| 258 | 0, 1500)); |
| 259 | |
Sami Kalliomäki | 426a80c | 2018-08-08 11:37:59 +0200 | [diff] [blame] | 260 | RTPVideoHeader video_header; |
Sergey Ulanov | 525df3f | 2016-08-02 17:46:41 -0700 | [diff] [blame] | 261 | EXPECT_TRUE(rtp_sender_->SendOutgoingData( |
Stefan Holmer | a246cfb | 2016-08-23 17:51:42 +0200 | [diff] [blame] | 262 | kVideoFrameKey, kPayloadType, kTimestamp, kCaptureTimeMs, kPayloadData, |
Sami Kalliomäki | 426a80c | 2018-08-08 11:37:59 +0200 | [diff] [blame] | 263 | sizeof(kPayloadData), nullptr, &video_header, nullptr, |
sprang | a8ae6f2 | 2017-09-04 07:23:56 -0700 | [diff] [blame] | 264 | kDefaultExpectedRetransmissionTimeMs)); |
asapersson | 35151f3 | 2016-05-02 23:44:01 -0700 | [diff] [blame] | 265 | } |
asapersson@webrtc.org | 5249cc8 | 2011-12-16 14:31:37 +0000 | [diff] [blame] | 266 | }; |
| 267 | |
Peter Boström | e23e737 | 2015-10-08 11:44:14 +0200 | [diff] [blame] | 268 | // TODO(pbos): Move tests over from WithoutPacer to RtpSenderTest as this is our |
| 269 | // default code path. |
| 270 | class RtpSenderTestWithoutPacer : public RtpSenderTest { |
| 271 | public: |
Erik Språng | 7b52f10 | 2018-02-07 14:37:37 +0100 | [diff] [blame] | 272 | void SetUp() override { SetUpRtpSender(false, false); } |
Peter Boström | e23e737 | 2015-10-08 11:44:14 +0200 | [diff] [blame] | 273 | }; |
| 274 | |
sprang | a8ae6f2 | 2017-09-04 07:23:56 -0700 | [diff] [blame] | 275 | class TestRtpSenderVideo : public RTPSenderVideo { |
| 276 | public: |
| 277 | TestRtpSenderVideo(Clock* clock, |
| 278 | RTPSender* rtp_sender, |
| 279 | FlexfecSender* flexfec_sender) |
Benjamin Wright | 192eeec | 2018-10-17 17:27:25 -0700 | [diff] [blame] | 280 | : RTPSenderVideo(clock, rtp_sender, flexfec_sender, nullptr, false) {} |
sprang | a8ae6f2 | 2017-09-04 07:23:56 -0700 | [diff] [blame] | 281 | ~TestRtpSenderVideo() override {} |
| 282 | |
| 283 | StorageType GetStorageType(const RTPVideoHeader& header, |
| 284 | int32_t retransmission_settings, |
| 285 | int64_t expected_retransmission_time_ms) { |
| 286 | return RTPSenderVideo::GetStorageType(GetTemporalId(header), |
| 287 | retransmission_settings, |
| 288 | expected_retransmission_time_ms); |
| 289 | } |
| 290 | }; |
| 291 | |
guoweis@webrtc.org | 4536289 | 2015-03-04 22:55:15 +0000 | [diff] [blame] | 292 | class RtpSenderVideoTest : public RtpSenderTest { |
| 293 | protected: |
danilchap | 162abd3 | 2015-12-10 02:39:40 -0800 | [diff] [blame] | 294 | void SetUp() override { |
Peter Boström | e23e737 | 2015-10-08 11:44:14 +0200 | [diff] [blame] | 295 | // TODO(pbos): Set up to use pacer. |
Erik Språng | 7b52f10 | 2018-02-07 14:37:37 +0100 | [diff] [blame] | 296 | SetUpRtpSender(false, false); |
guoweis@webrtc.org | 4536289 | 2015-03-04 22:55:15 +0000 | [diff] [blame] | 297 | rtp_sender_video_.reset( |
sprang | a8ae6f2 | 2017-09-04 07:23:56 -0700 | [diff] [blame] | 298 | new TestRtpSenderVideo(&fake_clock_, rtp_sender_.get(), nullptr)); |
guoweis@webrtc.org | 4536289 | 2015-03-04 22:55:15 +0000 | [diff] [blame] | 299 | } |
sprang | a8ae6f2 | 2017-09-04 07:23:56 -0700 | [diff] [blame] | 300 | std::unique_ptr<TestRtpSenderVideo> rtp_sender_video_; |
guoweis@webrtc.org | 4536289 | 2015-03-04 22:55:15 +0000 | [diff] [blame] | 301 | }; |
| 302 | |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 303 | TEST_P(RtpSenderTestWithoutPacer, AllocatePacketSetCsrc) { |
Danil Chapovalov | 5e57b17 | 2016-09-02 19:15:59 +0200 | [diff] [blame] | 304 | // Configure rtp_sender with csrc. |
| 305 | std::vector<uint32_t> csrcs; |
| 306 | csrcs.push_back(0x23456789); |
| 307 | rtp_sender_->SetCsrcs(csrcs); |
| 308 | |
| 309 | auto packet = rtp_sender_->AllocatePacket(); |
| 310 | |
| 311 | ASSERT_TRUE(packet); |
| 312 | EXPECT_EQ(rtp_sender_->SSRC(), packet->Ssrc()); |
| 313 | EXPECT_EQ(csrcs, packet->Csrcs()); |
| 314 | } |
| 315 | |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 316 | TEST_P(RtpSenderTestWithoutPacer, AllocatePacketReserveExtensions) { |
Danil Chapovalov | 5e57b17 | 2016-09-02 19:15:59 +0200 | [diff] [blame] | 317 | // Configure rtp_sender with extensions. |
| 318 | ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension( |
| 319 | kRtpExtensionTransmissionTimeOffset, |
| 320 | kTransmissionTimeOffsetExtensionId)); |
| 321 | ASSERT_EQ( |
| 322 | 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime, |
| 323 | kAbsoluteSendTimeExtensionId)); |
| 324 | ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAudioLevel, |
| 325 | kAudioLevelExtensionId)); |
| 326 | ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension( |
| 327 | kRtpExtensionTransportSequenceNumber, |
| 328 | kTransportSequenceNumberExtensionId)); |
| 329 | ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension( |
| 330 | kRtpExtensionVideoRotation, kVideoRotationExtensionId)); |
| 331 | |
| 332 | auto packet = rtp_sender_->AllocatePacket(); |
| 333 | |
| 334 | ASSERT_TRUE(packet); |
| 335 | // Preallocate BWE extensions RtpSender set itself. |
| 336 | EXPECT_TRUE(packet->HasExtension<TransmissionOffset>()); |
| 337 | EXPECT_TRUE(packet->HasExtension<AbsoluteSendTime>()); |
| 338 | EXPECT_TRUE(packet->HasExtension<TransportSequenceNumber>()); |
| 339 | // Do not allocate media specific extensions. |
| 340 | EXPECT_FALSE(packet->HasExtension<AudioLevel>()); |
| 341 | EXPECT_FALSE(packet->HasExtension<VideoOrientation>()); |
| 342 | } |
| 343 | |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 344 | TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberAdvanceSequenceNumber) { |
Danil Chapovalov | 5e57b17 | 2016-09-02 19:15:59 +0200 | [diff] [blame] | 345 | auto packet = rtp_sender_->AllocatePacket(); |
| 346 | ASSERT_TRUE(packet); |
| 347 | const uint16_t sequence_number = rtp_sender_->SequenceNumber(); |
| 348 | |
| 349 | EXPECT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get())); |
| 350 | |
| 351 | EXPECT_EQ(sequence_number, packet->SequenceNumber()); |
| 352 | EXPECT_EQ(sequence_number + 1, rtp_sender_->SequenceNumber()); |
| 353 | } |
| 354 | |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 355 | TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberFailsOnNotSending) { |
Danil Chapovalov | 5e57b17 | 2016-09-02 19:15:59 +0200 | [diff] [blame] | 356 | auto packet = rtp_sender_->AllocatePacket(); |
| 357 | ASSERT_TRUE(packet); |
| 358 | |
| 359 | rtp_sender_->SetSendingMediaStatus(false); |
| 360 | EXPECT_FALSE(rtp_sender_->AssignSequenceNumber(packet.get())); |
| 361 | } |
| 362 | |
Danil Chapovalov | b3179c7 | 2018-03-22 10:13:07 +0100 | [diff] [blame] | 363 | TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberMayAllowPaddingOnVideo) { |
Danil Chapovalov | 5e57b17 | 2016-09-02 19:15:59 +0200 | [diff] [blame] | 364 | constexpr size_t kPaddingSize = 100; |
| 365 | auto packet = rtp_sender_->AllocatePacket(); |
| 366 | ASSERT_TRUE(packet); |
| 367 | |
philipel | 8aadd50 | 2017-02-23 02:56:13 -0800 | [diff] [blame] | 368 | ASSERT_FALSE(rtp_sender_->TimeToSendPadding(kPaddingSize, PacedPacketInfo())); |
Danil Chapovalov | 5e57b17 | 2016-09-02 19:15:59 +0200 | [diff] [blame] | 369 | packet->SetMarker(false); |
| 370 | ASSERT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get())); |
Danil Chapovalov | b3179c7 | 2018-03-22 10:13:07 +0100 | [diff] [blame] | 371 | // Packet without marker bit doesn't allow padding on video stream. |
philipel | 8aadd50 | 2017-02-23 02:56:13 -0800 | [diff] [blame] | 372 | EXPECT_FALSE(rtp_sender_->TimeToSendPadding(kPaddingSize, PacedPacketInfo())); |
Danil Chapovalov | 5e57b17 | 2016-09-02 19:15:59 +0200 | [diff] [blame] | 373 | |
| 374 | packet->SetMarker(true); |
| 375 | ASSERT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get())); |
| 376 | // Packet with marker bit allows send padding. |
philipel | 8aadd50 | 2017-02-23 02:56:13 -0800 | [diff] [blame] | 377 | EXPECT_TRUE(rtp_sender_->TimeToSendPadding(kPaddingSize, PacedPacketInfo())); |
Danil Chapovalov | 5e57b17 | 2016-09-02 19:15:59 +0200 | [diff] [blame] | 378 | } |
| 379 | |
Danil Chapovalov | b3179c7 | 2018-03-22 10:13:07 +0100 | [diff] [blame] | 380 | TEST_P(RtpSenderTest, AssignSequenceNumberAllowsPaddingOnAudio) { |
| 381 | MockTransport transport; |
| 382 | const bool kEnableAudio = true; |
| 383 | rtp_sender_.reset(new RTPSender( |
| 384 | kEnableAudio, &fake_clock_, &transport, &mock_paced_sender_, nullptr, |
| 385 | nullptr, nullptr, nullptr, nullptr, nullptr, &mock_rtc_event_log_, |
Johannes Kron | 9190b82 | 2018-10-29 11:22:05 +0100 | [diff] [blame] | 386 | nullptr, &retransmission_rate_limiter_, nullptr, false, nullptr, false, |
| 387 | false)); |
Danil Chapovalov | b3179c7 | 2018-03-22 10:13:07 +0100 | [diff] [blame] | 388 | rtp_sender_->SetTimestampOffset(0); |
| 389 | rtp_sender_->SetSSRC(kSsrc); |
| 390 | |
| 391 | std::unique_ptr<RtpPacketToSend> audio_packet = rtp_sender_->AllocatePacket(); |
| 392 | // Padding on audio stream allowed regardless of marker in the last packet. |
| 393 | audio_packet->SetMarker(false); |
| 394 | audio_packet->SetPayloadType(kPayload); |
| 395 | rtp_sender_->AssignSequenceNumber(audio_packet.get()); |
| 396 | |
| 397 | const size_t kPaddingSize = 59; |
| 398 | EXPECT_CALL(transport, SendRtp(_, kPaddingSize + kRtpHeaderSize, _)) |
| 399 | .WillOnce(testing::Return(true)); |
| 400 | EXPECT_EQ(kPaddingSize, |
| 401 | rtp_sender_->TimeToSendPadding(kPaddingSize, PacedPacketInfo())); |
| 402 | |
| 403 | // Requested padding size is too small, will send a larger one. |
| 404 | const size_t kMinPaddingSize = 50; |
| 405 | EXPECT_CALL(transport, SendRtp(_, kMinPaddingSize + kRtpHeaderSize, _)) |
| 406 | .WillOnce(testing::Return(true)); |
Yves Gerey | 665174f | 2018-06-19 15:03:05 +0200 | [diff] [blame] | 407 | EXPECT_EQ(kMinPaddingSize, rtp_sender_->TimeToSendPadding(kMinPaddingSize - 5, |
| 408 | PacedPacketInfo())); |
Danil Chapovalov | b3179c7 | 2018-03-22 10:13:07 +0100 | [diff] [blame] | 409 | } |
| 410 | |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 411 | TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberSetPaddingTimestamps) { |
Danil Chapovalov | 5e57b17 | 2016-09-02 19:15:59 +0200 | [diff] [blame] | 412 | constexpr size_t kPaddingSize = 100; |
| 413 | auto packet = rtp_sender_->AllocatePacket(); |
| 414 | ASSERT_TRUE(packet); |
| 415 | packet->SetMarker(true); |
| 416 | packet->SetTimestamp(kTimestamp); |
| 417 | |
| 418 | ASSERT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get())); |
philipel | 8aadd50 | 2017-02-23 02:56:13 -0800 | [diff] [blame] | 419 | ASSERT_TRUE(rtp_sender_->TimeToSendPadding(kPaddingSize, PacedPacketInfo())); |
Danil Chapovalov | 5e57b17 | 2016-09-02 19:15:59 +0200 | [diff] [blame] | 420 | |
| 421 | ASSERT_EQ(1u, transport_.sent_packets_.size()); |
danilchap | 12ba186 | 2016-10-26 02:41:55 -0700 | [diff] [blame] | 422 | // Verify padding packet timestamp. |
| 423 | EXPECT_EQ(kTimestamp, transport_.last_sent_packet().Timestamp()); |
Danil Chapovalov | 5e57b17 | 2016-09-02 19:15:59 +0200 | [diff] [blame] | 424 | } |
| 425 | |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 426 | TEST_P(RtpSenderTestWithoutPacer, |
| 427 | TransportFeedbackObserverGetsCorrectByteCount) { |
| 428 | constexpr int kRtpOverheadBytesPerPacket = 12 + 8; |
| 429 | testing::NiceMock<MockOverheadObserver> mock_overhead_observer; |
| 430 | rtp_sender_.reset(new RTPSender( |
| 431 | false, &fake_clock_, &transport_, nullptr, nullptr, &seq_num_allocator_, |
| 432 | &feedback_observer_, nullptr, nullptr, nullptr, &mock_rtc_event_log_, |
Benjamin Wright | 192eeec | 2018-10-17 17:27:25 -0700 | [diff] [blame] | 433 | nullptr, &retransmission_rate_limiter_, &mock_overhead_observer, false, |
Johannes Kron | 9190b82 | 2018-10-29 11:22:05 +0100 | [diff] [blame] | 434 | nullptr, false, false)); |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 435 | rtp_sender_->SetSSRC(kSsrc); |
| 436 | EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension( |
| 437 | kRtpExtensionTransportSequenceNumber, |
| 438 | kTransportSequenceNumberExtensionId)); |
| 439 | EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber()) |
| 440 | .WillOnce(testing::Return(kTransportSequenceNumber)); |
| 441 | |
| 442 | const size_t expected_bytes = |
| 443 | GetParam() ? sizeof(kPayloadData) + kGenericHeaderLength + |
| 444 | kRtpOverheadBytesPerPacket |
| 445 | : sizeof(kPayloadData) + kGenericHeaderLength; |
| 446 | |
| 447 | EXPECT_CALL(feedback_observer_, |
| 448 | AddPacket(rtp_sender_->SSRC(), kTransportSequenceNumber, |
| 449 | expected_bytes, PacedPacketInfo())) |
| 450 | .Times(1); |
| 451 | EXPECT_CALL(mock_overhead_observer, |
| 452 | OnOverheadChanged(kRtpOverheadBytesPerPacket)) |
| 453 | .Times(1); |
| 454 | SendGenericPayload(); |
| 455 | } |
| 456 | |
| 457 | TEST_P(RtpSenderTestWithoutPacer, SendsPacketsWithTransportSequenceNumber) { |
Stefan Holmer | a246cfb | 2016-08-23 17:51:42 +0200 | [diff] [blame] | 458 | rtp_sender_.reset(new RTPSender( |
brandtr | dbdb3f1 | 2016-11-10 05:04:48 -0800 | [diff] [blame] | 459 | false, &fake_clock_, &transport_, nullptr, nullptr, &seq_num_allocator_, |
| 460 | &feedback_observer_, nullptr, nullptr, nullptr, &mock_rtc_event_log_, |
Benjamin Wright | 192eeec | 2018-10-17 17:27:25 -0700 | [diff] [blame] | 461 | &send_packet_observer_, &retransmission_rate_limiter_, nullptr, false, |
Johannes Kron | 9190b82 | 2018-10-29 11:22:05 +0100 | [diff] [blame] | 462 | nullptr, false, false)); |
nisse | 7d59f6b | 2017-02-21 03:40:24 -0800 | [diff] [blame] | 463 | rtp_sender_->SetSSRC(kSsrc); |
Stefan Holmer | f5dca48 | 2016-01-27 12:58:51 +0100 | [diff] [blame] | 464 | EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension( |
| 465 | kRtpExtensionTransportSequenceNumber, |
| 466 | kTransportSequenceNumberExtensionId)); |
| 467 | |
Stefan Holmer | f5dca48 | 2016-01-27 12:58:51 +0100 | [diff] [blame] | 468 | EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber()) |
| 469 | .WillOnce(testing::Return(kTransportSequenceNumber)); |
asapersson | 35151f3 | 2016-05-02 23:44:01 -0700 | [diff] [blame] | 470 | EXPECT_CALL(send_packet_observer_, |
| 471 | OnSendPacket(kTransportSequenceNumber, _, _)) |
| 472 | .Times(1); |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 473 | |
| 474 | EXPECT_CALL(feedback_observer_, |
| 475 | AddPacket(rtp_sender_->SSRC(), kTransportSequenceNumber, _, |
| 476 | PacedPacketInfo())) |
Stefan Holmer | a246cfb | 2016-08-23 17:51:42 +0200 | [diff] [blame] | 477 | .Times(1); |
asapersson | 35151f3 | 2016-05-02 23:44:01 -0700 | [diff] [blame] | 478 | |
| 479 | SendGenericPayload(); |
Stefan Holmer | f5dca48 | 2016-01-27 12:58:51 +0100 | [diff] [blame] | 480 | |
danilchap | 12ba186 | 2016-10-26 02:41:55 -0700 | [diff] [blame] | 481 | const auto& packet = transport_.last_sent_packet(); |
| 482 | uint16_t transport_seq_no; |
| 483 | ASSERT_TRUE(packet.GetExtension<TransportSequenceNumber>(&transport_seq_no)); |
| 484 | EXPECT_EQ(kTransportSequenceNumber, transport_seq_no); |
Petter Strandmark | 26bc669 | 2018-05-29 08:43:35 +0200 | [diff] [blame] | 485 | EXPECT_EQ(transport_.last_options_.packet_id, transport_seq_no); |
Sebastian Jansson | 1bca65b | 2018-10-10 09:58:08 +0200 | [diff] [blame] | 486 | EXPECT_TRUE(transport_.last_options_.included_in_allocation); |
Petter Strandmark | 26bc669 | 2018-05-29 08:43:35 +0200 | [diff] [blame] | 487 | } |
| 488 | |
| 489 | TEST_P(RtpSenderTestWithoutPacer, PacketOptionsNoRetransmission) { |
| 490 | rtp_sender_.reset(new RTPSender( |
| 491 | false, &fake_clock_, &transport_, nullptr, nullptr, &seq_num_allocator_, |
| 492 | &feedback_observer_, nullptr, nullptr, nullptr, &mock_rtc_event_log_, |
Benjamin Wright | 192eeec | 2018-10-17 17:27:25 -0700 | [diff] [blame] | 493 | &send_packet_observer_, &retransmission_rate_limiter_, nullptr, false, |
Johannes Kron | 9190b82 | 2018-10-29 11:22:05 +0100 | [diff] [blame] | 494 | nullptr, false, false)); |
Petter Strandmark | 26bc669 | 2018-05-29 08:43:35 +0200 | [diff] [blame] | 495 | rtp_sender_->SetSSRC(kSsrc); |
| 496 | |
| 497 | SendGenericPayload(); |
| 498 | |
| 499 | EXPECT_FALSE(transport_.last_options_.is_retransmit); |
Stefan Holmer | f5dca48 | 2016-01-27 12:58:51 +0100 | [diff] [blame] | 500 | } |
| 501 | |
Sebastian Jansson | 1bca65b | 2018-10-10 09:58:08 +0200 | [diff] [blame] | 502 | TEST_P(RtpSenderTestWithoutPacer, |
| 503 | SetsIncludedInFeedbackWhenTransportSequenceNumberExtensionIsRegistered) { |
| 504 | SetUpRtpSender(false, false); |
| 505 | rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionTransportSequenceNumber, |
| 506 | kTransportSequenceNumberExtensionId); |
| 507 | EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber()) |
| 508 | .WillOnce(testing::Return(kTransportSequenceNumber)); |
| 509 | EXPECT_CALL(send_packet_observer_, OnSendPacket).Times(1); |
stefan | a23fc62 | 2016-07-28 07:56:38 -0700 | [diff] [blame] | 510 | SendGenericPayload(); |
Sebastian Jansson | 1bca65b | 2018-10-10 09:58:08 +0200 | [diff] [blame] | 511 | EXPECT_TRUE(transport_.last_options_.included_in_feedback); |
| 512 | } |
| 513 | |
| 514 | TEST_P( |
| 515 | RtpSenderTestWithoutPacer, |
| 516 | SetsIncludedInAllocationWhenTransportSequenceNumberExtensionIsRegistered) { |
| 517 | SetUpRtpSender(false, false); |
| 518 | rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionTransportSequenceNumber, |
| 519 | kTransportSequenceNumberExtensionId); |
| 520 | EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber()) |
| 521 | .WillOnce(testing::Return(kTransportSequenceNumber)); |
| 522 | EXPECT_CALL(send_packet_observer_, OnSendPacket).Times(1); |
| 523 | SendGenericPayload(); |
| 524 | EXPECT_TRUE(transport_.last_options_.included_in_allocation); |
| 525 | } |
| 526 | |
| 527 | TEST_P(RtpSenderTestWithoutPacer, |
| 528 | SetsIncludedInAllocationWhenForcedAsPartOfAllocation) { |
| 529 | SetUpRtpSender(false, false); |
| 530 | rtp_sender_->SetAsPartOfAllocation(true); |
| 531 | SendGenericPayload(); |
| 532 | EXPECT_FALSE(transport_.last_options_.included_in_feedback); |
| 533 | EXPECT_TRUE(transport_.last_options_.included_in_allocation); |
| 534 | } |
| 535 | |
| 536 | TEST_P(RtpSenderTestWithoutPacer, DoesnSetIncludedInAllocationByDefault) { |
| 537 | SetUpRtpSender(false, false); |
| 538 | SendGenericPayload(); |
| 539 | EXPECT_FALSE(transport_.last_options_.included_in_feedback); |
| 540 | EXPECT_FALSE(transport_.last_options_.included_in_allocation); |
stefan | a23fc62 | 2016-07-28 07:56:38 -0700 | [diff] [blame] | 541 | } |
asapersson | 35151f3 | 2016-05-02 23:44:01 -0700 | [diff] [blame] | 542 | |
Johannes Kron | 4a8a5e7 | 2018-09-26 09:57:48 +0200 | [diff] [blame] | 543 | TEST_P(RtpSenderTestWithoutPacer, OnSendSideDelayUpdated) { |
| 544 | testing::StrictMock<MockSendSideDelayObserver> send_side_delay_observer_; |
Benjamin Wright | 192eeec | 2018-10-17 17:27:25 -0700 | [diff] [blame] | 545 | rtp_sender_.reset(new RTPSender( |
| 546 | false, &fake_clock_, &transport_, nullptr, nullptr, nullptr, nullptr, |
| 547 | nullptr, nullptr, &send_side_delay_observer_, &mock_rtc_event_log_, |
Johannes Kron | 9190b82 | 2018-10-29 11:22:05 +0100 | [diff] [blame] | 548 | nullptr, nullptr, nullptr, false, nullptr, false, false)); |
Johannes Kron | 4a8a5e7 | 2018-09-26 09:57:48 +0200 | [diff] [blame] | 549 | rtp_sender_->SetSSRC(kSsrc); |
| 550 | |
| 551 | const uint8_t kPayloadType = 127; |
| 552 | const uint32_t kCaptureTimeMsToRtpTimestamp = 90; // 90 kHz clock |
| 553 | char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC"; |
| 554 | RTPVideoHeader video_header; |
| 555 | EXPECT_EQ(0, rtp_sender_->RegisterPayload(payload_name, kPayloadType, |
| 556 | 1000 * kCaptureTimeMsToRtpTimestamp, |
| 557 | 0, 1500)); |
| 558 | |
| 559 | // Send packet with 10 ms send-side delay. The average and max should be 10 |
| 560 | // ms. |
| 561 | EXPECT_CALL(send_side_delay_observer_, SendSideDelayUpdated(10, 10, kSsrc)) |
| 562 | .Times(1); |
| 563 | int64_t capture_time_ms = fake_clock_.TimeInMilliseconds(); |
| 564 | fake_clock_.AdvanceTimeMilliseconds(10); |
| 565 | EXPECT_TRUE(rtp_sender_->SendOutgoingData( |
| 566 | kVideoFrameKey, kPayloadType, |
| 567 | capture_time_ms * kCaptureTimeMsToRtpTimestamp, capture_time_ms, |
| 568 | kPayloadData, sizeof(kPayloadData), nullptr, &video_header, nullptr, |
| 569 | kDefaultExpectedRetransmissionTimeMs)); |
| 570 | |
| 571 | // Send another packet with 20 ms delay. The average |
| 572 | // and max should be 15 and 20 ms respectively. |
| 573 | EXPECT_CALL(send_side_delay_observer_, SendSideDelayUpdated(15, 20, kSsrc)) |
| 574 | .Times(1); |
| 575 | fake_clock_.AdvanceTimeMilliseconds(10); |
| 576 | EXPECT_TRUE(rtp_sender_->SendOutgoingData( |
| 577 | kVideoFrameKey, kPayloadType, |
| 578 | capture_time_ms * kCaptureTimeMsToRtpTimestamp, capture_time_ms, |
| 579 | kPayloadData, sizeof(kPayloadData), nullptr, &video_header, nullptr, |
| 580 | kDefaultExpectedRetransmissionTimeMs)); |
| 581 | |
| 582 | // Send another packet at the same time, which replaces the last packet. |
| 583 | // Since this packet has 0 ms delay, the average is now 5 ms and max is 10 ms. |
| 584 | // TODO(terelius): Is is not clear that this is the right behavior. |
| 585 | EXPECT_CALL(send_side_delay_observer_, SendSideDelayUpdated(5, 10, kSsrc)) |
| 586 | .Times(1); |
| 587 | capture_time_ms = fake_clock_.TimeInMilliseconds(); |
| 588 | EXPECT_TRUE(rtp_sender_->SendOutgoingData( |
| 589 | kVideoFrameKey, kPayloadType, |
| 590 | capture_time_ms * kCaptureTimeMsToRtpTimestamp, capture_time_ms, |
| 591 | kPayloadData, sizeof(kPayloadData), nullptr, &video_header, nullptr, |
| 592 | kDefaultExpectedRetransmissionTimeMs)); |
| 593 | |
| 594 | // Send a packet 1 second later. The earlier packets should have timed |
| 595 | // out, so both max and average should be the delay of this packet. |
| 596 | fake_clock_.AdvanceTimeMilliseconds(1000); |
| 597 | capture_time_ms = fake_clock_.TimeInMilliseconds(); |
| 598 | fake_clock_.AdvanceTimeMilliseconds(1); |
| 599 | EXPECT_CALL(send_side_delay_observer_, SendSideDelayUpdated(1, 1, kSsrc)) |
| 600 | .Times(1); |
| 601 | EXPECT_TRUE(rtp_sender_->SendOutgoingData( |
| 602 | kVideoFrameKey, kPayloadType, |
| 603 | capture_time_ms * kCaptureTimeMsToRtpTimestamp, capture_time_ms, |
| 604 | kPayloadData, sizeof(kPayloadData), nullptr, &video_header, nullptr, |
| 605 | kDefaultExpectedRetransmissionTimeMs)); |
| 606 | } |
| 607 | |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 608 | TEST_P(RtpSenderTestWithoutPacer, OnSendPacketUpdated) { |
stefan | a23fc62 | 2016-07-28 07:56:38 -0700 | [diff] [blame] | 609 | EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension( |
| 610 | kRtpExtensionTransportSequenceNumber, |
| 611 | kTransportSequenceNumberExtensionId)); |
asapersson | 35151f3 | 2016-05-02 23:44:01 -0700 | [diff] [blame] | 612 | EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber()) |
| 613 | .WillOnce(testing::Return(kTransportSequenceNumber)); |
| 614 | EXPECT_CALL(send_packet_observer_, |
| 615 | OnSendPacket(kTransportSequenceNumber, _, _)) |
| 616 | .Times(1); |
| 617 | |
| 618 | SendGenericPayload(); |
| 619 | } |
| 620 | |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 621 | TEST_P(RtpSenderTest, SendsPacketsWithTransportSequenceNumber) { |
michaelt | 4da3044 | 2016-11-17 01:38:43 -0800 | [diff] [blame] | 622 | rtp_sender_.reset(new RTPSender( |
| 623 | false, &fake_clock_, &transport_, &mock_paced_sender_, nullptr, |
| 624 | &seq_num_allocator_, &feedback_observer_, nullptr, nullptr, nullptr, |
| 625 | &mock_rtc_event_log_, &send_packet_observer_, |
Johannes Kron | 9190b82 | 2018-10-29 11:22:05 +0100 | [diff] [blame] | 626 | &retransmission_rate_limiter_, nullptr, false, nullptr, false, false)); |
brandtr | 9dfff29 | 2016-11-14 05:14:50 -0800 | [diff] [blame] | 627 | rtp_sender_->SetSequenceNumber(kSeqNum); |
| 628 | rtp_sender_->SetSSRC(kSsrc); |
Stefan Holmer | a246cfb | 2016-08-23 17:51:42 +0200 | [diff] [blame] | 629 | rtp_sender_->SetStorePacketsStatus(true, 10); |
| 630 | EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension( |
| 631 | kRtpExtensionTransportSequenceNumber, |
| 632 | kTransportSequenceNumberExtensionId)); |
| 633 | |
brandtr | 9dfff29 | 2016-11-14 05:14:50 -0800 | [diff] [blame] | 634 | EXPECT_CALL(mock_paced_sender_, InsertPacket(_, kSsrc, kSeqNum, _, _, _)); |
Stefan Holmer | a246cfb | 2016-08-23 17:51:42 +0200 | [diff] [blame] | 635 | EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber()) |
| 636 | .WillOnce(testing::Return(kTransportSequenceNumber)); |
| 637 | EXPECT_CALL(send_packet_observer_, |
| 638 | OnSendPacket(kTransportSequenceNumber, _, _)) |
| 639 | .Times(1); |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 640 | EXPECT_CALL(feedback_observer_, |
| 641 | AddPacket(rtp_sender_->SSRC(), kTransportSequenceNumber, _, |
| 642 | PacedPacketInfo())) |
Stefan Holmer | a246cfb | 2016-08-23 17:51:42 +0200 | [diff] [blame] | 643 | .Times(1); |
| 644 | |
| 645 | SendGenericPayload(); |
philipel | 8aadd50 | 2017-02-23 02:56:13 -0800 | [diff] [blame] | 646 | rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum, |
| 647 | fake_clock_.TimeInMilliseconds(), false, |
| 648 | PacedPacketInfo()); |
Stefan Holmer | a246cfb | 2016-08-23 17:51:42 +0200 | [diff] [blame] | 649 | |
danilchap | 12ba186 | 2016-10-26 02:41:55 -0700 | [diff] [blame] | 650 | const auto& packet = transport_.last_sent_packet(); |
| 651 | uint16_t transport_seq_no; |
| 652 | EXPECT_TRUE(packet.GetExtension<TransportSequenceNumber>(&transport_seq_no)); |
| 653 | EXPECT_EQ(kTransportSequenceNumber, transport_seq_no); |
Petter Strandmark | 26bc669 | 2018-05-29 08:43:35 +0200 | [diff] [blame] | 654 | EXPECT_EQ(transport_.last_options_.packet_id, transport_seq_no); |
Stefan Holmer | a246cfb | 2016-08-23 17:51:42 +0200 | [diff] [blame] | 655 | } |
| 656 | |
Erik Språng | 7b52f10 | 2018-02-07 14:37:37 +0100 | [diff] [blame] | 657 | TEST_P(RtpSenderTest, WritesPacerExitToTimingExtension) { |
ilnik | 04f4d12 | 2017-06-19 07:18:55 -0700 | [diff] [blame] | 658 | rtp_sender_->SetStorePacketsStatus(true, 10); |
| 659 | EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension( |
| 660 | kRtpExtensionVideoTiming, kVideoTimingExtensionId)); |
| 661 | int64_t capture_time_ms = fake_clock_.TimeInMilliseconds(); |
| 662 | auto packet = rtp_sender_->AllocatePacket(); |
| 663 | packet->SetPayloadType(kPayload); |
| 664 | packet->SetMarker(true); |
| 665 | packet->SetTimestamp(kTimestamp); |
| 666 | packet->set_capture_time_ms(capture_time_ms); |
ilnik | 2edc684 | 2017-07-06 03:06:50 -0700 | [diff] [blame] | 667 | const VideoSendTiming kVideoTiming = {0u, 0u, 0u, 0u, 0u, 0u, true}; |
ilnik | 04f4d12 | 2017-06-19 07:18:55 -0700 | [diff] [blame] | 668 | packet->SetExtension<VideoTimingExtension>(kVideoTiming); |
| 669 | EXPECT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get())); |
| 670 | size_t packet_size = packet->size(); |
ilnik | 04f4d12 | 2017-06-19 07:18:55 -0700 | [diff] [blame] | 671 | |
| 672 | const int kStoredTimeInMs = 100; |
Erik Språng | 7b52f10 | 2018-02-07 14:37:37 +0100 | [diff] [blame] | 673 | { |
| 674 | EXPECT_CALL( |
| 675 | mock_paced_sender_, |
| 676 | InsertPacket(RtpPacketSender::kNormalPriority, kSsrc, _, _, _, _)); |
| 677 | EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet), |
| 678 | kAllowRetransmission, |
| 679 | RtpPacketSender::kNormalPriority)); |
| 680 | } |
ilnik | 04f4d12 | 2017-06-19 07:18:55 -0700 | [diff] [blame] | 681 | fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs); |
Erik Språng | 7b52f10 | 2018-02-07 14:37:37 +0100 | [diff] [blame] | 682 | rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum, capture_time_ms, false, |
| 683 | PacedPacketInfo()); |
ilnik | 04f4d12 | 2017-06-19 07:18:55 -0700 | [diff] [blame] | 684 | EXPECT_EQ(1, transport_.packets_sent()); |
| 685 | EXPECT_EQ(packet_size, transport_.last_sent_packet().size()); |
| 686 | |
danilchap | ce25181 | 2017-09-11 12:24:41 -0700 | [diff] [blame] | 687 | VideoSendTiming video_timing; |
| 688 | EXPECT_TRUE(transport_.last_sent_packet().GetExtension<VideoTimingExtension>( |
| 689 | &video_timing)); |
| 690 | EXPECT_EQ(kStoredTimeInMs, video_timing.pacer_exit_delta_ms); |
Erik Språng | 7b52f10 | 2018-02-07 14:37:37 +0100 | [diff] [blame] | 691 | } |
ilnik | 04f4d12 | 2017-06-19 07:18:55 -0700 | [diff] [blame] | 692 | |
Danil Chapovalov | af52b68 | 2018-11-27 10:48:27 +0100 | [diff] [blame^] | 693 | TEST_P(RtpSenderTest, WritesNetwork2ToTimingExtensionWithPacer) { |
| 694 | SetUpRtpSender(/*pacer=*/true, /*populate_network2=*/true); |
Erik Språng | 7b52f10 | 2018-02-07 14:37:37 +0100 | [diff] [blame] | 695 | rtp_sender_->SetStorePacketsStatus(true, 10); |
| 696 | EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension( |
| 697 | kRtpExtensionVideoTiming, kVideoTimingExtensionId)); |
| 698 | int64_t capture_time_ms = fake_clock_.TimeInMilliseconds(); |
| 699 | auto packet = rtp_sender_->AllocatePacket(); |
| 700 | packet->SetPayloadType(kPayload); |
| 701 | packet->SetMarker(true); |
| 702 | packet->SetTimestamp(kTimestamp); |
| 703 | packet->set_capture_time_ms(capture_time_ms); |
| 704 | const uint16_t kPacerExitMs = 1234u; |
| 705 | const VideoSendTiming kVideoTiming = {0u, 0u, 0u, kPacerExitMs, 0u, 0u, true}; |
| 706 | packet->SetExtension<VideoTimingExtension>(kVideoTiming); |
| 707 | EXPECT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get())); |
| 708 | size_t packet_size = packet->size(); |
| 709 | |
| 710 | const int kStoredTimeInMs = 100; |
| 711 | { |
| 712 | EXPECT_CALL( |
| 713 | mock_paced_sender_, |
| 714 | InsertPacket(RtpPacketSender::kNormalPriority, kSsrc, _, _, _, _)); |
| 715 | EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet), |
| 716 | kAllowRetransmission, |
| 717 | RtpPacketSender::kNormalPriority)); |
| 718 | } |
ilnik | 04f4d12 | 2017-06-19 07:18:55 -0700 | [diff] [blame] | 719 | fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs); |
| 720 | rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum, capture_time_ms, false, |
| 721 | PacedPacketInfo()); |
Erik Språng | 7b52f10 | 2018-02-07 14:37:37 +0100 | [diff] [blame] | 722 | EXPECT_EQ(1, transport_.packets_sent()); |
ilnik | 04f4d12 | 2017-06-19 07:18:55 -0700 | [diff] [blame] | 723 | EXPECT_EQ(packet_size, transport_.last_sent_packet().size()); |
| 724 | |
Erik Språng | 7b52f10 | 2018-02-07 14:37:37 +0100 | [diff] [blame] | 725 | VideoSendTiming video_timing; |
danilchap | ce25181 | 2017-09-11 12:24:41 -0700 | [diff] [blame] | 726 | EXPECT_TRUE(transport_.last_sent_packet().GetExtension<VideoTimingExtension>( |
| 727 | &video_timing)); |
Erik Språng | 7b52f10 | 2018-02-07 14:37:37 +0100 | [diff] [blame] | 728 | EXPECT_EQ(kStoredTimeInMs, video_timing.network2_timestamp_delta_ms); |
| 729 | EXPECT_EQ(kPacerExitMs, video_timing.pacer_exit_delta_ms); |
ilnik | 04f4d12 | 2017-06-19 07:18:55 -0700 | [diff] [blame] | 730 | } |
| 731 | |
Danil Chapovalov | af52b68 | 2018-11-27 10:48:27 +0100 | [diff] [blame^] | 732 | TEST_P(RtpSenderTest, WritesNetwork2ToTimingExtensionWithoutPacer) { |
| 733 | SetUpRtpSender(/*pacer=*/false, /*populate_network2=*/true); |
| 734 | EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension( |
| 735 | kRtpExtensionVideoTiming, kVideoTimingExtensionId)); |
| 736 | auto packet = rtp_sender_->AllocatePacket(); |
| 737 | packet->SetMarker(true); |
| 738 | packet->set_capture_time_ms(fake_clock_.TimeInMilliseconds()); |
| 739 | const VideoSendTiming kVideoTiming = {0u, 0u, 0u, 0u, 0u, 0u, true}; |
| 740 | packet->SetExtension<VideoTimingExtension>(kVideoTiming); |
| 741 | EXPECT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get())); |
| 742 | |
| 743 | const int kPropagateTimeMs = 10; |
| 744 | fake_clock_.AdvanceTimeMilliseconds(kPropagateTimeMs); |
| 745 | |
| 746 | EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet), |
| 747 | kAllowRetransmission, |
| 748 | RtpPacketSender::kNormalPriority)); |
| 749 | |
| 750 | EXPECT_EQ(1, transport_.packets_sent()); |
| 751 | absl::optional<VideoSendTiming> video_timing = |
| 752 | transport_.last_sent_packet().GetExtension<VideoTimingExtension>(); |
| 753 | ASSERT_TRUE(video_timing); |
| 754 | EXPECT_EQ(kPropagateTimeMs, video_timing->network2_timestamp_delta_ms); |
| 755 | } |
| 756 | |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 757 | TEST_P(RtpSenderTest, TrafficSmoothingWithExtensions) { |
Peter Boström | e23e737 | 2015-10-08 11:44:14 +0200 | [diff] [blame] | 758 | EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kNormalPriority, |
brandtr | 9dfff29 | 2016-11-14 05:14:50 -0800 | [diff] [blame] | 759 | kSsrc, kSeqNum, _, _, _)); |
Elad Alon | 4a87e1c | 2017-10-03 16:11:34 +0200 | [diff] [blame] | 760 | EXPECT_CALL(mock_rtc_event_log_, |
| 761 | LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing))); |
asapersson@webrtc.org | 0b3c35a | 2012-01-16 11:06:31 +0000 | [diff] [blame] | 762 | |
pwestin@webrtc.org | c66e8b3 | 2012-11-07 17:01:04 +0000 | [diff] [blame] | 763 | rtp_sender_->SetStorePacketsStatus(true, 10); |
solenberg@webrtc.org | 7ebbea1 | 2013-05-16 11:10:31 +0000 | [diff] [blame] | 764 | EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension( |
danilchap | 162abd3 | 2015-12-10 02:39:40 -0800 | [diff] [blame] | 765 | kRtpExtensionTransmissionTimeOffset, |
| 766 | kTransmissionTimeOffsetExtensionId)); |
| 767 | EXPECT_EQ( |
| 768 | 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime, |
| 769 | kAbsoluteSendTimeExtensionId)); |
stefan@webrtc.org | 8ccb9f9 | 2013-06-19 14:13:42 +0000 | [diff] [blame] | 770 | int64_t capture_time_ms = fake_clock_.TimeInMilliseconds(); |
danilchap | b6f1fb5 | 2016-10-19 06:11:39 -0700 | [diff] [blame] | 771 | auto packet = |
| 772 | BuildRtpPacket(kPayload, kMarkerBit, kTimestamp, capture_time_ms); |
| 773 | size_t packet_size = packet->size(); |
pwestin@webrtc.org | b0061f9 | 2013-04-27 00:41:08 +0000 | [diff] [blame] | 774 | |
asapersson@webrtc.org | 0b3c35a | 2012-01-16 11:06:31 +0000 | [diff] [blame] | 775 | // Packet should be stored in a send bucket. |
danilchap | b6f1fb5 | 2016-10-19 06:11:39 -0700 | [diff] [blame] | 776 | EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet), |
| 777 | kAllowRetransmission, |
Sergey Ulanov | 525df3f | 2016-08-02 17:46:41 -0700 | [diff] [blame] | 778 | RtpPacketSender::kNormalPriority)); |
pwestin@webrtc.org | b0061f9 | 2013-04-27 00:41:08 +0000 | [diff] [blame] | 779 | |
danilchap | 12ba186 | 2016-10-26 02:41:55 -0700 | [diff] [blame] | 780 | EXPECT_EQ(0, transport_.packets_sent()); |
pwestin@webrtc.org | b0061f9 | 2013-04-27 00:41:08 +0000 | [diff] [blame] | 781 | |
asapersson@webrtc.org | 0b3c35a | 2012-01-16 11:06:31 +0000 | [diff] [blame] | 782 | const int kStoredTimeInMs = 100; |
stefan@webrtc.org | a678a3b | 2013-01-21 07:42:11 +0000 | [diff] [blame] | 783 | fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs); |
pwestin@webrtc.org | b0061f9 | 2013-04-27 00:41:08 +0000 | [diff] [blame] | 784 | |
brandtr | 9dfff29 | 2016-11-14 05:14:50 -0800 | [diff] [blame] | 785 | rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum, capture_time_ms, false, |
philipel | 8aadd50 | 2017-02-23 02:56:13 -0800 | [diff] [blame] | 786 | PacedPacketInfo()); |
pwestin@webrtc.org | b0061f9 | 2013-04-27 00:41:08 +0000 | [diff] [blame] | 787 | |
asapersson@webrtc.org | 0b3c35a | 2012-01-16 11:06:31 +0000 | [diff] [blame] | 788 | // Process send bucket. Packet should now be sent. |
danilchap | 12ba186 | 2016-10-26 02:41:55 -0700 | [diff] [blame] | 789 | EXPECT_EQ(1, transport_.packets_sent()); |
| 790 | EXPECT_EQ(packet_size, transport_.last_sent_packet().size()); |
| 791 | |
stefan@webrtc.org | a5cb98c | 2013-05-29 12:12:51 +0000 | [diff] [blame] | 792 | webrtc::RTPHeader rtp_header; |
danilchap | 12ba186 | 2016-10-26 02:41:55 -0700 | [diff] [blame] | 793 | transport_.last_sent_packet().GetHeader(&rtp_header); |
pwestin@webrtc.org | b0061f9 | 2013-04-27 00:41:08 +0000 | [diff] [blame] | 794 | |
| 795 | // Verify transmission time offset. |
| 796 | EXPECT_EQ(kStoredTimeInMs * 90, rtp_header.extension.transmissionTimeOffset); |
solenberg@webrtc.org | 7ebbea1 | 2013-05-16 11:10:31 +0000 | [diff] [blame] | 797 | uint64_t expected_send_time = |
henrik.lundin@webrtc.org | 6e95d7a | 2013-11-15 08:59:19 +0000 | [diff] [blame] | 798 | ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds()); |
solenberg@webrtc.org | 7ebbea1 | 2013-05-16 11:10:31 +0000 | [diff] [blame] | 799 | EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime); |
pwestin@webrtc.org | b0061f9 | 2013-04-27 00:41:08 +0000 | [diff] [blame] | 800 | } |
| 801 | |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 802 | TEST_P(RtpSenderTest, TrafficSmoothingRetransmits) { |
Peter Boström | e23e737 | 2015-10-08 11:44:14 +0200 | [diff] [blame] | 803 | EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kNormalPriority, |
brandtr | 9dfff29 | 2016-11-14 05:14:50 -0800 | [diff] [blame] | 804 | kSsrc, kSeqNum, _, _, _)); |
Elad Alon | 4a87e1c | 2017-10-03 16:11:34 +0200 | [diff] [blame] | 805 | EXPECT_CALL(mock_rtc_event_log_, |
| 806 | LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing))); |
pwestin@webrtc.org | b0061f9 | 2013-04-27 00:41:08 +0000 | [diff] [blame] | 807 | |
| 808 | rtp_sender_->SetStorePacketsStatus(true, 10); |
solenberg@webrtc.org | 7ebbea1 | 2013-05-16 11:10:31 +0000 | [diff] [blame] | 809 | EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension( |
danilchap | 162abd3 | 2015-12-10 02:39:40 -0800 | [diff] [blame] | 810 | kRtpExtensionTransmissionTimeOffset, |
| 811 | kTransmissionTimeOffsetExtensionId)); |
| 812 | EXPECT_EQ( |
| 813 | 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime, |
| 814 | kAbsoluteSendTimeExtensionId)); |
stefan@webrtc.org | 8ccb9f9 | 2013-06-19 14:13:42 +0000 | [diff] [blame] | 815 | int64_t capture_time_ms = fake_clock_.TimeInMilliseconds(); |
danilchap | b6f1fb5 | 2016-10-19 06:11:39 -0700 | [diff] [blame] | 816 | auto packet = |
| 817 | BuildRtpPacket(kPayload, kMarkerBit, kTimestamp, capture_time_ms); |
| 818 | size_t packet_size = packet->size(); |
pwestin@webrtc.org | b0061f9 | 2013-04-27 00:41:08 +0000 | [diff] [blame] | 819 | |
| 820 | // Packet should be stored in a send bucket. |
danilchap | b6f1fb5 | 2016-10-19 06:11:39 -0700 | [diff] [blame] | 821 | EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet), |
| 822 | kAllowRetransmission, |
Sergey Ulanov | 525df3f | 2016-08-02 17:46:41 -0700 | [diff] [blame] | 823 | RtpPacketSender::kNormalPriority)); |
pwestin@webrtc.org | b0061f9 | 2013-04-27 00:41:08 +0000 | [diff] [blame] | 824 | |
danilchap | 12ba186 | 2016-10-26 02:41:55 -0700 | [diff] [blame] | 825 | EXPECT_EQ(0, transport_.packets_sent()); |
pwestin@webrtc.org | b0061f9 | 2013-04-27 00:41:08 +0000 | [diff] [blame] | 826 | |
terelius | 5d332ac | 2016-01-14 14:37:39 -0800 | [diff] [blame] | 827 | EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kNormalPriority, |
brandtr | 9dfff29 | 2016-11-14 05:14:50 -0800 | [diff] [blame] | 828 | kSsrc, kSeqNum, _, _, _)); |
pwestin@webrtc.org | b0061f9 | 2013-04-27 00:41:08 +0000 | [diff] [blame] | 829 | |
| 830 | const int kStoredTimeInMs = 100; |
| 831 | fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs); |
| 832 | |
danilchap | b6f1fb5 | 2016-10-19 06:11:39 -0700 | [diff] [blame] | 833 | EXPECT_EQ(static_cast<int>(packet_size), rtp_sender_->ReSendPacket(kSeqNum)); |
danilchap | 12ba186 | 2016-10-26 02:41:55 -0700 | [diff] [blame] | 834 | EXPECT_EQ(0, transport_.packets_sent()); |
pwestin@webrtc.org | b0061f9 | 2013-04-27 00:41:08 +0000 | [diff] [blame] | 835 | |
brandtr | 9dfff29 | 2016-11-14 05:14:50 -0800 | [diff] [blame] | 836 | rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum, capture_time_ms, false, |
philipel | 8aadd50 | 2017-02-23 02:56:13 -0800 | [diff] [blame] | 837 | PacedPacketInfo()); |
pwestin@webrtc.org | b0061f9 | 2013-04-27 00:41:08 +0000 | [diff] [blame] | 838 | |
| 839 | // Process send bucket. Packet should now be sent. |
danilchap | 12ba186 | 2016-10-26 02:41:55 -0700 | [diff] [blame] | 840 | EXPECT_EQ(1, transport_.packets_sent()); |
| 841 | EXPECT_EQ(packet_size, transport_.last_sent_packet().size()); |
pwestin@webrtc.org | b0061f9 | 2013-04-27 00:41:08 +0000 | [diff] [blame] | 842 | |
stefan@webrtc.org | a5cb98c | 2013-05-29 12:12:51 +0000 | [diff] [blame] | 843 | webrtc::RTPHeader rtp_header; |
danilchap | 12ba186 | 2016-10-26 02:41:55 -0700 | [diff] [blame] | 844 | transport_.last_sent_packet().GetHeader(&rtp_header); |
pwestin@webrtc.org | b0061f9 | 2013-04-27 00:41:08 +0000 | [diff] [blame] | 845 | |
asapersson@webrtc.org | 0b3c35a | 2012-01-16 11:06:31 +0000 | [diff] [blame] | 846 | // Verify transmission time offset. |
| 847 | EXPECT_EQ(kStoredTimeInMs * 90, rtp_header.extension.transmissionTimeOffset); |
solenberg@webrtc.org | 7ebbea1 | 2013-05-16 11:10:31 +0000 | [diff] [blame] | 848 | uint64_t expected_send_time = |
henrik.lundin@webrtc.org | 6e95d7a | 2013-11-15 08:59:19 +0000 | [diff] [blame] | 849 | ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds()); |
| 850 | EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime); |
| 851 | } |
| 852 | |
| 853 | // This test sends 1 regular video packet, then 4 padding packets, and then |
| 854 | // 1 more regular packet. |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 855 | TEST_P(RtpSenderTest, SendPadding) { |
henrik.lundin@webrtc.org | 6e95d7a | 2013-11-15 08:59:19 +0000 | [diff] [blame] | 856 | // Make all (non-padding) packets go to send queue. |
terelius | 5d332ac | 2016-01-14 14:37:39 -0800 | [diff] [blame] | 857 | EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kNormalPriority, |
brandtr | 9dfff29 | 2016-11-14 05:14:50 -0800 | [diff] [blame] | 858 | kSsrc, kSeqNum, _, _, _)); |
Elad Alon | 4a87e1c | 2017-10-03 16:11:34 +0200 | [diff] [blame] | 859 | EXPECT_CALL(mock_rtc_event_log_, |
| 860 | LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing))) |
| 861 | .Times(1 + 4 + 1); |
henrik.lundin@webrtc.org | 6e95d7a | 2013-11-15 08:59:19 +0000 | [diff] [blame] | 862 | |
| 863 | uint16_t seq_num = kSeqNum; |
| 864 | uint32_t timestamp = kTimestamp; |
| 865 | rtp_sender_->SetStorePacketsStatus(true, 10); |
pkasting@chromium.org | 4591fbd | 2014-11-20 22:28:14 +0000 | [diff] [blame] | 866 | size_t rtp_header_len = kRtpHeaderSize; |
henrik.lundin@webrtc.org | 6e95d7a | 2013-11-15 08:59:19 +0000 | [diff] [blame] | 867 | EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension( |
danilchap | 162abd3 | 2015-12-10 02:39:40 -0800 | [diff] [blame] | 868 | kRtpExtensionTransmissionTimeOffset, |
| 869 | kTransmissionTimeOffsetExtensionId)); |
henrik.lundin@webrtc.org | 6e95d7a | 2013-11-15 08:59:19 +0000 | [diff] [blame] | 870 | rtp_header_len += 4; // 4 bytes extension. |
danilchap | 162abd3 | 2015-12-10 02:39:40 -0800 | [diff] [blame] | 871 | EXPECT_EQ( |
| 872 | 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime, |
| 873 | kAbsoluteSendTimeExtensionId)); |
henrik.lundin@webrtc.org | 6e95d7a | 2013-11-15 08:59:19 +0000 | [diff] [blame] | 874 | rtp_header_len += 4; // 4 bytes extension. |
| 875 | rtp_header_len += 4; // 4 extra bytes common to all extension headers. |
| 876 | |
henrik.lundin@webrtc.org | 6e95d7a | 2013-11-15 08:59:19 +0000 | [diff] [blame] | 877 | webrtc::RTPHeader rtp_header; |
| 878 | |
henrik.lundin@webrtc.org | 6e95d7a | 2013-11-15 08:59:19 +0000 | [diff] [blame] | 879 | int64_t capture_time_ms = fake_clock_.TimeInMilliseconds(); |
danilchap | b6f1fb5 | 2016-10-19 06:11:39 -0700 | [diff] [blame] | 880 | auto packet = |
| 881 | BuildRtpPacket(kPayload, kMarkerBit, timestamp, capture_time_ms); |
Stefan Holmer | 586b19b | 2015-09-18 11:14:31 +0200 | [diff] [blame] | 882 | const uint32_t media_packet_timestamp = timestamp; |
danilchap | b6f1fb5 | 2016-10-19 06:11:39 -0700 | [diff] [blame] | 883 | size_t packet_size = packet->size(); |
henrik.lundin@webrtc.org | 6e95d7a | 2013-11-15 08:59:19 +0000 | [diff] [blame] | 884 | |
| 885 | // Packet should be stored in a send bucket. |
danilchap | b6f1fb5 | 2016-10-19 06:11:39 -0700 | [diff] [blame] | 886 | EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet), |
| 887 | kAllowRetransmission, |
Sergey Ulanov | 525df3f | 2016-08-02 17:46:41 -0700 | [diff] [blame] | 888 | RtpPacketSender::kNormalPriority)); |
henrik.lundin@webrtc.org | 6e95d7a | 2013-11-15 08:59:19 +0000 | [diff] [blame] | 889 | |
| 890 | int total_packets_sent = 0; |
danilchap | 12ba186 | 2016-10-26 02:41:55 -0700 | [diff] [blame] | 891 | EXPECT_EQ(total_packets_sent, transport_.packets_sent()); |
henrik.lundin@webrtc.org | 6e95d7a | 2013-11-15 08:59:19 +0000 | [diff] [blame] | 892 | |
| 893 | const int kStoredTimeInMs = 100; |
| 894 | fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs); |
brandtr | 9dfff29 | 2016-11-14 05:14:50 -0800 | [diff] [blame] | 895 | rtp_sender_->TimeToSendPacket(kSsrc, seq_num++, capture_time_ms, false, |
philipel | 8aadd50 | 2017-02-23 02:56:13 -0800 | [diff] [blame] | 896 | PacedPacketInfo()); |
henrik.lundin@webrtc.org | 6e95d7a | 2013-11-15 08:59:19 +0000 | [diff] [blame] | 897 | // Packet should now be sent. This test doesn't verify the regular video |
| 898 | // packet, since it is tested in another test. |
danilchap | 12ba186 | 2016-10-26 02:41:55 -0700 | [diff] [blame] | 899 | EXPECT_EQ(++total_packets_sent, transport_.packets_sent()); |
henrik.lundin@webrtc.org | 6e95d7a | 2013-11-15 08:59:19 +0000 | [diff] [blame] | 900 | timestamp += 90 * kStoredTimeInMs; |
| 901 | |
| 902 | // Send padding 4 times, waiting 50 ms between each. |
| 903 | for (int i = 0; i < 4; ++i) { |
| 904 | const int kPaddingPeriodMs = 50; |
pkasting@chromium.org | 4591fbd | 2014-11-20 22:28:14 +0000 | [diff] [blame] | 905 | const size_t kPaddingBytes = 100; |
| 906 | const size_t kMaxPaddingLength = 224; // Value taken from rtp_sender.cc. |
henrik.lundin@webrtc.org | 6e95d7a | 2013-11-15 08:59:19 +0000 | [diff] [blame] | 907 | // Padding will be forced to full packets. |
philipel | c7bf32a | 2017-02-17 03:59:43 -0800 | [diff] [blame] | 908 | EXPECT_EQ(kMaxPaddingLength, |
philipel | 8aadd50 | 2017-02-23 02:56:13 -0800 | [diff] [blame] | 909 | rtp_sender_->TimeToSendPadding(kPaddingBytes, PacedPacketInfo())); |
henrik.lundin@webrtc.org | 6e95d7a | 2013-11-15 08:59:19 +0000 | [diff] [blame] | 910 | |
| 911 | // Process send bucket. Padding should now be sent. |
danilchap | 12ba186 | 2016-10-26 02:41:55 -0700 | [diff] [blame] | 912 | EXPECT_EQ(++total_packets_sent, transport_.packets_sent()); |
henrik.lundin@webrtc.org | 6e95d7a | 2013-11-15 08:59:19 +0000 | [diff] [blame] | 913 | EXPECT_EQ(kMaxPaddingLength + rtp_header_len, |
danilchap | 12ba186 | 2016-10-26 02:41:55 -0700 | [diff] [blame] | 914 | transport_.last_sent_packet().size()); |
| 915 | |
| 916 | transport_.last_sent_packet().GetHeader(&rtp_header); |
pbos | bd2522a | 2015-07-01 05:35:53 -0700 | [diff] [blame] | 917 | EXPECT_EQ(kMaxPaddingLength, rtp_header.paddingLength); |
henrik.lundin@webrtc.org | 6e95d7a | 2013-11-15 08:59:19 +0000 | [diff] [blame] | 918 | |
Stefan Holmer | 586b19b | 2015-09-18 11:14:31 +0200 | [diff] [blame] | 919 | // Verify sequence number and timestamp. The timestamp should be the same |
| 920 | // as the last media packet. |
henrik.lundin@webrtc.org | 6e95d7a | 2013-11-15 08:59:19 +0000 | [diff] [blame] | 921 | EXPECT_EQ(seq_num++, rtp_header.sequenceNumber); |
Stefan Holmer | 586b19b | 2015-09-18 11:14:31 +0200 | [diff] [blame] | 922 | EXPECT_EQ(media_packet_timestamp, rtp_header.timestamp); |
henrik.lundin@webrtc.org | 6e95d7a | 2013-11-15 08:59:19 +0000 | [diff] [blame] | 923 | // Verify transmission time offset. |
Stefan Holmer | 586b19b | 2015-09-18 11:14:31 +0200 | [diff] [blame] | 924 | int offset = timestamp - media_packet_timestamp; |
| 925 | EXPECT_EQ(offset, rtp_header.extension.transmissionTimeOffset); |
henrik.lundin@webrtc.org | 6e95d7a | 2013-11-15 08:59:19 +0000 | [diff] [blame] | 926 | uint64_t expected_send_time = |
| 927 | ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds()); |
| 928 | EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime); |
| 929 | fake_clock_.AdvanceTimeMilliseconds(kPaddingPeriodMs); |
| 930 | timestamp += 90 * kPaddingPeriodMs; |
| 931 | } |
| 932 | |
| 933 | // Send a regular video packet again. |
| 934 | capture_time_ms = fake_clock_.TimeInMilliseconds(); |
danilchap | b6f1fb5 | 2016-10-19 06:11:39 -0700 | [diff] [blame] | 935 | packet = BuildRtpPacket(kPayload, kMarkerBit, timestamp, capture_time_ms); |
| 936 | packet_size = packet->size(); |
henrik.lundin@webrtc.org | 6e95d7a | 2013-11-15 08:59:19 +0000 | [diff] [blame] | 937 | |
brandtr | 9dfff29 | 2016-11-14 05:14:50 -0800 | [diff] [blame] | 938 | EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kNormalPriority, |
| 939 | kSsrc, seq_num, _, _, _)); |
terelius | 5d332ac | 2016-01-14 14:37:39 -0800 | [diff] [blame] | 940 | |
henrik.lundin@webrtc.org | 6e95d7a | 2013-11-15 08:59:19 +0000 | [diff] [blame] | 941 | // Packet should be stored in a send bucket. |
danilchap | b6f1fb5 | 2016-10-19 06:11:39 -0700 | [diff] [blame] | 942 | EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet), |
| 943 | kAllowRetransmission, |
Sergey Ulanov | 525df3f | 2016-08-02 17:46:41 -0700 | [diff] [blame] | 944 | RtpPacketSender::kNormalPriority)); |
henrik.lundin@webrtc.org | 6e95d7a | 2013-11-15 08:59:19 +0000 | [diff] [blame] | 945 | |
brandtr | 9dfff29 | 2016-11-14 05:14:50 -0800 | [diff] [blame] | 946 | rtp_sender_->TimeToSendPacket(kSsrc, seq_num, capture_time_ms, false, |
philipel | 8aadd50 | 2017-02-23 02:56:13 -0800 | [diff] [blame] | 947 | PacedPacketInfo()); |
henrik.lundin@webrtc.org | 6e95d7a | 2013-11-15 08:59:19 +0000 | [diff] [blame] | 948 | // Process send bucket. |
danilchap | 12ba186 | 2016-10-26 02:41:55 -0700 | [diff] [blame] | 949 | EXPECT_EQ(++total_packets_sent, transport_.packets_sent()); |
| 950 | EXPECT_EQ(packet_size, transport_.last_sent_packet().size()); |
| 951 | transport_.last_sent_packet().GetHeader(&rtp_header); |
henrik.lundin@webrtc.org | 6e95d7a | 2013-11-15 08:59:19 +0000 | [diff] [blame] | 952 | |
| 953 | // Verify sequence number and timestamp. |
| 954 | EXPECT_EQ(seq_num, rtp_header.sequenceNumber); |
| 955 | EXPECT_EQ(timestamp, rtp_header.timestamp); |
| 956 | // Verify transmission time offset. This packet is sent without delay. |
| 957 | EXPECT_EQ(0, rtp_header.extension.transmissionTimeOffset); |
| 958 | uint64_t expected_send_time = |
| 959 | ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds()); |
solenberg@webrtc.org | 7ebbea1 | 2013-05-16 11:10:31 +0000 | [diff] [blame] | 960 | EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime); |
asapersson@webrtc.org | 0b3c35a | 2012-01-16 11:06:31 +0000 | [diff] [blame] | 961 | } |
pbos@webrtc.org | 8911ce4 | 2013-03-18 16:39:03 +0000 | [diff] [blame] | 962 | |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 963 | TEST_P(RtpSenderTest, OnSendPacketUpdated) { |
stefan | a23fc62 | 2016-07-28 07:56:38 -0700 | [diff] [blame] | 964 | EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension( |
| 965 | kRtpExtensionTransportSequenceNumber, |
| 966 | kTransportSequenceNumberExtensionId)); |
asapersson | 35151f3 | 2016-05-02 23:44:01 -0700 | [diff] [blame] | 967 | rtp_sender_->SetStorePacketsStatus(true, 10); |
| 968 | |
| 969 | EXPECT_CALL(send_packet_observer_, |
| 970 | OnSendPacket(kTransportSequenceNumber, _, _)) |
| 971 | .Times(1); |
| 972 | EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber()) |
| 973 | .WillOnce(testing::Return(kTransportSequenceNumber)); |
brandtr | 9dfff29 | 2016-11-14 05:14:50 -0800 | [diff] [blame] | 974 | EXPECT_CALL(mock_paced_sender_, InsertPacket(_, kSsrc, kSeqNum, _, _, _)) |
| 975 | .Times(1); |
asapersson | 35151f3 | 2016-05-02 23:44:01 -0700 | [diff] [blame] | 976 | |
| 977 | SendGenericPayload(); // Packet passed to pacer. |
| 978 | const bool kIsRetransmit = false; |
brandtr | 9dfff29 | 2016-11-14 05:14:50 -0800 | [diff] [blame] | 979 | rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum, |
| 980 | fake_clock_.TimeInMilliseconds(), kIsRetransmit, |
philipel | 8aadd50 | 2017-02-23 02:56:13 -0800 | [diff] [blame] | 981 | PacedPacketInfo()); |
danilchap | 12ba186 | 2016-10-26 02:41:55 -0700 | [diff] [blame] | 982 | EXPECT_EQ(1, transport_.packets_sent()); |
asapersson | 35151f3 | 2016-05-02 23:44:01 -0700 | [diff] [blame] | 983 | } |
| 984 | |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 985 | TEST_P(RtpSenderTest, OnSendPacketNotUpdatedForRetransmits) { |
stefan | a23fc62 | 2016-07-28 07:56:38 -0700 | [diff] [blame] | 986 | EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension( |
| 987 | kRtpExtensionTransportSequenceNumber, |
| 988 | kTransportSequenceNumberExtensionId)); |
asapersson | 35151f3 | 2016-05-02 23:44:01 -0700 | [diff] [blame] | 989 | rtp_sender_->SetStorePacketsStatus(true, 10); |
| 990 | |
| 991 | EXPECT_CALL(send_packet_observer_, OnSendPacket(_, _, _)).Times(0); |
| 992 | EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber()) |
| 993 | .WillOnce(testing::Return(kTransportSequenceNumber)); |
brandtr | 9dfff29 | 2016-11-14 05:14:50 -0800 | [diff] [blame] | 994 | EXPECT_CALL(mock_paced_sender_, InsertPacket(_, kSsrc, kSeqNum, _, _, _)) |
| 995 | .Times(1); |
asapersson | 35151f3 | 2016-05-02 23:44:01 -0700 | [diff] [blame] | 996 | |
| 997 | SendGenericPayload(); // Packet passed to pacer. |
| 998 | const bool kIsRetransmit = true; |
brandtr | 9dfff29 | 2016-11-14 05:14:50 -0800 | [diff] [blame] | 999 | rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum, |
| 1000 | fake_clock_.TimeInMilliseconds(), kIsRetransmit, |
philipel | 8aadd50 | 2017-02-23 02:56:13 -0800 | [diff] [blame] | 1001 | PacedPacketInfo()); |
danilchap | 12ba186 | 2016-10-26 02:41:55 -0700 | [diff] [blame] | 1002 | EXPECT_EQ(1, transport_.packets_sent()); |
Petter Strandmark | 26bc669 | 2018-05-29 08:43:35 +0200 | [diff] [blame] | 1003 | EXPECT_TRUE(transport_.last_options_.is_retransmit); |
asapersson | 35151f3 | 2016-05-02 23:44:01 -0700 | [diff] [blame] | 1004 | } |
| 1005 | |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 1006 | TEST_P(RtpSenderTest, OnSendPacketNotUpdatedWithoutSeqNumAllocator) { |
asapersson | 35151f3 | 2016-05-02 23:44:01 -0700 | [diff] [blame] | 1007 | rtp_sender_.reset(new RTPSender( |
brandtr | dbdb3f1 | 2016-11-10 05:04:48 -0800 | [diff] [blame] | 1008 | false, &fake_clock_, &transport_, &mock_paced_sender_, nullptr, |
asapersson | 35151f3 | 2016-05-02 23:44:01 -0700 | [diff] [blame] | 1009 | nullptr /* TransportSequenceNumberAllocator */, nullptr, nullptr, nullptr, |
michaelt | 4da3044 | 2016-11-17 01:38:43 -0800 | [diff] [blame] | 1010 | nullptr, nullptr, &send_packet_observer_, &retransmission_rate_limiter_, |
Johannes Kron | 9190b82 | 2018-10-29 11:22:05 +0100 | [diff] [blame] | 1011 | nullptr, false, nullptr, false, false)); |
brandtr | 9dfff29 | 2016-11-14 05:14:50 -0800 | [diff] [blame] | 1012 | rtp_sender_->SetSequenceNumber(kSeqNum); |
| 1013 | rtp_sender_->SetSSRC(kSsrc); |
stefan | a23fc62 | 2016-07-28 07:56:38 -0700 | [diff] [blame] | 1014 | EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension( |
| 1015 | kRtpExtensionTransportSequenceNumber, |
| 1016 | kTransportSequenceNumberExtensionId)); |
asapersson | 35151f3 | 2016-05-02 23:44:01 -0700 | [diff] [blame] | 1017 | rtp_sender_->SetSequenceNumber(kSeqNum); |
| 1018 | rtp_sender_->SetStorePacketsStatus(true, 10); |
| 1019 | |
| 1020 | EXPECT_CALL(send_packet_observer_, OnSendPacket(_, _, _)).Times(0); |
brandtr | 9dfff29 | 2016-11-14 05:14:50 -0800 | [diff] [blame] | 1021 | EXPECT_CALL(mock_paced_sender_, InsertPacket(_, kSsrc, kSeqNum, _, _, _)) |
| 1022 | .Times(1); |
asapersson | 35151f3 | 2016-05-02 23:44:01 -0700 | [diff] [blame] | 1023 | |
| 1024 | SendGenericPayload(); // Packet passed to pacer. |
| 1025 | const bool kIsRetransmit = false; |
brandtr | 9dfff29 | 2016-11-14 05:14:50 -0800 | [diff] [blame] | 1026 | rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum, |
| 1027 | fake_clock_.TimeInMilliseconds(), kIsRetransmit, |
philipel | 8aadd50 | 2017-02-23 02:56:13 -0800 | [diff] [blame] | 1028 | PacedPacketInfo()); |
danilchap | 12ba186 | 2016-10-26 02:41:55 -0700 | [diff] [blame] | 1029 | EXPECT_EQ(1, transport_.packets_sent()); |
asapersson | 35151f3 | 2016-05-02 23:44:01 -0700 | [diff] [blame] | 1030 | } |
| 1031 | |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 1032 | TEST_P(RtpSenderTest, SendRedundantPayloads) { |
stefan@webrtc.org | 7e9315b | 2013-12-04 10:24:26 +0000 | [diff] [blame] | 1033 | MockTransport transport; |
terelius | 429c345 | 2016-01-21 05:42:04 -0800 | [diff] [blame] | 1034 | rtp_sender_.reset(new RTPSender( |
asapersson | 35151f3 | 2016-05-02 23:44:01 -0700 | [diff] [blame] | 1035 | false, &fake_clock_, &transport, &mock_paced_sender_, nullptr, nullptr, |
brandtr | dbdb3f1 | 2016-11-10 05:04:48 -0800 | [diff] [blame] | 1036 | nullptr, nullptr, nullptr, nullptr, &mock_rtc_event_log_, nullptr, |
Johannes Kron | 9190b82 | 2018-10-29 11:22:05 +0100 | [diff] [blame] | 1037 | &retransmission_rate_limiter_, nullptr, false, nullptr, false, false)); |
stefan@webrtc.org | 7e9315b | 2013-12-04 10:24:26 +0000 | [diff] [blame] | 1038 | rtp_sender_->SetSequenceNumber(kSeqNum); |
brandtr | 9dfff29 | 2016-11-14 05:14:50 -0800 | [diff] [blame] | 1039 | rtp_sender_->SetSSRC(kSsrc); |
Shao Changbin | e62202f | 2015-04-21 20:24:50 +0800 | [diff] [blame] | 1040 | rtp_sender_->SetRtxPayloadType(kRtxPayload, kPayload); |
stefan@webrtc.org | 7e9315b | 2013-12-04 10:24:26 +0000 | [diff] [blame] | 1041 | |
| 1042 | uint16_t seq_num = kSeqNum; |
| 1043 | rtp_sender_->SetStorePacketsStatus(true, 10); |
wu@webrtc.org | ebdb0e3 | 2014-03-06 23:49:08 +0000 | [diff] [blame] | 1044 | int32_t rtp_header_len = kRtpHeaderSize; |
danilchap | 162abd3 | 2015-12-10 02:39:40 -0800 | [diff] [blame] | 1045 | EXPECT_EQ( |
| 1046 | 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime, |
| 1047 | kAbsoluteSendTimeExtensionId)); |
stefan@webrtc.org | 7e9315b | 2013-12-04 10:24:26 +0000 | [diff] [blame] | 1048 | rtp_header_len += 4; // 4 bytes extension. |
| 1049 | rtp_header_len += 4; // 4 extra bytes common to all extension headers. |
| 1050 | |
pbos@webrtc.org | 0b0c241 | 2015-01-13 14:15:15 +0000 | [diff] [blame] | 1051 | rtp_sender_->SetRtxStatus(kRtxRetransmitted | kRtxRedundantPayloads); |
stefan@webrtc.org | ef92755 | 2014-06-05 08:25:29 +0000 | [diff] [blame] | 1052 | rtp_sender_->SetRtxSsrc(1234); |
stefan@webrtc.org | 7e9315b | 2013-12-04 10:24:26 +0000 | [diff] [blame] | 1053 | |
stefan@webrtc.org | 7e9315b | 2013-12-04 10:24:26 +0000 | [diff] [blame] | 1054 | const size_t kNumPayloadSizes = 10; |
danilchap | 162abd3 | 2015-12-10 02:39:40 -0800 | [diff] [blame] | 1055 | const size_t kPayloadSizes[kNumPayloadSizes] = {500, 550, 600, 650, 700, |
| 1056 | 750, 800, 850, 900, 950}; |
terelius | 5d332ac | 2016-01-14 14:37:39 -0800 | [diff] [blame] | 1057 | // Expect all packets go through the pacer. |
| 1058 | EXPECT_CALL(mock_paced_sender_, |
brandtr | 9dfff29 | 2016-11-14 05:14:50 -0800 | [diff] [blame] | 1059 | InsertPacket(RtpPacketSender::kNormalPriority, kSsrc, _, _, _, _)) |
terelius | 5d332ac | 2016-01-14 14:37:39 -0800 | [diff] [blame] | 1060 | .Times(kNumPayloadSizes); |
Elad Alon | 4a87e1c | 2017-10-03 16:11:34 +0200 | [diff] [blame] | 1061 | EXPECT_CALL(mock_rtc_event_log_, |
| 1062 | LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing))) |
terelius | 429c345 | 2016-01-21 05:42:04 -0800 | [diff] [blame] | 1063 | .Times(kNumPayloadSizes); |
| 1064 | |
stefan@webrtc.org | 7e9315b | 2013-12-04 10:24:26 +0000 | [diff] [blame] | 1065 | // Send 10 packets of increasing size. |
| 1066 | for (size_t i = 0; i < kNumPayloadSizes; ++i) { |
| 1067 | int64_t capture_time_ms = fake_clock_.TimeInMilliseconds(); |
stefan | 1d8a506 | 2015-10-02 03:39:33 -0700 | [diff] [blame] | 1068 | EXPECT_CALL(transport, SendRtp(_, _, _)).WillOnce(testing::Return(true)); |
stefan@webrtc.org | 7e9315b | 2013-12-04 10:24:26 +0000 | [diff] [blame] | 1069 | SendPacket(capture_time_ms, kPayloadSizes[i]); |
brandtr | 9dfff29 | 2016-11-14 05:14:50 -0800 | [diff] [blame] | 1070 | rtp_sender_->TimeToSendPacket(kSsrc, seq_num++, capture_time_ms, false, |
philipel | 8aadd50 | 2017-02-23 02:56:13 -0800 | [diff] [blame] | 1071 | PacedPacketInfo()); |
stefan@webrtc.org | 7e9315b | 2013-12-04 10:24:26 +0000 | [diff] [blame] | 1072 | fake_clock_.AdvanceTimeMilliseconds(33); |
| 1073 | } |
terelius | 429c345 | 2016-01-21 05:42:04 -0800 | [diff] [blame] | 1074 | |
Elad Alon | 4a87e1c | 2017-10-03 16:11:34 +0200 | [diff] [blame] | 1075 | EXPECT_CALL(mock_rtc_event_log_, |
| 1076 | LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing))) |
terelius | 429c345 | 2016-01-21 05:42:04 -0800 | [diff] [blame] | 1077 | .Times(::testing::AtLeast(4)); |
| 1078 | |
stefan@webrtc.org | 7e9315b | 2013-12-04 10:24:26 +0000 | [diff] [blame] | 1079 | // The amount of padding to send it too small to send a payload packet. |
stefan | 1d8a506 | 2015-10-02 03:39:33 -0700 | [diff] [blame] | 1080 | EXPECT_CALL(transport, SendRtp(_, kMaxPaddingSize + rtp_header_len, _)) |
pbos | 2d56668 | 2015-09-28 09:59:31 -0700 | [diff] [blame] | 1081 | .WillOnce(testing::Return(true)); |
philipel | a1ed0b3 | 2016-06-01 06:31:17 -0700 | [diff] [blame] | 1082 | EXPECT_EQ(kMaxPaddingSize, |
philipel | 8aadd50 | 2017-02-23 02:56:13 -0800 | [diff] [blame] | 1083 | rtp_sender_->TimeToSendPadding(49, PacedPacketInfo())); |
stefan@webrtc.org | 7e9315b | 2013-12-04 10:24:26 +0000 | [diff] [blame] | 1084 | |
Petter Strandmark | 26bc669 | 2018-05-29 08:43:35 +0200 | [diff] [blame] | 1085 | PacketOptions options; |
Peter Boström | ac547a6 | 2015-09-17 23:03:57 +0200 | [diff] [blame] | 1086 | EXPECT_CALL(transport, |
stefan | 1d8a506 | 2015-10-02 03:39:33 -0700 | [diff] [blame] | 1087 | SendRtp(_, kPayloadSizes[0] + rtp_header_len + kRtxHeaderSize, _)) |
Yves Gerey | 665174f | 2018-06-19 15:03:05 +0200 | [diff] [blame] | 1088 | .WillOnce( |
| 1089 | testing::DoAll(testing::SaveArg<2>(&options), testing::Return(true))); |
philipel | a1ed0b3 | 2016-06-01 06:31:17 -0700 | [diff] [blame] | 1090 | EXPECT_EQ(kPayloadSizes[0], |
philipel | 8aadd50 | 2017-02-23 02:56:13 -0800 | [diff] [blame] | 1091 | rtp_sender_->TimeToSendPadding(500, PacedPacketInfo())); |
Petter Strandmark | 26bc669 | 2018-05-29 08:43:35 +0200 | [diff] [blame] | 1092 | EXPECT_TRUE(options.is_retransmit); |
stefan@webrtc.org | 7e9315b | 2013-12-04 10:24:26 +0000 | [diff] [blame] | 1093 | |
Yves Gerey | 665174f | 2018-06-19 15:03:05 +0200 | [diff] [blame] | 1094 | EXPECT_CALL(transport, SendRtp(_, |
| 1095 | kPayloadSizes[kNumPayloadSizes - 1] + |
| 1096 | rtp_header_len + kRtxHeaderSize, |
stefan | 1d8a506 | 2015-10-02 03:39:33 -0700 | [diff] [blame] | 1097 | _)) |
pbos | 2d56668 | 2015-09-28 09:59:31 -0700 | [diff] [blame] | 1098 | .WillOnce(testing::Return(true)); |
Petter Strandmark | 26bc669 | 2018-05-29 08:43:35 +0200 | [diff] [blame] | 1099 | |
| 1100 | options.is_retransmit = false; |
stefan | 1d8a506 | 2015-10-02 03:39:33 -0700 | [diff] [blame] | 1101 | EXPECT_CALL(transport, SendRtp(_, kMaxPaddingSize + rtp_header_len, _)) |
Yves Gerey | 665174f | 2018-06-19 15:03:05 +0200 | [diff] [blame] | 1102 | .WillOnce( |
| 1103 | testing::DoAll(testing::SaveArg<2>(&options), testing::Return(true))); |
pbos@webrtc.org | 2f4b14e | 2014-07-15 15:25:39 +0000 | [diff] [blame] | 1104 | EXPECT_EQ(kPayloadSizes[kNumPayloadSizes - 1] + kMaxPaddingSize, |
philipel | 8aadd50 | 2017-02-23 02:56:13 -0800 | [diff] [blame] | 1105 | rtp_sender_->TimeToSendPadding(999, PacedPacketInfo())); |
Petter Strandmark | 26bc669 | 2018-05-29 08:43:35 +0200 | [diff] [blame] | 1106 | EXPECT_FALSE(options.is_retransmit); |
stefan@webrtc.org | 7e9315b | 2013-12-04 10:24:26 +0000 | [diff] [blame] | 1107 | } |
| 1108 | |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 1109 | TEST_P(RtpSenderTestWithoutPacer, SendGenericVideo) { |
pbos@webrtc.org | 8911ce4 | 2013-03-18 16:39:03 +0000 | [diff] [blame] | 1110 | char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC"; |
| 1111 | const uint8_t payload_type = 127; |
| 1112 | ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 90000, |
| 1113 | 0, 1500)); |
| 1114 | uint8_t payload[] = {47, 11, 32, 93, 89}; |
| 1115 | |
| 1116 | // Send keyframe |
Sami Kalliomäki | 426a80c | 2018-08-08 11:37:59 +0200 | [diff] [blame] | 1117 | RTPVideoHeader video_header; |
sprang | a8ae6f2 | 2017-09-04 07:23:56 -0700 | [diff] [blame] | 1118 | ASSERT_TRUE(rtp_sender_->SendOutgoingData( |
| 1119 | kVideoFrameKey, payload_type, 1234, 4321, payload, sizeof(payload), |
Sami Kalliomäki | 426a80c | 2018-08-08 11:37:59 +0200 | [diff] [blame] | 1120 | nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs)); |
pbos@webrtc.org | 8911ce4 | 2013-03-18 16:39:03 +0000 | [diff] [blame] | 1121 | |
danilchap | 96c1587 | 2016-11-21 01:35:29 -0800 | [diff] [blame] | 1122 | auto sent_payload = transport_.last_sent_packet().payload(); |
| 1123 | uint8_t generic_header = sent_payload[0]; |
pbos@webrtc.org | 8911ce4 | 2013-03-18 16:39:03 +0000 | [diff] [blame] | 1124 | EXPECT_TRUE(generic_header & RtpFormatVideoGeneric::kKeyFrameBit); |
| 1125 | EXPECT_TRUE(generic_header & RtpFormatVideoGeneric::kFirstPacketBit); |
danilchap | 96c1587 | 2016-11-21 01:35:29 -0800 | [diff] [blame] | 1126 | EXPECT_THAT(sent_payload.subview(1), ElementsAreArray(payload)); |
pbos@webrtc.org | 8911ce4 | 2013-03-18 16:39:03 +0000 | [diff] [blame] | 1127 | |
| 1128 | // Send delta frame |
| 1129 | payload[0] = 13; |
| 1130 | payload[1] = 42; |
| 1131 | payload[4] = 13; |
| 1132 | |
Sergey Ulanov | 525df3f | 2016-08-02 17:46:41 -0700 | [diff] [blame] | 1133 | ASSERT_TRUE(rtp_sender_->SendOutgoingData( |
| 1134 | kVideoFrameDelta, payload_type, 1234, 4321, payload, sizeof(payload), |
Sami Kalliomäki | 426a80c | 2018-08-08 11:37:59 +0200 | [diff] [blame] | 1135 | nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs)); |
pbos@webrtc.org | 8911ce4 | 2013-03-18 16:39:03 +0000 | [diff] [blame] | 1136 | |
danilchap | 96c1587 | 2016-11-21 01:35:29 -0800 | [diff] [blame] | 1137 | sent_payload = transport_.last_sent_packet().payload(); |
| 1138 | generic_header = sent_payload[0]; |
pbos@webrtc.org | 8911ce4 | 2013-03-18 16:39:03 +0000 | [diff] [blame] | 1139 | EXPECT_FALSE(generic_header & RtpFormatVideoGeneric::kKeyFrameBit); |
| 1140 | EXPECT_TRUE(generic_header & RtpFormatVideoGeneric::kFirstPacketBit); |
danilchap | 96c1587 | 2016-11-21 01:35:29 -0800 | [diff] [blame] | 1141 | EXPECT_THAT(sent_payload.subview(1), ElementsAreArray(payload)); |
pbos@webrtc.org | 8911ce4 | 2013-03-18 16:39:03 +0000 | [diff] [blame] | 1142 | } |
| 1143 | |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 1144 | TEST_P(RtpSenderTest, SendFlexfecPackets) { |
brandtr | dbdb3f1 | 2016-11-10 05:04:48 -0800 | [diff] [blame] | 1145 | constexpr int kMediaPayloadType = 127; |
| 1146 | constexpr int kFlexfecPayloadType = 118; |
| 1147 | constexpr uint32_t kMediaSsrc = 1234; |
| 1148 | constexpr uint32_t kFlexfecSsrc = 5678; |
Steve Anton | f0482ea | 2018-04-09 13:33:52 -0700 | [diff] [blame] | 1149 | const char kNoMid[] = ""; |
brandtr | dbdb3f1 | 2016-11-10 05:04:48 -0800 | [diff] [blame] | 1150 | const std::vector<RtpExtension> kNoRtpExtensions; |
erikvarga | 2788373 | 2017-05-17 05:08:38 -0700 | [diff] [blame] | 1151 | const std::vector<RtpExtensionSize> kNoRtpExtensionSizes; |
brandtr | dbdb3f1 | 2016-11-10 05:04:48 -0800 | [diff] [blame] | 1152 | FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexfecSsrc, kMediaSsrc, |
Steve Anton | f0482ea | 2018-04-09 13:33:52 -0700 | [diff] [blame] | 1153 | kNoMid, kNoRtpExtensions, kNoRtpExtensionSizes, |
brandtr | 48d21a2 | 2017-05-30 02:32:12 -0700 | [diff] [blame] | 1154 | nullptr /* rtp_state */, &fake_clock_); |
brandtr | dbdb3f1 | 2016-11-10 05:04:48 -0800 | [diff] [blame] | 1155 | |
| 1156 | // Reset |rtp_sender_| to use FlexFEC. |
michaelt | 4da3044 | 2016-11-17 01:38:43 -0800 | [diff] [blame] | 1157 | rtp_sender_.reset(new RTPSender( |
| 1158 | false, &fake_clock_, &transport_, &mock_paced_sender_, &flexfec_sender, |
| 1159 | &seq_num_allocator_, nullptr, nullptr, nullptr, nullptr, |
| 1160 | &mock_rtc_event_log_, &send_packet_observer_, |
Johannes Kron | 9190b82 | 2018-10-29 11:22:05 +0100 | [diff] [blame] | 1161 | &retransmission_rate_limiter_, nullptr, false, nullptr, false, false)); |
brandtr | dbdb3f1 | 2016-11-10 05:04:48 -0800 | [diff] [blame] | 1162 | rtp_sender_->SetSSRC(kMediaSsrc); |
| 1163 | rtp_sender_->SetSequenceNumber(kSeqNum); |
brandtr | dbdb3f1 | 2016-11-10 05:04:48 -0800 | [diff] [blame] | 1164 | rtp_sender_->SetStorePacketsStatus(true, 10); |
| 1165 | |
| 1166 | // Parameters selected to generate a single FEC packet per media packet. |
| 1167 | FecProtectionParams params; |
| 1168 | params.fec_rate = 15; |
| 1169 | params.max_fec_frames = 1; |
| 1170 | params.fec_mask_type = kFecMaskRandom; |
| 1171 | rtp_sender_->SetFecParameters(params, params); |
| 1172 | |
brandtr | 9dfff29 | 2016-11-14 05:14:50 -0800 | [diff] [blame] | 1173 | EXPECT_CALL(mock_paced_sender_, |
| 1174 | InsertPacket(RtpPacketSender::kLowPriority, kMediaSsrc, kSeqNum, |
| 1175 | _, _, false)); |
| 1176 | uint16_t flexfec_seq_num; |
brandtr | dbdb3f1 | 2016-11-10 05:04:48 -0800 | [diff] [blame] | 1177 | EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kLowPriority, |
brandtr | 9dfff29 | 2016-11-14 05:14:50 -0800 | [diff] [blame] | 1178 | kFlexfecSsrc, _, _, _, false)) |
| 1179 | .WillOnce(testing::SaveArg<2>(&flexfec_seq_num)); |
brandtr | dbdb3f1 | 2016-11-10 05:04:48 -0800 | [diff] [blame] | 1180 | SendGenericPayload(); |
Elad Alon | 4a87e1c | 2017-10-03 16:11:34 +0200 | [diff] [blame] | 1181 | EXPECT_CALL(mock_rtc_event_log_, |
| 1182 | LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing))) |
| 1183 | .Times(2); |
philipel | 8aadd50 | 2017-02-23 02:56:13 -0800 | [diff] [blame] | 1184 | EXPECT_TRUE(rtp_sender_->TimeToSendPacket(kMediaSsrc, kSeqNum, |
| 1185 | fake_clock_.TimeInMilliseconds(), |
| 1186 | false, PacedPacketInfo())); |
brandtr | 9dfff29 | 2016-11-14 05:14:50 -0800 | [diff] [blame] | 1187 | EXPECT_TRUE(rtp_sender_->TimeToSendPacket(kFlexfecSsrc, flexfec_seq_num, |
| 1188 | fake_clock_.TimeInMilliseconds(), |
philipel | 8aadd50 | 2017-02-23 02:56:13 -0800 | [diff] [blame] | 1189 | false, PacedPacketInfo())); |
brandtr | 9dfff29 | 2016-11-14 05:14:50 -0800 | [diff] [blame] | 1190 | ASSERT_EQ(2, transport_.packets_sent()); |
brandtr | dbdb3f1 | 2016-11-10 05:04:48 -0800 | [diff] [blame] | 1191 | const RtpPacketReceived& media_packet = transport_.sent_packets_[0]; |
| 1192 | EXPECT_EQ(kMediaPayloadType, media_packet.PayloadType()); |
brandtr | 9dfff29 | 2016-11-14 05:14:50 -0800 | [diff] [blame] | 1193 | EXPECT_EQ(kSeqNum, media_packet.SequenceNumber()); |
brandtr | dbdb3f1 | 2016-11-10 05:04:48 -0800 | [diff] [blame] | 1194 | EXPECT_EQ(kMediaSsrc, media_packet.Ssrc()); |
brandtr | 9dfff29 | 2016-11-14 05:14:50 -0800 | [diff] [blame] | 1195 | const RtpPacketReceived& flexfec_packet = transport_.sent_packets_[1]; |
| 1196 | EXPECT_EQ(kFlexfecPayloadType, flexfec_packet.PayloadType()); |
| 1197 | EXPECT_EQ(flexfec_seq_num, flexfec_packet.SequenceNumber()); |
| 1198 | EXPECT_EQ(kFlexfecSsrc, flexfec_packet.Ssrc()); |
brandtr | dbdb3f1 | 2016-11-10 05:04:48 -0800 | [diff] [blame] | 1199 | } |
| 1200 | |
ilnik | 1089499 | 2017-06-21 08:23:19 -0700 | [diff] [blame] | 1201 | // TODO(ilnik): because of webrtc:7859. Once FEC moved below pacer, this test |
| 1202 | // should be removed. |
| 1203 | TEST_P(RtpSenderTest, NoFlexfecForTimingFrames) { |
| 1204 | constexpr int kMediaPayloadType = 127; |
| 1205 | constexpr int kFlexfecPayloadType = 118; |
| 1206 | constexpr uint32_t kMediaSsrc = 1234; |
| 1207 | constexpr uint32_t kFlexfecSsrc = 5678; |
Steve Anton | f0482ea | 2018-04-09 13:33:52 -0700 | [diff] [blame] | 1208 | const char kNoMid[] = ""; |
ilnik | 1089499 | 2017-06-21 08:23:19 -0700 | [diff] [blame] | 1209 | const std::vector<RtpExtension> kNoRtpExtensions; |
| 1210 | const std::vector<RtpExtensionSize> kNoRtpExtensionSizes; |
ilnik | e435019 | 2017-06-29 02:27:44 -0700 | [diff] [blame] | 1211 | |
ilnik | 1089499 | 2017-06-21 08:23:19 -0700 | [diff] [blame] | 1212 | FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexfecSsrc, kMediaSsrc, |
Steve Anton | f0482ea | 2018-04-09 13:33:52 -0700 | [diff] [blame] | 1213 | kNoMid, kNoRtpExtensions, kNoRtpExtensionSizes, |
ilnik | 1089499 | 2017-06-21 08:23:19 -0700 | [diff] [blame] | 1214 | nullptr /* rtp_state */, &fake_clock_); |
| 1215 | |
| 1216 | // Reset |rtp_sender_| to use FlexFEC. |
| 1217 | rtp_sender_.reset(new RTPSender( |
| 1218 | false, &fake_clock_, &transport_, &mock_paced_sender_, &flexfec_sender, |
| 1219 | &seq_num_allocator_, nullptr, nullptr, nullptr, nullptr, |
| 1220 | &mock_rtc_event_log_, &send_packet_observer_, |
Johannes Kron | 9190b82 | 2018-10-29 11:22:05 +0100 | [diff] [blame] | 1221 | &retransmission_rate_limiter_, nullptr, false, nullptr, false, false)); |
ilnik | 1089499 | 2017-06-21 08:23:19 -0700 | [diff] [blame] | 1222 | rtp_sender_->SetSSRC(kMediaSsrc); |
| 1223 | rtp_sender_->SetSequenceNumber(kSeqNum); |
ilnik | 1089499 | 2017-06-21 08:23:19 -0700 | [diff] [blame] | 1224 | rtp_sender_->SetStorePacketsStatus(true, 10); |
| 1225 | |
ilnik | e435019 | 2017-06-29 02:27:44 -0700 | [diff] [blame] | 1226 | // Need extension to be registered for timing frames to be sent. |
| 1227 | ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension( |
| 1228 | kRtpExtensionVideoTiming, kVideoTimingExtensionId)); |
| 1229 | |
ilnik | 1089499 | 2017-06-21 08:23:19 -0700 | [diff] [blame] | 1230 | // Parameters selected to generate a single FEC packet per media packet. |
| 1231 | FecProtectionParams params; |
| 1232 | params.fec_rate = 15; |
| 1233 | params.max_fec_frames = 1; |
| 1234 | params.fec_mask_type = kFecMaskRandom; |
| 1235 | rtp_sender_->SetFecParameters(params, params); |
| 1236 | |
| 1237 | EXPECT_CALL(mock_paced_sender_, |
| 1238 | InsertPacket(RtpPacketSender::kLowPriority, kMediaSsrc, kSeqNum, |
| 1239 | _, _, false)); |
| 1240 | EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kLowPriority, |
| 1241 | kFlexfecSsrc, _, _, _, false)) |
| 1242 | .Times(0); // Not called because packet should not be protected. |
| 1243 | |
| 1244 | const uint32_t kTimestamp = 1234; |
| 1245 | const uint8_t kPayloadType = 127; |
| 1246 | const int64_t kCaptureTimeMs = fake_clock_.TimeInMilliseconds(); |
| 1247 | char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC"; |
| 1248 | EXPECT_EQ(0, rtp_sender_->RegisterPayload(payload_name, kPayloadType, 90000, |
| 1249 | 0, 1500)); |
| 1250 | RTPVideoHeader video_header; |
Ilya Nikolaevskiy | b6c462d | 2018-06-05 15:21:32 +0200 | [diff] [blame] | 1251 | video_header.video_timing.flags = VideoSendTiming::kTriggeredByTimer; |
ilnik | 1089499 | 2017-06-21 08:23:19 -0700 | [diff] [blame] | 1252 | EXPECT_TRUE(rtp_sender_->SendOutgoingData( |
| 1253 | kVideoFrameKey, kPayloadType, kTimestamp, kCaptureTimeMs, kPayloadData, |
sprang | a8ae6f2 | 2017-09-04 07:23:56 -0700 | [diff] [blame] | 1254 | sizeof(kPayloadData), nullptr, &video_header, nullptr, |
| 1255 | kDefaultExpectedRetransmissionTimeMs)); |
ilnik | 1089499 | 2017-06-21 08:23:19 -0700 | [diff] [blame] | 1256 | |
Elad Alon | 4a87e1c | 2017-10-03 16:11:34 +0200 | [diff] [blame] | 1257 | EXPECT_CALL(mock_rtc_event_log_, |
| 1258 | LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing))) |
| 1259 | .Times(1); |
ilnik | 1089499 | 2017-06-21 08:23:19 -0700 | [diff] [blame] | 1260 | EXPECT_TRUE(rtp_sender_->TimeToSendPacket(kMediaSsrc, kSeqNum, |
| 1261 | fake_clock_.TimeInMilliseconds(), |
| 1262 | false, PacedPacketInfo())); |
| 1263 | ASSERT_EQ(1, transport_.packets_sent()); |
| 1264 | const RtpPacketReceived& media_packet = transport_.sent_packets_[0]; |
| 1265 | EXPECT_EQ(kMediaPayloadType, media_packet.PayloadType()); |
| 1266 | EXPECT_EQ(kSeqNum, media_packet.SequenceNumber()); |
| 1267 | EXPECT_EQ(kMediaSsrc, media_packet.Ssrc()); |
| 1268 | |
| 1269 | // Now try to send not a timing frame. |
| 1270 | uint16_t flexfec_seq_num; |
| 1271 | EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kLowPriority, |
| 1272 | kFlexfecSsrc, _, _, _, false)) |
| 1273 | .WillOnce(testing::SaveArg<2>(&flexfec_seq_num)); |
| 1274 | EXPECT_CALL(mock_paced_sender_, |
| 1275 | InsertPacket(RtpPacketSender::kLowPriority, kMediaSsrc, |
| 1276 | kSeqNum + 1, _, _, false)); |
Ilya Nikolaevskiy | b6c462d | 2018-06-05 15:21:32 +0200 | [diff] [blame] | 1277 | video_header.video_timing.flags = VideoSendTiming::kInvalid; |
ilnik | 1089499 | 2017-06-21 08:23:19 -0700 | [diff] [blame] | 1278 | EXPECT_TRUE(rtp_sender_->SendOutgoingData( |
| 1279 | kVideoFrameKey, kPayloadType, kTimestamp + 1, kCaptureTimeMs + 1, |
sprang | a8ae6f2 | 2017-09-04 07:23:56 -0700 | [diff] [blame] | 1280 | kPayloadData, sizeof(kPayloadData), nullptr, &video_header, nullptr, |
| 1281 | kDefaultExpectedRetransmissionTimeMs)); |
ilnik | 1089499 | 2017-06-21 08:23:19 -0700 | [diff] [blame] | 1282 | |
Elad Alon | 4a87e1c | 2017-10-03 16:11:34 +0200 | [diff] [blame] | 1283 | EXPECT_CALL(mock_rtc_event_log_, |
| 1284 | LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing))) |
| 1285 | .Times(2); |
ilnik | 1089499 | 2017-06-21 08:23:19 -0700 | [diff] [blame] | 1286 | EXPECT_TRUE(rtp_sender_->TimeToSendPacket(kMediaSsrc, kSeqNum + 1, |
| 1287 | fake_clock_.TimeInMilliseconds(), |
| 1288 | false, PacedPacketInfo())); |
| 1289 | EXPECT_TRUE(rtp_sender_->TimeToSendPacket(kFlexfecSsrc, flexfec_seq_num, |
| 1290 | fake_clock_.TimeInMilliseconds(), |
| 1291 | false, PacedPacketInfo())); |
| 1292 | ASSERT_EQ(3, transport_.packets_sent()); |
| 1293 | const RtpPacketReceived& media_packet2 = transport_.sent_packets_[1]; |
| 1294 | EXPECT_EQ(kMediaPayloadType, media_packet2.PayloadType()); |
| 1295 | EXPECT_EQ(kSeqNum + 1, media_packet2.SequenceNumber()); |
| 1296 | EXPECT_EQ(kMediaSsrc, media_packet2.Ssrc()); |
| 1297 | const RtpPacketReceived& flexfec_packet = transport_.sent_packets_[2]; |
| 1298 | EXPECT_EQ(kFlexfecPayloadType, flexfec_packet.PayloadType()); |
| 1299 | EXPECT_EQ(flexfec_seq_num, flexfec_packet.SequenceNumber()); |
| 1300 | EXPECT_EQ(kFlexfecSsrc, flexfec_packet.Ssrc()); |
| 1301 | } |
| 1302 | |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 1303 | TEST_P(RtpSenderTestWithoutPacer, SendFlexfecPackets) { |
brandtr | dbdb3f1 | 2016-11-10 05:04:48 -0800 | [diff] [blame] | 1304 | constexpr int kMediaPayloadType = 127; |
| 1305 | constexpr int kFlexfecPayloadType = 118; |
| 1306 | constexpr uint32_t kMediaSsrc = 1234; |
| 1307 | constexpr uint32_t kFlexfecSsrc = 5678; |
Steve Anton | f0482ea | 2018-04-09 13:33:52 -0700 | [diff] [blame] | 1308 | const char kNoMid[] = ""; |
brandtr | dbdb3f1 | 2016-11-10 05:04:48 -0800 | [diff] [blame] | 1309 | const std::vector<RtpExtension> kNoRtpExtensions; |
erikvarga | 2788373 | 2017-05-17 05:08:38 -0700 | [diff] [blame] | 1310 | const std::vector<RtpExtensionSize> kNoRtpExtensionSizes; |
brandtr | dbdb3f1 | 2016-11-10 05:04:48 -0800 | [diff] [blame] | 1311 | FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexfecSsrc, kMediaSsrc, |
Steve Anton | f0482ea | 2018-04-09 13:33:52 -0700 | [diff] [blame] | 1312 | kNoMid, kNoRtpExtensions, kNoRtpExtensionSizes, |
brandtr | 48d21a2 | 2017-05-30 02:32:12 -0700 | [diff] [blame] | 1313 | nullptr /* rtp_state */, &fake_clock_); |
brandtr | dbdb3f1 | 2016-11-10 05:04:48 -0800 | [diff] [blame] | 1314 | |
| 1315 | // Reset |rtp_sender_| to use FlexFEC. |
Benjamin Wright | 192eeec | 2018-10-17 17:27:25 -0700 | [diff] [blame] | 1316 | rtp_sender_.reset(new RTPSender( |
| 1317 | false, &fake_clock_, &transport_, nullptr, &flexfec_sender, |
| 1318 | &seq_num_allocator_, nullptr, nullptr, nullptr, nullptr, |
| 1319 | &mock_rtc_event_log_, &send_packet_observer_, |
Johannes Kron | 9190b82 | 2018-10-29 11:22:05 +0100 | [diff] [blame] | 1320 | &retransmission_rate_limiter_, nullptr, false, nullptr, false, false)); |
brandtr | dbdb3f1 | 2016-11-10 05:04:48 -0800 | [diff] [blame] | 1321 | rtp_sender_->SetSSRC(kMediaSsrc); |
| 1322 | rtp_sender_->SetSequenceNumber(kSeqNum); |
brandtr | dbdb3f1 | 2016-11-10 05:04:48 -0800 | [diff] [blame] | 1323 | |
| 1324 | // Parameters selected to generate a single FEC packet per media packet. |
| 1325 | FecProtectionParams params; |
| 1326 | params.fec_rate = 15; |
| 1327 | params.max_fec_frames = 1; |
| 1328 | params.fec_mask_type = kFecMaskRandom; |
| 1329 | rtp_sender_->SetFecParameters(params, params); |
| 1330 | |
Elad Alon | 4a87e1c | 2017-10-03 16:11:34 +0200 | [diff] [blame] | 1331 | EXPECT_CALL(mock_rtc_event_log_, |
| 1332 | LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing))) |
| 1333 | .Times(2); |
brandtr | dbdb3f1 | 2016-11-10 05:04:48 -0800 | [diff] [blame] | 1334 | SendGenericPayload(); |
| 1335 | ASSERT_EQ(2, transport_.packets_sent()); |
| 1336 | const RtpPacketReceived& media_packet = transport_.sent_packets_[0]; |
| 1337 | EXPECT_EQ(kMediaPayloadType, media_packet.PayloadType()); |
| 1338 | EXPECT_EQ(kMediaSsrc, media_packet.Ssrc()); |
| 1339 | const RtpPacketReceived& flexfec_packet = transport_.sent_packets_[1]; |
| 1340 | EXPECT_EQ(kFlexfecPayloadType, flexfec_packet.PayloadType()); |
| 1341 | EXPECT_EQ(kFlexfecSsrc, flexfec_packet.Ssrc()); |
| 1342 | } |
| 1343 | |
Steve Anton | 296a0ce | 2018-03-22 15:17:27 -0700 | [diff] [blame] | 1344 | // Test that the MID header extension is included on sent packets when |
| 1345 | // configured. |
| 1346 | TEST_P(RtpSenderTestWithoutPacer, MidIncludedOnSentPackets) { |
| 1347 | const char kMid[] = "mid"; |
| 1348 | |
| 1349 | // Register MID header extension and set the MID for the RTPSender. |
| 1350 | rtp_sender_->SetSendingMediaStatus(false); |
| 1351 | rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionMid, kMidExtensionId); |
| 1352 | rtp_sender_->SetMid(kMid); |
| 1353 | rtp_sender_->SetSendingMediaStatus(true); |
| 1354 | |
| 1355 | // Send a couple packets. |
| 1356 | SendGenericPayload(); |
| 1357 | SendGenericPayload(); |
| 1358 | |
| 1359 | // Expect both packets to have the MID set. |
| 1360 | ASSERT_EQ(2u, transport_.sent_packets_.size()); |
| 1361 | for (const RtpPacketReceived& packet : transport_.sent_packets_) { |
| 1362 | std::string mid; |
| 1363 | ASSERT_TRUE(packet.GetExtension<RtpMid>(&mid)); |
| 1364 | EXPECT_EQ(kMid, mid); |
| 1365 | } |
| 1366 | } |
| 1367 | |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 1368 | TEST_P(RtpSenderTest, FecOverheadRate) { |
brandtr | 81eab61 | 2017-01-24 04:06:09 -0800 | [diff] [blame] | 1369 | constexpr int kFlexfecPayloadType = 118; |
| 1370 | constexpr uint32_t kMediaSsrc = 1234; |
| 1371 | constexpr uint32_t kFlexfecSsrc = 5678; |
Steve Anton | f0482ea | 2018-04-09 13:33:52 -0700 | [diff] [blame] | 1372 | const char kNoMid[] = ""; |
brandtr | 81eab61 | 2017-01-24 04:06:09 -0800 | [diff] [blame] | 1373 | const std::vector<RtpExtension> kNoRtpExtensions; |
erikvarga | 2788373 | 2017-05-17 05:08:38 -0700 | [diff] [blame] | 1374 | const std::vector<RtpExtensionSize> kNoRtpExtensionSizes; |
brandtr | 81eab61 | 2017-01-24 04:06:09 -0800 | [diff] [blame] | 1375 | FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexfecSsrc, kMediaSsrc, |
Steve Anton | f0482ea | 2018-04-09 13:33:52 -0700 | [diff] [blame] | 1376 | kNoMid, kNoRtpExtensions, kNoRtpExtensionSizes, |
brandtr | 48d21a2 | 2017-05-30 02:32:12 -0700 | [diff] [blame] | 1377 | nullptr /* rtp_state */, &fake_clock_); |
brandtr | 81eab61 | 2017-01-24 04:06:09 -0800 | [diff] [blame] | 1378 | |
| 1379 | // Reset |rtp_sender_| to use FlexFEC. |
| 1380 | rtp_sender_.reset(new RTPSender( |
| 1381 | false, &fake_clock_, &transport_, &mock_paced_sender_, &flexfec_sender, |
| 1382 | &seq_num_allocator_, nullptr, nullptr, nullptr, nullptr, |
| 1383 | &mock_rtc_event_log_, &send_packet_observer_, |
Johannes Kron | 9190b82 | 2018-10-29 11:22:05 +0100 | [diff] [blame] | 1384 | &retransmission_rate_limiter_, nullptr, false, nullptr, false, false)); |
brandtr | 81eab61 | 2017-01-24 04:06:09 -0800 | [diff] [blame] | 1385 | rtp_sender_->SetSSRC(kMediaSsrc); |
| 1386 | rtp_sender_->SetSequenceNumber(kSeqNum); |
brandtr | 81eab61 | 2017-01-24 04:06:09 -0800 | [diff] [blame] | 1387 | |
| 1388 | // Parameters selected to generate a single FEC packet per media packet. |
| 1389 | FecProtectionParams params; |
| 1390 | params.fec_rate = 15; |
| 1391 | params.max_fec_frames = 1; |
| 1392 | params.fec_mask_type = kFecMaskRandom; |
| 1393 | rtp_sender_->SetFecParameters(params, params); |
| 1394 | |
| 1395 | constexpr size_t kNumMediaPackets = 10; |
| 1396 | constexpr size_t kNumFecPackets = kNumMediaPackets; |
| 1397 | constexpr int64_t kTimeBetweenPacketsMs = 10; |
| 1398 | EXPECT_CALL(mock_paced_sender_, InsertPacket(_, _, _, _, _, false)) |
| 1399 | .Times(kNumMediaPackets + kNumFecPackets); |
| 1400 | for (size_t i = 0; i < kNumMediaPackets; ++i) { |
| 1401 | SendGenericPayload(); |
| 1402 | fake_clock_.AdvanceTimeMilliseconds(kTimeBetweenPacketsMs); |
| 1403 | } |
| 1404 | constexpr size_t kRtpHeaderLength = 12; |
| 1405 | constexpr size_t kFlexfecHeaderLength = 20; |
| 1406 | constexpr size_t kGenericCodecHeaderLength = 1; |
| 1407 | constexpr size_t kPayloadLength = sizeof(kPayloadData); |
| 1408 | constexpr size_t kPacketLength = kRtpHeaderLength + kFlexfecHeaderLength + |
| 1409 | kGenericCodecHeaderLength + kPayloadLength; |
| 1410 | EXPECT_NEAR(kNumFecPackets * kPacketLength * 8 / |
| 1411 | (kNumFecPackets * kTimeBetweenPacketsMs / 1000.0f), |
| 1412 | rtp_sender_->FecOverheadRate(), 500); |
| 1413 | } |
| 1414 | |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 1415 | TEST_P(RtpSenderTest, FrameCountCallbacks) { |
sprang@webrtc.org | 71f055f | 2013-12-04 15:09:27 +0000 | [diff] [blame] | 1416 | class TestCallback : public FrameCountObserver { |
| 1417 | public: |
pbos@webrtc.org | ce4e9a3 | 2014-12-18 13:50:16 +0000 | [diff] [blame] | 1418 | TestCallback() : FrameCountObserver(), num_calls_(0), ssrc_(0) {} |
Danil Chapovalov | dd7e284 | 2018-03-09 15:37:03 +0000 | [diff] [blame] | 1419 | ~TestCallback() override = default; |
sprang@webrtc.org | 71f055f | 2013-12-04 15:09:27 +0000 | [diff] [blame] | 1420 | |
kjellander@webrtc.org | 14665ff | 2015-03-04 12:58:35 +0000 | [diff] [blame] | 1421 | void FrameCountUpdated(const FrameCounts& frame_counts, |
| 1422 | uint32_t ssrc) override { |
sprang@webrtc.org | 71f055f | 2013-12-04 15:09:27 +0000 | [diff] [blame] | 1423 | ++num_calls_; |
| 1424 | ssrc_ = ssrc; |
pbos@webrtc.org | ce4e9a3 | 2014-12-18 13:50:16 +0000 | [diff] [blame] | 1425 | frame_counts_ = frame_counts; |
sprang@webrtc.org | 71f055f | 2013-12-04 15:09:27 +0000 | [diff] [blame] | 1426 | } |
| 1427 | |
| 1428 | uint32_t num_calls_; |
| 1429 | uint32_t ssrc_; |
pbos@webrtc.org | ce4e9a3 | 2014-12-18 13:50:16 +0000 | [diff] [blame] | 1430 | FrameCounts frame_counts_; |
sprang@webrtc.org | 71f055f | 2013-12-04 15:09:27 +0000 | [diff] [blame] | 1431 | } callback; |
| 1432 | |
Erik Språng | 7b52f10 | 2018-02-07 14:37:37 +0100 | [diff] [blame] | 1433 | rtp_sender_.reset(new RTPSender( |
| 1434 | false, &fake_clock_, &transport_, &mock_paced_sender_, nullptr, nullptr, |
| 1435 | nullptr, nullptr, &callback, nullptr, nullptr, nullptr, |
Johannes Kron | 9190b82 | 2018-10-29 11:22:05 +0100 | [diff] [blame] | 1436 | &retransmission_rate_limiter_, nullptr, false, nullptr, false, false)); |
nisse | 7d59f6b | 2017-02-21 03:40:24 -0800 | [diff] [blame] | 1437 | rtp_sender_->SetSSRC(kSsrc); |
sprang@webrtc.org | 71f055f | 2013-12-04 15:09:27 +0000 | [diff] [blame] | 1438 | char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC"; |
| 1439 | const uint8_t payload_type = 127; |
| 1440 | ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 90000, |
| 1441 | 0, 1500)); |
| 1442 | uint8_t payload[] = {47, 11, 32, 93, 89}; |
| 1443 | rtp_sender_->SetStorePacketsStatus(true, 1); |
| 1444 | uint32_t ssrc = rtp_sender_->SSRC(); |
| 1445 | |
terelius | 5d332ac | 2016-01-14 14:37:39 -0800 | [diff] [blame] | 1446 | EXPECT_CALL(mock_paced_sender_, InsertPacket(_, _, _, _, _, _)) |
| 1447 | .Times(::testing::AtLeast(2)); |
| 1448 | |
Sami Kalliomäki | 426a80c | 2018-08-08 11:37:59 +0200 | [diff] [blame] | 1449 | RTPVideoHeader video_header; |
sprang | a8ae6f2 | 2017-09-04 07:23:56 -0700 | [diff] [blame] | 1450 | ASSERT_TRUE(rtp_sender_->SendOutgoingData( |
| 1451 | kVideoFrameKey, payload_type, 1234, 4321, payload, sizeof(payload), |
Sami Kalliomäki | 426a80c | 2018-08-08 11:37:59 +0200 | [diff] [blame] | 1452 | nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs)); |
sprang@webrtc.org | 71f055f | 2013-12-04 15:09:27 +0000 | [diff] [blame] | 1453 | |
| 1454 | EXPECT_EQ(1U, callback.num_calls_); |
| 1455 | EXPECT_EQ(ssrc, callback.ssrc_); |
pbos@webrtc.org | ce4e9a3 | 2014-12-18 13:50:16 +0000 | [diff] [blame] | 1456 | EXPECT_EQ(1, callback.frame_counts_.key_frames); |
| 1457 | EXPECT_EQ(0, callback.frame_counts_.delta_frames); |
sprang@webrtc.org | 71f055f | 2013-12-04 15:09:27 +0000 | [diff] [blame] | 1458 | |
Sergey Ulanov | 525df3f | 2016-08-02 17:46:41 -0700 | [diff] [blame] | 1459 | ASSERT_TRUE(rtp_sender_->SendOutgoingData( |
| 1460 | kVideoFrameDelta, payload_type, 1234, 4321, payload, sizeof(payload), |
Sami Kalliomäki | 426a80c | 2018-08-08 11:37:59 +0200 | [diff] [blame] | 1461 | nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs)); |
sprang@webrtc.org | 71f055f | 2013-12-04 15:09:27 +0000 | [diff] [blame] | 1462 | |
| 1463 | EXPECT_EQ(2U, callback.num_calls_); |
| 1464 | EXPECT_EQ(ssrc, callback.ssrc_); |
pbos@webrtc.org | ce4e9a3 | 2014-12-18 13:50:16 +0000 | [diff] [blame] | 1465 | EXPECT_EQ(1, callback.frame_counts_.key_frames); |
| 1466 | EXPECT_EQ(1, callback.frame_counts_.delta_frames); |
sprang@webrtc.org | 71f055f | 2013-12-04 15:09:27 +0000 | [diff] [blame] | 1467 | |
andresp@webrtc.org | 8f15121 | 2014-07-10 09:39:23 +0000 | [diff] [blame] | 1468 | rtp_sender_.reset(); |
sprang@webrtc.org | 71f055f | 2013-12-04 15:09:27 +0000 | [diff] [blame] | 1469 | } |
| 1470 | |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 1471 | TEST_P(RtpSenderTest, BitrateCallbacks) { |
sprang@webrtc.org | 6811b6e | 2013-12-13 09:46:59 +0000 | [diff] [blame] | 1472 | class TestCallback : public BitrateStatisticsObserver { |
| 1473 | public: |
sprang | cd349d9 | 2016-07-13 09:11:28 -0700 | [diff] [blame] | 1474 | TestCallback() |
| 1475 | : BitrateStatisticsObserver(), |
| 1476 | num_calls_(0), |
| 1477 | ssrc_(0), |
| 1478 | total_bitrate_(0), |
| 1479 | retransmit_bitrate_(0) {} |
Danil Chapovalov | dd7e284 | 2018-03-09 15:37:03 +0000 | [diff] [blame] | 1480 | ~TestCallback() override = default; |
sprang@webrtc.org | 6811b6e | 2013-12-13 09:46:59 +0000 | [diff] [blame] | 1481 | |
sprang | cd349d9 | 2016-07-13 09:11:28 -0700 | [diff] [blame] | 1482 | void Notify(uint32_t total_bitrate, |
| 1483 | uint32_t retransmit_bitrate, |
kjellander@webrtc.org | 14665ff | 2015-03-04 12:58:35 +0000 | [diff] [blame] | 1484 | uint32_t ssrc) override { |
sprang@webrtc.org | 6811b6e | 2013-12-13 09:46:59 +0000 | [diff] [blame] | 1485 | ++num_calls_; |
| 1486 | ssrc_ = ssrc; |
sprang | cd349d9 | 2016-07-13 09:11:28 -0700 | [diff] [blame] | 1487 | total_bitrate_ = total_bitrate; |
| 1488 | retransmit_bitrate_ = retransmit_bitrate; |
sprang@webrtc.org | 6811b6e | 2013-12-13 09:46:59 +0000 | [diff] [blame] | 1489 | } |
| 1490 | |
| 1491 | uint32_t num_calls_; |
| 1492 | uint32_t ssrc_; |
sprang | cd349d9 | 2016-07-13 09:11:28 -0700 | [diff] [blame] | 1493 | uint32_t total_bitrate_; |
| 1494 | uint32_t retransmit_bitrate_; |
sprang@webrtc.org | 6811b6e | 2013-12-13 09:46:59 +0000 | [diff] [blame] | 1495 | } callback; |
Benjamin Wright | 192eeec | 2018-10-17 17:27:25 -0700 | [diff] [blame] | 1496 | rtp_sender_.reset(new RTPSender( |
| 1497 | false, &fake_clock_, &transport_, nullptr, nullptr, nullptr, nullptr, |
| 1498 | &callback, nullptr, nullptr, nullptr, nullptr, |
Johannes Kron | 9190b82 | 2018-10-29 11:22:05 +0100 | [diff] [blame] | 1499 | &retransmission_rate_limiter_, nullptr, false, nullptr, false, false)); |
nisse | 7d59f6b | 2017-02-21 03:40:24 -0800 | [diff] [blame] | 1500 | rtp_sender_->SetSSRC(kSsrc); |
sprang@webrtc.org | 6811b6e | 2013-12-13 09:46:59 +0000 | [diff] [blame] | 1501 | |
sprang | cd349d9 | 2016-07-13 09:11:28 -0700 | [diff] [blame] | 1502 | // Simulate kNumPackets sent with kPacketInterval ms intervals, with the |
| 1503 | // number of packets selected so that we fill (but don't overflow) the one |
| 1504 | // second averaging window. |
| 1505 | const uint32_t kWindowSizeMs = 1000; |
sprang@webrtc.org | 6811b6e | 2013-12-13 09:46:59 +0000 | [diff] [blame] | 1506 | const uint32_t kPacketInterval = 20; |
sprang | cd349d9 | 2016-07-13 09:11:28 -0700 | [diff] [blame] | 1507 | const uint32_t kNumPackets = |
| 1508 | (kWindowSizeMs - kPacketInterval) / kPacketInterval; |
sprang@webrtc.org | 6811b6e | 2013-12-13 09:46:59 +0000 | [diff] [blame] | 1509 | // Overhead = 12 bytes RTP header + 1 byte generic header. |
| 1510 | const uint32_t kPacketOverhead = 13; |
| 1511 | |
| 1512 | char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC"; |
| 1513 | const uint8_t payload_type = 127; |
danilchap | 162abd3 | 2015-12-10 02:39:40 -0800 | [diff] [blame] | 1514 | ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 90000, |
| 1515 | 0, 1500)); |
sprang@webrtc.org | 6811b6e | 2013-12-13 09:46:59 +0000 | [diff] [blame] | 1516 | uint8_t payload[] = {47, 11, 32, 93, 89}; |
| 1517 | rtp_sender_->SetStorePacketsStatus(true, 1); |
| 1518 | uint32_t ssrc = rtp_sender_->SSRC(); |
| 1519 | |
sprang@webrtc.org | 6811b6e | 2013-12-13 09:46:59 +0000 | [diff] [blame] | 1520 | // Initial process call so we get a new time window. |
| 1521 | rtp_sender_->ProcessBitrate(); |
sprang@webrtc.org | 6811b6e | 2013-12-13 09:46:59 +0000 | [diff] [blame] | 1522 | |
| 1523 | // Send a few frames. |
Sami Kalliomäki | 426a80c | 2018-08-08 11:37:59 +0200 | [diff] [blame] | 1524 | RTPVideoHeader video_header; |
sprang@webrtc.org | 6811b6e | 2013-12-13 09:46:59 +0000 | [diff] [blame] | 1525 | for (uint32_t i = 0; i < kNumPackets; ++i) { |
Sergey Ulanov | 525df3f | 2016-08-02 17:46:41 -0700 | [diff] [blame] | 1526 | ASSERT_TRUE(rtp_sender_->SendOutgoingData( |
| 1527 | kVideoFrameKey, payload_type, 1234, 4321, payload, sizeof(payload), |
Sami Kalliomäki | 426a80c | 2018-08-08 11:37:59 +0200 | [diff] [blame] | 1528 | nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs)); |
sprang@webrtc.org | 6811b6e | 2013-12-13 09:46:59 +0000 | [diff] [blame] | 1529 | fake_clock_.AdvanceTimeMilliseconds(kPacketInterval); |
| 1530 | } |
| 1531 | |
| 1532 | rtp_sender_->ProcessBitrate(); |
| 1533 | |
stefan@webrtc.org | 0bae1fa | 2014-11-05 14:05:29 +0000 | [diff] [blame] | 1534 | // We get one call for every stats updated, thus two calls since both the |
| 1535 | // stream stats and the retransmit stats are updated once. |
| 1536 | EXPECT_EQ(2u, callback.num_calls_); |
sprang@webrtc.org | 6811b6e | 2013-12-13 09:46:59 +0000 | [diff] [blame] | 1537 | EXPECT_EQ(ssrc, callback.ssrc_); |
sprang | cd349d9 | 2016-07-13 09:11:28 -0700 | [diff] [blame] | 1538 | const uint32_t kTotalPacketSize = kPacketOverhead + sizeof(payload); |
| 1539 | // Bitrate measured over delta between last and first timestamp, plus one. |
| 1540 | const uint32_t kExpectedWindowMs = kNumPackets * kPacketInterval + 1; |
| 1541 | const uint32_t kExpectedBitsAccumulated = kTotalPacketSize * kNumPackets * 8; |
| 1542 | const uint32_t kExpectedRateBps = |
| 1543 | (kExpectedBitsAccumulated * 1000 + (kExpectedWindowMs / 2)) / |
| 1544 | kExpectedWindowMs; |
| 1545 | EXPECT_EQ(kExpectedRateBps, callback.total_bitrate_); |
sprang@webrtc.org | 6811b6e | 2013-12-13 09:46:59 +0000 | [diff] [blame] | 1546 | |
andresp@webrtc.org | d11bec4 | 2014-07-08 14:32:58 +0000 | [diff] [blame] | 1547 | rtp_sender_.reset(); |
sprang@webrtc.org | 6811b6e | 2013-12-13 09:46:59 +0000 | [diff] [blame] | 1548 | } |
| 1549 | |
solenberg@webrtc.org | c0352d5 | 2013-05-20 20:55:07 +0000 | [diff] [blame] | 1550 | class RtpSenderAudioTest : public RtpSenderTest { |
| 1551 | protected: |
| 1552 | RtpSenderAudioTest() {} |
pbos@webrtc.org | 8911ce4 | 2013-03-18 16:39:03 +0000 | [diff] [blame] | 1553 | |
kjellander@webrtc.org | 14665ff | 2015-03-04 12:58:35 +0000 | [diff] [blame] | 1554 | void SetUp() override { |
solenberg@webrtc.org | c0352d5 | 2013-05-20 20:55:07 +0000 | [diff] [blame] | 1555 | payload_ = kAudioPayload; |
Benjamin Wright | 192eeec | 2018-10-17 17:27:25 -0700 | [diff] [blame] | 1556 | rtp_sender_.reset(new RTPSender( |
| 1557 | true, &fake_clock_, &transport_, nullptr, nullptr, nullptr, nullptr, |
| 1558 | nullptr, nullptr, nullptr, nullptr, nullptr, |
Johannes Kron | 9190b82 | 2018-10-29 11:22:05 +0100 | [diff] [blame] | 1559 | &retransmission_rate_limiter_, nullptr, false, nullptr, false, false)); |
nisse | 7d59f6b | 2017-02-21 03:40:24 -0800 | [diff] [blame] | 1560 | rtp_sender_->SetSSRC(kSsrc); |
solenberg@webrtc.org | c0352d5 | 2013-05-20 20:55:07 +0000 | [diff] [blame] | 1561 | rtp_sender_->SetSequenceNumber(kSeqNum); |
| 1562 | } |
| 1563 | }; |
| 1564 | |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 1565 | TEST_P(RtpSenderTestWithoutPacer, StreamDataCountersCallbacks) { |
sprang@webrtc.org | ebad765 | 2013-12-05 14:29:02 +0000 | [diff] [blame] | 1566 | class TestCallback : public StreamDataCountersCallback { |
| 1567 | public: |
danilchap | 162abd3 | 2015-12-10 02:39:40 -0800 | [diff] [blame] | 1568 | TestCallback() : StreamDataCountersCallback(), ssrc_(0), counters_() {} |
Danil Chapovalov | dd7e284 | 2018-03-09 15:37:03 +0000 | [diff] [blame] | 1569 | ~TestCallback() override = default; |
sprang@webrtc.org | ebad765 | 2013-12-05 14:29:02 +0000 | [diff] [blame] | 1570 | |
kjellander@webrtc.org | 14665ff | 2015-03-04 12:58:35 +0000 | [diff] [blame] | 1571 | void DataCountersUpdated(const StreamDataCounters& counters, |
| 1572 | uint32_t ssrc) override { |
sprang@webrtc.org | ebad765 | 2013-12-05 14:29:02 +0000 | [diff] [blame] | 1573 | ssrc_ = ssrc; |
| 1574 | counters_ = counters; |
| 1575 | } |
| 1576 | |
| 1577 | uint32_t ssrc_; |
| 1578 | StreamDataCounters counters_; |
asapersson@webrtc.org | 4414939 | 2015-02-04 08:34:47 +0000 | [diff] [blame] | 1579 | |
| 1580 | void MatchPacketCounter(const RtpPacketCounter& expected, |
| 1581 | const RtpPacketCounter& actual) { |
| 1582 | EXPECT_EQ(expected.payload_bytes, actual.payload_bytes); |
| 1583 | EXPECT_EQ(expected.header_bytes, actual.header_bytes); |
| 1584 | EXPECT_EQ(expected.padding_bytes, actual.padding_bytes); |
| 1585 | EXPECT_EQ(expected.packets, actual.packets); |
| 1586 | } |
| 1587 | |
asapersson@webrtc.org | 97d0489 | 2014-12-09 09:47:53 +0000 | [diff] [blame] | 1588 | void Matches(uint32_t ssrc, const StreamDataCounters& counters) { |
| 1589 | EXPECT_EQ(ssrc, ssrc_); |
asapersson@webrtc.org | 4414939 | 2015-02-04 08:34:47 +0000 | [diff] [blame] | 1590 | MatchPacketCounter(counters.transmitted, counters_.transmitted); |
| 1591 | MatchPacketCounter(counters.retransmitted, counters_.retransmitted); |
asapersson@webrtc.org | cfd82df | 2015-01-22 09:39:59 +0000 | [diff] [blame] | 1592 | EXPECT_EQ(counters.fec.packets, counters_.fec.packets); |
sprang@webrtc.org | ebad765 | 2013-12-05 14:29:02 +0000 | [diff] [blame] | 1593 | } |
sprang@webrtc.org | ebad765 | 2013-12-05 14:29:02 +0000 | [diff] [blame] | 1594 | } callback; |
| 1595 | |
| 1596 | const uint8_t kRedPayloadType = 96; |
| 1597 | const uint8_t kUlpfecPayloadType = 97; |
sprang@webrtc.org | ebad765 | 2013-12-05 14:29:02 +0000 | [diff] [blame] | 1598 | char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC"; |
| 1599 | const uint8_t payload_type = 127; |
| 1600 | ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 90000, |
| 1601 | 0, 1500)); |
| 1602 | uint8_t payload[] = {47, 11, 32, 93, 89}; |
| 1603 | rtp_sender_->SetStorePacketsStatus(true, 1); |
| 1604 | uint32_t ssrc = rtp_sender_->SSRC(); |
| 1605 | |
| 1606 | rtp_sender_->RegisterRtpStatisticsCallback(&callback); |
| 1607 | |
| 1608 | // Send a frame. |
Sami Kalliomäki | 426a80c | 2018-08-08 11:37:59 +0200 | [diff] [blame] | 1609 | RTPVideoHeader video_header; |
Sergey Ulanov | 525df3f | 2016-08-02 17:46:41 -0700 | [diff] [blame] | 1610 | ASSERT_TRUE(rtp_sender_->SendOutgoingData( |
sprang | a8ae6f2 | 2017-09-04 07:23:56 -0700 | [diff] [blame] | 1611 | kVideoFrameKey, payload_type, 1234, 4321, payload, sizeof(payload), |
Sami Kalliomäki | 426a80c | 2018-08-08 11:37:59 +0200 | [diff] [blame] | 1612 | nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs)); |
asapersson@webrtc.org | 97d0489 | 2014-12-09 09:47:53 +0000 | [diff] [blame] | 1613 | StreamDataCounters expected; |
asapersson@webrtc.org | cfd82df | 2015-01-22 09:39:59 +0000 | [diff] [blame] | 1614 | expected.transmitted.payload_bytes = 6; |
| 1615 | expected.transmitted.header_bytes = 12; |
| 1616 | expected.transmitted.padding_bytes = 0; |
| 1617 | expected.transmitted.packets = 1; |
| 1618 | expected.retransmitted.payload_bytes = 0; |
| 1619 | expected.retransmitted.header_bytes = 0; |
| 1620 | expected.retransmitted.padding_bytes = 0; |
| 1621 | expected.retransmitted.packets = 0; |
| 1622 | expected.fec.packets = 0; |
asapersson@webrtc.org | 97d0489 | 2014-12-09 09:47:53 +0000 | [diff] [blame] | 1623 | callback.Matches(ssrc, expected); |
sprang@webrtc.org | ebad765 | 2013-12-05 14:29:02 +0000 | [diff] [blame] | 1624 | |
| 1625 | // Retransmit a frame. |
| 1626 | uint16_t seqno = rtp_sender_->SequenceNumber() - 1; |
Erik Språng | a12b1d6 | 2018-03-14 12:39:24 +0100 | [diff] [blame] | 1627 | rtp_sender_->ReSendPacket(seqno); |
asapersson@webrtc.org | cfd82df | 2015-01-22 09:39:59 +0000 | [diff] [blame] | 1628 | expected.transmitted.payload_bytes = 12; |
| 1629 | expected.transmitted.header_bytes = 24; |
| 1630 | expected.transmitted.packets = 2; |
| 1631 | expected.retransmitted.payload_bytes = 6; |
| 1632 | expected.retransmitted.header_bytes = 12; |
| 1633 | expected.retransmitted.padding_bytes = 0; |
| 1634 | expected.retransmitted.packets = 1; |
asapersson@webrtc.org | 97d0489 | 2014-12-09 09:47:53 +0000 | [diff] [blame] | 1635 | callback.Matches(ssrc, expected); |
sprang@webrtc.org | ebad765 | 2013-12-05 14:29:02 +0000 | [diff] [blame] | 1636 | |
| 1637 | // Send padding. |
philipel | 8aadd50 | 2017-02-23 02:56:13 -0800 | [diff] [blame] | 1638 | rtp_sender_->TimeToSendPadding(kMaxPaddingSize, PacedPacketInfo()); |
asapersson@webrtc.org | cfd82df | 2015-01-22 09:39:59 +0000 | [diff] [blame] | 1639 | expected.transmitted.payload_bytes = 12; |
| 1640 | expected.transmitted.header_bytes = 36; |
| 1641 | expected.transmitted.padding_bytes = kMaxPaddingSize; |
| 1642 | expected.transmitted.packets = 3; |
asapersson@webrtc.org | 97d0489 | 2014-12-09 09:47:53 +0000 | [diff] [blame] | 1643 | callback.Matches(ssrc, expected); |
sprang@webrtc.org | ebad765 | 2013-12-05 14:29:02 +0000 | [diff] [blame] | 1644 | |
brandtr | f1bb476 | 2016-11-07 03:05:06 -0800 | [diff] [blame] | 1645 | // Send ULPFEC. |
| 1646 | rtp_sender_->SetUlpfecConfig(kRedPayloadType, kUlpfecPayloadType); |
sprang@webrtc.org | ebad765 | 2013-12-05 14:29:02 +0000 | [diff] [blame] | 1647 | FecProtectionParams fec_params; |
| 1648 | fec_params.fec_mask_type = kFecMaskRandom; |
| 1649 | fec_params.fec_rate = 1; |
| 1650 | fec_params.max_fec_frames = 1; |
brandtr | 1743a19 | 2016-11-07 03:36:05 -0800 | [diff] [blame] | 1651 | rtp_sender_->SetFecParameters(fec_params, fec_params); |
Sergey Ulanov | 525df3f | 2016-08-02 17:46:41 -0700 | [diff] [blame] | 1652 | ASSERT_TRUE(rtp_sender_->SendOutgoingData( |
sprang | a8ae6f2 | 2017-09-04 07:23:56 -0700 | [diff] [blame] | 1653 | kVideoFrameDelta, payload_type, 1234, 4321, payload, sizeof(payload), |
Sami Kalliomäki | 426a80c | 2018-08-08 11:37:59 +0200 | [diff] [blame] | 1654 | nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs)); |
asapersson@webrtc.org | cfd82df | 2015-01-22 09:39:59 +0000 | [diff] [blame] | 1655 | expected.transmitted.payload_bytes = 40; |
| 1656 | expected.transmitted.header_bytes = 60; |
| 1657 | expected.transmitted.packets = 5; |
| 1658 | expected.fec.packets = 1; |
asapersson@webrtc.org | 97d0489 | 2014-12-09 09:47:53 +0000 | [diff] [blame] | 1659 | callback.Matches(ssrc, expected); |
sprang@webrtc.org | ebad765 | 2013-12-05 14:29:02 +0000 | [diff] [blame] | 1660 | |
sprang | 867fb52 | 2015-08-03 04:38:41 -0700 | [diff] [blame] | 1661 | rtp_sender_->RegisterRtpStatisticsCallback(nullptr); |
sprang@webrtc.org | ebad765 | 2013-12-05 14:29:02 +0000 | [diff] [blame] | 1662 | } |
| 1663 | |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 1664 | TEST_P(RtpSenderAudioTest, SendAudio) { |
solenberg@webrtc.org | c0352d5 | 2013-05-20 20:55:07 +0000 | [diff] [blame] | 1665 | char payload_name[RTP_PAYLOAD_NAME_SIZE] = "PAYLOAD_NAME"; |
| 1666 | const uint8_t payload_type = 127; |
| 1667 | ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 48000, |
| 1668 | 0, 1500)); |
| 1669 | uint8_t payload[] = {47, 11, 32, 93, 89}; |
| 1670 | |
Sami Kalliomäki | 426a80c | 2018-08-08 11:37:59 +0200 | [diff] [blame] | 1671 | RTPVideoHeader video_header; |
Sergey Ulanov | 525df3f | 2016-08-02 17:46:41 -0700 | [diff] [blame] | 1672 | ASSERT_TRUE(rtp_sender_->SendOutgoingData( |
sprang | a8ae6f2 | 2017-09-04 07:23:56 -0700 | [diff] [blame] | 1673 | kAudioFrameCN, payload_type, 1234, 4321, payload, sizeof(payload), |
Sami Kalliomäki | 426a80c | 2018-08-08 11:37:59 +0200 | [diff] [blame] | 1674 | nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs)); |
solenberg@webrtc.org | c0352d5 | 2013-05-20 20:55:07 +0000 | [diff] [blame] | 1675 | |
danilchap | 96c1587 | 2016-11-21 01:35:29 -0800 | [diff] [blame] | 1676 | auto sent_payload = transport_.last_sent_packet().payload(); |
| 1677 | EXPECT_THAT(sent_payload, ElementsAreArray(payload)); |
solenberg@webrtc.org | c0352d5 | 2013-05-20 20:55:07 +0000 | [diff] [blame] | 1678 | } |
| 1679 | |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 1680 | TEST_P(RtpSenderAudioTest, SendAudioWithAudioLevelExtension) { |
solenberg@webrtc.org | c0352d5 | 2013-05-20 20:55:07 +0000 | [diff] [blame] | 1681 | EXPECT_EQ(0, rtp_sender_->SetAudioLevel(kAudioLevel)); |
danilchap | 162abd3 | 2015-12-10 02:39:40 -0800 | [diff] [blame] | 1682 | EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAudioLevel, |
| 1683 | kAudioLevelExtensionId)); |
solenberg@webrtc.org | c0352d5 | 2013-05-20 20:55:07 +0000 | [diff] [blame] | 1684 | |
| 1685 | char payload_name[RTP_PAYLOAD_NAME_SIZE] = "PAYLOAD_NAME"; |
| 1686 | const uint8_t payload_type = 127; |
| 1687 | ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 48000, |
| 1688 | 0, 1500)); |
| 1689 | uint8_t payload[] = {47, 11, 32, 93, 89}; |
| 1690 | |
Sami Kalliomäki | 426a80c | 2018-08-08 11:37:59 +0200 | [diff] [blame] | 1691 | RTPVideoHeader video_header; |
Sergey Ulanov | 525df3f | 2016-08-02 17:46:41 -0700 | [diff] [blame] | 1692 | ASSERT_TRUE(rtp_sender_->SendOutgoingData( |
sprang | a8ae6f2 | 2017-09-04 07:23:56 -0700 | [diff] [blame] | 1693 | kAudioFrameCN, payload_type, 1234, 4321, payload, sizeof(payload), |
Sami Kalliomäki | 426a80c | 2018-08-08 11:37:59 +0200 | [diff] [blame] | 1694 | nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs)); |
solenberg@webrtc.org | c0352d5 | 2013-05-20 20:55:07 +0000 | [diff] [blame] | 1695 | |
danilchap | 96c1587 | 2016-11-21 01:35:29 -0800 | [diff] [blame] | 1696 | auto sent_payload = transport_.last_sent_packet().payload(); |
| 1697 | EXPECT_THAT(sent_payload, ElementsAreArray(payload)); |
danilchap | 12ba186 | 2016-10-26 02:41:55 -0700 | [diff] [blame] | 1698 | // Verify AudioLevel extension. |
| 1699 | bool voice_activity; |
| 1700 | uint8_t audio_level; |
| 1701 | EXPECT_TRUE(transport_.last_sent_packet().GetExtension<AudioLevel>( |
| 1702 | &voice_activity, &audio_level)); |
| 1703 | EXPECT_EQ(kAudioLevel, audio_level); |
| 1704 | EXPECT_FALSE(voice_activity); |
solenberg@webrtc.org | c0352d5 | 2013-05-20 20:55:07 +0000 | [diff] [blame] | 1705 | } |
| 1706 | |
stefan@webrtc.org | 0a214ff | 2014-09-03 11:46:54 +0000 | [diff] [blame] | 1707 | // As RFC4733, named telephone events are carried as part of the audio stream |
| 1708 | // and must use the same sequence number and timestamp base as the regular |
| 1709 | // audio channel. |
| 1710 | // This test checks the marker bit for the first packet and the consequent |
| 1711 | // packets of the same telephone event. Since it is specifically for DTMF |
pbos | 22993e1 | 2015-10-19 02:39:06 -0700 | [diff] [blame] | 1712 | // events, ignoring audio packets and sending kEmptyFrame instead of those. |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 1713 | TEST_P(RtpSenderAudioTest, CheckMarkerBitForTelephoneEvents) { |
solenberg | ffbbcac | 2016-11-17 05:25:37 -0800 | [diff] [blame] | 1714 | const char* kDtmfPayloadName = "telephone-event"; |
| 1715 | const uint32_t kPayloadFrequency = 8000; |
| 1716 | const uint8_t kPayloadType = 126; |
| 1717 | ASSERT_EQ(0, rtp_sender_->RegisterPayload(kDtmfPayloadName, kPayloadType, |
| 1718 | kPayloadFrequency, 0, 0)); |
stefan@webrtc.org | 0a214ff | 2014-09-03 11:46:54 +0000 | [diff] [blame] | 1719 | // For Telephone events, payload is not added to the registered payload list, |
| 1720 | // it will register only the payload used for audio stream. |
| 1721 | // Registering the payload again for audio stream with different payload name. |
solenberg | ffbbcac | 2016-11-17 05:25:37 -0800 | [diff] [blame] | 1722 | const char* kPayloadName = "payload_name"; |
| 1723 | ASSERT_EQ(0, rtp_sender_->RegisterPayload(kPayloadName, kPayloadType, |
| 1724 | kPayloadFrequency, 1, 0)); |
stefan@webrtc.org | 0a214ff | 2014-09-03 11:46:54 +0000 | [diff] [blame] | 1725 | int64_t capture_time_ms = fake_clock_.TimeInMilliseconds(); |
| 1726 | // DTMF event key=9, duration=500 and attenuationdB=10 |
| 1727 | rtp_sender_->SendTelephoneEvent(9, 500, 10); |
| 1728 | // During start, it takes the starting timestamp as last sent timestamp. |
| 1729 | // The duration is calculated as the difference of current and last sent |
| 1730 | // timestamp. So for first call it will skip since the duration is zero. |
Sami Kalliomäki | 426a80c | 2018-08-08 11:37:59 +0200 | [diff] [blame] | 1731 | RTPVideoHeader video_header; |
sprang | a8ae6f2 | 2017-09-04 07:23:56 -0700 | [diff] [blame] | 1732 | ASSERT_TRUE(rtp_sender_->SendOutgoingData( |
| 1733 | kEmptyFrame, kPayloadType, capture_time_ms, 0, nullptr, 0, nullptr, |
Sami Kalliomäki | 426a80c | 2018-08-08 11:37:59 +0200 | [diff] [blame] | 1734 | &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs)); |
stefan@webrtc.org | 0a214ff | 2014-09-03 11:46:54 +0000 | [diff] [blame] | 1735 | // DTMF Sample Length is (Frequency/1000) * Duration. |
| 1736 | // So in this case, it is (8000/1000) * 500 = 4000. |
| 1737 | // Sending it as two packets. |
Sergey Ulanov | 525df3f | 2016-08-02 17:46:41 -0700 | [diff] [blame] | 1738 | ASSERT_TRUE(rtp_sender_->SendOutgoingData( |
sprang | a8ae6f2 | 2017-09-04 07:23:56 -0700 | [diff] [blame] | 1739 | kEmptyFrame, kPayloadType, capture_time_ms + 2000, 0, nullptr, 0, nullptr, |
Sami Kalliomäki | 426a80c | 2018-08-08 11:37:59 +0200 | [diff] [blame] | 1740 | &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs)); |
danilchap | 12ba186 | 2016-10-26 02:41:55 -0700 | [diff] [blame] | 1741 | |
stefan@webrtc.org | 0a214ff | 2014-09-03 11:46:54 +0000 | [diff] [blame] | 1742 | // Marker Bit should be set to 1 for first packet. |
danilchap | 12ba186 | 2016-10-26 02:41:55 -0700 | [diff] [blame] | 1743 | EXPECT_TRUE(transport_.last_sent_packet().Marker()); |
stefan@webrtc.org | 0a214ff | 2014-09-03 11:46:54 +0000 | [diff] [blame] | 1744 | |
Sergey Ulanov | 525df3f | 2016-08-02 17:46:41 -0700 | [diff] [blame] | 1745 | ASSERT_TRUE(rtp_sender_->SendOutgoingData( |
sprang | a8ae6f2 | 2017-09-04 07:23:56 -0700 | [diff] [blame] | 1746 | kEmptyFrame, kPayloadType, capture_time_ms + 4000, 0, nullptr, 0, nullptr, |
Sami Kalliomäki | 426a80c | 2018-08-08 11:37:59 +0200 | [diff] [blame] | 1747 | &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs)); |
stefan@webrtc.org | 0a214ff | 2014-09-03 11:46:54 +0000 | [diff] [blame] | 1748 | // Marker Bit should be set to 0 for rest of the packets. |
danilchap | 12ba186 | 2016-10-26 02:41:55 -0700 | [diff] [blame] | 1749 | EXPECT_FALSE(transport_.last_sent_packet().Marker()); |
stefan@webrtc.org | 0a214ff | 2014-09-03 11:46:54 +0000 | [diff] [blame] | 1750 | } |
| 1751 | |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 1752 | TEST_P(RtpSenderTestWithoutPacer, BytesReportedCorrectly) { |
pbos@webrtc.org | 72491b9 | 2014-07-10 16:24:54 +0000 | [diff] [blame] | 1753 | const char* kPayloadName = "GENERIC"; |
| 1754 | const uint8_t kPayloadType = 127; |
| 1755 | rtp_sender_->SetSSRC(1234); |
| 1756 | rtp_sender_->SetRtxSsrc(4321); |
Shao Changbin | e62202f | 2015-04-21 20:24:50 +0800 | [diff] [blame] | 1757 | rtp_sender_->SetRtxPayloadType(kPayloadType - 1, kPayloadType); |
pbos@webrtc.org | 0b0c241 | 2015-01-13 14:15:15 +0000 | [diff] [blame] | 1758 | rtp_sender_->SetRtxStatus(kRtxRetransmitted | kRtxRedundantPayloads); |
pbos@webrtc.org | 72491b9 | 2014-07-10 16:24:54 +0000 | [diff] [blame] | 1759 | |
danilchap | 162abd3 | 2015-12-10 02:39:40 -0800 | [diff] [blame] | 1760 | ASSERT_EQ(0, rtp_sender_->RegisterPayload(kPayloadName, kPayloadType, 90000, |
| 1761 | 0, 1500)); |
pbos@webrtc.org | 72491b9 | 2014-07-10 16:24:54 +0000 | [diff] [blame] | 1762 | uint8_t payload[] = {47, 11, 32, 93, 89}; |
| 1763 | |
Sami Kalliomäki | 426a80c | 2018-08-08 11:37:59 +0200 | [diff] [blame] | 1764 | RTPVideoHeader video_header; |
Sergey Ulanov | 525df3f | 2016-08-02 17:46:41 -0700 | [diff] [blame] | 1765 | ASSERT_TRUE(rtp_sender_->SendOutgoingData( |
sprang | a8ae6f2 | 2017-09-04 07:23:56 -0700 | [diff] [blame] | 1766 | kVideoFrameKey, kPayloadType, 1234, 4321, payload, sizeof(payload), |
Sami Kalliomäki | 426a80c | 2018-08-08 11:37:59 +0200 | [diff] [blame] | 1767 | nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs)); |
pbos@webrtc.org | 72491b9 | 2014-07-10 16:24:54 +0000 | [diff] [blame] | 1768 | |
pbos@webrtc.org | 2f4b14e | 2014-07-15 15:25:39 +0000 | [diff] [blame] | 1769 | // Will send 2 full-size padding packets. |
philipel | 8aadd50 | 2017-02-23 02:56:13 -0800 | [diff] [blame] | 1770 | rtp_sender_->TimeToSendPadding(1, PacedPacketInfo()); |
| 1771 | rtp_sender_->TimeToSendPadding(1, PacedPacketInfo()); |
pbos@webrtc.org | 72491b9 | 2014-07-10 16:24:54 +0000 | [diff] [blame] | 1772 | |
pbos@webrtc.org | 2f4b14e | 2014-07-15 15:25:39 +0000 | [diff] [blame] | 1773 | StreamDataCounters rtp_stats; |
| 1774 | StreamDataCounters rtx_stats; |
| 1775 | rtp_sender_->GetDataCounters(&rtp_stats, &rtx_stats); |
pbos@webrtc.org | 72491b9 | 2014-07-10 16:24:54 +0000 | [diff] [blame] | 1776 | |
pbos@webrtc.org | 2f4b14e | 2014-07-15 15:25:39 +0000 | [diff] [blame] | 1777 | // Payload + 1-byte generic header. |
asapersson@webrtc.org | d08d389 | 2014-12-16 12:03:11 +0000 | [diff] [blame] | 1778 | EXPECT_GT(rtp_stats.first_packet_time_ms, -1); |
asapersson@webrtc.org | cfd82df | 2015-01-22 09:39:59 +0000 | [diff] [blame] | 1779 | EXPECT_EQ(rtp_stats.transmitted.payload_bytes, sizeof(payload) + 1); |
| 1780 | EXPECT_EQ(rtp_stats.transmitted.header_bytes, 12u); |
| 1781 | EXPECT_EQ(rtp_stats.transmitted.padding_bytes, 0u); |
| 1782 | EXPECT_EQ(rtx_stats.transmitted.payload_bytes, 0u); |
| 1783 | EXPECT_EQ(rtx_stats.transmitted.header_bytes, 24u); |
| 1784 | EXPECT_EQ(rtx_stats.transmitted.padding_bytes, 2 * kMaxPaddingSize); |
pbos@webrtc.org | 2f4b14e | 2014-07-15 15:25:39 +0000 | [diff] [blame] | 1785 | |
asapersson@webrtc.org | cfd82df | 2015-01-22 09:39:59 +0000 | [diff] [blame] | 1786 | EXPECT_EQ(rtp_stats.transmitted.TotalBytes(), |
danilchap | 162abd3 | 2015-12-10 02:39:40 -0800 | [diff] [blame] | 1787 | rtp_stats.transmitted.payload_bytes + |
| 1788 | rtp_stats.transmitted.header_bytes + |
| 1789 | rtp_stats.transmitted.padding_bytes); |
asapersson@webrtc.org | cfd82df | 2015-01-22 09:39:59 +0000 | [diff] [blame] | 1790 | EXPECT_EQ(rtx_stats.transmitted.TotalBytes(), |
danilchap | 162abd3 | 2015-12-10 02:39:40 -0800 | [diff] [blame] | 1791 | rtx_stats.transmitted.payload_bytes + |
| 1792 | rtx_stats.transmitted.header_bytes + |
| 1793 | rtx_stats.transmitted.padding_bytes); |
asapersson@webrtc.org | 97d0489 | 2014-12-09 09:47:53 +0000 | [diff] [blame] | 1794 | |
danilchap | 162abd3 | 2015-12-10 02:39:40 -0800 | [diff] [blame] | 1795 | EXPECT_EQ( |
| 1796 | transport_.total_bytes_sent_, |
| 1797 | rtp_stats.transmitted.TotalBytes() + rtx_stats.transmitted.TotalBytes()); |
pbos@webrtc.org | 72491b9 | 2014-07-10 16:24:54 +0000 | [diff] [blame] | 1798 | } |
guoweis@webrtc.org | 4536289 | 2015-03-04 22:55:15 +0000 | [diff] [blame] | 1799 | |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 1800 | TEST_P(RtpSenderTestWithoutPacer, RespectsNackBitrateLimit) { |
sprang | 38778b0 | 2015-09-29 09:48:22 -0700 | [diff] [blame] | 1801 | const int32_t kPacketSize = 1400; |
| 1802 | const int32_t kNumPackets = 30; |
| 1803 | |
sprang | cd349d9 | 2016-07-13 09:11:28 -0700 | [diff] [blame] | 1804 | retransmission_rate_limiter_.SetMaxRate(kPacketSize * kNumPackets * 8); |
| 1805 | |
sprang | 38778b0 | 2015-09-29 09:48:22 -0700 | [diff] [blame] | 1806 | rtp_sender_->SetStorePacketsStatus(true, kNumPackets); |
sprang | 38778b0 | 2015-09-29 09:48:22 -0700 | [diff] [blame] | 1807 | const uint16_t kStartSequenceNumber = rtp_sender_->SequenceNumber(); |
Danil Chapovalov | 2800d74 | 2016-08-26 18:48:46 +0200 | [diff] [blame] | 1808 | std::vector<uint16_t> sequence_numbers; |
sprang | 38778b0 | 2015-09-29 09:48:22 -0700 | [diff] [blame] | 1809 | for (int32_t i = 0; i < kNumPackets; ++i) { |
| 1810 | sequence_numbers.push_back(kStartSequenceNumber + i); |
| 1811 | fake_clock_.AdvanceTimeMilliseconds(1); |
| 1812 | SendPacket(fake_clock_.TimeInMilliseconds(), kPacketSize); |
| 1813 | } |
danilchap | 12ba186 | 2016-10-26 02:41:55 -0700 | [diff] [blame] | 1814 | EXPECT_EQ(kNumPackets, transport_.packets_sent()); |
sprang | 38778b0 | 2015-09-29 09:48:22 -0700 | [diff] [blame] | 1815 | |
| 1816 | fake_clock_.AdvanceTimeMilliseconds(1000 - kNumPackets); |
| 1817 | |
| 1818 | // Resending should work - brings the bandwidth up to the limit. |
| 1819 | // NACK bitrate is capped to the same bitrate as the encoder, since the max |
| 1820 | // protection overhead is 50% (see MediaOptimization::SetTargetRates). |
Danil Chapovalov | 2800d74 | 2016-08-26 18:48:46 +0200 | [diff] [blame] | 1821 | rtp_sender_->OnReceivedNack(sequence_numbers, 0); |
danilchap | 12ba186 | 2016-10-26 02:41:55 -0700 | [diff] [blame] | 1822 | EXPECT_EQ(kNumPackets * 2, transport_.packets_sent()); |
sprang | 38778b0 | 2015-09-29 09:48:22 -0700 | [diff] [blame] | 1823 | |
sprang | cd349d9 | 2016-07-13 09:11:28 -0700 | [diff] [blame] | 1824 | // Must be at least 5ms in between retransmission attempts. |
| 1825 | fake_clock_.AdvanceTimeMilliseconds(5); |
| 1826 | |
sprang | 38778b0 | 2015-09-29 09:48:22 -0700 | [diff] [blame] | 1827 | // Resending should not work, bandwidth exceeded. |
Danil Chapovalov | 2800d74 | 2016-08-26 18:48:46 +0200 | [diff] [blame] | 1828 | rtp_sender_->OnReceivedNack(sequence_numbers, 0); |
danilchap | 12ba186 | 2016-10-26 02:41:55 -0700 | [diff] [blame] | 1829 | EXPECT_EQ(kNumPackets * 2, transport_.packets_sent()); |
sprang | 38778b0 | 2015-09-29 09:48:22 -0700 | [diff] [blame] | 1830 | } |
| 1831 | |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 1832 | TEST_P(RtpSenderVideoTest, KeyFrameHasCVO) { |
danilchap | b6f1fb5 | 2016-10-19 06:11:39 -0700 | [diff] [blame] | 1833 | uint8_t kFrame[kMaxPacketLength]; |
guoweis@webrtc.org | 4536289 | 2015-03-04 22:55:15 +0000 | [diff] [blame] | 1834 | EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension( |
| 1835 | kRtpExtensionVideoRotation, kVideoRotationExtensionId)); |
guoweis@webrtc.org | 4536289 | 2015-03-04 22:55:15 +0000 | [diff] [blame] | 1836 | |
philipel | 1a4746a | 2018-07-09 15:52:29 +0200 | [diff] [blame] | 1837 | RTPVideoHeader hdr; |
danilchap | c1600c5 | 2016-10-26 03:33:11 -0700 | [diff] [blame] | 1838 | hdr.rotation = kVideoRotation_0; |
Niels Möller | 520ca4e | 2018-06-04 11:14:38 +0200 | [diff] [blame] | 1839 | rtp_sender_video_->SendVideo(kVideoCodecGeneric, kVideoFrameKey, kPayload, |
danilchap | b6f1fb5 | 2016-10-19 06:11:39 -0700 | [diff] [blame] | 1840 | kTimestamp, 0, kFrame, sizeof(kFrame), nullptr, |
sprang | a8ae6f2 | 2017-09-04 07:23:56 -0700 | [diff] [blame] | 1841 | &hdr, kDefaultExpectedRetransmissionTimeMs); |
guoweis@webrtc.org | 4536289 | 2015-03-04 22:55:15 +0000 | [diff] [blame] | 1842 | |
danilchap | c1600c5 | 2016-10-26 03:33:11 -0700 | [diff] [blame] | 1843 | VideoRotation rotation; |
| 1844 | EXPECT_TRUE( |
| 1845 | transport_.last_sent_packet().GetExtension<VideoOrientation>(&rotation)); |
| 1846 | EXPECT_EQ(kVideoRotation_0, rotation); |
| 1847 | } |
guoweis@webrtc.org | 4536289 | 2015-03-04 22:55:15 +0000 | [diff] [blame] | 1848 | |
ilnik | 04f4d12 | 2017-06-19 07:18:55 -0700 | [diff] [blame] | 1849 | TEST_P(RtpSenderVideoTest, TimingFrameHasPacketizationTimstampSet) { |
| 1850 | uint8_t kFrame[kMaxPacketLength]; |
| 1851 | const int64_t kPacketizationTimeMs = 100; |
| 1852 | const int64_t kEncodeStartDeltaMs = 10; |
| 1853 | const int64_t kEncodeFinishDeltaMs = 50; |
| 1854 | EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension( |
| 1855 | kRtpExtensionVideoTiming, kVideoTimingExtensionId)); |
| 1856 | |
| 1857 | const int64_t kCaptureTimestamp = fake_clock_.TimeInMilliseconds(); |
| 1858 | |
philipel | 1a4746a | 2018-07-09 15:52:29 +0200 | [diff] [blame] | 1859 | RTPVideoHeader hdr; |
Ilya Nikolaevskiy | b6c462d | 2018-06-05 15:21:32 +0200 | [diff] [blame] | 1860 | hdr.video_timing.flags = VideoSendTiming::kTriggeredByTimer; |
ilnik | 04f4d12 | 2017-06-19 07:18:55 -0700 | [diff] [blame] | 1861 | hdr.video_timing.encode_start_delta_ms = kEncodeStartDeltaMs; |
| 1862 | hdr.video_timing.encode_finish_delta_ms = kEncodeFinishDeltaMs; |
| 1863 | |
| 1864 | fake_clock_.AdvanceTimeMilliseconds(kPacketizationTimeMs); |
Niels Möller | 520ca4e | 2018-06-04 11:14:38 +0200 | [diff] [blame] | 1865 | rtp_sender_video_->SendVideo(kVideoCodecGeneric, kVideoFrameKey, kPayload, |
ilnik | 04f4d12 | 2017-06-19 07:18:55 -0700 | [diff] [blame] | 1866 | kTimestamp, kCaptureTimestamp, kFrame, |
sprang | a8ae6f2 | 2017-09-04 07:23:56 -0700 | [diff] [blame] | 1867 | sizeof(kFrame), nullptr, &hdr, |
| 1868 | kDefaultExpectedRetransmissionTimeMs); |
ilnik | 2edc684 | 2017-07-06 03:06:50 -0700 | [diff] [blame] | 1869 | VideoSendTiming timing; |
ilnik | 04f4d12 | 2017-06-19 07:18:55 -0700 | [diff] [blame] | 1870 | EXPECT_TRUE(transport_.last_sent_packet().GetExtension<VideoTimingExtension>( |
| 1871 | &timing)); |
| 1872 | EXPECT_EQ(kPacketizationTimeMs, timing.packetization_finish_delta_ms); |
| 1873 | EXPECT_EQ(kEncodeStartDeltaMs, timing.encode_start_delta_ms); |
| 1874 | EXPECT_EQ(kEncodeFinishDeltaMs, timing.encode_finish_delta_ms); |
| 1875 | } |
| 1876 | |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 1877 | TEST_P(RtpSenderVideoTest, DeltaFrameHasCVOWhenChanged) { |
danilchap | c1600c5 | 2016-10-26 03:33:11 -0700 | [diff] [blame] | 1878 | uint8_t kFrame[kMaxPacketLength]; |
| 1879 | EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension( |
| 1880 | kRtpExtensionVideoRotation, kVideoRotationExtensionId)); |
| 1881 | |
philipel | 1a4746a | 2018-07-09 15:52:29 +0200 | [diff] [blame] | 1882 | RTPVideoHeader hdr; |
danilchap | c1600c5 | 2016-10-26 03:33:11 -0700 | [diff] [blame] | 1883 | hdr.rotation = kVideoRotation_90; |
sprang | a8ae6f2 | 2017-09-04 07:23:56 -0700 | [diff] [blame] | 1884 | EXPECT_TRUE(rtp_sender_video_->SendVideo( |
Niels Möller | 520ca4e | 2018-06-04 11:14:38 +0200 | [diff] [blame] | 1885 | kVideoCodecGeneric, kVideoFrameKey, kPayload, kTimestamp, 0, kFrame, |
sprang | a8ae6f2 | 2017-09-04 07:23:56 -0700 | [diff] [blame] | 1886 | sizeof(kFrame), nullptr, &hdr, kDefaultExpectedRetransmissionTimeMs)); |
danilchap | c1600c5 | 2016-10-26 03:33:11 -0700 | [diff] [blame] | 1887 | |
| 1888 | hdr.rotation = kVideoRotation_0; |
sprang | a8ae6f2 | 2017-09-04 07:23:56 -0700 | [diff] [blame] | 1889 | EXPECT_TRUE(rtp_sender_video_->SendVideo( |
Niels Möller | 520ca4e | 2018-06-04 11:14:38 +0200 | [diff] [blame] | 1890 | kVideoCodecGeneric, kVideoFrameDelta, kPayload, kTimestamp + 1, 0, kFrame, |
sprang | a8ae6f2 | 2017-09-04 07:23:56 -0700 | [diff] [blame] | 1891 | sizeof(kFrame), nullptr, &hdr, kDefaultExpectedRetransmissionTimeMs)); |
danilchap | c1600c5 | 2016-10-26 03:33:11 -0700 | [diff] [blame] | 1892 | |
| 1893 | VideoRotation rotation; |
| 1894 | EXPECT_TRUE( |
| 1895 | transport_.last_sent_packet().GetExtension<VideoOrientation>(&rotation)); |
| 1896 | EXPECT_EQ(kVideoRotation_0, rotation); |
| 1897 | } |
| 1898 | |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 1899 | TEST_P(RtpSenderVideoTest, DeltaFrameHasCVOWhenNonZero) { |
danilchap | c1600c5 | 2016-10-26 03:33:11 -0700 | [diff] [blame] | 1900 | uint8_t kFrame[kMaxPacketLength]; |
| 1901 | EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension( |
| 1902 | kRtpExtensionVideoRotation, kVideoRotationExtensionId)); |
| 1903 | |
philipel | 1a4746a | 2018-07-09 15:52:29 +0200 | [diff] [blame] | 1904 | RTPVideoHeader hdr; |
danilchap | c1600c5 | 2016-10-26 03:33:11 -0700 | [diff] [blame] | 1905 | hdr.rotation = kVideoRotation_90; |
sprang | a8ae6f2 | 2017-09-04 07:23:56 -0700 | [diff] [blame] | 1906 | EXPECT_TRUE(rtp_sender_video_->SendVideo( |
Niels Möller | 520ca4e | 2018-06-04 11:14:38 +0200 | [diff] [blame] | 1907 | kVideoCodecGeneric, kVideoFrameKey, kPayload, kTimestamp, 0, kFrame, |
sprang | a8ae6f2 | 2017-09-04 07:23:56 -0700 | [diff] [blame] | 1908 | sizeof(kFrame), nullptr, &hdr, kDefaultExpectedRetransmissionTimeMs)); |
danilchap | c1600c5 | 2016-10-26 03:33:11 -0700 | [diff] [blame] | 1909 | |
sprang | a8ae6f2 | 2017-09-04 07:23:56 -0700 | [diff] [blame] | 1910 | EXPECT_TRUE(rtp_sender_video_->SendVideo( |
Niels Möller | 520ca4e | 2018-06-04 11:14:38 +0200 | [diff] [blame] | 1911 | kVideoCodecGeneric, kVideoFrameDelta, kPayload, kTimestamp + 1, 0, kFrame, |
sprang | a8ae6f2 | 2017-09-04 07:23:56 -0700 | [diff] [blame] | 1912 | sizeof(kFrame), nullptr, &hdr, kDefaultExpectedRetransmissionTimeMs)); |
danilchap | c1600c5 | 2016-10-26 03:33:11 -0700 | [diff] [blame] | 1913 | |
| 1914 | VideoRotation rotation; |
| 1915 | EXPECT_TRUE( |
| 1916 | transport_.last_sent_packet().GetExtension<VideoOrientation>(&rotation)); |
| 1917 | EXPECT_EQ(kVideoRotation_90, rotation); |
guoweis@webrtc.org | 4536289 | 2015-03-04 22:55:15 +0000 | [diff] [blame] | 1918 | } |
magjed | 71eb61c | 2016-09-08 03:24:58 -0700 | [diff] [blame] | 1919 | |
| 1920 | // Make sure rotation is parsed correctly when the Camera (C) and Flip (F) bits |
| 1921 | // are set in the CVO byte. |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 1922 | TEST_P(RtpSenderVideoTest, SendVideoWithCameraAndFlipCVO) { |
magjed | 71eb61c | 2016-09-08 03:24:58 -0700 | [diff] [blame] | 1923 | // Test extracting rotation when Camera (C) and Flip (F) bits are zero. |
| 1924 | EXPECT_EQ(kVideoRotation_0, ConvertCVOByteToVideoRotation(0)); |
| 1925 | EXPECT_EQ(kVideoRotation_90, ConvertCVOByteToVideoRotation(1)); |
| 1926 | EXPECT_EQ(kVideoRotation_180, ConvertCVOByteToVideoRotation(2)); |
| 1927 | EXPECT_EQ(kVideoRotation_270, ConvertCVOByteToVideoRotation(3)); |
| 1928 | // Test extracting rotation when Camera (C) and Flip (F) bits are set. |
| 1929 | const int flip_bit = 1 << 2; |
| 1930 | const int camera_bit = 1 << 3; |
| 1931 | EXPECT_EQ(kVideoRotation_0, |
| 1932 | ConvertCVOByteToVideoRotation(flip_bit | camera_bit | 0)); |
| 1933 | EXPECT_EQ(kVideoRotation_90, |
| 1934 | ConvertCVOByteToVideoRotation(flip_bit | camera_bit | 1)); |
| 1935 | EXPECT_EQ(kVideoRotation_180, |
| 1936 | ConvertCVOByteToVideoRotation(flip_bit | camera_bit | 2)); |
| 1937 | EXPECT_EQ(kVideoRotation_270, |
| 1938 | ConvertCVOByteToVideoRotation(flip_bit | camera_bit | 3)); |
| 1939 | } |
| 1940 | |
sprang | a8ae6f2 | 2017-09-04 07:23:56 -0700 | [diff] [blame] | 1941 | TEST_P(RtpSenderVideoTest, RetransmissionTypesGeneric) { |
| 1942 | RTPVideoHeader header; |
Niels Möller | 520ca4e | 2018-06-04 11:14:38 +0200 | [diff] [blame] | 1943 | header.codec = kVideoCodecGeneric; |
sprang | a8ae6f2 | 2017-09-04 07:23:56 -0700 | [diff] [blame] | 1944 | |
| 1945 | EXPECT_EQ(kDontRetransmit, |
| 1946 | rtp_sender_video_->GetStorageType( |
| 1947 | header, kRetransmitOff, kDefaultExpectedRetransmissionTimeMs)); |
| 1948 | EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType( |
| 1949 | header, kRetransmitBaseLayer, |
| 1950 | kDefaultExpectedRetransmissionTimeMs)); |
| 1951 | EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType( |
| 1952 | header, kRetransmitHigherLayers, |
| 1953 | kDefaultExpectedRetransmissionTimeMs)); |
| 1954 | EXPECT_EQ(kAllowRetransmission, |
| 1955 | rtp_sender_video_->GetStorageType( |
| 1956 | header, kConditionallyRetransmitHigherLayers, |
| 1957 | kDefaultExpectedRetransmissionTimeMs)); |
| 1958 | EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType( |
| 1959 | header, kRetransmitAllPackets, |
| 1960 | kDefaultExpectedRetransmissionTimeMs)); |
| 1961 | } |
| 1962 | |
| 1963 | TEST_P(RtpSenderVideoTest, RetransmissionTypesH264) { |
| 1964 | RTPVideoHeader header; |
philipel | 7d745e5 | 2018-08-02 14:03:53 +0200 | [diff] [blame] | 1965 | header.video_type_header.emplace<RTPVideoHeaderH264>().packetization_mode = |
| 1966 | H264PacketizationMode::NonInterleaved; |
Niels Möller | 520ca4e | 2018-06-04 11:14:38 +0200 | [diff] [blame] | 1967 | header.codec = kVideoCodecH264; |
sprang | a8ae6f2 | 2017-09-04 07:23:56 -0700 | [diff] [blame] | 1968 | |
| 1969 | EXPECT_EQ(kDontRetransmit, |
| 1970 | rtp_sender_video_->GetStorageType( |
| 1971 | header, kRetransmitOff, kDefaultExpectedRetransmissionTimeMs)); |
| 1972 | EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType( |
| 1973 | header, kRetransmitBaseLayer, |
| 1974 | kDefaultExpectedRetransmissionTimeMs)); |
| 1975 | EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType( |
| 1976 | header, kRetransmitHigherLayers, |
| 1977 | kDefaultExpectedRetransmissionTimeMs)); |
| 1978 | EXPECT_EQ(kAllowRetransmission, |
| 1979 | rtp_sender_video_->GetStorageType( |
| 1980 | header, kConditionallyRetransmitHigherLayers, |
| 1981 | kDefaultExpectedRetransmissionTimeMs)); |
| 1982 | EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType( |
| 1983 | header, kRetransmitAllPackets, |
| 1984 | kDefaultExpectedRetransmissionTimeMs)); |
| 1985 | } |
| 1986 | |
| 1987 | TEST_P(RtpSenderVideoTest, RetransmissionTypesVP8BaseLayer) { |
| 1988 | RTPVideoHeader header; |
Niels Möller | 520ca4e | 2018-06-04 11:14:38 +0200 | [diff] [blame] | 1989 | header.codec = kVideoCodecVP8; |
Philip Eliasson | d52a1a6 | 2018-09-07 13:03:55 +0000 | [diff] [blame] | 1990 | auto& vp8_header = header.video_type_header.emplace<RTPVideoHeaderVP8>(); |
| 1991 | vp8_header.temporalIdx = 0; |
sprang | a8ae6f2 | 2017-09-04 07:23:56 -0700 | [diff] [blame] | 1992 | |
| 1993 | EXPECT_EQ(kDontRetransmit, |
| 1994 | rtp_sender_video_->GetStorageType( |
| 1995 | header, kRetransmitOff, kDefaultExpectedRetransmissionTimeMs)); |
| 1996 | EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType( |
| 1997 | header, kRetransmitBaseLayer, |
| 1998 | kDefaultExpectedRetransmissionTimeMs)); |
| 1999 | EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType( |
| 2000 | header, kRetransmitHigherLayers, |
| 2001 | kDefaultExpectedRetransmissionTimeMs)); |
| 2002 | EXPECT_EQ(kAllowRetransmission, |
| 2003 | rtp_sender_video_->GetStorageType( |
| 2004 | header, kRetransmitHigherLayers | kRetransmitBaseLayer, |
| 2005 | kDefaultExpectedRetransmissionTimeMs)); |
| 2006 | EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType( |
| 2007 | header, kConditionallyRetransmitHigherLayers, |
| 2008 | kDefaultExpectedRetransmissionTimeMs)); |
| 2009 | EXPECT_EQ( |
| 2010 | kAllowRetransmission, |
| 2011 | rtp_sender_video_->GetStorageType( |
| 2012 | header, kRetransmitBaseLayer | kConditionallyRetransmitHigherLayers, |
| 2013 | kDefaultExpectedRetransmissionTimeMs)); |
| 2014 | EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType( |
| 2015 | header, kRetransmitAllPackets, |
| 2016 | kDefaultExpectedRetransmissionTimeMs)); |
| 2017 | } |
| 2018 | |
| 2019 | TEST_P(RtpSenderVideoTest, RetransmissionTypesVP8HigherLayers) { |
| 2020 | RTPVideoHeader header; |
Niels Möller | 520ca4e | 2018-06-04 11:14:38 +0200 | [diff] [blame] | 2021 | header.codec = kVideoCodecVP8; |
sprang | a8ae6f2 | 2017-09-04 07:23:56 -0700 | [diff] [blame] | 2022 | |
Philip Eliasson | d52a1a6 | 2018-09-07 13:03:55 +0000 | [diff] [blame] | 2023 | auto& vp8_header = header.video_type_header.emplace<RTPVideoHeaderVP8>(); |
sprang | a8ae6f2 | 2017-09-04 07:23:56 -0700 | [diff] [blame] | 2024 | for (int tid = 1; tid <= kMaxTemporalStreams; ++tid) { |
Philip Eliasson | d52a1a6 | 2018-09-07 13:03:55 +0000 | [diff] [blame] | 2025 | vp8_header.temporalIdx = tid; |
sprang | a8ae6f2 | 2017-09-04 07:23:56 -0700 | [diff] [blame] | 2026 | |
| 2027 | EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType( |
| 2028 | header, kRetransmitOff, |
| 2029 | kDefaultExpectedRetransmissionTimeMs)); |
| 2030 | EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType( |
| 2031 | header, kRetransmitBaseLayer, |
| 2032 | kDefaultExpectedRetransmissionTimeMs)); |
| 2033 | EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType( |
| 2034 | header, kRetransmitHigherLayers, |
| 2035 | kDefaultExpectedRetransmissionTimeMs)); |
| 2036 | EXPECT_EQ(kAllowRetransmission, |
| 2037 | rtp_sender_video_->GetStorageType( |
| 2038 | header, kRetransmitHigherLayers | kRetransmitBaseLayer, |
| 2039 | kDefaultExpectedRetransmissionTimeMs)); |
| 2040 | EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType( |
| 2041 | header, kRetransmitAllPackets, |
| 2042 | kDefaultExpectedRetransmissionTimeMs)); |
| 2043 | } |
| 2044 | } |
| 2045 | |
| 2046 | TEST_P(RtpSenderVideoTest, RetransmissionTypesVP9) { |
| 2047 | RTPVideoHeader header; |
Niels Möller | 520ca4e | 2018-06-04 11:14:38 +0200 | [diff] [blame] | 2048 | header.codec = kVideoCodecVP9; |
sprang | a8ae6f2 | 2017-09-04 07:23:56 -0700 | [diff] [blame] | 2049 | |
philipel | 29d8846 | 2018-08-08 14:26:00 +0200 | [diff] [blame] | 2050 | auto& vp9_header = header.video_type_header.emplace<RTPVideoHeaderVP9>(); |
sprang | a8ae6f2 | 2017-09-04 07:23:56 -0700 | [diff] [blame] | 2051 | for (int tid = 1; tid <= kMaxTemporalStreams; ++tid) { |
philipel | 29d8846 | 2018-08-08 14:26:00 +0200 | [diff] [blame] | 2052 | vp9_header.temporal_idx = tid; |
sprang | a8ae6f2 | 2017-09-04 07:23:56 -0700 | [diff] [blame] | 2053 | |
| 2054 | EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType( |
| 2055 | header, kRetransmitOff, |
| 2056 | kDefaultExpectedRetransmissionTimeMs)); |
| 2057 | EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType( |
| 2058 | header, kRetransmitBaseLayer, |
| 2059 | kDefaultExpectedRetransmissionTimeMs)); |
| 2060 | EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType( |
| 2061 | header, kRetransmitHigherLayers, |
| 2062 | kDefaultExpectedRetransmissionTimeMs)); |
| 2063 | EXPECT_EQ(kAllowRetransmission, |
| 2064 | rtp_sender_video_->GetStorageType( |
| 2065 | header, kRetransmitHigherLayers | kRetransmitBaseLayer, |
| 2066 | kDefaultExpectedRetransmissionTimeMs)); |
| 2067 | EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType( |
| 2068 | header, kRetransmitAllPackets, |
| 2069 | kDefaultExpectedRetransmissionTimeMs)); |
| 2070 | } |
| 2071 | } |
| 2072 | |
| 2073 | TEST_P(RtpSenderVideoTest, ConditionalRetransmit) { |
| 2074 | const int64_t kFrameIntervalMs = 33; |
| 2075 | const int64_t kRttMs = (kFrameIntervalMs * 3) / 2; |
| 2076 | const uint8_t kSettings = |
| 2077 | kRetransmitBaseLayer | kConditionallyRetransmitHigherLayers; |
| 2078 | |
| 2079 | // Insert VP8 frames for all temporal layers, but stop before the final index. |
| 2080 | RTPVideoHeader header; |
Niels Möller | 520ca4e | 2018-06-04 11:14:38 +0200 | [diff] [blame] | 2081 | header.codec = kVideoCodecVP8; |
sprang | a8ae6f2 | 2017-09-04 07:23:56 -0700 | [diff] [blame] | 2082 | |
| 2083 | // Fill averaging window to prevent rounding errors. |
| 2084 | constexpr int kNumRepetitions = |
| 2085 | (RTPSenderVideo::kTLRateWindowSizeMs + (kFrameIntervalMs / 2)) / |
| 2086 | kFrameIntervalMs; |
| 2087 | constexpr int kPattern[] = {0, 2, 1, 2}; |
Philip Eliasson | d52a1a6 | 2018-09-07 13:03:55 +0000 | [diff] [blame] | 2088 | auto& vp8_header = header.video_type_header.emplace<RTPVideoHeaderVP8>(); |
sprang | a8ae6f2 | 2017-09-04 07:23:56 -0700 | [diff] [blame] | 2089 | for (size_t i = 0; i < arraysize(kPattern) * kNumRepetitions; ++i) { |
Philip Eliasson | d52a1a6 | 2018-09-07 13:03:55 +0000 | [diff] [blame] | 2090 | vp8_header.temporalIdx = kPattern[i % arraysize(kPattern)]; |
sprang | a8ae6f2 | 2017-09-04 07:23:56 -0700 | [diff] [blame] | 2091 | rtp_sender_video_->GetStorageType(header, kSettings, kRttMs); |
| 2092 | fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs); |
| 2093 | } |
| 2094 | |
| 2095 | // Since we're at the start of the pattern, the next expected frame in TL0 is |
| 2096 | // right now. We will wait at most one expected retransmission time before |
| 2097 | // acknowledging that it did not arrive, which means this frame and the next |
| 2098 | // will not be retransmitted. |
Philip Eliasson | d52a1a6 | 2018-09-07 13:03:55 +0000 | [diff] [blame] | 2099 | vp8_header.temporalIdx = 1; |
sprang | a8ae6f2 | 2017-09-04 07:23:56 -0700 | [diff] [blame] | 2100 | EXPECT_EQ(StorageType::kDontRetransmit, |
| 2101 | rtp_sender_video_->GetStorageType(header, kSettings, kRttMs)); |
| 2102 | fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs); |
| 2103 | EXPECT_EQ(StorageType::kDontRetransmit, |
| 2104 | rtp_sender_video_->GetStorageType(header, kSettings, kRttMs)); |
| 2105 | fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs); |
| 2106 | |
| 2107 | // The TL0 frame did not arrive. So allow retransmission. |
| 2108 | EXPECT_EQ(StorageType::kAllowRetransmission, |
| 2109 | rtp_sender_video_->GetStorageType(header, kSettings, kRttMs)); |
| 2110 | fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs); |
| 2111 | |
| 2112 | // Insert a frame for TL2. We just had frame in TL1, so the next one there is |
| 2113 | // in three frames away. TL0 is still too far in the past. So, allow |
| 2114 | // retransmission. |
Philip Eliasson | d52a1a6 | 2018-09-07 13:03:55 +0000 | [diff] [blame] | 2115 | vp8_header.temporalIdx = 2; |
sprang | a8ae6f2 | 2017-09-04 07:23:56 -0700 | [diff] [blame] | 2116 | EXPECT_EQ(StorageType::kAllowRetransmission, |
| 2117 | rtp_sender_video_->GetStorageType(header, kSettings, kRttMs)); |
| 2118 | fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs); |
| 2119 | |
| 2120 | // Another TL2, next in TL1 is two frames away. Allow again. |
| 2121 | EXPECT_EQ(StorageType::kAllowRetransmission, |
| 2122 | rtp_sender_video_->GetStorageType(header, kSettings, kRttMs)); |
| 2123 | fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs); |
| 2124 | |
| 2125 | // Yet another TL2, next in TL1 is now only one frame away, so don't store |
| 2126 | // for retransmission. |
| 2127 | EXPECT_EQ(StorageType::kDontRetransmit, |
| 2128 | rtp_sender_video_->GetStorageType(header, kSettings, kRttMs)); |
| 2129 | } |
| 2130 | |
| 2131 | TEST_P(RtpSenderVideoTest, ConditionalRetransmitLimit) { |
| 2132 | const int64_t kFrameIntervalMs = 200; |
| 2133 | const int64_t kRttMs = (kFrameIntervalMs * 3) / 2; |
| 2134 | const int32_t kSettings = |
| 2135 | kRetransmitBaseLayer | kConditionallyRetransmitHigherLayers; |
| 2136 | |
| 2137 | // Insert VP8 frames for all temporal layers, but stop before the final index. |
| 2138 | RTPVideoHeader header; |
Niels Möller | 520ca4e | 2018-06-04 11:14:38 +0200 | [diff] [blame] | 2139 | header.codec = kVideoCodecVP8; |
sprang | a8ae6f2 | 2017-09-04 07:23:56 -0700 | [diff] [blame] | 2140 | |
| 2141 | // Fill averaging window to prevent rounding errors. |
| 2142 | constexpr int kNumRepetitions = |
| 2143 | (RTPSenderVideo::kTLRateWindowSizeMs + (kFrameIntervalMs / 2)) / |
| 2144 | kFrameIntervalMs; |
| 2145 | constexpr int kPattern[] = {0, 2, 2, 2}; |
Philip Eliasson | d52a1a6 | 2018-09-07 13:03:55 +0000 | [diff] [blame] | 2146 | auto& vp8_header = header.video_type_header.emplace<RTPVideoHeaderVP8>(); |
sprang | a8ae6f2 | 2017-09-04 07:23:56 -0700 | [diff] [blame] | 2147 | for (size_t i = 0; i < arraysize(kPattern) * kNumRepetitions; ++i) { |
Philip Eliasson | d52a1a6 | 2018-09-07 13:03:55 +0000 | [diff] [blame] | 2148 | vp8_header.temporalIdx = kPattern[i % arraysize(kPattern)]; |
sprang | a8ae6f2 | 2017-09-04 07:23:56 -0700 | [diff] [blame] | 2149 | |
| 2150 | rtp_sender_video_->GetStorageType(header, kSettings, kRttMs); |
| 2151 | fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs); |
| 2152 | } |
| 2153 | |
| 2154 | // Since we're at the start of the pattern, the next expected frame will be |
| 2155 | // right now in TL0. Put it in TL1 instead. Regular rules would dictate that |
| 2156 | // we don't store for retransmission because we expect a frame in a lower |
| 2157 | // layer, but that last frame in TL1 was a long time ago in absolute terms, |
| 2158 | // so allow retransmission anyway. |
Philip Eliasson | d52a1a6 | 2018-09-07 13:03:55 +0000 | [diff] [blame] | 2159 | vp8_header.temporalIdx = 1; |
sprang | a8ae6f2 | 2017-09-04 07:23:56 -0700 | [diff] [blame] | 2160 | EXPECT_EQ(StorageType::kAllowRetransmission, |
| 2161 | rtp_sender_video_->GetStorageType(header, kSettings, kRttMs)); |
| 2162 | } |
| 2163 | |
philipel | b3e42a4 | 2018-09-13 10:57:14 +0200 | [diff] [blame] | 2164 | TEST_P(RtpSenderVideoTest, PopulateGenericFrameDescriptor) { |
| 2165 | const int64_t kFrameId = 100000; |
| 2166 | uint8_t kFrame[100]; |
| 2167 | EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension( |
| 2168 | kRtpExtensionGenericFrameDescriptor, kGenericDescriptorId)); |
| 2169 | |
| 2170 | RTPVideoHeader hdr; |
| 2171 | RTPVideoHeader::GenericDescriptorInfo& generic = hdr.generic.emplace(); |
| 2172 | generic.frame_id = kFrameId; |
| 2173 | generic.temporal_index = 3; |
| 2174 | generic.spatial_index = 2; |
| 2175 | generic.higher_spatial_layers.push_back(4); |
| 2176 | generic.dependencies.push_back(kFrameId - 1); |
| 2177 | generic.dependencies.push_back(kFrameId - 500); |
| 2178 | rtp_sender_video_->SendVideo(kVideoCodecGeneric, kVideoFrameDelta, kPayload, |
| 2179 | kTimestamp, 0, kFrame, sizeof(kFrame), nullptr, |
| 2180 | &hdr, kDefaultExpectedRetransmissionTimeMs); |
| 2181 | |
| 2182 | RtpGenericFrameDescriptor descriptor_wire; |
| 2183 | EXPECT_EQ(1U, transport_.sent_packets_.size()); |
| 2184 | EXPECT_TRUE( |
| 2185 | transport_.last_sent_packet() |
| 2186 | .GetExtension<RtpGenericFrameDescriptorExtension>(&descriptor_wire)); |
| 2187 | EXPECT_EQ(static_cast<uint16_t>(generic.frame_id), descriptor_wire.FrameId()); |
| 2188 | EXPECT_EQ(generic.temporal_index, descriptor_wire.TemporalLayer()); |
| 2189 | EXPECT_THAT(descriptor_wire.FrameDependenciesDiffs(), ElementsAre(1, 500)); |
| 2190 | uint8_t spatial_bitmask = 0x14; |
| 2191 | EXPECT_EQ(spatial_bitmask, descriptor_wire.SpatialLayersBitmask()); |
| 2192 | } |
| 2193 | |
Danil Chapovalov | 84ffb35 | 2018-09-25 18:59:09 +0200 | [diff] [blame] | 2194 | TEST_P(RtpSenderVideoTest, |
| 2195 | UsesMinimalVp8DescriptorWhenGenericFrameDescriptorExtensionIsUsed) { |
| 2196 | const int64_t kFrameId = 100000; |
| 2197 | const size_t kFrameSize = 100; |
| 2198 | uint8_t kFrame[kFrameSize]; |
| 2199 | ASSERT_TRUE(rtp_sender_->RegisterRtpHeaderExtension( |
| 2200 | RtpGenericFrameDescriptorExtension::kUri, kGenericDescriptorId)); |
| 2201 | |
| 2202 | RTPVideoHeader hdr; |
| 2203 | hdr.codec = kVideoCodecVP8; |
| 2204 | RTPVideoHeaderVP8& vp8 = hdr.video_type_header.emplace<RTPVideoHeaderVP8>(); |
| 2205 | vp8.pictureId = kFrameId % 0X7FFF; |
| 2206 | vp8.tl0PicIdx = 13; |
| 2207 | vp8.temporalIdx = 1; |
| 2208 | vp8.keyIdx = 2; |
| 2209 | RTPVideoHeader::GenericDescriptorInfo& generic = hdr.generic.emplace(); |
| 2210 | generic.frame_id = kFrameId; |
| 2211 | rtp_sender_video_->SendVideo(kVideoCodecVP8, kVideoFrameDelta, kPayload, |
| 2212 | kTimestamp, 0, kFrame, sizeof(kFrame), nullptr, |
| 2213 | &hdr, kDefaultExpectedRetransmissionTimeMs); |
| 2214 | |
| 2215 | ASSERT_THAT(transport_.sent_packets_, SizeIs(1)); |
| 2216 | // Expect only minimal 1-byte vp8 descriptor was generated. |
| 2217 | EXPECT_THAT(transport_.sent_packets_[0].payload_size(), 1 + kFrameSize); |
| 2218 | } |
| 2219 | |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 2220 | TEST_P(RtpSenderTest, OnOverheadChanged) { |
michaelt | 4da3044 | 2016-11-17 01:38:43 -0800 | [diff] [blame] | 2221 | MockOverheadObserver mock_overhead_observer; |
Benjamin Wright | 192eeec | 2018-10-17 17:27:25 -0700 | [diff] [blame] | 2222 | rtp_sender_.reset( |
| 2223 | new RTPSender(false, &fake_clock_, &transport_, nullptr, nullptr, nullptr, |
| 2224 | nullptr, nullptr, nullptr, nullptr, nullptr, nullptr, |
| 2225 | &retransmission_rate_limiter_, &mock_overhead_observer, |
Johannes Kron | 9190b82 | 2018-10-29 11:22:05 +0100 | [diff] [blame] | 2226 | false, nullptr, false, false)); |
nisse | 7d59f6b | 2017-02-21 03:40:24 -0800 | [diff] [blame] | 2227 | rtp_sender_->SetSSRC(kSsrc); |
michaelt | 4da3044 | 2016-11-17 01:38:43 -0800 | [diff] [blame] | 2228 | |
michaelt | 4da3044 | 2016-11-17 01:38:43 -0800 | [diff] [blame] | 2229 | // RTP overhead is 12B. |
nisse | 284542b | 2017-01-10 08:58:32 -0800 | [diff] [blame] | 2230 | EXPECT_CALL(mock_overhead_observer, OnOverheadChanged(12)).Times(1); |
michaelt | 4da3044 | 2016-11-17 01:38:43 -0800 | [diff] [blame] | 2231 | SendGenericPayload(); |
| 2232 | |
| 2233 | rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionTransmissionTimeOffset, |
| 2234 | kTransmissionTimeOffsetExtensionId); |
| 2235 | |
| 2236 | // TransmissionTimeOffset extension has a size of 8B. |
nisse | 284542b | 2017-01-10 08:58:32 -0800 | [diff] [blame] | 2237 | // 12B + 8B = 20B |
| 2238 | EXPECT_CALL(mock_overhead_observer, OnOverheadChanged(20)).Times(1); |
michaelt | 4da3044 | 2016-11-17 01:38:43 -0800 | [diff] [blame] | 2239 | SendGenericPayload(); |
| 2240 | } |
| 2241 | |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 2242 | TEST_P(RtpSenderTest, DoesNotUpdateOverheadOnEqualSize) { |
michaelt | 4da3044 | 2016-11-17 01:38:43 -0800 | [diff] [blame] | 2243 | MockOverheadObserver mock_overhead_observer; |
Benjamin Wright | 192eeec | 2018-10-17 17:27:25 -0700 | [diff] [blame] | 2244 | rtp_sender_.reset( |
| 2245 | new RTPSender(false, &fake_clock_, &transport_, nullptr, nullptr, nullptr, |
| 2246 | nullptr, nullptr, nullptr, nullptr, nullptr, nullptr, |
| 2247 | &retransmission_rate_limiter_, &mock_overhead_observer, |
Johannes Kron | 9190b82 | 2018-10-29 11:22:05 +0100 | [diff] [blame] | 2248 | false, nullptr, false, false)); |
nisse | 7d59f6b | 2017-02-21 03:40:24 -0800 | [diff] [blame] | 2249 | rtp_sender_->SetSSRC(kSsrc); |
michaelt | 4da3044 | 2016-11-17 01:38:43 -0800 | [diff] [blame] | 2250 | |
| 2251 | EXPECT_CALL(mock_overhead_observer, OnOverheadChanged(_)).Times(1); |
michaelt | 4da3044 | 2016-11-17 01:38:43 -0800 | [diff] [blame] | 2252 | SendGenericPayload(); |
| 2253 | SendGenericPayload(); |
| 2254 | } |
| 2255 | |
sprang | 168794c | 2017-07-06 04:38:06 -0700 | [diff] [blame] | 2256 | TEST_P(RtpSenderTest, SendsKeepAlive) { |
| 2257 | MockTransport transport; |
Benjamin Wright | 192eeec | 2018-10-17 17:27:25 -0700 | [diff] [blame] | 2258 | rtp_sender_.reset(new RTPSender( |
| 2259 | false, &fake_clock_, &transport, nullptr, nullptr, nullptr, nullptr, |
| 2260 | nullptr, nullptr, nullptr, &mock_rtc_event_log_, nullptr, |
Johannes Kron | 9190b82 | 2018-10-29 11:22:05 +0100 | [diff] [blame] | 2261 | &retransmission_rate_limiter_, nullptr, false, nullptr, false, false)); |
sprang | 168794c | 2017-07-06 04:38:06 -0700 | [diff] [blame] | 2262 | rtp_sender_->SetSequenceNumber(kSeqNum); |
| 2263 | rtp_sender_->SetTimestampOffset(0); |
| 2264 | rtp_sender_->SetSSRC(kSsrc); |
| 2265 | |
| 2266 | const uint8_t kKeepalivePayloadType = 20; |
| 2267 | RTC_CHECK_NE(kKeepalivePayloadType, kPayload); |
| 2268 | |
| 2269 | EXPECT_CALL(transport, SendRtp(_, _, _)) |
| 2270 | .WillOnce( |
| 2271 | Invoke([&kKeepalivePayloadType](const uint8_t* packet, size_t len, |
| 2272 | const PacketOptions& options) { |
| 2273 | webrtc::RTPHeader rtp_header; |
| 2274 | RtpUtility::RtpHeaderParser parser(packet, len); |
| 2275 | EXPECT_TRUE(parser.Parse(&rtp_header, nullptr)); |
| 2276 | EXPECT_FALSE(rtp_header.markerBit); |
| 2277 | EXPECT_EQ(0U, rtp_header.paddingLength); |
| 2278 | EXPECT_EQ(kKeepalivePayloadType, rtp_header.payloadType); |
| 2279 | EXPECT_EQ(kSeqNum, rtp_header.sequenceNumber); |
| 2280 | EXPECT_EQ(kSsrc, rtp_header.ssrc); |
| 2281 | EXPECT_EQ(0u, len - rtp_header.headerLength); |
| 2282 | return true; |
| 2283 | })); |
| 2284 | |
| 2285 | rtp_sender_->SendKeepAlive(kKeepalivePayloadType); |
| 2286 | EXPECT_EQ(kSeqNum + 1, rtp_sender_->SequenceNumber()); |
| 2287 | } |
| 2288 | |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 2289 | INSTANTIATE_TEST_CASE_P(WithAndWithoutOverhead, |
| 2290 | RtpSenderTest, |
| 2291 | ::testing::Bool()); |
| 2292 | INSTANTIATE_TEST_CASE_P(WithAndWithoutOverhead, |
| 2293 | RtpSenderTestWithoutPacer, |
| 2294 | ::testing::Bool()); |
| 2295 | INSTANTIATE_TEST_CASE_P(WithAndWithoutOverhead, |
| 2296 | RtpSenderVideoTest, |
| 2297 | ::testing::Bool()); |
| 2298 | INSTANTIATE_TEST_CASE_P(WithAndWithoutOverhead, |
| 2299 | RtpSenderAudioTest, |
| 2300 | ::testing::Bool()); |
solenberg@webrtc.org | c0352d5 | 2013-05-20 20:55:07 +0000 | [diff] [blame] | 2301 | } // namespace webrtc |