blob: a687bcbb35b27adc73b67ecfa082044b822916b8 [file] [log] [blame]
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +00001/*
phoglund@webrtc.org78088c22012-02-07 14:56:45 +00002 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +00003 *
4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
9 */
10
kwiberg84be5112016-04-27 01:19:58 -070011#include <memory>
danilchapb8b6fbb2015-12-10 05:05:27 -080012#include <vector>
13
Karl Wiberg918f50c2018-07-05 11:40:33 +020014#include "absl/memory/memory.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020015#include "api/video/video_timing.h"
Elad Alon4a87e1c2017-10-03 16:11:34 +020016#include "logging/rtc_event_log/events/rtc_event.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020017#include "logging/rtc_event_log/mock/mock_rtc_event_log.h"
18#include "modules/rtp_rtcp/include/rtp_cvo.h"
19#include "modules/rtp_rtcp/include/rtp_header_extension_map.h"
20#include "modules/rtp_rtcp/include/rtp_header_parser.h"
21#include "modules/rtp_rtcp/include/rtp_rtcp_defines.h"
22#include "modules/rtp_rtcp/source/rtcp_packet/transport_feedback.h"
23#include "modules/rtp_rtcp/source/rtp_format_video_generic.h"
philipelb3e42a42018-09-13 10:57:14 +020024#include "modules/rtp_rtcp/source/rtp_generic_frame_descriptor.h"
25#include "modules/rtp_rtcp/source/rtp_generic_frame_descriptor_extension.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020026#include "modules/rtp_rtcp/source/rtp_header_extensions.h"
27#include "modules/rtp_rtcp/source/rtp_packet_received.h"
28#include "modules/rtp_rtcp/source/rtp_packet_to_send.h"
29#include "modules/rtp_rtcp/source/rtp_sender.h"
30#include "modules/rtp_rtcp/source/rtp_sender_video.h"
31#include "modules/rtp_rtcp/source/rtp_utility.h"
32#include "rtc_base/arraysize.h"
33#include "rtc_base/buffer.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020034#include "rtc_base/rate_limiter.h"
35#include "test/field_trial.h"
36#include "test/gmock.h"
37#include "test/gtest.h"
38#include "test/mock_transport.h"
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +000039
40namespace webrtc {
41
andrew@webrtc.org8a442592011-12-16 21:24:30 +000042namespace {
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +000043const int kTransmissionTimeOffsetExtensionId = 1;
44const int kAbsoluteSendTimeExtensionId = 14;
sprang@webrtc.org30933902015-03-17 14:33:12 +000045const int kTransportSequenceNumberExtensionId = 13;
ilnik04f4d122017-06-19 07:18:55 -070046const int kVideoTimingExtensionId = 12;
Steve Anton296a0ce2018-03-22 15:17:27 -070047const int kMidExtensionId = 11;
andrew@webrtc.org8a442592011-12-16 21:24:30 +000048const int kPayload = 100;
Shao Changbine62202f2015-04-21 20:24:50 +080049const int kRtxPayload = 98;
andrew@webrtc.org8a442592011-12-16 21:24:30 +000050const uint32_t kTimestamp = 10;
51const uint16_t kSeqNum = 33;
brandtr9dfff292016-11-14 05:14:50 -080052const uint32_t kSsrc = 725242;
andrew@webrtc.org8a442592011-12-16 21:24:30 +000053const int kMaxPacketLength = 1500;
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +000054const uint8_t kAudioLevel = 0x5a;
sprang@webrtc.org30933902015-03-17 14:33:12 +000055const uint16_t kTransportSequenceNumber = 0xaabbu;
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +000056const uint8_t kAudioLevelExtensionId = 9;
57const int kAudioPayload = 103;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +000058const uint64_t kStartTime = 123456789;
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +000059const size_t kMaxPaddingSize = 224u;
guoweis@webrtc.org45362892015-03-04 22:55:15 +000060const int kVideoRotationExtensionId = 5;
Stefan Holmera246cfb2016-08-23 17:51:42 +020061const size_t kGenericHeaderLength = 1;
62const uint8_t kPayloadData[] = {47, 11, 32, 93, 89};
spranga8ae6f22017-09-04 07:23:56 -070063const int64_t kDefaultExpectedRetransmissionTimeMs = 125;
philipelb3e42a42018-09-13 10:57:14 +020064const int kGenericDescriptorId = 10;
andrew@webrtc.org8a442592011-12-16 21:24:30 +000065
Danil Chapovalov5e57b172016-09-02 19:15:59 +020066using ::testing::_;
philipelb3e42a42018-09-13 10:57:14 +020067using ::testing::ElementsAre;
Danil Chapovalov5e57b172016-09-02 19:15:59 +020068using ::testing::ElementsAreArray;
sprang168794c2017-07-06 04:38:06 -070069using ::testing::Invoke;
Danil Chapovalov84ffb352018-09-25 18:59:09 +020070using ::testing::SizeIs;
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +000071
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +000072uint64_t ConvertMsToAbsSendTime(int64_t time_ms) {
Stefan Holmer0a87ffc2015-10-21 13:41:48 +020073 return (((time_ms << 18) + 500) / 1000) & 0x00ffffff;
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +000074}
75
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +000076class LoopbackTransportTest : public webrtc::Transport {
77 public:
Petter Strandmark26bc6692018-05-29 08:43:35 +020078 LoopbackTransportTest() : total_bytes_sent_(0) {
danilchap12ba1862016-10-26 02:41:55 -070079 receivers_extensions_.Register(kRtpExtensionTransmissionTimeOffset,
80 kTransmissionTimeOffsetExtensionId);
81 receivers_extensions_.Register(kRtpExtensionAbsoluteSendTime,
82 kAbsoluteSendTimeExtensionId);
83 receivers_extensions_.Register(kRtpExtensionTransportSequenceNumber,
84 kTransportSequenceNumberExtensionId);
85 receivers_extensions_.Register(kRtpExtensionVideoRotation,
86 kVideoRotationExtensionId);
87 receivers_extensions_.Register(kRtpExtensionAudioLevel,
88 kAudioLevelExtensionId);
ilnik04f4d122017-06-19 07:18:55 -070089 receivers_extensions_.Register(kRtpExtensionVideoTiming,
90 kVideoTimingExtensionId);
Steve Anton296a0ce2018-03-22 15:17:27 -070091 receivers_extensions_.Register(kRtpExtensionMid, kMidExtensionId);
philipelb3e42a42018-09-13 10:57:14 +020092 receivers_extensions_.Register(kRtpExtensionGenericFrameDescriptor,
93 kGenericDescriptorId);
guoweis@webrtc.org45362892015-03-04 22:55:15 +000094 }
danilchap12ba1862016-10-26 02:41:55 -070095
stefan1d8a5062015-10-02 03:39:33 -070096 bool SendRtp(const uint8_t* data,
97 size_t len,
98 const PacketOptions& options) override {
Petter Strandmark26bc6692018-05-29 08:43:35 +020099 last_options_ = options;
pkasting@chromium.org4591fbd2014-11-20 22:28:14 +0000100 total_bytes_sent_ += len;
danilchap12ba1862016-10-26 02:41:55 -0700101 sent_packets_.push_back(RtpPacketReceived(&receivers_extensions_));
102 EXPECT_TRUE(sent_packets_.back().Parse(data, len));
pbos2d566682015-09-28 09:59:31 -0700103 return true;
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000104 }
danilchap162abd32015-12-10 02:39:40 -0800105 bool SendRtcp(const uint8_t* data, size_t len) override { return false; }
danilchap12ba1862016-10-26 02:41:55 -0700106 const RtpPacketReceived& last_sent_packet() { return sent_packets_.back(); }
107 int packets_sent() { return sent_packets_.size(); }
108
pbos@webrtc.org72491b92014-07-10 16:24:54 +0000109 size_t total_bytes_sent_;
Petter Strandmark26bc6692018-05-29 08:43:35 +0200110 PacketOptions last_options_;
danilchap12ba1862016-10-26 02:41:55 -0700111 std::vector<RtpPacketReceived> sent_packets_;
112
113 private:
114 RtpHeaderExtensionMap receivers_extensions_;
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000115};
116
Elad Alon4a87e1c2017-10-03 16:11:34 +0200117MATCHER_P(SameRtcEventTypeAs, value, "") {
118 return value == arg->GetType();
119}
120
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000121} // namespace
122
sprangebbf8a82015-09-21 15:11:14 -0700123class MockRtpPacketSender : public RtpPacketSender {
124 public:
125 MockRtpPacketSender() {}
126 virtual ~MockRtpPacketSender() {}
127
Peter Boströme23e7372015-10-08 11:44:14 +0200128 MOCK_METHOD6(InsertPacket,
129 void(Priority priority,
sprangebbf8a82015-09-21 15:11:14 -0700130 uint32_t ssrc,
131 uint16_t sequence_number,
132 int64_t capture_time_ms,
133 size_t bytes,
134 bool retransmission));
135};
136
Stefan Holmerf5dca482016-01-27 12:58:51 +0100137class MockTransportSequenceNumberAllocator
138 : public TransportSequenceNumberAllocator {
139 public:
140 MOCK_METHOD0(AllocateSequenceNumber, uint16_t());
141};
142
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200143class MockSendSideDelayObserver : public SendSideDelayObserver {
144 public:
145 MOCK_METHOD3(SendSideDelayUpdated, void(int, int, uint32_t));
146};
147
asapersson35151f32016-05-02 23:44:01 -0700148class MockSendPacketObserver : public SendPacketObserver {
149 public:
150 MOCK_METHOD3(OnSendPacket, void(uint16_t, int64_t, uint32_t));
151};
152
Stefan Holmera246cfb2016-08-23 17:51:42 +0200153class MockTransportFeedbackObserver : public TransportFeedbackObserver {
154 public:
elad.alond12a8e12017-03-23 11:04:48 -0700155 MOCK_METHOD4(AddPacket,
156 void(uint32_t, uint16_t, size_t, const PacedPacketInfo&));
Stefan Holmera246cfb2016-08-23 17:51:42 +0200157 MOCK_METHOD1(OnTransportFeedback, void(const rtcp::TransportFeedback&));
elad.alonf9490002017-03-06 05:32:21 -0800158 MOCK_CONST_METHOD0(GetTransportFeedbackVector, std::vector<PacketFeedback>());
Stefan Holmera246cfb2016-08-23 17:51:42 +0200159};
160
minyue3a407ee2017-04-03 01:10:33 -0700161class MockOverheadObserver : public OverheadObserver {
162 public:
163 MOCK_METHOD1(OnOverheadChanged, void(size_t overhead_bytes_per_packet));
164};
165
166class RtpSenderTest : public ::testing::TestWithParam<bool> {
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000167 protected:
168 RtpSenderTest()
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +0000169 : fake_clock_(kStartTime),
terelius429c3452016-01-21 05:42:04 -0800170 mock_rtc_event_log_(),
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +0000171 mock_paced_sender_(),
sprangcd349d92016-07-13 09:11:28 -0700172 retransmission_rate_limiter_(&fake_clock_, 1000),
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +0000173 rtp_sender_(),
174 payload_(kPayload),
175 transport_(),
minyue3a407ee2017-04-03 01:10:33 -0700176 kMarkerBit(true),
177 field_trials_(GetParam() ? "WebRTC-SendSideBwe-WithOverhead/Enabled/"
178 : "") {}
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +0000179
Erik Språng7b52f102018-02-07 14:37:37 +0100180 void SetUp() override { SetUpRtpSender(true, false); }
Peter Boströme23e7372015-10-08 11:44:14 +0200181
Erik Språng7b52f102018-02-07 14:37:37 +0100182 void SetUpRtpSender(bool pacer, bool populate_network2) {
asapersson35151f32016-05-02 23:44:01 -0700183 rtp_sender_.reset(new RTPSender(
184 false, &fake_clock_, &transport_, pacer ? &mock_paced_sender_ : nullptr,
brandtrdbdb3f12016-11-10 05:04:48 -0800185 nullptr, &seq_num_allocator_, nullptr, nullptr, nullptr, nullptr,
sprangcd349d92016-07-13 09:11:28 -0700186 &mock_rtc_event_log_, &send_packet_observer_,
Benjamin Wright192eeec2018-10-17 17:27:25 -0700187 &retransmission_rate_limiter_, nullptr, populate_network2, nullptr,
Johannes Kron9190b822018-10-29 11:22:05 +0100188 false, false));
brandtr9dfff292016-11-14 05:14:50 -0800189 rtp_sender_->SetSequenceNumber(kSeqNum);
danilchap71fead22016-08-18 02:01:49 -0700190 rtp_sender_->SetTimestampOffset(0);
brandtr9dfff292016-11-14 05:14:50 -0800191 rtp_sender_->SetSSRC(kSsrc);
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +0000192 }
193
stefan@webrtc.orga678a3b2013-01-21 07:42:11 +0000194 SimulatedClock fake_clock_;
stefana23fc622016-07-28 07:56:38 -0700195 testing::NiceMock<MockRtcEventLog> mock_rtc_event_log_;
sprangebbf8a82015-09-21 15:11:14 -0700196 MockRtpPacketSender mock_paced_sender_;
stefana23fc622016-07-28 07:56:38 -0700197 testing::StrictMock<MockTransportSequenceNumberAllocator> seq_num_allocator_;
198 testing::StrictMock<MockSendPacketObserver> send_packet_observer_;
Stefan Holmera246cfb2016-08-23 17:51:42 +0200199 testing::StrictMock<MockTransportFeedbackObserver> feedback_observer_;
sprangcd349d92016-07-13 09:11:28 -0700200 RateLimiter retransmission_rate_limiter_;
kwiberg84be5112016-04-27 01:19:58 -0700201 std::unique_ptr<RTPSender> rtp_sender_;
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +0000202 int payload_;
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000203 LoopbackTransportTest transport_;
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000204 const bool kMarkerBit;
minyue3a407ee2017-04-03 01:10:33 -0700205 test::ScopedFieldTrials field_trials_;
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000206
stefan@webrtc.orga5cb98c2013-05-29 12:12:51 +0000207 void VerifyRTPHeaderCommon(const RTPHeader& rtp_header) {
danilchapd9e62f52016-01-14 14:55:19 -0800208 VerifyRTPHeaderCommon(rtp_header, kMarkerBit, 0);
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000209 }
210
211 void VerifyRTPHeaderCommon(const RTPHeader& rtp_header, bool marker_bit) {
danilchapd9e62f52016-01-14 14:55:19 -0800212 VerifyRTPHeaderCommon(rtp_header, marker_bit, 0);
213 }
214
215 void VerifyRTPHeaderCommon(const RTPHeader& rtp_header,
216 bool marker_bit,
217 uint8_t number_of_csrcs) {
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000218 EXPECT_EQ(marker_bit, rtp_header.markerBit);
stefan@webrtc.orga5cb98c2013-05-29 12:12:51 +0000219 EXPECT_EQ(payload_, rtp_header.payloadType);
220 EXPECT_EQ(kSeqNum, rtp_header.sequenceNumber);
221 EXPECT_EQ(kTimestamp, rtp_header.timestamp);
222 EXPECT_EQ(rtp_sender_->SSRC(), rtp_header.ssrc);
danilchapd9e62f52016-01-14 14:55:19 -0800223 EXPECT_EQ(number_of_csrcs, rtp_header.numCSRCs);
pkasting@chromium.org4591fbd2014-11-20 22:28:14 +0000224 EXPECT_EQ(0U, rtp_header.paddingLength);
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000225 }
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000226
danilchapb6f1fb52016-10-19 06:11:39 -0700227 std::unique_ptr<RtpPacketToSend> BuildRtpPacket(int payload_type,
228 bool marker_bit,
229 uint32_t timestamp,
230 int64_t capture_time_ms) {
231 auto packet = rtp_sender_->AllocatePacket();
232 packet->SetPayloadType(payload_type);
233 packet->SetMarker(marker_bit);
234 packet->SetTimestamp(timestamp);
235 packet->set_capture_time_ms(capture_time_ms);
236 EXPECT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
237 return packet;
238 }
239
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000240 void SendPacket(int64_t capture_time_ms, int payload_length) {
241 uint32_t timestamp = capture_time_ms * 90;
danilchapb6f1fb52016-10-19 06:11:39 -0700242 auto packet =
243 BuildRtpPacket(kPayload, kMarkerBit, timestamp, capture_time_ms);
244 packet->AllocatePayload(payload_length);
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000245
246 // Packet should be stored in a send bucket.
danilchapb6f1fb52016-10-19 06:11:39 -0700247 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
248 kAllowRetransmission,
249 RtpPacketSender::kNormalPriority));
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000250 }
asapersson35151f32016-05-02 23:44:01 -0700251
252 void SendGenericPayload() {
asapersson35151f32016-05-02 23:44:01 -0700253 const uint32_t kTimestamp = 1234;
254 const uint8_t kPayloadType = 127;
255 const int64_t kCaptureTimeMs = fake_clock_.TimeInMilliseconds();
256 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
257 EXPECT_EQ(0, rtp_sender_->RegisterPayload(payload_name, kPayloadType, 90000,
258 0, 1500));
259
Sami Kalliomäki426a80c2018-08-08 11:37:59 +0200260 RTPVideoHeader video_header;
Sergey Ulanov525df3f2016-08-02 17:46:41 -0700261 EXPECT_TRUE(rtp_sender_->SendOutgoingData(
Stefan Holmera246cfb2016-08-23 17:51:42 +0200262 kVideoFrameKey, kPayloadType, kTimestamp, kCaptureTimeMs, kPayloadData,
Sami Kalliomäki426a80c2018-08-08 11:37:59 +0200263 sizeof(kPayloadData), nullptr, &video_header, nullptr,
spranga8ae6f22017-09-04 07:23:56 -0700264 kDefaultExpectedRetransmissionTimeMs));
asapersson35151f32016-05-02 23:44:01 -0700265 }
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000266};
267
Peter Boströme23e7372015-10-08 11:44:14 +0200268// TODO(pbos): Move tests over from WithoutPacer to RtpSenderTest as this is our
269// default code path.
270class RtpSenderTestWithoutPacer : public RtpSenderTest {
271 public:
Erik Språng7b52f102018-02-07 14:37:37 +0100272 void SetUp() override { SetUpRtpSender(false, false); }
Peter Boströme23e7372015-10-08 11:44:14 +0200273};
274
spranga8ae6f22017-09-04 07:23:56 -0700275class TestRtpSenderVideo : public RTPSenderVideo {
276 public:
277 TestRtpSenderVideo(Clock* clock,
278 RTPSender* rtp_sender,
279 FlexfecSender* flexfec_sender)
Benjamin Wright192eeec2018-10-17 17:27:25 -0700280 : RTPSenderVideo(clock, rtp_sender, flexfec_sender, nullptr, false) {}
spranga8ae6f22017-09-04 07:23:56 -0700281 ~TestRtpSenderVideo() override {}
282
283 StorageType GetStorageType(const RTPVideoHeader& header,
284 int32_t retransmission_settings,
285 int64_t expected_retransmission_time_ms) {
286 return RTPSenderVideo::GetStorageType(GetTemporalId(header),
287 retransmission_settings,
288 expected_retransmission_time_ms);
289 }
290};
291
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000292class RtpSenderVideoTest : public RtpSenderTest {
293 protected:
danilchap162abd32015-12-10 02:39:40 -0800294 void SetUp() override {
Peter Boströme23e7372015-10-08 11:44:14 +0200295 // TODO(pbos): Set up to use pacer.
Erik Språng7b52f102018-02-07 14:37:37 +0100296 SetUpRtpSender(false, false);
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000297 rtp_sender_video_.reset(
spranga8ae6f22017-09-04 07:23:56 -0700298 new TestRtpSenderVideo(&fake_clock_, rtp_sender_.get(), nullptr));
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000299 }
spranga8ae6f22017-09-04 07:23:56 -0700300 std::unique_ptr<TestRtpSenderVideo> rtp_sender_video_;
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000301};
302
minyue3a407ee2017-04-03 01:10:33 -0700303TEST_P(RtpSenderTestWithoutPacer, AllocatePacketSetCsrc) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200304 // Configure rtp_sender with csrc.
305 std::vector<uint32_t> csrcs;
306 csrcs.push_back(0x23456789);
307 rtp_sender_->SetCsrcs(csrcs);
308
309 auto packet = rtp_sender_->AllocatePacket();
310
311 ASSERT_TRUE(packet);
312 EXPECT_EQ(rtp_sender_->SSRC(), packet->Ssrc());
313 EXPECT_EQ(csrcs, packet->Csrcs());
314}
315
minyue3a407ee2017-04-03 01:10:33 -0700316TEST_P(RtpSenderTestWithoutPacer, AllocatePacketReserveExtensions) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200317 // Configure rtp_sender with extensions.
318 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
319 kRtpExtensionTransmissionTimeOffset,
320 kTransmissionTimeOffsetExtensionId));
321 ASSERT_EQ(
322 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
323 kAbsoluteSendTimeExtensionId));
324 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAudioLevel,
325 kAudioLevelExtensionId));
326 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
327 kRtpExtensionTransportSequenceNumber,
328 kTransportSequenceNumberExtensionId));
329 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
330 kRtpExtensionVideoRotation, kVideoRotationExtensionId));
331
332 auto packet = rtp_sender_->AllocatePacket();
333
334 ASSERT_TRUE(packet);
335 // Preallocate BWE extensions RtpSender set itself.
336 EXPECT_TRUE(packet->HasExtension<TransmissionOffset>());
337 EXPECT_TRUE(packet->HasExtension<AbsoluteSendTime>());
338 EXPECT_TRUE(packet->HasExtension<TransportSequenceNumber>());
339 // Do not allocate media specific extensions.
340 EXPECT_FALSE(packet->HasExtension<AudioLevel>());
341 EXPECT_FALSE(packet->HasExtension<VideoOrientation>());
342}
343
minyue3a407ee2017-04-03 01:10:33 -0700344TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberAdvanceSequenceNumber) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200345 auto packet = rtp_sender_->AllocatePacket();
346 ASSERT_TRUE(packet);
347 const uint16_t sequence_number = rtp_sender_->SequenceNumber();
348
349 EXPECT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
350
351 EXPECT_EQ(sequence_number, packet->SequenceNumber());
352 EXPECT_EQ(sequence_number + 1, rtp_sender_->SequenceNumber());
353}
354
minyue3a407ee2017-04-03 01:10:33 -0700355TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberFailsOnNotSending) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200356 auto packet = rtp_sender_->AllocatePacket();
357 ASSERT_TRUE(packet);
358
359 rtp_sender_->SetSendingMediaStatus(false);
360 EXPECT_FALSE(rtp_sender_->AssignSequenceNumber(packet.get()));
361}
362
Danil Chapovalovb3179c72018-03-22 10:13:07 +0100363TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberMayAllowPaddingOnVideo) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200364 constexpr size_t kPaddingSize = 100;
365 auto packet = rtp_sender_->AllocatePacket();
366 ASSERT_TRUE(packet);
367
philipel8aadd502017-02-23 02:56:13 -0800368 ASSERT_FALSE(rtp_sender_->TimeToSendPadding(kPaddingSize, PacedPacketInfo()));
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200369 packet->SetMarker(false);
370 ASSERT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
Danil Chapovalovb3179c72018-03-22 10:13:07 +0100371 // Packet without marker bit doesn't allow padding on video stream.
philipel8aadd502017-02-23 02:56:13 -0800372 EXPECT_FALSE(rtp_sender_->TimeToSendPadding(kPaddingSize, PacedPacketInfo()));
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200373
374 packet->SetMarker(true);
375 ASSERT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
376 // Packet with marker bit allows send padding.
philipel8aadd502017-02-23 02:56:13 -0800377 EXPECT_TRUE(rtp_sender_->TimeToSendPadding(kPaddingSize, PacedPacketInfo()));
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200378}
379
Danil Chapovalovb3179c72018-03-22 10:13:07 +0100380TEST_P(RtpSenderTest, AssignSequenceNumberAllowsPaddingOnAudio) {
381 MockTransport transport;
382 const bool kEnableAudio = true;
383 rtp_sender_.reset(new RTPSender(
384 kEnableAudio, &fake_clock_, &transport, &mock_paced_sender_, nullptr,
385 nullptr, nullptr, nullptr, nullptr, nullptr, &mock_rtc_event_log_,
Johannes Kron9190b822018-10-29 11:22:05 +0100386 nullptr, &retransmission_rate_limiter_, nullptr, false, nullptr, false,
387 false));
Danil Chapovalovb3179c72018-03-22 10:13:07 +0100388 rtp_sender_->SetTimestampOffset(0);
389 rtp_sender_->SetSSRC(kSsrc);
390
391 std::unique_ptr<RtpPacketToSend> audio_packet = rtp_sender_->AllocatePacket();
392 // Padding on audio stream allowed regardless of marker in the last packet.
393 audio_packet->SetMarker(false);
394 audio_packet->SetPayloadType(kPayload);
395 rtp_sender_->AssignSequenceNumber(audio_packet.get());
396
397 const size_t kPaddingSize = 59;
398 EXPECT_CALL(transport, SendRtp(_, kPaddingSize + kRtpHeaderSize, _))
399 .WillOnce(testing::Return(true));
400 EXPECT_EQ(kPaddingSize,
401 rtp_sender_->TimeToSendPadding(kPaddingSize, PacedPacketInfo()));
402
403 // Requested padding size is too small, will send a larger one.
404 const size_t kMinPaddingSize = 50;
405 EXPECT_CALL(transport, SendRtp(_, kMinPaddingSize + kRtpHeaderSize, _))
406 .WillOnce(testing::Return(true));
Yves Gerey665174f2018-06-19 15:03:05 +0200407 EXPECT_EQ(kMinPaddingSize, rtp_sender_->TimeToSendPadding(kMinPaddingSize - 5,
408 PacedPacketInfo()));
Danil Chapovalovb3179c72018-03-22 10:13:07 +0100409}
410
minyue3a407ee2017-04-03 01:10:33 -0700411TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberSetPaddingTimestamps) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200412 constexpr size_t kPaddingSize = 100;
413 auto packet = rtp_sender_->AllocatePacket();
414 ASSERT_TRUE(packet);
415 packet->SetMarker(true);
416 packet->SetTimestamp(kTimestamp);
417
418 ASSERT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
philipel8aadd502017-02-23 02:56:13 -0800419 ASSERT_TRUE(rtp_sender_->TimeToSendPadding(kPaddingSize, PacedPacketInfo()));
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200420
421 ASSERT_EQ(1u, transport_.sent_packets_.size());
danilchap12ba1862016-10-26 02:41:55 -0700422 // Verify padding packet timestamp.
423 EXPECT_EQ(kTimestamp, transport_.last_sent_packet().Timestamp());
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200424}
425
minyue3a407ee2017-04-03 01:10:33 -0700426TEST_P(RtpSenderTestWithoutPacer,
427 TransportFeedbackObserverGetsCorrectByteCount) {
428 constexpr int kRtpOverheadBytesPerPacket = 12 + 8;
429 testing::NiceMock<MockOverheadObserver> mock_overhead_observer;
430 rtp_sender_.reset(new RTPSender(
431 false, &fake_clock_, &transport_, nullptr, nullptr, &seq_num_allocator_,
432 &feedback_observer_, nullptr, nullptr, nullptr, &mock_rtc_event_log_,
Benjamin Wright192eeec2018-10-17 17:27:25 -0700433 nullptr, &retransmission_rate_limiter_, &mock_overhead_observer, false,
Johannes Kron9190b822018-10-29 11:22:05 +0100434 nullptr, false, false));
minyue3a407ee2017-04-03 01:10:33 -0700435 rtp_sender_->SetSSRC(kSsrc);
436 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
437 kRtpExtensionTransportSequenceNumber,
438 kTransportSequenceNumberExtensionId));
439 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
440 .WillOnce(testing::Return(kTransportSequenceNumber));
441
442 const size_t expected_bytes =
443 GetParam() ? sizeof(kPayloadData) + kGenericHeaderLength +
444 kRtpOverheadBytesPerPacket
445 : sizeof(kPayloadData) + kGenericHeaderLength;
446
447 EXPECT_CALL(feedback_observer_,
448 AddPacket(rtp_sender_->SSRC(), kTransportSequenceNumber,
449 expected_bytes, PacedPacketInfo()))
450 .Times(1);
451 EXPECT_CALL(mock_overhead_observer,
452 OnOverheadChanged(kRtpOverheadBytesPerPacket))
453 .Times(1);
454 SendGenericPayload();
455}
456
457TEST_P(RtpSenderTestWithoutPacer, SendsPacketsWithTransportSequenceNumber) {
Stefan Holmera246cfb2016-08-23 17:51:42 +0200458 rtp_sender_.reset(new RTPSender(
brandtrdbdb3f12016-11-10 05:04:48 -0800459 false, &fake_clock_, &transport_, nullptr, nullptr, &seq_num_allocator_,
460 &feedback_observer_, nullptr, nullptr, nullptr, &mock_rtc_event_log_,
Benjamin Wright192eeec2018-10-17 17:27:25 -0700461 &send_packet_observer_, &retransmission_rate_limiter_, nullptr, false,
Johannes Kron9190b822018-10-29 11:22:05 +0100462 nullptr, false, false));
nisse7d59f6b2017-02-21 03:40:24 -0800463 rtp_sender_->SetSSRC(kSsrc);
Stefan Holmerf5dca482016-01-27 12:58:51 +0100464 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
465 kRtpExtensionTransportSequenceNumber,
466 kTransportSequenceNumberExtensionId));
467
Stefan Holmerf5dca482016-01-27 12:58:51 +0100468 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
469 .WillOnce(testing::Return(kTransportSequenceNumber));
asapersson35151f32016-05-02 23:44:01 -0700470 EXPECT_CALL(send_packet_observer_,
471 OnSendPacket(kTransportSequenceNumber, _, _))
472 .Times(1);
minyue3a407ee2017-04-03 01:10:33 -0700473
474 EXPECT_CALL(feedback_observer_,
475 AddPacket(rtp_sender_->SSRC(), kTransportSequenceNumber, _,
476 PacedPacketInfo()))
Stefan Holmera246cfb2016-08-23 17:51:42 +0200477 .Times(1);
asapersson35151f32016-05-02 23:44:01 -0700478
479 SendGenericPayload();
Stefan Holmerf5dca482016-01-27 12:58:51 +0100480
danilchap12ba1862016-10-26 02:41:55 -0700481 const auto& packet = transport_.last_sent_packet();
482 uint16_t transport_seq_no;
483 ASSERT_TRUE(packet.GetExtension<TransportSequenceNumber>(&transport_seq_no));
484 EXPECT_EQ(kTransportSequenceNumber, transport_seq_no);
Petter Strandmark26bc6692018-05-29 08:43:35 +0200485 EXPECT_EQ(transport_.last_options_.packet_id, transport_seq_no);
Sebastian Jansson1bca65b2018-10-10 09:58:08 +0200486 EXPECT_TRUE(transport_.last_options_.included_in_allocation);
Petter Strandmark26bc6692018-05-29 08:43:35 +0200487}
488
489TEST_P(RtpSenderTestWithoutPacer, PacketOptionsNoRetransmission) {
490 rtp_sender_.reset(new RTPSender(
491 false, &fake_clock_, &transport_, nullptr, nullptr, &seq_num_allocator_,
492 &feedback_observer_, nullptr, nullptr, nullptr, &mock_rtc_event_log_,
Benjamin Wright192eeec2018-10-17 17:27:25 -0700493 &send_packet_observer_, &retransmission_rate_limiter_, nullptr, false,
Johannes Kron9190b822018-10-29 11:22:05 +0100494 nullptr, false, false));
Petter Strandmark26bc6692018-05-29 08:43:35 +0200495 rtp_sender_->SetSSRC(kSsrc);
496
497 SendGenericPayload();
498
499 EXPECT_FALSE(transport_.last_options_.is_retransmit);
Stefan Holmerf5dca482016-01-27 12:58:51 +0100500}
501
Sebastian Jansson1bca65b2018-10-10 09:58:08 +0200502TEST_P(RtpSenderTestWithoutPacer,
503 SetsIncludedInFeedbackWhenTransportSequenceNumberExtensionIsRegistered) {
504 SetUpRtpSender(false, false);
505 rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionTransportSequenceNumber,
506 kTransportSequenceNumberExtensionId);
507 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
508 .WillOnce(testing::Return(kTransportSequenceNumber));
509 EXPECT_CALL(send_packet_observer_, OnSendPacket).Times(1);
stefana23fc622016-07-28 07:56:38 -0700510 SendGenericPayload();
Sebastian Jansson1bca65b2018-10-10 09:58:08 +0200511 EXPECT_TRUE(transport_.last_options_.included_in_feedback);
512}
513
514TEST_P(
515 RtpSenderTestWithoutPacer,
516 SetsIncludedInAllocationWhenTransportSequenceNumberExtensionIsRegistered) {
517 SetUpRtpSender(false, false);
518 rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionTransportSequenceNumber,
519 kTransportSequenceNumberExtensionId);
520 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
521 .WillOnce(testing::Return(kTransportSequenceNumber));
522 EXPECT_CALL(send_packet_observer_, OnSendPacket).Times(1);
523 SendGenericPayload();
524 EXPECT_TRUE(transport_.last_options_.included_in_allocation);
525}
526
527TEST_P(RtpSenderTestWithoutPacer,
528 SetsIncludedInAllocationWhenForcedAsPartOfAllocation) {
529 SetUpRtpSender(false, false);
530 rtp_sender_->SetAsPartOfAllocation(true);
531 SendGenericPayload();
532 EXPECT_FALSE(transport_.last_options_.included_in_feedback);
533 EXPECT_TRUE(transport_.last_options_.included_in_allocation);
534}
535
536TEST_P(RtpSenderTestWithoutPacer, DoesnSetIncludedInAllocationByDefault) {
537 SetUpRtpSender(false, false);
538 SendGenericPayload();
539 EXPECT_FALSE(transport_.last_options_.included_in_feedback);
540 EXPECT_FALSE(transport_.last_options_.included_in_allocation);
stefana23fc622016-07-28 07:56:38 -0700541}
asapersson35151f32016-05-02 23:44:01 -0700542
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200543TEST_P(RtpSenderTestWithoutPacer, OnSendSideDelayUpdated) {
544 testing::StrictMock<MockSendSideDelayObserver> send_side_delay_observer_;
Benjamin Wright192eeec2018-10-17 17:27:25 -0700545 rtp_sender_.reset(new RTPSender(
546 false, &fake_clock_, &transport_, nullptr, nullptr, nullptr, nullptr,
547 nullptr, nullptr, &send_side_delay_observer_, &mock_rtc_event_log_,
Johannes Kron9190b822018-10-29 11:22:05 +0100548 nullptr, nullptr, nullptr, false, nullptr, false, false));
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200549 rtp_sender_->SetSSRC(kSsrc);
550
551 const uint8_t kPayloadType = 127;
552 const uint32_t kCaptureTimeMsToRtpTimestamp = 90; // 90 kHz clock
553 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
554 RTPVideoHeader video_header;
555 EXPECT_EQ(0, rtp_sender_->RegisterPayload(payload_name, kPayloadType,
556 1000 * kCaptureTimeMsToRtpTimestamp,
557 0, 1500));
558
559 // Send packet with 10 ms send-side delay. The average and max should be 10
560 // ms.
561 EXPECT_CALL(send_side_delay_observer_, SendSideDelayUpdated(10, 10, kSsrc))
562 .Times(1);
563 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
564 fake_clock_.AdvanceTimeMilliseconds(10);
565 EXPECT_TRUE(rtp_sender_->SendOutgoingData(
566 kVideoFrameKey, kPayloadType,
567 capture_time_ms * kCaptureTimeMsToRtpTimestamp, capture_time_ms,
568 kPayloadData, sizeof(kPayloadData), nullptr, &video_header, nullptr,
569 kDefaultExpectedRetransmissionTimeMs));
570
571 // Send another packet with 20 ms delay. The average
572 // and max should be 15 and 20 ms respectively.
573 EXPECT_CALL(send_side_delay_observer_, SendSideDelayUpdated(15, 20, kSsrc))
574 .Times(1);
575 fake_clock_.AdvanceTimeMilliseconds(10);
576 EXPECT_TRUE(rtp_sender_->SendOutgoingData(
577 kVideoFrameKey, kPayloadType,
578 capture_time_ms * kCaptureTimeMsToRtpTimestamp, capture_time_ms,
579 kPayloadData, sizeof(kPayloadData), nullptr, &video_header, nullptr,
580 kDefaultExpectedRetransmissionTimeMs));
581
582 // Send another packet at the same time, which replaces the last packet.
583 // Since this packet has 0 ms delay, the average is now 5 ms and max is 10 ms.
584 // TODO(terelius): Is is not clear that this is the right behavior.
585 EXPECT_CALL(send_side_delay_observer_, SendSideDelayUpdated(5, 10, kSsrc))
586 .Times(1);
587 capture_time_ms = fake_clock_.TimeInMilliseconds();
588 EXPECT_TRUE(rtp_sender_->SendOutgoingData(
589 kVideoFrameKey, kPayloadType,
590 capture_time_ms * kCaptureTimeMsToRtpTimestamp, capture_time_ms,
591 kPayloadData, sizeof(kPayloadData), nullptr, &video_header, nullptr,
592 kDefaultExpectedRetransmissionTimeMs));
593
594 // Send a packet 1 second later. The earlier packets should have timed
595 // out, so both max and average should be the delay of this packet.
596 fake_clock_.AdvanceTimeMilliseconds(1000);
597 capture_time_ms = fake_clock_.TimeInMilliseconds();
598 fake_clock_.AdvanceTimeMilliseconds(1);
599 EXPECT_CALL(send_side_delay_observer_, SendSideDelayUpdated(1, 1, kSsrc))
600 .Times(1);
601 EXPECT_TRUE(rtp_sender_->SendOutgoingData(
602 kVideoFrameKey, kPayloadType,
603 capture_time_ms * kCaptureTimeMsToRtpTimestamp, capture_time_ms,
604 kPayloadData, sizeof(kPayloadData), nullptr, &video_header, nullptr,
605 kDefaultExpectedRetransmissionTimeMs));
606}
607
minyue3a407ee2017-04-03 01:10:33 -0700608TEST_P(RtpSenderTestWithoutPacer, OnSendPacketUpdated) {
stefana23fc622016-07-28 07:56:38 -0700609 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
610 kRtpExtensionTransportSequenceNumber,
611 kTransportSequenceNumberExtensionId));
asapersson35151f32016-05-02 23:44:01 -0700612 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
613 .WillOnce(testing::Return(kTransportSequenceNumber));
614 EXPECT_CALL(send_packet_observer_,
615 OnSendPacket(kTransportSequenceNumber, _, _))
616 .Times(1);
617
618 SendGenericPayload();
619}
620
minyue3a407ee2017-04-03 01:10:33 -0700621TEST_P(RtpSenderTest, SendsPacketsWithTransportSequenceNumber) {
michaelt4da30442016-11-17 01:38:43 -0800622 rtp_sender_.reset(new RTPSender(
623 false, &fake_clock_, &transport_, &mock_paced_sender_, nullptr,
624 &seq_num_allocator_, &feedback_observer_, nullptr, nullptr, nullptr,
625 &mock_rtc_event_log_, &send_packet_observer_,
Johannes Kron9190b822018-10-29 11:22:05 +0100626 &retransmission_rate_limiter_, nullptr, false, nullptr, false, false));
brandtr9dfff292016-11-14 05:14:50 -0800627 rtp_sender_->SetSequenceNumber(kSeqNum);
628 rtp_sender_->SetSSRC(kSsrc);
Stefan Holmera246cfb2016-08-23 17:51:42 +0200629 rtp_sender_->SetStorePacketsStatus(true, 10);
630 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
631 kRtpExtensionTransportSequenceNumber,
632 kTransportSequenceNumberExtensionId));
633
brandtr9dfff292016-11-14 05:14:50 -0800634 EXPECT_CALL(mock_paced_sender_, InsertPacket(_, kSsrc, kSeqNum, _, _, _));
Stefan Holmera246cfb2016-08-23 17:51:42 +0200635 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
636 .WillOnce(testing::Return(kTransportSequenceNumber));
637 EXPECT_CALL(send_packet_observer_,
638 OnSendPacket(kTransportSequenceNumber, _, _))
639 .Times(1);
minyue3a407ee2017-04-03 01:10:33 -0700640 EXPECT_CALL(feedback_observer_,
641 AddPacket(rtp_sender_->SSRC(), kTransportSequenceNumber, _,
642 PacedPacketInfo()))
Stefan Holmera246cfb2016-08-23 17:51:42 +0200643 .Times(1);
644
645 SendGenericPayload();
philipel8aadd502017-02-23 02:56:13 -0800646 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum,
647 fake_clock_.TimeInMilliseconds(), false,
648 PacedPacketInfo());
Stefan Holmera246cfb2016-08-23 17:51:42 +0200649
danilchap12ba1862016-10-26 02:41:55 -0700650 const auto& packet = transport_.last_sent_packet();
651 uint16_t transport_seq_no;
652 EXPECT_TRUE(packet.GetExtension<TransportSequenceNumber>(&transport_seq_no));
653 EXPECT_EQ(kTransportSequenceNumber, transport_seq_no);
Petter Strandmark26bc6692018-05-29 08:43:35 +0200654 EXPECT_EQ(transport_.last_options_.packet_id, transport_seq_no);
Stefan Holmera246cfb2016-08-23 17:51:42 +0200655}
656
Erik Språng7b52f102018-02-07 14:37:37 +0100657TEST_P(RtpSenderTest, WritesPacerExitToTimingExtension) {
ilnik04f4d122017-06-19 07:18:55 -0700658 rtp_sender_->SetStorePacketsStatus(true, 10);
659 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
660 kRtpExtensionVideoTiming, kVideoTimingExtensionId));
661 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
662 auto packet = rtp_sender_->AllocatePacket();
663 packet->SetPayloadType(kPayload);
664 packet->SetMarker(true);
665 packet->SetTimestamp(kTimestamp);
666 packet->set_capture_time_ms(capture_time_ms);
ilnik2edc6842017-07-06 03:06:50 -0700667 const VideoSendTiming kVideoTiming = {0u, 0u, 0u, 0u, 0u, 0u, true};
ilnik04f4d122017-06-19 07:18:55 -0700668 packet->SetExtension<VideoTimingExtension>(kVideoTiming);
669 EXPECT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
670 size_t packet_size = packet->size();
ilnik04f4d122017-06-19 07:18:55 -0700671
672 const int kStoredTimeInMs = 100;
Erik Språng7b52f102018-02-07 14:37:37 +0100673 {
674 EXPECT_CALL(
675 mock_paced_sender_,
676 InsertPacket(RtpPacketSender::kNormalPriority, kSsrc, _, _, _, _));
677 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
678 kAllowRetransmission,
679 RtpPacketSender::kNormalPriority));
680 }
ilnik04f4d122017-06-19 07:18:55 -0700681 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
Erik Språng7b52f102018-02-07 14:37:37 +0100682 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum, capture_time_ms, false,
683 PacedPacketInfo());
ilnik04f4d122017-06-19 07:18:55 -0700684 EXPECT_EQ(1, transport_.packets_sent());
685 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
686
danilchapce251812017-09-11 12:24:41 -0700687 VideoSendTiming video_timing;
688 EXPECT_TRUE(transport_.last_sent_packet().GetExtension<VideoTimingExtension>(
689 &video_timing));
690 EXPECT_EQ(kStoredTimeInMs, video_timing.pacer_exit_delta_ms);
Erik Språng7b52f102018-02-07 14:37:37 +0100691}
ilnik04f4d122017-06-19 07:18:55 -0700692
Danil Chapovalovaf52b682018-11-27 10:48:27 +0100693TEST_P(RtpSenderTest, WritesNetwork2ToTimingExtensionWithPacer) {
694 SetUpRtpSender(/*pacer=*/true, /*populate_network2=*/true);
Erik Språng7b52f102018-02-07 14:37:37 +0100695 rtp_sender_->SetStorePacketsStatus(true, 10);
696 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
697 kRtpExtensionVideoTiming, kVideoTimingExtensionId));
698 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
699 auto packet = rtp_sender_->AllocatePacket();
700 packet->SetPayloadType(kPayload);
701 packet->SetMarker(true);
702 packet->SetTimestamp(kTimestamp);
703 packet->set_capture_time_ms(capture_time_ms);
704 const uint16_t kPacerExitMs = 1234u;
705 const VideoSendTiming kVideoTiming = {0u, 0u, 0u, kPacerExitMs, 0u, 0u, true};
706 packet->SetExtension<VideoTimingExtension>(kVideoTiming);
707 EXPECT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
708 size_t packet_size = packet->size();
709
710 const int kStoredTimeInMs = 100;
711 {
712 EXPECT_CALL(
713 mock_paced_sender_,
714 InsertPacket(RtpPacketSender::kNormalPriority, kSsrc, _, _, _, _));
715 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
716 kAllowRetransmission,
717 RtpPacketSender::kNormalPriority));
718 }
ilnik04f4d122017-06-19 07:18:55 -0700719 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
720 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum, capture_time_ms, false,
721 PacedPacketInfo());
Erik Språng7b52f102018-02-07 14:37:37 +0100722 EXPECT_EQ(1, transport_.packets_sent());
ilnik04f4d122017-06-19 07:18:55 -0700723 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
724
Erik Språng7b52f102018-02-07 14:37:37 +0100725 VideoSendTiming video_timing;
danilchapce251812017-09-11 12:24:41 -0700726 EXPECT_TRUE(transport_.last_sent_packet().GetExtension<VideoTimingExtension>(
727 &video_timing));
Erik Språng7b52f102018-02-07 14:37:37 +0100728 EXPECT_EQ(kStoredTimeInMs, video_timing.network2_timestamp_delta_ms);
729 EXPECT_EQ(kPacerExitMs, video_timing.pacer_exit_delta_ms);
ilnik04f4d122017-06-19 07:18:55 -0700730}
731
Danil Chapovalovaf52b682018-11-27 10:48:27 +0100732TEST_P(RtpSenderTest, WritesNetwork2ToTimingExtensionWithoutPacer) {
733 SetUpRtpSender(/*pacer=*/false, /*populate_network2=*/true);
734 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
735 kRtpExtensionVideoTiming, kVideoTimingExtensionId));
736 auto packet = rtp_sender_->AllocatePacket();
737 packet->SetMarker(true);
738 packet->set_capture_time_ms(fake_clock_.TimeInMilliseconds());
739 const VideoSendTiming kVideoTiming = {0u, 0u, 0u, 0u, 0u, 0u, true};
740 packet->SetExtension<VideoTimingExtension>(kVideoTiming);
741 EXPECT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
742
743 const int kPropagateTimeMs = 10;
744 fake_clock_.AdvanceTimeMilliseconds(kPropagateTimeMs);
745
746 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
747 kAllowRetransmission,
748 RtpPacketSender::kNormalPriority));
749
750 EXPECT_EQ(1, transport_.packets_sent());
751 absl::optional<VideoSendTiming> video_timing =
752 transport_.last_sent_packet().GetExtension<VideoTimingExtension>();
753 ASSERT_TRUE(video_timing);
754 EXPECT_EQ(kPropagateTimeMs, video_timing->network2_timestamp_delta_ms);
755}
756
minyue3a407ee2017-04-03 01:10:33 -0700757TEST_P(RtpSenderTest, TrafficSmoothingWithExtensions) {
Peter Boströme23e7372015-10-08 11:44:14 +0200758 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kNormalPriority,
brandtr9dfff292016-11-14 05:14:50 -0800759 kSsrc, kSeqNum, _, _, _));
Elad Alon4a87e1c2017-10-03 16:11:34 +0200760 EXPECT_CALL(mock_rtc_event_log_,
761 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)));
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000762
pwestin@webrtc.orgc66e8b32012-11-07 17:01:04 +0000763 rtp_sender_->SetStorePacketsStatus(true, 10);
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000764 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
danilchap162abd32015-12-10 02:39:40 -0800765 kRtpExtensionTransmissionTimeOffset,
766 kTransmissionTimeOffsetExtensionId));
767 EXPECT_EQ(
768 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
769 kAbsoluteSendTimeExtensionId));
stefan@webrtc.org8ccb9f92013-06-19 14:13:42 +0000770 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
danilchapb6f1fb52016-10-19 06:11:39 -0700771 auto packet =
772 BuildRtpPacket(kPayload, kMarkerBit, kTimestamp, capture_time_ms);
773 size_t packet_size = packet->size();
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000774
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000775 // Packet should be stored in a send bucket.
danilchapb6f1fb52016-10-19 06:11:39 -0700776 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
777 kAllowRetransmission,
Sergey Ulanov525df3f2016-08-02 17:46:41 -0700778 RtpPacketSender::kNormalPriority));
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000779
danilchap12ba1862016-10-26 02:41:55 -0700780 EXPECT_EQ(0, transport_.packets_sent());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000781
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000782 const int kStoredTimeInMs = 100;
stefan@webrtc.orga678a3b2013-01-21 07:42:11 +0000783 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000784
brandtr9dfff292016-11-14 05:14:50 -0800785 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum, capture_time_ms, false,
philipel8aadd502017-02-23 02:56:13 -0800786 PacedPacketInfo());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000787
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000788 // Process send bucket. Packet should now be sent.
danilchap12ba1862016-10-26 02:41:55 -0700789 EXPECT_EQ(1, transport_.packets_sent());
790 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
791
stefan@webrtc.orga5cb98c2013-05-29 12:12:51 +0000792 webrtc::RTPHeader rtp_header;
danilchap12ba1862016-10-26 02:41:55 -0700793 transport_.last_sent_packet().GetHeader(&rtp_header);
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000794
795 // Verify transmission time offset.
796 EXPECT_EQ(kStoredTimeInMs * 90, rtp_header.extension.transmissionTimeOffset);
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000797 uint64_t expected_send_time =
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000798 ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds());
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000799 EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime);
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000800}
801
minyue3a407ee2017-04-03 01:10:33 -0700802TEST_P(RtpSenderTest, TrafficSmoothingRetransmits) {
Peter Boströme23e7372015-10-08 11:44:14 +0200803 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kNormalPriority,
brandtr9dfff292016-11-14 05:14:50 -0800804 kSsrc, kSeqNum, _, _, _));
Elad Alon4a87e1c2017-10-03 16:11:34 +0200805 EXPECT_CALL(mock_rtc_event_log_,
806 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)));
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000807
808 rtp_sender_->SetStorePacketsStatus(true, 10);
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000809 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
danilchap162abd32015-12-10 02:39:40 -0800810 kRtpExtensionTransmissionTimeOffset,
811 kTransmissionTimeOffsetExtensionId));
812 EXPECT_EQ(
813 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
814 kAbsoluteSendTimeExtensionId));
stefan@webrtc.org8ccb9f92013-06-19 14:13:42 +0000815 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
danilchapb6f1fb52016-10-19 06:11:39 -0700816 auto packet =
817 BuildRtpPacket(kPayload, kMarkerBit, kTimestamp, capture_time_ms);
818 size_t packet_size = packet->size();
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000819
820 // Packet should be stored in a send bucket.
danilchapb6f1fb52016-10-19 06:11:39 -0700821 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
822 kAllowRetransmission,
Sergey Ulanov525df3f2016-08-02 17:46:41 -0700823 RtpPacketSender::kNormalPriority));
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000824
danilchap12ba1862016-10-26 02:41:55 -0700825 EXPECT_EQ(0, transport_.packets_sent());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000826
terelius5d332ac2016-01-14 14:37:39 -0800827 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kNormalPriority,
brandtr9dfff292016-11-14 05:14:50 -0800828 kSsrc, kSeqNum, _, _, _));
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000829
830 const int kStoredTimeInMs = 100;
831 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
832
danilchapb6f1fb52016-10-19 06:11:39 -0700833 EXPECT_EQ(static_cast<int>(packet_size), rtp_sender_->ReSendPacket(kSeqNum));
danilchap12ba1862016-10-26 02:41:55 -0700834 EXPECT_EQ(0, transport_.packets_sent());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000835
brandtr9dfff292016-11-14 05:14:50 -0800836 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum, capture_time_ms, false,
philipel8aadd502017-02-23 02:56:13 -0800837 PacedPacketInfo());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000838
839 // Process send bucket. Packet should now be sent.
danilchap12ba1862016-10-26 02:41:55 -0700840 EXPECT_EQ(1, transport_.packets_sent());
841 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000842
stefan@webrtc.orga5cb98c2013-05-29 12:12:51 +0000843 webrtc::RTPHeader rtp_header;
danilchap12ba1862016-10-26 02:41:55 -0700844 transport_.last_sent_packet().GetHeader(&rtp_header);
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000845
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000846 // Verify transmission time offset.
847 EXPECT_EQ(kStoredTimeInMs * 90, rtp_header.extension.transmissionTimeOffset);
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000848 uint64_t expected_send_time =
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000849 ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds());
850 EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime);
851}
852
853// This test sends 1 regular video packet, then 4 padding packets, and then
854// 1 more regular packet.
minyue3a407ee2017-04-03 01:10:33 -0700855TEST_P(RtpSenderTest, SendPadding) {
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000856 // Make all (non-padding) packets go to send queue.
terelius5d332ac2016-01-14 14:37:39 -0800857 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kNormalPriority,
brandtr9dfff292016-11-14 05:14:50 -0800858 kSsrc, kSeqNum, _, _, _));
Elad Alon4a87e1c2017-10-03 16:11:34 +0200859 EXPECT_CALL(mock_rtc_event_log_,
860 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
861 .Times(1 + 4 + 1);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000862
863 uint16_t seq_num = kSeqNum;
864 uint32_t timestamp = kTimestamp;
865 rtp_sender_->SetStorePacketsStatus(true, 10);
pkasting@chromium.org4591fbd2014-11-20 22:28:14 +0000866 size_t rtp_header_len = kRtpHeaderSize;
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000867 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
danilchap162abd32015-12-10 02:39:40 -0800868 kRtpExtensionTransmissionTimeOffset,
869 kTransmissionTimeOffsetExtensionId));
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000870 rtp_header_len += 4; // 4 bytes extension.
danilchap162abd32015-12-10 02:39:40 -0800871 EXPECT_EQ(
872 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
873 kAbsoluteSendTimeExtensionId));
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000874 rtp_header_len += 4; // 4 bytes extension.
875 rtp_header_len += 4; // 4 extra bytes common to all extension headers.
876
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000877 webrtc::RTPHeader rtp_header;
878
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000879 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
danilchapb6f1fb52016-10-19 06:11:39 -0700880 auto packet =
881 BuildRtpPacket(kPayload, kMarkerBit, timestamp, capture_time_ms);
Stefan Holmer586b19b2015-09-18 11:14:31 +0200882 const uint32_t media_packet_timestamp = timestamp;
danilchapb6f1fb52016-10-19 06:11:39 -0700883 size_t packet_size = packet->size();
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000884
885 // Packet should be stored in a send bucket.
danilchapb6f1fb52016-10-19 06:11:39 -0700886 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
887 kAllowRetransmission,
Sergey Ulanov525df3f2016-08-02 17:46:41 -0700888 RtpPacketSender::kNormalPriority));
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000889
890 int total_packets_sent = 0;
danilchap12ba1862016-10-26 02:41:55 -0700891 EXPECT_EQ(total_packets_sent, transport_.packets_sent());
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000892
893 const int kStoredTimeInMs = 100;
894 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
brandtr9dfff292016-11-14 05:14:50 -0800895 rtp_sender_->TimeToSendPacket(kSsrc, seq_num++, capture_time_ms, false,
philipel8aadd502017-02-23 02:56:13 -0800896 PacedPacketInfo());
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000897 // Packet should now be sent. This test doesn't verify the regular video
898 // packet, since it is tested in another test.
danilchap12ba1862016-10-26 02:41:55 -0700899 EXPECT_EQ(++total_packets_sent, transport_.packets_sent());
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000900 timestamp += 90 * kStoredTimeInMs;
901
902 // Send padding 4 times, waiting 50 ms between each.
903 for (int i = 0; i < 4; ++i) {
904 const int kPaddingPeriodMs = 50;
pkasting@chromium.org4591fbd2014-11-20 22:28:14 +0000905 const size_t kPaddingBytes = 100;
906 const size_t kMaxPaddingLength = 224; // Value taken from rtp_sender.cc.
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000907 // Padding will be forced to full packets.
philipelc7bf32a2017-02-17 03:59:43 -0800908 EXPECT_EQ(kMaxPaddingLength,
philipel8aadd502017-02-23 02:56:13 -0800909 rtp_sender_->TimeToSendPadding(kPaddingBytes, PacedPacketInfo()));
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000910
911 // Process send bucket. Padding should now be sent.
danilchap12ba1862016-10-26 02:41:55 -0700912 EXPECT_EQ(++total_packets_sent, transport_.packets_sent());
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000913 EXPECT_EQ(kMaxPaddingLength + rtp_header_len,
danilchap12ba1862016-10-26 02:41:55 -0700914 transport_.last_sent_packet().size());
915
916 transport_.last_sent_packet().GetHeader(&rtp_header);
pbosbd2522a2015-07-01 05:35:53 -0700917 EXPECT_EQ(kMaxPaddingLength, rtp_header.paddingLength);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000918
Stefan Holmer586b19b2015-09-18 11:14:31 +0200919 // Verify sequence number and timestamp. The timestamp should be the same
920 // as the last media packet.
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000921 EXPECT_EQ(seq_num++, rtp_header.sequenceNumber);
Stefan Holmer586b19b2015-09-18 11:14:31 +0200922 EXPECT_EQ(media_packet_timestamp, rtp_header.timestamp);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000923 // Verify transmission time offset.
Stefan Holmer586b19b2015-09-18 11:14:31 +0200924 int offset = timestamp - media_packet_timestamp;
925 EXPECT_EQ(offset, rtp_header.extension.transmissionTimeOffset);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000926 uint64_t expected_send_time =
927 ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds());
928 EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime);
929 fake_clock_.AdvanceTimeMilliseconds(kPaddingPeriodMs);
930 timestamp += 90 * kPaddingPeriodMs;
931 }
932
933 // Send a regular video packet again.
934 capture_time_ms = fake_clock_.TimeInMilliseconds();
danilchapb6f1fb52016-10-19 06:11:39 -0700935 packet = BuildRtpPacket(kPayload, kMarkerBit, timestamp, capture_time_ms);
936 packet_size = packet->size();
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000937
brandtr9dfff292016-11-14 05:14:50 -0800938 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kNormalPriority,
939 kSsrc, seq_num, _, _, _));
terelius5d332ac2016-01-14 14:37:39 -0800940
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000941 // Packet should be stored in a send bucket.
danilchapb6f1fb52016-10-19 06:11:39 -0700942 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
943 kAllowRetransmission,
Sergey Ulanov525df3f2016-08-02 17:46:41 -0700944 RtpPacketSender::kNormalPriority));
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000945
brandtr9dfff292016-11-14 05:14:50 -0800946 rtp_sender_->TimeToSendPacket(kSsrc, seq_num, capture_time_ms, false,
philipel8aadd502017-02-23 02:56:13 -0800947 PacedPacketInfo());
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000948 // Process send bucket.
danilchap12ba1862016-10-26 02:41:55 -0700949 EXPECT_EQ(++total_packets_sent, transport_.packets_sent());
950 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
951 transport_.last_sent_packet().GetHeader(&rtp_header);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000952
953 // Verify sequence number and timestamp.
954 EXPECT_EQ(seq_num, rtp_header.sequenceNumber);
955 EXPECT_EQ(timestamp, rtp_header.timestamp);
956 // Verify transmission time offset. This packet is sent without delay.
957 EXPECT_EQ(0, rtp_header.extension.transmissionTimeOffset);
958 uint64_t expected_send_time =
959 ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds());
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000960 EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime);
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000961}
pbos@webrtc.org8911ce42013-03-18 16:39:03 +0000962
minyue3a407ee2017-04-03 01:10:33 -0700963TEST_P(RtpSenderTest, OnSendPacketUpdated) {
stefana23fc622016-07-28 07:56:38 -0700964 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
965 kRtpExtensionTransportSequenceNumber,
966 kTransportSequenceNumberExtensionId));
asapersson35151f32016-05-02 23:44:01 -0700967 rtp_sender_->SetStorePacketsStatus(true, 10);
968
969 EXPECT_CALL(send_packet_observer_,
970 OnSendPacket(kTransportSequenceNumber, _, _))
971 .Times(1);
972 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
973 .WillOnce(testing::Return(kTransportSequenceNumber));
brandtr9dfff292016-11-14 05:14:50 -0800974 EXPECT_CALL(mock_paced_sender_, InsertPacket(_, kSsrc, kSeqNum, _, _, _))
975 .Times(1);
asapersson35151f32016-05-02 23:44:01 -0700976
977 SendGenericPayload(); // Packet passed to pacer.
978 const bool kIsRetransmit = false;
brandtr9dfff292016-11-14 05:14:50 -0800979 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum,
980 fake_clock_.TimeInMilliseconds(), kIsRetransmit,
philipel8aadd502017-02-23 02:56:13 -0800981 PacedPacketInfo());
danilchap12ba1862016-10-26 02:41:55 -0700982 EXPECT_EQ(1, transport_.packets_sent());
asapersson35151f32016-05-02 23:44:01 -0700983}
984
minyue3a407ee2017-04-03 01:10:33 -0700985TEST_P(RtpSenderTest, OnSendPacketNotUpdatedForRetransmits) {
stefana23fc622016-07-28 07:56:38 -0700986 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
987 kRtpExtensionTransportSequenceNumber,
988 kTransportSequenceNumberExtensionId));
asapersson35151f32016-05-02 23:44:01 -0700989 rtp_sender_->SetStorePacketsStatus(true, 10);
990
991 EXPECT_CALL(send_packet_observer_, OnSendPacket(_, _, _)).Times(0);
992 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
993 .WillOnce(testing::Return(kTransportSequenceNumber));
brandtr9dfff292016-11-14 05:14:50 -0800994 EXPECT_CALL(mock_paced_sender_, InsertPacket(_, kSsrc, kSeqNum, _, _, _))
995 .Times(1);
asapersson35151f32016-05-02 23:44:01 -0700996
997 SendGenericPayload(); // Packet passed to pacer.
998 const bool kIsRetransmit = true;
brandtr9dfff292016-11-14 05:14:50 -0800999 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum,
1000 fake_clock_.TimeInMilliseconds(), kIsRetransmit,
philipel8aadd502017-02-23 02:56:13 -08001001 PacedPacketInfo());
danilchap12ba1862016-10-26 02:41:55 -07001002 EXPECT_EQ(1, transport_.packets_sent());
Petter Strandmark26bc6692018-05-29 08:43:35 +02001003 EXPECT_TRUE(transport_.last_options_.is_retransmit);
asapersson35151f32016-05-02 23:44:01 -07001004}
1005
minyue3a407ee2017-04-03 01:10:33 -07001006TEST_P(RtpSenderTest, OnSendPacketNotUpdatedWithoutSeqNumAllocator) {
asapersson35151f32016-05-02 23:44:01 -07001007 rtp_sender_.reset(new RTPSender(
brandtrdbdb3f12016-11-10 05:04:48 -08001008 false, &fake_clock_, &transport_, &mock_paced_sender_, nullptr,
asapersson35151f32016-05-02 23:44:01 -07001009 nullptr /* TransportSequenceNumberAllocator */, nullptr, nullptr, nullptr,
michaelt4da30442016-11-17 01:38:43 -08001010 nullptr, nullptr, &send_packet_observer_, &retransmission_rate_limiter_,
Johannes Kron9190b822018-10-29 11:22:05 +01001011 nullptr, false, nullptr, false, false));
brandtr9dfff292016-11-14 05:14:50 -08001012 rtp_sender_->SetSequenceNumber(kSeqNum);
1013 rtp_sender_->SetSSRC(kSsrc);
stefana23fc622016-07-28 07:56:38 -07001014 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
1015 kRtpExtensionTransportSequenceNumber,
1016 kTransportSequenceNumberExtensionId));
asapersson35151f32016-05-02 23:44:01 -07001017 rtp_sender_->SetSequenceNumber(kSeqNum);
1018 rtp_sender_->SetStorePacketsStatus(true, 10);
1019
1020 EXPECT_CALL(send_packet_observer_, OnSendPacket(_, _, _)).Times(0);
brandtr9dfff292016-11-14 05:14:50 -08001021 EXPECT_CALL(mock_paced_sender_, InsertPacket(_, kSsrc, kSeqNum, _, _, _))
1022 .Times(1);
asapersson35151f32016-05-02 23:44:01 -07001023
1024 SendGenericPayload(); // Packet passed to pacer.
1025 const bool kIsRetransmit = false;
brandtr9dfff292016-11-14 05:14:50 -08001026 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum,
1027 fake_clock_.TimeInMilliseconds(), kIsRetransmit,
philipel8aadd502017-02-23 02:56:13 -08001028 PacedPacketInfo());
danilchap12ba1862016-10-26 02:41:55 -07001029 EXPECT_EQ(1, transport_.packets_sent());
asapersson35151f32016-05-02 23:44:01 -07001030}
1031
minyue3a407ee2017-04-03 01:10:33 -07001032TEST_P(RtpSenderTest, SendRedundantPayloads) {
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +00001033 MockTransport transport;
terelius429c3452016-01-21 05:42:04 -08001034 rtp_sender_.reset(new RTPSender(
asapersson35151f32016-05-02 23:44:01 -07001035 false, &fake_clock_, &transport, &mock_paced_sender_, nullptr, nullptr,
brandtrdbdb3f12016-11-10 05:04:48 -08001036 nullptr, nullptr, nullptr, nullptr, &mock_rtc_event_log_, nullptr,
Johannes Kron9190b822018-10-29 11:22:05 +01001037 &retransmission_rate_limiter_, nullptr, false, nullptr, false, false));
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +00001038 rtp_sender_->SetSequenceNumber(kSeqNum);
brandtr9dfff292016-11-14 05:14:50 -08001039 rtp_sender_->SetSSRC(kSsrc);
Shao Changbine62202f2015-04-21 20:24:50 +08001040 rtp_sender_->SetRtxPayloadType(kRtxPayload, kPayload);
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +00001041
1042 uint16_t seq_num = kSeqNum;
1043 rtp_sender_->SetStorePacketsStatus(true, 10);
wu@webrtc.orgebdb0e32014-03-06 23:49:08 +00001044 int32_t rtp_header_len = kRtpHeaderSize;
danilchap162abd32015-12-10 02:39:40 -08001045 EXPECT_EQ(
1046 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
1047 kAbsoluteSendTimeExtensionId));
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +00001048 rtp_header_len += 4; // 4 bytes extension.
1049 rtp_header_len += 4; // 4 extra bytes common to all extension headers.
1050
pbos@webrtc.org0b0c2412015-01-13 14:15:15 +00001051 rtp_sender_->SetRtxStatus(kRtxRetransmitted | kRtxRedundantPayloads);
stefan@webrtc.orgef927552014-06-05 08:25:29 +00001052 rtp_sender_->SetRtxSsrc(1234);
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +00001053
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +00001054 const size_t kNumPayloadSizes = 10;
danilchap162abd32015-12-10 02:39:40 -08001055 const size_t kPayloadSizes[kNumPayloadSizes] = {500, 550, 600, 650, 700,
1056 750, 800, 850, 900, 950};
terelius5d332ac2016-01-14 14:37:39 -08001057 // Expect all packets go through the pacer.
1058 EXPECT_CALL(mock_paced_sender_,
brandtr9dfff292016-11-14 05:14:50 -08001059 InsertPacket(RtpPacketSender::kNormalPriority, kSsrc, _, _, _, _))
terelius5d332ac2016-01-14 14:37:39 -08001060 .Times(kNumPayloadSizes);
Elad Alon4a87e1c2017-10-03 16:11:34 +02001061 EXPECT_CALL(mock_rtc_event_log_,
1062 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
terelius429c3452016-01-21 05:42:04 -08001063 .Times(kNumPayloadSizes);
1064
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +00001065 // Send 10 packets of increasing size.
1066 for (size_t i = 0; i < kNumPayloadSizes; ++i) {
1067 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
stefan1d8a5062015-10-02 03:39:33 -07001068 EXPECT_CALL(transport, SendRtp(_, _, _)).WillOnce(testing::Return(true));
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +00001069 SendPacket(capture_time_ms, kPayloadSizes[i]);
brandtr9dfff292016-11-14 05:14:50 -08001070 rtp_sender_->TimeToSendPacket(kSsrc, seq_num++, capture_time_ms, false,
philipel8aadd502017-02-23 02:56:13 -08001071 PacedPacketInfo());
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +00001072 fake_clock_.AdvanceTimeMilliseconds(33);
1073 }
terelius429c3452016-01-21 05:42:04 -08001074
Elad Alon4a87e1c2017-10-03 16:11:34 +02001075 EXPECT_CALL(mock_rtc_event_log_,
1076 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
terelius429c3452016-01-21 05:42:04 -08001077 .Times(::testing::AtLeast(4));
1078
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +00001079 // The amount of padding to send it too small to send a payload packet.
stefan1d8a5062015-10-02 03:39:33 -07001080 EXPECT_CALL(transport, SendRtp(_, kMaxPaddingSize + rtp_header_len, _))
pbos2d566682015-09-28 09:59:31 -07001081 .WillOnce(testing::Return(true));
philipela1ed0b32016-06-01 06:31:17 -07001082 EXPECT_EQ(kMaxPaddingSize,
philipel8aadd502017-02-23 02:56:13 -08001083 rtp_sender_->TimeToSendPadding(49, PacedPacketInfo()));
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +00001084
Petter Strandmark26bc6692018-05-29 08:43:35 +02001085 PacketOptions options;
Peter Boströmac547a62015-09-17 23:03:57 +02001086 EXPECT_CALL(transport,
stefan1d8a5062015-10-02 03:39:33 -07001087 SendRtp(_, kPayloadSizes[0] + rtp_header_len + kRtxHeaderSize, _))
Yves Gerey665174f2018-06-19 15:03:05 +02001088 .WillOnce(
1089 testing::DoAll(testing::SaveArg<2>(&options), testing::Return(true)));
philipela1ed0b32016-06-01 06:31:17 -07001090 EXPECT_EQ(kPayloadSizes[0],
philipel8aadd502017-02-23 02:56:13 -08001091 rtp_sender_->TimeToSendPadding(500, PacedPacketInfo()));
Petter Strandmark26bc6692018-05-29 08:43:35 +02001092 EXPECT_TRUE(options.is_retransmit);
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +00001093
Yves Gerey665174f2018-06-19 15:03:05 +02001094 EXPECT_CALL(transport, SendRtp(_,
1095 kPayloadSizes[kNumPayloadSizes - 1] +
1096 rtp_header_len + kRtxHeaderSize,
stefan1d8a5062015-10-02 03:39:33 -07001097 _))
pbos2d566682015-09-28 09:59:31 -07001098 .WillOnce(testing::Return(true));
Petter Strandmark26bc6692018-05-29 08:43:35 +02001099
1100 options.is_retransmit = false;
stefan1d8a5062015-10-02 03:39:33 -07001101 EXPECT_CALL(transport, SendRtp(_, kMaxPaddingSize + rtp_header_len, _))
Yves Gerey665174f2018-06-19 15:03:05 +02001102 .WillOnce(
1103 testing::DoAll(testing::SaveArg<2>(&options), testing::Return(true)));
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +00001104 EXPECT_EQ(kPayloadSizes[kNumPayloadSizes - 1] + kMaxPaddingSize,
philipel8aadd502017-02-23 02:56:13 -08001105 rtp_sender_->TimeToSendPadding(999, PacedPacketInfo()));
Petter Strandmark26bc6692018-05-29 08:43:35 +02001106 EXPECT_FALSE(options.is_retransmit);
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +00001107}
1108
minyue3a407ee2017-04-03 01:10:33 -07001109TEST_P(RtpSenderTestWithoutPacer, SendGenericVideo) {
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001110 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
1111 const uint8_t payload_type = 127;
1112 ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 90000,
1113 0, 1500));
1114 uint8_t payload[] = {47, 11, 32, 93, 89};
1115
1116 // Send keyframe
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001117 RTPVideoHeader video_header;
spranga8ae6f22017-09-04 07:23:56 -07001118 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
1119 kVideoFrameKey, payload_type, 1234, 4321, payload, sizeof(payload),
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001120 nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001121
danilchap96c15872016-11-21 01:35:29 -08001122 auto sent_payload = transport_.last_sent_packet().payload();
1123 uint8_t generic_header = sent_payload[0];
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001124 EXPECT_TRUE(generic_header & RtpFormatVideoGeneric::kKeyFrameBit);
1125 EXPECT_TRUE(generic_header & RtpFormatVideoGeneric::kFirstPacketBit);
danilchap96c15872016-11-21 01:35:29 -08001126 EXPECT_THAT(sent_payload.subview(1), ElementsAreArray(payload));
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001127
1128 // Send delta frame
1129 payload[0] = 13;
1130 payload[1] = 42;
1131 payload[4] = 13;
1132
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001133 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
1134 kVideoFrameDelta, payload_type, 1234, 4321, payload, sizeof(payload),
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001135 nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001136
danilchap96c15872016-11-21 01:35:29 -08001137 sent_payload = transport_.last_sent_packet().payload();
1138 generic_header = sent_payload[0];
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001139 EXPECT_FALSE(generic_header & RtpFormatVideoGeneric::kKeyFrameBit);
1140 EXPECT_TRUE(generic_header & RtpFormatVideoGeneric::kFirstPacketBit);
danilchap96c15872016-11-21 01:35:29 -08001141 EXPECT_THAT(sent_payload.subview(1), ElementsAreArray(payload));
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001142}
1143
minyue3a407ee2017-04-03 01:10:33 -07001144TEST_P(RtpSenderTest, SendFlexfecPackets) {
brandtrdbdb3f12016-11-10 05:04:48 -08001145 constexpr int kMediaPayloadType = 127;
1146 constexpr int kFlexfecPayloadType = 118;
1147 constexpr uint32_t kMediaSsrc = 1234;
1148 constexpr uint32_t kFlexfecSsrc = 5678;
Steve Antonf0482ea2018-04-09 13:33:52 -07001149 const char kNoMid[] = "";
brandtrdbdb3f12016-11-10 05:04:48 -08001150 const std::vector<RtpExtension> kNoRtpExtensions;
erikvarga27883732017-05-17 05:08:38 -07001151 const std::vector<RtpExtensionSize> kNoRtpExtensionSizes;
brandtrdbdb3f12016-11-10 05:04:48 -08001152 FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexfecSsrc, kMediaSsrc,
Steve Antonf0482ea2018-04-09 13:33:52 -07001153 kNoMid, kNoRtpExtensions, kNoRtpExtensionSizes,
brandtr48d21a22017-05-30 02:32:12 -07001154 nullptr /* rtp_state */, &fake_clock_);
brandtrdbdb3f12016-11-10 05:04:48 -08001155
1156 // Reset |rtp_sender_| to use FlexFEC.
michaelt4da30442016-11-17 01:38:43 -08001157 rtp_sender_.reset(new RTPSender(
1158 false, &fake_clock_, &transport_, &mock_paced_sender_, &flexfec_sender,
1159 &seq_num_allocator_, nullptr, nullptr, nullptr, nullptr,
1160 &mock_rtc_event_log_, &send_packet_observer_,
Johannes Kron9190b822018-10-29 11:22:05 +01001161 &retransmission_rate_limiter_, nullptr, false, nullptr, false, false));
brandtrdbdb3f12016-11-10 05:04:48 -08001162 rtp_sender_->SetSSRC(kMediaSsrc);
1163 rtp_sender_->SetSequenceNumber(kSeqNum);
brandtrdbdb3f12016-11-10 05:04:48 -08001164 rtp_sender_->SetStorePacketsStatus(true, 10);
1165
1166 // Parameters selected to generate a single FEC packet per media packet.
1167 FecProtectionParams params;
1168 params.fec_rate = 15;
1169 params.max_fec_frames = 1;
1170 params.fec_mask_type = kFecMaskRandom;
1171 rtp_sender_->SetFecParameters(params, params);
1172
brandtr9dfff292016-11-14 05:14:50 -08001173 EXPECT_CALL(mock_paced_sender_,
1174 InsertPacket(RtpPacketSender::kLowPriority, kMediaSsrc, kSeqNum,
1175 _, _, false));
1176 uint16_t flexfec_seq_num;
brandtrdbdb3f12016-11-10 05:04:48 -08001177 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kLowPriority,
brandtr9dfff292016-11-14 05:14:50 -08001178 kFlexfecSsrc, _, _, _, false))
1179 .WillOnce(testing::SaveArg<2>(&flexfec_seq_num));
brandtrdbdb3f12016-11-10 05:04:48 -08001180 SendGenericPayload();
Elad Alon4a87e1c2017-10-03 16:11:34 +02001181 EXPECT_CALL(mock_rtc_event_log_,
1182 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
1183 .Times(2);
philipel8aadd502017-02-23 02:56:13 -08001184 EXPECT_TRUE(rtp_sender_->TimeToSendPacket(kMediaSsrc, kSeqNum,
1185 fake_clock_.TimeInMilliseconds(),
1186 false, PacedPacketInfo()));
brandtr9dfff292016-11-14 05:14:50 -08001187 EXPECT_TRUE(rtp_sender_->TimeToSendPacket(kFlexfecSsrc, flexfec_seq_num,
1188 fake_clock_.TimeInMilliseconds(),
philipel8aadd502017-02-23 02:56:13 -08001189 false, PacedPacketInfo()));
brandtr9dfff292016-11-14 05:14:50 -08001190 ASSERT_EQ(2, transport_.packets_sent());
brandtrdbdb3f12016-11-10 05:04:48 -08001191 const RtpPacketReceived& media_packet = transport_.sent_packets_[0];
1192 EXPECT_EQ(kMediaPayloadType, media_packet.PayloadType());
brandtr9dfff292016-11-14 05:14:50 -08001193 EXPECT_EQ(kSeqNum, media_packet.SequenceNumber());
brandtrdbdb3f12016-11-10 05:04:48 -08001194 EXPECT_EQ(kMediaSsrc, media_packet.Ssrc());
brandtr9dfff292016-11-14 05:14:50 -08001195 const RtpPacketReceived& flexfec_packet = transport_.sent_packets_[1];
1196 EXPECT_EQ(kFlexfecPayloadType, flexfec_packet.PayloadType());
1197 EXPECT_EQ(flexfec_seq_num, flexfec_packet.SequenceNumber());
1198 EXPECT_EQ(kFlexfecSsrc, flexfec_packet.Ssrc());
brandtrdbdb3f12016-11-10 05:04:48 -08001199}
1200
ilnik10894992017-06-21 08:23:19 -07001201// TODO(ilnik): because of webrtc:7859. Once FEC moved below pacer, this test
1202// should be removed.
1203TEST_P(RtpSenderTest, NoFlexfecForTimingFrames) {
1204 constexpr int kMediaPayloadType = 127;
1205 constexpr int kFlexfecPayloadType = 118;
1206 constexpr uint32_t kMediaSsrc = 1234;
1207 constexpr uint32_t kFlexfecSsrc = 5678;
Steve Antonf0482ea2018-04-09 13:33:52 -07001208 const char kNoMid[] = "";
ilnik10894992017-06-21 08:23:19 -07001209 const std::vector<RtpExtension> kNoRtpExtensions;
1210 const std::vector<RtpExtensionSize> kNoRtpExtensionSizes;
ilnike4350192017-06-29 02:27:44 -07001211
ilnik10894992017-06-21 08:23:19 -07001212 FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexfecSsrc, kMediaSsrc,
Steve Antonf0482ea2018-04-09 13:33:52 -07001213 kNoMid, kNoRtpExtensions, kNoRtpExtensionSizes,
ilnik10894992017-06-21 08:23:19 -07001214 nullptr /* rtp_state */, &fake_clock_);
1215
1216 // Reset |rtp_sender_| to use FlexFEC.
1217 rtp_sender_.reset(new RTPSender(
1218 false, &fake_clock_, &transport_, &mock_paced_sender_, &flexfec_sender,
1219 &seq_num_allocator_, nullptr, nullptr, nullptr, nullptr,
1220 &mock_rtc_event_log_, &send_packet_observer_,
Johannes Kron9190b822018-10-29 11:22:05 +01001221 &retransmission_rate_limiter_, nullptr, false, nullptr, false, false));
ilnik10894992017-06-21 08:23:19 -07001222 rtp_sender_->SetSSRC(kMediaSsrc);
1223 rtp_sender_->SetSequenceNumber(kSeqNum);
ilnik10894992017-06-21 08:23:19 -07001224 rtp_sender_->SetStorePacketsStatus(true, 10);
1225
ilnike4350192017-06-29 02:27:44 -07001226 // Need extension to be registered for timing frames to be sent.
1227 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
1228 kRtpExtensionVideoTiming, kVideoTimingExtensionId));
1229
ilnik10894992017-06-21 08:23:19 -07001230 // Parameters selected to generate a single FEC packet per media packet.
1231 FecProtectionParams params;
1232 params.fec_rate = 15;
1233 params.max_fec_frames = 1;
1234 params.fec_mask_type = kFecMaskRandom;
1235 rtp_sender_->SetFecParameters(params, params);
1236
1237 EXPECT_CALL(mock_paced_sender_,
1238 InsertPacket(RtpPacketSender::kLowPriority, kMediaSsrc, kSeqNum,
1239 _, _, false));
1240 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kLowPriority,
1241 kFlexfecSsrc, _, _, _, false))
1242 .Times(0); // Not called because packet should not be protected.
1243
1244 const uint32_t kTimestamp = 1234;
1245 const uint8_t kPayloadType = 127;
1246 const int64_t kCaptureTimeMs = fake_clock_.TimeInMilliseconds();
1247 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
1248 EXPECT_EQ(0, rtp_sender_->RegisterPayload(payload_name, kPayloadType, 90000,
1249 0, 1500));
1250 RTPVideoHeader video_header;
Ilya Nikolaevskiyb6c462d2018-06-05 15:21:32 +02001251 video_header.video_timing.flags = VideoSendTiming::kTriggeredByTimer;
ilnik10894992017-06-21 08:23:19 -07001252 EXPECT_TRUE(rtp_sender_->SendOutgoingData(
1253 kVideoFrameKey, kPayloadType, kTimestamp, kCaptureTimeMs, kPayloadData,
spranga8ae6f22017-09-04 07:23:56 -07001254 sizeof(kPayloadData), nullptr, &video_header, nullptr,
1255 kDefaultExpectedRetransmissionTimeMs));
ilnik10894992017-06-21 08:23:19 -07001256
Elad Alon4a87e1c2017-10-03 16:11:34 +02001257 EXPECT_CALL(mock_rtc_event_log_,
1258 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
1259 .Times(1);
ilnik10894992017-06-21 08:23:19 -07001260 EXPECT_TRUE(rtp_sender_->TimeToSendPacket(kMediaSsrc, kSeqNum,
1261 fake_clock_.TimeInMilliseconds(),
1262 false, PacedPacketInfo()));
1263 ASSERT_EQ(1, transport_.packets_sent());
1264 const RtpPacketReceived& media_packet = transport_.sent_packets_[0];
1265 EXPECT_EQ(kMediaPayloadType, media_packet.PayloadType());
1266 EXPECT_EQ(kSeqNum, media_packet.SequenceNumber());
1267 EXPECT_EQ(kMediaSsrc, media_packet.Ssrc());
1268
1269 // Now try to send not a timing frame.
1270 uint16_t flexfec_seq_num;
1271 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kLowPriority,
1272 kFlexfecSsrc, _, _, _, false))
1273 .WillOnce(testing::SaveArg<2>(&flexfec_seq_num));
1274 EXPECT_CALL(mock_paced_sender_,
1275 InsertPacket(RtpPacketSender::kLowPriority, kMediaSsrc,
1276 kSeqNum + 1, _, _, false));
Ilya Nikolaevskiyb6c462d2018-06-05 15:21:32 +02001277 video_header.video_timing.flags = VideoSendTiming::kInvalid;
ilnik10894992017-06-21 08:23:19 -07001278 EXPECT_TRUE(rtp_sender_->SendOutgoingData(
1279 kVideoFrameKey, kPayloadType, kTimestamp + 1, kCaptureTimeMs + 1,
spranga8ae6f22017-09-04 07:23:56 -07001280 kPayloadData, sizeof(kPayloadData), nullptr, &video_header, nullptr,
1281 kDefaultExpectedRetransmissionTimeMs));
ilnik10894992017-06-21 08:23:19 -07001282
Elad Alon4a87e1c2017-10-03 16:11:34 +02001283 EXPECT_CALL(mock_rtc_event_log_,
1284 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
1285 .Times(2);
ilnik10894992017-06-21 08:23:19 -07001286 EXPECT_TRUE(rtp_sender_->TimeToSendPacket(kMediaSsrc, kSeqNum + 1,
1287 fake_clock_.TimeInMilliseconds(),
1288 false, PacedPacketInfo()));
1289 EXPECT_TRUE(rtp_sender_->TimeToSendPacket(kFlexfecSsrc, flexfec_seq_num,
1290 fake_clock_.TimeInMilliseconds(),
1291 false, PacedPacketInfo()));
1292 ASSERT_EQ(3, transport_.packets_sent());
1293 const RtpPacketReceived& media_packet2 = transport_.sent_packets_[1];
1294 EXPECT_EQ(kMediaPayloadType, media_packet2.PayloadType());
1295 EXPECT_EQ(kSeqNum + 1, media_packet2.SequenceNumber());
1296 EXPECT_EQ(kMediaSsrc, media_packet2.Ssrc());
1297 const RtpPacketReceived& flexfec_packet = transport_.sent_packets_[2];
1298 EXPECT_EQ(kFlexfecPayloadType, flexfec_packet.PayloadType());
1299 EXPECT_EQ(flexfec_seq_num, flexfec_packet.SequenceNumber());
1300 EXPECT_EQ(kFlexfecSsrc, flexfec_packet.Ssrc());
1301}
1302
minyue3a407ee2017-04-03 01:10:33 -07001303TEST_P(RtpSenderTestWithoutPacer, SendFlexfecPackets) {
brandtrdbdb3f12016-11-10 05:04:48 -08001304 constexpr int kMediaPayloadType = 127;
1305 constexpr int kFlexfecPayloadType = 118;
1306 constexpr uint32_t kMediaSsrc = 1234;
1307 constexpr uint32_t kFlexfecSsrc = 5678;
Steve Antonf0482ea2018-04-09 13:33:52 -07001308 const char kNoMid[] = "";
brandtrdbdb3f12016-11-10 05:04:48 -08001309 const std::vector<RtpExtension> kNoRtpExtensions;
erikvarga27883732017-05-17 05:08:38 -07001310 const std::vector<RtpExtensionSize> kNoRtpExtensionSizes;
brandtrdbdb3f12016-11-10 05:04:48 -08001311 FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexfecSsrc, kMediaSsrc,
Steve Antonf0482ea2018-04-09 13:33:52 -07001312 kNoMid, kNoRtpExtensions, kNoRtpExtensionSizes,
brandtr48d21a22017-05-30 02:32:12 -07001313 nullptr /* rtp_state */, &fake_clock_);
brandtrdbdb3f12016-11-10 05:04:48 -08001314
1315 // Reset |rtp_sender_| to use FlexFEC.
Benjamin Wright192eeec2018-10-17 17:27:25 -07001316 rtp_sender_.reset(new RTPSender(
1317 false, &fake_clock_, &transport_, nullptr, &flexfec_sender,
1318 &seq_num_allocator_, nullptr, nullptr, nullptr, nullptr,
1319 &mock_rtc_event_log_, &send_packet_observer_,
Johannes Kron9190b822018-10-29 11:22:05 +01001320 &retransmission_rate_limiter_, nullptr, false, nullptr, false, false));
brandtrdbdb3f12016-11-10 05:04:48 -08001321 rtp_sender_->SetSSRC(kMediaSsrc);
1322 rtp_sender_->SetSequenceNumber(kSeqNum);
brandtrdbdb3f12016-11-10 05:04:48 -08001323
1324 // Parameters selected to generate a single FEC packet per media packet.
1325 FecProtectionParams params;
1326 params.fec_rate = 15;
1327 params.max_fec_frames = 1;
1328 params.fec_mask_type = kFecMaskRandom;
1329 rtp_sender_->SetFecParameters(params, params);
1330
Elad Alon4a87e1c2017-10-03 16:11:34 +02001331 EXPECT_CALL(mock_rtc_event_log_,
1332 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
1333 .Times(2);
brandtrdbdb3f12016-11-10 05:04:48 -08001334 SendGenericPayload();
1335 ASSERT_EQ(2, transport_.packets_sent());
1336 const RtpPacketReceived& media_packet = transport_.sent_packets_[0];
1337 EXPECT_EQ(kMediaPayloadType, media_packet.PayloadType());
1338 EXPECT_EQ(kMediaSsrc, media_packet.Ssrc());
1339 const RtpPacketReceived& flexfec_packet = transport_.sent_packets_[1];
1340 EXPECT_EQ(kFlexfecPayloadType, flexfec_packet.PayloadType());
1341 EXPECT_EQ(kFlexfecSsrc, flexfec_packet.Ssrc());
1342}
1343
Steve Anton296a0ce2018-03-22 15:17:27 -07001344// Test that the MID header extension is included on sent packets when
1345// configured.
1346TEST_P(RtpSenderTestWithoutPacer, MidIncludedOnSentPackets) {
1347 const char kMid[] = "mid";
1348
1349 // Register MID header extension and set the MID for the RTPSender.
1350 rtp_sender_->SetSendingMediaStatus(false);
1351 rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionMid, kMidExtensionId);
1352 rtp_sender_->SetMid(kMid);
1353 rtp_sender_->SetSendingMediaStatus(true);
1354
1355 // Send a couple packets.
1356 SendGenericPayload();
1357 SendGenericPayload();
1358
1359 // Expect both packets to have the MID set.
1360 ASSERT_EQ(2u, transport_.sent_packets_.size());
1361 for (const RtpPacketReceived& packet : transport_.sent_packets_) {
1362 std::string mid;
1363 ASSERT_TRUE(packet.GetExtension<RtpMid>(&mid));
1364 EXPECT_EQ(kMid, mid);
1365 }
1366}
1367
minyue3a407ee2017-04-03 01:10:33 -07001368TEST_P(RtpSenderTest, FecOverheadRate) {
brandtr81eab612017-01-24 04:06:09 -08001369 constexpr int kFlexfecPayloadType = 118;
1370 constexpr uint32_t kMediaSsrc = 1234;
1371 constexpr uint32_t kFlexfecSsrc = 5678;
Steve Antonf0482ea2018-04-09 13:33:52 -07001372 const char kNoMid[] = "";
brandtr81eab612017-01-24 04:06:09 -08001373 const std::vector<RtpExtension> kNoRtpExtensions;
erikvarga27883732017-05-17 05:08:38 -07001374 const std::vector<RtpExtensionSize> kNoRtpExtensionSizes;
brandtr81eab612017-01-24 04:06:09 -08001375 FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexfecSsrc, kMediaSsrc,
Steve Antonf0482ea2018-04-09 13:33:52 -07001376 kNoMid, kNoRtpExtensions, kNoRtpExtensionSizes,
brandtr48d21a22017-05-30 02:32:12 -07001377 nullptr /* rtp_state */, &fake_clock_);
brandtr81eab612017-01-24 04:06:09 -08001378
1379 // Reset |rtp_sender_| to use FlexFEC.
1380 rtp_sender_.reset(new RTPSender(
1381 false, &fake_clock_, &transport_, &mock_paced_sender_, &flexfec_sender,
1382 &seq_num_allocator_, nullptr, nullptr, nullptr, nullptr,
1383 &mock_rtc_event_log_, &send_packet_observer_,
Johannes Kron9190b822018-10-29 11:22:05 +01001384 &retransmission_rate_limiter_, nullptr, false, nullptr, false, false));
brandtr81eab612017-01-24 04:06:09 -08001385 rtp_sender_->SetSSRC(kMediaSsrc);
1386 rtp_sender_->SetSequenceNumber(kSeqNum);
brandtr81eab612017-01-24 04:06:09 -08001387
1388 // Parameters selected to generate a single FEC packet per media packet.
1389 FecProtectionParams params;
1390 params.fec_rate = 15;
1391 params.max_fec_frames = 1;
1392 params.fec_mask_type = kFecMaskRandom;
1393 rtp_sender_->SetFecParameters(params, params);
1394
1395 constexpr size_t kNumMediaPackets = 10;
1396 constexpr size_t kNumFecPackets = kNumMediaPackets;
1397 constexpr int64_t kTimeBetweenPacketsMs = 10;
1398 EXPECT_CALL(mock_paced_sender_, InsertPacket(_, _, _, _, _, false))
1399 .Times(kNumMediaPackets + kNumFecPackets);
1400 for (size_t i = 0; i < kNumMediaPackets; ++i) {
1401 SendGenericPayload();
1402 fake_clock_.AdvanceTimeMilliseconds(kTimeBetweenPacketsMs);
1403 }
1404 constexpr size_t kRtpHeaderLength = 12;
1405 constexpr size_t kFlexfecHeaderLength = 20;
1406 constexpr size_t kGenericCodecHeaderLength = 1;
1407 constexpr size_t kPayloadLength = sizeof(kPayloadData);
1408 constexpr size_t kPacketLength = kRtpHeaderLength + kFlexfecHeaderLength +
1409 kGenericCodecHeaderLength + kPayloadLength;
1410 EXPECT_NEAR(kNumFecPackets * kPacketLength * 8 /
1411 (kNumFecPackets * kTimeBetweenPacketsMs / 1000.0f),
1412 rtp_sender_->FecOverheadRate(), 500);
1413}
1414
minyue3a407ee2017-04-03 01:10:33 -07001415TEST_P(RtpSenderTest, FrameCountCallbacks) {
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001416 class TestCallback : public FrameCountObserver {
1417 public:
pbos@webrtc.orgce4e9a32014-12-18 13:50:16 +00001418 TestCallback() : FrameCountObserver(), num_calls_(0), ssrc_(0) {}
Danil Chapovalovdd7e2842018-03-09 15:37:03 +00001419 ~TestCallback() override = default;
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001420
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00001421 void FrameCountUpdated(const FrameCounts& frame_counts,
1422 uint32_t ssrc) override {
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001423 ++num_calls_;
1424 ssrc_ = ssrc;
pbos@webrtc.orgce4e9a32014-12-18 13:50:16 +00001425 frame_counts_ = frame_counts;
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001426 }
1427
1428 uint32_t num_calls_;
1429 uint32_t ssrc_;
pbos@webrtc.orgce4e9a32014-12-18 13:50:16 +00001430 FrameCounts frame_counts_;
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001431 } callback;
1432
Erik Språng7b52f102018-02-07 14:37:37 +01001433 rtp_sender_.reset(new RTPSender(
1434 false, &fake_clock_, &transport_, &mock_paced_sender_, nullptr, nullptr,
1435 nullptr, nullptr, &callback, nullptr, nullptr, nullptr,
Johannes Kron9190b822018-10-29 11:22:05 +01001436 &retransmission_rate_limiter_, nullptr, false, nullptr, false, false));
nisse7d59f6b2017-02-21 03:40:24 -08001437 rtp_sender_->SetSSRC(kSsrc);
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001438 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
1439 const uint8_t payload_type = 127;
1440 ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 90000,
1441 0, 1500));
1442 uint8_t payload[] = {47, 11, 32, 93, 89};
1443 rtp_sender_->SetStorePacketsStatus(true, 1);
1444 uint32_t ssrc = rtp_sender_->SSRC();
1445
terelius5d332ac2016-01-14 14:37:39 -08001446 EXPECT_CALL(mock_paced_sender_, InsertPacket(_, _, _, _, _, _))
1447 .Times(::testing::AtLeast(2));
1448
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001449 RTPVideoHeader video_header;
spranga8ae6f22017-09-04 07:23:56 -07001450 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
1451 kVideoFrameKey, payload_type, 1234, 4321, payload, sizeof(payload),
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001452 nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001453
1454 EXPECT_EQ(1U, callback.num_calls_);
1455 EXPECT_EQ(ssrc, callback.ssrc_);
pbos@webrtc.orgce4e9a32014-12-18 13:50:16 +00001456 EXPECT_EQ(1, callback.frame_counts_.key_frames);
1457 EXPECT_EQ(0, callback.frame_counts_.delta_frames);
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001458
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001459 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
1460 kVideoFrameDelta, payload_type, 1234, 4321, payload, sizeof(payload),
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001461 nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001462
1463 EXPECT_EQ(2U, callback.num_calls_);
1464 EXPECT_EQ(ssrc, callback.ssrc_);
pbos@webrtc.orgce4e9a32014-12-18 13:50:16 +00001465 EXPECT_EQ(1, callback.frame_counts_.key_frames);
1466 EXPECT_EQ(1, callback.frame_counts_.delta_frames);
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001467
andresp@webrtc.org8f151212014-07-10 09:39:23 +00001468 rtp_sender_.reset();
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001469}
1470
minyue3a407ee2017-04-03 01:10:33 -07001471TEST_P(RtpSenderTest, BitrateCallbacks) {
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001472 class TestCallback : public BitrateStatisticsObserver {
1473 public:
sprangcd349d92016-07-13 09:11:28 -07001474 TestCallback()
1475 : BitrateStatisticsObserver(),
1476 num_calls_(0),
1477 ssrc_(0),
1478 total_bitrate_(0),
1479 retransmit_bitrate_(0) {}
Danil Chapovalovdd7e2842018-03-09 15:37:03 +00001480 ~TestCallback() override = default;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001481
sprangcd349d92016-07-13 09:11:28 -07001482 void Notify(uint32_t total_bitrate,
1483 uint32_t retransmit_bitrate,
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00001484 uint32_t ssrc) override {
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001485 ++num_calls_;
1486 ssrc_ = ssrc;
sprangcd349d92016-07-13 09:11:28 -07001487 total_bitrate_ = total_bitrate;
1488 retransmit_bitrate_ = retransmit_bitrate;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001489 }
1490
1491 uint32_t num_calls_;
1492 uint32_t ssrc_;
sprangcd349d92016-07-13 09:11:28 -07001493 uint32_t total_bitrate_;
1494 uint32_t retransmit_bitrate_;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001495 } callback;
Benjamin Wright192eeec2018-10-17 17:27:25 -07001496 rtp_sender_.reset(new RTPSender(
1497 false, &fake_clock_, &transport_, nullptr, nullptr, nullptr, nullptr,
1498 &callback, nullptr, nullptr, nullptr, nullptr,
Johannes Kron9190b822018-10-29 11:22:05 +01001499 &retransmission_rate_limiter_, nullptr, false, nullptr, false, false));
nisse7d59f6b2017-02-21 03:40:24 -08001500 rtp_sender_->SetSSRC(kSsrc);
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001501
sprangcd349d92016-07-13 09:11:28 -07001502 // Simulate kNumPackets sent with kPacketInterval ms intervals, with the
1503 // number of packets selected so that we fill (but don't overflow) the one
1504 // second averaging window.
1505 const uint32_t kWindowSizeMs = 1000;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001506 const uint32_t kPacketInterval = 20;
sprangcd349d92016-07-13 09:11:28 -07001507 const uint32_t kNumPackets =
1508 (kWindowSizeMs - kPacketInterval) / kPacketInterval;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001509 // Overhead = 12 bytes RTP header + 1 byte generic header.
1510 const uint32_t kPacketOverhead = 13;
1511
1512 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
1513 const uint8_t payload_type = 127;
danilchap162abd32015-12-10 02:39:40 -08001514 ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 90000,
1515 0, 1500));
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001516 uint8_t payload[] = {47, 11, 32, 93, 89};
1517 rtp_sender_->SetStorePacketsStatus(true, 1);
1518 uint32_t ssrc = rtp_sender_->SSRC();
1519
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001520 // Initial process call so we get a new time window.
1521 rtp_sender_->ProcessBitrate();
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001522
1523 // Send a few frames.
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001524 RTPVideoHeader video_header;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001525 for (uint32_t i = 0; i < kNumPackets; ++i) {
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001526 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
1527 kVideoFrameKey, payload_type, 1234, 4321, payload, sizeof(payload),
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001528 nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001529 fake_clock_.AdvanceTimeMilliseconds(kPacketInterval);
1530 }
1531
1532 rtp_sender_->ProcessBitrate();
1533
stefan@webrtc.org0bae1fa2014-11-05 14:05:29 +00001534 // We get one call for every stats updated, thus two calls since both the
1535 // stream stats and the retransmit stats are updated once.
1536 EXPECT_EQ(2u, callback.num_calls_);
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001537 EXPECT_EQ(ssrc, callback.ssrc_);
sprangcd349d92016-07-13 09:11:28 -07001538 const uint32_t kTotalPacketSize = kPacketOverhead + sizeof(payload);
1539 // Bitrate measured over delta between last and first timestamp, plus one.
1540 const uint32_t kExpectedWindowMs = kNumPackets * kPacketInterval + 1;
1541 const uint32_t kExpectedBitsAccumulated = kTotalPacketSize * kNumPackets * 8;
1542 const uint32_t kExpectedRateBps =
1543 (kExpectedBitsAccumulated * 1000 + (kExpectedWindowMs / 2)) /
1544 kExpectedWindowMs;
1545 EXPECT_EQ(kExpectedRateBps, callback.total_bitrate_);
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001546
andresp@webrtc.orgd11bec42014-07-08 14:32:58 +00001547 rtp_sender_.reset();
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001548}
1549
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001550class RtpSenderAudioTest : public RtpSenderTest {
1551 protected:
1552 RtpSenderAudioTest() {}
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001553
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00001554 void SetUp() override {
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001555 payload_ = kAudioPayload;
Benjamin Wright192eeec2018-10-17 17:27:25 -07001556 rtp_sender_.reset(new RTPSender(
1557 true, &fake_clock_, &transport_, nullptr, nullptr, nullptr, nullptr,
1558 nullptr, nullptr, nullptr, nullptr, nullptr,
Johannes Kron9190b822018-10-29 11:22:05 +01001559 &retransmission_rate_limiter_, nullptr, false, nullptr, false, false));
nisse7d59f6b2017-02-21 03:40:24 -08001560 rtp_sender_->SetSSRC(kSsrc);
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001561 rtp_sender_->SetSequenceNumber(kSeqNum);
1562 }
1563};
1564
minyue3a407ee2017-04-03 01:10:33 -07001565TEST_P(RtpSenderTestWithoutPacer, StreamDataCountersCallbacks) {
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001566 class TestCallback : public StreamDataCountersCallback {
1567 public:
danilchap162abd32015-12-10 02:39:40 -08001568 TestCallback() : StreamDataCountersCallback(), ssrc_(0), counters_() {}
Danil Chapovalovdd7e2842018-03-09 15:37:03 +00001569 ~TestCallback() override = default;
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001570
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00001571 void DataCountersUpdated(const StreamDataCounters& counters,
1572 uint32_t ssrc) override {
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001573 ssrc_ = ssrc;
1574 counters_ = counters;
1575 }
1576
1577 uint32_t ssrc_;
1578 StreamDataCounters counters_;
asapersson@webrtc.org44149392015-02-04 08:34:47 +00001579
1580 void MatchPacketCounter(const RtpPacketCounter& expected,
1581 const RtpPacketCounter& actual) {
1582 EXPECT_EQ(expected.payload_bytes, actual.payload_bytes);
1583 EXPECT_EQ(expected.header_bytes, actual.header_bytes);
1584 EXPECT_EQ(expected.padding_bytes, actual.padding_bytes);
1585 EXPECT_EQ(expected.packets, actual.packets);
1586 }
1587
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001588 void Matches(uint32_t ssrc, const StreamDataCounters& counters) {
1589 EXPECT_EQ(ssrc, ssrc_);
asapersson@webrtc.org44149392015-02-04 08:34:47 +00001590 MatchPacketCounter(counters.transmitted, counters_.transmitted);
1591 MatchPacketCounter(counters.retransmitted, counters_.retransmitted);
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001592 EXPECT_EQ(counters.fec.packets, counters_.fec.packets);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001593 }
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001594 } callback;
1595
1596 const uint8_t kRedPayloadType = 96;
1597 const uint8_t kUlpfecPayloadType = 97;
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001598 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
1599 const uint8_t payload_type = 127;
1600 ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 90000,
1601 0, 1500));
1602 uint8_t payload[] = {47, 11, 32, 93, 89};
1603 rtp_sender_->SetStorePacketsStatus(true, 1);
1604 uint32_t ssrc = rtp_sender_->SSRC();
1605
1606 rtp_sender_->RegisterRtpStatisticsCallback(&callback);
1607
1608 // Send a frame.
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001609 RTPVideoHeader video_header;
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001610 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001611 kVideoFrameKey, payload_type, 1234, 4321, payload, sizeof(payload),
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001612 nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001613 StreamDataCounters expected;
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001614 expected.transmitted.payload_bytes = 6;
1615 expected.transmitted.header_bytes = 12;
1616 expected.transmitted.padding_bytes = 0;
1617 expected.transmitted.packets = 1;
1618 expected.retransmitted.payload_bytes = 0;
1619 expected.retransmitted.header_bytes = 0;
1620 expected.retransmitted.padding_bytes = 0;
1621 expected.retransmitted.packets = 0;
1622 expected.fec.packets = 0;
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001623 callback.Matches(ssrc, expected);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001624
1625 // Retransmit a frame.
1626 uint16_t seqno = rtp_sender_->SequenceNumber() - 1;
Erik Språnga12b1d62018-03-14 12:39:24 +01001627 rtp_sender_->ReSendPacket(seqno);
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001628 expected.transmitted.payload_bytes = 12;
1629 expected.transmitted.header_bytes = 24;
1630 expected.transmitted.packets = 2;
1631 expected.retransmitted.payload_bytes = 6;
1632 expected.retransmitted.header_bytes = 12;
1633 expected.retransmitted.padding_bytes = 0;
1634 expected.retransmitted.packets = 1;
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001635 callback.Matches(ssrc, expected);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001636
1637 // Send padding.
philipel8aadd502017-02-23 02:56:13 -08001638 rtp_sender_->TimeToSendPadding(kMaxPaddingSize, PacedPacketInfo());
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001639 expected.transmitted.payload_bytes = 12;
1640 expected.transmitted.header_bytes = 36;
1641 expected.transmitted.padding_bytes = kMaxPaddingSize;
1642 expected.transmitted.packets = 3;
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001643 callback.Matches(ssrc, expected);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001644
brandtrf1bb4762016-11-07 03:05:06 -08001645 // Send ULPFEC.
1646 rtp_sender_->SetUlpfecConfig(kRedPayloadType, kUlpfecPayloadType);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001647 FecProtectionParams fec_params;
1648 fec_params.fec_mask_type = kFecMaskRandom;
1649 fec_params.fec_rate = 1;
1650 fec_params.max_fec_frames = 1;
brandtr1743a192016-11-07 03:36:05 -08001651 rtp_sender_->SetFecParameters(fec_params, fec_params);
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001652 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001653 kVideoFrameDelta, payload_type, 1234, 4321, payload, sizeof(payload),
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001654 nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001655 expected.transmitted.payload_bytes = 40;
1656 expected.transmitted.header_bytes = 60;
1657 expected.transmitted.packets = 5;
1658 expected.fec.packets = 1;
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001659 callback.Matches(ssrc, expected);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001660
sprang867fb522015-08-03 04:38:41 -07001661 rtp_sender_->RegisterRtpStatisticsCallback(nullptr);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001662}
1663
minyue3a407ee2017-04-03 01:10:33 -07001664TEST_P(RtpSenderAudioTest, SendAudio) {
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001665 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "PAYLOAD_NAME";
1666 const uint8_t payload_type = 127;
1667 ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 48000,
1668 0, 1500));
1669 uint8_t payload[] = {47, 11, 32, 93, 89};
1670
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001671 RTPVideoHeader video_header;
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001672 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001673 kAudioFrameCN, payload_type, 1234, 4321, payload, sizeof(payload),
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001674 nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001675
danilchap96c15872016-11-21 01:35:29 -08001676 auto sent_payload = transport_.last_sent_packet().payload();
1677 EXPECT_THAT(sent_payload, ElementsAreArray(payload));
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001678}
1679
minyue3a407ee2017-04-03 01:10:33 -07001680TEST_P(RtpSenderAudioTest, SendAudioWithAudioLevelExtension) {
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001681 EXPECT_EQ(0, rtp_sender_->SetAudioLevel(kAudioLevel));
danilchap162abd32015-12-10 02:39:40 -08001682 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAudioLevel,
1683 kAudioLevelExtensionId));
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001684
1685 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "PAYLOAD_NAME";
1686 const uint8_t payload_type = 127;
1687 ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 48000,
1688 0, 1500));
1689 uint8_t payload[] = {47, 11, 32, 93, 89};
1690
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001691 RTPVideoHeader video_header;
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001692 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001693 kAudioFrameCN, payload_type, 1234, 4321, payload, sizeof(payload),
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001694 nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001695
danilchap96c15872016-11-21 01:35:29 -08001696 auto sent_payload = transport_.last_sent_packet().payload();
1697 EXPECT_THAT(sent_payload, ElementsAreArray(payload));
danilchap12ba1862016-10-26 02:41:55 -07001698 // Verify AudioLevel extension.
1699 bool voice_activity;
1700 uint8_t audio_level;
1701 EXPECT_TRUE(transport_.last_sent_packet().GetExtension<AudioLevel>(
1702 &voice_activity, &audio_level));
1703 EXPECT_EQ(kAudioLevel, audio_level);
1704 EXPECT_FALSE(voice_activity);
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001705}
1706
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001707// As RFC4733, named telephone events are carried as part of the audio stream
1708// and must use the same sequence number and timestamp base as the regular
1709// audio channel.
1710// This test checks the marker bit for the first packet and the consequent
1711// packets of the same telephone event. Since it is specifically for DTMF
pbos22993e12015-10-19 02:39:06 -07001712// events, ignoring audio packets and sending kEmptyFrame instead of those.
minyue3a407ee2017-04-03 01:10:33 -07001713TEST_P(RtpSenderAudioTest, CheckMarkerBitForTelephoneEvents) {
solenbergffbbcac2016-11-17 05:25:37 -08001714 const char* kDtmfPayloadName = "telephone-event";
1715 const uint32_t kPayloadFrequency = 8000;
1716 const uint8_t kPayloadType = 126;
1717 ASSERT_EQ(0, rtp_sender_->RegisterPayload(kDtmfPayloadName, kPayloadType,
1718 kPayloadFrequency, 0, 0));
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001719 // For Telephone events, payload is not added to the registered payload list,
1720 // it will register only the payload used for audio stream.
1721 // Registering the payload again for audio stream with different payload name.
solenbergffbbcac2016-11-17 05:25:37 -08001722 const char* kPayloadName = "payload_name";
1723 ASSERT_EQ(0, rtp_sender_->RegisterPayload(kPayloadName, kPayloadType,
1724 kPayloadFrequency, 1, 0));
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001725 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
1726 // DTMF event key=9, duration=500 and attenuationdB=10
1727 rtp_sender_->SendTelephoneEvent(9, 500, 10);
1728 // During start, it takes the starting timestamp as last sent timestamp.
1729 // The duration is calculated as the difference of current and last sent
1730 // timestamp. So for first call it will skip since the duration is zero.
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001731 RTPVideoHeader video_header;
spranga8ae6f22017-09-04 07:23:56 -07001732 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
1733 kEmptyFrame, kPayloadType, capture_time_ms, 0, nullptr, 0, nullptr,
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001734 &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001735 // DTMF Sample Length is (Frequency/1000) * Duration.
1736 // So in this case, it is (8000/1000) * 500 = 4000.
1737 // Sending it as two packets.
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001738 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001739 kEmptyFrame, kPayloadType, capture_time_ms + 2000, 0, nullptr, 0, nullptr,
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001740 &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
danilchap12ba1862016-10-26 02:41:55 -07001741
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001742 // Marker Bit should be set to 1 for first packet.
danilchap12ba1862016-10-26 02:41:55 -07001743 EXPECT_TRUE(transport_.last_sent_packet().Marker());
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001744
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001745 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001746 kEmptyFrame, kPayloadType, capture_time_ms + 4000, 0, nullptr, 0, nullptr,
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001747 &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001748 // Marker Bit should be set to 0 for rest of the packets.
danilchap12ba1862016-10-26 02:41:55 -07001749 EXPECT_FALSE(transport_.last_sent_packet().Marker());
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001750}
1751
minyue3a407ee2017-04-03 01:10:33 -07001752TEST_P(RtpSenderTestWithoutPacer, BytesReportedCorrectly) {
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001753 const char* kPayloadName = "GENERIC";
1754 const uint8_t kPayloadType = 127;
1755 rtp_sender_->SetSSRC(1234);
1756 rtp_sender_->SetRtxSsrc(4321);
Shao Changbine62202f2015-04-21 20:24:50 +08001757 rtp_sender_->SetRtxPayloadType(kPayloadType - 1, kPayloadType);
pbos@webrtc.org0b0c2412015-01-13 14:15:15 +00001758 rtp_sender_->SetRtxStatus(kRtxRetransmitted | kRtxRedundantPayloads);
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001759
danilchap162abd32015-12-10 02:39:40 -08001760 ASSERT_EQ(0, rtp_sender_->RegisterPayload(kPayloadName, kPayloadType, 90000,
1761 0, 1500));
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001762 uint8_t payload[] = {47, 11, 32, 93, 89};
1763
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001764 RTPVideoHeader video_header;
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001765 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001766 kVideoFrameKey, kPayloadType, 1234, 4321, payload, sizeof(payload),
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001767 nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001768
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +00001769 // Will send 2 full-size padding packets.
philipel8aadd502017-02-23 02:56:13 -08001770 rtp_sender_->TimeToSendPadding(1, PacedPacketInfo());
1771 rtp_sender_->TimeToSendPadding(1, PacedPacketInfo());
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001772
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +00001773 StreamDataCounters rtp_stats;
1774 StreamDataCounters rtx_stats;
1775 rtp_sender_->GetDataCounters(&rtp_stats, &rtx_stats);
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001776
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +00001777 // Payload + 1-byte generic header.
asapersson@webrtc.orgd08d3892014-12-16 12:03:11 +00001778 EXPECT_GT(rtp_stats.first_packet_time_ms, -1);
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001779 EXPECT_EQ(rtp_stats.transmitted.payload_bytes, sizeof(payload) + 1);
1780 EXPECT_EQ(rtp_stats.transmitted.header_bytes, 12u);
1781 EXPECT_EQ(rtp_stats.transmitted.padding_bytes, 0u);
1782 EXPECT_EQ(rtx_stats.transmitted.payload_bytes, 0u);
1783 EXPECT_EQ(rtx_stats.transmitted.header_bytes, 24u);
1784 EXPECT_EQ(rtx_stats.transmitted.padding_bytes, 2 * kMaxPaddingSize);
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +00001785
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001786 EXPECT_EQ(rtp_stats.transmitted.TotalBytes(),
danilchap162abd32015-12-10 02:39:40 -08001787 rtp_stats.transmitted.payload_bytes +
1788 rtp_stats.transmitted.header_bytes +
1789 rtp_stats.transmitted.padding_bytes);
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001790 EXPECT_EQ(rtx_stats.transmitted.TotalBytes(),
danilchap162abd32015-12-10 02:39:40 -08001791 rtx_stats.transmitted.payload_bytes +
1792 rtx_stats.transmitted.header_bytes +
1793 rtx_stats.transmitted.padding_bytes);
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001794
danilchap162abd32015-12-10 02:39:40 -08001795 EXPECT_EQ(
1796 transport_.total_bytes_sent_,
1797 rtp_stats.transmitted.TotalBytes() + rtx_stats.transmitted.TotalBytes());
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001798}
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001799
minyue3a407ee2017-04-03 01:10:33 -07001800TEST_P(RtpSenderTestWithoutPacer, RespectsNackBitrateLimit) {
sprang38778b02015-09-29 09:48:22 -07001801 const int32_t kPacketSize = 1400;
1802 const int32_t kNumPackets = 30;
1803
sprangcd349d92016-07-13 09:11:28 -07001804 retransmission_rate_limiter_.SetMaxRate(kPacketSize * kNumPackets * 8);
1805
sprang38778b02015-09-29 09:48:22 -07001806 rtp_sender_->SetStorePacketsStatus(true, kNumPackets);
sprang38778b02015-09-29 09:48:22 -07001807 const uint16_t kStartSequenceNumber = rtp_sender_->SequenceNumber();
Danil Chapovalov2800d742016-08-26 18:48:46 +02001808 std::vector<uint16_t> sequence_numbers;
sprang38778b02015-09-29 09:48:22 -07001809 for (int32_t i = 0; i < kNumPackets; ++i) {
1810 sequence_numbers.push_back(kStartSequenceNumber + i);
1811 fake_clock_.AdvanceTimeMilliseconds(1);
1812 SendPacket(fake_clock_.TimeInMilliseconds(), kPacketSize);
1813 }
danilchap12ba1862016-10-26 02:41:55 -07001814 EXPECT_EQ(kNumPackets, transport_.packets_sent());
sprang38778b02015-09-29 09:48:22 -07001815
1816 fake_clock_.AdvanceTimeMilliseconds(1000 - kNumPackets);
1817
1818 // Resending should work - brings the bandwidth up to the limit.
1819 // NACK bitrate is capped to the same bitrate as the encoder, since the max
1820 // protection overhead is 50% (see MediaOptimization::SetTargetRates).
Danil Chapovalov2800d742016-08-26 18:48:46 +02001821 rtp_sender_->OnReceivedNack(sequence_numbers, 0);
danilchap12ba1862016-10-26 02:41:55 -07001822 EXPECT_EQ(kNumPackets * 2, transport_.packets_sent());
sprang38778b02015-09-29 09:48:22 -07001823
sprangcd349d92016-07-13 09:11:28 -07001824 // Must be at least 5ms in between retransmission attempts.
1825 fake_clock_.AdvanceTimeMilliseconds(5);
1826
sprang38778b02015-09-29 09:48:22 -07001827 // Resending should not work, bandwidth exceeded.
Danil Chapovalov2800d742016-08-26 18:48:46 +02001828 rtp_sender_->OnReceivedNack(sequence_numbers, 0);
danilchap12ba1862016-10-26 02:41:55 -07001829 EXPECT_EQ(kNumPackets * 2, transport_.packets_sent());
sprang38778b02015-09-29 09:48:22 -07001830}
1831
minyue3a407ee2017-04-03 01:10:33 -07001832TEST_P(RtpSenderVideoTest, KeyFrameHasCVO) {
danilchapb6f1fb52016-10-19 06:11:39 -07001833 uint8_t kFrame[kMaxPacketLength];
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001834 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
1835 kRtpExtensionVideoRotation, kVideoRotationExtensionId));
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001836
philipel1a4746a2018-07-09 15:52:29 +02001837 RTPVideoHeader hdr;
danilchapc1600c52016-10-26 03:33:11 -07001838 hdr.rotation = kVideoRotation_0;
Niels Möller520ca4e2018-06-04 11:14:38 +02001839 rtp_sender_video_->SendVideo(kVideoCodecGeneric, kVideoFrameKey, kPayload,
danilchapb6f1fb52016-10-19 06:11:39 -07001840 kTimestamp, 0, kFrame, sizeof(kFrame), nullptr,
spranga8ae6f22017-09-04 07:23:56 -07001841 &hdr, kDefaultExpectedRetransmissionTimeMs);
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001842
danilchapc1600c52016-10-26 03:33:11 -07001843 VideoRotation rotation;
1844 EXPECT_TRUE(
1845 transport_.last_sent_packet().GetExtension<VideoOrientation>(&rotation));
1846 EXPECT_EQ(kVideoRotation_0, rotation);
1847}
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001848
ilnik04f4d122017-06-19 07:18:55 -07001849TEST_P(RtpSenderVideoTest, TimingFrameHasPacketizationTimstampSet) {
1850 uint8_t kFrame[kMaxPacketLength];
1851 const int64_t kPacketizationTimeMs = 100;
1852 const int64_t kEncodeStartDeltaMs = 10;
1853 const int64_t kEncodeFinishDeltaMs = 50;
1854 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
1855 kRtpExtensionVideoTiming, kVideoTimingExtensionId));
1856
1857 const int64_t kCaptureTimestamp = fake_clock_.TimeInMilliseconds();
1858
philipel1a4746a2018-07-09 15:52:29 +02001859 RTPVideoHeader hdr;
Ilya Nikolaevskiyb6c462d2018-06-05 15:21:32 +02001860 hdr.video_timing.flags = VideoSendTiming::kTriggeredByTimer;
ilnik04f4d122017-06-19 07:18:55 -07001861 hdr.video_timing.encode_start_delta_ms = kEncodeStartDeltaMs;
1862 hdr.video_timing.encode_finish_delta_ms = kEncodeFinishDeltaMs;
1863
1864 fake_clock_.AdvanceTimeMilliseconds(kPacketizationTimeMs);
Niels Möller520ca4e2018-06-04 11:14:38 +02001865 rtp_sender_video_->SendVideo(kVideoCodecGeneric, kVideoFrameKey, kPayload,
ilnik04f4d122017-06-19 07:18:55 -07001866 kTimestamp, kCaptureTimestamp, kFrame,
spranga8ae6f22017-09-04 07:23:56 -07001867 sizeof(kFrame), nullptr, &hdr,
1868 kDefaultExpectedRetransmissionTimeMs);
ilnik2edc6842017-07-06 03:06:50 -07001869 VideoSendTiming timing;
ilnik04f4d122017-06-19 07:18:55 -07001870 EXPECT_TRUE(transport_.last_sent_packet().GetExtension<VideoTimingExtension>(
1871 &timing));
1872 EXPECT_EQ(kPacketizationTimeMs, timing.packetization_finish_delta_ms);
1873 EXPECT_EQ(kEncodeStartDeltaMs, timing.encode_start_delta_ms);
1874 EXPECT_EQ(kEncodeFinishDeltaMs, timing.encode_finish_delta_ms);
1875}
1876
minyue3a407ee2017-04-03 01:10:33 -07001877TEST_P(RtpSenderVideoTest, DeltaFrameHasCVOWhenChanged) {
danilchapc1600c52016-10-26 03:33:11 -07001878 uint8_t kFrame[kMaxPacketLength];
1879 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
1880 kRtpExtensionVideoRotation, kVideoRotationExtensionId));
1881
philipel1a4746a2018-07-09 15:52:29 +02001882 RTPVideoHeader hdr;
danilchapc1600c52016-10-26 03:33:11 -07001883 hdr.rotation = kVideoRotation_90;
spranga8ae6f22017-09-04 07:23:56 -07001884 EXPECT_TRUE(rtp_sender_video_->SendVideo(
Niels Möller520ca4e2018-06-04 11:14:38 +02001885 kVideoCodecGeneric, kVideoFrameKey, kPayload, kTimestamp, 0, kFrame,
spranga8ae6f22017-09-04 07:23:56 -07001886 sizeof(kFrame), nullptr, &hdr, kDefaultExpectedRetransmissionTimeMs));
danilchapc1600c52016-10-26 03:33:11 -07001887
1888 hdr.rotation = kVideoRotation_0;
spranga8ae6f22017-09-04 07:23:56 -07001889 EXPECT_TRUE(rtp_sender_video_->SendVideo(
Niels Möller520ca4e2018-06-04 11:14:38 +02001890 kVideoCodecGeneric, kVideoFrameDelta, kPayload, kTimestamp + 1, 0, kFrame,
spranga8ae6f22017-09-04 07:23:56 -07001891 sizeof(kFrame), nullptr, &hdr, kDefaultExpectedRetransmissionTimeMs));
danilchapc1600c52016-10-26 03:33:11 -07001892
1893 VideoRotation rotation;
1894 EXPECT_TRUE(
1895 transport_.last_sent_packet().GetExtension<VideoOrientation>(&rotation));
1896 EXPECT_EQ(kVideoRotation_0, rotation);
1897}
1898
minyue3a407ee2017-04-03 01:10:33 -07001899TEST_P(RtpSenderVideoTest, DeltaFrameHasCVOWhenNonZero) {
danilchapc1600c52016-10-26 03:33:11 -07001900 uint8_t kFrame[kMaxPacketLength];
1901 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
1902 kRtpExtensionVideoRotation, kVideoRotationExtensionId));
1903
philipel1a4746a2018-07-09 15:52:29 +02001904 RTPVideoHeader hdr;
danilchapc1600c52016-10-26 03:33:11 -07001905 hdr.rotation = kVideoRotation_90;
spranga8ae6f22017-09-04 07:23:56 -07001906 EXPECT_TRUE(rtp_sender_video_->SendVideo(
Niels Möller520ca4e2018-06-04 11:14:38 +02001907 kVideoCodecGeneric, kVideoFrameKey, kPayload, kTimestamp, 0, kFrame,
spranga8ae6f22017-09-04 07:23:56 -07001908 sizeof(kFrame), nullptr, &hdr, kDefaultExpectedRetransmissionTimeMs));
danilchapc1600c52016-10-26 03:33:11 -07001909
spranga8ae6f22017-09-04 07:23:56 -07001910 EXPECT_TRUE(rtp_sender_video_->SendVideo(
Niels Möller520ca4e2018-06-04 11:14:38 +02001911 kVideoCodecGeneric, kVideoFrameDelta, kPayload, kTimestamp + 1, 0, kFrame,
spranga8ae6f22017-09-04 07:23:56 -07001912 sizeof(kFrame), nullptr, &hdr, kDefaultExpectedRetransmissionTimeMs));
danilchapc1600c52016-10-26 03:33:11 -07001913
1914 VideoRotation rotation;
1915 EXPECT_TRUE(
1916 transport_.last_sent_packet().GetExtension<VideoOrientation>(&rotation));
1917 EXPECT_EQ(kVideoRotation_90, rotation);
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001918}
magjed71eb61c2016-09-08 03:24:58 -07001919
1920// Make sure rotation is parsed correctly when the Camera (C) and Flip (F) bits
1921// are set in the CVO byte.
minyue3a407ee2017-04-03 01:10:33 -07001922TEST_P(RtpSenderVideoTest, SendVideoWithCameraAndFlipCVO) {
magjed71eb61c2016-09-08 03:24:58 -07001923 // Test extracting rotation when Camera (C) and Flip (F) bits are zero.
1924 EXPECT_EQ(kVideoRotation_0, ConvertCVOByteToVideoRotation(0));
1925 EXPECT_EQ(kVideoRotation_90, ConvertCVOByteToVideoRotation(1));
1926 EXPECT_EQ(kVideoRotation_180, ConvertCVOByteToVideoRotation(2));
1927 EXPECT_EQ(kVideoRotation_270, ConvertCVOByteToVideoRotation(3));
1928 // Test extracting rotation when Camera (C) and Flip (F) bits are set.
1929 const int flip_bit = 1 << 2;
1930 const int camera_bit = 1 << 3;
1931 EXPECT_EQ(kVideoRotation_0,
1932 ConvertCVOByteToVideoRotation(flip_bit | camera_bit | 0));
1933 EXPECT_EQ(kVideoRotation_90,
1934 ConvertCVOByteToVideoRotation(flip_bit | camera_bit | 1));
1935 EXPECT_EQ(kVideoRotation_180,
1936 ConvertCVOByteToVideoRotation(flip_bit | camera_bit | 2));
1937 EXPECT_EQ(kVideoRotation_270,
1938 ConvertCVOByteToVideoRotation(flip_bit | camera_bit | 3));
1939}
1940
spranga8ae6f22017-09-04 07:23:56 -07001941TEST_P(RtpSenderVideoTest, RetransmissionTypesGeneric) {
1942 RTPVideoHeader header;
Niels Möller520ca4e2018-06-04 11:14:38 +02001943 header.codec = kVideoCodecGeneric;
spranga8ae6f22017-09-04 07:23:56 -07001944
1945 EXPECT_EQ(kDontRetransmit,
1946 rtp_sender_video_->GetStorageType(
1947 header, kRetransmitOff, kDefaultExpectedRetransmissionTimeMs));
1948 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1949 header, kRetransmitBaseLayer,
1950 kDefaultExpectedRetransmissionTimeMs));
1951 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1952 header, kRetransmitHigherLayers,
1953 kDefaultExpectedRetransmissionTimeMs));
1954 EXPECT_EQ(kAllowRetransmission,
1955 rtp_sender_video_->GetStorageType(
1956 header, kConditionallyRetransmitHigherLayers,
1957 kDefaultExpectedRetransmissionTimeMs));
1958 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1959 header, kRetransmitAllPackets,
1960 kDefaultExpectedRetransmissionTimeMs));
1961}
1962
1963TEST_P(RtpSenderVideoTest, RetransmissionTypesH264) {
1964 RTPVideoHeader header;
philipel7d745e52018-08-02 14:03:53 +02001965 header.video_type_header.emplace<RTPVideoHeaderH264>().packetization_mode =
1966 H264PacketizationMode::NonInterleaved;
Niels Möller520ca4e2018-06-04 11:14:38 +02001967 header.codec = kVideoCodecH264;
spranga8ae6f22017-09-04 07:23:56 -07001968
1969 EXPECT_EQ(kDontRetransmit,
1970 rtp_sender_video_->GetStorageType(
1971 header, kRetransmitOff, kDefaultExpectedRetransmissionTimeMs));
1972 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1973 header, kRetransmitBaseLayer,
1974 kDefaultExpectedRetransmissionTimeMs));
1975 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1976 header, kRetransmitHigherLayers,
1977 kDefaultExpectedRetransmissionTimeMs));
1978 EXPECT_EQ(kAllowRetransmission,
1979 rtp_sender_video_->GetStorageType(
1980 header, kConditionallyRetransmitHigherLayers,
1981 kDefaultExpectedRetransmissionTimeMs));
1982 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1983 header, kRetransmitAllPackets,
1984 kDefaultExpectedRetransmissionTimeMs));
1985}
1986
1987TEST_P(RtpSenderVideoTest, RetransmissionTypesVP8BaseLayer) {
1988 RTPVideoHeader header;
Niels Möller520ca4e2018-06-04 11:14:38 +02001989 header.codec = kVideoCodecVP8;
Philip Eliassond52a1a62018-09-07 13:03:55 +00001990 auto& vp8_header = header.video_type_header.emplace<RTPVideoHeaderVP8>();
1991 vp8_header.temporalIdx = 0;
spranga8ae6f22017-09-04 07:23:56 -07001992
1993 EXPECT_EQ(kDontRetransmit,
1994 rtp_sender_video_->GetStorageType(
1995 header, kRetransmitOff, kDefaultExpectedRetransmissionTimeMs));
1996 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1997 header, kRetransmitBaseLayer,
1998 kDefaultExpectedRetransmissionTimeMs));
1999 EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType(
2000 header, kRetransmitHigherLayers,
2001 kDefaultExpectedRetransmissionTimeMs));
2002 EXPECT_EQ(kAllowRetransmission,
2003 rtp_sender_video_->GetStorageType(
2004 header, kRetransmitHigherLayers | kRetransmitBaseLayer,
2005 kDefaultExpectedRetransmissionTimeMs));
2006 EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType(
2007 header, kConditionallyRetransmitHigherLayers,
2008 kDefaultExpectedRetransmissionTimeMs));
2009 EXPECT_EQ(
2010 kAllowRetransmission,
2011 rtp_sender_video_->GetStorageType(
2012 header, kRetransmitBaseLayer | kConditionallyRetransmitHigherLayers,
2013 kDefaultExpectedRetransmissionTimeMs));
2014 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
2015 header, kRetransmitAllPackets,
2016 kDefaultExpectedRetransmissionTimeMs));
2017}
2018
2019TEST_P(RtpSenderVideoTest, RetransmissionTypesVP8HigherLayers) {
2020 RTPVideoHeader header;
Niels Möller520ca4e2018-06-04 11:14:38 +02002021 header.codec = kVideoCodecVP8;
spranga8ae6f22017-09-04 07:23:56 -07002022
Philip Eliassond52a1a62018-09-07 13:03:55 +00002023 auto& vp8_header = header.video_type_header.emplace<RTPVideoHeaderVP8>();
spranga8ae6f22017-09-04 07:23:56 -07002024 for (int tid = 1; tid <= kMaxTemporalStreams; ++tid) {
Philip Eliassond52a1a62018-09-07 13:03:55 +00002025 vp8_header.temporalIdx = tid;
spranga8ae6f22017-09-04 07:23:56 -07002026
2027 EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType(
2028 header, kRetransmitOff,
2029 kDefaultExpectedRetransmissionTimeMs));
2030 EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType(
2031 header, kRetransmitBaseLayer,
2032 kDefaultExpectedRetransmissionTimeMs));
2033 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
2034 header, kRetransmitHigherLayers,
2035 kDefaultExpectedRetransmissionTimeMs));
2036 EXPECT_EQ(kAllowRetransmission,
2037 rtp_sender_video_->GetStorageType(
2038 header, kRetransmitHigherLayers | kRetransmitBaseLayer,
2039 kDefaultExpectedRetransmissionTimeMs));
2040 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
2041 header, kRetransmitAllPackets,
2042 kDefaultExpectedRetransmissionTimeMs));
2043 }
2044}
2045
2046TEST_P(RtpSenderVideoTest, RetransmissionTypesVP9) {
2047 RTPVideoHeader header;
Niels Möller520ca4e2018-06-04 11:14:38 +02002048 header.codec = kVideoCodecVP9;
spranga8ae6f22017-09-04 07:23:56 -07002049
philipel29d88462018-08-08 14:26:00 +02002050 auto& vp9_header = header.video_type_header.emplace<RTPVideoHeaderVP9>();
spranga8ae6f22017-09-04 07:23:56 -07002051 for (int tid = 1; tid <= kMaxTemporalStreams; ++tid) {
philipel29d88462018-08-08 14:26:00 +02002052 vp9_header.temporal_idx = tid;
spranga8ae6f22017-09-04 07:23:56 -07002053
2054 EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType(
2055 header, kRetransmitOff,
2056 kDefaultExpectedRetransmissionTimeMs));
2057 EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType(
2058 header, kRetransmitBaseLayer,
2059 kDefaultExpectedRetransmissionTimeMs));
2060 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
2061 header, kRetransmitHigherLayers,
2062 kDefaultExpectedRetransmissionTimeMs));
2063 EXPECT_EQ(kAllowRetransmission,
2064 rtp_sender_video_->GetStorageType(
2065 header, kRetransmitHigherLayers | kRetransmitBaseLayer,
2066 kDefaultExpectedRetransmissionTimeMs));
2067 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
2068 header, kRetransmitAllPackets,
2069 kDefaultExpectedRetransmissionTimeMs));
2070 }
2071}
2072
2073TEST_P(RtpSenderVideoTest, ConditionalRetransmit) {
2074 const int64_t kFrameIntervalMs = 33;
2075 const int64_t kRttMs = (kFrameIntervalMs * 3) / 2;
2076 const uint8_t kSettings =
2077 kRetransmitBaseLayer | kConditionallyRetransmitHigherLayers;
2078
2079 // Insert VP8 frames for all temporal layers, but stop before the final index.
2080 RTPVideoHeader header;
Niels Möller520ca4e2018-06-04 11:14:38 +02002081 header.codec = kVideoCodecVP8;
spranga8ae6f22017-09-04 07:23:56 -07002082
2083 // Fill averaging window to prevent rounding errors.
2084 constexpr int kNumRepetitions =
2085 (RTPSenderVideo::kTLRateWindowSizeMs + (kFrameIntervalMs / 2)) /
2086 kFrameIntervalMs;
2087 constexpr int kPattern[] = {0, 2, 1, 2};
Philip Eliassond52a1a62018-09-07 13:03:55 +00002088 auto& vp8_header = header.video_type_header.emplace<RTPVideoHeaderVP8>();
spranga8ae6f22017-09-04 07:23:56 -07002089 for (size_t i = 0; i < arraysize(kPattern) * kNumRepetitions; ++i) {
Philip Eliassond52a1a62018-09-07 13:03:55 +00002090 vp8_header.temporalIdx = kPattern[i % arraysize(kPattern)];
spranga8ae6f22017-09-04 07:23:56 -07002091 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs);
2092 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
2093 }
2094
2095 // Since we're at the start of the pattern, the next expected frame in TL0 is
2096 // right now. We will wait at most one expected retransmission time before
2097 // acknowledging that it did not arrive, which means this frame and the next
2098 // will not be retransmitted.
Philip Eliassond52a1a62018-09-07 13:03:55 +00002099 vp8_header.temporalIdx = 1;
spranga8ae6f22017-09-04 07:23:56 -07002100 EXPECT_EQ(StorageType::kDontRetransmit,
2101 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
2102 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
2103 EXPECT_EQ(StorageType::kDontRetransmit,
2104 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
2105 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
2106
2107 // The TL0 frame did not arrive. So allow retransmission.
2108 EXPECT_EQ(StorageType::kAllowRetransmission,
2109 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
2110 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
2111
2112 // Insert a frame for TL2. We just had frame in TL1, so the next one there is
2113 // in three frames away. TL0 is still too far in the past. So, allow
2114 // retransmission.
Philip Eliassond52a1a62018-09-07 13:03:55 +00002115 vp8_header.temporalIdx = 2;
spranga8ae6f22017-09-04 07:23:56 -07002116 EXPECT_EQ(StorageType::kAllowRetransmission,
2117 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
2118 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
2119
2120 // Another TL2, next in TL1 is two frames away. Allow again.
2121 EXPECT_EQ(StorageType::kAllowRetransmission,
2122 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
2123 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
2124
2125 // Yet another TL2, next in TL1 is now only one frame away, so don't store
2126 // for retransmission.
2127 EXPECT_EQ(StorageType::kDontRetransmit,
2128 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
2129}
2130
2131TEST_P(RtpSenderVideoTest, ConditionalRetransmitLimit) {
2132 const int64_t kFrameIntervalMs = 200;
2133 const int64_t kRttMs = (kFrameIntervalMs * 3) / 2;
2134 const int32_t kSettings =
2135 kRetransmitBaseLayer | kConditionallyRetransmitHigherLayers;
2136
2137 // Insert VP8 frames for all temporal layers, but stop before the final index.
2138 RTPVideoHeader header;
Niels Möller520ca4e2018-06-04 11:14:38 +02002139 header.codec = kVideoCodecVP8;
spranga8ae6f22017-09-04 07:23:56 -07002140
2141 // Fill averaging window to prevent rounding errors.
2142 constexpr int kNumRepetitions =
2143 (RTPSenderVideo::kTLRateWindowSizeMs + (kFrameIntervalMs / 2)) /
2144 kFrameIntervalMs;
2145 constexpr int kPattern[] = {0, 2, 2, 2};
Philip Eliassond52a1a62018-09-07 13:03:55 +00002146 auto& vp8_header = header.video_type_header.emplace<RTPVideoHeaderVP8>();
spranga8ae6f22017-09-04 07:23:56 -07002147 for (size_t i = 0; i < arraysize(kPattern) * kNumRepetitions; ++i) {
Philip Eliassond52a1a62018-09-07 13:03:55 +00002148 vp8_header.temporalIdx = kPattern[i % arraysize(kPattern)];
spranga8ae6f22017-09-04 07:23:56 -07002149
2150 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs);
2151 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
2152 }
2153
2154 // Since we're at the start of the pattern, the next expected frame will be
2155 // right now in TL0. Put it in TL1 instead. Regular rules would dictate that
2156 // we don't store for retransmission because we expect a frame in a lower
2157 // layer, but that last frame in TL1 was a long time ago in absolute terms,
2158 // so allow retransmission anyway.
Philip Eliassond52a1a62018-09-07 13:03:55 +00002159 vp8_header.temporalIdx = 1;
spranga8ae6f22017-09-04 07:23:56 -07002160 EXPECT_EQ(StorageType::kAllowRetransmission,
2161 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
2162}
2163
philipelb3e42a42018-09-13 10:57:14 +02002164TEST_P(RtpSenderVideoTest, PopulateGenericFrameDescriptor) {
2165 const int64_t kFrameId = 100000;
2166 uint8_t kFrame[100];
2167 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
2168 kRtpExtensionGenericFrameDescriptor, kGenericDescriptorId));
2169
2170 RTPVideoHeader hdr;
2171 RTPVideoHeader::GenericDescriptorInfo& generic = hdr.generic.emplace();
2172 generic.frame_id = kFrameId;
2173 generic.temporal_index = 3;
2174 generic.spatial_index = 2;
2175 generic.higher_spatial_layers.push_back(4);
2176 generic.dependencies.push_back(kFrameId - 1);
2177 generic.dependencies.push_back(kFrameId - 500);
2178 rtp_sender_video_->SendVideo(kVideoCodecGeneric, kVideoFrameDelta, kPayload,
2179 kTimestamp, 0, kFrame, sizeof(kFrame), nullptr,
2180 &hdr, kDefaultExpectedRetransmissionTimeMs);
2181
2182 RtpGenericFrameDescriptor descriptor_wire;
2183 EXPECT_EQ(1U, transport_.sent_packets_.size());
2184 EXPECT_TRUE(
2185 transport_.last_sent_packet()
2186 .GetExtension<RtpGenericFrameDescriptorExtension>(&descriptor_wire));
2187 EXPECT_EQ(static_cast<uint16_t>(generic.frame_id), descriptor_wire.FrameId());
2188 EXPECT_EQ(generic.temporal_index, descriptor_wire.TemporalLayer());
2189 EXPECT_THAT(descriptor_wire.FrameDependenciesDiffs(), ElementsAre(1, 500));
2190 uint8_t spatial_bitmask = 0x14;
2191 EXPECT_EQ(spatial_bitmask, descriptor_wire.SpatialLayersBitmask());
2192}
2193
Danil Chapovalov84ffb352018-09-25 18:59:09 +02002194TEST_P(RtpSenderVideoTest,
2195 UsesMinimalVp8DescriptorWhenGenericFrameDescriptorExtensionIsUsed) {
2196 const int64_t kFrameId = 100000;
2197 const size_t kFrameSize = 100;
2198 uint8_t kFrame[kFrameSize];
2199 ASSERT_TRUE(rtp_sender_->RegisterRtpHeaderExtension(
2200 RtpGenericFrameDescriptorExtension::kUri, kGenericDescriptorId));
2201
2202 RTPVideoHeader hdr;
2203 hdr.codec = kVideoCodecVP8;
2204 RTPVideoHeaderVP8& vp8 = hdr.video_type_header.emplace<RTPVideoHeaderVP8>();
2205 vp8.pictureId = kFrameId % 0X7FFF;
2206 vp8.tl0PicIdx = 13;
2207 vp8.temporalIdx = 1;
2208 vp8.keyIdx = 2;
2209 RTPVideoHeader::GenericDescriptorInfo& generic = hdr.generic.emplace();
2210 generic.frame_id = kFrameId;
2211 rtp_sender_video_->SendVideo(kVideoCodecVP8, kVideoFrameDelta, kPayload,
2212 kTimestamp, 0, kFrame, sizeof(kFrame), nullptr,
2213 &hdr, kDefaultExpectedRetransmissionTimeMs);
2214
2215 ASSERT_THAT(transport_.sent_packets_, SizeIs(1));
2216 // Expect only minimal 1-byte vp8 descriptor was generated.
2217 EXPECT_THAT(transport_.sent_packets_[0].payload_size(), 1 + kFrameSize);
2218}
2219
minyue3a407ee2017-04-03 01:10:33 -07002220TEST_P(RtpSenderTest, OnOverheadChanged) {
michaelt4da30442016-11-17 01:38:43 -08002221 MockOverheadObserver mock_overhead_observer;
Benjamin Wright192eeec2018-10-17 17:27:25 -07002222 rtp_sender_.reset(
2223 new RTPSender(false, &fake_clock_, &transport_, nullptr, nullptr, nullptr,
2224 nullptr, nullptr, nullptr, nullptr, nullptr, nullptr,
2225 &retransmission_rate_limiter_, &mock_overhead_observer,
Johannes Kron9190b822018-10-29 11:22:05 +01002226 false, nullptr, false, false));
nisse7d59f6b2017-02-21 03:40:24 -08002227 rtp_sender_->SetSSRC(kSsrc);
michaelt4da30442016-11-17 01:38:43 -08002228
michaelt4da30442016-11-17 01:38:43 -08002229 // RTP overhead is 12B.
nisse284542b2017-01-10 08:58:32 -08002230 EXPECT_CALL(mock_overhead_observer, OnOverheadChanged(12)).Times(1);
michaelt4da30442016-11-17 01:38:43 -08002231 SendGenericPayload();
2232
2233 rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionTransmissionTimeOffset,
2234 kTransmissionTimeOffsetExtensionId);
2235
2236 // TransmissionTimeOffset extension has a size of 8B.
nisse284542b2017-01-10 08:58:32 -08002237 // 12B + 8B = 20B
2238 EXPECT_CALL(mock_overhead_observer, OnOverheadChanged(20)).Times(1);
michaelt4da30442016-11-17 01:38:43 -08002239 SendGenericPayload();
2240}
2241
minyue3a407ee2017-04-03 01:10:33 -07002242TEST_P(RtpSenderTest, DoesNotUpdateOverheadOnEqualSize) {
michaelt4da30442016-11-17 01:38:43 -08002243 MockOverheadObserver mock_overhead_observer;
Benjamin Wright192eeec2018-10-17 17:27:25 -07002244 rtp_sender_.reset(
2245 new RTPSender(false, &fake_clock_, &transport_, nullptr, nullptr, nullptr,
2246 nullptr, nullptr, nullptr, nullptr, nullptr, nullptr,
2247 &retransmission_rate_limiter_, &mock_overhead_observer,
Johannes Kron9190b822018-10-29 11:22:05 +01002248 false, nullptr, false, false));
nisse7d59f6b2017-02-21 03:40:24 -08002249 rtp_sender_->SetSSRC(kSsrc);
michaelt4da30442016-11-17 01:38:43 -08002250
2251 EXPECT_CALL(mock_overhead_observer, OnOverheadChanged(_)).Times(1);
michaelt4da30442016-11-17 01:38:43 -08002252 SendGenericPayload();
2253 SendGenericPayload();
2254}
2255
sprang168794c2017-07-06 04:38:06 -07002256TEST_P(RtpSenderTest, SendsKeepAlive) {
2257 MockTransport transport;
Benjamin Wright192eeec2018-10-17 17:27:25 -07002258 rtp_sender_.reset(new RTPSender(
2259 false, &fake_clock_, &transport, nullptr, nullptr, nullptr, nullptr,
2260 nullptr, nullptr, nullptr, &mock_rtc_event_log_, nullptr,
Johannes Kron9190b822018-10-29 11:22:05 +01002261 &retransmission_rate_limiter_, nullptr, false, nullptr, false, false));
sprang168794c2017-07-06 04:38:06 -07002262 rtp_sender_->SetSequenceNumber(kSeqNum);
2263 rtp_sender_->SetTimestampOffset(0);
2264 rtp_sender_->SetSSRC(kSsrc);
2265
2266 const uint8_t kKeepalivePayloadType = 20;
2267 RTC_CHECK_NE(kKeepalivePayloadType, kPayload);
2268
2269 EXPECT_CALL(transport, SendRtp(_, _, _))
2270 .WillOnce(
2271 Invoke([&kKeepalivePayloadType](const uint8_t* packet, size_t len,
2272 const PacketOptions& options) {
2273 webrtc::RTPHeader rtp_header;
2274 RtpUtility::RtpHeaderParser parser(packet, len);
2275 EXPECT_TRUE(parser.Parse(&rtp_header, nullptr));
2276 EXPECT_FALSE(rtp_header.markerBit);
2277 EXPECT_EQ(0U, rtp_header.paddingLength);
2278 EXPECT_EQ(kKeepalivePayloadType, rtp_header.payloadType);
2279 EXPECT_EQ(kSeqNum, rtp_header.sequenceNumber);
2280 EXPECT_EQ(kSsrc, rtp_header.ssrc);
2281 EXPECT_EQ(0u, len - rtp_header.headerLength);
2282 return true;
2283 }));
2284
2285 rtp_sender_->SendKeepAlive(kKeepalivePayloadType);
2286 EXPECT_EQ(kSeqNum + 1, rtp_sender_->SequenceNumber());
2287}
2288
minyue3a407ee2017-04-03 01:10:33 -07002289INSTANTIATE_TEST_CASE_P(WithAndWithoutOverhead,
2290 RtpSenderTest,
2291 ::testing::Bool());
2292INSTANTIATE_TEST_CASE_P(WithAndWithoutOverhead,
2293 RtpSenderTestWithoutPacer,
2294 ::testing::Bool());
2295INSTANTIATE_TEST_CASE_P(WithAndWithoutOverhead,
2296 RtpSenderVideoTest,
2297 ::testing::Bool());
2298INSTANTIATE_TEST_CASE_P(WithAndWithoutOverhead,
2299 RtpSenderAudioTest,
2300 ::testing::Bool());
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00002301} // namespace webrtc