blob: da7ba4f67becee8ed70c31fc01138a1cbf6a4702 [file] [log] [blame]
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +00001/*
phoglund@webrtc.org78088c22012-02-07 14:56:45 +00002 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +00003 *
4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
9 */
10
Jonas Olssona4d87372019-07-05 19:08:33 +020011#include "modules/rtp_rtcp/source/rtp_sender.h"
12
kwiberg84be5112016-04-27 01:19:58 -070013#include <memory>
danilchapb8b6fbb2015-12-10 05:05:27 -080014#include <vector>
15
Danil Chapovalov16cb1f62019-09-05 11:29:59 +020016#include "api/rtc_event_log/rtc_event.h"
Per Kjellandere11b7d22019-02-21 07:55:59 +010017#include "api/transport/field_trial_based_config.h"
Erik Språngf93eda12019-01-16 17:10:57 +010018#include "api/video/video_codec_constants.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020019#include "api/video/video_timing.h"
20#include "logging/rtc_event_log/mock/mock_rtc_event_log.h"
21#include "modules/rtp_rtcp/include/rtp_cvo.h"
22#include "modules/rtp_rtcp/include/rtp_header_extension_map.h"
Erik Språngaa59eca2019-07-24 14:52:55 +020023#include "modules/rtp_rtcp/include/rtp_packet_sender.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020024#include "modules/rtp_rtcp/include/rtp_rtcp_defines.h"
25#include "modules/rtp_rtcp/source/rtcp_packet/transport_feedback.h"
26#include "modules/rtp_rtcp/source/rtp_format_video_generic.h"
philipelb3e42a42018-09-13 10:57:14 +020027#include "modules/rtp_rtcp/source/rtp_generic_frame_descriptor.h"
28#include "modules/rtp_rtcp/source/rtp_generic_frame_descriptor_extension.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020029#include "modules/rtp_rtcp/source/rtp_header_extensions.h"
30#include "modules/rtp_rtcp/source/rtp_packet_received.h"
31#include "modules/rtp_rtcp/source/rtp_packet_to_send.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020032#include "modules/rtp_rtcp/source/rtp_sender_video.h"
33#include "modules/rtp_rtcp/source/rtp_utility.h"
34#include "rtc_base/arraysize.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020035#include "rtc_base/rate_limiter.h"
36#include "test/field_trial.h"
37#include "test/gmock.h"
38#include "test/gtest.h"
39#include "test/mock_transport.h"
Tommi25eb47c2019-08-29 16:39:05 +020040#include "test/rtp_header_parser.h"
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +000041
42namespace webrtc {
43
andrew@webrtc.org8a442592011-12-16 21:24:30 +000044namespace {
Elad Alond8d32482019-02-18 23:45:57 +010045enum : int { // The first valid value is 1.
46 kAbsoluteSendTimeExtensionId = 1,
47 kAudioLevelExtensionId,
Elad Alonccb9b752019-02-19 13:01:31 +010048 kGenericDescriptorId00,
49 kGenericDescriptorId01,
Elad Alond8d32482019-02-18 23:45:57 +010050 kMidExtensionId,
51 kRepairedRidExtensionId,
52 kRidExtensionId,
53 kTransmissionTimeOffsetExtensionId,
54 kTransportSequenceNumberExtensionId,
55 kVideoRotationExtensionId,
56 kVideoTimingExtensionId,
57};
58
andrew@webrtc.org8a442592011-12-16 21:24:30 +000059const int kPayload = 100;
Shao Changbine62202f2015-04-21 20:24:50 +080060const int kRtxPayload = 98;
andrew@webrtc.org8a442592011-12-16 21:24:30 +000061const uint32_t kTimestamp = 10;
62const uint16_t kSeqNum = 33;
brandtr9dfff292016-11-14 05:14:50 -080063const uint32_t kSsrc = 725242;
Erik Språng9c771c22019-06-17 16:31:53 +020064const uint32_t kRtxSsrc = 12345;
65const uint32_t kFlexFecSsrc = 45678;
Erik Språng1fbfecd2019-08-26 19:00:05 +020066const uint16_t kTransportSequenceNumber = 1;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +000067const uint64_t kStartTime = 123456789;
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +000068const size_t kMaxPaddingSize = 224u;
Stefan Holmera246cfb2016-08-23 17:51:42 +020069const uint8_t kPayloadData[] = {47, 11, 32, 93, 89};
spranga8ae6f22017-09-04 07:23:56 -070070const int64_t kDefaultExpectedRetransmissionTimeMs = 125;
Amit Hilbuch77938e62018-12-21 09:23:38 -080071const char kNoRid[] = "";
72const char kNoMid[] = "";
andrew@webrtc.org8a442592011-12-16 21:24:30 +000073
Danil Chapovalov5e57b172016-09-02 19:15:59 +020074using ::testing::_;
Erik Språng30a276b2019-04-23 12:00:11 +020075using ::testing::AllOf;
Erik Språngea55b082019-10-02 14:57:46 +020076using ::testing::Contains;
Danil Chapovalov5e57b172016-09-02 19:15:59 +020077using ::testing::ElementsAreArray;
Erik Språng30a276b2019-04-23 12:00:11 +020078using ::testing::Field;
Erik Språng9c771c22019-06-17 16:31:53 +020079using ::testing::NiceMock;
Erik Språng478cb462019-06-26 15:49:27 +020080using ::testing::Pointee;
81using ::testing::Property;
Erik Språng214f5432019-06-20 15:09:58 +020082using ::testing::Return;
Erik Språng9c771c22019-06-17 16:31:53 +020083using ::testing::StrictMock;
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +000084
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +000085uint64_t ConvertMsToAbsSendTime(int64_t time_ms) {
Stefan Holmer0a87ffc2015-10-21 13:41:48 +020086 return (((time_ms << 18) + 500) / 1000) & 0x00ffffff;
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +000087}
88
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +000089class LoopbackTransportTest : public webrtc::Transport {
90 public:
Petter Strandmark26bc6692018-05-29 08:43:35 +020091 LoopbackTransportTest() : total_bytes_sent_(0) {
Danil Chapovalova74e4772019-09-12 17:53:04 +020092 receivers_extensions_.Register<TransmissionOffset>(
93 kTransmissionTimeOffsetExtensionId);
94 receivers_extensions_.Register<AbsoluteSendTime>(
95 kAbsoluteSendTimeExtensionId);
96 receivers_extensions_.Register<TransportSequenceNumber>(
97 kTransportSequenceNumberExtensionId);
98 receivers_extensions_.Register<VideoOrientation>(kVideoRotationExtensionId);
99 receivers_extensions_.Register<AudioLevel>(kAudioLevelExtensionId);
100 receivers_extensions_.Register<VideoTimingExtension>(
101 kVideoTimingExtensionId);
102 receivers_extensions_.Register<RtpMid>(kMidExtensionId);
103 receivers_extensions_.Register<RtpGenericFrameDescriptorExtension00>(
104 kGenericDescriptorId00);
105 receivers_extensions_.Register<RtpGenericFrameDescriptorExtension01>(
106 kGenericDescriptorId01);
107 receivers_extensions_.Register<RtpStreamId>(kRidExtensionId);
108 receivers_extensions_.Register<RepairedRtpStreamId>(
109 kRepairedRidExtensionId);
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000110 }
danilchap12ba1862016-10-26 02:41:55 -0700111
stefan1d8a5062015-10-02 03:39:33 -0700112 bool SendRtp(const uint8_t* data,
113 size_t len,
114 const PacketOptions& options) override {
Petter Strandmark26bc6692018-05-29 08:43:35 +0200115 last_options_ = options;
pkasting@chromium.org4591fbd2014-11-20 22:28:14 +0000116 total_bytes_sent_ += len;
danilchap12ba1862016-10-26 02:41:55 -0700117 sent_packets_.push_back(RtpPacketReceived(&receivers_extensions_));
118 EXPECT_TRUE(sent_packets_.back().Parse(data, len));
pbos2d566682015-09-28 09:59:31 -0700119 return true;
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000120 }
danilchap162abd32015-12-10 02:39:40 -0800121 bool SendRtcp(const uint8_t* data, size_t len) override { return false; }
danilchap12ba1862016-10-26 02:41:55 -0700122 const RtpPacketReceived& last_sent_packet() { return sent_packets_.back(); }
123 int packets_sent() { return sent_packets_.size(); }
124
pbos@webrtc.org72491b92014-07-10 16:24:54 +0000125 size_t total_bytes_sent_;
Petter Strandmark26bc6692018-05-29 08:43:35 +0200126 PacketOptions last_options_;
danilchap12ba1862016-10-26 02:41:55 -0700127 std::vector<RtpPacketReceived> sent_packets_;
128
129 private:
130 RtpHeaderExtensionMap receivers_extensions_;
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000131};
132
Elad Alon4a87e1c2017-10-03 16:11:34 +0200133MATCHER_P(SameRtcEventTypeAs, value, "") {
134 return value == arg->GetType();
135}
136
Erik Språngf6468d22019-07-05 16:53:43 +0200137struct TestConfig {
Erik Språngf5815fa2019-08-21 14:27:31 +0200138 explicit TestConfig(bool with_overhead) : with_overhead(with_overhead) {}
Erik Språngf6468d22019-07-05 16:53:43 +0200139 bool with_overhead = false;
Erik Språngf6468d22019-07-05 16:53:43 +0200140};
141
142std::string ToFieldTrialString(TestConfig config) {
143 std::string field_trials;
144 if (config.with_overhead) {
145 field_trials += "WebRTC-SendSideBwe-WithOverhead/Enabled/";
146 }
Erik Språngf6468d22019-07-05 16:53:43 +0200147 return field_trials;
148}
149
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000150} // namespace
151
Erik Språngaa59eca2019-07-24 14:52:55 +0200152class MockRtpPacketPacer : public RtpPacketSender {
sprangebbf8a82015-09-21 15:11:14 -0700153 public:
Erik Språng59b86542019-06-23 18:24:46 +0200154 MockRtpPacketPacer() {}
155 virtual ~MockRtpPacketPacer() {}
156
Erik Språngea55b082019-10-02 14:57:46 +0200157 MOCK_METHOD1(EnqueuePackets,
158 void(std::vector<std::unique_ptr<RtpPacketToSend>>));
sprangebbf8a82015-09-21 15:11:14 -0700159
Erik Språngaa59eca2019-07-24 14:52:55 +0200160 MOCK_METHOD2(CreateProbeCluster, void(int bitrate_bps, int cluster_id));
161
162 MOCK_METHOD0(Pause, void());
163 MOCK_METHOD0(Resume, void());
164 MOCK_METHOD1(SetCongestionWindow,
165 void(absl::optional<int64_t> congestion_window_bytes));
166 MOCK_METHOD1(UpdateOutstandingData, void(int64_t outstanding_bytes));
167 MOCK_METHOD1(SetAccountForAudioPackets, void(bool account_for_audio));
sprangebbf8a82015-09-21 15:11:14 -0700168};
169
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200170class MockSendSideDelayObserver : public SendSideDelayObserver {
171 public:
Henrik Boström9fe18342019-05-16 18:38:20 +0200172 MOCK_METHOD4(SendSideDelayUpdated, void(int, int, uint64_t, uint32_t));
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200173};
174
asapersson35151f32016-05-02 23:44:01 -0700175class MockSendPacketObserver : public SendPacketObserver {
176 public:
177 MOCK_METHOD3(OnSendPacket, void(uint16_t, int64_t, uint32_t));
178};
179
Stefan Holmera246cfb2016-08-23 17:51:42 +0200180class MockTransportFeedbackObserver : public TransportFeedbackObserver {
181 public:
Erik Språng30a276b2019-04-23 12:00:11 +0200182 MOCK_METHOD1(OnAddPacket, void(const RtpPacketSendInfo&));
Stefan Holmera246cfb2016-08-23 17:51:42 +0200183 MOCK_METHOD1(OnTransportFeedback, void(const rtcp::TransportFeedback&));
elad.alonf9490002017-03-06 05:32:21 -0800184 MOCK_CONST_METHOD0(GetTransportFeedbackVector, std::vector<PacketFeedback>());
Stefan Holmera246cfb2016-08-23 17:51:42 +0200185};
186
minyue3a407ee2017-04-03 01:10:33 -0700187class MockOverheadObserver : public OverheadObserver {
188 public:
189 MOCK_METHOD1(OnOverheadChanged, void(size_t overhead_bytes_per_packet));
190};
191
Erik Språngf6468d22019-07-05 16:53:43 +0200192class RtpSenderTest : public ::testing::TestWithParam<TestConfig> {
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000193 protected:
194 RtpSenderTest()
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +0000195 : fake_clock_(kStartTime),
terelius429c3452016-01-21 05:42:04 -0800196 mock_rtc_event_log_(),
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +0000197 mock_paced_sender_(),
sprangcd349d92016-07-13 09:11:28 -0700198 retransmission_rate_limiter_(&fake_clock_, 1000),
Erik Språng4580ca22019-07-04 10:38:43 +0200199 flexfec_sender_(0,
200 kFlexFecSsrc,
201 kSsrc,
202 "",
203 std::vector<RtpExtension>(),
204 std::vector<RtpExtensionSize>(),
205 nullptr,
206 &fake_clock_),
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +0000207 rtp_sender_(),
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +0000208 transport_(),
minyue3a407ee2017-04-03 01:10:33 -0700209 kMarkerBit(true),
Erik Språngf6468d22019-07-05 16:53:43 +0200210 field_trials_(ToFieldTrialString(GetParam())) {}
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +0000211
Erik Språng7b52f102018-02-07 14:37:37 +0100212 void SetUp() override { SetUpRtpSender(true, false); }
Peter Boströme23e7372015-10-08 11:44:14 +0200213
Erik Språng7b52f102018-02-07 14:37:37 +0100214 void SetUpRtpSender(bool pacer, bool populate_network2) {
Erik Språng4580ca22019-07-04 10:38:43 +0200215 RtpRtcp::Configuration config;
216 config.clock = &fake_clock_;
217 config.outgoing_transport = &transport_;
Erik Språng54d5d2c2019-08-20 17:22:36 +0200218 config.local_media_ssrc = kSsrc;
Erik Språng4580ca22019-07-04 10:38:43 +0200219 config.rtx_send_ssrc = kRtxSsrc;
220 config.flexfec_sender = &flexfec_sender_;
Erik Språng4580ca22019-07-04 10:38:43 +0200221 config.event_log = &mock_rtc_event_log_;
222 config.send_packet_observer = &send_packet_observer_;
223 config.retransmission_rate_limiter = &retransmission_rate_limiter_;
224 config.paced_sender = pacer ? &mock_paced_sender_ : nullptr;
225 config.populate_network2_timestamp = populate_network2;
226 rtp_sender_.reset(new RTPSender(config));
brandtr9dfff292016-11-14 05:14:50 -0800227 rtp_sender_->SetSequenceNumber(kSeqNum);
danilchap71fead22016-08-18 02:01:49 -0700228 rtp_sender_->SetTimestampOffset(0);
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +0000229 }
230
stefan@webrtc.orga678a3b2013-01-21 07:42:11 +0000231 SimulatedClock fake_clock_;
Erik Språng9c771c22019-06-17 16:31:53 +0200232 NiceMock<MockRtcEventLog> mock_rtc_event_log_;
Erik Språng59b86542019-06-23 18:24:46 +0200233 MockRtpPacketPacer mock_paced_sender_;
Erik Språng9c771c22019-06-17 16:31:53 +0200234 StrictMock<MockSendPacketObserver> send_packet_observer_;
235 StrictMock<MockTransportFeedbackObserver> feedback_observer_;
sprangcd349d92016-07-13 09:11:28 -0700236 RateLimiter retransmission_rate_limiter_;
Erik Språng4580ca22019-07-04 10:38:43 +0200237 FlexfecSender flexfec_sender_;
kwiberg84be5112016-04-27 01:19:58 -0700238 std::unique_ptr<RTPSender> rtp_sender_;
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000239 LoopbackTransportTest transport_;
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000240 const bool kMarkerBit;
minyue3a407ee2017-04-03 01:10:33 -0700241 test::ScopedFieldTrials field_trials_;
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000242
danilchapb6f1fb52016-10-19 06:11:39 -0700243 std::unique_ptr<RtpPacketToSend> BuildRtpPacket(int payload_type,
244 bool marker_bit,
245 uint32_t timestamp,
246 int64_t capture_time_ms) {
247 auto packet = rtp_sender_->AllocatePacket();
248 packet->SetPayloadType(payload_type);
Erik Språng60ffc312019-07-30 22:03:49 +0200249 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
danilchapb6f1fb52016-10-19 06:11:39 -0700250 packet->SetMarker(marker_bit);
251 packet->SetTimestamp(timestamp);
252 packet->set_capture_time_ms(capture_time_ms);
253 EXPECT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
254 return packet;
255 }
256
Erik Språngf6468d22019-07-05 16:53:43 +0200257 std::unique_ptr<RtpPacketToSend> SendPacket(int64_t capture_time_ms,
258 int payload_length) {
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000259 uint32_t timestamp = capture_time_ms * 90;
danilchapb6f1fb52016-10-19 06:11:39 -0700260 auto packet =
261 BuildRtpPacket(kPayload, kMarkerBit, timestamp, capture_time_ms);
262 packet->AllocatePayload(payload_length);
Erik Språng70768f42019-08-27 18:16:26 +0200263 packet->set_allow_retransmission(true);
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000264
265 // Packet should be stored in a send bucket.
Mirko Bonadei317a1f02019-09-17 17:06:18 +0200266 EXPECT_TRUE(
267 rtp_sender_->SendToNetwork(std::make_unique<RtpPacketToSend>(*packet)));
Erik Språngf6468d22019-07-05 16:53:43 +0200268 return packet;
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000269 }
asapersson35151f32016-05-02 23:44:01 -0700270
Erik Språngf6468d22019-07-05 16:53:43 +0200271 std::unique_ptr<RtpPacketToSend> SendGenericPacket() {
asapersson35151f32016-05-02 23:44:01 -0700272 const int64_t kCaptureTimeMs = fake_clock_.TimeInMilliseconds();
Erik Språngf6468d22019-07-05 16:53:43 +0200273 return SendPacket(kCaptureTimeMs, sizeof(kPayloadData));
asapersson35151f32016-05-02 23:44:01 -0700274 }
Steve Anton2bac7da2019-07-21 15:04:21 -0400275
Erik Språng4208a132019-08-26 08:58:45 +0200276 size_t GenerateAndSendPadding(size_t target_size_bytes) {
277 size_t generated_bytes = 0;
278 for (auto& packet : rtp_sender_->GeneratePadding(target_size_bytes)) {
279 generated_bytes += packet->payload_size() + packet->padding_size();
280 rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo());
281 }
282 return generated_bytes;
283 }
284
Steve Anton2bac7da2019-07-21 15:04:21 -0400285 // The following are helpers for configuring the RTPSender. They must be
286 // called before sending any packets.
287
288 // Enable the retransmission stream with sizable packet storage.
289 void EnableRtx() {
290 // RTX needs to be able to read the source packets from the packet store.
291 // Pick a number of packets to store big enough for any unit test.
292 constexpr uint16_t kNumberOfPacketsToStore = 100;
293 rtp_sender_->SetStorePacketsStatus(true, kNumberOfPacketsToStore);
294 rtp_sender_->SetRtxPayloadType(kRtxPayload, kPayload);
295 rtp_sender_->SetRtxStatus(kRtxRetransmitted | kRtxRedundantPayloads);
296 }
297
298 // Enable sending of the MID header extension for both the primary SSRC and
299 // the RTX SSRC.
300 void EnableMidSending(const std::string& mid) {
301 rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionMid, kMidExtensionId);
302 rtp_sender_->SetMid(mid);
303 }
304
305 // Enable sending of the RSID header extension for the primary SSRC and the
306 // RRSID header extension for the RTX SSRC.
307 void EnableRidSending(const std::string& rid) {
308 rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionRtpStreamId,
309 kRidExtensionId);
310 rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionRepairedRtpStreamId,
311 kRepairedRidExtensionId);
312 rtp_sender_->SetRid(rid);
313 }
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000314};
315
Peter Boströme23e7372015-10-08 11:44:14 +0200316// TODO(pbos): Move tests over from WithoutPacer to RtpSenderTest as this is our
317// default code path.
318class RtpSenderTestWithoutPacer : public RtpSenderTest {
319 public:
Erik Språng7b52f102018-02-07 14:37:37 +0100320 void SetUp() override { SetUpRtpSender(false, false); }
Peter Boströme23e7372015-10-08 11:44:14 +0200321};
322
minyue3a407ee2017-04-03 01:10:33 -0700323TEST_P(RtpSenderTestWithoutPacer, AllocatePacketSetCsrc) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200324 // Configure rtp_sender with csrc.
325 std::vector<uint32_t> csrcs;
326 csrcs.push_back(0x23456789);
327 rtp_sender_->SetCsrcs(csrcs);
328
329 auto packet = rtp_sender_->AllocatePacket();
330
331 ASSERT_TRUE(packet);
332 EXPECT_EQ(rtp_sender_->SSRC(), packet->Ssrc());
333 EXPECT_EQ(csrcs, packet->Csrcs());
334}
335
minyue3a407ee2017-04-03 01:10:33 -0700336TEST_P(RtpSenderTestWithoutPacer, AllocatePacketReserveExtensions) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200337 // Configure rtp_sender with extensions.
338 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
339 kRtpExtensionTransmissionTimeOffset,
340 kTransmissionTimeOffsetExtensionId));
341 ASSERT_EQ(
342 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
343 kAbsoluteSendTimeExtensionId));
344 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAudioLevel,
345 kAudioLevelExtensionId));
346 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
347 kRtpExtensionTransportSequenceNumber,
348 kTransportSequenceNumberExtensionId));
349 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
350 kRtpExtensionVideoRotation, kVideoRotationExtensionId));
351
352 auto packet = rtp_sender_->AllocatePacket();
353
354 ASSERT_TRUE(packet);
355 // Preallocate BWE extensions RtpSender set itself.
356 EXPECT_TRUE(packet->HasExtension<TransmissionOffset>());
357 EXPECT_TRUE(packet->HasExtension<AbsoluteSendTime>());
358 EXPECT_TRUE(packet->HasExtension<TransportSequenceNumber>());
359 // Do not allocate media specific extensions.
360 EXPECT_FALSE(packet->HasExtension<AudioLevel>());
361 EXPECT_FALSE(packet->HasExtension<VideoOrientation>());
362}
363
minyue3a407ee2017-04-03 01:10:33 -0700364TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberAdvanceSequenceNumber) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200365 auto packet = rtp_sender_->AllocatePacket();
366 ASSERT_TRUE(packet);
367 const uint16_t sequence_number = rtp_sender_->SequenceNumber();
368
369 EXPECT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
370
371 EXPECT_EQ(sequence_number, packet->SequenceNumber());
372 EXPECT_EQ(sequence_number + 1, rtp_sender_->SequenceNumber());
373}
374
minyue3a407ee2017-04-03 01:10:33 -0700375TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberFailsOnNotSending) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200376 auto packet = rtp_sender_->AllocatePacket();
377 ASSERT_TRUE(packet);
378
379 rtp_sender_->SetSendingMediaStatus(false);
380 EXPECT_FALSE(rtp_sender_->AssignSequenceNumber(packet.get()));
381}
382
Danil Chapovalovb3179c72018-03-22 10:13:07 +0100383TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberMayAllowPaddingOnVideo) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200384 constexpr size_t kPaddingSize = 100;
385 auto packet = rtp_sender_->AllocatePacket();
386 ASSERT_TRUE(packet);
387
Erik Språng4208a132019-08-26 08:58:45 +0200388 ASSERT_TRUE(rtp_sender_->GeneratePadding(kPaddingSize).empty());
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200389 packet->SetMarker(false);
390 ASSERT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
Danil Chapovalovb3179c72018-03-22 10:13:07 +0100391 // Packet without marker bit doesn't allow padding on video stream.
Erik Språng4208a132019-08-26 08:58:45 +0200392 ASSERT_TRUE(rtp_sender_->GeneratePadding(kPaddingSize).empty());
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200393
394 packet->SetMarker(true);
395 ASSERT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
396 // Packet with marker bit allows send padding.
Erik Språng4208a132019-08-26 08:58:45 +0200397 ASSERT_FALSE(rtp_sender_->GeneratePadding(kPaddingSize).empty());
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200398}
399
Danil Chapovalovb3179c72018-03-22 10:13:07 +0100400TEST_P(RtpSenderTest, AssignSequenceNumberAllowsPaddingOnAudio) {
401 MockTransport transport;
Erik Språng4580ca22019-07-04 10:38:43 +0200402 RtpRtcp::Configuration config;
403 config.audio = true;
404 config.clock = &fake_clock_;
405 config.outgoing_transport = &transport;
406 config.paced_sender = &mock_paced_sender_;
Erik Språng54d5d2c2019-08-20 17:22:36 +0200407 config.local_media_ssrc = kSsrc;
Erik Språng4580ca22019-07-04 10:38:43 +0200408 config.event_log = &mock_rtc_event_log_;
409 config.retransmission_rate_limiter = &retransmission_rate_limiter_;
Mirko Bonadei317a1f02019-09-17 17:06:18 +0200410 rtp_sender_ = std::make_unique<RTPSender>(config);
Erik Språng4580ca22019-07-04 10:38:43 +0200411
Danil Chapovalovb3179c72018-03-22 10:13:07 +0100412 rtp_sender_->SetTimestampOffset(0);
Danil Chapovalovb3179c72018-03-22 10:13:07 +0100413
414 std::unique_ptr<RtpPacketToSend> audio_packet = rtp_sender_->AllocatePacket();
415 // Padding on audio stream allowed regardless of marker in the last packet.
416 audio_packet->SetMarker(false);
417 audio_packet->SetPayloadType(kPayload);
418 rtp_sender_->AssignSequenceNumber(audio_packet.get());
419
420 const size_t kPaddingSize = 59;
421 EXPECT_CALL(transport, SendRtp(_, kPaddingSize + kRtpHeaderSize, _))
Erik Språng214f5432019-06-20 15:09:58 +0200422 .WillOnce(Return(true));
Erik Språng4208a132019-08-26 08:58:45 +0200423 EXPECT_EQ(kPaddingSize, GenerateAndSendPadding(kPaddingSize));
Danil Chapovalovb3179c72018-03-22 10:13:07 +0100424
425 // Requested padding size is too small, will send a larger one.
426 const size_t kMinPaddingSize = 50;
427 EXPECT_CALL(transport, SendRtp(_, kMinPaddingSize + kRtpHeaderSize, _))
Erik Språng214f5432019-06-20 15:09:58 +0200428 .WillOnce(Return(true));
Erik Språng4208a132019-08-26 08:58:45 +0200429 EXPECT_EQ(kMinPaddingSize, GenerateAndSendPadding(kMinPaddingSize - 5));
Danil Chapovalovb3179c72018-03-22 10:13:07 +0100430}
431
minyue3a407ee2017-04-03 01:10:33 -0700432TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberSetPaddingTimestamps) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200433 constexpr size_t kPaddingSize = 100;
434 auto packet = rtp_sender_->AllocatePacket();
435 ASSERT_TRUE(packet);
436 packet->SetMarker(true);
437 packet->SetTimestamp(kTimestamp);
438
439 ASSERT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
Erik Språng4208a132019-08-26 08:58:45 +0200440 auto padding_packets = rtp_sender_->GeneratePadding(kPaddingSize);
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200441
Erik Språng4208a132019-08-26 08:58:45 +0200442 ASSERT_EQ(1u, padding_packets.size());
danilchap12ba1862016-10-26 02:41:55 -0700443 // Verify padding packet timestamp.
Erik Språng4208a132019-08-26 08:58:45 +0200444 EXPECT_EQ(kTimestamp, padding_packets[0]->Timestamp());
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200445}
446
minyue3a407ee2017-04-03 01:10:33 -0700447TEST_P(RtpSenderTestWithoutPacer,
448 TransportFeedbackObserverGetsCorrectByteCount) {
449 constexpr int kRtpOverheadBytesPerPacket = 12 + 8;
Erik Språng9c771c22019-06-17 16:31:53 +0200450 NiceMock<MockOverheadObserver> mock_overhead_observer;
Erik Språng4580ca22019-07-04 10:38:43 +0200451
452 RtpRtcp::Configuration config;
453 config.clock = &fake_clock_;
454 config.outgoing_transport = &transport_;
Erik Språng54d5d2c2019-08-20 17:22:36 +0200455 config.local_media_ssrc = kSsrc;
Erik Språng4580ca22019-07-04 10:38:43 +0200456 config.transport_feedback_callback = &feedback_observer_;
457 config.event_log = &mock_rtc_event_log_;
458 config.retransmission_rate_limiter = &retransmission_rate_limiter_;
459 config.overhead_observer = &mock_overhead_observer;
Mirko Bonadei317a1f02019-09-17 17:06:18 +0200460 rtp_sender_ = std::make_unique<RTPSender>(config);
Erik Språng4580ca22019-07-04 10:38:43 +0200461
minyue3a407ee2017-04-03 01:10:33 -0700462 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
463 kRtpExtensionTransportSequenceNumber,
464 kTransportSequenceNumberExtensionId));
minyue3a407ee2017-04-03 01:10:33 -0700465
466 const size_t expected_bytes =
Erik Språngf6468d22019-07-05 16:53:43 +0200467 GetParam().with_overhead
468 ? sizeof(kPayloadData) + kRtpOverheadBytesPerPacket
469 : sizeof(kPayloadData);
minyue3a407ee2017-04-03 01:10:33 -0700470
471 EXPECT_CALL(feedback_observer_,
Erik Språng30a276b2019-04-23 12:00:11 +0200472 OnAddPacket(AllOf(
473 Field(&RtpPacketSendInfo::ssrc, rtp_sender_->SSRC()),
474 Field(&RtpPacketSendInfo::transport_sequence_number,
475 kTransportSequenceNumber),
476 Field(&RtpPacketSendInfo::rtp_sequence_number,
477 rtp_sender_->SequenceNumber()),
478 Field(&RtpPacketSendInfo::length, expected_bytes),
479 Field(&RtpPacketSendInfo::pacing_info, PacedPacketInfo()))))
minyue3a407ee2017-04-03 01:10:33 -0700480 .Times(1);
481 EXPECT_CALL(mock_overhead_observer,
482 OnOverheadChanged(kRtpOverheadBytesPerPacket))
483 .Times(1);
Niels Möllere7b9e6b2019-02-06 18:23:44 +0100484 SendGenericPacket();
minyue3a407ee2017-04-03 01:10:33 -0700485}
486
487TEST_P(RtpSenderTestWithoutPacer, SendsPacketsWithTransportSequenceNumber) {
Erik Språng4580ca22019-07-04 10:38:43 +0200488 RtpRtcp::Configuration config;
489 config.clock = &fake_clock_;
490 config.outgoing_transport = &transport_;
Erik Språng54d5d2c2019-08-20 17:22:36 +0200491 config.local_media_ssrc = kSsrc;
Erik Språng4580ca22019-07-04 10:38:43 +0200492 config.transport_feedback_callback = &feedback_observer_;
493 config.event_log = &mock_rtc_event_log_;
494 config.send_packet_observer = &send_packet_observer_;
495 config.retransmission_rate_limiter = &retransmission_rate_limiter_;
Mirko Bonadei317a1f02019-09-17 17:06:18 +0200496 rtp_sender_ = std::make_unique<RTPSender>(config);
Erik Språng4580ca22019-07-04 10:38:43 +0200497
Stefan Holmerf5dca482016-01-27 12:58:51 +0100498 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
499 kRtpExtensionTransportSequenceNumber,
500 kTransportSequenceNumberExtensionId));
501
asapersson35151f32016-05-02 23:44:01 -0700502 EXPECT_CALL(send_packet_observer_,
503 OnSendPacket(kTransportSequenceNumber, _, _))
504 .Times(1);
minyue3a407ee2017-04-03 01:10:33 -0700505
506 EXPECT_CALL(feedback_observer_,
Erik Språng30a276b2019-04-23 12:00:11 +0200507 OnAddPacket(AllOf(
508 Field(&RtpPacketSendInfo::ssrc, rtp_sender_->SSRC()),
509 Field(&RtpPacketSendInfo::transport_sequence_number,
510 kTransportSequenceNumber),
511 Field(&RtpPacketSendInfo::rtp_sequence_number,
512 rtp_sender_->SequenceNumber()),
513 Field(&RtpPacketSendInfo::pacing_info, PacedPacketInfo()))))
Stefan Holmera246cfb2016-08-23 17:51:42 +0200514 .Times(1);
asapersson35151f32016-05-02 23:44:01 -0700515
Niels Möllere7b9e6b2019-02-06 18:23:44 +0100516 SendGenericPacket();
Stefan Holmerf5dca482016-01-27 12:58:51 +0100517
danilchap12ba1862016-10-26 02:41:55 -0700518 const auto& packet = transport_.last_sent_packet();
519 uint16_t transport_seq_no;
520 ASSERT_TRUE(packet.GetExtension<TransportSequenceNumber>(&transport_seq_no));
521 EXPECT_EQ(kTransportSequenceNumber, transport_seq_no);
Petter Strandmark26bc6692018-05-29 08:43:35 +0200522 EXPECT_EQ(transport_.last_options_.packet_id, transport_seq_no);
Sebastian Jansson1bca65b2018-10-10 09:58:08 +0200523 EXPECT_TRUE(transport_.last_options_.included_in_allocation);
Petter Strandmark26bc6692018-05-29 08:43:35 +0200524}
525
526TEST_P(RtpSenderTestWithoutPacer, PacketOptionsNoRetransmission) {
Erik Språng4580ca22019-07-04 10:38:43 +0200527 RtpRtcp::Configuration config;
528 config.clock = &fake_clock_;
529 config.outgoing_transport = &transport_;
Erik Språng54d5d2c2019-08-20 17:22:36 +0200530 config.local_media_ssrc = kSsrc;
Erik Språng4580ca22019-07-04 10:38:43 +0200531 config.transport_feedback_callback = &feedback_observer_;
532 config.event_log = &mock_rtc_event_log_;
533 config.send_packet_observer = &send_packet_observer_;
534 config.retransmission_rate_limiter = &retransmission_rate_limiter_;
Mirko Bonadei317a1f02019-09-17 17:06:18 +0200535 rtp_sender_ = std::make_unique<RTPSender>(config);
Petter Strandmark26bc6692018-05-29 08:43:35 +0200536
Niels Möllere7b9e6b2019-02-06 18:23:44 +0100537 SendGenericPacket();
Petter Strandmark26bc6692018-05-29 08:43:35 +0200538
539 EXPECT_FALSE(transport_.last_options_.is_retransmit);
Stefan Holmerf5dca482016-01-27 12:58:51 +0100540}
541
Sebastian Jansson1bca65b2018-10-10 09:58:08 +0200542TEST_P(RtpSenderTestWithoutPacer,
543 SetsIncludedInFeedbackWhenTransportSequenceNumberExtensionIsRegistered) {
544 SetUpRtpSender(false, false);
545 rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionTransportSequenceNumber,
546 kTransportSequenceNumberExtensionId);
Sebastian Jansson1bca65b2018-10-10 09:58:08 +0200547 EXPECT_CALL(send_packet_observer_, OnSendPacket).Times(1);
Niels Möllere7b9e6b2019-02-06 18:23:44 +0100548 SendGenericPacket();
Sebastian Jansson1bca65b2018-10-10 09:58:08 +0200549 EXPECT_TRUE(transport_.last_options_.included_in_feedback);
550}
551
552TEST_P(
553 RtpSenderTestWithoutPacer,
554 SetsIncludedInAllocationWhenTransportSequenceNumberExtensionIsRegistered) {
555 SetUpRtpSender(false, false);
556 rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionTransportSequenceNumber,
557 kTransportSequenceNumberExtensionId);
Sebastian Jansson1bca65b2018-10-10 09:58:08 +0200558 EXPECT_CALL(send_packet_observer_, OnSendPacket).Times(1);
Niels Möllere7b9e6b2019-02-06 18:23:44 +0100559 SendGenericPacket();
Sebastian Jansson1bca65b2018-10-10 09:58:08 +0200560 EXPECT_TRUE(transport_.last_options_.included_in_allocation);
561}
562
563TEST_P(RtpSenderTestWithoutPacer,
564 SetsIncludedInAllocationWhenForcedAsPartOfAllocation) {
565 SetUpRtpSender(false, false);
566 rtp_sender_->SetAsPartOfAllocation(true);
Niels Möllere7b9e6b2019-02-06 18:23:44 +0100567 SendGenericPacket();
Sebastian Jansson1bca65b2018-10-10 09:58:08 +0200568 EXPECT_FALSE(transport_.last_options_.included_in_feedback);
569 EXPECT_TRUE(transport_.last_options_.included_in_allocation);
570}
571
572TEST_P(RtpSenderTestWithoutPacer, DoesnSetIncludedInAllocationByDefault) {
573 SetUpRtpSender(false, false);
Niels Möllere7b9e6b2019-02-06 18:23:44 +0100574 SendGenericPacket();
Sebastian Jansson1bca65b2018-10-10 09:58:08 +0200575 EXPECT_FALSE(transport_.last_options_.included_in_feedback);
576 EXPECT_FALSE(transport_.last_options_.included_in_allocation);
stefana23fc622016-07-28 07:56:38 -0700577}
asapersson35151f32016-05-02 23:44:01 -0700578
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200579TEST_P(RtpSenderTestWithoutPacer, OnSendSideDelayUpdated) {
Erik Språng9c771c22019-06-17 16:31:53 +0200580 StrictMock<MockSendSideDelayObserver> send_side_delay_observer_;
Erik Språng4580ca22019-07-04 10:38:43 +0200581
582 RtpRtcp::Configuration config;
583 config.clock = &fake_clock_;
584 config.outgoing_transport = &transport_;
Erik Språng54d5d2c2019-08-20 17:22:36 +0200585 config.local_media_ssrc = kSsrc;
Erik Språng4580ca22019-07-04 10:38:43 +0200586 config.send_side_delay_observer = &send_side_delay_observer_;
587 config.event_log = &mock_rtc_event_log_;
Mirko Bonadei317a1f02019-09-17 17:06:18 +0200588 rtp_sender_ = std::make_unique<RTPSender>(config);
Erik Språng4580ca22019-07-04 10:38:43 +0200589
Niels Möller5fe95102019-03-04 16:49:25 +0100590 PlayoutDelayOracle playout_delay_oracle;
Erik Språngdc34a252019-10-04 15:17:29 +0200591 FieldTrialBasedConfig field_trials;
592 RTPSenderVideo::Config video_config;
593 video_config.clock = &fake_clock_;
594 video_config.rtp_sender = rtp_sender_.get();
595 video_config.playout_delay_oracle = &playout_delay_oracle;
596 video_config.field_trials = &field_trials;
597 RTPSenderVideo rtp_sender_video(video_config);
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200598
599 const uint8_t kPayloadType = 127;
Erik Språng6cf554e2019-10-02 20:55:39 +0200600 const absl::optional<VideoCodecType> kCodecType =
601 VideoCodecType::kVideoCodecGeneric;
Niels Möller59ab1cf2019-02-06 22:48:11 +0100602
603 const uint32_t kCaptureTimeMsToRtpTimestamp = 90; // 90 kHz clock
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200604 RTPVideoHeader video_header;
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200605
Henrik Boström9fe18342019-05-16 18:38:20 +0200606 // Send packet with 10 ms send-side delay. The average, max and total should
607 // be 10 ms.
608 EXPECT_CALL(send_side_delay_observer_,
609 SendSideDelayUpdated(10, 10, 10, kSsrc))
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200610 .Times(1);
611 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
612 fake_clock_.AdvanceTimeMilliseconds(10);
Danil Chapovalov51bf2002019-10-11 10:53:27 +0200613 video_header.frame_type = VideoFrameType::kVideoFrameKey;
Niels Möller59ab1cf2019-02-06 22:48:11 +0100614 EXPECT_TRUE(rtp_sender_video.SendVideo(
Danil Chapovalov51bf2002019-10-11 10:53:27 +0200615 kPayloadType, kCodecType, capture_time_ms * kCaptureTimeMsToRtpTimestamp,
616 capture_time_ms, kPayloadData, nullptr, video_header,
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200617 kDefaultExpectedRetransmissionTimeMs));
618
Henrik Boström9fe18342019-05-16 18:38:20 +0200619 // Send another packet with 20 ms delay. The average, max and total should be
620 // 15, 20 and 30 ms respectively.
621 EXPECT_CALL(send_side_delay_observer_,
622 SendSideDelayUpdated(15, 20, 30, kSsrc))
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200623 .Times(1);
624 fake_clock_.AdvanceTimeMilliseconds(10);
Danil Chapovalov51bf2002019-10-11 10:53:27 +0200625 video_header.frame_type = VideoFrameType::kVideoFrameKey;
Niels Möller59ab1cf2019-02-06 22:48:11 +0100626 EXPECT_TRUE(rtp_sender_video.SendVideo(
Danil Chapovalov51bf2002019-10-11 10:53:27 +0200627 kPayloadType, kCodecType, capture_time_ms * kCaptureTimeMsToRtpTimestamp,
628 capture_time_ms, kPayloadData, nullptr, video_header,
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200629 kDefaultExpectedRetransmissionTimeMs));
630
631 // Send another packet at the same time, which replaces the last packet.
632 // Since this packet has 0 ms delay, the average is now 5 ms and max is 10 ms.
Henrik Boström9fe18342019-05-16 18:38:20 +0200633 // The total counter stays the same though.
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200634 // TODO(terelius): Is is not clear that this is the right behavior.
Henrik Boström9fe18342019-05-16 18:38:20 +0200635 EXPECT_CALL(send_side_delay_observer_, SendSideDelayUpdated(5, 10, 30, kSsrc))
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200636 .Times(1);
637 capture_time_ms = fake_clock_.TimeInMilliseconds();
Danil Chapovalov51bf2002019-10-11 10:53:27 +0200638 video_header.frame_type = VideoFrameType::kVideoFrameKey;
Niels Möller59ab1cf2019-02-06 22:48:11 +0100639 EXPECT_TRUE(rtp_sender_video.SendVideo(
Danil Chapovalov51bf2002019-10-11 10:53:27 +0200640 kPayloadType, kCodecType, capture_time_ms * kCaptureTimeMsToRtpTimestamp,
641 capture_time_ms, kPayloadData, nullptr, video_header,
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200642 kDefaultExpectedRetransmissionTimeMs));
643
644 // Send a packet 1 second later. The earlier packets should have timed
Henrik Boström9fe18342019-05-16 18:38:20 +0200645 // out, so both max and average should be the delay of this packet. The total
646 // keeps increasing.
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200647 fake_clock_.AdvanceTimeMilliseconds(1000);
648 capture_time_ms = fake_clock_.TimeInMilliseconds();
649 fake_clock_.AdvanceTimeMilliseconds(1);
Henrik Boström9fe18342019-05-16 18:38:20 +0200650 EXPECT_CALL(send_side_delay_observer_, SendSideDelayUpdated(1, 1, 31, kSsrc))
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200651 .Times(1);
Danil Chapovalov51bf2002019-10-11 10:53:27 +0200652 video_header.frame_type = VideoFrameType::kVideoFrameKey;
Niels Möller59ab1cf2019-02-06 22:48:11 +0100653 EXPECT_TRUE(rtp_sender_video.SendVideo(
Danil Chapovalov51bf2002019-10-11 10:53:27 +0200654 kPayloadType, kCodecType, capture_time_ms * kCaptureTimeMsToRtpTimestamp,
655 capture_time_ms, kPayloadData, nullptr, video_header,
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200656 kDefaultExpectedRetransmissionTimeMs));
657}
658
minyue3a407ee2017-04-03 01:10:33 -0700659TEST_P(RtpSenderTestWithoutPacer, OnSendPacketUpdated) {
stefana23fc622016-07-28 07:56:38 -0700660 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
661 kRtpExtensionTransportSequenceNumber,
662 kTransportSequenceNumberExtensionId));
asapersson35151f32016-05-02 23:44:01 -0700663 EXPECT_CALL(send_packet_observer_,
664 OnSendPacket(kTransportSequenceNumber, _, _))
665 .Times(1);
666
Niels Möllere7b9e6b2019-02-06 18:23:44 +0100667 SendGenericPacket();
asapersson35151f32016-05-02 23:44:01 -0700668}
669
minyue3a407ee2017-04-03 01:10:33 -0700670TEST_P(RtpSenderTest, SendsPacketsWithTransportSequenceNumber) {
Erik Språng4580ca22019-07-04 10:38:43 +0200671 RtpRtcp::Configuration config;
672 config.clock = &fake_clock_;
673 config.outgoing_transport = &transport_;
674 config.paced_sender = &mock_paced_sender_;
Erik Språng54d5d2c2019-08-20 17:22:36 +0200675 config.local_media_ssrc = kSsrc;
Erik Språng4580ca22019-07-04 10:38:43 +0200676 config.transport_feedback_callback = &feedback_observer_;
677 config.event_log = &mock_rtc_event_log_;
678 config.send_packet_observer = &send_packet_observer_;
679 config.retransmission_rate_limiter = &retransmission_rate_limiter_;
Mirko Bonadei317a1f02019-09-17 17:06:18 +0200680 rtp_sender_ = std::make_unique<RTPSender>(config);
Erik Språng4580ca22019-07-04 10:38:43 +0200681
brandtr9dfff292016-11-14 05:14:50 -0800682 rtp_sender_->SetSequenceNumber(kSeqNum);
Stefan Holmera246cfb2016-08-23 17:51:42 +0200683 rtp_sender_->SetStorePacketsStatus(true, 10);
684 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
685 kRtpExtensionTransportSequenceNumber,
686 kTransportSequenceNumberExtensionId));
687
Stefan Holmera246cfb2016-08-23 17:51:42 +0200688 EXPECT_CALL(send_packet_observer_,
689 OnSendPacket(kTransportSequenceNumber, _, _))
690 .Times(1);
minyue3a407ee2017-04-03 01:10:33 -0700691 EXPECT_CALL(feedback_observer_,
Erik Språng30a276b2019-04-23 12:00:11 +0200692 OnAddPacket(AllOf(
693 Field(&RtpPacketSendInfo::ssrc, rtp_sender_->SSRC()),
694 Field(&RtpPacketSendInfo::transport_sequence_number,
695 kTransportSequenceNumber),
696 Field(&RtpPacketSendInfo::rtp_sequence_number,
697 rtp_sender_->SequenceNumber()),
698 Field(&RtpPacketSendInfo::pacing_info, PacedPacketInfo()))))
Stefan Holmera246cfb2016-08-23 17:51:42 +0200699 .Times(1);
700
Erik Språngf5815fa2019-08-21 14:27:31 +0200701 EXPECT_CALL(
702 mock_paced_sender_,
Erik Språngea55b082019-10-02 14:57:46 +0200703 EnqueuePackets(Contains(AllOf(
704 Pointee(Property(&RtpPacketToSend::Ssrc, kSsrc)),
705 Pointee(Property(&RtpPacketToSend::SequenceNumber, kSeqNum))))));
Erik Språngf5815fa2019-08-21 14:27:31 +0200706 auto packet = SendGenericPacket();
707 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
708 // Transport sequence number is set by PacketRouter, before TrySendPacket().
709 packet->SetExtension<TransportSequenceNumber>(kTransportSequenceNumber);
710 rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo());
Stefan Holmera246cfb2016-08-23 17:51:42 +0200711
danilchap12ba1862016-10-26 02:41:55 -0700712 uint16_t transport_seq_no;
Erik Språngf5815fa2019-08-21 14:27:31 +0200713 EXPECT_TRUE(
714 transport_.last_sent_packet().GetExtension<TransportSequenceNumber>(
715 &transport_seq_no));
danilchap12ba1862016-10-26 02:41:55 -0700716 EXPECT_EQ(kTransportSequenceNumber, transport_seq_no);
Petter Strandmark26bc6692018-05-29 08:43:35 +0200717 EXPECT_EQ(transport_.last_options_.packet_id, transport_seq_no);
Stefan Holmera246cfb2016-08-23 17:51:42 +0200718}
719
Erik Språng7b52f102018-02-07 14:37:37 +0100720TEST_P(RtpSenderTest, WritesPacerExitToTimingExtension) {
ilnik04f4d122017-06-19 07:18:55 -0700721 rtp_sender_->SetStorePacketsStatus(true, 10);
722 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
723 kRtpExtensionVideoTiming, kVideoTimingExtensionId));
724 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
725 auto packet = rtp_sender_->AllocatePacket();
726 packet->SetPayloadType(kPayload);
727 packet->SetMarker(true);
728 packet->SetTimestamp(kTimestamp);
729 packet->set_capture_time_ms(capture_time_ms);
ilnik2edc6842017-07-06 03:06:50 -0700730 const VideoSendTiming kVideoTiming = {0u, 0u, 0u, 0u, 0u, 0u, true};
ilnik04f4d122017-06-19 07:18:55 -0700731 packet->SetExtension<VideoTimingExtension>(kVideoTiming);
732 EXPECT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
733 size_t packet_size = packet->size();
ilnik04f4d122017-06-19 07:18:55 -0700734
735 const int kStoredTimeInMs = 100;
Erik Språngf5815fa2019-08-21 14:27:31 +0200736 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
Erik Språng70768f42019-08-27 18:16:26 +0200737 packet->set_allow_retransmission(true);
Erik Språngea55b082019-10-02 14:57:46 +0200738 EXPECT_CALL(mock_paced_sender_, EnqueuePackets(Contains(Pointee(Property(
739 &RtpPacketToSend::Ssrc, kSsrc)))));
Erik Språng70768f42019-08-27 18:16:26 +0200740 EXPECT_TRUE(
Mirko Bonadei317a1f02019-09-17 17:06:18 +0200741 rtp_sender_->SendToNetwork(std::make_unique<RtpPacketToSend>(*packet)));
Erik Språngf5815fa2019-08-21 14:27:31 +0200742 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
743 rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo());
ilnik04f4d122017-06-19 07:18:55 -0700744 EXPECT_EQ(1, transport_.packets_sent());
745 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
746
danilchapce251812017-09-11 12:24:41 -0700747 VideoSendTiming video_timing;
748 EXPECT_TRUE(transport_.last_sent_packet().GetExtension<VideoTimingExtension>(
749 &video_timing));
750 EXPECT_EQ(kStoredTimeInMs, video_timing.pacer_exit_delta_ms);
Erik Språng7b52f102018-02-07 14:37:37 +0100751}
ilnik04f4d122017-06-19 07:18:55 -0700752
Danil Chapovalovaf52b682018-11-27 10:48:27 +0100753TEST_P(RtpSenderTest, WritesNetwork2ToTimingExtensionWithPacer) {
754 SetUpRtpSender(/*pacer=*/true, /*populate_network2=*/true);
Erik Språng7b52f102018-02-07 14:37:37 +0100755 rtp_sender_->SetStorePacketsStatus(true, 10);
756 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
757 kRtpExtensionVideoTiming, kVideoTimingExtensionId));
758 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
759 auto packet = rtp_sender_->AllocatePacket();
760 packet->SetPayloadType(kPayload);
761 packet->SetMarker(true);
762 packet->SetTimestamp(kTimestamp);
763 packet->set_capture_time_ms(capture_time_ms);
764 const uint16_t kPacerExitMs = 1234u;
765 const VideoSendTiming kVideoTiming = {0u, 0u, 0u, kPacerExitMs, 0u, 0u, true};
766 packet->SetExtension<VideoTimingExtension>(kVideoTiming);
767 EXPECT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
768 size_t packet_size = packet->size();
769
770 const int kStoredTimeInMs = 100;
Erik Språngf6468d22019-07-05 16:53:43 +0200771
Erik Språngf6468d22019-07-05 16:53:43 +0200772 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
Erik Språng70768f42019-08-27 18:16:26 +0200773 packet->set_allow_retransmission(true);
Erik Språngea55b082019-10-02 14:57:46 +0200774 EXPECT_CALL(mock_paced_sender_, EnqueuePackets(Contains(Pointee(Property(
775 &RtpPacketToSend::Ssrc, kSsrc)))));
Mirko Bonadei317a1f02019-09-17 17:06:18 +0200776 EXPECT_TRUE(
777 rtp_sender_->SendToNetwork(std::make_unique<RtpPacketToSend>(*packet)));
Erik Språngf6468d22019-07-05 16:53:43 +0200778 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
779 rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo());
Erik Språngf6468d22019-07-05 16:53:43 +0200780
Erik Språng7b52f102018-02-07 14:37:37 +0100781 EXPECT_EQ(1, transport_.packets_sent());
ilnik04f4d122017-06-19 07:18:55 -0700782 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
783
Erik Språng7b52f102018-02-07 14:37:37 +0100784 VideoSendTiming video_timing;
danilchapce251812017-09-11 12:24:41 -0700785 EXPECT_TRUE(transport_.last_sent_packet().GetExtension<VideoTimingExtension>(
786 &video_timing));
Erik Språng7b52f102018-02-07 14:37:37 +0100787 EXPECT_EQ(kStoredTimeInMs, video_timing.network2_timestamp_delta_ms);
788 EXPECT_EQ(kPacerExitMs, video_timing.pacer_exit_delta_ms);
ilnik04f4d122017-06-19 07:18:55 -0700789}
790
Danil Chapovalovaf52b682018-11-27 10:48:27 +0100791TEST_P(RtpSenderTest, WritesNetwork2ToTimingExtensionWithoutPacer) {
792 SetUpRtpSender(/*pacer=*/false, /*populate_network2=*/true);
793 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
794 kRtpExtensionVideoTiming, kVideoTimingExtensionId));
795 auto packet = rtp_sender_->AllocatePacket();
796 packet->SetMarker(true);
797 packet->set_capture_time_ms(fake_clock_.TimeInMilliseconds());
798 const VideoSendTiming kVideoTiming = {0u, 0u, 0u, 0u, 0u, 0u, true};
799 packet->SetExtension<VideoTimingExtension>(kVideoTiming);
Erik Språng70768f42019-08-27 18:16:26 +0200800 packet->set_allow_retransmission(true);
Danil Chapovalovaf52b682018-11-27 10:48:27 +0100801 EXPECT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
Erik Språng1fbfecd2019-08-26 19:00:05 +0200802 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
Danil Chapovalovaf52b682018-11-27 10:48:27 +0100803
804 const int kPropagateTimeMs = 10;
805 fake_clock_.AdvanceTimeMilliseconds(kPropagateTimeMs);
806
Erik Språng70768f42019-08-27 18:16:26 +0200807 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet)));
Danil Chapovalovaf52b682018-11-27 10:48:27 +0100808
809 EXPECT_EQ(1, transport_.packets_sent());
810 absl::optional<VideoSendTiming> video_timing =
811 transport_.last_sent_packet().GetExtension<VideoTimingExtension>();
812 ASSERT_TRUE(video_timing);
813 EXPECT_EQ(kPropagateTimeMs, video_timing->network2_timestamp_delta_ms);
814}
815
minyue3a407ee2017-04-03 01:10:33 -0700816TEST_P(RtpSenderTest, TrafficSmoothingWithExtensions) {
Elad Alon4a87e1c2017-10-03 16:11:34 +0200817 EXPECT_CALL(mock_rtc_event_log_,
818 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)));
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000819
pwestin@webrtc.orgc66e8b32012-11-07 17:01:04 +0000820 rtp_sender_->SetStorePacketsStatus(true, 10);
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000821 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
danilchap162abd32015-12-10 02:39:40 -0800822 kRtpExtensionTransmissionTimeOffset,
823 kTransmissionTimeOffsetExtensionId));
824 EXPECT_EQ(
825 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
826 kAbsoluteSendTimeExtensionId));
stefan@webrtc.org8ccb9f92013-06-19 14:13:42 +0000827 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
danilchapb6f1fb52016-10-19 06:11:39 -0700828 auto packet =
829 BuildRtpPacket(kPayload, kMarkerBit, kTimestamp, capture_time_ms);
830 size_t packet_size = packet->size();
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000831
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000832 const int kStoredTimeInMs = 100;
Erik Språngea55b082019-10-02 14:57:46 +0200833 EXPECT_CALL(
834 mock_paced_sender_,
835 EnqueuePackets(Contains(AllOf(
836 Pointee(Property(&RtpPacketToSend::Ssrc, kSsrc)),
837 Pointee(Property(&RtpPacketToSend::SequenceNumber, kSeqNum))))));
838 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
839 packet->set_allow_retransmission(true);
840 EXPECT_TRUE(
841 rtp_sender_->SendToNetwork(std::make_unique<RtpPacketToSend>(*packet)));
842 EXPECT_EQ(0, transport_.packets_sent());
843 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
844 rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000845
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000846 // Process send bucket. Packet should now be sent.
danilchap12ba1862016-10-26 02:41:55 -0700847 EXPECT_EQ(1, transport_.packets_sent());
848 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
849
stefan@webrtc.orga5cb98c2013-05-29 12:12:51 +0000850 webrtc::RTPHeader rtp_header;
danilchap12ba1862016-10-26 02:41:55 -0700851 transport_.last_sent_packet().GetHeader(&rtp_header);
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000852
853 // Verify transmission time offset.
854 EXPECT_EQ(kStoredTimeInMs * 90, rtp_header.extension.transmissionTimeOffset);
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000855 uint64_t expected_send_time =
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000856 ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds());
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000857 EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime);
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000858}
859
minyue3a407ee2017-04-03 01:10:33 -0700860TEST_P(RtpSenderTest, TrafficSmoothingRetransmits) {
Elad Alon4a87e1c2017-10-03 16:11:34 +0200861 EXPECT_CALL(mock_rtc_event_log_,
862 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)));
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000863
864 rtp_sender_->SetStorePacketsStatus(true, 10);
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000865 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
danilchap162abd32015-12-10 02:39:40 -0800866 kRtpExtensionTransmissionTimeOffset,
867 kTransmissionTimeOffsetExtensionId));
868 EXPECT_EQ(
869 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
870 kAbsoluteSendTimeExtensionId));
stefan@webrtc.org8ccb9f92013-06-19 14:13:42 +0000871 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
danilchapb6f1fb52016-10-19 06:11:39 -0700872 auto packet =
873 BuildRtpPacket(kPayload, kMarkerBit, kTimestamp, capture_time_ms);
874 size_t packet_size = packet->size();
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000875
876 // Packet should be stored in a send bucket.
Erik Språngea55b082019-10-02 14:57:46 +0200877 EXPECT_CALL(
878 mock_paced_sender_,
879 EnqueuePackets(Contains(AllOf(
880 Pointee(Property(&RtpPacketToSend::Ssrc, kSsrc)),
881 Pointee(Property(&RtpPacketToSend::SequenceNumber, kSeqNum))))));
882 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
883 packet->set_allow_retransmission(true);
884 EXPECT_TRUE(
885 rtp_sender_->SendToNetwork(std::make_unique<RtpPacketToSend>(*packet)));
886 // Immediately process send bucket and send packet.
887 rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo());
Erik Språngf6468d22019-07-05 16:53:43 +0200888
Erik Språng0f4f0552019-05-08 10:15:05 -0700889 EXPECT_EQ(1, transport_.packets_sent());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000890
Erik Språng0f4f0552019-05-08 10:15:05 -0700891 // Retransmit packet.
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000892 const int kStoredTimeInMs = 100;
893 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
894
Erik Språng0f4f0552019-05-08 10:15:05 -0700895 EXPECT_CALL(mock_rtc_event_log_,
896 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)));
Erik Språngf6468d22019-07-05 16:53:43 +0200897 packet->set_packet_type(RtpPacketToSend::Type::kRetransmission);
898 packet->set_retransmitted_sequence_number(kSeqNum);
899 EXPECT_CALL(
900 mock_paced_sender_,
Erik Språngea55b082019-10-02 14:57:46 +0200901 EnqueuePackets(Contains(AllOf(
Erik Språngf6468d22019-07-05 16:53:43 +0200902 Pointee(Property(&RtpPacketToSend::Ssrc, kSsrc)),
Erik Språngea55b082019-10-02 14:57:46 +0200903 Pointee(Property(&RtpPacketToSend::SequenceNumber, kSeqNum))))));
Erik Språngf6468d22019-07-05 16:53:43 +0200904 EXPECT_EQ(static_cast<int>(packet_size),
905 rtp_sender_->ReSendPacket(kSeqNum));
906 EXPECT_EQ(1, transport_.packets_sent());
907 rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000908
909 // Process send bucket. Packet should now be sent.
Erik Språng0f4f0552019-05-08 10:15:05 -0700910 EXPECT_EQ(2, transport_.packets_sent());
danilchap12ba1862016-10-26 02:41:55 -0700911 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000912
stefan@webrtc.orga5cb98c2013-05-29 12:12:51 +0000913 webrtc::RTPHeader rtp_header;
danilchap12ba1862016-10-26 02:41:55 -0700914 transport_.last_sent_packet().GetHeader(&rtp_header);
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000915
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000916 // Verify transmission time offset.
917 EXPECT_EQ(kStoredTimeInMs * 90, rtp_header.extension.transmissionTimeOffset);
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000918 uint64_t expected_send_time =
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000919 ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds());
920 EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime);
921}
922
923// This test sends 1 regular video packet, then 4 padding packets, and then
924// 1 more regular packet.
minyue3a407ee2017-04-03 01:10:33 -0700925TEST_P(RtpSenderTest, SendPadding) {
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000926 // Make all (non-padding) packets go to send queue.
Elad Alon4a87e1c2017-10-03 16:11:34 +0200927 EXPECT_CALL(mock_rtc_event_log_,
928 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
929 .Times(1 + 4 + 1);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000930
931 uint16_t seq_num = kSeqNum;
932 uint32_t timestamp = kTimestamp;
933 rtp_sender_->SetStorePacketsStatus(true, 10);
pkasting@chromium.org4591fbd2014-11-20 22:28:14 +0000934 size_t rtp_header_len = kRtpHeaderSize;
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000935 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
danilchap162abd32015-12-10 02:39:40 -0800936 kRtpExtensionTransmissionTimeOffset,
937 kTransmissionTimeOffsetExtensionId));
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000938 rtp_header_len += 4; // 4 bytes extension.
danilchap162abd32015-12-10 02:39:40 -0800939 EXPECT_EQ(
940 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
941 kAbsoluteSendTimeExtensionId));
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000942 rtp_header_len += 4; // 4 bytes extension.
943 rtp_header_len += 4; // 4 extra bytes common to all extension headers.
944
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000945 webrtc::RTPHeader rtp_header;
946
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000947 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
danilchapb6f1fb52016-10-19 06:11:39 -0700948 auto packet =
949 BuildRtpPacket(kPayload, kMarkerBit, timestamp, capture_time_ms);
Stefan Holmer586b19b2015-09-18 11:14:31 +0200950 const uint32_t media_packet_timestamp = timestamp;
danilchapb6f1fb52016-10-19 06:11:39 -0700951 size_t packet_size = packet->size();
Erik Språngf6468d22019-07-05 16:53:43 +0200952 int total_packets_sent = 0;
953 const int kStoredTimeInMs = 100;
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000954
955 // Packet should be stored in a send bucket.
Erik Språngea55b082019-10-02 14:57:46 +0200956 EXPECT_CALL(
957 mock_paced_sender_,
958 EnqueuePackets(Contains(AllOf(
959 Pointee(Property(&RtpPacketToSend::Ssrc, kSsrc)),
960 Pointee(Property(&RtpPacketToSend::SequenceNumber, kSeqNum))))));
961 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
962 packet->set_allow_retransmission(true);
963 EXPECT_TRUE(
964 rtp_sender_->SendToNetwork(std::make_unique<RtpPacketToSend>(*packet)));
965 EXPECT_EQ(total_packets_sent, transport_.packets_sent());
966 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
967 rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo());
968 ++seq_num;
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000969
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000970 // Packet should now be sent. This test doesn't verify the regular video
971 // packet, since it is tested in another test.
danilchap12ba1862016-10-26 02:41:55 -0700972 EXPECT_EQ(++total_packets_sent, transport_.packets_sent());
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000973 timestamp += 90 * kStoredTimeInMs;
974
975 // Send padding 4 times, waiting 50 ms between each.
976 for (int i = 0; i < 4; ++i) {
977 const int kPaddingPeriodMs = 50;
pkasting@chromium.org4591fbd2014-11-20 22:28:14 +0000978 const size_t kPaddingBytes = 100;
979 const size_t kMaxPaddingLength = 224; // Value taken from rtp_sender.cc.
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000980 // Padding will be forced to full packets.
Erik Språng4208a132019-08-26 08:58:45 +0200981 EXPECT_EQ(kMaxPaddingLength, GenerateAndSendPadding(kPaddingBytes));
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000982
983 // Process send bucket. Padding should now be sent.
danilchap12ba1862016-10-26 02:41:55 -0700984 EXPECT_EQ(++total_packets_sent, transport_.packets_sent());
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000985 EXPECT_EQ(kMaxPaddingLength + rtp_header_len,
danilchap12ba1862016-10-26 02:41:55 -0700986 transport_.last_sent_packet().size());
987
988 transport_.last_sent_packet().GetHeader(&rtp_header);
pbosbd2522a2015-07-01 05:35:53 -0700989 EXPECT_EQ(kMaxPaddingLength, rtp_header.paddingLength);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000990
Stefan Holmer586b19b2015-09-18 11:14:31 +0200991 // Verify sequence number and timestamp. The timestamp should be the same
992 // as the last media packet.
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000993 EXPECT_EQ(seq_num++, rtp_header.sequenceNumber);
Stefan Holmer586b19b2015-09-18 11:14:31 +0200994 EXPECT_EQ(media_packet_timestamp, rtp_header.timestamp);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000995 // Verify transmission time offset.
Stefan Holmer586b19b2015-09-18 11:14:31 +0200996 int offset = timestamp - media_packet_timestamp;
997 EXPECT_EQ(offset, rtp_header.extension.transmissionTimeOffset);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000998 uint64_t expected_send_time =
999 ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds());
1000 EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime);
1001 fake_clock_.AdvanceTimeMilliseconds(kPaddingPeriodMs);
1002 timestamp += 90 * kPaddingPeriodMs;
1003 }
1004
1005 // Send a regular video packet again.
1006 capture_time_ms = fake_clock_.TimeInMilliseconds();
danilchapb6f1fb52016-10-19 06:11:39 -07001007 packet = BuildRtpPacket(kPayload, kMarkerBit, timestamp, capture_time_ms);
1008 packet_size = packet->size();
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +00001009
Erik Språngf6468d22019-07-05 16:53:43 +02001010 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
Erik Språng70768f42019-08-27 18:16:26 +02001011 packet->set_allow_retransmission(true);
Erik Språngf6468d22019-07-05 16:53:43 +02001012 EXPECT_CALL(
1013 mock_paced_sender_,
Erik Språngea55b082019-10-02 14:57:46 +02001014 EnqueuePackets(Contains(AllOf(
Erik Språngf6468d22019-07-05 16:53:43 +02001015 Pointee(Property(&RtpPacketToSend::Ssrc, kSsrc)),
Erik Språngea55b082019-10-02 14:57:46 +02001016 Pointee(Property(&RtpPacketToSend::SequenceNumber, seq_num))))));
Mirko Bonadei317a1f02019-09-17 17:06:18 +02001017 EXPECT_TRUE(
1018 rtp_sender_->SendToNetwork(std::make_unique<RtpPacketToSend>(*packet)));
Erik Språngf6468d22019-07-05 16:53:43 +02001019 rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo());
terelius5d332ac2016-01-14 14:37:39 -08001020
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +00001021 // Process send bucket.
danilchap12ba1862016-10-26 02:41:55 -07001022 EXPECT_EQ(++total_packets_sent, transport_.packets_sent());
1023 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
1024 transport_.last_sent_packet().GetHeader(&rtp_header);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +00001025
1026 // Verify sequence number and timestamp.
1027 EXPECT_EQ(seq_num, rtp_header.sequenceNumber);
1028 EXPECT_EQ(timestamp, rtp_header.timestamp);
1029 // Verify transmission time offset. This packet is sent without delay.
1030 EXPECT_EQ(0, rtp_header.extension.transmissionTimeOffset);
1031 uint64_t expected_send_time =
1032 ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds());
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +00001033 EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime);
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +00001034}
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001035
minyue3a407ee2017-04-03 01:10:33 -07001036TEST_P(RtpSenderTest, OnSendPacketUpdated) {
stefana23fc622016-07-28 07:56:38 -07001037 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
1038 kRtpExtensionTransportSequenceNumber,
1039 kTransportSequenceNumberExtensionId));
asapersson35151f32016-05-02 23:44:01 -07001040 rtp_sender_->SetStorePacketsStatus(true, 10);
1041
1042 EXPECT_CALL(send_packet_observer_,
1043 OnSendPacket(kTransportSequenceNumber, _, _))
1044 .Times(1);
asapersson35151f32016-05-02 23:44:01 -07001045
Erik Språngea55b082019-10-02 14:57:46 +02001046 EXPECT_CALL(
1047 mock_paced_sender_,
1048 EnqueuePackets(Contains(AllOf(
1049 Pointee(Property(&RtpPacketToSend::Ssrc, kSsrc)),
1050 Pointee(Property(&RtpPacketToSend::SequenceNumber, kSeqNum))))));
1051 auto packet = SendGenericPacket();
1052 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
1053 packet->SetExtension<TransportSequenceNumber>(kTransportSequenceNumber);
1054 rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo());
Erik Språngf6468d22019-07-05 16:53:43 +02001055
danilchap12ba1862016-10-26 02:41:55 -07001056 EXPECT_EQ(1, transport_.packets_sent());
asapersson35151f32016-05-02 23:44:01 -07001057}
1058
minyue3a407ee2017-04-03 01:10:33 -07001059TEST_P(RtpSenderTest, OnSendPacketNotUpdatedForRetransmits) {
stefana23fc622016-07-28 07:56:38 -07001060 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
1061 kRtpExtensionTransportSequenceNumber,
1062 kTransportSequenceNumberExtensionId));
asapersson35151f32016-05-02 23:44:01 -07001063 rtp_sender_->SetStorePacketsStatus(true, 10);
1064
1065 EXPECT_CALL(send_packet_observer_, OnSendPacket(_, _, _)).Times(0);
asapersson35151f32016-05-02 23:44:01 -07001066
Erik Språngea55b082019-10-02 14:57:46 +02001067 EXPECT_CALL(
1068 mock_paced_sender_,
1069 EnqueuePackets(Contains(AllOf(
1070 Pointee(Property(&RtpPacketToSend::Ssrc, kSsrc)),
1071 Pointee(Property(&RtpPacketToSend::SequenceNumber, kSeqNum))))));
1072 auto packet = SendGenericPacket();
1073 packet->set_packet_type(RtpPacketToSend::Type::kRetransmission);
1074 packet->SetExtension<TransportSequenceNumber>(kTransportSequenceNumber);
1075 rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo());
Erik Språngf6468d22019-07-05 16:53:43 +02001076
danilchap12ba1862016-10-26 02:41:55 -07001077 EXPECT_EQ(1, transport_.packets_sent());
Petter Strandmark26bc6692018-05-29 08:43:35 +02001078 EXPECT_TRUE(transport_.last_options_.is_retransmit);
asapersson35151f32016-05-02 23:44:01 -07001079}
1080
minyue3a407ee2017-04-03 01:10:33 -07001081TEST_P(RtpSenderTestWithoutPacer, SendGenericVideo) {
Erik Språng6cf554e2019-10-02 20:55:39 +02001082 const uint8_t kPayloadType = 127;
1083 const VideoCodecType kCodecType = VideoCodecType::kVideoCodecGeneric;
Niels Möller5fe95102019-03-04 16:49:25 +01001084 PlayoutDelayOracle playout_delay_oracle;
Erik Språngdc34a252019-10-04 15:17:29 +02001085 FieldTrialBasedConfig field_trials;
1086 RTPSenderVideo::Config video_config;
1087 video_config.clock = &fake_clock_;
1088 video_config.rtp_sender = rtp_sender_.get();
1089 video_config.playout_delay_oracle = &playout_delay_oracle;
1090 video_config.field_trials = &field_trials;
1091 RTPSenderVideo rtp_sender_video(video_config);
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001092 uint8_t payload[] = {47, 11, 32, 93, 89};
1093
1094 // Send keyframe
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001095 RTPVideoHeader video_header;
Danil Chapovalov51bf2002019-10-11 10:53:27 +02001096 video_header.frame_type = VideoFrameType::kVideoFrameKey;
1097 ASSERT_TRUE(rtp_sender_video.SendVideo(kPayloadType, kCodecType, 1234, 4321,
1098 payload, nullptr, video_header,
1099 kDefaultExpectedRetransmissionTimeMs));
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001100
danilchap96c15872016-11-21 01:35:29 -08001101 auto sent_payload = transport_.last_sent_packet().payload();
1102 uint8_t generic_header = sent_payload[0];
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001103 EXPECT_TRUE(generic_header & RtpFormatVideoGeneric::kKeyFrameBit);
1104 EXPECT_TRUE(generic_header & RtpFormatVideoGeneric::kFirstPacketBit);
danilchap96c15872016-11-21 01:35:29 -08001105 EXPECT_THAT(sent_payload.subview(1), ElementsAreArray(payload));
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001106
1107 // Send delta frame
1108 payload[0] = 13;
1109 payload[1] = 42;
1110 payload[4] = 13;
1111
Danil Chapovalov51bf2002019-10-11 10:53:27 +02001112 video_header.frame_type = VideoFrameType::kVideoFrameDelta;
1113 ASSERT_TRUE(rtp_sender_video.SendVideo(kPayloadType, kCodecType, 1234, 4321,
1114 payload, nullptr, video_header,
1115 kDefaultExpectedRetransmissionTimeMs));
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001116
danilchap96c15872016-11-21 01:35:29 -08001117 sent_payload = transport_.last_sent_packet().payload();
1118 generic_header = sent_payload[0];
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001119 EXPECT_FALSE(generic_header & RtpFormatVideoGeneric::kKeyFrameBit);
1120 EXPECT_TRUE(generic_header & RtpFormatVideoGeneric::kFirstPacketBit);
danilchap96c15872016-11-21 01:35:29 -08001121 EXPECT_THAT(sent_payload.subview(1), ElementsAreArray(payload));
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001122}
1123
Mirta Dvornicicfe68daa2019-05-23 13:21:12 +02001124TEST_P(RtpSenderTestWithoutPacer, SendRawVideo) {
Erik Språng6cf554e2019-10-02 20:55:39 +02001125 const uint8_t kPayloadType = 111;
Mirta Dvornicicfe68daa2019-05-23 13:21:12 +02001126 const uint8_t payload[] = {11, 22, 33, 44, 55};
1127
1128 PlayoutDelayOracle playout_delay_oracle;
Erik Språngdc34a252019-10-04 15:17:29 +02001129 FieldTrialBasedConfig field_trials;
1130 RTPSenderVideo::Config video_config;
1131 video_config.clock = &fake_clock_;
1132 video_config.rtp_sender = rtp_sender_.get();
1133 video_config.playout_delay_oracle = &playout_delay_oracle;
1134 video_config.field_trials = &field_trials;
1135 RTPSenderVideo rtp_sender_video(video_config);
Mirta Dvornicicfe68daa2019-05-23 13:21:12 +02001136
1137 // Send a frame.
1138 RTPVideoHeader video_header;
Danil Chapovalov51bf2002019-10-11 10:53:27 +02001139 video_header.frame_type = VideoFrameType::kVideoFrameKey;
1140 ASSERT_TRUE(rtp_sender_video.SendVideo(kPayloadType, absl::nullopt, 1234,
1141 4321, payload, nullptr, video_header,
1142 kDefaultExpectedRetransmissionTimeMs));
Mirta Dvornicicfe68daa2019-05-23 13:21:12 +02001143
1144 auto sent_payload = transport_.last_sent_packet().payload();
1145 EXPECT_THAT(sent_payload, ElementsAreArray(payload));
1146}
1147
minyue3a407ee2017-04-03 01:10:33 -07001148TEST_P(RtpSenderTest, SendFlexfecPackets) {
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001149 constexpr uint32_t kTimestamp = 1234;
brandtrdbdb3f12016-11-10 05:04:48 -08001150 constexpr int kMediaPayloadType = 127;
Erik Språng6cf554e2019-10-02 20:55:39 +02001151 constexpr VideoCodecType kCodecType = VideoCodecType::kVideoCodecGeneric;
brandtrdbdb3f12016-11-10 05:04:48 -08001152 constexpr int kFlexfecPayloadType = 118;
brandtrdbdb3f12016-11-10 05:04:48 -08001153 const std::vector<RtpExtension> kNoRtpExtensions;
erikvarga27883732017-05-17 05:08:38 -07001154 const std::vector<RtpExtensionSize> kNoRtpExtensionSizes;
Erik Språng4580ca22019-07-04 10:38:43 +02001155 FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexFecSsrc, kSsrc, kNoMid,
1156 kNoRtpExtensions, kNoRtpExtensionSizes,
brandtr48d21a22017-05-30 02:32:12 -07001157 nullptr /* rtp_state */, &fake_clock_);
brandtrdbdb3f12016-11-10 05:04:48 -08001158
1159 // Reset |rtp_sender_| to use FlexFEC.
Erik Språng4580ca22019-07-04 10:38:43 +02001160 RtpRtcp::Configuration config;
1161 config.clock = &fake_clock_;
1162 config.outgoing_transport = &transport_;
1163 config.paced_sender = &mock_paced_sender_;
Erik Språng54d5d2c2019-08-20 17:22:36 +02001164 config.local_media_ssrc = kSsrc;
Erik Språng4580ca22019-07-04 10:38:43 +02001165 config.flexfec_sender = &flexfec_sender_;
Erik Språng4580ca22019-07-04 10:38:43 +02001166 config.event_log = &mock_rtc_event_log_;
1167 config.send_packet_observer = &send_packet_observer_;
1168 config.retransmission_rate_limiter = &retransmission_rate_limiter_;
Mirko Bonadei317a1f02019-09-17 17:06:18 +02001169 rtp_sender_ = std::make_unique<RTPSender>(config);
Erik Språng4580ca22019-07-04 10:38:43 +02001170
brandtrdbdb3f12016-11-10 05:04:48 -08001171 rtp_sender_->SetSequenceNumber(kSeqNum);
brandtrdbdb3f12016-11-10 05:04:48 -08001172 rtp_sender_->SetStorePacketsStatus(true, 10);
1173
Niels Möller5fe95102019-03-04 16:49:25 +01001174 PlayoutDelayOracle playout_delay_oracle;
Erik Språngdc34a252019-10-04 15:17:29 +02001175 FieldTrialBasedConfig field_trials;
1176 RTPSenderVideo::Config video_config;
1177 video_config.clock = &fake_clock_;
1178 video_config.rtp_sender = rtp_sender_.get();
1179 video_config.flexfec_sender = &flexfec_sender;
1180 video_config.playout_delay_oracle = &playout_delay_oracle;
1181 video_config.field_trials = &field_trials;
1182 RTPSenderVideo rtp_sender_video(video_config);
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001183
brandtrdbdb3f12016-11-10 05:04:48 -08001184 // Parameters selected to generate a single FEC packet per media packet.
1185 FecProtectionParams params;
1186 params.fec_rate = 15;
1187 params.max_fec_frames = 1;
1188 params.fec_mask_type = kFecMaskRandom;
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001189 rtp_sender_video.SetFecParameters(params, params);
brandtrdbdb3f12016-11-10 05:04:48 -08001190
brandtr9dfff292016-11-14 05:14:50 -08001191 uint16_t flexfec_seq_num;
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001192 RTPVideoHeader video_header;
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001193
Erik Språngf6468d22019-07-05 16:53:43 +02001194 std::unique_ptr<RtpPacketToSend> media_packet;
1195 std::unique_ptr<RtpPacketToSend> fec_packet;
1196
Erik Språngea55b082019-10-02 14:57:46 +02001197 EXPECT_CALL(mock_paced_sender_, EnqueuePackets)
Erik Språngf6468d22019-07-05 16:53:43 +02001198 .Times(2)
Erik Språngea55b082019-10-02 14:57:46 +02001199 .WillRepeatedly(
1200 [&](std::vector<std::unique_ptr<RtpPacketToSend>> packets) {
1201 for (auto& packet : packets) {
1202 if (packet->packet_type() == RtpPacketToSend::Type::kVideo) {
1203 EXPECT_EQ(packet->Ssrc(), kSsrc);
1204 EXPECT_EQ(packet->SequenceNumber(), kSeqNum);
1205 media_packet = std::move(packet);
1206 } else {
1207 EXPECT_EQ(packet->packet_type(),
1208 RtpPacketToSend::Type::kForwardErrorCorrection);
1209 EXPECT_EQ(packet->Ssrc(), kFlexFecSsrc);
1210 fec_packet = std::move(packet);
1211 }
1212 }
1213 });
Erik Språngf6468d22019-07-05 16:53:43 +02001214
Danil Chapovalov51bf2002019-10-11 10:53:27 +02001215 video_header.frame_type = VideoFrameType::kVideoFrameKey;
Erik Språngf6468d22019-07-05 16:53:43 +02001216 EXPECT_TRUE(rtp_sender_video.SendVideo(
Danil Chapovalov51bf2002019-10-11 10:53:27 +02001217 kMediaPayloadType, kCodecType, kTimestamp,
1218 fake_clock_.TimeInMilliseconds(), kPayloadData, nullptr, video_header,
Erik Språng6cf554e2019-10-02 20:55:39 +02001219 kDefaultExpectedRetransmissionTimeMs));
Erik Språngf6468d22019-07-05 16:53:43 +02001220 ASSERT_TRUE(media_packet != nullptr);
1221 ASSERT_TRUE(fec_packet != nullptr);
1222
1223 flexfec_seq_num = fec_packet->SequenceNumber();
1224 rtp_sender_->TrySendPacket(media_packet.get(), PacedPacketInfo());
1225 rtp_sender_->TrySendPacket(fec_packet.get(), PacedPacketInfo());
Erik Språngf6468d22019-07-05 16:53:43 +02001226
brandtr9dfff292016-11-14 05:14:50 -08001227 ASSERT_EQ(2, transport_.packets_sent());
Erik Språngf5815fa2019-08-21 14:27:31 +02001228 const RtpPacketReceived& sent_media_packet = transport_.sent_packets_[0];
1229 EXPECT_EQ(kMediaPayloadType, sent_media_packet.PayloadType());
1230 EXPECT_EQ(kSeqNum, sent_media_packet.SequenceNumber());
1231 EXPECT_EQ(kSsrc, sent_media_packet.Ssrc());
1232 const RtpPacketReceived& sent_flexfec_packet = transport_.sent_packets_[1];
1233 EXPECT_EQ(kFlexfecPayloadType, sent_flexfec_packet.PayloadType());
1234 EXPECT_EQ(flexfec_seq_num, sent_flexfec_packet.SequenceNumber());
1235 EXPECT_EQ(kFlexFecSsrc, sent_flexfec_packet.Ssrc());
brandtrdbdb3f12016-11-10 05:04:48 -08001236}
1237
Erik Språngf6468d22019-07-05 16:53:43 +02001238// TODO(ilnik): because of webrtc:7859. Once FEC moved below pacer, this test
1239// should be removed.
1240TEST_P(RtpSenderTest, NoFlexfecForTimingFrames) {
1241 constexpr uint32_t kTimestamp = 1234;
1242 const int64_t kCaptureTimeMs = fake_clock_.TimeInMilliseconds();
1243 constexpr int kMediaPayloadType = 127;
Erik Språng6cf554e2019-10-02 20:55:39 +02001244 constexpr VideoCodecType kCodecType = VideoCodecType::kVideoCodecGeneric;
Erik Språngf6468d22019-07-05 16:53:43 +02001245 constexpr int kFlexfecPayloadType = 118;
1246 const std::vector<RtpExtension> kNoRtpExtensions;
1247 const std::vector<RtpExtensionSize> kNoRtpExtensionSizes;
1248
1249 FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexFecSsrc, kSsrc, kNoMid,
1250 kNoRtpExtensions, kNoRtpExtensionSizes,
1251 nullptr /* rtp_state */, &fake_clock_);
1252
1253 // Reset |rtp_sender_| to use FlexFEC.
Erik Språng630443a2019-07-26 16:44:55 +02001254 RtpRtcp::Configuration config;
1255 config.clock = &fake_clock_;
1256 config.outgoing_transport = &transport_;
1257 config.paced_sender = &mock_paced_sender_;
1258 config.flexfec_sender = &flexfec_sender;
Erik Språng630443a2019-07-26 16:44:55 +02001259 config.event_log = &mock_rtc_event_log_;
1260 config.send_packet_observer = &send_packet_observer_;
1261 config.retransmission_rate_limiter = &retransmission_rate_limiter_;
Erik Språng54d5d2c2019-08-20 17:22:36 +02001262 config.local_media_ssrc = kSsrc;
Mirko Bonadei317a1f02019-09-17 17:06:18 +02001263 rtp_sender_ = std::make_unique<RTPSender>(config);
Erik Språngf6468d22019-07-05 16:53:43 +02001264 rtp_sender_->SetSequenceNumber(kSeqNum);
1265 rtp_sender_->SetStorePacketsStatus(true, 10);
1266
1267 PlayoutDelayOracle playout_delay_oracle;
Erik Språngdc34a252019-10-04 15:17:29 +02001268 FieldTrialBasedConfig field_trials;
1269 RTPSenderVideo::Config video_config;
1270 video_config.clock = &fake_clock_;
1271 video_config.rtp_sender = rtp_sender_.get();
1272 video_config.flexfec_sender = &flexfec_sender;
1273 video_config.playout_delay_oracle = &playout_delay_oracle;
1274 video_config.field_trials = &field_trials;
1275 RTPSenderVideo rtp_sender_video(video_config);
Erik Språngf6468d22019-07-05 16:53:43 +02001276
1277 // Need extension to be registered for timing frames to be sent.
1278 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
1279 kRtpExtensionVideoTiming, kVideoTimingExtensionId));
1280
1281 // Parameters selected to generate a single FEC packet per media packet.
1282 FecProtectionParams params;
1283 params.fec_rate = 15;
1284 params.max_fec_frames = 1;
1285 params.fec_mask_type = kFecMaskRandom;
1286 rtp_sender_video.SetFecParameters(params, params);
1287
1288 RTPVideoHeader video_header;
1289 video_header.video_timing.flags = VideoSendTiming::kTriggeredByTimer;
1290
1291 EXPECT_CALL(mock_rtc_event_log_,
1292 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
1293 .Times(1);
Erik Språngf6468d22019-07-05 16:53:43 +02001294 std::unique_ptr<RtpPacketToSend> rtp_packet;
1295 EXPECT_CALL(
1296 mock_paced_sender_,
Erik Språngea55b082019-10-02 14:57:46 +02001297 EnqueuePackets(Contains(AllOf(
Erik Språngf6468d22019-07-05 16:53:43 +02001298 Pointee(Property(&RtpPacketToSend::Ssrc, kSsrc)),
Erik Språngea55b082019-10-02 14:57:46 +02001299 Pointee(Property(&RtpPacketToSend::SequenceNumber, kSeqNum))))))
1300 .WillOnce([&rtp_packet](
1301 std::vector<std::unique_ptr<RtpPacketToSend>> packets) {
1302 EXPECT_EQ(packets.size(), 1u);
1303 rtp_packet = std::move(packets[0]);
Erik Språngf6468d22019-07-05 16:53:43 +02001304 });
1305
Erik Språngea55b082019-10-02 14:57:46 +02001306 EXPECT_CALL(mock_paced_sender_,
1307 EnqueuePackets(Contains(
1308 Pointee(Property(&RtpPacketToSend::Ssrc, kFlexFecSsrc)))))
Erik Språngf6468d22019-07-05 16:53:43 +02001309 .Times(0); // Not called because packet should not be protected.
1310
Danil Chapovalov51bf2002019-10-11 10:53:27 +02001311 video_header.frame_type = VideoFrameType::kVideoFrameKey;
Erik Språngf6468d22019-07-05 16:53:43 +02001312 EXPECT_TRUE(rtp_sender_video.SendVideo(
Danil Chapovalov51bf2002019-10-11 10:53:27 +02001313 kMediaPayloadType, kCodecType, kTimestamp, kCaptureTimeMs, kPayloadData,
1314 nullptr, video_header, kDefaultExpectedRetransmissionTimeMs));
Erik Språngf6468d22019-07-05 16:53:43 +02001315
1316 EXPECT_TRUE(
1317 rtp_sender_->TrySendPacket(rtp_packet.get(), PacedPacketInfo()));
Erik Språngf6468d22019-07-05 16:53:43 +02001318
1319 ASSERT_EQ(1, transport_.packets_sent());
Erik Språngf5815fa2019-08-21 14:27:31 +02001320 const RtpPacketReceived& sent_media_packet1 = transport_.sent_packets_[0];
1321 EXPECT_EQ(kMediaPayloadType, sent_media_packet1.PayloadType());
1322 EXPECT_EQ(kSeqNum, sent_media_packet1.SequenceNumber());
1323 EXPECT_EQ(kSsrc, sent_media_packet1.Ssrc());
Erik Språngf6468d22019-07-05 16:53:43 +02001324
1325 // Now try to send not a timing frame.
1326 uint16_t flexfec_seq_num;
1327
1328 EXPECT_CALL(mock_rtc_event_log_,
1329 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
1330 .Times(2);
Erik Språngf5815fa2019-08-21 14:27:31 +02001331 std::unique_ptr<RtpPacketToSend> media_packet2;
1332 std::unique_ptr<RtpPacketToSend> fec_packet;
Erik Språngf6468d22019-07-05 16:53:43 +02001333
Erik Språngea55b082019-10-02 14:57:46 +02001334 EXPECT_CALL(mock_paced_sender_, EnqueuePackets)
Erik Språngf5815fa2019-08-21 14:27:31 +02001335 .Times(2)
Erik Språngea55b082019-10-02 14:57:46 +02001336 .WillRepeatedly(
1337 [&](std::vector<std::unique_ptr<RtpPacketToSend>> packets) {
1338 for (auto& packet : packets) {
1339 if (packet->packet_type() == RtpPacketToSend::Type::kVideo) {
1340 EXPECT_EQ(packet->Ssrc(), kSsrc);
1341 EXPECT_EQ(packet->SequenceNumber(), kSeqNum + 1);
1342 media_packet2 = std::move(packet);
1343 } else {
1344 EXPECT_EQ(packet->packet_type(),
1345 RtpPacketToSend::Type::kForwardErrorCorrection);
1346 EXPECT_EQ(packet->Ssrc(), kFlexFecSsrc);
1347 fec_packet = std::move(packet);
1348 }
1349 }
1350 });
Erik Språngf6468d22019-07-05 16:53:43 +02001351
Erik Språngf5815fa2019-08-21 14:27:31 +02001352 video_header.video_timing.flags = VideoSendTiming::kInvalid;
Danil Chapovalov51bf2002019-10-11 10:53:27 +02001353 video_header.frame_type = VideoFrameType::kVideoFrameKey;
1354 EXPECT_TRUE(rtp_sender_video.SendVideo(kMediaPayloadType, kCodecType,
1355 kTimestamp + 1, kCaptureTimeMs + 1,
1356 kPayloadData, nullptr, video_header,
1357 kDefaultExpectedRetransmissionTimeMs));
Erik Språngf6468d22019-07-05 16:53:43 +02001358
Erik Språngf5815fa2019-08-21 14:27:31 +02001359 ASSERT_TRUE(media_packet2 != nullptr);
1360 ASSERT_TRUE(fec_packet != nullptr);
Erik Språngf6468d22019-07-05 16:53:43 +02001361
Erik Språngf5815fa2019-08-21 14:27:31 +02001362 flexfec_seq_num = fec_packet->SequenceNumber();
1363 rtp_sender_->TrySendPacket(media_packet2.get(), PacedPacketInfo());
1364 rtp_sender_->TrySendPacket(fec_packet.get(), PacedPacketInfo());
Erik Språngf6468d22019-07-05 16:53:43 +02001365
1366 ASSERT_EQ(3, transport_.packets_sent());
Erik Språngf5815fa2019-08-21 14:27:31 +02001367 const RtpPacketReceived& sent_media_packet2 = transport_.sent_packets_[1];
1368 EXPECT_EQ(kMediaPayloadType, sent_media_packet2.PayloadType());
1369 EXPECT_EQ(kSeqNum + 1, sent_media_packet2.SequenceNumber());
1370 EXPECT_EQ(kSsrc, sent_media_packet2.Ssrc());
Erik Språngf6468d22019-07-05 16:53:43 +02001371 const RtpPacketReceived& flexfec_packet = transport_.sent_packets_[2];
1372 EXPECT_EQ(kFlexfecPayloadType, flexfec_packet.PayloadType());
1373 EXPECT_EQ(flexfec_seq_num, flexfec_packet.SequenceNumber());
1374 EXPECT_EQ(kFlexFecSsrc, flexfec_packet.Ssrc());
1375}
1376
minyue3a407ee2017-04-03 01:10:33 -07001377TEST_P(RtpSenderTestWithoutPacer, SendFlexfecPackets) {
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001378 constexpr uint32_t kTimestamp = 1234;
brandtrdbdb3f12016-11-10 05:04:48 -08001379 constexpr int kMediaPayloadType = 127;
Erik Språng6cf554e2019-10-02 20:55:39 +02001380 constexpr VideoCodecType kCodecType = VideoCodecType::kVideoCodecGeneric;
brandtrdbdb3f12016-11-10 05:04:48 -08001381 constexpr int kFlexfecPayloadType = 118;
brandtrdbdb3f12016-11-10 05:04:48 -08001382 const std::vector<RtpExtension> kNoRtpExtensions;
erikvarga27883732017-05-17 05:08:38 -07001383 const std::vector<RtpExtensionSize> kNoRtpExtensionSizes;
Erik Språngf6468d22019-07-05 16:53:43 +02001384 FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexFecSsrc, kSsrc, kNoMid,
Erik Språng4580ca22019-07-04 10:38:43 +02001385 kNoRtpExtensions, kNoRtpExtensionSizes,
brandtr48d21a22017-05-30 02:32:12 -07001386 nullptr /* rtp_state */, &fake_clock_);
brandtrdbdb3f12016-11-10 05:04:48 -08001387
1388 // Reset |rtp_sender_| to use FlexFEC.
Erik Språng4580ca22019-07-04 10:38:43 +02001389 RtpRtcp::Configuration config;
1390 config.clock = &fake_clock_;
1391 config.outgoing_transport = &transport_;
Erik Språng54d5d2c2019-08-20 17:22:36 +02001392 config.local_media_ssrc = kSsrc;
Erik Språng4580ca22019-07-04 10:38:43 +02001393 config.flexfec_sender = &flexfec_sender;
Erik Språng4580ca22019-07-04 10:38:43 +02001394 config.event_log = &mock_rtc_event_log_;
1395 config.send_packet_observer = &send_packet_observer_;
1396 config.retransmission_rate_limiter = &retransmission_rate_limiter_;
Mirko Bonadei317a1f02019-09-17 17:06:18 +02001397 rtp_sender_ = std::make_unique<RTPSender>(config);
Erik Språng4580ca22019-07-04 10:38:43 +02001398
brandtrdbdb3f12016-11-10 05:04:48 -08001399 rtp_sender_->SetSequenceNumber(kSeqNum);
brandtrdbdb3f12016-11-10 05:04:48 -08001400
Niels Möller5fe95102019-03-04 16:49:25 +01001401 PlayoutDelayOracle playout_delay_oracle;
Erik Språngdc34a252019-10-04 15:17:29 +02001402 FieldTrialBasedConfig field_trials;
1403 RTPSenderVideo::Config video_config;
1404 video_config.clock = &fake_clock_;
1405 video_config.rtp_sender = rtp_sender_.get();
1406 video_config.flexfec_sender = &flexfec_sender;
1407 video_config.playout_delay_oracle = &playout_delay_oracle;
1408 video_config.field_trials = &field_trials;
1409 RTPSenderVideo rtp_sender_video(video_config);
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001410
brandtrdbdb3f12016-11-10 05:04:48 -08001411 // Parameters selected to generate a single FEC packet per media packet.
1412 FecProtectionParams params;
1413 params.fec_rate = 15;
1414 params.max_fec_frames = 1;
1415 params.fec_mask_type = kFecMaskRandom;
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001416 rtp_sender_video.SetFecParameters(params, params);
brandtrdbdb3f12016-11-10 05:04:48 -08001417
Elad Alon4a87e1c2017-10-03 16:11:34 +02001418 EXPECT_CALL(mock_rtc_event_log_,
1419 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
1420 .Times(2);
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001421 RTPVideoHeader video_header;
Danil Chapovalov51bf2002019-10-11 10:53:27 +02001422 video_header.frame_type = VideoFrameType::kVideoFrameKey;
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001423 EXPECT_TRUE(rtp_sender_video.SendVideo(
Danil Chapovalov51bf2002019-10-11 10:53:27 +02001424 kMediaPayloadType, kCodecType, kTimestamp,
1425 fake_clock_.TimeInMilliseconds(), kPayloadData, nullptr, video_header,
1426 kDefaultExpectedRetransmissionTimeMs));
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001427
brandtrdbdb3f12016-11-10 05:04:48 -08001428 ASSERT_EQ(2, transport_.packets_sent());
1429 const RtpPacketReceived& media_packet = transport_.sent_packets_[0];
1430 EXPECT_EQ(kMediaPayloadType, media_packet.PayloadType());
Erik Språng4580ca22019-07-04 10:38:43 +02001431 EXPECT_EQ(kSsrc, media_packet.Ssrc());
brandtrdbdb3f12016-11-10 05:04:48 -08001432 const RtpPacketReceived& flexfec_packet = transport_.sent_packets_[1];
1433 EXPECT_EQ(kFlexfecPayloadType, flexfec_packet.PayloadType());
Erik Språngf6468d22019-07-05 16:53:43 +02001434 EXPECT_EQ(kFlexFecSsrc, flexfec_packet.Ssrc());
brandtrdbdb3f12016-11-10 05:04:48 -08001435}
1436
Steve Anton296a0ce2018-03-22 15:17:27 -07001437// Test that the MID header extension is included on sent packets when
1438// configured.
1439TEST_P(RtpSenderTestWithoutPacer, MidIncludedOnSentPackets) {
1440 const char kMid[] = "mid";
1441
Steve Anton2bac7da2019-07-21 15:04:21 -04001442 EnableMidSending(kMid);
Steve Anton296a0ce2018-03-22 15:17:27 -07001443
1444 // Send a couple packets.
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001445 SendGenericPacket();
1446 SendGenericPacket();
Steve Anton296a0ce2018-03-22 15:17:27 -07001447
1448 // Expect both packets to have the MID set.
1449 ASSERT_EQ(2u, transport_.sent_packets_.size());
1450 for (const RtpPacketReceived& packet : transport_.sent_packets_) {
1451 std::string mid;
1452 ASSERT_TRUE(packet.GetExtension<RtpMid>(&mid));
1453 EXPECT_EQ(kMid, mid);
1454 }
1455}
1456
Amit Hilbuch77938e62018-12-21 09:23:38 -08001457TEST_P(RtpSenderTestWithoutPacer, RidIncludedOnSentPackets) {
1458 const char kRid[] = "f";
1459
Steve Anton2bac7da2019-07-21 15:04:21 -04001460 EnableRidSending(kRid);
Amit Hilbuch77938e62018-12-21 09:23:38 -08001461
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001462 SendGenericPacket();
Amit Hilbuch77938e62018-12-21 09:23:38 -08001463
1464 ASSERT_EQ(1u, transport_.sent_packets_.size());
1465 const RtpPacketReceived& packet = transport_.sent_packets_[0];
1466 std::string rid;
1467 ASSERT_TRUE(packet.GetExtension<RtpStreamId>(&rid));
1468 EXPECT_EQ(kRid, rid);
1469}
1470
1471TEST_P(RtpSenderTestWithoutPacer, RidIncludedOnRtxSentPackets) {
1472 const char kRid[] = "f";
Amit Hilbuch77938e62018-12-21 09:23:38 -08001473
Steve Anton2bac7da2019-07-21 15:04:21 -04001474 EnableRtx();
1475 EnableRidSending(kRid);
Amit Hilbuch77938e62018-12-21 09:23:38 -08001476
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001477 SendGenericPacket();
Amit Hilbuch77938e62018-12-21 09:23:38 -08001478 ASSERT_EQ(1u, transport_.sent_packets_.size());
1479 const RtpPacketReceived& packet = transport_.sent_packets_[0];
1480 std::string rid;
1481 ASSERT_TRUE(packet.GetExtension<RtpStreamId>(&rid));
1482 EXPECT_EQ(kRid, rid);
1483 rid = kNoRid;
Steve Anton2bac7da2019-07-21 15:04:21 -04001484 EXPECT_FALSE(packet.HasExtension<RepairedRtpStreamId>());
Amit Hilbuch77938e62018-12-21 09:23:38 -08001485
1486 uint16_t packet_id = packet.SequenceNumber();
1487 rtp_sender_->ReSendPacket(packet_id);
1488 ASSERT_EQ(2u, transport_.sent_packets_.size());
1489 const RtpPacketReceived& rtx_packet = transport_.sent_packets_[1];
1490 ASSERT_TRUE(rtx_packet.GetExtension<RepairedRtpStreamId>(&rid));
1491 EXPECT_EQ(kRid, rid);
1492 EXPECT_FALSE(rtx_packet.HasExtension<RtpStreamId>());
1493}
1494
Steve Anton2bac7da2019-07-21 15:04:21 -04001495TEST_P(RtpSenderTestWithoutPacer, MidAndRidNotIncludedOnSentPacketsAfterAck) {
1496 const char kMid[] = "mid";
1497 const char kRid[] = "f";
1498
1499 EnableMidSending(kMid);
1500 EnableRidSending(kRid);
1501
1502 // This first packet should include both MID and RID.
1503 auto first_built_packet = SendGenericPacket();
1504
1505 rtp_sender_->OnReceivedAckOnSsrc(first_built_packet->SequenceNumber());
1506
1507 // The second packet should include neither since an ack was received.
1508 SendGenericPacket();
1509
1510 ASSERT_EQ(2u, transport_.sent_packets_.size());
1511
1512 const RtpPacketReceived& first_packet = transport_.sent_packets_[0];
1513 std::string mid, rid;
1514 ASSERT_TRUE(first_packet.GetExtension<RtpMid>(&mid));
1515 EXPECT_EQ(kMid, mid);
1516 ASSERT_TRUE(first_packet.GetExtension<RtpStreamId>(&rid));
1517 EXPECT_EQ(kRid, rid);
1518
1519 const RtpPacketReceived& second_packet = transport_.sent_packets_[1];
1520 EXPECT_FALSE(second_packet.HasExtension<RtpMid>());
1521 EXPECT_FALSE(second_packet.HasExtension<RtpStreamId>());
1522}
1523
1524// Test that the first RTX packet includes both MID and RRID even if the packet
1525// being retransmitted did not have MID or RID. The MID and RID are needed on
1526// the first packets for a given SSRC, and RTX packets are sent on a separate
1527// SSRC.
1528TEST_P(RtpSenderTestWithoutPacer, MidAndRidIncludedOnFirstRtxPacket) {
1529 const char kMid[] = "mid";
1530 const char kRid[] = "f";
1531
1532 EnableRtx();
1533 EnableMidSending(kMid);
1534 EnableRidSending(kRid);
1535
1536 // This first packet will include both MID and RID.
1537 auto first_built_packet = SendGenericPacket();
1538 rtp_sender_->OnReceivedAckOnSsrc(first_built_packet->SequenceNumber());
1539
1540 // The second packet will include neither since an ack was received.
1541 auto second_built_packet = SendGenericPacket();
1542
1543 // The first RTX packet should include MID and RRID.
1544 ASSERT_LT(0,
1545 rtp_sender_->ReSendPacket(second_built_packet->SequenceNumber()));
1546
1547 ASSERT_EQ(3u, transport_.sent_packets_.size());
1548
1549 const RtpPacketReceived& rtx_packet = transport_.sent_packets_[2];
1550 std::string mid, rrid;
1551 ASSERT_TRUE(rtx_packet.GetExtension<RtpMid>(&mid));
1552 EXPECT_EQ(kMid, mid);
1553 ASSERT_TRUE(rtx_packet.GetExtension<RepairedRtpStreamId>(&rrid));
1554 EXPECT_EQ(kRid, rrid);
1555}
1556
1557// Test that the RTX packets sent after receving an ACK on the RTX SSRC does
1558// not include either MID or RRID even if the packet being retransmitted did
1559// had a MID or RID.
1560TEST_P(RtpSenderTestWithoutPacer, MidAndRidNotIncludedOnRtxPacketsAfterAck) {
1561 const char kMid[] = "mid";
1562 const char kRid[] = "f";
1563
1564 EnableRtx();
1565 EnableMidSending(kMid);
1566 EnableRidSending(kRid);
1567
1568 // This first packet will include both MID and RID.
1569 auto first_built_packet = SendGenericPacket();
1570 rtp_sender_->OnReceivedAckOnSsrc(first_built_packet->SequenceNumber());
1571
1572 // The second packet will include neither since an ack was received.
1573 auto second_built_packet = SendGenericPacket();
1574
1575 // The first RTX packet will include MID and RRID.
1576 ASSERT_LT(0,
1577 rtp_sender_->ReSendPacket(second_built_packet->SequenceNumber()));
1578
1579 ASSERT_EQ(3u, transport_.sent_packets_.size());
1580 const RtpPacketReceived& first_rtx_packet = transport_.sent_packets_[2];
1581
1582 rtp_sender_->OnReceivedAckOnRtxSsrc(first_rtx_packet.SequenceNumber());
1583
1584 // The second and third RTX packets should not include MID nor RRID.
1585 ASSERT_LT(0, rtp_sender_->ReSendPacket(first_built_packet->SequenceNumber()));
1586 ASSERT_LT(0,
1587 rtp_sender_->ReSendPacket(second_built_packet->SequenceNumber()));
1588
1589 ASSERT_EQ(5u, transport_.sent_packets_.size());
1590
1591 const RtpPacketReceived& second_rtx_packet = transport_.sent_packets_[3];
1592 EXPECT_FALSE(second_rtx_packet.HasExtension<RtpMid>());
1593 EXPECT_FALSE(second_rtx_packet.HasExtension<RepairedRtpStreamId>());
1594
1595 const RtpPacketReceived& third_rtx_packet = transport_.sent_packets_[4];
1596 EXPECT_FALSE(third_rtx_packet.HasExtension<RtpMid>());
1597 EXPECT_FALSE(third_rtx_packet.HasExtension<RepairedRtpStreamId>());
1598}
1599
1600// Test that if the RtpState indicates an ACK has been received on that SSRC
1601// then neither the MID nor RID header extensions will be sent.
1602TEST_P(RtpSenderTestWithoutPacer,
1603 MidAndRidNotIncludedOnSentPacketsAfterRtpStateRestored) {
1604 const char kMid[] = "mid";
1605 const char kRid[] = "f";
1606
1607 EnableMidSending(kMid);
1608 EnableRidSending(kRid);
1609
1610 RtpState state = rtp_sender_->GetRtpState();
1611 EXPECT_FALSE(state.ssrc_has_acked);
1612 state.ssrc_has_acked = true;
1613 rtp_sender_->SetRtpState(state);
1614
1615 SendGenericPacket();
1616
1617 ASSERT_EQ(1u, transport_.sent_packets_.size());
1618 const RtpPacketReceived& packet = transport_.sent_packets_[0];
1619 EXPECT_FALSE(packet.HasExtension<RtpMid>());
1620 EXPECT_FALSE(packet.HasExtension<RtpStreamId>());
1621}
1622
1623// Test that if the RTX RtpState indicates an ACK has been received on that
1624// RTX SSRC then neither the MID nor RRID header extensions will be sent on
1625// RTX packets.
1626TEST_P(RtpSenderTestWithoutPacer,
1627 MidAndRridNotIncludedOnRtxPacketsAfterRtpStateRestored) {
1628 const char kMid[] = "mid";
1629 const char kRid[] = "f";
1630
1631 EnableRtx();
1632 EnableMidSending(kMid);
1633 EnableRidSending(kRid);
1634
1635 RtpState rtx_state = rtp_sender_->GetRtxRtpState();
1636 EXPECT_FALSE(rtx_state.ssrc_has_acked);
1637 rtx_state.ssrc_has_acked = true;
1638 rtp_sender_->SetRtxRtpState(rtx_state);
1639
1640 auto built_packet = SendGenericPacket();
1641 ASSERT_LT(0, rtp_sender_->ReSendPacket(built_packet->SequenceNumber()));
1642
1643 ASSERT_EQ(2u, transport_.sent_packets_.size());
1644 const RtpPacketReceived& rtx_packet = transport_.sent_packets_[1];
1645 EXPECT_FALSE(rtx_packet.HasExtension<RtpMid>());
1646 EXPECT_FALSE(rtx_packet.HasExtension<RepairedRtpStreamId>());
1647}
1648
minyue3a407ee2017-04-03 01:10:33 -07001649TEST_P(RtpSenderTest, FecOverheadRate) {
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001650 constexpr uint32_t kTimestamp = 1234;
1651 constexpr int kMediaPayloadType = 127;
Erik Språng6cf554e2019-10-02 20:55:39 +02001652 constexpr VideoCodecType kCodecType = VideoCodecType::kVideoCodecGeneric;
brandtr81eab612017-01-24 04:06:09 -08001653 constexpr int kFlexfecPayloadType = 118;
brandtr81eab612017-01-24 04:06:09 -08001654 const std::vector<RtpExtension> kNoRtpExtensions;
erikvarga27883732017-05-17 05:08:38 -07001655 const std::vector<RtpExtensionSize> kNoRtpExtensionSizes;
Erik Språng4580ca22019-07-04 10:38:43 +02001656 FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexFecSsrc, kSsrc, kNoMid,
1657 kNoRtpExtensions, kNoRtpExtensionSizes,
brandtr48d21a22017-05-30 02:32:12 -07001658 nullptr /* rtp_state */, &fake_clock_);
brandtr81eab612017-01-24 04:06:09 -08001659
1660 // Reset |rtp_sender_| to use FlexFEC.
Erik Språng4580ca22019-07-04 10:38:43 +02001661 RtpRtcp::Configuration config;
1662 config.clock = &fake_clock_;
1663 config.outgoing_transport = &transport_;
1664 config.paced_sender = &mock_paced_sender_;
Erik Språng54d5d2c2019-08-20 17:22:36 +02001665 config.local_media_ssrc = kSsrc;
Erik Språng4580ca22019-07-04 10:38:43 +02001666 config.flexfec_sender = &flexfec_sender;
Erik Språng4580ca22019-07-04 10:38:43 +02001667 config.event_log = &mock_rtc_event_log_;
1668 config.send_packet_observer = &send_packet_observer_;
1669 config.retransmission_rate_limiter = &retransmission_rate_limiter_;
Mirko Bonadei317a1f02019-09-17 17:06:18 +02001670 rtp_sender_ = std::make_unique<RTPSender>(config);
Erik Språng4580ca22019-07-04 10:38:43 +02001671
brandtr81eab612017-01-24 04:06:09 -08001672 rtp_sender_->SetSequenceNumber(kSeqNum);
brandtr81eab612017-01-24 04:06:09 -08001673
Niels Möller5fe95102019-03-04 16:49:25 +01001674 PlayoutDelayOracle playout_delay_oracle;
Erik Språngdc34a252019-10-04 15:17:29 +02001675 FieldTrialBasedConfig field_trials;
1676 RTPSenderVideo::Config video_config;
1677 video_config.clock = &fake_clock_;
1678 video_config.rtp_sender = rtp_sender_.get();
1679 video_config.flexfec_sender = &flexfec_sender;
1680 video_config.playout_delay_oracle = &playout_delay_oracle;
1681 video_config.field_trials = &field_trials;
1682 RTPSenderVideo rtp_sender_video(video_config);
brandtr81eab612017-01-24 04:06:09 -08001683 // Parameters selected to generate a single FEC packet per media packet.
1684 FecProtectionParams params;
1685 params.fec_rate = 15;
1686 params.max_fec_frames = 1;
1687 params.fec_mask_type = kFecMaskRandom;
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001688 rtp_sender_video.SetFecParameters(params, params);
brandtr81eab612017-01-24 04:06:09 -08001689
1690 constexpr size_t kNumMediaPackets = 10;
1691 constexpr size_t kNumFecPackets = kNumMediaPackets;
1692 constexpr int64_t kTimeBetweenPacketsMs = 10;
Erik Språngea55b082019-10-02 14:57:46 +02001693 EXPECT_CALL(mock_paced_sender_, EnqueuePackets)
1694 .Times(kNumMediaPackets + kNumFecPackets);
brandtr81eab612017-01-24 04:06:09 -08001695 for (size_t i = 0; i < kNumMediaPackets; ++i) {
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001696 RTPVideoHeader video_header;
1697
Danil Chapovalov51bf2002019-10-11 10:53:27 +02001698 video_header.frame_type = VideoFrameType::kVideoFrameKey;
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001699 EXPECT_TRUE(rtp_sender_video.SendVideo(
Danil Chapovalov51bf2002019-10-11 10:53:27 +02001700 kMediaPayloadType, kCodecType, kTimestamp,
1701 fake_clock_.TimeInMilliseconds(), kPayloadData, nullptr, video_header,
Erik Språng6cf554e2019-10-02 20:55:39 +02001702 kDefaultExpectedRetransmissionTimeMs));
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001703
brandtr81eab612017-01-24 04:06:09 -08001704 fake_clock_.AdvanceTimeMilliseconds(kTimeBetweenPacketsMs);
1705 }
1706 constexpr size_t kRtpHeaderLength = 12;
1707 constexpr size_t kFlexfecHeaderLength = 20;
1708 constexpr size_t kGenericCodecHeaderLength = 1;
1709 constexpr size_t kPayloadLength = sizeof(kPayloadData);
1710 constexpr size_t kPacketLength = kRtpHeaderLength + kFlexfecHeaderLength +
1711 kGenericCodecHeaderLength + kPayloadLength;
1712 EXPECT_NEAR(kNumFecPackets * kPacketLength * 8 /
1713 (kNumFecPackets * kTimeBetweenPacketsMs / 1000.0f),
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001714 rtp_sender_video.FecOverheadRate(), 500);
brandtr81eab612017-01-24 04:06:09 -08001715}
1716
minyue3a407ee2017-04-03 01:10:33 -07001717TEST_P(RtpSenderTest, BitrateCallbacks) {
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001718 class TestCallback : public BitrateStatisticsObserver {
1719 public:
sprangcd349d92016-07-13 09:11:28 -07001720 TestCallback()
1721 : BitrateStatisticsObserver(),
1722 num_calls_(0),
1723 ssrc_(0),
1724 total_bitrate_(0),
1725 retransmit_bitrate_(0) {}
Danil Chapovalovdd7e2842018-03-09 15:37:03 +00001726 ~TestCallback() override = default;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001727
sprangcd349d92016-07-13 09:11:28 -07001728 void Notify(uint32_t total_bitrate,
1729 uint32_t retransmit_bitrate,
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00001730 uint32_t ssrc) override {
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001731 ++num_calls_;
1732 ssrc_ = ssrc;
sprangcd349d92016-07-13 09:11:28 -07001733 total_bitrate_ = total_bitrate;
1734 retransmit_bitrate_ = retransmit_bitrate;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001735 }
1736
1737 uint32_t num_calls_;
1738 uint32_t ssrc_;
sprangcd349d92016-07-13 09:11:28 -07001739 uint32_t total_bitrate_;
1740 uint32_t retransmit_bitrate_;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001741 } callback;
Erik Språng4580ca22019-07-04 10:38:43 +02001742
1743 RtpRtcp::Configuration config;
1744 config.clock = &fake_clock_;
1745 config.outgoing_transport = &transport_;
Erik Språng54d5d2c2019-08-20 17:22:36 +02001746 config.local_media_ssrc = kSsrc;
Erik Språng4580ca22019-07-04 10:38:43 +02001747 config.send_bitrate_observer = &callback;
1748 config.retransmission_rate_limiter = &retransmission_rate_limiter_;
Mirko Bonadei317a1f02019-09-17 17:06:18 +02001749 rtp_sender_ = std::make_unique<RTPSender>(config);
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001750
Niels Möller5fe95102019-03-04 16:49:25 +01001751 PlayoutDelayOracle playout_delay_oracle;
Erik Språngdc34a252019-10-04 15:17:29 +02001752 FieldTrialBasedConfig field_trials;
1753 RTPSenderVideo::Config video_config;
1754 video_config.clock = &fake_clock_;
1755 video_config.rtp_sender = rtp_sender_.get();
1756 video_config.playout_delay_oracle = &playout_delay_oracle;
1757 video_config.field_trials = &field_trials;
1758 RTPSenderVideo rtp_sender_video(video_config);
Erik Språng6cf554e2019-10-02 20:55:39 +02001759 const VideoCodecType kCodecType = VideoCodecType::kVideoCodecGeneric;
1760 const uint8_t kPayloadType = 127;
Niels Möller59ab1cf2019-02-06 22:48:11 +01001761
sprangcd349d92016-07-13 09:11:28 -07001762 // Simulate kNumPackets sent with kPacketInterval ms intervals, with the
1763 // number of packets selected so that we fill (but don't overflow) the one
1764 // second averaging window.
1765 const uint32_t kWindowSizeMs = 1000;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001766 const uint32_t kPacketInterval = 20;
sprangcd349d92016-07-13 09:11:28 -07001767 const uint32_t kNumPackets =
1768 (kWindowSizeMs - kPacketInterval) / kPacketInterval;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001769 // Overhead = 12 bytes RTP header + 1 byte generic header.
1770 const uint32_t kPacketOverhead = 13;
1771
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001772 uint8_t payload[] = {47, 11, 32, 93, 89};
1773 rtp_sender_->SetStorePacketsStatus(true, 1);
1774 uint32_t ssrc = rtp_sender_->SSRC();
1775
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001776 // Initial process call so we get a new time window.
1777 rtp_sender_->ProcessBitrate();
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001778
1779 // Send a few frames.
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001780 RTPVideoHeader video_header;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001781 for (uint32_t i = 0; i < kNumPackets; ++i) {
Danil Chapovalov51bf2002019-10-11 10:53:27 +02001782 video_header.frame_type = VideoFrameType::kVideoFrameKey;
Niels Möller59ab1cf2019-02-06 22:48:11 +01001783 ASSERT_TRUE(rtp_sender_video.SendVideo(
Danil Chapovalov51bf2002019-10-11 10:53:27 +02001784 kPayloadType, kCodecType, 1234, 4321, payload, nullptr, video_header,
Niels Möller8f7ce222019-03-21 15:43:58 +01001785 kDefaultExpectedRetransmissionTimeMs));
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001786 fake_clock_.AdvanceTimeMilliseconds(kPacketInterval);
1787 }
1788
1789 rtp_sender_->ProcessBitrate();
1790
stefan@webrtc.org0bae1fa2014-11-05 14:05:29 +00001791 // We get one call for every stats updated, thus two calls since both the
1792 // stream stats and the retransmit stats are updated once.
1793 EXPECT_EQ(2u, callback.num_calls_);
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001794 EXPECT_EQ(ssrc, callback.ssrc_);
sprangcd349d92016-07-13 09:11:28 -07001795 const uint32_t kTotalPacketSize = kPacketOverhead + sizeof(payload);
1796 // Bitrate measured over delta between last and first timestamp, plus one.
1797 const uint32_t kExpectedWindowMs = kNumPackets * kPacketInterval + 1;
1798 const uint32_t kExpectedBitsAccumulated = kTotalPacketSize * kNumPackets * 8;
1799 const uint32_t kExpectedRateBps =
1800 (kExpectedBitsAccumulated * 1000 + (kExpectedWindowMs / 2)) /
1801 kExpectedWindowMs;
1802 EXPECT_EQ(kExpectedRateBps, callback.total_bitrate_);
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001803
andresp@webrtc.orgd11bec42014-07-08 14:32:58 +00001804 rtp_sender_.reset();
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001805}
1806
Erik Språngdc34a252019-10-04 15:17:29 +02001807class StreamDataTestCallback : public StreamDataCountersCallback {
1808 public:
1809 StreamDataTestCallback()
1810 : StreamDataCountersCallback(), ssrc_(0), counters_() {}
1811 ~StreamDataTestCallback() override = default;
1812
1813 void DataCountersUpdated(const StreamDataCounters& counters,
1814 uint32_t ssrc) override {
1815 ssrc_ = ssrc;
1816 counters_ = counters;
1817 }
1818
1819 uint32_t ssrc_;
1820 StreamDataCounters counters_;
1821
1822 void MatchPacketCounter(const RtpPacketCounter& expected,
1823 const RtpPacketCounter& actual) {
1824 EXPECT_EQ(expected.payload_bytes, actual.payload_bytes);
1825 EXPECT_EQ(expected.header_bytes, actual.header_bytes);
1826 EXPECT_EQ(expected.padding_bytes, actual.padding_bytes);
1827 EXPECT_EQ(expected.packets, actual.packets);
1828 }
1829
1830 void Matches(uint32_t ssrc, const StreamDataCounters& counters) {
1831 EXPECT_EQ(ssrc, ssrc_);
1832 MatchPacketCounter(counters.transmitted, counters_.transmitted);
1833 MatchPacketCounter(counters.retransmitted, counters_.retransmitted);
1834 EXPECT_EQ(counters.fec.packets, counters_.fec.packets);
1835 }
1836};
1837
minyue3a407ee2017-04-03 01:10:33 -07001838TEST_P(RtpSenderTestWithoutPacer, StreamDataCountersCallbacks) {
Erik Språngdc34a252019-10-04 15:17:29 +02001839 StreamDataTestCallback callback;
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001840
Erik Språng6cf554e2019-10-02 20:55:39 +02001841 const uint8_t kPayloadType = 127;
1842 const VideoCodecType kCodecType = VideoCodecType::kVideoCodecGeneric;
Niels Möller5fe95102019-03-04 16:49:25 +01001843 PlayoutDelayOracle playout_delay_oracle;
Erik Språngdc34a252019-10-04 15:17:29 +02001844 FieldTrialBasedConfig field_trials;
1845 RTPSenderVideo::Config video_config;
1846 video_config.clock = &fake_clock_;
1847 video_config.rtp_sender = rtp_sender_.get();
1848 video_config.playout_delay_oracle = &playout_delay_oracle;
1849 video_config.field_trials = &field_trials;
1850 RTPSenderVideo rtp_sender_video(video_config);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001851 uint8_t payload[] = {47, 11, 32, 93, 89};
1852 rtp_sender_->SetStorePacketsStatus(true, 1);
1853 uint32_t ssrc = rtp_sender_->SSRC();
1854
1855 rtp_sender_->RegisterRtpStatisticsCallback(&callback);
1856
1857 // Send a frame.
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001858 RTPVideoHeader video_header;
Danil Chapovalov51bf2002019-10-11 10:53:27 +02001859 video_header.frame_type = VideoFrameType::kVideoFrameKey;
1860 ASSERT_TRUE(rtp_sender_video.SendVideo(kPayloadType, kCodecType, 1234, 4321,
1861 payload, nullptr, video_header,
1862 kDefaultExpectedRetransmissionTimeMs));
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001863 StreamDataCounters expected;
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001864 expected.transmitted.payload_bytes = 6;
1865 expected.transmitted.header_bytes = 12;
1866 expected.transmitted.padding_bytes = 0;
1867 expected.transmitted.packets = 1;
1868 expected.retransmitted.payload_bytes = 0;
1869 expected.retransmitted.header_bytes = 0;
1870 expected.retransmitted.padding_bytes = 0;
1871 expected.retransmitted.packets = 0;
1872 expected.fec.packets = 0;
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001873 callback.Matches(ssrc, expected);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001874
1875 // Retransmit a frame.
1876 uint16_t seqno = rtp_sender_->SequenceNumber() - 1;
Erik Språnga12b1d62018-03-14 12:39:24 +01001877 rtp_sender_->ReSendPacket(seqno);
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001878 expected.transmitted.payload_bytes = 12;
1879 expected.transmitted.header_bytes = 24;
1880 expected.transmitted.packets = 2;
1881 expected.retransmitted.payload_bytes = 6;
1882 expected.retransmitted.header_bytes = 12;
1883 expected.retransmitted.padding_bytes = 0;
1884 expected.retransmitted.packets = 1;
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001885 callback.Matches(ssrc, expected);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001886
1887 // Send padding.
Erik Språng4208a132019-08-26 08:58:45 +02001888 GenerateAndSendPadding(kMaxPaddingSize);
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001889 expected.transmitted.payload_bytes = 12;
1890 expected.transmitted.header_bytes = 36;
1891 expected.transmitted.padding_bytes = kMaxPaddingSize;
1892 expected.transmitted.packets = 3;
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001893 callback.Matches(ssrc, expected);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001894
Erik Språngdc34a252019-10-04 15:17:29 +02001895 rtp_sender_->RegisterRtpStatisticsCallback(nullptr);
1896}
1897
1898TEST_P(RtpSenderTestWithoutPacer, StreamDataCountersCallbacksUlpfec) {
1899 StreamDataTestCallback callback;
1900
1901 const uint8_t kRedPayloadType = 96;
1902 const uint8_t kUlpfecPayloadType = 97;
1903 const uint8_t kPayloadType = 127;
1904 const VideoCodecType kCodecType = VideoCodecType::kVideoCodecGeneric;
1905 PlayoutDelayOracle playout_delay_oracle;
1906 FieldTrialBasedConfig field_trials;
1907 RTPSenderVideo::Config video_config;
1908 video_config.clock = &fake_clock_;
1909 video_config.rtp_sender = rtp_sender_.get();
1910 video_config.playout_delay_oracle = &playout_delay_oracle;
1911 video_config.field_trials = &field_trials;
1912 video_config.red_payload_type = kRedPayloadType;
1913 video_config.ulpfec_payload_type = kUlpfecPayloadType;
1914 RTPSenderVideo rtp_sender_video(video_config);
1915 uint8_t payload[] = {47, 11, 32, 93, 89};
1916 rtp_sender_->SetStorePacketsStatus(true, 1);
1917 uint32_t ssrc = rtp_sender_->SSRC();
1918
1919 rtp_sender_->RegisterRtpStatisticsCallback(&callback);
1920
1921 RTPVideoHeader video_header;
1922 StreamDataCounters expected;
1923
brandtrf1bb4762016-11-07 03:05:06 -08001924 // Send ULPFEC.
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001925 FecProtectionParams fec_params;
1926 fec_params.fec_mask_type = kFecMaskRandom;
1927 fec_params.fec_rate = 1;
1928 fec_params.max_fec_frames = 1;
Niels Möller59ab1cf2019-02-06 22:48:11 +01001929 rtp_sender_video.SetFecParameters(fec_params, fec_params);
Danil Chapovalov51bf2002019-10-11 10:53:27 +02001930 video_header.frame_type = VideoFrameType::kVideoFrameDelta;
1931 ASSERT_TRUE(rtp_sender_video.SendVideo(kPayloadType, kCodecType, 1234, 4321,
1932 payload, nullptr, video_header,
1933 kDefaultExpectedRetransmissionTimeMs));
Erik Språngdc34a252019-10-04 15:17:29 +02001934 expected.transmitted.payload_bytes = 28;
1935 expected.transmitted.header_bytes = 24;
1936 expected.transmitted.packets = 2;
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001937 expected.fec.packets = 1;
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001938 callback.Matches(ssrc, expected);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001939
sprang867fb522015-08-03 04:38:41 -07001940 rtp_sender_->RegisterRtpStatisticsCallback(nullptr);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001941}
1942
minyue3a407ee2017-04-03 01:10:33 -07001943TEST_P(RtpSenderTestWithoutPacer, BytesReportedCorrectly) {
Niels Möller59ab1cf2019-02-06 22:48:11 +01001944 // XXX const char* kPayloadName = "GENERIC";
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001945 const uint8_t kPayloadType = 127;
Shao Changbine62202f2015-04-21 20:24:50 +08001946 rtp_sender_->SetRtxPayloadType(kPayloadType - 1, kPayloadType);
pbos@webrtc.org0b0c2412015-01-13 14:15:15 +00001947 rtp_sender_->SetRtxStatus(kRtxRetransmitted | kRtxRedundantPayloads);
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001948
Niels Möller59ab1cf2019-02-06 22:48:11 +01001949 SendGenericPacket();
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +00001950 // Will send 2 full-size padding packets.
Erik Språng4208a132019-08-26 08:58:45 +02001951 GenerateAndSendPadding(1);
1952 GenerateAndSendPadding(1);
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001953
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +00001954 StreamDataCounters rtp_stats;
1955 StreamDataCounters rtx_stats;
1956 rtp_sender_->GetDataCounters(&rtp_stats, &rtx_stats);
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001957
Niels Möller59ab1cf2019-02-06 22:48:11 +01001958 // Payload
asapersson@webrtc.orgd08d3892014-12-16 12:03:11 +00001959 EXPECT_GT(rtp_stats.first_packet_time_ms, -1);
Niels Möller59ab1cf2019-02-06 22:48:11 +01001960 EXPECT_EQ(rtp_stats.transmitted.payload_bytes, sizeof(kPayloadData));
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001961 EXPECT_EQ(rtp_stats.transmitted.header_bytes, 12u);
1962 EXPECT_EQ(rtp_stats.transmitted.padding_bytes, 0u);
1963 EXPECT_EQ(rtx_stats.transmitted.payload_bytes, 0u);
1964 EXPECT_EQ(rtx_stats.transmitted.header_bytes, 24u);
1965 EXPECT_EQ(rtx_stats.transmitted.padding_bytes, 2 * kMaxPaddingSize);
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +00001966
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001967 EXPECT_EQ(rtp_stats.transmitted.TotalBytes(),
danilchap162abd32015-12-10 02:39:40 -08001968 rtp_stats.transmitted.payload_bytes +
1969 rtp_stats.transmitted.header_bytes +
1970 rtp_stats.transmitted.padding_bytes);
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001971 EXPECT_EQ(rtx_stats.transmitted.TotalBytes(),
danilchap162abd32015-12-10 02:39:40 -08001972 rtx_stats.transmitted.payload_bytes +
1973 rtx_stats.transmitted.header_bytes +
1974 rtx_stats.transmitted.padding_bytes);
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001975
danilchap162abd32015-12-10 02:39:40 -08001976 EXPECT_EQ(
1977 transport_.total_bytes_sent_,
1978 rtp_stats.transmitted.TotalBytes() + rtx_stats.transmitted.TotalBytes());
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001979}
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001980
minyue3a407ee2017-04-03 01:10:33 -07001981TEST_P(RtpSenderTestWithoutPacer, RespectsNackBitrateLimit) {
sprang38778b02015-09-29 09:48:22 -07001982 const int32_t kPacketSize = 1400;
1983 const int32_t kNumPackets = 30;
1984
sprangcd349d92016-07-13 09:11:28 -07001985 retransmission_rate_limiter_.SetMaxRate(kPacketSize * kNumPackets * 8);
1986
sprang38778b02015-09-29 09:48:22 -07001987 rtp_sender_->SetStorePacketsStatus(true, kNumPackets);
sprang38778b02015-09-29 09:48:22 -07001988 const uint16_t kStartSequenceNumber = rtp_sender_->SequenceNumber();
Danil Chapovalov2800d742016-08-26 18:48:46 +02001989 std::vector<uint16_t> sequence_numbers;
sprang38778b02015-09-29 09:48:22 -07001990 for (int32_t i = 0; i < kNumPackets; ++i) {
1991 sequence_numbers.push_back(kStartSequenceNumber + i);
1992 fake_clock_.AdvanceTimeMilliseconds(1);
1993 SendPacket(fake_clock_.TimeInMilliseconds(), kPacketSize);
1994 }
danilchap12ba1862016-10-26 02:41:55 -07001995 EXPECT_EQ(kNumPackets, transport_.packets_sent());
sprang38778b02015-09-29 09:48:22 -07001996
1997 fake_clock_.AdvanceTimeMilliseconds(1000 - kNumPackets);
1998
1999 // Resending should work - brings the bandwidth up to the limit.
2000 // NACK bitrate is capped to the same bitrate as the encoder, since the max
2001 // protection overhead is 50% (see MediaOptimization::SetTargetRates).
Danil Chapovalov2800d742016-08-26 18:48:46 +02002002 rtp_sender_->OnReceivedNack(sequence_numbers, 0);
danilchap12ba1862016-10-26 02:41:55 -07002003 EXPECT_EQ(kNumPackets * 2, transport_.packets_sent());
sprang38778b02015-09-29 09:48:22 -07002004
sprangcd349d92016-07-13 09:11:28 -07002005 // Must be at least 5ms in between retransmission attempts.
2006 fake_clock_.AdvanceTimeMilliseconds(5);
2007
sprang38778b02015-09-29 09:48:22 -07002008 // Resending should not work, bandwidth exceeded.
Danil Chapovalov2800d742016-08-26 18:48:46 +02002009 rtp_sender_->OnReceivedNack(sequence_numbers, 0);
danilchap12ba1862016-10-26 02:41:55 -07002010 EXPECT_EQ(kNumPackets * 2, transport_.packets_sent());
sprang38778b02015-09-29 09:48:22 -07002011}
2012
minyue3a407ee2017-04-03 01:10:33 -07002013TEST_P(RtpSenderTest, OnOverheadChanged) {
michaelt4da30442016-11-17 01:38:43 -08002014 MockOverheadObserver mock_overhead_observer;
Erik Språng4580ca22019-07-04 10:38:43 +02002015 RtpRtcp::Configuration config;
2016 config.clock = &fake_clock_;
2017 config.outgoing_transport = &transport_;
Erik Språng54d5d2c2019-08-20 17:22:36 +02002018 config.local_media_ssrc = kSsrc;
Erik Språng4580ca22019-07-04 10:38:43 +02002019 config.retransmission_rate_limiter = &retransmission_rate_limiter_;
2020 config.overhead_observer = &mock_overhead_observer;
Mirko Bonadei317a1f02019-09-17 17:06:18 +02002021 rtp_sender_ = std::make_unique<RTPSender>(config);
michaelt4da30442016-11-17 01:38:43 -08002022
michaelt4da30442016-11-17 01:38:43 -08002023 // RTP overhead is 12B.
nisse284542b2017-01-10 08:58:32 -08002024 EXPECT_CALL(mock_overhead_observer, OnOverheadChanged(12)).Times(1);
Niels Möllere7b9e6b2019-02-06 18:23:44 +01002025 SendGenericPacket();
michaelt4da30442016-11-17 01:38:43 -08002026
2027 rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionTransmissionTimeOffset,
2028 kTransmissionTimeOffsetExtensionId);
2029
2030 // TransmissionTimeOffset extension has a size of 8B.
nisse284542b2017-01-10 08:58:32 -08002031 // 12B + 8B = 20B
2032 EXPECT_CALL(mock_overhead_observer, OnOverheadChanged(20)).Times(1);
Niels Möllere7b9e6b2019-02-06 18:23:44 +01002033 SendGenericPacket();
michaelt4da30442016-11-17 01:38:43 -08002034}
2035
minyue3a407ee2017-04-03 01:10:33 -07002036TEST_P(RtpSenderTest, DoesNotUpdateOverheadOnEqualSize) {
michaelt4da30442016-11-17 01:38:43 -08002037 MockOverheadObserver mock_overhead_observer;
Erik Språng4580ca22019-07-04 10:38:43 +02002038 RtpRtcp::Configuration config;
2039 config.clock = &fake_clock_;
2040 config.outgoing_transport = &transport_;
Erik Språng54d5d2c2019-08-20 17:22:36 +02002041 config.local_media_ssrc = kSsrc;
Erik Språng4580ca22019-07-04 10:38:43 +02002042 config.retransmission_rate_limiter = &retransmission_rate_limiter_;
2043 config.overhead_observer = &mock_overhead_observer;
Mirko Bonadei317a1f02019-09-17 17:06:18 +02002044 rtp_sender_ = std::make_unique<RTPSender>(config);
michaelt4da30442016-11-17 01:38:43 -08002045
2046 EXPECT_CALL(mock_overhead_observer, OnOverheadChanged(_)).Times(1);
Niels Möllere7b9e6b2019-02-06 18:23:44 +01002047 SendGenericPacket();
2048 SendGenericPacket();
michaelt4da30442016-11-17 01:38:43 -08002049}
2050
Erik Språng9c771c22019-06-17 16:31:53 +02002051TEST_P(RtpSenderTest, TrySendPacketMatchesVideo) {
2052 std::unique_ptr<RtpPacketToSend> packet =
2053 BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2054 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
2055
2056 // Verify not sent with wrong SSRC.
2057 packet->SetSsrc(kSsrc + 1);
2058 EXPECT_FALSE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2059
2060 // Verify sent with correct SSRC.
2061 packet = BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2062 packet->SetSsrc(kSsrc);
2063 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
2064 EXPECT_TRUE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2065}
2066
2067TEST_P(RtpSenderTest, TrySendPacketMatchesAudio) {
2068 std::unique_ptr<RtpPacketToSend> packet =
2069 BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2070 packet->set_packet_type(RtpPacketToSend::Type::kAudio);
2071
2072 // Verify not sent with wrong SSRC.
2073 packet->SetSsrc(kSsrc + 1);
2074 EXPECT_FALSE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2075
2076 // Verify sent with correct SSRC.
2077 packet = BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2078 packet->SetSsrc(kSsrc);
2079 packet->set_packet_type(RtpPacketToSend::Type::kAudio);
2080 EXPECT_TRUE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2081}
2082
2083TEST_P(RtpSenderTest, TrySendPacketMatchesRetransmissions) {
2084 std::unique_ptr<RtpPacketToSend> packet =
2085 BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2086 packet->set_packet_type(RtpPacketToSend::Type::kRetransmission);
2087
2088 // Verify not sent with wrong SSRC.
2089 packet->SetSsrc(kSsrc + 1);
2090 EXPECT_FALSE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2091
2092 // Verify sent with correct SSRC (non-RTX).
2093 packet = BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2094 packet->SetSsrc(kSsrc);
2095 packet->set_packet_type(RtpPacketToSend::Type::kRetransmission);
2096 EXPECT_TRUE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2097
2098 // RTX retransmission.
2099 packet = BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2100 packet->SetSsrc(kRtxSsrc);
2101 packet->set_packet_type(RtpPacketToSend::Type::kRetransmission);
2102 EXPECT_TRUE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2103}
2104
2105TEST_P(RtpSenderTest, TrySendPacketMatchesPadding) {
2106 std::unique_ptr<RtpPacketToSend> packet =
2107 BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2108 packet->set_packet_type(RtpPacketToSend::Type::kPadding);
2109
2110 // Verify not sent with wrong SSRC.
2111 packet->SetSsrc(kSsrc + 1);
2112 EXPECT_FALSE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2113
2114 // Verify sent with correct SSRC (non-RTX).
2115 packet = BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2116 packet->SetSsrc(kSsrc);
2117 packet->set_packet_type(RtpPacketToSend::Type::kPadding);
2118 EXPECT_TRUE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2119
2120 // RTX padding.
2121 packet = BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2122 packet->SetSsrc(kRtxSsrc);
2123 packet->set_packet_type(RtpPacketToSend::Type::kPadding);
2124 EXPECT_TRUE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2125}
2126
2127TEST_P(RtpSenderTest, TrySendPacketMatchesFlexfec) {
2128 std::unique_ptr<RtpPacketToSend> packet =
2129 BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2130 packet->set_packet_type(RtpPacketToSend::Type::kForwardErrorCorrection);
2131
2132 // Verify not sent with wrong SSRC.
2133 packet->SetSsrc(kSsrc + 1);
2134 EXPECT_FALSE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2135
2136 // Verify sent with correct SSRC.
2137 packet = BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2138 packet->SetSsrc(kFlexFecSsrc);
2139 packet->set_packet_type(RtpPacketToSend::Type::kForwardErrorCorrection);
2140 EXPECT_TRUE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2141}
2142
2143TEST_P(RtpSenderTest, TrySendPacketMatchesUlpfec) {
2144 std::unique_ptr<RtpPacketToSend> packet =
2145 BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2146 packet->set_packet_type(RtpPacketToSend::Type::kForwardErrorCorrection);
2147
2148 // Verify not sent with wrong SSRC.
2149 packet->SetSsrc(kSsrc + 1);
2150 EXPECT_FALSE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2151
2152 // Verify sent with correct SSRC.
2153 packet = BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2154 packet->SetSsrc(kSsrc);
2155 packet->set_packet_type(RtpPacketToSend::Type::kForwardErrorCorrection);
2156 EXPECT_TRUE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2157}
2158
2159TEST_P(RtpSenderTest, TrySendPacketHandlesRetransmissionHistory) {
2160 rtp_sender_->SetStorePacketsStatus(true, 10);
2161
2162 // Build a media packet and send it.
2163 std::unique_ptr<RtpPacketToSend> packet =
2164 BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2165 const uint16_t media_sequence_number = packet->SequenceNumber();
2166 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
2167 packet->set_allow_retransmission(true);
2168 EXPECT_TRUE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2169
2170 // Simulate retransmission request.
2171 fake_clock_.AdvanceTimeMilliseconds(30);
2172 EXPECT_GT(rtp_sender_->ReSendPacket(media_sequence_number), 0);
2173
2174 // Packet already pending, retransmission not allowed.
2175 fake_clock_.AdvanceTimeMilliseconds(30);
2176 EXPECT_EQ(rtp_sender_->ReSendPacket(media_sequence_number), 0);
2177
2178 // Packet exiting pacer, mark as not longer pending.
2179 packet = BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2180 EXPECT_NE(packet->SequenceNumber(), media_sequence_number);
2181 packet->set_packet_type(RtpPacketToSend::Type::kRetransmission);
2182 packet->SetSsrc(kRtxSsrc);
2183 packet->set_retransmitted_sequence_number(media_sequence_number);
2184 packet->set_allow_retransmission(false);
2185 EXPECT_TRUE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2186
2187 // Retransmissions allowed again.
2188 fake_clock_.AdvanceTimeMilliseconds(30);
2189 EXPECT_GT(rtp_sender_->ReSendPacket(media_sequence_number), 0);
2190
2191 // Retransmission of RTX packet should not be allowed.
2192 EXPECT_EQ(rtp_sender_->ReSendPacket(packet->SequenceNumber()), 0);
2193}
2194
2195TEST_P(RtpSenderTest, TrySendPacketUpdatesExtensions) {
2196 ASSERT_EQ(rtp_sender_->RegisterRtpHeaderExtension(
2197 kRtpExtensionTransmissionTimeOffset,
2198 kTransmissionTimeOffsetExtensionId),
2199 0);
2200 ASSERT_EQ(rtp_sender_->RegisterRtpHeaderExtension(
2201 kRtpExtensionAbsoluteSendTime, kAbsoluteSendTimeExtensionId),
2202 0);
2203 ASSERT_EQ(rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionVideoTiming,
2204 kVideoTimingExtensionId),
2205 0);
2206
2207 std::unique_ptr<RtpPacketToSend> packet =
2208 BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2209 packet->set_packetization_finish_time_ms(fake_clock_.TimeInMilliseconds());
2210
2211 const int32_t kDiffMs = 10;
2212 fake_clock_.AdvanceTimeMilliseconds(kDiffMs);
2213
2214 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
2215 EXPECT_TRUE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2216
2217 const RtpPacketReceived& received_packet = transport_.last_sent_packet();
2218
2219 EXPECT_EQ(received_packet.GetExtension<TransmissionOffset>(), kDiffMs * 90);
2220
2221 EXPECT_EQ(received_packet.GetExtension<AbsoluteSendTime>(),
2222 AbsoluteSendTime::MsTo24Bits(fake_clock_.TimeInMilliseconds()));
2223
2224 VideoSendTiming timing;
2225 EXPECT_TRUE(received_packet.GetExtension<VideoTimingExtension>(&timing));
2226 EXPECT_EQ(timing.pacer_exit_delta_ms, kDiffMs);
2227}
2228
2229TEST_P(RtpSenderTest, TrySendPacketSetsPacketOptions) {
2230 const uint16_t kPacketId = 42;
2231 ASSERT_EQ(rtp_sender_->RegisterRtpHeaderExtension(
2232 kRtpExtensionTransportSequenceNumber,
2233 kTransportSequenceNumberExtensionId),
2234 0);
2235 std::unique_ptr<RtpPacketToSend> packet =
2236 BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2237 packet->SetExtension<TransportSequenceNumber>(kPacketId);
2238
2239 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
2240 EXPECT_CALL(send_packet_observer_, OnSendPacket);
2241 EXPECT_TRUE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2242
2243 EXPECT_EQ(transport_.last_options_.packet_id, kPacketId);
2244 EXPECT_TRUE(transport_.last_options_.included_in_allocation);
2245 EXPECT_TRUE(transport_.last_options_.included_in_feedback);
2246 EXPECT_FALSE(transport_.last_options_.is_retransmit);
2247
2248 // Send another packet as retransmission, verify options are populated.
2249 packet = BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2250 packet->SetExtension<TransportSequenceNumber>(kPacketId + 1);
2251 packet->set_packet_type(RtpPacketToSend::Type::kRetransmission);
2252 EXPECT_TRUE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2253 EXPECT_TRUE(transport_.last_options_.is_retransmit);
2254}
2255
2256TEST_P(RtpSenderTest, TrySendPacketUpdatesStats) {
2257 const size_t kPayloadSize = 1000;
2258
2259 StrictMock<MockSendSideDelayObserver> send_side_delay_observer;
Erik Språng4580ca22019-07-04 10:38:43 +02002260
2261 RtpRtcp::Configuration config;
2262 config.clock = &fake_clock_;
2263 config.outgoing_transport = &transport_;
Erik Språng54d5d2c2019-08-20 17:22:36 +02002264 config.local_media_ssrc = kSsrc;
Erik Språng4580ca22019-07-04 10:38:43 +02002265 config.rtx_send_ssrc = kRtxSsrc;
2266 config.flexfec_sender = &flexfec_sender_;
2267 config.send_side_delay_observer = &send_side_delay_observer;
2268 config.event_log = &mock_rtc_event_log_;
2269 config.send_packet_observer = &send_packet_observer_;
Mirko Bonadei317a1f02019-09-17 17:06:18 +02002270 rtp_sender_ = std::make_unique<RTPSender>(config);
Erik Språng9c771c22019-06-17 16:31:53 +02002271 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
2272 kRtpExtensionTransportSequenceNumber,
2273 kTransportSequenceNumberExtensionId));
2274
2275 const int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
2276
2277 std::unique_ptr<RtpPacketToSend> video_packet =
2278 BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2279 video_packet->set_packet_type(RtpPacketToSend::Type::kVideo);
2280 video_packet->SetPayloadSize(kPayloadSize);
2281 video_packet->SetExtension<TransportSequenceNumber>(1);
2282
2283 std::unique_ptr<RtpPacketToSend> rtx_packet =
2284 BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2285 rtx_packet->SetSsrc(kRtxSsrc);
2286 rtx_packet->set_packet_type(RtpPacketToSend::Type::kRetransmission);
2287 rtx_packet->SetPayloadSize(kPayloadSize);
2288 rtx_packet->SetExtension<TransportSequenceNumber>(2);
2289
2290 std::unique_ptr<RtpPacketToSend> fec_packet =
2291 BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2292 fec_packet->SetSsrc(kFlexFecSsrc);
2293 fec_packet->set_packet_type(RtpPacketToSend::Type::kForwardErrorCorrection);
2294 fec_packet->SetPayloadSize(kPayloadSize);
2295 fec_packet->SetExtension<TransportSequenceNumber>(3);
2296
2297 const int64_t kDiffMs = 25;
2298 fake_clock_.AdvanceTimeMilliseconds(kDiffMs);
2299
2300 EXPECT_CALL(send_side_delay_observer,
2301 SendSideDelayUpdated(kDiffMs, kDiffMs, kDiffMs, kSsrc));
2302 EXPECT_CALL(
2303 send_side_delay_observer,
2304 SendSideDelayUpdated(kDiffMs, kDiffMs, 2 * kDiffMs, kFlexFecSsrc));
2305
2306 EXPECT_CALL(send_packet_observer_, OnSendPacket(1, capture_time_ms, kSsrc));
2307 EXPECT_TRUE(
2308 rtp_sender_->TrySendPacket(video_packet.get(), PacedPacketInfo()));
2309
2310 // Send packet observer not called for padding/retransmissions.
2311 EXPECT_CALL(send_packet_observer_, OnSendPacket(2, _, _)).Times(0);
2312 EXPECT_TRUE(rtp_sender_->TrySendPacket(rtx_packet.get(), PacedPacketInfo()));
2313
2314 EXPECT_CALL(send_packet_observer_,
2315 OnSendPacket(3, capture_time_ms, kFlexFecSsrc));
2316 EXPECT_TRUE(rtp_sender_->TrySendPacket(fec_packet.get(), PacedPacketInfo()));
2317
2318 StreamDataCounters rtp_stats;
2319 StreamDataCounters rtx_stats;
2320 rtp_sender_->GetDataCounters(&rtp_stats, &rtx_stats);
2321 EXPECT_EQ(rtp_stats.transmitted.packets, 2u);
2322 EXPECT_EQ(rtp_stats.fec.packets, 1u);
2323 EXPECT_EQ(rtx_stats.retransmitted.packets, 1u);
2324}
2325
Erik Språng478cb462019-06-26 15:49:27 +02002326TEST_P(RtpSenderTest, GeneratePaddingResendsOldPacketsWithRtx) {
Mirko Bonadeia7e3bce2019-07-12 17:35:56 +00002327 // Min requested size in order to use RTX payload.
2328 const size_t kMinPaddingSize = 50;
2329
Erik Språng478cb462019-06-26 15:49:27 +02002330 rtp_sender_->SetRtxStatus(kRtxRetransmitted | kRtxRedundantPayloads);
2331 rtp_sender_->SetRtxPayloadType(kRtxPayload, kPayload);
2332 rtp_sender_->SetStorePacketsStatus(true, 1);
2333
Erik Språng0f6191d2019-07-15 20:33:40 +02002334 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
2335 kRtpExtensionTransmissionTimeOffset,
2336 kTransmissionTimeOffsetExtensionId));
2337 ASSERT_EQ(
2338 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
2339 kAbsoluteSendTimeExtensionId));
2340 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
2341 kRtpExtensionTransportSequenceNumber,
2342 kTransportSequenceNumberExtensionId));
2343
Erik Språng478cb462019-06-26 15:49:27 +02002344 const size_t kPayloadPacketSize = 1234;
2345 std::unique_ptr<RtpPacketToSend> packet =
2346 BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2347 packet->set_allow_retransmission(true);
2348 packet->SetPayloadSize(kPayloadPacketSize);
2349 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
2350
2351 // Send a dummy video packet so it ends up in the packet history.
Erik Språng0f6191d2019-07-15 20:33:40 +02002352 EXPECT_CALL(send_packet_observer_, OnSendPacket).Times(1);
Erik Språng478cb462019-06-26 15:49:27 +02002353 EXPECT_TRUE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2354
2355 // Generated padding has large enough budget that the video packet should be
2356 // retransmitted as padding.
Erik Språngf6468d22019-07-05 16:53:43 +02002357 std::vector<std::unique_ptr<RtpPacketToSend>> generated_packets =
Mirko Bonadeia7e3bce2019-07-12 17:35:56 +00002358 rtp_sender_->GeneratePadding(kMinPaddingSize);
Erik Språngf6468d22019-07-05 16:53:43 +02002359 ASSERT_EQ(generated_packets.size(), 1u);
2360 auto& padding_packet = generated_packets.front();
2361 EXPECT_EQ(padding_packet->packet_type(), RtpPacketToSend::Type::kPadding);
2362 EXPECT_EQ(padding_packet->Ssrc(), kRtxSsrc);
2363 EXPECT_EQ(padding_packet->payload_size(),
2364 kPayloadPacketSize + kRtxHeaderSize);
Erik Språng0f6191d2019-07-15 20:33:40 +02002365 EXPECT_TRUE(padding_packet->IsExtensionReserved<TransportSequenceNumber>());
2366 EXPECT_TRUE(padding_packet->IsExtensionReserved<AbsoluteSendTime>());
2367 EXPECT_TRUE(padding_packet->IsExtensionReserved<TransmissionOffset>());
2368
2369 // Verify all header extensions are received.
2370 EXPECT_TRUE(
2371 rtp_sender_->TrySendPacket(padding_packet.get(), PacedPacketInfo()));
2372 webrtc::RTPHeader rtp_header;
2373 transport_.last_sent_packet().GetHeader(&rtp_header);
2374 EXPECT_TRUE(rtp_header.extension.hasAbsoluteSendTime);
2375 EXPECT_TRUE(rtp_header.extension.hasTransmissionTimeOffset);
2376 EXPECT_TRUE(rtp_header.extension.hasTransportSequenceNumber);
Erik Språng478cb462019-06-26 15:49:27 +02002377
2378 // Not enough budged for payload padding, use plain padding instead.
Mirko Bonadeia7e3bce2019-07-12 17:35:56 +00002379 const size_t kPaddingBytesRequested = kMinPaddingSize - 1;
Erik Språngf6468d22019-07-05 16:53:43 +02002380
2381 size_t padding_bytes_generated = 0;
2382 generated_packets = rtp_sender_->GeneratePadding(kPaddingBytesRequested);
Mirko Bonadeia7e3bce2019-07-12 17:35:56 +00002383 EXPECT_EQ(generated_packets.size(), 1u);
Erik Språngf6468d22019-07-05 16:53:43 +02002384 for (auto& packet : generated_packets) {
2385 EXPECT_EQ(packet->packet_type(), RtpPacketToSend::Type::kPadding);
2386 EXPECT_EQ(packet->Ssrc(), kRtxSsrc);
2387 EXPECT_EQ(packet->payload_size(), 0u);
2388 EXPECT_GT(packet->padding_size(), 0u);
2389 padding_bytes_generated += packet->padding_size();
Erik Språng0f6191d2019-07-15 20:33:40 +02002390
2391 EXPECT_TRUE(packet->IsExtensionReserved<TransportSequenceNumber>());
2392 EXPECT_TRUE(packet->IsExtensionReserved<AbsoluteSendTime>());
2393 EXPECT_TRUE(packet->IsExtensionReserved<TransmissionOffset>());
2394
2395 // Verify all header extensions are received.
2396 EXPECT_TRUE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2397 webrtc::RTPHeader rtp_header;
2398 transport_.last_sent_packet().GetHeader(&rtp_header);
2399 EXPECT_TRUE(rtp_header.extension.hasAbsoluteSendTime);
2400 EXPECT_TRUE(rtp_header.extension.hasTransmissionTimeOffset);
2401 EXPECT_TRUE(rtp_header.extension.hasTransportSequenceNumber);
Erik Språngf6468d22019-07-05 16:53:43 +02002402 }
2403
Mirko Bonadeia7e3bce2019-07-12 17:35:56 +00002404 EXPECT_EQ(padding_bytes_generated, kMaxPaddingSize);
Erik Språng478cb462019-06-26 15:49:27 +02002405}
2406
2407TEST_P(RtpSenderTest, GeneratePaddingCreatesPurePaddingWithoutRtx) {
2408 rtp_sender_->SetStorePacketsStatus(true, 1);
Erik Språng0f6191d2019-07-15 20:33:40 +02002409 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
2410 kRtpExtensionTransmissionTimeOffset,
2411 kTransmissionTimeOffsetExtensionId));
2412 ASSERT_EQ(
2413 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
2414 kAbsoluteSendTimeExtensionId));
2415 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
2416 kRtpExtensionTransportSequenceNumber,
2417 kTransportSequenceNumberExtensionId));
Erik Språng478cb462019-06-26 15:49:27 +02002418
2419 const size_t kPayloadPacketSize = 1234;
2420 // Send a dummy video packet so it ends up in the packet history. Since we
2421 // are not using RTX, it should never be used as padding.
2422 std::unique_ptr<RtpPacketToSend> packet =
2423 BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2424 packet->set_allow_retransmission(true);
2425 packet->SetPayloadSize(kPayloadPacketSize);
2426 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
Erik Språng0f6191d2019-07-15 20:33:40 +02002427 EXPECT_CALL(send_packet_observer_, OnSendPacket).Times(1);
Erik Språng478cb462019-06-26 15:49:27 +02002428 EXPECT_TRUE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2429
2430 // Payload padding not available without RTX, only generate plain padding on
2431 // the media SSRC.
2432 // Number of padding packets is the requested padding size divided by max
2433 // padding packet size, rounded up. Pure padding packets are always of the
2434 // maximum size.
2435 const size_t kPaddingBytesRequested = kPayloadPacketSize + kRtxHeaderSize;
2436 const size_t kExpectedNumPaddingPackets =
2437 (kPaddingBytesRequested + kMaxPaddingSize - 1) / kMaxPaddingSize;
Erik Språngf6468d22019-07-05 16:53:43 +02002438 size_t padding_bytes_generated = 0;
2439 std::vector<std::unique_ptr<RtpPacketToSend>> padding_packets =
2440 rtp_sender_->GeneratePadding(kPaddingBytesRequested);
2441 EXPECT_EQ(padding_packets.size(), kExpectedNumPaddingPackets);
2442 for (auto& packet : padding_packets) {
2443 EXPECT_EQ(packet->packet_type(), RtpPacketToSend::Type::kPadding);
2444 EXPECT_EQ(packet->Ssrc(), kSsrc);
2445 EXPECT_EQ(packet->payload_size(), 0u);
2446 EXPECT_GT(packet->padding_size(), 0u);
2447 padding_bytes_generated += packet->padding_size();
Erik Språng0f6191d2019-07-15 20:33:40 +02002448 EXPECT_TRUE(packet->IsExtensionReserved<TransportSequenceNumber>());
2449 EXPECT_TRUE(packet->IsExtensionReserved<AbsoluteSendTime>());
2450 EXPECT_TRUE(packet->IsExtensionReserved<TransmissionOffset>());
2451
2452 // Verify all header extensions are received.
2453 EXPECT_TRUE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2454 webrtc::RTPHeader rtp_header;
2455 transport_.last_sent_packet().GetHeader(&rtp_header);
2456 EXPECT_TRUE(rtp_header.extension.hasAbsoluteSendTime);
2457 EXPECT_TRUE(rtp_header.extension.hasTransmissionTimeOffset);
2458 EXPECT_TRUE(rtp_header.extension.hasTransportSequenceNumber);
Erik Språngf6468d22019-07-05 16:53:43 +02002459 }
2460
2461 EXPECT_EQ(padding_bytes_generated,
2462 kExpectedNumPaddingPackets * kMaxPaddingSize);
Erik Språng478cb462019-06-26 15:49:27 +02002463}
2464
Mirko Bonadei999a72a2019-07-12 17:33:46 +00002465TEST_P(RtpSenderTest, SupportsPadding) {
2466 bool kSendingMediaStats[] = {true, false};
2467 bool kEnableRedundantPayloads[] = {true, false};
2468 RTPExtensionType kBweExtensionTypes[] = {
2469 kRtpExtensionTransportSequenceNumber,
2470 kRtpExtensionTransportSequenceNumber02, kRtpExtensionAbsoluteSendTime,
2471 kRtpExtensionTransmissionTimeOffset};
2472 const int kExtensionsId = 7;
2473
2474 for (bool sending_media : kSendingMediaStats) {
2475 rtp_sender_->SetSendingMediaStatus(sending_media);
2476 for (bool redundant_payloads : kEnableRedundantPayloads) {
2477 int rtx_mode = kRtxRetransmitted;
2478 if (redundant_payloads) {
2479 rtx_mode |= kRtxRedundantPayloads;
2480 }
2481 rtp_sender_->SetRtxStatus(rtx_mode);
2482
2483 for (auto extension_type : kBweExtensionTypes) {
2484 EXPECT_FALSE(rtp_sender_->SupportsPadding());
2485 rtp_sender_->RegisterRtpHeaderExtension(extension_type, kExtensionsId);
2486 if (!sending_media) {
2487 EXPECT_FALSE(rtp_sender_->SupportsPadding());
2488 } else {
2489 EXPECT_TRUE(rtp_sender_->SupportsPadding());
2490 if (redundant_payloads) {
2491 EXPECT_TRUE(rtp_sender_->SupportsRtxPayloadPadding());
2492 } else {
2493 EXPECT_FALSE(rtp_sender_->SupportsRtxPayloadPadding());
2494 }
2495 }
2496 rtp_sender_->DeregisterRtpHeaderExtension(extension_type);
2497 EXPECT_FALSE(rtp_sender_->SupportsPadding());
2498 }
2499 }
2500 }
2501}
2502
Erik Språnga57711c2019-07-24 10:47:20 +02002503TEST_P(RtpSenderTest, SetsCaptureTimeAndPopulatesTransmissionOffset) {
2504 rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionTransmissionTimeOffset,
2505 kTransmissionTimeOffsetExtensionId);
2506
2507 rtp_sender_->SetSendingMediaStatus(true);
2508 rtp_sender_->SetRtxStatus(kRtxRetransmitted | kRtxRedundantPayloads);
2509 rtp_sender_->SetRtxPayloadType(kRtxPayload, kPayload);
2510 rtp_sender_->SetStorePacketsStatus(true, 10);
2511
2512 const int64_t kMissingCaptureTimeMs = 0;
2513 const uint32_t kTimestampTicksPerMs = 90;
2514 const int64_t kOffsetMs = 10;
2515
Erik Språnga57711c2019-07-24 10:47:20 +02002516 auto packet =
2517 BuildRtpPacket(kPayload, kMarkerBit, fake_clock_.TimeInMilliseconds(),
2518 kMissingCaptureTimeMs);
2519 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
2520 packet->ReserveExtension<TransmissionOffset>();
2521 packet->AllocatePayload(sizeof(kPayloadData));
2522
2523 std::unique_ptr<RtpPacketToSend> packet_to_pace;
Erik Språngea55b082019-10-02 14:57:46 +02002524 EXPECT_CALL(mock_paced_sender_, EnqueuePackets)
2525 .WillOnce([&](std::vector<std::unique_ptr<RtpPacketToSend>> packets) {
2526 EXPECT_EQ(packets.size(), 1u);
2527 EXPECT_GT(packets[0]->capture_time_ms(), 0);
2528 packet_to_pace = std::move(packets[0]);
Erik Språnga57711c2019-07-24 10:47:20 +02002529 });
2530
Erik Språng70768f42019-08-27 18:16:26 +02002531 packet->set_allow_retransmission(true);
2532 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet)));
Erik Språnga57711c2019-07-24 10:47:20 +02002533
2534 fake_clock_.AdvanceTimeMilliseconds(kOffsetMs);
2535
2536 rtp_sender_->TrySendPacket(packet_to_pace.get(), PacedPacketInfo());
Erik Språnga57711c2019-07-24 10:47:20 +02002537
2538 EXPECT_EQ(1, transport_.packets_sent());
2539 absl::optional<int32_t> transmission_time_extension =
2540 transport_.sent_packets_.back().GetExtension<TransmissionOffset>();
2541 ASSERT_TRUE(transmission_time_extension.has_value());
2542 EXPECT_EQ(*transmission_time_extension, kOffsetMs * kTimestampTicksPerMs);
2543
2544 // Retransmit packet. The RTX packet should get the same capture time as the
2545 // original packet, so offset is delta from original packet to now.
2546 fake_clock_.AdvanceTimeMilliseconds(kOffsetMs);
2547
Erik Språnga57711c2019-07-24 10:47:20 +02002548 std::unique_ptr<RtpPacketToSend> rtx_packet_to_pace;
Erik Språngea55b082019-10-02 14:57:46 +02002549 EXPECT_CALL(mock_paced_sender_, EnqueuePackets)
2550 .WillOnce([&](std::vector<std::unique_ptr<RtpPacketToSend>> packets) {
2551 EXPECT_GT(packets[0]->capture_time_ms(), 0);
2552 rtx_packet_to_pace = std::move(packets[0]);
Erik Språnga57711c2019-07-24 10:47:20 +02002553 });
2554
2555 EXPECT_GT(rtp_sender_->ReSendPacket(kSeqNum), 0);
2556 rtp_sender_->TrySendPacket(rtx_packet_to_pace.get(), PacedPacketInfo());
Erik Språnga57711c2019-07-24 10:47:20 +02002557
2558 EXPECT_EQ(2, transport_.packets_sent());
2559 transmission_time_extension =
2560 transport_.sent_packets_.back().GetExtension<TransmissionOffset>();
2561 ASSERT_TRUE(transmission_time_extension.has_value());
2562 EXPECT_EQ(*transmission_time_extension, 2 * kOffsetMs * kTimestampTicksPerMs);
2563}
2564
Erik Språng6cacef22019-07-24 14:15:51 +02002565TEST_P(RtpSenderTestWithoutPacer, ClearHistoryOnSsrcChange) {
2566 const int64_t kRtt = 10;
2567
2568 rtp_sender_->SetSendingMediaStatus(true);
2569 rtp_sender_->SetRtxStatus(kRtxRetransmitted | kRtxRedundantPayloads);
2570 rtp_sender_->SetRtxPayloadType(kRtxPayload, kPayload);
2571 rtp_sender_->SetStorePacketsStatus(true, 10);
2572 rtp_sender_->SetRtt(kRtt);
Erik Språng6cacef22019-07-24 14:15:51 +02002573
2574 // Send a packet and record its sequence numbers.
2575 SendGenericPacket();
2576 ASSERT_EQ(1u, transport_.sent_packets_.size());
2577 const uint16_t packet_seqence_number =
2578 transport_.sent_packets_.back().SequenceNumber();
2579
2580 // Advance time and make sure it can be retransmitted, even if we try to set
2581 // the ssrc the what it already is.
2582 rtp_sender_->SetSSRC(kSsrc);
2583 fake_clock_.AdvanceTimeMilliseconds(kRtt);
2584 EXPECT_GT(rtp_sender_->ReSendPacket(packet_seqence_number), 0);
2585
2586 // Change the SSRC, then move the time and try to retransmit again. The old
2587 // packet should now be gone.
2588 rtp_sender_->SetSSRC(kSsrc + 1);
2589 fake_clock_.AdvanceTimeMilliseconds(kRtt);
2590 EXPECT_EQ(rtp_sender_->ReSendPacket(packet_seqence_number), 0);
2591}
2592
2593TEST_P(RtpSenderTestWithoutPacer, ClearHistoryOnSequenceNumberCange) {
2594 const int64_t kRtt = 10;
2595
2596 rtp_sender_->SetSendingMediaStatus(true);
2597 rtp_sender_->SetRtxStatus(kRtxRetransmitted | kRtxRedundantPayloads);
2598 rtp_sender_->SetRtxPayloadType(kRtxPayload, kPayload);
2599 rtp_sender_->SetStorePacketsStatus(true, 10);
2600 rtp_sender_->SetRtt(kRtt);
2601
2602 // Send a packet and record its sequence numbers.
2603 SendGenericPacket();
2604 ASSERT_EQ(1u, transport_.sent_packets_.size());
2605 const uint16_t packet_seqence_number =
2606 transport_.sent_packets_.back().SequenceNumber();
2607
2608 // Advance time and make sure it can be retransmitted, even if we try to set
2609 // the ssrc the what it already is.
2610 rtp_sender_->SetSequenceNumber(rtp_sender_->SequenceNumber());
2611 fake_clock_.AdvanceTimeMilliseconds(kRtt);
2612 EXPECT_GT(rtp_sender_->ReSendPacket(packet_seqence_number), 0);
2613
2614 // Change the sequence number, then move the time and try to retransmit again.
2615 // The old packet should now be gone.
2616 rtp_sender_->SetSequenceNumber(rtp_sender_->SequenceNumber() - 1);
2617 fake_clock_.AdvanceTimeMilliseconds(kRtt);
2618 EXPECT_EQ(rtp_sender_->ReSendPacket(packet_seqence_number), 0);
2619}
2620
Erik Språng60ffc312019-07-30 22:03:49 +02002621TEST_P(RtpSenderTest, IgnoresNackAfterDisablingMedia) {
2622 const int64_t kRtt = 10;
2623
2624 rtp_sender_->SetSendingMediaStatus(true);
2625 rtp_sender_->SetRtxStatus(kRtxRetransmitted | kRtxRedundantPayloads);
2626 rtp_sender_->SetRtxPayloadType(kRtxPayload, kPayload);
2627 rtp_sender_->SetStorePacketsStatus(true, 10);
2628 rtp_sender_->SetRtt(kRtt);
2629
2630 // Send a packet so it is in the packet history.
Erik Språng60ffc312019-07-30 22:03:49 +02002631 std::unique_ptr<RtpPacketToSend> packet_to_pace;
Erik Språngea55b082019-10-02 14:57:46 +02002632 EXPECT_CALL(mock_paced_sender_, EnqueuePackets)
2633 .WillOnce([&](std::vector<std::unique_ptr<RtpPacketToSend>> packets) {
2634 packet_to_pace = std::move(packets[0]);
Erik Språng60ffc312019-07-30 22:03:49 +02002635 });
2636
2637 SendGenericPacket();
2638 rtp_sender_->TrySendPacket(packet_to_pace.get(), PacedPacketInfo());
2639
2640 ASSERT_EQ(1u, transport_.sent_packets_.size());
2641
2642 // Disable media sending and try to retransmit the packet, it should fail.
2643 rtp_sender_->SetSendingMediaStatus(false);
2644 fake_clock_.AdvanceTimeMilliseconds(kRtt);
2645 EXPECT_LT(rtp_sender_->ReSendPacket(kSeqNum), 0);
Erik Språng60ffc312019-07-30 22:03:49 +02002646}
2647
Mirko Bonadeic84f6612019-01-31 12:20:57 +01002648INSTANTIATE_TEST_SUITE_P(WithAndWithoutOverhead,
2649 RtpSenderTest,
Erik Språngf5815fa2019-08-21 14:27:31 +02002650 ::testing::Values(TestConfig{false},
2651 TestConfig{true}));
Erik Språngf6468d22019-07-05 16:53:43 +02002652
Mirko Bonadeic84f6612019-01-31 12:20:57 +01002653INSTANTIATE_TEST_SUITE_P(WithAndWithoutOverhead,
2654 RtpSenderTestWithoutPacer,
Erik Språngf5815fa2019-08-21 14:27:31 +02002655 ::testing::Values(TestConfig{false},
2656 TestConfig{true}));
Niels Möllera34d7762019-02-01 14:13:29 +01002657
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00002658} // namespace webrtc