asapersson@webrtc.org | 5249cc8 | 2011-12-16 14:31:37 +0000 | [diff] [blame] | 1 | /* |
phoglund@webrtc.org | 78088c2 | 2012-02-07 14:56:45 +0000 | [diff] [blame] | 2 | * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. |
asapersson@webrtc.org | 5249cc8 | 2011-12-16 14:31:37 +0000 | [diff] [blame] | 3 | * |
| 4 | * Use of this source code is governed by a BSD-style license |
| 5 | * that can be found in the LICENSE file in the root of the source |
| 6 | * tree. An additional intellectual property rights grant can be found |
| 7 | * in the file PATENTS. All contributing project authors may |
| 8 | * be found in the AUTHORS file in the root of the source tree. |
| 9 | */ |
| 10 | |
Jonas Olsson | a4d8737 | 2019-07-05 19:08:33 +0200 | [diff] [blame] | 11 | #include "modules/rtp_rtcp/source/rtp_sender.h" |
| 12 | |
kwiberg | 84be511 | 2016-04-27 01:19:58 -0700 | [diff] [blame] | 13 | #include <memory> |
danilchap | b8b6fbb | 2015-12-10 05:05:27 -0800 | [diff] [blame] | 14 | #include <vector> |
| 15 | |
Danil Chapovalov | 16cb1f6 | 2019-09-05 11:29:59 +0200 | [diff] [blame] | 16 | #include "api/rtc_event_log/rtc_event.h" |
Per Kjellander | e11b7d2 | 2019-02-21 07:55:59 +0100 | [diff] [blame] | 17 | #include "api/transport/field_trial_based_config.h" |
Erik Språng | f93eda1 | 2019-01-16 17:10:57 +0100 | [diff] [blame] | 18 | #include "api/video/video_codec_constants.h" |
Mirko Bonadei | 92ea95e | 2017-09-15 06:47:31 +0200 | [diff] [blame] | 19 | #include "api/video/video_timing.h" |
| 20 | #include "logging/rtc_event_log/mock/mock_rtc_event_log.h" |
| 21 | #include "modules/rtp_rtcp/include/rtp_cvo.h" |
| 22 | #include "modules/rtp_rtcp/include/rtp_header_extension_map.h" |
Erik Språng | aa59eca | 2019-07-24 14:52:55 +0200 | [diff] [blame] | 23 | #include "modules/rtp_rtcp/include/rtp_packet_sender.h" |
Mirko Bonadei | 92ea95e | 2017-09-15 06:47:31 +0200 | [diff] [blame] | 24 | #include "modules/rtp_rtcp/include/rtp_rtcp_defines.h" |
| 25 | #include "modules/rtp_rtcp/source/rtcp_packet/transport_feedback.h" |
| 26 | #include "modules/rtp_rtcp/source/rtp_format_video_generic.h" |
philipel | b3e42a4 | 2018-09-13 10:57:14 +0200 | [diff] [blame] | 27 | #include "modules/rtp_rtcp/source/rtp_generic_frame_descriptor.h" |
| 28 | #include "modules/rtp_rtcp/source/rtp_generic_frame_descriptor_extension.h" |
Mirko Bonadei | 92ea95e | 2017-09-15 06:47:31 +0200 | [diff] [blame] | 29 | #include "modules/rtp_rtcp/source/rtp_header_extensions.h" |
| 30 | #include "modules/rtp_rtcp/source/rtp_packet_received.h" |
| 31 | #include "modules/rtp_rtcp/source/rtp_packet_to_send.h" |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 32 | #include "modules/rtp_rtcp/source/rtp_sender_egress.h" |
Mirko Bonadei | 92ea95e | 2017-09-15 06:47:31 +0200 | [diff] [blame] | 33 | #include "modules/rtp_rtcp/source/rtp_sender_video.h" |
| 34 | #include "modules/rtp_rtcp/source/rtp_utility.h" |
| 35 | #include "rtc_base/arraysize.h" |
Mirko Bonadei | 92ea95e | 2017-09-15 06:47:31 +0200 | [diff] [blame] | 36 | #include "rtc_base/rate_limiter.h" |
| 37 | #include "test/field_trial.h" |
| 38 | #include "test/gmock.h" |
| 39 | #include "test/gtest.h" |
| 40 | #include "test/mock_transport.h" |
Tommi | 25eb47c | 2019-08-29 16:39:05 +0200 | [diff] [blame] | 41 | #include "test/rtp_header_parser.h" |
asapersson@webrtc.org | 5249cc8 | 2011-12-16 14:31:37 +0000 | [diff] [blame] | 42 | |
| 43 | namespace webrtc { |
| 44 | |
andrew@webrtc.org | 8a44259 | 2011-12-16 21:24:30 +0000 | [diff] [blame] | 45 | namespace { |
Elad Alon | d8d3248 | 2019-02-18 23:45:57 +0100 | [diff] [blame] | 46 | enum : int { // The first valid value is 1. |
| 47 | kAbsoluteSendTimeExtensionId = 1, |
| 48 | kAudioLevelExtensionId, |
Elad Alon | ccb9b75 | 2019-02-19 13:01:31 +0100 | [diff] [blame] | 49 | kGenericDescriptorId00, |
| 50 | kGenericDescriptorId01, |
Elad Alon | d8d3248 | 2019-02-18 23:45:57 +0100 | [diff] [blame] | 51 | kMidExtensionId, |
| 52 | kRepairedRidExtensionId, |
| 53 | kRidExtensionId, |
| 54 | kTransmissionTimeOffsetExtensionId, |
| 55 | kTransportSequenceNumberExtensionId, |
| 56 | kVideoRotationExtensionId, |
| 57 | kVideoTimingExtensionId, |
| 58 | }; |
| 59 | |
andrew@webrtc.org | 8a44259 | 2011-12-16 21:24:30 +0000 | [diff] [blame] | 60 | const int kPayload = 100; |
Shao Changbin | e62202f | 2015-04-21 20:24:50 +0800 | [diff] [blame] | 61 | const int kRtxPayload = 98; |
andrew@webrtc.org | 8a44259 | 2011-12-16 21:24:30 +0000 | [diff] [blame] | 62 | const uint32_t kTimestamp = 10; |
| 63 | const uint16_t kSeqNum = 33; |
brandtr | 9dfff29 | 2016-11-14 05:14:50 -0800 | [diff] [blame] | 64 | const uint32_t kSsrc = 725242; |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 65 | const uint32_t kRtxSsrc = 12345; |
| 66 | const uint32_t kFlexFecSsrc = 45678; |
Erik Språng | 1fbfecd | 2019-08-26 19:00:05 +0200 | [diff] [blame] | 67 | const uint16_t kTransportSequenceNumber = 1; |
sprang@webrtc.org | 6811b6e | 2013-12-13 09:46:59 +0000 | [diff] [blame] | 68 | const uint64_t kStartTime = 123456789; |
pbos@webrtc.org | 2f4b14e | 2014-07-15 15:25:39 +0000 | [diff] [blame] | 69 | const size_t kMaxPaddingSize = 224u; |
Stefan Holmer | a246cfb | 2016-08-23 17:51:42 +0200 | [diff] [blame] | 70 | const uint8_t kPayloadData[] = {47, 11, 32, 93, 89}; |
sprang | a8ae6f2 | 2017-09-04 07:23:56 -0700 | [diff] [blame] | 71 | const int64_t kDefaultExpectedRetransmissionTimeMs = 125; |
Amit Hilbuch | 77938e6 | 2018-12-21 09:23:38 -0800 | [diff] [blame] | 72 | const char kNoRid[] = ""; |
| 73 | const char kNoMid[] = ""; |
andrew@webrtc.org | 8a44259 | 2011-12-16 21:24:30 +0000 | [diff] [blame] | 74 | |
Danil Chapovalov | 5e57b17 | 2016-09-02 19:15:59 +0200 | [diff] [blame] | 75 | using ::testing::_; |
Erik Språng | 30a276b | 2019-04-23 12:00:11 +0200 | [diff] [blame] | 76 | using ::testing::AllOf; |
Erik Språng | ea55b08 | 2019-10-02 14:57:46 +0200 | [diff] [blame] | 77 | using ::testing::Contains; |
Danil Chapovalov | 5e57b17 | 2016-09-02 19:15:59 +0200 | [diff] [blame] | 78 | using ::testing::ElementsAreArray; |
Erik Språng | 30a276b | 2019-04-23 12:00:11 +0200 | [diff] [blame] | 79 | using ::testing::Field; |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 80 | using ::testing::NiceMock; |
Erik Språng | 478cb46 | 2019-06-26 15:49:27 +0200 | [diff] [blame] | 81 | using ::testing::Pointee; |
| 82 | using ::testing::Property; |
Erik Språng | 214f543 | 2019-06-20 15:09:58 +0200 | [diff] [blame] | 83 | using ::testing::Return; |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 84 | using ::testing::StrictMock; |
pwestin@webrtc.org | b0061f9 | 2013-04-27 00:41:08 +0000 | [diff] [blame] | 85 | |
henrik.lundin@webrtc.org | 6e95d7a | 2013-11-15 08:59:19 +0000 | [diff] [blame] | 86 | uint64_t ConvertMsToAbsSendTime(int64_t time_ms) { |
Stefan Holmer | 0a87ffc | 2015-10-21 13:41:48 +0200 | [diff] [blame] | 87 | return (((time_ms << 18) + 500) / 1000) & 0x00ffffff; |
henrik.lundin@webrtc.org | 6e95d7a | 2013-11-15 08:59:19 +0000 | [diff] [blame] | 88 | } |
| 89 | |
asapersson@webrtc.org | 0b3c35a | 2012-01-16 11:06:31 +0000 | [diff] [blame] | 90 | class LoopbackTransportTest : public webrtc::Transport { |
| 91 | public: |
Petter Strandmark | 26bc669 | 2018-05-29 08:43:35 +0200 | [diff] [blame] | 92 | LoopbackTransportTest() : total_bytes_sent_(0) { |
Danil Chapovalov | a74e477 | 2019-09-12 17:53:04 +0200 | [diff] [blame] | 93 | receivers_extensions_.Register<TransmissionOffset>( |
| 94 | kTransmissionTimeOffsetExtensionId); |
| 95 | receivers_extensions_.Register<AbsoluteSendTime>( |
| 96 | kAbsoluteSendTimeExtensionId); |
| 97 | receivers_extensions_.Register<TransportSequenceNumber>( |
| 98 | kTransportSequenceNumberExtensionId); |
| 99 | receivers_extensions_.Register<VideoOrientation>(kVideoRotationExtensionId); |
| 100 | receivers_extensions_.Register<AudioLevel>(kAudioLevelExtensionId); |
| 101 | receivers_extensions_.Register<VideoTimingExtension>( |
| 102 | kVideoTimingExtensionId); |
| 103 | receivers_extensions_.Register<RtpMid>(kMidExtensionId); |
| 104 | receivers_extensions_.Register<RtpGenericFrameDescriptorExtension00>( |
| 105 | kGenericDescriptorId00); |
| 106 | receivers_extensions_.Register<RtpGenericFrameDescriptorExtension01>( |
| 107 | kGenericDescriptorId01); |
| 108 | receivers_extensions_.Register<RtpStreamId>(kRidExtensionId); |
| 109 | receivers_extensions_.Register<RepairedRtpStreamId>( |
| 110 | kRepairedRidExtensionId); |
guoweis@webrtc.org | 4536289 | 2015-03-04 22:55:15 +0000 | [diff] [blame] | 111 | } |
danilchap | 12ba186 | 2016-10-26 02:41:55 -0700 | [diff] [blame] | 112 | |
stefan | 1d8a506 | 2015-10-02 03:39:33 -0700 | [diff] [blame] | 113 | bool SendRtp(const uint8_t* data, |
| 114 | size_t len, |
| 115 | const PacketOptions& options) override { |
Petter Strandmark | 26bc669 | 2018-05-29 08:43:35 +0200 | [diff] [blame] | 116 | last_options_ = options; |
pkasting@chromium.org | 4591fbd | 2014-11-20 22:28:14 +0000 | [diff] [blame] | 117 | total_bytes_sent_ += len; |
danilchap | 12ba186 | 2016-10-26 02:41:55 -0700 | [diff] [blame] | 118 | sent_packets_.push_back(RtpPacketReceived(&receivers_extensions_)); |
| 119 | EXPECT_TRUE(sent_packets_.back().Parse(data, len)); |
pbos | 2d56668 | 2015-09-28 09:59:31 -0700 | [diff] [blame] | 120 | return true; |
asapersson@webrtc.org | 0b3c35a | 2012-01-16 11:06:31 +0000 | [diff] [blame] | 121 | } |
danilchap | 162abd3 | 2015-12-10 02:39:40 -0800 | [diff] [blame] | 122 | bool SendRtcp(const uint8_t* data, size_t len) override { return false; } |
danilchap | 12ba186 | 2016-10-26 02:41:55 -0700 | [diff] [blame] | 123 | const RtpPacketReceived& last_sent_packet() { return sent_packets_.back(); } |
| 124 | int packets_sent() { return sent_packets_.size(); } |
| 125 | |
pbos@webrtc.org | 72491b9 | 2014-07-10 16:24:54 +0000 | [diff] [blame] | 126 | size_t total_bytes_sent_; |
Petter Strandmark | 26bc669 | 2018-05-29 08:43:35 +0200 | [diff] [blame] | 127 | PacketOptions last_options_; |
danilchap | 12ba186 | 2016-10-26 02:41:55 -0700 | [diff] [blame] | 128 | std::vector<RtpPacketReceived> sent_packets_; |
| 129 | |
| 130 | private: |
| 131 | RtpHeaderExtensionMap receivers_extensions_; |
asapersson@webrtc.org | 0b3c35a | 2012-01-16 11:06:31 +0000 | [diff] [blame] | 132 | }; |
| 133 | |
Elad Alon | 4a87e1c | 2017-10-03 16:11:34 +0200 | [diff] [blame] | 134 | MATCHER_P(SameRtcEventTypeAs, value, "") { |
| 135 | return value == arg->GetType(); |
| 136 | } |
| 137 | |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 138 | struct TestConfig { |
Erik Språng | f5815fa | 2019-08-21 14:27:31 +0200 | [diff] [blame] | 139 | explicit TestConfig(bool with_overhead) : with_overhead(with_overhead) {} |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 140 | bool with_overhead = false; |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 141 | }; |
| 142 | |
| 143 | std::string ToFieldTrialString(TestConfig config) { |
| 144 | std::string field_trials; |
| 145 | if (config.with_overhead) { |
| 146 | field_trials += "WebRTC-SendSideBwe-WithOverhead/Enabled/"; |
| 147 | } |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 148 | return field_trials; |
| 149 | } |
| 150 | |
Erik Språng | aa59eca | 2019-07-24 14:52:55 +0200 | [diff] [blame] | 151 | class MockRtpPacketPacer : public RtpPacketSender { |
sprang | ebbf8a8 | 2015-09-21 15:11:14 -0700 | [diff] [blame] | 152 | public: |
Erik Språng | 59b8654 | 2019-06-23 18:24:46 +0200 | [diff] [blame] | 153 | MockRtpPacketPacer() {} |
| 154 | virtual ~MockRtpPacketPacer() {} |
| 155 | |
Erik Språng | ea55b08 | 2019-10-02 14:57:46 +0200 | [diff] [blame] | 156 | MOCK_METHOD1(EnqueuePackets, |
| 157 | void(std::vector<std::unique_ptr<RtpPacketToSend>>)); |
sprang | ebbf8a8 | 2015-09-21 15:11:14 -0700 | [diff] [blame] | 158 | |
Erik Språng | aa59eca | 2019-07-24 14:52:55 +0200 | [diff] [blame] | 159 | MOCK_METHOD2(CreateProbeCluster, void(int bitrate_bps, int cluster_id)); |
| 160 | |
| 161 | MOCK_METHOD0(Pause, void()); |
| 162 | MOCK_METHOD0(Resume, void()); |
| 163 | MOCK_METHOD1(SetCongestionWindow, |
| 164 | void(absl::optional<int64_t> congestion_window_bytes)); |
| 165 | MOCK_METHOD1(UpdateOutstandingData, void(int64_t outstanding_bytes)); |
| 166 | MOCK_METHOD1(SetAccountForAudioPackets, void(bool account_for_audio)); |
sprang | ebbf8a8 | 2015-09-21 15:11:14 -0700 | [diff] [blame] | 167 | }; |
| 168 | |
Johannes Kron | 4a8a5e7 | 2018-09-26 09:57:48 +0200 | [diff] [blame] | 169 | class MockSendSideDelayObserver : public SendSideDelayObserver { |
| 170 | public: |
Henrik Boström | 9fe1834 | 2019-05-16 18:38:20 +0200 | [diff] [blame] | 171 | MOCK_METHOD4(SendSideDelayUpdated, void(int, int, uint64_t, uint32_t)); |
Johannes Kron | 4a8a5e7 | 2018-09-26 09:57:48 +0200 | [diff] [blame] | 172 | }; |
| 173 | |
asapersson | 35151f3 | 2016-05-02 23:44:01 -0700 | [diff] [blame] | 174 | class MockSendPacketObserver : public SendPacketObserver { |
| 175 | public: |
| 176 | MOCK_METHOD3(OnSendPacket, void(uint16_t, int64_t, uint32_t)); |
| 177 | }; |
| 178 | |
Stefan Holmer | a246cfb | 2016-08-23 17:51:42 +0200 | [diff] [blame] | 179 | class MockTransportFeedbackObserver : public TransportFeedbackObserver { |
| 180 | public: |
Erik Språng | 30a276b | 2019-04-23 12:00:11 +0200 | [diff] [blame] | 181 | MOCK_METHOD1(OnAddPacket, void(const RtpPacketSendInfo&)); |
Stefan Holmer | a246cfb | 2016-08-23 17:51:42 +0200 | [diff] [blame] | 182 | MOCK_METHOD1(OnTransportFeedback, void(const rtcp::TransportFeedback&)); |
| 183 | }; |
| 184 | |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 185 | class MockOverheadObserver : public OverheadObserver { |
| 186 | public: |
| 187 | MOCK_METHOD1(OnOverheadChanged, void(size_t overhead_bytes_per_packet)); |
| 188 | }; |
| 189 | |
Erik Språng | 7ea9b80 | 2019-10-16 19:03:38 +0200 | [diff] [blame] | 190 | class StreamDataTestCallback : public StreamDataCountersCallback { |
| 191 | public: |
| 192 | StreamDataTestCallback() |
| 193 | : StreamDataCountersCallback(), ssrc_(0), counters_() {} |
| 194 | ~StreamDataTestCallback() override = default; |
| 195 | |
| 196 | void DataCountersUpdated(const StreamDataCounters& counters, |
| 197 | uint32_t ssrc) override { |
| 198 | ssrc_ = ssrc; |
| 199 | counters_ = counters; |
| 200 | } |
| 201 | |
| 202 | uint32_t ssrc_; |
| 203 | StreamDataCounters counters_; |
| 204 | |
| 205 | void MatchPacketCounter(const RtpPacketCounter& expected, |
| 206 | const RtpPacketCounter& actual) { |
| 207 | EXPECT_EQ(expected.payload_bytes, actual.payload_bytes); |
| 208 | EXPECT_EQ(expected.header_bytes, actual.header_bytes); |
| 209 | EXPECT_EQ(expected.padding_bytes, actual.padding_bytes); |
| 210 | EXPECT_EQ(expected.packets, actual.packets); |
| 211 | } |
| 212 | |
| 213 | void Matches(uint32_t ssrc, const StreamDataCounters& counters) { |
| 214 | EXPECT_EQ(ssrc, ssrc_); |
| 215 | MatchPacketCounter(counters.transmitted, counters_.transmitted); |
| 216 | MatchPacketCounter(counters.retransmitted, counters_.retransmitted); |
| 217 | EXPECT_EQ(counters.fec.packets, counters_.fec.packets); |
| 218 | } |
| 219 | }; |
| 220 | |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 221 | // Mimics ModuleRtpRtcp::RtpSenderContext. |
| 222 | // TODO(sprang): Split up unit tests and test these components individually |
| 223 | // wherever possible. |
| 224 | struct RtpSenderContext { |
| 225 | explicit RtpSenderContext(const RtpRtcp::Configuration& config) |
| 226 | : packet_history_(config.clock), |
| 227 | packet_sender_(config, &packet_history_), |
| 228 | non_paced_sender_(&packet_sender_), |
| 229 | packet_generator_( |
| 230 | config, |
| 231 | &packet_history_, |
| 232 | config.paced_sender ? config.paced_sender : &non_paced_sender_) {} |
| 233 | RtpPacketHistory packet_history_; |
| 234 | RtpSenderEgress packet_sender_; |
| 235 | RtpSenderEgress::NonPacedPacketSender non_paced_sender_; |
| 236 | RTPSender packet_generator_; |
| 237 | }; |
| 238 | |
| 239 | } // namespace |
| 240 | |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 241 | class RtpSenderTest : public ::testing::TestWithParam<TestConfig> { |
asapersson@webrtc.org | 5249cc8 | 2011-12-16 14:31:37 +0000 | [diff] [blame] | 242 | protected: |
| 243 | RtpSenderTest() |
sprang@webrtc.org | 6811b6e | 2013-12-13 09:46:59 +0000 | [diff] [blame] | 244 | : fake_clock_(kStartTime), |
sprang | cd349d9 | 2016-07-13 09:11:28 -0700 | [diff] [blame] | 245 | retransmission_rate_limiter_(&fake_clock_, 1000), |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 246 | flexfec_sender_(0, |
| 247 | kFlexFecSsrc, |
| 248 | kSsrc, |
| 249 | "", |
| 250 | std::vector<RtpExtension>(), |
| 251 | std::vector<RtpExtensionSize>(), |
| 252 | nullptr, |
| 253 | &fake_clock_), |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 254 | kMarkerBit(true), |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 255 | field_trials_(ToFieldTrialString(GetParam())) {} |
solenberg@webrtc.org | c0352d5 | 2013-05-20 20:55:07 +0000 | [diff] [blame] | 256 | |
Erik Språng | 7b52f10 | 2018-02-07 14:37:37 +0100 | [diff] [blame] | 257 | void SetUp() override { SetUpRtpSender(true, false); } |
Peter Boström | e23e737 | 2015-10-08 11:44:14 +0200 | [diff] [blame] | 258 | |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 259 | RTPSender* rtp_sender() { |
| 260 | RTC_DCHECK(rtp_sender_context_); |
| 261 | return &rtp_sender_context_->packet_generator_; |
| 262 | } |
| 263 | |
| 264 | RtpSenderEgress* rtp_egress() { |
| 265 | RTC_DCHECK(rtp_sender_context_); |
| 266 | return &rtp_sender_context_->packet_sender_; |
| 267 | } |
| 268 | |
Erik Språng | 7b52f10 | 2018-02-07 14:37:37 +0100 | [diff] [blame] | 269 | void SetUpRtpSender(bool pacer, bool populate_network2) { |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 270 | RtpRtcp::Configuration config; |
| 271 | config.clock = &fake_clock_; |
| 272 | config.outgoing_transport = &transport_; |
Erik Språng | 54d5d2c | 2019-08-20 17:22:36 +0200 | [diff] [blame] | 273 | config.local_media_ssrc = kSsrc; |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 274 | config.rtx_send_ssrc = kRtxSsrc; |
| 275 | config.flexfec_sender = &flexfec_sender_; |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 276 | config.event_log = &mock_rtc_event_log_; |
| 277 | config.send_packet_observer = &send_packet_observer_; |
| 278 | config.retransmission_rate_limiter = &retransmission_rate_limiter_; |
| 279 | config.paced_sender = pacer ? &mock_paced_sender_ : nullptr; |
| 280 | config.populate_network2_timestamp = populate_network2; |
Erik Språng | 7ea9b80 | 2019-10-16 19:03:38 +0200 | [diff] [blame] | 281 | config.rtp_stats_callback = &rtp_stats_callback_; |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 282 | rtp_sender_context_ = std::make_unique<RtpSenderContext>(config); |
| 283 | rtp_sender()->SetSequenceNumber(kSeqNum); |
| 284 | rtp_sender()->SetTimestampOffset(0); |
solenberg@webrtc.org | c0352d5 | 2013-05-20 20:55:07 +0000 | [diff] [blame] | 285 | } |
| 286 | |
stefan@webrtc.org | a678a3b | 2013-01-21 07:42:11 +0000 | [diff] [blame] | 287 | SimulatedClock fake_clock_; |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 288 | NiceMock<MockRtcEventLog> mock_rtc_event_log_; |
Erik Språng | 59b8654 | 2019-06-23 18:24:46 +0200 | [diff] [blame] | 289 | MockRtpPacketPacer mock_paced_sender_; |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 290 | StrictMock<MockSendPacketObserver> send_packet_observer_; |
| 291 | StrictMock<MockTransportFeedbackObserver> feedback_observer_; |
sprang | cd349d9 | 2016-07-13 09:11:28 -0700 | [diff] [blame] | 292 | RateLimiter retransmission_rate_limiter_; |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 293 | FlexfecSender flexfec_sender_; |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 294 | |
| 295 | std::unique_ptr<RtpSenderContext> rtp_sender_context_; |
| 296 | |
asapersson@webrtc.org | 0b3c35a | 2012-01-16 11:06:31 +0000 | [diff] [blame] | 297 | LoopbackTransportTest transport_; |
asapersson@webrtc.org | 5249cc8 | 2011-12-16 14:31:37 +0000 | [diff] [blame] | 298 | const bool kMarkerBit; |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 299 | test::ScopedFieldTrials field_trials_; |
Erik Språng | 7ea9b80 | 2019-10-16 19:03:38 +0200 | [diff] [blame] | 300 | StreamDataTestCallback rtp_stats_callback_; |
asapersson@webrtc.org | 5249cc8 | 2011-12-16 14:31:37 +0000 | [diff] [blame] | 301 | |
danilchap | b6f1fb5 | 2016-10-19 06:11:39 -0700 | [diff] [blame] | 302 | std::unique_ptr<RtpPacketToSend> BuildRtpPacket(int payload_type, |
| 303 | bool marker_bit, |
| 304 | uint32_t timestamp, |
| 305 | int64_t capture_time_ms) { |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 306 | auto packet = rtp_sender()->AllocatePacket(); |
danilchap | b6f1fb5 | 2016-10-19 06:11:39 -0700 | [diff] [blame] | 307 | packet->SetPayloadType(payload_type); |
Erik Språng | 60ffc31 | 2019-07-30 22:03:49 +0200 | [diff] [blame] | 308 | packet->set_packet_type(RtpPacketToSend::Type::kVideo); |
danilchap | b6f1fb5 | 2016-10-19 06:11:39 -0700 | [diff] [blame] | 309 | packet->SetMarker(marker_bit); |
| 310 | packet->SetTimestamp(timestamp); |
| 311 | packet->set_capture_time_ms(capture_time_ms); |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 312 | EXPECT_TRUE(rtp_sender()->AssignSequenceNumber(packet.get())); |
danilchap | b6f1fb5 | 2016-10-19 06:11:39 -0700 | [diff] [blame] | 313 | return packet; |
| 314 | } |
| 315 | |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 316 | std::unique_ptr<RtpPacketToSend> SendPacket(int64_t capture_time_ms, |
| 317 | int payload_length) { |
stefan@webrtc.org | 7e9315b | 2013-12-04 10:24:26 +0000 | [diff] [blame] | 318 | uint32_t timestamp = capture_time_ms * 90; |
danilchap | b6f1fb5 | 2016-10-19 06:11:39 -0700 | [diff] [blame] | 319 | auto packet = |
| 320 | BuildRtpPacket(kPayload, kMarkerBit, timestamp, capture_time_ms); |
| 321 | packet->AllocatePayload(payload_length); |
Erik Språng | 70768f4 | 2019-08-27 18:16:26 +0200 | [diff] [blame] | 322 | packet->set_allow_retransmission(true); |
stefan@webrtc.org | 7e9315b | 2013-12-04 10:24:26 +0000 | [diff] [blame] | 323 | |
| 324 | // Packet should be stored in a send bucket. |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 325 | EXPECT_TRUE(rtp_sender()->SendToNetwork( |
| 326 | std::make_unique<RtpPacketToSend>(*packet))); |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 327 | return packet; |
stefan@webrtc.org | 7e9315b | 2013-12-04 10:24:26 +0000 | [diff] [blame] | 328 | } |
asapersson | 35151f3 | 2016-05-02 23:44:01 -0700 | [diff] [blame] | 329 | |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 330 | std::unique_ptr<RtpPacketToSend> SendGenericPacket() { |
asapersson | 35151f3 | 2016-05-02 23:44:01 -0700 | [diff] [blame] | 331 | const int64_t kCaptureTimeMs = fake_clock_.TimeInMilliseconds(); |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 332 | return SendPacket(kCaptureTimeMs, sizeof(kPayloadData)); |
asapersson | 35151f3 | 2016-05-02 23:44:01 -0700 | [diff] [blame] | 333 | } |
Steve Anton | 2bac7da | 2019-07-21 15:04:21 -0400 | [diff] [blame] | 334 | |
Erik Språng | 4208a13 | 2019-08-26 08:58:45 +0200 | [diff] [blame] | 335 | size_t GenerateAndSendPadding(size_t target_size_bytes) { |
| 336 | size_t generated_bytes = 0; |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 337 | for (auto& packet : |
| 338 | rtp_sender()->GeneratePadding(target_size_bytes, true)) { |
Erik Språng | 4208a13 | 2019-08-26 08:58:45 +0200 | [diff] [blame] | 339 | generated_bytes += packet->payload_size() + packet->padding_size(); |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 340 | rtp_egress()->SendPacket(packet.get(), PacedPacketInfo()); |
Erik Språng | 4208a13 | 2019-08-26 08:58:45 +0200 | [diff] [blame] | 341 | } |
| 342 | return generated_bytes; |
| 343 | } |
| 344 | |
Steve Anton | 2bac7da | 2019-07-21 15:04:21 -0400 | [diff] [blame] | 345 | // The following are helpers for configuring the RTPSender. They must be |
| 346 | // called before sending any packets. |
| 347 | |
| 348 | // Enable the retransmission stream with sizable packet storage. |
| 349 | void EnableRtx() { |
| 350 | // RTX needs to be able to read the source packets from the packet store. |
| 351 | // Pick a number of packets to store big enough for any unit test. |
| 352 | constexpr uint16_t kNumberOfPacketsToStore = 100; |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 353 | rtp_sender_context_->packet_history_.SetStorePacketsStatus( |
| 354 | RtpPacketHistory::StorageMode::kStoreAndCull, kNumberOfPacketsToStore); |
| 355 | rtp_sender()->SetRtxPayloadType(kRtxPayload, kPayload); |
| 356 | rtp_sender()->SetRtxStatus(kRtxRetransmitted | kRtxRedundantPayloads); |
Steve Anton | 2bac7da | 2019-07-21 15:04:21 -0400 | [diff] [blame] | 357 | } |
| 358 | |
| 359 | // Enable sending of the MID header extension for both the primary SSRC and |
| 360 | // the RTX SSRC. |
| 361 | void EnableMidSending(const std::string& mid) { |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 362 | rtp_sender()->RegisterRtpHeaderExtension(kRtpExtensionMid, kMidExtensionId); |
| 363 | rtp_sender()->SetMid(mid); |
Steve Anton | 2bac7da | 2019-07-21 15:04:21 -0400 | [diff] [blame] | 364 | } |
| 365 | |
| 366 | // Enable sending of the RSID header extension for the primary SSRC and the |
| 367 | // RRSID header extension for the RTX SSRC. |
| 368 | void EnableRidSending(const std::string& rid) { |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 369 | rtp_sender()->RegisterRtpHeaderExtension(kRtpExtensionRtpStreamId, |
| 370 | kRidExtensionId); |
| 371 | rtp_sender()->RegisterRtpHeaderExtension(kRtpExtensionRepairedRtpStreamId, |
| 372 | kRepairedRidExtensionId); |
| 373 | rtp_sender()->SetRid(rid); |
Steve Anton | 2bac7da | 2019-07-21 15:04:21 -0400 | [diff] [blame] | 374 | } |
asapersson@webrtc.org | 5249cc8 | 2011-12-16 14:31:37 +0000 | [diff] [blame] | 375 | }; |
| 376 | |
Peter Boström | e23e737 | 2015-10-08 11:44:14 +0200 | [diff] [blame] | 377 | // TODO(pbos): Move tests over from WithoutPacer to RtpSenderTest as this is our |
| 378 | // default code path. |
| 379 | class RtpSenderTestWithoutPacer : public RtpSenderTest { |
| 380 | public: |
Erik Språng | 7b52f10 | 2018-02-07 14:37:37 +0100 | [diff] [blame] | 381 | void SetUp() override { SetUpRtpSender(false, false); } |
Peter Boström | e23e737 | 2015-10-08 11:44:14 +0200 | [diff] [blame] | 382 | }; |
| 383 | |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 384 | TEST_P(RtpSenderTestWithoutPacer, AllocatePacketSetCsrc) { |
Danil Chapovalov | 5e57b17 | 2016-09-02 19:15:59 +0200 | [diff] [blame] | 385 | // Configure rtp_sender with csrc. |
| 386 | std::vector<uint32_t> csrcs; |
| 387 | csrcs.push_back(0x23456789); |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 388 | rtp_sender()->SetCsrcs(csrcs); |
Danil Chapovalov | 5e57b17 | 2016-09-02 19:15:59 +0200 | [diff] [blame] | 389 | |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 390 | auto packet = rtp_sender()->AllocatePacket(); |
Danil Chapovalov | 5e57b17 | 2016-09-02 19:15:59 +0200 | [diff] [blame] | 391 | |
| 392 | ASSERT_TRUE(packet); |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 393 | EXPECT_EQ(rtp_sender()->SSRC(), packet->Ssrc()); |
Danil Chapovalov | 5e57b17 | 2016-09-02 19:15:59 +0200 | [diff] [blame] | 394 | EXPECT_EQ(csrcs, packet->Csrcs()); |
| 395 | } |
| 396 | |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 397 | TEST_P(RtpSenderTestWithoutPacer, AllocatePacketReserveExtensions) { |
Danil Chapovalov | 5e57b17 | 2016-09-02 19:15:59 +0200 | [diff] [blame] | 398 | // Configure rtp_sender with extensions. |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 399 | ASSERT_EQ(0, rtp_sender()->RegisterRtpHeaderExtension( |
Danil Chapovalov | 5e57b17 | 2016-09-02 19:15:59 +0200 | [diff] [blame] | 400 | kRtpExtensionTransmissionTimeOffset, |
| 401 | kTransmissionTimeOffsetExtensionId)); |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 402 | ASSERT_EQ(0, |
| 403 | rtp_sender()->RegisterRtpHeaderExtension( |
| 404 | kRtpExtensionAbsoluteSendTime, kAbsoluteSendTimeExtensionId)); |
| 405 | ASSERT_EQ(0, rtp_sender()->RegisterRtpHeaderExtension( |
| 406 | kRtpExtensionAudioLevel, kAudioLevelExtensionId)); |
| 407 | ASSERT_EQ(0, rtp_sender()->RegisterRtpHeaderExtension( |
Danil Chapovalov | 5e57b17 | 2016-09-02 19:15:59 +0200 | [diff] [blame] | 408 | kRtpExtensionTransportSequenceNumber, |
| 409 | kTransportSequenceNumberExtensionId)); |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 410 | ASSERT_EQ(0, rtp_sender()->RegisterRtpHeaderExtension( |
Danil Chapovalov | 5e57b17 | 2016-09-02 19:15:59 +0200 | [diff] [blame] | 411 | kRtpExtensionVideoRotation, kVideoRotationExtensionId)); |
| 412 | |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 413 | auto packet = rtp_sender()->AllocatePacket(); |
Danil Chapovalov | 5e57b17 | 2016-09-02 19:15:59 +0200 | [diff] [blame] | 414 | |
| 415 | ASSERT_TRUE(packet); |
| 416 | // Preallocate BWE extensions RtpSender set itself. |
| 417 | EXPECT_TRUE(packet->HasExtension<TransmissionOffset>()); |
| 418 | EXPECT_TRUE(packet->HasExtension<AbsoluteSendTime>()); |
| 419 | EXPECT_TRUE(packet->HasExtension<TransportSequenceNumber>()); |
| 420 | // Do not allocate media specific extensions. |
| 421 | EXPECT_FALSE(packet->HasExtension<AudioLevel>()); |
| 422 | EXPECT_FALSE(packet->HasExtension<VideoOrientation>()); |
| 423 | } |
| 424 | |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 425 | TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberAdvanceSequenceNumber) { |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 426 | auto packet = rtp_sender()->AllocatePacket(); |
Danil Chapovalov | 5e57b17 | 2016-09-02 19:15:59 +0200 | [diff] [blame] | 427 | ASSERT_TRUE(packet); |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 428 | const uint16_t sequence_number = rtp_sender()->SequenceNumber(); |
Danil Chapovalov | 5e57b17 | 2016-09-02 19:15:59 +0200 | [diff] [blame] | 429 | |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 430 | EXPECT_TRUE(rtp_sender()->AssignSequenceNumber(packet.get())); |
Danil Chapovalov | 5e57b17 | 2016-09-02 19:15:59 +0200 | [diff] [blame] | 431 | |
| 432 | EXPECT_EQ(sequence_number, packet->SequenceNumber()); |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 433 | EXPECT_EQ(sequence_number + 1, rtp_sender()->SequenceNumber()); |
Danil Chapovalov | 5e57b17 | 2016-09-02 19:15:59 +0200 | [diff] [blame] | 434 | } |
| 435 | |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 436 | TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberFailsOnNotSending) { |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 437 | auto packet = rtp_sender()->AllocatePacket(); |
Danil Chapovalov | 5e57b17 | 2016-09-02 19:15:59 +0200 | [diff] [blame] | 438 | ASSERT_TRUE(packet); |
| 439 | |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 440 | rtp_sender()->SetSendingMediaStatus(false); |
| 441 | EXPECT_FALSE(rtp_sender()->AssignSequenceNumber(packet.get())); |
Danil Chapovalov | 5e57b17 | 2016-09-02 19:15:59 +0200 | [diff] [blame] | 442 | } |
| 443 | |
Danil Chapovalov | b3179c7 | 2018-03-22 10:13:07 +0100 | [diff] [blame] | 444 | TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberMayAllowPaddingOnVideo) { |
Danil Chapovalov | 5e57b17 | 2016-09-02 19:15:59 +0200 | [diff] [blame] | 445 | constexpr size_t kPaddingSize = 100; |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 446 | auto packet = rtp_sender()->AllocatePacket(); |
Danil Chapovalov | 5e57b17 | 2016-09-02 19:15:59 +0200 | [diff] [blame] | 447 | ASSERT_TRUE(packet); |
| 448 | |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 449 | ASSERT_TRUE(rtp_sender()->GeneratePadding(kPaddingSize, true).empty()); |
Danil Chapovalov | 5e57b17 | 2016-09-02 19:15:59 +0200 | [diff] [blame] | 450 | packet->SetMarker(false); |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 451 | ASSERT_TRUE(rtp_sender()->AssignSequenceNumber(packet.get())); |
Danil Chapovalov | b3179c7 | 2018-03-22 10:13:07 +0100 | [diff] [blame] | 452 | // Packet without marker bit doesn't allow padding on video stream. |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 453 | ASSERT_TRUE(rtp_sender()->GeneratePadding(kPaddingSize, true).empty()); |
Danil Chapovalov | 5e57b17 | 2016-09-02 19:15:59 +0200 | [diff] [blame] | 454 | |
| 455 | packet->SetMarker(true); |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 456 | ASSERT_TRUE(rtp_sender()->AssignSequenceNumber(packet.get())); |
Danil Chapovalov | 5e57b17 | 2016-09-02 19:15:59 +0200 | [diff] [blame] | 457 | // Packet with marker bit allows send padding. |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 458 | ASSERT_FALSE(rtp_sender()->GeneratePadding(kPaddingSize, true).empty()); |
Danil Chapovalov | 5e57b17 | 2016-09-02 19:15:59 +0200 | [diff] [blame] | 459 | } |
| 460 | |
Danil Chapovalov | b3179c7 | 2018-03-22 10:13:07 +0100 | [diff] [blame] | 461 | TEST_P(RtpSenderTest, AssignSequenceNumberAllowsPaddingOnAudio) { |
| 462 | MockTransport transport; |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 463 | RtpRtcp::Configuration config; |
| 464 | config.audio = true; |
| 465 | config.clock = &fake_clock_; |
| 466 | config.outgoing_transport = &transport; |
| 467 | config.paced_sender = &mock_paced_sender_; |
Erik Språng | 54d5d2c | 2019-08-20 17:22:36 +0200 | [diff] [blame] | 468 | config.local_media_ssrc = kSsrc; |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 469 | config.event_log = &mock_rtc_event_log_; |
| 470 | config.retransmission_rate_limiter = &retransmission_rate_limiter_; |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 471 | rtp_sender_context_ = std::make_unique<RtpSenderContext>(config); |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 472 | |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 473 | rtp_sender()->SetTimestampOffset(0); |
Danil Chapovalov | b3179c7 | 2018-03-22 10:13:07 +0100 | [diff] [blame] | 474 | |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 475 | std::unique_ptr<RtpPacketToSend> audio_packet = |
| 476 | rtp_sender()->AllocatePacket(); |
Danil Chapovalov | b3179c7 | 2018-03-22 10:13:07 +0100 | [diff] [blame] | 477 | // Padding on audio stream allowed regardless of marker in the last packet. |
| 478 | audio_packet->SetMarker(false); |
| 479 | audio_packet->SetPayloadType(kPayload); |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 480 | rtp_sender()->AssignSequenceNumber(audio_packet.get()); |
Danil Chapovalov | b3179c7 | 2018-03-22 10:13:07 +0100 | [diff] [blame] | 481 | |
| 482 | const size_t kPaddingSize = 59; |
| 483 | EXPECT_CALL(transport, SendRtp(_, kPaddingSize + kRtpHeaderSize, _)) |
Erik Språng | 214f543 | 2019-06-20 15:09:58 +0200 | [diff] [blame] | 484 | .WillOnce(Return(true)); |
Erik Språng | 4208a13 | 2019-08-26 08:58:45 +0200 | [diff] [blame] | 485 | EXPECT_EQ(kPaddingSize, GenerateAndSendPadding(kPaddingSize)); |
Danil Chapovalov | b3179c7 | 2018-03-22 10:13:07 +0100 | [diff] [blame] | 486 | |
| 487 | // Requested padding size is too small, will send a larger one. |
| 488 | const size_t kMinPaddingSize = 50; |
| 489 | EXPECT_CALL(transport, SendRtp(_, kMinPaddingSize + kRtpHeaderSize, _)) |
Erik Språng | 214f543 | 2019-06-20 15:09:58 +0200 | [diff] [blame] | 490 | .WillOnce(Return(true)); |
Erik Språng | 4208a13 | 2019-08-26 08:58:45 +0200 | [diff] [blame] | 491 | EXPECT_EQ(kMinPaddingSize, GenerateAndSendPadding(kMinPaddingSize - 5)); |
Danil Chapovalov | b3179c7 | 2018-03-22 10:13:07 +0100 | [diff] [blame] | 492 | } |
| 493 | |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 494 | TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberSetPaddingTimestamps) { |
Danil Chapovalov | 5e57b17 | 2016-09-02 19:15:59 +0200 | [diff] [blame] | 495 | constexpr size_t kPaddingSize = 100; |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 496 | auto packet = rtp_sender()->AllocatePacket(); |
Danil Chapovalov | 5e57b17 | 2016-09-02 19:15:59 +0200 | [diff] [blame] | 497 | ASSERT_TRUE(packet); |
| 498 | packet->SetMarker(true); |
| 499 | packet->SetTimestamp(kTimestamp); |
| 500 | |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 501 | ASSERT_TRUE(rtp_sender()->AssignSequenceNumber(packet.get())); |
| 502 | auto padding_packets = rtp_sender()->GeneratePadding(kPaddingSize, true); |
Danil Chapovalov | 5e57b17 | 2016-09-02 19:15:59 +0200 | [diff] [blame] | 503 | |
Erik Språng | 4208a13 | 2019-08-26 08:58:45 +0200 | [diff] [blame] | 504 | ASSERT_EQ(1u, padding_packets.size()); |
danilchap | 12ba186 | 2016-10-26 02:41:55 -0700 | [diff] [blame] | 505 | // Verify padding packet timestamp. |
Erik Språng | 4208a13 | 2019-08-26 08:58:45 +0200 | [diff] [blame] | 506 | EXPECT_EQ(kTimestamp, padding_packets[0]->Timestamp()); |
Danil Chapovalov | 5e57b17 | 2016-09-02 19:15:59 +0200 | [diff] [blame] | 507 | } |
| 508 | |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 509 | TEST_P(RtpSenderTestWithoutPacer, |
| 510 | TransportFeedbackObserverGetsCorrectByteCount) { |
| 511 | constexpr int kRtpOverheadBytesPerPacket = 12 + 8; |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 512 | NiceMock<MockOverheadObserver> mock_overhead_observer; |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 513 | |
| 514 | RtpRtcp::Configuration config; |
| 515 | config.clock = &fake_clock_; |
| 516 | config.outgoing_transport = &transport_; |
Erik Språng | 54d5d2c | 2019-08-20 17:22:36 +0200 | [diff] [blame] | 517 | config.local_media_ssrc = kSsrc; |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 518 | config.transport_feedback_callback = &feedback_observer_; |
| 519 | config.event_log = &mock_rtc_event_log_; |
| 520 | config.retransmission_rate_limiter = &retransmission_rate_limiter_; |
| 521 | config.overhead_observer = &mock_overhead_observer; |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 522 | rtp_sender_context_ = std::make_unique<RtpSenderContext>(config); |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 523 | |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 524 | EXPECT_EQ(0, rtp_sender()->RegisterRtpHeaderExtension( |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 525 | kRtpExtensionTransportSequenceNumber, |
| 526 | kTransportSequenceNumberExtensionId)); |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 527 | |
| 528 | const size_t expected_bytes = |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 529 | GetParam().with_overhead |
| 530 | ? sizeof(kPayloadData) + kRtpOverheadBytesPerPacket |
| 531 | : sizeof(kPayloadData); |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 532 | |
| 533 | EXPECT_CALL(feedback_observer_, |
Erik Språng | 30a276b | 2019-04-23 12:00:11 +0200 | [diff] [blame] | 534 | OnAddPacket(AllOf( |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 535 | Field(&RtpPacketSendInfo::ssrc, rtp_sender()->SSRC()), |
Erik Språng | 30a276b | 2019-04-23 12:00:11 +0200 | [diff] [blame] | 536 | Field(&RtpPacketSendInfo::transport_sequence_number, |
| 537 | kTransportSequenceNumber), |
| 538 | Field(&RtpPacketSendInfo::rtp_sequence_number, |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 539 | rtp_sender()->SequenceNumber()), |
Erik Språng | 30a276b | 2019-04-23 12:00:11 +0200 | [diff] [blame] | 540 | Field(&RtpPacketSendInfo::length, expected_bytes), |
| 541 | Field(&RtpPacketSendInfo::pacing_info, PacedPacketInfo())))) |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 542 | .Times(1); |
| 543 | EXPECT_CALL(mock_overhead_observer, |
| 544 | OnOverheadChanged(kRtpOverheadBytesPerPacket)) |
| 545 | .Times(1); |
Niels Möller | e7b9e6b | 2019-02-06 18:23:44 +0100 | [diff] [blame] | 546 | SendGenericPacket(); |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 547 | } |
| 548 | |
| 549 | TEST_P(RtpSenderTestWithoutPacer, SendsPacketsWithTransportSequenceNumber) { |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 550 | RtpRtcp::Configuration config; |
| 551 | config.clock = &fake_clock_; |
| 552 | config.outgoing_transport = &transport_; |
Erik Språng | 54d5d2c | 2019-08-20 17:22:36 +0200 | [diff] [blame] | 553 | config.local_media_ssrc = kSsrc; |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 554 | config.transport_feedback_callback = &feedback_observer_; |
| 555 | config.event_log = &mock_rtc_event_log_; |
| 556 | config.send_packet_observer = &send_packet_observer_; |
| 557 | config.retransmission_rate_limiter = &retransmission_rate_limiter_; |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 558 | rtp_sender_context_ = std::make_unique<RtpSenderContext>(config); |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 559 | |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 560 | EXPECT_EQ(0, rtp_sender()->RegisterRtpHeaderExtension( |
Stefan Holmer | f5dca48 | 2016-01-27 12:58:51 +0100 | [diff] [blame] | 561 | kRtpExtensionTransportSequenceNumber, |
| 562 | kTransportSequenceNumberExtensionId)); |
| 563 | |
asapersson | 35151f3 | 2016-05-02 23:44:01 -0700 | [diff] [blame] | 564 | EXPECT_CALL(send_packet_observer_, |
| 565 | OnSendPacket(kTransportSequenceNumber, _, _)) |
| 566 | .Times(1); |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 567 | |
| 568 | EXPECT_CALL(feedback_observer_, |
Erik Språng | 30a276b | 2019-04-23 12:00:11 +0200 | [diff] [blame] | 569 | OnAddPacket(AllOf( |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 570 | Field(&RtpPacketSendInfo::ssrc, rtp_sender()->SSRC()), |
Erik Språng | 30a276b | 2019-04-23 12:00:11 +0200 | [diff] [blame] | 571 | Field(&RtpPacketSendInfo::transport_sequence_number, |
| 572 | kTransportSequenceNumber), |
| 573 | Field(&RtpPacketSendInfo::rtp_sequence_number, |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 574 | rtp_sender()->SequenceNumber()), |
Erik Språng | 30a276b | 2019-04-23 12:00:11 +0200 | [diff] [blame] | 575 | Field(&RtpPacketSendInfo::pacing_info, PacedPacketInfo())))) |
Stefan Holmer | a246cfb | 2016-08-23 17:51:42 +0200 | [diff] [blame] | 576 | .Times(1); |
asapersson | 35151f3 | 2016-05-02 23:44:01 -0700 | [diff] [blame] | 577 | |
Niels Möller | e7b9e6b | 2019-02-06 18:23:44 +0100 | [diff] [blame] | 578 | SendGenericPacket(); |
Stefan Holmer | f5dca48 | 2016-01-27 12:58:51 +0100 | [diff] [blame] | 579 | |
danilchap | 12ba186 | 2016-10-26 02:41:55 -0700 | [diff] [blame] | 580 | const auto& packet = transport_.last_sent_packet(); |
| 581 | uint16_t transport_seq_no; |
| 582 | ASSERT_TRUE(packet.GetExtension<TransportSequenceNumber>(&transport_seq_no)); |
| 583 | EXPECT_EQ(kTransportSequenceNumber, transport_seq_no); |
Petter Strandmark | 26bc669 | 2018-05-29 08:43:35 +0200 | [diff] [blame] | 584 | EXPECT_EQ(transport_.last_options_.packet_id, transport_seq_no); |
Sebastian Jansson | 1bca65b | 2018-10-10 09:58:08 +0200 | [diff] [blame] | 585 | EXPECT_TRUE(transport_.last_options_.included_in_allocation); |
Petter Strandmark | 26bc669 | 2018-05-29 08:43:35 +0200 | [diff] [blame] | 586 | } |
| 587 | |
| 588 | TEST_P(RtpSenderTestWithoutPacer, PacketOptionsNoRetransmission) { |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 589 | RtpRtcp::Configuration config; |
| 590 | config.clock = &fake_clock_; |
| 591 | config.outgoing_transport = &transport_; |
Erik Språng | 54d5d2c | 2019-08-20 17:22:36 +0200 | [diff] [blame] | 592 | config.local_media_ssrc = kSsrc; |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 593 | config.transport_feedback_callback = &feedback_observer_; |
| 594 | config.event_log = &mock_rtc_event_log_; |
| 595 | config.send_packet_observer = &send_packet_observer_; |
| 596 | config.retransmission_rate_limiter = &retransmission_rate_limiter_; |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 597 | rtp_sender_context_ = std::make_unique<RtpSenderContext>(config); |
Petter Strandmark | 26bc669 | 2018-05-29 08:43:35 +0200 | [diff] [blame] | 598 | |
Niels Möller | e7b9e6b | 2019-02-06 18:23:44 +0100 | [diff] [blame] | 599 | SendGenericPacket(); |
Petter Strandmark | 26bc669 | 2018-05-29 08:43:35 +0200 | [diff] [blame] | 600 | |
| 601 | EXPECT_FALSE(transport_.last_options_.is_retransmit); |
Stefan Holmer | f5dca48 | 2016-01-27 12:58:51 +0100 | [diff] [blame] | 602 | } |
| 603 | |
Sebastian Jansson | 1bca65b | 2018-10-10 09:58:08 +0200 | [diff] [blame] | 604 | TEST_P(RtpSenderTestWithoutPacer, |
| 605 | SetsIncludedInFeedbackWhenTransportSequenceNumberExtensionIsRegistered) { |
| 606 | SetUpRtpSender(false, false); |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 607 | rtp_sender()->RegisterRtpHeaderExtension(kRtpExtensionTransportSequenceNumber, |
| 608 | kTransportSequenceNumberExtensionId); |
Sebastian Jansson | 1bca65b | 2018-10-10 09:58:08 +0200 | [diff] [blame] | 609 | EXPECT_CALL(send_packet_observer_, OnSendPacket).Times(1); |
Niels Möller | e7b9e6b | 2019-02-06 18:23:44 +0100 | [diff] [blame] | 610 | SendGenericPacket(); |
Sebastian Jansson | 1bca65b | 2018-10-10 09:58:08 +0200 | [diff] [blame] | 611 | EXPECT_TRUE(transport_.last_options_.included_in_feedback); |
| 612 | } |
| 613 | |
| 614 | TEST_P( |
| 615 | RtpSenderTestWithoutPacer, |
| 616 | SetsIncludedInAllocationWhenTransportSequenceNumberExtensionIsRegistered) { |
| 617 | SetUpRtpSender(false, false); |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 618 | rtp_sender()->RegisterRtpHeaderExtension(kRtpExtensionTransportSequenceNumber, |
| 619 | kTransportSequenceNumberExtensionId); |
Sebastian Jansson | 1bca65b | 2018-10-10 09:58:08 +0200 | [diff] [blame] | 620 | EXPECT_CALL(send_packet_observer_, OnSendPacket).Times(1); |
Niels Möller | e7b9e6b | 2019-02-06 18:23:44 +0100 | [diff] [blame] | 621 | SendGenericPacket(); |
Sebastian Jansson | 1bca65b | 2018-10-10 09:58:08 +0200 | [diff] [blame] | 622 | EXPECT_TRUE(transport_.last_options_.included_in_allocation); |
| 623 | } |
| 624 | |
| 625 | TEST_P(RtpSenderTestWithoutPacer, |
| 626 | SetsIncludedInAllocationWhenForcedAsPartOfAllocation) { |
| 627 | SetUpRtpSender(false, false); |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 628 | rtp_egress()->ForceIncludeSendPacketsInAllocation(true); |
Niels Möller | e7b9e6b | 2019-02-06 18:23:44 +0100 | [diff] [blame] | 629 | SendGenericPacket(); |
Sebastian Jansson | 1bca65b | 2018-10-10 09:58:08 +0200 | [diff] [blame] | 630 | EXPECT_FALSE(transport_.last_options_.included_in_feedback); |
| 631 | EXPECT_TRUE(transport_.last_options_.included_in_allocation); |
| 632 | } |
| 633 | |
| 634 | TEST_P(RtpSenderTestWithoutPacer, DoesnSetIncludedInAllocationByDefault) { |
| 635 | SetUpRtpSender(false, false); |
Niels Möller | e7b9e6b | 2019-02-06 18:23:44 +0100 | [diff] [blame] | 636 | SendGenericPacket(); |
Sebastian Jansson | 1bca65b | 2018-10-10 09:58:08 +0200 | [diff] [blame] | 637 | EXPECT_FALSE(transport_.last_options_.included_in_feedback); |
| 638 | EXPECT_FALSE(transport_.last_options_.included_in_allocation); |
stefan | a23fc62 | 2016-07-28 07:56:38 -0700 | [diff] [blame] | 639 | } |
asapersson | 35151f3 | 2016-05-02 23:44:01 -0700 | [diff] [blame] | 640 | |
Johannes Kron | 4a8a5e7 | 2018-09-26 09:57:48 +0200 | [diff] [blame] | 641 | TEST_P(RtpSenderTestWithoutPacer, OnSendSideDelayUpdated) { |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 642 | StrictMock<MockSendSideDelayObserver> send_side_delay_observer_; |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 643 | |
| 644 | RtpRtcp::Configuration config; |
| 645 | config.clock = &fake_clock_; |
| 646 | config.outgoing_transport = &transport_; |
Erik Språng | 54d5d2c | 2019-08-20 17:22:36 +0200 | [diff] [blame] | 647 | config.local_media_ssrc = kSsrc; |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 648 | config.send_side_delay_observer = &send_side_delay_observer_; |
| 649 | config.event_log = &mock_rtc_event_log_; |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 650 | rtp_sender_context_ = std::make_unique<RtpSenderContext>(config); |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 651 | |
Niels Möller | 5fe9510 | 2019-03-04 16:49:25 +0100 | [diff] [blame] | 652 | PlayoutDelayOracle playout_delay_oracle; |
Erik Språng | dc34a25 | 2019-10-04 15:17:29 +0200 | [diff] [blame] | 653 | FieldTrialBasedConfig field_trials; |
| 654 | RTPSenderVideo::Config video_config; |
| 655 | video_config.clock = &fake_clock_; |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 656 | video_config.rtp_sender = rtp_sender(); |
Erik Språng | dc34a25 | 2019-10-04 15:17:29 +0200 | [diff] [blame] | 657 | video_config.playout_delay_oracle = &playout_delay_oracle; |
| 658 | video_config.field_trials = &field_trials; |
| 659 | RTPSenderVideo rtp_sender_video(video_config); |
Johannes Kron | 4a8a5e7 | 2018-09-26 09:57:48 +0200 | [diff] [blame] | 660 | |
| 661 | const uint8_t kPayloadType = 127; |
Erik Språng | 6cf554e | 2019-10-02 20:55:39 +0200 | [diff] [blame] | 662 | const absl::optional<VideoCodecType> kCodecType = |
| 663 | VideoCodecType::kVideoCodecGeneric; |
Niels Möller | 59ab1cf | 2019-02-06 22:48:11 +0100 | [diff] [blame] | 664 | |
| 665 | const uint32_t kCaptureTimeMsToRtpTimestamp = 90; // 90 kHz clock |
Johannes Kron | 4a8a5e7 | 2018-09-26 09:57:48 +0200 | [diff] [blame] | 666 | RTPVideoHeader video_header; |
Johannes Kron | 4a8a5e7 | 2018-09-26 09:57:48 +0200 | [diff] [blame] | 667 | |
Henrik Boström | 9fe1834 | 2019-05-16 18:38:20 +0200 | [diff] [blame] | 668 | // Send packet with 10 ms send-side delay. The average, max and total should |
| 669 | // be 10 ms. |
| 670 | EXPECT_CALL(send_side_delay_observer_, |
| 671 | SendSideDelayUpdated(10, 10, 10, kSsrc)) |
Johannes Kron | 4a8a5e7 | 2018-09-26 09:57:48 +0200 | [diff] [blame] | 672 | .Times(1); |
| 673 | int64_t capture_time_ms = fake_clock_.TimeInMilliseconds(); |
| 674 | fake_clock_.AdvanceTimeMilliseconds(10); |
Danil Chapovalov | 51bf200 | 2019-10-11 10:53:27 +0200 | [diff] [blame] | 675 | video_header.frame_type = VideoFrameType::kVideoFrameKey; |
Niels Möller | 59ab1cf | 2019-02-06 22:48:11 +0100 | [diff] [blame] | 676 | EXPECT_TRUE(rtp_sender_video.SendVideo( |
Danil Chapovalov | 51bf200 | 2019-10-11 10:53:27 +0200 | [diff] [blame] | 677 | kPayloadType, kCodecType, capture_time_ms * kCaptureTimeMsToRtpTimestamp, |
| 678 | capture_time_ms, kPayloadData, nullptr, video_header, |
Johannes Kron | 4a8a5e7 | 2018-09-26 09:57:48 +0200 | [diff] [blame] | 679 | kDefaultExpectedRetransmissionTimeMs)); |
| 680 | |
Henrik Boström | 9fe1834 | 2019-05-16 18:38:20 +0200 | [diff] [blame] | 681 | // Send another packet with 20 ms delay. The average, max and total should be |
| 682 | // 15, 20 and 30 ms respectively. |
| 683 | EXPECT_CALL(send_side_delay_observer_, |
| 684 | SendSideDelayUpdated(15, 20, 30, kSsrc)) |
Johannes Kron | 4a8a5e7 | 2018-09-26 09:57:48 +0200 | [diff] [blame] | 685 | .Times(1); |
| 686 | fake_clock_.AdvanceTimeMilliseconds(10); |
Danil Chapovalov | 51bf200 | 2019-10-11 10:53:27 +0200 | [diff] [blame] | 687 | video_header.frame_type = VideoFrameType::kVideoFrameKey; |
Niels Möller | 59ab1cf | 2019-02-06 22:48:11 +0100 | [diff] [blame] | 688 | EXPECT_TRUE(rtp_sender_video.SendVideo( |
Danil Chapovalov | 51bf200 | 2019-10-11 10:53:27 +0200 | [diff] [blame] | 689 | kPayloadType, kCodecType, capture_time_ms * kCaptureTimeMsToRtpTimestamp, |
| 690 | capture_time_ms, kPayloadData, nullptr, video_header, |
Johannes Kron | 4a8a5e7 | 2018-09-26 09:57:48 +0200 | [diff] [blame] | 691 | kDefaultExpectedRetransmissionTimeMs)); |
| 692 | |
| 693 | // Send another packet at the same time, which replaces the last packet. |
| 694 | // Since this packet has 0 ms delay, the average is now 5 ms and max is 10 ms. |
Henrik Boström | 9fe1834 | 2019-05-16 18:38:20 +0200 | [diff] [blame] | 695 | // The total counter stays the same though. |
Johannes Kron | 4a8a5e7 | 2018-09-26 09:57:48 +0200 | [diff] [blame] | 696 | // TODO(terelius): Is is not clear that this is the right behavior. |
Henrik Boström | 9fe1834 | 2019-05-16 18:38:20 +0200 | [diff] [blame] | 697 | EXPECT_CALL(send_side_delay_observer_, SendSideDelayUpdated(5, 10, 30, kSsrc)) |
Johannes Kron | 4a8a5e7 | 2018-09-26 09:57:48 +0200 | [diff] [blame] | 698 | .Times(1); |
| 699 | capture_time_ms = fake_clock_.TimeInMilliseconds(); |
Danil Chapovalov | 51bf200 | 2019-10-11 10:53:27 +0200 | [diff] [blame] | 700 | video_header.frame_type = VideoFrameType::kVideoFrameKey; |
Niels Möller | 59ab1cf | 2019-02-06 22:48:11 +0100 | [diff] [blame] | 701 | EXPECT_TRUE(rtp_sender_video.SendVideo( |
Danil Chapovalov | 51bf200 | 2019-10-11 10:53:27 +0200 | [diff] [blame] | 702 | kPayloadType, kCodecType, capture_time_ms * kCaptureTimeMsToRtpTimestamp, |
| 703 | capture_time_ms, kPayloadData, nullptr, video_header, |
Johannes Kron | 4a8a5e7 | 2018-09-26 09:57:48 +0200 | [diff] [blame] | 704 | kDefaultExpectedRetransmissionTimeMs)); |
| 705 | |
| 706 | // Send a packet 1 second later. The earlier packets should have timed |
Henrik Boström | 9fe1834 | 2019-05-16 18:38:20 +0200 | [diff] [blame] | 707 | // out, so both max and average should be the delay of this packet. The total |
| 708 | // keeps increasing. |
Johannes Kron | 4a8a5e7 | 2018-09-26 09:57:48 +0200 | [diff] [blame] | 709 | fake_clock_.AdvanceTimeMilliseconds(1000); |
| 710 | capture_time_ms = fake_clock_.TimeInMilliseconds(); |
| 711 | fake_clock_.AdvanceTimeMilliseconds(1); |
Henrik Boström | 9fe1834 | 2019-05-16 18:38:20 +0200 | [diff] [blame] | 712 | EXPECT_CALL(send_side_delay_observer_, SendSideDelayUpdated(1, 1, 31, kSsrc)) |
Johannes Kron | 4a8a5e7 | 2018-09-26 09:57:48 +0200 | [diff] [blame] | 713 | .Times(1); |
Danil Chapovalov | 51bf200 | 2019-10-11 10:53:27 +0200 | [diff] [blame] | 714 | video_header.frame_type = VideoFrameType::kVideoFrameKey; |
Niels Möller | 59ab1cf | 2019-02-06 22:48:11 +0100 | [diff] [blame] | 715 | EXPECT_TRUE(rtp_sender_video.SendVideo( |
Danil Chapovalov | 51bf200 | 2019-10-11 10:53:27 +0200 | [diff] [blame] | 716 | kPayloadType, kCodecType, capture_time_ms * kCaptureTimeMsToRtpTimestamp, |
| 717 | capture_time_ms, kPayloadData, nullptr, video_header, |
Johannes Kron | 4a8a5e7 | 2018-09-26 09:57:48 +0200 | [diff] [blame] | 718 | kDefaultExpectedRetransmissionTimeMs)); |
| 719 | } |
| 720 | |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 721 | TEST_P(RtpSenderTestWithoutPacer, OnSendPacketUpdated) { |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 722 | EXPECT_EQ(0, rtp_sender()->RegisterRtpHeaderExtension( |
stefan | a23fc62 | 2016-07-28 07:56:38 -0700 | [diff] [blame] | 723 | kRtpExtensionTransportSequenceNumber, |
| 724 | kTransportSequenceNumberExtensionId)); |
asapersson | 35151f3 | 2016-05-02 23:44:01 -0700 | [diff] [blame] | 725 | EXPECT_CALL(send_packet_observer_, |
| 726 | OnSendPacket(kTransportSequenceNumber, _, _)) |
| 727 | .Times(1); |
| 728 | |
Niels Möller | e7b9e6b | 2019-02-06 18:23:44 +0100 | [diff] [blame] | 729 | SendGenericPacket(); |
asapersson | 35151f3 | 2016-05-02 23:44:01 -0700 | [diff] [blame] | 730 | } |
| 731 | |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 732 | TEST_P(RtpSenderTest, SendsPacketsWithTransportSequenceNumber) { |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 733 | RtpRtcp::Configuration config; |
| 734 | config.clock = &fake_clock_; |
| 735 | config.outgoing_transport = &transport_; |
| 736 | config.paced_sender = &mock_paced_sender_; |
Erik Språng | 54d5d2c | 2019-08-20 17:22:36 +0200 | [diff] [blame] | 737 | config.local_media_ssrc = kSsrc; |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 738 | config.transport_feedback_callback = &feedback_observer_; |
| 739 | config.event_log = &mock_rtc_event_log_; |
| 740 | config.send_packet_observer = &send_packet_observer_; |
| 741 | config.retransmission_rate_limiter = &retransmission_rate_limiter_; |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 742 | rtp_sender_context_ = std::make_unique<RtpSenderContext>(config); |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 743 | |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 744 | rtp_sender()->SetSequenceNumber(kSeqNum); |
| 745 | rtp_sender_context_->packet_history_.SetStorePacketsStatus( |
| 746 | RtpPacketHistory::StorageMode::kStoreAndCull, 10); |
| 747 | EXPECT_EQ(0, rtp_sender()->RegisterRtpHeaderExtension( |
Stefan Holmer | a246cfb | 2016-08-23 17:51:42 +0200 | [diff] [blame] | 748 | kRtpExtensionTransportSequenceNumber, |
| 749 | kTransportSequenceNumberExtensionId)); |
| 750 | |
Stefan Holmer | a246cfb | 2016-08-23 17:51:42 +0200 | [diff] [blame] | 751 | EXPECT_CALL(send_packet_observer_, |
| 752 | OnSendPacket(kTransportSequenceNumber, _, _)) |
| 753 | .Times(1); |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 754 | EXPECT_CALL(feedback_observer_, |
Erik Språng | 30a276b | 2019-04-23 12:00:11 +0200 | [diff] [blame] | 755 | OnAddPacket(AllOf( |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 756 | Field(&RtpPacketSendInfo::ssrc, rtp_sender()->SSRC()), |
Erik Språng | 30a276b | 2019-04-23 12:00:11 +0200 | [diff] [blame] | 757 | Field(&RtpPacketSendInfo::transport_sequence_number, |
| 758 | kTransportSequenceNumber), |
| 759 | Field(&RtpPacketSendInfo::rtp_sequence_number, |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 760 | rtp_sender()->SequenceNumber()), |
Erik Språng | 30a276b | 2019-04-23 12:00:11 +0200 | [diff] [blame] | 761 | Field(&RtpPacketSendInfo::pacing_info, PacedPacketInfo())))) |
Stefan Holmer | a246cfb | 2016-08-23 17:51:42 +0200 | [diff] [blame] | 762 | .Times(1); |
| 763 | |
Erik Språng | f5815fa | 2019-08-21 14:27:31 +0200 | [diff] [blame] | 764 | EXPECT_CALL( |
| 765 | mock_paced_sender_, |
Erik Språng | ea55b08 | 2019-10-02 14:57:46 +0200 | [diff] [blame] | 766 | EnqueuePackets(Contains(AllOf( |
| 767 | Pointee(Property(&RtpPacketToSend::Ssrc, kSsrc)), |
| 768 | Pointee(Property(&RtpPacketToSend::SequenceNumber, kSeqNum)))))); |
Erik Språng | f5815fa | 2019-08-21 14:27:31 +0200 | [diff] [blame] | 769 | auto packet = SendGenericPacket(); |
| 770 | packet->set_packet_type(RtpPacketToSend::Type::kVideo); |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 771 | // Transport sequence number is set by PacketRouter, before SendPacket(). |
Erik Språng | f5815fa | 2019-08-21 14:27:31 +0200 | [diff] [blame] | 772 | packet->SetExtension<TransportSequenceNumber>(kTransportSequenceNumber); |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 773 | rtp_egress()->SendPacket(packet.get(), PacedPacketInfo()); |
Stefan Holmer | a246cfb | 2016-08-23 17:51:42 +0200 | [diff] [blame] | 774 | |
danilchap | 12ba186 | 2016-10-26 02:41:55 -0700 | [diff] [blame] | 775 | uint16_t transport_seq_no; |
Erik Språng | f5815fa | 2019-08-21 14:27:31 +0200 | [diff] [blame] | 776 | EXPECT_TRUE( |
| 777 | transport_.last_sent_packet().GetExtension<TransportSequenceNumber>( |
| 778 | &transport_seq_no)); |
danilchap | 12ba186 | 2016-10-26 02:41:55 -0700 | [diff] [blame] | 779 | EXPECT_EQ(kTransportSequenceNumber, transport_seq_no); |
Petter Strandmark | 26bc669 | 2018-05-29 08:43:35 +0200 | [diff] [blame] | 780 | EXPECT_EQ(transport_.last_options_.packet_id, transport_seq_no); |
Stefan Holmer | a246cfb | 2016-08-23 17:51:42 +0200 | [diff] [blame] | 781 | } |
| 782 | |
Erik Språng | 7b52f10 | 2018-02-07 14:37:37 +0100 | [diff] [blame] | 783 | TEST_P(RtpSenderTest, WritesPacerExitToTimingExtension) { |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 784 | rtp_sender_context_->packet_history_.SetStorePacketsStatus( |
| 785 | RtpPacketHistory::StorageMode::kStoreAndCull, 10); |
| 786 | EXPECT_EQ(0, rtp_sender()->RegisterRtpHeaderExtension( |
ilnik | 04f4d12 | 2017-06-19 07:18:55 -0700 | [diff] [blame] | 787 | kRtpExtensionVideoTiming, kVideoTimingExtensionId)); |
| 788 | int64_t capture_time_ms = fake_clock_.TimeInMilliseconds(); |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 789 | auto packet = rtp_sender()->AllocatePacket(); |
ilnik | 04f4d12 | 2017-06-19 07:18:55 -0700 | [diff] [blame] | 790 | packet->SetPayloadType(kPayload); |
| 791 | packet->SetMarker(true); |
| 792 | packet->SetTimestamp(kTimestamp); |
| 793 | packet->set_capture_time_ms(capture_time_ms); |
ilnik | 2edc684 | 2017-07-06 03:06:50 -0700 | [diff] [blame] | 794 | const VideoSendTiming kVideoTiming = {0u, 0u, 0u, 0u, 0u, 0u, true}; |
ilnik | 04f4d12 | 2017-06-19 07:18:55 -0700 | [diff] [blame] | 795 | packet->SetExtension<VideoTimingExtension>(kVideoTiming); |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 796 | EXPECT_TRUE(rtp_sender()->AssignSequenceNumber(packet.get())); |
ilnik | 04f4d12 | 2017-06-19 07:18:55 -0700 | [diff] [blame] | 797 | size_t packet_size = packet->size(); |
ilnik | 04f4d12 | 2017-06-19 07:18:55 -0700 | [diff] [blame] | 798 | |
| 799 | const int kStoredTimeInMs = 100; |
Erik Språng | f5815fa | 2019-08-21 14:27:31 +0200 | [diff] [blame] | 800 | packet->set_packet_type(RtpPacketToSend::Type::kVideo); |
Erik Språng | 70768f4 | 2019-08-27 18:16:26 +0200 | [diff] [blame] | 801 | packet->set_allow_retransmission(true); |
Erik Språng | ea55b08 | 2019-10-02 14:57:46 +0200 | [diff] [blame] | 802 | EXPECT_CALL(mock_paced_sender_, EnqueuePackets(Contains(Pointee(Property( |
| 803 | &RtpPacketToSend::Ssrc, kSsrc))))); |
Erik Språng | 70768f4 | 2019-08-27 18:16:26 +0200 | [diff] [blame] | 804 | EXPECT_TRUE( |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 805 | rtp_sender()->SendToNetwork(std::make_unique<RtpPacketToSend>(*packet))); |
Erik Språng | f5815fa | 2019-08-21 14:27:31 +0200 | [diff] [blame] | 806 | fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs); |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 807 | rtp_egress()->SendPacket(packet.get(), PacedPacketInfo()); |
ilnik | 04f4d12 | 2017-06-19 07:18:55 -0700 | [diff] [blame] | 808 | EXPECT_EQ(1, transport_.packets_sent()); |
| 809 | EXPECT_EQ(packet_size, transport_.last_sent_packet().size()); |
| 810 | |
danilchap | ce25181 | 2017-09-11 12:24:41 -0700 | [diff] [blame] | 811 | VideoSendTiming video_timing; |
| 812 | EXPECT_TRUE(transport_.last_sent_packet().GetExtension<VideoTimingExtension>( |
| 813 | &video_timing)); |
| 814 | EXPECT_EQ(kStoredTimeInMs, video_timing.pacer_exit_delta_ms); |
Erik Språng | 7b52f10 | 2018-02-07 14:37:37 +0100 | [diff] [blame] | 815 | } |
ilnik | 04f4d12 | 2017-06-19 07:18:55 -0700 | [diff] [blame] | 816 | |
Danil Chapovalov | af52b68 | 2018-11-27 10:48:27 +0100 | [diff] [blame] | 817 | TEST_P(RtpSenderTest, WritesNetwork2ToTimingExtensionWithPacer) { |
| 818 | SetUpRtpSender(/*pacer=*/true, /*populate_network2=*/true); |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 819 | rtp_sender_context_->packet_history_.SetStorePacketsStatus( |
| 820 | RtpPacketHistory::StorageMode::kStoreAndCull, 10); |
| 821 | EXPECT_EQ(0, rtp_sender()->RegisterRtpHeaderExtension( |
Erik Språng | 7b52f10 | 2018-02-07 14:37:37 +0100 | [diff] [blame] | 822 | kRtpExtensionVideoTiming, kVideoTimingExtensionId)); |
| 823 | int64_t capture_time_ms = fake_clock_.TimeInMilliseconds(); |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 824 | auto packet = rtp_sender()->AllocatePacket(); |
Erik Språng | 7b52f10 | 2018-02-07 14:37:37 +0100 | [diff] [blame] | 825 | packet->SetPayloadType(kPayload); |
| 826 | packet->SetMarker(true); |
| 827 | packet->SetTimestamp(kTimestamp); |
| 828 | packet->set_capture_time_ms(capture_time_ms); |
| 829 | const uint16_t kPacerExitMs = 1234u; |
| 830 | const VideoSendTiming kVideoTiming = {0u, 0u, 0u, kPacerExitMs, 0u, 0u, true}; |
| 831 | packet->SetExtension<VideoTimingExtension>(kVideoTiming); |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 832 | EXPECT_TRUE(rtp_sender()->AssignSequenceNumber(packet.get())); |
Erik Språng | 7b52f10 | 2018-02-07 14:37:37 +0100 | [diff] [blame] | 833 | size_t packet_size = packet->size(); |
| 834 | |
| 835 | const int kStoredTimeInMs = 100; |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 836 | |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 837 | packet->set_packet_type(RtpPacketToSend::Type::kVideo); |
Erik Språng | 70768f4 | 2019-08-27 18:16:26 +0200 | [diff] [blame] | 838 | packet->set_allow_retransmission(true); |
Erik Språng | ea55b08 | 2019-10-02 14:57:46 +0200 | [diff] [blame] | 839 | EXPECT_CALL(mock_paced_sender_, EnqueuePackets(Contains(Pointee(Property( |
| 840 | &RtpPacketToSend::Ssrc, kSsrc))))); |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 841 | EXPECT_TRUE(rtp_sender()->SendToNetwork( |
| 842 | std::make_unique<RtpPacketToSend>(*packet))); |
Erik Språng | a81e2b4 | 2019-10-28 11:17:07 +0000 | [diff] [blame] | 843 | fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs); |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 844 | rtp_egress()->SendPacket(packet.get(), PacedPacketInfo()); |
Erik Språng | a81e2b4 | 2019-10-28 11:17:07 +0000 | [diff] [blame] | 845 | |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 846 | EXPECT_EQ(1, transport_.packets_sent()); |
| 847 | EXPECT_EQ(packet_size, transport_.last_sent_packet().size()); |
Erik Språng | a81e2b4 | 2019-10-28 11:17:07 +0000 | [diff] [blame] | 848 | |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 849 | VideoSendTiming video_timing; |
| 850 | EXPECT_TRUE( |
| 851 | transport_.last_sent_packet().GetExtension<VideoTimingExtension>( |
| 852 | &video_timing)); |
| 853 | EXPECT_EQ(kStoredTimeInMs, video_timing.network2_timestamp_delta_ms); |
| 854 | EXPECT_EQ(kPacerExitMs, video_timing.pacer_exit_delta_ms); |
ilnik | 04f4d12 | 2017-06-19 07:18:55 -0700 | [diff] [blame] | 855 | } |
| 856 | |
Danil Chapovalov | af52b68 | 2018-11-27 10:48:27 +0100 | [diff] [blame] | 857 | TEST_P(RtpSenderTest, WritesNetwork2ToTimingExtensionWithoutPacer) { |
| 858 | SetUpRtpSender(/*pacer=*/false, /*populate_network2=*/true); |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 859 | EXPECT_EQ(0, rtp_sender()->RegisterRtpHeaderExtension( |
Danil Chapovalov | af52b68 | 2018-11-27 10:48:27 +0100 | [diff] [blame] | 860 | kRtpExtensionVideoTiming, kVideoTimingExtensionId)); |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 861 | auto packet = rtp_sender()->AllocatePacket(); |
Danil Chapovalov | af52b68 | 2018-11-27 10:48:27 +0100 | [diff] [blame] | 862 | packet->SetMarker(true); |
| 863 | packet->set_capture_time_ms(fake_clock_.TimeInMilliseconds()); |
| 864 | const VideoSendTiming kVideoTiming = {0u, 0u, 0u, 0u, 0u, 0u, true}; |
| 865 | packet->SetExtension<VideoTimingExtension>(kVideoTiming); |
Erik Språng | 70768f4 | 2019-08-27 18:16:26 +0200 | [diff] [blame] | 866 | packet->set_allow_retransmission(true); |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 867 | EXPECT_TRUE(rtp_sender()->AssignSequenceNumber(packet.get())); |
Erik Språng | 1fbfecd | 2019-08-26 19:00:05 +0200 | [diff] [blame] | 868 | packet->set_packet_type(RtpPacketToSend::Type::kVideo); |
Danil Chapovalov | af52b68 | 2018-11-27 10:48:27 +0100 | [diff] [blame] | 869 | |
| 870 | const int kPropagateTimeMs = 10; |
| 871 | fake_clock_.AdvanceTimeMilliseconds(kPropagateTimeMs); |
| 872 | |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 873 | EXPECT_TRUE(rtp_sender()->SendToNetwork(std::move(packet))); |
Danil Chapovalov | af52b68 | 2018-11-27 10:48:27 +0100 | [diff] [blame] | 874 | |
| 875 | EXPECT_EQ(1, transport_.packets_sent()); |
| 876 | absl::optional<VideoSendTiming> video_timing = |
| 877 | transport_.last_sent_packet().GetExtension<VideoTimingExtension>(); |
| 878 | ASSERT_TRUE(video_timing); |
| 879 | EXPECT_EQ(kPropagateTimeMs, video_timing->network2_timestamp_delta_ms); |
| 880 | } |
| 881 | |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 882 | TEST_P(RtpSenderTest, TrafficSmoothingWithExtensions) { |
Elad Alon | 4a87e1c | 2017-10-03 16:11:34 +0200 | [diff] [blame] | 883 | EXPECT_CALL(mock_rtc_event_log_, |
| 884 | LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing))); |
asapersson@webrtc.org | 0b3c35a | 2012-01-16 11:06:31 +0000 | [diff] [blame] | 885 | |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 886 | rtp_sender_context_->packet_history_.SetStorePacketsStatus( |
| 887 | RtpPacketHistory::StorageMode::kStoreAndCull, 10); |
| 888 | EXPECT_EQ(0, rtp_sender()->RegisterRtpHeaderExtension( |
danilchap | 162abd3 | 2015-12-10 02:39:40 -0800 | [diff] [blame] | 889 | kRtpExtensionTransmissionTimeOffset, |
| 890 | kTransmissionTimeOffsetExtensionId)); |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 891 | EXPECT_EQ(0, |
| 892 | rtp_sender()->RegisterRtpHeaderExtension( |
| 893 | kRtpExtensionAbsoluteSendTime, kAbsoluteSendTimeExtensionId)); |
stefan@webrtc.org | 8ccb9f9 | 2013-06-19 14:13:42 +0000 | [diff] [blame] | 894 | int64_t capture_time_ms = fake_clock_.TimeInMilliseconds(); |
danilchap | b6f1fb5 | 2016-10-19 06:11:39 -0700 | [diff] [blame] | 895 | auto packet = |
| 896 | BuildRtpPacket(kPayload, kMarkerBit, kTimestamp, capture_time_ms); |
| 897 | size_t packet_size = packet->size(); |
pwestin@webrtc.org | b0061f9 | 2013-04-27 00:41:08 +0000 | [diff] [blame] | 898 | |
asapersson@webrtc.org | 0b3c35a | 2012-01-16 11:06:31 +0000 | [diff] [blame] | 899 | const int kStoredTimeInMs = 100; |
Erik Språng | ea55b08 | 2019-10-02 14:57:46 +0200 | [diff] [blame] | 900 | EXPECT_CALL( |
| 901 | mock_paced_sender_, |
| 902 | EnqueuePackets(Contains(AllOf( |
| 903 | Pointee(Property(&RtpPacketToSend::Ssrc, kSsrc)), |
| 904 | Pointee(Property(&RtpPacketToSend::SequenceNumber, kSeqNum)))))); |
| 905 | packet->set_packet_type(RtpPacketToSend::Type::kVideo); |
| 906 | packet->set_allow_retransmission(true); |
| 907 | EXPECT_TRUE( |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 908 | rtp_sender()->SendToNetwork(std::make_unique<RtpPacketToSend>(*packet))); |
Erik Språng | ea55b08 | 2019-10-02 14:57:46 +0200 | [diff] [blame] | 909 | EXPECT_EQ(0, transport_.packets_sent()); |
| 910 | fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs); |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 911 | rtp_egress()->SendPacket(packet.get(), PacedPacketInfo()); |
pwestin@webrtc.org | b0061f9 | 2013-04-27 00:41:08 +0000 | [diff] [blame] | 912 | |
asapersson@webrtc.org | 0b3c35a | 2012-01-16 11:06:31 +0000 | [diff] [blame] | 913 | // Process send bucket. Packet should now be sent. |
danilchap | 12ba186 | 2016-10-26 02:41:55 -0700 | [diff] [blame] | 914 | EXPECT_EQ(1, transport_.packets_sent()); |
| 915 | EXPECT_EQ(packet_size, transport_.last_sent_packet().size()); |
| 916 | |
stefan@webrtc.org | a5cb98c | 2013-05-29 12:12:51 +0000 | [diff] [blame] | 917 | webrtc::RTPHeader rtp_header; |
danilchap | 12ba186 | 2016-10-26 02:41:55 -0700 | [diff] [blame] | 918 | transport_.last_sent_packet().GetHeader(&rtp_header); |
pwestin@webrtc.org | b0061f9 | 2013-04-27 00:41:08 +0000 | [diff] [blame] | 919 | |
| 920 | // Verify transmission time offset. |
| 921 | EXPECT_EQ(kStoredTimeInMs * 90, rtp_header.extension.transmissionTimeOffset); |
solenberg@webrtc.org | 7ebbea1 | 2013-05-16 11:10:31 +0000 | [diff] [blame] | 922 | uint64_t expected_send_time = |
henrik.lundin@webrtc.org | 6e95d7a | 2013-11-15 08:59:19 +0000 | [diff] [blame] | 923 | ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds()); |
solenberg@webrtc.org | 7ebbea1 | 2013-05-16 11:10:31 +0000 | [diff] [blame] | 924 | EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime); |
pwestin@webrtc.org | b0061f9 | 2013-04-27 00:41:08 +0000 | [diff] [blame] | 925 | } |
| 926 | |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 927 | TEST_P(RtpSenderTest, TrafficSmoothingRetransmits) { |
Elad Alon | 4a87e1c | 2017-10-03 16:11:34 +0200 | [diff] [blame] | 928 | EXPECT_CALL(mock_rtc_event_log_, |
| 929 | LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing))); |
pwestin@webrtc.org | b0061f9 | 2013-04-27 00:41:08 +0000 | [diff] [blame] | 930 | |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 931 | rtp_sender_context_->packet_history_.SetStorePacketsStatus( |
| 932 | RtpPacketHistory::StorageMode::kStoreAndCull, 10); |
| 933 | EXPECT_EQ(0, rtp_sender()->RegisterRtpHeaderExtension( |
danilchap | 162abd3 | 2015-12-10 02:39:40 -0800 | [diff] [blame] | 934 | kRtpExtensionTransmissionTimeOffset, |
| 935 | kTransmissionTimeOffsetExtensionId)); |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 936 | EXPECT_EQ(0, |
| 937 | rtp_sender()->RegisterRtpHeaderExtension( |
| 938 | kRtpExtensionAbsoluteSendTime, kAbsoluteSendTimeExtensionId)); |
stefan@webrtc.org | 8ccb9f9 | 2013-06-19 14:13:42 +0000 | [diff] [blame] | 939 | int64_t capture_time_ms = fake_clock_.TimeInMilliseconds(); |
danilchap | b6f1fb5 | 2016-10-19 06:11:39 -0700 | [diff] [blame] | 940 | auto packet = |
| 941 | BuildRtpPacket(kPayload, kMarkerBit, kTimestamp, capture_time_ms); |
| 942 | size_t packet_size = packet->size(); |
pwestin@webrtc.org | b0061f9 | 2013-04-27 00:41:08 +0000 | [diff] [blame] | 943 | |
| 944 | // Packet should be stored in a send bucket. |
Erik Språng | ea55b08 | 2019-10-02 14:57:46 +0200 | [diff] [blame] | 945 | EXPECT_CALL( |
| 946 | mock_paced_sender_, |
| 947 | EnqueuePackets(Contains(AllOf( |
| 948 | Pointee(Property(&RtpPacketToSend::Ssrc, kSsrc)), |
| 949 | Pointee(Property(&RtpPacketToSend::SequenceNumber, kSeqNum)))))); |
| 950 | packet->set_packet_type(RtpPacketToSend::Type::kVideo); |
| 951 | packet->set_allow_retransmission(true); |
| 952 | EXPECT_TRUE( |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 953 | rtp_sender()->SendToNetwork(std::make_unique<RtpPacketToSend>(*packet))); |
Erik Språng | ea55b08 | 2019-10-02 14:57:46 +0200 | [diff] [blame] | 954 | // Immediately process send bucket and send packet. |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 955 | rtp_egress()->SendPacket(packet.get(), PacedPacketInfo()); |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 956 | |
Erik Språng | 0f4f055 | 2019-05-08 10:15:05 -0700 | [diff] [blame] | 957 | EXPECT_EQ(1, transport_.packets_sent()); |
pwestin@webrtc.org | b0061f9 | 2013-04-27 00:41:08 +0000 | [diff] [blame] | 958 | |
Erik Språng | 0f4f055 | 2019-05-08 10:15:05 -0700 | [diff] [blame] | 959 | // Retransmit packet. |
pwestin@webrtc.org | b0061f9 | 2013-04-27 00:41:08 +0000 | [diff] [blame] | 960 | const int kStoredTimeInMs = 100; |
| 961 | fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs); |
| 962 | |
Erik Språng | 0f4f055 | 2019-05-08 10:15:05 -0700 | [diff] [blame] | 963 | EXPECT_CALL(mock_rtc_event_log_, |
| 964 | LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing))); |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 965 | packet->set_packet_type(RtpPacketToSend::Type::kRetransmission); |
| 966 | packet->set_retransmitted_sequence_number(kSeqNum); |
| 967 | EXPECT_CALL( |
| 968 | mock_paced_sender_, |
Erik Språng | ea55b08 | 2019-10-02 14:57:46 +0200 | [diff] [blame] | 969 | EnqueuePackets(Contains(AllOf( |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 970 | Pointee(Property(&RtpPacketToSend::Ssrc, kSsrc)), |
Erik Språng | ea55b08 | 2019-10-02 14:57:46 +0200 | [diff] [blame] | 971 | Pointee(Property(&RtpPacketToSend::SequenceNumber, kSeqNum)))))); |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 972 | EXPECT_EQ(static_cast<int>(packet_size), |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 973 | rtp_sender()->ReSendPacket(kSeqNum)); |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 974 | EXPECT_EQ(1, transport_.packets_sent()); |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 975 | rtp_egress()->SendPacket(packet.get(), PacedPacketInfo()); |
pwestin@webrtc.org | b0061f9 | 2013-04-27 00:41:08 +0000 | [diff] [blame] | 976 | |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 977 | // Process send bucket. Packet should now be sent. |
| 978 | EXPECT_EQ(2, transport_.packets_sent()); |
| 979 | EXPECT_EQ(packet_size, transport_.last_sent_packet().size()); |
pwestin@webrtc.org | b0061f9 | 2013-04-27 00:41:08 +0000 | [diff] [blame] | 980 | |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 981 | webrtc::RTPHeader rtp_header; |
| 982 | transport_.last_sent_packet().GetHeader(&rtp_header); |
pwestin@webrtc.org | b0061f9 | 2013-04-27 00:41:08 +0000 | [diff] [blame] | 983 | |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 984 | // Verify transmission time offset. |
| 985 | EXPECT_EQ(kStoredTimeInMs * 90, |
| 986 | rtp_header.extension.transmissionTimeOffset); |
| 987 | uint64_t expected_send_time = |
| 988 | ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds()); |
| 989 | EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime); |
henrik.lundin@webrtc.org | 6e95d7a | 2013-11-15 08:59:19 +0000 | [diff] [blame] | 990 | } |
| 991 | |
| 992 | // This test sends 1 regular video packet, then 4 padding packets, and then |
| 993 | // 1 more regular packet. |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 994 | TEST_P(RtpSenderTest, SendPadding) { |
henrik.lundin@webrtc.org | 6e95d7a | 2013-11-15 08:59:19 +0000 | [diff] [blame] | 995 | // Make all (non-padding) packets go to send queue. |
Elad Alon | 4a87e1c | 2017-10-03 16:11:34 +0200 | [diff] [blame] | 996 | EXPECT_CALL(mock_rtc_event_log_, |
| 997 | LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing))) |
| 998 | .Times(1 + 4 + 1); |
henrik.lundin@webrtc.org | 6e95d7a | 2013-11-15 08:59:19 +0000 | [diff] [blame] | 999 | |
| 1000 | uint16_t seq_num = kSeqNum; |
| 1001 | uint32_t timestamp = kTimestamp; |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 1002 | rtp_sender_context_->packet_history_.SetStorePacketsStatus( |
| 1003 | RtpPacketHistory::StorageMode::kStoreAndCull, 10); |
pkasting@chromium.org | 4591fbd | 2014-11-20 22:28:14 +0000 | [diff] [blame] | 1004 | size_t rtp_header_len = kRtpHeaderSize; |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 1005 | EXPECT_EQ(0, rtp_sender()->RegisterRtpHeaderExtension( |
danilchap | 162abd3 | 2015-12-10 02:39:40 -0800 | [diff] [blame] | 1006 | kRtpExtensionTransmissionTimeOffset, |
| 1007 | kTransmissionTimeOffsetExtensionId)); |
henrik.lundin@webrtc.org | 6e95d7a | 2013-11-15 08:59:19 +0000 | [diff] [blame] | 1008 | rtp_header_len += 4; // 4 bytes extension. |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 1009 | EXPECT_EQ(0, |
| 1010 | rtp_sender()->RegisterRtpHeaderExtension( |
| 1011 | kRtpExtensionAbsoluteSendTime, kAbsoluteSendTimeExtensionId)); |
henrik.lundin@webrtc.org | 6e95d7a | 2013-11-15 08:59:19 +0000 | [diff] [blame] | 1012 | rtp_header_len += 4; // 4 bytes extension. |
| 1013 | rtp_header_len += 4; // 4 extra bytes common to all extension headers. |
| 1014 | |
henrik.lundin@webrtc.org | 6e95d7a | 2013-11-15 08:59:19 +0000 | [diff] [blame] | 1015 | webrtc::RTPHeader rtp_header; |
| 1016 | |
henrik.lundin@webrtc.org | 6e95d7a | 2013-11-15 08:59:19 +0000 | [diff] [blame] | 1017 | int64_t capture_time_ms = fake_clock_.TimeInMilliseconds(); |
danilchap | b6f1fb5 | 2016-10-19 06:11:39 -0700 | [diff] [blame] | 1018 | auto packet = |
| 1019 | BuildRtpPacket(kPayload, kMarkerBit, timestamp, capture_time_ms); |
Stefan Holmer | 586b19b | 2015-09-18 11:14:31 +0200 | [diff] [blame] | 1020 | const uint32_t media_packet_timestamp = timestamp; |
danilchap | b6f1fb5 | 2016-10-19 06:11:39 -0700 | [diff] [blame] | 1021 | size_t packet_size = packet->size(); |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 1022 | int total_packets_sent = 0; |
| 1023 | const int kStoredTimeInMs = 100; |
henrik.lundin@webrtc.org | 6e95d7a | 2013-11-15 08:59:19 +0000 | [diff] [blame] | 1024 | |
| 1025 | // Packet should be stored in a send bucket. |
Erik Språng | ea55b08 | 2019-10-02 14:57:46 +0200 | [diff] [blame] | 1026 | EXPECT_CALL( |
| 1027 | mock_paced_sender_, |
| 1028 | EnqueuePackets(Contains(AllOf( |
| 1029 | Pointee(Property(&RtpPacketToSend::Ssrc, kSsrc)), |
| 1030 | Pointee(Property(&RtpPacketToSend::SequenceNumber, kSeqNum)))))); |
| 1031 | packet->set_packet_type(RtpPacketToSend::Type::kVideo); |
| 1032 | packet->set_allow_retransmission(true); |
| 1033 | EXPECT_TRUE( |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 1034 | rtp_sender()->SendToNetwork(std::make_unique<RtpPacketToSend>(*packet))); |
Erik Språng | ea55b08 | 2019-10-02 14:57:46 +0200 | [diff] [blame] | 1035 | EXPECT_EQ(total_packets_sent, transport_.packets_sent()); |
| 1036 | fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs); |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 1037 | rtp_egress()->SendPacket(packet.get(), PacedPacketInfo()); |
Erik Språng | ea55b08 | 2019-10-02 14:57:46 +0200 | [diff] [blame] | 1038 | ++seq_num; |
henrik.lundin@webrtc.org | 6e95d7a | 2013-11-15 08:59:19 +0000 | [diff] [blame] | 1039 | |
henrik.lundin@webrtc.org | 6e95d7a | 2013-11-15 08:59:19 +0000 | [diff] [blame] | 1040 | // Packet should now be sent. This test doesn't verify the regular video |
| 1041 | // packet, since it is tested in another test. |
danilchap | 12ba186 | 2016-10-26 02:41:55 -0700 | [diff] [blame] | 1042 | EXPECT_EQ(++total_packets_sent, transport_.packets_sent()); |
henrik.lundin@webrtc.org | 6e95d7a | 2013-11-15 08:59:19 +0000 | [diff] [blame] | 1043 | timestamp += 90 * kStoredTimeInMs; |
| 1044 | |
| 1045 | // Send padding 4 times, waiting 50 ms between each. |
| 1046 | for (int i = 0; i < 4; ++i) { |
| 1047 | const int kPaddingPeriodMs = 50; |
pkasting@chromium.org | 4591fbd | 2014-11-20 22:28:14 +0000 | [diff] [blame] | 1048 | const size_t kPaddingBytes = 100; |
| 1049 | const size_t kMaxPaddingLength = 224; // Value taken from rtp_sender.cc. |
henrik.lundin@webrtc.org | 6e95d7a | 2013-11-15 08:59:19 +0000 | [diff] [blame] | 1050 | // Padding will be forced to full packets. |
Erik Språng | 4208a13 | 2019-08-26 08:58:45 +0200 | [diff] [blame] | 1051 | EXPECT_EQ(kMaxPaddingLength, GenerateAndSendPadding(kPaddingBytes)); |
henrik.lundin@webrtc.org | 6e95d7a | 2013-11-15 08:59:19 +0000 | [diff] [blame] | 1052 | |
| 1053 | // Process send bucket. Padding should now be sent. |
danilchap | 12ba186 | 2016-10-26 02:41:55 -0700 | [diff] [blame] | 1054 | EXPECT_EQ(++total_packets_sent, transport_.packets_sent()); |
henrik.lundin@webrtc.org | 6e95d7a | 2013-11-15 08:59:19 +0000 | [diff] [blame] | 1055 | EXPECT_EQ(kMaxPaddingLength + rtp_header_len, |
danilchap | 12ba186 | 2016-10-26 02:41:55 -0700 | [diff] [blame] | 1056 | transport_.last_sent_packet().size()); |
| 1057 | |
| 1058 | transport_.last_sent_packet().GetHeader(&rtp_header); |
pbos | bd2522a | 2015-07-01 05:35:53 -0700 | [diff] [blame] | 1059 | EXPECT_EQ(kMaxPaddingLength, rtp_header.paddingLength); |
henrik.lundin@webrtc.org | 6e95d7a | 2013-11-15 08:59:19 +0000 | [diff] [blame] | 1060 | |
Stefan Holmer | 586b19b | 2015-09-18 11:14:31 +0200 | [diff] [blame] | 1061 | // Verify sequence number and timestamp. The timestamp should be the same |
| 1062 | // as the last media packet. |
henrik.lundin@webrtc.org | 6e95d7a | 2013-11-15 08:59:19 +0000 | [diff] [blame] | 1063 | EXPECT_EQ(seq_num++, rtp_header.sequenceNumber); |
Stefan Holmer | 586b19b | 2015-09-18 11:14:31 +0200 | [diff] [blame] | 1064 | EXPECT_EQ(media_packet_timestamp, rtp_header.timestamp); |
henrik.lundin@webrtc.org | 6e95d7a | 2013-11-15 08:59:19 +0000 | [diff] [blame] | 1065 | // Verify transmission time offset. |
Stefan Holmer | 586b19b | 2015-09-18 11:14:31 +0200 | [diff] [blame] | 1066 | int offset = timestamp - media_packet_timestamp; |
| 1067 | EXPECT_EQ(offset, rtp_header.extension.transmissionTimeOffset); |
henrik.lundin@webrtc.org | 6e95d7a | 2013-11-15 08:59:19 +0000 | [diff] [blame] | 1068 | uint64_t expected_send_time = |
| 1069 | ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds()); |
| 1070 | EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime); |
| 1071 | fake_clock_.AdvanceTimeMilliseconds(kPaddingPeriodMs); |
| 1072 | timestamp += 90 * kPaddingPeriodMs; |
| 1073 | } |
| 1074 | |
| 1075 | // Send a regular video packet again. |
| 1076 | capture_time_ms = fake_clock_.TimeInMilliseconds(); |
danilchap | b6f1fb5 | 2016-10-19 06:11:39 -0700 | [diff] [blame] | 1077 | packet = BuildRtpPacket(kPayload, kMarkerBit, timestamp, capture_time_ms); |
| 1078 | packet_size = packet->size(); |
henrik.lundin@webrtc.org | 6e95d7a | 2013-11-15 08:59:19 +0000 | [diff] [blame] | 1079 | |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 1080 | packet->set_packet_type(RtpPacketToSend::Type::kVideo); |
Erik Språng | 70768f4 | 2019-08-27 18:16:26 +0200 | [diff] [blame] | 1081 | packet->set_allow_retransmission(true); |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 1082 | EXPECT_CALL( |
| 1083 | mock_paced_sender_, |
Erik Språng | ea55b08 | 2019-10-02 14:57:46 +0200 | [diff] [blame] | 1084 | EnqueuePackets(Contains(AllOf( |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 1085 | Pointee(Property(&RtpPacketToSend::Ssrc, kSsrc)), |
Erik Språng | ea55b08 | 2019-10-02 14:57:46 +0200 | [diff] [blame] | 1086 | Pointee(Property(&RtpPacketToSend::SequenceNumber, seq_num)))))); |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 1087 | EXPECT_TRUE(rtp_sender()->SendToNetwork( |
| 1088 | std::make_unique<RtpPacketToSend>(*packet))); |
| 1089 | rtp_egress()->SendPacket(packet.get(), PacedPacketInfo()); |
terelius | 5d332ac | 2016-01-14 14:37:39 -0800 | [diff] [blame] | 1090 | |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 1091 | // Process send bucket. |
| 1092 | EXPECT_EQ(++total_packets_sent, transport_.packets_sent()); |
| 1093 | EXPECT_EQ(packet_size, transport_.last_sent_packet().size()); |
| 1094 | transport_.last_sent_packet().GetHeader(&rtp_header); |
henrik.lundin@webrtc.org | 6e95d7a | 2013-11-15 08:59:19 +0000 | [diff] [blame] | 1095 | |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 1096 | // Verify sequence number and timestamp. |
| 1097 | EXPECT_EQ(seq_num, rtp_header.sequenceNumber); |
| 1098 | EXPECT_EQ(timestamp, rtp_header.timestamp); |
| 1099 | // Verify transmission time offset. This packet is sent without delay. |
| 1100 | EXPECT_EQ(0, rtp_header.extension.transmissionTimeOffset); |
| 1101 | uint64_t expected_send_time = |
| 1102 | ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds()); |
| 1103 | EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime); |
asapersson@webrtc.org | 0b3c35a | 2012-01-16 11:06:31 +0000 | [diff] [blame] | 1104 | } |
pbos@webrtc.org | 8911ce4 | 2013-03-18 16:39:03 +0000 | [diff] [blame] | 1105 | |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 1106 | TEST_P(RtpSenderTest, OnSendPacketUpdated) { |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 1107 | EXPECT_EQ(0, rtp_sender()->RegisterRtpHeaderExtension( |
stefan | a23fc62 | 2016-07-28 07:56:38 -0700 | [diff] [blame] | 1108 | kRtpExtensionTransportSequenceNumber, |
| 1109 | kTransportSequenceNumberExtensionId)); |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 1110 | rtp_sender_context_->packet_history_.SetStorePacketsStatus( |
| 1111 | RtpPacketHistory::StorageMode::kStoreAndCull, 10); |
asapersson | 35151f3 | 2016-05-02 23:44:01 -0700 | [diff] [blame] | 1112 | |
| 1113 | EXPECT_CALL(send_packet_observer_, |
| 1114 | OnSendPacket(kTransportSequenceNumber, _, _)) |
| 1115 | .Times(1); |
asapersson | 35151f3 | 2016-05-02 23:44:01 -0700 | [diff] [blame] | 1116 | |
Erik Språng | ea55b08 | 2019-10-02 14:57:46 +0200 | [diff] [blame] | 1117 | EXPECT_CALL( |
| 1118 | mock_paced_sender_, |
| 1119 | EnqueuePackets(Contains(AllOf( |
| 1120 | Pointee(Property(&RtpPacketToSend::Ssrc, kSsrc)), |
| 1121 | Pointee(Property(&RtpPacketToSend::SequenceNumber, kSeqNum)))))); |
| 1122 | auto packet = SendGenericPacket(); |
| 1123 | packet->set_packet_type(RtpPacketToSend::Type::kVideo); |
| 1124 | packet->SetExtension<TransportSequenceNumber>(kTransportSequenceNumber); |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 1125 | rtp_egress()->SendPacket(packet.get(), PacedPacketInfo()); |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 1126 | |
danilchap | 12ba186 | 2016-10-26 02:41:55 -0700 | [diff] [blame] | 1127 | EXPECT_EQ(1, transport_.packets_sent()); |
asapersson | 35151f3 | 2016-05-02 23:44:01 -0700 | [diff] [blame] | 1128 | } |
| 1129 | |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 1130 | TEST_P(RtpSenderTest, OnSendPacketNotUpdatedForRetransmits) { |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 1131 | EXPECT_EQ(0, rtp_sender()->RegisterRtpHeaderExtension( |
stefan | a23fc62 | 2016-07-28 07:56:38 -0700 | [diff] [blame] | 1132 | kRtpExtensionTransportSequenceNumber, |
| 1133 | kTransportSequenceNumberExtensionId)); |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 1134 | rtp_sender_context_->packet_history_.SetStorePacketsStatus( |
| 1135 | RtpPacketHistory::StorageMode::kStoreAndCull, 10); |
asapersson | 35151f3 | 2016-05-02 23:44:01 -0700 | [diff] [blame] | 1136 | |
| 1137 | EXPECT_CALL(send_packet_observer_, OnSendPacket(_, _, _)).Times(0); |
asapersson | 35151f3 | 2016-05-02 23:44:01 -0700 | [diff] [blame] | 1138 | |
Erik Språng | ea55b08 | 2019-10-02 14:57:46 +0200 | [diff] [blame] | 1139 | EXPECT_CALL( |
| 1140 | mock_paced_sender_, |
| 1141 | EnqueuePackets(Contains(AllOf( |
| 1142 | Pointee(Property(&RtpPacketToSend::Ssrc, kSsrc)), |
| 1143 | Pointee(Property(&RtpPacketToSend::SequenceNumber, kSeqNum)))))); |
| 1144 | auto packet = SendGenericPacket(); |
| 1145 | packet->set_packet_type(RtpPacketToSend::Type::kRetransmission); |
| 1146 | packet->SetExtension<TransportSequenceNumber>(kTransportSequenceNumber); |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 1147 | rtp_egress()->SendPacket(packet.get(), PacedPacketInfo()); |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 1148 | |
danilchap | 12ba186 | 2016-10-26 02:41:55 -0700 | [diff] [blame] | 1149 | EXPECT_EQ(1, transport_.packets_sent()); |
Petter Strandmark | 26bc669 | 2018-05-29 08:43:35 +0200 | [diff] [blame] | 1150 | EXPECT_TRUE(transport_.last_options_.is_retransmit); |
asapersson | 35151f3 | 2016-05-02 23:44:01 -0700 | [diff] [blame] | 1151 | } |
| 1152 | |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 1153 | TEST_P(RtpSenderTestWithoutPacer, SendGenericVideo) { |
Erik Språng | 6cf554e | 2019-10-02 20:55:39 +0200 | [diff] [blame] | 1154 | const uint8_t kPayloadType = 127; |
| 1155 | const VideoCodecType kCodecType = VideoCodecType::kVideoCodecGeneric; |
Niels Möller | 5fe9510 | 2019-03-04 16:49:25 +0100 | [diff] [blame] | 1156 | PlayoutDelayOracle playout_delay_oracle; |
Erik Språng | dc34a25 | 2019-10-04 15:17:29 +0200 | [diff] [blame] | 1157 | FieldTrialBasedConfig field_trials; |
| 1158 | RTPSenderVideo::Config video_config; |
| 1159 | video_config.clock = &fake_clock_; |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 1160 | video_config.rtp_sender = rtp_sender(); |
Erik Språng | dc34a25 | 2019-10-04 15:17:29 +0200 | [diff] [blame] | 1161 | video_config.playout_delay_oracle = &playout_delay_oracle; |
| 1162 | video_config.field_trials = &field_trials; |
| 1163 | RTPSenderVideo rtp_sender_video(video_config); |
pbos@webrtc.org | 8911ce4 | 2013-03-18 16:39:03 +0000 | [diff] [blame] | 1164 | uint8_t payload[] = {47, 11, 32, 93, 89}; |
| 1165 | |
| 1166 | // Send keyframe |
Sami Kalliomäki | 426a80c | 2018-08-08 11:37:59 +0200 | [diff] [blame] | 1167 | RTPVideoHeader video_header; |
Danil Chapovalov | 51bf200 | 2019-10-11 10:53:27 +0200 | [diff] [blame] | 1168 | video_header.frame_type = VideoFrameType::kVideoFrameKey; |
| 1169 | ASSERT_TRUE(rtp_sender_video.SendVideo(kPayloadType, kCodecType, 1234, 4321, |
| 1170 | payload, nullptr, video_header, |
| 1171 | kDefaultExpectedRetransmissionTimeMs)); |
pbos@webrtc.org | 8911ce4 | 2013-03-18 16:39:03 +0000 | [diff] [blame] | 1172 | |
danilchap | 96c1587 | 2016-11-21 01:35:29 -0800 | [diff] [blame] | 1173 | auto sent_payload = transport_.last_sent_packet().payload(); |
| 1174 | uint8_t generic_header = sent_payload[0]; |
pbos@webrtc.org | 8911ce4 | 2013-03-18 16:39:03 +0000 | [diff] [blame] | 1175 | EXPECT_TRUE(generic_header & RtpFormatVideoGeneric::kKeyFrameBit); |
| 1176 | EXPECT_TRUE(generic_header & RtpFormatVideoGeneric::kFirstPacketBit); |
danilchap | 96c1587 | 2016-11-21 01:35:29 -0800 | [diff] [blame] | 1177 | EXPECT_THAT(sent_payload.subview(1), ElementsAreArray(payload)); |
pbos@webrtc.org | 8911ce4 | 2013-03-18 16:39:03 +0000 | [diff] [blame] | 1178 | |
| 1179 | // Send delta frame |
| 1180 | payload[0] = 13; |
| 1181 | payload[1] = 42; |
| 1182 | payload[4] = 13; |
| 1183 | |
Danil Chapovalov | 51bf200 | 2019-10-11 10:53:27 +0200 | [diff] [blame] | 1184 | video_header.frame_type = VideoFrameType::kVideoFrameDelta; |
| 1185 | ASSERT_TRUE(rtp_sender_video.SendVideo(kPayloadType, kCodecType, 1234, 4321, |
| 1186 | payload, nullptr, video_header, |
| 1187 | kDefaultExpectedRetransmissionTimeMs)); |
pbos@webrtc.org | 8911ce4 | 2013-03-18 16:39:03 +0000 | [diff] [blame] | 1188 | |
danilchap | 96c1587 | 2016-11-21 01:35:29 -0800 | [diff] [blame] | 1189 | sent_payload = transport_.last_sent_packet().payload(); |
| 1190 | generic_header = sent_payload[0]; |
pbos@webrtc.org | 8911ce4 | 2013-03-18 16:39:03 +0000 | [diff] [blame] | 1191 | EXPECT_FALSE(generic_header & RtpFormatVideoGeneric::kKeyFrameBit); |
| 1192 | EXPECT_TRUE(generic_header & RtpFormatVideoGeneric::kFirstPacketBit); |
danilchap | 96c1587 | 2016-11-21 01:35:29 -0800 | [diff] [blame] | 1193 | EXPECT_THAT(sent_payload.subview(1), ElementsAreArray(payload)); |
pbos@webrtc.org | 8911ce4 | 2013-03-18 16:39:03 +0000 | [diff] [blame] | 1194 | } |
| 1195 | |
Mirta Dvornicic | fe68daa | 2019-05-23 13:21:12 +0200 | [diff] [blame] | 1196 | TEST_P(RtpSenderTestWithoutPacer, SendRawVideo) { |
Erik Språng | 6cf554e | 2019-10-02 20:55:39 +0200 | [diff] [blame] | 1197 | const uint8_t kPayloadType = 111; |
Mirta Dvornicic | fe68daa | 2019-05-23 13:21:12 +0200 | [diff] [blame] | 1198 | const uint8_t payload[] = {11, 22, 33, 44, 55}; |
| 1199 | |
| 1200 | PlayoutDelayOracle playout_delay_oracle; |
Erik Språng | dc34a25 | 2019-10-04 15:17:29 +0200 | [diff] [blame] | 1201 | FieldTrialBasedConfig field_trials; |
| 1202 | RTPSenderVideo::Config video_config; |
| 1203 | video_config.clock = &fake_clock_; |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 1204 | video_config.rtp_sender = rtp_sender(); |
Erik Språng | dc34a25 | 2019-10-04 15:17:29 +0200 | [diff] [blame] | 1205 | video_config.playout_delay_oracle = &playout_delay_oracle; |
| 1206 | video_config.field_trials = &field_trials; |
| 1207 | RTPSenderVideo rtp_sender_video(video_config); |
Mirta Dvornicic | fe68daa | 2019-05-23 13:21:12 +0200 | [diff] [blame] | 1208 | |
| 1209 | // Send a frame. |
| 1210 | RTPVideoHeader video_header; |
Danil Chapovalov | 51bf200 | 2019-10-11 10:53:27 +0200 | [diff] [blame] | 1211 | video_header.frame_type = VideoFrameType::kVideoFrameKey; |
| 1212 | ASSERT_TRUE(rtp_sender_video.SendVideo(kPayloadType, absl::nullopt, 1234, |
| 1213 | 4321, payload, nullptr, video_header, |
| 1214 | kDefaultExpectedRetransmissionTimeMs)); |
Mirta Dvornicic | fe68daa | 2019-05-23 13:21:12 +0200 | [diff] [blame] | 1215 | |
| 1216 | auto sent_payload = transport_.last_sent_packet().payload(); |
| 1217 | EXPECT_THAT(sent_payload, ElementsAreArray(payload)); |
| 1218 | } |
| 1219 | |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 1220 | TEST_P(RtpSenderTest, SendFlexfecPackets) { |
Niels Möller | e7b9e6b | 2019-02-06 18:23:44 +0100 | [diff] [blame] | 1221 | constexpr uint32_t kTimestamp = 1234; |
brandtr | dbdb3f1 | 2016-11-10 05:04:48 -0800 | [diff] [blame] | 1222 | constexpr int kMediaPayloadType = 127; |
Erik Språng | 6cf554e | 2019-10-02 20:55:39 +0200 | [diff] [blame] | 1223 | constexpr VideoCodecType kCodecType = VideoCodecType::kVideoCodecGeneric; |
brandtr | dbdb3f1 | 2016-11-10 05:04:48 -0800 | [diff] [blame] | 1224 | constexpr int kFlexfecPayloadType = 118; |
brandtr | dbdb3f1 | 2016-11-10 05:04:48 -0800 | [diff] [blame] | 1225 | const std::vector<RtpExtension> kNoRtpExtensions; |
erikvarga | 2788373 | 2017-05-17 05:08:38 -0700 | [diff] [blame] | 1226 | const std::vector<RtpExtensionSize> kNoRtpExtensionSizes; |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 1227 | FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexFecSsrc, kSsrc, kNoMid, |
| 1228 | kNoRtpExtensions, kNoRtpExtensionSizes, |
brandtr | 48d21a2 | 2017-05-30 02:32:12 -0700 | [diff] [blame] | 1229 | nullptr /* rtp_state */, &fake_clock_); |
brandtr | dbdb3f1 | 2016-11-10 05:04:48 -0800 | [diff] [blame] | 1230 | |
| 1231 | // Reset |rtp_sender_| to use FlexFEC. |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 1232 | RtpRtcp::Configuration config; |
| 1233 | config.clock = &fake_clock_; |
| 1234 | config.outgoing_transport = &transport_; |
| 1235 | config.paced_sender = &mock_paced_sender_; |
Erik Språng | 54d5d2c | 2019-08-20 17:22:36 +0200 | [diff] [blame] | 1236 | config.local_media_ssrc = kSsrc; |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 1237 | config.flexfec_sender = &flexfec_sender_; |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 1238 | config.event_log = &mock_rtc_event_log_; |
| 1239 | config.send_packet_observer = &send_packet_observer_; |
| 1240 | config.retransmission_rate_limiter = &retransmission_rate_limiter_; |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 1241 | rtp_sender_context_ = std::make_unique<RtpSenderContext>(config); |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 1242 | |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 1243 | rtp_sender()->SetSequenceNumber(kSeqNum); |
| 1244 | rtp_sender_context_->packet_history_.SetStorePacketsStatus( |
| 1245 | RtpPacketHistory::StorageMode::kStoreAndCull, 10); |
brandtr | dbdb3f1 | 2016-11-10 05:04:48 -0800 | [diff] [blame] | 1246 | |
Niels Möller | 5fe9510 | 2019-03-04 16:49:25 +0100 | [diff] [blame] | 1247 | PlayoutDelayOracle playout_delay_oracle; |
Erik Språng | dc34a25 | 2019-10-04 15:17:29 +0200 | [diff] [blame] | 1248 | FieldTrialBasedConfig field_trials; |
| 1249 | RTPSenderVideo::Config video_config; |
| 1250 | video_config.clock = &fake_clock_; |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 1251 | video_config.rtp_sender = rtp_sender(); |
Erik Språng | dc34a25 | 2019-10-04 15:17:29 +0200 | [diff] [blame] | 1252 | video_config.flexfec_sender = &flexfec_sender; |
| 1253 | video_config.playout_delay_oracle = &playout_delay_oracle; |
| 1254 | video_config.field_trials = &field_trials; |
| 1255 | RTPSenderVideo rtp_sender_video(video_config); |
Niels Möller | e7b9e6b | 2019-02-06 18:23:44 +0100 | [diff] [blame] | 1256 | |
brandtr | dbdb3f1 | 2016-11-10 05:04:48 -0800 | [diff] [blame] | 1257 | // Parameters selected to generate a single FEC packet per media packet. |
| 1258 | FecProtectionParams params; |
| 1259 | params.fec_rate = 15; |
| 1260 | params.max_fec_frames = 1; |
| 1261 | params.fec_mask_type = kFecMaskRandom; |
Niels Möller | e7b9e6b | 2019-02-06 18:23:44 +0100 | [diff] [blame] | 1262 | rtp_sender_video.SetFecParameters(params, params); |
brandtr | dbdb3f1 | 2016-11-10 05:04:48 -0800 | [diff] [blame] | 1263 | |
brandtr | 9dfff29 | 2016-11-14 05:14:50 -0800 | [diff] [blame] | 1264 | uint16_t flexfec_seq_num; |
Niels Möller | e7b9e6b | 2019-02-06 18:23:44 +0100 | [diff] [blame] | 1265 | RTPVideoHeader video_header; |
Niels Möller | e7b9e6b | 2019-02-06 18:23:44 +0100 | [diff] [blame] | 1266 | |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 1267 | std::unique_ptr<RtpPacketToSend> media_packet; |
| 1268 | std::unique_ptr<RtpPacketToSend> fec_packet; |
| 1269 | |
Erik Språng | ea55b08 | 2019-10-02 14:57:46 +0200 | [diff] [blame] | 1270 | EXPECT_CALL(mock_paced_sender_, EnqueuePackets) |
Erik Språng | fc78aac | 2019-10-24 12:55:30 +0200 | [diff] [blame] | 1271 | .WillOnce([&](std::vector<std::unique_ptr<RtpPacketToSend>> packets) { |
| 1272 | for (auto& packet : packets) { |
| 1273 | if (packet->packet_type() == RtpPacketToSend::Type::kVideo) { |
| 1274 | EXPECT_EQ(packet->Ssrc(), kSsrc); |
| 1275 | EXPECT_EQ(packet->SequenceNumber(), kSeqNum); |
| 1276 | media_packet = std::move(packet); |
| 1277 | } else { |
| 1278 | EXPECT_EQ(packet->packet_type(), |
| 1279 | RtpPacketToSend::Type::kForwardErrorCorrection); |
| 1280 | EXPECT_EQ(packet->Ssrc(), kFlexFecSsrc); |
| 1281 | fec_packet = std::move(packet); |
| 1282 | } |
| 1283 | } |
| 1284 | }); |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 1285 | |
Danil Chapovalov | 51bf200 | 2019-10-11 10:53:27 +0200 | [diff] [blame] | 1286 | video_header.frame_type = VideoFrameType::kVideoFrameKey; |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 1287 | EXPECT_TRUE(rtp_sender_video.SendVideo( |
Danil Chapovalov | 51bf200 | 2019-10-11 10:53:27 +0200 | [diff] [blame] | 1288 | kMediaPayloadType, kCodecType, kTimestamp, |
| 1289 | fake_clock_.TimeInMilliseconds(), kPayloadData, nullptr, video_header, |
Erik Språng | 6cf554e | 2019-10-02 20:55:39 +0200 | [diff] [blame] | 1290 | kDefaultExpectedRetransmissionTimeMs)); |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 1291 | ASSERT_TRUE(media_packet != nullptr); |
| 1292 | ASSERT_TRUE(fec_packet != nullptr); |
| 1293 | |
| 1294 | flexfec_seq_num = fec_packet->SequenceNumber(); |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 1295 | rtp_egress()->SendPacket(media_packet.get(), PacedPacketInfo()); |
| 1296 | rtp_egress()->SendPacket(fec_packet.get(), PacedPacketInfo()); |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 1297 | |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 1298 | ASSERT_EQ(2, transport_.packets_sent()); |
| 1299 | const RtpPacketReceived& sent_media_packet = transport_.sent_packets_[0]; |
| 1300 | EXPECT_EQ(kMediaPayloadType, sent_media_packet.PayloadType()); |
| 1301 | EXPECT_EQ(kSeqNum, sent_media_packet.SequenceNumber()); |
| 1302 | EXPECT_EQ(kSsrc, sent_media_packet.Ssrc()); |
| 1303 | const RtpPacketReceived& sent_flexfec_packet = transport_.sent_packets_[1]; |
| 1304 | EXPECT_EQ(kFlexfecPayloadType, sent_flexfec_packet.PayloadType()); |
| 1305 | EXPECT_EQ(flexfec_seq_num, sent_flexfec_packet.SequenceNumber()); |
| 1306 | EXPECT_EQ(kFlexFecSsrc, sent_flexfec_packet.Ssrc()); |
brandtr | dbdb3f1 | 2016-11-10 05:04:48 -0800 | [diff] [blame] | 1307 | } |
| 1308 | |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 1309 | TEST_P(RtpSenderTestWithoutPacer, SendFlexfecPackets) { |
Niels Möller | e7b9e6b | 2019-02-06 18:23:44 +0100 | [diff] [blame] | 1310 | constexpr uint32_t kTimestamp = 1234; |
brandtr | dbdb3f1 | 2016-11-10 05:04:48 -0800 | [diff] [blame] | 1311 | constexpr int kMediaPayloadType = 127; |
Erik Språng | 6cf554e | 2019-10-02 20:55:39 +0200 | [diff] [blame] | 1312 | constexpr VideoCodecType kCodecType = VideoCodecType::kVideoCodecGeneric; |
brandtr | dbdb3f1 | 2016-11-10 05:04:48 -0800 | [diff] [blame] | 1313 | constexpr int kFlexfecPayloadType = 118; |
brandtr | dbdb3f1 | 2016-11-10 05:04:48 -0800 | [diff] [blame] | 1314 | const std::vector<RtpExtension> kNoRtpExtensions; |
erikvarga | 2788373 | 2017-05-17 05:08:38 -0700 | [diff] [blame] | 1315 | const std::vector<RtpExtensionSize> kNoRtpExtensionSizes; |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 1316 | FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexFecSsrc, kSsrc, kNoMid, |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 1317 | kNoRtpExtensions, kNoRtpExtensionSizes, |
brandtr | 48d21a2 | 2017-05-30 02:32:12 -0700 | [diff] [blame] | 1318 | nullptr /* rtp_state */, &fake_clock_); |
brandtr | dbdb3f1 | 2016-11-10 05:04:48 -0800 | [diff] [blame] | 1319 | |
| 1320 | // Reset |rtp_sender_| to use FlexFEC. |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 1321 | RtpRtcp::Configuration config; |
| 1322 | config.clock = &fake_clock_; |
| 1323 | config.outgoing_transport = &transport_; |
Erik Språng | 54d5d2c | 2019-08-20 17:22:36 +0200 | [diff] [blame] | 1324 | config.local_media_ssrc = kSsrc; |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 1325 | config.flexfec_sender = &flexfec_sender; |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 1326 | config.event_log = &mock_rtc_event_log_; |
| 1327 | config.send_packet_observer = &send_packet_observer_; |
| 1328 | config.retransmission_rate_limiter = &retransmission_rate_limiter_; |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 1329 | rtp_sender_context_ = std::make_unique<RtpSenderContext>(config); |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 1330 | |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 1331 | rtp_sender()->SetSequenceNumber(kSeqNum); |
brandtr | dbdb3f1 | 2016-11-10 05:04:48 -0800 | [diff] [blame] | 1332 | |
Niels Möller | 5fe9510 | 2019-03-04 16:49:25 +0100 | [diff] [blame] | 1333 | PlayoutDelayOracle playout_delay_oracle; |
Erik Språng | dc34a25 | 2019-10-04 15:17:29 +0200 | [diff] [blame] | 1334 | FieldTrialBasedConfig field_trials; |
| 1335 | RTPSenderVideo::Config video_config; |
| 1336 | video_config.clock = &fake_clock_; |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 1337 | video_config.rtp_sender = rtp_sender(); |
Erik Språng | dc34a25 | 2019-10-04 15:17:29 +0200 | [diff] [blame] | 1338 | video_config.flexfec_sender = &flexfec_sender; |
| 1339 | video_config.playout_delay_oracle = &playout_delay_oracle; |
| 1340 | video_config.field_trials = &field_trials; |
| 1341 | RTPSenderVideo rtp_sender_video(video_config); |
Niels Möller | e7b9e6b | 2019-02-06 18:23:44 +0100 | [diff] [blame] | 1342 | |
brandtr | dbdb3f1 | 2016-11-10 05:04:48 -0800 | [diff] [blame] | 1343 | // Parameters selected to generate a single FEC packet per media packet. |
| 1344 | FecProtectionParams params; |
| 1345 | params.fec_rate = 15; |
| 1346 | params.max_fec_frames = 1; |
| 1347 | params.fec_mask_type = kFecMaskRandom; |
Niels Möller | e7b9e6b | 2019-02-06 18:23:44 +0100 | [diff] [blame] | 1348 | rtp_sender_video.SetFecParameters(params, params); |
brandtr | dbdb3f1 | 2016-11-10 05:04:48 -0800 | [diff] [blame] | 1349 | |
Elad Alon | 4a87e1c | 2017-10-03 16:11:34 +0200 | [diff] [blame] | 1350 | EXPECT_CALL(mock_rtc_event_log_, |
| 1351 | LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing))) |
| 1352 | .Times(2); |
Niels Möller | e7b9e6b | 2019-02-06 18:23:44 +0100 | [diff] [blame] | 1353 | RTPVideoHeader video_header; |
Danil Chapovalov | 51bf200 | 2019-10-11 10:53:27 +0200 | [diff] [blame] | 1354 | video_header.frame_type = VideoFrameType::kVideoFrameKey; |
Niels Möller | e7b9e6b | 2019-02-06 18:23:44 +0100 | [diff] [blame] | 1355 | EXPECT_TRUE(rtp_sender_video.SendVideo( |
Danil Chapovalov | 51bf200 | 2019-10-11 10:53:27 +0200 | [diff] [blame] | 1356 | kMediaPayloadType, kCodecType, kTimestamp, |
| 1357 | fake_clock_.TimeInMilliseconds(), kPayloadData, nullptr, video_header, |
| 1358 | kDefaultExpectedRetransmissionTimeMs)); |
Niels Möller | e7b9e6b | 2019-02-06 18:23:44 +0100 | [diff] [blame] | 1359 | |
brandtr | dbdb3f1 | 2016-11-10 05:04:48 -0800 | [diff] [blame] | 1360 | ASSERT_EQ(2, transport_.packets_sent()); |
| 1361 | const RtpPacketReceived& media_packet = transport_.sent_packets_[0]; |
| 1362 | EXPECT_EQ(kMediaPayloadType, media_packet.PayloadType()); |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 1363 | EXPECT_EQ(kSsrc, media_packet.Ssrc()); |
brandtr | dbdb3f1 | 2016-11-10 05:04:48 -0800 | [diff] [blame] | 1364 | const RtpPacketReceived& flexfec_packet = transport_.sent_packets_[1]; |
| 1365 | EXPECT_EQ(kFlexfecPayloadType, flexfec_packet.PayloadType()); |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 1366 | EXPECT_EQ(kFlexFecSsrc, flexfec_packet.Ssrc()); |
brandtr | dbdb3f1 | 2016-11-10 05:04:48 -0800 | [diff] [blame] | 1367 | } |
| 1368 | |
Steve Anton | 296a0ce | 2018-03-22 15:17:27 -0700 | [diff] [blame] | 1369 | // Test that the MID header extension is included on sent packets when |
| 1370 | // configured. |
| 1371 | TEST_P(RtpSenderTestWithoutPacer, MidIncludedOnSentPackets) { |
| 1372 | const char kMid[] = "mid"; |
| 1373 | |
Steve Anton | 2bac7da | 2019-07-21 15:04:21 -0400 | [diff] [blame] | 1374 | EnableMidSending(kMid); |
Steve Anton | 296a0ce | 2018-03-22 15:17:27 -0700 | [diff] [blame] | 1375 | |
| 1376 | // Send a couple packets. |
Niels Möller | e7b9e6b | 2019-02-06 18:23:44 +0100 | [diff] [blame] | 1377 | SendGenericPacket(); |
| 1378 | SendGenericPacket(); |
Steve Anton | 296a0ce | 2018-03-22 15:17:27 -0700 | [diff] [blame] | 1379 | |
| 1380 | // Expect both packets to have the MID set. |
| 1381 | ASSERT_EQ(2u, transport_.sent_packets_.size()); |
| 1382 | for (const RtpPacketReceived& packet : transport_.sent_packets_) { |
| 1383 | std::string mid; |
| 1384 | ASSERT_TRUE(packet.GetExtension<RtpMid>(&mid)); |
| 1385 | EXPECT_EQ(kMid, mid); |
| 1386 | } |
| 1387 | } |
| 1388 | |
Amit Hilbuch | 77938e6 | 2018-12-21 09:23:38 -0800 | [diff] [blame] | 1389 | TEST_P(RtpSenderTestWithoutPacer, RidIncludedOnSentPackets) { |
| 1390 | const char kRid[] = "f"; |
| 1391 | |
Steve Anton | 2bac7da | 2019-07-21 15:04:21 -0400 | [diff] [blame] | 1392 | EnableRidSending(kRid); |
Amit Hilbuch | 77938e6 | 2018-12-21 09:23:38 -0800 | [diff] [blame] | 1393 | |
Niels Möller | e7b9e6b | 2019-02-06 18:23:44 +0100 | [diff] [blame] | 1394 | SendGenericPacket(); |
Amit Hilbuch | 77938e6 | 2018-12-21 09:23:38 -0800 | [diff] [blame] | 1395 | |
| 1396 | ASSERT_EQ(1u, transport_.sent_packets_.size()); |
| 1397 | const RtpPacketReceived& packet = transport_.sent_packets_[0]; |
| 1398 | std::string rid; |
| 1399 | ASSERT_TRUE(packet.GetExtension<RtpStreamId>(&rid)); |
| 1400 | EXPECT_EQ(kRid, rid); |
| 1401 | } |
| 1402 | |
| 1403 | TEST_P(RtpSenderTestWithoutPacer, RidIncludedOnRtxSentPackets) { |
| 1404 | const char kRid[] = "f"; |
Amit Hilbuch | 77938e6 | 2018-12-21 09:23:38 -0800 | [diff] [blame] | 1405 | |
Steve Anton | 2bac7da | 2019-07-21 15:04:21 -0400 | [diff] [blame] | 1406 | EnableRtx(); |
| 1407 | EnableRidSending(kRid); |
Amit Hilbuch | 77938e6 | 2018-12-21 09:23:38 -0800 | [diff] [blame] | 1408 | |
Niels Möller | e7b9e6b | 2019-02-06 18:23:44 +0100 | [diff] [blame] | 1409 | SendGenericPacket(); |
Amit Hilbuch | 77938e6 | 2018-12-21 09:23:38 -0800 | [diff] [blame] | 1410 | ASSERT_EQ(1u, transport_.sent_packets_.size()); |
| 1411 | const RtpPacketReceived& packet = transport_.sent_packets_[0]; |
| 1412 | std::string rid; |
| 1413 | ASSERT_TRUE(packet.GetExtension<RtpStreamId>(&rid)); |
| 1414 | EXPECT_EQ(kRid, rid); |
| 1415 | rid = kNoRid; |
Steve Anton | 2bac7da | 2019-07-21 15:04:21 -0400 | [diff] [blame] | 1416 | EXPECT_FALSE(packet.HasExtension<RepairedRtpStreamId>()); |
Amit Hilbuch | 77938e6 | 2018-12-21 09:23:38 -0800 | [diff] [blame] | 1417 | |
| 1418 | uint16_t packet_id = packet.SequenceNumber(); |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 1419 | rtp_sender()->ReSendPacket(packet_id); |
Amit Hilbuch | 77938e6 | 2018-12-21 09:23:38 -0800 | [diff] [blame] | 1420 | ASSERT_EQ(2u, transport_.sent_packets_.size()); |
| 1421 | const RtpPacketReceived& rtx_packet = transport_.sent_packets_[1]; |
| 1422 | ASSERT_TRUE(rtx_packet.GetExtension<RepairedRtpStreamId>(&rid)); |
| 1423 | EXPECT_EQ(kRid, rid); |
| 1424 | EXPECT_FALSE(rtx_packet.HasExtension<RtpStreamId>()); |
| 1425 | } |
| 1426 | |
Steve Anton | 2bac7da | 2019-07-21 15:04:21 -0400 | [diff] [blame] | 1427 | TEST_P(RtpSenderTestWithoutPacer, MidAndRidNotIncludedOnSentPacketsAfterAck) { |
| 1428 | const char kMid[] = "mid"; |
| 1429 | const char kRid[] = "f"; |
| 1430 | |
| 1431 | EnableMidSending(kMid); |
| 1432 | EnableRidSending(kRid); |
| 1433 | |
| 1434 | // This first packet should include both MID and RID. |
| 1435 | auto first_built_packet = SendGenericPacket(); |
| 1436 | |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 1437 | rtp_sender()->OnReceivedAckOnSsrc(first_built_packet->SequenceNumber()); |
Steve Anton | 2bac7da | 2019-07-21 15:04:21 -0400 | [diff] [blame] | 1438 | |
| 1439 | // The second packet should include neither since an ack was received. |
| 1440 | SendGenericPacket(); |
| 1441 | |
| 1442 | ASSERT_EQ(2u, transport_.sent_packets_.size()); |
| 1443 | |
| 1444 | const RtpPacketReceived& first_packet = transport_.sent_packets_[0]; |
| 1445 | std::string mid, rid; |
| 1446 | ASSERT_TRUE(first_packet.GetExtension<RtpMid>(&mid)); |
| 1447 | EXPECT_EQ(kMid, mid); |
| 1448 | ASSERT_TRUE(first_packet.GetExtension<RtpStreamId>(&rid)); |
| 1449 | EXPECT_EQ(kRid, rid); |
| 1450 | |
| 1451 | const RtpPacketReceived& second_packet = transport_.sent_packets_[1]; |
| 1452 | EXPECT_FALSE(second_packet.HasExtension<RtpMid>()); |
| 1453 | EXPECT_FALSE(second_packet.HasExtension<RtpStreamId>()); |
| 1454 | } |
| 1455 | |
| 1456 | // Test that the first RTX packet includes both MID and RRID even if the packet |
| 1457 | // being retransmitted did not have MID or RID. The MID and RID are needed on |
| 1458 | // the first packets for a given SSRC, and RTX packets are sent on a separate |
| 1459 | // SSRC. |
| 1460 | TEST_P(RtpSenderTestWithoutPacer, MidAndRidIncludedOnFirstRtxPacket) { |
| 1461 | const char kMid[] = "mid"; |
| 1462 | const char kRid[] = "f"; |
| 1463 | |
| 1464 | EnableRtx(); |
| 1465 | EnableMidSending(kMid); |
| 1466 | EnableRidSending(kRid); |
| 1467 | |
| 1468 | // This first packet will include both MID and RID. |
| 1469 | auto first_built_packet = SendGenericPacket(); |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 1470 | rtp_sender()->OnReceivedAckOnSsrc(first_built_packet->SequenceNumber()); |
Steve Anton | 2bac7da | 2019-07-21 15:04:21 -0400 | [diff] [blame] | 1471 | |
| 1472 | // The second packet will include neither since an ack was received. |
| 1473 | auto second_built_packet = SendGenericPacket(); |
| 1474 | |
| 1475 | // The first RTX packet should include MID and RRID. |
| 1476 | ASSERT_LT(0, |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 1477 | rtp_sender()->ReSendPacket(second_built_packet->SequenceNumber())); |
Steve Anton | 2bac7da | 2019-07-21 15:04:21 -0400 | [diff] [blame] | 1478 | |
| 1479 | ASSERT_EQ(3u, transport_.sent_packets_.size()); |
| 1480 | |
| 1481 | const RtpPacketReceived& rtx_packet = transport_.sent_packets_[2]; |
| 1482 | std::string mid, rrid; |
| 1483 | ASSERT_TRUE(rtx_packet.GetExtension<RtpMid>(&mid)); |
| 1484 | EXPECT_EQ(kMid, mid); |
| 1485 | ASSERT_TRUE(rtx_packet.GetExtension<RepairedRtpStreamId>(&rrid)); |
| 1486 | EXPECT_EQ(kRid, rrid); |
| 1487 | } |
| 1488 | |
| 1489 | // Test that the RTX packets sent after receving an ACK on the RTX SSRC does |
| 1490 | // not include either MID or RRID even if the packet being retransmitted did |
| 1491 | // had a MID or RID. |
| 1492 | TEST_P(RtpSenderTestWithoutPacer, MidAndRidNotIncludedOnRtxPacketsAfterAck) { |
| 1493 | const char kMid[] = "mid"; |
| 1494 | const char kRid[] = "f"; |
| 1495 | |
| 1496 | EnableRtx(); |
| 1497 | EnableMidSending(kMid); |
| 1498 | EnableRidSending(kRid); |
| 1499 | |
| 1500 | // This first packet will include both MID and RID. |
| 1501 | auto first_built_packet = SendGenericPacket(); |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 1502 | rtp_sender()->OnReceivedAckOnSsrc(first_built_packet->SequenceNumber()); |
Steve Anton | 2bac7da | 2019-07-21 15:04:21 -0400 | [diff] [blame] | 1503 | |
| 1504 | // The second packet will include neither since an ack was received. |
| 1505 | auto second_built_packet = SendGenericPacket(); |
| 1506 | |
| 1507 | // The first RTX packet will include MID and RRID. |
| 1508 | ASSERT_LT(0, |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 1509 | rtp_sender()->ReSendPacket(second_built_packet->SequenceNumber())); |
Steve Anton | 2bac7da | 2019-07-21 15:04:21 -0400 | [diff] [blame] | 1510 | |
| 1511 | ASSERT_EQ(3u, transport_.sent_packets_.size()); |
| 1512 | const RtpPacketReceived& first_rtx_packet = transport_.sent_packets_[2]; |
| 1513 | |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 1514 | rtp_sender()->OnReceivedAckOnRtxSsrc(first_rtx_packet.SequenceNumber()); |
Steve Anton | 2bac7da | 2019-07-21 15:04:21 -0400 | [diff] [blame] | 1515 | |
| 1516 | // The second and third RTX packets should not include MID nor RRID. |
Steve Anton | 2bac7da | 2019-07-21 15:04:21 -0400 | [diff] [blame] | 1517 | ASSERT_LT(0, |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 1518 | rtp_sender()->ReSendPacket(first_built_packet->SequenceNumber())); |
| 1519 | ASSERT_LT(0, |
| 1520 | rtp_sender()->ReSendPacket(second_built_packet->SequenceNumber())); |
Steve Anton | 2bac7da | 2019-07-21 15:04:21 -0400 | [diff] [blame] | 1521 | |
| 1522 | ASSERT_EQ(5u, transport_.sent_packets_.size()); |
| 1523 | |
| 1524 | const RtpPacketReceived& second_rtx_packet = transport_.sent_packets_[3]; |
| 1525 | EXPECT_FALSE(second_rtx_packet.HasExtension<RtpMid>()); |
| 1526 | EXPECT_FALSE(second_rtx_packet.HasExtension<RepairedRtpStreamId>()); |
| 1527 | |
| 1528 | const RtpPacketReceived& third_rtx_packet = transport_.sent_packets_[4]; |
| 1529 | EXPECT_FALSE(third_rtx_packet.HasExtension<RtpMid>()); |
| 1530 | EXPECT_FALSE(third_rtx_packet.HasExtension<RepairedRtpStreamId>()); |
| 1531 | } |
| 1532 | |
| 1533 | // Test that if the RtpState indicates an ACK has been received on that SSRC |
| 1534 | // then neither the MID nor RID header extensions will be sent. |
| 1535 | TEST_P(RtpSenderTestWithoutPacer, |
| 1536 | MidAndRidNotIncludedOnSentPacketsAfterRtpStateRestored) { |
| 1537 | const char kMid[] = "mid"; |
| 1538 | const char kRid[] = "f"; |
| 1539 | |
| 1540 | EnableMidSending(kMid); |
| 1541 | EnableRidSending(kRid); |
| 1542 | |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 1543 | RtpState state = rtp_sender()->GetRtpState(); |
Steve Anton | 2bac7da | 2019-07-21 15:04:21 -0400 | [diff] [blame] | 1544 | EXPECT_FALSE(state.ssrc_has_acked); |
| 1545 | state.ssrc_has_acked = true; |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 1546 | rtp_sender()->SetRtpState(state); |
Steve Anton | 2bac7da | 2019-07-21 15:04:21 -0400 | [diff] [blame] | 1547 | |
| 1548 | SendGenericPacket(); |
| 1549 | |
| 1550 | ASSERT_EQ(1u, transport_.sent_packets_.size()); |
| 1551 | const RtpPacketReceived& packet = transport_.sent_packets_[0]; |
| 1552 | EXPECT_FALSE(packet.HasExtension<RtpMid>()); |
| 1553 | EXPECT_FALSE(packet.HasExtension<RtpStreamId>()); |
| 1554 | } |
| 1555 | |
| 1556 | // Test that if the RTX RtpState indicates an ACK has been received on that |
| 1557 | // RTX SSRC then neither the MID nor RRID header extensions will be sent on |
| 1558 | // RTX packets. |
| 1559 | TEST_P(RtpSenderTestWithoutPacer, |
| 1560 | MidAndRridNotIncludedOnRtxPacketsAfterRtpStateRestored) { |
| 1561 | const char kMid[] = "mid"; |
| 1562 | const char kRid[] = "f"; |
| 1563 | |
| 1564 | EnableRtx(); |
| 1565 | EnableMidSending(kMid); |
| 1566 | EnableRidSending(kRid); |
| 1567 | |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 1568 | RtpState rtx_state = rtp_sender()->GetRtxRtpState(); |
Steve Anton | 2bac7da | 2019-07-21 15:04:21 -0400 | [diff] [blame] | 1569 | EXPECT_FALSE(rtx_state.ssrc_has_acked); |
| 1570 | rtx_state.ssrc_has_acked = true; |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 1571 | rtp_sender()->SetRtxRtpState(rtx_state); |
Steve Anton | 2bac7da | 2019-07-21 15:04:21 -0400 | [diff] [blame] | 1572 | |
| 1573 | auto built_packet = SendGenericPacket(); |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 1574 | ASSERT_LT(0, rtp_sender()->ReSendPacket(built_packet->SequenceNumber())); |
Steve Anton | 2bac7da | 2019-07-21 15:04:21 -0400 | [diff] [blame] | 1575 | |
| 1576 | ASSERT_EQ(2u, transport_.sent_packets_.size()); |
| 1577 | const RtpPacketReceived& rtx_packet = transport_.sent_packets_[1]; |
| 1578 | EXPECT_FALSE(rtx_packet.HasExtension<RtpMid>()); |
| 1579 | EXPECT_FALSE(rtx_packet.HasExtension<RepairedRtpStreamId>()); |
| 1580 | } |
| 1581 | |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 1582 | TEST_P(RtpSenderTest, FecOverheadRate) { |
Niels Möller | e7b9e6b | 2019-02-06 18:23:44 +0100 | [diff] [blame] | 1583 | constexpr uint32_t kTimestamp = 1234; |
| 1584 | constexpr int kMediaPayloadType = 127; |
Erik Språng | 6cf554e | 2019-10-02 20:55:39 +0200 | [diff] [blame] | 1585 | constexpr VideoCodecType kCodecType = VideoCodecType::kVideoCodecGeneric; |
brandtr | 81eab61 | 2017-01-24 04:06:09 -0800 | [diff] [blame] | 1586 | constexpr int kFlexfecPayloadType = 118; |
brandtr | 81eab61 | 2017-01-24 04:06:09 -0800 | [diff] [blame] | 1587 | const std::vector<RtpExtension> kNoRtpExtensions; |
erikvarga | 2788373 | 2017-05-17 05:08:38 -0700 | [diff] [blame] | 1588 | const std::vector<RtpExtensionSize> kNoRtpExtensionSizes; |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 1589 | FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexFecSsrc, kSsrc, kNoMid, |
| 1590 | kNoRtpExtensions, kNoRtpExtensionSizes, |
brandtr | 48d21a2 | 2017-05-30 02:32:12 -0700 | [diff] [blame] | 1591 | nullptr /* rtp_state */, &fake_clock_); |
brandtr | 81eab61 | 2017-01-24 04:06:09 -0800 | [diff] [blame] | 1592 | |
| 1593 | // Reset |rtp_sender_| to use FlexFEC. |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 1594 | RtpRtcp::Configuration config; |
| 1595 | config.clock = &fake_clock_; |
| 1596 | config.outgoing_transport = &transport_; |
| 1597 | config.paced_sender = &mock_paced_sender_; |
Erik Språng | 54d5d2c | 2019-08-20 17:22:36 +0200 | [diff] [blame] | 1598 | config.local_media_ssrc = kSsrc; |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 1599 | config.flexfec_sender = &flexfec_sender; |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 1600 | config.event_log = &mock_rtc_event_log_; |
| 1601 | config.send_packet_observer = &send_packet_observer_; |
| 1602 | config.retransmission_rate_limiter = &retransmission_rate_limiter_; |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 1603 | rtp_sender_context_ = std::make_unique<RtpSenderContext>(config); |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 1604 | |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 1605 | rtp_sender()->SetSequenceNumber(kSeqNum); |
brandtr | 81eab61 | 2017-01-24 04:06:09 -0800 | [diff] [blame] | 1606 | |
Niels Möller | 5fe9510 | 2019-03-04 16:49:25 +0100 | [diff] [blame] | 1607 | PlayoutDelayOracle playout_delay_oracle; |
Erik Språng | dc34a25 | 2019-10-04 15:17:29 +0200 | [diff] [blame] | 1608 | FieldTrialBasedConfig field_trials; |
| 1609 | RTPSenderVideo::Config video_config; |
| 1610 | video_config.clock = &fake_clock_; |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 1611 | video_config.rtp_sender = rtp_sender(); |
Erik Språng | dc34a25 | 2019-10-04 15:17:29 +0200 | [diff] [blame] | 1612 | video_config.flexfec_sender = &flexfec_sender; |
| 1613 | video_config.playout_delay_oracle = &playout_delay_oracle; |
| 1614 | video_config.field_trials = &field_trials; |
| 1615 | RTPSenderVideo rtp_sender_video(video_config); |
brandtr | 81eab61 | 2017-01-24 04:06:09 -0800 | [diff] [blame] | 1616 | // Parameters selected to generate a single FEC packet per media packet. |
| 1617 | FecProtectionParams params; |
| 1618 | params.fec_rate = 15; |
| 1619 | params.max_fec_frames = 1; |
| 1620 | params.fec_mask_type = kFecMaskRandom; |
Niels Möller | e7b9e6b | 2019-02-06 18:23:44 +0100 | [diff] [blame] | 1621 | rtp_sender_video.SetFecParameters(params, params); |
brandtr | 81eab61 | 2017-01-24 04:06:09 -0800 | [diff] [blame] | 1622 | |
| 1623 | constexpr size_t kNumMediaPackets = 10; |
| 1624 | constexpr size_t kNumFecPackets = kNumMediaPackets; |
| 1625 | constexpr int64_t kTimeBetweenPacketsMs = 10; |
Erik Språng | fc78aac | 2019-10-24 12:55:30 +0200 | [diff] [blame] | 1626 | EXPECT_CALL(mock_paced_sender_, EnqueuePackets).Times(kNumMediaPackets); |
brandtr | 81eab61 | 2017-01-24 04:06:09 -0800 | [diff] [blame] | 1627 | for (size_t i = 0; i < kNumMediaPackets; ++i) { |
Niels Möller | e7b9e6b | 2019-02-06 18:23:44 +0100 | [diff] [blame] | 1628 | RTPVideoHeader video_header; |
| 1629 | |
Danil Chapovalov | 51bf200 | 2019-10-11 10:53:27 +0200 | [diff] [blame] | 1630 | video_header.frame_type = VideoFrameType::kVideoFrameKey; |
Niels Möller | e7b9e6b | 2019-02-06 18:23:44 +0100 | [diff] [blame] | 1631 | EXPECT_TRUE(rtp_sender_video.SendVideo( |
Danil Chapovalov | 51bf200 | 2019-10-11 10:53:27 +0200 | [diff] [blame] | 1632 | kMediaPayloadType, kCodecType, kTimestamp, |
| 1633 | fake_clock_.TimeInMilliseconds(), kPayloadData, nullptr, video_header, |
Erik Språng | 6cf554e | 2019-10-02 20:55:39 +0200 | [diff] [blame] | 1634 | kDefaultExpectedRetransmissionTimeMs)); |
Niels Möller | e7b9e6b | 2019-02-06 18:23:44 +0100 | [diff] [blame] | 1635 | |
brandtr | 81eab61 | 2017-01-24 04:06:09 -0800 | [diff] [blame] | 1636 | fake_clock_.AdvanceTimeMilliseconds(kTimeBetweenPacketsMs); |
| 1637 | } |
| 1638 | constexpr size_t kRtpHeaderLength = 12; |
| 1639 | constexpr size_t kFlexfecHeaderLength = 20; |
| 1640 | constexpr size_t kGenericCodecHeaderLength = 1; |
| 1641 | constexpr size_t kPayloadLength = sizeof(kPayloadData); |
| 1642 | constexpr size_t kPacketLength = kRtpHeaderLength + kFlexfecHeaderLength + |
| 1643 | kGenericCodecHeaderLength + kPayloadLength; |
| 1644 | EXPECT_NEAR(kNumFecPackets * kPacketLength * 8 / |
| 1645 | (kNumFecPackets * kTimeBetweenPacketsMs / 1000.0f), |
Niels Möller | e7b9e6b | 2019-02-06 18:23:44 +0100 | [diff] [blame] | 1646 | rtp_sender_video.FecOverheadRate(), 500); |
brandtr | 81eab61 | 2017-01-24 04:06:09 -0800 | [diff] [blame] | 1647 | } |
| 1648 | |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 1649 | TEST_P(RtpSenderTest, BitrateCallbacks) { |
sprang@webrtc.org | 6811b6e | 2013-12-13 09:46:59 +0000 | [diff] [blame] | 1650 | class TestCallback : public BitrateStatisticsObserver { |
| 1651 | public: |
sprang | cd349d9 | 2016-07-13 09:11:28 -0700 | [diff] [blame] | 1652 | TestCallback() |
| 1653 | : BitrateStatisticsObserver(), |
| 1654 | num_calls_(0), |
| 1655 | ssrc_(0), |
| 1656 | total_bitrate_(0), |
| 1657 | retransmit_bitrate_(0) {} |
Danil Chapovalov | dd7e284 | 2018-03-09 15:37:03 +0000 | [diff] [blame] | 1658 | ~TestCallback() override = default; |
sprang@webrtc.org | 6811b6e | 2013-12-13 09:46:59 +0000 | [diff] [blame] | 1659 | |
sprang | cd349d9 | 2016-07-13 09:11:28 -0700 | [diff] [blame] | 1660 | void Notify(uint32_t total_bitrate, |
| 1661 | uint32_t retransmit_bitrate, |
kjellander@webrtc.org | 14665ff | 2015-03-04 12:58:35 +0000 | [diff] [blame] | 1662 | uint32_t ssrc) override { |
sprang@webrtc.org | 6811b6e | 2013-12-13 09:46:59 +0000 | [diff] [blame] | 1663 | ++num_calls_; |
| 1664 | ssrc_ = ssrc; |
sprang | cd349d9 | 2016-07-13 09:11:28 -0700 | [diff] [blame] | 1665 | total_bitrate_ = total_bitrate; |
| 1666 | retransmit_bitrate_ = retransmit_bitrate; |
sprang@webrtc.org | 6811b6e | 2013-12-13 09:46:59 +0000 | [diff] [blame] | 1667 | } |
| 1668 | |
| 1669 | uint32_t num_calls_; |
| 1670 | uint32_t ssrc_; |
sprang | cd349d9 | 2016-07-13 09:11:28 -0700 | [diff] [blame] | 1671 | uint32_t total_bitrate_; |
| 1672 | uint32_t retransmit_bitrate_; |
sprang@webrtc.org | 6811b6e | 2013-12-13 09:46:59 +0000 | [diff] [blame] | 1673 | } callback; |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 1674 | |
| 1675 | RtpRtcp::Configuration config; |
| 1676 | config.clock = &fake_clock_; |
| 1677 | config.outgoing_transport = &transport_; |
Erik Språng | 54d5d2c | 2019-08-20 17:22:36 +0200 | [diff] [blame] | 1678 | config.local_media_ssrc = kSsrc; |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 1679 | config.send_bitrate_observer = &callback; |
| 1680 | config.retransmission_rate_limiter = &retransmission_rate_limiter_; |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 1681 | rtp_sender_context_ = std::make_unique<RtpSenderContext>(config); |
sprang@webrtc.org | 6811b6e | 2013-12-13 09:46:59 +0000 | [diff] [blame] | 1682 | |
Niels Möller | 5fe9510 | 2019-03-04 16:49:25 +0100 | [diff] [blame] | 1683 | PlayoutDelayOracle playout_delay_oracle; |
Erik Språng | dc34a25 | 2019-10-04 15:17:29 +0200 | [diff] [blame] | 1684 | FieldTrialBasedConfig field_trials; |
| 1685 | RTPSenderVideo::Config video_config; |
| 1686 | video_config.clock = &fake_clock_; |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 1687 | video_config.rtp_sender = rtp_sender(); |
Erik Språng | dc34a25 | 2019-10-04 15:17:29 +0200 | [diff] [blame] | 1688 | video_config.playout_delay_oracle = &playout_delay_oracle; |
| 1689 | video_config.field_trials = &field_trials; |
| 1690 | RTPSenderVideo rtp_sender_video(video_config); |
Erik Språng | 6cf554e | 2019-10-02 20:55:39 +0200 | [diff] [blame] | 1691 | const VideoCodecType kCodecType = VideoCodecType::kVideoCodecGeneric; |
| 1692 | const uint8_t kPayloadType = 127; |
Niels Möller | 59ab1cf | 2019-02-06 22:48:11 +0100 | [diff] [blame] | 1693 | |
sprang | cd349d9 | 2016-07-13 09:11:28 -0700 | [diff] [blame] | 1694 | // Simulate kNumPackets sent with kPacketInterval ms intervals, with the |
| 1695 | // number of packets selected so that we fill (but don't overflow) the one |
| 1696 | // second averaging window. |
| 1697 | const uint32_t kWindowSizeMs = 1000; |
sprang@webrtc.org | 6811b6e | 2013-12-13 09:46:59 +0000 | [diff] [blame] | 1698 | const uint32_t kPacketInterval = 20; |
sprang | cd349d9 | 2016-07-13 09:11:28 -0700 | [diff] [blame] | 1699 | const uint32_t kNumPackets = |
| 1700 | (kWindowSizeMs - kPacketInterval) / kPacketInterval; |
sprang@webrtc.org | 6811b6e | 2013-12-13 09:46:59 +0000 | [diff] [blame] | 1701 | // Overhead = 12 bytes RTP header + 1 byte generic header. |
| 1702 | const uint32_t kPacketOverhead = 13; |
| 1703 | |
sprang@webrtc.org | 6811b6e | 2013-12-13 09:46:59 +0000 | [diff] [blame] | 1704 | uint8_t payload[] = {47, 11, 32, 93, 89}; |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 1705 | rtp_sender_context_->packet_history_.SetStorePacketsStatus( |
| 1706 | RtpPacketHistory::StorageMode::kStoreAndCull, 1); |
| 1707 | uint32_t ssrc = rtp_sender()->SSRC(); |
sprang@webrtc.org | 6811b6e | 2013-12-13 09:46:59 +0000 | [diff] [blame] | 1708 | |
sprang@webrtc.org | 6811b6e | 2013-12-13 09:46:59 +0000 | [diff] [blame] | 1709 | // Initial process call so we get a new time window. |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 1710 | rtp_egress()->ProcessBitrateAndNotifyObservers(); |
sprang@webrtc.org | 6811b6e | 2013-12-13 09:46:59 +0000 | [diff] [blame] | 1711 | |
| 1712 | // Send a few frames. |
Sami Kalliomäki | 426a80c | 2018-08-08 11:37:59 +0200 | [diff] [blame] | 1713 | RTPVideoHeader video_header; |
sprang@webrtc.org | 6811b6e | 2013-12-13 09:46:59 +0000 | [diff] [blame] | 1714 | for (uint32_t i = 0; i < kNumPackets; ++i) { |
Danil Chapovalov | 51bf200 | 2019-10-11 10:53:27 +0200 | [diff] [blame] | 1715 | video_header.frame_type = VideoFrameType::kVideoFrameKey; |
Niels Möller | 59ab1cf | 2019-02-06 22:48:11 +0100 | [diff] [blame] | 1716 | ASSERT_TRUE(rtp_sender_video.SendVideo( |
Danil Chapovalov | 51bf200 | 2019-10-11 10:53:27 +0200 | [diff] [blame] | 1717 | kPayloadType, kCodecType, 1234, 4321, payload, nullptr, video_header, |
Niels Möller | 8f7ce22 | 2019-03-21 15:43:58 +0100 | [diff] [blame] | 1718 | kDefaultExpectedRetransmissionTimeMs)); |
sprang@webrtc.org | 6811b6e | 2013-12-13 09:46:59 +0000 | [diff] [blame] | 1719 | fake_clock_.AdvanceTimeMilliseconds(kPacketInterval); |
| 1720 | } |
| 1721 | |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 1722 | rtp_egress()->ProcessBitrateAndNotifyObservers(); |
sprang@webrtc.org | 6811b6e | 2013-12-13 09:46:59 +0000 | [diff] [blame] | 1723 | |
stefan@webrtc.org | 0bae1fa | 2014-11-05 14:05:29 +0000 | [diff] [blame] | 1724 | // We get one call for every stats updated, thus two calls since both the |
| 1725 | // stream stats and the retransmit stats are updated once. |
| 1726 | EXPECT_EQ(2u, callback.num_calls_); |
sprang@webrtc.org | 6811b6e | 2013-12-13 09:46:59 +0000 | [diff] [blame] | 1727 | EXPECT_EQ(ssrc, callback.ssrc_); |
sprang | cd349d9 | 2016-07-13 09:11:28 -0700 | [diff] [blame] | 1728 | const uint32_t kTotalPacketSize = kPacketOverhead + sizeof(payload); |
| 1729 | // Bitrate measured over delta between last and first timestamp, plus one. |
| 1730 | const uint32_t kExpectedWindowMs = kNumPackets * kPacketInterval + 1; |
| 1731 | const uint32_t kExpectedBitsAccumulated = kTotalPacketSize * kNumPackets * 8; |
| 1732 | const uint32_t kExpectedRateBps = |
| 1733 | (kExpectedBitsAccumulated * 1000 + (kExpectedWindowMs / 2)) / |
| 1734 | kExpectedWindowMs; |
| 1735 | EXPECT_EQ(kExpectedRateBps, callback.total_bitrate_); |
sprang@webrtc.org | 6811b6e | 2013-12-13 09:46:59 +0000 | [diff] [blame] | 1736 | } |
| 1737 | |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 1738 | TEST_P(RtpSenderTestWithoutPacer, StreamDataCountersCallbacks) { |
Erik Språng | 6cf554e | 2019-10-02 20:55:39 +0200 | [diff] [blame] | 1739 | const uint8_t kPayloadType = 127; |
| 1740 | const VideoCodecType kCodecType = VideoCodecType::kVideoCodecGeneric; |
Niels Möller | 5fe9510 | 2019-03-04 16:49:25 +0100 | [diff] [blame] | 1741 | PlayoutDelayOracle playout_delay_oracle; |
Erik Språng | dc34a25 | 2019-10-04 15:17:29 +0200 | [diff] [blame] | 1742 | FieldTrialBasedConfig field_trials; |
| 1743 | RTPSenderVideo::Config video_config; |
| 1744 | video_config.clock = &fake_clock_; |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 1745 | video_config.rtp_sender = rtp_sender(); |
Erik Språng | dc34a25 | 2019-10-04 15:17:29 +0200 | [diff] [blame] | 1746 | video_config.playout_delay_oracle = &playout_delay_oracle; |
| 1747 | video_config.field_trials = &field_trials; |
| 1748 | RTPSenderVideo rtp_sender_video(video_config); |
sprang@webrtc.org | ebad765 | 2013-12-05 14:29:02 +0000 | [diff] [blame] | 1749 | uint8_t payload[] = {47, 11, 32, 93, 89}; |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 1750 | rtp_sender_context_->packet_history_.SetStorePacketsStatus( |
| 1751 | RtpPacketHistory::StorageMode::kStoreAndCull, 1); |
| 1752 | uint32_t ssrc = rtp_sender()->SSRC(); |
sprang@webrtc.org | ebad765 | 2013-12-05 14:29:02 +0000 | [diff] [blame] | 1753 | |
sprang@webrtc.org | ebad765 | 2013-12-05 14:29:02 +0000 | [diff] [blame] | 1754 | // Send a frame. |
Sami Kalliomäki | 426a80c | 2018-08-08 11:37:59 +0200 | [diff] [blame] | 1755 | RTPVideoHeader video_header; |
Danil Chapovalov | 51bf200 | 2019-10-11 10:53:27 +0200 | [diff] [blame] | 1756 | video_header.frame_type = VideoFrameType::kVideoFrameKey; |
| 1757 | ASSERT_TRUE(rtp_sender_video.SendVideo(kPayloadType, kCodecType, 1234, 4321, |
| 1758 | payload, nullptr, video_header, |
| 1759 | kDefaultExpectedRetransmissionTimeMs)); |
asapersson@webrtc.org | 97d0489 | 2014-12-09 09:47:53 +0000 | [diff] [blame] | 1760 | StreamDataCounters expected; |
asapersson@webrtc.org | cfd82df | 2015-01-22 09:39:59 +0000 | [diff] [blame] | 1761 | expected.transmitted.payload_bytes = 6; |
| 1762 | expected.transmitted.header_bytes = 12; |
| 1763 | expected.transmitted.padding_bytes = 0; |
| 1764 | expected.transmitted.packets = 1; |
| 1765 | expected.retransmitted.payload_bytes = 0; |
| 1766 | expected.retransmitted.header_bytes = 0; |
| 1767 | expected.retransmitted.padding_bytes = 0; |
| 1768 | expected.retransmitted.packets = 0; |
| 1769 | expected.fec.packets = 0; |
Erik Språng | 7ea9b80 | 2019-10-16 19:03:38 +0200 | [diff] [blame] | 1770 | rtp_stats_callback_.Matches(ssrc, expected); |
sprang@webrtc.org | ebad765 | 2013-12-05 14:29:02 +0000 | [diff] [blame] | 1771 | |
| 1772 | // Retransmit a frame. |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 1773 | uint16_t seqno = rtp_sender()->SequenceNumber() - 1; |
| 1774 | rtp_sender()->ReSendPacket(seqno); |
asapersson@webrtc.org | cfd82df | 2015-01-22 09:39:59 +0000 | [diff] [blame] | 1775 | expected.transmitted.payload_bytes = 12; |
| 1776 | expected.transmitted.header_bytes = 24; |
| 1777 | expected.transmitted.packets = 2; |
| 1778 | expected.retransmitted.payload_bytes = 6; |
| 1779 | expected.retransmitted.header_bytes = 12; |
| 1780 | expected.retransmitted.padding_bytes = 0; |
| 1781 | expected.retransmitted.packets = 1; |
Erik Språng | 7ea9b80 | 2019-10-16 19:03:38 +0200 | [diff] [blame] | 1782 | rtp_stats_callback_.Matches(ssrc, expected); |
sprang@webrtc.org | ebad765 | 2013-12-05 14:29:02 +0000 | [diff] [blame] | 1783 | |
| 1784 | // Send padding. |
Erik Språng | 4208a13 | 2019-08-26 08:58:45 +0200 | [diff] [blame] | 1785 | GenerateAndSendPadding(kMaxPaddingSize); |
asapersson@webrtc.org | cfd82df | 2015-01-22 09:39:59 +0000 | [diff] [blame] | 1786 | expected.transmitted.payload_bytes = 12; |
| 1787 | expected.transmitted.header_bytes = 36; |
| 1788 | expected.transmitted.padding_bytes = kMaxPaddingSize; |
| 1789 | expected.transmitted.packets = 3; |
Erik Språng | 7ea9b80 | 2019-10-16 19:03:38 +0200 | [diff] [blame] | 1790 | rtp_stats_callback_.Matches(ssrc, expected); |
Erik Språng | dc34a25 | 2019-10-04 15:17:29 +0200 | [diff] [blame] | 1791 | } |
| 1792 | |
| 1793 | TEST_P(RtpSenderTestWithoutPacer, StreamDataCountersCallbacksUlpfec) { |
Erik Språng | dc34a25 | 2019-10-04 15:17:29 +0200 | [diff] [blame] | 1794 | const uint8_t kRedPayloadType = 96; |
| 1795 | const uint8_t kUlpfecPayloadType = 97; |
| 1796 | const uint8_t kPayloadType = 127; |
| 1797 | const VideoCodecType kCodecType = VideoCodecType::kVideoCodecGeneric; |
| 1798 | PlayoutDelayOracle playout_delay_oracle; |
| 1799 | FieldTrialBasedConfig field_trials; |
| 1800 | RTPSenderVideo::Config video_config; |
| 1801 | video_config.clock = &fake_clock_; |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 1802 | video_config.rtp_sender = rtp_sender(); |
Erik Språng | dc34a25 | 2019-10-04 15:17:29 +0200 | [diff] [blame] | 1803 | video_config.playout_delay_oracle = &playout_delay_oracle; |
| 1804 | video_config.field_trials = &field_trials; |
| 1805 | video_config.red_payload_type = kRedPayloadType; |
| 1806 | video_config.ulpfec_payload_type = kUlpfecPayloadType; |
| 1807 | RTPSenderVideo rtp_sender_video(video_config); |
| 1808 | uint8_t payload[] = {47, 11, 32, 93, 89}; |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 1809 | rtp_sender_context_->packet_history_.SetStorePacketsStatus( |
| 1810 | RtpPacketHistory::StorageMode::kStoreAndCull, 1); |
| 1811 | uint32_t ssrc = rtp_sender()->SSRC(); |
Erik Språng | dc34a25 | 2019-10-04 15:17:29 +0200 | [diff] [blame] | 1812 | |
Erik Språng | dc34a25 | 2019-10-04 15:17:29 +0200 | [diff] [blame] | 1813 | RTPVideoHeader video_header; |
| 1814 | StreamDataCounters expected; |
| 1815 | |
brandtr | f1bb476 | 2016-11-07 03:05:06 -0800 | [diff] [blame] | 1816 | // Send ULPFEC. |
sprang@webrtc.org | ebad765 | 2013-12-05 14:29:02 +0000 | [diff] [blame] | 1817 | FecProtectionParams fec_params; |
| 1818 | fec_params.fec_mask_type = kFecMaskRandom; |
| 1819 | fec_params.fec_rate = 1; |
| 1820 | fec_params.max_fec_frames = 1; |
Niels Möller | 59ab1cf | 2019-02-06 22:48:11 +0100 | [diff] [blame] | 1821 | rtp_sender_video.SetFecParameters(fec_params, fec_params); |
Danil Chapovalov | 51bf200 | 2019-10-11 10:53:27 +0200 | [diff] [blame] | 1822 | video_header.frame_type = VideoFrameType::kVideoFrameDelta; |
| 1823 | ASSERT_TRUE(rtp_sender_video.SendVideo(kPayloadType, kCodecType, 1234, 4321, |
| 1824 | payload, nullptr, video_header, |
| 1825 | kDefaultExpectedRetransmissionTimeMs)); |
Erik Språng | dc34a25 | 2019-10-04 15:17:29 +0200 | [diff] [blame] | 1826 | expected.transmitted.payload_bytes = 28; |
| 1827 | expected.transmitted.header_bytes = 24; |
| 1828 | expected.transmitted.packets = 2; |
asapersson@webrtc.org | cfd82df | 2015-01-22 09:39:59 +0000 | [diff] [blame] | 1829 | expected.fec.packets = 1; |
Erik Språng | 7ea9b80 | 2019-10-16 19:03:38 +0200 | [diff] [blame] | 1830 | rtp_stats_callback_.Matches(ssrc, expected); |
sprang@webrtc.org | ebad765 | 2013-12-05 14:29:02 +0000 | [diff] [blame] | 1831 | } |
| 1832 | |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 1833 | TEST_P(RtpSenderTestWithoutPacer, BytesReportedCorrectly) { |
Niels Möller | 59ab1cf | 2019-02-06 22:48:11 +0100 | [diff] [blame] | 1834 | // XXX const char* kPayloadName = "GENERIC"; |
pbos@webrtc.org | 72491b9 | 2014-07-10 16:24:54 +0000 | [diff] [blame] | 1835 | const uint8_t kPayloadType = 127; |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 1836 | rtp_sender()->SetRtxPayloadType(kPayloadType - 1, kPayloadType); |
| 1837 | rtp_sender()->SetRtxStatus(kRtxRetransmitted | kRtxRedundantPayloads); |
pbos@webrtc.org | 72491b9 | 2014-07-10 16:24:54 +0000 | [diff] [blame] | 1838 | |
Niels Möller | 59ab1cf | 2019-02-06 22:48:11 +0100 | [diff] [blame] | 1839 | SendGenericPacket(); |
pbos@webrtc.org | 2f4b14e | 2014-07-15 15:25:39 +0000 | [diff] [blame] | 1840 | // Will send 2 full-size padding packets. |
Erik Språng | 4208a13 | 2019-08-26 08:58:45 +0200 | [diff] [blame] | 1841 | GenerateAndSendPadding(1); |
| 1842 | GenerateAndSendPadding(1); |
pbos@webrtc.org | 72491b9 | 2014-07-10 16:24:54 +0000 | [diff] [blame] | 1843 | |
pbos@webrtc.org | 2f4b14e | 2014-07-15 15:25:39 +0000 | [diff] [blame] | 1844 | StreamDataCounters rtp_stats; |
| 1845 | StreamDataCounters rtx_stats; |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 1846 | rtp_egress()->GetDataCounters(&rtp_stats, &rtx_stats); |
pbos@webrtc.org | 72491b9 | 2014-07-10 16:24:54 +0000 | [diff] [blame] | 1847 | |
Niels Möller | 59ab1cf | 2019-02-06 22:48:11 +0100 | [diff] [blame] | 1848 | // Payload |
asapersson@webrtc.org | d08d389 | 2014-12-16 12:03:11 +0000 | [diff] [blame] | 1849 | EXPECT_GT(rtp_stats.first_packet_time_ms, -1); |
Niels Möller | 59ab1cf | 2019-02-06 22:48:11 +0100 | [diff] [blame] | 1850 | EXPECT_EQ(rtp_stats.transmitted.payload_bytes, sizeof(kPayloadData)); |
asapersson@webrtc.org | cfd82df | 2015-01-22 09:39:59 +0000 | [diff] [blame] | 1851 | EXPECT_EQ(rtp_stats.transmitted.header_bytes, 12u); |
| 1852 | EXPECT_EQ(rtp_stats.transmitted.padding_bytes, 0u); |
| 1853 | EXPECT_EQ(rtx_stats.transmitted.payload_bytes, 0u); |
| 1854 | EXPECT_EQ(rtx_stats.transmitted.header_bytes, 24u); |
| 1855 | EXPECT_EQ(rtx_stats.transmitted.padding_bytes, 2 * kMaxPaddingSize); |
pbos@webrtc.org | 2f4b14e | 2014-07-15 15:25:39 +0000 | [diff] [blame] | 1856 | |
asapersson@webrtc.org | cfd82df | 2015-01-22 09:39:59 +0000 | [diff] [blame] | 1857 | EXPECT_EQ(rtp_stats.transmitted.TotalBytes(), |
danilchap | 162abd3 | 2015-12-10 02:39:40 -0800 | [diff] [blame] | 1858 | rtp_stats.transmitted.payload_bytes + |
| 1859 | rtp_stats.transmitted.header_bytes + |
| 1860 | rtp_stats.transmitted.padding_bytes); |
asapersson@webrtc.org | cfd82df | 2015-01-22 09:39:59 +0000 | [diff] [blame] | 1861 | EXPECT_EQ(rtx_stats.transmitted.TotalBytes(), |
danilchap | 162abd3 | 2015-12-10 02:39:40 -0800 | [diff] [blame] | 1862 | rtx_stats.transmitted.payload_bytes + |
| 1863 | rtx_stats.transmitted.header_bytes + |
| 1864 | rtx_stats.transmitted.padding_bytes); |
asapersson@webrtc.org | 97d0489 | 2014-12-09 09:47:53 +0000 | [diff] [blame] | 1865 | |
danilchap | 162abd3 | 2015-12-10 02:39:40 -0800 | [diff] [blame] | 1866 | EXPECT_EQ( |
| 1867 | transport_.total_bytes_sent_, |
| 1868 | rtp_stats.transmitted.TotalBytes() + rtx_stats.transmitted.TotalBytes()); |
pbos@webrtc.org | 72491b9 | 2014-07-10 16:24:54 +0000 | [diff] [blame] | 1869 | } |
guoweis@webrtc.org | 4536289 | 2015-03-04 22:55:15 +0000 | [diff] [blame] | 1870 | |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 1871 | TEST_P(RtpSenderTestWithoutPacer, RespectsNackBitrateLimit) { |
sprang | 38778b0 | 2015-09-29 09:48:22 -0700 | [diff] [blame] | 1872 | const int32_t kPacketSize = 1400; |
| 1873 | const int32_t kNumPackets = 30; |
| 1874 | |
sprang | cd349d9 | 2016-07-13 09:11:28 -0700 | [diff] [blame] | 1875 | retransmission_rate_limiter_.SetMaxRate(kPacketSize * kNumPackets * 8); |
| 1876 | |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 1877 | rtp_sender_context_->packet_history_.SetStorePacketsStatus( |
| 1878 | RtpPacketHistory::StorageMode::kStoreAndCull, kNumPackets); |
| 1879 | const uint16_t kStartSequenceNumber = rtp_sender()->SequenceNumber(); |
Danil Chapovalov | 2800d74 | 2016-08-26 18:48:46 +0200 | [diff] [blame] | 1880 | std::vector<uint16_t> sequence_numbers; |
sprang | 38778b0 | 2015-09-29 09:48:22 -0700 | [diff] [blame] | 1881 | for (int32_t i = 0; i < kNumPackets; ++i) { |
| 1882 | sequence_numbers.push_back(kStartSequenceNumber + i); |
| 1883 | fake_clock_.AdvanceTimeMilliseconds(1); |
| 1884 | SendPacket(fake_clock_.TimeInMilliseconds(), kPacketSize); |
| 1885 | } |
danilchap | 12ba186 | 2016-10-26 02:41:55 -0700 | [diff] [blame] | 1886 | EXPECT_EQ(kNumPackets, transport_.packets_sent()); |
sprang | 38778b0 | 2015-09-29 09:48:22 -0700 | [diff] [blame] | 1887 | |
| 1888 | fake_clock_.AdvanceTimeMilliseconds(1000 - kNumPackets); |
| 1889 | |
| 1890 | // Resending should work - brings the bandwidth up to the limit. |
| 1891 | // NACK bitrate is capped to the same bitrate as the encoder, since the max |
| 1892 | // protection overhead is 50% (see MediaOptimization::SetTargetRates). |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 1893 | rtp_sender()->OnReceivedNack(sequence_numbers, 0); |
danilchap | 12ba186 | 2016-10-26 02:41:55 -0700 | [diff] [blame] | 1894 | EXPECT_EQ(kNumPackets * 2, transport_.packets_sent()); |
sprang | 38778b0 | 2015-09-29 09:48:22 -0700 | [diff] [blame] | 1895 | |
sprang | cd349d9 | 2016-07-13 09:11:28 -0700 | [diff] [blame] | 1896 | // Must be at least 5ms in between retransmission attempts. |
| 1897 | fake_clock_.AdvanceTimeMilliseconds(5); |
| 1898 | |
sprang | 38778b0 | 2015-09-29 09:48:22 -0700 | [diff] [blame] | 1899 | // Resending should not work, bandwidth exceeded. |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 1900 | rtp_sender()->OnReceivedNack(sequence_numbers, 0); |
danilchap | 12ba186 | 2016-10-26 02:41:55 -0700 | [diff] [blame] | 1901 | EXPECT_EQ(kNumPackets * 2, transport_.packets_sent()); |
sprang | 38778b0 | 2015-09-29 09:48:22 -0700 | [diff] [blame] | 1902 | } |
| 1903 | |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 1904 | TEST_P(RtpSenderTest, OnOverheadChanged) { |
michaelt | 4da3044 | 2016-11-17 01:38:43 -0800 | [diff] [blame] | 1905 | MockOverheadObserver mock_overhead_observer; |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 1906 | RtpRtcp::Configuration config; |
| 1907 | config.clock = &fake_clock_; |
| 1908 | config.outgoing_transport = &transport_; |
Erik Språng | 54d5d2c | 2019-08-20 17:22:36 +0200 | [diff] [blame] | 1909 | config.local_media_ssrc = kSsrc; |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 1910 | config.retransmission_rate_limiter = &retransmission_rate_limiter_; |
| 1911 | config.overhead_observer = &mock_overhead_observer; |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 1912 | rtp_sender_context_ = std::make_unique<RtpSenderContext>(config); |
michaelt | 4da3044 | 2016-11-17 01:38:43 -0800 | [diff] [blame] | 1913 | |
michaelt | 4da3044 | 2016-11-17 01:38:43 -0800 | [diff] [blame] | 1914 | // RTP overhead is 12B. |
nisse | 284542b | 2017-01-10 08:58:32 -0800 | [diff] [blame] | 1915 | EXPECT_CALL(mock_overhead_observer, OnOverheadChanged(12)).Times(1); |
Niels Möller | e7b9e6b | 2019-02-06 18:23:44 +0100 | [diff] [blame] | 1916 | SendGenericPacket(); |
michaelt | 4da3044 | 2016-11-17 01:38:43 -0800 | [diff] [blame] | 1917 | |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 1918 | rtp_sender()->RegisterRtpHeaderExtension(kRtpExtensionTransmissionTimeOffset, |
| 1919 | kTransmissionTimeOffsetExtensionId); |
michaelt | 4da3044 | 2016-11-17 01:38:43 -0800 | [diff] [blame] | 1920 | |
| 1921 | // TransmissionTimeOffset extension has a size of 8B. |
nisse | 284542b | 2017-01-10 08:58:32 -0800 | [diff] [blame] | 1922 | // 12B + 8B = 20B |
| 1923 | EXPECT_CALL(mock_overhead_observer, OnOverheadChanged(20)).Times(1); |
Niels Möller | e7b9e6b | 2019-02-06 18:23:44 +0100 | [diff] [blame] | 1924 | SendGenericPacket(); |
michaelt | 4da3044 | 2016-11-17 01:38:43 -0800 | [diff] [blame] | 1925 | } |
| 1926 | |
minyue | 3a407ee | 2017-04-03 01:10:33 -0700 | [diff] [blame] | 1927 | TEST_P(RtpSenderTest, DoesNotUpdateOverheadOnEqualSize) { |
michaelt | 4da3044 | 2016-11-17 01:38:43 -0800 | [diff] [blame] | 1928 | MockOverheadObserver mock_overhead_observer; |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 1929 | RtpRtcp::Configuration config; |
| 1930 | config.clock = &fake_clock_; |
| 1931 | config.outgoing_transport = &transport_; |
Erik Språng | 54d5d2c | 2019-08-20 17:22:36 +0200 | [diff] [blame] | 1932 | config.local_media_ssrc = kSsrc; |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 1933 | config.retransmission_rate_limiter = &retransmission_rate_limiter_; |
| 1934 | config.overhead_observer = &mock_overhead_observer; |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 1935 | rtp_sender_context_ = std::make_unique<RtpSenderContext>(config); |
michaelt | 4da3044 | 2016-11-17 01:38:43 -0800 | [diff] [blame] | 1936 | |
| 1937 | EXPECT_CALL(mock_overhead_observer, OnOverheadChanged(_)).Times(1); |
Niels Möller | e7b9e6b | 2019-02-06 18:23:44 +0100 | [diff] [blame] | 1938 | SendGenericPacket(); |
| 1939 | SendGenericPacket(); |
michaelt | 4da3044 | 2016-11-17 01:38:43 -0800 | [diff] [blame] | 1940 | } |
| 1941 | |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 1942 | TEST_P(RtpSenderTest, SendPacketMatchesVideo) { |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 1943 | std::unique_ptr<RtpPacketToSend> packet = |
| 1944 | BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds()); |
| 1945 | packet->set_packet_type(RtpPacketToSend::Type::kVideo); |
| 1946 | |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 1947 | // Verify sent with correct SSRC. |
| 1948 | packet = BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds()); |
| 1949 | packet->SetSsrc(kSsrc); |
| 1950 | packet->set_packet_type(RtpPacketToSend::Type::kVideo); |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 1951 | rtp_egress()->SendPacket(packet.get(), PacedPacketInfo()); |
Erik Språng | 671b403 | 2019-10-17 16:56:22 +0200 | [diff] [blame] | 1952 | EXPECT_EQ(transport_.packets_sent(), 1); |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 1953 | } |
| 1954 | |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 1955 | TEST_P(RtpSenderTest, SendPacketMatchesAudio) { |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 1956 | std::unique_ptr<RtpPacketToSend> packet = |
| 1957 | BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds()); |
| 1958 | packet->set_packet_type(RtpPacketToSend::Type::kAudio); |
| 1959 | |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 1960 | // Verify sent with correct SSRC. |
| 1961 | packet = BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds()); |
| 1962 | packet->SetSsrc(kSsrc); |
| 1963 | packet->set_packet_type(RtpPacketToSend::Type::kAudio); |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 1964 | rtp_egress()->SendPacket(packet.get(), PacedPacketInfo()); |
Erik Språng | 671b403 | 2019-10-17 16:56:22 +0200 | [diff] [blame] | 1965 | EXPECT_EQ(transport_.packets_sent(), 1); |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 1966 | } |
| 1967 | |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 1968 | TEST_P(RtpSenderTest, SendPacketMatchesRetransmissions) { |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 1969 | std::unique_ptr<RtpPacketToSend> packet = |
| 1970 | BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds()); |
| 1971 | packet->set_packet_type(RtpPacketToSend::Type::kRetransmission); |
| 1972 | |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 1973 | // Verify sent with correct SSRC (non-RTX). |
| 1974 | packet = BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds()); |
| 1975 | packet->SetSsrc(kSsrc); |
| 1976 | packet->set_packet_type(RtpPacketToSend::Type::kRetransmission); |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 1977 | rtp_egress()->SendPacket(packet.get(), PacedPacketInfo()); |
Erik Språng | 671b403 | 2019-10-17 16:56:22 +0200 | [diff] [blame] | 1978 | EXPECT_EQ(transport_.packets_sent(), 1); |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 1979 | |
| 1980 | // RTX retransmission. |
| 1981 | packet = BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds()); |
| 1982 | packet->SetSsrc(kRtxSsrc); |
| 1983 | packet->set_packet_type(RtpPacketToSend::Type::kRetransmission); |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 1984 | rtp_egress()->SendPacket(packet.get(), PacedPacketInfo()); |
Erik Språng | 671b403 | 2019-10-17 16:56:22 +0200 | [diff] [blame] | 1985 | EXPECT_EQ(transport_.packets_sent(), 2); |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 1986 | } |
| 1987 | |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 1988 | TEST_P(RtpSenderTest, SendPacketMatchesPadding) { |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 1989 | std::unique_ptr<RtpPacketToSend> packet = |
| 1990 | BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds()); |
| 1991 | packet->set_packet_type(RtpPacketToSend::Type::kPadding); |
| 1992 | |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 1993 | // Verify sent with correct SSRC (non-RTX). |
| 1994 | packet = BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds()); |
| 1995 | packet->SetSsrc(kSsrc); |
| 1996 | packet->set_packet_type(RtpPacketToSend::Type::kPadding); |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 1997 | rtp_egress()->SendPacket(packet.get(), PacedPacketInfo()); |
Erik Språng | 671b403 | 2019-10-17 16:56:22 +0200 | [diff] [blame] | 1998 | EXPECT_EQ(transport_.packets_sent(), 1); |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 1999 | |
| 2000 | // RTX padding. |
| 2001 | packet = BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds()); |
| 2002 | packet->SetSsrc(kRtxSsrc); |
| 2003 | packet->set_packet_type(RtpPacketToSend::Type::kPadding); |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 2004 | rtp_egress()->SendPacket(packet.get(), PacedPacketInfo()); |
Erik Språng | 671b403 | 2019-10-17 16:56:22 +0200 | [diff] [blame] | 2005 | EXPECT_EQ(transport_.packets_sent(), 2); |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 2006 | } |
| 2007 | |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 2008 | TEST_P(RtpSenderTest, SendPacketMatchesFlexfec) { |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 2009 | std::unique_ptr<RtpPacketToSend> packet = |
| 2010 | BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds()); |
| 2011 | packet->set_packet_type(RtpPacketToSend::Type::kForwardErrorCorrection); |
| 2012 | |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 2013 | // Verify sent with correct SSRC. |
| 2014 | packet = BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds()); |
| 2015 | packet->SetSsrc(kFlexFecSsrc); |
| 2016 | packet->set_packet_type(RtpPacketToSend::Type::kForwardErrorCorrection); |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 2017 | rtp_egress()->SendPacket(packet.get(), PacedPacketInfo()); |
Erik Språng | 671b403 | 2019-10-17 16:56:22 +0200 | [diff] [blame] | 2018 | EXPECT_EQ(transport_.packets_sent(), 1); |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 2019 | } |
| 2020 | |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 2021 | TEST_P(RtpSenderTest, SendPacketMatchesUlpfec) { |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 2022 | std::unique_ptr<RtpPacketToSend> packet = |
| 2023 | BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds()); |
| 2024 | packet->set_packet_type(RtpPacketToSend::Type::kForwardErrorCorrection); |
| 2025 | |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 2026 | // Verify sent with correct SSRC. |
| 2027 | packet = BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds()); |
| 2028 | packet->SetSsrc(kSsrc); |
| 2029 | packet->set_packet_type(RtpPacketToSend::Type::kForwardErrorCorrection); |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 2030 | rtp_egress()->SendPacket(packet.get(), PacedPacketInfo()); |
Erik Språng | 671b403 | 2019-10-17 16:56:22 +0200 | [diff] [blame] | 2031 | EXPECT_EQ(transport_.packets_sent(), 1); |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 2032 | } |
| 2033 | |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 2034 | TEST_P(RtpSenderTest, SendPacketHandlesRetransmissionHistory) { |
| 2035 | rtp_sender_context_->packet_history_.SetStorePacketsStatus( |
| 2036 | RtpPacketHistory::StorageMode::kStoreAndCull, 10); |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 2037 | |
| 2038 | // Build a media packet and send it. |
| 2039 | std::unique_ptr<RtpPacketToSend> packet = |
| 2040 | BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds()); |
| 2041 | const uint16_t media_sequence_number = packet->SequenceNumber(); |
| 2042 | packet->set_packet_type(RtpPacketToSend::Type::kVideo); |
| 2043 | packet->set_allow_retransmission(true); |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 2044 | rtp_egress()->SendPacket(packet.get(), PacedPacketInfo()); |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 2045 | |
| 2046 | // Simulate retransmission request. |
| 2047 | fake_clock_.AdvanceTimeMilliseconds(30); |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 2048 | EXPECT_GT(rtp_sender()->ReSendPacket(media_sequence_number), 0); |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 2049 | |
| 2050 | // Packet already pending, retransmission not allowed. |
| 2051 | fake_clock_.AdvanceTimeMilliseconds(30); |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 2052 | EXPECT_EQ(rtp_sender()->ReSendPacket(media_sequence_number), 0); |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 2053 | |
| 2054 | // Packet exiting pacer, mark as not longer pending. |
| 2055 | packet = BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds()); |
| 2056 | EXPECT_NE(packet->SequenceNumber(), media_sequence_number); |
| 2057 | packet->set_packet_type(RtpPacketToSend::Type::kRetransmission); |
| 2058 | packet->SetSsrc(kRtxSsrc); |
| 2059 | packet->set_retransmitted_sequence_number(media_sequence_number); |
| 2060 | packet->set_allow_retransmission(false); |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 2061 | rtp_egress()->SendPacket(packet.get(), PacedPacketInfo()); |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 2062 | |
| 2063 | // Retransmissions allowed again. |
| 2064 | fake_clock_.AdvanceTimeMilliseconds(30); |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 2065 | EXPECT_GT(rtp_sender()->ReSendPacket(media_sequence_number), 0); |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 2066 | |
| 2067 | // Retransmission of RTX packet should not be allowed. |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 2068 | EXPECT_EQ(rtp_sender()->ReSendPacket(packet->SequenceNumber()), 0); |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 2069 | } |
| 2070 | |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 2071 | TEST_P(RtpSenderTest, SendPacketUpdatesExtensions) { |
| 2072 | ASSERT_EQ(rtp_sender()->RegisterRtpHeaderExtension( |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 2073 | kRtpExtensionTransmissionTimeOffset, |
| 2074 | kTransmissionTimeOffsetExtensionId), |
| 2075 | 0); |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 2076 | ASSERT_EQ(rtp_sender()->RegisterRtpHeaderExtension( |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 2077 | kRtpExtensionAbsoluteSendTime, kAbsoluteSendTimeExtensionId), |
| 2078 | 0); |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 2079 | ASSERT_EQ(rtp_sender()->RegisterRtpHeaderExtension(kRtpExtensionVideoTiming, |
| 2080 | kVideoTimingExtensionId), |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 2081 | 0); |
| 2082 | |
| 2083 | std::unique_ptr<RtpPacketToSend> packet = |
| 2084 | BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds()); |
| 2085 | packet->set_packetization_finish_time_ms(fake_clock_.TimeInMilliseconds()); |
| 2086 | |
| 2087 | const int32_t kDiffMs = 10; |
| 2088 | fake_clock_.AdvanceTimeMilliseconds(kDiffMs); |
| 2089 | |
| 2090 | packet->set_packet_type(RtpPacketToSend::Type::kVideo); |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 2091 | rtp_egress()->SendPacket(packet.get(), PacedPacketInfo()); |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 2092 | |
| 2093 | const RtpPacketReceived& received_packet = transport_.last_sent_packet(); |
| 2094 | |
| 2095 | EXPECT_EQ(received_packet.GetExtension<TransmissionOffset>(), kDiffMs * 90); |
| 2096 | |
| 2097 | EXPECT_EQ(received_packet.GetExtension<AbsoluteSendTime>(), |
| 2098 | AbsoluteSendTime::MsTo24Bits(fake_clock_.TimeInMilliseconds())); |
| 2099 | |
| 2100 | VideoSendTiming timing; |
| 2101 | EXPECT_TRUE(received_packet.GetExtension<VideoTimingExtension>(&timing)); |
| 2102 | EXPECT_EQ(timing.pacer_exit_delta_ms, kDiffMs); |
| 2103 | } |
| 2104 | |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 2105 | TEST_P(RtpSenderTest, SendPacketSetsPacketOptions) { |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 2106 | const uint16_t kPacketId = 42; |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 2107 | ASSERT_EQ(rtp_sender()->RegisterRtpHeaderExtension( |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 2108 | kRtpExtensionTransportSequenceNumber, |
| 2109 | kTransportSequenceNumberExtensionId), |
| 2110 | 0); |
| 2111 | std::unique_ptr<RtpPacketToSend> packet = |
| 2112 | BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds()); |
| 2113 | packet->SetExtension<TransportSequenceNumber>(kPacketId); |
| 2114 | |
| 2115 | packet->set_packet_type(RtpPacketToSend::Type::kVideo); |
| 2116 | EXPECT_CALL(send_packet_observer_, OnSendPacket); |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 2117 | rtp_egress()->SendPacket(packet.get(), PacedPacketInfo()); |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 2118 | |
| 2119 | EXPECT_EQ(transport_.last_options_.packet_id, kPacketId); |
| 2120 | EXPECT_TRUE(transport_.last_options_.included_in_allocation); |
| 2121 | EXPECT_TRUE(transport_.last_options_.included_in_feedback); |
| 2122 | EXPECT_FALSE(transport_.last_options_.is_retransmit); |
| 2123 | |
| 2124 | // Send another packet as retransmission, verify options are populated. |
| 2125 | packet = BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds()); |
| 2126 | packet->SetExtension<TransportSequenceNumber>(kPacketId + 1); |
| 2127 | packet->set_packet_type(RtpPacketToSend::Type::kRetransmission); |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 2128 | rtp_egress()->SendPacket(packet.get(), PacedPacketInfo()); |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 2129 | EXPECT_TRUE(transport_.last_options_.is_retransmit); |
| 2130 | } |
| 2131 | |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 2132 | TEST_P(RtpSenderTest, SendPacketUpdatesStats) { |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 2133 | const size_t kPayloadSize = 1000; |
| 2134 | |
| 2135 | StrictMock<MockSendSideDelayObserver> send_side_delay_observer; |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 2136 | |
| 2137 | RtpRtcp::Configuration config; |
| 2138 | config.clock = &fake_clock_; |
| 2139 | config.outgoing_transport = &transport_; |
Erik Språng | 54d5d2c | 2019-08-20 17:22:36 +0200 | [diff] [blame] | 2140 | config.local_media_ssrc = kSsrc; |
Erik Språng | 4580ca2 | 2019-07-04 10:38:43 +0200 | [diff] [blame] | 2141 | config.rtx_send_ssrc = kRtxSsrc; |
| 2142 | config.flexfec_sender = &flexfec_sender_; |
| 2143 | config.send_side_delay_observer = &send_side_delay_observer; |
| 2144 | config.event_log = &mock_rtc_event_log_; |
| 2145 | config.send_packet_observer = &send_packet_observer_; |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 2146 | rtp_sender_context_ = std::make_unique<RtpSenderContext>(config); |
| 2147 | ASSERT_EQ(0, rtp_sender()->RegisterRtpHeaderExtension( |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 2148 | kRtpExtensionTransportSequenceNumber, |
| 2149 | kTransportSequenceNumberExtensionId)); |
| 2150 | |
| 2151 | const int64_t capture_time_ms = fake_clock_.TimeInMilliseconds(); |
| 2152 | |
| 2153 | std::unique_ptr<RtpPacketToSend> video_packet = |
| 2154 | BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds()); |
| 2155 | video_packet->set_packet_type(RtpPacketToSend::Type::kVideo); |
| 2156 | video_packet->SetPayloadSize(kPayloadSize); |
| 2157 | video_packet->SetExtension<TransportSequenceNumber>(1); |
| 2158 | |
| 2159 | std::unique_ptr<RtpPacketToSend> rtx_packet = |
| 2160 | BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds()); |
| 2161 | rtx_packet->SetSsrc(kRtxSsrc); |
| 2162 | rtx_packet->set_packet_type(RtpPacketToSend::Type::kRetransmission); |
| 2163 | rtx_packet->SetPayloadSize(kPayloadSize); |
| 2164 | rtx_packet->SetExtension<TransportSequenceNumber>(2); |
| 2165 | |
| 2166 | std::unique_ptr<RtpPacketToSend> fec_packet = |
| 2167 | BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds()); |
| 2168 | fec_packet->SetSsrc(kFlexFecSsrc); |
| 2169 | fec_packet->set_packet_type(RtpPacketToSend::Type::kForwardErrorCorrection); |
| 2170 | fec_packet->SetPayloadSize(kPayloadSize); |
| 2171 | fec_packet->SetExtension<TransportSequenceNumber>(3); |
| 2172 | |
| 2173 | const int64_t kDiffMs = 25; |
| 2174 | fake_clock_.AdvanceTimeMilliseconds(kDiffMs); |
| 2175 | |
| 2176 | EXPECT_CALL(send_side_delay_observer, |
| 2177 | SendSideDelayUpdated(kDiffMs, kDiffMs, kDiffMs, kSsrc)); |
| 2178 | EXPECT_CALL( |
| 2179 | send_side_delay_observer, |
| 2180 | SendSideDelayUpdated(kDiffMs, kDiffMs, 2 * kDiffMs, kFlexFecSsrc)); |
| 2181 | |
| 2182 | EXPECT_CALL(send_packet_observer_, OnSendPacket(1, capture_time_ms, kSsrc)); |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 2183 | |
| 2184 | rtp_egress()->SendPacket(video_packet.get(), PacedPacketInfo()); |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 2185 | |
| 2186 | // Send packet observer not called for padding/retransmissions. |
| 2187 | EXPECT_CALL(send_packet_observer_, OnSendPacket(2, _, _)).Times(0); |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 2188 | rtp_egress()->SendPacket(rtx_packet.get(), PacedPacketInfo()); |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 2189 | |
| 2190 | EXPECT_CALL(send_packet_observer_, |
| 2191 | OnSendPacket(3, capture_time_ms, kFlexFecSsrc)); |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 2192 | rtp_egress()->SendPacket(fec_packet.get(), PacedPacketInfo()); |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 2193 | |
| 2194 | StreamDataCounters rtp_stats; |
| 2195 | StreamDataCounters rtx_stats; |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 2196 | rtp_egress()->GetDataCounters(&rtp_stats, &rtx_stats); |
Erik Språng | 9c771c2 | 2019-06-17 16:31:53 +0200 | [diff] [blame] | 2197 | EXPECT_EQ(rtp_stats.transmitted.packets, 2u); |
| 2198 | EXPECT_EQ(rtp_stats.fec.packets, 1u); |
| 2199 | EXPECT_EQ(rtx_stats.retransmitted.packets, 1u); |
| 2200 | } |
| 2201 | |
Erik Språng | 478cb46 | 2019-06-26 15:49:27 +0200 | [diff] [blame] | 2202 | TEST_P(RtpSenderTest, GeneratePaddingResendsOldPacketsWithRtx) { |
Mirko Bonadei | a7e3bce | 2019-07-12 17:35:56 +0000 | [diff] [blame] | 2203 | // Min requested size in order to use RTX payload. |
| 2204 | const size_t kMinPaddingSize = 50; |
| 2205 | |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 2206 | rtp_sender()->SetRtxStatus(kRtxRetransmitted | kRtxRedundantPayloads); |
| 2207 | rtp_sender()->SetRtxPayloadType(kRtxPayload, kPayload); |
| 2208 | rtp_sender_context_->packet_history_.SetStorePacketsStatus( |
| 2209 | RtpPacketHistory::StorageMode::kStoreAndCull, 1); |
Erik Språng | 478cb46 | 2019-06-26 15:49:27 +0200 | [diff] [blame] | 2210 | |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 2211 | ASSERT_EQ(0, rtp_sender()->RegisterRtpHeaderExtension( |
Erik Språng | 0f6191d | 2019-07-15 20:33:40 +0200 | [diff] [blame] | 2212 | kRtpExtensionTransmissionTimeOffset, |
| 2213 | kTransmissionTimeOffsetExtensionId)); |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 2214 | ASSERT_EQ(0, |
| 2215 | rtp_sender()->RegisterRtpHeaderExtension( |
| 2216 | kRtpExtensionAbsoluteSendTime, kAbsoluteSendTimeExtensionId)); |
| 2217 | ASSERT_EQ(0, rtp_sender()->RegisterRtpHeaderExtension( |
Erik Språng | 0f6191d | 2019-07-15 20:33:40 +0200 | [diff] [blame] | 2218 | kRtpExtensionTransportSequenceNumber, |
| 2219 | kTransportSequenceNumberExtensionId)); |
| 2220 | |
Erik Språng | 478cb46 | 2019-06-26 15:49:27 +0200 | [diff] [blame] | 2221 | const size_t kPayloadPacketSize = 1234; |
| 2222 | std::unique_ptr<RtpPacketToSend> packet = |
| 2223 | BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds()); |
| 2224 | packet->set_allow_retransmission(true); |
| 2225 | packet->SetPayloadSize(kPayloadPacketSize); |
| 2226 | packet->set_packet_type(RtpPacketToSend::Type::kVideo); |
| 2227 | |
| 2228 | // Send a dummy video packet so it ends up in the packet history. |
Erik Språng | 0f6191d | 2019-07-15 20:33:40 +0200 | [diff] [blame] | 2229 | EXPECT_CALL(send_packet_observer_, OnSendPacket).Times(1); |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 2230 | rtp_egress()->SendPacket(packet.get(), PacedPacketInfo()); |
Erik Språng | 478cb46 | 2019-06-26 15:49:27 +0200 | [diff] [blame] | 2231 | |
| 2232 | // Generated padding has large enough budget that the video packet should be |
| 2233 | // retransmitted as padding. |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 2234 | std::vector<std::unique_ptr<RtpPacketToSend>> generated_packets = |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 2235 | rtp_sender()->GeneratePadding(kMinPaddingSize, true); |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 2236 | ASSERT_EQ(generated_packets.size(), 1u); |
| 2237 | auto& padding_packet = generated_packets.front(); |
| 2238 | EXPECT_EQ(padding_packet->packet_type(), RtpPacketToSend::Type::kPadding); |
| 2239 | EXPECT_EQ(padding_packet->Ssrc(), kRtxSsrc); |
| 2240 | EXPECT_EQ(padding_packet->payload_size(), |
| 2241 | kPayloadPacketSize + kRtxHeaderSize); |
Erik Språng | 0f6191d | 2019-07-15 20:33:40 +0200 | [diff] [blame] | 2242 | EXPECT_TRUE(padding_packet->IsExtensionReserved<TransportSequenceNumber>()); |
| 2243 | EXPECT_TRUE(padding_packet->IsExtensionReserved<AbsoluteSendTime>()); |
| 2244 | EXPECT_TRUE(padding_packet->IsExtensionReserved<TransmissionOffset>()); |
| 2245 | |
| 2246 | // Verify all header extensions are received. |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 2247 | rtp_egress()->SendPacket(padding_packet.get(), PacedPacketInfo()); |
Erik Språng | 0f6191d | 2019-07-15 20:33:40 +0200 | [diff] [blame] | 2248 | webrtc::RTPHeader rtp_header; |
| 2249 | transport_.last_sent_packet().GetHeader(&rtp_header); |
| 2250 | EXPECT_TRUE(rtp_header.extension.hasAbsoluteSendTime); |
| 2251 | EXPECT_TRUE(rtp_header.extension.hasTransmissionTimeOffset); |
| 2252 | EXPECT_TRUE(rtp_header.extension.hasTransportSequenceNumber); |
Erik Språng | 478cb46 | 2019-06-26 15:49:27 +0200 | [diff] [blame] | 2253 | |
| 2254 | // Not enough budged for payload padding, use plain padding instead. |
Mirko Bonadei | a7e3bce | 2019-07-12 17:35:56 +0000 | [diff] [blame] | 2255 | const size_t kPaddingBytesRequested = kMinPaddingSize - 1; |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 2256 | |
| 2257 | size_t padding_bytes_generated = 0; |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 2258 | generated_packets = |
| 2259 | rtp_sender()->GeneratePadding(kPaddingBytesRequested, true); |
Mirko Bonadei | a7e3bce | 2019-07-12 17:35:56 +0000 | [diff] [blame] | 2260 | EXPECT_EQ(generated_packets.size(), 1u); |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 2261 | for (auto& packet : generated_packets) { |
| 2262 | EXPECT_EQ(packet->packet_type(), RtpPacketToSend::Type::kPadding); |
| 2263 | EXPECT_EQ(packet->Ssrc(), kRtxSsrc); |
| 2264 | EXPECT_EQ(packet->payload_size(), 0u); |
| 2265 | EXPECT_GT(packet->padding_size(), 0u); |
| 2266 | padding_bytes_generated += packet->padding_size(); |
Erik Språng | 0f6191d | 2019-07-15 20:33:40 +0200 | [diff] [blame] | 2267 | |
| 2268 | EXPECT_TRUE(packet->IsExtensionReserved<TransportSequenceNumber>()); |
| 2269 | EXPECT_TRUE(packet->IsExtensionReserved<AbsoluteSendTime>()); |
| 2270 | EXPECT_TRUE(packet->IsExtensionReserved<TransmissionOffset>()); |
| 2271 | |
| 2272 | // Verify all header extensions are received. |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 2273 | rtp_egress()->SendPacket(packet.get(), PacedPacketInfo()); |
Erik Språng | 0f6191d | 2019-07-15 20:33:40 +0200 | [diff] [blame] | 2274 | webrtc::RTPHeader rtp_header; |
| 2275 | transport_.last_sent_packet().GetHeader(&rtp_header); |
| 2276 | EXPECT_TRUE(rtp_header.extension.hasAbsoluteSendTime); |
| 2277 | EXPECT_TRUE(rtp_header.extension.hasTransmissionTimeOffset); |
| 2278 | EXPECT_TRUE(rtp_header.extension.hasTransportSequenceNumber); |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 2279 | } |
| 2280 | |
Mirko Bonadei | a7e3bce | 2019-07-12 17:35:56 +0000 | [diff] [blame] | 2281 | EXPECT_EQ(padding_bytes_generated, kMaxPaddingSize); |
Erik Språng | 478cb46 | 2019-06-26 15:49:27 +0200 | [diff] [blame] | 2282 | } |
| 2283 | |
| 2284 | TEST_P(RtpSenderTest, GeneratePaddingCreatesPurePaddingWithoutRtx) { |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 2285 | rtp_sender_context_->packet_history_.SetStorePacketsStatus( |
| 2286 | RtpPacketHistory::StorageMode::kStoreAndCull, 1); |
| 2287 | ASSERT_EQ(0, rtp_sender()->RegisterRtpHeaderExtension( |
Erik Språng | 0f6191d | 2019-07-15 20:33:40 +0200 | [diff] [blame] | 2288 | kRtpExtensionTransmissionTimeOffset, |
| 2289 | kTransmissionTimeOffsetExtensionId)); |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 2290 | ASSERT_EQ(0, |
| 2291 | rtp_sender()->RegisterRtpHeaderExtension( |
| 2292 | kRtpExtensionAbsoluteSendTime, kAbsoluteSendTimeExtensionId)); |
| 2293 | ASSERT_EQ(0, rtp_sender()->RegisterRtpHeaderExtension( |
Erik Språng | 0f6191d | 2019-07-15 20:33:40 +0200 | [diff] [blame] | 2294 | kRtpExtensionTransportSequenceNumber, |
| 2295 | kTransportSequenceNumberExtensionId)); |
Erik Språng | 478cb46 | 2019-06-26 15:49:27 +0200 | [diff] [blame] | 2296 | |
| 2297 | const size_t kPayloadPacketSize = 1234; |
| 2298 | // Send a dummy video packet so it ends up in the packet history. Since we |
| 2299 | // are not using RTX, it should never be used as padding. |
| 2300 | std::unique_ptr<RtpPacketToSend> packet = |
| 2301 | BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds()); |
| 2302 | packet->set_allow_retransmission(true); |
| 2303 | packet->SetPayloadSize(kPayloadPacketSize); |
| 2304 | packet->set_packet_type(RtpPacketToSend::Type::kVideo); |
Erik Språng | 0f6191d | 2019-07-15 20:33:40 +0200 | [diff] [blame] | 2305 | EXPECT_CALL(send_packet_observer_, OnSendPacket).Times(1); |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 2306 | rtp_egress()->SendPacket(packet.get(), PacedPacketInfo()); |
Erik Språng | 478cb46 | 2019-06-26 15:49:27 +0200 | [diff] [blame] | 2307 | |
| 2308 | // Payload padding not available without RTX, only generate plain padding on |
| 2309 | // the media SSRC. |
| 2310 | // Number of padding packets is the requested padding size divided by max |
| 2311 | // padding packet size, rounded up. Pure padding packets are always of the |
| 2312 | // maximum size. |
| 2313 | const size_t kPaddingBytesRequested = kPayloadPacketSize + kRtxHeaderSize; |
| 2314 | const size_t kExpectedNumPaddingPackets = |
| 2315 | (kPaddingBytesRequested + kMaxPaddingSize - 1) / kMaxPaddingSize; |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 2316 | size_t padding_bytes_generated = 0; |
| 2317 | std::vector<std::unique_ptr<RtpPacketToSend>> padding_packets = |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 2318 | rtp_sender()->GeneratePadding(kPaddingBytesRequested, true); |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 2319 | EXPECT_EQ(padding_packets.size(), kExpectedNumPaddingPackets); |
| 2320 | for (auto& packet : padding_packets) { |
| 2321 | EXPECT_EQ(packet->packet_type(), RtpPacketToSend::Type::kPadding); |
| 2322 | EXPECT_EQ(packet->Ssrc(), kSsrc); |
| 2323 | EXPECT_EQ(packet->payload_size(), 0u); |
| 2324 | EXPECT_GT(packet->padding_size(), 0u); |
| 2325 | padding_bytes_generated += packet->padding_size(); |
Erik Språng | 0f6191d | 2019-07-15 20:33:40 +0200 | [diff] [blame] | 2326 | EXPECT_TRUE(packet->IsExtensionReserved<TransportSequenceNumber>()); |
| 2327 | EXPECT_TRUE(packet->IsExtensionReserved<AbsoluteSendTime>()); |
| 2328 | EXPECT_TRUE(packet->IsExtensionReserved<TransmissionOffset>()); |
| 2329 | |
| 2330 | // Verify all header extensions are received. |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 2331 | rtp_egress()->SendPacket(packet.get(), PacedPacketInfo()); |
Erik Språng | 0f6191d | 2019-07-15 20:33:40 +0200 | [diff] [blame] | 2332 | webrtc::RTPHeader rtp_header; |
| 2333 | transport_.last_sent_packet().GetHeader(&rtp_header); |
| 2334 | EXPECT_TRUE(rtp_header.extension.hasAbsoluteSendTime); |
| 2335 | EXPECT_TRUE(rtp_header.extension.hasTransmissionTimeOffset); |
| 2336 | EXPECT_TRUE(rtp_header.extension.hasTransportSequenceNumber); |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 2337 | } |
| 2338 | |
| 2339 | EXPECT_EQ(padding_bytes_generated, |
| 2340 | kExpectedNumPaddingPackets * kMaxPaddingSize); |
Erik Språng | 478cb46 | 2019-06-26 15:49:27 +0200 | [diff] [blame] | 2341 | } |
| 2342 | |
Mirko Bonadei | 999a72a | 2019-07-12 17:33:46 +0000 | [diff] [blame] | 2343 | TEST_P(RtpSenderTest, SupportsPadding) { |
| 2344 | bool kSendingMediaStats[] = {true, false}; |
| 2345 | bool kEnableRedundantPayloads[] = {true, false}; |
| 2346 | RTPExtensionType kBweExtensionTypes[] = { |
| 2347 | kRtpExtensionTransportSequenceNumber, |
| 2348 | kRtpExtensionTransportSequenceNumber02, kRtpExtensionAbsoluteSendTime, |
| 2349 | kRtpExtensionTransmissionTimeOffset}; |
| 2350 | const int kExtensionsId = 7; |
| 2351 | |
| 2352 | for (bool sending_media : kSendingMediaStats) { |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 2353 | rtp_sender()->SetSendingMediaStatus(sending_media); |
Mirko Bonadei | 999a72a | 2019-07-12 17:33:46 +0000 | [diff] [blame] | 2354 | for (bool redundant_payloads : kEnableRedundantPayloads) { |
| 2355 | int rtx_mode = kRtxRetransmitted; |
| 2356 | if (redundant_payloads) { |
| 2357 | rtx_mode |= kRtxRedundantPayloads; |
| 2358 | } |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 2359 | rtp_sender()->SetRtxStatus(rtx_mode); |
Mirko Bonadei | 999a72a | 2019-07-12 17:33:46 +0000 | [diff] [blame] | 2360 | |
| 2361 | for (auto extension_type : kBweExtensionTypes) { |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 2362 | EXPECT_FALSE(rtp_sender()->SupportsPadding()); |
| 2363 | rtp_sender()->RegisterRtpHeaderExtension(extension_type, kExtensionsId); |
Mirko Bonadei | 999a72a | 2019-07-12 17:33:46 +0000 | [diff] [blame] | 2364 | if (!sending_media) { |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 2365 | EXPECT_FALSE(rtp_sender()->SupportsPadding()); |
Mirko Bonadei | 999a72a | 2019-07-12 17:33:46 +0000 | [diff] [blame] | 2366 | } else { |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 2367 | EXPECT_TRUE(rtp_sender()->SupportsPadding()); |
Mirko Bonadei | 999a72a | 2019-07-12 17:33:46 +0000 | [diff] [blame] | 2368 | if (redundant_payloads) { |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 2369 | EXPECT_TRUE(rtp_sender()->SupportsRtxPayloadPadding()); |
Mirko Bonadei | 999a72a | 2019-07-12 17:33:46 +0000 | [diff] [blame] | 2370 | } else { |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 2371 | EXPECT_FALSE(rtp_sender()->SupportsRtxPayloadPadding()); |
Mirko Bonadei | 999a72a | 2019-07-12 17:33:46 +0000 | [diff] [blame] | 2372 | } |
| 2373 | } |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 2374 | rtp_sender()->DeregisterRtpHeaderExtension(extension_type); |
| 2375 | EXPECT_FALSE(rtp_sender()->SupportsPadding()); |
Mirko Bonadei | 999a72a | 2019-07-12 17:33:46 +0000 | [diff] [blame] | 2376 | } |
| 2377 | } |
| 2378 | } |
| 2379 | } |
| 2380 | |
Erik Språng | a57711c | 2019-07-24 10:47:20 +0200 | [diff] [blame] | 2381 | TEST_P(RtpSenderTest, SetsCaptureTimeAndPopulatesTransmissionOffset) { |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 2382 | rtp_sender()->RegisterRtpHeaderExtension(kRtpExtensionTransmissionTimeOffset, |
| 2383 | kTransmissionTimeOffsetExtensionId); |
Erik Språng | a57711c | 2019-07-24 10:47:20 +0200 | [diff] [blame] | 2384 | |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 2385 | rtp_sender()->SetSendingMediaStatus(true); |
| 2386 | rtp_sender()->SetRtxStatus(kRtxRetransmitted | kRtxRedundantPayloads); |
| 2387 | rtp_sender()->SetRtxPayloadType(kRtxPayload, kPayload); |
| 2388 | rtp_sender_context_->packet_history_.SetStorePacketsStatus( |
| 2389 | RtpPacketHistory::StorageMode::kStoreAndCull, 10); |
Erik Språng | a57711c | 2019-07-24 10:47:20 +0200 | [diff] [blame] | 2390 | |
| 2391 | const int64_t kMissingCaptureTimeMs = 0; |
| 2392 | const uint32_t kTimestampTicksPerMs = 90; |
| 2393 | const int64_t kOffsetMs = 10; |
| 2394 | |
Erik Språng | a57711c | 2019-07-24 10:47:20 +0200 | [diff] [blame] | 2395 | auto packet = |
| 2396 | BuildRtpPacket(kPayload, kMarkerBit, fake_clock_.TimeInMilliseconds(), |
| 2397 | kMissingCaptureTimeMs); |
| 2398 | packet->set_packet_type(RtpPacketToSend::Type::kVideo); |
| 2399 | packet->ReserveExtension<TransmissionOffset>(); |
| 2400 | packet->AllocatePayload(sizeof(kPayloadData)); |
| 2401 | |
| 2402 | std::unique_ptr<RtpPacketToSend> packet_to_pace; |
Erik Språng | ea55b08 | 2019-10-02 14:57:46 +0200 | [diff] [blame] | 2403 | EXPECT_CALL(mock_paced_sender_, EnqueuePackets) |
| 2404 | .WillOnce([&](std::vector<std::unique_ptr<RtpPacketToSend>> packets) { |
| 2405 | EXPECT_EQ(packets.size(), 1u); |
| 2406 | EXPECT_GT(packets[0]->capture_time_ms(), 0); |
| 2407 | packet_to_pace = std::move(packets[0]); |
Erik Språng | a57711c | 2019-07-24 10:47:20 +0200 | [diff] [blame] | 2408 | }); |
| 2409 | |
Erik Språng | 70768f4 | 2019-08-27 18:16:26 +0200 | [diff] [blame] | 2410 | packet->set_allow_retransmission(true); |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 2411 | EXPECT_TRUE(rtp_sender()->SendToNetwork(std::move(packet))); |
Erik Språng | a57711c | 2019-07-24 10:47:20 +0200 | [diff] [blame] | 2412 | |
| 2413 | fake_clock_.AdvanceTimeMilliseconds(kOffsetMs); |
| 2414 | |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 2415 | rtp_egress()->SendPacket(packet_to_pace.get(), PacedPacketInfo()); |
Erik Språng | a57711c | 2019-07-24 10:47:20 +0200 | [diff] [blame] | 2416 | |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 2417 | EXPECT_EQ(1, transport_.packets_sent()); |
| 2418 | absl::optional<int32_t> transmission_time_extension = |
| 2419 | transport_.sent_packets_.back().GetExtension<TransmissionOffset>(); |
| 2420 | ASSERT_TRUE(transmission_time_extension.has_value()); |
| 2421 | EXPECT_EQ(*transmission_time_extension, kOffsetMs * kTimestampTicksPerMs); |
Erik Språng | a57711c | 2019-07-24 10:47:20 +0200 | [diff] [blame] | 2422 | |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 2423 | // Retransmit packet. The RTX packet should get the same capture time as the |
| 2424 | // original packet, so offset is delta from original packet to now. |
| 2425 | fake_clock_.AdvanceTimeMilliseconds(kOffsetMs); |
Erik Språng | a57711c | 2019-07-24 10:47:20 +0200 | [diff] [blame] | 2426 | |
Erik Språng | a57711c | 2019-07-24 10:47:20 +0200 | [diff] [blame] | 2427 | std::unique_ptr<RtpPacketToSend> rtx_packet_to_pace; |
Erik Språng | ea55b08 | 2019-10-02 14:57:46 +0200 | [diff] [blame] | 2428 | EXPECT_CALL(mock_paced_sender_, EnqueuePackets) |
| 2429 | .WillOnce([&](std::vector<std::unique_ptr<RtpPacketToSend>> packets) { |
| 2430 | EXPECT_GT(packets[0]->capture_time_ms(), 0); |
| 2431 | rtx_packet_to_pace = std::move(packets[0]); |
Erik Språng | a57711c | 2019-07-24 10:47:20 +0200 | [diff] [blame] | 2432 | }); |
| 2433 | |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 2434 | EXPECT_GT(rtp_sender()->ReSendPacket(kSeqNum), 0); |
| 2435 | rtp_egress()->SendPacket(rtx_packet_to_pace.get(), PacedPacketInfo()); |
Erik Språng | a57711c | 2019-07-24 10:47:20 +0200 | [diff] [blame] | 2436 | |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 2437 | EXPECT_EQ(2, transport_.packets_sent()); |
| 2438 | transmission_time_extension = |
| 2439 | transport_.sent_packets_.back().GetExtension<TransmissionOffset>(); |
| 2440 | ASSERT_TRUE(transmission_time_extension.has_value()); |
| 2441 | EXPECT_EQ(*transmission_time_extension, |
| 2442 | 2 * kOffsetMs * kTimestampTicksPerMs); |
Erik Språng | a57711c | 2019-07-24 10:47:20 +0200 | [diff] [blame] | 2443 | } |
| 2444 | |
Erik Språng | 6cacef2 | 2019-07-24 14:15:51 +0200 | [diff] [blame] | 2445 | TEST_P(RtpSenderTestWithoutPacer, ClearHistoryOnSequenceNumberCange) { |
| 2446 | const int64_t kRtt = 10; |
| 2447 | |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 2448 | rtp_sender()->SetSendingMediaStatus(true); |
| 2449 | rtp_sender()->SetRtxStatus(kRtxRetransmitted | kRtxRedundantPayloads); |
| 2450 | rtp_sender()->SetRtxPayloadType(kRtxPayload, kPayload); |
| 2451 | rtp_sender_context_->packet_history_.SetStorePacketsStatus( |
| 2452 | RtpPacketHistory::StorageMode::kStoreAndCull, 10); |
| 2453 | rtp_sender_context_->packet_history_.SetRtt(kRtt); |
Erik Språng | 6cacef2 | 2019-07-24 14:15:51 +0200 | [diff] [blame] | 2454 | |
| 2455 | // Send a packet and record its sequence numbers. |
| 2456 | SendGenericPacket(); |
| 2457 | ASSERT_EQ(1u, transport_.sent_packets_.size()); |
| 2458 | const uint16_t packet_seqence_number = |
| 2459 | transport_.sent_packets_.back().SequenceNumber(); |
| 2460 | |
| 2461 | // Advance time and make sure it can be retransmitted, even if we try to set |
| 2462 | // the ssrc the what it already is. |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 2463 | rtp_sender()->SetSequenceNumber(rtp_sender()->SequenceNumber()); |
Erik Språng | 6cacef2 | 2019-07-24 14:15:51 +0200 | [diff] [blame] | 2464 | fake_clock_.AdvanceTimeMilliseconds(kRtt); |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 2465 | EXPECT_GT(rtp_sender()->ReSendPacket(packet_seqence_number), 0); |
Erik Språng | 6cacef2 | 2019-07-24 14:15:51 +0200 | [diff] [blame] | 2466 | |
| 2467 | // Change the sequence number, then move the time and try to retransmit again. |
| 2468 | // The old packet should now be gone. |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 2469 | rtp_sender()->SetSequenceNumber(rtp_sender()->SequenceNumber() - 1); |
Erik Språng | 6cacef2 | 2019-07-24 14:15:51 +0200 | [diff] [blame] | 2470 | fake_clock_.AdvanceTimeMilliseconds(kRtt); |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 2471 | EXPECT_EQ(rtp_sender()->ReSendPacket(packet_seqence_number), 0); |
Erik Språng | 6cacef2 | 2019-07-24 14:15:51 +0200 | [diff] [blame] | 2472 | } |
| 2473 | |
Erik Språng | 60ffc31 | 2019-07-30 22:03:49 +0200 | [diff] [blame] | 2474 | TEST_P(RtpSenderTest, IgnoresNackAfterDisablingMedia) { |
| 2475 | const int64_t kRtt = 10; |
| 2476 | |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 2477 | rtp_sender()->SetSendingMediaStatus(true); |
| 2478 | rtp_sender()->SetRtxStatus(kRtxRetransmitted | kRtxRedundantPayloads); |
| 2479 | rtp_sender()->SetRtxPayloadType(kRtxPayload, kPayload); |
| 2480 | rtp_sender_context_->packet_history_.SetStorePacketsStatus( |
| 2481 | RtpPacketHistory::StorageMode::kStoreAndCull, 10); |
| 2482 | rtp_sender_context_->packet_history_.SetRtt(kRtt); |
Erik Språng | 60ffc31 | 2019-07-30 22:03:49 +0200 | [diff] [blame] | 2483 | |
| 2484 | // Send a packet so it is in the packet history. |
Erik Språng | 60ffc31 | 2019-07-30 22:03:49 +0200 | [diff] [blame] | 2485 | std::unique_ptr<RtpPacketToSend> packet_to_pace; |
Erik Språng | ea55b08 | 2019-10-02 14:57:46 +0200 | [diff] [blame] | 2486 | EXPECT_CALL(mock_paced_sender_, EnqueuePackets) |
| 2487 | .WillOnce([&](std::vector<std::unique_ptr<RtpPacketToSend>> packets) { |
| 2488 | packet_to_pace = std::move(packets[0]); |
Erik Språng | 60ffc31 | 2019-07-30 22:03:49 +0200 | [diff] [blame] | 2489 | }); |
| 2490 | |
| 2491 | SendGenericPacket(); |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 2492 | rtp_egress()->SendPacket(packet_to_pace.get(), PacedPacketInfo()); |
Erik Språng | 60ffc31 | 2019-07-30 22:03:49 +0200 | [diff] [blame] | 2493 | |
| 2494 | ASSERT_EQ(1u, transport_.sent_packets_.size()); |
| 2495 | |
| 2496 | // Disable media sending and try to retransmit the packet, it should fail. |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 2497 | rtp_sender()->SetSendingMediaStatus(false); |
Erik Språng | 60ffc31 | 2019-07-30 22:03:49 +0200 | [diff] [blame] | 2498 | fake_clock_.AdvanceTimeMilliseconds(kRtt); |
Erik Språng | 77b7529 | 2019-10-28 15:51:36 +0100 | [diff] [blame] | 2499 | EXPECT_LT(rtp_sender()->ReSendPacket(kSeqNum), 0); |
Erik Språng | 60ffc31 | 2019-07-30 22:03:49 +0200 | [diff] [blame] | 2500 | } |
| 2501 | |
Mirko Bonadei | c84f661 | 2019-01-31 12:20:57 +0100 | [diff] [blame] | 2502 | INSTANTIATE_TEST_SUITE_P(WithAndWithoutOverhead, |
| 2503 | RtpSenderTest, |
Erik Språng | f5815fa | 2019-08-21 14:27:31 +0200 | [diff] [blame] | 2504 | ::testing::Values(TestConfig{false}, |
| 2505 | TestConfig{true})); |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame] | 2506 | |
Mirko Bonadei | c84f661 | 2019-01-31 12:20:57 +0100 | [diff] [blame] | 2507 | INSTANTIATE_TEST_SUITE_P(WithAndWithoutOverhead, |
| 2508 | RtpSenderTestWithoutPacer, |
Erik Språng | f5815fa | 2019-08-21 14:27:31 +0200 | [diff] [blame] | 2509 | ::testing::Values(TestConfig{false}, |
| 2510 | TestConfig{true})); |
Niels Möller | a34d776 | 2019-02-01 14:13:29 +0100 | [diff] [blame] | 2511 | |
solenberg@webrtc.org | c0352d5 | 2013-05-20 20:55:07 +0000 | [diff] [blame] | 2512 | } // namespace webrtc |