blob: 3f8a571fbd1224958dad71f5b2eae75430e3cd83 [file] [log] [blame]
Edward Lemur1f3bafb2019-10-08 17:56:33 +00001#!/usr/bin/env vpython
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +02002# Copyright (c) 2013 The Chromium Authors. All rights reserved.
maruel@chromium.org725f1c32011-04-01 20:24:54 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00006# Copyright (C) 2008 Evan Martin <martine@danga.com>
7
Andrii Shyshkalov03da1502018-10-15 03:42:34 +00008"""A git-command for integrating reviews on Gerrit."""
maruel@chromium.org725f1c32011-04-01 20:24:54 +00009
vapiera7fbd5a2016-06-16 09:17:49 -070010from __future__ import print_function
11
thakis@chromium.org3421c992014-11-02 02:20:32 +000012import base64
rmistry@google.com2dd99862015-06-22 12:22:18 +000013import collections
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +010014import datetime
Brian Sheedyb4307d52019-12-02 19:18:17 +000015import fnmatch
Edward Lemur202c5592019-10-21 22:44:52 +000016import httplib2
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +010017import itertools
maruel@chromium.org4f6852c2012-04-20 20:39:20 +000018import json
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000019import logging
calamity@chromium.orgcf197482016-04-29 20:15:53 +000020import multiprocessing
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000021import optparse
22import os
23import re
Andrii Shyshkalov353637c2017-03-14 16:52:18 +010024import shutil
ukai@chromium.org78c4b982012-02-14 02:20:26 +000025import stat
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000026import sys
Aaron Gable9a03ae02017-11-03 11:31:07 -070027import tempfile
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000028import textwrap
Edward Lemurfec80c42018-11-01 23:14:14 +000029import time
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +000030import uuid
thestig@chromium.org00858c82013-12-02 23:08:03 +000031import webbrowser
thakis@chromium.org3421c992014-11-02 02:20:32 +000032import zlib
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000033
maruel@chromium.org2e23ce32013-05-07 12:42:28 +000034from third_party import colorama
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +000035import auth
nick@chromium.org3ac1c4e2014-01-16 02:44:42 +000036import clang_format
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +000037import dart_format
maruel@chromium.org6f09cd92011-04-01 16:38:12 +000038import fix_encoding
maruel@chromium.org0e0436a2011-10-25 13:32:41 +000039import gclient_utils
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +000040import gerrit_util
iannucci@chromium.org9e849272014-04-04 00:31:55 +000041import git_common
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +000042import git_footers
Edward Lemur85153282020-02-14 22:06:29 +000043import git_new_branch
Edward Lemur5ba1e9c2018-07-23 18:19:02 +000044import metrics
Edward Lesmes93277a72018-10-18 22:04:26 +000045import metrics_utils
piman@chromium.org336f9122014-09-04 02:16:55 +000046import owners
iannucci@chromium.org9e849272014-04-04 00:31:55 +000047import owners_finder
maruel@chromium.org2a74d372011-03-29 19:05:50 +000048import presubmit_support
49import scm
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000050import setup_color
Francois Dorayd42c6812017-05-30 15:10:20 -040051import split_cl
maruel@chromium.org0633fb42013-08-16 20:06:14 +000052import subcommand
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +000053import subprocess2
maruel@chromium.org2a74d372011-03-29 19:05:50 +000054import watchlists
55
Edward Lemur79d4f992019-11-11 23:49:02 +000056from third_party import six
57from six.moves import urllib
58
59
60if sys.version_info.major == 3:
61 basestring = (str,) # pylint: disable=redefined-builtin
62
Edward Lemurb9830242019-10-30 22:19:20 +000063
tandrii7400cf02016-06-21 08:48:07 -070064__version__ = '2.0'
maruel@chromium.org2a74d372011-03-29 19:05:50 +000065
Edward Lemur0f58ae42019-04-30 17:24:12 +000066# Traces for git push will be stored in a traces directory inside the
67# depot_tools checkout.
68DEPOT_TOOLS = os.path.dirname(os.path.abspath(__file__))
69TRACES_DIR = os.path.join(DEPOT_TOOLS, 'traces')
Edward Lemur227d5102020-02-25 23:45:35 +000070PRESUBMIT_SUPPORT = os.path.join(DEPOT_TOOLS, 'presubmit_support.py')
Edward Lemur0f58ae42019-04-30 17:24:12 +000071
72# When collecting traces, Git hashes will be reduced to 6 characters to reduce
73# the size after compression.
74GIT_HASH_RE = re.compile(r'\b([a-f0-9]{6})[a-f0-9]{34}\b', flags=re.I)
75# Used to redact the cookies from the gitcookies file.
76GITCOOKIES_REDACT_RE = re.compile(r'1/.*')
77
Edward Lemurd4d1ba42019-09-20 21:46:37 +000078MAX_ATTEMPTS = 3
79
Edward Lemur1b52d872019-05-09 21:12:12 +000080# The maximum number of traces we will keep. Multiplied by 3 since we store
81# 3 files per trace.
82MAX_TRACES = 3 * 10
Edward Lemur5737f022019-05-17 01:24:00 +000083# Message to be displayed to the user to inform where to find the traces for a
84# git-cl upload execution.
Edward Lemur0f58ae42019-04-30 17:24:12 +000085TRACES_MESSAGE = (
Edward Lemur1b52d872019-05-09 21:12:12 +000086'\n'
Edward Lemur5737f022019-05-17 01:24:00 +000087'The traces of this git-cl execution have been recorded at:\n'
Edward Lemur1b52d872019-05-09 21:12:12 +000088' %(trace_name)s-traces.zip\n'
Edward Lemur5737f022019-05-17 01:24:00 +000089'Copies of your gitcookies file and git config have been recorded at:\n'
90' %(trace_name)s-git-info.zip\n')
Edward Lemur1b52d872019-05-09 21:12:12 +000091# Format of the message to be stored as part of the traces to give developers a
92# better context when they go through traces.
93TRACES_README_FORMAT = (
94'Date: %(now)s\n'
95'\n'
96'Change: https://%(gerrit_host)s/q/%(change_id)s\n'
97'Title: %(title)s\n'
98'\n'
99'%(description)s\n'
100'\n'
101'Execution time: %(execution_time)s\n'
102'Exit code: %(exit_code)s\n') + TRACES_MESSAGE
Edward Lemur0f58ae42019-04-30 17:24:12 +0000103
Aaron Gable1bc7bfe2016-12-19 10:08:14 -0800104POSTUPSTREAM_HOOK = '.git/hooks/post-cl-land'
Henrique Ferreiroff249622019-11-28 23:19:29 +0000105DESCRIPTION_BACKUP_FILE = '.git_cl_description_backup'
rmistry@google.comc68112d2015-03-03 12:48:06 +0000106REFS_THAT_ALIAS_TO_OTHER_REFS = {
107 'refs/remotes/origin/lkgr': 'refs/remotes/origin/master',
108 'refs/remotes/origin/lkcr': 'refs/remotes/origin/master',
109}
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000110
thestig@chromium.org44202a22014-03-11 19:22:18 +0000111# Valid extensions for files we want to lint.
112DEFAULT_LINT_REGEX = r"(.*\.cpp|.*\.cc|.*\.h)"
113DEFAULT_LINT_IGNORE_REGEX = r"$^"
114
Aiden Bennerc08566e2018-10-03 17:52:42 +0000115# File name for yapf style config files.
116YAPF_CONFIG_FILENAME = '.style.yapf'
117
Edward Lesmese3a49aa2020-03-24 23:46:28 +0000118# The issue, patchset and codereview server are stored on git config for each
119# branch under branch.<branch-name>.<config-key>.
120ISSUE_CONFIG_KEY = 'gerritissue'
121PATCHSET_CONFIG_KEY = 'gerritpatchset'
122CODEREVIEW_SERVER_CONFIG_KEY = 'gerritserver'
123
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000124# Shortcut since it quickly becomes repetitive.
maruel@chromium.org2e23ce32013-05-07 12:42:28 +0000125Fore = colorama.Fore
maruel@chromium.org90541732011-04-01 17:54:18 +0000126
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000127# Initialized in main()
128settings = None
129
Andrii Shyshkalov768f1d82016-12-08 15:10:13 +0100130# Used by tests/git_cl_test.py to add extra logging.
131# Inside the weirdly failing test, add this:
132# >>> self.mock(git_cl, '_IS_BEING_TESTED', True)
Quinten Yearsley0c62da92017-05-31 13:39:42 -0700133# And scroll up to see the stack trace printed.
Andrii Shyshkalov768f1d82016-12-08 15:10:13 +0100134_IS_BEING_TESTED = False
135
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000136
Andrii Shyshkalov1ee78cd2020-03-12 01:31:53 +0000137_KNOWN_GERRIT_TO_SHORT_URLS = {
138 'https://chrome-internal-review.googlesource.com': 'https://crrev.com/i',
139 'https://chromium-review.googlesource.com': 'https://crrev.com/c',
140}
141
142
Christopher Lamf732cd52017-01-24 12:40:11 +1100143def DieWithError(message, change_desc=None):
144 if change_desc:
145 SaveDescriptionBackup(change_desc)
Josip Sokcevic953278a2020-02-28 19:46:36 +0000146 print('\n ** Content of CL description **\n' +
147 '='*72 + '\n' +
148 change_desc.description + '\n' +
149 '='*72 + '\n')
Christopher Lamf732cd52017-01-24 12:40:11 +1100150
vapiera7fbd5a2016-06-16 09:17:49 -0700151 print(message, file=sys.stderr)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000152 sys.exit(1)
153
154
Christopher Lamf732cd52017-01-24 12:40:11 +1100155def SaveDescriptionBackup(change_desc):
Henrique Ferreiro5ae48172019-11-29 16:14:42 +0000156 backup_path = os.path.join(DEPOT_TOOLS, DESCRIPTION_BACKUP_FILE)
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000157 print('\nsaving CL description to %s\n' % backup_path)
Josip906bfde2020-01-31 22:38:49 +0000158 with open(backup_path, 'w') as backup_file:
159 backup_file.write(change_desc.description)
Christopher Lamf732cd52017-01-24 12:40:11 +1100160
161
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000162def GetNoGitPagerEnv():
163 env = os.environ.copy()
164 # 'cat' is a magical git string that disables pagers on all platforms.
165 env['GIT_PAGER'] = 'cat'
166 return env
167
vadimsh@chromium.org566a02a2014-08-22 01:34:13 +0000168
bsep@chromium.org627d9002016-04-29 00:00:52 +0000169def RunCommand(args, error_ok=False, error_message=None, shell=False, **kwargs):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000170 try:
Edward Lemur79d4f992019-11-11 23:49:02 +0000171 stdout = subprocess2.check_output(args, shell=shell, **kwargs)
172 return stdout.decode('utf-8', 'replace')
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000173 except subprocess2.CalledProcessError as e:
174 logging.debug('Failed running %s', args)
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +0000175 if not error_ok:
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000176 DieWithError(
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +0000177 'Command "%s" failed.\n%s' % (
178 ' '.join(args), error_message or e.stdout or ''))
Edward Lemur79d4f992019-11-11 23:49:02 +0000179 return e.stdout.decode('utf-8', 'replace')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000180
181
182def RunGit(args, **kwargs):
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +0000183 """Returns stdout."""
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000184 return RunCommand(['git'] + args, **kwargs)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000185
186
enne@chromium.org3b7e15c2014-01-21 17:44:47 +0000187def RunGitWithCode(args, suppress_stderr=False):
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +0000188 """Returns return code and stdout."""
tandrii5d48c322016-08-18 16:19:37 -0700189 if suppress_stderr:
190 stderr = subprocess2.VOID
191 else:
192 stderr = sys.stderr
szager@chromium.org9bb85e22012-06-13 20:28:23 +0000193 try:
tandrii5d48c322016-08-18 16:19:37 -0700194 (out, _), code = subprocess2.communicate(['git'] + args,
195 env=GetNoGitPagerEnv(),
196 stdout=subprocess2.PIPE,
197 stderr=stderr)
Edward Lemur79d4f992019-11-11 23:49:02 +0000198 return code, out.decode('utf-8', 'replace')
tandrii5d48c322016-08-18 16:19:37 -0700199 except subprocess2.CalledProcessError as e:
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +0900200 logging.debug('Failed running %s', ['git'] + args)
Edward Lemur79d4f992019-11-11 23:49:02 +0000201 return e.returncode, e.stdout.decode('utf-8', 'replace')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000202
203
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000204def RunGitSilent(args):
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +0000205 """Returns stdout, suppresses stderr and ignores the return code."""
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000206 return RunGitWithCode(args, suppress_stderr=True)[1]
207
208
tandrii2a16b952016-10-19 07:09:44 -0700209def time_sleep(seconds):
210 # Use this so that it can be mocked in tests without interfering with python
211 # system machinery.
tandrii2a16b952016-10-19 07:09:44 -0700212 return time.sleep(seconds)
213
214
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000215def time_time():
216 # Use this so that it can be mocked in tests without interfering with python
217 # system machinery.
218 return time.time()
219
220
Edward Lemur1b52d872019-05-09 21:12:12 +0000221def datetime_now():
222 # Use this so that it can be mocked in tests without interfering with python
223 # system machinery.
224 return datetime.datetime.now()
225
226
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100227def confirm_or_exit(prefix='', action='confirm'):
228 """Asks user to press enter to continue or press Ctrl+C to abort."""
229 if not prefix or prefix.endswith('\n'):
230 mid = 'Press'
Andrii Shyshkalov353637c2017-03-14 16:52:18 +0100231 elif prefix.endswith('.') or prefix.endswith('?'):
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100232 mid = ' Press'
233 elif prefix.endswith(' '):
234 mid = 'press'
235 else:
236 mid = ' press'
Edward Lesmesae3586b2020-03-23 21:21:14 +0000237 gclient_utils.AskForData(
238 '%s%s Enter to %s, or Ctrl+C to abort' % (prefix, mid, action))
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100239
240
241def ask_for_explicit_yes(prompt):
Quinten Yearsleyd242ed72019-07-25 17:17:55 +0000242 """Returns whether user typed 'y' or 'yes' to confirm the given prompt."""
Edward Lesmesae3586b2020-03-23 21:21:14 +0000243 result = gclient_utils.AskForData(prompt + ' [Yes/No]: ').lower()
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100244 while True:
245 if 'yes'.startswith(result):
246 return True
247 if 'no'.startswith(result):
248 return False
Edward Lesmesae3586b2020-03-23 21:21:14 +0000249 result = gclient_utils.AskForData('Please, type yes or no: ').lower()
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100250
251
machenbach@chromium.org45453142015-09-15 08:45:22 +0000252def _get_properties_from_options(options):
Quinten Yearsleya19d3532019-09-30 21:54:39 +0000253 prop_list = getattr(options, 'properties', [])
254 properties = dict(x.split('=', 1) for x in prop_list)
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +0000255 for key, val in properties.items():
machenbach@chromium.org45453142015-09-15 08:45:22 +0000256 try:
257 properties[key] = json.loads(val)
258 except ValueError:
259 pass # If a value couldn't be evaluated, treat it as a string.
260 return properties
261
262
Edward Lemur4c707a22019-09-24 21:13:43 +0000263def _call_buildbucket(http, buildbucket_host, method, request):
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000264 """Calls a buildbucket v2 method and returns the parsed json response."""
265 headers = {
266 'Accept': 'application/json',
267 'Content-Type': 'application/json',
268 }
269 request = json.dumps(request)
270 url = 'https://%s/prpc/buildbucket.v2.Builds/%s' % (buildbucket_host, method)
271
272 logging.info('POST %s with %s' % (url, request))
273
274 attempts = 1
275 time_to_sleep = 1
276 while True:
277 response, content = http.request(url, 'POST', body=request, headers=headers)
278 if response.status == 200:
279 return json.loads(content[4:])
280 if attempts >= MAX_ATTEMPTS or 400 <= response.status < 500:
281 msg = '%s error when calling POST %s with %s: %s' % (
282 response.status, url, request, content)
283 raise BuildbucketResponseException(msg)
284 logging.debug(
285 '%s error when calling POST %s with %s. '
286 'Sleeping for %d seconds and retrying...' % (
287 response.status, url, request, time_to_sleep))
288 time.sleep(time_to_sleep)
289 time_to_sleep *= 2
290 attempts += 1
291
292 assert False, 'unreachable'
293
294
Edward Lemur6215c792019-10-03 21:59:05 +0000295def _parse_bucket(raw_bucket):
296 legacy = True
297 project = bucket = None
298 if '/' in raw_bucket:
299 legacy = False
300 project, bucket = raw_bucket.split('/', 1)
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000301 # Assume luci.<project>.<bucket>.
Edward Lemur6215c792019-10-03 21:59:05 +0000302 elif raw_bucket.startswith('luci.'):
303 project, bucket = raw_bucket[len('luci.'):].split('.', 1)
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000304 # Otherwise, assume prefix is also the project name.
Edward Lemur6215c792019-10-03 21:59:05 +0000305 elif '.' in raw_bucket:
306 project = raw_bucket.split('.')[0]
307 bucket = raw_bucket
308 # Legacy buckets.
Edward Lemur45768512020-03-02 19:03:14 +0000309 if legacy and project and bucket:
Edward Lemur6215c792019-10-03 21:59:05 +0000310 print('WARNING Please use %s/%s to specify the bucket.' % (project, bucket))
311 return project, bucket
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000312
313
Quinten Yearsley777660f2020-03-04 23:37:06 +0000314def _trigger_tryjobs(changelist, jobs, options, patchset):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000315 """Sends a request to Buildbucket to trigger tryjobs for a changelist.
qyearsley1fdfcb62016-10-24 13:22:03 -0700316
317 Args:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000318 changelist: Changelist that the tryjobs are associated with.
Edward Lemur45768512020-03-02 19:03:14 +0000319 jobs: A list of (project, bucket, builder).
qyearsley1fdfcb62016-10-24 13:22:03 -0700320 options: Command-line options.
321 """
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000322 print('Scheduling jobs on:')
Edward Lemur45768512020-03-02 19:03:14 +0000323 for project, bucket, builder in jobs:
324 print(' %s/%s: %s' % (project, bucket, builder))
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000325 print('To see results here, run: git cl try-results')
326 print('To see results in browser, run: git cl web')
tandriide281ae2016-10-12 06:02:30 -0700327
Quinten Yearsley777660f2020-03-04 23:37:06 +0000328 requests = _make_tryjob_schedule_requests(changelist, jobs, options, patchset)
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +0000329 if not requests:
330 return
331
Edward Lemur5b929a42019-10-21 17:57:39 +0000332 http = auth.Authenticator().authorize(httplib2.Http())
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +0000333 http.force_exception_to_status_code = True
334
335 batch_request = {'requests': requests}
336 batch_response = _call_buildbucket(
337 http, options.buildbucket_host, 'Batch', batch_request)
338
339 errors = [
340 ' ' + response['error']['message']
341 for response in batch_response.get('responses', [])
342 if 'error' in response
343 ]
344 if errors:
345 raise BuildbucketResponseException(
346 'Failed to schedule builds for some bots:\n%s' % '\n'.join(errors))
347
348
Quinten Yearsley777660f2020-03-04 23:37:06 +0000349def _make_tryjob_schedule_requests(changelist, jobs, options, patchset):
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +0000350 """Constructs requests for Buildbucket to trigger tryjobs."""
Edward Lemurf0faf482019-09-25 20:40:17 +0000351 gerrit_changes = [changelist.GetGerritChange(patchset)]
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +0000352 shared_properties = {
353 'category': options.ensure_value('category', 'git_cl_try')
354 }
355 if options.ensure_value('clobber', False):
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000356 shared_properties['clobber'] = True
357 shared_properties.update(_get_properties_from_options(options) or {})
358
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +0000359 shared_tags = [{'key': 'user_agent', 'value': 'git_cl_try'}]
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +0000360 if options.ensure_value('retry_failed', False):
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +0000361 shared_tags.append({'key': 'retry_failed',
362 'value': '1'})
363
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000364 requests = []
Edward Lemur45768512020-03-02 19:03:14 +0000365 for (project, bucket, builder) in jobs:
366 properties = shared_properties.copy()
367 if 'presubmit' in builder.lower():
368 properties['dry_run'] = 'true'
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000369
Edward Lemur45768512020-03-02 19:03:14 +0000370 requests.append({
371 'scheduleBuild': {
372 'requestId': str(uuid.uuid4()),
373 'builder': {
374 'project': getattr(options, 'project', None) or project,
375 'bucket': bucket,
376 'builder': builder,
377 },
378 'gerritChanges': gerrit_changes,
379 'properties': properties,
380 'tags': [
381 {'key': 'builder', 'value': builder},
382 ] + shared_tags,
383 }
384 })
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000385
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +0000386 if options.ensure_value('revision', None):
Edward Lemur45768512020-03-02 19:03:14 +0000387 requests[-1]['scheduleBuild']['gitilesCommit'] = {
388 'host': gerrit_changes[0]['host'],
389 'project': gerrit_changes[0]['project'],
390 'id': options.revision
391 }
Anthony Polito1a5fe232020-01-24 23:17:52 +0000392
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +0000393 return requests
kjellander@chromium.org44424542015-06-02 18:35:29 +0000394
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000395
Quinten Yearsley777660f2020-03-04 23:37:06 +0000396def _fetch_tryjobs(changelist, buildbucket_host, patchset=None):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000397 """Fetches tryjobs from buildbucket.
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000398
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000399 Returns list of buildbucket.v2.Build with the try jobs for the changelist.
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000400 """
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +0000401 fields = ['id', 'builder', 'status', 'createTime', 'tags']
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000402 request = {
403 'predicate': {
404 'gerritChanges': [changelist.GetGerritChange(patchset)],
405 },
406 'fields': ','.join('builds.*.' + field for field in fields),
407 }
tandrii221ab252016-10-06 08:12:04 -0700408
Edward Lemur5b929a42019-10-21 17:57:39 +0000409 authenticator = auth.Authenticator()
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000410 if authenticator.has_cached_credentials():
411 http = authenticator.authorize(httplib2.Http())
412 else:
vapiera7fbd5a2016-06-16 09:17:49 -0700413 print('Warning: Some results might be missing because %s' %
414 # Get the message on how to login.
Edward Lemurba5bc992019-09-23 22:59:17 +0000415 (auth.LoginRequiredError().message,))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000416 http = httplib2.Http()
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000417 http.force_exception_to_status_code = True
418
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000419 response = _call_buildbucket(http, buildbucket_host, 'SearchBuilds', request)
420 return response.get('builds', [])
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000421
Edward Lemur45768512020-03-02 19:03:14 +0000422
Edward Lemur5b929a42019-10-21 17:57:39 +0000423def _fetch_latest_builds(changelist, buildbucket_host, latest_patchset=None):
Quinten Yearsley983111f2019-09-26 17:18:48 +0000424 """Fetches builds from the latest patchset that has builds (within
425 the last few patchsets).
426
427 Args:
Quinten Yearsley983111f2019-09-26 17:18:48 +0000428 changelist (Changelist): The CL to fetch builds for
429 buildbucket_host (str): Buildbucket host, e.g. "cr-buildbucket.appspot.com"
Andrii Shyshkalov1ad58112019-10-08 01:46:14 +0000430 lastest_patchset(int|NoneType): the patchset to start fetching builds from.
431 If None (default), starts with the latest available patchset.
Quinten Yearsley983111f2019-09-26 17:18:48 +0000432 Returns:
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000433 A tuple (builds, patchset) where builds is a list of buildbucket.v2.Build,
434 and patchset is the patchset number where those builds came from.
Quinten Yearsley983111f2019-09-26 17:18:48 +0000435 """
436 assert buildbucket_host
437 assert changelist.GetIssue(), 'CL must be uploaded first'
438 assert changelist.GetCodereviewServer(), 'CL must be uploaded first'
Andrii Shyshkalov1ad58112019-10-08 01:46:14 +0000439 if latest_patchset is None:
440 assert changelist.GetMostRecentPatchset()
441 ps = changelist.GetMostRecentPatchset()
442 else:
443 assert latest_patchset > 0, latest_patchset
444 ps = latest_patchset
445
Quinten Yearsley983111f2019-09-26 17:18:48 +0000446 min_ps = max(1, ps - 5)
447 while ps >= min_ps:
Quinten Yearsley777660f2020-03-04 23:37:06 +0000448 builds = _fetch_tryjobs(changelist, buildbucket_host, patchset=ps)
Quinten Yearsley983111f2019-09-26 17:18:48 +0000449 if len(builds):
450 return builds, ps
451 ps -= 1
452 return [], 0
453
454
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +0000455def _filter_failed_for_retry(all_builds):
456 """Returns a list of buckets/builders that are worth retrying.
Quinten Yearsley983111f2019-09-26 17:18:48 +0000457
458 Args:
Quinten Yearsley777660f2020-03-04 23:37:06 +0000459 all_builds (list): Builds, in the format returned by _fetch_tryjobs,
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000460 i.e. a list of buildbucket.v2.Builds which includes status and builder
461 info.
Quinten Yearsley983111f2019-09-26 17:18:48 +0000462
463 Returns:
Edward Lemur45768512020-03-02 19:03:14 +0000464 A dict {(proj, bucket): [builders]}. This is the same format accepted by
Quinten Yearsley777660f2020-03-04 23:37:06 +0000465 _trigger_tryjobs.
Quinten Yearsley983111f2019-09-26 17:18:48 +0000466 """
Edward Lemur45768512020-03-02 19:03:14 +0000467 grouped = {}
468 for build in all_builds:
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +0000469 builder = build['builder']
Edward Lemur45768512020-03-02 19:03:14 +0000470 key = (builder['project'], builder['bucket'], builder['builder'])
471 grouped.setdefault(key, []).append(build)
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +0000472
Edward Lemur45768512020-03-02 19:03:14 +0000473 jobs = []
474 for (project, bucket, builder), builds in grouped.items():
475 if 'triggered' in builder:
476 print('WARNING: Not scheduling %s. Triggered bots require an initial job '
477 'from a parent. Please schedule a manual job for the parent '
478 'instead.')
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +0000479 continue
480 if any(b['status'] in ('STARTED', 'SCHEDULED') for b in builds):
481 # Don't retry if any are running.
482 continue
Edward Lemur45768512020-03-02 19:03:14 +0000483 # If builder had several builds, retry only if the last one failed.
484 # This is a bit different from CQ, which would re-use *any* SUCCESS-full
485 # build, but in case of retrying failed jobs retrying a flaky one makes
486 # sense.
487 builds = sorted(builds, key=lambda b: b['createTime'])
488 if builds[-1]['status'] not in ('FAILURE', 'INFRA_FAILURE'):
489 continue
490 # Don't retry experimental build previously triggered by CQ.
491 if any(t['key'] == 'cq_experimental' and t['value'] == 'true'
492 for t in builds[-1]['tags']):
493 continue
494 jobs.append((project, bucket, builder))
495
496 # Sort the jobs to make testing easier.
497 return sorted(jobs)
Quinten Yearsley983111f2019-09-26 17:18:48 +0000498
499
Quinten Yearsley777660f2020-03-04 23:37:06 +0000500def _print_tryjobs(options, builds):
501 """Prints nicely result of _fetch_tryjobs."""
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000502 if not builds:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000503 print('No tryjobs scheduled.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000504 return
505
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000506 longest_builder = max(len(b['builder']['builder']) for b in builds)
507 name_fmt = '{builder:<%d}' % longest_builder
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000508 if options.print_master:
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000509 longest_bucket = max(len(b['builder']['bucket']) for b in builds)
510 name_fmt = ('{bucket:>%d} ' % longest_bucket) + name_fmt
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000511
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000512 builds_by_status = {}
513 for b in builds:
514 builds_by_status.setdefault(b['status'], []).append({
515 'id': b['id'],
516 'name': name_fmt.format(
517 builder=b['builder']['builder'], bucket=b['builder']['bucket']),
518 })
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000519
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000520 sort_key = lambda b: (b['name'], b['id'])
521
522 def print_builds(title, builds, fmt=None, color=None):
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000523 """Pop matching builds from `builds` dict and print them."""
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000524 if not builds:
525 return
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000526
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000527 fmt = fmt or '{name} https://ci.chromium.org/b/{id}'
tandrii@chromium.org6cf98c82016-03-15 11:56:00 +0000528 if not options.color or color is None:
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000529 colorize = lambda x: x
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000530 else:
531 colorize = lambda x: '%s%s%s' % (color, x, Fore.RESET)
532
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000533 print(colorize(title))
534 for b in sorted(builds, key=sort_key):
535 print(' ', colorize(fmt.format(**b)))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000536
537 total = len(builds)
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000538 print_builds(
539 'Successes:', builds_by_status.pop('SUCCESS', []), color=Fore.GREEN)
540 print_builds(
541 'Infra Failures:', builds_by_status.pop('INFRA_FAILURE', []),
542 color=Fore.MAGENTA)
543 print_builds('Failures:', builds_by_status.pop('FAILURE', []), color=Fore.RED)
544 print_builds('Canceled:', builds_by_status.pop('CANCELED', []), fmt='{name}',
545 color=Fore.MAGENTA)
546 print_builds('Started:', builds_by_status.pop('STARTED', []))
547 print_builds(
548 'Scheduled:', builds_by_status.pop('SCHEDULED', []), fmt='{name} id={id}')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000549 # The last section is just in case buildbucket API changes OR there is a bug.
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000550 print_builds(
551 'Other:', sum(builds_by_status.values(), []), fmt='{name} id={id}')
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000552 print('Total: %d tryjobs' % total)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000553
554
Aiden Bennerc08566e2018-10-03 17:52:42 +0000555def _ComputeDiffLineRanges(files, upstream_commit):
556 """Gets the changed line ranges for each file since upstream_commit.
557
558 Parses a git diff on provided files and returns a dict that maps a file name
559 to an ordered list of range tuples in the form (start_line, count).
560 Ranges are in the same format as a git diff.
561 """
562 # If files is empty then diff_output will be a full diff.
563 if len(files) == 0:
564 return {}
565
Aiden Benner6c18a1a2018-11-23 20:18:23 +0000566 # Take the git diff and find the line ranges where there are changes.
Jamie Madill3671a6a2019-10-24 15:13:21 +0000567 diff_cmd = BuildGitDiffCmd('-U0', upstream_commit, files, allow_prefix=True)
Aiden Bennerc08566e2018-10-03 17:52:42 +0000568 diff_output = RunGit(diff_cmd)
569
570 pattern = r'(?:^diff --git a/(?:.*) b/(.*))|(?:^@@.*\+(.*) @@)'
571 # 2 capture groups
572 # 0 == fname of diff file
573 # 1 == 'diff_start,diff_count' or 'diff_start'
574 # will match each of
575 # diff --git a/foo.foo b/foo.py
576 # @@ -12,2 +14,3 @@
577 # @@ -12,2 +17 @@
578 # running re.findall on the above string with pattern will give
579 # [('foo.py', ''), ('', '14,3'), ('', '17')]
580
581 curr_file = None
582 line_diffs = {}
583 for match in re.findall(pattern, diff_output, flags=re.MULTILINE):
584 if match[0] != '':
585 # Will match the second filename in diff --git a/a.py b/b.py.
586 curr_file = match[0]
587 line_diffs[curr_file] = []
588 else:
589 # Matches +14,3
590 if ',' in match[1]:
591 diff_start, diff_count = match[1].split(',')
592 else:
593 # Single line changes are of the form +12 instead of +12,1.
594 diff_start = match[1]
595 diff_count = 1
596
597 diff_start = int(diff_start)
598 diff_count = int(diff_count)
599
600 # If diff_count == 0 this is a removal we can ignore.
601 line_diffs[curr_file].append((diff_start, diff_count))
602
603 return line_diffs
604
605
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000606def _FindYapfConfigFile(fpath, yapf_config_cache, top_dir=None):
Aiden Bennerc08566e2018-10-03 17:52:42 +0000607 """Checks if a yapf file is in any parent directory of fpath until top_dir.
608
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000609 Recursively checks parent directories to find yapf file and if no yapf file
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000610 is found returns None. Uses yapf_config_cache as a cache for previously found
611 configs.
Aiden Bennerc08566e2018-10-03 17:52:42 +0000612 """
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000613 fpath = os.path.abspath(fpath)
Aiden Bennerc08566e2018-10-03 17:52:42 +0000614 # Return result if we've already computed it.
615 if fpath in yapf_config_cache:
616 return yapf_config_cache[fpath]
617
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000618 parent_dir = os.path.dirname(fpath)
619 if os.path.isfile(fpath):
620 ret = _FindYapfConfigFile(parent_dir, yapf_config_cache, top_dir)
Aiden Bennerc08566e2018-10-03 17:52:42 +0000621 else:
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000622 # Otherwise fpath is a directory
623 yapf_file = os.path.join(fpath, YAPF_CONFIG_FILENAME)
624 if os.path.isfile(yapf_file):
625 ret = yapf_file
626 elif fpath == top_dir or parent_dir == fpath:
627 # If we're at the top level directory, or if we're at root
628 # there is no provided style.
629 ret = None
630 else:
631 # Otherwise recurse on the current directory.
632 ret = _FindYapfConfigFile(parent_dir, yapf_config_cache, top_dir)
Aiden Bennerc08566e2018-10-03 17:52:42 +0000633 yapf_config_cache[fpath] = ret
634 return ret
635
636
Brian Sheedyb4307d52019-12-02 19:18:17 +0000637def _GetYapfIgnorePatterns(top_dir):
638 """Returns all patterns in the .yapfignore file.
Brian Sheedy59b06a82019-10-14 17:03:29 +0000639
640 yapf is supposed to handle the ignoring of files listed in .yapfignore itself,
641 but this functionality appears to break when explicitly passing files to
642 yapf for formatting. According to
643 https://github.com/google/yapf/blob/master/README.rst#excluding-files-from-formatting-yapfignore,
644 the .yapfignore file should be in the directory that yapf is invoked from,
645 which we assume to be the top level directory in this case.
646
647 Args:
648 top_dir: The top level directory for the repository being formatted.
649
650 Returns:
Brian Sheedyb4307d52019-12-02 19:18:17 +0000651 A set of all fnmatch patterns to be ignored.
Brian Sheedy59b06a82019-10-14 17:03:29 +0000652 """
653 yapfignore_file = os.path.join(top_dir, '.yapfignore')
Brian Sheedyb4307d52019-12-02 19:18:17 +0000654 ignore_patterns = set()
Brian Sheedy59b06a82019-10-14 17:03:29 +0000655 if not os.path.exists(yapfignore_file):
Brian Sheedyb4307d52019-12-02 19:18:17 +0000656 return ignore_patterns
Brian Sheedy59b06a82019-10-14 17:03:29 +0000657
Brian Sheedyb4307d52019-12-02 19:18:17 +0000658 with open(yapfignore_file) as f:
659 for line in f.readlines():
660 stripped_line = line.strip()
661 # Comments and blank lines should be ignored.
662 if stripped_line.startswith('#') or stripped_line == '':
663 continue
664 ignore_patterns.add(stripped_line)
665 return ignore_patterns
666
667
668def _FilterYapfIgnoredFiles(filepaths, patterns):
669 """Filters out any filepaths that match any of the given patterns.
670
671 Args:
672 filepaths: An iterable of strings containing filepaths to filter.
673 patterns: An iterable of strings containing fnmatch patterns to filter on.
674
675 Returns:
676 A list of strings containing all the elements of |filepaths| that did not
677 match any of the patterns in |patterns|.
678 """
679 # Not inlined so that tests can use the same implementation.
680 return [f for f in filepaths
681 if not any(fnmatch.fnmatch(f, p) for p in patterns)]
Brian Sheedy59b06a82019-10-14 17:03:29 +0000682
683
Aaron Gable13101a62018-02-09 13:20:41 -0800684def print_stats(args):
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000685 """Prints statistics about the change to the user."""
686 # --no-ext-diff is broken in some versions of Git, so try to work around
687 # this by overriding the environment (but there is still a problem if the
688 # git config key "diff.external" is used).
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000689 env = GetNoGitPagerEnv()
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000690 if 'GIT_EXTERNAL_DIFF' in env:
691 del env['GIT_EXTERNAL_DIFF']
iannucci@chromium.org79540052012-10-19 23:15:26 +0000692
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000693 return subprocess2.call(
Aaron Gable13101a62018-02-09 13:20:41 -0800694 ['git', 'diff', '--no-ext-diff', '--stat', '-l100000', '-C50'] + args,
Edward Lemur0db01f02019-11-12 22:01:51 +0000695 env=env)
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000696
697
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000698class BuildbucketResponseException(Exception):
699 pass
700
701
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000702class Settings(object):
703 def __init__(self):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000704 self.cc = None
thestig@chromium.org7a54e812014-02-11 19:57:22 +0000705 self.root = None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000706 self.tree_status_url = None
707 self.viewvc_url = None
708 self.updated = False
ukai@chromium.orge8077812012-02-03 03:41:46 +0000709 self.is_gerrit = None
bauerb@chromium.org54b400c2016-01-14 10:08:25 +0000710 self.squash_gerrit_uploads = None
tandrii@chromium.org28253532016-04-14 13:46:56 +0000711 self.gerrit_skip_ensure_authenticated = None
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000712 self.git_editor = None
Jamie Madilldc4d19e2019-10-24 21:50:02 +0000713 self.format_full_by_default = None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000714
Edward Lemur26964072020-02-19 19:18:51 +0000715 def _LazyUpdateIfNeeded(self):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000716 """Updates the settings from a codereview.settings file, if available."""
Edward Lemur26964072020-02-19 19:18:51 +0000717 if self.updated:
718 return
pgervais@chromium.org87884cc2014-01-03 22:23:41 +0000719
Edward Lemur26964072020-02-19 19:18:51 +0000720 # The only value that actually changes the behavior is
721 # autoupdate = "false". Everything else means "true".
722 autoupdate = (
723 scm.GIT.GetConfig(self.GetRoot(), 'rietveld.autoupdate', '').lower())
724
725 cr_settings_file = FindCodereviewSettingsFile()
726 if autoupdate != 'false' and cr_settings_file:
727 LoadCodereviewSettingsFromFile(cr_settings_file)
728 cr_settings_file.close()
729
730 self.updated = True
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000731
thestig@chromium.org7a54e812014-02-11 19:57:22 +0000732 @staticmethod
733 def GetRelativeRoot():
Edward Lesmese3a49aa2020-03-24 23:46:28 +0000734 return scm.GIT.GetCheckoutRoot(None)
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000735
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000736 def GetRoot(self):
thestig@chromium.org7a54e812014-02-11 19:57:22 +0000737 if self.root is None:
738 self.root = os.path.abspath(self.GetRelativeRoot())
739 return self.root
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000740
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000741 def GetTreeStatusUrl(self, error_ok=False):
742 if not self.tree_status_url:
Edward Lemur26964072020-02-19 19:18:51 +0000743 self.tree_status_url = self._GetConfig('rietveld.tree-status-url')
744 if self.tree_status_url is None and not error_ok:
745 DieWithError(
746 'You must configure your tree status URL by running '
747 '"git cl config".')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000748 return self.tree_status_url
749
750 def GetViewVCUrl(self):
751 if not self.viewvc_url:
Edward Lemur26964072020-02-19 19:18:51 +0000752 self.viewvc_url = self._GetConfig('rietveld.viewvc-url')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000753 return self.viewvc_url
754
rmistry@google.com90752582014-01-14 21:04:50 +0000755 def GetBugPrefix(self):
Edward Lemur26964072020-02-19 19:18:51 +0000756 return self._GetConfig('rietveld.bug-prefix')
rmistry@google.com78948ed2015-07-08 23:09:57 +0000757
rmistry@google.com5626a922015-02-26 14:03:30 +0000758 def GetRunPostUploadHook(self):
Edward Lemur61ea3072018-12-01 00:34:36 +0000759 run_post_upload_hook = self._GetConfig(
Edward Lemur26964072020-02-19 19:18:51 +0000760 'rietveld.run-post-upload-hook')
rmistry@google.com5626a922015-02-26 14:03:30 +0000761 return run_post_upload_hook == "True"
762
bauerb@chromium.orgae6df352011-04-06 17:40:39 +0000763 def GetDefaultCCList(self):
Edward Lemur26964072020-02-19 19:18:51 +0000764 return self._GetConfig('rietveld.cc')
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000765
bauerb@chromium.org54b400c2016-01-14 10:08:25 +0000766 def GetSquashGerritUploads(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000767 """Returns True if uploads to Gerrit should be squashed by default."""
bauerb@chromium.org54b400c2016-01-14 10:08:25 +0000768 if self.squash_gerrit_uploads is None:
tandriia60502f2016-06-20 02:01:53 -0700769 self.squash_gerrit_uploads = self.GetSquashGerritUploadsOverride()
Edward Lemur26964072020-02-19 19:18:51 +0000770 if self.squash_gerrit_uploads is None:
771 # Default is squash now (http://crbug.com/611892#c23).
772 self.squash_gerrit_uploads = self._GetConfig(
773 'gerrit.squash-uploads').lower() != 'false'
bauerb@chromium.org54b400c2016-01-14 10:08:25 +0000774 return self.squash_gerrit_uploads
775
tandriia60502f2016-06-20 02:01:53 -0700776 def GetSquashGerritUploadsOverride(self):
777 """Return True or False if codereview.settings should be overridden.
778
779 Returns None if no override has been defined.
780 """
781 # See also http://crbug.com/611892#c23
Edward Lemur26964072020-02-19 19:18:51 +0000782 result = self._GetConfig('gerrit.override-squash-uploads').lower()
tandriia60502f2016-06-20 02:01:53 -0700783 if result == 'true':
784 return True
785 if result == 'false':
786 return False
787 return None
788
tandrii@chromium.org28253532016-04-14 13:46:56 +0000789 def GetGerritSkipEnsureAuthenticated(self):
790 """Return True if EnsureAuthenticated should not be done for Gerrit
791 uploads."""
792 if self.gerrit_skip_ensure_authenticated is None:
Edward Lemur26964072020-02-19 19:18:51 +0000793 self.gerrit_skip_ensure_authenticated = self._GetConfig(
794 'gerrit.skip-ensure-authenticated').lower() == 'true'
tandrii@chromium.org28253532016-04-14 13:46:56 +0000795 return self.gerrit_skip_ensure_authenticated
796
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000797 def GetGitEditor(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000798 """Returns the editor specified in the git config, or None if none is."""
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000799 if self.git_editor is None:
Raul Tambre5a525872019-02-12 19:08:08 +0000800 # Git requires single quotes for paths with spaces. We need to replace
801 # them with double quotes for Windows to treat such paths as a single
802 # path.
Edward Lemur26964072020-02-19 19:18:51 +0000803 self.git_editor = self._GetConfig('core.editor').replace('\'', '"')
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000804 return self.git_editor or None
805
thestig@chromium.org44202a22014-03-11 19:22:18 +0000806 def GetLintRegex(self):
Edward Lemur26964072020-02-19 19:18:51 +0000807 return self._GetConfig('rietveld.cpplint-regex', DEFAULT_LINT_REGEX)
thestig@chromium.org44202a22014-03-11 19:22:18 +0000808
809 def GetLintIgnoreRegex(self):
Edward Lemur26964072020-02-19 19:18:51 +0000810 return self._GetConfig(
811 'rietveld.cpplint-ignore-regex', DEFAULT_LINT_IGNORE_REGEX)
thestig@chromium.org44202a22014-03-11 19:22:18 +0000812
Jamie Madilldc4d19e2019-10-24 21:50:02 +0000813 def GetFormatFullByDefault(self):
814 if self.format_full_by_default is None:
815 result = (
816 RunGit(['config', '--bool', 'rietveld.format-full-by-default'],
817 error_ok=True).strip())
818 self.format_full_by_default = (result == 'true')
819 return self.format_full_by_default
820
Edward Lemur26964072020-02-19 19:18:51 +0000821 def _GetConfig(self, key, default=''):
822 self._LazyUpdateIfNeeded()
823 return scm.GIT.GetConfig(self.GetRoot(), key, default)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000824
825
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +0000826class _CQState(object):
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +0000827 """Enum for states of CL with respect to CQ."""
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +0000828 NONE = 'none'
829 DRY_RUN = 'dry_run'
830 COMMIT = 'commit'
831
832 ALL_STATES = [NONE, DRY_RUN, COMMIT]
833
834
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000835class _ParsedIssueNumberArgument(object):
Edward Lemurf38bc172019-09-03 21:02:13 +0000836 def __init__(self, issue=None, patchset=None, hostname=None):
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000837 self.issue = issue
838 self.patchset = patchset
839 self.hostname = hostname
840
841 @property
842 def valid(self):
843 return self.issue is not None
844
845
Edward Lemurf38bc172019-09-03 21:02:13 +0000846def ParseIssueNumberArgument(arg):
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000847 """Parses the issue argument and returns _ParsedIssueNumberArgument."""
848 fail_result = _ParsedIssueNumberArgument()
849
Edward Lemur678a6842019-10-03 22:25:05 +0000850 if isinstance(arg, int):
851 return _ParsedIssueNumberArgument(issue=arg)
852 if not isinstance(arg, basestring):
853 return fail_result
854
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000855 if arg.isdigit():
Edward Lemurf38bc172019-09-03 21:02:13 +0000856 return _ParsedIssueNumberArgument(issue=int(arg))
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000857 if not arg.startswith('http'):
858 return fail_result
Aaron Gableaee6c852017-06-26 12:49:01 -0700859
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000860 url = gclient_utils.UpgradeToHttps(arg)
861 try:
Edward Lemur79d4f992019-11-11 23:49:02 +0000862 parsed_url = urllib.parse.urlparse(url)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000863 except ValueError:
864 return fail_result
Andrii Shyshkalov28d840e2017-04-10 15:45:09 +0200865
Edward Lemur678a6842019-10-03 22:25:05 +0000866 # Gerrit's new UI is https://domain/c/project/+/<issue_number>[/[patchset]]
867 # But old GWT UI is https://domain/#/c/project/+/<issue_number>[/[patchset]]
868 # Short urls like https://domain/<issue_number> can be used, but don't allow
869 # specifying the patchset (you'd 404), but we allow that here.
870 if parsed_url.path == '/':
871 part = parsed_url.fragment
872 else:
873 part = parsed_url.path
874
875 match = re.match(
876 r'(/c(/.*/\+)?)?/(?P<issue>\d+)(/(?P<patchset>\d+)?/?)?$', part)
877 if not match:
878 return fail_result
879
880 issue = int(match.group('issue'))
881 patchset = match.group('patchset')
882 return _ParsedIssueNumberArgument(
883 issue=issue,
884 patchset=int(patchset) if patchset else None,
885 hostname=parsed_url.netloc)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000886
887
Andrii Shyshkalovb07575f2018-10-16 06:16:21 +0000888def _create_description_from_log(args):
889 """Pulls out the commit log to use as a base for the CL description."""
890 log_args = []
891 if len(args) == 1 and not args[0].endswith('.'):
892 log_args = [args[0] + '..']
893 elif len(args) == 1 and args[0].endswith('...'):
894 log_args = [args[0][:-1]]
895 elif len(args) == 2:
896 log_args = [args[0] + '..' + args[1]]
897 else:
898 log_args = args[:] # Hope for the best!
Edward Lemura12175c2020-03-09 16:58:26 +0000899 return RunGit(['log', '--pretty=format:%s%n%n%b'] + log_args)
Andrii Shyshkalovb07575f2018-10-16 06:16:21 +0000900
901
Aaron Gablea45ee112016-11-22 15:14:38 -0800902class GerritChangeNotExists(Exception):
tandriic2405f52016-10-10 08:13:15 -0700903 def __init__(self, issue, url):
904 self.issue = issue
905 self.url = url
Aaron Gablea45ee112016-11-22 15:14:38 -0800906 super(GerritChangeNotExists, self).__init__()
tandriic2405f52016-10-10 08:13:15 -0700907
908 def __str__(self):
Aaron Gablea45ee112016-11-22 15:14:38 -0800909 return 'change %s at %s does not exist or you have no access to it' % (
tandriic2405f52016-10-10 08:13:15 -0700910 self.issue, self.url)
911
912
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +0100913_CommentSummary = collections.namedtuple(
Quinten Yearsley0e617c02019-02-20 00:37:03 +0000914 '_CommentSummary', ['date', 'message', 'sender', 'autogenerated',
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +0100915 # TODO(tandrii): these two aren't known in Gerrit.
916 'approval', 'disapproval'])
917
918
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000919class Changelist(object):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +0000920 """Changelist works with one changelist in local branch.
921
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +0000922 Notes:
923 * Not safe for concurrent multi-{thread,process} use.
924 * Caches values from current branch. Therefore, re-use after branch change
tandrii5d48c322016-08-18 16:19:37 -0700925 with great care.
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +0000926 """
927
Edward Lemur125d60a2019-09-13 18:25:41 +0000928 def __init__(self, branchref=None, issue=None, codereview_host=None):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +0000929 """Create a new ChangeList instance.
930
Edward Lemurf38bc172019-09-03 21:02:13 +0000931 **kwargs will be passed directly to Gerrit implementation.
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +0000932 """
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000933 # Poke settings so we get the "configure your server" message if necessary.
maruel@chromium.org379d07a2011-11-30 14:58:10 +0000934 global settings
935 if not settings:
936 # Happens when git_cl.py is used as a utility library.
937 settings = Settings()
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +0000938
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000939 self.branchref = branchref
940 if self.branchref:
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +0000941 assert branchref.startswith('refs/heads/')
Edward Lemur85153282020-02-14 22:06:29 +0000942 self.branch = scm.GIT.ShortBranchName(self.branchref)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000943 else:
944 self.branch = None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000945 self.upstream_branch = None
maruel@chromium.org1033efd2013-07-23 23:25:09 +0000946 self.lookedup_issue = False
947 self.issue = issue or None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000948 self.description = None
maruel@chromium.org1033efd2013-07-23 23:25:09 +0000949 self.lookedup_patchset = False
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000950 self.patchset = None
bauerb@chromium.orgae6df352011-04-06 17:40:39 +0000951 self.cc = None
Daniel Cheng7227d212017-11-17 08:12:37 -0800952 self.more_cc = []
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +0000953 self._remote = None
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +0000954 self._cached_remote_url = (False, None) # (is_cached, value)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +0000955
Edward Lemur125d60a2019-09-13 18:25:41 +0000956 # Lazily cached values.
957 self._gerrit_host = None # e.g. chromium-review.googlesource.com
958 self._gerrit_server = None # e.g. https://chromium-review.googlesource.com
959 # Map from change number (issue) to its detail cache.
960 self._detail_cache = {}
961
962 if codereview_host is not None:
963 assert not codereview_host.startswith('https://'), codereview_host
964 self._gerrit_host = codereview_host
965 self._gerrit_server = 'https://%s' % codereview_host
bauerb@chromium.orgae6df352011-04-06 17:40:39 +0000966
967 def GetCCList(self):
Quinten Yearsley0c62da92017-05-31 13:39:42 -0700968 """Returns the users cc'd on this CL.
bauerb@chromium.orgae6df352011-04-06 17:40:39 +0000969
Quinten Yearsley0c62da92017-05-31 13:39:42 -0700970 The return value is a string suitable for passing to git cl with the --cc
971 flag.
bauerb@chromium.orgae6df352011-04-06 17:40:39 +0000972 """
973 if self.cc is None:
tyoshino@chromium.org99918ab2013-09-30 06:17:28 +0000974 base_cc = settings.GetDefaultCCList()
Daniel Cheng7227d212017-11-17 08:12:37 -0800975 more_cc = ','.join(self.more_cc)
bauerb@chromium.orgae6df352011-04-06 17:40:39 +0000976 self.cc = ','.join(filter(None, (base_cc, more_cc))) or ''
977 return self.cc
978
Daniel Cheng7227d212017-11-17 08:12:37 -0800979 def ExtendCC(self, more_cc):
980 """Extends the list of users to cc on this CL based on the changed files."""
981 self.more_cc.extend(more_cc)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000982
983 def GetBranch(self):
984 """Returns the short branch name, e.g. 'master'."""
985 if not self.branch:
Edward Lemur85153282020-02-14 22:06:29 +0000986 branchref = scm.GIT.GetBranchRef(settings.GetRoot())
szager@chromium.orgd62c61f2014-10-20 22:33:21 +0000987 if not branchref:
988 return None
989 self.branchref = branchref
Edward Lemur85153282020-02-14 22:06:29 +0000990 self.branch = scm.GIT.ShortBranchName(self.branchref)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000991 return self.branch
992
993 def GetBranchRef(self):
994 """Returns the full branch name, e.g. 'refs/heads/master'."""
995 self.GetBranch() # Poke the lazy loader.
996 return self.branchref
997
Edward Lemur85153282020-02-14 22:06:29 +0000998 def _GitGetBranchConfigValue(self, key, default=None):
999 return scm.GIT.GetBranchConfig(
1000 settings.GetRoot(), self.GetBranch(), key, default)
tandrii5d48c322016-08-18 16:19:37 -07001001
Edward Lemur85153282020-02-14 22:06:29 +00001002 def _GitSetBranchConfigValue(self, key, value):
1003 action = 'set %s to %r' % (key, value)
1004 if not value:
1005 action = 'unset %s' % key
1006 assert self.GetBranch(), 'a branch is needed to ' + action
1007 return scm.GIT.SetBranchConfig(
1008 settings.GetRoot(), self.GetBranch(), key, value)
tandrii5d48c322016-08-18 16:19:37 -07001009
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001010 @staticmethod
1011 def FetchUpstreamTuple(branch):
pgervais@chromium.orgd6617f32013-11-19 00:34:54 +00001012 """Returns a tuple containing remote and remote ref,
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001013 e.g. 'origin', 'refs/heads/master'
1014 """
Edward Lemur15a9b8c2020-02-13 00:52:30 +00001015 remote, upstream_branch = scm.GIT.FetchUpstreamTuple(
1016 settings.GetRoot(), branch)
1017 if not remote or not upstream_branch:
1018 DieWithError(
1019 'Unable to determine default branch to diff against.\n'
1020 'Either pass complete "git diff"-style arguments, like\n'
1021 ' git cl upload origin/master\n'
1022 'or verify this branch is set up to track another \n'
1023 '(via the --track argument to "git checkout -b ...").')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001024
1025 return remote, upstream_branch
1026
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00001027 def GetCommonAncestorWithUpstream(self):
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +00001028 upstream_branch = self.GetUpstreamBranch()
Edward Lesmese3a49aa2020-03-24 23:46:28 +00001029 if not scm.GIT.IsValidRevision(settings.GetRoot(), upstream_branch):
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +00001030 DieWithError('The upstream for the current branch (%s) does not exist '
1031 'anymore.\nPlease fix it and try again.' % self.GetBranch())
iannucci@chromium.org9e849272014-04-04 00:31:55 +00001032 return git_common.get_or_create_merge_base(self.GetBranch(),
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +00001033 upstream_branch)
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00001034
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001035 def GetUpstreamBranch(self):
1036 if self.upstream_branch is None:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001037 remote, upstream_branch = self.FetchUpstreamTuple(self.GetBranch())
Raul Tambrefe1dbe12019-05-02 04:43:57 +00001038 if remote != '.':
mmoss@chromium.orge7585452014-08-24 01:41:11 +00001039 upstream_branch = upstream_branch.replace('refs/heads/',
1040 'refs/remotes/%s/' % remote)
1041 upstream_branch = upstream_branch.replace('refs/branch-heads/',
1042 'refs/remotes/branch-heads/')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001043 self.upstream_branch = upstream_branch
1044 return self.upstream_branch
1045
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001046 def GetRemoteBranch(self):
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001047 if not self._remote:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001048 remote, branch = None, self.GetBranch()
1049 seen_branches = set()
1050 while branch not in seen_branches:
1051 seen_branches.add(branch)
1052 remote, branch = self.FetchUpstreamTuple(branch)
Edward Lemur85153282020-02-14 22:06:29 +00001053 branch = scm.GIT.ShortBranchName(branch)
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001054 if remote != '.' or branch.startswith('refs/remotes'):
1055 break
1056 else:
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001057 remotes = RunGit(['remote'], error_ok=True).split()
1058 if len(remotes) == 1:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001059 remote, = remotes
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001060 elif 'origin' in remotes:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001061 remote = 'origin'
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08001062 logging.warn('Could not determine which remote this change is '
1063 'associated with, so defaulting to "%s".' % self._remote)
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001064 else:
1065 logging.warn('Could not determine which remote this change is '
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08001066 'associated with.')
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001067 branch = 'HEAD'
1068 if branch.startswith('refs/remotes'):
1069 self._remote = (remote, branch)
mmoss@chromium.orge7585452014-08-24 01:41:11 +00001070 elif branch.startswith('refs/branch-heads/'):
1071 self._remote = (remote, branch.replace('refs/', 'refs/remotes/'))
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001072 else:
1073 self._remote = (remote, 'refs/remotes/%s/%s' % (remote, branch))
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001074 return self._remote
1075
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001076 def GetRemoteUrl(self):
1077 """Return the configured remote URL, e.g. 'git://example.org/foo.git/'.
1078
1079 Returns None if there is no remote.
1080 """
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001081 is_cached, value = self._cached_remote_url
1082 if is_cached:
1083 return value
1084
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001085 remote, _ = self.GetRemoteBranch()
Edward Lemur26964072020-02-19 19:18:51 +00001086 url = scm.GIT.GetConfig(settings.GetRoot(), 'remote.%s.url' % remote, '')
dyen@chromium.org2a13d4f2014-06-13 00:06:37 +00001087
Edward Lemur298f2cf2019-02-22 21:40:39 +00001088 # Check if the remote url can be parsed as an URL.
Edward Lemur79d4f992019-11-11 23:49:02 +00001089 host = urllib.parse.urlparse(url).netloc
Edward Lemur298f2cf2019-02-22 21:40:39 +00001090 if host:
1091 self._cached_remote_url = (True, url)
1092 return url
1093
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001094 # If it cannot be parsed as an url, assume it is a local directory,
1095 # probably a git cache.
Edward Lemur298f2cf2019-02-22 21:40:39 +00001096 logging.warning('"%s" doesn\'t appear to point to a git host. '
1097 'Interpreting it as a local directory.', url)
1098 if not os.path.isdir(url):
1099 logging.error(
Josip906bfde2020-01-31 22:38:49 +00001100 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
1101 'but it doesn\'t exist.',
1102 {'remote': remote, 'branch': self.GetBranch(), 'url': url})
Edward Lemur298f2cf2019-02-22 21:40:39 +00001103 return None
1104
1105 cache_path = url
Edward Lemur26964072020-02-19 19:18:51 +00001106 url = scm.GIT.GetConfig(url, 'remote.%s.url' % remote, '')
Edward Lemur298f2cf2019-02-22 21:40:39 +00001107
Edward Lemur79d4f992019-11-11 23:49:02 +00001108 host = urllib.parse.urlparse(url).netloc
Edward Lemur298f2cf2019-02-22 21:40:39 +00001109 if not host:
1110 logging.error(
1111 'Remote "%(remote)s" for branch "%(branch)s" points to '
1112 '"%(cache_path)s", but it is misconfigured.\n'
1113 '"%(cache_path)s" must be a git repo and must have a remote named '
1114 '"%(remote)s" pointing to the git host.', {
1115 'remote': remote,
1116 'cache_path': cache_path,
1117 'branch': self.GetBranch()})
1118 return None
1119
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001120 self._cached_remote_url = (True, url)
dyen@chromium.org2a13d4f2014-06-13 00:06:37 +00001121 return url
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001122
tandrii@chromium.org87985d22016-03-24 17:33:33 +00001123 def GetIssue(self):
maruel@chromium.org52424302012-08-29 15:14:30 +00001124 """Returns the issue number as a int or None if not set."""
tandrii@chromium.org87985d22016-03-24 17:33:33 +00001125 if self.issue is None and not self.lookedup_issue:
Edward Lesmese3a49aa2020-03-24 23:46:28 +00001126 self.issue = self._GitGetBranchConfigValue(ISSUE_CONFIG_KEY)
Edward Lemur85153282020-02-14 22:06:29 +00001127 if self.issue is not None:
1128 self.issue = int(self.issue)
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001129 self.lookedup_issue = True
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001130 return self.issue
1131
Andrii Shyshkalov1ee78cd2020-03-12 01:31:53 +00001132 def GetIssueURL(self, short=False):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001133 """Get the URL for a particular issue."""
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001134 issue = self.GetIssue()
1135 if not issue:
dbeam@chromium.org015fd3d2013-06-18 19:02:50 +00001136 return None
Andrii Shyshkalov1ee78cd2020-03-12 01:31:53 +00001137 server = self.GetCodereviewServer()
1138 if short:
1139 server = _KNOWN_GERRIT_TO_SHORT_URLS.get(server, server)
1140 return '%s/%s' % (server, issue)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001141
Edward Lemur6c6827c2020-02-06 21:15:18 +00001142 def FetchDescription(self, pretty=False):
1143 assert self.GetIssue(), 'issue is required to query Gerrit'
1144
Edward Lemur9aa1a962020-02-25 00:58:38 +00001145 if self.description is None:
Edward Lemur6c6827c2020-02-06 21:15:18 +00001146 data = self._GetChangeDetail(['CURRENT_REVISION', 'CURRENT_COMMIT'])
1147 current_rev = data['current_revision']
1148 self.description = data['revisions'][current_rev]['commit']['message']
Edward Lemur6c6827c2020-02-06 21:15:18 +00001149
1150 if not pretty:
1151 return self.description
1152
1153 # Set width to 72 columns + 2 space indent.
1154 wrapper = textwrap.TextWrapper(width=74, replace_whitespace=True)
1155 wrapper.initial_indent = wrapper.subsequent_indent = ' '
1156 lines = self.description.splitlines()
1157 return '\n'.join([wrapper.fill(line) for line in lines])
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001158
1159 def GetPatchset(self):
maruel@chromium.org52424302012-08-29 15:14:30 +00001160 """Returns the patchset number as a int or None if not set."""
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001161 if self.patchset is None and not self.lookedup_patchset:
Edward Lesmese3a49aa2020-03-24 23:46:28 +00001162 self.patchset = self._GitGetBranchConfigValue(PATCHSET_CONFIG_KEY)
Edward Lemur85153282020-02-14 22:06:29 +00001163 if self.patchset is not None:
1164 self.patchset = int(self.patchset)
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001165 self.lookedup_patchset = True
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001166 return self.patchset
1167
Edward Lemur9aa1a962020-02-25 00:58:38 +00001168 def GetAuthor(self):
1169 return scm.GIT.GetConfig(settings.GetRoot(), 'user.email')
1170
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001171 def SetPatchset(self, patchset):
tandrii5d48c322016-08-18 16:19:37 -07001172 """Set this branch's patchset. If patchset=0, clears the patchset."""
1173 assert self.GetBranch()
1174 if not patchset:
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001175 self.patchset = None
tandrii5d48c322016-08-18 16:19:37 -07001176 else:
1177 self.patchset = int(patchset)
Edward Lesmese3a49aa2020-03-24 23:46:28 +00001178 self._GitSetBranchConfigValue(PATCHSET_CONFIG_KEY, str(self.patchset))
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001179
tandrii@chromium.orga342c922016-03-16 07:08:25 +00001180 def SetIssue(self, issue=None):
tandrii5d48c322016-08-18 16:19:37 -07001181 """Set this branch's issue. If issue isn't given, clears the issue."""
1182 assert self.GetBranch()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001183 if issue:
tandrii5d48c322016-08-18 16:19:37 -07001184 issue = int(issue)
Edward Lesmese3a49aa2020-03-24 23:46:28 +00001185 self._GitSetBranchConfigValue(ISSUE_CONFIG_KEY, str(issue))
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001186 self.issue = issue
Edward Lemur125d60a2019-09-13 18:25:41 +00001187 codereview_server = self.GetCodereviewServer()
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001188 if codereview_server:
tandrii5d48c322016-08-18 16:19:37 -07001189 self._GitSetBranchConfigValue(
Edward Lesmese3a49aa2020-03-24 23:46:28 +00001190 CODEREVIEW_SERVER_CONFIG_KEY, codereview_server)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001191 else:
tandrii5d48c322016-08-18 16:19:37 -07001192 # Reset all of these just to be clean.
1193 reset_suffixes = [
1194 'last-upload-hash',
Edward Lesmese3a49aa2020-03-24 23:46:28 +00001195 ISSUE_CONFIG_KEY,
1196 PATCHSET_CONFIG_KEY,
1197 CODEREVIEW_SERVER_CONFIG_KEY,
1198 'gerritsquashhash',
1199 ]
tandrii5d48c322016-08-18 16:19:37 -07001200 for prop in reset_suffixes:
Edward Lemur85153282020-02-14 22:06:29 +00001201 try:
1202 self._GitSetBranchConfigValue(prop, None)
1203 except subprocess2.CalledProcessError:
1204 pass
Aaron Gableca01e2c2017-07-19 11:16:02 -07001205 msg = RunGit(['log', '-1', '--format=%B']).strip()
1206 if msg and git_footers.get_footer_change_id(msg):
1207 print('WARNING: The change patched into this branch has a Change-Id. '
1208 'Removing it.')
1209 RunGit(['commit', '--amend', '-m',
1210 git_footers.remove_footer(msg, 'Change-Id')])
Edward Lemurf38bc172019-09-03 21:02:13 +00001211 self.lookedup_issue = True
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001212 self.issue = None
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00001213 self.patchset = None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001214
Edward Lemur2c62b332020-03-12 22:12:33 +00001215 def GetAffectedFiles(self, upstream):
maruel@chromium.org2b38e9c2011-10-19 00:04:35 +00001216 try:
Edward Lemur2c62b332020-03-12 22:12:33 +00001217 return [f for _, f in scm.GIT.CaptureStatus(settings.GetRoot(), upstream)]
maruel@chromium.org2b38e9c2011-10-19 00:04:35 +00001218 except subprocess2.CalledProcessError:
1219 DieWithError(
pgervais@chromium.orgd6617f32013-11-19 00:34:54 +00001220 ('\nFailed to diff against upstream branch %s\n\n'
maruel@chromium.org2b38e9c2011-10-19 00:04:35 +00001221 'This branch probably doesn\'t exist anymore. To reset the\n'
1222 'tracking branch, please run\n'
stip7a3dd352016-09-22 17:32:28 -07001223 ' git branch --set-upstream-to origin/master %s\n'
1224 'or replace origin/master with the relevant branch') %
Edward Lemur2c62b332020-03-12 22:12:33 +00001225 (upstream, self.GetBranch()))
bauerb@chromium.org6fb99c62011-04-18 15:57:28 +00001226
dsansomee2d6fd92016-09-08 00:10:47 -07001227 def UpdateDescription(self, description, force=False):
Edward Lemur6c6827c2020-02-06 21:15:18 +00001228 assert self.GetIssue(), 'issue is required to update description'
1229
1230 if gerrit_util.HasPendingChangeEdit(
1231 self._GetGerritHost(), self._GerritChangeIdentifier()):
1232 if not force:
1233 confirm_or_exit(
1234 'The description cannot be modified while the issue has a pending '
1235 'unpublished edit. Either publish the edit in the Gerrit web UI '
1236 'or delete it.\n\n', action='delete the unpublished edit')
1237
1238 gerrit_util.DeletePendingChangeEdit(
1239 self._GetGerritHost(), self._GerritChangeIdentifier())
1240 gerrit_util.SetCommitMessage(
1241 self._GetGerritHost(), self._GerritChangeIdentifier(),
1242 description, notify='NONE')
1243
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001244 self.description = description
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001245
Edward Lemur75526302020-02-27 22:31:05 +00001246 def _GetCommonPresubmitArgs(self, verbose, upstream):
Edward Lemur227d5102020-02-25 23:45:35 +00001247 args = [
Edward Lemur227d5102020-02-25 23:45:35 +00001248 '--root', settings.GetRoot(),
1249 '--upstream', upstream,
1250 ]
1251
1252 args.extend(['--verbose'] * verbose)
1253
Edward Lemur99df04e2020-03-05 19:39:43 +00001254 author = self.GetAuthor()
1255 gerrit_url = self.GetCodereviewServer()
Edward Lemur227d5102020-02-25 23:45:35 +00001256 issue = self.GetIssue()
1257 patchset = self.GetPatchset()
Edward Lemur99df04e2020-03-05 19:39:43 +00001258 if author:
1259 args.extend(['--author', author])
1260 if gerrit_url:
1261 args.extend(['--gerrit_url', gerrit_url])
Edward Lemur227d5102020-02-25 23:45:35 +00001262 if issue:
1263 args.extend(['--issue', str(issue)])
1264 if patchset:
1265 args.extend(['--patchset', str(patchset)])
Edward Lemur227d5102020-02-25 23:45:35 +00001266
Edward Lemur75526302020-02-27 22:31:05 +00001267 return args
1268
1269 def RunHook(
1270 self, committing, may_prompt, verbose, parallel, upstream, description,
1271 all_files):
1272 """Calls sys.exit() if the hook fails; returns a HookResults otherwise."""
1273 args = self._GetCommonPresubmitArgs(verbose, upstream)
1274 args.append('--commit' if committing else '--upload')
Edward Lemur227d5102020-02-25 23:45:35 +00001275 if may_prompt:
1276 args.append('--may_prompt')
1277 if parallel:
1278 args.append('--parallel')
1279 if all_files:
1280 args.append('--all_files')
1281
1282 with gclient_utils.temporary_file() as description_file:
1283 with gclient_utils.temporary_file() as json_output:
Edward Lemur1a83da12020-03-04 21:18:36 +00001284
1285 gclient_utils.FileWrite(description_file, description)
Edward Lemur227d5102020-02-25 23:45:35 +00001286 args.extend(['--json_output', json_output])
1287 args.extend(['--description_file', description_file])
1288
1289 start = time_time()
1290 p = subprocess2.Popen(['vpython', PRESUBMIT_SUPPORT] + args)
1291 exit_code = p.wait()
1292 metrics.collector.add_repeated('sub_commands', {
1293 'command': 'presubmit',
1294 'execution_time': time_time() - start,
1295 'exit_code': exit_code,
1296 })
1297
1298 if exit_code:
1299 sys.exit(exit_code)
1300
1301 json_results = gclient_utils.FileRead(json_output)
1302 return json.loads(json_results)
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001303
Edward Lemur75526302020-02-27 22:31:05 +00001304 def RunPostUploadHook(self, verbose, upstream, description):
1305 args = self._GetCommonPresubmitArgs(verbose, upstream)
1306 args.append('--post_upload')
1307
1308 with gclient_utils.temporary_file() as description_file:
Edward Lemur1a83da12020-03-04 21:18:36 +00001309 gclient_utils.FileWrite(description_file, description)
Edward Lemur75526302020-02-27 22:31:05 +00001310 args.extend(['--description_file', description_file])
1311 p = subprocess2.Popen(['vpython', PRESUBMIT_SUPPORT] + args)
1312 p.wait()
1313
Edward Lemur5a644f82020-03-18 16:44:57 +00001314 def _GetDescriptionForUpload(self, options, git_diff_args, files):
1315 # Get description message for upload.
1316 if self.GetIssue():
1317 description = self.FetchDescription()
1318 elif options.message:
1319 description = options.message
1320 else:
1321 description = _create_description_from_log(git_diff_args)
1322 if options.title and options.squash:
1323 description = options.title + '\n\n' + message
1324
1325 # Extract bug number from branch name.
1326 bug = options.bug
1327 fixed = options.fixed
1328 match = re.match(r'(?P<type>bug|fix(?:e[sd])?)[_-]?(?P<bugnum>\d+)',
1329 self.GetBranch())
1330 if not bug and not fixed and match:
1331 if match.group('type') == 'bug':
1332 bug = match.group('bugnum')
1333 else:
1334 fixed = match.group('bugnum')
1335
1336 change_description = ChangeDescription(description, bug, fixed)
1337
1338 # Set the reviewer list now so that presubmit checks can access it.
1339 if options.reviewers or options.tbrs or options.add_owners_to:
1340 change_description.update_reviewers(
1341 options.reviewers, options.tbrs, options.add_owners_to, files,
1342 self.GetAuthor())
1343
1344 return change_description
1345
1346 def _GetTitleForUpload(self, options):
1347 # When not squashing, just return options.title.
1348 if not options.squash:
1349 return options.title
1350
1351 # On first upload, patchset title is always this string, while options.title
1352 # gets converted to first line of message.
1353 if not self.GetIssue():
1354 return 'Initial upload'
1355
1356 # When uploading subsequent patchsets, options.message is taken as the title
1357 # if options.title is not provided.
1358 if options.title:
1359 return options.title
1360 if options.message:
1361 return options.message.strip()
1362
1363 # Use the subject of the last commit as title by default.
Edward Lesmese3a49aa2020-03-24 23:46:28 +00001364 title = RunGit(['show', '-s', '--format=%s', 'HEAD']).strip()
Edward Lemur5a644f82020-03-18 16:44:57 +00001365 if options.force:
1366 return title
Edward Lesmesae3586b2020-03-23 21:21:14 +00001367 user_title = gclient_utils.AskForData('Title for patchset [%s]: ' % title)
1368 return user_title or title
Edward Lemur5a644f82020-03-18 16:44:57 +00001369
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001370 def CMDUpload(self, options, git_diff_args, orig_args):
1371 """Uploads a change to codereview."""
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001372 custom_cl_base = None
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001373 if git_diff_args:
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001374 custom_cl_base = base_branch = git_diff_args[0]
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001375 else:
1376 if self.GetBranch() is None:
1377 DieWithError('Can\'t upload from detached HEAD state. Get on a branch!')
1378
1379 # Default to diffing against common ancestor of upstream branch
1380 base_branch = self.GetCommonAncestorWithUpstream()
1381 git_diff_args = [base_branch, 'HEAD']
1382
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001383 # Fast best-effort checks to abort before running potentially expensive
1384 # hooks if uploading is likely to fail anyway. Passing these checks does
1385 # not guarantee that uploading will not fail.
Edward Lemur125d60a2019-09-13 18:25:41 +00001386 self.EnsureAuthenticated(force=options.force)
1387 self.EnsureCanUploadPatchset(force=options.force)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001388
1389 # Apply watchlists on upload.
Edward Lemur2c62b332020-03-12 22:12:33 +00001390 watchlist = watchlists.Watchlists(settings.GetRoot())
1391 files = self.GetAffectedFiles(base_branch)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001392 if not options.bypass_watchlists:
Daniel Cheng7227d212017-11-17 08:12:37 -08001393 self.ExtendCC(watchlist.GetWatchersForPaths(files))
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001394
Edward Lemur5a644f82020-03-18 16:44:57 +00001395 change_desc = self._GetDescriptionForUpload(options, git_diff_args, files)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001396 if not options.bypass_hooks:
Edward Lemur2c62b332020-03-12 22:12:33 +00001397 hook_results = self.RunHook(
1398 committing=False,
1399 may_prompt=not options.force,
1400 verbose=options.verbose,
1401 parallel=options.parallel,
1402 upstream=base_branch,
Edward Lemur5a644f82020-03-18 16:44:57 +00001403 description=change_desc.description,
Edward Lemur2c62b332020-03-12 22:12:33 +00001404 all_files=False)
Edward Lemur227d5102020-02-25 23:45:35 +00001405 self.ExtendCC(hook_results['more_cc'])
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001406
Aaron Gable13101a62018-02-09 13:20:41 -08001407 print_stats(git_diff_args)
Edward Lemura12175c2020-03-09 16:58:26 +00001408 ret = self.CMDUploadChange(
Edward Lemur5a644f82020-03-18 16:44:57 +00001409 options, git_diff_args, custom_cl_base, change_desc)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001410 if not ret:
Edward Lemur85153282020-02-14 22:06:29 +00001411 self._GitSetBranchConfigValue(
Edward Lesmese3a49aa2020-03-24 23:46:28 +00001412 'last-upload-hash', scm.GIT.ResolveCommit(settings.GetRoot(), 'HEAD'))
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001413 # Run post upload hooks, if specified.
1414 if settings.GetRunPostUploadHook():
Edward Lemur5a644f82020-03-18 16:44:57 +00001415 self.RunPostUploadHook(
1416 options.verbose, base_branch, change_desc.description)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001417
1418 # Upload all dependencies if specified.
1419 if options.dependencies:
vapiera7fbd5a2016-06-16 09:17:49 -07001420 print()
1421 print('--dependencies has been specified.')
1422 print('All dependent local branches will be re-uploaded.')
1423 print()
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001424 # Remove the dependencies flag from args so that we do not end up in a
1425 # loop.
1426 orig_args.remove('--dependencies')
1427 ret = upload_branch_deps(self, orig_args)
1428 return ret
1429
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001430 def SetCQState(self, new_state):
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07001431 """Updates the CQ state for the latest patchset.
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001432
1433 Issue must have been already uploaded and known.
1434 """
1435 assert new_state in _CQState.ALL_STATES
1436 assert self.GetIssue()
qyearsley1fdfcb62016-10-24 13:22:03 -07001437 try:
Edward Lemur125d60a2019-09-13 18:25:41 +00001438 vote_map = {
1439 _CQState.NONE: 0,
1440 _CQState.DRY_RUN: 1,
1441 _CQState.COMMIT: 2,
1442 }
1443 labels = {'Commit-Queue': vote_map[new_state]}
1444 notify = False if new_state == _CQState.DRY_RUN else None
1445 gerrit_util.SetReview(
1446 self._GetGerritHost(), self._GerritChangeIdentifier(),
1447 labels=labels, notify=notify)
qyearsley1fdfcb62016-10-24 13:22:03 -07001448 return 0
1449 except KeyboardInterrupt:
1450 raise
1451 except:
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07001452 print('WARNING: Failed to %s.\n'
qyearsley1fdfcb62016-10-24 13:22:03 -07001453 'Either:\n'
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07001454 ' * Your project has no CQ,\n'
1455 ' * You don\'t have permission to change the CQ state,\n'
1456 ' * There\'s a bug in this code (see stack trace below).\n'
1457 'Consider specifying which bots to trigger manually or asking your '
1458 'project owners for permissions or contacting Chrome Infra at:\n'
1459 'https://www.chromium.org/infra\n\n' %
1460 ('cancel CQ' if new_state == _CQState.NONE else 'trigger CQ'))
qyearsley1fdfcb62016-10-24 13:22:03 -07001461 # Still raise exception so that stack trace is printed.
1462 raise
1463
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001464 def _GetGerritHost(self):
1465 # Lazy load of configs.
1466 self.GetCodereviewServer()
tandriie32e3ea2016-06-22 02:52:48 -07001467 if self._gerrit_host and '.' not in self._gerrit_host:
1468 # Abbreviated domain like "chromium" instead of chromium.googlesource.com.
1469 # This happens for internal stuff http://crbug.com/614312.
Edward Lemur79d4f992019-11-11 23:49:02 +00001470 parsed = urllib.parse.urlparse(self.GetRemoteUrl())
tandriie32e3ea2016-06-22 02:52:48 -07001471 if parsed.scheme == 'sso':
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001472 print('WARNING: using non-https URLs for remote is likely broken\n'
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001473 ' Your current remote is: %s' % self.GetRemoteUrl())
tandriie32e3ea2016-06-22 02:52:48 -07001474 self._gerrit_host = '%s.googlesource.com' % self._gerrit_host
1475 self._gerrit_server = 'https://%s' % self._gerrit_host
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001476 return self._gerrit_host
1477
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001478 def _GetGitHost(self):
1479 """Returns git host to be used when uploading change to Gerrit."""
Edward Lemur298f2cf2019-02-22 21:40:39 +00001480 remote_url = self.GetRemoteUrl()
1481 if not remote_url:
1482 return None
Edward Lemur79d4f992019-11-11 23:49:02 +00001483 return urllib.parse.urlparse(remote_url).netloc
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001484
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001485 def GetCodereviewServer(self):
1486 if not self._gerrit_server:
1487 # If we're on a branch then get the server potentially associated
1488 # with that branch.
Edward Lemur85153282020-02-14 22:06:29 +00001489 if self.GetIssue() and self.GetBranch():
tandrii5d48c322016-08-18 16:19:37 -07001490 self._gerrit_server = self._GitGetBranchConfigValue(
Edward Lesmese3a49aa2020-03-24 23:46:28 +00001491 CODEREVIEW_SERVER_CONFIG_KEY)
tandrii5d48c322016-08-18 16:19:37 -07001492 if self._gerrit_server:
Edward Lemur79d4f992019-11-11 23:49:02 +00001493 self._gerrit_host = urllib.parse.urlparse(self._gerrit_server).netloc
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001494 if not self._gerrit_server:
1495 # We assume repo to be hosted on Gerrit, and hence Gerrit server
1496 # has "-review" suffix for lowest level subdomain.
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001497 parts = self._GetGitHost().split('.')
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001498 parts[0] = parts[0] + '-review'
1499 self._gerrit_host = '.'.join(parts)
1500 self._gerrit_server = 'https://%s' % self._gerrit_host
1501 return self._gerrit_server
1502
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00001503 def _GetGerritProject(self):
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001504 """Returns Gerrit project name based on remote git URL."""
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00001505 remote_url = self.GetRemoteUrl()
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001506 if remote_url is None:
Josip906bfde2020-01-31 22:38:49 +00001507 logging.warning('can\'t detect Gerrit project.')
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00001508 return None
Edward Lemur79d4f992019-11-11 23:49:02 +00001509 project = urllib.parse.urlparse(remote_url).path.strip('/')
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001510 if project.endswith('.git'):
1511 project = project[:-len('.git')]
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00001512 # *.googlesource.com hosts ensure that Git/Gerrit projects don't start with
1513 # 'a/' prefix, because 'a/' prefix is used to force authentication in
1514 # gitiles/git-over-https protocol. E.g.,
1515 # https://chromium.googlesource.com/a/v8/v8 refers to the same repo/project
1516 # as
1517 # https://chromium.googlesource.com/v8/v8
1518 if project.startswith('a/'):
1519 project = project[len('a/'):]
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001520 return project
1521
Andrii Shyshkalovd06cc782018-08-23 17:24:19 +00001522 def _GerritChangeIdentifier(self):
1523 """Handy method for gerrit_util.ChangeIdentifier for a given CL.
1524
1525 Not to be confused by value of "Change-Id:" footer.
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00001526 If Gerrit project can be determined, this will speed up Gerrit HTTP API RPC.
Andrii Shyshkalovd06cc782018-08-23 17:24:19 +00001527 """
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00001528 project = self._GetGerritProject()
1529 if project:
1530 return gerrit_util.ChangeIdentifier(project, self.GetIssue())
1531 # Fall back on still unique, but less efficient change number.
1532 return str(self.GetIssue())
Andrii Shyshkalovd06cc782018-08-23 17:24:19 +00001533
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01001534 def EnsureAuthenticated(self, force, refresh=None):
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001535 """Best effort check that user is authenticated with Gerrit server."""
tandrii@chromium.org28253532016-04-14 13:46:56 +00001536 if settings.GetGerritSkipEnsureAuthenticated():
1537 # For projects with unusual authentication schemes.
1538 # See http://crbug.com/603378.
1539 return
Vadim Shtayurab250ec12018-10-04 00:21:08 +00001540
1541 # Check presence of cookies only if using cookies-based auth method.
1542 cookie_auth = gerrit_util.Authenticator.get()
1543 if not isinstance(cookie_auth, gerrit_util.CookiesAuthenticator):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001544 return
Vadim Shtayurab250ec12018-10-04 00:21:08 +00001545
Florian Mayerae510e82020-01-30 21:04:48 +00001546 remote_url = self.GetRemoteUrl()
1547 if remote_url is None:
Josip906bfde2020-01-31 22:38:49 +00001548 logging.warning('invalid remote')
Florian Mayerae510e82020-01-30 21:04:48 +00001549 return
1550 if urllib.parse.urlparse(remote_url).scheme != 'https':
Josip906bfde2020-01-31 22:38:49 +00001551 logging.warning('Ignoring branch %(branch)s with non-https remote '
1552 '%(remote)s', {
1553 'branch': self.branch,
1554 'remote': self.GetRemoteUrl()
1555 })
Daniel Chengcf6269b2019-05-18 01:02:12 +00001556 return
1557
Vadim Shtayurab250ec12018-10-04 00:21:08 +00001558 # Lazy-loader to identify Gerrit and Git hosts.
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001559 self.GetCodereviewServer()
1560 git_host = self._GetGitHost()
Edward Lemur298f2cf2019-02-22 21:40:39 +00001561 assert self._gerrit_server and self._gerrit_host and git_host
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001562
1563 gerrit_auth = cookie_auth.get_auth_header(self._gerrit_host)
1564 git_auth = cookie_auth.get_auth_header(git_host)
1565 if gerrit_auth and git_auth:
1566 if gerrit_auth == git_auth:
1567 return
Andrii Shyshkalov354e1d22017-06-09 19:31:33 +02001568 all_gsrc = cookie_auth.get_auth_header('d0esN0tEx1st.googlesource.com')
Raul Tambre80ee78e2019-05-06 22:41:05 +00001569 print(
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001570 'WARNING: You have different credentials for Gerrit and git hosts:\n'
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001571 ' %s\n'
1572 ' %s\n'
Andrii Shyshkalov51acef92017-04-11 17:19:59 +02001573 ' Consider running the following command:\n'
1574 ' git cl creds-check\n'
Andrii Shyshkalov354e1d22017-06-09 19:31:33 +02001575 ' %s\n'
Raul Tambre80ee78e2019-05-06 22:41:05 +00001576 ' %s' %
Andrii Shyshkalov51acef92017-04-11 17:19:59 +02001577 (git_host, self._gerrit_host,
Andrii Shyshkalov354e1d22017-06-09 19:31:33 +02001578 ('Hint: delete creds for .googlesource.com' if all_gsrc else ''),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001579 cookie_auth.get_new_password_message(git_host)))
1580 if not force:
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001581 confirm_or_exit('If you know what you are doing', action='continue')
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001582 return
1583 else:
1584 missing = (
Anna Henningsen4e891442017-07-06 21:40:58 +02001585 ([] if gerrit_auth else [self._gerrit_host]) +
1586 ([] if git_auth else [git_host]))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001587 DieWithError('Credentials for the following hosts are required:\n'
1588 ' %s\n'
1589 'These are read from %s (or legacy %s)\n'
1590 '%s' % (
1591 '\n '.join(missing),
1592 cookie_auth.get_gitcookies_path(),
1593 cookie_auth.get_netrc_path(),
1594 cookie_auth.get_new_password_message(git_host)))
1595
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001596 def EnsureCanUploadPatchset(self, force):
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01001597 if not self.GetIssue():
1598 return
1599
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01001600 status = self._GetChangeDetail()['status']
1601 if status in ('MERGED', 'ABANDONED'):
1602 DieWithError('Change %s has been %s, new uploads are not allowed' %
1603 (self.GetIssueURL(),
1604 'submitted' if status == 'MERGED' else 'abandoned'))
1605
Vadim Shtayurab250ec12018-10-04 00:21:08 +00001606 # TODO(vadimsh): For some reason the chunk of code below was skipped if
1607 # 'is_gce' is True. I'm just refactoring it to be 'skip if not cookies'.
1608 # Apparently this check is not very important? Otherwise get_auth_email
1609 # could have been added to other implementations of Authenticator.
1610 cookies_auth = gerrit_util.Authenticator.get()
1611 if not isinstance(cookies_auth, gerrit_util.CookiesAuthenticator):
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001612 return
Vadim Shtayurab250ec12018-10-04 00:21:08 +00001613
1614 cookies_user = cookies_auth.get_auth_email(self._GetGerritHost())
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001615 if self.GetIssueOwner() == cookies_user:
1616 return
1617 logging.debug('change %s owner is %s, cookies user is %s',
1618 self.GetIssue(), self.GetIssueOwner(), cookies_user)
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001619 # Maybe user has linked accounts or something like that,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001620 # so ask what Gerrit thinks of this user.
1621 details = gerrit_util.GetAccountDetails(self._GetGerritHost(), 'self')
1622 if details['email'] == self.GetIssueOwner():
1623 return
1624 if not force:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001625 print('WARNING: Change %s is owned by %s, but you authenticate to Gerrit '
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001626 'as %s.\n'
1627 'Uploading may fail due to lack of permissions.' %
1628 (self.GetIssue(), self.GetIssueOwner(), details['email']))
1629 confirm_or_exit(action='upload')
1630
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001631 def GetStatus(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001632 """Applies a rough heuristic to give a simple summary of an issue's review
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001633 or CQ status, assuming adherence to a common workflow.
1634
1635 Returns None if no issue for this branch, or one of the following keywords:
Aaron Gable9ab38c62017-04-06 14:36:33 -07001636 * 'error' - error from review tool (including deleted issues)
1637 * 'unsent' - no reviewers added
1638 * 'waiting' - waiting for review
1639 * 'reply' - waiting for uploader to reply to review
1640 * 'lgtm' - Code-Review label has been set
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00001641 * 'dry-run' - dry-running in the CQ
1642 * 'commit' - in the CQ
Aaron Gable9ab38c62017-04-06 14:36:33 -07001643 * 'closed' - successfully submitted or abandoned
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001644 """
1645 if not self.GetIssue():
1646 return None
1647
1648 try:
Aaron Gable9ab38c62017-04-06 14:36:33 -07001649 data = self._GetChangeDetail([
1650 'DETAILED_LABELS', 'CURRENT_REVISION', 'SUBMITTABLE'])
Edward Lemur79d4f992019-11-11 23:49:02 +00001651 except GerritChangeNotExists:
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001652 return 'error'
1653
tandrii@chromium.org5e1bf382016-05-17 08:43:24 +00001654 if data['status'] in ('ABANDONED', 'MERGED'):
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001655 return 'closed'
1656
Andrii Shyshkalovb8268ca2019-04-03 23:33:44 +00001657 cq_label = data['labels'].get('Commit-Queue', {})
1658 max_cq_vote = 0
1659 for vote in cq_label.get('all', []):
1660 max_cq_vote = max(max_cq_vote, vote.get('value', 0))
1661 if max_cq_vote == 2:
Aaron Gable9ab38c62017-04-06 14:36:33 -07001662 return 'commit'
Andrii Shyshkalovb8268ca2019-04-03 23:33:44 +00001663 if max_cq_vote == 1:
1664 return 'dry-run'
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001665
Aaron Gable9ab38c62017-04-06 14:36:33 -07001666 if data['labels'].get('Code-Review', {}).get('approved'):
1667 return 'lgtm'
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001668
1669 if not data.get('reviewers', {}).get('REVIEWER', []):
1670 return 'unsent'
1671
Andrii Shyshkalov33e88a42017-01-27 14:45:30 +01001672 owner = data['owner'].get('_account_id')
Edward Lemur79d4f992019-11-11 23:49:02 +00001673 messages = sorted(data.get('messages', []), key=lambda m: m.get('date'))
Andrii Shyshkalov8aa9d622020-03-10 19:15:35 +00001674 while messages:
1675 m = messages.pop()
1676 if m.get('tag', '').startswith('autogenerated:cq:'):
Andrii Shyshkalov33e88a42017-01-27 14:45:30 +01001677 # Ignore replies from CQ.
1678 continue
Andrii Shyshkalov8aa9d622020-03-10 19:15:35 +00001679 if m.get('author', {}).get('_account_id') == owner:
Aaron Gable9ab38c62017-04-06 14:36:33 -07001680 # Most recent message was by owner.
1681 return 'waiting'
1682 else:
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001683 # Some reply from non-owner.
1684 return 'reply'
Aaron Gable9ab38c62017-04-06 14:36:33 -07001685
1686 # Somehow there are no messages even though there are reviewers.
1687 return 'unsent'
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001688
1689 def GetMostRecentPatchset(self):
Edward Lemur6c6827c2020-02-06 21:15:18 +00001690 if not self.GetIssue():
1691 return None
1692
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001693 data = self._GetChangeDetail(['CURRENT_REVISION'])
Aaron Gablee8856ee2017-12-07 12:41:46 -08001694 patchset = data['revisions'][data['current_revision']]['_number']
1695 self.SetPatchset(patchset)
1696 return patchset
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001697
Aaron Gable636b13f2017-07-14 10:42:48 -07001698 def AddComment(self, message, publish=None):
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00001699 gerrit_util.SetReview(
1700 self._GetGerritHost(), self._GerritChangeIdentifier(),
1701 msg=message, ready=publish)
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01001702
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001703 def GetCommentsSummary(self, readable=True):
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01001704 # DETAILED_ACCOUNTS is to get emails in accounts.
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001705 # CURRENT_REVISION is included to get the latest patchset so that
1706 # only the robot comments from the latest patchset can be shown.
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001707 messages = self._GetChangeDetail(
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001708 options=['MESSAGES', 'DETAILED_ACCOUNTS',
1709 'CURRENT_REVISION']).get('messages', [])
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001710 file_comments = gerrit_util.GetChangeComments(
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00001711 self._GetGerritHost(), self._GerritChangeIdentifier())
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001712 robot_file_comments = gerrit_util.GetChangeRobotComments(
1713 self._GetGerritHost(), self._GerritChangeIdentifier())
1714
1715 # Add the robot comments onto the list of comments, but only
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00001716 # keep those that are from the latest patchset.
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001717 latest_patch_set = self.GetMostRecentPatchset()
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001718 for path, robot_comments in robot_file_comments.items():
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001719 line_comments = file_comments.setdefault(path, [])
1720 line_comments.extend(
1721 [c for c in robot_comments if c['patch_set'] == latest_patch_set])
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001722
1723 # Build dictionary of file comments for easy access and sorting later.
1724 # {author+date: {path: {patchset: {line: url+message}}}}
1725 comments = collections.defaultdict(
1726 lambda: collections.defaultdict(lambda: collections.defaultdict(dict)))
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001727 for path, line_comments in file_comments.items():
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001728 for comment in line_comments:
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001729 tag = comment.get('tag', '')
1730 if tag.startswith('autogenerated') and 'robot_id' not in comment:
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001731 continue
1732 key = (comment['author']['email'], comment['updated'])
1733 if comment.get('side', 'REVISION') == 'PARENT':
1734 patchset = 'Base'
1735 else:
1736 patchset = 'PS%d' % comment['patch_set']
1737 line = comment.get('line', 0)
1738 url = ('https://%s/c/%s/%s/%s#%s%s' %
1739 (self._GetGerritHost(), self.GetIssue(), comment['patch_set'], path,
1740 'b' if comment.get('side') == 'PARENT' else '',
1741 str(line) if line else ''))
1742 comments[key][path][patchset][line] = (url, comment['message'])
1743
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001744 summaries = []
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001745 for msg in messages:
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001746 summary = self._BuildCommentSummary(msg, comments, readable)
1747 if summary:
1748 summaries.append(summary)
1749 return summaries
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001750
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001751 @staticmethod
1752 def _BuildCommentSummary(msg, comments, readable):
1753 key = (msg['author']['email'], msg['date'])
1754 # Don't bother showing autogenerated messages that don't have associated
1755 # file or line comments. this will filter out most autogenerated
1756 # messages, but will keep robot comments like those from Tricium.
1757 is_autogenerated = msg.get('tag', '').startswith('autogenerated')
1758 if is_autogenerated and not comments.get(key):
1759 return None
1760 message = msg['message']
1761 # Gerrit spits out nanoseconds.
1762 assert len(msg['date'].split('.')[-1]) == 9
1763 date = datetime.datetime.strptime(msg['date'][:-3],
1764 '%Y-%m-%d %H:%M:%S.%f')
1765 if key in comments:
1766 message += '\n'
1767 for path, patchsets in sorted(comments.get(key, {}).items()):
1768 if readable:
1769 message += '\n%s' % path
1770 for patchset, lines in sorted(patchsets.items()):
1771 for line, (url, content) in sorted(lines.items()):
1772 if line:
1773 line_str = 'Line %d' % line
1774 path_str = '%s:%d:' % (path, line)
1775 else:
1776 line_str = 'File comment'
1777 path_str = '%s:0:' % path
1778 if readable:
1779 message += '\n %s, %s: %s' % (patchset, line_str, url)
1780 message += '\n %s\n' % content
1781 else:
1782 message += '\n%s ' % path_str
1783 message += '\n%s\n' % content
1784
1785 return _CommentSummary(
1786 date=date,
1787 message=message,
1788 sender=msg['author']['email'],
1789 autogenerated=is_autogenerated,
1790 # These could be inferred from the text messages and correlated with
1791 # Code-Review label maximum, however this is not reliable.
1792 # Leaving as is until the need arises.
1793 approval=False,
1794 disapproval=False,
1795 )
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01001796
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001797 def CloseIssue(self):
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00001798 gerrit_util.AbandonChange(
1799 self._GetGerritHost(), self._GerritChangeIdentifier(), msg='')
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001800
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00001801 def SubmitIssue(self, wait_for_merge=True):
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00001802 gerrit_util.SubmitChange(
1803 self._GetGerritHost(), self._GerritChangeIdentifier(),
1804 wait_for_merge=wait_for_merge)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001805
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001806 def _GetChangeDetail(self, options=None):
1807 """Returns details of associated Gerrit change and caching results."""
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00001808 options = options or []
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001809 assert self.GetIssue(), 'issue is required to query Gerrit'
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01001810
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01001811 # Optimization to avoid multiple RPCs:
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001812 if 'CURRENT_REVISION' in options or 'ALL_REVISIONS' in options:
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01001813 options.append('CURRENT_COMMIT')
1814
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01001815 # Normalize issue and options for consistent keys in cache.
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001816 cache_key = str(self.GetIssue())
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001817 options_set = frozenset(o.upper() for o in options)
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01001818
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001819 for cached_options_set, data in self._detail_cache.get(cache_key, []):
1820 # Assumption: data fetched before with extra options is suitable
1821 # for return for a smaller set of options.
1822 # For example, if we cached data for
1823 # options=[CURRENT_REVISION, DETAILED_FOOTERS]
1824 # and request is for options=[CURRENT_REVISION],
1825 # THEN we can return prior cached data.
1826 if options_set.issubset(cached_options_set):
1827 return data
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01001828
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01001829 try:
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001830 data = gerrit_util.GetChangeDetail(
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001831 self._GetGerritHost(), self._GerritChangeIdentifier(), options_set)
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01001832 except gerrit_util.GerritError as e:
1833 if e.http_status == 404:
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001834 raise GerritChangeNotExists(self.GetIssue(), self.GetCodereviewServer())
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01001835 raise
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01001836
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001837 self._detail_cache.setdefault(cache_key, []).append((options_set, data))
tandriic2405f52016-10-10 08:13:15 -07001838 return data
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001839
Andrii Shyshkalovcc5f17e2018-08-22 23:35:59 +00001840 def _GetChangeCommit(self):
Andrii Shyshkalove2633162018-08-27 23:50:31 +00001841 assert self.GetIssue(), 'issue must be set to query Gerrit'
Aaron Gable6f5a8d92017-04-18 14:49:05 -07001842 try:
Andrii Shyshkalove2633162018-08-27 23:50:31 +00001843 data = gerrit_util.GetChangeCommit(
1844 self._GetGerritHost(), self._GerritChangeIdentifier())
Aaron Gable6f5a8d92017-04-18 14:49:05 -07001845 except gerrit_util.GerritError as e:
1846 if e.http_status == 404:
Andrii Shyshkalove2633162018-08-27 23:50:31 +00001847 raise GerritChangeNotExists(self.GetIssue(), self.GetCodereviewServer())
Aaron Gable6f5a8d92017-04-18 14:49:05 -07001848 raise
agable32978d92016-11-01 12:55:02 -07001849 return data
1850
Karen Qian40c19422019-03-13 21:28:29 +00001851 def _IsCqConfigured(self):
1852 detail = self._GetChangeDetail(['LABELS'])
Andrii Shyshkalov8effa4d2020-01-21 13:23:36 +00001853 return u'Commit-Queue' in detail.get('labels', {})
Karen Qian40c19422019-03-13 21:28:29 +00001854
Olivier Robin75ee7252018-04-13 10:02:56 +02001855 def CMDLand(self, force, bypass_hooks, verbose, parallel):
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00001856 if git_common.is_dirty_git_tree('land'):
1857 return 1
Karen Qian40c19422019-03-13 21:28:29 +00001858
tandriid60367b2016-06-22 05:25:12 -07001859 detail = self._GetChangeDetail(['CURRENT_REVISION', 'LABELS'])
Karen Qian40c19422019-03-13 21:28:29 +00001860 if not force and self._IsCqConfigured():
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00001861 confirm_or_exit('\nIt seems this repository has a CQ, '
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001862 'which can test and land changes for you. '
1863 'Are you sure you wish to bypass it?\n',
1864 action='bypass CQ')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00001865 differs = True
tandriic4344b52016-08-29 06:04:54 -07001866 last_upload = self._GitGetBranchConfigValue('gerritsquashhash')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00001867 # Note: git diff outputs nothing if there is no diff.
1868 if not last_upload or RunGit(['diff', last_upload]).strip():
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001869 print('WARNING: Some changes from local branch haven\'t been uploaded.')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00001870 else:
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00001871 if detail['current_revision'] == last_upload:
1872 differs = False
1873 else:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001874 print('WARNING: Local branch contents differ from latest uploaded '
1875 'patchset.')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00001876 if differs:
1877 if not force:
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001878 confirm_or_exit(
1879 'Do you want to submit latest Gerrit patchset and bypass hooks?\n',
1880 action='submit')
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001881 print('WARNING: Bypassing hooks and submitting latest uploaded patchset.')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00001882 elif not bypass_hooks:
Edward Lemur227d5102020-02-25 23:45:35 +00001883 upstream = self.GetCommonAncestorWithUpstream()
1884 if self.GetIssue():
1885 description = self.FetchDescription()
1886 else:
Edward Lemura12175c2020-03-09 16:58:26 +00001887 description = _create_description_from_log([upstream])
Edward Lemur227d5102020-02-25 23:45:35 +00001888 self.RunHook(
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00001889 committing=True,
1890 may_prompt=not force,
1891 verbose=verbose,
Edward Lemur227d5102020-02-25 23:45:35 +00001892 parallel=parallel,
1893 upstream=upstream,
1894 description=description,
1895 all_files=False)
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00001896
1897 self.SubmitIssue(wait_for_merge=True)
1898 print('Issue %s has been submitted.' % self.GetIssueURL())
agable32978d92016-11-01 12:55:02 -07001899 links = self._GetChangeCommit().get('web_links', [])
1900 for link in links:
Aaron Gable02cdbb42016-12-13 16:24:25 -08001901 if link.get('name') == 'gitiles' and link.get('url'):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001902 print('Landed as: %s' % link.get('url'))
agable32978d92016-11-01 12:55:02 -07001903 break
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00001904 return 0
1905
Edward Lemurf38bc172019-09-03 21:02:13 +00001906 def CMDPatchWithParsedIssue(self, parsed_issue_arg, nocommit, force):
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001907 assert parsed_issue_arg.valid
1908
Edward Lemur125d60a2019-09-13 18:25:41 +00001909 self.issue = parsed_issue_arg.issue
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001910
1911 if parsed_issue_arg.hostname:
1912 self._gerrit_host = parsed_issue_arg.hostname
1913 self._gerrit_server = 'https://%s' % self._gerrit_host
1914
tandriic2405f52016-10-10 08:13:15 -07001915 try:
1916 detail = self._GetChangeDetail(['ALL_REVISIONS'])
Aaron Gablea45ee112016-11-22 15:14:38 -08001917 except GerritChangeNotExists as e:
tandriic2405f52016-10-10 08:13:15 -07001918 DieWithError(str(e))
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001919
1920 if not parsed_issue_arg.patchset:
1921 # Use current revision by default.
1922 revision_info = detail['revisions'][detail['current_revision']]
1923 patchset = int(revision_info['_number'])
1924 else:
1925 patchset = parsed_issue_arg.patchset
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001926 for revision_info in detail['revisions'].values():
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001927 if int(revision_info['_number']) == parsed_issue_arg.patchset:
1928 break
1929 else:
Aaron Gablea45ee112016-11-22 15:14:38 -08001930 DieWithError('Couldn\'t find patchset %i in change %i' %
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001931 (parsed_issue_arg.patchset, self.GetIssue()))
1932
Edward Lemur125d60a2019-09-13 18:25:41 +00001933 remote_url = self.GetRemoteUrl()
Aaron Gable697a91b2018-01-19 15:20:15 -08001934 if remote_url.endswith('.git'):
1935 remote_url = remote_url[:-len('.git')]
erikchen0d14d0d2018-08-28 18:57:09 +00001936 remote_url = remote_url.rstrip('/')
1937
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001938 fetch_info = revision_info['fetch']['http']
erikchen0d14d0d2018-08-28 18:57:09 +00001939 fetch_info['url'] = fetch_info['url'].rstrip('/')
Aaron Gable697a91b2018-01-19 15:20:15 -08001940
1941 if remote_url != fetch_info['url']:
1942 DieWithError('Trying to patch a change from %s but this repo appears '
1943 'to be %s.' % (fetch_info['url'], remote_url))
1944
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001945 RunGit(['fetch', fetch_info['url'], fetch_info['ref']])
Aaron Gable9387b4f2017-06-08 10:50:03 -07001946
Aaron Gable62619a32017-06-16 08:22:09 -07001947 if force:
1948 RunGit(['reset', '--hard', 'FETCH_HEAD'])
1949 print('Checked out commit for change %i patchset %i locally' %
1950 (parsed_issue_arg.issue, patchset))
Stefan Zager2d5f0392017-10-10 15:17:53 -07001951 elif nocommit:
1952 RunGit(['cherry-pick', '--no-commit', 'FETCH_HEAD'])
1953 print('Patch applied to index.')
Aaron Gable62619a32017-06-16 08:22:09 -07001954 else:
Aaron Gable9387b4f2017-06-08 10:50:03 -07001955 RunGit(['cherry-pick', 'FETCH_HEAD'])
1956 print('Committed patch for change %i patchset %i locally.' %
Aaron Gable62619a32017-06-16 08:22:09 -07001957 (parsed_issue_arg.issue, patchset))
1958 print('Note: this created a local commit which does not have '
1959 'the same hash as the one uploaded for review. This will make '
1960 'uploading changes based on top of this branch difficult.\n'
1961 'If you want to do that, use "git cl patch --force" instead.')
1962
Stefan Zagerd08043c2017-10-12 12:07:02 -07001963 if self.GetBranch():
1964 self.SetIssue(parsed_issue_arg.issue)
1965 self.SetPatchset(patchset)
Edward Lesmese3a49aa2020-03-24 23:46:28 +00001966 fetched_hash = scm.GIT.ResolveCommit(settings.GetRoot(), 'FETCH_HEAD')
Stefan Zagerd08043c2017-10-12 12:07:02 -07001967 self._GitSetBranchConfigValue('last-upload-hash', fetched_hash)
1968 self._GitSetBranchConfigValue('gerritsquashhash', fetched_hash)
1969 else:
1970 print('WARNING: You are in detached HEAD state.\n'
1971 'The patch has been applied to your checkout, but you will not be '
1972 'able to upload a new patch set to the gerrit issue.\n'
1973 'Try using the \'-b\' option if you would like to work on a '
1974 'branch and/or upload a new patch set.')
1975
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001976 return 0
1977
tandrii16e0b4e2016-06-07 10:34:28 -07001978 def _GerritCommitMsgHookCheck(self, offer_removal):
1979 hook = os.path.join(settings.GetRoot(), '.git', 'hooks', 'commit-msg')
1980 if not os.path.exists(hook):
1981 return
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001982 # Crude attempt to distinguish Gerrit Codereview hook from a potentially
1983 # custom developer-made one.
tandrii16e0b4e2016-06-07 10:34:28 -07001984 data = gclient_utils.FileRead(hook)
1985 if not('From Gerrit Code Review' in data and 'add_ChangeId()' in data):
1986 return
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001987 print('WARNING: You have Gerrit commit-msg hook installed.\n'
qyearsley12fa6ff2016-08-24 09:18:40 -07001988 'It is not necessary for uploading with git cl in squash mode, '
tandrii16e0b4e2016-06-07 10:34:28 -07001989 'and may interfere with it in subtle ways.\n'
1990 'We recommend you remove the commit-msg hook.')
1991 if offer_removal:
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001992 if ask_for_explicit_yes('Do you want to remove it now?'):
tandrii16e0b4e2016-06-07 10:34:28 -07001993 gclient_utils.rm_file_or_tree(hook)
1994 print('Gerrit commit-msg hook removed.')
1995 else:
1996 print('OK, will keep Gerrit commit-msg hook in place.')
1997
Edward Lemur1b52d872019-05-09 21:12:12 +00001998 def _CleanUpOldTraces(self):
1999 """Keep only the last |MAX_TRACES| traces."""
2000 try:
2001 traces = sorted([
2002 os.path.join(TRACES_DIR, f)
2003 for f in os.listdir(TRACES_DIR)
2004 if (os.path.isfile(os.path.join(TRACES_DIR, f))
2005 and not f.startswith('tmp'))
2006 ])
2007 traces_to_delete = traces[:-MAX_TRACES]
2008 for trace in traces_to_delete:
Daniel Chengcf6269b2019-05-18 01:02:12 +00002009 os.remove(trace)
Edward Lemur1b52d872019-05-09 21:12:12 +00002010 except OSError:
2011 print('WARNING: Failed to remove old git traces from\n'
2012 ' %s'
2013 'Consider removing them manually.' % TRACES_DIR)
Edward Lemurdc8e23d2019-05-07 00:45:48 +00002014
Edward Lemur5737f022019-05-17 01:24:00 +00002015 def _WriteGitPushTraces(self, trace_name, traces_dir, git_push_metadata):
Edward Lemur1b52d872019-05-09 21:12:12 +00002016 """Zip and write the git push traces stored in traces_dir."""
2017 gclient_utils.safe_makedirs(TRACES_DIR)
Edward Lemur1b52d872019-05-09 21:12:12 +00002018 traces_zip = trace_name + '-traces'
2019 traces_readme = trace_name + '-README'
Michael Mosse7f0b4c2019-05-08 04:36:24 +00002020 # Create a temporary dir to store git config and gitcookies in. It will be
2021 # compressed and stored next to the traces.
2022 git_info_dir = tempfile.mkdtemp()
Edward Lemur1b52d872019-05-09 21:12:12 +00002023 git_info_zip = trace_name + '-git-info'
2024
Edward Lemur5737f022019-05-17 01:24:00 +00002025 git_push_metadata['now'] = datetime_now().strftime('%c')
Eric Boren67c48202019-05-30 16:52:51 +00002026 if sys.stdin.encoding and sys.stdin.encoding != 'utf-8':
sangwoo.ko7a614332019-05-22 02:46:19 +00002027 git_push_metadata['now'] = git_push_metadata['now'].decode(
2028 sys.stdin.encoding)
2029
Edward Lemur1b52d872019-05-09 21:12:12 +00002030 git_push_metadata['trace_name'] = trace_name
2031 gclient_utils.FileWrite(
2032 traces_readme, TRACES_README_FORMAT % git_push_metadata)
2033
2034 # Keep only the first 6 characters of the git hashes on the packet
2035 # trace. This greatly decreases size after compression.
2036 packet_traces = os.path.join(traces_dir, 'trace-packet')
2037 if os.path.isfile(packet_traces):
2038 contents = gclient_utils.FileRead(packet_traces)
2039 gclient_utils.FileWrite(
2040 packet_traces, GIT_HASH_RE.sub(r'\1', contents))
2041 shutil.make_archive(traces_zip, 'zip', traces_dir)
2042
2043 # Collect and compress the git config and gitcookies.
2044 git_config = RunGit(['config', '-l'])
2045 gclient_utils.FileWrite(
2046 os.path.join(git_info_dir, 'git-config'),
2047 git_config)
2048
2049 cookie_auth = gerrit_util.Authenticator.get()
2050 if isinstance(cookie_auth, gerrit_util.CookiesAuthenticator):
2051 gitcookies_path = cookie_auth.get_gitcookies_path()
2052 if os.path.isfile(gitcookies_path):
2053 gitcookies = gclient_utils.FileRead(gitcookies_path)
2054 gclient_utils.FileWrite(
2055 os.path.join(git_info_dir, 'gitcookies'),
2056 GITCOOKIES_REDACT_RE.sub('REDACTED', gitcookies))
2057 shutil.make_archive(git_info_zip, 'zip', git_info_dir)
2058
Edward Lemur1b52d872019-05-09 21:12:12 +00002059 gclient_utils.rmtree(git_info_dir)
2060
2061 def _RunGitPushWithTraces(
2062 self, change_desc, refspec, refspec_opts, git_push_metadata):
2063 """Run git push and collect the traces resulting from the execution."""
2064 # Create a temporary directory to store traces in. Traces will be compressed
2065 # and stored in a 'traces' dir inside depot_tools.
2066 traces_dir = tempfile.mkdtemp()
Edward Lemur5737f022019-05-17 01:24:00 +00002067 trace_name = os.path.join(
2068 TRACES_DIR, datetime_now().strftime('%Y%m%dT%H%M%S.%f'))
Edward Lemur0f58ae42019-04-30 17:24:12 +00002069
2070 env = os.environ.copy()
2071 env['GIT_REDACT_COOKIES'] = 'o,SSO,GSSO_Uberproxy'
2072 env['GIT_TR2_EVENT'] = os.path.join(traces_dir, 'tr2-event')
Jonathan Nieder9779b142019-05-29 23:19:29 +00002073 env['GIT_TRACE2_EVENT'] = os.path.join(traces_dir, 'tr2-event')
Edward Lemur0f58ae42019-04-30 17:24:12 +00002074 env['GIT_TRACE_CURL'] = os.path.join(traces_dir, 'trace-curl')
2075 env['GIT_TRACE_CURL_NO_DATA'] = '1'
2076 env['GIT_TRACE_PACKET'] = os.path.join(traces_dir, 'trace-packet')
2077
2078 try:
2079 push_returncode = 0
Edward Lemur1b52d872019-05-09 21:12:12 +00002080 remote_url = self.GetRemoteUrl()
Edward Lemur0f58ae42019-04-30 17:24:12 +00002081 before_push = time_time()
2082 push_stdout = gclient_utils.CheckCallAndFilter(
Edward Lemur1b52d872019-05-09 21:12:12 +00002083 ['git', 'push', remote_url, refspec],
Edward Lemur0f58ae42019-04-30 17:24:12 +00002084 env=env,
2085 print_stdout=True,
2086 # Flush after every line: useful for seeing progress when running as
2087 # recipe.
2088 filter_fn=lambda _: sys.stdout.flush())
Edward Lemur79d4f992019-11-11 23:49:02 +00002089 push_stdout = push_stdout.decode('utf-8', 'replace')
Edward Lemur0f58ae42019-04-30 17:24:12 +00002090 except subprocess2.CalledProcessError as e:
2091 push_returncode = e.returncode
2092 DieWithError('Failed to create a change. Please examine output above '
2093 'for the reason of the failure.\n'
2094 'Hint: run command below to diagnose common Git/Gerrit '
2095 'credential problems:\n'
Edward Lemur5737f022019-05-17 01:24:00 +00002096 ' git cl creds-check\n'
2097 '\n'
2098 'If git-cl is not working correctly, file a bug under the '
2099 'Infra>SDK component including the files below.\n'
2100 'Review the files before upload, since they might contain '
2101 'sensitive information.\n'
2102 'Set the Restrict-View-Google label so that they are not '
2103 'publicly accessible.\n'
2104 + TRACES_MESSAGE % {'trace_name': trace_name},
Edward Lemur0f58ae42019-04-30 17:24:12 +00002105 change_desc)
2106 finally:
2107 execution_time = time_time() - before_push
2108 metrics.collector.add_repeated('sub_commands', {
2109 'command': 'git push',
2110 'execution_time': execution_time,
2111 'exit_code': push_returncode,
2112 'arguments': metrics_utils.extract_known_subcommand_args(refspec_opts),
2113 })
2114
Edward Lemur1b52d872019-05-09 21:12:12 +00002115 git_push_metadata['execution_time'] = execution_time
2116 git_push_metadata['exit_code'] = push_returncode
Edward Lemur5737f022019-05-17 01:24:00 +00002117 self._WriteGitPushTraces(trace_name, traces_dir, git_push_metadata)
Edward Lemur0f58ae42019-04-30 17:24:12 +00002118
Edward Lemur1b52d872019-05-09 21:12:12 +00002119 self._CleanUpOldTraces()
Edward Lemur0f58ae42019-04-30 17:24:12 +00002120 gclient_utils.rmtree(traces_dir)
2121
2122 return push_stdout
2123
Edward Lemura12175c2020-03-09 16:58:26 +00002124 def CMDUploadChange(
Edward Lemur5a644f82020-03-18 16:44:57 +00002125 self, options, git_diff_args, custom_cl_base, change_desc):
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002126 """Upload the current branch to Gerrit."""
Mike Frysingera989d552019-08-14 20:51:23 +00002127 if options.squash is None:
tandriia60502f2016-06-20 02:01:53 -07002128 # Load default for user, repo, squash=true, in this order.
2129 options.squash = settings.GetSquashGerritUploads()
tandrii26f3e4e2016-06-10 08:37:04 -07002130
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002131 remote, remote_branch = self.GetRemoteBranch()
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01002132 branch = GetTargetRef(remote, remote_branch, options.target_branch)
Dominic Battre7d1c4842017-10-27 09:17:28 +02002133
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002134 if options.squash:
tandrii16e0b4e2016-06-07 10:34:28 -07002135 self._GerritCommitMsgHookCheck(offer_removal=not options.force)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002136 if self.GetIssue():
Josipe827b0f2020-01-30 00:07:20 +00002137 # User requested to change description
2138 if options.edit_description:
Josipe827b0f2020-01-30 00:07:20 +00002139 change_desc.prompt()
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002140 change_id = self._GetChangeDetail()['change_id']
Edward Lemur5a644f82020-03-18 16:44:57 +00002141 change_desc.ensure_change_id(change_id)
Aaron Gableb56ad332017-01-06 15:24:31 -08002142 else: # if not self.GetIssue()
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002143 if not options.force:
Anthony Polito8b955342019-09-24 19:01:36 +00002144 change_desc.prompt()
Andrii Shyshkalov8c90d032017-04-19 21:27:26 +02002145 change_ids = git_footers.get_footer_change_id(change_desc.description)
Edward Lemur5a644f82020-03-18 16:44:57 +00002146 if len(change_ids) == 1:
2147 change_id = change_ids[0]
2148 else:
2149 change_id = GenerateGerritChangeId(change_desc.description)
2150 change_desc.ensure_change_id(change_id)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002151
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +00002152 if options.preserve_tryjobs:
2153 change_desc.set_preserve_tryjobs()
Robert Iannuccidb02dd02017-04-19 12:18:20 -07002154
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002155 remote, upstream_branch = self.FetchUpstreamTuple(self.GetBranch())
Edward Lemur5a644f82020-03-18 16:44:57 +00002156 parent = self._ComputeParent(
2157 remote, upstream_branch, custom_cl_base, options.force, change_desc)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002158 tree = RunGit(['rev-parse', 'HEAD:']).strip()
Edward Lemur1773f372020-02-22 00:27:14 +00002159 with gclient_utils.temporary_file() as desc_tempfile:
2160 gclient_utils.FileWrite(desc_tempfile, change_desc.description)
2161 ref_to_push = RunGit(
2162 ['commit-tree', tree, '-p', parent, '-F', desc_tempfile]).strip()
Anthony Polito8b955342019-09-24 19:01:36 +00002163 else: # if not options.squash
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002164 if not git_footers.get_footer_change_id(change_desc.description):
2165 DownloadGerritHook(False)
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002166 change_desc.set_description(
Edward Lemur5a644f82020-03-18 16:44:57 +00002167 self._AddChangeIdToCommitMessage(
2168 change_desc.description, git_diff_args))
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002169 ref_to_push = 'HEAD'
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002170 # For no-squash mode, we assume the remote called "origin" is the one we
2171 # want. It is not worthwhile to support different workflows for
2172 # no-squash mode.
2173 parent = 'origin/%s' % branch
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002174 change_id = git_footers.get_footer_change_id(change_desc.description)[0]
2175
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +00002176 SaveDescriptionBackup(change_desc)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002177 commits = RunGitSilent(['rev-list', '%s..%s' % (parent,
2178 ref_to_push)]).splitlines()
2179 if len(commits) > 1:
2180 print('WARNING: This will upload %d commits. Run the following command '
2181 'to see which commits will be uploaded: ' % len(commits))
2182 print('git log %s..%s' % (parent, ref_to_push))
2183 print('You can also use `git squash-branch` to squash these into a '
2184 'single commit.')
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002185 confirm_or_exit(action='upload')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002186
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00002187 reviewers = sorted(change_desc.get_reviewers())
Edward Lemur4508b422019-10-03 21:56:35 +00002188 cc = []
2189 # Add CCs from WATCHLISTS and rietveld.cc git config unless this is
2190 # the initial upload, the CL is private, or auto-CCing has ben disabled.
2191 if not (self.GetIssue() or options.private or options.no_autocc):
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00002192 cc = self.GetCCList().split(',')
Edward Lemur4508b422019-10-03 21:56:35 +00002193 # Add cc's from the --cc flag.
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00002194 if options.cc:
2195 cc.extend(options.cc)
Edward Lemur79d4f992019-11-11 23:49:02 +00002196 cc = [email.strip() for email in cc if email.strip()]
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00002197 if change_desc.get_cced():
2198 cc.extend(change_desc.get_cced())
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00002199 if self._GetGerritHost() == 'chromium-review.googlesource.com':
2200 valid_accounts = set(reviewers + cc)
2201 # TODO(crbug/877717): relax this for all hosts.
2202 else:
2203 valid_accounts = gerrit_util.ValidAccounts(
2204 self._GetGerritHost(), reviewers + cc)
Andrii Shyshkalovf170af42018-10-30 07:00:44 +00002205 logging.info('accounts %s are recognized, %s invalid',
2206 sorted(valid_accounts),
2207 set(reviewers + cc).difference(set(valid_accounts)))
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00002208
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00002209 # Extra options that can be specified at push time. Doc:
2210 # https://gerrit-review.googlesource.com/Documentation/user-upload.html
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00002211 refspec_opts = []
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02002212
Aaron Gable844cf292017-06-28 11:32:59 -07002213 # By default, new changes are started in WIP mode, and subsequent patchsets
2214 # don't send email. At any time, passing --send-mail will mark the change
2215 # ready and send email for that particular patch.
Aaron Gableafd52772017-06-27 16:40:10 -07002216 if options.send_mail:
2217 refspec_opts.append('ready')
Aaron Gable844cf292017-06-28 11:32:59 -07002218 refspec_opts.append('notify=ALL')
Jamie Madill276da0b2018-04-27 14:41:20 -04002219 elif not self.GetIssue() and options.squash:
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08002220 refspec_opts.append('wip')
Aaron Gableafd52772017-06-27 16:40:10 -07002221 else:
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08002222 refspec_opts.append('notify=NONE')
Aaron Gable70f4e242017-06-26 10:45:59 -07002223
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02002224 # TODO(tandrii): options.message should be posted as a comment
Aaron Gablee5adf612017-07-14 10:43:58 -07002225 # if --send-mail is set on non-initial upload as Rietveld used to do it.
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02002226
Edward Lemur5a644f82020-03-18 16:44:57 +00002227 title = self._GetTitleForUpload(options)
Aaron Gable9b713dd2016-12-14 16:04:21 -08002228 if title:
Nick Carter8692b182017-11-06 16:30:38 -08002229 # Punctuation and whitespace in |title| must be percent-encoded.
2230 refspec_opts.append('m=' + gerrit_util.PercentEncodeForGitRef(title))
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00002231
agablec6787972016-09-09 16:13:34 -07002232 if options.private:
Aaron Gableb02daf02017-05-23 11:53:46 -07002233 refspec_opts.append('private')
agablec6787972016-09-09 16:13:34 -07002234
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00002235 for r in sorted(reviewers):
2236 if r in valid_accounts:
2237 refspec_opts.append('r=%s' % r)
2238 reviewers.remove(r)
2239 else:
2240 # TODO(tandrii): this should probably be a hard failure.
2241 print('WARNING: reviewer %s doesn\'t have a Gerrit account, skipping'
2242 % r)
2243 for c in sorted(cc):
2244 # refspec option will be rejected if cc doesn't correspond to an
2245 # account, even though REST call to add such arbitrary cc may succeed.
2246 if c in valid_accounts:
2247 refspec_opts.append('cc=%s' % c)
2248 cc.remove(c)
2249
rmistry9eadede2016-09-19 11:22:43 -07002250 if options.topic:
2251 # Documentation on Gerrit topics is here:
2252 # https://gerrit-review.googlesource.com/Documentation/user-upload.html#topic
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00002253 refspec_opts.append('topic=%s' % options.topic)
rmistry9eadede2016-09-19 11:22:43 -07002254
Edward Lemur687ca902018-12-05 02:30:30 +00002255 if options.enable_auto_submit:
2256 refspec_opts.append('l=Auto-Submit+1')
2257 if options.use_commit_queue:
2258 refspec_opts.append('l=Commit-Queue+2')
2259 elif options.cq_dry_run:
2260 refspec_opts.append('l=Commit-Queue+1')
2261
2262 if change_desc.get_reviewers(tbr_only=True):
2263 score = gerrit_util.GetCodeReviewTbrScore(
2264 self._GetGerritHost(),
2265 self._GetGerritProject())
2266 refspec_opts.append('l=Code-Review+%s' % score)
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00002267
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08002268 # Gerrit sorts hashtags, so order is not important.
Nodir Turakulov23b82142017-11-16 11:04:25 -08002269 hashtags = {change_desc.sanitize_hash_tag(t) for t in options.hashtags}
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08002270 if not self.GetIssue():
Nodir Turakulov23b82142017-11-16 11:04:25 -08002271 hashtags.update(change_desc.get_hash_tags())
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08002272 refspec_opts += ['hashtag=%s' % t for t in sorted(hashtags)]
2273
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00002274 refspec_suffix = ''
2275 if refspec_opts:
2276 refspec_suffix = '%' + ','.join(refspec_opts)
2277 assert ' ' not in refspec_suffix, (
2278 'spaces not allowed in refspec: "%s"' % refspec_suffix)
2279 refspec = '%s:refs/for/%s%s' % (ref_to_push, branch, refspec_suffix)
2280
Edward Lemur1b52d872019-05-09 21:12:12 +00002281 git_push_metadata = {
2282 'gerrit_host': self._GetGerritHost(),
2283 'title': title or '<untitled>',
2284 'change_id': change_id,
2285 'description': change_desc.description,
2286 }
2287 push_stdout = self._RunGitPushWithTraces(
2288 change_desc, refspec, refspec_opts, git_push_metadata)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002289
2290 if options.squash:
Aaron Gable289b4312017-09-13 14:06:16 -07002291 regex = re.compile(r'remote:\s+https?://[\w\-\.\+\/#]*/(\d+)\s.*')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002292 change_numbers = [m.group(1)
2293 for m in map(regex.match, push_stdout.splitlines())
2294 if m]
2295 if len(change_numbers) != 1:
2296 DieWithError(
2297 ('Created|Updated %d issues on Gerrit, but only 1 expected.\n'
Christopher Lamf732cd52017-01-24 12:40:11 +11002298 'Change-Id: %s') % (len(change_numbers), change_id), change_desc)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002299 self.SetIssue(change_numbers[0])
tandrii5d48c322016-08-18 16:19:37 -07002300 self._GitSetBranchConfigValue('gerritsquashhash', ref_to_push)
tandrii88189772016-09-29 04:29:57 -07002301
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00002302 if self.GetIssue() and (reviewers or cc):
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00002303 # GetIssue() is not set in case of non-squash uploads according to tests.
2304 # TODO(agable): non-squash uploads in git cl should be removed.
2305 gerrit_util.AddReviewers(
2306 self._GetGerritHost(),
Andrii Shyshkalovd06cc782018-08-23 17:24:19 +00002307 self._GerritChangeIdentifier(),
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00002308 reviewers, cc,
2309 notify=bool(options.send_mail))
Aaron Gable6dadfbf2017-05-09 14:27:58 -07002310
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002311 return 0
2312
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002313 def _ComputeParent(self, remote, upstream_branch, custom_cl_base, force,
2314 change_desc):
2315 """Computes parent of the generated commit to be uploaded to Gerrit.
2316
2317 Returns revision or a ref name.
2318 """
2319 if custom_cl_base:
2320 # Try to avoid creating additional unintended CLs when uploading, unless
2321 # user wants to take this risk.
2322 local_ref_of_target_remote = self.GetRemoteBranch()[1]
2323 code, _ = RunGitWithCode(['merge-base', '--is-ancestor', custom_cl_base,
2324 local_ref_of_target_remote])
2325 if code == 1:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002326 print('\nWARNING: Manually specified base of this CL `%s` '
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002327 'doesn\'t seem to belong to target remote branch `%s`.\n\n'
2328 'If you proceed with upload, more than 1 CL may be created by '
2329 'Gerrit as a result, in turn confusing or crashing git cl.\n\n'
2330 'If you are certain that specified base `%s` has already been '
2331 'uploaded to Gerrit as another CL, you may proceed.\n' %
2332 (custom_cl_base, local_ref_of_target_remote, custom_cl_base))
2333 if not force:
2334 confirm_or_exit(
2335 'Do you take responsibility for cleaning up potential mess '
2336 'resulting from proceeding with upload?',
2337 action='upload')
2338 return custom_cl_base
2339
Aaron Gablef97e33d2017-03-30 15:44:27 -07002340 if remote != '.':
2341 return self.GetCommonAncestorWithUpstream()
2342
2343 # If our upstream branch is local, we base our squashed commit on its
2344 # squashed version.
2345 upstream_branch_name = scm.GIT.ShortBranchName(upstream_branch)
2346
Aaron Gablef97e33d2017-03-30 15:44:27 -07002347 if upstream_branch_name == 'master':
Aaron Gable0bbd1c22017-05-08 14:37:08 -07002348 return self.GetCommonAncestorWithUpstream()
Aaron Gablef97e33d2017-03-30 15:44:27 -07002349
2350 # Check the squashed hash of the parent.
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002351 # TODO(tandrii): consider checking parent change in Gerrit and using its
2352 # hash if tree hash of latest parent revision (patchset) in Gerrit matches
2353 # the tree hash of the parent branch. The upside is less likely bogus
2354 # requests to reupload parent change just because it's uploadhash is
2355 # missing, yet the downside likely exists, too (albeit unknown to me yet).
Edward Lesmese3a49aa2020-03-24 23:46:28 +00002356 parent = self._GitGetBranchConfigValue('gerritsquashhash', '')
Aaron Gablef97e33d2017-03-30 15:44:27 -07002357 # Verify that the upstream branch has been uploaded too, otherwise
2358 # Gerrit will create additional CLs when uploading.
2359 if not parent or (RunGitSilent(['rev-parse', upstream_branch + ':']) !=
2360 RunGitSilent(['rev-parse', parent + ':'])):
2361 DieWithError(
2362 '\nUpload upstream branch %s first.\n'
2363 'It is likely that this branch has been rebased since its last '
2364 'upload, so you just need to upload it again.\n'
2365 '(If you uploaded it with --no-squash, then branch dependencies '
2366 'are not supported, and you should reupload with --squash.)'
2367 % upstream_branch_name,
2368 change_desc)
2369 return parent
2370
Edward Lemura12175c2020-03-09 16:58:26 +00002371 def _AddChangeIdToCommitMessage(self, log_desc, args):
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00002372 """Re-commits using the current message, assumes the commit hook is in
2373 place.
2374 """
Edward Lemura12175c2020-03-09 16:58:26 +00002375 RunGit(['commit', '--amend', '-m', log_desc])
Andrii Shyshkalovb07575f2018-10-16 06:16:21 +00002376 new_log_desc = _create_description_from_log(args)
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00002377 if git_footers.get_footer_change_id(new_log_desc):
vapiera7fbd5a2016-06-16 09:17:49 -07002378 print('git-cl: Added Change-Id to commit message.')
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00002379 return new_log_desc
2380 else:
tandrii@chromium.orgb067ec52016-05-31 15:24:44 +00002381 DieWithError('ERROR: Gerrit commit-msg hook not installed.')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002382
tandriie113dfd2016-10-11 10:20:12 -07002383 def CannotTriggerTryJobReason(self):
tandrii8c5a3532016-11-04 07:52:02 -07002384 try:
2385 data = self._GetChangeDetail()
Aaron Gablea45ee112016-11-22 15:14:38 -08002386 except GerritChangeNotExists:
2387 return 'Gerrit doesn\'t know about your change %s' % self.GetIssue()
tandrii8c5a3532016-11-04 07:52:02 -07002388
2389 if data['status'] in ('ABANDONED', 'MERGED'):
2390 return 'CL %s is closed' % self.GetIssue()
2391
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002392 def GetGerritChange(self, patchset=None):
2393 """Returns a buildbucket.v2.GerritChange message for the current issue."""
Edward Lemur79d4f992019-11-11 23:49:02 +00002394 host = urllib.parse.urlparse(self.GetCodereviewServer()).hostname
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002395 issue = self.GetIssue()
Edward Lemur2c210a42019-09-16 23:58:35 +00002396 patchset = int(patchset or self.GetPatchset())
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002397 data = self._GetChangeDetail(['ALL_REVISIONS'])
2398
2399 assert host and issue and patchset, 'CL must be uploaded first'
2400
2401 has_patchset = any(
2402 int(revision_data['_number']) == patchset
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00002403 for revision_data in data['revisions'].values())
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002404 if not has_patchset:
Aaron Gablea45ee112016-11-22 15:14:38 -08002405 raise Exception('Patchset %d is not known in Gerrit change %d' %
tandrii8c5a3532016-11-04 07:52:02 -07002406 (patchset, self.GetIssue()))
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002407
tandrii8c5a3532016-11-04 07:52:02 -07002408 return {
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002409 'host': host,
2410 'change': issue,
2411 'project': data['project'],
2412 'patchset': patchset,
tandrii8c5a3532016-11-04 07:52:02 -07002413 }
tandriie113dfd2016-10-11 10:20:12 -07002414
tandriide281ae2016-10-12 06:02:30 -07002415 def GetIssueOwner(self):
tandrii8c5a3532016-11-04 07:52:02 -07002416 return self._GetChangeDetail(['DETAILED_ACCOUNTS'])['owner']['email']
tandriide281ae2016-10-12 06:02:30 -07002417
Edward Lemur707d70b2018-02-07 00:50:14 +01002418 def GetReviewers(self):
2419 details = self._GetChangeDetail(['DETAILED_ACCOUNTS'])
Mohamed Heikal171c0742018-11-09 20:38:51 +00002420 return [r['email'] for r in details['reviewers'].get('REVIEWER', [])]
Edward Lemur707d70b2018-02-07 00:50:14 +01002421
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002422
tandriif9aefb72016-07-01 09:06:51 -07002423def _get_bug_line_values(default_project, bugs):
2424 """Given default_project and comma separated list of bugs, yields bug line
2425 values.
2426
2427 Each bug can be either:
2428 * a number, which is combined with default_project
2429 * string, which is left as is.
2430
2431 This function may produce more than one line, because bugdroid expects one
2432 project per line.
2433
2434 >>> list(_get_bug_line_values('v8', '123,chromium:789'))
2435 ['v8:123', 'chromium:789']
2436 """
2437 default_bugs = []
2438 others = []
2439 for bug in bugs.split(','):
2440 bug = bug.strip()
2441 if bug:
2442 try:
2443 default_bugs.append(int(bug))
2444 except ValueError:
2445 others.append(bug)
2446
2447 if default_bugs:
2448 default_bugs = ','.join(map(str, default_bugs))
2449 if default_project:
2450 yield '%s:%s' % (default_project, default_bugs)
2451 else:
2452 yield default_bugs
2453 for other in sorted(others):
2454 # Don't bother finding common prefixes, CLs with >2 bugs are very very rare.
2455 yield other
2456
2457
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00002458class ChangeDescription(object):
2459 """Contains a parsed form of the change description."""
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00002460 R_LINE = r'^[ \t]*(TBR|R)[ \t]*=[ \t]*(.*?)[ \t]*$'
bradnelsond975b302016-10-23 12:20:23 -07002461 CC_LINE = r'^[ \t]*(CC)[ \t]*=[ \t]*(.*?)[ \t]*$'
Aaron Gable3a16ed12017-03-23 10:51:55 -07002462 BUG_LINE = r'^[ \t]*(?:(BUG)[ \t]*=|Bug:)[ \t]*(.*?)[ \t]*$'
Dan Beamd8b04ca2019-10-10 21:23:26 +00002463 FIXED_LINE = r'^[ \t]*Fixed[ \t]*:[ \t]*(.*?)[ \t]*$'
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01002464 CHERRY_PICK_LINE = r'^\(cherry picked from commit [a-fA-F0-9]{40}\)$'
Nodir Turakulov23b82142017-11-16 11:04:25 -08002465 STRIP_HASH_TAG_PREFIX = r'^(\s*(revert|reland)( "|:)?\s*)*'
2466 BRACKET_HASH_TAG = r'\s*\[([^\[\]]+)\]'
Anthony Polito02b5af32019-12-02 19:49:47 +00002467 COLON_SEPARATED_HASH_TAG = r'^([a-zA-Z0-9_\- ]+):($|[^:])'
Nodir Turakulov23b82142017-11-16 11:04:25 -08002468 BAD_HASH_TAG_CHUNK = r'[^a-zA-Z0-9]+'
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00002469
Dan Beamd8b04ca2019-10-10 21:23:26 +00002470 def __init__(self, description, bug=None, fixed=None):
agable@chromium.org42c20792013-09-12 17:34:49 +00002471 self._description_lines = (description or '').strip().splitlines()
Anthony Polito8b955342019-09-24 19:01:36 +00002472 if bug:
2473 regexp = re.compile(self.BUG_LINE)
2474 prefix = settings.GetBugPrefix()
2475 if not any((regexp.match(line) for line in self._description_lines)):
2476 values = list(_get_bug_line_values(prefix, bug))
2477 self.append_footer('Bug: %s' % ', '.join(values))
Dan Beamd8b04ca2019-10-10 21:23:26 +00002478 if fixed:
2479 regexp = re.compile(self.FIXED_LINE)
2480 prefix = settings.GetBugPrefix()
2481 if not any((regexp.match(line) for line in self._description_lines)):
2482 values = list(_get_bug_line_values(prefix, fixed))
2483 self.append_footer('Fixed: %s' % ', '.join(values))
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002484
agable@chromium.org42c20792013-09-12 17:34:49 +00002485 @property # www.logilab.org/ticket/89786
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08002486 def description(self): # pylint: disable=method-hidden
agable@chromium.org42c20792013-09-12 17:34:49 +00002487 return '\n'.join(self._description_lines)
2488
2489 def set_description(self, desc):
2490 if isinstance(desc, basestring):
2491 lines = desc.splitlines()
2492 else:
2493 lines = [line.rstrip() for line in desc]
2494 while lines and not lines[0]:
2495 lines.pop(0)
2496 while lines and not lines[-1]:
2497 lines.pop(-1)
2498 self._description_lines = lines
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002499
Edward Lemur5a644f82020-03-18 16:44:57 +00002500 def ensure_change_id(self, change_id):
2501 description = self.description
2502 footer_change_ids = git_footers.get_footer_change_id(description)
2503 # Make sure that the Change-Id in the description matches the given one.
2504 if footer_change_ids != [change_id]:
2505 if footer_change_ids:
2506 # Remove any existing Change-Id footers since they don't match the
2507 # expected change_id footer.
2508 description = git_footers.remove_footer(description, 'Change-Id')
2509 print('WARNING: Change-Id has been set to %s. Use `git cl issue 0` '
2510 'if you want to set a new one.')
2511 # Add the expected Change-Id footer.
2512 description = git_footers.add_footer_change_id(description, change_id)
2513 self.set_description(description)
2514
Edward Lemur2c62b332020-03-12 22:12:33 +00002515 def update_reviewers(
2516 self, reviewers, tbrs, add_owners_to, affected_files, author_email):
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002517 """Rewrites the R=/TBR= line(s) as a single line each.
2518
2519 Args:
2520 reviewers (list(str)) - list of additional emails to use for reviewers.
2521 tbrs (list(str)) - list of additional emails to use for TBRs.
2522 add_owners_to (None|'R'|'TBR') - Pass to do an OWNERS lookup for files in
2523 the change that are missing OWNER coverage. If this is not None, you
2524 must also pass a value for `change`.
2525 change (Change) - The Change that should be used for OWNERS lookups.
2526 """
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002527 assert isinstance(reviewers, list), reviewers
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002528 assert isinstance(tbrs, list), tbrs
2529
Robert Iannuccif2708bd2017-04-17 15:49:02 -07002530 assert add_owners_to in (None, 'TBR', 'R'), add_owners_to
Edward Lemur2c62b332020-03-12 22:12:33 +00002531 assert not add_owners_to or affected_files, add_owners_to
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002532
2533 if not reviewers and not tbrs and not add_owners_to:
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002534 return
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002535
2536 reviewers = set(reviewers)
2537 tbrs = set(tbrs)
2538 LOOKUP = {
2539 'TBR': tbrs,
2540 'R': reviewers,
2541 }
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002542
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002543 # Get the set of R= and TBR= lines and remove them from the description.
agable@chromium.org42c20792013-09-12 17:34:49 +00002544 regexp = re.compile(self.R_LINE)
2545 matches = [regexp.match(line) for line in self._description_lines]
2546 new_desc = [l for i, l in enumerate(self._description_lines)
2547 if not matches[i]]
2548 self.set_description(new_desc)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002549
agable@chromium.org42c20792013-09-12 17:34:49 +00002550 # Construct new unified R= and TBR= lines.
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002551
2552 # First, update tbrs/reviewers with names from the R=/TBR= lines (if any).
agable@chromium.org42c20792013-09-12 17:34:49 +00002553 for match in matches:
2554 if not match:
2555 continue
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002556 LOOKUP[match.group(1)].update(cleanup_list([match.group(2).strip()]))
2557
2558 # Next, maybe fill in OWNERS coverage gaps to either tbrs/reviewers.
Robert Iannuccif2708bd2017-04-17 15:49:02 -07002559 if add_owners_to:
Edward Lemur2c62b332020-03-12 22:12:33 +00002560 owners_db = owners.Database(settings.GetRoot(),
Edward Lemurb7f759f2020-03-04 21:20:56 +00002561 fopen=open, os_path=os.path)
Edward Lemur2c62b332020-03-12 22:12:33 +00002562 missing_files = owners_db.files_not_covered_by(affected_files,
Robert Iannucci100aa212017-04-18 17:28:26 -07002563 (tbrs | reviewers))
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002564 LOOKUP[add_owners_to].update(
Edward Lemur2c62b332020-03-12 22:12:33 +00002565 owners_db.reviewers_for(missing_files, author_email))
Robert Iannuccif2708bd2017-04-17 15:49:02 -07002566
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002567 # If any folks ended up in both groups, remove them from tbrs.
2568 tbrs -= reviewers
Robert Iannuccif2708bd2017-04-17 15:49:02 -07002569
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002570 new_r_line = 'R=' + ', '.join(sorted(reviewers)) if reviewers else None
2571 new_tbr_line = 'TBR=' + ', '.join(sorted(tbrs)) if tbrs else None
agable@chromium.org42c20792013-09-12 17:34:49 +00002572
2573 # Put the new lines in the description where the old first R= line was.
2574 line_loc = next((i for i, match in enumerate(matches) if match), -1)
2575 if 0 <= line_loc < len(self._description_lines):
2576 if new_tbr_line:
2577 self._description_lines.insert(line_loc, new_tbr_line)
2578 if new_r_line:
2579 self._description_lines.insert(line_loc, new_r_line)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002580 else:
agable@chromium.org42c20792013-09-12 17:34:49 +00002581 if new_r_line:
2582 self.append_footer(new_r_line)
2583 if new_tbr_line:
2584 self.append_footer(new_tbr_line)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002585
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +00002586 def set_preserve_tryjobs(self):
2587 """Ensures description footer contains 'Cq-Do-Not-Cancel-Tryjobs: true'."""
2588 footers = git_footers.parse_footers(self.description)
2589 for v in footers.get('Cq-Do-Not-Cancel-Tryjobs', []):
2590 if v.lower() == 'true':
2591 return
2592 self.append_footer('Cq-Do-Not-Cancel-Tryjobs: true')
2593
Anthony Polito8b955342019-09-24 19:01:36 +00002594 def prompt(self):
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002595 """Asks the user to update the description."""
agable@chromium.org42c20792013-09-12 17:34:49 +00002596 self.set_description([
2597 '# Enter a description of the change.',
2598 '# This will be displayed on the codereview site.',
2599 '# The first line will also be used as the subject of the review.',
alancutter@chromium.orgbd1073e2013-06-01 00:34:38 +00002600 '#--------------------This line is 72 characters long'
agable@chromium.org42c20792013-09-12 17:34:49 +00002601 '--------------------',
2602 ] + self._description_lines)
Dan Beamd8b04ca2019-10-10 21:23:26 +00002603 bug_regexp = re.compile(self.BUG_LINE)
2604 fixed_regexp = re.compile(self.FIXED_LINE)
Jonas Termansend0f79112019-03-22 15:28:26 +00002605 prefix = settings.GetBugPrefix()
Dan Beamd8b04ca2019-10-10 21:23:26 +00002606 has_issue = lambda l: bug_regexp.match(l) or fixed_regexp.match(l)
2607 if not any((has_issue(line) for line in self._description_lines)):
Anthony Polito8b955342019-09-24 19:01:36 +00002608 self.append_footer('Bug: %s' % prefix)
tandriif9aefb72016-07-01 09:06:51 -07002609
agable@chromium.org42c20792013-09-12 17:34:49 +00002610 content = gclient_utils.RunEditor(self.description, True,
Edward Lemur79d4f992019-11-11 23:49:02 +00002611 git_editor=settings.GetGitEditor())
maruel@chromium.org0e0436a2011-10-25 13:32:41 +00002612 if not content:
2613 DieWithError('Running editor failed')
agable@chromium.org42c20792013-09-12 17:34:49 +00002614 lines = content.splitlines()
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002615
Bruce Dawson2377b012018-01-11 16:46:49 -08002616 # Strip off comments and default inserted "Bug:" line.
2617 clean_lines = [line.rstrip() for line in lines if not
Jonas Termansend0f79112019-03-22 15:28:26 +00002618 (line.startswith('#') or
2619 line.rstrip() == "Bug:" or
2620 line.rstrip() == "Bug: " + prefix)]
agable@chromium.org42c20792013-09-12 17:34:49 +00002621 if not clean_lines:
maruel@chromium.org0e0436a2011-10-25 13:32:41 +00002622 DieWithError('No CL description, aborting')
agable@chromium.org42c20792013-09-12 17:34:49 +00002623 self.set_description(clean_lines)
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00002624
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002625 def append_footer(self, line):
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002626 """Adds a footer line to the description.
2627
2628 Differentiates legacy "KEY=xxx" footers (used to be called tags) and
2629 Gerrit's footers in the form of "Footer-Key: footer any value" and ensures
2630 that Gerrit footers are always at the end.
2631 """
2632 parsed_footer_line = git_footers.parse_footer(line)
2633 if parsed_footer_line:
2634 # Line is a gerrit footer in the form: Footer-Key: any value.
2635 # Thus, must be appended observing Gerrit footer rules.
2636 self.set_description(
2637 git_footers.add_footer(self.description,
2638 key=parsed_footer_line[0],
2639 value=parsed_footer_line[1]))
2640 return
2641
2642 if not self._description_lines:
2643 self._description_lines.append(line)
2644 return
2645
2646 top_lines, gerrit_footers, _ = git_footers.split_footers(self.description)
2647 if gerrit_footers:
2648 # git_footers.split_footers ensures that there is an empty line before
2649 # actual (gerrit) footers, if any. We have to keep it that way.
2650 assert top_lines and top_lines[-1] == ''
2651 top_lines, separator = top_lines[:-1], top_lines[-1:]
2652 else:
2653 separator = [] # No need for separator if there are no gerrit_footers.
2654
2655 prev_line = top_lines[-1] if top_lines else ''
2656 if (not presubmit_support.Change.TAG_LINE_RE.match(prev_line) or
2657 not presubmit_support.Change.TAG_LINE_RE.match(line)):
2658 top_lines.append('')
2659 top_lines.append(line)
2660 self._description_lines = top_lines + separator + gerrit_footers
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00002661
tandrii99a72f22016-08-17 14:33:24 -07002662 def get_reviewers(self, tbr_only=False):
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002663 """Retrieves the list of reviewers."""
agable@chromium.org42c20792013-09-12 17:34:49 +00002664 matches = [re.match(self.R_LINE, line) for line in self._description_lines]
tandrii99a72f22016-08-17 14:33:24 -07002665 reviewers = [match.group(2).strip()
2666 for match in matches
2667 if match and (not tbr_only or match.group(1).upper() == 'TBR')]
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002668 return cleanup_list(reviewers)
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00002669
bradnelsond975b302016-10-23 12:20:23 -07002670 def get_cced(self):
2671 """Retrieves the list of reviewers."""
2672 matches = [re.match(self.CC_LINE, line) for line in self._description_lines]
2673 cced = [match.group(2).strip() for match in matches if match]
2674 return cleanup_list(cced)
2675
Nodir Turakulov23b82142017-11-16 11:04:25 -08002676 def get_hash_tags(self):
2677 """Extracts and sanitizes a list of Gerrit hashtags."""
2678 subject = (self._description_lines or ('',))[0]
2679 subject = re.sub(
2680 self.STRIP_HASH_TAG_PREFIX, '', subject, flags=re.IGNORECASE)
2681
2682 tags = []
2683 start = 0
2684 bracket_exp = re.compile(self.BRACKET_HASH_TAG)
2685 while True:
2686 m = bracket_exp.match(subject, start)
2687 if not m:
2688 break
2689 tags.append(self.sanitize_hash_tag(m.group(1)))
2690 start = m.end()
2691
2692 if not tags:
2693 # Try "Tag: " prefix.
2694 m = re.match(self.COLON_SEPARATED_HASH_TAG, subject)
2695 if m:
2696 tags.append(self.sanitize_hash_tag(m.group(1)))
2697 return tags
2698
2699 @classmethod
2700 def sanitize_hash_tag(cls, tag):
2701 """Returns a sanitized Gerrit hash tag.
2702
2703 A sanitized hashtag can be used as a git push refspec parameter value.
2704 """
2705 return re.sub(cls.BAD_HASH_TAG_CHUNK, '-', tag).strip('-').lower()
2706
maruel@chromium.orge52678e2013-04-26 18:34:44 +00002707
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002708def FindCodereviewSettingsFile(filename='codereview.settings'):
2709 """Finds the given file starting in the cwd and going up.
2710
2711 Only looks up to the top of the repository unless an
2712 'inherit-review-settings-ok' file exists in the root of the repository.
2713 """
2714 inherit_ok_file = 'inherit-review-settings-ok'
2715 cwd = os.getcwd()
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00002716 root = settings.GetRoot()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002717 if os.path.isfile(os.path.join(root, inherit_ok_file)):
2718 root = '/'
2719 while True:
2720 if filename in os.listdir(cwd):
2721 if os.path.isfile(os.path.join(cwd, filename)):
2722 return open(os.path.join(cwd, filename))
2723 if cwd == root:
2724 break
2725 cwd = os.path.dirname(cwd)
2726
2727
2728def LoadCodereviewSettingsFromFile(fileobj):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002729 """Parses a codereview.settings file and updates hooks."""
maruel@chromium.org99ac1c52012-01-16 14:52:12 +00002730 keyvals = gclient_utils.ParseCodereviewSettingsContent(fileobj.read())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002731
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002732 def SetProperty(name, setting, unset_error_ok=False):
2733 fullname = 'rietveld.' + name
2734 if setting in keyvals:
2735 RunGit(['config', fullname, keyvals[setting]])
2736 else:
2737 RunGit(['config', '--unset-all', fullname], error_ok=unset_error_ok)
2738
tandrii48df5812016-10-17 03:55:37 -07002739 if not keyvals.get('GERRIT_HOST', False):
2740 SetProperty('server', 'CODE_REVIEW_SERVER')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002741 # Only server setting is required. Other settings can be absent.
2742 # In that case, we ignore errors raised during option deletion attempt.
2743 SetProperty('cc', 'CC_LIST', unset_error_ok=True)
2744 SetProperty('tree-status-url', 'STATUS', unset_error_ok=True)
2745 SetProperty('viewvc-url', 'VIEW_VC', unset_error_ok=True)
rmistry@google.com90752582014-01-14 21:04:50 +00002746 SetProperty('bug-prefix', 'BUG_PREFIX', unset_error_ok=True)
thestig@chromium.org44202a22014-03-11 19:22:18 +00002747 SetProperty('cpplint-regex', 'LINT_REGEX', unset_error_ok=True)
2748 SetProperty('cpplint-ignore-regex', 'LINT_IGNORE_REGEX', unset_error_ok=True)
rmistry@google.com5626a922015-02-26 14:03:30 +00002749 SetProperty('run-post-upload-hook', 'RUN_POST_UPLOAD_HOOK',
2750 unset_error_ok=True)
Jamie Madilldc4d19e2019-10-24 21:50:02 +00002751 SetProperty(
2752 'format-full-by-default', 'FORMAT_FULL_BY_DEFAULT', unset_error_ok=True)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002753
ukai@chromium.org7044efc2013-11-28 01:51:21 +00002754 if 'GERRIT_HOST' in keyvals:
ukai@chromium.orge8077812012-02-03 03:41:46 +00002755 RunGit(['config', 'gerrit.host', keyvals['GERRIT_HOST']])
ukai@chromium.orge8077812012-02-03 03:41:46 +00002756
bauerb@chromium.org54b400c2016-01-14 10:08:25 +00002757 if 'GERRIT_SQUASH_UPLOADS' in keyvals:
tandrii8dd81ea2016-06-16 13:24:23 -07002758 RunGit(['config', 'gerrit.squash-uploads',
2759 keyvals['GERRIT_SQUASH_UPLOADS']])
bauerb@chromium.org54b400c2016-01-14 10:08:25 +00002760
tandrii@chromium.org28253532016-04-14 13:46:56 +00002761 if 'GERRIT_SKIP_ENSURE_AUTHENTICATED' in keyvals:
shinyak@chromium.org00dbccd2016-04-15 07:24:43 +00002762 RunGit(['config', 'gerrit.skip-ensure-authenticated',
tandrii@chromium.org28253532016-04-14 13:46:56 +00002763 keyvals['GERRIT_SKIP_ENSURE_AUTHENTICATED']])
2764
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002765 if 'PUSH_URL_CONFIG' in keyvals and 'ORIGIN_URL_CONFIG' in keyvals:
Andrii Shyshkalov18975322017-01-25 16:44:13 +01002766 # should be of the form
2767 # PUSH_URL_CONFIG: url.ssh://gitrw.chromium.org.pushinsteadof
2768 # ORIGIN_URL_CONFIG: http://src.chromium.org/git
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002769 RunGit(['config', keyvals['PUSH_URL_CONFIG'],
2770 keyvals['ORIGIN_URL_CONFIG']])
2771
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002772
joshua.lock@intel.com426f69b2012-08-02 23:41:49 +00002773def urlretrieve(source, destination):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002774 """Downloads a network object to a local file, like urllib.urlretrieve.
2775
2776 This is necessary because urllib is broken for SSL connections via a proxy.
2777 """
joshua.lock@intel.com426f69b2012-08-02 23:41:49 +00002778 with open(destination, 'w') as f:
Edward Lemur79d4f992019-11-11 23:49:02 +00002779 f.write(urllib.request.urlopen(source).read())
joshua.lock@intel.com426f69b2012-08-02 23:41:49 +00002780
2781
ukai@chromium.org712d6102013-11-27 00:52:58 +00002782def hasSheBang(fname):
2783 """Checks fname is a #! script."""
2784 with open(fname) as f:
2785 return f.read(2).startswith('#!')
2786
2787
tandrii@chromium.org18630d62016-03-04 12:06:02 +00002788def DownloadGerritHook(force):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002789 """Downloads and installs a Gerrit commit-msg hook.
ukai@chromium.org78c4b982012-02-14 02:20:26 +00002790
2791 Args:
2792 force: True to update hooks. False to install hooks if not present.
2793 """
ukai@chromium.org712d6102013-11-27 00:52:58 +00002794 src = 'https://gerrit-review.googlesource.com/tools/hooks/commit-msg'
ukai@chromium.org78c4b982012-02-14 02:20:26 +00002795 dst = os.path.join(settings.GetRoot(), '.git', 'hooks', 'commit-msg')
2796 if not os.access(dst, os.X_OK):
2797 if os.path.exists(dst):
2798 if not force:
2799 return
ukai@chromium.org78c4b982012-02-14 02:20:26 +00002800 try:
joshua.lock@intel.com426f69b2012-08-02 23:41:49 +00002801 urlretrieve(src, dst)
ukai@chromium.org712d6102013-11-27 00:52:58 +00002802 if not hasSheBang(dst):
2803 DieWithError('Not a script: %s\n'
2804 'You need to download from\n%s\n'
2805 'into .git/hooks/commit-msg and '
2806 'chmod +x .git/hooks/commit-msg' % (dst, src))
ukai@chromium.org78c4b982012-02-14 02:20:26 +00002807 os.chmod(dst, stat.S_IRUSR | stat.S_IWUSR | stat.S_IXUSR)
2808 except Exception:
2809 if os.path.exists(dst):
2810 os.remove(dst)
ukai@chromium.org712d6102013-11-27 00:52:58 +00002811 DieWithError('\nFailed to download hooks.\n'
2812 'You need to download from\n%s\n'
2813 'into .git/hooks/commit-msg and '
2814 'chmod +x .git/hooks/commit-msg' % src)
ukai@chromium.org78c4b982012-02-14 02:20:26 +00002815
2816
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01002817class _GitCookiesChecker(object):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002818 """Provides facilities for validating and suggesting fixes to .gitcookies."""
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002819
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002820 _GOOGLESOURCE = 'googlesource.com'
2821
2822 def __init__(self):
2823 # Cached list of [host, identity, source], where source is either
2824 # .gitcookies or .netrc.
2825 self._all_hosts = None
2826
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01002827 def ensure_configured_gitcookies(self):
2828 """Runs checks and suggests fixes to make git use .gitcookies from default
2829 path."""
2830 default = gerrit_util.CookiesAuthenticator.get_gitcookies_path()
2831 configured_path = RunGitSilent(
2832 ['config', '--global', 'http.cookiefile']).strip()
Andrii Shyshkalov1e250cd2017-05-10 15:39:31 +02002833 configured_path = os.path.expanduser(configured_path)
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01002834 if configured_path:
2835 self._ensure_default_gitcookies_path(configured_path, default)
2836 else:
2837 self._configure_gitcookies_path(default)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002838
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01002839 @staticmethod
2840 def _ensure_default_gitcookies_path(configured_path, default_path):
2841 assert configured_path
2842 if configured_path == default_path:
2843 print('git is already configured to use your .gitcookies from %s' %
2844 configured_path)
2845 return
2846
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002847 print('WARNING: You have configured custom path to .gitcookies: %s\n'
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01002848 'Gerrit and other depot_tools expect .gitcookies at %s\n' %
2849 (configured_path, default_path))
2850
2851 if not os.path.exists(configured_path):
2852 print('However, your configured .gitcookies file is missing.')
2853 confirm_or_exit('Reconfigure git to use default .gitcookies?',
2854 action='reconfigure')
2855 RunGit(['config', '--global', 'http.cookiefile', default_path])
2856 return
2857
2858 if os.path.exists(default_path):
2859 print('WARNING: default .gitcookies file already exists %s' %
2860 default_path)
2861 DieWithError('Please delete %s manually and re-run git cl creds-check' %
2862 default_path)
2863
2864 confirm_or_exit('Move existing .gitcookies to default location?',
2865 action='move')
2866 shutil.move(configured_path, default_path)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002867 RunGit(['config', '--global', 'http.cookiefile', default_path])
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01002868 print('Moved and reconfigured git to use .gitcookies from %s' %
2869 default_path)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002870
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01002871 @staticmethod
2872 def _configure_gitcookies_path(default_path):
2873 netrc_path = gerrit_util.CookiesAuthenticator.get_netrc_path()
2874 if os.path.exists(netrc_path):
2875 print('You seem to be using outdated .netrc for git credentials: %s' %
2876 netrc_path)
2877 print('This tool will guide you through setting up recommended '
2878 '.gitcookies store for git credentials.\n'
2879 '\n'
2880 'IMPORTANT: If something goes wrong and you decide to go back, do:\n'
2881 ' git config --global --unset http.cookiefile\n'
2882 ' mv %s %s.backup\n\n' % (default_path, default_path))
2883 confirm_or_exit(action='setup .gitcookies')
2884 RunGit(['config', '--global', 'http.cookiefile', default_path])
2885 print('Configured git to use .gitcookies from %s' % default_path)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002886
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002887 def get_hosts_with_creds(self, include_netrc=False):
2888 if self._all_hosts is None:
2889 a = gerrit_util.CookiesAuthenticator()
2890 self._all_hosts = [
2891 (h, u, s)
2892 for h, u, s in itertools.chain(
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00002893 ((h, u, '.netrc') for h, (u, _, _) in a.netrc.hosts.items()),
2894 ((h, u, '.gitcookies') for h, (u, _) in a.gitcookies.items())
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002895 )
2896 if h.endswith(self._GOOGLESOURCE)
2897 ]
2898
2899 if include_netrc:
2900 return self._all_hosts
2901 return [(h, u, s) for h, u, s in self._all_hosts if s != '.netrc']
2902
2903 def print_current_creds(self, include_netrc=False):
2904 hosts = sorted(self.get_hosts_with_creds(include_netrc=include_netrc))
2905 if not hosts:
2906 print('No Git/Gerrit credentials found')
2907 return
Edward Lemur79d4f992019-11-11 23:49:02 +00002908 lengths = [max(map(len, (row[i] for row in hosts))) for i in range(3)]
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002909 header = [('Host', 'User', 'Which file'),
2910 ['=' * l for l in lengths]]
2911 for row in (header + hosts):
2912 print('\t'.join((('%%+%ds' % l) % s)
2913 for l, s in zip(lengths, row)))
2914
Andrii Shyshkalov97800502017-03-16 16:04:32 +01002915 @staticmethod
2916 def _parse_identity(identity):
Lei Zhangd3f769a2017-12-15 15:16:14 -08002917 """Parses identity "git-<username>.domain" into <username> and domain."""
2918 # Special case: usernames that contain ".", which are generally not
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +02002919 # distinguishable from sub-domains. But we do know typical domains:
2920 if identity.endswith('.chromium.org'):
2921 domain = 'chromium.org'
2922 username = identity[:-len('.chromium.org')]
2923 else:
2924 username, domain = identity.split('.', 1)
Andrii Shyshkalov97800502017-03-16 16:04:32 +01002925 if username.startswith('git-'):
2926 username = username[len('git-'):]
2927 return username, domain
2928
Andrii Shyshkalov97800502017-03-16 16:04:32 +01002929 def _canonical_git_googlesource_host(self, host):
2930 """Normalizes Gerrit hosts (with '-review') to Git host."""
2931 assert host.endswith(self._GOOGLESOURCE)
2932 # Prefix doesn't include '.' at the end.
2933 prefix = host[:-(1 + len(self._GOOGLESOURCE))]
2934 if prefix.endswith('-review'):
2935 prefix = prefix[:-len('-review')]
2936 return prefix + '.' + self._GOOGLESOURCE
2937
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01002938 def _canonical_gerrit_googlesource_host(self, host):
2939 git_host = self._canonical_git_googlesource_host(host)
2940 prefix = git_host.split('.', 1)[0]
2941 return prefix + '-review.' + self._GOOGLESOURCE
2942
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02002943 def _get_counterpart_host(self, host):
2944 assert host.endswith(self._GOOGLESOURCE)
2945 git = self._canonical_git_googlesource_host(host)
2946 gerrit = self._canonical_gerrit_googlesource_host(git)
2947 return git if gerrit == host else gerrit
2948
Andrii Shyshkalov97800502017-03-16 16:04:32 +01002949 def has_generic_host(self):
2950 """Returns whether generic .googlesource.com has been configured.
2951
2952 Chrome Infra recommends to use explicit ${host}.googlesource.com instead.
2953 """
2954 for host, _, _ in self.get_hosts_with_creds(include_netrc=False):
2955 if host == '.' + self._GOOGLESOURCE:
2956 return True
2957 return False
2958
2959 def _get_git_gerrit_identity_pairs(self):
2960 """Returns map from canonic host to pair of identities (Git, Gerrit).
2961
2962 One of identities might be None, meaning not configured.
2963 """
2964 host_to_identity_pairs = {}
2965 for host, identity, _ in self.get_hosts_with_creds():
2966 canonical = self._canonical_git_googlesource_host(host)
2967 pair = host_to_identity_pairs.setdefault(canonical, [None, None])
2968 idx = 0 if canonical == host else 1
2969 pair[idx] = identity
2970 return host_to_identity_pairs
2971
2972 def get_partially_configured_hosts(self):
2973 return set(
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02002974 (host if i1 else self._canonical_gerrit_googlesource_host(host))
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00002975 for host, (i1, i2) in self._get_git_gerrit_identity_pairs().items()
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02002976 if None in (i1, i2) and host != '.' + self._GOOGLESOURCE)
Andrii Shyshkalov97800502017-03-16 16:04:32 +01002977
2978 def get_conflicting_hosts(self):
2979 return set(
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02002980 host
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00002981 for host, (i1, i2) in self._get_git_gerrit_identity_pairs().items()
Andrii Shyshkalov97800502017-03-16 16:04:32 +01002982 if None not in (i1, i2) and i1 != i2)
2983
2984 def get_duplicated_hosts(self):
2985 counters = collections.Counter(h for h, _, _ in self.get_hosts_with_creds())
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00002986 return set(host for host, count in counters.items() if count > 1)
Andrii Shyshkalov97800502017-03-16 16:04:32 +01002987
2988 _EXPECTED_HOST_IDENTITY_DOMAINS = {
2989 'chromium.googlesource.com': 'chromium.org',
2990 'chrome-internal.googlesource.com': 'google.com',
2991 }
2992
2993 def get_hosts_with_wrong_identities(self):
2994 """Finds hosts which **likely** reference wrong identities.
2995
2996 Note: skips hosts which have conflicting identities for Git and Gerrit.
2997 """
2998 hosts = set()
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00002999 for host, expected in self._EXPECTED_HOST_IDENTITY_DOMAINS.items():
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003000 pair = self._get_git_gerrit_identity_pairs().get(host)
3001 if pair and pair[0] == pair[1]:
3002 _, domain = self._parse_identity(pair[0])
3003 if domain != expected:
3004 hosts.add(host)
3005 return hosts
3006
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003007 @staticmethod
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003008 def _format_hosts(hosts, extra_column_func=None):
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003009 hosts = sorted(hosts)
3010 assert hosts
3011 if extra_column_func is None:
3012 extras = [''] * len(hosts)
3013 else:
3014 extras = [extra_column_func(host) for host in hosts]
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003015 tmpl = '%%-%ds %%-%ds' % (max(map(len, hosts)), max(map(len, extras)))
3016 lines = []
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003017 for he in zip(hosts, extras):
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003018 lines.append(tmpl % he)
3019 return lines
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003020
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003021 def _find_problems(self):
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003022 if self.has_generic_host():
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003023 yield ('.googlesource.com wildcard record detected',
3024 ['Chrome Infrastructure team recommends to list full host names '
3025 'explicitly.'],
3026 None)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003027
3028 dups = self.get_duplicated_hosts()
3029 if dups:
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003030 yield ('The following hosts were defined twice',
3031 self._format_hosts(dups),
3032 None)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003033
3034 partial = self.get_partially_configured_hosts()
3035 if partial:
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003036 yield ('Credentials should come in pairs for Git and Gerrit hosts. '
3037 'These hosts are missing',
3038 self._format_hosts(partial, lambda host: 'but %s defined' %
3039 self._get_counterpart_host(host)),
3040 partial)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003041
3042 conflicting = self.get_conflicting_hosts()
3043 if conflicting:
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003044 yield ('The following Git hosts have differing credentials from their '
3045 'Gerrit counterparts',
3046 self._format_hosts(conflicting, lambda host: '%s vs %s' %
3047 tuple(self._get_git_gerrit_identity_pairs()[host])),
3048 conflicting)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003049
3050 wrong = self.get_hosts_with_wrong_identities()
3051 if wrong:
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003052 yield ('These hosts likely use wrong identity',
3053 self._format_hosts(wrong, lambda host: '%s but %s recommended' %
3054 (self._get_git_gerrit_identity_pairs()[host][0],
3055 self._EXPECTED_HOST_IDENTITY_DOMAINS[host])),
3056 wrong)
3057
3058 def find_and_report_problems(self):
3059 """Returns True if there was at least one problem, else False."""
3060 found = False
3061 bad_hosts = set()
3062 for title, sublines, hosts in self._find_problems():
3063 if not found:
3064 found = True
3065 print('\n\n.gitcookies problem report:\n')
3066 bad_hosts.update(hosts or [])
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003067 print(' %s%s' % (title, (':' if sublines else '')))
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003068 if sublines:
3069 print()
3070 print(' %s' % '\n '.join(sublines))
3071 print()
3072
3073 if bad_hosts:
3074 assert found
3075 print(' You can manually remove corresponding lines in your %s file and '
3076 'visit the following URLs with correct account to generate '
3077 'correct credential lines:\n' %
3078 gerrit_util.CookiesAuthenticator.get_gitcookies_path())
3079 print(' %s' % '\n '.join(sorted(set(
3080 gerrit_util.CookiesAuthenticator().get_new_password_url(
3081 self._canonical_git_googlesource_host(host))
3082 for host in bad_hosts
3083 ))))
3084 return found
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003085
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003086
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003087@metrics.collector.collect_metrics('git cl creds-check')
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003088def CMDcreds_check(parser, args):
3089 """Checks credentials and suggests changes."""
3090 _, _ = parser.parse_args(args)
3091
Vadim Shtayurab250ec12018-10-04 00:21:08 +00003092 # Code below checks .gitcookies. Abort if using something else.
3093 authn = gerrit_util.Authenticator.get()
3094 if not isinstance(authn, gerrit_util.CookiesAuthenticator):
Edward Lemur57d47422020-03-06 20:43:07 +00003095 message = (
Vadim Shtayurab250ec12018-10-04 00:21:08 +00003096 'This command is not designed for bot environment. It checks '
3097 '~/.gitcookies file not generally used on bots.')
Edward Lemur57d47422020-03-06 20:43:07 +00003098 # TODO(crbug.com/1059384): Automatically detect when running on cloudtop.
3099 if isinstance(authn, gerrit_util.GceAuthenticator):
3100 message += (
3101 '\n'
3102 'If you need to run this on GCE or a cloudtop instance, '
3103 'export SKIP_GCE_AUTH_FOR_GIT=1 in your env.')
3104 DieWithError(message)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003105
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003106 checker = _GitCookiesChecker()
3107 checker.ensure_configured_gitcookies()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003108
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003109 print('Your .netrc and .gitcookies have credentials for these hosts:')
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003110 checker.print_current_creds(include_netrc=True)
3111
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003112 if not checker.find_and_report_problems():
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003113 print('\nNo problems detected in your .gitcookies file.')
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003114 return 0
3115 return 1
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003116
3117
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003118@metrics.collector.collect_metrics('git cl baseurl')
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00003119def CMDbaseurl(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003120 """Gets or sets base-url for this branch."""
Edward Lesmese3a49aa2020-03-24 23:46:28 +00003121 branchref = scm.GIT.GetBranchRef(settings.GetRoot())
Edward Lemur85153282020-02-14 22:06:29 +00003122 branch = scm.GIT.ShortBranchName(branchref)
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00003123 _, args = parser.parse_args(args)
3124 if not args:
vapiera7fbd5a2016-06-16 09:17:49 -07003125 print('Current base-url:')
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00003126 return RunGit(['config', 'branch.%s.base-url' % branch],
3127 error_ok=False).strip()
3128 else:
vapiera7fbd5a2016-06-16 09:17:49 -07003129 print('Setting base-url to %s' % args[0])
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00003130 return RunGit(['config', 'branch.%s.base-url' % branch, args[0]],
3131 error_ok=False).strip()
3132
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003133
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00003134def color_for_status(status):
3135 """Maps a Changelist status to color, for CMDstatus and other tools."""
3136 return {
Aaron Gable9ab38c62017-04-06 14:36:33 -07003137 'unsent': Fore.YELLOW,
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00003138 'waiting': Fore.BLUE,
3139 'reply': Fore.YELLOW,
Aaron Gable9ab38c62017-04-06 14:36:33 -07003140 'not lgtm': Fore.RED,
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00003141 'lgtm': Fore.GREEN,
3142 'commit': Fore.MAGENTA,
3143 'closed': Fore.CYAN,
3144 'error': Fore.WHITE,
3145 }.get(status, Fore.WHITE)
3146
tandrii@chromium.org04ea8462016-04-25 19:51:21 +00003147
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003148def get_cl_statuses(changes, fine_grained, max_processes=None):
3149 """Returns a blocking iterable of (cl, status) for given branches.
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003150
3151 If fine_grained is true, this will fetch CL statuses from the server.
3152 Otherwise, simply indicate if there's a matching url for the given branches.
3153
3154 If max_processes is specified, it is used as the maximum number of processes
3155 to spawn to fetch CL status from the server. Otherwise 1 process per branch is
3156 spawned.
calamity@chromium.orgcf197482016-04-29 20:15:53 +00003157
3158 See GetStatus() for a list of possible statuses.
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003159 """
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003160 if not changes:
Edward Lemur61bf4172020-02-24 23:22:37 +00003161 return
calamity@chromium.orgcf197482016-04-29 20:15:53 +00003162
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003163 if not fine_grained:
3164 # Fast path which doesn't involve querying codereview servers.
Aaron Gablea1bab272017-04-11 16:38:18 -07003165 # Do not use get_approving_reviewers(), since it requires an HTTP request.
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003166 for cl in changes:
3167 yield (cl, 'waiting' if cl.GetIssueURL() else 'error')
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003168 return
3169
3170 # First, sort out authentication issues.
3171 logging.debug('ensuring credentials exist')
3172 for cl in changes:
3173 cl.EnsureAuthenticated(force=False, refresh=True)
3174
3175 def fetch(cl):
3176 try:
3177 return (cl, cl.GetStatus())
3178 except:
3179 # See http://crbug.com/629863.
Andrii Shyshkalov98824232018-04-19 11:37:15 -07003180 logging.exception('failed to fetch status for cl %s:', cl.GetIssue())
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003181 raise
3182
3183 threads_count = len(changes)
3184 if max_processes:
3185 threads_count = max(1, min(threads_count, max_processes))
3186 logging.debug('querying %d CLs using %d threads', len(changes), threads_count)
3187
Edward Lemur61bf4172020-02-24 23:22:37 +00003188 pool = multiprocessing.pool.ThreadPool(threads_count)
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003189 fetched_cls = set()
3190 try:
3191 it = pool.imap_unordered(fetch, changes).__iter__()
3192 while True:
3193 try:
3194 cl, status = it.next(timeout=5)
Edward Lemur61bf4172020-02-24 23:22:37 +00003195 except (multiprocessing.TimeoutError, StopIteration):
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003196 break
3197 fetched_cls.add(cl)
3198 yield cl, status
3199 finally:
3200 pool.close()
3201
3202 # Add any branches that failed to fetch.
3203 for cl in set(changes) - fetched_cls:
3204 yield (cl, 'error')
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00003205
rmistry@google.com2dd99862015-06-22 12:22:18 +00003206
3207def upload_branch_deps(cl, args):
3208 """Uploads CLs of local branches that are dependents of the current branch.
3209
3210 If the local branch dependency tree looks like:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003211
3212 test1 -> test2.1 -> test3.1
3213 -> test3.2
3214 -> test2.2 -> test3.3
rmistry@google.com2dd99862015-06-22 12:22:18 +00003215
3216 and you run "git cl upload --dependencies" from test1 then "git cl upload" is
3217 run on the dependent branches in this order:
3218 test2.1, test3.1, test3.2, test2.2, test3.3
3219
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003220 Note: This function does not rebase your local dependent branches. Use it
3221 when you make a change to the parent branch that will not conflict
3222 with its dependent branches, and you would like their dependencies
3223 updated in Rietveld.
rmistry@google.com2dd99862015-06-22 12:22:18 +00003224 """
3225 if git_common.is_dirty_git_tree('upload-branch-deps'):
3226 return 1
3227
3228 root_branch = cl.GetBranch()
3229 if root_branch is None:
3230 DieWithError('Can\'t find dependent branches from detached HEAD state. '
3231 'Get on a branch!')
Andrii Shyshkalov9f274432018-10-15 16:40:23 +00003232 if not cl.GetIssue():
rmistry@google.com2dd99862015-06-22 12:22:18 +00003233 DieWithError('Current branch does not have an uploaded CL. We cannot set '
3234 'patchset dependencies without an uploaded CL.')
3235
3236 branches = RunGit(['for-each-ref',
3237 '--format=%(refname:short) %(upstream:short)',
3238 'refs/heads'])
3239 if not branches:
3240 print('No local branches found.')
3241 return 0
3242
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003243 # Create a dictionary of all local branches to the branches that are
3244 # dependent on it.
rmistry@google.com2dd99862015-06-22 12:22:18 +00003245 tracked_to_dependents = collections.defaultdict(list)
3246 for b in branches.splitlines():
3247 tokens = b.split()
3248 if len(tokens) == 2:
3249 branch_name, tracked = tokens
3250 tracked_to_dependents[tracked].append(branch_name)
3251
vapiera7fbd5a2016-06-16 09:17:49 -07003252 print()
3253 print('The dependent local branches of %s are:' % root_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00003254 dependents = []
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003255
rmistry@google.com2dd99862015-06-22 12:22:18 +00003256 def traverse_dependents_preorder(branch, padding=''):
3257 dependents_to_process = tracked_to_dependents.get(branch, [])
3258 padding += ' '
3259 for dependent in dependents_to_process:
vapiera7fbd5a2016-06-16 09:17:49 -07003260 print('%s%s' % (padding, dependent))
rmistry@google.com2dd99862015-06-22 12:22:18 +00003261 dependents.append(dependent)
3262 traverse_dependents_preorder(dependent, padding)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003263
rmistry@google.com2dd99862015-06-22 12:22:18 +00003264 traverse_dependents_preorder(root_branch)
vapiera7fbd5a2016-06-16 09:17:49 -07003265 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00003266
3267 if not dependents:
vapiera7fbd5a2016-06-16 09:17:49 -07003268 print('There are no dependent local branches for %s' % root_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00003269 return 0
3270
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01003271 confirm_or_exit('This command will checkout all dependent branches and run '
3272 '"git cl upload".', action='continue')
rmistry@google.com2dd99862015-06-22 12:22:18 +00003273
rmistry@google.com2dd99862015-06-22 12:22:18 +00003274 # Record all dependents that failed to upload.
3275 failures = {}
3276 # Go through all dependents, checkout the branch and upload.
3277 try:
3278 for dependent_branch in dependents:
vapiera7fbd5a2016-06-16 09:17:49 -07003279 print()
3280 print('--------------------------------------')
3281 print('Running "git cl upload" from %s:' % dependent_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00003282 RunGit(['checkout', '-q', dependent_branch])
vapiera7fbd5a2016-06-16 09:17:49 -07003283 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00003284 try:
3285 if CMDupload(OptionParser(), args) != 0:
vapiera7fbd5a2016-06-16 09:17:49 -07003286 print('Upload failed for %s!' % dependent_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00003287 failures[dependent_branch] = 1
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08003288 except: # pylint: disable=bare-except
rmistry@google.com2dd99862015-06-22 12:22:18 +00003289 failures[dependent_branch] = 1
vapiera7fbd5a2016-06-16 09:17:49 -07003290 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00003291 finally:
3292 # Swap back to the original root branch.
3293 RunGit(['checkout', '-q', root_branch])
3294
vapiera7fbd5a2016-06-16 09:17:49 -07003295 print()
3296 print('Upload complete for dependent branches!')
rmistry@google.com2dd99862015-06-22 12:22:18 +00003297 for dependent_branch in dependents:
3298 upload_status = 'failed' if failures.get(dependent_branch) else 'succeeded'
vapiera7fbd5a2016-06-16 09:17:49 -07003299 print(' %s : %s' % (dependent_branch, upload_status))
3300 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00003301
3302 return 0
3303
3304
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00003305def GetArchiveTagForBranch(issue_num, branch_name, existing_tags):
3306 """Given a proposed tag name, returns a tag name that is guaranteed to be
3307 unique. If 'foo' is proposed but already exists, then 'foo-2' is used,
3308 or 'foo-3', and so on."""
3309
3310 proposed_tag = 'git-cl-archived-%s-%s' % (issue_num, branch_name)
3311 for suffix_num in itertools.count(1):
3312 if suffix_num == 1:
3313 to_check = proposed_tag
3314 else:
3315 to_check = '%s-%d' % (proposed_tag, suffix_num)
3316
3317 if to_check not in existing_tags:
3318 return to_check
3319
3320
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003321@metrics.collector.collect_metrics('git cl archive')
kmarshall3bff56b2016-06-06 18:31:47 -07003322def CMDarchive(parser, args):
3323 """Archives and deletes branches associated with closed changelists."""
3324 parser.add_option(
3325 '-j', '--maxjobs', action='store', type=int,
kmarshall9249e012016-08-23 12:02:16 -07003326 help='The maximum number of jobs to use when retrieving review status.')
kmarshall3bff56b2016-06-06 18:31:47 -07003327 parser.add_option(
3328 '-f', '--force', action='store_true',
3329 help='Bypasses the confirmation prompt.')
kmarshall9249e012016-08-23 12:02:16 -07003330 parser.add_option(
3331 '-d', '--dry-run', action='store_true',
3332 help='Skip the branch tagging and removal steps.')
3333 parser.add_option(
3334 '-t', '--notags', action='store_true',
3335 help='Do not tag archived branches. '
3336 'Note: local commit history may be lost.')
kmarshall3bff56b2016-06-06 18:31:47 -07003337
kmarshall3bff56b2016-06-06 18:31:47 -07003338 options, args = parser.parse_args(args)
3339 if args:
3340 parser.error('Unsupported args: %s' % ' '.join(args))
kmarshall3bff56b2016-06-06 18:31:47 -07003341
3342 branches = RunGit(['for-each-ref', '--format=%(refname)', 'refs/heads'])
3343 if not branches:
3344 return 0
3345
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00003346 tags = RunGit(['for-each-ref', '--format=%(refname)',
3347 'refs/tags']).splitlines() or []
3348 tags = [t.split('/')[-1] for t in tags]
3349
vapiera7fbd5a2016-06-16 09:17:49 -07003350 print('Finding all branches associated with closed issues...')
Edward Lemur934836a2019-09-09 20:16:54 +00003351 changes = [Changelist(branchref=b)
3352 for b in branches.splitlines()]
kmarshall3bff56b2016-06-06 18:31:47 -07003353 alignment = max(5, max(len(c.GetBranch()) for c in changes))
3354 statuses = get_cl_statuses(changes,
3355 fine_grained=True,
3356 max_processes=options.maxjobs)
3357 proposal = [(cl.GetBranch(),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00003358 GetArchiveTagForBranch(cl.GetIssue(), cl.GetBranch(),
3359 tags))
kmarshall3bff56b2016-06-06 18:31:47 -07003360 for cl, status in statuses
Andrii Shyshkalov51bdf8c2018-10-18 01:07:58 +00003361 if status in ('closed', 'rietveld-not-supported')]
kmarshall3bff56b2016-06-06 18:31:47 -07003362 proposal.sort()
3363
3364 if not proposal:
vapiera7fbd5a2016-06-16 09:17:49 -07003365 print('No branches with closed codereview issues found.')
kmarshall3bff56b2016-06-06 18:31:47 -07003366 return 0
3367
Edward Lemur85153282020-02-14 22:06:29 +00003368 current_branch = scm.GIT.GetBranch(settings.GetRoot())
kmarshall3bff56b2016-06-06 18:31:47 -07003369
vapiera7fbd5a2016-06-16 09:17:49 -07003370 print('\nBranches with closed issues that will be archived:\n')
kmarshall9249e012016-08-23 12:02:16 -07003371 if options.notags:
3372 for next_item in proposal:
3373 print(' ' + next_item[0])
3374 else:
3375 print('%*s | %s' % (alignment, 'Branch name', 'Archival tag name'))
3376 for next_item in proposal:
3377 print('%*s %s' % (alignment, next_item[0], next_item[1]))
kmarshall3bff56b2016-06-06 18:31:47 -07003378
kmarshall9249e012016-08-23 12:02:16 -07003379 # Quit now on precondition failure or if instructed by the user, either
3380 # via an interactive prompt or by command line flags.
3381 if options.dry_run:
3382 print('\nNo changes were made (dry run).\n')
3383 return 0
3384 elif any(branch == current_branch for branch, _ in proposal):
kmarshall3bff56b2016-06-06 18:31:47 -07003385 print('You are currently on a branch \'%s\' which is associated with a '
3386 'closed codereview issue, so archive cannot proceed. Please '
3387 'checkout another branch and run this command again.' %
3388 current_branch)
3389 return 1
kmarshall9249e012016-08-23 12:02:16 -07003390 elif not options.force:
Edward Lesmesae3586b2020-03-23 21:21:14 +00003391 answer = gclient_utils.AskForData('\nProceed with deletion (Y/n)? ').lower()
sergiyb4a5ecbe2016-06-20 09:46:00 -07003392 if answer not in ('y', ''):
vapiera7fbd5a2016-06-16 09:17:49 -07003393 print('Aborted.')
kmarshall3bff56b2016-06-06 18:31:47 -07003394 return 1
3395
3396 for branch, tagname in proposal:
kmarshall9249e012016-08-23 12:02:16 -07003397 if not options.notags:
3398 RunGit(['tag', tagname, branch])
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00003399
3400 if RunGitWithCode(['branch', '-D', branch])[0] != 0:
3401 # Clean up the tag if we failed to delete the branch.
3402 RunGit(['tag', '-d', tagname])
kmarshall9249e012016-08-23 12:02:16 -07003403
vapiera7fbd5a2016-06-16 09:17:49 -07003404 print('\nJob\'s done!')
kmarshall3bff56b2016-06-06 18:31:47 -07003405
3406 return 0
3407
3408
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003409@metrics.collector.collect_metrics('git cl status')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003410def CMDstatus(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003411 """Show status of changelists.
3412
3413 Colors are used to tell the state of the CL unless --fast is used:
jsbell@chromium.orgaeab41a2013-12-10 20:01:22 +00003414 - Blue waiting for review
Aaron Gable9ab38c62017-04-06 14:36:33 -07003415 - Yellow waiting for you to reply to review, or not yet sent
jsbell@chromium.orgaeab41a2013-12-10 20:01:22 +00003416 - Green LGTM'ed
Aaron Gable9ab38c62017-04-06 14:36:33 -07003417 - Red 'not LGTM'ed
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00003418 - Magenta in the CQ
jsbell@chromium.orgaeab41a2013-12-10 20:01:22 +00003419 - Cyan was committed, branch can be deleted
Aaron Gable9ab38c62017-04-06 14:36:33 -07003420 - White error, or unknown status
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003421
3422 Also see 'git cl comments'.
3423 """
Alan Cuttera3be9a52019-03-04 18:50:33 +00003424 parser.add_option(
3425 '--no-branch-color',
3426 action='store_true',
3427 help='Disable colorized branch names')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003428 parser.add_option('--field',
phajdan.jr289d03e2016-08-16 08:21:06 -07003429 help='print only specific field (desc|id|patch|status|url)')
maruel@chromium.org1033efd2013-07-23 23:25:09 +00003430 parser.add_option('-f', '--fast', action='store_true',
3431 help='Do not retrieve review status')
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003432 parser.add_option(
3433 '-j', '--maxjobs', action='store', type=int,
3434 help='The maximum number of jobs to use when retrieving review status')
Edward Lemur52969c92020-02-06 18:15:28 +00003435 parser.add_option(
3436 '-i', '--issue', type=int,
3437 help='Operate on this issue instead of the current branch\'s implicit '
3438 'issue. Requires --field to be set.')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00003439 options, args = parser.parse_args(args)
maruel@chromium.org39c0b222013-08-17 16:57:01 +00003440 if args:
3441 parser.error('Unsupported args: %s' % args)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003442
iannuccie53c9352016-08-17 14:40:40 -07003443 if options.issue is not None and not options.field:
Edward Lemur6c6827c2020-02-06 21:15:18 +00003444 parser.error('--field must be given when --issue is set.')
iannucci3c972b92016-08-17 13:24:10 -07003445
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003446 if options.field:
Edward Lemur934836a2019-09-09 20:16:54 +00003447 cl = Changelist(issue=options.issue)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003448 if options.field.startswith('desc'):
Edward Lemur6c6827c2020-02-06 21:15:18 +00003449 if cl.GetIssue():
3450 print(cl.FetchDescription())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003451 elif options.field == 'id':
3452 issueid = cl.GetIssue()
3453 if issueid:
vapiera7fbd5a2016-06-16 09:17:49 -07003454 print(issueid)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003455 elif options.field == 'patch':
Aaron Gablee8856ee2017-12-07 12:41:46 -08003456 patchset = cl.GetMostRecentPatchset()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003457 if patchset:
vapiera7fbd5a2016-06-16 09:17:49 -07003458 print(patchset)
phajdan.jr289d03e2016-08-16 08:21:06 -07003459 elif options.field == 'status':
3460 print(cl.GetStatus())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003461 elif options.field == 'url':
3462 url = cl.GetIssueURL()
3463 if url:
vapiera7fbd5a2016-06-16 09:17:49 -07003464 print(url)
maruel@chromium.orge25c75b2013-07-23 18:30:56 +00003465 return 0
3466
3467 branches = RunGit(['for-each-ref', '--format=%(refname)', 'refs/heads'])
3468 if not branches:
3469 print('No local branch found.')
3470 return 0
3471
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003472 changes = [
Edward Lemur934836a2019-09-09 20:16:54 +00003473 Changelist(branchref=b)
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003474 for b in branches.splitlines()]
vapiera7fbd5a2016-06-16 09:17:49 -07003475 print('Branches associated with reviews:')
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003476 output = get_cl_statuses(changes,
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003477 fine_grained=not options.fast,
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003478 max_processes=options.maxjobs)
maruel@chromium.org1033efd2013-07-23 23:25:09 +00003479
Edward Lemur85153282020-02-14 22:06:29 +00003480 current_branch = scm.GIT.GetBranch(settings.GetRoot())
Daniel McArdlea23bf592019-02-12 00:25:12 +00003481
3482 def FormatBranchName(branch, colorize=False):
3483 """Simulates 'git branch' behavior. Colorizes and prefixes branch name with
3484 an asterisk when it is the current branch."""
3485
3486 asterisk = ""
3487 color = Fore.RESET
3488 if branch == current_branch:
3489 asterisk = "* "
3490 color = Fore.GREEN
Edward Lemur85153282020-02-14 22:06:29 +00003491 branch_name = scm.GIT.ShortBranchName(branch)
Daniel McArdlea23bf592019-02-12 00:25:12 +00003492
3493 if colorize:
3494 return asterisk + color + branch_name + Fore.RESET
Daniel McArdle452a49f2019-02-14 17:28:31 +00003495 return asterisk + branch_name
3496
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003497 branch_statuses = {}
Daniel McArdlea23bf592019-02-12 00:25:12 +00003498
3499 alignment = max(5, max(len(FormatBranchName(c.GetBranch())) for c in changes))
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003500 for cl in sorted(changes, key=lambda c: c.GetBranch()):
3501 branch = cl.GetBranch()
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003502 while branch not in branch_statuses:
Edward Lemur79d4f992019-11-11 23:49:02 +00003503 c, status = next(output)
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003504 branch_statuses[c.GetBranch()] = status
3505 status = branch_statuses.pop(branch)
Andrii Shyshkalov1ee78cd2020-03-12 01:31:53 +00003506 url = cl.GetIssueURL(short=True)
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003507 if url and (not status or status == 'error'):
3508 # The issue probably doesn't exist anymore.
3509 url += ' (broken)'
3510
nodir@chromium.orga6de1f42015-06-10 04:23:17 +00003511 color = color_for_status(status)
maruel@chromium.org885f6512013-07-27 02:17:26 +00003512 reset = Fore.RESET
iannucci@chromium.org596cd5c2016-04-04 21:34:39 +00003513 if not setup_color.IS_TTY:
maruel@chromium.org885f6512013-07-27 02:17:26 +00003514 color = ''
3515 reset = ''
nodir@chromium.orga6de1f42015-06-10 04:23:17 +00003516 status_str = '(%s)' % status if status else ''
Daniel McArdle452a49f2019-02-14 17:28:31 +00003517
Alan Cuttera3be9a52019-03-04 18:50:33 +00003518 branch_display = FormatBranchName(branch)
3519 padding = ' ' * (alignment - len(branch_display))
3520 if not options.no_branch_color:
3521 branch_display = FormatBranchName(branch, colorize=True)
Daniel McArdle452a49f2019-02-14 17:28:31 +00003522
Alan Cuttera3be9a52019-03-04 18:50:33 +00003523 print(' %s : %s%s %s%s' % (padding + branch_display, color, url,
3524 status_str, reset))
Andrii Shyshkalovd0e1d9d2017-01-24 17:10:51 +01003525
vapiera7fbd5a2016-06-16 09:17:49 -07003526 print()
Daniel McArdlea23bf592019-02-12 00:25:12 +00003527 print('Current branch: %s' % current_branch)
Andrii Shyshkalovd0e1d9d2017-01-24 17:10:51 +01003528 for cl in changes:
Daniel McArdlea23bf592019-02-12 00:25:12 +00003529 if cl.GetBranch() == current_branch:
Andrii Shyshkalovd0e1d9d2017-01-24 17:10:51 +01003530 break
dpranke@chromium.orgee87f582015-07-31 18:46:25 +00003531 if not cl.GetIssue():
vapiera7fbd5a2016-06-16 09:17:49 -07003532 print('No issue assigned.')
dpranke@chromium.orgee87f582015-07-31 18:46:25 +00003533 return 0
vapiera7fbd5a2016-06-16 09:17:49 -07003534 print('Issue number: %s (%s)' % (cl.GetIssue(), cl.GetIssueURL()))
maruel@chromium.org85616e02014-07-28 15:37:55 +00003535 if not options.fast:
vapiera7fbd5a2016-06-16 09:17:49 -07003536 print('Issue description:')
Edward Lemur6c6827c2020-02-06 21:15:18 +00003537 print(cl.FetchDescription(pretty=True))
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003538 return 0
3539
3540
maruel@chromium.org39c0b222013-08-17 16:57:01 +00003541def colorize_CMDstatus_doc():
3542 """To be called once in main() to add colors to git cl status help."""
3543 colors = [i for i in dir(Fore) if i[0].isupper()]
3544
3545 def colorize_line(line):
3546 for color in colors:
3547 if color in line.upper():
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003548 # Extract whitespace first and the leading '-'.
maruel@chromium.org39c0b222013-08-17 16:57:01 +00003549 indent = len(line) - len(line.lstrip(' ')) + 1
3550 return line[:indent] + getattr(Fore, color) + line[indent:] + Fore.RESET
3551 return line
3552
3553 lines = CMDstatus.__doc__.splitlines()
3554 CMDstatus.__doc__ = '\n'.join(colorize_line(l) for l in lines)
3555
3556
phajdan.jre328cf92016-08-22 04:12:17 -07003557def write_json(path, contents):
Stefan Zager1306bd02017-06-22 19:26:46 -07003558 if path == '-':
3559 json.dump(contents, sys.stdout)
3560 else:
3561 with open(path, 'w') as f:
3562 json.dump(contents, f)
phajdan.jre328cf92016-08-22 04:12:17 -07003563
3564
maruel@chromium.org0633fb42013-08-16 20:06:14 +00003565@subcommand.usage('[issue_number]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003566@metrics.collector.collect_metrics('git cl issue')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003567def CMDissue(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003568 """Sets or displays the current code review issue number.
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003569
3570 Pass issue number 0 to clear the current issue.
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003571 """
dnj@chromium.org406c4402015-03-03 17:22:28 +00003572 parser.add_option('-r', '--reverse', action='store_true',
3573 help='Lookup the branch(es) for the specified issues. If '
3574 'no issues are specified, all branches with mapped '
3575 'issues will be listed.')
Stefan Zager1306bd02017-06-22 19:26:46 -07003576 parser.add_option('--json',
3577 help='Path to JSON output file, or "-" for stdout.')
dnj@chromium.org406c4402015-03-03 17:22:28 +00003578 options, args = parser.parse_args(args)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003579
dnj@chromium.org406c4402015-03-03 17:22:28 +00003580 if options.reverse:
3581 branches = RunGit(['for-each-ref', 'refs/heads',
Aaron Gablead64abd2017-12-04 09:49:13 -08003582 '--format=%(refname)']).splitlines()
dnj@chromium.org406c4402015-03-03 17:22:28 +00003583 # Reverse issue lookup.
3584 issue_branch_map = {}
Daniel Bratellb56a43a2018-09-06 15:49:03 +00003585
3586 git_config = {}
3587 for config in RunGit(['config', '--get-regexp',
3588 r'branch\..*issue']).splitlines():
3589 name, _space, val = config.partition(' ')
3590 git_config[name] = val
3591
dnj@chromium.org406c4402015-03-03 17:22:28 +00003592 for branch in branches:
Edward Lesmese3a49aa2020-03-24 23:46:28 +00003593 issue = git_config.get(
3594 'branch.%s.%s' % (scm.GIT.ShortBranchName(branch), ISSUE_CONFIG_KEY))
Edward Lemur52969c92020-02-06 18:15:28 +00003595 if issue:
3596 issue_branch_map.setdefault(int(issue), []).append(branch)
dnj@chromium.org406c4402015-03-03 17:22:28 +00003597 if not args:
3598 args = sorted(issue_branch_map.iterkeys())
phajdan.jre328cf92016-08-22 04:12:17 -07003599 result = {}
dnj@chromium.org406c4402015-03-03 17:22:28 +00003600 for issue in args:
Lei Zhang5a368d42019-03-25 23:18:19 +00003601 try:
3602 issue_num = int(issue)
3603 except ValueError:
3604 print('ERROR cannot parse issue number: %s' % issue, file=sys.stderr)
dnj@chromium.org406c4402015-03-03 17:22:28 +00003605 continue
Lei Zhang5a368d42019-03-25 23:18:19 +00003606 result[issue_num] = issue_branch_map.get(issue_num)
vapiera7fbd5a2016-06-16 09:17:49 -07003607 print('Branch for issue number %s: %s' % (
Lei Zhang5a368d42019-03-25 23:18:19 +00003608 issue, ', '.join(issue_branch_map.get(issue_num) or ('None',))))
phajdan.jre328cf92016-08-22 04:12:17 -07003609 if options.json:
3610 write_json(options.json, result)
Aaron Gable78753da2017-06-15 10:35:49 -07003611 return 0
3612
3613 if len(args) > 0:
Edward Lemurf38bc172019-09-03 21:02:13 +00003614 issue = ParseIssueNumberArgument(args[0])
Aaron Gable78753da2017-06-15 10:35:49 -07003615 if not issue.valid:
3616 DieWithError('Pass a url or number to set the issue, 0 to unset it, '
3617 'or no argument to list it.\n'
3618 'Maybe you want to run git cl status?')
Edward Lemurf38bc172019-09-03 21:02:13 +00003619 cl = Changelist()
Aaron Gable78753da2017-06-15 10:35:49 -07003620 cl.SetIssue(issue.issue)
dnj@chromium.org406c4402015-03-03 17:22:28 +00003621 else:
Edward Lemurf38bc172019-09-03 21:02:13 +00003622 cl = Changelist()
Aaron Gable78753da2017-06-15 10:35:49 -07003623 print('Issue number: %s (%s)' % (cl.GetIssue(), cl.GetIssueURL()))
3624 if options.json:
3625 write_json(options.json, {
3626 'issue': cl.GetIssue(),
3627 'issue_url': cl.GetIssueURL(),
3628 })
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003629 return 0
3630
3631
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003632@metrics.collector.collect_metrics('git cl comments')
maruel@chromium.org9977a2e2012-06-06 22:30:56 +00003633def CMDcomments(parser, args):
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003634 """Shows or posts review comments for any changelist."""
3635 parser.add_option('-a', '--add-comment', dest='comment',
3636 help='comment to add to an issue')
Sergiy Byelozyorovcb629a42018-10-28 19:20:39 +00003637 parser.add_option('-p', '--publish', action='store_true',
3638 help='marks CL as ready and sends comment to reviewers')
Andrii Shyshkalov0d6b46e2017-03-17 22:23:22 +01003639 parser.add_option('-i', '--issue', dest='issue',
Edward Lemurf38bc172019-09-03 21:02:13 +00003640 help='review issue id (defaults to current issue).')
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07003641 parser.add_option('-m', '--machine-readable', dest='readable',
3642 action='store_false', default=True,
3643 help='output comments in a format compatible with '
3644 'editor parsing')
smut@google.comc85ac942015-09-15 16:34:43 +00003645 parser.add_option('-j', '--json-file',
Stefan Zager1306bd02017-06-22 19:26:46 -07003646 help='File to write JSON summary to, or "-" for stdout')
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003647 options, args = parser.parse_args(args)
maruel@chromium.org9977a2e2012-06-06 22:30:56 +00003648
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003649 issue = None
3650 if options.issue:
3651 try:
3652 issue = int(options.issue)
3653 except ValueError:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00003654 DieWithError('A review issue ID is expected to be a number.')
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003655
Edward Lemur934836a2019-09-09 20:16:54 +00003656 cl = Changelist(issue=issue)
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003657
3658 if options.comment:
Sergiy Byelozyorovcb629a42018-10-28 19:20:39 +00003659 cl.AddComment(options.comment, options.publish)
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003660 return 0
3661
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07003662 summary = sorted(cl.GetCommentsSummary(readable=options.readable),
3663 key=lambda c: c.date)
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01003664 for comment in summary:
3665 if comment.disapproval:
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003666 color = Fore.RED
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01003667 elif comment.approval:
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003668 color = Fore.GREEN
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01003669 elif comment.sender == cl.GetIssueOwner():
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003670 color = Fore.MAGENTA
Quinten Yearsley0e617c02019-02-20 00:37:03 +00003671 elif comment.autogenerated:
3672 color = Fore.CYAN
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003673 else:
3674 color = Fore.BLUE
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01003675 print('\n%s%s %s%s\n%s' % (
3676 color,
3677 comment.date.strftime('%Y-%m-%d %H:%M:%S UTC'),
3678 comment.sender,
3679 Fore.RESET,
3680 '\n'.join(' ' + l for l in comment.message.strip().splitlines())))
3681
smut@google.comc85ac942015-09-15 16:34:43 +00003682 if options.json_file:
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01003683 def pre_serialize(c):
Edward Lemur79d4f992019-11-11 23:49:02 +00003684 dct = c._asdict().copy()
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01003685 dct['date'] = dct['date'].strftime('%Y-%m-%d %H:%M:%S.%f')
3686 return dct
Edward Lemur79d4f992019-11-11 23:49:02 +00003687 write_json(options.json_file, [pre_serialize(x) for x in summary])
maruel@chromium.org9977a2e2012-06-06 22:30:56 +00003688 return 0
3689
3690
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00003691@subcommand.usage('[codereview url or issue id]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003692@metrics.collector.collect_metrics('git cl description')
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00003693def CMDdescription(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003694 """Brings up the editor for the current CL's description."""
smut@google.com34fb6b12015-07-13 20:03:26 +00003695 parser.add_option('-d', '--display', action='store_true',
3696 help='Display the description instead of opening an editor')
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00003697 parser.add_option('-n', '--new-description',
dnjba1b0f32016-09-02 12:37:42 -07003698 help='New description to set for this issue (- for stdin, '
3699 '+ to load from local commit HEAD)')
dsansomee2d6fd92016-09-08 00:10:47 -07003700 parser.add_option('-f', '--force', action='store_true',
3701 help='Delete any unpublished Gerrit edits for this issue '
3702 'without prompting')
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00003703
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00003704 options, args = parser.parse_args(args)
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00003705
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01003706 target_issue_arg = None
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00003707 if len(args) > 0:
Edward Lemurf38bc172019-09-03 21:02:13 +00003708 target_issue_arg = ParseIssueNumberArgument(args[0])
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01003709 if not target_issue_arg.valid:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00003710 parser.error('Invalid issue ID or URL.')
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00003711
Edward Lemur934836a2019-09-09 20:16:54 +00003712 kwargs = {}
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01003713 if target_issue_arg:
3714 kwargs['issue'] = target_issue_arg.issue
3715 kwargs['codereview_host'] = target_issue_arg.hostname
martiniss6eda05f2016-06-30 10:18:35 -07003716
3717 cl = Changelist(**kwargs)
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00003718 if not cl.GetIssue():
3719 DieWithError('This branch has no associated changelist.')
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02003720
Edward Lemur678a6842019-10-03 22:25:05 +00003721 if args and not args[0].isdigit():
Edward Lemurf38bc172019-09-03 21:02:13 +00003722 logging.info('canonical issue/change URL: %s\n', cl.GetIssueURL())
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02003723
Edward Lemur6c6827c2020-02-06 21:15:18 +00003724 description = ChangeDescription(cl.FetchDescription())
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00003725
smut@google.com34fb6b12015-07-13 20:03:26 +00003726 if options.display:
vapiera7fbd5a2016-06-16 09:17:49 -07003727 print(description.description)
smut@google.com34fb6b12015-07-13 20:03:26 +00003728 return 0
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00003729
3730 if options.new_description:
3731 text = options.new_description
3732 if text == '-':
3733 text = '\n'.join(l.rstrip() for l in sys.stdin)
dnjba1b0f32016-09-02 12:37:42 -07003734 elif text == '+':
3735 base_branch = cl.GetCommonAncestorWithUpstream()
Edward Lemura12175c2020-03-09 16:58:26 +00003736 text = _create_description_from_log([base_branch])
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00003737
3738 description.set_description(text)
3739 else:
Edward Lemurf38bc172019-09-03 21:02:13 +00003740 description.prompt()
Edward Lemur6c6827c2020-02-06 21:15:18 +00003741 if cl.FetchDescription().strip() != description.description:
dsansomee2d6fd92016-09-08 00:10:47 -07003742 cl.UpdateDescription(description.description, force=options.force)
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00003743 return 0
3744
3745
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003746@metrics.collector.collect_metrics('git cl lint')
thestig@chromium.org44202a22014-03-11 19:22:18 +00003747def CMDlint(parser, args):
3748 """Runs cpplint on the current changelist."""
tzik@chromium.orgf204d4b2014-03-13 07:40:55 +00003749 parser.add_option('--filter', action='append', metavar='-x,+y',
3750 help='Comma-separated list of cpplint\'s category-filters')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00003751 options, args = parser.parse_args(args)
thestig@chromium.org44202a22014-03-11 19:22:18 +00003752
3753 # Access to a protected member _XX of a client class
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08003754 # pylint: disable=protected-access
thestig@chromium.org44202a22014-03-11 19:22:18 +00003755 try:
3756 import cpplint
3757 import cpplint_chromium
3758 except ImportError:
vapiera7fbd5a2016-06-16 09:17:49 -07003759 print('Your depot_tools is missing cpplint.py and/or cpplint_chromium.py.')
thestig@chromium.org44202a22014-03-11 19:22:18 +00003760 return 1
3761
3762 # Change the current working directory before calling lint so that it
3763 # shows the correct base.
3764 previous_cwd = os.getcwd()
3765 os.chdir(settings.GetRoot())
3766 try:
Edward Lemur934836a2019-09-09 20:16:54 +00003767 cl = Changelist()
Edward Lemur2c62b332020-03-12 22:12:33 +00003768 files = cl.GetAffectedFiles(cl.GetCommonAncestorWithUpstream())
thestig@chromium.org5839eb52014-05-30 16:20:51 +00003769 if not files:
vapiera7fbd5a2016-06-16 09:17:49 -07003770 print('Cannot lint an empty CL')
thestig@chromium.org5839eb52014-05-30 16:20:51 +00003771 return 1
thestig@chromium.org44202a22014-03-11 19:22:18 +00003772
3773 # Process cpplints arguments if any.
tzik@chromium.orgf204d4b2014-03-13 07:40:55 +00003774 command = args + files
3775 if options.filter:
3776 command = ['--filter=' + ','.join(options.filter)] + command
3777 filenames = cpplint.ParseArguments(command)
thestig@chromium.org44202a22014-03-11 19:22:18 +00003778
3779 white_regex = re.compile(settings.GetLintRegex())
3780 black_regex = re.compile(settings.GetLintIgnoreRegex())
3781 extra_check_functions = [cpplint_chromium.CheckPointerDeclarationWhitespace]
3782 for filename in filenames:
3783 if white_regex.match(filename):
3784 if black_regex.match(filename):
vapiera7fbd5a2016-06-16 09:17:49 -07003785 print('Ignoring file %s' % filename)
thestig@chromium.org44202a22014-03-11 19:22:18 +00003786 else:
3787 cpplint.ProcessFile(filename, cpplint._cpplint_state.verbose_level,
3788 extra_check_functions)
3789 else:
vapiera7fbd5a2016-06-16 09:17:49 -07003790 print('Skipping file %s' % filename)
thestig@chromium.org44202a22014-03-11 19:22:18 +00003791 finally:
3792 os.chdir(previous_cwd)
vapiera7fbd5a2016-06-16 09:17:49 -07003793 print('Total errors found: %d\n' % cpplint._cpplint_state.error_count)
thestig@chromium.org44202a22014-03-11 19:22:18 +00003794 if cpplint._cpplint_state.error_count != 0:
3795 return 1
3796 return 0
3797
3798
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003799@metrics.collector.collect_metrics('git cl presubmit')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003800def CMDpresubmit(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003801 """Runs presubmit tests on the current changelist."""
ilevy@chromium.org375a9022013-01-07 01:12:05 +00003802 parser.add_option('-u', '--upload', action='store_true',
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08003803 help='Run upload hook instead of the push hook')
ilevy@chromium.org375a9022013-01-07 01:12:05 +00003804 parser.add_option('-f', '--force', action='store_true',
sbc@chromium.org495ad152012-09-04 23:07:42 +00003805 help='Run checks even if tree is dirty')
Aaron Gable8076c282017-11-29 14:39:41 -08003806 parser.add_option('--all', action='store_true',
3807 help='Run checks against all files, not just modified ones')
Edward Lesmes8e282792018-04-03 18:50:29 -04003808 parser.add_option('--parallel', action='store_true',
3809 help='Run all tests specified by input_api.RunTests in all '
3810 'PRESUBMIT files in parallel.')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00003811 options, args = parser.parse_args(args)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003812
sbc@chromium.org71437c02015-04-09 19:29:40 +00003813 if not options.force and git_common.is_dirty_git_tree('presubmit'):
vapiera7fbd5a2016-06-16 09:17:49 -07003814 print('use --force to check even if tree is dirty.')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003815 return 1
3816
Edward Lemur934836a2019-09-09 20:16:54 +00003817 cl = Changelist()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003818 if args:
3819 base_branch = args[0]
3820 else:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00003821 # Default to diffing against the common ancestor of the upstream branch.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00003822 base_branch = cl.GetCommonAncestorWithUpstream()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003823
Gregory Nisbet29d5cf82020-02-27 08:16:58 +00003824 if cl.GetIssue():
3825 description = cl.FetchDescription()
Aaron Gable8076c282017-11-29 14:39:41 -08003826 else:
Edward Lemura12175c2020-03-09 16:58:26 +00003827 description = _create_description_from_log([base_branch])
Aaron Gable8076c282017-11-29 14:39:41 -08003828
ilevy@chromium.org051ad0e2013-03-04 21:57:34 +00003829 cl.RunHook(
3830 committing=not options.upload,
3831 may_prompt=False,
3832 verbose=options.verbose,
Edward Lemur227d5102020-02-25 23:45:35 +00003833 parallel=options.parallel,
3834 upstream=base_branch,
3835 description=description,
3836 all_files=options.all)
dpranke@chromium.org0a2bb372011-03-25 01:16:22 +00003837 return 0
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003838
3839
tandrii@chromium.org65874e12016-03-04 12:03:02 +00003840def GenerateGerritChangeId(message):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003841 """Returns the Change ID footer value (Ixxxxxx...xxx).
tandrii@chromium.org65874e12016-03-04 12:03:02 +00003842
3843 Works the same way as
3844 https://gerrit-review.googlesource.com/tools/hooks/commit-msg
3845 but can be called on demand on all platforms.
3846
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003847 The basic idea is to generate git hash of a state of the tree, original
3848 commit message, author/committer info and timestamps.
tandrii@chromium.org65874e12016-03-04 12:03:02 +00003849 """
3850 lines = []
3851 tree_hash = RunGitSilent(['write-tree'])
3852 lines.append('tree %s' % tree_hash.strip())
3853 code, parent = RunGitWithCode(['rev-parse', 'HEAD~0'], suppress_stderr=False)
3854 if code == 0:
3855 lines.append('parent %s' % parent.strip())
3856 author = RunGitSilent(['var', 'GIT_AUTHOR_IDENT'])
3857 lines.append('author %s' % author.strip())
3858 committer = RunGitSilent(['var', 'GIT_COMMITTER_IDENT'])
3859 lines.append('committer %s' % committer.strip())
3860 lines.append('')
3861 # Note: Gerrit's commit-hook actually cleans message of some lines and
3862 # whitespace. This code is not doing this, but it clearly won't decrease
3863 # entropy.
3864 lines.append(message)
3865 change_hash = RunCommand(['git', 'hash-object', '-t', 'commit', '--stdin'],
Raul Tambreb946b232019-03-26 14:48:46 +00003866 stdin=('\n'.join(lines)).encode())
tandrii@chromium.org65874e12016-03-04 12:03:02 +00003867 return 'I%s' % change_hash.strip()
3868
3869
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01003870def GetTargetRef(remote, remote_branch, target_branch):
wittman@chromium.org455dc922015-01-26 20:15:50 +00003871 """Computes the remote branch ref to use for the CL.
3872
3873 Args:
3874 remote (str): The git remote for the CL.
3875 remote_branch (str): The git remote branch for the CL.
3876 target_branch (str): The target branch specified by the user.
wittman@chromium.org455dc922015-01-26 20:15:50 +00003877 """
3878 if not (remote and remote_branch):
3879 return None
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00003880
wittman@chromium.org455dc922015-01-26 20:15:50 +00003881 if target_branch:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003882 # Canonicalize branch references to the equivalent local full symbolic
wittman@chromium.org455dc922015-01-26 20:15:50 +00003883 # refs, which are then translated into the remote full symbolic refs
3884 # below.
3885 if '/' not in target_branch:
3886 remote_branch = 'refs/remotes/%s/%s' % (remote, target_branch)
3887 else:
3888 prefix_replacements = (
3889 ('^((refs/)?remotes/)?branch-heads/', 'refs/remotes/branch-heads/'),
3890 ('^((refs/)?remotes/)?%s/' % remote, 'refs/remotes/%s/' % remote),
3891 ('^(refs/)?heads/', 'refs/remotes/%s/' % remote),
3892 )
3893 match = None
3894 for regex, replacement in prefix_replacements:
3895 match = re.search(regex, target_branch)
3896 if match:
3897 remote_branch = target_branch.replace(match.group(0), replacement)
3898 break
3899 if not match:
3900 # This is a branch path but not one we recognize; use as-is.
3901 remote_branch = target_branch
rmistry@google.comc68112d2015-03-03 12:48:06 +00003902 elif remote_branch in REFS_THAT_ALIAS_TO_OTHER_REFS:
3903 # Handle the refs that need to land in different refs.
3904 remote_branch = REFS_THAT_ALIAS_TO_OTHER_REFS[remote_branch]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00003905
wittman@chromium.org455dc922015-01-26 20:15:50 +00003906 # Create the true path to the remote branch.
3907 # Does the following translation:
3908 # * refs/remotes/origin/refs/diff/test -> refs/diff/test
3909 # * refs/remotes/origin/master -> refs/heads/master
3910 # * refs/remotes/branch-heads/test -> refs/branch-heads/test
3911 if remote_branch.startswith('refs/remotes/%s/refs/' % remote):
3912 remote_branch = remote_branch.replace('refs/remotes/%s/' % remote, '')
3913 elif remote_branch.startswith('refs/remotes/%s/' % remote):
3914 remote_branch = remote_branch.replace('refs/remotes/%s/' % remote,
3915 'refs/heads/')
3916 elif remote_branch.startswith('refs/remotes/branch-heads'):
3917 remote_branch = remote_branch.replace('refs/remotes/', 'refs/')
Andrii Shyshkalov768f1d82016-12-08 15:10:13 +01003918
wittman@chromium.org455dc922015-01-26 20:15:50 +00003919 return remote_branch
3920
3921
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00003922def cleanup_list(l):
3923 """Fixes a list so that comma separated items are put as individual items.
3924
3925 So that "--reviewers joe@c,john@c --reviewers joa@c" results in
3926 options.reviewers == sorted(['joe@c', 'john@c', 'joa@c']).
3927 """
3928 items = sum((i.split(',') for i in l), [])
3929 stripped_items = (i.strip() for i in items)
3930 return sorted(filter(None, stripped_items))
3931
3932
Aaron Gable4db38df2017-11-03 14:59:07 -07003933@subcommand.usage('[flags]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003934@metrics.collector.collect_metrics('git cl upload')
ukai@chromium.orge8077812012-02-03 03:41:46 +00003935def CMDupload(parser, args):
rmistry@google.com78948ed2015-07-08 23:09:57 +00003936 """Uploads the current changelist to codereview.
3937
3938 Can skip dependency patchset uploads for a branch by running:
3939 git config branch.branch_name.skip-deps-uploads True
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003940 To unset, run:
rmistry@google.com78948ed2015-07-08 23:09:57 +00003941 git config --unset branch.branch_name.skip-deps-uploads
3942 Can also set the above globally by using the --global flag.
Dominic Battre7d1c4842017-10-27 09:17:28 +02003943
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003944 If the name of the checked out branch starts with "bug-" or "fix-" followed
3945 by a bug number, this bug number is automatically populated in the CL
Dominic Battre7d1c4842017-10-27 09:17:28 +02003946 description.
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08003947
3948 If subject contains text in square brackets or has "<text>: " prefix, such
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003949 text(s) is treated as Gerrit hashtags. For example, CLs with subjects:
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08003950 [git-cl] add support for hashtags
3951 Foo bar: implement foo
3952 will be hashtagged with "git-cl" and "foo-bar" respectively.
rmistry@google.com78948ed2015-07-08 23:09:57 +00003953 """
ukai@chromium.orge8077812012-02-03 03:41:46 +00003954 parser.add_option('--bypass-hooks', action='store_true', dest='bypass_hooks',
3955 help='bypass upload presubmit hook')
brettw@chromium.orgb65c43c2013-06-10 22:04:49 +00003956 parser.add_option('--bypass-watchlists', action='store_true',
3957 dest='bypass_watchlists',
3958 help='bypass watchlists auto CC-ing reviewers')
Aaron Gablef7543cd2017-07-20 14:26:31 -07003959 parser.add_option('-f', '--force', action='store_true', dest='force',
ukai@chromium.orge8077812012-02-03 03:41:46 +00003960 help="force yes to questions (don't prompt)")
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08003961 parser.add_option('--message', '-m', dest='message',
3962 help='message for patchset')
tandriif9aefb72016-07-01 09:06:51 -07003963 parser.add_option('-b', '--bug',
3964 help='pre-populate the bug number(s) for this issue. '
3965 'If several, separate with commas')
tandriib80458a2016-06-23 12:20:07 -07003966 parser.add_option('--message-file', dest='message_file',
3967 help='file which contains message for patchset')
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08003968 parser.add_option('--title', '-t', dest='title',
3969 help='title for patchset')
ukai@chromium.orge8077812012-02-03 03:41:46 +00003970 parser.add_option('-r', '--reviewers',
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00003971 action='append', default=[],
ukai@chromium.orge8077812012-02-03 03:41:46 +00003972 help='reviewer email addresses')
Robert Iannucci6c98dc62017-04-18 11:38:00 -07003973 parser.add_option('--tbrs',
3974 action='append', default=[],
3975 help='TBR email addresses')
ukai@chromium.orge8077812012-02-03 03:41:46 +00003976 parser.add_option('--cc',
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00003977 action='append', default=[],
ukai@chromium.orge8077812012-02-03 03:41:46 +00003978 help='cc email addresses')
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08003979 parser.add_option('--hashtag', dest='hashtags',
3980 action='append', default=[],
3981 help=('Gerrit hashtag for new CL; '
3982 'can be applied multiple times'))
adamk@chromium.org36f47302013-04-05 01:08:31 +00003983 parser.add_option('-s', '--send-mail', action='store_true',
Aaron Gable59f48512017-01-12 10:54:46 -08003984 help='send email to reviewer(s) and cc(s) immediately')
ukai@chromium.org8ef7ab22012-11-28 04:24:52 +00003985 parser.add_option('--target_branch',
pgervais@chromium.orgb9f27512014-08-08 15:52:33 +00003986 '--target-branch',
wittman@chromium.org455dc922015-01-26 20:15:50 +00003987 metavar='TARGET',
3988 help='Apply CL to remote ref TARGET. ' +
3989 'Default: remote branch head, or master')
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00003990 parser.add_option('--squash', action='store_true',
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08003991 help='Squash multiple commits into one')
Mike Frysingera989d552019-08-14 20:51:23 +00003992 parser.add_option('--no-squash', action='store_false', dest='squash',
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08003993 help='Don\'t squash multiple commits into one')
rmistry9eadede2016-09-19 11:22:43 -07003994 parser.add_option('--topic', default=None,
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08003995 help='Topic to specify when uploading')
Robert Iannuccif2708bd2017-04-17 15:49:02 -07003996 parser.add_option('--tbr-owners', dest='add_owners_to', action='store_const',
3997 const='TBR', help='add a set of OWNERS to TBR')
3998 parser.add_option('--r-owners', dest='add_owners_to', action='store_const',
3999 const='R', help='add a set of OWNERS to R')
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00004000 parser.add_option('-c', '--use-commit-queue', action='store_true',
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004001 default=False,
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00004002 help='tell the CQ to commit this patchset; '
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004003 'implies --send-mail')
4004 parser.add_option('-d', '--cq-dry-run',
4005 action='store_true', default=False,
rmistry@google.comef966222015-04-07 11:15:01 +00004006 help='Send the patchset to do a CQ dry run right after '
4007 'upload.')
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +00004008 parser.add_option('--preserve-tryjobs', action='store_true',
4009 help='instruct the CQ to let tryjobs running even after '
4010 'new patchsets are uploaded instead of canceling '
4011 'prior patchset\' tryjobs')
rmistry@google.com2dd99862015-06-22 12:22:18 +00004012 parser.add_option('--dependencies', action='store_true',
4013 help='Uploads CLs of all the local branches that depend on '
4014 'the current branch')
Ravi Mistry31e7d562018-04-02 12:53:57 -04004015 parser.add_option('-a', '--enable-auto-submit', action='store_true',
4016 help='Sends your change to the CQ after an approval. Only '
4017 'works on repos that have the Auto-Submit label '
4018 'enabled')
Edward Lesmes8e282792018-04-03 18:50:29 -04004019 parser.add_option('--parallel', action='store_true',
4020 help='Run all tests specified by input_api.RunTests in all '
4021 'PRESUBMIT files in parallel.')
Sergiy Byelozyorov1aa405f2018-09-18 17:38:43 +00004022 parser.add_option('--no-autocc', action='store_true',
4023 help='Disables automatic addition of CC emails')
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004024 parser.add_option('--private', action='store_true',
Sergiy Byelozyorov1aa405f2018-09-18 17:38:43 +00004025 help='Set the review private. This implies --no-autocc.')
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004026 parser.add_option('-R', '--retry-failed', action='store_true',
4027 help='Retry failed tryjobs from old patchset immediately '
4028 'after uploading new patchset. Cannot be used with '
4029 '--use-commit-queue or --cq-dry-run.')
4030 parser.add_option('--buildbucket-host', default='cr-buildbucket.appspot.com',
4031 help='Host of buildbucket. The default host is %default.')
Dan Beamd8b04ca2019-10-10 21:23:26 +00004032 parser.add_option('--fixed', '-x',
4033 help='List of bugs that will be commented on and marked '
4034 'fixed (pre-populates "Fixed:" tag). Same format as '
4035 '-b option / "Bug:" tag. If fixing several issues, '
4036 'separate with commas.')
Josipe827b0f2020-01-30 00:07:20 +00004037 parser.add_option('--edit-description', action='store_true', default=False,
4038 help='Modify description before upload. Cannot be used '
4039 'with --force. It is a noop when --no-squash is set '
4040 'or a new commit is created.')
Sergiy Byelozyorov1aa405f2018-09-18 17:38:43 +00004041
rmistry@google.com2dd99862015-06-22 12:22:18 +00004042 orig_args = args
ukai@chromium.orge8077812012-02-03 03:41:46 +00004043 (options, args) = parser.parse_args(args)
4044
sbc@chromium.org71437c02015-04-09 19:29:40 +00004045 if git_common.is_dirty_git_tree('upload'):
ukai@chromium.orge8077812012-02-03 03:41:46 +00004046 return 1
4047
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004048 options.reviewers = cleanup_list(options.reviewers)
Robert Iannucci6c98dc62017-04-18 11:38:00 -07004049 options.tbrs = cleanup_list(options.tbrs)
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004050 options.cc = cleanup_list(options.cc)
4051
Josipe827b0f2020-01-30 00:07:20 +00004052 if options.edit_description and options.force:
4053 parser.error('Only one of --force and --edit-description allowed')
4054
tandriib80458a2016-06-23 12:20:07 -07004055 if options.message_file:
4056 if options.message:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004057 parser.error('Only one of --message and --message-file allowed.')
tandriib80458a2016-06-23 12:20:07 -07004058 options.message = gclient_utils.FileRead(options.message_file)
4059 options.message_file = None
4060
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004061 if ([options.cq_dry_run,
4062 options.use_commit_queue,
4063 options.retry_failed].count(True) > 1):
4064 parser.error('Only one of --use-commit-queue, --cq-dry-run, or '
4065 '--retry-failed is allowed.')
tandrii4d0545a2016-07-06 03:56:49 -07004066
Aaron Gableedbc4132017-09-11 13:22:28 -07004067 if options.use_commit_queue:
4068 options.send_mail = True
4069
Edward Lemur934836a2019-09-09 20:16:54 +00004070 cl = Changelist()
Edward Lesmes7677e5c2020-02-19 20:39:03 +00004071 # Warm change details cache now to avoid RPCs later, reducing latency for
4072 # developers.
4073 if cl.GetIssue():
4074 cl._GetChangeDetail(
4075 ['DETAILED_ACCOUNTS', 'CURRENT_REVISION', 'CURRENT_COMMIT', 'LABELS'])
4076
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004077 if options.retry_failed and not cl.GetIssue():
4078 print('No previous patchsets, so --retry-failed has no effect.')
4079 options.retry_failed = False
Edward Lesmes7677e5c2020-02-19 20:39:03 +00004080
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004081 # cl.GetMostRecentPatchset uses cached information, and can return the last
4082 # patchset before upload. Calling it here makes it clear that it's the
4083 # last patchset before upload. Note that GetMostRecentPatchset will fail
4084 # if no CL has been uploaded yet.
4085 if options.retry_failed:
4086 patchset = cl.GetMostRecentPatchset()
Andrii Shyshkalov9f274432018-10-15 16:40:23 +00004087
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004088 ret = cl.CMDUpload(options, args, orig_args)
4089
4090 if options.retry_failed:
4091 if ret != 0:
4092 print('Upload failed, so --retry-failed has no effect.')
4093 return ret
Andrii Shyshkalov1ad58112019-10-08 01:46:14 +00004094 builds, _ = _fetch_latest_builds(
Edward Lemur5b929a42019-10-21 17:57:39 +00004095 cl, options.buildbucket_host, latest_patchset=patchset)
Edward Lemur45768512020-03-02 19:03:14 +00004096 jobs = _filter_failed_for_retry(builds)
4097 if len(jobs) == 0:
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004098 print('No failed tryjobs, so --retry-failed has no effect.')
4099 return ret
Quinten Yearsley777660f2020-03-04 23:37:06 +00004100 _trigger_tryjobs(cl, jobs, options, patchset + 1)
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004101
4102 return ret
ukai@chromium.orge8077812012-02-03 03:41:46 +00004103
4104
Francois Dorayd42c6812017-05-30 15:10:20 -04004105@subcommand.usage('--description=<description file>')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004106@metrics.collector.collect_metrics('git cl split')
Francois Dorayd42c6812017-05-30 15:10:20 -04004107def CMDsplit(parser, args):
4108 """Splits a branch into smaller branches and uploads CLs.
4109
4110 Creates a branch and uploads a CL for each group of files modified in the
4111 current branch that share a common OWNERS file. In the CL description and
Edward Lemurac5c55f2020-02-29 00:17:16 +00004112 comment, the string '$directory', is replaced with the directory containing
4113 the shared OWNERS file.
Francois Dorayd42c6812017-05-30 15:10:20 -04004114 """
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004115 parser.add_option('-d', '--description', dest='description_file',
4116 help='A text file containing a CL description in which '
4117 '$directory will be replaced by each CL\'s directory.')
4118 parser.add_option('-c', '--comment', dest='comment_file',
4119 help='A text file containing a CL comment.')
4120 parser.add_option('-n', '--dry-run', dest='dry_run', action='store_true',
Chris Watkinsba28e462017-12-13 11:22:17 +11004121 default=False,
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004122 help='List the files and reviewers for each CL that would '
4123 'be created, but don\'t create branches or CLs.')
4124 parser.add_option('--cq-dry-run', action='store_true',
4125 help='If set, will do a cq dry run for each uploaded CL. '
4126 'Please be careful when doing this; more than ~10 CLs '
4127 'has the potential to overload our build '
4128 'infrastructure. Try to upload these not during high '
4129 'load times (usually 11-3 Mountain View time). Email '
4130 'infra-dev@chromium.org with any questions.')
Takuto Ikuta51eca592019-02-14 19:40:52 +00004131 parser.add_option('-a', '--enable-auto-submit', action='store_true',
4132 default=True,
4133 help='Sends your change to the CQ after an approval. Only '
4134 'works on repos that have the Auto-Submit label '
4135 'enabled')
Francois Dorayd42c6812017-05-30 15:10:20 -04004136 options, _ = parser.parse_args(args)
4137
4138 if not options.description_file:
4139 parser.error('No --description flag specified.')
4140
4141 def WrappedCMDupload(args):
4142 return CMDupload(OptionParser(), args)
4143
Edward Lemur2c62b332020-03-12 22:12:33 +00004144 return split_cl.SplitCl(
4145 options.description_file, options.comment_file, Changelist,
4146 WrappedCMDupload, options.dry_run, options.cq_dry_run,
4147 options.enable_auto_submit, settings.GetRoot())
Francois Dorayd42c6812017-05-30 15:10:20 -04004148
4149
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004150@subcommand.usage('DEPRECATED')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004151@metrics.collector.collect_metrics('git cl commit')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004152def CMDdcommit(parser, args):
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004153 """DEPRECATED: Used to commit the current changelist via git-svn."""
4154 message = ('git-cl no longer supports committing to SVN repositories via '
4155 'git-svn. You probably want to use `git cl land` instead.')
4156 print(message)
4157 return 1
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004158
4159
maruel@chromium.org0633fb42013-08-16 20:06:14 +00004160@subcommand.usage('[upstream branch to apply against]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004161@metrics.collector.collect_metrics('git cl land')
pgervais@chromium.orgcee6dc42014-05-07 17:04:03 +00004162def CMDland(parser, args):
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004163 """Commits the current changelist via git.
4164
4165 In case of Gerrit, uses Gerrit REST api to "submit" the issue, which pushes
4166 upstream and closes the issue automatically and atomically.
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004167 """
4168 parser.add_option('--bypass-hooks', action='store_true', dest='bypass_hooks',
4169 help='bypass upload presubmit hook')
Aaron Gablef7543cd2017-07-20 14:26:31 -07004170 parser.add_option('-f', '--force', action='store_true', dest='force',
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004171 help="force yes to questions (don't prompt)")
Edward Lesmes67b3faa2018-04-13 17:50:52 -04004172 parser.add_option('--parallel', action='store_true',
4173 help='Run all tests specified by input_api.RunTests in all '
4174 'PRESUBMIT files in parallel.')
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004175 (options, args) = parser.parse_args(args)
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004176
Edward Lemur934836a2019-09-09 20:16:54 +00004177 cl = Changelist()
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004178
Robert Iannucci2e73d432018-03-14 01:10:47 -07004179 if not cl.GetIssue():
4180 DieWithError('You must upload the change first to Gerrit.\n'
4181 ' If you would rather have `git cl land` upload '
4182 'automatically for you, see http://crbug.com/642759')
Edward Lemur125d60a2019-09-13 18:25:41 +00004183 return cl.CMDLand(options.force, options.bypass_hooks,
Olivier Robin75ee7252018-04-13 10:02:56 +02004184 options.verbose, options.parallel)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004185
4186
dsinclair@chromium.orgfbed6562015-09-25 21:22:36 +00004187@subcommand.usage('<patch url or issue id or issue url>')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004188@metrics.collector.collect_metrics('git cl patch')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004189def CMDpatch(parser, args):
marq@chromium.orge5e59002013-10-02 23:21:25 +00004190 """Patches in a code review."""
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004191 parser.add_option('-b', dest='newbranch',
4192 help='create a new branch off trunk for the patch')
qsr@chromium.org1ef44af2013-10-16 16:24:32 +00004193 parser.add_option('-f', '--force', action='store_true',
Aaron Gable62619a32017-06-16 08:22:09 -07004194 help='overwrite state on the current or chosen branch')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004195 parser.add_option('-n', '--no-commit', action='store_true', dest='nocommit',
Edward Lemurf38bc172019-09-03 21:02:13 +00004196 help='don\'t commit after patch applies.')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004197
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00004198 group = optparse.OptionGroup(
4199 parser,
4200 'Options for continuing work on the current issue uploaded from a '
4201 'different clone (e.g. different machine). Must be used independently '
4202 'from the other options. No issue number should be specified, and the '
4203 'branch must have an issue number associated with it')
4204 group.add_option('--reapply', action='store_true', dest='reapply',
4205 help='Reset the branch and reapply the issue.\n'
4206 'CAUTION: This will undo any local changes in this '
4207 'branch')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004208
4209 group.add_option('--pull', action='store_true', dest='pull',
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00004210 help='Performs a pull before reapplying.')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004211 parser.add_option_group(group)
4212
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004213 (options, args) = parser.parse_args(args)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004214
Andrii Shyshkalov18975322017-01-25 16:44:13 +01004215 if options.reapply:
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004216 if options.newbranch:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004217 parser.error('--reapply works on the current branch only.')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004218 if len(args) > 0:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004219 parser.error('--reapply implies no additional arguments.')
dsinclair@chromium.orgfbed6562015-09-25 21:22:36 +00004220
Edward Lemur934836a2019-09-09 20:16:54 +00004221 cl = Changelist()
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004222 if not cl.GetIssue():
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004223 parser.error('Current branch must have an associated issue.')
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004224
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004225 upstream = cl.GetUpstreamBranch()
Andrii Shyshkalov18975322017-01-25 16:44:13 +01004226 if upstream is None:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004227 parser.error('No upstream branch specified. Cannot reset branch.')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004228
4229 RunGit(['reset', '--hard', upstream])
4230 if options.pull:
4231 RunGit(['pull'])
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004232
Edward Lemur678a6842019-10-03 22:25:05 +00004233 target_issue_arg = ParseIssueNumberArgument(cl.GetIssue())
4234 return cl.CMDPatchWithParsedIssue(target_issue_arg, options.nocommit, False)
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004235
4236 if len(args) != 1 or not args[0]:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004237 parser.error('Must specify issue number or URL.')
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004238
Edward Lemurf38bc172019-09-03 21:02:13 +00004239 target_issue_arg = ParseIssueNumberArgument(args[0])
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004240 if not target_issue_arg.valid:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004241 parser.error('Invalid issue ID or URL.')
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004242
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004243 # We don't want uncommitted changes mixed up with the patch.
4244 if git_common.is_dirty_git_tree('patch'):
dsinclair@chromium.orgfbed6562015-09-25 21:22:36 +00004245 return 1
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004246
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004247 if options.newbranch:
4248 if options.force:
4249 RunGit(['branch', '-D', options.newbranch],
4250 stderr=subprocess2.PIPE, error_ok=True)
Edward Lemur84101642020-02-21 21:40:34 +00004251 git_new_branch.create_new_branch(options.newbranch)
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004252
Edward Lemur678a6842019-10-03 22:25:05 +00004253 cl = Changelist(
4254 codereview_host=target_issue_arg.hostname, issue=target_issue_arg.issue)
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004255
Edward Lemur678a6842019-10-03 22:25:05 +00004256 if not args[0].isdigit():
Edward Lemurf38bc172019-09-03 21:02:13 +00004257 print('canonical issue/change URL: %s\n' % cl.GetIssueURL())
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004258
Edward Lemurf38bc172019-09-03 21:02:13 +00004259 return cl.CMDPatchWithParsedIssue(
4260 target_issue_arg, options.nocommit, options.force)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004261
4262
jochen@chromium.org3ec0d542014-01-14 20:00:03 +00004263def GetTreeStatus(url=None):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004264 """Fetches the tree status and returns either 'open', 'closed',
4265 'unknown' or 'unset'."""
jochen@chromium.org3ec0d542014-01-14 20:00:03 +00004266 url = url or settings.GetTreeStatusUrl(error_ok=True)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004267 if url:
Edward Lemur79d4f992019-11-11 23:49:02 +00004268 status = urllib.request.urlopen(url).read().lower()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004269 if status.find('closed') != -1 or status == '0':
4270 return 'closed'
4271 elif status.find('open') != -1 or status == '1':
4272 return 'open'
4273 return 'unknown'
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004274 return 'unset'
4275
dpranke@chromium.org970c5222011-03-12 00:32:24 +00004276
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004277def GetTreeStatusReason():
4278 """Fetches the tree status from a json url and returns the message
4279 with the reason for the tree to be opened or closed."""
msb@chromium.orgbf1a7ba2011-02-01 16:21:46 +00004280 url = settings.GetTreeStatusUrl()
4281 json_url = urlparse.urljoin(url, '/current?format=json')
Edward Lemur79d4f992019-11-11 23:49:02 +00004282 connection = urllib.request.urlopen(json_url)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004283 status = json.loads(connection.read())
4284 connection.close()
4285 return status['message']
4286
dpranke@chromium.org970c5222011-03-12 00:32:24 +00004287
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004288@metrics.collector.collect_metrics('git cl tree')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004289def CMDtree(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004290 """Shows the status of the tree."""
dpranke@chromium.org97ae58e2011-03-18 00:29:20 +00004291 _, args = parser.parse_args(args)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004292 status = GetTreeStatus()
4293 if 'unset' == status:
vapiera7fbd5a2016-06-16 09:17:49 -07004294 print('You must configure your tree status URL by running "git cl config".')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004295 return 2
4296
vapiera7fbd5a2016-06-16 09:17:49 -07004297 print('The tree is %s' % status)
4298 print()
4299 print(GetTreeStatusReason())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004300 if status != 'open':
4301 return 1
4302 return 0
4303
4304
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004305@metrics.collector.collect_metrics('git cl try')
maruel@chromium.org15192402012-09-06 12:38:29 +00004306def CMDtry(parser, args):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004307 """Triggers tryjobs using either Buildbucket or CQ dry run."""
4308 group = optparse.OptionGroup(parser, 'Tryjob options')
maruel@chromium.org15192402012-09-06 12:38:29 +00004309 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004310 '-b', '--bot', action='append',
4311 help=('IMPORTANT: specify ONE builder per --bot flag. Use it multiple '
4312 'times to specify multiple builders. ex: '
4313 '"-b win_rel -b win_layout". See '
4314 'the try server waterfall for the builders name and the tests '
4315 'available.'))
maruel@chromium.org15192402012-09-06 12:38:29 +00004316 group.add_option(
borenet6c0efe62016-10-19 08:13:29 -07004317 '-B', '--bucket', default='',
4318 help=('Buildbucket bucket to send the try requests.'))
4319 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004320 '-r', '--revision',
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004321 help='Revision to use for the tryjob; default: the revision will '
tandriif7b29d42016-10-07 08:45:41 -07004322 'be determined by the try recipe that builder runs, which usually '
4323 'defaults to HEAD of origin/master')
maruel@chromium.org15192402012-09-06 12:38:29 +00004324 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004325 '-c', '--clobber', action='store_true', default=False,
tandriif7b29d42016-10-07 08:45:41 -07004326 help='Force a clobber before building; that is don\'t do an '
tandrii1838bad2016-10-06 00:10:52 -07004327 'incremental build')
maruel@chromium.org15192402012-09-06 12:38:29 +00004328 group.add_option(
Andrii Shyshkalovf9648b52018-02-21 22:32:42 -08004329 '--category', default='git_cl_try', help='Specify custom build category.')
4330 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004331 '--project',
4332 help='Override which project to use. Projects are defined '
tandriif7b29d42016-10-07 08:45:41 -07004333 'in recipe to determine to which repository or directory to '
4334 'apply the patch')
maruel@chromium.org15192402012-09-06 12:38:29 +00004335 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004336 '-p', '--property', dest='properties', action='append', default=[],
4337 help='Specify generic properties in the form -p key1=value1 -p '
tandriif7b29d42016-10-07 08:45:41 -07004338 'key2=value2 etc. The value will be treated as '
4339 'json if decodable, or as string otherwise. '
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004340 'NOTE: using this may make your tryjob not usable for CQ, '
4341 'which will then schedule another tryjob with default properties')
sheyang@chromium.orgdb375572015-08-17 19:22:23 +00004342 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004343 '--buildbucket-host', default='cr-buildbucket.appspot.com',
4344 help='Host of buildbucket. The default host is %default.')
maruel@chromium.org15192402012-09-06 12:38:29 +00004345 parser.add_option_group(group)
Quinten Yearsley983111f2019-09-26 17:18:48 +00004346 parser.add_option(
4347 '-R', '--retry-failed', action='store_true', default=False,
4348 help='Retry failed jobs from the latest set of tryjobs. '
4349 'Not allowed with --bucket and --bot options.')
Edward Lemur52969c92020-02-06 18:15:28 +00004350 parser.add_option(
4351 '-i', '--issue', type=int,
4352 help='Operate on this issue instead of the current branch\'s implicit '
4353 'issue.')
maruel@chromium.org15192402012-09-06 12:38:29 +00004354 options, args = parser.parse_args(args)
4355
machenbach@chromium.org45453142015-09-15 08:45:22 +00004356 # Make sure that all properties are prop=value pairs.
4357 bad_params = [x for x in options.properties if '=' not in x]
4358 if bad_params:
4359 parser.error('Got properties with missing "=": %s' % bad_params)
4360
maruel@chromium.org15192402012-09-06 12:38:29 +00004361 if args:
4362 parser.error('Unknown arguments: %s' % args)
4363
Edward Lemur934836a2019-09-09 20:16:54 +00004364 cl = Changelist(issue=options.issue)
maruel@chromium.org15192402012-09-06 12:38:29 +00004365 if not cl.GetIssue():
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004366 parser.error('Need to upload first.')
maruel@chromium.org15192402012-09-06 12:38:29 +00004367
Edward Lemurf38bc172019-09-03 21:02:13 +00004368 # HACK: warm up Gerrit change detail cache to save on RPCs.
Edward Lemur125d60a2019-09-13 18:25:41 +00004369 cl._GetChangeDetail(['DETAILED_ACCOUNTS', 'ALL_REVISIONS'])
Andrii Shyshkaloveadad922017-01-26 09:38:30 +01004370
tandriie113dfd2016-10-11 10:20:12 -07004371 error_message = cl.CannotTriggerTryJobReason()
4372 if error_message:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004373 parser.error('Can\'t trigger tryjobs: %s' % error_message)
jrobbins@chromium.org16f10f72014-06-24 22:14:36 +00004374
Edward Lemur45768512020-03-02 19:03:14 +00004375 if options.bot:
4376 if options.retry_failed:
4377 parser.error('--bot is not compatible with --retry-failed.')
4378 if not options.bucket:
4379 parser.error('A bucket (e.g. "chromium/try") is required.')
4380
4381 triggered = [b for b in options.bot if 'triggered' in b]
4382 if triggered:
4383 parser.error(
4384 'Cannot schedule builds on triggered bots: %s.\n'
4385 'This type of bot requires an initial job from a parent (usually a '
4386 'builder). Schedule a job on the parent instead.\n' % triggered)
4387
4388 if options.bucket.startswith('.master'):
4389 parser.error('Buildbot masters are not supported.')
4390
4391 project, bucket = _parse_bucket(options.bucket)
4392 if project is None or bucket is None:
4393 parser.error('Invalid bucket: %s.' % options.bucket)
4394 jobs = sorted((project, bucket, bot) for bot in options.bot)
4395 elif options.retry_failed:
Quinten Yearsley983111f2019-09-26 17:18:48 +00004396 print('Searching for failed tryjobs...')
Edward Lemur5b929a42019-10-21 17:57:39 +00004397 builds, patchset = _fetch_latest_builds(cl, options.buildbucket_host)
Quinten Yearsley983111f2019-09-26 17:18:48 +00004398 if options.verbose:
4399 print('Got %d builds in patchset #%d' % (len(builds), patchset))
Edward Lemur45768512020-03-02 19:03:14 +00004400 jobs = _filter_failed_for_retry(builds)
4401 if not jobs:
Quinten Yearsley983111f2019-09-26 17:18:48 +00004402 print('There are no failed jobs in the latest set of jobs '
4403 '(patchset #%d), doing nothing.' % patchset)
4404 return 0
Edward Lemur45768512020-03-02 19:03:14 +00004405 num_builders = len(jobs)
Quinten Yearsley983111f2019-09-26 17:18:48 +00004406 if num_builders > 10:
4407 confirm_or_exit('There are %d builders with failed builds.'
4408 % num_builders, action='continue')
4409 else:
qyearsley1fdfcb62016-10-24 13:22:03 -07004410 if options.verbose:
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07004411 print('git cl try with no bots now defaults to CQ dry run.')
4412 print('Scheduling CQ dry run on: %s' % cl.GetIssueURL())
4413 return cl.SetCQState(_CQState.DRY_RUN)
stip@chromium.org43064fd2013-12-18 20:07:44 +00004414
ilevy@chromium.org36e420b2013-08-06 23:21:12 +00004415 patchset = cl.GetMostRecentPatchset()
Edward Lemur2c210a42019-09-16 23:58:35 +00004416 try:
Quinten Yearsley777660f2020-03-04 23:37:06 +00004417 _trigger_tryjobs(cl, jobs, options, patchset)
Edward Lemur2c210a42019-09-16 23:58:35 +00004418 except BuildbucketResponseException as ex:
4419 print('ERROR: %s' % ex)
4420 return 1
4421 return 0
maruel@chromium.org15192402012-09-06 12:38:29 +00004422
4423
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004424@metrics.collector.collect_metrics('git cl try-results')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004425def CMDtry_results(parser, args):
Quinten Yearsleyd242ed72019-07-25 17:17:55 +00004426 """Prints info about results for tryjobs associated with the current CL."""
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004427 group = optparse.OptionGroup(parser, 'Tryjob results options')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004428 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004429 '-p', '--patchset', type=int, help='patchset number if not current.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004430 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004431 '--print-master', action='store_true', help='print master name as well.')
tandrii@chromium.org6cf98c82016-03-15 11:56:00 +00004432 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004433 '--color', action='store_true', default=setup_color.IS_TTY,
4434 help='force color output, useful when piping output.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004435 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004436 '--buildbucket-host', default='cr-buildbucket.appspot.com',
4437 help='Host of buildbucket. The default host is %default.')
qyearsley53f48a12016-09-01 10:45:13 -07004438 group.add_option(
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004439 '--json', help=('Path of JSON output file to write tryjob results to,'
Stefan Zager1306bd02017-06-22 19:26:46 -07004440 'or "-" for stdout.'))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004441 parser.add_option_group(group)
Edward Lemur52969c92020-02-06 18:15:28 +00004442 parser.add_option(
4443 '-i', '--issue', type=int,
4444 help='Operate on this issue instead of the current branch\'s implicit '
4445 'issue.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004446 options, args = parser.parse_args(args)
4447 if args:
4448 parser.error('Unrecognized args: %s' % ' '.join(args))
4449
Edward Lemur934836a2019-09-09 20:16:54 +00004450 cl = Changelist(issue=options.issue)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004451 if not cl.GetIssue():
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004452 parser.error('Need to upload first.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004453
tandrii221ab252016-10-06 08:12:04 -07004454 patchset = options.patchset
4455 if not patchset:
4456 patchset = cl.GetMostRecentPatchset()
4457 if not patchset:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004458 parser.error('Code review host doesn\'t know about issue %s. '
tandrii221ab252016-10-06 08:12:04 -07004459 'No access to issue or wrong issue number?\n'
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004460 'Either upload first, or pass --patchset explicitly.' %
tandrii221ab252016-10-06 08:12:04 -07004461 cl.GetIssue())
4462
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004463 try:
Quinten Yearsley777660f2020-03-04 23:37:06 +00004464 jobs = _fetch_tryjobs(cl, options.buildbucket_host, patchset)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004465 except BuildbucketResponseException as ex:
vapiera7fbd5a2016-06-16 09:17:49 -07004466 print('Buildbucket error: %s' % ex)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004467 return 1
qyearsley53f48a12016-09-01 10:45:13 -07004468 if options.json:
Edward Lemurbaaf6be2019-10-09 18:00:44 +00004469 write_json(options.json, jobs)
qyearsley53f48a12016-09-01 10:45:13 -07004470 else:
Quinten Yearsley777660f2020-03-04 23:37:06 +00004471 _print_tryjobs(options, jobs)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004472 return 0
4473
4474
maruel@chromium.org0633fb42013-08-16 20:06:14 +00004475@subcommand.usage('[new upstream branch]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004476@metrics.collector.collect_metrics('git cl upstream')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004477def CMDupstream(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004478 """Prints or sets the name of the upstream branch, if any."""
dpranke@chromium.org97ae58e2011-03-18 00:29:20 +00004479 _, args = parser.parse_args(args)
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00004480 if len(args) > 1:
maruel@chromium.org27bb3872011-05-30 20:33:19 +00004481 parser.error('Unrecognized args: %s' % ' '.join(args))
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00004482
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004483 cl = Changelist()
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00004484 if args:
4485 # One arg means set upstream branch.
bauerb@chromium.orgc9cf90a2014-04-28 20:32:31 +00004486 branch = cl.GetBranch()
stip7a3dd352016-09-22 17:32:28 -07004487 RunGit(['branch', '--set-upstream-to', args[0], branch])
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00004488 cl = Changelist()
vapiera7fbd5a2016-06-16 09:17:49 -07004489 print('Upstream branch set to %s' % (cl.GetUpstreamBranch(),))
bauerb@chromium.orgc9cf90a2014-04-28 20:32:31 +00004490
4491 # Clear configured merge-base, if there is one.
4492 git_common.remove_merge_base(branch)
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00004493 else:
vapiera7fbd5a2016-06-16 09:17:49 -07004494 print(cl.GetUpstreamBranch())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004495 return 0
4496
4497
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004498@metrics.collector.collect_metrics('git cl web')
thestig@chromium.org00858c82013-12-02 23:08:03 +00004499def CMDweb(parser, args):
4500 """Opens the current CL in the web browser."""
4501 _, args = parser.parse_args(args)
4502 if args:
4503 parser.error('Unrecognized args: %s' % ' '.join(args))
4504
4505 issue_url = Changelist().GetIssueURL()
4506 if not issue_url:
vapiera7fbd5a2016-06-16 09:17:49 -07004507 print('ERROR No issue to open', file=sys.stderr)
thestig@chromium.org00858c82013-12-02 23:08:03 +00004508 return 1
4509
Sergiy Byelozyorov2b718322018-10-24 17:43:31 +00004510 # Redirect I/O before invoking browser to hide its output. For example, this
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004511 # allows us to hide the "Created new window in existing browser session."
4512 # message from Chrome. Based on https://stackoverflow.com/a/2323563.
Sergiy Byelozyorov2b718322018-10-24 17:43:31 +00004513 saved_stdout = os.dup(1)
Sergiy Belozorov06684032019-03-06 16:53:08 +00004514 saved_stderr = os.dup(2)
Sergiy Byelozyorov2b718322018-10-24 17:43:31 +00004515 os.close(1)
Sergiy Belozorov06684032019-03-06 16:53:08 +00004516 os.close(2)
Sergiy Byelozyorov2b718322018-10-24 17:43:31 +00004517 os.open(os.devnull, os.O_RDWR)
4518 try:
4519 webbrowser.open(issue_url)
4520 finally:
4521 os.dup2(saved_stdout, 1)
Sergiy Belozorov06684032019-03-06 16:53:08 +00004522 os.dup2(saved_stderr, 2)
thestig@chromium.org00858c82013-12-02 23:08:03 +00004523 return 0
4524
4525
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004526@metrics.collector.collect_metrics('git cl set-commit')
maruel@chromium.org27bb3872011-05-30 20:33:19 +00004527def CMDset_commit(parser, args):
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00004528 """Sets the commit bit to trigger the CQ."""
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00004529 parser.add_option('-d', '--dry-run', action='store_true',
4530 help='trigger in dry run mode')
4531 parser.add_option('-c', '--clear', action='store_true',
4532 help='stop CQ run, if any')
Edward Lemur52969c92020-02-06 18:15:28 +00004533 parser.add_option(
4534 '-i', '--issue', type=int,
4535 help='Operate on this issue instead of the current branch\'s implicit '
4536 'issue.')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004537 options, args = parser.parse_args(args)
maruel@chromium.org27bb3872011-05-30 20:33:19 +00004538 if args:
4539 parser.error('Unrecognized args: %s' % ' '.join(args))
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00004540 if options.dry_run and options.clear:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004541 parser.error('Only one of --dry-run and --clear are allowed.')
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00004542
Edward Lemur934836a2019-09-09 20:16:54 +00004543 cl = Changelist(issue=options.issue)
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00004544 if options.clear:
tandriid9e5ce52016-07-13 02:32:59 -07004545 state = _CQState.NONE
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00004546 elif options.dry_run:
4547 state = _CQState.DRY_RUN
4548 else:
4549 state = _CQState.COMMIT
4550 if not cl.GetIssue():
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004551 parser.error('Must upload the issue first.')
tandrii9de9ec62016-07-13 03:01:59 -07004552 cl.SetCQState(state)
maruel@chromium.org27bb3872011-05-30 20:33:19 +00004553 return 0
4554
4555
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004556@metrics.collector.collect_metrics('git cl set-close')
groby@chromium.org411034a2013-02-26 15:12:01 +00004557def CMDset_close(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004558 """Closes the issue."""
Edward Lemur52969c92020-02-06 18:15:28 +00004559 parser.add_option(
4560 '-i', '--issue', type=int,
4561 help='Operate on this issue instead of the current branch\'s implicit '
4562 'issue.')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004563 options, args = parser.parse_args(args)
groby@chromium.org411034a2013-02-26 15:12:01 +00004564 if args:
4565 parser.error('Unrecognized args: %s' % ' '.join(args))
Edward Lemur934836a2019-09-09 20:16:54 +00004566 cl = Changelist(issue=options.issue)
groby@chromium.org411034a2013-02-26 15:12:01 +00004567 # Ensure there actually is an issue to close.
Aaron Gable7139a4e2017-09-05 17:53:09 -07004568 if not cl.GetIssue():
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004569 DieWithError('ERROR: No issue to close.')
groby@chromium.org411034a2013-02-26 15:12:01 +00004570 cl.CloseIssue()
4571 return 0
4572
4573
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004574@metrics.collector.collect_metrics('git cl diff')
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00004575def CMDdiff(parser, args):
wychen@chromium.org37b2ec02015-04-03 00:49:15 +00004576 """Shows differences between local tree and last upload."""
thomasanderson074beb22016-08-29 14:03:20 -07004577 parser.add_option(
4578 '--stat',
4579 action='store_true',
4580 dest='stat',
4581 help='Generate a diffstat')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004582 options, args = parser.parse_args(args)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004583 if args:
4584 parser.error('Unrecognized args: %s' % ' '.join(args))
wychen@chromium.org46309bf2015-04-03 21:04:49 +00004585
Edward Lemur934836a2019-09-09 20:16:54 +00004586 cl = Changelist()
sbc@chromium.org78dc9842013-11-25 18:43:44 +00004587 issue = cl.GetIssue()
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00004588 branch = cl.GetBranch()
sbc@chromium.org78dc9842013-11-25 18:43:44 +00004589 if not issue:
4590 DieWithError('No issue found for current branch (%s)' % branch)
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00004591
Aaron Gablea718c3e2017-08-28 17:47:28 -07004592 base = cl._GitGetBranchConfigValue('last-upload-hash')
4593 if not base:
4594 base = cl._GitGetBranchConfigValue('gerritsquashhash')
4595 if not base:
4596 detail = cl._GetChangeDetail(['CURRENT_REVISION', 'CURRENT_COMMIT'])
4597 revision_info = detail['revisions'][detail['current_revision']]
4598 fetch_info = revision_info['fetch']['http']
4599 RunGit(['fetch', fetch_info['url'], fetch_info['ref']])
4600 base = 'FETCH_HEAD'
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00004601
Aaron Gablea718c3e2017-08-28 17:47:28 -07004602 cmd = ['git', 'diff']
4603 if options.stat:
4604 cmd.append('--stat')
4605 cmd.append(base)
4606 subprocess2.check_call(cmd)
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00004607
4608 return 0
4609
4610
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004611@metrics.collector.collect_metrics('git cl owners')
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004612def CMDowners(parser, args):
Dirk Prankebf980882017-09-02 15:08:00 -07004613 """Finds potential owners for reviewing."""
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004614 parser.add_option(
Sidney San Martín8e6f58c2018-06-08 01:02:56 +00004615 '--ignore-current',
4616 action='store_true',
4617 help='Ignore the CL\'s current reviewers and start from scratch.')
4618 parser.add_option(
Sylvain Defresneb1f865d2019-02-12 12:38:22 +00004619 '--ignore-self',
4620 action='store_true',
4621 help='Do not consider CL\'s author as an owners.')
4622 parser.add_option(
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004623 '--no-color',
4624 action='store_true',
4625 help='Use this option to disable color output')
Dirk Prankebf980882017-09-02 15:08:00 -07004626 parser.add_option(
4627 '--batch',
4628 action='store_true',
4629 help='Do not run interactively, just suggest some')
Yang Guo6e269a02019-06-26 11:17:02 +00004630 # TODO: Consider moving this to another command, since other
4631 # git-cl owners commands deal with owners for a given CL.
4632 parser.add_option(
4633 '--show-all',
4634 action='store_true',
4635 help='Show all owners for a particular file')
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004636 options, args = parser.parse_args(args)
4637
Edward Lemur934836a2019-09-09 20:16:54 +00004638 cl = Changelist()
Edward Lesmese3a49aa2020-03-24 23:46:28 +00004639 author = cl.GetAuthor()
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004640
Yang Guo6e269a02019-06-26 11:17:02 +00004641 if options.show_all:
4642 for arg in args:
4643 base_branch = cl.GetCommonAncestorWithUpstream()
Edward Lemurb7f759f2020-03-04 21:20:56 +00004644 database = owners.Database(settings.GetRoot(), open, os.path)
Yang Guo6e269a02019-06-26 11:17:02 +00004645 database.load_data_needed_for([arg])
4646 print('Owners for %s:' % arg)
4647 for owner in sorted(database.all_possible_owners([arg], None)):
4648 print(' - %s' % owner)
4649 return 0
4650
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004651 if args:
4652 if len(args) > 1:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004653 parser.error('Unknown args.')
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004654 base_branch = args[0]
4655 else:
4656 # Default to diffing against the common ancestor of the upstream branch.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00004657 base_branch = cl.GetCommonAncestorWithUpstream()
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004658
Edward Lemur2c62b332020-03-12 22:12:33 +00004659 root = settings.GetRoot()
4660 affected_files = cl.GetAffectedFiles(base_branch)
Dirk Prankebf980882017-09-02 15:08:00 -07004661
4662 if options.batch:
Edward Lemur2c62b332020-03-12 22:12:33 +00004663 db = owners.Database(root, open, os.path)
Dirk Prankebf980882017-09-02 15:08:00 -07004664 print('\n'.join(db.reviewers_for(affected_files, author)))
4665 return 0
4666
Edward Lemur2c62b332020-03-12 22:12:33 +00004667 owner_files = [f for f in affected_files if 'OWNERS' in os.path.basename(f)]
4668 original_owner_files = {
4669 f: scm.GIT.GetOldContents(root, f, base_branch).splitlines()
4670 for f in owner_files}
4671
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004672 return owners_finder.OwnersFinder(
Dirk Prankebf980882017-09-02 15:08:00 -07004673 affected_files,
Edward Lemur2c62b332020-03-12 22:12:33 +00004674 root,
Edward Lemur707d70b2018-02-07 00:50:14 +01004675 author,
Sidney San Martín8e6f58c2018-06-08 01:02:56 +00004676 [] if options.ignore_current else cl.GetReviewers(),
Edward Lemur2c62b332020-03-12 22:12:33 +00004677 fopen=open,
4678 os_path=os.path,
Jochen Eisingerd0573ec2017-04-13 10:55:06 +02004679 disable_color=options.no_color,
Edward Lemur2c62b332020-03-12 22:12:33 +00004680 override_files=original_owner_files,
Sylvain Defresneb1f865d2019-02-12 12:38:22 +00004681 ignore_author=options.ignore_self).run()
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004682
4683
Aiden Bennerc08566e2018-10-03 17:52:42 +00004684def BuildGitDiffCmd(diff_type, upstream_commit, args, allow_prefix=False):
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00004685 """Generates a diff command."""
4686 # Generate diff for the current branch's changes.
Aiden Bennerc08566e2018-10-03 17:52:42 +00004687 diff_cmd = ['-c', 'core.quotePath=false', 'diff', '--no-ext-diff']
4688
Aiden Benner6c18a1a2018-11-23 20:18:23 +00004689 if allow_prefix:
4690 # explicitly setting --src-prefix and --dst-prefix is necessary in the
4691 # case that diff.noprefix is set in the user's git config.
4692 diff_cmd += ['--src-prefix=a/', '--dst-prefix=b/']
4693 else:
Aiden Bennerc08566e2018-10-03 17:52:42 +00004694 diff_cmd += ['--no-prefix']
4695
4696 diff_cmd += [diff_type, upstream_commit, '--']
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00004697
4698 if args:
4699 for arg in args:
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00004700 if os.path.isdir(arg) or os.path.isfile(arg):
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00004701 diff_cmd.append(arg)
4702 else:
4703 DieWithError('Argument "%s" is not a file or a directory' % arg)
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00004704
4705 return diff_cmd
4706
Andrii Shyshkalov18975322017-01-25 16:44:13 +01004707
Jamie Madill5e96ad12020-01-13 16:08:35 +00004708def _RunClangFormatDiff(opts, clang_diff_files, top_dir, upstream_commit):
4709 """Runs clang-format-diff and sets a return value if necessary."""
4710
4711 if not clang_diff_files:
4712 return 0
4713
4714 # Set to 2 to signal to CheckPatchFormatted() that this patch isn't
4715 # formatted. This is used to block during the presubmit.
4716 return_value = 0
4717
4718 # Locate the clang-format binary in the checkout
4719 try:
4720 clang_format_tool = clang_format.FindClangFormatToolInChromiumTree()
4721 except clang_format.NotFoundError as e:
4722 DieWithError(e)
4723
4724 if opts.full or settings.GetFormatFullByDefault():
4725 cmd = [clang_format_tool]
4726 if not opts.dry_run and not opts.diff:
4727 cmd.append('-i')
4728 if opts.dry_run:
4729 for diff_file in clang_diff_files:
4730 with open(diff_file, 'r') as myfile:
4731 code = myfile.read().replace('\r\n', '\n')
4732 stdout = RunCommand(cmd + [diff_file], cwd=top_dir)
4733 stdout = stdout.replace('\r\n', '\n')
4734 if opts.diff:
4735 sys.stdout.write(stdout)
4736 if code != stdout:
4737 return_value = 2
4738 else:
4739 stdout = RunCommand(cmd + clang_diff_files, cwd=top_dir)
4740 if opts.diff:
4741 sys.stdout.write(stdout)
4742 else:
4743 env = os.environ.copy()
4744 env['PATH'] = str(os.path.dirname(clang_format_tool))
4745 try:
4746 script = clang_format.FindClangFormatScriptInChromiumTree(
4747 'clang-format-diff.py')
4748 except clang_format.NotFoundError as e:
4749 DieWithError(e)
4750
4751 cmd = [sys.executable, script, '-p0']
4752 if not opts.dry_run and not opts.diff:
4753 cmd.append('-i')
4754
4755 diff_cmd = BuildGitDiffCmd('-U0', upstream_commit, clang_diff_files)
Edward Lemur1a83da12020-03-04 21:18:36 +00004756 diff_output = RunGit(diff_cmd).encode('utf-8')
Jamie Madill5e96ad12020-01-13 16:08:35 +00004757
4758 stdout = RunCommand(cmd, stdin=diff_output, cwd=top_dir, env=env)
4759 if opts.diff:
4760 sys.stdout.write(stdout)
4761 if opts.dry_run and len(stdout) > 0:
4762 return_value = 2
4763
4764 return return_value
4765
4766
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00004767def MatchingFileType(file_name, extensions):
Quinten Yearsleyd242ed72019-07-25 17:17:55 +00004768 """Returns True if the file name ends with one of the given extensions."""
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00004769 return bool([ext for ext in extensions if file_name.lower().endswith(ext)])
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00004770
Andrii Shyshkalov18975322017-01-25 16:44:13 +01004771
enne@chromium.org555cfe42014-01-29 18:21:39 +00004772@subcommand.usage('[files or directories to diff]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004773@metrics.collector.collect_metrics('git cl format')
agable@chromium.orgfab8f822013-05-06 17:43:09 +00004774def CMDformat(parser, args):
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00004775 """Runs auto-formatting tools (clang-format etc.) on the diff."""
Christopher Lamc5ba6922017-01-24 11:19:14 +11004776 CLANG_EXTS = ['.cc', '.cpp', '.h', '.m', '.mm', '.proto', '.java']
kylechar58edce22016-06-17 06:07:51 -07004777 GN_EXTS = ['.gn', '.gni', '.typemap']
enne@chromium.org3b7e15c2014-01-21 17:44:47 +00004778 parser.add_option('--full', action='store_true',
4779 help='Reformat the full content of all touched files')
4780 parser.add_option('--dry-run', action='store_true',
4781 help='Don\'t modify any file on disk.')
Aiden Benner99b0ccb2018-11-20 19:53:31 +00004782 parser.add_option(
Garrett Beatyed0cc5f2020-01-06 17:26:13 +00004783 '--no-clang-format',
4784 dest='clang_format',
4785 action='store_false',
4786 default=True,
4787 help='Disables formatting of various file types using clang-format.')
4788 parser.add_option(
Aiden Benner99b0ccb2018-11-20 19:53:31 +00004789 '--python',
4790 action='store_true',
4791 default=None,
4792 help='Enables python formatting on all python files.')
4793 parser.add_option(
4794 '--no-python',
4795 action='store_true',
Garrett Beaty91a6f332020-01-06 16:57:24 +00004796 default=False,
Aiden Benner99b0ccb2018-11-20 19:53:31 +00004797 help='Disables python formatting on all python files. '
Garrett Beaty91a6f332020-01-06 16:57:24 +00004798 'If neither --python or --no-python are set, python files that have a '
4799 '.style.yapf file in an ancestor directory will be formatted. '
4800 'It is an error to set both.')
Garrett Beatyed0cc5f2020-01-06 17:26:13 +00004801 parser.add_option(
4802 '--js',
4803 action='store_true',
4804 help='Format javascript code with clang-format. '
4805 'Has no effect if --no-clang-format is set.')
wittman@chromium.org04d5a222014-03-07 18:30:42 +00004806 parser.add_option('--diff', action='store_true',
4807 help='Print diff to stdout rather than modifying files.')
Ilya Shermane081cbe2017-08-15 17:51:04 -07004808 parser.add_option('--presubmit', action='store_true',
4809 help='Used when running the script from a presubmit.')
agable@chromium.orgfab8f822013-05-06 17:43:09 +00004810 opts, args = parser.parse_args(args)
agable@chromium.orgfab8f822013-05-06 17:43:09 +00004811
Garrett Beaty91a6f332020-01-06 16:57:24 +00004812 if opts.python is not None and opts.no_python:
4813 raise parser.error('Cannot set both --python and --no-python')
4814 if opts.no_python:
4815 opts.python = False
4816
Daniel Chengc55eecf2016-12-30 03:11:02 -08004817 # Normalize any remaining args against the current path, so paths relative to
4818 # the current directory are still resolved as expected.
4819 args = [os.path.join(os.getcwd(), arg) for arg in args]
4820
enne@chromium.orgff7a1fb2013-12-10 19:21:41 +00004821 # git diff generates paths against the root of the repository. Change
4822 # to that directory so clang-format can find files even within subdirs.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00004823 rel_base_path = settings.GetRelativeRoot()
enne@chromium.orgff7a1fb2013-12-10 19:21:41 +00004824 if rel_base_path:
4825 os.chdir(rel_base_path)
4826
digit@chromium.org29e47272013-05-17 17:01:46 +00004827 # Grab the merge-base commit, i.e. the upstream commit of the current
4828 # branch when it was created or the last time it was rebased. This is
4829 # to cover the case where the user may have called "git fetch origin",
4830 # moving the origin branch to a newer commit, but hasn't rebased yet.
4831 upstream_commit = None
4832 cl = Changelist()
4833 upstream_branch = cl.GetUpstreamBranch()
4834 if upstream_branch:
4835 upstream_commit = RunGit(['merge-base', 'HEAD', upstream_branch])
4836 upstream_commit = upstream_commit.strip()
4837
4838 if not upstream_commit:
4839 DieWithError('Could not find base commit for this branch. '
4840 'Are you in detached state?')
4841
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00004842 changed_files_cmd = BuildGitDiffCmd('--name-only', upstream_commit, args)
4843 diff_output = RunGit(changed_files_cmd)
4844 diff_files = diff_output.splitlines()
jkarlin@chromium.orgad21b922016-01-28 17:48:42 +00004845 # Filter out files deleted by this CL
4846 diff_files = [x for x in diff_files if os.path.isfile(x)]
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00004847
Andreas Haas417d89c2020-02-06 10:24:27 +00004848 if opts.js:
Deepanjan Roy605dd312018-07-02 17:48:54 +00004849 CLANG_EXTS.extend(['.js', '.ts'])
Christopher Lamc5ba6922017-01-24 11:19:14 +11004850
Garrett Beatyed0cc5f2020-01-06 17:26:13 +00004851 clang_diff_files = []
4852 if opts.clang_format:
4853 clang_diff_files = [
4854 x for x in diff_files if MatchingFileType(x, CLANG_EXTS)
4855 ]
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00004856 python_diff_files = [x for x in diff_files if MatchingFileType(x, ['.py'])]
4857 dart_diff_files = [x for x in diff_files if MatchingFileType(x, ['.dart'])]
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00004858 gn_diff_files = [x for x in diff_files if MatchingFileType(x, GN_EXTS)]
digit@chromium.org29e47272013-05-17 17:01:46 +00004859
Edward Lesmese3a49aa2020-03-24 23:46:28 +00004860 top_dir = settings.GetRoot()
nick@chromium.org3ac1c4e2014-01-16 02:44:42 +00004861
Jamie Madill5e96ad12020-01-13 16:08:35 +00004862 return_value = _RunClangFormatDiff(opts, clang_diff_files, top_dir,
4863 upstream_commit)
agable@chromium.orgfab8f822013-05-06 17:43:09 +00004864
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00004865 # Similar code to above, but using yapf on .py files rather than clang-format
4866 # on C/C++ files
Aiden Benner99b0ccb2018-11-20 19:53:31 +00004867 py_explicitly_disabled = opts.python is not None and not opts.python
4868 if python_diff_files and not py_explicitly_disabled:
Aiden Bennere47ac152018-11-20 16:44:03 +00004869 depot_tools_path = os.path.dirname(os.path.abspath(__file__))
4870 yapf_tool = os.path.join(depot_tools_path, 'yapf')
4871 if sys.platform.startswith('win'):
4872 yapf_tool += '.bat'
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00004873
Aiden Bennerc08566e2018-10-03 17:52:42 +00004874 # Used for caching.
4875 yapf_configs = {}
4876 for f in python_diff_files:
4877 # Find the yapf style config for the current file, defaults to depot
4878 # tools default.
Aiden Benner99b0ccb2018-11-20 19:53:31 +00004879 _FindYapfConfigFile(f, yapf_configs, top_dir)
4880
4881 # Turn on python formatting by default if a yapf config is specified.
4882 # This breaks in the case of this repo though since the specified
4883 # style file is also the global default.
4884 if opts.python is None:
4885 filtered_py_files = []
4886 for f in python_diff_files:
4887 if _FindYapfConfigFile(f, yapf_configs, top_dir) is not None:
4888 filtered_py_files.append(f)
4889 else:
4890 filtered_py_files = python_diff_files
4891
4892 # Note: yapf still seems to fix indentation of the entire file
4893 # even if line ranges are specified.
4894 # See https://github.com/google/yapf/issues/499
4895 if not opts.full and filtered_py_files:
4896 py_line_diffs = _ComputeDiffLineRanges(filtered_py_files, upstream_commit)
4897
Brian Sheedyb4307d52019-12-02 19:18:17 +00004898 yapfignore_patterns = _GetYapfIgnorePatterns(top_dir)
4899 filtered_py_files = _FilterYapfIgnoredFiles(filtered_py_files,
4900 yapfignore_patterns)
Brian Sheedy59b06a82019-10-14 17:03:29 +00004901
Aiden Benner99b0ccb2018-11-20 19:53:31 +00004902 for f in filtered_py_files:
Andrew Grievefa40bfa2020-01-07 02:32:57 +00004903 yapf_style = _FindYapfConfigFile(f, yapf_configs, top_dir)
4904 # Default to pep8 if not .style.yapf is found.
4905 if not yapf_style:
4906 yapf_style = 'pep8'
Aiden Bennerc08566e2018-10-03 17:52:42 +00004907
Andrew Grievefa40bfa2020-01-07 02:32:57 +00004908 cmd = [yapf_tool, '--style', yapf_style, f]
Aiden Bennerc08566e2018-10-03 17:52:42 +00004909
4910 has_formattable_lines = False
4911 if not opts.full:
4912 # Only run yapf over changed line ranges.
4913 for diff_start, diff_len in py_line_diffs[f]:
4914 diff_end = diff_start + diff_len - 1
4915 # Yapf errors out if diff_end < diff_start but this
4916 # is a valid line range diff for a removal.
4917 if diff_end >= diff_start:
4918 has_formattable_lines = True
4919 cmd += ['-l', '{}-{}'.format(diff_start, diff_end)]
4920 # If all line diffs were removals we have nothing to format.
4921 if not has_formattable_lines:
4922 continue
4923
4924 if opts.diff or opts.dry_run:
4925 cmd += ['--diff']
4926 # Will return non-zero exit code if non-empty diff.
4927 stdout = RunCommand(cmd, error_ok=True, cwd=top_dir)
4928 if opts.diff:
4929 sys.stdout.write(stdout)
4930 elif len(stdout) > 0:
4931 return_value = 2
4932 else:
4933 cmd += ['-i']
4934 RunCommand(cmd, cwd=top_dir)
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00004935
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00004936 # Dart's formatter does not have the nice property of only operating on
4937 # modified chunks, so hard code full.
4938 if dart_diff_files:
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00004939 try:
4940 command = [dart_format.FindDartFmtToolInChromiumTree()]
4941 if not opts.dry_run and not opts.diff:
4942 command.append('-w')
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00004943 command.extend(dart_diff_files)
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00004944
ppi@chromium.org6593d932016-03-03 15:41:15 +00004945 stdout = RunCommand(command, cwd=top_dir)
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00004946 if opts.dry_run and stdout:
4947 return_value = 2
Jamie Madill5e96ad12020-01-13 16:08:35 +00004948 except dart_format.NotFoundError:
vapiera7fbd5a2016-06-16 09:17:49 -07004949 print('Warning: Unable to check Dart code formatting. Dart SDK not '
4950 'found in this checkout. Files in other languages are still '
4951 'formatted.')
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00004952
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00004953 # Format GN build files. Always run on full build files for canonical form.
4954 if gn_diff_files:
Andrii Shyshkalov18975322017-01-25 16:44:13 +01004955 cmd = ['gn', 'format']
brettw4b8ed592016-08-05 16:19:12 -07004956 if opts.dry_run or opts.diff:
4957 cmd.append('--dry-run')
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00004958 for gn_diff_file in gn_diff_files:
brettw4b8ed592016-08-05 16:19:12 -07004959 gn_ret = subprocess2.call(cmd + [gn_diff_file],
4960 shell=sys.platform == 'win32',
4961 cwd=top_dir)
4962 if opts.dry_run and gn_ret == 2:
4963 return_value = 2 # Not formatted.
4964 elif opts.diff and gn_ret == 2:
4965 # TODO this should compute and print the actual diff.
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004966 print('This change has GN build file diff for ' + gn_diff_file)
brettw4b8ed592016-08-05 16:19:12 -07004967 elif gn_ret != 0:
4968 # For non-dry run cases (and non-2 return values for dry-run), a
4969 # nonzero error code indicates a failure, probably because the file
4970 # doesn't parse.
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004971 DieWithError('gn format failed on ' + gn_diff_file +
4972 '\nTry running `gn format` on this file manually.')
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00004973
Ilya Shermane081cbe2017-08-15 17:51:04 -07004974 # Skip the metrics formatting from the global presubmit hook. These files have
4975 # a separate presubmit hook that issues an error if the files need formatting,
4976 # whereas the top-level presubmit script merely issues a warning. Formatting
4977 # these files is somewhat slow, so it's important not to duplicate the work.
4978 if not opts.presubmit:
4979 for xml_dir in GetDirtyMetricsDirs(diff_files):
4980 tool_dir = os.path.join(top_dir, xml_dir)
4981 cmd = [os.path.join(tool_dir, 'pretty_print.py'), '--non-interactive']
4982 if opts.dry_run or opts.diff:
4983 cmd.append('--diff')
Ilya Sherman235b70d2017-08-22 17:46:38 -07004984 stdout = RunCommand(cmd, cwd=top_dir)
Ilya Shermane081cbe2017-08-15 17:51:04 -07004985 if opts.diff:
4986 sys.stdout.write(stdout)
4987 if opts.dry_run and stdout:
4988 return_value = 2 # Not formatted.
Alexei Svitkinef3cac412017-02-06 11:08:50 -05004989
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00004990 return return_value
agable@chromium.orgfab8f822013-05-06 17:43:09 +00004991
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004992
Steven Holte2e664bf2017-04-21 13:10:47 -07004993def GetDirtyMetricsDirs(diff_files):
4994 xml_diff_files = [x for x in diff_files if MatchingFileType(x, ['.xml'])]
4995 metrics_xml_dirs = [
4996 os.path.join('tools', 'metrics', 'actions'),
4997 os.path.join('tools', 'metrics', 'histograms'),
4998 os.path.join('tools', 'metrics', 'rappor'),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004999 os.path.join('tools', 'metrics', 'ukm'),
5000 ]
Steven Holte2e664bf2017-04-21 13:10:47 -07005001 for xml_dir in metrics_xml_dirs:
5002 if any(file.startswith(xml_dir) for file in xml_diff_files):
5003 yield xml_dir
5004
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005005
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005006@subcommand.usage('<codereview url or issue id>')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005007@metrics.collector.collect_metrics('git cl checkout')
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005008def CMDcheckout(parser, args):
Edward Lemurf38bc172019-09-03 21:02:13 +00005009 """Checks out a branch associated with a given Gerrit issue."""
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005010 _, args = parser.parse_args(args)
5011
5012 if len(args) != 1:
5013 parser.print_help()
5014 return 1
5015
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00005016 issue_arg = ParseIssueNumberArgument(args[0])
tandrii@chromium.orgde6c9a12016-04-11 15:33:53 +00005017 if not issue_arg.valid:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00005018 parser.error('Invalid issue ID or URL.')
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02005019
tandrii@chromium.orgabd27e52016-04-11 15:43:32 +00005020 target_issue = str(issue_arg.issue)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005021
Edward Lemur52969c92020-02-06 18:15:28 +00005022 output = RunGit(['config', '--local', '--get-regexp',
Edward Lesmese3a49aa2020-03-24 23:46:28 +00005023 r'branch\..*\.' + ISSUE_CONFIG_KEY],
Edward Lemur52969c92020-02-06 18:15:28 +00005024 error_ok=True)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005025
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00005026 branches = []
Edward Lemur52969c92020-02-06 18:15:28 +00005027 for key, issue in [x.split() for x in output.splitlines()]:
5028 if issue == target_issue:
Edward Lesmese3a49aa2020-03-24 23:46:28 +00005029 branches.append(re.sub(r'branch\.(.*)\.' + ISSUE_CONFIG_KEY, r'\1', key))
Edward Lemur52969c92020-02-06 18:15:28 +00005030
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005031 if len(branches) == 0:
vapiera7fbd5a2016-06-16 09:17:49 -07005032 print('No branch found for issue %s.' % target_issue)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005033 return 1
5034 if len(branches) == 1:
5035 RunGit(['checkout', branches[0]])
5036 else:
vapiera7fbd5a2016-06-16 09:17:49 -07005037 print('Multiple branches match issue %s:' % target_issue)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005038 for i in range(len(branches)):
vapiera7fbd5a2016-06-16 09:17:49 -07005039 print('%d: %s' % (i, branches[i]))
Edward Lesmesae3586b2020-03-23 21:21:14 +00005040 which = gclient_utils.AskForData('Choose by index: ')
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005041 try:
5042 RunGit(['checkout', branches[int(which)]])
5043 except (IndexError, ValueError):
vapiera7fbd5a2016-06-16 09:17:49 -07005044 print('Invalid selection, not checking out any branch.')
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005045 return 1
5046
5047 return 0
5048
5049
maruel@chromium.org29404b52014-09-08 22:58:00 +00005050def CMDlol(parser, args):
5051 # This command is intentionally undocumented.
vapiera7fbd5a2016-06-16 09:17:49 -07005052 print(zlib.decompress(base64.b64decode(
thakis@chromium.org3421c992014-11-02 02:20:32 +00005053 'eNptkLEOwyAMRHe+wupCIqW57v0Vq84WqWtXyrcXnCBsmgMJ+/SSAxMZgRB6NzE'
5054 'E2ObgCKJooYdu4uAQVffUEoE1sRQLxAcqzd7uK2gmStrll1ucV3uZyaY5sXyDd9'
5055 'JAnN+lAXsOMJ90GANAi43mq5/VeeacylKVgi8o6F1SC63FxnagHfJUTfUYdCR/W'
vapiera7fbd5a2016-06-16 09:17:49 -07005056 'Ofe+0dHL7PicpytKP750Fh1q2qnLVof4w8OZWNY')))
maruel@chromium.org29404b52014-09-08 22:58:00 +00005057 return 0
5058
5059
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005060class OptionParser(optparse.OptionParser):
5061 """Creates the option parse and add --verbose support."""
5062 def __init__(self, *args, **kwargs):
maruel@chromium.org0633fb42013-08-16 20:06:14 +00005063 optparse.OptionParser.__init__(
5064 self, *args, prog='git cl', version=__version__, **kwargs)
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005065 self.add_option(
5066 '-v', '--verbose', action='count', default=0,
5067 help='Use 2 times for more debugging info')
5068
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005069 def parse_args(self, args=None, _values=None):
Andrii Shyshkalov46f20cd2018-10-30 06:42:54 +00005070 try:
5071 return self._parse_args(args)
5072 finally:
5073 # Regardless of success or failure of args parsing, we want to report
5074 # metrics, but only after logging has been initialized (if parsing
5075 # succeeded).
5076 global settings
5077 settings = Settings()
5078
5079 if not metrics.DISABLE_METRICS_COLLECTION:
5080 # GetViewVCUrl ultimately calls logging method.
5081 project_url = settings.GetViewVCUrl().strip('/+')
5082 if project_url in metrics_utils.KNOWN_PROJECT_URLS:
5083 metrics.collector.add('project_urls', [project_url])
5084
5085 def _parse_args(self, args=None):
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005086 # Create an optparse.Values object that will store only the actual passed
5087 # options, without the defaults.
5088 actual_options = optparse.Values()
5089 _, args = optparse.OptionParser.parse_args(self, args, actual_options)
5090 # Create an optparse.Values object with the default options.
5091 options = optparse.Values(self.get_default_values().__dict__)
5092 # Update it with the options passed by the user.
5093 options._update_careful(actual_options.__dict__)
5094 # Store the options passed by the user in an _actual_options attribute.
5095 # We store only the keys, and not the values, since the values can contain
5096 # arbitrary information, which might be PII.
Edward Lemur79d4f992019-11-11 23:49:02 +00005097 metrics.collector.add('arguments', list(actual_options.__dict__.keys()))
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005098
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005099 levels = [logging.WARNING, logging.INFO, logging.DEBUG]
Andrii Shyshkalov5b04a572017-01-23 17:44:41 +01005100 logging.basicConfig(
5101 level=levels[min(options.verbose, len(levels) - 1)],
5102 format='[%(levelname).1s%(asctime)s %(process)d %(thread)d '
5103 '%(filename)s] %(message)s')
Edward Lemur83bd7f42018-10-10 00:14:21 +00005104
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005105 return options, args
5106
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005107
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005108def main(argv):
maruel@chromium.org82798cb2012-02-23 18:16:12 +00005109 if sys.hexversion < 0x02060000:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005110 print('\nYour Python version %s is unsupported, please upgrade.\n' %
vapiera7fbd5a2016-06-16 09:17:49 -07005111 (sys.version.split(' ', 1)[0],), file=sys.stderr)
maruel@chromium.org82798cb2012-02-23 18:16:12 +00005112 return 2
maruel@chromium.org2e23ce32013-05-07 12:42:28 +00005113
maruel@chromium.org39c0b222013-08-17 16:57:01 +00005114 colorize_CMDstatus_doc()
maruel@chromium.org0633fb42013-08-16 20:06:14 +00005115 dispatcher = subcommand.CommandDispatcher(__name__)
5116 try:
5117 return dispatcher.execute(OptionParser(), argv)
Edward Lemur5b929a42019-10-21 17:57:39 +00005118 except auth.LoginRequiredError as e:
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +00005119 DieWithError(str(e))
Edward Lemur79d4f992019-11-11 23:49:02 +00005120 except urllib.error.HTTPError as e:
maruel@chromium.org0633fb42013-08-16 20:06:14 +00005121 if e.code != 500:
5122 raise
5123 DieWithError(
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005124 ('App Engine is misbehaving and returned HTTP %d, again. Keep faith '
Quinten Yearsleyc4202212019-07-22 23:34:40 +00005125 'and retry or visit go/isgaeup.\n%s') % (e.code, str(e)))
sbc@chromium.org013731e2015-02-26 18:28:43 +00005126 return 0
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005127
5128
5129if __name__ == '__main__':
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005130 # These affect sys.stdout, so do it outside of main() to simplify mocks in
5131 # the unit tests.
maruel@chromium.org6f09cd92011-04-01 16:38:12 +00005132 fix_encoding.fix_encoding()
iannucci@chromium.org596cd5c2016-04-04 21:34:39 +00005133 setup_color.init()
Edward Lemur6f812e12018-07-31 22:45:57 +00005134 with metrics.collector.print_notice_and_exit():
sbc@chromium.org013731e2015-02-26 18:28:43 +00005135 sys.exit(main(sys.argv[1:]))