blob: ffcfe9f3fd97d046ed3df301fdd1d55c4b819c5f [file] [log] [blame]
maruel@chromium.org725f1c32011-04-01 20:24:54 +00001#!/usr/bin/env python
maruel@chromium.org3bbf2942012-01-10 16:52:06 +00002# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
6"""Enables directory-specific presubmit checks to run at upload and/or commit.
7"""
8
Raul Tambre80ee78e2019-05-06 22:41:05 +00009from __future__ import print_function
10
stip@chromium.orgf7d31f52014-01-03 20:14:46 +000011__version__ = '1.8.0'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000012
13# TODO(joi) Add caching where appropriate/needed. The API is designed to allow
14# caching (between all different invocations of presubmit scripts for a given
15# change). We should add it as our presubmit scripts start feeling slow.
16
Edward Lemura5799e32020-01-17 19:26:51 +000017import argparse
Takeshi Yoshino07a6bea2017-08-02 02:44:06 +090018import ast # Exposed through the API.
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +000019import contextlib
Yoshisato Yanagisawa406de132018-06-29 05:43:25 +000020import cpplint
dcheng091b7db2016-06-16 01:27:51 -070021import fnmatch # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000022import glob
asvitkine@chromium.org15169952011-09-27 14:30:53 +000023import inspect
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +000024import itertools
maruel@chromium.org4f6852c2012-04-20 20:39:20 +000025import json # Exposed through the API.
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +000026import logging
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000027import multiprocessing
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000028import os # Somewhat exposed through the API.
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000029import random
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000030import re # Exposed through the API.
Edward Lesmes8e282792018-04-03 18:50:29 -040031import signal
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000032import sys # Parts exposed through API.
33import tempfile # Exposed through the API.
Edward Lesmes8e282792018-04-03 18:50:29 -040034import threading
jam@chromium.org2a891dc2009-08-20 20:33:37 +000035import time
Edward Lemurde9e3ca2019-10-24 21:13:31 +000036import traceback
maruel@chromium.org1487d532009-06-06 00:22:57 +000037import unittest # Exposed through the API.
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000038from warnings import warn
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000039
40# Local imports.
maruel@chromium.org35625c72011-03-23 17:34:02 +000041import fix_encoding
Yoshisato Yanagisawa04600b42019-03-15 03:03:41 +000042import gclient_paths # Exposed through the API
43import gclient_utils
Aaron Gableb584c4f2017-04-26 16:28:08 -070044import git_footers
tandrii@chromium.org015ebae2016-04-25 19:37:22 +000045import gerrit_util
dpranke@chromium.org2a009622011-03-01 02:43:31 +000046import owners
Jochen Eisinger76f5fc62017-04-07 16:27:46 +020047import owners_finder
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000048import presubmit_canned_checks
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +000049import scm
maruel@chromium.org84f4fe32011-04-06 13:26:45 +000050import subprocess2 as subprocess # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000051
Edward Lemur16af3562019-10-17 22:11:33 +000052if sys.version_info.major == 2:
53 # TODO(1009814): Expose urllib2 only through urllib_request and urllib_error
54 import urllib2 # Exposed through the API.
55 import urlparse
56 import urllib2 as urllib_request
57 import urllib2 as urllib_error
58else:
59 import urllib.parse as urlparse
60 import urllib.request as urllib_request
61 import urllib.error as urllib_error
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000062
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000063# Ask for feedback only once in program lifetime.
64_ASKED_FOR_FEEDBACK = False
65
66
Edward Lemurecc27072020-01-06 16:42:34 +000067def time_time():
68 # Use this so that it can be mocked in tests without interfering with python
69 # system machinery.
70 return time.time()
71
72
maruel@chromium.org899e1c12011-04-07 17:03:18 +000073class PresubmitFailure(Exception):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000074 pass
75
76
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000077class CommandData(object):
Edward Lemur940c2822019-08-23 00:34:25 +000078 def __init__(self, name, cmd, kwargs, message, python3=False):
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000079 self.name = name
80 self.cmd = cmd
Edward Lesmes8e282792018-04-03 18:50:29 -040081 self.stdin = kwargs.get('stdin', None)
Edward Lemur2d6b67c2019-08-23 22:25:41 +000082 self.kwargs = kwargs.copy()
Edward Lesmes8e282792018-04-03 18:50:29 -040083 self.kwargs['stdout'] = subprocess.PIPE
84 self.kwargs['stderr'] = subprocess.STDOUT
85 self.kwargs['stdin'] = subprocess.PIPE
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000086 self.message = message
87 self.info = None
Edward Lemur940c2822019-08-23 00:34:25 +000088 self.python3 = python3
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000089
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000090
Edward Lesmes8e282792018-04-03 18:50:29 -040091# Adapted from
92# https://github.com/google/gtest-parallel/blob/master/gtest_parallel.py#L37
93#
94# An object that catches SIGINT sent to the Python process and notices
95# if processes passed to wait() die by SIGINT (we need to look for
96# both of those cases, because pressing Ctrl+C can result in either
97# the main process or one of the subprocesses getting the signal).
98#
99# Before a SIGINT is seen, wait(p) will simply call p.wait() and
100# return the result. Once a SIGINT has been seen (in the main process
101# or a subprocess, including the one the current call is waiting for),
Edward Lemur9a5bb612019-09-26 02:01:52 +0000102# wait(p) will call p.terminate().
Edward Lesmes8e282792018-04-03 18:50:29 -0400103class SigintHandler(object):
Edward Lesmes8e282792018-04-03 18:50:29 -0400104 sigint_returncodes = {-signal.SIGINT, # Unix
105 -1073741510, # Windows
106 }
107 def __init__(self):
108 self.__lock = threading.Lock()
109 self.__processes = set()
110 self.__got_sigint = False
Edward Lemur9a5bb612019-09-26 02:01:52 +0000111 self.__previous_signal = signal.signal(signal.SIGINT, self.interrupt)
Edward Lesmes8e282792018-04-03 18:50:29 -0400112
113 def __on_sigint(self):
114 self.__got_sigint = True
115 while self.__processes:
116 try:
117 self.__processes.pop().terminate()
118 except OSError:
119 pass
120
Edward Lemur9a5bb612019-09-26 02:01:52 +0000121 def interrupt(self, signal_num, frame):
Edward Lesmes8e282792018-04-03 18:50:29 -0400122 with self.__lock:
123 self.__on_sigint()
Edward Lemur9a5bb612019-09-26 02:01:52 +0000124 self.__previous_signal(signal_num, frame)
Edward Lesmes8e282792018-04-03 18:50:29 -0400125
126 def got_sigint(self):
127 with self.__lock:
128 return self.__got_sigint
129
130 def wait(self, p, stdin):
131 with self.__lock:
132 if self.__got_sigint:
133 p.terminate()
134 self.__processes.add(p)
135 stdout, stderr = p.communicate(stdin)
136 code = p.returncode
137 with self.__lock:
138 self.__processes.discard(p)
139 if code in self.sigint_returncodes:
140 self.__on_sigint()
Edward Lesmes8e282792018-04-03 18:50:29 -0400141 return stdout, stderr
142
143sigint_handler = SigintHandler()
144
145
Edward Lemurecc27072020-01-06 16:42:34 +0000146class Timer(object):
147 def __init__(self, timeout, fn):
148 self.completed = False
149 self._fn = fn
150 self._timer = threading.Timer(timeout, self._onTimer) if timeout else None
151
152 def __enter__(self):
153 if self._timer:
154 self._timer.start()
155 return self
156
157 def __exit__(self, _type, _value, _traceback):
158 if self._timer:
159 self._timer.cancel()
160
161 def _onTimer(self):
162 self._fn()
163 self.completed = True
164
165
Edward Lesmes8e282792018-04-03 18:50:29 -0400166class ThreadPool(object):
Edward Lemurecc27072020-01-06 16:42:34 +0000167 def __init__(self, pool_size=None, timeout=None):
168 self.timeout = timeout
Edward Lesmes8e282792018-04-03 18:50:29 -0400169 self._pool_size = pool_size or multiprocessing.cpu_count()
170 self._messages = []
171 self._messages_lock = threading.Lock()
172 self._tests = []
173 self._tests_lock = threading.Lock()
174 self._nonparallel_tests = []
175
Edward Lemurecc27072020-01-06 16:42:34 +0000176 def _GetCommand(self, test):
Edward Lemur940c2822019-08-23 00:34:25 +0000177 vpython = 'vpython'
178 if test.python3:
179 vpython += '3'
180 if sys.platform == 'win32':
181 vpython += '.bat'
Edward Lesmes8e282792018-04-03 18:50:29 -0400182
183 cmd = test.cmd
184 if cmd[0] == 'python':
185 cmd = list(cmd)
186 cmd[0] = vpython
187 elif cmd[0].endswith('.py'):
188 cmd = [vpython] + cmd
189
Edward Lemur336e51f2019-11-14 21:42:04 +0000190 # On Windows, scripts on the current directory take precedence over PATH, so
191 # that when testing depot_tools on Windows, calling `vpython.bat` will
192 # execute the copy of vpython of the depot_tools under test instead of the
193 # one in the bot.
194 # As a workaround, we run the tests from the parent directory instead.
195 if (cmd[0] == vpython and
196 'cwd' in test.kwargs and
197 os.path.basename(test.kwargs['cwd']) == 'depot_tools'):
198 test.kwargs['cwd'] = os.path.dirname(test.kwargs['cwd'])
199 cmd[1] = os.path.join('depot_tools', cmd[1])
200
Edward Lemurecc27072020-01-06 16:42:34 +0000201 return cmd
202
203 def _RunWithTimeout(self, cmd, stdin, kwargs):
204 p = subprocess.Popen(cmd, **kwargs)
205 with Timer(self.timeout, p.terminate) as timer:
206 stdout, _ = sigint_handler.wait(p, stdin)
207 if timer.completed:
208 stdout = 'Process timed out after %ss\n%s' % (self.timeout, stdout)
209 return p.returncode, stdout
210
211 def CallCommand(self, test):
212 """Runs an external program.
213
Edward Lemura5799e32020-01-17 19:26:51 +0000214 This function converts invocation of .py files and invocations of 'python'
Edward Lemurecc27072020-01-06 16:42:34 +0000215 to vpython invocations.
216 """
217 cmd = self._GetCommand(test)
Edward Lesmes8e282792018-04-03 18:50:29 -0400218 try:
Edward Lemurecc27072020-01-06 16:42:34 +0000219 start = time_time()
220 returncode, stdout = self._RunWithTimeout(cmd, test.stdin, test.kwargs)
221 duration = time_time() - start
Edward Lemur7cf94382019-11-15 22:36:41 +0000222 except Exception:
Edward Lemurecc27072020-01-06 16:42:34 +0000223 duration = time_time() - start
Edward Lesmes8e282792018-04-03 18:50:29 -0400224 return test.message(
Edward Lemur7cf94382019-11-15 22:36:41 +0000225 '%s\n%s exec failure (%4.2fs)\n%s' % (
226 test.name, ' '.join(cmd), duration, traceback.format_exc()))
Edward Lemurde9e3ca2019-10-24 21:13:31 +0000227
Edward Lemurecc27072020-01-06 16:42:34 +0000228 if returncode != 0:
Edward Lesmes8e282792018-04-03 18:50:29 -0400229 return test.message(
Edward Lemur7cf94382019-11-15 22:36:41 +0000230 '%s\n%s (%4.2fs) failed\n%s' % (
231 test.name, ' '.join(cmd), duration, stdout))
Edward Lemurecc27072020-01-06 16:42:34 +0000232
Edward Lesmes8e282792018-04-03 18:50:29 -0400233 if test.info:
Edward Lemur7cf94382019-11-15 22:36:41 +0000234 return test.info('%s\n%s (%4.2fs)' % (test.name, ' '.join(cmd), duration))
Edward Lesmes8e282792018-04-03 18:50:29 -0400235
236 def AddTests(self, tests, parallel=True):
237 if parallel:
238 self._tests.extend(tests)
239 else:
240 self._nonparallel_tests.extend(tests)
241
242 def RunAsync(self):
243 self._messages = []
244
245 def _WorkerFn():
246 while True:
247 test = None
248 with self._tests_lock:
249 if not self._tests:
250 break
251 test = self._tests.pop()
252 result = self.CallCommand(test)
253 if result:
254 with self._messages_lock:
255 self._messages.append(result)
256
257 def _StartDaemon():
258 t = threading.Thread(target=_WorkerFn)
259 t.daemon = True
260 t.start()
261 return t
262
263 while self._nonparallel_tests:
264 test = self._nonparallel_tests.pop()
265 result = self.CallCommand(test)
266 if result:
267 self._messages.append(result)
268
269 if self._tests:
270 threads = [_StartDaemon() for _ in range(self._pool_size)]
271 for worker in threads:
272 worker.join()
273
274 return self._messages
275
276
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000277def normpath(path):
278 '''Version of os.path.normpath that also changes backward slashes to
279 forward slashes when not running on Windows.
280 '''
281 # This is safe to always do because the Windows version of os.path.normpath
282 # will replace forward slashes with backward slashes.
283 path = path.replace(os.sep, '/')
284 return os.path.normpath(path)
285
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000286
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000287def _RightHandSideLinesImpl(affected_files):
288 """Implements RightHandSideLines for InputApi and GclChange."""
289 for af in affected_files:
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000290 lines = af.ChangedContents()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000291 for line in lines:
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000292 yield (af, line[0], line[1])
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000293
294
Edward Lemur6eb1d322020-02-27 22:20:15 +0000295def prompt_should_continue(prompt_string):
296 sys.stdout.write(prompt_string)
297 response = sys.stdin.readline().strip().lower()
298 return response in ('y', 'yes')
dpranke@chromium.org5ac21012011-03-16 02:58:25 +0000299
300
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000301# Top level object so multiprocessing can pickle
302# Public access through OutputApi object.
303class _PresubmitResult(object):
304 """Base class for result objects."""
305 fatal = False
306 should_prompt = False
307
308 def __init__(self, message, items=None, long_text=''):
309 """
310 message: A short one-line message to indicate errors.
311 items: A list of short strings to indicate where errors occurred.
312 long_text: multi-line text output, e.g. from another tool
313 """
314 self._message = message
315 self._items = items or []
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000316 self._long_text = long_text.rstrip()
317
Edward Lemur6eb1d322020-02-27 22:20:15 +0000318 def handle(self):
319 sys.stdout.write(self._message)
320 sys.stdout.write('\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000321 for index, item in enumerate(self._items):
Edward Lemur6eb1d322020-02-27 22:20:15 +0000322 sys.stdout.write(' ')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000323 # Write separately in case it's unicode.
Edward Lemur6eb1d322020-02-27 22:20:15 +0000324 sys.stdout.write(str(item))
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000325 if index < len(self._items) - 1:
Edward Lemur6eb1d322020-02-27 22:20:15 +0000326 sys.stdout.write(' \\')
327 sys.stdout.write('\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000328 if self._long_text:
Edward Lemur6eb1d322020-02-27 22:20:15 +0000329 sys.stdout.write('\n***************\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000330 # Write separately in case it's unicode.
Edward Lemur6eb1d322020-02-27 22:20:15 +0000331 sys.stdout.write(self._long_text)
332 sys.stdout.write('\n***************\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000333
Debrian Figueroadd2737e2019-06-21 23:50:13 +0000334 def json_format(self):
335 return {
336 'message': self._message,
Debrian Figueroa6095d402019-06-28 18:47:18 +0000337 'items': [str(item) for item in self._items],
Debrian Figueroadd2737e2019-06-21 23:50:13 +0000338 'long_text': self._long_text,
339 'fatal': self.fatal
340 }
341
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000342
343# Top level object so multiprocessing can pickle
344# Public access through OutputApi object.
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000345class _PresubmitError(_PresubmitResult):
346 """A hard presubmit error."""
347 fatal = True
348
349
350# Top level object so multiprocessing can pickle
351# Public access through OutputApi object.
352class _PresubmitPromptWarning(_PresubmitResult):
353 """An warning that prompts the user if they want to continue."""
354 should_prompt = True
355
356
357# Top level object so multiprocessing can pickle
358# Public access through OutputApi object.
359class _PresubmitNotifyResult(_PresubmitResult):
360 """Just print something to the screen -- but it's not even a warning."""
361 pass
362
363
364# Top level object so multiprocessing can pickle
365# Public access through OutputApi object.
366class _MailTextResult(_PresubmitResult):
367 """A warning that should be included in the review request email."""
368 def __init__(self, *args, **kwargs):
369 super(_MailTextResult, self).__init__()
370 raise NotImplementedError()
371
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000372class GerritAccessor(object):
373 """Limited Gerrit functionality for canned presubmit checks to work.
374
375 To avoid excessive Gerrit calls, caches the results.
376 """
377
378 def __init__(self, host):
379 self.host = host
380 self.cache = {}
381
382 def _FetchChangeDetail(self, issue):
383 # Separate function to be easily mocked in tests.
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +0100384 try:
385 return gerrit_util.GetChangeDetail(
386 self.host, str(issue),
Aaron Gable6f5a8d92017-04-18 14:49:05 -0700387 ['ALL_REVISIONS', 'DETAILED_LABELS', 'ALL_COMMITS'])
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +0100388 except gerrit_util.GerritError as e:
389 if e.http_status == 404:
390 raise Exception('Either Gerrit issue %s doesn\'t exist, or '
391 'no credentials to fetch issue details' % issue)
392 raise
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000393
394 def GetChangeInfo(self, issue):
395 """Returns labels and all revisions (patchsets) for this issue.
396
397 The result is a dictionary according to Gerrit REST Api.
398 https://gerrit-review.googlesource.com/Documentation/rest-api.html
399
400 However, API isn't very clear what's inside, so see tests for example.
401 """
402 assert issue
403 cache_key = int(issue)
404 if cache_key not in self.cache:
405 self.cache[cache_key] = self._FetchChangeDetail(issue)
406 return self.cache[cache_key]
407
408 def GetChangeDescription(self, issue, patchset=None):
409 """If patchset is none, fetches current patchset."""
410 info = self.GetChangeInfo(issue)
411 # info is a reference to cache. We'll modify it here adding description to
412 # it to the right patchset, if it is not yet there.
413
414 # Find revision info for the patchset we want.
415 if patchset is not None:
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +0000416 for rev, rev_info in info['revisions'].items():
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000417 if str(rev_info['_number']) == str(patchset):
418 break
419 else:
420 raise Exception('patchset %s doesn\'t exist in issue %s' % (
421 patchset, issue))
422 else:
423 rev = info['current_revision']
424 rev_info = info['revisions'][rev]
425
Andrii Shyshkalov9c3a4642017-01-24 17:41:22 +0100426 return rev_info['commit']['message']
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000427
Mun Yong Jang603d01e2017-12-19 16:38:30 -0800428 def GetDestRef(self, issue):
429 ref = self.GetChangeInfo(issue)['branch']
430 if not ref.startswith('refs/'):
431 # NOTE: it is possible to create 'refs/x' branch,
432 # aka 'refs/heads/refs/x'. However, this is ill-advised.
433 ref = 'refs/heads/%s' % ref
434 return ref
435
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000436 def GetChangeOwner(self, issue):
437 return self.GetChangeInfo(issue)['owner']['email']
438
439 def GetChangeReviewers(self, issue, approving_only=True):
Aaron Gable8b478f02017-07-31 15:33:19 -0700440 changeinfo = self.GetChangeInfo(issue)
441 if approving_only:
442 labelinfo = changeinfo.get('labels', {}).get('Code-Review', {})
443 values = labelinfo.get('values', {}).keys()
444 try:
445 max_value = max(int(v) for v in values)
446 reviewers = [r for r in labelinfo.get('all', [])
447 if r.get('value', 0) == max_value]
448 except ValueError: # values is the empty list
449 reviewers = []
450 else:
451 reviewers = changeinfo.get('reviewers', {}).get('REVIEWER', [])
452 return [r.get('email') for r in reviewers]
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000453
Edward Lemure4d329c2020-02-03 20:41:18 +0000454 def UpdateDescription(self, description, issue):
455 gerrit_util.SetCommitMessage(self.host, issue, description, notify='NONE')
456
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000457
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000458class OutputApi(object):
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000459 """An instance of OutputApi gets passed to presubmit scripts so that they
460 can output various types of results.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000461 """
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000462 PresubmitResult = _PresubmitResult
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000463 PresubmitError = _PresubmitError
464 PresubmitPromptWarning = _PresubmitPromptWarning
465 PresubmitNotifyResult = _PresubmitNotifyResult
466 MailTextResult = _MailTextResult
467
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000468 def __init__(self, is_committing):
469 self.is_committing = is_committing
Daniel Cheng7227d212017-11-17 08:12:37 -0800470 self.more_cc = []
471
472 def AppendCC(self, cc):
473 """Appends a user to cc for this change."""
474 self.more_cc.append(cc)
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000475
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000476 def PresubmitPromptOrNotify(self, *args, **kwargs):
477 """Warn the user when uploading, but only notify if committing."""
478 if self.is_committing:
479 return self.PresubmitNotifyResult(*args, **kwargs)
480 return self.PresubmitPromptWarning(*args, **kwargs)
481
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000482
483class InputApi(object):
484 """An instance of this object is passed to presubmit scripts so they can
485 know stuff about the change they're looking at.
486 """
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000487 # Method could be a function
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800488 # pylint: disable=no-self-use
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000489
maruel@chromium.org3410d912009-06-09 20:56:16 +0000490 # File extensions that are considered source files from a style guide
491 # perspective. Don't modify this list from a presubmit script!
maruel@chromium.orgc33455a2011-06-24 19:14:18 +0000492 #
493 # Files without an extension aren't included in the list. If you want to
Edward Lemura5799e32020-01-17 19:26:51 +0000494 # filter them as source files, add r'(^|.*?[\\\/])[^.]+$' to the white list.
maruel@chromium.orgc33455a2011-06-24 19:14:18 +0000495 # Note that ALL CAPS files are black listed in DEFAULT_BLACK_LIST below.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000496 DEFAULT_WHITE_LIST = (
497 # C++ and friends
Edward Lemura5799e32020-01-17 19:26:51 +0000498 r'.+\.c$', r'.+\.cc$', r'.+\.cpp$', r'.+\.h$', r'.+\.m$', r'.+\.mm$',
499 r'.+\.inl$', r'.+\.asm$', r'.+\.hxx$', r'.+\.hpp$', r'.+\.s$', r'.+\.S$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000500 # Scripts
Edward Lemura5799e32020-01-17 19:26:51 +0000501 r'.+\.js$', r'.+\.py$', r'.+\.sh$', r'.+\.rb$', r'.+\.pl$', r'.+\.pm$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000502 # Other
Edward Lemura5799e32020-01-17 19:26:51 +0000503 r'.+\.java$', r'.+\.mk$', r'.+\.am$', r'.+\.css$', r'.+\.mojom$',
504 r'.+\.fidl$'
maruel@chromium.org3410d912009-06-09 20:56:16 +0000505 )
506
507 # Path regexp that should be excluded from being considered containing source
508 # files. Don't modify this list from a presubmit script!
509 DEFAULT_BLACK_LIST = (
Edward Lemura5799e32020-01-17 19:26:51 +0000510 r'testing_support[\\\/]google_appengine[\\\/].*',
511 r'.*\bexperimental[\\\/].*',
Kent Tamura179dd1e2018-04-26 15:07:41 +0900512 # Exclude third_party/.* but NOT third_party/{WebKit,blink}
513 # (crbug.com/539768 and crbug.com/836555).
Edward Lemura5799e32020-01-17 19:26:51 +0000514 r'.*\bthird_party[\\\/](?!(WebKit|blink)[\\\/]).*',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000515 # Output directories (just in case)
Edward Lemura5799e32020-01-17 19:26:51 +0000516 r'.*\bDebug[\\\/].*',
517 r'.*\bRelease[\\\/].*',
518 r'.*\bxcodebuild[\\\/].*',
519 r'.*\bout[\\\/].*',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000520 # All caps files like README and LICENCE.
Edward Lemura5799e32020-01-17 19:26:51 +0000521 r'.*\b[A-Z0-9_]{2,}$',
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000522 # SCM (can happen in dual SCM configuration). (Slightly over aggressive)
Edward Lemura5799e32020-01-17 19:26:51 +0000523 r'(|.*[\\\/])\.git[\\\/].*',
524 r'(|.*[\\\/])\.svn[\\\/].*',
maruel@chromium.org7ccb4bb2011-11-07 20:26:20 +0000525 # There is no point in processing a patch file.
Edward Lemura5799e32020-01-17 19:26:51 +0000526 r'.+\.diff$',
527 r'.+\.patch$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000528 )
529
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000530 def __init__(self, change, presubmit_path, is_committing,
Edward Lesmes8e282792018-04-03 18:50:29 -0400531 verbose, gerrit_obj, dry_run=None, thread_pool=None, parallel=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000532 """Builds an InputApi object.
533
534 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000535 change: A presubmit.Change object.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000536 presubmit_path: The path to the presubmit script being processed.
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000537 is_committing: True if the change is about to be committed.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000538 gerrit_obj: provides basic Gerrit codereview functionality.
539 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -0400540 parallel: if true, all tests reported via input_api.RunTests for all
541 PRESUBMIT files will be run in parallel.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000542 """
maruel@chromium.org9711bba2009-05-22 23:51:39 +0000543 # Version number of the presubmit_support script.
544 self.version = [int(x) for x in __version__.split('.')]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000545 self.change = change
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000546 self.is_committing = is_committing
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000547 self.gerrit = gerrit_obj
tandrii@chromium.org57bafac2016-04-28 05:09:03 +0000548 self.dry_run = dry_run
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000549
Edward Lesmes8e282792018-04-03 18:50:29 -0400550 self.parallel = parallel
551 self.thread_pool = thread_pool or ThreadPool()
552
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000553 # We expose various modules and functions as attributes of the input_api
554 # so that presubmit scripts don't have to import them.
Takeshi Yoshino07a6bea2017-08-02 02:44:06 +0900555 self.ast = ast
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000556 self.basename = os.path.basename
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000557 self.cpplint = cpplint
dcheng091b7db2016-06-16 01:27:51 -0700558 self.fnmatch = fnmatch
Yoshisato Yanagisawa04600b42019-03-15 03:03:41 +0000559 self.gclient_paths = gclient_paths
Yoshisato Yanagisawa57dd17b2019-03-22 09:10:29 +0000560 # TODO(yyanagisawa): stop exposing this when python3 become default.
561 # Since python3's tempfile has TemporaryDirectory, we do not need this.
562 self.temporary_directory = gclient_utils.temporary_directory
dpranke@chromium.org17cc2442012-10-17 21:12:09 +0000563 self.glob = glob.glob
maruel@chromium.orgfb11c7b2010-03-18 18:22:14 +0000564 self.json = json
maruel@chromium.org6fba34d2011-06-02 13:45:12 +0000565 self.logging = logging.getLogger('PRESUBMIT')
maruel@chromium.org2b5ce562011-03-31 16:15:44 +0000566 self.os_listdir = os.listdir
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000567 self.os_path = os.path
pgervais@chromium.orgbd0cace2014-10-02 23:23:46 +0000568 self.os_stat = os.stat
Yoshisato Yanagisawa406de132018-06-29 05:43:25 +0000569 self.os_walk = os.walk
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000570 self.re = re
571 self.subprocess = subprocess
Edward Lemurb9830242019-10-30 22:19:20 +0000572 self.sys = sys
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000573 self.tempfile = tempfile
dpranke@chromium.org0d1bdea2011-03-24 22:54:38 +0000574 self.time = time
maruel@chromium.org1487d532009-06-06 00:22:57 +0000575 self.unittest = unittest
Edward Lemurb9830242019-10-30 22:19:20 +0000576 if sys.version_info.major == 2:
577 self.urllib2 = urllib2
Edward Lemur16af3562019-10-17 22:11:33 +0000578 self.urllib_request = urllib_request
579 self.urllib_error = urllib_error
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000580
Robert Iannucci50258932018-03-19 10:30:59 -0700581 self.is_windows = sys.platform == 'win32'
582
Edward Lemurb9646622019-10-25 20:57:35 +0000583 # Set python_executable to 'vpython' in order to allow scripts in other
584 # repos (e.g. src.git) to automatically pick up that repo's .vpython file,
585 # instead of inheriting the one in depot_tools.
586 self.python_executable = 'vpython'
maruel@chromium.orgc0b22972009-06-25 16:19:14 +0000587 self.environ = os.environ
588
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000589 # InputApi.platform is the platform you're currently running on.
590 self.platform = sys.platform
591
iannucci@chromium.org0af3bb32015-06-12 20:44:35 +0000592 self.cpu_count = multiprocessing.cpu_count()
593
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000594 # The local path of the currently-being-processed presubmit script.
maruel@chromium.org3d235242009-05-15 12:40:48 +0000595 self._current_presubmit_path = os.path.dirname(presubmit_path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000596
597 # We carry the canned checks so presubmit scripts can easily use them.
598 self.canned_checks = presubmit_canned_checks
599
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +0100600 # Temporary files we must manually remove at the end of a run.
601 self._named_temporary_files = []
Jochen Eisinger72606f82017-04-04 10:44:18 +0200602
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000603 # TODO(dpranke): figure out a list of all approved owners for a repo
604 # in order to be able to handle wildcard OWNERS files?
605 self.owners_db = owners.Database(change.RepositoryRoot(),
Edward Lemurb9830242019-10-30 22:19:20 +0000606 fopen=open, os_path=self.os_path)
Jochen Eisinger76f5fc62017-04-07 16:27:46 +0200607 self.owners_finder = owners_finder.OwnersFinder
maruel@chromium.org899e1c12011-04-07 17:03:18 +0000608 self.verbose = verbose
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000609 self.Command = CommandData
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000610
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000611 # Replace <hash_map> and <hash_set> as headers that need to be included
Edward Lemura5799e32020-01-17 19:26:51 +0000612 # with 'base/containers/hash_tables.h' instead.
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000613 # Access to a protected member _XX of a client class
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800614 # pylint: disable=protected-access
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000615 self.cpplint._re_pattern_templates = [
danakj@chromium.org18278522013-06-11 22:42:32 +0000616 (a, b, 'base/containers/hash_tables.h')
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000617 if header in ('<hash_map>', '<hash_set>') else (a, b, header)
618 for (a, b, header) in cpplint._re_pattern_templates
619 ]
620
Edward Lemurecc27072020-01-06 16:42:34 +0000621 def SetTimeout(self, timeout):
622 self.thread_pool.timeout = timeout
623
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000624 def PresubmitLocalPath(self):
625 """Returns the local path of the presubmit script currently being run.
626
627 This is useful if you don't want to hard-code absolute paths in the
628 presubmit script. For example, It can be used to find another file
629 relative to the PRESUBMIT.py script, so the whole tree can be branched and
630 the presubmit script still works, without editing its content.
631 """
maruel@chromium.org3d235242009-05-15 12:40:48 +0000632 return self._current_presubmit_path
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000633
agable0b65e732016-11-22 09:25:46 -0800634 def AffectedFiles(self, include_deletes=True, file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000635 """Same as input_api.change.AffectedFiles() except only lists files
636 (and optionally directories) in the same directory as the current presubmit
Bruce Dawson7a0b07a2020-04-23 17:14:40 +0000637 script, or subdirectories thereof. Note that files are listed using the OS
638 path separator, so backslashes are used as separators on Windows.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000639 """
Edward Lemura5799e32020-01-17 19:26:51 +0000640 dir_with_slash = normpath('%s/' % self.PresubmitLocalPath())
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000641 if len(dir_with_slash) == 1:
642 dir_with_slash = ''
sail@chromium.org5538e022011-05-12 17:53:16 +0000643
Edward Lemurb9830242019-10-30 22:19:20 +0000644 return list(filter(
maruel@chromium.org4661e0c2009-06-04 00:45:26 +0000645 lambda x: normpath(x.AbsoluteLocalPath()).startswith(dir_with_slash),
Edward Lemurb9830242019-10-30 22:19:20 +0000646 self.change.AffectedFiles(include_deletes, file_filter)))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000647
agable0b65e732016-11-22 09:25:46 -0800648 def LocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000649 """Returns local paths of input_api.AffectedFiles()."""
agable0b65e732016-11-22 09:25:46 -0800650 paths = [af.LocalPath() for af in self.AffectedFiles()]
Edward Lemura5799e32020-01-17 19:26:51 +0000651 logging.debug('LocalPaths: %s', paths)
pgervais@chromium.org2f64f782014-04-25 00:12:33 +0000652 return paths
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000653
agable0b65e732016-11-22 09:25:46 -0800654 def AbsoluteLocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000655 """Returns absolute local paths of input_api.AffectedFiles()."""
agable0b65e732016-11-22 09:25:46 -0800656 return [af.AbsoluteLocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000657
John Budorick16162372018-04-18 10:39:53 -0700658 def AffectedTestableFiles(self, include_deletes=None, **kwargs):
agable0b65e732016-11-22 09:25:46 -0800659 """Same as input_api.change.AffectedTestableFiles() except only lists files
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000660 in the same directory as the current presubmit script, or subdirectories
661 thereof.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000662 """
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000663 if include_deletes is not None:
Edward Lemura5799e32020-01-17 19:26:51 +0000664 warn('AffectedTestableFiles(include_deletes=%s)'
665 ' is deprecated and ignored' % str(include_deletes),
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000666 category=DeprecationWarning,
667 stacklevel=2)
Edward Lemurb9830242019-10-30 22:19:20 +0000668 return list(filter(
669 lambda x: x.IsTestableFile(),
670 self.AffectedFiles(include_deletes=False, **kwargs)))
agable0b65e732016-11-22 09:25:46 -0800671
672 def AffectedTextFiles(self, include_deletes=None):
673 """An alias to AffectedTestableFiles for backwards compatibility."""
674 return self.AffectedTestableFiles(include_deletes=include_deletes)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000675
maruel@chromium.org3410d912009-06-09 20:56:16 +0000676 def FilterSourceFile(self, affected_file, white_list=None, black_list=None):
Edward Lemura5799e32020-01-17 19:26:51 +0000677 """Filters out files that aren't considered 'source file'.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000678
679 If white_list or black_list is None, InputApi.DEFAULT_WHITE_LIST
680 and InputApi.DEFAULT_BLACK_LIST is used respectively.
681
682 The lists will be compiled as regular expression and
683 AffectedFile.LocalPath() needs to pass both list.
684
685 Note: Copy-paste this function to suit your needs or use a lambda function.
686 """
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000687 def Find(affected_file, items):
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000688 local_path = affected_file.LocalPath()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000689 for item in items:
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000690 if self.re.match(item, local_path):
maruel@chromium.org3410d912009-06-09 20:56:16 +0000691 return True
692 return False
693 return (Find(affected_file, white_list or self.DEFAULT_WHITE_LIST) and
694 not Find(affected_file, black_list or self.DEFAULT_BLACK_LIST))
695
696 def AffectedSourceFiles(self, source_file):
agable0b65e732016-11-22 09:25:46 -0800697 """Filter the list of AffectedTestableFiles by the function source_file.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000698
699 If source_file is None, InputApi.FilterSourceFile() is used.
700 """
701 if not source_file:
702 source_file = self.FilterSourceFile
Edward Lemurb9830242019-10-30 22:19:20 +0000703 return list(filter(source_file, self.AffectedTestableFiles()))
maruel@chromium.org3410d912009-06-09 20:56:16 +0000704
705 def RightHandSideLines(self, source_file_filter=None):
Edward Lemura5799e32020-01-17 19:26:51 +0000706 """An iterator over all text lines in 'new' version of changed files.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000707
708 Only lists lines from new or modified text files in the change that are
709 contained by the directory of the currently executing presubmit script.
710
711 This is useful for doing line-by-line regex checks, like checking for
712 trailing whitespace.
713
714 Yields:
715 a 3 tuple:
716 the AffectedFile instance of the current file;
717 integer line number (1-based); and
718 the contents of the line as a string.
maruel@chromium.org1487d532009-06-06 00:22:57 +0000719
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000720 Note: The carriage return (LF or CR) is stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000721 """
maruel@chromium.org3410d912009-06-09 20:56:16 +0000722 files = self.AffectedSourceFiles(source_file_filter)
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000723 return _RightHandSideLinesImpl(files)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000724
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000725 def ReadFile(self, file_item, mode='r'):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000726 """Reads an arbitrary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000727
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000728 Deny reading anything outside the repository.
729 """
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000730 if isinstance(file_item, AffectedFile):
731 file_item = file_item.AbsoluteLocalPath()
732 if not file_item.startswith(self.change.RepositoryRoot()):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000733 raise IOError('Access outside the repository root is denied.')
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +0000734 return gclient_utils.FileRead(file_item, mode)
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000735
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +0100736 def CreateTemporaryFile(self, **kwargs):
737 """Returns a named temporary file that must be removed with a call to
738 RemoveTemporaryFiles().
739
740 All keyword arguments are forwarded to tempfile.NamedTemporaryFile(),
741 except for |delete|, which is always set to False.
742
743 Presubmit checks that need to create a temporary file and pass it for
744 reading should use this function instead of NamedTemporaryFile(), as
745 Windows fails to open a file that is already open for writing.
746
747 with input_api.CreateTemporaryFile() as f:
748 f.write('xyz')
749 f.close()
750 input_api.subprocess.check_output(['script-that', '--reads-from',
751 f.name])
752
753
754 Note that callers of CreateTemporaryFile() should not worry about removing
755 any temporary file; this is done transparently by the presubmit handling
756 code.
757 """
758 if 'delete' in kwargs:
759 # Prevent users from passing |delete|; we take care of file deletion
760 # ourselves and this prevents unintuitive error messages when we pass
761 # delete=False and 'delete' is also in kwargs.
762 raise TypeError('CreateTemporaryFile() does not take a "delete" '
763 'argument, file deletion is handled automatically by '
764 'the same presubmit_support code that creates InputApi '
765 'objects.')
766 temp_file = self.tempfile.NamedTemporaryFile(delete=False, **kwargs)
767 self._named_temporary_files.append(temp_file.name)
768 return temp_file
769
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000770 @property
771 def tbr(self):
772 """Returns if a change is TBR'ed."""
Jeremy Romandce22502017-06-20 15:37:29 -0400773 return 'TBR' in self.change.tags or self.change.TBRsFromDescription()
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000774
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000775 def RunTests(self, tests_mix, parallel=True):
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000776 tests = []
777 msgs = []
778 for t in tests_mix:
Edward Lesmes8e282792018-04-03 18:50:29 -0400779 if isinstance(t, OutputApi.PresubmitResult) and t:
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000780 msgs.append(t)
781 else:
782 assert issubclass(t.message, _PresubmitResult)
783 tests.append(t)
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000784 if self.verbose:
785 t.info = _PresubmitNotifyResult
Edward Lemur1037c742018-05-01 18:56:04 -0400786 if not t.kwargs.get('cwd'):
787 t.kwargs['cwd'] = self.PresubmitLocalPath()
Edward Lesmes8e282792018-04-03 18:50:29 -0400788 self.thread_pool.AddTests(tests, parallel)
Edward Lemur21000eb2019-05-24 23:25:58 +0000789 # When self.parallel is True (i.e. --parallel is passed as an option)
790 # RunTests doesn't actually run tests. It adds them to a ThreadPool that
791 # will run all tests once all PRESUBMIT files are processed.
792 # Otherwise, it will run them and return the results.
793 if not self.parallel:
Edward Lesmes8e282792018-04-03 18:50:29 -0400794 msgs.extend(self.thread_pool.RunAsync())
795 return msgs
scottmg86099d72016-09-01 09:16:51 -0700796
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000797
nick@chromium.orgff526192013-06-10 19:30:26 +0000798class _DiffCache(object):
799 """Caches diffs retrieved from a particular SCM."""
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000800 def __init__(self, upstream=None):
801 """Stores the upstream revision against which all diffs will be computed."""
802 self._upstream = upstream
nick@chromium.orgff526192013-06-10 19:30:26 +0000803
804 def GetDiff(self, path, local_root):
805 """Get the diff for a particular path."""
806 raise NotImplementedError()
807
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700808 def GetOldContents(self, path, local_root):
809 """Get the old version for a particular path."""
810 raise NotImplementedError()
811
nick@chromium.orgff526192013-06-10 19:30:26 +0000812
nick@chromium.orgff526192013-06-10 19:30:26 +0000813class _GitDiffCache(_DiffCache):
814 """DiffCache implementation for git; gets all file diffs at once."""
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000815 def __init__(self, upstream):
816 super(_GitDiffCache, self).__init__(upstream=upstream)
nick@chromium.orgff526192013-06-10 19:30:26 +0000817 self._diffs_by_file = None
818
819 def GetDiff(self, path, local_root):
820 if not self._diffs_by_file:
821 # Compute a single diff for all files and parse the output; should
822 # with git this is much faster than computing one diff for each file.
823 diffs = {}
824
825 # Don't specify any filenames below, because there are command line length
826 # limits on some platforms and GenerateDiff would fail.
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000827 unified_diff = scm.GIT.GenerateDiff(local_root, files=[], full_move=True,
828 branch=self._upstream)
nick@chromium.orgff526192013-06-10 19:30:26 +0000829
830 # This regex matches the path twice, separated by a space. Note that
831 # filename itself may contain spaces.
832 file_marker = re.compile('^diff --git (?P<filename>.*) (?P=filename)$')
833 current_diff = []
834 keep_line_endings = True
835 for x in unified_diff.splitlines(keep_line_endings):
836 match = file_marker.match(x)
837 if match:
838 # Marks the start of a new per-file section.
839 diffs[match.group('filename')] = current_diff = [x]
840 elif x.startswith('diff --git'):
841 raise PresubmitFailure('Unexpected diff line: %s' % x)
842 else:
843 current_diff.append(x)
844
845 self._diffs_by_file = dict(
846 (normpath(path), ''.join(diff)) for path, diff in diffs.items())
847
848 if path not in self._diffs_by_file:
849 raise PresubmitFailure(
850 'Unified diff did not contain entry for file %s' % path)
851
852 return self._diffs_by_file[path]
853
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700854 def GetOldContents(self, path, local_root):
855 return scm.GIT.GetOldContents(local_root, path, branch=self._upstream)
856
nick@chromium.orgff526192013-06-10 19:30:26 +0000857
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000858class AffectedFile(object):
859 """Representation of a file in a change."""
nick@chromium.orgff526192013-06-10 19:30:26 +0000860
861 DIFF_CACHE = _DiffCache
862
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000863 # Method could be a function
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800864 # pylint: disable=no-self-use
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000865 def __init__(self, path, action, repository_root, diff_cache):
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000866 self._path = path
867 self._action = action
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000868 self._local_root = repository_root
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000869 self._is_directory = None
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000870 self._cached_changed_contents = None
871 self._cached_new_contents = None
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000872 self._diff_cache = diff_cache
tobiasjs2836bcf2016-08-16 04:08:16 -0700873 logging.debug('%s(%s)', self.__class__.__name__, self._path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000874
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000875 def LocalPath(self):
876 """Returns the path of this file on the local disk relative to client root.
Andrew Grieve92b8b992017-11-02 09:42:24 -0400877
878 This should be used for error messages but not for accessing files,
879 because presubmit checks are run with CWD=PresubmitLocalPath() (which is
880 often != client root).
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000881 """
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000882 return normpath(self._path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000883
884 def AbsoluteLocalPath(self):
885 """Returns the absolute path of this file on the local disk.
886 """
chase@chromium.org8e416c82009-10-06 04:30:44 +0000887 return os.path.abspath(os.path.join(self._local_root, self.LocalPath()))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000888
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000889 def Action(self):
890 """Returns the action on this opened file, e.g. A, M, D, etc."""
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000891 return self._action
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000892
agable0b65e732016-11-22 09:25:46 -0800893 def IsTestableFile(self):
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000894 """Returns True if the file is a text file and not a binary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000895
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000896 Deleted files are not text file."""
maruel@chromium.org1e08c002009-05-28 19:09:33 +0000897 raise NotImplementedError() # Implement when needed
898
agable0b65e732016-11-22 09:25:46 -0800899 def IsTextFile(self):
900 """An alias to IsTestableFile for backwards compatibility."""
901 return self.IsTestableFile()
902
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700903 def OldContents(self):
904 """Returns an iterator over the lines in the old version of file.
905
Daniel Cheng2da34fe2017-03-21 20:42:12 -0700906 The old version is the file before any modifications in the user's
Edward Lemura5799e32020-01-17 19:26:51 +0000907 workspace, i.e. the 'left hand side'.
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700908
909 Contents will be empty if the file is a directory or does not exist.
910 Note: The carriage returns (LF or CR) are stripped off.
911 """
912 return self._diff_cache.GetOldContents(self.LocalPath(),
913 self._local_root).splitlines()
914
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000915 def NewContents(self):
916 """Returns an iterator over the lines in the new version of file.
917
Edward Lemura5799e32020-01-17 19:26:51 +0000918 The new version is the file in the user's workspace, i.e. the 'right hand
919 side'.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000920
921 Contents will be empty if the file is a directory or does not exist.
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000922 Note: The carriage returns (LF or CR) are stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000923 """
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000924 if self._cached_new_contents is None:
925 self._cached_new_contents = []
agable0b65e732016-11-22 09:25:46 -0800926 try:
927 self._cached_new_contents = gclient_utils.FileRead(
928 self.AbsoluteLocalPath(), 'rU').splitlines()
929 except IOError:
930 pass # File not found? That's fine; maybe it was deleted.
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000931 return self._cached_new_contents[:]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000932
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000933 def ChangedContents(self):
934 """Returns a list of tuples (line number, line text) of all new lines.
935
936 This relies on the scm diff output describing each changed code section
937 with a line of the form
938
939 ^@@ <old line num>,<old size> <new line num>,<new size> @@$
940 """
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000941 if self._cached_changed_contents is not None:
942 return self._cached_changed_contents[:]
943 self._cached_changed_contents = []
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000944 line_num = 0
945
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000946 for line in self.GenerateScmDiff().splitlines():
Edward Lemurac5c55f2020-02-29 00:17:16 +0000947 m = re.match(r'^@@ [0-9\,\+\-]+ \+([0-9]+)\,[0-9]+ @@', line)
948 if m:
949 line_num = int(m.groups(1)[0])
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000950 continue
951 if line.startswith('+') and not line.startswith('++'):
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000952 self._cached_changed_contents.append((line_num, line[1:]))
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000953 if not line.startswith('-'):
954 line_num += 1
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000955 return self._cached_changed_contents[:]
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000956
maruel@chromium.org5de13972009-06-10 18:16:06 +0000957 def __str__(self):
958 return self.LocalPath()
959
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000960 def GenerateScmDiff(self):
nick@chromium.orgff526192013-06-10 19:30:26 +0000961 return self._diff_cache.GetDiff(self.LocalPath(), self._local_root)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000962
maruel@chromium.org58407af2011-04-12 23:15:57 +0000963
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000964class GitAffectedFile(AffectedFile):
965 """Representation of a file in a change out of a git checkout."""
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000966 # Method 'NNN' is abstract in class 'NNN' but is not overridden
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800967 # pylint: disable=abstract-method
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000968
nick@chromium.orgff526192013-06-10 19:30:26 +0000969 DIFF_CACHE = _GitDiffCache
970
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000971 def __init__(self, *args, **kwargs):
972 AffectedFile.__init__(self, *args, **kwargs)
973 self._server_path = None
agable0b65e732016-11-22 09:25:46 -0800974 self._is_testable_file = None
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000975
agable0b65e732016-11-22 09:25:46 -0800976 def IsTestableFile(self):
977 if self._is_testable_file is None:
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000978 if self.Action() == 'D':
agable0b65e732016-11-22 09:25:46 -0800979 # A deleted file is not testable.
980 self._is_testable_file = False
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000981 else:
agable0b65e732016-11-22 09:25:46 -0800982 self._is_testable_file = os.path.isfile(self.AbsoluteLocalPath())
983 return self._is_testable_file
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000984
maruel@chromium.orgc1938752011-04-12 23:11:13 +0000985
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000986class Change(object):
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000987 """Describe a change.
988
989 Used directly by the presubmit scripts to query the current change being
990 tested.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000991
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000992 Instance members:
nick@chromium.orgff526192013-06-10 19:30:26 +0000993 tags: Dictionary of KEY=VALUE pairs found in the change description.
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000994 self.KEY: equivalent to tags['KEY']
995 """
996
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000997 _AFFECTED_FILES = AffectedFile
998
Edward Lemura5799e32020-01-17 19:26:51 +0000999 # Matches key/value (or 'tag') lines in changelist descriptions.
maruel@chromium.org428342a2011-11-10 15:46:33 +00001000 TAG_LINE_RE = re.compile(
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001001 '^[ \t]*(?P<key>[A-Z][A-Z_0-9]*)[ \t]*=[ \t]*(?P<value>.*?)[ \t]*$')
maruel@chromium.orgc1938752011-04-12 23:11:13 +00001002 scm = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001003
maruel@chromium.org58407af2011-04-12 23:15:57 +00001004 def __init__(
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001005 self, name, description, local_root, files, issue, patchset, author,
1006 upstream=None):
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001007 if files is None:
1008 files = []
1009 self._name = name
chase@chromium.org8e416c82009-10-06 04:30:44 +00001010 # Convert root into an absolute path.
1011 self._local_root = os.path.abspath(local_root)
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001012 self._upstream = upstream
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001013 self.issue = issue
1014 self.patchset = patchset
maruel@chromium.org58407af2011-04-12 23:15:57 +00001015 self.author_email = author
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001016
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001017 self._full_description = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001018 self.tags = {}
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001019 self._description_without_tags = ''
1020 self.SetDescriptionText(description)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001021
maruel@chromium.orge085d812011-10-10 19:49:15 +00001022 assert all(
1023 (isinstance(f, (list, tuple)) and len(f) == 2) for f in files), files
1024
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001025 diff_cache = self._AFFECTED_FILES.DIFF_CACHE(self._upstream)
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001026 self._affected_files = [
nick@chromium.orgff526192013-06-10 19:30:26 +00001027 self._AFFECTED_FILES(path, action.strip(), self._local_root, diff_cache)
1028 for action, path in files
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +00001029 ]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001030
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001031 def Name(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001032 """Returns the change name."""
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001033 return self._name
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001034
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001035 def DescriptionText(self):
1036 """Returns the user-entered changelist description, minus tags.
1037
Edward Lemura5799e32020-01-17 19:26:51 +00001038 Any line in the user-provided description starting with e.g. 'FOO='
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001039 (whitespace permitted before and around) is considered a tag line. Such
1040 lines are stripped out of the description this function returns.
1041 """
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001042 return self._description_without_tags
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001043
1044 def FullDescriptionText(self):
1045 """Returns the complete changelist description including tags."""
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001046 return self._full_description
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001047
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001048 def SetDescriptionText(self, description):
1049 """Sets the full description text (including tags) to |description|.
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001050
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001051 Also updates the list of tags."""
1052 self._full_description = description
1053
1054 # From the description text, build up a dictionary of key/value pairs
Edward Lemura5799e32020-01-17 19:26:51 +00001055 # plus the description minus all key/value or 'tag' lines.
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001056 description_without_tags = []
1057 self.tags = {}
1058 for line in self._full_description.splitlines():
1059 m = self.TAG_LINE_RE.match(line)
1060 if m:
1061 self.tags[m.group('key')] = m.group('value')
1062 else:
1063 description_without_tags.append(line)
1064
1065 # Change back to text and remove whitespace at end.
1066 self._description_without_tags = (
1067 '\n'.join(description_without_tags).rstrip())
1068
Edward Lemur69bb8be2020-02-03 20:37:38 +00001069 def AddDescriptionFooter(self, key, value):
1070 """Adds the given footer to the change description.
1071
1072 Args:
1073 key: A string with the key for the git footer. It must conform to
1074 the git footers format (i.e. 'List-Of-Tokens') and will be case
1075 normalized so that each token is title-cased.
1076 value: A string with the value for the git footer.
1077 """
1078 description = git_footers.add_footer(
1079 self.FullDescriptionText(), git_footers.normalize_name(key), value)
1080 self.SetDescriptionText(description)
1081
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001082 def RepositoryRoot(self):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001083 """Returns the repository (checkout) root directory for this change,
1084 as an absolute path.
1085 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001086 return self._local_root
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001087
1088 def __getattr__(self, attr):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001089 """Return tags directly as attributes on the object."""
Edward Lemura5799e32020-01-17 19:26:51 +00001090 if not re.match(r'^[A-Z_]*$', attr):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001091 raise AttributeError(self, attr)
maruel@chromium.orge1a524f2009-05-27 14:43:46 +00001092 return self.tags.get(attr)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001093
Edward Lemur69bb8be2020-02-03 20:37:38 +00001094 def GitFootersFromDescription(self):
1095 """Return the git footers present in the description.
1096
1097 Returns:
1098 footers: A dict of {footer: [values]} containing a multimap of the footers
1099 in the change description.
1100 """
1101 return git_footers.parse_footers(self.FullDescriptionText())
1102
Aaron Gablefc03e672017-05-15 14:09:42 -07001103 def BugsFromDescription(self):
1104 """Returns all bugs referenced in the commit description."""
Aaron Gable12ef5012017-05-15 14:29:00 -07001105 tags = [b.strip() for b in self.tags.get('BUG', '').split(',') if b.strip()]
Caleb Rouleauc0546b92019-02-22 06:12:57 +00001106 footers = []
Edward Lemur69bb8be2020-02-03 20:37:38 +00001107 parsed = self.GitFootersFromDescription()
Dan Beam62954042019-10-03 21:20:33 +00001108 unsplit_footers = parsed.get('Bug', []) + parsed.get('Fixed', [])
Caleb Rouleauc0546b92019-02-22 06:12:57 +00001109 for unsplit_footer in unsplit_footers:
1110 footers += [b.strip() for b in unsplit_footer.split(',')]
Aaron Gable12ef5012017-05-15 14:29:00 -07001111 return sorted(set(tags + footers))
Aaron Gablefc03e672017-05-15 14:09:42 -07001112
1113 def ReviewersFromDescription(self):
1114 """Returns all reviewers listed in the commit description."""
Edward Lemura5799e32020-01-17 19:26:51 +00001115 # We don't support a 'R:' git-footer for reviewers; that is in metadata.
Aaron Gable12ef5012017-05-15 14:29:00 -07001116 tags = [r.strip() for r in self.tags.get('R', '').split(',') if r.strip()]
1117 return sorted(set(tags))
Aaron Gablefc03e672017-05-15 14:09:42 -07001118
1119 def TBRsFromDescription(self):
1120 """Returns all TBR reviewers listed in the commit description."""
Aaron Gable12ef5012017-05-15 14:29:00 -07001121 tags = [r.strip() for r in self.tags.get('TBR', '').split(',') if r.strip()]
1122 # TODO(agable): Remove support for 'Tbr:' when TBRs are programmatically
1123 # determined by self-CR+1s.
Edward Lemur69bb8be2020-02-03 20:37:38 +00001124 footers = self.GitFootersFromDescription().get('Tbr', [])
Aaron Gable12ef5012017-05-15 14:29:00 -07001125 return sorted(set(tags + footers))
Aaron Gablefc03e672017-05-15 14:09:42 -07001126
1127 # TODO(agable): Delete these once we're sure they're unused.
1128 @property
1129 def BUG(self):
1130 return ','.join(self.BugsFromDescription())
1131 @property
1132 def R(self):
1133 return ','.join(self.ReviewersFromDescription())
1134 @property
1135 def TBR(self):
1136 return ','.join(self.TBRsFromDescription())
1137
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001138 def AllFiles(self, root=None):
1139 """List all files under source control in the repo."""
1140 raise NotImplementedError()
1141
agable0b65e732016-11-22 09:25:46 -08001142 def AffectedFiles(self, include_deletes=True, file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001143 """Returns a list of AffectedFile instances for all files in the change.
1144
1145 Args:
1146 include_deletes: If false, deleted files will be filtered out.
sail@chromium.org5538e022011-05-12 17:53:16 +00001147 file_filter: An additional filter to apply.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001148
1149 Returns:
1150 [AffectedFile(path, action), AffectedFile(path, action)]
1151 """
Edward Lemurb9830242019-10-30 22:19:20 +00001152 affected = list(filter(file_filter, self._affected_files))
sail@chromium.org5538e022011-05-12 17:53:16 +00001153
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001154 if include_deletes:
1155 return affected
Edward Lemurb9830242019-10-30 22:19:20 +00001156 return list(filter(lambda x: x.Action() != 'D', affected))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001157
John Budorick16162372018-04-18 10:39:53 -07001158 def AffectedTestableFiles(self, include_deletes=None, **kwargs):
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +00001159 """Return a list of the existing text files in a change."""
1160 if include_deletes is not None:
Edward Lemura5799e32020-01-17 19:26:51 +00001161 warn('AffectedTeestableFiles(include_deletes=%s)'
1162 ' is deprecated and ignored' % str(include_deletes),
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +00001163 category=DeprecationWarning,
1164 stacklevel=2)
Edward Lemurb9830242019-10-30 22:19:20 +00001165 return list(filter(
1166 lambda x: x.IsTestableFile(),
1167 self.AffectedFiles(include_deletes=False, **kwargs)))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001168
agable0b65e732016-11-22 09:25:46 -08001169 def AffectedTextFiles(self, include_deletes=None):
1170 """An alias to AffectedTestableFiles for backwards compatibility."""
1171 return self.AffectedTestableFiles(include_deletes=include_deletes)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001172
agable0b65e732016-11-22 09:25:46 -08001173 def LocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001174 """Convenience function."""
agable0b65e732016-11-22 09:25:46 -08001175 return [af.LocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001176
agable0b65e732016-11-22 09:25:46 -08001177 def AbsoluteLocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001178 """Convenience function."""
agable0b65e732016-11-22 09:25:46 -08001179 return [af.AbsoluteLocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001180
1181 def RightHandSideLines(self):
Edward Lemura5799e32020-01-17 19:26:51 +00001182 """An iterator over all text lines in 'new' version of changed files.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001183
1184 Lists lines from new or modified text files in the change.
1185
1186 This is useful for doing line-by-line regex checks, like checking for
1187 trailing whitespace.
1188
1189 Yields:
1190 a 3 tuple:
1191 the AffectedFile instance of the current file;
1192 integer line number (1-based); and
1193 the contents of the line as a string.
1194 """
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +00001195 return _RightHandSideLinesImpl(
1196 x for x in self.AffectedFiles(include_deletes=False)
agable0b65e732016-11-22 09:25:46 -08001197 if x.IsTestableFile())
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001198
Jochen Eisingerd0573ec2017-04-13 10:55:06 +02001199 def OriginalOwnersFiles(self):
1200 """A map from path names of affected OWNERS files to their old content."""
1201 def owners_file_filter(f):
1202 return 'OWNERS' in os.path.split(f.LocalPath())[1]
1203 files = self.AffectedFiles(file_filter=owners_file_filter)
1204 return dict([(f.LocalPath(), f.OldContents()) for f in files])
1205
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001206
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001207class GitChange(Change):
1208 _AFFECTED_FILES = GitAffectedFile
maruel@chromium.orgc1938752011-04-12 23:11:13 +00001209 scm = 'git'
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +00001210
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001211 def AllFiles(self, root=None):
1212 """List all files under source control in the repo."""
1213 root = root or self.RepositoryRoot()
1214 return subprocess.check_output(
Aaron Gable7817f022017-12-12 09:43:17 -08001215 ['git', '-c', 'core.quotePath=false', 'ls-files', '--', '.'],
1216 cwd=root).splitlines()
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001217
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001218
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001219def ListRelevantPresubmitFiles(files, root):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001220 """Finds all presubmit files that apply to a given set of source files.
1221
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001222 If inherit-review-settings-ok is present right under root, looks for
1223 PRESUBMIT.py in directories enclosing root.
1224
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001225 Args:
1226 files: An iterable container containing file paths.
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001227 root: Path where to stop searching.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001228
1229 Return:
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001230 List of absolute paths of the existing PRESUBMIT.py scripts.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001231 """
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001232 files = [normpath(os.path.join(root, f)) for f in files]
1233
1234 # List all the individual directories containing files.
1235 directories = set([os.path.dirname(f) for f in files])
1236
1237 # Ignore root if inherit-review-settings-ok is present.
1238 if os.path.isfile(os.path.join(root, 'inherit-review-settings-ok')):
1239 root = None
1240
1241 # Collect all unique directories that may contain PRESUBMIT.py.
1242 candidates = set()
1243 for directory in directories:
1244 while True:
1245 if directory in candidates:
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001246 break
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001247 candidates.add(directory)
1248 if directory == root:
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001249 break
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001250 parent_dir = os.path.dirname(directory)
1251 if parent_dir == directory:
1252 # We hit the system root directory.
1253 break
1254 directory = parent_dir
1255
1256 # Look for PRESUBMIT.py in all candidate directories.
1257 results = []
1258 for directory in sorted(list(candidates)):
tobiasjsff061c02016-08-17 03:23:57 -07001259 try:
1260 for f in os.listdir(directory):
1261 p = os.path.join(directory, f)
1262 if os.path.isfile(p) and re.match(
1263 r'PRESUBMIT.*\.py$', f) and not f.startswith('PRESUBMIT_test'):
1264 results.append(p)
1265 except OSError:
1266 pass
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001267
tobiasjs2836bcf2016-08-16 04:08:16 -07001268 logging.debug('Presubmit files: %s', ','.join(results))
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001269 return results
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001270
1271
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001272class GetTryMastersExecuter(object):
1273 @staticmethod
1274 def ExecPresubmitScript(script_text, presubmit_path, project, change):
1275 """Executes GetPreferredTryMasters() from a single presubmit script.
1276
1277 Args:
1278 script_text: The text of the presubmit script.
1279 presubmit_path: Project script to run.
1280 project: Project name to pass to presubmit script for bot selection.
1281
1282 Return:
1283 A map of try masters to map of builders to set of tests.
1284 """
1285 context = {}
1286 try:
Raul Tambre09e64b42019-05-14 01:57:22 +00001287 exec(compile(script_text, 'PRESUBMIT.py', 'exec', dont_inherit=True),
1288 context)
Raul Tambre7c938462019-05-24 16:35:35 +00001289 except Exception as e:
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001290 raise PresubmitFailure('"%s" had an exception.\n%s'
1291 % (presubmit_path, e))
1292
1293 function_name = 'GetPreferredTryMasters'
1294 if function_name not in context:
1295 return {}
1296 get_preferred_try_masters = context[function_name]
1297 if not len(inspect.getargspec(get_preferred_try_masters)[0]) == 2:
1298 raise PresubmitFailure(
1299 'Expected function "GetPreferredTryMasters" to take two arguments.')
1300 return get_preferred_try_masters(project, change)
1301
1302
rmistry@google.com5626a922015-02-26 14:03:30 +00001303class GetPostUploadExecuter(object):
1304 @staticmethod
Edward Lemur016a0872020-02-04 22:13:28 +00001305 def ExecPresubmitScript(script_text, presubmit_path, gerrit_obj, change):
rmistry@google.com5626a922015-02-26 14:03:30 +00001306 """Executes PostUploadHook() from a single presubmit script.
1307
1308 Args:
1309 script_text: The text of the presubmit script.
1310 presubmit_path: Project script to run.
Edward Lemur016a0872020-02-04 22:13:28 +00001311 gerrit_obj: The GerritAccessor object.
rmistry@google.com5626a922015-02-26 14:03:30 +00001312 change: The Change object.
1313
1314 Return:
1315 A list of results objects.
1316 """
1317 context = {}
1318 try:
Raul Tambre09e64b42019-05-14 01:57:22 +00001319 exec(compile(script_text, 'PRESUBMIT.py', 'exec', dont_inherit=True),
1320 context)
Raul Tambre7c938462019-05-24 16:35:35 +00001321 except Exception as e:
rmistry@google.com5626a922015-02-26 14:03:30 +00001322 raise PresubmitFailure('"%s" had an exception.\n%s'
1323 % (presubmit_path, e))
1324
1325 function_name = 'PostUploadHook'
1326 if function_name not in context:
1327 return {}
1328 post_upload_hook = context[function_name]
1329 if not len(inspect.getargspec(post_upload_hook)[0]) == 3:
1330 raise PresubmitFailure(
1331 'Expected function "PostUploadHook" to take three arguments.')
Edward Lemur016a0872020-02-04 22:13:28 +00001332 return post_upload_hook(gerrit_obj, change, OutputApi(False))
rmistry@google.com5626a922015-02-26 14:03:30 +00001333
1334
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001335def _MergeMasters(masters1, masters2):
1336 """Merges two master maps. Merges also the tests of each builder."""
1337 result = {}
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001338 for (master, builders) in itertools.chain(masters1.items(),
1339 masters2.items()):
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001340 new_builders = result.setdefault(master, {})
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001341 for (builder, tests) in builders.items():
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001342 new_builders.setdefault(builder, set([])).update(tests)
1343 return result
1344
1345
1346def DoGetTryMasters(change,
1347 changed_files,
1348 repository_root,
1349 default_presubmit,
1350 project,
1351 verbose,
1352 output_stream):
1353 """Get the list of try masters from the presubmit scripts.
1354
1355 Args:
1356 changed_files: List of modified files.
1357 repository_root: The repository root.
1358 default_presubmit: A default presubmit script to execute in any case.
1359 project: Optional name of a project used in selecting trybots.
1360 verbose: Prints debug info.
1361 output_stream: A stream to write debug output to.
1362
1363 Return:
1364 Map of try masters to map of builders to set of tests.
1365 """
1366 presubmit_files = ListRelevantPresubmitFiles(changed_files, repository_root)
1367 if not presubmit_files and verbose:
Edward Lemura5799e32020-01-17 19:26:51 +00001368 output_stream.write('Warning, no PRESUBMIT.py found.\n')
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001369 results = {}
1370 executer = GetTryMastersExecuter()
1371
1372 if default_presubmit:
1373 if verbose:
Edward Lemura5799e32020-01-17 19:26:51 +00001374 output_stream.write('Running default presubmit script.\n')
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001375 fake_path = os.path.join(repository_root, 'PRESUBMIT.py')
1376 results = _MergeMasters(results, executer.ExecPresubmitScript(
1377 default_presubmit, fake_path, project, change))
1378 for filename in presubmit_files:
1379 filename = os.path.abspath(filename)
1380 if verbose:
Edward Lemura5799e32020-01-17 19:26:51 +00001381 output_stream.write('Running %s\n' % filename)
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001382 # Accept CRLF presubmit script.
1383 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1384 results = _MergeMasters(results, executer.ExecPresubmitScript(
1385 presubmit_script, filename, project, change))
1386
1387 # Make sets to lists again for later JSON serialization.
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001388 for builders in results.values():
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001389 for builder in builders:
1390 builders[builder] = list(builders[builder])
1391
1392 if results and verbose:
1393 output_stream.write('%s\n' % str(results))
1394 return results
1395
1396
rmistry@google.com5626a922015-02-26 14:03:30 +00001397def DoPostUploadExecuter(change,
Edward Lemur016a0872020-02-04 22:13:28 +00001398 gerrit_obj,
Edward Lemur6eb1d322020-02-27 22:20:15 +00001399 verbose):
rmistry@google.com5626a922015-02-26 14:03:30 +00001400 """Execute the post upload hook.
1401
1402 Args:
1403 change: The Change object.
Edward Lemur016a0872020-02-04 22:13:28 +00001404 gerrit_obj: The GerritAccessor object.
rmistry@google.com5626a922015-02-26 14:03:30 +00001405 verbose: Prints debug info.
rmistry@google.com5626a922015-02-26 14:03:30 +00001406 """
1407 presubmit_files = ListRelevantPresubmitFiles(
Edward Lemur6eb1d322020-02-27 22:20:15 +00001408 change.LocalPaths(), change.RepositoryRoot())
rmistry@google.com5626a922015-02-26 14:03:30 +00001409 if not presubmit_files and verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001410 sys.stdout.write('Warning, no PRESUBMIT.py found.\n')
rmistry@google.com5626a922015-02-26 14:03:30 +00001411 results = []
1412 executer = GetPostUploadExecuter()
1413 # The root presubmit file should be executed after the ones in subdirectories.
1414 # i.e. the specific post upload hooks should run before the general ones.
1415 # Thus, reverse the order provided by ListRelevantPresubmitFiles.
1416 presubmit_files.reverse()
1417
1418 for filename in presubmit_files:
1419 filename = os.path.abspath(filename)
1420 if verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001421 sys.stdout.write('Running %s\n' % filename)
rmistry@google.com5626a922015-02-26 14:03:30 +00001422 # Accept CRLF presubmit script.
1423 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1424 results.extend(executer.ExecPresubmitScript(
Edward Lemur016a0872020-02-04 22:13:28 +00001425 presubmit_script, filename, gerrit_obj, change))
rmistry@google.com5626a922015-02-26 14:03:30 +00001426
Edward Lemur6eb1d322020-02-27 22:20:15 +00001427 if not results:
1428 return 0
1429
1430 sys.stdout.write('\n')
1431 sys.stdout.write('** Post Upload Hook Messages **\n')
1432
1433 exit_code = 0
1434 for result in results:
1435 if result.fatal:
1436 exit_code = 1
1437 result.handle()
1438 sys.stdout.write('\n')
1439
1440 return exit_code
rmistry@google.com5626a922015-02-26 14:03:30 +00001441
1442
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001443class PresubmitExecuter(object):
Aaron Gable668c1d82018-04-03 10:19:16 -07001444 def __init__(self, change, committing, verbose,
Edward Lesmes8e282792018-04-03 18:50:29 -04001445 gerrit_obj, dry_run=None, thread_pool=None, parallel=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001446 """
1447 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001448 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001449 committing: True if 'git cl land' is running, False if 'git cl upload' is.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001450 gerrit_obj: provides basic Gerrit codereview functionality.
1451 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -04001452 parallel: if true, all tests reported via input_api.RunTests for all
1453 PRESUBMIT files will be run in parallel.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001454 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001455 self.change = change
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001456 self.committing = committing
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001457 self.gerrit = gerrit_obj
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001458 self.verbose = verbose
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001459 self.dry_run = dry_run
Daniel Cheng7227d212017-11-17 08:12:37 -08001460 self.more_cc = []
Edward Lesmes8e282792018-04-03 18:50:29 -04001461 self.thread_pool = thread_pool
1462 self.parallel = parallel
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001463
1464 def ExecPresubmitScript(self, script_text, presubmit_path):
1465 """Executes a single presubmit script.
1466
1467 Args:
1468 script_text: The text of the presubmit script.
1469 presubmit_path: The path to the presubmit file (this will be reported via
1470 input_api.PresubmitLocalPath()).
1471
1472 Return:
1473 A list of result objects, empty if no problems.
1474 """
thakis@chromium.orgc6ef53a2014-11-04 00:13:54 +00001475
chase@chromium.org8e416c82009-10-06 04:30:44 +00001476 # Change to the presubmit file's directory to support local imports.
1477 main_path = os.getcwd()
1478 os.chdir(os.path.dirname(presubmit_path))
1479
1480 # Load the presubmit script into context.
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001481 input_api = InputApi(self.change, presubmit_path, self.committing,
Aaron Gable668c1d82018-04-03 10:19:16 -07001482 self.verbose, gerrit_obj=self.gerrit,
Edward Lesmes8e282792018-04-03 18:50:29 -04001483 dry_run=self.dry_run, thread_pool=self.thread_pool,
1484 parallel=self.parallel)
Daniel Cheng7227d212017-11-17 08:12:37 -08001485 output_api = OutputApi(self.committing)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001486 context = {}
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001487 try:
Raul Tambre09e64b42019-05-14 01:57:22 +00001488 exec(compile(script_text, 'PRESUBMIT.py', 'exec', dont_inherit=True),
1489 context)
Raul Tambre7c938462019-05-24 16:35:35 +00001490 except Exception as e:
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001491 raise PresubmitFailure('"%s" had an exception.\n%s' % (presubmit_path, e))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001492
1493 # These function names must change if we make substantial changes to
1494 # the presubmit API that are not backwards compatible.
1495 if self.committing:
1496 function_name = 'CheckChangeOnCommit'
1497 else:
1498 function_name = 'CheckChangeOnUpload'
1499 if function_name in context:
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +01001500 try:
Daniel Cheng7227d212017-11-17 08:12:37 -08001501 context['__args'] = (input_api, output_api)
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +01001502 logging.debug('Running %s in %s', function_name, presubmit_path)
1503 result = eval(function_name + '(*__args)', context)
1504 logging.debug('Running %s done.', function_name)
Daniel Chengd36fce42017-11-21 21:52:52 -08001505 self.more_cc.extend(output_api.more_cc)
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +01001506 finally:
Edward Lemurb9830242019-10-30 22:19:20 +00001507 for f in input_api._named_temporary_files:
1508 os.remove(f)
1509 if not isinstance(result, (tuple, list)):
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001510 raise PresubmitFailure(
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001511 'Presubmit functions must return a tuple or list')
1512 for item in result:
1513 if not isinstance(item, OutputApi.PresubmitResult):
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001514 raise PresubmitFailure(
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001515 'All presubmit results must be of types derived from '
1516 'output_api.PresubmitResult')
1517 else:
1518 result = () # no error since the script doesn't care about current event.
1519
chase@chromium.org8e416c82009-10-06 04:30:44 +00001520 # Return the process to the original working directory.
1521 os.chdir(main_path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001522 return result
1523
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001524def DoPresubmitChecks(change,
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001525 committing,
1526 verbose,
maruel@chromium.orgb0dfd352009-06-10 14:12:54 +00001527 default_presubmit,
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001528 may_prompt,
Aaron Gable668c1d82018-04-03 10:19:16 -07001529 gerrit_obj,
Edward Lesmes8e282792018-04-03 18:50:29 -04001530 dry_run=None,
Debrian Figueroadd2737e2019-06-21 23:50:13 +00001531 parallel=False,
1532 json_output=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001533 """Runs all presubmit checks that apply to the files in the change.
1534
1535 This finds all PRESUBMIT.py files in directories enclosing the files in the
1536 change (up to the repository root) and calls the relevant entrypoint function
1537 depending on whether the change is being committed or uploaded.
1538
1539 Prints errors, warnings and notifications. Prompts the user for warnings
1540 when needed.
1541
1542 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001543 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001544 committing: True if 'git cl land' is running, False if 'git cl upload' is.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001545 verbose: Prints debug info.
maruel@chromium.org0ff1fab2009-05-22 13:08:15 +00001546 default_presubmit: A default presubmit script to execute in any case.
Quinten Yearsley516fe7f2016-12-14 11:50:18 -08001547 may_prompt: Enable (y/n) questions on warning or error. If False,
1548 any questions are answered with yes by default.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001549 gerrit_obj: provides basic Gerrit codereview functionality.
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001550 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -04001551 parallel: if true, all tests specified by input_api.RunTests in all
1552 PRESUBMIT files will be run in parallel.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001553
1554 Return:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001555 1 if presubmit checks failed or 0 otherwise.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001556 """
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001557 old_environ = os.environ
1558 try:
1559 # Make sure python subprocesses won't generate .pyc files.
1560 os.environ = os.environ.copy()
Edward Lemurb9830242019-10-30 22:19:20 +00001561 os.environ['PYTHONDONTWRITEBYTECODE'] = '1'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001562
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001563 if committing:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001564 sys.stdout.write('Running presubmit commit checks ...\n')
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001565 else:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001566 sys.stdout.write('Running presubmit upload checks ...\n')
Edward Lemurecc27072020-01-06 16:42:34 +00001567 start_time = time_time()
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001568 presubmit_files = ListRelevantPresubmitFiles(
agable0b65e732016-11-22 09:25:46 -08001569 change.AbsoluteLocalPaths(), change.RepositoryRoot())
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001570 if not presubmit_files and verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001571 sys.stdout.write('Warning, no PRESUBMIT.py found.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001572 results = []
Edward Lesmes8e282792018-04-03 18:50:29 -04001573 thread_pool = ThreadPool()
Edward Lemur7e3c67f2018-07-20 20:52:49 +00001574 executer = PresubmitExecuter(change, committing, verbose, gerrit_obj,
1575 dry_run, thread_pool, parallel)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001576 if default_presubmit:
1577 if verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001578 sys.stdout.write('Running default presubmit script.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001579 fake_path = os.path.join(change.RepositoryRoot(), 'PRESUBMIT.py')
1580 results += executer.ExecPresubmitScript(default_presubmit, fake_path)
1581 for filename in presubmit_files:
1582 filename = os.path.abspath(filename)
1583 if verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001584 sys.stdout.write('Running %s\n' % filename)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001585 # Accept CRLF presubmit script.
1586 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1587 results += executer.ExecPresubmitScript(presubmit_script, filename)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001588
Edward Lesmes8e282792018-04-03 18:50:29 -04001589 results += thread_pool.RunAsync()
1590
Edward Lemur6eb1d322020-02-27 22:20:15 +00001591 messages = {}
1592 should_prompt = False
1593 presubmits_failed = False
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001594 for result in results:
1595 if result.fatal:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001596 presubmits_failed = True
1597 messages.setdefault('ERRORS', []).append(result)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001598 elif result.should_prompt:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001599 should_prompt = True
1600 messages.setdefault('Warnings', []).append(result)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001601 else:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001602 messages.setdefault('Messages', []).append(result)
pam@chromium.orged9a0832009-09-09 22:48:55 +00001603
Edward Lemur6eb1d322020-02-27 22:20:15 +00001604 sys.stdout.write('\n')
1605 for name, items in messages.items():
1606 sys.stdout.write('** Presubmit %s **\n' % name)
1607 for item in items:
1608 item.handle()
1609 sys.stdout.write('\n')
pam@chromium.orged9a0832009-09-09 22:48:55 +00001610
Edward Lemurecc27072020-01-06 16:42:34 +00001611 total_time = time_time() - start_time
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001612 if total_time > 1.0:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001613 sys.stdout.write(
1614 'Presubmit checks took %.1fs to calculate.\n\n' % total_time)
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +00001615
Edward Lemur6eb1d322020-02-27 22:20:15 +00001616 if not should_prompt and not presubmits_failed:
1617 sys.stdout.write('Presubmit checks passed.\n')
1618 elif should_prompt:
1619 sys.stdout.write('There were presubmit warnings. ')
Quinten Yearsley516fe7f2016-12-14 11:50:18 -08001620 if may_prompt:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001621 presubmits_failed = not prompt_should_continue(
1622 'Are you sure you wish to continue? (y/N): ')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001623
Edward Lemur1dc66e12020-02-21 21:36:34 +00001624 if json_output:
1625 # Write the presubmit results to json output
1626 presubmit_results = {
1627 'errors': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001628 error.json_format()
1629 for error in messages.get('ERRORS', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001630 ],
1631 'notifications': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001632 notification.json_format()
1633 for notification in messages.get('Messages', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001634 ],
1635 'warnings': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001636 warning.json_format()
1637 for warning in messages.get('Warnings', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001638 ],
Edward Lemur6eb1d322020-02-27 22:20:15 +00001639 'more_cc': executer.more_cc,
Edward Lemur1dc66e12020-02-21 21:36:34 +00001640 }
1641
1642 gclient_utils.FileWrite(
1643 json_output, json.dumps(presubmit_results, sort_keys=True))
1644
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001645 global _ASKED_FOR_FEEDBACK
1646 # Ask for feedback one time out of 5.
1647 if (len(results) and random.randint(0, 4) == 0 and not _ASKED_FOR_FEEDBACK):
Edward Lemur6eb1d322020-02-27 22:20:15 +00001648 sys.stdout.write(
maruel@chromium.org1ce8e662014-01-14 15:23:00 +00001649 'Was the presubmit check useful? If not, run "git cl presubmit -v"\n'
1650 'to figure out which PRESUBMIT.py was run, then run git blame\n'
1651 'on the file to figure out who to ask for help.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001652 _ASKED_FOR_FEEDBACK = True
Edward Lemur6eb1d322020-02-27 22:20:15 +00001653
1654 return 1 if presubmits_failed else 0
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001655 finally:
1656 os.environ = old_environ
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001657
1658
Edward Lemur50984a62020-02-06 18:10:18 +00001659def _scan_sub_dirs(mask, recursive):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001660 if not recursive:
pgervais@chromium.orge57b09d2014-05-07 00:58:13 +00001661 return [x for x in glob.glob(mask) if x not in ('.svn', '.git')]
Lei Zhang9611c4c2017-04-04 01:41:56 -07001662
1663 results = []
1664 for root, dirs, files in os.walk('.'):
1665 if '.svn' in dirs:
1666 dirs.remove('.svn')
1667 if '.git' in dirs:
1668 dirs.remove('.git')
1669 for name in files:
1670 if fnmatch.fnmatch(name, mask):
1671 results.append(os.path.join(root, name))
1672 return results
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001673
1674
Edward Lemur50984a62020-02-06 18:10:18 +00001675def _parse_files(args, recursive):
tobiasjs2836bcf2016-08-16 04:08:16 -07001676 logging.debug('Searching for %s', args)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001677 files = []
1678 for arg in args:
Edward Lemur50984a62020-02-06 18:10:18 +00001679 files.extend([('M', f) for f in _scan_sub_dirs(arg, recursive)])
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001680 return files
1681
1682
Edward Lemur50984a62020-02-06 18:10:18 +00001683def _parse_change(parser, options):
1684 """Process change options.
1685
1686 Args:
1687 parser: The parser used to parse the arguments from command line.
1688 options: The arguments parsed from command line.
1689 Returns:
1690 A GitChange if the change root is a git repository, or a Change otherwise.
1691 """
1692 if options.files and options.all_files:
1693 parser.error('<files> cannot be specified when --all-files is set.')
1694
Edward Lesmes44ea3ff2020-02-05 00:14:30 +00001695 change_scm = scm.determine_scm(options.root)
Edward Lemur50984a62020-02-06 18:10:18 +00001696 if change_scm != 'git' and not options.files:
1697 parser.error('<files> is not optional for unversioned directories.')
1698
1699 if options.files:
1700 change_files = _parse_files(options.files, options.recursive)
1701 elif options.all_files:
1702 change_files = [('M', f) for f in scm.GIT.GetAllFiles(options.root)]
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001703 else:
Edward Lemur50984a62020-02-06 18:10:18 +00001704 change_files = scm.GIT.CaptureStatus(
Edward Lemur7f6dec02020-02-06 20:23:58 +00001705 options.root, options.upstream or None)
Edward Lemur50984a62020-02-06 18:10:18 +00001706
1707 logging.info('Found %d file(s).', len(change_files))
1708
1709 change_class = GitChange if change_scm == 'git' else Change
1710 return change_class(
1711 options.name,
1712 options.description,
1713 options.root,
1714 change_files,
1715 options.issue,
1716 options.patchset,
1717 options.author,
1718 upstream=options.upstream)
1719
1720
1721def _parse_gerrit_options(parser, options):
1722 """Process gerrit options.
1723
1724 SIDE EFFECTS: Modifies options.author and options.description from Gerrit if
1725 options.gerrit_fetch is set.
1726
1727 Args:
1728 parser: The parser used to parse the arguments from command line.
1729 options: The arguments parsed from command line.
1730 Returns:
1731 A GerritAccessor object if options.gerrit_url is set, or None otherwise.
1732 """
1733 gerrit_obj = None
1734 if options.gerrit_url:
1735 gerrit_obj = GerritAccessor(urlparse.urlparse(options.gerrit_url).netloc)
1736
1737 if not options.gerrit_fetch:
1738 return gerrit_obj
1739
1740 if not options.gerrit_url or not options.issue or not options.patchset:
1741 parser.error(
1742 '--gerrit_fetch requires --gerrit_url, --issue and --patchset.')
1743
1744 options.author = gerrit_obj.GetChangeOwner(options.issue)
1745 options.description = gerrit_obj.GetChangeDescription(
1746 options.issue, options.patchset)
1747
1748 logging.info('Got author: "%s"', options.author)
1749 logging.info('Got description: """\n%s\n"""', options.description)
1750
1751 return gerrit_obj
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001752
1753
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001754@contextlib.contextmanager
1755def canned_check_filter(method_names):
1756 filtered = {}
1757 try:
1758 for method_name in method_names:
1759 if not hasattr(presubmit_canned_checks, method_name):
Aaron Gableecee74c2018-04-02 15:13:08 -07001760 logging.warn('Skipping unknown "canned" check %s' % method_name)
1761 continue
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001762 filtered[method_name] = getattr(presubmit_canned_checks, method_name)
1763 setattr(presubmit_canned_checks, method_name, lambda *_a, **_kw: [])
1764 yield
1765 finally:
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001766 for name, method in filtered.items():
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001767 setattr(presubmit_canned_checks, name, method)
1768
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001769
sbc@chromium.org013731e2015-02-26 18:28:43 +00001770def main(argv=None):
Edward Lemura5799e32020-01-17 19:26:51 +00001771 parser = argparse.ArgumentParser(usage='%(prog)s [options] <files...>')
1772 hooks = parser.add_mutually_exclusive_group()
1773 hooks.add_argument('-c', '--commit', action='store_true',
1774 help='Use commit instead of upload checks.')
1775 hooks.add_argument('-u', '--upload', action='store_false', dest='commit',
1776 help='Use upload instead of commit checks.')
Edward Lemur75526302020-02-27 22:31:05 +00001777 hooks.add_argument('--post_upload', action='store_true',
1778 help='Run post-upload commit hooks.')
Edward Lemura5799e32020-01-17 19:26:51 +00001779 parser.add_argument('-r', '--recursive', action='store_true',
1780 help='Act recursively.')
1781 parser.add_argument('-v', '--verbose', action='count', default=0,
1782 help='Use 2 times for more debug info.')
1783 parser.add_argument('--name', default='no name')
1784 parser.add_argument('--author')
Edward Lemur227d5102020-02-25 23:45:35 +00001785 desc = parser.add_mutually_exclusive_group()
1786 desc.add_argument('--description', default='', help='The change description.')
1787 desc.add_argument('--description_file',
1788 help='File to read change description from.')
Edward Lemura5799e32020-01-17 19:26:51 +00001789 parser.add_argument('--issue', type=int, default=0)
1790 parser.add_argument('--patchset', type=int, default=0)
1791 parser.add_argument('--root', default=os.getcwd(),
1792 help='Search for PRESUBMIT.py up to this directory. '
1793 'If inherit-review-settings-ok is present in this '
1794 'directory, parent directories up to the root file '
1795 'system directories will also be searched.')
1796 parser.add_argument('--upstream',
1797 help='Git only: the base ref or upstream branch against '
1798 'which the diff should be computed.')
1799 parser.add_argument('--default_presubmit')
1800 parser.add_argument('--may_prompt', action='store_true', default=False)
1801 parser.add_argument('--skip_canned', action='append', default=[],
1802 help='A list of checks to skip which appear in '
1803 'presubmit_canned_checks. Can be provided multiple times '
1804 'to skip multiple canned checks.')
1805 parser.add_argument('--dry_run', action='store_true', help=argparse.SUPPRESS)
1806 parser.add_argument('--gerrit_url', help=argparse.SUPPRESS)
1807 parser.add_argument('--gerrit_fetch', action='store_true',
1808 help=argparse.SUPPRESS)
1809 parser.add_argument('--parallel', action='store_true',
1810 help='Run all tests specified by input_api.RunTests in '
1811 'all PRESUBMIT files in parallel.')
1812 parser.add_argument('--json_output',
1813 help='Write presubmit errors to json output.')
Edward Lemur1dc66e12020-02-21 21:36:34 +00001814 parser.add_argument('--all_files', action='store_true',
Edward Lemur50984a62020-02-06 18:10:18 +00001815 help='Mark all files under source control as modified.')
Edward Lemura5799e32020-01-17 19:26:51 +00001816 parser.add_argument('files', nargs='*',
1817 help='List of files to be marked as modified when '
1818 'executing presubmit or post-upload hooks. fnmatch '
1819 'wildcards can also be used.')
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001820
Edward Lemura5799e32020-01-17 19:26:51 +00001821 options = parser.parse_args(argv)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001822
Erik Staabcca5c492020-04-16 17:40:07 +00001823 log_level = logging.ERROR
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001824 if options.verbose >= 2:
Erik Staabcca5c492020-04-16 17:40:07 +00001825 log_level = logging.DEBUG
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001826 elif options.verbose:
Erik Staabcca5c492020-04-16 17:40:07 +00001827 log_level = logging.INFO
1828 log_format = ('[%(levelname).1s%(asctime)s %(process)d %(thread)d '
1829 '%(filename)s] %(message)s')
1830 logging.basicConfig(format=log_format, level=log_level)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001831
Edward Lemur227d5102020-02-25 23:45:35 +00001832 if options.description_file:
1833 options.description = gclient_utils.FileRead(options.description_file)
Edward Lemur50984a62020-02-06 18:10:18 +00001834 gerrit_obj = _parse_gerrit_options(parser, options)
1835 change = _parse_change(parser, options)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001836
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001837 try:
Edward Lemur75526302020-02-27 22:31:05 +00001838 if options.post_upload:
1839 return DoPostUploadExecuter(
1840 change,
1841 gerrit_obj,
1842 options.verbose)
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001843 with canned_check_filter(options.skip_canned):
Edward Lemur6eb1d322020-02-27 22:20:15 +00001844 return DoPresubmitChecks(
Edward Lemur50984a62020-02-06 18:10:18 +00001845 change,
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001846 options.commit,
1847 options.verbose,
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001848 options.default_presubmit,
1849 options.may_prompt,
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001850 gerrit_obj,
Edward Lesmes8e282792018-04-03 18:50:29 -04001851 options.dry_run,
Debrian Figueroadd2737e2019-06-21 23:50:13 +00001852 options.parallel,
1853 options.json_output)
Raul Tambre7c938462019-05-24 16:35:35 +00001854 except PresubmitFailure as e:
Raul Tambre80ee78e2019-05-06 22:41:05 +00001855 print(e, file=sys.stderr)
1856 print('Maybe your depot_tools is out of date?', file=sys.stderr)
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001857 return 2
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001858
1859
1860if __name__ == '__main__':
maruel@chromium.org35625c72011-03-23 17:34:02 +00001861 fix_encoding.fix_encoding()
sbc@chromium.org013731e2015-02-26 18:28:43 +00001862 try:
1863 sys.exit(main())
1864 except KeyboardInterrupt:
1865 sys.stderr.write('interrupted\n')
sergiybf8a3b382016-07-05 11:21:30 -07001866 sys.exit(2)